Values API: standardize parameters and return values

[babeltrace.git] / lib / trace-ir / attributes.c

diff --git a/lib/trace-ir/attributes.c b/lib/trace-ir/attributes.c
index 0b321e2eefcd161b888d1ab7dc62820627ee28a8..d1e644f914b2feb0203ad8c97f4e6dd5b7dbc39b 100644 (file)
--- a/lib/trace-ir/attributes.c
+++ b/lib/trace-ir/attributes.c
@@ -88,7 +88,6 @@ BT_HIDDEN
 const char *bt_attributes_get_field_name(struct bt_private_value *attr_obj,
                uint64_t index)
 {
-       int rc;
        const char *ret = NULL;
        struct bt_private_value *attr_field_obj = NULL;
        struct bt_private_value *attr_field_name_obj = NULL;
@@ -125,13 +124,8 @@ const char *bt_attributes_get_field_name(struct bt_private_value *attr_obj,
                goto end;
        }
 
-       rc = bt_value_string_get(
-               bt_value_borrow_from_private(attr_field_name_obj), &ret);
-       if (rc) {
-               BT_LOGE("Cannot get raw value from string value: value-addr=%p",
-                       attr_field_name_obj);
-               ret = NULL;
-       }
+       ret = bt_value_string_get(
+               bt_value_borrow_from_private(attr_field_name_obj));
 
 end:
        return ret;
@@ -195,7 +189,6 @@ struct bt_private_value *bt_attributes_borrow_field_by_name(
        }
 
        for (i = 0; i < attr_size; ++i) {
-               int ret;
                const char *field_name;
 
                value_obj = bt_private_value_array_borrow_element_by_index(
@@ -216,14 +209,8 @@ struct bt_private_value *bt_attributes_borrow_field_by_name(
                        goto error;
                }
 
-               ret = bt_value_string_get(
-                       bt_value_borrow_from_private(attr_field_name_obj),
-                       &field_name);
-               if (ret) {
-                       BT_LOGE("Cannot get raw value from string value: value-addr=%p",
-                               attr_field_name_obj);
-                       goto error;
-               }
+               field_name = bt_value_string_get(
+                       bt_value_borrow_from_private(attr_field_name_obj));
 
                if (!strcmp(field_name, name)) {
                        break;