Fix: null check after deref, use uninitialized or freed variable
authorMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Wed, 26 Jul 2017 16:02:56 +0000 (12:02 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Wed, 9 Aug 2017 18:05:11 +0000 (14:05 -0400)
commit2c212c058851bd675a5ff33ac0bff981458497be
tree7eb662066dc6682c6a1e8b86f12d6e014be635f9
parent9ec238a8ebb1176e7c8d7514163dd370459de789
Fix: null check after deref, use uninitialized or freed variable

Found by Coverity:

CID 1376179 (#1 of 1): Dereference before null check
(REVERSE_INULL)check_after_deref: Null-checking stream_state suggests
that it may be null, but it has already been dereferenced on all paths
leading to the check.

Reorganized this function so we clear the stream_state (set to NULL)
whenever we return success or error, so the caller don't end up using
uninitialized variable.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
lib/graph/iterator.c
This page took 0.024225 seconds and 4 git commands to generate.