From: Philippe Proulx Date: Fri, 3 May 2019 23:51:11 +0000 (-0400) Subject: tests/plugins/ctf/Makefile.am: do not set `TESTS` in this file X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=commitdiff_plain;h=684658b12aec270a06feb513a9d3119364b1252e tests/plugins/ctf/Makefile.am: do not set `TESTS` in this file We want the project's `make check` to continue even if specific tests fail, so we can't define `TESTS` in a subdirectory's `Makefile.am`, because if the test fails, `make` fails, and subsequent tests are not executed. There are ways to circumvent this, for example using `make`'s `--always-make` option, but it was decided previously that we want `make check` to run all tests as is, without any option. Therefore we set `TESTS` to all tests in `tests/Makefile.am`. To execute tests specific to a subdirectory, we have the following targets: * `check-bindings` * `check-cli` * `check-lib` * `check-plugins` * `check-python-plugin-provider` Signed-off-by: Philippe Proulx Change-Id: I1f198ff3ff2b44947042aee7fa5f01759874941f Reviewed-on: https://review.lttng.org/c/babeltrace/+/1254 Reviewed-by: Simon Marchi --- diff --git a/tests/Makefile.am b/tests/Makefile.am index 48598dc4..5bea8756 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -41,8 +41,10 @@ endif TESTS_PLUGINS = if !ENABLE_BUILT_IN_PLUGINS -if ENABLE_DEBUG_INFO if ENABLE_PYTHON_BINDINGS +TESTS_PLUGINS += plugins/ctf/test_ctf_plugin + +if ENABLE_DEBUG_INFO TESTS_PLUGINS += plugins/test_lttng_utils_debug_info endif endif diff --git a/tests/plugins/ctf/Makefile.am b/tests/plugins/ctf/Makefile.am index 7ea14a44..d10498ad 100644 --- a/tests/plugins/ctf/Makefile.am +++ b/tests/plugins/ctf/Makefile.am @@ -1,7 +1 @@ -if ENABLE_PYTHON_BINDINGS - -TESTS = test_ctf_plugin - -endif - dist_check_SCRIPTS = test_query_trace_info.py