From 9fde7203e6608f604218e69937f4fa8e20ac8459 Mon Sep 17 00:00:00 2001 From: Francis Deslauriers Date: Mon, 6 May 2019 14:50:50 -0400 Subject: [PATCH] Fix: lib/graph: Dereference before null checks MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit CID 1401244 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking graph->listeners.source_output_port_added suggests that it may be null, but it has already been dereferenced on all paths leading to the check. CID 1401260 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking graph->listeners.filter_output_port_added suggests that it may be null, but it has already been dereferenced on all paths leading to the check.k CID 1401243 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking graph->listeners.filter_input_port_added suggests that it may be null, but it has already been dereferenced on all paths leading to the check. CID 1401185 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking graph->listeners.sink_input_port_added suggests that it may be null, but it has already been dereferenced on all paths leading to the check. CID 1401262 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking graph->listeners.source_filter_ports_connected suggests that it may be null, but it has already been dereferenced on all paths leading to the check. CID 1401200 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking graph->listeners.filter_filter_ports_connected suggests that it may be null, but it has already been dereferenced on all paths leading to the check. CID 1401252 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking graph->listeners.source_sink_ports_connected suggests that it may be null, but it has already been dereferenced on all paths leading to the check. CID 1401264 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking graph->listeners.filter_sink_ports_connected suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Reported-by: Coverity (various ids) Dereference before null check Signed-off-by: Francis Deslauriers Change-Id: I88c8172e006e4bae2c7b5e29b501e1a36f19ae5c Reviewed-on: https://review.lttng.org/c/babeltrace/+/1262 Reviewed-by: Jérémie Galarneau --- lib/graph/graph.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/graph/graph.c b/lib/graph/graph.c index b43c35c6..2940355f 100644 --- a/lib/graph/graph.c +++ b/lib/graph/graph.c @@ -82,6 +82,9 @@ struct bt_graph_listener_ports_connected { do { \ size_t i; \ \ + if (!_listeners) { \ + break; \ + } \ for (i = 0; i < (_listeners)->len; i++) { \ _type *listener = \ &g_array_index((_listeners), _type, i); \ -- 2.34.1