tests: gen-ust-events: use options instead of arguments

[lttng-tools.git] / tests / utils / testapp / gen-ust-events / gen-ust-events.c

diff --git a/tests/utils/testapp/gen-ust-events/gen-ust-events.c b/tests/utils/testapp/gen-ust-events/gen-ust-events.c
index 1ce34423b330ab14cccf50597b2fa1d0e469148c..364545d5279e3fda785e566cf02115a3ccaccd9e 100644 (file)
--- a/tests/utils/testapp/gen-ust-events/gen-ust-events.c
+++ b/tests/utils/testapp/gen-ust-events/gen-ust-events.c
@@ -16,6 +16,7 @@
  */
 
 #define _LGPL_SOURCE
+#include <getopt.h>
 #include <assert.h>
 #include <arpa/inet.h>
 #include <fcntl.h>
@@ -37,9 +38,21 @@
 #define TRACEPOINT_DEFINE
 #include "tp.h"
 
+static struct option long_options[] =
+{
+       /* These options set a flag. */
+       {"iter", required_argument, 0, 'i'},
+       {"wait", required_argument, 0, 'w'},
+       {"sync-after-first-event", required_argument, 0, 'a'},
+       {"sync-before-last-event", required_argument, 0, 'b'},
+       {0, 0, 0, 0}
+};
+
 int main(int argc, char **argv)
 {
        unsigned int i, netint;
+       int option_index;
+       int option;
        long values[] = { 1, 2, 3 };
        char text[10] = "test";
        double dbl = 2.0;
@@ -49,29 +62,40 @@ int main(int argc, char **argv)
        char *after_first_event_file_path = NULL;
        char *before_last_event_file_path = NULL;
 
-       if (set_signal_handler()) {
-               ret = -1;
-               goto end;
-       }
-
-       if (argc >= 2) {
-               /*
-                * If nr_iter is negative, do an infinite tracing loop.
-                */
-               nr_iter = atoi(argv[1]);
+       while ((option = getopt_long(argc, argv, "i:w:a:b:c:d:",
+                       long_options, &option_index)) != -1) {
+               switch (option) {
+               case 'a':
+                       after_first_event_file_path = strdup(optarg);
+                       break;
+               case 'b':
+                       before_last_event_file_path = strdup(optarg);
+                       break;
+               case 'i':
+                       nr_iter = atoi(optarg);
+                       break;
+               case 'w':
+                       nr_usec = atoi(optarg);
+                       break;
+               case '?':
+                       /* getopt_long already printed an error message. */
+                       break;
+               default:
+                       ret = -1;
+                       goto end;
+               }
        }
 
-       if (argc >= 3) {
-               /* By default, don't wait unless user specifies. */
-               nr_usec = atoi(argv[2]);
+       if (optind != argc) {
+               fprintf(stderr, "Error: takes long options only.\n");
+               ret = -1;
+               goto end;
        }
 
-       if (argc >= 4) {
-               after_first_event_file_path = argv[3];
-       }
 
-       if (argc >= 5) {
-               before_last_event_file_path = argv[4];
+       if (set_signal_handler()) {
+               ret = -1;
+               goto end;
        }
 
        for (i = 0; nr_iter < 0 || i < nr_iter; i++) {
@@ -117,5 +141,7 @@ int main(int argc, char **argv)
        }
 
 end:
+       free(after_first_event_file_path);
+       free(before_last_event_file_path);
        exit(!ret ? EXIT_SUCCESS : EXIT_FAILURE);
 }