sim: mips: add printf attribute to trace func

This helps catch format errors in code, although they're all clean
at this point already.

diff --git a/sim/mips/ChangeLog b/sim/mips/ChangeLog
index c36e01fa19eb47286dad2ecea3ffea4977030f62..c582abc074479758a585c9fc1f75fba41f5234ae 100644 (file)
--- a/sim/mips/ChangeLog
+++ b/sim/mips/ChangeLog
@@ -1,3 +1,8 @@
+2021-06-16  Mike Frysinger  <vapier@gentoo.org>
+
+       * interp.c (dotrace): Make comment const.
+       * sim-main.h (dotrace):  Likewise.  Add ATTRIBUTE_PRINTF.
+
 2021-06-16  Mike Frysinger  <vapier@gentoo.org>
 
        * interp.c (sim_monitor): Change ap type to address_word*.

diff --git a/sim/mips/interp.c b/sim/mips/interp.c
index 5645f01ed2251c54e8dee4bc56ff1841f5448d10..a6f504acc764f4ea1004f74e76ea4f1de351b071 100644 (file)
--- a/sim/mips/interp.c
+++ b/sim/mips/interp.c
@@ -1722,7 +1722,7 @@ dotrace (SIM_DESC sd,
         int type,
         SIM_ADDR address,
         int width,
-        char *comment,...)
+        const char *comment, ...)
 {
   if (STATE & simTRACE) {
     va_list ap;

diff --git a/sim/mips/sim-main.h b/sim/mips/sim-main.h
index 8c9abfa0b0b32cce691c08510edc5379104c5330..990573996bb96ffa4ce6a84d7140bc0fc224e00f 100644 (file)
--- a/sim/mips/sim-main.h
+++ b/sim/mips/sim-main.h
@@ -965,7 +965,7 @@ address_word micromips_instruction_decode (SIM_DESC sd, sim_cpu * cpu,
                                           int instruction_size);
 
 #if WITH_TRACE_ANY_P
-void dotrace (SIM_DESC sd, sim_cpu *cpu, FILE *tracefh, int type, SIM_ADDR address, int width, char *comment, ...);
+void dotrace (SIM_DESC sd, sim_cpu *cpu, FILE *tracefh, int type, SIM_ADDR address, int width, const char *comment, ...) ATTRIBUTE_PRINTF (7, 8);
 extern FILE *tracefh;
 #else
 #define dotrace(sd, cpu, tracefh, type, address, width, comment, ...)