From 09fe663ed827474bfb73b78d0506cecdcd8ece9d Mon Sep 17 00:00:00 2001 From: Gary Benson Date: Thu, 28 May 2020 16:29:48 +0100 Subject: [PATCH] Pass -Wno-deprecated-register for gdb.cp that use "register" Clang fails to compile three testcases with the following error: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register] This prevents the following testcases from executing: gdb.cp/classes.exp gdb.cp/inherit.exp gdb.cp/misc.exp This commit builds those testcases with -Wno-deprecated-register, to avoid the failure. Note that this commit reveals five "wrong access specifier for typedef" failures in gdb.cp/classes.exp when compiling the testsuite with clang. gdb/testsuite/ChangeLog: * gdb.cp/classes.exp (prepare_for_testing): Add additional_flags=-Wno-deprecated-register. * gdb.cp/inherit.exp (prepare_for_testing): Likewise. * gdb.cp/misc.exp: Likewise. --- gdb/testsuite/ChangeLog | 7 +++++++ gdb/testsuite/gdb.cp/classes.exp | 3 ++- gdb/testsuite/gdb.cp/inherit.exp | 3 ++- gdb/testsuite/gdb.cp/misc.exp | 3 ++- 4 files changed, 13 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index d5554430bf..2349c96dfc 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2020-05-28 Gary Benson + + * gdb.cp/classes.exp (prepare_for_testing): Add + additional_flags=-Wno-deprecated-register. + * gdb.cp/inherit.exp (prepare_for_testing): Likewise. + * gdb.cp/misc.exp: Likewise. + 2020-05-28 Gary Benson * gdb.linespec/cpls-ops.cc (dummy): New static global. diff --git a/gdb/testsuite/gdb.cp/classes.exp b/gdb/testsuite/gdb.cp/classes.exp index beb471c371..4a2287a870 100644 --- a/gdb/testsuite/gdb.cp/classes.exp +++ b/gdb/testsuite/gdb.cp/classes.exp @@ -24,7 +24,8 @@ load_lib "cp-support.exp" standard_testfile .cc -if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { +if {[prepare_for_testing "failed to prepare" $testfile $srcfile \ + {debug c++ additional_flags=-Wno-deprecated-register}]} { return -1 } diff --git a/gdb/testsuite/gdb.cp/inherit.exp b/gdb/testsuite/gdb.cp/inherit.exp index 59c72da6ae..2d4635c96a 100644 --- a/gdb/testsuite/gdb.cp/inherit.exp +++ b/gdb/testsuite/gdb.cp/inherit.exp @@ -26,7 +26,8 @@ load_lib "cp-support.exp" standard_testfile misc.cc -if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { +if {[prepare_for_testing "failed to prepare" $testfile $srcfile \ + {debug c++ additional_flags=-Wno-deprecated-register}]} { return -1 } diff --git a/gdb/testsuite/gdb.cp/misc.exp b/gdb/testsuite/gdb.cp/misc.exp index cd6f0f7070..61034bf808 100644 --- a/gdb/testsuite/gdb.cp/misc.exp +++ b/gdb/testsuite/gdb.cp/misc.exp @@ -19,7 +19,8 @@ if { [skip_cplus_tests] } { continue } standard_testfile .cc -if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { +if {[prepare_for_testing "failed to prepare" $testfile $srcfile \ + {debug c++ additional_flags=-Wno-deprecated-register}]} { return -1 } -- 2.34.1