From 19e7491c85249200c9dcc438467ae127c2de88c7 Mon Sep 17 00:00:00 2001 From: Francis Deslauriers Date: Fri, 23 Aug 2019 11:38:03 -0700 Subject: [PATCH] Fix: sink.ctf.fs: dereference before NULL check CID 1404550 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking tsdl suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Reported-by: Coverity - Dereference before null check (REVERSE_INULL) Signed-off-by: Francis Deslauriers Change-Id: I7566cbd74529e93587079d163bb1691e420f723f Reviewed-on: https://review.lttng.org/c/babeltrace/+/1974 Tested-by: jenkins Reviewed-by: Simon Marchi Reviewed-by: Philippe Proulx --- src/plugins/ctf/fs-sink/fs-sink-trace.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/plugins/ctf/fs-sink/fs-sink-trace.c b/src/plugins/ctf/fs-sink/fs-sink-trace.c index d629d00d..16d9241a 100644 --- a/src/plugins/ctf/fs-sink/fs-sink-trace.c +++ b/src/plugins/ctf/fs-sink/fs-sink-trace.c @@ -545,9 +545,7 @@ void fs_sink_trace_destroy(struct fs_sink_trace *trace) trace->trace = NULL; g_free(trace); - if (tsdl) { - g_string_free(tsdl, TRUE); - } + g_string_free(tsdl, TRUE); end: return; -- 2.34.1