tests: use -z / -n to test for string empty / non-empty

[babeltrace.git] / tests / plugins / src.ctf.fs / fail / test_fail

diff --git a/tests/plugins/src.ctf.fs/fail/test_fail b/tests/plugins/src.ctf.fs/fail/test_fail
index 397c5e0233d4b60a1b15c4a38efe01ab680a237b..1c75a0d28a6391fafa48ffe390b6075cb908732d 100755 (executable)
--- a/tests/plugins/src.ctf.fs/fail/test_fail
+++ b/tests/plugins/src.ctf.fs/fail/test_fail
@@ -1,27 +1,16 @@
 #!/bin/bash
 #
-# Copyright (C) 2019 EfficiOS Inc.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License
-# as published by the Free Software Foundation; only version 2
-# of the License.
+# SPDX-License-Identifier: GPL-2.0-only
 #
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
+# Copyright (C) 2019 EfficiOS Inc.
 #
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 
 # This test validates that a `src.ctf.fs` component handles gracefully invalid
 # CTF traces and produces the expected error message.
 
 SH_TAP=1
 
-if [ "x${BT_TESTS_SRCDIR:-}" != "x" ]; then
+if [ -n "${BT_TESTS_SRCDIR:-}" ]; then
        UTILSSH="$BT_TESTS_SRCDIR/utils/utils.sh"
 else
        UTILSSH="$(dirname "$0")/../../../utils/utils.sh"
@@ -60,7 +49,7 @@ test_fail() {
 }
 
 
-plan_tests 8
+plan_tests 12
 
 test_fail \
        "invalid-packet-size/trace" \
@@ -72,4 +61,9 @@ test_fail \
        "${data_dir}/valid-events-then-invalid-events.expect" \
        "No event class with ID of event class ID to use in stream class: .*stream-class-id=0, event-class-id=255"
 
+test_fail \
+       "metadata-syntax-error" \
+       "/dev/null" \
+       "^  At line 3 in metadata stream: syntax error, unexpected CTF_RSBRAC: token=\"]\""
+
 rm -f "${stdout_file}" "${stderr_file}"