Fix: zero out URL parsing array before use and ensure proper error reporting
authorFrancis Deslauriers <francis.deslauriers@efficios.com>
Fri, 4 May 2018 16:07:34 +0000 (12:07 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Fri, 8 Jun 2018 15:30:17 +0000 (11:30 -0400)
commit340a47b8900142bf0bee9042c6595550c849bea4
treec2a8bb5ad1edab02258592acff7c26d2ed2b2741
parentd68a4daf85c73ab7d7070de0c98d0c170af4758e
Fix: zero out URL parsing array before use and ensure proper error reporting

The remain[2] array is being used uninitialized when such URI is used:
`net://localhost:1234`.
The following line (142) will return 1:
  `ret = sscanf(remain[0], ":%d%s", &ctx->port, remain[1]);`
because `sscanf` won't match on the string (%s) delimiter.
This will leave `remain[2]` uninitialized.

This potentially uninitialized array is being used further down the function.

As a fix, we zero out the array at initialization time to prevent the
`strlen(remain[2])` call from using uninitialized memory.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
formats/lttng-live/lttng-live-plugin.c
This page took 0.02686 seconds and 4 git commands to generate.