From: Francis Deslauriers Date: Thu, 24 Feb 2022 21:48:33 +0000 (-0500) Subject: Fix: ctf: wrongfully requiring CTF metadata signature for every section X-Git-Url: https://git.efficios.com/?p=babeltrace.git;a=commitdiff_plain;h=a4613497b7b8d3859c5ed4d6aa681eba60ab8efc Fix: ctf: wrongfully requiring CTF metadata signature for every section Issue ===== When testing the special live tracing session case of sending the metadata in multiple batches, we witnessed the CTF metadata decoder returning an error if the "/* CTF 1.8" signature is omitted from the metadata sections following the first one. Here is the output of Babeltrace when this error occurs: 07-22 12:18:38.518 539222 539222 W PLUGIN/CTF/META/DECODER ctf_metadata_decoder_append_content@decoder.c:242 [lttng-live] Missing "/* CTF major.minor" signature in plain text metadata file stream: mdec -addr=0x2398ec0 07-22 12:18:38.518 539222 539222 E PLUGIN/CTF/META/DECODER ctf_metadata_decoder_append_content@decoder.c:251 [lttng-live] Invalid metadata version found in plain text signature: version=571641920.0, md ec-addr=0x2398ec0 We expect the decoder to only require this signature when decoding the first section of plain-text metadata. Solution ======== Only check for the signature when processing the first metadata section. Signed-off-by: Francis Deslauriers Signed-off-by: Jérémie Galarneau Change-Id: I3153abf58ade5f5b02362dbedde382f398f5ee4e Reviewed-on: https://review.lttng.org/c/babeltrace/+/3807 --- diff --git a/src/plugins/ctf/common/metadata/decoder.cpp b/src/plugins/ctf/common/metadata/decoder.cpp index a45d7b03..740cbf05 100644 --- a/src/plugins/ctf/common/metadata/decoder.cpp +++ b/src/plugins/ctf/common/metadata/decoder.cpp @@ -41,6 +41,7 @@ struct ctf_metadata_decoder int bo; struct ctf_metadata_decoder_config config; struct meta_log_config log_cfg; + bool has_checked_plaintext_signature; }; struct packet_header @@ -221,7 +222,7 @@ ctf_metadata_decoder_append_content(struct ctf_metadata_decoder *mdec, FILE *fp) status = CTF_METADATA_DECODER_STATUS_ERROR; goto end; } - } else { + } else if (!mdec->has_checked_plaintext_signature) { unsigned int major, minor; ssize_t nr_items; const long init_pos = ftell(fp); @@ -263,6 +264,8 @@ ctf_metadata_decoder_append_content(struct ctf_metadata_decoder *mdec, FILE *fp) status = CTF_METADATA_DECODER_STATUS_ERROR; goto end; } + + mdec->has_checked_plaintext_signature = true; } #if YYDEBUG