Fix: missing parenthesis in offset_align_floor

Is currently unused. Triggers a compile error when used.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 1.1.2

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: remove logically dead code

CID 1021557 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line:
Execution cannot reach this statement "goto end;".

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: ctf.c fscanf missing integer length check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add Jérémie Galarneau as co-maintainer

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: disallow re-using same event ID in same stream

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: check for unknown enum/variant fields

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: libbabeltrace lib build dependencies

The "no-as-needed" is only needed for plugins, not for libraries we
depend upon, so it is not really needed here. Using LIBADD instead
ensures that libbabeltrace gets rebuilt whenever the content of
libbabeltrace_types (statically linked) is modified.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Be more widely accepting for missing variant/enum fields

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Refuse 0 integer size

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: read/write mode check

It's on the "prot" field, not flags. Moreover, it needs to be done with
a == / != comparison, not a mask.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: do not duplicate code in float fix

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: floats should set content size in tmp definition

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: test content size vs headers len

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: test for less than 1 byte packets

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: reversed logic in packet vs content size

As described in CTF section 5.2

"If the packet size field is missing, the whole stream only contains a
single packet. If the content size field is missing, the packet is
filled (no padding). The content and packet sizes include all headers."

Here is the correct semantic:

* Content size and packet size are available:

  Packet is filled with data up to content size, and then with padding
  up to packet size.

* Content size available, no packet size field:

  The stream has a single packet. It is filled up to content size, and
  the rest is padding.

* Packet size available, no content size field:

  Packet filled completely, no padding.

Fixes #683

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: clarify end of packet error

Fixes #686

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: string packet boundary handling, bits vs bytes

Fixes #684

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add stricter checks on packet boundaries

Fixes #699

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: fix typo

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: fail when reading 0 byte event

Rather than looping forever.

Fixes #685

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Take the iterator's end position into account

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Fix: Use the bt_iter_set_pos function to set the begin_pos

The current implementation of bt_iter_init asserts on begin_pos
that are not BT_SEEK_BEGIN. This uses the iterator set_pos function
to achieve the intended behavior.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Fix: Don't create a new packet if ctf_move_pos() seeks out of a packet

This change ensures that ctf_move_pos() does not create a new packet
when ctf_move_pos() moves out of the current packet's bounds. The next
call to ctf_pos_access_ok() will report EFAULT which can then be
handled appropriately by the caller.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Uninitialized ctf_stream_pos structure in ctf_float_write()

This structure is passed to _ctf_float_copy() which uses the
uninitialized mmap_offset and offset values to read the source
floating point value.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Use the packet's final size when mmap-ing the next packet

ctf_packet_seek() assumed that a packet would be of fixed size
"WRITE_PACKET_LEN" when seeking to the next packet in write mode.
This ensures that the real size used.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Close traces on context destruction

bt_trace_handle_destroy is called on destruction of the trace_handle
hash table's elements. This function only frees the trace handle,
leaving the input traces open.

This fix sets remove_trace_handle as the value_destroy_func ensuring
that the format's close_trace function is called before the trace_handle
is destroyed.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

gcc warning fix: -Wextra

For the "ordered comparison of pointer with integer zero" warning, fix
this by comparing (type) -1 against (type) 0 instead of just 0, so if
"type" is a pointer type, this pointer type will be applied to the right
operand too, thus fixing the warning.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Declare enum type to use from C++

Anonymous enum can't be referenced from C++. to fix this issue, declare enum
bt_iter_pos_type and use this type in struct bt_iter_pos.

Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Tests: fix string octal encoding

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix ctf_clock_declaration_visit returning an error when reading a boolean

The ret variable is used to read the "absolute" field's value and was
not reset to zero, thus returning an error whenever that value was TRUE.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix CTF parser hang with bison 3.0

Replace deprecated YYLEX_PARAM with %lex-param

See http://article.gmane.org/gmane.org.fsf.announce/2006 for details.

Tested with bison 2.5 and bison 3.0.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add missing lex/bison generated files to make clean

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Test for presence of bison and flex when building from git

Fixes #74

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Unchecked asprintf/vasprintf return values

strp·may·be·modified·even·in·case·of·failure·according·to·the
ASPRINTF(3) man page.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Missing NULL pointer init in tap.c

Could lead to free() of unitialized pointer.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Document: manpage: chronologically ordered events

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: comment mismatch with code

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: remove whitespaces at end of lines

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 1.1.1

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Compare traces by stream path as secondary key

Ensure runs of babeltrace in different environments give the same output
for the same trace collection. There are usually few events with the
same timestamp in a trace, so this secondary key comparison should not
be often required.

Fixes #540

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: use index, not cur_index, for SEEK_SET validation

Fixes #551

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: ctf-text irregular output with disabled field names

Fixes #532

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Support old compilers

Some old compilers do not use C99 as their default C language variant,
for example gcc 4.3.x, which is used on some old machines. When such a
compiler is used, by default, ULLONG_MAX is not visible. Adding
-std=gnu99 is needed to make this definition visible.

In autoconf speak, this translates into the need of using
AC_PROC_CC_STDC instead of AC_PROG_CC. See
http://www.gnu.org/software/autoconf/manual/autoconf-2.65/html_node/C-Compiler.html
for more details.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove useless variable assignment

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Remove extra quote after an include directive

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Don't dereference before NULL check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

eliminate dead code

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix babeltrace-log error checking

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix resource leak on error path

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: handle error checking should compare against NULL

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove unused array in bt_context_add_traces_recursive

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Suppress a compiler warning (always-false condition)

Clang reports an always-false condition (checking if an unsigned value <
0) caused by a type mismatch in ctf-visitor-generate-io-struct.c.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: remove trailing whitespaces

Reported-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Move memstream.h and uuid.h to include/babeltrace/compat directory

As preparation for a new compatibility layer, the files memstream.h
and uuid.h are moved to include/babeltrace/compat.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: handling of empty streams

Fixes #518

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add new option --clock-offset-ns

Add a new option --clock-offset-ns. It requires a parameter
that specifies a clock offset (in nanoseconds) that is added
to each timestamp.

This works exactly as the option --clock-offset, except that
the value is given in nanoseconds instead of full seconds.

The two options --clock-offset and --clock-offset-ns are
compatible with each other, and it's possible to give both.
For example, having the options

--clock-offset 2 --clock-offset-ns 1000000

means that 2.001 seconds is added to each timestamp.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing error return when create_event_definitions fails

Also add more verbose error printout to help identifying the culprit of
metadata issues.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: ctf-text should link on libbabeltrace-ctf

Refs: #410

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Move clock to bt_trace_descriptor

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove unused stream_heap

Now moved used within iterator structure (by prior commit).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Move trace collection pointer to bt_trace_descriptor

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Move bt_handle to bt_trace_descriptor

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Move bt_context to bt_trace_descriptor

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Privatize struct bt_trace descriptor, move trace path

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add backward ref from bt_stream_pos to bt_trace_descriptor

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix kFreeBSD build

Use general error numbers available on kFreeBSD.

Reported-by: Petr Salinger <Petr.Salinger@seznam.cz>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: babeltrace-log timestamps should be in nsec

Those were in usec, and babeltrace expect nsec by default for default
clock.

Most of the work has been focused on LTTng and read-side lately,
therefore babeltrace-log went under the radar.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use objstack for AST allocation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove unused gc field

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use objstack to store nodes

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use objstack for strings

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement objstack for parser

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: octal and hex string handling

Following C99:

Octal does not start by \o, but rather is in the form:

  \n \nn or \nnn

  where n is octal.

Hexadecimal is:

  \xH \xHH or \xHHH

  where H is hexadecimal.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Simplify error node

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Lexer cleanup

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: invalid integer suffix parsing

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Test cleanup

Remove unused binary file.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Test cleanup

Remove unused binary file.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Test cleanup

Remove unused binary files.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: bootstrap should call libtoolize

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix bootstrap script

Run autoreconf -i. Fix git repo initial bootstrap (needed to be run
twice).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use uint64_t for packet_map_len

packet_map_len is in bits, and we should use uint64_t to represent bits,
rather than size_t.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add smalltrace succeed/fail test cases

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Support packets and trace files smaller than page size

Fixes #450

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Move ctf-metadata plugin into its own shared object

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement ctf-metadata output plugin

Fixes #284

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Handle make_node errors with TLS dummy node

Neater than a segmentation fault when out of memory.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove nested expressions

Those are useless: the priorities are already known within the data
structure without those extra nodes.

Signed-off-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Eliminate dead code

This code is now unused after
commit d876a5baf224612e7e44d3cfda2dc1d57ea91ea4

Suggested-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: trace_collection_add() add after check

Fix segmentation fault by adding trace into trace collection only after
check for time correlation has succeeded.

Reported-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Handle integers in lexer rather than grammar

Signed-off-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement perror printf

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Support escape characters in metadata strings

Signed-off-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add error node to AST

Signed-off-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Introduce macro to enforce matching enum to string for node types

Signed-off-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add semantic check in grammar

Signed-off-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement likely/unlikely ifdefs

- don't redefine likely/unlikely on compilers already defining them,
- don't use builtins on compilers not supporting them.

Signed-off-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix unary constant use after error

Signed-off-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use new print macros in ctf-parser.y

Signed-off-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>