From 507d9140a9f7fba601a53b9ae210f82e8cc3f041 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Fri, 11 Mar 2022 12:03:35 -0500 Subject: [PATCH] sink.text.pretty: abort on unknown field class type I don't think there a legimitate case for the print_field function to encounter an invalid field class type. Change it to abort instead of returning an error. Change-Id: I333d2221b828841aff38a7d8b0a17032af3aafb1 Signed-off-by: Simon Marchi Reviewed-on: https://review.lttng.org/c/babeltrace/+/7580 Tested-by: jenkins Reviewed-by: Philippe Proulx Reviewed-on: https://review.lttng.org/c/babeltrace/+/7573 --- src/plugins/text/pretty/print.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/plugins/text/pretty/print.c b/src/plugins/text/pretty/print.c index a08235e8..4c7e1833 100644 --- a/src/plugins/text/pretty/print.c +++ b/src/plugins/text/pretty/print.c @@ -1311,11 +1311,9 @@ int print_field(struct pretty_component *pretty, } else if (bt_field_class_type_is(class_id, BT_FIELD_CLASS_TYPE_DYNAMIC_ARRAY)) { return print_sequence(pretty, field, print_names); - } else { - // TODO: log instead - fprintf(pretty->err, "[error] Unknown type id: %d\n", (int) class_id); - return -1; } + + bt_common_abort(); } static -- 2.34.1