projects / deliverable / binutils-gdb.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
Automatic date update in version.in
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
f2aec7f6
CB		 12019-09-11 Christian Biesinger <cbiesinger@google.com>
2
3 * auto-load.c (auto_load_expand_dir_vars): Update.
4 * defs.h (gdb_datadir): Change to std::string.
5 (python_libdir): Likewise.
6 (relocate_gdb_directory): Change return type to std::string.
7 * guile/guile.c (gdbscm_data_directory): Update.
8 (initialize_scheme_side): Update.
9 * jit.c (jit_reader_dir): Change to std::string.
10 (jit_reader_load_command): Update.
11 * main.c (gdb_datadir): Change to std::string.
12 (python_libdir): Likewise.
13 (set_gdb_data_directory): Update.
14 (relocate_path): Change to return std::string.
15 (relocate_gdb_directory): Change to return std::string.
16 (relocate_gdbinit_path_maybe_in_datadir): Update.
17 (captured_main_1): Update.
18 * python/python.c (do_start_initialization): Update.
19 * top.c (show_gdb_datadir): Update.
20 * xml-syscall.c (xml_init_syscalls_info): Update.
21 (init_syscalls_info): Update.
22
9224a013
CB		 232019-09-11 Christian Biesinger <cbiesinger@google.com>
24
25 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
26 out of get_init_files.
27 (get_init_files): Update.
28
f48cd836
CB		 292019-09-11 Christian Biesinger <cbiesinger@google.com>
30
31 * main.c (get_init_files): Change to use std::string.
32 (captured_main_1): Update.
33 (print_gdb_help): Update.
34
9cab7ecd
AT		 352019-09-11 Ali Tamur <tamur@google.com>
36
37 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
38 implementation.
39
67547d89
CB		 402019-09-11 Christian Biesinger <cbiesinger@google.com>
41
42 * dbxread.c (read_dbx_symtab): Update.
43 * dwarf2read.c (load_partial_dies): Update.
44 * mdebugread.c (parse_partial_symbols): Update.
45 (handle_psymbol_enumerators): Update.
46 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
47 * psymtab.c (add_psymbol_to_bcache): Likewise.
48 (add_psymbol_to_list): Likewise.
49 * symtab.c (symbol_set_names): Likewise.
50 * symtab.h (symbol_set_names): Likewise.
51 * xcoffread.c (scan_xcoff_symtab): Update.
52
64b2d4a0
TT		 532019-09-11 Tom Tromey <tom@tromey.com>
54
55 * symfile-mem.c (symbol_file_add_from_memory): Use
56 bfd_set_filename.
57 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
58 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
59
3b00ef10
TT		 602019-09-10 Tom Tromey <tromey@adacore.com>
61
62 * dwarf-index-write.c (write_psymbols): Extend error message.
63 (debug_names::insert): Add Ada code.
64 (debug_names::write_psymbols): Remove Ada check.
65 (debug_names) <m_string_obstack>: New member.
66 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
67 (gdb_index_symbol_name_matcher::matches): Remove.
68 (mapped_index_base::find_name_components_bounds): Add "lang"
69 parameter.
70 (mapped_index_base::build_name_components): Also split names
71 according to Ada syntax.
72 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
73 type of "match_callback".
74 (check_match, check_find_bounds_finds)
75 (dw2_expand_symtabs_matching): Update.
76 (dw2_debug_names_iterator): Add new constructor.
77 (dw2_debug_names_map_matching_symbols): New function.
78 (dw2_debug_names_expand_symtabs_matching): Update.
79 (dwarf2_debug_names_functions): Use
80 dw2_debug_names_map_matching_symbols.
81
aa391654
TT		 822019-09-10 Tom Tromey <tromey@adacore.com>
83
84 * dwarf2read.c (dw2_get_file_names_reader): Add the
85 CU's file name to the results.
86
b054970d
TT		 872019-09-10 Tom Tromey <tromey@adacore.com>
88
89 * ada-lang.c (add_nonlocal_symbols): Combine calls to
90 map_matching_symbols. Update.
91 * dwarf2read.c (dw2_map_matching_symbols): Update.
92 * psymtab.c (match_partial_symbol): Change type; update.
93 (psym_map_matching_symbols): Likewise.
94 * symfile-debug.c (debug_qf_map_matching_symbols): Change
95 type; update.
96 * symfile.h (struct quick_symbol_functions)
97 <map_matching_symbols>: Change "name" to be a lookup_name_info.
98 Remove "match".
99
6a3dbf1b
TT		 1002019-09-10 Tom Tromey <tromey@adacore.com>
101
102 * psymtab.c (map_block): Remove.
103 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
104 * symtab.c (iterate_over_symbols_terminated): New function.
105 * symtab.c (iterate_over_symbols_terminated): Declare.
106
6969f124
TT		 1072019-09-10 Tom Tromey <tromey@adacore.com>
108
109 * ada-lang.c (ada_iterate_over_symbols): Return bool.
110 * language.h (struct language_defn) <la_iterate_over_symbols>:
111 Return bool.
112 * symtab.c (iterate_over_symbols): Return bool.
113 * symtab.h (iterate_over_symbols): Return bool.
114
199b4314
TT		 1152019-09-10 Tom Tromey <tromey@adacore.com>
116
117 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
118 (add_nonlocal_symbols): Update.
119 * dwarf2read.c (dw2_map_matching_symbols): Change type.
120 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
121 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
122 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
123 Change type of "callback". Remove "data".
124
a084a2a6
AT		 125
1262019-09-09 Ali Tamur <tamur@google.com>
127
128 * dwarf2read.c (comp_unit_head): Update comment.
129 (dwarf2_dwo_name): New function declaration.
130 (dwarf_unit_type_name): New function declaration.
131 (read_comp_unit_head): Add support for new compilation units,
132 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
133 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
134 (currently named as "signature") in their header. Also clarify error
135 messages.
136 (lookup_dwo_id): New function. Returns the dwo id of the given
137 compile unit.
138 (lookup_dwo_unit): Use the new lookup_dwo_id function.
139 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
140 functions.
141 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
142 (dwarf2_dwo_name): Get the dwo name if present.
143 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
144 purposes.
145
25a2915e
TT		 1462019-09-09 Tom Tromey <tom@tromey.com>
147
148 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
149
e4df0874
PW		 1502019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
151
152 * python/python.c (do_start_initialization): Make progname_copy static,
153 to avoid a leak report.
154
8634b462
TT		 1552019-09-08 Tom Tromey <tom@tromey.com>
156
157 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
158
c7f839cb
SM		 1592019-09-07 Simon Marchi <simon.marchi@efficios.com>
160
161 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
162 Change type to gdb::optional<block_enum>.
163 (dw2_symtab_iter_init): Change block_index parameter type
164 to gdb::optional<block_enum>.
165 (dw2_lookup_symbol): Change block_index parameter
166 type to block_enum.c
167 (dw2_debug_names_lookup_symbol): Likewise.
168 * psymtab.c (psym_lookup_symbol): Likewise.
169 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
170 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
171 Likewise.
172
ead0e69a
CB		 1732019-09-06 Christian Biesinger <cbiesinger@google.com>
174
175 * defs.h (relocate_gdb_directory): Change int to bool in
176 signature and rename flag to relocatable.
177 * main.c (relocate_path): Likewise.
178 (relocate_gdb_directory): Likewise.
179
b16c44de
AM		 1802019-09-06 Alan Modra <amodra@gmail.com>
181
182 * coffread.c (coff_symfile_read): Constify filename variable.
183 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
184 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
185 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
186 * solib.c (reload_shared_libraries_1): Likewise.
187 * symfile.c (reread_symbols): Likewise.
188 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
189 * solib-darwin.c (darwin_bfd_open): Likewise.
190 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
191
06ff036e
AB		 1922019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
193
194 * psymtab.c (print_partial_symbols): Handle missing domain_enum
195 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
196
4e962e74
TT		 1972019-09-03 Tom Tromey <tromey@adacore.com>
198
199 * ada-valprint.c (ada_val_print_num): Don't recurse for range
200 types.
201 (has_negatives): Unbias a range type bound.
202 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
203 * gdbtypes.c (operator==): Handle new field.
204 (create_range_type): Add "bias" parameter.
205 (create_static_range_type, resolve_dynamic_range): Update.
206 * gdbtypes.h (struct range_bounds) <bias>: New member.
207 (create_range_type): Add bias parameter.
208 * printcmd.c (print_scalar_formatted): Unbias range types.
209 * value.c (unpack_long): Unbias range types.
210 (pack_long): Bias range types.
211
d90b8f26
AH		 2122019-09-02 Alan Hayward <alan.hayward@arm.com>
213
214 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
215 probe arguments.
216
fe01123e
AH		 2172019-09-02 Alan Hayward <alan.hayward@arm.com>
218
219 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
220 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
221 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
222 (compile_probe_arg): Likewise.
223 * probe.h (get_argument_count): Likewise.
224 * solib-svr4.c (solib_event_probe_action): Likewise.
225 * stap-probe.c (stap_probe::get_argument_count): Likewise.
226
e661ef01
AH		 2272019-09-02 Alan Hayward <alan.hayward@arm.com>
228
229 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
230 code to here...
231 (svr4_create_solib_event_breakpoints): ...from here.
232
47a536d9
SDJ		 2332019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
234
235 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
236 suffix from warning message.
237
d6a00eba
TT		 2382019-08-30 Tom Tromey <tom@tromey.com>
239
240 * tui/tui-winsource.h (struct tui_source_window_base)
241 <refresh_all>: Don't declare.
242 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
243 Remove.
244 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
245 tui_show_locator_content.
246 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
247 declare.
248 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
249 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
250 declare.
251
55b2657b
TT		 2522019-08-30 Tom Tromey <tom@tromey.com>
253
254 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
255
12a8555a
TT		 2562019-08-30 Tom Tromey <tom@tromey.com>
257
258 * tui/tui-stack.c (_initialize_tui_stack): Move later.
259 Remove unnecessary forward declarations.
260
900ac242
TT		 2612019-08-30 Tom Tromey <tom@tromey.com>
262
263 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
264 rerender.
265 (tui_update_locator_fullname, tui_show_frame_info): Don't call
266 tui_show_locator_content.
267
99ab33fb
TT		 2682019-08-30 Tom Tromey <tom@tromey.com>
269
270 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
271 (tui_locator_window::rerender): Rewrite using body of previous
272 tui_show_locator_content.
273
e594a5d1
TT		 2742019-08-30 Tom Tromey <tom@tromey.com>
275
276 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
277 set_locator_fullname>: New methods.
278 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
279 Rename from tui_set_locator_fullname.
280 (tui_locator_window::set_locator_info): Rename from
281 tui_set_locator_info. Return bool.
282 (tui_update_locator_fullname, tui_show_frame_info): Update.
283
715bb467
TT		 2842019-08-30 Tom Tromey <tom@tromey.com>
285
286 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
287
772f3f03
TT		 2882019-08-30 Tom Tromey <tom@tromey.com>
289
290 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
291 call touchwin.
292
108e13ab
TT		 2932019-08-30 Tom Tromey <tom@tromey.com>
294
295 * tui/tui-wingeneral.c (box_win): Assume win_info and
296 win_info->handle cannot be NULL.
297
cdaa6eb4
TT		 2982019-08-30 Tom Tromey <tom@tromey.com>
299
300 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
301 refresh_window>: Declare.
302 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
303 resize.
304 (tui_data_item_window::rerender): Rename from
305 tui_display_register.
306 (tui_data_item_window::refresh_window): New method.
307 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
308 no-op.
309
89df7f90
TT		 3102019-08-30 Tom Tromey <tom@tromey.com>
311
312 * tui/tui-regs.h (struct tui_data_window) <regs_content,
313 regs_column_count, current_group>: Move later. Now private.
314 <get_current_group>: New method.
315 * tui/tui-regs.c (tui_reg_command): Update.
316 * tui/tui-layout.c (tui_set_layout): Update.
317
1bf2866a
TT		 3182019-08-30 Tom Tromey <tom@tromey.com>
319
320 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
321 (tui_data_window::rerender): Don't call
322 check_and_display_highlight_if_needed.
323 (tui_data_window::refresh_all): Remove call to
324 erase_data_content.
325
0670413d
TT		 3262019-08-30 Tom Tromey <tom@tromey.com>
327
328 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
329 (tui_data_window::display_registers_from)
330 (tui_data_window::display_reg_element_at_line)
331 (tui_data_window::display_registers_from_line): Remove checks of
332 "empty".
333
18bb55c7
TT		 3342019-08-30 Tom Tromey <tom@tromey.com>
335
336 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
337 Don't declare.
338 * tui/tui-regs.c (tui_data_window::show_registers): Call
339 rerender.
340 (tui_data_window::rerender): Rename from display_all_data.
341 (tui_data_window::rerender): Remove old implementation.
342
1f6d2f10
TT		 3432019-08-30 Tom Tromey <tom@tromey.com>
344
345 * tui/tui-regs.c (tui_data_window::display_all_data): Change
346 text.
347 * tui/tui-data.h (NO_DATA_STRING): Remove define.
348
16d01f9c
BW		 3492019-08-29 Bernhard Wodok <barto@gmx.net>
350 Sergio Durigan Junior <sergiodj@redhat.com>
351
352 PR win32/24284
353 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
354
d8f27c60
AB		 3552019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
356
357 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
358 when searching for types.
359
1f20c35e
AB		 3602019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
361
362 * f-lang.c (f_language_defn): Use f_print_typedef.
363 * f-lang.h (f_print_typedef): Declare.
364 * f-typeprint.c (f_print_typedef): Define.
365
550105b7
CB		 3662019-08-27 Christian Biesinger <cbiesinger@google.com>
367
368 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
369
4acfdd20
AB		 3702019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
371
372 * cli/cli-utils.c (info_print_options_defs): Delete.
373 (make_info_print_options_def_group): Delete.
374 (extract_info_print_options): Delete.
375 (info_print_command_completer): Delete.
376 (info_print_args_help): Add extra parameter, and optionally
377 include text about -n flag.
378 * cli/cli-utils.h (struct info_print_options): Delete.
379 (extract_info_print_options): Delete declaration.
380 (info_print_command_completer): Delete declaration.
381 (info_print_args_help): Add extra parameter, extend header
382 comment.
383 * python/python.c (gdbpy_rbreak): Pass additional parameter to
384 search_symbols.
385 * stack.c (struct info_print_options): New type.
386 (info_print_options_defs): New file scoped variable.
387 (make_info_print_options_def_group): New static function.
388 (info_print_command_completer): New static function.
389 (info_locals_command): Update to use new local functions.
390 (info_args_command): Likewise.
391 (_initialize_stack): Add extra parameter to calls to
392 info_print_args_help.
393 * symtab.c (search_symbols): Add extra parameter, use this to
394 possibly excluse non-debug symbols.
395 (symtab_symbol_info): Add extra parameter, which is passed on to
396 search_symbols.
397 (struct info_print_options): New type.
398 (info_print_options_defs): New file scoped variable.
399 (make_info_print_options_def_group): New static function.
400 (info_print_command_completer): New static function.
401 (info_variables_command): Update to use local functions, and pass
402 extra parameter through to symtab_symbol_info.
403 (info_functions_command): Likewise.
404 (info_types_command): Pass additional argument through to
405 symtab_symbol_info.
406 (rbreak_command): Pass extra argument to search_symbols.
407 (_initialize_symtab): Add extra arguments for calls to
408 info_print_args_help, and update help text for 'info variables',
409 'whereis', and 'info functions' commands.
410 * symtab.h (search_symbols): Add extra argument to declaration.
411 * NEWS: Mention new flags.
412
9aa55206
CB		 4132019-08-26 Christian Biesinger <cbiesinger@google.com>
414
415 * symtab.c (lookup_static_symbol): Call the new function (and move
416 it down to be next to lookup_global_symbol).
417 (struct global_sym_lookup_data): Add block_enum member and rename to...
418 (struct global_or_static_sym_lookup_data): ...this.
419 (lookup_symbol_global_iterator_cb): Pass block_index instead of
420 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
421 (lookup_symbol_global_or_static_iterator_cb): ...this.
422 (lookup_global_or_static_symbol): New function.
423 (lookup_global_symbol): Call new function.
424
5c31b358
TV		 4252019-08-26 Tom de Vries <tdevries@suse.de>
426
427 PR c++/24852
428 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
429 when pc_probe.prob == NULL.
430
23c13d42
SM		 4312019-08-25 Simon Marchi <simon.marchi@efficios.com>
432
433 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
434 variable symbol_linkage to symbol_linkage_.
435
beadd3e8
SM		 4362019-08-25 Simon Marchi <simon.marchi@efficios.com>
437
438 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
439 represent whether the symbol is static, dynamic, or we don't
440 know.
441
e3ec872f
YS		 4422019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
443
444 * gdb/rx-tdep.c (rx_register_names): New.
445 (rx_register_name): Delete.
446 (rx_psw_type): Delete.
447 (rx_fpsw_type): Delete.
448 (rx_register_type): Delete.
449 (rx_gdbarch_init): Convert target-descriptions.
450 (_initialize_rx_tdep): Add initialize_tdesc_rx.
451 * gdb/features/Makefile: Add rx.xml.
452 * gdb/features/rx.xml: New.
453 * gdb/features/rx.c: Generated.
454 * gdb/NEWS: Mention target description support.
455
d0509ba4
CB		 4562019-08-22 Christian Biesinger <cbiesinger@google.com>
457
458 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
459 *slot_ptr.
460
2d41fa11
SDJ		 4612019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
462
463 * configure.ac: Don't check for 'dlfcn.h' (moved to
464 gdbsupport/common.m4).
465 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
466 'gdbsupport/'.
467 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
468 * compile/compile-c-support.c: Include
469 'gdbsupport/gdb-dlfcn.h'.
470 * gdbsupport/common.m4: Check for 'dlfcn.h'.
471 * gdb-dlfcn.c: Move to...
472 * gdbsupport/gdb-dlfcn.c: ... here.
473 * gdb-dlfcn.h: Move to...
474 * gdbsupport/gdb-dlfcn.h: ... here.
475
de8af808
SL		 4762019-08-23 Sandra Loosemore <sandra@codesourcery.com>
477
478 * nios2-tdep.c (struct reg_value): Improve comments. Make
479 the offset field signed.
480
27204489
CB		 4812019-08-22 Christian Biesinger <cbiesinger@google.com>
482
483 * python/lib/gdb/__init__.py (_execute_file): New function.
484 * python/python.c (python_run_simple_file): Call gdb._execute_file
485 on Windows.
486
43771869
AB		 4872019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
488
489 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
490 all uses as this was never set to anything but a zero value.
491
26c957f1
PA		 4922019-08-21 Bogdan Harjoc <harjoc@gmail.com>
493
494 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
495
c07aae6e
CB		 4962019-08-21 Christian Biesinger <cbiesinger@google.com>
497
498 * tui/tui-data.h (tui_gen_win_info): Add an =default
499 move constructor, required by some GCC versions.
500
3960cb7a
JF		 5012019-08-21 Jinke Fan <fanjinke51@yeah.net>
502
503 * go32-nat.c (go32_sysinfo): Add hygon_p.
504
04c72a68
TT		 5052019-08-20 Tom Tromey <tom@tromey.com>
506
507 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
508 line_from_reg_element_no, first_reg_element_no_inline,
509 display_all_data, delete_data_content_windows,
510 erase_data_content>: Now private.
511
072272ce
TT		 5122019-08-20 Tom Tromey <tom@tromey.com>
513
514 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
515 (tui_unhighlight_win, tui_highlight_win)
516 (tui_win_info::make_window): Update.
517 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
518
973961bd
TT		 5192019-08-20 Tom Tromey <tom@tromey.com>
520
521 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
522 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
523 (MAX_PID_WIDTH): Move to tui-stack.c.
524 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
525 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
526 (MAX_PID_WIDTH): Move from tui-data.h.
527
ab0e1f1a
TT		 5282019-08-20 Tom Tromey <tom@tromey.com>
529
530 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
531 * tui/tui-wingeneral.c (box_win): Change type of win_info.
532 (box_win): Update.
533 (tui_gen_win_info::make_window): Rename from tui_make_window.
534 (tui_win_info::make_window): New method.
535 (tui_gen_win_info::make_visible): Update.
536 * tui/tui-source.c (tui_source_window::set_contents): Update.
537 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
538 (tui_data_window::display_registers_from): Update.
539 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
540 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
541 Declare.
542 <can_box>: Remove.
543 <title>: Remove.
544 (struct tui_win_info) <make_window>: Declare.
545 <can_box>: Now virtual.
546 <title>: New member.
547 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
548 * tui/tui-command.c (tui_cmd_window::resize): Update.
549
100c2bf3
TT		 5502019-08-20 Tom Tromey <tom@tromey.com>
551
552 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
553 * tui/tui-regs.c (tui_data_window::show_registers): Update.
554 (tui_data_window::check_register_values): Update.
555
fa4dc567
TT		 5562019-08-20 Tom Tromey <tom@tromey.com>
557
558 * tui/tui-regs.h (struct tui_data_window): Use
559 DISABLE_COPY_AND_ASSIGN.
560 <regs_content>: Change type, removing unique_ptr.
561 <tui_data_window>: Add move constructor.
562 * tui/tui-regs.c (tui_data_window::show_registers)
563 (tui_data_window::show_register_group)
564 (tui_data_window::display_registers_from)
565 (tui_data_window::display_registers_from)
566 (tui_data_window::first_data_item_displayed)
567 (tui_data_window::delete_data_content_windows)
568 (tui_data_window::rerender, tui_data_window::refresh_window)
569 (tui_data_window::check_register_values): Update.
570
ca02d7c8
TT		 5712019-08-20 Tom Tromey <tom@tromey.com>
572
573 * tui/tui-regs.h (struct tui_data_window) <show_registers,
574 show_register_group>: Declare.
575 (tui_show_register_group): Don't declare.
576 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
577 tui_show_registers.
578 (tui_data_window::show_register_group): Rename from
579 tui_show_register_group.
580 (tui_data_window::check_register_values, tui_reg_command):
581 Update.
582 * tui/tui-layout.c (tui_set_layout): Update.
583
63356bfd
TT		 5842019-08-20 Tom Tromey <tom@tromey.com>
585
586 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
587 Declare.
588 (tui_check_register_values): Don't declare.
589 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
590 from tui_check_register_values.
591 * tui/tui-hooks.c (tui_register_changed): Update.
592
42cc14a7
TT		 5932019-08-20 Tom Tromey <tom@tromey.com>
594
595 * tui/tui-regs.c (tui_reg_layout): Move later.
596 (tui_show_registers): Don't enable TUI mode or change layout.
597
b9ad3686
TT		 5982019-08-20 Tom Tromey <tom@tromey.com>
599
600 * tui/tui-regs.h (struct tui_data_item_window)
601 <~tui_data_item_window>: Remove.
602 <content>: Now a unique_xmalloc_ptr.
603 * tui/tui-regs.c (tui_register_format): Return a
604 unique_xmalloc_ptr.
605 (tui_get_register): Update.
606 (~tui_data_item_window): Remove.
607 (tui_data_window::display_registers_from, tui_display_register):
608 Update.
609 * tui/tui-io.h (tui_expand_tabs): Update.
610 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
611 Remove "col" parameter.
612
8e114aab
TT		 6132019-08-20 Tom Tromey <tom@tromey.com>
614
615 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
616 field.
617 * tui/tui-regs.c (~tui_data_item_window): Update.
618
1a4f81dd
TT		 6192019-08-20 Tom Tromey <tom@tromey.com>
620
621 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
622 earlier.
623
0f8d8876
TT		 6242019-08-20 Tom Tromey <tom@tromey.com>
625
626 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
627
605dc2c2
TT		 6282019-08-20 Tom Tromey <tom@tromey.com>
629
630 * tui/tui-source.h (struct tui_source_window): Update.
631 * tui/tui-regs.c (tui_show_registers): Update.
632 * tui/tui-disasm.h (struct tui_disasm_window): Update.
633 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
634 (NO_REGS_STRING): Remove defines.
635
aedbe3bb
CM		 6362019-08-20 Conrad Meyer <cem@FreeBSD.org>
637
638 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
639 unnecessary thread walk if remote doesn't support the packet.
640
7ce8f214
TT		 6412019-08-19 Tom Tromey <tromey@adacore.com>
642
643 * python/py-value.c (value_has_field): Fix indentation.
644
f21c2bd7
TT		 6452019-08-19 Tom Tromey <tromey@adacore.com>
646
647 * printcmd.c (do_one_display, info_display_command): Update.
648 * block.h (contained_in): Return bool. Add allow_nested
649 parameter.
650 * block.c (contained_in): Return bool. Add allow_nested
651 parameter.
652
d806ea2d
TT		 6532019-08-19 Tom Tromey <tom@tromey.com>
654
655 * configure: Rebuild.
656 * configure.ac: Disallow the combination of -static-libstdc++ and
657 source highlight.
658 * source-cache.c (get_language_name): Handle rust.
659 (source_cache::get_source_lines): Ignore highlighting exceptions.
660
398fdd60
TT		 6612019-08-16 Tom Tromey <tom@tromey.com>
662
663 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
664 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
665 (struct tui_source_window_base) <make_visible, refresh_window,
666 resize>: Remove methods.
667 <execution_info>: Remove field.
668 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
669 (tui_show_source_line, tui_source_window_base)
670 (~tui_source_window_base): Update.
671 (tui_source_window_base::resize)
672 (tui_source_window_base::make_visible)
673 (tui_source_window_base::refresh_window): Remove.
674 (tui_source_window_base::update_exec_info): Update.
675 * tui/tui-source.c (tui_source_window::set_contents): Update.
676 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
677
e699d331
TT		 6782019-08-16 Tom Tromey <tom@tromey.com>
679
680 * tui/tui-hooks.c (tui_remove_hooks): Don't set
681 deprecated_query_hook.
682
bb01dbfc
TT		 6832019-08-16 Tom Tromey <tom@tromey.com>
684
685 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
686 (tui_update_source_windows_with_line): Update.
687 * tui/tui-source.h (struct tui_source_window)
688 <show_symtab_source>: Declare.
689 (tui_show_symtab_source): Don't declare.
690 * tui/tui-source.c (tui_show_symtab_source): Rename from
691 tui_show_symtab_source.
692
81c82c4b
TT		 6932019-08-16 Tom Tromey <tom@tromey.com>
694
695 * tui/tui-winsource.h (struct tui_source_window_base)
696 <set_contents>: Declare.
697 * tui/tui-winsource.c
698 (tui_source_window_base::update_source_window_as_is): Update.
699 * tui/tui-source.h (struct tui_source_window) <set_contents>:
700 Declare.
701 (tui_set_source_content): Don't declare.
702 * tui/tui-source.c (tui_source_window::set_contents): Rename from
703 tui_set_source_content.
704 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
705 Declare.
706 (tui_set_disassem_content): Don't declare.
707 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
708 tui_set_disassem_content.
709
2ddaf614
TT		 7102019-08-16 Tom Tromey <tom@tromey.com>
711
712 * tui/tui-winsource.h (struct tui_source_window_base)
713 <update_breakpoint_info>: Declare.
714 (tui_update_breakpoint_info): Don't declare.
715 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
716 (tui_update_all_breakpoint_info): Update.
717 (tui_source_window_base::update_breakpoint_info): Rename from
718 tui_update_breakpoint_info.
719 (tui_source_window_base::update_exec_info): Update.
720
017f9828
TT		 7212019-08-16 Tom Tromey <tom@tromey.com>
722
723 * tui/tui-winsource.h (struct tui_source_window_base)
724 <update_source_window>: Declare.
725 (tui_update_source_window): Don't declare.
726 * tui/tui-winsource.c
727 (tui_source_window_base::update_source_window): Rename from
728 tui_update_source_window.
729 (tui_source_window_base::rerender): Update.
730 * tui/tui-source.c (tui_source_window::maybe_update): Update.
731 * tui/tui-disasm.c (tui_show_disassem)
732 (tui_show_disassem_and_update_source)
733 (tui_disasm_window::maybe_update): Update.
734
ed8358e9
TT		 7352019-08-16 Tom Tromey <tom@tromey.com>
736
737 * tui/tui-winsource.h (struct tui_source_window_base)
738 <update_source_window_as_is>: Declare.
739 (tui_update_source_window_as_is): Don't declare.
740 * tui/tui-winsource.c (tui_update_source_window): Update
741 (tui_source_window_base::update_source_window_as_is): Rename from
742 tui_update_source_window_as_is.
743 (tui_source_window_base::refill): Update.
744 * tui/tui-source.c (tui_show_symtab_source): Update.
745 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
746 Update.
747
20149b6b
TT		 7482019-08-16 Tom Tromey <tom@tromey.com>
749
750 * tui/tui-winsource.h (tui_update_source_window)
751 (tui_update_source_window_as_is): Remove "noerror" parameter.
752 * tui/tui-winsource.c (tui_update_source_window)
753 (tui_update_source_window_as_is): Remove "noerror" parameter.
754 (tui_update_source_windows_with_addr)
755 (tui_update_source_windows_with_line)
756 (tui_source_window_base::rerender)
757 (tui_source_window_base::refill): Update.
758 * tui/tui-source.h (tui_set_source_content)
759 (tui_show_symtab_source): Remove "noerror" parameter.
760 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
761 parameter.
762 (tui_show_symtab_source): Likewise.
763 (tui_source_window::maybe_update): Update.
764 * tui/tui-disasm.c (tui_show_disassem)
765 (tui_show_disassem_and_update_source)
766 (tui_disasm_window::do_scroll_vertical)
767 (tui_disasm_window::maybe_update): Update.
768
2d83e710
TT		 7692019-08-16 Tom Tromey <tom@tromey.com>
770
771 * tui/tui.c (tui_is_window_visible): Update.
772 * tui/tui-wingeneral.c (tui_make_window)
773 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
774 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
775 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
776 (tui_set_win_height_command, parse_scrolling_args): Update.
777 * tui/tui-source.c (tui_source_window::style_changed): Update.
778 * tui/tui-regs.c (tui_show_registers)
779 (tui_data_window::first_data_item_displayed)
780 (tui_data_window::delete_data_content_windows)
781 (tui_check_register_values, tui_reg_command): Update.
782 * tui/tui-disasm.c (tui_show_disassem): Update.
783 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
784 method.
785 <is_visible>: Remove field.
786 * tui/tui-data.c (tui_next_win, tui_prev_win)
787 (tui_delete_invisible_windows): Update.
788
d4ab829a
TT		 7892019-08-16 Tom Tromey <tom@tromey.com>
790
791 * tui/tui-winsource.h (struct tui_source_window_base)
792 <m_has_locator>: Remove.
793 * tui/tui-layout.c (show_source_disasm_command, show_data)
794 (show_source_or_disasm_and_command): Update.
795
aa7ca1bb
AH		 7962019-08-16 Alan Hayward <alan.hayward@arm.com>
797
798 * NEWS (Other MI changes): New subsection.
799 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
800 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
801 * arch-utils.c (default_get_pc_address_flags): New function.
802 * arch-utils.h (default_get_pc_address_flags): New declaration.
803 * gdbarch.sh: Add get_pc_address_flags.
804 * gdbarch.c: Regenerate.
805 * gdbarch.h: Likewise.
806 * stack.c (print_pc): New function.
807 (print_frame_info) (print_frame): Call print_pc.
808
6eac171f
TV		 8092019-08-16 Tom de Vries <tdevries@suse.de>
810
811 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
812 print_objfile_section_info.
813
3df505f6
TT		 8142019-08-15 Tom Tromey <tom@tromey.com>
815
816 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
817 calling update_cmdwin_start_line.
818 * tui/tui-winsource.h (struct tui_source_window_base)
819 <do_make_visible_with_new_height, set_new_height>: Don't declare.
820 <rerender>: Declare.
821 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
822 Call rerender.
823 (tui_source_window_base::set_new_height): Remove.
824 (tui_source_window_base::rerender): Rename from
825 do_make_visible_with_new_height.
826 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
827 resize method.
828 (tui_win_info::make_invisible_and_set_new_height)
829 (tui_win_info::make_visible_with_new_height): Remove.
830 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
831 Declare.
832 * tui/tui-stack.c (tui_locator_window::rerender): New method.
833 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
834 do_make_visible_with_new_height>: Don't declare.
835 <rerender>: Declare.
836 * tui/tui-regs.c (tui_data_window::rerender): Rename from
837 set_new_height.
838 (tui_data_window::do_make_visible_with_new_height): Remove.
839 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
840 call tui_show_locator_content.
841 (tui_gen_win_info::resize): Call rerender.
842 (show_source_or_disasm_and_command): Don't call
843 tui_show_locator_content.
844 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
845 method.
846 (struct tui_win_info) <rerender>: Declare.
847 <set_new_height, make_invisible_and_set_new_height,
848 make_visible_with_new_height>: Don't declare.
849 * tui/tui-data.c (tui_win_list::rerender): New method.
850 * tui/tui-command.h (struct tui_cmd_window)
851 <do_make_visible_with_new_height>: Don't declare.
852 * tui/tui-command.c
853 (tui_cmd_window::do_make_visible_with_new_height): Remove.
854
272560b5
TT		 8552019-08-15 Tom Tromey <tromey@adacore.com>
856
857 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
858 * ada-lang.c (ada_enum_name): Likewise.
859
08235187
CB		 8602019-08-15 Christian Biesinger <cbiesinger@google.com>
861
862 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
863 leading underscore.
864 (GdbOutputErrorFile): Likewise.
865 (global scope): Adjust constructor calls to GdbOutput{,Error}File
866 accordingly.
867 (execute_unwinders): Rename to have a leading underscore.
868 (auto_load_packages): Likewise.
869 (global scope): Adjust call to auto_load_packages accordingly.
870 (GdbSetPythonDirectory): Likewise.
871 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
872 instead of execute_unwinders.
873
db502012
TT		 8742019-08-15 Tom Tromey <tom@tromey.com>
875
876 * tui/tui-layout.c (show_layout, show_source_disasm_command)
877 (show_data): Don't change window visibility.
878 (tui_gen_win_info::resize): Remove special case for command
879 window. Use wresize, when available.
880 (show_source_or_disasm_and_command): Don't change window
881 visibility.
882 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
883 <make_visible>: New method.
884 * tui/tui-command.c (tui_cmd_window::resize): New method.
885
3891b65e
TT		 8862019-08-15 Tom Tromey <tom@tromey.com>
887
888 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
889 (struct tui_source_windows): New.
890 * tui/tui-winsource.c (tui_display_main): Update.
891 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
892 (new_height_ok, parse_scrolling_args): Update.
893 * tui/tui-layout.c (show_layout, show_data): Update.
894 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
895 (tui_add_to_source_windows): Don't declare.
896 * tui/tui-data.c (source_windows, tui_source_windows)
897 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
898
ee556432
TT		 8992019-08-15 Tom Tromey <tom@tromey.com>
900
901 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
902 Rename from reset.
903 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
904 * tui/tui-layout.c (show_source_disasm_command, show_data):
905 Update.
906 (tui_gen_win_info::resize): Rename.
907 (show_source_or_disasm_and_command): Update.
908 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
909 reset.
910
46f438e3
TT		 9112019-08-15 Tom Tromey <tom@tromey.com>
912
913 * tui/tui-stack.c (tui_initialize_static_data): Remove.
914 * tui/tui-interp.c (tui_interp::init): Don't call
915 tui_initialize_static_data.
916 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
917
f4ce562c
TT		 9182019-08-15 Tom Tromey <tom@tromey.com>
919
920 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
921 examine tui_win_list.
922
c398c3d0
TT		 9232019-08-15 Tom Tromey <tom@tromey.com>
924
925 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
926 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
927 tui_clear_source_content.
928 (tui_clear_source_content): Remove.
929 (tui_source_window_base::do_erase_source_content): Hoist call to
930 content.clear().
931 * tui/tui-stack.c (tui_show_frame_info): Don't call
932 tui_clear_source_content.
933
e25d2004
TT		 9342019-08-15 Tom Tromey <tom@tromey.com>
935
936 * tui/tui-winsource.h (struct tui_source_window_base)
937 <do_erase_source_content>: New method.
938 <erase_source_content>: New method.
939 (tui_erase_source_content): Don't declare.
940 * tui/tui-winsource.c (tui_clear_source_content): Update.
941 (tui_source_window_base::do_erase_source_content): Rename from
942 tui_erase_source_content.
943 (tui_source_window_base::show_source_content): Update.
944 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
945 * tui/tui-source.h (struct tui_source_window)
946 <erase_source_content>: New method.
947 * tui/tui-disasm.h (struct tui_disasm_window)
948 <erase_source_content>: New method.
949
002f15c2
TT		 9502019-08-15 Tom Tromey <tom@tromey.com>
951
952 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
953 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
954 constructor.
955 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
956 * tui/tui-source.c (tui_set_source_content): Update.
957 * tui/tui-disasm.c (tui_set_disassem_content): Update.
958
c9033fe8
TT		 9592019-08-15 Tom Tromey <tom@tromey.com>
960
961 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
962 * tui/tui-winsource.c (tui_line_is_displayed): Move to
963 tui-source.c.
964 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
965 Declare.
966 * tui/tui-source.c (tui_source_window::line_is_displayed): New
967 method.
968 (tui_source_window::maybe_update): Update.
969
088f37dd
TT		 9702019-08-15 Tom Tromey <tom@tromey.com>
971
972 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
973 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
974 tui-disasm.c.
975 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
976 Declare.
977 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
978 method.
979 (tui_disasm_window::maybe_update): Update.
980
a54700c6
TT		 9812019-08-15 Tom Tromey <tom@tromey.com>
982
983 * tui/tui-winsource.h (struct tui_source_window_base)
984 <maybe_update>: Declare.
985 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
986 method.
987 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
988 Declare.
989 * tui/tui-source.c (tui_source_window::maybe_update): New method.
990 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
991 Declare.
992 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
993
e2a678a5
TT		 9942019-08-15 Tom Tromey <tom@tromey.com>
995
996 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
997
f2dda477
TT		 9982019-08-15 Tom Tromey <tom@tromey.com>
999
1000 * tui/tui-wingeneral.c: Include tui-stack.h.
1001 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1002 (struct tui_locator_window): Move from tui-data.h.
1003 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1004 (tui_initialize_static_data): Move from tui-data.c.
1005 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1006 (struct tui_locator_window): Move to tui-stack.c.
1007 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1008 (tui_initialize_static_data): Move to tui-stack.c.
1009
ed4a1084
TT		 10102019-08-15 Tom Tromey <tom@tromey.com>
1011
1012 * tui/tui-layout.c (show_source_disasm_command)
1013 (show_source_or_disasm_and_command): Use make_visible method, not
1014 tui_make_window.
1015 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1016 Remove.
1017
65962b20
TT		 10182019-08-15 Tom Tromey <tom@tromey.com>
1019
1020 * tui/tui-wingeneral.h (tui_make_window): Update.
1021 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1022 parameter.
1023 (tui_gen_win_info::make_visible): Update.
1024 * tui/tui-regs.c (tui_data_window::display_registers_from):
1025 Update.
1026 * tui/tui-layout.c (show_source_disasm_command)
1027 (show_source_or_disasm_and_command): Update.
1028 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1029 (enum tui_box): Remove.
1030 (struct tui_win_info) <can_box>: New method.
1031 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1032 method.
1033
2208ee91
TV		 10342019-08-15 Tom de Vries <tdevries@suse.de>
1035
1036 * linux-nat-trad.c: Include gdbarch.h.
1037
75faf5c4
AH		 10382019-08-14 Alan Hayward <alan.hayward@arm.com>
1039
1040 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1041 register sizes.
1042
b1c896b3
TT		 10432019-08-14 Tom Tromey <tromey@adacore.com>
1044
1045 * darwin-nat.c: Include gdbarch.h.
1046 * darwin-nat-info.c: Include gdbarch.h.
1047
6405cd73
TT		 10482019-08-13 Tom Tromey <tom@tromey.com>
1049
1050 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1051 Remove.
1052 * tui/tui-data.c (tui_initialize_static_data): Update.
1053
5216580d
TT		 10542019-08-13 Tom Tromey <tom@tromey.com>
1055
1056 * tui/tui-winsource.h (struct tui_exec_info_window)
1057 <~tui_exec_info_window, maybe_allocate_content, get_content,
1058 m_content>: Remove.
1059 (struct tui_source_window_base) <set_exec_info_content,
1060 show_exec_info_content>: Don't declare.
1061 * tui/tui-winsource.c
1062 (tui_exec_info_window::maybe_allocate_content): Remove.
1063 (tui_source_window_base::update_exec_info): Rename from
1064 set_exec_info_content.
1065 (tui_source_window_base::show_exec_info_content)
1066 (tui_source_window_base::update_exec_info): Remove.
1067
93858ad3
TT		 10682019-08-13 Tom Tromey <tom@tromey.com>
1069
1070 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1071 declare.
1072 * tui/tui-winsource.c (tui_update_source_window_as_is)
1073 (tui_update_source_windows_with_addr, tui_erase_source_content):
1074 Update.
1075 (tui_clear_exec_info_content): Remove.
1076
e321e7ce
TT		 10772019-08-13 Tom Tromey <tom@tromey.com>
1078
1079 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1080 declare.
1081 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1082 call tui_erase_exec_info_content.
1083 (tui_clear_exec_info_content): Rename from
1084 tui_erase_exec_info_content.
1085 (tui_clear_exec_info_content): Delete.
1086
8270ac62
TT		 10872019-08-13 Tom Tromey <tom@tromey.com>
1088
1089 * tui/tui-winsource.h (struct tui_source_window_base)
1090 <show_exec_info_content>: Declare.
1091 (tui_show_exec_info_content): Don't declare.
1092 * tui/tui-winsource.c
1093 (tui_source_window_base::show_exec_info_content): Rename from
1094 tui_show_exec_info_content.
1095 (tui_source_window_base::update_exec_info): Update.
1096
7b56485d
TT		 10972019-08-13 Tom Tromey <tom@tromey.com>
1098
1099 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1100 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1101 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1102 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1103 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1104 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1105 ... here.
1106
7ba913dc
TT		 11072019-08-13 Tom Tromey <tom@tromey.com>
1108
1109 * tui/tui-winsource.h (struct tui_source_window_base)
1110 <update_exec_info>: Declare.
1111 (tui_update_exec_info): Don't declare.
1112 * tui/tui-winsource.c (tui_update_source_window_as_is)
1113 (tui_source_window_base::refresh_all)
1114 (tui_update_all_breakpoint_info): Update.
1115 (tui_source_window_base::update_exec_info): Rename from
1116 tui_update_exec_info.
1117 * tui/tui-stack.c (tui_show_frame_info): Update.
1118
37a4a131
TT		 11192019-08-13 Tom Tromey <tom@tromey.com>
1120
1121 * tui/tui-winsource.h (struct tui_source_window_base)
1122 <set_exec_info_content>: Declare.
1123 (tui_set_exec_info_content): Don't declare.
1124 * tui/tui-winsource.c
1125 (tui_source_window_base::set_exec_info_content): Rename from
1126 tui_set_exec_info_content.
1127 (tui_update_exec_info): Update.
1128
0bd27e07
TT		 11292019-08-13 Tom Tromey <tom@tromey.com>
1130
1131 * tui/tui-winsource.h (struct tui_source_window_base)
1132 <show_source_content>: Declare.
1133 (tui_show_source_content): Don't declare.
1134 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1135 (tui_source_window_base::show_source_content): Rename from
1136 tui_show_source_content.
1137 (tui_source_window_base::refresh_all): Update.
1138 * tui/tui-layout.c (show_source_disasm_command)
1139 (show_source_or_disasm_and_command): Update.
1140
b4ef5aeb
TT		 11412019-08-13 Tom Tromey <tom@tromey.com>
1142
1143 * tui/tui-winsource.c (tui_erase_source_content)
1144 (tui_show_source_content, tui_source_window_base::refresh_all):
1145 Update.
1146 * tui/tui-wingeneral.h
1147 (tui_check_and_display_highlight_if_needed): Don't declare.
1148 * tui/tui-wingeneral.c
1149 (tui_win_info::check_and_display_highlight_if_needed): Rename from
1150 check_and_display_highlight_if_needed.
1151 * tui/tui-win.c (tui_rehighlight_all)
1152 (tui_win_info::make_visible_with_new_height): Update.
1153 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1154 (tui_data_window::erase_data_content)
1155 (tui_data_window::display_all_data): Update.
1156 * tui/tui-data.h (struct tui_win_info)
1157 <check_and_display_highlight_if_needed>: Declare.
1158
fede5273
TT		 11592019-08-13 Tom Tromey <tom@tromey.com>
1160
1161 * tui/tui-win.c (tui_resize_all): Call
1162 tui_delete_invisible_windows.
1163 * tui/tui-layout.c (show_layout): Call
1164 tui_delete_invisible_windows.
1165 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1166 * tui/tui-data.c (tui_delete_invisible_windows): New function.
1167
22c3f490
TT		 11682019-08-13 Tom Tromey <tom@tromey.com>
1169
1170 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
1171 tui_add_win_to_layout.
1172
16cb7910
TT		 11732019-08-13 Tom Tromey <tom@tromey.com>
1174
1175 * tui/tui-layout.h (tui_default_win_height): Don't declare.
1176 * tui/tui-layout.c (tui_default_win_height): Now static.
1177
cc0c3ffb
TT		 11782019-08-13 Tom Tromey <tom@tromey.com>
1179
1180 * tui/tui-layout.c (show_layout): Unify all layout cases into a
1181 single switch.
1182 (show_source_disasm_command, show_source_or_disasm_and_command):
1183 Don't check current layout.
1184
3f3ffe54
TT		 11852019-08-13 Tom Tromey <tom@tromey.com>
1186
1187 * tui/tui-wingeneral.c (make_all_visible): Remove.
1188 (tui_make_all_invisible): Simplify.
1189 * tui/tui-layout.c (tui_make_all_invisible): Move from
1190 tui-wingeneral.c; simplify.
1191 (show_layout): Hoist call to tui_make_all_invisible.
1192 (show_data): Don't call tui_make_all_invisible.
1193
69258091
TT		 11942019-08-13 Tom Tromey <tom@tromey.com>
1195
1196 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1197 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1198
62cf57fe
TT		 11992019-08-13 Tom Tromey <tom@tromey.com>
1200
1201 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1202 tui-data.c.
1203 (show_source_disasm_command, show_data)
1204 (show_source_or_disasm_and_command): Don't use
1205 tui_set_current_layout_to.
1206 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1207 * tui/tui-data.c (current_layout, tui_current_layout): Move to
1208 tui-layout.c.
1209 (tui_set_current_layout_to): Remove.
1210
2afade5d
TT		 12112019-08-13 Tom Tromey <tom@tromey.com>
1212
1213 * tui/tui-layout.c (tui_set_layout): Update.
1214 * tui/tui-data.h (struct tui_layout_def): Remove.
1215 (tui_layout_def): Don't declare.
1216 * tui/tui-data.c (layout_def): Remove.
1217 (tui_layout_def): Remove.
1218
a3504e96
TT		 12192019-08-13 Tom Tromey <tom@tromey.com>
1220
1221 * tui/tui-winsource.h (struct tui_source_window_base)
1222 <clear_detail>: No longer "override".
1223 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1224 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1225 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1226 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1227 Remove.
1228 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1229
29c92911
TT		 12302019-08-13 Tom Tromey <tromey@adacore.com>
1231
1232 * tracepoint.c: Don't include readline.h or history.h.
1233
86c6b807
TT		 12342019-08-12 Tom Tromey <tom@tromey.com>
1235
1236 * configure: Rebuild.
1237 * configure.ac: Check for readline 7.
1238 * NEWS: Mention readline 7 requirement.
1239 * README: Update.
1240
5db2718c
TT		 12412019-08-12 Tom Tromey <tom@tromey.com>
1242
1243 * mingw-hdep.c (gdb_select): Remove readline hack.
1244
dac36daf
PFC		 12452019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
1246
1247 * blockframe.c (find_pc_partial_function): Set *block to nullptr
1248 when the function fails.
1249
1022c627
AA		 12502019-08-09 Andreas Arnez <arnez@linux.ibm.com>
1251
1252 * s390-tdep.c (s390_type_align): New function.
1253 (s390_gdbarch_init): Set it as type_align gdbarch method.
1254
eba4caf2
TV		 12552019-08-09 Tom de Vries <tdevries@suse.de>
1256
1257 PR gdb/24591
1258 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1259 pc_low with relocation offset.
1260
123cd851
TT		 12612019-08-07 Tom Tromey <tromey@adacore.com>
1262
1263 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1264 (print_frame_args): Update.
1265 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1266 Update.
1267 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1268 * frame.h (struct frame_arg): Add initializers.
1269 <error>: Now a unique_xmalloc_ptr.
1270
3d31bc39
AH		 12712019-08-07 Alan Hayward <alan.hayward@arm.com>
1272
1273 * NEWS: Expand the Pointer Authentication entry.
1274 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1275 (aarch64_frame_unmask_lr): ... to this.
1276 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1277 Call aarch64_frame_unmask_lr.
1278 * frame.c (struct frame_info): Add "masked" variable.
1279 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1280 (fprint_frame): Check for masked pc.
1281 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1282 declarations.
1283 * python/py-framefilter.c (py_print_frame): Check for masked pc.
1284 * stack.c (print_frame): Check for masked pc.
1285
0cf9feb9
TT		 12862019-08-06 Tom Tromey <tom@tromey.com>
1287
1288 * stabsread.c (patch_block_stabs, read_one_struct_field)
1289 (read_enum_type): Use obstack_strndup.
1290 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1291 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1292 * dwarf2read.c (guess_full_die_structure_name)
1293 (anonymous_struct_prefix): Use obstack_strndup.
1294 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1295 * c-exp.y (yylex): Use obstack_strndup.
1296 * ada-exp.y (write_object_renaming, write_ambiguous_var)
1297 (write_var_or_type): Use obstack_strndup.
1298
efba19b0
TT		 12992019-08-06 Tom Tromey <tom@tromey.com>
1300
1301 * symfile.c (reread_symbols): Use obstack_strdup.
1302 * stabsread.c (read_type): Use obstack_strdup.
1303 * gdb_obstack.h (obstack_strdup): New overload.
1304 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1305 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1306 (dwarf2_canonicalize_name): Use obstack_strdup.
1307 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1308 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1309 Use obstack_strdup.
1310
f25102f7
TT		 13112019-08-06 Tom Tromey <tom@tromey.com>
1312
1313 * gdb_obstack.h (obstack_strdup): Define.
1314 * gdb_obstack.c (obstack_strdup): Don't define.
1315
021887d8
TT		 13162019-08-06 Tom Tromey <tom@tromey.com>
1317
1318 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1319 obstack_strdup.
1320 * typeprint.c (typedef_hash_table::find_global_typedef): Use
1321 obstack_strdup.
1322 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1323 * stabsread.c (common_block_start): Use obstack_strdup.
1324 * objfiles.c (set_objfile_main_name, objfile): Use
1325 obstack_strdup.
1326 * namespace.c (add_using_directive): Use obstack_strdup.
1327 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1328 * jit.c (finalize_symtab): Use obstack_strdup.
1329 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1330 (guess_partial_die_structure_name, partial_die_info::fixup)
1331 (dwarf2_name): Use obstack_strdup.
1332 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1333 obstack_strdup.
1334 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1335 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1336 obstack_strdup.
1337 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1338
d2834edc
PW		 13392019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1340
1341 * unittests/help-doc-selftests.c: New file.
1342 * Makefile.in: Add the new file.
1343
590042fc
PW		 13442019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1345
1346 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1347 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
1348 the full first line, except when FOR_VALUE_PREFIX. In this case,
1349 the trailing '.' is not output, and the first character is uppercased.
1350 (print_help_for_command): Update call to print_doc_line.
1351 (print_doc_of_command): Likewise.
1352 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1353 * cli/cli-option.c (append_indented_doc): Do not append newline.
1354 (build_help_option): Append newline after first appended_indented_doc
1355 only if a second call is done.
1356 (build_help): Append 2 new lines before each option, except the first
1357 one.
1358 * compile/compile.c (_initialize_compile): Add new lines after
1359 %OPTIONS%, when not at the end of the help.
1360 Change help doc or code
1361 producing the help doc to respect the invariants.
1362 * maint-test-options.c (_initialize_maint_test_options): Likewise.
1363 Also removed the new line after 'Options:', as all other commands
1364 do not put an empty line between 'Options:' and the first option.
1365 * printcmd.c (_initialize_printcmd): Likewise.
1366 * stack.c (_initialize_stack): Likewise.
1367 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1368 incorrectly telling COMMAND is optional.
1369 * ada-lang.c (_initialize_ada_language): Change help doc or code
1370 producing the help doc to respect the invariants.
1371 * ada-tasks.c (_initialize_ada_tasks): Likewise.
1372 * breakpoint.c (_initialize_breakpoint): Likewise.
1373 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1374 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1375 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1376 * cli/cli-style.c (cli_style_option::add_setshow_commands,
1377 _initialize_cli_style): Likewise.
1378 * corelow.c (core_target_info): Likewise.
1379 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1380 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1381 * filesystem.c (_initialize_filesystem): Likewise.
1382 * frame.c (_initialize_frame): Likewise.
1383 * gnu-nat.c (add_task_commands): Likewise.
1384 * infcall.c (_initialize_infcall): Likewise.
1385 * infcmd.c (_initialize_infcmd): Likewise.
1386 * interps.c (_initialize_interpreter): Likewise.
1387 * language.c (_initialize_language): Likewise.
1388 * linux-fork.c (_initialize_linux_fork): Likewise.
1389 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1390 * maint.c (_initialize_maint_cmds): Likewise.
1391 * memattr.c (_initialize_mem): Likewise.
1392 * printcmd.c (_initialize_printcmd): Likewise.
1393 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1394 _RegEx): Likewise.
1395 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1396 * record-btrace.c (_initialize_record_btrace): Likewise.
1397 * record-full.c (_initialize_record_full): Likewise.
1398 * record.c (_initialize_record): Likewise.
1399 * regcache-dump.c (_initialize_regcache_dump): Likewise.
1400 * regcache.c (_initialize_regcache): Likewise.
1401 * remote.c (add_packet_config_cmd, init_remote_threadtests,
1402 _initialize_remote): Likewise.
1403 * ser-tcp.c (_initialize_ser_tcp): Likewise.
1404 * serial.c (_initialize_serial): Likewise.
1405 * skip.c (_initialize_step_skip): Likewise.
1406 * source.c (_initialize_source): Likewise.
1407 * stack.c (_initialize_stack): Likewise.
1408 * symfile.c (_initialize_symfile): Likewise.
1409 * symtab.c (_initialize_symtab): Likewise.
1410 * target-descriptions.c (_initialize_target_descriptions): Likewise.
1411 * top.c (init_main): Likewise.
1412 * tracefile-tfile.c (tfile_target_info): Likewise.
1413 * tracepoint.c (_initialize_tracepoint): Likewise.
1414 * tui/tui-win.c (_initialize_tui_win): Likewise.
1415 * utils.c (add_internal_problem_command): Likewise.
1416 * valprint.c (value_print_option_defs): Likewise.
1417
404f2902
FCE		 14182019-08-06 Frank Ch. Eigler <fche@redhat.com>
1419
1420 PR build/24886
1421 * configure.ac: Drop enable-libmcheck support.
1422 * configure, config.in: Rebuild.
1423 * libmcheck.m4: Remove.
1424 * acinclude.m4: Don't include it.
1425 * Makefile.in: Don't distribute it.
1426 * top.c (print_gdb_configuration): Don't mention it.
1427
046bebe1
TT		 14282019-08-06 Tom Tromey <tom@tromey.com>
1429
1430 * utils.c (set_output_style): Sometimes pass stream to
1431 emit_style_escape.
1432 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1433 * record-btrace.c (btrace_insn_history): Update.
1434 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1435 method.
1436 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1437 Update initializers.
1438 <m_uiout>: New field.
1439 <m_di>: Move lower.
1440 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1441 Remove "uiout" parameter.
1442 (dump_insns): Update.
1443 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1444 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1445
ddbcedf5
CB		 14462019-08-06 Christian Biesinger <cbiesinger@google.com>
1447
1448 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1449 (error_in_psymtab_expansion): Likewise.
1450 (lookup_symbol_via_quick_fns): Likewise.
1451 (basic_lookup_transparent_type_quick): Likewise.
1452 (basic_lookup_transparent_type_1): Likewise.
1453
b08b16c8
TT		 14542019-08-06 Tom Tromey <tromey@adacore.com>
1455
1456 * source.c (last_source_error): Now bool.
1457 (print_source_lines_base): Make "noprint" bool. Only open
1458 source file when last_source_visited changes.
1459
cb44333d
TT		 14602019-08-06 Tom Tromey <tromey@adacore.com>
1461
1462 * annotate.c (annotate_source_line): Use g_source_cache.
1463 * source-cache.c (source_cache::get_plain_source_lines): Change
1464 parameters. Populate m_offset_cache.
1465 (source_cache::ensure): New method.
1466 (source_cache::get_line_charpos): New method.
1467 (extract_lines): Move lower. Change parameters.
1468 (source_cache::get_source_lines): Move lower.
1469 * source-cache.h (class source_cache): Update comment.
1470 <get_line_charpos>: New method.
1471 <get_source_lines>: Update comment.
1472 <clear>: Clear m_offset_cache.
1473 <get_plain_source_lines>: Change parameters.
1474 <ensure>: New method
1475 <m_offset_cache>: New member.
1476 * source.c (forget_cached_source_info_for_objfile): Update.
1477 (info_source_command): Use g_source_cache.
1478 (find_source_lines, open_source_file_with_line_charpos): Remove.
1479 (print_source_lines_base, search_command_helper): Use g_source_cache.
1480 * source.h (open_source_file_with_line_charpos): Don't declare.
1481 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1482 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1483 Use g_source_cache.
1484
872dceaa
TT		 14852019-08-06 Tom Tromey <tromey@adacore.com>
1486
1487 * source-cache.c (source_cache::get_plain_source_lines):
1488 Remove "first_line" and "last_line" parameters.
1489 (source_cache::get_source_lines): Cache plain text.
1490 * source-cache.h (class source_cache)
1491 <get_plain_source_lines>: Update.
1492
269249d9
TT		 14932019-08-06 Tom Tromey <tromey@adacore.com>
1494
1495 * source-cache.c (extract_lines): No longer a method.
1496 Changed type of parameter. Include final newline.
1497 (selftests::extract_lines_test): New function.
1498 (_initialize_source_cache): Likewise.
1499 * source-cache.h (class source_cache)
1500 <extract_lines>: Don't declare.
1501
c0e8dcd8
TT		 15022019-08-06 Tom Tromey <tromey@adacore.com>
1503
1504 * breakpoint.c (init_breakpoint_sal): Update.
1505 (breakpoint): Update.
1506 * breakpoint.h (struct breakpoint) <filter>: Now a
1507 unique_xmalloc_ptr.
1508
0b27c27d
CB		 15092019-08-05 Christian Biesinger <cbiesinger@google.com>
1510
1511 * NEWS: Mention dictionary access on blocks.
1512 * python/py-block.c (blpy_getitem): New function.
1513 (block_object_as_mapping): New struct.
1514 (block_object_type): Use new struct for tp_as_mapping field.
1515
4ee94178
CB		 15162019-08-05 Christian Biesinger <cbiesinger@google.com>
1517
1518 * objfiles.h (objfile): Add a comment describing partial symbols.
1519
8abfcabc
TT		 15202019-08-05 Tom Tromey <tromey@adacore.com>
1521
1522 * compile/compile.c (_initialize_compile): Use _(), not N_().
1523 * thread.c (_initialize_thread): Use _(), not N_().
1524 * stack.c (_initialize_stack): Use _(), not N_().
1525 * printcmd.c (_initialize_printcmd): Use _(), not N_().
1526
2b79f376
SM		 15272019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
1528
1529 * dwarf2read.c (struct dw2_symtab_iterator):
1530 <want_specific_block>: Remove.
1531 <block_index>: Change type to gdb::optional.
1532 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1533 change type of BLOCK_INDEX parameter to gdb::optional.
1534 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1535 (dw2_lookup_symbol): Don't pass argument for
1536 WANT_SPECIFIC_BLOCK.
1537 (dw2_expand_symtabs_for_function): Don't pass argument for
1538 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1539 (class dw2_debug_names_iterator)
1540 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1541 parameter, change BLOCK_INDEX type to gdb::optional.
1542 <m_want_specific_block>: Remove.
1543 <m_block_index>: Change type to gdb::optional.
1544 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1545 gdb::optional. Re-write in function of gdb::optional.
1546 (dw2_debug_names_lookup_symbol): Don't pass argument for
1547 WANT_SPECIFIC_BLOCK.
1548 (dw2_debug_names_expand_symtabs_for_function): Don't pass
1549 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1550 BLOCK_INDEX.
1551
ae60f04e
PW		 15522019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1553
1554 * NEWS: Mention changes to "info sources" command.
1555
28cd9371
PW		 15562019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1557
1558 * symtab.c (filename_partial_match_opts): New struct type.
1559 (struct output_source_filename_data): New members
1560 regexp, c_regexp, partial_match.
1561 (output_source_filename): Use new members to decide to print file.
1562 (info_sources_option_defs): New variable.
1563 (make_info_sources_options_def_group, print_info_sources_header,
1564 info_sources_command_completer):
1565 New functions.
1566 (info_sources_command): Read new optional arguments.
1567 (_initialize_symtab): Update info sources help.
1568
ca683e3a
AO		 15692019-08-02 Alexandre Oliva <oliva@adacore.com>
1570
1571 * ada-lang.c (exception_support_info_v0): Renamed from...
1572 (default_exception_support_info): ... this. Create new
1573 definition for v1.
1574 (ada_has_this_exception_support): Look up catch_handlers_sym.
1575 (ada_exception_support_info_sniffer): Try v0 after default.
1576
f1264162
TT		 15772019-08-01 Tom Tromey <tromey@adacore.com>
1578
1579 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1580 gdbarch.h.
1581
0a7b2485
CB		 15822019-08-01 Christian Biesinger <cbiesinger@google.com>
1583
1584 * s12z-tdep.c: Fix include path for s12z-opc.h.
1585
c6bdbeb7
AH		 15862019-08-01 Alan Hayward <alan.hayward@arm.com>
1587
1588 * NEWS: Require GNU make 3.82.
1589
a2bd7b82
TT		 15902019-07-16 Tom Tromey <tom@tromey.com>
1591
1592 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1593 declare.
1594
aa3b6533
TT		 15952019-07-30 Tom Tromey <tromey@adacore.com>
1596
1597 * block.c (contained_in): Remove BLOCK_FUNCTION check.
1598
a1530dc7
KB		 15992019-07-30 Kevin Buettner <kevinb@redhat.com>
1600
1601 * printcmd.c (print_address_symbolic): Print negative offsets.
1602 (build_address_symbolic): Force signed arithmetic when computing
1603 offset.
1604
2906593f
CB		 16052019-07-30 Christian Biesinger <cbiesinger@google.com>
1606
1607 PR/24474: Add a function to lookup static variables.
1608 * NEWS: Mention this new function.
1609 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1610 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1611 * python/python.c (python_GdbMethods): Add new function.
1612
c620ed88
CB		 16132019-07-29 Christian Biesinger <cbiesinger@google.com>
1614
1615 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1616 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1617 (objfpy_lookup_static_symbol): New function.
1618 (objfile_object_methods): Add new functions.
1619
bc4268a5
PW		 16202019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1621
1622 * NEWS: Mention 'set|show print frame-info'. Mention new
1623 'presence' value for 'frame-arguments'. Mention new '-frame-info'
1624 backtrace argument. Mention that python frame filtering code
1625 is now consistent with what 'backtrace' command prints.
1626
4b5e8d19
PW		 16272019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1628
1629 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1630 comments.
1631 (print_frame_info_auto, print_frame_info_source_line,
1632 print_frame_info_location, print_frame_info_source_and_location,
1633 print_frame_info_location_and_address, print_frame_info_short_location):
1634 New declarations.
1635 (struct frame_print_options): New member print_frame_info.
1636 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1637 * stack.h (get_user_print_what_frame_info): New declaration.
1638 (frame_show_address): New declaration.
1639 * stack.c (print_frame_arguments_choices): New value 'presence'.
1640 (print_frame_info_auto, print_frame_info_source_line,
1641 print_frame_info_location, print_frame_info_source_and_location,
1642 print_frame_info_location_and_address, print_frame_info_short_location,
1643 print_frame_info_choices, print_frame_info_print_what): New definitions.
1644 (print_frame_args): Only print dots for args if print frame-arguments
1645 is 'presence'.
1646 (frame_print_option_defs): New element for "frame-info".
1647 (get_user_print_what_frame_info): New function.
1648 (frame_show_address): Make non static. Move comment to stack.h.
1649 (print_frame_info_to_print_what): New function.
1650 (print_frame_info): Update comment. Use fp_opts.print_frame_info
1651 to decide what to print.
1652 (backtrace_command_1): Handle the new print_frame_arguments_presence
1653 value.
1654 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1655 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1656 (py_print_frame): In non-mi mode, use LOCATION as default for
1657 print_what, similarly to frame information printed directly by
1658 backtrace command. Handle frame-info user option in non MI mode.
1659
6bdfee81
KB		 16602019-07-27 Kevin Buettner <kevinb@redhat.com>
1661
1662 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1663 Add case for debugging 32-bit target on 64-bit host. Revise
1664 comment.
1665
98a617f8
KB		 16662019-07-27 Kevin Buettner <kevinb@redhat.com>
1667
1668 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1669 instead of find_function_entry_range_from_pc.
1670
567238c9
KB		 16712019-07-27 Kevin Buettner <kevinb@redhat.com>
1672
1673 * stack.c (find_frame_funname): Remove code which preferred
1674 minsym over symtab sym in "certain pathological cases".
1675
2dc80cf8
KB		 1676 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1677 parameter. Change type of "do_demangle" to bool.
1678 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1679 Pass suitable "prefer_sym_over_minsym" flag to
1680 build_address_symbolic(). Don't output "+" for negative offsets.
1681 * printcmd.c (print_address_symbolic): Update invocation of
1682 build_address_symbolic to include a "prefer_sym_over_minsym"
1683 flag.
1684 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1685 Restrict cases in which use of minimal symbol is preferred to that
1686 of a found symbol. Update comments.
1687
1aff7173
KB		 1688 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1689 for entry pc when entry pc is out of range for that FDE.
1690
89b085ac
BC		 16912019-07-26 Brian Callahan <bcallah@openbsd.org>
1692
1693 PR gdb/24839:
1694 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1695 type.
1696
f32feb4a
CB		 16972019-07-25 Christian Biesinger <cbiesinger@google.com>
1698
1699 * python/py-objfile.c (add_separate_debug_file): Fix comment about
1700 this function's Python signature.
1701
1702
17032019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB		 1704
1705 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1706 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1707 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1708 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1709 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1710
1711
c54e4253
YS		 17122019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
1713
1714 * h8300-tdep.c (h8300_register_name_common): New.
1715 h8300_register_name): Use h8300_register_name_common.
1716 (h8300s_register_name): Likewise.
1717 (h8300sx_register_name): Likewise.
1718 (h8300h_register_nam): New.
1719 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1720
1721
40eadf04
SP		 17222019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
1723
1724 * arm-tdep.c (arm_skip_cmse_entry): New function.
1725 (arm_is_sgstubs_section): New function.
1726 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1727
bfa2a36d
TT		 17282019-07-22 Tom Tromey <tom@tromey.com>
1729
1730 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1731 Don't self-assign.
1732
a8e9d247
AB		 17332019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1734
1735 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1736 type_print.
1737
eb86c5e2
AB		 17382019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1739
1740 * symtab.c (search_symbols): Adjust msymbol matching type arrays
1741 so that GDB doesn't match any msymbols when searching in the
1742 TYPES_DOMAIN.
1743 (print_symbol_info): Print using typedef_print or type_print based
1744 on the type of the symbol. Add updated FIXME comment moved from...
1745 (_initialize_symtab): ... move and update FIXME comment to above.
1746
a8eab7c6
AB		 17472019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1748
1749 * NEWS: Mention adding -q option to "info types".
1750 * symtab.c (struct info_types_options): New struct.
1751 (info_types_options_defs): New variable.
1752 (make_info_types_options_def_group): New function.
1753 (info_types_command): Use gdb::option framework to parse options.
1754 (info_types_command_completer): New function.
1755 (_initialize_symtab): Extend the help text on "info types" and
1756 register command completer.
1757
b4603c34
CB		 17582019-07-21 Christian Biesinger <cbiesinger@google.com>
1759
1760 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1761 (lookup_symbol_in_objfile): Change int to block_enum and add a
1762 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1763
c8cdc1e0
CB		 17642019-07-20 Christian Biesinger <cbiesinger@google.com>
1765
1766 * MAINTAINERS (Write After Approval): Add self.
1767
01e175fe
AB		 17682019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
1769
1770 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1771 instruction to the dummy code region.
1772
56f79b63
TT		 17732019-07-19 Tom Tromey <tromey@adacore.com>
1774
1775 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1776 (ARGSUSED, PARAMS, __func__): Remove rules.
1777
4c5aa8e0
AH		 17782019-07-19 Alan Hayward <alan.hayward@arm.com>
1779
1780 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1781 * features/arm/arm-with-iwmmxt.c: Remove.
1782 * features/arm/arm-with-iwmmxt.xml: Remove.
1783 * features/arm/arm-with-m-fpa-layout.c: Remove.
1784 * features/arm/arm-with-m-fpa-layout.xml: Remove.
1785 * features/arm/arm-with-m-vfp-d16.c: Remove.
1786 * features/arm/arm-with-m-vfp-d16.xml: Remove.
1787 * features/arm/arm-with-m.c: Remove.
1788 * features/arm/arm-with-m.xml: Remove.
1789 * features/arm/arm-with-neon.c: Remove.
1790 * features/arm/arm-with-neon.xml: Remove.
1791 * features/arm/arm-with-vfpv2.c: Remove.
1792 * features/arm/arm-with-vfpv2.xml: Remove.
1793 * features/arm/arm-with-vfpv3.c: Remove.
1794 * features/arm/arm-with-vfpv3.xml: Remove.
1795
f42b2617
AH		 17962019-07-19 Alan Hayward <alan.hayward@arm.com>
1797
1798 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1799
f29ec966
AH		 18002019-07-19 Alan Hayward <alan.hayward@arm.com>
1801
1802 * arch/aarch32.c (aarch32_create_target_description): Create
1803 target descriptions using features.
1804 * arch/arm.c (arm_create_target_description)
1805 (arm_create_mprofile_target_description): Likewise.
1806 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1807
d105cce5
AH		 18082019-07-19 Alan Hayward <alan.hayward@arm.com>
1809
1810 * Makefile.in: Add new files.
1811 * aarch32-tdep.c: New file.
1812 * aarch32-tdep.h: New file.
1813 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1814 Call aarch32_read_description.
1815 * arch/aarch32.c: New file.
1816 * arch/aarch32.h: New file.
1817 * arch/arm.c (arm_create_target_description)
1818 (arm_create_mprofile_target_description): New function.
1819 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1820 (arm_create_target_description)
1821 (arm_create_mprofile_target_description): New declaration.
1822 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1823 read_description functions.
1824 * arm-linux-nat.c (arm_linux_nat_target::read_description):
1825 Likewise.
1826 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1827 * arm-tdep.c (tdesc_arm_list): New variable.
1828 (arm_register_g_packet_guesses): Call create description functions.
1829 (arm_read_description) (arm_read_mprofile_description): New
1830 function.
1831 * arm-tdep.h (arm_read_description)
1832 (arm_read_mprofile_description): Add declaration.
1833 * configure.tgt: Add new files.
1834
afe09f0b
GL		 18352019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
1836
1837 * top.c (new_ui_command): Open specified terminal just once.
1838
cd215b2e
TT		 18392019-07-18 Tom Tromey <tromey@adacore.com>
1840
1841 * symtab.c (main_name): Constify return type.
1842 * symfile.c (set_initial_language): Update.
1843 * symtab.h (main_name): Constify return type.
1844
d8f68fcb
TT		 18452019-07-17 Tom Tromey <tom@tromey.com>
1846
1847 * tui/tui-winsource.c (tui_update_source_window)
1848 (tui_update_source_window_as_is)
1849 (tui_update_source_windows_with_line): Remove return.
1850 * tui/tui-disasm.c (tui_show_disassem)
1851 (tui_show_disassem_and_update_source): Remove return.
1852 * tui/tui.c (tui_reset): Remove return.
1853 * tui/tui-wingeneral.c
1854 (tui_check_and_display_highlight_if_needed): Remove return.
1855
ca5af91e
TT		 18562019-07-17 Tom Tromey <tom@tromey.com>
1857
1858 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1859
5104fe36
TT		 18602019-07-17 Tom Tromey <tom@tromey.com>
1861
1862 * tui/tui-winsource.h (struct tui_exec_info_window)
1863 (struct tui_source_window_base): Move from tui-data.h.
1864 * tui/tui-winsource.c: Move many method definitions from
1865 elsewhere. Remove "structuring" comments.
1866 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1867 (tui_source_window_base::refresh_window): Move to
1868 tui-winsource.c.
1869 * tui/tui-win.c (tui_source_window_base::refresh_all)
1870 (tui_source_window_base::update_tab_width)
1871 (tui_source_window_base::set_new_height)
1872 (tui_source_window_base::do_make_visible_with_new_height): Move to
1873 tui-winsource.c.
1874 * tui/tui-source.h: Update.
1875 * tui/tui-source.c (tui_source_window_base::reset): Move to
1876 tui-winsource.c.
1877 * tui/tui-disasm.h: Update.
1878 * tui/tui-data.h (struct tui_exec_info_window): Move to
1879 tui-winsource.h.
1880 (struct tui_source_window_base): Likewise.
1881 * tui/tui-data.c (tui_source_window_base::clear_detail)
1882 (tui_source_window_base, ~tui_source_window_base): Move to
1883 tui-winsource.c.
1884
daa15dde
TT		 18852019-07-17 Tom Tromey <tom@tromey.com>
1886
1887 * tui/tui-win.c (tui_resize_all)
1888 (tui_source_window_base::update_tab_width)
1889 (tui_adjust_win_heights): Update.
1890 (tui_win_info::make_invisible_and_set_new_height): Rename from
1891 make_invisible_and_set_new_height.
1892 * tui/tui-data.h (struct tui_win_info)
1893 <make_invisible_and_set_new_height>: New method.
1894
bfad4537
TT		 18952019-07-17 Tom Tromey <tom@tromey.com>
1896
1897 * tui/tui.c: Update.
1898 * tui/tui-source.h (struct tui_source_window): Move from
1899 tui-data.h.
1900 * tui/tui-layout.c: Update.
1901 * tui/tui-disasm.c: Update.
1902 * tui/tui-data.h (struct tui_source_window): Move to
1903 tui-source.h.
1904
88f7e873
TT		 19052019-07-17 Tom Tromey <tom@tromey.com>
1906
1907 * tui/tui-disasm.h (struct tui_disasm_window): Move from
1908 tui-data.h.
1909 * tui/tui-data.h (struct tui_disasm_window): Move to
1910 tui-disasm.h.
1911
96bd6233
TT		 19122019-07-17 Tom Tromey <tom@tromey.com>
1913
1914 * tui/tui-regs.h (struct tui_data_item_window): Move from
1915 tui-data.h.
1916 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1917 * tui/tui-data.h (struct tui_data_item_window): Move to
1918 tui-regs.h.
1919 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1920
ce38393b
TT		 19212019-07-17 Tom Tromey <tom@tromey.com>
1922
1923 * tui/tui.c: Update.
1924 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1925 (tui_cmd_window::max_height): Move to tui-command.c.
1926 * tui/tui-layout.c: Update.
1927 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1928 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1929 tui-command.c.
1930 * tui/tui-command.h (struct tui_cmd_window): Move from
1931 tui-data.h.
1932 * tui/tui-command.c: Remove "structuring" comments.
1933 (tui_cmd_window::clear_detail)
1934 (tui_cmd_window::do_make_visible_with_new_height)
1935 (tui_cmd_window::max_height): Move from elsewhere.
1936
2d8b51cb
TT		 19372019-07-17 Tom Tromey <tom@tromey.com>
1938
1939 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1940 Now static.
1941 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1942 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1943
18ab23af
TT		 19442019-07-17 Tom Tromey <tom@tromey.com>
1945
1946 * tui/tui.c: Update.
1947 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1948 tui-regs.c.
1949 * tui/tui-windata.h: Remove file.
1950 * tui/tui-windata.c: Remove file.
1951 * tui/tui-win.c (tui_data_window::set_new_height)
1952 (tui_data_window::do_make_visible_with_new_height): Move to
1953 tui-regs.c.
1954 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1955 * tui/tui-regs.c: Remove "structuring" comments.
1956 (tui_data_window::first_data_item_displayed)
1957 (tui_data_window::delete_data_content_windows)
1958 (tui_data_window::erase_data_content)
1959 (tui_data_window::display_all_data)
1960 (tui_data_window::refresh_all)
1961 (tui_data_window::do_scroll_vertical)
1962 (tui_data_window::clear_detail, tui_data_window::set_new_height)
1963 (tui_data_window::do_make_visible_with_new_height)
1964 (tui_data_window::refresh_window): Move from elsewhere.
1965 (_initialize_tui_regs): Move to end of file.
1966 * tui/tui-layout.c: Update.
1967 * tui/tui-hooks.c: Update.
1968 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1969 * tui/tui-data.c (tui_data_window::clear_detail): Move to
1970 tui-regs.c.
1971 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1972
88b7e7cc
TT		 19732019-07-17 Tom Tromey <tom@tromey.com>
1974
1975 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1976 seen.
1977
0fcd3711
TT		 19782019-07-17 Tom Tromey <tom@tromey.com>
1979
1980 * tui/tui-win.c (tui_source_window_base::set_new_height)
1981 (tui_source_window_base::do_make_visible_with_new_height): Use
1982 m_has_locator field directly.
1983 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1984 method.
1985 (struct tui_source_window_base) <has_locator>: Likewise.
1986
4a38112d
TT		 19872019-07-17 Tom Tromey <tom@tromey.com>
1988
1989 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1990 Don't declare.
1991 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1992 Remove.
1993 * tui/tui-win.c (tui_source_window_base::set_new_height)
1994 (tui_source_window_base::set_new_height)
1995 (make_invisible_and_set_new_height)
1996 (tui_source_window_base::do_make_visible_with_new_height)
1997 (tui_source_window_base::do_make_visible_with_new_height):
1998 Update.
1999 * tui/tui-layout.c (show_source_disasm_command, show_data)
2000 (show_source_or_disasm_and_command): Update.
2001 * tui/tui-layout.c (show_layout): Update.
2002
09129226
TT		 20032019-07-17 Tom Tromey <tom@tromey.com>
2004
2005 * tui/tui-layout.c (make_data_window): Remove.
2006 (show_data): Unify creation and re-initialization cases.
2007
4a8a5e84
TT		 20082019-07-17 Tom Tromey <tom@tromey.com>
2009
2010 * tui/tui-layout.c (make_source_window, make_disasm_window):
2011 Remove.
2012 (show_data): Unify creation and re-initialization cases.
2013
76d2be8e
TT		 20142019-07-17 Tom Tromey <tom@tromey.com>
2015
2016 * tui/tui-layout.c (make_command_window): Remove.
2017 (show_source_disasm_command, show_source_or_disasm_and_command):
2018 Unify creation and re-initialization cases.
2019
890b8bde
TT		 20202019-07-17 Tom Tromey <tom@tromey.com>
2021
2022 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2023 creation and re-initialization cases.
2024
2cdfa113
TT		 20252019-07-17 Tom Tromey <tom@tromey.com>
2026
2027 * tui/tui-regs.c (tui_get_register): Return void.
2028
8e3cfd09
TT		 20292019-07-17 Tom Tromey <tom@tromey.com>
2030
2031 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2032 Simplify.
2033
f4e04977
TT		 20342019-07-17 Tom Tromey <tom@tromey.com>
2035
2036 * tui/tui-layout.c (show_source_disasm_command): Simplify window
2037 resetting.
2038
0379b883
TT		 20392019-07-17 Tom Tromey <tom@tromey.com>
2040
2041 * tui/tui.h (tui_set_layout_by_name): Don't declare.
2042 * tui/tui-regs.c (tui_reg_layout): New function.
2043 (tui_show_registers, tui_reg_command): Use it.
2044 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2045 (tui_layout_command): Rename from tui_set_layout_by_name. Change
2046 parameters.
2047 (tui_layout_command): Remove.
2048
b7fbad91
TT		 20492019-07-17 Tom Tromey <tom@tromey.com>
2050
2051 * tui/tui-layout.h (tui/tui-layout): Return void.
2052 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
2053
4e1e56b9
TT		 20542019-07-17 Tom Tromey <tom@tromey.com>
2055
2056 * tui/tui-layout.c (show_source_disasm_command, show_data):
2057 Update.
2058 (reset_locator): Remove.
2059 (show_source_or_disasm_and_command): Update.
2060
1e0c09ba
TT		 20612019-07-17 Tom Tromey <tom@tromey.com>
2062
2063 * tui/tui-source.c (tui_source_window_base::reset): Remove
2064 win_type parameter.
2065 * tui/tui-layout.c (make_command_window, make_source_window)
2066 (make_disasm_window, make_data_window)
2067 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2068 (reset_locator, show_source_or_disasm_and_command): Update.
2069 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2070 win_type parameter.
2071 (struct tui_source_window_base) <reset>: Likewise.
2072
1bf605de
TT		 20732019-07-17 Tom Tromey <tom@tromey.com>
2074
2075 * tui/tui-layout.c (show_source_disasm_command): Use
2076 reset_locator.
2077 (reset_locator): New function.
2078 (init_and_make_win): Remove.
2079 (show_source_or_disasm_and_command): Use reset_locator.
2080
098f9ed4
TT		 20812019-07-17 Tom Tromey <tom@tromey.com>
2082
2083 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2084 condition.
2085 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2086 Remove condition.
2087 * tui/tui-source.c (tui_source_window_base::reset): New method.
2088 * tui/tui-layout.c (make_command_window): Don't call
2089 init_and_make_win.
2090 (make_source_window, make_disasm_window): Don't call
2091 make_source_or_disasm_window.
2092 (make_data_window): Don't call init_and_make_win. Change calling
2093 convention.
2094 (show_source_disasm_command, show_data): Simplify.
2095 (make_source_or_disasm_window): Remove.
2096 (show_source_or_disasm_and_command): Simplify.
2097 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2098 (struct tui_source_window_base) <reset>: Likewise.
2099 <execution_info>: Remove initializer.
2100 * tui/tui-data.c (tui_source_window_base): Initialize
2101 execution_info.
2102
80110957
TT		 21032019-07-17 Tom Tromey <tom@tromey.com>
2104
2105 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2106 variable.
2107
cf82af05
TT		 21082019-07-17 Tom Tromey <tom@tromey.com>
2109
2110 * tui/tui.c (tui_rl_other_window): Update.
2111 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2112 superclass method first. Always iterate over regs_content.
2113 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2114 method.
2115 * tui/tui-win.c (tui_set_focus_command): Update.
2116
01aeb396
TT		 21172019-07-17 Tom Tromey <tom@tromey.com>
2118
2119 * tui/tui-win.c (tui_set_focus_command): Rename from
2120 tui_set_focus. Call tui_enable.
2121 (tui_set_focus_command): Remove.
2122
fd6c75ee
TT		 21232019-07-17 Tom Tromey <tom@tromey.com>
2124
2125 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2126 refresh_window.
2127 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2128 touchwin.
2129 (tui_data_window::refresh_window): Call refresh_window on data
2130 items. Always call superclass refresh_window.
2131 (tui_win_info::refresh): Remove.
2132 (tui_source_window_base::refresh_window): Update.
2133 (tui_refresh_all): Update.
2134 * tui/tui-layout.c (show_source_disasm_command): Remove call to
2135 refresh_window.
2136 (show_source_or_disasm_and_command): Likewise.
2137 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2138 (struct tui_source_window_base) <refresh>: Likewise.
2139
f6cc34a9
TT		 21402019-07-17 Tom Tromey <tom@tromey.com>
2141
2142 * tui/tui-winsource.c (tui_clear_source_content)
2143 (tui_show_source_content): Update.
2144 * tui/tui-source.c (tui_source_window::showing_source_p): Check
2145 whether content is empty.
2146 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2147 Remove.
2148
f31ec9af
TT		 21492019-07-17 Tom Tromey <tom@tromey.com>
2150
2151 * tui/tui-winsource.c (tui_erase_source_content): Clear the
2152 window's contents.
2153 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2154 * tui/tui-source.c (tui_set_source_content_nil): Remove.
2155
d1b6f1e5
TT		 21562019-07-17 Tom Tromey <tom@tromey.com>
2157
2158 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2159 (struct tui_data_item_window): Update.
2160
d9743a13
TT		 21612019-07-17 Tom Tromey <tom@tromey.com>
2162
2163 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2164 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2165 defines.
2166
caf0bc4e
TT		 21672019-07-17 Tom Tromey <tom@tromey.com>
2168
2169 * tui/tui-winsource.h (tui_erase_source_content)
2170 (tui_clear_source_content): Remove "display_prompt" parameter.
2171 * tui/tui-winsource.c (tui_update_source_window_as_is)
2172 (tui_update_source_windows_with_addr): Update.
2173 (tui_clear_source_content): Remove "display_prompt" parameter.
2174 (tui_erase_source_content): Likewise. Simplify.
2175 (tui_show_source_content): Update.
2176 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2177 * tui/tui-stack.c (tui_show_frame_info): Update.
2178 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2179 Remove defines.
2180
9d391078
TT		 21812019-07-17 Tom Tromey <tom@tromey.com>
2182
2183 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2184 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2185 parameter.
2186 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2187 parameter.
2188
a38da35d
TT		 21892019-07-17 Tom Tromey <tom@tromey.com>
2190
2191 * tui/tui-winsource.c (tui_clear_source_content)
2192 (tui_show_source_content, tui_show_exec_info_content)
2193 (tui_clear_exec_info_content): Update.
2194 * tui/tui-stack.c (tui_show_locator_content): Update.
2195 (tui_show_frame_info): Update.
2196 * tui/tui-source.h (tui_source_window): Don't declare.
2197 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2198 from tui_source_is_displayed.
2199 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2200 Remove field.
2201 (struct tui_source_window_base) <content_in_use>: New field. Now
2202 bool.
2203 (struct tui_source_window) <showing_source_p>: New method.
2204 (TUI_SRC_WIN): Change cast.
2205 * tui/tui-data.c (tui_initialize_static_data): Update.
2206
c2cd8994
TT		 22072019-07-17 Tom Tromey <tom@tromey.com>
2208
2209 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2210 location_matches_p.
2211 * tui/tui-source.c (tui_source_window::location_matches_p): New
2212 method.
2213 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2214 method.
2215 * tui/tui-data.h (struct tui_source_window_base)
2216 <location_matches_p>: New method.
2217 (struct tui_source_window, struct tui_disasm_window)
2218 <location_matches_p>: Likewise.
2219
4dde7b34
TT		 22202019-07-17 Tom Tromey <tom@tromey.com>
2221
2222 * tui/tui-win.c (tui_set_win_height_command): Rename from
2223 tui_set_win_height.
2224 (tui_set_win_height_command): Remove.
2225
b73dd877
TT		 22262019-07-17 Tom Tromey <tom@tromey.com>
2227
2228 * tui/tui-source.c (tui_source_window): New constructor. Add
2229 observer.
2230 (~tui_source_window): New destructor.
2231 (tui_source_window::style_changed): New method.
2232 * tui/tui-hooks.c (tui_redisplay_source): Remove.
2233 (tui_attach_detach_observers): Update.
2234 * tui/tui-data.h (struct tui_source_window): Make constructor not
2235 inline. Add destructor.
2236 (struct tui_source_window) <style_changed>: New method.
2237 <m_observable>: New member.
2238
ae2b5380
TT		 22392019-07-17 Tom Tromey <tom@tromey.com>
2240
2241 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2242 * tui/tui-win.c (tui_resize_all): Fix typo.
2243
1ce3e844
TT		 22442019-07-17 Tom Tromey <tom@tromey.com>
2245
2246 * tui/tui-wingeneral.h (tui_refresh_all): Update.
2247 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2248 (tui_refresh_all): Remove "list" parameter. Use foreach.
2249 * tui/tui-win.c (window_name_completer): Use foreach.
2250 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2251 (update_tab_width): Likewise.
2252 * tui/tui-layout.c (show_layout): Update.
2253 * tui/tui-data.h (class tui_window_iterator): New.
2254 (struct all_tui_windows): New.
2255 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2256
fe3eaf1c
TT		 22572019-07-17 Tom Tromey <tom@tromey.com>
2258
2259 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2260 parameter. Don't reference globals.
2261 (tui_reg_command): Update.
2262
368c1354
TT		 22632019-07-17 Tom Tromey <tom@tromey.com>
2264
2265 * tui/tui-regs.c (tui_show_registers): Simplify.
2266
e80cd204
TT		 22672019-07-17 Tom Tromey <tom@tromey.com>
2268
2269 * tui/tui-regs.c (tui_show_registers): Update.
2270 (tui_show_register_group): Add win_info parameter.
2271
aca2dd16
TT		 22722019-07-17 Tom Tromey <tom@tromey.com>
2273
2274 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2275 Rename from tui_display_reg_element_at_line.
2276 (tui_data_window::display_registers_from_line): Update.
2277 * tui/tui-data.h (struct tui_data_window)
2278 <display_reg_element_at_line>: New method.
2279
517e9505
TT		 22802019-07-17 Tom Tromey <tom@tromey.com>
2281
2282 * tui/tui-regs.h (tui_display_registers_from)
2283 (tui_display_registers_from_line): Don't declare.
2284 * tui/tui-windata.c (tui_data_window::display_all_data)
2285 (tui_data_window::refresh_all)
2286 (tui_data_window::do_scroll_vertical): Update.
2287 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2288 from tui_display_registers_from.
2289 (tui_display_reg_element_at_line): Update.
2290 (tui_data_window::display_registers_from_line): Rename from
2291 tui_display_registers_from_line.
2292 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2293 display_registers_from_line>: New methods.
2294
f76d8b19
TT		 22952019-07-17 Tom Tromey <tom@tromey.com>
2296
2297 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2298 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2299 from tui_erase_data_content.
2300 (tui_data_window::display_all_data)
2301 (tui_data_window::refresh_all)
2302 (tui_data_window::do_scroll_vertical): Update.
2303 * tui/tui-regs.c (tui_show_registers): Update.
2304 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2305 New method.
2306
b4094625
TT		 23072019-07-17 Tom Tromey <tom@tromey.com>
2308
2309 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2310 declare.
2311 * tui/tui-windata.c
2312 (tui_data_window::delete_data_content_windows): Rename from
2313 tui_delete_data_content_windows.
2314 (tui_data_window::display_all_data)
2315 (tui_data_window::do_scroll_vertical): Update.
2316 * tui/tui-data.h (struct tui_data_window)
2317 <delete_data_content_windows>: New method.
2318
c223a729
TT		 23192019-07-17 Tom Tromey <tom@tromey.com>
2320
2321 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2322 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2323
50daf268
TT		 23242019-07-17 Tom Tromey <tom@tromey.com>
2325
2326 * tui/tui-windata.h (tui_display_all_data): Don't declare.
2327 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2328 from tui_display_all_data.
2329 * tui/tui-win.c
2330 (tui_data_window::do_make_visible_with_new_height): Update.
2331 * tui/tui-regs.c (tui_show_registers): Update.
2332 * tui/tui-layout.c (tui_set_layout): Update.
2333 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2334 method.
2335
df5f8cab
TT		 23362019-07-17 Tom Tromey <tom@tromey.com>
2337
2338 * tui/tui-windata.h (tui_display_data_from): Don't declare.
2339 * tui/tui-windata.c (tui_display_data_from): Remove.
2340 (tui_data_window::refresh_all): Update.
2341
80cb6c27
TT		 23422019-07-17 Tom Tromey <tom@tromey.com>
2343
2344 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2345 * tui/tui-windata.c (tui_display_data_from_line): Remove.
2346 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2347 tui_display_registers_from_line.
2348 * tui/tui-regs.h (tui_display_registers_from_line): Update.
2349 * tui/tui-regs.c (tui_display_registers_from_line): Remove
2350 "force_display" parameter.
2351
baff0c28
TT		 23522019-07-17 Tom Tromey <tom@tromey.com>
2353
2354 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2355 declare.
2356 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2357 Rename from tui_first_reg_element_no_inline.
2358 (tui_display_reg_element_at_line)
2359 (tui_display_registers_from_line): Update.
2360 * tui/tui-data.h (struct tui_data_window)
2361 <first_reg_element_no_inline>: New method.
2362
3b23c5f2
TT		 23632019-07-17 Tom Tromey <tom@tromey.com>
2364
2365 * tui/tui-windata.c (tui_display_data_from)
2366 (tui_data_window::do_scroll_vertical): Update.
2367 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2368 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2369 Rename from tui_line_from_reg_element_no.
2370 (tui_display_registers_from_line): Update.
2371 * tui/tui-data.h (struct tui_data_window)
2372 <line_from_reg_element_no>: New method.
2373
0b5ec218
TT		 23742019-07-17 Tom Tromey <tom@tromey.com>
2375
2376 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2377 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2378 tui_last_regs_line_no.
2379 (tui_display_reg_element_at_line)
2380 (tui_display_registers_from_line): Update.
2381 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2382 method.
2383
0807ab7b
TT		 23842019-07-17 Tom Tromey <tom@tromey.com>
2385
2386 PR tui/24722:
2387 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2388 (tui_update_breakpoint_info): Add "being_deleted" parameter.
2389 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2390 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2391 (tui_update_breakpoint_info): Likewise.
2392 * tui/tui-hooks.c (tui_event_create_breakpoint)
2393 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2394 Update.
2395
9ad7fdef
TT		 23962019-07-17 Tom Tromey <tom@tromey.com>
2397
2398 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2399
5813316f
TT		 24002019-07-17 Tom Tromey <tom@tromey.com>
2401
2402 * tui/tui-winsource.c (tui_update_source_window_as_is)
2403 (tui_update_source_windows_with_addr): Update.
2404 * tui/tui-source.h (tui_set_source_content)
2405 (tui_show_symtab_source): Add "win_info" parameter.
2406 * tui/tui-source.c (tui_set_source_content): Add "win_info"
2407 parameter.
2408 (tui_show_symtab_source): Likewise.
2409
00e264e7
TT		 24102019-07-17 Tom Tromey <tom@tromey.com>
2411
2412 * tui/tui-wingeneral.c
2413 (tui_check_and_display_highlight_if_needed): Check can_highlight.
2414
06210ce4
TT		 24152019-07-17 Tom Tromey <tom@tromey.com>
2416
2417 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2418 (struct tui_cmd_window) <can_scroll>: New method.
2419 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2420 method.
2421
381befee
TT		 24222019-07-17 Tom Tromey <tromey@adacore.com>
2423
2424 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2425 do_field_signed>: Rename. Change type of "value".
2426 * ui-out.c (ui_out::field_signed): Rename from field_int.
2427 Change type of "value".
2428 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
2429 type of "value".
2430 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2431 do_field_int. Change type of "value".
2432 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2433 do_field_int. Change type of "value".
2434 * tracepoint.c (trace_status_mi, tfind_1)
2435 (print_one_static_tracepoint_marker): Update.
2436 * thread.c (print_thread_info_1, print_selected_thread_frame):
2437 Update.
2438 * stack.c (print_frame, print_frame_info): Update.
2439 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2440 Update.
2441 * source.c (print_source_lines_base): Update.
2442 * skip.c (info_skip_command): Update.
2443 * record-btrace.c (btrace_ui_out_decode_error)
2444 (btrace_call_history_src_line): Update.
2445 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2446 Update.
2447 * progspace.c (print_program_space): Update.
2448 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2449 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2450 do_field_int. Change type of "value".
2451 * mi/mi-out.c (mi_ui_out::do_table_begin)
2452 (mi_ui_out::do_table_header): Update.
2453 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
2454 type of "value".
2455 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2456 (mi_cmd_data_list_changed_registers, output_register)
2457 (mi_cmd_data_read_memory, mi_load_progress)
2458 (mi_cmd_trace_frame_collected): Update.
2459 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2460 Update.
2461 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2462 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2463 (mi_cmd_var_list_children, varobj_update_one): Update.
2464 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2465 (mi_cmd_stack_list_args, list_arg_or_local): Update.
2466 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2467 * inferior.c (print_inferior): Update.
2468 * gdb_bfd.c (print_one_bfd): Update.
2469 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2470 Update.
2471 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2472 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2473 do_field_int. Change type of "value".
2474 * cli-out.c (cli_ui_out::do_field_signed): Rename from
2475 do_field_int. Change type of "value".
2476 * breakpoint.c (watchpoint_check, print_breakpoint_location)
2477 (print_one_breakpoint_location, print_it_catch_fork)
2478 (print_one_catch_fork, print_it_catch_vfork)
2479 (print_one_catch_vfork, print_it_catch_solib)
2480 (print_it_catch_exec, print_it_ranged_breakpoint)
2481 (print_mention_watchpoint, print_mention_masked_watchpoint)
2482 (bkpt_print_it, update_static_tracepoint): Update.
2483 * break-catch-throw.c (print_it_exception_catchpoint): Update.
2484 * break-catch-syscall.c (print_it_catch_syscall): Update.
2485 * ada-tasks.c (print_ada_task_info): Update.
2486 * ada-lang.c (print_it_exception, print_mention_exception):
2487 Update.
2488
6b78c3f8
AB		 24892019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
2490
2491 PR breakpoints/24541
2492 * gdbarch.c: Regenerate.
2493 * gdbarch.h: Regenerate.
2494 * gdbarch.sh: Adjust return type and parameter types for
2495 'stap_adjust_register'.
2496 (i386_stap_adjust_register): Adjust signature and return new
2497 register name.
2498 * stap-probe.c (stap_parse_register_operand): Adjust use of
2499 'gdbarch_stap_adjust_register'.
2500
d72a9b85
TT		 25012019-07-17 Tom Tromey <tromey@adacore.com>
2502
2503 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
2504 declare VEC.
2505 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2506 std::vector.
2507 (struct s390_process_info): Add initializers.
2508 (s390_add_process): Use new.
2509 (s390_linux_nat_target::low_forget_process): Use delete.
2510 (s390_linux_nat_target::low_new_fork)
2511 (s390_linux_nat_target::stopped_by_watchpoint)
2512 (s390_linux_nat_target::low_prepare_to_resume)
2513 (s390_linux_nat_target::insert_watchpoint)
2514 (s390_linux_nat_target::insert_hw_breakpoint)
2515 (s390_linux_nat_target::remove_watchpoint)
2516 (s390_linux_nat_target::remove_hw_breakpoint): Update.
2517
206e6c58
JB		 25182019-07-16 John Baldwin <jhb@FreeBSD.org>
2519
2520 * aarch64-fbsd-nat.c: Include regcache.h.
2521 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2522 argument.
2523 (aarch64_fbsd_nat_target::fetch_registers)
2524 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2525 variable.
2526 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2527
cbde90f2
JB		 25282019-07-16 John Baldwin <jhb@FreeBSD.org>
2529
2530 * fbsd-nat.c: Include gdbarch.h.
2531
07128006
TT		 25322019-07-15 Tom Tromey <tromey@adacore.com>
2533
2534 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2535
1f77b012
TT		 25362019-07-15 Tom Tromey <tromey@adacore.com>
2537
2538 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2539 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2540 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2541 * cli-out.c (cli_ui_out::do_field_int): New method.
2542 * ui-out.c (ui_out::field_unsigned): New method.
2543 * symfile.c (generic_load): Use field_unsigned.
2544 (print_transfer_performance): Likewise.
2545 * record-btrace.c (ui_out_field_uint): Remove.
2546 (btrace_call_history_insn_range, btrace_call_history): Use
2547 field_unsigned.
2548 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2549 field_unsigned.
2550 * ui-out.h (class ui_out) <field_unsigned>: New method.
2551 <do_field_unsigned>: Likewise.
2552
33eca680
TT		 25532019-07-15 Tom Tromey <tromey@adacore.com>
2554
2555 * mi/mi-main.c (list_available_thread_groups): Use field_string.
2556 * mi/mi-interp.c (mi_memory_changed): Use field_string.
2557 * target.c (flash_erase_command): Use field_string.
2558 * infrun.c (print_signal_received_reason): Use field_string.
2559 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2560 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2561 field_string.
2562 * ada-tasks.c (print_ada_task_info): Use field_string.
2563
ca8d69be
TT		 25642019-07-15 Tom Tromey <tromey@adacore.com>
2565
2566 * target.c (flash_erase_command): Use field_core_addr.
2567 * symfile.c (generic_load): Use field_core_addr.
2568 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2569 Use field_core_addr.
2570 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2571 field_core_addr.
2572
0d4e84ed
AB		 25732019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2574
2575 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2576 value if its desired type is smaller than a CORE_ADDR and signed.
2577
9a49df9d
AB		 25782019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2579
2580 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2581 of changes to field names, and use new is_reference field to
2582 decide if a property is a reference or not.
2583 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2584 field.
2585 (struct dwarf2_property_baton): Update header comment, rename
2586 'referenced_type' to 'property_type' and update comments.
2587 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2588 default property type, store in property baton, update to take
2589 accound of renamed field.
2590 (read_func_scope): Update call to attr_to_dynamic_prop.
2591 (read_array_type): Likewise.
2592 (dwarf2_per_cu_addr_sized_int_type): New function.
2593 (read_subrange_index_type): Move type finding code to
2594 dwarf2_per_cu_addr_sized_int_type.
2595 (read_subrange_type): Update calls to attr_to_dynamic_prop.
2596 (dwarf2_per_cu_addr_type): New function.
2597 (set_die_type): Update calls to attr_to_dynamic_prop.
2598
b86352cf
AB		 25992019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2600
2601 * dwarf2read.c (read_subrange_index_type): New function.
2602 (read_subrange_type): Move code into new function and call it.
2603 * gdbtypes.c (create_range_type): Add some asserts.
2604
603490bf
AB		 26052019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2606
2607 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2608 update return statements.
2609 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2610 declaration, and update comment to match.
2611 * gdbtypes.c (resolve_dynamic_array): Update call to
2612 dwarf2_evaluate_property to match new return type.
2613
592f9d27
AB		 26142019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2615
2616 * valarith.c (value_subscripted_rvalue): Change lowerbound
2617 parameter type from int to LONGEST.
2618 * value.h (value_subscripted_rvalue): Likewise in declaration.
2619
60cfcb20
AB		 26202019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2621
2622 * cli/cli-utils.c (info_print_command_completer): New function.
2623 * cli/cli-utils.h: Add 'completer.h' include, and forward
2624 declaration for 'struct cmd_list_element'.
2625 (info_print_command_completer): Declare.
2626 * stack.c (_initialize_stack): Add completer for 'info locals' and
2627 'info args'.
2628 * symtab.c (_initialize_symtab): Add completer for 'info
2629 variables' and 'info functions'.
2630 * NEWS: Mention completion for additional info commands.
2631
b16507e0
AB		 26322019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2633
2634 * cli/cli-utils.c (extract_info_print_args): Delete.
2635 (extract_arg_maybe_quoted): Delete.
2636 (info_print_options_defs): New variable.
2637 (make_info_print_options_def_group): New function.
2638 (extract_info_print_options): Define new function.
2639 * cli/cli-utils.h (extract_info_print_args): Delete.
2640 (struct info_print_options): New structure.
2641 (extract_info_print_options): Declare new function.
2642 * stack.c (info_locals_command): Update to use new
2643 extract_info_print_options, also add a header comment.
2644 (info_args_command): Likewise.
2645 * symtab.c (info_variables_command): Likewise.
2646 (info_functions_command): Likewise.
2647
021d8588
AB		 26482019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2649
2650 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2651 to extract string arguments.
2652 * common/common-utils.c (extract_string_maybe_quoted): New function.
2653 * common/common-utils.h (extract_string_maybe_quoted): Declare.
2654
b777eb6d
TT		 26552019-07-11 Tom Tromey <tromey@adacore.com>
2656
2657 * main.c (get_init_files): Use GDBINIT, not gdbinit.
2658 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2659 * top.h (gdbinit): Don't declare.
2660 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2661 into...
2662 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
2663 * top.c (gdb_init): Don't call init_cli_cmds.
2664 (gdbinit): Remove.
2665 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2666
72ee03ff
TT		 26672019-07-11 Tom Tromey <tromey@adacore.com>
2668
2669 * python/py-inferior.c (add_thread_object): Don't use thread_obj
2670 after it has been moved.
2671
00db9531
SM		 26722019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2673
2674 * valops.c (value_must_coerce_to_target): Change return type to
2675 bool.
2676 * value.h (value_must_coerce_to_target): Likewise.
2677
f2478a7e
SM		 26782019-07-10 Simon Marchi <simon.marchi@efficios.com>
2679
2680 * breakpoint.c (is_hardware_watchpoint): Remove
2681 forward-declaration.
2682 (is_masked_watchpoint): Change return type to bool.
2683 (is_tracepoint): Likewise.
2684 (is_breakpoint): Likewise.
2685 (is_hardware_watchpoint): Likewise.
2686 (is_watchpoint): Likewise.
2687 (is_no_memory_software_watchpoint): Likewise.
2688 (is_catchpoint): Likewise.
2689 (breakpoint_1): Make FILTER parameter's return type bool.
2690 is_masked_watchpoint): Change return type to bool.
2691 (save_breakpoints): Make FILTER parameter's return type bool.
2692 * breakpoint.h (is_breakpoint): Change return type to bool.
2693 (is_watchpoint): Likewise.
2694 (is_catchpoint): Likewise.
2695 (is_tracepoint): Likewise.
2696
0d12e84c
TT		 26972019-07-10 Tom Tromey <tom@tromey.com>
2698
2699 * defs.h: Don't include gdbarch.h.
2700 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2701 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2702 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2703 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2704 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2705 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2706 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2707 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2708 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2709 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2710 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2711 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2712 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2713 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2714 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2715 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2716 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2717 record-btrace.c, record.h, regcache-dump.c, regcache.h,
2718 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2719 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2720 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2721 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2722 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2723 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2724 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2725 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2726 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2727
f06f1252
TT		 27282019-07-10 Tom Tromey <tromey@adacore.com>
2729
2730 * ada-lang.h (is_ada_exception_catchpoint): Declare.
2731 * breakpoint.c (init_ada_exception_breakpoint): Register as
2732 bp_catchpoint.
2733 (print_one_breakpoint_location, print_one_breakpoint): Use
2734 is_ada_exception_catchpoint.
2735 * ada-lang.c (class ada_catchpoint_location): Pass
2736 bp_loc_software_breakpoint to bp_location constructor.
2737 (is_ada_exception_catchpoint): New function.
2738
7a5d944b
TT		 27392019-07-10 Tom Tromey <tromey@adacore.com>
2740
2741 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
2742 VEC.
2743 (struct arm_exidx_entry): New method operator<.
2744 (struct arm_exidx_data) <section_maps>: Change type.
2745 (arm_exidx_data_free): Remove.
2746 (arm_exidx_data_key): Change type. Move lower.
2747 (arm_exidx_new_objfile): Update.
2748 (arm_compare_exidx_entries): Remove.
2749 (arm_find_exidx_entry, _initialize_arm_tdep)
2750
48c66e1d
TT		 27512019-07-10 Tom Tromey <tromey@adacore.com>
2752
2753 * solib-spu.c (ocl_program_data_key): Change type.
2754 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2755 Update.
2756
a269fbf1
TT		 27572019-07-10 Tom Tromey <tromey@adacore.com>
2758
2759 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
2760 (struct solib_aix_inferior_data) <library_list>: Change type.
2761 (solib_aix_inferior_data_handle): Change type.
2762 (get_solib_aix_inferior_data): Update.
2763 (solib_aix_free_library_list): Remove.
2764 (library_list_start_library): Update.
2765 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2766 return type.
2767 (solib_aix_get_library_list)
2768 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2769 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2770
c294730c
TT		 27712019-07-10 Tom Tromey <tromey@adacore.com>
2772
2773 * solib-dsbt.c (struct dsbt_info): Add initializers.
2774 (solib_dsbt_pspace_data): Change type.
2775 (dsbt_pspace_data_cleanup): Remove.
2776 (get_dsbt_info, _initialize_dsbt_solib): Update.
2777
9d52077d
TT		 27782019-07-10 Tom Tromey <tromey@adacore.com>
2779
2780 * spu-tdep.c (spu_overlay_data): Change type.
2781 (spu_get_overlay_table, spu_overlay_new_objfile)
2782 (_initialize_spu_tdep): Update.
2783
22a20dca
TT		 27842019-07-10 Tom Tromey <tromey@adacore.com>
2785
2786 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2787 destructor.
2788 (dbx_objfile_data_key): Change type and declare later.
2789 (DBX_SYMFILE_INFO): Rewrite.
2790 * dbxread.c (dbx_objfile_data_key): Change type.
2791 (dbx_symfile_init): Update.
2792 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
2793 (coffstab_build_psymtabs, elfstab_build_psymtabs)
2794 (stabsect_build_psymtabs, _initialize_dbxread): Update.
2795
cb60f420
TT		 27962019-07-10 Tom Tromey <tromey@adacore.com>
2797
2798 * jit.c (jit_program_space_key): Change type. Move lower.
2799 (get_jit_program_space_data): Update.
2800 (jit_program_space_data_cleanup): Remove.
2801 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2802 Update.
2803 (struct jit_program_space_data): Add initializers.
2804
51df2ae3
TT		 28052019-07-10 Tom Tromey <tromey@adacore.com>
2806
2807 * solib-darwin.c (struct darwin_info): Add initializers.
2808 (solib_darwin_pspace_data): Change type.
2809 (darwin_pspace_data_cleanup): Remove.
2810 (get_darwin_info, _initialize_darwin_solib): Update.
2811
18101a35
TT		 28122019-07-10 Tom Tromey <tromey@adacore.com>
2813
2814 * remote-sim.c (struct sim_inferior_data): Add initializers,
2815 constructor, and destructor.
2816 (sim_inferior_data_key): Change type. Move lower.
2817 (check_for_duplicate_sim_descriptor): Update.
2818 (get_sim_inferior_data): Use new. Update.
2819 (~sim_inferior_data_cleanup): Rename from
2820 sim_inferior_data_cleanup. Simplify.
2821 (gdbsim_close_inferior, simulator_command)
2822 (sim_command_completer, _initialize_remote_sim): Update.
2823 (next_pid, INITIAL_PID): Move earlier.
2824
05b08ac1
TT		 28252019-07-10 Tom Tromey <tromey@adacore.com>
2826
2827 * python/python-internal.h (create_thread_object): Return
2828 gdbpy_ref.
2829 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2830 * python/py-inferior.c (struct threadlist_entry): Add
2831 constructor.
2832 <thread_obj>: Now a gdbpy_ref.
2833 (thread_to_thread_object): Update.
2834 (add_thread_object): Use new.
2835 (delete_thread_object): Use delete.
2836 (infpy_threads): Update.
2837 (py_free_inferior): Update. Construct "inf_obj" after acquiring
2838 GIL.
2839
32372d80
TT		 28402019-07-10 Tom Tromey <tromey@adacore.com>
2841
2842 * valops.c (value_cast): Specialize error message for Ada.
2843
5c458ae8
SM		 28442019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2845
2846 * breakpoint.c (breakpoint_1): Update doc and parameter names.
2847
4c462cb0
SM		 28482019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2849
2850 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2851 bpstat_should_step): Return bool, adjust comments.
2852 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2853 bpstat_should_step): Likewise.
2854
89abbcc2
AH		 28552019-07-10 Alan Hayward <alan.hayward@arm.com>
2856
2857 * features/Makefile: Use feature target descriptions for Arm.
2858 * features/arm/arm-core.c: Generate new file.
2859 * features/arm/arm-fpa.c: Likewise.
2860 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2861 * features/arm/arm-m-profile.c: Likewise.
2862 * features/arm/arm-vfpv2.c: Likewise.
2863 * features/arm/arm-vfpv3.c: Likewise.
2864 * features/arm/xscale-iwmmxt.c: Likewise.
2865 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2866
166a82be
AH		 28672019-07-10 Alan Hayward <alan.hayward@arm.com>
2868
2869 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2870 ptrace earlier.
2871
9fb4c7e9
AH		 28722019-07-10 Alan Hayward <alan.hayward@arm.com>
2873
2874 * features/aarch64-pauth.c: Regenerate.
2875
e2d0f980
SM		 28762019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
2877
2878 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2879 bool.
2880 (bpstat_what): Use false instead of 0.
2881
a38118e5
PA		 28822019-07-09 Pedro Alves <palves@redhat.com>
2883
2884 * break-catch-throw.c (is_exception_catchpoint): New.
2885 * breakpoint.c (print_one_breakpoint_location): New parameter
2886 'raw_loc'. Handle it. Use
2887 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2888 looking at the breakpoint's type.
2889 (print_one_breakpoint): If handling "maint info breakpoints", also
2890 print locations of exception catchpoints.
2891 * breakpoint.h (is_exception_catchpoint): Declare.
2892
cb1e4e32
PA		 28932019-07-09 Pedro Alves <palves@redhat.com>
2894
2895 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2896 "addr" field.
2897 (allocate_location_exception_catchpoint): New.
2898 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2899 (initialize_throw_catchpoint_ops): Install
2900 allocate_location_exception_catchpoint as allocate_location
2901 method.
2902 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2903 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2904 bp_loc_other.
2905 (breakpoint_address_is_meaningful): Delete.
2906 (bl_address_is_meaningful): New.
2907 (breakpoint_locations_match): Adjust comment.
2908 (bp_location_from_bp_type): New, factored out of...
2909 (bp_location::bp_location(breakpoint *)): ... this.
2910 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2911 factored out of...
2912 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
2913 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2914 breakpoint_address_is_meaningful.
2915 (bp_locations_compare): Adjust comment.
2916 (update_global_location_list): Use bl_address_is_meaningful
2917 instead of breakpoint_address_is_meaningful.
2918 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2919 explicit.
2920 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2921 * python/py-breakpoint.c (bppy_get_location): No longer check
2922 whether location is null.
2923
b58a68fe
PA		 29242019-07-09 Pedro Alves <palves@redhat.com>
2925
2926 PR c++/15468
2927 * breakpoint.c (print_one_breakpoint_location): Remove
2928 single-location assert.
2929
268a13a5
TT		 29302019-07-09 Tom Tromey <tom@tromey.com>
2931
2932 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2933 * configure: Rebuild.
2934 * configure.ac: Change common to gdbsupport.
2935 * gdbsupport: Rename from common.
2936 * acinclude.m4: Change common to gdbsupport.
2937 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2938 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2939 gdbsupport.
2940 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2941 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2942 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2943 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2944 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2945 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2946 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2947 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2948 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2949 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2950 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2951 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2952 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2953 coff-pe-read.c, command.h, compile/compile-c-support.c,
2954 compile/compile-c.h, compile/compile-cplus-symbols.c,
2955 compile/compile-cplus-types.c, compile/compile-cplus.h,
2956 compile/compile-loc2c.c, compile/compile.c, completer.c,
2957 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2958 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2959 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2960 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2961 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2962 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2963 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2964 features/aarch64-core.c, features/aarch64-fpu.c,
2965 features/aarch64-pauth.c, features/aarch64-sve.c,
2966 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2967 features/i386/32bit-core.c, features/i386/32bit-linux.c,
2968 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2969 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2970 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2971 features/i386/64bit-core.c, features/i386/64bit-linux.c,
2972 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2973 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2974 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2975 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2976 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2977 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2978 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2979 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2980 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2981 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2982 go32-nat.c, guile/guile.c, guile/scm-ports.c,
2983 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2984 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2985 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2986 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2987 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2988 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2989 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2990 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2991 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2992 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2993 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2994 minsyms.c, mips-linux-tdep.c, namespace.h,
2995 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2996 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2997 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2998 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2999 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3000 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3001 nat/linux-waitpid.c, nat/mips-linux-watch.c,
3002 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3003 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3004 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3005 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3006 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3007 procfs.c, producer.c, progspace.h, psymtab.h,
3008 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3009 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3010 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3011 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3012 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3013 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3014 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3015 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3016 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3017 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3018 target-memory.c, target.c, target.h, target/waitstatus.c,
3019 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3020 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3021 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3022 unittests/array-view-selftests.c,
3023 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3024 unittests/common-utils-selftests.c,
3025 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3026 unittests/format_pieces-selftests.c,
3027 unittests/function-view-selftests.c,
3028 unittests/lookup_name_info-selftests.c,
3029 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3030 unittests/mkdir-recursive-selftests.c,
3031 unittests/observable-selftests.c,
3032 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3033 unittests/parse-connection-spec-selftests.c,
3034 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3035 unittests/scoped_fd-selftests.c,
3036 unittests/scoped_mmap-selftests.c,
3037 unittests/scoped_restore-selftests.c,
3038 unittests/string_view-selftests.c, unittests/style-selftests.c,
3039 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3040 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3041 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3042 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3043 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3044 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3045
5b0e2db4
AB		 30462019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3047
3048 * linespec.c (decode_digits_list_mode): Set explicit_line to a
3049 bool value.
3050 (decode_digits_ordinary): Set explicit_line field in sal.
3051 * symtab.c (skip_prologue_sal): Don't skip prologue for a
3052 symtab_and_line that was set on an explicit line number in
3053 assembler code. Do always update the recorded symtab and line if
3054 we do skip the prologue.
3055
0ba852ab
AB		 30562019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3057
3058 * breakpoint.c (set_breakpoint_location_function): Remove
3059 explicit_loc parameter.
3060 (momentary_breakpoint_from_master): Update call to
3061 set_breakpoint_location_function.
3062 (add_location_to_breakpoint): Likewise.
3063
b3a7d171
AB		 30642019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3065
3066 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3067 required features based on default bfd type when no specific bfd
3068 is present.
3069
1f6f6e21
PW		 30702019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3071
3072 * NEWS: Mention that GDB printf and eval commands can now print
3073 C-style and Ada-style convenience var strings without
3074 calling the inferior.
3075 * printcmd.c (printf_c_string): Locally print GDB internal var
3076 instead of transiting via the inferior.
3077 (printf_wide_c_string): Likewise.
3078
30792019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH		 3080
3081 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3082
0598af48
TT		 30832019-07-04 Tom Tromey <tom@tromey.com>
3084
3085 PR tui/24724:
3086 * tui/tui-winsource.c (tui_clear_source_content): Update.
3087 (tui_source_window_base::set_is_exec_point_at): Fix comment.
3088 (tui_update_breakpoint_info): Update.
3089 (tui_set_exec_info_content): Update.
3090 * tui/tui-source.c (tui_set_source_content_nil): Update.
3091 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3092 has_break.
3093 * tui/tui-data.h (enum tui_bp_flag): New.
3094 (tui_bp_flags): New enum flags type.
3095 (struct tui_source_element) <break_mode>: Change type. Rename
3096 from has_break.
3097 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3098 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
3099 constants.
3100 * tui/tui-winsource.h: Fix comment.
3101
350fab54
AH		 31022019-07-04 Alan Hayward <alan.hayward@arm.com>
3103
3104 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3105 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3106 (store_fpregs_to_thread)
3107 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3108 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3109 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3110 (IWMMXT_REGS_SIZE): Add define.
3111 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3112 (fetch_vfp_regs, store_vfp_regs)
3113 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3114 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3115
f0452268
AH		 31162019-07-04 Alan Hayward <alan.hayward@arm.com>
3117
3118 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3119 defines.
3120 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3121 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3122 (ARM_INT_REGISTER_SIZE): ...to this.
3123 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3124 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3125 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3126 (arm_linux_collect_gregset, supply_nwfpe_register)
3127 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3128 defines.
3129 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3130 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3131 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3132 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3133 (arm_return_in_memory, arm_store_return_value)
3134 (arm_get_longjmp_target, arm_register_g_packet_guesses)
3135 (arm_record_ld_st_multiple): Likewise.
3136 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3137 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3138
e935475c
AH		 31392019-07-04 Alan Hayward <alan.hayward@arm.com>
3140
3141 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3142 AARCH64_DISPLACED_MODIFIED_INSNS.
3143 * aarch64-tdep.c (struct aarch64_displaced_step_data)
3144 (aarch64_displaced_step_copy_insn): Likewise.
3145 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3146 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3147 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3148 ARM_DISPLACED_MODIFIED_INSNS.
3149 * arm-tdep.c (arm_gdbarch_init): Likewise.
3150 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3151 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3152 (struct arm_displaced_step_closure): Use
3153 ARM_DISPLACED_MODIFIED_INSNS.
3154
df0bb381
AH		 31552019-07-04 Alan Hayward <alan.hayward@arm.com>
3156
3157 * features/Makefile: Remove unused xml files.
3158 * features/aarch64.xml: Remove.
3159 * features/i386/amd64-avx-avx512-linux.xml: Remove.
3160 * features/i386/amd64-avx-avx512.xml: Remove.
3161 * features/i386/amd64-avx-linux.xml: Remove.
3162 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3163 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3164 * features/i386/amd64-avx-mpx-linux.xml: Remove.
3165 * features/i386/amd64-avx-mpx.xml: Remove.
3166 * features/i386/amd64-avx.xml: Remove.
3167 * features/i386/amd64-linux.xml: Remove.
3168 * features/i386/amd64-mpx-linux.xml: Remove.
3169 * features/i386/amd64-mpx.xml: Remove.
3170 * features/i386/amd64.xml: Remove.
3171 * features/i386/i386-avx-avx512-linux.xml: Remove.
3172 * features/i386/i386-avx-avx512.xml: Remove.
3173 * features/i386/i386-avx-linux.xml: Remove.
3174 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3175 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3176 * features/i386/i386-avx-mpx-linux.xml: Remove.
3177 * features/i386/i386-avx-mpx.xml: Remove.
3178 * features/i386/i386-avx.xml: Remove.
3179 * features/i386/i386-linux.xml: Remove.
3180 * features/i386/i386-mmx-linux.xml: Remove.
3181 * features/i386/i386-mmx.xml: Remove.
3182 * features/i386/i386-mpx-linux.xml: Remove.
3183 * features/i386/i386-mpx.xml: Remove.
3184 * features/i386/i386.xml: Remove.
3185 * features/i386/x32-avx-avx512-linux.xml: Remove.
3186 * features/i386/x32-avx-linux.xml: Remove.
3187 * features/i386/x32-linux.xml: Remove.
3188
edd6266a
AH		 31892019-07-04 Alan Hayward <alan.hayward@arm.com>
3190
3191 * regformats/aarch64.dat: Remove.
3192 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3193 * regformats/i386/amd64-avx-linux.dat: Remove.
3194 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3195 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3196 * regformats/i386/amd64-linux.dat: Remove.
3197 * regformats/i386/amd64-mpx-linux.dat: Remove.
3198 * regformats/i386/amd64.dat: Remove.
3199 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3200 * regformats/i386/i386-avx-linux.dat: Remove.
3201 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3202 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3203 * regformats/i386/i386-linux.dat: Remove.
3204 * regformats/i386/i386-mmx-linux.dat: Remove.
3205 * regformats/i386/i386-mpx-linux.dat: Remove.
3206 * regformats/i386/i386.dat: Remove.
3207 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3208 * regformats/i386/x32-avx-linux.dat: Remove.
3209 * regformats/i386/x32-linux.dat: Remove.
3210
2b40fda7
AH		 32112019-07-04 Alan Hayward <alan.hayward@arm.com>
3212
3213 * aarch64-tdep.c: Remove xml self tests.
3214 * amd64-linux-tdep.c: Likewise.
3215 * amd64-tdep.c: Likewise.
3216 * i386-linux-tdep.c: Likewise.
3217 * i386-tdep.c: Likewise.
3218
5f4ba3e7
PA		 32192019-07-03 Pedro Alves <palves@redhat.com>
3220
3221 PR cli/24732
3222 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3223 (pipe_cmd_option_defs): New.
3224 (make_pipe_cmd_options_def_group): New.
3225 (pipe_command): Use gdb::option::process_options.
3226 (pipe_command_completer): New function.
3227 (_initialize_cli_cmds): Install completer for "pipe" command.
3228
3d9be6f5
PA		 32292019-07-03 Pedro Alves <palves@redhat.com>
3230
3231 * cli/cli-option.c (union option_value) <string>: New field.
3232 (struct option_def_and_value): Add ctor, move ctor, dtor and
3233 use DISABLE_COPY_AND_ASSIGN.
3234 (option_def_and_value::clear_value): New.
3235 (parse_option, save_option_value_in_ctx, get_val_type_str)
3236 (add_setshow_cmds_for_options): Handle var_string.
3237 * cli-option.h (union option_def::var_address) <string>: New
3238 field.
3239 (struct string_option_def): New.
3240 * maint-test-options.c (struct test_options_opts): Add default
3241 ctor and use DISABLE_COPY_AND_ASSIGN.
3242 <string_opt>: New field.
3243 (test_options_opts::~test_options_opts): New.
3244 (test_options_opts::dump): Also dump "-string".
3245 (test_options_option_defs): Install "string.
3246
41fc454c
PA		 32472019-07-03 Pedro Alves <palves@redhat.com>
3248
3249 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3250 option_value with a null enumeration.
3251 (complete_options): Save the option values in the context.
3252 (save_option_value_in_ctx): New, factored out from ...
3253 (process_options): ... here.
3254 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3255 of the function.
3256 * maint-test-options.c (test_options_opts::dump): New, factored
3257 out from ...
3258 (maintenance_test_options_command_mode): ... here.
3259 (maintenance_test_options_command_completion_result): Delete.
3260 (maintenance_test_options_command_completion_text): Update
3261 comment.
3262 (maintenance_show_test_options_completion_result): Change
3263 prototype. Just print
3264 maintenance_test_options_command_completion_text.
3265 (save_completion_result): New.
3266 (maintenance_test_options_completer_mode): Pass options context to
3267 complete_options, and then save a dump.
3268 (_initialize_maint_test_options): Use add_cmd to install "maint
3269 show test-options-completion-result".
3270
fdbc9870
PA		 32712019-07-03 Pedro Alves <palves@redhat.com>
3272
3273 * NEWS (New commands): Mention "with" and "maint with".
3274 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3275 (with_command, with_command_completer): New.
3276 (pipe_command): Adjust to new repeat_previous
3277 interface.
3278 (_initialize_cli_cmds): Install the "with" command and its "w"
3279 alias.
3280 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3281 declarations.
3282 * cli/cli-setshow.c (parse_cli_var_uinteger)
3283 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3284 argument strings for all var_types.
3285 (get_setshow_command_value_string): New, factored out from ...
3286 (do_show_command): ... this.
3287 * cli/cli-setshow.h: Include <string>.
3288 (get_setshow_command_value_string): Declare.
3289 * command.h (repeat_previous): Now returns const char *. Adjust
3290 comment.
3291 * maint.c: Include "cli/cli-cmds.h".
3292 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3293 (_initialize_maint_cmds): Register the "maintenance with" command.
3294 * top.c (repeat_previous): Move bits from pipe_command here:
3295 Return the saved command line, if any; error out if there's no
3296 command to relaunch.
3297
c6ac8931
PA		 32982019-07-03 Pedro Alves <palves@redhat.com>
3299
3300 * NEWS (New commands): Mention "maint set/show test-settings"
3301 instead of "maint test-settings".
3302 * maint-test-settings.c (maintenance_test_settings_list): Delete.
3303 (maintenance_test_settings_set_list): Rename to ...
3304 (maintenance_set_test_settings_list): ... this.
3305 (maintenance_test_settings_show_list): Rename to ...
3306 (maintenance_show_test_settings_list): ... this.
3307 (maintenance_test_settings_cmd): Delete.
3308 (maintenance_test_settings_set_cmd): ...
3309 (maintenance_set_test_settings_cmd): ... this.
3310 (maintenance_test_settings_show_cmd): ...
3311 (maintenance_show_test_settings_cmd): ... this.
3312 (maintenance_test_settings_show_value_cmd):
3313 (maintenance_show_test_settings_value_cmd): ... this.
3314 (_initialize_maint_test_settings): No longer install the "maint
3315 test-settings" prefix command. Rename "maint test-settings set"
3316 to "maint set test-settings", and "maint test-settings show" to
3317 "maint show test-settings". Adjust all subcommands.
3318
d1fcf2fd
PA		 33192019-07-03 Pedro Alves <palves@redhat.com>
3320
3321 * maint-test-settings.c: Fix file's intro comment. Replace all
3322 references to "test-options" with references to "test-settings",
3323 in comments.
3324
970f9d09
PA		 33252019-07-03 Pedro Alves <palves@redhat.com>
3326
3327 * maint-test-settings.c (maintenance_test_settings_xxx)
3328 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3329 New.
3330 (maintenance_test_settings_enums): Use them.
3331 (maintenance_test_settings_enum): Default to
3332 maintenance_test_settings_xxx.
3333 (_initialize_maint_test_settings): Initialize
3334 MAINTENANCE_TEST_SETTINGS_FILENAME.
3335
f3869b1a
SM		 33362019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3337
3338 * breakpoint.h (remove_breakpoints_inf): Change return type to
3339 void, move function documentation here.
3340 * breakpoint.c (remove_breakpoints_inf): Change return type to
3341 void, move function documentation to header.
3342
54d66006
PA		 33432019-07-02 Pedro Alves <palves@redhat.com>
3344
3345 * NEWS (Completion improvements): Mention "info threads".
3346 * thread.c (struct info_threads_opts, info_threads_option_defs)
3347 (make_info_threads_options_def_group): New.
3348 (info_threads_command): Use gdb::option::process_options.
3349 (info_threads_command_completer): New.
3350 (_initialize_thread): Use gdb::option::build_help to build the
3351 help text for "info threads".
3352
854f6088
SM		 33532019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3354
3355 * defs.h (generic_load): Move from here...
3356 * symfile.h (generic_load): ... to here. Rename name parameter
3357 to args.
3358 * symfile.c (generic_load): Add comment.
3359
54ee4252
TT		 33602019-07-01 Tom Tromey <tromey@adacore.com>
3361
3362 * dwarf2read.c
3363 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3364 declaration of without_params. Fix formatting.
3365
65392b3e
TT		 33662019-07-01 Tom Tromey <tromey@adacore.com>
3367
3368 * ada-exp.y (find_primitive_type): Update.
3369 * ada-lang.h (ada_lookup_symbol): Update.
3370 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3371 parameter.
3372 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3373
7d7571f0
SDJ		 33742019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3375
3376 PR breakpoints/24541
3377 * gdbarch.c: Regenerate.
3378 * gdbarch.h: Regenerate.
3379 * gdbarch.sh: Add 'stap_adjust_register'.
3380 * i386-tdep.c: Include '<unordered_set>'.
3381 (i386_stap_adjust_register): New function.
3382 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3383 * stap-probe.c (stap_parse_register_operand): Call
3384 'gdbarch_stap_adjust_register'.
3385
5af5392a
SDJ		 33862019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3387
3388 PR python/24742
3389 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3390 * python/python.c (do_start_initialization): Use 'xmalloc'
3391 instead of 'PyMem_Malloc'.
3392
10d06d82
TT		 33932019-06-28 Tom Tromey <tromey@adacore.com>
3394
3395 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3396 for Ada.
3397
1b7f24cd
TT		 33982019-06-27 Tom Tromey <tromey@adacore.com>
3399
3400 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
3401 objfile_key.
3402 (arm_find_mapping_symbol, arm_record_special_symbol)
3403 (_initialize_arm_tdep): Update.
3404 (arm_objfile_data_free): Remove.
3405
3d507ff2
TT		 34062019-06-27 Tom Tromey <tromey@adacore.com>
3407
3408 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3409 to cp_print_static_field.
3410
762c164d
TT		 34112019-06-26 Tom Tromey <tromey@adacore.com>
3412
3413 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3414 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3415 declare.
3416
aa2f9bcf
AH		 34172019-06-26 Alan Hayward <alan.hayward@arm.com>
3418
3419 * features/aarch64-core.c (create_feature_aarch64_core):
3420 Regenerate.
3421 * features/aarch64-core.xml: Add cpsr flags.
3422
3426ae57
AH		 34232019-06-26 Alan Hayward <alan.hayward@arm.com>
3424
3425 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3426 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3427
4838e44c
SM		 34282019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3429
3430 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3431 field.
3432 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3433 use.
3434 (arm_record_special_symbol): Don't insert new symbol in sorted
3435 position, push it at the end.
3436
54cc7474
SM		 34372019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3438
3439 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3440 (arm_mapping_symbol_s): Remove.
3441 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3442 (arm_mapping_symbol_vec): New typedef.
3443 (struct arm_per_objfile): Add constructor.
3444 <section_maps>: Change type to
3445 std::unique_ptr<arm_mapping_symbol_vec[]>.
3446 (arm_compare_mapping_symbols): Remove.
3447 (arm_find_mapping_symbol): Adjust to section_maps type change.
3448 (arm_objfile_data_free): Call delete on arm_per_objfile.
3449 (arm_record_special_symbol): Adjust to section_maps type change.
3450 Allocate arm_per_objfile with new.
3451
b65b566c
PW		 34522019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3453
3454 * cli/cli-cmds.c (alias_command): Compare the alias prefix
3455 with the command prefix.
3456
c2fc64f5
TT		 34572019-06-25 Tom Tromey <tom@tromey.com>
3458
3459 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3460 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3461
fb54fa76
TT		 34622019-06-25 Tom Tromey <tom@tromey.com>
3463
3464 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3465 type.
3466 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3467 protected.
3468
f7952c57
TT		 34692019-06-25 Tom Tromey <tom@tromey.com>
3470
3471 * tui/tui-winsource.c
3472 (tui_source_window_base::set_is_exec_point_at): Add check against
3473 LOA_ADDRESS.
3474
17568d78
TT		 34752019-06-25 Tom Tromey <tom@tromey.com>
3476
3477 * tui/tui-source.c (tui_set_source_content): Don't check before
3478 xfree.
3479 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3480
53e7cdba
TT		 34812019-06-25 Tom Tromey <tom@tromey.com>
3482
3483 * tui/tui-winsource.h (tui_update_source_window_as_is)
3484 (tui_alloc_source_buffer, tui_line_is_displayed)
3485 (tui_addr_is_displayed): Change type of win_info.
3486 * tui/tui-winsource.c (tui_update_source_window_as_is)
3487 (tui_clear_source_content, tui_show_source_line)
3488 (tui_show_source_content, tui_source_window_base::refill)
3489 (tui_source_window_base::set_is_exec_point_at)
3490 (tui_source_window_base::set_is_exec_point_at)
3491 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3492 (tui_alloc_source_buffer, tui_line_is_displayed)
3493 (tui_addr_is_displayed): Change type of win_info. Update.
3494 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3495 (tui_source_window_base::do_make_visible_with_new_height):
3496 Update.
3497 * tui/tui-source.c (tui_set_source_content)
3498 (tui_set_source_content_nil)
3499 (tui_source_window::do_scroll_vertical): Update.
3500 * tui/tui-layout.c (show_layout): Update.
3501 * tui/tui-disasm.c (tui_set_disassem_content)
3502 (tui_disasm_window::do_scroll_vertical): Update.
3503 * tui/tui-data.h (tui_win_content): Remove.
3504 (struct tui_gen_win_info) <content, content_size>: Remove.
3505 (struct tui_source_element): Add initializers and destructor.
3506 (union tui_which_element, struct tui_win_element): Remove.
3507 (struct tui_source_window_base) <content>: New field.
3508 (struct tui_data_window): Remove destructor.
3509 (tui_alloc_content, tui_free_win_content)
3510 (tui_free_all_source_wins_content): Don't declare.
3511 * tui/tui-data.c (tui_initialize_static_data): Update.
3512 (init_content_element, tui_alloc_content): Remove.
3513 (~tui_gen_win_info): Update.
3514 (~tui_data_window, tui_free_all_source_wins_content)
3515 (tui_free_win_content, free_content, free_content_elements):
3516 Remove.
3517
7908abbf
TT		 35182019-06-25 Tom Tromey <tom@tromey.com>
3519
3520 * tui/tui-winsource.h (tui_clear_source_content)
3521 (tui_erase_source_content, tui_show_source_content): Change type
3522 of win_info.
3523 * tui/tui-winsource.c (tui_clear_source_content)
3524 (tui_erase_source_content, tui_show_source_content): Change type
3525 of win_info.
3526 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3527 * tui/tui-source.h (tui_set_source_content_nil): Change type of
3528 win_info.
3529 * tui/tui-source.c (tui_set_source_content_nil): Change type of
3530 win_info.
3531 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3532
02c28df0
TT		 35332019-06-25 Tom Tromey <tom@tromey.com>
3534
3535 * tui/tui-winsource.c (tui_clear_source_content)
3536 (tui_source_window_base::set_is_exec_point_at): Update.
3537 * tui/tui-source.c (tui_set_source_content_nil): Update.
3538 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3539 a bool.
3540 * tui/tui-data.c (init_content_element): Update.
3541
6658b1bf
TT		 35422019-06-25 Tom Tromey <tom@tromey.com>
3543
3544 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3545 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3546 * tui/tui-layout.c (init_and_make_win): Update.
3547 * tui/tui.h (enum tui_win_type): Update.
3548 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3549 tui_win_is_auxillary.
3550 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3551 tui_win_is_auxillary.
3552
21e1c91e
TT		 35532019-06-25 Tom Tromey <tom@tromey.com>
3554
3555 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3556 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3557 (tui_delete_data_content_windows, tui_display_all_data)
3558 (tui_data_window::do_scroll_vertical, tui_display_data_from):
3559 Update.
3560 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3561 * tui/tui-regs.c (tui_last_regs_line_no)
3562 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3563 (tui_show_registers): Update.
3564 (tui_show_register_group): Return void. Update.
3565 (tui_display_registers_from, tui_display_reg_element_at_line)
3566 (tui_display_registers_from_line, tui_check_register_values):
3567 Update.
3568 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3569 member.
3570 (struct tui_data_window) <regs_content>: Now a std::vector.
3571 <regs_content_count>: Remove.
3572 (tui_add_content_elements, tui_free_data_content): Don't declare.
3573 * tui/tui-data.c (tui_data_window::clear_detail): Update.
3574 (init_content_element): Remove DATA_WIN case. Add assert.
3575 (tui_add_content_elements): Remove.
3576 (tui_data_window): Update.
3577 (tui_free_data_content): Remove.
3578 (free_content_elements): Remove DATA_WIN case.
3579
115ac53b
TT		 35802019-06-25 Tom Tromey <tom@tromey.com>
3581
3582 * tui/tui-data.c (tui_data_item_window): Update.
3583 * tui/tui-windata.h (tui_check_data_values): Don't declare.
3584 * tui/tui-windata.c (tui_display_all_data)
3585 (tui_display_data_from_line): Update.
3586 (tui_check_data_values): Remove.
3587 * tui/tui-regs.c (tui_show_register_group)
3588 (tui_display_reg_element_at_line): Update.
3589 * tui/tui-hooks.c (tui_register_changed)
3590 (tui_refresh_frame_and_register_information): Call
3591 tui_check_register_values.
3592 * tui/tui-data.h (struct tui_data_window) <data_content,
3593 data_content_count, data_type>: Remove.
3594 (enum tui_data_type): Remove.
3595
3596 * tui/tui-data.c (tui_data_window::clear_detail)
3597 (~tui_data_window): Update.
3598
eaf9738b
TT		 35992019-06-25 Tom Tromey <tom@tromey.com>
3600
3601 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3602 declare.
3603 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3604 Rename from tui_first_data_item_displayed. Update.
3605 (tui_data_window::refresh_all)
3606 (tui_data_window::do_scroll_vertical): Update.
3607 * tui/tui-data.h (struct tui_data_window)
3608 <first_data_item_displayed>: Declare new method.
3609
31ca4723
TT		 36102019-06-25 Tom Tromey <tom@tromey.com>
3611
3612 * tui/tui-data.h (tui_init_generic_part): Don't declare.
3613 * tui/tui-data.c (tui_init_generic_part): Remove, moving
3614 contents...
3615 (tui_initialize_static_data): ...here.
3616
41bcff7f
TT		 36172019-06-25 Tom Tromey <tom@tromey.com>
3618
3619 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3620 (tui_display_registers_from, tui_check_register_values): Update.
3621 (tui_display_register): Remove win_info parameter; update.
3622 (tui_get_register): Change type of parameters.
3623 * tui/tui-data.h (struct tui_data_element): Remove.
3624 (union tui_which_element) <data>: Remove.
3625 <data_window>: Change type.
3626 (struct tui_data_item_window): New.
3627 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3628 case. Add assert.
3629 (~tui_data_item_window): New destructor.
3630 (free_content_elements): Remove DATA_ITEM_WIN case.
3631
d2802c33
TT		 36322019-06-25 Tom Tromey <tom@tromey.com>
3633
3634 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3635 Remove.
3636
dd835f8b
TT		 36372019-06-25 Tom Tromey <tom@tromey.com>
3638
3639 * tui/tui-data.h (struct tui_command_element): Remove.
3640 (union tui_which_element) <command>: Remove.
3641 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
3642 assert.
3643 (free_content_elements): Remove CMD_WIN case.
3644
bd7db367
TT		 36452019-06-25 Tom Tromey <tom@tromey.com>
3646
3647 * tui/tui-layout.c (tui_set_layout): Update.
3648 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3649 * tui/tui-data.c (layout_def): Update.
3650
3add462f
TT		 36512019-06-25 Tom Tromey <tom@tromey.com>
3652
3653 * tui/tui-wingeneral.c (tui_refresh_all): Update.
3654 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3655 (tui_source_window_base::set_new_height): Update.
3656 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3657 Update.
3658 (tui_set_locator_fullname, tui_set_locator_info)
3659 (tui_show_frame_info): Update.
3660 * tui/tui-source.c (tui_set_source_content)
3661 (tui_source_is_displayed): Update.
3662 * tui/tui-layout.c (show_source_disasm_command, show_data)
3663 (show_source_or_disasm_and_command): Update.
3664 * tui/tui-disasm.c (tui_set_disassem_content)
3665 (tui_get_begin_asm_address): Update.
3666 * tui/tui-data.h (struct tui_locator_element): Remove.
3667 (union tui_which_element) <locator>: Remove.
3668 (struct tui_locator_window): New.
3669 (tui_locator_win_info_ptr): Change return type.
3670 * tui/tui-data.c (_locator): Change type.
3671 (tui_locator_win_info_ptr): Change return type.
3672 (init_content_element): Remove LOCATOR_WIN case. Add assert.
3673 (tui_alloc_content): Add assert.
3674
489e9d8b
TT		 36752019-06-25 Tom Tromey <tom@tromey.com>
3676
3677 * tui/tui-winsource.c
3678 (tui_exec_info_window::maybe_allocate_content): New method.
3679 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3680 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3681 (make_source_or_disasm_window): Add cast.
3682 * tui/tui-data.h (union tui_which_element) <simple_string>:
3683 Remove.
3684 (struct tui_source_info): New.
3685 (struct tui_source_window_base) <execution_info>: Change type.
3686 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3687 case, and add assert.
3688 (tui_alloc_content): Add assert.
3689
c3fabb7d
TT		 36902019-06-25 Tom Tromey <tom@tromey.com>
3691
3692 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3693 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3694 * tui/tui-data.c (tui_alloc_win_info): Remove.
3695
bbc228ee
TT		 36962019-06-25 Tom Tromey <tom@tromey.com>
3697
3698 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3699 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3700 can_highlight.
3701
5fcee43a
TT		 37022019-06-25 Tom Tromey <tom@tromey.com>
3703
3704 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3705 make_visible_with_new_height method.
3706 (tui_win_info::make_visible_with_new_height): New method.
3707 (tui_source_window_base::do_make_visible_with_new_height)
3708 (tui_data_window::do_make_visible_with_new_height)
3709 (tui_cmd_window::do_make_visible_with_new_height): New methods.
3710 (make_visible_with_new_height): Remove.
3711 (tui_resize_all, tui_adjust_win_heights): Use
3712 make_visible_with_new_height method.
3713 * tui/tui-data.h (struct tui_win_info)
3714 <do_make_visible_with_new_height, make_visible_with_new_height>:
3715 New methods.
3716 (struct tui_source_window_base, struct tui_data_window)
3717 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3718 methods.
3719
d83f1fe6
TT		 37202019-06-25 Tom Tromey <tom@tromey.com>
3721
3722 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3723 method.
3724 (update_tab_width): Call update_tab_width method.
3725 * tui/tui-data.h (struct tui_win_info)
3726 (struct tui_source_window_base) <update_tab_width>: New methods.
3727
17374de4
TT		 37282019-06-25 Tom Tromey <tom@tromey.com>
3729
3730 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3731 parameter.
3732 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3733 parameter.
3734 (tui_gen_win_info::make_visible): Update.
3735 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3736 parameter.
3737 * tui/tui-data.h (enum tui_box): New enum.
3738 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3739
f936bca2
TT		 37402019-06-25 Tom Tromey <tom@tromey.com>
3741
3742 * tui/tui-layout.c (make_source_or_disasm_window): Always use
3743 init_and_make_win for EXEC_INFO_WIN.
3744 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3745 longer inline.
3746 (struct tui_win_info) <~tui_win_info>: Inline.
3747 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3748 Don't declare.
3749 * tui/tui-data.c (source_win, disasm_win): Remove globals.
3750 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3751 Remove.
3752 (tui_initialize_static_data): Update.
3753 (~tui_gen_win_info): Handle more cleanup here.
3754 (~tui_source_window_base): Delete "execution_info".
3755 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3756
d6ba6a11
TT		 37572019-06-25 Tom Tromey <tom@tromey.com>
3758
3759 * tui/tui-layout.c (make_command_window): Don't set
3760 can_highlight.
3761 (show_source_disasm_command): Call the reset method.
3762 (show_data): Don't set can_highlight. Call the reset method.
3763 (tui_gen_win_info::reset): Rename from init_gen_win_info
3764 (init_and_make_win): Simplify. Return tui_gen_win_info.
3765 (show_source_or_disasm_and_command): Call the reset method.
3766 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3767 (struct tui_cmd_window): Set can_highlight.
3768
48a3bd16
TT		 37692019-06-25 Tom Tromey <tom@tromey.com>
3770
3771 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3772 from make_visible.
3773 (tui_make_visible, tui_make_invisible): Rewrite.
3774 (tui_win_info::make_visible): Remove.
3775 (tui_source_window_base::make_visible): Update.
3776 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3777 method. Moved from...
3778 (struct tui_win_info) <make_visible>: ...here.
3779
c3bd716f
TT		 37802019-06-25 Tom Tromey <tom@tromey.com>
3781
3782 * tui/tui-winsource.c
3783 (tui_source_window_base::do_scroll_horizontal): Remove direction
3784 parameter.
3785 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3786 direction parameter.
3787 * tui/tui-win.c (tui_win_info::forward_scroll)
3788 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3789 (tui_win_info::right_scroll): Update.
3790 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3791 direction parameter.
3792 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3793 direction parameter.
3794 * tui/tui-data.h (enum tui_scroll_direction): Remove.
3795 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3796 Remove direction parameter.
3797 (struct tui_source_window_base, struct tui_source_window)
3798 (struct tui_disasm_window, struct tui_data_window)
3799 (struct tui_cmd_window): Update.
3800
21c32dca
TT		 38012019-06-25 Tom Tromey <tom@tromey.com>
3802
3803 * tui/tui-winsource.h (tui_set_exec_info_content)
3804 (tui_show_exec_info_content, tui_erase_exec_info_content)
3805 (tui_clear_exec_info_content, tui_update_exec_info): Change
3806 argument to tui_source_window_base.
3807 * tui/tui-winsource.c (tui_set_exec_info_content)
3808 (tui_show_exec_info_content, tui_erase_exec_info_content)
3809 (tui_clear_exec_info_content, tui_update_exec_info): Change
3810 argument to tui_source_window_base.
3811
73fbdc65
TT		 38122019-06-25 Tom Tromey <tom@tromey.com>
3813
3814 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3815 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3816
33325343
TT		 38172019-06-25 Tom Tromey <tom@tromey.com>
3818
3819 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3820 check.
3821
29d2c474
TT		 38222019-06-25 Tom Tromey <tom@tromey.com>
3823
3824 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3825 type to void.
3826 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3827 type to void.
3828 * tui/tui-source.c (tui_set_source_content): Update.
3829 * tui/tui-disasm.c (tui_set_disassem_content): Update.
3830
152f3f4b
TT		 38312019-06-25 Tom Tromey <tom@tromey.com>
3832
3833 * tui/tui-win.c (window_name_completer, tui_set_focus)
3834 (tui_all_windows_info): Use name method.
3835 * tui/tui-data.h (struct tui_gen_win_info)
3836 (struct tui_source_window, struct tui_disasm_window)
3837 (struct tui_data_window, struct tui_cmd_window) <name>: New
3838 method.
3839 (tui_win_name): Don't declare.
3840 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3841 (tui_win_name): Remove.
3842
be4da588
TT		 38432019-06-25 Tom Tromey <tom@tromey.com>
3844
3845 * tui/tui-winsource.h (tui_update_source_window)
3846 (tui_update_source_window_as_is): Change parameter type.
3847 * tui/tui-winsource.c (tui_update_source_window): Change win_info
3848 to be a tui_source_window_base.
3849 (tui_update_source_window_as_is): Likewise.
3850 * tui/tui-win.c (make_visible_with_new_height): Update.
3851
5b81daba
TT		 38522019-06-25 Tom Tromey <tom@tromey.com>
3853
3854 * tui/tui-winsource.c (tui_erase_source_content)
3855 (tui_show_source_content, tui_show_exec_info_content)
3856 (tui_erase_exec_info_content): Use refresh_window method.
3857 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3858 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3859 from tui_refresh_win.
3860 (tui_data_window::refresh_window): New method.
3861 (tui_win_info::refresh, tui_source_window_base::refresh)
3862 (tui_refresh_all): Use refresh_window method.
3863 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3864 method.
3865 * tui/tui-regs.c (tui_display_register): Call refresh_window
3866 method.
3867 * tui/tui-layout.c (show_source_disasm_command)
3868 (show_source_or_disasm_and_command): Call refresh_window method.
3869 * tui/tui-data.h (struct tui_gen_win_info)
3870 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3871 New method.
3872
cb2ce893
TT		 38732019-06-25 Tom Tromey <tom@tromey.com>
3874
3875 * tui/tui.c (tui_rl_other_window, tui_enable)
3876 (tui_is_window_visible, tui_get_command_dimension): Update.
3877 * tui/tui-winsource.c (tui_update_source_window_as_is)
3878 (tui_clear_source_content, tui_erase_source_content)
3879 (tui_show_source_line, tui_source_window_base::refill)
3880 (tui_source_window_base::do_scroll_horizontal)
3881 (tui_source_window_base::set_is_exec_point_at)
3882 (tui_update_breakpoint_info, tui_set_exec_info_content)
3883 (tui_alloc_source_buffer, tui_line_is_displayed)
3884 (tui_addr_is_displayed): Update.
3885 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3886 (tui_check_and_display_highlight_if_needed)
3887 (tui_win_info::make_visible, tui_win_info::refresh)
3888 (tui_refresh_all): Update.
3889 * tui/tui-windata.c (tui_first_data_item_displayed)
3890 (tui_delete_data_content_windows, tui_erase_data_content)
3891 (tui_display_all_data, tui_data_window::refresh_all)
3892 (tui_check_data_values): Update.
3893 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3894 (tui_set_win_focus_to, tui_win_info::forward_scroll)
3895 (tui_win_info::backward_scroll, tui_refresh_all_win)
3896 (tui_resize_all, tui_set_focus, tui_all_windows_info)
3897 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3898 (tui_source_window_base::set_new_height)
3899 (tui_data_window::set_new_height)
3900 (make_invisible_and_set_new_height)
3901 (make_visible_with_new_height, new_height_ok)
3902 (parse_scrolling_args): Update.
3903 * tui/tui-stack.c (tui_show_frame_info): Update.
3904 * tui/tui-source.c (tui_set_source_content)
3905 (tui_set_source_content_nil, tui_source_is_displayed)
3906 (tui_source_window::do_scroll_vertical): Update.
3907 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3908 (tui_display_registers_from, tui_display_reg_element_at_line)
3909 (tui_check_register_values, tui_reg_command): Update.
3910 * tui/tui-layout.c (tui_default_win_height)
3911 (show_source_disasm_command, show_data, init_and_make_win)
3912 (show_source_or_disasm_and_command): Update.
3913 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3914 (tui_redisplay_readline, tui_mld_flush)
3915 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3916 (tui_getc): Update.
3917 * tui/tui-disasm.c (tui_set_disassem_content)
3918 (tui_disasm_window::do_scroll_vertical): Update.
3919 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3920 Now virtual.
3921 (struct tui_win_info): Derive from tui_gen_win_info.
3922 <~tui_win_info>: Mark as override.
3923 <generic>: Remove member.
3924 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3925 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3926 (~tui_data_window, ~tui_win_info)
3927 (tui_free_all_source_wins_content): Update.
3928 * tui/tui-command.c (tui_refresh_cmd_win): Update.
3929
ab313b35
TT		 39302019-06-25 Tom Tromey <tom@tromey.com>
3931
3932 * tui/tui-layout.c (init_and_make_win): Use new.
3933 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3934 destructor, initializers.
3935 (tui_alloc_generic_win_info): Don't declare.
3936 * tui/tui-data.c (_locator): Add argument to constructor.
3937 (source_win, disasm_win): New globals.
3938 (exec_info): Remove.
3939 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3940 Update.
3941 (tui_alloc_generic_win_info): Remove.
3942 (init_content_element): Use new.
3943 (tui_win_info::tui_win_info): Update.
3944 (free_content_elements) <case DATA_WIN>: Use delete.
3945
dc2c33e4
TT		 39462019-06-25 Tom Tromey <tom@tromey.com>
3947
3948 * tui/tui-wingeneral.c (tui_refresh_win): Update.
3949 * tui/tui-windata.c (tui_first_data_item_displayed)
3950 (tui_delete_data_content_windows): Update.
3951 * tui/tui-win.c (tui_data_window::set_new_height): Update.
3952 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3953 (tui_display_registers_from, tui_check_register_values): Update.
3954 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3955 pointer.
3956 * tui/tui-data.c (init_content_element): Update. Allocate the new
3957 window.
3958 (tui_free_data_content): Update.
3959 (free_content_elements) <case DATA_WIN>: Free the window.
3960
214a5cbe
TT		 39612019-06-25 Tom Tromey <tom@tromey.com>
3962
3963 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3964 Update.
3965 * tui/tui-layout.c (make_command_window)
3966 (show_source_disasm_command, show_data, init_and_make_win)
3967 (show_source_or_disasm_and_command): Update.
3968 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3969 method.
3970 <can_highight, is_highlighted>: Now bool.
3971 (tui_set_win_highlight): Don't declare.
3972 * tui/tui-data.c (tui_set_win_highlight): Remove.
3973
8e2daf15
TT		 39742019-06-25 Tom Tromey <tom@tromey.com>
3975
3976 * tui/tui-wingeneral.c (make_visible): Remove check of window
3977 type.
3978
8903bd8a
TT		 39792019-06-25 Tom Tromey <tom@tromey.com>
3980
3981 * tui/tui-win.c (tui_win_info::max_height)
3982 (tui_cmd_window::max_height): New methods.
3983 (new_height_ok): Call max_height.
3984 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3985 <max_height>: New method.
3986
3f02ce1e
TT		 39872019-06-25 Tom Tromey <tom@tromey.com>
3988
3989 * tui/tui-win.c (tui_source_window_base::set_new_height)
3990 (tui_data_window::set_new_height): New methods.
3991 (make_invisible_and_set_new_height): Call set_new_height method.
3992 * tui/tui-data.h (struct tui_win_info)
3993 (struct tui_source_window_base, struct tui_data_window)
3994 <set_new_height>: New method.
3995
1825f487
TT		 39962019-06-25 Tom Tromey <tom@tromey.com>
3997
3998 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3999 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4000 tui_refresh_data_win.
4001 * tui/tui-win.c (tui_source_window_base::refresh_all): New
4002 method.
4003 (tui_refresh_all_win): Call the refresh_all method.
4004 (tui_set_focus): Likewise.
4005 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4006 (struct tui_source_window_base, struct tui_data_window) <refresh>:
4007 Likewise.
4008
ad54d15b
TT		 40092019-06-25 Tom Tromey <tom@tromey.com>
4010
4011 * tui/tui-winsource.h (tui_refill_source_window)
4012 (tui_set_is_exec_point_at): Don't declare.
4013 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4014 (tui_source_window_base::refill): Rename from
4015 tui_refill_source_window.
4016 (tui_source_window_base::do_scroll_horizontal): Update.
4017 (tui_source_window_base::set_is_exec_point_at): Rename from
4018 tui_set_is_exec_point_at.
4019 (tui_update_all_breakpoint_info): Update.
4020 * tui/tui-stack.c (tui_show_frame_info): Update.
4021 * tui/tui-layout.c (show_data): Add cast.
4022 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4023 * tui/tui-data.h (struct tui_source_window_base) <refill,
4024 set_is_exec_point_at>: New methods.
4025 (tui_source_windows, tui_add_to_source_windows): Update types.
4026 (tui_add_to_source_windows): Remove redundant declaration.
4027 * tui/tui-data.c (source_windows): Store tui_source_window_base.
4028 (tui_source_windows): Change return type.
4029 (tui_clear_source_windows_detail): Update.
4030 (tui_add_to_source_windows): Change type of parameter.
4031 (tui_free_all_source_wins_content): Update.
4032
2042b506
TT		 40332019-06-25 Tom Tromey <tom@tromey.com>
4034
4035 * tui/tui-wingeneral.c (tui_win_info::refresh)
4036 (tui_source_window_base::refresh): New methods.
4037 (tui_refresh_all): Call the refresh method.
4038 * tui/tui-data.h (struct tui_win_info)
4039 (struct tui_source_window_base) <refresh>: New method.
4040
56122977
TT		 40412019-06-25 Tom Tromey <tom@tromey.com>
4042
4043 * tui/tui.h (tui_is_window_visible): Return bool.
4044 * tui/tui.c (tui_is_window_visible): Return bool.
4045 * tui/tui-wingeneral.c (tui_make_window, make_visible)
4046 (tui_make_visible, tui_make_invisible)
4047 (tui_win_info::make_visible)
4048 (tui_source_window_base::make_visible, make_all_visible)
4049 (tui_make_all_visible, tui_make_all_invisible): Update.
4050 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4051 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4052 bool.
4053 (struct tui_win_info, struct tui_source_window_base)
4054 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4055 * tui/tui-data.c (tui_init_generic_part): Update.
4056
cda37efb
TT		 40572019-06-25 Tom Tromey <tom@tromey.com>
4058
4059 * tui/tui-wingeneral.c (tui_win_info::make_visible)
4060 (tui_source_window_base::make_visible): New methods.
4061 (make_all_visible): Make method call.
4062 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4063 (struct tui_source_window_base, struct tui_cmd_window): Override
4064 make_visible.
4065 (tui_win_is_source_type): Don't declare.
4066 * tui/tui-data.c (tui_win_is_source_type): Remove.
4067
6a0ee02c
TT		 40682019-06-25 Tom Tromey <tom@tromey.com>
4069
4070 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4071 NULL check.
4072
63901aec
TT		 40732019-06-25 Tom Tromey <tom@tromey.com>
4074
4075 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4076 Inline constructor. Add initializers for members.
4077 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4078 constructors; now inline in class.
4079
ceb13a13
TT		 40802019-06-25 Tom Tromey <tom@tromey.com>
4081
4082 * tui/tui-regs.c (tui_show_registers): Update.
4083 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4084 bool.
4085 * tui/tui-data.c (tui_data_window::clear_detail)
4086 (tui_data_window): Update.
4087
238eb706
TT		 40882019-06-25 Tom Tromey <tom@tromey.com>
4089
4090 * tui/tui-windata.c (tui_display_all_data)
4091 (tui_display_data_from_line, tui_display_data_from)
4092 (tui_check_data_values, tui_data_window::do_scroll_vertical):
4093 Update.
4094 * tui/tui-regs.c (tui_last_regs_line_no)
4095 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4096 (tui_show_registers, tui_show_register_group)
4097 (tui_display_registers_from, tui_display_reg_element_at_line)
4098 (tui_display_registers_from_line, tui_check_register_values)
4099 (tui_reg_next, tui_reg_prev): Update.
4100 * tui/tui-layout.c (tui_set_layout, show_data): Update.
4101 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
4102 tui_data_window.
4103 (struct tui_win_info) <detail>: Remove. Add new fields from
4104 tui_data_info.
4105 (TUI_DATA_WIN): Add cast.
4106 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4107 (~tui_data_window): Simplify.
4108
81491aa0
TT		 41092019-06-25 Tom Tromey <tom@tromey.com>
4110
4111 * tui/tui-layout.c (show_source_disasm_command)
4112 (show_source_or_disasm_and_command): Update.
4113 * tui/tui-io.c (update_cmdwin_start_line)
4114 (tui_redisplay_readline): Update.
4115 * tui/tui-data.h (struct tui_command_info): Remove.
4116 (struct tui_win_info) <detail>: Remove command_info member.
4117 (struct tui_data_window) <start_line>: New member, from
4118 tui_command_info.
4119 (TUI_CMD_WIN): Add casts.
4120
e6e41501
TT		 41212019-06-25 Tom Tromey <tom@tromey.com>
4122
4123 * tui/tui-winsource.c (tui_update_source_window)
4124 (tui_refill_source_window)
4125 (tui_source_window_base::do_scroll_horizontal)
4126 (tui_update_breakpoint_info, tui_set_exec_info_content)
4127 (tui_show_exec_info_content, tui_erase_exec_info_content)
4128 (tui_clear_exec_info_content): Update.
4129 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4130 Update.
4131 * tui/tui-win.c (make_invisible_and_set_new_height)
4132 (make_visible_with_new_height): Update.
4133 * tui/tui-source.c (tui_set_source_content)
4134 (tui_show_symtab_source): Update.
4135 * tui/tui-layout.c (extract_display_start_addr)
4136 (show_source_disasm_command, show_data)
4137 (make_source_or_disasm_window)
4138 (show_source_or_disasm_and_command): Update.
4139 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4140 (tui_disasm_window::do_scroll_vertical): Remove shadowing
4141 "gdbarch".
4142 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
4143 to tui_source_window_base.
4144 (struct tui_win_info) <detail>: Remove source_info member.
4145 (struct tui_source_window_base) <has_locator>: Inline.
4146 Move contents from tui_source_info; rename has_locator member to
4147 m_has_locator.
4148 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4149 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4150 header file.
4151 (tui_source_window_base::clear_detail, ~tui_source_window_base):
4152 Simplify.
4153 (tui_free_all_source_wins_content): Cast to
4154 tui_source_window_base.
4155
44f0e208
TT		 41562019-06-25 Tom Tromey <tom@tromey.com>
4157
4158 * tui/tui-win.c (make_invisible_and_set_new_height)
4159 (make_visible_with_new_height): Call has_locator method.
4160 * tui/tui-layout.c (show_source_disasm_command, show_data)
4161 (show_source_or_disasm_and_command): Update for bool change.
4162 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4163 (tui_win_info) <has_locator>: New method.
4164 (struct tui_source_window_base) <has_locator>: New method.
4165 (tui_win_has_locator): Don't declare.
4166 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4167 from tui_win_has_locator.
4168 (tui_source_window_base): Use false, not FALSE.
4169
7778b912
TT		 41702019-06-25 Tom Tromey <tom@tromey.com>
4171
4172 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4173 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4174 clear_detail method directly.
4175 (tui_clear_win_detail): Remove.
4176
f83d391c
TT		 41772019-06-25 Tom Tromey <tom@tromey.com>
4178
4179 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4180 "this", not TUI_DISASM_WIN.
4181
13446e05
TT		 41822019-06-25 Tom Tromey <tom@tromey.com>
4183
4184 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
4185 declare.
4186 * tui/tui-winsource.c
4187 (tui_source_window_base::do_scroll_horizontal): Rename from
4188 tui_horizontal_source_scroll.
4189 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4190 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4191 from tui_vertical_data_scroll.
4192 * tui/tui-win.h (tui_scroll): Don't declare.
4193 * tui/tui-win.c (tui_win_info::forward_scroll)
4194 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4195 (tui_win_info::right_scroll): Rename and update.
4196 (tui_scroll_forward_command, tui_scroll_backward_command)
4197 (tui_scroll_left_command, tui_scroll_right_command): Update.
4198 (tui_scroll): Remove.
4199 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4200 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4201 from tui_vertical_source_scroll.
4202 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4203 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4204 from tui_vertical_disassem_scroll.
4205 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4206 do_scroll_horizontal>: New methods.
4207 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4208 Likewise.
4209 (struct tui_source_window_base): Add do_scroll_horizontal.
4210 (struct tui_source_window, struct tui_disasm_window): Add
4211 do_scroll_vertical.
4212 (struct tui_data_window, struct tui_cmd_window): Add
4213 do_scroll_horizontal and do_scroll_vertical.
4214 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4215
5cf82909
TT		 42162019-06-25 Tom Tromey <tom@tromey.com>
4217
4218 * tui/tui-data.h (struct tui_source_window_base): New struct.
4219 (struct tui_source_window): Derive from tui_source_window_base.
4220 (struct tui_disasm_window): New struct.
4221 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4222 from tui_source_window::clear_detail.
4223 (tui_source_window_base): Rename from tui_source_window.
4224 (~tui_source_window_base): Rename from ~tui_source_window.
4225 (tui_alloc_win_info): Create a tui_disasm_window.
4226
ee1d42d6
TT		 42272019-06-25 Tom Tromey <tom@tromey.com>
4228
4229 * tui/tui-data.h (struct tui_source_window)
4230 (struct tui_data_window): Declare destructors.
4231 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4232 destructors.
4233 (tui_win_info): Simplify.
4234
b4eb2452
TT		 42352019-06-25 Tom Tromey <tom@tromey.com>
4236
4237 * tui/tui-winsource.c (tui_display_main)
4238 (tui_update_source_windows_with_addr)
4239 (tui_update_all_breakpoint_info): Update.
4240 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4241 (new_height_ok, parse_scrolling_args): Update.
4242 * tui/tui-stack.c (tui_show_frame_info): Update.
4243 * tui/tui-data.h (struct tui_list): Remove.
4244 (tui_source_windows): Return a reference to a std::vector.
4245 * tui/tui-data.c (source_windows): Now a std::vector.
4246 (tui_source_windows): Change return type.
4247 (tui_clear_source_windows): Rewrite.
4248 (tui_clear_source_windows_detail, tui_add_to_source_windows)
4249 (tui_free_all_source_wins_content): Rewrite.
4250
8761a91b
TT		 42512019-06-25 Tom Tromey <tom@tromey.com>
4252
4253 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4254 (struct tui_data_window, struct tui_cmd_window): Declare
4255 clear_detail method.
4256 * tui/tui-data.c (tui_source_window::clear_detail)
4257 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4258 methods.
4259 (tui_clear_win_detail): Simplify.
4260
0ed69eda
TT		 42612019-06-25 Tom Tromey <tom@tromey.com>
4262
4263 * tui/tui-layout.c (make_source_window, make_disasm_window)
4264 (make_source_or_disasm_window): Remove win_info_ptr parameter.
4265 Return the new window.
4266 (show_source_disasm_command, show_data)
4267 (show_source_or_disasm_and_command): Update.
4268
82432e10
TT		 42692019-06-25 Tom Tromey <tom@tromey.com>
4270
4271 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4272 parameter. Return the new window.
4273 (show_source_disasm_command): Update and remove NULL check.
4274 (show_source_or_disasm_and_command): Update.
4275
ec328aa5
TT		 42762019-06-25 Tom Tromey <tom@tromey.com>
4277
4278 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4279
33b906ab
TT		 42802019-06-25 Tom Tromey <tom@tromey.com>
4281
4282 * tui/tui-data.h (struct tui_win_info): Make constructor
4283 protected. Make destructor virtual. Add initializers.
4284 (tui_source_window, tui_data_window, tui_cmd_window): New
4285 classes.
4286 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
4287 constructor. Add "type" parameter.
4288 (tui_source_window, tui_data_window, tui_cmd_window): New
4289 constructors.
4290 (tui_alloc_win_info): Instantiate the appropriate subclass.
4291
e7e11af4
TT		 42922019-06-25 Tom Tromey <tom@tromey.com>
4293
4294 * tui/tui-win.c (tui_resize_all): Use delete.
4295 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4296 destructor.
4297 (tui_free_window): Don't declare.
4298 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4299 Update.
4300
6792b55e
TT		 43012019-06-25 Tom Tromey <tom@tromey.com>
4302
4303 * tui/tui-data.h (struct tui_win_info): Add constructor.
4304 * tui/tui-data.c (tui_alloc_win_info): Use new.
4305 (tui_free_window): Use delete.
4306
f95675e1
TT		 43072019-06-22 Tom Tromey <tom@tromey.com>
4308
4309 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4310 declare.
4311 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4312
5bff081c
TT		 43132019-06-22 Tom Tromey <tom@tromey.com>
4314
4315 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4316 declare.
4317 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4318
47e3f474
TV		 43192019-06-22 Tom de Vries <tdevries@suse.de>
4320
4321 * dwarf2read.c (create_addrmap_from_aranges)
4322 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4323 instead of '%zu'.
4324
fd5866f6
SM		 43252019-06-21 Simon Marchi <simon.marchi@efficios.com>
4326
4327 * dwarf2read.h (dwarf2_section_info_def): Remove.
4328 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4329 * dwarf2read.c (struct dwo_sections) <types>: Change type to
4330 std::vector<dwarf2_section_info>.
4331 (struct dwo_file) <~dwo_file>: Remove.
4332 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4333 types field.
4334 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4335 (dwarf2_read_debug_names): Likewise.
4336 (create_debug_types_hash_table): Change parameter type to
4337 array_view, adjust code accordingly.
4338 (dwarf2_locate_dwo_sections): Adjust to std::vector.
4339 (partial_die_info::fixup): Likewise.
4340 (determine_prefix): Likewise.
4341 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4342
fb1eb2f9
SM		 43432019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4344
4345 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4346 gdb_bfd_ref_ptr.
4347 <~dwo_file>: Remove call to gdb_bfd_unref.
4348 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4349 gdb_bfd_ref_ptr::get.
4350
51ac9db5
SM		 43512019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4352
4353 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4354 type to htab_up.
4355 * dwarf2read.c (struct dwo_file): Initialize fields.
4356 <~dwo_file>: New.
4357 (free_dwo_file): Remove, move content to ~dwo_file.
4358 (struct dwo_file_deleter): Remove.
4359 (dwo_file_up>: Remove custom deleter.
4360 (free_dwo_files): Remove.
4361 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4362 dwo_files.
4363 (process_skeletonless_type_units): Call unique_ptr::get.
4364 (allocate_dwo_file_hash_table): Add deleter to created hash
4365 table. Change return type to htab_up.
4366 (lookup_dwo_file_slot): Don't memset dwo_file, call
4367 unique_ptr::get.
4368 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4369 (create_dwo_unit_in_dwp_v2): Likewise.
4370 (open_and_init_dwo_file): Likewise.
4371 (free_dwo_file_from_slot): Remove.
4372
dc4ccb6f
SM		 43732019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4374
4375 * dwarf2read.h (struct dwarf2_section_info) <readin,
4376 is_virtual>: Change type to bool.
4377 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4378 true instead of 1.
4379
e6a1c5cb
TT		 43802019-06-19 Tom Tromey <tom@tromey.com>
4381
4382 * tui/tui-data.h (tui_init_content_element): Don't declare.
4383
6f6ffbeb
TT		 43842019-06-19 Tom Tromey <tom@tromey.com>
4385
4386 * tui/tui-data.h (tui_init_win_info): Don't declare.
4387
f23f598e
TV		 43882019-06-19 Tom de Vries <tdevries@suse.de>
4389
4390 * dwarf2read.h (abstract_to_concrete): Change type to
4391 std::unordered_map<sect_offset, std::vector<sect_offset>,
4392 gdb::hash_enum<sect_offset>>.
4393
680e1bee
TT		 43942019-06-19 Tom Tromey <tromey@adacore.com>
4395
4396 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4397 EVAL_AVOID_SIDE_EFFECTS specially.
4398
dcf37923
TT		 43992019-06-19 Tom Tromey <tromey@adacore.com>
4400
4401 * source-cache.c (highlighter): New global.
4402 (source_cache::get_source_lines): Create a highlighter on demand.
4403
494986d5
AB		 44042019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
4405
4406 * defs.h (deprecated_interactive_hook): Delete declaration.
4407 * interps.c (clear_interpreter_hooks): Remove use of
4408 deprecated_interactive_hook.
4409 * top.c (deprecated_interactive_hook): Delete definition.
4410 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4411
3360b6e7
TV		 44122019-06-18 Tom de Vries <tdevries@suse.de>
4413
4414 PR gdb/24515
4415 * dwarf2read.h (abstract_to_concrete): Change type from
4416 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4417 std::unordered_map<sect_offset, std::vector<sect_offset>>.
4418 * dwarf2read.c (read_variable): Update.
4419 (dwarf2_fetch_die_loc_sect_off): Update.
4420
310b3441
TV		 44212019-06-17 Tom de Vries <tdevries@suse.de>
4422
4423 PR gdb/24617
4424 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4425 accessing parent[parent_len - 1].
4426
ba9777be
PP		 44272019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
4428
4429 PR gdb/24364
4430 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4431 call dtrace_process_dof with NULL dof.
4432
2b9f6e89
TV		 44332019-06-16 Tom de Vries <tdevries@suse.de>
4434
4435 PR gdb/24445
4436 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4437
431b3ead
TT		 44382019-06-16 Tom Tromey <tom@tromey.com>
4439
4440 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4441 (make_all_visible): Use address of member.
4442
d04b44a1
TT		 44432019-06-16 Tom Tromey <tom@tromey.com>
4444
4445 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4446 (tui_free_window, free_content, free_content_elements): Remove
4447 unnecessary cast.
4448 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4449 cast.
4450 * tui/tui-regs.c (tui_show_register_group)
4451 (tui_display_registers_from, tui_display_reg_element_at_line):
4452 Remove unnecessary cast.
4453
bf5142e7
AB		 44542019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
4455
4456 * linux-nat.c (normal_mask): Delete.
4457 (_initialize_linux_nat): Don't initialise normal_mask.
4458
c4973306
SM		 44592019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
4460
4461 PR gdb/24445
4462 * dwarf-index-write.h (write_psymtabs_to_index): Add
4463 dwz_basename parameter.
4464 * dwarf-index-write.c (write_gdbindex): Move file writing to
4465 write_gdbindex_1. Change return type void.
4466 (assert_file_size): Move up, remove filename parameter.
4467 (write_gdbindex_1): New function.
4468 (write_debug_names): Change return type to void, call
4469 assert_file_size.
4470 (struct index_wip_file): New struct.
4471 (write_psymtabs_to_index): Add dwz_basename parameter. Move
4472 file logic to index_wip_file. Write index for dwz file if
4473 needed.
4474 (save_gdb_index_command): Pass basename of dwz file, if present.
4475 * dwarf-index-cache.c (index_cache::store): Obtain and pass
4476 build-id of dwz file, if present.
4477 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4478 (dwarf2_get_dwz_file): Likewise.
4479 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4480 (dwarf2_get_dwz_file): Likewise.
4481
395f9c91
TT		 44822019-06-16 Tom Tromey <tom@tromey.com>
4483
4484 * coffread.c (process_coff_symbol): Use xstrdup.
4485 * value.c (create_internalvar): Use xstrdup.
4486
cafb3438
TT		 44872019-06-16 Tom Tromey <tom@tromey.com>
4488
4489 * valops.c (value_cast, value_slice): Remove unnecessary cast.
4490 * breakpoint.c (stopin_command, stopat_command)
4491 (until_break_command, decode_location_default): Remove unnecessary
4492 cast.
4493 * utils.c (subset_compare): Remove unnecessary cast.
4494 * ada-lang.c (ada_update_initial_language): Remove unnecessary
4495 cast.
4496 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4497 cast.
4498 * infcmd.c (path_command): Remove unnecessary cast.
4499 * coffread.c (decode_type): Remove unnecessary cast.
4500 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4501 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4502 * tui/tui-stack.c (tui_show_locator_content)
4503 (tui_show_frame_info): Remove unnecessary cast.
4504 * tui/tui-win.c (tui_scroll_forward_command)
4505 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4506 (parse_scrolling_args): Remove unnecessary cast.
4507 * tui/tui-data.c (init_win_info, tui_del_window)
4508 (tui_free_window, tui_del_data_windows, tui_free_data_content)
4509 (free_content_elements): Remove unnecessary cast.
4510 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4511 unnecessary cast.
4512 * tui/tui-source.c (tui_set_source_content)
4513 (tui_vertical_source_scroll): Remove unnecessary cast.
4514 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4515 cast.
4516 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4517 * tui/tui-regs.c (tui_display_registers_from)
4518 (tui_display_register): Remove unnecessary cast.
4519 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4520 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4521 (make_visible): Remove unnecessary cast.
4522 * tui/tui-winsource.c (tui_erase_source_content)
4523 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4524 unnecessary cast.
4525 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4526 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4527 * stabsread.c (read_type, read_array_type, read_range_type):
4528 Remove unnecessary cast.
4529 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4530 (parse_symbol, parse_type, upgrade_type, parse_external)
4531 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4532 unnecessary cast.
4533 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4534
730ead81
TT		 45352019-06-16 Tom Tromey <tom@tromey.com>
4536
4537 * tui/tui-data.c (tui_alloc_generic_win_info)
4538 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4539 checks.
4540
584a927c
AB		 45412019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
4542 Andrew Burgess <andrew.burgess@embecosm.com>
4543
4544 * f-typeprint.c (f_print_type): Don't return early for not
4545 associated or not allocated types.
4546 (f_type_print_varspec_suffix): Add print_rank parameter and print
4547 ranks of array types in case they dangling.
4548 (f_type_print_base): Add print_rank parameter.
4549
30056ea0
AB		 45502019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4551
4552 * NEWS: Mention new MI commands.
4553 * break-catch-throw.c (enum exception_event_kind): Move to
4554 breakpoint.h.
4555 (print_mention_exception_catchpoint): Output text as a single
4556 message.
4557 (catch_exception_command_1): Rename to...
4558 (catch_exception_event): ...this, make non-static, update header
4559 command, and change some parameter types.
4560 (catch_catch_command): Update for changes to
4561 catch_exception_command_1.
4562 (catch_throw_command): Likewise.
4563 (catch_rethrow_command): Likewise.
4564 * breakpoint.c (enum exception_event_kind): Delete.
4565 * breakpoint.h (enum exception_event_kind): Moved here from
4566 break-catch-throw.c.
4567 (catch_exception_event): Declare.
4568 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4569 (mi_cmd_catch_throw): New function.
4570 (mi_cmd_catch_rethrow): New function.
4571 (mi_cmd_catch_catch): New function.
4572 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4573 'catch-catch' entries.
4574 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4575 (mi_cmd_catch_rethrow): Declare.
4576 (mi_cmd_catch_catch): Declare.
4577
ec8e2b6d
AB		 45782019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4579
4580 * annotate.c (annotate_source_line): Change return type to void,
4581 update implementation to match.
4582 * annotate.h (annotate_source_line): Change return type to void,
4583 update header comment.
4584 * stack.c (print_frame_info): Don't change what frame information
4585 is printed based on whether annotations are on or not.
4586
0d3abd8c
AB		 45872019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4588
4589 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4590 (annotate_source): Make static.
4591 (annotate_source_line): Moved from source.c and renamed from
4592 identify_source_line. Update the return type.
4593 * annotate.h (annotate_source): Delete declaration.
4594 (annotate_source_line): Declaration moved from source.h, and
4595 renamed from identify_source_line. Return type updated.
4596 * source.c (identify_source_line): Moved to annotate.c and renamed
4597 to annotate_source_line.
4598 (info_line_command): Remove check of annotation_level.
4599 * source.h (identify_source_line): Move declaration to annotate.h
4600 and rename to annotate_source_line.
4601 * stack.c: Add 'annotate.h' include.
4602 (print_frame_info): Remove check of annotation_level before
4603 calling annotate_source_line.
4604
00df30ae
AB		 46052019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4606
4607 * source-cache.c (source_cache::get_plain_source_lines): Use
4608 open_source_file_with_line_charpos instead of just
4609 open_source_file, remove call to find_source_lines.
4610 (source_cache::get_source_lines): Likewise.
4611 * source.c (find_source_lines): Make static.
4612 (get_filename_and_charpos): Renamed into...
4613 (open_source_file_with_line_charpos): ..this along with changes to
4614 return a scoped_fd, and some other minor clean ups.
4615 (identify_source_line): Use open_source_file_with_line_charpos.
4616 (search_command_helper): Use open_source_file_with_line_charpos
4617 instead of just open_source_file, remove call to
4618 find_source_lines.
4619 * source.h (open_source_file_with_line_charpos): Declare new
4620 function.
4621 (find_source_lines): Delete declaration.
4622
afda45a2
AB		 46232019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4624
4625 * source.c (get_filename_and_charpos): Remove fullname
4626 parameter.
4627 (identify_source_line): Update call to get_filename_and_charpos.
4628
0735b091
TT		 46292019-06-14 Tom Tromey <tromey@adacore.com>
4630
4631 PR gdb/24502:
4632 * ui-style.h (skip_ansi_escape): Update comment.
4633 * ui-file.h (class no_terminal_escape_file): New class.
4634 * ui-file.c (no_terminal_escape_file::write)
4635 (no_terminal_escape_file::puts): New methods.
4636 * cli/cli-logging.c (handle_redirections): Use
4637 no_terminal_escape_file.
4638
52ce35e2
TT		 46392019-06-14 Tom Tromey <tromey@adacore.com>
4640
4641 * NEWS: Move convenience variable news above Python news.
4642
73cc7272
TT		 46432019-06-14 Tom Tromey <tom@tromey.com>
4644
4645 * gnulib: Move directory to top-level.
4646 * configure.ac: Don't configure gnulib.
4647 * configure: Rebuild.
4648 * common/common-defs.h: Use new path to gnulib.
4649 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4650 (GNULIB_H): Remove.
4651 (INCGNU): Look in new gnulib location.
4652 (HFILES_NO_SRCDIR): Remove gnulib files.
4653 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4654 (generated_files): Remove GNULIB_H.
4655 ($(LIBGNU), all-lib): Remove targets.
4656 (distclean): Don't mention GNULIB_BUILDDIR.
4657 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4658
f5686554
TT		 46592019-06-14 Tom Tromey <tromey@adacore.com>
4660
4661 * symfile.c (add_symbol_file_command): Remove obsolete comment.
4662 Warn if symbol file does not provide any symbols.
4663
a0c1ffed
TT		 46642019-06-14 Tom Tromey <tromey@adacore.com>
4665
4666 * source.c (find_and_open_source): Respect basenames_may_differ.
4667
7c39e397
AB		 46682019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
4669
4670 * annotate.c (annotate_breakpoints_invalid): Make use of
4671 scoped_restore_terminal_state.
4672 (annotate_frames_invalid): Likewise.
4673
f411722c
TT		 46742019-06-14 Tom Tromey <tromey@adacore.com>
4675
4676 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4677 allow assignment to an internalvar.
4678
4268ec18
TT		 46792019-06-14 Tom Tromey <tromey@adacore.com>
4680
4681 * ada-lex.l: Allow "_" in attribute names.
4682
abdb711e
TT		 46832019-06-14 Tom Tromey <tromey@adacore.com>
4684
4685 PR gdb/24653:
4686 * regcache.c (registers_changed): Don't call alloca.
4687 * top.c (execute_command): Don't call alloca.
4688
4c048731
PA		 46892019-06-13 Pedro Alves <palves@redhat.com>
4690
4691 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4692 'expression'. When parsing an expression, error out if there's
4693 junk after "unlimited".
4694 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4695 (do_set_command): Adjust calls to is_unlimited_literal.
4696
66eb1ed3
PA		 46972019-06-13 Pedro Alves <palves@redhat.com>
4698
4699 * compile/compile.c (make_compile_options_def_group): Add braces
4700 around array_view initializer.
4701 * thread.c (make_thread_apply_all_options_def_group)
4702 (make_thread_apply_all_options_def_group): Likewise.
4703
3345721a
PA		 47042019-06-13 Pedro Alves <palves@redhat.com>
4705
4706 * NEWS (New commands): Mention "maint test-options
4707 require-delimiter", "maint test-options unknown-is-error", "maint
4708 test-options unknown-is-operand" and "maint show
4709 test-options-completion-result".
4710 (New command options, command completion): New section.
4711 (Completion improvements): New section.
4712 Mention that you can abbreviate "unlimited".
4713
6206060d
PA		 47142019-06-13 Pedro Alves <palves@redhat.com>
4715
4716 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4717 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4718 * unittests/cli-utils-selftests.c (test_parse_flags)
4719 (test_parse_flags_qcs): Delete.
4720 (test_cli_utils): Don't call deleted functions.
4721
6665660a
PA		 47222019-06-13 Pedro Alves <palves@redhat.com>
4723
4724 * thread.c: Include "cli/cli-option.h".
4725 (tp_array_compar_ascending): Global.
4726 (tp_array_compar): Delete function.
4727 (tp_array_compar_ascending, tp_array_compar_descending): New
4728 functions.
4729 (ascending_option_def, qcs_flag_option_def)
4730 (thr_qcs_flags_option_defs)
4731 (make_thread_apply_all_options_def_group)
4732 (make_thread_apply_options_def_group): New.
4733 (thread_apply_all_command): Use gdb::option::process_options.
4734 (thread_apply_command_completer)
4735 (thread_apply_all_command_completer): New.
4736 (thread_apply_command): Use gdb::option::process_options.
4737 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4738 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
4739 to generate help text of "thread apply". Adjust "taas"'s help.
4740 * tid-parse.c (tid_range_parser::in_thread_range): New method.
4741 * tid-parse.h (tid_range_parser::in_thread_range): New method.
4742
f7e13587
PA		 47432019-06-13 Pedro Alves <palves@redhat.com>
4744
4745 * thread.c (thread_apply_command): Check for invalid TID with
4746 isdigit instead of !isalpha.
4747
5d707134
PA		 47482019-06-13 Pedro Alves <palves@redhat.com>
4749
4750 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4751 (validate_flags_qcs): New.
4752 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4753 (validate_flags_qcs): Declare.
4754 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4755 (make_frame_apply_options_def_group): New.
4756 (frame_apply_command_count): Process options with
4757 gdb::option::process_options.
4758 (frame_apply_completer): New.
4759 (frame_apply_level_completer, frame_apply_all_completer)
4760 (frame_apply_completer): New.
4761 (_initialize_stack): Update help of "frame apply", "frame apply
4762 level", "frame apply all" and "faas" to mention supported options
4763 and install command completers.
4764 * stack.h (frame_apply_all_completer): Declare.
4765 * thread.c: Include "stack.h".
4766 (tfaas_command): Add "--".
4767 (_initialize_thread): Update help "tfaas" to mention supported
4768 options and install command completer.
4769
272d4594
PA		 47702019-06-13 Pedro Alves <palves@redhat.com>
4771
4772 * completer.c (complete_nested_command_line): New.
4773 (gdb_completion_word_break_characters_throw): Add assertion.
4774 * completer.h (complete_nested_command_line): Declare.
4775
90a1ef87
PA		 47762019-06-13 Pedro Alves <palves@redhat.com>
4777
4778 * stack.c (parse_backtrace_qualifiers): New.
4779 (backtrace_command): Use it.
4780 (backtrace_command_completer): Complete on qualifiers.
4781
d4c16835
PA		 47822019-06-13 Pedro Alves <palves@redhat.com>
4783
4784 * frame.c: Include "cli/cli-option.h.
4785 (user_set_backtrace_options): New.
4786 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4787 Delete.
4788 (get_prev_frame): Adjust.
4789 (boolean_option_def, uinteger_option_def)
4790 (set_backtrace_option_defs): New.
4791 (_initialize_frame): Adjust and use
4792 gdb::option::add_setshow_cmds_for_options to install "set
4793 backtrace past-main" and "set backtrace past-entry".
4794 * frame.h: Include "cli/cli-option.h".
4795 (struct frame_print_options): Forward declare.
4796 (print_frame_arguments_all, print_frame_arguments_scalars)
4797 (print_frame_arguments_none): Declare.
4798 (print_entry_values): Delete declaration.
4799 (struct frame_print_options, user_frame_print_options): New.
4800 (struct set_backtrace_options): New.
4801 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4802 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4803 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4804 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4805 (list_args_or_locals): Add frame_print_options parameter.
4806 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4807 * python/py-framefilter.c (enumerate_args): Pass down
4808 USER_FRAME_PRINT_OPTIONS.
4809 * stack.c: Include "cli/cli-option.h".
4810 (print_frame_arguments_all, print_frame_arguments_scalars)
4811 (print_frame_arguments_none): Declare.
4812 (print_raw_frame_arguments, print_entry_values): Delete.
4813 (user_frame_print_options): New.
4814 (boolean_option_def, enum_option_def, frame_print_option_defs):
4815 New.
4816 (struct backtrace_cmd_options): New.
4817 (bt_flag_option_def): New.
4818 (backtrace_command_option_defs): New.
4819 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4820 (print_frame_arg, read_frame_arg, print_frame_args)
4821 (print_frame_info, print_frame): Add frame_print_options parameter
4822 and use it.
4823 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4824 (backtrace_command_1): Add frame_print_options and
4825 backtrace_cmd_options parameters and use them.
4826 (make_backtrace_options_def_group): New.
4827 (backtrace_command): Process command options with
4828 gdb::option::process_options.
4829 (backtrace_command_completer): New.
4830 (_initialize_stack): Extend "backtrace"'s help to mention
4831 supported options. Install completer for "backtrace".
4832 Install some settings commands with add_setshow_cmds_for_options.
4833
2daf894e
PA		 48342019-06-13 Pedro Alves <palves@redhat.com>
4835
4836 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4837 and that "set/show print raw frame-arguments" are now deprecated.
4838
4839 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4840 command.
4841 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4842 * stack.c (_initialize_stack): Install "set/show print
4843 raw-frame-arguments", and deprecate "set/show print raw
4844 frame-arguments".
4845 * valprint.c (_initialize_valprint): Deprecate "set/show print
4846 raw".
4847
e6ed716c
PA		 48482019-06-13 Pedro Alves <palves@redhat.com>
4849
4850 * compile/compile.c (struct compile_options): New.
4851 (compile_flag_option_def, compile_command_option_defs)
4852 (make_compile_options_def_group): New.
4853 (compile_file_command): Handle options with
4854 gdb::option::process_options.
4855 (compile_file_command_completer): New function.
4856 (compile_code_command): Handle options with
4857 gdb::option::process_options.
4858 (compile_code_command_completer): New function.
4859 (_initialize_compiler): Install completers for "compile code" and
4860 "compile file". Mention available options in "compile code" and
4861 "compile code"'s help.
4862 * completer.c (advance_to_completion_word): New, factored out from
4863 ...
4864 (advance_to_expression_complete_word_point): ... this.
4865 (advance_to_filename_complete_word_point): New.
4866 * completer.h (advance_to_filename_complete_word_point): New
4867 declaration.
4868
7d8062de
PA		 48692019-06-13 Pedro Alves <palves@redhat.com>
4870
4871 * compile/compile.c: Include "cli/cli-option.h".
4872 (compile_print_value): Scope data pointer is now a
4873 value_print_options pointer; adjust.
4874 (compile_print_command): Process options. Scope data pointer is
4875 now a value_print_options pointer; adjust.
4876 (_initialize_compile): Update "compile print"'s help to include
4877 supported options. Install a completer for "compile print".
4878 * cp-valprint.c (show_vtblprint, show_objectprint)
4879 (show_static_field_print): Delete.
4880 (_initialize_cp_valprint): Don't install "set print
4881 static-members", "set print vtbl", "set print object" here.
4882 * printcmd.c: Include "cli/cli-option.h" and
4883 "common/gdb_optional.h".
4884 (print_command_parse_format): Rework to fill in a
4885 value_print_options instead of a format_data.
4886 (print_value): Change parameter type from format_data pointer to
4887 value_print_options reference. Adjust.
4888 (print_command_1): Process options. Adjust to pass down a
4889 value_print_options.
4890 (print_command_completer): New.
4891 (_initialize_printcmd): Install print_command_completer as
4892 handle_brkchars completer for the "print" command. Update
4893 "print"'s help to include supported options.
4894 * valprint.c: Include "cli/cli-option.h".
4895 (show_vtblprint, show_objectprint, show_static_field_print): Moved
4896 here from cp-valprint.c.
4897 (boolean_option_def, uinteger_option_def)
4898 (value_print_option_defs, make_value_print_options_def_group):
4899 New. Use gdb::option::add_setshow_cmds_for_options to install
4900 "set print elements", "set print null-stop", "set print repeats",
4901 "set print pretty", "set print union", "set print array", "set
4902 print address", "set print symbol", "set print array-indexes".
4903 * valprint.h: Include <string> and "cli/cli-option.h".
4904 (make_value_print_options_def_group): Declare.
4905 (print_value): Change parameter type from format_data pointer to
4906 value_print_options reference.
4907 (print_command_completer): Declare.
4908
9d0faba9
PA		 49092019-06-13 Pedro Alves <palves@redhat.com>
4910
4911 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4912 (COMMON_SFILES): Add maint-test-settings.c.
4913 * cli/cli-decode.c (boolean_enums): New global, factored out from
4914 ...
4915 (add_setshow_boolean_cmd): ... here.
4916 * cli/cli-decode.h (boolean_enums): Declare.
4917 * cli/cli-option.c: New file.
4918 * cli/cli-option.h: New file.
4919 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4920 factored out from ...
4921 (parse_cli_boolean_value(const char *)): ... this.
4922 (is_unlimited_literal): Change parameter type to pointer to
4923 pointer. Adjust and advance ARG pointer.
4924 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4925 (parse_cli_var_enum): New, factored out from ...
4926 (do_set_command): ... this. Adjust.
4927 * cli/cli-setshow.h (parse_cli_boolean_value)
4928 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4929 (parse_cli_var_enum): Declare.
4930 * cli/cli-utils.c: Include "cli/cli-option.h".
4931 (get_ulongest): New.
4932 * cli/cli-utils.h (get_ulongest): Declare.
4933 (check_for_argument): New overloads.
4934 * maint-test-options.c: New file.
4935
2c722807
PA		 49362019-06-13 Pedro Alves <palves@redhat.com>
4937
4938 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4939 parse a range if "-" is at the end of the string.
4940
dee7b4c8
PA		 49412019-06-13 Pedro Alves <palves@redhat.com>
4942
4943 * cli/cli-setshow.c (parse_auto_binary_operation)
4944 (parse_cli_boolean_value): Don't allow "o".
4945
dca0f6c0
PA		 49462019-06-13 Pedro Alves <palves@redhat.com>
4947
4948 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4949 * NEWS: Mention maint test-settings KIND.
4950 * maint-test-settings.c: New file.
4951
597bf39d
PA		 49522019-06-13 Pedro Alves <palves@redhat.com>
4953
4954 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4955 completer.
4956 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4957 "set" completers.
4958
48c410fb
PA		 49592019-06-13 Pedro Alves <palves@redhat.com>
4960
4961 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4962 after item.
4963
93bcb043
PA		 49642019-06-13 Pedro Alves <palves@redhat.com>
4965
4966 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4967
cbba3ecd
PA		 49682019-06-13 Pedro Alves <palves@redhat.com>
4969
4970 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4971 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4972 call.
4973 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4974 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4975 calls.
4976 (check_for_argument): Skip spaces after argument.
4977
b9a3f842
PA		 49782019-06-13 Pedro Alves <palves@redhat.com>
4979
4980 * thread.c (thread_apply_command): Adjust TID parsing.
4981 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4982 detected before end of string.
4983 (tid_is_in_list): Error out if LIST is invalid.
4984
3844e605
PA		 49852019-06-13 Pedro Alves <palves@redhat.com>
4986
4987 * completer.c (complete_line_internal_1): Rewind completion word
4988 point.
4989 (completion_tracker::advance_custom_word_point_by): Change
4990 parameter type to int.
4991 * completer.h (completion_tracker::advance_custom_word_point_by):
4992 Likewise.
4993
00b56dbe
PA		 49942019-06-13 Pedro Alves <palves@redhat.com>
4995
4996 * completer.c (advance_to_completion_word): Handle delimiters.
4997
d106773e
PA		 49982019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
4999
5000 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5001
08f10e02
TT		 50022019-06-11 Tom Tromey <tom@tromey.com>
5003
5004 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5005 (xmalloc_failed): Move to alloc.c.
5006 * alloc.c: New file.
5007 * Makefile.in (COMMON_SFILES): Add alloc.c.
5008
1c7fe951
TT		 50092019-06-11 Tom Tromey <tom@tromey.com>
5010
5011 * nat/linux-waitpid.c: Don't include server.h.
5012 (linux_debug): Remove.
5013 (my_waitpid): Update.
5014
89549d7f
TT		 50152019-06-11 Tom Tromey <tromey@adacore.com>
5016
5017 * infcall.c (_initialize_infcall): Remove trailing newline from
5018 help.
5019 * user-regs.c (_initialize_user_regs): Remove trailing newline
5020 from help.
5021 * typeprint.c (_initialize_typeprint): Remove trailing newline
5022 from help.
5023 * reverse.c (_initialize_reverse): Remove trailing newlines from
5024 help.
5025 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5026 from help.
5027 * language.c (add_set_language_command): Remove trailing newline
5028 from help.
5029 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5030 help.
5031 * disasm.c (_initialize_disasm): Remove trailing newline from
5032 help.
5033 * top.c (init_main): Remove trailing newline from help.
5034 * interps.c (_initialize_interpreter): Remove trailing newline
5035 from help.
5036 * btrace.c (_initialize_btrace): Remove trailing newlines from
5037 help.
5038 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5039 from help.
5040 * python/python.c (_initialize_python): Remove trailing newline
5041 from help.
5042 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5043 help.
5044 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5045 from help. Reformat some text.
5046 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5047 from help.
5048 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5049 newline from help.
5050
86108c13
TT		 50512019-06-11 Tom Tromey <tromey@adacore.com>
5052
5053 * darwin-nat.c (darwin_decode_exception_message)
5054 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5055
a7067863
AB		 50562019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
5057
5058 * valops.c (value_slice): Check for not allocated or not
5059 associated values.
5060
9ab08412
TV		 50612019-06-10 Tom de Vries <tdevries@suse.de>
5062
5063 PR gdb/24618
5064 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5065 sure an empty slot (defined by a 32-bit zero pair) is recognized as
5066 invalid.
5067
f19e22e9
TV		 50682019-06-10 Tom de Vries <tdevries@suse.de>
5069
5070 PR gdb/24611
5071 * linespec.c (linespec_lexer_lex_string): Remove incorrect
5072 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
5073
e99f9db0
TV		 50742019-06-10 Tom de Vries <tdevries@suse.de>
5075
5076 PR symtab/24545
5077 * symtab.c (struct demangled_name_entry): Add language field.
5078 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
5079 static minimal symbol". Set and use language field.
5080
9bf7038b
TT		 50812019-06-10 Tom Tromey <tromey@adacore.com>
5082
5083 * ada-lang.c (_initialize_ada_language): Update help text.
5084
422186a9
TT		 50852019-06-10 Tom Tromey <tromey@adacore.com>
5086
5087 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5088 with a newline.
5089 * guile/guile.c (handle_boot_error): Don't end warning with a
5090 newline.
5091 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5092 warning with a newline.
5093 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5094 newline.
5095 (s12z_frame_cache): Likewise.
5096 * dwarf-index-cache.c (index_cache::store): Don't end warning with
5097 a newline.
5098 * solib-svr4.c (disable_probes_interface): Don't end warning with
5099 a newline.
5100 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5101 newline.
5102 * python/python.c (do_finish_initialization): Don't end warning
5103 with a newline.
5104
25ce02ee
TT		 51052019-06-10 Tom Tromey <tom@tromey.com>
5106
5107 * python/py-breakpoint.c (gdbpy_breakpoint_created)
5108 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5109 gdbpy_enter.
5110
caa429d8
TT		 51112019-06-10 Tom Tromey <tromey@adacore.com>
5112
5113 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5114 data.
5115 (elf_new_init): Don't call stabsread_new_init.
5116 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5117 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
5118 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5119
81873cc8
TV		 51202019-06-10 Tom de Vries <tdevries@suse.de>
5121
5122 PR symtab/16264
5123 PR symtab/24517
5124 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5125
4fa0265e
РИ		 51262019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
5127
5128 * source.c (find_and_open_source): Also rewrite relative file
5129 names.
5130
1a3da2cd
AB		 51312019-04-26 Amos Bird <amosbird@gmail.com>
5132
5133 * annotate.c (annotate_thread_exited): Add "thread-exited"
5134 annotation.
5135
3847a7bf
TT		 51362019-06-06 Tom Tromey <tromey@adacore.com>
5137
5138 * maint.h (class scoped_command_stats): Use
5139 DISABLE_COPY_AND_ASSIGN.
5140 <print_time>: New method.
5141 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5142 print_time.
5143 (scoped_command_stats::print_time): New method.
5144
312617a3
AB		 51452019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
5146
5147 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5148 instructions of lengths 6 or 8 bytes.
5149
b02f78f9
PA		 51502019-06-04 Pedro Alves <palves@redhat.com>
5151
5152 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5153
5154 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5155 * breakpoint.c (condition_completer): Likewise.
5156 * cli/cli-dump.c (scan_expression): Likewise.
5157 * common/filestuff.c (mkdir_recursive): Likewise.
5158 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5159 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5160 (gdb_abspath): Likewise.
5161 * compile/compile-cplus-types.c
5162 (compile_cplus_instance::decl_name): Likewise.
5163 * completer.c (complete_explicit_location):
5164 (signal_completer, reg_or_group_completer_1): Likewise.
5165 * cp-support.c (cp_remove_params_if_any): Likewise.
5166 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5167 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5168 * infcmd.c (strip_bg_char): Likewise.
5169 * linespec.c (copy_token_string): Likewise.
5170 * mi/mi-main.c (output_cores): Likewise.
5171 * psymtab.c (psymtab_search_name):
5172 * symfile.c (test_set_ext_lang_command): Likewise.
5173 * target.c (target_fileio_read_stralloc): Likewise.
5174 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5175 * value.c (complete_internalvar): Likewise.
5176
e1f2e1a2
CB		 51772019-06-04 Christian Biesinger <cbiesinger@google.com>
5178
5179 Add objfile property to gdb.Type.
d3238f7d
PA		 5180 * NEWS: Mention Python API addition.
5181 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 5182
e664d728
PW		 51832019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5184
5185 * NEWS: Mention the new set|show style [title|highlight].
5186 Mention changes to "show style", "help" and "apropos".
5187
66d8c862
PW		 51882019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5189
5190 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5191 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
5192 instead of print_help_for_command.
5193 (print_doc_of_command): New function.
5194 (help_list): Add 'apropos -v word' suggestion.
5195 (print_help_for_command): Style the command name using title style.
5196 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5197 (_initialize_cli_cmds): Describe -v in apropos_command help.
5198
9303eb2f
PW		 51992019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5200
5201 * cli/cli-style.h (cli_style_option): Add name in constructor,
5202 add m_name class member, add constructor with intensity,
5203 add name class function.
5204 (cli_style_option::add_setshow_commands): Remove name argument.
5205 (highlight_style, title_style): New styles.
5206 * cli/cli-style.c (do_show): New function that shows a style
5207 characteristic styling the style name with itself.
5208 (set_style_name): New function.
5209 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5210 Update all callers according to the changes in cli/cli-style.h.
5211 * utils.h (fputs_highlighted): New function.
5212 * utils.c (fputs_highlighted): Likewise.
5213
e2c52041
PW		 52142019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5215
5216 * NEWS: Mention new pipe command and new convenience variables.
5217
947d3946
PW		 52182019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5219
5220 * cli/cli-cmds.c (pipe_command): New function.
5221 (_initialize_cli_cmds): Call add_com for pipe_command.
5222 Define | as an alias for pipe.
5223 (exit_status_set_internal_vars): New function.
5224 (shell_escape): Call exit_status_set_internal_vars.
5225 cli/cli-decode.c (find_command_name_length): Recognize | as
5226 a single character command.
5227
b8fd0918
PW		 52282019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5229
5230 * gdbcmd.h (execute_command_to_ui_file): New declaration.
5231 top.c (execute_command_to_ui_file): New function, mostly a copy
5232 of execute_command_to_string.
5233 (execute_command_to_string): Implement by calling
5234 execute_command_to_ui_file.
5235
68bb5386
PW		 52362019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5237
5238 * top.h (saved_command_line): Remove declaration.
5239 * top.c (previous_saved_command_line, previous_repeat_arguments):
5240 New variables.
5241 (saved_command_line): Make static, define together with other
5242 'repeat variables'.
5243 (dont_repeat): Clear repeat_arguments.
5244 (repeat_previous, get_saved_command_line, save_command_line):
5245 New functions.
5246 (gdb_init): Initialize saved_command_line
5247 and previous_saved_command_line.
5248 * main.c (captured_main_1): Remove saved_command_line initialization.
5249 * event-top.c (handle_line_of_input): Update to use
5250 the new 'repeat' related functions instead of direct access to
5251 saved_command_line.
5252 * command.h (repeat_previous, get_saved_command_line,
5253 save_command_line): New declarations.
5254 (dont_repeat): Add comment.
5255
bfcdb852
TT		 52562019-05-30 Tom Tromey <tromey@adacore.com>
5257
5258 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5259 Fix comment.
5260 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5261
0ef209f2
JV		 52622019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
5263
5264 PR cli/24587
5265 * completer.c (complete): Initialize variable word.
5266
955b06fa
SDJ		 52672019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
5268
5269 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5270 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5271 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5272 'body' is NULL to the outter 'if', protecting the '!is_define'
5273 situation as well.
5274
fa9c3fa0
TT		 52752019-05-29 Tom Tromey <tromey@adacore.com>
5276
5277 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5278 (dwarf_unknown): New function.
5279 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5280 (dwarf_type_encoding_name): Use dwarf_unknown.
5281
4330d61d
TT		 52822019-05-29 Tom Tromey <tromey@adacore.com>
5283
5284 PR c++/20020:
5285 * cp-valprint.c (cp_print_value_fields): Call
5286 cp_print_static_field inside "try".
5287
33a6bc35
TT		 52882019-05-29 Tom Tromey <tromey@adacore.com>
5289
5290 * inflow.c (struct terminal_info): Add default operator=.
5291 * configure: Rebuild.
5292 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5293 -Wdeprecated-copy-dtor, -Wredundant-move.
5294
000439d5
TT		 52952019-05-29 Tom Tromey <tromey@adacore.com>
5296
5297 * NEWS: Add entry.
5298 * infcmd.c (print_return_value_1): Handle finish_print
5299 option.
5300 (show_print_finish): New function.
5301 (_initialize_infcmd): Add "set/show print finish" commands.
5302 * valprint.c (user_print_options): Initialize new member.
5303 * valprint.h (struct value_print_options) <finish_print>: New
5304 member.
5305
c0e70c62
TT		 53062019-05-28 Tom Tromey <tromey@adacore.com>
5307
5308 * ada-lang.c (ada_remove_Xbn_suffix)
5309 (find_old_style_renaming_symbol)
5310 (parse_old_style_renaming): Remove.
5311 (ada_find_renaming_symbol): Don't call
5312 find_old_style_renaming_symbol.
5313 (ada_is_renaming_symbol): Rename from
5314 ada_find_renaming_symbol. Remove "block" parameter. Return
5315 bool. Now static.
5316 (ada_read_var_value): Update and simplify.
5317 * ada-exp.y (write_var_or_type): Remove old code.
5318
766f8836
AH		 53192019-05-28 Alan Hayward <alan.hayward@arm.com>
5320
5321 * event-top.c: Remove include comment.
5322 * inflow.c (class scoped_ignore_sigttou): Move from here...
5323 * inflow.h (class scoped_ignore_sigttou): ...to here.
5324 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5325 * top.c: Remove include comment.
5326
eb41253a
TT		 53272019-05-27 Tom Tromey <tom@tromey.com>
5328
5329 * NEWS: Fix typo.
5330
4ca51187
TT		 53312019-05-22 Tom Tromey <tromey@adacore.com>
5332
5333 * target.c (target_follow_exec): Constify parameter.
5334 * target-delegates.c: Rebuild.
5335 * remote.c (remote_target::follow_exec): Constify parameter.
5336 * infrun.c (follow_exec): Constify parameter.
5337 * target.h (struct target_ops) <follow_exec>: Constify parameter.
5338 (target_follow_exec): Likewise.
5339
8fca4da0
AH		 53402019-05-22 Alan Hayward <alan.hayward@arm.com>
5341
5342 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5343 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5344
b7060614
AH		 53452019-05-22 Alan Hayward <alan.hayward@arm.com>
5346
5347 * NEWS: Add debugredirect and testsuite sections.
5348
0a5954bd
SC		 53492019-05-22 Simon Cook <simon.cook@embecosm.com>
5350
5351 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5352 target descriptions using exclusively floating point register name
5353 aliases.
5354
dc42e902
AB		 53552019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
5356
5357 PR gdb/18644:
5358 * f-lang.c (build_fortran_types): Handle the case where
5359 gdbarch_floatformat_for_type returns a nullptr.
5360
fb7806c7
TV		 53612019-05-21 Tom de Vries <tdevries@suse.de>
5362
5363 PR cli/24587
5364 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5365
34d11c68
AB		 53662019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5367
5368 PR gdb/18644:
5369 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5370 16-byte floats.
5371 * i386-tdep.c (i386_floatformat_for_type): Use
5372 floatformats_ia64_quad for the 16-byte floating point component
5373 within a fortran 32-byte complex number.
5374
122cf0f2
AB		 53752019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5376
5377 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5378 delete default constructor.
5379 (find_partial_die): Update to return const struct.
5380 (partial_die_parent_scope): Move variable declaration into scope
5381 of its use and change its type to auto.
5382 (guess_partial_die_structure_name): Likewise.
5383 (partial_die_info::fixup): Likewise.
5384
33d0e35a
TT		 53852019-05-17 Tom Tromey <tromey@adacore.com>
5386
5387 * source.c (find_and_open_source): Remove cast.
5388
a45575b0
TT		 53892019-05-17 Tom Tromey <tromey@adacore.com>
5390
5391 * annotate.c (annotate_source): Make "filename" const.
5392 * annotate.h (annotate_source): Use const.
5393
81f47ac2
AH		 53942019-05-17 Alan Hayward <alan.hayward@arm.com>
5395
5396 * disasm.c (set_disassembler_options): Send errors to stderr.
5397
ca1285d1
AH		 53982019-05-17 Alan Hayward <alan.hayward@arm.com>
5399
5400 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5401 (cli_interp_base::set_logging): Check debug_redirect.
5402 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5403 * cli/cli-logging.c (debug_redirect): Add static variable.
5404 (pop_output_files): Add default param.
5405 (handle_redirections): Print debug setting.
5406 (show_logging_command): Likewise.
5407 (_initialize_cli_logging): Add debugredirect command.
5408 * interps.c (current_interp_set_logging): Add debug_redirect
5409 parameter.
5410 * interps.h (set_logging): Add debug_redirect parameter.
5411 (current_interp_set_logging): Likewise.
5412 * mi/mi-common.h: Likewise.
5413 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5414
54152019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH		 5416 Tom Tromey <tromey@adacore.com>
5417
5418 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5419 directly.
5420 * cli/cli-interp.h (make_logging_output): Remove declaration.
5421 * cli/cli-logging.c (make_logging_output): Remove function.
5422 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5423 directly.
5424 * ui-file.c (tee_file::tee_file): Remove bools.
5425 (tee_file::~tee_file): Remove deletes.
5426 * ui-file.h (tee_file): Remove bools.
5427
26648588
JV		 54282019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
5429
5430 * mi/mi-cmds.h (mi_cmd_complete): New function.
5431 * mi/mi-main.c (mi_cmd_complete): Likewise.
5432 * mi/mi-cmds.c: Define new MI command -complete.
5433 * NEWS: Mention new -complete command.
5434
6e035501
JV		 54352019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
5436
5437 * completer.h (complete): New function.
5438 * completer.c (complete): Likewise.
5439 * cli/cli-cmds.c: (complete_command): Update to use new complete()
5440 function defined in completer.h.
5441
7d0e2ece
JV		 54422019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
5443
e79be6e5 5444 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 5445
fb816e8b
TV		 54462019-05-17 Tom de Vries <tdevries@suse.de>
5447
5448 PR gdb/24094
5449 * dwarf2read.c (struct cu_partial_die_info): New struct.
5450 (find_partial_die): Return cu_partial_die_info.
5451 (partial_die_parent_scope, guess_partial_die_structure_name)
5452 (partial_die_info::fixup): Handle new return type of find_partial_die.
5453
677052f2
SDJ		 54542019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5455
5456 * stap-probe.c (stap_parse_register_operand): Make "regname" an
5457 "std::string", simplifying the algorithm.
5458
f3da9116
SDJ		 54592019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5460
5461 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5462 (stap_static_probe_ops::get_probes): Likewise.
5463
f1bb75ab
SDJ		 54642019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5465
5466 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5467 '-')" and "else if".
5468 (stap_parse_single_operand): Join checks for
5469 "gdbarch_stap_parse_special_token_p" and
5470 "gdbarch_stap_parse_special_token" in the same "if" statement.
5471 Invert check when verifying for operation on register
5472 displacement.
5473
3ca58cde
SDJ		 54742019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5475
5476 * stap-probe.c (stap_get_opcode): Update comment.
5477 (stap_get_expected_argument_type): Likewise.
5478 (handle_stap_probe): Likewise.
5479
af2d9bee
SDJ		 54802019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5481
5482 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5483 return type to 'bool'. Adjust comment. Use 'bool' when
5484 appropriate.
5485 (i386_stap_parse_special_token_three_arg_disp): Likewise.
5486 * stap-probe.c (stap_parse_argument_1): Likewise.
5487 (stap_is_operator): Likewise.
5488 (stap_is_generic_prefix): Likewise.
5489 (stap_is_register_prefix): Likewise.
5490 (stap_is_register_indirection_prefix): Likewise.
5491 (stap_is_integer_prefix): Likewise.
5492 (stap_generic_check_suffix): Likewise.
5493 (stap_check_integer_suffix): Likewise.
5494 (stap_check_register_suffix): Likewise.
5495 (stap_check_register_indirection_suffix): Likewise.
5496 (stap_parse_register_operand): Likewise.
5497 (stap_parse_single_operand): Likewise.
5498 (stap_parse_argument_1): Likewise.
5499 (stap_probe::get_argument_count): Likewise.
5500 (stap_is_operator): Likewise.
5501
61c9c421
TT		 55022019-05-16 Tom Tromey <tromey@adacore.com>
5503
5504 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5505 keyword to foreach.
5506
9ddc1af1
SM		 55072019-05-15 Simon Marchi <simon.marchi@efficios.com>
5508
5509 * linux-thread-db.c (try_thread_db_load_1): Change return type
5510 to bool.
5511 (try_thread_db_load): Likewise.
5512 (try_thread_db_load_from_pdir_1): Likewise.
5513 (try_thread_db_load_from_pdir): Likewise.
5514 (try_thread_db_load_from_sdir): Likewise.
5515 (try_thread_db_load_from_dir): Likewise.
5516 (thread_db_load_search): Likewise.
5517 (has_libpthread): Likewise.
5518 (thread_db_load): Likewise.
5519
7bede828
SDJ		 55202019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
5521
5522 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5523 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5524 NULL, and complain/return if that's the case.
5525
c5358db4
JD		 55262019-05-15 John Darrington <john@darrington.wattle.id.au>
5527
5528 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5529 (advance, posn, abstract_read_memory): New functions.
5530 [struct mem_read_abstraction]: New struct.
5531 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5532
c408a94f
TT		 55332019-05-14 Tom Tromey <tromey@adacore.com>
5534
5535 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5536 value is not lval_memory.
5537
e7bd7fba
TT		 55382019-05-14 Tom Tromey <tromey@adacore.com>
5539
5540 * solib.c (info_sharedlibrary_command): Style the file name.
5541
a6d0f249
AH		 55422019-05-14 Alan Hayward <alan.hayward@arm.com>
5543
5544 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5545 (aarch64_vnv_type): Likewise.
5546 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5547 * common/tdesc.c: Likewise.
5548 * common/tdesc.h (enum tdesc_type_kind): Likewise.
5549 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5550 * features/aarch64-fpu.xml: Add ieee half view.
5551 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5552 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5553 * gdbtypes.h (struct builtin_type): Likewise.
5554 (struct objfile_type): Likewise.
5555
66b8bb74
SM		 55562019-05-12 Paul Naert <paul.naert@polymtl.ca>
5557
5558 * language.c (language_sniff_from_mangled_name): Fix "langauge"
5559 typo.
5560 * location.h (string_to_event_location): Likewise.
5561
21c219fd
JB		 55622019-05-11 Joel Brobecker <brobecker@adacore.com>
5563
5564 GDB 8.3 released.
5565
13674803
SM		 55662019-05-10 Simon Marchi <simon.marchi@efficios.com>
5567
5568 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5569 New variable declaration.
5570 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5571 New variable.
5572 (print_one_breakpoint): Use ui_out::test_flags and new global
5573 variable to compute use_fixed_output.
5574 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5575 Remove.
5576 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5577 (mi_multi_location_breakpoint_output_fixed): Remove.
5578 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5579 new variable.
5580 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5581 fix_multi_location_breakpoint_output flag if version >= 3.
5582 * ui-out.h (enum ui_out_flag)
5583 <fix_multi_location_breakpoint_output>: New enumerator.
5584
a9eac7f9
SM		 55852019-05-10 Simon Marchi <simon.marchi@efficios.com>
5586
5587 * contrib/cc-with-tweaks.sh: Validate dwz's work.
5588
71bed2db
TT		 55892019-05-10 Tom Tromey <tromey@adacore.com>
5590
5591 * ada-lang.c (catch_ada_completer): New function.
5592 (_initialize_ada_language): Use it.
5593
24c54127
TT		 55942019-05-10 Tom Tromey <tromey@adacore.com>
5595
5596 * thread.c (print_thread_info): Make "requested_threads" const.
5597 * gdbthread.h (print_thread_info): Make "requested_threads"
5598 const.
5599 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5600 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5601
7a102139
TT		 56022019-05-08 Tom Tromey <tom@tromey.com>
5603
5604 * gdbtypes.c (objfile_type_data): Change type.
5605 (objfile_type, _initialize_gdbtypes): Update.
5606
924d79e2
TT		 56072019-05-08 Tom Tromey <tom@tromey.com>
5608
5609 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5610 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5611 (_initialize_dwarf2_frame): Update.
5612
4c58e337
TT		 56132019-05-08 Tom Tromey <tom@tromey.com>
5614
5615 * objc-lang.c (objc_objfile_data): Change type.
5616 (find_methods): Update.
5617 (_initialize_objc_lang): Remove.
5618
d772d2ab
TT		 56192019-05-08 Tom Tromey <tom@tromey.com>
5620
5621 * stabsread.c (rs6000_builtin_type_data): Change type.
5622 (rs6000_builtin_type, _initialize_stabsread): Update.
5623
d11d83f4
TT		 56242019-05-08 Tom Tromey <tom@tromey.com>
5625
5626 * mips-tdep.c (mips_pdr_data): Remove.
5627 (_initialize_mips_tdep): Update.
5628
9a73f0ad
TT		 56292019-05-08 Tom Tromey <tom@tromey.com>
5630
5631 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5632 (hppa_init_objfile_priv_data, read_unwind_info)
5633 (find_unwind_entry, _initialize_hppa_tdep): Update.
5634
8127a2fa
TT		 56352019-05-08 Tom Tromey <tom@tromey.com>
5636
5637 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5638 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
5639 on obstack.
5640 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5641
91d3055d
TT		 56422019-05-08 Tom Tromey <tom@tromey.com>
5643
5644 * mdebugread.c (basic_type_data): Change type.
5645 (basic_type, _initialize_mdebugread): Update.
5646
31930bd3
TT		 56472019-05-08 Tom Tromey <tom@tromey.com>
5648
5649 * common/gdb_unique_ptr.h (struct noop_deleter): New.
5650
bdb3ed9e
TT		 56512019-05-08 Tom Tromey <tom@tromey.com>
5652
5653 * nto-tdep.c (nto_inferior_data_reg): Change type.
5654 (nto_inferior_data): Update.
5655 (nto_inferior_data_cleanup, nto_new_inferior_data)
5656 (_initialize_nto_tdep): Remove.
5657 * nto-tdep.h (struct nto_inferior_data): Add initializers.
5658
f37b313d
TT		 56592019-05-08 Tom Tromey <tom@tromey.com>
5660
5661 * ada-lang.c (struct ada_inferior_data): Add initializers.
5662 (ada_inferior_data): Change type.
5663 (ada_inferior_data_cleanup): Remove.
5664 (get_ada_inferior_data, ada_inferior_exit)
5665 (struct ada_pspace_data): Add initializers, destructor.
5666 (ada_pspace_data_handle): Change type.
5667 (get_ada_pspace_data): Update.
5668 (ada_pspace_data_cleanup): Remove.
5669
24699405
TT		 56702019-05-08 Tom Tromey <tom@tromey.com>
5671
5672 * coffread.c (struct coff_symfile_info): Add initializers.
5673 (coff_objfile_data_key): Move lower. Change type.
5674 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5675 Update.
5676 (coff_free_info): Remove.
5677
d4e05d2f
TT		 56782019-05-08 Tom Tromey <tom@tromey.com>
5679
5680 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5681 (fbsd_pspace_data_handle): Move lower. Change type.
5682 (get_fbsd_pspace_data): Update.
5683 (fbsd_pspace_data_cleanup): Remove.
5684 (_initialize_fbsd_tdep): Update.
5685
14ef6690
TT		 56862019-05-08 Tom Tromey <tom@tromey.com>
5687
5688 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5689 (get_ada_tasks_pspace_data): Update.
5690 (ada_tasks_pspace_data_cleanup): Remove.
5691 (_initialize_tasks): Update.
5692 (ada_tasks_inferior_data_handle): Change type.
5693 (get_ada_tasks_inferior_data): Update.
5694 (ada_tasks_inferior_data_cleanup): Remove.
5695 (struct ada_tasks_pspace_data): Add initializers.
5696
814cf43a
TT		 56972019-05-08 Tom Tromey <tom@tromey.com>
5698
5699 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5700 * symfile-debug.c (debug_sym_get_probes): Change type.
5701 * stap-probe.c (handle_stap_probe):
5702 (stap_static_probe_ops::get_probes): Change type.
5703 * probe.h (class static_probe_ops) <get_probes>: Change type.
5704 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5705 (parse_probes_in_pspace): Update.
5706 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5707 Update.
5708 (any_static_probe_ops::get_probes): Change type.
5709 * elfread.c (elfread_data): New typedef.
5710 (probe_key): Change type.
5711 (elf_get_probes): Likewise. Update.
5712 (probe_key_free): Remove.
5713 (_initialize_elfread): Update.
5714 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5715 Change type.
5716 (dtrace_process_dof_probe, dtrace_process_dof)
5717 (dtrace_static_probe_ops::get_probe): Change type.
5718
02dc647e
TT		 57192019-05-08 Tom Tromey <tom@tromey.com>
5720
5721 * xcoffread.c (struct xcoff_symfile_info): Rename from
5722 coff_symfile_info. Add initializers.
5723 (xcoff_objfile_data_key): Move lower. Change type.
5724 (XCOFF_DATA): Rewrite.
5725 (xcoff_free_info): Remove.
5726 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5727 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5728 (xcoff_initial_scan): Update.
5729
09232438
TT		 57302019-05-08 Tom Tromey <tom@tromey.com>
5731
5732 * solib-svr4.c (struct svr4_info): Add initializers and
5733 destructor.
5734 <probes_table>: Now an htab_up.
5735 (solib_svr4_pspace_data): Change type.
5736 (free_probes_table): Simplify.
5737 (~svr4_info): Rename from svr4_pspace_data_cleanup.
5738 (get_svr4_info, probes_table_htab_remove_objfile_probes)
5739 (probes_table_remove_objfile_probes, register_solib_event_probe)
5740 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5741 (_initialize_svr4_solib): Update.
5742
7b4a314f
TT		 57432019-05-08 Tom Tromey <tom@tromey.com>
5744
5745 * remote.c (remote_pspace_data): Change type.
5746 (remote_pspace_data_cleanup): Remove.
5747 (get_remote_exec_file, set_pspace_remote_exec_file)
5748 (_initialize_remote): Update.
5749
51d3063a
TT		 57502019-05-08 Tom Tromey <tom@tromey.com>
5751
5752 * breakpoint.c (breakpoint_objfile_key): Change type.
5753 (get_breakpoint_objfile_data): Update.
5754 (free_breakpoint_objfile_data): Remove.
5755 (_initialize_breakpoint): Update.
5756
89fb8848
TT		 57572019-05-08 Tom Tromey <tom@tromey.com>
5758
5759 * linux-tdep.c (struct linux_info): Add initializers.
5760 (linux_inferior_data): Move. Change type.
5761 (invalidate_linux_cache_inf): Update.
5762 (linux_inferior_data_cleanup): Remove.
5763 (get_linux_inferior_data, _initialize_linux_tdep): Update.
5764
e9b89e2d
TT		 57652019-05-08 Tom Tromey <tom@tromey.com>
5766
5767 * auxv.c (auxv_inferior_data): Move. Change type.
5768 (auxv_inferior_data_cleanup): Remove.
5769 (invalidate_auxv_cache_inf): Rewrite.
5770 (get_auxv_inferior_data, _initialize_auxv): Update.
5771
8c42777c
TT		 57722019-05-08 Tom Tromey <tom@tromey.com>
5773
5774 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5775 (symfile_debug_objfile_data_key): Change type.
5776 (symfile_debug_installed, debug_qf_has_symbols)
5777 (debug_qf_find_last_source_symtab)
5778 (debug_qf_forget_cached_source_info)
5779 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5780 (debug_qf_print_stats, debug_qf_dump)
5781 (debug_qf_expand_symtabs_for_function)
5782 (debug_qf_expand_all_symtabs)
5783 (debug_qf_expand_symtabs_with_fullname)
5784 (debug_qf_map_matching_symbols)
5785 (debug_qf_expand_symtabs_matching)
5786 (debug_qf_find_pc_sect_compunit_symtab)
5787 (debug_qf_map_symbol_filenames)
5788 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5789 (debug_sym_new_init, debug_sym_init, debug_sym_read)
5790 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5791 (debug_sym_read_linetable, debug_sym_relocate): Update.
5792 (symfile_debug_free_objfile): Remove.
5793 (install_symfile_debug_logging, _initialize_symfile_debug):
5794 Update.
5795
5bfd760d
TT		 57962019-05-08 Tom Tromey <tom@tromey.com>
5797
5798 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5799 allocate_on_obstack.
5800 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5801 (get_dwarf2_per_objfile): Update.
5802 (set_dwarf2_per_objfile): Remove.
5803 (dwarf2_has_info, dwarf2_get_section_info): Update.
5804 (dwarf2_free_objfile): Remove.
5805 (_initialize_dwarf2_read): Update.
5806
e85e19b4
TT		 58072019-05-08 Tom Tromey <tom@tromey.com>
5808
5809 * auto-load.c (struct auto_load_pspace_info): Add destructor and
5810 initializers.
5811 <unsupported_script_warning_printed,
5812 script_not_found_warning_printed>: Now bool.
5813 (auto_load_pspace_data): Change type.
5814 (~auto_load_pspace_info): Rename from
5815 auto_load_pspace_data_cleanup.
5816 (get_auto_load_pspace_data, init_loaded_scripts_info)
5817 (clear_section_scripts, maybe_print_unsupported_script_warning)
5818 (maybe_print_script_not_found_warning, _initialize_auto_load):
5819 Update.
5820
f6aa7436
TT		 58212019-05-08 Tom Tromey <tom@tromey.com>
5822
5823 * objfiles.c (objfile_pspace_info): Add destructor and
5824 initializers.
5825 (objfiles_pspace_data): Change type.
5826 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5827 (get_objfile_pspace_data): Update.
5828 (objfiles_bfd_data): Change type.
5829 (get_objfile_bfd_data): Update.
5830 (objfile_bfd_data_free, _initialize_objfiles): Remove.
5831
6ae614f6
TT		 58322019-05-08 Tom Tromey <tom@tromey.com>
5833
5834 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5835 Change type.
5836 (get_catch_syscall_inferior_data): Update.
5837 (catch_syscall_inferior_data_cleanup): Remove.
5838 (_initialize_break_catch_syscall): Update.
5839
6509b8eb
TT		 58402019-05-08 Tom Tromey <tom@tromey.com>
5841
5842 * inflow.c (struct terminal_info): Add destructor and
5843 initializers.
5844 (inflow_inferior_data): Change type.
5845 (~terminal_info): Rename from inflow_inferior_data_cleanup.
5846 (get_inflow_inferior_data, inflow_inferior_exit)
5847 (swap_terminal_info, _initialize_inflow): Update.
5848
35632941
TT		 58492019-05-08 Tom Tromey <tom@tromey.com>
5850
5851 * target-dcache.c (target_dcache_cleanup): Remove.
5852 (target_dcache_aspace_key): Change type.
5853 (target_dcache_init_p, target_dcache_invalidate)
5854 (target_dcache_get, target_dcache_get_or_init)
5855 (_initialize_target_dcache): Update.
5856 * dcache.h (struct dcache_deleter): New.
5857
3017b94d
TT		 58582019-05-08 Tom Tromey <tom@tromey.com>
5859
5860 * symtab.c (struct symbol_cache): Add destructor and
5861 initializers.
5862 (symbol_cache_key): Move. Change type.
5863 (make_symbol_cache, free_symbol_cache): Remove.
5864 (get_symbol_cache): Update.
5865 (symbol_cache_cleanup): Remove.
5866 (ALL_PSPACES, symbol_cache_flush)
5867 (maintenance_print_symbol_cache)
5868 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5869 Update.
5870
a32ad8c5
TT		 58712019-05-08 Tom Tromey <tom@tromey.com>
5872
5873 * symtab.c (struct main_info): Add destructor and initializers.
5874 (main_progspace_key): Move. Change type.
5875 (get_main_info): Update.
5876 (main_info_cleanup): Remove.
5877 (_initialize_symtab): Update.
5878
5f6e90a0
TT		 58792019-05-08 Tom Tromey <tom@tromey.com>
5880
5881 * registry.h (DECLARE_REGISTRY): Define the _key class.
5882
1bd0c6e4
AB		 58832019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
5884
5885 * NEWS: Merge two 'New commands' sections.
5886
2228ef77
XR		 58872019-05-08 Joel Brobecker <brobecker@adacore.com>
5888
5889 * ada-valprint.c (ada_val_print_gnat_array): Remove language
5890 parameter and use Ada language definition instead.
5891 (ada_val_print_ptr): Remove unused language parameter.
5892 (ada_val_print_num): Remove language parameter and use Ada language
5893 definition instead.
5894 (ada_val_print_enum, ada_val_print_flt): Remove unused language
5895 parameter.
5896 (ada_val_print_struct_union, ada_val_print_ref): Remove language
5897 parameter and use Ada language definition instead.
5898 (ada_val_print_1): Update all ada_val_print_xxx calls.
5899 Remove language parameter.
5900 (ada_val_print): Update ada_val_print_1 call.
5901
60fcc1c3
TT		 59022019-05-08 Tom Tromey <tromey@adacore.com>
5903
5904 * remote.c (remote_hw_watchpoint_limit)
5905 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5906 Now static.
5907
ed2b7c17
TT		 59082019-05-08 Tom Tromey <tromey@adacore.com>
5909
5910 * maint.c (_initialize_maint_cmds): Move initialization code to
5911 remote.c.
5912 (watchdog, show_watchdog): Move to remote.c.
5913 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
5914 "watchdog" static.
5915 (_initialize_remote): Move initialization code from maint.c.
5916 * defs.h (watchdog): Don't declare.
5917
b0be6c91
TT		 59182019-05-08 Tom Tromey <tromey@adacore.com>
5919
5920 * tui/tui-interp.c: Include main.h.
5921 * interps.c: Include main.h.
5922 * main.h (interpreter_p): Declare.
5923 * defs.h (interpreter_p): Don't declare.
5924
587ee17b
TT		 59252019-05-08 Tom Tromey <tromey@adacore.com>
5926
5927 * dwarf2loc.c: Include dwarf2read.h.
5928 * defs.h (read_unsigned_leb128): Don't declare.
5929 * dwarf2read.h (read_unsigned_leb128): Declare.
5930
ca1df239
TT		 59312019-05-08 Tom Tromey <tromey@adacore.com>
5932
5933 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5934 method.
5935
99f20f08
TT		 59362019-05-08 Tom Tromey <tromey@adacore.com>
5937
5938 * utils.c (fputs_maybe_filtered): Reset style after paging, even
5939 when no wrap column is set.
5940
80e55b13
TT		 59412019-05-08 Tom Tromey <tromey@adacore.com>
5942
5943 * c-lang.c (c_get_string): Handle non-C-style arrays.
5944
9d3421af
TT		 59452019-05-08 Tom Tromey <tromey@adacore.com>
5946
5947 * typeprint.c (print_offset_data::update): Print the bit offset,
5948 not the number of bits remaining.
5949
844333e2
TT		 59502019-05-08 Tom Tromey <tromey@adacore.com>
5951
5952 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5953 padding at end of comment.
5954
988915ee
TT		 59552019-05-08 Tom Tromey <tromey@adacore.com>
5956
5957 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5958 Compare main types.
5959
26bfd823
TT		 59602019-05-06 Tom Tromey <tom@tromey.com>
5961
5962 * common/scoped_mmap.c: Include common-defs.h.
5963 * common/scoped_mmap.h: Don't include config.h.
5964
89055eaa
TT		 59652019-05-04 Tom Tromey <tom@tromey.com>
5966
5967 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5968 (struct aarch64_call_info): Add initializers.
5969 <si>: Now a std::vector.
5970 (pass_on_stack, aarch64_push_dummy_call): Update.
5971
5da01df5
TT		 59722019-05-04 Simon Marchi <simon.marchi@efficios.com>
5973 Tom Tromey <tom@tromey.com>
5974
5975 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5976 (ppc_threads): Now a std::vector. Now static.
5977 (hwdebug_find_thread_points_by_tid)
5978 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5979 Update.
5980
fbdf05a1
TT		 59812019-05-04 Tom Tromey <tom@tromey.com>
5982
5983 * arc-tdep.c (arc_tdesc_init): Return bool.
5984
06d16ec9
TT		 59852019-05-04 Tom Tromey <tom@tromey.com>
5986
5987 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5988 Use gdb_assert_not_reached.
5989
9c056022
TT		 59902019-05-04 Tom Tromey <tom@tromey.com>
5991
5992 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5993 "false".
5994
fa9c2a59
TT		 59952019-05-04 Tom Tromey <tom@tromey.com>
5996
5997 * arc-tdep.c (arc_tdesc_init): Use bool.
5998
e2eb806a
TT		 59992019-05-04 Tom Tromey <tom@tromey.com>
6000
6001 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6002
6fe87677
TT		 60032019-05-04 Tom Tromey <tom@tromey.com>
6004
6005 * cli/cli-cmds.c (valid_command_p): Return bool.
6006
7f008c9e
TT		 60072019-05-04 Tom Tromey <tom@tromey.com>
6008
6009 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6010 * command.h (valid_user_defined_cmd_name_p): Channge return type.
6011
b6484282
RT		 60122019-05-04 Raul Tambre <raul@tambre.ee>
6013
6014 * python/lib/gdb/prompt.py (_ExtendedPrompt)
6015 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6016 operator for comparison.
6017
af97b416
TT		 60182019-05-04 Tom Tromey <tom@tromey.com>
6019
6020 * psymtab.c (psymbol_name_matches, match_partial_symbol)
6021 (lookup_partial_symbol, print_partial_symbols)
6022 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6023 (psymbol_compare): Update.
6024 (add_psymbol_to_bcache): Clear the entire psymbol.
6025 (maintenance_check_psymtabs): Update.
6026 * psympriv.h (struct partial_symbol): Don't derive from
6027 general_symbol_info.
6028 <obj_section, unrelocated_address, address,
6029 set_unrelocated_address>: Update.
6030 <ginfo>: New member.
6031 * dwarf-index-write.c (write_psymbols, debug_names::insert)
6032 (debug_names::write_psymbols): Update.
6033
9d6d4be8
TV		 60342019-05-04 Tom de Vries <tdevries@suse.de>
6035
6036 * contrib/cc-with-tweaks.sh: Support -n arg.
6037
66452beb
PW		 60382019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6039
6040 * corelow.c (core_target::detach): Ensure frame cache and
6041 register caches are cleared.
6042 inferior.c (exit_inferior_1): Likewise.
6043
bde09ab7
TT		 60442019-05-03 Sandra Loosemore <sandra@codesourcery.com>
6045 Tom Tromey <tom@tromey.com>
6046
6047 * dictionary.c (collate_pending_symbols_by_language): Remove
6048 "struct" from foreach.
6049 * symtab.c (lookup_global_symbol_from_objfile)
6050 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6051 foreach.
6052 * ser-tcp.c (net_open): Remove "struct" from foreach.
6053 * objfiles.c (objfile_relocate, objfile_rebase)
6054 (objfile_has_symbols): Remove "struct" from foreach.
6055 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6056 from foreach.
6057 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6058 foreach.
6059 * darwin-nat.c (thread_info_from_private_thread_info): Remove
6060 "struct" from foreach.
6061 * ada-lang.c (create_excep_cond_exprs)
6062 (ada_exception_catchpoint_cond_string): Remove "struct" from
6063 foreach.
6064
222a8d25
TT		 60652019-05-03 Tom Tromey <tromey@adacore.com>
6066
6067 * ada-exp.y (convert_char_literal): Check suffix of each
6068 enumerator.
6069
fcd60b84
DP		 60702019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
6071
6072 PR ada/21406:
6073 * ada-exp.y (yywrap): Don't define.
6074 * ada-lex.l (%option): Add noyywrap
6075 (yywrap): Remove.
6076
5f2459c2
EZ		 60772019-05-03 Eli Zaretskii <eliz@gnu.org>
6078
353ea2d1
EZ		 6079 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6080 _WIN32_WINNT to the XP level, unless already defined to a higher
6081 level.
6082
6083 * unittests/parse-connection-spec-selftests.c:
6084 * ser-tcp.c:
6085 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
6086 override.
6087
5f2459c2
EZ		 6088 * symfile.c (find_separate_debug_file): Remove colon from the
6089 drive spec of DOS/Windows file names of the target, so that the
6090 file name produced from DEBUGDIR and the target's directory will
6091 be valid on DOS/Windows systems.
6092
80062eb9
AB		 60932019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
6094
6095 * rust-lang.c (val_print_struct): Handle printing structures
6096 containing strings.
6097
b8c05e85
TT		 60982019-05-02 Tom Tromey <tromey@adacore.com>
6099
6100 * valarith.c (_initialize_valarith): Remove.
6101
4504bbde
TT		 61022019-05-01 Tom Tromey <tromey@adacore.com>
6103
6104 * ada-lang.c (ada_value_primitive_field): Treat more fields as
6105 bitfields.
6106
d48e62f4
TT		 61072019-05-01 Tom Tromey <tromey@adacore.com>
6108
6109 * ada-lang.c (ada_value_assign): Correctly compute starting offset
6110 for big-endian copies.
6111
15f18d14
AT		 61122019-04-30 Ali Tamur <tamur@google.com>
6113 * gdb/dwarf2read.c (read_3_bytes): New declaration.
6114 (read_attribute_value): Added DW_FORM_strx1-4 cases.
6115 (read_3_bytes): New function.
6116
ab4ee614
JB		 61172019-04-30 Joel Brobecker <brobecker@adacore.com>
6118
6119 * windows-nat.c (main_thread_id): Delete.
6120 (handle_output_debug_string): Replace main_thread_id by
6121 current_event.dwThreadId.
6122 (fake_create_process): Likewise.
6123 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6124 Do not set main_thread_id.
6125 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6126 current_event.dwThreadId.
6127 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6128
8ed5b76e
JB		 61292019-04-30 Joel Brobecker <brobecker@adacore.com>
6130
6131 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6132 Use current_event.dwThreadId instead of main_thread_id.
6133
2ff0a947
TT		 61342019-04-30 Tom Tromey <tromey@adacore.com>
6135
6136 * ada-lang.c (ada_lookup_simple_minsyms): New function.
6137 (create_excep_cond_exprs): Iterate over program spaces.
6138 (ada_exception_catchpoint_cond_string): Examine all minimal
6139 symbols for exception types.
6140
a776957c
TT		 61412019-04-30 Tom Tromey <tromey@adacore.com>
6142
6143 PR c++/24470:
6144 * dwarf2read.c (process_structure_scope): Handle case where type
6145 has template parameters but no symbol was created.
6146
bc68014d
AB		 61472019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6148 Chris January <chris.january@arm.com>
6149
6150 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6151 qualifier.
6152 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6153
f1fdc960
AB		 61542019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6155
6156 * f-typeprint.c (f_print_type): Update rules for printing
6157 whitespace.
6158 (f_type_print_varspec_suffix): Likewise.
6159
bf7a4de1
AB		 61602019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6161 Chris January <chris.january@arm.com>
6162
6163 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6164 function arguments.
6165
bbe75b9d
AB		 61662019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6167
6168 * f-lang.c (build_fortran_types): Change name of void type to
6169 lower case.
6170 * f-typeprint.c (f_type_print_base): Print the name of the void
6171 type, rather than a fixed string.
6172 * f-valprint.c (f_decorations): Use lower case void string.
6173
1db455a7
AB		 61742019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6175 Chris January <chris.january@arm.com>
6176
6177 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6178 types for Fortran.
6179
b6d03bb2
AB		 61802019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6181 Chris January <chris.january@arm.com>
6182 David Lecomber <david.lecomber@arm.com>
6183
6184 * f-exp.y (BINOP_INTRINSIC): New token.
6185 (exp): New parser rule handling BINOP_INTRINSIC.
6186 (f77_keywords): Add new builtin procedures.
6187 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6188 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6189 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6190 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6191 (print_unop_subexp_f): New function.
6192 (print_binop_subexp_f): New function.
6193 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6194 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6195 (dump_subexp_body_f): Likewise.
6196 (operator_check_f): Likewise.
6197 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6198 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6199
83228e93
AB		 62002019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6201
6202 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6203 UNOP_KIND.
6204 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6205 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6206 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6207 (operator_length_f): New fuction.
6208 (print_subexp_f): New function.
6209 (op_name_f): New function.
6210 (dump_subexp_body_f): New function.
6211 (operator_check_f): New function.
6212 (exp_descriptor_f): Replace standard expression handling functions
6213 with new functions.
6214 * gdb/fortran-operator.def: New file.
6215 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6216 * gdb/std-operator.def: Remove UNOP_KIND.
6217
6fdcd7cc
AB		 62182019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6219
6220 * std-operator.def: Remove unbalanced, stray double quote
6221 character.
6222
2e62ab40
AB		 62232019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6224 Chris January <chris.january@arm.com>
6225 Daniel Everett <daniel.everett@arm.com>
6226 Nick Forrington <nick.forrington@arm.com>
6227 Richard Bunt <richard.bunt@arm.com>
6228
6229 * cp-valprint.c (cp_print_value_fields): Allow an additional level
6230 of depth when printing anonymous structs or unions.
6231 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6232 Don't print either the top-level value, or the children if the
6233 max-depth is exceeded.
6234 (ppscm_print_children): When printing the key of a map, allow one
6235 extra level of depth.
6236 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6237 print either the top-level value, or the children if the max-depth
6238 is exceeded.
6239 (print_children): When printing the key of a map, allow one extra
6240 level of depth.
6241 * python/py-value.c (valpy_format_string): Add max_depth keyword.
6242 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6243 (user_print_options): Initialise max_depth field.
6244 (val_print_scalar_or_string_type_p): New function.
6245 (val_print): Check to see if the max depth has been reached.
6246 (val_print_check_max_depth): Define new function.
6247 (show_print_max_depth): New function.
6248 (_initialize_valprint): Add 'print max-depth' option.
6249 * valprint.h (struct value_print_options) <max_depth>: New field.
6250 (val_print_check_max_depth): Declare new function.
6251 * NEWS: Document new feature.
6252
4be290b2
AB		 62532019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6254
6255 * ada-lang.c (ada_language_defn): Initialise new field.
6256 * c-lang.c (c_is_string_type_p): New function.
6257 (c_language_defn): Initialise new field.
6258 (cplus_language_defn): Initialise new field.
6259 (asm_language_defn): Initialise new field.
6260 (minimal_language_defn): Initialise new field.
6261 * c-lang.h (c_is_string_type_p): Declare new function.
6262 * d-lang.c (d_language_defn): Initialise new field.
6263 * f-lang.c (f_is_string_type_p): New function.
6264 (f_language_defn): Initialise new field.
6265 * go-lang.c (go_is_string_type_p): New function.
6266 (go_language_defn): Initialise new field.
6267 * language.c (default_is_string_type_p): New function.
6268 (unknown_language_defn): Initialise new field.
6269 (auto_language_defn): Initialise new field.
6270 * language.h (struct language_defn) <la_is_string_type_p>: New
6271 member variable.
6272 (default_is_string_type_p): Declare new function.
6273 * m2-lang.c (m2_language_defn): Initialise new field.
6274 * objc-lang.c (objc_language_defn): Initialise new field.
6275 * opencl-lang.c (opencl_language_defn): Initialise new field.
6276 * p-lang.c (pascal_is_string_type_p): New function.
6277 (pascal_language_defn): Initialise new field.
6278 * rust-lang.c (rust_is_string_type_p): New function.
6279 (rust_language_defn): Initialise new field.
6280
721b08c6
AB		 62812019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6282
6283 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6284 New field.
6285 * ada-lang.c (ada_language_defn): Initialise new field.
6286 * c-lang.c (c_language_defn): Likewise.
6287 (cplus_language_defn): Likewise.
6288 (asm_language_defn): Likewise.
6289 (minimal_language_defn): Likewise.
6290 * d-lang.c (d_language_defn): Likewise.
6291 * f-lang.c (f_language_defn): Likewise.
6292 * go-lang.c (go_language_defn): Likewise.
6293 * language.c (unknown_language_defn): Likewise.
6294 (auto_language_defn): Likewise.
6295 * m2-lang.c (m2_language_defn): Likewise.
6296 * objc-lang.c (objc_language_defn): Likewise.
6297 * opencl-lang.c (opencl_language_defn): Likewise.
6298 * p-lang.c (pascal_language_defn): Likewise.
6299 * rust-lang.c (rust_language_defn): Likewise.
6300
fc913e53
AB		 63012019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6302
6303 * ada-lang.c (ada_is_character_type): Change return type to bool.
6304 (ada_is_string_type): Likewise.
6305 * ada-lang.h (ada_is_character_type): Update declaration
6306 (ada_is_string_type): Likewise.
6307
fa731fa0
PW		 63082019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6309
6310 Support style in 'frame|thread apply'
6311
6312 * gdbcmd.h (execute_command_to_string): New term_out parameter.
6313 * record.c (record_start, record_stop): Update callers of
6314 execute_command_to_string with false.
6315 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6316 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6317 methods.
6318 (class string_file): New constructor with term_out parameter.
6319 Override methods term_out and can_emit_style_escape. New member
6320 term_out.
6321 (class stdio_file): Override can_emit_style_escape.
6322 (class tee_file): Override term_out and can_emit_style_escape.
6323 * utils.h (can_emit_style_escape): Remove.
6324 * utils.c (can_emit_style_escape): Likewise.
6325 Update all callers of can_emit_style_escape (SOMESTREAM) to
6326 SOMESTREAM->can_emit_style_escape.
6327 * source-cache.c (source_cache::get_source_lines): Likewise.
6328 * stack.c (frame_apply_command_count): Call execute_command_to_string
6329 passing the term_out characteristic of the current gdb_stdout.
6330 * thread.c (thr_try_catch_cmd): Likewise.
6331 * top.c (execute_command_to_string): pass term_out parameter
6332 to construct the string_file for the command output.
6333 * ui-file.c (term_cli_styling): New function (most code moved
6334 from utils.c can_emit_style_escape).
6335 (string_file::string_file, string_file::can_emit_style_escape,
6336 stdio_file::can_emit_style_escape, tee_file::term_out,
6337 tee_file::can_emit_style_escape): New functions.
6338
136afab8
PW		 63392019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6340
6341 * NEWS: Mention the new set|show may-call-functions.
6342 * infcall.c (may_call_functions_p): New variable.
6343 (show_may_call_functions_p): New function.
6344 (call_function_by_hand_dummy): Throws an error if not
6345 may-call-functions.
6346 (_initialize_infcall): Call add_setshow_boolean_cmd for
6347 may-call-functions.
6348
725cbb63
KS		 63492019-04-25 Keith Seitz <keiths@redhat.com>
6350
6351 PR c++/24367
6352 * cp-support.c (inspect_type): Don't attempt substitutions
6353 of symbol with the same name.
6354
3d1cbb78
TT		 63552019-04-25 Tom Tromey <tromey@adacore.com>
6356
6357 PR gdb/24475:
6358 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6359 static.
6360
94aeb44b
TT		 63612019-04-25 Tom Tromey <tromey@adacore.com>
6362
6363 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6364 rvalue reference.
6365 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6366 (gdb_xml_parser::parse): Use std::move.
6367 * python/python-internal.h (gdbpy_convert_exception): Take a const
6368 reference.
6369 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6370 std::move.
6371 * python/py-utils.c (gdbpy_convert_exception): Take a const
6372 reference.
6373 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6374 Use std::move.
6375 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6376 Use std::move.
6377 * mi/mi-main.c (mi_print_exception): Take a const reference.
6378 * main.c (handle_command_errors): Take a const reference.
6379 * linespec.c (parse_linespec): Use std::move.
6380 * infcall.c (run_inferior_call): Use std::move.
6381 (call_function_by_hand_dummy): Use std::move.
6382 * exec.c (try_open_exec_file): Use std::move.
6383 * exceptions.h (exception_print, exception_fprintf)
6384 (exception_print_same): Update.
6385 * exceptions.c (print_exception, exception_print)
6386 (exception_fprintf, exception_print_same): Change parameters to
6387 const reference.
6388 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6389 * common/new-op.c: Use std::move.
6390 * common/common-exceptions.h (struct gdb_exception): Add move
6391 constructor.
6392 (struct gdb_exception_error, struct gdb_exception_quit, struct
6393 gdb_quit_bad_alloc): Change constructor to move constructor.
6394 (throw_exception): Change parameter to rvalue reference.
6395 * common/common-exceptions.c (throw_exception): Take rvalue
6396 reference.
6397 * cli/cli-interp.c (safe_execute_command): Use std::move.
6398 * breakpoint.c (insert_bp_location, location_to_sals): Use
6399 std::move.
6400
680d7fd5
TT		 64012019-04-25 Tom Tromey <tromey@adacore.com>
6402
6403 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6404 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6405 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6406 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6407 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6408 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6409 guile/scm-value.c: Use unpack.
6410 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6411 gdbscm_gdb_exception.
6412 (gdbscm_throw_gdb_exception): Likewise.
6413 (struct gdbscm_gdb_exception): New.
6414 (unpack): New function.
6415 (gdbscm_wrap): Use unpack.
6416
c6fdd8b2
TT		 64172019-04-25 Tom Tromey <tromey@adacore.com>
6418
6419 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6420 (gdb_rl_callback_handler): Use std::move.
6421 * common/common-exceptions.h (struct gdb_exception): Add move
6422 assignment operator.
6423 (throw_exception_sjlj): Change "exception" to const reference.
6424 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6425 (throw_exception_sjlj): Change "exception" to const reference.
6426
cc06b668
TT		 64272019-04-25 Tom Tromey <tromey@adacore.com>
6428
6429 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6430 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6431 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6432 Update.
6433 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6434 Update.
6435 * mi/mi-interp.c (mi_interp::exec): Update.
6436 * linespec.c (parse_linespec): Update.
6437 * infcall.c (run_inferior_call): Update.
6438 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6439 * guile/scm-symbol.c (gdbscm_lookup_symbol)
6440 (gdbscm_lookup_global_symbol): Update.
6441 * guile/scm-param.c (gdbscm_parameter_value): Update.
6442 * guile/scm-frame.c (gdbscm_frame_read_register)
6443 (gdbscm_frame_read_var): Update.
6444 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6445 * exec.c (try_open_exec_file): Update.
6446 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6447 (gdb_rl_callback_handler): Update.
6448 * common/common-exceptions.h (exception_none): Don't declare.
6449 * common/common-exceptions.c (exception_none): Don't define.
6450 (struct catcher) <exception>: Update.
6451 * cli/cli-interp.c (safe_execute_command): Update.
6452 * breakpoint.c (insert_bp_location, location_to_sals): Update.
6453
cf532bd1
AT		 64542019-04-25 Ali Tamur <tamur@google.com>
6455
6456 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6457 (read_attribute_value): Likewise.
6458 (dwarf2_read_addr_index): Update comment.
6459 (read_str_index): Add DW_FORM_strx.
6460 (dwarf2_string_attr): Likewise.
6461 (dwarf2_const_value_attr): Likewise.
6462 (dump_die_shallow): Likewise.
6463 (dwarf2_fetch_constant_bytes): Likewise.
6464 (skip_form_bytes): Likewise.
6465 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6466
82433e3e
SDJ		 64672019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
6468
6469 PR corefiles/11608
6470 PR corefiles/18187
6471 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6472 OFFSET. Verify if current mapping contains an ELF header.
6473 (linux_find_memory_regions_full): Adjust call to
6474 dump_mapping_p.
6475
723adb65
SL		 64762019-04-25 Sandra Loosemore <sandra@codesourcery.com>
6477 Kang Li <kanglictf@gmail.com>
6478
6479 PR gdb/21600
6480
6481 * dwarf2-frame.c (read_initial_length): Be consistent about using
6482 unsigned representation of length.
6483 (decode_frame_entry_1): Likewise. Check for wraparound of
6484 end pointer as well as buffer overflow.
6485
596179f7
SDJ		 64862019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
6487
6488 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6489 "vq".
6490
a59240a4
TT		 64912019-04-24 Tom Tromey <tromey@adacore.com>
6492
6493 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6494
f872fdbb
AB		 64952019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6496
6497 * s12z-tdep.c (s12z_unwind_pc): Delete.
6498 (s12z_unwind_sp): Delete.
6499 (s12z_gdbarch_init): Don't register deleted functions with
6500 gdbarch.
6501
b614e6f3
AB		 65022019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6503
6504 * rl78-tdep.c (rl78_unwind_sp): Delete.
6505 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6506
14faed38
AB		 65072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6508
6509 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6510 (xstormy16_unwind_pc): Delete.
6511 (xstormy16_dummy_id): Delete.
6512 (xstormy16_gdbarch_init): Don't register deleted functions with
6513 gdbarch.
6514
541aad8a
AB		 65152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6516
6517 * vax-tdep.c (vax_unwind_pc): Delete.
6518 (vax_gdbarch_init): Don't register deleted function with gdbarch.
6519
29222070
AB		 65202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6521
6522 * v850-tdep.c (v850_unwind_sp): Delete.
6523 (v850_unwind_pc): Delete.
6524 (v850_dummy_id): Delete.
6525 (v850_gdbarch_init): Don't register deleted functions with
6526 gdbarch.
6527
0f534d76
AB		 65282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6529
6530 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6531 (tilegx_unwind_pc): Delete.
6532 (tilegx_unwind_dummy_id): Delete.
6533 (tilegx_gdbarch_init): Don't register deleted functions with
6534 gdbarch.
6535
1ba7b7f9
AB		 65362019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6537
6538 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6539 (tic6x_dummy_id): Delete.
6540 (tic6x_gdbarch_init): Don't register deleted functions with
6541 gdbarch.
6542
d31f262c
AB		 65432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6544
6545 * sparc-tdep.c (sparc_unwind_pc): Delete.
6546 (sparc32_gdbarch_init): Don't register deleted function with
6547 gdbarch.
6548
6d14d64d
AB		 65492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6550
6551 * sh-tdep.c (sh_unwind_sp): Delete.
6552 (sh_unwind_pc): Delete.
6553 (sh_dummy_id): Delete.
6554 (sh_gdbarch_init): Don't register deleted functions with
6555 gdbarch.
6556
a40dde9d
AB		 65572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6558
6559 * score-tdep.c (score_unwind_sp): Delete.
6560 (score_unwind_pc): Delete.
6561 (score_dummy_id): Delete.
6562 (score_gdbarch_init): Don't register deleted functions with
6563 gdbarch.
6564
47c47d69
AB		 65652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6566
6567 * rx-tdep.c (rx_unwind_pc): Delete.
6568 (rx_unwind_sp): Delete.
6569 (rx_dummy_id): Delete.
6570 (rx_gdbarch_init): Don't register deleted functions with
6571 gdbarch. Update comment.
6572
833a4480
AB		 65732019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6574
6575 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6576 (rs6000_dummy_id): Delete.
6577 (rs6000_gdbarch_init): Don't register deleted functions with
6578 gdbarch.
6579
3f2cef49
AB		 65802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6581
6582 * or1k-tdep.c (or1k_dummy_id): Delete.
6583 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6584
96acf884
AB		 65852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6586
6587 * nios2-tdep.c (nios2_dummy_id): Delete.
6588 (nios2_unwind_sp): Delete.
6589 (nios2_gdbarch_init): Don't register deleted functions with
6590 gdbarch.
6591
ca0ab0aa
AB		 65922019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6593
6594 * nds32-tdep.c (nds32_dummy_id): Delete.
6595 (nds32_unwind_pc): Delete.
6596 (nds32_unwind_sp): Delete.
6597 (nds32_gdbarch_init): Don't register deleted functions with
6598 gdbarch.
6599
c8259044
AB		 66002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6601
6602 * msp430-tdep.c (msp430_unwind_pc): Delete.
6603 (msp430_unwind_sp): Delete.
6604 (msp430_dummy_id): Delete.
6605 (msp430_gdbarch_init): Don't register deleted functions with
6606 gdbarch.
6607
27f113c8
AB		 66082019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6609
6610 * moxie-tdep.c (moxie_unwind_sp): Delete.
6611 (moxie_unwind_pc): Delete.
6612 (moxie_dummy_id): Delete.
6613 (moxie_gdbarch_init): Don't register deleted functions with
6614 gdbarch.
6615
aee6c3cd
AB		 66162019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6617
6618 * mn10300-tdep.c (mn10300_dummy_id): Delete.
6619 (mn10300_unwind_pc): Delete.
6620 (mn10300_unwind_sp): Delete.
6621 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6622 mn10300_unwind_sp.
6623 (mn10300_frame_unwind_init): Don't register deleted functions with
6624 gdbarch.
6625
8e2b5aea
AB		 66262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6627
6628 * mep-tdep.c (mep_unwind_pc): Delete.
6629 (mep_unwind_sp): Delete.
6630 (mep_dummy_id): Delete.
6631 (mep_gdbarch_init): Don't register deleted functions with
6632 gdbarch.
6633
43cf3ede
AB		 66342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6635
6636 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6637 (m68hc11_unwind_sp): Delete.
6638 (m68hc11_gdbarch_init): Don't register deleted functions with
6639 gdbarch.
6640
5e79b7bb
AB		 66412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6642
6643 * m32r-tdep.c (m32r_unwind_sp): Delete.
6644 (m32r_unwind_pc): Delete.
6645 (m32r_dummy_id): Delete.
6646 (m32r_gdbarch_init): Don't register deleted functions with
6647 gdbarch.
6648
89b268d8
AB		 66492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6650
6651 * m32c-tdep.c (m32c_unwind_pc): Delete.
6652 (m32c_unwind_sp): Delete.
6653 (m32c_dummy_id): Delete.
6654 (m32c_gdbarch_init): Don't register deleted functions with
6655 gdbarch.
6656
946c28d2
AB		 66572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6658
6659 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6660 (lm32_unwind_pc): Delete.
6661 (lm32_dummy_id): Delete.
6662 (lm32_gdbarch_init): Don't register deleted functions with
6663 gdbarch.
6664
bf12844a
AB		 66652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6666
6667 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6668 (iq2000_unwind_pc): Delete.
6669 (iq2000_dummy_id): Delete.
6670 (iq2000_gdbarch_init): Don't register deleted functions with
6671 gdbarch.
6672
ecbc06d2
AB		 66732019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6674
6675 * nds32-tdep.c (nds32_type_align): Delete.
6676 (nds32_push_dummy_call): Use type_align instead.
6677
030197b4
AB		 66782019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6679
6680 * arm-tdep.c (arm_type_align): Only handle vector override case.
6681 (arm_push_dummy_call): Use type_align.
6682 (arm_gdbarch_init): Register arm_type_align gdbarch function.
6683
b907456c
AB		 66842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6685
6686 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6687 case.
6688 (pass_on_stack): Use type_align.
6689 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6690 function.
6691
9e97ba43
TT		 66922019-04-23 Tom Tromey <tromey@adacore.com>
6693
6694 * dwarf2read.c (line_header::file_name_at): Remove unused
6695 overload.
6696
6892f601
TV		 66972019-04-23 Tom de Vries <tdevries@suse.de>
6698
6699 PR gdb/24438
6700 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6701 invocation.
6702
336d760d
AT		 6703
67042019-03-27 Ali Tamur <tamur@google.com>
6705
6706 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6707 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6708 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6709 (dwarf_expr_context::get_addr_index): Likewise
6710 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6711 (symbol_needs_eval_context::get_addr_index): Likewise
6712 (disassemble_dwarf_expression): Add DW_OP_addrx
6713 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6714 (read_cutu_die_from_dwo): Update comment
6715 (skip_one_die): Add DW_FORM_addrx
6716 (read_attribute_value): Likewise
6717 (var_decode_location): Add DW_OP_addrx
6718 (dwarf2_const_value_attr): Add DW_FORM_addrx
6719 (dump_die_shallow): Likewise
6720 (dwarf2_fetch_constant_bytes): Likewise
6721 (decode_locdesc): Add DW_OP_addrx
6722 (skip_form_bytes): Add DW_FORM_addrx
6723
ad9d13f8
AT		 67242019-04-22 Ali Tamur <tamur@google.com>
6725
6726 * MAINTAINERS (Write After Approval): Add self.
6727
d70cc3ba
SM		 67282019-04-22 Simon Marchi <simon.marchi@efficios.com>
6729
6730 * solib-svr4.c (get_svr4_info): Add pspace parameter.
6731 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6732 (open_symbol_file_object): Likewise.
6733 (svr4_default_sos): Add info parameter.
6734 (svr4_read_so_list): Likewise.
6735 (svr4_current_sos_direct): Adjust functions calls to pass down
6736 info.
6737 (svr4_current_sos_1): Add info parameter.
6738 (svr4_current_sos): Call get_svr4_info, pass info down to
6739 svr4_current_sos_1.
6740 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6741 get_svr4_info.
6742 (svr4_in_dynsym_resolve_code): Pass current_program_space to
6743 get_svr4_info.
6744 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6745 to get_svr4_info.
6746 (probes_table_remove_objfile_probes): Likewise.
6747 (register_solib_event_probe): Add info parameter.
6748 (solist_update_incremental): Pass info parameter down to
6749 svr4_read_so_list.
6750 (disable_probes_interface): Add info parameter.
6751 (svr4_handle_solib_event): Pass current_program_space to
6752 get_svr4_info. Adjust disable_probes_interface cleanup.
6753 (svr4_create_probe_breakpoints): Add info parameter, pass it
6754 down to register_solib_event_probe.
6755 (svr4_create_solib_event_breakpoints): Add info parameter,
6756 pass it down to svr4_create_probe_breakpoints.
6757 (enable_break): Pass info down to
6758 svr4_create_solib_event_breakpoints.
6759 (svr4_solib_create_inferior_hook): Pass current_program_space to
6760 get_svr4_info.
6761 (svr4_clear_solib): Likewise.
6762
7905fc35
PA		 67632019-04-22 Pedro Alves <palves@redhat.com>
6764
6765 * solib-svr4.c (svr4_free_objfile_observer): New.
6766 (probe_and_action::objfile): New field.
6767 (probes_table_htab_remove_objfile_probes)
6768 (probes_table_remove_objfile_probes): New functions.
6769 (register_solib_event_probe): Add 'objfile' parameter. Store it
6770 in the new probe_and_action. Don't store the probe in 'lookup'.
6771 (svr4_create_probe_breakpoints): Pass objfile to
6772 register_solib_event_probe.
6773 (_initialize_svr4_solib): Register a free_objfile observer.
6774
fb881986
TT		 67752019-04-19 Tom Tromey <tom@tromey.com>
6776
6777 * common/queue.h: Remove.
6778
8732db6c
TT		 67792019-04-19 Tom Tromey <tom@tromey.com>
6780
6781 * event-loop.c: Don't include "common/queue.h".
6782
97dfbadd
TT		 67832019-04-19 Tom Tromey <tom@tromey.com>
6784
6785 * remote.c (remote_target): Use delete.
6786 * remote-notif.h: Include <list>, not "common/queue.h".
6787 (notif_client_p): Remove typedef.
6788 (remote_notif_state): Add constructor, destructor, initializer.
6789 <notif_queue>: Now a std::list.
6790 (remote_notif_state_xfree): Don't declare.
6791 * remote-notif.c (remote_notif_process, handle_notification)
6792 (remote_notif_state_allocate): Update.
6793 (~remote_notif_state): Rename from remote_notif_state_xfree.
6794
cf250e36
TT		 67952019-04-19 Tom Tromey <tom@tromey.com>
6796
6797 * symfile.c (reread_symbols): Update.
6798 * objfiles.c (objfile_register_static_link)
6799 (objfile_lookup_static_link): Update
6800 (~objfile) Don't delete static_links.
6801 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6802
61f4b350
TT		 68032019-04-19 Tom Tromey <tom@tromey.com>
6804
6805 * type-stack.h (struct type_stack) <insert>: Constify string.
6806 * type-stack.c (type_stack::insert): Constify string.
6807 * gdbtypes.h (lookup_template_type): Update.
6808 (address_space_name_to_int): Update.
6809 * gdbtypes.c (address_space_name_to_int): Make space_identifier
6810 const.
6811 (lookup_template_type): Make name const.
6812 * c-exp.y: Update rules.
6813 (lex_one_token, classify_name, classify_inner_name)
6814 (c_print_token): Update.
6815 * p-exp.y: Update rules.
6816 (yylex): Update.
6817 * f-exp.y: Update rules.
6818 (yylex): Update.
6819 * d-exp.y: Update rules.
6820 (lex_one_token, classify_name, classify_inner_name): Update.
6821 * parse.c (write_dollar_variable, copy_name): Return std::string.
6822 * parser-defs.h (copy_name): Change return type.
6823 * m2-exp.y: Update rules.
6824 (yylex): Update.
6825 * go-exp.y (lex_one_token): Update.
6826 Update rules.
6827 (classify_unsafe_function, classify_packaged_name)
6828 (classify_name, yylex): Update.
6829
189b8c2e
ST		 68302019-04-19 Sergei Trofimovich <siarheit@google.com>
6831
6832 * configure.ac: add --enable-source-highlight switch.
6833 * configure: Regenerate.
6834 * top.c (print_gdb_version): plumb --enable-source-highlight
6835 status to "show configuration".
6836
8ecb59f8
TT		 68372019-04-19 Tom Tromey <tromey@adacore.com>
6838
6839 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6840 Check ADA_TYPE_P.
6841 (empty_record, ada_template_to_fixed_record_type_1)
6842 (template_to_static_fixed_type)
6843 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6844 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6845 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6846 macros.
6847
62160ec9
TT		 68482019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
6849
6850 PR symtab/24423:
6851 * source.c (print_source_lines_base): Advance "iter" when a
6852 control character is seen.
6853
f2ae8bc8
PW		 68542019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6855
6856 * inferior.h (struct infcall_suspend_state_deleter):
6857 Catch exception in destructor to avoid crash.
6858
d563b953
PW		 68592019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6860
6861 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6862 close to the add_com "shell".
6863
dc34c897
TT		 68642019-04-18 Tom Tromey <tromey@adacore.com>
6865
6866 * process-stratum-target.h (class process_stratum_target)
6867 <stratum>: Add "final".
6868
a12e5744
TT		 68692019-04-17 Tom Tromey <tromey@adacore.com>
6870
6871 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6872 against nullptr before use.
6873
a7e559cc
AH		 68742019-04-17 Alan Hayward <alan.hayward@arm.com>
6875
6876 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6877
c01660c6
AB		 68782019-04-17 Jim Wilson <jimw@sifive.com>
6879 Andrew Burgess <andrew.burgess@embecosm.com>
6880
6881 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6882 code read might fail, assume 4-byte breakpoint in that case.
6883
4aa866af
LS		 68842019-04-15 Leszek Swirski <leszeks@google.com>
6885
6886 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6887 rather than a hand-rolled POD check when checking for forced MEMORY
6888 classification.
6889
48574d91
AH		 68902019-04-15 Alan Hayward <alan.hayward@arm.com>
6891
6892 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6893 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6894 function.
6895 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6896 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6897 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6898 declaration.
6899
4da037ef
AH		 69002019-04-15 Alan Hayward <alan.hayward@arm.com>
6901
6902 * aarch64-linux-nat.c
6903 (aarch64_linux_nat_target::thread_architecture): Add override.
6904 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6905 each VQ.
6906
ccb8d7e8
AH		 69072019-04-15 Alan Hayward <alan.hayward@arm.com>
6908
6909 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6910
35add35e
AB		 69112019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
6912
6913 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6914 target types of size 96-bits, add some additional comments, and
6915 check that the builtin type we found was the correct size.
6916
51196bbc
EZ		 69172019-04-12 Eli Zaretskii <eliz@gnu.org>
6918
6919 * utils.c (prompt_for_continue): Don't restore the styling at the
6920 end, as applied_style has the wrong value. This fixes styling in
6921 long lists of file names that are interrupted by the "Continue?"
6922 prompt.
6923
62253a61
AB		 69242019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
6925
6926 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6927 * c-lang.c (c_language_defn): Likewise.
6928 (cplus_language_defn): Likewise.
6929 (asm_language_defn): Likewise.
6930 (minimal_language_defn): Likewise.
6931 * d-lang.c (d_language_defn): Likewise.
6932 * f-lang.c (f_language_defn): Likewise.
6933 * go-lang.c (go_language_defn): Likewise.
6934 * language.c (unknown_language_defn): Likewise.
6935 (auto_language_defn): Likewise.
6936 * language.h (struct language_defn): Remove la_magic field.
6937 (LANG_MAGIC): Delete.
6938 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6939 * objc-lang.c (objc_language_defn): Likewise.
6940 * opencl-lang.c (opencl_language_defn): Likewise.
6941 * p-lang.c (pascal_language_defn): Likewise.
6942 * rust-lang.c (rust_language_defn): Likewise.
6943
a9158a86
AB		 69442019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6945
6946 * riscv-tdep.c (riscv_type_align): New function.
6947 (riscv_type_alignment): Delete.
6948 (riscv_arg_location): Use 'type_align'.
6949 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6950
41077b66
AB		 69512019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6952
6953 * gdbtypes.c (type_align): A struct with no non-static fields also
6954 has alignment of 1.
6955
9f0272f8
AB		 69562019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6957
6958 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6959 component to 0.
6960 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6961 member.
6962 (riscv_struct_info::analyse): New implementation using new
6963 analyse_inner member function.
6964 (riscv_struct_info::field_offset): New member function.
6965 (riscv_struct_info::m_offsets): New member variable.
6966 (riscv_struct_info::analyse_inner): New private member function,
6967 takes the old implementation of riscv_struct_info::analyse but
6968 extended to track field offsets.
6969 (riscv_call_arg_struct): Update the struct folding special cases
6970 to handle cases where empty C++ structs, which are non-zero
6971 length, are found.
6972 (riscv_arg_location): Initialise the length of each location, a
6973 non-zero length now indicates the location is in use.
6974 (riscv_push_dummy_call): Allow for the first location having a
6975 non-zero offset when setting up arguments.
6976 (riscv_return_value): Likewise, but for return values.
6977
02cf60c7
TT		 69782019-04-11 Tom Tromey <tromey@adacore.com>
6979
6980 * utils.c (internal_vproblem): Make "msg" const.
6981
68811f8f
AH		 69822019-04-11 Alan Hayward <alan.hayward@arm.com>
6983
6984 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6985 * trad-frame.c (trad_frame_reset_saved_regs): New function.
6986 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6987 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6988
3f52fdbc
KB		 69892019-04-10 Kevin Buettner <kevinb@redhat.com>
6990
6991 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6992 function.
6993 (fill_gregset): Call amd64_linux_collect_native_gregset instead
6994 of amd64_collect_native_gregset.
6995 (amd64_linux_nat_target::store_registers): Likewise.
6996
e9ad22ee
TT		 69972019-04-10 Tom Tromey <tom@tromey.com>
6998
6999 * symtab.c (lookup_global_symbol_from_objfile)
7000 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7001 * objfiles.h (class separate_debug_iterator): New.
7002 (class separate_debug_range): New.
7003 (struct objfile) <separate_debug_objfiles>: New method.
7004 (objfile_separate_debug_iterate): Don't declare.
7005 * objfiles.c (separate_debug_iterator::operator++): Rename from
7006 objfile_separate_debug_iterate.
7007 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7008 iterator.
7009 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7010 iterator.
7011
ee371134
TT		 70122019-04-10 Tom Tromey <tom@tromey.com>
7013
7014 * symfile.c (reread_symbols): Remove old comment.
7015 * objfiles.c (free_all_objfiles): Fix a typo.
7016
bf227d61
TT		 70172019-04-10 Tom Tromey <tom@tromey.com>
7018
7019 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7020 * minsyms.c (lookup_minimal_symbol): Use foreach.
7021 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7022 (lookup_minimal_symbol_solib_trampoline): Likewise.
7023 * symfile.c (reread_symbols): Use foreach.
7024
8dc433a0
TT		 70252019-04-09 Ivan Begert <ivanbegert@gmail.com>
7026 Tom Tromey <tromey@adacore.com>
7027
7028 PR rust/24414:
7029 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7030 (rust_lex_int_test): Change "value" to be LONGEST.
7031 (rust_lex_tests): Add test for long integer literal.
7032
9ab8741a
TT		 70332019-04-09 Tom Tromey <tromey@adacore.com>
7034
7035 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7036 to bool.
7037 (extended_remote_target::attach): Update.
7038 (remote_target::remote_notice_new_inferior): Update.
7039 (remote_target::add_current_inferior_and_thread): Update.
7040 * inferior.c (exit_inferior_1): Use "false".
7041 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7042
e242fd12
SM		 70432019-04-09 Simon Marchi <simon.marchi@efficios.com>
7044
9ca1957f 7045 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM		 7046 the "start" command.
7047
2b0c8b01
KB		 70482019-04-08 Kevin Buettner <kevinb@redhat.com>
7049
7050 * python/py-inferior.c (infpy_thread_from_thread_handle):
7051 Adjust comments to reflect renaming of thread_from_thread_handle
7052 to thread_from_handle. Adjust keywords. Fix type error message.
7053 (inferior_object_methods): Add thread_from_handle. Retain
7054 thread_from_thread_handle, but mark it as deprecated.
7055
50a82723
KB		 70562019-04-08 Kevin Buettner <kevinb@redhat.com>
7057
7058 * gdbthread.h (find_thread_by_handle): Revise declaration.
7059 * thread.c (find_thread_by_handle): Likewise. Adjust
7060 implementation too.
7061 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7062 support for buffer objects as handles.
7063
cf63b016
KB		 70642019-04-08 Kevin Buettner <kevinb@redhat.com>
7065
7066 * python/py-infthread.c (thpy_thread_handle): New function.
7067 (thread_object_methods): Register thpy_thread_handle.
7068
3d6c6204
KB		 70692019-04-08 Kevin Buettner <kevinb@redhat.com>
7070
7071 * gdbthread.h (thread_to_thread_handle): Declare.
7072 * thread.c (gdbtypes.h): Include.
7073 (thread_to_thread_handle): New function.
7074
7075 * target.h (struct target_ops): Add thread_info_to_thread_handle.
7076 (target_thread_info_to_thread_handle): Declare.
7077 * target.c (target_thread_info_to_thread_handle): New function.
7078 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7079 * target-delegates.c: Regenerate.
7080
7081 * linux-thread-db.c (class thread_db_target): Add method
7082 thread_info_to_thread_handle.
7083 (thread_db_target::thread_info_to_thread_handle): Define.
7084 * remote.c (class remote_target): Add new method
7085 thread_info_to_thread_handle.
7086 (remote_target::thread_info_to_thread_handle): Define.
7087
56be6ea8
PA		 70882019-04-08 Pedro Alves <palves@redhat.com>
7089
7090 * common/common-exceptions.c (throw_exception): Don't create
7091 named object to throw; throw directly.
7092 (throw_it): Likewise. Don't initialize gdb_exception::message
7093 here, with new; pass FMT and AP to the ctor instead.
7094 * common/common-exceptions.h: Include <string>.
7095 (gdb_exception::gdb_exception(enum return_reason, enum errors,
7096 const char *, va_list)): New ctor. Use std::make_shared.
7097 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7098 errors)): Delete.
7099 (gdb_exception_error::gdb_exception_error(enum errors, const char
7100 *, va_list)): New.
7101 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7102 Add assertion.
7103 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7104 errors)): Delete.
7105 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7106 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7107 Add assertion.
7108
eedc3f4f
TT		 71092019-04-08 Tom Tromey <tom@tromey.com>
7110
7111 * valops.c (value_rtti_indirect_type): Replace throw_exception
7112 with throw.
7113 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7114 with throw.
7115 * thread.c (thr_try_catch_cmd): Replace throw_exception with
7116 throw.
7117 * target.c (target_translate_tls_address): Replace throw_exception
7118 with throw.
7119 * stack.c (frame_apply_command_count): Replace throw_exception
7120 with throw.
7121 * solib-spu.c (append_ocl_sos): Replace throw_exception with
7122 throw.
7123 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7124 with throw.
7125 * rs6000-tdep.c (rs6000_frame_cache)
7126 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7127 * remote.c: Replace throw_exception with throw.
7128 * record-full.c (record_full_message, record_full_wait_1)
7129 (record_full_restore): Replace throw_exception with throw.
7130 * record-btrace.c:
7131 (get_thread_current_frame_id, record_btrace_start_replaying)
7132 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7133 (cmd_record_btrace_start): Replace throw_exception with throw.
7134 * parse.c (parse_exp_in_context_1): Replace throw_exception with
7135 throw.
7136 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7137 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7138 * linespec.c:
7139 (find_linespec_symbols): Replace throw_exception with throw.
7140 * infrun.c (displaced_step_prepare, resume): Replace
7141 throw_exception with throw.
7142 * infcmd.c (post_create_inferior): Replace throw_exception with
7143 throw.
7144 * inf-loop.c (inferior_event_handler): Replace throw_exception
7145 with throw.
7146 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7147 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7148 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7149 (get_prev_frame_always, get_frame_pc_if_available)
7150 (get_frame_address_in_block_if_available, get_frame_language):
7151 Replace throw_exception with throw.
7152 * frame-unwind.c (frame_unwind_try_unwinder): Replace
7153 throw_exception with throw.
7154 * eval.c (fetch_subexp_value, evaluate_var_value)
7155 (evaluate_funcall, evaluate_subexp_standard): Replace
7156 throw_exception with throw.
7157 * dwarf2loc.c (call_site_find_chain)
7158 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7159 Replace throw_exception with throw.
7160 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7161 with throw.
7162 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7163 throw.
7164 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7165 * completer.c (complete_line_internal): Replace throw_exception
7166 with throw.
7167 * compile/compile-object-run.c (compile_object_run): Replace
7168 throw_exception with throw.
7169 * cli/cli-script.c (process_next_line): Replace throw_exception
7170 with throw.
7171 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7172 (btrace_enable, btrace_maint_update_pt_packets): Replace
7173 throw_exception with throw.
7174 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7175 throw_exception with throw.
7176 * break-catch-throw.c (re_set_exception_catchpoint): Replace
7177 throw_exception with throw.
7178 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7179 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7180 * aarch64-tdep.c (aarch64_make_prologue_cache)
7181 (aarch64_make_stub_cache): Replace throw_exception with throw.
7182
26003a20
TT		 71832019-04-08 Tom Tromey <tom@tromey.com>
7184
7185 * common/common-exceptions.c (throw_exception): Rename from
7186 throw_exception_cxx. Remove old copy. Make argument const.
7187 (throw_it): Create and throw exception objects directly.
7188 * common/common-exceptions.h (throw_exception): Make argument
7189 const.
7190 (struct gdb_exception_error): Add constructor.
7191 (struct gdb_exception_quit): Add constructor.
7192
d272eb37
TT		 71932019-04-08 Tom Tromey <tom@tromey.com>
7194
7195 * common/common-exceptions.h (exception_rethrow): Don't declare.
7196 (TRY_SJLJ): Update comment.
7197 (TRY, CATCH, END_CATCH): Remove.
7198 * common/common-exceptions.c (exception_rethrow): Remove.
7199
230d2906
TT		 72002019-04-08 Tom Tromey <tom@tromey.com>
7201
7202 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7203 Remove.
7204 (gdb_exception_error): Rename from
7205 gdb_exception_RETURN_MASK_ERROR.
7206 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7207 (gdb_quit_bad_alloc): Update.
7208 * aarch64-tdep.c: Update.
7209 * ada-lang.c: Update.
7210 * ada-typeprint.c: Update.
7211 * ada-valprint.c: Update.
7212 * amd64-tdep.c: Update.
7213 * arch-utils.c: Update.
7214 * break-catch-throw.c: Update.
7215 * breakpoint.c: Update.
7216 * btrace.c: Update.
7217 * c-varobj.c: Update.
7218 * cli/cli-cmds.c: Update.
7219 * cli/cli-interp.c: Update.
7220 * cli/cli-script.c: Update.
7221 * common/common-exceptions.c: Update.
7222 * common/new-op.c: Update.
7223 * common/selftest.c: Update.
7224 * compile/compile-c-symbols.c: Update.
7225 * compile/compile-cplus-symbols.c: Update.
7226 * compile/compile-object-load.c: Update.
7227 * compile/compile-object-run.c: Update.
7228 * completer.c: Update.
7229 * corelow.c: Update.
7230 * cp-abi.c: Update.
7231 * cp-support.c: Update.
7232 * cp-valprint.c: Update.
7233 * darwin-nat.c: Update.
7234 * disasm-selftests.c: Update.
7235 * dtrace-probe.c: Update.
7236 * dwarf-index-cache.c: Update.
7237 * dwarf-index-write.c: Update.
7238 * dwarf2-frame-tailcall.c: Update.
7239 * dwarf2-frame.c: Update.
7240 * dwarf2loc.c: Update.
7241 * dwarf2read.c: Update.
7242 * eval.c: Update.
7243 * event-loop.c: Update.
7244 * event-top.c: Update.
7245 * exec.c: Update.
7246 * f-valprint.c: Update.
7247 * fbsd-tdep.c: Update.
7248 * frame-unwind.c: Update.
7249 * frame.c: Update.
7250 * gdbtypes.c: Update.
7251 * gnu-v3-abi.c: Update.
7252 * guile/guile-internal.h: Update.
7253 * guile/scm-block.c: Update.
7254 * guile/scm-breakpoint.c: Update.
7255 * guile/scm-cmd.c: Update.
7256 * guile/scm-disasm.c: Update.
7257 * guile/scm-frame.c: Update.
7258 * guile/scm-lazy-string.c: Update.
7259 * guile/scm-math.c: Update.
7260 * guile/scm-param.c: Update.
7261 * guile/scm-ports.c: Update.
7262 * guile/scm-pretty-print.c: Update.
7263 * guile/scm-symbol.c: Update.
7264 * guile/scm-symtab.c: Update.
7265 * guile/scm-type.c: Update.
7266 * guile/scm-value.c: Update.
7267 * i386-linux-tdep.c: Update.
7268 * i386-tdep.c: Update.
7269 * inf-loop.c: Update.
7270 * infcall.c: Update.
7271 * infcmd.c: Update.
7272 * infrun.c: Update.
7273 * jit.c: Update.
7274 * language.c: Update.
7275 * linespec.c: Update.
7276 * linux-fork.c: Update.
7277 * linux-nat.c: Update.
7278 * linux-tdep.c: Update.
7279 * linux-thread-db.c: Update.
7280 * main.c: Update.
7281 * mi/mi-cmd-break.c: Update.
7282 * mi/mi-cmd-stack.c: Update.
7283 * mi/mi-interp.c: Update.
7284 * mi/mi-main.c: Update.
7285 * objc-lang.c: Update.
7286 * p-valprint.c: Update.
7287 * parse.c: Update.
7288 * ppc-linux-tdep.c: Update.
7289 * printcmd.c: Update.
7290 * python/py-arch.c: Update.
7291 * python/py-breakpoint.c: Update.
7292 * python/py-cmd.c: Update.
7293 * python/py-finishbreakpoint.c: Update.
7294 * python/py-frame.c: Update.
7295 * python/py-framefilter.c: Update.
7296 * python/py-gdb-readline.c: Update.
7297 * python/py-inferior.c: Update.
7298 * python/py-infthread.c: Update.
7299 * python/py-lazy-string.c: Update.
7300 * python/py-linetable.c: Update.
7301 * python/py-objfile.c: Update.
7302 * python/py-param.c: Update.
7303 * python/py-prettyprint.c: Update.
7304 * python/py-progspace.c: Update.
7305 * python/py-record-btrace.c: Update.
7306 * python/py-record.c: Update.
7307 * python/py-symbol.c: Update.
7308 * python/py-type.c: Update.
7309 * python/py-unwind.c: Update.
7310 * python/py-utils.c: Update.
7311 * python/py-value.c: Update.
7312 * python/python.c: Update.
7313 * record-btrace.c: Update.
7314 * record-full.c: Update.
7315 * remote-fileio.c: Update.
7316 * remote.c: Update.
7317 * riscv-tdep.c: Update.
7318 * rs6000-aix-tdep.c: Update.
7319 * rs6000-tdep.c: Update.
7320 * rust-exp.y: Update.
7321 * rust-lang.c: Update.
7322 * s390-tdep.c: Update.
7323 * selftest-arch.c: Update.
7324 * solib-dsbt.c: Update.
7325 * solib-frv.c: Update.
7326 * solib-spu.c: Update.
7327 * solib-svr4.c: Update.
7328 * solib.c: Update.
7329 * sparc64-linux-tdep.c: Update.
7330 * stack.c: Update.
7331 * symfile-mem.c: Update.
7332 * symmisc.c: Update.
7333 * target.c: Update.
7334 * thread.c: Update.
7335 * top.c: Update.
7336 * tracefile-tfile.c: Update.
7337 * tui/tui.c: Update.
7338 * typeprint.c: Update.
7339 * unittests/cli-utils-selftests.c: Update.
7340 * unittests/parse-connection-spec-selftests.c: Update.
7341 * valops.c: Update.
7342 * valprint.c: Update.
7343 * value.c: Update.
7344 * varobj.c: Update.
7345 * windows-nat.c: Update.
7346 * x86-linux-nat.c: Update.
7347 * xml-support.c: Update.
7348
a70b8144
TT		 73492019-04-08 Tom Tromey <tom@tromey.com>
7350
7351 * xml-support.c: Use C++ exception handling.
7352 * x86-linux-nat.c: Use C++ exception handling.
7353 * windows-nat.c: Use C++ exception handling.
7354 * varobj.c: Use C++ exception handling.
7355 * value.c: Use C++ exception handling.
7356 * valprint.c: Use C++ exception handling.
7357 * valops.c: Use C++ exception handling.
7358 * unittests/parse-connection-spec-selftests.c: Use C++ exception
7359 handling.
7360 * unittests/cli-utils-selftests.c: Use C++ exception handling.
7361 * typeprint.c: Use C++ exception handling.
7362 * tui/tui.c: Use C++ exception handling.
7363 * tracefile-tfile.c: Use C++ exception handling.
7364 * top.c: Use C++ exception handling.
7365 * thread.c: Use C++ exception handling.
7366 * target.c: Use C++ exception handling.
7367 * symmisc.c: Use C++ exception handling.
7368 * symfile-mem.c: Use C++ exception handling.
7369 * stack.c: Use C++ exception handling.
7370 * sparc64-linux-tdep.c: Use C++ exception handling.
7371 * solib.c: Use C++ exception handling.
7372 * solib-svr4.c: Use C++ exception handling.
7373 * solib-spu.c: Use C++ exception handling.
7374 * solib-frv.c: Use C++ exception handling.
7375 * solib-dsbt.c: Use C++ exception handling.
7376 * selftest-arch.c: Use C++ exception handling.
7377 * s390-tdep.c: Use C++ exception handling.
7378 * rust-lang.c: Use C++ exception handling.
7379 * rust-exp.y: Use C++ exception handling.
7380 * rs6000-tdep.c: Use C++ exception handling.
7381 * rs6000-aix-tdep.c: Use C++ exception handling.
7382 * riscv-tdep.c: Use C++ exception handling.
7383 * remote.c: Use C++ exception handling.
7384 * remote-fileio.c: Use C++ exception handling.
7385 * record-full.c: Use C++ exception handling.
7386 * record-btrace.c: Use C++ exception handling.
7387 * python/python.c: Use C++ exception handling.
7388 * python/py-value.c: Use C++ exception handling.
7389 * python/py-utils.c: Use C++ exception handling.
7390 * python/py-unwind.c: Use C++ exception handling.
7391 * python/py-type.c: Use C++ exception handling.
7392 * python/py-symbol.c: Use C++ exception handling.
7393 * python/py-record.c: Use C++ exception handling.
7394 * python/py-record-btrace.c: Use C++ exception handling.
7395 * python/py-progspace.c: Use C++ exception handling.
7396 * python/py-prettyprint.c: Use C++ exception handling.
7397 * python/py-param.c: Use C++ exception handling.
7398 * python/py-objfile.c: Use C++ exception handling.
7399 * python/py-linetable.c: Use C++ exception handling.
7400 * python/py-lazy-string.c: Use C++ exception handling.
7401 * python/py-infthread.c: Use C++ exception handling.
7402 * python/py-inferior.c: Use C++ exception handling.
7403 * python/py-gdb-readline.c: Use C++ exception handling.
7404 * python/py-framefilter.c: Use C++ exception handling.
7405 * python/py-frame.c: Use C++ exception handling.
7406 * python/py-finishbreakpoint.c: Use C++ exception handling.
7407 * python/py-cmd.c: Use C++ exception handling.
7408 * python/py-breakpoint.c: Use C++ exception handling.
7409 * python/py-arch.c: Use C++ exception handling.
7410 * printcmd.c: Use C++ exception handling.
7411 * ppc-linux-tdep.c: Use C++ exception handling.
7412 * parse.c: Use C++ exception handling.
7413 * p-valprint.c: Use C++ exception handling.
7414 * objc-lang.c: Use C++ exception handling.
7415 * mi/mi-main.c: Use C++ exception handling.
7416 * mi/mi-interp.c: Use C++ exception handling.
7417 * mi/mi-cmd-stack.c: Use C++ exception handling.
7418 * mi/mi-cmd-break.c: Use C++ exception handling.
7419 * main.c: Use C++ exception handling.
7420 * linux-thread-db.c: Use C++ exception handling.
7421 * linux-tdep.c: Use C++ exception handling.
7422 * linux-nat.c: Use C++ exception handling.
7423 * linux-fork.c: Use C++ exception handling.
7424 * linespec.c: Use C++ exception handling.
7425 * language.c: Use C++ exception handling.
7426 * jit.c: Use C++ exception handling.
7427 * infrun.c: Use C++ exception handling.
7428 * infcmd.c: Use C++ exception handling.
7429 * infcall.c: Use C++ exception handling.
7430 * inf-loop.c: Use C++ exception handling.
7431 * i386-tdep.c: Use C++ exception handling.
7432 * i386-linux-tdep.c: Use C++ exception handling.
7433 * guile/scm-value.c: Use C++ exception handling.
7434 * guile/scm-type.c: Use C++ exception handling.
7435 * guile/scm-symtab.c: Use C++ exception handling.
7436 * guile/scm-symbol.c: Use C++ exception handling.
7437 * guile/scm-pretty-print.c: Use C++ exception handling.
7438 * guile/scm-ports.c: Use C++ exception handling.
7439 * guile/scm-param.c: Use C++ exception handling.
7440 * guile/scm-math.c: Use C++ exception handling.
7441 * guile/scm-lazy-string.c: Use C++ exception handling.
7442 * guile/scm-frame.c: Use C++ exception handling.
7443 * guile/scm-disasm.c: Use C++ exception handling.
7444 * guile/scm-cmd.c: Use C++ exception handling.
7445 * guile/scm-breakpoint.c: Use C++ exception handling.
7446 * guile/scm-block.c: Use C++ exception handling.
7447 * guile/guile-internal.h: Use C++ exception handling.
7448 * gnu-v3-abi.c: Use C++ exception handling.
7449 * gdbtypes.c: Use C++ exception handling.
7450 * frame.c: Use C++ exception handling.
7451 * frame-unwind.c: Use C++ exception handling.
7452 * fbsd-tdep.c: Use C++ exception handling.
7453 * f-valprint.c: Use C++ exception handling.
7454 * exec.c: Use C++ exception handling.
7455 * event-top.c: Use C++ exception handling.
7456 * event-loop.c: Use C++ exception handling.
7457 * eval.c: Use C++ exception handling.
7458 * dwarf2read.c: Use C++ exception handling.
7459 * dwarf2loc.c: Use C++ exception handling.
7460 * dwarf2-frame.c: Use C++ exception handling.
7461 * dwarf2-frame-tailcall.c: Use C++ exception handling.
7462 * dwarf-index-write.c: Use C++ exception handling.
7463 * dwarf-index-cache.c: Use C++ exception handling.
7464 * dtrace-probe.c: Use C++ exception handling.
7465 * disasm-selftests.c: Use C++ exception handling.
7466 * darwin-nat.c: Use C++ exception handling.
7467 * cp-valprint.c: Use C++ exception handling.
7468 * cp-support.c: Use C++ exception handling.
7469 * cp-abi.c: Use C++ exception handling.
7470 * corelow.c: Use C++ exception handling.
7471 * completer.c: Use C++ exception handling.
7472 * compile/compile-object-run.c: Use C++ exception handling.
7473 * compile/compile-object-load.c: Use C++ exception handling.
7474 * compile/compile-cplus-symbols.c: Use C++ exception handling.
7475 * compile/compile-c-symbols.c: Use C++ exception handling.
7476 * common/selftest.c: Use C++ exception handling.
7477 * common/new-op.c: Use C++ exception handling.
7478 * cli/cli-script.c: Use C++ exception handling.
7479 * cli/cli-interp.c: Use C++ exception handling.
7480 * cli/cli-cmds.c: Use C++ exception handling.
7481 * c-varobj.c: Use C++ exception handling.
7482 * btrace.c: Use C++ exception handling.
7483 * breakpoint.c: Use C++ exception handling.
7484 * break-catch-throw.c: Use C++ exception handling.
7485 * arch-utils.c: Use C++ exception handling.
7486 * amd64-tdep.c: Use C++ exception handling.
7487 * ada-valprint.c: Use C++ exception handling.
7488 * ada-typeprint.c: Use C++ exception handling.
7489 * ada-lang.c: Use C++ exception handling.
7490 * aarch64-tdep.c: Use C++ exception handling.
7491
3d6e9d23
TT		 74922019-04-08 Tom Tromey <tom@tromey.com>
7493
7494 * xml-support.c (gdb_xml_parser::parse): Update.
7495 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7496 * value.c (show_convenience): Update.
7497 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7498 (test_parse_flags_qcs): Update.
7499 * thread.c (thr_try_catch_cmd): Update.
7500 * target.c (target_translate_tls_address): Update.
7501 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7502 (info_frame_command_core, frame_apply_command_count): Update.
7503 * rust-exp.y (rust_lex_exception_test): Update.
7504 * riscv-tdep.c (riscv_print_one_register_info): Update.
7505 * remote.c (remote_target::enable_btrace): Update.
7506 * record-btrace.c (record_btrace_enable_warn): Update.
7507 * python/py-utils.c (gdbpy_convert_exception): Update.
7508 * printcmd.c (do_one_display, print_variable_and_value): Update.
7509 * mi/mi-main.c (mi_print_exception): Update.
7510 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7511 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7512 * linux-nat.c (linux_nat_target::attach): Update.
7513 * linux-fork.c (class scoped_switch_fork_info): Update.
7514 * infrun.c (displaced_step_prepare): Update.
7515 * infcall.c (call_function_by_hand_dummy): Update.
7516 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7517 * gnu-v3-abi.c (print_one_vtable): Update.
7518 * frame.c (get_prev_frame_always): Update.
7519 * f-valprint.c (info_common_command_for_block): Update.
7520 * exec.c (try_open_exec_file): Update.
7521 * exceptions.c (print_exception, exception_print)
7522 (exception_fprintf, exception_print_same): Update.
7523 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7524 * dwarf-index-cache.c (index_cache::store)
7525 (index_cache::lookup_gdb_index): Update.
7526 * darwin-nat.c (maybe_cache_shell): Update.
7527 * cp-valprint.c (cp_print_value_fields): Update.
7528 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7529 (gcc_cplus_symbol_address): Update.
7530 * compile/compile-c-symbols.c (gcc_convert_symbol)
7531 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7532 * common/selftest.c: Update.
7533 * common/common-exceptions.h (struct gdb_exception) <message>: Now
7534 a std::string.
7535 (exception_try_scope_entry, exception_try_scope_exit): Don't
7536 declare.
7537 (struct exception_try_scope): Remove.
7538 (TRY): Don't use exception_try_scope.
7539 (struct gdb_exception): Add constructor, operator=.
7540 <what>: New method.
7541 (struct gdb_exception_RETURN_MASK_ALL)
7542 (struct gdb_exception_RETURN_MASK_ERROR)
7543 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7544 (struct gdb_quit_bad_alloc): Update.
7545 * common/common-exceptions.c (exception_none): Change
7546 initializer.
7547 (struct catcher) <state, exception>: Initialize inline.
7548 <prev>: Remove member.
7549 (current_catcher): Remove.
7550 (catchers): New global.
7551 (exceptions_state_mc_init): Simplify.
7552 (catcher_pop): Remove.
7553 (exceptions_state_mc, exceptions_state_mc_catch): Update.
7554 (try_scope_depth, exception_try_scope_entry)
7555 (exception_try_scope_exit): Remove.
7556 (throw_exception_sjlj): Update.
7557 (exception_messages, exception_messages_size): Remove.
7558 (throw_it): Simplify.
7559 (gdb_exception_sliced_copy): Remove.
7560 (throw_exception_cxx): Update.
7561 * cli/cli-script.c (script_from_file): Update.
7562 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7563 Update.
7564 * ada-valprint.c (ada_val_print): Update.
7565 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7566 (create_excep_cond_exprs): Update.
7567
c5c10118
TT		 75682019-04-08 Tom Tromey <tom@tromey.com>
7569
7570 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7571 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7572 (TRY, CATCH, END_CATCH): Remove some definitions.
7573 * common/common-exceptions.c: Don't use GDB_XCPT.
7574 (catcher_list_size): Remove.
7575 (throw_exception, throw_it): Simplify.
7576
4de283e4
TT		 75772019-04-05 Tom Tromey <tom@tromey.com>
7578
7579 Revert the header-sorting patch.
7580 * ft32-tdep.c: Revert.
7581 * frv-tdep.c: Revert.
7582 * frv-linux-tdep.c: Revert.
7583 * frame.c: Revert.
7584 * frame-unwind.c: Revert.
7585 * frame-base.c: Revert.
7586 * fork-child.c: Revert.
7587 * findvar.c: Revert.
7588 * findcmd.c: Revert.
7589 * filesystem.c: Revert.
7590 * filename-seen-cache.h: Revert.
7591 * filename-seen-cache.c: Revert.
7592 * fbsd-tdep.c: Revert.
7593 * fbsd-nat.h: Revert.
7594 * fbsd-nat.c: Revert.
7595 * f-valprint.c: Revert.
7596 * f-typeprint.c: Revert.
7597 * f-lang.c: Revert.
7598 * extension.h: Revert.
7599 * extension.c: Revert.
7600 * extension-priv.h: Revert.
7601 * expprint.c: Revert.
7602 * exec.h: Revert.
7603 * exec.c: Revert.
7604 * exceptions.c: Revert.
7605 * event-top.c: Revert.
7606 * event-loop.c: Revert.
7607 * eval.c: Revert.
7608 * elfread.c: Revert.
7609 * dwarf2read.h: Revert.
7610 * dwarf2read.c: Revert.
7611 * dwarf2loc.c: Revert.
7612 * dwarf2expr.h: Revert.
7613 * dwarf2expr.c: Revert.
7614 * dwarf2-frame.c: Revert.
7615 * dwarf2-frame-tailcall.c: Revert.
7616 * dwarf-index-write.h: Revert.
7617 * dwarf-index-write.c: Revert.
7618 * dwarf-index-common.c: Revert.
7619 * dwarf-index-cache.h: Revert.
7620 * dwarf-index-cache.c: Revert.
7621 * dummy-frame.c: Revert.
7622 * dtrace-probe.c: Revert.
7623 * disasm.h: Revert.
7624 * disasm.c: Revert.
7625 * disasm-selftests.c: Revert.
7626 * dictionary.c: Revert.
7627 * dicos-tdep.c: Revert.
7628 * demangle.c: Revert.
7629 * dcache.h: Revert.
7630 * dcache.c: Revert.
7631 * darwin-nat.h: Revert.
7632 * darwin-nat.c: Revert.
7633 * darwin-nat-info.c: Revert.
7634 * d-valprint.c: Revert.
7635 * d-namespace.c: Revert.
7636 * d-lang.c: Revert.
7637 * ctf.c: Revert.
7638 * csky-tdep.c: Revert.
7639 * csky-linux-tdep.c: Revert.
7640 * cris-tdep.c: Revert.
7641 * cris-linux-tdep.c: Revert.
7642 * cp-valprint.c: Revert.
7643 * cp-support.c: Revert.
7644 * cp-namespace.c: Revert.
7645 * cp-abi.c: Revert.
7646 * corelow.c: Revert.
7647 * corefile.c: Revert.
7648 * continuations.c: Revert.
7649 * completer.h: Revert.
7650 * completer.c: Revert.
7651 * complaints.c: Revert.
7652 * coffread.c: Revert.
7653 * coff-pe-read.c: Revert.
7654 * cli-out.h: Revert.
7655 * cli-out.c: Revert.
7656 * charset.c: Revert.
7657 * c-varobj.c: Revert.
7658 * c-valprint.c: Revert.
7659 * c-typeprint.c: Revert.
7660 * c-lang.c: Revert.
7661 * buildsym.c: Revert.
7662 * buildsym-legacy.c: Revert.
7663 * build-id.h: Revert.
7664 * build-id.c: Revert.
7665 * btrace.c: Revert.
7666 * bsd-uthread.c: Revert.
7667 * breakpoint.h: Revert.
7668 * breakpoint.c: Revert.
7669 * break-catch-throw.c: Revert.
7670 * break-catch-syscall.c: Revert.
7671 * break-catch-sig.c: Revert.
7672 * blockframe.c: Revert.
7673 * block.c: Revert.
7674 * bfin-tdep.c: Revert.
7675 * bfin-linux-tdep.c: Revert.
7676 * bfd-target.c: Revert.
7677 * bcache.c: Revert.
7678 * ax-general.c: Revert.
7679 * ax-gdb.h: Revert.
7680 * ax-gdb.c: Revert.
7681 * avr-tdep.c: Revert.
7682 * auxv.c: Revert.
7683 * auto-load.c: Revert.
7684 * arm-wince-tdep.c: Revert.
7685 * arm-tdep.c: Revert.
7686 * arm-symbian-tdep.c: Revert.
7687 * arm-pikeos-tdep.c: Revert.
7688 * arm-obsd-tdep.c: Revert.
7689 * arm-nbsd-tdep.c: Revert.
7690 * arm-nbsd-nat.c: Revert.
7691 * arm-linux-tdep.c: Revert.
7692 * arm-linux-nat.c: Revert.
7693 * arm-fbsd-tdep.c: Revert.
7694 * arm-fbsd-nat.c: Revert.
7695 * arm-bsd-tdep.c: Revert.
7696 * arch-utils.c: Revert.
7697 * arc-tdep.c: Revert.
7698 * arc-newlib-tdep.c: Revert.
7699 * annotate.h: Revert.
7700 * annotate.c: Revert.
7701 * amd64-windows-tdep.c: Revert.
7702 * amd64-windows-nat.c: Revert.
7703 * amd64-tdep.c: Revert.
7704 * amd64-sol2-tdep.c: Revert.
7705 * amd64-obsd-tdep.c: Revert.
7706 * amd64-obsd-nat.c: Revert.
7707 * amd64-nbsd-tdep.c: Revert.
7708 * amd64-nbsd-nat.c: Revert.
7709 * amd64-nat.c: Revert.
7710 * amd64-linux-tdep.c: Revert.
7711 * amd64-linux-nat.c: Revert.
7712 * amd64-fbsd-tdep.c: Revert.
7713 * amd64-fbsd-nat.c: Revert.
7714 * amd64-dicos-tdep.c: Revert.
7715 * amd64-darwin-tdep.c: Revert.
7716 * amd64-bsd-nat.c: Revert.
7717 * alpha-tdep.c: Revert.
7718 * alpha-obsd-tdep.c: Revert.
7719 * alpha-nbsd-tdep.c: Revert.
7720 * alpha-mdebug-tdep.c: Revert.
7721 * alpha-linux-tdep.c: Revert.
7722 * alpha-linux-nat.c: Revert.
7723 * alpha-bsd-tdep.c: Revert.
7724 * alpha-bsd-nat.c: Revert.
7725 * aix-thread.c: Revert.
7726 * agent.c: Revert.
7727 * addrmap.c: Revert.
7728 * ada-varobj.c: Revert.
7729 * ada-valprint.c: Revert.
7730 * ada-typeprint.c: Revert.
7731 * ada-tasks.c: Revert.
7732 * ada-lang.c: Revert.
7733 * aarch64-tdep.c: Revert.
7734 * aarch64-ravenscar-thread.c: Revert.
7735 * aarch64-newlib-tdep.c: Revert.
7736 * aarch64-linux-tdep.c: Revert.
7737 * aarch64-linux-nat.c: Revert.
7738 * aarch64-fbsd-tdep.c: Revert.
7739 * aarch64-fbsd-nat.c: Revert.
7740 * aarch32-linux-nat.c: Revert.
7741
d55e5aa6
TT		 77422019-04-05 Tom Tromey <tom@tromey.com>
7743
7744 * ft32-tdep.c: Sort headers.
7745 * frv-tdep.c: Sort headers.
7746 * frv-linux-tdep.c: Sort headers.
7747 * frame.c: Sort headers.
7748 * frame-unwind.c: Sort headers.
7749 * frame-base.c: Sort headers.
7750 * fork-child.c: Sort headers.
7751 * findvar.c: Sort headers.
7752 * findcmd.c: Sort headers.
7753 * filesystem.c: Sort headers.
7754 * filename-seen-cache.h: Sort headers.
7755 * filename-seen-cache.c: Sort headers.
7756 * fbsd-tdep.c: Sort headers.
7757 * fbsd-nat.h: Sort headers.
7758 * fbsd-nat.c: Sort headers.
7759 * f-valprint.c: Sort headers.
7760 * f-typeprint.c: Sort headers.
7761 * f-lang.c: Sort headers.
7762 * extension.h: Sort headers.
7763 * extension.c: Sort headers.
7764 * extension-priv.h: Sort headers.
7765 * expprint.c: Sort headers.
7766 * exec.h: Sort headers.
7767 * exec.c: Sort headers.
7768 * exceptions.c: Sort headers.
7769 * event-top.c: Sort headers.
7770 * event-loop.c: Sort headers.
7771 * eval.c: Sort headers.
7772 * elfread.c: Sort headers.
7773 * dwarf2read.h: Sort headers.
7774 * dwarf2read.c: Sort headers.
7775 * dwarf2loc.c: Sort headers.
7776 * dwarf2expr.h: Sort headers.
7777 * dwarf2expr.c: Sort headers.
7778 * dwarf2-frame.c: Sort headers.
7779 * dwarf2-frame-tailcall.c: Sort headers.
7780 * dwarf-index-write.h: Sort headers.
7781 * dwarf-index-write.c: Sort headers.
7782 * dwarf-index-common.c: Sort headers.
7783 * dwarf-index-cache.h: Sort headers.
7784 * dwarf-index-cache.c: Sort headers.
7785 * dummy-frame.c: Sort headers.
7786 * dtrace-probe.c: Sort headers.
7787 * disasm.h: Sort headers.
7788 * disasm.c: Sort headers.
7789 * disasm-selftests.c: Sort headers.
7790 * dictionary.c: Sort headers.
7791 * dicos-tdep.c: Sort headers.
7792 * demangle.c: Sort headers.
7793 * dcache.h: Sort headers.
7794 * dcache.c: Sort headers.
7795 * darwin-nat.h: Sort headers.
7796 * darwin-nat.c: Sort headers.
7797 * darwin-nat-info.c: Sort headers.
7798 * d-valprint.c: Sort headers.
7799 * d-namespace.c: Sort headers.
7800 * d-lang.c: Sort headers.
7801 * ctf.c: Sort headers.
7802 * csky-tdep.c: Sort headers.
7803 * csky-linux-tdep.c: Sort headers.
7804 * cris-tdep.c: Sort headers.
7805 * cris-linux-tdep.c: Sort headers.
7806 * cp-valprint.c: Sort headers.
7807 * cp-support.c: Sort headers.
7808 * cp-namespace.c: Sort headers.
7809 * cp-abi.c: Sort headers.
7810 * corelow.c: Sort headers.
7811 * corefile.c: Sort headers.
7812 * continuations.c: Sort headers.
7813 * completer.h: Sort headers.
7814 * completer.c: Sort headers.
7815 * complaints.c: Sort headers.
7816 * coffread.c: Sort headers.
7817 * coff-pe-read.c: Sort headers.
7818 * cli-out.h: Sort headers.
7819 * cli-out.c: Sort headers.
7820 * charset.c: Sort headers.
7821 * c-varobj.c: Sort headers.
7822 * c-valprint.c: Sort headers.
7823 * c-typeprint.c: Sort headers.
7824 * c-lang.c: Sort headers.
7825 * buildsym.c: Sort headers.
7826 * buildsym-legacy.c: Sort headers.
7827 * build-id.h: Sort headers.
7828 * build-id.c: Sort headers.
7829 * btrace.c: Sort headers.
7830 * bsd-uthread.c: Sort headers.
7831 * breakpoint.h: Sort headers.
7832 * breakpoint.c: Sort headers.
7833 * break-catch-throw.c: Sort headers.
7834 * break-catch-syscall.c: Sort headers.
7835 * break-catch-sig.c: Sort headers.
7836 * blockframe.c: Sort headers.
7837 * block.c: Sort headers.
7838 * bfin-tdep.c: Sort headers.
7839 * bfin-linux-tdep.c: Sort headers.
7840 * bfd-target.c: Sort headers.
7841 * bcache.c: Sort headers.
7842 * ax-general.c: Sort headers.
7843 * ax-gdb.h: Sort headers.
7844 * ax-gdb.c: Sort headers.
7845 * avr-tdep.c: Sort headers.
7846 * auxv.c: Sort headers.
7847 * auto-load.c: Sort headers.
7848 * arm-wince-tdep.c: Sort headers.
7849 * arm-tdep.c: Sort headers.
7850 * arm-symbian-tdep.c: Sort headers.
7851 * arm-pikeos-tdep.c: Sort headers.
7852 * arm-obsd-tdep.c: Sort headers.
7853 * arm-nbsd-tdep.c: Sort headers.
7854 * arm-nbsd-nat.c: Sort headers.
7855 * arm-linux-tdep.c: Sort headers.
7856 * arm-linux-nat.c: Sort headers.
7857 * arm-fbsd-tdep.c: Sort headers.
7858 * arm-fbsd-nat.c: Sort headers.
7859 * arm-bsd-tdep.c: Sort headers.
7860 * arch-utils.c: Sort headers.
7861 * arc-tdep.c: Sort headers.
7862 * arc-newlib-tdep.c: Sort headers.
7863 * annotate.h: Sort headers.
7864 * annotate.c: Sort headers.
7865 * amd64-windows-tdep.c: Sort headers.
7866 * amd64-windows-nat.c: Sort headers.
7867 * amd64-tdep.c: Sort headers.
7868 * amd64-sol2-tdep.c: Sort headers.
7869 * amd64-obsd-tdep.c: Sort headers.
7870 * amd64-obsd-nat.c: Sort headers.
7871 * amd64-nbsd-tdep.c: Sort headers.
7872 * amd64-nbsd-nat.c: Sort headers.
7873 * amd64-nat.c: Sort headers.
7874 * amd64-linux-tdep.c: Sort headers.
7875 * amd64-linux-nat.c: Sort headers.
7876 * amd64-fbsd-tdep.c: Sort headers.
7877 * amd64-fbsd-nat.c: Sort headers.
7878 * amd64-dicos-tdep.c: Sort headers.
7879 * amd64-darwin-tdep.c: Sort headers.
7880 * amd64-bsd-nat.c: Sort headers.
7881 * alpha-tdep.c: Sort headers.
7882 * alpha-obsd-tdep.c: Sort headers.
7883 * alpha-nbsd-tdep.c: Sort headers.
7884 * alpha-mdebug-tdep.c: Sort headers.
7885 * alpha-linux-tdep.c: Sort headers.
7886 * alpha-linux-nat.c: Sort headers.
7887 * alpha-bsd-tdep.c: Sort headers.
7888 * alpha-bsd-nat.c: Sort headers.
7889 * aix-thread.c: Sort headers.
7890 * agent.c: Sort headers.
7891 * addrmap.c: Sort headers.
7892 * ada-varobj.c: Sort headers.
7893 * ada-valprint.c: Sort headers.
7894 * ada-typeprint.c: Sort headers.
7895 * ada-tasks.c: Sort headers.
7896 * ada-lang.c: Sort headers.
7897 * aarch64-tdep.c: Sort headers.
7898 * aarch64-ravenscar-thread.c: Sort headers.
7899 * aarch64-newlib-tdep.c: Sort headers.
7900 * aarch64-linux-tdep.c: Sort headers.
7901 * aarch64-linux-nat.c: Sort headers.
7902 * aarch64-fbsd-tdep.c: Sort headers.
7903 * aarch64-fbsd-nat.c: Sort headers.
7904 * aarch32-linux-nat.c: Sort headers.
7905
699bd4cf
TT		 79062019-04-04 Tom Tromey <tom@tromey.com>
7907
7908 * varobj.c (varobj_create): Update.
7909 * rust-exp.y (struct rust_parser) <update_innermost_block,
7910 lookup_symbol>: New methods.
7911 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7912 Rename.
7913 (rust_parser::rust_lookup_type)
7914 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7915 * printcmd.c (display_command, do_one_display): Update.
7916 * parser-defs.h (struct parser_state) <parser_state>: Add
7917 "tracker" parameter.
7918 (block_tracker): New member.
7919 (class innermost_block_tracker) <innermost_block_tracker>: Add
7920 "types" parameter.
7921 <reset>: Remove method.
7922 (innermost_block): Don't declare.
7923 (null_post_parser): Update.
7924 * parse.c (innermost_block): Remove global.
7925 (write_dollar_variable): Update.
7926 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7927 Remove "tracker_types" parameter.
7928 (parse_expression): Add "tracker" parameter.
7929 (parse_expression_for_completion): Update.
7930 (null_post_parser): Add "tracker" parameter.
7931 * p-exp.y: Update rules.
7932 * m2-exp.y: Update rules.
7933 * language.h (struct language_defn) <la_post_parser>: Add
7934 "tracker" parameter.
7935 * go-exp.y: Update rules.
7936 * f-exp.y: Update rules.
7937 * expression.h (parse_expression, parse_exp_1): Add "tracker"
7938 parameter.
7939 * d-exp.y: Update rules.
7940 * c-exp.y: Update rules.
7941 * breakpoint.c (set_breakpoint_condition): Create an
7942 innermost_block_tracker.
7943 (watch_command_1): Likewise.
7944 * ada-lang.c (resolve): Add "tracker" parameter.
7945 (resolve_subexp): Likewise.
7946 * ada-exp.y (write_var_from_sym): Update.
7947
dac43e32
TT		 79482019-04-04 Tom Tromey <tom@tromey.com>
7949
7950 * type-stack.h: New file.
7951 * type-stack.c: New file.
7952 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7953 type-stack.h.
7954 (insert_into_type_stack, insert_type, push_type, push_type_int)
7955 (insert_type_address_space, pop_type, pop_type_int)
7956 (pop_typelist, pop_type_stack, append_type_stack)
7957 (push_type_stack, get_type_stack, push_typelist)
7958 (follow_type_instance_flags, follow_types): Don't declare.
7959 * parse.c (type_stack): Remove global.
7960 (parse_exp_in_context): Update.
7961 (insert_into_type_stack, insert_type, push_type, push_type_int)
7962 (insert_type_address_space, pop_type, pop_type_int)
7963 (pop_typelist, pop_type_stack, append_type_stack)
7964 (push_type_stack, get_type_stack, push_typelist)
7965 (follow_type_instance_flags, follow_types): Remove (moved to
7966 type-stack.c).
7967 * f-exp.y (type_stack): New global.
7968 Update rules.
7969 (push_kind_type, f_parse): Update.
7970 * d-exp.y (type_stack): New global.
7971 Update rules.
7972 (d_parse): Update.
7973 * c-exp.y (struct c_parse_state) <type_stack>: New member.
7974 Update rules.
7975 * Makefile.in (COMMON_SFILES): Add type-stack.c.
7976 (HFILES_NO_SRCDIR): Add type-stack.h.
7977
2a612529
TT		 79782019-04-04 Tom Tromey <tom@tromey.com>
7979
7980 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7981 (rust_parser::convert_ast_to_expression, rust_parse)
7982 (rust_lex_test_completion, rust_lex_tests): Update.
7983 * parser-defs.h (struct expr_completion_state): New.
7984 (struct parser_state) <parser_state>: Add completion parameter.
7985 <mark_struct_expression, mark_completion_tag>: New methods.
7986 <parse_completion, m_completion_state>: New members.
7987 (prefixify_expression, null_post_parser): Update.
7988 (mark_struct_expression, mark_completion_tag): Don't declare.
7989 * parse.c (parse_completion, expout_last_struct)
7990 (expout_tag_completion_type, expout_completion_name): Remove
7991 globals.
7992 (parser_state::mark_struct_expression)
7993 (parser_state::mark_completion_tag): Now methods.
7994 (prefixify_expression): Add last_struct parameter.
7995 (prefixify_subexp): Likewise.
7996 (parse_exp_1): Update.
7997 (parse_exp_in_context): Add cstate parameter. Update.
7998 (parse_expression_for_completion): Create an
7999 expr_completion_state.
8000 (null_post_parser): Add "completion" parameter.
8001 * p-exp.y: Update rules.
8002 (yylex): Update.
8003 * language.h (struct language_defn) <la_post_parser>: Add
8004 "completing" parameter.
8005 * go-exp.y: Update rules.
8006 (lex_one_token): Update.
8007 * expression.h (parse_completion): Don't declare.
8008 * d-exp.y: Update rules.
8009 (lex_one_token): Update rules.
8010 * c-exp.y: Update rules.
8011 (lex_one_token): Update.
8012 * ada-lang.c (resolve): Add "parse_completion" parameter.
8013 (resolve_subexp): Likewise.
8014 (ada_resolve_function): Likewise.
8015
43476f0b
TT		 80162019-04-04 Tom Tromey <tom@tromey.com>
8017
8018 * parser-defs.h (struct parser_state) <start_arglist,
8019 end_arglist>: New methods.
8020 <arglist_len, m_funcall_chain>: New members.
8021 (arglist_len, start_arglist, end_arglist): Don't declare.
8022 * parse.c (arglist_len, funcall_chain): Remove global.
8023 (start_arglist, end_arglist): Remove functions.
8024 (parse_exp_in_context): Update.
8025 * p-exp.y: Update rules.
8026 * m2-exp.y: Update rules.
8027 * go-exp.y: Update rules.
8028 * f-exp.y: Update rules.
8029 * d-exp.y: Update rules.
8030 * c-exp.y: Update rules.
8031
5776fca3
TT		 80322019-04-04 Tom Tromey <tom@tromey.com>
8033
8034 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8035 lex_operator, push_back>: New methods.
8036 Update all rules.
8037 (rust_parser::lex_hex, lex_escape): Rename and update.
8038 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8039 (rust_parser::lex_operator): Rename and update.
8040 (rust_parser::lex_number, rustyylex, rustyyerror)
8041 (rust_lex_test_init, rust_lex_test_sequence)
8042 (rust_lex_test_push_back, rust_lex_tests): Update.
8043 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8044 parameter.
8045 <lexptr, prev_lexptr>: New members.
8046 (lexptr, prev_lexptr): Don't declare.
8047 * parse.c (lexptr, prev_lexptr): Remove globals.
8048 (parse_exp_in_context): Update.
8049 * p-exp.y (yylex, yyerror): Update.
8050 * m2-exp.y (parse_number, yylex, yyerror): Update.
8051 * go-exp.y (lex_one_token, yyerror): Update.
8052 * f-exp.y (match_string_literal, yylex, yyerror): Update.
8053 * d-exp.y (lex_one_token, yyerror): Update.
8054 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8055 (lex_one_token, yyerror): Update.
8056 * ada-lex.l (YY_INPUT): Update.
8057 (rewind_to_char): Update.
8058 * ada-exp.y (yyerror): Update.
8059
8621b685
TT		 80602019-04-04 Tom Tromey <tom@tromey.com>
8061
8062 * rust-exp.y (rustyylex, rust_lex_tests): Update.
8063 * parser-defs.h (struct parser_state) <parser_state>: Add new
8064 parameter.
8065 <comma_terminates>: New member.
8066 (comma_terminates): Don't declare global.
8067 * parse.c (comma_terminates): Remove global.
8068 (parse_exp_in_context): Update.
8069 * p-exp.y (yylex): Update.
8070 * m2-exp.y (yylex): Update.
8071 * go-exp.y (lex_one_token): Update.
8072 * f-exp.y (yylex): Update.
8073 * d-exp.y (lex_one_token): Update.
8074 * c-exp.y (lex_one_token): Update.
8075 * ada-lex.l: Update.
8076
28aaf3fd
TT		 80772019-04-04 Tom Tromey <tom@tromey.com>
8078
8079 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8080 (rustyylex, rust_lex_test_init, rust_lex_test_one)
8081 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8082 * parser-defs.h (paren_depth): Don't declare.
8083 * parse.c (paren_depth): Remove global.
8084 (parse_exp_in_context): Update.
8085 * p-exp.y (paren_depth): New global.
8086 (pascal_parse): Initialize it.
8087 * m2-exp.y (paren_depth): New global.
8088 (m2_parse): Initialize it.
8089 * go-exp.y (paren_depth): New global.
8090 (go_parse): Initialize it.
8091 * f-exp.y (paren_depth): New global.
8092 (f_parse): Initialize it.
8093 * d-exp.y (paren_depth): New global.
8094 (d_parse): Initialize it.
8095 * c-exp.y (paren_depth): New global.
8096 (c_parse): Initialize it.
8097 * ada-lex.l (paren_depth): New global.
8098 (lexer_init): Initialize it.
8099
1e58a4a4
TT		 81002019-04-04 Tom Tromey <tom@tromey.com>
8101
8102 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8103 (rust_parser::convert_ast_to_type)
8104 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8105 * parser-defs.h (struct parser_state) <parser_state>: Add
8106 parameters. Initialize new members.
8107 <expression_context_block, expression_context_pc>: New members.
8108 * parse.c (expression_context_block, expression_context_pc):
8109 Remove globals.
8110 (parse_exp_in_context): Update.
8111 * p-exp.y: Update all rules.
8112 (yylex): Update.
8113 * m2-exp.y: Update all rules.
8114 (yylex): Update.
8115 * go-exp.y (yylex): Update.
8116 * f-exp.y (yylex): Update.
8117 * d-exp.y: Update all rules.
8118 (yylex): Update.
8119 * c-exp.y: Update all rules.
8120 (lex_one_token, classify_name, yylex, c_parse): Update.
8121 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8122
37eedb39
TT		 81232019-04-04 Tom Tromey <tom@tromey.com>
8124
8125 * gdbarch.h, gdbarch.c: Rebuild.
8126 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8127 * stap-probe.h:
8128 (struct stap_parse_info): Replace "parser_state" with
8129 "expr_builder".
8130 * parser-defs.h (struct expr_builder): Rename from "parser_state".
8131 (parser_state): New class.
8132 * parse.c (expr_builder): Rename.
8133 (expr_builder::release): Rename.
8134 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8135 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8136 (write_exp_elt_longcst, write_exp_elt_floatcst)
8137 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8138 (write_exp_string_vector, write_exp_bitstring)
8139 (write_exp_msymbol, mark_struct_expression)
8140 (write_dollar_variable)
8141 (insert_type_address_space, increase_expout_size): Replace
8142 "parser_state" with "expr_builder".
8143 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8144 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8145 "parser_state" with "expr_builder".
8146
73923d7e
TT		 81472019-04-04 Tom Tromey <tom@tromey.com>
8148
8149 * rust-exp.y: Replace "parse_language" with method call.
8150 * p-exp.y:
8151 (yylex): Replace "parse_language" with method call.
8152 * m2-exp.y:
8153 (yylex): Replace "parse_language" with method call.
8154 * go-exp.y (classify_name): Replace "parse_language" with method
8155 call.
8156 * f-exp.y (yylex): Replace "parse_language" with method call.
8157 * d-exp.y (lex_one_token): Replace "parse_language" with method
8158 call.
8159 * c-exp.y:
8160 (lex_one_token, classify_name, yylex): Replace "parse_language"
8161 with method call.
8162 * ada-exp.y (find_primitive_type, type_char)
8163 (type_system_address): Replace "parse_language" with method call.
8164
fa9f5be6
TT		 81652019-04-04 Tom Tromey <tom@tromey.com>
8166
8167 * rust-exp.y: Replace "parse_gdbarch" with method call.
8168 * parse.c (write_dollar_variable, insert_type_address_space):
8169 Replace "parse_gdbarch" with method call.
8170 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8171 call.
8172 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8173 call.
8174 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8175 "parse_gdbarch" with method call.
8176 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8177 with method call.
8178 * f-exp.y (parse_type, parse_f_type, yylex): Replace
8179 "parse_gdbarch" with method call.
8180 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8181 "parse_gdbarch" with method call.
8182 * c-exp.y (parse_type, parse_number, classify_name): Replace
8183 "parse_gdbarch" with method call.
8184 * ada-lex.l: Replace "parse_gdbarch" with method call.
8185 * ada-exp.y (parse_type, find_primitive_type, type_char)
8186 (type_system_address): Replace "parse_gdbarch" with method call.
8187
1201a264
TT		 81882019-04-04 Tom Tromey <tom@tromey.com>
8189
8190 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8191 * stap-probe.c (stap_parse_argument): Update.
8192 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8193 initial_size parameter.
8194 * rust-exp.y (rust_lex_tests): Update.
8195 * parse.c (parser_state): Update.
8196 (parse_exp_in_context): Update.
8197 * parser-defs.h (struct parser_state) <parser_state>: Remove
8198 "initial_size" parameter.
8199
e3980ce2
TT		 82002019-04-04 Tom Tromey <tom@tromey.com>
8201
8202 * parser-defs.h (increase_expout_size): Don't declare.
8203 * parse.c (increase_expout_size): Now static.
8204
e9f8e3f1
TS		 82052019-04-04 Thomas Schwinge <thomas@codesourcery.com>
8206
8207 * gnu-nat.c (gnu_nat_target::wait): Fix
8208 target_waitstatus_to_string call.
8209
d7df6549
AB		 82102019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8211
8212 * eval.c (evaluate_subexp_standard): Handle internal functions
8213 during Fortran function call handling.
8214
8bdc1658
AB		 82152019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8216
8217 * NEWS: Mention new internal functions.
8218 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8219 (read_base_type): Use dwarf2_init_complex_target_type.
8220 * value.c (creal_internal_fn): New function.
8221 (cimag_internal_fn): New function.
8222 (_initialize_values): Register new internal functions.
8223
c29705b7
PW		 82242019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8225
8226 * infrun.c (stop_all_threads): If debug_infrun, always
8227 trace the wait status after wait_one, using
8228 target_waitstatus_to_string and target_pid_to_str.
8229 (handle_inferior_event): Replace various trace of
8230 wait status kind by a single trace.
8231 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8232 wait status kind image by target_waitstatus_to_string.
8233 * target/waitstatus.c (target_waitstatus_to_string): Fix
8234 obsolete comment.
8235
05caa1d2
TT		 82362019-04-01 Tom Tromey <tromey@adacore.com>
8237
8238 PR symtab/23331:
8239 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8240
9d1447e0
SDJ		 82412019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
8242 Pedro Alves <palves@redhat.com>
8243
8244 * top.c (quit_force): Call 'finalize_values'.
8245 * value.c (finalize_values): New function.
8246 * value.h (finalize_values): Declare.
8247
7734102d
EZ		 82482019-03-30 Eli Zaretskii <eliz@gnu.org>
8249
8250 * NEWS: Announce $_gdb_major and $_gdb_minor.
8251
8252 * top.c (init_gdb_version_vars): New function.
8253 (gdb_init): Call init_gdb_version_vars.
8254
188e1fa9
TT		 82552019-03-29 Tom Tromey <tromey@adacore.com>
8256
8257 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
8258 help text. Remove dead code.
8259
2880242d
KS		 82602019-03-29 Keith Seitz <keiths@redhat.com>
8261
8262 From Siddhesh Poyarekar:
8263 * f-lang.h (f77_get_upperbound): Return LONGEST.
8264 (f77_get_lowerbound): Likewise.
8265 * f-typeprint.c (f_type_print_varspec_suffix): Expand
8266 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
8267 print them.
8268 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
8269 plongest to format print it.
8270 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8271 (f77_get_upperbound): Likewise.
8272 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8273 LOWER_BOUND to LONGEST.
8274 (f77_create_arrayprint_offset_tbl): Likewise.
8275
cc1defb1
KS		 82762019-03-29 Keith Seitz <keiths@redhat.com>
8277
8278 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8279 %s/pulongest for TYPE_LENGTH instead of %d in format
8280 strings.
8281 * ada-typerint.c (ada_print_type): Likewise.
8282 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8283 * compile/compile-c-support.c (generate_register_struct): Likewise.
8284 * gdbtypes.c (recursive_dump_type): Likewise.
8285 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8286 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
8287 instead of %d in format strings.
8288 * riscv-tdep.c (riscv_type_alignment): Cast second argument
8289 to std::min to ULONGEST.
8290 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8291 instead of %d in format strings.
8292 * tracepoint.c (info_scope_command): Likewise.
8293 * typeprint.c (print_offset_data::update)
8294 (print_offset_data::finish): Likewise.
8295 * xtensa-tdep.c (xtensa_store_return_value)
8296 (xtensa_push_dummy_call): Likewise.
8297
e432ccf1
JT		 82982019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
8299
8300 * windows-nat.c (display_selector): Fixed format specifications
8301 for 64-bit Cygwin.
8302
65d2b333
PW		 83032019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8304
8305 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8306
f489207e
SL		 83072019-03-28 Sandra Loosemore <sandra@codesourcery.com>
8308
8309 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8310 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8311 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8312 (nios2_linux_init_abi): Install it.
8313
bffa1015
AH		 83142019-03-28 Alan Hayward <alan.hayward@arm.com>
8315
8316 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8317
fc96163a
AH		 83182019-03-28 Alan Hayward <alan.hayward@arm.com>
8319
8320 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8321
20dc7e9b
PW		 83222019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8323 Tom Tromey <tromey@adacore.com>
8324
8325 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8326
7f5331a8
JB		 83272019-03-26 Joel Brobecker <brobecker@adacore.com>
8328
8329 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8330 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8331 method to compute the bounds of range types. Also print "[evaluated]"
8332 if the bounds' values come from a dynamic evaluation.
8333
18c77628
AB		 83342019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
8335
8336 * cp-valprint.c (cp_print_value_fields): Don't print trailing
8337 whitespace when pretty printing is on.
8338
53c973f2
AH		 83392019-03-26 Alan Hayward <alan.hayward@arm.com>
8340
e79be6e5 8341 * ppc-linux-nat.c: Add include.
53c973f2 8342
d851aa71
AH		 83432019-03-26 Alan Hayward <alan.hayward@arm.com>
8344
e79be6e5 8345 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 8346
2fe7bab7
AH		 83472019-03-26 Alan Hayward <alan.hayward@arm.com>
8348
e79be6e5 8349 * arm-linux-nat.c: Add include.
2fe7bab7 8350
068ef30e
SM		 83512019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
8352
8353 * source-cache.c (source_cache::get_source_lines): Re-read
8354 fullname after calling open_source_file.
8355
81a24d04
JB		 83562019-03-25 John Baldwin <jhb@FreeBSD.org>
8357
8358 * NEWS: Mention TLS support for FreeBSD.
8359
79e7ae11
TT		 83602019-03-25 Tom Tromey <tromey@adacore.com>
8361
8362 * minsyms.c (BUNCH_SIZE): Update comment.
8363 (~minimal_symbol_reader): Remove old comment.
8364 (compact_minimal_symbols): Update comment.
8365 (minimal_symbol_reader::install): Remove old comment. Update
8366 other comments.
8367
d45963c2
AH		 83682019-03-25 Alan Hayward <alan.hayward@arm.com>
8369
8370 * s390-linux-nat.c: Add include.
8371
0f83012e
AH		 83722019-03-25 Alan Hayward <alan.hayward@arm.com>
8373
8374 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8375 Call linux_get_hwcap.
8376 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8377 Likewise.
8378 (aarch64_linux_get_hwcap): Remove function.
8379 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8380 declaration.
8381 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8382 linux_get_hwcap.
8383 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8384 * linux-tdep.c (linux_get_hwcap): Add function.
8385 (linux_get_hwcap2): Likewise.
8386 * linux-tdep.h (linux_get_hwcap): Add declaration.
8387 (linux_get_hwcap2): Likewise.
8388 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8389 (ppc_linux_get_hwcap2): Likewise.
8390 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8391 linux_get_hwcap.
8392 (ppc_linux_nat_target::insert_watchpoint): Likewise.
8393 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8394 (ppc_linux_nat_target::read_description): Likewise.
8395 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8396 * s390-linux-nat.c: Likewise.
8397 * s390-linux-tdep.c (s390_core_read_description): Likewise.
8398
6640a367
TT		 83992019-03-24 Tom Tromey <tom@tromey.com>
8400
8401 * ada-lang.c (standard_lookup): Simplify initialization.
8402 (ada_lookup_symbol_nonlocal): Simplify return.
8403 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8404 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8405 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8406 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8407 initialization.
8408 * solib.c (solib_global_lookup): Simplify.
8409 * symtab.c (null_block_symbol): Remove.
8410 (symbol_cache_lookup): Simplify returns.
8411 (lookup_language_this): Simplify returns.
8412 (lookup_symbol_aux): Simplify return.
8413 (lookup_local_symbol): Simplify returns.
8414 (lookup_global_symbol_from_objfile): Simplify return.
8415 (lookup_symbol_in_objfile_symtabs)
8416 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8417 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8418 (lookup_static_symbol, lookup_global_symbol): Simplify return.
8419 * cp-namespace.c (cp_lookup_bare_symbol)
8420 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8421 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8422 (cp_lookup_nested_symbol): Don't use null_block_symbol.
8423 (cp_lookup_symbol_via_imports): Simplify initialization.
8424 (find_symbol_in_baseclass): Likewise.
8425 * symtab.h (null_block_symbol): Remove.
8426 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8427 (d_lookup_nested_symbol, d_lookup_symbol_imports)
8428 (d_lookup_symbol_module): Likewise.
8429 (find_symbol_in_baseclass): Simplify initialization.
8430
a930ebcd
TT		 84312019-03-24 Tom Tromey <tom@tromey.com>
8432
8433 * expression.h: Don't include symtab.h.
8434 (struct block): Forward declare.
8435
582942f4
TT		 84362019-03-24 Tom Tromey <tom@tromey.com>
8437
8438 * c-exp.y (typebase): Remove casts.
8439 * gdbtypes.c (lookup_unsigned_typename, )
8440 (lookup_signed_typename): Remove cast.
8441 * eval.c (parse_to_comma_and_eval): Remove cast.
8442 * parse.c (write_dollar_variable): Remove cast.
8443 * block.h (struct block) <superblock>: Now const.
8444 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8445 * psymtab.c (psym_map_matching_symbols): Make "block" const.
8446 (map_block): Make "block" const.
8447 * symfile.h (struct quick_symbol_functions)
8448 <map_matching_symbols>: Constify block argument to "callback".
8449 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8450 const.
8451 (find_pc_sect_compunit_symtab): Make "b" const.
8452 (find_symbol_at_address): Likewise.
8453 (search_symbols): Likewise.
8454 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8455 (dw2_debug_names_lookup_symbol): Likewise.
8456 (dw2_map_matching_symbols): Update.
8457 * p-valprint.c (pascal_val_print): Remove "block".
8458 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8459 (aux_add_nonlocal_symbols): Make "block" const.
8460 (resolve_subexp): Remove cast.
8461 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8462 const.
8463 (iterate_over_file_blocks): Likewise.
8464 * f-exp.y (%union) <bval>: Remove.
8465 * coffread.c (patch_opaque_types): Make "b" const.
8466 * spu-tdep.c (spu_catch_start): Make "block" const.
8467 * c-valprint.c (print_unpacked_pointer): Remove "block".
8468 * symmisc.c (dump_symtab_1): Make "b" const.
8469 (block_depth): Make "block" const.
8470 * d-exp.y (%union) <bval>: Remove.
8471 * cp-support.h (cp_lookup_rtti_type): Update.
8472 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8473 * psymtab.c (psym_lookup_symbol): Make "block" const.
8474 (maintenance_check_psymtabs): Make "b" const.
8475 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8476 (enumerate_locals, enumerate_args): Update.
8477 * python/py-symtab.c (stpy_global_block): Make "block" const.
8478 (stpy_static_block): Likewise.
8479 * inline-frame.c (block_starting_point_at): Make "new_block"
8480 const.
8481 * block.c (find_block_in_blockvector): Make return type const.
8482 (blockvector_for_pc_sect): Make "b" const.
8483 (find_block_in_blockvector): Make "b" const.
8484
7ad417dd
TT		 84852019-03-23 Tom Tromey <tom@tromey.com>
8486
8487 * varobj.c (varobj_create): Update.
8488 * symfile.c (clear_symtab_users): Don't reset innermost_block.
8489 * printcmd.c (display_command, do_one_display): Don't reset
8490 innermost_block.
8491 * parser-defs.h (enum innermost_block_tracker_type): Move to
8492 expression.h.
8493 (innermost_block): Update comment.
8494 * parse.c (parse_exp_1): Add tracker_types parameter.
8495 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
8496 tracker_types parameter. Reset innermost_block.
8497 (parse_exp_in_context): Remove.
8498 (parse_expression_for_completion): Update.
8499 * objfiles.c (~objfile): Don't reset expression_context_block or
8500 innermost_block.
8501 * expression.h (enum innermost_block_tracker_type): Move from
8502 parser-defs.h.
8503 (parse_exp_1): Add tracker_types parameter.
8504 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8505 reset innermost_block.
8506
b366c208
TT		 85072019-03-23 Tom Tromey <tom@tromey.com>
8508
8509 * objfiles.h: Include bcache.h.
8510
9bb9b2f9
TT		 85112019-03-23 Tom Tromey <tom@tromey.com>
8512
8513 * linespec.c (get_current_search_block): Use
8514 scoped_restore_current_language.
8515 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8516
59c28372
AH		 85172019-03-22 Alan Hayward <alan.hayward@arm.com>
8518 Jiong Wang <jiong.wang@arm.com>
8519
8520 * aarch64-linux-tdep.c
8521 (aarch64_linux_iterate_over_regset_sections): Check for pauth
8522 section.
8523 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8524
17e116a7
AH		 85252019-03-22 Alan Hayward <alan.hayward@arm.com>
8526 Jiong Wang <jiong.wang@arm.com>
8527
8528 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8529 instructions.
8530 (aarch64_analyze_prologue_test): Add PACIASP test.
8531 (aarch64_prologue_prev_register): Unmask PC value.
8532
11e1b75f
AH		 85332019-03-22 Alan Hayward <alan.hayward@arm.com>
8534 Jiong Wang <jiong.wang@arm.com>
8535
8536 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8537 (aarch64_dwarf2_prev_register): Unmask PC value.
8538 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8539 (aarch64_execute_dwarf_cfa_vendor_op): Check for
8540 DW_CFA_AARCH64_negate_ra_state.
8541 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8542
34dcc7cf
AH		 85432019-03-22 Alan Hayward <alan.hayward@arm.com>
8544 Jiong Wang <jiong.wang@arm.com>
8545
8546 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8547 registers.
8548 (aarch64_pseudo_register_name): Likewise.
8549 (aarch64_pseudo_register_type): Likewise.
8550 (aarch64_pseudo_register_reggroup_p): Likewise.
8551 (aarch64_gdbarch_init): Add pauth registers.
8552 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8553 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8554 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8555 (struct gdbarch_tdep): Add regnum for ra_state.
8556
1ef53e6b
AH		 85572019-03-22 Alan Hayward <alan.hayward@arm.com>
8558 Jiong Wang <jiong.wang@arm.com>
8559
8560 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8561
76bed0fd
AH		 85622019-03-22 Alan Hayward <alan.hayward@arm.com>
8563 Jiong Wang <jiong.wang@arm.com>
8564
8565 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8566 function.
8567 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8568 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8569 (aarch64_gdbarch_init): Add puth registers.
8570 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8571 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8572 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8573
ee4fbcfa
AH		 85742019-03-22 Alan Hayward <alan.hayward@arm.com>
8575 Jiong Wang <jiong.wang@arm.com>
8576
8577 * aarch64-linux-nat.c
8578 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8579 * aarch64-linux-tdep.c
8580 (aarch64_linux_core_read_description): Likewise.
8581 (aarch64_linux_get_hwcap): New function.
8582 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8583 (aarch64_linux_get_hwcap): New declaration.
8584
6dc0ebde
AH		 85852019-03-22 Alan Hayward <alan.hayward@arm.com>
8586 Jiong Wang <jiong.wang@arm.com>
8587
8588 * aarch64-linux-nat.c
8589 (aarch64_linux_nat_target::read_description): Add pauth param.
8590 * aarch64-linux-tdep.c
8591 (aarch64_linux_core_read_description): Likewise.
8592 * aarch64-tdep.c (struct target_desc): Add in pauth.
8593 (aarch64_read_description): Add pauth param.
8594 (aarch64_gdbarch_init): Likewise.
8595 * aarch64-tdep.h (aarch64_read_description): Likewise.
8596 * arch/aarch64.c (aarch64_create_target_description): Likewise.
8597 * arch/aarch64.h (aarch64_create_target_description): Likewise.
8598 * features/Makefile: Add new files.
8599 * features/aarch64-pauth.c: New file.
8600 * features/aarch64-pauth.xml: New file.
8601
595915c1
TT		 86022019-03-20 Tom Tromey <tromey@adacore.com>
8603
8604 * infrun.c (handle_inferior_event): Rename from
8605 handle_inferior_event_1. Create a scoped_value_mark.
8606 (handle_inferior_event): Remove.
8607
4c7d57e7
TT		 86082019-03-19 Tom Tromey <tromey@adacore.com>
8609
8610 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8611 * infrun.h (print_stop_event): Add "displays" parameter.
8612 * infrun.c (print_stop_event): Add "displays" parameter.
8613
cb246234
PA		 86142019-03-19 Pedro Alves <palves@redhat.com>
8615
8616 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8617 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
8618 to -1. Fix TABs vs spaces.
8619 (tui_ui_out::tui_ui_out): Don't initialize fields here.
8620 * tui/tui-out.h (tui_ui_out) Add intro comments.
8621 <m_line, m_start_of_line>: In-class initialize, and add describing
8622 comment.
8623
3a0e45b2
AH		 86242019-03-18 Alan Hayward <alan.hayward@arm.com>
8625
8626 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8627 variable names.
8628 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8629
5371b850
PA		 86302019-03-18 Pedro Alves <palves@redhat.com>
8631 Eli Zaretskii <eliz@gnu.org>
8632
8633 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8634 m_line and m_start_of_line.
8635
b17c4cd0
EZ		 86362019-03-18 Eli Zaretskii <eliz@gnu.org>
8637
8638 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8639 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8640 it returns a newline. This fixes a regression in TU mode, whereby
8641 the next line is output on the same screen line as the user input.
8642
4bd56d18
TT		 86432019-03-18 Tom Tromey <tromey@adacore.com>
8644
8645 * minsyms.c (minimal_symbol_reader::install): Remove call to
8646 obstack_blank.
8647
55c10aca
PA		 86482019-03-18 Pedro Alves <palves@redhat.com>
8649
8650 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8651 New globals.
8652 (apply_style): New, factored out from ...
8653 (apply_ansi_escape): ... this. Handle reverse video mode.
8654 (tui_set_reverse_mode): New function.
8655 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8656 * tui/tui-winsource.c (tui_show_source_line): Use
8657 tui_set_reverse_mode instead of setting A_STANDOUT.
8658 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8659 New setter methods.
8660
647bb750
HD		 86612019-03-18 Hannes Domani <ssbssa@yahoo.de>
8662
8663 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8664 Handle tabs.
8665
bff8c71f
TT		 86662019-03-18 Tom Tromey <tromey@adacore.com>
8667
8668 * ada-lang.c (empty_array): Add "high" parameter.
8669 (ada_evaluate_subexp): Update.
8670
58785d98
ST		 86712019-03-17 Sergei Trofimovich <siarheit@google.com>
8672
8673 * unittests/string_view-selftests.c: Define
8674 _initialize_string_view_selftests unconditionally.
8675
d4cbef22
ВМ		 86762019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8677
8678 PR gdb/24350
8679 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8680
fce4c071
ВМ		 86812019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8682
8683 PR gdb/24351
8684 * windows-nat.c (display_selector): Fix format specifiers.
8685
f7f0a123
EZ		 86862019-03-17 Eli Zaretskii <eliz@gnu.org>
8687
8688 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8689 tui_refill_source_window instead of tui_refresh_win, to update the
8690 current execution line. This fixes redisplay of the current line
8691 when stepping through the code with "next" or "step".
8692
ab42892f
EZ		 86932019-03-16 Eli Zaretskii <eliz@gnu.org>
8694
8695 * source-cache.c (source_cache::get_source_lines): Call
8696 find_source_lines to initialize s->nlines. This fixes vertical
8697 scrolling of TUI source window when the DOWN arrow is pressed.
8698
8d8c087f
PW		 86992019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8700
8701 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8702 linux-thread-db.c (_initialize_thread_db): Likewise.
8703
798e1c30
EZ		 87042019-03-16 Eli Zaretskii <eliz@gnu.org>
8705
8706 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8707 wclrtoeol in tui_show_source_line". This reverts changes made in
8708 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8709
eefba3da
TT		 87102019-03-15 Tom Tromey <tom@tromey.com>
8711
8712 * symtab.h (struct minimal_symbol): Derive from
8713 general_symbol_info.
8714 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8715 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8716 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8717 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8718 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8719 (MSYMBOL_SEARCH_NAME): Update.
8720 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8721 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8722 * minsyms.c (minimal_symbol_reader::record_full): Update.
8723
0de2420c
TT		 87242019-03-15 Tom Tromey <tom@tromey.com>
8725
8726 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8727
042d75e4
TT		 87282019-03-15 Tom Tromey <tom@tromey.com>
8729
8730 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8731 unique_xmalloc_ptr.
8732 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8733 Update.
8734 * minsyms.c (lookup_minimal_symbol_by_pc_section)
8735 (build_minimal_symbol_hash_tables)
8736 (minimal_symbol_reader::install): Update.
8737
db92718b
TT		 87382019-03-15 Tom Tromey <tom@tromey.com>
8739
8740 * symtab.c (create_demangled_names_hash): Update.
8741 (symbol_set_names): Update.
8742 * objfiles.h (struct objfile_per_bfd_storage)
8743 <demangled_names_hash>: Now an htab_up.
8744 * objfiles.c (objfile_per_bfd_storage): Simplify.
8745
d6797f46
TT		 87462019-03-15 Tom Tromey <tom@tromey.com>
8747
8748 * objfiles.h (struct objfile_per_bfd_storage): Declare
8749 destructor.
8750 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8751 New.
8752 (get_objfile_bfd_data): Use new. Don't initialize
8753 language_of_main.
8754 (free_objfile_per_bfd_storage): Remove.
8755 (objfile_bfd_data_free, objfile::~objfile): Use delete.
8756
741d7538
TT		 87572019-03-15 Tom Tromey <tom@tromey.com>
8758
8759 * symfile.c (reread_symbols): Update.
8760 * objfiles.c (objfile::objfile): Update.
8761 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8762 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8763 comment.
8764 (minimal_symbol_reader::install): Update.
8765 (terminate_minimal_symbol_table): Remove.
8766 * jit.c (jit_object_close_impl): Update.
8767
788c80d1
TT		 87682019-03-15 Tom Tromey <tom@tromey.com>
8769
8770 * minsyms.c (minimal_symbol_reader::record_full): Remove some
8771 initializations.
8772
1b7a07cb
TT		 87732019-03-15 Tom Tromey <tom@tromey.com>
8774
8775 * objfiles.h (struct objfile_per_bfd_storage)
8776 <demangled_hash_languages>: Now a bitset.
8777 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8778 (lookup_minimal_symbol): Update.
8779
3db066bc
TT		 87802019-03-15 Tom Tromey <tom@tromey.com>
8781
8782 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8783 Don't return the symbol.
8784 * coffread.c (record_minimal_symbol): Use record_full.
8785
3fff2c37
EZ		 87862019-03-14 Eli Zaretskii <eliz@gnu.org>
8787
8788 The MS-Windows port of ncurses fails to switch to a color pair if
8789 one or both of the colors are the implicit default colors. This
8790 change records the default colors when TUI is initialized, and
8791 then specifies them explicitly when a color pair uses the default
8792 colors. This allows color styling in TUI mode on MS-Windows.
8793
8794 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
8795 ncurses_norm_attr.
8796 (tui_initialize_io) [__MINGW32__]: Record the default terminal
8797 colors in ncurses_norm_attr.
8798 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8799 "none", replace it with the default color recorded in
8800 ncurses_norm_attr.
8801
3b336828
TT		 88022019-03-14 Tom Tromey <tromey@adacore.com>
8803
8804 * source-cache.h (class source_cache) <get_source_lines>: Return
8805 std::string.
8806 * source-cache.c (source_cache::extract_lines): Handle case where
8807 first_pos==npos. Return std::string.
8808 (source_cache::get_source_lines): Update.
8809
d085f989
TT		 88102019-03-14 Tom Tromey <tromey@adacore.com>
8811
8812 * NEWS: Add item for "style sources" commands.
8813 * source-cache.c (source_cache::get_source_lines): Check
8814 source_styling.
8815 * cli/cli-style.c (source_styling): New global.
8816 (_initialize_cli_style): Add "style sources" commands.
8817 (show_style_sources): New function.
8818 * cli/cli-style.h (source_styling): Declare.
8819
6f11e682
TT		 88202019-03-14 Pedro Alves <palves@redhat.com>
8821 Tom Tromey <tromey@adacore.com>
8822
8823 * tui/tui-winsource.h (tui_refill_source_window): Declare.
8824 * tui/tui-winsource.c (tui_refill_source_window): New function,
8825 from...
8826 (tui_horizontal_source_scroll): ... here. Move some logic.
8827 * cli/cli-style.c (set_style_enabled): Notify new observable.
8828 * tui/tui-hooks.c (tui_redisplay_source): New function.
8829 (tui_attach_detach_observers): Attach or detach
8830 tui_redisplay_source.
8831 * observable.h (source_styling_changed): New observable.
8832 * observable.c: Define source_styling_changed observable.
8833
a068643d
TT		 88342019-03-13 Tom Tromey <tromey@adacore.com>
8835
8836 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8837 (i386_gnu_nat_target::store_registers): Update.
8838 * target-debug.h (target_debug_print_std_string): New macro.
8839 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8840 * windows-tdep.c (display_one_tib): Update.
8841 * tui/tui-stack.c (tui_make_status_line): Update.
8842 * top.c (print_inferior_quit_action): Update.
8843 * thread.c (thr_try_catch_cmd): Update.
8844 (add_thread_with_info): Update.
8845 (thread_target_id_str): Update.
8846 (thr_try_catch_cmd): Update.
8847 (thread_command): Update.
8848 (thread_find_command): Update.
8849 * record-btrace.c (record_btrace_target::info_record)
8850 (record_btrace_resume_thread, record_btrace_target::resume)
8851 (record_btrace_cancel_resume, record_btrace_step_thread)
8852 (record_btrace_target::wait, record_btrace_target::wait)
8853 (record_btrace_target::wait, record_btrace_target::stop): Update.
8854 * progspace.c (print_program_space): Update.
8855 * process-stratum-target.c
8856 (process_stratum_target::thread_address_space): Update.
8857 * linux-fork.c (linux_fork_mourn_inferior)
8858 (detach_checkpoint_command, info_checkpoints_command)
8859 (linux_fork_context): Update.
8860 (linux_fork_detach): Update.
8861 (class scoped_switch_fork_info): Update.
8862 (delete_checkpoint_command): Update.
8863 * infrun.c (follow_fork_inferior): Update.
8864 (follow_fork_inferior): Update.
8865 (proceed_after_vfork_done): Update.
8866 (handle_vfork_child_exec_or_exit): Update.
8867 (follow_exec): Update.
8868 (displaced_step_prepare_throw): Update.
8869 (displaced_step_restore): Update.
8870 (start_step_over): Update.
8871 (resume_1): Update.
8872 (clear_proceed_status_thread): Update.
8873 (proceed): Update.
8874 (print_target_wait_results): Update.
8875 (do_target_wait): Update.
8876 (context_switch): Update.
8877 (stop_all_threads): Update.
8878 (restart_threads): Update.
8879 (finish_step_over): Update.
8880 (handle_signal_stop): Update.
8881 (switch_back_to_stepped_thread): Update.
8882 (keep_going_pass_signal): Update.
8883 (print_exited_reason): Update.
8884 (normal_stop): Update.
8885 * inferior.c (inferior_pid_to_str): Change return type.
8886 (print_selected_inferior): Update.
8887 (add_inferior): Update.
8888 (detach_inferior): Update.
8889 * dummy-frame.c (fprint_dummy_frames): Update.
8890 * dcache.c (dcache_info_1): Update.
8891 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8892 (btrace_fetch, btrace_clear): Update.
8893 * linux-tdep.c (linux_core_pid_to_str): Change return type.
8894 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8895 type.
8896 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8897 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8898 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8899 * gdbarch.c, gdbarch.h: Rebuild.
8900 * gdbarch.sh (core_pid_to_str): Change return type.
8901 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8902 return type.
8903 (windows_nat_target::pid_to_str): Change return type.
8904 (windows_delete_thread): Update.
8905 (windows_nat_target::attach): Update.
8906 (windows_nat_target::files_info): Update.
8907 * target-delegates.c: Rebuild.
8908 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8909 return type.
8910 (sol_thread_target::pid_to_str): Change return type.
8911 * remote.c (class remote_target) <pid_to_str>: Change return
8912 type.
8913 (remote_target::pid_to_str): Change return type.
8914 (extended_remote_target::attach, remote_target::remote_stop_ns)
8915 (remote_target::remote_notif_remove_queued_reply)
8916 (remote_target::push_stop_reply, remote_target::disable_btrace):
8917 Update.
8918 (extended_remote_target::attach): Update.
8919 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8920 type.
8921 (gdbsim_target::pid_to_str): Change return type.
8922 * ravenscar-thread.c (struct ravenscar_thread_target)
8923 <pid_to_str>: Change return type.
8924 (ravenscar_thread_target::pid_to_str): Change return type.
8925 * procfs.c (class procfs_target) <pid_to_str>: Change return
8926 type.
8927 (procfs_target::pid_to_str): Change return type.
8928 (procfs_target::attach): Update.
8929 (procfs_target::detach): Update.
8930 (procfs_target::fetch_registers): Update.
8931 (procfs_target::store_registers): Update.
8932 (procfs_target::wait): Update.
8933 (procfs_target::files_info): Update.
8934 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8935 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8936 return type.
8937 (nto_procfs_target::pid_to_str): Change return type.
8938 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8939 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8940 return type.
8941 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8942 (exit_lwp): Update.
8943 (attach_proc_task_lwp_callback, get_detach_signal)
8944 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8945 (linux_nat_target::resume, wait_lwp, stop_callback)
8946 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8947 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8948 (linux_nat_wait_1, resume_stopped_resumed_lwps)
8949 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8950 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8951 type.
8952 (inf_ptrace_target::attach): Update.
8953 (inf_ptrace_target::files_info): Update.
8954 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8955 type.
8956 (go32_nat_target::pid_to_str): Change return type.
8957 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8958 (gnu_nat_target::wait): Update.
8959 (gnu_nat_target::wait): Update.
8960 (gnu_nat_target::resume): Update.
8961 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8962 (fbsd_nat_target::wait): Update.
8963 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8964 type.
8965 (darwin_nat_target::attach): Update.
8966 * corelow.c (class core_target) <pid_to_str>: Change return type.
8967 (core_target::pid_to_str): Change return type.
8968 * target.c (normal_pid_to_str): Change return type.
8969 (default_pid_to_str): Likewise.
8970 (target_pid_to_str): Change return type.
8971 (target_translate_tls_address): Update.
8972 (target_announce_detach): Update.
8973 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8974 return type.
8975 (bsd_uthread_target::pid_to_str): Change return type.
8976 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8977 type.
8978 (bsd_kvm_target::pid_to_str): Change return type.
8979 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8980 return type.
8981 (aix_thread_target::pid_to_str): Change return type.
8982 * target.h (struct target_ops) <pid_to_str>: Change return type.
8983 (target_pid_to_str, normal_pid_to_str): Likewise.
8984 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8985 type.
8986 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8987 type.
8988 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8989 return type.
8990 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8991 type.
8992 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8993 type.
8994 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8995 return type.
8996
b4be1b06
SM		 89972019-03-13 Simon Marchi <simon.marchi@ericsson.com>
8998
8999 * NEWS: Mention that the new default MI version is 3. Mention
9000 changes to the output of commands and events that deal with
9001 multi-location breakpoints.
9002 * breakpoint.c: Include "mi/mi-out.h".
9003 (print_one_breakpoint): Change output syntax if using MI version
9004 >= 3.
9005 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9006 New.
9007 (mi_multi_location_breakpoint_output_fixed): New.
9008 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9009 (mi_cmd_fix_multi_location_breakpoint_output): New.
9010 (mi_multi_location_breakpoint_output_fixed): New.
9011 * mi/mi-cmds.c (mi_cmds): Register command
9012 -fix-multi-location-breakpoint-output.
9013 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9014 interpreter "mi".
9015
8e5e5494
SM		 90162019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
9017
9018 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9019 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9020 instantiate mi_ui_out based on interpreter name.
9021 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9022 * mi/mi-main.c (mi_load_progress): Likewise.
9023
197df35e
JB		 90242019-03-12 John Baldwin <jhb@FreeBSD.org>
9025
9026 * NEWS: Combine separate "New targets" sections for 8.3.
9027
8399425f
JB		 90282019-03-12 John Baldwin <jhb@FreeBSD.org>
9029
9030 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9031 (ppcfbsd_init_abi): Install gdbarch
9032 "fetch_tls_load_module_address" and "get_thread_local_address"
9033 methods.
9034
b0f87ed0
JB		 90352019-03-12 John Baldwin <jhb@FreeBSD.org>
9036
9037 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9038 (riscv_fbsd_init_abi): Install gdbarch
9039 "fetch_tls_load_module_address" and "get_thread_local_address"
9040 methods.
9041
ce25aa57
JB		 90422019-03-12 John Baldwin <jhb@FreeBSD.org>
9043
9044 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9045 (i386fbsd_init_abi): Install gdbarch
9046 "fetch_tls_load_module_address" and "get_thread_local_address"
9047 methods.
9048
f5424cfa
JB		 90492019-03-12 John Baldwin <jhb@FreeBSD.org>
9050
9051 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9052 (amd64fbsd_init_abi): Install gdbarch
9053 "fetch_tls_load_module_address" and "get_thread_local_address"
9054 methods.
9055
945f3901
JB		 90562019-03-12 John Baldwin <jhb@FreeBSD.org>
9057
9058 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9059 (struct fbsd_pspace_data): New type.
9060 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9061 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9062 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9063 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9064 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9065
ef0bd204
JB		 90662019-03-12 John Baldwin <jhb@FreeBSD.org>
9067
9068 * gdbtypes.c (lookup_struct_elt): New function.
9069 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9070 * gdbtypes.h (struct struct_elt): New type.
9071 (lookup_struct_elt): New prototype.
9072
36c53a02
JB		 90732019-03-12 John Baldwin <jhb@FreeBSD.org>
9074
9075 * gdbtypes.c (lookup_struct_elt_type): Update comment and
9076 remove disabled code block.
9077
6e056c81
JB		 90782019-03-12 John Baldwin <jhb@FreeBSD.org>
9079
9080 * gdbarch.sh (get_thread_local_address): New method.
9081 * gdbarch.h, gdbarch.c: Regenerate.
9082 * target.c (target_translate_tls_address): Use
9083 gdbarch_get_thread_local_address if present instead of
9084 target::get_thread_local_address.
9085
cd250a18
JB		 90862019-03-12 John Baldwin <jhb@FreeBSD.org>
9087
9088 * target.h (target::get_thread_local_address): Update comment.
9089
df22c1e5
JB		 90902019-03-12 John Baldwin <jhb@FreeBSD.org>
9091
9092 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9093 objfile->separate_debug_objfile_backlink if not NULL.
9094
dd6876c9
JB		 90952019-03-12 John Baldwin <jhb@FreeBSD.org>
9096
9097 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9098 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9099 (amd64bsd_store_inferior_registers): Likewise.
9100 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9101 Enable segment base registers.
9102 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9103 PT_GETFSBASE and PT_GETGSBASE.
9104 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9105 PT_SETGSBASE.
9106 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9107 segment base registers.
9108 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9109
1163a4b7
JB		 91102019-03-12 John Baldwin <jhb@FreeBSD.org>
9111
9112 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9113 Update calls to i386_target_description to add 'segments'
9114 parameter.
9115 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
9116 add segment base registers.
9117 * arch/i386.c (i386_create_target_description): Add 'segments'
9118 parameter to enable segment base registers.
9119 * arch/i386.h (i386_create_target_description): Likewise.
9120 * features/i386/32bit-segments.xml: New file.
9121 * features/i386/32bit-segments.c: Generate.
9122 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9123 call to i386_target_description to add 'segments' parameter.
9124 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9125 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9126 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9127 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9128 if feature is present.
9129 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9130 Add 'segments' parameter to call to i386_target_description.
9131 (i386_target_description): Add 'segments' parameter to enable
9132 segment base registers.
9133 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9134 to call to i386_target_description.
9135 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9136 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9137 Define I386_NUM_REGS.
9138 (i386_target_description): Add 'segments' parameter to enable
9139 segment base registers.
9140
3a350822
EZ		 91412019-03-12 Eli Zaretskii <eliz@gnu.org>
9142
9143 PR/24325
9144 * source-cache.c: #undef open and close, to avoid unresolved
9145 externals during linking.
9146
ffdd69cf
TT		 91472019-03-12 Tom Tromey <tromey@adacore.com>
9148
9149 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9150 const. Add initializers.
9151 (_initialize_remote): Don't initialize ptid globals.
9152
ec148c57
PA		 91532019-03-12 Pedro Alves <palves@redhat.com>
9154
9155 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9156
32764270
PA		 91572019-03-12 Pedro Alves <palves@redhat.com>
9158
9159 * cp-name-parser.y (main): Remove unused 'len' variable.
9160
17547186
TT		 91612019-03-12 Tom Tromey <tromey@adacore.com>
9162
9163 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9164 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9165
d3a70e03
TT		 91662019-03-12 Tom Tromey <tromey@adacore.com>
9167
9168 * linux-nat.c (iterate_over_lwps): Update.
9169 (stop_callback): Remove parameter.
9170 (stop_wait_callback, detach_callback, resume_set_callback)
9171 (select_singlestep_lwp_callback, set_ignore_sigint)
9172 (status_callback, resumed_callback, resume_clear_callback)
9173 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9174 data parameter.
9175 (linux_nat_target::detach, linux_nat_target::resume)
9176 (linux_stop_and_wait_all_lwps, select_event_lwp)
9177 (linux_nat_filter_event, linux_nat_wait_1)
9178 (linux_nat_target::kill, linux_nat_target::stop)
9179 (linux_nat_target::stop): Update.
9180 (linux_nat_resume_callback): Change type.
9181 (resume_stopped_resumed_lwps, count_events_callback)
9182 (select_event_lwp_callback): Likewise.
9183 (linux_stop_lwp, linux_nat_stop_lwp): Update.
9184 * arm-linux-nat.c (struct update_registers_data): Remove.
9185 (update_registers_callback): Change type.
9186 (arm_linux_insert_hw_breakpoint1): Update.
9187 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9188 parameter.
9189 (x86_linux_dr_set_addr): Update.
9190 (x86_linux_dr_set_control): Update.
9191 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9192 (iterate_over_lwps): Use gdb::function_view.
9193 * nat/aarch64-linux-hw-point.c (struct
9194 aarch64_dr_update_callback_param): Remove.
9195 (debug_reg_change_callback): Change type.
9196 (aarch64_notify_debug_reg_change): Update.
9197 * s390-linux-nat.c (s390_refresh_per_info): Update.
9198
82cb27ff
TT		 91992019-03-11 Tom Tromey <tromey@adacore.com>
9200
9201 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9202 redundant assignment to "this_cu".
9203
568c0683
SM		 92042019-03-08 Simon Marchi <simon.marchi@efficios.com>
9205
9206 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9207
f09ce22d
SM		 92082019-03-08 Simon Marchi <simon.marchi@efficios.com>
9209
9210 * gdbtypes.c (rank_one_type_parm_set): New function extracted
9211 from...
9212 (rank_one_type): ... this.
9213
595f96a9
SM		 92142019-03-08 Simon Marchi <simon.marchi@efficios.com>
9215
9216 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9217 from...
9218 (rank_one_type): ... this.
9219
2598a94b
SM		 92202019-03-08 Simon Marchi <simon.marchi@efficios.com>
9221
9222 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9223 from...
9224 (rank_one_type): ... this.
9225
7f17b20d
SM		 92262019-03-08 Simon Marchi <simon.marchi@efficios.com>
9227
9228 * gdbtypes.c (rank_one_type_parm_float): New function extracted
9229 from...
9230 (rank_one_type): ... this.
9231
2c509035
SM		 92322019-03-08 Simon Marchi <simon.marchi@efficios.com>
9233
9234 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9235 from...
9236 (rank_one_type): ... this.
9237
0dd322dc
SM		 92382019-03-08 Simon Marchi <simon.marchi@efficios.com>
9239
9240 * gdbtypes.c (rank_one_type_parm_range): New function extracted
9241 from...
9242 (rank_one_type): ... this.
9243
41ea4728
SM		 92442019-03-08 Simon Marchi <simon.marchi@efficios.com>
9245
9246 * gdbtypes.c (rank_one_type_parm_char): New function extracted
9247 from...
9248 (rank_one_type): ... this.
9249
793cd1d2
SM		 92502019-03-08 Simon Marchi <simon.marchi@efficios.com>
9251
9252 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9253 from...
9254 (rank_one_type): ... this.
9255
34910087
SM		 92562019-03-08 Simon Marchi <simon.marchi@efficios.com>
9257
9258 * gdbtypes.c (rank_one_type_parm_int): New function extracted
9259 from...
9260 (rank_one_type): ... this.
9261
f1f832d6
SM		 92622019-03-08 Simon Marchi <simon.marchi@efficios.com>
9263
9264 * gdbtypes.c (rank_one_type_parm_func): New function extracted
9265 from...
9266 (rank_one_type): ... this.
9267
b9f4512f
SM		 92682019-03-08 Simon Marchi <simon.marchi@efficios.com>
9269
9270 * gdbtypes.c (rank_one_type_parm_array): New function extracted
9271 from...
9272 (rank_one_type): ... this.
9273
9293fc63
SM		 92742019-03-08 Simon Marchi <simon.marchi@efficios.com>
9275
9276 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9277 from...
9278 (rank_one_type): ... this.
9279
e3abbe7e
PW		 92802019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9281
9282 * inferior.c (initialize_inferiors): Ensure 'help set/show print
9283 inferior-events' shows the example events.
9284
e4adb939
EZ		 92852019-03-08 Eli Zaretskii <eliz@gnu.org>
9286
9287 Support styling on native MS-Windows console
9288
9289 PR/24315
9290 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9291 on MS-Windows if $TERM is not defined.
9292
9293 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9294
9295 * posix-hdep.c (gdb_console_fputs):
9296 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9297 functions.
9298 * ui-file.h (gdb_console_fputs): Add prototype.
9299
9300 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9301 back to fputs only if the former returns zero.
9302
25629dfd
TT		 93032019-03-07 Tom Tromey <tom@tromey.com>
9304
9305 * symmisc.c (print_symbol_bcache_statistics): Update.
9306 (print_objfile_statistics): Update.
9307 * symfile.c (allocate_symtab): Update.
9308 * stabsread.c: Don't include bcache.h.
9309 * psymtab.h (struct psymbol_bcache): Don't declare.
9310 (class psymtab_storage) <psymbol_cache>: Now a bcache.
9311 (psymbol_bcache_init, psymbol_bcache_free)
9312 (psymbol_bcache_get_bcache): Don't declare.
9313 * psymtab.c (struct psymbol_bcache): Remove.
9314 (psymtab_storage::psymtab_storage): Update.
9315 (psymtab_storage::~psymtab_storage): Update.
9316 (psymbol_bcache_init, psymbol_bcache_free)
9317 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9318 (add_psymbol_to_bcache): Update.
9319 (allocate_psymtab): Update.
9320 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9321 macro_cache>: No longer pointers.
9322 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9323 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9324 * macrotab.c (macro_bcache): Update.
9325 * macroexp.c: Don't include bcache.h.
9326 * gdbtypes.c (check_types_worklist): Update.
9327 (types_deeply_equal): Remove TRY/CATCH. Update.
9328 * elfread.c (elf_symtab_read): Update.
9329 * dwarf2read.c: Don't include bcache.h.
9330 * buildsym.c (buildsym_compunit::get_macro_table): Update.
9331 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9332 (print_bcache_statistics, bcache_memory_used): Don't declare.
9333 (struct bcache): Move from bcache.c. Add constructor, destructor,
9334 methods. Rename all data members.
9335 * bcache.c (struct bcache): Move to bcache.h.
9336 (bcache::expand_hash_table): Rename from expand_hash_table.
9337 (bcache): Remove.
9338 (bcache::insert): Rename from bcache_full.
9339 (bcache::compare): Rename from bcache_compare.
9340 (bcache_xmalloc): Remove.
9341 (bcache::~bcache): Rename from bcache_xfree.
9342 (bcache::print_statistics): Rename from print_bcache_statistics.
9343 (bcache::memory_used): Rename from bcache_memory_used.
9344
fe726667
PA		 93452019-03-07 Pedro Alves <palves@redhat.com>
9346
9347 * infrun.c (normal_stop): Also check for
9348 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9349
7584bb30
AB		 93502019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
9351
9352 * f-lang.c (value_from_host_double): Moved to...
9353 * value.c (value_from_host_double): ...here.
9354 * value.h (value_from_host_double): Declare.
9355 * guile/scm-math.c (vlscm_convert_typed_number): Use
9356 value_from_host_double.
9357 (vlscm_convert_number): Likewise.
9358 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9359 * python/py-value.c (convert_value_from_python): Likewise.
9360
a7b1986e
TT		 93612019-03-06 Tom Tromey <tom@tromey.com>
9362
9363 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9364
0ccf4211
TT		 93652019-03-06 Tom Tromey <tom@tromey.com>
9366
9367 * utils.h (free_current_contents): Don't declare.
9368 * utils.c (free_current_contents): Remove.
9369
fe7b42e5
TT		 93702019-03-06 Tom Tromey <tom@tromey.com>
9371
9372 * top.c (quit_force): Update.
9373 * main.c (captured_command_loop): Update.
9374 * common/new-op.c (operator new): Update.
9375 * common/common-exceptions.c (struct catcher)
9376 <save_cleanup_chain>: Remove member.
9377 (exceptions_state_mc_init): Update.
9378 (exception_try_scope_entry): Return nullptr.
9379 (exception_try_scope_exit, exception_rethrow)
9380 (throw_exception_sjlj, throw_exception_cxx): Update.
9381 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9382 (all_cleanups, do_cleanups, discard_cleanups)
9383 (discard_final_cleanups, save_cleanups, save_final_cleanups)
9384 (restore_cleanups, restore_final_cleanups): Don't declare.
9385 (do_final_cleanups): Remove parameter.
9386 * common/cleanups.c (cleanup_chain, make_cleanup)
9387 (make_cleanup_dtor, all_cleanups, do_cleanups)
9388 (discard_my_cleanups, discard_cleanups)
9389 (discard_final_cleanups, save_my_cleanups, save_cleanups)
9390 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9391 (null_cleanup): Remove.
9392 (do_final_cleanups): Remove parameter.
9393
c6321f19
TT		 93942019-03-06 Tom Tromey <tom@tromey.com>
9395
9396 * remote.c (remote_target::remote_parse_stop_reply): Use
9397 unique_xmalloc_ptr.
9398
61b30099
TT		 93992019-03-06 Tom Tromey <tom@tromey.com>
9400
9401 * stabsread.c (struct stabs_field_info): Rename from field_info.
9402 <list, fnlist>: Add initializers.
9403 <obstack>: New member.
9404 (read_member_functions, read_struct_fields, read_baseclasses):
9405 Allocate on obstack. Don't use cleanups.
9406 (read_one_struct_field, read_member_functions, read_struct_fields)
9407 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9408 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9409 (read_struct_type): Update.
9410
6cceac94
TT		 94112019-03-06 Tom Tromey <tom@tromey.com>
9412
9413 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9414 * common/filestuff.h (make_cleanup_close): Don't declare.
9415 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9416 Remove.
9417
72412762
TT		 94182019-03-06 Tom Tromey <tom@tromey.com>
9419
9420 * solib-aix.c: Use make_scope_exit.
9421
2b6ff1c0
TT		 94222019-03-06 Tom Tromey <tom@tromey.com>
9423
9424 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9425 Use make_scope_exit.
9426
d01c5877
TT		 94272019-03-06 Tom Tromey <tom@tromey.com>
9428
9429 * solib-svr4.c (disable_probes_interface): Remove parameter.
9430 (svr4_handle_solib_event): Use make_scope_exit.
9431
32603266
TT		 94322019-03-06 Tom Tromey <tom@tromey.com>
9433
9434 * remote.c (struct stop_reply_deleter): Remove.
9435 (stop_reply_up): Update.
9436 (struct stop_reply): Derive from notif_event. Don't typedef.
9437 <regcache>: Now a std::vector.
9438 (stop_reply_xfree): Remove.
9439 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9440 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
9441 (remote_target::discard_pending_stop_replies): Use delete.
9442 (remote_target::remote_parse_stop_reply): Update.
9443 (remote_target::process_stop_reply): Update.
9444 * remote-notif.h (struct notif_event): Add virtual destructor.
9445 Remove "dtr" member.
9446 (struct notif_client) <alloc_event>: Return a unique_ptr.
9447 (notif_event_xfree): Don't declare.
9448 (notif_event_up): New typedef.
9449 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9450 (notif_event_xfree, do_notif_event_xfree): Remove.
9451 (remote_notif_state_xfree): Update.
9452
9799571e
TT		 94532019-03-06 Tom Tromey <tom@tromey.com>
9454
9455 * infrun.c (displaced_step_clear_cleanup): Now a
9456 forward_scope_exit type.
9457 (displaced_step_prepare_throw): Update.
9458 (displaced_step_fixup): Update.
9459
09e3c4ca
TT		 94602019-03-06 Tom Tromey <tom@tromey.com>
9461
9462 * inferior.h (class inferior): Update comment.
9463 * gdbthread.h (class thread_info): Update comment.
9464
e2a03548
TT		 94652019-03-06 Joel Brobecker <brobecker@adacore.com>
9466 Tom Tromey <tom@tromey.com>
9467
9468 * stabsread.h (struct stab_section_list): Remove.
9469 (coffstab_build_psymtabs): Update.
9470 * dbxread.c (symbuf_sections): Now a std::vector.
9471 (sect_idx): New global.
9472 (fill_symbuf): Update.
9473 (coffstab_build_psymtabs): Change type of stabsects parameter.
9474 Update.
9475 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9476 std::vector.
9477 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9478 (coff_locate_sections): Update.
9479 (coff_symfile_read): Remove cleanups. Update.
9480 (init_stringtab): Add storage parameter.
9481 (free_stringtab, free_stringtab_cleanup): Remove.
9482 (init_lineno): Add storage parameter.
9483 (free_linetab, free_linetab_cleanup): Remove.
9484
b7e60d85
PA		 94852019-03-06 Pedro Alves <palves@redhat.com>
9486
9487 * linux-fork.c (fork_info::clobber_regs): Delete.
9488 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9489 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
9490 comment. Adjust.
9491 (scoped_switch_fork_info::scoped_switch_fork_info)
9492 (checkpoint_command, linux_fork_context): Adjust
9493 fork_save_infrun_state calls.
9494
e52c971f
PA		 94952019-03-06 Pedro Alves <palves@redhat.com>
9496
9497 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9498 (inf_has_multiple_threads): Return 'bool' and rewrite using
9499 inferior_info::threads().
9500
06974e6c
PA		 95012019-03-06 Pedro Alves <palves@redhat.com>
9502
9503 * linux-fork.c: Include <list>.
9504 (fork_list): Now a std::list instance.
9505 (fork_info): Add ctor, dtor, and in-class initialize all fields.
9506 (forks_exist_p, find_last_fork): Adjust.
9507 (new_fork): Delete.
9508 (one_fork_p): New.
9509 (add_fork): Adjust.
9510 (free_fork): Delete, folded into fork_info::~fork_info().
9511 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9512 Adjust.
9513 (init_fork_list): Delete.
9514 (linux_fork_killall, linux_fork_mourn_inferior)
9515 (linux_fork_detach, info_checkpoints_command): Adjust.
9516 (_initialize_linux_fork): No longer call init_fork_list.
9517
72f31aea
PA		 95182019-03-06 Pedro Alves <palves@redhat.com>
9519
9520 * linux-fork.c (new_fork): New, split out of ...
9521 (add_fork): ... this. Return void. Move "first fork" special
9522 case from here, to ...
9523 (checkpoint_command): ... here.
9524 * linux-linux.h (add_fork): Return void.
9525
efbecbc1
AB		 95262019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9527
9528 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9529
0841c79a
AB		 95302019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9531 Chris January <chris.january@arm.com>
9532 David Lecomber <david.lecomber@arm.com>
9533
9534 * f-exp.y: New token, UNOP_INTRINSIC.
9535 (exp): New pattern using UNOP_INTRINSIC token.
9536 (f77_keywords): Add 'abs' keyword.
9537 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9538 (value_from_host_double): New function.
9539 (evaluate_subexp_f): Support UNOP_ABS.
9540
4a270568
AB		 95412019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9542
9543 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9544 types.
9545
067630bd
AB		 95462019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9547
9548 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9549 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9550 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9551
3be47f7a
AB		 95522019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9553
9554 * f-exp.y (convert_to_kind_type): Handle more type kinds.
9555
4d00f5d8
AB		 95562019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9557 Chris January <chris.january@arm.com>
9558
9559 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9560 * f-exp.y: Define 'KIND' token.
9561 (exp): New pattern for KIND expressions.
9562 (ptype): Handle types with a kind extension.
9563 (direct_abs_decl): Extend to spot kind extensions.
9564 (f77_keywords): Add 'kind' to the list.
9565 (push_kind_type): New function.
9566 (convert_to_kind_type): New function.
9567 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9568 * parse.c (operator_length_standard): Likewise.
9569 * parser-defs.h (enum type_pieces): Add tp_kind.
9570 * std-operator.def: Add UNOP_KIND.
9571
e454224f
AB		 95722019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9573
9574 * f-exp.y (f_parse): Set yydebug.
9575
9dad4a58
AB		 95762019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9577
9578 * f-lang.c (evaluate_subexp_f): New function.
9579 (exp_descriptor_f): New global.
9580 (f_language_defn): Use exp_descriptor_f instead of
9581 exp_descriptor_standard.
9582
c8f91604
AB		 95832019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9584
9585 * f-exp.y (struct token): Add comments.
9586 (dot_ops): Remove uppercase versions and the end marker.
9587 (f77_keywords): Likewise.
9588 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9589 entries in the dot_ops array are case insensitive, and use
9590 strncasecmp to compare strings. Also some whitespace cleanup in
9591 this area. Similar for the f77_keywords array, except entries in
9592 this list might be case sensitive.
9593
dd9f2c76
AB		 95942019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9595
9596 * f-exp.y (struct f77_boolean_val): Add comments.
9597 (boolean_values): Remove uppercase versions, and end marker.
9598 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9599 and use strncasecmp to achieve case insensitivity. Additionally,
9600 perform whitespace cleanup around this code.
9601
67a3048c
TT		 96022019-03-06 Tom Tromey <tromey@adacore.com>
9603
9604 * remote-sim.c (gdbsim_target_open): Use result of
9605 gdb_argv::release.
9606
aa3cfbda
RB		 96072019-03-06 Richard Bunt <richard.bunt@arm.com>
9608 Dirk Schubert <dirk.schubert@arm.com>
9609 Chris January <chris.january@arm.com>
9610
9611 * eval.c (evaluate_subexp_standard): Call Fortran argument
9612 wrapping logic.
9613 * f-lang.c (struct value): A value which can be passed into a
9614 Fortran function call.
9615 (fortran_argument_convert): Wrap Fortran arguments in a pointer
9616 where appropriate.
9617 (struct type): Value ready for a Fortran function call.
9618 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9619 is needed.
9620 * f-lang.h (fortran_argument_convert): Declaration.
9621 (fortran_preserve_arg_pointer): Declaration.
9622 * infcall.c (value_arg_coerce): Call Fortran argument logic.
9623
ea38e5df
TT		 96242019-03-05 Tom Tromey <tromey@adacore.com>
9625
9626 * python/py-prettyprint.c (print_string_repr): Remove #if.
9627 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9628
06b5b831
TT		 96292019-03-05 Tom Tromey <tromey@adacore.com>
9630
9631 * target.c (the_dummy_target): Move later. Change type to
9632 "dummy_target".
9633 (initialize_targets): Don't initialize the_dummy_target.
9634
edbd9e45
TT		 96352019-03-05 Tom Tromey <tromey@adacore.com>
9636
9637 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9638 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9639
c119e040
TT		 96402019-03-05 Tom Tromey <tromey@adacore.com>
9641
9642 * windows-nat.c (windows_nat_target::attach)
9643 (windows_nat_target::detach): Don't call gdb_flush.
9644 * valprint.c (generic_val_print, val_print, val_print_string):
9645 Don't call gdb_flush.
9646 * utils.c (defaulted_query): Don't call gdb_flush.
9647 * typeprint.c (print_type_scalar): Don't call gdb_flush.
9648 * target.c (target_announce_detach): Don't call gdb_flush.
9649 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9650 * remote.c (extended_remote_target::attach): Don't call
9651 gdb_flush.
9652 * procfs.c (procfs_target::detach): Don't call gdb_flush.
9653 * printcmd.c (do_examine): Don't call gdb_flush.
9654 (info_display_command): Don't call gdb_flush.
9655 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9656 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9657 * memattr.c (info_mem_command): Don't call gdb_flush.
9658 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9659 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9660 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9661 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9662 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9663 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9664 (gnu_nat_target::detach): Don't call gdb_flush.
9665 * f-valprint.c (f_val_print): Don't call gdb_flush.
9666 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9667 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9668 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9669 gdb_flush.
9670 * c-valprint.c (c_val_print): Don't call gdb_flush.
9671 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9672
895dafa6
TT		 96732019-03-05 Tom Tromey <tromey@adacore.com>
9674
9675 * varobj.c (update_dynamic_varobj_children): Update.
9676 (install_default_visualizer): Use reset, not release.
9677 * value.c (set_internalvar): Update.
9678 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9679 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9680 ATTRIBUTE_UNUSED_RESULT.
9681
88a774b9
TT		 96822019-03-05 Tom Tromey <tromey@adacore.com>
9683
9684 * remote.c (class scoped_remote_fd) <release>: Add
9685 ATTRIBUTE_UNUSED_RESULT.
9686
4e4a8b93
TT		 96872019-03-05 Tom Tromey <tromey@adacore.com>
9688
9689 * macroexp.c (struct macro_buffer) <release>: Add
9690 ATTRIBUTE_UNUSED_RESULT.
9691
083eef1f
TT		 96922019-03-05 Tom Tromey <tromey@adacore.com>
9693
9694 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9695 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9696 ATTRIBUTE_UNUSED_RESULT.
9697
3cabd438
TT		 96982019-03-05 Tom Tromey <tromey@adacore.com>
9699
9700 * common/scoped_fd.h (class scoped_fd) <release>: Add
9701 ATTRIBUTE_UNUSED_RESULT.
9702
41e3300a
TT		 97032019-03-05 Tom Tromey <tromey@adacore.com>
9704
9705 * parser-defs.h (struct parser_state) <release>: Add
9706 ATTRIBUTE_UNUSED_RESULT.
9707
18cb7c9f
TT		 97082019-03-05 Tom Tromey <tromey@adacore.com>
9709
9710 * utils.h (class gdb_argv) <release>: Add
9711 ATTRIBUTE_UNUSED_RESULT.
9712 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9713
41fa577f
EZ		 97142019-03-02 Eli Zaretskii <eliz@gnu.org>
9715
a6a4b2c6
EZ		 9716 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9717 for-loop range, to avoid compiler warnings.
9718
9719 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9720 avoid compiler warnings about unused variables.
9721
742a7df5
EZ		 9722 * NEWS: Mention end of support for native debugging on MS-Windows
9723 before XP.
9724
41fa577f
EZ		 9725 PR gdb/24292
9726 * common/netstuff.c:
9727 * gdbserver/gdbreplay.c
9728 * gdbserver/remote-utils.c:
9729 * ser-tcp.c:
9730 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9731 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
9732 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9733 'getaddrinfo' and 'freeaddrinfo' were not available before
9734 Windows XP, and mingw.org's MinGW headers by default define
9735 _WIN32_WINNT to 0x500.
9736
827f438f
GB		 97372019-03-01 Gary Benson <gbenson@redhat.com>
9738
9739 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9740
92137da0
RO		 97412019-02-28 Brian Vandenberg <phantall@gmail.com>
9742 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
9743
9744 PR gdb/8527
9745 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9746 set_sigint_trap, clear_sigint_trap.
9747
799efbe8
PW		 97482019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9749
9750 * target.c (target_detach): Clear the regcache and the
9751 frame cache.
9752
8ed25214
PA		 97532019-02-27 Pedro Alves <palves@redhat.com>
9754
9755 * utils.c (set_screen_size): When we cap the height/width sizes,
9756 tweak the corresponding command variable to show "unlimited":
9757
23031e31
SJ		 97582019-02-27 Saagar Jha <saagar@saagarjha.com>
9759 Pedro Alves <palves@redhat.com>
9760
9761 * utils.c (set_screen_size): Reduce "infinite" rows and columns
9762 before calling rl_set_screen_size.
9763
6c28e44a
TT		 97642019-02-27 Tom Tromey <tromey@adacore.com>
9765
9766 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9767 define.
9768 * python/py-value.c: Remove Python 2.4 workaround.
9769 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9770 workaround.
9771 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9772 Python 2.4 workaround.
9773 * python/python-internal.h: Remove Python 2.4 comment.
9774 (Py_ssize_t): Don't define.
9775 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9776 (gdb_Py_DECREF): Remove Python 2.4 workaround.
9777 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9778 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9779 * python/python.c (do_start_initialization): Remove Python 2.4
9780 workaround.
9781 * python/py-prettyprint.c (class dummy_python_frame): Remove.
9782 (print_children): Remove Python 2.4 workaround.
9783 * python/py-inferior.c (buffer_procs): Remove Python 2.4
9784 workaround.
9785 (CHARBUFFERPROC_NAME): Remove.
9786 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9787 Python 2.4 workaround.
9788
2c3fc25d 97892019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 9790
2c3fc25d
KB		 9791 * NEWS: Note minimum Python version.
9792
6ca62222
KB		 97932019-02-27 Kevin Buettner <kevinb@redhat.com>
9794
9795 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9796 code from these functions. Remove corresponding ifdefs. Use
9797 Py_buffer_up instead of explicit calls to PyBuffer_Release.
9798 Remove gotos and target of gotos.
9799 (infpy_search_memory): Likewise.
9800
f4bc7d2c
AB		 98012019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9802
9803 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9804 (hppa_gdbarch_init): Don't register deleted functions with
9805 gdbarch.
9806
9734a586
AB		 98072019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9808
9809 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9810 (h8300_unwind_sp): Delete.
9811 (h8300_dummy_id): Delete.
9812 (h8300_gdbarch_init): Don't register deleted functions with
9813 gdbarch.
9814
68b867f3
AB		 98152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9816
9817 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9818 (ft32_unwind_pc): Delete.
9819 (ft32_unwind_sp): Delete.
9820 (ft32_gdbarch_init): Don't register deleted functions with
9821 gdbarch.
9822
2fbe7ad0
AB		 98232019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9824
9825 * gdb/frv-tdep.c (frv_dummy_id): Delete.
9826 (frv_unwind_pc): Delete.
9827 (frv_unwind_sp): Delete.
9828 (frv_gdbarch_init): Don't register deleted functions with
9829 gdbarch.
9830
76055cbe
AB		 98312019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9832
9833 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9834 (riscv_unwind_pc): Delete.
9835 (riscv_unwind_sp): Delete.
9836 (riscv_gdbarch_init): Don't register deleted functions with
9837 gdbarch.
9838
4133e5a1
AB		 98392019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9840
9841 * gdb/csky-tdep.c (csky_dummy_id): Delete.
9842 (csky_unwind_pc): Delete.
9843 (csky_unwind_sp): Delete.
9844 (csky_gdbarch_init): Don't register deleted functions with
9845 gdbarch.
9846
8010f576
AB		 98472019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9848
9849 * gdb/cris-tdep.c (cris_dummy_id): Delete.
9850 (cris_unwind_pc): Delete.
9851 (cris_unwind_sp): Delete.
9852 (cris_gdbarch_init): Don't register deleted functions with
9853 gdbarch.
9854
b56bf084
AB		 98552019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9856
9857 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9858 (bfin_unwind_pc): Delete.
9859 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9860
a19a650f
AB		 98612019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9862
9863 * gdb/arm-tdep.c (arm_dummy_id): Delete.
9864 (arm_unwind_pc): Delete.
9865 (arm_unwind_sp): Delete.
9866 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9867
f8278c3c
AB		 98682019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9869
9870 * gdb/arc-tdep.c (arc_dummy_id): Delete.
9871 (arc_unwind_pc): Delete.
9872 (arc_unwind_sp): Delete.
9873 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9874
480e46cf
AB		 98752019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9876
9877 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9878 (alpha_unwind_pc): Delete.
9879 (alpha_gdbarch_init): Don't register deleted functions with
9880 gdbarch.
9881
7a995095
AB		 98822019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9883
9884 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9885 (aarch64_unwind_pc): Delete.
9886 (aarch64_unwind_sp): Delete.
9887 (aarch64_gdbarch_init): Don't register deleted functions with
9888 gdbarch.
9889
bf9a735e
AB		 98902019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9891
9892 * gdbtypes.c (type_align): Don't consider static members when
9893 computing structure alignment.
9894
5561fc30
AB		 98952019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9896
9897 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9898 return 0 for other types.
9899 * arch-utils.c (default_type_align): Always return 0.
9900 * gdbarch.h: Regenerate.
9901 * gdbarch.sh (type_align): Extend comment.
9902 * gdbtypes.c (type_align): Add additional comments, always call
9903 gdbarch_type_align before applying the default rules.
9904 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9905 generic code will then apply a suitable default.
9906 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9907 types, return 0 for other types.
9908
9335e75a
JB		 99092019-02-27 Joel Brobecker <brobecker@adacore.com>
9910
9911 * NEWS: Create a new section for the next release branch.
9912 Rename the section of the current branch, now that it has
9913 been cut.
9914
3d34d8de
JB		 99152019-02-27 Joel Brobecker <brobecker@adacore.com>
9916
9917 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9918 * version.in: Bump version to 8.3.50.DATE-git.
9919
143420fb
SM		 99202019-02-26 Simon Marchi <simon.marchi@efficios.com>
9921
9922 * aix-thread.c (ptid_cmp): Remove unused variable.
9923 (get_signaled_thread): Likewise.
9924 (store_regs_user_thread): Likewise.
9925 (store_regs_kernel_thread): Likewise.
9926 (fetch_regs_kernel_thread): Remove shadowed variable.
9927
172fb711
AB		 99282019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
9929
9930 * features/riscv/32bit-cpu.xml: Add register numbers.
9931 * features/riscv/32bit-fpu.c: Regenerate.
9932 * features/riscv/32bit-fpu.xml: Add register numbers.
9933 * features/riscv/64bit-cpu.xml: Add register numbers.
9934 * features/riscv/64bit-fpu.c: Regenerate.
9935 * features/riscv/64bit-fpu.xml: Add register numbers.
9936
26c89782
KB		 99372019-02-26 Kevin Buettner <kevinb@redhat.com>
9938
af54ade9 9939 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB		 9940 * python/py-value.c (convert_buffer_and_type_to_value): New
9941 function.
9942 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9943 Add support for handling an optional second argument. Call
9944 convert_buffer_and_type_to_value as appropriate.
26c89782
KB		 9945 * python/python-internal.h (Py_buffer_deleter): New struct.
9946 (Py_buffer_up): New typedef.
9947
0f58c9e8
JB		 99482019-02-25 John Baldwin <jhb@FreeBSD.org>
9949
9950 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9951 instead of releasing ownership.
9952
0a0f4c01
JR		 99532019-02-25 Jordan Rupprecht <rupprecht@google.com>
9954
9955 * dwarf2read.c (open_and_init_dwp_file): Call
9956 elf_numsections instead of bfd_count_sections to initialize
9957 dwp_file->num_sections.
9958
cd5a152c
TT		 99592019-02-25 Tom Tromey <tromey@adacore.com>
9960
9961 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9962
8a6a8513
SDJ		 99632019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
9964
9965 * gcore.in: Add '--readnever' option when invoking GDB.
9966
04dcda9c
SM		 99672019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9968
9969 * MAINTAINERS: Update my email address.
9970
07bc701d
SM		 99712019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9972
9973 * build-id.c (build_id_to_debug_bfd_1): New function.
9974 (build_id_to_debug_bfd): Look for separate debug file in
9975 sysroot.
9976
c6f4a5d0
AB		 99772019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
9978
9979 * gdbarch.sh: Update the copyright year range that is placed into
9980 generated files.
9981
9600246d
KS		 99822019-02-22 Keith Seitz <keiths@redhat.com>
9983
9984 PR symtab/23853
9985 * linespec.c (create_sals_line_offset): Search for the default
9986 symtab's filename instead of its fullname.
9987
7557a514
AH		 99882019-02-21 Alan Hayward <alan.hayward@arm.com>
9989
9990 * NEWS: Update style defaults.
9991
ee2bcb0c
AH		 99922019-02-21 Alan Hayward <alan.hayward@arm.com>
9993
9994 * main.c (captured_main_1): Disable styling in batch mode.
9995
0c95f9ed
TT		 99962019-02-20 Tom Tromey <tom@tromey.com>
9997
9998 * symtab.c (symtab_symbol_info): Fix typos.
9999
c763b894
TT		 100002019-02-20 Tom Tromey <tromey@adacore.com>
10001
10002 * findcmd.c (_initialize_mem_search): Use upper case for
10003 metasyntactic variables.
10004
0ef8a082
AH		 100052019-02-20 Alan Hayward <alan.hayward@arm.com>
10006
10007 * aarch64-tdep.c (aarch64_add_reggroups): New function.
10008 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10009
6caa91b6
SM		 100102019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
10011
10012 * top.h (source_file_name): Change to std::string.
10013 * top.c (source_file_name): Likewise.
10014 (command_line_input): Adjust.
10015 * cli/cli-script.c (script_from_file): Adjust.
10016
98814c6c
TT		 100172019-02-19 Tom Tromey <tromey@adacore.com>
10018
10019 * ravenscar-thread.c
10020 (ravenscar_thread_target::update_thread_list): Don't call
10021 ada_build_task_list.
10022 * ada-lang.h (ada_build_task_list): Don't declare.
10023 * ada-tasks.c (struct ada_tasks_inferior_data)
10024 <task_list_valid_p>: Now bool.
10025 (read_known_tasks, ada_task_list_changed)
10026 (ada_tasks_invalidate_inferior_data): Update.
10027 (read_known_tasks_array): Return bool.
10028 (read_known_tasks_list): Likewise.
10029 (read_known_tasks): Return void.
10030 (ada_build_task_list): Now static.
10031
70cd633e
AB		 100322019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
10033
10034 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10035 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10036
040b3e95
PW		 100372019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10038
10039 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10040 variant for ada_tasks_pspace_data_handle and
10041 ada_tasks_inferior_data_handle.
10042 (ada_tasks_pspace_data_cleanup): New function.
10043 (ada_tasks_inferior_data_cleanup): New function.
10044
9409233b
TT		 100452019-02-17 Tom Tromey <tom@tromey.com>
10046
10047 * macrotab.h (macro_source_fullname): Return a std::string.
10048 * macrotab.c (macro_include, check_for_redefinition)
10049 (macro_undef, macro_lookup_definition, foreach_macro)
10050 (foreach_macro_in_scope): Update.
10051 (macro_source_fullname): Return a std::string.
10052 * macrocmd.c (show_pp_source_pos): Update.
10053
6506371f
TT		 100542019-02-17 Tom Tromey <tom@tromey.com>
10055
10056 * macrocmd.c (show_pp_source_pos): Style the file names.
10057
0c820d67
TT		 100582019-02-17 Tom Tromey <tom@tromey.com>
10059
10060 PR tui/24197:
10061 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10062
a0087920
TT		 100632019-02-17 Tom Tromey <tom@tromey.com>
10064
10065 * ada-lang.c (user_select_syms): Use filtered printing.
10066 * utils.c (wrap_style): New global.
10067 (desired_style): Remove.
10068 (emit_style_escape): Add stream parameter.
10069 (set_output_style, reset_terminal_style, prompt_for_continue):
10070 Update.
10071 (flush_wrap_buffer): Only flush gdb_stdout.
10072 (wrap_here): Set wrap_style.
10073 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
10074 treat escape sequences as a character. Change when wrap buffer is
10075 flushed.
10076 (fputs_styled): Do not set the output style when the default is
10077 requested.
10078 * ui-style.h (struct ui_file_style) <is_default>: New method.
10079 * source.c (print_source_lines_base): Emit escape sequences in one
10080 piece.
10081
75ba10dc
JB		 100822019-02-17 Joel Brobecker <brobecker@adacore.com>
10083
10084 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10085 integers and enumeration types.
10086
a2cd4f14
JB		 100872019-02-17 Joel Brobecker <brobecker@adacore.com>
10088
10089 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10090 instead of lookup_symbol_in_language
10091 (do_exact_match): New function.
10092 (ada_get_symbol_name_matcher): Return do_exact_match when
10093 doing a verbatim match.
10094
485b851b
TT		 100952019-02-15 Tom Tromey <tromey@adacore.com>
10096
10097 * ravenscar-thread.c (ravenscar_thread_target::resume)
10098 (ravenscar_thread_target::wait): Special case wildcard requests.
10099
0b790b1e
TT		 101002019-02-15 Tom Tromey <tromey@adacore.com>
10101
10102 * ravenscar-thread.c (base_ptid): Remove.
10103 (struct ravenscar_thread_target) <close>: New method.
10104 <m_base_ptid>: New member.
10105 <update_inferior_ptid, active_task, task_is_currently_active,
10106 runtime_initialized>: Declare methods.
10107 <ravenscar_thread_target>: Add constructor.
10108 (ravenscar_thread_target::task_is_currently_active)
10109 (ravenscar_thread_target::update_inferior_ptid)
10110 (ravenscar_runtime_initialized): Rename. Now methods.
10111 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10112 (ravenscar_thread_target::update_thread_list): Update.
10113 (ravenscar_thread_target::active_task): Now method.
10114 (ravenscar_thread_target::store_registers)
10115 (ravenscar_thread_target::prepare_to_store)
10116 (ravenscar_thread_target::prepare_to_store)
10117 (ravenscar_thread_target::mourn_inferior): Update.
10118 (ravenscar_inferior_created): Use "new" to create target.
10119 (ravenscar_thread_target::get_ada_task_ptid): Update.
10120 (_initialize_ravenscar): Don't initialize base_ptid.
10121 (ravenscar_ops): Remove global.
10122
dea57a62
TT		 101232019-02-15 Tom Tromey <tromey@adacore.com>
10124
10125 * target.h (push_target): Declare new overload.
10126 * target.c (push_target): New overload, taking an rvalue reference.
10127 * remote.c (remote_target::open_1): Use push_target overload.
10128 * corelow.c (core_target_open): Use push_target overload.
10129
989f3c58
TT		 101302019-02-15 Tom Tromey <tromey@adacore.com>
10131
10132 * ravenscar-thread.c (is_ravenscar_task)
10133 (ravenscar_task_is_currently_active): Return bool.
10134 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10135 (_initialize_ravenscar): Remove "(void)".
10136 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10137 Return bool.
10138
6cbcc006
TT		 101392019-02-15 Tom Tromey <tromey@adacore.com>
10140
10141 * ravenscar-thread.c (ravenscar_runtime_initializer)
10142 (has_ravenscar_runtime, get_running_thread_id)
10143 (ravenscar_thread_target::resume): Fix indentation.
10144
7657f14d
TT		 101452019-02-15 Tom Tromey <tromey@adacore.com>
10146
10147 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10148 from ravenscar_arch_ops.
10149 (sparc_ravenscar_ops::fetch_registers)
10150 (sparc_ravenscar_ops::store_registers): Now methods.
10151 (sparc_ravenscar_prepare_to_store): Remove.
10152 (sparc_ravenscar_ops): Redefine.
10153 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10154 methods and destructor. Remove members.
10155 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10156 (ravenscar_thread_target::store_registers)
10157 (ravenscar_thread_target::prepare_to_store): Update.
10158 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10159 Remove.
10160 (struct ppc_ravenscar_powerpc_ops): Derive from
10161 ravenscar_arch_ops.
10162 (ppc_ravenscar_powerpc_ops::fetch_registers)
10163 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10164 (ppc_ravenscar_powerpc_ops): Redefine.
10165 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10166 (ppc_ravenscar_e500_ops::fetch_registers)
10167 (ppc_ravenscar_e500_ops::store_registers): Now methods.
10168 (ppc_ravenscar_e500_ops): Redefine.
10169 * aarch64-ravenscar-thread.c
10170 (aarch64_ravenscar_generic_prepare_to_store): Remove.
10171 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10172 (aarch64_ravenscar_fetch_registers)
10173 (aarch64_ravenscar_store_registers): Now methods.
10174 (aarch64_ravenscar_ops): Redefine.
10175
5b6ea500
TT		 101762019-02-15 Tom Tromey <tromey@adacore.com>
10177
10178 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10179 (ravenscar_thread_target::stopped_by_hw_breakpoint)
10180 (ravenscar_thread_target::stopped_by_watchpoint)
10181 (ravenscar_thread_target::stopped_data_address)
10182 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10183
e397fd39
TT		 101842019-02-15 Tom Tromey <tromey@adacore.com>
10185
10186 * ravenscar-thread.c: Fix some typos.
10187
cc12f4a8
TT		 101882019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10189 Tom Tromey <tromey@adacore.com>
10190
10191 * ada-lang.c (ada_exception_sal): Change addr_string to a
10192 std::string.
10193 (create_ada_exception_catchpoint): Update.
10194
5f486660
TT		 101952019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10196 Tom Tromey <tromey@adacore.com>
10197
10198 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10199 (bp_location_ops): Remove.
10200 (base_breakpoint_allocate_location): Update.
10201 (free_bp_location): Update.
10202 * ada-lang.c (class ada_catchpoint_location)
10203 <ada_catchpoint_location>: Remove ops parameter.
10204 (ada_catchpoint_location_dtor): Remove.
10205 (ada_catchpoint_location_ops): Remove.
10206 (allocate_location_exception): Update.
10207 * breakpoint.h (struct bp_location_ops): Remove.
10208 (class bp_location) <bp_location>: Remove bp_location_ops
10209 parameter.
10210 <~bp_location>: Add destructor.
10211 <ops>: Remove.
10212
b671c7fb
TS		 102132019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10214 Pedro Alves <palves@redhat.com>
10215
10216 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10217 'PATH_MAX'.
10218
8071c5ce
DM		 102192019-02-14 David Michael <fedora.dm0@gmail.com>
10220 Samuel Thibault <samuel.thibault@gnu.org>
10221 Thomas Schwinge <thomas@codesourcery.com>
10222
10223 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10224 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10225
b1041ae0
TS		 102262019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10227
924514e1
TS		 10228 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10229 (check_empty): Use "const char *".
10230
c29ee8d4
TS		 10231 * gnu-nat.c (gnu_nat_target::detach): Instead of
10232 'detach_inferior (pid)' call
10233 'detach_inferior (find_inferior_pid (pid))'.
10234
6c6ef69f
TS		 10235 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10236 'nat/fork-inferior.o'.
10237 * gnu-nat.c: #include "nat/fork-inferior.h".
10238
2d0a338c
TS		 10239 * gnu-nat.c (gnu_nat_target::detach): Instead of
10240 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10241 * gnu-nat.h: #include "inf-child.h".
10242 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10243 'i386_gnu_nat_target::fetch_registers'.
10244 (gnu_store_registers): Rename/move to
10245 'i386_gnu_nat_target::store_registers'.
10246
cabb5f06
TS		 10247 * config/i386/nm-i386gnu.h: Don't "#include" any files.
10248 * gnu-nat.h (mach_thread_info): New function.
10249 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10250
b1041ae0
TS		 10251 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10252
2988d01e
KF		 102532019-02-14 Frederic Konrad <konrad@adacore.com>
10254
10255 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10256
c559d709
JB		 102572019-02-14 Joel Brobecker <brobecker@adacore.com>
10258
10259 * windows-nat.c (windows_add_thread): Add new parameter
10260 "main_thread_p" with default value set to false. Update
10261 function documentation as well as all callers.
10262 (windows_delete_thread): Likewise.
10263 (fake_create_process): Update call to windows_add_thread.
10264 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10265 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10266 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10267 call to windows_delete_thread.
10268
007024cc
SM		 102692019-02-13 Simon Marchi <simon.marchi@ericsson.com>
10270
10271 * MAINTAINERS: Add Andrew Burgess as global maintainer.
10272
f62318e9
JB		 102732019-02-12 John Baldwin <jhb@FreeBSD.org>
10274
10275 * symfile.c (find_separate_debug_file): Use canonical path of
10276 sysroot with child_path instead of gdb_sysroot if it is valid.
10277
cd4b7848
JB		 102782019-02-12 John Baldwin <jhb@FreeBSD.org>
10279
10280 * symfile.c (find_separate_debug_file): Use child_path to
10281 determine if an object file is under a sysroot.
10282
efac4bfe
JB		 102832019-02-12 John Baldwin <jhb@FreeBSD.org>
10284
10285 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10286 unittests/child-path-selftests.c.
10287 * common/pathstuff.c (child_path): New function.
10288 * common/pathstuff.h (child_path): New prototype.
10289 * unittests/child-path-selftests.c: New file.
10290
402d2bfe
JB		 102912019-02-12 John Baldwin <jhb@FreeBSD.org>
10292
10293 * symfile.c (find_separate_debug_file): Look for separate debug
10294 files in debug directories under the sysroot.
10295
1ed9f74e
PW		 102962019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10297
10298 * symtab.h (struct minimal_symbol data_p): New const method.
10299 (struct minimal_symbol text_p): Likewise.
10300 * symtab.c (output_source_filename): Use file name style
10301 to print file name.
10302 (print_symbol_info): Likewise.
10303 (print_msymbol_info): Use address style to print addresses.
10304 Use function name style to print executable text symbols.
10305 (expand_symtab_containing_pc): Use data_p.
10306 (find_pc_sect_compunit_symtab): Likewise.
10307
2636d81d
PW		 103082019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10309
10310 * breakpoint.c (describe_other_breakpoints): Use address style
10311 to print addresses.
10312 (say_where): Likewise.
10313
ac8c53cc
PW		 103142019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10315
10316 * ada-typeprint.c (print_func_type): Print function name
10317 style to print function name.
10318 * c-typeprint.c (c_print_type_1): Likewise.
10319
ea638c43
AH		 103202019-02-11 Alan Hayward <alan.hayward@arm.com>
10321
10322 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10323 for execve.
10324
ab759ca8
PW		 103252019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10326
10327 * c-exp.y (direct_abs_decl): Use emplace_back to record the
10328 type_stack.
10329
aff29d1c
JB		 103302019-02-10 Joel Brobecker <brobecker@adacore.com>
10331
10332 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10333 TYPE_CODE_REF types.
10334
617126bc
JW		 103352019-02-08 Jim Wilson <jimw@sifive.com>
10336
10337 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10338 (riscv_linux_fregset): New.
10339 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10340
46e3ed7f
TT		 103412019-02-07 Tom Tromey <tom@tromey.com>
10342
10343 * thread.c (thread_cancel_execution_command): Update.
10344 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10345 methods.
10346 (struct thread_fsm_ops): Remove.
10347 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10348 (thread_fsm_should_stop, thread_fsm_return_value)
10349 (thread_fsm_set_finished, thread_fsm_finished_p)
10350 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10351 Don't declare.
10352 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10353 * infrun.c (clear_proceed_status_thread)
10354 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10355 (print_stop_event): Update.
10356 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10357 Add constructor.
10358 (step_command_fsm_ops): Remove.
10359 (new_step_command_fsm): Remove.
10360 (step_1): Update.
10361 (step_command_fsm::should_stop): Rename from
10362 step_command_fsm_should_stop.
10363 (step_command_fsm::clean_up): Rename from
10364 step_command_fsm_clean_up.
10365 (step_command_fsm::do_async_reply_reason): Rename from
10366 step_command_fsm_async_reply_reason.
10367 (struct until_next_fsm): Inherit from thread_fsm. Add
10368 constructor.
10369 (until_next_fsm_ops): Remove.
10370 (new_until_next_fsm): Remove.
10371 (until_next_fsm::should_stop): Rename from
10372 until_next_fsm_should_stop.
10373 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10374 (until_next_fsm::do_async_reply_reason): Rename from
10375 until_next_fsm_async_reply_reason.
10376 (struct finish_command_fsm): Inherit from thread_fsm. Add
10377 constructor. Change type of breakpoint.
10378 (finish_command_fsm_ops): Remove.
10379 (new_finish_command_fsm): Remove.
10380 (finish_command_fsm::should_stop): Rename from
10381 finish_command_fsm_should_stop.
10382 (finish_command_fsm::clean_up): Rename from
10383 finish_command_fsm_clean_up.
10384 (finish_command_fsm::return_value): Rename from
10385 finish_command_fsm_return_value.
10386 (finish_command_fsm::do_async_reply_reason): Rename from
10387 finish_command_fsm_async_reply_reason.
10388 (finish_command): Update.
10389 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10390 Add constructor.
10391 (call_thread_fsm_ops): Remove.
10392 (call_thread_fsm::call_thread_fsm): Rename from
10393 new_call_thread_fsm.
10394 (call_thread_fsm::should_stop): Rename from
10395 call_thread_fsm_should_stop.
10396 (call_thread_fsm::should_notify_stop): Rename from
10397 call_thread_fsm_should_notify_stop.
10398 (run_inferior_call, call_function_by_hand_dummy): Update.
10399 * cli/cli-interp.c (should_print_stop_to_console): Update.
10400 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10401 Add constructor. Change type of location_breakpoint,
10402 caller_breakpoint.
10403 (until_break_fsm_ops): Remove.
10404 (new_until_break_fsm): Remove.
10405 (until_break_fsm::should_stop): Rename from
10406 until_break_fsm_should_stop.
10407 (until_break_fsm::clean_up): Rename from
10408 until_break_fsm_clean_up.
10409 (until_break_fsm::do_async_reply_reason): Rename from
10410 until_break_fsm_async_reply_reason.
10411 (until_break_command): Update.
10412 * thread-fsm.c: Remove.
10413 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10414
1a5c2598
TT		 104152019-02-07 Tom Tromey <tom@tromey.com>
10416
10417 * yy-remap.h: Add include guard.
10418 * xtensa-tdep.h: Add include guard.
10419 * xcoffread.h: Rename include guard.
10420 * varobj-iter.h: Add include guard.
10421 * tui/tui.h: Rename include guard.
10422 * tui/tui-winsource.h: Rename include guard.
10423 * tui/tui-wingeneral.h: Rename include guard.
10424 * tui/tui-windata.h: Rename include guard.
10425 * tui/tui-win.h: Rename include guard.
10426 * tui/tui-stack.h: Rename include guard.
10427 * tui/tui-source.h: Rename include guard.
10428 * tui/tui-regs.h: Rename include guard.
10429 * tui/tui-out.h: Rename include guard.
10430 * tui/tui-layout.h: Rename include guard.
10431 * tui/tui-io.h: Rename include guard.
10432 * tui/tui-hooks.h: Rename include guard.
10433 * tui/tui-file.h: Rename include guard.
10434 * tui/tui-disasm.h: Rename include guard.
10435 * tui/tui-data.h: Rename include guard.
10436 * tui/tui-command.h: Rename include guard.
10437 * tic6x-tdep.h: Add include guard.
10438 * target/waitstatus.h: Rename include guard.
10439 * target/wait.h: Rename include guard.
10440 * target/target.h: Rename include guard.
10441 * target/resume.h: Rename include guard.
10442 * target-float.h: Rename include guard.
10443 * stabsread.h: Add include guard.
10444 * rs6000-tdep.h: Add include guard.
10445 * riscv-fbsd-tdep.h: Add include guard.
10446 * regformats/regdef.h: Rename include guard.
10447 * record.h: Rename include guard.
10448 * python/python.h: Rename include guard.
10449 * python/python-internal.h: Rename include guard.
10450 * python/py-stopevent.h: Rename include guard.
10451 * python/py-ref.h: Rename include guard.
10452 * python/py-record.h: Rename include guard.
10453 * python/py-record-full.h: Rename include guard.
10454 * python/py-record-btrace.h: Rename include guard.
10455 * python/py-instruction.h: Rename include guard.
10456 * python/py-events.h: Rename include guard.
10457 * python/py-event.h: Rename include guard.
10458 * procfs.h: Add include guard.
10459 * proc-utils.h: Add include guard.
10460 * p-lang.h: Add include guard.
10461 * or1k-tdep.h: Rename include guard.
10462 * observable.h: Rename include guard.
10463 * nto-tdep.h: Rename include guard.
10464 * nat/x86-linux.h: Rename include guard.
10465 * nat/x86-linux-dregs.h: Rename include guard.
10466 * nat/x86-gcc-cpuid.h: Add include guard.
10467 * nat/x86-dregs.h: Rename include guard.
10468 * nat/x86-cpuid.h: Rename include guard.
10469 * nat/ppc-linux.h: Rename include guard.
10470 * nat/mips-linux-watch.h: Rename include guard.
10471 * nat/linux-waitpid.h: Rename include guard.
10472 * nat/linux-ptrace.h: Rename include guard.
10473 * nat/linux-procfs.h: Rename include guard.
10474 * nat/linux-osdata.h: Rename include guard.
10475 * nat/linux-nat.h: Rename include guard.
10476 * nat/linux-namespaces.h: Rename include guard.
10477 * nat/linux-btrace.h: Rename include guard.
10478 * nat/glibc_thread_db.h: Rename include guard.
10479 * nat/gdb_thread_db.h: Rename include guard.
10480 * nat/gdb_ptrace.h: Rename include guard.
10481 * nat/fork-inferior.h: Rename include guard.
10482 * nat/amd64-linux-siginfo.h: Rename include guard.
10483 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10484 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10485 * nat/aarch64-linux.h: Rename include guard.
10486 * nat/aarch64-linux-hw-point.h: Rename include guard.
10487 * mn10300-tdep.h: Add include guard.
10488 * mips-linux-tdep.h: Add include guard.
10489 * mi/mi-parse.h: Rename include guard.
10490 * mi/mi-out.h: Rename include guard.
10491 * mi/mi-main.h: Rename include guard.
10492 * mi/mi-interp.h: Rename include guard.
10493 * mi/mi-getopt.h: Rename include guard.
10494 * mi/mi-console.h: Rename include guard.
10495 * mi/mi-common.h: Rename include guard.
10496 * mi/mi-cmds.h: Rename include guard.
10497 * mi/mi-cmd-break.h: Rename include guard.
10498 * m2-lang.h: Add include guard.
10499 * location.h: Rename include guard.
10500 * linux-record.h: Rename include guard.
10501 * linux-nat.h: Add include guard.
10502 * linux-fork.h: Add include guard.
10503 * i386-darwin-tdep.h: Rename include guard.
10504 * hppa-linux-offsets.h: Add include guard.
10505 * guile/guile.h: Rename include guard.
10506 * guile/guile-internal.h: Rename include guard.
10507 * gnu-nat.h: Rename include guard.
10508 * gdb-stabs.h: Rename include guard.
10509 * frv-tdep.h: Add include guard.
10510 * f-lang.h: Add include guard.
10511 * event-loop.h: Add include guard.
10512 * darwin-nat.h: Rename include guard.
10513 * cp-abi.h: Rename include guard.
10514 * config/sparc/nm-sol2.h: Rename include guard.
10515 * config/nm-nto.h: Rename include guard.
10516 * config/nm-linux.h: Add include guard.
10517 * config/i386/nm-i386gnu.h: Rename include guard.
10518 * config/djgpp/nl_types.h: Rename include guard.
10519 * config/djgpp/langinfo.h: Rename include guard.
10520 * compile/gcc-cp-plugin.h: Add include guard.
10521 * compile/gcc-c-plugin.h: Add include guard.
10522 * compile/compile.h: Rename include guard.
10523 * compile/compile-object-run.h: Rename include guard.
10524 * compile/compile-object-load.h: Rename include guard.
10525 * compile/compile-internal.h: Rename include guard.
10526 * compile/compile-cplus.h: Rename include guard.
10527 * compile/compile-c.h: Rename include guard.
10528 * common/xml-utils.h: Rename include guard.
10529 * common/x86-xstate.h: Rename include guard.
10530 * common/version.h: Rename include guard.
10531 * common/vec.h: Rename include guard.
10532 * common/tdesc.h: Rename include guard.
10533 * common/selftest.h: Rename include guard.
10534 * common/scoped_restore.h: Rename include guard.
10535 * common/scoped_mmap.h: Rename include guard.
10536 * common/scoped_fd.h: Rename include guard.
10537 * common/safe-iterator.h: Rename include guard.
10538 * common/run-time-clock.h: Rename include guard.
10539 * common/refcounted-object.h: Rename include guard.
10540 * common/queue.h: Rename include guard.
10541 * common/ptid.h: Rename include guard.
10542 * common/print-utils.h: Rename include guard.
10543 * common/preprocessor.h: Rename include guard.
10544 * common/pathstuff.h: Rename include guard.
10545 * common/observable.h: Rename include guard.
10546 * common/netstuff.h: Rename include guard.
10547 * common/job-control.h: Rename include guard.
10548 * common/host-defs.h: Rename include guard.
10549 * common/gdb_wait.h: Rename include guard.
10550 * common/gdb_vecs.h: Rename include guard.
10551 * common/gdb_unlinker.h: Rename include guard.
10552 * common/gdb_unique_ptr.h: Rename include guard.
10553 * common/gdb_tilde_expand.h: Rename include guard.
10554 * common/gdb_sys_time.h: Rename include guard.
10555 * common/gdb_string_view.h: Rename include guard.
10556 * common/gdb_splay_tree.h: Rename include guard.
10557 * common/gdb_setjmp.h: Rename include guard.
10558 * common/gdb_ref_ptr.h: Rename include guard.
10559 * common/gdb_optional.h: Rename include guard.
10560 * common/gdb_locale.h: Rename include guard.
10561 * common/gdb_assert.h: Rename include guard.
10562 * common/filtered-iterator.h: Rename include guard.
10563 * common/filestuff.h: Rename include guard.
10564 * common/fileio.h: Rename include guard.
10565 * common/environ.h: Rename include guard.
10566 * common/common-utils.h: Rename include guard.
10567 * common/common-types.h: Rename include guard.
10568 * common/common-regcache.h: Rename include guard.
10569 * common/common-inferior.h: Rename include guard.
10570 * common/common-gdbthread.h: Rename include guard.
10571 * common/common-exceptions.h: Rename include guard.
10572 * common/common-defs.h: Rename include guard.
10573 * common/common-debug.h: Rename include guard.
10574 * common/cleanups.h: Rename include guard.
10575 * common/buffer.h: Rename include guard.
10576 * common/btrace-common.h: Rename include guard.
10577 * common/break-common.h: Rename include guard.
10578 * cli/cli-utils.h: Rename include guard.
10579 * cli/cli-style.h: Rename include guard.
10580 * cli/cli-setshow.h: Rename include guard.
10581 * cli/cli-script.h: Rename include guard.
10582 * cli/cli-interp.h: Rename include guard.
10583 * cli/cli-decode.h: Rename include guard.
10584 * cli/cli-cmds.h: Rename include guard.
10585 * charset-list.h: Add include guard.
10586 * buildsym-legacy.h: Rename include guard.
10587 * bfin-tdep.h: Add include guard.
10588 * ax.h: Rename include guard.
10589 * arm-linux-tdep.h: Add include guard.
10590 * arm-fbsd-tdep.h: Add include guard.
10591 * arch/xtensa.h: Rename include guard.
10592 * arch/tic6x.h: Add include guard.
10593 * arch/i386.h: Add include guard.
10594 * arch/arm.h: Rename include guard.
10595 * arch/arm-linux.h: Rename include guard.
10596 * arch/arm-get-next-pcs.h: Rename include guard.
10597 * arch/amd64.h: Add include guard.
10598 * arch/aarch64-insn.h: Rename include guard.
10599 * arch-utils.h: Rename include guard.
10600 * annotate.h: Add include guard.
10601 * amd64-darwin-tdep.h: Rename include guard.
10602 * aarch64-linux-tdep.h: Add include guard.
10603 * aarch64-fbsd-tdep.h: Add include guard.
10604 * aarch32-linux-nat.h: Add include guard.
10605
ab9268d2
PW		 106062019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10607
10608 * macrotab.c (macro_define_internal): New function that
10609 factorizes macro_define_object_internal and macro_define_function
10610 code.
10611 (macro_define_object_internal): Use macro_define_internal.
10612 (macro_define_function): Likewise.
10613
bb0da2b4
PW		 106142019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10615
10616 * macrocmd.c (extract_identifier): Return
10617 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10618 callers.
10619
424eb552
JB		 106202019-02-06 John Baldwin <jhb@FreeBSD.org>
10621
10622 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10623
1688cb29
TT		 106242019-02-05 Tom Tromey <tom@tromey.com>
10625
10626 * target.c (target_stack::unpush): Move assertion earlier.
10627
b5eba2d8
TT		 106282019-01-30 Tom Tromey <tom@tromey.com>
10629
10630 PR python/23615:
10631 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10632 (gdbpy_parse_and_eval): Likewise.
10633 * python/python-internal.h (gdbpy_allow_threads): New class.
10634
7054e2ff
JB		 106352019-01-28 John Baldwin <jhb@FreeBSD.org>
10636
10637 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10638 (aarch64_fbsd_fpregmap): Move earlier.
10639 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10640 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10641 instead of individual calls to trad_frame_set_reg_addr.
10642 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10643 earlier.
10644 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10645 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10646 instead of individual calls to trad_frame_set_reg_addr.
10647
36c25ffa
AH		 106482019-01-28 Alan Hayward <alan.hayward@arm.com>
10649
10650 * CONTRIBUTE: Replace contribution list with wiki link.
10651
a0707f3c
TT		 106522019-01-25 Tom Tromey <tom@tromey.com>
10653
10654 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10655
0747795c
TT		 106562019-01-25 Tom Tromey <tom@tromey.com>
10657
10658 * xtensa-linux-nat.c: Fix common/ includes.
10659 * xml-support.h: Fix common/ includes.
10660 * xml-support.c: Fix common/ includes.
10661 * x86-linux-nat.c: Fix common/ includes.
10662 * windows-nat.c: Fix common/ includes.
10663 * varobj.h: Fix common/ includes.
10664 * varobj.c: Fix common/ includes.
10665 * value.c: Fix common/ includes.
10666 * valops.c: Fix common/ includes.
10667 * utils.c: Fix common/ includes.
10668 * unittests/xml-utils-selftests.c: Fix common/ includes.
10669 * unittests/utils-selftests.c: Fix common/ includes.
10670 * unittests/unpack-selftests.c: Fix common/ includes.
10671 * unittests/tracepoint-selftests.c: Fix common/ includes.
10672 * unittests/style-selftests.c: Fix common/ includes.
10673 * unittests/string_view-selftests.c: Fix common/ includes.
10674 * unittests/scoped_restore-selftests.c: Fix common/ includes.
10675 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10676 * unittests/scoped_fd-selftests.c: Fix common/ includes.
10677 * unittests/rsp-low-selftests.c: Fix common/ includes.
10678 * unittests/parse-connection-spec-selftests.c: Fix common/
10679 includes.
10680 * unittests/optional-selftests.c: Fix common/ includes.
10681 * unittests/offset-type-selftests.c: Fix common/ includes.
10682 * unittests/observable-selftests.c: Fix common/ includes.
10683 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10684 * unittests/memrange-selftests.c: Fix common/ includes.
10685 * unittests/memory-map-selftests.c: Fix common/ includes.
10686 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10687 * unittests/function-view-selftests.c: Fix common/ includes.
10688 * unittests/environ-selftests.c: Fix common/ includes.
10689 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10690 * unittests/common-utils-selftests.c: Fix common/ includes.
10691 * unittests/cli-utils-selftests.c: Fix common/ includes.
10692 * unittests/array-view-selftests.c: Fix common/ includes.
10693 * ui-file.c: Fix common/ includes.
10694 * tui/tui-io.c: Fix common/ includes.
10695 * tracepoint.h: Fix common/ includes.
10696 * tracepoint.c: Fix common/ includes.
10697 * tracefile-tfile.c: Fix common/ includes.
10698 * top.h: Fix common/ includes.
10699 * top.c: Fix common/ includes.
10700 * thread.c: Fix common/ includes.
10701 * target/waitstatus.h: Fix common/ includes.
10702 * target/waitstatus.c: Fix common/ includes.
10703 * target.h: Fix common/ includes.
10704 * target.c: Fix common/ includes.
10705 * target-memory.c: Fix common/ includes.
10706 * target-descriptions.c: Fix common/ includes.
10707 * symtab.h: Fix common/ includes.
10708 * symfile.c: Fix common/ includes.
10709 * stap-probe.c: Fix common/ includes.
10710 * spu-linux-nat.c: Fix common/ includes.
10711 * sparc-nat.c: Fix common/ includes.
10712 * source.c: Fix common/ includes.
10713 * solib.c: Fix common/ includes.
10714 * solib-target.c: Fix common/ includes.
10715 * ser-unix.c: Fix common/ includes.
10716 * ser-tcp.c: Fix common/ includes.
10717 * ser-pipe.c: Fix common/ includes.
10718 * ser-base.c: Fix common/ includes.
10719 * selftest-arch.c: Fix common/ includes.
10720 * s12z-tdep.c: Fix common/ includes.
10721 * rust-exp.y: Fix common/ includes.
10722 * rs6000-aix-tdep.c: Fix common/ includes.
10723 * riscv-tdep.c: Fix common/ includes.
10724 * remote.c: Fix common/ includes.
10725 * remote-notif.h: Fix common/ includes.
10726 * remote-fileio.h: Fix common/ includes.
10727 * remote-fileio.c: Fix common/ includes.
10728 * regcache.h: Fix common/ includes.
10729 * regcache.c: Fix common/ includes.
10730 * record-btrace.c: Fix common/ includes.
10731 * python/python.c: Fix common/ includes.
10732 * python/py-type.c: Fix common/ includes.
10733 * python/py-inferior.c: Fix common/ includes.
10734 * progspace.h: Fix common/ includes.
10735 * producer.c: Fix common/ includes.
10736 * procfs.c: Fix common/ includes.
10737 * proc-api.c: Fix common/ includes.
10738 * printcmd.c: Fix common/ includes.
10739 * ppc-linux-nat.c: Fix common/ includes.
10740 * parser-defs.h: Fix common/ includes.
10741 * osdata.c: Fix common/ includes.
10742 * obsd-nat.c: Fix common/ includes.
10743 * nat/x86-linux.c: Fix common/ includes.
10744 * nat/x86-linux-dregs.c: Fix common/ includes.
10745 * nat/x86-dregs.h: Fix common/ includes.
10746 * nat/x86-dregs.c: Fix common/ includes.
10747 * nat/ppc-linux.c: Fix common/ includes.
10748 * nat/mips-linux-watch.h: Fix common/ includes.
10749 * nat/mips-linux-watch.c: Fix common/ includes.
10750 * nat/linux-waitpid.c: Fix common/ includes.
10751 * nat/linux-ptrace.h: Fix common/ includes.
10752 * nat/linux-ptrace.c: Fix common/ includes.
10753 * nat/linux-procfs.c: Fix common/ includes.
10754 * nat/linux-personality.c: Fix common/ includes.
10755 * nat/linux-osdata.c: Fix common/ includes.
10756 * nat/linux-namespaces.c: Fix common/ includes.
10757 * nat/linux-btrace.h: Fix common/ includes.
10758 * nat/linux-btrace.c: Fix common/ includes.
10759 * nat/fork-inferior.c: Fix common/ includes.
10760 * nat/amd64-linux-siginfo.c: Fix common/ includes.
10761 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10762 * nat/aarch64-linux.c: Fix common/ includes.
10763 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10764 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10765 * namespace.h: Fix common/ includes.
10766 * mips-linux-tdep.c: Fix common/ includes.
10767 * minsyms.c: Fix common/ includes.
10768 * mi/mi-parse.h: Fix common/ includes.
10769 * mi/mi-main.c: Fix common/ includes.
10770 * mi/mi-cmd-env.c: Fix common/ includes.
10771 * memrange.h: Fix common/ includes.
10772 * memattr.c: Fix common/ includes.
10773 * maint.h: Fix common/ includes.
10774 * maint.c: Fix common/ includes.
10775 * main.c: Fix common/ includes.
10776 * machoread.c: Fix common/ includes.
10777 * location.c: Fix common/ includes.
10778 * linux-thread-db.c: Fix common/ includes.
10779 * linux-nat.c: Fix common/ includes.
10780 * linux-fork.c: Fix common/ includes.
10781 * inline-frame.c: Fix common/ includes.
10782 * infrun.c: Fix common/ includes.
10783 * inflow.c: Fix common/ includes.
10784 * inferior.h: Fix common/ includes.
10785 * inferior.c: Fix common/ includes.
10786 * infcmd.c: Fix common/ includes.
10787 * inf-ptrace.c: Fix common/ includes.
10788 * inf-child.c: Fix common/ includes.
10789 * ia64-linux-nat.c: Fix common/ includes.
10790 * i387-tdep.c: Fix common/ includes.
10791 * i386-tdep.c: Fix common/ includes.
10792 * i386-linux-tdep.c: Fix common/ includes.
10793 * i386-linux-nat.c: Fix common/ includes.
10794 * i386-go32-tdep.c: Fix common/ includes.
10795 * i386-fbsd-tdep.c: Fix common/ includes.
10796 * i386-fbsd-nat.c: Fix common/ includes.
10797 * guile/scm-type.c: Fix common/ includes.
10798 * guile/guile.c: Fix common/ includes.
10799 * go32-nat.c: Fix common/ includes.
10800 * gnu-nat.c: Fix common/ includes.
10801 * gdbthread.h: Fix common/ includes.
10802 * gdbarch-selftests.c: Fix common/ includes.
10803 * gdb_usleep.c: Fix common/ includes.
10804 * gdb_select.h: Fix common/ includes.
10805 * gdb_bfd.c: Fix common/ includes.
10806 * gcore.c: Fix common/ includes.
10807 * fork-child.c: Fix common/ includes.
10808 * findvar.c: Fix common/ includes.
10809 * fbsd-nat.c: Fix common/ includes.
10810 * event-top.c: Fix common/ includes.
10811 * event-loop.c: Fix common/ includes.
10812 * dwarf2read.c: Fix common/ includes.
10813 * dwarf2loc.c: Fix common/ includes.
10814 * dwarf2-frame.c: Fix common/ includes.
10815 * dwarf-index-cache.c: Fix common/ includes.
10816 * dtrace-probe.c: Fix common/ includes.
10817 * disasm-selftests.c: Fix common/ includes.
10818 * defs.h: Fix common/ includes.
10819 * csky-tdep.c: Fix common/ includes.
10820 * cp-valprint.c: Fix common/ includes.
10821 * cp-support.h: Fix common/ includes.
10822 * cp-support.c: Fix common/ includes.
10823 * corelow.c: Fix common/ includes.
10824 * completer.h: Fix common/ includes.
10825 * completer.c: Fix common/ includes.
10826 * compile/compile.c: Fix common/ includes.
10827 * compile/compile-loc2c.c: Fix common/ includes.
10828 * compile/compile-cplus-types.c: Fix common/ includes.
10829 * compile/compile-cplus-symbols.c: Fix common/ includes.
10830 * command.h: Fix common/ includes.
10831 * cli/cli-dump.c: Fix common/ includes.
10832 * cli/cli-cmds.c: Fix common/ includes.
10833 * charset.c: Fix common/ includes.
10834 * build-id.c: Fix common/ includes.
10835 * btrace.h: Fix common/ includes.
10836 * btrace.c: Fix common/ includes.
10837 * breakpoint.h: Fix common/ includes.
10838 * breakpoint.c: Fix common/ includes.
10839 * ax.h:
10840 (enum agent_op): Fix common/ includes.
10841 * ax-general.c (struct aop_map): Fix common/ includes.
10842 * ax-gdb.c: Fix common/ includes.
10843 * auxv.c: Fix common/ includes.
10844 * auto-load.c: Fix common/ includes.
10845 * arm-tdep.c: Fix common/ includes.
10846 * arch/riscv.c: Fix common/ includes.
10847 * arch/ppc-linux-common.c: Fix common/ includes.
10848 * arch/i386.c: Fix common/ includes.
10849 * arch/arm.c: Fix common/ includes.
10850 * arch/arm-linux.c: Fix common/ includes.
10851 * arch/arm-get-next-pcs.c: Fix common/ includes.
10852 * arch/amd64.c: Fix common/ includes.
10853 * arch/aarch64.c: Fix common/ includes.
10854 * arch/aarch64-insn.c: Fix common/ includes.
10855 * arch-utils.c: Fix common/ includes.
10856 * amd64-windows-tdep.c: Fix common/ includes.
10857 * amd64-tdep.c: Fix common/ includes.
10858 * amd64-sol2-tdep.c: Fix common/ includes.
10859 * amd64-obsd-tdep.c: Fix common/ includes.
10860 * amd64-nbsd-tdep.c: Fix common/ includes.
10861 * amd64-linux-tdep.c: Fix common/ includes.
10862 * amd64-linux-nat.c: Fix common/ includes.
10863 * amd64-fbsd-tdep.c: Fix common/ includes.
10864 * amd64-fbsd-nat.c: Fix common/ includes.
10865 * amd64-dicos-tdep.c: Fix common/ includes.
10866 * amd64-darwin-tdep.c: Fix common/ includes.
10867 * agent.c: Fix common/ includes.
10868 * ada-lang.h: Fix common/ includes.
10869 * ada-lang.c: Fix common/ includes.
10870 * aarch64-tdep.c: Fix common/ includes.
10871
2f5c153e
TT		 108722019-01-25 Tom Tromey <tom@tromey.com>
10873
10874 * common/create-version.sh: Use common/version.h.
10875
adc6a863
PA		 108762019-01-24 Pedro Alves <palves@redhat.com>
10877
10878 * infrun.c (signal_stop, signal_print, signal_program)
10879 (signal_catch, signal_pass): Now arrays instead of pointers.
10880 (update_signals_program_target, do_target_resume)
10881 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10882 * linux-nat.c (linux_nat_target::pass_signals)
10883 (linux_nat_target::create_inferior, linux_nat_target::attach):
10884 Adjust.
10885 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10886 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10887 * procfs.c (procfs_target::pass_signals): Adjust.
10888 * record-full.c (record_full_target::resume): Adjust.
10889 * remote.c (remote_target::pass_signals)
10890 (remote_target::program_signals): Adjust.
10891 * target-debug.h (target_debug_print_signals): Now takes a
10892 gdb::array_view as parameter. Adjust.
10893 * target.h (target_ops) <pass_signals, program_signals>: Replace
10894 pointer and length parameters with gdb::array_view.
10895 (target_pass_signals, target_program_signals): Likewise.
10896 * target-delegates.c: Regenerate.
10897
3046d67a
PA		 108982019-01-24 Pedro Alves <palves@redhat.com>
10899
10900 * common/forward-scope-exit.h
10901 (forward_scope_exit::forward_scope_exit): Pass arguments to
10902 m_bind_function directly, instead of creating a std::bind and
10903 copying that.
10904
353229bf
AH		 109052019-01-24 Alan Hayward <alan.hayward@arm.com>
10906
10907 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10908 for static members.
10909 (pass_in_v_vfp_candidate): Likewise.
10910
311dc83a
TT		 109112019-01-23 Tom Tromey <tom@tromey.com>
10912 Pedro Alves <palves@redhat.com>
10913
10914 * regcache.c (class regcache_invalidator): Remove.
10915 (regcache::raw_write): Use make_scope_exit.
10916
296bd123
TT		 109172019-01-23 Tom Tromey <tom@tromey.com>
10918
10919 * ui-out.h (class ui_out_emit_type): Update comment.
10920
979a0d13
TT		 109212019-01-23 Tom Tromey <tom@tromey.com>
10922
10923 * infrun.c (fetch_inferior_event): Update comment.
10924
d238133d
TT		 109252019-01-23 Tom Tromey <tom@tromey.com>
10926 Pedro Alves <palves@redhat.com>
10927
10928 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10929 parameter.
10930 (fetch_inferior_event): Use SCOPE_EXIT.
10931
10932
9885e6bb
TT		 109332019-01-23 Tom Tromey <tom@tromey.com>
10934 Pedro Alves <palves@redhat.com>
10935
10936 * infrun.c (disable_thread_events): Delete.
10937 (stop_all_threads): Use SCOPE_EXIT.
10938
286526c1
TT		 109392019-01-23 Tom Tromey <tom@tromey.com>
10940 Pedro Alves <palves@redhat.com>
10941
10942 * symfile.c: Include forward-scope-exit.h.
10943 (clear_symtab_users_cleanup): Replace forward declaration with
10944 a FORWARD_SCOPE_EXIT.
10945 (syms_from_objfile_1): Use the forward_scope_exit and
10946 gdb::optional instead of cleanup_function.
10947 (reread_symbols): Use the forward_scope_exit instead of
10948 cleanup_function.
10949 (clear_symtab_users_cleanup): Remove function.
10950
1db93f14
TT		 109512019-01-23 Tom Tromey <tom@tromey.com>
10952 Pedro Alves <palves@redhat.com>
10953
10954 * linux-nat.c: Include scope-exit.h.
10955 (cleanup_target_stop): Remove.
10956 (linux_nat_target::static_tracepoint_markers_by_strid): Use
10957 SCOPE_EXIT.
10958
2cc83d1e
TT		 109592019-01-23 Tom Tromey <tom@tromey.com>
10960 Pedro Alves <palves@redhat.com>
10961
10962 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10963 (call_function_by_hand_dummy): Use SCOPE_EXIT.
10964
694c6bf5
TT		 109652019-01-23 Tom Tromey <tom@tromey.com>
10966 Andrew Burgess <andrew.burgess@embecosm.com>
10967 Pedro Alves <palves@redhat.com>
10968
10969 * infrun.c (fetch_inferior_event): Use scope_exit.
10970 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10971 * top.c (execute_command): Use scope_exit.
10972 * breakpoint.c (bpstat_do_actions): Use scope_exit.
10973 * utils.c (do_bpstat_clear_actions_cleanup)
10974 (make_bpstat_clear_actions_cleanup): Remove.
10975
4c41382a
TT		 109762019-01-23 Tom Tromey <tom@tromey.com>
10977 Pedro Alves <palves@redhat.com>
10978
10979 * infrun.c: Include "common/scope-exit.h"
10980 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10981 (wait_for_inferior): Use SCOPE_EXIT.
10982 (fetch_inferior_event): Use scope_exit.
10983
89f8fb50
TT		 109842019-01-23 Tom Tromey <tom@tromey.com>
10985 Pedro Alves <palves@redhat.com>
10986
10987 * breakpoint.c (create_breakpoint): Remove cleanup.
10988
5419bdae
TT		 109892019-01-23 Tom Tromey <tom@tromey.com>
10990 Andrew Burgess <andrew.burgess@embecosm.com>
10991 Pedro Alves <palves@redhat.com>
10992
e587ef42
PA		 109932019-01-23 Pedro Alves <palves@redhat.com>
10994
10995 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10996
77f0e74c
PA		 109972019-01-23 Pedro Alves <palves@redhat.com>
10998 Andrew Burgess <andrew.burgess@embecosm.com>
10999
11000 * gdbthread.h: Include "common/forward-scope-exit.h".
11001 (scoped_finish_thread_state): Redefine custom class in terms of
11002 forward_scope_exit.
11003
5b9b3e53
PA		 110042019-01-23 Pedro Alves <palves@redhat.com>
11005 Andrew Burgess <andrew.burgess@embecosm.com>
11006
11007 * common/forward-scope-exit.h: New file.
11008
54b65c9b
PA		 110092019-01-23 Pedro Alves <palves@redhat.com>
11010 Andrew Burgess <andrew.burgess@embecosm.com>
11011 Tom Tromey <tom@tromey.com>
11012
11013 * common/scope-exit.h: New file.
11014
cf08fb29
PA		 110152019-01-23 Pedro Alves <palves@redhat.com>
11016
11017 * common/preprocessor.h (ESC): Rename to ...
11018 (ESC_PARENS): ... this.
11019 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11020 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11021
ae73e2e2
TT		 110222019-01-23 Tom Tromey <tom@tromey.com>
11023
11024 * language.h (class scoped_switch_to_sym_language_if_auto):
11025 Initialize m_lang in both cases.
11026
6594e122
AH		 110272019-01-23 Alan Hayward <alan.hayward@arm.com>
11028
11029 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11030 with XCNEW.
11031
a7c9855d
TT		 110322019-01-22 Tom Tromey <tom@tromey.com>
11033
11034 * corelow.c: Do not include sys/file.h.
11035
93cc1d53
TT		 110362019-01-22 Tom Tromey <tom@tromey.com>
11037
11038 * tui/tui-wingeneral.h: Include gdb_curses.h.
11039
38561778
TT		 110402019-01-22 Tom Tromey <tom@tromey.com>
11041
11042 * source-cache.h (class source_cache) <get_source_lines,
11043 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11044
37b3ab5b
TT		 110452019-01-22 Tom Tromey <tom@tromey.com>
11046
11047 * remote-fileio.h (struct remote_target): Declare.
11048
3fabc016
TT		 110492019-01-22 Tom Tromey <tom@tromey.com>
11050
11051 * python/py-arch.c: Do not include py-ref.h.
11052 * python/py-bpevent.c: Do not include py-ref.h.
11053 * python/py-cmd.c: Do not include py-ref.h.
11054 * python/py-continueevent.c: Do not include py-ref.h.
11055 * python/py-event.h: Do not include py-ref.h.
11056 * python/py-evtregistry.c: Do not include py-ref.h.
11057 * python/py-finishbreakpoint.c: Do not include py-ref.h.
11058 * python/py-frame.c: Do not include py-ref.h.
11059 * python/py-framefilter.c: Do not include py-ref.h.
11060 * python/py-function.c: Do not include py-ref.h.
11061 * python/py-infevents.c: Do not include py-ref.h.
11062 * python/py-linetable.c: Do not include py-ref.h.
11063 * python/py-objfile.c: Do not include py-ref.h.
11064 * python/py-param.c: Do not include py-ref.h.
11065 * python/py-prettyprint.c: Do not include py-ref.h.
11066 * python/py-progspace.c: Do not include py-ref.h.
11067 * python/py-symbol.c: Do not include py-ref.h.
11068 * python/py-symtab.c: Do not include py-ref.h.
11069 * python/py-type.c: Do not include py-ref.h.
11070 * python/py-unwind.c: Do not include py-ref.h.
11071 * python/py-utils.c: Do not include py-ref.h.
11072 * python/py-value.c: Do not include py-ref.h.
11073 * python/py-varobj.c: Do not include py-ref.h.
11074 * python/py-xmethods.c: Do not include py-ref.h.
11075 * python/python.c: Do not include py-ref.h.
11076 * varobj.c: Do not include py-ref.h.
11077
6b4d7774
TT		 110782019-01-22 Tom Tromey <tom@tromey.com>
11079
11080 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11081 keyword for bcache.
11082
7af7e9b5
TT		 110832019-01-22 Tom Tromey <tom@tromey.com>
11084
11085 * compile/compile-cplus-types.c: Remove a comment by #include.
11086
951d1049
TT		 110872019-01-22 Tom Tromey <tom@tromey.com>
11088
11089 * compile/gcc-c-plugin.h: Include compile-internal.h.
11090
d65d5705
TT		 110912019-01-22 Tom Tromey <tom@tromey.com>
11092
11093 * stabsread.c (EXTERN): Do not define.
11094 (symnum, next_symbol_text_func, processing_gcc_compilation)
11095 (within_function, global_sym_chain, global_stabs)
11096 (previous_stab_code, this_object_header_files)
11097 (n_this_object_header_files)
11098 (n_allocated_this_object_header_files): Define.
11099 * stabsread.h (EXTERN): Never define. Use "extern".
11100
b6fb1ee5
PW		 111012019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11102
11103 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11104 history_value.
11105
be6d4f74
TT		 111062019-01-21 Tom Tromey <tom@tromey.com>
11107
11108 * ui-out.c: Fix includes.
11109 * tui/tui-source.c: Fix includes.
11110 * target.c: Fix includes.
11111 * remote.c: Fix includes.
11112 * regcache.c: Fix includes.
11113 * python/py-block.c: Fix includes.
11114 * printcmd.c: Fix includes.
11115 * or1k-tdep.c: Fix includes.
11116 * mi/mi-main.c: Fix includes.
11117 * m32r-tdep.c: Fix includes.
11118 * csky-tdep.c: Fix includes.
11119 * compile/compile-cplus-types.c: Fix includes.
11120 * cli/cli-interp.c: Fix includes.
11121
73021deb
AH		 111222019-01-21 Alan Hayward <alan.hayward@arm.com>
11123
11124 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11125 for padding.
11126
7932255d
TT		 111272019-01-16 Tom Tromey <tom@tromey.com>
11128
11129 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
11130 earlier.
11131 (struct objfile) <msymbols_range>: Move from top level.
11132 <msymbols>: New method.
11133 (class objfile_msymbols): Remove.
11134 * symtab.c (default_collect_symbol_completion_matches_break_on):
11135 Update.
11136 * symmisc.c (dump_msymbols): Update.
11137 * stabsread.c (scan_file_globals): Update.
11138 * objc-lang.c (info_selectors_command, info_classes_command)
11139 (find_methods): Update.
11140 * minsyms.c (find_solib_trampoline_target): Update.
11141 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11142 * coffread.c (coff_symfile_read): Update.
11143 * ada-lang.c (ada_lookup_simple_minsym)
11144 (ada_collect_symbol_completion_matches): Update.
11145
604b1bfb
TT		 111462019-01-16 Tom Tromey <tom@tromey.com>
11147
11148 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11149 type. Remove no-argument constructor.
11150 <iterator::operator++>: Simplify.
11151 <begin>: Update.
11152 <end>: Use minimal_symbol_count.
11153
f252c6d5
TT		 111542019-01-16 Tom Tromey <tom@tromey.com>
11155
11156 * objfiles.h (struct objfile) <psymtabs>: New method.
11157 (class objfile_psymtabs): Remove.
11158 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11159 typedef.
11160 <range>: New method.
11161 (require_partial_symbols): Change return type.
11162 * psymtab.c (require_partial_symbols)
11163 (psym_expand_symtabs_matching): Update.
11164 * mdebugread.c (parse_partial_symbols): Update.
11165 * dbxread.c (dbx_end_psymtab): Update.
11166
b669c953
TT		 111672019-01-15 Tom Tromey <tom@tromey.com>
11168
11169 * symtab.c (lookup_objfile_from_block)
11170 (lookup_symbol_in_objfile_symtabs)
11171 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11172 (find_line_symtab, info_sources_command)
11173 (default_collect_symbol_completion_matches_break_on)
11174 (make_source_files_completion_list): Update.
11175 * symmisc.c (print_objfile_statistics, dump_objfile)
11176 (maintenance_print_symbols, maintenance_info_symtabs)
11177 (maintenance_check_symtabs, maintenance_info_line_tables):
11178 Update.
11179 * source.c (select_source_symtab)
11180 (forget_cached_source_info_for_objfile): Update.
11181 * objfiles.h (class objfile_compunits): Remove.
11182 (struct objfile) <compunits_range>: New typedef.
11183 (compunits): New method.
11184 * objfiles.c (objfile_relocate1): Update.
11185 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11186 * maint.c (count_symtabs_and_blocks): Update.
11187 * linespec.c (iterate_over_all_matching_symtabs): Update.
11188 * cp-support.c (add_symbol_overload_list_qualified): Update.
11189 * coffread.c (coff_symtab_read): Update.
11190 * ada-lang.c (add_nonlocal_symbols)
11191 (ada_collect_symbol_completion_matches)
11192 (ada_add_global_exceptions): Update.
11193
7e955d83
TT		 111942019-01-15 Tom Tromey <tom@tromey.com>
11195
11196 * progspace.h (program_space) <objfiles_safe_range>: New
11197 typedef.
11198 <objfiles_safe>: New method.
11199 * objfiles.h (class all_objfiles_safe): Remove.
11200 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11201 * jit.c (jit_inferior_exit_hook): Update.
11202
2030c079
TT		 112032019-01-17 Tom Tromey <tom@tromey.com>
11204
11205 * progspace.h (program_space) <objfiles_range>: New typedef.
11206 <objfiles>: New method.
11207 <objfiles_head>: Rename from objfiles.
11208 (object_files): Update.
11209 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11210 * guile/scm-pretty-print.c
11211 (ppscm_find_pretty_printer_from_objfiles): Update.
11212 * guile/scm-objfile.c (gdbscm_objfiles): Update.
11213 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11214 Update.
11215 * python/py-progspace.c (pspy_get_objfiles): Update.
11216 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11217 Update.
11218 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11219 (objfpy_lookup_objfile_by_build_id): Update.
11220 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11221 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11222 Update.
11223 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11224 (expand_symtab_containing_pc, lookup_objfile_from_block)
11225 (lookup_static_symbol, basic_lookup_transparent_type)
11226 (find_pc_sect_compunit_symtab, find_symbol_at_address)
11227 (find_line_symtab, info_sources_command)
11228 (default_collect_symbol_completion_matches_break_on)
11229 (make_source_files_completion_list, find_main_name): Update.
11230 * symmisc.c (print_symbol_bcache_statistics)
11231 (print_objfile_statistics, maintenance_print_symbols)
11232 (maintenance_print_msymbols, maintenance_print_objfiles)
11233 (maintenance_info_symtabs, maintenance_check_symtabs)
11234 (maintenance_expand_symtabs, maintenance_info_line_tables):
11235 Update.
11236 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11237 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11238 (map_overlay_command, unmap_overlay_command)
11239 (simple_overlay_update, expand_symtabs_matching)
11240 (map_symbol_filenames): Update.
11241 * symfile-debug.c (set_debug_symfile): Update.
11242 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11243 Update.
11244 * source.c (select_source_symtab, forget_cached_source_info):
11245 Update.
11246 * solib.c (solib_read_symbols): Update.
11247 * solib-spu.c (append_ocl_sos): Update.
11248 * psymtab.c (maintenance_print_psymbols)
11249 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11250 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11251 * printcmd.c (info_symbol_command): Update.
11252 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11253 Update.
11254 * objfiles.h (class all_objfiles): Remove.
11255 * objfiles.c (have_partial_symbols, have_full_symbols)
11256 (have_minimal_symbols, qsort_cmp, update_section_map)
11257 (shared_objfile_contains_address_p)
11258 (default_iterate_over_objfiles_in_search_order): Update.
11259 * objc-lang.c (info_selectors_command, info_classes_command)
11260 (find_methods): Update.
11261 * minsyms.c (find_solib_trampoline_target): Update.
11262 * maint.c (maintenance_info_sections)
11263 (maintenance_translate_address, count_symtabs_and_blocks):
11264 Update.
11265 * main.c (captured_main_1): Update.
11266 * linux-thread-db.c (try_thread_db_load_from_pdir)
11267 (has_libpthread): Update.
11268 * linespec.c (iterate_over_all_matching_symtabs)
11269 (search_minsyms_for_name): Update.
11270 * jit.c (jit_find_objf_with_entry_addr): Update.
11271 * hppa-tdep.c (find_unwind_entry)
11272 (hppa_lookup_stub_minimal_symbol): Update.
11273 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11274 Update.
11275 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11276 (elf_gnu_ifunc_resolve_by_got): Update.
11277 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11278 * dwarf-index-write.c (save_gdb_index_command): Update.
11279 * cp-support.c (add_symbol_overload_list_qualified): Update.
11280 * breakpoint.c (create_overlay_event_breakpoint)
11281 (create_longjmp_master_breakpoint)
11282 (create_std_terminate_master_breakpoint)
11283 (create_exception_master_breakpoint): Update.
11284 * blockframe.c (find_pc_partial_function): Update.
11285 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11286 (ada_collect_symbol_completion_matches)
11287 (ada_add_global_exceptions): Update.
11288
776489e0
TT		 112892019-01-17 Tom Tromey <tom@tromey.com>
11290
11291 * solib-target.c (lm_info_target_p): Remove typedef. Don't
11292 declare VEC.
11293 (solib_target_parse_libraries): Change return type.
11294 (library_list_start_segment, library_list_start_section)
11295 (library_list_end_library, library_list_start_library); Update.
11296 (solib_target_free_library_list): Remove.
11297 (solib_target_parse_libraries): Remove cleanup. Change return
11298 type.
11299 (solib_target_current_sos): Update.
11300
6471e7d2
TT		 113012019-01-17 Tom Tromey <tromey@bapiya>
11302
11303 * valprint.c: Replace "the the" with "the".
11304 * symtab.c: Replace "the the" with "the".
11305 * solib.c: Replace "the the" with "the".
11306 * solib-dsbt.c: Replace "the the" with "the".
11307 * linespec.c: Replace "the the" with "the".
11308 * dwarf2loc.h: Replace "the the" with "the".
11309 * amd64-windows-tdep.c: Replace "the the" with "the".
11310 * aarch64-tdep.c: Replace "the the" with "the".
11311
c24bdb02
KS		 113122019-01-16 Keith Seitz <keiths@redhat.com>
11313
11314 PR gdb/23773
11315 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11316 <builder>: Rename to ..
11317 <m_builder>: ... this and make private.
11318 (dwarf2_cu::get_builder): New method. Change all users of
11319 `builder' to use this method.
11320 (dwarf2_start_symtab): Move to ...
11321 (dwarf2_cu::start_symtab): ... here. Update all callers
11322 (setup_type_unit_groups): Move to ...
11323 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
11324 callers.
11325 (dwarf2_cu::reset_builder): New method.
11326 (process_full_compunit, process_full_type_unit): Use
11327 dwarf2_cu::reset_builder.
11328 (follow_die_offset): Record the ancestor CU if it is different
11329 from the followed DIE's CU.
11330 (follow_die_sig_1): Likewise.
11331
8d64371b
TT		 113322019-01-15 Tom Tromey <tom@tromey.com>
11333
11334 * remote.c (class remote_state) <buf>: Now a char_vector.
11335 <buf_size>: Remove.
11336 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
11337 parameter.
11338 (remote_target::getpkt_or_notif_sane_1)
11339 (remote_target::getpkt_sane)
11340 (remote_target::getpkt_or_notif_sane): Likewise.
11341 (class remote_target) <putpkt>: New overload.
11342 (remote_target::read_frame): Change type of "buf_p". Remove
11343 sizeof_p parameter.
11344 (packet_ok): New overload.
11345 (packet_check_result): New overload.
11346 Update all uses.
11347
bb277751
TT		 113482019-01-14 Tom Tromey <tom@tromey.com>
11349
11350 * remote-notif.c (handle_notification, remote_notif_ack)
11351 (remote_notif_parse): Make "buf" const.
11352 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11353 const.
11354 (remote_notif_parse, remote_notif_ack, handle_notification):
11355 Likewise.
11356 * remote.c (remote_notif_stop_parse): Make "buf" const.
11357 (remote_target::remote_parse_stop_reply): Make "buf" const.
11358 (remote_notif_stop_ack): Make "buf" const.
11359
05be00a8
TT		 113602019-01-14 Tom Tromey <tom@tromey.com>
11361
11362 * remote.c (remote_console_output): Make parameter const.
11363
491adeca
TT		 113642019-01-14 Tom Tromey <tom@tromey.com>
11365
11366 * target-debug.h (target_debug_print_signals): Constify.
11367 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11368 * procfs.c (procfs_target::pass_signals): Update.
11369 * linux-nat.c (linux_nat_target::pass_signals): Update.
11370 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11371 * target-delegates.c: Rebuild.
11372 * remote.c (remote_target::program_signals): Update.
11373 (remote_target::pass_signals): Update.
11374 * target.c (target_pass_signals): Constify argument.
11375 (target_program_signals): Likewise.
11376 * target.h (struct target_ops) <pass_signals, program_signals>:
11377 Constify argument.
11378 (target_pass_signals, target_program_signals): Constify argument.
11379
bbd94648
TT		 113802019-01-14 Tom Tromey <tom@tromey.com>
11381
11382 PR tui/28819:
11383 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11384
6f072a10
PFC		 113852019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
11386
11387 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11388 field.
11389 * rs6000-tdep.c: Include reggroups.h.
11390 (IS_V_ALIAS_PSEUDOREG): Define.
11391 (rs6000_register_name): Return names for the "vX" aliases.
11392 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11393 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
11394 aliases. Call default_register_reggroup_p for all other
11395 pseudo-registers.
11396 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11397 New functions.
11398 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11399 Handle "vX" aliases.
11400 (v_alias_pseudo_register_collect): New function.
11401 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11402 (rs6000_gdbarch_init): Initialize "vX" aliases as
11403 pseudo-registers. Restore registration of
11404 rs6000_pseudo_register_reggroup_p with
11405 set_tdesc_pseudo_register_reggroup_p.
11406
1a782351
MF		 114072019-01-13 Max Filippov <jcmvbkbc@gmail.com>
11408
11409 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11410 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11411 set_gdbarch_num_pseudo_regs.
11412
d73cff18
PW		 114132019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11414
11415 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11416 Remove arg prefixname, add do_set and do_show.
11417 Add member functions set_list and show_list.
11418 * cli/cli-style.c (class cli_style_option): Update accordingly.
11419 (style_set_list): Move to file scope.
11420 (style_show_list): Likewise.
11421 (set_style): Call help_list.
11422 (show_style): Call cmd_show_list.
11423 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11424 Update to use the new macro.
11425
60a90376
JB		 114262019-10-12 Joel Brobecker <brobecker@adacore.com>
11427
11428 * ada-lang.c (_initialize_ada_language): Expand the help text
11429 for the "catch exception" command.
11430
9d7c67bf
PW		 114312019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11432
11433 * symtab.c (matching_obj_sections): Initialize obj,
11434 declare it closer to its usage.
11435
7cf47dc4
TT		 114362019-01-10 Tom Tromey <tom@tromey.com>
11437
11438 * thread-iter.h (inf_threads_iterator): Use next_iterator.
11439 (basic_inf_threads_range): Remove.
11440 (inf_threads_range, inf_non_exited_threads_range)
11441 (safe_inf_threads_range): Use next_adapter.
11442
d3cb6808
KS		 114432019-01-10 Keith Seitz <keiths@redhat.com>
11444
11445 PR gdb/23712
11446 PR symtab/23010
11447 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11448 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11449
63a20375
KS		 114502019-01-10 Keith Seitz <keiths@redhat.com>
11451
11452 PR gdb/23712
11453 PR symtab/23010
11454 * dictionary.c (pending_to_vector): Remove.
11455 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11456 Remove _1 suffix, replacing functions of the same name. Update
11457 all callers.
11458 (dict_create_hashed, dict_create_hashed_expandable)
11459 (dict_create_linear, dict_create_linear_expandable, dict_free)
11460 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11461 Make functions static.
11462
b026f593
KS		 114632019-01-10 Keith Seitz <keiths@redhat.com>
11464
11465 PR gdb/23712
11466 PR symtab/23010
11467 * dictionary.h (struct dictionary): Replace declaration with
11468 multidictionary.
11469 (dict_create_hashed, dict_create_hashed_expandable)
11470 (dict_create_linear, dict_create_linear_expandable)
11471 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11472 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11473 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11474 taking multidictionary argument.
11475 [ALL_DICT_SYMBOLS]: Update for multidictionary.
11476 * block.h (struct block) <dict>: Change to multidictionary
11477 and rename `multidict'.
11478 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11479 symmisc.c: Update all dictionary references to multidictionary.
11480
c7748ee9
KS		 114812019-01-10 Keith Seitz <keiths@redhat.com>
11482
11483 PR gdb/23712
11484 PR symtab/23010
11485 * dictionary.c: Include unordered_map.
11486 (pending_to_vector): New function.
11487 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11488 Rewrite the non-"_1" functions to take vector instead
11489 of linked list.
11490 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11491 "new" _1 versions of the same name.
11492 (multidictionary): Define.
11493 (std::hash<enum language): New definition.
11494 (collate_pending_symbols_by_language, mdict_create_hashed)
11495 (mdict_create_hashed_expandable, mdict_create_linear)
11496 (mdict_create_linear_expandable, mdict_free)
11497 (find_language_dictionary, create_new_language_dictionary)
11498 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11499 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11500 (mdict_size, mdict_empty): New functions.
11501 * dictionary.h (mdict_iterator): Define.
11502
67aa1f3c
PA		 115032019-01-10 Pedro Alves <palves@redhat.com>
11504
11505 * breakpoint.c (read_uploaded_action)
11506 (create_tracepoint_from_upload): Adjust to use
11507 gdb::unique_xmalloc_ptr.
11508 * ctf.c (ctf_write_uploaded_tp):
11509 (SET_ARRAY_FIELD): Use emplace_back.
11510 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11511 * tracefile-tfile.c (tfile_write_uploaded_tp):
11512 * tracepoint.c (parse_tracepoint_definition): Adjust to use
11513 gdb::unique_xmalloc_ptr.
11514 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11515 at_string, cond_string, cmd_strings>: Replace char pointers
11516 with gdb::unique_xmalloc_ptr.
11517
2f667667
PA		 115182019-01-10 Pedro Alves <palves@redhat.com>
11519
11520 * solib-target.c (library_list_start_library): Don't xstrdup name.
11521
36cb7237
PA		 115222019-01-10 Pedro Alves <palves@redhat.com>
11523
11524 * mdebugread.c (parse_partial_symbols): Use
11525 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11526
da584958
AB		 115272019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11528
11529 * linux-fork.c (scoped_switch_fork_info)
11530 <~scoped_switch_fork_info>: Fix incorrect variable name.
11531
1ef8573c
AB		 115322019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11533
11534 * linux-fork.c (scoped_switch_fork_info)
11535 <scoped_switch_fork_info>: Make explicit.
11536 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11537
8d7bcccb
TT		 115382019-01-10 Tom Tromey <tom@tromey.com>
11539
11540 * objfiles.h (objfile::reset_psymtabs): Update.
11541 * objfiles.c (objfile::objfile): Update.
11542 * psymtab.h (psymtab_storage::obstack): Update.
11543 (psymtab_storage::m_obstack): Use gdb::optional.
11544 (class psymtab_storage): Update comment. Remove objfile
11545 parameter.
11546 * psymtab.c (psymtab_storage::psymtab_storage): Update.
11547
b596a3c7
TT		 115482019-01-10 Tom Tromey <tom@tromey.com>
11549
11550 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11551 <free_psymtabs>: Now private.
11552 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11553 (allocate_psymtab): Use new method.
11554
a9342b62
TT		 115552019-01-10 Tom Tromey <tom@tromey.com>
11556
11557 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11558 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11559 * mdebugread.c (parse_partial_symbols): Use
11560 allocate_dependencies.
11561 * dwarf2read.c (dwarf2_create_include_psymtab): Use
11562 allocate_dependencies.
11563 (process_psymtab_comp_unit_reader)
11564 (build_type_psymtab_dependencies): Likewise.
11565 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11566
5af70966
TT		 115672019-01-10 Tom Tromey <tom@tromey.com>
11568
11569 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11570 PSYMBOL_SET_LANGUAGE.
11571 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11572
5923a04c
TT		 115732019-01-10 Tom Tromey <tom@tromey.com>
11574
11575 * psymtab.h (psymtab_storage::obstack): New method.
11576 <m_obstack>: Rename from obstack; now private.
11577 * psymtab.c (psymtab_storage): Update.
11578 * dwarf2read.c (create_addrmap_from_index)
11579 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11580 Update.
11581
6d6a12bf
TT		 115822019-01-10 Tom Tromey <tom@tromey.com>
11583
11584 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11585 * objfiles.h (objfile::reset_psymtabs): New method.
11586
d320c2b5
TT		 115872019-01-10 Tom Tromey <tom@tromey.com>
11588
11589 * symmisc.c (print_symbol_bcache_statistics): Update.
11590 (print_objfile_statistics): Update.
11591 * symfile.c (reread_symbols): Update.
11592 * psymtab.h (class psymtab_storage): New.
11593 * psymtab.c (psymtab_storage): New constructor.
11594 (~psymtab_storage): New destructor.
11595 (require_partial_symbols): Update.
11596 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11597 (find_pc_sect_psymtab, find_pc_sect_psymbol)
11598 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11599 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11600 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11601 (start_psymtab_common, end_psymtab_common)
11602 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11603 (allocate_psymtab): Update.
11604 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11605 Update.
11606 (dump_psymtab_addrmap, maintenance_print_psymbols)
11607 (maintenance_check_psymtabs): Update.
11608 (class objfile_psymtabs): Move to objfiles.h.
11609 * psympriv.h (discard_psymtab): Now inline.
11610 (psymtab_discarder::psymtab_discarder): Update.
11611 (psymtab_discarder::~psymtab_discarder): Update.
11612 (ALL_OBJFILE_PSYMTABS): Rewrite.
11613 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11614 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11615 Remove fields.
11616 <partial_symtabs>: New field.
11617 (class objfile_psymtabs): Move from psymtab.h. Update.
11618 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11619 psymbol_cache.
11620 (objfile::~objfile): Don't destroy psymbol_cache.
11621 * mdebugread.c (parse_partial_symbols): Update.
11622 * dwarf2read.c (create_addrmap_from_index)
11623 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11624 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11625 (add_partial_subprogram, dwarf2_ranges_read): Update.
11626 * dwarf-index-write.c (write_address_map)
11627 (write_one_signatured_type, recursively_write_psymbols)
11628 (class debug_names, class debug_names, write_psymtabs_to_index):
11629 Update.
11630
1d94a5a3
TT		 116312019-01-10 Tom Tromey <tom@tromey.com>
11632
11633 * symtab.h (SYMBOL_SET_NAMES): Update.
11634 (symbol_set_names): Update.
11635 (MSYMBOL_SET_NAMES): Update.
11636 * symtab.c (symbol_set_names): Change argument to be an
11637 objfile_per_bfd_storage.
11638 * psymtab.c (add_psymbol_to_bcache): Update.
11639 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11640
0f14768a
TT		 116412019-01-10 Tom Tromey <tom@tromey.com>
11642
11643 * symtab.c (create_demangled_names_hash): Change argument to be an
11644 objfile_per_bfd_storage.
11645 (symbol_set_names): Update.
11646
6eee24ce
TT		 116472019-01-10 Tom Tromey <tom@tromey.com>
11648
11649 * xcoffread.c (xcoff_initial_scan): Unconditionally call
11650 init_psymbol_list.
11651 * psymtab.c (init_psymbol_list): Do nothing if already called.
11652 * psympriv.h (init_psymbol_list): Add comment.
11653 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11654 init_psymbol_list.
11655 * dbxread.c (dbx_symfile_read): Unconditionally call
11656 init_psymbol_list.
11657
75aedd27
TT		 116582019-01-10 Tom Tromey <tom@tromey.com>
11659
11660 * xcoffread.c (scan_xcoff_symtab): Update.
11661 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11662 "where".
11663 * mdebugread.c (parse_partial_symbols)
11664 (handle_psymbol_enumerators): Update.
11665 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11666 * dbxread.c (read_dbx_symtab): Update.
11667 * psympriv.h (psymbol_placement): New enum.
11668 (add_psymbol_to_list): Update.
11669
939652a5
TT		 116702019-01-10 Tom Tromey <tom@tromey.com>
11671
11672 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11673 static_psymbols parameters.
11674 (scan_xcoff_symtab): Update.
11675 * psymtab.c (start_psymtab_common): Remove global_psymbols and
11676 static_psymbols parameters.
11677 * psympriv.h (start_psymtab_common): Update.
11678 * mdebugread.c (parse_partial_symbols): Update.
11679 * dwarf2read.c (create_partial_symtab): Update.
11680 * dbxread.c (read_dbx_symtab): Update.
11681 (start_psymtab): Remove global_psymbols and static_psymbols
11682 parameters.
11683
baa62830
TT		 116842019-01-10 Tom Tromey <tom@tromey.com>
11685
11686 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11687 * psymtab.c (allocate_psymtab): Add comment.
11688 * psympriv.h (allocate_psymtab): Add comment.
11689 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11690 initializations.
11691 * dbxread.c (dbx_end_psymtab): Remove some initializations.
11692
0e8f53ba
TT		 116932019-01-10 Tom Tromey <tom@tromey.com>
11694
11695 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11696 Don't declare.
11697 * mipsread.c: Include mdebugread.h.
11698 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11699 Declare.
11700 * elfread.c: Include mdebugread.h.
11701
b22a7c6a
TT		 117022019-01-09 Tom Tromey <tom@tromey.com>
11703
11704 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11705 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11706 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11707 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11708 (psym_lookup_symbol, psym_find_last_source_symtab)
11709 (psym_forget_cached_source_info, psym_print_stats)
11710 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11711 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11712 (psym_map_matching_symbols, psym_expand_symtabs_matching)
11713 (psym_find_compunit_symtab_by_address)
11714 (maintenance_print_psymbols, maintenance_info_psymtabs)
11715 (maintenance_check_psymtabs): Use ranged for.
11716 * psymtab.h (class objfile_psymtabs): New.
11717 (require_partial_symbols): Return objfile_psymtabs.
11718 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11719
3b9d3ac2
TT		 117202019-01-09 Tom Tromey <tom@tromey.com>
11721
11722 * symfile.c (overlay_invalidate_all, find_pc_overlay)
11723 (find_pc_mapped_section, list_overlays_command)
11724 (map_overlay_command, unmap_overlay_command)
11725 (simple_overlay_update): Use all_objfiles.
11726 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11727 * printcmd.c (info_symbol_command): Use all_objfiles.
11728 * objfiles.h (ALL_OBJSECTIONS): Remove.
11729 * maint.c (maintenance_translate_address): Use all_objfiles.
11730 * gcore.c (gcore_create_callback): Use all_objfiles.
11731 (objfile_find_memory_regions): Likewise.
11732
8b31193a
TT		 117332019-01-09 Tom Tromey <tom@tromey.com>
11734
11735 * symtab.c (find_line_symtab, info_sources_command)
11736 (make_source_files_completion_list): Use objfile_compunits.
11737 * source.c (select_source_symtab): Use objfile_compunits.
11738 * objfiles.h (struct objfile): Update comment.
11739 (ALL_OBJFILES): Remove.
11740 (ALL_FILETABS): Remove.
11741 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11742 objfile_compunits.
11743
d5da8b3c
TT		 117442019-01-09 Tom Tromey <tom@tromey.com>
11745
11746 * symmisc.c (print_objfile_statistics, dump_objfile)
11747 (maintenance_print_symbols): Use compunit_filetabs.
11748 * source.c (forget_cached_source_info_for_objfile): Use
11749 compunit_filetabs.
11750 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11751 (ALL_FILETABS): Use compunit_filetabs.
11752 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11753 * coffread.c (coff_symtab_read): Use compunit_filetabs.
11754
5accd1a0
TT		 117552019-01-09 Tom Tromey <tom@tromey.com>
11756
11757 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11758 (compunit_filetabs): New.
11759 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11760 compunit_filetabs.
11761 (info_sources_command, make_source_files_completion_list): Remove
11762 declaration.
11763 * symmisc.c (print_objfile_statistics, dump_objfile)
11764 (maintenance_print_symbols): Remove declaration.
11765 (maintenance_info_symtabs): Use compunit_filetabs.
11766 (maintenance_info_line_tables): Likewise.
11767 * source.c (select_source_symtab): Change local variable name.
11768 (forget_cached_source_info_for_objfile): Remove declaration.
11769 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11770 * objfiles.c (objfile_relocate1): Remove declaration.
11771 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11772 declaration.
11773 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11774 * coffread.c (coff_symtab_read): Remove declaration.
11775 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11776 compunit_filetabs.
11777
d8aeb77f
TT		 117782019-01-09 Tom Tromey <tom@tromey.com>
11779
11780 * symtab.c (lookup_objfile_from_block)
11781 (find_pc_sect_compunit_symtab, search_symbols)
11782 (default_collect_symbol_completion_matches_break_on): Use
11783 objfile_compunits.
11784 * objfiles.h (ALL_COMPUNITS): Remove.
11785 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11786 * cp-support.c (add_symbol_overload_list_qualified): Use
11787 objfile_compunits.
11788 * ada-lang.c (ada_collect_symbol_completion_matches)
11789 (ada_add_global_exceptions): Use objfile_compunits.
11790
592553c4
TT		 117912019-01-09 Tom Tromey <tom@tromey.com>
11792
11793 * source.c (select_source_symtab)
11794 (forget_cached_source_info_for_objfile): Remove declaration.
11795 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11796 declaration.
11797 * maint.c (count_symtabs_and_blocks): Remove declaration.
11798 * cp-support.c (add_symbol_overload_list_qualified): Remove
11799 declaration.
11800 * coffread.c (coff_symtab_read): Remove declaration.
11801 * symtab.c (lookup_symbol_in_objfile_symtabs)
11802 (basic_lookup_transparent_type_1): Use objfile_compunits.
11803 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11804 (info_sources_command, search_symbols)
11805 (default_collect_symbol_completion_matches_break_on)
11806 (make_source_files_completion_list): Remove declaration.
11807 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11808 (ada_collect_symbol_completion_matches)
11809 (ada_add_global_exceptions): Remove declaration.
11810 * linespec.c (iterate_over_all_matching_symtabs): Use
11811 objfile_compunits.
11812 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11813 (class objfile_compunits): New.
11814 (ALL_COMPUNITS): Use objfile_compunits.
11815 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11816 (maintenance_check_symtabs, maintenance_info_line_tables): Use
11817 objfile_compunits.
11818 * objfiles.c (objfile_relocate1): Use objfile_compunits.
11819
5325b9bf
TT		 118202019-01-09 Tom Tromey <tom@tromey.com>
11821
11822 * symtab.c (search_symbols)
11823 (default_collect_symbol_completion_matches_break_on): Use
11824 objfile_msymbols.
11825 * ada-lang.c (ada_lookup_simple_minsym)
11826 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11827 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11828 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11829 objfile_msymbols.
11830 * coffread.c (coff_symfile_read): Use objfile_msymbols.
11831 * symmisc.c (dump_msymbols): Use objfile_msymbols.
11832 * objc-lang.c (find_methods): Use objfile_msymbols.
11833 (info_selectors_command, info_classes_command): Likewise.
11834 * stabsread.c (scan_file_globals): Use objfile_msymbols.
11835 * objfiles.h (class objfile_msymbols): New.
11836 (ALL_OBJFILE_MSYMBOLS): Remove.
11837 (ALL_MSYMBOLS): Remove.
11838
cac85af2
TT		 118392019-01-09 Tom Tromey <tom@tromey.com>
11840
11841 * common/next-iterator.h (next_adapter): Add Iterator template
11842 parameter.
11843 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11844 (class all_objfiles_safe): New.
11845 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11846 * objfiles.c (put_objfile_before): Update comment.
11847 (add_separate_debug_objfile): Likewise.
11848 (free_all_objfiles): Use all_objfiles_safe.
11849 (objfile_purge_solibs): Likewise.
11850
aed57c53
TT		 118512019-01-09 Tom Tromey <tom@tromey.com>
11852
11853 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11854 (expand_symtab_containing_pc, lookup_static_symbol)
11855 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11856 (find_symbol_at_address, find_line_symtab, find_main_name): Use
11857 all_objfiles.
11858 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11859 * breakpoint.c (create_overlay_event_breakpoint)
11860 (create_longjmp_master_breakpoint)
11861 (create_std_terminate_master_breakpoint)
11862 (create_exception_master_breakpoint): Use all_objfiles.
11863 * linux-thread-db.c (try_thread_db_load_from_pdir)
11864 (has_libpthread): Use all_objfiles.
11865 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11866 * linespec.c (iterate_over_all_matching_symtabs)
11867 (search_minsyms_for_name): Use all_objfiles.
11868 * maint.c (maintenance_info_sections): Use all_objfiles.
11869 * main.c (captured_main_1): Use all_objfiles.
11870 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11871 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11872 * guile/scm-pretty-print.c
11873 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11874 * solib-spu.c (append_ocl_sos): Use all_objfiles.
11875 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11876 (maintenance_print_msymbols): Use all_objfiles.
11877 * source.c (select_source_symtab): Use all_objfiles.
11878 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11879 * symfile.c (remove_symbol_file_command)
11880 (expand_symtabs_matching, map_symbol_filenames): Use
11881 all_objfiles.
11882 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11883 all_objfiles.
11884 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11885 * objc-lang.c (find_methods): Use all_objfiles.
11886 * objfiles.c (have_partial_symbols, have_full_symbols)
11887 (have_minimal_symbols, qsort_cmp)
11888 (default_iterate_over_objfiles_in_search_order): Use
11889 all_objfiles.
11890 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11891 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11892 (maintenance_check_psymtabs): Use all_objfiles.
11893 (ALL_PSYMTABS): Remove.
11894 * compile/compile-object-run.c (do_module_cleanup): Use
11895 all_objfiles.
11896 * blockframe.c (find_pc_partial_function): Use all_objfiles.
11897 * cp-support.c (add_symbol_overload_list_qualified): Use
11898 all_objfiles.
11899 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11900 Use all_objfiles.
11901 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11902 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11903 all_objfiles.
11904 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11905 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11906 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11907 Uses all_objfiles.
11908 * solib.c (solib_read_symbols): Use all_objfiles
11909
99d89cde
TT		 119102019-01-09 Tom Tromey <tom@tromey.com>
11911
11912 * probe.c (parse_probes_in_pspace): Use all_objfiles.
11913 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11914 all_objfiles.
11915 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11916 * symmisc.c (print_symbol_bcache_statistics)
11917 (print_objfile_statistics, maintenance_print_objfiles)
11918 (maintenance_info_symtabs, maintenance_check_symtabs)
11919 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11920 all_objfiles.
11921 * source.c (forget_cached_source_info): Use all_objfiles.
11922 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11923 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11924 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11925 * objfiles.c (update_section_map): Use all_objfiles.
11926 (shared_objfile_contains_address_p): Likewise.
11927 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11928 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11929
21708325
TT		 119302019-01-09 Tom Tromey <tom@tromey.com>
11931
11932 * common/next-iterator.h: New file.
11933 * objfiles.h (class all_objfiles): New.
11934 (struct objfile_iterator): New.
11935
669e09f6
PW		 119362019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11937
11938 * NEWS: Move the description of the changed "frame", "select-frame",
11939 and "info frame" commands to the Changed commands section.
11940
041be526
SM		 119412019-01-09 Simon Marchi <simon.marchi@ericsson.com>
11942
11943 * gdbtypes.c (check_stub_method_group): Remove handling of old
11944 mangling schemes.
11945 * linespec.c (find_methods): Likewise.
11946 * stabsread.c (read_member_functions): Likewise.
11947 * valops.c (search_struct_method): Likewise.
11948 (value_struct_elt_for_reference): Likewise.
11949 * NEWS: Mention this change.
11950
0e2a2133
AB		 119512019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
11952
11953 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11954 print_source_lines.
11955 * source.c (print_source_lines_base): Update line number check.
11956 (print_source_lines): New function.
11957 (source_lines_range::source_lines_range): New function.
11958 * source.h (class source_lines_range): New class.
11959 (print_source_lines): New declaration.
11960
1055a3b4
PW		 119612019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11962
11963 * linespec.c (linespec_state_destructor): Free self->canonical_names.
11964
cfeadda5
TT		 119652019-01-08 Tom Tromey <tom@tromey.com>
11966 Simon Marchi <simon.marchi@ericsson.com>
11967
11968 PR gdb/24060
11969 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11970 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11971 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11972 * f-exp.y (DOLLAR_VARIABLE): Likewise.
11973 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11974 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11975
583068ca
AB		 119762019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11977
11978 * source.c (select_source_symtab): Move header comment to
11979 declaration in source.h.
11980 (forget_cached_source_info_for_objfile): Likewise.
11981 (forget_cached_source_info): Likewise.
11982 (identify_source_line): Likewise.
11983 * source.h (identify_source_line): Move declaration from symtab.h
11984 and add comment from source.c
11985 (print_source_lines): Likewise.
11986 (forget_cached_source_info_for_objfile): Likewise.
11987 (forget_cached_source_info): Likewise.
11988 (select_source_symtab): Likewise.
11989 (enum print_source_lines_flag): Move definition from symtab.h.
11990 * symtab.h (identify_source_line): Move declaration to source.h.
11991 (print_source_lines): Likewise.
11992 (forget_cached_source_info_for_objfile): Likewise.
11993 (forget_cached_source_info): Likewise.
11994 (select_source_symtab): Likewise.
11995 (enum print_source_lines_flag): Move definition to source.h.
11996 * tui/tui-hooks.c: Add 'source.h' include.
11997
ec98a4ad
AB		 119982019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11999
12000 * source.c (print_source_lines_base): Handle requests to print
12001 reverse line number sequences, and guard against empty lines
12002 string.
12003
62ea19c1
AB		 120042019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12005
12006 * source.c (print_source_lines_base): Fix skip of '\r' if next
12007 character is '\n'.
12008
9d30e1fd
TT		 120092019-01-06 Tom Tromey <tom@tromey.com>
12010
12011 * c-exp.y (struct c_parse_state) <macro_original_text,
12012 expansion_obstack>: New member.
12013 (macro_original_text, expansion_obstack): Remove globals.
12014 (scan_macro_expansion, scanning_macro_expansion)
12015 (finished_macro_expansion): Update.
12016 (scan_macro_cleanup): Remove.
12017 (yylex, c_parse): Update.
12018
c65bac38
TT		 120192019-01-06 Tom Tromey <tom@tromey.com>
12020
12021 * c-exp.y (struct c_parse_state) <strings>: New member.
12022 (operator_stoken): Update.
12023
02e12e38
TT		 120242019-01-06 Tom Tromey <tom@tromey.com>
12025
12026 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
12027 (union type_stack_elt) <typelist_val>: Now a pointer to
12028 std::vector.
12029 (type_stack_cleanup): Don't declare.
12030 (push_typelist): Update.
12031 * parse.c (pop_typelist): Return a std::vector.
12032 (push_typelist): Take a std::vector.
12033 (follow_types): Update. Do not free args.
12034 (type_stack_cleanup): Remove.
12035 * c-exp.y (struct c_parse_state): New.
12036 (cpstate): New global.
12037 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12038 (nonempty_typelist): Update.
12039 (func_mod): Create a new vector.
12040 (c_parse): Create a c_parse_state.
12041 (check_parameter_typelist): Do not delete params.
12042 (function_method): Update. Do not delete type_list.
12043
f097f5ad
TT		 120442019-01-06 Tom Tromey <tom@tromey.com>
12045
12046 PR gdb/28155:
12047 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12048 check_typedef.
12049 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12050 (print_return_value): Likewise.
12051
d2adf9f1
TT		 120522019-01-05 Tom Tromey <tom@tromey.com>
12053
12054 * contrib/cleanup_check.py: Remove.
12055 * contrib/gcc-with-excheck: Remove.
12056 * contrib/exsummary.py: Remove.
12057 * contrib/excheck.py: Remove.
12058
2eab46b1
JB		 120592019-01-05 Joel Brobecker <brobecker@adacore.com>
12060
12061 * thread.c (delete_thread_1): Add gdb_assert that THR is not
12062 NULL. Initialize tpprev to NULL instead of assigning it
12063 to NULL on the next statement.
12064 * windows-nat.c (windows_delete_thread): Remove check for
12065 main_thread_id before printing thread exit notifications.
12066 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12067 Remove thread ID check against main_thread_id.
12068 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12069 windows_delete_thread.
12070 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12071
48c5e7e2
TT		 120722019-01-04 Tom Tromey <tom@tromey.com>
12073
12074 * compile/compile.c (_initialize_compile): Use upper case for
12075 metasyntactic variables.
12076 * symmisc.c (_initialize_symmisc): Use upper case for
12077 metasyntactic variables.
12078 * psymtab.c (_initialize_psymtab): Use upper case for
12079 metasyntactic variables.
12080 * demangle.c (demangle_command): Use upper case for metasyntactic
12081 variables.
12082 (_initialize_demangler): Likewise.
12083 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12084 variables.
12085
986041cd
TT		 120862019-01-03 Tom Tromey <tom@tromey.com>
12087
12088 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12089
7c711119
TT		 120902019-01-03 Tom Tromey <tom@tromey.com>
12091
12092 * python/py-symtab.c (salpy_str): Update.
12093 (struct salpy_sal_object) <symtab>: Now a PyObject.
12094 (salpy_dealloc): Update.
12095 (del_objfile_sal): Use gdbpy_ref.
12096
1b20edf0
TT		 120972019-01-03 Tom Tromey <tom@tromey.com>
12098
12099 * python/py-type.c (convert_field): Use new_reference. Return
12100 gdbpy_ref.
12101 (make_fielditem): Return gdbpy_ref.
12102 (typy_fields): Update.
12103 (typy_getitem): Update.
12104 (field_name): Return gdbpy_ref. Use new_reference.
12105 (typy_iterator_iternext): Update.
12106
ea41325b
TT		 121072019-01-03 Tom Tromey <tom@tromey.com>
12108
12109 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12110
2a3c71d6
TT		 121112019-01-03 Tom Tromey <tom@tromey.com>
12112
12113 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12114 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12115 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12116 (pspy_set_frame_filters, pspy_set_frame_unwinders)
12117 (pspy_set_type_printers): Likewise.
12118 * python/py-function.c (fnpy_init): Use gdbpy_ref.
12119 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12120 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12121 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12122 (objfpy_set_type_printers): Likewise.
12123
5c329e6a
TT		 121242019-01-03 Tom Tromey <tom@tromey.com>
12125
12126 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12127 (gdbpy_print_stack): Use gdbpy_err_fetch.
12128 * python/python-internal.h (class gdbpy_err_fetch): New class.
12129 (class gdbpy_enter) <m_error_type, m_error_value,
12130 m_error_traceback>: Remove.
12131 <m_error>: New member.
12132 (gdbpy_exception_to_string): Don't declare.
12133 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12134 * python/py-value.c (convert_value_from_python): Use
12135 gdbpy_err_fetch.
12136 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12137 gdbpy_exception_to_string.
12138 (gdbpy_handle_exception): Use gdbpy_err_fetch.
12139 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12140 gdbpy_err_fetch.
12141
169bb27b
AB		 121422019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12143
12144 * linux-nat.c (delete_lwp_cleanup): Delete.
12145 (struct lwp_deleter): New struct.
12146 (lwp_info_up): New typedef.
12147 (linux_nat_target::follow_fork): Delete cleanup, and make use of
12148 lwp_info_up.
12149
a07c8880
AB		 121502019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12151
12152 * linux-fork.c (class scoped_switch_fork_info): New class.
12153 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12154
26089c49
AB		 121552019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12156
12157 * valops.c (find_overload_match): Remove use of null_cleanup, and
12158 calls to do_cleanups.
12159
06d3e5b0
AB		 121602019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12161
12162 * compile/compile-cplus-types.c
12163 (compile_cplus_instance::decl_name): Handle changes to
12164 cp_func_name.
12165 * cp-support.c (cp_func_name): Update header comment, update
12166 return type.
12167 * cp-support.h (cp_func_name): Update return type in declaration.
12168 * valops.c (find_overload_match): Move temp_func local to top
12169 level of function and change its type. Use temp_func to hold and
12170 delete temporary string obtained from cp_func_name.
12171
66644cd3
AB		 121722019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12173
12174 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12175 gdb::char_vector, remove cleanup, and update uses of `msg`.
12176
592d8c0a
JW		 121772019-01-03 Jim Wilson <jimw@sifive.com>
12178
12179 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12180
c55d06ec
TT		 121812019-01-02 Tom Tromey <tom@tromey.com>
12182
12183 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12184 (tdesc_parse_xml): Remove cleanups.
12185 * target-descriptions.h (make_cleanup_free_target_description):
12186 Don't declare.
12187 (target_desc_deleter): New struct.
12188 (target_desc_up): New typedef.
12189 * target-descriptions.c (target_desc_deleter::operator()): Rename
12190 from free_target_description.
12191 (make_cleanup_free_target_description): Remove.
12192
3a6ae42d
TT		 121932019-01-02 Tom Tromey <tom@tromey.com>
12194
12195 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
12196 constructor, destructor.
12197 (linespec_parser): Remove typedef.
12198 (~linespec_parser): Rename from linespec_parser_delete.
12199 (linespec_lex_to_end, linespec_complete_label)
12200 (linespec_complete): Update.
12201 (decode_line_full): Remove cleanups.
12202 (decode_line_1): Update.
12203
61fd3e73
TT		 122042019-01-02 Tom Tromey <tom@tromey.com>
12205
12206 * python/python-internal.h (inferior_to_inferior_object): Change
12207 return type.
12208 * python/py-exitedevent.c (create_exited_event_object): Update.
12209 * python/py-inferior.c (inferior_to_inferior_object): Return
12210 gdbpy_ref.
12211 (python_new_inferior, python_inferior_deleted)
12212 (thread_to_thread_object, delete_thread_object)
12213 (build_inferior_list, gdbpy_selected_inferior): Update.
12214 * python/py-infthread.c (create_thread_object): Update. Also fail
12215 if inferior_to_inferior_object fails.
12216
d20172fc
SM		 122172019-01-02 Simon Marchi <simon.marchi@ericsson.com>
12218
12219 * inferior.h (class inferior) <displaced_step_state>: New field.
12220 * infrun.h (struct displaced_step_state): Move here from
12221 infrun.c. Initialize fields, add constructor.
12222 <inf>: Remove field.
12223 <reset>: New method.
12224 * infrun.c (struct displaced_step_inferior_state): Move to
12225 infrun.h.
12226 (displaced_step_inferior_states): Remove.
12227 (get_displaced_stepping_state): Adust.
12228 (displaced_step_in_progress_any_inferior): Adjust.
12229 (displaced_step_in_progress_thread): Adjust.
12230 (displaced_step_in_progress): Adjust.
12231 (add_displaced_stepping_state): Remove.
12232 (get_displaced_step_closure_by_addr): Adjust.
12233 (remove_displaced_stepping_state): Remove.
12234 (infrun_inferior_exit): Call displaced_step_state.reset.
12235 (use_displaced_stepping): Don't check for NULL.
12236 (displaced_step_prepare_throw): Call
12237 get_displaced_stepping_state.
12238 (displaced_step_fixup): Don't check for NULL.
12239 (prepare_for_detach): Don't check for NULL.
12240
e3319240
PW		 122412019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12242
12243 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12244 in case of call that did not complete.
12245
5d36dfb9
AU		 122462019-01-02 Andrey Utkin <autkin@undo.io>
12247
12248 * symfile.c (find_separate_debug_file): Fix search of debug files for
12249 remote debuggee.
12250
8833fbf0
TT		 122512019-01-02 Tom Tromey <tom@tromey.com>
12252
12253 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12254 indentation.
12255 * python/py-frame.c (frapy_older): Remove cast.
12256 (frapy_newer): Likewise.
12257 * python/py-breakpoint.c (local_setattro): Remove cast.
12258 * python/py-arch.c (archpy_name): Remove local variable.
12259 * python/py-type.c (gdbpy_lookup_type): Remove cast.
12260
4ada3dfd
JB		 122612019-01-02 Joel Brobecker <brobecker@adacore.com>
12262
12263 * unittests/basic_string_view/element_access/char/empty.cc:
12264 Fix year range in copyright header.
12265
113b7b81
AB		 122662019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
12267
12268 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12269 Delete.
12270 <operator==>: Update with for removed field.
12271 <hash>: Likewise.
12272 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12273 <isa_features>: ...this.
12274 <abi_features>: New field.
12275 (riscv_isa_flen): Update comment.
12276 (riscv_abi_xlen): New declaration.
12277 (riscv_abi_flen): New declaration.
12278 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12279 isa_features.
12280 (riscv_abi_xlen): New function.
12281 (riscv_isa_flen): Update to get answer from isa_features.
12282 (riscv_abi_flen): New function.
12283 (riscv_has_fp_abi): Update to get answer from abi_features.
12284 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12285 xlen and flen.
12286 (riscv_call_info) <xlen, flen>: Update comment.
12287 (riscv_call_arg_struct): Remove invalid assertions
12288 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12289 is removed.
12290 (riscv_gdbarch_init): Gather isa features and abi features
12291 separately, ensure both match on the gdbarch when reusing an old
12292 gdbarch. Relax an error check to allow 32-bit abi float to run on
12293 a target with 64-bit float hardware.
12294
b18ca514
PW		 122952019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12296
12297 * source.c (search_command_helper): Stop reverse search
12298 when line 1 has been searched.
12299
ec70d8db
PW		 123002019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12301
12302 * record-full.c (record_full_base_target::close): Rewrite
12303 record_full_core_buf_list free logic.
12304
5b38f9c1
PW		 123052019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12306
12307 * break-catch-syscall.c (print_one_catch_syscall): xfree
12308 the last text.
12309
66d91b39
JB		 123102019-01-01 Joel Brobecker <brobecker@adacore.com>
12311
12312 * top.c (print_gdb_version): Update Copyright year in version
12313 message.
12314
42a4f53d
JB		 123152019-01-01 Joel Brobecker <brobecker@adacore.com>
12316
12317 Update copyright year range in all GDB files.
12318
7e955d83 123192019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 12320
5bbd631d 12321 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 12322
5bbd631d 12323For older changes see ChangeLog-2018.
c906108c
SS		 12324\f
12325Local Variables:
12326mode: change-log
12327left-margin: 8
12328fill-column: 74
12329version-control: never
57da7796 12330coding: utf-8
c906108c 12331End:
5bbd631d 12332
GDB Binutils - Deliverables
This page took 3.146756 seconds and 4 git commands to generate.