gdb: remove unused includes from dwarf2read.c
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
6acc1a0b
SM
12019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2
3 * dwarf2read.c: Remove includes.
4
284782de
SM
52019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
6
7 * ui-out.c (ui_out::call_do_message): Silence
8 -Wformat-nonliteral warning.
9
073bbbb0
SM
102019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
11
12 * breakpoint.c: Remove some includes: continuations.h, skip.h,
13 mi/mi-main.h, readline/readline.h, readline/history.h. Add
14 include: readline/tilde.h.
15
7b9a15e1
CB
162019-10-12 Christian Biesinger <cbiesinger@google.com>
17
18 * remote.c (remote_target::get_trace_status): Remove declaration of
19 trace_regblock_size.
20
cc8dee1f
CB
212019-10-12 Christian Biesinger <cbiesinger@google.com>
22
23 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
24 (show_user): Remove declaration of cmdlist.
25 * cli/cli-cmds.h (max_user_call_depth): Declare.
26 * cli/cli-script.c (execute_user_command): Remove declaration
27 of max_user_call_depth.
28
a83d4ef6
JW
292019-10-11 Jim Wilson <jimw@sifive.com>
30
5f93c5a6
JW
31 * gdbsupport/print-utils.h (pulongest): Fix comment.
32 (plongest): Likewise.
33 (phex): Add missing comment, mention leading zeros.
34 (phex_nz): Add mention of no leading zeros to comment.
35
a83d4ef6
JW
36 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
37 plongest instead of unsigned long long cast.
38
26344e0c
CB
392019-10-10 Christian Biesinger <cbiesinger@google.com>
40
41 * main.c (captured_main_1): Include gdbtk.h and remove declarations
42 for external_editor_command and gdbtk_test.
43
c2c440a9
CB
442019-10-10 Christian Biesinger <cbiesinger@google.com>
45
46 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
47 * varobj.c (varobjdebug): Move comment to...
48 * varobj.h (varobjdebug): ...here, and declare.
49
a31bff9d
TT
502019-10-09 Tom Tromey <tom@tromey.com>
51
52 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
53 erase_data_content.
54
7523da63
TT
552019-10-09 Tom Tromey <tom@tromey.com>
56
57 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
58 * tui/tui-stack.c (tui_locator_window::rerender): Update.
59 * tui/tui-command.c (tui_cmd_window::resize)
60 (tui_refresh_cmd_win): Update.
61 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
62 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
63 * tui/tui-data.c (~tui_gen_win_info): Remove.
64 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
65 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
66 (tui_redisplay_readline, tui_mld_flush)
67 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
68 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
69 (tui_data_window::erase_data_content)
70 (tui_data_item_window::rerender)
71 (tui_data_item_window::refresh_window): Update.
72 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
73 (box_win, tui_gen_win_info::make_window)
74 (tui_gen_win_info::make_visible): Update.
75 (tui_delete_win): Remove.
76 * tui/tui-winsource.c
77 (tui_source_window_base::do_erase_source_content): Update.
78 (tui_show_source_line, tui_source_window_base::update_tab_width)
79 (tui_source_window_base::update_exec_info): Update.
80 * tui/tui-data.h (struct curses_deleter): New.
81 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
82 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
83
a7798e7f
TT
842019-10-09 Tom Tromey <tom@tromey.com>
85
86 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
87
5c45899e
TT
882019-10-09 Tom Tromey <tom@tromey.com>
89
90 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
91 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
92
6d7fd9aa
TT
932019-10-09 Tom Tromey <tom@tromey.com>
94
95 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
96 window height directly.
97 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
98 declare.
99 * tui/tui-layout.c (tui_default_win_height): Remove.
100 (tui_default_win_viewport_height): Remove.
101
d2dd1084
TT
1022019-10-09 Tom Tromey <tom@tromey.com>
103
104 * tui/tui.h: Remove comments.
105
cff32449
TV
1062019-10-09 Tom de Vries <tdevries@suse.de>
107
108 * python/lib/gdb/printer/bound_registers.py: Use
109 '^builtin_type_bound128' as regexp argument for
110 add_builtin_pretty_printer.
111
6a25e8a2
CB
1122019-10-09 Christian Biesinger <cbiesinger@google.com>
113
114 * guile/guile.c (guile_extension_script_ops): Remove forward
115 declaration and mark as static.
116 (guile_script_ops): Likewise.
117 (extension_language_guile): Move further down in the file so
118 it can reference the definitions for guile_{extension_,}script_ops.
119
6d9d6da4
AA
1202019-10-09 Andreas Arnez <arnez@linux.ibm.com>
121
122 * s390-tdep.c (390_process_record): Handle new arch13 instructions
123 except SORTL, DFLTCC, and KDSA.
124
3abea05d
TT
1252019-10-08 Tom Tromey <tromey@adacore.com>
126
127 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
128 (struct safe_symbol_file_add_args): Remove.
129
dde996e2
TT
1302019-10-08 Tom Tromey <tromey@adacore.com>
131
132 * windows-nat.c: Don't include buildsym-legacy.h.
133
cd6fdaa1
TT
1342019-10-08 Tom Tromey <tromey@adacore.com>
135
136 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
137
79bb1944
CB
1382019-10-08 Christian Biesinger <cbiesinger@google.com>
139
140 * gdbtypes.c (overload_debug): Move comment to header.
141 * gdbtypes.h (overload_debug): Declare.
142 * valops.c: Remove declaration of overload_debug, instead
143 include gdbtypes.h.
144
34916edc
CB
1452019-10-08 Christian Biesinger <cbiesinger@google.com>
146
147 * language.c (show_language_command): Pass lang_frame_mismatch_warn
148 through _().
149 (lang_frame_mismatch_warn): Make const, mark with N_(), and
150 move comment...
151 * language.h (lang_frame_mismatch_warn): ... here. Also add
152 declaration.
153 * top.c (lang_frame_mismatch_warn): Remove declaration.
154 (check_frame_language_change): Pass lang_frame_mismatch_warn
155 through _().
156
bad5c026
CB
1572019-10-07 Christian Biesinger <cbiesinger@google.com>
158
159 * c-lang.h (vtbl_ptr_name): Declare.
160 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
161 it from the header.
162 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
163
51f1fdc3
CB
1642019-10-07 Christian Biesinger <cbiesinger@google.com>
165
166 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
167 gdb_static_assert.
168
30d1f018
WP
1692019-10-07 Weimin Pan <weimin.pan@oracle.com>
170
606813d5
WP
171 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
172 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
173 * ctfread.c: New file.
174 * ctfread.h: New file.
175 * elfread.c: Include ctfread.h.
176 (struct elfinfo text_p): New member ctfsect.
177 (elf_locate_sections): Mark CTF section.
178 (elf_symfile_read): Call elfctf_build_psymtabs.
179 * Makefile.in (LIBCTF): Add.
180 (CLIBS): Use it.
181 (CDEPS): Likewise.
182 (DIST): Add ctfread.c.
606813d5
WP
183
1842019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
185
186 * ctfread.c (struct nextfield): Renamed to ...
187 (struct ctf_nextfield): ... this.
188 (struct field_info): Renamed to ...
189 (strut ctf_field_info): ... this.
190 (attach_fields_to_type): Update for renamed structures.
191 (ctf_add_member_cb): Likewise.
192 (ctf_add_enum_member_cb): Likewise.
193 (process_struct_members): Likewise.
194 (process_enum_type): Likewise.
30d1f018 195
518fe38c
WP
1962019-10-07 Weimin Pan <weimin.pan@oracle.com>
197
198 * tracectf.h: Rename, was ctf.h.
199 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
200 * tracefile.c: Likewise.
201 * tracepoint.c: Remove unused include ctf.h.
202 * mi/mi-main.c: Likewise.
203 * Makefile.in Replace ctf.c with tracectf.c.
204
225f296a
JB
2052019-10-06 Joel Brobecker <brobecker@adacore.com>
206
207 * version.in: Change version number to "9.0.50.DATE-git".
208
77c2dba3
TT
2092019-10-03 Tom Tromey <tom@tromey.com>
210
211 PR rust/24976:
212 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
213
179aed7f
AB
2142019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
215
216 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
217 cp_search_name_hash.
218 * NEWS: Add entry about nested function support.
219
0a4b0913
AB
2202019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
221 Andrew Burgess <andrew.burgess@embecosm.com>
222
223 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
224 for nested static variables when searchin VAR_DOMAIN.
225 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
226 global scope, update comment.
227 (add_partial_subprogram): Call add_partial_subprogram recursively
228 for nested subroutines when processinng Fortran.
229 (load_partial_dies): Process the child entities of a subprogram
230 when processing Fortran.
231 (partial_die_parent_scope): Handle building scope
232 for Fortran nested functions.
233 (process_die): Record that nested functions have a scope.
234 (new_symbol): Always record Fortran subprograms on the global
235 symbol list.
236 (determine_prefix): How to build the prefix for Fortran
237 subprograms.
238
d8c06f22
AB
2392019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
240
241 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
242 have just sent the thread a SIGSTOP and are waiting for it to
243 arrive.
244
a8b3b8e9
AB
2452019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
246
247 * btrace.c (btrace_add_pc): Remove whitespace before the template
248 parameter in 'std::vector <...>'.
249 (parse_xml_btrace_block): Likewise.
250 (btrace_maint_decode_pt): Likewise.
251 (btrace_maint_update_packets): Likewise.
252 (btrace_maint_print_packets): Likewise.
253 * btrace.h (struct btrace_maint_info): Likewise.
254 * dwarf2read.c (struct type_unit_group): Likewise.
255 (build_type_psymtabs_reader): Likewise.
256 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
257 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
258 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
259
4d825eab
TV
2602019-10-03 Tom de Vries <tdevries@suse.de>
261
262 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
263 the first line of the help text for set/show style metadata.
264
80fd2826
TT
2652019-10-02 Tom Tromey <tromey@adacore.com>
266
267 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
268 * gdbsupport/common-inferior.c: New file.
269 * infcmd.c (startup_with_shell): Don't define.
270 * nat/fork-inferior.h (startup_with_shell): Don't declare.
271 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
272 * inferior.h (startup_with_shell): Don't declare.
273
70054538
CB
2742019-10-02 Christian Biesinger <cbiesinger@google.com>
275
276 * gdbsupport/gdb_assert.h: Include errors.h.
277 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
278
37f6a7f4
TT
2792019-10-02 Tom Tromey <tromey@adacore.com>
280
281 * NEWS: Add $_ada_exception entry.
282 * ada-lang.c (struct ada_catchpoint): Add constructor.
283 <m_kind>: New member.
284 (allocate_location_exception, re_set_exception): Remove
285 "ex" parameter.
286 (should_stop_exception): Compute $_ada_exception.
287 (check_status_exception, print_it_exception)
288 (print_one_exception, print_mention_exception): Remove
289 "ex" parameter.
290 (allocate_location_catch_exception, re_set_catch_exception)
291 (check_status_exception, print_it_catch_exception)
292 (print_one_catch_exception, print_mention_catch_exception)
293 (print_recreate_catch_exception)
294 (allocate_location_catch_exception_unhandled)
295 (re_set_catch_exception_unhandled)
296 (check_status_exception, print_it_catch_exception_unhandled)
297 (print_one_catch_exception_unhandled)
298 (print_mention_catch_exception_unhandled)
299 (print_recreate_catch_exception_unhandled)
300 (allocate_location_catch_assert, re_set_catch_assert)
301 (check_status_assert, print_it_catch_assert)
302 (print_one_catch_assert, print_mention_catch_assert)
303 (print_recreate_catch_assert)
304 (allocate_location_catch_handlers, re_set_catch_handlers)
305 (check_status_handlers, print_it_catch_handlers)
306 (print_one_catch_handlers, print_mention_catch_handlers)
307 (print_recreate_catch_handlers): Remove.
308 (create_ada_exception_catchpoint): Update.
309 (initialize_ada_catchpoint_ops): Update.
310
fccf9de1
TT
3112019-10-02 Tom Tromey <tromey@adacore.com>
312
313 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
314 (create_excep_cond_exprs): Simplify exception string computation.
315 (ada_exception_catchpoint_cond_string): Likewise.
316
4b610737
TT
3172019-10-02 Tom Tromey <tromey@adacore.com>
318
319 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
320 * ada-lang.c (lesseq_defined_than): Handle
321 LOC_STATIC.
322 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
323 parameter.
324 (dwarf2_has_info): Likewise.
325 (new_symbol): Set maybe_copied on symbol when
326 appropriate.
327 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
328 parameter.
329 <can_copy>: New member.
330 * elfread.c (record_minimal_symbol): Set maybe_copied
331 on symbol when appropriate.
332 (elf_symfile_read): Update call to dwarf2_has_info.
333 * minsyms.c (lookup_minimal_symbol_linkage): New
334 function.
335 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
336 * symtab.c (get_symbol_address, get_msymbol_address):
337 New functions.
338 * symtab.h (get_symbol_address, get_msymbol_address):
339 Declare.
340 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
341 maybe_copied.
342 (struct symbol, struct minimal_symbol) <maybe_copied>:
343 New member.
344
1dd58850
TT
3452019-10-02 Tom Tromey <tromey@adacore.com>
346
347 * source.c (struct current_source_location): New.
348 (current_source_key): New global.
349 (current_source_symtab, current_source_line)
350 (current_source_pspace): Remove.
351 (get_source_location): New function.
352 (get_current_source_symtab_and_line)
353 (set_default_source_symtab_and_line)
354 (set_current_source_symtab_and_line)
355 (clear_current_source_symtab_and_line, select_source_symtab)
356 (info_source_command, print_source_lines_base)
357 (info_line_command, search_command_helper, _initialize_source):
358 Update.
359
5c281dbb
TT
3602019-10-02 Tom Tromey <tromey@adacore.com>
361
362 * source.c (select_source_symtab): Don't call
363 decode_line_with_current_source.
364
d3d32391
AB
3652019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
366
367 * symtab.c (lookup_global_symbol): Search global block.
368
38583298
TT
3692019-10-02 Tom Tromey <tromey@adacore.com>
370
371 * coffread.c (process_coff_symbol): Update.
372 * dwarf2read.c (var_decode_location, new_symbol): Update.
373 * mdebugread.c (parse_symbol): Update.
374 * objfiles.c (relocate_one_symbol): Update.
375 * stabsread.c (define_symbol, fix_common_block)
376 (scan_file_globals): Update.
377 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
378 (SET_SYMBOL_VALUE_ADDRESS): New macro.
379 * xcoffread.c (process_xcoff_symbol): Update.
380
9344c18f
AA
3812019-10-02 Andreas Arnez <arnez@linux.ibm.com>
382
383 * MAINTAINERS: Update my email address.
384
df07e2c7
AB
3852019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
386
387 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
388 std::vector.
389 (build_type_psymtabs_reader): Update for std::vector.
390 (build_type_psymtab_dependencies): Likewise.
391 * dwarf2read.h: Remove use of DEF_VEC_P.
392 (typedef sig_type_ptr): Delete.
393
554ac434
AB
3942019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
395
396 * btrace.c (btrace_maint_clear): Update to handle change from VEC
397 to std::vector.
398 (btrace_maint_decode_pt): Likewise, and move allocation of the
399 vector outside of the loop.
400 (btrace_maint_update_packets): Update to handle change from VEC to
401 std::vector.
402 (btrace_maint_print_packets): Likewise.
403 (maint_info_btrace_cmd): Likewise.
404 * btrace.h: Remove use of DEF_VEC_O.
405 (typedef btrace_pt_packet_s): Delete.
406 (struct btrace_maint_info) <packets>: Change fromm VEC to
407 std::vector.
408 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
409
46f29a9a
AB
4102019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
411
412 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
413 make accesses into the vector constant references.
414 (btrace_add_pc): Update for std::vector.
415 (btrace_stitch_bts): Likewise.
416 (parse_xml_btrace_block): Likewise.
417 (btrace_maint_update_packets): Likewise.
418 (btrace_maint_print_packets): Likewise.
419 (maint_info_btrace_cmd): Likewise.
420 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
421 std::vector.
422 (btrace_data::empty): Likewise.
423 (btrace_data_append): Likewise.
424 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
425 (typedef btrace_block_s): Delete.
426 (struct btrace_block): Add constructor.
427 (struct btrace_data_bts) <blocks>: Change to std::vector.
428 * nat/linux-btrace.c (perf_event_read_bts): Update for
429 std::vector.
430 (linux_read_bts): Likewise.
431
d770d56f
TT
4322019-10-01 Tom Tromey <tom@tromey.com>
433
434 * cli/cli-logging.c (show_logging_filename): Use styled_string.
435
9d636d67
TT
4362019-10-01 Tom Tromey <tom@tromey.com>
437
438 * stack.c (print_frame, info_frame_command_core): Use
439 styled_string.
440 * linux-thread-db.c (try_thread_db_load_1)
441 (try_thread_db_load_from_pdir_1): Use styled_string.
442 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
443 (auto_load_section_scripts, info_auto_load_local_gdbinit)
444 (maybe_print_unsupported_script_warning)
445 (maybe_print_script_not_found_warning): Use styled_string.
446 * ada-lang.c (user_select_syms): Use styled_string.
447
7f6aba03
TT
4482019-10-01 Tom Tromey <tom@tromey.com>
449
450 * p-lang.c (pascal_printstr): Use metadata style.
451 * value.c (show_convenience): Use metadata style.
452 * valprint.c (valprint_check_validity, val_print_optimized_out)
453 (val_print_not_saved, val_print_unavailable)
454 (val_print_invalid_address, generic_val_print, val_print)
455 (value_check_printable, val_print_array_elements): Use metadata
456 style.
457 * ui-out.h (class ui_out) <field_fmt>: New overload.
458 <do_field_fmt>: Add style parameter.
459 * ui-out.c (ui_out::field_fmt): New overload.
460 * typeprint.c (type_print_unknown_return_type)
461 (val_print_not_allocated, val_print_not_associated): Use metadata
462 style.
463 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
464 parameter.
465 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
466 * tracepoint.c (tvariables_info_1): Use metadata style.
467 * stack.c (print_frame_arg, print_frame_info, print_frame)
468 (info_frame_command_core): Use metadata style.
469 * skip.c (info_skip_command): Use metadata style.
470 * rust-lang.c (rust_print_enum): Use metadata style.
471 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
472 metadata style.
473 * python/py-framefilter.c (py_print_single_arg): Use metadata
474 style.
475 * printcmd.c (do_one_display, print_variable_and_value): Use
476 metadata style.
477 * p-valprint.c (pascal_val_print)
478 (pascal_object_print_value_fields): Use metadata style.
479 * p-typeprint.c (pascal_type_print_base): Use metadata style.
480 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
481 parameter.
482 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
483 * m2-valprint.c (m2_print_long_set): Use metadata style.
484 * m2-typeprint.c (m2_print_type): Use metadata style.
485 * infcmd.c (print_return_value_1): Use metadata style.
486 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
487 * f-valprint.c (info_common_command_for_block): Use metadata
488 style.
489 * f-typeprint.c (f_type_print_base): Use metadata style.
490 * expprint.c (print_subexp_standard): Use metadata style.
491 * cp-valprint.c (cp_print_value_fields): Use metadata style.
492 * cli/cli-style.h (class cli_style_option): Add constructor.
493 (metadata_style): Declare.
494 * cli/cli-style.c (metadata_style): New global.
495 (_initialize_cli_style): Register metadata style.
496 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
497 parameter.
498 * cli-out.c (cli_ui_out::do_field_fmt): Update.
499 * c-typeprint.c (c_type_print_base_struct_union)
500 (c_type_print_base_1): Use metadata style.
501 * breakpoint.c (watchpoint_value_print)
502 (print_one_breakpoint_location): Use metadata style.
503 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
504 style.
505 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
506 style.
507 * ada-valprint.c (val_print_packed_array_elements, printstr)
508 (print_field_values, ada_val_print_ref, ada_val_print): Use
509 metadata style.
510 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
511 style.
512 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
513 style.
514 * ada-lang.c (user_select_syms): Use metadata style.
515
14309bb6
TT
5162019-10-01 Tom Tromey <tom@tromey.com>
517
518 * cli/cli-cmds.c (pwd_command): Style output.
519
6a831f06
PA
5202019-10-01 Pedro Alves <palves@redhat.com>
521 Tom Tromey <tom@tromey.com>
522
523 * symtab.c (print_symbol_info): Use %ps.
524 (print_msymbol_info): Use %ps.
525 * symfile.c (symbol_file_add_with_addrs): Use %ps.
526 * printcmd.c (print_variable_and_value): Use %ps.
527 * macrocmd.c (show_pp_source_pos): Use %ps.
528 * infrun.c (print_exited_reason): Use ui_out::message.
529 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
530 (describe_other_breakpoints): Use ui_out::message and new
531 formats.
532 (say_where): Use new formats.
533 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
534 and new formats.
535
2a3c1174
PA
5362019-10-01 Pedro Alves <palves@redhat.com>
537 Tom Tromey <tom@tromey.com>
538
539 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
540 (test_gdb_formats): New function.
541 (run_tests): Call it.
542 (test_format_specifier): Update.
543 * utils.h (fputs_filtered): Update comment.
544 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
545 (fputs_styled_unfiltered): Declare.
546 * utils.c (fputs_styled_unfiltered): New function.
547 (vfprintf_maybe_filtered): Add gdbfmt parameter.
548 (vfprintf_filtered): Update.
549 (vfprintf_unfiltered, vprintf_filtered): Update.
550 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
551 * ui-out.h (enum ui_out_flag) <unfiltered_output,
552 disallow_ui_out_field>: New constants.
553 (enum class field_kind): New.
554 (struct base_field_s, struct signed_field_s): New.
555 (signed_field): New function.
556 (struct string_field_s): New.
557 (string_field): New function.
558 (struct styled_string_s): New.
559 (styled_string): New function.
560 (class ui_out) <message>: Add comment.
561 <vmessage, call_do_message>: New methods.
562 <do_message>: Add style parameter.
563 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
564 methods.
565 (ui_out::message): Rewrite.
566 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
567 parameter.
568 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
569 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
570 gdb_extensions parameter.
571 (class format_piece): Add parameter to constructor.
572 (n_int_args): New field.
573 * gdbsupport/format.c (format_pieces::format_pieces): Add
574 gdb_extensions parameter. Handle '*'.
575 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
576 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
577 vfprintf_styled_no_gdbfmt.
578 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
579 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
580 unfiltered output.
581 * ui-style.h (struct ui_file_style) <ptr>: New method.
582
0dfe5bfb
TT
5832019-10-01 Tom Tromey <tom@tromey.com>
584
585 * unittests/format_pieces-selftests.c: Update. Add final format.
586 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
587 empty literal pieces.
588
e43b10e1
TT
5892019-10-01 Tom Tromey <tom@tromey.com>
590
591 * ui-out.h (enum class ui_out_style_kind): Remove.
592 (class ui_out) <field_string, field_stsream, do_field_string>:
593 Change type of "style".
594 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
595 (ui_out::field_string): Update.
596 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
597 of "style".
598 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
599 * tracepoint.c (print_one_static_tracepoint_marker): Update.
600 * stack.c (print_frame_arg, print_frame_info, print_frame):
601 Update.
602 * source.c (print_source_lines_base): Update.
603 * solib.c (info_sharedlibrary_command): Update.
604 * skip.c (info_skip_command): Update.
605 * record-btrace.c (btrace_call_history_src_line)
606 (btrace_call_history): Update.
607 * python/py-framefilter.c (py_print_frame): Update.
608 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
609 "style".
610 * mi/mi-out.c (mi_ui_out::do_table_header)
611 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
612 (mi_ui_out::do_field_string): Update.
613 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
614 Update.
615 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
616 "style".
617 * cli-out.c (cli_ui_out::do_table_header)
618 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
619 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
620 (cli_ui_out::do_field_fmt): Update.
621 * breakpoint.c (print_breakpoint_location): Update.
622 (update_static_tracepoint): Update.
623
cd7c32c3
PW
6242019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
625
626 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
627 conversion of gdb_datadir.
628 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
629 remove not needed c_str ().
630
8fe0f950
AT
6312019-09-30 Ali Tamur <tamur@google.com>
632
633 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
634 (dwarf2_string_attr): Likewise.
635
5f48f8f3
AT
6362019-09-30 Ali Tamur <tamur@google.com>
637
638 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
639 (process_full_type_unit): Likewise.
640 (dump_die_shallow): Likewise.
641 (cu_debug_loc_section): Likewise.
642
6fb08628
CB
6432019-09-28 Christian Biesinger <cbiesinger@google.com>
644
645 * minsyms.c (compare_minimal_symbols): Rename to...
646 (minimal_symbol_is_less_than): ...this, and adjust to STL
647 conventions (return bool, take arguments as references)
648 (minimal_symbol_reader::install): Call std::sort instead
649 of qsort.
650
c7ee338a
CB
6512019-09-29 Christian Biesinger <cbiesinger@google.com>
652
653 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
654 hash and why.
655 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
656 msymbol_hash, msymbol_demangled_hash>: Improve comments.
657
703a86c2
SM
6582019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
659
660 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
661 * psympriv.h (add_psymbol_to_list): Move comment here and update
662 it.
663
0df0352a
TV
6642019-09-29 Tom de Vries <tdevries@suse.de>
665
666 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
667 Use $tmpdir/$(basename "$output_file").dwz instead of
668 "${output_file}.dwz".
669
ad75efa6
SM
6702019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
671
672 PR gdb/25045
673 * hppa-linux-nat.c: Include gdbarch.h.
674
ececd218
CB
6752019-09-26 Christian Biesinger <cbiesinger@google.com>
676
677 * blockframe.c (find_pc_partial_function): Change return type to bool.
678 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
679 * minsyms.c (in_gnu_ifunc_stub): Likewise.
680 (stub_gnu_ifunc_resolve_name): Likewise.
681 * symtab.c (compare_filenames_for_search): Likewise.
682 (compare_glob_filenames_for_search): Likewise.
683 (matching_obj_sections): Likewise.
684 (symbol_matches_domain): Likewise.
685 (find_line_symtab): Change out param EXACT_MATCH to bool *.
686 (find_line_pc): Change return type to bool.
687 (find_line_pc_range): Likewise.
688 (producer_is_realview): Likewise.
689 * symtab.h (symbol_matches_domain): Likewise.
690 (find_pc_partial_function): Likewise.
691 (find_pc_line_pc_range): Likewise.
692 (in_gnu_ifunc_stub): Likewise.
693 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
694 (find_line_pc): Likewise.
695 (find_line_pc_range): Likewise.
696 (matching_obj_sections): Likewise.
697 (find_line_symtab): Change out parameter to bool.
698 (producer_is_realview): Change return type to bool.
699 (compare_filenames_for_search): Likewise.
700 (compare_glob_filenames_for_search): Likewise.
701
27a900b8
TT
7022019-09-26 Tom Tromey <tom@tromey.com>
703
704 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
705 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
706 * gdb_usleep.h: Remove.
707 * gdb_usleep.c: Remove.
708 * utils.c: Don't include gdb_usleep.h.
709
5d63b30a
TT
7102019-09-26 Tom Tromey <tromey@adacore.com>
711
712 * python/py-type.c (type_to_type_object): Call check_typedef
713 for stub types.
714
12904d37
TT
7152019-09-26 Tom Tromey <tom@tromey.com>
716
717 * utils.h (initialize_utils): Don't declare.
718 * top.c (gdb_init): Don't call initialize_utils.
719 * utils.c (initialize_utils): Remove. Move contents...
720 (_initialize_utils): ... here.
721
858f25f0
TT
7222019-09-25 Tom Tromey <tom@tromey.com>
723
724 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
725 * utils.h (make_hex_string): Don't declare.
726 * utils.c (make_hex_string): Remove.
727
3d435220
TV
7282019-09-24 Tom de Vries <tdevries@suse.de>
729
730 PR gdb/23815
731 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
732 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
733
ddd44b70
DD
7342019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
735
736 * NEWS: Mention new simulator port for PRU.
737
f945dedf
CB
7382019-09-23 Christian Biesinger <cbiesinger@google.com>
739
740 * ada-exp.y (write_object_remaining): Update.
741 * ada-lang.c (ada_decode): Return a std::string instead of a char*
742 and eliminate the static buffer.
743 (ada_decode_symbol): Update.
744 (ada_la_decode): Update.
745 (ada_sniff_from_mangled_name): Update.
746 (is_valid_name_for_wild_match): Update.
747 (ada_lookup_name_info::matches): Update and simplify.
748 (name_matches_regex): Update.
749 (ada_add_global_exceptions): Update.
750 * ada-lang.h (ada_decode): Update signature.
751 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
752 * dwarf-index-write.c (debug_names::insert): Update.
753
7ab78ccb
SM
7542019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
755
756 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
757 formatting.
758
9252448b
SM
7592019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
760
761 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
762 Change "nonzero" to "true" in documentation.
763
626ca2c0
CB
7642019-09-20 Christian Biesinger <cbiesinger@google.com>
765
766 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
767 (_initialize_darwin_solib): Don't set
768 darwin_so_ops.lookup_lib_global_symbol.
769 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
770 set_gdbarch_iterate_over_objfiles_in_search_order.
771 (elf_lookup_lib_symbol): Rename to...
772 (svr4_iterate_over_objfiles_in_search_order): this, and update
773 to iterate semantics.
774 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
775 * solib.c (solib_global_lookup): Remove.
776 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
777 (solib_global_lookup): Remove.
778 * symtab.c (lookup_global_or_static_symbol): Remove call to
779 solib_global_lookup.
780
5a3a0d63
JB
7812019-09-20 Joel Brobecker <brobecker@adacore.com>
782
783 * NEWS: Move entries about default MI version now being
784 version 3, and about the GDB/MI fix for multi-location
785 breakpoints to the "since GDB 8.3" section.
786
ffea1427
JB
7872019-09-20 Joel Brobecker <brobecker@adacore.com>
788
789 GDB 8.3.1 released.
790
abf516c6
UW
7912019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
792
793 * NEWS: Mention that Cell/B.E. debugging support was removed.
794 * MAINTAINERS: Remove spu target.
795
796 * config/djgpp/fnchange.lst: Remove entries for removed files.
797
798 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
799 spu-multiarch.o, and spu-tdep.o.
800 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
801 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
802 spu-multiarch.c, and spu-tdep.c.
803 * spu-linux-nat.c: Remove file.
804 * spu-multiarch.c: Remove file.
805 * spu-tdep.c: Remove file.
806 * spu-tdep.h: Remove file.
807 * solib-spu.c: Remove file.
808 * solib-spu.h: Remove file.
809
810 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
811 * configure.nat (spu-linux): Remove.
812 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
813 solib-multiarch.o from gdb_target_obs.
814 (spu*-*-*): Remove.
815
816 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
817 feature flag.
818 (ppc_linux_no_features): Update.
819 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
820 Cell/B.E. support.
821 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
822 (tdesc_powerpc_cell64l): Likewise.
823 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
824 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
825 Cell/B.E. support.
826 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
827 Do not include "features/rs6000/powerpc-cell32l.c" or
828 "features/rs6000/powerpc-cell64l.c".
829 (ppc_linux_spu_section): Remove.
830 (ppc_linux_core_read_description): Remove Cell/B.E. support.
831 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
832 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
833 (ppc_linux_spe_context_lookup): Remove.
834 (ppc_linux_spe_context_inferior_created): Remove.
835 (ppc_linux_spe_context_solib_loaded): Remove.
836 (ppc_linux_spe_context_solib_unloaded): Remove.
837 (ppc_linux_spe_context): Remove.
838 (struct ppu2spu_cache): Remove.
839 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
840 (struct ppu2spu_data): Remove.
841 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
842 ppu2spu_unwind): Remove.
843 (ppc_linux_init_abi): Remove Cell/B.E. support.
844 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
845
846 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
847 (rs6000/powerpc-cell64l-expedite): Likewise
848 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
849 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
850 rs6000/powerpc-cell64l.xml.
851 * features/rs6000/powerpc-cell32l.xml: Remove.
852 * features/rs6000/powerpc-cell64l.xml: Likewise.
853 * features/rs6000/powerpc-cell32l.c: Remove generated file.
854 * features/rs6000/powerpc-cell64l.c: Likewise.
855 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
856 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
857 * regformats/reg-spu.dat: Remove.
858
859 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
860 * corelow.c (struct spuid_list): Remove.
861 (add_to_spuid_list): Remove.
862 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
863 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
864 (remote_protocol_features): Remove associated entries.
865 (_initialize_remote): No longer initialize them.
866 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
867 * linux-nat.c (SPUFS_MAGIC): Remove.
868 (linux_proc_xfer_spu): Remove.
869 (spu_enumerate_spu_ids): Remove.
870 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
871 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
872 (linux_make_corefile_notes): No longer call it.
873
874 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
875 (cooked_write_test): Likewise.
876
78e8cb91
TT
8772019-09-20 Tom Tromey <tom@tromey.com>
878
879 * NEWS: Mention case-sensitivity of TUI commands.
880 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
881 (tui_set_win_height_command, parse_scrolling_args): Likewise.
882 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
883
f074b67e
TT
8842019-09-20 Tom Tromey <tom@tromey.com>
885
886 * tui/tui-source.c (tui_source_window::set_contents): Use
887 make_unique_xstrdup.
888 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
889 make_unique_xstrdup.
890
63c4bf19
TT
8912019-09-20 Tom Tromey <tom@tromey.com>
892
893 * tui/tui-data.c: Remove separator comments.
894 * tui/tui-layout.c: Remove separator comments.
895 * tui/tui-win.c: Remove separator comments.
896 * tui/tui-wingeneral.c: Remove separator comments.
897
43df9b2f
TT
8982019-09-20 Tom Tromey <tom@tromey.com>
899
900 * tui/tui.h (strcat_to_buf): Don't declare.
901 * tui/tui.c (strcat_to_buf): Remove.
902
7226433c
TT
9032019-09-20 Tom Tromey <tom@tromey.com>
904
905 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
906 from "fullname".
907 * tui/tui-source.c (tui_source_window::set_contents)
908 (tui_source_window::location_matches_p)
909 (tui_source_window::maybe_update): Update.
910
80df3337
TT
9112019-09-20 Tom Tromey <tom@tromey.com>
912
913 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
914 Update.
915 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
916 prefix.
917 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
918 (tui_data_window::line_from_reg_element_no)
919 (tui_data_window::first_reg_element_no_inline)
920 (tui_data_window::show_registers)
921 (tui_data_window::show_register_group)
922 (tui_data_window::display_registers_from)
923 (tui_data_window::display_registers_from_line)
924 (tui_data_window::first_data_item_displayed)
925 (tui_data_window::delete_data_content_windows)
926 (tui_data_window::erase_data_content)
927 (tui_data_window::do_scroll_vertical)
928 (tui_data_window::refresh_window)
929 (tui_data_window::check_register_values): Update.
930
9923f347
TT
9312019-09-20 Tom Tromey <tom@tromey.com>
932
933 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
934 (struct tui_locator_window) <full_name, proc_name>: Now
935 std::string.
936 * tui/tui-stack.c (tui_locator_window::make_status_line)
937 (tui_locator_window::set_locator_fullname)
938 (tui_locator_window::set_locator_info): Update.
939 * tui/tui-source.c (tui_source_window::set_contents)
940 (tui_source_window::showing_source_p): Update.
941
b76251ab
TT
9422019-09-20 Tom Tromey <tom@tromey.com>
943
944 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
945 Don't call tui_locator_win_info_ptr.
946
0891be08
TT
9472019-09-20 Tom Tromey <tom@tromey.com>
948
949 * tui/tui-win.c (tui_resize_all): Don't call refresh.
950
1b935acf
TT
9512019-09-20 Tom Tromey <tom@tromey.com>
952
953 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
954 height for locator.
955 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
956 * tui/tui-layout.c (show_source_disasm_command, show_data)
957 (show_source_or_disasm_and_command): Use 1 as height for locator.
958
9abd8a65
TT
9592019-09-20 Tom Tromey <tom@tromey.com>
960
961 * tui/tui.c (tui_enable): Update.
962 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
963 Update.
964 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
965 Update.
966 * tui/tui-data.c (win_resized): Now bool.
967 (tui_win_resized): Return bool.
968 (tui_set_win_resized_to): Accept a bool.
969
b5457826
TT
9702019-09-20 Tom Tromey <tom@tromey.com>
971
972 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
973 Change type of "refresh_values_only".
974 * tui/tui-regs.c (tui_data_window::show_register_group): Change
975 type of "refresh_values_only".
976
6b915f7d
TT
9772019-09-20 Tom Tromey <tom@tromey.com>
978
979 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
980 std::string.
981 (tui_disassemble): Add "pos" parameter.
982 (tui_disasm_window::set_contents): Simplify.
983
2ad52f6f
TT
9842019-09-20 Tom Tromey <tom@tromey.com>
985
986 * tui/tui-winsource.h (struct tui_source_window_base)
987 <show_source_content>: Now private.
988 * tui/tui-winsource.c
989 (tui_source_window_base::show_source_content): Don't handle empty
990 content case.
991
b3b1bde6
TT
9922019-09-20 Tom Tromey <tom@tromey.com>
993
994 * tui/tui-layout.c (show_source_disasm_command)
995 (show_source_or_disasm_and_command): Don't call
996 show_source_content.
997
71a25ed2
TT
9982019-09-20 Tom Tromey <tom@tromey.com>
999
1000 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1001 Declare.
1002 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1003 from tui_make_status_line.
1004 (tui_locator_window::rerender): Update.
1005
f8532154
TT
10062019-09-20 Tom Tromey <tom@tromey.com>
1007
1008 * tui/tui-stack.c (tui_make_status_line): Return std::string.
1009 (tui_locator_window::rerender): Update.
1010
2d81b349
TT
10112019-09-20 Tom Tromey <tom@tromey.com>
1012
1013 * tui/tui-winsource.h (struct tui_source_window_base)
1014 <~tui_source_window_base>: Don't declare.
1015 <fullname>: Remove.
1016 * tui/tui-winsource.c (~tui_source_window_base): Remove.
1017 * tui/tui-source.h (struct tui_source_window) <fullname>: New
1018 member.
1019 * tui/tui-source.c (tui_source_window::set_contents): Update.
1020 (tui_source_window::location_matches_p)
1021 (tui_source_window::maybe_update): Update.
1022
f14bec58
TT
10232019-09-20 Tom Tromey <tom@tromey.com>
1024
1025 * tui/tui-winsource.h (~tui_source_element): Remove.
1026 (tui_source_element): Update.
1027 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1028 * tui/tui-winsource.c (tui_show_source_line): Update.
1029 * tui/tui-source.c (tui_source_window::set_contents): Update.
1030 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1031
78d5933a
TT
10322019-09-20 Tom Tromey <tom@tromey.com>
1033
1034 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1035 declare.
1036 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1037 tui_clear_source_windows_detail.
1038 * tui/tui-winsource.h (struct tui_source_window_base)
1039 <clear_detail>: Don't declare.
1040 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1041 Remove.
1042 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1043
d4207696
TT
10442019-09-20 Tom Tromey <tromey@adacore.com>
1045
1046 PR ada/24919:
1047 * block.c (contained_in): Fix final return value.
1048
00f93c44
AM
10492019-09-20 Alan Modra <amodra@gmail.com>
1050
1051 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1052 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1053 (read_indirect_string_from_dwz): Use bfd accessor.
1054 * dwarf2read.h (struct dwz_file <filename>): Likewise.
1055 * machoread.c (macho_symfile_read_all_oso): Likewise.
1056 * solib.c (solib_bfd_open): Likewise.
1057
e4153ae6
CB
10582019-09-19 Christian Biesinger <cbiesinger@google.com>
1059
1060 * eval.c: Move declaration of overload_resolution to...
1061 * value.h: ...here.
1062
c7ae7675
CB
10632019-09-19 Christian Biesinger <cbiesinger@google.com>
1064
1065 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1066 * arm-linux-tdep.c: Likewise.
1067 * arm-nbsd-nat.c: Likewise.
1068 * arm-tdep.h: Declare arm_apcs_32.
1069 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1070
e86f08d2
CB
10712019-09-19 Christian Biesinger <cbiesinger@google.com>
1072
1073 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1074 * dwarf2read.h: Declare dwarf_always_disassemble.
1075
f64e2f40
TV
10762019-09-19 Tom de Vries <tdevries@suse.de>
1077
1078 PR gdb/25009
1079 * source-cache.c (source_cache::ensure): Catch exception thrown during
1080 construction of the highlighter.
1081
fd361982
AM
10822019-09-18 Alan Modra <amodra@gmail.com>
1083
1084 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1085 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1086 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1087 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1088 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1089 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1090 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1091 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1092 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1093 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1094 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1095 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1096 * solib-spu.c, * solib-svr4.c, * solib-target.c,
1097 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1098 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1099 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1100 * mi/mi-interp.c: Update throughout for bfd section macro and
1101 function changes.
1102 * gcore (gcore_create_callback): Use bfd_set_section_lma.
1103 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1104
11061048
TT
11052019-09-18 Tom Tromey <tom@tromey.com>
1106
1107 * NEWS: Add entry.
1108 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
1109 call rl_initialize.
1110 (tui_enable): Do not call rl_initialize.
1111
7a27b85f
CG
11122019-09-18 Christian Groessler <chris@groessler.org>
1113
1114 * alpha-linux-nat.c: Include gdbarch.h.
1115
f64eea3a
SM
11162019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
1117
1118 * ui-file.c: Include cli/cli-style.h.
1119 (term_cli_styling): Remove cli_styling declaration.
1120
e6f7f6d1
AM
11212019-09-18 Alan Modra <amodra@gmail.com>
1122
1123 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1124 to bfd_asymbol_section.
1125
1d38e9d1
AM
11262019-09-18 Alan Modra <amodra@gmail.com>
1127
1128 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1129 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1130 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1131
90d92a63
AM
11322019-09-18 Alan Modra <amodra@gmail.com>
1133
1134 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1135 * spu-linux-nat.c (spu_bfd_open): Likewise.
1136
a3d181d2
CB
11372019-09-18 Christian Biesinger <cbiesinger@google.com>
1138
1139 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1140 to bool to match definition in dwarf2read.c.
1141
491144b5
CB
11422019-09-17 Christian Biesinger <cbiesinger@google.com>
1143
1144 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1145 (print_signatures): Likewise.
1146 (trust_pad_over_xvs): Likewise.
1147 * arch/aarch64-insn.c (aarch64_debug): Likewise.
1148 * arch/aarch64-insn.h (aarch64_debug): Likewise.
1149 * arm-linux-nat.c (arm_apcs_32): Likewise.
1150 * arm-linux-tdep.c (arm_apcs_32): Likewise.
1151 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1152 * arm-tdep.c (arm_debug): Likewise.
1153 (arm_apcs_32): Likewise.
1154 * auto-load.c (debug_auto_load): Likewise.
1155 (auto_load_gdb_scripts): Likewise.
1156 (global_auto_load): Likewise.
1157 (auto_load_local_gdbinit): Likewise.
1158 (auto_load_local_gdbinit_loaded): Likewise.
1159 * auto-load.h (global_auto_load): Likewise.
1160 (auto_load_local_gdbinit): Likewise.
1161 (auto_load_local_gdbinit_loaded): Likewise.
1162 * breakpoint.c (disconnected_dprintf): Likewise.
1163 (breakpoint_proceeded): Likewise.
1164 (automatic_hardware_breakpoints): Likewise.
1165 (always_inserted_mode): Likewise.
1166 (target_exact_watchpoints): Likewise.
1167 (_initialize_breakpoint): Update.
1168 * breakpoint.h (target_exact_watchpoints): Change to bool.
1169 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1170 * cli/cli-cmds.c (trace_commands): Likewise.
1171 * cli/cli-cmds.h (trace_commands): Likewise.
1172 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1173 to bool*.
1174 * cli/cli-logging.c (logging_overwrite): Change to bool.
1175 (logging_redirect): Likewise.
1176 (debug_redirect): Likewise.
1177 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1178 (struct boolean_option_def) <get_var_address_cb_>: Change return type
1179 to bool.
1180 <boolean_option_def>: Update.
1181 (struct flag_option_def): Change default type of Context to bool
1182 from int.
1183 <flag_option_def>: Change return type of var_address_cb_ to bool*.
1184 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1185 (get_setshow_command_value_string): Likewise.
1186 * cli/cli-style.c (cli_styling): Change to bool.
1187 (source_styling): Likewise.
1188 * cli/cli-style.h (source_styling): Likewise.
1189 (cli_styling): Likewise.
1190 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1191 to bool.
1192 * command.h (var_types): Update comment.
1193 (add_setshow_boolean_cmd): Change int* var argument to bool*.
1194 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1195 bool.
1196 (debug_compile_cplus_scopes): Likewise.
1197 * compile/compile-internal.h (compile_debug): Likewise.
1198 * compile/compile.c (compile_debug): Likewise.
1199 (struct compile_options) <raw>: Likewise.
1200 * cp-support.c (catch_demangler_crashes): Likewise.
1201 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1202 (usr_cmd_cris_dwarf2_cfi): Likewise.
1203 * csky-tdep.c (csky_debug): Likewise.
1204 * darwin-nat.c (enable_mach_exceptions): Likewise.
1205 * dcache.c (dcache_enabled_p): Likewise.
1206 * defs.h (info_verbose): Likewise.
1207 * demangle.c (demangle): Likewise.
1208 (asm_demangle): Likewise.
1209 * dwarf-index-cache.c (debug_index_cache): Likewise.
1210 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1211 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1212 * dwarf2read.c (check_physname): Likewise.
1213 (use_deprecated_index_sections): Likewise.
1214 (dwarf_always_disassemble): Likewise.
1215 * eval.c (overload_resolution): Likewise.
1216 * event-top.c (set_editing_cmd_var): Likewise.
1217 (exec_done_display_p): Likewise.
1218 * event-top.h (set_editing_cmd_var): Likewise.
1219 (exec_done_display_p): Likewise.
1220 * exec.c (write_files): Likewise.
1221 * fbsd-nat.c (debug_fbsd_lwp): Likewise
1222 (debug_fbsd_nat): Likewise.
1223 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1224 Likewise.
1225 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1226 <backtrace_past_entry> Likewise.
1227 * gdb-demangle.h (demangle): Likewise.
1228 (asm_demangle): Likewise.
1229 * gdb_bfd.c (bfd_sharing): Likewise.
1230 * gdbcore.h (write_files): Likewise.
1231 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1232 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1233 * gdbthread.h (print_thread_events): Likewise.
1234 * gdbtypes.c (opaque_type_resolution): Likewise.
1235 (strict_type_checking): Likewise.
1236 * gnu-nat.c (gnu_debug_flag): Likewise.
1237 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1238 * guile/scm-param.c (pascm_variable): Add boolval.
1239 (add_setshow_generic): Update.
1240 (pascm_param_value): Update.
1241 (pascm_set_param_value_x): Update.
1242 * hppa-tdep.c (hppa_debug): Change to bool..
1243 * infcall.c (may_call_functions_p): Likewise.
1244 (coerce_float_to_double_p): Likewise.
1245 (unwind_on_signal_p): Likewise.
1246 (unwind_on_terminating_exception_p): Likewise.
1247 * infcmd.c (startup_with_shell): Likewise.
1248 * inferior.c (print_inferior_events): Likewise.
1249 * inferior.h (startup_with_shell): Likewise.
1250 (print_inferior_events): Likewise.
1251 * infrun.c (step_stop_if_no_debug): Likewise.
1252 (detach_fork): Likewise.
1253 (debug_displaced): Likewise.
1254 (disable_randomization): Likewise.
1255 (non_stop): Likewise.
1256 (non_stop_1): Likewise.
1257 (observer_mode): Likewise.
1258 (observer_mode_1): Likewise.
1259 (set_observer_mode): Update.
1260 (sched_multi): Change to bool.
1261 * infrun.h (debug_displaced): Likewise.
1262 (sched_multi): Likewise.
1263 (step_stop_if_no_debug): Likewise.
1264 (non_stop): Likewise.
1265 (disable_randomization): Likewise.
1266 * linux-tdep.c (use_coredump_filter): Likewise.
1267 (dump_excluded_mappings): Likewise.
1268 * linux-thread-db.c (auto_load_thread_db): Likewise.
1269 (check_thread_db_on_load): Likewise.
1270 * main.c (captured_main_1): Update.
1271 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1272 xx2_opt, boolean_opt>: Change to bool.
1273 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1274 * maint.c (maintenance_profile_p): Likewise.
1275 (per_command_time): Likewise.
1276 (per_command_space): Likewise.
1277 (per_command_symtab): Likewise.
1278 * memattr.c (inaccessible_by_default): Likewise.
1279 * mi/mi-main.c (mi_async): Likewise.
1280 (mi_async_1): Likewise.
1281 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1282 * nat/fork-inferior.h (startup_with_shell): Likewise.
1283 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1284 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1285 * nios2-tdep.c (nios2_debug): Likewise.
1286 * or1k-tdep.c (or1k_debug): Likewise.
1287 * parse.c (parser_debug): Likewise.
1288 * parser-defs.h (parser_debug): Likewise.
1289 * printcmd.c (print_symbol_filename): Likewise.
1290 * proc-api.c (procfs_trace): Likewise.
1291 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1292 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1293 (set_parameter_value): Update.
1294 (add_setshow_generic): Update.
1295 * python/py-value.c (copy_py_bool_obj): Change argument from int*
1296 to bool*.
1297 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1298 int*.
1299 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1300 * record-btrace.c (record_btrace_target::store_registers): Update.
1301 * record-full.c (record_full_memory_query): Change to bool.
1302 (record_full_stop_at_limit): Likewise.
1303 * record-full.h (record_full_memory_query): Likewise.
1304 * remote-notif.c (notif_debug): Likewise.
1305 * remote-notif.h (notif_debug): Likewise.
1306 * remote.c (use_range_stepping): Likewise.
1307 (interrupt_on_connect): Likewise.
1308 (remote_break): Likewise.
1309 * ser-tcp.c (tcp_auto_retry): Likewise.
1310 * ser-unix.c (serial_hwflow): Likewise.
1311 * skip.c (debug_skip): Likewise.
1312 * solib-aix.c (solib_aix_debug): Likewise.
1313 * spu-tdep.c (spu_stop_on_load_p): Likewise.
1314 (spu_auto_flush_cache_p): Likewise.
1315 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1316 Likewise.
1317 (struct info_print_options) <quiet>: Likewise.
1318 * symfile-debug.c (debug_symfile): Likewise.
1319 * symfile.c (auto_solib_add): Likewise.
1320 (separate_debug_file_debug): Likewise.
1321 * symfile.h (auto_solib_add): Likewise.
1322 (separate_debug_file_debug): Likewise.
1323 * symtab.c (basenames_may_differ): Likewise.
1324 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1325 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1326 (struct info_types_options) <quiet>: Likewise.
1327 * symtab.h (demangle): Likewise.
1328 (basenames_may_differ): Likewise.
1329 * target-dcache.c (stack_cache_enabled_1): Likewise.
1330 (code_cache_enabled_1): Likewise.
1331 * target.c (trust_readonly): Likewise.
1332 (may_write_registers): Likewise.
1333 (may_write_memory): Likewise.
1334 (may_insert_breakpoints): Likewise.
1335 (may_insert_tracepoints): Likewise.
1336 (may_insert_fast_tracepoints): Likewise.
1337 (may_stop): Likewise.
1338 (auto_connect_native_target): Likewise.
1339 (target_stop_and_wait): Update.
1340 (target_async_permitted): Change to bool.
1341 (target_async_permitted_1): Likewise.
1342 (may_write_registers_1): Likewise.
1343 (may_write_memory_1): Likewise.
1344 (may_insert_breakpoints_1): Likewise.
1345 (may_insert_tracepoints_1): Likewise.
1346 (may_insert_fast_tracepoints_1): Likewise.
1347 (may_stop_1): Likewise.
1348 * target.h (target_async_permitted): Likewise.
1349 (may_write_registers): Likewise.
1350 (may_write_memory): Likewise.
1351 (may_insert_breakpoints): Likewise.
1352 (may_insert_tracepoints): Likewise.
1353 (may_insert_fast_tracepoints): Likewise.
1354 (may_stop): Likewise.
1355 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1356 (make_thread_apply_all_options_def_group): Change argument from int*
1357 to bool*.
1358 (thread_apply_all_command): Update.
1359 (print_thread_events): Change to bool.
1360 * top.c (confirm): Likewise.
1361 (command_editing_p): Likewise.
1362 (history_expansion_p): Likewise.
1363 (write_history_p): Likewise.
1364 (info_verbose): Likewise.
1365 * top.h (confirm): Likewise.
1366 (history_expansion_p): Likewise.
1367 * tracepoint.c (disconnected_tracing): Likewise.
1368 (circular_trace_buffer): Likewise.
1369 * typeprint.c (print_methods): Likewise.
1370 (print_typedefs): Likewise.
1371 * utils.c (debug_timestamp): Likewise.
1372 (sevenbit_strings): Likewise.
1373 (pagination_enabled): Likewise.
1374 * utils.h (sevenbit_strings): Likewise.
1375 (pagination_enabled): Likewise.
1376 * valops.c (overload_resolution): Likewise.
1377 * valprint.h (struct value_print_options) <prettyformat_arrays,
1378 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1379 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1380 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1381 Likewise.
1382 * windows-nat.c (new_console): Likewise.
1383 (cygwin_exceptions): Likewise.
1384 (new_group): Likewise.
1385 (debug_exec): Likewise.
1386 (debug_events): Likewise.
1387 (debug_memory): Likewise.
1388 (debug_exceptions): Likewise.
1389 (useshell): Likewise.
1390 * windows-tdep.c (maint_display_all_tib): Likewise.
1391 * xml-support.c (debug_xml): Likewise.
1392
f1b620e9
MG
13932019-09-17 Mike Gulick <mgulick@mathworks.com>
1394
1395 * source.c (prepare_path_for_appending): New function.
1396 (openp): Make use of new function.
1397 (find_and_open_source): Search for the compilation directory and
1398 source file as a relative path beneath the directory search path.
1399
67f3ed6a
AB
14002019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
1401
1402 * source-cache.c (source_cache::get_line_charpos): Catch
1403 exceptions and return false, this matches the behaviour documented
1404 in the header file.
1405
74332189
JB
14062019-09-17 Joel Brobecker <brobecker@adacore.com>
1407
1408 * ada-tasks.c (info_task): Remove quoting of the task's name.
1409
f2f24aa9
CB
14102019-09-16 Christian Biesinger <cbiesinger@google.com>
1411
1412 * symfile.c (auto_solib_add): Replace comment with a reference
1413 to the header file.
1414
6a062a93
CB
14152019-09-14 Christian Biesinger <cbiesinger@google.com>
1416
1417 * NEWS: Mention that gdb can now be compiled with Python 3
1418 on Windows.
1419
ec6c8338
AB
14202019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1421
1422 * maint.c (maint_print_section_data::maint_print_section_data):
1423 Force use of 'float log10 (float)' by casting the argument to
1424 float.
1425
aa17805f
AB
14262019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1427
1428 * maint.c: Add 'cmath' include.
1429 (struct maint_print_section_data): New structure.
1430 (print_section_index): New function.
1431 (print_bfd_section_info): Add header comment, small whitespace
1432 cleanup, and update to call new print_section_index function.
1433 (print_objfile_section_info): Likewise.
1434 (maint_obj_section_from_bfd_section): New function.
1435 (print_bfd_section_info_maybe_relocated): New function.
1436 (maintenance_info_sections): Add header comment, always use
1437 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1438
3dd9bb46
AB
14392019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1440
1441 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1442 inner scope, add check that the objfile has psymtabs before
1443 checking psymtabs_addrmap.
1444 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1445
4993045d
PW
14462019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1447
1448 * NEWS: Announce that Ada task names are now shown at more places,
1449 and between quotes (except in info task output).
1450 * gdb/ada-tasks.c (task_to_str): New function.
1451 (display_current_task_id): Call task_to_str.
1452 (task_command_1): Likewise.
1453 (print_ada_task_info): In non-mi mode, Properly align headers and data
1454 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1455
7a289707
RO
14562019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1457
1458 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1459 prstatus.pr_lwp.pr_info instead of making it up.
1460
f2aec7f6
CB
14612019-09-11 Christian Biesinger <cbiesinger@google.com>
1462
1463 * auto-load.c (auto_load_expand_dir_vars): Update.
1464 * defs.h (gdb_datadir): Change to std::string.
1465 (python_libdir): Likewise.
1466 (relocate_gdb_directory): Change return type to std::string.
1467 * guile/guile.c (gdbscm_data_directory): Update.
1468 (initialize_scheme_side): Update.
1469 * jit.c (jit_reader_dir): Change to std::string.
1470 (jit_reader_load_command): Update.
1471 * main.c (gdb_datadir): Change to std::string.
1472 (python_libdir): Likewise.
1473 (set_gdb_data_directory): Update.
1474 (relocate_path): Change to return std::string.
1475 (relocate_gdb_directory): Change to return std::string.
1476 (relocate_gdbinit_path_maybe_in_datadir): Update.
1477 (captured_main_1): Update.
1478 * python/python.c (do_start_initialization): Update.
1479 * top.c (show_gdb_datadir): Update.
1480 * xml-syscall.c (xml_init_syscalls_info): Update.
1481 (init_syscalls_info): Update.
1482
9224a013
CB
14832019-09-11 Christian Biesinger <cbiesinger@google.com>
1484
1485 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1486 out of get_init_files.
1487 (get_init_files): Update.
1488
f48cd836
CB
14892019-09-11 Christian Biesinger <cbiesinger@google.com>
1490
1491 * main.c (get_init_files): Change to use std::string.
1492 (captured_main_1): Update.
1493 (print_gdb_help): Update.
1494
9cab7ecd
AT
14952019-09-11 Ali Tamur <tamur@google.com>
1496
1497 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1498 implementation.
1499
67547d89
CB
15002019-09-11 Christian Biesinger <cbiesinger@google.com>
1501
1502 * dbxread.c (read_dbx_symtab): Update.
1503 * dwarf2read.c (load_partial_dies): Update.
1504 * mdebugread.c (parse_partial_symbols): Update.
1505 (handle_psymbol_enumerators): Update.
1506 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1507 * psymtab.c (add_psymbol_to_bcache): Likewise.
1508 (add_psymbol_to_list): Likewise.
1509 * symtab.c (symbol_set_names): Likewise.
1510 * symtab.h (symbol_set_names): Likewise.
1511 * xcoffread.c (scan_xcoff_symtab): Update.
1512
64b2d4a0
TT
15132019-09-11 Tom Tromey <tom@tromey.com>
1514
1515 * symfile-mem.c (symbol_file_add_from_memory): Use
1516 bfd_set_filename.
1517 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1518 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1519
3b00ef10
TT
15202019-09-10 Tom Tromey <tromey@adacore.com>
1521
1522 * dwarf-index-write.c (write_psymbols): Extend error message.
1523 (debug_names::insert): Add Ada code.
1524 (debug_names::write_psymbols): Remove Ada check.
1525 (debug_names) <m_string_obstack>: New member.
1526 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1527 (gdb_index_symbol_name_matcher::matches): Remove.
1528 (mapped_index_base::find_name_components_bounds): Add "lang"
1529 parameter.
1530 (mapped_index_base::build_name_components): Also split names
1531 according to Ada syntax.
1532 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
1533 type of "match_callback".
1534 (check_match, check_find_bounds_finds)
1535 (dw2_expand_symtabs_matching): Update.
1536 (dw2_debug_names_iterator): Add new constructor.
1537 (dw2_debug_names_map_matching_symbols): New function.
1538 (dw2_debug_names_expand_symtabs_matching): Update.
1539 (dwarf2_debug_names_functions): Use
1540 dw2_debug_names_map_matching_symbols.
1541
aa391654
TT
15422019-09-10 Tom Tromey <tromey@adacore.com>
1543
1544 * dwarf2read.c (dw2_get_file_names_reader): Add the
1545 CU's file name to the results.
1546
b054970d
TT
15472019-09-10 Tom Tromey <tromey@adacore.com>
1548
1549 * ada-lang.c (add_nonlocal_symbols): Combine calls to
1550 map_matching_symbols. Update.
1551 * dwarf2read.c (dw2_map_matching_symbols): Update.
1552 * psymtab.c (match_partial_symbol): Change type; update.
1553 (psym_map_matching_symbols): Likewise.
1554 * symfile-debug.c (debug_qf_map_matching_symbols): Change
1555 type; update.
1556 * symfile.h (struct quick_symbol_functions)
1557 <map_matching_symbols>: Change "name" to be a lookup_name_info.
1558 Remove "match".
1559
6a3dbf1b
TT
15602019-09-10 Tom Tromey <tromey@adacore.com>
1561
1562 * psymtab.c (map_block): Remove.
1563 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1564 * symtab.c (iterate_over_symbols_terminated): New function.
1565 * symtab.c (iterate_over_symbols_terminated): Declare.
1566
6969f124
TT
15672019-09-10 Tom Tromey <tromey@adacore.com>
1568
1569 * ada-lang.c (ada_iterate_over_symbols): Return bool.
1570 * language.h (struct language_defn) <la_iterate_over_symbols>:
1571 Return bool.
1572 * symtab.c (iterate_over_symbols): Return bool.
1573 * symtab.h (iterate_over_symbols): Return bool.
1574
199b4314
TT
15752019-09-10 Tom Tromey <tromey@adacore.com>
1576
1577 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1578 (add_nonlocal_symbols): Update.
1579 * dwarf2read.c (dw2_map_matching_symbols): Change type.
1580 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1581 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1582 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1583 Change type of "callback". Remove "data".
1584
a084a2a6
AT
1585
15862019-09-09 Ali Tamur <tamur@google.com>
1587
1588 * dwarf2read.c (comp_unit_head): Update comment.
1589 (dwarf2_dwo_name): New function declaration.
1590 (dwarf_unit_type_name): New function declaration.
1591 (read_comp_unit_head): Add support for new compilation units,
1592 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1593 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1594 (currently named as "signature") in their header. Also clarify error
1595 messages.
1596 (lookup_dwo_id): New function. Returns the dwo id of the given
1597 compile unit.
1598 (lookup_dwo_unit): Use the new lookup_dwo_id function.
1599 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1600 functions.
1601 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1602 (dwarf2_dwo_name): Get the dwo name if present.
1603 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1604 purposes.
1605
25a2915e
TT
16062019-09-09 Tom Tromey <tom@tromey.com>
1607
1608 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1609
e4df0874
PW
16102019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1611
1612 * python/python.c (do_start_initialization): Make progname_copy static,
1613 to avoid a leak report.
1614
8634b462
TT
16152019-09-08 Tom Tromey <tom@tromey.com>
1616
1617 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1618
c7f839cb
SM
16192019-09-07 Simon Marchi <simon.marchi@efficios.com>
1620
1621 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1622 Change type to gdb::optional<block_enum>.
1623 (dw2_symtab_iter_init): Change block_index parameter type
1624 to gdb::optional<block_enum>.
1625 (dw2_lookup_symbol): Change block_index parameter
1626 type to block_enum.c
1627 (dw2_debug_names_lookup_symbol): Likewise.
1628 * psymtab.c (psym_lookup_symbol): Likewise.
1629 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1630 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1631 Likewise.
1632
ead0e69a
CB
16332019-09-06 Christian Biesinger <cbiesinger@google.com>
1634
1635 * defs.h (relocate_gdb_directory): Change int to bool in
1636 signature and rename flag to relocatable.
1637 * main.c (relocate_path): Likewise.
1638 (relocate_gdb_directory): Likewise.
1639
b16c44de
AM
16402019-09-06 Alan Modra <amodra@gmail.com>
1641
1642 * coffread.c (coff_symfile_read): Constify filename variable.
1643 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1644 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1645 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1646 * solib.c (reload_shared_libraries_1): Likewise.
1647 * symfile.c (reread_symbols): Likewise.
1648 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1649 * solib-darwin.c (darwin_bfd_open): Likewise.
1650 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1651
06ff036e
AB
16522019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
1653
1654 * psymtab.c (print_partial_symbols): Handle missing domain_enum
1655 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1656
4e962e74
TT
16572019-09-03 Tom Tromey <tromey@adacore.com>
1658
1659 * ada-valprint.c (ada_val_print_num): Don't recurse for range
1660 types.
1661 (has_negatives): Unbias a range type bound.
1662 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1663 * gdbtypes.c (operator==): Handle new field.
1664 (create_range_type): Add "bias" parameter.
1665 (create_static_range_type, resolve_dynamic_range): Update.
1666 * gdbtypes.h (struct range_bounds) <bias>: New member.
1667 (create_range_type): Add bias parameter.
1668 * printcmd.c (print_scalar_formatted): Unbias range types.
1669 * value.c (unpack_long): Unbias range types.
1670 (pack_long): Bias range types.
1671
d90b8f26
AH
16722019-09-02 Alan Hayward <alan.hayward@arm.com>
1673
1674 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1675 probe arguments.
1676
fe01123e
AH
16772019-09-02 Alan Hayward <alan.hayward@arm.com>
1678
1679 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1680 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1681 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1682 (compile_probe_arg): Likewise.
1683 * probe.h (get_argument_count): Likewise.
1684 * solib-svr4.c (solib_event_probe_action): Likewise.
1685 * stap-probe.c (stap_probe::get_argument_count): Likewise.
1686
e661ef01
AH
16872019-09-02 Alan Hayward <alan.hayward@arm.com>
1688
1689 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1690 code to here...
1691 (svr4_create_solib_event_breakpoints): ...from here.
1692
47a536d9
SDJ
16932019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
1694
1695 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1696 suffix from warning message.
1697
d6a00eba
TT
16982019-08-30 Tom Tromey <tom@tromey.com>
1699
1700 * tui/tui-winsource.h (struct tui_source_window_base)
1701 <refresh_all>: Don't declare.
1702 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1703 Remove.
1704 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1705 tui_show_locator_content.
1706 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1707 declare.
1708 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1709 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1710 declare.
1711
55b2657b
TT
17122019-08-30 Tom Tromey <tom@tromey.com>
1713
1714 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1715
12a8555a
TT
17162019-08-30 Tom Tromey <tom@tromey.com>
1717
1718 * tui/tui-stack.c (_initialize_tui_stack): Move later.
1719 Remove unnecessary forward declarations.
1720
900ac242
TT
17212019-08-30 Tom Tromey <tom@tromey.com>
1722
1723 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1724 rerender.
1725 (tui_update_locator_fullname, tui_show_frame_info): Don't call
1726 tui_show_locator_content.
1727
99ab33fb
TT
17282019-08-30 Tom Tromey <tom@tromey.com>
1729
1730 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
1731 (tui_locator_window::rerender): Rewrite using body of previous
1732 tui_show_locator_content.
1733
e594a5d1
TT
17342019-08-30 Tom Tromey <tom@tromey.com>
1735
1736 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1737 set_locator_fullname>: New methods.
1738 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1739 Rename from tui_set_locator_fullname.
1740 (tui_locator_window::set_locator_info): Rename from
1741 tui_set_locator_info. Return bool.
1742 (tui_update_locator_fullname, tui_show_frame_info): Update.
1743
715bb467
TT
17442019-08-30 Tom Tromey <tom@tromey.com>
1745
1746 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1747
772f3f03
TT
17482019-08-30 Tom Tromey <tom@tromey.com>
1749
1750 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1751 call touchwin.
1752
108e13ab
TT
17532019-08-30 Tom Tromey <tom@tromey.com>
1754
1755 * tui/tui-wingeneral.c (box_win): Assume win_info and
1756 win_info->handle cannot be NULL.
1757
cdaa6eb4
TT
17582019-08-30 Tom Tromey <tom@tromey.com>
1759
1760 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1761 refresh_window>: Declare.
1762 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1763 resize.
1764 (tui_data_item_window::rerender): Rename from
1765 tui_display_register.
1766 (tui_data_item_window::refresh_window): New method.
1767 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1768 no-op.
1769
89df7f90
TT
17702019-08-30 Tom Tromey <tom@tromey.com>
1771
1772 * tui/tui-regs.h (struct tui_data_window) <regs_content,
1773 regs_column_count, current_group>: Move later. Now private.
1774 <get_current_group>: New method.
1775 * tui/tui-regs.c (tui_reg_command): Update.
1776 * tui/tui-layout.c (tui_set_layout): Update.
1777
1bf2866a
TT
17782019-08-30 Tom Tromey <tom@tromey.com>
1779
1780 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1781 (tui_data_window::rerender): Don't call
1782 check_and_display_highlight_if_needed.
1783 (tui_data_window::refresh_all): Remove call to
1784 erase_data_content.
1785
0670413d
TT
17862019-08-30 Tom Tromey <tom@tromey.com>
1787
1788 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1789 (tui_data_window::display_registers_from)
1790 (tui_data_window::display_reg_element_at_line)
1791 (tui_data_window::display_registers_from_line): Remove checks of
1792 "empty".
1793
18bb55c7
TT
17942019-08-30 Tom Tromey <tom@tromey.com>
1795
1796 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1797 Don't declare.
1798 * tui/tui-regs.c (tui_data_window::show_registers): Call
1799 rerender.
1800 (tui_data_window::rerender): Rename from display_all_data.
1801 (tui_data_window::rerender): Remove old implementation.
1802
1f6d2f10
TT
18032019-08-30 Tom Tromey <tom@tromey.com>
1804
1805 * tui/tui-regs.c (tui_data_window::display_all_data): Change
1806 text.
1807 * tui/tui-data.h (NO_DATA_STRING): Remove define.
1808
16d01f9c
BW
18092019-08-29 Bernhard Wodok <barto@gmx.net>
1810 Sergio Durigan Junior <sergiodj@redhat.com>
1811
1812 PR win32/24284
1813 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1814
d8f27c60
AB
18152019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1816
1817 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1818 when searching for types.
1819
1f20c35e
AB
18202019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1821
1822 * f-lang.c (f_language_defn): Use f_print_typedef.
1823 * f-lang.h (f_print_typedef): Declare.
1824 * f-typeprint.c (f_print_typedef): Define.
1825
550105b7
CB
18262019-08-27 Christian Biesinger <cbiesinger@google.com>
1827
1828 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1829
4acfdd20
AB
18302019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
1831
1832 * cli/cli-utils.c (info_print_options_defs): Delete.
1833 (make_info_print_options_def_group): Delete.
1834 (extract_info_print_options): Delete.
1835 (info_print_command_completer): Delete.
1836 (info_print_args_help): Add extra parameter, and optionally
1837 include text about -n flag.
1838 * cli/cli-utils.h (struct info_print_options): Delete.
1839 (extract_info_print_options): Delete declaration.
1840 (info_print_command_completer): Delete declaration.
1841 (info_print_args_help): Add extra parameter, extend header
1842 comment.
1843 * python/python.c (gdbpy_rbreak): Pass additional parameter to
1844 search_symbols.
1845 * stack.c (struct info_print_options): New type.
1846 (info_print_options_defs): New file scoped variable.
1847 (make_info_print_options_def_group): New static function.
1848 (info_print_command_completer): New static function.
1849 (info_locals_command): Update to use new local functions.
1850 (info_args_command): Likewise.
1851 (_initialize_stack): Add extra parameter to calls to
1852 info_print_args_help.
1853 * symtab.c (search_symbols): Add extra parameter, use this to
1854 possibly excluse non-debug symbols.
1855 (symtab_symbol_info): Add extra parameter, which is passed on to
1856 search_symbols.
1857 (struct info_print_options): New type.
1858 (info_print_options_defs): New file scoped variable.
1859 (make_info_print_options_def_group): New static function.
1860 (info_print_command_completer): New static function.
1861 (info_variables_command): Update to use local functions, and pass
1862 extra parameter through to symtab_symbol_info.
1863 (info_functions_command): Likewise.
1864 (info_types_command): Pass additional argument through to
1865 symtab_symbol_info.
1866 (rbreak_command): Pass extra argument to search_symbols.
1867 (_initialize_symtab): Add extra arguments for calls to
1868 info_print_args_help, and update help text for 'info variables',
1869 'whereis', and 'info functions' commands.
1870 * symtab.h (search_symbols): Add extra argument to declaration.
1871 * NEWS: Mention new flags.
1872
9aa55206
CB
18732019-08-26 Christian Biesinger <cbiesinger@google.com>
1874
1875 * symtab.c (lookup_static_symbol): Call the new function (and move
1876 it down to be next to lookup_global_symbol).
1877 (struct global_sym_lookup_data): Add block_enum member and rename to...
1878 (struct global_or_static_sym_lookup_data): ...this.
1879 (lookup_symbol_global_iterator_cb): Pass block_index instead of
1880 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1881 (lookup_symbol_global_or_static_iterator_cb): ...this.
1882 (lookup_global_or_static_symbol): New function.
1883 (lookup_global_symbol): Call new function.
1884
5c31b358
TV
18852019-08-26 Tom de Vries <tdevries@suse.de>
1886
1887 PR c++/24852
1888 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1889 when pc_probe.prob == NULL.
1890
23c13d42
SM
18912019-08-25 Simon Marchi <simon.marchi@efficios.com>
1892
1893 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1894 variable symbol_linkage to symbol_linkage_.
1895
beadd3e8
SM
18962019-08-25 Simon Marchi <simon.marchi@efficios.com>
1897
1898 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1899 represent whether the symbol is static, dynamic, or we don't
1900 know.
1901
e3ec872f
YS
19022019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
1903
1904 * gdb/rx-tdep.c (rx_register_names): New.
1905 (rx_register_name): Delete.
1906 (rx_psw_type): Delete.
1907 (rx_fpsw_type): Delete.
1908 (rx_register_type): Delete.
1909 (rx_gdbarch_init): Convert target-descriptions.
1910 (_initialize_rx_tdep): Add initialize_tdesc_rx.
1911 * gdb/features/Makefile: Add rx.xml.
1912 * gdb/features/rx.xml: New.
1913 * gdb/features/rx.c: Generated.
1914 * gdb/NEWS: Mention target description support.
1915
d0509ba4
CB
19162019-08-22 Christian Biesinger <cbiesinger@google.com>
1917
1918 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1919 *slot_ptr.
1920
2d41fa11
SDJ
19212019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
1922
1923 * configure.ac: Don't check for 'dlfcn.h' (moved to
1924 gdbsupport/common.m4).
1925 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1926 'gdbsupport/'.
1927 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1928 * compile/compile-c-support.c: Include
1929 'gdbsupport/gdb-dlfcn.h'.
1930 * gdbsupport/common.m4: Check for 'dlfcn.h'.
1931 * gdb-dlfcn.c: Move to...
1932 * gdbsupport/gdb-dlfcn.c: ... here.
1933 * gdb-dlfcn.h: Move to...
1934 * gdbsupport/gdb-dlfcn.h: ... here.
1935
de8af808
SL
19362019-08-23 Sandra Loosemore <sandra@codesourcery.com>
1937
1938 * nios2-tdep.c (struct reg_value): Improve comments. Make
1939 the offset field signed.
1940
27204489
CB
19412019-08-22 Christian Biesinger <cbiesinger@google.com>
1942
1943 * python/lib/gdb/__init__.py (_execute_file): New function.
1944 * python/python.c (python_run_simple_file): Call gdb._execute_file
1945 on Windows.
1946
43771869
AB
19472019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
1948
1949 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1950 all uses as this was never set to anything but a zero value.
1951
26c957f1
PA
19522019-08-21 Bogdan Harjoc <harjoc@gmail.com>
1953
1954 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1955
c07aae6e
CB
19562019-08-21 Christian Biesinger <cbiesinger@google.com>
1957
1958 * tui/tui-data.h (tui_gen_win_info): Add an =default
1959 move constructor, required by some GCC versions.
1960
3960cb7a
JF
19612019-08-21 Jinke Fan <fanjinke51@yeah.net>
1962
1963 * go32-nat.c (go32_sysinfo): Add hygon_p.
1964
04c72a68
TT
19652019-08-20 Tom Tromey <tom@tromey.com>
1966
1967 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1968 line_from_reg_element_no, first_reg_element_no_inline,
1969 display_all_data, delete_data_content_windows,
1970 erase_data_content>: Now private.
1971
072272ce
TT
19722019-08-20 Tom Tromey <tom@tromey.com>
1973
1974 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1975 (tui_unhighlight_win, tui_highlight_win)
1976 (tui_win_info::make_window): Update.
1977 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1978
973961bd
TT
19792019-08-20 Tom Tromey <tom@tromey.com>
1980
1981 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1982 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1983 (MAX_PID_WIDTH): Move to tui-stack.c.
1984 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1985 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1986 (MAX_PID_WIDTH): Move from tui-data.h.
1987
ab0e1f1a
TT
19882019-08-20 Tom Tromey <tom@tromey.com>
1989
1990 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1991 * tui/tui-wingeneral.c (box_win): Change type of win_info.
1992 (box_win): Update.
1993 (tui_gen_win_info::make_window): Rename from tui_make_window.
1994 (tui_win_info::make_window): New method.
1995 (tui_gen_win_info::make_visible): Update.
1996 * tui/tui-source.c (tui_source_window::set_contents): Update.
1997 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1998 (tui_data_window::display_registers_from): Update.
1999 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2000 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2001 Declare.
2002 <can_box>: Remove.
2003 <title>: Remove.
2004 (struct tui_win_info) <make_window>: Declare.
2005 <can_box>: Now virtual.
2006 <title>: New member.
2007 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2008 * tui/tui-command.c (tui_cmd_window::resize): Update.
2009
100c2bf3
TT
20102019-08-20 Tom Tromey <tom@tromey.com>
2011
2012 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2013 * tui/tui-regs.c (tui_data_window::show_registers): Update.
2014 (tui_data_window::check_register_values): Update.
2015
fa4dc567
TT
20162019-08-20 Tom Tromey <tom@tromey.com>
2017
2018 * tui/tui-regs.h (struct tui_data_window): Use
2019 DISABLE_COPY_AND_ASSIGN.
2020 <regs_content>: Change type, removing unique_ptr.
2021 <tui_data_window>: Add move constructor.
2022 * tui/tui-regs.c (tui_data_window::show_registers)
2023 (tui_data_window::show_register_group)
2024 (tui_data_window::display_registers_from)
2025 (tui_data_window::display_registers_from)
2026 (tui_data_window::first_data_item_displayed)
2027 (tui_data_window::delete_data_content_windows)
2028 (tui_data_window::rerender, tui_data_window::refresh_window)
2029 (tui_data_window::check_register_values): Update.
2030
ca02d7c8
TT
20312019-08-20 Tom Tromey <tom@tromey.com>
2032
2033 * tui/tui-regs.h (struct tui_data_window) <show_registers,
2034 show_register_group>: Declare.
2035 (tui_show_register_group): Don't declare.
2036 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2037 tui_show_registers.
2038 (tui_data_window::show_register_group): Rename from
2039 tui_show_register_group.
2040 (tui_data_window::check_register_values, tui_reg_command):
2041 Update.
2042 * tui/tui-layout.c (tui_set_layout): Update.
2043
63356bfd
TT
20442019-08-20 Tom Tromey <tom@tromey.com>
2045
2046 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2047 Declare.
2048 (tui_check_register_values): Don't declare.
2049 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2050 from tui_check_register_values.
2051 * tui/tui-hooks.c (tui_register_changed): Update.
2052
42cc14a7
TT
20532019-08-20 Tom Tromey <tom@tromey.com>
2054
2055 * tui/tui-regs.c (tui_reg_layout): Move later.
2056 (tui_show_registers): Don't enable TUI mode or change layout.
2057
b9ad3686
TT
20582019-08-20 Tom Tromey <tom@tromey.com>
2059
2060 * tui/tui-regs.h (struct tui_data_item_window)
2061 <~tui_data_item_window>: Remove.
2062 <content>: Now a unique_xmalloc_ptr.
2063 * tui/tui-regs.c (tui_register_format): Return a
2064 unique_xmalloc_ptr.
2065 (tui_get_register): Update.
2066 (~tui_data_item_window): Remove.
2067 (tui_data_window::display_registers_from, tui_display_register):
2068 Update.
2069 * tui/tui-io.h (tui_expand_tabs): Update.
2070 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2071 Remove "col" parameter.
2072
8e114aab
TT
20732019-08-20 Tom Tromey <tom@tromey.com>
2074
2075 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2076 field.
2077 * tui/tui-regs.c (~tui_data_item_window): Update.
2078
1a4f81dd
TT
20792019-08-20 Tom Tromey <tom@tromey.com>
2080
2081 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2082 earlier.
2083
0f8d8876
TT
20842019-08-20 Tom Tromey <tom@tromey.com>
2085
2086 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2087
605dc2c2
TT
20882019-08-20 Tom Tromey <tom@tromey.com>
2089
2090 * tui/tui-source.h (struct tui_source_window): Update.
2091 * tui/tui-regs.c (tui_show_registers): Update.
2092 * tui/tui-disasm.h (struct tui_disasm_window): Update.
2093 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2094 (NO_REGS_STRING): Remove defines.
2095
aedbe3bb
CM
20962019-08-20 Conrad Meyer <cem@FreeBSD.org>
2097
2098 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2099 unnecessary thread walk if remote doesn't support the packet.
2100
7ce8f214
TT
21012019-08-19 Tom Tromey <tromey@adacore.com>
2102
2103 * python/py-value.c (value_has_field): Fix indentation.
2104
f21c2bd7
TT
21052019-08-19 Tom Tromey <tromey@adacore.com>
2106
2107 * printcmd.c (do_one_display, info_display_command): Update.
2108 * block.h (contained_in): Return bool. Add allow_nested
2109 parameter.
2110 * block.c (contained_in): Return bool. Add allow_nested
2111 parameter.
2112
d806ea2d
TT
21132019-08-19 Tom Tromey <tom@tromey.com>
2114
2115 * configure: Rebuild.
2116 * configure.ac: Disallow the combination of -static-libstdc++ and
2117 source highlight.
2118 * source-cache.c (get_language_name): Handle rust.
2119 (source_cache::get_source_lines): Ignore highlighting exceptions.
2120
398fdd60
TT
21212019-08-16 Tom Tromey <tom@tromey.com>
2122
2123 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2124 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2125 (struct tui_source_window_base) <make_visible, refresh_window,
2126 resize>: Remove methods.
2127 <execution_info>: Remove field.
2128 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2129 (tui_show_source_line, tui_source_window_base)
2130 (~tui_source_window_base): Update.
2131 (tui_source_window_base::resize)
2132 (tui_source_window_base::make_visible)
2133 (tui_source_window_base::refresh_window): Remove.
2134 (tui_source_window_base::update_exec_info): Update.
2135 * tui/tui-source.c (tui_source_window::set_contents): Update.
2136 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2137
e699d331
TT
21382019-08-16 Tom Tromey <tom@tromey.com>
2139
2140 * tui/tui-hooks.c (tui_remove_hooks): Don't set
2141 deprecated_query_hook.
2142
bb01dbfc
TT
21432019-08-16 Tom Tromey <tom@tromey.com>
2144
2145 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2146 (tui_update_source_windows_with_line): Update.
2147 * tui/tui-source.h (struct tui_source_window)
2148 <show_symtab_source>: Declare.
2149 (tui_show_symtab_source): Don't declare.
2150 * tui/tui-source.c (tui_show_symtab_source): Rename from
2151 tui_show_symtab_source.
2152
81c82c4b
TT
21532019-08-16 Tom Tromey <tom@tromey.com>
2154
2155 * tui/tui-winsource.h (struct tui_source_window_base)
2156 <set_contents>: Declare.
2157 * tui/tui-winsource.c
2158 (tui_source_window_base::update_source_window_as_is): Update.
2159 * tui/tui-source.h (struct tui_source_window) <set_contents>:
2160 Declare.
2161 (tui_set_source_content): Don't declare.
2162 * tui/tui-source.c (tui_source_window::set_contents): Rename from
2163 tui_set_source_content.
2164 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2165 Declare.
2166 (tui_set_disassem_content): Don't declare.
2167 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2168 tui_set_disassem_content.
2169
2ddaf614
TT
21702019-08-16 Tom Tromey <tom@tromey.com>
2171
2172 * tui/tui-winsource.h (struct tui_source_window_base)
2173 <update_breakpoint_info>: Declare.
2174 (tui_update_breakpoint_info): Don't declare.
2175 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2176 (tui_update_all_breakpoint_info): Update.
2177 (tui_source_window_base::update_breakpoint_info): Rename from
2178 tui_update_breakpoint_info.
2179 (tui_source_window_base::update_exec_info): Update.
2180
017f9828
TT
21812019-08-16 Tom Tromey <tom@tromey.com>
2182
2183 * tui/tui-winsource.h (struct tui_source_window_base)
2184 <update_source_window>: Declare.
2185 (tui_update_source_window): Don't declare.
2186 * tui/tui-winsource.c
2187 (tui_source_window_base::update_source_window): Rename from
2188 tui_update_source_window.
2189 (tui_source_window_base::rerender): Update.
2190 * tui/tui-source.c (tui_source_window::maybe_update): Update.
2191 * tui/tui-disasm.c (tui_show_disassem)
2192 (tui_show_disassem_and_update_source)
2193 (tui_disasm_window::maybe_update): Update.
2194
ed8358e9
TT
21952019-08-16 Tom Tromey <tom@tromey.com>
2196
2197 * tui/tui-winsource.h (struct tui_source_window_base)
2198 <update_source_window_as_is>: Declare.
2199 (tui_update_source_window_as_is): Don't declare.
2200 * tui/tui-winsource.c (tui_update_source_window): Update
2201 (tui_source_window_base::update_source_window_as_is): Rename from
2202 tui_update_source_window_as_is.
2203 (tui_source_window_base::refill): Update.
2204 * tui/tui-source.c (tui_show_symtab_source): Update.
2205 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2206 Update.
2207
20149b6b
TT
22082019-08-16 Tom Tromey <tom@tromey.com>
2209
2210 * tui/tui-winsource.h (tui_update_source_window)
2211 (tui_update_source_window_as_is): Remove "noerror" parameter.
2212 * tui/tui-winsource.c (tui_update_source_window)
2213 (tui_update_source_window_as_is): Remove "noerror" parameter.
2214 (tui_update_source_windows_with_addr)
2215 (tui_update_source_windows_with_line)
2216 (tui_source_window_base::rerender)
2217 (tui_source_window_base::refill): Update.
2218 * tui/tui-source.h (tui_set_source_content)
2219 (tui_show_symtab_source): Remove "noerror" parameter.
2220 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2221 parameter.
2222 (tui_show_symtab_source): Likewise.
2223 (tui_source_window::maybe_update): Update.
2224 * tui/tui-disasm.c (tui_show_disassem)
2225 (tui_show_disassem_and_update_source)
2226 (tui_disasm_window::do_scroll_vertical)
2227 (tui_disasm_window::maybe_update): Update.
2228
2d83e710
TT
22292019-08-16 Tom Tromey <tom@tromey.com>
2230
2231 * tui/tui.c (tui_is_window_visible): Update.
2232 * tui/tui-wingeneral.c (tui_make_window)
2233 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2234 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2235 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2236 (tui_set_win_height_command, parse_scrolling_args): Update.
2237 * tui/tui-source.c (tui_source_window::style_changed): Update.
2238 * tui/tui-regs.c (tui_show_registers)
2239 (tui_data_window::first_data_item_displayed)
2240 (tui_data_window::delete_data_content_windows)
2241 (tui_check_register_values, tui_reg_command): Update.
2242 * tui/tui-disasm.c (tui_show_disassem): Update.
2243 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2244 method.
2245 <is_visible>: Remove field.
2246 * tui/tui-data.c (tui_next_win, tui_prev_win)
2247 (tui_delete_invisible_windows): Update.
2248
d4ab829a
TT
22492019-08-16 Tom Tromey <tom@tromey.com>
2250
2251 * tui/tui-winsource.h (struct tui_source_window_base)
2252 <m_has_locator>: Remove.
2253 * tui/tui-layout.c (show_source_disasm_command, show_data)
2254 (show_source_or_disasm_and_command): Update.
2255
aa7ca1bb
AH
22562019-08-16 Alan Hayward <alan.hayward@arm.com>
2257
2258 * NEWS (Other MI changes): New subsection.
2259 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2260 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2261 * arch-utils.c (default_get_pc_address_flags): New function.
2262 * arch-utils.h (default_get_pc_address_flags): New declaration.
2263 * gdbarch.sh: Add get_pc_address_flags.
2264 * gdbarch.c: Regenerate.
2265 * gdbarch.h: Likewise.
2266 * stack.c (print_pc): New function.
2267 (print_frame_info) (print_frame): Call print_pc.
2268
6eac171f
TV
22692019-08-16 Tom de Vries <tdevries@suse.de>
2270
2271 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2272 print_objfile_section_info.
2273
3df505f6
TT
22742019-08-15 Tom Tromey <tom@tromey.com>
2275
2276 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2277 calling update_cmdwin_start_line.
2278 * tui/tui-winsource.h (struct tui_source_window_base)
2279 <do_make_visible_with_new_height, set_new_height>: Don't declare.
2280 <rerender>: Declare.
2281 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2282 Call rerender.
2283 (tui_source_window_base::set_new_height): Remove.
2284 (tui_source_window_base::rerender): Rename from
2285 do_make_visible_with_new_height.
2286 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2287 resize method.
2288 (tui_win_info::make_invisible_and_set_new_height)
2289 (tui_win_info::make_visible_with_new_height): Remove.
2290 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2291 Declare.
2292 * tui/tui-stack.c (tui_locator_window::rerender): New method.
2293 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2294 do_make_visible_with_new_height>: Don't declare.
2295 <rerender>: Declare.
2296 * tui/tui-regs.c (tui_data_window::rerender): Rename from
2297 set_new_height.
2298 (tui_data_window::do_make_visible_with_new_height): Remove.
2299 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2300 call tui_show_locator_content.
2301 (tui_gen_win_info::resize): Call rerender.
2302 (show_source_or_disasm_and_command): Don't call
2303 tui_show_locator_content.
2304 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2305 method.
2306 (struct tui_win_info) <rerender>: Declare.
2307 <set_new_height, make_invisible_and_set_new_height,
2308 make_visible_with_new_height>: Don't declare.
2309 * tui/tui-data.c (tui_win_list::rerender): New method.
2310 * tui/tui-command.h (struct tui_cmd_window)
2311 <do_make_visible_with_new_height>: Don't declare.
2312 * tui/tui-command.c
2313 (tui_cmd_window::do_make_visible_with_new_height): Remove.
2314
272560b5
TT
23152019-08-15 Tom Tromey <tromey@adacore.com>
2316
2317 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2318 * ada-lang.c (ada_enum_name): Likewise.
2319
08235187
CB
23202019-08-15 Christian Biesinger <cbiesinger@google.com>
2321
2322 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2323 leading underscore.
2324 (GdbOutputErrorFile): Likewise.
2325 (global scope): Adjust constructor calls to GdbOutput{,Error}File
2326 accordingly.
2327 (execute_unwinders): Rename to have a leading underscore.
2328 (auto_load_packages): Likewise.
2329 (global scope): Adjust call to auto_load_packages accordingly.
2330 (GdbSetPythonDirectory): Likewise.
2331 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2332 instead of execute_unwinders.
2333
db502012
TT
23342019-08-15 Tom Tromey <tom@tromey.com>
2335
2336 * tui/tui-layout.c (show_layout, show_source_disasm_command)
2337 (show_data): Don't change window visibility.
2338 (tui_gen_win_info::resize): Remove special case for command
2339 window. Use wresize, when available.
2340 (show_source_or_disasm_and_command): Don't change window
2341 visibility.
2342 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2343 <make_visible>: New method.
2344 * tui/tui-command.c (tui_cmd_window::resize): New method.
2345
3891b65e
TT
23462019-08-15 Tom Tromey <tom@tromey.com>
2347
2348 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2349 (struct tui_source_windows): New.
2350 * tui/tui-winsource.c (tui_display_main): Update.
2351 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2352 (new_height_ok, parse_scrolling_args): Update.
2353 * tui/tui-layout.c (show_layout, show_data): Update.
2354 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2355 (tui_add_to_source_windows): Don't declare.
2356 * tui/tui-data.c (source_windows, tui_source_windows)
2357 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2358
ee556432
TT
23592019-08-15 Tom Tromey <tom@tromey.com>
2360
2361 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2362 Rename from reset.
2363 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2364 * tui/tui-layout.c (show_source_disasm_command, show_data):
2365 Update.
2366 (tui_gen_win_info::resize): Rename.
2367 (show_source_or_disasm_and_command): Update.
2368 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2369 reset.
2370
46f438e3
TT
23712019-08-15 Tom Tromey <tom@tromey.com>
2372
2373 * tui/tui-stack.c (tui_initialize_static_data): Remove.
2374 * tui/tui-interp.c (tui_interp::init): Don't call
2375 tui_initialize_static_data.
2376 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2377
f4ce562c
TT
23782019-08-15 Tom Tromey <tom@tromey.com>
2379
2380 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2381 examine tui_win_list.
2382
c398c3d0
TT
23832019-08-15 Tom Tromey <tom@tromey.com>
2384
2385 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2386 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2387 tui_clear_source_content.
2388 (tui_clear_source_content): Remove.
2389 (tui_source_window_base::do_erase_source_content): Hoist call to
2390 content.clear().
2391 * tui/tui-stack.c (tui_show_frame_info): Don't call
2392 tui_clear_source_content.
2393
e25d2004
TT
23942019-08-15 Tom Tromey <tom@tromey.com>
2395
2396 * tui/tui-winsource.h (struct tui_source_window_base)
2397 <do_erase_source_content>: New method.
2398 <erase_source_content>: New method.
2399 (tui_erase_source_content): Don't declare.
2400 * tui/tui-winsource.c (tui_clear_source_content): Update.
2401 (tui_source_window_base::do_erase_source_content): Rename from
2402 tui_erase_source_content.
2403 (tui_source_window_base::show_source_content): Update.
2404 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2405 * tui/tui-source.h (struct tui_source_window)
2406 <erase_source_content>: New method.
2407 * tui/tui-disasm.h (struct tui_disasm_window)
2408 <erase_source_content>: New method.
2409
002f15c2
TT
24102019-08-15 Tom Tromey <tom@tromey.com>
2411
2412 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2413 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2414 constructor.
2415 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2416 * tui/tui-source.c (tui_set_source_content): Update.
2417 * tui/tui-disasm.c (tui_set_disassem_content): Update.
2418
c9033fe8
TT
24192019-08-15 Tom Tromey <tom@tromey.com>
2420
2421 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2422 * tui/tui-winsource.c (tui_line_is_displayed): Move to
2423 tui-source.c.
2424 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2425 Declare.
2426 * tui/tui-source.c (tui_source_window::line_is_displayed): New
2427 method.
2428 (tui_source_window::maybe_update): Update.
2429
088f37dd
TT
24302019-08-15 Tom Tromey <tom@tromey.com>
2431
2432 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2433 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2434 tui-disasm.c.
2435 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2436 Declare.
2437 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2438 method.
2439 (tui_disasm_window::maybe_update): Update.
2440
a54700c6
TT
24412019-08-15 Tom Tromey <tom@tromey.com>
2442
2443 * tui/tui-winsource.h (struct tui_source_window_base)
2444 <maybe_update>: Declare.
2445 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2446 method.
2447 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2448 Declare.
2449 * tui/tui-source.c (tui_source_window::maybe_update): New method.
2450 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2451 Declare.
2452 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2453
e2a678a5
TT
24542019-08-15 Tom Tromey <tom@tromey.com>
2455
2456 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2457
f2dda477
TT
24582019-08-15 Tom Tromey <tom@tromey.com>
2459
2460 * tui/tui-wingeneral.c: Include tui-stack.h.
2461 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2462 (struct tui_locator_window): Move from tui-data.h.
2463 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2464 (tui_initialize_static_data): Move from tui-data.c.
2465 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2466 (struct tui_locator_window): Move to tui-stack.c.
2467 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2468 (tui_initialize_static_data): Move to tui-stack.c.
2469
ed4a1084
TT
24702019-08-15 Tom Tromey <tom@tromey.com>
2471
2472 * tui/tui-layout.c (show_source_disasm_command)
2473 (show_source_or_disasm_and_command): Use make_visible method, not
2474 tui_make_window.
2475 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2476 Remove.
2477
65962b20
TT
24782019-08-15 Tom Tromey <tom@tromey.com>
2479
2480 * tui/tui-wingeneral.h (tui_make_window): Update.
2481 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2482 parameter.
2483 (tui_gen_win_info::make_visible): Update.
2484 * tui/tui-regs.c (tui_data_window::display_registers_from):
2485 Update.
2486 * tui/tui-layout.c (show_source_disasm_command)
2487 (show_source_or_disasm_and_command): Update.
2488 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2489 (enum tui_box): Remove.
2490 (struct tui_win_info) <can_box>: New method.
2491 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2492 method.
2493
2208ee91
TV
24942019-08-15 Tom de Vries <tdevries@suse.de>
2495
2496 * linux-nat-trad.c: Include gdbarch.h.
2497
75faf5c4
AH
24982019-08-14 Alan Hayward <alan.hayward@arm.com>
2499
2500 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2501 register sizes.
2502
b1c896b3
TT
25032019-08-14 Tom Tromey <tromey@adacore.com>
2504
2505 * darwin-nat.c: Include gdbarch.h.
2506 * darwin-nat-info.c: Include gdbarch.h.
2507
6405cd73
TT
25082019-08-13 Tom Tromey <tom@tromey.com>
2509
2510 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2511 Remove.
2512 * tui/tui-data.c (tui_initialize_static_data): Update.
2513
5216580d
TT
25142019-08-13 Tom Tromey <tom@tromey.com>
2515
2516 * tui/tui-winsource.h (struct tui_exec_info_window)
2517 <~tui_exec_info_window, maybe_allocate_content, get_content,
2518 m_content>: Remove.
2519 (struct tui_source_window_base) <set_exec_info_content,
2520 show_exec_info_content>: Don't declare.
2521 * tui/tui-winsource.c
2522 (tui_exec_info_window::maybe_allocate_content): Remove.
2523 (tui_source_window_base::update_exec_info): Rename from
2524 set_exec_info_content.
2525 (tui_source_window_base::show_exec_info_content)
2526 (tui_source_window_base::update_exec_info): Remove.
2527
93858ad3
TT
25282019-08-13 Tom Tromey <tom@tromey.com>
2529
2530 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2531 declare.
2532 * tui/tui-winsource.c (tui_update_source_window_as_is)
2533 (tui_update_source_windows_with_addr, tui_erase_source_content):
2534 Update.
2535 (tui_clear_exec_info_content): Remove.
2536
e321e7ce
TT
25372019-08-13 Tom Tromey <tom@tromey.com>
2538
2539 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2540 declare.
2541 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2542 call tui_erase_exec_info_content.
2543 (tui_clear_exec_info_content): Rename from
2544 tui_erase_exec_info_content.
2545 (tui_clear_exec_info_content): Delete.
2546
8270ac62
TT
25472019-08-13 Tom Tromey <tom@tromey.com>
2548
2549 * tui/tui-winsource.h (struct tui_source_window_base)
2550 <show_exec_info_content>: Declare.
2551 (tui_show_exec_info_content): Don't declare.
2552 * tui/tui-winsource.c
2553 (tui_source_window_base::show_exec_info_content): Rename from
2554 tui_show_exec_info_content.
2555 (tui_source_window_base::update_exec_info): Update.
2556
7b56485d
TT
25572019-08-13 Tom Tromey <tom@tromey.com>
2558
2559 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2560 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2561 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2562 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2563 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2564 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2565 ... here.
2566
7ba913dc
TT
25672019-08-13 Tom Tromey <tom@tromey.com>
2568
2569 * tui/tui-winsource.h (struct tui_source_window_base)
2570 <update_exec_info>: Declare.
2571 (tui_update_exec_info): Don't declare.
2572 * tui/tui-winsource.c (tui_update_source_window_as_is)
2573 (tui_source_window_base::refresh_all)
2574 (tui_update_all_breakpoint_info): Update.
2575 (tui_source_window_base::update_exec_info): Rename from
2576 tui_update_exec_info.
2577 * tui/tui-stack.c (tui_show_frame_info): Update.
2578
37a4a131
TT
25792019-08-13 Tom Tromey <tom@tromey.com>
2580
2581 * tui/tui-winsource.h (struct tui_source_window_base)
2582 <set_exec_info_content>: Declare.
2583 (tui_set_exec_info_content): Don't declare.
2584 * tui/tui-winsource.c
2585 (tui_source_window_base::set_exec_info_content): Rename from
2586 tui_set_exec_info_content.
2587 (tui_update_exec_info): Update.
2588
0bd27e07
TT
25892019-08-13 Tom Tromey <tom@tromey.com>
2590
2591 * tui/tui-winsource.h (struct tui_source_window_base)
2592 <show_source_content>: Declare.
2593 (tui_show_source_content): Don't declare.
2594 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2595 (tui_source_window_base::show_source_content): Rename from
2596 tui_show_source_content.
2597 (tui_source_window_base::refresh_all): Update.
2598 * tui/tui-layout.c (show_source_disasm_command)
2599 (show_source_or_disasm_and_command): Update.
2600
b4ef5aeb
TT
26012019-08-13 Tom Tromey <tom@tromey.com>
2602
2603 * tui/tui-winsource.c (tui_erase_source_content)
2604 (tui_show_source_content, tui_source_window_base::refresh_all):
2605 Update.
2606 * tui/tui-wingeneral.h
2607 (tui_check_and_display_highlight_if_needed): Don't declare.
2608 * tui/tui-wingeneral.c
2609 (tui_win_info::check_and_display_highlight_if_needed): Rename from
2610 check_and_display_highlight_if_needed.
2611 * tui/tui-win.c (tui_rehighlight_all)
2612 (tui_win_info::make_visible_with_new_height): Update.
2613 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2614 (tui_data_window::erase_data_content)
2615 (tui_data_window::display_all_data): Update.
2616 * tui/tui-data.h (struct tui_win_info)
2617 <check_and_display_highlight_if_needed>: Declare.
2618
fede5273
TT
26192019-08-13 Tom Tromey <tom@tromey.com>
2620
2621 * tui/tui-win.c (tui_resize_all): Call
2622 tui_delete_invisible_windows.
2623 * tui/tui-layout.c (show_layout): Call
2624 tui_delete_invisible_windows.
2625 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2626 * tui/tui-data.c (tui_delete_invisible_windows): New function.
2627
22c3f490
TT
26282019-08-13 Tom Tromey <tom@tromey.com>
2629
2630 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
2631 tui_add_win_to_layout.
2632
16cb7910
TT
26332019-08-13 Tom Tromey <tom@tromey.com>
2634
2635 * tui/tui-layout.h (tui_default_win_height): Don't declare.
2636 * tui/tui-layout.c (tui_default_win_height): Now static.
2637
cc0c3ffb
TT
26382019-08-13 Tom Tromey <tom@tromey.com>
2639
2640 * tui/tui-layout.c (show_layout): Unify all layout cases into a
2641 single switch.
2642 (show_source_disasm_command, show_source_or_disasm_and_command):
2643 Don't check current layout.
2644
3f3ffe54
TT
26452019-08-13 Tom Tromey <tom@tromey.com>
2646
2647 * tui/tui-wingeneral.c (make_all_visible): Remove.
2648 (tui_make_all_invisible): Simplify.
2649 * tui/tui-layout.c (tui_make_all_invisible): Move from
2650 tui-wingeneral.c; simplify.
2651 (show_layout): Hoist call to tui_make_all_invisible.
2652 (show_data): Don't call tui_make_all_invisible.
2653
69258091
TT
26542019-08-13 Tom Tromey <tom@tromey.com>
2655
2656 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2657 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2658
62cf57fe
TT
26592019-08-13 Tom Tromey <tom@tromey.com>
2660
2661 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2662 tui-data.c.
2663 (show_source_disasm_command, show_data)
2664 (show_source_or_disasm_and_command): Don't use
2665 tui_set_current_layout_to.
2666 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2667 * tui/tui-data.c (current_layout, tui_current_layout): Move to
2668 tui-layout.c.
2669 (tui_set_current_layout_to): Remove.
2670
2afade5d
TT
26712019-08-13 Tom Tromey <tom@tromey.com>
2672
2673 * tui/tui-layout.c (tui_set_layout): Update.
2674 * tui/tui-data.h (struct tui_layout_def): Remove.
2675 (tui_layout_def): Don't declare.
2676 * tui/tui-data.c (layout_def): Remove.
2677 (tui_layout_def): Remove.
2678
a3504e96
TT
26792019-08-13 Tom Tromey <tom@tromey.com>
2680
2681 * tui/tui-winsource.h (struct tui_source_window_base)
2682 <clear_detail>: No longer "override".
2683 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2684 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2685 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2686 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2687 Remove.
2688 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2689
29c92911
TT
26902019-08-13 Tom Tromey <tromey@adacore.com>
2691
2692 * tracepoint.c: Don't include readline.h or history.h.
2693
86c6b807
TT
26942019-08-12 Tom Tromey <tom@tromey.com>
2695
2696 * configure: Rebuild.
2697 * configure.ac: Check for readline 7.
2698 * NEWS: Mention readline 7 requirement.
2699 * README: Update.
2700
5db2718c
TT
27012019-08-12 Tom Tromey <tom@tromey.com>
2702
2703 * mingw-hdep.c (gdb_select): Remove readline hack.
2704
dac36daf
PFC
27052019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
2706
2707 * blockframe.c (find_pc_partial_function): Set *block to nullptr
2708 when the function fails.
2709
1022c627
AA
27102019-08-09 Andreas Arnez <arnez@linux.ibm.com>
2711
2712 * s390-tdep.c (s390_type_align): New function.
2713 (s390_gdbarch_init): Set it as type_align gdbarch method.
2714
eba4caf2
TV
27152019-08-09 Tom de Vries <tdevries@suse.de>
2716
2717 PR gdb/24591
2718 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2719 pc_low with relocation offset.
2720
123cd851
TT
27212019-08-07 Tom Tromey <tromey@adacore.com>
2722
2723 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2724 (print_frame_args): Update.
2725 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2726 Update.
2727 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2728 * frame.h (struct frame_arg): Add initializers.
2729 <error>: Now a unique_xmalloc_ptr.
2730
3d31bc39
AH
27312019-08-07 Alan Hayward <alan.hayward@arm.com>
2732
2733 * NEWS: Expand the Pointer Authentication entry.
2734 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2735 (aarch64_frame_unmask_lr): ... to this.
2736 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2737 Call aarch64_frame_unmask_lr.
2738 * frame.c (struct frame_info): Add "masked" variable.
2739 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2740 (fprint_frame): Check for masked pc.
2741 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2742 declarations.
2743 * python/py-framefilter.c (py_print_frame): Check for masked pc.
2744 * stack.c (print_frame): Check for masked pc.
2745
0cf9feb9
TT
27462019-08-06 Tom Tromey <tom@tromey.com>
2747
2748 * stabsread.c (patch_block_stabs, read_one_struct_field)
2749 (read_enum_type): Use obstack_strndup.
2750 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2751 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2752 * dwarf2read.c (guess_full_die_structure_name)
2753 (anonymous_struct_prefix): Use obstack_strndup.
2754 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2755 * c-exp.y (yylex): Use obstack_strndup.
2756 * ada-exp.y (write_object_renaming, write_ambiguous_var)
2757 (write_var_or_type): Use obstack_strndup.
2758
efba19b0
TT
27592019-08-06 Tom Tromey <tom@tromey.com>
2760
2761 * symfile.c (reread_symbols): Use obstack_strdup.
2762 * stabsread.c (read_type): Use obstack_strdup.
2763 * gdb_obstack.h (obstack_strdup): New overload.
2764 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2765 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2766 (dwarf2_canonicalize_name): Use obstack_strdup.
2767 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2768 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2769 Use obstack_strdup.
2770
f25102f7
TT
27712019-08-06 Tom Tromey <tom@tromey.com>
2772
2773 * gdb_obstack.h (obstack_strdup): Define.
2774 * gdb_obstack.c (obstack_strdup): Don't define.
2775
021887d8
TT
27762019-08-06 Tom Tromey <tom@tromey.com>
2777
2778 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2779 obstack_strdup.
2780 * typeprint.c (typedef_hash_table::find_global_typedef): Use
2781 obstack_strdup.
2782 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2783 * stabsread.c (common_block_start): Use obstack_strdup.
2784 * objfiles.c (set_objfile_main_name, objfile): Use
2785 obstack_strdup.
2786 * namespace.c (add_using_directive): Use obstack_strdup.
2787 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2788 * jit.c (finalize_symtab): Use obstack_strdup.
2789 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2790 (guess_partial_die_structure_name, partial_die_info::fixup)
2791 (dwarf2_name): Use obstack_strdup.
2792 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2793 obstack_strdup.
2794 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2795 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2796 obstack_strdup.
2797 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2798
d2834edc
PW
27992019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2800
2801 * unittests/help-doc-selftests.c: New file.
2802 * Makefile.in: Add the new file.
2803
590042fc
PW
28042019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2805
2806 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2807 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
2808 the full first line, except when FOR_VALUE_PREFIX. In this case,
2809 the trailing '.' is not output, and the first character is uppercased.
2810 (print_help_for_command): Update call to print_doc_line.
2811 (print_doc_of_command): Likewise.
2812 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2813 * cli/cli-option.c (append_indented_doc): Do not append newline.
2814 (build_help_option): Append newline after first appended_indented_doc
2815 only if a second call is done.
2816 (build_help): Append 2 new lines before each option, except the first
2817 one.
2818 * compile/compile.c (_initialize_compile): Add new lines after
2819 %OPTIONS%, when not at the end of the help.
2820 Change help doc or code
2821 producing the help doc to respect the invariants.
2822 * maint-test-options.c (_initialize_maint_test_options): Likewise.
2823 Also removed the new line after 'Options:', as all other commands
2824 do not put an empty line between 'Options:' and the first option.
2825 * printcmd.c (_initialize_printcmd): Likewise.
2826 * stack.c (_initialize_stack): Likewise.
2827 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2828 incorrectly telling COMMAND is optional.
2829 * ada-lang.c (_initialize_ada_language): Change help doc or code
2830 producing the help doc to respect the invariants.
2831 * ada-tasks.c (_initialize_ada_tasks): Likewise.
2832 * breakpoint.c (_initialize_breakpoint): Likewise.
2833 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2834 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2835 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2836 * cli/cli-style.c (cli_style_option::add_setshow_commands,
2837 _initialize_cli_style): Likewise.
2838 * corelow.c (core_target_info): Likewise.
2839 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2840 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2841 * filesystem.c (_initialize_filesystem): Likewise.
2842 * frame.c (_initialize_frame): Likewise.
2843 * gnu-nat.c (add_task_commands): Likewise.
2844 * infcall.c (_initialize_infcall): Likewise.
2845 * infcmd.c (_initialize_infcmd): Likewise.
2846 * interps.c (_initialize_interpreter): Likewise.
2847 * language.c (_initialize_language): Likewise.
2848 * linux-fork.c (_initialize_linux_fork): Likewise.
2849 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2850 * maint.c (_initialize_maint_cmds): Likewise.
2851 * memattr.c (_initialize_mem): Likewise.
2852 * printcmd.c (_initialize_printcmd): Likewise.
2853 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2854 _RegEx): Likewise.
2855 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2856 * record-btrace.c (_initialize_record_btrace): Likewise.
2857 * record-full.c (_initialize_record_full): Likewise.
2858 * record.c (_initialize_record): Likewise.
2859 * regcache-dump.c (_initialize_regcache_dump): Likewise.
2860 * regcache.c (_initialize_regcache): Likewise.
2861 * remote.c (add_packet_config_cmd, init_remote_threadtests,
2862 _initialize_remote): Likewise.
2863 * ser-tcp.c (_initialize_ser_tcp): Likewise.
2864 * serial.c (_initialize_serial): Likewise.
2865 * skip.c (_initialize_step_skip): Likewise.
2866 * source.c (_initialize_source): Likewise.
2867 * stack.c (_initialize_stack): Likewise.
2868 * symfile.c (_initialize_symfile): Likewise.
2869 * symtab.c (_initialize_symtab): Likewise.
2870 * target-descriptions.c (_initialize_target_descriptions): Likewise.
2871 * top.c (init_main): Likewise.
2872 * tracefile-tfile.c (tfile_target_info): Likewise.
2873 * tracepoint.c (_initialize_tracepoint): Likewise.
2874 * tui/tui-win.c (_initialize_tui_win): Likewise.
2875 * utils.c (add_internal_problem_command): Likewise.
2876 * valprint.c (value_print_option_defs): Likewise.
2877
404f2902
FCE
28782019-08-06 Frank Ch. Eigler <fche@redhat.com>
2879
2880 PR build/24886
2881 * configure.ac: Drop enable-libmcheck support.
2882 * configure, config.in: Rebuild.
2883 * libmcheck.m4: Remove.
2884 * acinclude.m4: Don't include it.
2885 * Makefile.in: Don't distribute it.
2886 * top.c (print_gdb_configuration): Don't mention it.
2887
046bebe1
TT
28882019-08-06 Tom Tromey <tom@tromey.com>
2889
2890 * utils.c (set_output_style): Sometimes pass stream to
2891 emit_style_escape.
2892 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2893 * record-btrace.c (btrace_insn_history): Update.
2894 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2895 method.
2896 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2897 Update initializers.
2898 <m_uiout>: New field.
2899 <m_di>: Move lower.
2900 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2901 Remove "uiout" parameter.
2902 (dump_insns): Update.
2903 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2904 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2905
ddbcedf5
CB
29062019-08-06 Christian Biesinger <cbiesinger@google.com>
2907
2908 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2909 (error_in_psymtab_expansion): Likewise.
2910 (lookup_symbol_via_quick_fns): Likewise.
2911 (basic_lookup_transparent_type_quick): Likewise.
2912 (basic_lookup_transparent_type_1): Likewise.
2913
b08b16c8
TT
29142019-08-06 Tom Tromey <tromey@adacore.com>
2915
2916 * source.c (last_source_error): Now bool.
2917 (print_source_lines_base): Make "noprint" bool. Only open
2918 source file when last_source_visited changes.
2919
cb44333d
TT
29202019-08-06 Tom Tromey <tromey@adacore.com>
2921
2922 * annotate.c (annotate_source_line): Use g_source_cache.
2923 * source-cache.c (source_cache::get_plain_source_lines): Change
2924 parameters. Populate m_offset_cache.
2925 (source_cache::ensure): New method.
2926 (source_cache::get_line_charpos): New method.
2927 (extract_lines): Move lower. Change parameters.
2928 (source_cache::get_source_lines): Move lower.
2929 * source-cache.h (class source_cache): Update comment.
2930 <get_line_charpos>: New method.
2931 <get_source_lines>: Update comment.
2932 <clear>: Clear m_offset_cache.
2933 <get_plain_source_lines>: Change parameters.
2934 <ensure>: New method
2935 <m_offset_cache>: New member.
2936 * source.c (forget_cached_source_info_for_objfile): Update.
2937 (info_source_command): Use g_source_cache.
2938 (find_source_lines, open_source_file_with_line_charpos): Remove.
2939 (print_source_lines_base, search_command_helper): Use g_source_cache.
2940 * source.h (open_source_file_with_line_charpos): Don't declare.
2941 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2942 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2943 Use g_source_cache.
2944
872dceaa
TT
29452019-08-06 Tom Tromey <tromey@adacore.com>
2946
2947 * source-cache.c (source_cache::get_plain_source_lines):
2948 Remove "first_line" and "last_line" parameters.
2949 (source_cache::get_source_lines): Cache plain text.
2950 * source-cache.h (class source_cache)
2951 <get_plain_source_lines>: Update.
2952
269249d9
TT
29532019-08-06 Tom Tromey <tromey@adacore.com>
2954
2955 * source-cache.c (extract_lines): No longer a method.
2956 Changed type of parameter. Include final newline.
2957 (selftests::extract_lines_test): New function.
2958 (_initialize_source_cache): Likewise.
2959 * source-cache.h (class source_cache)
2960 <extract_lines>: Don't declare.
2961
c0e8dcd8
TT
29622019-08-06 Tom Tromey <tromey@adacore.com>
2963
2964 * breakpoint.c (init_breakpoint_sal): Update.
2965 (breakpoint): Update.
2966 * breakpoint.h (struct breakpoint) <filter>: Now a
2967 unique_xmalloc_ptr.
2968
0b27c27d
CB
29692019-08-05 Christian Biesinger <cbiesinger@google.com>
2970
2971 * NEWS: Mention dictionary access on blocks.
2972 * python/py-block.c (blpy_getitem): New function.
2973 (block_object_as_mapping): New struct.
2974 (block_object_type): Use new struct for tp_as_mapping field.
2975
4ee94178
CB
29762019-08-05 Christian Biesinger <cbiesinger@google.com>
2977
2978 * objfiles.h (objfile): Add a comment describing partial symbols.
2979
8abfcabc
TT
29802019-08-05 Tom Tromey <tromey@adacore.com>
2981
2982 * compile/compile.c (_initialize_compile): Use _(), not N_().
2983 * thread.c (_initialize_thread): Use _(), not N_().
2984 * stack.c (_initialize_stack): Use _(), not N_().
2985 * printcmd.c (_initialize_printcmd): Use _(), not N_().
2986
2b79f376
SM
29872019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
2988
2989 * dwarf2read.c (struct dw2_symtab_iterator):
2990 <want_specific_block>: Remove.
2991 <block_index>: Change type to gdb::optional.
2992 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2993 change type of BLOCK_INDEX parameter to gdb::optional.
2994 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2995 (dw2_lookup_symbol): Don't pass argument for
2996 WANT_SPECIFIC_BLOCK.
2997 (dw2_expand_symtabs_for_function): Don't pass argument for
2998 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2999 (class dw2_debug_names_iterator)
3000 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3001 parameter, change BLOCK_INDEX type to gdb::optional.
3002 <m_want_specific_block>: Remove.
3003 <m_block_index>: Change type to gdb::optional.
3004 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3005 gdb::optional. Re-write in function of gdb::optional.
3006 (dw2_debug_names_lookup_symbol): Don't pass argument for
3007 WANT_SPECIFIC_BLOCK.
3008 (dw2_debug_names_expand_symtabs_for_function): Don't pass
3009 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3010 BLOCK_INDEX.
3011
ae60f04e
PW
30122019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3013
3014 * NEWS: Mention changes to "info sources" command.
3015
28cd9371
PW
30162019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3017
3018 * symtab.c (filename_partial_match_opts): New struct type.
3019 (struct output_source_filename_data): New members
3020 regexp, c_regexp, partial_match.
3021 (output_source_filename): Use new members to decide to print file.
3022 (info_sources_option_defs): New variable.
3023 (make_info_sources_options_def_group, print_info_sources_header,
3024 info_sources_command_completer):
3025 New functions.
3026 (info_sources_command): Read new optional arguments.
3027 (_initialize_symtab): Update info sources help.
3028
ca683e3a
AO
30292019-08-02 Alexandre Oliva <oliva@adacore.com>
3030
3031 * ada-lang.c (exception_support_info_v0): Renamed from...
3032 (default_exception_support_info): ... this. Create new
3033 definition for v1.
3034 (ada_has_this_exception_support): Look up catch_handlers_sym.
3035 (ada_exception_support_info_sniffer): Try v0 after default.
3036
f1264162
TT
30372019-08-01 Tom Tromey <tromey@adacore.com>
3038
3039 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3040 gdbarch.h.
3041
0a7b2485
CB
30422019-08-01 Christian Biesinger <cbiesinger@google.com>
3043
3044 * s12z-tdep.c: Fix include path for s12z-opc.h.
3045
c6bdbeb7
AH
30462019-08-01 Alan Hayward <alan.hayward@arm.com>
3047
3048 * NEWS: Require GNU make 3.82.
3049
a2bd7b82
TT
30502019-07-16 Tom Tromey <tom@tromey.com>
3051
3052 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3053 declare.
3054
aa3b6533
TT
30552019-07-30 Tom Tromey <tromey@adacore.com>
3056
3057 * block.c (contained_in): Remove BLOCK_FUNCTION check.
3058
a1530dc7
KB
30592019-07-30 Kevin Buettner <kevinb@redhat.com>
3060
3061 * printcmd.c (print_address_symbolic): Print negative offsets.
3062 (build_address_symbolic): Force signed arithmetic when computing
3063 offset.
3064
2906593f
CB
30652019-07-30 Christian Biesinger <cbiesinger@google.com>
3066
3067 PR/24474: Add a function to lookup static variables.
3068 * NEWS: Mention this new function.
3069 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3070 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3071 * python/python.c (python_GdbMethods): Add new function.
3072
c620ed88
CB
30732019-07-29 Christian Biesinger <cbiesinger@google.com>
3074
3075 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3076 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3077 (objfpy_lookup_static_symbol): New function.
3078 (objfile_object_methods): Add new functions.
3079
bc4268a5
PW
30802019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3081
3082 * NEWS: Mention 'set|show print frame-info'. Mention new
3083 'presence' value for 'frame-arguments'. Mention new '-frame-info'
3084 backtrace argument. Mention that python frame filtering code
3085 is now consistent with what 'backtrace' command prints.
3086
4b5e8d19
PW
30872019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3088
3089 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3090 comments.
3091 (print_frame_info_auto, print_frame_info_source_line,
3092 print_frame_info_location, print_frame_info_source_and_location,
3093 print_frame_info_location_and_address, print_frame_info_short_location):
3094 New declarations.
3095 (struct frame_print_options): New member print_frame_info.
3096 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3097 * stack.h (get_user_print_what_frame_info): New declaration.
3098 (frame_show_address): New declaration.
3099 * stack.c (print_frame_arguments_choices): New value 'presence'.
3100 (print_frame_info_auto, print_frame_info_source_line,
3101 print_frame_info_location, print_frame_info_source_and_location,
3102 print_frame_info_location_and_address, print_frame_info_short_location,
3103 print_frame_info_choices, print_frame_info_print_what): New definitions.
3104 (print_frame_args): Only print dots for args if print frame-arguments
3105 is 'presence'.
3106 (frame_print_option_defs): New element for "frame-info".
3107 (get_user_print_what_frame_info): New function.
3108 (frame_show_address): Make non static. Move comment to stack.h.
3109 (print_frame_info_to_print_what): New function.
3110 (print_frame_info): Update comment. Use fp_opts.print_frame_info
3111 to decide what to print.
3112 (backtrace_command_1): Handle the new print_frame_arguments_presence
3113 value.
3114 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3115 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3116 (py_print_frame): In non-mi mode, use LOCATION as default for
3117 print_what, similarly to frame information printed directly by
3118 backtrace command. Handle frame-info user option in non MI mode.
3119
6bdfee81
KB
31202019-07-27 Kevin Buettner <kevinb@redhat.com>
3121
3122 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3123 Add case for debugging 32-bit target on 64-bit host. Revise
3124 comment.
3125
98a617f8
KB
31262019-07-27 Kevin Buettner <kevinb@redhat.com>
3127
3128 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3129 instead of find_function_entry_range_from_pc.
3130
567238c9
KB
31312019-07-27 Kevin Buettner <kevinb@redhat.com>
3132
3133 * stack.c (find_frame_funname): Remove code which preferred
3134 minsym over symtab sym in "certain pathological cases".
3135
2dc80cf8
KB
3136 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3137 parameter. Change type of "do_demangle" to bool.
3138 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3139 Pass suitable "prefer_sym_over_minsym" flag to
3140 build_address_symbolic(). Don't output "+" for negative offsets.
3141 * printcmd.c (print_address_symbolic): Update invocation of
3142 build_address_symbolic to include a "prefer_sym_over_minsym"
3143 flag.
3144 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3145 Restrict cases in which use of minimal symbol is preferred to that
3146 of a found symbol. Update comments.
3147
1aff7173
KB
3148 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3149 for entry pc when entry pc is out of range for that FDE.
3150
89b085ac
BC
31512019-07-26 Brian Callahan <bcallah@openbsd.org>
3152
3153 PR gdb/24839:
3154 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3155 type.
3156
f32feb4a
CB
31572019-07-25 Christian Biesinger <cbiesinger@google.com>
3158
3159 * python/py-objfile.c (add_separate_debug_file): Fix comment about
3160 this function's Python signature.
3161
3162
31632019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
3164
3165 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3166 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3167 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3168 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3169 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3170
3171
c54e4253
YS
31722019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
3173
3174 * h8300-tdep.c (h8300_register_name_common): New.
3175 h8300_register_name): Use h8300_register_name_common.
3176 (h8300s_register_name): Likewise.
3177 (h8300sx_register_name): Likewise.
3178 (h8300h_register_nam): New.
3179 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3180
3181
40eadf04
SP
31822019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
3183
3184 * arm-tdep.c (arm_skip_cmse_entry): New function.
3185 (arm_is_sgstubs_section): New function.
3186 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3187
bfa2a36d
TT
31882019-07-22 Tom Tromey <tom@tromey.com>
3189
3190 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3191 Don't self-assign.
3192
a8e9d247
AB
31932019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3194
3195 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3196 type_print.
3197
eb86c5e2
AB
31982019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3199
3200 * symtab.c (search_symbols): Adjust msymbol matching type arrays
3201 so that GDB doesn't match any msymbols when searching in the
3202 TYPES_DOMAIN.
3203 (print_symbol_info): Print using typedef_print or type_print based
3204 on the type of the symbol. Add updated FIXME comment moved from...
3205 (_initialize_symtab): ... move and update FIXME comment to above.
3206
a8eab7c6
AB
32072019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3208
3209 * NEWS: Mention adding -q option to "info types".
3210 * symtab.c (struct info_types_options): New struct.
3211 (info_types_options_defs): New variable.
3212 (make_info_types_options_def_group): New function.
3213 (info_types_command): Use gdb::option framework to parse options.
3214 (info_types_command_completer): New function.
3215 (_initialize_symtab): Extend the help text on "info types" and
3216 register command completer.
3217
b4603c34
CB
32182019-07-21 Christian Biesinger <cbiesinger@google.com>
3219
3220 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3221 (lookup_symbol_in_objfile): Change int to block_enum and add a
3222 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3223
c8cdc1e0
CB
32242019-07-20 Christian Biesinger <cbiesinger@google.com>
3225
3226 * MAINTAINERS (Write After Approval): Add self.
3227
01e175fe
AB
32282019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
3229
3230 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3231 instruction to the dummy code region.
3232
56f79b63
TT
32332019-07-19 Tom Tromey <tromey@adacore.com>
3234
3235 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3236 (ARGSUSED, PARAMS, __func__): Remove rules.
3237
4c5aa8e0
AH
32382019-07-19 Alan Hayward <alan.hayward@arm.com>
3239
3240 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3241 * features/arm/arm-with-iwmmxt.c: Remove.
3242 * features/arm/arm-with-iwmmxt.xml: Remove.
3243 * features/arm/arm-with-m-fpa-layout.c: Remove.
3244 * features/arm/arm-with-m-fpa-layout.xml: Remove.
3245 * features/arm/arm-with-m-vfp-d16.c: Remove.
3246 * features/arm/arm-with-m-vfp-d16.xml: Remove.
3247 * features/arm/arm-with-m.c: Remove.
3248 * features/arm/arm-with-m.xml: Remove.
3249 * features/arm/arm-with-neon.c: Remove.
3250 * features/arm/arm-with-neon.xml: Remove.
3251 * features/arm/arm-with-vfpv2.c: Remove.
3252 * features/arm/arm-with-vfpv2.xml: Remove.
3253 * features/arm/arm-with-vfpv3.c: Remove.
3254 * features/arm/arm-with-vfpv3.xml: Remove.
3255
f42b2617
AH
32562019-07-19 Alan Hayward <alan.hayward@arm.com>
3257
3258 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3259
f29ec966
AH
32602019-07-19 Alan Hayward <alan.hayward@arm.com>
3261
3262 * arch/aarch32.c (aarch32_create_target_description): Create
3263 target descriptions using features.
3264 * arch/arm.c (arm_create_target_description)
3265 (arm_create_mprofile_target_description): Likewise.
3266 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3267
d105cce5
AH
32682019-07-19 Alan Hayward <alan.hayward@arm.com>
3269
3270 * Makefile.in: Add new files.
3271 * aarch32-tdep.c: New file.
3272 * aarch32-tdep.h: New file.
3273 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3274 Call aarch32_read_description.
3275 * arch/aarch32.c: New file.
3276 * arch/aarch32.h: New file.
3277 * arch/arm.c (arm_create_target_description)
3278 (arm_create_mprofile_target_description): New function.
3279 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3280 (arm_create_target_description)
3281 (arm_create_mprofile_target_description): New declaration.
3282 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3283 read_description functions.
3284 * arm-linux-nat.c (arm_linux_nat_target::read_description):
3285 Likewise.
3286 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3287 * arm-tdep.c (tdesc_arm_list): New variable.
3288 (arm_register_g_packet_guesses): Call create description functions.
3289 (arm_read_description) (arm_read_mprofile_description): New
3290 function.
3291 * arm-tdep.h (arm_read_description)
3292 (arm_read_mprofile_description): Add declaration.
3293 * configure.tgt: Add new files.
3294
afe09f0b
GL
32952019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
3296
3297 * top.c (new_ui_command): Open specified terminal just once.
3298
cd215b2e
TT
32992019-07-18 Tom Tromey <tromey@adacore.com>
3300
3301 * symtab.c (main_name): Constify return type.
3302 * symfile.c (set_initial_language): Update.
3303 * symtab.h (main_name): Constify return type.
3304
d8f68fcb
TT
33052019-07-17 Tom Tromey <tom@tromey.com>
3306
3307 * tui/tui-winsource.c (tui_update_source_window)
3308 (tui_update_source_window_as_is)
3309 (tui_update_source_windows_with_line): Remove return.
3310 * tui/tui-disasm.c (tui_show_disassem)
3311 (tui_show_disassem_and_update_source): Remove return.
3312 * tui/tui.c (tui_reset): Remove return.
3313 * tui/tui-wingeneral.c
3314 (tui_check_and_display_highlight_if_needed): Remove return.
3315
ca5af91e
TT
33162019-07-17 Tom Tromey <tom@tromey.com>
3317
3318 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3319
5104fe36
TT
33202019-07-17 Tom Tromey <tom@tromey.com>
3321
3322 * tui/tui-winsource.h (struct tui_exec_info_window)
3323 (struct tui_source_window_base): Move from tui-data.h.
3324 * tui/tui-winsource.c: Move many method definitions from
3325 elsewhere. Remove "structuring" comments.
3326 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3327 (tui_source_window_base::refresh_window): Move to
3328 tui-winsource.c.
3329 * tui/tui-win.c (tui_source_window_base::refresh_all)
3330 (tui_source_window_base::update_tab_width)
3331 (tui_source_window_base::set_new_height)
3332 (tui_source_window_base::do_make_visible_with_new_height): Move to
3333 tui-winsource.c.
3334 * tui/tui-source.h: Update.
3335 * tui/tui-source.c (tui_source_window_base::reset): Move to
3336 tui-winsource.c.
3337 * tui/tui-disasm.h: Update.
3338 * tui/tui-data.h (struct tui_exec_info_window): Move to
3339 tui-winsource.h.
3340 (struct tui_source_window_base): Likewise.
3341 * tui/tui-data.c (tui_source_window_base::clear_detail)
3342 (tui_source_window_base, ~tui_source_window_base): Move to
3343 tui-winsource.c.
3344
daa15dde
TT
33452019-07-17 Tom Tromey <tom@tromey.com>
3346
3347 * tui/tui-win.c (tui_resize_all)
3348 (tui_source_window_base::update_tab_width)
3349 (tui_adjust_win_heights): Update.
3350 (tui_win_info::make_invisible_and_set_new_height): Rename from
3351 make_invisible_and_set_new_height.
3352 * tui/tui-data.h (struct tui_win_info)
3353 <make_invisible_and_set_new_height>: New method.
3354
bfad4537
TT
33552019-07-17 Tom Tromey <tom@tromey.com>
3356
3357 * tui/tui.c: Update.
3358 * tui/tui-source.h (struct tui_source_window): Move from
3359 tui-data.h.
3360 * tui/tui-layout.c: Update.
3361 * tui/tui-disasm.c: Update.
3362 * tui/tui-data.h (struct tui_source_window): Move to
3363 tui-source.h.
3364
88f7e873
TT
33652019-07-17 Tom Tromey <tom@tromey.com>
3366
3367 * tui/tui-disasm.h (struct tui_disasm_window): Move from
3368 tui-data.h.
3369 * tui/tui-data.h (struct tui_disasm_window): Move to
3370 tui-disasm.h.
3371
96bd6233
TT
33722019-07-17 Tom Tromey <tom@tromey.com>
3373
3374 * tui/tui-regs.h (struct tui_data_item_window): Move from
3375 tui-data.h.
3376 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3377 * tui/tui-data.h (struct tui_data_item_window): Move to
3378 tui-regs.h.
3379 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3380
ce38393b
TT
33812019-07-17 Tom Tromey <tom@tromey.com>
3382
3383 * tui/tui.c: Update.
3384 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3385 (tui_cmd_window::max_height): Move to tui-command.c.
3386 * tui/tui-layout.c: Update.
3387 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3388 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3389 tui-command.c.
3390 * tui/tui-command.h (struct tui_cmd_window): Move from
3391 tui-data.h.
3392 * tui/tui-command.c: Remove "structuring" comments.
3393 (tui_cmd_window::clear_detail)
3394 (tui_cmd_window::do_make_visible_with_new_height)
3395 (tui_cmd_window::max_height): Move from elsewhere.
3396
2d8b51cb
TT
33972019-07-17 Tom Tromey <tom@tromey.com>
3398
3399 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3400 Now static.
3401 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3402 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3403
18ab23af
TT
34042019-07-17 Tom Tromey <tom@tromey.com>
3405
3406 * tui/tui.c: Update.
3407 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3408 tui-regs.c.
3409 * tui/tui-windata.h: Remove file.
3410 * tui/tui-windata.c: Remove file.
3411 * tui/tui-win.c (tui_data_window::set_new_height)
3412 (tui_data_window::do_make_visible_with_new_height): Move to
3413 tui-regs.c.
3414 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3415 * tui/tui-regs.c: Remove "structuring" comments.
3416 (tui_data_window::first_data_item_displayed)
3417 (tui_data_window::delete_data_content_windows)
3418 (tui_data_window::erase_data_content)
3419 (tui_data_window::display_all_data)
3420 (tui_data_window::refresh_all)
3421 (tui_data_window::do_scroll_vertical)
3422 (tui_data_window::clear_detail, tui_data_window::set_new_height)
3423 (tui_data_window::do_make_visible_with_new_height)
3424 (tui_data_window::refresh_window): Move from elsewhere.
3425 (_initialize_tui_regs): Move to end of file.
3426 * tui/tui-layout.c: Update.
3427 * tui/tui-hooks.c: Update.
3428 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3429 * tui/tui-data.c (tui_data_window::clear_detail): Move to
3430 tui-regs.c.
3431 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3432
88b7e7cc
TT
34332019-07-17 Tom Tromey <tom@tromey.com>
3434
3435 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3436 seen.
3437
0fcd3711
TT
34382019-07-17 Tom Tromey <tom@tromey.com>
3439
3440 * tui/tui-win.c (tui_source_window_base::set_new_height)
3441 (tui_source_window_base::do_make_visible_with_new_height): Use
3442 m_has_locator field directly.
3443 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3444 method.
3445 (struct tui_source_window_base) <has_locator>: Likewise.
3446
4a38112d
TT
34472019-07-17 Tom Tromey <tom@tromey.com>
3448
3449 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3450 Don't declare.
3451 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3452 Remove.
3453 * tui/tui-win.c (tui_source_window_base::set_new_height)
3454 (tui_source_window_base::set_new_height)
3455 (make_invisible_and_set_new_height)
3456 (tui_source_window_base::do_make_visible_with_new_height)
3457 (tui_source_window_base::do_make_visible_with_new_height):
3458 Update.
3459 * tui/tui-layout.c (show_source_disasm_command, show_data)
3460 (show_source_or_disasm_and_command): Update.
3461 * tui/tui-layout.c (show_layout): Update.
3462
09129226
TT
34632019-07-17 Tom Tromey <tom@tromey.com>
3464
3465 * tui/tui-layout.c (make_data_window): Remove.
3466 (show_data): Unify creation and re-initialization cases.
3467
4a8a5e84
TT
34682019-07-17 Tom Tromey <tom@tromey.com>
3469
3470 * tui/tui-layout.c (make_source_window, make_disasm_window):
3471 Remove.
3472 (show_data): Unify creation and re-initialization cases.
3473
76d2be8e
TT
34742019-07-17 Tom Tromey <tom@tromey.com>
3475
3476 * tui/tui-layout.c (make_command_window): Remove.
3477 (show_source_disasm_command, show_source_or_disasm_and_command):
3478 Unify creation and re-initialization cases.
3479
890b8bde
TT
34802019-07-17 Tom Tromey <tom@tromey.com>
3481
3482 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3483 creation and re-initialization cases.
3484
2cdfa113
TT
34852019-07-17 Tom Tromey <tom@tromey.com>
3486
3487 * tui/tui-regs.c (tui_get_register): Return void.
3488
8e3cfd09
TT
34892019-07-17 Tom Tromey <tom@tromey.com>
3490
3491 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3492 Simplify.
3493
f4e04977
TT
34942019-07-17 Tom Tromey <tom@tromey.com>
3495
3496 * tui/tui-layout.c (show_source_disasm_command): Simplify window
3497 resetting.
3498
0379b883
TT
34992019-07-17 Tom Tromey <tom@tromey.com>
3500
3501 * tui/tui.h (tui_set_layout_by_name): Don't declare.
3502 * tui/tui-regs.c (tui_reg_layout): New function.
3503 (tui_show_registers, tui_reg_command): Use it.
3504 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3505 (tui_layout_command): Rename from tui_set_layout_by_name. Change
3506 parameters.
3507 (tui_layout_command): Remove.
3508
b7fbad91
TT
35092019-07-17 Tom Tromey <tom@tromey.com>
3510
3511 * tui/tui-layout.h (tui/tui-layout): Return void.
3512 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
3513
4e1e56b9
TT
35142019-07-17 Tom Tromey <tom@tromey.com>
3515
3516 * tui/tui-layout.c (show_source_disasm_command, show_data):
3517 Update.
3518 (reset_locator): Remove.
3519 (show_source_or_disasm_and_command): Update.
3520
1e0c09ba
TT
35212019-07-17 Tom Tromey <tom@tromey.com>
3522
3523 * tui/tui-source.c (tui_source_window_base::reset): Remove
3524 win_type parameter.
3525 * tui/tui-layout.c (make_command_window, make_source_window)
3526 (make_disasm_window, make_data_window)
3527 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3528 (reset_locator, show_source_or_disasm_and_command): Update.
3529 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3530 win_type parameter.
3531 (struct tui_source_window_base) <reset>: Likewise.
3532
1bf605de
TT
35332019-07-17 Tom Tromey <tom@tromey.com>
3534
3535 * tui/tui-layout.c (show_source_disasm_command): Use
3536 reset_locator.
3537 (reset_locator): New function.
3538 (init_and_make_win): Remove.
3539 (show_source_or_disasm_and_command): Use reset_locator.
3540
098f9ed4
TT
35412019-07-17 Tom Tromey <tom@tromey.com>
3542
3543 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3544 condition.
3545 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3546 Remove condition.
3547 * tui/tui-source.c (tui_source_window_base::reset): New method.
3548 * tui/tui-layout.c (make_command_window): Don't call
3549 init_and_make_win.
3550 (make_source_window, make_disasm_window): Don't call
3551 make_source_or_disasm_window.
3552 (make_data_window): Don't call init_and_make_win. Change calling
3553 convention.
3554 (show_source_disasm_command, show_data): Simplify.
3555 (make_source_or_disasm_window): Remove.
3556 (show_source_or_disasm_and_command): Simplify.
3557 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3558 (struct tui_source_window_base) <reset>: Likewise.
3559 <execution_info>: Remove initializer.
3560 * tui/tui-data.c (tui_source_window_base): Initialize
3561 execution_info.
3562
80110957
TT
35632019-07-17 Tom Tromey <tom@tromey.com>
3564
3565 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3566 variable.
3567
cf82af05
TT
35682019-07-17 Tom Tromey <tom@tromey.com>
3569
3570 * tui/tui.c (tui_rl_other_window): Update.
3571 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3572 superclass method first. Always iterate over regs_content.
3573 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3574 method.
3575 * tui/tui-win.c (tui_set_focus_command): Update.
3576
01aeb396
TT
35772019-07-17 Tom Tromey <tom@tromey.com>
3578
3579 * tui/tui-win.c (tui_set_focus_command): Rename from
3580 tui_set_focus. Call tui_enable.
3581 (tui_set_focus_command): Remove.
3582
fd6c75ee
TT
35832019-07-17 Tom Tromey <tom@tromey.com>
3584
3585 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3586 refresh_window.
3587 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3588 touchwin.
3589 (tui_data_window::refresh_window): Call refresh_window on data
3590 items. Always call superclass refresh_window.
3591 (tui_win_info::refresh): Remove.
3592 (tui_source_window_base::refresh_window): Update.
3593 (tui_refresh_all): Update.
3594 * tui/tui-layout.c (show_source_disasm_command): Remove call to
3595 refresh_window.
3596 (show_source_or_disasm_and_command): Likewise.
3597 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3598 (struct tui_source_window_base) <refresh>: Likewise.
3599
f6cc34a9
TT
36002019-07-17 Tom Tromey <tom@tromey.com>
3601
3602 * tui/tui-winsource.c (tui_clear_source_content)
3603 (tui_show_source_content): Update.
3604 * tui/tui-source.c (tui_source_window::showing_source_p): Check
3605 whether content is empty.
3606 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3607 Remove.
3608
f31ec9af
TT
36092019-07-17 Tom Tromey <tom@tromey.com>
3610
3611 * tui/tui-winsource.c (tui_erase_source_content): Clear the
3612 window's contents.
3613 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3614 * tui/tui-source.c (tui_set_source_content_nil): Remove.
3615
d1b6f1e5
TT
36162019-07-17 Tom Tromey <tom@tromey.com>
3617
3618 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3619 (struct tui_data_item_window): Update.
3620
d9743a13
TT
36212019-07-17 Tom Tromey <tom@tromey.com>
3622
3623 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3624 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3625 defines.
3626
caf0bc4e
TT
36272019-07-17 Tom Tromey <tom@tromey.com>
3628
3629 * tui/tui-winsource.h (tui_erase_source_content)
3630 (tui_clear_source_content): Remove "display_prompt" parameter.
3631 * tui/tui-winsource.c (tui_update_source_window_as_is)
3632 (tui_update_source_windows_with_addr): Update.
3633 (tui_clear_source_content): Remove "display_prompt" parameter.
3634 (tui_erase_source_content): Likewise. Simplify.
3635 (tui_show_source_content): Update.
3636 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3637 * tui/tui-stack.c (tui_show_frame_info): Update.
3638 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3639 Remove defines.
3640
9d391078
TT
36412019-07-17 Tom Tromey <tom@tromey.com>
3642
3643 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3644 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3645 parameter.
3646 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3647 parameter.
3648
a38da35d
TT
36492019-07-17 Tom Tromey <tom@tromey.com>
3650
3651 * tui/tui-winsource.c (tui_clear_source_content)
3652 (tui_show_source_content, tui_show_exec_info_content)
3653 (tui_clear_exec_info_content): Update.
3654 * tui/tui-stack.c (tui_show_locator_content): Update.
3655 (tui_show_frame_info): Update.
3656 * tui/tui-source.h (tui_source_window): Don't declare.
3657 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3658 from tui_source_is_displayed.
3659 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3660 Remove field.
3661 (struct tui_source_window_base) <content_in_use>: New field. Now
3662 bool.
3663 (struct tui_source_window) <showing_source_p>: New method.
3664 (TUI_SRC_WIN): Change cast.
3665 * tui/tui-data.c (tui_initialize_static_data): Update.
3666
c2cd8994
TT
36672019-07-17 Tom Tromey <tom@tromey.com>
3668
3669 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3670 location_matches_p.
3671 * tui/tui-source.c (tui_source_window::location_matches_p): New
3672 method.
3673 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3674 method.
3675 * tui/tui-data.h (struct tui_source_window_base)
3676 <location_matches_p>: New method.
3677 (struct tui_source_window, struct tui_disasm_window)
3678 <location_matches_p>: Likewise.
3679
4dde7b34
TT
36802019-07-17 Tom Tromey <tom@tromey.com>
3681
3682 * tui/tui-win.c (tui_set_win_height_command): Rename from
3683 tui_set_win_height.
3684 (tui_set_win_height_command): Remove.
3685
b73dd877
TT
36862019-07-17 Tom Tromey <tom@tromey.com>
3687
3688 * tui/tui-source.c (tui_source_window): New constructor. Add
3689 observer.
3690 (~tui_source_window): New destructor.
3691 (tui_source_window::style_changed): New method.
3692 * tui/tui-hooks.c (tui_redisplay_source): Remove.
3693 (tui_attach_detach_observers): Update.
3694 * tui/tui-data.h (struct tui_source_window): Make constructor not
3695 inline. Add destructor.
3696 (struct tui_source_window) <style_changed>: New method.
3697 <m_observable>: New member.
3698
ae2b5380
TT
36992019-07-17 Tom Tromey <tom@tromey.com>
3700
3701 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3702 * tui/tui-win.c (tui_resize_all): Fix typo.
3703
1ce3e844
TT
37042019-07-17 Tom Tromey <tom@tromey.com>
3705
3706 * tui/tui-wingeneral.h (tui_refresh_all): Update.
3707 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3708 (tui_refresh_all): Remove "list" parameter. Use foreach.
3709 * tui/tui-win.c (window_name_completer): Use foreach.
3710 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3711 (update_tab_width): Likewise.
3712 * tui/tui-layout.c (show_layout): Update.
3713 * tui/tui-data.h (class tui_window_iterator): New.
3714 (struct all_tui_windows): New.
3715 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3716
fe3eaf1c
TT
37172019-07-17 Tom Tromey <tom@tromey.com>
3718
3719 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3720 parameter. Don't reference globals.
3721 (tui_reg_command): Update.
3722
368c1354
TT
37232019-07-17 Tom Tromey <tom@tromey.com>
3724
3725 * tui/tui-regs.c (tui_show_registers): Simplify.
3726
e80cd204
TT
37272019-07-17 Tom Tromey <tom@tromey.com>
3728
3729 * tui/tui-regs.c (tui_show_registers): Update.
3730 (tui_show_register_group): Add win_info parameter.
3731
aca2dd16
TT
37322019-07-17 Tom Tromey <tom@tromey.com>
3733
3734 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3735 Rename from tui_display_reg_element_at_line.
3736 (tui_data_window::display_registers_from_line): Update.
3737 * tui/tui-data.h (struct tui_data_window)
3738 <display_reg_element_at_line>: New method.
3739
517e9505
TT
37402019-07-17 Tom Tromey <tom@tromey.com>
3741
3742 * tui/tui-regs.h (tui_display_registers_from)
3743 (tui_display_registers_from_line): Don't declare.
3744 * tui/tui-windata.c (tui_data_window::display_all_data)
3745 (tui_data_window::refresh_all)
3746 (tui_data_window::do_scroll_vertical): Update.
3747 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3748 from tui_display_registers_from.
3749 (tui_display_reg_element_at_line): Update.
3750 (tui_data_window::display_registers_from_line): Rename from
3751 tui_display_registers_from_line.
3752 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3753 display_registers_from_line>: New methods.
3754
f76d8b19
TT
37552019-07-17 Tom Tromey <tom@tromey.com>
3756
3757 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3758 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3759 from tui_erase_data_content.
3760 (tui_data_window::display_all_data)
3761 (tui_data_window::refresh_all)
3762 (tui_data_window::do_scroll_vertical): Update.
3763 * tui/tui-regs.c (tui_show_registers): Update.
3764 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3765 New method.
3766
b4094625
TT
37672019-07-17 Tom Tromey <tom@tromey.com>
3768
3769 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3770 declare.
3771 * tui/tui-windata.c
3772 (tui_data_window::delete_data_content_windows): Rename from
3773 tui_delete_data_content_windows.
3774 (tui_data_window::display_all_data)
3775 (tui_data_window::do_scroll_vertical): Update.
3776 * tui/tui-data.h (struct tui_data_window)
3777 <delete_data_content_windows>: New method.
3778
c223a729
TT
37792019-07-17 Tom Tromey <tom@tromey.com>
3780
3781 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3782 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3783
50daf268
TT
37842019-07-17 Tom Tromey <tom@tromey.com>
3785
3786 * tui/tui-windata.h (tui_display_all_data): Don't declare.
3787 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3788 from tui_display_all_data.
3789 * tui/tui-win.c
3790 (tui_data_window::do_make_visible_with_new_height): Update.
3791 * tui/tui-regs.c (tui_show_registers): Update.
3792 * tui/tui-layout.c (tui_set_layout): Update.
3793 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3794 method.
3795
df5f8cab
TT
37962019-07-17 Tom Tromey <tom@tromey.com>
3797
3798 * tui/tui-windata.h (tui_display_data_from): Don't declare.
3799 * tui/tui-windata.c (tui_display_data_from): Remove.
3800 (tui_data_window::refresh_all): Update.
3801
80cb6c27
TT
38022019-07-17 Tom Tromey <tom@tromey.com>
3803
3804 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3805 * tui/tui-windata.c (tui_display_data_from_line): Remove.
3806 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3807 tui_display_registers_from_line.
3808 * tui/tui-regs.h (tui_display_registers_from_line): Update.
3809 * tui/tui-regs.c (tui_display_registers_from_line): Remove
3810 "force_display" parameter.
3811
baff0c28
TT
38122019-07-17 Tom Tromey <tom@tromey.com>
3813
3814 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3815 declare.
3816 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3817 Rename from tui_first_reg_element_no_inline.
3818 (tui_display_reg_element_at_line)
3819 (tui_display_registers_from_line): Update.
3820 * tui/tui-data.h (struct tui_data_window)
3821 <first_reg_element_no_inline>: New method.
3822
3b23c5f2
TT
38232019-07-17 Tom Tromey <tom@tromey.com>
3824
3825 * tui/tui-windata.c (tui_display_data_from)
3826 (tui_data_window::do_scroll_vertical): Update.
3827 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3828 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3829 Rename from tui_line_from_reg_element_no.
3830 (tui_display_registers_from_line): Update.
3831 * tui/tui-data.h (struct tui_data_window)
3832 <line_from_reg_element_no>: New method.
3833
0b5ec218
TT
38342019-07-17 Tom Tromey <tom@tromey.com>
3835
3836 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3837 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3838 tui_last_regs_line_no.
3839 (tui_display_reg_element_at_line)
3840 (tui_display_registers_from_line): Update.
3841 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3842 method.
3843
0807ab7b
TT
38442019-07-17 Tom Tromey <tom@tromey.com>
3845
3846 PR tui/24722:
3847 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3848 (tui_update_breakpoint_info): Add "being_deleted" parameter.
3849 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3850 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3851 (tui_update_breakpoint_info): Likewise.
3852 * tui/tui-hooks.c (tui_event_create_breakpoint)
3853 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3854 Update.
3855
9ad7fdef
TT
38562019-07-17 Tom Tromey <tom@tromey.com>
3857
3858 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3859
5813316f
TT
38602019-07-17 Tom Tromey <tom@tromey.com>
3861
3862 * tui/tui-winsource.c (tui_update_source_window_as_is)
3863 (tui_update_source_windows_with_addr): Update.
3864 * tui/tui-source.h (tui_set_source_content)
3865 (tui_show_symtab_source): Add "win_info" parameter.
3866 * tui/tui-source.c (tui_set_source_content): Add "win_info"
3867 parameter.
3868 (tui_show_symtab_source): Likewise.
3869
00e264e7
TT
38702019-07-17 Tom Tromey <tom@tromey.com>
3871
3872 * tui/tui-wingeneral.c
3873 (tui_check_and_display_highlight_if_needed): Check can_highlight.
3874
06210ce4
TT
38752019-07-17 Tom Tromey <tom@tromey.com>
3876
3877 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3878 (struct tui_cmd_window) <can_scroll>: New method.
3879 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3880 method.
3881
381befee
TT
38822019-07-17 Tom Tromey <tromey@adacore.com>
3883
3884 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3885 do_field_signed>: Rename. Change type of "value".
3886 * ui-out.c (ui_out::field_signed): Rename from field_int.
3887 Change type of "value".
3888 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
3889 type of "value".
3890 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3891 do_field_int. Change type of "value".
3892 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3893 do_field_int. Change type of "value".
3894 * tracepoint.c (trace_status_mi, tfind_1)
3895 (print_one_static_tracepoint_marker): Update.
3896 * thread.c (print_thread_info_1, print_selected_thread_frame):
3897 Update.
3898 * stack.c (print_frame, print_frame_info): Update.
3899 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3900 Update.
3901 * source.c (print_source_lines_base): Update.
3902 * skip.c (info_skip_command): Update.
3903 * record-btrace.c (btrace_ui_out_decode_error)
3904 (btrace_call_history_src_line): Update.
3905 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3906 Update.
3907 * progspace.c (print_program_space): Update.
3908 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3909 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3910 do_field_int. Change type of "value".
3911 * mi/mi-out.c (mi_ui_out::do_table_begin)
3912 (mi_ui_out::do_table_header): Update.
3913 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
3914 type of "value".
3915 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3916 (mi_cmd_data_list_changed_registers, output_register)
3917 (mi_cmd_data_read_memory, mi_load_progress)
3918 (mi_cmd_trace_frame_collected): Update.
3919 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3920 Update.
3921 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3922 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3923 (mi_cmd_var_list_children, varobj_update_one): Update.
3924 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3925 (mi_cmd_stack_list_args, list_arg_or_local): Update.
3926 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3927 * inferior.c (print_inferior): Update.
3928 * gdb_bfd.c (print_one_bfd): Update.
3929 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3930 Update.
3931 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3932 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3933 do_field_int. Change type of "value".
3934 * cli-out.c (cli_ui_out::do_field_signed): Rename from
3935 do_field_int. Change type of "value".
3936 * breakpoint.c (watchpoint_check, print_breakpoint_location)
3937 (print_one_breakpoint_location, print_it_catch_fork)
3938 (print_one_catch_fork, print_it_catch_vfork)
3939 (print_one_catch_vfork, print_it_catch_solib)
3940 (print_it_catch_exec, print_it_ranged_breakpoint)
3941 (print_mention_watchpoint, print_mention_masked_watchpoint)
3942 (bkpt_print_it, update_static_tracepoint): Update.
3943 * break-catch-throw.c (print_it_exception_catchpoint): Update.
3944 * break-catch-syscall.c (print_it_catch_syscall): Update.
3945 * ada-tasks.c (print_ada_task_info): Update.
3946 * ada-lang.c (print_it_exception, print_mention_exception):
3947 Update.
3948
6b78c3f8
AB
39492019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
3950
3951 PR breakpoints/24541
3952 * gdbarch.c: Regenerate.
3953 * gdbarch.h: Regenerate.
3954 * gdbarch.sh: Adjust return type and parameter types for
3955 'stap_adjust_register'.
3956 (i386_stap_adjust_register): Adjust signature and return new
3957 register name.
3958 * stap-probe.c (stap_parse_register_operand): Adjust use of
3959 'gdbarch_stap_adjust_register'.
3960
d72a9b85
TT
39612019-07-17 Tom Tromey <tromey@adacore.com>
3962
3963 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
3964 declare VEC.
3965 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3966 std::vector.
3967 (struct s390_process_info): Add initializers.
3968 (s390_add_process): Use new.
3969 (s390_linux_nat_target::low_forget_process): Use delete.
3970 (s390_linux_nat_target::low_new_fork)
3971 (s390_linux_nat_target::stopped_by_watchpoint)
3972 (s390_linux_nat_target::low_prepare_to_resume)
3973 (s390_linux_nat_target::insert_watchpoint)
3974 (s390_linux_nat_target::insert_hw_breakpoint)
3975 (s390_linux_nat_target::remove_watchpoint)
3976 (s390_linux_nat_target::remove_hw_breakpoint): Update.
3977
206e6c58
JB
39782019-07-16 John Baldwin <jhb@FreeBSD.org>
3979
3980 * aarch64-fbsd-nat.c: Include regcache.h.
3981 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3982 argument.
3983 (aarch64_fbsd_nat_target::fetch_registers)
3984 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3985 variable.
3986 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3987
cbde90f2
JB
39882019-07-16 John Baldwin <jhb@FreeBSD.org>
3989
3990 * fbsd-nat.c: Include gdbarch.h.
3991
07128006
TT
39922019-07-15 Tom Tromey <tromey@adacore.com>
3993
3994 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3995
1f77b012
TT
39962019-07-15 Tom Tromey <tromey@adacore.com>
3997
3998 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3999 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4000 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4001 * cli-out.c (cli_ui_out::do_field_int): New method.
4002 * ui-out.c (ui_out::field_unsigned): New method.
4003 * symfile.c (generic_load): Use field_unsigned.
4004 (print_transfer_performance): Likewise.
4005 * record-btrace.c (ui_out_field_uint): Remove.
4006 (btrace_call_history_insn_range, btrace_call_history): Use
4007 field_unsigned.
4008 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4009 field_unsigned.
4010 * ui-out.h (class ui_out) <field_unsigned>: New method.
4011 <do_field_unsigned>: Likewise.
4012
33eca680
TT
40132019-07-15 Tom Tromey <tromey@adacore.com>
4014
4015 * mi/mi-main.c (list_available_thread_groups): Use field_string.
4016 * mi/mi-interp.c (mi_memory_changed): Use field_string.
4017 * target.c (flash_erase_command): Use field_string.
4018 * infrun.c (print_signal_received_reason): Use field_string.
4019 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4020 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4021 field_string.
4022 * ada-tasks.c (print_ada_task_info): Use field_string.
4023
ca8d69be
TT
40242019-07-15 Tom Tromey <tromey@adacore.com>
4025
4026 * target.c (flash_erase_command): Use field_core_addr.
4027 * symfile.c (generic_load): Use field_core_addr.
4028 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4029 Use field_core_addr.
4030 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4031 field_core_addr.
4032
0d4e84ed
AB
40332019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4034
4035 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4036 value if its desired type is smaller than a CORE_ADDR and signed.
4037
9a49df9d
AB
40382019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4039
4040 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4041 of changes to field names, and use new is_reference field to
4042 decide if a property is a reference or not.
4043 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4044 field.
4045 (struct dwarf2_property_baton): Update header comment, rename
4046 'referenced_type' to 'property_type' and update comments.
4047 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4048 default property type, store in property baton, update to take
4049 accound of renamed field.
4050 (read_func_scope): Update call to attr_to_dynamic_prop.
4051 (read_array_type): Likewise.
4052 (dwarf2_per_cu_addr_sized_int_type): New function.
4053 (read_subrange_index_type): Move type finding code to
4054 dwarf2_per_cu_addr_sized_int_type.
4055 (read_subrange_type): Update calls to attr_to_dynamic_prop.
4056 (dwarf2_per_cu_addr_type): New function.
4057 (set_die_type): Update calls to attr_to_dynamic_prop.
4058
b86352cf
AB
40592019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4060
4061 * dwarf2read.c (read_subrange_index_type): New function.
4062 (read_subrange_type): Move code into new function and call it.
4063 * gdbtypes.c (create_range_type): Add some asserts.
4064
603490bf
AB
40652019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4066
4067 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4068 update return statements.
4069 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4070 declaration, and update comment to match.
4071 * gdbtypes.c (resolve_dynamic_array): Update call to
4072 dwarf2_evaluate_property to match new return type.
4073
592f9d27
AB
40742019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4075
4076 * valarith.c (value_subscripted_rvalue): Change lowerbound
4077 parameter type from int to LONGEST.
4078 * value.h (value_subscripted_rvalue): Likewise in declaration.
4079
60cfcb20
AB
40802019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4081
4082 * cli/cli-utils.c (info_print_command_completer): New function.
4083 * cli/cli-utils.h: Add 'completer.h' include, and forward
4084 declaration for 'struct cmd_list_element'.
4085 (info_print_command_completer): Declare.
4086 * stack.c (_initialize_stack): Add completer for 'info locals' and
4087 'info args'.
4088 * symtab.c (_initialize_symtab): Add completer for 'info
4089 variables' and 'info functions'.
4090 * NEWS: Mention completion for additional info commands.
4091
b16507e0
AB
40922019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4093
4094 * cli/cli-utils.c (extract_info_print_args): Delete.
4095 (extract_arg_maybe_quoted): Delete.
4096 (info_print_options_defs): New variable.
4097 (make_info_print_options_def_group): New function.
4098 (extract_info_print_options): Define new function.
4099 * cli/cli-utils.h (extract_info_print_args): Delete.
4100 (struct info_print_options): New structure.
4101 (extract_info_print_options): Declare new function.
4102 * stack.c (info_locals_command): Update to use new
4103 extract_info_print_options, also add a header comment.
4104 (info_args_command): Likewise.
4105 * symtab.c (info_variables_command): Likewise.
4106 (info_functions_command): Likewise.
4107
021d8588
AB
41082019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4109
4110 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4111 to extract string arguments.
4112 * common/common-utils.c (extract_string_maybe_quoted): New function.
4113 * common/common-utils.h (extract_string_maybe_quoted): Declare.
4114
b777eb6d
TT
41152019-07-11 Tom Tromey <tromey@adacore.com>
4116
4117 * main.c (get_init_files): Use GDBINIT, not gdbinit.
4118 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4119 * top.h (gdbinit): Don't declare.
4120 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4121 into...
4122 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
4123 * top.c (gdb_init): Don't call init_cli_cmds.
4124 (gdbinit): Remove.
4125 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4126
72ee03ff
TT
41272019-07-11 Tom Tromey <tromey@adacore.com>
4128
4129 * python/py-inferior.c (add_thread_object): Don't use thread_obj
4130 after it has been moved.
4131
00db9531
SM
41322019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4133
4134 * valops.c (value_must_coerce_to_target): Change return type to
4135 bool.
4136 * value.h (value_must_coerce_to_target): Likewise.
4137
f2478a7e
SM
41382019-07-10 Simon Marchi <simon.marchi@efficios.com>
4139
4140 * breakpoint.c (is_hardware_watchpoint): Remove
4141 forward-declaration.
4142 (is_masked_watchpoint): Change return type to bool.
4143 (is_tracepoint): Likewise.
4144 (is_breakpoint): Likewise.
4145 (is_hardware_watchpoint): Likewise.
4146 (is_watchpoint): Likewise.
4147 (is_no_memory_software_watchpoint): Likewise.
4148 (is_catchpoint): Likewise.
4149 (breakpoint_1): Make FILTER parameter's return type bool.
4150 is_masked_watchpoint): Change return type to bool.
4151 (save_breakpoints): Make FILTER parameter's return type bool.
4152 * breakpoint.h (is_breakpoint): Change return type to bool.
4153 (is_watchpoint): Likewise.
4154 (is_catchpoint): Likewise.
4155 (is_tracepoint): Likewise.
4156
0d12e84c
TT
41572019-07-10 Tom Tromey <tom@tromey.com>
4158
4159 * defs.h: Don't include gdbarch.h.
4160 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4161 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4162 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4163 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4164 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4165 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4166 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4167 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4168 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4169 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4170 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4171 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4172 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4173 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4174 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4175 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4176 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4177 record-btrace.c, record.h, regcache-dump.c, regcache.h,
4178 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4179 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4180 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4181 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4182 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4183 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4184 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4185 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4186 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4187
f06f1252
TT
41882019-07-10 Tom Tromey <tromey@adacore.com>
4189
4190 * ada-lang.h (is_ada_exception_catchpoint): Declare.
4191 * breakpoint.c (init_ada_exception_breakpoint): Register as
4192 bp_catchpoint.
4193 (print_one_breakpoint_location, print_one_breakpoint): Use
4194 is_ada_exception_catchpoint.
4195 * ada-lang.c (class ada_catchpoint_location): Pass
4196 bp_loc_software_breakpoint to bp_location constructor.
4197 (is_ada_exception_catchpoint): New function.
4198
7a5d944b
TT
41992019-07-10 Tom Tromey <tromey@adacore.com>
4200
4201 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
4202 VEC.
4203 (struct arm_exidx_entry): New method operator<.
4204 (struct arm_exidx_data) <section_maps>: Change type.
4205 (arm_exidx_data_free): Remove.
4206 (arm_exidx_data_key): Change type. Move lower.
4207 (arm_exidx_new_objfile): Update.
4208 (arm_compare_exidx_entries): Remove.
4209 (arm_find_exidx_entry, _initialize_arm_tdep)
4210
48c66e1d
TT
42112019-07-10 Tom Tromey <tromey@adacore.com>
4212
4213 * solib-spu.c (ocl_program_data_key): Change type.
4214 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4215 Update.
4216
a269fbf1
TT
42172019-07-10 Tom Tromey <tromey@adacore.com>
4218
4219 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
4220 (struct solib_aix_inferior_data) <library_list>: Change type.
4221 (solib_aix_inferior_data_handle): Change type.
4222 (get_solib_aix_inferior_data): Update.
4223 (solib_aix_free_library_list): Remove.
4224 (library_list_start_library): Update.
4225 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4226 return type.
4227 (solib_aix_get_library_list)
4228 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4229 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4230
c294730c
TT
42312019-07-10 Tom Tromey <tromey@adacore.com>
4232
4233 * solib-dsbt.c (struct dsbt_info): Add initializers.
4234 (solib_dsbt_pspace_data): Change type.
4235 (dsbt_pspace_data_cleanup): Remove.
4236 (get_dsbt_info, _initialize_dsbt_solib): Update.
4237
9d52077d
TT
42382019-07-10 Tom Tromey <tromey@adacore.com>
4239
4240 * spu-tdep.c (spu_overlay_data): Change type.
4241 (spu_get_overlay_table, spu_overlay_new_objfile)
4242 (_initialize_spu_tdep): Update.
4243
22a20dca
TT
42442019-07-10 Tom Tromey <tromey@adacore.com>
4245
4246 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4247 destructor.
4248 (dbx_objfile_data_key): Change type and declare later.
4249 (DBX_SYMFILE_INFO): Rewrite.
4250 * dbxread.c (dbx_objfile_data_key): Change type.
4251 (dbx_symfile_init): Update.
4252 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
4253 (coffstab_build_psymtabs, elfstab_build_psymtabs)
4254 (stabsect_build_psymtabs, _initialize_dbxread): Update.
4255
cb60f420
TT
42562019-07-10 Tom Tromey <tromey@adacore.com>
4257
4258 * jit.c (jit_program_space_key): Change type. Move lower.
4259 (get_jit_program_space_data): Update.
4260 (jit_program_space_data_cleanup): Remove.
4261 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4262 Update.
4263 (struct jit_program_space_data): Add initializers.
4264
51df2ae3
TT
42652019-07-10 Tom Tromey <tromey@adacore.com>
4266
4267 * solib-darwin.c (struct darwin_info): Add initializers.
4268 (solib_darwin_pspace_data): Change type.
4269 (darwin_pspace_data_cleanup): Remove.
4270 (get_darwin_info, _initialize_darwin_solib): Update.
4271
18101a35
TT
42722019-07-10 Tom Tromey <tromey@adacore.com>
4273
4274 * remote-sim.c (struct sim_inferior_data): Add initializers,
4275 constructor, and destructor.
4276 (sim_inferior_data_key): Change type. Move lower.
4277 (check_for_duplicate_sim_descriptor): Update.
4278 (get_sim_inferior_data): Use new. Update.
4279 (~sim_inferior_data_cleanup): Rename from
4280 sim_inferior_data_cleanup. Simplify.
4281 (gdbsim_close_inferior, simulator_command)
4282 (sim_command_completer, _initialize_remote_sim): Update.
4283 (next_pid, INITIAL_PID): Move earlier.
4284
05b08ac1
TT
42852019-07-10 Tom Tromey <tromey@adacore.com>
4286
4287 * python/python-internal.h (create_thread_object): Return
4288 gdbpy_ref.
4289 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4290 * python/py-inferior.c (struct threadlist_entry): Add
4291 constructor.
4292 <thread_obj>: Now a gdbpy_ref.
4293 (thread_to_thread_object): Update.
4294 (add_thread_object): Use new.
4295 (delete_thread_object): Use delete.
4296 (infpy_threads): Update.
4297 (py_free_inferior): Update. Construct "inf_obj" after acquiring
4298 GIL.
4299
32372d80
TT
43002019-07-10 Tom Tromey <tromey@adacore.com>
4301
4302 * valops.c (value_cast): Specialize error message for Ada.
4303
5c458ae8
SM
43042019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4305
4306 * breakpoint.c (breakpoint_1): Update doc and parameter names.
4307
4c462cb0
SM
43082019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4309
4310 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4311 bpstat_should_step): Return bool, adjust comments.
4312 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4313 bpstat_should_step): Likewise.
4314
89abbcc2
AH
43152019-07-10 Alan Hayward <alan.hayward@arm.com>
4316
4317 * features/Makefile: Use feature target descriptions for Arm.
4318 * features/arm/arm-core.c: Generate new file.
4319 * features/arm/arm-fpa.c: Likewise.
4320 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4321 * features/arm/arm-m-profile.c: Likewise.
4322 * features/arm/arm-vfpv2.c: Likewise.
4323 * features/arm/arm-vfpv3.c: Likewise.
4324 * features/arm/xscale-iwmmxt.c: Likewise.
4325 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4326
166a82be
AH
43272019-07-10 Alan Hayward <alan.hayward@arm.com>
4328
4329 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4330 ptrace earlier.
4331
9fb4c7e9
AH
43322019-07-10 Alan Hayward <alan.hayward@arm.com>
4333
4334 * features/aarch64-pauth.c: Regenerate.
4335
e2d0f980
SM
43362019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
4337
4338 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4339 bool.
4340 (bpstat_what): Use false instead of 0.
4341
a38118e5
PA
43422019-07-09 Pedro Alves <palves@redhat.com>
4343
4344 * break-catch-throw.c (is_exception_catchpoint): New.
4345 * breakpoint.c (print_one_breakpoint_location): New parameter
4346 'raw_loc'. Handle it. Use
4347 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4348 looking at the breakpoint's type.
4349 (print_one_breakpoint): If handling "maint info breakpoints", also
4350 print locations of exception catchpoints.
4351 * breakpoint.h (is_exception_catchpoint): Declare.
4352
cb1e4e32
PA
43532019-07-09 Pedro Alves <palves@redhat.com>
4354
4355 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4356 "addr" field.
4357 (allocate_location_exception_catchpoint): New.
4358 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4359 (initialize_throw_catchpoint_ops): Install
4360 allocate_location_exception_catchpoint as allocate_location
4361 method.
4362 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4363 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4364 bp_loc_other.
4365 (breakpoint_address_is_meaningful): Delete.
4366 (bl_address_is_meaningful): New.
4367 (breakpoint_locations_match): Adjust comment.
4368 (bp_location_from_bp_type): New, factored out of...
4369 (bp_location::bp_location(breakpoint *)): ... this.
4370 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4371 factored out of...
4372 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
4373 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4374 breakpoint_address_is_meaningful.
4375 (bp_locations_compare): Adjust comment.
4376 (update_global_location_list): Use bl_address_is_meaningful
4377 instead of breakpoint_address_is_meaningful.
4378 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4379 explicit.
4380 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4381 * python/py-breakpoint.c (bppy_get_location): No longer check
4382 whether location is null.
4383
b58a68fe
PA
43842019-07-09 Pedro Alves <palves@redhat.com>
4385
4386 PR c++/15468
4387 * breakpoint.c (print_one_breakpoint_location): Remove
4388 single-location assert.
4389
268a13a5
TT
43902019-07-09 Tom Tromey <tom@tromey.com>
4391
4392 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4393 * configure: Rebuild.
4394 * configure.ac: Change common to gdbsupport.
4395 * gdbsupport: Rename from common.
4396 * acinclude.m4: Change common to gdbsupport.
4397 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4398 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4399 gdbsupport.
4400 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4401 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4402 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4403 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4404 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4405 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4406 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4407 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4408 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4409 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4410 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4411 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4412 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4413 coff-pe-read.c, command.h, compile/compile-c-support.c,
4414 compile/compile-c.h, compile/compile-cplus-symbols.c,
4415 compile/compile-cplus-types.c, compile/compile-cplus.h,
4416 compile/compile-loc2c.c, compile/compile.c, completer.c,
4417 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4418 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4419 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4420 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4421 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4422 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4423 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4424 features/aarch64-core.c, features/aarch64-fpu.c,
4425 features/aarch64-pauth.c, features/aarch64-sve.c,
4426 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4427 features/i386/32bit-core.c, features/i386/32bit-linux.c,
4428 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4429 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4430 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4431 features/i386/64bit-core.c, features/i386/64bit-linux.c,
4432 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4433 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4434 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4435 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4436 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4437 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4438 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4439 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4440 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4441 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4442 go32-nat.c, guile/guile.c, guile/scm-ports.c,
4443 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4444 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4445 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4446 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4447 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4448 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4449 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4450 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4451 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4452 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4453 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4454 minsyms.c, mips-linux-tdep.c, namespace.h,
4455 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4456 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4457 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4458 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4459 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4460 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4461 nat/linux-waitpid.c, nat/mips-linux-watch.c,
4462 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4463 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4464 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4465 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4466 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4467 procfs.c, producer.c, progspace.h, psymtab.h,
4468 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4469 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4470 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4471 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4472 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4473 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4474 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4475 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4476 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4477 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4478 target-memory.c, target.c, target.h, target/waitstatus.c,
4479 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4480 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4481 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4482 unittests/array-view-selftests.c,
4483 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4484 unittests/common-utils-selftests.c,
4485 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4486 unittests/format_pieces-selftests.c,
4487 unittests/function-view-selftests.c,
4488 unittests/lookup_name_info-selftests.c,
4489 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4490 unittests/mkdir-recursive-selftests.c,
4491 unittests/observable-selftests.c,
4492 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4493 unittests/parse-connection-spec-selftests.c,
4494 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4495 unittests/scoped_fd-selftests.c,
4496 unittests/scoped_mmap-selftests.c,
4497 unittests/scoped_restore-selftests.c,
4498 unittests/string_view-selftests.c, unittests/style-selftests.c,
4499 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4500 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4501 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4502 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4503 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4504 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4505
5b0e2db4
AB
45062019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4507
4508 * linespec.c (decode_digits_list_mode): Set explicit_line to a
4509 bool value.
4510 (decode_digits_ordinary): Set explicit_line field in sal.
4511 * symtab.c (skip_prologue_sal): Don't skip prologue for a
4512 symtab_and_line that was set on an explicit line number in
4513 assembler code. Do always update the recorded symtab and line if
4514 we do skip the prologue.
4515
0ba852ab
AB
45162019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4517
4518 * breakpoint.c (set_breakpoint_location_function): Remove
4519 explicit_loc parameter.
4520 (momentary_breakpoint_from_master): Update call to
4521 set_breakpoint_location_function.
4522 (add_location_to_breakpoint): Likewise.
4523
b3a7d171
AB
45242019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4525
4526 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4527 required features based on default bfd type when no specific bfd
4528 is present.
4529
1f6f6e21
PW
45302019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4531
4532 * NEWS: Mention that GDB printf and eval commands can now print
4533 C-style and Ada-style convenience var strings without
4534 calling the inferior.
4535 * printcmd.c (printf_c_string): Locally print GDB internal var
4536 instead of transiting via the inferior.
4537 (printf_wide_c_string): Likewise.
4538
45392019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 4540
5862c886 4541 PR breakpoints/25011
ea142fbf
AH
4542 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4543
0598af48
TT
45442019-07-04 Tom Tromey <tom@tromey.com>
4545
4546 PR tui/24724:
4547 * tui/tui-winsource.c (tui_clear_source_content): Update.
4548 (tui_source_window_base::set_is_exec_point_at): Fix comment.
4549 (tui_update_breakpoint_info): Update.
4550 (tui_set_exec_info_content): Update.
4551 * tui/tui-source.c (tui_set_source_content_nil): Update.
4552 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4553 has_break.
4554 * tui/tui-data.h (enum tui_bp_flag): New.
4555 (tui_bp_flags): New enum flags type.
4556 (struct tui_source_element) <break_mode>: Change type. Rename
4557 from has_break.
4558 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4559 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
4560 constants.
4561 * tui/tui-winsource.h: Fix comment.
4562
350fab54
AH
45632019-07-04 Alan Hayward <alan.hayward@arm.com>
4564
4565 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4566 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4567 (store_fpregs_to_thread)
4568 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4569 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4570 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4571 (IWMMXT_REGS_SIZE): Add define.
4572 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4573 (fetch_vfp_regs, store_vfp_regs)
4574 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4575 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4576
f0452268
AH
45772019-07-04 Alan Hayward <alan.hayward@arm.com>
4578
4579 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4580 defines.
4581 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4582 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4583 (ARM_INT_REGISTER_SIZE): ...to this.
4584 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4585 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4586 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4587 (arm_linux_collect_gregset, supply_nwfpe_register)
4588 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4589 defines.
4590 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4591 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4592 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4593 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4594 (arm_return_in_memory, arm_store_return_value)
4595 (arm_get_longjmp_target, arm_register_g_packet_guesses)
4596 (arm_record_ld_st_multiple): Likewise.
4597 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4598 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4599
e935475c
AH
46002019-07-04 Alan Hayward <alan.hayward@arm.com>
4601
4602 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4603 AARCH64_DISPLACED_MODIFIED_INSNS.
4604 * aarch64-tdep.c (struct aarch64_displaced_step_data)
4605 (aarch64_displaced_step_copy_insn): Likewise.
4606 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4607 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4608 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4609 ARM_DISPLACED_MODIFIED_INSNS.
4610 * arm-tdep.c (arm_gdbarch_init): Likewise.
4611 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4612 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4613 (struct arm_displaced_step_closure): Use
4614 ARM_DISPLACED_MODIFIED_INSNS.
4615
df0bb381
AH
46162019-07-04 Alan Hayward <alan.hayward@arm.com>
4617
4618 * features/Makefile: Remove unused xml files.
4619 * features/aarch64.xml: Remove.
4620 * features/i386/amd64-avx-avx512-linux.xml: Remove.
4621 * features/i386/amd64-avx-avx512.xml: Remove.
4622 * features/i386/amd64-avx-linux.xml: Remove.
4623 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4624 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4625 * features/i386/amd64-avx-mpx-linux.xml: Remove.
4626 * features/i386/amd64-avx-mpx.xml: Remove.
4627 * features/i386/amd64-avx.xml: Remove.
4628 * features/i386/amd64-linux.xml: Remove.
4629 * features/i386/amd64-mpx-linux.xml: Remove.
4630 * features/i386/amd64-mpx.xml: Remove.
4631 * features/i386/amd64.xml: Remove.
4632 * features/i386/i386-avx-avx512-linux.xml: Remove.
4633 * features/i386/i386-avx-avx512.xml: Remove.
4634 * features/i386/i386-avx-linux.xml: Remove.
4635 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4636 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4637 * features/i386/i386-avx-mpx-linux.xml: Remove.
4638 * features/i386/i386-avx-mpx.xml: Remove.
4639 * features/i386/i386-avx.xml: Remove.
4640 * features/i386/i386-linux.xml: Remove.
4641 * features/i386/i386-mmx-linux.xml: Remove.
4642 * features/i386/i386-mmx.xml: Remove.
4643 * features/i386/i386-mpx-linux.xml: Remove.
4644 * features/i386/i386-mpx.xml: Remove.
4645 * features/i386/i386.xml: Remove.
4646 * features/i386/x32-avx-avx512-linux.xml: Remove.
4647 * features/i386/x32-avx-linux.xml: Remove.
4648 * features/i386/x32-linux.xml: Remove.
4649
edd6266a
AH
46502019-07-04 Alan Hayward <alan.hayward@arm.com>
4651
4652 * regformats/aarch64.dat: Remove.
4653 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4654 * regformats/i386/amd64-avx-linux.dat: Remove.
4655 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4656 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4657 * regformats/i386/amd64-linux.dat: Remove.
4658 * regformats/i386/amd64-mpx-linux.dat: Remove.
4659 * regformats/i386/amd64.dat: Remove.
4660 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4661 * regformats/i386/i386-avx-linux.dat: Remove.
4662 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4663 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4664 * regformats/i386/i386-linux.dat: Remove.
4665 * regformats/i386/i386-mmx-linux.dat: Remove.
4666 * regformats/i386/i386-mpx-linux.dat: Remove.
4667 * regformats/i386/i386.dat: Remove.
4668 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4669 * regformats/i386/x32-avx-linux.dat: Remove.
4670 * regformats/i386/x32-linux.dat: Remove.
4671
2b40fda7
AH
46722019-07-04 Alan Hayward <alan.hayward@arm.com>
4673
4674 * aarch64-tdep.c: Remove xml self tests.
4675 * amd64-linux-tdep.c: Likewise.
4676 * amd64-tdep.c: Likewise.
4677 * i386-linux-tdep.c: Likewise.
4678 * i386-tdep.c: Likewise.
4679
5f4ba3e7
PA
46802019-07-03 Pedro Alves <palves@redhat.com>
4681
4682 PR cli/24732
4683 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4684 (pipe_cmd_option_defs): New.
4685 (make_pipe_cmd_options_def_group): New.
4686 (pipe_command): Use gdb::option::process_options.
4687 (pipe_command_completer): New function.
4688 (_initialize_cli_cmds): Install completer for "pipe" command.
4689
3d9be6f5
PA
46902019-07-03 Pedro Alves <palves@redhat.com>
4691
4692 * cli/cli-option.c (union option_value) <string>: New field.
4693 (struct option_def_and_value): Add ctor, move ctor, dtor and
4694 use DISABLE_COPY_AND_ASSIGN.
4695 (option_def_and_value::clear_value): New.
4696 (parse_option, save_option_value_in_ctx, get_val_type_str)
4697 (add_setshow_cmds_for_options): Handle var_string.
4698 * cli-option.h (union option_def::var_address) <string>: New
4699 field.
4700 (struct string_option_def): New.
4701 * maint-test-options.c (struct test_options_opts): Add default
4702 ctor and use DISABLE_COPY_AND_ASSIGN.
4703 <string_opt>: New field.
4704 (test_options_opts::~test_options_opts): New.
4705 (test_options_opts::dump): Also dump "-string".
4706 (test_options_option_defs): Install "string.
4707
41fc454c
PA
47082019-07-03 Pedro Alves <palves@redhat.com>
4709
4710 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4711 option_value with a null enumeration.
4712 (complete_options): Save the option values in the context.
4713 (save_option_value_in_ctx): New, factored out from ...
4714 (process_options): ... here.
4715 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4716 of the function.
4717 * maint-test-options.c (test_options_opts::dump): New, factored
4718 out from ...
4719 (maintenance_test_options_command_mode): ... here.
4720 (maintenance_test_options_command_completion_result): Delete.
4721 (maintenance_test_options_command_completion_text): Update
4722 comment.
4723 (maintenance_show_test_options_completion_result): Change
4724 prototype. Just print
4725 maintenance_test_options_command_completion_text.
4726 (save_completion_result): New.
4727 (maintenance_test_options_completer_mode): Pass options context to
4728 complete_options, and then save a dump.
4729 (_initialize_maint_test_options): Use add_cmd to install "maint
4730 show test-options-completion-result".
4731
fdbc9870
PA
47322019-07-03 Pedro Alves <palves@redhat.com>
4733
4734 * NEWS (New commands): Mention "with" and "maint with".
4735 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4736 (with_command, with_command_completer): New.
4737 (pipe_command): Adjust to new repeat_previous
4738 interface.
4739 (_initialize_cli_cmds): Install the "with" command and its "w"
4740 alias.
4741 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4742 declarations.
4743 * cli/cli-setshow.c (parse_cli_var_uinteger)
4744 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4745 argument strings for all var_types.
4746 (get_setshow_command_value_string): New, factored out from ...
4747 (do_show_command): ... this.
4748 * cli/cli-setshow.h: Include <string>.
4749 (get_setshow_command_value_string): Declare.
4750 * command.h (repeat_previous): Now returns const char *. Adjust
4751 comment.
4752 * maint.c: Include "cli/cli-cmds.h".
4753 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4754 (_initialize_maint_cmds): Register the "maintenance with" command.
4755 * top.c (repeat_previous): Move bits from pipe_command here:
4756 Return the saved command line, if any; error out if there's no
4757 command to relaunch.
4758
c6ac8931
PA
47592019-07-03 Pedro Alves <palves@redhat.com>
4760
4761 * NEWS (New commands): Mention "maint set/show test-settings"
4762 instead of "maint test-settings".
4763 * maint-test-settings.c (maintenance_test_settings_list): Delete.
4764 (maintenance_test_settings_set_list): Rename to ...
4765 (maintenance_set_test_settings_list): ... this.
4766 (maintenance_test_settings_show_list): Rename to ...
4767 (maintenance_show_test_settings_list): ... this.
4768 (maintenance_test_settings_cmd): Delete.
4769 (maintenance_test_settings_set_cmd): ...
4770 (maintenance_set_test_settings_cmd): ... this.
4771 (maintenance_test_settings_show_cmd): ...
4772 (maintenance_show_test_settings_cmd): ... this.
4773 (maintenance_test_settings_show_value_cmd):
4774 (maintenance_show_test_settings_value_cmd): ... this.
4775 (_initialize_maint_test_settings): No longer install the "maint
4776 test-settings" prefix command. Rename "maint test-settings set"
4777 to "maint set test-settings", and "maint test-settings show" to
4778 "maint show test-settings". Adjust all subcommands.
4779
d1fcf2fd
PA
47802019-07-03 Pedro Alves <palves@redhat.com>
4781
4782 * maint-test-settings.c: Fix file's intro comment. Replace all
4783 references to "test-options" with references to "test-settings",
4784 in comments.
4785
970f9d09
PA
47862019-07-03 Pedro Alves <palves@redhat.com>
4787
4788 * maint-test-settings.c (maintenance_test_settings_xxx)
4789 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4790 New.
4791 (maintenance_test_settings_enums): Use them.
4792 (maintenance_test_settings_enum): Default to
4793 maintenance_test_settings_xxx.
4794 (_initialize_maint_test_settings): Initialize
4795 MAINTENANCE_TEST_SETTINGS_FILENAME.
4796
f3869b1a
SM
47972019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4798
4799 * breakpoint.h (remove_breakpoints_inf): Change return type to
4800 void, move function documentation here.
4801 * breakpoint.c (remove_breakpoints_inf): Change return type to
4802 void, move function documentation to header.
4803
54d66006
PA
48042019-07-02 Pedro Alves <palves@redhat.com>
4805
4806 * NEWS (Completion improvements): Mention "info threads".
4807 * thread.c (struct info_threads_opts, info_threads_option_defs)
4808 (make_info_threads_options_def_group): New.
4809 (info_threads_command): Use gdb::option::process_options.
4810 (info_threads_command_completer): New.
4811 (_initialize_thread): Use gdb::option::build_help to build the
4812 help text for "info threads".
4813
854f6088
SM
48142019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4815
4816 * defs.h (generic_load): Move from here...
4817 * symfile.h (generic_load): ... to here. Rename name parameter
4818 to args.
4819 * symfile.c (generic_load): Add comment.
4820
54ee4252
TT
48212019-07-01 Tom Tromey <tromey@adacore.com>
4822
4823 * dwarf2read.c
4824 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4825 declaration of without_params. Fix formatting.
4826
65392b3e
TT
48272019-07-01 Tom Tromey <tromey@adacore.com>
4828
4829 * ada-exp.y (find_primitive_type): Update.
4830 * ada-lang.h (ada_lookup_symbol): Update.
4831 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4832 parameter.
4833 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4834
7d7571f0
SDJ
48352019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4836
4837 PR breakpoints/24541
4838 * gdbarch.c: Regenerate.
4839 * gdbarch.h: Regenerate.
4840 * gdbarch.sh: Add 'stap_adjust_register'.
4841 * i386-tdep.c: Include '<unordered_set>'.
4842 (i386_stap_adjust_register): New function.
4843 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4844 * stap-probe.c (stap_parse_register_operand): Call
4845 'gdbarch_stap_adjust_register'.
4846
5af5392a
SDJ
48472019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4848
4849 PR python/24742
4850 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4851 * python/python.c (do_start_initialization): Use 'xmalloc'
4852 instead of 'PyMem_Malloc'.
4853
10d06d82
TT
48542019-06-28 Tom Tromey <tromey@adacore.com>
4855
4856 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4857 for Ada.
4858
1b7f24cd
TT
48592019-06-27 Tom Tromey <tromey@adacore.com>
4860
4861 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
4862 objfile_key.
4863 (arm_find_mapping_symbol, arm_record_special_symbol)
4864 (_initialize_arm_tdep): Update.
4865 (arm_objfile_data_free): Remove.
4866
3d507ff2
TT
48672019-06-27 Tom Tromey <tromey@adacore.com>
4868
4869 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4870 to cp_print_static_field.
4871
762c164d
TT
48722019-06-26 Tom Tromey <tromey@adacore.com>
4873
4874 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4875 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4876 declare.
4877
aa2f9bcf
AH
48782019-06-26 Alan Hayward <alan.hayward@arm.com>
4879
4880 * features/aarch64-core.c (create_feature_aarch64_core):
4881 Regenerate.
4882 * features/aarch64-core.xml: Add cpsr flags.
4883
3426ae57
AH
48842019-06-26 Alan Hayward <alan.hayward@arm.com>
4885
4886 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4887 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4888
4838e44c
SM
48892019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4890
4891 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4892 field.
4893 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4894 use.
4895 (arm_record_special_symbol): Don't insert new symbol in sorted
4896 position, push it at the end.
4897
54cc7474
SM
48982019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4899
4900 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4901 (arm_mapping_symbol_s): Remove.
4902 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4903 (arm_mapping_symbol_vec): New typedef.
4904 (struct arm_per_objfile): Add constructor.
4905 <section_maps>: Change type to
4906 std::unique_ptr<arm_mapping_symbol_vec[]>.
4907 (arm_compare_mapping_symbols): Remove.
4908 (arm_find_mapping_symbol): Adjust to section_maps type change.
4909 (arm_objfile_data_free): Call delete on arm_per_objfile.
4910 (arm_record_special_symbol): Adjust to section_maps type change.
4911 Allocate arm_per_objfile with new.
4912
b65b566c
PW
49132019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4914
4915 * cli/cli-cmds.c (alias_command): Compare the alias prefix
4916 with the command prefix.
4917
c2fc64f5
TT
49182019-06-25 Tom Tromey <tom@tromey.com>
4919
4920 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4921 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4922
fb54fa76
TT
49232019-06-25 Tom Tromey <tom@tromey.com>
4924
4925 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4926 type.
4927 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4928 protected.
4929
f7952c57
TT
49302019-06-25 Tom Tromey <tom@tromey.com>
4931
4932 * tui/tui-winsource.c
4933 (tui_source_window_base::set_is_exec_point_at): Add check against
4934 LOA_ADDRESS.
4935
17568d78
TT
49362019-06-25 Tom Tromey <tom@tromey.com>
4937
4938 * tui/tui-source.c (tui_set_source_content): Don't check before
4939 xfree.
4940 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4941
53e7cdba
TT
49422019-06-25 Tom Tromey <tom@tromey.com>
4943
4944 * tui/tui-winsource.h (tui_update_source_window_as_is)
4945 (tui_alloc_source_buffer, tui_line_is_displayed)
4946 (tui_addr_is_displayed): Change type of win_info.
4947 * tui/tui-winsource.c (tui_update_source_window_as_is)
4948 (tui_clear_source_content, tui_show_source_line)
4949 (tui_show_source_content, tui_source_window_base::refill)
4950 (tui_source_window_base::set_is_exec_point_at)
4951 (tui_source_window_base::set_is_exec_point_at)
4952 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4953 (tui_alloc_source_buffer, tui_line_is_displayed)
4954 (tui_addr_is_displayed): Change type of win_info. Update.
4955 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4956 (tui_source_window_base::do_make_visible_with_new_height):
4957 Update.
4958 * tui/tui-source.c (tui_set_source_content)
4959 (tui_set_source_content_nil)
4960 (tui_source_window::do_scroll_vertical): Update.
4961 * tui/tui-layout.c (show_layout): Update.
4962 * tui/tui-disasm.c (tui_set_disassem_content)
4963 (tui_disasm_window::do_scroll_vertical): Update.
4964 * tui/tui-data.h (tui_win_content): Remove.
4965 (struct tui_gen_win_info) <content, content_size>: Remove.
4966 (struct tui_source_element): Add initializers and destructor.
4967 (union tui_which_element, struct tui_win_element): Remove.
4968 (struct tui_source_window_base) <content>: New field.
4969 (struct tui_data_window): Remove destructor.
4970 (tui_alloc_content, tui_free_win_content)
4971 (tui_free_all_source_wins_content): Don't declare.
4972 * tui/tui-data.c (tui_initialize_static_data): Update.
4973 (init_content_element, tui_alloc_content): Remove.
4974 (~tui_gen_win_info): Update.
4975 (~tui_data_window, tui_free_all_source_wins_content)
4976 (tui_free_win_content, free_content, free_content_elements):
4977 Remove.
4978
7908abbf
TT
49792019-06-25 Tom Tromey <tom@tromey.com>
4980
4981 * tui/tui-winsource.h (tui_clear_source_content)
4982 (tui_erase_source_content, tui_show_source_content): Change type
4983 of win_info.
4984 * tui/tui-winsource.c (tui_clear_source_content)
4985 (tui_erase_source_content, tui_show_source_content): Change type
4986 of win_info.
4987 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4988 * tui/tui-source.h (tui_set_source_content_nil): Change type of
4989 win_info.
4990 * tui/tui-source.c (tui_set_source_content_nil): Change type of
4991 win_info.
4992 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4993
02c28df0
TT
49942019-06-25 Tom Tromey <tom@tromey.com>
4995
4996 * tui/tui-winsource.c (tui_clear_source_content)
4997 (tui_source_window_base::set_is_exec_point_at): Update.
4998 * tui/tui-source.c (tui_set_source_content_nil): Update.
4999 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5000 a bool.
5001 * tui/tui-data.c (init_content_element): Update.
5002
6658b1bf
TT
50032019-06-25 Tom Tromey <tom@tromey.com>
5004
5005 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5006 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5007 * tui/tui-layout.c (init_and_make_win): Update.
5008 * tui/tui.h (enum tui_win_type): Update.
5009 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5010 tui_win_is_auxillary.
5011 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5012 tui_win_is_auxillary.
5013
21e1c91e
TT
50142019-06-25 Tom Tromey <tom@tromey.com>
5015
5016 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5017 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5018 (tui_delete_data_content_windows, tui_display_all_data)
5019 (tui_data_window::do_scroll_vertical, tui_display_data_from):
5020 Update.
5021 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5022 * tui/tui-regs.c (tui_last_regs_line_no)
5023 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5024 (tui_show_registers): Update.
5025 (tui_show_register_group): Return void. Update.
5026 (tui_display_registers_from, tui_display_reg_element_at_line)
5027 (tui_display_registers_from_line, tui_check_register_values):
5028 Update.
5029 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5030 member.
5031 (struct tui_data_window) <regs_content>: Now a std::vector.
5032 <regs_content_count>: Remove.
5033 (tui_add_content_elements, tui_free_data_content): Don't declare.
5034 * tui/tui-data.c (tui_data_window::clear_detail): Update.
5035 (init_content_element): Remove DATA_WIN case. Add assert.
5036 (tui_add_content_elements): Remove.
5037 (tui_data_window): Update.
5038 (tui_free_data_content): Remove.
5039 (free_content_elements): Remove DATA_WIN case.
5040
115ac53b
TT
50412019-06-25 Tom Tromey <tom@tromey.com>
5042
5043 * tui/tui-data.c (tui_data_item_window): Update.
5044 * tui/tui-windata.h (tui_check_data_values): Don't declare.
5045 * tui/tui-windata.c (tui_display_all_data)
5046 (tui_display_data_from_line): Update.
5047 (tui_check_data_values): Remove.
5048 * tui/tui-regs.c (tui_show_register_group)
5049 (tui_display_reg_element_at_line): Update.
5050 * tui/tui-hooks.c (tui_register_changed)
5051 (tui_refresh_frame_and_register_information): Call
5052 tui_check_register_values.
5053 * tui/tui-data.h (struct tui_data_window) <data_content,
5054 data_content_count, data_type>: Remove.
5055 (enum tui_data_type): Remove.
5056
5057 * tui/tui-data.c (tui_data_window::clear_detail)
5058 (~tui_data_window): Update.
5059
eaf9738b
TT
50602019-06-25 Tom Tromey <tom@tromey.com>
5061
5062 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5063 declare.
5064 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5065 Rename from tui_first_data_item_displayed. Update.
5066 (tui_data_window::refresh_all)
5067 (tui_data_window::do_scroll_vertical): Update.
5068 * tui/tui-data.h (struct tui_data_window)
5069 <first_data_item_displayed>: Declare new method.
5070
31ca4723
TT
50712019-06-25 Tom Tromey <tom@tromey.com>
5072
5073 * tui/tui-data.h (tui_init_generic_part): Don't declare.
5074 * tui/tui-data.c (tui_init_generic_part): Remove, moving
5075 contents...
5076 (tui_initialize_static_data): ...here.
5077
41bcff7f
TT
50782019-06-25 Tom Tromey <tom@tromey.com>
5079
5080 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5081 (tui_display_registers_from, tui_check_register_values): Update.
5082 (tui_display_register): Remove win_info parameter; update.
5083 (tui_get_register): Change type of parameters.
5084 * tui/tui-data.h (struct tui_data_element): Remove.
5085 (union tui_which_element) <data>: Remove.
5086 <data_window>: Change type.
5087 (struct tui_data_item_window): New.
5088 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5089 case. Add assert.
5090 (~tui_data_item_window): New destructor.
5091 (free_content_elements): Remove DATA_ITEM_WIN case.
5092
d2802c33
TT
50932019-06-25 Tom Tromey <tom@tromey.com>
5094
5095 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5096 Remove.
5097
dd835f8b
TT
50982019-06-25 Tom Tromey <tom@tromey.com>
5099
5100 * tui/tui-data.h (struct tui_command_element): Remove.
5101 (union tui_which_element) <command>: Remove.
5102 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
5103 assert.
5104 (free_content_elements): Remove CMD_WIN case.
5105
bd7db367
TT
51062019-06-25 Tom Tromey <tom@tromey.com>
5107
5108 * tui/tui-layout.c (tui_set_layout): Update.
5109 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5110 * tui/tui-data.c (layout_def): Update.
5111
3add462f
TT
51122019-06-25 Tom Tromey <tom@tromey.com>
5113
5114 * tui/tui-wingeneral.c (tui_refresh_all): Update.
5115 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5116 (tui_source_window_base::set_new_height): Update.
5117 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5118 Update.
5119 (tui_set_locator_fullname, tui_set_locator_info)
5120 (tui_show_frame_info): Update.
5121 * tui/tui-source.c (tui_set_source_content)
5122 (tui_source_is_displayed): Update.
5123 * tui/tui-layout.c (show_source_disasm_command, show_data)
5124 (show_source_or_disasm_and_command): Update.
5125 * tui/tui-disasm.c (tui_set_disassem_content)
5126 (tui_get_begin_asm_address): Update.
5127 * tui/tui-data.h (struct tui_locator_element): Remove.
5128 (union tui_which_element) <locator>: Remove.
5129 (struct tui_locator_window): New.
5130 (tui_locator_win_info_ptr): Change return type.
5131 * tui/tui-data.c (_locator): Change type.
5132 (tui_locator_win_info_ptr): Change return type.
5133 (init_content_element): Remove LOCATOR_WIN case. Add assert.
5134 (tui_alloc_content): Add assert.
5135
489e9d8b
TT
51362019-06-25 Tom Tromey <tom@tromey.com>
5137
5138 * tui/tui-winsource.c
5139 (tui_exec_info_window::maybe_allocate_content): New method.
5140 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5141 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5142 (make_source_or_disasm_window): Add cast.
5143 * tui/tui-data.h (union tui_which_element) <simple_string>:
5144 Remove.
5145 (struct tui_source_info): New.
5146 (struct tui_source_window_base) <execution_info>: Change type.
5147 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5148 case, and add assert.
5149 (tui_alloc_content): Add assert.
5150
c3fabb7d
TT
51512019-06-25 Tom Tromey <tom@tromey.com>
5152
5153 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5154 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5155 * tui/tui-data.c (tui_alloc_win_info): Remove.
5156
bbc228ee
TT
51572019-06-25 Tom Tromey <tom@tromey.com>
5158
5159 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5160 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5161 can_highlight.
5162
5fcee43a
TT
51632019-06-25 Tom Tromey <tom@tromey.com>
5164
5165 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5166 make_visible_with_new_height method.
5167 (tui_win_info::make_visible_with_new_height): New method.
5168 (tui_source_window_base::do_make_visible_with_new_height)
5169 (tui_data_window::do_make_visible_with_new_height)
5170 (tui_cmd_window::do_make_visible_with_new_height): New methods.
5171 (make_visible_with_new_height): Remove.
5172 (tui_resize_all, tui_adjust_win_heights): Use
5173 make_visible_with_new_height method.
5174 * tui/tui-data.h (struct tui_win_info)
5175 <do_make_visible_with_new_height, make_visible_with_new_height>:
5176 New methods.
5177 (struct tui_source_window_base, struct tui_data_window)
5178 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5179 methods.
5180
d83f1fe6
TT
51812019-06-25 Tom Tromey <tom@tromey.com>
5182
5183 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5184 method.
5185 (update_tab_width): Call update_tab_width method.
5186 * tui/tui-data.h (struct tui_win_info)
5187 (struct tui_source_window_base) <update_tab_width>: New methods.
5188
17374de4
TT
51892019-06-25 Tom Tromey <tom@tromey.com>
5190
5191 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5192 parameter.
5193 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5194 parameter.
5195 (tui_gen_win_info::make_visible): Update.
5196 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5197 parameter.
5198 * tui/tui-data.h (enum tui_box): New enum.
5199 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5200
f936bca2
TT
52012019-06-25 Tom Tromey <tom@tromey.com>
5202
5203 * tui/tui-layout.c (make_source_or_disasm_window): Always use
5204 init_and_make_win for EXEC_INFO_WIN.
5205 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5206 longer inline.
5207 (struct tui_win_info) <~tui_win_info>: Inline.
5208 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5209 Don't declare.
5210 * tui/tui-data.c (source_win, disasm_win): Remove globals.
5211 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5212 Remove.
5213 (tui_initialize_static_data): Update.
5214 (~tui_gen_win_info): Handle more cleanup here.
5215 (~tui_source_window_base): Delete "execution_info".
5216 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5217
d6ba6a11
TT
52182019-06-25 Tom Tromey <tom@tromey.com>
5219
5220 * tui/tui-layout.c (make_command_window): Don't set
5221 can_highlight.
5222 (show_source_disasm_command): Call the reset method.
5223 (show_data): Don't set can_highlight. Call the reset method.
5224 (tui_gen_win_info::reset): Rename from init_gen_win_info
5225 (init_and_make_win): Simplify. Return tui_gen_win_info.
5226 (show_source_or_disasm_and_command): Call the reset method.
5227 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5228 (struct tui_cmd_window): Set can_highlight.
5229
48a3bd16
TT
52302019-06-25 Tom Tromey <tom@tromey.com>
5231
5232 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5233 from make_visible.
5234 (tui_make_visible, tui_make_invisible): Rewrite.
5235 (tui_win_info::make_visible): Remove.
5236 (tui_source_window_base::make_visible): Update.
5237 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5238 method. Moved from...
5239 (struct tui_win_info) <make_visible>: ...here.
5240
c3bd716f
TT
52412019-06-25 Tom Tromey <tom@tromey.com>
5242
5243 * tui/tui-winsource.c
5244 (tui_source_window_base::do_scroll_horizontal): Remove direction
5245 parameter.
5246 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5247 direction parameter.
5248 * tui/tui-win.c (tui_win_info::forward_scroll)
5249 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5250 (tui_win_info::right_scroll): Update.
5251 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5252 direction parameter.
5253 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5254 direction parameter.
5255 * tui/tui-data.h (enum tui_scroll_direction): Remove.
5256 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5257 Remove direction parameter.
5258 (struct tui_source_window_base, struct tui_source_window)
5259 (struct tui_disasm_window, struct tui_data_window)
5260 (struct tui_cmd_window): Update.
5261
21c32dca
TT
52622019-06-25 Tom Tromey <tom@tromey.com>
5263
5264 * tui/tui-winsource.h (tui_set_exec_info_content)
5265 (tui_show_exec_info_content, tui_erase_exec_info_content)
5266 (tui_clear_exec_info_content, tui_update_exec_info): Change
5267 argument to tui_source_window_base.
5268 * tui/tui-winsource.c (tui_set_exec_info_content)
5269 (tui_show_exec_info_content, tui_erase_exec_info_content)
5270 (tui_clear_exec_info_content, tui_update_exec_info): Change
5271 argument to tui_source_window_base.
5272
73fbdc65
TT
52732019-06-25 Tom Tromey <tom@tromey.com>
5274
5275 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5276 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5277
33325343
TT
52782019-06-25 Tom Tromey <tom@tromey.com>
5279
5280 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5281 check.
5282
29d2c474
TT
52832019-06-25 Tom Tromey <tom@tromey.com>
5284
5285 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5286 type to void.
5287 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5288 type to void.
5289 * tui/tui-source.c (tui_set_source_content): Update.
5290 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5291
152f3f4b
TT
52922019-06-25 Tom Tromey <tom@tromey.com>
5293
5294 * tui/tui-win.c (window_name_completer, tui_set_focus)
5295 (tui_all_windows_info): Use name method.
5296 * tui/tui-data.h (struct tui_gen_win_info)
5297 (struct tui_source_window, struct tui_disasm_window)
5298 (struct tui_data_window, struct tui_cmd_window) <name>: New
5299 method.
5300 (tui_win_name): Don't declare.
5301 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5302 (tui_win_name): Remove.
5303
be4da588
TT
53042019-06-25 Tom Tromey <tom@tromey.com>
5305
5306 * tui/tui-winsource.h (tui_update_source_window)
5307 (tui_update_source_window_as_is): Change parameter type.
5308 * tui/tui-winsource.c (tui_update_source_window): Change win_info
5309 to be a tui_source_window_base.
5310 (tui_update_source_window_as_is): Likewise.
5311 * tui/tui-win.c (make_visible_with_new_height): Update.
5312
5b81daba
TT
53132019-06-25 Tom Tromey <tom@tromey.com>
5314
5315 * tui/tui-winsource.c (tui_erase_source_content)
5316 (tui_show_source_content, tui_show_exec_info_content)
5317 (tui_erase_exec_info_content): Use refresh_window method.
5318 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5319 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5320 from tui_refresh_win.
5321 (tui_data_window::refresh_window): New method.
5322 (tui_win_info::refresh, tui_source_window_base::refresh)
5323 (tui_refresh_all): Use refresh_window method.
5324 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5325 method.
5326 * tui/tui-regs.c (tui_display_register): Call refresh_window
5327 method.
5328 * tui/tui-layout.c (show_source_disasm_command)
5329 (show_source_or_disasm_and_command): Call refresh_window method.
5330 * tui/tui-data.h (struct tui_gen_win_info)
5331 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5332 New method.
5333
cb2ce893
TT
53342019-06-25 Tom Tromey <tom@tromey.com>
5335
5336 * tui/tui.c (tui_rl_other_window, tui_enable)
5337 (tui_is_window_visible, tui_get_command_dimension): Update.
5338 * tui/tui-winsource.c (tui_update_source_window_as_is)
5339 (tui_clear_source_content, tui_erase_source_content)
5340 (tui_show_source_line, tui_source_window_base::refill)
5341 (tui_source_window_base::do_scroll_horizontal)
5342 (tui_source_window_base::set_is_exec_point_at)
5343 (tui_update_breakpoint_info, tui_set_exec_info_content)
5344 (tui_alloc_source_buffer, tui_line_is_displayed)
5345 (tui_addr_is_displayed): Update.
5346 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5347 (tui_check_and_display_highlight_if_needed)
5348 (tui_win_info::make_visible, tui_win_info::refresh)
5349 (tui_refresh_all): Update.
5350 * tui/tui-windata.c (tui_first_data_item_displayed)
5351 (tui_delete_data_content_windows, tui_erase_data_content)
5352 (tui_display_all_data, tui_data_window::refresh_all)
5353 (tui_check_data_values): Update.
5354 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5355 (tui_set_win_focus_to, tui_win_info::forward_scroll)
5356 (tui_win_info::backward_scroll, tui_refresh_all_win)
5357 (tui_resize_all, tui_set_focus, tui_all_windows_info)
5358 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5359 (tui_source_window_base::set_new_height)
5360 (tui_data_window::set_new_height)
5361 (make_invisible_and_set_new_height)
5362 (make_visible_with_new_height, new_height_ok)
5363 (parse_scrolling_args): Update.
5364 * tui/tui-stack.c (tui_show_frame_info): Update.
5365 * tui/tui-source.c (tui_set_source_content)
5366 (tui_set_source_content_nil, tui_source_is_displayed)
5367 (tui_source_window::do_scroll_vertical): Update.
5368 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5369 (tui_display_registers_from, tui_display_reg_element_at_line)
5370 (tui_check_register_values, tui_reg_command): Update.
5371 * tui/tui-layout.c (tui_default_win_height)
5372 (show_source_disasm_command, show_data, init_and_make_win)
5373 (show_source_or_disasm_and_command): Update.
5374 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5375 (tui_redisplay_readline, tui_mld_flush)
5376 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5377 (tui_getc): Update.
5378 * tui/tui-disasm.c (tui_set_disassem_content)
5379 (tui_disasm_window::do_scroll_vertical): Update.
5380 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5381 Now virtual.
5382 (struct tui_win_info): Derive from tui_gen_win_info.
5383 <~tui_win_info>: Mark as override.
5384 <generic>: Remove member.
5385 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5386 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5387 (~tui_data_window, ~tui_win_info)
5388 (tui_free_all_source_wins_content): Update.
5389 * tui/tui-command.c (tui_refresh_cmd_win): Update.
5390
ab313b35
TT
53912019-06-25 Tom Tromey <tom@tromey.com>
5392
5393 * tui/tui-layout.c (init_and_make_win): Use new.
5394 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5395 destructor, initializers.
5396 (tui_alloc_generic_win_info): Don't declare.
5397 * tui/tui-data.c (_locator): Add argument to constructor.
5398 (source_win, disasm_win): New globals.
5399 (exec_info): Remove.
5400 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5401 Update.
5402 (tui_alloc_generic_win_info): Remove.
5403 (init_content_element): Use new.
5404 (tui_win_info::tui_win_info): Update.
5405 (free_content_elements) <case DATA_WIN>: Use delete.
5406
dc2c33e4
TT
54072019-06-25 Tom Tromey <tom@tromey.com>
5408
5409 * tui/tui-wingeneral.c (tui_refresh_win): Update.
5410 * tui/tui-windata.c (tui_first_data_item_displayed)
5411 (tui_delete_data_content_windows): Update.
5412 * tui/tui-win.c (tui_data_window::set_new_height): Update.
5413 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5414 (tui_display_registers_from, tui_check_register_values): Update.
5415 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5416 pointer.
5417 * tui/tui-data.c (init_content_element): Update. Allocate the new
5418 window.
5419 (tui_free_data_content): Update.
5420 (free_content_elements) <case DATA_WIN>: Free the window.
5421
214a5cbe
TT
54222019-06-25 Tom Tromey <tom@tromey.com>
5423
5424 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5425 Update.
5426 * tui/tui-layout.c (make_command_window)
5427 (show_source_disasm_command, show_data, init_and_make_win)
5428 (show_source_or_disasm_and_command): Update.
5429 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5430 method.
5431 <can_highight, is_highlighted>: Now bool.
5432 (tui_set_win_highlight): Don't declare.
5433 * tui/tui-data.c (tui_set_win_highlight): Remove.
5434
8e2daf15
TT
54352019-06-25 Tom Tromey <tom@tromey.com>
5436
5437 * tui/tui-wingeneral.c (make_visible): Remove check of window
5438 type.
5439
8903bd8a
TT
54402019-06-25 Tom Tromey <tom@tromey.com>
5441
5442 * tui/tui-win.c (tui_win_info::max_height)
5443 (tui_cmd_window::max_height): New methods.
5444 (new_height_ok): Call max_height.
5445 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5446 <max_height>: New method.
5447
3f02ce1e
TT
54482019-06-25 Tom Tromey <tom@tromey.com>
5449
5450 * tui/tui-win.c (tui_source_window_base::set_new_height)
5451 (tui_data_window::set_new_height): New methods.
5452 (make_invisible_and_set_new_height): Call set_new_height method.
5453 * tui/tui-data.h (struct tui_win_info)
5454 (struct tui_source_window_base, struct tui_data_window)
5455 <set_new_height>: New method.
5456
1825f487
TT
54572019-06-25 Tom Tromey <tom@tromey.com>
5458
5459 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5460 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5461 tui_refresh_data_win.
5462 * tui/tui-win.c (tui_source_window_base::refresh_all): New
5463 method.
5464 (tui_refresh_all_win): Call the refresh_all method.
5465 (tui_set_focus): Likewise.
5466 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5467 (struct tui_source_window_base, struct tui_data_window) <refresh>:
5468 Likewise.
5469
ad54d15b
TT
54702019-06-25 Tom Tromey <tom@tromey.com>
5471
5472 * tui/tui-winsource.h (tui_refill_source_window)
5473 (tui_set_is_exec_point_at): Don't declare.
5474 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5475 (tui_source_window_base::refill): Rename from
5476 tui_refill_source_window.
5477 (tui_source_window_base::do_scroll_horizontal): Update.
5478 (tui_source_window_base::set_is_exec_point_at): Rename from
5479 tui_set_is_exec_point_at.
5480 (tui_update_all_breakpoint_info): Update.
5481 * tui/tui-stack.c (tui_show_frame_info): Update.
5482 * tui/tui-layout.c (show_data): Add cast.
5483 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5484 * tui/tui-data.h (struct tui_source_window_base) <refill,
5485 set_is_exec_point_at>: New methods.
5486 (tui_source_windows, tui_add_to_source_windows): Update types.
5487 (tui_add_to_source_windows): Remove redundant declaration.
5488 * tui/tui-data.c (source_windows): Store tui_source_window_base.
5489 (tui_source_windows): Change return type.
5490 (tui_clear_source_windows_detail): Update.
5491 (tui_add_to_source_windows): Change type of parameter.
5492 (tui_free_all_source_wins_content): Update.
5493
2042b506
TT
54942019-06-25 Tom Tromey <tom@tromey.com>
5495
5496 * tui/tui-wingeneral.c (tui_win_info::refresh)
5497 (tui_source_window_base::refresh): New methods.
5498 (tui_refresh_all): Call the refresh method.
5499 * tui/tui-data.h (struct tui_win_info)
5500 (struct tui_source_window_base) <refresh>: New method.
5501
56122977
TT
55022019-06-25 Tom Tromey <tom@tromey.com>
5503
5504 * tui/tui.h (tui_is_window_visible): Return bool.
5505 * tui/tui.c (tui_is_window_visible): Return bool.
5506 * tui/tui-wingeneral.c (tui_make_window, make_visible)
5507 (tui_make_visible, tui_make_invisible)
5508 (tui_win_info::make_visible)
5509 (tui_source_window_base::make_visible, make_all_visible)
5510 (tui_make_all_visible, tui_make_all_invisible): Update.
5511 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5512 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5513 bool.
5514 (struct tui_win_info, struct tui_source_window_base)
5515 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5516 * tui/tui-data.c (tui_init_generic_part): Update.
5517
cda37efb
TT
55182019-06-25 Tom Tromey <tom@tromey.com>
5519
5520 * tui/tui-wingeneral.c (tui_win_info::make_visible)
5521 (tui_source_window_base::make_visible): New methods.
5522 (make_all_visible): Make method call.
5523 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5524 (struct tui_source_window_base, struct tui_cmd_window): Override
5525 make_visible.
5526 (tui_win_is_source_type): Don't declare.
5527 * tui/tui-data.c (tui_win_is_source_type): Remove.
5528
6a0ee02c
TT
55292019-06-25 Tom Tromey <tom@tromey.com>
5530
5531 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5532 NULL check.
5533
63901aec
TT
55342019-06-25 Tom Tromey <tom@tromey.com>
5535
5536 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5537 Inline constructor. Add initializers for members.
5538 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5539 constructors; now inline in class.
5540
ceb13a13
TT
55412019-06-25 Tom Tromey <tom@tromey.com>
5542
5543 * tui/tui-regs.c (tui_show_registers): Update.
5544 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5545 bool.
5546 * tui/tui-data.c (tui_data_window::clear_detail)
5547 (tui_data_window): Update.
5548
238eb706
TT
55492019-06-25 Tom Tromey <tom@tromey.com>
5550
5551 * tui/tui-windata.c (tui_display_all_data)
5552 (tui_display_data_from_line, tui_display_data_from)
5553 (tui_check_data_values, tui_data_window::do_scroll_vertical):
5554 Update.
5555 * tui/tui-regs.c (tui_last_regs_line_no)
5556 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5557 (tui_show_registers, tui_show_register_group)
5558 (tui_display_registers_from, tui_display_reg_element_at_line)
5559 (tui_display_registers_from_line, tui_check_register_values)
5560 (tui_reg_next, tui_reg_prev): Update.
5561 * tui/tui-layout.c (tui_set_layout, show_data): Update.
5562 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
5563 tui_data_window.
5564 (struct tui_win_info) <detail>: Remove. Add new fields from
5565 tui_data_info.
5566 (TUI_DATA_WIN): Add cast.
5567 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5568 (~tui_data_window): Simplify.
5569
81491aa0
TT
55702019-06-25 Tom Tromey <tom@tromey.com>
5571
5572 * tui/tui-layout.c (show_source_disasm_command)
5573 (show_source_or_disasm_and_command): Update.
5574 * tui/tui-io.c (update_cmdwin_start_line)
5575 (tui_redisplay_readline): Update.
5576 * tui/tui-data.h (struct tui_command_info): Remove.
5577 (struct tui_win_info) <detail>: Remove command_info member.
5578 (struct tui_data_window) <start_line>: New member, from
5579 tui_command_info.
5580 (TUI_CMD_WIN): Add casts.
5581
e6e41501
TT
55822019-06-25 Tom Tromey <tom@tromey.com>
5583
5584 * tui/tui-winsource.c (tui_update_source_window)
5585 (tui_refill_source_window)
5586 (tui_source_window_base::do_scroll_horizontal)
5587 (tui_update_breakpoint_info, tui_set_exec_info_content)
5588 (tui_show_exec_info_content, tui_erase_exec_info_content)
5589 (tui_clear_exec_info_content): Update.
5590 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5591 Update.
5592 * tui/tui-win.c (make_invisible_and_set_new_height)
5593 (make_visible_with_new_height): Update.
5594 * tui/tui-source.c (tui_set_source_content)
5595 (tui_show_symtab_source): Update.
5596 * tui/tui-layout.c (extract_display_start_addr)
5597 (show_source_disasm_command, show_data)
5598 (make_source_or_disasm_window)
5599 (show_source_or_disasm_and_command): Update.
5600 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5601 (tui_disasm_window::do_scroll_vertical): Remove shadowing
5602 "gdbarch".
5603 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
5604 to tui_source_window_base.
5605 (struct tui_win_info) <detail>: Remove source_info member.
5606 (struct tui_source_window_base) <has_locator>: Inline.
5607 Move contents from tui_source_info; rename has_locator member to
5608 m_has_locator.
5609 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5610 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5611 header file.
5612 (tui_source_window_base::clear_detail, ~tui_source_window_base):
5613 Simplify.
5614 (tui_free_all_source_wins_content): Cast to
5615 tui_source_window_base.
5616
44f0e208
TT
56172019-06-25 Tom Tromey <tom@tromey.com>
5618
5619 * tui/tui-win.c (make_invisible_and_set_new_height)
5620 (make_visible_with_new_height): Call has_locator method.
5621 * tui/tui-layout.c (show_source_disasm_command, show_data)
5622 (show_source_or_disasm_and_command): Update for bool change.
5623 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5624 (tui_win_info) <has_locator>: New method.
5625 (struct tui_source_window_base) <has_locator>: New method.
5626 (tui_win_has_locator): Don't declare.
5627 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5628 from tui_win_has_locator.
5629 (tui_source_window_base): Use false, not FALSE.
5630
7778b912
TT
56312019-06-25 Tom Tromey <tom@tromey.com>
5632
5633 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5634 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5635 clear_detail method directly.
5636 (tui_clear_win_detail): Remove.
5637
f83d391c
TT
56382019-06-25 Tom Tromey <tom@tromey.com>
5639
5640 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5641 "this", not TUI_DISASM_WIN.
5642
13446e05
TT
56432019-06-25 Tom Tromey <tom@tromey.com>
5644
5645 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
5646 declare.
5647 * tui/tui-winsource.c
5648 (tui_source_window_base::do_scroll_horizontal): Rename from
5649 tui_horizontal_source_scroll.
5650 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5651 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5652 from tui_vertical_data_scroll.
5653 * tui/tui-win.h (tui_scroll): Don't declare.
5654 * tui/tui-win.c (tui_win_info::forward_scroll)
5655 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5656 (tui_win_info::right_scroll): Rename and update.
5657 (tui_scroll_forward_command, tui_scroll_backward_command)
5658 (tui_scroll_left_command, tui_scroll_right_command): Update.
5659 (tui_scroll): Remove.
5660 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5661 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5662 from tui_vertical_source_scroll.
5663 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5664 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5665 from tui_vertical_disassem_scroll.
5666 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5667 do_scroll_horizontal>: New methods.
5668 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5669 Likewise.
5670 (struct tui_source_window_base): Add do_scroll_horizontal.
5671 (struct tui_source_window, struct tui_disasm_window): Add
5672 do_scroll_vertical.
5673 (struct tui_data_window, struct tui_cmd_window): Add
5674 do_scroll_horizontal and do_scroll_vertical.
5675 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5676
5cf82909
TT
56772019-06-25 Tom Tromey <tom@tromey.com>
5678
5679 * tui/tui-data.h (struct tui_source_window_base): New struct.
5680 (struct tui_source_window): Derive from tui_source_window_base.
5681 (struct tui_disasm_window): New struct.
5682 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5683 from tui_source_window::clear_detail.
5684 (tui_source_window_base): Rename from tui_source_window.
5685 (~tui_source_window_base): Rename from ~tui_source_window.
5686 (tui_alloc_win_info): Create a tui_disasm_window.
5687
ee1d42d6
TT
56882019-06-25 Tom Tromey <tom@tromey.com>
5689
5690 * tui/tui-data.h (struct tui_source_window)
5691 (struct tui_data_window): Declare destructors.
5692 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5693 destructors.
5694 (tui_win_info): Simplify.
5695
b4eb2452
TT
56962019-06-25 Tom Tromey <tom@tromey.com>
5697
5698 * tui/tui-winsource.c (tui_display_main)
5699 (tui_update_source_windows_with_addr)
5700 (tui_update_all_breakpoint_info): Update.
5701 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5702 (new_height_ok, parse_scrolling_args): Update.
5703 * tui/tui-stack.c (tui_show_frame_info): Update.
5704 * tui/tui-data.h (struct tui_list): Remove.
5705 (tui_source_windows): Return a reference to a std::vector.
5706 * tui/tui-data.c (source_windows): Now a std::vector.
5707 (tui_source_windows): Change return type.
5708 (tui_clear_source_windows): Rewrite.
5709 (tui_clear_source_windows_detail, tui_add_to_source_windows)
5710 (tui_free_all_source_wins_content): Rewrite.
5711
8761a91b
TT
57122019-06-25 Tom Tromey <tom@tromey.com>
5713
5714 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5715 (struct tui_data_window, struct tui_cmd_window): Declare
5716 clear_detail method.
5717 * tui/tui-data.c (tui_source_window::clear_detail)
5718 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5719 methods.
5720 (tui_clear_win_detail): Simplify.
5721
0ed69eda
TT
57222019-06-25 Tom Tromey <tom@tromey.com>
5723
5724 * tui/tui-layout.c (make_source_window, make_disasm_window)
5725 (make_source_or_disasm_window): Remove win_info_ptr parameter.
5726 Return the new window.
5727 (show_source_disasm_command, show_data)
5728 (show_source_or_disasm_and_command): Update.
5729
82432e10
TT
57302019-06-25 Tom Tromey <tom@tromey.com>
5731
5732 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5733 parameter. Return the new window.
5734 (show_source_disasm_command): Update and remove NULL check.
5735 (show_source_or_disasm_and_command): Update.
5736
ec328aa5
TT
57372019-06-25 Tom Tromey <tom@tromey.com>
5738
5739 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5740
33b906ab
TT
57412019-06-25 Tom Tromey <tom@tromey.com>
5742
5743 * tui/tui-data.h (struct tui_win_info): Make constructor
5744 protected. Make destructor virtual. Add initializers.
5745 (tui_source_window, tui_data_window, tui_cmd_window): New
5746 classes.
5747 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
5748 constructor. Add "type" parameter.
5749 (tui_source_window, tui_data_window, tui_cmd_window): New
5750 constructors.
5751 (tui_alloc_win_info): Instantiate the appropriate subclass.
5752
e7e11af4
TT
57532019-06-25 Tom Tromey <tom@tromey.com>
5754
5755 * tui/tui-win.c (tui_resize_all): Use delete.
5756 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5757 destructor.
5758 (tui_free_window): Don't declare.
5759 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5760 Update.
5761
6792b55e
TT
57622019-06-25 Tom Tromey <tom@tromey.com>
5763
5764 * tui/tui-data.h (struct tui_win_info): Add constructor.
5765 * tui/tui-data.c (tui_alloc_win_info): Use new.
5766 (tui_free_window): Use delete.
5767
f95675e1
TT
57682019-06-22 Tom Tromey <tom@tromey.com>
5769
5770 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5771 declare.
5772 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5773
5bff081c
TT
57742019-06-22 Tom Tromey <tom@tromey.com>
5775
5776 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5777 declare.
5778 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5779
47e3f474
TV
57802019-06-22 Tom de Vries <tdevries@suse.de>
5781
5782 * dwarf2read.c (create_addrmap_from_aranges)
5783 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5784 instead of '%zu'.
5785
fd5866f6
SM
57862019-06-21 Simon Marchi <simon.marchi@efficios.com>
5787
5788 * dwarf2read.h (dwarf2_section_info_def): Remove.
5789 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5790 * dwarf2read.c (struct dwo_sections) <types>: Change type to
5791 std::vector<dwarf2_section_info>.
5792 (struct dwo_file) <~dwo_file>: Remove.
5793 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5794 types field.
5795 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5796 (dwarf2_read_debug_names): Likewise.
5797 (create_debug_types_hash_table): Change parameter type to
5798 array_view, adjust code accordingly.
5799 (dwarf2_locate_dwo_sections): Adjust to std::vector.
5800 (partial_die_info::fixup): Likewise.
5801 (determine_prefix): Likewise.
5802 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5803
fb1eb2f9
SM
58042019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5805
5806 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5807 gdb_bfd_ref_ptr.
5808 <~dwo_file>: Remove call to gdb_bfd_unref.
5809 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5810 gdb_bfd_ref_ptr::get.
5811
51ac9db5
SM
58122019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5813
5814 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5815 type to htab_up.
5816 * dwarf2read.c (struct dwo_file): Initialize fields.
5817 <~dwo_file>: New.
5818 (free_dwo_file): Remove, move content to ~dwo_file.
5819 (struct dwo_file_deleter): Remove.
5820 (dwo_file_up>: Remove custom deleter.
5821 (free_dwo_files): Remove.
5822 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5823 dwo_files.
5824 (process_skeletonless_type_units): Call unique_ptr::get.
5825 (allocate_dwo_file_hash_table): Add deleter to created hash
5826 table. Change return type to htab_up.
5827 (lookup_dwo_file_slot): Don't memset dwo_file, call
5828 unique_ptr::get.
5829 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5830 (create_dwo_unit_in_dwp_v2): Likewise.
5831 (open_and_init_dwo_file): Likewise.
5832 (free_dwo_file_from_slot): Remove.
5833
dc4ccb6f
SM
58342019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5835
5836 * dwarf2read.h (struct dwarf2_section_info) <readin,
5837 is_virtual>: Change type to bool.
5838 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5839 true instead of 1.
5840
e6a1c5cb
TT
58412019-06-19 Tom Tromey <tom@tromey.com>
5842
5843 * tui/tui-data.h (tui_init_content_element): Don't declare.
5844
6f6ffbeb
TT
58452019-06-19 Tom Tromey <tom@tromey.com>
5846
5847 * tui/tui-data.h (tui_init_win_info): Don't declare.
5848
f23f598e
TV
58492019-06-19 Tom de Vries <tdevries@suse.de>
5850
5851 * dwarf2read.h (abstract_to_concrete): Change type to
5852 std::unordered_map<sect_offset, std::vector<sect_offset>,
5853 gdb::hash_enum<sect_offset>>.
5854
680e1bee
TT
58552019-06-19 Tom Tromey <tromey@adacore.com>
5856
5857 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5858 EVAL_AVOID_SIDE_EFFECTS specially.
5859
dcf37923
TT
58602019-06-19 Tom Tromey <tromey@adacore.com>
5861
5862 * source-cache.c (highlighter): New global.
5863 (source_cache::get_source_lines): Create a highlighter on demand.
5864
494986d5
AB
58652019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
5866
5867 * defs.h (deprecated_interactive_hook): Delete declaration.
5868 * interps.c (clear_interpreter_hooks): Remove use of
5869 deprecated_interactive_hook.
5870 * top.c (deprecated_interactive_hook): Delete definition.
5871 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5872
3360b6e7
TV
58732019-06-18 Tom de Vries <tdevries@suse.de>
5874
5875 PR gdb/24515
5876 * dwarf2read.h (abstract_to_concrete): Change type from
5877 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5878 std::unordered_map<sect_offset, std::vector<sect_offset>>.
5879 * dwarf2read.c (read_variable): Update.
5880 (dwarf2_fetch_die_loc_sect_off): Update.
5881
310b3441
TV
58822019-06-17 Tom de Vries <tdevries@suse.de>
5883
5884 PR gdb/24617
5885 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5886 accessing parent[parent_len - 1].
5887
ba9777be
PP
58882019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
5889
5890 PR gdb/24364
5891 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5892 call dtrace_process_dof with NULL dof.
5893
2b9f6e89
TV
58942019-06-16 Tom de Vries <tdevries@suse.de>
5895
5896 PR gdb/24445
5897 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5898
431b3ead
TT
58992019-06-16 Tom Tromey <tom@tromey.com>
5900
5901 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5902 (make_all_visible): Use address of member.
5903
d04b44a1
TT
59042019-06-16 Tom Tromey <tom@tromey.com>
5905
5906 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5907 (tui_free_window, free_content, free_content_elements): Remove
5908 unnecessary cast.
5909 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5910 cast.
5911 * tui/tui-regs.c (tui_show_register_group)
5912 (tui_display_registers_from, tui_display_reg_element_at_line):
5913 Remove unnecessary cast.
5914
bf5142e7
AB
59152019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
5916
5917 * linux-nat.c (normal_mask): Delete.
5918 (_initialize_linux_nat): Don't initialise normal_mask.
5919
c4973306
SM
59202019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
5921
5922 PR gdb/24445
5923 * dwarf-index-write.h (write_psymtabs_to_index): Add
5924 dwz_basename parameter.
5925 * dwarf-index-write.c (write_gdbindex): Move file writing to
5926 write_gdbindex_1. Change return type void.
5927 (assert_file_size): Move up, remove filename parameter.
5928 (write_gdbindex_1): New function.
5929 (write_debug_names): Change return type to void, call
5930 assert_file_size.
5931 (struct index_wip_file): New struct.
5932 (write_psymtabs_to_index): Add dwz_basename parameter. Move
5933 file logic to index_wip_file. Write index for dwz file if
5934 needed.
5935 (save_gdb_index_command): Pass basename of dwz file, if present.
5936 * dwarf-index-cache.c (index_cache::store): Obtain and pass
5937 build-id of dwz file, if present.
5938 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5939 (dwarf2_get_dwz_file): Likewise.
5940 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5941 (dwarf2_get_dwz_file): Likewise.
5942
395f9c91
TT
59432019-06-16 Tom Tromey <tom@tromey.com>
5944
5945 * coffread.c (process_coff_symbol): Use xstrdup.
5946 * value.c (create_internalvar): Use xstrdup.
5947
cafb3438
TT
59482019-06-16 Tom Tromey <tom@tromey.com>
5949
5950 * valops.c (value_cast, value_slice): Remove unnecessary cast.
5951 * breakpoint.c (stopin_command, stopat_command)
5952 (until_break_command, decode_location_default): Remove unnecessary
5953 cast.
5954 * utils.c (subset_compare): Remove unnecessary cast.
5955 * ada-lang.c (ada_update_initial_language): Remove unnecessary
5956 cast.
5957 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5958 cast.
5959 * infcmd.c (path_command): Remove unnecessary cast.
5960 * coffread.c (decode_type): Remove unnecessary cast.
5961 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5962 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5963 * tui/tui-stack.c (tui_show_locator_content)
5964 (tui_show_frame_info): Remove unnecessary cast.
5965 * tui/tui-win.c (tui_scroll_forward_command)
5966 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5967 (parse_scrolling_args): Remove unnecessary cast.
5968 * tui/tui-data.c (init_win_info, tui_del_window)
5969 (tui_free_window, tui_del_data_windows, tui_free_data_content)
5970 (free_content_elements): Remove unnecessary cast.
5971 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5972 unnecessary cast.
5973 * tui/tui-source.c (tui_set_source_content)
5974 (tui_vertical_source_scroll): Remove unnecessary cast.
5975 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5976 cast.
5977 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5978 * tui/tui-regs.c (tui_display_registers_from)
5979 (tui_display_register): Remove unnecessary cast.
5980 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5981 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5982 (make_visible): Remove unnecessary cast.
5983 * tui/tui-winsource.c (tui_erase_source_content)
5984 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5985 unnecessary cast.
5986 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5987 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5988 * stabsread.c (read_type, read_array_type, read_range_type):
5989 Remove unnecessary cast.
5990 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5991 (parse_symbol, parse_type, upgrade_type, parse_external)
5992 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5993 unnecessary cast.
5994 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5995
730ead81
TT
59962019-06-16 Tom Tromey <tom@tromey.com>
5997
5998 * tui/tui-data.c (tui_alloc_generic_win_info)
5999 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6000 checks.
6001
584a927c
AB
60022019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
6003 Andrew Burgess <andrew.burgess@embecosm.com>
6004
6005 * f-typeprint.c (f_print_type): Don't return early for not
6006 associated or not allocated types.
6007 (f_type_print_varspec_suffix): Add print_rank parameter and print
6008 ranks of array types in case they dangling.
6009 (f_type_print_base): Add print_rank parameter.
6010
30056ea0
AB
60112019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6012
6013 * NEWS: Mention new MI commands.
6014 * break-catch-throw.c (enum exception_event_kind): Move to
6015 breakpoint.h.
6016 (print_mention_exception_catchpoint): Output text as a single
6017 message.
6018 (catch_exception_command_1): Rename to...
6019 (catch_exception_event): ...this, make non-static, update header
6020 command, and change some parameter types.
6021 (catch_catch_command): Update for changes to
6022 catch_exception_command_1.
6023 (catch_throw_command): Likewise.
6024 (catch_rethrow_command): Likewise.
6025 * breakpoint.c (enum exception_event_kind): Delete.
6026 * breakpoint.h (enum exception_event_kind): Moved here from
6027 break-catch-throw.c.
6028 (catch_exception_event): Declare.
6029 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6030 (mi_cmd_catch_throw): New function.
6031 (mi_cmd_catch_rethrow): New function.
6032 (mi_cmd_catch_catch): New function.
6033 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6034 'catch-catch' entries.
6035 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6036 (mi_cmd_catch_rethrow): Declare.
6037 (mi_cmd_catch_catch): Declare.
6038
ec8e2b6d
AB
60392019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6040
6041 * annotate.c (annotate_source_line): Change return type to void,
6042 update implementation to match.
6043 * annotate.h (annotate_source_line): Change return type to void,
6044 update header comment.
6045 * stack.c (print_frame_info): Don't change what frame information
6046 is printed based on whether annotations are on or not.
6047
0d3abd8c
AB
60482019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6049
6050 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6051 (annotate_source): Make static.
6052 (annotate_source_line): Moved from source.c and renamed from
6053 identify_source_line. Update the return type.
6054 * annotate.h (annotate_source): Delete declaration.
6055 (annotate_source_line): Declaration moved from source.h, and
6056 renamed from identify_source_line. Return type updated.
6057 * source.c (identify_source_line): Moved to annotate.c and renamed
6058 to annotate_source_line.
6059 (info_line_command): Remove check of annotation_level.
6060 * source.h (identify_source_line): Move declaration to annotate.h
6061 and rename to annotate_source_line.
6062 * stack.c: Add 'annotate.h' include.
6063 (print_frame_info): Remove check of annotation_level before
6064 calling annotate_source_line.
6065
00df30ae
AB
60662019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6067
6068 * source-cache.c (source_cache::get_plain_source_lines): Use
6069 open_source_file_with_line_charpos instead of just
6070 open_source_file, remove call to find_source_lines.
6071 (source_cache::get_source_lines): Likewise.
6072 * source.c (find_source_lines): Make static.
6073 (get_filename_and_charpos): Renamed into...
6074 (open_source_file_with_line_charpos): ..this along with changes to
6075 return a scoped_fd, and some other minor clean ups.
6076 (identify_source_line): Use open_source_file_with_line_charpos.
6077 (search_command_helper): Use open_source_file_with_line_charpos
6078 instead of just open_source_file, remove call to
6079 find_source_lines.
6080 * source.h (open_source_file_with_line_charpos): Declare new
6081 function.
6082 (find_source_lines): Delete declaration.
6083
afda45a2
AB
60842019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6085
6086 * source.c (get_filename_and_charpos): Remove fullname
6087 parameter.
6088 (identify_source_line): Update call to get_filename_and_charpos.
6089
0735b091
TT
60902019-06-14 Tom Tromey <tromey@adacore.com>
6091
6092 PR gdb/24502:
6093 * ui-style.h (skip_ansi_escape): Update comment.
6094 * ui-file.h (class no_terminal_escape_file): New class.
6095 * ui-file.c (no_terminal_escape_file::write)
6096 (no_terminal_escape_file::puts): New methods.
6097 * cli/cli-logging.c (handle_redirections): Use
6098 no_terminal_escape_file.
6099
52ce35e2
TT
61002019-06-14 Tom Tromey <tromey@adacore.com>
6101
6102 * NEWS: Move convenience variable news above Python news.
6103
73cc7272
TT
61042019-06-14 Tom Tromey <tom@tromey.com>
6105
6106 * gnulib: Move directory to top-level.
6107 * configure.ac: Don't configure gnulib.
6108 * configure: Rebuild.
6109 * common/common-defs.h: Use new path to gnulib.
6110 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6111 (GNULIB_H): Remove.
6112 (INCGNU): Look in new gnulib location.
6113 (HFILES_NO_SRCDIR): Remove gnulib files.
6114 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6115 (generated_files): Remove GNULIB_H.
6116 ($(LIBGNU), all-lib): Remove targets.
6117 (distclean): Don't mention GNULIB_BUILDDIR.
6118 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6119
f5686554
TT
61202019-06-14 Tom Tromey <tromey@adacore.com>
6121
6122 * symfile.c (add_symbol_file_command): Remove obsolete comment.
6123 Warn if symbol file does not provide any symbols.
6124
a0c1ffed
TT
61252019-06-14 Tom Tromey <tromey@adacore.com>
6126
6127 * source.c (find_and_open_source): Respect basenames_may_differ.
6128
7c39e397
AB
61292019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
6130
6131 * annotate.c (annotate_breakpoints_invalid): Make use of
6132 scoped_restore_terminal_state.
6133 (annotate_frames_invalid): Likewise.
6134
f411722c
TT
61352019-06-14 Tom Tromey <tromey@adacore.com>
6136
6137 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6138 allow assignment to an internalvar.
6139
4268ec18
TT
61402019-06-14 Tom Tromey <tromey@adacore.com>
6141
6142 * ada-lex.l: Allow "_" in attribute names.
6143
abdb711e
TT
61442019-06-14 Tom Tromey <tromey@adacore.com>
6145
6146 PR gdb/24653:
6147 * regcache.c (registers_changed): Don't call alloca.
6148 * top.c (execute_command): Don't call alloca.
6149
4c048731
PA
61502019-06-13 Pedro Alves <palves@redhat.com>
6151
6152 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6153 'expression'. When parsing an expression, error out if there's
6154 junk after "unlimited".
6155 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6156 (do_set_command): Adjust calls to is_unlimited_literal.
6157
66eb1ed3
PA
61582019-06-13 Pedro Alves <palves@redhat.com>
6159
6160 * compile/compile.c (make_compile_options_def_group): Add braces
6161 around array_view initializer.
6162 * thread.c (make_thread_apply_all_options_def_group)
6163 (make_thread_apply_all_options_def_group): Likewise.
6164
3345721a
PA
61652019-06-13 Pedro Alves <palves@redhat.com>
6166
6167 * NEWS (New commands): Mention "maint test-options
6168 require-delimiter", "maint test-options unknown-is-error", "maint
6169 test-options unknown-is-operand" and "maint show
6170 test-options-completion-result".
6171 (New command options, command completion): New section.
6172 (Completion improvements): New section.
6173 Mention that you can abbreviate "unlimited".
6174
6206060d
PA
61752019-06-13 Pedro Alves <palves@redhat.com>
6176
6177 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6178 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6179 * unittests/cli-utils-selftests.c (test_parse_flags)
6180 (test_parse_flags_qcs): Delete.
6181 (test_cli_utils): Don't call deleted functions.
6182
6665660a
PA
61832019-06-13 Pedro Alves <palves@redhat.com>
6184
6185 * thread.c: Include "cli/cli-option.h".
6186 (tp_array_compar_ascending): Global.
6187 (tp_array_compar): Delete function.
6188 (tp_array_compar_ascending, tp_array_compar_descending): New
6189 functions.
6190 (ascending_option_def, qcs_flag_option_def)
6191 (thr_qcs_flags_option_defs)
6192 (make_thread_apply_all_options_def_group)
6193 (make_thread_apply_options_def_group): New.
6194 (thread_apply_all_command): Use gdb::option::process_options.
6195 (thread_apply_command_completer)
6196 (thread_apply_all_command_completer): New.
6197 (thread_apply_command): Use gdb::option::process_options.
6198 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6199 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
6200 to generate help text of "thread apply". Adjust "taas"'s help.
6201 * tid-parse.c (tid_range_parser::in_thread_range): New method.
6202 * tid-parse.h (tid_range_parser::in_thread_range): New method.
6203
f7e13587
PA
62042019-06-13 Pedro Alves <palves@redhat.com>
6205
6206 * thread.c (thread_apply_command): Check for invalid TID with
6207 isdigit instead of !isalpha.
6208
5d707134
PA
62092019-06-13 Pedro Alves <palves@redhat.com>
6210
6211 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6212 (validate_flags_qcs): New.
6213 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6214 (validate_flags_qcs): Declare.
6215 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6216 (make_frame_apply_options_def_group): New.
6217 (frame_apply_command_count): Process options with
6218 gdb::option::process_options.
6219 (frame_apply_completer): New.
6220 (frame_apply_level_completer, frame_apply_all_completer)
6221 (frame_apply_completer): New.
6222 (_initialize_stack): Update help of "frame apply", "frame apply
6223 level", "frame apply all" and "faas" to mention supported options
6224 and install command completers.
6225 * stack.h (frame_apply_all_completer): Declare.
6226 * thread.c: Include "stack.h".
6227 (tfaas_command): Add "--".
6228 (_initialize_thread): Update help "tfaas" to mention supported
6229 options and install command completer.
6230
272d4594
PA
62312019-06-13 Pedro Alves <palves@redhat.com>
6232
6233 * completer.c (complete_nested_command_line): New.
6234 (gdb_completion_word_break_characters_throw): Add assertion.
6235 * completer.h (complete_nested_command_line): Declare.
6236
90a1ef87
PA
62372019-06-13 Pedro Alves <palves@redhat.com>
6238
6239 * stack.c (parse_backtrace_qualifiers): New.
6240 (backtrace_command): Use it.
6241 (backtrace_command_completer): Complete on qualifiers.
6242
d4c16835
PA
62432019-06-13 Pedro Alves <palves@redhat.com>
6244
6245 * frame.c: Include "cli/cli-option.h.
6246 (user_set_backtrace_options): New.
6247 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6248 Delete.
6249 (get_prev_frame): Adjust.
6250 (boolean_option_def, uinteger_option_def)
6251 (set_backtrace_option_defs): New.
6252 (_initialize_frame): Adjust and use
6253 gdb::option::add_setshow_cmds_for_options to install "set
6254 backtrace past-main" and "set backtrace past-entry".
6255 * frame.h: Include "cli/cli-option.h".
6256 (struct frame_print_options): Forward declare.
6257 (print_frame_arguments_all, print_frame_arguments_scalars)
6258 (print_frame_arguments_none): Declare.
6259 (print_entry_values): Delete declaration.
6260 (struct frame_print_options, user_frame_print_options): New.
6261 (struct set_backtrace_options): New.
6262 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6263 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6264 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6265 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6266 (list_args_or_locals): Add frame_print_options parameter.
6267 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6268 * python/py-framefilter.c (enumerate_args): Pass down
6269 USER_FRAME_PRINT_OPTIONS.
6270 * stack.c: Include "cli/cli-option.h".
6271 (print_frame_arguments_all, print_frame_arguments_scalars)
6272 (print_frame_arguments_none): Declare.
6273 (print_raw_frame_arguments, print_entry_values): Delete.
6274 (user_frame_print_options): New.
6275 (boolean_option_def, enum_option_def, frame_print_option_defs):
6276 New.
6277 (struct backtrace_cmd_options): New.
6278 (bt_flag_option_def): New.
6279 (backtrace_command_option_defs): New.
6280 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6281 (print_frame_arg, read_frame_arg, print_frame_args)
6282 (print_frame_info, print_frame): Add frame_print_options parameter
6283 and use it.
6284 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6285 (backtrace_command_1): Add frame_print_options and
6286 backtrace_cmd_options parameters and use them.
6287 (make_backtrace_options_def_group): New.
6288 (backtrace_command): Process command options with
6289 gdb::option::process_options.
6290 (backtrace_command_completer): New.
6291 (_initialize_stack): Extend "backtrace"'s help to mention
6292 supported options. Install completer for "backtrace".
6293 Install some settings commands with add_setshow_cmds_for_options.
6294
2daf894e
PA
62952019-06-13 Pedro Alves <palves@redhat.com>
6296
6297 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6298 and that "set/show print raw frame-arguments" are now deprecated.
6299
6300 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6301 command.
6302 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6303 * stack.c (_initialize_stack): Install "set/show print
6304 raw-frame-arguments", and deprecate "set/show print raw
6305 frame-arguments".
6306 * valprint.c (_initialize_valprint): Deprecate "set/show print
6307 raw".
6308
e6ed716c
PA
63092019-06-13 Pedro Alves <palves@redhat.com>
6310
6311 * compile/compile.c (struct compile_options): New.
6312 (compile_flag_option_def, compile_command_option_defs)
6313 (make_compile_options_def_group): New.
6314 (compile_file_command): Handle options with
6315 gdb::option::process_options.
6316 (compile_file_command_completer): New function.
6317 (compile_code_command): Handle options with
6318 gdb::option::process_options.
6319 (compile_code_command_completer): New function.
6320 (_initialize_compiler): Install completers for "compile code" and
6321 "compile file". Mention available options in "compile code" and
6322 "compile code"'s help.
6323 * completer.c (advance_to_completion_word): New, factored out from
6324 ...
6325 (advance_to_expression_complete_word_point): ... this.
6326 (advance_to_filename_complete_word_point): New.
6327 * completer.h (advance_to_filename_complete_word_point): New
6328 declaration.
6329
7d8062de
PA
63302019-06-13 Pedro Alves <palves@redhat.com>
6331
6332 * compile/compile.c: Include "cli/cli-option.h".
6333 (compile_print_value): Scope data pointer is now a
6334 value_print_options pointer; adjust.
6335 (compile_print_command): Process options. Scope data pointer is
6336 now a value_print_options pointer; adjust.
6337 (_initialize_compile): Update "compile print"'s help to include
6338 supported options. Install a completer for "compile print".
6339 * cp-valprint.c (show_vtblprint, show_objectprint)
6340 (show_static_field_print): Delete.
6341 (_initialize_cp_valprint): Don't install "set print
6342 static-members", "set print vtbl", "set print object" here.
6343 * printcmd.c: Include "cli/cli-option.h" and
6344 "common/gdb_optional.h".
6345 (print_command_parse_format): Rework to fill in a
6346 value_print_options instead of a format_data.
6347 (print_value): Change parameter type from format_data pointer to
6348 value_print_options reference. Adjust.
6349 (print_command_1): Process options. Adjust to pass down a
6350 value_print_options.
6351 (print_command_completer): New.
6352 (_initialize_printcmd): Install print_command_completer as
6353 handle_brkchars completer for the "print" command. Update
6354 "print"'s help to include supported options.
6355 * valprint.c: Include "cli/cli-option.h".
6356 (show_vtblprint, show_objectprint, show_static_field_print): Moved
6357 here from cp-valprint.c.
6358 (boolean_option_def, uinteger_option_def)
6359 (value_print_option_defs, make_value_print_options_def_group):
6360 New. Use gdb::option::add_setshow_cmds_for_options to install
6361 "set print elements", "set print null-stop", "set print repeats",
6362 "set print pretty", "set print union", "set print array", "set
6363 print address", "set print symbol", "set print array-indexes".
6364 * valprint.h: Include <string> and "cli/cli-option.h".
6365 (make_value_print_options_def_group): Declare.
6366 (print_value): Change parameter type from format_data pointer to
6367 value_print_options reference.
6368 (print_command_completer): Declare.
6369
9d0faba9
PA
63702019-06-13 Pedro Alves <palves@redhat.com>
6371
6372 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6373 (COMMON_SFILES): Add maint-test-settings.c.
6374 * cli/cli-decode.c (boolean_enums): New global, factored out from
6375 ...
6376 (add_setshow_boolean_cmd): ... here.
6377 * cli/cli-decode.h (boolean_enums): Declare.
6378 * cli/cli-option.c: New file.
6379 * cli/cli-option.h: New file.
6380 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6381 factored out from ...
6382 (parse_cli_boolean_value(const char *)): ... this.
6383 (is_unlimited_literal): Change parameter type to pointer to
6384 pointer. Adjust and advance ARG pointer.
6385 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6386 (parse_cli_var_enum): New, factored out from ...
6387 (do_set_command): ... this. Adjust.
6388 * cli/cli-setshow.h (parse_cli_boolean_value)
6389 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6390 (parse_cli_var_enum): Declare.
6391 * cli/cli-utils.c: Include "cli/cli-option.h".
6392 (get_ulongest): New.
6393 * cli/cli-utils.h (get_ulongest): Declare.
6394 (check_for_argument): New overloads.
6395 * maint-test-options.c: New file.
6396
2c722807
PA
63972019-06-13 Pedro Alves <palves@redhat.com>
6398
6399 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6400 parse a range if "-" is at the end of the string.
6401
dee7b4c8
PA
64022019-06-13 Pedro Alves <palves@redhat.com>
6403
6404 * cli/cli-setshow.c (parse_auto_binary_operation)
6405 (parse_cli_boolean_value): Don't allow "o".
6406
dca0f6c0
PA
64072019-06-13 Pedro Alves <palves@redhat.com>
6408
6409 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6410 * NEWS: Mention maint test-settings KIND.
6411 * maint-test-settings.c: New file.
6412
597bf39d
PA
64132019-06-13 Pedro Alves <palves@redhat.com>
6414
6415 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6416 completer.
6417 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6418 "set" completers.
6419
48c410fb
PA
64202019-06-13 Pedro Alves <palves@redhat.com>
6421
6422 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6423 after item.
6424
93bcb043
PA
64252019-06-13 Pedro Alves <palves@redhat.com>
6426
6427 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6428
cbba3ecd
PA
64292019-06-13 Pedro Alves <palves@redhat.com>
6430
6431 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6432 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6433 call.
6434 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6435 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6436 calls.
6437 (check_for_argument): Skip spaces after argument.
6438
b9a3f842
PA
64392019-06-13 Pedro Alves <palves@redhat.com>
6440
6441 * thread.c (thread_apply_command): Adjust TID parsing.
6442 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6443 detected before end of string.
6444 (tid_is_in_list): Error out if LIST is invalid.
6445
3844e605
PA
64462019-06-13 Pedro Alves <palves@redhat.com>
6447
6448 * completer.c (complete_line_internal_1): Rewind completion word
6449 point.
6450 (completion_tracker::advance_custom_word_point_by): Change
6451 parameter type to int.
6452 * completer.h (completion_tracker::advance_custom_word_point_by):
6453 Likewise.
6454
00b56dbe
PA
64552019-06-13 Pedro Alves <palves@redhat.com>
6456
6457 * completer.c (advance_to_completion_word): Handle delimiters.
6458
d106773e
PA
64592019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
6460
6461 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6462
08f10e02
TT
64632019-06-11 Tom Tromey <tom@tromey.com>
6464
6465 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6466 (xmalloc_failed): Move to alloc.c.
6467 * alloc.c: New file.
6468 * Makefile.in (COMMON_SFILES): Add alloc.c.
6469
1c7fe951
TT
64702019-06-11 Tom Tromey <tom@tromey.com>
6471
6472 * nat/linux-waitpid.c: Don't include server.h.
6473 (linux_debug): Remove.
6474 (my_waitpid): Update.
6475
89549d7f
TT
64762019-06-11 Tom Tromey <tromey@adacore.com>
6477
6478 * infcall.c (_initialize_infcall): Remove trailing newline from
6479 help.
6480 * user-regs.c (_initialize_user_regs): Remove trailing newline
6481 from help.
6482 * typeprint.c (_initialize_typeprint): Remove trailing newline
6483 from help.
6484 * reverse.c (_initialize_reverse): Remove trailing newlines from
6485 help.
6486 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6487 from help.
6488 * language.c (add_set_language_command): Remove trailing newline
6489 from help.
6490 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6491 help.
6492 * disasm.c (_initialize_disasm): Remove trailing newline from
6493 help.
6494 * top.c (init_main): Remove trailing newline from help.
6495 * interps.c (_initialize_interpreter): Remove trailing newline
6496 from help.
6497 * btrace.c (_initialize_btrace): Remove trailing newlines from
6498 help.
6499 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6500 from help.
6501 * python/python.c (_initialize_python): Remove trailing newline
6502 from help.
6503 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6504 help.
6505 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6506 from help. Reformat some text.
6507 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6508 from help.
6509 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6510 newline from help.
6511
86108c13
TT
65122019-06-11 Tom Tromey <tromey@adacore.com>
6513
6514 * darwin-nat.c (darwin_decode_exception_message)
6515 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6516
a7067863
AB
65172019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
6518
6519 * valops.c (value_slice): Check for not allocated or not
6520 associated values.
6521
9ab08412
TV
65222019-06-10 Tom de Vries <tdevries@suse.de>
6523
6524 PR gdb/24618
6525 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6526 sure an empty slot (defined by a 32-bit zero pair) is recognized as
6527 invalid.
6528
f19e22e9
TV
65292019-06-10 Tom de Vries <tdevries@suse.de>
6530
6531 PR gdb/24611
6532 * linespec.c (linespec_lexer_lex_string): Remove incorrect
6533 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
6534
e99f9db0
TV
65352019-06-10 Tom de Vries <tdevries@suse.de>
6536
6537 PR symtab/24545
6538 * symtab.c (struct demangled_name_entry): Add language field.
6539 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
6540 static minimal symbol". Set and use language field.
6541
9bf7038b
TT
65422019-06-10 Tom Tromey <tromey@adacore.com>
6543
6544 * ada-lang.c (_initialize_ada_language): Update help text.
6545
422186a9
TT
65462019-06-10 Tom Tromey <tromey@adacore.com>
6547
6548 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6549 with a newline.
6550 * guile/guile.c (handle_boot_error): Don't end warning with a
6551 newline.
6552 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6553 warning with a newline.
6554 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6555 newline.
6556 (s12z_frame_cache): Likewise.
6557 * dwarf-index-cache.c (index_cache::store): Don't end warning with
6558 a newline.
6559 * solib-svr4.c (disable_probes_interface): Don't end warning with
6560 a newline.
6561 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6562 newline.
6563 * python/python.c (do_finish_initialization): Don't end warning
6564 with a newline.
6565
25ce02ee
TT
65662019-06-10 Tom Tromey <tom@tromey.com>
6567
6568 * python/py-breakpoint.c (gdbpy_breakpoint_created)
6569 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6570 gdbpy_enter.
6571
caa429d8
TT
65722019-06-10 Tom Tromey <tromey@adacore.com>
6573
6574 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6575 data.
6576 (elf_new_init): Don't call stabsread_new_init.
6577 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6578 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
6579 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6580
81873cc8
TV
65812019-06-10 Tom de Vries <tdevries@suse.de>
6582
6583 PR symtab/16264
6584 PR symtab/24517
6585 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6586
4fa0265e
РИ
65872019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
6588
6589 * source.c (find_and_open_source): Also rewrite relative file
6590 names.
6591
1a3da2cd
AB
65922019-04-26 Amos Bird <amosbird@gmail.com>
6593
6594 * annotate.c (annotate_thread_exited): Add "thread-exited"
6595 annotation.
6596
3847a7bf
TT
65972019-06-06 Tom Tromey <tromey@adacore.com>
6598
6599 * maint.h (class scoped_command_stats): Use
6600 DISABLE_COPY_AND_ASSIGN.
6601 <print_time>: New method.
6602 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6603 print_time.
6604 (scoped_command_stats::print_time): New method.
6605
312617a3
AB
66062019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
6607
6608 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6609 instructions of lengths 6 or 8 bytes.
6610
b02f78f9
PA
66112019-06-04 Pedro Alves <palves@redhat.com>
6612
6613 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6614
6615 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6616 * breakpoint.c (condition_completer): Likewise.
6617 * cli/cli-dump.c (scan_expression): Likewise.
6618 * common/filestuff.c (mkdir_recursive): Likewise.
6619 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6620 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6621 (gdb_abspath): Likewise.
6622 * compile/compile-cplus-types.c
6623 (compile_cplus_instance::decl_name): Likewise.
6624 * completer.c (complete_explicit_location):
6625 (signal_completer, reg_or_group_completer_1): Likewise.
6626 * cp-support.c (cp_remove_params_if_any): Likewise.
6627 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6628 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6629 * infcmd.c (strip_bg_char): Likewise.
6630 * linespec.c (copy_token_string): Likewise.
6631 * mi/mi-main.c (output_cores): Likewise.
6632 * psymtab.c (psymtab_search_name):
6633 * symfile.c (test_set_ext_lang_command): Likewise.
6634 * target.c (target_fileio_read_stralloc): Likewise.
6635 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6636 * value.c (complete_internalvar): Likewise.
6637
e1f2e1a2
CB
66382019-06-04 Christian Biesinger <cbiesinger@google.com>
6639
6640 Add objfile property to gdb.Type.
d3238f7d
PA
6641 * NEWS: Mention Python API addition.
6642 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 6643
e664d728
PW
66442019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6645
6646 * NEWS: Mention the new set|show style [title|highlight].
6647 Mention changes to "show style", "help" and "apropos".
6648
66d8c862
PW
66492019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6650
6651 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6652 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
6653 instead of print_help_for_command.
6654 (print_doc_of_command): New function.
6655 (help_list): Add 'apropos -v word' suggestion.
6656 (print_help_for_command): Style the command name using title style.
6657 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6658 (_initialize_cli_cmds): Describe -v in apropos_command help.
6659
9303eb2f
PW
66602019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6661
6662 * cli/cli-style.h (cli_style_option): Add name in constructor,
6663 add m_name class member, add constructor with intensity,
6664 add name class function.
6665 (cli_style_option::add_setshow_commands): Remove name argument.
6666 (highlight_style, title_style): New styles.
6667 * cli/cli-style.c (do_show): New function that shows a style
6668 characteristic styling the style name with itself.
6669 (set_style_name): New function.
6670 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6671 Update all callers according to the changes in cli/cli-style.h.
6672 * utils.h (fputs_highlighted): New function.
6673 * utils.c (fputs_highlighted): Likewise.
6674
e2c52041
PW
66752019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6676
6677 * NEWS: Mention new pipe command and new convenience variables.
6678
947d3946
PW
66792019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6680
6681 * cli/cli-cmds.c (pipe_command): New function.
6682 (_initialize_cli_cmds): Call add_com for pipe_command.
6683 Define | as an alias for pipe.
6684 (exit_status_set_internal_vars): New function.
6685 (shell_escape): Call exit_status_set_internal_vars.
6686 cli/cli-decode.c (find_command_name_length): Recognize | as
6687 a single character command.
6688
b8fd0918
PW
66892019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6690
6691 * gdbcmd.h (execute_command_to_ui_file): New declaration.
6692 top.c (execute_command_to_ui_file): New function, mostly a copy
6693 of execute_command_to_string.
6694 (execute_command_to_string): Implement by calling
6695 execute_command_to_ui_file.
6696
68bb5386
PW
66972019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6698
6699 * top.h (saved_command_line): Remove declaration.
6700 * top.c (previous_saved_command_line, previous_repeat_arguments):
6701 New variables.
6702 (saved_command_line): Make static, define together with other
6703 'repeat variables'.
6704 (dont_repeat): Clear repeat_arguments.
6705 (repeat_previous, get_saved_command_line, save_command_line):
6706 New functions.
6707 (gdb_init): Initialize saved_command_line
6708 and previous_saved_command_line.
6709 * main.c (captured_main_1): Remove saved_command_line initialization.
6710 * event-top.c (handle_line_of_input): Update to use
6711 the new 'repeat' related functions instead of direct access to
6712 saved_command_line.
6713 * command.h (repeat_previous, get_saved_command_line,
6714 save_command_line): New declarations.
6715 (dont_repeat): Add comment.
6716
bfcdb852
TT
67172019-05-30 Tom Tromey <tromey@adacore.com>
6718
6719 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6720 Fix comment.
6721 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6722
0ef209f2
JV
67232019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
6724
6725 PR cli/24587
6726 * completer.c (complete): Initialize variable word.
6727
955b06fa
SDJ
67282019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
6729
6730 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6731 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6732 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6733 'body' is NULL to the outter 'if', protecting the '!is_define'
6734 situation as well.
6735
fa9c3fa0
TT
67362019-05-29 Tom Tromey <tromey@adacore.com>
6737
6738 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6739 (dwarf_unknown): New function.
6740 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6741 (dwarf_type_encoding_name): Use dwarf_unknown.
6742
4330d61d
TT
67432019-05-29 Tom Tromey <tromey@adacore.com>
6744
6745 PR c++/20020:
6746 * cp-valprint.c (cp_print_value_fields): Call
6747 cp_print_static_field inside "try".
6748
33a6bc35
TT
67492019-05-29 Tom Tromey <tromey@adacore.com>
6750
6751 * inflow.c (struct terminal_info): Add default operator=.
6752 * configure: Rebuild.
6753 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6754 -Wdeprecated-copy-dtor, -Wredundant-move.
6755
000439d5
TT
67562019-05-29 Tom Tromey <tromey@adacore.com>
6757
6758 * NEWS: Add entry.
6759 * infcmd.c (print_return_value_1): Handle finish_print
6760 option.
6761 (show_print_finish): New function.
6762 (_initialize_infcmd): Add "set/show print finish" commands.
6763 * valprint.c (user_print_options): Initialize new member.
6764 * valprint.h (struct value_print_options) <finish_print>: New
6765 member.
6766
c0e70c62
TT
67672019-05-28 Tom Tromey <tromey@adacore.com>
6768
6769 * ada-lang.c (ada_remove_Xbn_suffix)
6770 (find_old_style_renaming_symbol)
6771 (parse_old_style_renaming): Remove.
6772 (ada_find_renaming_symbol): Don't call
6773 find_old_style_renaming_symbol.
6774 (ada_is_renaming_symbol): Rename from
6775 ada_find_renaming_symbol. Remove "block" parameter. Return
6776 bool. Now static.
6777 (ada_read_var_value): Update and simplify.
6778 * ada-exp.y (write_var_or_type): Remove old code.
6779
766f8836
AH
67802019-05-28 Alan Hayward <alan.hayward@arm.com>
6781
68255adc 6782 PR gdb/25010
766f8836
AH
6783 * event-top.c: Remove include comment.
6784 * inflow.c (class scoped_ignore_sigttou): Move from here...
6785 * inflow.h (class scoped_ignore_sigttou): ...to here.
6786 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6787 * top.c: Remove include comment.
6788
eb41253a
TT
67892019-05-27 Tom Tromey <tom@tromey.com>
6790
6791 * NEWS: Fix typo.
6792
4ca51187
TT
67932019-05-22 Tom Tromey <tromey@adacore.com>
6794
6795 * target.c (target_follow_exec): Constify parameter.
6796 * target-delegates.c: Rebuild.
6797 * remote.c (remote_target::follow_exec): Constify parameter.
6798 * infrun.c (follow_exec): Constify parameter.
6799 * target.h (struct target_ops) <follow_exec>: Constify parameter.
6800 (target_follow_exec): Likewise.
6801
8fca4da0
AH
68022019-05-22 Alan Hayward <alan.hayward@arm.com>
6803
6804 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6805 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6806
b7060614
AH
68072019-05-22 Alan Hayward <alan.hayward@arm.com>
6808
6809 * NEWS: Add debugredirect and testsuite sections.
6810
0a5954bd
SC
68112019-05-22 Simon Cook <simon.cook@embecosm.com>
6812
6813 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6814 target descriptions using exclusively floating point register name
6815 aliases.
6816
dc42e902
AB
68172019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
6818
6819 PR gdb/18644:
6820 * f-lang.c (build_fortran_types): Handle the case where
6821 gdbarch_floatformat_for_type returns a nullptr.
6822
fb7806c7
TV
68232019-05-21 Tom de Vries <tdevries@suse.de>
6824
6825 PR cli/24587
6826 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6827
34d11c68
AB
68282019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6829
6830 PR gdb/18644:
6831 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6832 16-byte floats.
6833 * i386-tdep.c (i386_floatformat_for_type): Use
6834 floatformats_ia64_quad for the 16-byte floating point component
6835 within a fortran 32-byte complex number.
6836
122cf0f2
AB
68372019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6838
6839 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6840 delete default constructor.
6841 (find_partial_die): Update to return const struct.
6842 (partial_die_parent_scope): Move variable declaration into scope
6843 of its use and change its type to auto.
6844 (guess_partial_die_structure_name): Likewise.
6845 (partial_die_info::fixup): Likewise.
6846
33d0e35a
TT
68472019-05-17 Tom Tromey <tromey@adacore.com>
6848
6849 * source.c (find_and_open_source): Remove cast.
6850
a45575b0
TT
68512019-05-17 Tom Tromey <tromey@adacore.com>
6852
6853 * annotate.c (annotate_source): Make "filename" const.
6854 * annotate.h (annotate_source): Use const.
6855
81f47ac2
AH
68562019-05-17 Alan Hayward <alan.hayward@arm.com>
6857
6858 * disasm.c (set_disassembler_options): Send errors to stderr.
6859
ca1285d1
AH
68602019-05-17 Alan Hayward <alan.hayward@arm.com>
6861
6862 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6863 (cli_interp_base::set_logging): Check debug_redirect.
6864 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6865 * cli/cli-logging.c (debug_redirect): Add static variable.
6866 (pop_output_files): Add default param.
6867 (handle_redirections): Print debug setting.
6868 (show_logging_command): Likewise.
6869 (_initialize_cli_logging): Add debugredirect command.
6870 * interps.c (current_interp_set_logging): Add debug_redirect
6871 parameter.
6872 * interps.h (set_logging): Add debug_redirect parameter.
6873 (current_interp_set_logging): Likewise.
6874 * mi/mi-common.h: Likewise.
6875 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6876
68772019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
6878 Tom Tromey <tromey@adacore.com>
6879
6880 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6881 directly.
6882 * cli/cli-interp.h (make_logging_output): Remove declaration.
6883 * cli/cli-logging.c (make_logging_output): Remove function.
6884 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6885 directly.
6886 * ui-file.c (tee_file::tee_file): Remove bools.
6887 (tee_file::~tee_file): Remove deletes.
6888 * ui-file.h (tee_file): Remove bools.
6889
26648588
JV
68902019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
6891
6892 * mi/mi-cmds.h (mi_cmd_complete): New function.
6893 * mi/mi-main.c (mi_cmd_complete): Likewise.
6894 * mi/mi-cmds.c: Define new MI command -complete.
6895 * NEWS: Mention new -complete command.
6896
6e035501
JV
68972019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
6898
6899 * completer.h (complete): New function.
6900 * completer.c (complete): Likewise.
6901 * cli/cli-cmds.c: (complete_command): Update to use new complete()
6902 function defined in completer.h.
6903
7d0e2ece
JV
69042019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
6905
e79be6e5 6906 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 6907
fb816e8b
TV
69082019-05-17 Tom de Vries <tdevries@suse.de>
6909
6910 PR gdb/24094
6911 * dwarf2read.c (struct cu_partial_die_info): New struct.
6912 (find_partial_die): Return cu_partial_die_info.
6913 (partial_die_parent_scope, guess_partial_die_structure_name)
6914 (partial_die_info::fixup): Handle new return type of find_partial_die.
6915
677052f2
SDJ
69162019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6917
a1726c38 6918 PR breakpoints/24541
677052f2
SDJ
6919 * stap-probe.c (stap_parse_register_operand): Make "regname" an
6920 "std::string", simplifying the algorithm.
6921
f3da9116
SDJ
69222019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6923
6924 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6925 (stap_static_probe_ops::get_probes): Likewise.
6926
f1bb75ab
SDJ
69272019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6928
6929 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6930 '-')" and "else if".
6931 (stap_parse_single_operand): Join checks for
6932 "gdbarch_stap_parse_special_token_p" and
6933 "gdbarch_stap_parse_special_token" in the same "if" statement.
6934 Invert check when verifying for operation on register
6935 displacement.
6936
3ca58cde
SDJ
69372019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6938
6939 * stap-probe.c (stap_get_opcode): Update comment.
6940 (stap_get_expected_argument_type): Likewise.
6941 (handle_stap_probe): Likewise.
6942
af2d9bee
SDJ
69432019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6944
6945 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6946 return type to 'bool'. Adjust comment. Use 'bool' when
6947 appropriate.
6948 (i386_stap_parse_special_token_three_arg_disp): Likewise.
6949 * stap-probe.c (stap_parse_argument_1): Likewise.
6950 (stap_is_operator): Likewise.
6951 (stap_is_generic_prefix): Likewise.
6952 (stap_is_register_prefix): Likewise.
6953 (stap_is_register_indirection_prefix): Likewise.
6954 (stap_is_integer_prefix): Likewise.
6955 (stap_generic_check_suffix): Likewise.
6956 (stap_check_integer_suffix): Likewise.
6957 (stap_check_register_suffix): Likewise.
6958 (stap_check_register_indirection_suffix): Likewise.
6959 (stap_parse_register_operand): Likewise.
6960 (stap_parse_single_operand): Likewise.
6961 (stap_parse_argument_1): Likewise.
6962 (stap_probe::get_argument_count): Likewise.
6963 (stap_is_operator): Likewise.
6964
61c9c421
TT
69652019-05-16 Tom Tromey <tromey@adacore.com>
6966
6967 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6968 keyword to foreach.
6969
9ddc1af1
SM
69702019-05-15 Simon Marchi <simon.marchi@efficios.com>
6971
6972 * linux-thread-db.c (try_thread_db_load_1): Change return type
6973 to bool.
6974 (try_thread_db_load): Likewise.
6975 (try_thread_db_load_from_pdir_1): Likewise.
6976 (try_thread_db_load_from_pdir): Likewise.
6977 (try_thread_db_load_from_sdir): Likewise.
6978 (try_thread_db_load_from_dir): Likewise.
6979 (thread_db_load_search): Likewise.
6980 (has_libpthread): Likewise.
6981 (thread_db_load): Likewise.
6982
7bede828
SDJ
69832019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
6984
6985 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6986 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6987 NULL, and complain/return if that's the case.
6988
c5358db4
JD
69892019-05-15 John Darrington <john@darrington.wattle.id.au>
6990
6991 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6992 (advance, posn, abstract_read_memory): New functions.
6993 [struct mem_read_abstraction]: New struct.
6994 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6995
c408a94f
TT
69962019-05-14 Tom Tromey <tromey@adacore.com>
6997
6998 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6999 value is not lval_memory.
7000
e7bd7fba
TT
70012019-05-14 Tom Tromey <tromey@adacore.com>
7002
7003 * solib.c (info_sharedlibrary_command): Style the file name.
7004
a6d0f249
AH
70052019-05-14 Alan Hayward <alan.hayward@arm.com>
7006
7007 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7008 (aarch64_vnv_type): Likewise.
7009 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7010 * common/tdesc.c: Likewise.
7011 * common/tdesc.h (enum tdesc_type_kind): Likewise.
7012 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7013 * features/aarch64-fpu.xml: Add ieee half view.
7014 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7015 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7016 * gdbtypes.h (struct builtin_type): Likewise.
7017 (struct objfile_type): Likewise.
7018
66b8bb74
SM
70192019-05-12 Paul Naert <paul.naert@polymtl.ca>
7020
7021 * language.c (language_sniff_from_mangled_name): Fix "langauge"
7022 typo.
7023 * location.h (string_to_event_location): Likewise.
7024
21c219fd
JB
70252019-05-11 Joel Brobecker <brobecker@adacore.com>
7026
7027 GDB 8.3 released.
7028
13674803
SM
70292019-05-10 Simon Marchi <simon.marchi@efficios.com>
7030
7031 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7032 New variable declaration.
7033 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7034 New variable.
7035 (print_one_breakpoint): Use ui_out::test_flags and new global
7036 variable to compute use_fixed_output.
7037 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7038 Remove.
7039 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7040 (mi_multi_location_breakpoint_output_fixed): Remove.
7041 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7042 new variable.
7043 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7044 fix_multi_location_breakpoint_output flag if version >= 3.
7045 * ui-out.h (enum ui_out_flag)
7046 <fix_multi_location_breakpoint_output>: New enumerator.
7047
a9eac7f9
SM
70482019-05-10 Simon Marchi <simon.marchi@efficios.com>
7049
7050 * contrib/cc-with-tweaks.sh: Validate dwz's work.
7051
71bed2db
TT
70522019-05-10 Tom Tromey <tromey@adacore.com>
7053
7054 * ada-lang.c (catch_ada_completer): New function.
7055 (_initialize_ada_language): Use it.
7056
24c54127
TT
70572019-05-10 Tom Tromey <tromey@adacore.com>
7058
7059 * thread.c (print_thread_info): Make "requested_threads" const.
7060 * gdbthread.h (print_thread_info): Make "requested_threads"
7061 const.
7062 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7063 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7064
7a102139
TT
70652019-05-08 Tom Tromey <tom@tromey.com>
7066
7067 * gdbtypes.c (objfile_type_data): Change type.
7068 (objfile_type, _initialize_gdbtypes): Update.
7069
924d79e2
TT
70702019-05-08 Tom Tromey <tom@tromey.com>
7071
7072 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7073 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7074 (_initialize_dwarf2_frame): Update.
7075
4c58e337
TT
70762019-05-08 Tom Tromey <tom@tromey.com>
7077
7078 * objc-lang.c (objc_objfile_data): Change type.
7079 (find_methods): Update.
7080 (_initialize_objc_lang): Remove.
7081
d772d2ab
TT
70822019-05-08 Tom Tromey <tom@tromey.com>
7083
7084 * stabsread.c (rs6000_builtin_type_data): Change type.
7085 (rs6000_builtin_type, _initialize_stabsread): Update.
7086
d11d83f4
TT
70872019-05-08 Tom Tromey <tom@tromey.com>
7088
7089 * mips-tdep.c (mips_pdr_data): Remove.
7090 (_initialize_mips_tdep): Update.
7091
9a73f0ad
TT
70922019-05-08 Tom Tromey <tom@tromey.com>
7093
7094 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7095 (hppa_init_objfile_priv_data, read_unwind_info)
7096 (find_unwind_entry, _initialize_hppa_tdep): Update.
7097
8127a2fa
TT
70982019-05-08 Tom Tromey <tom@tromey.com>
7099
7100 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7101 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
7102 on obstack.
7103 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7104
91d3055d
TT
71052019-05-08 Tom Tromey <tom@tromey.com>
7106
7107 * mdebugread.c (basic_type_data): Change type.
7108 (basic_type, _initialize_mdebugread): Update.
7109
31930bd3
TT
71102019-05-08 Tom Tromey <tom@tromey.com>
7111
7112 * common/gdb_unique_ptr.h (struct noop_deleter): New.
7113
bdb3ed9e
TT
71142019-05-08 Tom Tromey <tom@tromey.com>
7115
7116 * nto-tdep.c (nto_inferior_data_reg): Change type.
7117 (nto_inferior_data): Update.
7118 (nto_inferior_data_cleanup, nto_new_inferior_data)
7119 (_initialize_nto_tdep): Remove.
7120 * nto-tdep.h (struct nto_inferior_data): Add initializers.
7121
f37b313d
TT
71222019-05-08 Tom Tromey <tom@tromey.com>
7123
7124 * ada-lang.c (struct ada_inferior_data): Add initializers.
7125 (ada_inferior_data): Change type.
7126 (ada_inferior_data_cleanup): Remove.
7127 (get_ada_inferior_data, ada_inferior_exit)
7128 (struct ada_pspace_data): Add initializers, destructor.
7129 (ada_pspace_data_handle): Change type.
7130 (get_ada_pspace_data): Update.
7131 (ada_pspace_data_cleanup): Remove.
7132
24699405
TT
71332019-05-08 Tom Tromey <tom@tromey.com>
7134
7135 * coffread.c (struct coff_symfile_info): Add initializers.
7136 (coff_objfile_data_key): Move lower. Change type.
7137 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7138 Update.
7139 (coff_free_info): Remove.
7140
d4e05d2f
TT
71412019-05-08 Tom Tromey <tom@tromey.com>
7142
7143 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7144 (fbsd_pspace_data_handle): Move lower. Change type.
7145 (get_fbsd_pspace_data): Update.
7146 (fbsd_pspace_data_cleanup): Remove.
7147 (_initialize_fbsd_tdep): Update.
7148
14ef6690
TT
71492019-05-08 Tom Tromey <tom@tromey.com>
7150
7151 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7152 (get_ada_tasks_pspace_data): Update.
7153 (ada_tasks_pspace_data_cleanup): Remove.
7154 (_initialize_tasks): Update.
7155 (ada_tasks_inferior_data_handle): Change type.
7156 (get_ada_tasks_inferior_data): Update.
7157 (ada_tasks_inferior_data_cleanup): Remove.
7158 (struct ada_tasks_pspace_data): Add initializers.
7159
814cf43a
TT
71602019-05-08 Tom Tromey <tom@tromey.com>
7161
7162 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7163 * symfile-debug.c (debug_sym_get_probes): Change type.
7164 * stap-probe.c (handle_stap_probe):
7165 (stap_static_probe_ops::get_probes): Change type.
7166 * probe.h (class static_probe_ops) <get_probes>: Change type.
7167 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7168 (parse_probes_in_pspace): Update.
7169 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7170 Update.
7171 (any_static_probe_ops::get_probes): Change type.
7172 * elfread.c (elfread_data): New typedef.
7173 (probe_key): Change type.
7174 (elf_get_probes): Likewise. Update.
7175 (probe_key_free): Remove.
7176 (_initialize_elfread): Update.
7177 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7178 Change type.
7179 (dtrace_process_dof_probe, dtrace_process_dof)
7180 (dtrace_static_probe_ops::get_probe): Change type.
7181
02dc647e
TT
71822019-05-08 Tom Tromey <tom@tromey.com>
7183
7184 * xcoffread.c (struct xcoff_symfile_info): Rename from
7185 coff_symfile_info. Add initializers.
7186 (xcoff_objfile_data_key): Move lower. Change type.
7187 (XCOFF_DATA): Rewrite.
7188 (xcoff_free_info): Remove.
7189 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7190 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7191 (xcoff_initial_scan): Update.
7192
09232438
TT
71932019-05-08 Tom Tromey <tom@tromey.com>
7194
7195 * solib-svr4.c (struct svr4_info): Add initializers and
7196 destructor.
7197 <probes_table>: Now an htab_up.
7198 (solib_svr4_pspace_data): Change type.
7199 (free_probes_table): Simplify.
7200 (~svr4_info): Rename from svr4_pspace_data_cleanup.
7201 (get_svr4_info, probes_table_htab_remove_objfile_probes)
7202 (probes_table_remove_objfile_probes, register_solib_event_probe)
7203 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7204 (_initialize_svr4_solib): Update.
7205
7b4a314f
TT
72062019-05-08 Tom Tromey <tom@tromey.com>
7207
7208 * remote.c (remote_pspace_data): Change type.
7209 (remote_pspace_data_cleanup): Remove.
7210 (get_remote_exec_file, set_pspace_remote_exec_file)
7211 (_initialize_remote): Update.
7212
51d3063a
TT
72132019-05-08 Tom Tromey <tom@tromey.com>
7214
7215 * breakpoint.c (breakpoint_objfile_key): Change type.
7216 (get_breakpoint_objfile_data): Update.
7217 (free_breakpoint_objfile_data): Remove.
7218 (_initialize_breakpoint): Update.
7219
89fb8848
TT
72202019-05-08 Tom Tromey <tom@tromey.com>
7221
7222 * linux-tdep.c (struct linux_info): Add initializers.
7223 (linux_inferior_data): Move. Change type.
7224 (invalidate_linux_cache_inf): Update.
7225 (linux_inferior_data_cleanup): Remove.
7226 (get_linux_inferior_data, _initialize_linux_tdep): Update.
7227
e9b89e2d
TT
72282019-05-08 Tom Tromey <tom@tromey.com>
7229
7230 * auxv.c (auxv_inferior_data): Move. Change type.
7231 (auxv_inferior_data_cleanup): Remove.
7232 (invalidate_auxv_cache_inf): Rewrite.
7233 (get_auxv_inferior_data, _initialize_auxv): Update.
7234
8c42777c
TT
72352019-05-08 Tom Tromey <tom@tromey.com>
7236
7237 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7238 (symfile_debug_objfile_data_key): Change type.
7239 (symfile_debug_installed, debug_qf_has_symbols)
7240 (debug_qf_find_last_source_symtab)
7241 (debug_qf_forget_cached_source_info)
7242 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7243 (debug_qf_print_stats, debug_qf_dump)
7244 (debug_qf_expand_symtabs_for_function)
7245 (debug_qf_expand_all_symtabs)
7246 (debug_qf_expand_symtabs_with_fullname)
7247 (debug_qf_map_matching_symbols)
7248 (debug_qf_expand_symtabs_matching)
7249 (debug_qf_find_pc_sect_compunit_symtab)
7250 (debug_qf_map_symbol_filenames)
7251 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7252 (debug_sym_new_init, debug_sym_init, debug_sym_read)
7253 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7254 (debug_sym_read_linetable, debug_sym_relocate): Update.
7255 (symfile_debug_free_objfile): Remove.
7256 (install_symfile_debug_logging, _initialize_symfile_debug):
7257 Update.
7258
5bfd760d
TT
72592019-05-08 Tom Tromey <tom@tromey.com>
7260
7261 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7262 allocate_on_obstack.
7263 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7264 (get_dwarf2_per_objfile): Update.
7265 (set_dwarf2_per_objfile): Remove.
7266 (dwarf2_has_info, dwarf2_get_section_info): Update.
7267 (dwarf2_free_objfile): Remove.
7268 (_initialize_dwarf2_read): Update.
7269
e85e19b4
TT
72702019-05-08 Tom Tromey <tom@tromey.com>
7271
7272 * auto-load.c (struct auto_load_pspace_info): Add destructor and
7273 initializers.
7274 <unsupported_script_warning_printed,
7275 script_not_found_warning_printed>: Now bool.
7276 (auto_load_pspace_data): Change type.
7277 (~auto_load_pspace_info): Rename from
7278 auto_load_pspace_data_cleanup.
7279 (get_auto_load_pspace_data, init_loaded_scripts_info)
7280 (clear_section_scripts, maybe_print_unsupported_script_warning)
7281 (maybe_print_script_not_found_warning, _initialize_auto_load):
7282 Update.
7283
f6aa7436
TT
72842019-05-08 Tom Tromey <tom@tromey.com>
7285
7286 * objfiles.c (objfile_pspace_info): Add destructor and
7287 initializers.
7288 (objfiles_pspace_data): Change type.
7289 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7290 (get_objfile_pspace_data): Update.
7291 (objfiles_bfd_data): Change type.
7292 (get_objfile_bfd_data): Update.
7293 (objfile_bfd_data_free, _initialize_objfiles): Remove.
7294
6ae614f6
TT
72952019-05-08 Tom Tromey <tom@tromey.com>
7296
7297 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7298 Change type.
7299 (get_catch_syscall_inferior_data): Update.
7300 (catch_syscall_inferior_data_cleanup): Remove.
7301 (_initialize_break_catch_syscall): Update.
7302
6509b8eb
TT
73032019-05-08 Tom Tromey <tom@tromey.com>
7304
7305 * inflow.c (struct terminal_info): Add destructor and
7306 initializers.
7307 (inflow_inferior_data): Change type.
7308 (~terminal_info): Rename from inflow_inferior_data_cleanup.
7309 (get_inflow_inferior_data, inflow_inferior_exit)
7310 (swap_terminal_info, _initialize_inflow): Update.
7311
35632941
TT
73122019-05-08 Tom Tromey <tom@tromey.com>
7313
7314 * target-dcache.c (target_dcache_cleanup): Remove.
7315 (target_dcache_aspace_key): Change type.
7316 (target_dcache_init_p, target_dcache_invalidate)
7317 (target_dcache_get, target_dcache_get_or_init)
7318 (_initialize_target_dcache): Update.
7319 * dcache.h (struct dcache_deleter): New.
7320
3017b94d
TT
73212019-05-08 Tom Tromey <tom@tromey.com>
7322
7323 * symtab.c (struct symbol_cache): Add destructor and
7324 initializers.
7325 (symbol_cache_key): Move. Change type.
7326 (make_symbol_cache, free_symbol_cache): Remove.
7327 (get_symbol_cache): Update.
7328 (symbol_cache_cleanup): Remove.
7329 (ALL_PSPACES, symbol_cache_flush)
7330 (maintenance_print_symbol_cache)
7331 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7332 Update.
7333
a32ad8c5
TT
73342019-05-08 Tom Tromey <tom@tromey.com>
7335
7336 * symtab.c (struct main_info): Add destructor and initializers.
7337 (main_progspace_key): Move. Change type.
7338 (get_main_info): Update.
7339 (main_info_cleanup): Remove.
7340 (_initialize_symtab): Update.
7341
5f6e90a0
TT
73422019-05-08 Tom Tromey <tom@tromey.com>
7343
7344 * registry.h (DECLARE_REGISTRY): Define the _key class.
7345
1bd0c6e4
AB
73462019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
7347
7348 * NEWS: Merge two 'New commands' sections.
7349
2228ef77
XR
73502019-05-08 Joel Brobecker <brobecker@adacore.com>
7351
7352 * ada-valprint.c (ada_val_print_gnat_array): Remove language
7353 parameter and use Ada language definition instead.
7354 (ada_val_print_ptr): Remove unused language parameter.
7355 (ada_val_print_num): Remove language parameter and use Ada language
7356 definition instead.
7357 (ada_val_print_enum, ada_val_print_flt): Remove unused language
7358 parameter.
7359 (ada_val_print_struct_union, ada_val_print_ref): Remove language
7360 parameter and use Ada language definition instead.
7361 (ada_val_print_1): Update all ada_val_print_xxx calls.
7362 Remove language parameter.
7363 (ada_val_print): Update ada_val_print_1 call.
7364
60fcc1c3
TT
73652019-05-08 Tom Tromey <tromey@adacore.com>
7366
7367 * remote.c (remote_hw_watchpoint_limit)
7368 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7369 Now static.
7370
ed2b7c17
TT
73712019-05-08 Tom Tromey <tromey@adacore.com>
7372
7373 * maint.c (_initialize_maint_cmds): Move initialization code to
7374 remote.c.
7375 (watchdog, show_watchdog): Move to remote.c.
7376 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
7377 "watchdog" static.
7378 (_initialize_remote): Move initialization code from maint.c.
7379 * defs.h (watchdog): Don't declare.
7380
b0be6c91
TT
73812019-05-08 Tom Tromey <tromey@adacore.com>
7382
7383 * tui/tui-interp.c: Include main.h.
7384 * interps.c: Include main.h.
7385 * main.h (interpreter_p): Declare.
7386 * defs.h (interpreter_p): Don't declare.
7387
587ee17b
TT
73882019-05-08 Tom Tromey <tromey@adacore.com>
7389
7390 * dwarf2loc.c: Include dwarf2read.h.
7391 * defs.h (read_unsigned_leb128): Don't declare.
7392 * dwarf2read.h (read_unsigned_leb128): Declare.
7393
ca1df239
TT
73942019-05-08 Tom Tromey <tromey@adacore.com>
7395
7396 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7397 method.
7398
99f20f08
TT
73992019-05-08 Tom Tromey <tromey@adacore.com>
7400
7401 * utils.c (fputs_maybe_filtered): Reset style after paging, even
7402 when no wrap column is set.
7403
80e55b13
TT
74042019-05-08 Tom Tromey <tromey@adacore.com>
7405
7406 * c-lang.c (c_get_string): Handle non-C-style arrays.
7407
9d3421af
TT
74082019-05-08 Tom Tromey <tromey@adacore.com>
7409
7410 * typeprint.c (print_offset_data::update): Print the bit offset,
7411 not the number of bits remaining.
7412
844333e2
TT
74132019-05-08 Tom Tromey <tromey@adacore.com>
7414
7415 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7416 padding at end of comment.
7417
988915ee
TT
74182019-05-08 Tom Tromey <tromey@adacore.com>
7419
7420 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7421 Compare main types.
7422
26bfd823
TT
74232019-05-06 Tom Tromey <tom@tromey.com>
7424
7425 * common/scoped_mmap.c: Include common-defs.h.
7426 * common/scoped_mmap.h: Don't include config.h.
7427
89055eaa
TT
74282019-05-04 Tom Tromey <tom@tromey.com>
7429
7430 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7431 (struct aarch64_call_info): Add initializers.
7432 <si>: Now a std::vector.
7433 (pass_on_stack, aarch64_push_dummy_call): Update.
7434
5da01df5
TT
74352019-05-04 Simon Marchi <simon.marchi@efficios.com>
7436 Tom Tromey <tom@tromey.com>
7437
7438 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7439 (ppc_threads): Now a std::vector. Now static.
7440 (hwdebug_find_thread_points_by_tid)
7441 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7442 Update.
7443
fbdf05a1
TT
74442019-05-04 Tom Tromey <tom@tromey.com>
7445
7446 * arc-tdep.c (arc_tdesc_init): Return bool.
7447
06d16ec9
TT
74482019-05-04 Tom Tromey <tom@tromey.com>
7449
7450 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7451 Use gdb_assert_not_reached.
7452
9c056022
TT
74532019-05-04 Tom Tromey <tom@tromey.com>
7454
7455 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7456 "false".
7457
fa9c2a59
TT
74582019-05-04 Tom Tromey <tom@tromey.com>
7459
7460 * arc-tdep.c (arc_tdesc_init): Use bool.
7461
e2eb806a
TT
74622019-05-04 Tom Tromey <tom@tromey.com>
7463
7464 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7465
6fe87677
TT
74662019-05-04 Tom Tromey <tom@tromey.com>
7467
7468 * cli/cli-cmds.c (valid_command_p): Return bool.
7469
7f008c9e
TT
74702019-05-04 Tom Tromey <tom@tromey.com>
7471
7472 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7473 * command.h (valid_user_defined_cmd_name_p): Channge return type.
7474
b6484282
RT
74752019-05-04 Raul Tambre <raul@tambre.ee>
7476
7477 * python/lib/gdb/prompt.py (_ExtendedPrompt)
7478 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7479 operator for comparison.
7480
af97b416
TT
74812019-05-04 Tom Tromey <tom@tromey.com>
7482
7483 * psymtab.c (psymbol_name_matches, match_partial_symbol)
7484 (lookup_partial_symbol, print_partial_symbols)
7485 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7486 (psymbol_compare): Update.
7487 (add_psymbol_to_bcache): Clear the entire psymbol.
7488 (maintenance_check_psymtabs): Update.
7489 * psympriv.h (struct partial_symbol): Don't derive from
7490 general_symbol_info.
7491 <obj_section, unrelocated_address, address,
7492 set_unrelocated_address>: Update.
7493 <ginfo>: New member.
7494 * dwarf-index-write.c (write_psymbols, debug_names::insert)
7495 (debug_names::write_psymbols): Update.
7496
9d6d4be8
TV
74972019-05-04 Tom de Vries <tdevries@suse.de>
7498
7499 * contrib/cc-with-tweaks.sh: Support -n arg.
7500
66452beb
PW
75012019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7502
7503 * corelow.c (core_target::detach): Ensure frame cache and
7504 register caches are cleared.
7505 inferior.c (exit_inferior_1): Likewise.
7506
bde09ab7
TT
75072019-05-03 Sandra Loosemore <sandra@codesourcery.com>
7508 Tom Tromey <tom@tromey.com>
7509
7510 * dictionary.c (collate_pending_symbols_by_language): Remove
7511 "struct" from foreach.
7512 * symtab.c (lookup_global_symbol_from_objfile)
7513 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7514 foreach.
7515 * ser-tcp.c (net_open): Remove "struct" from foreach.
7516 * objfiles.c (objfile_relocate, objfile_rebase)
7517 (objfile_has_symbols): Remove "struct" from foreach.
7518 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7519 from foreach.
7520 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7521 foreach.
7522 * darwin-nat.c (thread_info_from_private_thread_info): Remove
7523 "struct" from foreach.
7524 * ada-lang.c (create_excep_cond_exprs)
7525 (ada_exception_catchpoint_cond_string): Remove "struct" from
7526 foreach.
7527
222a8d25
TT
75282019-05-03 Tom Tromey <tromey@adacore.com>
7529
7530 * ada-exp.y (convert_char_literal): Check suffix of each
7531 enumerator.
7532
fcd60b84
DP
75332019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
7534
7535 PR ada/21406:
7536 * ada-exp.y (yywrap): Don't define.
7537 * ada-lex.l (%option): Add noyywrap
7538 (yywrap): Remove.
7539
5f2459c2
EZ
75402019-05-03 Eli Zaretskii <eliz@gnu.org>
7541
353ea2d1
EZ
7542 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7543 _WIN32_WINNT to the XP level, unless already defined to a higher
7544 level.
7545
7546 * unittests/parse-connection-spec-selftests.c:
7547 * ser-tcp.c:
7548 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
7549 override.
7550
5f2459c2
EZ
7551 * symfile.c (find_separate_debug_file): Remove colon from the
7552 drive spec of DOS/Windows file names of the target, so that the
7553 file name produced from DEBUGDIR and the target's directory will
7554 be valid on DOS/Windows systems.
7555
80062eb9
AB
75562019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
7557
7558 * rust-lang.c (val_print_struct): Handle printing structures
7559 containing strings.
7560
b8c05e85
TT
75612019-05-02 Tom Tromey <tromey@adacore.com>
7562
7563 * valarith.c (_initialize_valarith): Remove.
7564
4504bbde
TT
75652019-05-01 Tom Tromey <tromey@adacore.com>
7566
7567 * ada-lang.c (ada_value_primitive_field): Treat more fields as
7568 bitfields.
7569
d48e62f4
TT
75702019-05-01 Tom Tromey <tromey@adacore.com>
7571
7572 * ada-lang.c (ada_value_assign): Correctly compute starting offset
7573 for big-endian copies.
7574
15f18d14
AT
75752019-04-30 Ali Tamur <tamur@google.com>
7576 * gdb/dwarf2read.c (read_3_bytes): New declaration.
7577 (read_attribute_value): Added DW_FORM_strx1-4 cases.
7578 (read_3_bytes): New function.
7579
ab4ee614
JB
75802019-04-30 Joel Brobecker <brobecker@adacore.com>
7581
7582 * windows-nat.c (main_thread_id): Delete.
7583 (handle_output_debug_string): Replace main_thread_id by
7584 current_event.dwThreadId.
7585 (fake_create_process): Likewise.
7586 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7587 Do not set main_thread_id.
7588 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7589 current_event.dwThreadId.
7590 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7591
8ed5b76e
JB
75922019-04-30 Joel Brobecker <brobecker@adacore.com>
7593
7594 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7595 Use current_event.dwThreadId instead of main_thread_id.
7596
2ff0a947
TT
75972019-04-30 Tom Tromey <tromey@adacore.com>
7598
7599 * ada-lang.c (ada_lookup_simple_minsyms): New function.
7600 (create_excep_cond_exprs): Iterate over program spaces.
7601 (ada_exception_catchpoint_cond_string): Examine all minimal
7602 symbols for exception types.
7603
a776957c
TT
76042019-04-30 Tom Tromey <tromey@adacore.com>
7605
7606 PR c++/24470:
7607 * dwarf2read.c (process_structure_scope): Handle case where type
7608 has template parameters but no symbol was created.
7609
bc68014d
AB
76102019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7611 Chris January <chris.january@arm.com>
7612
7613 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7614 qualifier.
7615 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7616
f1fdc960
AB
76172019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7618
7619 * f-typeprint.c (f_print_type): Update rules for printing
7620 whitespace.
7621 (f_type_print_varspec_suffix): Likewise.
7622
bf7a4de1
AB
76232019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7624 Chris January <chris.january@arm.com>
7625
7626 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7627 function arguments.
7628
bbe75b9d
AB
76292019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7630
7631 * f-lang.c (build_fortran_types): Change name of void type to
7632 lower case.
7633 * f-typeprint.c (f_type_print_base): Print the name of the void
7634 type, rather than a fixed string.
7635 * f-valprint.c (f_decorations): Use lower case void string.
7636
1db455a7
AB
76372019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7638 Chris January <chris.january@arm.com>
7639
7640 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7641 types for Fortran.
7642
b6d03bb2
AB
76432019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7644 Chris January <chris.january@arm.com>
7645 David Lecomber <david.lecomber@arm.com>
7646
7647 * f-exp.y (BINOP_INTRINSIC): New token.
7648 (exp): New parser rule handling BINOP_INTRINSIC.
7649 (f77_keywords): Add new builtin procedures.
7650 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7651 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7652 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7653 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7654 (print_unop_subexp_f): New function.
7655 (print_binop_subexp_f): New function.
7656 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7657 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7658 (dump_subexp_body_f): Likewise.
7659 (operator_check_f): Likewise.
7660 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7661 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7662
83228e93
AB
76632019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7664
7665 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7666 UNOP_KIND.
7667 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7668 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7669 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7670 (operator_length_f): New fuction.
7671 (print_subexp_f): New function.
7672 (op_name_f): New function.
7673 (dump_subexp_body_f): New function.
7674 (operator_check_f): New function.
7675 (exp_descriptor_f): Replace standard expression handling functions
7676 with new functions.
7677 * gdb/fortran-operator.def: New file.
7678 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7679 * gdb/std-operator.def: Remove UNOP_KIND.
7680
6fdcd7cc
AB
76812019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7682
7683 * std-operator.def: Remove unbalanced, stray double quote
7684 character.
7685
2e62ab40
AB
76862019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7687 Chris January <chris.january@arm.com>
7688 Daniel Everett <daniel.everett@arm.com>
7689 Nick Forrington <nick.forrington@arm.com>
7690 Richard Bunt <richard.bunt@arm.com>
7691
7692 * cp-valprint.c (cp_print_value_fields): Allow an additional level
7693 of depth when printing anonymous structs or unions.
7694 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7695 Don't print either the top-level value, or the children if the
7696 max-depth is exceeded.
7697 (ppscm_print_children): When printing the key of a map, allow one
7698 extra level of depth.
7699 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7700 print either the top-level value, or the children if the max-depth
7701 is exceeded.
7702 (print_children): When printing the key of a map, allow one extra
7703 level of depth.
7704 * python/py-value.c (valpy_format_string): Add max_depth keyword.
7705 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7706 (user_print_options): Initialise max_depth field.
7707 (val_print_scalar_or_string_type_p): New function.
7708 (val_print): Check to see if the max depth has been reached.
7709 (val_print_check_max_depth): Define new function.
7710 (show_print_max_depth): New function.
7711 (_initialize_valprint): Add 'print max-depth' option.
7712 * valprint.h (struct value_print_options) <max_depth>: New field.
7713 (val_print_check_max_depth): Declare new function.
7714 * NEWS: Document new feature.
7715
4be290b2
AB
77162019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7717
7718 * ada-lang.c (ada_language_defn): Initialise new field.
7719 * c-lang.c (c_is_string_type_p): New function.
7720 (c_language_defn): Initialise new field.
7721 (cplus_language_defn): Initialise new field.
7722 (asm_language_defn): Initialise new field.
7723 (minimal_language_defn): Initialise new field.
7724 * c-lang.h (c_is_string_type_p): Declare new function.
7725 * d-lang.c (d_language_defn): Initialise new field.
7726 * f-lang.c (f_is_string_type_p): New function.
7727 (f_language_defn): Initialise new field.
7728 * go-lang.c (go_is_string_type_p): New function.
7729 (go_language_defn): Initialise new field.
7730 * language.c (default_is_string_type_p): New function.
7731 (unknown_language_defn): Initialise new field.
7732 (auto_language_defn): Initialise new field.
7733 * language.h (struct language_defn) <la_is_string_type_p>: New
7734 member variable.
7735 (default_is_string_type_p): Declare new function.
7736 * m2-lang.c (m2_language_defn): Initialise new field.
7737 * objc-lang.c (objc_language_defn): Initialise new field.
7738 * opencl-lang.c (opencl_language_defn): Initialise new field.
7739 * p-lang.c (pascal_is_string_type_p): New function.
7740 (pascal_language_defn): Initialise new field.
7741 * rust-lang.c (rust_is_string_type_p): New function.
7742 (rust_language_defn): Initialise new field.
7743
721b08c6
AB
77442019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7745
7746 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7747 New field.
7748 * ada-lang.c (ada_language_defn): Initialise new field.
7749 * c-lang.c (c_language_defn): Likewise.
7750 (cplus_language_defn): Likewise.
7751 (asm_language_defn): Likewise.
7752 (minimal_language_defn): Likewise.
7753 * d-lang.c (d_language_defn): Likewise.
7754 * f-lang.c (f_language_defn): Likewise.
7755 * go-lang.c (go_language_defn): Likewise.
7756 * language.c (unknown_language_defn): Likewise.
7757 (auto_language_defn): Likewise.
7758 * m2-lang.c (m2_language_defn): Likewise.
7759 * objc-lang.c (objc_language_defn): Likewise.
7760 * opencl-lang.c (opencl_language_defn): Likewise.
7761 * p-lang.c (pascal_language_defn): Likewise.
7762 * rust-lang.c (rust_language_defn): Likewise.
7763
fc913e53
AB
77642019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7765
7766 * ada-lang.c (ada_is_character_type): Change return type to bool.
7767 (ada_is_string_type): Likewise.
7768 * ada-lang.h (ada_is_character_type): Update declaration
7769 (ada_is_string_type): Likewise.
7770
fa731fa0
PW
77712019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7772
7773 Support style in 'frame|thread apply'
7774
7775 * gdbcmd.h (execute_command_to_string): New term_out parameter.
7776 * record.c (record_start, record_stop): Update callers of
7777 execute_command_to_string with false.
7778 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7779 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7780 methods.
7781 (class string_file): New constructor with term_out parameter.
7782 Override methods term_out and can_emit_style_escape. New member
7783 term_out.
7784 (class stdio_file): Override can_emit_style_escape.
7785 (class tee_file): Override term_out and can_emit_style_escape.
7786 * utils.h (can_emit_style_escape): Remove.
7787 * utils.c (can_emit_style_escape): Likewise.
7788 Update all callers of can_emit_style_escape (SOMESTREAM) to
7789 SOMESTREAM->can_emit_style_escape.
7790 * source-cache.c (source_cache::get_source_lines): Likewise.
7791 * stack.c (frame_apply_command_count): Call execute_command_to_string
7792 passing the term_out characteristic of the current gdb_stdout.
7793 * thread.c (thr_try_catch_cmd): Likewise.
7794 * top.c (execute_command_to_string): pass term_out parameter
7795 to construct the string_file for the command output.
7796 * ui-file.c (term_cli_styling): New function (most code moved
7797 from utils.c can_emit_style_escape).
7798 (string_file::string_file, string_file::can_emit_style_escape,
7799 stdio_file::can_emit_style_escape, tee_file::term_out,
7800 tee_file::can_emit_style_escape): New functions.
7801
136afab8
PW
78022019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7803
7804 * NEWS: Mention the new set|show may-call-functions.
7805 * infcall.c (may_call_functions_p): New variable.
7806 (show_may_call_functions_p): New function.
7807 (call_function_by_hand_dummy): Throws an error if not
7808 may-call-functions.
7809 (_initialize_infcall): Call add_setshow_boolean_cmd for
7810 may-call-functions.
7811
725cbb63
KS
78122019-04-25 Keith Seitz <keiths@redhat.com>
7813
7814 PR c++/24367
7815 * cp-support.c (inspect_type): Don't attempt substitutions
7816 of symbol with the same name.
7817
3d1cbb78
TT
78182019-04-25 Tom Tromey <tromey@adacore.com>
7819
7820 PR gdb/24475:
7821 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7822 static.
7823
94aeb44b
TT
78242019-04-25 Tom Tromey <tromey@adacore.com>
7825
7826 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7827 rvalue reference.
7828 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7829 (gdb_xml_parser::parse): Use std::move.
7830 * python/python-internal.h (gdbpy_convert_exception): Take a const
7831 reference.
7832 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7833 std::move.
7834 * python/py-utils.c (gdbpy_convert_exception): Take a const
7835 reference.
7836 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7837 Use std::move.
7838 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7839 Use std::move.
7840 * mi/mi-main.c (mi_print_exception): Take a const reference.
7841 * main.c (handle_command_errors): Take a const reference.
7842 * linespec.c (parse_linespec): Use std::move.
7843 * infcall.c (run_inferior_call): Use std::move.
7844 (call_function_by_hand_dummy): Use std::move.
7845 * exec.c (try_open_exec_file): Use std::move.
7846 * exceptions.h (exception_print, exception_fprintf)
7847 (exception_print_same): Update.
7848 * exceptions.c (print_exception, exception_print)
7849 (exception_fprintf, exception_print_same): Change parameters to
7850 const reference.
7851 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7852 * common/new-op.c: Use std::move.
7853 * common/common-exceptions.h (struct gdb_exception): Add move
7854 constructor.
7855 (struct gdb_exception_error, struct gdb_exception_quit, struct
7856 gdb_quit_bad_alloc): Change constructor to move constructor.
7857 (throw_exception): Change parameter to rvalue reference.
7858 * common/common-exceptions.c (throw_exception): Take rvalue
7859 reference.
7860 * cli/cli-interp.c (safe_execute_command): Use std::move.
7861 * breakpoint.c (insert_bp_location, location_to_sals): Use
7862 std::move.
7863
680d7fd5
TT
78642019-04-25 Tom Tromey <tromey@adacore.com>
7865
7866 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7867 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7868 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7869 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7870 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7871 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7872 guile/scm-value.c: Use unpack.
7873 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7874 gdbscm_gdb_exception.
7875 (gdbscm_throw_gdb_exception): Likewise.
7876 (struct gdbscm_gdb_exception): New.
7877 (unpack): New function.
7878 (gdbscm_wrap): Use unpack.
7879
c6fdd8b2
TT
78802019-04-25 Tom Tromey <tromey@adacore.com>
7881
7882 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7883 (gdb_rl_callback_handler): Use std::move.
7884 * common/common-exceptions.h (struct gdb_exception): Add move
7885 assignment operator.
7886 (throw_exception_sjlj): Change "exception" to const reference.
7887 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7888 (throw_exception_sjlj): Change "exception" to const reference.
7889
cc06b668
TT
78902019-04-25 Tom Tromey <tromey@adacore.com>
7891
7892 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7893 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7894 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7895 Update.
7896 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7897 Update.
7898 * mi/mi-interp.c (mi_interp::exec): Update.
7899 * linespec.c (parse_linespec): Update.
7900 * infcall.c (run_inferior_call): Update.
7901 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7902 * guile/scm-symbol.c (gdbscm_lookup_symbol)
7903 (gdbscm_lookup_global_symbol): Update.
7904 * guile/scm-param.c (gdbscm_parameter_value): Update.
7905 * guile/scm-frame.c (gdbscm_frame_read_register)
7906 (gdbscm_frame_read_var): Update.
7907 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7908 * exec.c (try_open_exec_file): Update.
7909 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7910 (gdb_rl_callback_handler): Update.
7911 * common/common-exceptions.h (exception_none): Don't declare.
7912 * common/common-exceptions.c (exception_none): Don't define.
7913 (struct catcher) <exception>: Update.
7914 * cli/cli-interp.c (safe_execute_command): Update.
7915 * breakpoint.c (insert_bp_location, location_to_sals): Update.
7916
cf532bd1
AT
79172019-04-25 Ali Tamur <tamur@google.com>
7918
7919 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7920 (read_attribute_value): Likewise.
7921 (dwarf2_read_addr_index): Update comment.
7922 (read_str_index): Add DW_FORM_strx.
7923 (dwarf2_string_attr): Likewise.
7924 (dwarf2_const_value_attr): Likewise.
7925 (dump_die_shallow): Likewise.
7926 (dwarf2_fetch_constant_bytes): Likewise.
7927 (skip_form_bytes): Likewise.
7928 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7929
82433e3e
SDJ
79302019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
7931
7932 PR corefiles/11608
7933 PR corefiles/18187
7934 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7935 OFFSET. Verify if current mapping contains an ELF header.
7936 (linux_find_memory_regions_full): Adjust call to
7937 dump_mapping_p.
7938
723adb65
SL
79392019-04-25 Sandra Loosemore <sandra@codesourcery.com>
7940 Kang Li <kanglictf@gmail.com>
7941
7942 PR gdb/21600
7943
7944 * dwarf2-frame.c (read_initial_length): Be consistent about using
7945 unsigned representation of length.
7946 (decode_frame_entry_1): Likewise. Check for wraparound of
7947 end pointer as well as buffer overflow.
7948
596179f7
SDJ
79492019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
7950
7951 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7952 "vq".
7953
a59240a4
TT
79542019-04-24 Tom Tromey <tromey@adacore.com>
7955
7956 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7957
f872fdbb
AB
79582019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7959
7960 * s12z-tdep.c (s12z_unwind_pc): Delete.
7961 (s12z_unwind_sp): Delete.
7962 (s12z_gdbarch_init): Don't register deleted functions with
7963 gdbarch.
7964
b614e6f3
AB
79652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7966
7967 * rl78-tdep.c (rl78_unwind_sp): Delete.
7968 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7969
14faed38
AB
79702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7971
7972 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7973 (xstormy16_unwind_pc): Delete.
7974 (xstormy16_dummy_id): Delete.
7975 (xstormy16_gdbarch_init): Don't register deleted functions with
7976 gdbarch.
7977
541aad8a
AB
79782019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7979
7980 * vax-tdep.c (vax_unwind_pc): Delete.
7981 (vax_gdbarch_init): Don't register deleted function with gdbarch.
7982
29222070
AB
79832019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7984
7985 * v850-tdep.c (v850_unwind_sp): Delete.
7986 (v850_unwind_pc): Delete.
7987 (v850_dummy_id): Delete.
7988 (v850_gdbarch_init): Don't register deleted functions with
7989 gdbarch.
7990
0f534d76
AB
79912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7992
7993 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7994 (tilegx_unwind_pc): Delete.
7995 (tilegx_unwind_dummy_id): Delete.
7996 (tilegx_gdbarch_init): Don't register deleted functions with
7997 gdbarch.
7998
1ba7b7f9
AB
79992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8000
8001 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8002 (tic6x_dummy_id): Delete.
8003 (tic6x_gdbarch_init): Don't register deleted functions with
8004 gdbarch.
8005
d31f262c
AB
80062019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8007
8008 * sparc-tdep.c (sparc_unwind_pc): Delete.
8009 (sparc32_gdbarch_init): Don't register deleted function with
8010 gdbarch.
8011
6d14d64d
AB
80122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8013
8014 * sh-tdep.c (sh_unwind_sp): Delete.
8015 (sh_unwind_pc): Delete.
8016 (sh_dummy_id): Delete.
8017 (sh_gdbarch_init): Don't register deleted functions with
8018 gdbarch.
8019
a40dde9d
AB
80202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8021
8022 * score-tdep.c (score_unwind_sp): Delete.
8023 (score_unwind_pc): Delete.
8024 (score_dummy_id): Delete.
8025 (score_gdbarch_init): Don't register deleted functions with
8026 gdbarch.
8027
47c47d69
AB
80282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8029
8030 * rx-tdep.c (rx_unwind_pc): Delete.
8031 (rx_unwind_sp): Delete.
8032 (rx_dummy_id): Delete.
8033 (rx_gdbarch_init): Don't register deleted functions with
8034 gdbarch. Update comment.
8035
833a4480
AB
80362019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8037
8038 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8039 (rs6000_dummy_id): Delete.
8040 (rs6000_gdbarch_init): Don't register deleted functions with
8041 gdbarch.
8042
3f2cef49
AB
80432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8044
8045 * or1k-tdep.c (or1k_dummy_id): Delete.
8046 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8047
96acf884
AB
80482019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8049
8050 * nios2-tdep.c (nios2_dummy_id): Delete.
8051 (nios2_unwind_sp): Delete.
8052 (nios2_gdbarch_init): Don't register deleted functions with
8053 gdbarch.
8054
ca0ab0aa
AB
80552019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8056
8057 * nds32-tdep.c (nds32_dummy_id): Delete.
8058 (nds32_unwind_pc): Delete.
8059 (nds32_unwind_sp): Delete.
8060 (nds32_gdbarch_init): Don't register deleted functions with
8061 gdbarch.
8062
c8259044
AB
80632019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8064
8065 * msp430-tdep.c (msp430_unwind_pc): Delete.
8066 (msp430_unwind_sp): Delete.
8067 (msp430_dummy_id): Delete.
8068 (msp430_gdbarch_init): Don't register deleted functions with
8069 gdbarch.
8070
27f113c8
AB
80712019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8072
8073 * moxie-tdep.c (moxie_unwind_sp): Delete.
8074 (moxie_unwind_pc): Delete.
8075 (moxie_dummy_id): Delete.
8076 (moxie_gdbarch_init): Don't register deleted functions with
8077 gdbarch.
8078
aee6c3cd
AB
80792019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8080
8081 * mn10300-tdep.c (mn10300_dummy_id): Delete.
8082 (mn10300_unwind_pc): Delete.
8083 (mn10300_unwind_sp): Delete.
8084 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8085 mn10300_unwind_sp.
8086 (mn10300_frame_unwind_init): Don't register deleted functions with
8087 gdbarch.
8088
8e2b5aea
AB
80892019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8090
8091 * mep-tdep.c (mep_unwind_pc): Delete.
8092 (mep_unwind_sp): Delete.
8093 (mep_dummy_id): Delete.
8094 (mep_gdbarch_init): Don't register deleted functions with
8095 gdbarch.
8096
43cf3ede
AB
80972019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8098
8099 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8100 (m68hc11_unwind_sp): Delete.
8101 (m68hc11_gdbarch_init): Don't register deleted functions with
8102 gdbarch.
8103
5e79b7bb
AB
81042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8105
8106 * m32r-tdep.c (m32r_unwind_sp): Delete.
8107 (m32r_unwind_pc): Delete.
8108 (m32r_dummy_id): Delete.
8109 (m32r_gdbarch_init): Don't register deleted functions with
8110 gdbarch.
8111
89b268d8
AB
81122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8113
8114 * m32c-tdep.c (m32c_unwind_pc): Delete.
8115 (m32c_unwind_sp): Delete.
8116 (m32c_dummy_id): Delete.
8117 (m32c_gdbarch_init): Don't register deleted functions with
8118 gdbarch.
8119
946c28d2
AB
81202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8121
8122 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8123 (lm32_unwind_pc): Delete.
8124 (lm32_dummy_id): Delete.
8125 (lm32_gdbarch_init): Don't register deleted functions with
8126 gdbarch.
8127
bf12844a
AB
81282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8129
8130 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8131 (iq2000_unwind_pc): Delete.
8132 (iq2000_dummy_id): Delete.
8133 (iq2000_gdbarch_init): Don't register deleted functions with
8134 gdbarch.
8135
ecbc06d2
AB
81362019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8137
8138 * nds32-tdep.c (nds32_type_align): Delete.
8139 (nds32_push_dummy_call): Use type_align instead.
8140
030197b4
AB
81412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8142
8143 * arm-tdep.c (arm_type_align): Only handle vector override case.
8144 (arm_push_dummy_call): Use type_align.
8145 (arm_gdbarch_init): Register arm_type_align gdbarch function.
8146
b907456c
AB
81472019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8148
8149 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8150 case.
8151 (pass_on_stack): Use type_align.
8152 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8153 function.
8154
9e97ba43
TT
81552019-04-23 Tom Tromey <tromey@adacore.com>
8156
8157 * dwarf2read.c (line_header::file_name_at): Remove unused
8158 overload.
8159
6892f601
TV
81602019-04-23 Tom de Vries <tdevries@suse.de>
8161
8162 PR gdb/24438
8163 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8164 invocation.
8165
336d760d
AT
8166
81672019-03-27 Ali Tamur <tamur@google.com>
8168
8169 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8170 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8171 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8172 (dwarf_expr_context::get_addr_index): Likewise
8173 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8174 (symbol_needs_eval_context::get_addr_index): Likewise
8175 (disassemble_dwarf_expression): Add DW_OP_addrx
8176 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8177 (read_cutu_die_from_dwo): Update comment
8178 (skip_one_die): Add DW_FORM_addrx
8179 (read_attribute_value): Likewise
8180 (var_decode_location): Add DW_OP_addrx
8181 (dwarf2_const_value_attr): Add DW_FORM_addrx
8182 (dump_die_shallow): Likewise
8183 (dwarf2_fetch_constant_bytes): Likewise
8184 (decode_locdesc): Add DW_OP_addrx
8185 (skip_form_bytes): Add DW_FORM_addrx
8186
ad9d13f8
AT
81872019-04-22 Ali Tamur <tamur@google.com>
8188
8189 * MAINTAINERS (Write After Approval): Add self.
8190
d70cc3ba
SM
81912019-04-22 Simon Marchi <simon.marchi@efficios.com>
8192
8193 * solib-svr4.c (get_svr4_info): Add pspace parameter.
8194 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8195 (open_symbol_file_object): Likewise.
8196 (svr4_default_sos): Add info parameter.
8197 (svr4_read_so_list): Likewise.
8198 (svr4_current_sos_direct): Adjust functions calls to pass down
8199 info.
8200 (svr4_current_sos_1): Add info parameter.
8201 (svr4_current_sos): Call get_svr4_info, pass info down to
8202 svr4_current_sos_1.
8203 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8204 get_svr4_info.
8205 (svr4_in_dynsym_resolve_code): Pass current_program_space to
8206 get_svr4_info.
8207 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8208 to get_svr4_info.
8209 (probes_table_remove_objfile_probes): Likewise.
8210 (register_solib_event_probe): Add info parameter.
8211 (solist_update_incremental): Pass info parameter down to
8212 svr4_read_so_list.
8213 (disable_probes_interface): Add info parameter.
8214 (svr4_handle_solib_event): Pass current_program_space to
8215 get_svr4_info. Adjust disable_probes_interface cleanup.
8216 (svr4_create_probe_breakpoints): Add info parameter, pass it
8217 down to register_solib_event_probe.
8218 (svr4_create_solib_event_breakpoints): Add info parameter,
8219 pass it down to svr4_create_probe_breakpoints.
8220 (enable_break): Pass info down to
8221 svr4_create_solib_event_breakpoints.
8222 (svr4_solib_create_inferior_hook): Pass current_program_space to
8223 get_svr4_info.
8224 (svr4_clear_solib): Likewise.
8225
7905fc35
PA
82262019-04-22 Pedro Alves <palves@redhat.com>
8227
8228 * solib-svr4.c (svr4_free_objfile_observer): New.
8229 (probe_and_action::objfile): New field.
8230 (probes_table_htab_remove_objfile_probes)
8231 (probes_table_remove_objfile_probes): New functions.
8232 (register_solib_event_probe): Add 'objfile' parameter. Store it
8233 in the new probe_and_action. Don't store the probe in 'lookup'.
8234 (svr4_create_probe_breakpoints): Pass objfile to
8235 register_solib_event_probe.
8236 (_initialize_svr4_solib): Register a free_objfile observer.
8237
fb881986
TT
82382019-04-19 Tom Tromey <tom@tromey.com>
8239
8240 * common/queue.h: Remove.
8241
8732db6c
TT
82422019-04-19 Tom Tromey <tom@tromey.com>
8243
8244 * event-loop.c: Don't include "common/queue.h".
8245
97dfbadd
TT
82462019-04-19 Tom Tromey <tom@tromey.com>
8247
8248 * remote.c (remote_target): Use delete.
8249 * remote-notif.h: Include <list>, not "common/queue.h".
8250 (notif_client_p): Remove typedef.
8251 (remote_notif_state): Add constructor, destructor, initializer.
8252 <notif_queue>: Now a std::list.
8253 (remote_notif_state_xfree): Don't declare.
8254 * remote-notif.c (remote_notif_process, handle_notification)
8255 (remote_notif_state_allocate): Update.
8256 (~remote_notif_state): Rename from remote_notif_state_xfree.
8257
cf250e36
TT
82582019-04-19 Tom Tromey <tom@tromey.com>
8259
8260 * symfile.c (reread_symbols): Update.
8261 * objfiles.c (objfile_register_static_link)
8262 (objfile_lookup_static_link): Update
8263 (~objfile) Don't delete static_links.
8264 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8265
61f4b350
TT
82662019-04-19 Tom Tromey <tom@tromey.com>
8267
8268 * type-stack.h (struct type_stack) <insert>: Constify string.
8269 * type-stack.c (type_stack::insert): Constify string.
8270 * gdbtypes.h (lookup_template_type): Update.
8271 (address_space_name_to_int): Update.
8272 * gdbtypes.c (address_space_name_to_int): Make space_identifier
8273 const.
8274 (lookup_template_type): Make name const.
8275 * c-exp.y: Update rules.
8276 (lex_one_token, classify_name, classify_inner_name)
8277 (c_print_token): Update.
8278 * p-exp.y: Update rules.
8279 (yylex): Update.
8280 * f-exp.y: Update rules.
8281 (yylex): Update.
8282 * d-exp.y: Update rules.
8283 (lex_one_token, classify_name, classify_inner_name): Update.
8284 * parse.c (write_dollar_variable, copy_name): Return std::string.
8285 * parser-defs.h (copy_name): Change return type.
8286 * m2-exp.y: Update rules.
8287 (yylex): Update.
8288 * go-exp.y (lex_one_token): Update.
8289 Update rules.
8290 (classify_unsafe_function, classify_packaged_name)
8291 (classify_name, yylex): Update.
8292
189b8c2e
ST
82932019-04-19 Sergei Trofimovich <siarheit@google.com>
8294
8295 * configure.ac: add --enable-source-highlight switch.
8296 * configure: Regenerate.
8297 * top.c (print_gdb_version): plumb --enable-source-highlight
8298 status to "show configuration".
8299
8ecb59f8
TT
83002019-04-19 Tom Tromey <tromey@adacore.com>
8301
8302 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8303 Check ADA_TYPE_P.
8304 (empty_record, ada_template_to_fixed_record_type_1)
8305 (template_to_static_fixed_type)
8306 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8307 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8308 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8309 macros.
8310
62160ec9
TT
83112019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
8312
8313 PR symtab/24423:
8314 * source.c (print_source_lines_base): Advance "iter" when a
8315 control character is seen.
8316
f2ae8bc8
PW
83172019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8318
8319 * inferior.h (struct infcall_suspend_state_deleter):
8320 Catch exception in destructor to avoid crash.
8321
d563b953
PW
83222019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8323
8324 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8325 close to the add_com "shell".
8326
dc34c897
TT
83272019-04-18 Tom Tromey <tromey@adacore.com>
8328
8329 * process-stratum-target.h (class process_stratum_target)
8330 <stratum>: Add "final".
8331
a12e5744
TT
83322019-04-17 Tom Tromey <tromey@adacore.com>
8333
8334 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8335 against nullptr before use.
8336
a7e559cc
AH
83372019-04-17 Alan Hayward <alan.hayward@arm.com>
8338
8339 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8340
c01660c6
AB
83412019-04-17 Jim Wilson <jimw@sifive.com>
8342 Andrew Burgess <andrew.burgess@embecosm.com>
8343
8344 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8345 code read might fail, assume 4-byte breakpoint in that case.
8346
4aa866af
LS
83472019-04-15 Leszek Swirski <leszeks@google.com>
8348
8349 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8350 rather than a hand-rolled POD check when checking for forced MEMORY
8351 classification.
8352
48574d91
AH
83532019-04-15 Alan Hayward <alan.hayward@arm.com>
8354
8355 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8356 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8357 function.
8358 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8359 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8360 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8361 declaration.
8362
4da037ef
AH
83632019-04-15 Alan Hayward <alan.hayward@arm.com>
8364
8365 * aarch64-linux-nat.c
8366 (aarch64_linux_nat_target::thread_architecture): Add override.
8367 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8368 each VQ.
8369
ccb8d7e8
AH
83702019-04-15 Alan Hayward <alan.hayward@arm.com>
8371
8372 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8373
35add35e
AB
83742019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
8375
8376 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8377 target types of size 96-bits, add some additional comments, and
8378 check that the builtin type we found was the correct size.
8379
51196bbc
EZ
83802019-04-12 Eli Zaretskii <eliz@gnu.org>
8381
8382 * utils.c (prompt_for_continue): Don't restore the styling at the
8383 end, as applied_style has the wrong value. This fixes styling in
8384 long lists of file names that are interrupted by the "Continue?"
8385 prompt.
8386
62253a61
AB
83872019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
8388
8389 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8390 * c-lang.c (c_language_defn): Likewise.
8391 (cplus_language_defn): Likewise.
8392 (asm_language_defn): Likewise.
8393 (minimal_language_defn): Likewise.
8394 * d-lang.c (d_language_defn): Likewise.
8395 * f-lang.c (f_language_defn): Likewise.
8396 * go-lang.c (go_language_defn): Likewise.
8397 * language.c (unknown_language_defn): Likewise.
8398 (auto_language_defn): Likewise.
8399 * language.h (struct language_defn): Remove la_magic field.
8400 (LANG_MAGIC): Delete.
8401 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8402 * objc-lang.c (objc_language_defn): Likewise.
8403 * opencl-lang.c (opencl_language_defn): Likewise.
8404 * p-lang.c (pascal_language_defn): Likewise.
8405 * rust-lang.c (rust_language_defn): Likewise.
8406
a9158a86
AB
84072019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8408
8409 * riscv-tdep.c (riscv_type_align): New function.
8410 (riscv_type_alignment): Delete.
8411 (riscv_arg_location): Use 'type_align'.
8412 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8413
41077b66
AB
84142019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8415
8416 * gdbtypes.c (type_align): A struct with no non-static fields also
8417 has alignment of 1.
8418
9f0272f8
AB
84192019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8420
8421 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8422 component to 0.
8423 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8424 member.
8425 (riscv_struct_info::analyse): New implementation using new
8426 analyse_inner member function.
8427 (riscv_struct_info::field_offset): New member function.
8428 (riscv_struct_info::m_offsets): New member variable.
8429 (riscv_struct_info::analyse_inner): New private member function,
8430 takes the old implementation of riscv_struct_info::analyse but
8431 extended to track field offsets.
8432 (riscv_call_arg_struct): Update the struct folding special cases
8433 to handle cases where empty C++ structs, which are non-zero
8434 length, are found.
8435 (riscv_arg_location): Initialise the length of each location, a
8436 non-zero length now indicates the location is in use.
8437 (riscv_push_dummy_call): Allow for the first location having a
8438 non-zero offset when setting up arguments.
8439 (riscv_return_value): Likewise, but for return values.
8440
02cf60c7
TT
84412019-04-11 Tom Tromey <tromey@adacore.com>
8442
8443 * utils.c (internal_vproblem): Make "msg" const.
8444
68811f8f
AH
84452019-04-11 Alan Hayward <alan.hayward@arm.com>
8446
8447 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8448 * trad-frame.c (trad_frame_reset_saved_regs): New function.
8449 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8450 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8451
3f52fdbc
KB
84522019-04-10 Kevin Buettner <kevinb@redhat.com>
8453
8454 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8455 function.
8456 (fill_gregset): Call amd64_linux_collect_native_gregset instead
8457 of amd64_collect_native_gregset.
8458 (amd64_linux_nat_target::store_registers): Likewise.
8459
e9ad22ee
TT
84602019-04-10 Tom Tromey <tom@tromey.com>
8461
8462 * symtab.c (lookup_global_symbol_from_objfile)
8463 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8464 * objfiles.h (class separate_debug_iterator): New.
8465 (class separate_debug_range): New.
8466 (struct objfile) <separate_debug_objfiles>: New method.
8467 (objfile_separate_debug_iterate): Don't declare.
8468 * objfiles.c (separate_debug_iterator::operator++): Rename from
8469 objfile_separate_debug_iterate.
8470 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8471 iterator.
8472 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8473 iterator.
8474
ee371134
TT
84752019-04-10 Tom Tromey <tom@tromey.com>
8476
8477 * symfile.c (reread_symbols): Remove old comment.
8478 * objfiles.c (free_all_objfiles): Fix a typo.
8479
bf227d61
TT
84802019-04-10 Tom Tromey <tom@tromey.com>
8481
8482 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8483 * minsyms.c (lookup_minimal_symbol): Use foreach.
8484 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8485 (lookup_minimal_symbol_solib_trampoline): Likewise.
8486 * symfile.c (reread_symbols): Use foreach.
8487
8dc433a0
TT
84882019-04-09 Ivan Begert <ivanbegert@gmail.com>
8489 Tom Tromey <tromey@adacore.com>
8490
8491 PR rust/24414:
8492 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8493 (rust_lex_int_test): Change "value" to be LONGEST.
8494 (rust_lex_tests): Add test for long integer literal.
8495
9ab8741a
TT
84962019-04-09 Tom Tromey <tromey@adacore.com>
8497
8498 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8499 to bool.
8500 (extended_remote_target::attach): Update.
8501 (remote_target::remote_notice_new_inferior): Update.
8502 (remote_target::add_current_inferior_and_thread): Update.
8503 * inferior.c (exit_inferior_1): Use "false".
8504 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8505
e242fd12
SM
85062019-04-09 Simon Marchi <simon.marchi@efficios.com>
8507
9ca1957f 8508 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
8509 the "start" command.
8510
2b0c8b01
KB
85112019-04-08 Kevin Buettner <kevinb@redhat.com>
8512
8513 * python/py-inferior.c (infpy_thread_from_thread_handle):
8514 Adjust comments to reflect renaming of thread_from_thread_handle
8515 to thread_from_handle. Adjust keywords. Fix type error message.
8516 (inferior_object_methods): Add thread_from_handle. Retain
8517 thread_from_thread_handle, but mark it as deprecated.
8518
50a82723
KB
85192019-04-08 Kevin Buettner <kevinb@redhat.com>
8520
8521 * gdbthread.h (find_thread_by_handle): Revise declaration.
8522 * thread.c (find_thread_by_handle): Likewise. Adjust
8523 implementation too.
8524 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8525 support for buffer objects as handles.
8526
cf63b016
KB
85272019-04-08 Kevin Buettner <kevinb@redhat.com>
8528
8529 * python/py-infthread.c (thpy_thread_handle): New function.
8530 (thread_object_methods): Register thpy_thread_handle.
8531
3d6c6204
KB
85322019-04-08 Kevin Buettner <kevinb@redhat.com>
8533
8534 * gdbthread.h (thread_to_thread_handle): Declare.
8535 * thread.c (gdbtypes.h): Include.
8536 (thread_to_thread_handle): New function.
8537
8538 * target.h (struct target_ops): Add thread_info_to_thread_handle.
8539 (target_thread_info_to_thread_handle): Declare.
8540 * target.c (target_thread_info_to_thread_handle): New function.
8541 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8542 * target-delegates.c: Regenerate.
8543
8544 * linux-thread-db.c (class thread_db_target): Add method
8545 thread_info_to_thread_handle.
8546 (thread_db_target::thread_info_to_thread_handle): Define.
8547 * remote.c (class remote_target): Add new method
8548 thread_info_to_thread_handle.
8549 (remote_target::thread_info_to_thread_handle): Define.
8550
56be6ea8
PA
85512019-04-08 Pedro Alves <palves@redhat.com>
8552
8553 * common/common-exceptions.c (throw_exception): Don't create
8554 named object to throw; throw directly.
8555 (throw_it): Likewise. Don't initialize gdb_exception::message
8556 here, with new; pass FMT and AP to the ctor instead.
8557 * common/common-exceptions.h: Include <string>.
8558 (gdb_exception::gdb_exception(enum return_reason, enum errors,
8559 const char *, va_list)): New ctor. Use std::make_shared.
8560 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8561 errors)): Delete.
8562 (gdb_exception_error::gdb_exception_error(enum errors, const char
8563 *, va_list)): New.
8564 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8565 Add assertion.
8566 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8567 errors)): Delete.
8568 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8569 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8570 Add assertion.
8571
eedc3f4f
TT
85722019-04-08 Tom Tromey <tom@tromey.com>
8573
8574 * valops.c (value_rtti_indirect_type): Replace throw_exception
8575 with throw.
8576 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8577 with throw.
8578 * thread.c (thr_try_catch_cmd): Replace throw_exception with
8579 throw.
8580 * target.c (target_translate_tls_address): Replace throw_exception
8581 with throw.
8582 * stack.c (frame_apply_command_count): Replace throw_exception
8583 with throw.
8584 * solib-spu.c (append_ocl_sos): Replace throw_exception with
8585 throw.
8586 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8587 with throw.
8588 * rs6000-tdep.c (rs6000_frame_cache)
8589 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8590 * remote.c: Replace throw_exception with throw.
8591 * record-full.c (record_full_message, record_full_wait_1)
8592 (record_full_restore): Replace throw_exception with throw.
8593 * record-btrace.c:
8594 (get_thread_current_frame_id, record_btrace_start_replaying)
8595 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8596 (cmd_record_btrace_start): Replace throw_exception with throw.
8597 * parse.c (parse_exp_in_context_1): Replace throw_exception with
8598 throw.
8599 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8600 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8601 * linespec.c:
8602 (find_linespec_symbols): Replace throw_exception with throw.
8603 * infrun.c (displaced_step_prepare, resume): Replace
8604 throw_exception with throw.
8605 * infcmd.c (post_create_inferior): Replace throw_exception with
8606 throw.
8607 * inf-loop.c (inferior_event_handler): Replace throw_exception
8608 with throw.
8609 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8610 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8611 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8612 (get_prev_frame_always, get_frame_pc_if_available)
8613 (get_frame_address_in_block_if_available, get_frame_language):
8614 Replace throw_exception with throw.
8615 * frame-unwind.c (frame_unwind_try_unwinder): Replace
8616 throw_exception with throw.
8617 * eval.c (fetch_subexp_value, evaluate_var_value)
8618 (evaluate_funcall, evaluate_subexp_standard): Replace
8619 throw_exception with throw.
8620 * dwarf2loc.c (call_site_find_chain)
8621 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8622 Replace throw_exception with throw.
8623 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8624 with throw.
8625 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8626 throw.
8627 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8628 * completer.c (complete_line_internal): Replace throw_exception
8629 with throw.
8630 * compile/compile-object-run.c (compile_object_run): Replace
8631 throw_exception with throw.
8632 * cli/cli-script.c (process_next_line): Replace throw_exception
8633 with throw.
8634 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8635 (btrace_enable, btrace_maint_update_pt_packets): Replace
8636 throw_exception with throw.
8637 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8638 throw_exception with throw.
8639 * break-catch-throw.c (re_set_exception_catchpoint): Replace
8640 throw_exception with throw.
8641 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8642 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8643 * aarch64-tdep.c (aarch64_make_prologue_cache)
8644 (aarch64_make_stub_cache): Replace throw_exception with throw.
8645
26003a20
TT
86462019-04-08 Tom Tromey <tom@tromey.com>
8647
8648 * common/common-exceptions.c (throw_exception): Rename from
8649 throw_exception_cxx. Remove old copy. Make argument const.
8650 (throw_it): Create and throw exception objects directly.
8651 * common/common-exceptions.h (throw_exception): Make argument
8652 const.
8653 (struct gdb_exception_error): Add constructor.
8654 (struct gdb_exception_quit): Add constructor.
8655
d272eb37
TT
86562019-04-08 Tom Tromey <tom@tromey.com>
8657
8658 * common/common-exceptions.h (exception_rethrow): Don't declare.
8659 (TRY_SJLJ): Update comment.
8660 (TRY, CATCH, END_CATCH): Remove.
8661 * common/common-exceptions.c (exception_rethrow): Remove.
8662
230d2906
TT
86632019-04-08 Tom Tromey <tom@tromey.com>
8664
8665 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8666 Remove.
8667 (gdb_exception_error): Rename from
8668 gdb_exception_RETURN_MASK_ERROR.
8669 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8670 (gdb_quit_bad_alloc): Update.
8671 * aarch64-tdep.c: Update.
8672 * ada-lang.c: Update.
8673 * ada-typeprint.c: Update.
8674 * ada-valprint.c: Update.
8675 * amd64-tdep.c: Update.
8676 * arch-utils.c: Update.
8677 * break-catch-throw.c: Update.
8678 * breakpoint.c: Update.
8679 * btrace.c: Update.
8680 * c-varobj.c: Update.
8681 * cli/cli-cmds.c: Update.
8682 * cli/cli-interp.c: Update.
8683 * cli/cli-script.c: Update.
8684 * common/common-exceptions.c: Update.
8685 * common/new-op.c: Update.
8686 * common/selftest.c: Update.
8687 * compile/compile-c-symbols.c: Update.
8688 * compile/compile-cplus-symbols.c: Update.
8689 * compile/compile-object-load.c: Update.
8690 * compile/compile-object-run.c: Update.
8691 * completer.c: Update.
8692 * corelow.c: Update.
8693 * cp-abi.c: Update.
8694 * cp-support.c: Update.
8695 * cp-valprint.c: Update.
8696 * darwin-nat.c: Update.
8697 * disasm-selftests.c: Update.
8698 * dtrace-probe.c: Update.
8699 * dwarf-index-cache.c: Update.
8700 * dwarf-index-write.c: Update.
8701 * dwarf2-frame-tailcall.c: Update.
8702 * dwarf2-frame.c: Update.
8703 * dwarf2loc.c: Update.
8704 * dwarf2read.c: Update.
8705 * eval.c: Update.
8706 * event-loop.c: Update.
8707 * event-top.c: Update.
8708 * exec.c: Update.
8709 * f-valprint.c: Update.
8710 * fbsd-tdep.c: Update.
8711 * frame-unwind.c: Update.
8712 * frame.c: Update.
8713 * gdbtypes.c: Update.
8714 * gnu-v3-abi.c: Update.
8715 * guile/guile-internal.h: Update.
8716 * guile/scm-block.c: Update.
8717 * guile/scm-breakpoint.c: Update.
8718 * guile/scm-cmd.c: Update.
8719 * guile/scm-disasm.c: Update.
8720 * guile/scm-frame.c: Update.
8721 * guile/scm-lazy-string.c: Update.
8722 * guile/scm-math.c: Update.
8723 * guile/scm-param.c: Update.
8724 * guile/scm-ports.c: Update.
8725 * guile/scm-pretty-print.c: Update.
8726 * guile/scm-symbol.c: Update.
8727 * guile/scm-symtab.c: Update.
8728 * guile/scm-type.c: Update.
8729 * guile/scm-value.c: Update.
8730 * i386-linux-tdep.c: Update.
8731 * i386-tdep.c: Update.
8732 * inf-loop.c: Update.
8733 * infcall.c: Update.
8734 * infcmd.c: Update.
8735 * infrun.c: Update.
8736 * jit.c: Update.
8737 * language.c: Update.
8738 * linespec.c: Update.
8739 * linux-fork.c: Update.
8740 * linux-nat.c: Update.
8741 * linux-tdep.c: Update.
8742 * linux-thread-db.c: Update.
8743 * main.c: Update.
8744 * mi/mi-cmd-break.c: Update.
8745 * mi/mi-cmd-stack.c: Update.
8746 * mi/mi-interp.c: Update.
8747 * mi/mi-main.c: Update.
8748 * objc-lang.c: Update.
8749 * p-valprint.c: Update.
8750 * parse.c: Update.
8751 * ppc-linux-tdep.c: Update.
8752 * printcmd.c: Update.
8753 * python/py-arch.c: Update.
8754 * python/py-breakpoint.c: Update.
8755 * python/py-cmd.c: Update.
8756 * python/py-finishbreakpoint.c: Update.
8757 * python/py-frame.c: Update.
8758 * python/py-framefilter.c: Update.
8759 * python/py-gdb-readline.c: Update.
8760 * python/py-inferior.c: Update.
8761 * python/py-infthread.c: Update.
8762 * python/py-lazy-string.c: Update.
8763 * python/py-linetable.c: Update.
8764 * python/py-objfile.c: Update.
8765 * python/py-param.c: Update.
8766 * python/py-prettyprint.c: Update.
8767 * python/py-progspace.c: Update.
8768 * python/py-record-btrace.c: Update.
8769 * python/py-record.c: Update.
8770 * python/py-symbol.c: Update.
8771 * python/py-type.c: Update.
8772 * python/py-unwind.c: Update.
8773 * python/py-utils.c: Update.
8774 * python/py-value.c: Update.
8775 * python/python.c: Update.
8776 * record-btrace.c: Update.
8777 * record-full.c: Update.
8778 * remote-fileio.c: Update.
8779 * remote.c: Update.
8780 * riscv-tdep.c: Update.
8781 * rs6000-aix-tdep.c: Update.
8782 * rs6000-tdep.c: Update.
8783 * rust-exp.y: Update.
8784 * rust-lang.c: Update.
8785 * s390-tdep.c: Update.
8786 * selftest-arch.c: Update.
8787 * solib-dsbt.c: Update.
8788 * solib-frv.c: Update.
8789 * solib-spu.c: Update.
8790 * solib-svr4.c: Update.
8791 * solib.c: Update.
8792 * sparc64-linux-tdep.c: Update.
8793 * stack.c: Update.
8794 * symfile-mem.c: Update.
8795 * symmisc.c: Update.
8796 * target.c: Update.
8797 * thread.c: Update.
8798 * top.c: Update.
8799 * tracefile-tfile.c: Update.
8800 * tui/tui.c: Update.
8801 * typeprint.c: Update.
8802 * unittests/cli-utils-selftests.c: Update.
8803 * unittests/parse-connection-spec-selftests.c: Update.
8804 * valops.c: Update.
8805 * valprint.c: Update.
8806 * value.c: Update.
8807 * varobj.c: Update.
8808 * windows-nat.c: Update.
8809 * x86-linux-nat.c: Update.
8810 * xml-support.c: Update.
8811
a70b8144
TT
88122019-04-08 Tom Tromey <tom@tromey.com>
8813
8814 * xml-support.c: Use C++ exception handling.
8815 * x86-linux-nat.c: Use C++ exception handling.
8816 * windows-nat.c: Use C++ exception handling.
8817 * varobj.c: Use C++ exception handling.
8818 * value.c: Use C++ exception handling.
8819 * valprint.c: Use C++ exception handling.
8820 * valops.c: Use C++ exception handling.
8821 * unittests/parse-connection-spec-selftests.c: Use C++ exception
8822 handling.
8823 * unittests/cli-utils-selftests.c: Use C++ exception handling.
8824 * typeprint.c: Use C++ exception handling.
8825 * tui/tui.c: Use C++ exception handling.
8826 * tracefile-tfile.c: Use C++ exception handling.
8827 * top.c: Use C++ exception handling.
8828 * thread.c: Use C++ exception handling.
8829 * target.c: Use C++ exception handling.
8830 * symmisc.c: Use C++ exception handling.
8831 * symfile-mem.c: Use C++ exception handling.
8832 * stack.c: Use C++ exception handling.
8833 * sparc64-linux-tdep.c: Use C++ exception handling.
8834 * solib.c: Use C++ exception handling.
8835 * solib-svr4.c: Use C++ exception handling.
8836 * solib-spu.c: Use C++ exception handling.
8837 * solib-frv.c: Use C++ exception handling.
8838 * solib-dsbt.c: Use C++ exception handling.
8839 * selftest-arch.c: Use C++ exception handling.
8840 * s390-tdep.c: Use C++ exception handling.
8841 * rust-lang.c: Use C++ exception handling.
8842 * rust-exp.y: Use C++ exception handling.
8843 * rs6000-tdep.c: Use C++ exception handling.
8844 * rs6000-aix-tdep.c: Use C++ exception handling.
8845 * riscv-tdep.c: Use C++ exception handling.
8846 * remote.c: Use C++ exception handling.
8847 * remote-fileio.c: Use C++ exception handling.
8848 * record-full.c: Use C++ exception handling.
8849 * record-btrace.c: Use C++ exception handling.
8850 * python/python.c: Use C++ exception handling.
8851 * python/py-value.c: Use C++ exception handling.
8852 * python/py-utils.c: Use C++ exception handling.
8853 * python/py-unwind.c: Use C++ exception handling.
8854 * python/py-type.c: Use C++ exception handling.
8855 * python/py-symbol.c: Use C++ exception handling.
8856 * python/py-record.c: Use C++ exception handling.
8857 * python/py-record-btrace.c: Use C++ exception handling.
8858 * python/py-progspace.c: Use C++ exception handling.
8859 * python/py-prettyprint.c: Use C++ exception handling.
8860 * python/py-param.c: Use C++ exception handling.
8861 * python/py-objfile.c: Use C++ exception handling.
8862 * python/py-linetable.c: Use C++ exception handling.
8863 * python/py-lazy-string.c: Use C++ exception handling.
8864 * python/py-infthread.c: Use C++ exception handling.
8865 * python/py-inferior.c: Use C++ exception handling.
8866 * python/py-gdb-readline.c: Use C++ exception handling.
8867 * python/py-framefilter.c: Use C++ exception handling.
8868 * python/py-frame.c: Use C++ exception handling.
8869 * python/py-finishbreakpoint.c: Use C++ exception handling.
8870 * python/py-cmd.c: Use C++ exception handling.
8871 * python/py-breakpoint.c: Use C++ exception handling.
8872 * python/py-arch.c: Use C++ exception handling.
8873 * printcmd.c: Use C++ exception handling.
8874 * ppc-linux-tdep.c: Use C++ exception handling.
8875 * parse.c: Use C++ exception handling.
8876 * p-valprint.c: Use C++ exception handling.
8877 * objc-lang.c: Use C++ exception handling.
8878 * mi/mi-main.c: Use C++ exception handling.
8879 * mi/mi-interp.c: Use C++ exception handling.
8880 * mi/mi-cmd-stack.c: Use C++ exception handling.
8881 * mi/mi-cmd-break.c: Use C++ exception handling.
8882 * main.c: Use C++ exception handling.
8883 * linux-thread-db.c: Use C++ exception handling.
8884 * linux-tdep.c: Use C++ exception handling.
8885 * linux-nat.c: Use C++ exception handling.
8886 * linux-fork.c: Use C++ exception handling.
8887 * linespec.c: Use C++ exception handling.
8888 * language.c: Use C++ exception handling.
8889 * jit.c: Use C++ exception handling.
8890 * infrun.c: Use C++ exception handling.
8891 * infcmd.c: Use C++ exception handling.
8892 * infcall.c: Use C++ exception handling.
8893 * inf-loop.c: Use C++ exception handling.
8894 * i386-tdep.c: Use C++ exception handling.
8895 * i386-linux-tdep.c: Use C++ exception handling.
8896 * guile/scm-value.c: Use C++ exception handling.
8897 * guile/scm-type.c: Use C++ exception handling.
8898 * guile/scm-symtab.c: Use C++ exception handling.
8899 * guile/scm-symbol.c: Use C++ exception handling.
8900 * guile/scm-pretty-print.c: Use C++ exception handling.
8901 * guile/scm-ports.c: Use C++ exception handling.
8902 * guile/scm-param.c: Use C++ exception handling.
8903 * guile/scm-math.c: Use C++ exception handling.
8904 * guile/scm-lazy-string.c: Use C++ exception handling.
8905 * guile/scm-frame.c: Use C++ exception handling.
8906 * guile/scm-disasm.c: Use C++ exception handling.
8907 * guile/scm-cmd.c: Use C++ exception handling.
8908 * guile/scm-breakpoint.c: Use C++ exception handling.
8909 * guile/scm-block.c: Use C++ exception handling.
8910 * guile/guile-internal.h: Use C++ exception handling.
8911 * gnu-v3-abi.c: Use C++ exception handling.
8912 * gdbtypes.c: Use C++ exception handling.
8913 * frame.c: Use C++ exception handling.
8914 * frame-unwind.c: Use C++ exception handling.
8915 * fbsd-tdep.c: Use C++ exception handling.
8916 * f-valprint.c: Use C++ exception handling.
8917 * exec.c: Use C++ exception handling.
8918 * event-top.c: Use C++ exception handling.
8919 * event-loop.c: Use C++ exception handling.
8920 * eval.c: Use C++ exception handling.
8921 * dwarf2read.c: Use C++ exception handling.
8922 * dwarf2loc.c: Use C++ exception handling.
8923 * dwarf2-frame.c: Use C++ exception handling.
8924 * dwarf2-frame-tailcall.c: Use C++ exception handling.
8925 * dwarf-index-write.c: Use C++ exception handling.
8926 * dwarf-index-cache.c: Use C++ exception handling.
8927 * dtrace-probe.c: Use C++ exception handling.
8928 * disasm-selftests.c: Use C++ exception handling.
8929 * darwin-nat.c: Use C++ exception handling.
8930 * cp-valprint.c: Use C++ exception handling.
8931 * cp-support.c: Use C++ exception handling.
8932 * cp-abi.c: Use C++ exception handling.
8933 * corelow.c: Use C++ exception handling.
8934 * completer.c: Use C++ exception handling.
8935 * compile/compile-object-run.c: Use C++ exception handling.
8936 * compile/compile-object-load.c: Use C++ exception handling.
8937 * compile/compile-cplus-symbols.c: Use C++ exception handling.
8938 * compile/compile-c-symbols.c: Use C++ exception handling.
8939 * common/selftest.c: Use C++ exception handling.
8940 * common/new-op.c: Use C++ exception handling.
8941 * cli/cli-script.c: Use C++ exception handling.
8942 * cli/cli-interp.c: Use C++ exception handling.
8943 * cli/cli-cmds.c: Use C++ exception handling.
8944 * c-varobj.c: Use C++ exception handling.
8945 * btrace.c: Use C++ exception handling.
8946 * breakpoint.c: Use C++ exception handling.
8947 * break-catch-throw.c: Use C++ exception handling.
8948 * arch-utils.c: Use C++ exception handling.
8949 * amd64-tdep.c: Use C++ exception handling.
8950 * ada-valprint.c: Use C++ exception handling.
8951 * ada-typeprint.c: Use C++ exception handling.
8952 * ada-lang.c: Use C++ exception handling.
8953 * aarch64-tdep.c: Use C++ exception handling.
8954
3d6e9d23
TT
89552019-04-08 Tom Tromey <tom@tromey.com>
8956
8957 * xml-support.c (gdb_xml_parser::parse): Update.
8958 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8959 * value.c (show_convenience): Update.
8960 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8961 (test_parse_flags_qcs): Update.
8962 * thread.c (thr_try_catch_cmd): Update.
8963 * target.c (target_translate_tls_address): Update.
8964 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8965 (info_frame_command_core, frame_apply_command_count): Update.
8966 * rust-exp.y (rust_lex_exception_test): Update.
8967 * riscv-tdep.c (riscv_print_one_register_info): Update.
8968 * remote.c (remote_target::enable_btrace): Update.
8969 * record-btrace.c (record_btrace_enable_warn): Update.
8970 * python/py-utils.c (gdbpy_convert_exception): Update.
8971 * printcmd.c (do_one_display, print_variable_and_value): Update.
8972 * mi/mi-main.c (mi_print_exception): Update.
8973 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8974 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8975 * linux-nat.c (linux_nat_target::attach): Update.
8976 * linux-fork.c (class scoped_switch_fork_info): Update.
8977 * infrun.c (displaced_step_prepare): Update.
8978 * infcall.c (call_function_by_hand_dummy): Update.
8979 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8980 * gnu-v3-abi.c (print_one_vtable): Update.
8981 * frame.c (get_prev_frame_always): Update.
8982 * f-valprint.c (info_common_command_for_block): Update.
8983 * exec.c (try_open_exec_file): Update.
8984 * exceptions.c (print_exception, exception_print)
8985 (exception_fprintf, exception_print_same): Update.
8986 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8987 * dwarf-index-cache.c (index_cache::store)
8988 (index_cache::lookup_gdb_index): Update.
8989 * darwin-nat.c (maybe_cache_shell): Update.
8990 * cp-valprint.c (cp_print_value_fields): Update.
8991 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8992 (gcc_cplus_symbol_address): Update.
8993 * compile/compile-c-symbols.c (gcc_convert_symbol)
8994 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8995 * common/selftest.c: Update.
8996 * common/common-exceptions.h (struct gdb_exception) <message>: Now
8997 a std::string.
8998 (exception_try_scope_entry, exception_try_scope_exit): Don't
8999 declare.
9000 (struct exception_try_scope): Remove.
9001 (TRY): Don't use exception_try_scope.
9002 (struct gdb_exception): Add constructor, operator=.
9003 <what>: New method.
9004 (struct gdb_exception_RETURN_MASK_ALL)
9005 (struct gdb_exception_RETURN_MASK_ERROR)
9006 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9007 (struct gdb_quit_bad_alloc): Update.
9008 * common/common-exceptions.c (exception_none): Change
9009 initializer.
9010 (struct catcher) <state, exception>: Initialize inline.
9011 <prev>: Remove member.
9012 (current_catcher): Remove.
9013 (catchers): New global.
9014 (exceptions_state_mc_init): Simplify.
9015 (catcher_pop): Remove.
9016 (exceptions_state_mc, exceptions_state_mc_catch): Update.
9017 (try_scope_depth, exception_try_scope_entry)
9018 (exception_try_scope_exit): Remove.
9019 (throw_exception_sjlj): Update.
9020 (exception_messages, exception_messages_size): Remove.
9021 (throw_it): Simplify.
9022 (gdb_exception_sliced_copy): Remove.
9023 (throw_exception_cxx): Update.
9024 * cli/cli-script.c (script_from_file): Update.
9025 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9026 Update.
9027 * ada-valprint.c (ada_val_print): Update.
9028 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9029 (create_excep_cond_exprs): Update.
9030
c5c10118
TT
90312019-04-08 Tom Tromey <tom@tromey.com>
9032
9033 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9034 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9035 (TRY, CATCH, END_CATCH): Remove some definitions.
9036 * common/common-exceptions.c: Don't use GDB_XCPT.
9037 (catcher_list_size): Remove.
9038 (throw_exception, throw_it): Simplify.
9039
4de283e4
TT
90402019-04-05 Tom Tromey <tom@tromey.com>
9041
9042 Revert the header-sorting patch.
9043 * ft32-tdep.c: Revert.
9044 * frv-tdep.c: Revert.
9045 * frv-linux-tdep.c: Revert.
9046 * frame.c: Revert.
9047 * frame-unwind.c: Revert.
9048 * frame-base.c: Revert.
9049 * fork-child.c: Revert.
9050 * findvar.c: Revert.
9051 * findcmd.c: Revert.
9052 * filesystem.c: Revert.
9053 * filename-seen-cache.h: Revert.
9054 * filename-seen-cache.c: Revert.
9055 * fbsd-tdep.c: Revert.
9056 * fbsd-nat.h: Revert.
9057 * fbsd-nat.c: Revert.
9058 * f-valprint.c: Revert.
9059 * f-typeprint.c: Revert.
9060 * f-lang.c: Revert.
9061 * extension.h: Revert.
9062 * extension.c: Revert.
9063 * extension-priv.h: Revert.
9064 * expprint.c: Revert.
9065 * exec.h: Revert.
9066 * exec.c: Revert.
9067 * exceptions.c: Revert.
9068 * event-top.c: Revert.
9069 * event-loop.c: Revert.
9070 * eval.c: Revert.
9071 * elfread.c: Revert.
9072 * dwarf2read.h: Revert.
9073 * dwarf2read.c: Revert.
9074 * dwarf2loc.c: Revert.
9075 * dwarf2expr.h: Revert.
9076 * dwarf2expr.c: Revert.
9077 * dwarf2-frame.c: Revert.
9078 * dwarf2-frame-tailcall.c: Revert.
9079 * dwarf-index-write.h: Revert.
9080 * dwarf-index-write.c: Revert.
9081 * dwarf-index-common.c: Revert.
9082 * dwarf-index-cache.h: Revert.
9083 * dwarf-index-cache.c: Revert.
9084 * dummy-frame.c: Revert.
9085 * dtrace-probe.c: Revert.
9086 * disasm.h: Revert.
9087 * disasm.c: Revert.
9088 * disasm-selftests.c: Revert.
9089 * dictionary.c: Revert.
9090 * dicos-tdep.c: Revert.
9091 * demangle.c: Revert.
9092 * dcache.h: Revert.
9093 * dcache.c: Revert.
9094 * darwin-nat.h: Revert.
9095 * darwin-nat.c: Revert.
9096 * darwin-nat-info.c: Revert.
9097 * d-valprint.c: Revert.
9098 * d-namespace.c: Revert.
9099 * d-lang.c: Revert.
9100 * ctf.c: Revert.
9101 * csky-tdep.c: Revert.
9102 * csky-linux-tdep.c: Revert.
9103 * cris-tdep.c: Revert.
9104 * cris-linux-tdep.c: Revert.
9105 * cp-valprint.c: Revert.
9106 * cp-support.c: Revert.
9107 * cp-namespace.c: Revert.
9108 * cp-abi.c: Revert.
9109 * corelow.c: Revert.
9110 * corefile.c: Revert.
9111 * continuations.c: Revert.
9112 * completer.h: Revert.
9113 * completer.c: Revert.
9114 * complaints.c: Revert.
9115 * coffread.c: Revert.
9116 * coff-pe-read.c: Revert.
9117 * cli-out.h: Revert.
9118 * cli-out.c: Revert.
9119 * charset.c: Revert.
9120 * c-varobj.c: Revert.
9121 * c-valprint.c: Revert.
9122 * c-typeprint.c: Revert.
9123 * c-lang.c: Revert.
9124 * buildsym.c: Revert.
9125 * buildsym-legacy.c: Revert.
9126 * build-id.h: Revert.
9127 * build-id.c: Revert.
9128 * btrace.c: Revert.
9129 * bsd-uthread.c: Revert.
9130 * breakpoint.h: Revert.
9131 * breakpoint.c: Revert.
9132 * break-catch-throw.c: Revert.
9133 * break-catch-syscall.c: Revert.
9134 * break-catch-sig.c: Revert.
9135 * blockframe.c: Revert.
9136 * block.c: Revert.
9137 * bfin-tdep.c: Revert.
9138 * bfin-linux-tdep.c: Revert.
9139 * bfd-target.c: Revert.
9140 * bcache.c: Revert.
9141 * ax-general.c: Revert.
9142 * ax-gdb.h: Revert.
9143 * ax-gdb.c: Revert.
9144 * avr-tdep.c: Revert.
9145 * auxv.c: Revert.
9146 * auto-load.c: Revert.
9147 * arm-wince-tdep.c: Revert.
9148 * arm-tdep.c: Revert.
9149 * arm-symbian-tdep.c: Revert.
9150 * arm-pikeos-tdep.c: Revert.
9151 * arm-obsd-tdep.c: Revert.
9152 * arm-nbsd-tdep.c: Revert.
9153 * arm-nbsd-nat.c: Revert.
9154 * arm-linux-tdep.c: Revert.
9155 * arm-linux-nat.c: Revert.
9156 * arm-fbsd-tdep.c: Revert.
9157 * arm-fbsd-nat.c: Revert.
9158 * arm-bsd-tdep.c: Revert.
9159 * arch-utils.c: Revert.
9160 * arc-tdep.c: Revert.
9161 * arc-newlib-tdep.c: Revert.
9162 * annotate.h: Revert.
9163 * annotate.c: Revert.
9164 * amd64-windows-tdep.c: Revert.
9165 * amd64-windows-nat.c: Revert.
9166 * amd64-tdep.c: Revert.
9167 * amd64-sol2-tdep.c: Revert.
9168 * amd64-obsd-tdep.c: Revert.
9169 * amd64-obsd-nat.c: Revert.
9170 * amd64-nbsd-tdep.c: Revert.
9171 * amd64-nbsd-nat.c: Revert.
9172 * amd64-nat.c: Revert.
9173 * amd64-linux-tdep.c: Revert.
9174 * amd64-linux-nat.c: Revert.
9175 * amd64-fbsd-tdep.c: Revert.
9176 * amd64-fbsd-nat.c: Revert.
9177 * amd64-dicos-tdep.c: Revert.
9178 * amd64-darwin-tdep.c: Revert.
9179 * amd64-bsd-nat.c: Revert.
9180 * alpha-tdep.c: Revert.
9181 * alpha-obsd-tdep.c: Revert.
9182 * alpha-nbsd-tdep.c: Revert.
9183 * alpha-mdebug-tdep.c: Revert.
9184 * alpha-linux-tdep.c: Revert.
9185 * alpha-linux-nat.c: Revert.
9186 * alpha-bsd-tdep.c: Revert.
9187 * alpha-bsd-nat.c: Revert.
9188 * aix-thread.c: Revert.
9189 * agent.c: Revert.
9190 * addrmap.c: Revert.
9191 * ada-varobj.c: Revert.
9192 * ada-valprint.c: Revert.
9193 * ada-typeprint.c: Revert.
9194 * ada-tasks.c: Revert.
9195 * ada-lang.c: Revert.
9196 * aarch64-tdep.c: Revert.
9197 * aarch64-ravenscar-thread.c: Revert.
9198 * aarch64-newlib-tdep.c: Revert.
9199 * aarch64-linux-tdep.c: Revert.
9200 * aarch64-linux-nat.c: Revert.
9201 * aarch64-fbsd-tdep.c: Revert.
9202 * aarch64-fbsd-nat.c: Revert.
9203 * aarch32-linux-nat.c: Revert.
9204
d55e5aa6
TT
92052019-04-05 Tom Tromey <tom@tromey.com>
9206
9207 * ft32-tdep.c: Sort headers.
9208 * frv-tdep.c: Sort headers.
9209 * frv-linux-tdep.c: Sort headers.
9210 * frame.c: Sort headers.
9211 * frame-unwind.c: Sort headers.
9212 * frame-base.c: Sort headers.
9213 * fork-child.c: Sort headers.
9214 * findvar.c: Sort headers.
9215 * findcmd.c: Sort headers.
9216 * filesystem.c: Sort headers.
9217 * filename-seen-cache.h: Sort headers.
9218 * filename-seen-cache.c: Sort headers.
9219 * fbsd-tdep.c: Sort headers.
9220 * fbsd-nat.h: Sort headers.
9221 * fbsd-nat.c: Sort headers.
9222 * f-valprint.c: Sort headers.
9223 * f-typeprint.c: Sort headers.
9224 * f-lang.c: Sort headers.
9225 * extension.h: Sort headers.
9226 * extension.c: Sort headers.
9227 * extension-priv.h: Sort headers.
9228 * expprint.c: Sort headers.
9229 * exec.h: Sort headers.
9230 * exec.c: Sort headers.
9231 * exceptions.c: Sort headers.
9232 * event-top.c: Sort headers.
9233 * event-loop.c: Sort headers.
9234 * eval.c: Sort headers.
9235 * elfread.c: Sort headers.
9236 * dwarf2read.h: Sort headers.
9237 * dwarf2read.c: Sort headers.
9238 * dwarf2loc.c: Sort headers.
9239 * dwarf2expr.h: Sort headers.
9240 * dwarf2expr.c: Sort headers.
9241 * dwarf2-frame.c: Sort headers.
9242 * dwarf2-frame-tailcall.c: Sort headers.
9243 * dwarf-index-write.h: Sort headers.
9244 * dwarf-index-write.c: Sort headers.
9245 * dwarf-index-common.c: Sort headers.
9246 * dwarf-index-cache.h: Sort headers.
9247 * dwarf-index-cache.c: Sort headers.
9248 * dummy-frame.c: Sort headers.
9249 * dtrace-probe.c: Sort headers.
9250 * disasm.h: Sort headers.
9251 * disasm.c: Sort headers.
9252 * disasm-selftests.c: Sort headers.
9253 * dictionary.c: Sort headers.
9254 * dicos-tdep.c: Sort headers.
9255 * demangle.c: Sort headers.
9256 * dcache.h: Sort headers.
9257 * dcache.c: Sort headers.
9258 * darwin-nat.h: Sort headers.
9259 * darwin-nat.c: Sort headers.
9260 * darwin-nat-info.c: Sort headers.
9261 * d-valprint.c: Sort headers.
9262 * d-namespace.c: Sort headers.
9263 * d-lang.c: Sort headers.
9264 * ctf.c: Sort headers.
9265 * csky-tdep.c: Sort headers.
9266 * csky-linux-tdep.c: Sort headers.
9267 * cris-tdep.c: Sort headers.
9268 * cris-linux-tdep.c: Sort headers.
9269 * cp-valprint.c: Sort headers.
9270 * cp-support.c: Sort headers.
9271 * cp-namespace.c: Sort headers.
9272 * cp-abi.c: Sort headers.
9273 * corelow.c: Sort headers.
9274 * corefile.c: Sort headers.
9275 * continuations.c: Sort headers.
9276 * completer.h: Sort headers.
9277 * completer.c: Sort headers.
9278 * complaints.c: Sort headers.
9279 * coffread.c: Sort headers.
9280 * coff-pe-read.c: Sort headers.
9281 * cli-out.h: Sort headers.
9282 * cli-out.c: Sort headers.
9283 * charset.c: Sort headers.
9284 * c-varobj.c: Sort headers.
9285 * c-valprint.c: Sort headers.
9286 * c-typeprint.c: Sort headers.
9287 * c-lang.c: Sort headers.
9288 * buildsym.c: Sort headers.
9289 * buildsym-legacy.c: Sort headers.
9290 * build-id.h: Sort headers.
9291 * build-id.c: Sort headers.
9292 * btrace.c: Sort headers.
9293 * bsd-uthread.c: Sort headers.
9294 * breakpoint.h: Sort headers.
9295 * breakpoint.c: Sort headers.
9296 * break-catch-throw.c: Sort headers.
9297 * break-catch-syscall.c: Sort headers.
9298 * break-catch-sig.c: Sort headers.
9299 * blockframe.c: Sort headers.
9300 * block.c: Sort headers.
9301 * bfin-tdep.c: Sort headers.
9302 * bfin-linux-tdep.c: Sort headers.
9303 * bfd-target.c: Sort headers.
9304 * bcache.c: Sort headers.
9305 * ax-general.c: Sort headers.
9306 * ax-gdb.h: Sort headers.
9307 * ax-gdb.c: Sort headers.
9308 * avr-tdep.c: Sort headers.
9309 * auxv.c: Sort headers.
9310 * auto-load.c: Sort headers.
9311 * arm-wince-tdep.c: Sort headers.
9312 * arm-tdep.c: Sort headers.
9313 * arm-symbian-tdep.c: Sort headers.
9314 * arm-pikeos-tdep.c: Sort headers.
9315 * arm-obsd-tdep.c: Sort headers.
9316 * arm-nbsd-tdep.c: Sort headers.
9317 * arm-nbsd-nat.c: Sort headers.
9318 * arm-linux-tdep.c: Sort headers.
9319 * arm-linux-nat.c: Sort headers.
9320 * arm-fbsd-tdep.c: Sort headers.
9321 * arm-fbsd-nat.c: Sort headers.
9322 * arm-bsd-tdep.c: Sort headers.
9323 * arch-utils.c: Sort headers.
9324 * arc-tdep.c: Sort headers.
9325 * arc-newlib-tdep.c: Sort headers.
9326 * annotate.h: Sort headers.
9327 * annotate.c: Sort headers.
9328 * amd64-windows-tdep.c: Sort headers.
9329 * amd64-windows-nat.c: Sort headers.
9330 * amd64-tdep.c: Sort headers.
9331 * amd64-sol2-tdep.c: Sort headers.
9332 * amd64-obsd-tdep.c: Sort headers.
9333 * amd64-obsd-nat.c: Sort headers.
9334 * amd64-nbsd-tdep.c: Sort headers.
9335 * amd64-nbsd-nat.c: Sort headers.
9336 * amd64-nat.c: Sort headers.
9337 * amd64-linux-tdep.c: Sort headers.
9338 * amd64-linux-nat.c: Sort headers.
9339 * amd64-fbsd-tdep.c: Sort headers.
9340 * amd64-fbsd-nat.c: Sort headers.
9341 * amd64-dicos-tdep.c: Sort headers.
9342 * amd64-darwin-tdep.c: Sort headers.
9343 * amd64-bsd-nat.c: Sort headers.
9344 * alpha-tdep.c: Sort headers.
9345 * alpha-obsd-tdep.c: Sort headers.
9346 * alpha-nbsd-tdep.c: Sort headers.
9347 * alpha-mdebug-tdep.c: Sort headers.
9348 * alpha-linux-tdep.c: Sort headers.
9349 * alpha-linux-nat.c: Sort headers.
9350 * alpha-bsd-tdep.c: Sort headers.
9351 * alpha-bsd-nat.c: Sort headers.
9352 * aix-thread.c: Sort headers.
9353 * agent.c: Sort headers.
9354 * addrmap.c: Sort headers.
9355 * ada-varobj.c: Sort headers.
9356 * ada-valprint.c: Sort headers.
9357 * ada-typeprint.c: Sort headers.
9358 * ada-tasks.c: Sort headers.
9359 * ada-lang.c: Sort headers.
9360 * aarch64-tdep.c: Sort headers.
9361 * aarch64-ravenscar-thread.c: Sort headers.
9362 * aarch64-newlib-tdep.c: Sort headers.
9363 * aarch64-linux-tdep.c: Sort headers.
9364 * aarch64-linux-nat.c: Sort headers.
9365 * aarch64-fbsd-tdep.c: Sort headers.
9366 * aarch64-fbsd-nat.c: Sort headers.
9367 * aarch32-linux-nat.c: Sort headers.
9368
699bd4cf
TT
93692019-04-04 Tom Tromey <tom@tromey.com>
9370
9371 * varobj.c (varobj_create): Update.
9372 * rust-exp.y (struct rust_parser) <update_innermost_block,
9373 lookup_symbol>: New methods.
9374 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9375 Rename.
9376 (rust_parser::rust_lookup_type)
9377 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9378 * printcmd.c (display_command, do_one_display): Update.
9379 * parser-defs.h (struct parser_state) <parser_state>: Add
9380 "tracker" parameter.
9381 (block_tracker): New member.
9382 (class innermost_block_tracker) <innermost_block_tracker>: Add
9383 "types" parameter.
9384 <reset>: Remove method.
9385 (innermost_block): Don't declare.
9386 (null_post_parser): Update.
9387 * parse.c (innermost_block): Remove global.
9388 (write_dollar_variable): Update.
9389 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9390 Remove "tracker_types" parameter.
9391 (parse_expression): Add "tracker" parameter.
9392 (parse_expression_for_completion): Update.
9393 (null_post_parser): Add "tracker" parameter.
9394 * p-exp.y: Update rules.
9395 * m2-exp.y: Update rules.
9396 * language.h (struct language_defn) <la_post_parser>: Add
9397 "tracker" parameter.
9398 * go-exp.y: Update rules.
9399 * f-exp.y: Update rules.
9400 * expression.h (parse_expression, parse_exp_1): Add "tracker"
9401 parameter.
9402 * d-exp.y: Update rules.
9403 * c-exp.y: Update rules.
9404 * breakpoint.c (set_breakpoint_condition): Create an
9405 innermost_block_tracker.
9406 (watch_command_1): Likewise.
9407 * ada-lang.c (resolve): Add "tracker" parameter.
9408 (resolve_subexp): Likewise.
9409 * ada-exp.y (write_var_from_sym): Update.
9410
dac43e32
TT
94112019-04-04 Tom Tromey <tom@tromey.com>
9412
9413 * type-stack.h: New file.
9414 * type-stack.c: New file.
9415 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9416 type-stack.h.
9417 (insert_into_type_stack, insert_type, push_type, push_type_int)
9418 (insert_type_address_space, pop_type, pop_type_int)
9419 (pop_typelist, pop_type_stack, append_type_stack)
9420 (push_type_stack, get_type_stack, push_typelist)
9421 (follow_type_instance_flags, follow_types): Don't declare.
9422 * parse.c (type_stack): Remove global.
9423 (parse_exp_in_context): Update.
9424 (insert_into_type_stack, insert_type, push_type, push_type_int)
9425 (insert_type_address_space, pop_type, pop_type_int)
9426 (pop_typelist, pop_type_stack, append_type_stack)
9427 (push_type_stack, get_type_stack, push_typelist)
9428 (follow_type_instance_flags, follow_types): Remove (moved to
9429 type-stack.c).
9430 * f-exp.y (type_stack): New global.
9431 Update rules.
9432 (push_kind_type, f_parse): Update.
9433 * d-exp.y (type_stack): New global.
9434 Update rules.
9435 (d_parse): Update.
9436 * c-exp.y (struct c_parse_state) <type_stack>: New member.
9437 Update rules.
9438 * Makefile.in (COMMON_SFILES): Add type-stack.c.
9439 (HFILES_NO_SRCDIR): Add type-stack.h.
9440
2a612529
TT
94412019-04-04 Tom Tromey <tom@tromey.com>
9442
9443 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9444 (rust_parser::convert_ast_to_expression, rust_parse)
9445 (rust_lex_test_completion, rust_lex_tests): Update.
9446 * parser-defs.h (struct expr_completion_state): New.
9447 (struct parser_state) <parser_state>: Add completion parameter.
9448 <mark_struct_expression, mark_completion_tag>: New methods.
9449 <parse_completion, m_completion_state>: New members.
9450 (prefixify_expression, null_post_parser): Update.
9451 (mark_struct_expression, mark_completion_tag): Don't declare.
9452 * parse.c (parse_completion, expout_last_struct)
9453 (expout_tag_completion_type, expout_completion_name): Remove
9454 globals.
9455 (parser_state::mark_struct_expression)
9456 (parser_state::mark_completion_tag): Now methods.
9457 (prefixify_expression): Add last_struct parameter.
9458 (prefixify_subexp): Likewise.
9459 (parse_exp_1): Update.
9460 (parse_exp_in_context): Add cstate parameter. Update.
9461 (parse_expression_for_completion): Create an
9462 expr_completion_state.
9463 (null_post_parser): Add "completion" parameter.
9464 * p-exp.y: Update rules.
9465 (yylex): Update.
9466 * language.h (struct language_defn) <la_post_parser>: Add
9467 "completing" parameter.
9468 * go-exp.y: Update rules.
9469 (lex_one_token): Update.
9470 * expression.h (parse_completion): Don't declare.
9471 * d-exp.y: Update rules.
9472 (lex_one_token): Update rules.
9473 * c-exp.y: Update rules.
9474 (lex_one_token): Update.
9475 * ada-lang.c (resolve): Add "parse_completion" parameter.
9476 (resolve_subexp): Likewise.
9477 (ada_resolve_function): Likewise.
9478
43476f0b
TT
94792019-04-04 Tom Tromey <tom@tromey.com>
9480
9481 * parser-defs.h (struct parser_state) <start_arglist,
9482 end_arglist>: New methods.
9483 <arglist_len, m_funcall_chain>: New members.
9484 (arglist_len, start_arglist, end_arglist): Don't declare.
9485 * parse.c (arglist_len, funcall_chain): Remove global.
9486 (start_arglist, end_arglist): Remove functions.
9487 (parse_exp_in_context): Update.
9488 * p-exp.y: Update rules.
9489 * m2-exp.y: Update rules.
9490 * go-exp.y: Update rules.
9491 * f-exp.y: Update rules.
9492 * d-exp.y: Update rules.
9493 * c-exp.y: Update rules.
9494
5776fca3
TT
94952019-04-04 Tom Tromey <tom@tromey.com>
9496
9497 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9498 lex_operator, push_back>: New methods.
9499 Update all rules.
9500 (rust_parser::lex_hex, lex_escape): Rename and update.
9501 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9502 (rust_parser::lex_operator): Rename and update.
9503 (rust_parser::lex_number, rustyylex, rustyyerror)
9504 (rust_lex_test_init, rust_lex_test_sequence)
9505 (rust_lex_test_push_back, rust_lex_tests): Update.
9506 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9507 parameter.
9508 <lexptr, prev_lexptr>: New members.
9509 (lexptr, prev_lexptr): Don't declare.
9510 * parse.c (lexptr, prev_lexptr): Remove globals.
9511 (parse_exp_in_context): Update.
9512 * p-exp.y (yylex, yyerror): Update.
9513 * m2-exp.y (parse_number, yylex, yyerror): Update.
9514 * go-exp.y (lex_one_token, yyerror): Update.
9515 * f-exp.y (match_string_literal, yylex, yyerror): Update.
9516 * d-exp.y (lex_one_token, yyerror): Update.
9517 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9518 (lex_one_token, yyerror): Update.
9519 * ada-lex.l (YY_INPUT): Update.
9520 (rewind_to_char): Update.
9521 * ada-exp.y (yyerror): Update.
9522
8621b685
TT
95232019-04-04 Tom Tromey <tom@tromey.com>
9524
9525 * rust-exp.y (rustyylex, rust_lex_tests): Update.
9526 * parser-defs.h (struct parser_state) <parser_state>: Add new
9527 parameter.
9528 <comma_terminates>: New member.
9529 (comma_terminates): Don't declare global.
9530 * parse.c (comma_terminates): Remove global.
9531 (parse_exp_in_context): Update.
9532 * p-exp.y (yylex): Update.
9533 * m2-exp.y (yylex): Update.
9534 * go-exp.y (lex_one_token): Update.
9535 * f-exp.y (yylex): Update.
9536 * d-exp.y (lex_one_token): Update.
9537 * c-exp.y (lex_one_token): Update.
9538 * ada-lex.l: Update.
9539
28aaf3fd
TT
95402019-04-04 Tom Tromey <tom@tromey.com>
9541
9542 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9543 (rustyylex, rust_lex_test_init, rust_lex_test_one)
9544 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9545 * parser-defs.h (paren_depth): Don't declare.
9546 * parse.c (paren_depth): Remove global.
9547 (parse_exp_in_context): Update.
9548 * p-exp.y (paren_depth): New global.
9549 (pascal_parse): Initialize it.
9550 * m2-exp.y (paren_depth): New global.
9551 (m2_parse): Initialize it.
9552 * go-exp.y (paren_depth): New global.
9553 (go_parse): Initialize it.
9554 * f-exp.y (paren_depth): New global.
9555 (f_parse): Initialize it.
9556 * d-exp.y (paren_depth): New global.
9557 (d_parse): Initialize it.
9558 * c-exp.y (paren_depth): New global.
9559 (c_parse): Initialize it.
9560 * ada-lex.l (paren_depth): New global.
9561 (lexer_init): Initialize it.
9562
1e58a4a4
TT
95632019-04-04 Tom Tromey <tom@tromey.com>
9564
9565 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9566 (rust_parser::convert_ast_to_type)
9567 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9568 * parser-defs.h (struct parser_state) <parser_state>: Add
9569 parameters. Initialize new members.
9570 <expression_context_block, expression_context_pc>: New members.
9571 * parse.c (expression_context_block, expression_context_pc):
9572 Remove globals.
9573 (parse_exp_in_context): Update.
9574 * p-exp.y: Update all rules.
9575 (yylex): Update.
9576 * m2-exp.y: Update all rules.
9577 (yylex): Update.
9578 * go-exp.y (yylex): Update.
9579 * f-exp.y (yylex): Update.
9580 * d-exp.y: Update all rules.
9581 (yylex): Update.
9582 * c-exp.y: Update all rules.
9583 (lex_one_token, classify_name, yylex, c_parse): Update.
9584 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9585
37eedb39
TT
95862019-04-04 Tom Tromey <tom@tromey.com>
9587
9588 * gdbarch.h, gdbarch.c: Rebuild.
9589 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9590 * stap-probe.h:
9591 (struct stap_parse_info): Replace "parser_state" with
9592 "expr_builder".
9593 * parser-defs.h (struct expr_builder): Rename from "parser_state".
9594 (parser_state): New class.
9595 * parse.c (expr_builder): Rename.
9596 (expr_builder::release): Rename.
9597 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9598 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9599 (write_exp_elt_longcst, write_exp_elt_floatcst)
9600 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9601 (write_exp_string_vector, write_exp_bitstring)
9602 (write_exp_msymbol, mark_struct_expression)
9603 (write_dollar_variable)
9604 (insert_type_address_space, increase_expout_size): Replace
9605 "parser_state" with "expr_builder".
9606 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9607 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9608 "parser_state" with "expr_builder".
9609
73923d7e
TT
96102019-04-04 Tom Tromey <tom@tromey.com>
9611
9612 * rust-exp.y: Replace "parse_language" with method call.
9613 * p-exp.y:
9614 (yylex): Replace "parse_language" with method call.
9615 * m2-exp.y:
9616 (yylex): Replace "parse_language" with method call.
9617 * go-exp.y (classify_name): Replace "parse_language" with method
9618 call.
9619 * f-exp.y (yylex): Replace "parse_language" with method call.
9620 * d-exp.y (lex_one_token): Replace "parse_language" with method
9621 call.
9622 * c-exp.y:
9623 (lex_one_token, classify_name, yylex): Replace "parse_language"
9624 with method call.
9625 * ada-exp.y (find_primitive_type, type_char)
9626 (type_system_address): Replace "parse_language" with method call.
9627
fa9f5be6
TT
96282019-04-04 Tom Tromey <tom@tromey.com>
9629
9630 * rust-exp.y: Replace "parse_gdbarch" with method call.
9631 * parse.c (write_dollar_variable, insert_type_address_space):
9632 Replace "parse_gdbarch" with method call.
9633 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9634 call.
9635 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9636 call.
9637 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9638 "parse_gdbarch" with method call.
9639 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9640 with method call.
9641 * f-exp.y (parse_type, parse_f_type, yylex): Replace
9642 "parse_gdbarch" with method call.
9643 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9644 "parse_gdbarch" with method call.
9645 * c-exp.y (parse_type, parse_number, classify_name): Replace
9646 "parse_gdbarch" with method call.
9647 * ada-lex.l: Replace "parse_gdbarch" with method call.
9648 * ada-exp.y (parse_type, find_primitive_type, type_char)
9649 (type_system_address): Replace "parse_gdbarch" with method call.
9650
1201a264
TT
96512019-04-04 Tom Tromey <tom@tromey.com>
9652
9653 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9654 * stap-probe.c (stap_parse_argument): Update.
9655 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9656 initial_size parameter.
9657 * rust-exp.y (rust_lex_tests): Update.
9658 * parse.c (parser_state): Update.
9659 (parse_exp_in_context): Update.
9660 * parser-defs.h (struct parser_state) <parser_state>: Remove
9661 "initial_size" parameter.
9662
e3980ce2
TT
96632019-04-04 Tom Tromey <tom@tromey.com>
9664
9665 * parser-defs.h (increase_expout_size): Don't declare.
9666 * parse.c (increase_expout_size): Now static.
9667
e9f8e3f1
TS
96682019-04-04 Thomas Schwinge <thomas@codesourcery.com>
9669
9670 * gnu-nat.c (gnu_nat_target::wait): Fix
9671 target_waitstatus_to_string call.
9672
d7df6549
AB
96732019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9674
9675 * eval.c (evaluate_subexp_standard): Handle internal functions
9676 during Fortran function call handling.
9677
8bdc1658
AB
96782019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9679
9680 * NEWS: Mention new internal functions.
9681 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9682 (read_base_type): Use dwarf2_init_complex_target_type.
9683 * value.c (creal_internal_fn): New function.
9684 (cimag_internal_fn): New function.
9685 (_initialize_values): Register new internal functions.
9686
c29705b7
PW
96872019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9688
9689 * infrun.c (stop_all_threads): If debug_infrun, always
9690 trace the wait status after wait_one, using
9691 target_waitstatus_to_string and target_pid_to_str.
9692 (handle_inferior_event): Replace various trace of
9693 wait status kind by a single trace.
9694 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9695 wait status kind image by target_waitstatus_to_string.
9696 * target/waitstatus.c (target_waitstatus_to_string): Fix
9697 obsolete comment.
9698
05caa1d2
TT
96992019-04-01 Tom Tromey <tromey@adacore.com>
9700
9701 PR symtab/23331:
9702 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9703
9d1447e0
SDJ
97042019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
9705 Pedro Alves <palves@redhat.com>
9706
9707 * top.c (quit_force): Call 'finalize_values'.
9708 * value.c (finalize_values): New function.
9709 * value.h (finalize_values): Declare.
9710
7734102d
EZ
97112019-03-30 Eli Zaretskii <eliz@gnu.org>
9712
9713 * NEWS: Announce $_gdb_major and $_gdb_minor.
9714
9715 * top.c (init_gdb_version_vars): New function.
9716 (gdb_init): Call init_gdb_version_vars.
9717
188e1fa9
TT
97182019-03-29 Tom Tromey <tromey@adacore.com>
9719
9720 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
9721 help text. Remove dead code.
9722
2880242d
KS
97232019-03-29 Keith Seitz <keiths@redhat.com>
9724
9725 From Siddhesh Poyarekar:
9726 * f-lang.h (f77_get_upperbound): Return LONGEST.
9727 (f77_get_lowerbound): Likewise.
9728 * f-typeprint.c (f_type_print_varspec_suffix): Expand
9729 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
9730 print them.
9731 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
9732 plongest to format print it.
9733 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9734 (f77_get_upperbound): Likewise.
9735 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9736 LOWER_BOUND to LONGEST.
9737 (f77_create_arrayprint_offset_tbl): Likewise.
9738
cc1defb1
KS
97392019-03-29 Keith Seitz <keiths@redhat.com>
9740
9741 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9742 %s/pulongest for TYPE_LENGTH instead of %d in format
9743 strings.
9744 * ada-typerint.c (ada_print_type): Likewise.
9745 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9746 * compile/compile-c-support.c (generate_register_struct): Likewise.
9747 * gdbtypes.c (recursive_dump_type): Likewise.
9748 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9749 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
9750 instead of %d in format strings.
9751 * riscv-tdep.c (riscv_type_alignment): Cast second argument
9752 to std::min to ULONGEST.
9753 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9754 instead of %d in format strings.
9755 * tracepoint.c (info_scope_command): Likewise.
9756 * typeprint.c (print_offset_data::update)
9757 (print_offset_data::finish): Likewise.
9758 * xtensa-tdep.c (xtensa_store_return_value)
9759 (xtensa_push_dummy_call): Likewise.
9760
e432ccf1
JT
97612019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
9762
9763 * windows-nat.c (display_selector): Fixed format specifications
9764 for 64-bit Cygwin.
9765
65d2b333
PW
97662019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9767
9768 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9769
f489207e
SL
97702019-03-28 Sandra Loosemore <sandra@codesourcery.com>
9771
9772 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9773 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9774 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9775 (nios2_linux_init_abi): Install it.
9776
bffa1015
AH
97772019-03-28 Alan Hayward <alan.hayward@arm.com>
9778
9779 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9780
fc96163a
AH
97812019-03-28 Alan Hayward <alan.hayward@arm.com>
9782
9783 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9784
20dc7e9b
PW
97852019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9786 Tom Tromey <tromey@adacore.com>
9787
9788 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9789
7f5331a8
JB
97902019-03-26 Joel Brobecker <brobecker@adacore.com>
9791
9792 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9793 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9794 method to compute the bounds of range types. Also print "[evaluated]"
9795 if the bounds' values come from a dynamic evaluation.
9796
18c77628
AB
97972019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
9798
9799 * cp-valprint.c (cp_print_value_fields): Don't print trailing
9800 whitespace when pretty printing is on.
9801
53c973f2
AH
98022019-03-26 Alan Hayward <alan.hayward@arm.com>
9803
e79be6e5 9804 * ppc-linux-nat.c: Add include.
53c973f2 9805
d851aa71
AH
98062019-03-26 Alan Hayward <alan.hayward@arm.com>
9807
e79be6e5 9808 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 9809
2fe7bab7
AH
98102019-03-26 Alan Hayward <alan.hayward@arm.com>
9811
e79be6e5 9812 * arm-linux-nat.c: Add include.
2fe7bab7 9813
068ef30e
SM
98142019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
9815
9816 * source-cache.c (source_cache::get_source_lines): Re-read
9817 fullname after calling open_source_file.
9818
81a24d04
JB
98192019-03-25 John Baldwin <jhb@FreeBSD.org>
9820
9821 * NEWS: Mention TLS support for FreeBSD.
9822
79e7ae11
TT
98232019-03-25 Tom Tromey <tromey@adacore.com>
9824
9825 * minsyms.c (BUNCH_SIZE): Update comment.
9826 (~minimal_symbol_reader): Remove old comment.
9827 (compact_minimal_symbols): Update comment.
9828 (minimal_symbol_reader::install): Remove old comment. Update
9829 other comments.
9830
d45963c2
AH
98312019-03-25 Alan Hayward <alan.hayward@arm.com>
9832
9833 * s390-linux-nat.c: Add include.
9834
0f83012e
AH
98352019-03-25 Alan Hayward <alan.hayward@arm.com>
9836
9837 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9838 Call linux_get_hwcap.
9839 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9840 Likewise.
9841 (aarch64_linux_get_hwcap): Remove function.
9842 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9843 declaration.
9844 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9845 linux_get_hwcap.
9846 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9847 * linux-tdep.c (linux_get_hwcap): Add function.
9848 (linux_get_hwcap2): Likewise.
9849 * linux-tdep.h (linux_get_hwcap): Add declaration.
9850 (linux_get_hwcap2): Likewise.
9851 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9852 (ppc_linux_get_hwcap2): Likewise.
9853 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9854 linux_get_hwcap.
9855 (ppc_linux_nat_target::insert_watchpoint): Likewise.
9856 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9857 (ppc_linux_nat_target::read_description): Likewise.
9858 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9859 * s390-linux-nat.c: Likewise.
9860 * s390-linux-tdep.c (s390_core_read_description): Likewise.
9861
6640a367
TT
98622019-03-24 Tom Tromey <tom@tromey.com>
9863
9864 * ada-lang.c (standard_lookup): Simplify initialization.
9865 (ada_lookup_symbol_nonlocal): Simplify return.
9866 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9867 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9868 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9869 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9870 initialization.
9871 * solib.c (solib_global_lookup): Simplify.
9872 * symtab.c (null_block_symbol): Remove.
9873 (symbol_cache_lookup): Simplify returns.
9874 (lookup_language_this): Simplify returns.
9875 (lookup_symbol_aux): Simplify return.
9876 (lookup_local_symbol): Simplify returns.
9877 (lookup_global_symbol_from_objfile): Simplify return.
9878 (lookup_symbol_in_objfile_symtabs)
9879 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9880 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9881 (lookup_static_symbol, lookup_global_symbol): Simplify return.
9882 * cp-namespace.c (cp_lookup_bare_symbol)
9883 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9884 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9885 (cp_lookup_nested_symbol): Don't use null_block_symbol.
9886 (cp_lookup_symbol_via_imports): Simplify initialization.
9887 (find_symbol_in_baseclass): Likewise.
9888 * symtab.h (null_block_symbol): Remove.
9889 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9890 (d_lookup_nested_symbol, d_lookup_symbol_imports)
9891 (d_lookup_symbol_module): Likewise.
9892 (find_symbol_in_baseclass): Simplify initialization.
9893
a930ebcd
TT
98942019-03-24 Tom Tromey <tom@tromey.com>
9895
9896 * expression.h: Don't include symtab.h.
9897 (struct block): Forward declare.
9898
582942f4
TT
98992019-03-24 Tom Tromey <tom@tromey.com>
9900
9901 * c-exp.y (typebase): Remove casts.
9902 * gdbtypes.c (lookup_unsigned_typename, )
9903 (lookup_signed_typename): Remove cast.
9904 * eval.c (parse_to_comma_and_eval): Remove cast.
9905 * parse.c (write_dollar_variable): Remove cast.
9906 * block.h (struct block) <superblock>: Now const.
9907 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9908 * psymtab.c (psym_map_matching_symbols): Make "block" const.
9909 (map_block): Make "block" const.
9910 * symfile.h (struct quick_symbol_functions)
9911 <map_matching_symbols>: Constify block argument to "callback".
9912 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9913 const.
9914 (find_pc_sect_compunit_symtab): Make "b" const.
9915 (find_symbol_at_address): Likewise.
9916 (search_symbols): Likewise.
9917 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9918 (dw2_debug_names_lookup_symbol): Likewise.
9919 (dw2_map_matching_symbols): Update.
9920 * p-valprint.c (pascal_val_print): Remove "block".
9921 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9922 (aux_add_nonlocal_symbols): Make "block" const.
9923 (resolve_subexp): Remove cast.
9924 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9925 const.
9926 (iterate_over_file_blocks): Likewise.
9927 * f-exp.y (%union) <bval>: Remove.
9928 * coffread.c (patch_opaque_types): Make "b" const.
9929 * spu-tdep.c (spu_catch_start): Make "block" const.
9930 * c-valprint.c (print_unpacked_pointer): Remove "block".
9931 * symmisc.c (dump_symtab_1): Make "b" const.
9932 (block_depth): Make "block" const.
9933 * d-exp.y (%union) <bval>: Remove.
9934 * cp-support.h (cp_lookup_rtti_type): Update.
9935 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9936 * psymtab.c (psym_lookup_symbol): Make "block" const.
9937 (maintenance_check_psymtabs): Make "b" const.
9938 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9939 (enumerate_locals, enumerate_args): Update.
9940 * python/py-symtab.c (stpy_global_block): Make "block" const.
9941 (stpy_static_block): Likewise.
9942 * inline-frame.c (block_starting_point_at): Make "new_block"
9943 const.
9944 * block.c (find_block_in_blockvector): Make return type const.
9945 (blockvector_for_pc_sect): Make "b" const.
9946 (find_block_in_blockvector): Make "b" const.
9947
7ad417dd
TT
99482019-03-23 Tom Tromey <tom@tromey.com>
9949
9950 * varobj.c (varobj_create): Update.
9951 * symfile.c (clear_symtab_users): Don't reset innermost_block.
9952 * printcmd.c (display_command, do_one_display): Don't reset
9953 innermost_block.
9954 * parser-defs.h (enum innermost_block_tracker_type): Move to
9955 expression.h.
9956 (innermost_block): Update comment.
9957 * parse.c (parse_exp_1): Add tracker_types parameter.
9958 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
9959 tracker_types parameter. Reset innermost_block.
9960 (parse_exp_in_context): Remove.
9961 (parse_expression_for_completion): Update.
9962 * objfiles.c (~objfile): Don't reset expression_context_block or
9963 innermost_block.
9964 * expression.h (enum innermost_block_tracker_type): Move from
9965 parser-defs.h.
9966 (parse_exp_1): Add tracker_types parameter.
9967 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9968 reset innermost_block.
9969
b366c208
TT
99702019-03-23 Tom Tromey <tom@tromey.com>
9971
9972 * objfiles.h: Include bcache.h.
9973
9bb9b2f9
TT
99742019-03-23 Tom Tromey <tom@tromey.com>
9975
9976 * linespec.c (get_current_search_block): Use
9977 scoped_restore_current_language.
9978 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9979
59c28372
AH
99802019-03-22 Alan Hayward <alan.hayward@arm.com>
9981 Jiong Wang <jiong.wang@arm.com>
9982
9983 * aarch64-linux-tdep.c
9984 (aarch64_linux_iterate_over_regset_sections): Check for pauth
9985 section.
9986 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9987
17e116a7
AH
99882019-03-22 Alan Hayward <alan.hayward@arm.com>
9989 Jiong Wang <jiong.wang@arm.com>
9990
9991 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9992 instructions.
9993 (aarch64_analyze_prologue_test): Add PACIASP test.
9994 (aarch64_prologue_prev_register): Unmask PC value.
9995
11e1b75f
AH
99962019-03-22 Alan Hayward <alan.hayward@arm.com>
9997 Jiong Wang <jiong.wang@arm.com>
9998
9999 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10000 (aarch64_dwarf2_prev_register): Unmask PC value.
10001 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10002 (aarch64_execute_dwarf_cfa_vendor_op): Check for
10003 DW_CFA_AARCH64_negate_ra_state.
10004 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10005
34dcc7cf
AH
100062019-03-22 Alan Hayward <alan.hayward@arm.com>
10007 Jiong Wang <jiong.wang@arm.com>
10008
10009 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10010 registers.
10011 (aarch64_pseudo_register_name): Likewise.
10012 (aarch64_pseudo_register_type): Likewise.
10013 (aarch64_pseudo_register_reggroup_p): Likewise.
10014 (aarch64_gdbarch_init): Add pauth registers.
10015 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10016 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10017 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10018 (struct gdbarch_tdep): Add regnum for ra_state.
10019
1ef53e6b
AH
100202019-03-22 Alan Hayward <alan.hayward@arm.com>
10021 Jiong Wang <jiong.wang@arm.com>
10022
10023 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10024
76bed0fd
AH
100252019-03-22 Alan Hayward <alan.hayward@arm.com>
10026 Jiong Wang <jiong.wang@arm.com>
10027
10028 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10029 function.
10030 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10031 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10032 (aarch64_gdbarch_init): Add puth registers.
10033 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10034 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10035 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10036
ee4fbcfa
AH
100372019-03-22 Alan Hayward <alan.hayward@arm.com>
10038 Jiong Wang <jiong.wang@arm.com>
10039
10040 * aarch64-linux-nat.c
10041 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10042 * aarch64-linux-tdep.c
10043 (aarch64_linux_core_read_description): Likewise.
10044 (aarch64_linux_get_hwcap): New function.
10045 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10046 (aarch64_linux_get_hwcap): New declaration.
10047
6dc0ebde
AH
100482019-03-22 Alan Hayward <alan.hayward@arm.com>
10049 Jiong Wang <jiong.wang@arm.com>
10050
10051 * aarch64-linux-nat.c
10052 (aarch64_linux_nat_target::read_description): Add pauth param.
10053 * aarch64-linux-tdep.c
10054 (aarch64_linux_core_read_description): Likewise.
10055 * aarch64-tdep.c (struct target_desc): Add in pauth.
10056 (aarch64_read_description): Add pauth param.
10057 (aarch64_gdbarch_init): Likewise.
10058 * aarch64-tdep.h (aarch64_read_description): Likewise.
10059 * arch/aarch64.c (aarch64_create_target_description): Likewise.
10060 * arch/aarch64.h (aarch64_create_target_description): Likewise.
10061 * features/Makefile: Add new files.
10062 * features/aarch64-pauth.c: New file.
10063 * features/aarch64-pauth.xml: New file.
10064
595915c1
TT
100652019-03-20 Tom Tromey <tromey@adacore.com>
10066
10067 * infrun.c (handle_inferior_event): Rename from
10068 handle_inferior_event_1. Create a scoped_value_mark.
10069 (handle_inferior_event): Remove.
10070
4c7d57e7
TT
100712019-03-19 Tom Tromey <tromey@adacore.com>
10072
10073 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10074 * infrun.h (print_stop_event): Add "displays" parameter.
10075 * infrun.c (print_stop_event): Add "displays" parameter.
10076
cb246234
PA
100772019-03-19 Pedro Alves <palves@redhat.com>
10078
10079 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10080 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
10081 to -1. Fix TABs vs spaces.
10082 (tui_ui_out::tui_ui_out): Don't initialize fields here.
10083 * tui/tui-out.h (tui_ui_out) Add intro comments.
10084 <m_line, m_start_of_line>: In-class initialize, and add describing
10085 comment.
10086
3a0e45b2
AH
100872019-03-18 Alan Hayward <alan.hayward@arm.com>
10088
10089 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10090 variable names.
10091 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10092
5371b850
PA
100932019-03-18 Pedro Alves <palves@redhat.com>
10094 Eli Zaretskii <eliz@gnu.org>
10095
10096 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10097 m_line and m_start_of_line.
10098
b17c4cd0
EZ
100992019-03-18 Eli Zaretskii <eliz@gnu.org>
10100
10101 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10102 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10103 it returns a newline. This fixes a regression in TU mode, whereby
10104 the next line is output on the same screen line as the user input.
10105
4bd56d18
TT
101062019-03-18 Tom Tromey <tromey@adacore.com>
10107
10108 * minsyms.c (minimal_symbol_reader::install): Remove call to
10109 obstack_blank.
10110
55c10aca
PA
101112019-03-18 Pedro Alves <palves@redhat.com>
10112
10113 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10114 New globals.
10115 (apply_style): New, factored out from ...
10116 (apply_ansi_escape): ... this. Handle reverse video mode.
10117 (tui_set_reverse_mode): New function.
10118 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10119 * tui/tui-winsource.c (tui_show_source_line): Use
10120 tui_set_reverse_mode instead of setting A_STANDOUT.
10121 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10122 New setter methods.
10123
647bb750
HD
101242019-03-18 Hannes Domani <ssbssa@yahoo.de>
10125
10126 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10127 Handle tabs.
10128
bff8c71f
TT
101292019-03-18 Tom Tromey <tromey@adacore.com>
10130
10131 * ada-lang.c (empty_array): Add "high" parameter.
10132 (ada_evaluate_subexp): Update.
10133
58785d98
ST
101342019-03-17 Sergei Trofimovich <siarheit@google.com>
10135
10136 * unittests/string_view-selftests.c: Define
10137 _initialize_string_view_selftests unconditionally.
10138
d4cbef22
ВМ
101392019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10140
10141 PR gdb/24350
10142 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10143
fce4c071
ВМ
101442019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10145
10146 PR gdb/24351
10147 * windows-nat.c (display_selector): Fix format specifiers.
10148
f7f0a123
EZ
101492019-03-17 Eli Zaretskii <eliz@gnu.org>
10150
10151 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10152 tui_refill_source_window instead of tui_refresh_win, to update the
10153 current execution line. This fixes redisplay of the current line
10154 when stepping through the code with "next" or "step".
10155
ab42892f
EZ
101562019-03-16 Eli Zaretskii <eliz@gnu.org>
10157
10158 * source-cache.c (source_cache::get_source_lines): Call
10159 find_source_lines to initialize s->nlines. This fixes vertical
10160 scrolling of TUI source window when the DOWN arrow is pressed.
10161
8d8c087f
PW
101622019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10163
10164 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10165 linux-thread-db.c (_initialize_thread_db): Likewise.
10166
798e1c30
EZ
101672019-03-16 Eli Zaretskii <eliz@gnu.org>
10168
10169 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10170 wclrtoeol in tui_show_source_line". This reverts changes made in
10171 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10172
eefba3da
TT
101732019-03-15 Tom Tromey <tom@tromey.com>
10174
10175 * symtab.h (struct minimal_symbol): Derive from
10176 general_symbol_info.
10177 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10178 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10179 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10180 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10181 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10182 (MSYMBOL_SEARCH_NAME): Update.
10183 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10184 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10185 * minsyms.c (minimal_symbol_reader::record_full): Update.
10186
0de2420c
TT
101872019-03-15 Tom Tromey <tom@tromey.com>
10188
10189 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10190
042d75e4
TT
101912019-03-15 Tom Tromey <tom@tromey.com>
10192
10193 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10194 unique_xmalloc_ptr.
10195 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10196 Update.
10197 * minsyms.c (lookup_minimal_symbol_by_pc_section)
10198 (build_minimal_symbol_hash_tables)
10199 (minimal_symbol_reader::install): Update.
10200
db92718b
TT
102012019-03-15 Tom Tromey <tom@tromey.com>
10202
10203 * symtab.c (create_demangled_names_hash): Update.
10204 (symbol_set_names): Update.
10205 * objfiles.h (struct objfile_per_bfd_storage)
10206 <demangled_names_hash>: Now an htab_up.
10207 * objfiles.c (objfile_per_bfd_storage): Simplify.
10208
d6797f46
TT
102092019-03-15 Tom Tromey <tom@tromey.com>
10210
10211 * objfiles.h (struct objfile_per_bfd_storage): Declare
10212 destructor.
10213 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10214 New.
10215 (get_objfile_bfd_data): Use new. Don't initialize
10216 language_of_main.
10217 (free_objfile_per_bfd_storage): Remove.
10218 (objfile_bfd_data_free, objfile::~objfile): Use delete.
10219
741d7538
TT
102202019-03-15 Tom Tromey <tom@tromey.com>
10221
10222 * symfile.c (reread_symbols): Update.
10223 * objfiles.c (objfile::objfile): Update.
10224 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10225 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10226 comment.
10227 (minimal_symbol_reader::install): Update.
10228 (terminate_minimal_symbol_table): Remove.
10229 * jit.c (jit_object_close_impl): Update.
10230
788c80d1
TT
102312019-03-15 Tom Tromey <tom@tromey.com>
10232
10233 * minsyms.c (minimal_symbol_reader::record_full): Remove some
10234 initializations.
10235
1b7a07cb
TT
102362019-03-15 Tom Tromey <tom@tromey.com>
10237
10238 * objfiles.h (struct objfile_per_bfd_storage)
10239 <demangled_hash_languages>: Now a bitset.
10240 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10241 (lookup_minimal_symbol): Update.
10242
3db066bc
TT
102432019-03-15 Tom Tromey <tom@tromey.com>
10244
10245 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10246 Don't return the symbol.
10247 * coffread.c (record_minimal_symbol): Use record_full.
10248
3fff2c37
EZ
102492019-03-14 Eli Zaretskii <eliz@gnu.org>
10250
10251 The MS-Windows port of ncurses fails to switch to a color pair if
10252 one or both of the colors are the implicit default colors. This
10253 change records the default colors when TUI is initialized, and
10254 then specifies them explicitly when a color pair uses the default
10255 colors. This allows color styling in TUI mode on MS-Windows.
10256
10257 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
10258 ncurses_norm_attr.
10259 (tui_initialize_io) [__MINGW32__]: Record the default terminal
10260 colors in ncurses_norm_attr.
10261 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10262 "none", replace it with the default color recorded in
10263 ncurses_norm_attr.
10264
3b336828
TT
102652019-03-14 Tom Tromey <tromey@adacore.com>
10266
10267 * source-cache.h (class source_cache) <get_source_lines>: Return
10268 std::string.
10269 * source-cache.c (source_cache::extract_lines): Handle case where
10270 first_pos==npos. Return std::string.
10271 (source_cache::get_source_lines): Update.
10272
d085f989
TT
102732019-03-14 Tom Tromey <tromey@adacore.com>
10274
10275 * NEWS: Add item for "style sources" commands.
10276 * source-cache.c (source_cache::get_source_lines): Check
10277 source_styling.
10278 * cli/cli-style.c (source_styling): New global.
10279 (_initialize_cli_style): Add "style sources" commands.
10280 (show_style_sources): New function.
10281 * cli/cli-style.h (source_styling): Declare.
10282
6f11e682
TT
102832019-03-14 Pedro Alves <palves@redhat.com>
10284 Tom Tromey <tromey@adacore.com>
10285
10286 * tui/tui-winsource.h (tui_refill_source_window): Declare.
10287 * tui/tui-winsource.c (tui_refill_source_window): New function,
10288 from...
10289 (tui_horizontal_source_scroll): ... here. Move some logic.
10290 * cli/cli-style.c (set_style_enabled): Notify new observable.
10291 * tui/tui-hooks.c (tui_redisplay_source): New function.
10292 (tui_attach_detach_observers): Attach or detach
10293 tui_redisplay_source.
10294 * observable.h (source_styling_changed): New observable.
10295 * observable.c: Define source_styling_changed observable.
10296
a068643d
TT
102972019-03-13 Tom Tromey <tromey@adacore.com>
10298
10299 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10300 (i386_gnu_nat_target::store_registers): Update.
10301 * target-debug.h (target_debug_print_std_string): New macro.
10302 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10303 * windows-tdep.c (display_one_tib): Update.
10304 * tui/tui-stack.c (tui_make_status_line): Update.
10305 * top.c (print_inferior_quit_action): Update.
10306 * thread.c (thr_try_catch_cmd): Update.
10307 (add_thread_with_info): Update.
10308 (thread_target_id_str): Update.
10309 (thr_try_catch_cmd): Update.
10310 (thread_command): Update.
10311 (thread_find_command): Update.
10312 * record-btrace.c (record_btrace_target::info_record)
10313 (record_btrace_resume_thread, record_btrace_target::resume)
10314 (record_btrace_cancel_resume, record_btrace_step_thread)
10315 (record_btrace_target::wait, record_btrace_target::wait)
10316 (record_btrace_target::wait, record_btrace_target::stop): Update.
10317 * progspace.c (print_program_space): Update.
10318 * process-stratum-target.c
10319 (process_stratum_target::thread_address_space): Update.
10320 * linux-fork.c (linux_fork_mourn_inferior)
10321 (detach_checkpoint_command, info_checkpoints_command)
10322 (linux_fork_context): Update.
10323 (linux_fork_detach): Update.
10324 (class scoped_switch_fork_info): Update.
10325 (delete_checkpoint_command): Update.
10326 * infrun.c (follow_fork_inferior): Update.
10327 (follow_fork_inferior): Update.
10328 (proceed_after_vfork_done): Update.
10329 (handle_vfork_child_exec_or_exit): Update.
10330 (follow_exec): Update.
10331 (displaced_step_prepare_throw): Update.
10332 (displaced_step_restore): Update.
10333 (start_step_over): Update.
10334 (resume_1): Update.
10335 (clear_proceed_status_thread): Update.
10336 (proceed): Update.
10337 (print_target_wait_results): Update.
10338 (do_target_wait): Update.
10339 (context_switch): Update.
10340 (stop_all_threads): Update.
10341 (restart_threads): Update.
10342 (finish_step_over): Update.
10343 (handle_signal_stop): Update.
10344 (switch_back_to_stepped_thread): Update.
10345 (keep_going_pass_signal): Update.
10346 (print_exited_reason): Update.
10347 (normal_stop): Update.
10348 * inferior.c (inferior_pid_to_str): Change return type.
10349 (print_selected_inferior): Update.
10350 (add_inferior): Update.
10351 (detach_inferior): Update.
10352 * dummy-frame.c (fprint_dummy_frames): Update.
10353 * dcache.c (dcache_info_1): Update.
10354 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10355 (btrace_fetch, btrace_clear): Update.
10356 * linux-tdep.c (linux_core_pid_to_str): Change return type.
10357 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10358 type.
10359 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10360 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10361 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10362 * gdbarch.c, gdbarch.h: Rebuild.
10363 * gdbarch.sh (core_pid_to_str): Change return type.
10364 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10365 return type.
10366 (windows_nat_target::pid_to_str): Change return type.
10367 (windows_delete_thread): Update.
10368 (windows_nat_target::attach): Update.
10369 (windows_nat_target::files_info): Update.
10370 * target-delegates.c: Rebuild.
10371 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10372 return type.
10373 (sol_thread_target::pid_to_str): Change return type.
10374 * remote.c (class remote_target) <pid_to_str>: Change return
10375 type.
10376 (remote_target::pid_to_str): Change return type.
10377 (extended_remote_target::attach, remote_target::remote_stop_ns)
10378 (remote_target::remote_notif_remove_queued_reply)
10379 (remote_target::push_stop_reply, remote_target::disable_btrace):
10380 Update.
10381 (extended_remote_target::attach): Update.
10382 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10383 type.
10384 (gdbsim_target::pid_to_str): Change return type.
10385 * ravenscar-thread.c (struct ravenscar_thread_target)
10386 <pid_to_str>: Change return type.
10387 (ravenscar_thread_target::pid_to_str): Change return type.
10388 * procfs.c (class procfs_target) <pid_to_str>: Change return
10389 type.
10390 (procfs_target::pid_to_str): Change return type.
10391 (procfs_target::attach): Update.
10392 (procfs_target::detach): Update.
10393 (procfs_target::fetch_registers): Update.
10394 (procfs_target::store_registers): Update.
10395 (procfs_target::wait): Update.
10396 (procfs_target::files_info): Update.
10397 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10398 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10399 return type.
10400 (nto_procfs_target::pid_to_str): Change return type.
10401 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10402 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10403 return type.
10404 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10405 (exit_lwp): Update.
10406 (attach_proc_task_lwp_callback, get_detach_signal)
10407 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10408 (linux_nat_target::resume, wait_lwp, stop_callback)
10409 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10410 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10411 (linux_nat_wait_1, resume_stopped_resumed_lwps)
10412 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10413 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10414 type.
10415 (inf_ptrace_target::attach): Update.
10416 (inf_ptrace_target::files_info): Update.
10417 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10418 type.
10419 (go32_nat_target::pid_to_str): Change return type.
10420 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10421 (gnu_nat_target::wait): Update.
10422 (gnu_nat_target::wait): Update.
10423 (gnu_nat_target::resume): Update.
10424 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10425 (fbsd_nat_target::wait): Update.
10426 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10427 type.
10428 (darwin_nat_target::attach): Update.
10429 * corelow.c (class core_target) <pid_to_str>: Change return type.
10430 (core_target::pid_to_str): Change return type.
10431 * target.c (normal_pid_to_str): Change return type.
10432 (default_pid_to_str): Likewise.
10433 (target_pid_to_str): Change return type.
10434 (target_translate_tls_address): Update.
10435 (target_announce_detach): Update.
10436 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10437 return type.
10438 (bsd_uthread_target::pid_to_str): Change return type.
10439 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10440 type.
10441 (bsd_kvm_target::pid_to_str): Change return type.
10442 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10443 return type.
10444 (aix_thread_target::pid_to_str): Change return type.
10445 * target.h (struct target_ops) <pid_to_str>: Change return type.
10446 (target_pid_to_str, normal_pid_to_str): Likewise.
10447 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10448 type.
10449 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10450 type.
10451 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10452 return type.
10453 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10454 type.
10455 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10456 type.
10457 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10458 return type.
10459
b4be1b06
SM
104602019-03-13 Simon Marchi <simon.marchi@ericsson.com>
10461
10462 * NEWS: Mention that the new default MI version is 3. Mention
10463 changes to the output of commands and events that deal with
10464 multi-location breakpoints.
10465 * breakpoint.c: Include "mi/mi-out.h".
10466 (print_one_breakpoint): Change output syntax if using MI version
10467 >= 3.
10468 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10469 New.
10470 (mi_multi_location_breakpoint_output_fixed): New.
10471 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10472 (mi_cmd_fix_multi_location_breakpoint_output): New.
10473 (mi_multi_location_breakpoint_output_fixed): New.
10474 * mi/mi-cmds.c (mi_cmds): Register command
10475 -fix-multi-location-breakpoint-output.
10476 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10477 interpreter "mi".
10478
8e5e5494
SM
104792019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
10480
10481 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10482 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10483 instantiate mi_ui_out based on interpreter name.
10484 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10485 * mi/mi-main.c (mi_load_progress): Likewise.
10486
197df35e
JB
104872019-03-12 John Baldwin <jhb@FreeBSD.org>
10488
10489 * NEWS: Combine separate "New targets" sections for 8.3.
10490
8399425f
JB
104912019-03-12 John Baldwin <jhb@FreeBSD.org>
10492
10493 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10494 (ppcfbsd_init_abi): Install gdbarch
10495 "fetch_tls_load_module_address" and "get_thread_local_address"
10496 methods.
10497
b0f87ed0
JB
104982019-03-12 John Baldwin <jhb@FreeBSD.org>
10499
10500 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10501 (riscv_fbsd_init_abi): Install gdbarch
10502 "fetch_tls_load_module_address" and "get_thread_local_address"
10503 methods.
10504
ce25aa57
JB
105052019-03-12 John Baldwin <jhb@FreeBSD.org>
10506
10507 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10508 (i386fbsd_init_abi): Install gdbarch
10509 "fetch_tls_load_module_address" and "get_thread_local_address"
10510 methods.
10511
f5424cfa
JB
105122019-03-12 John Baldwin <jhb@FreeBSD.org>
10513
10514 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10515 (amd64fbsd_init_abi): Install gdbarch
10516 "fetch_tls_load_module_address" and "get_thread_local_address"
10517 methods.
10518
945f3901
JB
105192019-03-12 John Baldwin <jhb@FreeBSD.org>
10520
10521 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10522 (struct fbsd_pspace_data): New type.
10523 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10524 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10525 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10526 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10527 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10528
ef0bd204
JB
105292019-03-12 John Baldwin <jhb@FreeBSD.org>
10530
10531 * gdbtypes.c (lookup_struct_elt): New function.
10532 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10533 * gdbtypes.h (struct struct_elt): New type.
10534 (lookup_struct_elt): New prototype.
10535
36c53a02
JB
105362019-03-12 John Baldwin <jhb@FreeBSD.org>
10537
10538 * gdbtypes.c (lookup_struct_elt_type): Update comment and
10539 remove disabled code block.
10540
6e056c81
JB
105412019-03-12 John Baldwin <jhb@FreeBSD.org>
10542
10543 * gdbarch.sh (get_thread_local_address): New method.
10544 * gdbarch.h, gdbarch.c: Regenerate.
10545 * target.c (target_translate_tls_address): Use
10546 gdbarch_get_thread_local_address if present instead of
10547 target::get_thread_local_address.
10548
cd250a18
JB
105492019-03-12 John Baldwin <jhb@FreeBSD.org>
10550
10551 * target.h (target::get_thread_local_address): Update comment.
10552
df22c1e5
JB
105532019-03-12 John Baldwin <jhb@FreeBSD.org>
10554
10555 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10556 objfile->separate_debug_objfile_backlink if not NULL.
10557
dd6876c9
JB
105582019-03-12 John Baldwin <jhb@FreeBSD.org>
10559
10560 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10561 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10562 (amd64bsd_store_inferior_registers): Likewise.
10563 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10564 Enable segment base registers.
10565 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10566 PT_GETFSBASE and PT_GETGSBASE.
10567 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10568 PT_SETGSBASE.
10569 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10570 segment base registers.
10571 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10572
1163a4b7
JB
105732019-03-12 John Baldwin <jhb@FreeBSD.org>
10574
10575 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10576 Update calls to i386_target_description to add 'segments'
10577 parameter.
10578 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
10579 add segment base registers.
10580 * arch/i386.c (i386_create_target_description): Add 'segments'
10581 parameter to enable segment base registers.
10582 * arch/i386.h (i386_create_target_description): Likewise.
10583 * features/i386/32bit-segments.xml: New file.
10584 * features/i386/32bit-segments.c: Generate.
10585 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10586 call to i386_target_description to add 'segments' parameter.
10587 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10588 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10589 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10590 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10591 if feature is present.
10592 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10593 Add 'segments' parameter to call to i386_target_description.
10594 (i386_target_description): Add 'segments' parameter to enable
10595 segment base registers.
10596 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10597 to call to i386_target_description.
10598 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10599 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10600 Define I386_NUM_REGS.
10601 (i386_target_description): Add 'segments' parameter to enable
10602 segment base registers.
10603
3a350822
EZ
106042019-03-12 Eli Zaretskii <eliz@gnu.org>
10605
10606 PR/24325
10607 * source-cache.c: #undef open and close, to avoid unresolved
10608 externals during linking.
10609
ffdd69cf
TT
106102019-03-12 Tom Tromey <tromey@adacore.com>
10611
10612 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10613 const. Add initializers.
10614 (_initialize_remote): Don't initialize ptid globals.
10615
ec148c57
PA
106162019-03-12 Pedro Alves <palves@redhat.com>
10617
10618 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10619
32764270
PA
106202019-03-12 Pedro Alves <palves@redhat.com>
10621
10622 * cp-name-parser.y (main): Remove unused 'len' variable.
10623
17547186
TT
106242019-03-12 Tom Tromey <tromey@adacore.com>
10625
10626 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10627 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10628
d3a70e03
TT
106292019-03-12 Tom Tromey <tromey@adacore.com>
10630
10631 * linux-nat.c (iterate_over_lwps): Update.
10632 (stop_callback): Remove parameter.
10633 (stop_wait_callback, detach_callback, resume_set_callback)
10634 (select_singlestep_lwp_callback, set_ignore_sigint)
10635 (status_callback, resumed_callback, resume_clear_callback)
10636 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10637 data parameter.
10638 (linux_nat_target::detach, linux_nat_target::resume)
10639 (linux_stop_and_wait_all_lwps, select_event_lwp)
10640 (linux_nat_filter_event, linux_nat_wait_1)
10641 (linux_nat_target::kill, linux_nat_target::stop)
10642 (linux_nat_target::stop): Update.
10643 (linux_nat_resume_callback): Change type.
10644 (resume_stopped_resumed_lwps, count_events_callback)
10645 (select_event_lwp_callback): Likewise.
10646 (linux_stop_lwp, linux_nat_stop_lwp): Update.
10647 * arm-linux-nat.c (struct update_registers_data): Remove.
10648 (update_registers_callback): Change type.
10649 (arm_linux_insert_hw_breakpoint1): Update.
10650 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10651 parameter.
10652 (x86_linux_dr_set_addr): Update.
10653 (x86_linux_dr_set_control): Update.
10654 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10655 (iterate_over_lwps): Use gdb::function_view.
10656 * nat/aarch64-linux-hw-point.c (struct
10657 aarch64_dr_update_callback_param): Remove.
10658 (debug_reg_change_callback): Change type.
10659 (aarch64_notify_debug_reg_change): Update.
10660 * s390-linux-nat.c (s390_refresh_per_info): Update.
10661
82cb27ff
TT
106622019-03-11 Tom Tromey <tromey@adacore.com>
10663
10664 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10665 redundant assignment to "this_cu".
10666
568c0683
SM
106672019-03-08 Simon Marchi <simon.marchi@efficios.com>
10668
10669 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10670
f09ce22d
SM
106712019-03-08 Simon Marchi <simon.marchi@efficios.com>
10672
10673 * gdbtypes.c (rank_one_type_parm_set): New function extracted
10674 from...
10675 (rank_one_type): ... this.
10676
595f96a9
SM
106772019-03-08 Simon Marchi <simon.marchi@efficios.com>
10678
10679 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10680 from...
10681 (rank_one_type): ... this.
10682
2598a94b
SM
106832019-03-08 Simon Marchi <simon.marchi@efficios.com>
10684
10685 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10686 from...
10687 (rank_one_type): ... this.
10688
7f17b20d
SM
106892019-03-08 Simon Marchi <simon.marchi@efficios.com>
10690
10691 * gdbtypes.c (rank_one_type_parm_float): New function extracted
10692 from...
10693 (rank_one_type): ... this.
10694
2c509035
SM
106952019-03-08 Simon Marchi <simon.marchi@efficios.com>
10696
10697 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10698 from...
10699 (rank_one_type): ... this.
10700
0dd322dc
SM
107012019-03-08 Simon Marchi <simon.marchi@efficios.com>
10702
10703 * gdbtypes.c (rank_one_type_parm_range): New function extracted
10704 from...
10705 (rank_one_type): ... this.
10706
41ea4728
SM
107072019-03-08 Simon Marchi <simon.marchi@efficios.com>
10708
10709 * gdbtypes.c (rank_one_type_parm_char): New function extracted
10710 from...
10711 (rank_one_type): ... this.
10712
793cd1d2
SM
107132019-03-08 Simon Marchi <simon.marchi@efficios.com>
10714
10715 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10716 from...
10717 (rank_one_type): ... this.
10718
34910087
SM
107192019-03-08 Simon Marchi <simon.marchi@efficios.com>
10720
10721 * gdbtypes.c (rank_one_type_parm_int): New function extracted
10722 from...
10723 (rank_one_type): ... this.
10724
f1f832d6
SM
107252019-03-08 Simon Marchi <simon.marchi@efficios.com>
10726
10727 * gdbtypes.c (rank_one_type_parm_func): New function extracted
10728 from...
10729 (rank_one_type): ... this.
10730
b9f4512f
SM
107312019-03-08 Simon Marchi <simon.marchi@efficios.com>
10732
10733 * gdbtypes.c (rank_one_type_parm_array): New function extracted
10734 from...
10735 (rank_one_type): ... this.
10736
9293fc63
SM
107372019-03-08 Simon Marchi <simon.marchi@efficios.com>
10738
10739 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10740 from...
10741 (rank_one_type): ... this.
10742
e3abbe7e
PW
107432019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10744
10745 * inferior.c (initialize_inferiors): Ensure 'help set/show print
10746 inferior-events' shows the example events.
10747
e4adb939
EZ
107482019-03-08 Eli Zaretskii <eliz@gnu.org>
10749
10750 Support styling on native MS-Windows console
10751
10752 PR/24315
10753 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10754 on MS-Windows if $TERM is not defined.
10755
10756 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10757
10758 * posix-hdep.c (gdb_console_fputs):
10759 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10760 functions.
10761 * ui-file.h (gdb_console_fputs): Add prototype.
10762
10763 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10764 back to fputs only if the former returns zero.
10765
25629dfd
TT
107662019-03-07 Tom Tromey <tom@tromey.com>
10767
10768 * symmisc.c (print_symbol_bcache_statistics): Update.
10769 (print_objfile_statistics): Update.
10770 * symfile.c (allocate_symtab): Update.
10771 * stabsread.c: Don't include bcache.h.
10772 * psymtab.h (struct psymbol_bcache): Don't declare.
10773 (class psymtab_storage) <psymbol_cache>: Now a bcache.
10774 (psymbol_bcache_init, psymbol_bcache_free)
10775 (psymbol_bcache_get_bcache): Don't declare.
10776 * psymtab.c (struct psymbol_bcache): Remove.
10777 (psymtab_storage::psymtab_storage): Update.
10778 (psymtab_storage::~psymtab_storage): Update.
10779 (psymbol_bcache_init, psymbol_bcache_free)
10780 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10781 (add_psymbol_to_bcache): Update.
10782 (allocate_psymtab): Update.
10783 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10784 macro_cache>: No longer pointers.
10785 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10786 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10787 * macrotab.c (macro_bcache): Update.
10788 * macroexp.c: Don't include bcache.h.
10789 * gdbtypes.c (check_types_worklist): Update.
10790 (types_deeply_equal): Remove TRY/CATCH. Update.
10791 * elfread.c (elf_symtab_read): Update.
10792 * dwarf2read.c: Don't include bcache.h.
10793 * buildsym.c (buildsym_compunit::get_macro_table): Update.
10794 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10795 (print_bcache_statistics, bcache_memory_used): Don't declare.
10796 (struct bcache): Move from bcache.c. Add constructor, destructor,
10797 methods. Rename all data members.
10798 * bcache.c (struct bcache): Move to bcache.h.
10799 (bcache::expand_hash_table): Rename from expand_hash_table.
10800 (bcache): Remove.
10801 (bcache::insert): Rename from bcache_full.
10802 (bcache::compare): Rename from bcache_compare.
10803 (bcache_xmalloc): Remove.
10804 (bcache::~bcache): Rename from bcache_xfree.
10805 (bcache::print_statistics): Rename from print_bcache_statistics.
10806 (bcache::memory_used): Rename from bcache_memory_used.
10807
fe726667
PA
108082019-03-07 Pedro Alves <palves@redhat.com>
10809
10810 * infrun.c (normal_stop): Also check for
10811 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10812
7584bb30
AB
108132019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
10814
10815 * f-lang.c (value_from_host_double): Moved to...
10816 * value.c (value_from_host_double): ...here.
10817 * value.h (value_from_host_double): Declare.
10818 * guile/scm-math.c (vlscm_convert_typed_number): Use
10819 value_from_host_double.
10820 (vlscm_convert_number): Likewise.
10821 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10822 * python/py-value.c (convert_value_from_python): Likewise.
10823
a7b1986e
TT
108242019-03-06 Tom Tromey <tom@tromey.com>
10825
10826 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10827
0ccf4211
TT
108282019-03-06 Tom Tromey <tom@tromey.com>
10829
10830 * utils.h (free_current_contents): Don't declare.
10831 * utils.c (free_current_contents): Remove.
10832
fe7b42e5
TT
108332019-03-06 Tom Tromey <tom@tromey.com>
10834
10835 * top.c (quit_force): Update.
10836 * main.c (captured_command_loop): Update.
10837 * common/new-op.c (operator new): Update.
10838 * common/common-exceptions.c (struct catcher)
10839 <save_cleanup_chain>: Remove member.
10840 (exceptions_state_mc_init): Update.
10841 (exception_try_scope_entry): Return nullptr.
10842 (exception_try_scope_exit, exception_rethrow)
10843 (throw_exception_sjlj, throw_exception_cxx): Update.
10844 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10845 (all_cleanups, do_cleanups, discard_cleanups)
10846 (discard_final_cleanups, save_cleanups, save_final_cleanups)
10847 (restore_cleanups, restore_final_cleanups): Don't declare.
10848 (do_final_cleanups): Remove parameter.
10849 * common/cleanups.c (cleanup_chain, make_cleanup)
10850 (make_cleanup_dtor, all_cleanups, do_cleanups)
10851 (discard_my_cleanups, discard_cleanups)
10852 (discard_final_cleanups, save_my_cleanups, save_cleanups)
10853 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10854 (null_cleanup): Remove.
10855 (do_final_cleanups): Remove parameter.
10856
c6321f19
TT
108572019-03-06 Tom Tromey <tom@tromey.com>
10858
10859 * remote.c (remote_target::remote_parse_stop_reply): Use
10860 unique_xmalloc_ptr.
10861
61b30099
TT
108622019-03-06 Tom Tromey <tom@tromey.com>
10863
10864 * stabsread.c (struct stabs_field_info): Rename from field_info.
10865 <list, fnlist>: Add initializers.
10866 <obstack>: New member.
10867 (read_member_functions, read_struct_fields, read_baseclasses):
10868 Allocate on obstack. Don't use cleanups.
10869 (read_one_struct_field, read_member_functions, read_struct_fields)
10870 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10871 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10872 (read_struct_type): Update.
10873
6cceac94
TT
108742019-03-06 Tom Tromey <tom@tromey.com>
10875
10876 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10877 * common/filestuff.h (make_cleanup_close): Don't declare.
10878 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10879 Remove.
10880
72412762
TT
108812019-03-06 Tom Tromey <tom@tromey.com>
10882
10883 * solib-aix.c: Use make_scope_exit.
10884
2b6ff1c0
TT
108852019-03-06 Tom Tromey <tom@tromey.com>
10886
10887 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10888 Use make_scope_exit.
10889
d01c5877
TT
108902019-03-06 Tom Tromey <tom@tromey.com>
10891
10892 * solib-svr4.c (disable_probes_interface): Remove parameter.
10893 (svr4_handle_solib_event): Use make_scope_exit.
10894
32603266
TT
108952019-03-06 Tom Tromey <tom@tromey.com>
10896
10897 * remote.c (struct stop_reply_deleter): Remove.
10898 (stop_reply_up): Update.
10899 (struct stop_reply): Derive from notif_event. Don't typedef.
10900 <regcache>: Now a std::vector.
10901 (stop_reply_xfree): Remove.
10902 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10903 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
10904 (remote_target::discard_pending_stop_replies): Use delete.
10905 (remote_target::remote_parse_stop_reply): Update.
10906 (remote_target::process_stop_reply): Update.
10907 * remote-notif.h (struct notif_event): Add virtual destructor.
10908 Remove "dtr" member.
10909 (struct notif_client) <alloc_event>: Return a unique_ptr.
10910 (notif_event_xfree): Don't declare.
10911 (notif_event_up): New typedef.
10912 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10913 (notif_event_xfree, do_notif_event_xfree): Remove.
10914 (remote_notif_state_xfree): Update.
10915
9799571e
TT
109162019-03-06 Tom Tromey <tom@tromey.com>
10917
10918 * infrun.c (displaced_step_clear_cleanup): Now a
10919 forward_scope_exit type.
10920 (displaced_step_prepare_throw): Update.
10921 (displaced_step_fixup): Update.
10922
09e3c4ca
TT
109232019-03-06 Tom Tromey <tom@tromey.com>
10924
10925 * inferior.h (class inferior): Update comment.
10926 * gdbthread.h (class thread_info): Update comment.
10927
e2a03548
TT
109282019-03-06 Joel Brobecker <brobecker@adacore.com>
10929 Tom Tromey <tom@tromey.com>
10930
10931 * stabsread.h (struct stab_section_list): Remove.
10932 (coffstab_build_psymtabs): Update.
10933 * dbxread.c (symbuf_sections): Now a std::vector.
10934 (sect_idx): New global.
10935 (fill_symbuf): Update.
10936 (coffstab_build_psymtabs): Change type of stabsects parameter.
10937 Update.
10938 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10939 std::vector.
10940 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10941 (coff_locate_sections): Update.
10942 (coff_symfile_read): Remove cleanups. Update.
10943 (init_stringtab): Add storage parameter.
10944 (free_stringtab, free_stringtab_cleanup): Remove.
10945 (init_lineno): Add storage parameter.
10946 (free_linetab, free_linetab_cleanup): Remove.
10947
b7e60d85
PA
109482019-03-06 Pedro Alves <palves@redhat.com>
10949
10950 * linux-fork.c (fork_info::clobber_regs): Delete.
10951 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10952 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
10953 comment. Adjust.
10954 (scoped_switch_fork_info::scoped_switch_fork_info)
10955 (checkpoint_command, linux_fork_context): Adjust
10956 fork_save_infrun_state calls.
10957
e52c971f
PA
109582019-03-06 Pedro Alves <palves@redhat.com>
10959
10960 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10961 (inf_has_multiple_threads): Return 'bool' and rewrite using
10962 inferior_info::threads().
10963
06974e6c
PA
109642019-03-06 Pedro Alves <palves@redhat.com>
10965
10966 * linux-fork.c: Include <list>.
10967 (fork_list): Now a std::list instance.
10968 (fork_info): Add ctor, dtor, and in-class initialize all fields.
10969 (forks_exist_p, find_last_fork): Adjust.
10970 (new_fork): Delete.
10971 (one_fork_p): New.
10972 (add_fork): Adjust.
10973 (free_fork): Delete, folded into fork_info::~fork_info().
10974 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10975 Adjust.
10976 (init_fork_list): Delete.
10977 (linux_fork_killall, linux_fork_mourn_inferior)
10978 (linux_fork_detach, info_checkpoints_command): Adjust.
10979 (_initialize_linux_fork): No longer call init_fork_list.
10980
72f31aea
PA
109812019-03-06 Pedro Alves <palves@redhat.com>
10982
10983 * linux-fork.c (new_fork): New, split out of ...
10984 (add_fork): ... this. Return void. Move "first fork" special
10985 case from here, to ...
10986 (checkpoint_command): ... here.
10987 * linux-linux.h (add_fork): Return void.
10988
efbecbc1
AB
109892019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10990
10991 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10992
0841c79a
AB
109932019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10994 Chris January <chris.january@arm.com>
10995 David Lecomber <david.lecomber@arm.com>
10996
10997 * f-exp.y: New token, UNOP_INTRINSIC.
10998 (exp): New pattern using UNOP_INTRINSIC token.
10999 (f77_keywords): Add 'abs' keyword.
11000 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11001 (value_from_host_double): New function.
11002 (evaluate_subexp_f): Support UNOP_ABS.
11003
4a270568
AB
110042019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11005
11006 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11007 types.
11008
067630bd
AB
110092019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11010
11011 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11012 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11013 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11014
3be47f7a
AB
110152019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11016
11017 * f-exp.y (convert_to_kind_type): Handle more type kinds.
11018
4d00f5d8
AB
110192019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11020 Chris January <chris.january@arm.com>
11021
11022 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11023 * f-exp.y: Define 'KIND' token.
11024 (exp): New pattern for KIND expressions.
11025 (ptype): Handle types with a kind extension.
11026 (direct_abs_decl): Extend to spot kind extensions.
11027 (f77_keywords): Add 'kind' to the list.
11028 (push_kind_type): New function.
11029 (convert_to_kind_type): New function.
11030 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11031 * parse.c (operator_length_standard): Likewise.
11032 * parser-defs.h (enum type_pieces): Add tp_kind.
11033 * std-operator.def: Add UNOP_KIND.
11034
e454224f
AB
110352019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11036
11037 * f-exp.y (f_parse): Set yydebug.
11038
9dad4a58
AB
110392019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11040
11041 * f-lang.c (evaluate_subexp_f): New function.
11042 (exp_descriptor_f): New global.
11043 (f_language_defn): Use exp_descriptor_f instead of
11044 exp_descriptor_standard.
11045
c8f91604
AB
110462019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11047
11048 * f-exp.y (struct token): Add comments.
11049 (dot_ops): Remove uppercase versions and the end marker.
11050 (f77_keywords): Likewise.
11051 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11052 entries in the dot_ops array are case insensitive, and use
11053 strncasecmp to compare strings. Also some whitespace cleanup in
11054 this area. Similar for the f77_keywords array, except entries in
11055 this list might be case sensitive.
11056
dd9f2c76
AB
110572019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11058
11059 * f-exp.y (struct f77_boolean_val): Add comments.
11060 (boolean_values): Remove uppercase versions, and end marker.
11061 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11062 and use strncasecmp to achieve case insensitivity. Additionally,
11063 perform whitespace cleanup around this code.
11064
67a3048c
TT
110652019-03-06 Tom Tromey <tromey@adacore.com>
11066
11067 * remote-sim.c (gdbsim_target_open): Use result of
11068 gdb_argv::release.
11069
aa3cfbda
RB
110702019-03-06 Richard Bunt <richard.bunt@arm.com>
11071 Dirk Schubert <dirk.schubert@arm.com>
11072 Chris January <chris.january@arm.com>
11073
11074 * eval.c (evaluate_subexp_standard): Call Fortran argument
11075 wrapping logic.
11076 * f-lang.c (struct value): A value which can be passed into a
11077 Fortran function call.
11078 (fortran_argument_convert): Wrap Fortran arguments in a pointer
11079 where appropriate.
11080 (struct type): Value ready for a Fortran function call.
11081 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11082 is needed.
11083 * f-lang.h (fortran_argument_convert): Declaration.
11084 (fortran_preserve_arg_pointer): Declaration.
11085 * infcall.c (value_arg_coerce): Call Fortran argument logic.
11086
ea38e5df
TT
110872019-03-05 Tom Tromey <tromey@adacore.com>
11088
11089 * python/py-prettyprint.c (print_string_repr): Remove #if.
11090 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11091
06b5b831
TT
110922019-03-05 Tom Tromey <tromey@adacore.com>
11093
11094 * target.c (the_dummy_target): Move later. Change type to
11095 "dummy_target".
11096 (initialize_targets): Don't initialize the_dummy_target.
11097
edbd9e45
TT
110982019-03-05 Tom Tromey <tromey@adacore.com>
11099
11100 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11101 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11102
c119e040
TT
111032019-03-05 Tom Tromey <tromey@adacore.com>
11104
11105 * windows-nat.c (windows_nat_target::attach)
11106 (windows_nat_target::detach): Don't call gdb_flush.
11107 * valprint.c (generic_val_print, val_print, val_print_string):
11108 Don't call gdb_flush.
11109 * utils.c (defaulted_query): Don't call gdb_flush.
11110 * typeprint.c (print_type_scalar): Don't call gdb_flush.
11111 * target.c (target_announce_detach): Don't call gdb_flush.
11112 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11113 * remote.c (extended_remote_target::attach): Don't call
11114 gdb_flush.
11115 * procfs.c (procfs_target::detach): Don't call gdb_flush.
11116 * printcmd.c (do_examine): Don't call gdb_flush.
11117 (info_display_command): Don't call gdb_flush.
11118 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11119 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11120 * memattr.c (info_mem_command): Don't call gdb_flush.
11121 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11122 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11123 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11124 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11125 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11126 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11127 (gnu_nat_target::detach): Don't call gdb_flush.
11128 * f-valprint.c (f_val_print): Don't call gdb_flush.
11129 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11130 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11131 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11132 gdb_flush.
11133 * c-valprint.c (c_val_print): Don't call gdb_flush.
11134 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11135
895dafa6
TT
111362019-03-05 Tom Tromey <tromey@adacore.com>
11137
11138 * varobj.c (update_dynamic_varobj_children): Update.
11139 (install_default_visualizer): Use reset, not release.
11140 * value.c (set_internalvar): Update.
11141 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11142 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11143 ATTRIBUTE_UNUSED_RESULT.
11144
88a774b9
TT
111452019-03-05 Tom Tromey <tromey@adacore.com>
11146
11147 * remote.c (class scoped_remote_fd) <release>: Add
11148 ATTRIBUTE_UNUSED_RESULT.
11149
4e4a8b93
TT
111502019-03-05 Tom Tromey <tromey@adacore.com>
11151
11152 * macroexp.c (struct macro_buffer) <release>: Add
11153 ATTRIBUTE_UNUSED_RESULT.
11154
083eef1f
TT
111552019-03-05 Tom Tromey <tromey@adacore.com>
11156
11157 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11158 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11159 ATTRIBUTE_UNUSED_RESULT.
11160
3cabd438
TT
111612019-03-05 Tom Tromey <tromey@adacore.com>
11162
11163 * common/scoped_fd.h (class scoped_fd) <release>: Add
11164 ATTRIBUTE_UNUSED_RESULT.
11165
41e3300a
TT
111662019-03-05 Tom Tromey <tromey@adacore.com>
11167
11168 * parser-defs.h (struct parser_state) <release>: Add
11169 ATTRIBUTE_UNUSED_RESULT.
11170
18cb7c9f
TT
111712019-03-05 Tom Tromey <tromey@adacore.com>
11172
11173 * utils.h (class gdb_argv) <release>: Add
11174 ATTRIBUTE_UNUSED_RESULT.
11175 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11176
41fa577f
EZ
111772019-03-02 Eli Zaretskii <eliz@gnu.org>
11178
a6a4b2c6
EZ
11179 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11180 for-loop range, to avoid compiler warnings.
11181
11182 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11183 avoid compiler warnings about unused variables.
11184
742a7df5
EZ
11185 * NEWS: Mention end of support for native debugging on MS-Windows
11186 before XP.
11187
41fa577f
EZ
11188 PR gdb/24292
11189 * common/netstuff.c:
11190 * gdbserver/gdbreplay.c
11191 * gdbserver/remote-utils.c:
11192 * ser-tcp.c:
11193 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11194 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
11195 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11196 'getaddrinfo' and 'freeaddrinfo' were not available before
11197 Windows XP, and mingw.org's MinGW headers by default define
11198 _WIN32_WINNT to 0x500.
11199
827f438f
GB
112002019-03-01 Gary Benson <gbenson@redhat.com>
11201
11202 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11203
92137da0
RO
112042019-02-28 Brian Vandenberg <phantall@gmail.com>
11205 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
11206
11207 PR gdb/8527
11208 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11209 set_sigint_trap, clear_sigint_trap.
11210
799efbe8
PW
112112019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11212
11213 * target.c (target_detach): Clear the regcache and the
11214 frame cache.
11215
8ed25214
PA
112162019-02-27 Pedro Alves <palves@redhat.com>
11217
11218 * utils.c (set_screen_size): When we cap the height/width sizes,
11219 tweak the corresponding command variable to show "unlimited":
11220
23031e31
SJ
112212019-02-27 Saagar Jha <saagar@saagarjha.com>
11222 Pedro Alves <palves@redhat.com>
11223
11224 * utils.c (set_screen_size): Reduce "infinite" rows and columns
11225 before calling rl_set_screen_size.
11226
6c28e44a
TT
112272019-02-27 Tom Tromey <tromey@adacore.com>
11228
11229 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11230 define.
11231 * python/py-value.c: Remove Python 2.4 workaround.
11232 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11233 workaround.
11234 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11235 Python 2.4 workaround.
11236 * python/python-internal.h: Remove Python 2.4 comment.
11237 (Py_ssize_t): Don't define.
11238 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11239 (gdb_Py_DECREF): Remove Python 2.4 workaround.
11240 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11241 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11242 * python/python.c (do_start_initialization): Remove Python 2.4
11243 workaround.
11244 * python/py-prettyprint.c (class dummy_python_frame): Remove.
11245 (print_children): Remove Python 2.4 workaround.
11246 * python/py-inferior.c (buffer_procs): Remove Python 2.4
11247 workaround.
11248 (CHARBUFFERPROC_NAME): Remove.
11249 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11250 Python 2.4 workaround.
11251
2c3fc25d 112522019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 11253
2c3fc25d
KB
11254 * NEWS: Note minimum Python version.
11255
6ca62222
KB
112562019-02-27 Kevin Buettner <kevinb@redhat.com>
11257
11258 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11259 code from these functions. Remove corresponding ifdefs. Use
11260 Py_buffer_up instead of explicit calls to PyBuffer_Release.
11261 Remove gotos and target of gotos.
11262 (infpy_search_memory): Likewise.
11263
f4bc7d2c
AB
112642019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11265
11266 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11267 (hppa_gdbarch_init): Don't register deleted functions with
11268 gdbarch.
11269
9734a586
AB
112702019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11271
11272 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11273 (h8300_unwind_sp): Delete.
11274 (h8300_dummy_id): Delete.
11275 (h8300_gdbarch_init): Don't register deleted functions with
11276 gdbarch.
11277
68b867f3
AB
112782019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11279
11280 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11281 (ft32_unwind_pc): Delete.
11282 (ft32_unwind_sp): Delete.
11283 (ft32_gdbarch_init): Don't register deleted functions with
11284 gdbarch.
11285
2fbe7ad0
AB
112862019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11287
11288 * gdb/frv-tdep.c (frv_dummy_id): Delete.
11289 (frv_unwind_pc): Delete.
11290 (frv_unwind_sp): Delete.
11291 (frv_gdbarch_init): Don't register deleted functions with
11292 gdbarch.
11293
76055cbe
AB
112942019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11295
11296 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11297 (riscv_unwind_pc): Delete.
11298 (riscv_unwind_sp): Delete.
11299 (riscv_gdbarch_init): Don't register deleted functions with
11300 gdbarch.
11301
4133e5a1
AB
113022019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11303
11304 * gdb/csky-tdep.c (csky_dummy_id): Delete.
11305 (csky_unwind_pc): Delete.
11306 (csky_unwind_sp): Delete.
11307 (csky_gdbarch_init): Don't register deleted functions with
11308 gdbarch.
11309
8010f576
AB
113102019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11311
11312 * gdb/cris-tdep.c (cris_dummy_id): Delete.
11313 (cris_unwind_pc): Delete.
11314 (cris_unwind_sp): Delete.
11315 (cris_gdbarch_init): Don't register deleted functions with
11316 gdbarch.
11317
b56bf084
AB
113182019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11319
11320 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11321 (bfin_unwind_pc): Delete.
11322 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11323
a19a650f
AB
113242019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11325
11326 * gdb/arm-tdep.c (arm_dummy_id): Delete.
11327 (arm_unwind_pc): Delete.
11328 (arm_unwind_sp): Delete.
11329 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11330
f8278c3c
AB
113312019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11332
11333 * gdb/arc-tdep.c (arc_dummy_id): Delete.
11334 (arc_unwind_pc): Delete.
11335 (arc_unwind_sp): Delete.
11336 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11337
480e46cf
AB
113382019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11339
11340 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11341 (alpha_unwind_pc): Delete.
11342 (alpha_gdbarch_init): Don't register deleted functions with
11343 gdbarch.
11344
7a995095
AB
113452019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11346
11347 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11348 (aarch64_unwind_pc): Delete.
11349 (aarch64_unwind_sp): Delete.
11350 (aarch64_gdbarch_init): Don't register deleted functions with
11351 gdbarch.
11352
bf9a735e
AB
113532019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11354
11355 * gdbtypes.c (type_align): Don't consider static members when
11356 computing structure alignment.
11357
5561fc30
AB
113582019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11359
11360 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11361 return 0 for other types.
11362 * arch-utils.c (default_type_align): Always return 0.
11363 * gdbarch.h: Regenerate.
11364 * gdbarch.sh (type_align): Extend comment.
11365 * gdbtypes.c (type_align): Add additional comments, always call
11366 gdbarch_type_align before applying the default rules.
11367 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11368 generic code will then apply a suitable default.
11369 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11370 types, return 0 for other types.
11371
9335e75a
JB
113722019-02-27 Joel Brobecker <brobecker@adacore.com>
11373
11374 * NEWS: Create a new section for the next release branch.
11375 Rename the section of the current branch, now that it has
11376 been cut.
11377
3d34d8de
JB
113782019-02-27 Joel Brobecker <brobecker@adacore.com>
11379
11380 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11381 * version.in: Bump version to 8.3.50.DATE-git.
11382
143420fb
SM
113832019-02-26 Simon Marchi <simon.marchi@efficios.com>
11384
11385 * aix-thread.c (ptid_cmp): Remove unused variable.
11386 (get_signaled_thread): Likewise.
11387 (store_regs_user_thread): Likewise.
11388 (store_regs_kernel_thread): Likewise.
11389 (fetch_regs_kernel_thread): Remove shadowed variable.
11390
172fb711
AB
113912019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
11392
11393 * features/riscv/32bit-cpu.xml: Add register numbers.
11394 * features/riscv/32bit-fpu.c: Regenerate.
11395 * features/riscv/32bit-fpu.xml: Add register numbers.
11396 * features/riscv/64bit-cpu.xml: Add register numbers.
11397 * features/riscv/64bit-fpu.c: Regenerate.
11398 * features/riscv/64bit-fpu.xml: Add register numbers.
11399
26c89782
KB
114002019-02-26 Kevin Buettner <kevinb@redhat.com>
11401
af54ade9 11402 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
11403 * python/py-value.c (convert_buffer_and_type_to_value): New
11404 function.
11405 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11406 Add support for handling an optional second argument. Call
11407 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
11408 * python/python-internal.h (Py_buffer_deleter): New struct.
11409 (Py_buffer_up): New typedef.
11410
0f58c9e8
JB
114112019-02-25 John Baldwin <jhb@FreeBSD.org>
11412
11413 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11414 instead of releasing ownership.
11415
0a0f4c01
JR
114162019-02-25 Jordan Rupprecht <rupprecht@google.com>
11417
11418 * dwarf2read.c (open_and_init_dwp_file): Call
11419 elf_numsections instead of bfd_count_sections to initialize
11420 dwp_file->num_sections.
11421
cd5a152c
TT
114222019-02-25 Tom Tromey <tromey@adacore.com>
11423
11424 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11425
8a6a8513
SDJ
114262019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
11427
11428 * gcore.in: Add '--readnever' option when invoking GDB.
11429
04dcda9c
SM
114302019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11431
11432 * MAINTAINERS: Update my email address.
11433
07bc701d
SM
114342019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11435
11436 * build-id.c (build_id_to_debug_bfd_1): New function.
11437 (build_id_to_debug_bfd): Look for separate debug file in
11438 sysroot.
11439
c6f4a5d0
AB
114402019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
11441
11442 * gdbarch.sh: Update the copyright year range that is placed into
11443 generated files.
11444
9600246d
KS
114452019-02-22 Keith Seitz <keiths@redhat.com>
11446
11447 PR symtab/23853
11448 * linespec.c (create_sals_line_offset): Search for the default
11449 symtab's filename instead of its fullname.
11450
7557a514
AH
114512019-02-21 Alan Hayward <alan.hayward@arm.com>
11452
11453 * NEWS: Update style defaults.
11454
ee2bcb0c
AH
114552019-02-21 Alan Hayward <alan.hayward@arm.com>
11456
11457 * main.c (captured_main_1): Disable styling in batch mode.
11458
0c95f9ed
TT
114592019-02-20 Tom Tromey <tom@tromey.com>
11460
11461 * symtab.c (symtab_symbol_info): Fix typos.
11462
c763b894
TT
114632019-02-20 Tom Tromey <tromey@adacore.com>
11464
11465 * findcmd.c (_initialize_mem_search): Use upper case for
11466 metasyntactic variables.
11467
0ef8a082
AH
114682019-02-20 Alan Hayward <alan.hayward@arm.com>
11469
11470 * aarch64-tdep.c (aarch64_add_reggroups): New function.
11471 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11472
6caa91b6
SM
114732019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
11474
11475 * top.h (source_file_name): Change to std::string.
11476 * top.c (source_file_name): Likewise.
11477 (command_line_input): Adjust.
11478 * cli/cli-script.c (script_from_file): Adjust.
11479
98814c6c
TT
114802019-02-19 Tom Tromey <tromey@adacore.com>
11481
11482 * ravenscar-thread.c
11483 (ravenscar_thread_target::update_thread_list): Don't call
11484 ada_build_task_list.
11485 * ada-lang.h (ada_build_task_list): Don't declare.
11486 * ada-tasks.c (struct ada_tasks_inferior_data)
11487 <task_list_valid_p>: Now bool.
11488 (read_known_tasks, ada_task_list_changed)
11489 (ada_tasks_invalidate_inferior_data): Update.
11490 (read_known_tasks_array): Return bool.
11491 (read_known_tasks_list): Likewise.
11492 (read_known_tasks): Return void.
11493 (ada_build_task_list): Now static.
11494
70cd633e
AB
114952019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
11496
11497 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11498 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11499
040b3e95
PW
115002019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11501
11502 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11503 variant for ada_tasks_pspace_data_handle and
11504 ada_tasks_inferior_data_handle.
11505 (ada_tasks_pspace_data_cleanup): New function.
11506 (ada_tasks_inferior_data_cleanup): New function.
11507
9409233b
TT
115082019-02-17 Tom Tromey <tom@tromey.com>
11509
11510 * macrotab.h (macro_source_fullname): Return a std::string.
11511 * macrotab.c (macro_include, check_for_redefinition)
11512 (macro_undef, macro_lookup_definition, foreach_macro)
11513 (foreach_macro_in_scope): Update.
11514 (macro_source_fullname): Return a std::string.
11515 * macrocmd.c (show_pp_source_pos): Update.
11516
6506371f
TT
115172019-02-17 Tom Tromey <tom@tromey.com>
11518
11519 * macrocmd.c (show_pp_source_pos): Style the file names.
11520
0c820d67
TT
115212019-02-17 Tom Tromey <tom@tromey.com>
11522
11523 PR tui/24197:
11524 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11525
a0087920
TT
115262019-02-17 Tom Tromey <tom@tromey.com>
11527
11528 * ada-lang.c (user_select_syms): Use filtered printing.
11529 * utils.c (wrap_style): New global.
11530 (desired_style): Remove.
11531 (emit_style_escape): Add stream parameter.
11532 (set_output_style, reset_terminal_style, prompt_for_continue):
11533 Update.
11534 (flush_wrap_buffer): Only flush gdb_stdout.
11535 (wrap_here): Set wrap_style.
11536 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
11537 treat escape sequences as a character. Change when wrap buffer is
11538 flushed.
11539 (fputs_styled): Do not set the output style when the default is
11540 requested.
11541 * ui-style.h (struct ui_file_style) <is_default>: New method.
11542 * source.c (print_source_lines_base): Emit escape sequences in one
11543 piece.
11544
75ba10dc
JB
115452019-02-17 Joel Brobecker <brobecker@adacore.com>
11546
11547 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11548 integers and enumeration types.
11549
a2cd4f14
JB
115502019-02-17 Joel Brobecker <brobecker@adacore.com>
11551
11552 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11553 instead of lookup_symbol_in_language
11554 (do_exact_match): New function.
11555 (ada_get_symbol_name_matcher): Return do_exact_match when
11556 doing a verbatim match.
11557
485b851b
TT
115582019-02-15 Tom Tromey <tromey@adacore.com>
11559
11560 * ravenscar-thread.c (ravenscar_thread_target::resume)
11561 (ravenscar_thread_target::wait): Special case wildcard requests.
11562
0b790b1e
TT
115632019-02-15 Tom Tromey <tromey@adacore.com>
11564
11565 * ravenscar-thread.c (base_ptid): Remove.
11566 (struct ravenscar_thread_target) <close>: New method.
11567 <m_base_ptid>: New member.
11568 <update_inferior_ptid, active_task, task_is_currently_active,
11569 runtime_initialized>: Declare methods.
11570 <ravenscar_thread_target>: Add constructor.
11571 (ravenscar_thread_target::task_is_currently_active)
11572 (ravenscar_thread_target::update_inferior_ptid)
11573 (ravenscar_runtime_initialized): Rename. Now methods.
11574 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11575 (ravenscar_thread_target::update_thread_list): Update.
11576 (ravenscar_thread_target::active_task): Now method.
11577 (ravenscar_thread_target::store_registers)
11578 (ravenscar_thread_target::prepare_to_store)
11579 (ravenscar_thread_target::prepare_to_store)
11580 (ravenscar_thread_target::mourn_inferior): Update.
11581 (ravenscar_inferior_created): Use "new" to create target.
11582 (ravenscar_thread_target::get_ada_task_ptid): Update.
11583 (_initialize_ravenscar): Don't initialize base_ptid.
11584 (ravenscar_ops): Remove global.
11585
dea57a62
TT
115862019-02-15 Tom Tromey <tromey@adacore.com>
11587
11588 * target.h (push_target): Declare new overload.
11589 * target.c (push_target): New overload, taking an rvalue reference.
11590 * remote.c (remote_target::open_1): Use push_target overload.
11591 * corelow.c (core_target_open): Use push_target overload.
11592
989f3c58
TT
115932019-02-15 Tom Tromey <tromey@adacore.com>
11594
11595 * ravenscar-thread.c (is_ravenscar_task)
11596 (ravenscar_task_is_currently_active): Return bool.
11597 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11598 (_initialize_ravenscar): Remove "(void)".
11599 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11600 Return bool.
11601
6cbcc006
TT
116022019-02-15 Tom Tromey <tromey@adacore.com>
11603
11604 * ravenscar-thread.c (ravenscar_runtime_initializer)
11605 (has_ravenscar_runtime, get_running_thread_id)
11606 (ravenscar_thread_target::resume): Fix indentation.
11607
7657f14d
TT
116082019-02-15 Tom Tromey <tromey@adacore.com>
11609
11610 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11611 from ravenscar_arch_ops.
11612 (sparc_ravenscar_ops::fetch_registers)
11613 (sparc_ravenscar_ops::store_registers): Now methods.
11614 (sparc_ravenscar_prepare_to_store): Remove.
11615 (sparc_ravenscar_ops): Redefine.
11616 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11617 methods and destructor. Remove members.
11618 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11619 (ravenscar_thread_target::store_registers)
11620 (ravenscar_thread_target::prepare_to_store): Update.
11621 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11622 Remove.
11623 (struct ppc_ravenscar_powerpc_ops): Derive from
11624 ravenscar_arch_ops.
11625 (ppc_ravenscar_powerpc_ops::fetch_registers)
11626 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11627 (ppc_ravenscar_powerpc_ops): Redefine.
11628 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11629 (ppc_ravenscar_e500_ops::fetch_registers)
11630 (ppc_ravenscar_e500_ops::store_registers): Now methods.
11631 (ppc_ravenscar_e500_ops): Redefine.
11632 * aarch64-ravenscar-thread.c
11633 (aarch64_ravenscar_generic_prepare_to_store): Remove.
11634 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11635 (aarch64_ravenscar_fetch_registers)
11636 (aarch64_ravenscar_store_registers): Now methods.
11637 (aarch64_ravenscar_ops): Redefine.
11638
5b6ea500
TT
116392019-02-15 Tom Tromey <tromey@adacore.com>
11640
11641 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11642 (ravenscar_thread_target::stopped_by_hw_breakpoint)
11643 (ravenscar_thread_target::stopped_by_watchpoint)
11644 (ravenscar_thread_target::stopped_data_address)
11645 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11646
e397fd39
TT
116472019-02-15 Tom Tromey <tromey@adacore.com>
11648
11649 * ravenscar-thread.c: Fix some typos.
11650
cc12f4a8
TT
116512019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11652 Tom Tromey <tromey@adacore.com>
11653
11654 * ada-lang.c (ada_exception_sal): Change addr_string to a
11655 std::string.
11656 (create_ada_exception_catchpoint): Update.
11657
5f486660
TT
116582019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11659 Tom Tromey <tromey@adacore.com>
11660
11661 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11662 (bp_location_ops): Remove.
11663 (base_breakpoint_allocate_location): Update.
11664 (free_bp_location): Update.
11665 * ada-lang.c (class ada_catchpoint_location)
11666 <ada_catchpoint_location>: Remove ops parameter.
11667 (ada_catchpoint_location_dtor): Remove.
11668 (ada_catchpoint_location_ops): Remove.
11669 (allocate_location_exception): Update.
11670 * breakpoint.h (struct bp_location_ops): Remove.
11671 (class bp_location) <bp_location>: Remove bp_location_ops
11672 parameter.
11673 <~bp_location>: Add destructor.
11674 <ops>: Remove.
11675
b671c7fb
TS
116762019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11677 Pedro Alves <palves@redhat.com>
11678
11679 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11680 'PATH_MAX'.
11681
8071c5ce
DM
116822019-02-14 David Michael <fedora.dm0@gmail.com>
11683 Samuel Thibault <samuel.thibault@gnu.org>
11684 Thomas Schwinge <thomas@codesourcery.com>
11685
11686 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11687 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11688
b1041ae0
TS
116892019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11690
924514e1
TS
11691 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11692 (check_empty): Use "const char *".
11693
c29ee8d4
TS
11694 * gnu-nat.c (gnu_nat_target::detach): Instead of
11695 'detach_inferior (pid)' call
11696 'detach_inferior (find_inferior_pid (pid))'.
11697
6c6ef69f
TS
11698 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11699 'nat/fork-inferior.o'.
11700 * gnu-nat.c: #include "nat/fork-inferior.h".
11701
2d0a338c
TS
11702 * gnu-nat.c (gnu_nat_target::detach): Instead of
11703 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11704 * gnu-nat.h: #include "inf-child.h".
11705 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11706 'i386_gnu_nat_target::fetch_registers'.
11707 (gnu_store_registers): Rename/move to
11708 'i386_gnu_nat_target::store_registers'.
11709
cabb5f06
TS
11710 * config/i386/nm-i386gnu.h: Don't "#include" any files.
11711 * gnu-nat.h (mach_thread_info): New function.
11712 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11713
b1041ae0
TS
11714 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11715
2988d01e
KF
117162019-02-14 Frederic Konrad <konrad@adacore.com>
11717
11718 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11719
c559d709
JB
117202019-02-14 Joel Brobecker <brobecker@adacore.com>
11721
11722 * windows-nat.c (windows_add_thread): Add new parameter
11723 "main_thread_p" with default value set to false. Update
11724 function documentation as well as all callers.
11725 (windows_delete_thread): Likewise.
11726 (fake_create_process): Update call to windows_add_thread.
11727 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11728 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11729 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11730 call to windows_delete_thread.
11731
007024cc
SM
117322019-02-13 Simon Marchi <simon.marchi@ericsson.com>
11733
11734 * MAINTAINERS: Add Andrew Burgess as global maintainer.
11735
f62318e9
JB
117362019-02-12 John Baldwin <jhb@FreeBSD.org>
11737
11738 * symfile.c (find_separate_debug_file): Use canonical path of
11739 sysroot with child_path instead of gdb_sysroot if it is valid.
11740
cd4b7848
JB
117412019-02-12 John Baldwin <jhb@FreeBSD.org>
11742
11743 * symfile.c (find_separate_debug_file): Use child_path to
11744 determine if an object file is under a sysroot.
11745
efac4bfe
JB
117462019-02-12 John Baldwin <jhb@FreeBSD.org>
11747
11748 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11749 unittests/child-path-selftests.c.
11750 * common/pathstuff.c (child_path): New function.
11751 * common/pathstuff.h (child_path): New prototype.
11752 * unittests/child-path-selftests.c: New file.
11753
402d2bfe
JB
117542019-02-12 John Baldwin <jhb@FreeBSD.org>
11755
11756 * symfile.c (find_separate_debug_file): Look for separate debug
11757 files in debug directories under the sysroot.
11758
1ed9f74e
PW
117592019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11760
11761 * symtab.h (struct minimal_symbol data_p): New const method.
11762 (struct minimal_symbol text_p): Likewise.
11763 * symtab.c (output_source_filename): Use file name style
11764 to print file name.
11765 (print_symbol_info): Likewise.
11766 (print_msymbol_info): Use address style to print addresses.
11767 Use function name style to print executable text symbols.
11768 (expand_symtab_containing_pc): Use data_p.
11769 (find_pc_sect_compunit_symtab): Likewise.
11770
2636d81d
PW
117712019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11772
11773 * breakpoint.c (describe_other_breakpoints): Use address style
11774 to print addresses.
11775 (say_where): Likewise.
11776
ac8c53cc
PW
117772019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11778
11779 * ada-typeprint.c (print_func_type): Print function name
11780 style to print function name.
11781 * c-typeprint.c (c_print_type_1): Likewise.
11782
ea638c43
AH
117832019-02-11 Alan Hayward <alan.hayward@arm.com>
11784
11785 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11786 for execve.
11787
ab759ca8
PW
117882019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11789
11790 * c-exp.y (direct_abs_decl): Use emplace_back to record the
11791 type_stack.
11792
aff29d1c
JB
117932019-02-10 Joel Brobecker <brobecker@adacore.com>
11794
11795 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11796 TYPE_CODE_REF types.
11797
617126bc
JW
117982019-02-08 Jim Wilson <jimw@sifive.com>
11799
11800 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11801 (riscv_linux_fregset): New.
11802 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11803
46e3ed7f
TT
118042019-02-07 Tom Tromey <tom@tromey.com>
11805
11806 * thread.c (thread_cancel_execution_command): Update.
11807 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11808 methods.
11809 (struct thread_fsm_ops): Remove.
11810 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11811 (thread_fsm_should_stop, thread_fsm_return_value)
11812 (thread_fsm_set_finished, thread_fsm_finished_p)
11813 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11814 Don't declare.
11815 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11816 * infrun.c (clear_proceed_status_thread)
11817 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11818 (print_stop_event): Update.
11819 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11820 Add constructor.
11821 (step_command_fsm_ops): Remove.
11822 (new_step_command_fsm): Remove.
11823 (step_1): Update.
11824 (step_command_fsm::should_stop): Rename from
11825 step_command_fsm_should_stop.
11826 (step_command_fsm::clean_up): Rename from
11827 step_command_fsm_clean_up.
11828 (step_command_fsm::do_async_reply_reason): Rename from
11829 step_command_fsm_async_reply_reason.
11830 (struct until_next_fsm): Inherit from thread_fsm. Add
11831 constructor.
11832 (until_next_fsm_ops): Remove.
11833 (new_until_next_fsm): Remove.
11834 (until_next_fsm::should_stop): Rename from
11835 until_next_fsm_should_stop.
11836 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11837 (until_next_fsm::do_async_reply_reason): Rename from
11838 until_next_fsm_async_reply_reason.
11839 (struct finish_command_fsm): Inherit from thread_fsm. Add
11840 constructor. Change type of breakpoint.
11841 (finish_command_fsm_ops): Remove.
11842 (new_finish_command_fsm): Remove.
11843 (finish_command_fsm::should_stop): Rename from
11844 finish_command_fsm_should_stop.
11845 (finish_command_fsm::clean_up): Rename from
11846 finish_command_fsm_clean_up.
11847 (finish_command_fsm::return_value): Rename from
11848 finish_command_fsm_return_value.
11849 (finish_command_fsm::do_async_reply_reason): Rename from
11850 finish_command_fsm_async_reply_reason.
11851 (finish_command): Update.
11852 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11853 Add constructor.
11854 (call_thread_fsm_ops): Remove.
11855 (call_thread_fsm::call_thread_fsm): Rename from
11856 new_call_thread_fsm.
11857 (call_thread_fsm::should_stop): Rename from
11858 call_thread_fsm_should_stop.
11859 (call_thread_fsm::should_notify_stop): Rename from
11860 call_thread_fsm_should_notify_stop.
11861 (run_inferior_call, call_function_by_hand_dummy): Update.
11862 * cli/cli-interp.c (should_print_stop_to_console): Update.
11863 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11864 Add constructor. Change type of location_breakpoint,
11865 caller_breakpoint.
11866 (until_break_fsm_ops): Remove.
11867 (new_until_break_fsm): Remove.
11868 (until_break_fsm::should_stop): Rename from
11869 until_break_fsm_should_stop.
11870 (until_break_fsm::clean_up): Rename from
11871 until_break_fsm_clean_up.
11872 (until_break_fsm::do_async_reply_reason): Rename from
11873 until_break_fsm_async_reply_reason.
11874 (until_break_command): Update.
11875 * thread-fsm.c: Remove.
11876 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11877
1a5c2598
TT
118782019-02-07 Tom Tromey <tom@tromey.com>
11879
11880 * yy-remap.h: Add include guard.
11881 * xtensa-tdep.h: Add include guard.
11882 * xcoffread.h: Rename include guard.
11883 * varobj-iter.h: Add include guard.
11884 * tui/tui.h: Rename include guard.
11885 * tui/tui-winsource.h: Rename include guard.
11886 * tui/tui-wingeneral.h: Rename include guard.
11887 * tui/tui-windata.h: Rename include guard.
11888 * tui/tui-win.h: Rename include guard.
11889 * tui/tui-stack.h: Rename include guard.
11890 * tui/tui-source.h: Rename include guard.
11891 * tui/tui-regs.h: Rename include guard.
11892 * tui/tui-out.h: Rename include guard.
11893 * tui/tui-layout.h: Rename include guard.
11894 * tui/tui-io.h: Rename include guard.
11895 * tui/tui-hooks.h: Rename include guard.
11896 * tui/tui-file.h: Rename include guard.
11897 * tui/tui-disasm.h: Rename include guard.
11898 * tui/tui-data.h: Rename include guard.
11899 * tui/tui-command.h: Rename include guard.
11900 * tic6x-tdep.h: Add include guard.
11901 * target/waitstatus.h: Rename include guard.
11902 * target/wait.h: Rename include guard.
11903 * target/target.h: Rename include guard.
11904 * target/resume.h: Rename include guard.
11905 * target-float.h: Rename include guard.
11906 * stabsread.h: Add include guard.
11907 * rs6000-tdep.h: Add include guard.
11908 * riscv-fbsd-tdep.h: Add include guard.
11909 * regformats/regdef.h: Rename include guard.
11910 * record.h: Rename include guard.
11911 * python/python.h: Rename include guard.
11912 * python/python-internal.h: Rename include guard.
11913 * python/py-stopevent.h: Rename include guard.
11914 * python/py-ref.h: Rename include guard.
11915 * python/py-record.h: Rename include guard.
11916 * python/py-record-full.h: Rename include guard.
11917 * python/py-record-btrace.h: Rename include guard.
11918 * python/py-instruction.h: Rename include guard.
11919 * python/py-events.h: Rename include guard.
11920 * python/py-event.h: Rename include guard.
11921 * procfs.h: Add include guard.
11922 * proc-utils.h: Add include guard.
11923 * p-lang.h: Add include guard.
11924 * or1k-tdep.h: Rename include guard.
11925 * observable.h: Rename include guard.
11926 * nto-tdep.h: Rename include guard.
11927 * nat/x86-linux.h: Rename include guard.
11928 * nat/x86-linux-dregs.h: Rename include guard.
11929 * nat/x86-gcc-cpuid.h: Add include guard.
11930 * nat/x86-dregs.h: Rename include guard.
11931 * nat/x86-cpuid.h: Rename include guard.
11932 * nat/ppc-linux.h: Rename include guard.
11933 * nat/mips-linux-watch.h: Rename include guard.
11934 * nat/linux-waitpid.h: Rename include guard.
11935 * nat/linux-ptrace.h: Rename include guard.
11936 * nat/linux-procfs.h: Rename include guard.
11937 * nat/linux-osdata.h: Rename include guard.
11938 * nat/linux-nat.h: Rename include guard.
11939 * nat/linux-namespaces.h: Rename include guard.
11940 * nat/linux-btrace.h: Rename include guard.
11941 * nat/glibc_thread_db.h: Rename include guard.
11942 * nat/gdb_thread_db.h: Rename include guard.
11943 * nat/gdb_ptrace.h: Rename include guard.
11944 * nat/fork-inferior.h: Rename include guard.
11945 * nat/amd64-linux-siginfo.h: Rename include guard.
11946 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11947 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11948 * nat/aarch64-linux.h: Rename include guard.
11949 * nat/aarch64-linux-hw-point.h: Rename include guard.
11950 * mn10300-tdep.h: Add include guard.
11951 * mips-linux-tdep.h: Add include guard.
11952 * mi/mi-parse.h: Rename include guard.
11953 * mi/mi-out.h: Rename include guard.
11954 * mi/mi-main.h: Rename include guard.
11955 * mi/mi-interp.h: Rename include guard.
11956 * mi/mi-getopt.h: Rename include guard.
11957 * mi/mi-console.h: Rename include guard.
11958 * mi/mi-common.h: Rename include guard.
11959 * mi/mi-cmds.h: Rename include guard.
11960 * mi/mi-cmd-break.h: Rename include guard.
11961 * m2-lang.h: Add include guard.
11962 * location.h: Rename include guard.
11963 * linux-record.h: Rename include guard.
11964 * linux-nat.h: Add include guard.
11965 * linux-fork.h: Add include guard.
11966 * i386-darwin-tdep.h: Rename include guard.
11967 * hppa-linux-offsets.h: Add include guard.
11968 * guile/guile.h: Rename include guard.
11969 * guile/guile-internal.h: Rename include guard.
11970 * gnu-nat.h: Rename include guard.
11971 * gdb-stabs.h: Rename include guard.
11972 * frv-tdep.h: Add include guard.
11973 * f-lang.h: Add include guard.
11974 * event-loop.h: Add include guard.
11975 * darwin-nat.h: Rename include guard.
11976 * cp-abi.h: Rename include guard.
11977 * config/sparc/nm-sol2.h: Rename include guard.
11978 * config/nm-nto.h: Rename include guard.
11979 * config/nm-linux.h: Add include guard.
11980 * config/i386/nm-i386gnu.h: Rename include guard.
11981 * config/djgpp/nl_types.h: Rename include guard.
11982 * config/djgpp/langinfo.h: Rename include guard.
11983 * compile/gcc-cp-plugin.h: Add include guard.
11984 * compile/gcc-c-plugin.h: Add include guard.
11985 * compile/compile.h: Rename include guard.
11986 * compile/compile-object-run.h: Rename include guard.
11987 * compile/compile-object-load.h: Rename include guard.
11988 * compile/compile-internal.h: Rename include guard.
11989 * compile/compile-cplus.h: Rename include guard.
11990 * compile/compile-c.h: Rename include guard.
11991 * common/xml-utils.h: Rename include guard.
11992 * common/x86-xstate.h: Rename include guard.
11993 * common/version.h: Rename include guard.
11994 * common/vec.h: Rename include guard.
11995 * common/tdesc.h: Rename include guard.
11996 * common/selftest.h: Rename include guard.
11997 * common/scoped_restore.h: Rename include guard.
11998 * common/scoped_mmap.h: Rename include guard.
11999 * common/scoped_fd.h: Rename include guard.
12000 * common/safe-iterator.h: Rename include guard.
12001 * common/run-time-clock.h: Rename include guard.
12002 * common/refcounted-object.h: Rename include guard.
12003 * common/queue.h: Rename include guard.
12004 * common/ptid.h: Rename include guard.
12005 * common/print-utils.h: Rename include guard.
12006 * common/preprocessor.h: Rename include guard.
12007 * common/pathstuff.h: Rename include guard.
12008 * common/observable.h: Rename include guard.
12009 * common/netstuff.h: Rename include guard.
12010 * common/job-control.h: Rename include guard.
12011 * common/host-defs.h: Rename include guard.
12012 * common/gdb_wait.h: Rename include guard.
12013 * common/gdb_vecs.h: Rename include guard.
12014 * common/gdb_unlinker.h: Rename include guard.
12015 * common/gdb_unique_ptr.h: Rename include guard.
12016 * common/gdb_tilde_expand.h: Rename include guard.
12017 * common/gdb_sys_time.h: Rename include guard.
12018 * common/gdb_string_view.h: Rename include guard.
12019 * common/gdb_splay_tree.h: Rename include guard.
12020 * common/gdb_setjmp.h: Rename include guard.
12021 * common/gdb_ref_ptr.h: Rename include guard.
12022 * common/gdb_optional.h: Rename include guard.
12023 * common/gdb_locale.h: Rename include guard.
12024 * common/gdb_assert.h: Rename include guard.
12025 * common/filtered-iterator.h: Rename include guard.
12026 * common/filestuff.h: Rename include guard.
12027 * common/fileio.h: Rename include guard.
12028 * common/environ.h: Rename include guard.
12029 * common/common-utils.h: Rename include guard.
12030 * common/common-types.h: Rename include guard.
12031 * common/common-regcache.h: Rename include guard.
12032 * common/common-inferior.h: Rename include guard.
12033 * common/common-gdbthread.h: Rename include guard.
12034 * common/common-exceptions.h: Rename include guard.
12035 * common/common-defs.h: Rename include guard.
12036 * common/common-debug.h: Rename include guard.
12037 * common/cleanups.h: Rename include guard.
12038 * common/buffer.h: Rename include guard.
12039 * common/btrace-common.h: Rename include guard.
12040 * common/break-common.h: Rename include guard.
12041 * cli/cli-utils.h: Rename include guard.
12042 * cli/cli-style.h: Rename include guard.
12043 * cli/cli-setshow.h: Rename include guard.
12044 * cli/cli-script.h: Rename include guard.
12045 * cli/cli-interp.h: Rename include guard.
12046 * cli/cli-decode.h: Rename include guard.
12047 * cli/cli-cmds.h: Rename include guard.
12048 * charset-list.h: Add include guard.
12049 * buildsym-legacy.h: Rename include guard.
12050 * bfin-tdep.h: Add include guard.
12051 * ax.h: Rename include guard.
12052 * arm-linux-tdep.h: Add include guard.
12053 * arm-fbsd-tdep.h: Add include guard.
12054 * arch/xtensa.h: Rename include guard.
12055 * arch/tic6x.h: Add include guard.
12056 * arch/i386.h: Add include guard.
12057 * arch/arm.h: Rename include guard.
12058 * arch/arm-linux.h: Rename include guard.
12059 * arch/arm-get-next-pcs.h: Rename include guard.
12060 * arch/amd64.h: Add include guard.
12061 * arch/aarch64-insn.h: Rename include guard.
12062 * arch-utils.h: Rename include guard.
12063 * annotate.h: Add include guard.
12064 * amd64-darwin-tdep.h: Rename include guard.
12065 * aarch64-linux-tdep.h: Add include guard.
12066 * aarch64-fbsd-tdep.h: Add include guard.
12067 * aarch32-linux-nat.h: Add include guard.
12068
ab9268d2
PW
120692019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12070
12071 * macrotab.c (macro_define_internal): New function that
12072 factorizes macro_define_object_internal and macro_define_function
12073 code.
12074 (macro_define_object_internal): Use macro_define_internal.
12075 (macro_define_function): Likewise.
12076
bb0da2b4
PW
120772019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12078
12079 * macrocmd.c (extract_identifier): Return
12080 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12081 callers.
12082
424eb552
JB
120832019-02-06 John Baldwin <jhb@FreeBSD.org>
12084
12085 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12086
1688cb29
TT
120872019-02-05 Tom Tromey <tom@tromey.com>
12088
12089 * target.c (target_stack::unpush): Move assertion earlier.
12090
b5eba2d8
TT
120912019-01-30 Tom Tromey <tom@tromey.com>
12092
12093 PR python/23615:
12094 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12095 (gdbpy_parse_and_eval): Likewise.
12096 * python/python-internal.h (gdbpy_allow_threads): New class.
12097
7054e2ff
JB
120982019-01-28 John Baldwin <jhb@FreeBSD.org>
12099
12100 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12101 (aarch64_fbsd_fpregmap): Move earlier.
12102 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12103 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12104 instead of individual calls to trad_frame_set_reg_addr.
12105 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12106 earlier.
12107 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12108 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12109 instead of individual calls to trad_frame_set_reg_addr.
12110
36c25ffa
AH
121112019-01-28 Alan Hayward <alan.hayward@arm.com>
12112
12113 * CONTRIBUTE: Replace contribution list with wiki link.
12114
a0707f3c
TT
121152019-01-25 Tom Tromey <tom@tromey.com>
12116
12117 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12118
0747795c
TT
121192019-01-25 Tom Tromey <tom@tromey.com>
12120
12121 * xtensa-linux-nat.c: Fix common/ includes.
12122 * xml-support.h: Fix common/ includes.
12123 * xml-support.c: Fix common/ includes.
12124 * x86-linux-nat.c: Fix common/ includes.
12125 * windows-nat.c: Fix common/ includes.
12126 * varobj.h: Fix common/ includes.
12127 * varobj.c: Fix common/ includes.
12128 * value.c: Fix common/ includes.
12129 * valops.c: Fix common/ includes.
12130 * utils.c: Fix common/ includes.
12131 * unittests/xml-utils-selftests.c: Fix common/ includes.
12132 * unittests/utils-selftests.c: Fix common/ includes.
12133 * unittests/unpack-selftests.c: Fix common/ includes.
12134 * unittests/tracepoint-selftests.c: Fix common/ includes.
12135 * unittests/style-selftests.c: Fix common/ includes.
12136 * unittests/string_view-selftests.c: Fix common/ includes.
12137 * unittests/scoped_restore-selftests.c: Fix common/ includes.
12138 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12139 * unittests/scoped_fd-selftests.c: Fix common/ includes.
12140 * unittests/rsp-low-selftests.c: Fix common/ includes.
12141 * unittests/parse-connection-spec-selftests.c: Fix common/
12142 includes.
12143 * unittests/optional-selftests.c: Fix common/ includes.
12144 * unittests/offset-type-selftests.c: Fix common/ includes.
12145 * unittests/observable-selftests.c: Fix common/ includes.
12146 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12147 * unittests/memrange-selftests.c: Fix common/ includes.
12148 * unittests/memory-map-selftests.c: Fix common/ includes.
12149 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12150 * unittests/function-view-selftests.c: Fix common/ includes.
12151 * unittests/environ-selftests.c: Fix common/ includes.
12152 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12153 * unittests/common-utils-selftests.c: Fix common/ includes.
12154 * unittests/cli-utils-selftests.c: Fix common/ includes.
12155 * unittests/array-view-selftests.c: Fix common/ includes.
12156 * ui-file.c: Fix common/ includes.
12157 * tui/tui-io.c: Fix common/ includes.
12158 * tracepoint.h: Fix common/ includes.
12159 * tracepoint.c: Fix common/ includes.
12160 * tracefile-tfile.c: Fix common/ includes.
12161 * top.h: Fix common/ includes.
12162 * top.c: Fix common/ includes.
12163 * thread.c: Fix common/ includes.
12164 * target/waitstatus.h: Fix common/ includes.
12165 * target/waitstatus.c: Fix common/ includes.
12166 * target.h: Fix common/ includes.
12167 * target.c: Fix common/ includes.
12168 * target-memory.c: Fix common/ includes.
12169 * target-descriptions.c: Fix common/ includes.
12170 * symtab.h: Fix common/ includes.
12171 * symfile.c: Fix common/ includes.
12172 * stap-probe.c: Fix common/ includes.
12173 * spu-linux-nat.c: Fix common/ includes.
12174 * sparc-nat.c: Fix common/ includes.
12175 * source.c: Fix common/ includes.
12176 * solib.c: Fix common/ includes.
12177 * solib-target.c: Fix common/ includes.
12178 * ser-unix.c: Fix common/ includes.
12179 * ser-tcp.c: Fix common/ includes.
12180 * ser-pipe.c: Fix common/ includes.
12181 * ser-base.c: Fix common/ includes.
12182 * selftest-arch.c: Fix common/ includes.
12183 * s12z-tdep.c: Fix common/ includes.
12184 * rust-exp.y: Fix common/ includes.
12185 * rs6000-aix-tdep.c: Fix common/ includes.
12186 * riscv-tdep.c: Fix common/ includes.
12187 * remote.c: Fix common/ includes.
12188 * remote-notif.h: Fix common/ includes.
12189 * remote-fileio.h: Fix common/ includes.
12190 * remote-fileio.c: Fix common/ includes.
12191 * regcache.h: Fix common/ includes.
12192 * regcache.c: Fix common/ includes.
12193 * record-btrace.c: Fix common/ includes.
12194 * python/python.c: Fix common/ includes.
12195 * python/py-type.c: Fix common/ includes.
12196 * python/py-inferior.c: Fix common/ includes.
12197 * progspace.h: Fix common/ includes.
12198 * producer.c: Fix common/ includes.
12199 * procfs.c: Fix common/ includes.
12200 * proc-api.c: Fix common/ includes.
12201 * printcmd.c: Fix common/ includes.
12202 * ppc-linux-nat.c: Fix common/ includes.
12203 * parser-defs.h: Fix common/ includes.
12204 * osdata.c: Fix common/ includes.
12205 * obsd-nat.c: Fix common/ includes.
12206 * nat/x86-linux.c: Fix common/ includes.
12207 * nat/x86-linux-dregs.c: Fix common/ includes.
12208 * nat/x86-dregs.h: Fix common/ includes.
12209 * nat/x86-dregs.c: Fix common/ includes.
12210 * nat/ppc-linux.c: Fix common/ includes.
12211 * nat/mips-linux-watch.h: Fix common/ includes.
12212 * nat/mips-linux-watch.c: Fix common/ includes.
12213 * nat/linux-waitpid.c: Fix common/ includes.
12214 * nat/linux-ptrace.h: Fix common/ includes.
12215 * nat/linux-ptrace.c: Fix common/ includes.
12216 * nat/linux-procfs.c: Fix common/ includes.
12217 * nat/linux-personality.c: Fix common/ includes.
12218 * nat/linux-osdata.c: Fix common/ includes.
12219 * nat/linux-namespaces.c: Fix common/ includes.
12220 * nat/linux-btrace.h: Fix common/ includes.
12221 * nat/linux-btrace.c: Fix common/ includes.
12222 * nat/fork-inferior.c: Fix common/ includes.
12223 * nat/amd64-linux-siginfo.c: Fix common/ includes.
12224 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12225 * nat/aarch64-linux.c: Fix common/ includes.
12226 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12227 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12228 * namespace.h: Fix common/ includes.
12229 * mips-linux-tdep.c: Fix common/ includes.
12230 * minsyms.c: Fix common/ includes.
12231 * mi/mi-parse.h: Fix common/ includes.
12232 * mi/mi-main.c: Fix common/ includes.
12233 * mi/mi-cmd-env.c: Fix common/ includes.
12234 * memrange.h: Fix common/ includes.
12235 * memattr.c: Fix common/ includes.
12236 * maint.h: Fix common/ includes.
12237 * maint.c: Fix common/ includes.
12238 * main.c: Fix common/ includes.
12239 * machoread.c: Fix common/ includes.
12240 * location.c: Fix common/ includes.
12241 * linux-thread-db.c: Fix common/ includes.
12242 * linux-nat.c: Fix common/ includes.
12243 * linux-fork.c: Fix common/ includes.
12244 * inline-frame.c: Fix common/ includes.
12245 * infrun.c: Fix common/ includes.
12246 * inflow.c: Fix common/ includes.
12247 * inferior.h: Fix common/ includes.
12248 * inferior.c: Fix common/ includes.
12249 * infcmd.c: Fix common/ includes.
12250 * inf-ptrace.c: Fix common/ includes.
12251 * inf-child.c: Fix common/ includes.
12252 * ia64-linux-nat.c: Fix common/ includes.
12253 * i387-tdep.c: Fix common/ includes.
12254 * i386-tdep.c: Fix common/ includes.
12255 * i386-linux-tdep.c: Fix common/ includes.
12256 * i386-linux-nat.c: Fix common/ includes.
12257 * i386-go32-tdep.c: Fix common/ includes.
12258 * i386-fbsd-tdep.c: Fix common/ includes.
12259 * i386-fbsd-nat.c: Fix common/ includes.
12260 * guile/scm-type.c: Fix common/ includes.
12261 * guile/guile.c: Fix common/ includes.
12262 * go32-nat.c: Fix common/ includes.
12263 * gnu-nat.c: Fix common/ includes.
12264 * gdbthread.h: Fix common/ includes.
12265 * gdbarch-selftests.c: Fix common/ includes.
12266 * gdb_usleep.c: Fix common/ includes.
12267 * gdb_select.h: Fix common/ includes.
12268 * gdb_bfd.c: Fix common/ includes.
12269 * gcore.c: Fix common/ includes.
12270 * fork-child.c: Fix common/ includes.
12271 * findvar.c: Fix common/ includes.
12272 * fbsd-nat.c: Fix common/ includes.
12273 * event-top.c: Fix common/ includes.
12274 * event-loop.c: Fix common/ includes.
12275 * dwarf2read.c: Fix common/ includes.
12276 * dwarf2loc.c: Fix common/ includes.
12277 * dwarf2-frame.c: Fix common/ includes.
12278 * dwarf-index-cache.c: Fix common/ includes.
12279 * dtrace-probe.c: Fix common/ includes.
12280 * disasm-selftests.c: Fix common/ includes.
12281 * defs.h: Fix common/ includes.
12282 * csky-tdep.c: Fix common/ includes.
12283 * cp-valprint.c: Fix common/ includes.
12284 * cp-support.h: Fix common/ includes.
12285 * cp-support.c: Fix common/ includes.
12286 * corelow.c: Fix common/ includes.
12287 * completer.h: Fix common/ includes.
12288 * completer.c: Fix common/ includes.
12289 * compile/compile.c: Fix common/ includes.
12290 * compile/compile-loc2c.c: Fix common/ includes.
12291 * compile/compile-cplus-types.c: Fix common/ includes.
12292 * compile/compile-cplus-symbols.c: Fix common/ includes.
12293 * command.h: Fix common/ includes.
12294 * cli/cli-dump.c: Fix common/ includes.
12295 * cli/cli-cmds.c: Fix common/ includes.
12296 * charset.c: Fix common/ includes.
12297 * build-id.c: Fix common/ includes.
12298 * btrace.h: Fix common/ includes.
12299 * btrace.c: Fix common/ includes.
12300 * breakpoint.h: Fix common/ includes.
12301 * breakpoint.c: Fix common/ includes.
12302 * ax.h:
12303 (enum agent_op): Fix common/ includes.
12304 * ax-general.c (struct aop_map): Fix common/ includes.
12305 * ax-gdb.c: Fix common/ includes.
12306 * auxv.c: Fix common/ includes.
12307 * auto-load.c: Fix common/ includes.
12308 * arm-tdep.c: Fix common/ includes.
12309 * arch/riscv.c: Fix common/ includes.
12310 * arch/ppc-linux-common.c: Fix common/ includes.
12311 * arch/i386.c: Fix common/ includes.
12312 * arch/arm.c: Fix common/ includes.
12313 * arch/arm-linux.c: Fix common/ includes.
12314 * arch/arm-get-next-pcs.c: Fix common/ includes.
12315 * arch/amd64.c: Fix common/ includes.
12316 * arch/aarch64.c: Fix common/ includes.
12317 * arch/aarch64-insn.c: Fix common/ includes.
12318 * arch-utils.c: Fix common/ includes.
12319 * amd64-windows-tdep.c: Fix common/ includes.
12320 * amd64-tdep.c: Fix common/ includes.
12321 * amd64-sol2-tdep.c: Fix common/ includes.
12322 * amd64-obsd-tdep.c: Fix common/ includes.
12323 * amd64-nbsd-tdep.c: Fix common/ includes.
12324 * amd64-linux-tdep.c: Fix common/ includes.
12325 * amd64-linux-nat.c: Fix common/ includes.
12326 * amd64-fbsd-tdep.c: Fix common/ includes.
12327 * amd64-fbsd-nat.c: Fix common/ includes.
12328 * amd64-dicos-tdep.c: Fix common/ includes.
12329 * amd64-darwin-tdep.c: Fix common/ includes.
12330 * agent.c: Fix common/ includes.
12331 * ada-lang.h: Fix common/ includes.
12332 * ada-lang.c: Fix common/ includes.
12333 * aarch64-tdep.c: Fix common/ includes.
12334
2f5c153e
TT
123352019-01-25 Tom Tromey <tom@tromey.com>
12336
12337 * common/create-version.sh: Use common/version.h.
12338
adc6a863
PA
123392019-01-24 Pedro Alves <palves@redhat.com>
12340
12341 * infrun.c (signal_stop, signal_print, signal_program)
12342 (signal_catch, signal_pass): Now arrays instead of pointers.
12343 (update_signals_program_target, do_target_resume)
12344 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12345 * linux-nat.c (linux_nat_target::pass_signals)
12346 (linux_nat_target::create_inferior, linux_nat_target::attach):
12347 Adjust.
12348 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12349 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12350 * procfs.c (procfs_target::pass_signals): Adjust.
12351 * record-full.c (record_full_target::resume): Adjust.
12352 * remote.c (remote_target::pass_signals)
12353 (remote_target::program_signals): Adjust.
12354 * target-debug.h (target_debug_print_signals): Now takes a
12355 gdb::array_view as parameter. Adjust.
12356 * target.h (target_ops) <pass_signals, program_signals>: Replace
12357 pointer and length parameters with gdb::array_view.
12358 (target_pass_signals, target_program_signals): Likewise.
12359 * target-delegates.c: Regenerate.
12360
3046d67a
PA
123612019-01-24 Pedro Alves <palves@redhat.com>
12362
12363 * common/forward-scope-exit.h
12364 (forward_scope_exit::forward_scope_exit): Pass arguments to
12365 m_bind_function directly, instead of creating a std::bind and
12366 copying that.
12367
353229bf
AH
123682019-01-24 Alan Hayward <alan.hayward@arm.com>
12369
12370 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12371 for static members.
12372 (pass_in_v_vfp_candidate): Likewise.
12373
311dc83a
TT
123742019-01-23 Tom Tromey <tom@tromey.com>
12375 Pedro Alves <palves@redhat.com>
12376
12377 * regcache.c (class regcache_invalidator): Remove.
12378 (regcache::raw_write): Use make_scope_exit.
12379
296bd123
TT
123802019-01-23 Tom Tromey <tom@tromey.com>
12381
12382 * ui-out.h (class ui_out_emit_type): Update comment.
12383
979a0d13
TT
123842019-01-23 Tom Tromey <tom@tromey.com>
12385
12386 * infrun.c (fetch_inferior_event): Update comment.
12387
d238133d
TT
123882019-01-23 Tom Tromey <tom@tromey.com>
12389 Pedro Alves <palves@redhat.com>
12390
12391 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12392 parameter.
12393 (fetch_inferior_event): Use SCOPE_EXIT.
12394
12395
9885e6bb
TT
123962019-01-23 Tom Tromey <tom@tromey.com>
12397 Pedro Alves <palves@redhat.com>
12398
12399 * infrun.c (disable_thread_events): Delete.
12400 (stop_all_threads): Use SCOPE_EXIT.
12401
286526c1
TT
124022019-01-23 Tom Tromey <tom@tromey.com>
12403 Pedro Alves <palves@redhat.com>
12404
12405 * symfile.c: Include forward-scope-exit.h.
12406 (clear_symtab_users_cleanup): Replace forward declaration with
12407 a FORWARD_SCOPE_EXIT.
12408 (syms_from_objfile_1): Use the forward_scope_exit and
12409 gdb::optional instead of cleanup_function.
12410 (reread_symbols): Use the forward_scope_exit instead of
12411 cleanup_function.
12412 (clear_symtab_users_cleanup): Remove function.
12413
1db93f14
TT
124142019-01-23 Tom Tromey <tom@tromey.com>
12415 Pedro Alves <palves@redhat.com>
12416
12417 * linux-nat.c: Include scope-exit.h.
12418 (cleanup_target_stop): Remove.
12419 (linux_nat_target::static_tracepoint_markers_by_strid): Use
12420 SCOPE_EXIT.
12421
2cc83d1e
TT
124222019-01-23 Tom Tromey <tom@tromey.com>
12423 Pedro Alves <palves@redhat.com>
12424
12425 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12426 (call_function_by_hand_dummy): Use SCOPE_EXIT.
12427
694c6bf5
TT
124282019-01-23 Tom Tromey <tom@tromey.com>
12429 Andrew Burgess <andrew.burgess@embecosm.com>
12430 Pedro Alves <palves@redhat.com>
12431
12432 * infrun.c (fetch_inferior_event): Use scope_exit.
12433 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12434 * top.c (execute_command): Use scope_exit.
12435 * breakpoint.c (bpstat_do_actions): Use scope_exit.
12436 * utils.c (do_bpstat_clear_actions_cleanup)
12437 (make_bpstat_clear_actions_cleanup): Remove.
12438
4c41382a
TT
124392019-01-23 Tom Tromey <tom@tromey.com>
12440 Pedro Alves <palves@redhat.com>
12441
12442 * infrun.c: Include "common/scope-exit.h"
12443 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12444 (wait_for_inferior): Use SCOPE_EXIT.
12445 (fetch_inferior_event): Use scope_exit.
12446
89f8fb50
TT
124472019-01-23 Tom Tromey <tom@tromey.com>
12448 Pedro Alves <palves@redhat.com>
12449
12450 * breakpoint.c (create_breakpoint): Remove cleanup.
12451
5419bdae
TT
124522019-01-23 Tom Tromey <tom@tromey.com>
12453 Andrew Burgess <andrew.burgess@embecosm.com>
12454 Pedro Alves <palves@redhat.com>
12455
e587ef42
PA
124562019-01-23 Pedro Alves <palves@redhat.com>
12457
12458 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12459
77f0e74c
PA
124602019-01-23 Pedro Alves <palves@redhat.com>
12461 Andrew Burgess <andrew.burgess@embecosm.com>
12462
12463 * gdbthread.h: Include "common/forward-scope-exit.h".
12464 (scoped_finish_thread_state): Redefine custom class in terms of
12465 forward_scope_exit.
12466
5b9b3e53
PA
124672019-01-23 Pedro Alves <palves@redhat.com>
12468 Andrew Burgess <andrew.burgess@embecosm.com>
12469
12470 * common/forward-scope-exit.h: New file.
12471
54b65c9b
PA
124722019-01-23 Pedro Alves <palves@redhat.com>
12473 Andrew Burgess <andrew.burgess@embecosm.com>
12474 Tom Tromey <tom@tromey.com>
12475
12476 * common/scope-exit.h: New file.
12477
cf08fb29
PA
124782019-01-23 Pedro Alves <palves@redhat.com>
12479
12480 * common/preprocessor.h (ESC): Rename to ...
12481 (ESC_PARENS): ... this.
12482 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12483 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12484
ae73e2e2
TT
124852019-01-23 Tom Tromey <tom@tromey.com>
12486
12487 * language.h (class scoped_switch_to_sym_language_if_auto):
12488 Initialize m_lang in both cases.
12489
6594e122
AH
124902019-01-23 Alan Hayward <alan.hayward@arm.com>
12491
12492 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12493 with XCNEW.
12494
a7c9855d
TT
124952019-01-22 Tom Tromey <tom@tromey.com>
12496
12497 * corelow.c: Do not include sys/file.h.
12498
93cc1d53
TT
124992019-01-22 Tom Tromey <tom@tromey.com>
12500
12501 * tui/tui-wingeneral.h: Include gdb_curses.h.
12502
38561778
TT
125032019-01-22 Tom Tromey <tom@tromey.com>
12504
12505 * source-cache.h (class source_cache) <get_source_lines,
12506 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12507
37b3ab5b
TT
125082019-01-22 Tom Tromey <tom@tromey.com>
12509
12510 * remote-fileio.h (struct remote_target): Declare.
12511
3fabc016
TT
125122019-01-22 Tom Tromey <tom@tromey.com>
12513
12514 * python/py-arch.c: Do not include py-ref.h.
12515 * python/py-bpevent.c: Do not include py-ref.h.
12516 * python/py-cmd.c: Do not include py-ref.h.
12517 * python/py-continueevent.c: Do not include py-ref.h.
12518 * python/py-event.h: Do not include py-ref.h.
12519 * python/py-evtregistry.c: Do not include py-ref.h.
12520 * python/py-finishbreakpoint.c: Do not include py-ref.h.
12521 * python/py-frame.c: Do not include py-ref.h.
12522 * python/py-framefilter.c: Do not include py-ref.h.
12523 * python/py-function.c: Do not include py-ref.h.
12524 * python/py-infevents.c: Do not include py-ref.h.
12525 * python/py-linetable.c: Do not include py-ref.h.
12526 * python/py-objfile.c: Do not include py-ref.h.
12527 * python/py-param.c: Do not include py-ref.h.
12528 * python/py-prettyprint.c: Do not include py-ref.h.
12529 * python/py-progspace.c: Do not include py-ref.h.
12530 * python/py-symbol.c: Do not include py-ref.h.
12531 * python/py-symtab.c: Do not include py-ref.h.
12532 * python/py-type.c: Do not include py-ref.h.
12533 * python/py-unwind.c: Do not include py-ref.h.
12534 * python/py-utils.c: Do not include py-ref.h.
12535 * python/py-value.c: Do not include py-ref.h.
12536 * python/py-varobj.c: Do not include py-ref.h.
12537 * python/py-xmethods.c: Do not include py-ref.h.
12538 * python/python.c: Do not include py-ref.h.
12539 * varobj.c: Do not include py-ref.h.
12540
6b4d7774
TT
125412019-01-22 Tom Tromey <tom@tromey.com>
12542
12543 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12544 keyword for bcache.
12545
7af7e9b5
TT
125462019-01-22 Tom Tromey <tom@tromey.com>
12547
12548 * compile/compile-cplus-types.c: Remove a comment by #include.
12549
951d1049
TT
125502019-01-22 Tom Tromey <tom@tromey.com>
12551
12552 * compile/gcc-c-plugin.h: Include compile-internal.h.
12553
d65d5705
TT
125542019-01-22 Tom Tromey <tom@tromey.com>
12555
12556 * stabsread.c (EXTERN): Do not define.
12557 (symnum, next_symbol_text_func, processing_gcc_compilation)
12558 (within_function, global_sym_chain, global_stabs)
12559 (previous_stab_code, this_object_header_files)
12560 (n_this_object_header_files)
12561 (n_allocated_this_object_header_files): Define.
12562 * stabsread.h (EXTERN): Never define. Use "extern".
12563
b6fb1ee5
PW
125642019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12565
12566 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12567 history_value.
12568
be6d4f74
TT
125692019-01-21 Tom Tromey <tom@tromey.com>
12570
12571 * ui-out.c: Fix includes.
12572 * tui/tui-source.c: Fix includes.
12573 * target.c: Fix includes.
12574 * remote.c: Fix includes.
12575 * regcache.c: Fix includes.
12576 * python/py-block.c: Fix includes.
12577 * printcmd.c: Fix includes.
12578 * or1k-tdep.c: Fix includes.
12579 * mi/mi-main.c: Fix includes.
12580 * m32r-tdep.c: Fix includes.
12581 * csky-tdep.c: Fix includes.
12582 * compile/compile-cplus-types.c: Fix includes.
12583 * cli/cli-interp.c: Fix includes.
12584
73021deb
AH
125852019-01-21 Alan Hayward <alan.hayward@arm.com>
12586
12587 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12588 for padding.
12589
7932255d
TT
125902019-01-16 Tom Tromey <tom@tromey.com>
12591
12592 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
12593 earlier.
12594 (struct objfile) <msymbols_range>: Move from top level.
12595 <msymbols>: New method.
12596 (class objfile_msymbols): Remove.
12597 * symtab.c (default_collect_symbol_completion_matches_break_on):
12598 Update.
12599 * symmisc.c (dump_msymbols): Update.
12600 * stabsread.c (scan_file_globals): Update.
12601 * objc-lang.c (info_selectors_command, info_classes_command)
12602 (find_methods): Update.
12603 * minsyms.c (find_solib_trampoline_target): Update.
12604 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12605 * coffread.c (coff_symfile_read): Update.
12606 * ada-lang.c (ada_lookup_simple_minsym)
12607 (ada_collect_symbol_completion_matches): Update.
12608
604b1bfb
TT
126092019-01-16 Tom Tromey <tom@tromey.com>
12610
12611 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12612 type. Remove no-argument constructor.
12613 <iterator::operator++>: Simplify.
12614 <begin>: Update.
12615 <end>: Use minimal_symbol_count.
12616
f252c6d5
TT
126172019-01-16 Tom Tromey <tom@tromey.com>
12618
12619 * objfiles.h (struct objfile) <psymtabs>: New method.
12620 (class objfile_psymtabs): Remove.
12621 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12622 typedef.
12623 <range>: New method.
12624 (require_partial_symbols): Change return type.
12625 * psymtab.c (require_partial_symbols)
12626 (psym_expand_symtabs_matching): Update.
12627 * mdebugread.c (parse_partial_symbols): Update.
12628 * dbxread.c (dbx_end_psymtab): Update.
12629
b669c953
TT
126302019-01-15 Tom Tromey <tom@tromey.com>
12631
12632 * symtab.c (lookup_objfile_from_block)
12633 (lookup_symbol_in_objfile_symtabs)
12634 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12635 (find_line_symtab, info_sources_command)
12636 (default_collect_symbol_completion_matches_break_on)
12637 (make_source_files_completion_list): Update.
12638 * symmisc.c (print_objfile_statistics, dump_objfile)
12639 (maintenance_print_symbols, maintenance_info_symtabs)
12640 (maintenance_check_symtabs, maintenance_info_line_tables):
12641 Update.
12642 * source.c (select_source_symtab)
12643 (forget_cached_source_info_for_objfile): Update.
12644 * objfiles.h (class objfile_compunits): Remove.
12645 (struct objfile) <compunits_range>: New typedef.
12646 (compunits): New method.
12647 * objfiles.c (objfile_relocate1): Update.
12648 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12649 * maint.c (count_symtabs_and_blocks): Update.
12650 * linespec.c (iterate_over_all_matching_symtabs): Update.
12651 * cp-support.c (add_symbol_overload_list_qualified): Update.
12652 * coffread.c (coff_symtab_read): Update.
12653 * ada-lang.c (add_nonlocal_symbols)
12654 (ada_collect_symbol_completion_matches)
12655 (ada_add_global_exceptions): Update.
12656
7e955d83
TT
126572019-01-15 Tom Tromey <tom@tromey.com>
12658
12659 * progspace.h (program_space) <objfiles_safe_range>: New
12660 typedef.
12661 <objfiles_safe>: New method.
12662 * objfiles.h (class all_objfiles_safe): Remove.
12663 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12664 * jit.c (jit_inferior_exit_hook): Update.
12665
2030c079
TT
126662019-01-17 Tom Tromey <tom@tromey.com>
12667
12668 * progspace.h (program_space) <objfiles_range>: New typedef.
12669 <objfiles>: New method.
12670 <objfiles_head>: Rename from objfiles.
12671 (object_files): Update.
12672 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12673 * guile/scm-pretty-print.c
12674 (ppscm_find_pretty_printer_from_objfiles): Update.
12675 * guile/scm-objfile.c (gdbscm_objfiles): Update.
12676 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12677 Update.
12678 * python/py-progspace.c (pspy_get_objfiles): Update.
12679 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12680 Update.
12681 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12682 (objfpy_lookup_objfile_by_build_id): Update.
12683 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12684 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12685 Update.
12686 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12687 (expand_symtab_containing_pc, lookup_objfile_from_block)
12688 (lookup_static_symbol, basic_lookup_transparent_type)
12689 (find_pc_sect_compunit_symtab, find_symbol_at_address)
12690 (find_line_symtab, info_sources_command)
12691 (default_collect_symbol_completion_matches_break_on)
12692 (make_source_files_completion_list, find_main_name): Update.
12693 * symmisc.c (print_symbol_bcache_statistics)
12694 (print_objfile_statistics, maintenance_print_symbols)
12695 (maintenance_print_msymbols, maintenance_print_objfiles)
12696 (maintenance_info_symtabs, maintenance_check_symtabs)
12697 (maintenance_expand_symtabs, maintenance_info_line_tables):
12698 Update.
12699 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12700 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12701 (map_overlay_command, unmap_overlay_command)
12702 (simple_overlay_update, expand_symtabs_matching)
12703 (map_symbol_filenames): Update.
12704 * symfile-debug.c (set_debug_symfile): Update.
12705 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12706 Update.
12707 * source.c (select_source_symtab, forget_cached_source_info):
12708 Update.
12709 * solib.c (solib_read_symbols): Update.
12710 * solib-spu.c (append_ocl_sos): Update.
12711 * psymtab.c (maintenance_print_psymbols)
12712 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12713 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12714 * printcmd.c (info_symbol_command): Update.
12715 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12716 Update.
12717 * objfiles.h (class all_objfiles): Remove.
12718 * objfiles.c (have_partial_symbols, have_full_symbols)
12719 (have_minimal_symbols, qsort_cmp, update_section_map)
12720 (shared_objfile_contains_address_p)
12721 (default_iterate_over_objfiles_in_search_order): Update.
12722 * objc-lang.c (info_selectors_command, info_classes_command)
12723 (find_methods): Update.
12724 * minsyms.c (find_solib_trampoline_target): Update.
12725 * maint.c (maintenance_info_sections)
12726 (maintenance_translate_address, count_symtabs_and_blocks):
12727 Update.
12728 * main.c (captured_main_1): Update.
12729 * linux-thread-db.c (try_thread_db_load_from_pdir)
12730 (has_libpthread): Update.
12731 * linespec.c (iterate_over_all_matching_symtabs)
12732 (search_minsyms_for_name): Update.
12733 * jit.c (jit_find_objf_with_entry_addr): Update.
12734 * hppa-tdep.c (find_unwind_entry)
12735 (hppa_lookup_stub_minimal_symbol): Update.
12736 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12737 Update.
12738 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12739 (elf_gnu_ifunc_resolve_by_got): Update.
12740 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12741 * dwarf-index-write.c (save_gdb_index_command): Update.
12742 * cp-support.c (add_symbol_overload_list_qualified): Update.
12743 * breakpoint.c (create_overlay_event_breakpoint)
12744 (create_longjmp_master_breakpoint)
12745 (create_std_terminate_master_breakpoint)
12746 (create_exception_master_breakpoint): Update.
12747 * blockframe.c (find_pc_partial_function): Update.
12748 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12749 (ada_collect_symbol_completion_matches)
12750 (ada_add_global_exceptions): Update.
12751
776489e0
TT
127522019-01-17 Tom Tromey <tom@tromey.com>
12753
12754 * solib-target.c (lm_info_target_p): Remove typedef. Don't
12755 declare VEC.
12756 (solib_target_parse_libraries): Change return type.
12757 (library_list_start_segment, library_list_start_section)
12758 (library_list_end_library, library_list_start_library); Update.
12759 (solib_target_free_library_list): Remove.
12760 (solib_target_parse_libraries): Remove cleanup. Change return
12761 type.
12762 (solib_target_current_sos): Update.
12763
6471e7d2
TT
127642019-01-17 Tom Tromey <tromey@bapiya>
12765
12766 * valprint.c: Replace "the the" with "the".
12767 * symtab.c: Replace "the the" with "the".
12768 * solib.c: Replace "the the" with "the".
12769 * solib-dsbt.c: Replace "the the" with "the".
12770 * linespec.c: Replace "the the" with "the".
12771 * dwarf2loc.h: Replace "the the" with "the".
12772 * amd64-windows-tdep.c: Replace "the the" with "the".
12773 * aarch64-tdep.c: Replace "the the" with "the".
12774
c24bdb02
KS
127752019-01-16 Keith Seitz <keiths@redhat.com>
12776
12777 PR gdb/23773
12778 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12779 <builder>: Rename to ..
12780 <m_builder>: ... this and make private.
12781 (dwarf2_cu::get_builder): New method. Change all users of
12782 `builder' to use this method.
12783 (dwarf2_start_symtab): Move to ...
12784 (dwarf2_cu::start_symtab): ... here. Update all callers
12785 (setup_type_unit_groups): Move to ...
12786 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
12787 callers.
12788 (dwarf2_cu::reset_builder): New method.
12789 (process_full_compunit, process_full_type_unit): Use
12790 dwarf2_cu::reset_builder.
12791 (follow_die_offset): Record the ancestor CU if it is different
12792 from the followed DIE's CU.
12793 (follow_die_sig_1): Likewise.
12794
8d64371b
TT
127952019-01-15 Tom Tromey <tom@tromey.com>
12796
12797 * remote.c (class remote_state) <buf>: Now a char_vector.
12798 <buf_size>: Remove.
12799 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
12800 parameter.
12801 (remote_target::getpkt_or_notif_sane_1)
12802 (remote_target::getpkt_sane)
12803 (remote_target::getpkt_or_notif_sane): Likewise.
12804 (class remote_target) <putpkt>: New overload.
12805 (remote_target::read_frame): Change type of "buf_p". Remove
12806 sizeof_p parameter.
12807 (packet_ok): New overload.
12808 (packet_check_result): New overload.
12809 Update all uses.
12810
bb277751
TT
128112019-01-14 Tom Tromey <tom@tromey.com>
12812
12813 * remote-notif.c (handle_notification, remote_notif_ack)
12814 (remote_notif_parse): Make "buf" const.
12815 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12816 const.
12817 (remote_notif_parse, remote_notif_ack, handle_notification):
12818 Likewise.
12819 * remote.c (remote_notif_stop_parse): Make "buf" const.
12820 (remote_target::remote_parse_stop_reply): Make "buf" const.
12821 (remote_notif_stop_ack): Make "buf" const.
12822
05be00a8
TT
128232019-01-14 Tom Tromey <tom@tromey.com>
12824
12825 * remote.c (remote_console_output): Make parameter const.
12826
491adeca
TT
128272019-01-14 Tom Tromey <tom@tromey.com>
12828
12829 * target-debug.h (target_debug_print_signals): Constify.
12830 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12831 * procfs.c (procfs_target::pass_signals): Update.
12832 * linux-nat.c (linux_nat_target::pass_signals): Update.
12833 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12834 * target-delegates.c: Rebuild.
12835 * remote.c (remote_target::program_signals): Update.
12836 (remote_target::pass_signals): Update.
12837 * target.c (target_pass_signals): Constify argument.
12838 (target_program_signals): Likewise.
12839 * target.h (struct target_ops) <pass_signals, program_signals>:
12840 Constify argument.
12841 (target_pass_signals, target_program_signals): Constify argument.
12842
bbd94648
TT
128432019-01-14 Tom Tromey <tom@tromey.com>
12844
12845 PR tui/28819:
12846 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12847
6f072a10
PFC
128482019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
12849
12850 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12851 field.
12852 * rs6000-tdep.c: Include reggroups.h.
12853 (IS_V_ALIAS_PSEUDOREG): Define.
12854 (rs6000_register_name): Return names for the "vX" aliases.
12855 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12856 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
12857 aliases. Call default_register_reggroup_p for all other
12858 pseudo-registers.
12859 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12860 New functions.
12861 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12862 Handle "vX" aliases.
12863 (v_alias_pseudo_register_collect): New function.
12864 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12865 (rs6000_gdbarch_init): Initialize "vX" aliases as
12866 pseudo-registers. Restore registration of
12867 rs6000_pseudo_register_reggroup_p with
12868 set_tdesc_pseudo_register_reggroup_p.
12869
1a782351
MF
128702019-01-13 Max Filippov <jcmvbkbc@gmail.com>
12871
12872 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12873 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12874 set_gdbarch_num_pseudo_regs.
12875
d73cff18
PW
128762019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12877
12878 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12879 Remove arg prefixname, add do_set and do_show.
12880 Add member functions set_list and show_list.
12881 * cli/cli-style.c (class cli_style_option): Update accordingly.
12882 (style_set_list): Move to file scope.
12883 (style_show_list): Likewise.
12884 (set_style): Call help_list.
12885 (show_style): Call cmd_show_list.
12886 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12887 Update to use the new macro.
12888
60a90376
JB
128892019-10-12 Joel Brobecker <brobecker@adacore.com>
12890
12891 * ada-lang.c (_initialize_ada_language): Expand the help text
12892 for the "catch exception" command.
12893
9d7c67bf
PW
128942019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12895
12896 * symtab.c (matching_obj_sections): Initialize obj,
12897 declare it closer to its usage.
12898
7cf47dc4
TT
128992019-01-10 Tom Tromey <tom@tromey.com>
12900
12901 * thread-iter.h (inf_threads_iterator): Use next_iterator.
12902 (basic_inf_threads_range): Remove.
12903 (inf_threads_range, inf_non_exited_threads_range)
12904 (safe_inf_threads_range): Use next_adapter.
12905
d3cb6808
KS
129062019-01-10 Keith Seitz <keiths@redhat.com>
12907
12908 PR gdb/23712
12909 PR symtab/23010
12910 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12911 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12912
63a20375
KS
129132019-01-10 Keith Seitz <keiths@redhat.com>
12914
12915 PR gdb/23712
12916 PR symtab/23010
12917 * dictionary.c (pending_to_vector): Remove.
12918 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12919 Remove _1 suffix, replacing functions of the same name. Update
12920 all callers.
12921 (dict_create_hashed, dict_create_hashed_expandable)
12922 (dict_create_linear, dict_create_linear_expandable, dict_free)
12923 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12924 Make functions static.
12925
b026f593
KS
129262019-01-10 Keith Seitz <keiths@redhat.com>
12927
12928 PR gdb/23712
12929 PR symtab/23010
12930 * dictionary.h (struct dictionary): Replace declaration with
12931 multidictionary.
12932 (dict_create_hashed, dict_create_hashed_expandable)
12933 (dict_create_linear, dict_create_linear_expandable)
12934 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12935 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12936 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12937 taking multidictionary argument.
12938 [ALL_DICT_SYMBOLS]: Update for multidictionary.
12939 * block.h (struct block) <dict>: Change to multidictionary
12940 and rename `multidict'.
12941 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12942 symmisc.c: Update all dictionary references to multidictionary.
12943
c7748ee9
KS
129442019-01-10 Keith Seitz <keiths@redhat.com>
12945
12946 PR gdb/23712
12947 PR symtab/23010
12948 * dictionary.c: Include unordered_map.
12949 (pending_to_vector): New function.
12950 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12951 Rewrite the non-"_1" functions to take vector instead
12952 of linked list.
12953 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12954 "new" _1 versions of the same name.
12955 (multidictionary): Define.
12956 (std::hash<enum language): New definition.
12957 (collate_pending_symbols_by_language, mdict_create_hashed)
12958 (mdict_create_hashed_expandable, mdict_create_linear)
12959 (mdict_create_linear_expandable, mdict_free)
12960 (find_language_dictionary, create_new_language_dictionary)
12961 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12962 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12963 (mdict_size, mdict_empty): New functions.
12964 * dictionary.h (mdict_iterator): Define.
12965
67aa1f3c
PA
129662019-01-10 Pedro Alves <palves@redhat.com>
12967
12968 * breakpoint.c (read_uploaded_action)
12969 (create_tracepoint_from_upload): Adjust to use
12970 gdb::unique_xmalloc_ptr.
12971 * ctf.c (ctf_write_uploaded_tp):
12972 (SET_ARRAY_FIELD): Use emplace_back.
12973 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12974 * tracefile-tfile.c (tfile_write_uploaded_tp):
12975 * tracepoint.c (parse_tracepoint_definition): Adjust to use
12976 gdb::unique_xmalloc_ptr.
12977 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12978 at_string, cond_string, cmd_strings>: Replace char pointers
12979 with gdb::unique_xmalloc_ptr.
12980
2f667667
PA
129812019-01-10 Pedro Alves <palves@redhat.com>
12982
12983 * solib-target.c (library_list_start_library): Don't xstrdup name.
12984
36cb7237
PA
129852019-01-10 Pedro Alves <palves@redhat.com>
12986
12987 * mdebugread.c (parse_partial_symbols): Use
12988 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12989
da584958
AB
129902019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12991
12992 * linux-fork.c (scoped_switch_fork_info)
12993 <~scoped_switch_fork_info>: Fix incorrect variable name.
12994
1ef8573c
AB
129952019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12996
12997 * linux-fork.c (scoped_switch_fork_info)
12998 <scoped_switch_fork_info>: Make explicit.
12999 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13000
8d7bcccb
TT
130012019-01-10 Tom Tromey <tom@tromey.com>
13002
13003 * objfiles.h (objfile::reset_psymtabs): Update.
13004 * objfiles.c (objfile::objfile): Update.
13005 * psymtab.h (psymtab_storage::obstack): Update.
13006 (psymtab_storage::m_obstack): Use gdb::optional.
13007 (class psymtab_storage): Update comment. Remove objfile
13008 parameter.
13009 * psymtab.c (psymtab_storage::psymtab_storage): Update.
13010
b596a3c7
TT
130112019-01-10 Tom Tromey <tom@tromey.com>
13012
13013 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13014 <free_psymtabs>: Now private.
13015 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13016 (allocate_psymtab): Use new method.
13017
a9342b62
TT
130182019-01-10 Tom Tromey <tom@tromey.com>
13019
13020 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13021 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13022 * mdebugread.c (parse_partial_symbols): Use
13023 allocate_dependencies.
13024 * dwarf2read.c (dwarf2_create_include_psymtab): Use
13025 allocate_dependencies.
13026 (process_psymtab_comp_unit_reader)
13027 (build_type_psymtab_dependencies): Likewise.
13028 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13029
5af70966
TT
130302019-01-10 Tom Tromey <tom@tromey.com>
13031
13032 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13033 PSYMBOL_SET_LANGUAGE.
13034 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13035
5923a04c
TT
130362019-01-10 Tom Tromey <tom@tromey.com>
13037
13038 * psymtab.h (psymtab_storage::obstack): New method.
13039 <m_obstack>: Rename from obstack; now private.
13040 * psymtab.c (psymtab_storage): Update.
13041 * dwarf2read.c (create_addrmap_from_index)
13042 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13043 Update.
13044
6d6a12bf
TT
130452019-01-10 Tom Tromey <tom@tromey.com>
13046
13047 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13048 * objfiles.h (objfile::reset_psymtabs): New method.
13049
d320c2b5
TT
130502019-01-10 Tom Tromey <tom@tromey.com>
13051
13052 * symmisc.c (print_symbol_bcache_statistics): Update.
13053 (print_objfile_statistics): Update.
13054 * symfile.c (reread_symbols): Update.
13055 * psymtab.h (class psymtab_storage): New.
13056 * psymtab.c (psymtab_storage): New constructor.
13057 (~psymtab_storage): New destructor.
13058 (require_partial_symbols): Update.
13059 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13060 (find_pc_sect_psymtab, find_pc_sect_psymbol)
13061 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13062 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13063 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13064 (start_psymtab_common, end_psymtab_common)
13065 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13066 (allocate_psymtab): Update.
13067 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13068 Update.
13069 (dump_psymtab_addrmap, maintenance_print_psymbols)
13070 (maintenance_check_psymtabs): Update.
13071 (class objfile_psymtabs): Move to objfiles.h.
13072 * psympriv.h (discard_psymtab): Now inline.
13073 (psymtab_discarder::psymtab_discarder): Update.
13074 (psymtab_discarder::~psymtab_discarder): Update.
13075 (ALL_OBJFILE_PSYMTABS): Rewrite.
13076 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13077 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13078 Remove fields.
13079 <partial_symtabs>: New field.
13080 (class objfile_psymtabs): Move from psymtab.h. Update.
13081 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13082 psymbol_cache.
13083 (objfile::~objfile): Don't destroy psymbol_cache.
13084 * mdebugread.c (parse_partial_symbols): Update.
13085 * dwarf2read.c (create_addrmap_from_index)
13086 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13087 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13088 (add_partial_subprogram, dwarf2_ranges_read): Update.
13089 * dwarf-index-write.c (write_address_map)
13090 (write_one_signatured_type, recursively_write_psymbols)
13091 (class debug_names, class debug_names, write_psymtabs_to_index):
13092 Update.
13093
1d94a5a3
TT
130942019-01-10 Tom Tromey <tom@tromey.com>
13095
13096 * symtab.h (SYMBOL_SET_NAMES): Update.
13097 (symbol_set_names): Update.
13098 (MSYMBOL_SET_NAMES): Update.
13099 * symtab.c (symbol_set_names): Change argument to be an
13100 objfile_per_bfd_storage.
13101 * psymtab.c (add_psymbol_to_bcache): Update.
13102 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13103
0f14768a
TT
131042019-01-10 Tom Tromey <tom@tromey.com>
13105
13106 * symtab.c (create_demangled_names_hash): Change argument to be an
13107 objfile_per_bfd_storage.
13108 (symbol_set_names): Update.
13109
6eee24ce
TT
131102019-01-10 Tom Tromey <tom@tromey.com>
13111
13112 * xcoffread.c (xcoff_initial_scan): Unconditionally call
13113 init_psymbol_list.
13114 * psymtab.c (init_psymbol_list): Do nothing if already called.
13115 * psympriv.h (init_psymbol_list): Add comment.
13116 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13117 init_psymbol_list.
13118 * dbxread.c (dbx_symfile_read): Unconditionally call
13119 init_psymbol_list.
13120
75aedd27
TT
131212019-01-10 Tom Tromey <tom@tromey.com>
13122
13123 * xcoffread.c (scan_xcoff_symtab): Update.
13124 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13125 "where".
13126 * mdebugread.c (parse_partial_symbols)
13127 (handle_psymbol_enumerators): Update.
13128 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13129 * dbxread.c (read_dbx_symtab): Update.
13130 * psympriv.h (psymbol_placement): New enum.
13131 (add_psymbol_to_list): Update.
13132
939652a5
TT
131332019-01-10 Tom Tromey <tom@tromey.com>
13134
13135 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13136 static_psymbols parameters.
13137 (scan_xcoff_symtab): Update.
13138 * psymtab.c (start_psymtab_common): Remove global_psymbols and
13139 static_psymbols parameters.
13140 * psympriv.h (start_psymtab_common): Update.
13141 * mdebugread.c (parse_partial_symbols): Update.
13142 * dwarf2read.c (create_partial_symtab): Update.
13143 * dbxread.c (read_dbx_symtab): Update.
13144 (start_psymtab): Remove global_psymbols and static_psymbols
13145 parameters.
13146
baa62830
TT
131472019-01-10 Tom Tromey <tom@tromey.com>
13148
13149 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13150 * psymtab.c (allocate_psymtab): Add comment.
13151 * psympriv.h (allocate_psymtab): Add comment.
13152 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13153 initializations.
13154 * dbxread.c (dbx_end_psymtab): Remove some initializations.
13155
0e8f53ba
TT
131562019-01-10 Tom Tromey <tom@tromey.com>
13157
13158 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13159 Don't declare.
13160 * mipsread.c: Include mdebugread.h.
13161 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13162 Declare.
13163 * elfread.c: Include mdebugread.h.
13164
b22a7c6a
TT
131652019-01-09 Tom Tromey <tom@tromey.com>
13166
13167 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13168 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13169 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13170 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13171 (psym_lookup_symbol, psym_find_last_source_symtab)
13172 (psym_forget_cached_source_info, psym_print_stats)
13173 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13174 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13175 (psym_map_matching_symbols, psym_expand_symtabs_matching)
13176 (psym_find_compunit_symtab_by_address)
13177 (maintenance_print_psymbols, maintenance_info_psymtabs)
13178 (maintenance_check_psymtabs): Use ranged for.
13179 * psymtab.h (class objfile_psymtabs): New.
13180 (require_partial_symbols): Return objfile_psymtabs.
13181 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13182
3b9d3ac2
TT
131832019-01-09 Tom Tromey <tom@tromey.com>
13184
13185 * symfile.c (overlay_invalidate_all, find_pc_overlay)
13186 (find_pc_mapped_section, list_overlays_command)
13187 (map_overlay_command, unmap_overlay_command)
13188 (simple_overlay_update): Use all_objfiles.
13189 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13190 * printcmd.c (info_symbol_command): Use all_objfiles.
13191 * objfiles.h (ALL_OBJSECTIONS): Remove.
13192 * maint.c (maintenance_translate_address): Use all_objfiles.
13193 * gcore.c (gcore_create_callback): Use all_objfiles.
13194 (objfile_find_memory_regions): Likewise.
13195
8b31193a
TT
131962019-01-09 Tom Tromey <tom@tromey.com>
13197
13198 * symtab.c (find_line_symtab, info_sources_command)
13199 (make_source_files_completion_list): Use objfile_compunits.
13200 * source.c (select_source_symtab): Use objfile_compunits.
13201 * objfiles.h (struct objfile): Update comment.
13202 (ALL_OBJFILES): Remove.
13203 (ALL_FILETABS): Remove.
13204 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13205 objfile_compunits.
13206
d5da8b3c
TT
132072019-01-09 Tom Tromey <tom@tromey.com>
13208
13209 * symmisc.c (print_objfile_statistics, dump_objfile)
13210 (maintenance_print_symbols): Use compunit_filetabs.
13211 * source.c (forget_cached_source_info_for_objfile): Use
13212 compunit_filetabs.
13213 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13214 (ALL_FILETABS): Use compunit_filetabs.
13215 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13216 * coffread.c (coff_symtab_read): Use compunit_filetabs.
13217
5accd1a0
TT
132182019-01-09 Tom Tromey <tom@tromey.com>
13219
13220 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13221 (compunit_filetabs): New.
13222 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13223 compunit_filetabs.
13224 (info_sources_command, make_source_files_completion_list): Remove
13225 declaration.
13226 * symmisc.c (print_objfile_statistics, dump_objfile)
13227 (maintenance_print_symbols): Remove declaration.
13228 (maintenance_info_symtabs): Use compunit_filetabs.
13229 (maintenance_info_line_tables): Likewise.
13230 * source.c (select_source_symtab): Change local variable name.
13231 (forget_cached_source_info_for_objfile): Remove declaration.
13232 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13233 * objfiles.c (objfile_relocate1): Remove declaration.
13234 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13235 declaration.
13236 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13237 * coffread.c (coff_symtab_read): Remove declaration.
13238 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13239 compunit_filetabs.
13240
d8aeb77f
TT
132412019-01-09 Tom Tromey <tom@tromey.com>
13242
13243 * symtab.c (lookup_objfile_from_block)
13244 (find_pc_sect_compunit_symtab, search_symbols)
13245 (default_collect_symbol_completion_matches_break_on): Use
13246 objfile_compunits.
13247 * objfiles.h (ALL_COMPUNITS): Remove.
13248 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13249 * cp-support.c (add_symbol_overload_list_qualified): Use
13250 objfile_compunits.
13251 * ada-lang.c (ada_collect_symbol_completion_matches)
13252 (ada_add_global_exceptions): Use objfile_compunits.
13253
592553c4
TT
132542019-01-09 Tom Tromey <tom@tromey.com>
13255
13256 * source.c (select_source_symtab)
13257 (forget_cached_source_info_for_objfile): Remove declaration.
13258 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13259 declaration.
13260 * maint.c (count_symtabs_and_blocks): Remove declaration.
13261 * cp-support.c (add_symbol_overload_list_qualified): Remove
13262 declaration.
13263 * coffread.c (coff_symtab_read): Remove declaration.
13264 * symtab.c (lookup_symbol_in_objfile_symtabs)
13265 (basic_lookup_transparent_type_1): Use objfile_compunits.
13266 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13267 (info_sources_command, search_symbols)
13268 (default_collect_symbol_completion_matches_break_on)
13269 (make_source_files_completion_list): Remove declaration.
13270 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13271 (ada_collect_symbol_completion_matches)
13272 (ada_add_global_exceptions): Remove declaration.
13273 * linespec.c (iterate_over_all_matching_symtabs): Use
13274 objfile_compunits.
13275 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13276 (class objfile_compunits): New.
13277 (ALL_COMPUNITS): Use objfile_compunits.
13278 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13279 (maintenance_check_symtabs, maintenance_info_line_tables): Use
13280 objfile_compunits.
13281 * objfiles.c (objfile_relocate1): Use objfile_compunits.
13282
5325b9bf
TT
132832019-01-09 Tom Tromey <tom@tromey.com>
13284
13285 * symtab.c (search_symbols)
13286 (default_collect_symbol_completion_matches_break_on): Use
13287 objfile_msymbols.
13288 * ada-lang.c (ada_lookup_simple_minsym)
13289 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13290 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13291 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13292 objfile_msymbols.
13293 * coffread.c (coff_symfile_read): Use objfile_msymbols.
13294 * symmisc.c (dump_msymbols): Use objfile_msymbols.
13295 * objc-lang.c (find_methods): Use objfile_msymbols.
13296 (info_selectors_command, info_classes_command): Likewise.
13297 * stabsread.c (scan_file_globals): Use objfile_msymbols.
13298 * objfiles.h (class objfile_msymbols): New.
13299 (ALL_OBJFILE_MSYMBOLS): Remove.
13300 (ALL_MSYMBOLS): Remove.
13301
cac85af2
TT
133022019-01-09 Tom Tromey <tom@tromey.com>
13303
13304 * common/next-iterator.h (next_adapter): Add Iterator template
13305 parameter.
13306 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13307 (class all_objfiles_safe): New.
13308 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13309 * objfiles.c (put_objfile_before): Update comment.
13310 (add_separate_debug_objfile): Likewise.
13311 (free_all_objfiles): Use all_objfiles_safe.
13312 (objfile_purge_solibs): Likewise.
13313
aed57c53
TT
133142019-01-09 Tom Tromey <tom@tromey.com>
13315
13316 * symtab.c (iterate_over_symtabs, matching_obj_sections)
13317 (expand_symtab_containing_pc, lookup_static_symbol)
13318 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13319 (find_symbol_at_address, find_line_symtab, find_main_name): Use
13320 all_objfiles.
13321 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13322 * breakpoint.c (create_overlay_event_breakpoint)
13323 (create_longjmp_master_breakpoint)
13324 (create_std_terminate_master_breakpoint)
13325 (create_exception_master_breakpoint): Use all_objfiles.
13326 * linux-thread-db.c (try_thread_db_load_from_pdir)
13327 (has_libpthread): Use all_objfiles.
13328 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13329 * linespec.c (iterate_over_all_matching_symtabs)
13330 (search_minsyms_for_name): Use all_objfiles.
13331 * maint.c (maintenance_info_sections): Use all_objfiles.
13332 * main.c (captured_main_1): Use all_objfiles.
13333 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13334 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13335 * guile/scm-pretty-print.c
13336 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13337 * solib-spu.c (append_ocl_sos): Use all_objfiles.
13338 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13339 (maintenance_print_msymbols): Use all_objfiles.
13340 * source.c (select_source_symtab): Use all_objfiles.
13341 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13342 * symfile.c (remove_symbol_file_command)
13343 (expand_symtabs_matching, map_symbol_filenames): Use
13344 all_objfiles.
13345 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13346 all_objfiles.
13347 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13348 * objc-lang.c (find_methods): Use all_objfiles.
13349 * objfiles.c (have_partial_symbols, have_full_symbols)
13350 (have_minimal_symbols, qsort_cmp)
13351 (default_iterate_over_objfiles_in_search_order): Use
13352 all_objfiles.
13353 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13354 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13355 (maintenance_check_psymtabs): Use all_objfiles.
13356 (ALL_PSYMTABS): Remove.
13357 * compile/compile-object-run.c (do_module_cleanup): Use
13358 all_objfiles.
13359 * blockframe.c (find_pc_partial_function): Use all_objfiles.
13360 * cp-support.c (add_symbol_overload_list_qualified): Use
13361 all_objfiles.
13362 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13363 Use all_objfiles.
13364 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13365 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13366 all_objfiles.
13367 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13368 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13369 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13370 Uses all_objfiles.
13371 * solib.c (solib_read_symbols): Use all_objfiles
13372
99d89cde
TT
133732019-01-09 Tom Tromey <tom@tromey.com>
13374
13375 * probe.c (parse_probes_in_pspace): Use all_objfiles.
13376 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13377 all_objfiles.
13378 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13379 * symmisc.c (print_symbol_bcache_statistics)
13380 (print_objfile_statistics, maintenance_print_objfiles)
13381 (maintenance_info_symtabs, maintenance_check_symtabs)
13382 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13383 all_objfiles.
13384 * source.c (forget_cached_source_info): Use all_objfiles.
13385 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13386 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13387 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13388 * objfiles.c (update_section_map): Use all_objfiles.
13389 (shared_objfile_contains_address_p): Likewise.
13390 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13391 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13392
21708325
TT
133932019-01-09 Tom Tromey <tom@tromey.com>
13394
13395 * common/next-iterator.h: New file.
13396 * objfiles.h (class all_objfiles): New.
13397 (struct objfile_iterator): New.
13398
669e09f6
PW
133992019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13400
13401 * NEWS: Move the description of the changed "frame", "select-frame",
13402 and "info frame" commands to the Changed commands section.
13403
041be526
SM
134042019-01-09 Simon Marchi <simon.marchi@ericsson.com>
13405
13406 * gdbtypes.c (check_stub_method_group): Remove handling of old
13407 mangling schemes.
13408 * linespec.c (find_methods): Likewise.
13409 * stabsread.c (read_member_functions): Likewise.
13410 * valops.c (search_struct_method): Likewise.
13411 (value_struct_elt_for_reference): Likewise.
13412 * NEWS: Mention this change.
13413
0e2a2133
AB
134142019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
13415
13416 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13417 print_source_lines.
13418 * source.c (print_source_lines_base): Update line number check.
13419 (print_source_lines): New function.
13420 (source_lines_range::source_lines_range): New function.
13421 * source.h (class source_lines_range): New class.
13422 (print_source_lines): New declaration.
13423
1055a3b4
PW
134242019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13425
13426 * linespec.c (linespec_state_destructor): Free self->canonical_names.
13427
cfeadda5
TT
134282019-01-08 Tom Tromey <tom@tromey.com>
13429 Simon Marchi <simon.marchi@ericsson.com>
13430
13431 PR gdb/24060
13432 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13433 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13434 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13435 * f-exp.y (DOLLAR_VARIABLE): Likewise.
13436 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13437 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13438
583068ca
AB
134392019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13440
13441 * source.c (select_source_symtab): Move header comment to
13442 declaration in source.h.
13443 (forget_cached_source_info_for_objfile): Likewise.
13444 (forget_cached_source_info): Likewise.
13445 (identify_source_line): Likewise.
13446 * source.h (identify_source_line): Move declaration from symtab.h
13447 and add comment from source.c
13448 (print_source_lines): Likewise.
13449 (forget_cached_source_info_for_objfile): Likewise.
13450 (forget_cached_source_info): Likewise.
13451 (select_source_symtab): Likewise.
13452 (enum print_source_lines_flag): Move definition from symtab.h.
13453 * symtab.h (identify_source_line): Move declaration to source.h.
13454 (print_source_lines): Likewise.
13455 (forget_cached_source_info_for_objfile): Likewise.
13456 (forget_cached_source_info): Likewise.
13457 (select_source_symtab): Likewise.
13458 (enum print_source_lines_flag): Move definition to source.h.
13459 * tui/tui-hooks.c: Add 'source.h' include.
13460
ec98a4ad
AB
134612019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13462
13463 * source.c (print_source_lines_base): Handle requests to print
13464 reverse line number sequences, and guard against empty lines
13465 string.
13466
62ea19c1
AB
134672019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13468
13469 * source.c (print_source_lines_base): Fix skip of '\r' if next
13470 character is '\n'.
13471
9d30e1fd
TT
134722019-01-06 Tom Tromey <tom@tromey.com>
13473
13474 * c-exp.y (struct c_parse_state) <macro_original_text,
13475 expansion_obstack>: New member.
13476 (macro_original_text, expansion_obstack): Remove globals.
13477 (scan_macro_expansion, scanning_macro_expansion)
13478 (finished_macro_expansion): Update.
13479 (scan_macro_cleanup): Remove.
13480 (yylex, c_parse): Update.
13481
c65bac38
TT
134822019-01-06 Tom Tromey <tom@tromey.com>
13483
13484 * c-exp.y (struct c_parse_state) <strings>: New member.
13485 (operator_stoken): Update.
13486
02e12e38
TT
134872019-01-06 Tom Tromey <tom@tromey.com>
13488
13489 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
13490 (union type_stack_elt) <typelist_val>: Now a pointer to
13491 std::vector.
13492 (type_stack_cleanup): Don't declare.
13493 (push_typelist): Update.
13494 * parse.c (pop_typelist): Return a std::vector.
13495 (push_typelist): Take a std::vector.
13496 (follow_types): Update. Do not free args.
13497 (type_stack_cleanup): Remove.
13498 * c-exp.y (struct c_parse_state): New.
13499 (cpstate): New global.
13500 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13501 (nonempty_typelist): Update.
13502 (func_mod): Create a new vector.
13503 (c_parse): Create a c_parse_state.
13504 (check_parameter_typelist): Do not delete params.
13505 (function_method): Update. Do not delete type_list.
13506
f097f5ad
TT
135072019-01-06 Tom Tromey <tom@tromey.com>
13508
13509 PR gdb/28155:
13510 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13511 check_typedef.
13512 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13513 (print_return_value): Likewise.
13514
d2adf9f1
TT
135152019-01-05 Tom Tromey <tom@tromey.com>
13516
13517 * contrib/cleanup_check.py: Remove.
13518 * contrib/gcc-with-excheck: Remove.
13519 * contrib/exsummary.py: Remove.
13520 * contrib/excheck.py: Remove.
13521
2eab46b1
JB
135222019-01-05 Joel Brobecker <brobecker@adacore.com>
13523
13524 * thread.c (delete_thread_1): Add gdb_assert that THR is not
13525 NULL. Initialize tpprev to NULL instead of assigning it
13526 to NULL on the next statement.
13527 * windows-nat.c (windows_delete_thread): Remove check for
13528 main_thread_id before printing thread exit notifications.
13529 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13530 Remove thread ID check against main_thread_id.
13531 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13532 windows_delete_thread.
13533 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13534
48c5e7e2
TT
135352019-01-04 Tom Tromey <tom@tromey.com>
13536
13537 * compile/compile.c (_initialize_compile): Use upper case for
13538 metasyntactic variables.
13539 * symmisc.c (_initialize_symmisc): Use upper case for
13540 metasyntactic variables.
13541 * psymtab.c (_initialize_psymtab): Use upper case for
13542 metasyntactic variables.
13543 * demangle.c (demangle_command): Use upper case for metasyntactic
13544 variables.
13545 (_initialize_demangler): Likewise.
13546 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13547 variables.
13548
986041cd
TT
135492019-01-03 Tom Tromey <tom@tromey.com>
13550
13551 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13552
7c711119
TT
135532019-01-03 Tom Tromey <tom@tromey.com>
13554
13555 * python/py-symtab.c (salpy_str): Update.
13556 (struct salpy_sal_object) <symtab>: Now a PyObject.
13557 (salpy_dealloc): Update.
13558 (del_objfile_sal): Use gdbpy_ref.
13559
1b20edf0
TT
135602019-01-03 Tom Tromey <tom@tromey.com>
13561
13562 * python/py-type.c (convert_field): Use new_reference. Return
13563 gdbpy_ref.
13564 (make_fielditem): Return gdbpy_ref.
13565 (typy_fields): Update.
13566 (typy_getitem): Update.
13567 (field_name): Return gdbpy_ref. Use new_reference.
13568 (typy_iterator_iternext): Update.
13569
ea41325b
TT
135702019-01-03 Tom Tromey <tom@tromey.com>
13571
13572 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13573
2a3c71d6
TT
135742019-01-03 Tom Tromey <tom@tromey.com>
13575
13576 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13577 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13578 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13579 (pspy_set_frame_filters, pspy_set_frame_unwinders)
13580 (pspy_set_type_printers): Likewise.
13581 * python/py-function.c (fnpy_init): Use gdbpy_ref.
13582 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13583 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13584 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13585 (objfpy_set_type_printers): Likewise.
13586
5c329e6a
TT
135872019-01-03 Tom Tromey <tom@tromey.com>
13588
13589 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13590 (gdbpy_print_stack): Use gdbpy_err_fetch.
13591 * python/python-internal.h (class gdbpy_err_fetch): New class.
13592 (class gdbpy_enter) <m_error_type, m_error_value,
13593 m_error_traceback>: Remove.
13594 <m_error>: New member.
13595 (gdbpy_exception_to_string): Don't declare.
13596 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13597 * python/py-value.c (convert_value_from_python): Use
13598 gdbpy_err_fetch.
13599 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13600 gdbpy_exception_to_string.
13601 (gdbpy_handle_exception): Use gdbpy_err_fetch.
13602 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13603 gdbpy_err_fetch.
13604
169bb27b
AB
136052019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13606
13607 * linux-nat.c (delete_lwp_cleanup): Delete.
13608 (struct lwp_deleter): New struct.
13609 (lwp_info_up): New typedef.
13610 (linux_nat_target::follow_fork): Delete cleanup, and make use of
13611 lwp_info_up.
13612
a07c8880
AB
136132019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13614
13615 * linux-fork.c (class scoped_switch_fork_info): New class.
13616 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13617
26089c49
AB
136182019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13619
13620 * valops.c (find_overload_match): Remove use of null_cleanup, and
13621 calls to do_cleanups.
13622
06d3e5b0
AB
136232019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13624
13625 * compile/compile-cplus-types.c
13626 (compile_cplus_instance::decl_name): Handle changes to
13627 cp_func_name.
13628 * cp-support.c (cp_func_name): Update header comment, update
13629 return type.
13630 * cp-support.h (cp_func_name): Update return type in declaration.
13631 * valops.c (find_overload_match): Move temp_func local to top
13632 level of function and change its type. Use temp_func to hold and
13633 delete temporary string obtained from cp_func_name.
13634
66644cd3
AB
136352019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13636
13637 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13638 gdb::char_vector, remove cleanup, and update uses of `msg`.
13639
592d8c0a
JW
136402019-01-03 Jim Wilson <jimw@sifive.com>
13641
13642 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13643
c55d06ec
TT
136442019-01-02 Tom Tromey <tom@tromey.com>
13645
13646 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13647 (tdesc_parse_xml): Remove cleanups.
13648 * target-descriptions.h (make_cleanup_free_target_description):
13649 Don't declare.
13650 (target_desc_deleter): New struct.
13651 (target_desc_up): New typedef.
13652 * target-descriptions.c (target_desc_deleter::operator()): Rename
13653 from free_target_description.
13654 (make_cleanup_free_target_description): Remove.
13655
3a6ae42d
TT
136562019-01-02 Tom Tromey <tom@tromey.com>
13657
13658 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
13659 constructor, destructor.
13660 (linespec_parser): Remove typedef.
13661 (~linespec_parser): Rename from linespec_parser_delete.
13662 (linespec_lex_to_end, linespec_complete_label)
13663 (linespec_complete): Update.
13664 (decode_line_full): Remove cleanups.
13665 (decode_line_1): Update.
13666
61fd3e73
TT
136672019-01-02 Tom Tromey <tom@tromey.com>
13668
13669 * python/python-internal.h (inferior_to_inferior_object): Change
13670 return type.
13671 * python/py-exitedevent.c (create_exited_event_object): Update.
13672 * python/py-inferior.c (inferior_to_inferior_object): Return
13673 gdbpy_ref.
13674 (python_new_inferior, python_inferior_deleted)
13675 (thread_to_thread_object, delete_thread_object)
13676 (build_inferior_list, gdbpy_selected_inferior): Update.
13677 * python/py-infthread.c (create_thread_object): Update. Also fail
13678 if inferior_to_inferior_object fails.
13679
d20172fc
SM
136802019-01-02 Simon Marchi <simon.marchi@ericsson.com>
13681
13682 * inferior.h (class inferior) <displaced_step_state>: New field.
13683 * infrun.h (struct displaced_step_state): Move here from
13684 infrun.c. Initialize fields, add constructor.
13685 <inf>: Remove field.
13686 <reset>: New method.
13687 * infrun.c (struct displaced_step_inferior_state): Move to
13688 infrun.h.
13689 (displaced_step_inferior_states): Remove.
13690 (get_displaced_stepping_state): Adust.
13691 (displaced_step_in_progress_any_inferior): Adjust.
13692 (displaced_step_in_progress_thread): Adjust.
13693 (displaced_step_in_progress): Adjust.
13694 (add_displaced_stepping_state): Remove.
13695 (get_displaced_step_closure_by_addr): Adjust.
13696 (remove_displaced_stepping_state): Remove.
13697 (infrun_inferior_exit): Call displaced_step_state.reset.
13698 (use_displaced_stepping): Don't check for NULL.
13699 (displaced_step_prepare_throw): Call
13700 get_displaced_stepping_state.
13701 (displaced_step_fixup): Don't check for NULL.
13702 (prepare_for_detach): Don't check for NULL.
13703
e3319240
PW
137042019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13705
13706 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13707 in case of call that did not complete.
13708
5d36dfb9
AU
137092019-01-02 Andrey Utkin <autkin@undo.io>
13710
13711 * symfile.c (find_separate_debug_file): Fix search of debug files for
13712 remote debuggee.
13713
8833fbf0
TT
137142019-01-02 Tom Tromey <tom@tromey.com>
13715
13716 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13717 indentation.
13718 * python/py-frame.c (frapy_older): Remove cast.
13719 (frapy_newer): Likewise.
13720 * python/py-breakpoint.c (local_setattro): Remove cast.
13721 * python/py-arch.c (archpy_name): Remove local variable.
13722 * python/py-type.c (gdbpy_lookup_type): Remove cast.
13723
4ada3dfd
JB
137242019-01-02 Joel Brobecker <brobecker@adacore.com>
13725
13726 * unittests/basic_string_view/element_access/char/empty.cc:
13727 Fix year range in copyright header.
13728
113b7b81
AB
137292019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
13730
13731 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13732 Delete.
13733 <operator==>: Update with for removed field.
13734 <hash>: Likewise.
13735 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13736 <isa_features>: ...this.
13737 <abi_features>: New field.
13738 (riscv_isa_flen): Update comment.
13739 (riscv_abi_xlen): New declaration.
13740 (riscv_abi_flen): New declaration.
13741 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13742 isa_features.
13743 (riscv_abi_xlen): New function.
13744 (riscv_isa_flen): Update to get answer from isa_features.
13745 (riscv_abi_flen): New function.
13746 (riscv_has_fp_abi): Update to get answer from abi_features.
13747 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13748 xlen and flen.
13749 (riscv_call_info) <xlen, flen>: Update comment.
13750 (riscv_call_arg_struct): Remove invalid assertions
13751 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13752 is removed.
13753 (riscv_gdbarch_init): Gather isa features and abi features
13754 separately, ensure both match on the gdbarch when reusing an old
13755 gdbarch. Relax an error check to allow 32-bit abi float to run on
13756 a target with 64-bit float hardware.
13757
b18ca514
PW
137582019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13759
13760 * source.c (search_command_helper): Stop reverse search
13761 when line 1 has been searched.
13762
ec70d8db
PW
137632019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13764
13765 * record-full.c (record_full_base_target::close): Rewrite
13766 record_full_core_buf_list free logic.
13767
5b38f9c1
PW
137682019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13769
13770 * break-catch-syscall.c (print_one_catch_syscall): xfree
13771 the last text.
13772
66d91b39
JB
137732019-01-01 Joel Brobecker <brobecker@adacore.com>
13774
13775 * top.c (print_gdb_version): Update Copyright year in version
13776 message.
13777
42a4f53d
JB
137782019-01-01 Joel Brobecker <brobecker@adacore.com>
13779
13780 Update copyright year range in all GDB files.
13781
7e955d83 137822019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 13783
5bbd631d 13784 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 13785
5bbd631d 13786For older changes see ChangeLog-2018.
c906108c
SS
13787\f
13788Local Variables:
13789mode: change-log
13790left-margin: 8
13791fill-column: 74
13792version-control: never
57da7796 13793coding: utf-8
c906108c 13794End:
5bbd631d 13795
This page took 4.098172 seconds and 4 git commands to generate.