gdb/ChangeLog

   1 2020-06-17  Pedro Alves  <palves@redhat.com>
   2
   3         * gdbthread.h (thread_control_state) <trap_expected> Update
   4         comments.
   5
   6 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
   7
   8         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
   9         ada_language::lookup_symbol_nonlocal.
  10         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
  11         (ada_language::lookup_symbol_nonlocal): New member function,
  12         implementation from ada_lookup_symbol_nonlocal.
  13         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
  14         initializer.
  15         (cplus_language_data): Delete la_lookup_symbol_nonlocal
  16         initializer.
  17         (cplus_language::lookup_symbol_nonlocal): New member function.
  18         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
  19         (minimal_language_data) Likewise.
  20         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
  21         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
  22         initializer.
  23         (d_language::lookup_symbol_nonlocal): New member function.
  24         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
  25         initializer.
  26         (f_language::lookup_symbol_nonlocal): New member function.
  27         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
  28         initializer.
  29         * language.c (unknown_language_data): Likewise.
  30         (auto_language_data): Likewise.
  31         * language.h (language_data): Delete la_lookup_symbol_nonlocal
  32         field.
  33         (language_defn::lookup_symbol_nonlocal): New member function.
  34         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
  35         initializer.
  36         * objc-lang.c (objc_language_data): Likewise.
  37         * opencl-lang.c (opencl_language_data): Likewise.
  38         * p-lang.c (pascal_language_data): Likewise.
  39         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
  40         rust_language::lookup_symbol_nonlocal.
  41         (rust_language_data): Delete la_lookup_symbol_nonlocal
  42         initializer.
  43         (rust_language::lookup_symbol_nonlocal): New member function,
  44         implementation from rust_lookup_symbol_nonlocal.
  45         * symtab.c (lookup_symbol_aux): Update call to
  46         lookup_symbol_nonlocal.
  47         (basic_lookup_symbol_nonlocal): Rename to...
  48         (language_defn::lookup_symbol_nonlocal): ...this, and update
  49         header comment.  Remove language_defn parameter, and replace with
  50         uses of `this'.
  51         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
  52
  53 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
  54
  55         * ada-lang.c (ada_language_data): Delete la_value_print_inner
  56         initializer.
  57         (ada_language::value_print_inner): New member function.
  58         * c-lang.c (c_language_data): Delete la_value_print_inner
  59         initializer.
  60         (cplus_language_data): Likewise.
  61         (asm_language_data): Likewise.
  62         (minimal_language_data): Likewise.
  63         * d-lang.c (d_language_data): Likewise.
  64         (d_language::value_print_inner): New member function.
  65         * f-lang.c (f_language_data): Delete la_value_print_inner
  66         initializer.
  67         (f_language::value_print_inner): New member function.
  68         * f-lang.h (f_value_print_innner): Rename to...
  69         (f_value_print_inner): ...this (note spelling of 'inner').
  70         * f-valprint.c (f_value_print_innner): Rename to...
  71         (f_value_print_inner): ...this (note spelling of 'inner').
  72         * go-lang.c (go_language_data): Delete la_value_print_inner
  73         initializer.
  74         (go_language::value_print_inner): New member function.
  75         * language.c (language_defn::value_print_inner): Define new member
  76         function.
  77         (unk_lang_value_print_inner): Delete.
  78         (unknown_language_data): Delete la_value_print_inner initializer.
  79         (unknown_language::value_print_inner): New member function.
  80         (auto_language_data): Delete la_value_print_inner initializer.
  81         (auto_language::value_print_inner): New member function.
  82         * language.h (language_data): Delete la_value_print_inner field.
  83         (language_defn::value_print_inner): Delcare new member function.
  84         * m2-lang.c (m2_language_data): Delete la_value_print_inner
  85         initializer.
  86         (m2_language::value_print_inner): New member function.
  87         * objc-lang.c (objc_language_data): Delete la_value_print_inner
  88         initializer.
  89         * opencl-lang.c (opencl_language_data): Likewise.
  90         * p-lang.c (pascal_language_data): Likewise.
  91         (pascal_language::value_print_inner): New member function.
  92         * rust-lang.c (rust_language_data): Delete la_value_print_inner
  93         initializer.
  94         (rust_language::value_print_inner): New member function.
  95         * valprint.c (do_val_print): Update call to value_print_inner.
  96
  97 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
  98
  99         * ada-lang.c (ada_language_data): Delete la_value_print
 100         initializer.
 101         (ada_language::value_print): New member function.
 102         * c-lang.c (c_language_data): Delete la_value_print initializer.
 103         (cplus_language_data): Likewise.
 104         (asm_language_data): Likewise.
 105         (minimal_language_data): Likewise.
 106         * d-lang.c (d_language_data): Likewise.
 107         * f-lang.c (f_language_data): Likewise.
 108         * go-lang.c (go_language_data): Likewise.
 109         * language.c (unk_lang_value_print): Delete.
 110         (language_defn::value_print): Define new member function.
 111         (unknown_language_data): Delete la_value_print initializer.
 112         (unknown_language::value_print): New member function.
 113         (auto_language_data): Delete la_value_print initializer.
 114         (auto_language::value_print): New member function.
 115         * language.h (language_data): Delete la_value_print field.
 116         (language_defn::value_print): Declare new member function.
 117         (LA_VALUE_PRINT): Update call to value_print.
 118         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
 119         * objc-lang.c (objc_language_data): Likewise.
 120         * opencl-lang.c (opencl_language_data): Likewise.
 121         * p-lang.c (pascal_language_data): Likewise.
 122         (pascal_language::value_print): New member function.
 123         * rust-lang.c (rust_language_data): Delete la_value_print
 124         initializer.
 125
 126 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 127
 128         * ada-lang.c (ada_watch_location_expression): Rename to
 129         ada_language::watch_location_expression.
 130         (ada_language_data): Delete la_watch_location_expression
 131         initializer.
 132         (ada_language::watch_location_expression): New member function,
 133         implementation from ada_watch_location_expression.
 134         * breakpoint.c (watch_command_1): Update call to
 135         watch_location_expression.
 136         * c-lang.c (c_watch_location_expression): Rename to
 137         language_defn::watch_location_expression.
 138         (c_language_data): Delete la_watch_location_expression
 139         initializer.
 140         (cplus_language_data): Likewise.
 141         (asm_language_data): Likewise.
 142         (minimal_language_data): Likewise.
 143         * c-lang.h (c_watch_location_expression): Delete declaration.
 144         * d-lang.c (d_language_data): Delete la_watch_location_expression
 145         initializer.
 146         * f-lang.c (f_language_data): Likewise.
 147         * go-lang.c (go_language_data): Likewise.
 148         * language.c (language_defn::watch_location_expression): Member
 149         function implementation from c_watch_location_expression.
 150         (unknown_language_data): Delete la_watch_location_expression
 151         initializer.
 152         (auto_language_data): Likewise.
 153         * language.h (language_data): Delete la_watch_location_expression
 154         field.
 155         (language_defn::watch_location_expression): Declare new member
 156         function.
 157         * m2-lang.c (m2_language_data): Delete
 158         la_watch_location_expression initializer.
 159         * objc-lang.c (objc_language_data): Likewise.
 160         * opencl-lang.c (opencl_language_data): Likewise.
 161         * p-lang.c (pascal_language_data): Likewise.
 162         * rust-lang.c (rust_watch_location_expression): Rename to
 163         rust_language::watch_location_expression.
 164         (rust_language_data): Delete la_watch_location_expression
 165         initializer.
 166         (rust_language::watch_location_expression): New member function,
 167         implementation from rust_watch_location_expression.
 168
 169 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 170
 171         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
 172         ada_language::collect_symbol_completion_matches.
 173         (ada_language_data): Delete la_collect_symbol_completion_matches
 174         initializer.
 175         (ada_language::collect_symbol_completion_matches): New member
 176         function, implementation from
 177         ada_collect_symbol_completion_matches.
 178         * c-lang.c (c_language_data): Delete
 179         la_collect_symbol_completion_matches initializer.
 180         (cplus_language_data): Likewise.
 181         (asm_language_data): Likewise.
 182         (minimal_language_data): Likewise.
 183         * d-lang.c (d_language_data): Likewise.
 184         * f-lang.c (f_collect_symbol_completion_matches): Rename to
 185         f_language::collect_symbol_completion_matches.
 186         (f_language_data): Delete la_collect_symbol_completion_matches
 187         initializer.
 188         (f_language::collect_symbol_completion_matches) New member
 189         function, implementation from f_collect_symbol_completion_matches.
 190         * go-lang.c (go_language_data): Delete
 191         la_collect_symbol_completion_matches initializer.
 192         * language.c (unknown_language_data): Likewise.
 193         (auto_language_data): Likewise.
 194         * language.h (language_data): Delete
 195         la_collect_symbol_completion_matches field.
 196         (language_defn::collect_symbol_completion_matches): New member
 197         function.
 198         * m2-lang.c (m2_language_data): Delete
 199         la_collect_symbol_completion_matches initializer.
 200         * objc-lang.c (objc_language_data): Likewise.
 201         * opencl-lang.c (opencl_language_data): Likewise.
 202         * p-lang.c (pascal_language_data): Likewise.
 203         * rust-lang.c (rust_language_data): Likewise.
 204         * symtab.c (default_collect_symbol_completion_matches): Delete.
 205         (collect_symbol_completion_matches): Update call to
 206         collect_symbol_completion_matches.
 207         (collect_symbol_completion_matches_type): Likewise.
 208         * symtab.h (default_collect_symbol_completion_matches): Delete
 209         declaration.
 210
 211 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 212
 213         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
 214         (ada_language_data): Delete la_word_break_characters initializer.
 215         (ada_language::word_break_characters): New member function.
 216         * c-lang.c (c_language_data): Delete la_word_break_characters
 217         initializer.
 218         (cplus_language_data): Likewise.
 219         (asm_language_data): Likewise.
 220         (minimal_language_data): Likewise.
 221         * completer.c: Update global comment.
 222         (advance_to_expression_complete_word_point): Update call to
 223         word_break_characters.
 224         (complete_files_symbols): Likewise.
 225         (complete_line_internal_1): Likewise.
 226         (default_completer_handle_brkchars): Likewise.
 227         (skip_quoted_chars): Likewise.
 228         * d-lang.c (d_language_data): Delete la_word_break_characters
 229         initializer.
 230         * f-lang.c (f_word_break_characters): Delete.
 231         (f_language_data): Delete la_word_break_characters initializer.
 232         (f_language::word_break_characters): New member function.
 233         * go-lang.c (go_language_data): Delete la_word_break_characters
 234         initializer.
 235         * language.c (unknown_language_data): Likewise.
 236         (auto_language_data): Likewise.
 237         * language.h (default_word_break_characters): Move declaration to
 238         earlier in the file.
 239         (language_data): Delete la_word_break_characters field.
 240         (language_defn::word_break_characters): New member function.
 241         * m2-lang.c (m2_language_data): Delete la_word_break_characters
 242         initializer.
 243         * objc-lang.c (objc_language_data): Likewise.
 244         * opencl-lang.c (opencl_language_data): Likewise.
 245         * p-lang.c (pascal_language_data): Likewise.
 246         * rust-lang.c (rust_language_data): Likewise.
 247
 248 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 249
 250         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
 251         (ada_language_data): Delete la_get_symbol_name_matcher
 252         initializer.
 253         (language_defn::get_symbol_name_matcher_inner): New member
 254         function.
 255         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
 256         initializer.
 257         (cplus_language_data): Likewise.
 258         (cplus_language::get_symbol_name_matcher_inner): New member
 259         function.
 260         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
 261         (minimal_language_data): Likewise.
 262         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
 263         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
 264         initializer.
 265         * dictionary.c (iter_match_first_hashed): Update call to
 266         get_symbol_name_matcher.
 267         (iter_match_next_hashed): Likewise.
 268         (iter_match_next_linear): Likewise.
 269         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
 270         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
 271         initializer.
 272         (f_language::get_symbol_name_matcher_inner): New member function.
 273         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
 274         initializer.
 275         * language.c (default_symbol_name_matcher): Update header comment,
 276         make static.
 277         (language_defn::get_symbol_name_matcher): New definition.
 278         (language_defn::get_symbol_name_matcher_inner): Likewise.
 279         (get_symbol_name_matcher): Delete.
 280         (unknown_language_data): Delete la_get_symbol_name_matcher
 281         initializer.
 282         (auto_language_data): Likewise.
 283         * language.h (language_data): Delete la_get_symbol_name_matcher
 284         field.
 285         (language_defn::get_symbol_name_matcher): New member function.
 286         (language_defn::get_symbol_name_matcher_inner): Likewise.
 287         (default_symbol_name_matcher): Delete declaration.
 288         * linespec.c (find_methods): Update call to
 289         get_symbol_name_matcher.
 290         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
 291         initializer.
 292         * minsyms.c (lookup_minimal_symbol): Update call to
 293         get_symbol_name_matcher.
 294         (iterate_over_minimal_symbols): Likewise.
 295         * objc-lang.c (objc_language_data): Delete
 296         la_get_symbol_name_matcher initializer.
 297         * opencl-lang.c (opencl_language_data): Likewise.
 298         * p-lang.c (pascal_language_data): Likewise.
 299         * psymtab.c (psymbol_name_matches): Update call to
 300         get_symbol_name_matcher.
 301         * rust-lang.c (rust_language_data): Delete
 302         la_get_symbol_name_matcher initializer.
 303         * symtab.c (symbol_matches_search_name): Update call to
 304         get_symbol_name_matcher.
 305         (compare_symbol_name): Likewise.
 306
 307 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 308
 309         * ada-lang.c (ada_language_data): Delete la_compute_program
 310         initializer.
 311         * c-lang.c (c_language_data): Likewise.
 312         (c_language::compute_program): New member function.
 313         (cplus_language_data): Delete la_compute_program initializer.
 314         (cplus_language::compute_program): New member function.
 315         (asm_language_data): Delete la_compute_program initializer.
 316         (minimal_language_data): Likewise.
 317         * c-lang.h (c_compute_program): Update comment.
 318         (cplus_compute_program): Likewise.
 319         * compile/compile-c-support.c (c_compute_program): Likewise.
 320         (cplus_compute_program): Likewise.
 321         * compile/compile.c (compile_to_object): Update call to
 322         la_compute_program.
 323         * d-lang.c (d_language_data): Delete la_compute_program
 324         initializer.
 325         * f-lang.c (f_language_data): Likewise.
 326         * go-lang.c (go_language_data): Likewise.
 327         * language.c (unknown_language_data): Likewise.
 328         (auto_language_data): Likewise.
 329         * language.h (language_data): Delete la_compute_program field.
 330         (language_defn::compute_program): New member function.
 331         * m2-lang.c (m2_language_data): Delete la_compute_program
 332         initializer.
 333         * objc-lang.c (objc_language_data): Likewise.
 334         * opencl-lang.c (opencl_language_data): Likewise.
 335         * p-lang.c (pascal_language_data): Likewise.
 336         * rust-lang.c (rust_language_data): Likewise.
 337
 338 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 339
 340         * ada-lang.c (ada_language_data) Delete
 341         la_class_name_from_physname initializer.
 342         * c-lang.c (c_language_data): Likewise.
 343         (cplus_language_data): Likewise.
 344         (cplus_language::class_name_from_physname): New member function.
 345         (asm_language_data): Delete la_class_name_from_physname
 346         initializer.
 347         (minimal_language_data): Likewise.
 348         * d-lang.c (d_language_data): Likewise.
 349         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
 350         method on language_defn class.
 351         (guess_full_die_structure_name): Likewise.
 352         * f-lang.c (f_language_data): Delete la_class_name_from_physname
 353         initializer.
 354         * go-lang.c (go_language_data): Likewise.
 355         * language.c (language_class_name_from_physname): Delete.
 356         (unk_lang_class_name): Delete.
 357         (unknown_language_data): Delete la_class_name_from_physname
 358         initializer.
 359         (auto_language_data): Likewise.
 360         * language.h (language_data): Delete la_class_name_from_physname
 361         field.
 362         (language_defn::class_name_from_physname): New function.
 363         (language_class_name_from_physname): Delete declaration.
 364         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
 365         initializer.
 366         * objc-lang.c (objc_language_data): Likewise.
 367         * opencl-lang.c (opencl_language_data): Likewise.
 368         * p-lang.c (pascal_language_data): Likewise.
 369         * rust-lang.c (rust_language_data): Likewise.
 370
 371 2020-06-16  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-data.h (STATUS_NAME): New macro.
 374         * tui/tui-layout.c (tui_remove_some_windows)
 375         (initialize_known_windows, tui_register_window)
 376         (tui_layout_split::remove_windows, initialize_layouts)
 377         (tui_new_layout_command): Don't use hard-coded window names.
 378
 379 2020-06-16  Tom Tromey  <tom@tromey.com>
 380
 381         PR tui/25348:
 382         * tui/tui.c (tui_ensure_readline_initialized): Rename from
 383         tui_initialize_readline.  Only run once.  Call rl_initialize.
 384         * tui/tui.h (tui_ensure_readline_initialized): Rename from
 385         tui_initialize_readline.
 386         * tui/tui-io.c (tui_setup_io): Call
 387         tui_ensure_readline_initialized.
 388         * tui/tui-interp.c (tui_interp::init): Update.
 389
 390 2020-06-16  Tom Tromey  <tom@tromey.com>
 391
 392         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
 393         Also preserve the status window.
 394
 395 2020-06-16  Tom Tromey  <tom@tromey.com>
 396
 397         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
 398         where m_window==nullptr.
 399
 400 2020-06-15  Tom Tromey  <tromey@adacore.com>
 401
 402         * windows-nat.c (windows_nat::handle_output_debug_string):
 403         Update.
 404         (windows_nat::handle_ms_vc_exception): Update.
 405         * target.h (target_read_string): Change API.
 406         * target.c (target_read_string): Change API.
 407         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
 408         Update.
 409         * solib-frv.c (frv_current_sos): Update.
 410         * solib-dsbt.c (dsbt_current_sos): Update.
 411         * solib-darwin.c (darwin_current_sos): Update.
 412         * linux-thread-db.c (inferior_has_bug): Update.
 413         * expprint.c (print_subexp_standard): Update.
 414         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
 415         (ada_exception_message_1): Update.
 416
 417 2020-06-15  Tom Tromey  <tromey@adacore.com>
 418
 419         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
 420
 421 2020-06-15  Tom Tromey  <tromey@adacore.com>
 422
 423         * valprint.c (read_string): Update comment.
 424         * target.c (MIN): Remove.
 425         (target_read_string): Rewrite.
 426
 427 2020-06-15  Tom Tromey  <tromey@adacore.com>
 428
 429         * corefile.c (read_memory_string): Remove.
 430         * ada-valprint.c (ada_value_print_ptr): Update.
 431         * ada-lang.h (ada_tag_name): Change return type.
 432         * ada-lang.c (type_from_tag): Update.
 433         (ada_tag_name_from_tsd): Change return type.  Use
 434         target_read_string.
 435         (ada_tag_name): Likewise.
 436         * gdbcore.h (read_memory_string): Don't declare.
 437
 438 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
 439
 440         * symtab.c (rbreak_command): Ignore Windows drive colon.
 441
 442 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
 443
 444         * NEWS: Mention removed GDBserver host support.
 445
 446 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
 447
 448         * features/riscv/rebuild-csr-xml.sh: Updated.
 449
 450 2020-06-11  Tom Tromey  <tom@tromey.com>
 451
 452         PR gdb/18318:
 453         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
 454
 455 2020-06-09  Jonny Grant  <jg@jguk.org>
 456 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
 457
 458         * main.c (captured_main_1): Don't print new line after help.
 459         (print_gdb_help): add mailing list and IRC channel information
 460         to --help.  Add new lines between items in the footer.  Remove
 461         quotes around bug url.
 462
 463 2020-06-11  Keith Seitz  <keiths@redhat.com>
 464
 465         PR gdb/21356
 466         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
 467         Resolve typedefs for type length calculations.
 468
 469 2020-06-10  Tom de Vries  <tdevries@suse.de>
 470
 471         PR ada/24713
 472         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
 473         (write_psymbols): Enable .gdb_index for ada.
 474         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
 475         ada.
 476
 477 2020-06-10  Tom de Vries  <tdevries@suse.de>
 478
 479         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
 480         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
 481         namei" instead of "const char *name" argument.
 482         (dw2_map_matching_symbols): Use "offset_type namei" variant of
 483         dw2_symtab_iter_init.
 484
 485 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 486
 487         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
 488         to use type::field and field::type instead.
 489
 490 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 491
 492         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
 493         to use field::type instead.
 494
 495 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 496
 497         * gdbtypes.h (struct field) <type, set_type>: New methods.
 498         Rename `type` field to...
 499         <m_type>: ... this.  Change references throughout to use type or
 500         set_type methods.
 501         (FIELD_TYPE): Use field::type.  Change call sites that modify
 502         the field's type to use field::set_type instead.
 503
 504 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 505
 506         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
 507         to use type::index_type instead.
 508
 509 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 510
 511         * gdbtypes.h (struct type) <index_type, set_index_type>: New
 512         methods.
 513         (TYPE_INDEX_TYPE): Use type::index_type.
 514         * gdbtypes.c (create_array_type_with_stride): Likewise.
 515
 516 2020-06-07  Tom Tromey  <tom@tromey.com>
 517
 518         * valprint.c (generic_val_print_float): Remove "embedded_offset"
 519         parameter.
 520         (generic_value_print): Update.
 521
 522 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 523
 524         Revert commit 982a38f60b0.
 525         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
 526
 527 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 528
 529         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
 530         avoid use after free.
 531
 532 2020-06-05  Tom de Vries  <tdevries@suse.de>
 533
 534         * NEWS: Fix typos.
 535
 536 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
 537
 538         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
 539         the per_bfd object.
 540         (dwarf2_read_debug_names): Likewise.
 541         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
 542         object when re-using a per_bfd object with an index.
 543
 544 2020-06-03  Tom de Vries  <tdevries@suse.de>
 545
 546         PR symtab/26046
 547         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
 548         children for C++.
 549         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
 550         DW_TAG_subprogram.
 551
 552 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 553
 554         * ada-lang.c (ada_language_data): Delete skip_trampoline
 555         initializer.
 556         * c-lang.c (c_language_data): Likewise.
 557         (cplus_language_data): Likewise.
 558         (cplus_language::skip_trampoline): New member function.
 559         (asm_language_data): Delete skip_trampoline initializer.
 560         (minimal_language_data): Likewise.
 561         * d-lang.c (d_language_data): Likewise.
 562         * f-lang.c (f_language_data): Likewise.
 563         * go-lang.c (go_language_data): Likewise.
 564         * language.c (unk_lang_trampoline): Delete function.
 565         (skip_language_trampoline): Update.
 566         (unknown_language_data): Delete skip_trampoline initializer.
 567         (auto_language_data): Likewise.
 568         * language.h (language_data): Delete skip_trampoline field.
 569         (language_defn::skip_trampoline): New function.
 570         * m2-lang.c (m2_language_data): Delete skip_trampoline
 571         initializer.
 572         * objc-lang.c (objc_skip_trampoline): Delete function, move
 573         implementation to objc_language::skip_trampoline.
 574         (objc_language_data): Delete skip_trampoline initializer.
 575         (objc_language::skip_trampoline): New member function with
 576         implementation from objc_skip_trampoline.
 577         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
 578         initializer.
 579         * p-lang.c (pascal_language_data): Likewise.
 580         * rust-lang.c (rust_language_data): Likewise.
 581
 582 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 583
 584         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
 585         (ada_language::demangle): New member function.
 586         * c-lang.c (c_language_data): Delete la_demangle initializer.
 587         (cplus_language_data): Delete la_demangle initializer.
 588         (cplus_language::demangle): New member function.
 589         (asm_language_data): Delete la_demangle initializer.
 590         (minimal_language_data): Delete la_demangle initializer.
 591         * d-lang.c (d_language_data): Delete la_demangle initializer.
 592         (d_language::demangle): New member function.
 593         * f-lang.c (f_language_data): Delete la_demangle initializer.
 594         (f_language::demangle): New member function.
 595         * go-lang.c (go_language_data): Delete la_demangle initializer.
 596         (go_language::demangle): New member function.
 597         * language.c (language_demangle): Update.
 598         (unk_lang_demangle): Delete.
 599         (unknown_language_data): Delete la_demangle initializer.
 600         (unknown_language::demangle): New member function.
 601         (auto_language_data): Delete la_demangle initializer.
 602         (auto_language::demangle): New member function.
 603         * language.h (language_data): Delete la_demangle field.
 604         (language_defn::demangle): New function.
 605         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
 606         * objc-lang.c (objc_language_data): Delete la_demangle
 607         initializer.
 608         (objc_language::demangle): New member function.
 609         * opencl-lang.c (opencl_language_data): Delete la_demangle
 610         initializer.
 611         * p-lang.c (pascal_language_data): Likewise.
 612         * rust-lang.c (rust_language_data): Likewise.
 613         (rust_language::demangle): New member function.
 614
 615 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 616
 617         * ada-lang.c (ada_language_data): Delete la_print_type
 618         initializer.
 619         (ada_language::print_type): New member function.
 620         * c-lang.c (c_language_data): Delete la_print_type initializer.
 621         (c_language::print_type): New member function.
 622         (cplus_language_data): Delete la_print_type initializer.
 623         (cplus_language::print_type): New member function.
 624         (asm_language_data): Delete la_print_type initializer.
 625         (asm_language::print_type): New member function.
 626         (minimal_language_data): Delete la_print_type initializer.
 627         (minimal_language::print_type): New member function.
 628         * d-lang.c (d_language_data): Delete la_print_type initializer.
 629         (d_language::print_type): New member function.
 630         * f-lang.c (f_language_data): Delete la_print_type initializer.
 631         (f_language::print_type): New member function.
 632         * go-lang.c (go_language_data): Delete la_print_type initializer.
 633         (go_language::print_type): New member function.
 634         * language.c (unk_lang_print_type): Delete.
 635         (unknown_language_data): Delete la_print_type initializer.
 636         (unknown_language::print_type): New member function.
 637         (auto_language_data): Delete la_print_type initializer.
 638         (auto_language::print_type): New member function.
 639         * language.h (language_data): Delete la_print_type field.
 640         (language_defn::print_type): New function.
 641         (LA_PRINT_TYPE): Update.
 642         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
 643         (m2_language::print_type): New member function.
 644         * objc-lang.c (objc_language_data): Delete la_print_type
 645         initializer.
 646         (objc_language::print_type): New member function.
 647         * opencl-lang.c (opencl_print_type): Delete, implementation moved
 648         to opencl_language::print_type.
 649         (opencl_language_data): Delete la_print_type initializer.
 650         (opencl_language::print_type): New member function, implementation
 651         from opencl_print_type.
 652         * p-lang.c (pascal_language_data): Delete la_print_type
 653         initializer.
 654         (pascal_language::print_type): New member function.
 655         * rust-lang.c (rust_print_type): Delete, implementation moved to
 656         rust_language::print_type.
 657         (rust_language_data): Delete la_print_type initializer.
 658         (rust_language::print_type): New member function, implementation
 659         from rust_print_type.
 660
 661 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 662
 663         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
 664         implementation moves to...
 665         (ada_language::sniff_from_mangled_name): ...here.  Update return
 666         type.
 667         (ada_language_data): Delete la_sniff_from_mangled_name
 668         initializer.
 669         * c-lang.c (c_language_data): Likewise.
 670         (cplus_language_data): Likewise.
 671         (cplus_language::sniff_from_mangled_name): New member function,
 672         implementation taken from gdb_sniff_from_mangled_name.
 673         (asm_language_data): Delete la_sniff_from_mangled_name
 674         initializer.
 675         (minimal_language_data): Likewise.
 676         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
 677         implementation moves to cplus_language::sniff_from_mangled_name.
 678         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
 679         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
 680         moves to...
 681         (d_language::sniff_from_mangled_name): ...here.
 682         (d_language_data): Delete la_sniff_from_mangled_name initializer.
 683         * f-lang.c (f_language_data): Likewise.
 684         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
 685         moves to...
 686         (go_language::sniff_from_mangled_name): ...here.
 687         (go_language_data): Delete la_sniff_from_mangled_name initializer.
 688         * language.c (language_sniff_from_mangled_name): Delete.
 689         (unknown_language_data): Delete la_sniff_from_mangled_name
 690         initializer.
 691         (auto_language_data): Likewise.
 692         * language.h (language_data): Delete la_sniff_from_mangled_name
 693         field.
 694         (language_defn::sniff_from_mangled_name): New function.
 695         (language_sniff_from_mangled_name): Delete declaration.
 696         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
 697         field.
 698         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
 699         implementation moves to...
 700         (objc_language::sniff_from_mangled_name): ...here.
 701         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
 702         * opencl-lang.c (opencl_language_data): Likewise.
 703         * p-lang.c (pascal_language_data): Likewise.
 704         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
 705         implementation moves to...
 706         (rust_language::sniff_from_mangled_name): ...here.
 707         (rust_language_data): Delete la_sniff_from_mangled_name
 708         initializer.
 709         * symtab.c (symbol_find_demangled_name): Call
 710         sniff_from_mangled_name member function.
 711
 712 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 713
 714         * ada-lang.c (ada_language_data): Delete la_search_name_hash
 715         initializer.
 716         * c-lang.c (c_language_data): Likewise.
 717         (cplus_language_data): Likewise.
 718         (cplus_language::search_name_hash): New member function.
 719         (asm_language_data): Delete la_search_name_hash initializer.
 720         (minimal_language_data): Likewise.
 721         * d-lang.c (d_language_data): Likewise.
 722         * dictionary.c (default_search_name_hash): Rename to...
 723         (language_defn::search_name_hash): ...this.
 724         * f-lang.c (f_language_data): Likewise.
 725         (f_language::search_name_hash): New member function.
 726         * go-lang.c (go_language_data): Delete la_search_name_hash
 727         initializer.
 728         * language.c (unknown_language_data): Likewise.
 729         (auto_language_data): Likewise.
 730         * language.h (struct language_data): Delete la_search_name_hash
 731         field.
 732         (language_defn::search_name_hash): Declare new member function.
 733         (default_search_name_hash): Delete declaration.
 734         * m2-lang.c (m2_language_data): Delete la_search_name_hash
 735         initializer.
 736         * objc-lang.c (objc_language_data): Likewise.
 737         * opencl-lang.c (opencl_language_data): Likewise.
 738         * p-lang.c (pascal_language_data): Likewise.
 739         * rust-lang.c (rust_language_data): Likewise.
 740         * symtab.c (search_name_hash): Update call.
 741
 742 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 743
 744         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
 745         initializer.
 746         * c-lang.c (class compile_instance): Declare.
 747         (c_language_data): Delete la_get_compile_instance initializer.
 748         (c_language::get_compile_instance): New member function.
 749         (cplus_language_data): Delete la_get_compile_instance initializer.
 750         (cplus_language::get_compile_instance): New member function.
 751         (asm_language_data): Delete la_get_compile_instance initializer.
 752         (minimal_language_data): Likewise.
 753         * c-lang.h (c_get_compile_context): Update comment.
 754         (cplus_get_compile_context): Update comment.
 755         * compile/compile.c (compile_to_object): Update calls, don't rely
 756         on function pointer being NULL.
 757         * d-lang.c (d_language_data): Delete la_get_compile_instance
 758         initializer.
 759         * f-lang.c (f_language_data): Likewise.
 760         * go-lang.c (go_language_data): Likewise.
 761         * language.c (unknown_language_data): Likewise.
 762         (auto_language_data): Likewise.
 763         * language.h (language_data): Delete la_get_compile_instance field.
 764         (language_defn::get_compile_instance): New member function.
 765         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
 766         initializer.
 767         * objc-lang.c (objc_language_data): Likewise.
 768         * opencl-lang.c (opencl_language_data): Likewise.
 769         * p-lang.c (pascal_language_data): Likewise.
 770         * rust-lang.c (rust_language_data): Likewise.
 771
 772 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 773
 774         * ada-lang.c (ada_add_all_symbols): Update comment.
 775         (ada_iterate_over_symbols): Delete, move implementation to...
 776         (ada_language::iterate_over_symbols): ...here, a new member
 777         function, rewrite to use range based for loop.
 778         (ada_language_data): Delete la_iterate_over_symbols initializer.
 779         * c-lang.c (c_language_data): Likewise.
 780         (cplus_language_data): Likewise.
 781         (asm_language_data): Likewise.
 782         (minimal_language_data): Likewise.
 783         * d-lang.c (d_language_data): Likewise.
 784         * f-lang.c (f_language_data): Likewise.
 785         * go-lang.c (go_language_data): Likewise.
 786         * language.c (unknown_language_data): Likewise.
 787         (auto_language_data): Likewise.
 788         * language.h (language_data): Delete la_iterate_over_symbols field.
 789         (language_defn::iterate_over_symbols): New member function.
 790         (LA_ITERATE_OVER_SYMBOLS): Update.
 791         * linespec.c (iterate_over_all_matching_symtabs): Update.
 792         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
 793         initializer.
 794         * objc-lang.c (objc_language_data): Likewise.
 795         * opencl-lang.c (opencl_language_data): Likewise.
 796         * p-lang.c (pascal_language_data): Likewise.
 797         * rust-lang.c (rust_language_data): Likewise.
 798
 799 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 800
 801         * ada-lang.c (ada_language_data): Delete
 802         la_lookup_transparent_type initializer.
 803         * c-lang.c (c_language_data): Likewise.
 804         (cplus_language_data): Likewise.
 805         (cplus_language::lookup_transparent_type): New member function.
 806         (asm_language_data): Delete la_lookup_transparent_type
 807         initializer.
 808         (minimal_language_data): Likewise.
 809         * d-lang.c (d_language_data): Likewise.
 810         * f-lang.c (f_language_data): Likewise.
 811         * go-lang.c (go_language_data): Likewise.
 812         * language.c (unknown_language_data): Likewise.
 813         (auto_language_data): Likewise.
 814         * language.h (struct language_data): Delete
 815         la_lookup_transparent_type field.
 816         (language_defn::lookup_transparent_type): New member function.
 817         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
 818         initializer.
 819         * objc-lang.c (objc_language_data): Likewise.
 820         * opencl-lang.c (opencl_language_data): Likewise.
 821         * p-lang.c (pascal_language_data): Likewise.
 822         * rust-lang.c (rust_language_data): Likewise.
 823         * symtab.c (symbol_matches_domain): Update call.
 824
 825 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 826
 827         * ada-lang.c (ada_language_arch_info): Delete function, move
 828         implementation to...
 829         (ada_language::language_arch_info): ...here, a new member
 830         function.
 831         (ada_language_data): Delete la_language_arch_info.
 832         * c-lang.c (c_language_data): Likewise.
 833         (c_language::language_arch_info): New member function.
 834         (cplus_language_arch_info): Delete function, move
 835         implementation to...
 836         (cplus_language::language_arch_info): ...here, a new member
 837         function.
 838         (cplus_language_data): Delete la_language_arch_info.
 839         (asm_language_data): Likewise.
 840         (asm_language::language_arch_info): New member function.
 841         (minimal_language_data): Delete la_language_arch_info.
 842         (minimal_language::language_arch_info): New member function.
 843         * d-lang.c (d_language_arch_info): Delete function, move
 844         implementation to...
 845         (d_language::language_arch_info): ...here, a new member
 846         function.
 847         (d_language_data): Delete la_language_arch_info.
 848         * f-lang.c (f_language_arch_info): Delete function, move
 849         implementation to...
 850         (f_language::language_arch_info): ...here, a new member
 851         function.
 852         (f_language_data): Delete la_language_arch_info.
 853         * go-lang.c (go_language_arch_info): Delete function, move
 854         implementation to...
 855         (go_language::language_arch_info): ...here, a new member
 856         function.
 857         (go_language_data): Delete la_language_arch_info.
 858         * language.c (unknown_language_data): Likewise.
 859         (unknown_language::language_arch_info): New member function.
 860         (auto_language_data): Delete la_language_arch_info.
 861         (auto_language::language_arch_info): New member function.
 862         (language_gdbarch_post_init): Update call to
 863         la_language_arch_info.
 864         * language.h (language_data): Delete la_language_arch_info
 865         function pointer.
 866         (language_defn::language_arch_info): New function.
 867         * m2-lang.c (m2_language_arch_info): Delete function, move
 868         implementation to...
 869         (m2_language::language_arch_info): ...here, a new member
 870         function.
 871         (m2_language_data): Delete la_language_arch_info.
 872         * objc-lang.c (objc_language_arch_info): Delete function, move
 873         implementation to...
 874         (objc_language::language_arch_info): ...here, a new member
 875         function.
 876         (objc_language_data): Delete la_language_arch_info.
 877         * opencl-lang.c (opencl_language_arch_info): Delete function, move
 878         implementation to...
 879         (opencl_language::language_arch_info): ...here, a new member
 880         function.
 881         (opencl_language_data): Delete la_language_arch_info.
 882         * p-lang.c (pascal_language_arch_info): Delete function, move
 883         implementation to...
 884         (pascal_language::language_arch_info): ...here, a new member
 885         function.
 886         (pascal_language_data): Delete la_language_arch_info.
 887         * rust-lang.c (rust_language_arch_info): Delete function, move
 888         implementation to...
 889         (rust_language::language_arch_info): ...here, a new member
 890         function.
 891         (rust_language_data): Delete la_language_arch_info.
 892
 893 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 894
 895         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
 896         initializer.
 897         * c-lang.c (c_language_data): Likewise.
 898         (cplus_language_data): Likewise.
 899         (cplus_language::pass_by_reference_info): New method.
 900         (asm_language_data): Delete la_pass_by_reference initializer.
 901         (minimal_language_data): Likewise.
 902         * cp-abi.c (cp_pass_by_reference): Remove use of
 903         default_pass_by_reference.
 904         * d-lang.c (d_language_data): Likewise.
 905         * f-lang.c (f_language_data): Likewise.
 906         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
 907         default_pass_by_reference.
 908         * go-lang.c (go_language_data): Likewise.
 909         * language.c (language_pass_by_reference): Update.
 910         (default_pass_by_reference): Delete.
 911         (unknown_language_data): Delete la_pass_by_reference
 912         initializer.
 913         (auto_language_data): Likewise.
 914         * language.h (struct language_data): Delete la_pass_by_reference
 915         field.
 916         (language_defn::pass_by_reference_info): New member function.
 917         (default_pass_by_reference): Delete declaration.
 918         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
 919         initializer.
 920         * objc-lang.c (objc_language_data): Likewise.
 921         * opencl-lang.c (opencl_language_data): Likewise.
 922         * p-lang.c (pascal_language_data): Likewise.
 923         * rust-lang.c (rust_language_data): Likewise.
 924
 925 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 926
 927         * ada-lang.c (ada_read_var_value): Delete function, move
 928         implementation to...
 929         (ada_language::read_var_value): ...here.
 930         (ada_language_data): Delete la_read_var_value initializer.
 931         * c-lang.c (c_language_data): Likewise.
 932         (cplus_language_data): Likewise.
 933         (minimal_language_data): Likewise.
 934         * d-lang.c (d_language_data): Likewise.
 935         * f-lang.c (f_language_data): Likewise.
 936         * findvar.c (default_read_var_value): Rename to...
 937         (language_defn::read_var_value): ...this.
 938         * findvar.c (read_var_value): Update header comment, and change to
 939         call member function instead of function pointer.
 940         * go-lang.c (go_language_data): Likewise.
 941         * language.c (unknown_language_data): Delete la_read_var_value
 942         initializer.
 943         (auto_language_data): Likewise.
 944         * language.h (struct language_data): Delete la_read_var_value
 945         field.
 946         (language_defn::read_var_value): New member function.
 947         (default_read_var_value): Delete declaration.
 948         * m2-lang.c (m2_language_data): Delete la_read_var_value
 949         initializer.
 950         * objc-lang.c (objc_language_data): Likewise.
 951         * opencl-lang.c (opencl_language_data): Likewise.
 952         * p-lang.c (pascal_language_data): Likewise.
 953         * rust-lang.c (rust_language_data): Likewise.
 954         * value.h (default_read_var_value): Delete declaration.
 955
 956 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 957
 958         * ada-lang.c (ada_print_array_index): Delete function, move
 959         implementation to...
 960         (ada_language::print_array_index): ...here.
 961         (ada_language_data): Delete la_print_array_index initializer.
 962         * c-lang.c (c_language_data): Likewise.
 963         (cplus_language_data): Likewise.
 964         (minimal_language_data): Likewise.
 965         * d-lang.c (d_language_data): Likewise.
 966         * f-lang.c (f_language_data): Likewise.
 967         * go-lang.c (go_language_data): Likewise.
 968         * language.c (default_print_array_index): Delete function, move
 969         implementation to...
 970         (language_defn::print_array_index): ...here.
 971         (unknown_language_data): Delete la_print_array_index initializer.
 972         (auto_language_data): Likewise.
 973         * language.h (struct language_data): Delete la_print_array_index
 974         field.
 975         (language_defn::print_array_index): New member function.
 976         (LA_PRINT_ARRAY_INDEX): Update.
 977         (default_print_array_index): Delete declaration.
 978         * m2-lang.c (m2_language_data): Delete la_print_array_index
 979         initializer.
 980         * objc-lang.c (objc_language_data): Likewise.
 981         * opencl-lang.c (opencl_language_data): Likewise.
 982         * p-lang.c (pascal_language_data): Likewise.
 983         * rust-lang.c (rust_language_data): Likewise.
 984
 985 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 986
 987         * gdb/ada-lang.c (ada_language_defn): Convert to...
 988         (ada_language_data): ...this.
 989         (class ada_language): New class.
 990         (ada_language_defn): New static global.
 991         * gdb/c-lang.c (c_language_defn): Convert to...
 992         (c_language_data): ...this.
 993         (class c_language): New class.
 994         (c_language_defn): New static global.
 995         (cplus_language_defn): Convert to...
 996         (cplus_language_data): ...this.
 997         (class cplus_language): New class.
 998         (cplus_language_defn): New static global.
 999         (asm_language_defn): Convert to...
1000         (asm_language_data): ...this.
1001         (class asm_language): New class.
1002         (asm_language_defn): New static global.
1003         (minimal_language_defn): Convert to...
1004         (minimal_language_data): ...this.
1005         (class minimal_language): New class.
1006         (minimal_language_defn): New static global.
1007         * gdb/d-lang.c (d_language_defn): Convert to...
1008         (d_language_data): ...this.
1009         (class d_language): New class.
1010         (d_language_defn): New static global.
1011         * gdb/f-lang.c (f_language_defn): Convert to...
1012         (f_language_data): ...this.
1013         (class f_language): New class.
1014         (f_language_defn): New static global.
1015         * gdb/go-lang.c (go_language_defn): Convert to...
1016         (go_language_data): ...this.
1017         (class go_language): New class.
1018         (go_language_defn): New static global.
1019         * gdb/language.c (unknown_language_defn): Remove declaration.
1020         (current_language): Initialize to nullptr, real initialization is
1021         moved to _initialize_language.
1022         (languages): Delete global.
1023         (language_defn::languages): Define.
1024         (set_language_command): Use language_defn::languages.
1025         (set_language): Likewise.
1026         (range_error): Likewise.
1027         (language_enum): Likewise.
1028         (language_def): Likewise.
1029         (add_set_language_command): Use language_def::languages for the
1030         language list, and language_def to lookup language pointers.
1031         (skip_language_trampoline): Use language_defn::languages.
1032         (unknown_language_defn): Convert to...
1033         (unknown_language_data): ...this.
1034         (class unknown_language): New class.
1035         (unknown_language_defn): New static global.
1036         (auto_language_defn): Convert to...
1037         (auto_language_data): ...this.
1038         (class auto_language): New class.
1039         (auto_language_defn): New static global.
1040         (language_gdbarch_post_init): Use language_defn::languages.
1041         (_initialize_language): Initialize current_language.
1042         * gdb/language.h (struct language_defn): Rename to...
1043         (struct language_data): ...this.
1044         (struct language_defn): New.
1045         (auto_language_defn): Delete.
1046         (unknown_language_defn): Delete.
1047         (minimal_language_defn): Delete.
1048         (ada_language_defn): Delete.
1049         (asm_language_defn): Delete.
1050         (c_language_defn): Delete.
1051         (cplus_language_defn): Delete.
1052         (d_language_defn): Delete.
1053         (f_language_defn): Delete.
1054         (go_language_defn): Delete.
1055         (m2_language_defn): Delete.
1056         (objc_language_defn): Delete.
1057         (opencl_language_defn): Delete.
1058         (pascal_language_defn): Delete.
1059         (rust_language_defn): Delete.
1060         * gdb/m2-lang.c (m2_language_defn): Convert to...
1061         (m2_language_data): ...this.
1062         (class m2_language): New class.
1063         (m2_language_defn): New static global.
1064         * gdb/objc-lang.c (objc_language_defn): Convert to...
1065         (objc_language_data): ...this.
1066         (class objc_language): New class.
1067         (objc_language_defn): New static global.
1068         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
1069         (opencl_language_data): ...this.
1070         (class opencl_language): New class.
1071         (opencl_language_defn): New static global.
1072         * gdb/p-lang.c (pascal_language_defn): Convert to...
1073         (pascal_language_data): ...this.
1074         (class pascal_language): New class.
1075         (pascal_language_defn): New static global.
1076         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
1077         language pointer, update comment format.
1078         * gdb/rust-lang.c (rust_language_defn): Convert to...
1079         (rust_language_data): ...this.
1080         (class rust_language): New class.
1081         (rust_language_defn): New static global.
1082
1083 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1084
1085         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
1086         member variable.
1087         <m_stmt_at_address>: New member variable.
1088         (lnp_state_machine::record_line): Don't record some lines, update
1089         tracking of is_stmt at the same address.
1090         (lnp_state_machine::lnp_state_machine): Initialise new member
1091         variables.
1092
1093 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1094
1095         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
1096         "-include gnu-nat-mig.h".
1097         * gnu-nat-mig.h: New file.
1098         * gnu-nat.c: Include "gnu-nat-mig.h".
1099         (exc_server, msg_reply_server, notify_server,
1100         process_reply_server): Remove declarations.
1101
1102 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1103
1104         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
1105         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
1106         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
1107         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
1108         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
1109         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
1110         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
1111         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
1112         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
1113         to gnu_nat_target class.
1114         * gnu-nat.c: Likewise.
1115         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
1116         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
1117         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
1118         object.
1119         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
1120         instead of `gnu_target'.
1121
1122 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1123
1124         * i386-gnu-tdep.c: Include "gdbcore.h"
1125         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
1126         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
1127         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
1128         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
1129         i386_gnu_sigcontext_addr): New functions
1130         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
1131         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
1132         tdep.
1133
1134 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1135
1136         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
1137         before fork_inferior call. Avoid calling it if target_is_pushed returns
1138         true.
1139
1140 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1141
1142         * gnu-nat.h (gnu_target): New variable declaration.
1143         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
1144         gnu_target.
1145         * gnu-nat.c (gnu_target): New variable.
1146         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
1147         add_thread_silent, and add_thread calls.
1148         (gnu_nat_target::create_inferior): Pass gnu_target to
1149         add_thread_silent, thread_change_ptid call.
1150         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
1151         call.
1152
1153 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1154
1155         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
1156         (gnu_nat_target::find_memory_regions): Remove unused
1157         `old_address' variable.
1158
1159 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1160
1161         * gnu-nat.c: Include "gdbarch.h".
1162
1163 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1164
1165         * reply_mig_hack.awk (Error return): Cast function through
1166         void *, to bypass compiler function call check.
1167
1168 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1169
1170         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
1171         $(srcdir)/reply_mig_hack.awk.
1172
1173 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1174
1175         * gnu-nat.h (gnu_debug_flag): Set type to bool.
1176
1177 2020-05-30  Jonny Grant  <jg@jguk.org>
1178
1179         * configure.ac (ACX_BUGURL): change bug URL to https.
1180
1181 2020-05-30  Pedro Alves  <palves@redhat.com>
1182
1183         * cp-support.c (replace_typedefs_template): New.
1184         (replace_typedefs_qualified_name): Handle
1185         DEMANGLE_COMPONENT_TEMPLATE.
1186
1187 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
1188
1189         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
1190         dwarf2/index-cache.h, dwarf2/index-write.c,
1191         dwarf2/index-write.h, dwarf2/line-header.c,
1192         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
1193         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
1194         variables and fields from `dwarf2_per_objfile` to just
1195         `per_objfile` throughout.
1196
1197 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
1198
1199         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1200         <push_dwarf_reg_entry_value>: Add comment.
1201
1202 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
1203             Keith Seitz  <keiths@redhat.com>
1204
1205         * python/python.c (do_start_initialization): Call PyEval_SaveThread
1206         instead of PyEval_ReleaseLock.
1207         (class gdbpy_gil): Move to earlier in file.
1208         (finalize_python): Set gdb_python_initialized.
1209         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
1210         when not initialized.
1211
1212 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
1213
1214         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1215         <push_dwarf_reg_entry_value>: Remove assert.  Override
1216         per_objfile with caller_per_objfile.
1217
1218 2020-05-28  Tom de Vries  <tdevries@suse.de>
1219
1220         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
1221         PR gold/15646 workaround to symbol kind "type".
1222
1223 2020-05-27  Tom Tromey  <tromey@adacore.com>
1224
1225         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
1226
1227 2020-05-27  Tom Tromey  <tromey@adacore.com>
1228
1229         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
1230         Use htab_find_with_hash.
1231         <add_abbrev>: Remove "abbrev_number" parameter.
1232         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
1233         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
1234         (hash_abbrev): Add comment.
1235         (abbrev_table::lookup_abbrev): Move to header file.
1236         (abbrev_table::read): Update.
1237
1238 2020-05-27  Tom Tromey  <tromey@adacore.com>
1239
1240         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
1241         method.
1242         <canonical_name>: New member.
1243         <raw_name>: Rename from "name".
1244         (partial_die_info): Initialize canonical_name.
1245         (scan_partial_symbols): Check raw_name.
1246         (partial_die_parent_scope, partial_die_full_name)
1247         (add_partial_symbol, add_partial_subprogram)
1248         (add_partial_enumeration, load_partial_dies): Use "name" method.
1249         (partial_die_info::name): New method.
1250         (partial_die_info::read, guess_partial_die_structure_name)
1251         (partial_die_info::fixup): Update.
1252
1253 2020-05-27  Tom Tromey  <tromey@adacore.com>
1254
1255         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
1256         <get_ref_die_offset>: Inline.
1257         <get_ref_die_offset_complaint>: New method.
1258         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
1259         (attribute::get_ref_die_offset_complaint): Rename from
1260         get_ref_die_offset.  Just issue complaint.
1261
1262 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1263
1264         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
1265
1266 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1267
1268         * exec.c (exec_file_attach): Use errno value of first openp failure.
1269
1270 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1271
1272         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
1273         Don't close thread handle.
1274
1275 2020-05-27  Tom Tromey  <tom@tromey.com>
1276             Simon Marchi  <simon.marchi@efficios.com>
1277
1278         * objfiles.h (struct objfile) <partial_symtabs>: Now a
1279         shared_ptr.
1280         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
1281         member.
1282         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
1283         dwarf2_per_bfd_objfile_data_key>: New globals.
1284         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
1285         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
1286         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
1287         shared.
1288         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
1289         short-circuit when sharing.
1290         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
1291         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
1292
1293 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1294
1295         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
1296         to...
1297         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
1298         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
1299
1300 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1301
1302         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
1303         build_name_components, find_name_components_bounds>:
1304         Add per_objfile parameter.
1305         (struct mapped_index) <symbol_name_at>: Likewise.
1306         (struct mapped_debug_names): Remove constructor.
1307         <dwarf2_per_objfile>: Remove field.
1308         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
1309         (mapped_index_base::find_name_components_bounds,
1310         mapped_index_base::build_name_components,
1311         dw2_expand_symtabs_matching_symbol): Likewise.
1312         (class mock_mapped_index) <symbol_name_at>: Likewise.
1313         (check_match): Likewise.
1314         (check_find_bounds_finds): Likewise.
1315         (test_mapped_index_find_name_component_bounds): Update.
1316         (CHECK_MATCH): Update.
1317         (dw2_expand_symtabs_matching): Update.
1318         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
1319         per_objfile parameter.
1320         <find_vec_in_debug_names>: Likewise.
1321         <m_per_objfile>: New field.
1322         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
1323         parameter.
1324         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
1325         (dw2_debug_names_iterator::next): Update.
1326         (dw2_debug_names_lookup_symbol): Update.
1327         (dw2_debug_names_expand_symtabs_for_function): Update.
1328         (dw2_debug_names_map_matching_symbols): Update.
1329         (dw2_debug_names_expand_symtabs_matching): Update.
1330         (dwarf2_read_debug_names): Update.
1331
1332 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1333
1334         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
1335         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
1336         move to dwarf2_per_objfile.
1337         <read_in_chain>: Remove.
1338         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
1339         remove_all_cus, age_comp_units>: New methods.
1340         <m_dwarf2_cus>: New member.
1341         (struct dwarf2_per_cu_data) <cu>: Remove.
1342         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
1343         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
1344         moved to methods of dwarf2_per_objfile.
1345         (dwarf2_clear_marks): Remove.
1346         (dwarf2_queue_item::~dwarf2_queue_item): Update.
1347         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
1348         (dwarf2_per_bfd::free_cached_comp_units): Remove.
1349         (dwarf2_per_objfile::remove_all_cus): New.
1350         (class free_cached_comp_units) <~free_cached_comp_units>:
1351         Update.
1352         (load_cu): Update.
1353         (dw2_do_instantiate_symtab): Adjust.
1354         (fill_in_sig_entry_from_dwo_entry): Adjust.
1355         (cutu_reader::init_tu_and_read_dwo_dies): Update.
1356         (cutu_reader::cutu_reader): Likewise.
1357         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
1358         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
1359         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
1360         and dwarf2_per_objfile::age_comp_units.
1361         (load_partial_comp_unit): Update.
1362         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
1363         (process_queue): Likewise.
1364         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
1365         backlink.
1366         (dwarf2_read_addr_index): Likewise.
1367         (follow_die_offset): Likewise.
1368         (dwarf2_fetch_die_loc_sect_off): Likewise.
1369         (dwarf2_fetch_constant_bytes): Likewise.
1370         (dwarf2_fetch_die_type_sect_off): Likewise.
1371         (follow_die_sig_1): Likewise.
1372         (load_full_type_unit): Likewise.
1373         (read_signatured_type): Likewise.
1374         (dwarf2_cu::dwarf2_cu): Don't set cu field.
1375         (dwarf2_cu::~dwarf2_cu): Remove.
1376         (dwarf2_per_objfile::get_cu): New.
1377         (dwarf2_per_objfile::set_cu): New.
1378         (age_cached_comp_units): Rename to...
1379         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
1380         to std::unordered_map.
1381         (free_one_cached_comp_unit): Rename to...
1382         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
1383         to std::unordered_map.
1384         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
1385         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
1386         a dwarf2_per_objfile in data.
1387         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
1388         (dwarf2_clear_marks): Remove.
1389
1390 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1391
1392         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
1393         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
1394         (init_tu_and_read_dwo_dies): Likewise.
1395         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
1396         (cutu_reader::cutu_reader): Likewise.
1397         (load_partial_comp_unit): Likewise.
1398         (process_psymtab_comp_unit): Update.
1399         (build_type_psymtabs_1): Update.
1400         (process_skeletonless_type_unit): Update.
1401         (load_full_comp_unit): Update.
1402         (find_partial_die): Update.
1403         (dwarf2_read_addr_index): Update.
1404         (read_signatured_type): Update.
1405
1406 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1407
1408         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
1409         m_header_read_in>: New fields.
1410         <get_header>: New method.
1411         * dwarf2/read.c (per_cu_header_read_in): Remove.
1412         (dwarf2_per_cu_data::get_header): New.
1413         (dwarf2_per_cu_data::addr_size): Update.
1414         (dwarf2_per_cu_data::offset_size): Update.
1415         (dwarf2_per_cu_data::ref_addr_size): Update.
1416
1417 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1418
1419         * dwarf2/read.c (load_cu): Return dwarf2_cu.
1420         (dw2_do_instantiate_symtab): Update.
1421         (queue_and_load_all_dwo_tus): Change parameter from
1422         dwarf2_per_cu_data to dwarf2_cu.
1423         (dwarf2_fetch_die_loc_sect_off): Update.
1424         (dwarf2_fetch_constant_bytes): Update.
1425         (dwarf2_fetch_die_type_sect_off): Update.
1426
1427 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1428
1429         * dwarf2/read.c (process_full_comp_unit,
1430         process_full_type_unit): Remove per_cu, per_objfile paramters.
1431         Add dwarf2_cu parameter.
1432         (process_queue): Update.
1433
1434 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1435
1436         * dwarf2/read.c (create_cu_from_index_list): Replace
1437         dwarf2_per_objfile parameter with dwarf2_per_bfd.
1438         (create_cus_from_index_list): Likewise.
1439         (create_cus_from_index): Likewise.
1440         (create_signatured_type_table_from_index): Likewise.
1441         (create_cus_from_debug_names_list): Likewise.
1442         (create_cus_from_debug_names): Likewise.
1443         (dwarf2_read_gdb_index): Update.
1444         (dwarf2_read_debug_names): Update.
1445
1446 2020-05-27  Tom Tromey  <tom@tromey.com>
1447             Simon Marchi  <simon.marchi@efficios.com>
1448
1449         * dwarf2/read.h (struct dwarf2_per_objfile)
1450         <get_type_for_signatured_type, set_type_for_signatured_type>:
1451         New methods.
1452         <m_type_map>: New member.
1453         (struct signatured_type) <type>: Remove.
1454         * dwarf2/read.c
1455         (dwarf2_per_objfile::get_type_for_signatured_type,
1456         dwarf2_per_objfile::set_type_for_signatured_type): New.
1457         (get_signatured_type): Use new methods.
1458
1459 2020-05-27  Tom Tromey  <tom@tromey.com>
1460             Simon Marchi  <simon.marchi@efficios.com>
1461
1462         * dwarf2/read.h (struct type_unit_group_unshareable): New.
1463         (struct dwarf2_per_objfile) <type_units>: New member.
1464         <get_type_unit_group_unshareable>: New method.
1465         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
1466         num_symtabs, symtabs>: Remove; move to
1467         type_unit_group_unshareable.
1468         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
1469         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
1470         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
1471
1472 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1473
1474         * dwarf2/read.h (struct dwarf2_per_cu_data):
1475         <dwarf2_per_objfile>: Remove.
1476         * dwarf2/read.c (create_cu_from_index_list): Don't assign
1477         dwarf2_per_objfile.
1478         (create_signatured_type_table_from_index): Likewise.
1479         (create_signatured_type_table_from_debug_names): Likewise.
1480         (create_debug_type_hash_table): Likewise.
1481         (fill_in_sig_entry_from_dwo_entry): Likewise.
1482         (create_type_unit_group): Likewise.
1483         (read_comp_units_from_section): Likewise.
1484         (create_cus_hash_table): Likewise.
1485
1486 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1487
1488         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
1489         dwarf2_per_cu_data::dwarf2_per_objfile.
1490         (compute_compunit_symtab_includes): Likewise.
1491         (dwarf2_cu::start_symtab): Likewise.
1492
1493 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1494
1495         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
1496         parameter.
1497         * dwarf2/read.c (get_die_type_at_offset): Likewise.
1498         (read_namespace_alias): Update.
1499         (lookup_die_type): Update.
1500         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
1501         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
1502         Update.
1503         (disassemble_dwarf_expression): Update.
1504
1505 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1506
1507         * dwarf2/read.h (struct dwarf2_queue_item): Add
1508         dwarf2_per_objfile parameter, assign new parameter.
1509         <per_objfile>: New field.
1510         * dwarf2/read.c (free_one_cached_comp_unit): Add
1511         dwarf2_per_objfile parameter.
1512         (queue_comp_unit): Likewise.
1513         (dw2_do_instantiate_symtab): Update.
1514         (process_psymtab_comp_unit): Update.
1515         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
1516         (process_imported_unit_die): Update.
1517         (queue_and_load_dwo_tu): Update.
1518         (follow_die_offset): Update.
1519         (follow_die_sig_1): Update.
1520
1521 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1522
1523         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
1524         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
1525         (read_call_site_scope): Assign per_objfile.
1526         (dwarf2_per_cu_data::objfile): Remove.
1527         * gdbtypes.h (struct call_site) <per_objfile>: New member.
1528         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
1529         dwarf2_per_objfile parameter.
1530         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
1531         dwarf2_per_objfile parameter.
1532         (dwarf_expr_reg_to_entry_parameter): Add output
1533         dwarf2_per_objfile parameter.
1534         (locexpr_get_frame_base): Update.
1535         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
1536         <push_dwarf_reg_entry_value>: Update.
1537         <call_site_to_target_addr>: Update.
1538         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
1539         parameter.
1540         (value_of_dwarf_reg_entry): Update.
1541         (rw_pieced_value): Update.
1542         (indirect_synthetic_pointer): Update.
1543         (dwarf2_evaluate_property): Update.
1544         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
1545         parameter.
1546         (locexpr_read_variable): Update.
1547         (locexpr_get_symbol_read_needs): Update.
1548         (loclist_read_variable): Update.
1549
1550 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1551
1552         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
1553         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1554         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
1555         parameter.
1556         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
1557         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1558         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
1559         parameter.
1560         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
1561         sect_variable_value): Add dwarf2_per_objfile parameter.
1562         (class dwarf_evaluate_loc_desc) <dwarf_call,
1563         dwarf_variable_value>: Update.
1564         (fetch_const_value_from_synthetic_pointer): Add
1565         dwarf2_per_objfile parameter.
1566         (fetch_const_value_from_synthetic_pointer): Update.
1567         (coerced_pieced_ref): Update.
1568         (class symbol_needs_eval_context) <dwarf_call,
1569         dwarf_variable_value>: Update.
1570         (dwarf2_compile_expr_to_ax): Update.
1571
1572 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1573
1574         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
1575         parameter.
1576         (dwarf2_evaluate_loc_desc_full): Update.
1577
1578 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1579
1580         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
1581         parameter.
1582         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
1583         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
1584         dwarf2_per_objfile parameter.
1585         (decode_debug_loc_dwo_addresses): Likewise.
1586         (dwarf2_find_location_expression): Update.
1587         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
1588         (locexpr_describe_location_piece): Add dwarf2_per_objfile
1589         parameter.
1590         (disassemble_dwarf_expression): Add dwarf2_per_objfile
1591         parameter.
1592         (locexpr_describe_location_1): Likewise.
1593         (locexpr_describe_location): Update.
1594
1595 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1596
1597         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
1598         Remove.
1599         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
1600         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
1601         (dwarf2_compile_property_to_c): Update.
1602         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
1603         use text offset from objfile.
1604         (locexpr_tracepoint_var_ref): Update.
1605         (locexpr_generate_c_location): Update.
1606         (loclist_describe_location): Update.
1607         (loclist_tracepoint_var_ref): Update.
1608         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
1609         dwarf2_per_objfile parameter.
1610         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
1611         use text offset from objfile.
1612         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
1613
1614 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1615
1616         * dwarf2/expr.h (struct dwarf_expr_context)
1617         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
1618         <offset>: Remove.
1619         <per_objfile>: New member.
1620         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
1621         dwarf2_per_objfile parameter.  Don't set offset, set
1622         per_objfile.
1623         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
1624         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
1625         a dwarf2_per_objfile object instead of an offset.
1626         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
1627         constructor.
1628         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
1629         to dwarf2_expr_executor constructor.  Don't set offset.
1630         (dwarf2_fetch_cfa_info): Update.
1631         (struct dwarf2_frame_cache) <text_offset>: Remove.
1632         <per_objfile>: New field.
1633         (dwarf2_frame_cache): Update.
1634         (dwarf2_frame_prev_register): Update.
1635         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1636         <dwarf_evaluate_loc_desc>: Add constructor.
1637         (dwarf2_evaluate_loc_desc_full): Update.
1638         (dwarf2_locexpr_baton_eval): Update.
1639         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
1640         Add constructor.
1641         (dwarf2_loc_desc_get_symbol_read_needs): Update.
1642
1643 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1644
1645         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
1646         addr_sized_int_type>: Move to dwarf2_cu.
1647         <int_type>: Move to dwarf2_per_objfile.
1648         (struct dwarf2_per_objfile) <int_type>: Move here.
1649         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
1650         addr_sized_int_type>: Move here.
1651         (read_func_scope): Update.
1652         (read_array_type): Update.
1653         (read_tag_string_type): Update.
1654         (attr_to_dynamic_prop): Update.
1655         (dwarf2_per_cu_data::int_type): Rename to...
1656         (dwarf2_per_objfile::int_type): ... this.
1657         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
1658         (dwarf2_cu::addr_sized_int_type): ... this.
1659         (read_subrange_type): Update.
1660         (dwarf2_per_cu_data::addr_type): Rename to...
1661         (dwarf2_cu::addr_type): ... this.
1662         (set_die_type): Update.
1663
1664 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1665
1666         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
1667         data through per_cu->cu.
1668
1669 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1670
1671         * dwarf2/read.c (lookup_dwo_comp_unit): Change
1672         dwarf2_per_cu_data parameter fo dwarf2_cu.
1673         (lookup_dwo_type_unit): Likewise.
1674         (read_cutu_die_from_dwo): Likewise.
1675         (lookup_dwo_unit): Likewise.
1676         (open_and_init_dwo_file): Likewise.
1677         (lookup_dwo_cutu): Likewise.
1678         (lookup_dwo_comp_unit): Likewise.
1679         (lookup_dwo_type_unit): Likewise.
1680         (cutu_reader::init_tu_and_read_dwo_dies): Update.
1681         (cutu_reader::cutu_reader): Update.
1682
1683 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1684
1685         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
1686         parameter.
1687         (process_full_type_unit): Likewise.
1688         (process_queue): Update.
1689
1690 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1691
1692         * dwarf2/read.c (recursively_compute_inclusions): Add
1693         dwarf2_per_objfile parameter.
1694         (compute_compunit_symtab_includes): Likewise.
1695         (process_cu_includes): Update.
1696
1697 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1698
1699         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
1700         parameter.
1701         (create_type_unit_group): Update.
1702         (process_psymtab_comp_unit_reader): Update.
1703         (build_type_psymtabs_reader): Update.
1704
1705 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1706
1707         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
1708         object through m_this_cu->cu.
1709
1710 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1711
1712         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
1713         the info parameter.
1714         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
1715
1716 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1717
1718         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
1719         per_objfile parameter.
1720         (load_full_type_unit): Add per_objfile parameter.
1721         (read_signatured_type): Likewise.
1722         (load_full_comp_unit): Likewise.
1723         (load_cu): Likewise.
1724         (dw2_do_instantiate_symtab): Likewise.
1725         (dw2_get_file_names): Likewise.
1726         (dw2_map_symtabs_matching_filename): Update.
1727         (dw_expand_symtabs_matching_file_matcher): Update.
1728         (dw2_map_symbol_filenames): Update.
1729         (process_psymtab_comp_unit): Add per_objfile parameter.
1730         (build_type_psymtabs_1): Update.
1731         (process_skeletonless_type_unit): Update.
1732         (dwarf2_build_psymtabs_hard): Update.
1733         (load_partial_comp_unit): Add per_objfile parameter.
1734         (scan_partial_symbols): Update.
1735         (load_full_comp_unit): Add per_objfile parameter.
1736         (process_imported_unit_die): Update.
1737         (create_cus_hash_table): Update.
1738         (find_partial_die): Update.
1739         (dwarf2_read_addr_index): Update.
1740         (follow_die_offset): Update.
1741         (dwarf2_fetch_die_loc_sect_off): Update.
1742         (dwarf2_fetch_constant_bytes): Update.
1743         (dwarf2_fetch_die_type_sect_off): Update.
1744         (follow_die_sig_1): Update.
1745         (load_full_type_unit): Add per_objfile parameter.
1746         (read_signatured_type): Likewise.
1747
1748 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1749
1750         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
1751         of objfile_name.
1752
1753 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1754
1755         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
1756         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
1757         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
1758         field.
1759         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
1760         (create_cus_from_index): Update.
1761         (dwarf2_read_gdb_index): Update.
1762         (create_cus_from_debug_names): Update.
1763         (dwarf2_read_debug_names): Update.
1764         (get_abbrev_section_for_cu): Update.
1765         (create_all_comp_units): Update.
1766         (read_attribute_value): Update.
1767         (get_debug_line_section): Update.
1768         * dwarf2/index-cache.c (index_cache::store): Update.
1769         * dwarf2/index-write.c (save_gdb_index_command): Update.
1770         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
1771
1772 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1773
1774         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
1775         member.
1776         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
1777         dwarf2_per_cu_data::per_bfd.
1778         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
1779         (create_type_unit_group): Likewise.
1780         (queue_comp_unit): Remove reference to
1781         per_cu->dwarf2_per_objfile.
1782         (maybe_queue_comp_unit): Likewise.
1783         (fill_in_sig_entry_from_dwo_entry): Assign new field.
1784         (create_cus_hash_table): Assign new field.
1785
1786 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1787
1788         * dwarf2/read.c: Replace
1789         dwarf2_cu->per_cu->dwarf2_per_objfile references with
1790         dwarf2_cu->per_objfile throughout.
1791
1792 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1793
1794         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
1795         parameter, don't use per_cu->dwarf2_per_objfile.
1796         (dw2_instantiate_symtab): Likewise.
1797         (dw2_find_last_source_symtab): Update.
1798         (dw2_map_expand_apply): Update.
1799         (dw2_lookup_symbol): Update.
1800         (dw2_expand_symtabs_for_function): Update.
1801         (dw2_expand_all_symtabs): Update.
1802         (dw2_expand_symtabs_with_fullname): Update.
1803         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
1804         don't use per_cu->dwarf2_per_objfile.
1805         (dw2_expand_marked_cus): Update.
1806         (dw2_find_pc_sect_compunit_symtab): Update.
1807         (dw2_debug_names_lookup_symbol): Update.
1808         (dw2_debug_names_expand_symtabs_for_function): Update.
1809         (dw2_debug_names_map_matching_symbols): Update.
1810         (dwarf2_psymtab::expand_psymtab): Update.
1811
1812 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1813
1814         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
1815         <per_objfile>: New member.
1816         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
1817         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
1818         call to dwarf2_cu.
1819         (cutu_reader::cutu_reader): Update.
1820         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
1821
1822 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1823
1824         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
1825         struct dwarf2_per_objfile.
1826         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
1827         dwarf2_per_bfd.
1828         * dwarf2/read.c (set_die_type): Update.
1829         (get_die_type_at_offset): Update.
1830
1831 2020-05-27  Tom Tromey  <tom@tromey.com>
1832             Simon Marchi  <simon.marchi@efficios.com>
1833
1834         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
1835         method.
1836         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
1837         get_symtab, set_symtab>: New methods.
1838         <m_symtabs>: New field.
1839         (struct dwarf2_psymtab): Derive from partial_symtab.
1840         <readin_p, get_compunit_symtab>: Declare methods.
1841         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
1842         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
1843         New methods.
1844         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
1845         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
1846         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
1847         (dw2_symtab_iter_next, dw2_print_stats)
1848         (dw2_expand_symtabs_with_fullname)
1849         (dw2_expand_symtabs_matching_one)
1850         (dw_expand_symtabs_matching_file_matcher)
1851         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
1852         (dw2_debug_names_iterator::next)
1853         (dw2_debug_names_map_matching_symbols)
1854         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
1855         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
1856         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
1857         New methods.
1858         (get_compunit_symtab, process_full_comp_unit)
1859         (process_full_type_unit): Update.
1860         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
1861
1862 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1863
1864         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
1865         then introduce a new dwarf2_per_objfile type.
1866         <read_line_string>: Move to the new dwarf2_per_objfile type.
1867         <objfile>: Likewise.
1868         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
1869         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
1870         dwarf2_per_objfile->per_bfd.
1871         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
1872         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
1873         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
1874         (dwarf2_per_bfd::free_cached_comp_units): ... this.
1875         (dwarf2_has_info): Allocate dwarf2_per_bfd.
1876         (dwarf2_per_objfile::locate_sections): Rename to...
1877         (dwarf2_per_bfd::locate_sections): ... this.
1878         (dwarf2_per_objfile::get_cutu): Rename to...
1879         (dwarf2_per_bfd::get_cutu): ... this.
1880         (dwarf2_per_objfile::get_cu): Rename to...
1881         (dwarf2_per_bfd::get_cu): ... this.
1882         (dwarf2_per_objfile::get_tu): Rename to...
1883         (dwarf2_per_bfd::get_tu): ... this.
1884         (dwarf2_per_objfile::allocate_per_cu): Rename to...
1885         (dwarf2_per_bfd::allocate_per_cu): ... this.
1886         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
1887         (dwarf2_per_bfd::allocate_signatured_type): ... this.
1888         (get_gdb_index_contents_ftype): Change parameter from
1889         dwarf2_per_objfile to dwarf2_per_bfd.
1890         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
1891         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
1892
1893 2020-05-27  Tom Tromey  <tom@tromey.com>
1894             Simon Marchi  <simon.marchi@efficios.com>
1895
1896         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
1897         (allocate_piece_closure): Set "per_objfile" member.
1898         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
1899         (locexpr_describe_location, loclist_describe_location): Use new
1900         member.
1901         * dwarf2/read.c (read_call_site_scope)
1902         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
1903         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
1904         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
1905         handle_data_member_location): Set per_objfile member.
1906         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
1907         member.
1908         (struct dwarf2_loclist_baton) <per_objfile>: New member.
1909
1910 2020-05-27  Tom Tromey  <tom@tromey.com>
1911
1912         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
1913         allocate_signatured_type>: Declare new methods.
1914         <m_num_psymtabs>: New member.
1915         (struct dwarf2_per_cu_data) <index>: New member.
1916         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
1917         (dwarf2_per_objfile::allocate_signatured_type): New methods.
1918         (create_cu_from_index_list): Use allocate_per_cu.
1919         (create_signatured_type_table_from_index)
1920         (create_signatured_type_table_from_debug_names)
1921         (create_debug_type_hash_table, add_type_unit)
1922         (read_comp_units_from_section): Use allocate_signatured_type.
1923
1924 2020-05-27  Tom Tromey  <tom@tromey.com>
1925
1926         * psymtab.c (partial_map_expand_apply)
1927         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
1928         (psym_lookup_global_symbol_language)
1929         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
1930         (psym_print_stats, psym_expand_symtabs_for_function)
1931         (psym_map_symbol_filenames, psym_map_matching_symbols)
1932         (psym_expand_symtabs_matching)
1933         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
1934         (maintenance_check_psymtabs): Update.
1935         * psympriv.h (struct partial_symtab) <readin_p,
1936         get_compunit_symtab>: Add objfile parameter.
1937         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
1938         Likewise.
1939         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
1940         get_compunit_symtab>: Likewise.
1941         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
1942
1943 2020-05-27  Tom Tromey  <tom@tromey.com>
1944
1945         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
1946         member.
1947         * dwarf2/read.c (delete_file_name_entry): Fix comment.
1948         (create_cu_from_index_list)
1949         (create_signatured_type_table_from_index)
1950         (create_signatured_type_table_from_debug_names)
1951         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
1952         (dwarf2_create_include_psymtab)
1953         (create_debug_type_hash_table, add_type_unit)
1954         (create_type_unit_group, read_comp_units_from_section)
1955         (dwarf2_compute_name, create_cus_hash_table)
1956         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
1957         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
1958         obstack.
1959         (dw2_get_real_path): Likewise.  Change argument to
1960         dwarf2_per_objfile.
1961
1962 2020-05-27  Luis Machado  <luis.machado@linaro.org>
1963
1964         PR tdep/26000
1965         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
1966         for ldrd (immediate).
1967
1968 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1969
1970         * command.h: Add comment giving the name of class_tui.
1971         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
1972         create the fake command for the help for class_tui.
1973
1974 2020-05-26  Tom Tromey  <tromey@adacore.com>
1975
1976         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
1977         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
1978         (val_atr): New function.
1979         (value_val_atr): Use it.
1980         * ada-valprint.c (print_optional_low_bound): Change low bound
1981         handling for enums.
1982         (val_print_packed_array_elements): Don't call discrete_position.
1983         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
1984         discrete_position for enum types.
1985         * language.c (default_print_array_index): Change type.
1986         * language.h (struct language_defn) <la_print_array_index>: Add
1987         index_type parameter, change type of index_value.
1988         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
1989         (default_print_array_index): Update.
1990         * valprint.c (maybe_print_array_index): Don't call
1991         value_from_longest.  Update.
1992         (value_print_array_elements): Don't call discrete_position.
1993
1994 2020-05-26  Tom Tromey  <tromey@adacore.com>
1995
1996         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
1997         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
1998
1999 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
2000
2001         PR gdb/13519
2002         * avr-tdep.c (avr_integer_to_address): Return data or code
2003         address accordingly to the second 'type' argument of the
2004         function.
2005
2006 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
2007
2008         * infcmd.c, inferior.h: (construct_inferior_arguments):
2009         Moved function from here to gdbsupport/common-inferior.{h,cc}
2010
2011 2020-05-23  Tom Tromey  <tom@tromey.com>
2012
2013         Revert commit eca1f90c:
2014         * NEWS: Remove entry for completion styling.
2015         * completer.c (_rl_completion_prefix_display_length): Move
2016         declaration later.
2017         (gdb_fnprint): Revert.
2018         (gdb_display_match_list_1): Likewise.
2019         * cli/cli-style.c (completion_prefix_style)
2020         (completion_difference_style, completion_suffix_style): Remove.
2021         (_initialize_cli_style): Revert.
2022         * cli/cli-style.h (completion_prefix_style)
2023         (completion_difference_style, completion_suffix_style): Don't
2024         declare.
2025
2026 2020-05-24  Pedro Alves  <palves@redhat.com>
2027
2028         * symtab.c (completion_list_add_name): Return boolean indication
2029         of whether the symbol matched.
2030         (completion_list_add_symbol): Don't try to remove C++ aliases if
2031         the symbol didn't match in the first place.
2032         * symtab.h (completion_list_add_name): Return bool.
2033
2034 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
2035
2036         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
2037         type::field.
2038
2039 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
2040
2041         GDB 9.2 released.
2042
2043 2020-05-23  Tom Tromey  <tom@tromey.com>
2044
2045         * NEWS: Add entry for completion styling.
2046         * completer.c (_rl_completion_prefix_display_length): Move
2047         declaration earlier.
2048         (gdb_fnprint): Use completion_style.
2049         (gdb_display_match_list_1): Likewise.
2050         * cli/cli-style.c (completion_prefix_style)
2051         (completion_difference_style, completion_suffix_style): New
2052         globals.
2053         (_initialize_cli_style): Register new globals.
2054         * cli/cli-style.h (completion_prefix_style)
2055         (completion_difference_style, completion_suffix_style): Declare.
2056
2057 2020-05-23  Pedro Alves  <palves@redhat.com>
2058
2059         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
2060         (parse_escape): Use ISDIGIT instead of isdigit.
2061         (puts_debug): Use gdb_isprint instead of isprint.
2062         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
2063         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
2064         ISSPACE instead of isspace.
2065         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
2066         instead of isspace.
2067         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
2068         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
2069         instead of isxdigit and ISDIGIT instead of isdigit.
2070
2071 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2072
2073         * gdbtypes.h (struct type) <field>: New method.
2074         (TYPE_FIELDS): Remove, replace all uses with either type::fields
2075         or type::field.
2076
2077 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2078
2079         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
2080         (TYPE_FIELDS): Use type::fields.  Change all call sites that
2081         modify the propery to use type::set_fields instead.
2082
2083 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2084
2085         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
2086         type::num_fields instead.
2087
2088 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2089
2090         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
2091         methods.
2092         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
2093         that modify the number of fields to use type::set_num_fields
2094         instead.
2095
2096 2020-05-22  Tom Tromey  <tromey@adacore.com>
2097
2098         * compile/compile-object-load.h (munmap_list_free): Don't
2099         declare.
2100
2101 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2102
2103         * annotate.c (annotate_source_line): Update return type, add call
2104         to update current symtab and line.
2105         * annotate.h (annotate_source_line): Update return type, and
2106         extend header comment.
2107         * source.c (info_line_command): Check annotation_level before
2108         calling annotate_source_line.
2109         * stack.c (print_frame_info): If calling annotate_source_line
2110         returns true, then don't print any other source line information.
2111
2112 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
2113
2114         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
2115
2116 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
2117
2118         * coffread.c (patch_type): Remove NULL check before xfree.
2119         * corefile.c (set_gnutarget): Likewise.
2120         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
2121         * exec.c (build_section_table): Likewise.
2122         * remote.c (remote_target::pass_signals): Likewise.
2123         * utils.c (n_spaces): Likewise.
2124         * cli/cli-script.c (document_command): Likewise.
2125         * i386-windows-tdep.c (core_process_module_section): Likewise.
2126         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
2127
2128 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
2129
2130         * symfile.c (reread_symbols): Clear objfile's section_offsets
2131         vector and section indices, re-compute them by calling
2132         sym_offsets.
2133
2134 2020-05-20  Tom Tromey  <tromey@adacore.com>
2135
2136         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
2137         (desc_one_bound, desc_index_type): Compute field name.
2138
2139 2020-05-20  Tom de Vries  <tdevries@suse.de>
2140
2141         PR symtab/25833
2142         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
2143
2144 2020-05-20  Alan Modra  <amodra@gmail.com>
2145
2146         PR 25993
2147         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
2148         bfd_set_filename.
2149         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
2150         passed to bfd_set_filename.
2151         * symfile-mem.c (add_vsyscall_page): Likewise for string
2152         passed to symbol_file_add_from_memory.
2153         (symbol_file_add_from_memory): Make name param a const char* and
2154         don't strdup.
2155
2156 2020-05-20  Alan Modra  <amodra@gmail.com>
2157
2158         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
2159         rather than accessing bfd->filename directly.
2160         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
2161         and use bfd_section_name.
2162         * dwarf2/frame.c (decode_frame_entry): Likewise.
2163         * exec.c (exec_set_section_address): Likewise.
2164         * solib-aix.c (solib_aix_bfd_open): Likewise.
2165         * stap-probe.c (get_stap_base_address): Likewise.
2166         * symfile.c (reread_symbols): Likewise.
2167
2168 2020-05-19  Tom Tromey  <tromey@adacore.com>
2169
2170         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
2171
2172 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2173
2174         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
2175
2176 2020-05-19  Pedro Alves  <palves@redhat.com>
2177
2178         * NEWS (set exec-file-mismatch): Adjust entry.
2179         * exec.c: Include "build-id.h".
2180         (validate_exec_file): Try to match build IDs instead of filenames.
2181         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
2182         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
2183         and pass down 'warn_if_slow'.
2184         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
2185         gdb_bfd_open_closure to pass it down.
2186         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
2187
2188 2020-05-19  Pedro Alves  <palves@redhat.com>
2189
2190         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
2191         * target.c (target_fileio_open_1): Rename to target_fileio_open
2192         and make extern.  Use bool.
2193         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
2194         (target_fileio_read_alloc_1): Adjust.
2195         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
2196         (target_fileio_open_warn_if_slow): Delete declaration.
2197
2198 2020-05-19  Pedro Alves  <palves@redhat.com>
2199
2200         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
2201         Adjust all callers.
2202
2203 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
2204
2205         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
2206         whether disp is negative.
2207
2208 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2209
2210         * symfile.h (struct symfile_segment_data)
2211         <~symfile_segment_data>: Remove.
2212         <segment_info>: Change to std::vector.
2213         * symfile.c (default_symfile_segments): Update.
2214         * elfread.c (elf_symfile_segments): Update.
2215
2216 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2217
2218         * symfile.h (struct symfile_segment_data) <struct segment>: New.
2219         <segments>: New.
2220         <segment_bases, segment_sizes>: Remove.
2221         * symfile.c (default_symfile_segments): Update.
2222         * elfread.c (elf_symfile_segments): Update.
2223         * remote.c (remote_target::get_offsets): Update.
2224         * solib-target.c (solib_target_relocate_section_addresses):
2225         Update.
2226
2227 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2228
2229         * symfile.h (struct symfile_segment_data): Initialize fields.
2230         <~symfile_segment_data>: Add.
2231         (symfile_segment_data_up): New.
2232         (struct sym_fns) <sym_segments>: Return a
2233         symfile_segment_data_up.
2234         (default_symfile_segments): Return a symfile_segment_data_up.
2235         (free_symfile_segment_data): Remove.
2236         (get_symfile_segment_data): Return a symfile_segment_data_up.
2237         * symfile.c (default_symfile_segments): Likewise.
2238         (get_symfile_segment_data): Likewise.
2239         (free_symfile_segment_data): Remove.
2240         (symfile_find_segment_sections): Update.
2241         * elfread.c (elf_symfile_segments): Return a
2242         symfile_segment_data_up.
2243         * remote.c (remote_target::get_offsets): Update.
2244         * solib-target.c (solib_target_relocate_section_addresses):
2245         Update.
2246         * symfile-debug.c (debug_sym_segments): Return a
2247         symfile_segment_data_up.
2248
2249 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2250
2251         PR build/25981
2252         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
2253         Hardcode register numbers.
2254
2255         PR build/25981
2256         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
2257         procfs_find_LDT_entry): Remove.
2258         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
2259         procfs_find_LDT_entry): Remove.
2260         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
2261         Remove.
2262
2263 2020-05-17  Pedro Alves  <palves@redhat.com>
2264             Andrew Burgess  <andrew.burgess@embecosm.com>
2265             Keno Fischer  <keno@juliacomputing.com>
2266
2267         PR gdb/25741
2268         * breakpoint.c (build_target_condition_list): Update comments.
2269         (build_target_command_list): Update comments and skip matching
2270         locations.
2271         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
2272         a separate function.  Simplify "set breakpoint auto-hw off"
2273         handling.
2274         (insert_breakpoints): Update comment.
2275         (tracepoint_locations_match): New parameter.  For breakpoints,
2276         compare location types too, if the caller wants to.
2277         (handle_automatic_hardware_breakpoints): New functions.
2278         (bp_location_is_less_than): Also sort by location type and
2279         hardware breakpoint length.
2280         (update_global_location_list): Handle "set breakpoint auto-hw on"
2281         here.
2282         (update_breakpoint_locations): Ask breakpoint_locations_match to
2283         ignore location types.
2284
2285 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2286
2287         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
2288         type::name instead.
2289
2290 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2291
2292         * gdbtypes.h (struct type) <name, set_name>: New methods.
2293         (TYPE_CODE): Use type::name.  Change all call sites used to set
2294         the name to use type::set_name instead.
2295
2296 2020-05-16  Tom Tromey  <tom@tromey.com>
2297
2298         * top.c (quit_force): Update.
2299         * infrun.c (handle_no_resumed): Update.
2300         * top.h (all_uis): New function.
2301         (ALL_UIS): Remove.
2302
2303 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2304
2305         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
2306
2307 2020-05-16  Pedro Alves  <palves@redhat.com>
2308
2309         * ia64-linux-nat.c
2310         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
2311         Declare method.
2312         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
2313
2314 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
2315
2316         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
2317         (sparc64_adi_info): Likewise.
2318
2319 2020-05-15  Tom Tromey  <tom@tromey.com>
2320
2321         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
2322         block_objfile.
2323         (lookup_objfile_from_block): Remove.
2324         (lookup_symbol_in_block, lookup_symbol_in_static_block)
2325         (lookup_global_symbol): Use block_objfile.
2326         * symtab.h (lookup_objfile_from_block): Don't declare.
2327         * printcmd.c (clear_dangling_display_expressions): Use
2328         block_objfile.
2329         * parse.c (operator_check_standard): Use block_objfile.
2330
2331 2020-05-15  Tom Tromey  <tom@tromey.com>
2332
2333         * language.c (language_alloc_type_symbol): Set
2334         SYMBOL_SECTION.
2335         * symtab.c (initialize_objfile_symbol): Remove.
2336         (allocate_symbol): Remove.
2337         (allocate_template_symbol): Remove.
2338         * dwarf2/read.c (fixup_go_packaging): Use "new".
2339         (new_symbol): Use "new".
2340         (read_variable): Don't call initialize_objfile_symbol.  Use
2341         "new".
2342         (read_func_scope): Use "new".
2343         * xcoffread.c (process_xcoff_symbol): Don't call
2344         initialize_objfile_symbol.
2345         (SYMBOL_DUP): Remove.
2346         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
2347         "new".
2348         * symtab.h (allocate_symbol, initialize_objfile_symbol)
2349         (allocate_template_symbol): Don't declare.
2350         (struct symbol): Add copy constructor.  Change defaults.
2351         * jit.c (finalize_symtab): Use "new".
2352         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
2353         Use "new".
2354         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
2355         (common_block_end): Use "new".
2356         * mdebugread.c (parse_symbol): Use "new".
2357         (new_symbol): Likewise.
2358
2359 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2360
2361         * NEWS: Mention changes to help and apropos.
2362
2363 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2364
2365         * command.h (enum command_class): Improve comments, document
2366         that class_alias is for user-defined aliases, give the class
2367         name for each class, remove unused class_xdb.
2368         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
2369         * breakpoint.c (_initialize_breakpoint): Replace class_alias
2370         by a precise class.
2371         * infcmd.c (_initialize_infcmd): Likewise.
2372         * reverse.c (_initialize_reverse): Likewise.
2373         * stack.c (_initialize_stack): Likewise.
2374         * symfile.c (_initialize_symfile): Likewise.
2375         * tracepoint.c (_initialize_tracepoint): Likewise.
2376
2377 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2378
2379         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
2380         when their aliased command is traversed.
2381         (help_cmd): Add fput_command_names_styled call to
2382         output command name and aliases when command has an alias.
2383
2384 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2385
2386         * cli/cli-decode.h (help_cmd_list): Remove declaration.
2387         * cli/cli-decode.c (help_cmd_list): Declare as static,
2388         remove prefix argument, use bool for recurse arg, rework to show the aliases of
2389         a command together with the command.
2390         (fput_command_name_styled, fput_command_names_styled): New functions.
2391         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
2392         fput_command_name_styled.
2393         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
2394         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
2395
2396 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2397
2398         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
2399         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
2400         * command.h (cmd_show_list): Likewise.
2401         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
2402         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
2403
2404 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2405
2406         * unittests/command-def-selftests.c (traverse_command_structure):
2407         Verify all commands of a list have the same prefix command and
2408         that only the top cmdlist commands have a null prefix.
2409
2410 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2411
2412         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
2413         as prefix, not one of its aliases.
2414         (set_cmd_prefix): Remove.
2415         (do_add_cmd): Centralize the setting of the prefix of a command, when
2416         command is defined after its full chain of prefix commands.
2417         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
2418         (add_setshow_cmd_full): Likewise.
2419         (update_prefix_field_of_prefixed_commands): New function.
2420         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
2421         update_prefix_field_of_prefixed_commands.
2422         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
2423         addresses of remote_set_cmdlist and remote_show_cmdlist given
2424         as argument, not the address of an argument.
2425         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
2426         * gdb/remote.c (_initialize_remote): Likewise.
2427
2428 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2429
2430         * cli/cli-cmds.c (alias_command): Check for an existing alias
2431         using lookup_cmd_composition, as valid_command_p is too strict
2432         and forbids aliases that are the prefix of an existing alias
2433         or command.
2434         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
2435         command is properly recognised as a valid command.
2436
2437 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2438
2439         * unittests/help-doc-selftests.c: Rename to
2440         unittests/command-def-selftests.c
2441         * unittests/command-def-selftests.c (help_doc_tests): Update some
2442         comments.
2443         (command_structure_tests, traverse_command_structure): New namespace
2444         and function.
2445         (command_structure_invariants_tests): New function.
2446         (_initialize_command_def_selftests) Renamed from
2447         _initialize_help_doc_selftests, register command_structure_invariants
2448         selftest.
2449
2450 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2451
2452         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
2453         an alias of 'show'.
2454
2455 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
2456
2457         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
2458         ada_is_fixed_point_type.  Update all callers.
2459         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
2460         all callers.
2461         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
2462         Update all callers.
2463         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
2464         print_fixed_point_type.  Update all callers.
2465         * ada-valprint.c (ada_value_print_num): Replace call to
2466         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
2467
2468 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
2469
2470         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
2471         processors.
2472         (cpu_supports_bts): Add CV_AMD case.
2473
2474 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
2475             Simon Marchi  <simon.marchi@efficios.com>
2476
2477         * infrun.c (stop_all_threads): Collect multiple wait events at
2478         each pass.
2479
2480 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
2481
2482         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
2483         type::code instead.
2484
2485 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
2486
2487         * gdbtypes.h (struct type) <code, set_code>: New methods.
2488         (TYPE_CODE): Use type::code.  Change all call sites used to set
2489         the code to use type::set_code instead.
2490
2491 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2492             Tom de Vries  <tdevries@suse.de>
2493             Pedro Alves  <palves@redhat.com>
2494
2495         PR threads/25478
2496         * infrun.c (stop_all_threads): Do NOT ignore
2497         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
2498         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
2499         received.
2500         (handle_no_resumed): Remove code handling a live inferior with no
2501         threads.
2502         * remote.c (has_single_non_exited_thread): New.
2503         (remote_target::update_thread_list): Do not delete a thread if is
2504         the last thread of the process.
2505         * thread.c (thread_select): Call delete_exited_threads instead of
2506         prune_threads.
2507
2508 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2509
2510         * infrun.c (stop_all_threads): Enable/disable thread events of all
2511         targets.  Move a debug message denoting the end of the function
2512         into the SCOPED_EXIT block.
2513
2514 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2515
2516         * process-stratum-target.h: Include <set>.
2517         (all_non_exited_process_targets, switch_to_target_no_thread): New
2518         function declarations.
2519         * process-stratum-target.c (all_non_exited_process_targets)
2520         (switch_to_target_no_thread): New function implementations.
2521
2522 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2523
2524         * infrun.c (handle_inferior_event): Extract out a piece of code
2525         into...
2526         (mark_non_executing_threads): ...this new function.
2527
2528 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2529
2530         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
2531         use.
2532
2533 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2534
2535         * regcache.c (regcache_read_pc_protected): New function
2536         implementation that returns 0 if the PC cannot read via
2537         'regcache_read_pc'.
2538         * infrun.c (proceed): Call 'regcache_read_pc_protected'
2539         instead of 'regcache_read_pc'.
2540         (keep_going_pass_signal): Ditto.
2541
2542 2020-05-13  Tom Tromey  <tromey@adacore.com>
2543
2544         * ada-lang.c (align_value): Remove.
2545         (ada_template_to_fixed_record_type_1): Use align_up.
2546
2547 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2548
2549         * async-event.c: Update the copyright year.
2550         * async-event.h: Update the copyright year.
2551
2552 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
2553
2554         * objfiles.h (is_addr_in_objfile,
2555         shared_objfile_contains_address_p): Return bool.
2556         * objfile.c (is_addr_in_objfile,
2557         shared_objfile_contains_address_p): Return bool.
2558
2559 2020-05-11  Tom Tromey  <tromey@adacore.com>
2560
2561         * cli/cli-cmds.c (info_command): Restore.
2562         (_initialize_cli_cmds): Use add_prefix_command for "info".
2563         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
2564
2565 2020-05-11  Tom Tromey  <tromey@adacore.com>
2566
2567         * ada-lang.c (ada_value_primitive_field): Now public.
2568         * ada-lang.h (ada_value_primitive_field): Declare.
2569         * ada-valprint.c (print_field_values): Use
2570         ada_value_primitive_field for wrapper fields.
2571
2572 2020-05-11  Tom de Vries  <tdevries@suse.de>
2573
2574         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
2575         MODULE_DOMAIN.
2576
2577 2020-05-11  Tom de Vries  <tdevries@suse.de>
2578
2579         PR symtab/25941
2580         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
2581         with length 0, if not gdb-produced.
2582         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
2583
2584 2020-05-09  Tom de Vries  <tdevries@suse.de>
2585
2586         PR gdb/25955
2587         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
2588         calculation.
2589
2590 2020-05-09  Tom Tromey  <tom@tromey.com>
2591
2592         * top.c (server_command): Now bool.
2593         * top.h (server_command): Now bool.
2594
2595 2020-05-08  Tom Tromey  <tromey@adacore.com>
2596
2597         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
2598         already being processed.
2599
2600 2020-05-08  Tom Tromey  <tom@tromey.com>
2601
2602         * printcmd.c (struct display) <next>: Remove.
2603         <display>: New constructor.
2604         <exp_string>: Now a std::string.
2605         <enabled_p>: Now a bool.
2606         (display_number): Move definition earlier.
2607         (displays): Rename from display_chain.  Now a std::vector.
2608         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
2609         (display_command): Update.
2610         (do_one_display, disable_display)
2611         (enable_disable_display_command, do_enable_disable_display):
2612         Update.
2613         (free_display): Remove.
2614         (clear_displays): Rewrite.
2615         (delete_display): Update.
2616         (map_display_numbers): Use function_view.  Remove "data"
2617         parameter.  Update.
2618         (do_delete_display): Remove.
2619         (undisplay_command): Update.
2620         (do_one_display, do_displays, disable_display)
2621         (info_display_command): Update.
2622         (do_enable_disable_display): Remove.
2623         (enable_disable_display_command)
2624         (clear_dangling_display_expressions): Update.
2625
2626 2020-05-08  Tom Tromey  <tom@tromey.com>
2627
2628         * symtab.c (set_symbol_cache_size)
2629         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
2630         (maintenance_print_symbol_cache_statistics): Update.
2631         * symmisc.c (print_symbol_bcache_statistics)
2632         (print_objfile_statistics, maintenance_print_objfiles)
2633         (maintenance_info_symtabs, maintenance_check_symtabs)
2634         (maintenance_expand_symtabs, maintenance_info_line_tables):
2635         Update.
2636         * symfile-debug.c (set_debug_symfile): Update.
2637         * source.c (forget_cached_source_info): Update.
2638         * python/python.c (gdbpy_progspaces): Update.
2639         * psymtab.c (maintenance_info_psymtabs): Update.
2640         * probe.c (parse_probes): Update.
2641         * linespec.c (iterate_over_all_matching_symtabs)
2642         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
2643         * guile/scm-progspace.c (gdbscm_progspaces): Update.
2644         * exec.c (exec_target::close): Update.
2645         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
2646         * breakpoint.c (print_one_breakpoint_location)
2647         (create_longjmp_master_breakpoint)
2648         (create_std_terminate_master_breakpoint): Update.
2649         * progspace.c (program_spaces): Now a std::vector.
2650         (maybe_new_address_space): Update.
2651         (add_program_space): Remove.
2652         (program_space::program_space): Update.
2653         (remove_program_space): Update.
2654         (number_of_program_spaces): Remove.
2655         (print_program_space, update_address_spaces): Update.
2656         * progspace.h (program_spaces): Change type.
2657         (ALL_PSPACES): Remove.
2658         (number_of_program_spaces): Don't declare.
2659         (struct program_space) <next>: Remove.
2660
2661 2020-05-08  Tom Tromey  <tom@tromey.com>
2662
2663         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
2664         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
2665         (enable_break): Update.
2666         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
2667         (frv_fdpic_find_canonical_descriptor): Update.
2668         (frv_fetch_objfile_link_map): Update.
2669         * progspace.c (program_space::free_all_objfiles): Update.
2670         (program_space::solibs): New method.
2671         * progspace.h (struct program_space) <solibs>: New method.
2672         * solist.h (master_so_list): Don't declare.
2673         (ALL_SO_LIBS): Remove.
2674         * solib.h (so_list_head): Remove.
2675         (update_solib_list): Update comment.
2676         * solib.c (master_so_list): Remove.
2677         (solib_used, update_solib_list, solib_add)
2678         (info_sharedlibrary_command, clear_solib)
2679         (reload_shared_libraries_1, remove_user_added_objfile): Update.
2680
2681 2020-05-08  Tom Tromey  <tom@tromey.com>
2682
2683         * extension.c (extension_languages): Now a std::array.
2684         (ALL_EXTENSION_LANGUAGES): Remove.
2685         (get_ext_lang_defn, get_ext_lang_of_file)
2686         (eval_ext_lang_from_control_command): Update.
2687         (finish_ext_lang_initialization)
2688         (auto_load_ext_lang_scripts_for_objfile)
2689         (ext_lang_type_printers::ext_lang_type_printers)
2690         (apply_ext_lang_type_printers)
2691         (ext_lang_type_printers::~ext_lang_type_printers)
2692         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
2693         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
2694         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
2695         (get_matching_xmethod_workers, ext_lang_colorize)
2696         (ext_lang_before_prompt): Update.
2697         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
2698
2699 2020-05-08  Tom Tromey  <tom@tromey.com>
2700
2701         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
2702         overload.
2703         <swap_string, m_string>: Remove.
2704         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
2705         Update.
2706         * stabsread.c (define_symbol, read_type): Update.
2707         * linespec.c (find_linespec_symbols): Update.
2708         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
2709         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
2710         * dbxread.c (read_dbx_symtab): Update.
2711         * cp-support.h (cp_canonicalize_string_full)
2712         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
2713         Return unique_xmalloc_ptr.
2714         * cp-support.c (inspect_type): Update.
2715         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
2716         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
2717         Likewise.
2718         * c-typeprint.c (print_name_maybe_canonical): Update.
2719         * break-catch-throw.c (check_status_exception_catchpoint):
2720         Update.
2721
2722 2020-05-08  Tom de Vries  <tdevries@suse.de>
2723
2724         * infrun.c (follow_fork): Copy current_line and current_symtab to
2725         child thread.
2726
2727 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2728
2729         * async-event.c (struct async_signal_handler, struct
2730         async_event_handler): Reformat, remove typedef.
2731
2732 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2733
2734         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
2735         access thistype->main_type->dyn_prop_list directly.
2736
2737 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2738
2739         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
2740         (remove_dyn_prop): Remove.  Update all users to use
2741         type::remove_dyn_prop.
2742         * gdbtypes.c (remove_dyn_prop): Rename to...
2743         (type::remove_dyn_prop): ... this.
2744
2745 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
2746
2747         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
2748         (add_dyn_prop): Remove.  Update all users to use
2749         type::add_dyn_prop.
2750         * gdbtypes.c (add_dyn_prop): Rename to...
2751         (type::add_dyn_prop): ... this.
2752
2753 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2754
2755         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
2756         (get_dyn_prop): Remove.  Update all users to use
2757         type::dyn_prop.
2758         * gdbtypes.c (get_dyn_prop): Rename to...
2759         (type::dyn_prop): ... this.
2760
2761 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
2762
2763         * gdbtypes.h (struct main_type) <flag_static>: Remove.
2764
2765 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
2766
2767         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
2768         instruction, skip it if it's there.
2769
2770 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
2771
2772         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
2773
2774 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
2775
2776         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
2777         * gdbtypes.c (recursive_dump_type): Remove use of
2778         TYPE_INCOMPLETE.
2779
2780 2020-05-03  Tom Tromey  <tom@tromey.com>
2781
2782         * breakpoint.c (catch_command, tcatch_command): Remove.
2783         (_initialize_breakpoint): Use add_basic_prefix_cmd,
2784         add_show_prefix_cmd.
2785         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
2786         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
2787         Remove.
2788         (add_internal_problem_command): Use add_basic_prefix_cmd,
2789         add_show_prefix_cmd.
2790         * mips-tdep.c (set_mipsfpu_command): Remove.
2791         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
2792         * dwarf2/index-cache.c (set_index_cache_command): Remove.
2793         (_initialize_index_cache): Use add_basic_prefix_cmd.
2794         * memattr.c (dummy_cmd): Remove.
2795         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
2796         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
2797         (_initialize_tui_win): Use add_basic_prefix_cmd,
2798         add_show_prefix_cmd.
2799         * cli/cli-logging.c (set_logging_command): Remove.
2800         (_initialize_cli_logging): Use add_basic_prefix_cmd,
2801         add_show_prefix_cmd.
2802         (show_logging_command): Remove.
2803         * target.c (target_command): Remove.
2804         (add_target): Use add_basic_prefix_cmd.
2805
2806 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
2807
2808         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
2809
2810 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2811
2812         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
2813         info_command.
2814
2815 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
2816
2817         * nbsd-nat.c (nbsd_enable_proc_events)
2818         (nbsd_nat_target::post_startup_inferior): Add.
2819         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
2820         (nbsd_nat_target::update_thread_list): Rewrite.
2821         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
2822         "PTRACE_LWP_CREATE".
2823         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
2824
2825 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2826
2827         * stack.c (_initialize_stack): Remove duplicated creation
2828         of "frame" command and "f" alias.
2829
2830 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
2831
2832         PR gdb/18706
2833         * gdbtypes.c (check_typedef): Calculate size of array of
2834         stubbed type.
2835
2836 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
2837
2838         PR gdb/15559
2839         * i386-tdep.c (i386_push_dummy_call): Call
2840         i386_thiscall_push_dummy_call.
2841         (i386_thiscall_push_dummy_call): New function.
2842         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
2843         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
2844         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
2845
2846 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2847
2848         * gdbarch.sh (do_read): Add shellcheck disable directive for
2849         warning SC2162.
2850
2851 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2852
2853         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
2854         "referenced but not assigned" warning.
2855
2856 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2857
2858         * gdbarch.sh: Remove code that sets fallbackdefault.
2859
2860 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2861
2862         * gdbarch.sh: Use shell operators && and || instead of
2863         -a and -o.
2864
2865 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2866
2867         * gdbarch.sh: Use $(...) instead of `...`.
2868
2869 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2870
2871         * gdbarch.sh: Use double quotes around variables.
2872
2873 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2874
2875         * gdbarch.sh: Use %s with printf, instead of variables in the
2876         format string.
2877
2878 2020-04-29  Tom Tromey  <tromey@adacore.com>
2879
2880         PR ada/25875:
2881         * dwarf2/read.c (update_enumeration_type_from_children): Compute
2882         type fields here.
2883         (read_enumeration_type): Call
2884         update_enumeration_type_from_children later.  Update comments.
2885         (process_enumeration_scope): Don't create type fields.
2886
2887 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
2888
2889         * nbsd-tdep.c: Include "xml-syscall.h".
2890         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
2891
2892 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
2893
2894         * nbsd-nat.c: Include "sys/wait.h".
2895         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
2896         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
2897         (nbsd_nat_target::remove_exec_catchpoint)
2898         (nbsd_nat_target::set_syscall_catchpoint): Add.
2899         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
2900         (nbsd_nat_target::insert_exec_catchpoint)
2901         (nbsd_nat_target::remove_exec_catchpoint)
2902         (nbsd_nat_target::set_syscall_catchpoint): Add.
2903         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
2904         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
2905         `nbsd_get_syscall_number'.
2906
2907 2020-04-29  Tom Tromey  <tom@tromey.com>
2908
2909         * stack.c (print_block_frame_labels): Remove.
2910
2911 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
2912
2913         PR gdb/17320
2914         * ada-valprint.c (val_print_packed_array_elements): Move array
2915         end bracket to new line.
2916         (ada_val_print_string): Remove extra spaces before first array
2917         element.
2918         * c-valprint.c (c_value_print_array): Likewise.
2919         * m2-valprint.c (m2_print_array_contents): Likewise.
2920         (m2_value_print_inner): Likewise.
2921         * p-valprint.c (pascal_value_print_inner): Likewise.
2922         * valprint.c (generic_val_print_array): Likewise.
2923         (value_print_array_elements): Move first array element and array
2924         end bracket to new line.
2925
2926 2020-04-29  Tom de Vries  <tdevries@suse.de>
2927
2928         PR symtab/25889
2929         * linespec.c (find_method): Fix ix calculation.
2930
2931 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
2932
2933         * syscalls/update-netbsd.sh: New file.
2934         * syscalls/netbsd.xml: Regenerate.
2935         * data-directory/Makefile.in: Register `netbsd.xml' in
2936         `SYSCALLS_FILES'.
2937
2938 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
2939
2940         * syscalls/update-freebsd.sh: Add double quotes.
2941
2942 2020-04-28  Tom Tromey  <tom@tromey.com>
2943
2944         * NEWS: Update.
2945         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
2946         (cmdpy_init): Allow class_tui.
2947
2948 2020-04-28 Mark Williams <mark@myosotissp.com>
2949
2950         PR gdb/24480
2951         * dwarf2read.c: Add missing assingments to list_in_scope when
2952         start_symtab was already called.
2953
2954 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
2955
2956         PR gdb/25881
2957         * dwarf2/read.c (offset_map_type): Use
2958         gdb:hash_enum<sect_offset> as hash function.
2959
2960 2020-04-28  Tom de Vries  <tdevries@suse.de>
2961
2962         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
2963         with DW_AT_signature.
2964
2965 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
2966
2967         * configure.ac: Remove check for fs_base/gs_base in
2968         user_regs_struct.
2969         * configure: Re-generate.
2970         * config.in: Re-generate.
2971         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
2972         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
2973         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
2974
2975 2020-04-27  Luis Machado  <luis.machado@linaro.org>
2976
2977         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
2978         problematic inline frame unwinding situation.
2979         * frame.c (frame_id_computed_p): New function.
2980         * frame.h (frame_id_computed_p): New prototype.
2981
2982 2020-04-26  Tom Tromey  <tom@tromey.com>
2983
2984         * command.h (enum command_class) <class_pseudo>: Remove.
2985
2986 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2987
2988         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
2989         and whitespace.
2990
2991 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
2992
2993         * inf-ptrace.c (inf_ptrace_target::wait): Remove
2994         `PT_GET_PROCESS_STATE' block.
2995
2996 2020-04-24  Tom Tromey  <tom@tromey.com>
2997
2998         * symtab.h (symbol_get_demangled_name): Don't declare.
2999         * symtab.c (symbol_get_demangled_name): Remove.
3000         (general_symbol_info::natural_name)
3001         (general_symbol_info::demangled_name): Update.
3002
3003 2020-04-24  Tom Tromey  <tom@tromey.com>
3004
3005         PR rust/25025:
3006         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
3007
3008 2020-04-24  Tom Tromey  <tom@tromey.com>
3009
3010         PR symtab/12707:
3011         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
3012         exists.
3013         (new_symbol): Likewise.
3014         * compile/compile-object-load.c (get_out_value_type): Use
3015         symbol_matches_search_name.
3016
3017 2020-04-24  Tom Tromey  <tom@tromey.com>
3018
3019         * dwarf2/read.c (add_partial_symbol): Do not call
3020         compute_and_set_names.
3021
3022 2020-04-24  Tom Tromey  <tom@tromey.com>
3023
3024         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
3025         overload.
3026
3027 2020-04-24  Tom Tromey  <tom@tromey.com>
3028
3029         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
3030         (add_psymbol_to_list): New overload.  Make old overload call new
3031         one.
3032         * psympriv.h (add_psymbol_to_list): New overload.
3033
3034 2020-04-24  Tom Tromey  <tom@tromey.com>
3035
3036         * dwarf2/read.c (partial_die_info::read) <case
3037         DW_AT_linkage_name>: Use value_as_string.
3038         (dwarf2_string_attr): Use value_as_string.
3039         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
3040         method.
3041         * dwarf2/attribute.c (attribute::value_as_string): New method.
3042
3043 2020-04-24  Tom Tromey  <tom@tromey.com>
3044
3045         * symtab.c (general_symbol_info::natural_name)
3046         (general_symbol_info::demangled_name): Check for language_rust.
3047
3048 2020-04-24  Tom Tromey  <tom@tromey.com>
3049
3050         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
3051         (dwarf2_physname): ... from here.
3052         (partial_die_info::read): Add Rust "{" hack.
3053
3054 2020-04-24  Tom Tromey  <tom@tromey.com>
3055
3056         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
3057         method.
3058         (symbol_set_demangled_name): Don't declare.
3059         * symtab.c (general_symbol_info::set_demangled_name): Rename from
3060         symbol_set_demangled_name.
3061         (general_symbol_info::set_language)
3062         (general_symbol_info::compute_and_set_names): Update.
3063         * minsyms.c (minimal_symbol_reader::install): Update.
3064         * dwarf2/read.c (new_symbol): Update.
3065
3066 2020-04-24  Tom Tromey  <tromey@adacore.com>
3067
3068         PR python/23662:
3069         * python/py-type.c (convert_field): Handle
3070         FIELD_LOC_KIND_DWARF_BLOCK.
3071         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
3072         (typy_get_dynamic): Nw function.
3073         (type_object_getset): Add "dynamic".
3074         * NEWS: Add entry.
3075
3076 2020-04-24  Tom Tromey  <tromey@adacore.com>
3077
3078         * ada-typeprint.c (print_choices, print_variant_part)
3079         (print_record_field_types_dynamic): New functions.
3080         (print_record_field_types): Use print_record_field_types_dynamic.
3081
3082 2020-04-24  Tom Tromey  <tromey@adacore.com>
3083
3084         * dwarf2/read.c (handle_data_member_location): New overload.
3085         (dwarf2_add_field): Use it.
3086         (decode_locdesc): Add "computed" parameter.  Update comment.
3087         * gdbtypes.c (is_dynamic_type_internal): Also look for
3088         FIELD_LOC_KIND_DWARF_BLOCK.
3089         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
3090         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
3091         virtual base classes.
3092         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
3093         FIELD_LOC_KIND_DWARF_BLOCK.
3094
3095 2020-04-24  Tom Tromey  <tromey@adacore.com>
3096
3097         * dwarf2/read.c (read_structure_type): Handle dynamic length.
3098         * gdbtypes.c (is_dynamic_type_internal): Check
3099         TYPE_HAS_DYNAMIC_LENGTH.
3100         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
3101         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
3102         New macros.
3103         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
3104         constant.
3105
3106 2020-04-24  Tom Tromey  <tromey@adacore.com>
3107
3108         * dwarf2/read.c (struct variant_field): Rewrite.
3109         (struct variant_part_builder): New.
3110         (struct nextfield): Remove "variant" field.  Add "offset".
3111         (struct field_info): Add "current_variant_part" and
3112         "variant_parts".
3113         (alloc_discriminant_info): Remove.
3114         (alloc_rust_variant): New function.
3115         (quirk_rust_enum): Update.
3116         (dwarf2_add_field): Set "offset" member.  Don't handle
3117         DW_TAG_variant_part.
3118         (offset_map_type): New typedef.
3119         (convert_variant_range, create_one_variant)
3120         (create_one_variant_part, create_variant_parts)
3121         (add_variant_property): New functions.
3122         (dwarf2_attach_fields_to_type): Call add_variant_property.
3123         (read_structure_type): Don't handle DW_TAG_variant_part.
3124         (handle_variant_part, handle_variant): New functions.
3125         (handle_struct_member_die): Use them.
3126         (process_structure_scope): Don't handle variant parts.
3127         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
3128         (struct discriminant_info): Remove.
3129         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
3130         (struct main_type) <flag_discriminated_union>: Remove.
3131         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
3132         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
3133         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
3134         Update.
3135         * valops.c (value_union_variant): Remove.
3136         * value.h (value_union_variant): Don't declare.
3137
3138 2020-04-24  Tom Tromey  <tromey@adacore.com>
3139
3140         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
3141         (ada_value_primitive_packed_val): Update.
3142         * ada-valprint.c (ada_value_print_1): Update.
3143         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
3144         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
3145         just an address.  Use evaluate_for_locexpr_baton.
3146         (dwarf2_evaluate_property): Update.
3147         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
3148         array_view.
3149         * findvar.c (default_read_var_value): Update.
3150         * gdbtypes.c (compute_variant_fields_inner)
3151         (resolve_dynamic_type_internal): Update.
3152         (resolve_dynamic_type): Change type of valaddr parameter.
3153         * gdbtypes.h (resolve_dynamic_type): Update.
3154         * valarith.c (value_subscripted_rvalue): Update.
3155         * value.c (value_from_contents_and_address): Update.
3156
3157 2020-04-24  Tom Tromey  <tromey@adacore.com>
3158
3159         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
3160         "push_initial_value" parameter.
3161         (dwarf2_evaluate_property): Likewise.
3162         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
3163
3164 2020-04-24  Tom Tromey  <tromey@adacore.com>
3165
3166         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
3167         (variant::matches, compute_variant_fields_recurse)
3168         (compute_variant_fields_inner, compute_variant_fields): New
3169         functions.
3170         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
3171         Use resolved_type after type is made.
3172         (operator==): Add new cases.
3173         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
3174         (struct discriminant_range, struct variant, struct variant_part):
3175         New.
3176         (union dynamic_prop_data) <variant_parts, original_type>: New
3177         members.
3178         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
3179         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
3180         constants.
3181         * value.c (unpack_bits_as_long): Now public.
3182         * value.h (unpack_bits_as_long): Declare.
3183
3184 2020-04-24  Tom Tromey  <tromey@adacore.com>
3185
3186         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
3187         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
3188
3189 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
3190
3191         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
3192
3193 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
3194
3195         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
3196         (remove_fork_catchpoint, post_startup_inferior)
3197         (post_attach): Move...
3198         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
3199         (remove_fork_catchpoint, post_startup_inferior)
3200         (post_attach): ...here.
3201         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
3202         (remove_fork_catchpoint, post_startup_inferior)
3203         (post_attach): Move...
3204         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
3205         (remove_fork_catchpoint, post_startup_inferior)
3206         (post_attach): ...here.
3207
3208 2020-04-24  Tom Tromey  <tromey@adacore.com>
3209
3210         * nat/windows-nat.h (struct windows_thread_info)
3211         <pc_adjusted>: New member.
3212         * windows-nat.c (windows_fetch_one_register): Check
3213         pc_adjusted.
3214         (windows_nat_target::get_windows_debug_event)
3215         (windows_nat_target::wait): Set pc_adjusted.
3216
3217 2020-04-24  Tom de Vries  <tdevries@suse.de>
3218
3219         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
3220         Run gdb-add-index inside temp dir.
3221
3222 2020-04-23  Tom Tromey  <tromey@adacore.com>
3223
3224         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
3225         in loop.
3226
3227 2020-04-23  Luis Machado  <luis.machado@linaro.org>
3228
3229         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
3230         get_frame_register instead of gdbarch_unwind_pc.
3231
3232 2020-04-23  Tom de Vries  <tdevries@suse.de>
3233
3234         * symtab.c (lookup_global_symbol): Prefer def over decl.
3235
3236 2020-04-23  Tom de Vries  <tdevries@suse.de>
3237
3238         PR symtab/25807
3239         * block.c (best_symbol, better_symbol): Promote to external.
3240         * block.h (best_symbol, better_symbol): Declare.
3241         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
3242         decl.
3243
3244 2020-04-23  Tom Tromey  <tromey@adacore.com>
3245
3246         PR ada/25837:
3247         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
3248         "const char *", not a "const std::string &".
3249         <name_and_matcher::operator==>: Update.
3250         * unittests/lookup_name_info-selftests.c: Change type of
3251         "result".
3252
3253 2020-04-23  Tom Tromey  <tom@tromey.com>
3254
3255         * inferior.h (iterate_over_inferiors): Don't declare.
3256         * inferior.c (iterate_over_inferiors): Remove.
3257         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
3258         Remove.
3259         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
3260         use iterate_over_inferiors.
3261         (darwin_resume_inferior_it)
3262         (struct resume_inferior_threads_param)
3263         (darwin_resume_inferior_threads_it): Remove.
3264         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
3265
3266 2020-04-23  Tom de Vries  <tdevries@suse.de>
3267
3268         * blockframe.c (find_pc_partial_function): Use
3269         find_pc_sect_compunit_symtab rather than
3270         objfile->sf->qf->find_pc_sect_compunit_symtab.
3271
3272 2020-04-22  Tom de Vries  <tdevries@suse.de>
3273
3274         PR symtab/25764
3275         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
3276         in psymtabs.
3277
3278 2020-04-22  Tom de Vries  <tdevries@suse.de>
3279
3280         PR symtab/25801
3281         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
3282         symtabs.
3283
3284 2020-04-22  Tom de Vries  <tdevries@suse.de>
3285
3286         PR symtab/25700
3287         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
3288         CU if already created.
3289
3290 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3291
3292         * infrun.c (displaced_step_fixup): Switch to the event_thread
3293         before calling displaced_step_restore, not after.
3294
3295 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3296
3297         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
3298         its inferior is not recorded by us.
3299         (record_btrace_target_open): Replace call to
3300         all_non_exited_threads () with call to current_inferior
3301         ()->non_exited_threads ().
3302         (record_btrace_target::stop_recording): Likewise.
3303         (record_btrace_target::close): Likewise.
3304         (record_btrace_target::wait): Likewise.
3305         (record_btrace_target::record_stop_replaying): Likewise.
3306
3307 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3308
3309         * btrace.c (btrace_enable): Throw an error on double enables and
3310         when enabling recording fails.
3311         (btrace_disable): Throw an error if the thread is not recorded.
3312
3313 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3314
3315         * record-btrace.c (record_btrace_target::fetch_registers): Forward
3316         request if we do not have a thread_info.
3317
3318 2020-04-21  Tom de Vries  <tdevries@suse.de>
3319
3320         PR gdb/25471
3321         * thread.c
3322         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
3323         exception in get_frame_id.
3324
3325 2020-04-20  Tom Tromey  <tromey@adacore.com>
3326
3327         * python/python.c (struct gdbpy_event): Mark move constructor as
3328         noexcept.
3329         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
3330         constructor as noexcept.
3331         * completer.h (struct completion_result): Mark move constructor as
3332         noexcept.
3333         * completer.c (completion_result::completion_result): Use
3334         initialization style.  Don't call reset_match_list.
3335
3336 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
3337
3338         * MAINTAINERS (Write After Approval): Add myself.
3339
3340 2020-04-18  Tom Tromey  <tom@tromey.com>
3341
3342         * windows-tdep.c (init_w32_command_list)
3343         (w32_prefix_command_valid): Restore.
3344         (_initialize_windows_tdep): Call init_w32_command_list.
3345
3346 2020-04-18  Tom Tromey  <tom@tromey.com>
3347
3348         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
3349         * value.c (value_fn_field): Update.
3350         * valops.c (find_function_in_inferior)
3351         (value_allocate_space_in_inferior): Update.
3352         * tui/tui-winsource.c (tui_update_source_windows_with_line):
3353         Update.
3354         * tui/tui-source.c (tui_source_window::set_contents): Update.
3355         * symtab.c (lookup_global_or_static_symbol)
3356         (find_function_start_sal_1, skip_prologue_sal)
3357         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
3358         * symmisc.c (dump_msymbols, dump_symtab_1)
3359         (maintenance_print_one_line_table): Update.
3360         * symfile.c (init_entry_point_info, section_is_mapped)
3361         (list_overlays_command, simple_read_overlay_table)
3362         (simple_overlay_update_1): Update.
3363         * stap-probe.c (handle_stap_probe): Update.
3364         * stabsread.c (dbx_init_float_type, define_symbol)
3365         (read_one_struct_field, read_enum_type, read_range_type): Update.
3366         * source.c (info_line_command): Update.
3367         * python/python.c (gdbpy_source_objfile_script)
3368         (gdbpy_execute_objfile_script): Update.
3369         * python/py-type.c (save_objfile_types): Update.
3370         * python/py-objfile.c (py_free_objfile): Update.
3371         * python/py-inferior.c (python_new_objfile): Update.
3372         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
3373         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
3374         (maintenance_check_psymtabs): Update.
3375         * printcmd.c (info_address_command): Update.
3376         * objfiles.h (struct objfile) <arch>: New method, from
3377         get_objfile_arch.
3378         (get_objfile_arch): Don't declare.
3379         * objfiles.c (get_objfile_arch): Remove.
3380         (filter_overlapping_sections): Update.
3381         * minsyms.c (msymbol_is_function): Update.
3382         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
3383         (output_nondebug_symbol): Update.
3384         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
3385         (mdebug_expand_psymtab): Update.
3386         * machoread.c (macho_add_oso_symfile): Update.
3387         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
3388         Update.
3389         * linux-fork.c (checkpoint_command): Update.
3390         * linespec.c (convert_linespec_to_sals): Update.
3391         * jit.c (finalize_symtab): Update.
3392         * infrun.c (insert_exception_resume_from_probe): Update.
3393         * ia64-tdep.c (ia64_find_unwind_table): Update.
3394         * hppa-tdep.c (internalize_unwinds): Update.
3395         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
3396         Update.
3397         * gcore.c (call_target_sbrk): Update.
3398         * elfread.c (record_minimal_symbol, elf_symtab_read)
3399         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
3400         (elf_gnu_ifunc_resolve_by_got): Update.
3401         * dwarf2/read.c (create_addrmap_from_index)
3402         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3403         (read_debug_names_from_section)
3404         (process_psymtab_comp_unit_reader, add_partial_symbol)
3405         (add_partial_subprogram, process_full_comp_unit)
3406         (read_file_scope, read_func_scope, read_lexical_block_scope)
3407         (read_call_site_scope, dwarf2_ranges_read)
3408         (dwarf2_record_block_ranges, dwarf2_add_field)
3409         (mark_common_block_symbol_computed, read_tag_pointer_type)
3410         (read_tag_string_type, dwarf2_init_float_type)
3411         (dwarf2_init_complex_target_type, read_base_type)
3412         (partial_die_info::read, partial_die_info::read)
3413         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
3414         (dwarf2_fetch_die_loc_sect_off): Update.
3415         * dwarf2/loc.c (dwarf2_find_location_expression)
3416         (class dwarf_evaluate_loc_desc, rw_pieced_value)
3417         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
3418         (dwarf2_loc_desc_get_symbol_read_needs)
3419         (locexpr_describe_location_piece, locexpr_describe_location_1)
3420         (loclist_describe_location): Update.
3421         * dwarf2/index-write.c (write_debug_names): Update.
3422         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
3423         * dtrace-probe.c (dtrace_process_dof): Update.
3424         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
3425         (process_one_symbol): Update.
3426         * ctfread.c (ctf_init_float_type, read_base_type): Update.
3427         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
3428         (coff_read_enum_type): Update.
3429         * cli/cli-cmds.c (edit_command, list_command): Update.
3430         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
3431         * breakpoint.c (create_overlay_event_breakpoint)
3432         (create_longjmp_master_breakpoint)
3433         (create_std_terminate_master_breakpoint)
3434         (create_exception_master_breakpoint, get_sal_arch): Update.
3435         * block.c (block_gdbarch): Update.
3436         * annotate.c (annotate_source_line): Update.
3437
3438 2020-04-17  Tom Tromey  <tromey@adacore.com>
3439
3440         * auto-load.c (show_auto_load_cmd): Remove.
3441         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
3442         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
3443         (maintenance_print_arc_command): Remove.
3444         * tui/tui-win.c (tui_command): Remove.
3445         (tui_get_cmd_list): Use add_basic_prefix_cmd.
3446         * tui/tui-layout.c (tui_layout_command): Remove.
3447         (_initialize_tui_layout): Use add_basic_prefix_cmd.
3448         * python/python.c (user_set_python, user_show_python): Remove.
3449         (_initialize_python): Use add_basic_prefix_cmd,
3450         add_show_prefix_cmd.
3451         * guile/guile.c (set_guile_command, show_guile_command): Remove.
3452         (install_gdb_commands): Use add_basic_prefix_cmd,
3453         add_show_prefix_cmd.
3454         (info_guile_command): Remove.
3455         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
3456         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
3457         add_show_prefix_cmd.
3458         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
3459         Remove do_set and do_show parameters.
3460         * cli/cli-style.c (set_style, show_style): Remove.
3461         (_initialize_cli_style): Use add_basic_prefix_cmd,
3462         add_show_prefix_cmd.
3463         (cli_style_option::add_setshow_commands): Remove do_set and
3464         do_show parameters.
3465         (cli_style_option::add_setshow_commands): Use
3466         add_basic_prefix_cmd, add_show_prefix_cmd.
3467         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
3468         (set_style_name): Remove.
3469         * cli/cli-dump.c (dump_command, append_command): Remove.
3470         (srec_dump_command, ihex_dump_command, verilog_dump_command)
3471         (tekhex_dump_command, binary_dump_command)
3472         (binary_append_command): Remove.
3473         (_initialize_cli_dump): Use add_basic_prefix_cmd.
3474         * windows-tdep.c (w32_prefix_command_valid): Remove global.
3475         (init_w32_command_list): Remove; move into ...
3476         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
3477         * valprint.c (set_print, show_print, set_print_raw)
3478         (show_print_raw): Remove.
3479         (_initialize_valprint): Use add_basic_prefix_cmd,
3480         add_show_prefix_cmd.
3481         * typeprint.c (set_print_type, show_print_type): Remove.
3482         (_initialize_typeprint): Use add_basic_prefix_cmd,
3483         add_show_prefix_cmd.
3484         * record.c (set_record_command, show_record_command): Remove.
3485         (_initialize_record): Use add_basic_prefix_cmd,
3486         add_show_prefix_cmd.
3487         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
3488         add_show_prefix_cmd.
3489         (info_command, show_command, set_debug, show_debug): Remove.
3490         * top.h (set_history, show_history): Don't declare.
3491         * top.c (set_history, show_history): Remove.
3492         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
3493         (unset_tdesc_cmd): Remove.
3494         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
3495         add_show_prefix_cmd.
3496         * symtab.c (info_module_command): Remove.
3497         (_initialize_symtab): Use add_basic_prefix_cmd.
3498         * symfile.c (overlay_command): Remove.
3499         (_initialize_symfile): Use add_basic_prefix_cmd.
3500         * sparc64-tdep.c (info_adi_command): Remove.
3501         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
3502         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
3503         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
3504         add_show_prefix_cmd.
3505         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
3506         (_initialize_serial): Use add_basic_prefix_cmd,
3507         add_show_prefix_cmd.
3508         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
3509         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
3510         add_show_prefix_cmd.
3511         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
3512         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
3513         add_show_prefix_cmd.
3514         * riscv-tdep.c (show_riscv_command, set_riscv_command)
3515         (show_debug_riscv_command, set_debug_riscv_command): Remove.
3516         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
3517         add_show_prefix_cmd.
3518         * remote.c (remote_command, set_remote_cmd): Remove.
3519         (_initialize_remote): Use add_basic_prefix_cmd.
3520         * record-full.c (set_record_full_command)
3521         (show_record_full_command): Remove.
3522         (_initialize_record_full): Use add_basic_prefix_cmd,
3523         add_show_prefix_cmd.
3524         * record-btrace.c (cmd_set_record_btrace)
3525         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
3526         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
3527         (cmd_show_record_btrace_pt): Remove.
3528         (_initialize_record_btrace): Use add_basic_prefix_cmd,
3529         add_show_prefix_cmd.
3530         * ravenscar-thread.c (set_ravenscar_command)
3531         (show_ravenscar_command): Remove.
3532         (_initialize_ravenscar): Use add_basic_prefix_cmd,
3533         add_show_prefix_cmd.
3534         * mips-tdep.c (show_mips_command, set_mips_command)
3535         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
3536         add_show_prefix_cmd.
3537         * maint.c (maintenance_command, maintenance_info_command)
3538         (maintenance_check_command, maintenance_print_command)
3539         (maintenance_set_cmd, maintenance_show_cmd): Remove.
3540         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
3541         add_show_prefix_cmd.
3542         (show_per_command_cmd): Remove.
3543         * maint-test-settings.c (maintenance_set_test_settings_cmd):
3544         Remove.
3545         (maintenance_show_test_settings_cmd): Remove.
3546         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
3547         add_show_prefix_cmd.
3548         * maint-test-options.c (maintenance_test_options_command):
3549         Remove.
3550         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
3551         * macrocmd.c (macro_command): Remove
3552         (_initialize_macrocmd): Use add_basic_prefix_cmd.
3553         * language.c (set_check, show_check): Remove.
3554         (_initialize_language): Use add_basic_prefix_cmd,
3555         add_show_prefix_cmd.
3556         * infcmd.c (unset_command): Remove.
3557         (_initialize_infcmd): Use add_basic_prefix_cmd.
3558         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
3559         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
3560         add_show_prefix_cmd.
3561         * go32-nat.c (go32_info_dos_command): Remove.
3562         (_initialize_go32_nat): Use add_basic_prefix_cmd.
3563         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
3564         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
3565         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
3566         (_initialize_frame): Use add_basic_prefix_cmd,
3567         add_show_prefix_cmd.
3568         * dcache.c (set_dcache_command, show_dcache_command): Remove.
3569         (_initialize_dcache): Use add_basic_prefix_cmd,
3570         add_show_prefix_cmd.
3571         * cp-support.c (maint_cplus_command): Remove.
3572         (_initialize_cp_support): Use add_basic_prefix_cmd.
3573         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
3574         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
3575         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
3576         add_basic_prefix_cmd, add_show_prefix_cmd.
3577         * breakpoint.c (save_command): Remove.
3578         (_initialize_breakpoint): Use add_basic_prefix_cmd.
3579         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
3580         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
3581         add_show_prefix_cmd.
3582         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
3583         (set_ada_command, show_ada_command): Remove.
3584         (_initialize_ada_language): Use add_basic_prefix_cmd,
3585         add_show_prefix_cmd.
3586         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
3587
3588 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
3589
3590         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
3591         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
3592
3593 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
3594
3595         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
3596         warning messages.
3597
3598 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
3599
3600         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
3601         import table is not at beginning of .idata section.
3602
3603 2020-04-16  Pedro Alves  <palves@redhat.com>
3604
3605         * inferior.c (delete_inferior): Use delete operator directly
3606         instead of delete_program_space.
3607         * progspace.c (add_program_space): New, factored out from
3608         program_space::program_space.
3609         (remove_program_space): New, factored out from
3610         delete_program_space.
3611         (program_space::program_space): Remove intro comment.  Rewrite.
3612         (program_space::~program_space): Remove intro comment.  Call
3613         remove_program_space.
3614         (delete_program_space): Delete.
3615         * progspace.h (program_space::program_space): Make explicit.  Move
3616         intro comment here, adjusted.
3617         (program_space::~program_space): Move intro comment here,
3618         adjusted.
3619         (delete_program_space): Remove.
3620
3621 2020-04-16  Tom Tromey  <tromey@adacore.com>
3622
3623         * windows-nat.c (windows_nat::handle_access_violation): New
3624         function.
3625         * nat/windows-nat.h (handle_access_violation): Declare.
3626         * nat/windows-nat.c (handle_exception): Move Cygwin code to
3627         windows-nat.c.  Call handle_access_violation.
3628
3629 2020-04-16  Tom de Vries  <tdevries@suse.de>
3630
3631         PR symtab/25791
3632         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
3633         CUs without psymtab.
3634
3635 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
3636
3637         * python/python.c (do_start_initialization): Don't call
3638         PyEval_InitThreads for Python 3.9 and beyond.
3639
3640 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
3641
3642         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
3643         thread functions.
3644         (obsd_nat_target::wait): Likewise.
3645
3646 2020-04-15  Tom Tromey  <tromey@adacore.com>
3647
3648         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
3649         (DEBUG_EXCEPT): Use debug_printf.
3650
3651 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3652
3653         * completer.c (class completion_tracker::completion_hash_entry)
3654         <hash_name>: New member function.
3655         (completion_tracker::discard_completions): New callback to hash a
3656         completion_hash_entry, pass this to htab_create_alloc.
3657
3658 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
3659
3660         * windows-nat.c (windows_make_so): Warn rather than stopping with
3661         an error if realpath() fails.
3662
3663 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
3664
3665         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
3666         (nbsd_nat_target::info_proc): Add do_status.
3667
3668 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
3669             Tom de Vries  <tdevries@suse.de>
3670
3671         PR symtab/25718
3672         * psympriv.h (struct partial_symtab::read_symtab)
3673         (struct partial_symtab::expand_psymtab)
3674         (struct partial_symtab::read_dependencies): Update comments.
3675         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
3676         read_symtab for includer.
3677         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
3678         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
3679         (struct dwarf2_include_psymtab::m_readin): Remove.
3680         (struct dwarf2_include_psymtab::includer): New member function.
3681         (dwarf2_psymtab::expand_psymtab): Assert !readin.
3682
3683 2020-04-14  Tom de Vries  <tdevries@suse.de>
3684
3685         PR symtab/25720
3686         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
3687         with NULL symbol_matcher and lookup_name.
3688         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
3689         and lookup_name.
3690         * dwarf2/read.c (dw2_expand_symtabs_matching)
3691         (dw2_debug_names_expand_symtabs_matching): Same.
3692         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
3693         Make lookup_name a pointer.  Update comment.
3694         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
3695         lookup_name being a pointer.
3696         * symfile.c (expand_symtabs_matching): Same.
3697         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
3698         * linespec.c (iterate_over_all_matching_symtabs): Same.
3699
3700 2020-04-13  Tom Tromey  <tom@tromey.com>
3701
3702         * run-on-main-thread.c: Update include.
3703         * unittests/main-thread-selftests.c: Update include.
3704         * tui/tui-win.c: Update include.
3705         * tui/tui-io.c: Update include.
3706         * tui/tui-interp.c: Update include.
3707         * tui/tui-hooks.c: Update include.
3708         * top.h: Update include.
3709         * top.c: Update include.
3710         * ser-base.c: Update include.
3711         * remote.c: Update include.
3712         * remote-notif.c: Update include.
3713         * remote-fileio.c: Update include.
3714         * record-full.c: Update include.
3715         * record-btrace.c: Update include.
3716         * python/python.c: Update include.
3717         * posix-hdep.c: Update include.
3718         * mingw-hdep.c: Update include.
3719         * mi/mi-main.c: Update include.
3720         * mi/mi-interp.c: Update include.
3721         * main.c: Update include.
3722         * linux-nat.c: Update include.
3723         * interps.c: Update include.
3724         * infrun.c: Update include.
3725         * inf-loop.c: Update include.
3726         * event-top.c: Update include.
3727         * event-loop.c: Move to ../gdbsupport/.
3728         * event-loop.h: Move to ../gdbsupport/.
3729         * async-event.h: Update include.
3730         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
3731
3732 2020-04-13  Tom Tromey  <tom@tromey.com>
3733
3734         * tui/tui-win.c: Include async-event.h.
3735         * remote.c: Include async-event.h.
3736         * remote-notif.c: Include async-event.h.
3737         * record-full.c: Include async-event.h.
3738         * record-btrace.c: Include async-event.h.
3739         * infrun.c: Include async-event.h.
3740         * event-top.c: Include async-event.h.
3741         * event-loop.h: Move some declarations to async-event.h.
3742         * event-loop.c: Don't include ser-event.h or top.h.  Move some
3743         code to async-event.c.
3744         * async-event.h: New file.
3745         * async-event.c: New file.
3746         * Makefile.in (COMMON_SFILES): Add async-event.c.
3747         (HFILES_NO_SRCDIR): Add async-event.h.
3748
3749 2020-04-13  Tom Tromey  <tom@tromey.com>
3750
3751         * utils.c (flush_streams): New function.
3752         * event-loop.c (gdb_wait_for_event): Call flush_streams.
3753
3754 2020-04-13  Tom Tromey  <tom@tromey.com>
3755
3756         * event-loop.c (handle_file_event): Use warning, not
3757         printf_unfiltered.
3758
3759 2020-04-13  Tom Tromey  <tom@tromey.com>
3760
3761         * event-loop.c: Include <chrono>.
3762
3763 2020-04-13  Tom Tromey  <tom@tromey.com>
3764
3765         * gdb_select.h: Move to ../gdbsupport/.
3766         * event-loop.c: Update include path.
3767         * top.c: Update include path.
3768         * ser-base.c: Update include path.
3769         * ui-file.c: Update include path.
3770         * ser-tcp.c: Update include path.
3771         * guile/scm-ports.c: Update include path.
3772         * posix-hdep.c: Update include path.
3773         * ser-unix.c: Update include path.
3774         * gdb_usleep.c: Update include path.
3775         * mingw-hdep.c: Update include path.
3776         * inflow.c: Update include path.
3777         * infrun.c: Update include path.
3778         * event-top.c: Update include path.
3779
3780 2020-04-13  Tom Tromey  <tom@tromey.com>
3781
3782         * configure: Rebuild.
3783         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
3784
3785 2020-04-13  Tom Tromey  <tom@tromey.com>
3786
3787         * event-loop.h (start_event_loop): Don't declare.
3788         * event-loop.c (start_event_loop): Move...
3789         * main.c (start_event_loop): ...here.  Now static.
3790
3791 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
3792
3793         * MAINTAINERS: Update my email address.
3794
3795 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3796
3797         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
3798         IP_ALL.
3799
3800 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3801
3802         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
3803         (nbsd_nat_target::info_proc): Add do_cmdline.
3804
3805 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3806
3807         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
3808         (nbsd_nat_target::info_proc): Add do_cwd.
3809
3810 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3811
3812         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
3813
3814 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
3815
3816         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
3817         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
3818         (nbsd_nat_target::info_proc): New functions.
3819         * nbsd-nat.c (kinfo_get_vmmap): New function.
3820         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
3821         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
3822         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
3823         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
3824         functions.
3825         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
3826         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
3827         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
3828         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
3829         (KINFO_VME_FLAG_GROWS_DOWN): New.
3830
3831 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
3832
3833         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
3834         bit shift.
3835
3836 2020-04-10  Tom Tromey  <tromey@adacore.com>
3837
3838         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
3839
3840 2020-04-10  Tom Tromey  <tromey@adacore.com>
3841
3842         * symtab.c (get_symbol_address, get_msymbol_address): Skip
3843         separate debug files.
3844
3845 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
3846
3847         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
3848         Move to...
3849         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
3850         ... here.
3851         * windows-nat.c (windows_nat_target::get_windows_debug_event):
3852         Check for STATUS_WX86_BREAKPOINT.
3853         (windows_nat_target::wait): Same.
3854
3855 2020-04-10  Tom de Vries  <tdevries@suse.de>
3856
3857         PR cli/25808
3858         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
3859
3860 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3861
3862         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
3863         (Write After Approval): Remove Tom de Vries.
3864
3865 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3866
3867         revert partially:
3868         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3869
3870         * buildsym.c (record_line): Fix undefined behavior and preserve
3871         lines at eof.
3872
3873 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
3874
3875         * auxv.h (svr4_auxv_parse): New.
3876         * auxv.c (default_auxv_parse): Split into default_auxv_parse
3877         and generic_auxv_parse.
3878         (svr4_auxv_parse): Add.
3879         * obsd-tdep.c: Include "auxv.h".
3880         (obsd_auxv_parse): Remove.
3881         (obsd_init_abi): Remove comment.
3882         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
3883         from `obsd_auxv_parse' to `svr4_auxv_parse'.
3884         * nbsd-tdep.c: Include "auxv.h".
3885         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
3886
3887 2020-04-08  Tom Tromey  <tromey@adacore.com>
3888
3889         * nat/windows-nat.h (last_wait_event): Don't declare.
3890         (wait_for_debug_event): Update comment.
3891         * nat/windows-nat.c (last_wait_event): Now static.
3892
3893 2020-04-08  Tom Tromey  <tromey@adacore.com>
3894
3895         * windows-nat.c (wait_for_debug_event): Move to
3896         nat/windows-nat.c.
3897         * nat/windows-nat.h (wait_for_debug_event): Declare.
3898         * nat/windows-nat.c (wait_for_debug_event): Move from
3899         windows-nat.c.  No longer static.
3900
3901 2020-04-08  Tom Tromey  <tromey@adacore.com>
3902
3903         * windows-nat.c (get_windows_debug_event): Use
3904         fetch_pending_stop.
3905         * nat/windows-nat.h (fetch_pending_stop): Declare.
3906         * nat/windows-nat.c (fetch_pending_stop): New function.
3907
3908 2020-04-08  Tom Tromey  <tromey@adacore.com>
3909
3910         * windows-nat.c (windows_continue): Use matching_pending_stop and
3911         continue_last_debug_event.
3912         * nat/windows-nat.h (matching_pending_stop)
3913         (continue_last_debug_event): Declare.
3914         * nat/windows-nat.c (DEBUG_EVENTS): New define.
3915         (matching_pending_stop, continue_last_debug_event): New
3916         functions.
3917
3918 2020-04-08  Tom Tromey  <tromey@adacore.com>
3919
3920         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
3921         (handle_exception_result): Move to nat/windows-nat.h.
3922         (DEBUG_EXCEPTION_SIMPLE): Remove.
3923         (windows_nat::handle_ms_vc_exception): New function.
3924         (handle_exception): Move to nat/windows-nat.c.
3925         (get_windows_debug_event): Update.
3926         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
3927         nat/windows-nat.c.
3928         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
3929         (handle_exception_result): Move from windows-nat.c.
3930         (handle_exception): Declare.
3931         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
3932         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
3933         windows-nat.c.
3934
3935 2020-04-08  Tom Tromey  <tromey@adacore.com>
3936
3937         * windows-nat.c (exception_count, event_count): Remove.
3938         (handle_exception, get_windows_debug_event)
3939         (do_initial_windows_stuff): Update.
3940
3941 2020-04-08  Tom Tromey  <tromey@adacore.com>
3942
3943         * windows-nat.c (windows_nat::handle_load_dll)
3944         (windows_nat::handle_unload_dll): Rename.  No longer static.
3945         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
3946         Declare.
3947
3948 2020-04-08  Tom Tromey  <tromey@adacore.com>
3949
3950         * complaints.h (stop_whining): Declare at top-level.
3951         (complaint): Don't declare stop_whining.
3952
3953 2020-04-08  Tom Tromey  <tromey@adacore.com>
3954
3955         * windows-nat.c (windows_nat::handle_output_debug_string):
3956         Rename.  No longer static.
3957         * nat/windows-nat.h (handle_output_debug_string): Declare.
3958
3959 2020-04-08  Tom Tromey  <tromey@adacore.com>
3960
3961         * windows-nat.c (current_process_handle, current_process_id)
3962         (main_thread_id, last_sig, current_event, last_wait_event)
3963         (current_windows_thread, desired_stop_thread_id, pending_stops)
3964         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
3965         (display_selectors, fake_create_process)
3966         (get_windows_debug_event): Update.
3967         * nat/windows-nat.h (current_process_handle, current_process_id)
3968         (main_thread_id, last_sig, current_event, last_wait_event)
3969         (current_windows_thread, desired_stop_thread_id, pending_stops)
3970         (struct pending_stop, siginfo_er): Move from windows-nat.c.
3971         * nat/windows-nat.c (current_process_handle, current_process_id)
3972         (main_thread_id, last_sig, current_event, last_wait_event)
3973         (current_windows_thread, desired_stop_thread_id, pending_stops)
3974         (siginfo_er): New globals.  Move from windows-nat.c.
3975
3976 2020-04-08  Tom Tromey  <tromey@adacore.com>
3977
3978         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
3979         (handle_load_dll): Update.
3980         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
3981
3982 2020-04-08  Tom Tromey  <tromey@adacore.com>
3983
3984         * windows-nat.c (enum thread_disposition_type): Move to
3985         nat/windows-nat.h.
3986         (windows_nat::thread_rec): Rename from thread_rec.  No longer
3987         static.
3988         (windows_add_thread, windows_nat_target::fetch_registers)
3989         (windows_nat_target::store_registers, handle_exception)
3990         (windows_nat_target::resume, get_windows_debug_event)
3991         (windows_nat_target::get_tib_address)
3992         (windows_nat_target::thread_name)
3993         (windows_nat_target::thread_alive): Update.
3994         * nat/windows-nat.h (enum thread_disposition_type): Move from
3995         windows-nat.c.
3996         (thread_rec): Declare.
3997
3998 2020-04-08  Tom Tromey  <tromey@adacore.com>
3999
4000         * windows-nat.c: Add "using namespace".
4001         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
4002         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
4003
4004 2020-04-08  Tom Tromey  <tromey@adacore.com>
4005
4006         * nat/windows-nat.h (struct windows_thread_info): Declare
4007         destructor.
4008         * nat/windows-nat.c (~windows_thread_info): New.
4009
4010 2020-04-08  Tom Tromey  <tromey@adacore.com>
4011
4012         PR gdb/22992
4013         * windows-nat.c (current_event): Update comment.
4014         (last_wait_event, desired_stop_thread_id): New globals.
4015         (struct pending_stop): New.
4016         (pending_stops): New global.
4017         (windows_nat_target) <stopped_by_sw_breakpoint>
4018         <supports_stopped_by_sw_breakpoint>: New methods.
4019         (windows_fetch_one_register): Add assertions.  Adjust PC.
4020         (windows_continue): Handle pending stops.  Suspend other threads
4021         when stepping.  Use last_wait_event
4022         (wait_for_debug_event): New function.
4023         (get_windows_debug_event): Use wait_for_debug_event.  Handle
4024         pending stops.  Queue spurious stops.
4025         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
4026         (windows_nat_target::kill): Use wait_for_debug_event.
4027         * nat/windows-nat.h (struct windows_thread_info)
4028         <stopped_at_software_breakpoint>: New field.
4029         * nat/windows-nat.c (windows_thread_info::resume): Clear
4030         stopped_at_software_breakpoint.
4031
4032 2020-04-08  Tom Tromey  <tromey@adacore.com>
4033
4034         * windows-nat.c (enum thread_disposition_type): New.
4035         (thread_rec): Replace "get_context" parameter with "disposition";
4036         change type.
4037         (windows_add_thread, windows_nat_target::fetch_registers)
4038         (windows_nat_target::store_registers, handle_exception)
4039         (windows_nat_target::resume, get_windows_debug_event)
4040         (windows_nat_target::get_tib_address)
4041         (windows_nat_target::thread_name)
4042         (windows_nat_target::thread_alive): Update.
4043
4044 2020-04-08  Tom Tromey  <tromey@adacore.com>
4045
4046         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
4047         (windows_continue): Use windows_continue::resume.
4048         * nat/windows-nat.h (struct windows_thread_info) <suspend,
4049         resume>: Declare new methods.
4050         * nat/windows-nat.c: New file.
4051         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
4052
4053 2020-04-08  Tom Tromey  <tromey@adacore.com>
4054
4055         * windows-nat.c (windows_add_thread, windows_delete_thread)
4056         (windows_nat_target::fetch_registers)
4057         (windows_nat_target::store_registers, fake_create_process)
4058         (windows_nat_target::resume, windows_nat_target::resume)
4059         (get_windows_debug_event, windows_nat_target::wait)
4060         (windows_nat_target::pid_to_str)
4061         (windows_nat_target::get_tib_address)
4062         (windows_nat_target::get_ada_task_ptid)
4063         (windows_nat_target::thread_name)
4064         (windows_nat_target::thread_alive): Use lwp, not tid.
4065
4066 2020-04-08  Tom Tromey  <tromey@adacore.com>
4067
4068         * windows-nat.c (handle_exception)
4069         (windows_nat_target::thread_name): Update.
4070         * nat/windows-nat.h (windows_thread_info): Remove destructor.
4071         <name>: Now unique_xmalloc_ptr.
4072
4073 2020-04-08  Tom Tromey  <tromey@adacore.com>
4074
4075         * windows-nat.c (thread_rec)
4076         (windows_nat_target::fetch_registers): Update.
4077         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
4078         Update comment.
4079         <debug_registers_changed, reload_context>: Now bool.
4080
4081 2020-04-08  Tom Tromey  <tromey@adacore.com>
4082
4083         * windows-nat.c (windows_add_thread): Use new.
4084         (windows_init_thread_list, windows_delete_thread): Use delete.
4085         (get_windows_debug_event): Update.
4086         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
4087         destructor, and initializers.
4088
4089 2020-04-08  Tom Tromey  <tromey@adacore.com>
4090
4091         * windows-nat.c (struct windows_thread_info): Remove.
4092         * nat/windows-nat.h: New file.
4093
4094 2020-04-08  Tom Tromey  <tromey@adacore.com>
4095
4096         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
4097         (thread_rec, windows_add_thread, windows_delete_thread)
4098         (windows_continue): Update.
4099
4100 2020-04-08  Tom Tromey  <tromey@adacore.com>
4101
4102         * windows-nat.c (struct windows_thread_info): Remove typedef.
4103         (thread_head): Remove.
4104         (thread_list): New global.
4105         (thread_rec, windows_add_thread, windows_init_thread_list)
4106         (windows_delete_thread, windows_continue): Update.
4107
4108 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
4109
4110         * windows-tdep.h (windows_init_abi): Add comment.
4111         (cygwin_init_abi): New declaration.
4112         * windows-tdep.c: Split signal enumeration in two, one for
4113         Windows and one for Cygwin.
4114         (windows_gdb_signal_to_target): Only deal with signal of the
4115         Windows OS ABI.
4116         (cygwin_gdb_signal_to_target): New function.
4117         (windows_init_abi): Rename to windows_init_abi_common, don't set
4118         gdb_signal_to_target gdbarch method.  Add new new function with
4119         this name.
4120         (cygwin_init_abi): New function.
4121         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
4122         comment.  Don't call windows_init_abi.
4123         (amd64_windows_init_abi): Add comment, call windows_init_abi.
4124         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
4125         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
4126         i386_windows_init_abi_common, don't call windows_init_abi.  Add
4127         a new function of this name.
4128         (i386_cygwin_init_abi): New function.
4129         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
4130         OS ABI Cygwin.
4131
4132 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
4133
4134         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
4135         parameter.c.
4136         (dwarf2_read_gdb_index): Update.
4137
4138 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
4139
4140         * nbsd-tdep.c: Include "objfiles.h".
4141         (nbsd_skip_solib_resolver): New.
4142         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
4143
4144 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4145
4146         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
4147         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
4148         with DW_LLE_base_addressx are being emitted in DWARFv5.
4149         Add the newly added kind DW_LOC_OFFSET_PAIR also.
4150         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
4151         unsigned integer.
4152
4153 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4154
4155         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
4156         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
4157         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
4158         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
4159         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
4160         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
4161         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
4162
4163
4164 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4165
4166         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
4167         (read_loclist_index): New function definition.
4168         (lookup_loclist_base): New function definition.
4169         (read_loclist_header): New function definition.
4170         (dwarf2_cu): Add loclist_base and loclist_header field.
4171         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
4172         (read_full_die_1): Read the value of DW_AT_loclists_base.
4173         (read_attribute_reprocess): Handle DW_FORM_loclistx.
4174         (read_attribute_value): Handle DW_FORM_loclistx.
4175         (skip_one_die): Handle DW_FORM_loclistx.
4176         (loclist_header): New structure declaration.
4177         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
4178
4179 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4180
4181         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
4182         constructor.  Remove `addr` parameter from other constructor and
4183         add `per_cu` parameter.
4184         * dwarf2/read.c (create_partial_symtab): Update.
4185
4186 2020-04-07  Tom de Vries  <tdevries@suse.de>
4187
4188         PR symtab/25796
4189         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
4190         (partial_die_info::fixup): Inherit has_const_value.
4191
4192 2020-04-07  Tom de Vries  <tdevries@suse.de>
4193
4194         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
4195         symbols without address.
4196
4197 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
4198
4199         * nbsd-nat.h (struct thread_info): Add forward declaration.
4200         (nbsd_nat_target::thread_alive): Add.
4201         (nbsd_nat_target::thread_name): Likewise.
4202         (nbsd_nat_target::update_thread_list): Likewise.
4203         (update_thread_list::post_attach): Likewise.
4204         (post_attach::pid_to_str): Likewise.
4205         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
4206         (nbsd_thread_lister): Add.
4207         (nbsd_nat_target::thread_alive): Likewise.
4208         (nbsd_nat_target::thread_name): Likewise.
4209         (nbsd_add_threads): Likewise.
4210         (update_thread_list::post_attach): Likewise.
4211         (nbsd_nat_target::update_thread_list): Likewise.
4212         (post_attach::pid_to_str): Likewise.
4213
4214 2020-04-06  Tom Tromey  <tromey@adacore.com>
4215
4216         * ada-valprint.c (print_variant_part): Extract the variant field.
4217         (print_field_values): Use the field as the outer value when
4218         recursing.
4219
4220 2020-04-06  Tom Tromey  <tromey@adacore.com>
4221
4222         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
4223         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
4224         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
4225         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
4226         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
4227
4228 2020-04-06  Tom Tromey  <tromey@adacore.com>
4229
4230         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
4231         TYPE_CODE_ERROR.
4232
4233 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
4234
4235         * nbsd-tdep.c: Include "gdbarch.h".
4236         Define enum with NetBSD signal numbers.
4237         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
4238         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
4239         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
4240         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
4241         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
4242         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
4243         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
4244         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
4245         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
4246         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
4247         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
4248         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
4249
4250 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
4251
4252         PR gdb/25325
4253         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
4254
4255 2020-04-03  Tom Tromey  <tromey@adacore.com>
4256
4257         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
4258         Read constant block.
4259
4260 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
4261
4262         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
4263         (gdb_bfd_get_full_section_contents): New declaration.
4264         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
4265         * windows-tdep.c (is_linked_with_cygwin_dll): Use
4266         gdb_bfd_get_full_section_contents.
4267
4268 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
4269
4270         * exec.c (build_section_table): Replace internal_error with
4271         gdb_assert.
4272         (section_table_xfer_memory_partial): Likewise.
4273         * mdebugread.c (parse_partial_symbols): Likewise.
4274         * psymtab.c (lookup_partial_symbol): Likewise.
4275         * utils.c (wrap_here): Likewise.
4276
4277 2020-04-02  Tom Tromey  <tromey@adacore.com>
4278
4279         * f-lang.c (build_fortran_types): Use arch_type to initialize
4280         builtin_complex_s32 in the TYPE_CODE_ERROR case.
4281
4282 2020-04-02  Tom Tromey  <tromey@adacore.com>
4283
4284         * dwarf2/read.c (partial_die_info::read): Do not create a vector
4285         of attributes.
4286
4287 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4288             Bernd Edlinger <bernd.edlinger@hotmail.de>
4289             Tom Tromey  <tromey@adacore.com>
4290
4291         * buildsym.c (buildsym_compunit::record_line): Remove
4292         deduplication code.
4293
4294 2020-04-02  Tom de Vries  <tdevries@suse.de>
4295
4296         PR ada/24671
4297         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
4298
4299 2020-04-02  Tom de Vries  <tdevries@suse.de>
4300
4301         * dwarf2/read.c (dwarf2_gdb_index_functions,
4302         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
4303         NULL.
4304         * psymtab.c (psym_lookup_global_symbol_language): New function.
4305         (psym_functions): Init psym_lookup_global_symbol_language with
4306         psym_lookup_global_symbol_language.
4307         * symfile-debug.c (debug_sym_quick_functions): Init
4308         lookup_global_symbol_language with NULL.
4309         * symfile.c (set_initial_language): Remove fixme comment.
4310         * symfile.h (struct quick_symbol_functions): Add
4311         lookup_global_symbol_language.
4312         * symtab.c (find_quick_global_symbol_language): New function.
4313         (find_main_name): Use find_quick_global_symbol_language.
4314
4315 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4316
4317         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
4318
4319 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4320
4321         * buildsym.c (record_line): Fix undefined behavior and preserve
4322         lines at eof.
4323
4324 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4325
4326         * buildsym.c (record_line): Fix the resizing condition.
4327
4328 2020-04-01  Tom Tromey  <tom@tromey.com>
4329
4330         * value.h (value_literal_complex): Add comment.
4331         * valops.c (value_literal_complex): Refer to value.h.
4332
4333 2020-04-01  Tom Tromey  <tom@tromey.com>
4334
4335         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
4336         (scalar_type): New rule, from typebase.
4337         (typebase): Use scalar_type.  Recognize complex types.
4338         (field_name): Handle FLOAT_KEYWORD.
4339         (ident_tokens): Add _Complex and __complex__.
4340
4341 2020-04-01  Tom Tromey  <tom@tromey.com>
4342
4343         PR exp/25299:
4344         * valarith.c (promotion_type, complex_binop): New functions.
4345         (scalar_binop): Handle complex numbers.  Use promotion_type.
4346         (value_pos, value_neg, value_complement): Handle complex numbers.
4347
4348 2020-04-01  Tom Tromey  <tom@tromey.com>
4349
4350         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
4351         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
4352         (parse_number): Handle complex numbers.
4353
4354 2020-04-01  Tom Tromey  <tom@tromey.com>
4355
4356         * c-valprint.c (c_decorations): Change complex suffix to "i".
4357
4358 2020-04-01  Tom Tromey  <tom@tromey.com>
4359
4360         * valprint.c (generic_value_print_complex): Use accessors.
4361         * value.h (value_real_part, value_imaginary_part): Declare.
4362         * valops.c (value_real_part, value_imaginary_part): New
4363         functions.
4364         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
4365
4366 2020-04-01  Tom Tromey  <tom@tromey.com>
4367
4368         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
4369         (read_range_type): Update.
4370         * mdebugread.c (basic_type): Update.
4371         * go-lang.c (build_go_types): Use init_complex_type.
4372         * gdbtypes.h (struct main_type) <complex_type>: New member.
4373         (init_complex_type): Update.
4374         (arch_complex_type): Don't declare.
4375         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
4376         Make name if none given.  Use alloc_type_copy.  Look for cached
4377         complex type.
4378         (arch_complex_type): Remove.
4379         (gdbtypes_post_init): Use init_complex_type.
4380         * f-lang.c (build_fortran_types): Use init_complex_type.
4381         * dwarf2/read.c (read_base_type): Update.
4382         * d-lang.c (build_d_types): Use init_complex_type.
4383         * ctfread.c (read_base_type): Update.
4384
4385 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4386
4387         * infrun.c (stop_all_threads): Update assertion, plus when
4388         stopping threads, take into account that we might be trying
4389         to stop an all-stop target.
4390         (stop_waiting): Call 'stop_all_threads' if there exists a
4391         non-stop target.
4392
4393 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4394
4395         * target.h (exists_non_stop_target): New function declaration.
4396         * target.c (exists_non_stop_target): New function.
4397
4398 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
4399
4400         PR gdb/24789
4401         * eval.c (is_integral_or_integral_reference): New function.
4402         (evaluate_subexp_standard): Allow integer references in
4403         pointer arithmetic.
4404
4405 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4406
4407         * remote.c (remote_target::remote_parse_stop_reply): Remove the
4408         check for no ptid in the stop reply when the target is non-stop.
4409
4410 2020-04-01  Tom Tromey  <tromey@adacore.com>
4411
4412         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
4413         "name" parameter to rvalue reference.  Initialize m_name_holder.
4414         <lookup_name_info>: New overloads.
4415         <name>: Return gdb::string_view.
4416         <c_str>: New method.
4417         <make_ignore_params>: Update.
4418         <search_name_hash>: Update.
4419         <language_lookup_name>: Return const char *.
4420         <m_name>: Change type.
4421         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
4422         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
4423         (lookup_name_info::match_any): Update.
4424         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
4425         Update.
4426         * minsyms.c (linkage_name_str): Update.
4427         * language.c (default_symbol_name_matcher): Update.
4428         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
4429         Update.
4430         * ada-lang.c (ada_fold_name): Change parameter to string_view.
4431         (ada_lookup_name_info::ada_lookup_name_info): Update.
4432         (literal_symbol_name_matcher): Update.
4433
4434 2020-04-01  Tom Tromey  <tromey@adacore.com>
4435
4436         * psymtab.c (psymtab_search_name): Remove function.
4437         (psym_lookup_symbol): Create search name and lookup name here.
4438         (lookup_partial_symbol): Remove "name" parameter; add
4439         lookup_name.
4440         (psym_expand_symtabs_for_function): Update.
4441
4442 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
4443
4444         PR tui/25597:
4445         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
4446
4447 2020-03-31  Tom Tromey  <tromey@adacore.com>
4448
4449         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
4450         memcpy.
4451
4452 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
4453
4454         * features/riscv/32bit-csr.xml: Regenerated.
4455         * features/riscv/64bit-csr.xml: Regenerated.
4456
4457 2020-03-30  Tom Tromey  <tromey@adacore.com>
4458
4459         * ada-valprint.c (print_variant_part): Update.
4460         * ada-lang.h (ada_which_variant_applies): Update.
4461         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
4462         outer_valaddr parameters; replace with "outer" value parameter.
4463         (to_fixed_variant_branch_type): Update.
4464
4465 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4466
4467         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
4468         <list>.  Remove inclusion of observable.h.
4469         (PPC_DEBUG_CURRENT_VERSION): Move up define.
4470         (struct arch_lwp_info): New struct.
4471         (class ppc_linux_dreg_interface): New class.
4472         (struct ppc_linux_process_info): New struct.
4473         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
4474         <low_new_clone, low_forget_process, low_prepare_to_resume>
4475         <copy_thread_dreg_state, mark_thread_stale>
4476         <mark_debug_registers_changed, register_hw_breakpoint>
4477         <clear_hw_breakpoint, register_wp, clear_wp>
4478         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
4479         <num_memory_accesses, get_trigger_type>
4480         <create_watchpoint_request, hwdebug_point_cmp>
4481         <init_arch_lwp_info, get_arch_lwp_info>
4482         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
4483         methods.
4484         <struct ptid_hash>: New inner struct.
4485         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
4486         members.
4487         (saved_dabr_value, hwdebug_info, max_slots_number)
4488         (struct hw_break_tuple, struct thread_points, ppc_threads)
4489         (have_ptrace_hwdebug_interface)
4490         (hwdebug_find_thread_points_by_tid)
4491         (hwdebug_insert_point, hwdebug_remove_point): Remove.
4492         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
4493         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
4494         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
4495         use m_dreg_interface.
4496         (hwdebug_point_cmp): Change to...
4497         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
4498         reference arguments instead of pointers.
4499         (ppc_linux_nat_target::ranged_break_num_registers): Use
4500         m_dreg_interface.
4501         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
4502         m_dreg_interface.  Call register_hw_breakpoint.
4503         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
4504         m_dreg_interface.  Call clear_hw_breakpoint.
4505         (get_trigger_type): Change to...
4506         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
4507         comment.
4508         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
4509         use m_dreg_interface.  Call register_hw_breakpoint.
4510         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
4511         use m_dreg_interface.  Call clear_hw_breakpoint.
4512         (can_use_watchpoint_cond_accel): Change to...
4513         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
4514         method.  Update comment, use m_dreg_interface and
4515         m_process_info.
4516         (calculate_dvc): Change to...
4517         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
4518         m_dreg_interface.
4519         (num_memory_accesses): Change to...
4520         (ppc_linux_nat_target::num_memory_accesses): ...this method.
4521         (check_condition): Change to...
4522         (ppc_linux_nat_target::check_condition): ...this method.
4523         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
4524         comment, use m_dreg_interface.
4525         (create_watchpoint_request): Change to...
4526         (ppc_linux_nat_target::create_watchpoint_request): ...this
4527         method.  Use m_dreg_interface.
4528         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
4529         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
4530         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
4531         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
4532         (ppc_linux_nat_target::low_forget_process)
4533         (ppc_linux_nat_target::low_new_fork)
4534         (ppc_linux_nat_target::low_new_clone)
4535         (ppc_linux_nat_target::low_delete_thread)
4536         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
4537         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
4538         only call mark_thread_stale.
4539         (ppc_linux_thread_exit): Remove.
4540         (ppc_linux_nat_target::stopped_data_address): Change to...
4541         (ppc_linux_nat_target::low_stopped_data_address): This. Add
4542         comment, use m_dreg_interface and m_thread_hw_breakpoints.
4543         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
4544         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
4545         comment.  Call low_stopped_data_address.
4546         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
4547         m_dreg_interface.
4548         (ppc_linux_nat_target::masked_watch_num_registers): Use
4549         m_dreg_interface.
4550         (ppc_linux_nat_target::copy_thread_dreg_state)
4551         (ppc_linux_nat_target::mark_thread_stale)
4552         (ppc_linux_nat_target::mark_debug_registers_changed)
4553         (ppc_linux_nat_target::register_hw_breakpoint)
4554         (ppc_linux_nat_target::clear_hw_breakpoint)
4555         (ppc_linux_nat_target::register_wp)
4556         (ppc_linux_nat_target::clear_wp)
4557         (ppc_linux_nat_target::init_arch_lwp_info)
4558         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
4559         (_initialize_ppc_linux_nat): Remove observer callback.
4560
4561 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4562
4563         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
4564         (ppc_linux_nat_target::auxv_parse)
4565         (ppc_linux_nat_target::read_description)
4566         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
4567         Move up.
4568
4569 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4570
4571         * linux-nat.h (low_new_clone): New method.
4572         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
4573
4574 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
4575
4576         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
4577         (dbx_expand_psymtab): ... this.
4578         (start_psymtab): Update.
4579         * mdebugread.c (psymtab_to_symtab_1): Rename to...
4580         (mdebug_expand_psymtab): ... this.
4581         (parse_partial_symbols): Update.
4582         (new_psymtab): Update.
4583         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
4584         (xcoff_expand_psymtab): ... this.
4585         (xcoff_start_psymtab): Update.
4586
4587 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
4588
4589         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
4590         <expand_dependencies>: ... this.
4591         * psymtab.c (partial_symtab::read_dependencies): Rename to...
4592         (partial_symtab::expand_dependencies): ... this.
4593         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
4594         Update.
4595         (dwarf2_psymtab::expand_psymtab): Update.
4596         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
4597         * mdebugread.c (psymtab_to_symtab_1): Update.
4598         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
4599
4600 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
4601
4602         * psympriv.h (discard_psymtab): Remove.
4603         * dbxread.c (dbx_end_psymtab): Update.
4604         * xcoffread.c (xcoff_end_psymtab): Update.
4605
4606 2020-03-28  Tom Tromey  <tom@tromey.com>
4607
4608         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
4609         comment.
4610
4611 2020-03-28  Tom Tromey  <tom@tromey.com>
4612
4613         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
4614
4615 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
4616
4617         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
4618
4619 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
4620
4621         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
4622
4623 2020-03-26  Tom Tromey  <tom@tromey.com>
4624
4625         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
4626         (mark_common_block_symbol_computed, read_tag_string_type)
4627         (attr_to_dynamic_prop, read_subrange_type): Update.
4628         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
4629         to be methods on struct attribute.
4630         (skip_one_die, process_imported_unit_die, read_namespace_alias)
4631         (read_call_site_scope, partial_die_info::read)
4632         (partial_die_info::read, lookup_die_type, follow_die_ref):
4633         Update.
4634         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
4635         from dwarf2_get_ref_die_offset.
4636         (attribute::constant_value): New method, from
4637         dwarf2_get_attr_constant_value.
4638         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
4639         Declare method.
4640         <constant_value>: New method.
4641
4642 2020-03-26  Tom Tromey  <tom@tromey.com>
4643
4644         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
4645         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
4646         (dwarf_type_encoding_name): Move to stringify.c.
4647         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
4648         * dwarf2/stringify.c: New file.
4649         * dwarf2/stringify.h: New file.
4650
4651 2020-03-26  Tom Tromey  <tom@tromey.com>
4652
4653         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
4654         Rewrite.
4655
4656 2020-03-26  Tom Tromey  <tom@tromey.com>
4657
4658         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
4659         methods.
4660         * dwarf2/read.c (lookup_addr_base): Move to die.h.
4661         (lookup_ranges_base): Likewise.
4662         (read_cutu_die_from_dwo, read_full_die_1): Update.
4663
4664 2020-03-26  Tom Tromey  <tom@tromey.com>
4665
4666         * dwarf2/read.c (read_import_statement, read_file_scope)
4667         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
4668         (read_lexical_block_scope, read_call_site_scope)
4669         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
4670         (handle_struct_member_die, process_structure_scope)
4671         (update_enumeration_type_from_children)
4672         (process_enumeration_scope, read_array_type, read_common_block)
4673         (read_namespace, read_module, read_subroutine_type): Update.
4674         (sibling_die): Remove.
4675
4676 2020-03-26  Tom Tromey  <tom@tromey.com>
4677
4678         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
4679         (build_type_psymtabs_reader, read_structure_type)
4680         (read_enumeration_type, read_full_die_1): Update.
4681         (dwarf2_attr_no_follow): Move to die.h.
4682         * dwarf2/die.h (struct die_info) <attr>: New method.
4683
4684 2020-03-26  Tom Tromey  <tom@tromey.com>
4685
4686         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
4687         <base_address>: Now an optional.
4688         (dwarf2_find_base_address, dwarf2_rnglists_process)
4689         (dwarf2_ranges_process, fill_in_loclist_baton)
4690         (dwarf2_symbol_mark_computed): Update.
4691
4692 2020-03-26  Tom Tromey  <tom@tromey.com>
4693
4694         * dwarf2/read.c (struct die_info): Move to die.h.
4695         * dwarf2/die.h: New file.
4696
4697 2020-03-26  Tom Tromey  <tom@tromey.com>
4698
4699         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
4700         * dwarf2/read.c
4701         (dwarf2_statement_list_fits_in_line_number_section_complaint):
4702         Move to line-header.c.
4703         (read_checked_initial_length_and_offset, read_formatted_entries):
4704         Likewise.
4705         (dwarf_decode_line_header): Split into two.
4706         * dwarf2/line-header.c
4707         (dwarf2_statement_list_fits_in_line_number_section_complaint):
4708         Move from read.c.
4709         (read_checked_initial_length_and_offset, read_formatted_entries):
4710         Likewise.
4711         (dwarf_decode_line_header): New function, split from read.c.
4712
4713 2020-03-26  Tom Tromey  <tom@tromey.com>
4714
4715         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
4716         Declare method.
4717         * dwarf2/read.c (read_attribute_value): Update.
4718         (dwarf2_per_objfile::read_line_string): Rename from
4719         read_indirect_line_string.
4720         (read_formatted_entries): Update.
4721
4722 2020-03-26  Tom Tromey  <tom@tromey.com>
4723
4724         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
4725         variable.
4726
4727 2020-03-26  Tom Tromey  <tom@tromey.com>
4728
4729         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
4730         const.
4731         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
4732         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
4733         parameter const.
4734
4735 2020-03-26  Tom Tromey  <tom@tromey.com>
4736
4737         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
4738         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
4739         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
4740         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
4741
4742 2020-03-26  Tom Tromey  <tom@tromey.com>
4743
4744         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
4745         file_names_size, file_full_name, file_file_name>: Use const.
4746         <file_name_at, file_names>: Add const overload.
4747         * dwarf2/line-header.c (line_header::file_file_name)
4748         (line_header::file_full_name): Update.
4749
4750 2020-03-26  Tom Tromey  <tom@tromey.com>
4751
4752         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
4753         (macro_start_file, consume_improper_spaces)
4754         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
4755         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
4756         (dwarf_decode_macros): Move to macro.c.
4757         * dwarf2/macro.c: New file.
4758         * dwarf2/macro.h: New file.
4759         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
4760
4761 2020-03-26  Tom Tromey  <tom@tromey.com>
4762
4763         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
4764         method.
4765         * dwarf2/section.c: New method.  From
4766         read_indirect_string_at_offset_from.
4767         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
4768         (read_indirect_string_at_offset_from): Move to section.c.
4769         (read_indirect_string_at_offset): Rewrite.
4770         (read_indirect_line_string_at_offset): Remove.
4771         (read_indirect_string, read_indirect_line_string)
4772         (dwarf_decode_macro_bytes): Update.
4773
4774 2020-03-26  Tom Tromey  <tom@tromey.com>
4775
4776         * dwarf2/section.h (struct dwarf2_section_info)
4777         <overload_complaint>: Declare.
4778         (dwarf2_section_buffer_overflow_complaint): Don't declare.
4779         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
4780         Rename from dwarf2_section_buffer_overflow_complaint.
4781         * dwarf2/read.c (skip_one_die, partial_die_info::read)
4782         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
4783
4784 2020-03-26  Tom Tromey  <tom@tromey.com>
4785
4786         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
4787         Declare.
4788         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
4789         Move from read.c.
4790         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
4791         to section.c.
4792
4793 2020-03-26  Tom Tromey  <tom@tromey.com>
4794
4795         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
4796
4797 2020-03-26  Tom Tromey  <tom@tromey.com>
4798
4799         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
4800         "builder".
4801         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
4802         parameter.
4803         (dwarf_decode_macros): Update.
4804
4805 2020-03-26  Tom Tromey  <tom@tromey.com>
4806
4807         * dwarf2/read.c (read_attribute_value): Update.
4808         (read_indirect_string_from_dwz): Move to dwz.c; change into
4809         method.
4810         (dwarf_decode_macro_bytes): Update.
4811         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
4812         * dwarf2/dwz.c: New file.
4813         * Makefile.in (COMMON_SFILES): Add dwz.c.
4814
4815 2020-03-26  Tom Tromey  <tom@tromey.com>
4816
4817         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
4818         * dwarf2/read.c: Add include.
4819         * dwarf2/index-write.c: Add include.
4820         * dwarf2/index-cache.c: Add include.
4821         * dwarf2/dwz.h: New file.
4822
4823 2020-03-25  Tom Tromey  <tom@tromey.com>
4824
4825         * compile/compile-object-load.c (get_out_value_type): Mention
4826         correct symbol name in error message.
4827
4828 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
4829
4830         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
4831
4832 2020-03-25  Tom de Vries  <tdevries@suse.de>
4833
4834         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
4835         * symmisc.c (dump_symtab_1): Print user and includes fields.
4836         (maintenance_info_symtabs): Same.
4837
4838 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
4839
4840         PR gdb/25534
4841         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
4842         (riscv_regcache_cooked_write): New function.
4843         (riscv_push_dummy_call): Use new function.
4844         (riscv_return_value): Likewise.
4845
4846 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
4847
4848         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
4849         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
4850         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
4851         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
4852         * infrun.c (follow_fork): Likewise.
4853         (follow_fork_inferior): Likewise.
4854         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
4855         * linux-nat.h (class linux_nat_target): Likewise.
4856         * remote.c (class remote_target) <follow_fork>: Likewise.
4857         (remote_target::follow_fork): Likewise.
4858         * target-delegates.c: Re-generate.
4859         * target.c (default_follow_fork): Likewise.
4860         (target_follow_fork): Likewise.
4861         * target.h (struct target_ops) <follow_fork>: Likewise.
4862         (target_follow_fork): Likewise.
4863
4864 2020-03-24  Tom de Vries  <tdevries@suse.de>
4865
4866         * psymtab.c (maintenance_info_psymtabs): Print user field.
4867
4868 2020-03-20  Tom Tromey  <tromey@adacore.com>
4869
4870         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
4871         const.
4872         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
4873         const.
4874
4875 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
4876
4877         * ptrace.m4: Don't check for ptrace declaration.
4878         * config.in: Re-generate.
4879         * configure: Re-generate.
4880         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
4881         not defined.
4882
4883 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
4884
4885         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
4886         `PTRACE_TYPE_RET'.
4887         * i386-bsd-nat.c (gdb_ptrace): Likewise.
4888         * sparc-nat.c (gdb_ptrace): Likewise.
4889         * x86-bsd-nat.c (gdb_ptrace): Likewise.
4890
4891 2020-03-20  Tom Tromey  <tromey@adacore.com>
4892
4893         * c-exp.y (lex_one_token): Fix assert.
4894
4895 2020-03-20  Tom Tromey  <tromey@adacore.com>
4896
4897         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
4898         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
4899         strncpy call.
4900
4901 2020-03-20  Tom Tromey  <tromey@adacore.com>
4902
4903         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
4904
4905 2020-03-20  Tom Tromey  <tromey@adacore.com>
4906
4907         * ada-valprint.c (print_variant_part): Remove parameters; switch
4908         to value-based API.
4909         (print_field_values): Likewise.
4910         (ada_val_print_struct_union): Likewise.
4911         (ada_value_print_1): Update.
4912
4913 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
4914
4915         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
4916         nbsd_nat_target instead of inf_ptrace_target.
4917         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
4918         nbsd_nat_target.
4919
4920 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
4921
4922         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
4923         it to the ptrace call.
4924         * (store_registers): Likewise.
4925
4926 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
4927
4928         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
4929         it to the ptrace call.
4930         * (store_registers): Likewise.
4931
4932 2020-03-19  Luis Machado  <luis.machado@linaro.org>
4933
4934         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
4935         valid, fetch vg value from ptrace.
4936
4937 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
4938         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
4939         * inf-ptrace.c: Likewise.
4940         * (gdb_ptrace): Add.
4941         * (inf_ptrace_target::resume): Update.
4942         * (inf_ptrace_target::xfer_partial): Likewise.
4943         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
4944         * (inf_ptrace_peek_poke): Update.
4945
4946 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
4947
4948         * x86-bsd-nat.c (gdb_ptrace): New.
4949         * (x86bsd_dr_set): Add new argument `ptid'.
4950         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
4951         x86bsd_dr_set_addr): Update.
4952
4953 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4954
4955         * remote.c (remote_target::process_stop_reply): Handle events for
4956         all threads differently.
4957
4958 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4959
4960         * completer.c (completion_tracker::remove_completion): Define new
4961         function.
4962         * completer.h (completion_tracker::remove_completion): Declare new
4963         function.
4964         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
4965         when adding a C++ function symbol.
4966
4967 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4968
4969         * completer.c (completion_tracker::completion_hash_entry): Define
4970         new class.
4971         (advance_to_filename_complete_word_point): Call
4972         recompute_lowest_common_denominator.
4973         (completion_tracker::completion_tracker): Call discard_completions
4974         to setup the hash table.
4975         (completion_tracker::discard_completions): Allow for being called
4976         from the constructor, pass new equal function, and element deleter
4977         when constructing the hash table.  Initialise new class member
4978         variables.
4979         (completion_tracker::maybe_add_completion): Remove use of
4980         m_entries_vec, and store more information into m_entries_hash.
4981         (completion_tracker::recompute_lcd_visitor): New function, most
4982         content taken from...
4983         (completion_tracker::recompute_lowest_common_denominator):
4984         ...here, this now just visits each item in the hash calling the
4985         above visitor.
4986         (completion_tracker::build_completion_result): Remove use of
4987         m_entries_vec, call recompute_lowest_common_denominator.
4988         * completer.h (completion_tracker::have_completions): Remove use
4989         of m_entries_vec.
4990         (completion_tracker::completion_hash_entry): Declare new class.
4991         (completion_tracker::recompute_lowest_common_denominator): Change
4992         function signature.
4993         (completion_tracker::recompute_lcd_visitor): Declare new function.
4994         (completion_tracker::m_entries_vec): Delete.
4995         (completion_tracker::m_entries_hash): Initialize to NULL.
4996         (completion_tracker::m_lowest_common_denominator_valid): New
4997         member variable.
4998         (completion_tracker::m_lowest_common_denominator_max_length): New
4999         member variable.
5000
5001 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5002
5003         * regformats/regdef.h: Put reg in gdb namespace.
5004
5005 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5006
5007         * i386-bsd-nat.c (gdb_ptrace): New.
5008         * (i386bsd_fetch_inferior_registers,
5009         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5010         * (i386bsd_fetch_inferior_registers,
5011         i386bsd_store_inferior_registers) Use gdb_ptrace.
5012
5013 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5014
5015         * amd64-bsd-nat.c (gdb_ptrace): New.
5016         * (amd64bsd_fetch_inferior_registers,
5017         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5018         * (amd64bsd_fetch_inferior_registers,
5019         amd64bsd_store_inferior_registers) Use gdb_ptrace.
5020
5021 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5022
5023         * user-regs.c (user_reg::read): Rename to...
5024         (user_reg::xread): ...this.
5025         * (append_user_reg): Rename argument `read' to `xread'.
5026         * (user_reg_add_builtin): Likewise.
5027         * (user_reg_add): Likewise.
5028         * (value_of_user_reg): Likewise.
5029
5030 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5031
5032         * sparc-nat.c (gdb_ptrace): New.
5033         * sparc-nat.c (sparc_fetch_inferior_registers)
5034         (sparc_store_inferior_registers) Remove obsolete comment.
5035         * sparc-nat.c (sparc_fetch_inferior_registers)
5036         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
5037         * sparc-nat.c (sparc_fetch_inferior_registers)
5038         (sparc_store_inferior_registers) Use gdb_ptrace.
5039
5040 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5041
5042         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
5043         it to the ptrace call.
5044         * sh-nbsd-nat.c (store_registers): Likewise.
5045
5046 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5047
5048         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
5049         nbsd_nat_target instead of inf_ptrace_target.
5050         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5051         nbsd_nat_target.
5052
5053 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5054
5055         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
5056
5057 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5058
5059         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
5060         <sys/sysctl.h>.
5061         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
5062
5063 2020-03-17  Tom de Vries  <tdevries@suse.de>
5064
5065         PR gdb/23710
5066         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
5067         fields.
5068         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
5069         fields.
5070         (process_imported_unit_die): Skip import of c++ CUs.
5071
5072 2020-03-16  Tom Tromey  <tom@tromey.com>
5073
5074         * p-valprint.c (pascal_object_print_value): Initialize
5075         base_value.
5076
5077 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
5078             Shahab Vahedi  <shahab@synopsys.com>
5079
5080         * Makefile.in: Add arch/arc.o
5081         * configure.tgt: Likewise.
5082         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
5083         (_initialize_arc_tdep): Don't initialize old target descriptions.
5084         (arc_read_description): New function to cache target descriptions.
5085         * arc-tdep.h (arc_read_description): Add proto type.
5086         * arch/arc.c: New file.
5087         * arch/arc.h: Likewise.
5088         * features/Makefile: Replace old target descriptions with new.
5089         * features/arc-arcompact.c: Remove.
5090         * features/arc-arcompact.xml: Likewise.
5091         * features/arc-v2.c: Likewise
5092         * features/arc-v2.xml: Likewise
5093         * features/arc/aux-arcompact.xml: New file.
5094         * features/arc/aux-v2.xml: Likewise.
5095         * features/arc/core-arcompact.xml: Likewise.
5096         * features/arc/core-v2.xml: Likewise.
5097         * features/arc/aux-arcompact.c: Generate.
5098         * features/arc/aux-v2.c: Likewise.
5099         * features/arc/core-arcompact.c: Likewise.
5100         * features/arc/core-v2.c: Likewise.
5101         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
5102
5103 2020-03-16  Tom Tromey  <tromey@adacore.com>
5104
5105         PR gdb/25663:
5106         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
5107         putting value into bcache.
5108
5109 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5110
5111         PR gdb/21500
5112         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
5113         to...
5114         (amd64_windows_init_abi_common): ... this.  Don't set size of
5115         long type.
5116         (amd64_windows_init_abi): New function.
5117         (amd64_cygwin_init_abi): New function.
5118         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
5119         the Cygwin OS ABI.
5120         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
5121         comment.
5122
5123 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5124
5125         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
5126         * windows-tdep.c (CYGWIN_DLL_NAME): New.
5127         (pe_import_directory_entry): New struct type.
5128         (is_linked_with_cygwin_dll): New function.
5129         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
5130         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
5131         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
5132
5133 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5134
5135         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
5136         i386_cygwin_core_osabi_sniffer.
5137
5138 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5139
5140         * i386-cygwin-tdep.c: Rename to...
5141         * i386-windows-tdep.c: ... this.
5142         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
5143         i386-windows-tdep.c.
5144         * configure.tgt: Likewise.
5145
5146 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5147
5148         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
5149         * osabi.c (gdb_osabi_names): Add "Windows".
5150         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
5151         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
5152         (i386_cygwin_core_osabi_sniffer): New function, extracted from
5153         i386_cygwin_osabi_sniffer.
5154         (_initialize_i386_cygwin_tdep): Register OS ABI
5155         GDB_OSABI_WINDOWS for i386.
5156         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
5157         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
5158         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
5159         for x86-64.
5160         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
5161         when the target matches '*-*-mingw*'.
5162
5163 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5164
5165         * defs.h (enum gdb_osabi): Move to...
5166         * osabi.h (enum gdb_osabi): ... here.
5167         * gdbarch.sh: Include osabi.h in gdbarch.h.
5168         * gdbarch.h: Re-generate.
5169
5170 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5171
5172         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
5173         function.
5174         (_initialize_amd64_windows_tdep): Register osabi sniffer.
5175
5176 2020-03-14  Tom Tromey  <tom@tromey.com>
5177
5178         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
5179         for C++.
5180         (c_type_print_modifier): Likewise.  Add "language" parameter.
5181         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
5182         (c_type_print_base_1): Update.
5183         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
5184         constants.
5185         * type-stack.c (type_stack::insert): Handle tp_atomic and
5186         tp_restrict.
5187         (type_stack::follow_type_instance_flags): Likewise.
5188         (type_stack::follow_types): Likewise.  Merge type-following code.
5189         * c-exp.y (RESTRICT, ATOMIC): New tokens.
5190         (space_identifier, cv_with_space_id)
5191         (const_or_volatile_or_space_identifier_noopt)
5192         (const_or_volatile_or_space_identifier): Remove.
5193         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
5194         rules.
5195         (ptr_operator, typebase): Update.
5196         (enum token_flag) <FLAG_C>: New constant.
5197         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
5198         "_Atomic".
5199         (lex_one_token): Handle FLAG_C.
5200
5201 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5202
5203         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
5204         it to the ptrace call.
5205         * m68k-bsd-nat.c (store_registers): Likewise.
5206
5207 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5208
5209         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
5210         gdb_byte *.
5211         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
5212         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
5213         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
5214
5215 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5216
5217         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
5218         nbsd_nat_target instead of inf_ptrace_target.
5219         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5220         nbsd_nat_target.
5221
5222 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5223
5224         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
5225         register_t.
5226
5227 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5228
5229         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
5230         it to the ptrace call.
5231         * alpha-bsd-nat.c (store_registers): Likewise.
5232
5233 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5234
5235         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
5236         includes.
5237         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
5238         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
5239         fill_fpregset): Likewise.
5240
5241 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5242
5243         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
5244         nbsd_nat_target instead of inf_ptrace_target.
5245         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5246         nbsd_nat_target.
5247
5248 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5249
5250         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
5251         register_t.
5252
5253 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5254
5255         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
5256         it to the ptrace call.
5257         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
5258         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
5259         * arm-nbsd-nat.c (store_register): Likewise.
5260         * arm-nbsd-nat.c (store_regs): Likewise.
5261         * arm-nbsd-nat.c (store_fp_register): Likewise.
5262         * arm-nbsd-nat.c (store_fp_regs): Likewise.
5263
5264 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5265
5266         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
5267         nbsd_nat_target instead of inf_ptrace_target.
5268         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5269         nbsd_nat_target.
5270
5271 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5272
5273         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
5274         it to the ptrace call.
5275         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
5276
5277 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5278
5279         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
5280         it to the ptrace call.
5281         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
5282
5283 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5284
5285         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
5286         gdb_byte *.
5287         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
5288
5289 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5290
5291         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
5292         instead of inf_ptrace_target.
5293         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5294         nbsd_nat_target.
5295
5296 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5297
5298         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5299         register_t.
5300
5301 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5302
5303         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5304         register_t.
5305
5306 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5307
5308         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
5309         register_t.
5310
5311 2020-03-13  Tom Tromey  <tom@tromey.com>
5312
5313         * value.h (val_print): Don't declare.
5314         * valprint.h (val_print_array_elements)
5315         (val_print_scalar_formatted, generic_val_print): Don't declare.
5316         * valprint.c (generic_val_print_array): Take a struct value.
5317         (generic_val_print_ptr, generic_val_print_memberptr)
5318         (generic_val_print_bool, generic_val_print_int)
5319         (generic_val_print_char, generic_val_print_complex)
5320         (generic_val_print): Remove.
5321         (generic_value_print): Update.
5322         (do_val_print): Remove unused parameters.  Don't call
5323         la_val_print.
5324         (val_print): Remove.
5325         (common_val_print): Update.  Don't call value_check_printable.
5326         (val_print_scalar_formatted, val_print_array_elements): Remove.
5327         * rust-lang.c (rust_val_print): Remove.
5328         (rust_language_defn): Update.
5329         * p-valprint.c (pascal_val_print): Remove.
5330         (pascal_value_print_inner): Update.
5331         (pascal_object_print_val_fields, pascal_object_print_val):
5332         Remove.
5333         (pascal_object_print_static_field): Update.
5334         * p-lang.h (pascal_val_print): Don't declare.
5335         * p-lang.c (pascal_language_defn): Update.
5336         * opencl-lang.c (opencl_language_defn): Update.
5337         * objc-lang.c (objc_language_defn): Update.
5338         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
5339         * m2-lang.h (m2_val_print): Don't declare.
5340         * m2-lang.c (m2_language_defn): Update.
5341         * language.h (struct language_defn) <la_val_print>: Remove.
5342         * language.c (unk_lang_value_print_inner): Rename.  Change
5343         argument types.
5344         (unknown_language_defn, auto_language_defn): Update.
5345         * go-valprint.c (go_val_print): Remove.
5346         * go-lang.h (go_val_print): Don't declare.
5347         * go-lang.c (go_language_defn): Update.
5348         * f-valprint.c (f_val_print): Remove.
5349         * f-lang.h (f_value_print): Don't declare.
5350         * f-lang.c (f_language_defn): Update.
5351         * d-valprint.c (d_val_print): Remove.
5352         * d-lang.h (d_value_print): Don't declare.
5353         * d-lang.c (d_language_defn): Update.
5354         * cp-valprint.c (cp_print_value_fields)
5355         (cp_print_value_fields_rtti, cp_print_value): Remove.
5356         (cp_print_static_field): Update.
5357         * c-valprint.c (c_val_print_array, c_val_print_ptr)
5358         (c_val_print_struct, c_val_print_union, c_val_print_int)
5359         (c_val_print_memberptr, c_val_print): Remove.
5360         * c-lang.h (c_val_print_array, cp_print_value_fields)
5361         (cp_print_value_fields_rtti): Don't declare.
5362         * c-lang.c (c_language_defn, cplus_language_defn)
5363         (asm_language_defn, minimal_language_defn): Update.
5364         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
5365         (ada_val_print_enum): Take a struct value.
5366         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
5367         (ada_val_print): Remove.
5368         (ada_value_print_1): Update.
5369         (printable_val_type): Remove.
5370         * ada-lang.h (ada_val_print): Don't declare.
5371         * ada-lang.c (ada_language_defn): Update.
5372
5373 2020-03-13  Tom Tromey  <tom@tromey.com>
5374
5375         * valprint.c (do_val_print): Update.
5376         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
5377         a struct value.
5378         (value_to_value_object_no_release): Declare.
5379         * python/py-value.c (value_to_value_object_no_release): New
5380         function.
5381         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
5382         struct value.
5383         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
5384         function.
5385         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
5386         a struct value.
5387         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
5388         Declare.
5389         (gdbscm_apply_val_pretty_printer): Take a struct value.
5390         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
5391         value.
5392         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
5393         value.
5394         * extension-priv.h (struct extension_language_ops)
5395         <apply_val_pretty_printer>: Take a struct value.
5396         * cp-valprint.c (cp_print_value): Create a struct value.
5397         (cp_print_value): Update.
5398
5399 2020-03-13  Tom Tromey  <tom@tromey.com>
5400
5401         * ada-valprint.c (print_field_values): Call common_val_print.
5402
5403 2020-03-13  Tom Tromey  <tom@tromey.com>
5404
5405         * ada-valprint.c (val_print_packed_array_elements): Remove
5406         bitoffset and val parameters.  Call common_val_print.
5407         (ada_val_print_string): Remove offset, address, and original_value
5408         parameters.
5409         (ada_val_print_array): Update.
5410         (ada_value_print_array): New function.
5411         (ada_value_print_1): Call it.
5412
5413 2020-03-13  Tom Tromey  <tom@tromey.com>
5414
5415         * ada-valprint.c (ada_value_print): Use common_val_print.
5416
5417 2020-03-13  Tom Tromey  <tom@tromey.com>
5418
5419         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
5420
5421 2020-03-13  Tom Tromey  <tom@tromey.com>
5422
5423         * ada-valprint.c (ada_value_print_num): New function.
5424         (ada_value_print_1): Use it.
5425
5426 2020-03-13  Tom Tromey  <tom@tromey.com>
5427
5428         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
5429
5430 2020-03-13  Tom Tromey  <tom@tromey.com>
5431
5432         * ada-valprint.c (ada_value_print_ptr): New function.
5433         (ada_value_print_1): Use it.
5434
5435 2020-03-13  Tom Tromey  <tom@tromey.com>
5436
5437         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
5438         call common_val_print.
5439         (ada_val_print_1): Update.
5440         (ada_value_print_1): New function.
5441         (ada_value_print_inner): Rewrite.
5442
5443 2020-03-13  Tom Tromey  <tom@tromey.com>
5444
5445         * cp-valprint.c (cp_print_value_fields): Update.
5446         (cp_print_value): New function.
5447
5448 2020-03-13  Tom Tromey  <tom@tromey.com>
5449
5450         * m2-valprint.c (m2_value_print_inner): Use
5451         cp_print_value_fields.
5452         * cp-valprint.c (cp_print_value_fields): New function.
5453         * c-valprint.c (c_value_print_struct): New function.
5454         (c_value_print_inner): Use c_value_print_struct.
5455         * c-lang.h (cp_print_value_fields): Declare.
5456
5457 2020-03-13  Tom Tromey  <tom@tromey.com>
5458
5459         * c-valprint.c (c_value_print_array): New function.
5460         (c_value_print_inner): Use it.
5461
5462 2020-03-13  Tom Tromey  <tom@tromey.com>
5463
5464         * c-valprint.c (c_value_print_memberptr): New function.
5465         (c_value_print_inner): Use it.
5466
5467 2020-03-13  Tom Tromey  <tom@tromey.com>
5468
5469         * c-valprint.c (c_value_print_int): New function.
5470         (c_value_print_inner): Use it.
5471
5472 2020-03-13  Tom Tromey  <tom@tromey.com>
5473
5474         * c-valprint.c (c_value_print_ptr): New function.
5475         (c_value_print_inner): Use it.
5476
5477 2020-03-13  Tom Tromey  <tom@tromey.com>
5478
5479         * c-valprint.c (c_value_print_inner): Rewrite.
5480
5481 2020-03-13  Tom Tromey  <tom@tromey.com>
5482
5483         * valprint.c (generic_value_print_complex): New function.
5484         (generic_value_print): Use it.
5485
5486 2020-03-13  Tom Tromey  <tom@tromey.com>
5487
5488         * valprint.c (generic_val_print_float): Don't call
5489         val_print_scalar_formatted.
5490         (generic_val_print, generic_value_print): Update.
5491
5492 2020-03-13  Tom Tromey  <tom@tromey.com>
5493
5494         * valprint.c (generic_value_print_char): New function
5495         (generic_value_print): Use it.
5496
5497 2020-03-13  Tom Tromey  <tom@tromey.com>
5498
5499         * valprint.c (generic_value_print_int): New function.
5500         (generic_value_print): Use it.
5501
5502 2020-03-13  Tom Tromey  <tom@tromey.com>
5503
5504         * valprint.c (generic_value_print_bool): New function.
5505         (generic_value_print): Use it.
5506
5507 2020-03-13  Tom Tromey  <tom@tromey.com>
5508
5509         * valprint.c (generic_val_print_func): Simplify.
5510         (generic_val_print, generic_value_print): Update.
5511
5512 2020-03-13  Tom Tromey  <tom@tromey.com>
5513
5514         * valprint.c (generic_val_print_flags): Remove.
5515         (generic_val_print, generic_value_print): Update.
5516         (val_print_type_code_flags): Add original_value parameter.
5517
5518 2020-03-13  Tom Tromey  <tom@tromey.com>
5519
5520         * valprint.c (generic_val_print): Update.
5521         (generic_value_print): Update.
5522         * valprint.c (generic_val_print_enum): Don't call
5523         val_print_scalar_formatted.
5524
5525 2020-03-13  Tom Tromey  <tom@tromey.com>
5526
5527         * valprint.c (generic_value_print): Call generic_value_print_ptr.
5528         * valprint.c (generic_value_print_ptr): New function.
5529
5530 2020-03-13  Tom Tromey  <tom@tromey.com>
5531
5532         * valprint.c (generic_value_print): Rewrite.
5533
5534 2020-03-13  Tom Tromey  <tom@tromey.com>
5535
5536         * p-valprint.c (pascal_object_print_value_fields)
5537         (pascal_object_print_value): New functions.
5538
5539 2020-03-13  Tom Tromey  <tom@tromey.com>
5540
5541         * p-valprint.c (pascal_value_print_inner): Rewrite.
5542
5543 2020-03-13  Tom Tromey  <tom@tromey.com>
5544
5545         * f-valprint.c (f_value_print_innner): Rewrite.
5546
5547 2020-03-13  Tom Tromey  <tom@tromey.com>
5548
5549         * m2-valprint.c (m2_print_unbounded_array): New overload.
5550         (m2_print_unbounded_array): Update.
5551         (m2_print_array_contents): Take a struct value.
5552         (m2_value_print_inner): Rewrite.
5553
5554 2020-03-13  Tom Tromey  <tom@tromey.com>
5555
5556         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
5557         (d_value_print_inner): New function.
5558         * d-lang.h (d_value_print_inner): Declare.
5559         * d-lang.c (d_language_defn): Use d_value_print_inner.
5560
5561 2020-03-13  Tom Tromey  <tom@tromey.com>
5562
5563         * go-valprint.c (go_value_print_inner): New function.
5564         * go-lang.h (go_value_print_inner): Declare.
5565         * go-lang.c (go_language_defn): Use go_value_print_inner.
5566
5567 2020-03-13  Tom Tromey  <tom@tromey.com>
5568
5569         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
5570         API.
5571         (rust_val_print): Rewrite.
5572         (rust_value_print_inner): New function, from rust_val_print.
5573         (rust_language_defn): Use rust_value_print_inner.
5574
5575 2020-03-13  Tom Tromey  <tom@tromey.com>
5576
5577         * ada-valprint.c (ada_value_print_inner): New function.
5578         * ada-lang.h (ada_value_print_inner): Declare.
5579         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
5580
5581 2020-03-13  Tom Tromey  <tom@tromey.com>
5582
5583         * f-valprint.c (f_value_print_innner): New function.
5584         * f-lang.h (f_value_print_innner): Declare.
5585         * f-lang.c (f_language_defn): Use f_value_print_innner.
5586
5587 2020-03-13  Tom Tromey  <tom@tromey.com>
5588
5589         * p-valprint.c (pascal_value_print_inner): New function.
5590         * p-lang.h (pascal_value_print_inner): Declare.
5591         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
5592
5593 2020-03-13  Tom Tromey  <tom@tromey.com>
5594
5595         * m2-valprint.c (m2_value_print_inner): New function.
5596         * m2-lang.h (m2_value_print_inner): Declare.
5597         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
5598
5599 2020-03-13  Tom Tromey  <tom@tromey.com>
5600
5601         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
5602         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
5603         * c-valprint.c (c_value_print_inner): New function.
5604         * c-lang.h (c_value_print_inner): Declare.
5605         * c-lang.c (c_language_defn, cplus_language_defn)
5606         (asm_language_defn, minimal_language_defn): Use
5607         c_value_print_inner.
5608
5609 2020-03-13  Tom Tromey  <tom@tromey.com>
5610
5611         * p-valprint.c (pascal_object_print_value_fields): Now static.
5612         * p-lang.h (pascal_object_print_value_fields): Don't declare.
5613
5614 2020-03-13  Tom Tromey  <tom@tromey.com>
5615
5616         * c-valprint.c (c_val_print_array): Simplify.
5617
5618 2020-03-13  Tom Tromey  <tom@tromey.com>
5619
5620         * valprint.c (value_print_array_elements): New function.
5621         * valprint.h (value_print_array_elements): Declare.
5622
5623 2020-03-13  Tom Tromey  <tom@tromey.com>
5624
5625         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
5626         * mips-tdep.c (mips_print_register): Use
5627         value_print_scalar_formatted.
5628
5629 2020-03-13  Tom Tromey  <tom@tromey.com>
5630
5631         * valprint.h (value_print_scalar_formatted): Declare.
5632         * valprint.c (value_print_scalar_formatted): New function.
5633
5634 2020-03-13  Tom Tromey  <tom@tromey.com>
5635
5636         * valprint.h (generic_value_print): Declare.
5637         * valprint.c (generic_value_print): New function.
5638
5639 2020-03-13  Tom Tromey  <tom@tromey.com>
5640
5641         * valprint.c (do_val_print): Call la_value_print_inner, if
5642         available.
5643         * rust-lang.c (rust_language_defn): Update.
5644         * p-lang.c (pascal_language_defn): Update.
5645         * opencl-lang.c (opencl_language_defn): Update.
5646         * objc-lang.c (objc_language_defn): Update.
5647         * m2-lang.c (m2_language_defn): Update.
5648         * language.h (struct language_defn) <la_value_print_inner>: New
5649         member.
5650         * language.c (unknown_language_defn, auto_language_defn): Update.
5651         * go-lang.c (go_language_defn): Update.
5652         * f-lang.c (f_language_defn): Update.
5653         * d-lang.c (d_language_defn): Update.
5654         * c-lang.c (c_language_defn, cplus_language_defn)
5655         (asm_language_defn, minimal_language_defn): Update.
5656         * ada-lang.c (ada_language_defn): Update.
5657
5658 2020-03-13  Tom Tromey  <tom@tromey.com>
5659
5660         * c-valprint.c (c_value_print): Use common_val_print.
5661
5662 2020-03-13  Tom Tromey  <tom@tromey.com>
5663
5664         * cp-valprint.c (cp_print_static_field): Use common_val_print.
5665
5666 2020-03-13  Tom Tromey  <tom@tromey.com>
5667
5668         * f-valprint.c (f77_print_array_1, f_val_print): Use
5669         common_val_print.
5670
5671 2020-03-13  Tom Tromey  <tom@tromey.com>
5672
5673         * riscv-tdep.c (riscv_print_one_register_info): Use
5674         common_val_print.
5675
5676 2020-03-13  Tom Tromey  <tom@tromey.com>
5677
5678         * mi/mi-main.c (output_register): Use common_val_print.
5679
5680 2020-03-13  Tom Tromey  <tom@tromey.com>
5681
5682         * infcmd.c (default_print_one_register_info): Use
5683         common_val_print.
5684
5685 2020-03-13  Tom Tromey  <tom@tromey.com>
5686
5687         * valprint.h (common_val_print_checked): Declare.
5688         * valprint.c (common_val_print_checked): New function.
5689         * stack.c (print_frame_arg): Use common_val_print_checked.
5690
5691 2020-03-13  Tom Tromey  <tom@tromey.com>
5692
5693         * valprint.c (do_val_print): New function, from val_print.
5694         (val_print): Use do_val_print.
5695         (common_val_print): Use do_val_print.
5696
5697 2020-03-13  Tom Tromey  <tom@tromey.com>
5698
5699         * valprint.c (value_print): Use scoped_value_mark.
5700
5701 2020-03-13  Tom de Vries  <tdevries@suse.de>
5702
5703         PR symtab/25646
5704         * psymtab.c (partial_symtab::partial_symtab): Don't set
5705         globals_offset and statics_offset.  Push element onto
5706         current_global_psymbols and current_static_psymbols stacks.
5707         (concat): New function.
5708         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
5709         element from current_global_psymbols and current_static_psymbols
5710         stacks.  Concat popped elements to global_psymbols and
5711         static_symbols.
5712         (add_psymbol_to_list): Use current_global_psymbols and
5713         current_static_psymbols stacks.
5714         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
5715         current_static_psymbols fields.
5716
5717 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
5718
5719         * corelow.c (sniff_core_bfd): Remove.
5720         (class core_target) <m_core_vec>: Remove.
5721         (core_target::core_target): Update.
5722         (core_file_fns): Remove.
5723         (deprecated_add_core_fns): Remove.
5724         (default_core_sniffer): Remove.
5725         (sniff_core_bfd): Remove.
5726         (default_check_format): Remove.
5727         (gdb_check_format): Remove.
5728         (core_target_open): Update.
5729         (core_target::get_core_register_section): Update.
5730         (get_core_registers_cb): Update.
5731         (core_target::fetch_registers): Update.
5732         * gdbcore.h (struct core_fns): Remove.
5733         (deprecated_add_core_fns): Remove.
5734         (default_core_sniffer): Remove.
5735         (default_check_format): Remove.
5736
5737 2020-03-12  Tom Tromey  <tom@tromey.com>
5738
5739         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
5740         CORE_ADDR.
5741         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
5742
5743 2020-03-12  Tom Tromey  <tom@tromey.com>
5744
5745         * remote.c (remote_target::download_tracepoint)
5746         (remote_target::enable_tracepoint)
5747         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
5748         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
5749         sprintf_vma.
5750
5751 2020-03-12  Tom Tromey  <tom@tromey.com>
5752
5753         * symfile-mem.c: Update CORE_ADDR size assert.
5754
5755 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5756
5757         * selftest.m4: Move to gdbsupport/.
5758         * acinclude.m4: Update path to selftest.m4.
5759
5760 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5761
5762         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
5763         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
5764         gdbarch-selfselftests.c and selftest-arch.c.
5765         (SUBDIR_UNITTESTS_OBS): Rename to...
5766         (SELFTESTS_OBS): ... this.
5767         (COMMON_SFILES): Remove disasm-selftests.c and
5768         gdbarch-selftests.c.
5769         * configure.ac: Don't add selftest-arch.{c,o} to
5770         CONFIG_{SRCS,OBS}.
5771         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
5772         preprocessor conditions.
5773
5774 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5775
5776         * configure.ac: Don't source bfd/development.sh.
5777         * selftest.m4: Modify comment.
5778         * configure: Re-generate.
5779
5780 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5781
5782         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
5783         not "true" or "false".
5784         * configure: Re-generate.
5785
5786 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
5787
5788         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
5789         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
5790         renamed to arm_nbsd_supply_gregset.
5791         (fetch_register): Update to call arm_nbsd_supply_gregset.
5792         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
5793         (arm_netbsd_nat_target::fetch_registers): Update.
5794         (fetch_elfcore_registers): Removed.
5795         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
5796         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
5797         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
5798         not require NetBSD system headers.
5799         (arm_nbsd_regset): New struct.
5800         (arm_nbsd_iterate_over_regset_sections): New function.
5801         (arm_netbsd_init_abi_common): Updated to call
5802         set_gdbarch_iterate_over_regset_sections.
5803         * arm-nbsd-tdep.h: New file.
5804
5805 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
5806
5807         * symtab.c (find_pc_sect_line): Add check which prevents infinite
5808         recursion.
5809
5810 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
5811
5812         * configure: Re-generate.
5813
5814 2020-03-11  Tom Tromey  <tromey@adacore.com>
5815
5816         * ada-typeprint.c (print_choices): Fix comment.
5817
5818 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5819
5820         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
5821         previous item in the list, when the list has no items.
5822
5823 2020-03-11  Tom de Vries  <tdevries@suse.de>
5824
5825         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
5826         PROP_LOCLIST handling code.
5827
5828 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5829
5830         * buildsym-legacy.c (record_line): Pass extra parameter to
5831         record_line.
5832         * buildsym.c (buildsym_compunit::record_line): Take an extra
5833         parameter, reduce duplication in the line table, and record the
5834         is_stmt flag in the line table.
5835         * buildsym.h (buildsym_compunit::record_line): Add extra
5836         parameter.
5837         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
5838         non-statement lines.
5839         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
5840         this to the symtab builder.
5841         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
5842         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
5843         through to dwarf_record_line_1.
5844         * infrun.c (process_event_stop_test): When stepping, don't stop at
5845         a non-statement instruction, and only refresh the step info when
5846         we land in the middle of a line's range.  Also add an extra
5847         comment.
5848         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
5849         field.
5850         * record-btrace.c (btrace_find_line_range): Only record lines
5851         marked as is-statement.
5852         * stack.c (frame_show_address): Show the frame address if we are
5853         in a non-statement sal.
5854         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
5855         (maintenance_print_one_line_table): Print a header for the is_stmt
5856         column, and include is_stmt information in the output.
5857         * symtab.c (find_pc_sect_line): Find lines marked as statements in
5858         preference to non-statements.
5859         (find_pcs_for_symtab_line): Prefer is-statement entries.
5860         (find_line_common): Likewise.
5861         * symtab.h (struct linetable_entry): Add is_stmt field.
5862         (struct symtab_and_line): Likewise.
5863         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
5864         arranging the line table.
5865
5866 2020-03-07  Tom de Vries  <tdevries@suse.de>
5867
5868         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
5869         DIE.
5870
5871 2020-03-07  Tom Tromey  <tom@tromey.com>
5872
5873         * valops.c (value_literal_complex): Remove obsolete comment.
5874         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
5875         comment.
5876
5877 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5878
5879         * infrun.h: Forward-declare thread_info.
5880         (set_step_info): Add thread_info parameter, add doc.
5881         * infrun.c (set_step_info): Add thread_info parameter, move doc
5882         to header.
5883         * infrun.c (process_event_stop_test): Pass thread to
5884         set_step_info call.
5885         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
5886         set_step_info.
5887         (prepare_one_step): Add thread_info parameter, pass it to
5888         set_step_frame and prepare_one_step (recursive) call.
5889         (step_1): Pass thread to prepare_one_step call.
5890         (step_command_fsm::should_stop): Pass thread to
5891         prepare_one_step.
5892         (until_next_fsm): Pass thread to set_step_frame call.
5893         (finish_command): Pass thread to set_step_info call.
5894
5895 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
5896
5897         * windows-tdep.c (windows_solib_create_inferior_hook):
5898         Check if inferior is running.
5899
5900 2020-03-06  Tom de Vries  <tdevries@suse.de>
5901
5902         * NEWS: Fix "the the".
5903         * ctfread.c: Same.
5904
5905 2020-03-06  Tom de Vries  <tdevries@suse.de>
5906
5907         * psymtab.c (psymtab_to_symtab): Don't print "done.".
5908
5909 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5910
5911         * .dir-locals.el: Add a comment referencing the other copies of
5912         this file.
5913
5914 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
5915
5916         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
5917         psargs.
5918
5919 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5920
5921         * .gitattributes: New file.
5922
5923 2020-03-04  Tom Tromey  <tom@tromey.com>
5924
5925         * symmisc.c (print_symbol_bcache_statistics)
5926         (print_objfile_statistics): Update.
5927         * symfile.c (allocate_symtab): Use intern.
5928         * psymtab.c (partial_symtab::partial_symtab): Use intern.
5929         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5930         macro_cache>: Remove.
5931         <string_cache>: New member.
5932         (struct objfile) <intern>: New methods.
5933         * elfread.c (elf_symtab_read): Use intern.
5934         * dwarf2/read.c (fixup_go_packaging): Intern package name.
5935         (dwarf2_compute_name, dwarf2_physname)
5936         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
5937         names.
5938         (guess_partial_die_structure_name): Update.
5939         (partial_die_info::fixup): Intern name.
5940         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
5941         name.
5942         (dwarf2_name): Intern name.  Update.
5943         * buildsym.c (buildsym_compunit::get_macro_table): Use
5944         string_cache.
5945
5946 2020-03-04  Tom Tromey  <tom@tromey.com>
5947
5948         * jit.c (bfd_open_from_target_memory): Make "target" const.
5949         * corefile.c (gnutarget): Now const.
5950         * gdbcore.h (gnutarget): Now const.
5951
5952 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
5953
5954         * NEWS: Mention support for WOW64 processes.
5955         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
5956         (amd64_windows_segment_register_p): Remove static.
5957         (_initialize_amd64_windows_nat): Update.
5958         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
5959         * i386-windows-nat.c (context_offset): Update.
5960         (i386_mappings): Rename and remove static.
5961         (i386_windows_segment_register_p): Remove static.
5962         (_initialize_i386_windows_nat): Update.
5963         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
5964         (STATUS_WX86_SINGLE_STEP): New macro.
5965         (EnumProcessModulesEx): New macro.
5966         (Wow64SuspendThread): New macro.
5967         (Wow64GetThreadContext): New macro.
5968         (Wow64SetThreadContext): New macro.
5969         (Wow64GetThreadSelectorEntry): New macro.
5970         (windows_set_context_register_offsets): Add static.
5971         (windows_set_segment_register_p): Likewise.
5972         (windows_add_thread): Adapt for WOW64 processes.
5973         (windows_fetch_one_register): Likewise.
5974         (windows_nat_target::fetch_registers): Likewise.
5975         (windows_store_one_register): Likewise.
5976         (display_selector): Likewise.
5977         (display_selectors): Likewise.
5978         (handle_exception): Likewise.
5979         (windows_continue): Likewise.
5980         (windows_nat_target::resume): Likewise.
5981         (windows_add_all_dlls): Likewise.
5982         (do_initial_windows_stuff): Likewise.
5983         (windows_nat_target::attach): Likewise.
5984         (windows_get_exec_module_filename): Likewise.
5985         (windows_nat_target::create_inferior): Likewise.
5986         (windows_xfer_siginfo): Likewise.
5987         (_initialize_loadable): Initialize Wow64SuspendThread,
5988         Wow64GetThreadContext, Wow64SetThreadContext,
5989         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
5990         * windows-nat.h (windows_set_context_register_offsets):
5991         Remove declaration.
5992         (windows_set_segment_register_p): Likewise.
5993         (i386_windows_segment_register_p): Add declaration.
5994         (amd64_windows_segment_register_p): Likewise.
5995
5996 2020-03-04  Luis Machado  <luis.machado@linaro.org>
5997
5998         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
5999         in "info registers" for AArch64/ARM.
6000
6001         The change caused "info registers" to not print GPR's.
6002
6003         gdb/ChangeLog:
6004
6005         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
6006
6007         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
6008         when reg->group is empty and reggroup is not.
6009
6010 2020-03-03  Tom Tromey  <tromey@adacore.com>
6011
6012         * dwarf2/frame.c (struct dwarf2_frame_cache)
6013         <checked_tailcall_bottom, entry_cfa_sp_offset,
6014         entry_cfa_sp_offset_p>: Remove members.
6015         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
6016         (dwarf2_frame_prev_register): Don't call
6017         dwarf2_tailcall_sniffer_first.
6018         (dwarf2_append_unwinders): Don't append tailcall unwinder.
6019         * frame-unwind.c (add_unwinder): New fuction.
6020         (frame_unwind_init): Use it.  Add tailcall unwinder.
6021
6022 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6023             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
6024
6025         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
6026         value should be printed as true.
6027
6028 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
6029
6030         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
6031         (windows_init_abi): Set and use windows_so_ops.
6032
6033 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
6034
6035         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
6036         when verifying if dealing with a convenience variable.
6037
6038 2020-03-03  Luis Machado  <luis.machado@linaro.org>
6039
6040         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
6041
6042 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
6043
6044         * infrun.c (gdbarch_supports_displaced_stepping): New.
6045         (use_displaced_stepping): Break up conditions in smaller pieces.
6046         Use gdbarch_supports_displaced_stepping.
6047         (displaced_step_prepare_throw): Use
6048         gdbarch_supports_displaced_stepping.
6049
6050 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6051
6052         * NEWS: Mention new behaviour of the history filename.
6053         * top.c (write_history_p): Add comment.
6054         (show_write_history_p): Add header comment, give a different
6055         message when history writing is on, but the history filename is
6056         empty.
6057         (history_filename): Add comment.
6058         (history_filename_empty): New function.
6059         (show_history_filename): Add header comment, give a different
6060         message when the filename is empty.
6061         (init_history): Compare history_filename against nullptr, and only
6062         read history if the filename is not empty.
6063         (set_history_filename): Add header comment, and only make
6064         non-empty filenames absolute.
6065         (init_main): Make the filename argument to 'set history filename'
6066         optional.
6067
6068 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
6069
6070         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
6071         (arm_supply_vfpregset): ...this, and update to use VFP registers.
6072         (fetch_fp_register): Update.
6073         (fetch_fp_regs): Update.
6074         (store_fp_register): Update.
6075         (store_fp_regs): Update.
6076         (arm_netbsd_nat_target::read_description): New function.
6077         (fetch_elfcore_registers): Update.
6078
6079 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6080
6081         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
6082         general_thread if the stop reply is missing a thread-id.
6083         (remote_target::process_stop_reply): Use the first non-exited
6084         thread if the target didn't pass a thread-id.
6085         * infrun.c (do_target_wait): Move call to
6086         switch_to_inferior_no_thread to ....
6087         (do_target_wait_1): ... here.
6088
6089 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
6090
6091         * debuginfod-support.c: Include defs.h first.
6092
6093 2020-02-28  Tom de Vries  <tdevries@suse.de>
6094
6095         * symfile.c (set_initial_language): Use default language for lookup.
6096
6097 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
6098
6099         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
6100         reader variable, pass `this` to read_cutu_die_from_dwo.
6101
6102 2020-02-27  Aaron Merey  <amerey@redhat.com>
6103
6104         * source.c (open_source_file): Check for nullptr when computing
6105         srcpath.
6106
6107 2020-02-27  Tom Tromey  <tromey@adacore.com>
6108
6109         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
6110         member.
6111         (dwarf2_add_field): Don't update nfields.
6112         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
6113
6114 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6115
6116         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
6117         abs.
6118
6119 2020-02-26  Tom Tromey  <tom@tromey.com>
6120
6121         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
6122         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
6123         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
6124         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
6125         per_cu_data.
6126
6127 2020-02-26  Tom Tromey  <tom@tromey.com>
6128
6129         * dwarf2/index-write.c (psym_index_map): Change type.
6130         (add_address_entry_worker, write_one_signatured_type)
6131         (recursively_count_psymbols, recursively_write_psymbols)
6132         (class debug_names, psyms_seen_size, write_gdbindex)
6133         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
6134
6135 2020-02-26  Aaron Merey  <amerey@redhat.com>
6136
6137         * Makefile.in: Handle optional debuginfod support.
6138         * NEWS: Update.
6139         * README: Add --with-debuginfod summary.
6140         * config.in: Regenerate.
6141         * configure: Regenerate.
6142         * configure.ac: Handle optional debuginfod support.
6143         * debuginfod-support.c: debuginfod helper functions.
6144         * debuginfod-support.h: Ditto.
6145         * doc/gdb.texinfo: Add --with-debuginfod to configure options
6146         summary.
6147         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
6148         when a dwz file cannot be found.
6149         * elfread.c (elf_symfile_read): Query debuginfod servers when a
6150         debuginfo file cannot be found.
6151         * source.c (open_source_file): Query debuginfod servers when a
6152         source file cannot be found.
6153         * top.c (print_gdb_configuration): Include
6154         --{with,without}-debuginfod in the output.
6155
6156 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
6157
6158         * thread.c (thr_try_catch_cmd): Print thread name.
6159
6160 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
6161
6162         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
6163         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6164         dwarf2_fetch_die_type_sect_off): Move to...
6165         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
6166         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6167         dwarf2_fetch_die_type_sect_off): ... here.
6168         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
6169         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6170         dwarf2_fetch_die_type_sect_off): Move doc to header file.
6171
6172 2020-02-26  Tom de Vries  <tdevries@suse.de>
6173
6174         PR gdb/25603
6175         * symfile.c (set_initial_language): Exit-early if
6176         language_mode == language_mode_manual.
6177
6178 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
6179
6180         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
6181         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
6182         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
6183
6184 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
6185
6186         * gdbtypes.c (create_array_type_with_stride): Handle negative
6187         array strides.
6188         * valarith.c (value_subscripted_rvalue): Likewise.
6189
6190 2020-02-25  Luis Machado  <luis.machado@linaro.org>
6191
6192         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
6193
6194 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
6195
6196         * loc.h (dwarf2_get_die_type): Move to...
6197         * read.h (dwarf2_get_die_type): ... here.
6198         * read.c (dwarf2_get_die_type): Move doc to header.
6199
6200 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
6201
6202         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
6203         'gnulib/Makefile.in' to the list.
6204
6205 2020-02-24  Tom Tromey  <tom@tromey.com>
6206
6207         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
6208         Remove.
6209         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
6210         XOBNEWVEC.
6211
6212 2020-02-24  Tom Tromey  <tom@tromey.com>
6213
6214         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
6215         New method.
6216         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
6217         (dw2_do_instantiate_symtab, dw2_get_file_names)
6218         (build_type_psymtab_dependencies, load_full_type_unit): Update.
6219
6220 2020-02-24  Tom Tromey  <tom@tromey.com>
6221
6222         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
6223         make_scoped_restore.
6224         (dwarf2_psymtab::read_symtab): Don't clear
6225         reading_partial_symbols.
6226
6227 2020-02-24  Tom de Vries  <tdevries@suse.de>
6228
6229         PR gdb/25592
6230         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
6231
6232 2020-02-24  Tom de Vries  <tdevries@suse.de>
6233
6234         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
6235         commands layout next/prev/regs.
6236
6237 2020-02-22  Tom Tromey  <tom@tromey.com>
6238
6239         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
6240         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
6241
6242 2020-02-22  Tom Tromey  <tom@tromey.com>
6243
6244         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
6245
6246 2020-02-22  Tom Tromey  <tom@tromey.com>
6247
6248         * tui/tui-win.c (_initialize_tui_win): Add usage text.
6249         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
6250         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
6251         * tui/tui.c (_initialize_tui): Add usage text.
6252
6253 2020-02-22  Tom Tromey  <tom@tromey.com>
6254
6255         * tui/tui-win.c (tui_set_focus_command)
6256         (tui_set_win_height_command): Use error_no_arg.
6257         (_initialize_tui_win): Update help text.
6258         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
6259
6260 2020-02-22  Tom Tromey  <tom@tromey.com>
6261
6262         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
6263         * tui/tui-disasm.h (struct tui_disasm_window)
6264         <display_start_addr>: Declare.
6265         * tui/tui-source.h (struct tui_source_window)
6266         <display_start_addr>: Declare.
6267         * tui/tui-winsource.h (struct tui_source_window_base)
6268         <show_source_line, display_start_addr>: New methods.
6269         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
6270         Rename and move to protected section.
6271         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
6272         (tui_source_window_base::do_erase_source_content): Update.
6273         (tui_source_window_base::show_source_line): Now a method.
6274         (tui_source_window_base::show_source_content)
6275         (tui_source_window_base::tui_source_window_base)
6276         (tui_source_window_base::rerender)
6277         (tui_source_window_base::refill)
6278         (tui_source_window_base::do_scroll_horizontal)
6279         (tui_source_window_base::set_is_exec_point_at)
6280         (tui_source_window_base::update_breakpoint_info)
6281         (tui_source_window_base::update_exec_info): Update.
6282         * tui/tui-source.c (tui_source_window::set_contents)
6283         (tui_source_window::showing_source_p)
6284         (tui_source_window::do_scroll_vertical)
6285         (tui_source_window::location_matches_p)
6286         (tui_source_window::line_is_displayed): Update.
6287         (tui_source_window::display_start_addr): New method.
6288         * tui/tui-disasm.c (tui_disasm_window::set_contents)
6289         (tui_disasm_window::do_scroll_vertical)
6290         (tui_disasm_window::location_matches_p): Update.
6291         (tui_disasm_window::display_start_addr): New method.
6292
6293 2020-02-22  Tom Tromey  <tom@tromey.com>
6294
6295         * NEWS: Add entry for gdb.register_window_type.
6296         * tui/tui-layout.h (window_factory): New typedef.
6297         (tui_register_window): Declare.
6298         * tui/tui-layout.c (saved_tui_windows): New global.
6299         (tui_apply_current_layout): Use it.
6300         (tui_register_window): New function.
6301         * python/python.c (do_start_initialization): Call
6302         gdbpy_initialize_tui.
6303         (python_GdbMethods): Add "register_window_type" function.
6304         * python/python-internal.h (gdbpy_register_tui_window)
6305         (gdbpy_initialize_tui): Declare.
6306         * python/py-tui.c: New file.
6307         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
6308
6309 2020-02-22  Tom Tromey  <tom@tromey.com>
6310
6311         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
6312
6313 2020-02-22  Tom Tromey  <tom@tromey.com>
6314
6315         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
6316         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
6317         * tui/tui-data.c (tui_set_win_with_focus): Remove.
6318         (tui_set_win_focus_to): Move from tui-win.c.
6319
6320 2020-02-22  Tom Tromey  <tom@tromey.com>
6321
6322         * tui/tui-layout.c (make_standard_window, get_locator_window): New
6323         functions.
6324         (known_window_types): New global.
6325         (tui_get_window_by_name): Reimplement.
6326         (initialize_known_windows): New function.
6327         (validate_window_name): Rewrite.
6328         (_initialize_tui_layout): Call initialize_known_windows.
6329
6330 2020-02-22  Tom Tromey  <tom@tromey.com>
6331
6332         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
6333         Remove constants.
6334         * tui/tui-winsource.h (struct tui_source_window_base)
6335         <tui_source_window_base>: Remove parameter.
6336         * tui/tui-winsource.c
6337         (tui_source_window_base::tui_source_window_base): Remove
6338         parameter.
6339         (tui_source_window_base::refill): Update.
6340         * tui/tui-stack.h (struct tui_locator_window)
6341         <tui_locator_window>: Update.
6342         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
6343         Default the constructor.
6344         * tui/tui-regs.h (struct tui_data_item_window)
6345         <tui_data_item_window>: Default the constructor.
6346         (struct tui_data_window) <tui_data_window>: Likewise.
6347         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
6348         Default the constructor.
6349         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
6350         Default the constructor.
6351         <type>: Remove.
6352         (struct tui_win_info) <tui_win_info>: Default the constructor.
6353         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
6354         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
6355         Default the constructor.
6356
6357 2020-02-22  Tom Tromey  <tom@tromey.com>
6358
6359         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
6360         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
6361         * tui/tui-win.c (tui_resize_all): Don't call
6362         tui_delete_invisible_windows.
6363         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
6364         done.
6365         (tui_set_layout): Update.
6366         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
6367         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
6368         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
6369
6370 2020-02-22  Tom Tromey  <tom@tromey.com>
6371
6372         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
6373         correctly.
6374
6375 2020-02-22  Tom Tromey  <tom@tromey.com>
6376
6377         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
6378
6379 2020-02-22  Tom Tromey  <tom@tromey.com>
6380
6381         * tui/tui-winsource.h (struct tui_source_window_iterator)
6382         <inner_iterator>: New etytypedef.
6383         <tui_source_window_iterator>: Take "end" parameter.
6384         <tui_source_window_iterator>: Take iterator.
6385         <operator*, advance>: Update.
6386         <m_iter>: Change type.
6387         <m_end>: New field.
6388         (struct tui_source_windows) <begin, end>: Update.
6389         * tui/tui-layout.c (tui_windows): New global.
6390         (tui_apply_current_layout): Clear tui_windows.
6391         (tui_layout_window::apply): Update tui_windows.
6392         * tui/tui-data.h (tui_windows): Declare.
6393         (all_tui_windows): Now inline function.
6394         (class tui_window_iterator, struct all_tui_windows): Remove.
6395
6396 2020-02-22  Tom Tromey  <tom@tromey.com>
6397
6398         PR tui/17850:
6399         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
6400         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
6401         "height" argument.
6402         (class tui_layout_window) <get_sizes>: Likewise.
6403         (class tui_layout_split) <tui_layout_split>: Add "vertical"
6404         argument.
6405         <get_sizes>: Add "height" argument.
6406         <m_vertical>: New field.
6407         * tui/tui-layout.c (tui_layout_split::clone): Update.
6408         (tui_layout_split::get_sizes): Add "height" argument.
6409         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
6410         (tui_new_layout_command): Parse "-horizontal".
6411         (_initialize_tui_layout): Update help string.
6412         (tui_layout_split::specification): Add "-horizontal" when needed.
6413         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
6414         argument.
6415         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
6416         New methods.
6417
6418 2020-02-22  Tom Tromey  <tom@tromey.com>
6419
6420         * tui/tui-layout.h (enum tui_adjust_result): New.
6421         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
6422         (class tui_layout_window) <adjust_size>: Return
6423         tui_adjust_result.  Rewrite.
6424         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
6425         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
6426
6427 2020-02-22  Tom Tromey  <tom@tromey.com>
6428
6429         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
6430         parameter and return types.
6431         (class tui_layout_base) <specification>: Add "depth".
6432         (class tui_layout_window) <specification>: Add "depth".
6433         (class tui_layout_split) <specification>: Add "depth".
6434         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
6435         and return types.
6436         (tui_new_layout_command): Parse sub-layouts.
6437         (_initialize_tui_layout): Update help string.
6438         (tui_layout_window::specification): Add "depth".
6439         (add_layout_command): Update.
6440
6441 2020-02-22  Tom Tromey  <tom@tromey.com>
6442
6443         * NEWS: Add "tui new-layout" item.
6444         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
6445         Add new-layout command to help text.
6446         (validate_window_name): New function.
6447         (tui_new_layout_command): New function.
6448         (_initialize_tui_layout): Register "new-layout".
6449         (tui_layout_window::specification): New method.
6450         (tui_layout_window::specification): New method.
6451         * tui/tui-layout.h (class tui_layout_base) <specification>: New
6452         method.
6453         (class tui_layout_window) <specification>: New method.
6454         (class tui_layout_split) <specification>: New method.
6455
6456 2020-02-22  Tom Tromey  <tom@tromey.com>
6457
6458         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
6459         * tui/tui-win.c (window_name_completer): Update comment.
6460         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
6461         Declare method.
6462         (class tui_layout_window) <replace_window>: Likewise.
6463         (class tui_layout_split) <replace_window>: Likewise.
6464         (tui_set_layout): Don't declare.
6465         (tui_set_initial_layout): Declare function.
6466         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
6467         (asm_regs_layout): New globals.
6468         (tui_current_layout, show_layout): Remove.
6469         (tui_set_layout, tui_add_win_to_layout): Rewrite.
6470         (find_layout, tui_apply_layout): New function.
6471         (layout_completer): Remove.
6472         (tui_next_layout): Reimplement.
6473         (tui_next_layout_command): New function.
6474         (tui_set_initial_layout, tui_prev_layout_command): New functions.
6475         (tui_regs_layout): Reimplement.
6476         (tui_regs_layout_command): New function.
6477         (extract_display_start_addr): Rewrite.
6478         (next_layout, prev_layout): Remove.
6479         (tui_layout_window::replace_window): New method.
6480         (tui_layout_split::replace_window): New method.
6481         (destroy_layout): New function.
6482         (layout_list): New global.
6483         (add_layout_command): New function.
6484         (initialize_layouts): Update.
6485         (tui_layout_command): New function.
6486         (_initialize_tui_layout): Install "layout" commands.
6487         * tui/tui-data.h (enum tui_layout_type): Remove.
6488         (tui_current_layout): Don't declare.
6489
6490 2020-02-22  Tom Tromey  <tom@tromey.com>
6491
6492         * tui/tui-regs.c (tui_reg_layout): Remove.
6493         (tui_reg_command): Use tui_regs_layout.
6494         * tui/tui-layout.h (tui_reg_command): Declare.
6495         * tui/tui-layout.c (tui_reg_command): New function.
6496
6497 2020-02-22  Tom Tromey  <tom@tromey.com>
6498
6499         * tui/tui.c (tui_rl_delete_other_windows): Call
6500         tui_remove_some_windows.
6501         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
6502         Declare method.
6503         (class tui_layout_window) <remove_windows>: New method.
6504         (class tui_layout_split) <remove_windows>: Declare.
6505         (tui_remove_some_windows): Declare.
6506         * tui/tui-layout.c (tui_remove_some_windows): New function.
6507         (tui_layout_split::remove_windows): New method.
6508
6509 2020-02-22  Tom Tromey  <tom@tromey.com>
6510
6511         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
6512         * tui/tui-layout.h (tui_next_layout): Declare.
6513         * tui/tui-layout.c (tui_next_layout): New function.
6514
6515 2020-02-22  Tom Tromey  <tom@tromey.com>
6516
6517         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
6518         correct coordinates.
6519
6520 2020-02-22  Tom Tromey  <tom@tromey.com>
6521
6522         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
6523         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
6524         DATA_WIN case.
6525
6526 2020-02-22  Tom Tromey  <tom@tromey.com>
6527
6528         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
6529         TUI_DISASM_WIN, not tui_win_list.
6530
6531 2020-02-22  Tom Tromey  <tom@tromey.com>
6532
6533         * valprint.c (generic_val_print_enum_1)
6534         (val_print_type_code_flags): Style member names.
6535         * rust-lang.c (val_print_struct, rust_print_enum)
6536         (rust_print_struct_def, rust_internal_print_type): Style member
6537         names.
6538         * p-valprint.c (pascal_object_print_value_fields): Style member
6539         names.  Only call fprintf_symbol_filtered for static members.
6540         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
6541         * f-valprint.c (f_val_print): Style member names.
6542         * f-typeprint.c (f_type_print_base): Style member names.
6543         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
6544         call fprintf_symbol_filtered for static members.
6545         (cp_print_class_member): Style member names.
6546         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
6547         member names.
6548         * ada-valprint.c (ada_print_scalar): Style enum names.
6549         (ada_val_print_enum): Likewise.
6550         * ada-typeprint.c (print_enum_type): Style enum names.
6551
6552 2020-02-21  Tom Tromey  <tom@tromey.com>
6553
6554         * psympriv.h (struct partial_symtab): Update comment.
6555
6556 2020-02-21  Tom Tromey  <tromey@adacore.com>
6557
6558         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
6559         type is CORE_ADDR.
6560
6561 2020-02-21  Tom de Vries  <tdevries@suse.de>
6562
6563         PR gdb/25534
6564         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
6565         if dependencies[i]->user != NULL.
6566
6567 2020-02-21  Ali Tamur  <tamur@google.com>
6568
6569         * dwarf2/read.c (dwarf2_name): Add null check.
6570
6571 2020-02-20  Tom Tromey  <tom@tromey.com>
6572
6573         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
6574         ">=", in binary search.
6575         (dwarf2_find_containing_comp_unit): New overload.
6576         (run_test): New self-test.
6577         (_initialize_dwarf2_read): Register new test.
6578
6579 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
6580
6581         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
6582         * riscv-tdep.h: Likewise.
6583         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
6584         rv32-only CSR.
6585         * features/riscv/64bit-csr.xml: Regenerated.
6586
6587 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
6588             Tom Tromey  <tom@tromey.com>
6589
6590         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
6591         of 'fputc_unfiltered'.
6592         (putchar_unfiltered): Call 'fputc_unfiltered'.
6593         (fputc_unfiltered): Call 'fputs_unfiltered'.
6594
6595 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
6596
6597         * config.in: Regenerate.
6598         * configure: Regenerate.
6599         * configure.ac: Add --with-python-libdir option.
6600         * main.c: Use WITH_PYTHON_LIBDIR.
6601
6602 2020-02-19  Tom Tromey  <tom@tromey.com>
6603
6604         * symtab.c (general_symbol_info::compute_and_set_names): Use
6605         obstack_strndup.  Simplify call to symbol_set_demangled_name.
6606
6607 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
6608
6609         * dwarf2/read.c (allocate_signatured_type_table,
6610         allocate_dwo_unit_table, allocate_type_unit_groups_table,
6611         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
6612         Remove objfile parameter, update all callers.
6613
6614 2020-02-19  Doug Evans  <dje@google.com>
6615
6616         PR rust/25535
6617         * rust-lang.c (rust_print_enum): Apply embedded_offset to
6618         rust_enum_variant calculation.
6619
6620 2020-02-19  Tom Tromey  <tromey@adacore.com>
6621
6622         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
6623
6624 2020-02-19  Tom Tromey  <tromey@adacore.com>
6625
6626         * ada-lang.c (cache_symbol): Use obstack_strdup.
6627
6628 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6629
6630         * configure: Regenerate.
6631
6632 2020-02-19  Tom Tromey  <tromey@adacore.com>
6633
6634         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
6635         NULL check.
6636
6637 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
6638
6639         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
6640
6641 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6642
6643         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
6644         if GDBSERVER is not defined.
6645         (riscv_tdesc_cache): Likewise, also store const target_desc.
6646         (STATIC_IN_GDB): Define.
6647         (riscv_create_target_description): Update declaration with
6648         STATIC_IN_GDB.
6649         (riscv_lookup_target_description): New function, only define if
6650         GDBSERVER is not defined.
6651         * arch/riscv.h (riscv_create_target_description): Declare only
6652         when GDBSERVER is defined.
6653         (riscv_lookup_target_description): New declaration when GDBSERVER
6654         is not defined.
6655         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
6656         (riscv_linux_read_features): ...this, and return
6657         riscv_gdbarch_features instead of target_desc.
6658         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
6659         (riscv_linux_read_description): Rename to...
6660         (riscv_linux_read_features): ...this.
6661         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
6662         Update to use riscv_gdbarch_features and
6663         riscv_lookup_target_description.
6664         * riscv-tdep.c (riscv_find_default_target_description): Use
6665         riscv_lookup_target_description instead of
6666         riscv_create_target_description.
6667
6668 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6669
6670         * valprint.c (generic_val_print_enum_1): When printing a flag
6671         enum with value 0 and there is no enumerator with value 0, print
6672         just "0" instead of "(unknown: 0x0)".
6673
6674 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6675
6676         * valprint.c (generic_val_print_enum_1): Print unknown part of
6677         flag enum in hex.
6678
6679 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6680
6681         * dwarf2/read.c (update_enumeration_type_from_children): Allow
6682         flag enums to contain duplicate enumerators.
6683         * valprint.c (generic_val_print_enum_1): Update comment.
6684
6685 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6686
6687         * dwarf2/read.c: Include "count-one-bits.h".
6688         (update_enumeration_type_from_children): If an enumerator has
6689         multiple bits set, don't treat the enumeration as a "flag enum".
6690         * valprint.c (generic_val_print_enum_1): Assert that enumerators
6691         of flag enums have 0 or 1 bit set.
6692
6693 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6694
6695         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
6696         conversion.
6697         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
6698         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
6699         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
6700         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
6701         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
6702
6703 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6704
6705         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
6706
6707 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6708
6709         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
6710         displaced_step_closure_up.
6711         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
6712         (struct displaced_step_closure_up):
6713         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
6714         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
6715         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
6716         Likewise.
6717         * gdbarch.sh (displaced_step_copy_insn): Likewise.
6718         * gdbarch.c, gdbarch.h: Re-generate.
6719         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
6720         displaced_step_closure_up.
6721         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
6722         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
6723         * infrun.h (displaced_step_closure_up): New type alias.
6724         (struct displaced_step_inferior_state) <step_closure>: Change
6725         type to displaced_step_closure_up.
6726         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
6727         displaced_step_closure_up.
6728         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
6729
6730 2020-02-14  Tom Tromey  <tom@tromey.com>
6731
6732         * minidebug.c (gnu_debug_key): New global.
6733         (find_separate_debug_file_in_section): Use it.
6734
6735 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6736
6737         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
6738         std::unique_ptr.
6739         * gdbarch.c: Re-generate.
6740         * gdbarch.h: Re-generate.
6741         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
6742         change.
6743         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
6744         type to std::unique_ptr.
6745         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
6746         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
6747         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
6748         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
6749         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
6750         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
6751         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
6752         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
6753         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
6754
6755 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6756
6757         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
6758         std::unique_ptr.
6759         (displaced_step_clear): Rename to...
6760         (displaced_step_reset): ... this.  Just call displaced->reset ().
6761         (displaced_step_clear_cleanup): Rename to...
6762         (displaced_step_reset_cleanup): ... this.
6763         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
6764         (displaced_step_fixup): Likewise.
6765         (resume_1): Likewise.
6766         (handle_inferior_event): Restore child's memory before calling
6767         displaced_step_fixup on the parent.
6768         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
6769         to std::unique_ptr.
6770         <step_closure>: Change type to std::unique_ptr.
6771
6772 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6773
6774         * arm-tdep.c: Include count-one-bits.h.
6775         (cleanup_block_store_pc): Use count_one_bits.
6776         (cleanup_block_load_pc): Use count_one_bits.
6777         (arm_copy_block_xfer): Use count_one_bits.
6778         (thumb2_copy_block_xfer): Use count_one_bits.
6779         (thumb_copy_pop_pc_16bit): Use count_one_bits.
6780         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
6781         (thumb_get_next_pcs_raw): Use count_one_bits.
6782         (arm_get_next_pcs_raw): Use count_one_bits_l.
6783         * arch/arm.c (bitcount): Remove.
6784         * arch/arm.h (bitcount): Remove.
6785
6786 2020-02-14  Tom Tromey  <tromey@adacore.com>
6787
6788         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
6789         Update.
6790         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
6791         * dwarf2/loc.c (call_site_find_chain_1): Return
6792         unique_xmalloc_ptr.
6793         (call_site_find_chain): Likewise.
6794
6795 2020-02-14  Richard Biener  <rguenther@suse.de>
6796
6797         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
6798         on expression with division operators.
6799
6800 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
6801
6802         * MAINTAINERS (Write After Approval): Adding myself.
6803
6804 2020-02-12  Tom Tromey  <tom@tromey.com>
6805
6806         * event-loop.c (event_data, gdb_event, event_handler_func):
6807         Remove.
6808
6809 2020-02-12  Tom Tromey  <tom@tromey.com>
6810
6811         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
6812         (dwarf2_frame_objfile_data): Add comment.
6813         (find_comp_unit, set_comp_unit): New functions.
6814         (dwarf2_frame_find_fde): Use find_comp_unit.
6815         (dwarf2_build_frame_info): Use set_comp_unit.
6816
6817 2020-02-12  Tom Tromey  <tom@tromey.com>
6818
6819         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
6820         (comp_unit): Don't initialize objfile.
6821         (execute_cfa_program): Add text_offset parameter.
6822         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
6823         (dwarf2_frame_cache): Update.
6824         (dwarf2_build_frame_info): Don't set "objfile" member.
6825
6826 2020-02-12  Tom Tromey  <tom@tromey.com>
6827
6828         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
6829         (decode_frame_entry): Likewise.
6830         (dwarf2_build_frame_info): Update.
6831
6832 2020-02-12  Tom Tromey  <tom@tromey.com>
6833
6834         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
6835         (decode_frame_entry_1): Use the comp_unit obstack.
6836
6837 2020-02-12  Tom Tromey  <tom@tromey.com>
6838
6839         * dwarf2/frame.c (struct comp_unit): Add initializers and
6840         constructor.
6841         (dwarf2_frame_objfile_data): Store a comp_unit.
6842         (dwarf2_frame_find_fde): Update.
6843         (dwarf2_build_frame_info): Use "new".
6844
6845 2020-02-12  Tom Tromey  <tom@tromey.com>
6846
6847         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
6848         (dwarf2_fde_table): Typedef for std::vector.
6849         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
6850         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
6851         (decode_frame_entry): Update.
6852         (dwarf2_build_frame_info): Use "new".
6853
6854 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
6855
6856         * arm-tdep.c (arm_gdbarch_init): Update.
6857         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
6858         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
6859         have_neon, is_m>: Change to bool.
6860
6861 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
6862
6863         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
6864
6865 2020-02-12  Tom Tromey  <tom@tromey.com>
6866
6867         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
6868
6869 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
6870
6871         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
6872         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
6873
6874 2020-02-11  Tom Tromey  <tom@tromey.com>
6875
6876         * psymtab.h: Update comment.
6877
6878 2020-02-11  Tom Tromey  <tom@tromey.com>
6879
6880         * gdb_obstack.h (struct auto_obstack): Use
6881         DISABLE_COPY_AND_ASSIGN.
6882
6883 2020-02-11  Tom Tromey  <tom@tromey.com>
6884
6885         * dwarf2/frame.h (struct objfile): Don't forward declare.
6886
6887 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
6888
6889         * cris-tdep.c (cris_supply_gregset): Change signature to match
6890         what struct regset expects.
6891         (cris_regset): New struct.
6892         (fetch_core_registers): Remove.
6893         (cris_iterate_over_regset_sections): New function.
6894         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
6895         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
6896
6897 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
6898
6899         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
6900         registers.
6901
6902 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
6903
6904         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
6905
6906 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
6907
6908         * configure: Re-generate.
6909
6910 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
6911
6912         * configure: Re-generate.
6913
6914 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
6915
6916         * acinclude: Update warning.m4 path.
6917         * warning.m4: Move to gdbsupport.
6918
6919 2020-02-11  Tom Tromey  <tromey@adacore.com>
6920
6921         * remote.c (remote_console_output): Update.
6922         * printcmd.c (printf_command): Update.
6923         * event-loop.c (gdb_wait_for_event): Update.
6924         * linux-nat.c (sigchld_handler): Update.
6925         * remote-sim.c (gdb_os_write_stdout): Update.
6926         (gdb_os_flush_stdout): Update.
6927         (gdb_os_flush_stderr): Update.
6928         (gdb_os_write_stderr): Update.
6929         * exceptions.c (print_exception): Update.
6930         * remote-fileio.c (remote_fileio_func_read): Update.
6931         (remote_fileio_func_write): Update.
6932         * tui/tui.c (tui_enable): Update.
6933         * tui/tui-interp.c (tui_interp::init): Update.
6934         * utils.c (init_page_info): Update.
6935         (putchar_unfiltered, fputc_unfiltered): Update.
6936         (gdb_flush): Update.
6937         (emit_style_escape): Update.
6938         (flush_wrap_buffer, fputs_maybe_filtered): Update.
6939         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
6940         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
6941         (stderr_file::write): Update.
6942         (stderr_file::puts): Update.
6943         * ui-file.h (ui_file_isatty, ui_file_write)
6944         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
6945         (ui_file_puts): Don't declare.
6946
6947 2020-02-10  Tom de Vries  <tdevries@suse.de>
6948
6949         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
6950         sentinel to char *.
6951
6952 2020-02-09  Tom de Vries  <tdevries@suse.de>
6953
6954         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
6955         filename if it matches "<artificial>".
6956
6957 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
6958
6959         * windows-tdep.c (struct enum_value_name): New struct.
6960         (create_enum): New function.
6961         (windows_get_siginfo_type): Create and use enum types.
6962
6963 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
6964
6965         * NEWS: Mention $_siginfo support for Windows.
6966         * windows-nat.c (handle_exception): Set siginfo_er.
6967         (windows_nat_target::mourn_inferior): Reset siginfo_er.
6968         (windows_xfer_siginfo): New function.
6969         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
6970         * windows-tdep.c (struct windows_gdbarch_data): New struct.
6971         (init_windows_gdbarch_data): New function.
6972         (get_windows_gdbarch_data): New function.
6973         (windows_get_siginfo_type): New function.
6974         (windows_init_abi): Register windows_get_siginfo_type.
6975         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
6976
6977 2020-02-08  Tom Tromey  <tom@tromey.com>
6978
6979         * dwarf2/read.c (class cutu_reader) <cutu_reader,
6980         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
6981         <keep>: Declare method.
6982         <m_keep>: Remove member.
6983         <~cutu_reader>: Remove.
6984         (cutu_reader::init_tu_and_read_dwo_dies): Update.
6985         (cutu_reader::cutu_reader): Update.
6986         (cutu_reader::keep): Rename from ~cutu_reader.
6987         (process_psymtab_comp_unit, build_type_psymtabs_1)
6988         (process_skeletonless_type_unit, load_partial_comp_unit)
6989         (load_full_comp_unit, dwarf2_read_addr_index)
6990         (read_signatured_type): Update.
6991
6992 2020-02-08  Tom Tromey  <tom@tromey.com>
6993
6994         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
6995         "want_partial_unit" parameter.
6996         (process_psymtab_comp_unit): Change want_partial_unit to bool.
6997         Inline check for DW_TAG_partial_unit.
6998         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
6999
7000 2020-02-08  Tom Tromey  <tom@tromey.com>
7001
7002         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
7003         read.c.
7004         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
7005         read.c.
7006
7007 2020-02-08  Tom Tromey  <tom@tromey.com>
7008
7009         * dwarf2/read.c (read_address): Move to comp-unit.c.
7010         (dwarf2_rnglists_process, dwarf2_ranges_process)
7011         (read_attribute_value, dwarf_decode_lines_1)
7012         (var_decode_location, decode_locdesc): Update.
7013         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
7014         read.c.  Remove "cu" parameter.
7015         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
7016         method.
7017
7018 2020-02-08  Tom Tromey  <tom@tromey.com>
7019
7020         * dwarf2/read.c (read_attribute_value, read_indirect_string)
7021         (read_indirect_line_string): Update.
7022         * dwarf2/comp-unit.c (read_offset): Remove.
7023         (read_comp_unit_head): Update.
7024         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
7025         method.
7026         (read_offset): Don't declare.
7027
7028 2020-02-08  Tom Tromey  <tom@tromey.com>
7029
7030         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
7031         * dwarf2/read.c (struct comp_unit_head): Move to
7032         dwarf2/comp-unit.h.
7033         (enum class rcuh_kind): Move to comp-unit.h.
7034         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
7035         (read_comp_unit_head, error_check_comp_unit_head)
7036         (read_and_check_comp_unit_head): Move to comp-unit.c.
7037         (read_offset, dwarf_unit_type_name): Likewise.
7038         (create_debug_type_hash_table, read_cutu_die_from_dwo)
7039         (cutu_reader::cutu_reader, read_call_site_scope)
7040         (find_partial_die, follow_die_offset): Update.
7041         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
7042
7043 2020-02-08  Tom Tromey  <tom@tromey.com>
7044
7045         * dwarf2/read.c (read_offset_1): Move to leb.c.
7046         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
7047         (dwarf_decode_macro_bytes): Update.
7048         * dwarf2/leb.c (read_offset): Rename; move from read.c.
7049         * dwarf2/leb.h (read_offset): Declare.
7050
7051 2020-02-08  Tom Tromey  <tom@tromey.com>
7052
7053         * dwarf2/read.c (dwarf2_section_size): Remove.
7054         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
7055         Update.
7056         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
7057
7058 2020-02-08  Tom Tromey  <tom@tromey.com>
7059
7060         * dwarf2/read.c (read_initial_length): Move to leb.c.
7061         * dwarf2/leb.h (read_initial_length): Declare.
7062         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
7063         handle_nonstd parameter.
7064         * dwarf2/frame.c (read_initial_length): Remove.
7065         (decode_frame_entry_1): Update.
7066
7067 2020-02-08  Tom Tromey  <tom@tromey.com>
7068
7069         * dwarf2/loc.c (dwarf2_find_location_expression)
7070         (dwarf_evaluate_loc_desc::get_tls_address)
7071         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
7072         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
7073         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
7074         (dwarf2_compile_property_to_c)
7075         (dwarf2_loc_desc_get_symbol_read_needs)
7076         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
7077         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
7078         (loclist_describe_location, loclist_tracepoint_var_ref)
7079         (loclist_generate_c_location): Update.
7080         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
7081         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
7082         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
7083         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
7084         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
7085         (dwarf2_per_cu_data::addr_size)
7086         (dwarf2_per_cu_data::ref_addr_size)
7087         (dwarf2_per_cu_data::text_offset)
7088         (dwarf2_per_cu_data::addr_type): Now methods.
7089         (per_cu_header_read_in): Make per_cu "const".
7090         (dwarf2_version): Remove.
7091         (dwarf2_per_cu_data::int_type): Now a method.
7092         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
7093         (set_die_type, read_array_type, read_subrange_index_type)
7094         (read_tag_string_type, read_subrange_type): Update.
7095         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
7096         offset_size, ref_addr_size, text_offset, addr_type, version,
7097         objfile, int_type, addr_sized_int_type>: Declare methods.
7098
7099 2020-02-08  Tom Tromey  <tom@tromey.com>
7100
7101         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
7102         Move earlier.
7103
7104 2020-02-08  Tom Tromey  <tom@tromey.com>
7105
7106         * dwarf2/read.h (dwarf_line_debug): Declare.
7107         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
7108         * dwarf2/read.c: Move line_header code to new files.
7109         (dwarf_line_debug): No longer static.
7110         * dwarf2/line-header.c: New file.
7111         * dwarf2/line-header.h: New file.
7112
7113 2020-02-08  Tom Tromey  <tom@tromey.com>
7114
7115         * dwarf2/read.c (struct line_header) <file_full_name,
7116         file_file_name>: Return unique_xmalloc_ptr.
7117         (line_header::file_file_name): Update.
7118         (line_header::file_full_name): Update.
7119         (dw2_get_file_names_reader): Update.
7120         (macro_start_file): Update.
7121
7122 2020-02-08  Tom Tromey  <tom@tromey.com>
7123
7124         * dwarf2/read.c (struct line_header) <file_full_name,
7125         file_file_name>: Declare methods.
7126         (dw2_get_file_names_reader): Update.
7127         (file_file_name): Now a method.
7128         (file_full_name): Likewise.
7129         (macro_start_file): Update.
7130
7131 2020-02-08  Tom Tromey  <tom@tromey.com>
7132
7133         * dwarf2/read.c (dwarf_always_disassemble)
7134         (show_dwarf_always_disassemble): Move to loc.c.
7135         (_initialize_dwarf2_read): Move "always-disassemble" registration
7136         to loc.c.
7137         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
7138         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
7139         static.
7140         (show_dwarf_always_disassemble): Move from read.c.
7141         (_initialize_dwarf2loc): Move always-disassemble from read.c.
7142
7143 2020-02-08  Tom Tromey  <tom@tromey.com>
7144
7145         * dwarf2/read.c (~dwarf2_per_objfile): Update.
7146         (create_quick_file_names_table): Return htab_up.
7147         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
7148         Update.
7149         * dwarf2/read.h (struct dwarf2_per_objfile)
7150         <quick_file_names_table>: Now htab_up.
7151
7152 2020-02-08  Tom Tromey  <tom@tromey.com>
7153
7154         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
7155
7156 2020-02-08  Tom Tromey  <tom@tromey.com>
7157
7158         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
7159         Rewrite.
7160         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
7161         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
7162         (abbrev_table::abbrev_table): No longer inline.
7163         (ABBREV_HASH_SIZE): Remove.
7164         (abbrev_table::m_abbrevs): Now an htab_up.
7165
7166 2020-02-08  Tom Tromey  <tom@tromey.com>
7167
7168         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
7169         (cutu_reader): Update.
7170         (build_type_psymtabs_1): Update.
7171         * dwarf2/abbrev.c (abbrev_table::read): Rename.
7172         (abbrev_table::alloc_abbrev): Update.
7173         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
7174         (abbrev_table::read): New static method, renamed from
7175         abbrev_table_read_table.
7176         (abbrev_table::alloc_abbrev)
7177         (abbrev_table::add_abbrev): Now private.
7178         (abbrev_table::abbrev_table): Now private.
7179         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
7180
7181 2020-02-08  Tom Tromey  <tom@tromey.com>
7182
7183         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
7184         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
7185         htab_up.
7186
7187 2020-02-08  Tom Tromey  <tom@tromey.com>
7188
7189         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
7190         htab_up.
7191         (lookup_dwo_unit_in_dwp): Update.
7192         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
7193         on obstack.
7194
7195 2020-02-08  Tom Tromey  <tom@tromey.com>
7196
7197         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
7198         obstack.
7199
7200 2020-02-08  Tom Tromey  <tom@tromey.com>
7201
7202         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
7203         line_header_hash.
7204         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
7205         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
7206         Change type to htab_up.
7207
7208 2020-02-08  Tom Tromey  <tom@tromey.com>
7209
7210         * dwarf2/read.c (allocate_type_unit_groups_table): Return
7211         htab_up.  Don't allocate on obstack.
7212         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
7213         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
7214         Change type to htab_up.
7215
7216 2020-02-08  Tom Tromey  <tom@tromey.com>
7217
7218         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
7219         Change type to htab_up.
7220         * dwarf2/read.c (create_signatured_type_table_from_index)
7221         (create_signatured_type_table_from_debug_names)
7222         (create_all_type_units, add_type_unit)
7223         (lookup_dwo_signatured_type, lookup_signatured_type)
7224         (process_skeletonless_type_unit): Update.
7225         (create_debug_type_hash_table, create_debug_types_hash_table):
7226         Change type of types_htab.
7227         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
7228         htab_up.  Don't allocate on obstack.
7229         (create_cus_hash_table): Change type of cus_htab parameter.
7230         (struct dwo_file) <cus, tus>: Now htab_up.
7231         (lookup_dwo_signatured_type, lookup_dwo_cutu)
7232         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
7233         (queue_and_load_all_dwo_tus): Update.
7234         * dwarf2/index-write.c (write_gdbindex): Update.
7235         (write_debug_names): Update.
7236
7237 2020-02-08  Tom Tromey  <tom@tromey.com>
7238
7239         * dwarf2/read.h (struct dwarf2_queue_item): Move from
7240         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
7241         destructor.
7242         (struct dwarf2_per_objfile) <queue>: New member.
7243         * dwarf2/read.c (struct dwarf2_queue_item): Move to
7244         dwarf2/read.h.
7245         (dwarf2_queue, dwarf2_queue_tail): Remove.
7246         (class dwarf2_queue_guard): Add parameter to constructor.  Use
7247         DISABLE_COPY_AND_ASSIGN.
7248         <m_per_objfile>: New member.
7249         <~dwarf2_queue_guard>: Rewrite.
7250         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
7251         Update.
7252         (~dwarf2_queue_item): New.
7253
7254 2020-02-08  Tom Tromey  <tom@tromey.com>
7255
7256         * dwarf2/read.c (struct die_info) <has_children>: New member.
7257         (dw2_get_file_names_reader): Remove has_children.
7258         (dw2_get_file_names): Update.
7259         (read_cutu_die_from_dwo): Remove has_children.
7260         (cutu_reader::init_tu_and_read_dwo_dies)
7261         (cutu_reader::cutu_reader): Update.
7262         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
7263         Remove has_children.
7264         (build_type_psymtabs_1, process_skeletonless_type_unit)
7265         (load_partial_comp_unit, load_full_comp_unit): Update.
7266         (create_dwo_cu_reader): Remove has_children.
7267         (create_cus_hash_table, read_die_and_children): Update.
7268         (read_full_die_1,read_full_die): Remove has_children.
7269         (read_signatured_type): Update.
7270         (class cutu_reader) <has_children>: Remove.
7271
7272 2020-02-08  Tom Tromey  <tom@tromey.com>
7273
7274         * dwarf2/expr.c: Rename from dwarf2expr.c.
7275         * dwarf2/expr.h: Rename from dwarf2expr.h.
7276         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
7277         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
7278         * dwarf2/frame.c: Rename from dwarf2-frame.c.
7279         * dwarf2/frame.h: Rename from dwarf2-frame.h.
7280         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
7281         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
7282         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
7283         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
7284         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
7285         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
7286         * dwarf2/loc.c: Rename from dwarf2loc.c.
7287         * dwarf2/loc.h: Rename from dwarf2loc.h.
7288         * dwarf2/read.c: Rename from dwarf2read.c.
7289         * dwarf2/read.h: Rename from dwarf2read.h.
7290         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
7291         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
7292         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
7293         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
7294         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
7295         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
7296         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
7297         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
7298         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
7299         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
7300         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
7301         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
7302         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
7303         Update.
7304         * Makefile.in (COMMON_SFILES): Update.
7305         (HFILES_NO_SRCDIR): Update.
7306
7307 2020-02-08  Tom Tromey  <tom@tromey.com>
7308
7309         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
7310         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
7311
7312 2020-02-08  Tom Tromey  <tom@tromey.com>
7313
7314         * dwarf2read.h (struct die_info): Don't declare.
7315
7316 2020-02-08  Tom Tromey  <tom@tromey.com>
7317
7318         * dwarf2read.h (die_info_ptr): Remove typedef.
7319
7320 2020-02-08  Tom Tromey  <tom@tromey.com>
7321
7322         * dwarf2read.c (read_call_site_scope)
7323         (handle_data_member_location, dwarf2_add_member_fn)
7324         (mark_common_block_symbol_computed, read_common_block)
7325         (attr_to_dynamic_prop, partial_die_info::read)
7326         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
7327         (dwarf2_symbol_mark_computed, set_die_type): Update.
7328         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
7329         method.
7330         (attr_form_is_block): Don't declare.
7331         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
7332
7333 2020-02-08  Tom Tromey  <tom@tromey.com>
7334
7335         * dwarf2read.c (dwarf2_find_base_address, )
7336         (read_call_site_scope, rust_containing_type)
7337         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
7338         (handle_data_member_location, dwarf2_add_member_fn)
7339         (get_alignment, read_structure_type, process_structure_scope)
7340         (mark_common_block_symbol_computed, read_common_block)
7341         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
7342         (partial_die_info::read, read_attribute_value, new_symbol)
7343         (lookup_die_type, dwarf2_get_ref_die_offset)
7344         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
7345         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
7346         (dwarf2_symbol_mark_computed): Update.
7347         * dwarf2/attribute.h (struct attribute) <value_as_address,
7348         form_is_section_offset, form_is_constant, form_is_ref>: Declare
7349         methods.
7350         (value_as_address, attr_form_is_section_offset)
7351         (attr_form_is_constant, attr_form_is_ref): Don't declare.
7352         * dwarf2/attribute.c (attribute::value_as_address)
7353         (attribute::form_is_section_offset, attribute::form_is_constant)
7354         (attribute::form_is_ref): Now methods.
7355
7356 2020-02-08  Tom Tromey  <tom@tromey.com>
7357
7358         * dwarf2read.c (struct attribute, DW_STRING)
7359         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
7360         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
7361         (attr_form_is_block, attr_form_is_section_offset)
7362         (attr_form_is_constant, attr_form_is_ref): Move.
7363         * dwarf2/attribute.h: New file.
7364         * dwarf2/attribute.c: New file, from dwarf2read.c.
7365         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
7366
7367 2020-02-08  Tom Tromey  <tom@tromey.com>
7368
7369         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
7370         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
7371         Move.
7372         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
7373         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
7374         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
7375         abbrev.c.
7376         * dwarf2/abbrev.h: New file.
7377         * dwarf2/abbrev.c: New file, from dwarf2read.c.
7378         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
7379
7380 2020-02-08  Tom Tromey  <tom@tromey.com>
7381
7382         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
7383         (dwarf2_section_size, dwarf2_get_section_info)
7384         (create_signatured_type_table_from_debug_names)
7385         (create_addrmap_from_aranges, read_debug_names_from_section)
7386         (get_gdb_index_contents_from_section, read_comp_unit_head)
7387         (error_check_comp_unit_head, read_abbrev_offset)
7388         (create_debug_type_hash_table, init_cu_die_reader)
7389         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
7390         (read_comp_units_from_section, create_cus_hash_table)
7391         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
7392         (create_dwp_v2_section, dwarf2_rnglists_process)
7393         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
7394         (abbrev_table_read_table, read_indirect_string_at_offset_from)
7395         (read_indirect_string_from_dwz, read_addr_index_1)
7396         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
7397         (dwarf_decode_macro_bytes, dwarf_decode_macros)
7398         (fill_in_loclist_baton): Update.
7399         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
7400         get_containing_section, get_bfd_owner, get_bfd_section,
7401         get_file_name, get_id, get_flags, empty, read>: Declare methods.
7402         (dwarf2_read_section, get_section_name, get_section_file_name)
7403         (get_containing_section, get_section_bfd_owner)
7404         (get_section_bfd_section, get_section_name, get_section_file_name)
7405         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
7406         declare.
7407         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
7408         (dwarf2_section_info::get_bfd_owner)
7409         (dwarf2_section_info::get_bfd_section)
7410         (dwarf2_section_info::get_name)
7411         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
7412         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
7413         (dwarf2_section_info::read): Now methods.
7414         * dwarf-index-write.c (class debug_names): Update.
7415
7416 2020-02-08  Tom Tromey  <tom@tromey.com>
7417
7418         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
7419         Move to dwarf2/section.h.
7420         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
7421         (get_section_bfd_section, get_section_name)
7422         (get_section_file_name, get_section_id, get_section_flags)
7423         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
7424         dwarf2/section.c.
7425         * dwarf2/section.h: New file.
7426         * dwarf2/section.c: New file, from dwarf2read.c.
7427         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
7428
7429 2020-02-08  Tom Tromey  <tom@tromey.com>
7430
7431         * dwarf2read.h (read_unsigned_leb128): Don't declare.
7432         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
7433         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
7434         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
7435         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
7436         * dwarf2/leb.h: New file, from dwarf2read.c.
7437         * dwarf2/leb.c: New file, from dwarf2read.c.
7438         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
7439         Remove.
7440         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
7441         (COMMON_SFILES): Add dwarf2/leb.c.
7442
7443 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
7444
7445         GDB 9.1 released.
7446
7447 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
7448
7449         PR gdb/25190:
7450         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
7451         * gdb/remote.c (remote_console_output): Update.
7452         * gdb/ui-file.c (fputs_unfiltered): Rename to...
7453         (ui_file_puts): ...this.
7454         * gdb/ui-file.h (ui_file_puts): Add declaration.
7455         * gdb/utils.c (emit_style_escape): Update.
7456         (flush_wrap_buffer): Update.
7457         (fputs_maybe_filtered): Update.
7458         (fputs_unfiltered): Add function.
7459
7460 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
7461
7462         * gdb/event-loop.c (gdb_wait_for_event): Update.
7463         * gdb/printcmd.c (printf_command): Update.
7464         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
7465         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
7466         (gdb_os_flush_stderr): Update.
7467         * gdb/remote.c (remote_console_output): Update.
7468         * gdb/ui-file.c (gdb_flush): Rename to...
7469         (ui_file_flush): ...this.
7470         (stderr_file::write): Update.
7471         (stderr_file::puts): Update.
7472         * gdb/ui-file.h (gdb_flush): Rename to...
7473         (ui_file_flush): ...this.
7474         * gdb/utils.c (gdb_flush): Add function.
7475         * gdb/utils.h (gdb_flush): Add declaration.
7476
7477 2020-02-07  Tom Tromey  <tromey@adacore.com>
7478
7479         PR breakpoints/24915:
7480         * source.c (find_and_open_source): Do not check basenames_may_differ.
7481
7482 2020-02-07  Tom Tromey  <tom@tromey.com>
7483
7484         * README: Update gdbserver documentation.
7485         * gdbserver: Move to top level.
7486         * configure.tgt (build_gdbserver): Remove.
7487         * configure.ac: Remove --enable-gdbserver.
7488         * configure: Rebuild.
7489         * Makefile.in (distclean): Don't mention gdbserver.
7490
7491 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
7492
7493         * source-cache.c (source_cache::ensure): Surround
7494         get_plain_source_lines with a try/catch.
7495         (source_cache::get_line_charpos): Get rid of try/catch
7496         and only check for the return value of "ensure".
7497         * tui/tui-source.c (tui_source_window::set_contents):
7498         Simplify "nlines" calculation.
7499
7500 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
7501
7502         * MAINTAINERS (Write After Approval): Add myself.
7503
7504 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
7505
7506         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
7507         function call.
7508
7509 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
7510
7511         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
7512
7513 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
7514
7515         * nat/riscv-linux-tdesc.h: New file.
7516         * nat/riscv-linux-tdesc.c: New file, taking code from...
7517         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
7518         ... here.
7519         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
7520         NATDEPFILES.
7521
7522 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
7523
7524         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
7525         we don't set the fake simulator ptid to the null_ptid.
7526
7527 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
7528
7529         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
7530         * gdbthread.h (class thread_info) <resumed>: Likewise.
7531         * infrun.c (resume_1): Likewise.
7532         (proceed): Likewise.
7533         (infrun_thread_stop_requested): Likewise.
7534         (stop_all_threads): Likewise.
7535         (handle_inferior_event): Likewise.
7536         (restart_threads): Likewise.
7537         (finish_step_over): Likewise.
7538         (keep_going_stepped_thread): Likewise.
7539         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
7540         (linux_handle_extended_wait): Likewise.
7541         * record-btrace.c (get_thread_current_frame_id): Likewise.
7542         * record-full.c (record_full_wait_1): Likewise.
7543         * remote.c (remote_target::process_initial_stop_replies): Likewise.
7544         * target.c (target_resume): Likewise.
7545         * thread.c (set_running_thread): Likewise.
7546
7547 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
7548
7549         * f-valprint.c (f77_print_array_1): Changed datatype of index
7550         variable to LONGEST from int to enable it to contain bound
7551         values correctly.
7552
7553 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
7554
7555         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
7556         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
7557         offsets according to FLEN determined.
7558         (riscv_linux_nat_target::read_description): Determine FLEN
7559         dynamically.
7560         (riscv_linux_nat_target::fetch_registers): Size regset buffer
7561         according to FLEN determined.
7562         (riscv_linux_nat_target::store_registers): Likewise.
7563
7564 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
7565
7566         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
7567         when reg->group is empty and reggroup is not.
7568
7569 2020-01-31  Tom Tromey  <tromey@adacore.com>
7570
7571         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
7572         Call beneath target's mourn_inferior after unpushing.
7573
7574 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
7575
7576         PR tui/9765
7577         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
7578         have enough lines to fill the screen, still return the lowest
7579         address we found.
7580
7581 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
7582
7583         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
7584         '-', '<', and '>' commands.
7585
7586 2020-01-29  Pedro Alves  <palves@redhat.com>
7587             Sergio Durigan Junior  <sergiodj@redhat.com>
7588
7589         * infcmd.c (construct_inferior_arguments): Assert that
7590         'argc' is greater than 0.
7591
7592 2020-01-29  Luis Machado  <luis.machado@linaro.org>
7593
7594         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
7595         (BRK_INSN_MASK): Define to 0xd4200000.
7596         (aarch64_program_breakpoint_here_p): New function.
7597         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
7598         * arch-utils.c (default_program_breakpoint_here_p): Moved from
7599         breakpoint.c.
7600         * arch-utils.h (default_program_breakpoint_here_p): Moved from
7601         breakpoint.h
7602         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
7603         call gdbarch_program_breakpoint_here_p.
7604         (program_breakpoint_here): Moved to arch-utils.c, renamed to
7605         default_program_breakpoint_here_p, changed return type to bool and
7606         simplified.
7607         * breakpoint.h (program_breakpoint_here): Moved prototype to
7608         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
7609         return type to bool.
7610         * gdbarch.c: Regenerate.
7611         * gdbarch.h: Regenerate.
7612         * gdbarch.sh (program_breakpoint_here_p): New method.
7613         * infrun.c (handle_signal_stop): Call
7614         gdbarch_program_breakpoint_here_p.
7615
7616 2020-01-26  Tom Tromey  <tom@tromey.com>
7617
7618         * ctfread.c (struct ctf_fp_info): Reindent.
7619         (_initialize_ctfread): Remove.
7620
7621 2020-01-26  Tom Tromey  <tom@tromey.com>
7622
7623         * psymtab.c (partial_map_expand_apply)
7624         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
7625         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
7626         (psym_print_stats, psym_expand_symtabs_for_function)
7627         (psym_map_symbol_filenames, psym_map_matching_symbols)
7628         (psym_expand_symtabs_matching)
7629         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
7630         (maintenance_check_psymtabs): Use new methods.
7631         * psympriv.h (struct partial_symtab) <readin_p,
7632         get_compunit_symtab>: New methods.
7633         <readin, compunit_symtab>: Remove members.
7634         (struct standard_psymtab): New.
7635         (struct legacy_psymtab): Derive from standard_psymtab.
7636         * dwarf2read.h (struct dwarf2_psymtab): Derive from
7637         standard_psymtab.
7638         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
7639
7640 2020-01-26  Tom Tromey  <tom@tromey.com>
7641
7642         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
7643         read_dependencies.  Add assert.
7644         * psymtab.c (partial_symtab::read_dependencies): New method.
7645         * psympriv.h (struct partial_symtab) <read_dependencies>: New
7646         method.
7647         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
7648         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
7649         read_dependencies.
7650         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
7651         Add assert.
7652
7653 2020-01-26  Tom Tromey  <tom@tromey.com>
7654
7655         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
7656         Call expand_psymtab.
7657         (xcoff_read_symtab): Call expand_psymtab.
7658         (xcoff_start_psymtab, xcoff_end_psymtab): Set
7659         legacy_expand_psymtab.
7660         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
7661         method.
7662         (struct legacy_psymtab) <expand_psymtab>: Implement.
7663         <legacy_expand_psymtab>: New member.
7664         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
7665         (parse_partial_symbols): Set legacy_expand_psymtab.
7666         (psymtab_to_symtab_1): Change argument order.  Call
7667         expand_psymtab.
7668         (new_psymtab): Set legacy_expand_psymtab.
7669         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
7670         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
7671         expand_psymtab.
7672         (dwarf2_psymtab::expand_psymtab): Rename from
7673         psymtab_to_symtab_1.  Call expand_psymtab.
7674         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
7675         (dbx_end_psymtab): Likewise.
7676         (dbx_psymtab_to_symtab_1): Change argument order. Call
7677         expand_psymtab.
7678         (dbx_read_symtab): Call expand_psymtab.
7679         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
7680         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
7681         (ctf_psymtab::read_symtab): Call expand_psymtab.
7682
7683 2020-01-26  Tom Tromey  <tom@tromey.com>
7684
7685         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
7686         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
7687         messages.
7688         * mdebugread.c (mdebug_read_symtab): Remove prints.
7689         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
7690         assert.
7691         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
7692
7693 2020-01-26  Tom Tromey  <tom@tromey.com>
7694
7695         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
7696         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
7697         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
7698         legacy_symtab.
7699         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
7700         * psymtab.c (psymtab_to_symtab): Call method.
7701         (dump_psymtab): Update.
7702         * psympriv.h (struct partial_symtab): Add virtual destructor.
7703         <read_symtab>: New method.
7704         (struct legacy_symtab): New.
7705         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
7706         (struct pst_map) <pst>: Now a legacy_psymtab.
7707         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
7708         (new_psymtab): Use legacy_psymtab.
7709         * dwarf2read.h (struct dwarf2_psymtab): New.
7710         (struct dwarf2_per_cu_data) <psymtab>: Use it.
7711         * dwarf2read.c (dwarf2_create_include_psymtab)
7712         (dwarf2_build_include_psymtabs, create_type_unit_group)
7713         (create_partial_symtab, process_psymtab_comp_unit_reader)
7714         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
7715         (set_partial_user): Use dwarf2_psymtab.
7716         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
7717         (psymtab_to_symtab_1, process_full_comp_unit)
7718         (process_full_type_unit, dwarf2_ranges_read)
7719         (dwarf2_get_pc_bounds, psymtab_include_file_name)
7720         (dwarf_decode_lines): Use dwarf2_psymtab.
7721         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
7722         (add_address_entry_worker, write_one_signatured_type)
7723         (recursively_count_psymbols, recursively_write_psymbols)
7724         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
7725         (write_debug_names): Likewise.
7726         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
7727         <pst>: Now a legacy_psymtab.
7728         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
7729         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
7730         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
7731         * ctfread.c (struct ctf_psymtab): New.
7732         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
7733         ctf_psymtab.
7734         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
7735         (create_partial_symtab): Return a ctf_psymtab.
7736         (scan_partial_symbols): Update.
7737
7738 2020-01-26  Tom Tromey  <tom@tromey.com>
7739
7740         * xcoffread.c (xcoff_start_psymtab): Use new.
7741         * psymtab.c (partial_symtab::partial_symtab): New constructor,
7742         renamed from start_psymtab_common.
7743         * psympriv.h (struct partial_symtab): Add new constructor.
7744         (start_psymtab_common): Don't declare.
7745         * mdebugread.c (parse_partial_symbols): Use new.
7746         * dwarf2read.c (create_partial_symtab): Use new.
7747         * dbxread.c (start_psymtab): Use new.
7748         * ctfread.c (create_partial_symtab): Use new.
7749
7750 2020-01-26  Tom Tromey  <tom@tromey.com>
7751
7752         * xcoffread.c (xcoff_end_psymtab): Use new.
7753         * psymtab.c (start_psymtab_common): Use new.
7754         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
7755         Update.
7756         * psympriv.h (struct partial_symtab): Add parameters to
7757         constructor.  Don't inline.
7758         (allocate_psymtab): Don't declare.
7759         * mdebugread.c (new_psymtab): Use new.
7760         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
7761         * dbxread.c (dbx_end_psymtab): Use new.
7762
7763 2020-01-26  Tom Tromey  <tom@tromey.com>
7764
7765         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
7766         allocate_psymtab.  Update documentation.
7767         * psymtab.c (psymtab_storage::install_psymtab): Rename from
7768         allocate_psymtab.  Do not use new.
7769         (allocate_psymtab): Use new.  Update.
7770
7771 2020-01-26  Tom Tromey  <tom@tromey.com>
7772
7773         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
7774         * psymtab.c (psym_print_stats): Update.
7775         * psympriv.h (struct partial_symtab) <readin,
7776         psymtabs_addrmap_supported, anonymous>: Now bool.
7777         * mdebugread.c (psymtab_to_symtab_1): Update.
7778         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
7779         (build_type_psymtabs_reader, psymtab_to_symtab_1)
7780         (process_full_comp_unit, process_full_type_unit): Update.
7781         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
7782         * ctfread.c (psymtab_to_symtab): Update.
7783
7784 2020-01-26  Tom Tromey  <tom@tromey.com>
7785
7786         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
7787         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
7788         * psymtab.c (psymtab_storage): Delete psymtabs.
7789         (psymtab_storage::allocate_psymtab): Use new.
7790         (psymtab_storage::discard_psymtab): Use delete.
7791         * psympriv.h (struct partial_symtab): Add constructor and
7792         initializers.
7793
7794 2020-01-26  Tom Tromey  <tom@tromey.com>
7795
7796         * machoread.c: Do not include psympriv.h.
7797
7798 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7799
7800         * NEWS: Mention the new option and the set/show commands.
7801
7802 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7803
7804         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
7805         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
7806         (validate_exec_file): New variables, enums, functions.
7807         (exec_file_locate_attach, print_section_info): Style the filenames.
7808         (_initialize_exec): Install show_exec_file_mismatch_command and
7809          set_exec_file_mismatch_command.
7810         * gdbcore.h (validate_exec_file): Declare.
7811         * infcmd.c (attach_command): Call validate_exec_file.
7812         * remote.c ( remote_target::remote_add_inferior): Likewise.
7813
7814 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7815
7816         * frame.c (find_frame_sal): Move call to get_next_frame into more
7817         inner scope.
7818         * inline-frame.c (inilne_state) <inline_state>: Update argument
7819         types.
7820         (inilne_state) <skipped_symbol>: Rename to...
7821         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
7822         (skip_inline_frames): Build vector of skipped symbols and use this
7823         to reate the inline_state.
7824         (inline_skipped_symbol): Add a comment and some assertions, fetch
7825         skipped symbol from the list.
7826
7827 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7828
7829         * buildsym.c (lte_is_less_than): Delete.
7830         (buildsym_compunit::end_symtab_with_blockvector): Create local
7831         lambda function to sort line table entries, and use
7832         std::stable_sort instead of std::sort.
7833         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
7834         markers when looking for a previous line.
7835
7836 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7837
7838         * dwarf2read.c (lnp_state_machine::record_line): Include
7839         end_sequence parameter in debug print out.  Record the line if we
7840         are at an end_sequence marker even if it's not the start of a
7841         statement.
7842         * symmisc.c (maintenance_print_one_line_table): Print end of
7843         sequence markers with 'END' not '0'.
7844
7845 2020-01-24  Pedro Alves  <palves@redhat.com>
7846
7847         PR gdb/25410
7848         * thread.c (scoped_restore_current_thread::restore): Use
7849         switch_to_inferior_no_thread.
7850         * exec.c: Include "progspace-and-thread.h".
7851         (add_target_sections, remove_target_sections):
7852         scoped_restore_current_pspace_and_thread instead of
7853         scoped_restore_current_thread.
7854         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
7855         and aspace to the inferior before calling clone_program_space.
7856         Remove stale comment.
7857
7858 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
7859
7860         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
7861         (arm_netbsd_nat_target::fetch_registers): ...this.
7862         (arm_nbsd_nat_target::store_registers): Rename to...
7863         (arm_netbsd_nat_target::store_registers): ...this.
7864
7865 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
7866
7867         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
7868         register_t.
7869
7870 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
7871
7872         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
7873         Update comment.
7874         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
7875         Likewise.
7876         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
7877         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
7878         the correct replacement (iterate_over_regset_sections).
7879         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
7880         Update comment.
7881
7882 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
7883
7884         PR gdb/23718
7885         * gdb/python/python.c (execute_gdb_command): Call
7886         async_enable_stdin in catch block.
7887
7888 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7889
7890         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
7891         SWITCH_THRU_ALL_UIS.
7892
7893 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7894
7895         PR tui/9765
7896         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
7897         comment, add extra parameter, and update to store previous symbol
7898         when appropriate.
7899         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
7900         add extra parameter.
7901         * tui/tui-disasm.c (tui_disassemble): Update header comment,
7902         remove unneeded parameter, add try/catch around gdb_print_insn,
7903         rewrite to add items to asm_lines vector.
7904         (tui_find_backward_disassembly_start_address): New function.
7905         (tui_find_disassembly_address): Updated throughout.
7906         (tui_disasm_window::set_contents): Update for changes to
7907         tui_disassemble.
7908         (tui_disasm_window::do_scroll_vertical): No need to adjust the
7909         number of lines to scroll.
7910
7911 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
7912
7913         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
7914         (SECT_OFF_DATA): Likewise.
7915         (SECT_OFF_RODATA): Likewise.
7916         (SECT_OFF_TEXT): Likewise.
7917         (SECT_OFF_BSS): Likewise.
7918         (struct objfile) <text_section_offset, data_section_offset>: New
7919         methods.
7920         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
7921         objfile::text_section_offset.
7922         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
7923         * coffread.c (coff_symtab_read): Likewise.
7924         (enter_linenos): Likewise.
7925         (process_coff_symbol): Likewise.
7926         * ctfread.c (get_objfile_text_range): Likewise.
7927         * dtrace-probe.c (dtrace_probe::get_relocated_address):
7928         Use objfile::data_section_offset.
7929         * dwarf2-frame.c (execute_cfa_program): Use
7930         objfile::text_section_offset.
7931         (dwarf2_frame_find_fde): Likewise.
7932         * dwarf2read.c (create_addrmap_from_index): Likewise.
7933         (create_addrmap_from_aranges): Likewise.
7934         (dw2_find_pc_sect_compunit_symtab): Likewise.
7935         (process_psymtab_comp_unit_reader): Likewise.
7936         (add_partial_symbol): Likewise.
7937         (add_partial_subprogram): Likewise.
7938         (process_full_comp_unit): Likewise.
7939         (read_file_scope): Likewise.
7940         (read_func_scope): Likewise.
7941         (read_lexical_block_scope): Likewise.
7942         (read_call_site_scope): Likewise.
7943         (dwarf2_rnglists_process): Likewise.
7944         (dwarf2_ranges_process): Likewise.
7945         (dwarf2_ranges_read): Likewise.
7946         (dwarf_decode_lines_1): Likewise.
7947         (new_symbol): Likewise.
7948         (dwarf2_fetch_die_loc_sect_off): Likewise.
7949         (dwarf2_per_cu_text_offset): Likewise.
7950         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
7951         * hppa-tdep.c (read_unwind_info): Likewise.
7952         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
7953         * psympriv.h (struct partial_symtab): Likewise.
7954         * psymtab.c (find_pc_sect_psymtab): Likewise.
7955         * solib-svr4.c (enable_break): Likewise.
7956         * stap-probe.c (relocate_address): Use
7957         objfile::data_section_offset.
7958         * xcoffread.c (enter_line_range): Use
7959         objfile::text_section_offset.
7960         (read_xcoff_symtab): Likewise.
7961
7962 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
7963
7964         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
7965         declaration to narrower scopes.
7966
7967 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
7968
7969         * darwin-nat.h (struct darwin_exception_msg, enum
7970         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
7971         Move up.
7972         (class darwin_nat_target) <wait_1, check_new_threads,
7973         decode_exception_message, decode_message, stop_inferior,
7974         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
7975         * darwin-nat.c (darwin_check_new_threads): Rename to...
7976         (darwin_nat_target::check_new_threads): ... this.
7977         (darwin_suspend_inferior_it): Remove.
7978         (darwin_decode_exception_message): Rename to...
7979         (darwin_nat_target::decode_exception_message): ... this.
7980         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
7981         (darwin_decode_message): Rename to...
7982         (darwin_nat_target::decode_message): ... this.
7983         (cancel_breakpoint): Rename to...
7984         (darwin_nat_target::cancel_breakpoint): ... this.
7985         (darwin_wait): Rename to...
7986         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
7987         instead of iterate_over_inferiors.
7988         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
7989         (darwin_stop_inferior): Rename to...
7990         (darwin_nat_target::stop_inferior): ... this.
7991         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
7992         (darwin_init_thread_list): Rename to...
7993         (darwin_nat_target::init_thread_list): ... this.
7994         (darwin_ptrace_him): Rename to...
7995         (darwin_nat_target::ptrace_him): ... this.
7996         (darwin_nat_target::create_inferior): Pass lambda function to
7997         fork_inferior.
7998         (darwin_nat_target::detach): Call stop_inferior instead of
7999         darwin_stop_inferior.
8000         * fork-inferior.h (fork_inferior): Change init_trace_fun
8001         parameter to gdb::function_view.
8002         * fork-inferior.c (fork_inferior): Likewise.
8003
8004 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
8005
8006         * i386-cygwin-tdep.c (core_process_module_section): Update.
8007         * windows-nat.c (struct lm_info_windows): Add text_offset.
8008         (windows_xfer_shared_libraries): Update.
8009         * windows-tdep.c (windows_xfer_shared_library):
8010         Add text_offset_cached argument.
8011         * windows-tdep.h (windows_xfer_shared_library): Update.
8012
8013 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8014
8015         * gdbarch.sh: Add declaration for _initialize_gdbarch.
8016
8017 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8018
8019         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
8020         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
8021         replace with range-based for.
8022         (gdbsim_interrupt_inferior): Remove.
8023         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
8024         with a range-based for.  Inline code from
8025         gdbsim_interrupt_inferior.
8026
8027 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8028
8029         * infrun.c (proceed): Fix indentation.
8030
8031 2020-01-21  Tom Tromey  <tromey@adacore.com>
8032
8033         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
8034         * python/python.c (python_extension_ops): Update.
8035         (gdbpy_colorize): New function.
8036         * python/lib/gdb/__init__.py (colorize): New function.
8037         * extension.h (ext_lang_colorize): Declare.
8038         * extension.c (ext_lang_colorize): New function.
8039         * extension-priv.h (struct extension_language_ops) <colorize>: New
8040         member.
8041         * cli/cli-style.c (_initialize_cli_style): Update help text.
8042
8043 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8044
8045         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
8046         <cond>: Change type to bool.
8047         (aarch64_displaced_step_b_cond): Update cond to use bool type.
8048         (aarch64_displaced_step_cb): Likewise.
8049         (aarch64_displaced_step_tb): Likewise.
8050
8051 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8052
8053         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
8054         output.
8055
8056 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8057
8058         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
8059         <pc_adjust>: Adjust the documentation.
8060         (aarch64_displaced_step_fixup): Check if PC really moved before
8061         adjusting it.
8062
8063 2020-01-19  Tom Tromey  <tom@tromey.com>
8064
8065         * disasm.c (~gdb_disassembler): New destructor.
8066         (gdb_buffered_insn_length): Call disassemble_free_target.
8067         * disasm.h (class gdb_disassembler): Declare destructor.  Use
8068         DISABLE_COPY_AND_ASSIGN.
8069
8070 2020-01-19  Tom Tromey  <tom@tromey.com>
8071
8072         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
8073         (die_reader_func_ftype): Remove.
8074         (cutu_reader): New class.
8075         (dw2_get_file_names_reader): Remove "data" parameter.
8076         (dw2_get_file_names): Use cutu_reader.
8077         (create_debug_type_hash_table): Update.
8078         (read_cutu_die_from_dwo): Update comment.
8079         (lookup_dwo_unit): Add dwo_name parameter.
8080         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
8081         die_reader_func_ftype and data parameters.
8082         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
8083         Remove die_reader_func_ftype and data parameters.
8084         (~cutu_reader): New; from init_cutu_and_read_dies.
8085         (cutu_reader::cutu_reader): Rename from
8086         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
8087         and data parameters.
8088         (init_cutu_and_read_dies_simple): Remove.
8089         (struct process_psymtab_comp_unit_data): Remove.
8090         (process_psymtab_comp_unit_reader): Remove data parameter; add
8091         want_partial_unit and pretend_language parameters.
8092         (process_psymtab_comp_unit): Use cutu_reader.
8093         (build_type_psymtabs_reader): Remove data parameter.
8094         (build_type_psymtabs_1): Use cutu_reader.
8095         (process_skeletonless_type_unit): Likewise.
8096         (load_partial_comp_unit_reader): Remove.
8097         (load_partial_comp_unit): Use cutu_reader.
8098         (load_full_comp_unit_reader): Remove.
8099         (load_full_comp_unit): Use cutu_reader.
8100         (struct create_dwo_cu_data): Remove.
8101         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
8102         dwo_unit parameters.
8103         (create_cus_hash_table): Use cutu_reader.
8104         (struct dwarf2_read_addr_index_data): Remove.
8105         (dwarf2_read_addr_index_reader): Remove.
8106         (dwarf2_read_addr_index): Use cutu_reader.
8107         (read_signatured_type_reader): Remove.
8108         (read_signatured_type): Use cutu_reader.
8109
8110 2020-01-19  Tom Tromey  <tom@tromey.com>
8111
8112         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
8113         * tui/tui-wingeneral.h (class tui_suppress_output): New.
8114         (tui_wrefresh): Declare.
8115         * tui/tui-wingeneral.c (suppress_output): New global.
8116         (tui_suppress_output, ~tui_suppress_output): New constructor and
8117         destructor.
8118         (tui_wrefresh): New function.
8119         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
8120         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
8121         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
8122         method.
8123         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
8124         tui_wrefresh.
8125         (tui_data_window::no_refresh): New method.
8126         (tui_data_item_window::refresh_window): Call tui_wrefresh.
8127         (tui_reg_command): Use tui_suppress_output
8128         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
8129         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
8130         method.
8131         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
8132
8133 2020-01-19  Tom Tromey  <tom@tromey.com>
8134
8135         * tui/tui-winsource.c (tui_update_source_windows_with_line):
8136         Handle case where symtab is null.
8137
8138 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
8139
8140         * linux-fork.c (one_fork_p): Simplify.
8141
8142 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8143
8144         * top.c (struct qt_args): Remove.
8145         (kill_or_detach): Change return type to void, replace `void *`
8146         parameter with a proper one.
8147         (print_inferior_quit_action):  Likewise.
8148         (quit_confirm): Use range-based for loop to iterate over inferiors.
8149         (quit_force): Likewise.
8150
8151 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8152
8153         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
8154         `void *` parameter with proper parameters.
8155         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
8156         (print_one_inferior): Change return type to void, replace `void *`
8157         parameter with proper parameters.
8158         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
8159         inferiors.
8160         (get_other_inferior): Remove.
8161         (mi_cmd_remove_inferior): Use range-based loop to iterate over
8162         inferiors.
8163
8164 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8165
8166         * mi/mi-interp.c (report_initial_inferior): Remove.
8167         (mi_interp::init): Use range-based for to iterate over inferiors.
8168
8169 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8170
8171         * python/py-inferior.c (build_inferior_list): Remove.
8172         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
8173
8174 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
8175
8176         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
8177         (btrace_stitch_trace): Likewise.
8178         * charset.c (intermediate_encoding): Likewise (vaild).
8179         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
8180         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
8181         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
8182
8183 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
8184
8185         * windows-tdep.c (windows_get_tlb_type):
8186         Add rtl_user_process_parameters type.
8187
8188 2020-01-16  Pedro Alves  <palves@redhat.com>
8189             Norbert Lange  <nolange79@gmail.com>
8190
8191         PR build/24805
8192         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
8193         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
8194         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
8195         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
8196         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
8197         (ps_plog): Redeclare exported functions with default visibility.
8198
8199 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
8200
8201         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
8202         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
8203
8204 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
8205
8206         * infcmd.c (post_create_inferior): Use get_thread_regcache
8207         instead of get_current_regcache.
8208
8209 2020-01-14  Tom Tromey  <tom@tromey.com>
8210
8211         PR symtab/12535:
8212         * python/python.c (gdbpy_decode_line): Treat empty string the same
8213         as no argument.
8214
8215 2020-01-14  Tom Tromey  <tom@tromey.com>
8216
8217         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
8218
8219 2020-01-14  Tom Tromey  <tom@tromey.com>
8220
8221         * nat/linux-btrace.c: Don't include <config.h>.
8222         * nat/linux-ptrace.c: Don't include <config.h>.
8223         * nat/x86-linux-dregs.c: Don't include <config.h>.
8224
8225 2020-01-14  Tom Tromey  <tom@tromey.com>
8226
8227         * configure: Rebuild.
8228         * configure.ac: Move many checks to ../gdbsupport/common.m4.
8229
8230 2020-01-14  Tom Tromey  <tom@tromey.com>
8231
8232         * nat/x86-linux-dregs.c: Include configh.h.
8233         * nat/linux-ptrace.c: Include configh.h.
8234         * nat/linux-btrace.c: Include configh.h.
8235         * defs.h: Include config.h, bfd.h.
8236         * configure.ac: Don't source common.host.
8237         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
8238         * configure: Rebuild.
8239         * acinclude.m4: Update path.
8240         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
8241         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
8242         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
8243         (CLIBS): Add LIBSUPPORT.
8244         (CDEPS): Likewise.
8245         (COMMON_SFILES): Remove gdbsupport files.
8246         (HFILES_NO_SRCDIR): Likewise.
8247         (stamp-version): Update path to create-version.sh.
8248         (ALLDEPFILES): Remove gdbsupport files.
8249
8250 2020-01-14  Tom Tromey  <tom@tromey.com>
8251
8252         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
8253         USE_WIN32API when needed.
8254         * configure.ac (USE_WIN32API): Don't define.
8255         (WIN32LIBS): Use WIN32APILIBS.
8256         * configure: Rebuild.
8257
8258 2020-01-14  Tom Tromey  <tom@tromey.com>
8259
8260         * configure: Rebuild.
8261         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
8262
8263 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
8264
8265         * skip.c (skip_function_command): Make skip w/o arguments use the
8266         name of the inlined function if pc is inside any inlined function.
8267
8268 2020-01-14  Luis Machado  <luis.machado@linaro.org>
8269
8270         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
8271         * infrun.c (resume_1): Likewise.
8272         (handle_inferior_event): Remove stale comment.
8273         * linux-nat.c (linux_nat_target::resume): Update comments.
8274         (save_stop_reason): Likewise.
8275         (linux_nat_filter_event): Likewise.
8276         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
8277
8278 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8279
8280         * elfread.c (record_minimal_symbol): Set section index to 0 for
8281         non-allocatable sections.
8282
8283
8284 2020-01-13  Ali Tamur <tamur@google.com>
8285
8286         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
8287         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
8288         to gdb::optional.  Update comments.
8289         (dwo_file): Update comments.
8290         (read_attribute): Update API to take an additional out parameter,
8291         need_reprocess.  This is used to mark attributes that need other
8292         attributes (e.g. str_offsets_base) for correct computation which may not
8293         have been read yet.
8294         (read_attribute_reprocess): New function declaration.
8295         (read_addr_index): Likewise.
8296         (read_dwo_str_index): Likewise.
8297         (read_stub_str_index): Likewise.
8298         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
8299         (lookup_addr_base): New function definition.
8300         (lookup_ranges_base): Likewise.
8301         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
8302         lookup_ranges_base.
8303         (init_cutu_and_read_dies): Update comments.
8304         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
8305         unit.  This is used to inherit parent's str_offsets_base and addr_base.
8306         Update comments.
8307         (init_cutu_and_read_dies_simple): Reflect API changes.
8308         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
8309         (create_cus_hash_table): Change API to take parent compile unit.
8310         Reflect API changes.
8311         (open_and_init_dwo_file): Reflect API changes.
8312         (dwarf2_get_pc_bounds): Update comments.
8313         (dwarf2_record_block_ranges): Likewise.
8314         (read_full_die_1): Change implementation to reprocess attributes that
8315         need str_offsets_base and addr_base.
8316         (partial_die_info::read): Likewise.
8317         (read_attribute_reprocess): New function definition.
8318         (read_attribute_value): Change API to take an additional out parameter,
8319         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
8320         when a non-dwo compile unit has index based attributes.
8321         (read_attribute): Reflect API changes.
8322         (read_addr_index_1): Reflect API changes.  Update comments.
8323         (dwarf2_read_addr_index_data): Reflect API changes.
8324         (dwarf2_read_addr_index): Likewise.
8325         (read_str_index): Change API and implementation.  This becomes a helper
8326         to be used by the new string index related methods.  Update error
8327         message and comments.
8328         (read_dwo_str_index): New function definition.
8329         (read_stub_str_index): Likewise.
8330         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
8331         * symfile.h (dwarf2_debug_sections): Likewise.
8332         * xcoffread.c (dwarf2_debug_sections): Likewise.
8333
8334 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8335
8336         * gdbcore.h (struct core_fns) <core_read_registers>: Change
8337         core_reg_sect type to gdb_byte *.
8338         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
8339         * cris-tdep.c (fetch_core_registers): Likewise.
8340         * corelow.c (core_target::get_core_register_section): Change
8341         type of `contents` to gdb::byte_vector.
8342
8343 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8344
8345         * tui/tui-wingeneral.c (box_win): Position the title in the center
8346         of the border.
8347
8348 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
8349
8350         * corelow.c (core_target::get_core_register_section): Use
8351           std::vector instead of alloca.
8352
8353 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8354
8355         * warning.m4: Add -Wmissing-declarations to build_warnings.
8356         * configure: Re-generate.
8357
8358 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8359
8360         * python/python.c (init__gdb_module): Add declaration.
8361
8362 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8363
8364         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
8365         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
8366         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
8367         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
8368         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
8369         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
8370         * ada-exp.y (_initialize_ada_exp): Add declaration.
8371         * ada-lang.c (_initialize_ada_language): Add declaration.
8372         * ada-tasks.c (_initialize_tasks): Add declaration.
8373         * agent.c (_initialize_agent): Add declaration.
8374         * aix-thread.c (_initialize_aix_thread): Add declaration.
8375         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
8376         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
8377         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
8378         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
8379         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
8380         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
8381         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
8382         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
8383         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
8384         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
8385         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
8386         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
8387         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
8388         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
8389         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
8390         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
8391         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
8392         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
8393         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
8394         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
8395         * annotate.c (_initialize_annotate): Add declaration.
8396         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
8397         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
8398         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
8399         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
8400         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
8401         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
8402         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
8403         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
8404         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
8405         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
8406         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
8407         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
8408         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
8409         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
8410         * auto-load.c (_initialize_auto_load): Add declaration.
8411         * auxv.c (_initialize_auxv): Add declaration.
8412         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
8413         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
8414         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
8415         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
8416         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
8417         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
8418         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
8419         * breakpoint.c (_initialize_breakpoint): Add declaration.
8420         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
8421         * btrace.c (_initialize_btrace): Add declaration.
8422         * charset.c (_initialize_charset): Add declaration.
8423         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
8424         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
8425         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
8426         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
8427         * cli/cli-script.c (_initialize_cli_script): Add declaration.
8428         * cli/cli-style.c (_initialize_cli_style): Add declaration.
8429         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
8430         * coffread.c (_initialize_coffread): Add declaration.
8431         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
8432         * compile/compile.c (_initialize_compile): Add declaration.
8433         * complaints.c (_initialize_complaints): Add declaration.
8434         * completer.c (_initialize_completer): Add declaration.
8435         * copying.c (_initialize_copying): Add declaration.
8436         * corefile.c (_initialize_core): Add declaration.
8437         * corelow.c (_initialize_corelow): Add declaration.
8438         * cp-abi.c (_initialize_cp_abi): Add declaration.
8439         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
8440         * cp-support.c (_initialize_cp_support): Add declaration.
8441         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
8442         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
8443         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
8444         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
8445         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
8446         * ctfread.c (_initialize_ctfread): Add declaration.
8447         * d-lang.c (_initialize_d_language): Add declaration.
8448         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
8449         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
8450         * dbxread.c (_initialize_dbxread): Add declaration.
8451         * dcache.c (_initialize_dcache): Add declaration.
8452         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
8453         * disasm.c (_initialize_disasm): Add declaration.
8454         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
8455         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
8456         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
8457         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
8458         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
8459         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
8460         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
8461         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
8462         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
8463         * elfread.c (_initialize_elfread): Add declaration.
8464         * exec.c (_initialize_exec): Add declaration.
8465         * extension.c (_initialize_extension): Add declaration.
8466         * f-lang.c (_initialize_f_language): Add declaration.
8467         * f-valprint.c (_initialize_f_valprint): Add declaration.
8468         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
8469         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
8470         * filesystem.c (_initialize_filesystem): Add declaration.
8471         * findcmd.c (_initialize_mem_search): Add declaration.
8472         * findvar.c (_initialize_findvar): Add declaration.
8473         * fork-child.c (_initialize_fork_child): Add declaration.
8474         * frame-base.c (_initialize_frame_base): Add declaration.
8475         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
8476         * frame.c (_initialize_frame): Add declaration.
8477         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
8478         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
8479         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
8480         * gcore.c (_initialize_gcore): Add declaration.
8481         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
8482         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
8483         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
8484         * gdbarch.c (_initialize_gdbarch): Add declaration.
8485         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
8486         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
8487         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
8488         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
8489         * go-lang.c (_initialize_go_language): Add declaration.
8490         * go32-nat.c (_initialize_go32_nat): Add declaration.
8491         * guile/guile.c (_initialize_guile): Add declaration.
8492         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
8493         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
8494         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
8495         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
8496         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
8497         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
8498         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
8499         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
8500         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
8501         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
8502         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
8503         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
8504         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
8505         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
8506         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
8507         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
8508         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
8509         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
8510         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
8511         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
8512         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
8513         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
8514         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
8515         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
8516         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
8517         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
8518         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
8519         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
8520         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
8521         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
8522         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
8523         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
8524         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
8525         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
8526         * infcall.c (_initialize_infcall): Add declaration.
8527         * infcmd.c (_initialize_infcmd): Add declaration.
8528         * inflow.c (_initialize_inflow): Add declaration.
8529         * infrun.c (_initialize_infrun): Add declaration.
8530         * interps.c (_initialize_interpreter): Add declaration.
8531         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
8532         * jit.c (_initialize_jit): Add declaration.
8533         * language.c (_initialize_language): Add declaration.
8534         * linux-fork.c (_initialize_linux_fork): Add declaration.
8535         * linux-nat.c (_initialize_linux_nat): Add declaration.
8536         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
8537         * linux-thread-db.c (_initialize_thread_db): Add declaration.
8538         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
8539         * m2-lang.c (_initialize_m2_language): Add declaration.
8540         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
8541         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
8542         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
8543         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
8544         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
8545         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
8546         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
8547         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
8548         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
8549         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
8550         * machoread.c (_initialize_machoread): Add declaration.
8551         * macrocmd.c (_initialize_macrocmd): Add declaration.
8552         * macroscope.c (_initialize_macroscope): Add declaration.
8553         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
8554         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
8555         * maint.c (_initialize_maint_cmds): Add declaration.
8556         * mdebugread.c (_initialize_mdebugread): Add declaration.
8557         * memattr.c (_initialize_mem): Add declaration.
8558         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
8559         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
8560         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
8561         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
8562         * mi/mi-main.c (_initialize_mi_main): Add declaration.
8563         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
8564         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
8565         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
8566         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
8567         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
8568         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
8569         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
8570         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
8571         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
8572         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
8573         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
8574         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
8575         * mipsread.c (_initialize_mipsread): Add declaration.
8576         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
8577         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
8578         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
8579         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
8580         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
8581         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
8582         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
8583         * nto-procfs.c (_initialize_procfs): Add declaration.
8584         * objc-lang.c (_initialize_objc_language): Add declaration.
8585         * observable.c (_initialize_observer): Add declaration.
8586         * opencl-lang.c (_initialize_opencl_language): Add declaration.
8587         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
8588         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
8589         * osabi.c (_initialize_gdb_osabi): Add declaration.
8590         * osdata.c (_initialize_osdata): Add declaration.
8591         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
8592         * parse.c (_initialize_parse): Add declaration.
8593         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
8594         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
8595         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
8596         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
8597         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
8598         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
8599         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
8600         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
8601         * printcmd.c (_initialize_printcmd): Add declaration.
8602         * probe.c (_initialize_probe): Add declaration.
8603         * proc-api.c (_initialize_proc_api): Add declaration.
8604         * proc-events.c (_initialize_proc_events): Add declaration.
8605         * proc-service.c (_initialize_proc_service): Add declaration.
8606         * procfs.c (_initialize_procfs): Add declaration.
8607         * producer.c (_initialize_producer): Add declaration.
8608         * psymtab.c (_initialize_psymtab): Add declaration.
8609         * python/python.c (_initialize_python): Add declaration.
8610         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
8611         * record-btrace.c (_initialize_record_btrace): Add declaration.
8612         * record-full.c (_initialize_record_full): Add declaration.
8613         * record.c (_initialize_record): Add declaration.
8614         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
8615         * regcache.c (_initialize_regcache): Add declaration.
8616         * reggroups.c (_initialize_reggroup): Add declaration.
8617         * remote-notif.c (_initialize_notif): Add declaration.
8618         * remote-sim.c (_initialize_remote_sim): Add declaration.
8619         * remote.c (_initialize_remote): Add declaration.
8620         * reverse.c (_initialize_reverse): Add declaration.
8621         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
8622         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
8623         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
8624         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
8625         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
8626         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
8627         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
8628         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
8629         Add declaration.
8630         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
8631         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
8632         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
8633         * rust-exp.y (_initialize_rust_exp): Add declaration.
8634         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
8635         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
8636         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
8637         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
8638         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
8639         * score-tdep.c (_initialize_score_tdep): Add declaration.
8640         * ser-go32.c (_initialize_ser_dos): Add declaration.
8641         * ser-mingw.c (_initialize_ser_windows): Add declaration.
8642         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
8643         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
8644         * ser-uds.c (_initialize_ser_socket): Add declaration.
8645         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
8646         * serial.c (_initialize_serial): Add declaration.
8647         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
8648         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
8649         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
8650         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
8651         * skip.c (_initialize_step_skip): Add declaration.
8652         * sol-thread.c (_initialize_sol_thread): Add declaration.
8653         * solib-aix.c (_initialize_solib_aix): Add declaration.
8654         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
8655         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
8656         * solib-frv.c (_initialize_frv_solib): Add declaration.
8657         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
8658         * solib-target.c (_initialize_solib_target): Add declaration.
8659         * solib.c (_initialize_solib): Add declaration.
8660         * source-cache.c (_initialize_source_cache): Add declaration.
8661         * source.c (_initialize_source): Add declaration.
8662         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
8663         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
8664         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
8665         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
8666         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
8667         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
8668         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
8669         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
8670         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
8671         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
8672         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
8673         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
8674         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
8675         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
8676         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
8677         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
8678         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
8679         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
8680         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
8681         * stabsread.c (_initialize_stabsread): Add declaration.
8682         * stack.c (_initialize_stack): Add declaration.
8683         * stap-probe.c (_initialize_stap_probe): Add declaration.
8684         * std-regs.c (_initialize_frame_reg): Add declaration.
8685         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
8686         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
8687         * symfile.c (_initialize_symfile): Add declaration.
8688         * symmisc.c (_initialize_symmisc): Add declaration.
8689         * symtab.c (_initialize_symtab): Add declaration.
8690         * target.c (_initialize_target): Add declaration.
8691         * target-connection.c (_initialize_target_connection): Add
8692         declaration.
8693         * target-dcache.c (_initialize_target_dcache): Add declaration.
8694         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
8695         * thread.c (_initialize_thread): Add declaration.
8696         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
8697         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
8698         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
8699         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
8700         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
8701         * tracectf.c (_initialize_ctf): Add declaration.
8702         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
8703         * tracefile.c (_initialize_tracefile): Add declaration.
8704         * tracepoint.c (_initialize_tracepoint): Add declaration.
8705         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
8706         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
8707         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
8708         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
8709         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
8710         * tui/tui-win.c (_initialize_tui_win): Add declaration.
8711         * tui/tui.c (_initialize_tui): Add declaration.
8712         * typeprint.c (_initialize_typeprint): Add declaration.
8713         * ui-style.c (_initialize_ui_style): Add declaration.
8714         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
8715         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
8716         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
8717         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
8718         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
8719         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
8720         * unittests/filtered_iterator-selftests.c
8721         (_initialize_filtered_iterator_selftests): Add declaration.
8722         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
8723         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
8724         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
8725         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
8726         * unittests/main-thread-selftests.c
8727         (_initialize_main_thread_selftests): Add declaration.
8728         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
8729         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
8730         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
8731         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
8732         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
8733         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
8734         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
8735         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
8736         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
8737         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
8738         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
8739         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
8740         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
8741         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
8742         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
8743         declaration.
8744         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
8745         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
8746         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
8747         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
8748         * user-regs.c (_initialize_user_regs): Add declaration.
8749         * utils.c (_initialize_utils): Add declaration.
8750         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
8751         * valops.c (_initialize_valops): Add declaration.
8752         * valprint.c (_initialize_valprint): Add declaration.
8753         * value.c (_initialize_values): Add declaration.
8754         * varobj.c (_initialize_varobj): Add declaration.
8755         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
8756         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
8757         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
8758         * windows-nat.c (_initialize_windows_nat): Add declaration.
8759         (_initialize_check_for_gdb_ini): Add declaration.
8760         (_initialize_loadable): Add declaration.
8761         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
8762         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
8763         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
8764         * xcoffread.c (_initialize_xcoffread): Add declaration.
8765         * xml-support.c (_initialize_xml_support): Add declaration.
8766         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
8767         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
8768         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
8769         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
8770
8771 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
8772
8773         * regformats/regdat.sh: Generate declaration for init function.
8774
8775 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
8776
8777         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
8778         up.
8779         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
8780         close_one_inferior>: New methods.
8781         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
8782         pass down target to find_inferior_pid.
8783         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
8784         Pass down target to find_inferior_ptid.
8785         (gdbsim_target::create_inferior): Pass down target to
8786         add_thread_silent.
8787         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
8788         target down to find_inferior_ptid and switch_to_thread.
8789         (gdbsim_target::close): Update to call close_one_inferior.
8790         (struct resume_data): Remove.
8791         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
8792         directly, rather than through a void pointer.
8793         (gdbsim_target::resume): Update to call resume_one_inferior.
8794
8795 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
8796
8797         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
8798
8799 2020-01-12  Pedro Alves  <palves@redhat.com>
8800
8801         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
8802         directly for the current inferior instead of
8803         discard_all_inferiors.
8804         (discard_all_inferiors): Delete.
8805
8806 2020-01-11  Tom Tromey  <tom@tromey.com>
8807
8808         * tui/tui-wingeneral.c (box_win): Check cli_styling.
8809         * tui/tui-winsource.c (tui_source_window_base::refill): Use
8810         deprecated_safe_get_selected_frame.
8811
8812 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
8813
8814         * inferior.c (print_inferior): Switch inferior before printing it.
8815
8816 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
8817             Pedro Alves  <palves@redhat.com>
8818
8819         * progspace-and-thread.c (switch_to_program_space_and_thread):
8820         Assert there's an inferior for PSPACE.  Use
8821         switch_to_inferior_no_thread to switch the inferior too.
8822         * progspace.c (program_space::~program_space): Call
8823         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
8824         (program_space::free_all_objfiles): Don't call clear_symtab_users
8825         here.
8826         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
8827
8828 2020-01-10  Pedro Alves  <palves@redhat.com>
8829
8830         * NEWS: Mention multi-target debugging, "info connections", and
8831         "add-inferior -no-connection".
8832
8833 2020-01-10  Pedro Alves  <palves@redhat.com>
8834
8835         * infrun.c: Include "target-connection.h".
8836         (check_multi_target_resumption): New.
8837         (proceed): Call it.
8838         * target-connection.c (make_target_connection_string): Make
8839         extern.
8840         * target-connection.h (make_target_connection_string): Declare.
8841
8842 2020-01-10  Pedro Alves  <palves@redhat.com>
8843
8844         * Makefile.in (COMMON_SFILES): Add target-connection.c.
8845         * inferior.c (uiout_field_connection): New function.
8846         (print_inferior): Add new "connection-id" column.
8847         (add_inferior_command): Show connection number/string of added
8848         inferior.
8849         * process-stratum-target.h
8850         (process_stratum_target::connection_string): New virtual method.
8851         (process_stratum_target::connection_number): New field.
8852         * remote.c (remote_target::connection_string): New override.
8853         * target-connection.c: New file.
8854         * target-connection.h: New file.
8855         * target.c (decref_target): Remove process_stratum targets from
8856         the connection list.
8857         (target_stack::push): Add process_stratum targets to the
8858         connection list.
8859
8860 2020-01-10  Pedro Alves  <palves@redhat.com>
8861
8862         Revert:
8863         2016-04-12  Pedro Alves  <palves@redhat.com>
8864         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
8865         Remove references to name.
8866         * serial.h (struct serial) <name>: Delete.
8867
8868 2020-01-10  Pedro Alves  <palves@redhat.com>
8869
8870         * gdbarch-selftests.c (register_to_value_test): Remove "target
8871         already pushed" check.
8872
8873 2020-01-10  Pedro Alves  <palves@redhat.com>
8874             John Baldwin  <jhb@FreeBSD.org>
8875
8876         * aarch64-linux-nat.c
8877         (aarch64_linux_nat_target::thread_architecture): Adjust.
8878         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
8879         (task_command_1): Likewise.
8880         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
8881         (aix_thread_target::wait, aix_thread_target::fetch_registers)
8882         (aix_thread_target::store_registers)
8883         (aix_thread_target::thread_alive): Adjust.
8884         * amd64-fbsd-tdep.c: Include "inferior.h".
8885         (amd64fbsd_get_thread_local_address): Pass down target.
8886         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
8887         thread's gdbarch instead of target_gdbarch.
8888         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
8889         get_last_target_status.
8890         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
8891         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
8892         inferiors.
8893         (update_inserted_breakpoint_locations): Skip if inferiors with no
8894         execution.
8895         (update_global_location_list): When handling moribund locations,
8896         find representative inferior for location's pspace, and use thread
8897         count of its process_stratum target.
8898         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
8899         * bsd-uthread.c (bsd_uthread_target::wait): Use
8900         as_process_stratum_target and adjust thread_change_ptid and
8901         add_thread calls.
8902         (bsd_uthread_target::update_thread_list): Use
8903         as_process_stratum_target and adjust find_thread_ptid,
8904         thread_change_ptid and add_thread calls.
8905         * btrace.c (maint_btrace_packet_history_cmd): Adjust
8906         find_thread_ptid call.
8907         * corelow.c (add_to_thread_list): Adjust add_thread call.
8908         (core_target_open): Adjust add_thread_silent and thread_count
8909         calls.
8910         (core_target::pid_to_str): Adjust find_inferior_ptid call.
8911         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
8912         * event-top.c (async_disconnect): Pop targets from all inferiors.
8913         * exec.c (add_target_sections): Push exec target on all inferiors
8914         sharing the program space.
8915         (remove_target_sections): Remove the exec target from all
8916         inferiors sharing the program space.
8917         (exec_on_vfork): New.
8918         * exec.h (exec_on_vfork): Declare.
8919         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
8920         Pass it down.
8921         (fbsd_nat_target::update_thread_list): Adjust.
8922         (fbsd_nat_target::resume): Adjust.
8923         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
8924         down.
8925         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
8926         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
8927         get_thread_arch_regcache call.
8928         * fork-child.c (gdb_startup_inferior): Pass target down to
8929         startup_inferior and set_executing.
8930         * gdbthread.h (struct process_stratum_target): Forward declare.
8931         (add_thread, add_thread_silent, add_thread_with_info)
8932         (in_thread_list): Add process_stratum_target parameter.
8933         (find_thread_ptid(inferior*, ptid_t)): New overload.
8934         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
8935         parameter.
8936         (all_threads()): Delete overload.
8937         (all_threads, all_non_exited_threads): Add process_stratum_target
8938         parameter.
8939         (all_threads_safe): Use brace initialization.
8940         (thread_count): Add process_stratum_target parameter.
8941         (set_resumed, set_running, set_stop_requested, set_executing)
8942         (threads_are_executing, finish_thread_state): Add
8943         process_stratum_target parameter.
8944         (switch_to_thread): Use is_current_thread.
8945         * i386-fbsd-tdep.c: Include "inferior.h".
8946         (i386fbsd_get_thread_local_address): Pass down target.
8947         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
8948         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
8949         have_inferiors check.
8950         * inf-ptrace.c (inf_ptrace_target::create_inferior)
8951         (inf_ptrace_target::attach): Adjust.
8952         * infcall.c (run_inferior_call): Adjust.
8953         * infcmd.c (run_command_1): Pass target to
8954         scoped_finish_thread_state.
8955         (proceed_thread_callback): Skip inferiors with no execution.
8956         (continue_command): Rename 'all_threads' local to avoid hiding
8957         'all_threads' function.  Adjust get_last_target_status call.
8958         (prepare_one_step): Adjust set_running call.
8959         (signal_command): Use user_visible_resume_target.  Compare thread
8960         pointers instead of inferior_ptid.
8961         (info_program_command): Adjust to pass down target.
8962         (attach_command): Mark target's 'thread_executing' flag.
8963         (stop_current_target_threads_ns): New, factored out from ...
8964         (interrupt_target_1): ... this.  Switch inferior before making
8965         target calls.
8966         * inferior-iter.h
8967         (struct all_inferiors_iterator, struct all_inferiors_range)
8968         (struct all_inferiors_safe_range)
8969         (struct all_non_exited_inferiors_range): Filter on
8970         process_stratum_target too.  Remove explicit.
8971         * inferior.c (inferior::inferior): Push dummy target on target
8972         stack.
8973         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
8974         Add process_stratum_target parameter, and pass it down.
8975         (have_live_inferiors): Adjust.
8976         (switch_to_inferior_and_push_target): New.
8977         (add_inferior_command, clone_inferior_command): Handle
8978         "-no-connection" parameter.  Use
8979         switch_to_inferior_and_push_target.
8980         (_initialize_inferior): Mention "-no-connection" option in
8981         the help of "add-inferior" and "clone-inferior" commands.
8982         * inferior.h: Include "process-stratum-target.h".
8983         (interrupt_target_1): Use bool.
8984         (struct inferior) <push_target, unpush_target, target_is_pushed,
8985         find_target_beneath, top_target, process_target, target_at,
8986         m_stack>: New.
8987         (discard_all_inferiors): Delete.
8988         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
8989         (all_inferiors, all_non_exited_inferiors): Add
8990         process_stratum_target parameter.
8991         * infrun.c: Include "gdb_select.h" and <unordered_map>.
8992         (target_last_proc_target): New global.
8993         (follow_fork_inferior): Push target on new inferior.  Pass target
8994         to add_thread_silent.  Call exec_on_vfork.  Handle target's
8995         reference count.
8996         (follow_fork): Adjust get_last_target_status call.  Also consider
8997         target.
8998         (follow_exec): Push target on new inferior.
8999         (struct execution_control_state) <target>: New field.
9000         (user_visible_resume_target): New.
9001         (do_target_resume): Call target_async.
9002         (resume_1): Set target's threads_executing flag.  Consider resume
9003         target.
9004         (commit_resume_all_targets): New.
9005         (proceed): Also consider resume target.  Skip threads of inferiors
9006         with no execution.  Commit resumtion in all targets.
9007         (start_remote): Pass current inferior to wait_for_inferior.
9008         (infrun_thread_stop_requested): Consider target as well.  Pass
9009         thread_info pointer to clear_inline_frame_state instead of ptid.
9010         (infrun_thread_thread_exit): Consider target as well.
9011         (random_pending_event_thread): New inferior parameter.  Use it.
9012         (do_target_wait): Rename to ...
9013         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
9014         down.
9015         (threads_are_resumed_pending_p, do_target_wait): New.
9016         (prepare_for_detach): Adjust calls.
9017         (wait_for_inferior): New inferior parameter.  Handle it.  Use
9018         do_target_wait_1 instead of do_target_wait.
9019         (fetch_inferior_event): Adjust.  Switch to representative
9020         inferior.  Pass target down.
9021         (set_last_target_status): Add process_stratum_target parameter.
9022         Save target in global.
9023         (get_last_target_status): Add process_stratum_target parameter and
9024         handle it.
9025         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
9026         (context_switch): Check inferior_ptid == null_ptid before calling
9027         inferior_thread().
9028         (get_inferior_stop_soon): Pass down target.
9029         (wait_one): Rename to ...
9030         (poll_one_curr_target): ... this.
9031         (struct wait_one_event): New.
9032         (wait_one): New.
9033         (stop_all_threads): Adjust.
9034         (handle_no_resumed, handle_inferior_event): Adjust to consider the
9035         event's target.
9036         (switch_back_to_stepped_thread): Also consider target.
9037         (print_stop_event): Update.
9038         (normal_stop): Update.  Also consider the resume target.
9039         * infrun.h (wait_for_inferior): Remove declaration.
9040         (user_visible_resume_target): New declaration.
9041         (get_last_target_status, set_last_target_status): New
9042         process_stratum_target parameter.
9043         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9044         process_stratum_target parameter, and use it.
9045         (clear_inline_frame_state (thread_info*)): New.
9046         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9047         process_stratum_target parameter.
9048         (clear_inline_frame_state (thread_info*)): Declare.
9049         * linux-fork.c (delete_checkpoint_command): Pass target down to
9050         find_thread_ptid.
9051         (checkpoint_command): Adjust.
9052         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
9053         instead of just tweaking inferior_ptid.
9054         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
9055         (exit_lwp): Pass target down to find_thread_ptid.
9056         (attach_proc_task_lwp_callback): Pass target down to
9057         add_thread/set_running/set_executing.
9058         (linux_nat_target::attach): Pass target down to
9059         thread_change_ptid.
9060         (get_detach_signal): Pass target down to find_thread_ptid.
9061         Consider last target status's target.
9062         (linux_resume_one_lwp_throw, resume_lwp)
9063         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
9064         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
9065         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
9066         (linux_nat_target::async_wait_fd): New.
9067         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
9068         target down.
9069         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
9070         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
9071         * linux-thread-db.c (struct thread_db_info::process_target): New
9072         field.
9073         (add_thread_db_info): Save target.
9074         (get_thread_db_info): New process_stratum_target parameter.  Also
9075         match target.
9076         (delete_thread_db_info): New process_stratum_target parameter.
9077         Also match target.
9078         (thread_from_lwp): Adjust to pass down target.
9079         (thread_db_notice_clone): Pass down target.
9080         (check_thread_db_callback): Pass down target.
9081         (try_thread_db_load_1): Always push the thread_db target.
9082         (try_thread_db_load, record_thread): Pass target down.
9083         (thread_db_target::detach): Pass target down.  Always unpush the
9084         thread_db target.
9085         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
9086         target down.  Always unpush the thread_db target.
9087         (find_new_threads_callback, thread_db_find_new_threads_2)
9088         (thread_db_target::update_thread_list): Pass target down.
9089         (thread_db_target::pid_to_str): Pass current inferior down.
9090         (thread_db_target::get_thread_local_address): Pass target down.
9091         (thread_db_target::resume, maintenance_check_libthread_db): Pass
9092         target down.
9093         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
9094         * procfs.c (procfs_target::procfs_init_inferior): Declare.
9095         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
9096         (procfs_init_inferior): Rename to ...
9097         (procfs_target::procfs_init_inferior): ... this and adjust.
9098         (procfs_target::create_inferior, procfs_notice_thread)
9099         (procfs_do_thread_registers): Adjust.
9100         * ppc-fbsd-tdep.c: Include "inferior.h".
9101         (ppcfbsd_get_thread_local_address): Pass down target.
9102         * proc-service.c (ps_xfer_memory): Switch current inferior and
9103         program space as well.
9104         (get_ps_regcache): Pass target down.
9105         * process-stratum-target.c
9106         (process_stratum_target::thread_address_space)
9107         (process_stratum_target::thread_architecture): Pass target down.
9108         * process-stratum-target.h
9109         (process_stratum_target::threads_executing): New field.
9110         (as_process_stratum_target): New.
9111         * ravenscar-thread.c
9112         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
9113         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
9114         down.
9115         * record-btrace.c (record_btrace_target::info_record): Adjust.
9116         (record_btrace_target::record_method)
9117         (record_btrace_target::record_is_replaying)
9118         (record_btrace_target::fetch_registers)
9119         (get_thread_current_frame_id, record_btrace_target::resume)
9120         (record_btrace_target::wait, record_btrace_target::stop): Pass
9121         target down.
9122         * record-full.c (record_full_wait_1): Switch to event thread.
9123         Pass target down.
9124         * regcache.c (regcache::regcache)
9125         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
9126         process_stratum_target parameter and handle it.
9127         (current_thread_target): New global.
9128         (get_thread_regcache): Add process_stratum_target parameter and
9129         handle it.  Switch inferior before calling target method.
9130         (get_thread_regcache): Pass target down.
9131         (get_thread_regcache_for_ptid): Pass target down.
9132         (registers_changed_ptid): Add process_stratum_target parameter and
9133         handle it.
9134         (registers_changed_thread, registers_changed): Pass target down.
9135         (test_get_thread_arch_aspace_regcache): New.
9136         (current_regcache_test): Define a couple local test_target_ops
9137         instances and use them for testing.
9138         (readwrite_regcache): Pass process_stratum_target parameter.
9139         (cooked_read_test, cooked_write_test): Pass mock_target down.
9140         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
9141         (get_thread_arch_aspace_regcache): Add process_stratum_target
9142         parameter.
9143         (regcache::target): New method.
9144         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
9145         (regcache::registers_changed_ptid): Add process_stratum_target
9146         parameter.
9147         (regcache::m_target): New field.
9148         (registers_changed_ptid): Add process_stratum_target parameter.
9149         * remote.c (remote_state::supports_vCont_probed): New field.
9150         (remote_target::async_wait_fd): New method.
9151         (remote_unpush_and_throw): Add remote_target parameter.
9152         (get_current_remote_target): Adjust.
9153         (remote_target::remote_add_inferior): Push target.
9154         (remote_target::remote_add_thread)
9155         (remote_target::remote_notice_new_inferior)
9156         (get_remote_thread_info): Pass target down.
9157         (remote_target::update_thread_list): Skip threads of inferiors
9158         bound to other targets.  (remote_target::close): Don't discard
9159         inferiors.  (remote_target::add_current_inferior_and_thread)
9160         (remote_target::process_initial_stop_replies)
9161         (remote_target::start_remote)
9162         (remote_target::remote_serial_quit_handler): Pass down target.
9163         (remote_target::remote_unpush_target): New remote_target
9164         parameter.  Unpush the target from all inferiors.
9165         (remote_target::remote_unpush_and_throw): New remote_target
9166         parameter.  Pass it down.
9167         (remote_target::open_1): Check whether the current inferior has
9168         execution instead of checking whether any inferior is live.  Pass
9169         target down.
9170         (remote_target::remote_detach_1): Pass down target.  Use
9171         remote_unpush_target.
9172         (extended_remote_target::attach): Pass down target.
9173         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
9174         (remote_target::append_resumption): Pass down target.
9175         (remote_target::append_pending_thread_resumptions)
9176         (remote_target::remote_resume_with_hc, remote_target::resume)
9177         (remote_target::commit_resume): Pass down target.
9178         (remote_target::remote_stop_ns): Check supports_vCont_probed.
9179         (remote_target::interrupt_query)
9180         (remote_target::remove_new_fork_children)
9181         (remote_target::check_pending_events_prevent_wildcard_vcont)
9182         (remote_target::remote_parse_stop_reply)
9183         (remote_target::process_stop_reply): Pass down target.
9184         (first_remote_resumed_thread): New remote_target parameter.  Pass
9185         it down.
9186         (remote_target::wait_as): Pass down target.
9187         (unpush_and_perror): New remote_target parameter.  Pass it down.
9188         (remote_target::readchar, remote_target::remote_serial_write)
9189         (remote_target::getpkt_or_notif_sane_1)
9190         (remote_target::kill_new_fork_children, remote_target::kill): Pass
9191         down target.
9192         (remote_target::mourn_inferior): Pass down target.  Use
9193         remote_unpush_target.
9194         (remote_target::core_of_thread)
9195         (remote_target::remote_btrace_maybe_reopen): Pass down target.
9196         (remote_target::pid_to_exec_file)
9197         (remote_target::thread_handle_to_thread_info): Pass down target.
9198         (remote_target::async_wait_fd): New.
9199         * riscv-fbsd-tdep.c: Include "inferior.h".
9200         (riscv_fbsd_get_thread_local_address): Pass down target.
9201         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
9202         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
9203         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
9204         Adjust.
9205         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
9206         * solib-svr4.c (enable_break): Pass down target.
9207         * spu-multiarch.c (parse_spufs_run): Pass down target.
9208         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
9209         * target-delegates.c: Regenerate.
9210         * target.c (g_target_stack): Delete.
9211         (current_top_target): Return the current inferior's top target.
9212         (target_has_execution_1): Refer to the passed-in inferior's top
9213         target.
9214         (target_supports_terminal_ours): Check whether the initial
9215         inferior was already created.
9216         (decref_target): New.
9217         (target_stack::push): Incref/decref the target.
9218         (push_target, push_target, unpush_target): Adjust.
9219         (target_stack::unpush): Defref target.
9220         (target_is_pushed): Return bool.  Adjust to refer to the current
9221         inferior's target stack.
9222         (dispose_inferior): Delete, and inline parts ...
9223         (target_preopen): ... here.  Only dispose of the current inferior.
9224         (target_detach): Hold strong target reference while detaching.
9225         Pass target down.
9226         (target_thread_name): Add assertion.
9227         (target_resume): Pass down target.
9228         (target_ops::beneath, find_target_at): Adjust to refer to the
9229         current inferior's target stack.
9230         (get_dummy_target): New.
9231         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
9232         has a thread running.
9233         (initialize_targets): Rename to ...
9234         (_initialize_target): ... this.
9235         * target.h: Include "gdbsupport/refcounted-object.h".
9236         (struct target_ops): Inherit refcounted_object.
9237         (target_ops::shortname, target_ops::longname): Make const.
9238         (target_ops::async_wait_fd): New method.
9239         (decref_target): Declare.
9240         (struct target_ops_ref_policy): New.
9241         (target_ops_ref): New typedef.
9242         (get_dummy_target): Declare function.
9243         (target_is_pushed): Return bool.
9244         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
9245         (all_matching_threads_iterator::all_matching_threads_iterator):
9246         Handle filter target.
9247         * thread-iter.h (struct all_matching_threads_iterator, struct
9248         all_matching_threads_range, class all_non_exited_threads_range):
9249         Filter by target too.  Remove explicit.
9250         * thread.c (threads_executing): Delete.
9251         (inferior_thread): Pass down current inferior.
9252         (clear_thread_inferior_resources): Pass down thread pointer
9253         instead of ptid_t.
9254         (add_thread_silent, add_thread_with_info, add_thread): Add
9255         process_stratum_target parameter.  Use it for thread and inferior
9256         searches.
9257         (is_current_thread): New.
9258         (thread_info::deletable): Use it.
9259         (find_thread_ptid, thread_count, in_thread_list)
9260         (thread_change_ptid, set_resumed, set_running): New
9261         process_stratum_target parameter.  Pass it down.
9262         (set_executing): New process_stratum_target parameter.  Pass it
9263         down.  Adjust reference to 'threads_executing'.
9264         (threads_are_executing): New process_stratum_target parameter.
9265         Adjust reference to 'threads_executing'.
9266         (set_stop_requested, finish_thread_state): New
9267         process_stratum_target parameter.  Pass it down.
9268         (switch_to_thread): Also match inferior.
9269         (switch_to_thread): New process_stratum_target parameter.  Pass it
9270         down.
9271         (update_threads_executing): Reimplement.
9272         * top.c (quit_force): Pop targets from all inferior.
9273         (gdb_init): Don't call initialize_targets.
9274         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
9275         Declare.
9276         (windows_add_thread, windows_delete_thread): Adjust.
9277         (get_windows_debug_event): Rename to ...
9278         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
9279         * tracefile-tfile.c (tfile_target_open): Pass down target.
9280         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
9281         Forward declare.
9282         (switch_to_thread): Add process_stratum_target parameter.
9283         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
9284         parameter.  Use it.
9285         (mi_on_resume): Pass target down.
9286         * nat/fork-inferior.c (startup_inferior): Add
9287         process_stratum_target parameter.  Pass it down.
9288         * nat/fork-inferior.h (startup_inferior): Add
9289         process_stratum_target parameter.
9290         * python/py-threadevent.c (py_get_event_thread): Pass target down.
9291
9292 2020-01-10  Pedro Alves  <palves@redhat.com>
9293
9294         * remote.c (remote_target::start_remote): Don't set inferior_ptid
9295         directly.  Instead find the first thread in the thread list and
9296         use switch_to_thread.
9297
9298 2020-01-10  Pedro Alves  <palves@redhat.com>
9299
9300         * remote.c (remote_target::remote_add_inferior): Don't bind a
9301         process to the current inferior if the current inferior is already
9302         bound to a process.
9303
9304 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
9305             Pedro Alves  <palves@redhat.com>
9306
9307         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
9308         If no process is specified, return null_ptid instead of
9309         inferior_ptid.
9310         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
9311         TARGET_WAITKIND_SIGNALLED with no pid.
9312
9313 2020-01-10  Pedro Alves  <palves@redhat.com>
9314
9315         * remote.c (first_remote_resumed_thread): New.
9316         (remote_target::wait_as): Use it as default event_ptid instead of
9317         inferior_ptid.
9318
9319 2020-01-10  Pedro Alves  <palves@redhat.com>
9320
9321         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
9322
9323 2020-01-10  Pedro Alves  <palves@redhat.com>
9324
9325         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
9326         not -1.
9327
9328 2020-01-10  Pedro Alves  <palves@redhat.com>
9329
9330         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
9331         ptid to get_last_target_status.
9332         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
9333         ptid to get_last_target_status.
9334         * infcmd.c (continue_command): Don't pass a target_waitstatus to
9335         get_last_target_status.
9336         (info_program_command): Don't pass a target_waitstatus to
9337         get_last_target_status.
9338         * infrun.c (init_wait_for_inferior): Use
9339         nullify_last_target_wait_ptid.
9340         (get_last_target_status): Handle nullptr arguments.
9341         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
9342         (print_stop_event): Don't pass a ptid to get_last_target_status.
9343         (normal_stop): Don't pass a ptid to get_last_target_status.
9344         * infrun.h (get_last_target_status, set_last_target_status): Move
9345         comments here and update.
9346         (nullify_last_target_wait_ptid): Declare.
9347         * linux-fork.c (fork_load_infrun_state): Remove local extern
9348         declaration of nullify_last_target_wait_ptid.
9349         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
9350         to get_last_target_status.
9351
9352 2020-01-10  Pedro Alves  <palves@redhat.com>
9353
9354         * gdbthread.h (scoped_restore_current_thread)
9355         <dont_restore, restore, m_dont_restore>: Declare.
9356         * thread.c (thread_alive): Add assertion.  Return bool.
9357         (switch_to_thread_if_alive): New.
9358         (prune_threads): Switch inferior/thread.
9359         (print_thread_info_1): Switch thread before calling target methods.
9360         (scoped_restore_current_thread::restore): New, factored out from
9361         ...
9362         (scoped_restore_current_thread::~scoped_restore_current_thread):
9363         ... this.
9364         (scoped_restore_current_thread::scoped_restore_current_thread):
9365         Add assertion.
9366         (thread_apply_all_command, thread_select): Use
9367         switch_to_thread_if_alive.
9368         * infrun.c (proceed, restart_threads, handle_signal_stop)
9369         (switch_back_to_stepped_thread): Switch current thread before
9370         calling target methods.
9371
9372 2020-01-10  Pedro Alves <palves@redhat.com>
9373
9374         * inferior.c (switch_to_inferior_no_thread): New function,
9375         factored out from ...
9376         (inferior_command): ... here.
9377         * inferior.h (switch_to_inferior_no_thread): Declare.
9378         * mi/mi-main.c (run_one_inferior): Use
9379         switch_to_inferior_no_thread.
9380
9381 2020-01-10  Pedro Alves  <palves@redhat.com>
9382
9383         * infcmd.c (kill_command): Remove dead code.
9384
9385 2020-01-10  Pedro Alves  <palves@redhat.com>
9386
9387         * remote.c (remote_target::mourn_inferior): No longer check
9388         whether the target is running.
9389
9390 2020-01-10  Pedro Alves  <palves@redhat.com>
9391
9392         * corelow.c (core_target::has_execution): Change parameter type to
9393         inferior pointer.
9394         * inferior.c (number_of_live_inferiors): Use
9395         inferior::has_execution instead of target_has_execution_1.
9396         * inferior.h (inferior::has_execution): New.
9397         * linux-thread-db.c (thread_db_target::update_thread_list): Use
9398         inferior::has_execution instead of target_has_execution_1.
9399         * process-stratum-target.c
9400         (process_stratum_target::has_execution): Change parameter type to
9401         inferior pointer.  Check the inferior's PID instead of
9402         inferior_ptid.
9403         * process-stratum-target.h
9404         (process_stratum_target::has_execution): Change parameter type to
9405         inferior pointer.
9406         * record-full.c (record_full_core_target::has_execution): Change
9407         parameter type to inferior pointer.
9408         * target.c (target_has_execution_1): Change parameter type to
9409         inferior pointer.
9410         (target_has_execution_current): Adjust.
9411         * target.h (target_ops::has_execution): Change parameter type to
9412         inferior pointer.
9413         (target_has_execution_1): Change parameter type to inferior
9414         pointer.  Change return type to bool.
9415         * tracefile.h (tracefile_target::has_execution): Change parameter
9416         type to inferior pointer.
9417
9418 2020-01-10  Pedro Alves  <palves@redhat.com>
9419
9420         * exceptions.c (print_flush): Remove current_top_target() check.
9421
9422 2020-01-10  Pedro Alves  <palves@redhat.com>
9423
9424         * remote.c (show_remote_exec_file): Show the current inferior's
9425         exec-file instead of the command variable's value.
9426
9427 2020-01-10  Pedro Alves  <palves@redhat.com>
9428
9429         * record-full.c (record_full_resume_ptid): New global.
9430         (record_full_target::resume): Set it.
9431         (record_full_wait_1): Use record_full_resume_ptid instead of
9432         inferior_ptid.
9433
9434 2020-01-10  Pedro Alves  <palves@redhat.com>
9435
9436         * gdbthread.h (scoped_restore_current_thread)
9437         <dont_restore, restore, m_dont_restore>: Declare.
9438         * thread.c (thread_alive): Add assertion.  Return bool.
9439         (switch_to_thread_if_alive): New.
9440         (prune_threads): Switch inferior/thread.
9441         (print_thread_info_1): Switch thread before calling target methods.
9442         (scoped_restore_current_thread::restore): New, factored out from
9443         ...
9444         (scoped_restore_current_thread::~scoped_restore_current_thread):
9445         ... this.
9446         (scoped_restore_current_thread::scoped_restore_current_thread):
9447         Add assertion.
9448         (thread_apply_all_command, thread_select): Use
9449         switch_to_thread_if_alive.
9450
9451 2020-01-10  George Barrett  <bob@bob131.so>
9452
9453         * stap-probe.c (stap_modify_semaphore): Don't check for null
9454         semaphores.
9455         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
9456         for null semaphores.
9457
9458 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9459
9460         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
9461         all source windows, and maintain horizontal scroll status while
9462         doing so.
9463
9464 2020-01-09  Tom Tromey  <tom@tromey.com>
9465
9466         PR tui/18932:
9467         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
9468         update_source_window, not print_source_lines.
9469
9470 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9471
9472         * tui/tui.c (tui_enable): Register tui hooks after calling
9473         tui_display_main.
9474
9475 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
9476
9477         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
9478
9479 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
9480
9481         * thread.c (print_thread_info_1): Fix indentation.
9482
9483 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
9484
9485         * symtab.c (general_symbol_info::compute_and_set_names): Move the
9486         unique_xmalloc_ptr outside the if to always free the demangled name.
9487
9488 2020-01-08  Tom Tromey  <tromey@adacore.com>
9489
9490         * xcoffread.c (enter_line_range, read_xcoff_symtab)
9491         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
9492         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
9493         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
9494         Remove.
9495         (section_offsets): New typedef.
9496         * symtab.c (fixup_section, get_msymbol_address): Update.
9497         * symmisc.c (dump_msymbols): Update.
9498         * symfile.h (relative_addr_info_to_section_offsets)
9499         (symfile_map_offsets_to_segments): Update.
9500         * symfile.c (build_section_addr_info_from_objfile)
9501         (init_objfile_sect_indices): Update.
9502         (struct place_section_arg): Change type of "offsets".
9503         (place_section): Update.
9504         (relative_addr_info_to_section_offsets): Change type of
9505         "section_offsets".  Remove "num_sections" parameter.
9506         (default_symfile_offsets, syms_from_objfile_1)
9507         (set_objfile_default_section_offset): Update.
9508         (reread_symbols): No need to preserve section offsets by hand.
9509         (symfile_map_offsets_to_segments): Change type of "offsets".
9510         * stap-probe.c (relocate_address): Update.
9511         * stabsread.h (process_one_symbol): Update.
9512         * solib-target.c (struct lm_info_target) <offsets>: Change type.
9513         (solib_target_relocate_section_addresses): Update.
9514         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
9515         Update.
9516         * solib-frv.c (frv_relocate_main_executable): Update.
9517         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
9518         * solib-aix.c (solib_aix_get_section_offsets): Change return
9519         type.
9520         (solib_aix_solib_create_inferior_hook): Update.
9521         * remote.c (remote_target::get_offsets): Update.
9522         * psymtab.c (find_pc_sect_psymtab): Update.
9523         * psympriv.h (struct partial_symbol) <address, text_low,
9524         text_high>: Update.
9525         * objfiles.h (obj_section_offset): Update.
9526         (struct objfile) <section_offsets>: Change type.
9527         <num_sections>: Remove.
9528         (objfile_relocate): Update.
9529         * objfiles.c (entry_point_address_query): Update
9530         (relocate_one_symbol): Change type of "section_offsets".
9531         (objfile_relocate1, objfile_relocate1): Change type of
9532         "new_offsets".
9533         (objfile_rebase1): Update.
9534         * mipsread.c (mipscoff_symfile_read): Update.
9535         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
9536         parameter.
9537         * mdebugread.c (parse_symbol): Change type of "section_offsets".
9538         (parse_external, psymtab_to_symtab_1): Update.
9539         * machoread.c (macho_symfile_offsets): Update.
9540         * ia64-tdep.c (ia64_find_unwind_table): Update.
9541         * hppa-tdep.c (read_unwind_info): Update.
9542         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
9543         * dwarf2read.c (create_addrmap_from_index)
9544         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9545         (process_psymtab_comp_unit_reader, add_partial_symbol)
9546         (add_partial_subprogram, process_full_comp_unit)
9547         (read_file_scope, read_func_scope, read_lexical_block_scope)
9548         (read_call_site_scope, dwarf2_rnglists_process)
9549         (dwarf2_ranges_process, dwarf2_ranges_read)
9550         (dwarf_decode_lines_1, var_decode_location, new_symbol)
9551         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
9552         Update.
9553         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
9554         Update.
9555         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
9556         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
9557         (process_one_symbol): Change type of "section_offsets".
9558         * ctfread.c (get_objfile_text_range): Update.
9559         * coffread.c (coff_symtab_read, enter_linenos)
9560         (process_coff_symbol): Update.
9561         * coff-pe-read.c (add_pe_forwarded_sym): Update.
9562         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
9563
9564 2020-01-08  Tom Tromey  <tromey@adacore.com>
9565
9566         * dwarf2read.c (parse_macro_definition): Use std::string.
9567         (parse_macro_definition): Likewise.
9568
9569 2020-01-08  Tom Tromey  <tromey@adacore.com>
9570
9571         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
9572         (ATTR_ALLOC_CHUNK): Remove.
9573
9574 2020-01-08  Tom Tromey  <tromey@adacore.com>
9575
9576         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
9577
9578 2020-01-08  Tom Tromey  <tromey@adacore.com>
9579
9580         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
9581         (dwarf2_compute_name, open_dwo_file): Likewise.
9582         (process_enumeration_scope): Use std::vector.
9583         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
9584         (partial_die_info::fixup, dwarf2_start_subfile)
9585         (guess_full_die_structure_name, dwarf2_name): Likewise.
9586         (determine_prefix): Update.
9587         (guess_full_die_structure_name): Make return type const.
9588         (partial_die_full_name): Return unique_xmalloc_ptr.
9589         (DW_FIELD_ALLOC_CHUNK): Remove.
9590
9591 2020-01-07  Tom Tromey  <tromey@adacore.com>
9592
9593         PR build/24937:
9594         * stap-probe.c (class stap_static_probe_ops): Add constructor.
9595
9596 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
9597
9598         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
9599
9600 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9601
9602         * stack.c (print_frame_info): Move disassemble_next_line code
9603         inside source_print block.
9604
9605 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9606
9607         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
9608         gdb/signals.h, as we are now using native signal symbols.
9609
9610 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
9611
9612         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
9613         overflow by an early check of content vs threshold.
9614         * tui/tui-source.c (tui_source_window::line_is_displayed):
9615         Likewise.
9616
9617 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9618
9619         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
9620
9621 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
9622
9623         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
9624         export table if no section contains it's RVA.
9625
9626 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9627
9628         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
9629
9630 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
9631
9632         * source.c (print_source_lines_base): Set last_line_listed.
9633
9634 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
9635
9636         * tui/tui-disasm.c: Remove trailing spaces.
9637
9638 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9639             Pedro Alves  <palves@redhat.com>
9640
9641         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
9642         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
9643         (windows_gdb_signal_to_target): New function, uses the above
9644         enumeration to convert GDB internal signal codes to equivalent
9645         Windows codes.
9646         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
9647         * windows-nat.c: Include "gdb_wait.h".
9648         (get_windows_debug_event): Extract the fatal exception from the
9649         exit status and convert to the equivalent Posix signal number.
9650         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
9651         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
9652         * gdbsupport/gdb_wait.c: New file, implements
9653         windows_status_to_termsig.
9654         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
9655         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
9656
9657 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9658
9659         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
9660         show_layout.
9661
9662 2020-01-05  Luis Machado  <luis.machado@linaro.org>
9663
9664         * aarch64-linux-nat.c
9665         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
9666         and bfd_mach_aarch64.
9667
9668 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9669
9670         * ui-file.c (stdio_file::can_emit_style_escape)
9671         (tee_file::can_emit_style_escape): Ensure style is used also on
9672         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
9673         to gdb_stdout.
9674         * main.c (set_gdb_data_directory): Use file style to output the
9675         warning that the given pathname is not a directory.
9676         * top.c (show_history_filename, gdb_safe_append_history)
9677         (show_gdb_datadir): Use file style.
9678
9679 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
9680
9681         * solib-target.c (struct lm_info_target):
9682         Change offsets to be a unique_xmalloc_ptr.
9683         (solib_target_relocate_section_addresses): Update.
9684
9685 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
9686
9687         * windows-nat.c (windows_clear_solib): Free so_list linked list.
9688
9689 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
9690
9691         * MAINTAINERS (Write After Approval): Add myself.
9692
9693 2020-01-02  Luis Machado  <luis.machado@linaro.org>
9694
9695         * proc-service.c (get_ps_regcache): Remove reference to obsolete
9696         Cell BE architecture.
9697         * target.h (struct target_ops) <thread_architecture>: Likewise.
9698
9699 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
9700
9701         * Makefile.in: Use INSTALL_PROGRAM_ENV.
9702
9703 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
9704
9705         * MAINTAINERS (Write After Approval): Add myself.
9706
9707 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9708
9709         * gdbarch.sh: Update copyright year range of generated files.
9710
9711 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9712
9713         Update copyright year range in all GDB files.
9714
9715 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9716
9717         * copyright.py: Convert to Python 3.
9718
9719 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9720
9721         * copyright.py: Adapt after move of gnulib directory from gdb
9722         directory to toplevel directory.
9723
9724 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9725
9726         * copyright.py (main): Exit if run from the wrong directory.
9727
9728 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9729
9730         * top.c (print_gdb_version): Change copyright year to 2020.
9731
9732 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9733
9734         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
9735
9736 For older changes see ChangeLog-2019.
9737 \f
9738 Local Variables:
9739 mode: change-log
9740 left-margin: 8
9741 fill-column: 74
9742 version-control: never
9743 coding: utf-8
9744 End: