libctf/ChangeLog

   1 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
   2
   3         * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
   4         (ctf_dump_format_type): improve slice formatting.  Always print
   5         the type size, even of slices.
   6         (ctf_dump_member): Print slices (-> bitfields) differently from
   7         non-slices.  Failure to format a type is not an OOM.
   8
   9 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  10
  11         * ctf-dump.c (ctf_dump_format_type): Emit a warning.
  12         (ctf_dump_label): Swallow errors from ctf_dump_format_type.
  13         (ctf_dump_objts): Likewise.
  14         (ctf_dump_var): Likewise.
  15         (ctf_dump_type): Do not emit a duplicate message.  Move to
  16         ctf_err_warning, and swallow all errors.
  17
  18 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  19
  20         * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
  21         (ctf_decl_buf): Once it escapes, don't try to free it later.
  22
  23 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  24
  25         * ctf-types.c (ctf_type_aname): Print arg types here...
  26         * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
  27         in the type name here.
  28
  29 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  30
  31         * ctf-impl.h (ctf_assert): New.
  32         (ctf_err_warning_t): Likewise.
  33         (ctf_file_t) <ctf_errs_warnings>: Likewise.
  34         (ctf_err_warn): New prototype.
  35         (ctf_assert_fail_internal): Likewise.
  36         * ctf-inlines.h (ctf_assert_internal): Likewise.
  37         * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
  38         * ctf-create.c (ctf_serialize): Copy it on serialization.
  39         * ctf-subr.c (ctf_err_warn): New, add an error/warning.
  40         (ctf_errwarning_next): New iterator, free and pass back
  41         errors/warnings in succession.
  42         * libctf.ver (ctf_errwarning_next): Add.
  43
  44 2020-07-22  Egeyar Bagcioglu  <egeyar.bagcioglu@oracle.com>
  45
  46         * ctf-types.c (ctf_variable_iter): Fix error return.
  47
  48 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  49
  50         * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
  51
  52 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  53
  54         ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
  55
  56 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  57
  58         * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
  59         sorting functions.
  60         (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
  61         ctf_dynhash_next_sorted.
  62         <cu.ctn_h>: New, pointer to the dynhash under iteration.
  63         <cu.ctn_s>: New, pointer to the dynset under iteration.
  64         (ctf_hash_sort_f): Sorting function passed to...
  65         (ctf_dynhash_next_sorted): ... this new function.
  66         (ctf_dynhash_next): New.
  67         (ctf_dynset_next): New.
  68         * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
  69         (ctf_dynhash_cnext): New.
  70         (ctf_dynset_cnext): New.
  71         * ctf-hash.c (ctf_dynhash_next_sorted): New.
  72         (ctf_dynhash_next): New.
  73         (ctf_dynset_next): New.
  74         * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
  75         needed.
  76         (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
  77
  78 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  79
  80         * ctf-impl.h (ctf_next): New.
  81         (ctf_get_dict): New prototype.
  82         * ctf-lookup.c (ctf_get_dict): New, split out of...
  83         (ctf_lookup_by_id): ... here.
  84         * ctf-util.c (ctf_next_create): New.
  85         (ctf_next_destroy): New.
  86         (ctf_next_copy): New.
  87         * ctf-types.c (includes): Add <assert.h>.
  88         (ctf_member_next): New.
  89         (ctf_enum_next): New.
  90         (ctf_type_iter): Document the lack of iteration over parent
  91         types.
  92         (ctf_type_next): New.
  93         (ctf_variable_next): New.
  94         * ctf-archive.c (ctf_archive_next): New.
  95         * libctf.ver: Add new public functions.
  96
  97 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  98
  99         * libctf.ver (ctf_ref): New.
 100         * ctf-open.c (ctf_ref): Implement it.
 101
 102 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 103
 104         * ctf-inlines.h (ctf_forwardable_kind): New.
 105         * ctf-create.c (ctf_add_forward): Use it.
 106
 107 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 108
 109         * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
 110         * ctf-inlines.h (ctf_get_ctt_size): ... to here.
 111
 112 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 113
 114         * ctf-hash.c (ctf_dynset_eq_string): New.
 115         (ctf_dynset_create): New.
 116         (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
 117         (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
 118         (key_to_internal): New.
 119         (internal_to_key): New.
 120         (ctf_dynset_insert): New.
 121         (ctf_dynset_remove): New.
 122         (ctf_dynset_destroy): New.
 123         (ctf_dynset_lookup): New.
 124         (ctf_dynset_exists): New.
 125         (ctf_dynset_lookup_any): New.
 126         (ctf_hash_insert_type): Coding style.
 127         (ctf_hash_define_type): Likewise.
 128         * ctf-impl.h (ctf_dynset_t): New.
 129         (ctf_dynset_eq_string): New.
 130         (ctf_dynset_create): New.
 131         (ctf_dynset_insert): New.
 132         (ctf_dynset_remove): New.
 133         (ctf_dynset_destroy): New.
 134         (ctf_dynset_lookup): New.
 135         (ctf_dynset_exists): New.
 136         (ctf_dynset_lookup_any): New.
 137         * ctf-inlines.h (ctf_dynset_cinsert): New.
 138
 139 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 140
 141         * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
 142         <value_free>: Likewise.
 143         <owner>: New.
 144         (ctf_dynhash_item_free): Indirect through the owner.
 145         (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
 146         allocate space for the key_free and value_free fields fields
 147         if necessary.
 148         (ctf_hashtab_insert): Likewise.  Fix OOM errno value.
 149         (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
 150         value_free if they will exist.  Set the slot's owner, but only
 151         if it exists.
 152         (ctf_dynhash_remove): Adjust.
 153
 154 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 155
 156         * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
 157         there is a key-freeing function and the key already exists.
 158
 159 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 160
 161         * ctf-inlines.h: New file.
 162         * ctf-impl.h: Include it.
 163         (ctf_hash_iter_find_f): New typedef.
 164         (ctf_dynhash_elements): New.
 165         (ctf_dynhash_lookup_kv): New.
 166         (ctf_dynhash_iter_find): New.
 167         * ctf-hash.c (ctf_dynhash_lookup_kv): New.
 168         (ctf_traverse_find_cb_arg_t): New.
 169         (ctf_hashtab_traverse_find): New.
 170         (ctf_dynhash_iter_find): New.
 171         (ctf_dynhash_elements): New.
 172
 173 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 174
 175         * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
 176
 177 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 178
 179         * ctf-archive.c (ctf_archive_count): New.
 180         * libctf.ver: New public function.
 181
 182 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 183
 184         * ctf-types.c (ctf_member_count): New.
 185         * libctf.ver: New public function.
 186
 187 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 188
 189         * ctf-types.c (ctf_type_kind_forwarded): New.
 190
 191 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 192
 193         * ctf-types.c (ctf_type_name_raw): New.
 194         (ctf_type_aname_raw): Reimplement accordingly.
 195
 196 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 197
 198         * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
 199
 200 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 201
 202         * ctf-impl.h (struct ctf_archive_internal)
 203         <ctfi_unmap_on_close>: New.
 204         (ctf_new_archive_internal): Adjust.
 205         * ctf-archive.c (ctf_new_archive_internal): Likewise.
 206         Initialize ctfi_unmap_on_close.  Adjust error path.
 207         (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
 208         (unmap_on_close is 0).
 209         (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
 210         * ctf-open-bfd.c (ctf_fdopen): Adjust.
 211
 212 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 213
 214         * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
 215         ints, floats or typedefs have no name.  Fix comment typo.
 216
 217 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 218
 219         * ctf-create.c (ctf_add_slice): Support slices of any kind that
 220         resolves to an integral type.
 221         * ctf-types.c (ctf_type_encoding): Resolve the type before
 222         fishing its encoding out.
 223
 224 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 225
 226         * ctf-create.c (ctf_create): Mark dirty.
 227
 228 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 229
 230         * ctf-create.c (membcmp)  Skip nameless members.
 231
 232 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 233
 234         * ctf-create.c (ctf_add_member_offset): Support names of ""
 235         as if they were the null pointer.
 236
 237 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 238
 239         * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
 240         special-casing.
 241
 242 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 243
 244         * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
 245
 246 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 247
 248         * ctf-create.c (ctf_serialize): Add cast.
 249         (ctf_add_slice): Likewise.
 250
 251 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 252
 253         * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
 254         * ctf-create.c (ctf_add_function): Check for unimplemented type
 255         and populate at the same time.  Populate one-by-one, not via
 256         memcpy.
 257         (ctf_serialize): Remove unnecessary cast.
 258         * ctf-types.c (ctf_func_type_info): Likewise.
 259         (ctf_func_type_args): Likewise.  Fix comment typo.
 260
 261 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 262
 263         * ctf-create.c (ctf_add_reftype): Support refs to type zero.
 264         (ctf_add_array): Support array contents of type zero.
 265         (ctf_add_function): Support arguments and return types of
 266         type zero.
 267         (ctf_add_typedef): Support typedefs to type zero.
 268         (ctf_add_member_offset): Support members of type zero,
 269         unless added at unspecified (naturally-aligned) offset.
 270
 271 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 272
 273         * ctf-error.c: Include <stddef.h>, for offsetof.
 274         (_ctf_errlist): Migrate to...
 275         (_ctf_errlist_t): ... this.
 276         (_ctf_erridx): New, indexes into _ctf_errlist_t.
 277         (_ctf_nerr): Remove.
 278         (ctf_errmsg): Adjust accordingly.
 279         * Makefile.am (BUILT_SOURCES): Note...
 280         (ctf-error.h): ... this new rule.
 281         * Makefile.in: Regenerate.
 282         * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
 283         * .gitignore: New, ignore ctf-error.h.
 284
 285 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 286
 287         * ctf-impl.h: Fix typos in comments.
 288
 289 2020-07-22  Nick Clifton  <nickc@redhat.com>
 290
 291         * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
 292         same file descriptor.
 293
 294 2020-07-04  Nick Clifton  <nickc@redhat.com>
 295
 296         Binutils 2.35 branch created.
 297
 298 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 299
 300         * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
 301         alphabetical order.
 302         * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
 303         * config.h.in: Regenerated.
 304         * Makefile.in: Likewise.
 305         * configure: Likewise.
 306
 307 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 308
 309         * ctf-create.c: Include <unistd.h>.
 310         * ctf-open-bfd.c: Likewise.
 311
 312 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 313
 314         PR libctf/25120
 315         * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
 316         * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
 317         means this is declared.
 318         (bswap_32): Likewise.
 319         (bswap_64): Likewise.
 320         (bswap_identity_64): Remove, unused.
 321         * configure: Regenerated.
 322         * config.h.in: Likewise.
 323
 324 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 325
 326         PR libctf/25120
 327         * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
 328         (_libctf_unlikely_): Likewise.
 329         (_libctf_unused): Likewise.
 330         (_libctf_malloc_): Likewise.
 331
 332 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 333
 334         PR libctf/25120
 335         * ctf-archive.c (search_nametbl): No longer global: declare...
 336         (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
 337         (search_modent_by_name): Take and use ARG for the nametbl.
 338
 339 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 340
 341         * ctf-impl.h (ctf_new_archive_internal): Declare.
 342         (ctf_arc_bufopen): Remove.
 343         (ctf_archive_internal) <ctfi_free_symsect>: New.
 344         * ctf-archive.c (ctf_arc_close): Use it.
 345         (ctf_arc_bufopen): Fuse into...
 346         (ctf_new_archive_internal): ... this, moved across from...
 347         * ctf-open-bfd.c: ... here.
 348         (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
 349         * libctf.ver: Add it.
 350
 351 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 352
 353         * ctf-create.c (ctf_add_forward): Intern in the right namespace.
 354         (ctf_dtd_delete): Remove correspondingly.
 355         (ctf_rollback): Likewise.
 356
 357 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 358
 359         * ctf-create.c (ctf_add_type_internal): Hand back existing types
 360         unchanged.
 361
 362 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 363
 364         * ctf-create.c (ctf_add_forward): Don't add forwards to
 365         types that already exist.
 366
 367 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 368
 369         * ctf-open.c (init_types): Only intern root-visible types.
 370         * ctf-create.c (ctf_dtd_insert): Likewise.
 371         (ctf_dtd_delete): Only remove root-visible types.
 372         (ctf_rollback): Likewise.
 373         (ctf_add_generic): Adjust.
 374         (ctf_add_struct_sized): Adjust comment.
 375         (ctf_add_union_sized): Likewise.
 376         (ctf_add_enum): Likewise.
 377         * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
 378
 379 2020-03-11  John Baldwin  <jhb@FreeBSD.org>
 380
 381         * swap.h (bswap_identity_64): Make static.
 382
 383 2020-01-18  Nick Clifton  <nickc@redhat.com>
 384
 385         Binutils 2.34 branch created.
 386
 387 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
 388
 389         PR binutils/25155:
 390         * configure.ac: Add AC_CHECK_DECLS([asprintf]).
 391         * configure, config.h.in: Regenerate.
 392
 393 2020-01-01  Alan Modra  <amodra@gmail.com>
 394
 395         Update year range in copyright notice of all files.
 396
 397 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
 398
 399         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
 400
 401 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 402
 403         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
 404         * ctf-types.c (ctf_type_lname): Likewise.
 405
 406 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 407
 408         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
 409         ctf_import after the first for a given file.
 410
 411 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 412
 413         * ctf-impl.h (ctf_str_append_noerr): Declare.
 414         * ctf-util.c (ctf_str_append_noerr): Define in terms of
 415         ctf_str_append.
 416         * ctf-dump.c (str_append): New, call it.
 417         (ctf_dump_format_type): Use str_append, not ctf_str_append.
 418         (ctf_dump_label): Likewise.
 419         (ctf_dump_objts): Likewise.
 420         (ctf_dump_funcs): Likewise.
 421         (ctf_dump_var): Likewise.
 422         (ctf_dump_member): Likewise.
 423         (ctf_dump_type): Likewise.
 424         (ctf_dump): Likewise.
 425
 426 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 427
 428         * ctf-impl.h (ctf_alloc): Remove.
 429         (ctf_free): Likewise.
 430         (ctf_strdup): Likewise.
 431         * ctf-subr.c (ctf_alloc): Remove.
 432         (ctf_free): Likewise.
 433         * ctf-util.c (ctf_strdup): Remove.
 434
 435         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
 436         ctf_free; strdup, not ctf_strdup.
 437         (ctf_dtd_delete): Likewise.
 438         (ctf_dvd_delete): Likewise.
 439         (ctf_add_generic): Likewise.
 440         (ctf_add_function): Likewise.
 441         (ctf_add_enumerator): Likewise.
 442         (ctf_add_member_offset): Likewise.
 443         (ctf_add_variable): Likewise.
 444         (membadd): Likewise.
 445         (ctf_compress_write): Likewise.
 446         (ctf_write_mem): Likewise.
 447         * ctf-decl.c (ctf_decl_push): Likewise.
 448         (ctf_decl_fini): Likewise.
 449         (ctf_decl_sprintf): Likewise.  Check for OOM.
 450         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
 451         ctf_free; strdup, not ctf_strdup.
 452         (ctf_dump_free): Likewise.
 453         (ctf_dump): Likewise.
 454         * ctf-open.c (upgrade_types_v1): Likewise.
 455         (init_types): Likewise.
 456         (ctf_file_close): Likewise.
 457         (ctf_bufopen_internal): Likewise.  Check for OOM.
 458         (ctf_parent_name_set): Likewise: report the OOM to the caller.
 459         (ctf_cuname_set): Likewise.
 460         (ctf_import): Likewise.
 461         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
 462         free, not ctf_free; strdup, not ctf_strdup.
 463         (ctf_str_free_atom): Likewise.
 464         (ctf_str_create_atoms): Likewise.
 465         (ctf_str_add_ref_internal): Likewise.
 466         (ctf_str_remove_ref): Likewise.
 467         (ctf_str_write_strtab): Likewise.
 468
 469 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 470
 471         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
 472         work right for non-int/fps.
 473
 474 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
 475
 476         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
 477         null pointer.
 478
 479 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
 480
 481         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
 482         * ctf-open.c (ctf_file_close): Free it.
 483         * ctf-create.c (ctf_serialize): Adjust.
 484         (membcmp): When reporting a conflict due to an error, report the
 485         error.
 486         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
 487         (ctf_add_type_internal): ... this.  Hand back types we are already
 488         in the middle of adding immediately.  Hand back structs/unions with
 489         the same number of members immediately.  Do not walk the dynamic
 490         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
 491         forwards promoted to other types and the inverse case identically.
 492         Add structs to the mapping as soon as we intern them, before they
 493         gain any members.
 494
 495 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 496
 497         * ctf-impl.h (ctf_names_t): New.
 498         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
 499         (ctf_file_t) <ctf_structs>: Likewise.
 500         <ctf_unions>: Likewise.
 501         <ctf_enums>: Likewise.
 502         <ctf_names>: Likewise.
 503         <ctf_lookups>: Improve comment.
 504         <ctf_ptrtab_len>: New.
 505         <ctf_prov_strtab>: New.
 506         <ctf_str_prov_offset>: New.
 507         <ctf_dtbyname>: Remove, redundant to the names hashes.
 508         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
 509         (ctf_dtdef_t) <dtd_name>: Remove.
 510         <dtd_data>: Note that the ctt_name is now populated.
 511         (ctf_str_atom_t) <csa_offset>: This is now the strtab
 512         offset for internal strings too.
 513         <csa_external_offset>: New, the external strtab offset.
 514         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
 515         (ctf_name_table): New declaration.
 516         (ctf_lookup_by_rawname): Likewise.
 517         (ctf_lookup_by_rawhash): Likewise.
 518         (ctf_set_ctl_hashes): Likewise.
 519         (ctf_serialize): Likewise.
 520         (ctf_dtd_insert): Adjust.
 521         (ctf_simple_open_internal): Likewise.
 522         (ctf_bufopen_internal): Likewise.
 523         (ctf_list_empty_p): Likewise.
 524         (ctf_str_remove_ref): Likewise.
 525         (ctf_str_add): Returns uint32_t now.
 526         (ctf_str_add_ref): Likewise.
 527         (ctf_str_add_external): Now returns a boolean (int).
 528         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
 529         for strings in the appropriate range.
 530         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
 531         when adding the null string to the new strtab.
 532         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
 533         (ctf_str_add_ref_internal): Add make_provisional argument.  If
 534         make_provisional, populate the offset and fill in the
 535         ctf_prov_strtab accordingly.
 536         (ctf_str_add): Return the offset, not the string.
 537         (ctf_str_add_ref): Likewise.
 538         (ctf_str_add_external): Return a success integer.
 539         (ctf_str_remove_ref): New, remove a single ref.
 540         (ctf_str_count_strtab): Do not count the initial null string's
 541         length or the existence or length of any unreferenced internal
 542         atoms.
 543         (ctf_str_populate_sorttab): Skip atoms with no refs.
 544         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
 545         to the cts_len for the null string, since it is no longer done
 546         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
 547         Populate the csa_offset for both internal and external cases.
 548         Flush the ctf_prov_strtab afterwards, and reset the
 549         ctf_str_prov_offset.
 550         * ctf-create.c (ctf_grow_ptrtab): New.
 551         (ctf_create): Call it.  Initialize new fields rather than old
 552         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
 553         Set the ctl hashes and data model.
 554         (ctf_update): Rename to...
 555         (ctf_serialize): ... this.  Leave a compatibility function behind.
 556         Tell ctf_simple_open_internal that this is a writable dictionary.
 557         Pass the new fields along from the old dictionary.  Drop
 558         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
 559         Do not zero out the DTD's ctt_name.
 560         (ctf_prefixed_name): Rename to...
 561         (ctf_name_table): ... this.  No longer return a prefixed name: return
 562         the applicable name table instead.
 563         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
 564         kind we're adding.  Migrate away from dtd_name.
 565         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
 566         deleted ctt_name.
 567         (ctf_dtd_lookup_type_by_name): Remove.
 568         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 569         No longer check ctf_dtnextid: check ctf_typemax instead.
 570         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 571         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 572         ctf_name_table and the right name table, and migrate away from
 573         dtd_name as in ctf_dtd_delete.
 574         (ctf_add_generic): Pass in the kind explicitly and pass it to
 575         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 576         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 577         Grow the ptrtab if needed.
 578         (ctf_add_encoded): Pass in the kind.
 579         (ctf_add_slice): Likewise.
 580         (ctf_add_array): Likewise.
 581         (ctf_add_function): Likewise.
 582         (ctf_add_typedef): Likewise.
 583         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 584         ctt_name rather than dtd_name.
 585         (ctf_add_struct_sized): Pass in the kind.  Use
 586         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 587         ctf_dtd_lookup_type_by_name.
 588         (ctf_add_union_sized): Likewise.
 589         (ctf_add_enum): Likewise.
 590         (ctf_add_enum_encoded): Likewise.
 591         (ctf_add_forward): Likewise.
 592         (ctf_add_type): Likewise.
 593         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 594         being initialized until after the call.
 595         (ctf_write_mem): Likewise.
 596         (ctf_write): Likewise.
 597         * ctf-archive.c (arc_write_one_ctf): Likewise.
 598         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 599         ctf_hash_lookup_type.
 600         (ctf_lookup_by_id): No longer check the readonly types if the
 601         dictionary is writable.
 602         * ctf-open.c (init_types): Assert that this dictionary is not
 603         writable.  Adjust to use the new name hashes, ctf_name_table,
 604         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 605         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 606         if set.  Drop out early when dictionary is writable.  Split the
 607         ctf_lookups initialization into...
 608         (ctf_set_cth_hashes): ... this new function.
 609         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
 610         (ctf_simple_open): Adjust accordingly.
 611         (ctf_bufopen): Likewise.
 612         (ctf_file_close): Destroy the appropriate name hashes.  No longer
 613         destroy ctf_dtbyname, which is gone.
 614         (ctf_getdatasect): Remove spurious "extern".
 615         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
 616         specified name table, given a kind.
 617         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
 618         (ctf_member_iter): Add support for iterating over the
 619         dynamic type list.
 620         (ctf_enum_iter): Likewise.
 621         (ctf_variable_iter): Likewise.
 622         (ctf_type_rvisit): Likewise.
 623         (ctf_member_info): Add support for types in the dynamic type list.
 624         (ctf_enum_name): Likewise.
 625         (ctf_enum_value): Likewise.
 626         (ctf_func_type_info): Likewise.
 627         (ctf_func_type_args): Likewise.
 628         * ctf-link.c (ctf_accumulate_archive_names): No longer call
 629         ctf_update.
 630         (ctf_link_write): Likewise.
 631         (ctf_link_intern_extern_string): Adjust for new
 632         ctf_str_add_external return value.
 633         (ctf_link_add_strtab): Likewise.
 634         * ctf-util.c (ctf_list_empty_p): New.
 635
 636 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
 637
 638         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
 639         type zero.
 640         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
 641         members and types.
 642         (ctf_add_variable): Likewise for variables pointing to them.
 643         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
 644         type link failure, but do warn for others.
 645         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
 646         errors to be ENOMEM.
 647         (ctf_dump_member): Likewise.
 648         (ctf_dump_type): Likewise.
 649         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
 650         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
 651         (ctf_dump_header): Likewise.
 652         (ctf_dump_label): likewise.
 653         (ctf_dump_objts): likewise.
 654         (ctf_dump_funcs): likewise.
 655         (ctf_dump_var): likewise.
 656         (ctf_dump_str): Likewise.
 657
 658 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 659
 660         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
 661         (LT_INIT): Likewise.
 662         (AM_INSTALL_LIBBFD): Likewise.
 663         (dlopen): Note why this is necessary in a comment.
 664         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
 665         opcodes/.
 666         (SHARED_LDFLAGS): Likewise.
 667         (BFD_LIBADD): Likewise, for libbfd.
 668         (BFD_DEPENDENCIES): Likewise.
 669         (VERSION_FLAGS): Initialize, using a version script if ld supports
 670         one, or libtool -export-symbols-regex otherwise.
 671         (AC_CONFIG_MACRO_DIR): Add ../BFD.
 672         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
 673         (INCDIR): New.
 674         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
 675         (noinst_LIBRARIES): Replace with...
 676         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
 677         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
 678         libctf-nobfd.la as well.
 679         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
 680         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
 681         (libctf_a_SOURCES): Rename to...
 682         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
 683         ctf-open-bfd.c.
 684         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
 685         with ctf-open-bfd.c added.
 686         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
 687         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
 688         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
 689         * Makefile.am [INSTALL_LIBCTF]: Use it.
 690         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
 691         libtool macros.
 692         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
 693         the unstable components).
 694         * Makefile.in: Regenerated.
 695         * config.h.in: Likewise.
 696         * configure: Likewise.
 697
 698 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 699
 700         * configure.ac (INSTALL_LIBCTF): New, controlled by
 701         --enable-install-libctf.
 702         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
 703         * Makefile.in: Regenerated.
 704         * configure: Regenerated.
 705
 706 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 707
 708         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
 709         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
 710
 711 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 712
 713         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
 714
 715 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 716
 717         * ctf-impl.h (includes): Include <sys/param.h> here.
 718
 719 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 720
 721         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
 722         (flip_objts): Likewise.
 723         (flip_vars): Likewise.
 724         (flip_types): Likewise.
 725
 726 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 727
 728         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
 729         freeing functions: if set, free the key and value if the slot
 730         already exists.  Always reassign the key.
 731         (ctf_dynhash_insert): Adjust call appropriately.
 732         (ctf_hash_insert_type): Likewise.
 733
 734 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
 735
 736         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
 737         type kind.  Allow forwards to unify with pre-existing structs/
 738         unions/enums.
 739
 740 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 741
 742         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
 743         <ctf_link_memb_name_changer>: Likewise.
 744         <ctf_link_memb_name_changer_arg>: Likewise.
 745         * ctf-create.c (ctf_update): Update accordingly.
 746         * ctf-open.c (ctf_file_close): Likewise.
 747         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
 748         (ctf_link_add_cu_mapping): New.
 749         (ctf_link_set_memb_name_changer): Likewise.
 750         (ctf_change_parent_name): New.
 751         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
 752         allocated by the caller's ctf_link_memb_name_changer.
 753         <ndynames>: Likewise.
 754         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
 755         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
 756         ctf_change_parent_name.  Free any resulting names.
 757
 758 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 759
 760         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
 761         (ctf_link_one_type): ... here, with parent-name setting added.
 762         (check_variable): New.
 763         (ctf_link_one_variable): Likewise.
 764         (ctf_link_one_input_archive_member): Call it.
 765         * ctf-error.c (_ctf_errlist): Updated with new errors.
 766
 767 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 768
 769         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
 770         (struct ctf_link_type_mapping_key): New.
 771         (ctf_hash_type_mapping_key): Likewise.
 772         (ctf_hash_eq_type_mapping_key): Likewise.
 773         (ctf_add_type_mapping): Likewise.
 774         (ctf_type_mapping): Likewise.
 775         (ctf_dynhash_empty): Likewise.
 776         * ctf-open.c (ctf_file_close): Update accordingly.
 777         * ctf-create.c (ctf_update): Likewise.
 778         (ctf_add_type): Populate the mapping.
 779         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
 780         (ctf_hash_eq_type_mapping_key): Check the key for equality.
 781         (ctf_dynhash_insert): Fix comment typo.
 782         (ctf_dynhash_empty): New.
 783         * ctf-link.c (ctf_add_type_mapping): New.
 784         (ctf_type_mapping): Likewise.
 785         (empty_link_type_mapping): New.
 786         (ctf_link_one_input_archive): Call it.
 787
 788 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 789
 790         * ctf-link.c: New file, linking of the string and type sections.
 791         * Makefile.am (libctf_a_SOURCES): Add it.
 792         * Makefile.in: Regenerate.
 793
 794         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
 795         ctf_link_outputs.
 796         * ctf-create.c (ctf_update): Update accordingly.
 797         * ctf-open.c (ctf_file_close): Likewise.
 798         * ctf-error.c (_ctf_errlist): Updated with new errors.
 799
 800 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 801
 802         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
 803
 804 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 805
 806         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
 807         ctf_type_iter.
 808         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
 809         (ctf_dump_format_type): Add non-root-type { } notation.
 810         Add root flag to prototype.
 811         (ctf_dump_label): Adjust accordingly.
 812         (ctf_dump_objts): Likewise.
 813         (ctf_dump_var): Likewise.
 814
 815 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 816
 817         * ctf-create.c (ctf_compress_write): Fix double-free.
 818
 819 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 820
 821         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
 822         of...
 823         (ctf_arc_write_fd): ... this new function.
 824         * ctf-create.c (ctf_write_mem): New.
 825
 826 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 827
 828         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
 829         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
 830         (ctf_str_add_ref): Name the last arg.
 831         (ctf_str_add_external) New.
 832         (ctf_str_add_strraw_explicit): Likewise.
 833         (ctf_simple_open_internal): Likewise.
 834         (ctf_bufopen_internal): Likewise.
 835
 836         * ctf-string.c (ctf_strraw_explicit): Split from...
 837         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
 838         (ctf_str_add_ref_internal): Return the atom, not the
 839         string.
 840         (ctf_str_add): Adjust accordingly.
 841         (ctf_str_add_ref): Likewise.  Move up in the file.
 842         (ctf_str_add_external): New: update the csa_offset.
 843         (ctf_str_count_strtab): Only account for strings with no csa_offset
 844         in the internal strtab length.
 845         (ctf_str_write_strtab): If the csa_offset is set, update the
 846         string's refs without writing the string out, and update the
 847         ctf_syn_ext_strtab.  Make OOM handling less ugly.
 848         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
 849         (ctf_update): Handle failure to populate the strtab.  Pass in the
 850         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
 851         Call ctf_simple_open_internal, not ctf_simple_open.
 852         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
 853         strings by hand.
 854         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
 855         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
 856         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
 857         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
 858         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
 859         (ctf_simple_open_internal): ... this new function, which calls
 860         ctf_bufopen_internal.
 861         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
 862         (ctf_bufopen_internal): ... this new function, which sets
 863         ctf_syn_ext_strtab.
 864
 865 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 866
 867         * ctf_types.c (ctf_type_iter_all): New.
 868
 869 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 870
 871         * ctf-open.c (init_symtab): Check for overflow against the right
 872         section.
 873         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
 874         (upgrade_types_v1): Note that these sections are not checked.
 875         (flip_header): Endian-swap the header fields.
 876         (flip_ctf): Endian-swap the sections.
 877         (flip_objts): Update comment.
 878         (ctf_bufopen): Check header offsets and alignment for validity.
 879
 880 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 881
 882         * ctf-open-bfd.c: Add <assert.h>.
 883         (ctf_bfdopen_ctfsect): Open string and symbol tables using
 884         techniques borrowed from bfd_elf_sym_name.
 885         (ctf_new_archive_internal): Improve comment.
 886         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
 887         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
 888         no symbol section, but not vice versa.
 889
 890 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
 891
 892         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
 893         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
 894         * ctf-dump.c (dump_header): New function, dump the CTF header.
 895         (ctf_dump): Call it.
 896         (ctf_dump_header_strfield): New function.
 897         (ctf_dump_header_sectfield): Likewise.
 898
 899 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
 900
 901         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
 902         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
 903         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
 904         ctf_base: do not assume that it is always sizeof (ctf_header_t).
 905         Print out ctf_cuname: only print out ctf_parname if set.
 906         (ctf_free_base): Removed, ctf_base is no longer freed: free
 907         ctf_dynbase instead.
 908         (ctf_set_version): Fix spacing.
 909         (upgrade_header): New, in-place header upgrading.
 910         (upgrade_types): Rename to...
 911         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
 912         longer track old and new headers separately.  No longer allow for
 913         header sizes explicitly: squeeze the headers out on upgrade (they
 914         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
 915         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
 916         (upgrade_types): New, also handle ctf_parmax updating.
 917         (flip_header): Flip ctf_cuname.
 918         (flip_types): Flip BUF explicitly rather than deriving BUF from
 919         BASE.
 920         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
 921         required alignment of objtoff and funcoff.  No longer store it in
 922         the ctf_buf unless that buf is derived unmodified from the input.
 923         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
 924         that duplicate fields in ctf_file: move allocation of ctf_file
 925         further up instead.  Call upgrade_header as needed.  Move
 926         version-specific ctf_parmax initialization into upgrade_types.  More
 927         concise error handling.
 928         (ctf_file_close): No longer test for null pointers before freeing.
 929         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
 930         ctf_free_base.
 931         (ctf_cuname): New.
 932         (ctf_cuname_set): New.
 933         * ctf-create.c (ctf_update): Populate ctf_cuname.
 934         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
 935         comment.
 936         (ctf_write): Likewise.
 937         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
 938         Fix the compression length: fp->ctf_size never counted the CTF
 939         header.  Simplify the compress call accordingly.
 940
 941 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
 942
 943         * ctf-endian.h: Don't assume htole64 and le64toh are always
 944         present if HAVE_ENDIAN_H; also check if htole64 is defined.
 945         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
 946         not bswap_identity_64.
 947
 948 2019-09-18  Alan Modra  <amodra@gmail.com>
 949
 950         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
 951
 952 2019-09-09  Phil Blundell  <pb@pbcl.net>
 953
 954         binutils 2.33 branch created.
 955
 956 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
 957
 958         * ctf-types.c (ctf_type_aname_raw): New.
 959         (ctf_func_type_info): Likewise.
 960         (ctf_func_type_args): Likewise.
 961         * ctf-error.c (_ctf_errlist): Fix description.
 962         * ctf-lookup.c: Fix file description.
 963
 964 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 965
 966         * ctf-create.c (ctf_create): Fix off-by-one error.
 967
 968 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 969
 970         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
 971         struct ctf_strs.
 972         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
 973         (struct ctf_str_atom): New, disambiguated single string.
 974         (struct ctf_str_atom_ref): New, points to some other location that
 975         references this string's offset.
 976         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
 977         Remove member ctf_dtvstrlen: we no longer track the total strlen
 978         as we add strings.
 979         (ctf_str_create_atoms): Declare new function in ctf-string.c.
 980         (ctf_str_free_atoms): Likewise.
 981         (ctf_str_add): Likewise.
 982         (ctf_str_add_ref): Likewise.
 983         (ctf_str_rollback): Likewise.
 984         (ctf_str_purge_refs): Likewise.
 985         (ctf_str_write_strtab): Likewise.
 986         (ctf_realloc): Declare new function in ctf-util.c.
 987
 988         * ctf-open.c (ctf_bufopen): Create the atoms table.
 989         (ctf_file_close): Destroy it.
 990         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
 991         special-case the position of the parname string.  Construct the
 992         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
 993         rest of each buffer element is constructed, not via open-coding:
 994         realloc the CTF buffer and append the strtab to it.  No longer
 995         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
 996         strtab construction.
 997         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
 998         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
 999         after buffer element construction instead.
1000         (ctf_copy_lmembers): Likewise.
1001         (ctf_copy_emembers): Likewise.
1002         (ctf_create): No longer maintain the ctf_dtvstrlen.
1003         (ctf_dtd_delete): Likewise.
1004         (ctf_dvd_delete): Likewise.
1005         (ctf_add_generic): Likewise.
1006         (ctf_add_enumerator): Likewise.
1007         (ctf_add_member_offset): Likewise.
1008         (ctf_add_variable): Likewise.
1009         (membadd): Likewise.
1010         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1011         if there are active ctf_str_num_refs.
1012         (ctf_strraw): Move to ctf-string.c.
1013         (ctf_strptr): Likewise.
1014         * ctf-string.c: New file, strtab manipulation.
1015
1016         * Makefile.am (libctf_a_SOURCES): Add it.
1017         * Makefile.in: Regenerate.
1018
1019 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1020
1021         * ctf-impl.h (ctf_hash_iter_f): New.
1022         (ctf_dynhash_iter): New declaration.
1023         (ctf_dynhash_iter_remove): New declaration.
1024         * ctf-hash.c (ctf_dynhash_iter): Define.
1025         (ctf_dynhash_iter_remove): Likewise.
1026         (ctf_hashtab_traverse): New.
1027         (ctf_hashtab_traverse_remove): Likewise.
1028         (struct ctf_traverse_cb_arg): Likewise.
1029         (struct ctf_traverse_remove_cb_arg): Likewise.
1030
1031 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1032
1033         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1034
1035 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1036
1037         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1038         (ctf_dump_funcs): Likewise.
1039
1040 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1041
1042         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1043         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1044         little-endian CTF archive magic.  Do not check the CTF version:
1045         ctf_simple_open does that in endian-safe ways.  Do not dereference
1046         null pointers on open failure.
1047
1048 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1049
1050         * ctf-open.c (get_vbytes_common): Return the new slice size.
1051         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1052         Remember to copy in the CTF data when opening an uncompressed
1053         foreign-endian CTF file.  Prune useless variable manipulation.
1054
1055 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1056
1057         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1058         seen.
1059
1060 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1061
1062         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1063         output.
1064
1065 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1066
1067         * ctf-subr.c (_PAGESIZE): Remove.
1068         (ctf_data_alloc): Likewise.
1069         (ctf_data_free): Likewise.
1070         (ctf_data_protect): Likewise.
1071         * ctf-impl.h: Remove declarations.
1072         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1073         ctf_free, not ctf_data_free.
1074         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
1075         the buffer again on compression error.
1076         * ctf-open.c (ctf_set_base): No longer track the size: call
1077         ctf_free, not ctf_data_free.
1078         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
1079         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
1080
1081 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1082
1083         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1084         ctf_dynhash_insert.
1085         (ctf_dvd_insert): Likewise.
1086         (ctf_add_generic): Likewise.
1087         (ctf_add_variable): Likewise.
1088         * ctf-impl.h: Adjust declarations.
1089
1090 2019-06-14  Alan Modra  <amodra@gmail.com>
1091
1092         * configure: Regenerate.
1093
1094 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1095
1096         * ctf-decls.h: Include <libiberty.h>.
1097         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1098
1099 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1100
1101         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1102         (ctf_dump_objts): Likewise.
1103         (ctf_dump_funcs): Likewise.
1104         (ctf_dump_member): Likewise.
1105         (ctf_dump_str): Likewise.
1106
1107 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1108
1109         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1110         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1111
1112 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
1113
1114         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1115         (ctf_arc_open_by_offset): Likewise.
1116         * ctf-create.c (ctf_add_type): Likewise.
1117
1118 2019-06-04  Tom Tromey  <tromey@adacore.com>
1119
1120         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1121         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1122
1123 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1124
1125         * configure.ac: Check for O_CLOEXEC.
1126         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1127         * config.h.in: Regenerate.
1128         * configure: Likewise.
1129
1130 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1131
1132         * qsort_r.c: Rename to...
1133         * ctf-qsort_r.c: ... this.
1134         (_quicksort): Define to ctf_qsort_r.
1135         * ctf-decls.h (qsort_r): Remove.
1136         (ctf_qsort_r): Add.
1137         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1138         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1139         * Makefile.am (libctf_a_LIBADD): Remove.
1140         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1141         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1142         * ctf-create.c (ctf_update): Likewise.
1143         * configure.ac: Check for BSD versus GNU qsort_r signature.
1144         * Makefile.in: Regenerate.
1145         * config.h.in: Likewise.
1146         * configure: Likewise.
1147
1148 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
1149
1150         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1151
1152 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
1153
1154         * Makefile.am (ZLIB): New.
1155         (ZLIBINC): Likewise.
1156         (AM_CFLAGS): Use them.
1157         (libctf_a_LIBADD): New, for LIBOBJS.
1158         * configure.ac: Check for zlib, endian.h, and qsort_r.
1159         * ctf-endian.h: New, providing htole64 and le64toh.
1160         * swap.h: Code style fixes.
1161         (bswap_identity_64): New.
1162         * qsort_r.c: New, from gnulib (with one added #include).
1163         * ctf-decls.h: New, providing a conditional qsort_r declaration,
1164         and unconditional definitions of MIN and MAX.
1165         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
1166         (ctf_set_errno): Now returns unsigned long.
1167         * ctf-util.c (ctf_set_errno): Adjust here too.
1168         * ctf-archive.c: Use ctf-endian.h.
1169         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
1170         cts_flags and cts_offset.
1171         (ctf_arc_write): Drop debugging dependent on the size of off_t.
1172         * ctf-create.c: Provide a definition of roundup if not defined.
1173         (ctf_create): Drop cts_type, cts_flags and cts_offset.
1174         (ctf_add_reftype): Do not check if type IDs are below zero.
1175         (ctf_add_slice): Likewise.
1176         (ctf_add_typedef): Likewise.
1177         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1178         when known error-free.  Drop CTF_ERR usage for functions returning
1179         int.
1180         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1181         int.
1182         (ctf_add_variable): Likewise.
1183         (enumcmp): Likewise.
1184         (enumadd): Likewise.
1185         (membcmp): Likewise.
1186         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
1187         when known error-free.
1188         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1189         returning int: use CTF_ERR for functions returning ctf_type_id.
1190         (ctf_dump_label): Likewise.
1191         (ctf_dump_objts): Likewise.
1192         * ctf-labels.c (ctf_label_topmost): Likewise.
1193         (ctf_label_iter): Likewise.
1194         (ctf_label_info): Likewise.
1195         * ctf-lookup.c (ctf_func_args): Likewise.
1196         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1197         (ctf_bufopen): Likewise.  Use zlib types as needed.
1198         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1199         returning int.
1200         (ctf_enum_iter): Likewise.
1201         (ctf_type_size): Likewise.
1202         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
1203         (ctf_type_kind_unsliced): Likewise.
1204         (ctf_type_kind): Likewise.
1205         (ctf_type_encoding): Likewise.
1206         (ctf_member_info): Likewise.
1207         (ctf_array_info): Likewise.
1208         (ctf_enum_value): Likewise.
1209         (ctf_type_rvisit): Likewise.
1210         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1211         cts_offset.
1212         (ctf_simple_open): Likewise.
1213         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
1214         * Makefile.in: Regenerate.
1215         * aclocal.m4: Likewise.
1216         * config.h: Likewise.
1217         * configure: Likewise.
1218
1219 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1220
1221         * configure.in: Check for bfd_section_from_elf_index.
1222         * configure: Regenerate.
1223         * config.h.in [HAVE_BFD_ELF]: Likewise.
1224         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1225         abfd is potentially unused now.
1226
1227 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1228
1229         * Makefile.am: New.
1230         * Makefile.in: Regenerated.
1231         * config.h.in: Likewise.
1232         * aclocal.m4: Likewise.
1233         * configure: Likewise.
1234
1235 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1236
1237         * ctf-dump.c: New.
1238
1239 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1240
1241         * ctf-labels.c: New.
1242
1243 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1244
1245         * ctf-impl.h (_libctf_version): New declaration.
1246         * ctf-subr.c (_libctf_version): Define it.
1247         (ctf_version): New.
1248
1249 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1250
1251         * ctf-create.c (enumcmp): New.
1252         (enumadd): Likewise.
1253         (membcmp): Likewise.
1254         (membadd): Likewise.
1255         (ctf_add_type): Likewise.
1256
1257 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1258
1259         * ctf-lookup.c (isqualifier): New.
1260         (ctf_lookup_by_name): Likewise.
1261         (struct ctf_lookup_var_key): Likewise.
1262         (ctf_lookup_var): Likewise.
1263         (ctf_lookup_variable): Likewise.
1264         (ctf_lookup_symbol_name): Likewise.
1265         (ctf_lookup_by_symbol): Likewise.
1266         (ctf_func_info): Likewise.
1267         (ctf_func_args): Likewise.
1268
1269 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1270
1271         * ctf-decl.c: New file.
1272         * ctf-types.c: Likewise.
1273         * ctf-impl.h: New declarations.
1274
1275 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1276
1277         * ctf-open-bfd.c: New file.
1278         * ctf-open.c (ctf_close): New.
1279         * ctf-impl.h: Include bfd.h.
1280         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1281         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1282         ctfi_bfd_close.
1283         (ctf_bfdopen_ctfsect): New declaration.
1284         (_CTF_SECTION): likewise.
1285
1286 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1287
1288         * ctf-archive.c: New.
1289         * ctf-impl.h (ctf_archive_internal): New type.
1290         (ctf_arc_open_internal): New declaration.
1291         (ctf_arc_bufopen): Likewise.
1292         (ctf_arc_close_internal): Likewise.
1293
1294 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1295
1296         * ctf-open.c: New file.
1297         * swap.h: Likewise.
1298
1299 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1300
1301         * ctf-create.c: New file.
1302         * ctf-lookup.c: New file.
1303
1304 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1305
1306         * ctf-impl.h: New definitions and declarations for type creation
1307         and lookup.
1308
1309 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1310
1311         * ctf-hash.c: New file.
1312         * ctf-impl.h: New declarations.
1313
1314 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1315
1316         * ctf-error.c: New file.
1317
1318 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1319
1320         * ctf-util.c: New file.
1321         * elf.h: Likewise.
1322         * ctf-impl.h: Include it, and add declarations.
1323
1324 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1325
1326         * ctf-impl.h: New file.
1327         * ctf-subr.c: New file.
1328
1329 \f
1330 Local Variables:
1331 mode: change-log
1332 left-margin: 8
1333 fill-column: 76
1334 version-control: never
1335 End: