}
static inline
-int py_exc_to_status(bt_self_component_class *self_component_class,
+int py_exc_to_status_clear(
+ bt_self_component_class *self_component_class,
bt_self_component *self_component,
bt_self_message_iterator *self_message_iterator,
const char *module_name, int active_log_level)
{
- int status = __BT_FUNC_STATUS_OK;
+ int status;
PyObject *exc = PyErr_Occurred();
if (!exc) {
+ status = __BT_FUNC_STATUS_OK;
goto end;
}
}
BT_ASSERT(active_log_level != -1);
- log_exception_and_maybe_append_error(BT_LOG_WARNING,
+ log_exception_and_maybe_append_cause(BT_LOG_WARNING,
active_log_level, true,
self_component_class, self_component,
self_message_iterator, module_name);
}
static
-int py_exc_to_status_component_class(
+int py_exc_to_status_component_class_clear(
bt_self_component_class *self_component_class,
int active_log_level)
{
- return py_exc_to_status(self_component_class, NULL, NULL, NULL,
+ return py_exc_to_status_clear(self_component_class, NULL, NULL, NULL,
active_log_level);
}
static
-int py_exc_to_status_component(bt_self_component *self_component)
+int py_exc_to_status_component_clear(bt_self_component *self_component)
{
- return py_exc_to_status(NULL, self_component, NULL, NULL, -1);
+ return py_exc_to_status_clear(NULL, self_component, NULL, NULL, -1);
}
static
-int py_exc_to_status_message_iterator(
+int py_exc_to_status_message_iterator_clear(
bt_self_message_iterator *self_message_iterator)
{
- return py_exc_to_status(NULL, NULL, self_message_iterator, NULL, -1);
+ return py_exc_to_status_clear(NULL, NULL, self_message_iterator, NULL, -1);
}
static
{
const bt_component *component = bt_self_component_as_component(self_component);
const bt_component_class *component_class = bt_component_borrow_class_const(component);
- bt_component_class_initialize_method_status status = __BT_FUNC_STATUS_OK;
+ bt_component_class_initialize_method_status status;
PyObject *py_cls = NULL;
PyObject *py_comp = NULL;
PyObject *py_params_ptr = NULL;
BT_COMP_LOG_CUR_LVL(BT_LOG_WARNING, log_level, self_component,
"Failed to call Python class's _bt_init_from_native() method: "
"py-cls-addr=%p", py_cls);
- status = py_exc_to_status_component(self_component);
+ status = py_exc_to_status_component_clear(self_component);
goto end;
}
*/
bt_self_component_set_data(self_component, py_comp);
py_comp = NULL;
+
+ status = BT_COMPONENT_CLASS_INITIALIZE_METHOD_STATUS_OK;
+
goto end;
error:
- status = __BT_FUNC_STATUS_ERROR;
-
- /*
- * Clear any exception: we're returning a bad status anyway. If
- * this call originated from Python (creation from a plugin's
- * component class, for example), then the user gets an
- * appropriate creation error.
- */
- PyErr_Clear();
+ /* This error path is for non-Python errors only. */
+ status = BT_COMPONENT_CLASS_INITIALIZE_METHOD_STATUS_ERROR;
end:
+ BT_ASSERT(!PyErr_Occurred());
Py_XDECREF(py_comp);
Py_XDECREF(py_params_ptr);
Py_XDECREF(py_comp_ptr);
PyObject *py_params_ptr = NULL;
PyObject *py_range_set_addr = NULL;
bt_integer_range_set_unsigned *ret_range_set = NULL;
- bt_component_class_get_supported_mip_versions_method_status status =
- __BT_FUNC_STATUS_OK;
+ bt_component_class_get_supported_mip_versions_method_status status;
py_cls = lookup_cc_ptr_to_py_cls(component_class);
if (!py_cls) {
BT_LOG_WRITE_CUR_LVL(BT_LOG_WARNING, log_level, BT_LOG_TAG,
"Failed to call Python class's _bt_get_supported_mip_versions_from_native() method: "
"py-cls-addr=%p", py_cls);
- status = py_exc_to_status_component_class(self_component_class,
+ status = py_exc_to_status_component_class_clear(self_component_class,
log_level);
goto end;
}
}
}
+ status = BT_COMPONENT_CLASS_GET_SUPPORTED_MIP_VERSIONS_METHOD_STATUS_OK;
+
goto end;
error:
- PyErr_Clear();
- status = __BT_FUNC_STATUS_ERROR;
+ /* This error path is for non-Python errors only. */
+ status = BT_COMPONENT_CLASS_GET_SUPPORTED_MIP_VERSIONS_METHOD_STATUS_ERROR;
end:
+ BT_ASSERT(!PyErr_Occurred());
Py_XDECREF(py_params_ptr);
Py_XDECREF(py_range_set_addr);
bt_integer_range_set_unsigned_put_ref(ret_range_set);
void component_class_finalize(bt_self_component *self_component)
{
PyObject *py_comp = bt_self_component_get_data(self_component);
+ PyObject *py_method_result;
+
BT_ASSERT(py_comp);
/* Call user's _user_finalize() method */
- PyObject *py_method_result = PyObject_CallMethod(py_comp,
- "_user_finalize", NULL);
-
- if (PyErr_Occurred()) {
+ py_method_result = PyObject_CallMethod(py_comp, "_user_finalize", NULL);
+ if (!py_method_result) {
bt_logging_level log_level = get_self_component_log_level(
self_component);
+ /*
+ * Ignore any exception raised by the _user_finalize() method
+ * because it won't change anything at this point: the component
+ * is being destroyed anyway.
+ */
BT_COMP_LOG_CUR_LVL(BT_LOG_WARNING, log_level, self_component,
"User component's _user_finalize() method raised an exception: ignoring:");
- logw_exception(log_level);
+ logw_exception_clear(log_level);
+
+ goto end;
}
- /*
- * Ignore any exception raised by the _user_finalize() method
- * because it won't change anything at this point: the component
- * is being destroyed anyway.
- */
- PyErr_Clear();
+ BT_ASSERT(py_method_result == Py_None);
+
+end:
Py_XDECREF(py_method_result);
Py_DECREF(py_comp);
}
PyObject *py_result = NULL;
bt_component_class_message_iterator_can_seek_beginning_method_status status;
py_iter = bt_self_message_iterator_get_data(self_message_iterator);
+
BT_ASSERT(py_iter);
py_result = PyObject_CallMethod(py_iter,
"_bt_can_seek_beginning_from_native", NULL);
+ if (!py_result) {
+ status = py_exc_to_status_message_iterator_clear(self_message_iterator);
+ goto end;
+ }
- BT_ASSERT(!py_result || PyBool_Check(py_result));
+ BT_ASSERT(PyBool_Check(py_result));
+ *can_seek = PyObject_IsTrue(py_result);
- if (py_result) {
- *can_seek = PyObject_IsTrue(py_result);
- status = BT_COMPONENT_CLASS_MESSAGE_ITERATOR_CAN_SEEK_BEGINNING_METHOD_STATUS_OK;
- } else {
- status = py_exc_to_status_message_iterator(self_message_iterator);
- BT_ASSERT(status != __BT_FUNC_STATUS_OK);
- }
+ status = BT_COMPONENT_CLASS_MESSAGE_ITERATOR_CAN_SEEK_BEGINNING_METHOD_STATUS_OK;
+end:
Py_XDECREF(py_result);
return status;
py_iter = bt_self_message_iterator_get_data(self_message_iterator);
BT_ASSERT(py_iter);
- py_result = PyObject_CallMethod(py_iter, "_bt_seek_beginning_from_native",
+
+ py_result = PyObject_CallMethod(py_iter,
+ "_bt_seek_beginning_from_native",
NULL);
- BT_ASSERT(!py_result || py_result == Py_None);
- status = py_exc_to_status_message_iterator(self_message_iterator);
+ if (!py_result) {
+ status = py_exc_to_status_message_iterator_clear(self_message_iterator);
+ goto end;
+ }
+
+ BT_ASSERT(py_result == Py_None);
+
+ status = BT_COMPONENT_CLASS_MESSAGE_ITERATOR_SEEK_BEGINNING_METHOD_STATUS_OK;
+
+end:
Py_XDECREF(py_result);
+
return status;
}
PyObject *py_iter;
PyObject *py_result = NULL;
bt_component_class_message_iterator_can_seek_ns_from_origin_method_status status;
+
py_iter = bt_self_message_iterator_get_data(self_message_iterator);
BT_ASSERT(py_iter);
py_result = PyObject_CallMethod(py_iter,
"_bt_can_seek_ns_from_origin_from_native", "L", ns_from_origin);
+ if (!py_result) {
+ status = py_exc_to_status_message_iterator_clear(self_message_iterator);
+ goto end;
+ }
- BT_ASSERT(!py_result || PyBool_Check(py_result));
+ BT_ASSERT(PyBool_Check(py_result));
+ *can_seek = PyObject_IsTrue(py_result);
- if (py_result) {
- *can_seek = PyObject_IsTrue(py_result);
- status = BT_COMPONENT_CLASS_MESSAGE_ITERATOR_CAN_SEEK_NS_FROM_ORIGIN_METHOD_STATUS_OK;
- } else {
- status = py_exc_to_status_message_iterator(self_message_iterator);
- BT_ASSERT(status != BT_COMPONENT_CLASS_MESSAGE_ITERATOR_CAN_SEEK_NS_FROM_ORIGIN_METHOD_STATUS_OK);
- }
+ status = BT_COMPONENT_CLASS_MESSAGE_ITERATOR_CAN_SEEK_NS_FROM_ORIGIN_METHOD_STATUS_OK;
+end:
Py_XDECREF(py_result);
return status;
py_iter = bt_self_message_iterator_get_data(self_message_iterator);
BT_ASSERT(py_iter);
+
py_result = PyObject_CallMethod(py_iter,
"_bt_seek_ns_from_origin_from_native", "L", ns_from_origin);
- BT_ASSERT(!py_result || py_result == Py_None);
- status = py_exc_to_status_message_iterator(self_message_iterator);
+ if (!py_result) {
+ status = py_exc_to_status_message_iterator_clear(self_message_iterator);
+ goto end;
+ }
+
+
+ BT_ASSERT(py_result == Py_None);
+
+ status = BT_COMPONENT_CLASS_MESSAGE_ITERATOR_SEEK_NS_FROM_ORIGIN_METHOD_STATUS_OK;
+
+end:
Py_XDECREF(py_result);
+
return status;
}
BT_COMP_LOG_CUR_LVL(BT_LOG_ERROR, log_level, self_component,
"Failed to create a SWIG pointer object.");
status = __BT_FUNC_STATUS_MEMORY_ERROR;
- goto end; }
+ goto end;
+ }
py_method_result = PyObject_CallMethod(py_comp,
"_bt_port_connected_from_native", "(OiO)", py_self_port_ptr,
self_component_port_type, py_other_port_ptr);
- BT_ASSERT(!py_method_result || py_method_result == Py_None);
- status = py_exc_to_status_component(self_component);
+ if (!py_method_result) {
+ status = py_exc_to_status_component_clear(self_component);
+ goto end;
+ }
+
+ BT_ASSERT(py_method_result == Py_None);
+
+ status = BT_COMPONENT_CLASS_PORT_CONNECTED_METHOD_STATUS_OK;
end:
Py_XDECREF(py_self_port_ptr);
Py_XDECREF(py_other_port_ptr);
Py_XDECREF(py_method_result);
+
return status;
}
{
PyObject *py_comp = NULL;
PyObject *py_method_result = NULL;
- bt_component_class_sink_graph_is_configured_method_status status = __BT_FUNC_STATUS_OK;
+ bt_component_class_sink_graph_is_configured_method_status status;
bt_self_component *self_component = bt_self_component_sink_as_self_component(self_component_sink);
py_comp = bt_self_component_get_data(self_component);
+
py_method_result = PyObject_CallMethod(py_comp,
"_bt_graph_is_configured_from_native", NULL);
- BT_ASSERT(!py_method_result || py_method_result == Py_None);
- status = py_exc_to_status_component(self_component);
+ if (!py_method_result) {
+ status = py_exc_to_status_component_clear(self_component);
+ goto end;
+ }
+
+ BT_ASSERT(py_method_result == Py_None);
+
+ status = BT_COMPONENT_CLASS_SINK_GRAPH_IS_CONFIGURED_METHOD_STATUS_OK;;
+
+end:
Py_XDECREF(py_method_result);
return status;
}
py_object, py_params_ptr,
method_data ? method_data : Py_None);
if (!py_results_addr) {
- status = py_exc_to_status_component_class(self_component_class,
+ status = py_exc_to_status_component_class_clear(self_component_class,
log_level);
if (status < 0) {
static const char *fmt =
python_error:
/* Handling of errors that cause a Python exception to be set. */
- status = py_exc_to_status_message_iterator(self_message_iterator);
- BT_ASSERT(status != __BT_FUNC_STATUS_OK);
+ status = py_exc_to_status_message_iterator_clear(self_message_iterator);
goto end;
error:
/* Call user's _user_finalize() method */
py_method_result = PyObject_CallMethod(py_message_iter,
"_user_finalize", NULL);
-
- if (PyErr_Occurred()) {
+ if (!py_method_result) {
bt_self_component *self_comp =
bt_self_message_iterator_borrow_component(
message_iterator);
bt_logging_level log_level = get_self_component_log_level(
self_comp);
+ /*
+ * Ignore any exception raised by the _user_finalize() method
+ * because it won't change anything at this point: the component
+ * is being destroyed anyway.
+ */
BT_COMP_LOG_CUR_LVL(BT_LOG_WARNING, log_level, self_comp,
"User's _user_finalize() method raised an exception: ignoring:");
- logw_exception(get_self_message_iterator_log_level(
+ logw_exception_clear(get_self_message_iterator_log_level(
message_iterator));
}
- /*
- * Ignore any exception raised by the _user_finalize() method
- * because it won't change anything at this point: the component
- * is being destroyed anyway.
- */
- PyErr_Clear();
Py_XDECREF(py_method_result);
Py_DECREF(py_message_iter);
}
bt_message_array_const msgs, uint64_t capacity,
uint64_t *count)
{
- bt_component_class_message_iterator_next_method_status status = __BT_FUNC_STATUS_OK;
+ bt_component_class_message_iterator_next_method_status status;
PyObject *py_message_iter = bt_self_message_iterator_get_data(message_iterator);
PyObject *py_method_result = NULL;
- BT_ASSERT(py_message_iter);
+ BT_ASSERT_DBG(py_message_iter);
py_method_result = PyObject_CallMethod(py_message_iter,
"_bt_next_from_native", NULL);
if (!py_method_result) {
- status = py_exc_to_status_message_iterator(message_iterator);
- BT_ASSERT(status != __BT_FUNC_STATUS_OK);
+ status = py_exc_to_status_message_iterator_clear(message_iterator);
goto end;
}
msgs[0] = PyLong_AsVoidPtr(py_method_result);
*count = 1;
- /* Clear potential overflow error; should never happen */
- BT_ASSERT(!PyErr_Occurred());
- goto end;
+ /* Overflow errors should never happen. */
+ BT_ASSERT_DBG(!PyErr_Occurred());
+
+ status = BT_COMPONENT_CLASS_MESSAGE_ITERATOR_NEXT_METHOD_STATUS_OK;
end:
Py_XDECREF(py_method_result);
PyObject *py_method_result = NULL;
bt_component_class_sink_consume_method_status status;
- BT_ASSERT(py_comp);
+ BT_ASSERT_DBG(py_comp);
+
py_method_result = PyObject_CallMethod(py_comp,
"_user_consume", NULL);
- status = py_exc_to_status_component(self_component);
- BT_ASSERT(py_method_result || status != __BT_FUNC_STATUS_OK);
+ if (!py_method_result) {
+ status = py_exc_to_status_component_clear(self_component);
+ goto end;
+ }
+
+ status = BT_COMPONENT_CLASS_SINK_CONSUME_METHOD_STATUS_OK;
+
+end:
Py_XDECREF(py_method_result);
return status;
}
BT_ASSERT(ret == 0);
ret = bt_component_class_source_set_finalize_method(component_class_source, component_class_source_finalize);
BT_ASSERT(ret == 0);
- ret = bt_component_class_source_set_message_iterator_can_seek_beginning_method(component_class_source,
- component_class_can_seek_beginning);
- BT_ASSERT(ret == 0);
- ret = bt_component_class_source_set_message_iterator_seek_beginning_method(component_class_source,
- component_class_seek_beginning);
- ret = bt_component_class_source_set_message_iterator_can_seek_ns_from_origin_method(
- component_class_source, component_class_can_seek_ns_from_origin);
- BT_ASSERT(ret == 0);
- ret = bt_component_class_source_set_message_iterator_seek_ns_from_origin_method(
- component_class_source, component_class_seek_ns_from_origin);
+ ret = bt_component_class_source_set_message_iterator_seek_beginning_methods(component_class_source,
+ component_class_seek_beginning, component_class_can_seek_beginning);
+ ret = bt_component_class_source_set_message_iterator_seek_ns_from_origin_methods(
+ component_class_source, component_class_seek_ns_from_origin,
+ component_class_can_seek_ns_from_origin);
BT_ASSERT(ret == 0);
ret = bt_component_class_source_set_output_port_connected_method(component_class_source,
component_class_source_output_port_connected);
BT_ASSERT(ret == 0);
ret = bt_component_class_filter_set_finalize_method (component_class_filter, component_class_filter_finalize);
BT_ASSERT(ret == 0);
- ret = bt_component_class_filter_set_message_iterator_can_seek_beginning_method(component_class_filter,
- component_class_can_seek_beginning);
- BT_ASSERT(ret == 0);
- ret = bt_component_class_filter_set_message_iterator_seek_beginning_method(component_class_filter,
- component_class_seek_beginning);
- BT_ASSERT(ret == 0);
- ret = bt_component_class_filter_set_message_iterator_can_seek_ns_from_origin_method(
- component_class_filter, component_class_can_seek_ns_from_origin);
+ ret = bt_component_class_filter_set_message_iterator_seek_beginning_methods(component_class_filter,
+ component_class_seek_beginning, component_class_can_seek_beginning);
BT_ASSERT(ret == 0);
- ret = bt_component_class_filter_set_message_iterator_seek_ns_from_origin_method(
- component_class_filter, component_class_seek_ns_from_origin);
+ ret = bt_component_class_filter_set_message_iterator_seek_ns_from_origin_methods(
+ component_class_filter, component_class_seek_ns_from_origin,
+ component_class_can_seek_ns_from_origin);
ret = bt_component_class_filter_set_input_port_connected_method(component_class_filter,
component_class_filter_input_port_connected);
BT_ASSERT(ret == 0);