libctf: drop error-prone ctf_strerror
authorNick Alcock <nick.alcock@oracle.com>
Thu, 4 Jun 2020 17:07:38 +0000 (18:07 +0100)
committerNick Alcock <nick.alcock@oracle.com>
Wed, 22 Jul 2020 17:02:18 +0000 (18:02 +0100)
commite148b73013109517c4d179aa9ae5a50b6d1dd5b5
treef35a67a172a16852efc56d6d1fdbb586cf307dcc
parent1fa7a0c24e78e7f7995a3fa608c9f97a6ccbe1b6
libctf: drop error-prone ctf_strerror

This utility function is almost useless (all it does is casts the result
of a strerror) but has a seriously confusing name.  Over and over again
I have accidentally called it instead of ctf_errmsg, and hidden a
time-bomb for myself in a hard-to-test error-handling path: since
ctf_strerror is just a strerror wrapper, it cannot handle CTF errnos,
unlike ctf_errmsg.  It's astonishingly lucky that none of these errors
have crept into any commits to date.

Fuse it into ctf_errmsg and drop it.

libctf/
* ctf-impl.h (ctf_strerror): Delete.
* ctf-subr.c (ctf_strerror): Likewise.
* ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
strerror directly.
libctf/ChangeLog
libctf/ctf-error.c
libctf/ctf-impl.h
libctf/ctf-subr.c
This page took 0.026227 seconds and 4 git commands to generate.