Coverity reported the following:
CID
1401189 (#1 of 1): Logically dead code (DEADCODE)dead_error_begin:
Execution cannot reach this statement: bt_clock_snapshot_recycle(c.
Reported-by: Coverity - 1401189 Logically dead code (DEADCODE)
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Change-Id: I382a29cf5d825a9df06de61cbed7dcdf988de7d3
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2053
Tested-by: jenkins <jenkins@lttng.org>
Reviewed-by: Simon Marchi <simon.marchi@efficios.com>
BT_LIB_LOGE_APPEND_CAUSE(
"Cannot allocate one clock snapshot from clock class's clock snapshot pool: "
"%![cc-]+K", clock_class);
- goto error;
+ goto end;
}
if (G_LIKELY(!clock_snapshot->clock_class)) {
bt_object_get_no_null_check(clock_class);
}
- goto end;
-
-error:
- if (clock_snapshot) {
- bt_clock_snapshot_recycle(clock_snapshot);
- clock_snapshot = NULL;
- }
-
end:
return clock_snapshot;
}