Enable:
https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.html
Set the `AllowMissingMoveFunctionsWhenCopyIsDeleted`, so it's less
verbose when you just want to delete everything.
Set `AllowSoleDefaultDtor`, because we have legitimate cases (when
defining virtual base classes) where we only define a default
destructor. Perhaps there's a pitfall I don't see when allowing this?
Change-Id: I4a8d20c0be628ac807db4c6b52548e3b7d7ee286
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/12090
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>
bugprone-virtual-near-miss,
bugprone-unused-raii,
bugprone-use-after-move,
bugprone-virtual-near-miss,
bugprone-unused-raii,
bugprone-use-after-move,
+ cppcoreguidelines-avoid-const-or-ref-data-members,
cppcoreguidelines-pro-type-const-cast,
cppcoreguidelines-slicing,
cppcoreguidelines-special-member-functions,
cppcoreguidelines-pro-type-const-cast,
cppcoreguidelines-slicing,
cppcoreguidelines-special-member-functions,
CheckOptions:
- key: bugprone-assert-side-effect.AssertMacros
value: BT_ASSERT,BT_ASSERT_DBG
CheckOptions:
- key: bugprone-assert-side-effect.AssertMacros
value: BT_ASSERT,BT_ASSERT_DBG
+ - key: cppcoreguidelines-special-member-functions.AllowSoleDefaultDtor
+ value: true
+ - key: cppcoreguidelines-special-member-functions.AllowMissingMoveFunctionsWhenCopyIsDeleted
+ value: true