summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
885a880)
CID
1376153 (#1 of 1): Unchecked return value (CHECKED_RETURN).
check_return: Calling bt_value_bool_get without checking return value
(as is done elsewhere 18 out of 20 times).
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
#include <babeltrace/graph/notification-iterator.h>
#include <babeltrace/ref.h>
#include <babeltrace/values.h>
#include <babeltrace/graph/notification-iterator.h>
#include <babeltrace/ref.h>
#include <babeltrace/values.h>
+#include <babeltrace/values-internal.h>
#include <babeltrace/logging.h>
#include <unistd.h>
#include <stdlib.h>
#include <babeltrace/logging.h>
#include <unistd.h>
#include <stdlib.h>
const char *str_val;
int size;
int i;
const char *str_val;
int size;
int i;
+ enum bt_value_status status;
bt_common_color_reset());
break;
case BT_VALUE_TYPE_BOOL:
bt_common_color_reset());
break;
case BT_VALUE_TYPE_BOOL:
- bt_value_bool_get(value, &bool_val);
+ status = bt_value_bool_get(value, &bool_val);
+ if (status != BT_VALUE_STATUS_OK) {
+ goto error;
+ }
fprintf(fp, "%s%s%s%s\n", bt_common_color_bold(),
bt_common_color_fg_cyan(), bool_val ? "yes" : "no",
bt_common_color_reset());
break;
case BT_VALUE_TYPE_INTEGER:
fprintf(fp, "%s%s%s%s\n", bt_common_color_bold(),
bt_common_color_fg_cyan(), bool_val ? "yes" : "no",
bt_common_color_reset());
break;
case BT_VALUE_TYPE_INTEGER:
- bt_value_integer_get(value, &int_val);
+ status = bt_value_integer_get(value, &int_val);
+ if (status != BT_VALUE_STATUS_OK) {
+ goto error;
+ }
fprintf(fp, "%s%s%" PRId64 "%s\n", bt_common_color_bold(),
bt_common_color_fg_red(), int_val,
bt_common_color_reset());
break;
case BT_VALUE_TYPE_FLOAT:
fprintf(fp, "%s%s%" PRId64 "%s\n", bt_common_color_bold(),
bt_common_color_fg_red(), int_val,
bt_common_color_reset());
break;
case BT_VALUE_TYPE_FLOAT:
- bt_value_float_get(value, &dbl_val);
+ status = bt_value_float_get(value, &dbl_val);
+ if (status != BT_VALUE_STATUS_OK) {
+ goto error;
+ }
fprintf(fp, "%s%s%lf%s\n", bt_common_color_bold(),
bt_common_color_fg_red(), dbl_val,
bt_common_color_reset());
break;
case BT_VALUE_TYPE_STRING:
fprintf(fp, "%s%s%lf%s\n", bt_common_color_bold(),
bt_common_color_fg_red(), dbl_val,
bt_common_color_reset());
break;
case BT_VALUE_TYPE_STRING:
- bt_value_string_get(value, &str_val);
+ status = bt_value_string_get(value, &str_val);
+ if (status != BT_VALUE_STATUS_OK) {
+ goto error;
+ }
fprintf(fp, "%s%s%s%s\n", bt_common_color_bold(),
bt_common_color_fg_green(), str_val,
bt_common_color_reset());
break;
case BT_VALUE_TYPE_ARRAY:
size = bt_value_array_size(value);
fprintf(fp, "%s%s%s%s\n", bt_common_color_bold(),
bt_common_color_fg_green(), str_val,
bt_common_color_reset());
break;
case BT_VALUE_TYPE_ARRAY:
size = bt_value_array_size(value);
+ if (size < 0) {
+ goto error;
+ }
if (size == 0) {
print_indent(fp, indent);
if (size == 0) {
print_indent(fp, indent);
struct bt_value *element =
bt_value_array_get(value, i);
struct bt_value *element =
bt_value_array_get(value, i);
+ if (!element) {
+ goto error;
+ }
print_indent(fp, indent);
fprintf(fp, "- ");
print_indent(fp, indent);
fprintf(fp, "- ");
+ return;
+
+error:
+ BT_LOGE("Error printing value of type %s.",
+ bt_value_type_string(bt_value_get_type(value)));