summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
8a957c7)
When running test_bin_info (e.g. through
tests/plugins/flt.lttng-utils.debug-info/test_bin_info_i386-linux-gnu)
under Valgrind, I get:
==25792== 1,112 (88 direct, 1,024 indirect) bytes in 1 blocks are definitely lost in loss record 18 of 20
==25792== at 0x4C31B25: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==25792== by 0x55C2B10: g_malloc0 (gmem.c:129)
==25792== by 0x55C86F2: g_option_context_new (goption.c:361)
==25792== by 0x10CB25: main (test_bin_info.c:419)
Fix that by calling g_option_context_free.
Reported-by: Valgrind Memcheck
Change-Id: I9cd9a5ef786484169b9215744861af8cd6f5a9c8
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2739
Tested-by: jenkins <jenkins@lttng.org>
Reviewed-by: Francis Deslauriers <francis.deslauriers@efficios.com>
int ret;
GError *error = NULL;
GOptionContext *context;
int ret;
GError *error = NULL;
GOptionContext *context;
context = g_option_context_new("- bin info test");
g_option_context_add_main_entries(context, entries, NULL);
if (!g_option_context_parse(context, &argc, &argv, &error)) {
fprintf(stderr, "option parsing failed: %s\n", error->message);
context = g_option_context_new("- bin info test");
g_option_context_add_main_entries(context, entries, NULL);
if (!g_option_context_parse(context, &argc, &argv, &error)) {
fprintf(stderr, "option parsing failed: %s\n", error->message);
+ status = EXIT_FAILURE;
+ goto end;
}
g_snprintf(func_foo_printf_name, FUNC_FOO_NAME_LEN,
}
g_snprintf(func_foo_printf_name, FUNC_FOO_NAME_LEN,
if (build_id_to_bin()) {
fprintf(stderr, "Failed to parse / missing build id\n");
if (build_id_to_bin()) {
fprintf(stderr, "Failed to parse / missing build id\n");
+ status = EXIT_FAILURE;
+ goto end;
test_bin_info_build_id(opt_debug_info_dir);
test_bin_info_debug_link(opt_debug_info_dir);
test_bin_info_build_id(opt_debug_info_dir);
test_bin_info_debug_link(opt_debug_info_dir);
+ status = EXIT_SUCCESS;
+
+end:
+ g_option_context_free(context);
+
+ return status;