Fix: unchecked return value of cds_lfht_destroy

The sessiond should assert that cds_lfht_destroy returns 0 when
tearing down the 'pending rotate channel' hash table as a non-zero
value would indicate a leak.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/src/bin/lttng-sessiond/rotation-thread.c b/src/bin/lttng-sessiond/rotation-thread.c
index dcae248b4088c5aa068b871afbc37871176f532b..24ab0c8033fd715c829f036c67a2c3e891923c5d 100644 (file)
--- a/src/bin/lttng-sessiond/rotation-thread.c
+++ b/src/bin/lttng-sessiond/rotation-thread.c
@@ -261,8 +261,11 @@ error:
 static
 void fini_thread_state(struct rotation_thread_state *state)
 {
+       int ret;
+
        lttng_poll_clean(&state->events);
-       cds_lfht_destroy(channel_pending_rotate_ht, NULL);
+       ret = cds_lfht_destroy(channel_pending_rotate_ht, NULL);
+       assert(!ret);
        if (rotate_notification_channel) {
                lttng_notification_channel_destroy(rotate_notification_channel);
        }