From: Francis Deslauriers <francis.deslauriers@efficios.com>
Date: Mon, 6 May 2019 19:04:05 +0000 (-0400)
Subject: Fix: sink.text.pretty: Unsigned compared against 0
X-Git-Url: https://git.efficios.com/?a=commitdiff_plain;h=53dc85fa3e0012825e9f0128747f6f2fb54119d1;hp=ca79a87c7e8fa3bea26152033ee80fed43d64ba4;p=babeltrace.git

Fix: sink.text.pretty: Unsigned compared against 0

  CID 1401251 (#1 of 1): Unsigned compared against 0 (NO_EFFECT)
  unsigned_compare: This less-than-zero comparison of an unsigned value is
  never true. nr_fields < 0UL.

Reported-by: Coverity (1401251) Unsigned compared against 0
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Change-Id: I8aa8a03a6b03ca1640570d70a51729d001af3b66
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1263
Reviewed-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/plugins/text/pretty/print.c b/plugins/text/pretty/print.c
index 95189d5e..a53a567f 100644
--- a/plugins/text/pretty/print.c
+++ b/plugins/text/pretty/print.c
@@ -822,11 +822,9 @@ int print_struct(struct pretty_component *pretty,
 		ret = -1;
 		goto end;
 	}
+
 	nr_fields = bt_field_class_structure_get_member_count(struct_class);
-	if (nr_fields < 0) {
-		ret = -1;
-		goto end;
-	}
+
 	g_string_append(pretty->string, "{");
 	pretty->depth++;
 	nr_printed_fields = 0;