From ad4a95e0038a68747d4982815b8eaeae27e848d9 Mon Sep 17 00:00:00 2001 From: Christian Babeux Date: Mon, 30 Sep 2013 16:56:26 -0400 Subject: [PATCH] Add FIXME about endianess issue in Nexus binary file processing MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Christian Babeux Signed-off-by: Jérémie Galarneau --- converter/nexus/Application.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/converter/nexus/Application.cpp b/converter/nexus/Application.cpp index ced3fc08..d5c31157 100644 --- a/converter/nexus/Application.cpp +++ b/converter/nexus/Application.cpp @@ -150,6 +150,8 @@ bool Application::processBinFile_(const string &fn) while (!infile.eof()) { infile.read((char*) &byte, sizeof(uint32_t)); // Nexus binary files are Big Endian data + // FIXME: This assumes that the binary file will be read on + // a Little Endian machine. data = byte[0] << 24; data |= byte[1] << 16; data |= byte[2] << 8; -- 2.34.1