Move RCP plugins to the Trace Compass namespace

Change-Id: I99b76ca059ea50ecb341b9928f5b4e992e9004e6
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Move plugins to the Trace Compass namespace

We'll keep the name "TMF" for now to refer to the core framework.

Change-Id: Ifb221f2c8239feb0eb0e2e308cc24e094c6501e1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ss: Move plugins to Trace Compass namespace

Change-Id: I6cfee9874e9893d13374f05b139e73a6c8478fd7
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

pcap: Move plugins to the Trace Compass namespace

Change-Id: I8effa07aba182ee4796d007355e0f31e1b38b356
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Move plugins to the Trace Compass namespace

Change-Id: Iba52d6b728b235e76f1ce1fc0eb9a96c2205c702
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

gdbtrace: Move plugins to the Trace Compass namespace

Change-Id: I3407ed9c13052b2959c9446bedd4ceee52c10610
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ctf: Move plugins to the Trace Compass namespace

Change-Id: Ice502abf91920f0e5128193cff92e11b92847b72
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

btf: Move plugins to the Trace Compass namespace

Change-Id: I0723494466881a9d17ff9eb717554da130b47a11
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Rename parent, releng and target modules to tracecompass

Change-Id: I28e21dba39eacd4d28bb2845c9692a03ca5fecd3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Update README to reflect new commands

Change-Id: Ic663674af40a4b2cde7a397b10d9a7f4b92eb22c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Make Maven build possible with the new repo

This required:
- Importing some settings from Linux Tools's top-level pom.xml
- Maven'ifying our target plugin, and adding some missing elements
  (Wikitext, Antlr sources)

Change-Id: Id3db846ad90f1e6cfec97fe3a5189d41ae9b1b27
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Add 'last modified' and 'size' properties for traces

Change-Id: I037bd0eb7f6abb91fa73bcf3ca6fae93986f0eb3
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/33983
Tested-by: Hudson CI

tmf: Remove unnecessary System.gc since we now have SafeMappedByteBuffer

Change-Id: Ifa1297448a68e4903dcea7c21ee13bd5b8ed8c20
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/35004
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix source location on import from archive

Change-Id: I0f8a89b2c50d09745d71bada384d896fe6db01b1
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/34954
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: More performance improvements to the Resources view

In the Resources view, the CPU Status states are further split, when the
current thread switches mid-state, into sub-states by a drawing overlay.

There was no limit to the number of sub-states that this overlay
produces. It should be limited to at most one sub-state per pixel.

Furthermore the vertical bar delimiting these sub-states should not be
drawn when the sub-state is smaller than a pixel, otherwise the bars
can block the underlying state color.

Change-Id: I26fa3ef27ebbde41481fb210c702ddbf22a10773
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/34883
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Some performance improvements to the Resources view

On Linux/GTK, calls to getSystemColor, getFontMetrics and gc.stringExtent are
quite expensive. This patch minimizes those calls. As a future improvement,
we should look into optimizing calls to TimeGraphControl.getXForTime because it
calls Control.getSize() which is slow as well.

Change-Id: I63460e305d8de458dbee4b6cb162b6cf04e77054
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/34743
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix some leaks in the sequence diagram

Change-Id: Id2a1be23d7f3119e259df221df037c0813127e26
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/34674
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Offset traces ui

Change-Id: Ifbcfa32cddfaa21e6c526169e9b2b3a8f06fcf72
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/30689
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: lttngControl: fix: way to retrieve probe and function information

Change-Id: Ie47ac49b58de165397be92b23161f90faf43772d
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32440
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Cache the result of gc.getFontMetrics in callstack view

This is a major performance bottleneck on Linux/GTK when a lot of elements are
drawn.

Change-Id: I5259a8910f08b6602801f97fc200b00b7c55c4a1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/34605
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

TMF: Change API for synchronization files' folder

Some clients of experiment need a relative path, others need the absolute
path, the getSynchronizationFolder method is unified and the constant becomes
private.

Change-Id: I02688b55ec047820fbe756a269cf4bde3721a9b7
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/33133
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

XML state system: Add timestamp field to the current eventfields

It is sometimes required to get also the timestamp of the events.

Change-Id: I013d91cbba4732245b1981b4e88f9c7648d05ec8
Signed-off-by: Naser Ezzati <n.ezzati@polymtl.ca>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/34471
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI

tmf: Fix copy trace handler enabled in unrelated dialogs

Ctrl-C no longer opens the Copy Trace dialog from another dialog when
the current selection in the Project Explorer is a trace element.

The same fix is applied to the copy experiment handler.

Change-Id: I4eb9df578d2227b74312d7fe660b2a3caf2b2627
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/34415
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Revert "XML state system: Add timestamp field to the current eventfields."

This reverts commit d4507ad7c220770cfc698db62874fb46b79888db.

This introduced a new field in a public interface, which is a major API break.
Let's revert it for now, and get it into Trace Compass.

Change-Id: I2bc0ebe90f438ca72a1156878ed0f300c5492183
Reviewed-on: https://git.eclipse.org/r/34470
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Include the "alltests" plugin in the sync-settings script

Change-Id: Icb22e027f0d892fbb0390bb77b724c407a07420e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/33470

statesystem: Remove duplicate empty state creation

The transient state already creates a "null" value for every state
attribute that is added. No need for the attribute tree to do an
explicit insertion immediately after (which gets ignored any way).

That attribute tree should also keeps its paws off the transient state,
but that's a different problem.

Change-Id: Ib77e16d67375e65c495b9ff0b73c5cee78eddf02
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/33076
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

XML state system: Add timestamp field to the current eventfields.

It is sometimes required to get also the timestamp of the events.

Change-Id: I7166f0c27431696e93432a47cb7f3f36c5277382
Signed-off-by: Naser Ezzati <n.ezzati@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/34317
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tracing rcp: save workspace during shutdown

Change-Id: Ifa4413602ca8543997dccea82764508ff7f429be
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/34405
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

tmf: add SWTBot tests for collapsing feature (disabled for now)

Change-Id: I67952062a74c744ca7ef8abce474bb92ebfa328c
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33846
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Annotate 3.2 APIs

Many APIs were not actually part of 3.1, mark them @since 3.2 instead.

Change-Id: Idf17db685b4c0ed57c7e772f2718bdb0bfeffc03
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/34242
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI

tmf: use in memory index for sequence diagram test cases

This makes sure that each test class starts with its own index and
doesn't reuse an existing index on disk.

Change-Id: I3d4497603ed1ea79bc2cdf6e055f43767d4dcbb4
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/34219
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

Fix temp directory path when workspace path contains a space

Change-Id: I9066def7c55d8c324cfe30e82bf320a107bb67e0
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/34167
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix missing trace properties

The 'Trace properties' category (e.g. CTF properties of an opened trace)
was missing due to change of trace path to OS String.

Change-Id: I5592f4e979e86f2a33225065832c685e7020aad6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/34152
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng/tmf: Update guides for collapsing feature

Change-Id: I25b858c6cc61a462662a4c5471528085d1cd7ed6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/34149
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Fix alltests pom version number

Change-Id: I49b4826ad6d14b4354dbe3031af838f20fc805dc
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/34156
Tested-by: Hudson CI

TMF: Do not add synchronization data for traces from the same host

Change-Id: Ia45d7568a80a731672cee1d33211451d55a5c922
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/34067
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Support incremental update of Call Stack view

Change-Id: I3fcbd3569a28b16f53755cb346c2b59741509222
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/33720
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: support collapse filter in events table

Change-Id: Iaa87955affa8004764a92e078c51cd854850f44a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32350
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: add filter for collapsing of events in event table

Change-Id: I2641ff7df5039bdd294846f315a6955687aac84c
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32349
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: add interface for collapsing of events

Change-Id: Ic29ea3b588bc1c3633968a1ef7c086eced1161d5
Reviewed-on: https://git.eclipse.org/r/32348
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Do not use java.io.tmpdir property (/tmp) when possible

This is problematic when multiple instances of Eclipse are running
(builds).
Instead, we can create a "temporary" folder under the Eclipse workspace
so
that each Eclipse instances are independant. This also has the advantage
of
the directory being cleared every time a mvn clean is executed or when a
JUnit launch configuration is used inside Eclipse.

Change-Id: I3c7fb17d4b36e7ba5fe054ea9d81667c465e75b6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33728
Tested-by: Hudson CI

Bump features to 3.2.0-SNAPSHOT.

Change-Id: I08a5bd3b0a3892c66537997668dedd36e88474c0
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/33993

lttng/tmf: Minor user and developer guide updates

Change-Id: Ibba6c22d5e39742761ba6b131366ab5686109393
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33851
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf xml: Add the possibility to display value delta in XML XY views

For now, the xml xy viewer only showed the value of an attribute as is. This
addition allows to show also the difference between the values at timestamp t
and timestamp t-1.

Change-Id: I35e001054def796bd2da19f50d491bf5ad8921af
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/33705
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

TMF: Address comments on the trace stub for unit test patch

Some comments were mentioned in patch https://git.eclipse.org/r/#/c/21265
They are addressed in this patch.

Change-Id: I6dc940d5a5fcb7e920c934ce0b6a86adc8fbf860
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/33718
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Support locale in timestamp format and time preferences

Bug: 439917
Change-Id: I14b90bed61ed0f6174f27852fa7fad72bfa5d41e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/33576
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

TMF xml: Add toString() methods to the XML model classes

And a message when throwing some exceptions so that we have more information
when debugging XML analyses.

Change-Id: I935f5727a612f9c4b96d5d8ade998ed4b673d3ba
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/33699
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

swtbot/tmf: pull out opentrace to SWTBotUtil

Change-Id: Id4f97e45a336b4025cec0d097f0a167b87c11c57
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33518
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

TMF: Add trace stub for TMF unit tests

This new trace type uses a custom XML definition and converts custom XML
events to TmfEvents, where the fields and their values are defined through the
XML fields. To illustrate, here is the content of each type of event:

CustomXmlEvent: fields = "a | b", values = "1 | abd"

would transpose to this

Development trace: a = 1, b = "abd"

This type of trace will be useful to unit test analyses involving LTTng kernel
and UST traces for instance.

Change-Id: I41ac7206c1a54088c998d551a4174f2184b05f5b
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/21265
Tested-by: Hudson CI

lttng: Cleanup the state system tests

Only use @Before/@After (not the -Class variants), and make it more
clear which class is responsible for which resources.

Change-Id: Ic1e2d0b7edbdac5eec250bd2d4a6cbacc9181843
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/33222
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Updates to the lttng.alltests plugin

- Split RunAllTests in RunAllCoreTests and RunAllUITests
- Move other Run*Tests to their own packages
- Add a default launch configuration for the RunAllCoreTests, to specify
  to not run in the UI thread. This is required to avoid problems like
  Job's never being disposed.

Change-Id: I085b4a1ae87635b28a9d0c0ba7fcd7f1dfe303b4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/33223
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: remove some returns from finally blocks

Change-Id: Id0c9caa3c54f1ed168c63347e4ee3f5d473d78e6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33621
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

TMF: Fix a bug where the label of an XML XY chart is not considered

Change-Id: I055395e8ab91b0551f54d91fb54ef71d9df4c1a7
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/32728
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: add xml wizard ui rudimentary test

Change-Id: I5c51bd14819f3cffd3d8ca7824721da8235fba72
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/30258
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: make CTFTraceReader access streams in consistent way

make all accesses pass by getTopStream() accessor

Change-Id: I41b21289d8d7bff7bcf56273545e2c1190af1eef
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32566
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Bug 443994: Contextual menu defines conflicting delete handlers

Change-Id: I5affff5ef2a3812057637c51e1a1278d72e2146b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/33511
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

tmf: Additional SWTBot tests for the standard import wizard

Change-Id: Id776ed33768ddc640c8ba5f6c23c6e1ecd79ab33
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33480
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Change time graph mouse wheel behavior

The mouse wheel now scrolls up or down while over the time graph states
area. Zooming in or out can be performed by holding the Ctrl key while
scrolling the mouse wheel.

Change-Id: Ia544bb498a7a6ed9b50eb36f7cf3e2a6bb300400
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/30288
Tested-by: Hudson CI

Squashed commit of missing user guide updates from stable-3.0

tmf: update user guide to have UST section

Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/27504
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Update introduction and installation of user guide

Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/27402
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
tmf-guide: Introduction chapter about TMF built-in views and viewers

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/28065
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
tmf: Developer guide update about trace types

Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/27952
Tested-by: Hudson CI
Reviewed-on: https://git.eclipse.org/r/33466
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
Tested-by: Jeff Johnston <jjohnstn@redhat.com>
Change-Id: I217ae1c2c0729f4064745fee5dbe487bfc5d82ff
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33467
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Disable "Value of parameter is not used" warning

Recent versions of JDT in Eclipse 4.5 now include exception
parameters in the "value of parameter is not used" setting. This
throws upwards of 400 errors with our current settings.

Bug #439750 explains the problem. Bug #441933 tracks the addition
of a new UI preference to handle exception parameters separately
from method parameters.

For now, we can set the setting to Ignore to make Eclipse integration
builds useable. Once the two bugs above are fixed, we can revert
this commit.

Change-Id: I5db6322eb6d7ae3c2bb98ee983d0824e0e8fc9e2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/33469
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Add cycles time format and delta format in time graph

Change-Id: Iaa0e750971bf7b06a6209f7528e8c293be816d9c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/33339
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Remove unused references to old Batch Import command

Change-Id: Iee1e58a4194ba9e55f7ce33f7939ec21b13ed6ab
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/33408
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Fix pom.xml parent version position

- Moving version after parent id allows us to use a simple
  sed script to remove -SNAPSHOT before an official release

Change-Id: I4baab3daca4adec37b9aed6b24caba75fd6cdd4d
Reviewed-on: https://git.eclipse.org/r/33287
Tested-by: Hudson CI
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
Tested-by: Alexander Kurtakov <akurtako@redhat.com>

Add missing license headers.

Change-Id: I941980fe78669bcf8728c42660486869b41dac93
Signed-off-by: Andrew Ferrazzutti <aferrazz@redhat.com>
Reviewed-on: https://git.eclipse.org/r/33394
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
Tested-by: Alexander Kurtakov <akurtako@redhat.com>

tmf: Correctly dispose sub-components of a partial history backend

This will avoid lingering "event handler" threads when using partial
state histories.

Change-Id: I6044faa1c41a634e605161858b03ffb37b9e97ac
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/33221
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Provide (internal) API to customize Import Trace Wizard Page

Change-Id: I0471a64f000c06fcbe274aaa765154c1cec76503
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32560
Tested-by: Hudson CI

ctf: Reduce complexity of CTFTrace#openStreamInput

Change-Id: Id9ffa4ddffbe5e44640c5703af9ca1581bbfb74b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32563
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

tmf: Update User Guide for custom parser category support

Change-Id: Idce7640b0e8ff0475dc0ffaf4e29a74475730124
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/33079
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

tmf/ctf: lower memory usage of events with fixed length strings

Change-Id: I87149b8cb1c94e8fea8a90801cd254d9c3dc02ea
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32075
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

CTF: Add some documentation on CTF test traces

Sometimes, for a unit test, we just need a trace and having the trace length,
size and event count may help choose the right trace for the right test.

Change-Id: Ibc963509c0c7b08ab74b8a69cc34f33f5462768e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/32555
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

rcp: Make archive file name compatible with Maven 3.2.2

The build timestamp format changed in Maven 3.2.2. See
https://jira.codehaus.org/browse/MNG-5452

This means the archive name now looks like
linuxtools-trace-viewer-1.0.0-2014-09-05T21:50:43Z.linux.gtk.x86.tar.gz

This is especially problematic on Windows because colons are used to
specify devices. The format can be changed by to the original format with
a property.

Change-Id: I6c0ec7cc0e8a18ef6a20fb43cc19eadbed80670f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32961
Tested-by: Hudson CI

tmf: Do not use Display.sleep in tests

Similar to bug 415992 and change 25443. The display needs to be woken up
because it's possible to get in a state where nothing will wake up the UI
thread (events, messages), especially if the tests are being run unattended.
Instead of using the highly implementation-dependent solution of doing a
Display.asyncExec (which only works on Mac, not Windows), we can simply not put
the display to sleep and just have the thread sleep. This is safer because
Display.sleep by definition should not wake up until an event is received which
we cannot guarantee will happen.

Change-Id: Ib2282bcd71c9376d7bbdb084c094892146410ff7
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33257
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Invalid thread access when deleting trace or trace folder

Bug: 439449
Change-Id: Id2f7b940a0afcd35bb0baca710b15ebb5d156298
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/29828
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Delete suppl. files *after* the trace has been disposed in a test

That way the file handle won't be still opened when trying to delete
the suppl. folder (Windows).

Change-Id: I6e43442d715389fd3ba5265a96d9de534701f7d8
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33255
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Adapted ExportToText feature to new events table column API

Change-Id: I11d9e500fb19c368233047c153205b2a9fba807d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32496
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Also check if the trace type exists in select traces dialog

Change-Id: I26734465a54bc1d6ca865e035ce3259dbf956521
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33282
Tested-by: Hudson CI

tmf: Fix untyped traces being shown in the select traces dialog

Bug: 443737
Change-Id: Ifc1902341a4673a268ac0d540346a50cb5e5c9cc
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33202
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix a test when running from alltests plugin

Change-Id: I9649c0e6f384b6b5c075898ccc541e941a7a2b1e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32965
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Fix NullPointerException drawing time graph arrows

Change-Id: Ic3fd6c9646a4d6a62c6421ab5392fe0d4f4b152c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/33213
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Improve SS Explorer filter button description

Change the filter button's tooltip in the State System Explorer from
"Display Only Change" to "Only Display Changes at Selected Timestamp".
This is more representative of what this option does.

Refs bug #419515.

Change-Id: I457627d2ff60b2efee9f8f962a00e883b0a8e63c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/33153
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI

rcp: Update version number to 1.1.0

Change-Id: I59a0f93f1255bf09cd7f51c30ce1e05e9f8345d3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33123
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33138

lttng: Increment the version numbers to at least SR1 numbers

Change-Id: I3169329580cf77e01dbf0fee55fce2ce2f7aa229
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32887
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Javadoc fixes.

Mostly typos.

Change-Id: If150c1c7644e6846a4b56a0e8efd153aab90cddc
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/33178

tmf: Fix a few other cases of not using toOSString

Bug: 443646
Change-Id: Ibffd262432e5b231132a5738717016f8556ac2ae
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33077
Tested-by: Hudson CI

tmf: Fix IllegalArgumentException when importing from the root directory

Bug: 443651
Change-Id: I5fb050a4c35f27c4393f30ba0b9836cc656e76de
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33152
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
(cherry picked from commit 47d1ed9b786018f2f5da5c86a1fa2d4386fd8c9f)
Reviewed-on: https://git.eclipse.org/r/33154

tmf: Use the class name if no ID is specified for analysis modules

Since there is no abstract method or other compile-time check, we can't
expect all modules to know they have to specify an ID. If they don't, we'll
infer one from the full class name instead of filling the log with errors.

Change-Id: Id1f83dcb782573aa87b2128a3864a85c4cdcffd3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/33084
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>

[lttng control] Fix snapshot command output parsing (Bug 443519)

Change-Id: Icb2915486ad1c9c4e26ba8c3ef7f5f6a9a5c9dad
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33060
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

gdb: Improve GDB trace file validation

Change-Id: Ia09daf6816a3638a2c061e940112ad264c3b44b5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/33136
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI

lttng: Increase number of iterations in benchmarks

Change-Id: I09625d783f070cb5b671c3ceb23e2af113391c49
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32962
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: Catch ParseSyntaxException in custom text parser wizard

Change-Id: I1ac66cacbc5d1d26ff06dbbe4920d31702cf3704
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/33081
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Add a testing feature that contains all tests

Change-Id: I1389c99321c7b9f9e8016e58baa365fc17c523ad
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32956
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI

tmf: Improve synchronization in TmfRequestExecutor

If the TmfRequestExecutor is overwhelmed by event requests, it can
freeze the UI thread for long amounts of time and lead to a pretty
bad user experience. (An easy way to test this is to select an entry
with lots of state changes in the CFV, and hold down the right or left
arrow key.)

This patch:
- Makes it use Queue.offer() instead of .add(). This avoids spewing
  exceptions in the console once the queues are full.
- Actually cancels the requests if the offer() fails. Before, even
  though they would not be put in the queue, they would still exist
  and still wait to execute.
- Drastically reduces the size of the request queues. If we are in a
  case where the handler receives requests faster than it can process
  them, instead of giving the user false hope that we will process them
  in a reasonable time, just cancel them so that the UI can go back to
  being responsive faster (see bufferbloat).

The "correct" fix would be to make sure on the request sender's side that
we don't send to many requests, and correctly cancel obsolete ones.
But independently of the sender's implementation, this patch makes the
executor degrade more gracefully.

Change-Id: I0072d54bb7a403773fd4288a42bfb73c4614189b
Reported-by: Simon Marchi <simon.marchi@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/32115
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Support tool tip for arrows in time graph

The tool tip will show the time link event information of the closest
arrow to the mouse position, provided that it is within 5 pixels.
Holding the Shift key will disable the arrow tool tip so that the tool
tip can show the information of the underlying state.

Change-Id: I5f4daaea130817a16dd5d222b262cb0ec9aee76b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32875
Tested-by: Hudson CI

TMF: added support for process filter in the TimeGraphFilterDialog.

On top of the filter dialog a text field enables filtering over the
tree of process names.

A node of the tree is shown if:
- the node matches with the search pattern
- one of the children of the node matches with the search pattern
- one of the parents of the node matches with the search pattern

The buttons check-all and check-subtree check only the visible items.
The button uncheck-subtree unchecks all the children (the hidden
children too, since it makes no sense a checked child with an unchecked
parent).
The button uncheck-all unchecks everything, except the hidden roots
(and corresponding subtrees).

Change-Id: I517f3333bb7b6da9fd14eaaac90e7b914671479e
Signed-off-by: Generoso Pagano <generoso.pagano@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32404
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix some NLS Message strings

Change-Id: I41b3e8ce64b9fca5150681f487786826a2ce968c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/33062
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI

tmf: Resolve trace type name conflicts on custom parser import

Change-Id: Id2ee9c86a88c29fbc86638556fb9b83df06d70e7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32573
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Make default (built-in) custom parsers uneditable

Change-Id: Ia96451ffca8dafa29d176401dc23450e975e1b70
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32572
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Support category in custom parser wizards

Change-Id: I9655a997bdcec4659a5189eeaf1e812d86e3a3d0
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32280
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Support custom parser category in utils, properties and commands

Change-Id: I0b865646d14000259d8f19f9c6a9630ed9a516ef
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32279
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Add category to custom parser definition

Change-Id: I882676278acca7398e4adee5c4f485bb20cda083
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32278
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>