Alexandre Montplaisir [Mon, 4 Jul 2016 19:09:48 +0000 (15:09 -0400)] 
tmf: Remove redundant booleans in TmfEventRequest
The booleans and CountDownLatches do the same thing, they can
be merged together.
Change-Id: I77e26cbeb7e9166f8997d5a33571f993616c3cb2
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76551
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Raphaël Beamonte [Thu, 7 Jul 2016 16:22:38 +0000 (12:22 -0400)] 
ss: add a 'done()' method to ITmfStateProvider
This approach was previously used in the ITmfGraphProvider but not
available in the ITmfStateProvider. This allows, when needed, to finish
up the provider's work when the trace has been fully read, in order to
obtain a finalized state system when data are on hold until the trace end.
Change-Id: Ic6988e6e25936796eb8de48520dcf95e0a4690bb
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Reviewed-on: https://git.eclipse.org/r/76884
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Matthew Khouzam [Mon, 4 Jul 2016 20:19:49 +0000 (16:19 -0400)] 
doc: update XY charts view controls
The CPU usage/UST Memory/Kernel Memory view and all XY
charts control scheme is updated to match time graph views.
Change-Id: I261216a3610835913ad00228a090868338317b17
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76544
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Wed, 6 Jul 2016 06:58:21 +0000 (02:58 -0400)]
analysis.lami: Replace Activator info logging with JUL
That way the commands that are run every time a kernel trace
is opened won't show up systematically in the command-line
output.
We can continue logging critical errors to the Activator for now.
Change-Id: Ifa0c9dfabe89f20747776366cced22ff12caca71
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76671
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 5 Jul 2016 23:40:06 +0000 (19:40 -0400)]
lttng: Use getFieldValue() for some field retrievals
Change-Id: Ide8835b047d69dbf0f40672c49f93853bf6d4699
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76628
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Bruno Roy [Wed, 29 Jun 2016 18:52:08 +0000 (14:52 -0400)] 
doc: Document the exclude event feature
Documentation for the exclusion of UST events by name feature. This
feature is in the Control view under the UST tab.
Change-Id: I60e2f27f40a67f2fd4b39d0532b0644831b8ff07
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76238
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Geneviève Bastien [Thu, 30 Jun 2016 08:39:27 +0000 (10:39 +0200)] 
tmf: Bug 460036: Fix multiple XML views when reopening TraceCompass
Save the XML view data in persistent store per secondary ID so the multiple
views remain when reopening the trace.
Change-Id: I1ef9abe668c76e72a51f74c818768996fa8a1e20
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/76526
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
rjongeling [Thu, 30 Jun 2016 08:39:27 +0000 (10:39 +0200)] 
tmf: Bug 460036: Allow opening of multiple XML Analyses of same type
Show views using secondary id, allowing multiple XML views of the same
type.
Change-Id: I5dcce426877da2a44064bb29e1ab56640d9f2b32
Signed-off-by: rjongeling <robbert.jongeling@alten.nl>
Reviewed-on: https://git.eclipse.org/r/76301
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Matthew Khouzam [Fri, 26 Feb 2016 18:48:00 +0000 (13:48 -0500)]
ss: cache TmfStateValue String creation
This patch adds a direct mapped cache to the TmfStateValue#newValueString
method. This method is used heavily in the Lttng Kernel State Provider.
Using KernelAnalysisBenchmark, this patch increases the performance by 5-10%
Change-Id: Ib0bece8eb606186086cbb4843944e438cf5fbf98
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67455
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Bruno Roy [Mon, 6 Jun 2016 18:54:22 +0000 (14:54 -0400)]
lttng.control: Replacing isKernel with an enum for the domain type
Since we are adding a support for a new domain (JUL) the boolean value
isKernel is not enough anymore. I changed it for a enum type
TraceDomainType.
Change-Id: Id7e9bb5f739e93255a6770bc5813a2822dcb085d
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74798
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Tue, 5 Jul 2016 17:45:06 +0000 (13:45 -0400)]
lttng.ust: Replace timestamp.getValue() with toNanos()
If a trace with a different time base is used, there will be no errors in time scales.
Change-Id: Ia13bb9ab0c98dda8d10cfb4d02ee62bf0a820fa0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76633
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
Alexandre Montplaisir [Tue, 5 Jul 2016 19:25:12 +0000 (15:25 -0400)]
tmf: Add utility method to retrieve field values
It's very common when handling trace events to expect fields
of a certain type. The common pattern to handle an event field
would be:
- field = content.getField()
- make sure field is not null
- value = field.getValue()
- make sure value is not null and of the expected type
Doing this every time we want to read a field is very
cumbersome, we can add a getFieldValue() utility method to
directly get the value into the expected type. So then we
just need to:
- content.getFieldValue(expectedType, fieldName);
- null-check the result
Change-Id: Icff8de7772d8ba8ed66880668cf14c26a07b2573
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76646
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Geneviève Bastien [Mon, 18 Apr 2016 16:24:52 +0000 (12:24 -0400)]
ss.tests: Move HT integrity check to an assert method of the stub
Change-Id: I55ba757873a4c582d1f4ce4d1c5baf19d1167570
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/70890
Reviewed-by: Hudson CI
Geneviève Bastien [Mon, 18 Apr 2016 16:20:26 +0000 (12:20 -0400)]
ss.tests: Add unit test for intervals before start time
Change-Id: I42704a18810e5b7899d24addbed9d17221289ac8
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/70887
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Geneviève Bastien [Mon, 18 Apr 2016 14:51:41 +0000 (10:51 -0400)]
ss: Add timestamp parameter to debugPrint for intervals
Printing the intervals is useful for debugging, but for large history trees,
it can get very big. Printing only nodes intersecting a given time range may
be more realistic, for instance to debug an incoherent interval storage when
querying at time t.
Change-Id: I0d71725c6cbe3bd3ad8abf9e9b5d7588aefc094f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/70886
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Sonia Farrah [Wed, 11 May 2016 17:42:13 +0000 (13:42 -0400)] 
ss: Make modifyAttribute()'s value parameter @NonNull
Change-Id: I2adbf60b127f8cb7acd040b7214b3ae4dc921406
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72550
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Wed, 29 Jun 2016 21:25:33 +0000 (17:25 -0400)] 
lttng.ust: Properly null-check the debug info state system
When opening a trace, some views (callstack etc.) might request
binaries before the state system is properly loaded,
so the checkNotNull() check can fail. Actually reply that the
information is not available, instead of breaking the whole trace.
Change-Id: Iba14ac2ffac6f01d45bba4dba9f946372777b5db
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76255
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Bruno Roy [Wed, 29 Jun 2016 18:08:08 +0000 (14:08 -0400)]
control: Moving the loglevels radio buttons over the drop down menu
Moving the loglevel and loglevel-only radio buttons over the drop down
menu instead of being underneath it. This is because most of the time
the drop down menu is going down and it hides the two radio buttons.
Those are in the enable event dialog box in the Control view under the
UST domain tab.
Change-Id: I434255ba3fd0b9e88cdd3c759c1a50cba09ea3c6
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76236
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 23 Jun 2016 20:18:22 +0000 (16:18 -0400)]
ss: Remove cache-level synchronization in HT_IO
The LoadingCache supports multi-threaded access, we can remove
the "synchronized" on the methods and only lock at the object
level whenever we need to hit the disk.
Benchmark results of the HistoryTreeBackendBenchmark comparing
the current master version and the LoadingCache + this patch:
(using System Time in all cases):
Master LoadingCache + no-cache-synchro
Average
Build: 262ms 284ms
Single Queries: 15ms 12ms
Full Queries: 13ms 11ms
Query History Range: 147ms 120ms
Vertical scaling
Build: 17.77s 19.82s
Single Queries: 2.92s 3.2s
Full Queries: 4.14s 4.42s
Query History Range: 48.06s 57.03s
Horizontal scaling
Build: 10.54s 9.82s
Single Queries: 186ms 110ms
Full Queries: 157ms 86ms
Query History Range: 14.52s 13.61s
Interval distribution uniformly distributed
Build: 428ms 402ms
Single Queries: 31ms 24ms
Full Queries: 26ms 16ms
Query History Range: 368ms 443ms
Interval durations with 10 percent outliers
Build: 238ms 215ms
Single Queries: 12ms 9ms
Full Queries: 12ms 9ms
Query History Range: 120ms 92ms
Data type strings
Build: 302ms 288ms
Single Queries: 36ms 29ms
Full Queries: 27ms 8ms
Query History Range: 333ms 107ms
Data type longs
Build: 256ms 250ms
Single Queries: 16ms 13ms
Full Queries: 13ms 8ms
Query History Range: 151ms 91ms
Data type doubles
Build: 264ms 248ms
Single Queries: 18ms 14ms
Full Queries: 14ms 7ms
Query History Range: 161ms 90ms
The "vertical scaling" seem strange, but remember this is a
degenerate case where the average node usage is rounded to 0%.
The LoadingCache seems slightly less resilient to cache thrashing,
(which makes sense for LRU vs. direct-map in general) but it's
faster in all other regular use cases.
Other patches are being worked on to avoid trees with very low
node usage.
Change-Id: I96e32d99febb1dbbe7f9d2b473d15307c4b8e2e5
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/75886
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Geneviève Bastien [Fri, 13 May 2016 18:52:44 +0000 (14:52 -0400)]
critical path: Clean up link list of content provider
The link cache was not used because it was written to one map, but read
from another. So links were computed every time
Change-Id: Id3533034be15e1e974160338d9d5e56bda84992e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72761
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 14 Apr 2016 21:23:19 +0000 (17:23 -0400)]
ss: Rework the HTNode cache
Reimplement the HTNode cache as a Guava LoadingCache. This
nicely abstracts the loading logic, and will also allow
making cache accesses multi-threaded.
This also changes the log points from CacheHit/CacheMiss to
CacheLookup/CacheMiss, since the "cache hit" branch is now
entirely part of the Guava library, so we cannot instrument
it. Same information is available, it will just have to be
computed differently.
Change-Id: I267008c69f9d6f4ada0257dee45b2a79902b8c84
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70713
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Bruno Roy [Wed, 29 Jun 2016 15:19:28 +0000 (11:19 -0400)]
doc: Document the enabling specific event by name feature
Documentation for the enabling specific Kernel event by name feature.
Change-Id: Iab8600a0cf42b2d05633bf24ab805986896a9279
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76233
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bruno Roy [Wed, 29 Jun 2016 15:26:42 +0000 (11:26 -0400)]
control: Change the string label for specific event in the Control view
The label for enabling specific event by name is now "Event Name"
instead of "Event Type". This is to be more consistent with the other
fields of the dialog window.
Change-Id: Id4237d53f76b43bc146107cd9a6eee301ddde0df
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76224
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Tue, 28 Jun 2016 20:16:43 +0000 (16:16 -0400)]
tmf: Speed up TmfTraceUtils#getPreviousEventMatching
This patch makes the reverse search look back by the cache
size of the trace, then iterating on the chunk in reverse
order to find a match. This allows returning as soon as
we find a matching event.
Change-Id: Iaed2c2326d5a4939688df7ba6d13696811d1c165
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76164
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Tue, 28 Jun 2016 22:03:05 +0000 (18:03 -0400)]
Introduce a MAINTAINERS.md file
This file will list the current project committers and maintainers,
along with their assigned section of the code base.
Change-Id: I42c535514648b7bc91d7ec5c6460bc5bd11add03
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76173
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bruno Roy [Tue, 14 Jun 2016 14:17:40 +0000 (10:17 -0400)]
control.test: Add tests for the exclude feature in Control view
Test the exclude feature with the LTTng service. Also test the UI with
SWTBot tests.
Change-Id: I2afd0fdfa8a1c85b375528c58e0977aa98f4b060
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74320
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Geneviève Bastien [Wed, 15 Jun 2016 19:59:25 +0000 (15:59 -0400)]
custom parsers: Add unit tests for custom event names
Change-Id: I53470bc5c67bd0f7dfbc9089294544a7c50e9753
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/75479
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Mon, 27 Jun 2016 22:09:36 +0000 (18:09 -0400)]
ss: Relax but enforce the character limit in HTInterval strings
The string parsing logic in HTInterval casts the string length to
a byte, which can result in a negative value (and subsequent
NegativeArraySize exception) if the string is actually > 127 bytes
in its encoded form.
A comment mentions that the string length is checked at the
constructor, but this is false! No check is done whatsoever.
The limit should be checked.
While at it, the current limit of 127 bytes is very small for
string values. File system paths for example can easily add up
to more than 127 characters. For this reason, use a short (2 bytes)
instead of one byte to store the string length, which allows for
strings up to 32,767 bytes.
Finally, specify UTF-8 encoding explicitely. This is what was
happening on most platforms already, but it's a better practice
to specify it, and it makes static analysis happy.
Also happens to fix:
Bug: 496864
Change-Id: Ia801782696a1574568d52c52775d475ed2dcf173
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76060
Reviewed-by: Hudson CI
Alexandre Montplaisir [Mon, 27 Jun 2016 20:46:13 +0000 (16:46 -0400)]
ss: Properly implement hashCode/equals in HTInterval
The equals() was wrongly calling .compareTo(), which only
checks the end times, not the whole object.
Change-Id: I235d01b3cd19a668e0808233eedcd5c1f50c5b57
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76059
Reviewed-by: Hudson CI
Alexandre Montplaisir [Mon, 27 Jun 2016 19:41:51 +0000 (15:41 -0400)]
lttng.ust: Properly null-check the debug info state system
When opening a trace, some views (callstack etc.) might request
symbol/function names before the state system is properly loaded,
so the checkNotNull() check can fail. Actually reply that the
information is not available, instead of breaking the whole trace.
Change-Id: I9cb5446b00444d2b8388e9f21a5822187fd30734
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76058
Reviewed-by: Hudson CI
Geneviève Bastien [Tue, 14 Jun 2016 18:27:30 +0000 (14:27 -0400)]
ss: Add JUL logging to some classes
This patch adds JUL log points to the state system queries and
to the HT_IO cache hits and misses.
Change-Id: I7dbbc9ec79f0da4a23cd2bc8756ebd3e0eea3b0c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/75274
Reviewed-by: Hudson CI
Geneviève Bastien [Tue, 14 Jun 2016 15:19:06 +0000 (11:19 -0400)]
common: Add JUL logging to TraceCompass
Logging allows to add tracepoints at various places in the code, and at runtime
enable log handlers for specific components to produce log files that can then
be analyzed by various tools... like Trace Compass!
This patch is a first suggestion for adding logging facility to TraceCompass.
Here is the suggested approach:
* Logging has a small overhead, so they should have a negligible performance
impact performance if they are not overly used.
* Logging must be explicitly enabled at runtime by setting a parameter to true:
-Dorg.eclipse.tracecompass.logging=true in the vmargs
* Each class should have their own logger, using the class's full name
(canonical name). It is thus easy to filter which classes to log using per
logger name. For example, logging org.eclipse.tracecompass.tmf will log all
loggers that start with o.e.t.tmf.*
* Abstract classes should use their concrete class's name, to match the log
statements to their concrete component.
* The TraceCompassLog class contains a wrapper methods to retrieve loggers.
Calling it makes sure that the main logger's level has been set and the default
values set by java (info level with ConsoleLogger) are not used.
* What is non-negligible in logging is often the message being logged. To be
meaningful, the message will often add parameters concatenated to a string
and that can be very costly. Messages should be lazily constructed using
the logging statements taking Supplier<String> in parameter. For example:
LOGGER.log(() -> "My msg " + param1 + " " + param2);
* Log levels, handlers, etc can be controlled via a configuration file set in
the vmargs: -Djava.util.logging.config.file=/path/to/logger.properties. An
example logger.properties file can be found here:
https://wiki.eclipse.org/Swordfish_Documentation:_Turning_On_Logging
* To help logging trace parsing, the log strings should have the following
format: [EventName:MayContainSemiColon] paramName1=param1, paramName2=param2
Change-Id: Ia6cde4256799705a9f13c71b70576eb09cc3d427
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/71819
Reviewed-by: Hudson CI
Alexandre Montplaisir [Tue, 28 Jun 2016 23:06:09 +0000 (19:06 -0400)]
tmf: Add a few tests to TmfTraceUtilsSearchingTest
Test the behavior of the search when there is no event match.
Change-Id: I6c6bfb76acf73151851cab766f5d57026f7da7d8
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76226
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Geneviève Bastien [Thu, 26 May 2016 21:20:03 +0000 (17:20 -0400)]
custom.parsers: bug 494697 Define event names in custom parsers
In custom traces, all events had the same name which corresponded to the
custom parser name. Now it is possible to define a field for the custom
event type.
Change-Id: Icdef3b0dfc73e403b39bd7ceb0e8ff2afaa12db2
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73803
Reviewed-by: Hudson CI
Alexandre Montplaisir [Fri, 3 Jun 2016 23:27:17 +0000 (19:27 -0400)]
Update formatter settings for all plugins
Update all formatter settings files to the Eclipse 4.6 synthax.
The only value that was changed was to allow wrapping at method
invocations. This means that successive method calls on separate
lines won't be auto-unwrapped anymore:
list.stream()
.map(...)
.filter(...)
.collect(...)
All the other settings are simply new ones, left to their default
values.
Change-Id: I4d405f4954c1587dfafde23cd9f1058bf515b7c0
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74106
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Tue, 28 Jun 2016 18:11:24 +0000 (14:11 -0400)]
lttng: Stabilize CriticalPathTest
To reproduce the issue:
Inside CriticalPathView.CriticalPathContentProvider.BuildThread.run()
add a Thread.sleep(5000) just before the refresh() call.
It fails because we get all the tree items of the Critical Path view
before the algorithm and the redrawing is done. Since not all of this
process is done in a job, the waitForJobs is not sufficient. Instead,
wait for the UI to update in the state we want to "assert" on.
Bug: 496588
Change-Id: I2617b017f1d94f000600cd2f25ccce98b3cfe5be
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76153
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Tue, 28 Jun 2016 14:09:42 +0000 (10:09 -0400)] 
releng: update 4.5 target to build with neon for o.e.remote
Change-Id: Ia01384cf4a417670be77e4470a6cafa37dba4f07
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76122
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Michael Jeanson [Mon, 16 May 2016 19:51:01 +0000 (15:51 -0400)] 
analysis.lami: Add units to timestamp axis title
Units are currently missing in the axis title when the axis is a
timestamp series. This patch adds units based on the axis timestamp
format pattern.
Bug: 493941
Change-Id: I6f03267c5a2704d4b729cc3d666dd30df533053d
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74093
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Alexandre Montplaisir [Tue, 28 Jun 2016 12:48:14 +0000 (08:48 -0400)]
releng: Update to tracecompass-test-traces 1.5.0
Contains updated traces with debug-info information, courtesy
of Simon Marchi.
Change-Id: I5e42d08b097fa5e3727c2a41ba0c928e8132c8fd
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76104
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Tue, 28 Jun 2016 11:19:25 +0000 (07:19 -0400)]
releng: Don't use composite repos in targets
Composite repos often take extremely longer to resolve.
Point to real p2 repos where we can.
Change-Id: Ia5fc195df85de81a33eee3d062b2e9a67fb07ea7
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76096
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Sonia Farrah [Wed, 4 May 2016 21:34:01 +0000 (17:34 -0400)]
tmf: Simplify boolean expression in compareTo()
Change-Id: I7a40de618de0ae6fbc9afbaf21c24ff3cc745f4f
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72104
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Sonia Farrah [Tue, 3 May 2016 21:10:44 +0000 (17:10 -0400)]
ctf: Remove Array loop from update()
Change-Id: I367978db1df697af90b9e4d56159cf0d7cba3fd7
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71958
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Mon, 27 Jun 2016 18:46:25 +0000 (14:46 -0400)]
tmf: Make Trace Compass work with mars (4.5)
Patch https://git.eclipse.org/r/75736 changed the dialog box for
deletion of trace folders to use JFace dialog. The change uses an
API that didn't exist in 4.5. This patch will change it to use the
4.5 APIs.
Change-Id: I71ec510eaedefb790b296264bda6cac857ebc89c
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76037
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Wed, 22 Jun 2016 21:21:29 +0000 (17:21 -0400)]
swtbot: Help stabilize SWTChart tests by waiting for number of series
Some tests do not have any waiting for the chart to be populated
before starting to inspect its content. By waiting until the expected
number of series is reached, it is much more likely that the expected
content will be there.
Change-Id: Id0c4f8ec2fae2507ed37c2e3ef9178f789af8b5e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75782
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Geneviève Bastien [Tue, 17 May 2016 20:22:37 +0000 (16:22 -0400)]
lttng: Add Lttng Execution Graph analysis benchmarks
This benchmarks the build time and memory usage of the kernel execution
graph
analysis on some lttng kernel traces. The graph is used to calculate the
critical path
Change-Id: I7e787f4120f084c1acd5a8fdad835bfdb7e71559
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-on: https://git.eclipse.org/r/72973
Reviewed-by: Hudson CI
Jean-Christian Kouame [Tue, 21 Jun 2016 03:13:30 +0000 (23:13 -0400)] 
analysis: Keep selection when switching traces Kernel Memory Usage View
Change-Id: I45ba60e1476995c07b9bb0df32733ff837943ddc
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75601
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Jean-Christian Kouame [Mon, 13 Jun 2016 17:24:43 +0000 (13:24 -0400)]
analysis: Keep thread selection and follow CPU when switching traces
Keep thread selection and follow CPU when switching traces in CPU Usage
View. The data is saved in a map in the trace context, so if the view
is closed, it will remember the thread selection and the followed CPU
for each trace when reopening.
Change-Id: I8c56d852a133d0615f58cdb3e8e6b965a7c2f73d
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75600
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Wed, 22 Jun 2016 19:50:07 +0000 (15:50 -0400)]
tmf.ui: Add shift-mousewheel to scroll horizontally in xy charts
This makes the behavior of XY charts and timegraphs inlined.
Change-Id: I8296d4f79e34d4f0905bb7cd29fcdc765fe360e0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75768
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Geneviève Bastien [Wed, 18 May 2016 14:58:08 +0000 (10:58 -0400)]
lttng: Add system call analysis usage benchmark
This benchmarks iterating through all the segments and getting the intersecting
elements for different times
Change-Id: I1bef84370bec226625ff052a9a912f51aa33e6b0
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/73054
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Samuel Gagnon [Tue, 10 May 2016 03:18:08 +0000 (23:18 -0400)] 
linux.ui: Algorithm for grouping threads in CFV
This patch adds an algorithm for grouping threads in the
ControlFlowView. It works by looking at the arrows that are
shown in the view for a given time range. Those arrows represent
CPU transitions and the grouping is done based on this information.
Change-Id: I4292ea0ba6057f33d22c00f4dbd3e6f1ce46f4d4
Signed-off-by: Samuel Gagnon <samuel.gagnon92@gmail.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69212
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Wed, 22 Jun 2016 21:39:07 +0000 (17:39 -0400)]
releng: Update targets and API baselines to Neon release
Remote and Launchbar do not have release repositories.
Change-Id: I7ae124d1c7ebc0644a43e268cc366fe3f295ca25
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75784
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Wed, 22 Jun 2016 15:00:00 +0000 (11:00 -0400)]
tmf: Add SWTBot tests for trace actions in Project Explorer
Change-Id: I3c181a0d60c07a259e84cf33d401d9ad97cd82f5
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75014
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 21 Jun 2016 22:12:13 +0000 (18:12 -0400)]
tmf: Add missing @since 2.1 in new methods
Change-Id: Idf79b3b39463a257825414b58c3f37dad48e0253
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/75679
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Wed, 22 Jun 2016 19:26:37 +0000 (15:26 -0400)]
doc: Link to LTTng-Analyses releases, not the git tree
Since 0.5+ are not yet supported, the user guide should guide
the user towards downloading the 0.4.x releases.
Change-Id: I8b63a58c8f2d3ed336aba9ee7cdb6fae3a219ac4
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/75767
Reviewed-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@efficios.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Wed, 22 Jun 2016 14:53:49 +0000 (10:53 -0400)]
tmf: Convert Delete trace dialog to a JFace dialog
It's the same functionality as before when it was a native dialog. But
now it allows us to control it in SWTBot.
Change-Id: I44af835a15bb00d2be6b294c837399caa23c83fb
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75736
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Wed, 4 May 2016 19:45:11 +0000 (15:45 -0400)]
xml: Use equalsIgnoreCase for the 'cpu' field string
Change-Id: Ia410993b506febb5be343c480020d88444a3cf59
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72078
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Mon, 18 Apr 2016 14:56:52 +0000 (10:56 -0400)]
ss: Prepare the history tree backend for more unit tests
The constructor calls a new @VisibleForTesting protected method
to initialize the history tree. This will allow the stub to
provide its own implementation.
Change-Id: I8bfdcb454ed49b9e77648c7d6da67aa35d6b9efa
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70888
Reviewed-by: Hudson CI
Matthew Khouzam [Fri, 10 Jun 2016 21:53:18 +0000 (17:53 -0400)]
tmf.ui: make XY charts drag the canvas when CTRL-leftclicked
This is more inline with the timegraph view.
Change-Id: Iba8bb83a345be99cd40c7b5e1fdbd300998966c4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75103
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Alexandre Montplaisir [Wed, 15 Jun 2016 00:33:53 +0000 (20:33 -0400)]
tmf: Add utility method to search for events matching a Predicate
Add methods in TmfUtils to search for events, forwards or
backwards in the trace, until an event matching the given
Predicate is found.
This will be used to implement a "Go to next/previous event of
current time graph entry" option for time graph views.
Change-Id: I19c78a459f1918cc41b0094f2a16bf0172b34804
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/75325
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bruno Roy [Tue, 14 Jun 2016 14:15:47 +0000 (10:15 -0400)]
control: command support for excluding specific events by name
We can add exclusions to UST tracepoints. Events that match any of the
items of the list are not going to be enabled. Even if they match a
wildcard definition of enabled events.
Change-Id: Id1522633046f3a3251605ea9b6664be17c40bc49
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74105
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Fri, 10 Jun 2016 21:40:08 +0000 (17:40 -0400)]
tmf.ui: make XY charts zoom on CTRL-MOUSEWHEEL
This makes the control much more inline with tracecompass as mousewheel
is typically for moving up-down.
Change-Id: I6de6a809e0b15161e6059939d8aedff65f2a596e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75102
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Wed, 15 Jun 2016 21:39:38 +0000 (17:39 -0400)]
tmf.ui: make Shift-Click extend selection ranges
Change-Id: If2130443830b87d83a3e3e012e1f5b944a323f00
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75359
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bruno Roy [Mon, 16 May 2016 21:01:19 +0000 (17:01 -0400)]
control.test: SWTBot test for enabling specific event type by name
Change-Id: I900b990712423203710f5b73b920d0995f637bad
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73099
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bruno Roy [Mon, 16 May 2016 18:27:52 +0000 (14:27 -0400)]
control: Bug 490322: command support for enabling specific event by name
Change-Id: I14628d04a7546c10f518c84a2b64be4069cd9196
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72838
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Fri, 6 May 2016 03:20:19 +0000 (23:20 -0400)]
Use 4.6 target by default in Oomph setup
Since we build with 4.6 by default, it makes sense that the Oomph
setup uses 4.6 by default as well.
Change-Id: I63177df57c91eb1c08b806f4b8022dc6c53b0b81
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72177
Reviewed-by: Hudson CI
Bernd Hufmann [Mon, 13 Jun 2016 19:29:46 +0000 (15:29 -0400)]
control: fix tree item selection in SWTBot tests
Before the all tree node was not selected. The test still was
successful due to default behaviour
Change-Id: I6356def3db40cdd3414185d6df6d3d2c16415a6c
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75181
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Mon, 13 Jun 2016 20:41:15 +0000 (16:41 -0400)]
Revert "ctf.core: making some classes final"
This reverts commit
266c4d511bd4c26ca6e5063b53715d9c9ecea674.
Change-Id: I21b23499a79084100256591ba59c8af14de06a2e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75196
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Mon, 13 Jun 2016 20:41:02 +0000 (16:41 -0400)]
Revert "ust.core: making some classes final"
This reverts commit
ac52feb8c7e7dbc3caa69207c1df59b841a7012d.
Change-Id: I4bbdb49c9f4cecf10e628a8274c8fd0f6ef1ac56
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75195
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Mon, 13 Jun 2016 20:42:29 +0000 (16:42 -0400)]
Add Trace Compass 2.0.0 baseline
For now, use RC4 update site. Will switch to final release update
site when it's available.
Change-Id: I5bdb53ffd13875912e1aa87a169bbb7a13759f59
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75194
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Matthew Khouzam [Fri, 6 May 2016 20:04:54 +0000 (16:04 -0400)]
tmf.ui: hide title and legend in swtcharts by default
Change-Id: Ic4ac8b6ec66732986651a0483fcf3d51a54edc09
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72302
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Wassim [Fri, 10 Jun 2016 19:56:28 +0000 (15:56 -0400)] 
tmf.core: making fInstance private
Private members encapsulate data well in a class and are not used
anywhere else in the code so they can be easily modified or enhanced
without any side-effects.
Change-Id: Ida21a9a5c576f20ee2a5bee29b80ef02de9eb630
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/75095
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bruno Roy [Tue, 3 May 2016 19:46:37 +0000 (15:46 -0400)]
tmf.ui: Remove overriding methods
Change-Id: I4ff9a10a618f14f5a08ce9d46cc15ca6ce94349a
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71943
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bruno Roy [Tue, 3 May 2016 18:00:12 +0000 (14:00 -0400)]
tmf.ui: Change the == operator with the equals() method
Change-Id: I4633d1aa33c49fc7e1da3bb449cb5a25e85870a4
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71935
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Michael Jeanson [Mon, 16 May 2016 19:50:29 +0000 (15:50 -0400)]
analysis.lami: Split axis titles in label and units
The axis titles are now built using the label and units strings,
which makes it easier to override or remove the units of an axis.
Bug: 493941
Change-Id: Icd63f9678084029c6ccaf2a6c51b607ccc71c0ab
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74092
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Geneviève Bastien [Mon, 13 Jun 2016 19:13:10 +0000 (15:13 -0400)]
tmf: buf 495911 Fix timestamp transform fast for small timestamps
Change-Id: I64f3fc6c113fd240506a6d972430bda94ed05afb
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/75187
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Wassim [Mon, 6 Jun 2016 19:58:59 +0000 (15:58 -0400)]
linux.core: making SyscallNameAspect final
This patch is to make a class final in linux.core component.
It should be final to improve readability and since you should never
extend it. It also allows the jvm to inline methods and improve
performance.
Change-Id: I6df113ac664cb7e11981de84d64460d3c90cacb3
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74715
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Fri, 1 Apr 2016 13:09:34 +0000 (09:09 -0400)]
control: command support for enabling all tracepoints/syscalls
Change-Id: I68f2783bfa9ff7882f8956a06028c0d63d286e98
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72207
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Fri, 1 Apr 2016 13:12:39 +0000 (09:12 -0400)]
control: allow filters for when enabling events on domain level
Change-Id: I1dcebc5c204f7d906ce5dd723a25153280689d96
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72206
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Cédric Biancheri [Mon, 6 Jun 2016 14:02:39 +0000 (10:02 -0400)] 
lttng: add names of traces in sync algorithm stats
Two lines were added to match traces Ids with traces names so it can be
easier to see which pairs were synchronized.
Change-Id: Iec69283080a12668c02d5886b4bbf95e1440ac00
Signed-off-by: Cédric Biancheri <cdc.biancheri@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74674
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Wed, 8 Jun 2016 16:20:11 +0000 (12:20 -0400)]
Update targets with latest launchbar
Change-Id: Ic67b5dcd47c94cb5da04123f9a330d5400f25d6c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74912
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Wed, 8 Jun 2016 13:10:28 +0000 (09:10 -0400)] 
rcp: Update copyright year in branding files
Change-Id: Id72825366f573b71a4247402a015c7baebc3d74d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74891
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Marc-Andre Laperle [Wed, 8 Jun 2016 03:32:44 +0000 (23:32 -0400)]
releng: Update targets for Neon RC4
Also update staging target, I forgot to update it last time.
Change-Id: I1f6846934bd21147a07c6e97e6a715bad816c098
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74847
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Philippe Proulx [Mon, 25 Apr 2016 23:00:55 +0000 (19:00 -0400)] 
doc: Document the external analyses feature
Bug 495211
Change-Id: I323e83b23f3a90591a9d24d0ecd067cb6e34b925
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74813
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 7 Jun 2016 21:35:13 +0000 (17:35 -0400)]
analysis.lami: Correctly reject lttng-analyses > 0.4
Trace Compass does not currently support the LAMI 1.0 protocol,
which means lttng-analyses 0.5 and up should not be available
and should be striked out.
Correctly update the max version number to make it so.
Change-Id: I65a33db732dba7725284840b2bcd0b2ecaab9d3a
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74839
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jean-Christian Kouame [Tue, 7 Jun 2016 14:04:42 +0000 (10:04 -0400)]
doc: Bug 495211. Add flat/hierarchical threads presentation user guide
Change-Id: I11a6c4f9293e0118f032e0da01d2984d8bb65fc1
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74777
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Patrick Tasse [Thu, 2 Jun 2016 21:10:00 +0000 (17:10 -0400)]
tmf: Bug 495219: Fix NPE in checkpoint indexer seeking on disposed trace
In BTree, if it is disposed (file is null), return -1 (insertion point
0) in the binary search. This will correspond to checkpoint 0 in the
flat array.
In FlatArray, if it is disposed (file is null) return null as checkpoint
in get(long).
In TmfCheckpointIndexer, if the returned checkpoint is null in
restoreCheckpoint(long), return the context given by the trace
implementation of seekEvent((ITmfLocation) null). It should properly
handle a disposed trace.
Change-Id: I3148d2e10118628e387d206054de55d5238a9807
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74474
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Mon, 6 Jun 2016 04:07:36 +0000 (00:07 -0400)]
lttng: Make use of "is_pic" event field in debug info analysis
A field with name "is_pic" is now present in LTTng 2.8 final in
"bin_info" events to indicate if the referred binary is PIC
(position-independent code) or not. We can make use of this
field to identify PIC binaries much more reliably than by just
looking at the file name.
Bug: 495551
Change-Id: Ib553f43e8236c399c56387ff8e20a8428c688fb5
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74616
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Wed, 1 Jun 2016 04:16:55 +0000 (00:16 -0400)]
releng: Update targets for Neon RC3
- launchbar doesn't have a RC3, only RC2.
- Make sure SWTChart 0.7.0 is used, the newer version will not be
used for Neon.
Change-Id: I5bb6195bc79651e5f596ade765e37086794a162a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74160
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouame [Mon, 6 Jun 2016 20:32:50 +0000 (16:32 -0400)]
doc: Bug 495211. Update follow CPU in user guide
Add follow CPU to Resources View user guide and CPU filtering to CPU
Usage View user guide.
Change-Id: Ie0572582f9228b7a4784d612e21fcca07dc9ccba
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74718
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Sonia Farrah [Tue, 3 May 2016 21:54:12 +0000 (17:54 -0400)]
ust: Simplify conditional in equals()
Change-Id: I66add0ec275904fdc25df899d440041b7fa78882
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71962
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Patrick Tasse [Mon, 6 Jun 2016 20:59:42 +0000 (16:59 -0400)]
doc: Bug 495211: Update developer guide for ITmfStateSystem API
Change-Id: I20bad86bfbd2bde033e04b8ea215fe0a6d2ac847
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74725
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Mon, 6 Jun 2016 18:10:14 +0000 (14:10 -0400)]
doc: Bug 495211: Update TmfTimestampFormat reference API
Update TmfTimestampFormat.html link to external user guide location.
Update pom.xml to copy the reference directory in deploy-doc profile.
Update external Javadoc links to Java 8.
Change-Id: I6fc2e12ca4c0b8aac8253d0f805ad3c5d76dd8c7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74716
Reviewed-by: Hudson CI
Patrick Tasse [Mon, 6 Jun 2016 21:17:36 +0000 (17:17 -0400)]
doc: Bug 495211: Update developer guide signal reference
Change-Id: I432fb33f118c39f0011708187b85022996bccd6d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74726
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Jean-Christian Kouame [Mon, 6 Jun 2016 18:05:29 +0000 (14:05 -0400)]
doc: Bug 495211. Update Statistics View user guide
Change-Id: Id266dbb9ba577edea8acafbc196cfbc29f37cfb2
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74704
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Alexandre Montplaisir [Mon, 6 Jun 2016 02:47:03 +0000 (22:47 -0400)]
analysis.lami: Use openResource command to run analyses
Bug: 493941
Change-Id: I628c5f7aef0674f4e83dbd9e611ec3616754f758
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74615
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Alexandre Montplaisir [Fri, 3 Jun 2016 22:43:21 +0000 (18:43 -0400)]
analysis.lami: Use the openResource command to open reports
Instead of defining our own command, we can hook into the
Eclipse-provided org.eclipse.ui.navigate.openResource command,
so that the reports can then be opened using the usual
keybindings to open resources.
Also hook it into OpenAction so that Enter and double-click
opens the report.
Bug: 493941
Change-Id: I4c546b60a77c2d531c8c9f18961984e5962ef56f
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74569
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Jean-Christian Kouame [Wed, 1 Jun 2016 14:57:44 +0000 (10:57 -0400)]
analysis: bug 494786. Clear process selection when switching trace
Clear selection in CPU Usage view and Kernel Memory Usage View when
switching trace.
Change-Id: I57618581048995904fa71a9f24d65453eea9ae94
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74261
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouame [Fri, 3 Jun 2016 17:06:30 +0000 (13:06 -0400)]
doc: Bug 495211. Add timing views and viewers developer guide
Change-Id: Icc60e2838c884188fcf314032ff89cde8bbef743
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74544
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jean-Christian Kouame [Thu, 2 Jun 2016 13:56:50 +0000 (09:56 -0400)]
doc: Bug 495211. Update Go to min/max documentation
Change-Id: Ia6817483a4b6c03afcde050026ea218479681ad4
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74380
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Patrick Tasse [Mon, 30 May 2016 21:20:10 +0000 (17:20 -0400)]
tmf: Bug 494952: Remove deadlock in Time Chart view
The handling of signal TmfTraceUpdated is now done in a
ProcessTraceThread. There is only one such thread per trace active at a
time. If an update is requested while a thread is active, the thread is
marked to be restarted after its current iteration completion.
The starting or restarting of a ProcessTraceThread is consolidated in a
method and synchronized.
The ProcessTraceThread now always processes the full time range of the
trace, even when the view is opened with a trace already opened.
A missing synchronization on DecorateThread concurrent access is added.
Method ITimeDataProvider.resetStartFinishTime(boolean) is added to allow
the TimeChartView to reset its window range without notifying listeners.
Change-Id: I0d49d2712af4e5c645bd61bfde46ba37fc42779c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73996
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
This page took 0.052688 seconds and 5 git commands to generate.
projects / deliverable / tracecompass.git / log
