lib: reverse order of bt_self_component_port_input_message_iterator::auto_seek_msgs...
authorSimon Marchi <simon.marchi@efficios.com>
Wed, 26 Jun 2019 13:49:57 +0000 (09:49 -0400)
committerPhilippe Proulx <eeppeliteloop@gmail.com>
Thu, 27 Jun 2019 03:09:07 +0000 (23:09 -0400)
The messages in this queue are in reverse chronological order, meaning
we push the incoming messages to the head and later consume them from
the tail.

It would be more expected (although functionally equivalent) to do the
opposite, so that the messages are in chronological order when iterating
the list in forward.

So this patch just swaps the push/pop calls around.

Change-Id: Id4892e12e064376e919647c0d8bb838156ef0fc5
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1543
CI-Build: Philippe Proulx <eeppeliteloop@gmail.com>
Tested-by: jenkins <jenkins@lttng.org>
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>
src/lib/graph/iterator.c

index a72611f6907622521ec3d95228c8ee39b756e930..b6117e125c05b36110ca7db4921fffefd1d64e6c 100644 (file)
@@ -1141,7 +1141,7 @@ skip_msg:
        goto end;
 
 push_msg:
-       g_queue_push_head(iterator->auto_seek_msgs, (void *) msg);
+       g_queue_push_tail(iterator->auto_seek_msgs, (void *) msg);
        msg = NULL;
 
 end:
@@ -1210,7 +1210,7 @@ enum bt_message_iterator_status find_message_ge_ns_from_origin(
 
                for (i = 0; i < user_count; i++) {
                        if (got_first) {
-                               g_queue_push_head(iterator->auto_seek_msgs,
+                               g_queue_push_tail(iterator->auto_seek_msgs,
                                        (void *) messages[i]);
                                messages[i] = NULL;
                                continue;
@@ -1252,7 +1252,7 @@ enum bt_self_message_iterator_status post_auto_seek_next(
         * iterator's base message array).
         */
        while (capacity > 0 && !g_queue_is_empty(iterator->auto_seek_msgs)) {
-               msgs[*count] = g_queue_pop_tail(iterator->auto_seek_msgs);
+               msgs[*count] = g_queue_pop_head(iterator->auto_seek_msgs);
                capacity--;
                (*count)++;
        }
This page took 0.026637 seconds and 4 git commands to generate.