Cleanup: common/assert.c: remove useless calls

  CID 1401190 (#1 of 1): Useless call (USELESS_CALL)
  side_effect_free: Calling bt_common_color_bold() is only useful for
  its return value, which is ignored.

  side_effect_free: Calling bt_common_color_fg_red() is only useful for
  its return value, which is ignored.

Reported-by: Coverity (1401190) Useless call
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Change-Id: Ia25823f44c24997782ccc209c48d5b28a45a98f4
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1287
Reviewed-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/common/assert.c b/common/assert.c
index ebc987697a8bdbb4c9608953b4b4cf691230bdbc..ce204d0265f40a6263bc8c579e4adb5d26093c4a 100644 (file)
--- a/common/assert.c
+++ b/common/assert.c
@@ -23,10 +23,9 @@
 #include <babeltrace/assert-internal.h>
 #include <babeltrace/common-internal.h>
 
-void bt_common_assert_failed(
-       const char *file, int line, const char *func, const char *assertion) {
-       bt_common_color_bold();
-       bt_common_color_fg_red();
+void bt_common_assert_failed(const char *file, int line, const char *func,
+               const char *assertion)
+{
        fprintf(stderr,
                "%s\n%s%s%s (╯°□°)╯︵ ┻━┻ %s %s%s%s%s:%s%d%s: %s%s()%s: "
                "%sAssertion %s`%s`%s%s failed.%s\n",