Fix: flt.lttng-utils.debug-info: omitting copy_field_class_content() return value

  ID 1401259 (#1 of 2): Logically dead code (DEADCODE)
  dead_error_line: Execution cannot reach this statement: goto error;.

  CID 1401259 (#2 of 2): Logically dead code (DEADCODE)
  dead_error_line: Execution cannot reach this statement: goto error;.

Reported-by: Coverity (various ids) Logically dead code
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Change-Id: I1b3bb7cba9aec34e6a90386178f99cc505d4da66
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1264
Reviewed-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/plugins/lttng-utils/debug-info/trace-ir-metadata-copy.c b/plugins/lttng-utils/debug-info/trace-ir-metadata-copy.c
index bdcc18ca8760ac357bef378d0597d698ecb8da09..af6c87429fbaccb054829509207188b2c97d7807 100644 (file)
--- a/plugins/lttng-utils/debug-info/trace-ir-metadata-copy.c
+++ b/plugins/lttng-utils/debug-info/trace-ir-metadata-copy.c
@@ -412,7 +412,7 @@ int copy_event_class_content(struct trace_ir_maps *ir_maps,
                out_specific_context_fc = create_field_class_copy(md_maps,
                                in_event_specific_context);
 
-               copy_field_class_content(md_maps,
+               ret = copy_field_class_content(md_maps,
                                in_event_specific_context, out_specific_context_fc);
                if (ret) {
                        goto error;
@@ -445,7 +445,7 @@ int copy_event_class_content(struct trace_ir_maps *ir_maps,
        /* Copy the payload of this event class. */
                out_payload_fc = create_field_class_copy(md_maps,
                                in_event_payload);
-               copy_field_class_content(md_maps,
+               ret = copy_field_class_content(md_maps,
                                in_event_payload, out_payload_fc);
                if (ret) {
                        goto error;