tests: fix shellcheck warnings in plugins/sink.ctf.fs/succeed/test_succeed
authorSimon Marchi <simon.marchi@efficios.com>
Tue, 25 Feb 2020 19:33:53 +0000 (14:33 -0500)
committerSimon Marchi <simon.marchi@efficios.com>
Wed, 26 Feb 2020 14:10:00 +0000 (09:10 -0500)
Fix:

    In test_succeed line 44:
    local temp_out_trace_dir="$(mktemp -d)"
  ^----------------^ SC2155: Declare and assign separately to avoid masking return values.

    In test_succeed line 73:
    local temp_gen_trace_dir="$(mktemp -d)"
  ^----------------^ SC2155: Declare and assign separately to avoid masking return values.

Change-Id: I1d7d419d8a11458200d6bf97b1558c8183315dce
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reported-by: shellcheck
Reviewed-on: https://review.lttng.org/c/babeltrace/+/3141
Tested-by: jenkins <jenkins@lttng.org>
tests/plugins/sink.ctf.fs/succeed/test_succeed

index 5c2547d6afaf0e35e703e759d992751d6af2df94..f9c26a27ab8693d7fb50ed10fcae2eab669a066d 100755 (executable)
@@ -41,7 +41,9 @@ succeed_traces="$BT_CTF_TRACES_PATH/succeed"
 test_ctf_single() {
        local name="$1"
        local in_trace_dir="$2"
 test_ctf_single() {
        local name="$1"
        local in_trace_dir="$2"
-       local temp_out_trace_dir="$(mktemp -d)"
+       local temp_out_trace_dir
+
+       temp_out_trace_dir="$(mktemp -d)"
 
        diag "Converting trace '$name' to CTF through 'sink.ctf.fs'"
        "$BT_TESTS_BT2_BIN" >/dev/null "$in_trace_dir" -o ctf -w "$temp_out_trace_dir"
 
        diag "Converting trace '$name' to CTF through 'sink.ctf.fs'"
        "$BT_TESTS_BT2_BIN" >/dev/null "$in_trace_dir" -o ctf -w "$temp_out_trace_dir"
@@ -70,7 +72,9 @@ test_ctf_existing_single() {
 
 test_ctf_gen_single() {
        local name="$1"
 
 test_ctf_gen_single() {
        local name="$1"
-       local temp_gen_trace_dir="$(mktemp -d)"
+       local temp_gen_trace_dir
+
+       temp_gen_trace_dir="$(mktemp -d)"
 
        diag "Generating trace '$name'"
 
 
        diag "Generating trace '$name'"
 
This page took 0.025745 seconds and 4 git commands to generate.