Bump required glib version to 2.28
authorSimon Marchi <simon.marchi@efficios.com>
Wed, 16 Oct 2019 19:27:11 +0000 (15:27 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Thu, 17 Oct 2019 16:13:27 +0000 (12:13 -0400)
While investigating a hang in the lttng-live source component when
running with glib 2.22.5, we have found that this version had a bug in
g_ptr_array_remove_index_fast.  When removing the last element of the
array, the free func is not called.

It was fixed in the following commit:

https://github.com/GNOME/glib/commit/5fffa39b6ae8f8faf1036fbf07de02ffe84ef099

The first major release where this is fixed is 2.26.  We went through
the platforms we need to support, and the oldest glib version we need to
support is 2.28.6, on Solaris 11.  Therefore, fix the issue with
lttng-live by bumping the required glib version to 2.28.

Change-Id: Ib56ac221dfc5ecf45eb62b837fe0b6f54032cf31
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2210
Reviewed-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@efficios.com>
Tested-by: jenkins <jenkins@lttng.org>
README.adoc
configure.ac

index a2ac98dcd09952930d56ff3855a89f03474cca29..e1983b6d262d81035e0a4c4571238ccd8bd0fe31 100644 (file)
@@ -77,7 +77,7 @@ Libraries::
     * A C library (for example,
       https://www.gnu.org/software/libc/[GNU{nbsp}C Library],
       https://www.musl-libc.org/[musl libc])
-    * https://developer.gnome.org/glib/[GLib]{nbsp}≥{nbsp}2.22
+    * https://developer.gnome.org/glib/[GLib]{nbsp}≥{nbsp}2.28
       (Debian/Ubuntu: `libglib2.0-dev`; Fedora: `glib2-devel`)
 
 _**If you need the `bt2` Python bindings**_::
@@ -250,7 +250,7 @@ Libraries::
     * A C library (for example,
       https://www.gnu.org/software/libc/[GNU{nbsp}C Library],
       https://www.musl-libc.org/[musl libc])
-    * https://developer.gnome.org/glib/[GLib]{nbsp}≥{nbsp}2.22
+    * https://developer.gnome.org/glib/[GLib]{nbsp}≥{nbsp}2.28
       (Debian/Ubuntu: `libglib2.0-0`; Fedora: `glib2`)
 
 _**If you need the `bt2` Python bindings**_::
index 878e1ced57a47496addc1235f335a1cf92f3b990..076e2e71141e2e7e6ff00a37d4801bb1b4dd5be9 100644 (file)
@@ -248,9 +248,9 @@ AM_CONDITIONAL([HAVE_FLEX], [test "x$have_flex" = "xyes"])
 # Check what libraries are required on this platform to link sockets programs.
 AX_LIB_SOCKET_NSL
 
-# Check for glib >= 2.22 with gmodule support
-AM_PATH_GLIB_2_0([2.22.0], [],
-  AC_MSG_ERROR([glib >= 2.22 is required - download it from ftp://ftp.gtk.org/pub/gtk]),
+# Check for glib >= 2.28 with gmodule support
+AM_PATH_GLIB_2_0([2.28.0], [],
+  AC_MSG_ERROR([glib >= 2.28 is required - download it from ftp://ftp.gtk.org/pub/gtk]),
   [gmodule-no-export]
 )
 
This page took 0.025591 seconds and 4 git commands to generate.