Fix: lttng-live non NULL-terminated strings
authorMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Sat, 14 Dec 2013 15:44:17 +0000 (10:44 -0500)
committerMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Sat, 14 Dec 2013 16:02:09 +0000 (11:02 -0500)
Found by coverity.

** CID 1136986:  String not null terminated  (STRING_NULL)
/formats/lttng-live/lttng-live-functions.c: 375 in lttng_live_attach_session()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
formats/lttng-live/lttng-live-functions.c

index 9de53ae5fd96734d714a4ca161a8e2176ab2ed42..67c814cf80b8df5b070192d1b8a153e31a7496bf 100644 (file)
@@ -201,6 +201,8 @@ int lttng_live_list_sessions(struct lttng_live_ctx *ctx, const char *path)
                        goto error;
                }
                assert(ret_len == sizeof(lsession));
+               lsession.hostname[LTTNG_VIEWER_HOST_NAME_MAX - 1] = '\0';
+               lsession.session_name[LTTNG_VIEWER_NAME_MAX - 1] = '\0';
 
                fprintf(stdout, "%s/%" PRIu64 " : %s on host %s (timer = %u, "
                                "%u stream(s), %u client(s) connected)\n",
@@ -355,6 +357,8 @@ int lttng_live_attach_session(struct lttng_live_ctx *ctx, uint64_t id)
                        goto error;
                }
                assert(ret_len == sizeof(stream));
+               stream.path_name[LTTNG_VIEWER_PATH_MAX - 1] = '\0';
+               stream.channel_name[LTTNG_VIEWER_NAME_MAX - 1] = '\0';
 
                printf_verbose("    stream %" PRIu64 " : %s/%s\n",
                                be64toh(stream.id), stream.path_name,
This page took 0.025214 seconds and 4 git commands to generate.