bt2: Add `Const` suffix to `_Connection` class and adapt tests

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Change-Id: I9f695ece01ba48a1fc7008b0ff2ac036fc6e0a7f
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2007
Tested-by: jenkins <jenkins@lttng.org>
Reviewed-by: Simon Marchi <simon.marchi@efficios.com>

diff --git a/src/bindings/python/bt2/bt2/connection.py b/src/bindings/python/bt2/bt2/connection.py
index eb0c431627f852f728ef8a2637a74f980d5afb01..cb69ef5af79e5d68d52c7df88e6e3f9a9339ca46 100644 (file)
--- a/src/bindings/python/bt2/bt2/connection.py
+++ b/src/bindings/python/bt2/bt2/connection.py
@@ -25,7 +25,7 @@ from bt2 import port as bt2_port
 from bt2 import object as bt2_object
 
 
-class _Connection(bt2_object._SharedObject):
+class _ConnectionConst(bt2_object._SharedObject):
     _get_ref = staticmethod(native_bt.connection_get_ref)
     _put_ref = staticmethod(native_bt.connection_put_ref)
 

diff --git a/src/bindings/python/bt2/bt2/graph.py b/src/bindings/python/bt2/bt2/graph.py
index 6c9db7ec96a24b4e97d4b44c993fc2c2a6100514..14c3b65b84f56fc2351455230e3e4edc2eddd08d 100644 (file)
--- a/src/bindings/python/bt2/bt2/graph.py
+++ b/src/bindings/python/bt2/bt2/graph.py
@@ -147,7 +147,7 @@ class Graph(object._SharedObject):
         )
         utils._handle_func_status(status, 'cannot connect component ports within graph')
         assert conn_ptr
-        return bt2_connection._Connection._create_from_ptr(conn_ptr)
+        return bt2_connection._ConnectionConst._create_from_ptr(conn_ptr)
 
     def add_port_added_listener(self, listener):
         if not callable(listener):

diff --git a/src/bindings/python/bt2/bt2/port.py b/src/bindings/python/bt2/bt2/port.py
index 963a5b3c603097684b68422af5d86bf56de673ad..d3bc398fa500653b750a658a914b788fa6ed0d90 100644 (file)
--- a/src/bindings/python/bt2/bt2/port.py
+++ b/src/bindings/python/bt2/bt2/port.py
@@ -68,7 +68,7 @@ class _Port(object._SharedObject):
         if conn_ptr is None:
             return
 
-        return bt2_connection._Connection._create_from_ptr_and_get_ref(conn_ptr)
+        return bt2_connection._ConnectionConst._create_from_ptr_and_get_ref(conn_ptr)
 
     @property
     def is_connected(self):
@@ -97,7 +97,7 @@ class _UserComponentPort(_Port):
         if conn_ptr is None:
             return
 
-        return bt2_connection._Connection._create_from_ptr_and_get_ref(conn_ptr)
+        return bt2_connection._ConnectionConst._create_from_ptr_and_get_ref(conn_ptr)
 
     @property
     def user_data(self):

diff --git a/tests/bindings/python/bt2/test_connection.py b/tests/bindings/python/bt2/test_connection.py
index 127fd2e8fd36c7e08239e88f107ea006ce9f9081..edeefd08df4635289c838ec524f52b9b7476e0c4 100644 (file)
--- a/tests/bindings/python/bt2/test_connection.py
+++ b/tests/bindings/python/bt2/test_connection.py
@@ -18,6 +18,7 @@
 
 import unittest
 import bt2
+from bt2 import connection as bt2_connection
 
 
 class ConnectionTestCase(unittest.TestCase):
@@ -40,7 +41,8 @@ class ConnectionTestCase(unittest.TestCase):
         graph = bt2.Graph()
         src = graph.add_component(MySource, 'src')
         sink = graph.add_component(MySink, 'sink')
-        graph.connect_ports(src.output_ports['out'], sink.input_ports['in'])
+        conn = graph.connect_ports(src.output_ports['out'], sink.input_ports['in'])
+        self.assertIs(type(conn), bt2_connection._ConnectionConst)
 
     def test_downstream_port(self):
         class MyIter(bt2._UserMessageIterator):
@@ -63,6 +65,7 @@ class ConnectionTestCase(unittest.TestCase):
         sink = graph.add_component(MySink, 'sink')
         conn = graph.connect_ports(src.output_ports['out'], sink.input_ports['in'])
         self.assertEqual(conn.downstream_port.addr, sink.input_ports['in'].addr)
+        self.assertIs(type(conn), bt2_connection._ConnectionConst)
 
     def test_upstream_port(self):
         class MyIter(bt2._UserMessageIterator):