shellcheck complains:
In test_auto_source_discovery_params line 42:
print_test_params="--params what=\"test-params\""
^---------------------------^ SC2089: Quotes/backslashes will be treated literally. Use an array.
In test_auto_source_discovery_params line 68:
"${dir_ab}" --params 'test-allo="madame"' ${print_test_params} \
^------------------^ SC2090: Quotes/backslashes in this variable will not be respected.
^------------------^ SC2086: Double quote to prevent globbing and word splitting.
Did you mean:
"${dir_ab}" --params 'test-allo="madame"' "${print_test_params}" \
It would be cleaner to make it print_test_params an array, like we do
for details_sink.
Consistently double-quotes references to print_test_params and
details_sink to avoid the "word splitting" warnings.
Change-Id: I6b18effc29f3c453949b4c181e528e2a60cea4e4
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reported-by: shellcheck
Reviewed-on: https://review.lttng.org/c/babeltrace/+/3145
Tested-by: jenkins <jenkins@lttng.org>
expected_file=$(mktemp -t expected.XXXXXX)
expected_file=$(mktemp -t expected.XXXXXX)
-print_log_level="--params what=\"log-level\""
+print_log_level=(--params 'what="log-level"')
details_sink=("-c" "sink.text.details" "--params=with-metadata=false")
debug=2
details_sink=("-c" "sink.text.details" "--params=with-metadata=false")
debug=2
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
- "${dir_ab}" --log-level DEBUG ${print_log_level} \
- ${details_sink[@]}
+ "${dir_ab}" --log-level DEBUG "${print_log_level[@]}" \
+ "${details_sink[@]}"
ok "$?" "apply log level to two components from one non-option argument"
# Apply log level to two components from two distinct non-option arguments.
ok "$?" "apply log level to two components from one non-option argument"
# Apply log level to two components from two distinct non-option arguments.
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
- "${dir_a}" --log-level DEBUG ${print_log_level} "${dir_b}" --log-level TRACE ${print_log_level} \
- ${details_sink[@]}
+ "${dir_a}" --log-level DEBUG "${print_log_level[@]}" "${dir_b}" --log-level TRACE "${print_log_level[@]}" \
+ "${details_sink[@]}"
ok "$?" "apply log level to two non-option arguments"
# Apply log level to one component coming from one non-option argument and one component coming from two non-option arguments (1).
ok "$?" "apply log level to two non-option arguments"
# Apply log level to one component coming from one non-option argument and one component coming from two non-option arguments (1).
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
- "${dir_a}" --log-level DEBUG ${print_log_level} "${dir_ab}" --log-level TRACE ${print_log_level} \
- ${details_sink[@]}
+ "${dir_a}" --log-level DEBUG "${print_log_level[@]}" "${dir_ab}" --log-level TRACE "${print_log_level[@]}" \
+ "${details_sink[@]}"
ok "$?" "apply log level to one component coming from one non-option argument and one component coming from two non-option arguments (1)"
# Apply log level to one component coming from one non-option argument and one component coming from two non-option arguments (2).
ok "$?" "apply log level to one component coming from one non-option argument and one component coming from two non-option arguments (1)"
# Apply log level to one component coming from one non-option argument and one component coming from two non-option arguments (2).
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
- "${dir_ab}" --log-level DEBUG ${print_log_level} "${dir_a}" --log-level TRACE ${print_log_level} \
- ${details_sink[@]}
+ "${dir_ab}" --log-level DEBUG "${print_log_level[@]}" "${dir_a}" --log-level TRACE "${print_log_level[@]}" \
+ "${details_sink[@]}"
ok "$?" "apply log level to one component coming from one non-option argument and one component coming from two non-option arguments (2)"
rm -f "$expected_file"
ok "$?" "apply log level to one component coming from one non-option argument and one component coming from two non-option arguments (2)"
rm -f "$expected_file"
expected_file=$(mktemp -t expected.XXXXXX)
expected_file=$(mktemp -t expected.XXXXXX)
-print_test_params="--params what=\"test-params\""
+print_test_params=("--params" 'what="test-params"')
details_sink=("-c" "sink.text.details" "--params=with-metadata=false")
# Apply params to two components from one non-option argument.
details_sink=("-c" "sink.text.details" "--params=with-metadata=false")
# Apply params to two components from one non-option argument.
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
- "${dir_ab}" --params 'test-allo="madame"' ${print_test_params} \
- ${details_sink[@]}
+ "${dir_ab}" --params 'test-allo="madame"' "${print_test_params[@]}" \
+ "${details_sink[@]}"
ok "$?" "apply params to two components from one non-option argument"
# Apply params to two components from two distinct non-option arguments.
ok "$?" "apply params to two components from one non-option argument"
# Apply params to two components from two distinct non-option arguments.
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
- "${dir_a}" --params 'test-allo="madame"' ${print_test_params} "${dir_b}" --params 'test-bonjour="monsieur"' ${print_test_params} \
- ${details_sink[@]}
+ "${dir_a}" --params 'test-allo="madame"' "${print_test_params[@]}" "${dir_b}" --params 'test-bonjour="monsieur"' "${print_test_params[@]}" \
+ "${details_sink[@]}"
ok "$?" "apply params to two non-option arguments"
# Apply params to one component coming from one non-option argument and one component coming from two non-option arguments (1).
ok "$?" "apply params to two non-option arguments"
# Apply params to one component coming from one non-option argument and one component coming from two non-option arguments (1).
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
- "${dir_a}" --params 'test-allo="madame"' ${print_test_params} "${dir_ab}" --params 'test-bonjour="monsieur"' ${print_test_params} \
- ${details_sink[@]}
+ "${dir_a}" --params 'test-allo="madame"' "${print_test_params[@]}" "${dir_ab}" --params 'test-bonjour="monsieur"' "${print_test_params[@]}" \
+ "${details_sink[@]}"
ok "$?" "apply params to one component coming from one non-option argument and one component coming from two non-option arguments (1)"
# Apply params to one component coming from one non-option argument and one component coming from two non-option arguments (2).
ok "$?" "apply params to one component coming from one non-option argument and one component coming from two non-option arguments (1)"
# Apply params to one component coming from one non-option argument and one component coming from two non-option arguments (2).
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
bt_diff_cli "$expected_file" "/dev/null" \
--plugin-path "${plugin_dir}" convert \
- "${dir_ab}" --params 'test-bonjour="madame",test-salut="les amis"' ${print_test_params} "${dir_a}" --params 'test-bonjour="monsieur"' ${print_test_params} \
- ${details_sink[@]}
+ "${dir_ab}" --params 'test-bonjour="madame",test-salut="les amis"' "${print_test_params[@]}" "${dir_a}" --params 'test-bonjour="monsieur"' "${print_test_params[@]}" \
+ "${details_sink[@]}"
ok "$?" "apply params to one component coming from one non-option argument and one component coming from two non-option arguments (2)"
rm -f "$expected_file"
ok "$?" "apply params to one component coming from one non-option argument and one component coming from two non-option arguments (2)"
rm -f "$expected_file"