Fix: bt2: use unsigned iteration variable
authorSimon Marchi <simon.marchi@efficios.com>
Wed, 7 Aug 2019 03:48:44 +0000 (23:48 -0400)
committerPhilippe Proulx <eeppeliteloop@gmail.com>
Wed, 7 Aug 2019 14:31:23 +0000 (10:31 -0400)
This fixes the following compiler diagnostic (gcc 9.1.0):

    bt2/native_bt.c: In function ‘_wrap_field_class_enumeration_unsigned_get_mapping_labels_for_value’:
    bt2/native_bt.c:9387:25: error: comparison of integer expressions of different signedness: ‘int’ and ‘uint64_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
     9387 |       for (int i = 0; i < *arg4; i++) {
          |                         ^

Change-Id: I543c61d64c0cf7b42cb242bdbb7b71cbf67dbe48
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1834
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>
Tested-by: jenkins <jenkins@lttng.org>
src/bindings/python/bt2/bt2/native_bt_field_class.i

index 674d6938d84373a5db2c0579418c81ab4f4a3741..5a84b8695df27f81340ecb50c16dd75529de8d60 100644 (file)
@@ -34,7 +34,9 @@
        (bt_field_class_enumeration_mapping_label_array *label_array, uint64_t *count) {
        if (*$1) {
                PyObject *py_label_list = PyList_New(*$2);
-               for (int i = 0; i < *$2; i++) {
+               uint64_t i;
+
+               for (i = 0; i < *$2; i++) {
                        PyList_SET_ITEM(py_label_list, i, PyUnicode_FromString((*$1)[i]));
                }
 
This page took 0.024865 seconds and 4 git commands to generate.