Fix: flt.lttng-utils.debug-info: extra colon in `bin` member

There is an extra ':' character in the `bin` member of the `debug-info`
field.

Example of the issue from the tests:
   debug_info = { bin = "libhello_so:+0x15a6", func = "bar+0xa9", src =
   "libhello.c:13" }

The "libhello_so:+0x15a6" will now be printed "libhello_so+0x15a6".

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Change-Id: Ie7c4ea54e534eeb8a1bdd503760b791a01aa9594
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1129
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>

diff --git a/plugins/lttng-utils/debug-info/debug-info.c b/plugins/lttng-utils/debug-info/debug-info.c
index 0146fa27efae3e43ad25da8f00b31da385786029..1bdd01e565038dd5a807c6aed7eae9ef01618843 100644 (file)
--- a/plugins/lttng-utils/debug-info/debug-info.c
+++ b/plugins/lttng-utils/debug-info/debug-info.c
@@ -948,13 +948,6 @@ void fill_debug_info_bin_field(struct debug_info_source *dbg_info_src,
                                curr_field);
                }
 
-               status = bt_field_string_append(curr_field, ":");
-               if (status != BT_FIELD_STATUS_OK) {
-                       BT_LOGE("Cannot set colon component of \"bin\" "
-                               "curr_field field's value: str-fc-addr=%p",
-                               curr_field);
-               }
-
                status = bt_field_string_append(curr_field, dbg_info_src->bin_loc);
                if (status != BT_FIELD_STATUS_OK) {
                        BT_LOGE("Cannot set bin location component of \"bin\" "