Manage objfiles with shared_ptr
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
7d7167ce
TT
12019-12-12 Tom Tromey <tom@tromey.com>
2
3 * progspace.h (objfile_list): New typedef.
4 (class unwrapping_objfile_iterator)
5 (struct unwrapping_objfile_range): Newl
6 (struct program_space) <objfiles_range>: Change type.
7 <objfiles>: Change return type.
8 <add_objfile>: Change type of "objfile" parameter.
9 <objfiles_list>: Now a list of shared_ptr.
10 * progspace.c (program_space::add_objfile): Change type of
11 "objfile". Update.
12 (program_space::remove_objfile): Update.
13 * objfiles.h (struct objfile) <~objfile>: Make public.
14 * objfiles.c (objfile::make): Update.
15 (objfile::unlink): Don't call delete.
16
343cc952
TT
172019-12-12 Tom Tromey <tom@tromey.com>
18
19 * symfile.c (symbol_file_clear): Update.
20 * progspace.h (struct program_space) <free_all_objfiles>: Declare
21 method.
22 * progspace.c (program_space::free_all_objfiles): New method.
23 * objfiles.h (free_all_objfiles): Don't declare.
24 * objfiles.c (free_all_objfiles): Move to program_space.
25
d0801dd8
TT
262019-12-12 Tom Tromey <tom@tromey.com>
27
28 * progspace.c (program_space::add_objfile)
29 (program_space::remove_objfile): Update.
30 (program_space::multi_objfile_p): Remove.
31 * objfiles.h (struct objfile) <next>: Remove.
32 * objfiles.c (objfile::objfile): Update.
33 (put_objfile_before): Update.
34 (unlink_objfile): Update.
35 * progspace.h (object_files): Remove.
36 (struct program_space) <objfiles_head>: Remove.
37 <objfiles_list>: New member.
38 <objfiles_range, objfiles_safe_range>: Change type.
39 (objfiles): Change return type.
40 (objfiles_safe): Update.
41 (multi_objfile_p): Rewrite and inline.
42 (object_files): Remove macro.
43
13bff726
TT
442019-12-12 Tom Tromey <tom@tromey.com>
45
46 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
47 second constructor.
48 (basic_safe_range): New class.
49
deeafabb
TT
502019-12-12 Tom Tromey <tom@tromey.com>
51
52 * progspace.c (program_space::multi_objfile_p): New method.
53 * printcmd.c (info_symbol_command): Update.
54 * maint.c (maintenance_translate_address): Update.
55 * objfiles.h (MULTI_OBJFILE_P): Remove.
56 * progspace.h (struct program_space) <multi_objfile_p>: New
57 method.
58
23452926
TT
592019-12-12 Tom Tromey <tom@tromey.com>
60
61 * progspace.h (struct program_space) <remove_objfile>: Declare.
62 * progspace.c (program_space::remove_objfile): New method.
63 * objfiles.c (unlink_objfile): Remove.
64 (objfile::unlink): Call remove_objfile.
65 (objfile): Don't call unlink_objfile.
66
7cac64af
TT
672019-12-12 Tom Tromey <tom@tromey.com>
68
69 * progspace.h (struct program_space) <add_objfile>: Declare
70 method.
71 * progspace.c (program_space::add_objfile): New method.
72 * objfiles.c (~objfile): Don't unlink objfile.
73 (put_objfile_before): Remove.
74 (add_separate_debug_objfile): Don't call put_objfile_before.
75 (objfile::make): Call add_objfile. Set new_objfiles_available on
76 the per-program-space data.
77
268e4f09
TT
782019-12-12 Tom Tromey <tom@tromey.com>
79
80 * symfile.c (syms_from_objfile_1): Use objfile_up.
81 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
82 method.
83 (reread_symbols): Use objfile_up.
84 * solib.c (update_solib_list, reload_shared_libraries_1): Call
85 unlink method.
86 * objfiles.h (struct objfile) <~objfile>: Now private.
87 <unlink>: New method.
88 (struct objfile_deleter): New.
89 (objfile_up): New typedef.
90 * objfiles.c (objfile::unlink): New method.
91 (free_objfile_separate_debug, free_all_objfiles)
92 (objfile_purge_solibs): Use it.
93 * jit.c (jit_unregister_code): Remove.
94 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
95 objfile.
96 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
97 objfile.
98 * compile/compile-object-load.c (compile_object_load): Use
99 objfile_up.
100
f65fe570
TT
1012019-12-12 Tom Tromey <tom@tromey.com>
102
103 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
104 objfile::make.
105 * objfiles.h (struct objjfile) <make>: No longer inline.
106 (add_separate_debug_objfile): Don't declare.
107 * objfiles.c (add_separate_debug_objfile): Now static.
108 (objfile::make): Move from objfiles.h. Call
109 add_separate_debug_objfile. Add "parent" parameter.
110
bda13cdc
TT
1112019-12-12 Tom Tromey <tom@tromey.com>
112
113 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
114 * objfiles.h (struct objfile): Make constructor private.
115 <make>: New static method.
116 * jit.c (jit_object_close_impl): Update.
117
7190276c
SM
1182019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
119
120 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
121 gdb::byte_vector.
122
d61df897
TT
1232019-12-12 Tom Tromey <tromey@adacore.com>
124
125 * xml-support.c (xml_fetch_content_from_file): Don't call
126 malloc_failure.
127 * utils.h (class gdb_argv): Remove malloc_failure comment.
128 * utils.c (gdb_argv::reset): Don't call malloc_failure.
129
db3ad2f0
TT
1302019-12-12 Tom Tromey <tromey@adacore.com>
131
132 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
133 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
134 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
135 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
136 * riscv-ravenscar-thread.c: New file.
137 * riscv-ravenscar-thread.h: New file.
138 * riscv-tdep.c (riscv_gdbarch_init): Call
139 register_riscv_ravenscar_ops.
140
2ffe5b9c
TT
1412019-12-12 Tom Tromey <tromey@adacore.com>
142
143 * gdbsupport/thread-pool.c (set_thread_name): Use
144 ATTRIBUTE_UNUSED.
145
39f34d7b
LM
1462019-12-12 Luis Machado <luis.machado@linaro.org>
147
148 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
149 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
150 macros.
151
d4eeccfe
TT
1522019-12-11 Tom Tromey <tom@tromey.com>
153
154 * tui/tui-win.c (tui_set_win_height_command): Call
155 tui_adjust_window_height.
156 (tui_adjust_win_heights, new_height_ok): Remove.
157 * tui/tui-layout.h (tui_adjust_window_height): Declare.
158 * tui/tui-layout.c (tui_adjust_window_height): New function.
159
3d979945
TT
1602019-12-11 Tom Tromey <tom@tromey.com>
161
162 * tui/tui-win.c (tui_resize_all): Remove code, call
163 tui_apply_current_layout.
164
2192a9d3
TT
1652019-12-11 Tom Tromey <tom@tromey.com>
166
167 * tui/tui-layout.h (tui_apply_current_layout): Declare.
168 * tui/tui-layout.c (standard_layouts, applied_layout): New
169 globals.
170 (tui_apply_current_layout): New function.
171 (show_layout): Set applied_layout. Call
172 tui_apply_current_layout.
173 (show_source_command, show_disasm_command)
174 (show_source_disasm_command, show_data)
175 (show_source_or_disasm_and_command): Remove.
176 (initialize_layouts): New function.
177 (_initialize_tui_layout): Call initialize_layouts.
178
389e7ddb
TT
1792019-12-11 Tom Tromey <tom@tromey.com>
180
181 * tui/tui-layout.h (class tui_layout_base)
182 (class tui_layout_window, class tui_layout_split): New.
183 * tui/tui-layout.c (tui_get_window_by_name)
184 (tui_layout_window::clone, tui_layout_window::apply)
185 (tui_layout_window::get_sizes, tui_layout_window::add_split)
186 (tui_layout_split::add_window, tui_layout_split::clone)
187 (tui_layout_split::get_sizes)
188 (tui_layout_split::set_weights_from_heights)
189 (tui_layout_split::adjust_size, tui_layout_split::apply): New
190 functions.
191 (tui_layout_split::add_split, tui_layout_split::add_split)
192 (tui_layout_split::set_weights_from_heights)
193 (tui_layout_split::set_weights_from_heights): New functions.
194
fb3184d8
TT
1952019-12-11 Tom Tromey <tom@tromey.com>
196
197 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
198 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
199 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
200 * tui/tui-data.h (struct tui_point): Remove.
201 (struct tui_gen_win_info) <origin>: Remove.
202 <x, y>: New fields.
203 * tui/tui-command.c (tui_cmd_window::resize): Update.
204
dc7ff8a6
TT
2052019-12-11 Tom Tromey <tom@tromey.com>
206
207 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
208 Implement.
209 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
210 Implement.
211 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
212 method.
213 (struct tui_win_info) <min_height>: Implement.
214
1431937b
TT
2152019-12-11 Tom Tromey <tom@tromey.com>
216
217 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
218 (struct tui_win_info) <can_box>: Update.
219
c8ec2f43
TT
2202019-12-11 Tom Tromey <tom@tromey.com>
221
222 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
223 method.
224 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
225 method.
226 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
227 method.
228 (struct tui_win_info) <max_height>: Now override.
229
4decd62b
JB
2302019-12-11 Joel Brobecker <brobecker@adacore.com>
231
232 * NEWS: Create a new section for the next release branch.
233 Rename the section of the current branch, now that it has
234 been cut.
235
d746744e
JB
2362019-12-11 Joel Brobecker <brobecker@adacore.com>
237
238 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
239 * version.in: Bump version to 10.0.50.DATE-git.
240
2e744276
TT
2412019-12-11 Tom Tromey <tromey@adacore.com>
242
243 PR build/25268:
244 * gdbsupport/thread-pool.c (set_thread_name): New function.
245 (thread_pool::set_thread_count): Don't call pthread_setname_np.
246 (thread_pool::thread_function): Call set_thread_name.
247
aac4760f
TT
2482019-12-11 Tom Tromey <tromey@adacore.com>
249
250 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
251 bfd_get_signed_8.
252
d8edc8b7
PW
2532019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
254
255 * NEWS: Document -raw-values option and the related setting commands.
256 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
257 only set it on when /r is given.
258 * valprint.c (value_print_option_defs): New element raw-values.
259 * Makefile.in: Add the new file.
260
cb511130
CB
2612019-12-10 Christian Biesinger <cbiesinger@google.com>
262
263 * gdbsupport/safe-strerror.c: Supress the unused function warning
264 for select_strerror_r.
265
ab7d13f0
CB
2662019-12-10 Christian Biesinger <cbiesinger@google.com>
267
268 * config.in: Regenerate.
269 * configure: Regenerate.
270 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
271 safe_strerror instead of strerror.
272 * gdbsupport/common.m4: Don't check for strerror.
273 * gdbsupport/safe-strerror.c: Support both the glibc version
274 of strerror_r and the XSI version.
275
6c71eb7d
TT
2762019-12-10 Tom Tromey <tromey@adacore.com>
277
278 * ada-typeprint.c (print_choices): Use a single "?".
279 (print_variant_part): Print "?" if the discriminant name
280 is not known.
281
bac7c5cf
GB
2822019-12-10 George Barrett <bob@bob131.so>
283
284 Fix scripted probe breakpoints.
285 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
286 declaration forward.
287 (breakpoint_ops_for_event_location_type)
288 (breakpoint_ops_for_event_location): Add function definitions.
289 (break_command_1, trace_command): Use
290 breakpoint_ops_for_event_location.
291 * breakpoint.h (breakpoint_ops_for_event_location): Add function
292 declarations.
293 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
294 breakpoint_ops_for_event_location.
295 * python/py-breakpoint.c (bppy_init): Use
296 breakpoint_ops_for_event_location.
297
330f1d38
TBA
2982019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
299
300 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
301 when ranking an lvalue argument for an rvalue parameter.
302
b1f0c0b9
WA
3032019-12-08 Wataru Ashihara <wataash@wataash.com>
304
305 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
306 template argument for scoped_restore_tmpl from bool to int.
307
aa2d5a42
KS
3082019-12-07 Keith Seitz <keiths@redhat.com>
309
310 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
311 (build_id_to_debug_bfd): Make static, rewriting to use
312 build_id_to_bfd_suffix.
313 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
314 adding `suffix' parameter. Append SUFFIX to file names
315 when searching for matching files.
316 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
317 (build_id_to_exec_bfd): Likewise.
318 * build-id.h (build_id_to_debug_bfd): Clarify that function
319 searches for BFD of debug info file.
320 (build_id_to_exec_bfd): Declare.
321 * corelow.c: Include build-id.h.
322 (locate_exec_from_corefile_build_id): New function.
323 (core_target_open): If no executable BFD is found,
324 search for a core file BFD using build-id.
325
dfb65191
CB
3262019-12-06 Christian Biesinger <cbiesinger@google.com>
327
328 * bcache.c: Put in namespace gdb.
329 * bcache.h: Likewise.
330 * gdbtypes.c (check_types_worklist): Update.
331 (types_deeply_equal): Update.
332 * macrotab.c (struct macro_table) <bcache>: Update.
333 (new_macro_table): Update.
334 * macrotab.h (struct bcache): Put this forward declaration
335 inside namespace gdb.
336 (new_macro_table): Update.
337 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
338 Update.
339 <macro_cache>: Update.
340 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
341
93e55f0a
TV
3422019-12-06 Tom de Vries <tdevries@suse.de>
343
344 PR symtab/24971
345 * block.c (best_symbol, better_symbol): New function.
346 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
347 decl.
348
06acc08f
TBA
3492019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
350
351 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
352 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
353 for ranking see-through reference cases.
354
e0fad1ea
PW
3552019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
356 * stack.c (faas_command): Check a command is provided.
357 * thread.c (taas_command, tfaas_command): Likewise.
358
908641f5
PW
3592019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
360 * inferior.c (prune_inferiors): Only call delete_inferior,
361 Do not modify the inferior list.
362
b858499d
SM
3632019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
364
365 * c-exp.y: Update calls to lookup_typename,
366 lookup_signed_typename and lookup_unsigned_typename.
367 * c-lang.c (evaluate_subexp_c): Likewise.
368 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
369 Likewise.
370 * eval.c (binop_promote): Likewise.
371 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
372 (lookup_unsigned_typename): Likewise.
373 (lookup_signed_typename): Likewise.
374 * gdbtypes.h (lookup_unsigned_typename): Likewise.
375 (lookup_signed_typename): Likewise.
376 (lookup_typename): Likewise.
377 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
378 lookup_typename, lookup_signed_typename,
379 lookup_unsigned_typename.
380 * m2-exp.y: Likewise.
381 * printcmd.c (printf_wide_c_string): Likewise.
382 (ui_printf): Likewise.
383 * python/py-type.c (typy_lookup_typename): Likewise.
384 * python/py-xmethods.c (python_xmethod_worker::invoke):
385 Likewise.
386 * rust-exp.y: Likewise.
387
3a8fa228
CB
3882019-12-04 Christian Biesinger <cbiesinger@google.com>
389
390 * configure.nat (obsd64): Add missing files x86-nat.o and
391 nat/x86-dregs.o.
392
2dbc041e
TT
3932019-12-04 Tom Tromey <tom@tromey.com>
394
395 * valprint.c (val_print_string): Use metadata_style.
396 * go-valprint.c (print_go_string): Use metadata style.
397 * p-valprint.c (pascal_object_print_static_field): Use metadata
398 style.
399 * cp-valprint.c (cp_print_static_field): Use metadata style.
400
36c8fb93
AB
4012019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
402 Chris January <chris.january@arm.com>
403
404 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
405 tokens.
406 (typebase): New patterns for complex, single/double precision, and
407 single/double complex.
408 (f77_keywords): Change token for complex keyword, and add single,
409 double, and precision keywords.
410
c6170c2c
SM
4112019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
412
413 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
414 "info io_registers".
415
894ecaf4
SM
4162019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
417
418 * regcache.c (cooked_read_test): Initialize thread list of
419 mock_inferior.
420
be155ebb
SM
4212019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
422
423 * aarch64-linux-tdep.c: Remove includes.
424
c577cdd7
SM
4252019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
426
427 * aarch64-tdep.c: Remove includes.
428
610cfd61
SM
4292019-12-04 Simon Marchi <simon.marchi@efficios.com>
430
431 * filtered-iterator.h (filtered_iterator) <operator==,
432 operator!=>: Compare wrapped iterators, not wrapped pointers.
433 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
434 unittests/filtered_iterator-selftests.c.
435 * unittests/filtered_iterator-selftests.c: New file.
436
a05cf17a
TT
4372019-12-04 Tom Tromey <tromey@adacore.com>
438
439 * gdbtypes.c (create_range_type): Inherit endianity
440 from base type.
441
d5a22e77
TT
4422019-12-04 Tom Tromey <tromey@adacore.com>
443
444 * ada-lang.c (decode_constrained_packed_array)
445 (ada_value_assign, value_assign_to_component): Update.
446 * dwarf2loc.c (rw_pieced_value, access_memory)
447 (dwarf2_compile_expr_to_ax): Update.
448 * dwarf2read.c (dwarf2_add_field): Update.
449 * eval.c (evaluate_subexp_standard): Update.
450 * gdbarch.c, gdbarch.h: Rebuild.
451 * gdbarch.sh (bits_big_endian): Remove.
452 * gdbtypes.h (union field_location): Update comment.
453 * target-descriptions.c (make_gdb_type): Update.
454 * valarith.c (value_bit_index): Update.
455 * value.c (struct value) <bitpos>: Update comment.
456 (unpack_bits_as_long, modify_field): Update.
457 * value.h (value_bitpos): Update comment.
458
7ab4a236
TT
4592019-12-04 Tom Tromey <tromey@adacore.com>
460
461 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
462 endian-ness.
463
103a685e
TT
4642019-12-04 Tom Tromey <tromey@adacore.com>
465
466 * dwarf2read.c (dwarf2_init_float_type)
467 (dwarf2_init_complex_target_type): Add byte_order parameter.
468 (read_base_type): Compute byte order earlier.
469 * gdbtypes.c (init_float_type): Add byte_order parameter.
470 * gdbtypes.h (init_float_type): Add byte_order parameter.
471
7a9e9f9f
TT
4722019-12-04 Tom Tromey <tromey@adacore.com>
473
474 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
475
feee869b
TT
4762019-12-04 Tom Tromey <tromey@adacore.com>
477
478 * dwarf2read.c (process_structure_scope): Initialize
479 "discr_offset".
480
c2512106
AB
4812019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
482
483 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
484 add it into the search spec.
485 (parse_max_results_option): New function.
486 (mi_info_functions_or_variables): Parse -max-results flag and pass
487 it to mi_symbol_info.
488 (mi_cmd_symbol_info_modules): Likewise.
489 (mi_cmd_symbol_info_types): Likewise.
490 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
491 return type to bool, change result container into a set, and don't
492 add new results if we have enough already.
493 (global_symbol_searcher::add_matching_msymbols): Change return
494 type to bool, and don't add new results if we have enough already.
495 (sort_search_symbols_remove_dups): Delete.
496 (global_symbol_searcher::search): Early exit from search loop when
497 we have enough results. Use a std::set to collect the results
498 from calling add_matching_symbols.
499 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
500 member function.
501 (global_symbol_searcher) <m_max_search_results>: New member
502 variable.
503 (global_symbol_searcher) <add_matching_symbols>: Update header
504 comment and change return type to bool.
505 (global_symbol_searcher) <add_matching_msymbols>: Update header
506 comment and change return type to bool.
507
f97a63c5
AB
5082019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
509
510 * symtab.c (symbol_search::compare_search_syms): Update header
511 comment.
512 (global_symbol_searcher::is_suitable_msymbol): New function.
513 (global_symbol_searcher::expand_symtabs): New function.
514 (global_symbol_searcher::add_matching_symbols): New function.
515 (global_symbol_searcher::add_matching_msymbols): New function.
516 (global_symbol_searcher::search): Move most of the content
517 into the new functions above, and call them as needed.
518 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
519 function.
520 (global_symbol_searcher) <add_matching_symbols>: New member
521 function.
522 (global_symbol_searcher) <add_matching_msymbols>: New member
523 function.
524 (global_symbol_searcher) <is_suitable_msymbol>: New member
525 function.
526
293b38d6
AB
5272019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
528
529 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
530 -symbol-info-module-variables entries.
531 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
532 (mi_cmd_symbol_info_module_variables): Declare.
533 * mi/mi-symbol-cmds.c
534 (module_symbol_search_iterator): New typedef.
535 (output_module_symbols_in_single_module_and_file): New function.
536 (output_module_symbols_in_single_module): New function.
537 (mi_info_module_functions_or_variables): New function.
538 (mi_cmd_symbol_info_module_functions): New function.
539 (mi_cmd_symbol_info_module_variables): New function.
540 * NEWS: Mention new MI command.
541
4cbd39b2
CB
5422019-12-03 Christian Biesinger <cbiesinger@google.com>
543
544 * bcache.c (hash): Remove.
545 (hash_continue): Remove.
546 * bcache.h (hash): Remove.
547 (hash_continue): Remove.
548 (struct bcache) <ctor>: Update.
549 * psymtab.c (psymbol_hash): Update.
550 * stabsread.c (hashname): Update.
551 * utils.h (fast_hash): Add an argument for a start value,
552 defaulting to zero.
553
82f910ea
PW
5542019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
555 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
556 (destroy_block_symbol_cache): New function.
557 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
558 (resize_symbol_cache): Likewise.
559
de2396d0
TT
5602019-12-02 Tom Tromey <tom@tromey.com>
561
562 * unittests/tui-selftests.c (run_tests): Make conditional.
563 (_initialize_tui_selftest): Make conditional.
564
638d85bc
CB
5652019-12-02 Christian Biesinger <cbiesinger@google.com>
566
567 * aix-thread.c (debug_aix_thread): Change type to bool.
568
7532a164
LM
5692019-12-02 Luis Machado <luis.machado@linaro.org>
570
571 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
572
216a7e6b
AB
5732019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
574
575 * dwarf2read.c (read_tag_string_type): Read the fields required to
576 make a dynamic string, and possibly create a dynamic range for the
577 string.
578 (attr_to_dynamic_prop): Setup is_reference based on the type of
579 attribute being processed.
580 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
581 (resolve_dynamic_array): Rename to...
582 (resolve_dynamic_array_or_string): ...this, update header comment,
583 and accept TYPE_CODE_STRING.
584 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
585
11a8b164
AB
5862019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
587
588 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
589 of its implementation from...
590 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
591 the new function.
592
5bbd8269
AB
5932019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
594
595 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
596 create a range with stride where appropriate.
597 * f-valprint.c: Include 'gdbarch.h'.
598 (f77_print_array_1): Take the stride into account when walking the
599 array. Also convert the stride into addressable units.
600 * gdbtypes.c (create_range_type): Initialise the stride to
601 constant zero.
602 (create_range_type_with_stride): New function, initialise the
603 range as normal, and then setup the stride.
604 (has_static_range): Include the stride here. Also change the
605 return type to bool.
606 (create_array_type_with_stride): Consider the range stride if the
607 array isn't given its own stride.
608 (resolve_dynamic_range): Resolve the stride if needed.
609 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
610 (struct range_bounds) <flag_is_byte_stride>: New member variable.
611 (TYPE_BIT_STRIDE): Define.
612 (TYPE_ARRAY_BIT_STRIDE): Define.
613 (create_range_type_with_stride): Declare.
614 * valarith.c (value_subscripted_rvalue): Take range stride into
615 account when walking the array.
616
82e3b564
TT
6172019-12-01 Tom Tromey <tom@tromey.com>
618
619 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
620 specially.
621
517d261d
TT
6222019-12-01 Tom Tromey <tom@tromey.com>
623
624 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
625 \0.
626 * unittests/tui-selftests.c: New file.
627 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
628
484c9b64
TT
6292019-12-01 Tom Tromey <tom@tromey.com>
630
631 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
632
a2a7af0c
TT
6332019-12-01 Tom Tromey <tom@tromey.com>
634
635 * NEWS: Document new settings.
636 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
637 * tui/tui-win.c (_initialize_tui_win): Add border style
638 observers.
639 * tui/tui-io.h (tui_apply_style): Declare.
640 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
641 longer static.
642 (apply_ansi_escape, tui_set_reverse_mode): Update.
643 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
644 Add "skip_intensity" parameter.
645 <changed>: New member.
646 <do_set_value>: Declare.
647 (tui_border_style, tui_active_border_style): Declare.
648 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
649 globals.
650 (cli_style_option): Initialize "changed".
651 (cli_style_option::do_set_value): New function.
652 (cli_style_option::add_setshow_commands): Add "skip_intensity"
653 parameter. Update.
654 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
655 (_initialize_cli_style): Update. Create TUI border style
656 commands.
657
d1da6b01
TT
6582019-12-01 Tom Tromey <tom@tromey.com>
659
660 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
661 parameter.
662 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
663 parameter.
664 * tui/tui-win.h (compact_source): Declare.
665 * tui/tui-win.c (compact_source): New global.
666 (tui_set_compact_source, tui_show_compact_source): New functions.
667 (_initialize_tui_win): Add "compact-source" setting.
668 * tui/tui-source.c (tui_source_window::set_contents): Handle
669 compact_source setting.
670 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
671 * NEWS: Document new setting.
672
489dbda6
TT
6732019-11-30 Tom Tromey <tom@tromey.com>
674
675 * dwarf2read.c (dwarf2_add_field): Include field offset when
676 computing variant part length.
677
bf498525
PW
6782019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
679 * NEWS: Mention define-prefix. Tell that command names can now
680 contain a . character.
681
be09caf1
PW
6822019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
683
684 * command.h (valid_cmd_char_p): Declare.
685 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
686 the check of valid command char.
687 (find_command_name_length, valid_user_defined_cmd_name_p): Use
688 valid_cmd_char_p.
689 * cli/cli-script.c (validate_comname): Likewise.
690 * completer.c (gdb_completer_command_word_break_characters):
691 Do not remove . from the word break char, update comments.
692 (complete_line_internal_1): Use valid_cmd_char_p.
693 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
694 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
695
c6ac7fc9
PW
6962019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
697
698 * cli/cli-script.c (do_define_command): Ensure a redefined
699 prefix command is kept as a prefix command.
700 (define_prefix_command): New function.
701 (show_user_1): Report user defined prefixes.
702 (_initialize_cli_script): Create the new 'define-prefix' command.
703 Add completers for 'define' and 'document'.
704 * top.c (execute_command): If command is a user-defined prefix only
705 command, report the list of commands for this prefix command.
706
a992a3b0
TBA
7072019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
708
709 * valops.c (find_oload_champ): Improve debug output.
710
e9194a1a
TBA
7112019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
712
713 * valops.c (find_oload_champ): Print part of debug messages
714 before the badness vector is std::move'd.
715
53a008a6
TT
7162019-11-28 Tom Tromey <tom@tromey.com>
717
718 * value.c (creal_internal_fn): Fix comment.
719
bab05c83
TT
7202019-11-28 Tom Tromey <tom@tromey.com>
721
722 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
723 flag_bound_evaluated>: Now unsigned.
724
2522f049
TT
7252019-11-28 Tom Tromey <tom@tromey.com>
726
727 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
728 declare.
729
38b49e22
MS
7302019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
731
732 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
733 debug output.
734 * jit.c (jit_unregister_code): Add debug print to match
735 `jit_register_code`.
736
35125921
CB
7372019-11-27 Christian Biesinger <cbiesinger@google.com>
738
739 * NEWS: Mention the new multithreaded symbol loading.
740
62e77f56
CB
7412019-11-27 Christian Biesinger <cbiesinger@google.com>
742
743 * maint.c (n_worker_threads): Default to 0.
744 (worker_threads_disabled): New function.
745 * maint.h (worker_threads_disabled): New function.
746 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
747 here if worker_threads_disabled () is true.
748 (minimal_symbol_reader::install): Skip all threading if
749 worker_threads_disabled () is true.
750
f29d7f6b
CB
7512019-11-27 Christian Biesinger <cbiesinger@google.com>
752
753 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
754 hash code if possible.
755 (add_minsym_to_demangled_hash_table): Likewise.
756 (minimal_symbol_reader::install): Compute the hash codes for msymbol
757 on the background thread.
758 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
759 Add these fields.
760
e76b2246
CB
7612019-11-27 Christian Biesinger <cbiesinger@google.com>
762
763 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
764 of the mangled name on the background thread.
765 * symtab.c (symbol_set_names): Allow passing in the hash of the
766 linkage_name.
767 * symtab.h (symbol_set_names): Likewise.
768
8d9a2568
KB
7692019-11-27 Kevin Buettner <kevinb@redhat.com>
770
771 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
772 physnames are computed for inherited DIEs.
773
fad03f6e
TT
7742019-11-27 Tom Tromey <tromey@adacore.com>
775
776 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
777 backslashes.
778 * cp-support.c: Remove unnecessary backslashes.
779
43678b0a
CB
7802019-11-27 Christian Biesinger <cbiesinger@google.com>
781
782 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
783 with sym->set_linkage_name.
784 * coffread.c (coff_read_enum_type): Likewise.
785 * mdebugread.c (parse_symbol): Likewise.
786 * stabsread.c (patch_block_stabs): Likewise.
787 (define_symbol): Likewise.
788 (read_enum_type): Likewise.
789 (common_block_end): Likewise.
790 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
791 function.
792 (SYMBOL_SET_LINKAGE_NAME): Remove.
793 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
794 with sym->set_linkage_name.
795
db5960b4
AB
7962019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
797
798 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
799 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
800 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
801 * NEWS: Mention new MI command.
802
7dc42066
AB
8032019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
804
805 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
806 '-symbol-info-types', and '-symbol-info-variables'.
807 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
808 (mi_cmd_symbol_info_types): Declare.
809 (mi_cmd_symbol_info_variables): Declare.
810 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
811 (output_debug_symbol): New function.
812 (output_nondebug_symbol): New function.
813 (mi_symbol_info): New function.
814 (mi_info_functions_or_variables): New function.
815 (mi_cmd_symbol_info_functions): New function.
816 (mi_cmd_symbol_info_types): New function.
817 (mi_cmd_symbol_info_variables): New function.
818 * NEWS: Mention new commands.
819
5f512a7d
AB
8202019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
821
822 * symtab.c (symbol_to_info_string): New function, most content
823 moved from print_symbol_info, but updated to return a std::string.
824 (print_symbol_info): Update to use symbol_to_info_string and print
825 returned string.
826 * symtab.h (symbol_to_info_string): Declare new function.
827
470c0b1c
AB
8282019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
829
830 * python/python.c (gdbpy_rbreak): Convert to using
831 global_symbol_searcher.
832 * symtab.c (file_matches): Convert return type to bool, change
833 file list to std::vector, update header comment.
834 (search_symbols): Rename to...
835 (global_symbol_searcher::search): ...this and update now its
836 a member function of global_symbol_searcher. Take account of the
837 changes to file_matches.
838 (symtab_symbol_info): Convert to using global_symbol_searcher.
839 (rbreak_command): Likewise.
840 (search_module_symbols): Likewise.
841 * symtab.h (enum symbol_search): Update comment.
842 (search_symbols): Remove declaration.
843 (class global_symbol_searcher): New class.
844
57357d9d
TT
8452019-11-26 Tom Tromey <tromey@adacore.com>
846
847 * cp-support.c (_initialize_cp_support): Conditionally initialize
848 gdb_demangle_attempt_core_dump.
849
3ea16160
TT
8502019-11-26 Tom Tromey <tom@tromey.com>
851
852 * python/py-function.c (fnpy_init): Update.
853 * value.h (add_internal_function): Adjust declaration.
854 * value.c (function_destroyer): Remove.
855 (do_add_internal_function): Don't set destroyer or copy name.
856 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
857 Set name_allocated.
858 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
859 (cmdpy_init): Set name_allocated.
860 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
861 member.
862 (~cmd_list_element): Free "name" if needed.
863
1a6d41c6
TT
8642019-11-26 Tom Tromey <tom@tromey.com>
865
866 * value.h (add_internal_function): Add new overload. Move
867 documentation from value.h.
868 * value.c (do_add_internal_function): New function.
869 (add_internal_function): Use it. Add new overload.
870 (function_destroyer): Don't free doc.
871 * python/py-function.c (fnpy_init): Update.
872
8318f3c3
TT
8732019-11-26 Tom Tromey <tom@tromey.com>
874
875 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
876 (cmdpy_init): Set "doc_allocated".
877
4da8c3a8
TT
8782019-11-26 Tom Tromey <tom@tromey.com>
879
880 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
881 name of worker thread.
882 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
883 pthread_setname_np.
884 * configure, config.in: Rebuild.
885
971db5e2
TT
8862019-11-26 Tom Tromey <tom@tromey.com>
887
888 * python/python.c (class gdbpy_gil): New.
889 (struct gdbpy_event): Add constructor, destructor, operator().
890 (gdbpy_post_event): Use run_on_main_thread.
891 (gdbpy_initialize_events): Remove.
892 (do_start_initialization): Update.
893
22138db6
TT
8942019-11-26 Tom Tromey <tom@tromey.com>
895
896 * NEWS: Add entry.
897 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
898 commands. Call update_thread_pool_size.
899 (update_thread_pool_size, maintenance_set_worker_threads): New
900 functions.
901 (n_worker_threads): New global.
902
d55c9a68
TT
9032019-11-26 Christian Biesinger <cbiesinger@google.com>
904 Tom Tromey <tom@tromey.com>
905
906 * minsyms.c (minimal_symbol_reader::install): Use
907 parallel_for_each.
908 * gdbsupport/parallel-for.h: New file.
909 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
910
a0b57563
CB
9112019-11-26 Christian Biesinger <cbiesinger@google.com>
912 Tom Tromey <tom@tromey.com>
913
914 * gdbsupport/thread-pool.h: New file.
915 * gdbsupport/thread-pool.c: New file.
916 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
917 (HFILES_NO_SRCDIR): Add thread-pool.h.
918
3b3978bc
TT
9192019-11-26 Tom Tromey <tom@tromey.com>
920
921 * event-top.h (thread_local_segv_handler): Declare.
922 * event-top.c (thread_local_segv_handler): New global.
923 (install_handle_sigsegv, handle_sigsegv): New functions.
924 (async_init_signals): Install SIGSEGV handler.
925 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
926 thread-local.
927 (report_failed_demangle): New function.
928 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
929 handler-setting code, instead use segv_handler. Run warning code
930 on main thread.
931
9411c49e
TT
9322019-11-26 Tom Tromey <tom@tromey.com>
933
934 * run-on-main-thread.c: New file.
935 * run-on-main-thread.h: New file.
936 * unittests/main-thread-selftests.c: New file.
937 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
938 main-thread-selftests.c.
939 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
940 (COMMON_SFILES): Add run-on-main-thread.c.
941
c3efb965
TT
9422019-11-26 Tom Tromey <tom@tromey.com>
943
944 * main.c (setup_alternate_signal_stack): Remove.
945 (captured_main_1): Use gdb::alternate_signal_stack.
946 * gdbsupport/alt-stack.h: New file.
947
21987b9c
TT
9482019-11-26 Tom Tromey <tom@tromey.com>
949
950 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
951 Remove comment.
952 (save_original_signals_state, restore_original_signals_state): Use
953 gdb_sigmask.
954 * linux-nat.c (block_child_signals, restore_child_signals_mask)
955 (_initialize_linux_nat): Use gdb_sigmask.
956 * guile/guile.c (_initialize_guile): Use block_signals.
957 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
958 * gdbsupport/gdb-sigmask.h: New file.
959 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
960 * cp-support.c (gdb_demangle): Use gdb_sigmask.
961 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
962 pthread_sigmask.
963 * configure, config.in: Rebuild.
964 * gdbsupport/block-signals.h: New file.
965
5e030278
TT
9662019-11-26 Tom Tromey <tom@tromey.com>
967
968 * acinclude.m4: Include ax_pthread.m4.
969 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
970 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
971 (CLIBS): Use PTHREAD_LIBS.
972 (aclocal_m4_deps): Add ax_pthread.m4.
973 * config.in, configure: Rebuild.
974 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
975
5a79c107
TT
9762019-11-26 Tom Tromey <tom@tromey.com>
977
978 * symtab.h (struct minimal_symbol) <name_set>: New member.
979 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
980 Don't call symbol_set_names.
981 (minimal_symbol_reader::install): Call symbol_set_names.
982
aa369509
PW
9832019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
984
985 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
986 restore_active_ext_lang, as GIL is needed for (indirectly)
987 called PyOS_InterruptOccurred.
988
cadc9cb8
SM
9892019-11-26 Simon Marchi <simon.marchi@efficios.com>
990
991 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
992 definition.
993
d04afd58
SM
9942019-11-26 Simon Marchi <simon.marchi@efficios.com>
995
996 * remote-sim.c (simulator_command): Make static, remove
997 declaration.
998
dd694d77
SM
9992019-11-26 Simon Marchi <simon.marchi@efficios.com>
1000
1001 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1002 static.
1003 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1004 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1005 (main): Likewise.
1006 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1007 (main): Likewise.
1008 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1009 (main): Likewise.
1010 * unittests/basic_string_view/element_access/char/1.cc (test01):
1011 Likewise.
1012 (main): Likewise.
1013 * unittests/basic_string_view/element_access/char/empty.cc (main):
1014 Likewise.
1015 * unittests/basic_string_view/element_access/char/front_back.cc
1016 (test01): Likewise.
1017 (main): Likewise.
1018 * unittests/basic_string_view/inserters/char/2.cc (test05):
1019 Likewise.
1020 (main): Likewise.
1021 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1022 (test01): Likewise.
1023 (main): Likewise.
1024 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1025 (test01): Likewise.
1026 (main): Likewise.
1027 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1028 Likewise.
1029 * unittests/basic_string_view/operations/compare/char/1.cc
1030 (test01): Likewise.
1031 (main): Likewise.
1032 * unittests/basic_string_view/operations/compare/char/13650.cc
1033 (test01): Likewise.
1034 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1035 Likewise.
1036 (main): Likewise.
1037 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1038 Likewise.
1039 (main): Likewise.
1040 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1041 Likewise.
1042 (main): Likewise.
1043 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1044 Likewise.
1045 (main): Likewise.
1046 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1047 Likewise.
1048 (main): Likewise.
1049 * unittests/basic_string_view/operations/find/char/4.cc (main):
1050 Likewise.
1051 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1052 Likewise.
1053 (main): Likewise.
1054 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1055 Likewise.
1056 (main): Likewise.
1057 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1058 Likewise.
1059 (main): Likewise.
1060 * unittests/basic_string_view/operations/substr/char/1.cc
1061 (test01): Likewise.
1062 (main): Likewise.
1063 * unittests/basic_string_view/operators/char/2.cc (main):
1064 Likewise.
1065 * unittests/optional/assignment/1.cc (test): Likewise.
1066 * unittests/optional/assignment/2.cc (test): Likewise.
1067 * unittests/optional/assignment/3.cc (test): Likewise.
1068 * unittests/optional/assignment/4.cc (test): Likewise.
1069 * unittests/optional/assignment/5.cc (test): Likewise.
1070 * unittests/optional/assignment/6.cc (test): Likewise.
1071 * unittests/optional/assignment/7.cc (test): Likewise.
1072 * unittests/optional/cons/copy.cc (test): Likewise.
1073 * unittests/optional/cons/default.cc (test): Likewise.
1074 * unittests/optional/cons/move.cc (test): Likewise.
1075 * unittests/optional/cons/value.cc (test): Likewise.
1076 * unittests/optional/in_place.cc (test): Likewise.
1077 * unittests/optional/observers/1.cc (test): Likewise.
1078 * unittests/optional/observers/2.cc (test): Likewise.
1079
3b5c1d49
SM
10802019-11-26 Simon Marchi <simon.marchi@efficios.com>
1081
1082 * tui-win.h (tui_set_var_cmd): Remove.
1083 * tui-win.c (tui_set_var_cmd): Make static.
1084
adce99fe
SM
10852019-11-26 Simon Marchi <simon.marchi@efficios.com>
1086
1087 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1088 rbreak_command_wrapper): Remove.
1089 * symtab.c (rbreak_command_wrapper): Remove.
1090
fe3adccf
SM
10912019-11-26 Simon Marchi <simon.marchi@efficios.com>
1092
1093 * inferior.h (info_terminal_command): Remove declaration.
1094 * inflow.c (info_terminal_command): Make static.
1095
b926335f
SM
10962019-11-26 Simon Marchi <simon.marchi@efficios.com>
1097
1098 * inferior.c (exit_inferior_silent): Remove.
1099
b62f6f54
SM
11002019-11-26 Simon Marchi <simon.marchi@efficios.com>
1101
1102 * dictionary.c (dict_empty, mdict_empty): Remove.
1103 * dictionary.c (mdict_empty): Remove.
1104
cb8c24b6
SM
11052019-11-26 Simon Marchi <simon.marchi@efficios.com>
1106
1107 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1108 (arc_insn_get_memory_offset): Likewise.
1109 (arc_insn_dump): Likewise.
1110 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1111 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1112 * dictionary.c (dict_iterator_next): Likewise.
1113 (dict_iter_match_first): Likewise.
1114 (dict_iter_match_next): Likewise.
1115 * f-lang.c (evaluate_subexp_f): Likewise.
1116 * hppa-tdep.c (hppa_read_pc): Likewise.
1117 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1118 * parse.c (write_exp_elt_msym): Likewise.
1119 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1120 * remote.c (remote_packet_size): Likewise.
1121 (remote_notif_stop_parse): Likewise.
1122 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1123 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1124 * source.c (prepare_path_for_appending): Likewise.
1125 * sparc64-linux-tdep.c
1126 (sparc64_linux_handle_segmentation_fault); Likewise.
1127 * stack.c (frame_selection_by_function_completer): Likewise.
1128
781597ff
SM
11292019-11-26 Simon Marchi <simon.marchi@efficios.com>
1130
1131 * completer.c (set_gdb_completion_word_break_characters):
1132 Remove.
1133
23baa4cc
SM
11342019-11-26 Simon Marchi <simon.marchi@efficios.com>
1135
1136 * dwarf-index-write.c: Include dwarf-index-write.h.
1137 * mi/mi-interp.c: Include mi/mi-interp.h.
1138
23767560
SM
11392019-11-26 Simon Marchi <simon.marchi@efficios.com>
1140
1141 * aarch32-tdep.c: Include aarch32-tdep.h.
1142 * aarch32-tdep.h: Forward-declare struct target_desc.
1143
6d91ce9a
CB
11442019-11-26 Christian Biesinger <cbiesinger@google.com>
1145
1146 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1147 strerror.
1148 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1149 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1150
3cf2f237
TV
11512019-11-25 Tom de Vries <tdevries@suse.de>
1152
1153 * contrib/words.sh: Add -c option.
1154
5b89c67a
CB
11552019-11-25 Christian Biesinger <cbiesinger@google.com>
1156
1157 * solib.c (solib_find_1): Change int to bool.
1158 (exec_file_find): Change int to bool.
1159 (solib_find): Change int to bool.
1160 (solib_read_symbols): Change int to bool.
1161 (solib_used): Change int to bool.
1162 (solib_add): Change int to bool.
1163 (info_sharedlibrary_command): Change int to bool.
1164 (solib_contains_address_p): Change int to bool.
1165 (solib_keep_data_in_core): Change int to bool.
1166 (in_solib_dynsym_resolve_code): Change int to bool.
1167 (reload_shared_libraries_1): Change int to bool.
1168 (gdb_sysroot_changed): Change int to bool.
1169 * solib.h (solib_read_symbols): Change int to bool.
1170 (solib_contains_address_p): Change int to bool.
1171 (solib_keep_data_in_core): Change int to bool.
1172 (in_solib_dynsym_resolve_code): Change int to bool.
1173 (libpthread_name_p): Change int to bool.
1174
6cc8564b
LM
11752019-11-25 Luis Machado <luis.machado@linaro.org>
1176
1177 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1178 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1179 (remote_packet_max_chars): New static global.
1180 (show_remote_packet_max_chars): New function.
1181 (remote_target::putpkt_binary): Adjust to use new
1182 remote_packet_max_chars option.
1183 (remote_target::getpkt_or_notif_sane_1): Likewise.
1184 (_initialize_remote): Register new remote-packet-max-chars option.
1185
a7cdaa91
SM
11862019-11-24 Simon Marchi <simon.marchi@efficios.com>
1187
1188 * m68k-linux-nat.c: Include gdbarch.h.
1189
26abc753
TT
11902019-11-24 Tom Tromey <tom@tromey.com>
1191
1192 * symfile.c (read_symbols): Update.
1193 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1194 bool.
1195 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1196 (psym_lookup_symbol, psym_find_last_source_symtab)
1197 (psym_forget_cached_source_info, psym_print_stats)
1198 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1199 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1200 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1201 (psym_find_compunit_symtab_by_address)
1202 (maintenance_print_psymbols, maintenance_info_psymtabs)
1203 (maintenance_check_psymtabs): Update.
1204 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1205 bool.
1206
012fc909
TT
12072019-11-22 Tom Tromey <tom@tromey.com>
1208
1209 * observable.h: Update comments.
1210
c83d8d32
TT
12112019-11-22 Tom Tromey <tromey@adacore.com>
1212
1213 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1214 (print_ada_task_info): Don't try to fetch thread id if task is not
1215 alive.
1216
987012b8
CB
12172019-11-22 Christian Biesinger <cbiesinger@google.com>
1218
1219 * ada-exp.y: Update.
1220 * ada-lang.c (sort_choices): Update.
1221 (ada_print_symbol_signature): Update.
1222 (resolve_subexp): Update.
1223 (ada_parse_renaming): Update.
1224 (ada_read_renaming_var_value): Update.
1225 (lesseq_defined_than): Update.
1226 (remove_extra_symbols): Update.
1227 (remove_irrelevant_renamings): Update.
1228 (ada_add_block_symbols): Update.
1229 (ada_collect_symbol_completion_matches): Update.
1230 (ada_is_renaming_symbol): Update.
1231 (aggregate_assign_from_choices): Update.
1232 (ada_evaluate_subexp): Update.
1233 (ada_has_this_exception_support): Update.
1234 (ada_is_non_standard_exception_sym): Update.
1235 (ada_add_exceptions_from_frame): Update.
1236 (ada_add_global_exceptions): Update.
1237 (ada_print_subexp): Update.
1238 * ax-gdb.c (gen_var_ref): Update.
1239 (gen_maybe_namespace_elt): Update.
1240 (gen_expr_for_cast): Update.
1241 (gen_expr): Update.
1242 * block.h: Update.
1243 * blockframe.c (find_pc_partial_function): Update.
1244 * breakpoint.c (print_breakpoint_location): Update.
1245 (update_static_tracepoint): Update.
1246 * btrace.c (ftrace_print_function_name): Update.
1247 (ftrace_function_switched): Update.
1248 * buildsym.c (find_symbol_in_list): Update.
1249 * c-exp.y: Update.
1250 * c-typeprint.c (c_print_typedef): Update.
1251 (c_type_print_template_args): Update.
1252 * cli/cli-cmds.c (edit_command): Update.
1253 (list_command): Update.
1254 (print_sal_location): Update.
1255 * coffread.c (patch_opaque_types): Update.
1256 (process_coff_symbol): Update.
1257 (coff_read_enum_type): Update.
1258 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1259 (convert_one_symbol): Update.
1260 (hash_symname): Update.
1261 (eq_symname): Update.
1262 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1263 * compile/compile-cplus-types.c (debug_print_scope): Update.
1264 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1265 * compile/compile-object-load.c (get_out_value_type): Update.
1266 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1267 (search_symbol_list): Update.
1268 (cp_lookup_symbol_imports_or_template): Update.
1269 * cp-support.c (overload_list_add_symbol): Update.
1270 * ctfread.c (psymtab_to_symtab): Update.
1271 * dbxread.c (cp_set_block_scope): Update.
1272 * dictionary.c (iter_match_first_hashed): Update.
1273 (iter_match_next_hashed): Update.
1274 (insert_symbol_hashed): Update.
1275 (iter_match_next_linear): Update.
1276 * dictionary.h: Update.
1277 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1278 (locexpr_describe_location_piece): Update.
1279 (locexpr_describe_location_1): Update.
1280 (locexpr_generate_c_location): Update.
1281 (loclist_describe_location): Update.
1282 (loclist_generate_c_location): Update.
1283 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1284 (read_func_scope): Update.
1285 (process_enumeration_scope): Update.
1286 (new_symbol): Update.
1287 (dwarf2_const_value): Update.
1288 (dwarf2_symbol_mark_computed): Update.
1289 * eval.c (evaluate_funcall): Update.
1290 (evaluate_subexp_standard): Update.
1291 * expprint.c (print_subexp_standard): Update.
1292 (dump_subexp_body_standard): Update.
1293 * f-valprint.c (info_common_command_for_block): Update.
1294 * findvar.c (get_hosting_frame): Update.
1295 (default_read_var_value): Update.
1296 * go-lang.c (go_symbol_package_name): Update.
1297 * guile/scm-block.c (bkscm_print_block_smob): Update.
1298 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1299 (gdbscm_symbol_name): Update.
1300 (gdbscm_symbol_linkage_name): Update.
1301 (gdbscm_symbol_print_name): Update.
1302 * infcall.c (get_function_name): Update.
1303 * infcmd.c (jump_command): Update.
1304 (finish_command): Update.
1305 * infrun.c (insert_exception_resume_breakpoint): Update.
1306 * linespec.c (canonicalize_linespec): Update.
1307 (create_sals_line_offset): Update.
1308 (convert_linespec_to_sals): Update.
1309 (complete_label): Update.
1310 (find_label_symbols_in_block): Update.
1311 * m2-typeprint.c (m2_print_typedef): Update.
1312 * mdebugread.c (mdebug_reg_to_regnum): Update.
1313 (parse_symbol): Update.
1314 (mylookup_symbol): Update.
1315 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1316 (list_args_or_locals): Update.
1317 * objc-lang.c (compare_selectors): Update.
1318 (info_selectors_command): Update.
1319 (compare_classes): Update.
1320 (info_classes_command): Update.
1321 (find_imps): Update.
1322 * p-typeprint.c (pascal_print_typedef): Update.
1323 * printcmd.c (build_address_symbolic): Update.
1324 (info_address_command): Update.
1325 (print_variable_and_value): Update.
1326 * python/py-framefilter.c (extract_sym): Update.
1327 (py_print_single_arg): Update.
1328 * python/py-symbol.c (sympy_str): Update.
1329 (sympy_get_name): Update.
1330 (sympy_get_linkage_name): Update.
1331 * python/python.c (gdbpy_rbreak): Update.
1332 * record-btrace.c (btrace_get_bfun_name): Update.
1333 (btrace_call_history): Update.
1334 * rust-lang.c (rust_print_typedef): Update.
1335 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1336 * stabsread.c (stab_reg_to_regnum): Update.
1337 (define_symbol): Update.
1338 (read_enum_type): Update.
1339 (common_block_end): Update.
1340 (cleanup_undefined_types_1): Update.
1341 (scan_file_globals): Update.
1342 * stack.c (print_frame_arg): Update.
1343 (print_frame_args): Update.
1344 (find_frame_funname): Update.
1345 (info_frame_command_core): Update.
1346 (iterate_over_block_locals): Update.
1347 (print_block_frame_labels): Update.
1348 (do_print_variable_and_value): Update.
1349 (iterate_over_block_arg_vars): Update.
1350 (return_command): Update.
1351 * symmisc.c (dump_symtab_1): Update.
1352 (print_symbol): Update.
1353 * symtab.c (eq_symbol_entry): Update.
1354 (symbol_cache_dump): Update.
1355 (lookup_language_this): Update.
1356 (find_pc_sect_line): Update.
1357 (skip_prologue_sal): Update.
1358 (symbol_search::compare_search_syms): Update.
1359 (treg_matches_sym_type_name): Update.
1360 (search_symbols): Update.
1361 (print_symbol_info): Update.
1362 (rbreak_command): Update.
1363 (completion_list_add_symbol): Update.
1364 (find_gnu_ifunc): Update.
1365 (get_symbol_address): Update.
1366 (search_module_symbols): Update.
1367 (info_module_subcommand): Update.
1368 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1369 (SYMBOL_LINKAGE_NAME): Remove.
1370 (SYMBOL_DEMANGLED_NAME): Remove.
1371 (SYMBOL_PRINT_NAME): Remove.
1372 (SYMBOL_SEARCH_NAME): Remove.
1373 * tracepoint.c (set_traceframe_context): Update.
1374 (validate_actionline): Update.
1375 (collection_list::collect_symbol): Update.
1376 (encode_actions_1): Update.
1377 (info_scope_command): Update.
1378 (print_one_static_tracepoint_marker): Update.
1379 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1380 * valops.c (address_of_variable): Update.
1381 (find_overload_match): Update.
1382 (find_oload_champ): Update.
1383
c9d95fa3
CB
13842019-11-22 Christian Biesinger <cbiesinger@google.com>
1385
1386 * ada-lang.c (ada_lookup_simple_minsym): Update.
1387 (ada_collect_symbol_completion_matches): Update.
1388 * ada-tasks.c (read_atcb): Update.
1389 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1390 (amd64_windows_skip_trampoline_code): Update.
1391 * arm-tdep.c (skip_prologue_function): Update.
1392 (arm_skip_stack_protector): Update.
1393 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1394 (arm_wince_skip_main_prologue): Update.
1395 * ax-gdb.c (gen_expr): Update.
1396 * block.c (call_site_for_pc): Update.
1397 * blockframe.c (find_pc_partial_function): Update.
1398 * breakpoint.c (set_breakpoint_location_function): Update.
1399 * btrace.c (ftrace_print_function_name): Update.
1400 (ftrace_function_switched): Update.
1401 * c-valprint.c (print_unpacked_pointer): Update.
1402 * coffread.c (coff_symfile_read): Update.
1403 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1404 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1405 * dwarf-index-write.c (write_psymbols): Update.
1406 * dwarf2loc.c (call_site_to_target_addr): Update.
1407 (func_verify_no_selftailcall): Update.
1408 (tailcall_dump): Update.
1409 (call_site_find_chain_1): Update.
1410 (dwarf_expr_reg_to_entry_parameter): Update.
1411 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1412 * eval.c (evaluate_funcall): Update.
1413 (evaluate_subexp_standard): Update.
1414 (evaluate_subexp_for_sizeof): Update.
1415 * expprint.c (print_subexp_standard): Update.
1416 (dump_subexp_body_standard): Update.
1417 * frame.c (get_prev_frame_always_1): Update.
1418 * frv-tdep.c (frv_skip_main_prologue): Update.
1419 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1420 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1421 (gnuv3_get_typename_from_type_info): Update.
1422 (gnuv3_skip_trampoline): Update.
1423 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1424 * i386-tdep.c (i386_skip_main_prologue): Update.
1425 (i386_pe_skip_trampoline_code): Update.
1426 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1427 * infcall.c (get_function_name): Update.
1428 * linespec.c (minsym_found): Update.
1429 * linux-fork.c (info_checkpoints_command): Update.
1430 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1431 (m32c_m16c_pointer_to_address): Update.
1432 * maint.c (maintenance_translate_address): Update.
1433 * minsyms.c (add_minsym_to_hash_table): Update.
1434 (add_minsym_to_demangled_hash_table): Update.
1435 (lookup_minimal_symbol_mangled): Update.
1436 (lookup_minimal_symbol_demangled): Update.
1437 (lookup_minimal_symbol_linkage): Update.
1438 (lookup_minimal_symbol_text): Update.
1439 (lookup_minimal_symbol_by_pc_name): Update.
1440 (minimal_symbol_is_less_than): Update.
1441 (compact_minimal_symbols): Update.
1442 (build_minimal_symbol_hash_tables): Update.
1443 (find_solib_trampoline_target): Update.
1444 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1445 (mips_skip_pic_trampoline_code): Update.
1446 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1447 * objc-lang.c (info_selectors_command): Update.
1448 (info_classes_command): Update.
1449 (find_methods): Update.
1450 (find_imps): Update.
1451 * p-valprint.c (pascal_val_print): Update.
1452 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1453 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1454 * printcmd.c (build_address_symbolic): Update.
1455 (info_symbol_command): Update.
1456 * psymtab.c (psymbol_name_matches): Update.
1457 (match_partial_symbol): Update.
1458 (lookup_partial_symbol): Update.
1459 (print_partial_symbols): Update.
1460 (sort_pst_symbols): Update.
1461 (maintenance_check_psymtabs): Update.
1462 * python/py-framefilter.c (py_print_frame): Update.
1463 * python/python.c (gdbpy_rbreak): Update.
1464 * record-btrace.c (btrace_get_bfun_name): Update.
1465 (btrace_call_history): Update.
1466 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1467 (rs6000_skip_trampoline_code): Update.
1468 * sol-thread.c (info_cb): Update.
1469 * stabsread.c (scan_file_globals): Update.
1470 * stack.c (find_frame_funname): Update.
1471 (info_frame_command_core): Update.
1472 * symmisc.c (dump_msymbols): Update.
1473 * symtab.c (symbol_natural_name): Rename to..,
1474 (general_symbol_info::natural_name): ...this.
1475 (symbol_demangled_name): Rename to...
1476 (general_symbol_info::demangled_name): ...this.
1477 (symbol_search_name): Rename to...
1478 (general_symbol_info::search_name): ...this.
1479 (symbol_matches_search_name): Update.
1480 (find_pc_sect_line): Update.
1481 (skip_prologue_sal): Update.
1482 (search_symbols): Update.
1483 (print_msymbol_info): Update.
1484 (rbreak_command): Update.
1485 (completion_list_add_msymbol): Update.
1486 (completion_list_objc_symbol): Update.
1487 (get_msymbol_address): Update.
1488 * symtab.h (struct general_symbol_info): Add member functions
1489 natural_name (), linkage_name (), print_name (), demangled_name (),
1490 and search_name ().
1491 (SYMBOL_NATURAL_NAME): Update.
1492 (symbol_natural_name): Move to a member function on general_symbol_info.
1493 (SYMBOL_DEMANGLED_NAME): Update.
1494 (symbol_demangled_name): Move to a member function on
1495 general_symbol_info.
1496 (SYMBOL_SEARCH_NAME): Update.
1497 (symbol_search_name): Move to a member function on general_symbol_info.
1498 (MSYMBOL_NATURAL_NAME): Remove.
1499 (MSYMBOL_LINKAGE_NAME): Remove.
1500 (MSYMBOL_PRINT_NAME): Remove.
1501 (MSYMBOL_DEMANGLED_NAME): Remove.
1502 (MSYMBOL_SEARCH_NAME): Remove.
1503 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1504
f8bab2d6
CB
15052019-11-22 Christian Biesinger <cbiesinger@google.com>
1506
1507 * symtab.c (create_demangled_names_hash): Use per_bfd->
1508 minimal_symbol_count for computing the initial size, if greater
1509 than our default size.
1510
85e7588d
TV
15112019-11-22 Tom de Vries <tdevries@suse.de>
1512
1513 * contrib/words.sh: Improve words extraction.
1514
f6180073
TV
15152019-11-22 Tom de Vries <tdevries@suse.de>
1516
1517 * contrib/words.sh: Combine sed invocations.
1518
f10ffa41
CB
15192019-11-21 Christian Biesinger <cbiesinger@google.com>
1520
1521 * Makefile.in: Update.
1522 * demangle.c: Rename to...
1523 * gdb-demangle.c: ..this.
1524 (is_cplus_marker): Change return type to bool.
1525 (_initialize_demangler): Rename to...
1526 (_initialize_gdb_demangle): ...this.
1527 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1528 * symtab.h (demangle): Remove declaration; instead include
1529 gdb-demangle.h.
1530
6ba18521
TT
15312019-11-21 Tom Tromey <tromey@adacore.com>
1532
1533 * gdbsupport/format.c (format_pieces): Parse %I64d.
1534 * unittests/format_pieces-selftests.c (test_windows_formats): New
1535 function.
1536 (run_tests): Call it.
1537
34877895
PJ
15382019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1539
1540 Byte reverse display of variables with DW_END_big, DW_END_little
1541 (DW_AT_endianity) dwarf attributes if different than the native
1542 byte order.
1543 * ada-lang.c (ada_value_binop):
1544 Use type_byte_order instead of gdbarch_byte_order.
1545 * ada-valprint.c (printstr):
1546 (ada_val_print_string):
1547 * ada-lang.c (value_pointer):
1548 (ada_value_binop):
1549 Use type_byte_order instead of gdbarch_byte_order.
1550 * c-lang.c (c_get_string):
1551 Use type_byte_order instead of gdbarch_byte_order.
1552 * c-valprint.c (c_val_print_array):
1553 Use type_byte_order instead of gdbarch_byte_order.
1554 * cp-valprint.c (cp_print_class_member):
1555 Use type_byte_order instead of gdbarch_byte_order.
1556 * dwarf2loc.c (rw_pieced_value):
1557 Use type_byte_order instead of gdbarch_byte_order.
1558 * dwarf2read.c (read_base_type): Handle DW_END_big,
1559 DW_END_little
1560 * f-lang.c (f_get_encoding):
1561 Use type_byte_order instead of gdbarch_byte_order.
1562 * findvar.c (default_read_var_value):
1563 Use type_byte_order instead of gdbarch_byte_order.
1564 * gdbtypes.c (check_types_equal):
1565 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1566 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1567 and TYPE_ENDIANITY_LITTLE if set.
1568 (type_byte_order): new function.
1569 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1570 (struct main_type) <flag_endianity_not_default>:
1571 New field.
1572 (type_byte_order): New function.
1573 * infcmd.c (default_print_one_register_info):
1574 Use type_byte_order instead of gdbarch_byte_order.
1575 * p-lang.c (pascal_printstr):
1576 Use type_byte_order instead of gdbarch_byte_order.
1577 * p-valprint.c (pascal_val_print):
1578 Use type_byte_order instead of gdbarch_byte_order.
1579 * printcmd.c (print_scalar_formatted):
1580 Use type_byte_order instead of gdbarch_byte_order.
1581 * solib-darwin.c (darwin_current_sos):
1582 Use type_byte_order instead of gdbarch_byte_order.
1583 * solib-svr4.c (solib_svr4_r_ldsomap):
1584 Use type_byte_order instead of gdbarch_byte_order.
1585 * stap-probe.c (stap_modify_semaphore):
1586 Use type_byte_order instead of gdbarch_byte_order.
1587 * target-float.c (target_float_same_format_p):
1588 Use type_byte_order instead of gdbarch_byte_order.
1589 * valarith.c (scalar_binop):
1590 (value_bit_index):
1591 Use type_byte_order instead of gdbarch_byte_order.
1592 * valops.c (value_cast):
1593 Use type_byte_order instead of gdbarch_byte_order.
1594 * valprint.c (generic_emit_char):
1595 (generic_printstr):
1596 (val_print_string):
1597 Use type_byte_order instead of gdbarch_byte_order.
1598 * value.c (unpack_long):
1599 (unpack_bits_as_long):
1600 (unpack_value_bitfield):
1601 (modify_field):
1602 (pack_long):
1603 (pack_unsigned_long):
1604 Use type_byte_order instead of gdbarch_byte_order.
1605 * findvar.c (unsigned_pointer_to_address):
1606 (signed_pointer_to_address):
1607 (unsigned_address_to_pointer):
1608 (address_to_signed_pointer):
1609 (default_read_var_value):
1610 (default_value_from_register):
1611 Use type_byte_order instead of gdbarch_byte_order.
1612 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1613 Use type_byte_order instead of gdbarch_byte_order.
1614 * riscv-tdep.c (riscv_print_one_register_info):
1615 Use type_byte_order instead of gdbarch_byte_order.
1616
87fb00ea
SM
16172019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1618
1619 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1620 (current_ui_gdb_stdin_ptr): Likewise.
1621 (current_ui_gdb_stderr_ptr): Likewise.
1622 (current_ui_gdb_stdlog_ptr): Likewise.
1623 (current_ui_current_uiout_ptr): Likewise.
1624 (gen_ret_current_ui_field_ptr): Remove.
1625
65d1cd5f
TV
16262019-11-21 Tom de Vries <tdevries@suse.de>
1627
1628 PR gdb/24956
1629 * cli/cli-script.c (execute_control_command): Only switch to
1630 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1631
9f6ad286
TT
16322019-11-19 Tom Tromey <tom@tromey.com>
1633
1634 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1635 Now static. Change type of "name".
1636 (tui_set_win_height_command): Don't copy "arg".
1637 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1638 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1639
435d3d88
AT
16402019-11-19 Ali Tamur <tamur@google.com>
1641
1642 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1643 "if (attr != nullptr)".
1644 (dwarf2_find_base_address): Likewise.
1645 (dwarf2_build_include_psymtabs): Likewise.
1646 (read_cutu_die_from_dwo): Likewise.
1647 (read_func_scope): Likewise.
1648 (read_call_site_scope): Likewise.
1649 (dwarf2_get_pc_bounds): Likewise.
1650 (dwarf2_record_block_ranges): Likewise.
1651 (dwarf2_add_field): Likewise.
1652 (dwarf2_add_member_fn): Likewise.
1653 (read_structure_type): Likewise.
1654 (read_enumeration_type): Likewise.
1655 (read_array_type): Likewise.
1656 (read_array_order): Likewise.
1657 (read_set_type): Likewise.
1658 (read_common_block): Likewise.
1659 (read_tag_reference_type): Likewise.
1660 (read_tag_string_type): Likewise.
1661 (read_subroutine_type): Likewise.
1662 (read_base_type): Likewise.
1663 (read_subrange_type): Likewise.
1664 (new_symbol): Likewise.
1665 (prepare_one_comp_unit): Likewise.
1666
c9739b6a
TT
16672019-11-19 Tom Tromey <tromey@adacore.com>
1668
1669 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1670 result in error when DebugActiveProcess fails.
1671
494409bb
SDJ
16722019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1673 Pedro Alves <palves@redhat.com>
1674
1675 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1676 * target.c (target_stack::push): Call 'unpush' if there's a
1677 target on top of the stack.
1678
2e953aca
PW
16792019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1680
1681 * python/py-block.c (blpy_dealloc): Call tp_free.
1682 (blpy_block_syms_dealloc): Likewise.
1683 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1684 * python/py-inferior.c (infpy_dealloc): Likewise.
1685 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1686 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1687 * python/py-symbol.c (sympy_dealloc): Likewise.
1688 * python/py-symtab.c (stpy_dealloc): Likewise.
1689 * python/py-type.c (typy_iterator_dealloc): Likewise.
1690
6edc43ec
CB
16912019-11-18 Christian Biesinger <cbiesinger@google.com>
1692
1693 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1694 constructor instead of using a class initializer.
1695
cd850b40
CB
16962019-11-15 Christian Biesinger <cbiesinger@google.com>
1697
1698 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1699 * configure: Regenerate.
1700 * configure.ac: Don't source common.host.
1701 * gdbsupport/common.host: Remove.
1702 * gdbsupport/mingw-strerror.c: Remove.
1703 * gdbsupport/posix-strerror.c: Rename to...
1704 * gdbsupport/safe-strerror.c: ...this.
1705
53fea9c7
CB
17062019-11-15 Christian Biesinger <cbiesinger@google.com>
1707
1708 * maint.c (scoped_command_stats::print_time): Use localtime_r
1709 instead of localtime (provided through gnulib if necessary).
1710 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1711 of ctime.
1712
f8e27d88
CB
17132019-11-15 Christian Biesinger <cbiesinger@google.com>
1714
1715 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1716 avoid compile errors.
1717
5abebf3c
CB
17182019-11-15 Christian Biesinger <cbiesinger@google.com>
1719
1720 * config.in: Regenerate.
1721 * configure: Regenerate.
1722 * gdbsupport/common.m4: No longer check for strerror_r.
1723 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1724 POSIX version of strerror_r, now that gnulib provides it if
1725 necessary.
1726
9a351667
CB
17272019-11-14 Christian Biesinger <cbiesinger@google.com>
1728
1729 * README (`configure' options): Update.
1730
55708e99
TT
17312019-11-14 Tom Tromey <tromey@adacore.com>
1732
1733 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1734 expected type for the RHS if the LHS is a convenience variable.
1735
4b09bb2e
SM
17362019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1737
1738 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1739 Provide explicit default and copy constructor.
1740
bd454f8b
PW
17412019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1742
1743 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1744 only call Py_INCREF (newbp) in the bppy_pending_object case.
1745
d1aa3cf0
TT
17462019-11-13 Tom Tromey <tromey@adacore.com>
1747
1748 PR build/25182:
1749 * psympriv.h (partial_symbol): Remove static assert.
1750 * symtab.h (general_symbol_info, symbol): Remove static assert.
1751
e06f3d6e
AB
17522019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1753
1754 * gdbsupport/format.c (format_pieces::format_pieces): Support
1755 printf 'z' size modifier.
1756 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1757 * printcmd.c (ui_printf): Handle size_t_arg.
1758 * ui-out.c (ui_out::vmessage): Likewise.
1759 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1760 function.
1761 (run_tests): Call test_format_int_sizes.
1762
468c0cbb
CB
17632019-11-12 Christian Biesinger <cbiesinger@google.com>
1764
1765 * ada-exp.y (write_ambiguous_var): Update.
1766 * buildsym.c (add_symbol_to_list): Update.
1767 * dwarf2read.c (read_variable): Update.
1768 (new_symbol): Update.
1769 * jit.c (finalize_symtab): Update.
1770 * language.c (language_alloc_type_symbol): Update.
1771 * symtab.c (fixup_symbol_section): Update.
1772 (initialize_objfile_symbol_1): Move code to...
1773 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1774 (allocate_symbol): Update.
1775 (allocate_template_symbol): Update.
1776 (get_symbol_address): Update.
1777 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1778 of having as a field, and add a constructor.
1779 (SYMBOL_VALUE): Update.
1780 (SYMBOL_VALUE_ADDRESS): Update.
1781 (SET_SYMBOL_VALUE_ADDRESS): Update.
1782 (SYMBOL_VALUE_BYTES): Update.
1783 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1784 (SYMBOL_BLOCK_VALUE): Update.
1785 (SYMBOL_VALUE_CHAIN): Update.
1786 (SYMBOL_LANGUAGE): Update.
1787 (SYMBOL_SECTION): Update.
1788 (SYMBOL_OBJ_SECTION): Update.
1789 (SYMBOL_SET_LANGUAGE): Update.
1790 (SYMBOL_SET_LINKAGE_NAME): Update.
1791 (SYMBOL_SET_NAMES): Update.
1792 (SYMBOL_NATURAL_NAME): Update.
1793 (SYMBOL_LINKAGE_NAME): Update.
1794 (SYMBOL_DEMANGLED_NAME): Update.
1795 (SYMBOL_SEARCH_NAME): Update.
1796 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1797 (struct symbol): Update.
1798 (struct template_symbol): Update.
1799 (struct rust_vtable_symbol): Update.
1800 * xcoffread.c (SYMBOL_DUP): Update.
1801
ed2c82c3
TT
18022019-11-12 Tom Tromey <tom@tromey.com>
1803
1804 * tui/tui-layout.c (show_layout): Set current_layout.
1805 (show_source_disasm_command, show_data)
1806 (show_source_or_disasm_and_command): Don't set current_layout.
1807
d9fcefd5
TT
18082019-11-12 Tom Tromey <tom@tromey.com>
1809
1810 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1811
45e42163
TT
18122019-11-12 Tom Tromey <tom@tromey.com>
1813
1814 * tui/tui-win.c (resize_message): New global.
1815 (show_tui_resize_message): New function.
1816 (tui_async_resize_screen): Print message if requested.
1817 (_initialize_tui_win): Add tui-resize-message setting.
1818 * NEWS: Add entry for new commands.
1819
c86d74cc
TT
18202019-11-11 Tom Tromey <tom@tromey.com>
1821
1822 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1823 functions.
1824
7b7b9424
CB
18252019-11-11 Christian Biesinger <cbiesinger@google.com>
1826
1827 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1828
086baaf1
AB
18292019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1830
1831 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1832 function.
1833 * python/python-internal.h (gdbpy_lookup_static_symbols):
1834 Declare new function.
1835 * python/python.c (python_GdbMethods): Add
1836 gdb.lookup_static_symbols method.
1837 * NEWS: Mention gdb.lookup_static_symbols.
1838
09ff83af
AB
18392019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1840
1841 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1842 static block of current object file first. Also fix typo in
1843 header comment.
1844
eb2dd8df
AB
18452019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1846
1847 * stack.c (set_last_displayed_sal): Delete.
1848 (last_displayed_sal_valid): Delete.
1849 (last_displayed_pspace): Delete.
1850 (last_displayed_addr): Delete.
1851 (last_displayed_symtab): Delete.
1852 (last_displayed_line): Delete.
1853 (class last_displayed_symtab_info_type): New.
1854 (last_displayed_symtab_info): New static global variable.
1855 (print_frame_info): Call methods on last_displayed_symtab_info.
1856 (clear_last_displayed_sal): Update header comment, and make use of
1857 last_displayed_symtab_info.
1858 (last_displayed_sal_is_valid): Likewise.
1859 (get_last_displayed_pspace): Likewise.
1860 (get_last_displayed_addr): Likewise.
1861 (get_last_displayed_symtab): Likewise.
1862 (get_last_displayed_line): Likewise.
1863 (get_last_displayed_sal): Likewise.
1864 * stack.h (clear_last_displayed_sal): Update header comment.
1865 (last_displayed_sal_is_valid): Likewise.
1866 (get_last_displayed_pspace): Likewise.
1867 (get_last_displayed_addr): Likewise.
1868 (get_last_displayed_symtab): Likewise.
1869 (get_last_displayed_line): Likewise.
1870 (get_last_displayed_sal): Likewise.
1871
62137775
AB
18722019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1873
1874 * stack.c (frame_show_address): Convert return type to bool.
1875 * stack.h (frame_show_address): Likewise, and update header
1876 comment.
1877
cf57ad6d
AB
18782019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1879
1880 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1881 * unittests/vec-utils-selftests.c: New file.
1882 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1883
0b026263
TT
18842019-11-10 Tom Tromey <tom@tromey.com>
1885
1886 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1887 (tui_highlight_win): Likewise.
1888 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1889 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1890 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1891 Don't set can_highlight.
1892
b049ce2d
TT
18932019-11-10 Tom Tromey <tom@tromey.com>
1894
1895 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1896 Remove unused declaration.
1897
992a7040
TT
18982019-11-08 Tom Tromey <tromey@adacore.com>
1899
1900 * top.c (read_command_file): Update.
1901 (command_line_input): Make return type const.
1902 * python/py-gdb-readline.c: Update.
1903 * linespec.c (decode_line_2): Update.
1904 * defs.h (command_line_input): Make return type const.
1905 * cli/cli-script.c (read_next_line): Make return type const.
1906 * ada-lang.c (get_selections): Update.
1907
ca3a04f6
CB
19082019-11-06 Christian Biesinger <cbiesinger@google.com>
1909
1910 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1911 * mi/mi-main.c (output_cores): Likewise.
1912 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1913 (linux_xfer_osdata_modules): Likewise.
1914 * remote.c (register_remote_support_xml): Likewise.
1915 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1916 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1917
e0eac551
TT
19182019-11-06 Tom Tromey <tom@tromey.com>
1919
1920 * tui/tui-interp.c: Don't include readline.h.
1921 * tui/tui-hooks.c: Don't include readline.h.
1922 * symmisc.c: Include tilde.h, not readline.h.
1923 * symfile.c: Include tilde.h, not readline.h.
1924 * source.c: Include tilde.h, not readline.h.
1925 * solib.c: Include tilde.h, not readline.h.
1926 * psymtab.c: Include tilde.h, not readline.h.
1927 * exec.c: Include tilde.h, not readline.h.
1928 * corelow.c: Include tilde.h, not readline.h.
1929 * cli/cli-dump.c: Include tilde.h, not readline.h.
1930 * cli/cli-cmds.c: Don't include readline.h.
1931
825165c5
TT
19322019-11-05 Tom Tromey <tom@tromey.com>
1933
1934 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1935 (tui_disassemble): Set addr_size.
1936 (tui_disasm_window::set_contents): Use addr_size.
1937
91ae903f
TT
19382019-11-05 Tom Tromey <tom@tromey.com>
1939
1940 * rust-lang.c (rust_language_defn): Update.
1941 * python/py-value.c (valpy_string): Call c_get_string.
1942 * p-lang.c (pascal_language_defn): Update.
1943 * opencl-lang.c (opencl_language_defn): Update.
1944 * objc-lang.c (objc_language_defn): Update.
1945 * m2-lang.c (m2_language_defn): Update.
1946 * language.c (unknown_language_defn, auto_language_defn): Update.
1947 (default_get_string): Remove.
1948 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1949 * go-lang.c (go_language_defn): Update.
1950 * f-lang.c (f_language_defn): Update.
1951 * d-lang.c (d_language_defn): Update.
1952 * c-lang.c (c_language_defn, cplus_language_defn)
1953 (asm_language_defn, minimal_language_defn): Update.
1954 * ada-lang.c (ada_language_defn): Update.
1955 * language.h (struct language_defn) <la_get_string>: Remove.
1956 (LA_GET_STRING): Remove.
1957 (default_get_string): Don't declare.
1958
1df2f9ef
TT
19592019-11-05 Tom Tromey <tom@tromey.com>
1960
1961 * tui/tui-source.h (struct tui_source_window): Inline
1962 constructor. Remove destructor.
1963 <style_changed, m_observable>: Move to superclass.
1964 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1965 (struct tui_source_window_base): Move private members to end.
1966 <style_changed, m_observable>: Move from tui_source_window.
1967 * tui/tui-winsource.c (tui_copy_source_line): Move from
1968 tui-source.c. Rename from copy_source_line. Add special handling
1969 for negative line number.
1970 (tui_source_window_base::style_changed): Move from
1971 tui_source_window.
1972 (tui_source_window_base): Register observer.
1973 (~tui_source_window_base): New.
1974 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1975 rename.
1976 (tui_source_window::set_contents): Use tui_copy_source_line.
1977 (tui_source_window::tui_source_window): Move to tui-source.h.
1978 (tui_source_window::~tui_source_window): Remove.
1979 (tui_source_window::style_changed): Move to superclass.
1980 * tui/tui-disasm.c (tui_disassemble): Create string file with
1981 styling, when possible. Add "addr_size" parameter.
1982 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1983 Don't compute maximum size.
1984 (len_without_escapes): New function
1985
5d051055
TT
19862019-11-05 Tom Tromey <tom@tromey.com>
1987
1988 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1989 std::string.
1990 * tui/tui-winsource.c (tui_show_source_line): Update.
1991 * tui/tui-source.c (tui_source_window::set_contents): Update.
1992 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1993
ade7beea
CB
19942019-11-05 Christian Biesinger <cbiesinger@google.com>
1995
1996 * symtab.h (gdb_static_assert): Put && operator at the beginning
1997 of the line instead of the end.
1998
3573abe1
CB
19992019-11-04 Christian Biesinger <cbiesinger@google.com>
2000
2001 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2002 and sizeof (symbol).
2003 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2004
dae8b3eb
RO
20052019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2006
2007 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2008 * configure.host: Mark *-*-solaris2.10* obsolete.
2009 * configure.tgt: Mark Solaris < 11 obsolete.
2010 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2011 Update target triplet.
2012
5df96a4e
TT
20132019-11-01 Tom Tromey <tromey@adacore.com>
2014
2015 * utils.c (print_sys_errmsg): Simplify.
2016
b7481649
TT
20172019-11-01 Tom Tromey <tromey@adacore.com>
2018
2019 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2020
e48f6033
CB
20212019-11-01 Christian Biesinger <cbiesinger@google.com>
2022
2023 * configure: Regenerate.
2024 * configure.ac: Remove check for strerror_r.
2025 * gdbsupport/common.m4: Check for strerror_r.
2026
bd5766ec
LM
20272019-11-01 Luis Machado <luis.machado@linaro.org>
2028
2029 PR gdb/25124
2030
2031 * arm-tdep.c (arm_per_objfile): Rename to ...
2032 (arm_per_bfd): ... this.
2033 (arm_objfile_data_key): Rename to ...
2034 (arm_bfd_data_key): ... this.
2035 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2036 data.
2037 (arm_record_special_symbol): Likewise.
2038
e1709896
AB
20392019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2040
2041 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2042 end.
2043 * c-typeprint.c (c_print_typedef): Likewise.
2044 * f-typeprint.c (f_print_typedef): Likewise.
2045 * m2-typeprint.c (m2_print_typedef): Likewise.
2046 * p-typeprint.c (pascal_print_typedef): Likewise.
2047 * rust-lang.c (rust_print_typedef): Likewise.
2048 * symtab.c (print_symbol_info): Print a newline after calling
2049 typedef_print.
2050
165f8965
AB
20512019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2052
2053 * symtab.c (info_module_cmdlist): New variable.
2054 (info_module_command): New function.
2055 (search_module_symbols): New function.
2056 (info_module_subcommand): New function.
2057 (struct info_modules_var_func_options): New struct.
2058 (info_modules_var_func_options_defs): New variable.
2059 (make_info_modules_var_func_options_def_group): New function.
2060 (info_module_functions_command): New function.
2061 (info_module_variables_command): New function.
2062 (info_module_var_func_command_completer): New function.
2063 (_initialize_symtab): Register new 'info module functions' and
2064 'info module variables' commands.
2065 * symtab.h (typedef symbol_search_in_module): New typedef.
2066 (search_module_symbols): Declare new function.
2067 * NEWS: Mention new commands.
2068
59c35742
AB
20692019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2070
2071 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2072 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2073 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2074 MODULES_DOMAIN.
2075 (scan_partial_symbols): Only create partial module symbols for non
2076 declarations.
2077 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2078 and MODULES_DOMAIN.
2079 * symtab.c (search_domain_name): Likewise.
2080 (search_symbols): Likewise.
2081 (print_symbol_info): Likewise.
2082 (symtab_symbol_info): Likewise.
2083 (info_modules_command): New function.
2084 (_initialize_symtab): Register 'info modules' command.
2085 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2086 * NEWS: Mention new 'info modules' command.
2087
aed61d02
PW
20882019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2089
2090 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2091 and $_gdb_maint_setting_str.
2092
9ad9b77d
PW
20932019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2094
2095 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2096 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2097 (str_value_from_setting, gdb_setting_str_internal_fn)
2098 (gdb_maint_setting_str_internal_fn): New functions.
2099 (_initialize_cli_cmds): Define the new convenience functions.
2100 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2101 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2102
8d6efaa2
CB
21032019-10-31 Christian Biesinger <cbiesinger@google.com>
2104
2105 * agent.c (set_can_use_agent): When the setting is turned on,
2106 look up agent symbols if we don't have them yet.
2107 (agent_new_objfile): Don't look up agent symbols when the agent
2108 setting is off.
2109
33cb1647
CB
21102019-10-31 Christian Biesinger <cbiesinger@google.com>
2111
2112 * config.in: Regenerate.
2113
b231e86a
CB
21142019-10-31 Christian Biesinger <cbiesinger@google.com>
2115
2116 * configure: Regenerate.
2117 * configure.ac: Check for strerror_r.
2118 * gdbsupport/common-utils.h (safe_strerror): Change return value
2119 to const char * and document that this function is now threadsafe.
2120 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2121 thread_local and call strerror_r, if available.
2122 * utils.c (perror_string): Update.
2123 (print_sys_errmsg): Update.
2124
a2726d4f
LM
21252019-10-31 Luis Machado <luis.machado@linaro.org>
2126
2127 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2128 objfile_key.
2129 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2130 objfile to fetch per-bfd data.
2131 (arm_find_exidx_entry): Likewise.
2132
75cafaa6
CB
21332019-10-31 Christian Biesinger <cbiesinger@google.com>
2134
2135 * gdbsupport/agent.c (debug_agent): Change type to bool.
2136 (use_agent): Likewise.
2137 (all_agent_symbols_look_up): Likewise.
2138 (agent_loaded_p): Change return value to bool.
2139 (agent_look_up_symbols): Update.
2140 (agent_capability_check): Change return value to bool.
2141 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2142 (debug_agent): Change type to bool.
2143 (use_agent): Likewise.
2144 (agent_capability_check): Change return value to bool.
2145
808590ec
CB
21462019-10-30 Christian Biesinger <cbiesinger@google.com>
2147
2148 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2149 (build_minimal_symbol_hash_tables): Code to clear the table moved
2150 to clear_minimal_symbol_hash_tables.
2151 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2152 when needed.
2153
f18ad8a1
SM
21542019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2155
2156 * infcmd.c: Remove includes.
2157 * infrun.c: Remove includes.
2158
de93309a
SM
21592019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2160
2161 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2162 (grow_vect): Remove declaration.
2163 (ada_type_of_array): Remove declaration.
2164 (ada_update_initial_language): Remove declaration.
2165 (ada_fold_name): Remove declaration.
2166 (ada_fill_in_ada_prototype): Remove declaration.
2167 (user_select_syms): Remove declaration.
2168 (get_selections): Remove declaration.
2169 (ada_tag_type): Remove declaration.
2170 (ada_value_tag): Remove declaration.
2171 (ada_is_others_clause): Remove declaration.
2172 (ada_in_variant): Remove declaration.
2173 (ada_value_struct_elt): Remove declaration.
2174 (ada_attribute_name): Remove declaration.
2175 (ada_system_address_type): Remove declaration.
2176 * ada-lang.c (ada_watch_location_expression): Make static.
2177 (GROW_VECT): Move here from ada-lang.h.
2178 (grow_vect): Make static.
2179 (ada_update_initial_language): Make static.
2180 (ada_fold_name): Make static.
2181 (ada_type_of_array): Make static.
2182 (encoded_ordered_before): Move up.
2183 (sort_choices): Move up.
2184 (print_signatures): Move up.
2185 (ada_print_symbol_signature): Move up.
2186 (get_selections): Move up and make static.
2187 (user_select_syms): Move up and make static.
2188 (ada_value_struct_elt): Move up and make static.
2189 (ada_tag_type): Make static.
2190 (ada_value_tag): Make static.
2191 (ada_is_others_clause): Make static.
2192 (ada_in_variant): Make static.
2193 (ada_attribute_name): Make static.
2194
cdc46a9f
SM
21952019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2196
2197 * ada-lang.c: Remove includes.
2198 * ada-typeprint.c: Remove includes.
2199 * ada-valprint.c: Remove includes.
2200
90421c56
SM
22012019-10-29 Simon Marchi <simon.marchi@efficios.com>
2202
2203 * addrmap.c: Add static assertions of type size, moved from
2204 _initialize_addrmap.
2205 (_initialize_addrmap): Remove.
2206
31edb802
CB
22072019-10-29 Christian Biesinger <cbiesinger@google.com>
2208
2209 * coffread.c (record_minimal_symbol): Update.
2210 (process_coff_symbol): Update.
2211 * dbxread.c (read_dbx_symtab): Update.
2212 * dwarf2read.c (add_partial_symbol): Update.
2213 (fixup_go_packaging): Update.
2214 (load_partial_dies): Update.
2215 (new_symbol): Update.
2216 * elfread.c (record_minimal_symbol): Change signature to use
2217 gdb::string_view instead of name+len.
2218 (elf_symtab_read): Update.
2219 (elf_rel_plt_read): Update.
2220 * mdebugread.c (parse_partial_symbols): Update.
2221 (handle_psymbol_enumerators): Update.
2222 (new_symbol): Update.
2223 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2224 to use gdb::string_view instead of name+len.
2225 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2226 * psympriv.h (add_psymbol_to_list): Likewise.
2227 * psymtab.c (add_psymbol_to_bcache): Likewise.
2228 (add_psymbol_to_list): Likewise.
2229 * stabsread.c (define_symbol): Update.
2230 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2231 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2232 (symbol_set_names): Likewise.
2233 * xcoffread.c (scan_xcoff_symtab): Update.
2234
0c921b21
CB
22352019-10-29 Christian Biesinger <cbiesinger@google.com>
2236
2237 * symtab.h (symbol_set_names): Document that copy_name must be
2238 set to true for non-nullterminated strings.
2239 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2240 linkage_name if the entry was not found and we need to demangle.
2241
35e65c49
CB
22422019-10-29 Christian Biesinger <cbiesinger@google.com>
2243
2244 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2245 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2246 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2247 * gdbsupport/gdb_binary_search.h: New file.
2248
ed2a2229
CB
22492019-10-29 Christian Biesinger <cbiesinger@google.com>
2250
2251 * NEWS: Mention new --with-system-gdbinit-dir option.
2252 * config.in: Regenerate.
2253 * configure: Regenerate.
2254 * configure.ac: Add new option --with-system-gdbinit-dir.
2255 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2256 for a ".gdb" suffix.
2257 * main.c (get_init_files): Change system_gdbinit argument to
2258 a vector and return the files in SYSTEM_GDBINIT_DIR in
2259 addition to SYSTEM_GDBINIT.
2260 (captured_main_1): Update.
2261 (print_gdb_help): Update.
2262 * top.c (print_gdb_configuration): Also print the value of
2263 SYSTEM_GDBINIT_DIR.
2264
87f34879
CB
22652019-10-28 Christian Biesinger <cbiesinger@google.com>
2266
2267 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2268 that takes gdb::string_view arguments.
2269
30baf67b
TV
22702019-10-26 Tom de Vries <tdevries@suse.de>
2271
2272 * aarch64-linux-tdep.c: Fix typos in comments.
2273 * aarch64-tdep.c: Same.
2274 * ada-lang.c: Same.
2275 * amd64-nat.c: Same.
2276 * arc-tdep.c: Same.
2277 * arch/aarch64-insn.c: Same.
2278 * block.c: Same.
2279 * breakpoint.h: Same.
2280 * btrace.h: Same.
2281 * c-varobj.c: Same.
2282 * cli/cli-decode.c: Same.
2283 * cli/cli-script.c: Same.
2284 * cli/cli-utils.h: Same.
2285 * coff-pe-read.c: Same.
2286 * coffread.c: Same.
2287 * compile/compile-cplus-symbols.c: Same.
2288 * compile/compile-object-run.c: Same.
2289 * completer.c: Same.
2290 * corelow.c: Same.
2291 * cp-support.c: Same.
2292 * demangle.c: Same.
2293 * dwarf-index-write.c: Same.
2294 * dwarf2-frame.c: Same.
2295 * dwarf2-frame.h: Same.
2296 * eval.c: Same.
2297 * frame-base.h: Same.
2298 * frame.h: Same.
2299 * gdbcmd.h: Same.
2300 * gdbtypes.h: Same.
2301 * gnu-nat.c: Same.
2302 * guile/scm-objfile.c: Same.
2303 * i386-tdep.c: Same.
2304 * i386-tdep.h: Same.
2305 * infcall.c: Same.
2306 * infcall.h: Same.
2307 * linux-nat.c: Same.
2308 * m68k-tdep.c: Same.
2309 * macroexp.c: Same.
2310 * memattr.c: Same.
2311 * mi/mi-cmd-disas.c: Same.
2312 * mi/mi-getopt.h: Same.
2313 * mi/mi-main.c: Same.
2314 * minsyms.c: Same.
2315 * nat/aarch64-sve-linux-sigcontext.h: Same.
2316 * objfiles.h: Same.
2317 * ppc-linux-nat.c: Same.
2318 * ppc-linux-tdep.c: Same.
2319 * ppc-tdep.h: Same.
2320 * progspace.h: Same.
2321 * prologue-value.h: Same.
2322 * python/py-evtregistry.c: Same.
2323 * python/py-instruction.h: Same.
2324 * record-btrace.c: Same.
2325 * record-full.c: Same.
2326 * remote.c: Same.
2327 * rs6000-tdep.c: Same.
2328 * ser-tcp.c: Same.
2329 * sol-thread.c: Same.
2330 * sparc-sol2-tdep.c: Same.
2331 * sparc64-tdep.c: Same.
2332 * stabsread.c: Same.
2333 * symfile.c: Same.
2334 * symtab.h: Same.
2335 * target.c: Same.
2336 * tracepoint.c: Same.
2337 * tui/tui-data.h: Same.
2338 * tui/tui-io.c: Same.
2339 * tui/tui-win.c: Same.
2340 * tui/tui.c: Same.
2341 * unittests/rsp-low-selftests.c: Same.
2342 * user-regs.h: Same.
2343 * utils.c: Same.
2344 * utils.h: Same.
2345 * valarith.c: Same.
2346 * valops.c: Same.
2347 * valprint.c: Same.
2348 * valprint.h: Same.
2349 * value.c: Same.
2350 * value.h: Same.
2351 * varobj.c: Same.
2352 * x86-nat.h: Same.
2353 * xtensa-tdep.c: Same.
2354
1834d45f
AT
23552019-10-25 Ali Tamur <tamur@google.com>
2356
2357 * charset.c (find_charset_names): Reflect API change.
2358
5396ae17
CB
23592019-10-25 Christian Biesinger <cbiesinger@google.com>
2360
2361 * symtab.c (struct demangled_name_entry): Change demangled name
2362 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2363 part of the struct anymore.
2364 (symbol_set_names): No longer obstack allocate + copy the demangled
2365 name, just store the allocated name from bfd.
2366
93878f47
TT
23672019-10-25 Tom Tromey <tromey@adacore.com>
2368
2369 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2370 (bsearch_cie_cmp, add_cie): Remove.
2371 (find_cie): Reimplement.
2372 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2373 (dwarf2_build_frame_info): Update.
2374
7b71fc97
L
23752019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2376
2377 PR gdb/25126
2378 * symfile.c (reread_symbols): Call forget_cached_source_info to
2379 clear the stale source cache.
2380
cbb5a2ea
CB
23812019-10-24 Christian Biesinger <cbiesinger@google.com>
2382
2383 * configure: Regenerate.
2384 * configure.ac: Remove code that sets python_has_threads.
2385
71737c43
CB
23862019-10-24 Christian Biesinger <cbiesinger@google.com>
2387
2388 * config.in: Regenerate.
2389 * configure: Regenerate.
2390 * configure.ac: Remove the code that uses sed to get the python
2391 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2392
33d569b7
AB
23932019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2394
2395 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2396 error paths.
2397
f16f7b7c
TT
23982019-10-23 Tom Tromey <tom@tromey.com>
2399
2400 * arc-tdep.c: Remove ".." from include.
2401 * frv-tdep.c: Remove ".." from include.
2402 * lm32-tdep.c: Remove ".." from include.
2403 * microblaze-tdep.c: Remove ".." from include.
2404 * or1k-tdep.h: Remove ".." from include.
2405 * s12z-tdep.c: Remove ".." from include.
2406 * Makefile.in (OPCODES_CFLAGS): Add comment.
2407 (TOP_CFLAGS): New variable.
2408 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2409
6999161a
TT
24102019-10-23 Tom Tromey <tom@tromey.com>
2411
2412 * Makefile.in (READLINE_DIR): Update.
2413
12e7c35e
TBA
24142019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2415
2416 * infcall.c (call_function_by_hand_dummy): Fix the function
2417 comment. And extract out a code section into...
2418 (reserve_stack_space): ...this new function.
2419
37055cad
TBA
24202019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2421
2422 * infcall.c (value_arg_coerce): Remove an unused parameter.
2423 (call_function_by_hand_dummy): Update the call to
2424 'value_arg_coerce'.
2425
39bcc47c
TBA
24262019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2427
2428 * infcall.c (call_function_by_hand_dummy): Refactor.
2429
bd888c0f
TBA
24302019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2431
2432 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2433
c12d372d
TT
24342019-10-23 Tom Tromey <tom@tromey.com>
2435
2436 * configure: Rebuild.
2437 * configure.ac: Don't check for sigprocmask.
2438 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2439
4d0b984b
TT
24402019-10-23 Tom Tromey <tom@tromey.com>
2441
2442 * configure: Rebuild.
2443 * acinclude.m4: Use m4_include, not sinclude.
2444
7e785608
TV
24452019-10-23 Tom de Vries <tdevries@suse.de>
2446
2447 PR breakpoints/24687
2448 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2449
403772ef
CB
24502019-10-22 Christian Biesinger <cbiesinger@google.com>
2451
2452 * symtab.c (struct demangled_name_entry) <language>: Change from
2453 bitfield to regular variable.
2454
3a494279
CB
24552019-10-22 Christian Biesinger <cbiesinger@google.com>
2456
2457 * symtab.c (struct demangled_name_entry): Add a constructor.
2458 (free_demangled_name_entry): New function to call the destructor
2459 for demangled_name_entry.
2460 (create_demangled_names_hash): Pass free_demangled_name_entry to
2461 htab_create_alloc.
2462 (symbol_set_names): Call placement new for demangled_name_entry.
2463 * utils.c: No longer include xxhash.h here, now that fast_hash
2464 is inlined in the header.
2465 * utils.h: Instead, include it here.
2466
ccb1ba62
CB
24672019-10-22 Christian Biesinger <cbiesinger@google.com>
2468
2469 * Makefile.in: Link with libxxhash.
2470 * config.in: Regenerate.
2471 * configure: Regenerate.
2472 * configure.ac: Search for libxxhash.
2473 * utils.c (fast_hash): Use xxhash if present.
2474
1a6ff1a9
CB
24752019-10-22 Christian Biesinger <cbiesinger@google.com>
2476
2477 * utils.h (fast_hash): New function.
2478 * symtab.c (hash_demangled_name_entry): Call new function
2479 fast_hash.
2480
7bb43059
CB
24812019-10-22 Christian Biesinger <cbiesinger@google.com>
2482
2483 * symtab.c (struct demangled_name_entry): Change type of mangled
2484 to gdb::string_view. Also adds a constructor that takes the
2485 mangled name.
2486 (hash_demangled_name_entry): Update.
2487 (eq_demangled_name_entry): Update.
2488 (free_demangled_name_entry): New function to call the destructor
2489 now that this is not a POD anymore.
2490 (create_demangled_names_hash): Pass free_demangled_name_entry to
2491 htab_create_alloc.
2492 (symbol_set_names): Update.
2493
7ba99d21
AT
24942019-10-21 Ali Tamur <tamu@google.com>
2495
2496 * dwarf2read.c (dir_index): Change type.
2497 (file_name_index): Likewise.
2498 (line_header::include_dir_at): Change comment and implementation on
2499 whether it is DWARF 5.
2500 (line_header::is_valid_file_index): New function.
2501 (line_header::file_name_at): Change comment and implementation on
2502 whether it is DWARF 5.
2503 (line_header::file_names): Change to private field renamed as
2504 m_file_names and introduce a new accessor method.
2505 (line_header::file_names_size): New method.
2506 (line_header::include_dirs): Change to private field and rename as
2507 m_include_dirs.
2508 (dw2_get_file_names_reader): Define local var at a smaller scope and
2509 reflect API change.
2510 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2511 (process_structure_scope): Likewise.
2512 (line_header::add_include_dir): Change message and reflect renaming.
2513 (line_header::add_file_name): Likewise.
2514 (read_formatted_entries): Handle DW_FORM_data16.
2515 (dwarf_decode_line_header): Fix line header length calculation.
2516 (psymtab_include_file_name): Change comment and API.
2517 (lnp_state_machine::m_file): Update comment and reflect type change.
2518 (lnp_state_machine::record_line): Reflect type change.
2519 (dwarf_decode_lines): Reflect API change.
2520 (file_file_name): Likewise.
2521 (file_full_name): Likewise.
2522
45f47c3a
AB
25232019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2524
2525 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2526
e5f3c0e3
TT
25272019-10-21 Tom Tromey <tom@tromey.com>
2528
2529 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2530
a0a461e5
TT
25312019-10-21 Tom Tromey <tom@tromey.com>
2532
2533 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2534 NM_H. Use AC_CONFIG_LINKS.
2535 * configure: Rebuild.
2536 * Makefile.in (NM_H): New variable.
2537 (generated_files): Add NM_H. Remove gcore.
2538 (nm.h, stamp-nmh): New targets.
2539
54d83b8d
TT
25402019-10-20 Tom Tromey <tom@tromey.com>
2541
2542 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2543 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2544 obsolete comment.
2545 (put_objfile_before): Now static.
2546
23771117
SM
25472019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2548
2549 * gdbsupport/common-utils.h (startswith): Change return type to
2550 bool.
2551
39ef2f62
CB
25522019-10-19 Christian Biesinger <cbiesinger@google.com>
2553
2554 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2555 * breakpoint.c (bp_locations_compare): Rename to...
2556 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2557 (update_global_location_list): Use std::sort instead of qsort.
2558 * buildsym.c (compare_line_numbers): Rename to...
2559 (lte_is_less_than): ...this, and change to std::sort semantics.
2560 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2561 instead of qsort.
2562 * disasm.c (compare_lines): Rename to...
2563 (line_is_less_than): ...this, and change to std::sort semantics.
2564 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2565 of qsort.
2566 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2567 (fde_is_less_than): ...this, and change to std::sort semantics.
2568 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2569 * mdebugread.c (compare_blocks):
2570 (block_is_less_than): ...this, and change to std::sort semantics.
2571 (sort_blocks): Call std::sort instead of qsort.
2572 * objfiles.c (qsort_cmp): Rename to...
2573 (sort_cmp): ...this, and change to std::sort semantics.
2574 (update_section_map): Call std::sort instead of qsort.
2575 * remote.c (compare_pnums): Remove.
2576 (map_regcache_remote_table): Call std::sort instead of qsort.
2577 * utils.c (compare_positive_ints): Remove.
2578 * utils.h (compare_positive_ints): Remove.
2579 * xcoffread.c (compare_lte): Remove.
2580 (arrange_linetable): Call std::sort instead of qsort.
2581
f71433ee
SDJ
25822019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2583
2584 * symfile.c (init_entry_point_info): Fix typo.
2585 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2586
85102364
TV
25872019-10-18 Tom de Vries <tdevries@suse.de>
2588
2589 * aarch64-tdep.c: Fix typos in comments.
2590 * ada-lang.c: Same.
2591 * ada-tasks.c: Same.
2592 * alpha-tdep.c: Same.
2593 * alpha-tdep.h: Same.
2594 * amd64-nat.c: Same.
2595 * amd64-windows-tdep.c: Same.
2596 * arc-tdep.c: Same.
2597 * arc-tdep.h: Same.
2598 * arch-utils.c: Same.
2599 * arm-nbsd-tdep.c: Same.
2600 * arm-tdep.c: Same.
2601 * ax-gdb.c: Same.
2602 * blockframe.c: Same.
2603 * btrace.c: Same.
2604 * c-varobj.c: Same.
2605 * coff-pe-read.c: Same.
2606 * coffread.c: Same.
2607 * cris-tdep.c: Same.
2608 * darwin-nat.c: Same.
2609 * dbxread.c: Same.
2610 * dcache.c: Same.
2611 * disasm.c: Same.
2612 * dtrace-probe.c: Same.
2613 * dwarf-index-write.c: Same.
2614 * dwarf2-frame-tailcall.c: Same.
2615 * dwarf2-frame.c: Same.
2616 * dwarf2read.c: Same.
2617 * eval.c: Same.
2618 * exceptions.c: Same.
2619 * fbsd-tdep.c: Same.
2620 * findvar.c: Same.
2621 * frame.c: Same.
2622 * frv-tdep.c: Same.
2623 * gnu-v3-abi.c: Same.
2624 * go32-nat.c: Same.
2625 * h8300-tdep.c: Same.
2626 * hppa-tdep.c: Same.
2627 * i386-linux-tdep.c: Same.
2628 * i386-tdep.c: Same.
2629 * ia64-libunwind-tdep.c: Same.
2630 * ia64-tdep.c: Same.
2631 * infcmd.c: Same.
2632 * infrun.c: Same.
2633 * linespec.c: Same.
2634 * linux-nat.c: Same.
2635 * linux-thread-db.c: Same.
2636 * machoread.c: Same.
2637 * mdebugread.c: Same.
2638 * mep-tdep.c: Same.
2639 * mn10300-tdep.c: Same.
2640 * namespace.c: Same.
2641 * objfiles.c: Same.
2642 * opencl-lang.c: Same.
2643 * or1k-tdep.c: Same.
2644 * osabi.c: Same.
2645 * ppc-linux-nat.c: Same.
2646 * ppc-linux-tdep.c: Same.
2647 * ppc-sysv-tdep.c: Same.
2648 * printcmd.c: Same.
2649 * procfs.c: Same.
2650 * record-btrace.c: Same.
2651 * record-full.c: Same.
2652 * remote-fileio.c: Same.
2653 * remote.c: Same.
2654 * rs6000-tdep.c: Same.
2655 * s12z-tdep.c: Same.
2656 * score-tdep.c: Same.
2657 * ser-base.c: Same.
2658 * ser-go32.c: Same.
2659 * skip.c: Same.
2660 * sol-thread.c: Same.
2661 * solib-svr4.c: Same.
2662 * solib.c: Same.
2663 * source.c: Same.
2664 * sparc-nat.c: Same.
2665 * sparc-sol2-tdep.c: Same.
2666 * sparc-tdep.c: Same.
2667 * sparc64-tdep.c: Same.
2668 * stabsread.c: Same.
2669 * stack.c: Same.
2670 * symfile.c: Same.
2671 * symtab.c: Same.
2672 * target-descriptions.c: Same.
2673 * target-float.c: Same.
2674 * thread.c: Same.
2675 * utils.c: Same.
2676 * valops.c: Same.
2677 * valprint.c: Same.
2678 * value.c: Same.
2679 * varobj.c: Same.
2680 * windows-nat.c: Same.
2681 * xcoffread.c: Same.
2682 * xstormy16-tdep.c: Same.
2683 * xtensa-tdep.c: Same.
2684
c5adaa19
TT
26852019-10-17 Tom Tromey <tromey@adacore.com>
2686
2687 * configure: Rebuild.
2688 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2689 in AC_CONFIG_FILES invocation.
2690 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2691 new-style config.status invocation.
2692
405feb71
TV
26932019-10-17 Tom de Vries <tdevries@suse.de>
2694
2695 * arm-nbsd-nat.c: Fix typos in comments.
2696 * arm-tdep.c: Same.
2697 * darwin-nat-info.c: Same.
2698 * dwarf2read.c: Same.
2699 * elfread.c: Same.
2700 * event-top.c: Same.
2701 * findvar.c: Same.
2702 * gdbtypes.c: Same.
2703 * hppa-tdep.c: Same.
2704 * i386-tdep.c: Same.
2705 * jit.c: Same.
2706 * main.c: Same.
2707 * mdebugread.c: Same.
2708 * moxie-tdep.c: Same.
2709 * nto-procfs.c: Same.
2710 * osabi.c: Same.
2711 * ppc-linux-tdep.c: Same.
2712 * remote.c: Same.
2713 * riscv-tdep.c: Same.
2714 * s390-tdep.c: Same.
2715 * sh-tdep.c: Same.
2716 * sparc-linux-tdep.c: Same.
2717 * sparc-nat.c: Same.
2718 * stack.c: Same.
2719 * target-descriptions.c: Same.
2720 * top.c: Same.
2721 * varobj.c: Same.
2722
befcd486
TT
27232019-10-16 Tom Tromey <tom@tromey.com>
2724
2725 * objfiles.h (struct objfile) <original_name>: Now const.
2726
17bfe554
CB
27272019-10-16 Christian Biesinger <cbiesinger@google.com>
2728
2729 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2730 pass on to sigsetjmp's second argument.
2731 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2732
950b7495
KS
27332019-10-16 Keith Seitz <keiths@redhat.com>
2734
2735 PR gdb/23567
2736 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2737 sections whose size is greater than the file size.
2738
ff371ec9
JW
27392019-10-16 Jim Wilson <jimw@sifive.com>
2740
2741 * riscv-tdep.c (riscv_gcc_target_options): New.
2742 (riscv_gnu_triplet_regexp): New.
2743 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2744 set_gdbarch_gnu_triplet_regexp.
2745
fec4e896
CB
27462019-10-16 Christian Biesinger <cbiesinger@google.com>
2747
2748 * Makefile.in: Add xml-builtin.h.
2749 * features/feature_to_c.sh: Add an include for xml-builtin.h
2750 to ensure that the compiler checks that the types match.
2751 * xml-builtin.h: New file.
2752 * xml-support.c (fetch_xml_builtin): Add missing const.
2753 * xml-support.h: Remove declaration of xml_builtins.
2754
d10eccaa
TV
27552019-10-16 Tom de Vries <tdevries@suse.de>
2756
2757 PR tdep/25096
2758 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2759 (amd64_classify_aggregate): ... here.
2760 (amd64_classify_aggregate_field): Handled fiels of nested structs
2761 recursively.
2762
745ff14e
TV
27632019-10-16 Tom de Vries <tdevries@suse.de>
2764
2765 PR tdep/24104
2766 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2767 that handles 'theclass'.
2768
791b7405
AB
27692019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2770
2771 * linespec.c (decode_digits_ordinary): Update comment.
2772 * make-target-delegates: No longer need to handle VEC case.
2773 * memrange.c (normalize_mem_ranges): Update comment.
2774 * namespace.c (add_using_directive): Update comment.
2775 * objc-lang.c (uniquify_strings): Update comment.
2776 * ppc-linux-nat.c (struct thread_points): Update comment.
2777 * probe.h (find_probes_in_objfile): Update comment.
2778 * target.h (enum flash_preserve_mode): Update comment.
2779 * varobj.c (varobj_restrict_range): Update comment.
2780 * varobj.h (varobj_list_children): Update comment.
2781
0dc32745
AB
27822019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2783
2784 * Makefile.in: Remove references to vec.h and vec.c.
2785 * aarch64-tdep.c: No longer include vec.h.
2786 * ada-lang.c: Likewise.
2787 * ada-lang.h: Likewise.
2788 * arm-tdep.c: Likewise.
2789 * ax.h: Likewise.
2790 * breakpoint.h: Likewise.
2791 * charset.c: Likewise.
2792 * cp-support.h: Likewise.
2793 * dtrace-probe.c: Likewise.
2794 * dwarf2read.c: Likewise.
2795 * extension.h: Likewise.
2796 * gdb_bfd.c: Likewise.
2797 * gdbsupport/gdb_vecs.h: Likewise.
2798 * gdbsupport/vec.c: Remove.
2799 * gdbsupport/vec.h: Remove.
2800 * gdbthread.h: Likewise.
2801 * guile/scm-type.c: Likewise.
2802 * inline-frame.c: Likewise.
2803 * machoread.c: Likewise.
2804 * memattr.c: Likewise.
2805 * memrange.h: Likewise.
2806 * namespace.h: Likewise.
2807 * nat/linux-btrace.h: Likewise.
2808 * osdata.c: Likewise.
2809 * parser-defs.h: Likewise.
2810 * progspace.h: Likewise.
2811 * python/py-type.c: Likewise.
2812 * record-btrace.c: Likewise.
2813 * rust-exp.y: Likewise.
2814 * solib-target.c: Likewise.
2815 * stap-probe.c: Likewise.
2816 * target-descriptions.c: Likewise.
2817 * target-memory.c: Likewise.
2818 * target.h: Likewise.
2819 * varobj.c: Likewise.
2820 * varobj.h: Likewise.
2821 * xml-support.h: Likewise.
2822
ae640021
AB
28232019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2824
2825 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2826 Update for new std::vector based implementation.
2827 (process_psymtab_comp_unit_reader): Likewise.
2828 (scan_partial_symbols): Likewise.
2829 (recursively_compute_inclusions): Likewise.
2830 (compute_compunit_symtab_includes): Likewise.
2831 (process_imported_unit_die): Likewise.
2832 (queue_and_load_dwo_tu): Likewise.
2833 (follow_die_sig_1): Likewise.
2834 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2835 (typedef dwarf2_per_cu_ptr): Remove.
2836 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2837 function.
2838 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2839 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2840 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2841 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2842 std::vector.
2843
55dfc88f
TT
28442019-10-15 Tom Tromey <tromey@adacore.com>
2845
2846 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2847 TID.
2848
96b49c5e
TT
28492019-10-15 Tom Tromey <tromey@adacore.com>
2850
2851 * windows-nat.c (windows_nat_target::fetch_registers)
2852 (windows_nat_target::store_registers): Rename "pid" to "tid".
2853
953cff56
TT
28542019-10-15 Tom Tromey <tromey@adacore.com>
2855
2856 * gdbarch.h, gdbarch.c: Rebuild.
2857 * gdbarch.sh (gcc_target_options): Change return type to
2858 std::string.
2859 * compile/compile.c (get_args): Update.
2860 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2861 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2862 std::string.
2863 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2864 std::string.
2865 * arch-utils.c (default_gcc_target_options): Return std::string.
2866 * arch-utils.h (default_gcc_target_options): Return std::string.
2867 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2868
81e6b8eb
CB
28692019-10-15 Christian Biesinger <cbiesinger@google.com>
2870
2871 * breakpoint.c (breakpoint_chain): Make static.
2872 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2873 of accessing breakpoint_chain.
2874
95da600f
CB
28752019-10-15 Christian Biesinger <cbiesinger@google.com>
2876
2877 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2878 to a gdb::function_view and return value to bool.
2879 * breakpoint.h (iterate_over_breakpoints): Likewise.
2880 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2881 (pop_dummy_frame): Update.
2882 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2883 (gdbscm_breakpoints): Update.
2884 * python/py-breakpoint.c (build_bp_list): Update.
2885 (gdbpy_breakpoints): Update.
2886 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2887 Update.
2888 (bpfinishpy_handle_stop): Update.
2889 (bpfinishpy_handle_exit): Update.
2890 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2891 (svr4_update_solib_event_breakpoints): Update.
2892
ba18312d
AA
28932019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2894
2895 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2896 when unwrapping single-field structs.
2897
6acc1a0b
SM
28982019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2899
2900 * dwarf2read.c: Remove includes.
2901
284782de
SM
29022019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2903
2904 * ui-out.c (ui_out::call_do_message): Silence
2905 -Wformat-nonliteral warning.
2906
073bbbb0
SM
29072019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2908
2909 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2910 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2911 include: readline/tilde.h.
2912
7b9a15e1
CB
29132019-10-12 Christian Biesinger <cbiesinger@google.com>
2914
2915 * remote.c (remote_target::get_trace_status): Remove declaration of
2916 trace_regblock_size.
2917
cc8dee1f
CB
29182019-10-12 Christian Biesinger <cbiesinger@google.com>
2919
2920 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2921 (show_user): Remove declaration of cmdlist.
2922 * cli/cli-cmds.h (max_user_call_depth): Declare.
2923 * cli/cli-script.c (execute_user_command): Remove declaration
2924 of max_user_call_depth.
2925
a83d4ef6
JW
29262019-10-11 Jim Wilson <jimw@sifive.com>
2927
5f93c5a6
JW
2928 * gdbsupport/print-utils.h (pulongest): Fix comment.
2929 (plongest): Likewise.
2930 (phex): Add missing comment, mention leading zeros.
2931 (phex_nz): Add mention of no leading zeros to comment.
2932
a83d4ef6
JW
2933 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2934 plongest instead of unsigned long long cast.
2935
26344e0c
CB
29362019-10-10 Christian Biesinger <cbiesinger@google.com>
2937
2938 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2939 for external_editor_command and gdbtk_test.
2940
c2c440a9
CB
29412019-10-10 Christian Biesinger <cbiesinger@google.com>
2942
2943 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2944 * varobj.c (varobjdebug): Move comment to...
2945 * varobj.h (varobjdebug): ...here, and declare.
2946
a31bff9d
TT
29472019-10-09 Tom Tromey <tom@tromey.com>
2948
2949 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2950 erase_data_content.
2951
7523da63
TT
29522019-10-09 Tom Tromey <tom@tromey.com>
2953
2954 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2955 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2956 * tui/tui-command.c (tui_cmd_window::resize)
2957 (tui_refresh_cmd_win): Update.
2958 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2959 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2960 * tui/tui-data.c (~tui_gen_win_info): Remove.
2961 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2962 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2963 (tui_redisplay_readline, tui_mld_flush)
2964 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2965 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2966 (tui_data_window::erase_data_content)
2967 (tui_data_item_window::rerender)
2968 (tui_data_item_window::refresh_window): Update.
2969 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2970 (box_win, tui_gen_win_info::make_window)
2971 (tui_gen_win_info::make_visible): Update.
2972 (tui_delete_win): Remove.
2973 * tui/tui-winsource.c
2974 (tui_source_window_base::do_erase_source_content): Update.
2975 (tui_show_source_line, tui_source_window_base::update_tab_width)
2976 (tui_source_window_base::update_exec_info): Update.
2977 * tui/tui-data.h (struct curses_deleter): New.
2978 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2979 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2980
a7798e7f
TT
29812019-10-09 Tom Tromey <tom@tromey.com>
2982
2983 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2984
5c45899e
TT
29852019-10-09 Tom Tromey <tom@tromey.com>
2986
2987 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2988 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2989
6d7fd9aa
TT
29902019-10-09 Tom Tromey <tom@tromey.com>
2991
2992 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2993 window height directly.
2994 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2995 declare.
2996 * tui/tui-layout.c (tui_default_win_height): Remove.
2997 (tui_default_win_viewport_height): Remove.
2998
d2dd1084
TT
29992019-10-09 Tom Tromey <tom@tromey.com>
3000
3001 * tui/tui.h: Remove comments.
3002
cff32449
TV
30032019-10-09 Tom de Vries <tdevries@suse.de>
3004
3005 * python/lib/gdb/printer/bound_registers.py: Use
3006 '^builtin_type_bound128' as regexp argument for
3007 add_builtin_pretty_printer.
3008
6a25e8a2
CB
30092019-10-09 Christian Biesinger <cbiesinger@google.com>
3010
3011 * guile/guile.c (guile_extension_script_ops): Remove forward
3012 declaration and mark as static.
3013 (guile_script_ops): Likewise.
3014 (extension_language_guile): Move further down in the file so
3015 it can reference the definitions for guile_{extension_,}script_ops.
3016
6d9d6da4
AA
30172019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3018
3019 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3020 except SORTL, DFLTCC, and KDSA.
3021
3abea05d
TT
30222019-10-08 Tom Tromey <tromey@adacore.com>
3023
3024 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3025 (struct safe_symbol_file_add_args): Remove.
3026
dde996e2
TT
30272019-10-08 Tom Tromey <tromey@adacore.com>
3028
3029 * windows-nat.c: Don't include buildsym-legacy.h.
3030
cd6fdaa1
TT
30312019-10-08 Tom Tromey <tromey@adacore.com>
3032
3033 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3034
79bb1944
CB
30352019-10-08 Christian Biesinger <cbiesinger@google.com>
3036
3037 * gdbtypes.c (overload_debug): Move comment to header.
3038 * gdbtypes.h (overload_debug): Declare.
3039 * valops.c: Remove declaration of overload_debug, instead
3040 include gdbtypes.h.
3041
34916edc
CB
30422019-10-08 Christian Biesinger <cbiesinger@google.com>
3043
3044 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3045 through _().
3046 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3047 move comment...
3048 * language.h (lang_frame_mismatch_warn): ... here. Also add
3049 declaration.
3050 * top.c (lang_frame_mismatch_warn): Remove declaration.
3051 (check_frame_language_change): Pass lang_frame_mismatch_warn
3052 through _().
3053
bad5c026
CB
30542019-10-07 Christian Biesinger <cbiesinger@google.com>
3055
3056 * c-lang.h (vtbl_ptr_name): Declare.
3057 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3058 it from the header.
3059 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3060
51f1fdc3
CB
30612019-10-07 Christian Biesinger <cbiesinger@google.com>
3062
3063 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3064 gdb_static_assert.
3065
30d1f018
WP
30662019-10-07 Weimin Pan <weimin.pan@oracle.com>
3067
606813d5
WP
3068 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3069 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
3070 * ctfread.c: New file.
3071 * ctfread.h: New file.
3072 * elfread.c: Include ctfread.h.
3073 (struct elfinfo text_p): New member ctfsect.
3074 (elf_locate_sections): Mark CTF section.
3075 (elf_symfile_read): Call elfctf_build_psymtabs.
3076 * Makefile.in (LIBCTF): Add.
3077 (CLIBS): Use it.
3078 (CDEPS): Likewise.
3079 (DIST): Add ctfread.c.
606813d5
WP
3080
30812019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3082
3083 * ctfread.c (struct nextfield): Renamed to ...
3084 (struct ctf_nextfield): ... this.
3085 (struct field_info): Renamed to ...
3086 (strut ctf_field_info): ... this.
3087 (attach_fields_to_type): Update for renamed structures.
3088 (ctf_add_member_cb): Likewise.
3089 (ctf_add_enum_member_cb): Likewise.
3090 (process_struct_members): Likewise.
3091 (process_enum_type): Likewise.
30d1f018 3092
518fe38c
WP
30932019-10-07 Weimin Pan <weimin.pan@oracle.com>
3094
3095 * tracectf.h: Rename, was ctf.h.
3096 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3097 * tracefile.c: Likewise.
3098 * tracepoint.c: Remove unused include ctf.h.
3099 * mi/mi-main.c: Likewise.
3100 * Makefile.in Replace ctf.c with tracectf.c.
3101
225f296a
JB
31022019-10-06 Joel Brobecker <brobecker@adacore.com>
3103
3104 * version.in: Change version number to "9.0.50.DATE-git".
3105
77c2dba3
TT
31062019-10-03 Tom Tromey <tom@tromey.com>
3107
3108 PR rust/24976:
3109 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3110
179aed7f
AB
31112019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3112
3113 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3114 cp_search_name_hash.
3115 * NEWS: Add entry about nested function support.
3116
0a4b0913
AB
31172019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3118 Andrew Burgess <andrew.burgess@embecosm.com>
3119
3120 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3121 for nested static variables when searchin VAR_DOMAIN.
3122 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3123 global scope, update comment.
3124 (add_partial_subprogram): Call add_partial_subprogram recursively
3125 for nested subroutines when processinng Fortran.
3126 (load_partial_dies): Process the child entities of a subprogram
3127 when processing Fortran.
3128 (partial_die_parent_scope): Handle building scope
3129 for Fortran nested functions.
3130 (process_die): Record that nested functions have a scope.
3131 (new_symbol): Always record Fortran subprograms on the global
3132 symbol list.
3133 (determine_prefix): How to build the prefix for Fortran
3134 subprograms.
3135
d8c06f22
AB
31362019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3137
3138 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3139 have just sent the thread a SIGSTOP and are waiting for it to
3140 arrive.
3141
a8b3b8e9
AB
31422019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3143
3144 * btrace.c (btrace_add_pc): Remove whitespace before the template
3145 parameter in 'std::vector <...>'.
3146 (parse_xml_btrace_block): Likewise.
3147 (btrace_maint_decode_pt): Likewise.
3148 (btrace_maint_update_packets): Likewise.
3149 (btrace_maint_print_packets): Likewise.
3150 * btrace.h (struct btrace_maint_info): Likewise.
3151 * dwarf2read.c (struct type_unit_group): Likewise.
3152 (build_type_psymtabs_reader): Likewise.
3153 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3154 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3155 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3156
4d825eab
TV
31572019-10-03 Tom de Vries <tdevries@suse.de>
3158
3159 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3160 the first line of the help text for set/show style metadata.
3161
80fd2826
TT
31622019-10-02 Tom Tromey <tromey@adacore.com>
3163
3164 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3165 * gdbsupport/common-inferior.c: New file.
3166 * infcmd.c (startup_with_shell): Don't define.
3167 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3168 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3169 * inferior.h (startup_with_shell): Don't declare.
3170
70054538
CB
31712019-10-02 Christian Biesinger <cbiesinger@google.com>
3172
3173 * gdbsupport/gdb_assert.h: Include errors.h.
3174 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3175
37f6a7f4
TT
31762019-10-02 Tom Tromey <tromey@adacore.com>
3177
3178 * NEWS: Add $_ada_exception entry.
3179 * ada-lang.c (struct ada_catchpoint): Add constructor.
3180 <m_kind>: New member.
3181 (allocate_location_exception, re_set_exception): Remove
3182 "ex" parameter.
3183 (should_stop_exception): Compute $_ada_exception.
3184 (check_status_exception, print_it_exception)
3185 (print_one_exception, print_mention_exception): Remove
3186 "ex" parameter.
3187 (allocate_location_catch_exception, re_set_catch_exception)
3188 (check_status_exception, print_it_catch_exception)
3189 (print_one_catch_exception, print_mention_catch_exception)
3190 (print_recreate_catch_exception)
3191 (allocate_location_catch_exception_unhandled)
3192 (re_set_catch_exception_unhandled)
3193 (check_status_exception, print_it_catch_exception_unhandled)
3194 (print_one_catch_exception_unhandled)
3195 (print_mention_catch_exception_unhandled)
3196 (print_recreate_catch_exception_unhandled)
3197 (allocate_location_catch_assert, re_set_catch_assert)
3198 (check_status_assert, print_it_catch_assert)
3199 (print_one_catch_assert, print_mention_catch_assert)
3200 (print_recreate_catch_assert)
3201 (allocate_location_catch_handlers, re_set_catch_handlers)
3202 (check_status_handlers, print_it_catch_handlers)
3203 (print_one_catch_handlers, print_mention_catch_handlers)
3204 (print_recreate_catch_handlers): Remove.
3205 (create_ada_exception_catchpoint): Update.
3206 (initialize_ada_catchpoint_ops): Update.
3207
fccf9de1
TT
32082019-10-02 Tom Tromey <tromey@adacore.com>
3209
3210 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3211 (create_excep_cond_exprs): Simplify exception string computation.
3212 (ada_exception_catchpoint_cond_string): Likewise.
3213
4b610737
TT
32142019-10-02 Tom Tromey <tromey@adacore.com>
3215
3216 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3217 * ada-lang.c (lesseq_defined_than): Handle
3218 LOC_STATIC.
3219 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3220 parameter.
3221 (dwarf2_has_info): Likewise.
3222 (new_symbol): Set maybe_copied on symbol when
3223 appropriate.
3224 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3225 parameter.
3226 <can_copy>: New member.
3227 * elfread.c (record_minimal_symbol): Set maybe_copied
3228 on symbol when appropriate.
3229 (elf_symfile_read): Update call to dwarf2_has_info.
3230 * minsyms.c (lookup_minimal_symbol_linkage): New
3231 function.
3232 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3233 * symtab.c (get_symbol_address, get_msymbol_address):
3234 New functions.
3235 * symtab.h (get_symbol_address, get_msymbol_address):
3236 Declare.
3237 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3238 maybe_copied.
3239 (struct symbol, struct minimal_symbol) <maybe_copied>:
3240 New member.
3241
1dd58850
TT
32422019-10-02 Tom Tromey <tromey@adacore.com>
3243
3244 * source.c (struct current_source_location): New.
3245 (current_source_key): New global.
3246 (current_source_symtab, current_source_line)
3247 (current_source_pspace): Remove.
3248 (get_source_location): New function.
3249 (get_current_source_symtab_and_line)
3250 (set_default_source_symtab_and_line)
3251 (set_current_source_symtab_and_line)
3252 (clear_current_source_symtab_and_line, select_source_symtab)
3253 (info_source_command, print_source_lines_base)
3254 (info_line_command, search_command_helper, _initialize_source):
3255 Update.
3256
5c281dbb
TT
32572019-10-02 Tom Tromey <tromey@adacore.com>
3258
3259 * source.c (select_source_symtab): Don't call
3260 decode_line_with_current_source.
3261
d3d32391
AB
32622019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3263
3264 * symtab.c (lookup_global_symbol): Search global block.
3265
38583298
TT
32662019-10-02 Tom Tromey <tromey@adacore.com>
3267
3268 * coffread.c (process_coff_symbol): Update.
3269 * dwarf2read.c (var_decode_location, new_symbol): Update.
3270 * mdebugread.c (parse_symbol): Update.
3271 * objfiles.c (relocate_one_symbol): Update.
3272 * stabsread.c (define_symbol, fix_common_block)
3273 (scan_file_globals): Update.
3274 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3275 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3276 * xcoffread.c (process_xcoff_symbol): Update.
3277
9344c18f
AA
32782019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3279
3280 * MAINTAINERS: Update my email address.
3281
df07e2c7
AB
32822019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3283
3284 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3285 std::vector.
3286 (build_type_psymtabs_reader): Update for std::vector.
3287 (build_type_psymtab_dependencies): Likewise.
3288 * dwarf2read.h: Remove use of DEF_VEC_P.
3289 (typedef sig_type_ptr): Delete.
3290
554ac434
AB
32912019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3292
3293 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3294 to std::vector.
3295 (btrace_maint_decode_pt): Likewise, and move allocation of the
3296 vector outside of the loop.
3297 (btrace_maint_update_packets): Update to handle change from VEC to
3298 std::vector.
3299 (btrace_maint_print_packets): Likewise.
3300 (maint_info_btrace_cmd): Likewise.
3301 * btrace.h: Remove use of DEF_VEC_O.
3302 (typedef btrace_pt_packet_s): Delete.
3303 (struct btrace_maint_info) <packets>: Change fromm VEC to
3304 std::vector.
3305 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3306
46f29a9a
AB
33072019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3308
3309 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3310 make accesses into the vector constant references.
3311 (btrace_add_pc): Update for std::vector.
3312 (btrace_stitch_bts): Likewise.
3313 (parse_xml_btrace_block): Likewise.
3314 (btrace_maint_update_packets): Likewise.
3315 (btrace_maint_print_packets): Likewise.
3316 (maint_info_btrace_cmd): Likewise.
3317 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3318 std::vector.
3319 (btrace_data::empty): Likewise.
3320 (btrace_data_append): Likewise.
3321 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3322 (typedef btrace_block_s): Delete.
3323 (struct btrace_block): Add constructor.
3324 (struct btrace_data_bts) <blocks>: Change to std::vector.
3325 * nat/linux-btrace.c (perf_event_read_bts): Update for
3326 std::vector.
3327 (linux_read_bts): Likewise.
3328
d770d56f
TT
33292019-10-01 Tom Tromey <tom@tromey.com>
3330
3331 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3332
9d636d67
TT
33332019-10-01 Tom Tromey <tom@tromey.com>
3334
3335 * stack.c (print_frame, info_frame_command_core): Use
3336 styled_string.
3337 * linux-thread-db.c (try_thread_db_load_1)
3338 (try_thread_db_load_from_pdir_1): Use styled_string.
3339 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3340 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3341 (maybe_print_unsupported_script_warning)
3342 (maybe_print_script_not_found_warning): Use styled_string.
3343 * ada-lang.c (user_select_syms): Use styled_string.
3344
7f6aba03
TT
33452019-10-01 Tom Tromey <tom@tromey.com>
3346
3347 * p-lang.c (pascal_printstr): Use metadata style.
3348 * value.c (show_convenience): Use metadata style.
3349 * valprint.c (valprint_check_validity, val_print_optimized_out)
3350 (val_print_not_saved, val_print_unavailable)
3351 (val_print_invalid_address, generic_val_print, val_print)
3352 (value_check_printable, val_print_array_elements): Use metadata
3353 style.
3354 * ui-out.h (class ui_out) <field_fmt>: New overload.
3355 <do_field_fmt>: Add style parameter.
3356 * ui-out.c (ui_out::field_fmt): New overload.
3357 * typeprint.c (type_print_unknown_return_type)
3358 (val_print_not_allocated, val_print_not_associated): Use metadata
3359 style.
3360 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3361 parameter.
3362 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3363 * tracepoint.c (tvariables_info_1): Use metadata style.
3364 * stack.c (print_frame_arg, print_frame_info, print_frame)
3365 (info_frame_command_core): Use metadata style.
3366 * skip.c (info_skip_command): Use metadata style.
3367 * rust-lang.c (rust_print_enum): Use metadata style.
3368 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3369 metadata style.
3370 * python/py-framefilter.c (py_print_single_arg): Use metadata
3371 style.
3372 * printcmd.c (do_one_display, print_variable_and_value): Use
3373 metadata style.
3374 * p-valprint.c (pascal_val_print)
3375 (pascal_object_print_value_fields): Use metadata style.
3376 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3377 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3378 parameter.
3379 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3380 * m2-valprint.c (m2_print_long_set): Use metadata style.
3381 * m2-typeprint.c (m2_print_type): Use metadata style.
3382 * infcmd.c (print_return_value_1): Use metadata style.
3383 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3384 * f-valprint.c (info_common_command_for_block): Use metadata
3385 style.
3386 * f-typeprint.c (f_type_print_base): Use metadata style.
3387 * expprint.c (print_subexp_standard): Use metadata style.
3388 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3389 * cli/cli-style.h (class cli_style_option): Add constructor.
3390 (metadata_style): Declare.
3391 * cli/cli-style.c (metadata_style): New global.
3392 (_initialize_cli_style): Register metadata style.
3393 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3394 parameter.
3395 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3396 * c-typeprint.c (c_type_print_base_struct_union)
3397 (c_type_print_base_1): Use metadata style.
3398 * breakpoint.c (watchpoint_value_print)
3399 (print_one_breakpoint_location): Use metadata style.
3400 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3401 style.
3402 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3403 style.
3404 * ada-valprint.c (val_print_packed_array_elements, printstr)
3405 (print_field_values, ada_val_print_ref, ada_val_print): Use
3406 metadata style.
3407 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3408 style.
3409 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3410 style.
3411 * ada-lang.c (user_select_syms): Use metadata style.
3412
14309bb6
TT
34132019-10-01 Tom Tromey <tom@tromey.com>
3414
3415 * cli/cli-cmds.c (pwd_command): Style output.
3416
6a831f06
PA
34172019-10-01 Pedro Alves <palves@redhat.com>
3418 Tom Tromey <tom@tromey.com>
3419
3420 * symtab.c (print_symbol_info): Use %ps.
3421 (print_msymbol_info): Use %ps.
3422 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3423 * printcmd.c (print_variable_and_value): Use %ps.
3424 * macrocmd.c (show_pp_source_pos): Use %ps.
3425 * infrun.c (print_exited_reason): Use ui_out::message.
3426 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3427 (describe_other_breakpoints): Use ui_out::message and new
3428 formats.
3429 (say_where): Use new formats.
3430 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3431 and new formats.
3432
2a3c1174
PA
34332019-10-01 Pedro Alves <palves@redhat.com>
3434 Tom Tromey <tom@tromey.com>
3435
3436 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3437 (test_gdb_formats): New function.
3438 (run_tests): Call it.
3439 (test_format_specifier): Update.
3440 * utils.h (fputs_filtered): Update comment.
3441 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3442 (fputs_styled_unfiltered): Declare.
3443 * utils.c (fputs_styled_unfiltered): New function.
3444 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3445 (vfprintf_filtered): Update.
3446 (vfprintf_unfiltered, vprintf_filtered): Update.
3447 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3448 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3449 disallow_ui_out_field>: New constants.
3450 (enum class field_kind): New.
3451 (struct base_field_s, struct signed_field_s): New.
3452 (signed_field): New function.
3453 (struct string_field_s): New.
3454 (string_field): New function.
3455 (struct styled_string_s): New.
3456 (styled_string): New function.
3457 (class ui_out) <message>: Add comment.
3458 <vmessage, call_do_message>: New methods.
3459 <do_message>: Add style parameter.
3460 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3461 methods.
3462 (ui_out::message): Rewrite.
3463 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3464 parameter.
3465 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3466 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3467 gdb_extensions parameter.
3468 (class format_piece): Add parameter to constructor.
3469 (n_int_args): New field.
3470 * gdbsupport/format.c (format_pieces::format_pieces): Add
3471 gdb_extensions parameter. Handle '*'.
3472 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3473 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3474 vfprintf_styled_no_gdbfmt.
3475 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3476 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3477 unfiltered output.
3478 * ui-style.h (struct ui_file_style) <ptr>: New method.
3479
0dfe5bfb
TT
34802019-10-01 Tom Tromey <tom@tromey.com>
3481
3482 * unittests/format_pieces-selftests.c: Update. Add final format.
3483 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3484 empty literal pieces.
3485
e43b10e1
TT
34862019-10-01 Tom Tromey <tom@tromey.com>
3487
3488 * ui-out.h (enum class ui_out_style_kind): Remove.
3489 (class ui_out) <field_string, field_stsream, do_field_string>:
3490 Change type of "style".
3491 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3492 (ui_out::field_string): Update.
3493 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3494 of "style".
3495 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3496 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3497 * stack.c (print_frame_arg, print_frame_info, print_frame):
3498 Update.
3499 * source.c (print_source_lines_base): Update.
3500 * solib.c (info_sharedlibrary_command): Update.
3501 * skip.c (info_skip_command): Update.
3502 * record-btrace.c (btrace_call_history_src_line)
3503 (btrace_call_history): Update.
3504 * python/py-framefilter.c (py_print_frame): Update.
3505 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3506 "style".
3507 * mi/mi-out.c (mi_ui_out::do_table_header)
3508 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3509 (mi_ui_out::do_field_string): Update.
3510 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3511 Update.
3512 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3513 "style".
3514 * cli-out.c (cli_ui_out::do_table_header)
3515 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3516 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3517 (cli_ui_out::do_field_fmt): Update.
3518 * breakpoint.c (print_breakpoint_location): Update.
3519 (update_static_tracepoint): Update.
3520
cd7c32c3
PW
35212019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3522
3523 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3524 conversion of gdb_datadir.
3525 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3526 remove not needed c_str ().
3527
8fe0f950
AT
35282019-09-30 Ali Tamur <tamur@google.com>
3529
3530 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3531 (dwarf2_string_attr): Likewise.
3532
5f48f8f3
AT
35332019-09-30 Ali Tamur <tamur@google.com>
3534
3535 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3536 (process_full_type_unit): Likewise.
3537 (dump_die_shallow): Likewise.
3538 (cu_debug_loc_section): Likewise.
3539
6fb08628
CB
35402019-09-28 Christian Biesinger <cbiesinger@google.com>
3541
3542 * minsyms.c (compare_minimal_symbols): Rename to...
3543 (minimal_symbol_is_less_than): ...this, and adjust to STL
3544 conventions (return bool, take arguments as references)
3545 (minimal_symbol_reader::install): Call std::sort instead
3546 of qsort.
3547
c7ee338a
CB
35482019-09-29 Christian Biesinger <cbiesinger@google.com>
3549
3550 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3551 hash and why.
3552 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3553 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3554
703a86c2
SM
35552019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3556
3557 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3558 * psympriv.h (add_psymbol_to_list): Move comment here and update
3559 it.
3560
0df0352a
TV
35612019-09-29 Tom de Vries <tdevries@suse.de>
3562
3563 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3564 Use $tmpdir/$(basename "$output_file").dwz instead of
3565 "${output_file}.dwz".
3566
ad75efa6
SM
35672019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3568
3569 PR gdb/25045
3570 * hppa-linux-nat.c: Include gdbarch.h.
3571
ececd218
CB
35722019-09-26 Christian Biesinger <cbiesinger@google.com>
3573
3574 * blockframe.c (find_pc_partial_function): Change return type to bool.
3575 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3576 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3577 (stub_gnu_ifunc_resolve_name): Likewise.
3578 * symtab.c (compare_filenames_for_search): Likewise.
3579 (compare_glob_filenames_for_search): Likewise.
3580 (matching_obj_sections): Likewise.
3581 (symbol_matches_domain): Likewise.
3582 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3583 (find_line_pc): Change return type to bool.
3584 (find_line_pc_range): Likewise.
3585 (producer_is_realview): Likewise.
3586 * symtab.h (symbol_matches_domain): Likewise.
3587 (find_pc_partial_function): Likewise.
3588 (find_pc_line_pc_range): Likewise.
3589 (in_gnu_ifunc_stub): Likewise.
3590 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3591 (find_line_pc): Likewise.
3592 (find_line_pc_range): Likewise.
3593 (matching_obj_sections): Likewise.
3594 (find_line_symtab): Change out parameter to bool.
3595 (producer_is_realview): Change return type to bool.
3596 (compare_filenames_for_search): Likewise.
3597 (compare_glob_filenames_for_search): Likewise.
3598
27a900b8
TT
35992019-09-26 Tom Tromey <tom@tromey.com>
3600
3601 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3602 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3603 * gdb_usleep.h: Remove.
3604 * gdb_usleep.c: Remove.
3605 * utils.c: Don't include gdb_usleep.h.
3606
5d63b30a
TT
36072019-09-26 Tom Tromey <tromey@adacore.com>
3608
3609 * python/py-type.c (type_to_type_object): Call check_typedef
3610 for stub types.
3611
12904d37
TT
36122019-09-26 Tom Tromey <tom@tromey.com>
3613
3614 * utils.h (initialize_utils): Don't declare.
3615 * top.c (gdb_init): Don't call initialize_utils.
3616 * utils.c (initialize_utils): Remove. Move contents...
3617 (_initialize_utils): ... here.
3618
858f25f0
TT
36192019-09-25 Tom Tromey <tom@tromey.com>
3620
3621 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3622 * utils.h (make_hex_string): Don't declare.
3623 * utils.c (make_hex_string): Remove.
3624
3d435220
TV
36252019-09-24 Tom de Vries <tdevries@suse.de>
3626
3627 PR gdb/23815
3628 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3629 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3630
ddd44b70
DD
36312019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3632
3633 * NEWS: Mention new simulator port for PRU.
3634
f945dedf
CB
36352019-09-23 Christian Biesinger <cbiesinger@google.com>
3636
3637 * ada-exp.y (write_object_remaining): Update.
3638 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3639 and eliminate the static buffer.
3640 (ada_decode_symbol): Update.
3641 (ada_la_decode): Update.
3642 (ada_sniff_from_mangled_name): Update.
3643 (is_valid_name_for_wild_match): Update.
3644 (ada_lookup_name_info::matches): Update and simplify.
3645 (name_matches_regex): Update.
3646 (ada_add_global_exceptions): Update.
3647 * ada-lang.h (ada_decode): Update signature.
3648 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3649 * dwarf-index-write.c (debug_names::insert): Update.
3650
7ab78ccb
SM
36512019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3652
3653 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3654 formatting.
3655
9252448b
SM
36562019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3657
3658 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3659 Change "nonzero" to "true" in documentation.
3660
626ca2c0
CB
36612019-09-20 Christian Biesinger <cbiesinger@google.com>
3662
3663 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3664 (_initialize_darwin_solib): Don't set
3665 darwin_so_ops.lookup_lib_global_symbol.
3666 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3667 set_gdbarch_iterate_over_objfiles_in_search_order.
3668 (elf_lookup_lib_symbol): Rename to...
3669 (svr4_iterate_over_objfiles_in_search_order): this, and update
3670 to iterate semantics.
3671 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3672 * solib.c (solib_global_lookup): Remove.
3673 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3674 (solib_global_lookup): Remove.
3675 * symtab.c (lookup_global_or_static_symbol): Remove call to
3676 solib_global_lookup.
3677
5a3a0d63
JB
36782019-09-20 Joel Brobecker <brobecker@adacore.com>
3679
3680 * NEWS: Move entries about default MI version now being
3681 version 3, and about the GDB/MI fix for multi-location
3682 breakpoints to the "since GDB 8.3" section.
3683
ffea1427
JB
36842019-09-20 Joel Brobecker <brobecker@adacore.com>
3685
3686 GDB 8.3.1 released.
3687
abf516c6
UW
36882019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3689
3690 * NEWS: Mention that Cell/B.E. debugging support was removed.
3691 * MAINTAINERS: Remove spu target.
3692
3693 * config/djgpp/fnchange.lst: Remove entries for removed files.
3694
3695 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3696 spu-multiarch.o, and spu-tdep.o.
3697 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3698 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3699 spu-multiarch.c, and spu-tdep.c.
3700 * spu-linux-nat.c: Remove file.
3701 * spu-multiarch.c: Remove file.
3702 * spu-tdep.c: Remove file.
3703 * spu-tdep.h: Remove file.
3704 * solib-spu.c: Remove file.
3705 * solib-spu.h: Remove file.
3706
3707 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3708 * configure.nat (spu-linux): Remove.
3709 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3710 solib-multiarch.o from gdb_target_obs.
3711 (spu*-*-*): Remove.
3712
3713 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3714 feature flag.
3715 (ppc_linux_no_features): Update.
3716 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3717 Cell/B.E. support.
3718 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3719 (tdesc_powerpc_cell64l): Likewise.
3720 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3721 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3722 Cell/B.E. support.
3723 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3724 Do not include "features/rs6000/powerpc-cell32l.c" or
3725 "features/rs6000/powerpc-cell64l.c".
3726 (ppc_linux_spu_section): Remove.
3727 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3728 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3729 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3730 (ppc_linux_spe_context_lookup): Remove.
3731 (ppc_linux_spe_context_inferior_created): Remove.
3732 (ppc_linux_spe_context_solib_loaded): Remove.
3733 (ppc_linux_spe_context_solib_unloaded): Remove.
3734 (ppc_linux_spe_context): Remove.
3735 (struct ppu2spu_cache): Remove.
3736 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3737 (struct ppu2spu_data): Remove.
3738 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3739 ppu2spu_unwind): Remove.
3740 (ppc_linux_init_abi): Remove Cell/B.E. support.
3741 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3742
3743 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3744 (rs6000/powerpc-cell64l-expedite): Likewise
3745 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3746 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3747 rs6000/powerpc-cell64l.xml.
3748 * features/rs6000/powerpc-cell32l.xml: Remove.
3749 * features/rs6000/powerpc-cell64l.xml: Likewise.
3750 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3751 * features/rs6000/powerpc-cell64l.c: Likewise.
3752 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3753 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3754 * regformats/reg-spu.dat: Remove.
3755
3756 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3757 * corelow.c (struct spuid_list): Remove.
3758 (add_to_spuid_list): Remove.
3759 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3760 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3761 (remote_protocol_features): Remove associated entries.
3762 (_initialize_remote): No longer initialize them.
3763 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3764 * linux-nat.c (SPUFS_MAGIC): Remove.
3765 (linux_proc_xfer_spu): Remove.
3766 (spu_enumerate_spu_ids): Remove.
3767 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3768 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3769 (linux_make_corefile_notes): No longer call it.
3770
3771 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3772 (cooked_write_test): Likewise.
3773
78e8cb91
TT
37742019-09-20 Tom Tromey <tom@tromey.com>
3775
3776 * NEWS: Mention case-sensitivity of TUI commands.
3777 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3778 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3779 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3780
f074b67e
TT
37812019-09-20 Tom Tromey <tom@tromey.com>
3782
3783 * tui/tui-source.c (tui_source_window::set_contents): Use
3784 make_unique_xstrdup.
3785 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3786 make_unique_xstrdup.
3787
63c4bf19
TT
37882019-09-20 Tom Tromey <tom@tromey.com>
3789
3790 * tui/tui-data.c: Remove separator comments.
3791 * tui/tui-layout.c: Remove separator comments.
3792 * tui/tui-win.c: Remove separator comments.
3793 * tui/tui-wingeneral.c: Remove separator comments.
3794
43df9b2f
TT
37952019-09-20 Tom Tromey <tom@tromey.com>
3796
3797 * tui/tui.h (strcat_to_buf): Don't declare.
3798 * tui/tui.c (strcat_to_buf): Remove.
3799
7226433c
TT
38002019-09-20 Tom Tromey <tom@tromey.com>
3801
3802 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3803 from "fullname".
3804 * tui/tui-source.c (tui_source_window::set_contents)
3805 (tui_source_window::location_matches_p)
3806 (tui_source_window::maybe_update): Update.
3807
80df3337
TT
38082019-09-20 Tom Tromey <tom@tromey.com>
3809
3810 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3811 Update.
3812 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3813 prefix.
3814 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3815 (tui_data_window::line_from_reg_element_no)
3816 (tui_data_window::first_reg_element_no_inline)
3817 (tui_data_window::show_registers)
3818 (tui_data_window::show_register_group)
3819 (tui_data_window::display_registers_from)
3820 (tui_data_window::display_registers_from_line)
3821 (tui_data_window::first_data_item_displayed)
3822 (tui_data_window::delete_data_content_windows)
3823 (tui_data_window::erase_data_content)
3824 (tui_data_window::do_scroll_vertical)
3825 (tui_data_window::refresh_window)
3826 (tui_data_window::check_register_values): Update.
3827
9923f347
TT
38282019-09-20 Tom Tromey <tom@tromey.com>
3829
3830 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3831 (struct tui_locator_window) <full_name, proc_name>: Now
3832 std::string.
3833 * tui/tui-stack.c (tui_locator_window::make_status_line)
3834 (tui_locator_window::set_locator_fullname)
3835 (tui_locator_window::set_locator_info): Update.
3836 * tui/tui-source.c (tui_source_window::set_contents)
3837 (tui_source_window::showing_source_p): Update.
3838
b76251ab
TT
38392019-09-20 Tom Tromey <tom@tromey.com>
3840
3841 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3842 Don't call tui_locator_win_info_ptr.
3843
0891be08
TT
38442019-09-20 Tom Tromey <tom@tromey.com>
3845
3846 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3847
1b935acf
TT
38482019-09-20 Tom Tromey <tom@tromey.com>
3849
3850 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3851 height for locator.
3852 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3853 * tui/tui-layout.c (show_source_disasm_command, show_data)
3854 (show_source_or_disasm_and_command): Use 1 as height for locator.
3855
9abd8a65
TT
38562019-09-20 Tom Tromey <tom@tromey.com>
3857
3858 * tui/tui.c (tui_enable): Update.
3859 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3860 Update.
3861 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3862 Update.
3863 * tui/tui-data.c (win_resized): Now bool.
3864 (tui_win_resized): Return bool.
3865 (tui_set_win_resized_to): Accept a bool.
3866
b5457826
TT
38672019-09-20 Tom Tromey <tom@tromey.com>
3868
3869 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3870 Change type of "refresh_values_only".
3871 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3872 type of "refresh_values_only".
3873
6b915f7d
TT
38742019-09-20 Tom Tromey <tom@tromey.com>
3875
3876 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3877 std::string.
3878 (tui_disassemble): Add "pos" parameter.
3879 (tui_disasm_window::set_contents): Simplify.
3880
2ad52f6f
TT
38812019-09-20 Tom Tromey <tom@tromey.com>
3882
3883 * tui/tui-winsource.h (struct tui_source_window_base)
3884 <show_source_content>: Now private.
3885 * tui/tui-winsource.c
3886 (tui_source_window_base::show_source_content): Don't handle empty
3887 content case.
3888
b3b1bde6
TT
38892019-09-20 Tom Tromey <tom@tromey.com>
3890
3891 * tui/tui-layout.c (show_source_disasm_command)
3892 (show_source_or_disasm_and_command): Don't call
3893 show_source_content.
3894
71a25ed2
TT
38952019-09-20 Tom Tromey <tom@tromey.com>
3896
3897 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3898 Declare.
3899 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3900 from tui_make_status_line.
3901 (tui_locator_window::rerender): Update.
3902
f8532154
TT
39032019-09-20 Tom Tromey <tom@tromey.com>
3904
3905 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3906 (tui_locator_window::rerender): Update.
3907
2d81b349
TT
39082019-09-20 Tom Tromey <tom@tromey.com>
3909
3910 * tui/tui-winsource.h (struct tui_source_window_base)
3911 <~tui_source_window_base>: Don't declare.
3912 <fullname>: Remove.
3913 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3914 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3915 member.
3916 * tui/tui-source.c (tui_source_window::set_contents): Update.
3917 (tui_source_window::location_matches_p)
3918 (tui_source_window::maybe_update): Update.
3919
f14bec58
TT
39202019-09-20 Tom Tromey <tom@tromey.com>
3921
3922 * tui/tui-winsource.h (~tui_source_element): Remove.
3923 (tui_source_element): Update.
3924 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3925 * tui/tui-winsource.c (tui_show_source_line): Update.
3926 * tui/tui-source.c (tui_source_window::set_contents): Update.
3927 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3928
78d5933a
TT
39292019-09-20 Tom Tromey <tom@tromey.com>
3930
3931 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3932 declare.
3933 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3934 tui_clear_source_windows_detail.
3935 * tui/tui-winsource.h (struct tui_source_window_base)
3936 <clear_detail>: Don't declare.
3937 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3938 Remove.
3939 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3940
d4207696
TT
39412019-09-20 Tom Tromey <tromey@adacore.com>
3942
3943 PR ada/24919:
3944 * block.c (contained_in): Fix final return value.
3945
00f93c44
AM
39462019-09-20 Alan Modra <amodra@gmail.com>
3947
3948 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3949 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3950 (read_indirect_string_from_dwz): Use bfd accessor.
3951 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3952 * machoread.c (macho_symfile_read_all_oso): Likewise.
3953 * solib.c (solib_bfd_open): Likewise.
3954
e4153ae6
CB
39552019-09-19 Christian Biesinger <cbiesinger@google.com>
3956
3957 * eval.c: Move declaration of overload_resolution to...
3958 * value.h: ...here.
3959
c7ae7675
CB
39602019-09-19 Christian Biesinger <cbiesinger@google.com>
3961
3962 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3963 * arm-linux-tdep.c: Likewise.
3964 * arm-nbsd-nat.c: Likewise.
3965 * arm-tdep.h: Declare arm_apcs_32.
3966 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3967
e86f08d2
CB
39682019-09-19 Christian Biesinger <cbiesinger@google.com>
3969
3970 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3971 * dwarf2read.h: Declare dwarf_always_disassemble.
3972
f64e2f40
TV
39732019-09-19 Tom de Vries <tdevries@suse.de>
3974
3975 PR gdb/25009
3976 * source-cache.c (source_cache::ensure): Catch exception thrown during
3977 construction of the highlighter.
3978
fd361982
AM
39792019-09-18 Alan Modra <amodra@gmail.com>
3980
3981 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3982 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3983 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3984 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3985 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3986 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3987 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3988 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3989 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3990 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3991 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3992 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3993 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3994 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3995 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3996 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3997 * mi/mi-interp.c: Update throughout for bfd section macro and
3998 function changes.
3999 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4000 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4001
11061048
TT
40022019-09-18 Tom Tromey <tom@tromey.com>
4003
4004 * NEWS: Add entry.
4005 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4006 call rl_initialize.
4007 (tui_enable): Do not call rl_initialize.
4008
7a27b85f
CG
40092019-09-18 Christian Groessler <chris@groessler.org>
4010
4011 * alpha-linux-nat.c: Include gdbarch.h.
4012
f64eea3a
SM
40132019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4014
4015 * ui-file.c: Include cli/cli-style.h.
4016 (term_cli_styling): Remove cli_styling declaration.
4017
e6f7f6d1
AM
40182019-09-18 Alan Modra <amodra@gmail.com>
4019
4020 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4021 to bfd_asymbol_section.
4022
1d38e9d1
AM
40232019-09-18 Alan Modra <amodra@gmail.com>
4024
4025 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4026 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4027 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4028
90d92a63
AM
40292019-09-18 Alan Modra <amodra@gmail.com>
4030
4031 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4032 * spu-linux-nat.c (spu_bfd_open): Likewise.
4033
a3d181d2
CB
40342019-09-18 Christian Biesinger <cbiesinger@google.com>
4035
4036 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4037 to bool to match definition in dwarf2read.c.
4038
491144b5
CB
40392019-09-17 Christian Biesinger <cbiesinger@google.com>
4040
4041 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4042 (print_signatures): Likewise.
4043 (trust_pad_over_xvs): Likewise.
4044 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4045 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4046 * arm-linux-nat.c (arm_apcs_32): Likewise.
4047 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4048 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4049 * arm-tdep.c (arm_debug): Likewise.
4050 (arm_apcs_32): Likewise.
4051 * auto-load.c (debug_auto_load): Likewise.
4052 (auto_load_gdb_scripts): Likewise.
4053 (global_auto_load): Likewise.
4054 (auto_load_local_gdbinit): Likewise.
4055 (auto_load_local_gdbinit_loaded): Likewise.
4056 * auto-load.h (global_auto_load): Likewise.
4057 (auto_load_local_gdbinit): Likewise.
4058 (auto_load_local_gdbinit_loaded): Likewise.
4059 * breakpoint.c (disconnected_dprintf): Likewise.
4060 (breakpoint_proceeded): Likewise.
4061 (automatic_hardware_breakpoints): Likewise.
4062 (always_inserted_mode): Likewise.
4063 (target_exact_watchpoints): Likewise.
4064 (_initialize_breakpoint): Update.
4065 * breakpoint.h (target_exact_watchpoints): Change to bool.
4066 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4067 * cli/cli-cmds.c (trace_commands): Likewise.
4068 * cli/cli-cmds.h (trace_commands): Likewise.
4069 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4070 to bool*.
4071 * cli/cli-logging.c (logging_overwrite): Change to bool.
4072 (logging_redirect): Likewise.
4073 (debug_redirect): Likewise.
4074 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4075 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4076 to bool.
4077 <boolean_option_def>: Update.
4078 (struct flag_option_def): Change default type of Context to bool
4079 from int.
4080 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4081 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4082 (get_setshow_command_value_string): Likewise.
4083 * cli/cli-style.c (cli_styling): Change to bool.
4084 (source_styling): Likewise.
4085 * cli/cli-style.h (source_styling): Likewise.
4086 (cli_styling): Likewise.
4087 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4088 to bool.
4089 * command.h (var_types): Update comment.
4090 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4091 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4092 bool.
4093 (debug_compile_cplus_scopes): Likewise.
4094 * compile/compile-internal.h (compile_debug): Likewise.
4095 * compile/compile.c (compile_debug): Likewise.
4096 (struct compile_options) <raw>: Likewise.
4097 * cp-support.c (catch_demangler_crashes): Likewise.
4098 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4099 (usr_cmd_cris_dwarf2_cfi): Likewise.
4100 * csky-tdep.c (csky_debug): Likewise.
4101 * darwin-nat.c (enable_mach_exceptions): Likewise.
4102 * dcache.c (dcache_enabled_p): Likewise.
4103 * defs.h (info_verbose): Likewise.
4104 * demangle.c (demangle): Likewise.
4105 (asm_demangle): Likewise.
4106 * dwarf-index-cache.c (debug_index_cache): Likewise.
4107 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4108 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4109 * dwarf2read.c (check_physname): Likewise.
4110 (use_deprecated_index_sections): Likewise.
4111 (dwarf_always_disassemble): Likewise.
4112 * eval.c (overload_resolution): Likewise.
4113 * event-top.c (set_editing_cmd_var): Likewise.
4114 (exec_done_display_p): Likewise.
4115 * event-top.h (set_editing_cmd_var): Likewise.
4116 (exec_done_display_p): Likewise.
4117 * exec.c (write_files): Likewise.
4118 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4119 (debug_fbsd_nat): Likewise.
4120 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4121 Likewise.
4122 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4123 <backtrace_past_entry> Likewise.
4124 * gdb-demangle.h (demangle): Likewise.
4125 (asm_demangle): Likewise.
4126 * gdb_bfd.c (bfd_sharing): Likewise.
4127 * gdbcore.h (write_files): Likewise.
4128 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4129 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4130 * gdbthread.h (print_thread_events): Likewise.
4131 * gdbtypes.c (opaque_type_resolution): Likewise.
4132 (strict_type_checking): Likewise.
4133 * gnu-nat.c (gnu_debug_flag): Likewise.
4134 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4135 * guile/scm-param.c (pascm_variable): Add boolval.
4136 (add_setshow_generic): Update.
4137 (pascm_param_value): Update.
4138 (pascm_set_param_value_x): Update.
4139 * hppa-tdep.c (hppa_debug): Change to bool..
4140 * infcall.c (may_call_functions_p): Likewise.
4141 (coerce_float_to_double_p): Likewise.
4142 (unwind_on_signal_p): Likewise.
4143 (unwind_on_terminating_exception_p): Likewise.
4144 * infcmd.c (startup_with_shell): Likewise.
4145 * inferior.c (print_inferior_events): Likewise.
4146 * inferior.h (startup_with_shell): Likewise.
4147 (print_inferior_events): Likewise.
4148 * infrun.c (step_stop_if_no_debug): Likewise.
4149 (detach_fork): Likewise.
4150 (debug_displaced): Likewise.
4151 (disable_randomization): Likewise.
4152 (non_stop): Likewise.
4153 (non_stop_1): Likewise.
4154 (observer_mode): Likewise.
4155 (observer_mode_1): Likewise.
4156 (set_observer_mode): Update.
4157 (sched_multi): Change to bool.
4158 * infrun.h (debug_displaced): Likewise.
4159 (sched_multi): Likewise.
4160 (step_stop_if_no_debug): Likewise.
4161 (non_stop): Likewise.
4162 (disable_randomization): Likewise.
4163 * linux-tdep.c (use_coredump_filter): Likewise.
4164 (dump_excluded_mappings): Likewise.
4165 * linux-thread-db.c (auto_load_thread_db): Likewise.
4166 (check_thread_db_on_load): Likewise.
4167 * main.c (captured_main_1): Update.
4168 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4169 xx2_opt, boolean_opt>: Change to bool.
4170 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4171 * maint.c (maintenance_profile_p): Likewise.
4172 (per_command_time): Likewise.
4173 (per_command_space): Likewise.
4174 (per_command_symtab): Likewise.
4175 * memattr.c (inaccessible_by_default): Likewise.
4176 * mi/mi-main.c (mi_async): Likewise.
4177 (mi_async_1): Likewise.
4178 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4179 * nat/fork-inferior.h (startup_with_shell): Likewise.
4180 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4181 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4182 * nios2-tdep.c (nios2_debug): Likewise.
4183 * or1k-tdep.c (or1k_debug): Likewise.
4184 * parse.c (parser_debug): Likewise.
4185 * parser-defs.h (parser_debug): Likewise.
4186 * printcmd.c (print_symbol_filename): Likewise.
4187 * proc-api.c (procfs_trace): Likewise.
4188 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4189 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4190 (set_parameter_value): Update.
4191 (add_setshow_generic): Update.
4192 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4193 to bool*.
4194 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4195 int*.
4196 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4197 * record-btrace.c (record_btrace_target::store_registers): Update.
4198 * record-full.c (record_full_memory_query): Change to bool.
4199 (record_full_stop_at_limit): Likewise.
4200 * record-full.h (record_full_memory_query): Likewise.
4201 * remote-notif.c (notif_debug): Likewise.
4202 * remote-notif.h (notif_debug): Likewise.
4203 * remote.c (use_range_stepping): Likewise.
4204 (interrupt_on_connect): Likewise.
4205 (remote_break): Likewise.
4206 * ser-tcp.c (tcp_auto_retry): Likewise.
4207 * ser-unix.c (serial_hwflow): Likewise.
4208 * skip.c (debug_skip): Likewise.
4209 * solib-aix.c (solib_aix_debug): Likewise.
4210 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4211 (spu_auto_flush_cache_p): Likewise.
4212 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4213 Likewise.
4214 (struct info_print_options) <quiet>: Likewise.
4215 * symfile-debug.c (debug_symfile): Likewise.
4216 * symfile.c (auto_solib_add): Likewise.
4217 (separate_debug_file_debug): Likewise.
4218 * symfile.h (auto_solib_add): Likewise.
4219 (separate_debug_file_debug): Likewise.
4220 * symtab.c (basenames_may_differ): Likewise.
4221 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4222 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4223 (struct info_types_options) <quiet>: Likewise.
4224 * symtab.h (demangle): Likewise.
4225 (basenames_may_differ): Likewise.
4226 * target-dcache.c (stack_cache_enabled_1): Likewise.
4227 (code_cache_enabled_1): Likewise.
4228 * target.c (trust_readonly): Likewise.
4229 (may_write_registers): Likewise.
4230 (may_write_memory): Likewise.
4231 (may_insert_breakpoints): Likewise.
4232 (may_insert_tracepoints): Likewise.
4233 (may_insert_fast_tracepoints): Likewise.
4234 (may_stop): Likewise.
4235 (auto_connect_native_target): Likewise.
4236 (target_stop_and_wait): Update.
4237 (target_async_permitted): Change to bool.
4238 (target_async_permitted_1): Likewise.
4239 (may_write_registers_1): Likewise.
4240 (may_write_memory_1): Likewise.
4241 (may_insert_breakpoints_1): Likewise.
4242 (may_insert_tracepoints_1): Likewise.
4243 (may_insert_fast_tracepoints_1): Likewise.
4244 (may_stop_1): Likewise.
4245 * target.h (target_async_permitted): Likewise.
4246 (may_write_registers): Likewise.
4247 (may_write_memory): Likewise.
4248 (may_insert_breakpoints): Likewise.
4249 (may_insert_tracepoints): Likewise.
4250 (may_insert_fast_tracepoints): Likewise.
4251 (may_stop): Likewise.
4252 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4253 (make_thread_apply_all_options_def_group): Change argument from int*
4254 to bool*.
4255 (thread_apply_all_command): Update.
4256 (print_thread_events): Change to bool.
4257 * top.c (confirm): Likewise.
4258 (command_editing_p): Likewise.
4259 (history_expansion_p): Likewise.
4260 (write_history_p): Likewise.
4261 (info_verbose): Likewise.
4262 * top.h (confirm): Likewise.
4263 (history_expansion_p): Likewise.
4264 * tracepoint.c (disconnected_tracing): Likewise.
4265 (circular_trace_buffer): Likewise.
4266 * typeprint.c (print_methods): Likewise.
4267 (print_typedefs): Likewise.
4268 * utils.c (debug_timestamp): Likewise.
4269 (sevenbit_strings): Likewise.
4270 (pagination_enabled): Likewise.
4271 * utils.h (sevenbit_strings): Likewise.
4272 (pagination_enabled): Likewise.
4273 * valops.c (overload_resolution): Likewise.
4274 * valprint.h (struct value_print_options) <prettyformat_arrays,
4275 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4276 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4277 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4278 Likewise.
4279 * windows-nat.c (new_console): Likewise.
4280 (cygwin_exceptions): Likewise.
4281 (new_group): Likewise.
4282 (debug_exec): Likewise.
4283 (debug_events): Likewise.
4284 (debug_memory): Likewise.
4285 (debug_exceptions): Likewise.
4286 (useshell): Likewise.
4287 * windows-tdep.c (maint_display_all_tib): Likewise.
4288 * xml-support.c (debug_xml): Likewise.
4289
f1b620e9
MG
42902019-09-17 Mike Gulick <mgulick@mathworks.com>
4291
4292 * source.c (prepare_path_for_appending): New function.
4293 (openp): Make use of new function.
4294 (find_and_open_source): Search for the compilation directory and
4295 source file as a relative path beneath the directory search path.
4296
67f3ed6a
AB
42972019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4298
4299 * source-cache.c (source_cache::get_line_charpos): Catch
4300 exceptions and return false, this matches the behaviour documented
4301 in the header file.
4302
74332189
JB
43032019-09-17 Joel Brobecker <brobecker@adacore.com>
4304
4305 * ada-tasks.c (info_task): Remove quoting of the task's name.
4306
f2f24aa9
CB
43072019-09-16 Christian Biesinger <cbiesinger@google.com>
4308
4309 * symfile.c (auto_solib_add): Replace comment with a reference
4310 to the header file.
4311
6a062a93
CB
43122019-09-14 Christian Biesinger <cbiesinger@google.com>
4313
4314 * NEWS: Mention that gdb can now be compiled with Python 3
4315 on Windows.
4316
ec6c8338
AB
43172019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4318
4319 * maint.c (maint_print_section_data::maint_print_section_data):
4320 Force use of 'float log10 (float)' by casting the argument to
4321 float.
4322
aa17805f
AB
43232019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4324
4325 * maint.c: Add 'cmath' include.
4326 (struct maint_print_section_data): New structure.
4327 (print_section_index): New function.
4328 (print_bfd_section_info): Add header comment, small whitespace
4329 cleanup, and update to call new print_section_index function.
4330 (print_objfile_section_info): Likewise.
4331 (maint_obj_section_from_bfd_section): New function.
4332 (print_bfd_section_info_maybe_relocated): New function.
4333 (maintenance_info_sections): Add header comment, always use
4334 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4335
3dd9bb46
AB
43362019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4337
4338 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4339 inner scope, add check that the objfile has psymtabs before
4340 checking psymtabs_addrmap.
4341 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4342
4993045d
PW
43432019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4344
4345 * NEWS: Announce that Ada task names are now shown at more places,
4346 and between quotes (except in info task output).
4347 * gdb/ada-tasks.c (task_to_str): New function.
4348 (display_current_task_id): Call task_to_str.
4349 (task_command_1): Likewise.
4350 (print_ada_task_info): In non-mi mode, Properly align headers and data
4351 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4352
7a289707
RO
43532019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4354
4355 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4356 prstatus.pr_lwp.pr_info instead of making it up.
4357
f2aec7f6
CB
43582019-09-11 Christian Biesinger <cbiesinger@google.com>
4359
4360 * auto-load.c (auto_load_expand_dir_vars): Update.
4361 * defs.h (gdb_datadir): Change to std::string.
4362 (python_libdir): Likewise.
4363 (relocate_gdb_directory): Change return type to std::string.
4364 * guile/guile.c (gdbscm_data_directory): Update.
4365 (initialize_scheme_side): Update.
4366 * jit.c (jit_reader_dir): Change to std::string.
4367 (jit_reader_load_command): Update.
4368 * main.c (gdb_datadir): Change to std::string.
4369 (python_libdir): Likewise.
4370 (set_gdb_data_directory): Update.
4371 (relocate_path): Change to return std::string.
4372 (relocate_gdb_directory): Change to return std::string.
4373 (relocate_gdbinit_path_maybe_in_datadir): Update.
4374 (captured_main_1): Update.
4375 * python/python.c (do_start_initialization): Update.
4376 * top.c (show_gdb_datadir): Update.
4377 * xml-syscall.c (xml_init_syscalls_info): Update.
4378 (init_syscalls_info): Update.
4379
9224a013
CB
43802019-09-11 Christian Biesinger <cbiesinger@google.com>
4381
4382 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4383 out of get_init_files.
4384 (get_init_files): Update.
4385
f48cd836
CB
43862019-09-11 Christian Biesinger <cbiesinger@google.com>
4387
4388 * main.c (get_init_files): Change to use std::string.
4389 (captured_main_1): Update.
4390 (print_gdb_help): Update.
4391
9cab7ecd
AT
43922019-09-11 Ali Tamur <tamur@google.com>
4393
4394 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4395 implementation.
4396
67547d89
CB
43972019-09-11 Christian Biesinger <cbiesinger@google.com>
4398
4399 * dbxread.c (read_dbx_symtab): Update.
4400 * dwarf2read.c (load_partial_dies): Update.
4401 * mdebugread.c (parse_partial_symbols): Update.
4402 (handle_psymbol_enumerators): Update.
4403 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4404 * psymtab.c (add_psymbol_to_bcache): Likewise.
4405 (add_psymbol_to_list): Likewise.
4406 * symtab.c (symbol_set_names): Likewise.
4407 * symtab.h (symbol_set_names): Likewise.
4408 * xcoffread.c (scan_xcoff_symtab): Update.
4409
64b2d4a0
TT
44102019-09-11 Tom Tromey <tom@tromey.com>
4411
4412 * symfile-mem.c (symbol_file_add_from_memory): Use
4413 bfd_set_filename.
4414 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4415 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4416
3b00ef10
TT
44172019-09-10 Tom Tromey <tromey@adacore.com>
4418
4419 * dwarf-index-write.c (write_psymbols): Extend error message.
4420 (debug_names::insert): Add Ada code.
4421 (debug_names::write_psymbols): Remove Ada check.
4422 (debug_names) <m_string_obstack>: New member.
4423 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4424 (gdb_index_symbol_name_matcher::matches): Remove.
4425 (mapped_index_base::find_name_components_bounds): Add "lang"
4426 parameter.
4427 (mapped_index_base::build_name_components): Also split names
4428 according to Ada syntax.
4429 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4430 type of "match_callback".
4431 (check_match, check_find_bounds_finds)
4432 (dw2_expand_symtabs_matching): Update.
4433 (dw2_debug_names_iterator): Add new constructor.
4434 (dw2_debug_names_map_matching_symbols): New function.
4435 (dw2_debug_names_expand_symtabs_matching): Update.
4436 (dwarf2_debug_names_functions): Use
4437 dw2_debug_names_map_matching_symbols.
4438
aa391654
TT
44392019-09-10 Tom Tromey <tromey@adacore.com>
4440
4441 * dwarf2read.c (dw2_get_file_names_reader): Add the
4442 CU's file name to the results.
4443
b054970d
TT
44442019-09-10 Tom Tromey <tromey@adacore.com>
4445
4446 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4447 map_matching_symbols. Update.
4448 * dwarf2read.c (dw2_map_matching_symbols): Update.
4449 * psymtab.c (match_partial_symbol): Change type; update.
4450 (psym_map_matching_symbols): Likewise.
4451 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4452 type; update.
4453 * symfile.h (struct quick_symbol_functions)
4454 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4455 Remove "match".
4456
6a3dbf1b
TT
44572019-09-10 Tom Tromey <tromey@adacore.com>
4458
4459 * psymtab.c (map_block): Remove.
4460 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4461 * symtab.c (iterate_over_symbols_terminated): New function.
4462 * symtab.c (iterate_over_symbols_terminated): Declare.
4463
6969f124
TT
44642019-09-10 Tom Tromey <tromey@adacore.com>
4465
4466 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4467 * language.h (struct language_defn) <la_iterate_over_symbols>:
4468 Return bool.
4469 * symtab.c (iterate_over_symbols): Return bool.
4470 * symtab.h (iterate_over_symbols): Return bool.
4471
199b4314
TT
44722019-09-10 Tom Tromey <tromey@adacore.com>
4473
4474 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4475 (add_nonlocal_symbols): Update.
4476 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4477 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4478 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4479 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4480 Change type of "callback". Remove "data".
4481
a084a2a6
AT
4482
44832019-09-09 Ali Tamur <tamur@google.com>
4484
4485 * dwarf2read.c (comp_unit_head): Update comment.
4486 (dwarf2_dwo_name): New function declaration.
4487 (dwarf_unit_type_name): New function declaration.
4488 (read_comp_unit_head): Add support for new compilation units,
4489 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4490 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4491 (currently named as "signature") in their header. Also clarify error
4492 messages.
4493 (lookup_dwo_id): New function. Returns the dwo id of the given
4494 compile unit.
4495 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4496 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4497 functions.
4498 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4499 (dwarf2_dwo_name): Get the dwo name if present.
4500 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4501 purposes.
4502
25a2915e
TT
45032019-09-09 Tom Tromey <tom@tromey.com>
4504
4505 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4506
e4df0874
PW
45072019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4508
4509 * python/python.c (do_start_initialization): Make progname_copy static,
4510 to avoid a leak report.
4511
8634b462
TT
45122019-09-08 Tom Tromey <tom@tromey.com>
4513
4514 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4515
c7f839cb
SM
45162019-09-07 Simon Marchi <simon.marchi@efficios.com>
4517
4518 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4519 Change type to gdb::optional<block_enum>.
4520 (dw2_symtab_iter_init): Change block_index parameter type
4521 to gdb::optional<block_enum>.
4522 (dw2_lookup_symbol): Change block_index parameter
4523 type to block_enum.c
4524 (dw2_debug_names_lookup_symbol): Likewise.
4525 * psymtab.c (psym_lookup_symbol): Likewise.
4526 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4527 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4528 Likewise.
4529
ead0e69a
CB
45302019-09-06 Christian Biesinger <cbiesinger@google.com>
4531
4532 * defs.h (relocate_gdb_directory): Change int to bool in
4533 signature and rename flag to relocatable.
4534 * main.c (relocate_path): Likewise.
4535 (relocate_gdb_directory): Likewise.
4536
b16c44de
AM
45372019-09-06 Alan Modra <amodra@gmail.com>
4538
4539 * coffread.c (coff_symfile_read): Constify filename variable.
4540 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4541 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4542 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4543 * solib.c (reload_shared_libraries_1): Likewise.
4544 * symfile.c (reread_symbols): Likewise.
4545 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4546 * solib-darwin.c (darwin_bfd_open): Likewise.
4547 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4548
06ff036e
AB
45492019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4550
4551 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4552 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4553
4e962e74
TT
45542019-09-03 Tom Tromey <tromey@adacore.com>
4555
4556 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4557 types.
4558 (has_negatives): Unbias a range type bound.
4559 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4560 * gdbtypes.c (operator==): Handle new field.
4561 (create_range_type): Add "bias" parameter.
4562 (create_static_range_type, resolve_dynamic_range): Update.
4563 * gdbtypes.h (struct range_bounds) <bias>: New member.
4564 (create_range_type): Add bias parameter.
4565 * printcmd.c (print_scalar_formatted): Unbias range types.
4566 * value.c (unpack_long): Unbias range types.
4567 (pack_long): Bias range types.
4568
d90b8f26
AH
45692019-09-02 Alan Hayward <alan.hayward@arm.com>
4570
4571 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4572 probe arguments.
4573
fe01123e
AH
45742019-09-02 Alan Hayward <alan.hayward@arm.com>
4575
4576 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4577 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4578 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4579 (compile_probe_arg): Likewise.
4580 * probe.h (get_argument_count): Likewise.
4581 * solib-svr4.c (solib_event_probe_action): Likewise.
4582 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4583
e661ef01
AH
45842019-09-02 Alan Hayward <alan.hayward@arm.com>
4585
4586 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4587 code to here...
4588 (svr4_create_solib_event_breakpoints): ...from here.
4589
47a536d9
SDJ
45902019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4591
4592 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4593 suffix from warning message.
4594
d6a00eba
TT
45952019-08-30 Tom Tromey <tom@tromey.com>
4596
4597 * tui/tui-winsource.h (struct tui_source_window_base)
4598 <refresh_all>: Don't declare.
4599 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4600 Remove.
4601 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4602 tui_show_locator_content.
4603 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4604 declare.
4605 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4606 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4607 declare.
4608
55b2657b
TT
46092019-08-30 Tom Tromey <tom@tromey.com>
4610
4611 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4612
12a8555a
TT
46132019-08-30 Tom Tromey <tom@tromey.com>
4614
4615 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4616 Remove unnecessary forward declarations.
4617
900ac242
TT
46182019-08-30 Tom Tromey <tom@tromey.com>
4619
4620 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4621 rerender.
4622 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4623 tui_show_locator_content.
4624
99ab33fb
TT
46252019-08-30 Tom Tromey <tom@tromey.com>
4626
4627 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4628 (tui_locator_window::rerender): Rewrite using body of previous
4629 tui_show_locator_content.
4630
e594a5d1
TT
46312019-08-30 Tom Tromey <tom@tromey.com>
4632
4633 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4634 set_locator_fullname>: New methods.
4635 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4636 Rename from tui_set_locator_fullname.
4637 (tui_locator_window::set_locator_info): Rename from
4638 tui_set_locator_info. Return bool.
4639 (tui_update_locator_fullname, tui_show_frame_info): Update.
4640
715bb467
TT
46412019-08-30 Tom Tromey <tom@tromey.com>
4642
4643 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4644
772f3f03
TT
46452019-08-30 Tom Tromey <tom@tromey.com>
4646
4647 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4648 call touchwin.
4649
108e13ab
TT
46502019-08-30 Tom Tromey <tom@tromey.com>
4651
4652 * tui/tui-wingeneral.c (box_win): Assume win_info and
4653 win_info->handle cannot be NULL.
4654
cdaa6eb4
TT
46552019-08-30 Tom Tromey <tom@tromey.com>
4656
4657 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4658 refresh_window>: Declare.
4659 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4660 resize.
4661 (tui_data_item_window::rerender): Rename from
4662 tui_display_register.
4663 (tui_data_item_window::refresh_window): New method.
4664 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4665 no-op.
4666
89df7f90
TT
46672019-08-30 Tom Tromey <tom@tromey.com>
4668
4669 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4670 regs_column_count, current_group>: Move later. Now private.
4671 <get_current_group>: New method.
4672 * tui/tui-regs.c (tui_reg_command): Update.
4673 * tui/tui-layout.c (tui_set_layout): Update.
4674
1bf2866a
TT
46752019-08-30 Tom Tromey <tom@tromey.com>
4676
4677 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4678 (tui_data_window::rerender): Don't call
4679 check_and_display_highlight_if_needed.
4680 (tui_data_window::refresh_all): Remove call to
4681 erase_data_content.
4682
0670413d
TT
46832019-08-30 Tom Tromey <tom@tromey.com>
4684
4685 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4686 (tui_data_window::display_registers_from)
4687 (tui_data_window::display_reg_element_at_line)
4688 (tui_data_window::display_registers_from_line): Remove checks of
4689 "empty".
4690
18bb55c7
TT
46912019-08-30 Tom Tromey <tom@tromey.com>
4692
4693 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4694 Don't declare.
4695 * tui/tui-regs.c (tui_data_window::show_registers): Call
4696 rerender.
4697 (tui_data_window::rerender): Rename from display_all_data.
4698 (tui_data_window::rerender): Remove old implementation.
4699
1f6d2f10
TT
47002019-08-30 Tom Tromey <tom@tromey.com>
4701
4702 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4703 text.
4704 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4705
16d01f9c
BW
47062019-08-29 Bernhard Wodok <barto@gmx.net>
4707 Sergio Durigan Junior <sergiodj@redhat.com>
4708
4709 PR win32/24284
4710 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4711
d8f27c60
AB
47122019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4713
4714 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4715 when searching for types.
4716
1f20c35e
AB
47172019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4718
4719 * f-lang.c (f_language_defn): Use f_print_typedef.
4720 * f-lang.h (f_print_typedef): Declare.
4721 * f-typeprint.c (f_print_typedef): Define.
4722
550105b7
CB
47232019-08-27 Christian Biesinger <cbiesinger@google.com>
4724
4725 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4726
4acfdd20
AB
47272019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4728
4729 * cli/cli-utils.c (info_print_options_defs): Delete.
4730 (make_info_print_options_def_group): Delete.
4731 (extract_info_print_options): Delete.
4732 (info_print_command_completer): Delete.
4733 (info_print_args_help): Add extra parameter, and optionally
4734 include text about -n flag.
4735 * cli/cli-utils.h (struct info_print_options): Delete.
4736 (extract_info_print_options): Delete declaration.
4737 (info_print_command_completer): Delete declaration.
4738 (info_print_args_help): Add extra parameter, extend header
4739 comment.
4740 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4741 search_symbols.
4742 * stack.c (struct info_print_options): New type.
4743 (info_print_options_defs): New file scoped variable.
4744 (make_info_print_options_def_group): New static function.
4745 (info_print_command_completer): New static function.
4746 (info_locals_command): Update to use new local functions.
4747 (info_args_command): Likewise.
4748 (_initialize_stack): Add extra parameter to calls to
4749 info_print_args_help.
4750 * symtab.c (search_symbols): Add extra parameter, use this to
4751 possibly excluse non-debug symbols.
4752 (symtab_symbol_info): Add extra parameter, which is passed on to
4753 search_symbols.
4754 (struct info_print_options): New type.
4755 (info_print_options_defs): New file scoped variable.
4756 (make_info_print_options_def_group): New static function.
4757 (info_print_command_completer): New static function.
4758 (info_variables_command): Update to use local functions, and pass
4759 extra parameter through to symtab_symbol_info.
4760 (info_functions_command): Likewise.
4761 (info_types_command): Pass additional argument through to
4762 symtab_symbol_info.
4763 (rbreak_command): Pass extra argument to search_symbols.
4764 (_initialize_symtab): Add extra arguments for calls to
4765 info_print_args_help, and update help text for 'info variables',
4766 'whereis', and 'info functions' commands.
4767 * symtab.h (search_symbols): Add extra argument to declaration.
4768 * NEWS: Mention new flags.
4769
9aa55206
CB
47702019-08-26 Christian Biesinger <cbiesinger@google.com>
4771
4772 * symtab.c (lookup_static_symbol): Call the new function (and move
4773 it down to be next to lookup_global_symbol).
4774 (struct global_sym_lookup_data): Add block_enum member and rename to...
4775 (struct global_or_static_sym_lookup_data): ...this.
4776 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4777 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4778 (lookup_symbol_global_or_static_iterator_cb): ...this.
4779 (lookup_global_or_static_symbol): New function.
4780 (lookup_global_symbol): Call new function.
4781
5c31b358
TV
47822019-08-26 Tom de Vries <tdevries@suse.de>
4783
4784 PR c++/24852
4785 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4786 when pc_probe.prob == NULL.
4787
23c13d42
SM
47882019-08-25 Simon Marchi <simon.marchi@efficios.com>
4789
4790 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4791 variable symbol_linkage to symbol_linkage_.
4792
beadd3e8
SM
47932019-08-25 Simon Marchi <simon.marchi@efficios.com>
4794
4795 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4796 represent whether the symbol is static, dynamic, or we don't
4797 know.
4798
e3ec872f
YS
47992019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4800
4801 * gdb/rx-tdep.c (rx_register_names): New.
4802 (rx_register_name): Delete.
4803 (rx_psw_type): Delete.
4804 (rx_fpsw_type): Delete.
4805 (rx_register_type): Delete.
4806 (rx_gdbarch_init): Convert target-descriptions.
4807 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4808 * gdb/features/Makefile: Add rx.xml.
4809 * gdb/features/rx.xml: New.
4810 * gdb/features/rx.c: Generated.
4811 * gdb/NEWS: Mention target description support.
4812
d0509ba4
CB
48132019-08-22 Christian Biesinger <cbiesinger@google.com>
4814
4815 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4816 *slot_ptr.
4817
2d41fa11
SDJ
48182019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4819
4820 * configure.ac: Don't check for 'dlfcn.h' (moved to
4821 gdbsupport/common.m4).
4822 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4823 'gdbsupport/'.
4824 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4825 * compile/compile-c-support.c: Include
4826 'gdbsupport/gdb-dlfcn.h'.
4827 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4828 * gdb-dlfcn.c: Move to...
4829 * gdbsupport/gdb-dlfcn.c: ... here.
4830 * gdb-dlfcn.h: Move to...
4831 * gdbsupport/gdb-dlfcn.h: ... here.
4832
de8af808
SL
48332019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4834
4835 * nios2-tdep.c (struct reg_value): Improve comments. Make
4836 the offset field signed.
4837
27204489
CB
48382019-08-22 Christian Biesinger <cbiesinger@google.com>
4839
4840 * python/lib/gdb/__init__.py (_execute_file): New function.
4841 * python/python.c (python_run_simple_file): Call gdb._execute_file
4842 on Windows.
4843
43771869
AB
48442019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4845
4846 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4847 all uses as this was never set to anything but a zero value.
4848
26c957f1
PA
48492019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4850
4851 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4852
c07aae6e
CB
48532019-08-21 Christian Biesinger <cbiesinger@google.com>
4854
4855 * tui/tui-data.h (tui_gen_win_info): Add an =default
4856 move constructor, required by some GCC versions.
4857
3960cb7a
JF
48582019-08-21 Jinke Fan <fanjinke51@yeah.net>
4859
4860 * go32-nat.c (go32_sysinfo): Add hygon_p.
4861
04c72a68
TT
48622019-08-20 Tom Tromey <tom@tromey.com>
4863
4864 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4865 line_from_reg_element_no, first_reg_element_no_inline,
4866 display_all_data, delete_data_content_windows,
4867 erase_data_content>: Now private.
4868
072272ce
TT
48692019-08-20 Tom Tromey <tom@tromey.com>
4870
4871 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4872 (tui_unhighlight_win, tui_highlight_win)
4873 (tui_win_info::make_window): Update.
4874 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4875
973961bd
TT
48762019-08-20 Tom Tromey <tom@tromey.com>
4877
4878 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4879 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4880 (MAX_PID_WIDTH): Move to tui-stack.c.
4881 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4882 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4883 (MAX_PID_WIDTH): Move from tui-data.h.
4884
ab0e1f1a
TT
48852019-08-20 Tom Tromey <tom@tromey.com>
4886
4887 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4888 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4889 (box_win): Update.
4890 (tui_gen_win_info::make_window): Rename from tui_make_window.
4891 (tui_win_info::make_window): New method.
4892 (tui_gen_win_info::make_visible): Update.
4893 * tui/tui-source.c (tui_source_window::set_contents): Update.
4894 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4895 (tui_data_window::display_registers_from): Update.
4896 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4897 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4898 Declare.
4899 <can_box>: Remove.
4900 <title>: Remove.
4901 (struct tui_win_info) <make_window>: Declare.
4902 <can_box>: Now virtual.
4903 <title>: New member.
4904 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4905 * tui/tui-command.c (tui_cmd_window::resize): Update.
4906
100c2bf3
TT
49072019-08-20 Tom Tromey <tom@tromey.com>
4908
4909 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4910 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4911 (tui_data_window::check_register_values): Update.
4912
fa4dc567
TT
49132019-08-20 Tom Tromey <tom@tromey.com>
4914
4915 * tui/tui-regs.h (struct tui_data_window): Use
4916 DISABLE_COPY_AND_ASSIGN.
4917 <regs_content>: Change type, removing unique_ptr.
4918 <tui_data_window>: Add move constructor.
4919 * tui/tui-regs.c (tui_data_window::show_registers)
4920 (tui_data_window::show_register_group)
4921 (tui_data_window::display_registers_from)
4922 (tui_data_window::display_registers_from)
4923 (tui_data_window::first_data_item_displayed)
4924 (tui_data_window::delete_data_content_windows)
4925 (tui_data_window::rerender, tui_data_window::refresh_window)
4926 (tui_data_window::check_register_values): Update.
4927
ca02d7c8
TT
49282019-08-20 Tom Tromey <tom@tromey.com>
4929
4930 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4931 show_register_group>: Declare.
4932 (tui_show_register_group): Don't declare.
4933 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4934 tui_show_registers.
4935 (tui_data_window::show_register_group): Rename from
4936 tui_show_register_group.
4937 (tui_data_window::check_register_values, tui_reg_command):
4938 Update.
4939 * tui/tui-layout.c (tui_set_layout): Update.
4940
63356bfd
TT
49412019-08-20 Tom Tromey <tom@tromey.com>
4942
4943 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4944 Declare.
4945 (tui_check_register_values): Don't declare.
4946 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4947 from tui_check_register_values.
4948 * tui/tui-hooks.c (tui_register_changed): Update.
4949
42cc14a7
TT
49502019-08-20 Tom Tromey <tom@tromey.com>
4951
4952 * tui/tui-regs.c (tui_reg_layout): Move later.
4953 (tui_show_registers): Don't enable TUI mode or change layout.
4954
b9ad3686
TT
49552019-08-20 Tom Tromey <tom@tromey.com>
4956
4957 * tui/tui-regs.h (struct tui_data_item_window)
4958 <~tui_data_item_window>: Remove.
4959 <content>: Now a unique_xmalloc_ptr.
4960 * tui/tui-regs.c (tui_register_format): Return a
4961 unique_xmalloc_ptr.
4962 (tui_get_register): Update.
4963 (~tui_data_item_window): Remove.
4964 (tui_data_window::display_registers_from, tui_display_register):
4965 Update.
4966 * tui/tui-io.h (tui_expand_tabs): Update.
4967 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4968 Remove "col" parameter.
4969
8e114aab
TT
49702019-08-20 Tom Tromey <tom@tromey.com>
4971
4972 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4973 field.
4974 * tui/tui-regs.c (~tui_data_item_window): Update.
4975
1a4f81dd
TT
49762019-08-20 Tom Tromey <tom@tromey.com>
4977
4978 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4979 earlier.
4980
0f8d8876
TT
49812019-08-20 Tom Tromey <tom@tromey.com>
4982
4983 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4984
605dc2c2
TT
49852019-08-20 Tom Tromey <tom@tromey.com>
4986
4987 * tui/tui-source.h (struct tui_source_window): Update.
4988 * tui/tui-regs.c (tui_show_registers): Update.
4989 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4990 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4991 (NO_REGS_STRING): Remove defines.
4992
aedbe3bb
CM
49932019-08-20 Conrad Meyer <cem@FreeBSD.org>
4994
4995 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4996 unnecessary thread walk if remote doesn't support the packet.
4997
7ce8f214
TT
49982019-08-19 Tom Tromey <tromey@adacore.com>
4999
5000 * python/py-value.c (value_has_field): Fix indentation.
5001
f21c2bd7
TT
50022019-08-19 Tom Tromey <tromey@adacore.com>
5003
5004 * printcmd.c (do_one_display, info_display_command): Update.
5005 * block.h (contained_in): Return bool. Add allow_nested
5006 parameter.
5007 * block.c (contained_in): Return bool. Add allow_nested
5008 parameter.
5009
d806ea2d
TT
50102019-08-19 Tom Tromey <tom@tromey.com>
5011
5012 * configure: Rebuild.
5013 * configure.ac: Disallow the combination of -static-libstdc++ and
5014 source highlight.
5015 * source-cache.c (get_language_name): Handle rust.
5016 (source_cache::get_source_lines): Ignore highlighting exceptions.
5017
398fdd60
TT
50182019-08-16 Tom Tromey <tom@tromey.com>
5019
5020 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5021 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5022 (struct tui_source_window_base) <make_visible, refresh_window,
5023 resize>: Remove methods.
5024 <execution_info>: Remove field.
5025 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5026 (tui_show_source_line, tui_source_window_base)
5027 (~tui_source_window_base): Update.
5028 (tui_source_window_base::resize)
5029 (tui_source_window_base::make_visible)
5030 (tui_source_window_base::refresh_window): Remove.
5031 (tui_source_window_base::update_exec_info): Update.
5032 * tui/tui-source.c (tui_source_window::set_contents): Update.
5033 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5034
e699d331
TT
50352019-08-16 Tom Tromey <tom@tromey.com>
5036
5037 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5038 deprecated_query_hook.
5039
bb01dbfc
TT
50402019-08-16 Tom Tromey <tom@tromey.com>
5041
5042 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5043 (tui_update_source_windows_with_line): Update.
5044 * tui/tui-source.h (struct tui_source_window)
5045 <show_symtab_source>: Declare.
5046 (tui_show_symtab_source): Don't declare.
5047 * tui/tui-source.c (tui_show_symtab_source): Rename from
5048 tui_show_symtab_source.
5049
81c82c4b
TT
50502019-08-16 Tom Tromey <tom@tromey.com>
5051
5052 * tui/tui-winsource.h (struct tui_source_window_base)
5053 <set_contents>: Declare.
5054 * tui/tui-winsource.c
5055 (tui_source_window_base::update_source_window_as_is): Update.
5056 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5057 Declare.
5058 (tui_set_source_content): Don't declare.
5059 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5060 tui_set_source_content.
5061 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5062 Declare.
5063 (tui_set_disassem_content): Don't declare.
5064 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5065 tui_set_disassem_content.
5066
2ddaf614
TT
50672019-08-16 Tom Tromey <tom@tromey.com>
5068
5069 * tui/tui-winsource.h (struct tui_source_window_base)
5070 <update_breakpoint_info>: Declare.
5071 (tui_update_breakpoint_info): Don't declare.
5072 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5073 (tui_update_all_breakpoint_info): Update.
5074 (tui_source_window_base::update_breakpoint_info): Rename from
5075 tui_update_breakpoint_info.
5076 (tui_source_window_base::update_exec_info): Update.
5077
017f9828
TT
50782019-08-16 Tom Tromey <tom@tromey.com>
5079
5080 * tui/tui-winsource.h (struct tui_source_window_base)
5081 <update_source_window>: Declare.
5082 (tui_update_source_window): Don't declare.
5083 * tui/tui-winsource.c
5084 (tui_source_window_base::update_source_window): Rename from
5085 tui_update_source_window.
5086 (tui_source_window_base::rerender): Update.
5087 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5088 * tui/tui-disasm.c (tui_show_disassem)
5089 (tui_show_disassem_and_update_source)
5090 (tui_disasm_window::maybe_update): Update.
5091
ed8358e9
TT
50922019-08-16 Tom Tromey <tom@tromey.com>
5093
5094 * tui/tui-winsource.h (struct tui_source_window_base)
5095 <update_source_window_as_is>: Declare.
5096 (tui_update_source_window_as_is): Don't declare.
5097 * tui/tui-winsource.c (tui_update_source_window): Update
5098 (tui_source_window_base::update_source_window_as_is): Rename from
5099 tui_update_source_window_as_is.
5100 (tui_source_window_base::refill): Update.
5101 * tui/tui-source.c (tui_show_symtab_source): Update.
5102 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5103 Update.
5104
20149b6b
TT
51052019-08-16 Tom Tromey <tom@tromey.com>
5106
5107 * tui/tui-winsource.h (tui_update_source_window)
5108 (tui_update_source_window_as_is): Remove "noerror" parameter.
5109 * tui/tui-winsource.c (tui_update_source_window)
5110 (tui_update_source_window_as_is): Remove "noerror" parameter.
5111 (tui_update_source_windows_with_addr)
5112 (tui_update_source_windows_with_line)
5113 (tui_source_window_base::rerender)
5114 (tui_source_window_base::refill): Update.
5115 * tui/tui-source.h (tui_set_source_content)
5116 (tui_show_symtab_source): Remove "noerror" parameter.
5117 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5118 parameter.
5119 (tui_show_symtab_source): Likewise.
5120 (tui_source_window::maybe_update): Update.
5121 * tui/tui-disasm.c (tui_show_disassem)
5122 (tui_show_disassem_and_update_source)
5123 (tui_disasm_window::do_scroll_vertical)
5124 (tui_disasm_window::maybe_update): Update.
5125
2d83e710
TT
51262019-08-16 Tom Tromey <tom@tromey.com>
5127
5128 * tui/tui.c (tui_is_window_visible): Update.
5129 * tui/tui-wingeneral.c (tui_make_window)
5130 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5131 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5132 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5133 (tui_set_win_height_command, parse_scrolling_args): Update.
5134 * tui/tui-source.c (tui_source_window::style_changed): Update.
5135 * tui/tui-regs.c (tui_show_registers)
5136 (tui_data_window::first_data_item_displayed)
5137 (tui_data_window::delete_data_content_windows)
5138 (tui_check_register_values, tui_reg_command): Update.
5139 * tui/tui-disasm.c (tui_show_disassem): Update.
5140 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5141 method.
5142 <is_visible>: Remove field.
5143 * tui/tui-data.c (tui_next_win, tui_prev_win)
5144 (tui_delete_invisible_windows): Update.
5145
d4ab829a
TT
51462019-08-16 Tom Tromey <tom@tromey.com>
5147
5148 * tui/tui-winsource.h (struct tui_source_window_base)
5149 <m_has_locator>: Remove.
5150 * tui/tui-layout.c (show_source_disasm_command, show_data)
5151 (show_source_or_disasm_and_command): Update.
5152
aa7ca1bb
AH
51532019-08-16 Alan Hayward <alan.hayward@arm.com>
5154
5155 * NEWS (Other MI changes): New subsection.
5156 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5157 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5158 * arch-utils.c (default_get_pc_address_flags): New function.
5159 * arch-utils.h (default_get_pc_address_flags): New declaration.
5160 * gdbarch.sh: Add get_pc_address_flags.
5161 * gdbarch.c: Regenerate.
5162 * gdbarch.h: Likewise.
5163 * stack.c (print_pc): New function.
5164 (print_frame_info) (print_frame): Call print_pc.
5165
6eac171f
TV
51662019-08-16 Tom de Vries <tdevries@suse.de>
5167
5168 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5169 print_objfile_section_info.
5170
3df505f6
TT
51712019-08-15 Tom Tromey <tom@tromey.com>
5172
5173 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5174 calling update_cmdwin_start_line.
5175 * tui/tui-winsource.h (struct tui_source_window_base)
5176 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5177 <rerender>: Declare.
5178 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5179 Call rerender.
5180 (tui_source_window_base::set_new_height): Remove.
5181 (tui_source_window_base::rerender): Rename from
5182 do_make_visible_with_new_height.
5183 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5184 resize method.
5185 (tui_win_info::make_invisible_and_set_new_height)
5186 (tui_win_info::make_visible_with_new_height): Remove.
5187 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5188 Declare.
5189 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5190 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5191 do_make_visible_with_new_height>: Don't declare.
5192 <rerender>: Declare.
5193 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5194 set_new_height.
5195 (tui_data_window::do_make_visible_with_new_height): Remove.
5196 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5197 call tui_show_locator_content.
5198 (tui_gen_win_info::resize): Call rerender.
5199 (show_source_or_disasm_and_command): Don't call
5200 tui_show_locator_content.
5201 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5202 method.
5203 (struct tui_win_info) <rerender>: Declare.
5204 <set_new_height, make_invisible_and_set_new_height,
5205 make_visible_with_new_height>: Don't declare.
5206 * tui/tui-data.c (tui_win_list::rerender): New method.
5207 * tui/tui-command.h (struct tui_cmd_window)
5208 <do_make_visible_with_new_height>: Don't declare.
5209 * tui/tui-command.c
5210 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5211
272560b5
TT
52122019-08-15 Tom Tromey <tromey@adacore.com>
5213
5214 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5215 * ada-lang.c (ada_enum_name): Likewise.
5216
08235187
CB
52172019-08-15 Christian Biesinger <cbiesinger@google.com>
5218
5219 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5220 leading underscore.
5221 (GdbOutputErrorFile): Likewise.
5222 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5223 accordingly.
5224 (execute_unwinders): Rename to have a leading underscore.
5225 (auto_load_packages): Likewise.
5226 (global scope): Adjust call to auto_load_packages accordingly.
5227 (GdbSetPythonDirectory): Likewise.
5228 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5229 instead of execute_unwinders.
5230
db502012
TT
52312019-08-15 Tom Tromey <tom@tromey.com>
5232
5233 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5234 (show_data): Don't change window visibility.
5235 (tui_gen_win_info::resize): Remove special case for command
5236 window. Use wresize, when available.
5237 (show_source_or_disasm_and_command): Don't change window
5238 visibility.
5239 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5240 <make_visible>: New method.
5241 * tui/tui-command.c (tui_cmd_window::resize): New method.
5242
3891b65e
TT
52432019-08-15 Tom Tromey <tom@tromey.com>
5244
5245 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5246 (struct tui_source_windows): New.
5247 * tui/tui-winsource.c (tui_display_main): Update.
5248 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5249 (new_height_ok, parse_scrolling_args): Update.
5250 * tui/tui-layout.c (show_layout, show_data): Update.
5251 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5252 (tui_add_to_source_windows): Don't declare.
5253 * tui/tui-data.c (source_windows, tui_source_windows)
5254 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5255
ee556432
TT
52562019-08-15 Tom Tromey <tom@tromey.com>
5257
5258 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5259 Rename from reset.
5260 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5261 * tui/tui-layout.c (show_source_disasm_command, show_data):
5262 Update.
5263 (tui_gen_win_info::resize): Rename.
5264 (show_source_or_disasm_and_command): Update.
5265 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5266 reset.
5267
46f438e3
TT
52682019-08-15 Tom Tromey <tom@tromey.com>
5269
5270 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5271 * tui/tui-interp.c (tui_interp::init): Don't call
5272 tui_initialize_static_data.
5273 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5274
f4ce562c
TT
52752019-08-15 Tom Tromey <tom@tromey.com>
5276
5277 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5278 examine tui_win_list.
5279
c398c3d0
TT
52802019-08-15 Tom Tromey <tom@tromey.com>
5281
5282 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5283 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5284 tui_clear_source_content.
5285 (tui_clear_source_content): Remove.
5286 (tui_source_window_base::do_erase_source_content): Hoist call to
5287 content.clear().
5288 * tui/tui-stack.c (tui_show_frame_info): Don't call
5289 tui_clear_source_content.
5290
e25d2004
TT
52912019-08-15 Tom Tromey <tom@tromey.com>
5292
5293 * tui/tui-winsource.h (struct tui_source_window_base)
5294 <do_erase_source_content>: New method.
5295 <erase_source_content>: New method.
5296 (tui_erase_source_content): Don't declare.
5297 * tui/tui-winsource.c (tui_clear_source_content): Update.
5298 (tui_source_window_base::do_erase_source_content): Rename from
5299 tui_erase_source_content.
5300 (tui_source_window_base::show_source_content): Update.
5301 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5302 * tui/tui-source.h (struct tui_source_window)
5303 <erase_source_content>: New method.
5304 * tui/tui-disasm.h (struct tui_disasm_window)
5305 <erase_source_content>: New method.
5306
002f15c2
TT
53072019-08-15 Tom Tromey <tom@tromey.com>
5308
5309 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5310 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5311 constructor.
5312 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5313 * tui/tui-source.c (tui_set_source_content): Update.
5314 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5315
c9033fe8
TT
53162019-08-15 Tom Tromey <tom@tromey.com>
5317
5318 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5319 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5320 tui-source.c.
5321 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5322 Declare.
5323 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5324 method.
5325 (tui_source_window::maybe_update): Update.
5326
088f37dd
TT
53272019-08-15 Tom Tromey <tom@tromey.com>
5328
5329 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5330 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5331 tui-disasm.c.
5332 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5333 Declare.
5334 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5335 method.
5336 (tui_disasm_window::maybe_update): Update.
5337
a54700c6
TT
53382019-08-15 Tom Tromey <tom@tromey.com>
5339
5340 * tui/tui-winsource.h (struct tui_source_window_base)
5341 <maybe_update>: Declare.
5342 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5343 method.
5344 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5345 Declare.
5346 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5347 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5348 Declare.
5349 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5350
e2a678a5
TT
53512019-08-15 Tom Tromey <tom@tromey.com>
5352
5353 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5354
f2dda477
TT
53552019-08-15 Tom Tromey <tom@tromey.com>
5356
5357 * tui/tui-wingeneral.c: Include tui-stack.h.
5358 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5359 (struct tui_locator_window): Move from tui-data.h.
5360 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5361 (tui_initialize_static_data): Move from tui-data.c.
5362 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5363 (struct tui_locator_window): Move to tui-stack.c.
5364 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5365 (tui_initialize_static_data): Move to tui-stack.c.
5366
ed4a1084
TT
53672019-08-15 Tom Tromey <tom@tromey.com>
5368
5369 * tui/tui-layout.c (show_source_disasm_command)
5370 (show_source_or_disasm_and_command): Use make_visible method, not
5371 tui_make_window.
5372 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5373 Remove.
5374
65962b20
TT
53752019-08-15 Tom Tromey <tom@tromey.com>
5376
5377 * tui/tui-wingeneral.h (tui_make_window): Update.
5378 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5379 parameter.
5380 (tui_gen_win_info::make_visible): Update.
5381 * tui/tui-regs.c (tui_data_window::display_registers_from):
5382 Update.
5383 * tui/tui-layout.c (show_source_disasm_command)
5384 (show_source_or_disasm_and_command): Update.
5385 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5386 (enum tui_box): Remove.
5387 (struct tui_win_info) <can_box>: New method.
5388 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5389 method.
5390
2208ee91
TV
53912019-08-15 Tom de Vries <tdevries@suse.de>
5392
5393 * linux-nat-trad.c: Include gdbarch.h.
5394
75faf5c4
AH
53952019-08-14 Alan Hayward <alan.hayward@arm.com>
5396
5397 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5398 register sizes.
5399
b1c896b3
TT
54002019-08-14 Tom Tromey <tromey@adacore.com>
5401
5402 * darwin-nat.c: Include gdbarch.h.
5403 * darwin-nat-info.c: Include gdbarch.h.
5404
6405cd73
TT
54052019-08-13 Tom Tromey <tom@tromey.com>
5406
5407 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5408 Remove.
5409 * tui/tui-data.c (tui_initialize_static_data): Update.
5410
5216580d
TT
54112019-08-13 Tom Tromey <tom@tromey.com>
5412
5413 * tui/tui-winsource.h (struct tui_exec_info_window)
5414 <~tui_exec_info_window, maybe_allocate_content, get_content,
5415 m_content>: Remove.
5416 (struct tui_source_window_base) <set_exec_info_content,
5417 show_exec_info_content>: Don't declare.
5418 * tui/tui-winsource.c
5419 (tui_exec_info_window::maybe_allocate_content): Remove.
5420 (tui_source_window_base::update_exec_info): Rename from
5421 set_exec_info_content.
5422 (tui_source_window_base::show_exec_info_content)
5423 (tui_source_window_base::update_exec_info): Remove.
5424
93858ad3
TT
54252019-08-13 Tom Tromey <tom@tromey.com>
5426
5427 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5428 declare.
5429 * tui/tui-winsource.c (tui_update_source_window_as_is)
5430 (tui_update_source_windows_with_addr, tui_erase_source_content):
5431 Update.
5432 (tui_clear_exec_info_content): Remove.
5433
e321e7ce
TT
54342019-08-13 Tom Tromey <tom@tromey.com>
5435
5436 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5437 declare.
5438 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5439 call tui_erase_exec_info_content.
5440 (tui_clear_exec_info_content): Rename from
5441 tui_erase_exec_info_content.
5442 (tui_clear_exec_info_content): Delete.
5443
8270ac62
TT
54442019-08-13 Tom Tromey <tom@tromey.com>
5445
5446 * tui/tui-winsource.h (struct tui_source_window_base)
5447 <show_exec_info_content>: Declare.
5448 (tui_show_exec_info_content): Don't declare.
5449 * tui/tui-winsource.c
5450 (tui_source_window_base::show_exec_info_content): Rename from
5451 tui_show_exec_info_content.
5452 (tui_source_window_base::update_exec_info): Update.
5453
7b56485d
TT
54542019-08-13 Tom Tromey <tom@tromey.com>
5455
5456 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5457 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5458 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5459 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5460 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5461 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5462 ... here.
5463
7ba913dc
TT
54642019-08-13 Tom Tromey <tom@tromey.com>
5465
5466 * tui/tui-winsource.h (struct tui_source_window_base)
5467 <update_exec_info>: Declare.
5468 (tui_update_exec_info): Don't declare.
5469 * tui/tui-winsource.c (tui_update_source_window_as_is)
5470 (tui_source_window_base::refresh_all)
5471 (tui_update_all_breakpoint_info): Update.
5472 (tui_source_window_base::update_exec_info): Rename from
5473 tui_update_exec_info.
5474 * tui/tui-stack.c (tui_show_frame_info): Update.
5475
37a4a131
TT
54762019-08-13 Tom Tromey <tom@tromey.com>
5477
5478 * tui/tui-winsource.h (struct tui_source_window_base)
5479 <set_exec_info_content>: Declare.
5480 (tui_set_exec_info_content): Don't declare.
5481 * tui/tui-winsource.c
5482 (tui_source_window_base::set_exec_info_content): Rename from
5483 tui_set_exec_info_content.
5484 (tui_update_exec_info): Update.
5485
0bd27e07
TT
54862019-08-13 Tom Tromey <tom@tromey.com>
5487
5488 * tui/tui-winsource.h (struct tui_source_window_base)
5489 <show_source_content>: Declare.
5490 (tui_show_source_content): Don't declare.
5491 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5492 (tui_source_window_base::show_source_content): Rename from
5493 tui_show_source_content.
5494 (tui_source_window_base::refresh_all): Update.
5495 * tui/tui-layout.c (show_source_disasm_command)
5496 (show_source_or_disasm_and_command): Update.
5497
b4ef5aeb
TT
54982019-08-13 Tom Tromey <tom@tromey.com>
5499
5500 * tui/tui-winsource.c (tui_erase_source_content)
5501 (tui_show_source_content, tui_source_window_base::refresh_all):
5502 Update.
5503 * tui/tui-wingeneral.h
5504 (tui_check_and_display_highlight_if_needed): Don't declare.
5505 * tui/tui-wingeneral.c
5506 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5507 check_and_display_highlight_if_needed.
5508 * tui/tui-win.c (tui_rehighlight_all)
5509 (tui_win_info::make_visible_with_new_height): Update.
5510 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5511 (tui_data_window::erase_data_content)
5512 (tui_data_window::display_all_data): Update.
5513 * tui/tui-data.h (struct tui_win_info)
5514 <check_and_display_highlight_if_needed>: Declare.
5515
fede5273
TT
55162019-08-13 Tom Tromey <tom@tromey.com>
5517
5518 * tui/tui-win.c (tui_resize_all): Call
5519 tui_delete_invisible_windows.
5520 * tui/tui-layout.c (show_layout): Call
5521 tui_delete_invisible_windows.
5522 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5523 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5524
22c3f490
TT
55252019-08-13 Tom Tromey <tom@tromey.com>
5526
5527 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5528 tui_add_win_to_layout.
5529
16cb7910
TT
55302019-08-13 Tom Tromey <tom@tromey.com>
5531
5532 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5533 * tui/tui-layout.c (tui_default_win_height): Now static.
5534
cc0c3ffb
TT
55352019-08-13 Tom Tromey <tom@tromey.com>
5536
5537 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5538 single switch.
5539 (show_source_disasm_command, show_source_or_disasm_and_command):
5540 Don't check current layout.
5541
3f3ffe54
TT
55422019-08-13 Tom Tromey <tom@tromey.com>
5543
5544 * tui/tui-wingeneral.c (make_all_visible): Remove.
5545 (tui_make_all_invisible): Simplify.
5546 * tui/tui-layout.c (tui_make_all_invisible): Move from
5547 tui-wingeneral.c; simplify.
5548 (show_layout): Hoist call to tui_make_all_invisible.
5549 (show_data): Don't call tui_make_all_invisible.
5550
69258091
TT
55512019-08-13 Tom Tromey <tom@tromey.com>
5552
5553 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5554 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5555
62cf57fe
TT
55562019-08-13 Tom Tromey <tom@tromey.com>
5557
5558 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5559 tui-data.c.
5560 (show_source_disasm_command, show_data)
5561 (show_source_or_disasm_and_command): Don't use
5562 tui_set_current_layout_to.
5563 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5564 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5565 tui-layout.c.
5566 (tui_set_current_layout_to): Remove.
5567
2afade5d
TT
55682019-08-13 Tom Tromey <tom@tromey.com>
5569
5570 * tui/tui-layout.c (tui_set_layout): Update.
5571 * tui/tui-data.h (struct tui_layout_def): Remove.
5572 (tui_layout_def): Don't declare.
5573 * tui/tui-data.c (layout_def): Remove.
5574 (tui_layout_def): Remove.
5575
a3504e96
TT
55762019-08-13 Tom Tromey <tom@tromey.com>
5577
5578 * tui/tui-winsource.h (struct tui_source_window_base)
5579 <clear_detail>: No longer "override".
5580 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5581 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5582 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5583 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5584 Remove.
5585 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5586
29c92911
TT
55872019-08-13 Tom Tromey <tromey@adacore.com>
5588
5589 * tracepoint.c: Don't include readline.h or history.h.
5590
86c6b807
TT
55912019-08-12 Tom Tromey <tom@tromey.com>
5592
5593 * configure: Rebuild.
5594 * configure.ac: Check for readline 7.
5595 * NEWS: Mention readline 7 requirement.
5596 * README: Update.
5597
5db2718c
TT
55982019-08-12 Tom Tromey <tom@tromey.com>
5599
5600 * mingw-hdep.c (gdb_select): Remove readline hack.
5601
dac36daf
PFC
56022019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5603
5604 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5605 when the function fails.
5606
1022c627
AA
56072019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5608
5609 * s390-tdep.c (s390_type_align): New function.
5610 (s390_gdbarch_init): Set it as type_align gdbarch method.
5611
eba4caf2
TV
56122019-08-09 Tom de Vries <tdevries@suse.de>
5613
5614 PR gdb/24591
5615 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5616 pc_low with relocation offset.
5617
123cd851
TT
56182019-08-07 Tom Tromey <tromey@adacore.com>
5619
5620 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5621 (print_frame_args): Update.
5622 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5623 Update.
5624 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5625 * frame.h (struct frame_arg): Add initializers.
5626 <error>: Now a unique_xmalloc_ptr.
5627
3d31bc39
AH
56282019-08-07 Alan Hayward <alan.hayward@arm.com>
5629
5630 * NEWS: Expand the Pointer Authentication entry.
5631 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5632 (aarch64_frame_unmask_lr): ... to this.
5633 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5634 Call aarch64_frame_unmask_lr.
5635 * frame.c (struct frame_info): Add "masked" variable.
5636 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5637 (fprint_frame): Check for masked pc.
5638 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5639 declarations.
5640 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5641 * stack.c (print_frame): Check for masked pc.
5642
0cf9feb9
TT
56432019-08-06 Tom Tromey <tom@tromey.com>
5644
5645 * stabsread.c (patch_block_stabs, read_one_struct_field)
5646 (read_enum_type): Use obstack_strndup.
5647 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5648 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5649 * dwarf2read.c (guess_full_die_structure_name)
5650 (anonymous_struct_prefix): Use obstack_strndup.
5651 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5652 * c-exp.y (yylex): Use obstack_strndup.
5653 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5654 (write_var_or_type): Use obstack_strndup.
5655
efba19b0
TT
56562019-08-06 Tom Tromey <tom@tromey.com>
5657
5658 * symfile.c (reread_symbols): Use obstack_strdup.
5659 * stabsread.c (read_type): Use obstack_strdup.
5660 * gdb_obstack.h (obstack_strdup): New overload.
5661 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5662 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5663 (dwarf2_canonicalize_name): Use obstack_strdup.
5664 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5665 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5666 Use obstack_strdup.
5667
f25102f7
TT
56682019-08-06 Tom Tromey <tom@tromey.com>
5669
5670 * gdb_obstack.h (obstack_strdup): Define.
5671 * gdb_obstack.c (obstack_strdup): Don't define.
5672
021887d8
TT
56732019-08-06 Tom Tromey <tom@tromey.com>
5674
5675 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5676 obstack_strdup.
5677 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5678 obstack_strdup.
5679 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5680 * stabsread.c (common_block_start): Use obstack_strdup.
5681 * objfiles.c (set_objfile_main_name, objfile): Use
5682 obstack_strdup.
5683 * namespace.c (add_using_directive): Use obstack_strdup.
5684 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5685 * jit.c (finalize_symtab): Use obstack_strdup.
5686 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5687 (guess_partial_die_structure_name, partial_die_info::fixup)
5688 (dwarf2_name): Use obstack_strdup.
5689 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5690 obstack_strdup.
5691 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5692 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5693 obstack_strdup.
5694 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5695
d2834edc
PW
56962019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5697
5698 * unittests/help-doc-selftests.c: New file.
5699 * Makefile.in: Add the new file.
5700
590042fc
PW
57012019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5702
5703 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5704 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5705 the full first line, except when FOR_VALUE_PREFIX. In this case,
5706 the trailing '.' is not output, and the first character is uppercased.
5707 (print_help_for_command): Update call to print_doc_line.
5708 (print_doc_of_command): Likewise.
5709 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5710 * cli/cli-option.c (append_indented_doc): Do not append newline.
5711 (build_help_option): Append newline after first appended_indented_doc
5712 only if a second call is done.
5713 (build_help): Append 2 new lines before each option, except the first
5714 one.
5715 * compile/compile.c (_initialize_compile): Add new lines after
5716 %OPTIONS%, when not at the end of the help.
5717 Change help doc or code
5718 producing the help doc to respect the invariants.
5719 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5720 Also removed the new line after 'Options:', as all other commands
5721 do not put an empty line between 'Options:' and the first option.
5722 * printcmd.c (_initialize_printcmd): Likewise.
5723 * stack.c (_initialize_stack): Likewise.
5724 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5725 incorrectly telling COMMAND is optional.
5726 * ada-lang.c (_initialize_ada_language): Change help doc or code
5727 producing the help doc to respect the invariants.
5728 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5729 * breakpoint.c (_initialize_breakpoint): Likewise.
5730 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5731 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5732 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5733 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5734 _initialize_cli_style): Likewise.
5735 * corelow.c (core_target_info): Likewise.
5736 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5737 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5738 * filesystem.c (_initialize_filesystem): Likewise.
5739 * frame.c (_initialize_frame): Likewise.
5740 * gnu-nat.c (add_task_commands): Likewise.
5741 * infcall.c (_initialize_infcall): Likewise.
5742 * infcmd.c (_initialize_infcmd): Likewise.
5743 * interps.c (_initialize_interpreter): Likewise.
5744 * language.c (_initialize_language): Likewise.
5745 * linux-fork.c (_initialize_linux_fork): Likewise.
5746 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5747 * maint.c (_initialize_maint_cmds): Likewise.
5748 * memattr.c (_initialize_mem): Likewise.
5749 * printcmd.c (_initialize_printcmd): Likewise.
5750 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5751 _RegEx): Likewise.
5752 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5753 * record-btrace.c (_initialize_record_btrace): Likewise.
5754 * record-full.c (_initialize_record_full): Likewise.
5755 * record.c (_initialize_record): Likewise.
5756 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5757 * regcache.c (_initialize_regcache): Likewise.
5758 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5759 _initialize_remote): Likewise.
5760 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5761 * serial.c (_initialize_serial): Likewise.
5762 * skip.c (_initialize_step_skip): Likewise.
5763 * source.c (_initialize_source): Likewise.
5764 * stack.c (_initialize_stack): Likewise.
5765 * symfile.c (_initialize_symfile): Likewise.
5766 * symtab.c (_initialize_symtab): Likewise.
5767 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5768 * top.c (init_main): Likewise.
5769 * tracefile-tfile.c (tfile_target_info): Likewise.
5770 * tracepoint.c (_initialize_tracepoint): Likewise.
5771 * tui/tui-win.c (_initialize_tui_win): Likewise.
5772 * utils.c (add_internal_problem_command): Likewise.
5773 * valprint.c (value_print_option_defs): Likewise.
5774
404f2902
FCE
57752019-08-06 Frank Ch. Eigler <fche@redhat.com>
5776
5777 PR build/24886
5778 * configure.ac: Drop enable-libmcheck support.
5779 * configure, config.in: Rebuild.
5780 * libmcheck.m4: Remove.
5781 * acinclude.m4: Don't include it.
5782 * Makefile.in: Don't distribute it.
5783 * top.c (print_gdb_configuration): Don't mention it.
5784
046bebe1
TT
57852019-08-06 Tom Tromey <tom@tromey.com>
5786
5787 * utils.c (set_output_style): Sometimes pass stream to
5788 emit_style_escape.
5789 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5790 * record-btrace.c (btrace_insn_history): Update.
5791 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5792 method.
5793 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5794 Update initializers.
5795 <m_uiout>: New field.
5796 <m_di>: Move lower.
5797 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5798 Remove "uiout" parameter.
5799 (dump_insns): Update.
5800 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5801 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5802
ddbcedf5
CB
58032019-08-06 Christian Biesinger <cbiesinger@google.com>
5804
5805 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5806 (error_in_psymtab_expansion): Likewise.
5807 (lookup_symbol_via_quick_fns): Likewise.
5808 (basic_lookup_transparent_type_quick): Likewise.
5809 (basic_lookup_transparent_type_1): Likewise.
5810
b08b16c8
TT
58112019-08-06 Tom Tromey <tromey@adacore.com>
5812
5813 * source.c (last_source_error): Now bool.
5814 (print_source_lines_base): Make "noprint" bool. Only open
5815 source file when last_source_visited changes.
5816
cb44333d
TT
58172019-08-06 Tom Tromey <tromey@adacore.com>
5818
5819 * annotate.c (annotate_source_line): Use g_source_cache.
5820 * source-cache.c (source_cache::get_plain_source_lines): Change
5821 parameters. Populate m_offset_cache.
5822 (source_cache::ensure): New method.
5823 (source_cache::get_line_charpos): New method.
5824 (extract_lines): Move lower. Change parameters.
5825 (source_cache::get_source_lines): Move lower.
5826 * source-cache.h (class source_cache): Update comment.
5827 <get_line_charpos>: New method.
5828 <get_source_lines>: Update comment.
5829 <clear>: Clear m_offset_cache.
5830 <get_plain_source_lines>: Change parameters.
5831 <ensure>: New method
5832 <m_offset_cache>: New member.
5833 * source.c (forget_cached_source_info_for_objfile): Update.
5834 (info_source_command): Use g_source_cache.
5835 (find_source_lines, open_source_file_with_line_charpos): Remove.
5836 (print_source_lines_base, search_command_helper): Use g_source_cache.
5837 * source.h (open_source_file_with_line_charpos): Don't declare.
5838 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5839 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5840 Use g_source_cache.
5841
872dceaa
TT
58422019-08-06 Tom Tromey <tromey@adacore.com>
5843
5844 * source-cache.c (source_cache::get_plain_source_lines):
5845 Remove "first_line" and "last_line" parameters.
5846 (source_cache::get_source_lines): Cache plain text.
5847 * source-cache.h (class source_cache)
5848 <get_plain_source_lines>: Update.
5849
269249d9
TT
58502019-08-06 Tom Tromey <tromey@adacore.com>
5851
5852 * source-cache.c (extract_lines): No longer a method.
5853 Changed type of parameter. Include final newline.
5854 (selftests::extract_lines_test): New function.
5855 (_initialize_source_cache): Likewise.
5856 * source-cache.h (class source_cache)
5857 <extract_lines>: Don't declare.
5858
c0e8dcd8
TT
58592019-08-06 Tom Tromey <tromey@adacore.com>
5860
5861 * breakpoint.c (init_breakpoint_sal): Update.
5862 (breakpoint): Update.
5863 * breakpoint.h (struct breakpoint) <filter>: Now a
5864 unique_xmalloc_ptr.
5865
0b27c27d
CB
58662019-08-05 Christian Biesinger <cbiesinger@google.com>
5867
5868 * NEWS: Mention dictionary access on blocks.
5869 * python/py-block.c (blpy_getitem): New function.
5870 (block_object_as_mapping): New struct.
5871 (block_object_type): Use new struct for tp_as_mapping field.
5872
4ee94178
CB
58732019-08-05 Christian Biesinger <cbiesinger@google.com>
5874
5875 * objfiles.h (objfile): Add a comment describing partial symbols.
5876
8abfcabc
TT
58772019-08-05 Tom Tromey <tromey@adacore.com>
5878
5879 * compile/compile.c (_initialize_compile): Use _(), not N_().
5880 * thread.c (_initialize_thread): Use _(), not N_().
5881 * stack.c (_initialize_stack): Use _(), not N_().
5882 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5883
2b79f376
SM
58842019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5885
5886 * dwarf2read.c (struct dw2_symtab_iterator):
5887 <want_specific_block>: Remove.
5888 <block_index>: Change type to gdb::optional.
5889 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5890 change type of BLOCK_INDEX parameter to gdb::optional.
5891 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5892 (dw2_lookup_symbol): Don't pass argument for
5893 WANT_SPECIFIC_BLOCK.
5894 (dw2_expand_symtabs_for_function): Don't pass argument for
5895 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5896 (class dw2_debug_names_iterator)
5897 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5898 parameter, change BLOCK_INDEX type to gdb::optional.
5899 <m_want_specific_block>: Remove.
5900 <m_block_index>: Change type to gdb::optional.
5901 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5902 gdb::optional. Re-write in function of gdb::optional.
5903 (dw2_debug_names_lookup_symbol): Don't pass argument for
5904 WANT_SPECIFIC_BLOCK.
5905 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5906 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5907 BLOCK_INDEX.
5908
ae60f04e
PW
59092019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5910
5911 * NEWS: Mention changes to "info sources" command.
5912
28cd9371
PW
59132019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5914
5915 * symtab.c (filename_partial_match_opts): New struct type.
5916 (struct output_source_filename_data): New members
5917 regexp, c_regexp, partial_match.
5918 (output_source_filename): Use new members to decide to print file.
5919 (info_sources_option_defs): New variable.
5920 (make_info_sources_options_def_group, print_info_sources_header,
5921 info_sources_command_completer):
5922 New functions.
5923 (info_sources_command): Read new optional arguments.
5924 (_initialize_symtab): Update info sources help.
5925
ca683e3a
AO
59262019-08-02 Alexandre Oliva <oliva@adacore.com>
5927
5928 * ada-lang.c (exception_support_info_v0): Renamed from...
5929 (default_exception_support_info): ... this. Create new
5930 definition for v1.
5931 (ada_has_this_exception_support): Look up catch_handlers_sym.
5932 (ada_exception_support_info_sniffer): Try v0 after default.
5933
f1264162
TT
59342019-08-01 Tom Tromey <tromey@adacore.com>
5935
5936 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5937 gdbarch.h.
5938
0a7b2485
CB
59392019-08-01 Christian Biesinger <cbiesinger@google.com>
5940
5941 * s12z-tdep.c: Fix include path for s12z-opc.h.
5942
c6bdbeb7
AH
59432019-08-01 Alan Hayward <alan.hayward@arm.com>
5944
5945 * NEWS: Require GNU make 3.82.
5946
a2bd7b82
TT
59472019-07-16 Tom Tromey <tom@tromey.com>
5948
5949 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5950 declare.
5951
aa3b6533
TT
59522019-07-30 Tom Tromey <tromey@adacore.com>
5953
5954 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5955
a1530dc7
KB
59562019-07-30 Kevin Buettner <kevinb@redhat.com>
5957
5958 * printcmd.c (print_address_symbolic): Print negative offsets.
5959 (build_address_symbolic): Force signed arithmetic when computing
5960 offset.
5961
2906593f
CB
59622019-07-30 Christian Biesinger <cbiesinger@google.com>
5963
5964 PR/24474: Add a function to lookup static variables.
5965 * NEWS: Mention this new function.
5966 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5967 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5968 * python/python.c (python_GdbMethods): Add new function.
5969
c620ed88
CB
59702019-07-29 Christian Biesinger <cbiesinger@google.com>
5971
5972 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5973 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5974 (objfpy_lookup_static_symbol): New function.
5975 (objfile_object_methods): Add new functions.
5976
bc4268a5
PW
59772019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5978
5979 * NEWS: Mention 'set|show print frame-info'. Mention new
5980 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5981 backtrace argument. Mention that python frame filtering code
5982 is now consistent with what 'backtrace' command prints.
5983
4b5e8d19
PW
59842019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5985
5986 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5987 comments.
5988 (print_frame_info_auto, print_frame_info_source_line,
5989 print_frame_info_location, print_frame_info_source_and_location,
5990 print_frame_info_location_and_address, print_frame_info_short_location):
5991 New declarations.
5992 (struct frame_print_options): New member print_frame_info.
5993 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5994 * stack.h (get_user_print_what_frame_info): New declaration.
5995 (frame_show_address): New declaration.
5996 * stack.c (print_frame_arguments_choices): New value 'presence'.
5997 (print_frame_info_auto, print_frame_info_source_line,
5998 print_frame_info_location, print_frame_info_source_and_location,
5999 print_frame_info_location_and_address, print_frame_info_short_location,
6000 print_frame_info_choices, print_frame_info_print_what): New definitions.
6001 (print_frame_args): Only print dots for args if print frame-arguments
6002 is 'presence'.
6003 (frame_print_option_defs): New element for "frame-info".
6004 (get_user_print_what_frame_info): New function.
6005 (frame_show_address): Make non static. Move comment to stack.h.
6006 (print_frame_info_to_print_what): New function.
6007 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6008 to decide what to print.
6009 (backtrace_command_1): Handle the new print_frame_arguments_presence
6010 value.
6011 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6012 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6013 (py_print_frame): In non-mi mode, use LOCATION as default for
6014 print_what, similarly to frame information printed directly by
6015 backtrace command. Handle frame-info user option in non MI mode.
6016
6bdfee81
KB
60172019-07-27 Kevin Buettner <kevinb@redhat.com>
6018
6019 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6020 Add case for debugging 32-bit target on 64-bit host. Revise
6021 comment.
6022
98a617f8
KB
60232019-07-27 Kevin Buettner <kevinb@redhat.com>
6024
6025 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6026 instead of find_function_entry_range_from_pc.
6027
567238c9
KB
60282019-07-27 Kevin Buettner <kevinb@redhat.com>
6029
6030 * stack.c (find_frame_funname): Remove code which preferred
6031 minsym over symtab sym in "certain pathological cases".
6032
2dc80cf8
KB
6033 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6034 parameter. Change type of "do_demangle" to bool.
6035 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6036 Pass suitable "prefer_sym_over_minsym" flag to
6037 build_address_symbolic(). Don't output "+" for negative offsets.
6038 * printcmd.c (print_address_symbolic): Update invocation of
6039 build_address_symbolic to include a "prefer_sym_over_minsym"
6040 flag.
6041 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6042 Restrict cases in which use of minimal symbol is preferred to that
6043 of a found symbol. Update comments.
6044
1aff7173
KB
6045 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6046 for entry pc when entry pc is out of range for that FDE.
6047
89b085ac
BC
60482019-07-26 Brian Callahan <bcallah@openbsd.org>
6049
6050 PR gdb/24839:
6051 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6052 type.
6053
f32feb4a
CB
60542019-07-25 Christian Biesinger <cbiesinger@google.com>
6055
6056 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6057 this function's Python signature.
6058
6059
60602019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
6061
6062 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6063 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6064 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6065 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6066 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6067
6068
c54e4253
YS
60692019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6070
6071 * h8300-tdep.c (h8300_register_name_common): New.
6072 h8300_register_name): Use h8300_register_name_common.
6073 (h8300s_register_name): Likewise.
6074 (h8300sx_register_name): Likewise.
6075 (h8300h_register_nam): New.
6076 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6077
6078
40eadf04
SP
60792019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6080
6081 * arm-tdep.c (arm_skip_cmse_entry): New function.
6082 (arm_is_sgstubs_section): New function.
6083 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6084
bfa2a36d
TT
60852019-07-22 Tom Tromey <tom@tromey.com>
6086
6087 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6088 Don't self-assign.
6089
a8e9d247
AB
60902019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6091
6092 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6093 type_print.
6094
eb86c5e2
AB
60952019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6096
6097 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6098 so that GDB doesn't match any msymbols when searching in the
6099 TYPES_DOMAIN.
6100 (print_symbol_info): Print using typedef_print or type_print based
6101 on the type of the symbol. Add updated FIXME comment moved from...
6102 (_initialize_symtab): ... move and update FIXME comment to above.
6103
a8eab7c6
AB
61042019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6105
6106 * NEWS: Mention adding -q option to "info types".
6107 * symtab.c (struct info_types_options): New struct.
6108 (info_types_options_defs): New variable.
6109 (make_info_types_options_def_group): New function.
6110 (info_types_command): Use gdb::option framework to parse options.
6111 (info_types_command_completer): New function.
6112 (_initialize_symtab): Extend the help text on "info types" and
6113 register command completer.
6114
b4603c34
CB
61152019-07-21 Christian Biesinger <cbiesinger@google.com>
6116
6117 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6118 (lookup_symbol_in_objfile): Change int to block_enum and add a
6119 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6120
c8cdc1e0
CB
61212019-07-20 Christian Biesinger <cbiesinger@google.com>
6122
6123 * MAINTAINERS (Write After Approval): Add self.
6124
01e175fe
AB
61252019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6126
6127 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6128 instruction to the dummy code region.
6129
56f79b63
TT
61302019-07-19 Tom Tromey <tromey@adacore.com>
6131
6132 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6133 (ARGSUSED, PARAMS, __func__): Remove rules.
6134
4c5aa8e0
AH
61352019-07-19 Alan Hayward <alan.hayward@arm.com>
6136
6137 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6138 * features/arm/arm-with-iwmmxt.c: Remove.
6139 * features/arm/arm-with-iwmmxt.xml: Remove.
6140 * features/arm/arm-with-m-fpa-layout.c: Remove.
6141 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6142 * features/arm/arm-with-m-vfp-d16.c: Remove.
6143 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6144 * features/arm/arm-with-m.c: Remove.
6145 * features/arm/arm-with-m.xml: Remove.
6146 * features/arm/arm-with-neon.c: Remove.
6147 * features/arm/arm-with-neon.xml: Remove.
6148 * features/arm/arm-with-vfpv2.c: Remove.
6149 * features/arm/arm-with-vfpv2.xml: Remove.
6150 * features/arm/arm-with-vfpv3.c: Remove.
6151 * features/arm/arm-with-vfpv3.xml: Remove.
6152
f42b2617
AH
61532019-07-19 Alan Hayward <alan.hayward@arm.com>
6154
6155 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6156
f29ec966
AH
61572019-07-19 Alan Hayward <alan.hayward@arm.com>
6158
6159 * arch/aarch32.c (aarch32_create_target_description): Create
6160 target descriptions using features.
6161 * arch/arm.c (arm_create_target_description)
6162 (arm_create_mprofile_target_description): Likewise.
6163 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6164
d105cce5
AH
61652019-07-19 Alan Hayward <alan.hayward@arm.com>
6166
6167 * Makefile.in: Add new files.
6168 * aarch32-tdep.c: New file.
6169 * aarch32-tdep.h: New file.
6170 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6171 Call aarch32_read_description.
6172 * arch/aarch32.c: New file.
6173 * arch/aarch32.h: New file.
6174 * arch/arm.c (arm_create_target_description)
6175 (arm_create_mprofile_target_description): New function.
6176 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6177 (arm_create_target_description)
6178 (arm_create_mprofile_target_description): New declaration.
6179 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6180 read_description functions.
6181 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6182 Likewise.
6183 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6184 * arm-tdep.c (tdesc_arm_list): New variable.
6185 (arm_register_g_packet_guesses): Call create description functions.
6186 (arm_read_description) (arm_read_mprofile_description): New
6187 function.
6188 * arm-tdep.h (arm_read_description)
6189 (arm_read_mprofile_description): Add declaration.
6190 * configure.tgt: Add new files.
6191
afe09f0b
GL
61922019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6193
6194 * top.c (new_ui_command): Open specified terminal just once.
6195
cd215b2e
TT
61962019-07-18 Tom Tromey <tromey@adacore.com>
6197
6198 * symtab.c (main_name): Constify return type.
6199 * symfile.c (set_initial_language): Update.
6200 * symtab.h (main_name): Constify return type.
6201
d8f68fcb
TT
62022019-07-17 Tom Tromey <tom@tromey.com>
6203
6204 * tui/tui-winsource.c (tui_update_source_window)
6205 (tui_update_source_window_as_is)
6206 (tui_update_source_windows_with_line): Remove return.
6207 * tui/tui-disasm.c (tui_show_disassem)
6208 (tui_show_disassem_and_update_source): Remove return.
6209 * tui/tui.c (tui_reset): Remove return.
6210 * tui/tui-wingeneral.c
6211 (tui_check_and_display_highlight_if_needed): Remove return.
6212
ca5af91e
TT
62132019-07-17 Tom Tromey <tom@tromey.com>
6214
6215 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6216
5104fe36
TT
62172019-07-17 Tom Tromey <tom@tromey.com>
6218
6219 * tui/tui-winsource.h (struct tui_exec_info_window)
6220 (struct tui_source_window_base): Move from tui-data.h.
6221 * tui/tui-winsource.c: Move many method definitions from
6222 elsewhere. Remove "structuring" comments.
6223 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6224 (tui_source_window_base::refresh_window): Move to
6225 tui-winsource.c.
6226 * tui/tui-win.c (tui_source_window_base::refresh_all)
6227 (tui_source_window_base::update_tab_width)
6228 (tui_source_window_base::set_new_height)
6229 (tui_source_window_base::do_make_visible_with_new_height): Move to
6230 tui-winsource.c.
6231 * tui/tui-source.h: Update.
6232 * tui/tui-source.c (tui_source_window_base::reset): Move to
6233 tui-winsource.c.
6234 * tui/tui-disasm.h: Update.
6235 * tui/tui-data.h (struct tui_exec_info_window): Move to
6236 tui-winsource.h.
6237 (struct tui_source_window_base): Likewise.
6238 * tui/tui-data.c (tui_source_window_base::clear_detail)
6239 (tui_source_window_base, ~tui_source_window_base): Move to
6240 tui-winsource.c.
6241
daa15dde
TT
62422019-07-17 Tom Tromey <tom@tromey.com>
6243
6244 * tui/tui-win.c (tui_resize_all)
6245 (tui_source_window_base::update_tab_width)
6246 (tui_adjust_win_heights): Update.
6247 (tui_win_info::make_invisible_and_set_new_height): Rename from
6248 make_invisible_and_set_new_height.
6249 * tui/tui-data.h (struct tui_win_info)
6250 <make_invisible_and_set_new_height>: New method.
6251
bfad4537
TT
62522019-07-17 Tom Tromey <tom@tromey.com>
6253
6254 * tui/tui.c: Update.
6255 * tui/tui-source.h (struct tui_source_window): Move from
6256 tui-data.h.
6257 * tui/tui-layout.c: Update.
6258 * tui/tui-disasm.c: Update.
6259 * tui/tui-data.h (struct tui_source_window): Move to
6260 tui-source.h.
6261
88f7e873
TT
62622019-07-17 Tom Tromey <tom@tromey.com>
6263
6264 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6265 tui-data.h.
6266 * tui/tui-data.h (struct tui_disasm_window): Move to
6267 tui-disasm.h.
6268
96bd6233
TT
62692019-07-17 Tom Tromey <tom@tromey.com>
6270
6271 * tui/tui-regs.h (struct tui_data_item_window): Move from
6272 tui-data.h.
6273 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6274 * tui/tui-data.h (struct tui_data_item_window): Move to
6275 tui-regs.h.
6276 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6277
ce38393b
TT
62782019-07-17 Tom Tromey <tom@tromey.com>
6279
6280 * tui/tui.c: Update.
6281 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6282 (tui_cmd_window::max_height): Move to tui-command.c.
6283 * tui/tui-layout.c: Update.
6284 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6285 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6286 tui-command.c.
6287 * tui/tui-command.h (struct tui_cmd_window): Move from
6288 tui-data.h.
6289 * tui/tui-command.c: Remove "structuring" comments.
6290 (tui_cmd_window::clear_detail)
6291 (tui_cmd_window::do_make_visible_with_new_height)
6292 (tui_cmd_window::max_height): Move from elsewhere.
6293
2d8b51cb
TT
62942019-07-17 Tom Tromey <tom@tromey.com>
6295
6296 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6297 Now static.
6298 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6299 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6300
18ab23af
TT
63012019-07-17 Tom Tromey <tom@tromey.com>
6302
6303 * tui/tui.c: Update.
6304 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6305 tui-regs.c.
6306 * tui/tui-windata.h: Remove file.
6307 * tui/tui-windata.c: Remove file.
6308 * tui/tui-win.c (tui_data_window::set_new_height)
6309 (tui_data_window::do_make_visible_with_new_height): Move to
6310 tui-regs.c.
6311 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6312 * tui/tui-regs.c: Remove "structuring" comments.
6313 (tui_data_window::first_data_item_displayed)
6314 (tui_data_window::delete_data_content_windows)
6315 (tui_data_window::erase_data_content)
6316 (tui_data_window::display_all_data)
6317 (tui_data_window::refresh_all)
6318 (tui_data_window::do_scroll_vertical)
6319 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6320 (tui_data_window::do_make_visible_with_new_height)
6321 (tui_data_window::refresh_window): Move from elsewhere.
6322 (_initialize_tui_regs): Move to end of file.
6323 * tui/tui-layout.c: Update.
6324 * tui/tui-hooks.c: Update.
6325 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6326 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6327 tui-regs.c.
6328 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6329
88b7e7cc
TT
63302019-07-17 Tom Tromey <tom@tromey.com>
6331
6332 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6333 seen.
6334
0fcd3711
TT
63352019-07-17 Tom Tromey <tom@tromey.com>
6336
6337 * tui/tui-win.c (tui_source_window_base::set_new_height)
6338 (tui_source_window_base::do_make_visible_with_new_height): Use
6339 m_has_locator field directly.
6340 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6341 method.
6342 (struct tui_source_window_base) <has_locator>: Likewise.
6343
4a38112d
TT
63442019-07-17 Tom Tromey <tom@tromey.com>
6345
6346 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6347 Don't declare.
6348 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6349 Remove.
6350 * tui/tui-win.c (tui_source_window_base::set_new_height)
6351 (tui_source_window_base::set_new_height)
6352 (make_invisible_and_set_new_height)
6353 (tui_source_window_base::do_make_visible_with_new_height)
6354 (tui_source_window_base::do_make_visible_with_new_height):
6355 Update.
6356 * tui/tui-layout.c (show_source_disasm_command, show_data)
6357 (show_source_or_disasm_and_command): Update.
6358 * tui/tui-layout.c (show_layout): Update.
6359
09129226
TT
63602019-07-17 Tom Tromey <tom@tromey.com>
6361
6362 * tui/tui-layout.c (make_data_window): Remove.
6363 (show_data): Unify creation and re-initialization cases.
6364
4a8a5e84
TT
63652019-07-17 Tom Tromey <tom@tromey.com>
6366
6367 * tui/tui-layout.c (make_source_window, make_disasm_window):
6368 Remove.
6369 (show_data): Unify creation and re-initialization cases.
6370
76d2be8e
TT
63712019-07-17 Tom Tromey <tom@tromey.com>
6372
6373 * tui/tui-layout.c (make_command_window): Remove.
6374 (show_source_disasm_command, show_source_or_disasm_and_command):
6375 Unify creation and re-initialization cases.
6376
890b8bde
TT
63772019-07-17 Tom Tromey <tom@tromey.com>
6378
6379 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6380 creation and re-initialization cases.
6381
2cdfa113
TT
63822019-07-17 Tom Tromey <tom@tromey.com>
6383
6384 * tui/tui-regs.c (tui_get_register): Return void.
6385
8e3cfd09
TT
63862019-07-17 Tom Tromey <tom@tromey.com>
6387
6388 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6389 Simplify.
6390
f4e04977
TT
63912019-07-17 Tom Tromey <tom@tromey.com>
6392
6393 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6394 resetting.
6395
0379b883
TT
63962019-07-17 Tom Tromey <tom@tromey.com>
6397
6398 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6399 * tui/tui-regs.c (tui_reg_layout): New function.
6400 (tui_show_registers, tui_reg_command): Use it.
6401 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6402 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6403 parameters.
6404 (tui_layout_command): Remove.
6405
b7fbad91
TT
64062019-07-17 Tom Tromey <tom@tromey.com>
6407
6408 * tui/tui-layout.h (tui/tui-layout): Return void.
6409 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6410
4e1e56b9
TT
64112019-07-17 Tom Tromey <tom@tromey.com>
6412
6413 * tui/tui-layout.c (show_source_disasm_command, show_data):
6414 Update.
6415 (reset_locator): Remove.
6416 (show_source_or_disasm_and_command): Update.
6417
1e0c09ba
TT
64182019-07-17 Tom Tromey <tom@tromey.com>
6419
6420 * tui/tui-source.c (tui_source_window_base::reset): Remove
6421 win_type parameter.
6422 * tui/tui-layout.c (make_command_window, make_source_window)
6423 (make_disasm_window, make_data_window)
6424 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6425 (reset_locator, show_source_or_disasm_and_command): Update.
6426 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6427 win_type parameter.
6428 (struct tui_source_window_base) <reset>: Likewise.
6429
1bf605de
TT
64302019-07-17 Tom Tromey <tom@tromey.com>
6431
6432 * tui/tui-layout.c (show_source_disasm_command): Use
6433 reset_locator.
6434 (reset_locator): New function.
6435 (init_and_make_win): Remove.
6436 (show_source_or_disasm_and_command): Use reset_locator.
6437
098f9ed4
TT
64382019-07-17 Tom Tromey <tom@tromey.com>
6439
6440 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6441 condition.
6442 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6443 Remove condition.
6444 * tui/tui-source.c (tui_source_window_base::reset): New method.
6445 * tui/tui-layout.c (make_command_window): Don't call
6446 init_and_make_win.
6447 (make_source_window, make_disasm_window): Don't call
6448 make_source_or_disasm_window.
6449 (make_data_window): Don't call init_and_make_win. Change calling
6450 convention.
6451 (show_source_disasm_command, show_data): Simplify.
6452 (make_source_or_disasm_window): Remove.
6453 (show_source_or_disasm_and_command): Simplify.
6454 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6455 (struct tui_source_window_base) <reset>: Likewise.
6456 <execution_info>: Remove initializer.
6457 * tui/tui-data.c (tui_source_window_base): Initialize
6458 execution_info.
6459
80110957
TT
64602019-07-17 Tom Tromey <tom@tromey.com>
6461
6462 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6463 variable.
6464
cf82af05
TT
64652019-07-17 Tom Tromey <tom@tromey.com>
6466
6467 * tui/tui.c (tui_rl_other_window): Update.
6468 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6469 superclass method first. Always iterate over regs_content.
6470 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6471 method.
6472 * tui/tui-win.c (tui_set_focus_command): Update.
6473
01aeb396
TT
64742019-07-17 Tom Tromey <tom@tromey.com>
6475
6476 * tui/tui-win.c (tui_set_focus_command): Rename from
6477 tui_set_focus. Call tui_enable.
6478 (tui_set_focus_command): Remove.
6479
fd6c75ee
TT
64802019-07-17 Tom Tromey <tom@tromey.com>
6481
6482 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6483 refresh_window.
6484 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6485 touchwin.
6486 (tui_data_window::refresh_window): Call refresh_window on data
6487 items. Always call superclass refresh_window.
6488 (tui_win_info::refresh): Remove.
6489 (tui_source_window_base::refresh_window): Update.
6490 (tui_refresh_all): Update.
6491 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6492 refresh_window.
6493 (show_source_or_disasm_and_command): Likewise.
6494 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6495 (struct tui_source_window_base) <refresh>: Likewise.
6496
f6cc34a9
TT
64972019-07-17 Tom Tromey <tom@tromey.com>
6498
6499 * tui/tui-winsource.c (tui_clear_source_content)
6500 (tui_show_source_content): Update.
6501 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6502 whether content is empty.
6503 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6504 Remove.
6505
f31ec9af
TT
65062019-07-17 Tom Tromey <tom@tromey.com>
6507
6508 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6509 window's contents.
6510 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6511 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6512
d1b6f1e5
TT
65132019-07-17 Tom Tromey <tom@tromey.com>
6514
6515 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6516 (struct tui_data_item_window): Update.
6517
d9743a13
TT
65182019-07-17 Tom Tromey <tom@tromey.com>
6519
6520 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6521 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6522 defines.
6523
caf0bc4e
TT
65242019-07-17 Tom Tromey <tom@tromey.com>
6525
6526 * tui/tui-winsource.h (tui_erase_source_content)
6527 (tui_clear_source_content): Remove "display_prompt" parameter.
6528 * tui/tui-winsource.c (tui_update_source_window_as_is)
6529 (tui_update_source_windows_with_addr): Update.
6530 (tui_clear_source_content): Remove "display_prompt" parameter.
6531 (tui_erase_source_content): Likewise. Simplify.
6532 (tui_show_source_content): Update.
6533 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6534 * tui/tui-stack.c (tui_show_frame_info): Update.
6535 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6536 Remove defines.
6537
9d391078
TT
65382019-07-17 Tom Tromey <tom@tromey.com>
6539
6540 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6541 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6542 parameter.
6543 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6544 parameter.
6545
a38da35d
TT
65462019-07-17 Tom Tromey <tom@tromey.com>
6547
6548 * tui/tui-winsource.c (tui_clear_source_content)
6549 (tui_show_source_content, tui_show_exec_info_content)
6550 (tui_clear_exec_info_content): Update.
6551 * tui/tui-stack.c (tui_show_locator_content): Update.
6552 (tui_show_frame_info): Update.
6553 * tui/tui-source.h (tui_source_window): Don't declare.
6554 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6555 from tui_source_is_displayed.
6556 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6557 Remove field.
6558 (struct tui_source_window_base) <content_in_use>: New field. Now
6559 bool.
6560 (struct tui_source_window) <showing_source_p>: New method.
6561 (TUI_SRC_WIN): Change cast.
6562 * tui/tui-data.c (tui_initialize_static_data): Update.
6563
c2cd8994
TT
65642019-07-17 Tom Tromey <tom@tromey.com>
6565
6566 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6567 location_matches_p.
6568 * tui/tui-source.c (tui_source_window::location_matches_p): New
6569 method.
6570 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6571 method.
6572 * tui/tui-data.h (struct tui_source_window_base)
6573 <location_matches_p>: New method.
6574 (struct tui_source_window, struct tui_disasm_window)
6575 <location_matches_p>: Likewise.
6576
4dde7b34
TT
65772019-07-17 Tom Tromey <tom@tromey.com>
6578
6579 * tui/tui-win.c (tui_set_win_height_command): Rename from
6580 tui_set_win_height.
6581 (tui_set_win_height_command): Remove.
6582
b73dd877
TT
65832019-07-17 Tom Tromey <tom@tromey.com>
6584
6585 * tui/tui-source.c (tui_source_window): New constructor. Add
6586 observer.
6587 (~tui_source_window): New destructor.
6588 (tui_source_window::style_changed): New method.
6589 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6590 (tui_attach_detach_observers): Update.
6591 * tui/tui-data.h (struct tui_source_window): Make constructor not
6592 inline. Add destructor.
6593 (struct tui_source_window) <style_changed>: New method.
6594 <m_observable>: New member.
6595
ae2b5380
TT
65962019-07-17 Tom Tromey <tom@tromey.com>
6597
6598 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6599 * tui/tui-win.c (tui_resize_all): Fix typo.
6600
1ce3e844
TT
66012019-07-17 Tom Tromey <tom@tromey.com>
6602
6603 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6604 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6605 (tui_refresh_all): Remove "list" parameter. Use foreach.
6606 * tui/tui-win.c (window_name_completer): Use foreach.
6607 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6608 (update_tab_width): Likewise.
6609 * tui/tui-layout.c (show_layout): Update.
6610 * tui/tui-data.h (class tui_window_iterator): New.
6611 (struct all_tui_windows): New.
6612 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6613
fe3eaf1c
TT
66142019-07-17 Tom Tromey <tom@tromey.com>
6615
6616 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6617 parameter. Don't reference globals.
6618 (tui_reg_command): Update.
6619
368c1354
TT
66202019-07-17 Tom Tromey <tom@tromey.com>
6621
6622 * tui/tui-regs.c (tui_show_registers): Simplify.
6623
e80cd204
TT
66242019-07-17 Tom Tromey <tom@tromey.com>
6625
6626 * tui/tui-regs.c (tui_show_registers): Update.
6627 (tui_show_register_group): Add win_info parameter.
6628
aca2dd16
TT
66292019-07-17 Tom Tromey <tom@tromey.com>
6630
6631 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6632 Rename from tui_display_reg_element_at_line.
6633 (tui_data_window::display_registers_from_line): Update.
6634 * tui/tui-data.h (struct tui_data_window)
6635 <display_reg_element_at_line>: New method.
6636
517e9505
TT
66372019-07-17 Tom Tromey <tom@tromey.com>
6638
6639 * tui/tui-regs.h (tui_display_registers_from)
6640 (tui_display_registers_from_line): Don't declare.
6641 * tui/tui-windata.c (tui_data_window::display_all_data)
6642 (tui_data_window::refresh_all)
6643 (tui_data_window::do_scroll_vertical): Update.
6644 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6645 from tui_display_registers_from.
6646 (tui_display_reg_element_at_line): Update.
6647 (tui_data_window::display_registers_from_line): Rename from
6648 tui_display_registers_from_line.
6649 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6650 display_registers_from_line>: New methods.
6651
f76d8b19
TT
66522019-07-17 Tom Tromey <tom@tromey.com>
6653
6654 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6655 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6656 from tui_erase_data_content.
6657 (tui_data_window::display_all_data)
6658 (tui_data_window::refresh_all)
6659 (tui_data_window::do_scroll_vertical): Update.
6660 * tui/tui-regs.c (tui_show_registers): Update.
6661 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6662 New method.
6663
b4094625
TT
66642019-07-17 Tom Tromey <tom@tromey.com>
6665
6666 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6667 declare.
6668 * tui/tui-windata.c
6669 (tui_data_window::delete_data_content_windows): Rename from
6670 tui_delete_data_content_windows.
6671 (tui_data_window::display_all_data)
6672 (tui_data_window::do_scroll_vertical): Update.
6673 * tui/tui-data.h (struct tui_data_window)
6674 <delete_data_content_windows>: New method.
6675
c223a729
TT
66762019-07-17 Tom Tromey <tom@tromey.com>
6677
6678 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6679 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6680
50daf268
TT
66812019-07-17 Tom Tromey <tom@tromey.com>
6682
6683 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6684 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6685 from tui_display_all_data.
6686 * tui/tui-win.c
6687 (tui_data_window::do_make_visible_with_new_height): Update.
6688 * tui/tui-regs.c (tui_show_registers): Update.
6689 * tui/tui-layout.c (tui_set_layout): Update.
6690 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6691 method.
6692
df5f8cab
TT
66932019-07-17 Tom Tromey <tom@tromey.com>
6694
6695 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6696 * tui/tui-windata.c (tui_display_data_from): Remove.
6697 (tui_data_window::refresh_all): Update.
6698
80cb6c27
TT
66992019-07-17 Tom Tromey <tom@tromey.com>
6700
6701 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6702 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6703 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6704 tui_display_registers_from_line.
6705 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6706 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6707 "force_display" parameter.
6708
baff0c28
TT
67092019-07-17 Tom Tromey <tom@tromey.com>
6710
6711 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6712 declare.
6713 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6714 Rename from tui_first_reg_element_no_inline.
6715 (tui_display_reg_element_at_line)
6716 (tui_display_registers_from_line): Update.
6717 * tui/tui-data.h (struct tui_data_window)
6718 <first_reg_element_no_inline>: New method.
6719
3b23c5f2
TT
67202019-07-17 Tom Tromey <tom@tromey.com>
6721
6722 * tui/tui-windata.c (tui_display_data_from)
6723 (tui_data_window::do_scroll_vertical): Update.
6724 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6725 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6726 Rename from tui_line_from_reg_element_no.
6727 (tui_display_registers_from_line): Update.
6728 * tui/tui-data.h (struct tui_data_window)
6729 <line_from_reg_element_no>: New method.
6730
0b5ec218
TT
67312019-07-17 Tom Tromey <tom@tromey.com>
6732
6733 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6734 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6735 tui_last_regs_line_no.
6736 (tui_display_reg_element_at_line)
6737 (tui_display_registers_from_line): Update.
6738 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6739 method.
6740
0807ab7b
TT
67412019-07-17 Tom Tromey <tom@tromey.com>
6742
6743 PR tui/24722:
6744 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6745 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6746 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6747 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6748 (tui_update_breakpoint_info): Likewise.
6749 * tui/tui-hooks.c (tui_event_create_breakpoint)
6750 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6751 Update.
6752
9ad7fdef
TT
67532019-07-17 Tom Tromey <tom@tromey.com>
6754
6755 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6756
5813316f
TT
67572019-07-17 Tom Tromey <tom@tromey.com>
6758
6759 * tui/tui-winsource.c (tui_update_source_window_as_is)
6760 (tui_update_source_windows_with_addr): Update.
6761 * tui/tui-source.h (tui_set_source_content)
6762 (tui_show_symtab_source): Add "win_info" parameter.
6763 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6764 parameter.
6765 (tui_show_symtab_source): Likewise.
6766
00e264e7
TT
67672019-07-17 Tom Tromey <tom@tromey.com>
6768
6769 * tui/tui-wingeneral.c
6770 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6771
06210ce4
TT
67722019-07-17 Tom Tromey <tom@tromey.com>
6773
6774 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6775 (struct tui_cmd_window) <can_scroll>: New method.
6776 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6777 method.
6778
381befee
TT
67792019-07-17 Tom Tromey <tromey@adacore.com>
6780
6781 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6782 do_field_signed>: Rename. Change type of "value".
6783 * ui-out.c (ui_out::field_signed): Rename from field_int.
6784 Change type of "value".
6785 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6786 type of "value".
6787 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6788 do_field_int. Change type of "value".
6789 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6790 do_field_int. Change type of "value".
6791 * tracepoint.c (trace_status_mi, tfind_1)
6792 (print_one_static_tracepoint_marker): Update.
6793 * thread.c (print_thread_info_1, print_selected_thread_frame):
6794 Update.
6795 * stack.c (print_frame, print_frame_info): Update.
6796 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6797 Update.
6798 * source.c (print_source_lines_base): Update.
6799 * skip.c (info_skip_command): Update.
6800 * record-btrace.c (btrace_ui_out_decode_error)
6801 (btrace_call_history_src_line): Update.
6802 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6803 Update.
6804 * progspace.c (print_program_space): Update.
6805 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6806 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6807 do_field_int. Change type of "value".
6808 * mi/mi-out.c (mi_ui_out::do_table_begin)
6809 (mi_ui_out::do_table_header): Update.
6810 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6811 type of "value".
6812 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6813 (mi_cmd_data_list_changed_registers, output_register)
6814 (mi_cmd_data_read_memory, mi_load_progress)
6815 (mi_cmd_trace_frame_collected): Update.
6816 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6817 Update.
6818 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6819 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6820 (mi_cmd_var_list_children, varobj_update_one): Update.
6821 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6822 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6823 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6824 * inferior.c (print_inferior): Update.
6825 * gdb_bfd.c (print_one_bfd): Update.
6826 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6827 Update.
6828 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6829 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6830 do_field_int. Change type of "value".
6831 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6832 do_field_int. Change type of "value".
6833 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6834 (print_one_breakpoint_location, print_it_catch_fork)
6835 (print_one_catch_fork, print_it_catch_vfork)
6836 (print_one_catch_vfork, print_it_catch_solib)
6837 (print_it_catch_exec, print_it_ranged_breakpoint)
6838 (print_mention_watchpoint, print_mention_masked_watchpoint)
6839 (bkpt_print_it, update_static_tracepoint): Update.
6840 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6841 * break-catch-syscall.c (print_it_catch_syscall): Update.
6842 * ada-tasks.c (print_ada_task_info): Update.
6843 * ada-lang.c (print_it_exception, print_mention_exception):
6844 Update.
6845
6b78c3f8
AB
68462019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6847
6848 PR breakpoints/24541
6849 * gdbarch.c: Regenerate.
6850 * gdbarch.h: Regenerate.
6851 * gdbarch.sh: Adjust return type and parameter types for
6852 'stap_adjust_register'.
6853 (i386_stap_adjust_register): Adjust signature and return new
6854 register name.
6855 * stap-probe.c (stap_parse_register_operand): Adjust use of
6856 'gdbarch_stap_adjust_register'.
6857
d72a9b85
TT
68582019-07-17 Tom Tromey <tromey@adacore.com>
6859
6860 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6861 declare VEC.
6862 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6863 std::vector.
6864 (struct s390_process_info): Add initializers.
6865 (s390_add_process): Use new.
6866 (s390_linux_nat_target::low_forget_process): Use delete.
6867 (s390_linux_nat_target::low_new_fork)
6868 (s390_linux_nat_target::stopped_by_watchpoint)
6869 (s390_linux_nat_target::low_prepare_to_resume)
6870 (s390_linux_nat_target::insert_watchpoint)
6871 (s390_linux_nat_target::insert_hw_breakpoint)
6872 (s390_linux_nat_target::remove_watchpoint)
6873 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6874
206e6c58
JB
68752019-07-16 John Baldwin <jhb@FreeBSD.org>
6876
6877 * aarch64-fbsd-nat.c: Include regcache.h.
6878 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6879 argument.
6880 (aarch64_fbsd_nat_target::fetch_registers)
6881 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6882 variable.
6883 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6884
cbde90f2
JB
68852019-07-16 John Baldwin <jhb@FreeBSD.org>
6886
6887 * fbsd-nat.c: Include gdbarch.h.
6888
07128006
TT
68892019-07-15 Tom Tromey <tromey@adacore.com>
6890
6891 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6892
1f77b012
TT
68932019-07-15 Tom Tromey <tromey@adacore.com>
6894
6895 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6896 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6897 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6898 * cli-out.c (cli_ui_out::do_field_int): New method.
6899 * ui-out.c (ui_out::field_unsigned): New method.
6900 * symfile.c (generic_load): Use field_unsigned.
6901 (print_transfer_performance): Likewise.
6902 * record-btrace.c (ui_out_field_uint): Remove.
6903 (btrace_call_history_insn_range, btrace_call_history): Use
6904 field_unsigned.
6905 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6906 field_unsigned.
6907 * ui-out.h (class ui_out) <field_unsigned>: New method.
6908 <do_field_unsigned>: Likewise.
6909
33eca680
TT
69102019-07-15 Tom Tromey <tromey@adacore.com>
6911
6912 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6913 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6914 * target.c (flash_erase_command): Use field_string.
6915 * infrun.c (print_signal_received_reason): Use field_string.
6916 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6917 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6918 field_string.
6919 * ada-tasks.c (print_ada_task_info): Use field_string.
6920
ca8d69be
TT
69212019-07-15 Tom Tromey <tromey@adacore.com>
6922
6923 * target.c (flash_erase_command): Use field_core_addr.
6924 * symfile.c (generic_load): Use field_core_addr.
6925 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6926 Use field_core_addr.
6927 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6928 field_core_addr.
6929
0d4e84ed
AB
69302019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6931
6932 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6933 value if its desired type is smaller than a CORE_ADDR and signed.
6934
9a49df9d
AB
69352019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6936
6937 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6938 of changes to field names, and use new is_reference field to
6939 decide if a property is a reference or not.
6940 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6941 field.
6942 (struct dwarf2_property_baton): Update header comment, rename
6943 'referenced_type' to 'property_type' and update comments.
6944 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6945 default property type, store in property baton, update to take
6946 accound of renamed field.
6947 (read_func_scope): Update call to attr_to_dynamic_prop.
6948 (read_array_type): Likewise.
6949 (dwarf2_per_cu_addr_sized_int_type): New function.
6950 (read_subrange_index_type): Move type finding code to
6951 dwarf2_per_cu_addr_sized_int_type.
6952 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6953 (dwarf2_per_cu_addr_type): New function.
6954 (set_die_type): Update calls to attr_to_dynamic_prop.
6955
b86352cf
AB
69562019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6957
6958 * dwarf2read.c (read_subrange_index_type): New function.
6959 (read_subrange_type): Move code into new function and call it.
6960 * gdbtypes.c (create_range_type): Add some asserts.
6961
603490bf
AB
69622019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6963
6964 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6965 update return statements.
6966 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6967 declaration, and update comment to match.
6968 * gdbtypes.c (resolve_dynamic_array): Update call to
6969 dwarf2_evaluate_property to match new return type.
6970
592f9d27
AB
69712019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6972
6973 * valarith.c (value_subscripted_rvalue): Change lowerbound
6974 parameter type from int to LONGEST.
6975 * value.h (value_subscripted_rvalue): Likewise in declaration.
6976
60cfcb20
AB
69772019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6978
6979 * cli/cli-utils.c (info_print_command_completer): New function.
6980 * cli/cli-utils.h: Add 'completer.h' include, and forward
6981 declaration for 'struct cmd_list_element'.
6982 (info_print_command_completer): Declare.
6983 * stack.c (_initialize_stack): Add completer for 'info locals' and
6984 'info args'.
6985 * symtab.c (_initialize_symtab): Add completer for 'info
6986 variables' and 'info functions'.
6987 * NEWS: Mention completion for additional info commands.
6988
b16507e0
AB
69892019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6990
6991 * cli/cli-utils.c (extract_info_print_args): Delete.
6992 (extract_arg_maybe_quoted): Delete.
6993 (info_print_options_defs): New variable.
6994 (make_info_print_options_def_group): New function.
6995 (extract_info_print_options): Define new function.
6996 * cli/cli-utils.h (extract_info_print_args): Delete.
6997 (struct info_print_options): New structure.
6998 (extract_info_print_options): Declare new function.
6999 * stack.c (info_locals_command): Update to use new
7000 extract_info_print_options, also add a header comment.
7001 (info_args_command): Likewise.
7002 * symtab.c (info_variables_command): Likewise.
7003 (info_functions_command): Likewise.
7004
021d8588
AB
70052019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7006
7007 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7008 to extract string arguments.
7009 * common/common-utils.c (extract_string_maybe_quoted): New function.
7010 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7011
b777eb6d
TT
70122019-07-11 Tom Tromey <tromey@adacore.com>
7013
7014 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7015 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7016 * top.h (gdbinit): Don't declare.
7017 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7018 into...
7019 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7020 * top.c (gdb_init): Don't call init_cli_cmds.
7021 (gdbinit): Remove.
7022 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7023
72ee03ff
TT
70242019-07-11 Tom Tromey <tromey@adacore.com>
7025
7026 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7027 after it has been moved.
7028
00db9531
SM
70292019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7030
7031 * valops.c (value_must_coerce_to_target): Change return type to
7032 bool.
7033 * value.h (value_must_coerce_to_target): Likewise.
7034
f2478a7e
SM
70352019-07-10 Simon Marchi <simon.marchi@efficios.com>
7036
7037 * breakpoint.c (is_hardware_watchpoint): Remove
7038 forward-declaration.
7039 (is_masked_watchpoint): Change return type to bool.
7040 (is_tracepoint): Likewise.
7041 (is_breakpoint): Likewise.
7042 (is_hardware_watchpoint): Likewise.
7043 (is_watchpoint): Likewise.
7044 (is_no_memory_software_watchpoint): Likewise.
7045 (is_catchpoint): Likewise.
7046 (breakpoint_1): Make FILTER parameter's return type bool.
7047 is_masked_watchpoint): Change return type to bool.
7048 (save_breakpoints): Make FILTER parameter's return type bool.
7049 * breakpoint.h (is_breakpoint): Change return type to bool.
7050 (is_watchpoint): Likewise.
7051 (is_catchpoint): Likewise.
7052 (is_tracepoint): Likewise.
7053
0d12e84c
TT
70542019-07-10 Tom Tromey <tom@tromey.com>
7055
7056 * defs.h: Don't include gdbarch.h.
7057 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7058 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7059 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7060 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7061 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7062 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7063 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7064 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7065 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7066 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7067 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7068 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7069 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7070 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7071 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7072 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7073 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7074 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7075 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7076 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7077 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7078 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7079 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7080 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7081 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7082 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7083 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7084
f06f1252
TT
70852019-07-10 Tom Tromey <tromey@adacore.com>
7086
7087 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7088 * breakpoint.c (init_ada_exception_breakpoint): Register as
7089 bp_catchpoint.
7090 (print_one_breakpoint_location, print_one_breakpoint): Use
7091 is_ada_exception_catchpoint.
7092 * ada-lang.c (class ada_catchpoint_location): Pass
7093 bp_loc_software_breakpoint to bp_location constructor.
7094 (is_ada_exception_catchpoint): New function.
7095
7a5d944b
TT
70962019-07-10 Tom Tromey <tromey@adacore.com>
7097
7098 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7099 VEC.
7100 (struct arm_exidx_entry): New method operator<.
7101 (struct arm_exidx_data) <section_maps>: Change type.
7102 (arm_exidx_data_free): Remove.
7103 (arm_exidx_data_key): Change type. Move lower.
7104 (arm_exidx_new_objfile): Update.
7105 (arm_compare_exidx_entries): Remove.
7106 (arm_find_exidx_entry, _initialize_arm_tdep)
7107
48c66e1d
TT
71082019-07-10 Tom Tromey <tromey@adacore.com>
7109
7110 * solib-spu.c (ocl_program_data_key): Change type.
7111 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7112 Update.
7113
a269fbf1
TT
71142019-07-10 Tom Tromey <tromey@adacore.com>
7115
7116 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7117 (struct solib_aix_inferior_data) <library_list>: Change type.
7118 (solib_aix_inferior_data_handle): Change type.
7119 (get_solib_aix_inferior_data): Update.
7120 (solib_aix_free_library_list): Remove.
7121 (library_list_start_library): Update.
7122 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7123 return type.
7124 (solib_aix_get_library_list)
7125 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7126 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7127
c294730c
TT
71282019-07-10 Tom Tromey <tromey@adacore.com>
7129
7130 * solib-dsbt.c (struct dsbt_info): Add initializers.
7131 (solib_dsbt_pspace_data): Change type.
7132 (dsbt_pspace_data_cleanup): Remove.
7133 (get_dsbt_info, _initialize_dsbt_solib): Update.
7134
9d52077d
TT
71352019-07-10 Tom Tromey <tromey@adacore.com>
7136
7137 * spu-tdep.c (spu_overlay_data): Change type.
7138 (spu_get_overlay_table, spu_overlay_new_objfile)
7139 (_initialize_spu_tdep): Update.
7140
22a20dca
TT
71412019-07-10 Tom Tromey <tromey@adacore.com>
7142
7143 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7144 destructor.
7145 (dbx_objfile_data_key): Change type and declare later.
7146 (DBX_SYMFILE_INFO): Rewrite.
7147 * dbxread.c (dbx_objfile_data_key): Change type.
7148 (dbx_symfile_init): Update.
7149 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7150 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7151 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7152
cb60f420
TT
71532019-07-10 Tom Tromey <tromey@adacore.com>
7154
7155 * jit.c (jit_program_space_key): Change type. Move lower.
7156 (get_jit_program_space_data): Update.
7157 (jit_program_space_data_cleanup): Remove.
7158 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7159 Update.
7160 (struct jit_program_space_data): Add initializers.
7161
51df2ae3
TT
71622019-07-10 Tom Tromey <tromey@adacore.com>
7163
7164 * solib-darwin.c (struct darwin_info): Add initializers.
7165 (solib_darwin_pspace_data): Change type.
7166 (darwin_pspace_data_cleanup): Remove.
7167 (get_darwin_info, _initialize_darwin_solib): Update.
7168
18101a35
TT
71692019-07-10 Tom Tromey <tromey@adacore.com>
7170
7171 * remote-sim.c (struct sim_inferior_data): Add initializers,
7172 constructor, and destructor.
7173 (sim_inferior_data_key): Change type. Move lower.
7174 (check_for_duplicate_sim_descriptor): Update.
7175 (get_sim_inferior_data): Use new. Update.
7176 (~sim_inferior_data_cleanup): Rename from
7177 sim_inferior_data_cleanup. Simplify.
7178 (gdbsim_close_inferior, simulator_command)
7179 (sim_command_completer, _initialize_remote_sim): Update.
7180 (next_pid, INITIAL_PID): Move earlier.
7181
05b08ac1
TT
71822019-07-10 Tom Tromey <tromey@adacore.com>
7183
7184 * python/python-internal.h (create_thread_object): Return
7185 gdbpy_ref.
7186 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7187 * python/py-inferior.c (struct threadlist_entry): Add
7188 constructor.
7189 <thread_obj>: Now a gdbpy_ref.
7190 (thread_to_thread_object): Update.
7191 (add_thread_object): Use new.
7192 (delete_thread_object): Use delete.
7193 (infpy_threads): Update.
7194 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7195 GIL.
7196
32372d80
TT
71972019-07-10 Tom Tromey <tromey@adacore.com>
7198
7199 * valops.c (value_cast): Specialize error message for Ada.
7200
5c458ae8
SM
72012019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7202
7203 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7204
4c462cb0
SM
72052019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7206
7207 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7208 bpstat_should_step): Return bool, adjust comments.
7209 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7210 bpstat_should_step): Likewise.
7211
89abbcc2
AH
72122019-07-10 Alan Hayward <alan.hayward@arm.com>
7213
7214 * features/Makefile: Use feature target descriptions for Arm.
7215 * features/arm/arm-core.c: Generate new file.
7216 * features/arm/arm-fpa.c: Likewise.
7217 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7218 * features/arm/arm-m-profile.c: Likewise.
7219 * features/arm/arm-vfpv2.c: Likewise.
7220 * features/arm/arm-vfpv3.c: Likewise.
7221 * features/arm/xscale-iwmmxt.c: Likewise.
7222 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7223
166a82be
AH
72242019-07-10 Alan Hayward <alan.hayward@arm.com>
7225
7226 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7227 ptrace earlier.
7228
9fb4c7e9
AH
72292019-07-10 Alan Hayward <alan.hayward@arm.com>
7230
7231 * features/aarch64-pauth.c: Regenerate.
7232
e2d0f980
SM
72332019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7234
7235 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7236 bool.
7237 (bpstat_what): Use false instead of 0.
7238
a38118e5
PA
72392019-07-09 Pedro Alves <palves@redhat.com>
7240
7241 * break-catch-throw.c (is_exception_catchpoint): New.
7242 * breakpoint.c (print_one_breakpoint_location): New parameter
7243 'raw_loc'. Handle it. Use
7244 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7245 looking at the breakpoint's type.
7246 (print_one_breakpoint): If handling "maint info breakpoints", also
7247 print locations of exception catchpoints.
7248 * breakpoint.h (is_exception_catchpoint): Declare.
7249
cb1e4e32
PA
72502019-07-09 Pedro Alves <palves@redhat.com>
7251
7252 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7253 "addr" field.
7254 (allocate_location_exception_catchpoint): New.
7255 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7256 (initialize_throw_catchpoint_ops): Install
7257 allocate_location_exception_catchpoint as allocate_location
7258 method.
7259 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7260 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7261 bp_loc_other.
7262 (breakpoint_address_is_meaningful): Delete.
7263 (bl_address_is_meaningful): New.
7264 (breakpoint_locations_match): Adjust comment.
7265 (bp_location_from_bp_type): New, factored out of...
7266 (bp_location::bp_location(breakpoint *)): ... this.
7267 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7268 factored out of...
7269 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7270 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7271 breakpoint_address_is_meaningful.
7272 (bp_locations_compare): Adjust comment.
7273 (update_global_location_list): Use bl_address_is_meaningful
7274 instead of breakpoint_address_is_meaningful.
7275 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7276 explicit.
7277 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7278 * python/py-breakpoint.c (bppy_get_location): No longer check
7279 whether location is null.
7280
b58a68fe
PA
72812019-07-09 Pedro Alves <palves@redhat.com>
7282
7283 PR c++/15468
7284 * breakpoint.c (print_one_breakpoint_location): Remove
7285 single-location assert.
7286
268a13a5
TT
72872019-07-09 Tom Tromey <tom@tromey.com>
7288
7289 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7290 * configure: Rebuild.
7291 * configure.ac: Change common to gdbsupport.
7292 * gdbsupport: Rename from common.
7293 * acinclude.m4: Change common to gdbsupport.
7294 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7295 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7296 gdbsupport.
7297 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7298 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7299 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7300 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7301 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7302 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7303 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7304 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7305 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7306 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7307 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7308 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7309 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7310 coff-pe-read.c, command.h, compile/compile-c-support.c,
7311 compile/compile-c.h, compile/compile-cplus-symbols.c,
7312 compile/compile-cplus-types.c, compile/compile-cplus.h,
7313 compile/compile-loc2c.c, compile/compile.c, completer.c,
7314 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7315 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7316 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7317 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7318 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7319 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7320 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7321 features/aarch64-core.c, features/aarch64-fpu.c,
7322 features/aarch64-pauth.c, features/aarch64-sve.c,
7323 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7324 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7325 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7326 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7327 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7328 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7329 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7330 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7331 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7332 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7333 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7334 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7335 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7336 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7337 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7338 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7339 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7340 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7341 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7342 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7343 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7344 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7345 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7346 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7347 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7348 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7349 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7350 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7351 minsyms.c, mips-linux-tdep.c, namespace.h,
7352 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7353 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7354 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7355 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7356 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7357 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7358 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7359 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7360 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7361 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7362 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7363 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7364 procfs.c, producer.c, progspace.h, psymtab.h,
7365 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7366 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7367 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7368 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7369 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7370 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7371 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7372 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7373 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7374 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7375 target-memory.c, target.c, target.h, target/waitstatus.c,
7376 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7377 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7378 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7379 unittests/array-view-selftests.c,
7380 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7381 unittests/common-utils-selftests.c,
7382 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7383 unittests/format_pieces-selftests.c,
7384 unittests/function-view-selftests.c,
7385 unittests/lookup_name_info-selftests.c,
7386 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7387 unittests/mkdir-recursive-selftests.c,
7388 unittests/observable-selftests.c,
7389 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7390 unittests/parse-connection-spec-selftests.c,
7391 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7392 unittests/scoped_fd-selftests.c,
7393 unittests/scoped_mmap-selftests.c,
7394 unittests/scoped_restore-selftests.c,
7395 unittests/string_view-selftests.c, unittests/style-selftests.c,
7396 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7397 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7398 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7399 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7400 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7401 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7402
5b0e2db4
AB
74032019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7404
7405 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7406 bool value.
7407 (decode_digits_ordinary): Set explicit_line field in sal.
7408 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7409 symtab_and_line that was set on an explicit line number in
7410 assembler code. Do always update the recorded symtab and line if
7411 we do skip the prologue.
7412
0ba852ab
AB
74132019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7414
7415 * breakpoint.c (set_breakpoint_location_function): Remove
7416 explicit_loc parameter.
7417 (momentary_breakpoint_from_master): Update call to
7418 set_breakpoint_location_function.
7419 (add_location_to_breakpoint): Likewise.
7420
b3a7d171
AB
74212019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7422
7423 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7424 required features based on default bfd type when no specific bfd
7425 is present.
7426
1f6f6e21
PW
74272019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7428
7429 * NEWS: Mention that GDB printf and eval commands can now print
7430 C-style and Ada-style convenience var strings without
7431 calling the inferior.
7432 * printcmd.c (printf_c_string): Locally print GDB internal var
7433 instead of transiting via the inferior.
7434 (printf_wide_c_string): Likewise.
7435
74362019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7437
5862c886 7438 PR breakpoints/25011
ea142fbf
AH
7439 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7440
0598af48
TT
74412019-07-04 Tom Tromey <tom@tromey.com>
7442
7443 PR tui/24724:
7444 * tui/tui-winsource.c (tui_clear_source_content): Update.
7445 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7446 (tui_update_breakpoint_info): Update.
7447 (tui_set_exec_info_content): Update.
7448 * tui/tui-source.c (tui_set_source_content_nil): Update.
7449 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7450 has_break.
7451 * tui/tui-data.h (enum tui_bp_flag): New.
7452 (tui_bp_flags): New enum flags type.
7453 (struct tui_source_element) <break_mode>: Change type. Rename
7454 from has_break.
7455 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7456 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7457 constants.
7458 * tui/tui-winsource.h: Fix comment.
7459
350fab54
AH
74602019-07-04 Alan Hayward <alan.hayward@arm.com>
7461
7462 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7463 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7464 (store_fpregs_to_thread)
7465 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7466 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7467 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7468 (IWMMXT_REGS_SIZE): Add define.
7469 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7470 (fetch_vfp_regs, store_vfp_regs)
7471 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7472 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7473
f0452268
AH
74742019-07-04 Alan Hayward <alan.hayward@arm.com>
7475
7476 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7477 defines.
7478 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7479 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7480 (ARM_INT_REGISTER_SIZE): ...to this.
7481 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7482 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7483 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7484 (arm_linux_collect_gregset, supply_nwfpe_register)
7485 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7486 defines.
7487 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7488 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7489 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7490 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7491 (arm_return_in_memory, arm_store_return_value)
7492 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7493 (arm_record_ld_st_multiple): Likewise.
7494 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7495 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7496
e935475c
AH
74972019-07-04 Alan Hayward <alan.hayward@arm.com>
7498
7499 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7500 AARCH64_DISPLACED_MODIFIED_INSNS.
7501 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7502 (aarch64_displaced_step_copy_insn): Likewise.
7503 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7504 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7505 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7506 ARM_DISPLACED_MODIFIED_INSNS.
7507 * arm-tdep.c (arm_gdbarch_init): Likewise.
7508 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7509 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7510 (struct arm_displaced_step_closure): Use
7511 ARM_DISPLACED_MODIFIED_INSNS.
7512
df0bb381
AH
75132019-07-04 Alan Hayward <alan.hayward@arm.com>
7514
7515 * features/Makefile: Remove unused xml files.
7516 * features/aarch64.xml: Remove.
7517 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7518 * features/i386/amd64-avx-avx512.xml: Remove.
7519 * features/i386/amd64-avx-linux.xml: Remove.
7520 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7521 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7522 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7523 * features/i386/amd64-avx-mpx.xml: Remove.
7524 * features/i386/amd64-avx.xml: Remove.
7525 * features/i386/amd64-linux.xml: Remove.
7526 * features/i386/amd64-mpx-linux.xml: Remove.
7527 * features/i386/amd64-mpx.xml: Remove.
7528 * features/i386/amd64.xml: Remove.
7529 * features/i386/i386-avx-avx512-linux.xml: Remove.
7530 * features/i386/i386-avx-avx512.xml: Remove.
7531 * features/i386/i386-avx-linux.xml: Remove.
7532 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7533 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7534 * features/i386/i386-avx-mpx-linux.xml: Remove.
7535 * features/i386/i386-avx-mpx.xml: Remove.
7536 * features/i386/i386-avx.xml: Remove.
7537 * features/i386/i386-linux.xml: Remove.
7538 * features/i386/i386-mmx-linux.xml: Remove.
7539 * features/i386/i386-mmx.xml: Remove.
7540 * features/i386/i386-mpx-linux.xml: Remove.
7541 * features/i386/i386-mpx.xml: Remove.
7542 * features/i386/i386.xml: Remove.
7543 * features/i386/x32-avx-avx512-linux.xml: Remove.
7544 * features/i386/x32-avx-linux.xml: Remove.
7545 * features/i386/x32-linux.xml: Remove.
7546
edd6266a
AH
75472019-07-04 Alan Hayward <alan.hayward@arm.com>
7548
7549 * regformats/aarch64.dat: Remove.
7550 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7551 * regformats/i386/amd64-avx-linux.dat: Remove.
7552 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7553 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7554 * regformats/i386/amd64-linux.dat: Remove.
7555 * regformats/i386/amd64-mpx-linux.dat: Remove.
7556 * regformats/i386/amd64.dat: Remove.
7557 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7558 * regformats/i386/i386-avx-linux.dat: Remove.
7559 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7560 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7561 * regformats/i386/i386-linux.dat: Remove.
7562 * regformats/i386/i386-mmx-linux.dat: Remove.
7563 * regformats/i386/i386-mpx-linux.dat: Remove.
7564 * regformats/i386/i386.dat: Remove.
7565 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7566 * regformats/i386/x32-avx-linux.dat: Remove.
7567 * regformats/i386/x32-linux.dat: Remove.
7568
2b40fda7
AH
75692019-07-04 Alan Hayward <alan.hayward@arm.com>
7570
7571 * aarch64-tdep.c: Remove xml self tests.
7572 * amd64-linux-tdep.c: Likewise.
7573 * amd64-tdep.c: Likewise.
7574 * i386-linux-tdep.c: Likewise.
7575 * i386-tdep.c: Likewise.
7576
5f4ba3e7
PA
75772019-07-03 Pedro Alves <palves@redhat.com>
7578
7579 PR cli/24732
7580 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7581 (pipe_cmd_option_defs): New.
7582 (make_pipe_cmd_options_def_group): New.
7583 (pipe_command): Use gdb::option::process_options.
7584 (pipe_command_completer): New function.
7585 (_initialize_cli_cmds): Install completer for "pipe" command.
7586
3d9be6f5
PA
75872019-07-03 Pedro Alves <palves@redhat.com>
7588
7589 * cli/cli-option.c (union option_value) <string>: New field.
7590 (struct option_def_and_value): Add ctor, move ctor, dtor and
7591 use DISABLE_COPY_AND_ASSIGN.
7592 (option_def_and_value::clear_value): New.
7593 (parse_option, save_option_value_in_ctx, get_val_type_str)
7594 (add_setshow_cmds_for_options): Handle var_string.
7595 * cli-option.h (union option_def::var_address) <string>: New
7596 field.
7597 (struct string_option_def): New.
7598 * maint-test-options.c (struct test_options_opts): Add default
7599 ctor and use DISABLE_COPY_AND_ASSIGN.
7600 <string_opt>: New field.
7601 (test_options_opts::~test_options_opts): New.
7602 (test_options_opts::dump): Also dump "-string".
7603 (test_options_option_defs): Install "string.
7604
41fc454c
PA
76052019-07-03 Pedro Alves <palves@redhat.com>
7606
7607 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7608 option_value with a null enumeration.
7609 (complete_options): Save the option values in the context.
7610 (save_option_value_in_ctx): New, factored out from ...
7611 (process_options): ... here.
7612 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7613 of the function.
7614 * maint-test-options.c (test_options_opts::dump): New, factored
7615 out from ...
7616 (maintenance_test_options_command_mode): ... here.
7617 (maintenance_test_options_command_completion_result): Delete.
7618 (maintenance_test_options_command_completion_text): Update
7619 comment.
7620 (maintenance_show_test_options_completion_result): Change
7621 prototype. Just print
7622 maintenance_test_options_command_completion_text.
7623 (save_completion_result): New.
7624 (maintenance_test_options_completer_mode): Pass options context to
7625 complete_options, and then save a dump.
7626 (_initialize_maint_test_options): Use add_cmd to install "maint
7627 show test-options-completion-result".
7628
fdbc9870
PA
76292019-07-03 Pedro Alves <palves@redhat.com>
7630
7631 * NEWS (New commands): Mention "with" and "maint with".
7632 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7633 (with_command, with_command_completer): New.
7634 (pipe_command): Adjust to new repeat_previous
7635 interface.
7636 (_initialize_cli_cmds): Install the "with" command and its "w"
7637 alias.
7638 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7639 declarations.
7640 * cli/cli-setshow.c (parse_cli_var_uinteger)
7641 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7642 argument strings for all var_types.
7643 (get_setshow_command_value_string): New, factored out from ...
7644 (do_show_command): ... this.
7645 * cli/cli-setshow.h: Include <string>.
7646 (get_setshow_command_value_string): Declare.
7647 * command.h (repeat_previous): Now returns const char *. Adjust
7648 comment.
7649 * maint.c: Include "cli/cli-cmds.h".
7650 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7651 (_initialize_maint_cmds): Register the "maintenance with" command.
7652 * top.c (repeat_previous): Move bits from pipe_command here:
7653 Return the saved command line, if any; error out if there's no
7654 command to relaunch.
7655
c6ac8931
PA
76562019-07-03 Pedro Alves <palves@redhat.com>
7657
7658 * NEWS (New commands): Mention "maint set/show test-settings"
7659 instead of "maint test-settings".
7660 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7661 (maintenance_test_settings_set_list): Rename to ...
7662 (maintenance_set_test_settings_list): ... this.
7663 (maintenance_test_settings_show_list): Rename to ...
7664 (maintenance_show_test_settings_list): ... this.
7665 (maintenance_test_settings_cmd): Delete.
7666 (maintenance_test_settings_set_cmd): ...
7667 (maintenance_set_test_settings_cmd): ... this.
7668 (maintenance_test_settings_show_cmd): ...
7669 (maintenance_show_test_settings_cmd): ... this.
7670 (maintenance_test_settings_show_value_cmd):
7671 (maintenance_show_test_settings_value_cmd): ... this.
7672 (_initialize_maint_test_settings): No longer install the "maint
7673 test-settings" prefix command. Rename "maint test-settings set"
7674 to "maint set test-settings", and "maint test-settings show" to
7675 "maint show test-settings". Adjust all subcommands.
7676
d1fcf2fd
PA
76772019-07-03 Pedro Alves <palves@redhat.com>
7678
7679 * maint-test-settings.c: Fix file's intro comment. Replace all
7680 references to "test-options" with references to "test-settings",
7681 in comments.
7682
970f9d09
PA
76832019-07-03 Pedro Alves <palves@redhat.com>
7684
7685 * maint-test-settings.c (maintenance_test_settings_xxx)
7686 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7687 New.
7688 (maintenance_test_settings_enums): Use them.
7689 (maintenance_test_settings_enum): Default to
7690 maintenance_test_settings_xxx.
7691 (_initialize_maint_test_settings): Initialize
7692 MAINTENANCE_TEST_SETTINGS_FILENAME.
7693
f3869b1a
SM
76942019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7695
7696 * breakpoint.h (remove_breakpoints_inf): Change return type to
7697 void, move function documentation here.
7698 * breakpoint.c (remove_breakpoints_inf): Change return type to
7699 void, move function documentation to header.
7700
54d66006
PA
77012019-07-02 Pedro Alves <palves@redhat.com>
7702
7703 * NEWS (Completion improvements): Mention "info threads".
7704 * thread.c (struct info_threads_opts, info_threads_option_defs)
7705 (make_info_threads_options_def_group): New.
7706 (info_threads_command): Use gdb::option::process_options.
7707 (info_threads_command_completer): New.
7708 (_initialize_thread): Use gdb::option::build_help to build the
7709 help text for "info threads".
7710
854f6088
SM
77112019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7712
7713 * defs.h (generic_load): Move from here...
7714 * symfile.h (generic_load): ... to here. Rename name parameter
7715 to args.
7716 * symfile.c (generic_load): Add comment.
7717
54ee4252
TT
77182019-07-01 Tom Tromey <tromey@adacore.com>
7719
7720 * dwarf2read.c
7721 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7722 declaration of without_params. Fix formatting.
7723
65392b3e
TT
77242019-07-01 Tom Tromey <tromey@adacore.com>
7725
7726 * ada-exp.y (find_primitive_type): Update.
7727 * ada-lang.h (ada_lookup_symbol): Update.
7728 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7729 parameter.
7730 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7731
7d7571f0
SDJ
77322019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7733
7734 PR breakpoints/24541
7735 * gdbarch.c: Regenerate.
7736 * gdbarch.h: Regenerate.
7737 * gdbarch.sh: Add 'stap_adjust_register'.
7738 * i386-tdep.c: Include '<unordered_set>'.
7739 (i386_stap_adjust_register): New function.
7740 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7741 * stap-probe.c (stap_parse_register_operand): Call
7742 'gdbarch_stap_adjust_register'.
7743
5af5392a
SDJ
77442019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7745
7746 PR python/24742
7747 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7748 * python/python.c (do_start_initialization): Use 'xmalloc'
7749 instead of 'PyMem_Malloc'.
7750
10d06d82
TT
77512019-06-28 Tom Tromey <tromey@adacore.com>
7752
7753 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7754 for Ada.
7755
1b7f24cd
TT
77562019-06-27 Tom Tromey <tromey@adacore.com>
7757
7758 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7759 objfile_key.
7760 (arm_find_mapping_symbol, arm_record_special_symbol)
7761 (_initialize_arm_tdep): Update.
7762 (arm_objfile_data_free): Remove.
7763
3d507ff2
TT
77642019-06-27 Tom Tromey <tromey@adacore.com>
7765
7766 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7767 to cp_print_static_field.
7768
762c164d
TT
77692019-06-26 Tom Tromey <tromey@adacore.com>
7770
7771 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7772 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7773 declare.
7774
aa2f9bcf
AH
77752019-06-26 Alan Hayward <alan.hayward@arm.com>
7776
7777 * features/aarch64-core.c (create_feature_aarch64_core):
7778 Regenerate.
7779 * features/aarch64-core.xml: Add cpsr flags.
7780
3426ae57
AH
77812019-06-26 Alan Hayward <alan.hayward@arm.com>
7782
7783 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7784 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7785
4838e44c
SM
77862019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7787
7788 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7789 field.
7790 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7791 use.
7792 (arm_record_special_symbol): Don't insert new symbol in sorted
7793 position, push it at the end.
7794
54cc7474
SM
77952019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7796
7797 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7798 (arm_mapping_symbol_s): Remove.
7799 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7800 (arm_mapping_symbol_vec): New typedef.
7801 (struct arm_per_objfile): Add constructor.
7802 <section_maps>: Change type to
7803 std::unique_ptr<arm_mapping_symbol_vec[]>.
7804 (arm_compare_mapping_symbols): Remove.
7805 (arm_find_mapping_symbol): Adjust to section_maps type change.
7806 (arm_objfile_data_free): Call delete on arm_per_objfile.
7807 (arm_record_special_symbol): Adjust to section_maps type change.
7808 Allocate arm_per_objfile with new.
7809
b65b566c
PW
78102019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7811
7812 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7813 with the command prefix.
7814
c2fc64f5
TT
78152019-06-25 Tom Tromey <tom@tromey.com>
7816
7817 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7818 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7819
fb54fa76
TT
78202019-06-25 Tom Tromey <tom@tromey.com>
7821
7822 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7823 type.
7824 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7825 protected.
7826
f7952c57
TT
78272019-06-25 Tom Tromey <tom@tromey.com>
7828
7829 * tui/tui-winsource.c
7830 (tui_source_window_base::set_is_exec_point_at): Add check against
7831 LOA_ADDRESS.
7832
17568d78
TT
78332019-06-25 Tom Tromey <tom@tromey.com>
7834
7835 * tui/tui-source.c (tui_set_source_content): Don't check before
7836 xfree.
7837 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7838
53e7cdba
TT
78392019-06-25 Tom Tromey <tom@tromey.com>
7840
7841 * tui/tui-winsource.h (tui_update_source_window_as_is)
7842 (tui_alloc_source_buffer, tui_line_is_displayed)
7843 (tui_addr_is_displayed): Change type of win_info.
7844 * tui/tui-winsource.c (tui_update_source_window_as_is)
7845 (tui_clear_source_content, tui_show_source_line)
7846 (tui_show_source_content, tui_source_window_base::refill)
7847 (tui_source_window_base::set_is_exec_point_at)
7848 (tui_source_window_base::set_is_exec_point_at)
7849 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7850 (tui_alloc_source_buffer, tui_line_is_displayed)
7851 (tui_addr_is_displayed): Change type of win_info. Update.
7852 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7853 (tui_source_window_base::do_make_visible_with_new_height):
7854 Update.
7855 * tui/tui-source.c (tui_set_source_content)
7856 (tui_set_source_content_nil)
7857 (tui_source_window::do_scroll_vertical): Update.
7858 * tui/tui-layout.c (show_layout): Update.
7859 * tui/tui-disasm.c (tui_set_disassem_content)
7860 (tui_disasm_window::do_scroll_vertical): Update.
7861 * tui/tui-data.h (tui_win_content): Remove.
7862 (struct tui_gen_win_info) <content, content_size>: Remove.
7863 (struct tui_source_element): Add initializers and destructor.
7864 (union tui_which_element, struct tui_win_element): Remove.
7865 (struct tui_source_window_base) <content>: New field.
7866 (struct tui_data_window): Remove destructor.
7867 (tui_alloc_content, tui_free_win_content)
7868 (tui_free_all_source_wins_content): Don't declare.
7869 * tui/tui-data.c (tui_initialize_static_data): Update.
7870 (init_content_element, tui_alloc_content): Remove.
7871 (~tui_gen_win_info): Update.
7872 (~tui_data_window, tui_free_all_source_wins_content)
7873 (tui_free_win_content, free_content, free_content_elements):
7874 Remove.
7875
7908abbf
TT
78762019-06-25 Tom Tromey <tom@tromey.com>
7877
7878 * tui/tui-winsource.h (tui_clear_source_content)
7879 (tui_erase_source_content, tui_show_source_content): Change type
7880 of win_info.
7881 * tui/tui-winsource.c (tui_clear_source_content)
7882 (tui_erase_source_content, tui_show_source_content): Change type
7883 of win_info.
7884 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7885 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7886 win_info.
7887 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7888 win_info.
7889 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7890
02c28df0
TT
78912019-06-25 Tom Tromey <tom@tromey.com>
7892
7893 * tui/tui-winsource.c (tui_clear_source_content)
7894 (tui_source_window_base::set_is_exec_point_at): Update.
7895 * tui/tui-source.c (tui_set_source_content_nil): Update.
7896 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7897 a bool.
7898 * tui/tui-data.c (init_content_element): Update.
7899
6658b1bf
TT
79002019-06-25 Tom Tromey <tom@tromey.com>
7901
7902 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7903 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7904 * tui/tui-layout.c (init_and_make_win): Update.
7905 * tui/tui.h (enum tui_win_type): Update.
7906 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7907 tui_win_is_auxillary.
7908 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7909 tui_win_is_auxillary.
7910
21e1c91e
TT
79112019-06-25 Tom Tromey <tom@tromey.com>
7912
7913 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7914 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7915 (tui_delete_data_content_windows, tui_display_all_data)
7916 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7917 Update.
7918 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7919 * tui/tui-regs.c (tui_last_regs_line_no)
7920 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7921 (tui_show_registers): Update.
7922 (tui_show_register_group): Return void. Update.
7923 (tui_display_registers_from, tui_display_reg_element_at_line)
7924 (tui_display_registers_from_line, tui_check_register_values):
7925 Update.
7926 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7927 member.
7928 (struct tui_data_window) <regs_content>: Now a std::vector.
7929 <regs_content_count>: Remove.
7930 (tui_add_content_elements, tui_free_data_content): Don't declare.
7931 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7932 (init_content_element): Remove DATA_WIN case. Add assert.
7933 (tui_add_content_elements): Remove.
7934 (tui_data_window): Update.
7935 (tui_free_data_content): Remove.
7936 (free_content_elements): Remove DATA_WIN case.
7937
115ac53b
TT
79382019-06-25 Tom Tromey <tom@tromey.com>
7939
7940 * tui/tui-data.c (tui_data_item_window): Update.
7941 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7942 * tui/tui-windata.c (tui_display_all_data)
7943 (tui_display_data_from_line): Update.
7944 (tui_check_data_values): Remove.
7945 * tui/tui-regs.c (tui_show_register_group)
7946 (tui_display_reg_element_at_line): Update.
7947 * tui/tui-hooks.c (tui_register_changed)
7948 (tui_refresh_frame_and_register_information): Call
7949 tui_check_register_values.
7950 * tui/tui-data.h (struct tui_data_window) <data_content,
7951 data_content_count, data_type>: Remove.
7952 (enum tui_data_type): Remove.
7953
7954 * tui/tui-data.c (tui_data_window::clear_detail)
7955 (~tui_data_window): Update.
7956
eaf9738b
TT
79572019-06-25 Tom Tromey <tom@tromey.com>
7958
7959 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7960 declare.
7961 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7962 Rename from tui_first_data_item_displayed. Update.
7963 (tui_data_window::refresh_all)
7964 (tui_data_window::do_scroll_vertical): Update.
7965 * tui/tui-data.h (struct tui_data_window)
7966 <first_data_item_displayed>: Declare new method.
7967
31ca4723
TT
79682019-06-25 Tom Tromey <tom@tromey.com>
7969
7970 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7971 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7972 contents...
7973 (tui_initialize_static_data): ...here.
7974
41bcff7f
TT
79752019-06-25 Tom Tromey <tom@tromey.com>
7976
7977 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7978 (tui_display_registers_from, tui_check_register_values): Update.
7979 (tui_display_register): Remove win_info parameter; update.
7980 (tui_get_register): Change type of parameters.
7981 * tui/tui-data.h (struct tui_data_element): Remove.
7982 (union tui_which_element) <data>: Remove.
7983 <data_window>: Change type.
7984 (struct tui_data_item_window): New.
7985 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7986 case. Add assert.
7987 (~tui_data_item_window): New destructor.
7988 (free_content_elements): Remove DATA_ITEM_WIN case.
7989
d2802c33
TT
79902019-06-25 Tom Tromey <tom@tromey.com>
7991
7992 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7993 Remove.
7994
dd835f8b
TT
79952019-06-25 Tom Tromey <tom@tromey.com>
7996
7997 * tui/tui-data.h (struct tui_command_element): Remove.
7998 (union tui_which_element) <command>: Remove.
7999 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8000 assert.
8001 (free_content_elements): Remove CMD_WIN case.
8002
bd7db367
TT
80032019-06-25 Tom Tromey <tom@tromey.com>
8004
8005 * tui/tui-layout.c (tui_set_layout): Update.
8006 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8007 * tui/tui-data.c (layout_def): Update.
8008
3add462f
TT
80092019-06-25 Tom Tromey <tom@tromey.com>
8010
8011 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8012 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8013 (tui_source_window_base::set_new_height): Update.
8014 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8015 Update.
8016 (tui_set_locator_fullname, tui_set_locator_info)
8017 (tui_show_frame_info): Update.
8018 * tui/tui-source.c (tui_set_source_content)
8019 (tui_source_is_displayed): Update.
8020 * tui/tui-layout.c (show_source_disasm_command, show_data)
8021 (show_source_or_disasm_and_command): Update.
8022 * tui/tui-disasm.c (tui_set_disassem_content)
8023 (tui_get_begin_asm_address): Update.
8024 * tui/tui-data.h (struct tui_locator_element): Remove.
8025 (union tui_which_element) <locator>: Remove.
8026 (struct tui_locator_window): New.
8027 (tui_locator_win_info_ptr): Change return type.
8028 * tui/tui-data.c (_locator): Change type.
8029 (tui_locator_win_info_ptr): Change return type.
8030 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8031 (tui_alloc_content): Add assert.
8032
489e9d8b
TT
80332019-06-25 Tom Tromey <tom@tromey.com>
8034
8035 * tui/tui-winsource.c
8036 (tui_exec_info_window::maybe_allocate_content): New method.
8037 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8038 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8039 (make_source_or_disasm_window): Add cast.
8040 * tui/tui-data.h (union tui_which_element) <simple_string>:
8041 Remove.
8042 (struct tui_source_info): New.
8043 (struct tui_source_window_base) <execution_info>: Change type.
8044 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8045 case, and add assert.
8046 (tui_alloc_content): Add assert.
8047
c3fabb7d
TT
80482019-06-25 Tom Tromey <tom@tromey.com>
8049
8050 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8051 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8052 * tui/tui-data.c (tui_alloc_win_info): Remove.
8053
bbc228ee
TT
80542019-06-25 Tom Tromey <tom@tromey.com>
8055
8056 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8057 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8058 can_highlight.
8059
5fcee43a
TT
80602019-06-25 Tom Tromey <tom@tromey.com>
8061
8062 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8063 make_visible_with_new_height method.
8064 (tui_win_info::make_visible_with_new_height): New method.
8065 (tui_source_window_base::do_make_visible_with_new_height)
8066 (tui_data_window::do_make_visible_with_new_height)
8067 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8068 (make_visible_with_new_height): Remove.
8069 (tui_resize_all, tui_adjust_win_heights): Use
8070 make_visible_with_new_height method.
8071 * tui/tui-data.h (struct tui_win_info)
8072 <do_make_visible_with_new_height, make_visible_with_new_height>:
8073 New methods.
8074 (struct tui_source_window_base, struct tui_data_window)
8075 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8076 methods.
8077
d83f1fe6
TT
80782019-06-25 Tom Tromey <tom@tromey.com>
8079
8080 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8081 method.
8082 (update_tab_width): Call update_tab_width method.
8083 * tui/tui-data.h (struct tui_win_info)
8084 (struct tui_source_window_base) <update_tab_width>: New methods.
8085
17374de4
TT
80862019-06-25 Tom Tromey <tom@tromey.com>
8087
8088 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8089 parameter.
8090 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8091 parameter.
8092 (tui_gen_win_info::make_visible): Update.
8093 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8094 parameter.
8095 * tui/tui-data.h (enum tui_box): New enum.
8096 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8097
f936bca2
TT
80982019-06-25 Tom Tromey <tom@tromey.com>
8099
8100 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8101 init_and_make_win for EXEC_INFO_WIN.
8102 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8103 longer inline.
8104 (struct tui_win_info) <~tui_win_info>: Inline.
8105 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8106 Don't declare.
8107 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8108 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8109 Remove.
8110 (tui_initialize_static_data): Update.
8111 (~tui_gen_win_info): Handle more cleanup here.
8112 (~tui_source_window_base): Delete "execution_info".
8113 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8114
d6ba6a11
TT
81152019-06-25 Tom Tromey <tom@tromey.com>
8116
8117 * tui/tui-layout.c (make_command_window): Don't set
8118 can_highlight.
8119 (show_source_disasm_command): Call the reset method.
8120 (show_data): Don't set can_highlight. Call the reset method.
8121 (tui_gen_win_info::reset): Rename from init_gen_win_info
8122 (init_and_make_win): Simplify. Return tui_gen_win_info.
8123 (show_source_or_disasm_and_command): Call the reset method.
8124 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8125 (struct tui_cmd_window): Set can_highlight.
8126
48a3bd16
TT
81272019-06-25 Tom Tromey <tom@tromey.com>
8128
8129 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8130 from make_visible.
8131 (tui_make_visible, tui_make_invisible): Rewrite.
8132 (tui_win_info::make_visible): Remove.
8133 (tui_source_window_base::make_visible): Update.
8134 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8135 method. Moved from...
8136 (struct tui_win_info) <make_visible>: ...here.
8137
c3bd716f
TT
81382019-06-25 Tom Tromey <tom@tromey.com>
8139
8140 * tui/tui-winsource.c
8141 (tui_source_window_base::do_scroll_horizontal): Remove direction
8142 parameter.
8143 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8144 direction parameter.
8145 * tui/tui-win.c (tui_win_info::forward_scroll)
8146 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8147 (tui_win_info::right_scroll): Update.
8148 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8149 direction parameter.
8150 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8151 direction parameter.
8152 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8153 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8154 Remove direction parameter.
8155 (struct tui_source_window_base, struct tui_source_window)
8156 (struct tui_disasm_window, struct tui_data_window)
8157 (struct tui_cmd_window): Update.
8158
21c32dca
TT
81592019-06-25 Tom Tromey <tom@tromey.com>
8160
8161 * tui/tui-winsource.h (tui_set_exec_info_content)
8162 (tui_show_exec_info_content, tui_erase_exec_info_content)
8163 (tui_clear_exec_info_content, tui_update_exec_info): Change
8164 argument to tui_source_window_base.
8165 * tui/tui-winsource.c (tui_set_exec_info_content)
8166 (tui_show_exec_info_content, tui_erase_exec_info_content)
8167 (tui_clear_exec_info_content, tui_update_exec_info): Change
8168 argument to tui_source_window_base.
8169
73fbdc65
TT
81702019-06-25 Tom Tromey <tom@tromey.com>
8171
8172 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8173 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8174
33325343
TT
81752019-06-25 Tom Tromey <tom@tromey.com>
8176
8177 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8178 check.
8179
29d2c474
TT
81802019-06-25 Tom Tromey <tom@tromey.com>
8181
8182 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8183 type to void.
8184 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8185 type to void.
8186 * tui/tui-source.c (tui_set_source_content): Update.
8187 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8188
152f3f4b
TT
81892019-06-25 Tom Tromey <tom@tromey.com>
8190
8191 * tui/tui-win.c (window_name_completer, tui_set_focus)
8192 (tui_all_windows_info): Use name method.
8193 * tui/tui-data.h (struct tui_gen_win_info)
8194 (struct tui_source_window, struct tui_disasm_window)
8195 (struct tui_data_window, struct tui_cmd_window) <name>: New
8196 method.
8197 (tui_win_name): Don't declare.
8198 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8199 (tui_win_name): Remove.
8200
be4da588
TT
82012019-06-25 Tom Tromey <tom@tromey.com>
8202
8203 * tui/tui-winsource.h (tui_update_source_window)
8204 (tui_update_source_window_as_is): Change parameter type.
8205 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8206 to be a tui_source_window_base.
8207 (tui_update_source_window_as_is): Likewise.
8208 * tui/tui-win.c (make_visible_with_new_height): Update.
8209
5b81daba
TT
82102019-06-25 Tom Tromey <tom@tromey.com>
8211
8212 * tui/tui-winsource.c (tui_erase_source_content)
8213 (tui_show_source_content, tui_show_exec_info_content)
8214 (tui_erase_exec_info_content): Use refresh_window method.
8215 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8216 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8217 from tui_refresh_win.
8218 (tui_data_window::refresh_window): New method.
8219 (tui_win_info::refresh, tui_source_window_base::refresh)
8220 (tui_refresh_all): Use refresh_window method.
8221 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8222 method.
8223 * tui/tui-regs.c (tui_display_register): Call refresh_window
8224 method.
8225 * tui/tui-layout.c (show_source_disasm_command)
8226 (show_source_or_disasm_and_command): Call refresh_window method.
8227 * tui/tui-data.h (struct tui_gen_win_info)
8228 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8229 New method.
8230
cb2ce893
TT
82312019-06-25 Tom Tromey <tom@tromey.com>
8232
8233 * tui/tui.c (tui_rl_other_window, tui_enable)
8234 (tui_is_window_visible, tui_get_command_dimension): Update.
8235 * tui/tui-winsource.c (tui_update_source_window_as_is)
8236 (tui_clear_source_content, tui_erase_source_content)
8237 (tui_show_source_line, tui_source_window_base::refill)
8238 (tui_source_window_base::do_scroll_horizontal)
8239 (tui_source_window_base::set_is_exec_point_at)
8240 (tui_update_breakpoint_info, tui_set_exec_info_content)
8241 (tui_alloc_source_buffer, tui_line_is_displayed)
8242 (tui_addr_is_displayed): Update.
8243 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8244 (tui_check_and_display_highlight_if_needed)
8245 (tui_win_info::make_visible, tui_win_info::refresh)
8246 (tui_refresh_all): Update.
8247 * tui/tui-windata.c (tui_first_data_item_displayed)
8248 (tui_delete_data_content_windows, tui_erase_data_content)
8249 (tui_display_all_data, tui_data_window::refresh_all)
8250 (tui_check_data_values): Update.
8251 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8252 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8253 (tui_win_info::backward_scroll, tui_refresh_all_win)
8254 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8255 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8256 (tui_source_window_base::set_new_height)
8257 (tui_data_window::set_new_height)
8258 (make_invisible_and_set_new_height)
8259 (make_visible_with_new_height, new_height_ok)
8260 (parse_scrolling_args): Update.
8261 * tui/tui-stack.c (tui_show_frame_info): Update.
8262 * tui/tui-source.c (tui_set_source_content)
8263 (tui_set_source_content_nil, tui_source_is_displayed)
8264 (tui_source_window::do_scroll_vertical): Update.
8265 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8266 (tui_display_registers_from, tui_display_reg_element_at_line)
8267 (tui_check_register_values, tui_reg_command): Update.
8268 * tui/tui-layout.c (tui_default_win_height)
8269 (show_source_disasm_command, show_data, init_and_make_win)
8270 (show_source_or_disasm_and_command): Update.
8271 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8272 (tui_redisplay_readline, tui_mld_flush)
8273 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8274 (tui_getc): Update.
8275 * tui/tui-disasm.c (tui_set_disassem_content)
8276 (tui_disasm_window::do_scroll_vertical): Update.
8277 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8278 Now virtual.
8279 (struct tui_win_info): Derive from tui_gen_win_info.
8280 <~tui_win_info>: Mark as override.
8281 <generic>: Remove member.
8282 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8283 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8284 (~tui_data_window, ~tui_win_info)
8285 (tui_free_all_source_wins_content): Update.
8286 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8287
ab313b35
TT
82882019-06-25 Tom Tromey <tom@tromey.com>
8289
8290 * tui/tui-layout.c (init_and_make_win): Use new.
8291 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8292 destructor, initializers.
8293 (tui_alloc_generic_win_info): Don't declare.
8294 * tui/tui-data.c (_locator): Add argument to constructor.
8295 (source_win, disasm_win): New globals.
8296 (exec_info): Remove.
8297 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8298 Update.
8299 (tui_alloc_generic_win_info): Remove.
8300 (init_content_element): Use new.
8301 (tui_win_info::tui_win_info): Update.
8302 (free_content_elements) <case DATA_WIN>: Use delete.
8303
dc2c33e4
TT
83042019-06-25 Tom Tromey <tom@tromey.com>
8305
8306 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8307 * tui/tui-windata.c (tui_first_data_item_displayed)
8308 (tui_delete_data_content_windows): Update.
8309 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8310 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8311 (tui_display_registers_from, tui_check_register_values): Update.
8312 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8313 pointer.
8314 * tui/tui-data.c (init_content_element): Update. Allocate the new
8315 window.
8316 (tui_free_data_content): Update.
8317 (free_content_elements) <case DATA_WIN>: Free the window.
8318
214a5cbe
TT
83192019-06-25 Tom Tromey <tom@tromey.com>
8320
8321 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8322 Update.
8323 * tui/tui-layout.c (make_command_window)
8324 (show_source_disasm_command, show_data, init_and_make_win)
8325 (show_source_or_disasm_and_command): Update.
8326 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8327 method.
8328 <can_highight, is_highlighted>: Now bool.
8329 (tui_set_win_highlight): Don't declare.
8330 * tui/tui-data.c (tui_set_win_highlight): Remove.
8331
8e2daf15
TT
83322019-06-25 Tom Tromey <tom@tromey.com>
8333
8334 * tui/tui-wingeneral.c (make_visible): Remove check of window
8335 type.
8336
8903bd8a
TT
83372019-06-25 Tom Tromey <tom@tromey.com>
8338
8339 * tui/tui-win.c (tui_win_info::max_height)
8340 (tui_cmd_window::max_height): New methods.
8341 (new_height_ok): Call max_height.
8342 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8343 <max_height>: New method.
8344
3f02ce1e
TT
83452019-06-25 Tom Tromey <tom@tromey.com>
8346
8347 * tui/tui-win.c (tui_source_window_base::set_new_height)
8348 (tui_data_window::set_new_height): New methods.
8349 (make_invisible_and_set_new_height): Call set_new_height method.
8350 * tui/tui-data.h (struct tui_win_info)
8351 (struct tui_source_window_base, struct tui_data_window)
8352 <set_new_height>: New method.
8353
1825f487
TT
83542019-06-25 Tom Tromey <tom@tromey.com>
8355
8356 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8357 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8358 tui_refresh_data_win.
8359 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8360 method.
8361 (tui_refresh_all_win): Call the refresh_all method.
8362 (tui_set_focus): Likewise.
8363 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8364 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8365 Likewise.
8366
ad54d15b
TT
83672019-06-25 Tom Tromey <tom@tromey.com>
8368
8369 * tui/tui-winsource.h (tui_refill_source_window)
8370 (tui_set_is_exec_point_at): Don't declare.
8371 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8372 (tui_source_window_base::refill): Rename from
8373 tui_refill_source_window.
8374 (tui_source_window_base::do_scroll_horizontal): Update.
8375 (tui_source_window_base::set_is_exec_point_at): Rename from
8376 tui_set_is_exec_point_at.
8377 (tui_update_all_breakpoint_info): Update.
8378 * tui/tui-stack.c (tui_show_frame_info): Update.
8379 * tui/tui-layout.c (show_data): Add cast.
8380 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8381 * tui/tui-data.h (struct tui_source_window_base) <refill,
8382 set_is_exec_point_at>: New methods.
8383 (tui_source_windows, tui_add_to_source_windows): Update types.
8384 (tui_add_to_source_windows): Remove redundant declaration.
8385 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8386 (tui_source_windows): Change return type.
8387 (tui_clear_source_windows_detail): Update.
8388 (tui_add_to_source_windows): Change type of parameter.
8389 (tui_free_all_source_wins_content): Update.
8390
2042b506
TT
83912019-06-25 Tom Tromey <tom@tromey.com>
8392
8393 * tui/tui-wingeneral.c (tui_win_info::refresh)
8394 (tui_source_window_base::refresh): New methods.
8395 (tui_refresh_all): Call the refresh method.
8396 * tui/tui-data.h (struct tui_win_info)
8397 (struct tui_source_window_base) <refresh>: New method.
8398
56122977
TT
83992019-06-25 Tom Tromey <tom@tromey.com>
8400
8401 * tui/tui.h (tui_is_window_visible): Return bool.
8402 * tui/tui.c (tui_is_window_visible): Return bool.
8403 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8404 (tui_make_visible, tui_make_invisible)
8405 (tui_win_info::make_visible)
8406 (tui_source_window_base::make_visible, make_all_visible)
8407 (tui_make_all_visible, tui_make_all_invisible): Update.
8408 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8409 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8410 bool.
8411 (struct tui_win_info, struct tui_source_window_base)
8412 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8413 * tui/tui-data.c (tui_init_generic_part): Update.
8414
cda37efb
TT
84152019-06-25 Tom Tromey <tom@tromey.com>
8416
8417 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8418 (tui_source_window_base::make_visible): New methods.
8419 (make_all_visible): Make method call.
8420 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8421 (struct tui_source_window_base, struct tui_cmd_window): Override
8422 make_visible.
8423 (tui_win_is_source_type): Don't declare.
8424 * tui/tui-data.c (tui_win_is_source_type): Remove.
8425
6a0ee02c
TT
84262019-06-25 Tom Tromey <tom@tromey.com>
8427
8428 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8429 NULL check.
8430
63901aec
TT
84312019-06-25 Tom Tromey <tom@tromey.com>
8432
8433 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8434 Inline constructor. Add initializers for members.
8435 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8436 constructors; now inline in class.
8437
ceb13a13
TT
84382019-06-25 Tom Tromey <tom@tromey.com>
8439
8440 * tui/tui-regs.c (tui_show_registers): Update.
8441 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8442 bool.
8443 * tui/tui-data.c (tui_data_window::clear_detail)
8444 (tui_data_window): Update.
8445
238eb706
TT
84462019-06-25 Tom Tromey <tom@tromey.com>
8447
8448 * tui/tui-windata.c (tui_display_all_data)
8449 (tui_display_data_from_line, tui_display_data_from)
8450 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8451 Update.
8452 * tui/tui-regs.c (tui_last_regs_line_no)
8453 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8454 (tui_show_registers, tui_show_register_group)
8455 (tui_display_registers_from, tui_display_reg_element_at_line)
8456 (tui_display_registers_from_line, tui_check_register_values)
8457 (tui_reg_next, tui_reg_prev): Update.
8458 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8459 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8460 tui_data_window.
8461 (struct tui_win_info) <detail>: Remove. Add new fields from
8462 tui_data_info.
8463 (TUI_DATA_WIN): Add cast.
8464 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8465 (~tui_data_window): Simplify.
8466
81491aa0
TT
84672019-06-25 Tom Tromey <tom@tromey.com>
8468
8469 * tui/tui-layout.c (show_source_disasm_command)
8470 (show_source_or_disasm_and_command): Update.
8471 * tui/tui-io.c (update_cmdwin_start_line)
8472 (tui_redisplay_readline): Update.
8473 * tui/tui-data.h (struct tui_command_info): Remove.
8474 (struct tui_win_info) <detail>: Remove command_info member.
8475 (struct tui_data_window) <start_line>: New member, from
8476 tui_command_info.
8477 (TUI_CMD_WIN): Add casts.
8478
e6e41501
TT
84792019-06-25 Tom Tromey <tom@tromey.com>
8480
8481 * tui/tui-winsource.c (tui_update_source_window)
8482 (tui_refill_source_window)
8483 (tui_source_window_base::do_scroll_horizontal)
8484 (tui_update_breakpoint_info, tui_set_exec_info_content)
8485 (tui_show_exec_info_content, tui_erase_exec_info_content)
8486 (tui_clear_exec_info_content): Update.
8487 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8488 Update.
8489 * tui/tui-win.c (make_invisible_and_set_new_height)
8490 (make_visible_with_new_height): Update.
8491 * tui/tui-source.c (tui_set_source_content)
8492 (tui_show_symtab_source): Update.
8493 * tui/tui-layout.c (extract_display_start_addr)
8494 (show_source_disasm_command, show_data)
8495 (make_source_or_disasm_window)
8496 (show_source_or_disasm_and_command): Update.
8497 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8498 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8499 "gdbarch".
8500 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8501 to tui_source_window_base.
8502 (struct tui_win_info) <detail>: Remove source_info member.
8503 (struct tui_source_window_base) <has_locator>: Inline.
8504 Move contents from tui_source_info; rename has_locator member to
8505 m_has_locator.
8506 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8507 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8508 header file.
8509 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8510 Simplify.
8511 (tui_free_all_source_wins_content): Cast to
8512 tui_source_window_base.
8513
44f0e208
TT
85142019-06-25 Tom Tromey <tom@tromey.com>
8515
8516 * tui/tui-win.c (make_invisible_and_set_new_height)
8517 (make_visible_with_new_height): Call has_locator method.
8518 * tui/tui-layout.c (show_source_disasm_command, show_data)
8519 (show_source_or_disasm_and_command): Update for bool change.
8520 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8521 (tui_win_info) <has_locator>: New method.
8522 (struct tui_source_window_base) <has_locator>: New method.
8523 (tui_win_has_locator): Don't declare.
8524 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8525 from tui_win_has_locator.
8526 (tui_source_window_base): Use false, not FALSE.
8527
7778b912
TT
85282019-06-25 Tom Tromey <tom@tromey.com>
8529
8530 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8531 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8532 clear_detail method directly.
8533 (tui_clear_win_detail): Remove.
8534
f83d391c
TT
85352019-06-25 Tom Tromey <tom@tromey.com>
8536
8537 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8538 "this", not TUI_DISASM_WIN.
8539
13446e05
TT
85402019-06-25 Tom Tromey <tom@tromey.com>
8541
8542 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8543 declare.
8544 * tui/tui-winsource.c
8545 (tui_source_window_base::do_scroll_horizontal): Rename from
8546 tui_horizontal_source_scroll.
8547 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8548 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8549 from tui_vertical_data_scroll.
8550 * tui/tui-win.h (tui_scroll): Don't declare.
8551 * tui/tui-win.c (tui_win_info::forward_scroll)
8552 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8553 (tui_win_info::right_scroll): Rename and update.
8554 (tui_scroll_forward_command, tui_scroll_backward_command)
8555 (tui_scroll_left_command, tui_scroll_right_command): Update.
8556 (tui_scroll): Remove.
8557 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8558 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8559 from tui_vertical_source_scroll.
8560 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8561 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8562 from tui_vertical_disassem_scroll.
8563 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8564 do_scroll_horizontal>: New methods.
8565 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8566 Likewise.
8567 (struct tui_source_window_base): Add do_scroll_horizontal.
8568 (struct tui_source_window, struct tui_disasm_window): Add
8569 do_scroll_vertical.
8570 (struct tui_data_window, struct tui_cmd_window): Add
8571 do_scroll_horizontal and do_scroll_vertical.
8572 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8573
5cf82909
TT
85742019-06-25 Tom Tromey <tom@tromey.com>
8575
8576 * tui/tui-data.h (struct tui_source_window_base): New struct.
8577 (struct tui_source_window): Derive from tui_source_window_base.
8578 (struct tui_disasm_window): New struct.
8579 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8580 from tui_source_window::clear_detail.
8581 (tui_source_window_base): Rename from tui_source_window.
8582 (~tui_source_window_base): Rename from ~tui_source_window.
8583 (tui_alloc_win_info): Create a tui_disasm_window.
8584
ee1d42d6
TT
85852019-06-25 Tom Tromey <tom@tromey.com>
8586
8587 * tui/tui-data.h (struct tui_source_window)
8588 (struct tui_data_window): Declare destructors.
8589 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8590 destructors.
8591 (tui_win_info): Simplify.
8592
b4eb2452
TT
85932019-06-25 Tom Tromey <tom@tromey.com>
8594
8595 * tui/tui-winsource.c (tui_display_main)
8596 (tui_update_source_windows_with_addr)
8597 (tui_update_all_breakpoint_info): Update.
8598 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8599 (new_height_ok, parse_scrolling_args): Update.
8600 * tui/tui-stack.c (tui_show_frame_info): Update.
8601 * tui/tui-data.h (struct tui_list): Remove.
8602 (tui_source_windows): Return a reference to a std::vector.
8603 * tui/tui-data.c (source_windows): Now a std::vector.
8604 (tui_source_windows): Change return type.
8605 (tui_clear_source_windows): Rewrite.
8606 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8607 (tui_free_all_source_wins_content): Rewrite.
8608
8761a91b
TT
86092019-06-25 Tom Tromey <tom@tromey.com>
8610
8611 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8612 (struct tui_data_window, struct tui_cmd_window): Declare
8613 clear_detail method.
8614 * tui/tui-data.c (tui_source_window::clear_detail)
8615 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8616 methods.
8617 (tui_clear_win_detail): Simplify.
8618
0ed69eda
TT
86192019-06-25 Tom Tromey <tom@tromey.com>
8620
8621 * tui/tui-layout.c (make_source_window, make_disasm_window)
8622 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8623 Return the new window.
8624 (show_source_disasm_command, show_data)
8625 (show_source_or_disasm_and_command): Update.
8626
82432e10
TT
86272019-06-25 Tom Tromey <tom@tromey.com>
8628
8629 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8630 parameter. Return the new window.
8631 (show_source_disasm_command): Update and remove NULL check.
8632 (show_source_or_disasm_and_command): Update.
8633
ec328aa5
TT
86342019-06-25 Tom Tromey <tom@tromey.com>
8635
8636 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8637
33b906ab
TT
86382019-06-25 Tom Tromey <tom@tromey.com>
8639
8640 * tui/tui-data.h (struct tui_win_info): Make constructor
8641 protected. Make destructor virtual. Add initializers.
8642 (tui_source_window, tui_data_window, tui_cmd_window): New
8643 classes.
8644 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8645 constructor. Add "type" parameter.
8646 (tui_source_window, tui_data_window, tui_cmd_window): New
8647 constructors.
8648 (tui_alloc_win_info): Instantiate the appropriate subclass.
8649
e7e11af4
TT
86502019-06-25 Tom Tromey <tom@tromey.com>
8651
8652 * tui/tui-win.c (tui_resize_all): Use delete.
8653 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8654 destructor.
8655 (tui_free_window): Don't declare.
8656 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8657 Update.
8658
6792b55e
TT
86592019-06-25 Tom Tromey <tom@tromey.com>
8660
8661 * tui/tui-data.h (struct tui_win_info): Add constructor.
8662 * tui/tui-data.c (tui_alloc_win_info): Use new.
8663 (tui_free_window): Use delete.
8664
f95675e1
TT
86652019-06-22 Tom Tromey <tom@tromey.com>
8666
8667 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8668 declare.
8669 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8670
5bff081c
TT
86712019-06-22 Tom Tromey <tom@tromey.com>
8672
8673 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8674 declare.
8675 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8676
47e3f474
TV
86772019-06-22 Tom de Vries <tdevries@suse.de>
8678
8679 * dwarf2read.c (create_addrmap_from_aranges)
8680 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8681 instead of '%zu'.
8682
fd5866f6
SM
86832019-06-21 Simon Marchi <simon.marchi@efficios.com>
8684
8685 * dwarf2read.h (dwarf2_section_info_def): Remove.
8686 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8687 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8688 std::vector<dwarf2_section_info>.
8689 (struct dwo_file) <~dwo_file>: Remove.
8690 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8691 types field.
8692 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8693 (dwarf2_read_debug_names): Likewise.
8694 (create_debug_types_hash_table): Change parameter type to
8695 array_view, adjust code accordingly.
8696 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8697 (partial_die_info::fixup): Likewise.
8698 (determine_prefix): Likewise.
8699 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8700
fb1eb2f9
SM
87012019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8702
8703 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8704 gdb_bfd_ref_ptr.
8705 <~dwo_file>: Remove call to gdb_bfd_unref.
8706 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8707 gdb_bfd_ref_ptr::get.
8708
51ac9db5
SM
87092019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8710
8711 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8712 type to htab_up.
8713 * dwarf2read.c (struct dwo_file): Initialize fields.
8714 <~dwo_file>: New.
8715 (free_dwo_file): Remove, move content to ~dwo_file.
8716 (struct dwo_file_deleter): Remove.
8717 (dwo_file_up>: Remove custom deleter.
8718 (free_dwo_files): Remove.
8719 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8720 dwo_files.
8721 (process_skeletonless_type_units): Call unique_ptr::get.
8722 (allocate_dwo_file_hash_table): Add deleter to created hash
8723 table. Change return type to htab_up.
8724 (lookup_dwo_file_slot): Don't memset dwo_file, call
8725 unique_ptr::get.
8726 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8727 (create_dwo_unit_in_dwp_v2): Likewise.
8728 (open_and_init_dwo_file): Likewise.
8729 (free_dwo_file_from_slot): Remove.
8730
dc4ccb6f
SM
87312019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8732
8733 * dwarf2read.h (struct dwarf2_section_info) <readin,
8734 is_virtual>: Change type to bool.
8735 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8736 true instead of 1.
8737
e6a1c5cb
TT
87382019-06-19 Tom Tromey <tom@tromey.com>
8739
8740 * tui/tui-data.h (tui_init_content_element): Don't declare.
8741
6f6ffbeb
TT
87422019-06-19 Tom Tromey <tom@tromey.com>
8743
8744 * tui/tui-data.h (tui_init_win_info): Don't declare.
8745
f23f598e
TV
87462019-06-19 Tom de Vries <tdevries@suse.de>
8747
8748 * dwarf2read.h (abstract_to_concrete): Change type to
8749 std::unordered_map<sect_offset, std::vector<sect_offset>,
8750 gdb::hash_enum<sect_offset>>.
8751
680e1bee
TT
87522019-06-19 Tom Tromey <tromey@adacore.com>
8753
8754 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8755 EVAL_AVOID_SIDE_EFFECTS specially.
8756
dcf37923
TT
87572019-06-19 Tom Tromey <tromey@adacore.com>
8758
8759 * source-cache.c (highlighter): New global.
8760 (source_cache::get_source_lines): Create a highlighter on demand.
8761
494986d5
AB
87622019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8763
8764 * defs.h (deprecated_interactive_hook): Delete declaration.
8765 * interps.c (clear_interpreter_hooks): Remove use of
8766 deprecated_interactive_hook.
8767 * top.c (deprecated_interactive_hook): Delete definition.
8768 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8769
3360b6e7
TV
87702019-06-18 Tom de Vries <tdevries@suse.de>
8771
8772 PR gdb/24515
8773 * dwarf2read.h (abstract_to_concrete): Change type from
8774 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8775 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8776 * dwarf2read.c (read_variable): Update.
8777 (dwarf2_fetch_die_loc_sect_off): Update.
8778
310b3441
TV
87792019-06-17 Tom de Vries <tdevries@suse.de>
8780
8781 PR gdb/24617
8782 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8783 accessing parent[parent_len - 1].
8784
ba9777be
PP
87852019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8786
8787 PR gdb/24364
8788 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8789 call dtrace_process_dof with NULL dof.
8790
2b9f6e89
TV
87912019-06-16 Tom de Vries <tdevries@suse.de>
8792
8793 PR gdb/24445
8794 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8795
431b3ead
TT
87962019-06-16 Tom Tromey <tom@tromey.com>
8797
8798 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8799 (make_all_visible): Use address of member.
8800
d04b44a1
TT
88012019-06-16 Tom Tromey <tom@tromey.com>
8802
8803 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8804 (tui_free_window, free_content, free_content_elements): Remove
8805 unnecessary cast.
8806 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8807 cast.
8808 * tui/tui-regs.c (tui_show_register_group)
8809 (tui_display_registers_from, tui_display_reg_element_at_line):
8810 Remove unnecessary cast.
8811
bf5142e7
AB
88122019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8813
8814 * linux-nat.c (normal_mask): Delete.
8815 (_initialize_linux_nat): Don't initialise normal_mask.
8816
c4973306
SM
88172019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8818
8819 PR gdb/24445
8820 * dwarf-index-write.h (write_psymtabs_to_index): Add
8821 dwz_basename parameter.
8822 * dwarf-index-write.c (write_gdbindex): Move file writing to
8823 write_gdbindex_1. Change return type void.
8824 (assert_file_size): Move up, remove filename parameter.
8825 (write_gdbindex_1): New function.
8826 (write_debug_names): Change return type to void, call
8827 assert_file_size.
8828 (struct index_wip_file): New struct.
8829 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8830 file logic to index_wip_file. Write index for dwz file if
8831 needed.
8832 (save_gdb_index_command): Pass basename of dwz file, if present.
8833 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8834 build-id of dwz file, if present.
8835 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8836 (dwarf2_get_dwz_file): Likewise.
8837 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8838 (dwarf2_get_dwz_file): Likewise.
8839
395f9c91
TT
88402019-06-16 Tom Tromey <tom@tromey.com>
8841
8842 * coffread.c (process_coff_symbol): Use xstrdup.
8843 * value.c (create_internalvar): Use xstrdup.
8844
cafb3438
TT
88452019-06-16 Tom Tromey <tom@tromey.com>
8846
8847 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8848 * breakpoint.c (stopin_command, stopat_command)
8849 (until_break_command, decode_location_default): Remove unnecessary
8850 cast.
8851 * utils.c (subset_compare): Remove unnecessary cast.
8852 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8853 cast.
8854 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8855 cast.
8856 * infcmd.c (path_command): Remove unnecessary cast.
8857 * coffread.c (decode_type): Remove unnecessary cast.
8858 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8859 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8860 * tui/tui-stack.c (tui_show_locator_content)
8861 (tui_show_frame_info): Remove unnecessary cast.
8862 * tui/tui-win.c (tui_scroll_forward_command)
8863 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8864 (parse_scrolling_args): Remove unnecessary cast.
8865 * tui/tui-data.c (init_win_info, tui_del_window)
8866 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8867 (free_content_elements): Remove unnecessary cast.
8868 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8869 unnecessary cast.
8870 * tui/tui-source.c (tui_set_source_content)
8871 (tui_vertical_source_scroll): Remove unnecessary cast.
8872 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8873 cast.
8874 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8875 * tui/tui-regs.c (tui_display_registers_from)
8876 (tui_display_register): Remove unnecessary cast.
8877 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8878 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8879 (make_visible): Remove unnecessary cast.
8880 * tui/tui-winsource.c (tui_erase_source_content)
8881 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8882 unnecessary cast.
8883 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8884 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8885 * stabsread.c (read_type, read_array_type, read_range_type):
8886 Remove unnecessary cast.
8887 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8888 (parse_symbol, parse_type, upgrade_type, parse_external)
8889 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8890 unnecessary cast.
8891 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8892
730ead81
TT
88932019-06-16 Tom Tromey <tom@tromey.com>
8894
8895 * tui/tui-data.c (tui_alloc_generic_win_info)
8896 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8897 checks.
8898
584a927c
AB
88992019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8900 Andrew Burgess <andrew.burgess@embecosm.com>
8901
8902 * f-typeprint.c (f_print_type): Don't return early for not
8903 associated or not allocated types.
8904 (f_type_print_varspec_suffix): Add print_rank parameter and print
8905 ranks of array types in case they dangling.
8906 (f_type_print_base): Add print_rank parameter.
8907
30056ea0
AB
89082019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8909
8910 * NEWS: Mention new MI commands.
8911 * break-catch-throw.c (enum exception_event_kind): Move to
8912 breakpoint.h.
8913 (print_mention_exception_catchpoint): Output text as a single
8914 message.
8915 (catch_exception_command_1): Rename to...
8916 (catch_exception_event): ...this, make non-static, update header
8917 command, and change some parameter types.
8918 (catch_catch_command): Update for changes to
8919 catch_exception_command_1.
8920 (catch_throw_command): Likewise.
8921 (catch_rethrow_command): Likewise.
8922 * breakpoint.c (enum exception_event_kind): Delete.
8923 * breakpoint.h (enum exception_event_kind): Moved here from
8924 break-catch-throw.c.
8925 (catch_exception_event): Declare.
8926 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8927 (mi_cmd_catch_throw): New function.
8928 (mi_cmd_catch_rethrow): New function.
8929 (mi_cmd_catch_catch): New function.
8930 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8931 'catch-catch' entries.
8932 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8933 (mi_cmd_catch_rethrow): Declare.
8934 (mi_cmd_catch_catch): Declare.
8935
ec8e2b6d
AB
89362019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8937
8938 * annotate.c (annotate_source_line): Change return type to void,
8939 update implementation to match.
8940 * annotate.h (annotate_source_line): Change return type to void,
8941 update header comment.
8942 * stack.c (print_frame_info): Don't change what frame information
8943 is printed based on whether annotations are on or not.
8944
0d3abd8c
AB
89452019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8946
8947 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8948 (annotate_source): Make static.
8949 (annotate_source_line): Moved from source.c and renamed from
8950 identify_source_line. Update the return type.
8951 * annotate.h (annotate_source): Delete declaration.
8952 (annotate_source_line): Declaration moved from source.h, and
8953 renamed from identify_source_line. Return type updated.
8954 * source.c (identify_source_line): Moved to annotate.c and renamed
8955 to annotate_source_line.
8956 (info_line_command): Remove check of annotation_level.
8957 * source.h (identify_source_line): Move declaration to annotate.h
8958 and rename to annotate_source_line.
8959 * stack.c: Add 'annotate.h' include.
8960 (print_frame_info): Remove check of annotation_level before
8961 calling annotate_source_line.
8962
00df30ae
AB
89632019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8964
8965 * source-cache.c (source_cache::get_plain_source_lines): Use
8966 open_source_file_with_line_charpos instead of just
8967 open_source_file, remove call to find_source_lines.
8968 (source_cache::get_source_lines): Likewise.
8969 * source.c (find_source_lines): Make static.
8970 (get_filename_and_charpos): Renamed into...
8971 (open_source_file_with_line_charpos): ..this along with changes to
8972 return a scoped_fd, and some other minor clean ups.
8973 (identify_source_line): Use open_source_file_with_line_charpos.
8974 (search_command_helper): Use open_source_file_with_line_charpos
8975 instead of just open_source_file, remove call to
8976 find_source_lines.
8977 * source.h (open_source_file_with_line_charpos): Declare new
8978 function.
8979 (find_source_lines): Delete declaration.
8980
afda45a2
AB
89812019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8982
8983 * source.c (get_filename_and_charpos): Remove fullname
8984 parameter.
8985 (identify_source_line): Update call to get_filename_and_charpos.
8986
0735b091
TT
89872019-06-14 Tom Tromey <tromey@adacore.com>
8988
8989 PR gdb/24502:
8990 * ui-style.h (skip_ansi_escape): Update comment.
8991 * ui-file.h (class no_terminal_escape_file): New class.
8992 * ui-file.c (no_terminal_escape_file::write)
8993 (no_terminal_escape_file::puts): New methods.
8994 * cli/cli-logging.c (handle_redirections): Use
8995 no_terminal_escape_file.
8996
52ce35e2
TT
89972019-06-14 Tom Tromey <tromey@adacore.com>
8998
8999 * NEWS: Move convenience variable news above Python news.
9000
73cc7272
TT
90012019-06-14 Tom Tromey <tom@tromey.com>
9002
9003 * gnulib: Move directory to top-level.
9004 * configure.ac: Don't configure gnulib.
9005 * configure: Rebuild.
9006 * common/common-defs.h: Use new path to gnulib.
9007 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9008 (GNULIB_H): Remove.
9009 (INCGNU): Look in new gnulib location.
9010 (HFILES_NO_SRCDIR): Remove gnulib files.
9011 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9012 (generated_files): Remove GNULIB_H.
9013 ($(LIBGNU), all-lib): Remove targets.
9014 (distclean): Don't mention GNULIB_BUILDDIR.
9015 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9016
f5686554
TT
90172019-06-14 Tom Tromey <tromey@adacore.com>
9018
9019 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9020 Warn if symbol file does not provide any symbols.
9021
a0c1ffed
TT
90222019-06-14 Tom Tromey <tromey@adacore.com>
9023
9024 * source.c (find_and_open_source): Respect basenames_may_differ.
9025
7c39e397
AB
90262019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9027
9028 * annotate.c (annotate_breakpoints_invalid): Make use of
9029 scoped_restore_terminal_state.
9030 (annotate_frames_invalid): Likewise.
9031
f411722c
TT
90322019-06-14 Tom Tromey <tromey@adacore.com>
9033
9034 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9035 allow assignment to an internalvar.
9036
4268ec18
TT
90372019-06-14 Tom Tromey <tromey@adacore.com>
9038
9039 * ada-lex.l: Allow "_" in attribute names.
9040
abdb711e
TT
90412019-06-14 Tom Tromey <tromey@adacore.com>
9042
9043 PR gdb/24653:
9044 * regcache.c (registers_changed): Don't call alloca.
9045 * top.c (execute_command): Don't call alloca.
9046
4c048731
PA
90472019-06-13 Pedro Alves <palves@redhat.com>
9048
9049 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9050 'expression'. When parsing an expression, error out if there's
9051 junk after "unlimited".
9052 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9053 (do_set_command): Adjust calls to is_unlimited_literal.
9054
66eb1ed3
PA
90552019-06-13 Pedro Alves <palves@redhat.com>
9056
9057 * compile/compile.c (make_compile_options_def_group): Add braces
9058 around array_view initializer.
9059 * thread.c (make_thread_apply_all_options_def_group)
9060 (make_thread_apply_all_options_def_group): Likewise.
9061
3345721a
PA
90622019-06-13 Pedro Alves <palves@redhat.com>
9063
9064 * NEWS (New commands): Mention "maint test-options
9065 require-delimiter", "maint test-options unknown-is-error", "maint
9066 test-options unknown-is-operand" and "maint show
9067 test-options-completion-result".
9068 (New command options, command completion): New section.
9069 (Completion improvements): New section.
9070 Mention that you can abbreviate "unlimited".
9071
6206060d
PA
90722019-06-13 Pedro Alves <palves@redhat.com>
9073
9074 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9075 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9076 * unittests/cli-utils-selftests.c (test_parse_flags)
9077 (test_parse_flags_qcs): Delete.
9078 (test_cli_utils): Don't call deleted functions.
9079
6665660a
PA
90802019-06-13 Pedro Alves <palves@redhat.com>
9081
9082 * thread.c: Include "cli/cli-option.h".
9083 (tp_array_compar_ascending): Global.
9084 (tp_array_compar): Delete function.
9085 (tp_array_compar_ascending, tp_array_compar_descending): New
9086 functions.
9087 (ascending_option_def, qcs_flag_option_def)
9088 (thr_qcs_flags_option_defs)
9089 (make_thread_apply_all_options_def_group)
9090 (make_thread_apply_options_def_group): New.
9091 (thread_apply_all_command): Use gdb::option::process_options.
9092 (thread_apply_command_completer)
9093 (thread_apply_all_command_completer): New.
9094 (thread_apply_command): Use gdb::option::process_options.
9095 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9096 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9097 to generate help text of "thread apply". Adjust "taas"'s help.
9098 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9099 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9100
f7e13587
PA
91012019-06-13 Pedro Alves <palves@redhat.com>
9102
9103 * thread.c (thread_apply_command): Check for invalid TID with
9104 isdigit instead of !isalpha.
9105
5d707134
PA
91062019-06-13 Pedro Alves <palves@redhat.com>
9107
9108 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9109 (validate_flags_qcs): New.
9110 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9111 (validate_flags_qcs): Declare.
9112 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9113 (make_frame_apply_options_def_group): New.
9114 (frame_apply_command_count): Process options with
9115 gdb::option::process_options.
9116 (frame_apply_completer): New.
9117 (frame_apply_level_completer, frame_apply_all_completer)
9118 (frame_apply_completer): New.
9119 (_initialize_stack): Update help of "frame apply", "frame apply
9120 level", "frame apply all" and "faas" to mention supported options
9121 and install command completers.
9122 * stack.h (frame_apply_all_completer): Declare.
9123 * thread.c: Include "stack.h".
9124 (tfaas_command): Add "--".
9125 (_initialize_thread): Update help "tfaas" to mention supported
9126 options and install command completer.
9127
272d4594
PA
91282019-06-13 Pedro Alves <palves@redhat.com>
9129
9130 * completer.c (complete_nested_command_line): New.
9131 (gdb_completion_word_break_characters_throw): Add assertion.
9132 * completer.h (complete_nested_command_line): Declare.
9133
90a1ef87
PA
91342019-06-13 Pedro Alves <palves@redhat.com>
9135
9136 * stack.c (parse_backtrace_qualifiers): New.
9137 (backtrace_command): Use it.
9138 (backtrace_command_completer): Complete on qualifiers.
9139
d4c16835
PA
91402019-06-13 Pedro Alves <palves@redhat.com>
9141
9142 * frame.c: Include "cli/cli-option.h.
9143 (user_set_backtrace_options): New.
9144 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9145 Delete.
9146 (get_prev_frame): Adjust.
9147 (boolean_option_def, uinteger_option_def)
9148 (set_backtrace_option_defs): New.
9149 (_initialize_frame): Adjust and use
9150 gdb::option::add_setshow_cmds_for_options to install "set
9151 backtrace past-main" and "set backtrace past-entry".
9152 * frame.h: Include "cli/cli-option.h".
9153 (struct frame_print_options): Forward declare.
9154 (print_frame_arguments_all, print_frame_arguments_scalars)
9155 (print_frame_arguments_none): Declare.
9156 (print_entry_values): Delete declaration.
9157 (struct frame_print_options, user_frame_print_options): New.
9158 (struct set_backtrace_options): New.
9159 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9160 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9161 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9162 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9163 (list_args_or_locals): Add frame_print_options parameter.
9164 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9165 * python/py-framefilter.c (enumerate_args): Pass down
9166 USER_FRAME_PRINT_OPTIONS.
9167 * stack.c: Include "cli/cli-option.h".
9168 (print_frame_arguments_all, print_frame_arguments_scalars)
9169 (print_frame_arguments_none): Declare.
9170 (print_raw_frame_arguments, print_entry_values): Delete.
9171 (user_frame_print_options): New.
9172 (boolean_option_def, enum_option_def, frame_print_option_defs):
9173 New.
9174 (struct backtrace_cmd_options): New.
9175 (bt_flag_option_def): New.
9176 (backtrace_command_option_defs): New.
9177 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9178 (print_frame_arg, read_frame_arg, print_frame_args)
9179 (print_frame_info, print_frame): Add frame_print_options parameter
9180 and use it.
9181 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9182 (backtrace_command_1): Add frame_print_options and
9183 backtrace_cmd_options parameters and use them.
9184 (make_backtrace_options_def_group): New.
9185 (backtrace_command): Process command options with
9186 gdb::option::process_options.
9187 (backtrace_command_completer): New.
9188 (_initialize_stack): Extend "backtrace"'s help to mention
9189 supported options. Install completer for "backtrace".
9190 Install some settings commands with add_setshow_cmds_for_options.
9191
2daf894e
PA
91922019-06-13 Pedro Alves <palves@redhat.com>
9193
9194 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9195 and that "set/show print raw frame-arguments" are now deprecated.
9196
9197 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9198 command.
9199 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9200 * stack.c (_initialize_stack): Install "set/show print
9201 raw-frame-arguments", and deprecate "set/show print raw
9202 frame-arguments".
9203 * valprint.c (_initialize_valprint): Deprecate "set/show print
9204 raw".
9205
e6ed716c
PA
92062019-06-13 Pedro Alves <palves@redhat.com>
9207
9208 * compile/compile.c (struct compile_options): New.
9209 (compile_flag_option_def, compile_command_option_defs)
9210 (make_compile_options_def_group): New.
9211 (compile_file_command): Handle options with
9212 gdb::option::process_options.
9213 (compile_file_command_completer): New function.
9214 (compile_code_command): Handle options with
9215 gdb::option::process_options.
9216 (compile_code_command_completer): New function.
9217 (_initialize_compiler): Install completers for "compile code" and
9218 "compile file". Mention available options in "compile code" and
9219 "compile code"'s help.
9220 * completer.c (advance_to_completion_word): New, factored out from
9221 ...
9222 (advance_to_expression_complete_word_point): ... this.
9223 (advance_to_filename_complete_word_point): New.
9224 * completer.h (advance_to_filename_complete_word_point): New
9225 declaration.
9226
7d8062de
PA
92272019-06-13 Pedro Alves <palves@redhat.com>
9228
9229 * compile/compile.c: Include "cli/cli-option.h".
9230 (compile_print_value): Scope data pointer is now a
9231 value_print_options pointer; adjust.
9232 (compile_print_command): Process options. Scope data pointer is
9233 now a value_print_options pointer; adjust.
9234 (_initialize_compile): Update "compile print"'s help to include
9235 supported options. Install a completer for "compile print".
9236 * cp-valprint.c (show_vtblprint, show_objectprint)
9237 (show_static_field_print): Delete.
9238 (_initialize_cp_valprint): Don't install "set print
9239 static-members", "set print vtbl", "set print object" here.
9240 * printcmd.c: Include "cli/cli-option.h" and
9241 "common/gdb_optional.h".
9242 (print_command_parse_format): Rework to fill in a
9243 value_print_options instead of a format_data.
9244 (print_value): Change parameter type from format_data pointer to
9245 value_print_options reference. Adjust.
9246 (print_command_1): Process options. Adjust to pass down a
9247 value_print_options.
9248 (print_command_completer): New.
9249 (_initialize_printcmd): Install print_command_completer as
9250 handle_brkchars completer for the "print" command. Update
9251 "print"'s help to include supported options.
9252 * valprint.c: Include "cli/cli-option.h".
9253 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9254 here from cp-valprint.c.
9255 (boolean_option_def, uinteger_option_def)
9256 (value_print_option_defs, make_value_print_options_def_group):
9257 New. Use gdb::option::add_setshow_cmds_for_options to install
9258 "set print elements", "set print null-stop", "set print repeats",
9259 "set print pretty", "set print union", "set print array", "set
9260 print address", "set print symbol", "set print array-indexes".
9261 * valprint.h: Include <string> and "cli/cli-option.h".
9262 (make_value_print_options_def_group): Declare.
9263 (print_value): Change parameter type from format_data pointer to
9264 value_print_options reference.
9265 (print_command_completer): Declare.
9266
9d0faba9
PA
92672019-06-13 Pedro Alves <palves@redhat.com>
9268
9269 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9270 (COMMON_SFILES): Add maint-test-settings.c.
9271 * cli/cli-decode.c (boolean_enums): New global, factored out from
9272 ...
9273 (add_setshow_boolean_cmd): ... here.
9274 * cli/cli-decode.h (boolean_enums): Declare.
9275 * cli/cli-option.c: New file.
9276 * cli/cli-option.h: New file.
9277 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9278 factored out from ...
9279 (parse_cli_boolean_value(const char *)): ... this.
9280 (is_unlimited_literal): Change parameter type to pointer to
9281 pointer. Adjust and advance ARG pointer.
9282 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9283 (parse_cli_var_enum): New, factored out from ...
9284 (do_set_command): ... this. Adjust.
9285 * cli/cli-setshow.h (parse_cli_boolean_value)
9286 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9287 (parse_cli_var_enum): Declare.
9288 * cli/cli-utils.c: Include "cli/cli-option.h".
9289 (get_ulongest): New.
9290 * cli/cli-utils.h (get_ulongest): Declare.
9291 (check_for_argument): New overloads.
9292 * maint-test-options.c: New file.
9293
2c722807
PA
92942019-06-13 Pedro Alves <palves@redhat.com>
9295
9296 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9297 parse a range if "-" is at the end of the string.
9298
dee7b4c8
PA
92992019-06-13 Pedro Alves <palves@redhat.com>
9300
9301 * cli/cli-setshow.c (parse_auto_binary_operation)
9302 (parse_cli_boolean_value): Don't allow "o".
9303
dca0f6c0
PA
93042019-06-13 Pedro Alves <palves@redhat.com>
9305
9306 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9307 * NEWS: Mention maint test-settings KIND.
9308 * maint-test-settings.c: New file.
9309
597bf39d
PA
93102019-06-13 Pedro Alves <palves@redhat.com>
9311
9312 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9313 completer.
9314 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9315 "set" completers.
9316
48c410fb
PA
93172019-06-13 Pedro Alves <palves@redhat.com>
9318
9319 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9320 after item.
9321
93bcb043
PA
93222019-06-13 Pedro Alves <palves@redhat.com>
9323
9324 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9325
cbba3ecd
PA
93262019-06-13 Pedro Alves <palves@redhat.com>
9327
9328 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9329 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9330 call.
9331 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9332 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9333 calls.
9334 (check_for_argument): Skip spaces after argument.
9335
b9a3f842
PA
93362019-06-13 Pedro Alves <palves@redhat.com>
9337
9338 * thread.c (thread_apply_command): Adjust TID parsing.
9339 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9340 detected before end of string.
9341 (tid_is_in_list): Error out if LIST is invalid.
9342
3844e605
PA
93432019-06-13 Pedro Alves <palves@redhat.com>
9344
9345 * completer.c (complete_line_internal_1): Rewind completion word
9346 point.
9347 (completion_tracker::advance_custom_word_point_by): Change
9348 parameter type to int.
9349 * completer.h (completion_tracker::advance_custom_word_point_by):
9350 Likewise.
9351
00b56dbe
PA
93522019-06-13 Pedro Alves <palves@redhat.com>
9353
9354 * completer.c (advance_to_completion_word): Handle delimiters.
9355
d106773e
PA
93562019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9357
9358 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9359
08f10e02
TT
93602019-06-11 Tom Tromey <tom@tromey.com>
9361
9362 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9363 (xmalloc_failed): Move to alloc.c.
9364 * alloc.c: New file.
9365 * Makefile.in (COMMON_SFILES): Add alloc.c.
9366
1c7fe951
TT
93672019-06-11 Tom Tromey <tom@tromey.com>
9368
9369 * nat/linux-waitpid.c: Don't include server.h.
9370 (linux_debug): Remove.
9371 (my_waitpid): Update.
9372
89549d7f
TT
93732019-06-11 Tom Tromey <tromey@adacore.com>
9374
9375 * infcall.c (_initialize_infcall): Remove trailing newline from
9376 help.
9377 * user-regs.c (_initialize_user_regs): Remove trailing newline
9378 from help.
9379 * typeprint.c (_initialize_typeprint): Remove trailing newline
9380 from help.
9381 * reverse.c (_initialize_reverse): Remove trailing newlines from
9382 help.
9383 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9384 from help.
9385 * language.c (add_set_language_command): Remove trailing newline
9386 from help.
9387 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9388 help.
9389 * disasm.c (_initialize_disasm): Remove trailing newline from
9390 help.
9391 * top.c (init_main): Remove trailing newline from help.
9392 * interps.c (_initialize_interpreter): Remove trailing newline
9393 from help.
9394 * btrace.c (_initialize_btrace): Remove trailing newlines from
9395 help.
9396 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9397 from help.
9398 * python/python.c (_initialize_python): Remove trailing newline
9399 from help.
9400 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9401 help.
9402 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9403 from help. Reformat some text.
9404 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9405 from help.
9406 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9407 newline from help.
9408
86108c13
TT
94092019-06-11 Tom Tromey <tromey@adacore.com>
9410
9411 * darwin-nat.c (darwin_decode_exception_message)
9412 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9413
a7067863
AB
94142019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9415
9416 * valops.c (value_slice): Check for not allocated or not
9417 associated values.
9418
9ab08412
TV
94192019-06-10 Tom de Vries <tdevries@suse.de>
9420
9421 PR gdb/24618
9422 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9423 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9424 invalid.
9425
f19e22e9
TV
94262019-06-10 Tom de Vries <tdevries@suse.de>
9427
9428 PR gdb/24611
9429 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9430 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9431
e99f9db0
TV
94322019-06-10 Tom de Vries <tdevries@suse.de>
9433
9434 PR symtab/24545
9435 * symtab.c (struct demangled_name_entry): Add language field.
9436 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9437 static minimal symbol". Set and use language field.
9438
9bf7038b
TT
94392019-06-10 Tom Tromey <tromey@adacore.com>
9440
9441 * ada-lang.c (_initialize_ada_language): Update help text.
9442
422186a9
TT
94432019-06-10 Tom Tromey <tromey@adacore.com>
9444
9445 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9446 with a newline.
9447 * guile/guile.c (handle_boot_error): Don't end warning with a
9448 newline.
9449 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9450 warning with a newline.
9451 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9452 newline.
9453 (s12z_frame_cache): Likewise.
9454 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9455 a newline.
9456 * solib-svr4.c (disable_probes_interface): Don't end warning with
9457 a newline.
9458 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9459 newline.
9460 * python/python.c (do_finish_initialization): Don't end warning
9461 with a newline.
9462
25ce02ee
TT
94632019-06-10 Tom Tromey <tom@tromey.com>
9464
9465 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9466 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9467 gdbpy_enter.
9468
caa429d8
TT
94692019-06-10 Tom Tromey <tromey@adacore.com>
9470
9471 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9472 data.
9473 (elf_new_init): Don't call stabsread_new_init.
9474 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9475 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9476 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9477
81873cc8
TV
94782019-06-10 Tom de Vries <tdevries@suse.de>
9479
9480 PR symtab/16264
9481 PR symtab/24517
9482 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9483
4fa0265e
РИ
94842019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9485
9486 * source.c (find_and_open_source): Also rewrite relative file
9487 names.
9488
1a3da2cd
AB
94892019-04-26 Amos Bird <amosbird@gmail.com>
9490
9491 * annotate.c (annotate_thread_exited): Add "thread-exited"
9492 annotation.
9493
3847a7bf
TT
94942019-06-06 Tom Tromey <tromey@adacore.com>
9495
9496 * maint.h (class scoped_command_stats): Use
9497 DISABLE_COPY_AND_ASSIGN.
9498 <print_time>: New method.
9499 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9500 print_time.
9501 (scoped_command_stats::print_time): New method.
9502
312617a3
AB
95032019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9504
9505 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9506 instructions of lengths 6 or 8 bytes.
9507
b02f78f9
PA
95082019-06-04 Pedro Alves <palves@redhat.com>
9509
9510 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9511
9512 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9513 * breakpoint.c (condition_completer): Likewise.
9514 * cli/cli-dump.c (scan_expression): Likewise.
9515 * common/filestuff.c (mkdir_recursive): Likewise.
9516 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9517 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9518 (gdb_abspath): Likewise.
9519 * compile/compile-cplus-types.c
9520 (compile_cplus_instance::decl_name): Likewise.
9521 * completer.c (complete_explicit_location):
9522 (signal_completer, reg_or_group_completer_1): Likewise.
9523 * cp-support.c (cp_remove_params_if_any): Likewise.
9524 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9525 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9526 * infcmd.c (strip_bg_char): Likewise.
9527 * linespec.c (copy_token_string): Likewise.
9528 * mi/mi-main.c (output_cores): Likewise.
9529 * psymtab.c (psymtab_search_name):
9530 * symfile.c (test_set_ext_lang_command): Likewise.
9531 * target.c (target_fileio_read_stralloc): Likewise.
9532 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9533 * value.c (complete_internalvar): Likewise.
9534
e1f2e1a2
CB
95352019-06-04 Christian Biesinger <cbiesinger@google.com>
9536
9537 Add objfile property to gdb.Type.
d3238f7d
PA
9538 * NEWS: Mention Python API addition.
9539 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9540
e664d728
PW
95412019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9542
9543 * NEWS: Mention the new set|show style [title|highlight].
9544 Mention changes to "show style", "help" and "apropos".
9545
66d8c862
PW
95462019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9547
9548 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9549 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9550 instead of print_help_for_command.
9551 (print_doc_of_command): New function.
9552 (help_list): Add 'apropos -v word' suggestion.
9553 (print_help_for_command): Style the command name using title style.
9554 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9555 (_initialize_cli_cmds): Describe -v in apropos_command help.
9556
9303eb2f
PW
95572019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9558
9559 * cli/cli-style.h (cli_style_option): Add name in constructor,
9560 add m_name class member, add constructor with intensity,
9561 add name class function.
9562 (cli_style_option::add_setshow_commands): Remove name argument.
9563 (highlight_style, title_style): New styles.
9564 * cli/cli-style.c (do_show): New function that shows a style
9565 characteristic styling the style name with itself.
9566 (set_style_name): New function.
9567 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9568 Update all callers according to the changes in cli/cli-style.h.
9569 * utils.h (fputs_highlighted): New function.
9570 * utils.c (fputs_highlighted): Likewise.
9571
e2c52041
PW
95722019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9573
9574 * NEWS: Mention new pipe command and new convenience variables.
9575
947d3946
PW
95762019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9577
9578 * cli/cli-cmds.c (pipe_command): New function.
9579 (_initialize_cli_cmds): Call add_com for pipe_command.
9580 Define | as an alias for pipe.
9581 (exit_status_set_internal_vars): New function.
9582 (shell_escape): Call exit_status_set_internal_vars.
9583 cli/cli-decode.c (find_command_name_length): Recognize | as
9584 a single character command.
9585
b8fd0918
PW
95862019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9587
9588 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9589 top.c (execute_command_to_ui_file): New function, mostly a copy
9590 of execute_command_to_string.
9591 (execute_command_to_string): Implement by calling
9592 execute_command_to_ui_file.
9593
68bb5386
PW
95942019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9595
9596 * top.h (saved_command_line): Remove declaration.
9597 * top.c (previous_saved_command_line, previous_repeat_arguments):
9598 New variables.
9599 (saved_command_line): Make static, define together with other
9600 'repeat variables'.
9601 (dont_repeat): Clear repeat_arguments.
9602 (repeat_previous, get_saved_command_line, save_command_line):
9603 New functions.
9604 (gdb_init): Initialize saved_command_line
9605 and previous_saved_command_line.
9606 * main.c (captured_main_1): Remove saved_command_line initialization.
9607 * event-top.c (handle_line_of_input): Update to use
9608 the new 'repeat' related functions instead of direct access to
9609 saved_command_line.
9610 * command.h (repeat_previous, get_saved_command_line,
9611 save_command_line): New declarations.
9612 (dont_repeat): Add comment.
9613
bfcdb852
TT
96142019-05-30 Tom Tromey <tromey@adacore.com>
9615
9616 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9617 Fix comment.
9618 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9619
0ef209f2
JV
96202019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9621
9622 PR cli/24587
9623 * completer.c (complete): Initialize variable word.
9624
955b06fa
SDJ
96252019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9626
9627 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9628 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9629 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9630 'body' is NULL to the outter 'if', protecting the '!is_define'
9631 situation as well.
9632
fa9c3fa0
TT
96332019-05-29 Tom Tromey <tromey@adacore.com>
9634
9635 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9636 (dwarf_unknown): New function.
9637 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9638 (dwarf_type_encoding_name): Use dwarf_unknown.
9639
4330d61d
TT
96402019-05-29 Tom Tromey <tromey@adacore.com>
9641
9642 PR c++/20020:
9643 * cp-valprint.c (cp_print_value_fields): Call
9644 cp_print_static_field inside "try".
9645
33a6bc35
TT
96462019-05-29 Tom Tromey <tromey@adacore.com>
9647
9648 * inflow.c (struct terminal_info): Add default operator=.
9649 * configure: Rebuild.
9650 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9651 -Wdeprecated-copy-dtor, -Wredundant-move.
9652
000439d5
TT
96532019-05-29 Tom Tromey <tromey@adacore.com>
9654
9655 * NEWS: Add entry.
9656 * infcmd.c (print_return_value_1): Handle finish_print
9657 option.
9658 (show_print_finish): New function.
9659 (_initialize_infcmd): Add "set/show print finish" commands.
9660 * valprint.c (user_print_options): Initialize new member.
9661 * valprint.h (struct value_print_options) <finish_print>: New
9662 member.
9663
c0e70c62
TT
96642019-05-28 Tom Tromey <tromey@adacore.com>
9665
9666 * ada-lang.c (ada_remove_Xbn_suffix)
9667 (find_old_style_renaming_symbol)
9668 (parse_old_style_renaming): Remove.
9669 (ada_find_renaming_symbol): Don't call
9670 find_old_style_renaming_symbol.
9671 (ada_is_renaming_symbol): Rename from
9672 ada_find_renaming_symbol. Remove "block" parameter. Return
9673 bool. Now static.
9674 (ada_read_var_value): Update and simplify.
9675 * ada-exp.y (write_var_or_type): Remove old code.
9676
766f8836
AH
96772019-05-28 Alan Hayward <alan.hayward@arm.com>
9678
68255adc 9679 PR gdb/25010
766f8836
AH
9680 * event-top.c: Remove include comment.
9681 * inflow.c (class scoped_ignore_sigttou): Move from here...
9682 * inflow.h (class scoped_ignore_sigttou): ...to here.
9683 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9684 * top.c: Remove include comment.
9685
eb41253a
TT
96862019-05-27 Tom Tromey <tom@tromey.com>
9687
9688 * NEWS: Fix typo.
9689
4ca51187
TT
96902019-05-22 Tom Tromey <tromey@adacore.com>
9691
9692 * target.c (target_follow_exec): Constify parameter.
9693 * target-delegates.c: Rebuild.
9694 * remote.c (remote_target::follow_exec): Constify parameter.
9695 * infrun.c (follow_exec): Constify parameter.
9696 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9697 (target_follow_exec): Likewise.
9698
8fca4da0
AH
96992019-05-22 Alan Hayward <alan.hayward@arm.com>
9700
9701 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9702 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9703
b7060614
AH
97042019-05-22 Alan Hayward <alan.hayward@arm.com>
9705
9706 * NEWS: Add debugredirect and testsuite sections.
9707
0a5954bd
SC
97082019-05-22 Simon Cook <simon.cook@embecosm.com>
9709
9710 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9711 target descriptions using exclusively floating point register name
9712 aliases.
9713
dc42e902
AB
97142019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9715
9716 PR gdb/18644:
9717 * f-lang.c (build_fortran_types): Handle the case where
9718 gdbarch_floatformat_for_type returns a nullptr.
9719
fb7806c7
TV
97202019-05-21 Tom de Vries <tdevries@suse.de>
9721
9722 PR cli/24587
9723 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9724
34d11c68
AB
97252019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9726
9727 PR gdb/18644:
9728 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9729 16-byte floats.
9730 * i386-tdep.c (i386_floatformat_for_type): Use
9731 floatformats_ia64_quad for the 16-byte floating point component
9732 within a fortran 32-byte complex number.
9733
122cf0f2
AB
97342019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9735
9736 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9737 delete default constructor.
9738 (find_partial_die): Update to return const struct.
9739 (partial_die_parent_scope): Move variable declaration into scope
9740 of its use and change its type to auto.
9741 (guess_partial_die_structure_name): Likewise.
9742 (partial_die_info::fixup): Likewise.
9743
33d0e35a
TT
97442019-05-17 Tom Tromey <tromey@adacore.com>
9745
9746 * source.c (find_and_open_source): Remove cast.
9747
a45575b0
TT
97482019-05-17 Tom Tromey <tromey@adacore.com>
9749
9750 * annotate.c (annotate_source): Make "filename" const.
9751 * annotate.h (annotate_source): Use const.
9752
81f47ac2
AH
97532019-05-17 Alan Hayward <alan.hayward@arm.com>
9754
9755 * disasm.c (set_disassembler_options): Send errors to stderr.
9756
ca1285d1
AH
97572019-05-17 Alan Hayward <alan.hayward@arm.com>
9758
9759 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9760 (cli_interp_base::set_logging): Check debug_redirect.
9761 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9762 * cli/cli-logging.c (debug_redirect): Add static variable.
9763 (pop_output_files): Add default param.
9764 (handle_redirections): Print debug setting.
9765 (show_logging_command): Likewise.
9766 (_initialize_cli_logging): Add debugredirect command.
9767 * interps.c (current_interp_set_logging): Add debug_redirect
9768 parameter.
9769 * interps.h (set_logging): Add debug_redirect parameter.
9770 (current_interp_set_logging): Likewise.
9771 * mi/mi-common.h: Likewise.
9772 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9773
97742019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
9775 Tom Tromey <tromey@adacore.com>
9776
9777 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9778 directly.
9779 * cli/cli-interp.h (make_logging_output): Remove declaration.
9780 * cli/cli-logging.c (make_logging_output): Remove function.
9781 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9782 directly.
9783 * ui-file.c (tee_file::tee_file): Remove bools.
9784 (tee_file::~tee_file): Remove deletes.
9785 * ui-file.h (tee_file): Remove bools.
9786
26648588
JV
97872019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9788
9789 * mi/mi-cmds.h (mi_cmd_complete): New function.
9790 * mi/mi-main.c (mi_cmd_complete): Likewise.
9791 * mi/mi-cmds.c: Define new MI command -complete.
9792 * NEWS: Mention new -complete command.
9793
6e035501
JV
97942019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9795
9796 * completer.h (complete): New function.
9797 * completer.c (complete): Likewise.
9798 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9799 function defined in completer.h.
9800
7d0e2ece
JV
98012019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9802
e79be6e5 9803 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9804
fb816e8b
TV
98052019-05-17 Tom de Vries <tdevries@suse.de>
9806
9807 PR gdb/24094
9808 * dwarf2read.c (struct cu_partial_die_info): New struct.
9809 (find_partial_die): Return cu_partial_die_info.
9810 (partial_die_parent_scope, guess_partial_die_structure_name)
9811 (partial_die_info::fixup): Handle new return type of find_partial_die.
9812
677052f2
SDJ
98132019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9814
a1726c38 9815 PR breakpoints/24541
677052f2
SDJ
9816 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9817 "std::string", simplifying the algorithm.
9818
f3da9116
SDJ
98192019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9820
9821 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9822 (stap_static_probe_ops::get_probes): Likewise.
9823
f1bb75ab
SDJ
98242019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9825
9826 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9827 '-')" and "else if".
9828 (stap_parse_single_operand): Join checks for
9829 "gdbarch_stap_parse_special_token_p" and
9830 "gdbarch_stap_parse_special_token" in the same "if" statement.
9831 Invert check when verifying for operation on register
9832 displacement.
9833
3ca58cde
SDJ
98342019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9835
9836 * stap-probe.c (stap_get_opcode): Update comment.
9837 (stap_get_expected_argument_type): Likewise.
9838 (handle_stap_probe): Likewise.
9839
af2d9bee
SDJ
98402019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9841
9842 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9843 return type to 'bool'. Adjust comment. Use 'bool' when
9844 appropriate.
9845 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9846 * stap-probe.c (stap_parse_argument_1): Likewise.
9847 (stap_is_operator): Likewise.
9848 (stap_is_generic_prefix): Likewise.
9849 (stap_is_register_prefix): Likewise.
9850 (stap_is_register_indirection_prefix): Likewise.
9851 (stap_is_integer_prefix): Likewise.
9852 (stap_generic_check_suffix): Likewise.
9853 (stap_check_integer_suffix): Likewise.
9854 (stap_check_register_suffix): Likewise.
9855 (stap_check_register_indirection_suffix): Likewise.
9856 (stap_parse_register_operand): Likewise.
9857 (stap_parse_single_operand): Likewise.
9858 (stap_parse_argument_1): Likewise.
9859 (stap_probe::get_argument_count): Likewise.
9860 (stap_is_operator): Likewise.
9861
61c9c421
TT
98622019-05-16 Tom Tromey <tromey@adacore.com>
9863
9864 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9865 keyword to foreach.
9866
9ddc1af1
SM
98672019-05-15 Simon Marchi <simon.marchi@efficios.com>
9868
9869 * linux-thread-db.c (try_thread_db_load_1): Change return type
9870 to bool.
9871 (try_thread_db_load): Likewise.
9872 (try_thread_db_load_from_pdir_1): Likewise.
9873 (try_thread_db_load_from_pdir): Likewise.
9874 (try_thread_db_load_from_sdir): Likewise.
9875 (try_thread_db_load_from_dir): Likewise.
9876 (thread_db_load_search): Likewise.
9877 (has_libpthread): Likewise.
9878 (thread_db_load): Likewise.
9879
7bede828
SDJ
98802019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9881
9882 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9883 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9884 NULL, and complain/return if that's the case.
9885
c5358db4
JD
98862019-05-15 John Darrington <john@darrington.wattle.id.au>
9887
9888 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9889 (advance, posn, abstract_read_memory): New functions.
9890 [struct mem_read_abstraction]: New struct.
9891 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9892
c408a94f
TT
98932019-05-14 Tom Tromey <tromey@adacore.com>
9894
9895 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9896 value is not lval_memory.
9897
e7bd7fba
TT
98982019-05-14 Tom Tromey <tromey@adacore.com>
9899
9900 * solib.c (info_sharedlibrary_command): Style the file name.
9901
a6d0f249
AH
99022019-05-14 Alan Hayward <alan.hayward@arm.com>
9903
9904 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9905 (aarch64_vnv_type): Likewise.
9906 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9907 * common/tdesc.c: Likewise.
9908 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9909 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9910 * features/aarch64-fpu.xml: Add ieee half view.
9911 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9912 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9913 * gdbtypes.h (struct builtin_type): Likewise.
9914 (struct objfile_type): Likewise.
9915
66b8bb74
SM
99162019-05-12 Paul Naert <paul.naert@polymtl.ca>
9917
9918 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9919 typo.
9920 * location.h (string_to_event_location): Likewise.
9921
21c219fd
JB
99222019-05-11 Joel Brobecker <brobecker@adacore.com>
9923
9924 GDB 8.3 released.
9925
13674803
SM
99262019-05-10 Simon Marchi <simon.marchi@efficios.com>
9927
9928 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9929 New variable declaration.
9930 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9931 New variable.
9932 (print_one_breakpoint): Use ui_out::test_flags and new global
9933 variable to compute use_fixed_output.
9934 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9935 Remove.
9936 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9937 (mi_multi_location_breakpoint_output_fixed): Remove.
9938 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9939 new variable.
9940 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9941 fix_multi_location_breakpoint_output flag if version >= 3.
9942 * ui-out.h (enum ui_out_flag)
9943 <fix_multi_location_breakpoint_output>: New enumerator.
9944
a9eac7f9
SM
99452019-05-10 Simon Marchi <simon.marchi@efficios.com>
9946
9947 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9948
71bed2db
TT
99492019-05-10 Tom Tromey <tromey@adacore.com>
9950
9951 * ada-lang.c (catch_ada_completer): New function.
9952 (_initialize_ada_language): Use it.
9953
24c54127
TT
99542019-05-10 Tom Tromey <tromey@adacore.com>
9955
9956 * thread.c (print_thread_info): Make "requested_threads" const.
9957 * gdbthread.h (print_thread_info): Make "requested_threads"
9958 const.
9959 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9960 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9961
7a102139
TT
99622019-05-08 Tom Tromey <tom@tromey.com>
9963
9964 * gdbtypes.c (objfile_type_data): Change type.
9965 (objfile_type, _initialize_gdbtypes): Update.
9966
924d79e2
TT
99672019-05-08 Tom Tromey <tom@tromey.com>
9968
9969 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9970 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9971 (_initialize_dwarf2_frame): Update.
9972
4c58e337
TT
99732019-05-08 Tom Tromey <tom@tromey.com>
9974
9975 * objc-lang.c (objc_objfile_data): Change type.
9976 (find_methods): Update.
9977 (_initialize_objc_lang): Remove.
9978
d772d2ab
TT
99792019-05-08 Tom Tromey <tom@tromey.com>
9980
9981 * stabsread.c (rs6000_builtin_type_data): Change type.
9982 (rs6000_builtin_type, _initialize_stabsread): Update.
9983
d11d83f4
TT
99842019-05-08 Tom Tromey <tom@tromey.com>
9985
9986 * mips-tdep.c (mips_pdr_data): Remove.
9987 (_initialize_mips_tdep): Update.
9988
9a73f0ad
TT
99892019-05-08 Tom Tromey <tom@tromey.com>
9990
9991 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9992 (hppa_init_objfile_priv_data, read_unwind_info)
9993 (find_unwind_entry, _initialize_hppa_tdep): Update.
9994
8127a2fa
TT
99952019-05-08 Tom Tromey <tom@tromey.com>
9996
9997 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9998 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9999 on obstack.
10000 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10001
91d3055d
TT
100022019-05-08 Tom Tromey <tom@tromey.com>
10003
10004 * mdebugread.c (basic_type_data): Change type.
10005 (basic_type, _initialize_mdebugread): Update.
10006
31930bd3
TT
100072019-05-08 Tom Tromey <tom@tromey.com>
10008
10009 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10010
bdb3ed9e
TT
100112019-05-08 Tom Tromey <tom@tromey.com>
10012
10013 * nto-tdep.c (nto_inferior_data_reg): Change type.
10014 (nto_inferior_data): Update.
10015 (nto_inferior_data_cleanup, nto_new_inferior_data)
10016 (_initialize_nto_tdep): Remove.
10017 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10018
f37b313d
TT
100192019-05-08 Tom Tromey <tom@tromey.com>
10020
10021 * ada-lang.c (struct ada_inferior_data): Add initializers.
10022 (ada_inferior_data): Change type.
10023 (ada_inferior_data_cleanup): Remove.
10024 (get_ada_inferior_data, ada_inferior_exit)
10025 (struct ada_pspace_data): Add initializers, destructor.
10026 (ada_pspace_data_handle): Change type.
10027 (get_ada_pspace_data): Update.
10028 (ada_pspace_data_cleanup): Remove.
10029
24699405
TT
100302019-05-08 Tom Tromey <tom@tromey.com>
10031
10032 * coffread.c (struct coff_symfile_info): Add initializers.
10033 (coff_objfile_data_key): Move lower. Change type.
10034 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10035 Update.
10036 (coff_free_info): Remove.
10037
d4e05d2f
TT
100382019-05-08 Tom Tromey <tom@tromey.com>
10039
10040 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10041 (fbsd_pspace_data_handle): Move lower. Change type.
10042 (get_fbsd_pspace_data): Update.
10043 (fbsd_pspace_data_cleanup): Remove.
10044 (_initialize_fbsd_tdep): Update.
10045
14ef6690
TT
100462019-05-08 Tom Tromey <tom@tromey.com>
10047
10048 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10049 (get_ada_tasks_pspace_data): Update.
10050 (ada_tasks_pspace_data_cleanup): Remove.
10051 (_initialize_tasks): Update.
10052 (ada_tasks_inferior_data_handle): Change type.
10053 (get_ada_tasks_inferior_data): Update.
10054 (ada_tasks_inferior_data_cleanup): Remove.
10055 (struct ada_tasks_pspace_data): Add initializers.
10056
814cf43a
TT
100572019-05-08 Tom Tromey <tom@tromey.com>
10058
10059 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10060 * symfile-debug.c (debug_sym_get_probes): Change type.
10061 * stap-probe.c (handle_stap_probe):
10062 (stap_static_probe_ops::get_probes): Change type.
10063 * probe.h (class static_probe_ops) <get_probes>: Change type.
10064 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10065 (parse_probes_in_pspace): Update.
10066 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10067 Update.
10068 (any_static_probe_ops::get_probes): Change type.
10069 * elfread.c (elfread_data): New typedef.
10070 (probe_key): Change type.
10071 (elf_get_probes): Likewise. Update.
10072 (probe_key_free): Remove.
10073 (_initialize_elfread): Update.
10074 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10075 Change type.
10076 (dtrace_process_dof_probe, dtrace_process_dof)
10077 (dtrace_static_probe_ops::get_probe): Change type.
10078
02dc647e
TT
100792019-05-08 Tom Tromey <tom@tromey.com>
10080
10081 * xcoffread.c (struct xcoff_symfile_info): Rename from
10082 coff_symfile_info. Add initializers.
10083 (xcoff_objfile_data_key): Move lower. Change type.
10084 (XCOFF_DATA): Rewrite.
10085 (xcoff_free_info): Remove.
10086 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10087 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10088 (xcoff_initial_scan): Update.
10089
09232438
TT
100902019-05-08 Tom Tromey <tom@tromey.com>
10091
10092 * solib-svr4.c (struct svr4_info): Add initializers and
10093 destructor.
10094 <probes_table>: Now an htab_up.
10095 (solib_svr4_pspace_data): Change type.
10096 (free_probes_table): Simplify.
10097 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10098 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10099 (probes_table_remove_objfile_probes, register_solib_event_probe)
10100 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10101 (_initialize_svr4_solib): Update.
10102
7b4a314f
TT
101032019-05-08 Tom Tromey <tom@tromey.com>
10104
10105 * remote.c (remote_pspace_data): Change type.
10106 (remote_pspace_data_cleanup): Remove.
10107 (get_remote_exec_file, set_pspace_remote_exec_file)
10108 (_initialize_remote): Update.
10109
51d3063a
TT
101102019-05-08 Tom Tromey <tom@tromey.com>
10111
10112 * breakpoint.c (breakpoint_objfile_key): Change type.
10113 (get_breakpoint_objfile_data): Update.
10114 (free_breakpoint_objfile_data): Remove.
10115 (_initialize_breakpoint): Update.
10116
89fb8848
TT
101172019-05-08 Tom Tromey <tom@tromey.com>
10118
10119 * linux-tdep.c (struct linux_info): Add initializers.
10120 (linux_inferior_data): Move. Change type.
10121 (invalidate_linux_cache_inf): Update.
10122 (linux_inferior_data_cleanup): Remove.
10123 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10124
e9b89e2d
TT
101252019-05-08 Tom Tromey <tom@tromey.com>
10126
10127 * auxv.c (auxv_inferior_data): Move. Change type.
10128 (auxv_inferior_data_cleanup): Remove.
10129 (invalidate_auxv_cache_inf): Rewrite.
10130 (get_auxv_inferior_data, _initialize_auxv): Update.
10131
8c42777c
TT
101322019-05-08 Tom Tromey <tom@tromey.com>
10133
10134 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10135 (symfile_debug_objfile_data_key): Change type.
10136 (symfile_debug_installed, debug_qf_has_symbols)
10137 (debug_qf_find_last_source_symtab)
10138 (debug_qf_forget_cached_source_info)
10139 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10140 (debug_qf_print_stats, debug_qf_dump)
10141 (debug_qf_expand_symtabs_for_function)
10142 (debug_qf_expand_all_symtabs)
10143 (debug_qf_expand_symtabs_with_fullname)
10144 (debug_qf_map_matching_symbols)
10145 (debug_qf_expand_symtabs_matching)
10146 (debug_qf_find_pc_sect_compunit_symtab)
10147 (debug_qf_map_symbol_filenames)
10148 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10149 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10150 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10151 (debug_sym_read_linetable, debug_sym_relocate): Update.
10152 (symfile_debug_free_objfile): Remove.
10153 (install_symfile_debug_logging, _initialize_symfile_debug):
10154 Update.
10155
5bfd760d
TT
101562019-05-08 Tom Tromey <tom@tromey.com>
10157
10158 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10159 allocate_on_obstack.
10160 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10161 (get_dwarf2_per_objfile): Update.
10162 (set_dwarf2_per_objfile): Remove.
10163 (dwarf2_has_info, dwarf2_get_section_info): Update.
10164 (dwarf2_free_objfile): Remove.
10165 (_initialize_dwarf2_read): Update.
10166
e85e19b4
TT
101672019-05-08 Tom Tromey <tom@tromey.com>
10168
10169 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10170 initializers.
10171 <unsupported_script_warning_printed,
10172 script_not_found_warning_printed>: Now bool.
10173 (auto_load_pspace_data): Change type.
10174 (~auto_load_pspace_info): Rename from
10175 auto_load_pspace_data_cleanup.
10176 (get_auto_load_pspace_data, init_loaded_scripts_info)
10177 (clear_section_scripts, maybe_print_unsupported_script_warning)
10178 (maybe_print_script_not_found_warning, _initialize_auto_load):
10179 Update.
10180
f6aa7436
TT
101812019-05-08 Tom Tromey <tom@tromey.com>
10182
10183 * objfiles.c (objfile_pspace_info): Add destructor and
10184 initializers.
10185 (objfiles_pspace_data): Change type.
10186 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10187 (get_objfile_pspace_data): Update.
10188 (objfiles_bfd_data): Change type.
10189 (get_objfile_bfd_data): Update.
10190 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10191
6ae614f6
TT
101922019-05-08 Tom Tromey <tom@tromey.com>
10193
10194 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10195 Change type.
10196 (get_catch_syscall_inferior_data): Update.
10197 (catch_syscall_inferior_data_cleanup): Remove.
10198 (_initialize_break_catch_syscall): Update.
10199
6509b8eb
TT
102002019-05-08 Tom Tromey <tom@tromey.com>
10201
10202 * inflow.c (struct terminal_info): Add destructor and
10203 initializers.
10204 (inflow_inferior_data): Change type.
10205 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10206 (get_inflow_inferior_data, inflow_inferior_exit)
10207 (swap_terminal_info, _initialize_inflow): Update.
10208
35632941
TT
102092019-05-08 Tom Tromey <tom@tromey.com>
10210
10211 * target-dcache.c (target_dcache_cleanup): Remove.
10212 (target_dcache_aspace_key): Change type.
10213 (target_dcache_init_p, target_dcache_invalidate)
10214 (target_dcache_get, target_dcache_get_or_init)
10215 (_initialize_target_dcache): Update.
10216 * dcache.h (struct dcache_deleter): New.
10217
3017b94d
TT
102182019-05-08 Tom Tromey <tom@tromey.com>
10219
10220 * symtab.c (struct symbol_cache): Add destructor and
10221 initializers.
10222 (symbol_cache_key): Move. Change type.
10223 (make_symbol_cache, free_symbol_cache): Remove.
10224 (get_symbol_cache): Update.
10225 (symbol_cache_cleanup): Remove.
10226 (ALL_PSPACES, symbol_cache_flush)
10227 (maintenance_print_symbol_cache)
10228 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10229 Update.
10230
a32ad8c5
TT
102312019-05-08 Tom Tromey <tom@tromey.com>
10232
10233 * symtab.c (struct main_info): Add destructor and initializers.
10234 (main_progspace_key): Move. Change type.
10235 (get_main_info): Update.
10236 (main_info_cleanup): Remove.
10237 (_initialize_symtab): Update.
10238
5f6e90a0
TT
102392019-05-08 Tom Tromey <tom@tromey.com>
10240
10241 * registry.h (DECLARE_REGISTRY): Define the _key class.
10242
1bd0c6e4
AB
102432019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10244
10245 * NEWS: Merge two 'New commands' sections.
10246
2228ef77
XR
102472019-05-08 Joel Brobecker <brobecker@adacore.com>
10248
10249 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10250 parameter and use Ada language definition instead.
10251 (ada_val_print_ptr): Remove unused language parameter.
10252 (ada_val_print_num): Remove language parameter and use Ada language
10253 definition instead.
10254 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10255 parameter.
10256 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10257 parameter and use Ada language definition instead.
10258 (ada_val_print_1): Update all ada_val_print_xxx calls.
10259 Remove language parameter.
10260 (ada_val_print): Update ada_val_print_1 call.
10261
60fcc1c3
TT
102622019-05-08 Tom Tromey <tromey@adacore.com>
10263
10264 * remote.c (remote_hw_watchpoint_limit)
10265 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10266 Now static.
10267
ed2b7c17
TT
102682019-05-08 Tom Tromey <tromey@adacore.com>
10269
10270 * maint.c (_initialize_maint_cmds): Move initialization code to
10271 remote.c.
10272 (watchdog, show_watchdog): Move to remote.c.
10273 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10274 "watchdog" static.
10275 (_initialize_remote): Move initialization code from maint.c.
10276 * defs.h (watchdog): Don't declare.
10277
b0be6c91
TT
102782019-05-08 Tom Tromey <tromey@adacore.com>
10279
10280 * tui/tui-interp.c: Include main.h.
10281 * interps.c: Include main.h.
10282 * main.h (interpreter_p): Declare.
10283 * defs.h (interpreter_p): Don't declare.
10284
587ee17b
TT
102852019-05-08 Tom Tromey <tromey@adacore.com>
10286
10287 * dwarf2loc.c: Include dwarf2read.h.
10288 * defs.h (read_unsigned_leb128): Don't declare.
10289 * dwarf2read.h (read_unsigned_leb128): Declare.
10290
ca1df239
TT
102912019-05-08 Tom Tromey <tromey@adacore.com>
10292
10293 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10294 method.
10295
99f20f08
TT
102962019-05-08 Tom Tromey <tromey@adacore.com>
10297
10298 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10299 when no wrap column is set.
10300
80e55b13
TT
103012019-05-08 Tom Tromey <tromey@adacore.com>
10302
10303 * c-lang.c (c_get_string): Handle non-C-style arrays.
10304
9d3421af
TT
103052019-05-08 Tom Tromey <tromey@adacore.com>
10306
10307 * typeprint.c (print_offset_data::update): Print the bit offset,
10308 not the number of bits remaining.
10309
844333e2
TT
103102019-05-08 Tom Tromey <tromey@adacore.com>
10311
10312 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10313 padding at end of comment.
10314
988915ee
TT
103152019-05-08 Tom Tromey <tromey@adacore.com>
10316
10317 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10318 Compare main types.
10319
26bfd823
TT
103202019-05-06 Tom Tromey <tom@tromey.com>
10321
10322 * common/scoped_mmap.c: Include common-defs.h.
10323 * common/scoped_mmap.h: Don't include config.h.
10324
89055eaa
TT
103252019-05-04 Tom Tromey <tom@tromey.com>
10326
10327 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10328 (struct aarch64_call_info): Add initializers.
10329 <si>: Now a std::vector.
10330 (pass_on_stack, aarch64_push_dummy_call): Update.
10331
5da01df5
TT
103322019-05-04 Simon Marchi <simon.marchi@efficios.com>
10333 Tom Tromey <tom@tromey.com>
10334
10335 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10336 (ppc_threads): Now a std::vector. Now static.
10337 (hwdebug_find_thread_points_by_tid)
10338 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10339 Update.
10340
fbdf05a1
TT
103412019-05-04 Tom Tromey <tom@tromey.com>
10342
10343 * arc-tdep.c (arc_tdesc_init): Return bool.
10344
06d16ec9
TT
103452019-05-04 Tom Tromey <tom@tromey.com>
10346
10347 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10348 Use gdb_assert_not_reached.
10349
9c056022
TT
103502019-05-04 Tom Tromey <tom@tromey.com>
10351
10352 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10353 "false".
10354
fa9c2a59
TT
103552019-05-04 Tom Tromey <tom@tromey.com>
10356
10357 * arc-tdep.c (arc_tdesc_init): Use bool.
10358
e2eb806a
TT
103592019-05-04 Tom Tromey <tom@tromey.com>
10360
10361 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10362
6fe87677
TT
103632019-05-04 Tom Tromey <tom@tromey.com>
10364
10365 * cli/cli-cmds.c (valid_command_p): Return bool.
10366
7f008c9e
TT
103672019-05-04 Tom Tromey <tom@tromey.com>
10368
10369 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10370 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10371
b6484282
RT
103722019-05-04 Raul Tambre <raul@tambre.ee>
10373
10374 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10375 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10376 operator for comparison.
10377
af97b416
TT
103782019-05-04 Tom Tromey <tom@tromey.com>
10379
10380 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10381 (lookup_partial_symbol, print_partial_symbols)
10382 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10383 (psymbol_compare): Update.
10384 (add_psymbol_to_bcache): Clear the entire psymbol.
10385 (maintenance_check_psymtabs): Update.
10386 * psympriv.h (struct partial_symbol): Don't derive from
10387 general_symbol_info.
10388 <obj_section, unrelocated_address, address,
10389 set_unrelocated_address>: Update.
10390 <ginfo>: New member.
10391 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10392 (debug_names::write_psymbols): Update.
10393
9d6d4be8
TV
103942019-05-04 Tom de Vries <tdevries@suse.de>
10395
10396 * contrib/cc-with-tweaks.sh: Support -n arg.
10397
66452beb
PW
103982019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10399
10400 * corelow.c (core_target::detach): Ensure frame cache and
10401 register caches are cleared.
10402 inferior.c (exit_inferior_1): Likewise.
10403
bde09ab7
TT
104042019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10405 Tom Tromey <tom@tromey.com>
10406
10407 * dictionary.c (collate_pending_symbols_by_language): Remove
10408 "struct" from foreach.
10409 * symtab.c (lookup_global_symbol_from_objfile)
10410 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10411 foreach.
10412 * ser-tcp.c (net_open): Remove "struct" from foreach.
10413 * objfiles.c (objfile_relocate, objfile_rebase)
10414 (objfile_has_symbols): Remove "struct" from foreach.
10415 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10416 from foreach.
10417 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10418 foreach.
10419 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10420 "struct" from foreach.
10421 * ada-lang.c (create_excep_cond_exprs)
10422 (ada_exception_catchpoint_cond_string): Remove "struct" from
10423 foreach.
10424
222a8d25
TT
104252019-05-03 Tom Tromey <tromey@adacore.com>
10426
10427 * ada-exp.y (convert_char_literal): Check suffix of each
10428 enumerator.
10429
fcd60b84
DP
104302019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10431
10432 PR ada/21406:
10433 * ada-exp.y (yywrap): Don't define.
10434 * ada-lex.l (%option): Add noyywrap
10435 (yywrap): Remove.
10436
5f2459c2
EZ
104372019-05-03 Eli Zaretskii <eliz@gnu.org>
10438
353ea2d1
EZ
10439 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10440 _WIN32_WINNT to the XP level, unless already defined to a higher
10441 level.
10442
10443 * unittests/parse-connection-spec-selftests.c:
10444 * ser-tcp.c:
10445 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10446 override.
10447
5f2459c2
EZ
10448 * symfile.c (find_separate_debug_file): Remove colon from the
10449 drive spec of DOS/Windows file names of the target, so that the
10450 file name produced from DEBUGDIR and the target's directory will
10451 be valid on DOS/Windows systems.
10452
80062eb9
AB
104532019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10454
10455 * rust-lang.c (val_print_struct): Handle printing structures
10456 containing strings.
10457
b8c05e85
TT
104582019-05-02 Tom Tromey <tromey@adacore.com>
10459
10460 * valarith.c (_initialize_valarith): Remove.
10461
4504bbde
TT
104622019-05-01 Tom Tromey <tromey@adacore.com>
10463
10464 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10465 bitfields.
10466
d48e62f4
TT
104672019-05-01 Tom Tromey <tromey@adacore.com>
10468
10469 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10470 for big-endian copies.
10471
15f18d14
AT
104722019-04-30 Ali Tamur <tamur@google.com>
10473 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10474 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10475 (read_3_bytes): New function.
10476
ab4ee614
JB
104772019-04-30 Joel Brobecker <brobecker@adacore.com>
10478
10479 * windows-nat.c (main_thread_id): Delete.
10480 (handle_output_debug_string): Replace main_thread_id by
10481 current_event.dwThreadId.
10482 (fake_create_process): Likewise.
10483 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10484 Do not set main_thread_id.
10485 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10486 current_event.dwThreadId.
10487 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10488
8ed5b76e
JB
104892019-04-30 Joel Brobecker <brobecker@adacore.com>
10490
10491 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10492 Use current_event.dwThreadId instead of main_thread_id.
10493
2ff0a947
TT
104942019-04-30 Tom Tromey <tromey@adacore.com>
10495
10496 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10497 (create_excep_cond_exprs): Iterate over program spaces.
10498 (ada_exception_catchpoint_cond_string): Examine all minimal
10499 symbols for exception types.
10500
a776957c
TT
105012019-04-30 Tom Tromey <tromey@adacore.com>
10502
10503 PR c++/24470:
10504 * dwarf2read.c (process_structure_scope): Handle case where type
10505 has template parameters but no symbol was created.
10506
bc68014d
AB
105072019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10508 Chris January <chris.january@arm.com>
10509
10510 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10511 qualifier.
10512 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10513
f1fdc960
AB
105142019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10515
10516 * f-typeprint.c (f_print_type): Update rules for printing
10517 whitespace.
10518 (f_type_print_varspec_suffix): Likewise.
10519
bf7a4de1
AB
105202019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10521 Chris January <chris.january@arm.com>
10522
10523 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10524 function arguments.
10525
bbe75b9d
AB
105262019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10527
10528 * f-lang.c (build_fortran_types): Change name of void type to
10529 lower case.
10530 * f-typeprint.c (f_type_print_base): Print the name of the void
10531 type, rather than a fixed string.
10532 * f-valprint.c (f_decorations): Use lower case void string.
10533
1db455a7
AB
105342019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10535 Chris January <chris.january@arm.com>
10536
10537 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10538 types for Fortran.
10539
b6d03bb2
AB
105402019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10541 Chris January <chris.january@arm.com>
10542 David Lecomber <david.lecomber@arm.com>
10543
10544 * f-exp.y (BINOP_INTRINSIC): New token.
10545 (exp): New parser rule handling BINOP_INTRINSIC.
10546 (f77_keywords): Add new builtin procedures.
10547 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10548 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10549 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10550 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10551 (print_unop_subexp_f): New function.
10552 (print_binop_subexp_f): New function.
10553 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10554 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10555 (dump_subexp_body_f): Likewise.
10556 (operator_check_f): Likewise.
10557 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10558 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10559
83228e93
AB
105602019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10561
10562 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10563 UNOP_KIND.
10564 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10565 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10566 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10567 (operator_length_f): New fuction.
10568 (print_subexp_f): New function.
10569 (op_name_f): New function.
10570 (dump_subexp_body_f): New function.
10571 (operator_check_f): New function.
10572 (exp_descriptor_f): Replace standard expression handling functions
10573 with new functions.
10574 * gdb/fortran-operator.def: New file.
10575 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10576 * gdb/std-operator.def: Remove UNOP_KIND.
10577
6fdcd7cc
AB
105782019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10579
10580 * std-operator.def: Remove unbalanced, stray double quote
10581 character.
10582
2e62ab40
AB
105832019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10584 Chris January <chris.january@arm.com>
10585 Daniel Everett <daniel.everett@arm.com>
10586 Nick Forrington <nick.forrington@arm.com>
10587 Richard Bunt <richard.bunt@arm.com>
10588
10589 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10590 of depth when printing anonymous structs or unions.
10591 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10592 Don't print either the top-level value, or the children if the
10593 max-depth is exceeded.
10594 (ppscm_print_children): When printing the key of a map, allow one
10595 extra level of depth.
10596 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10597 print either the top-level value, or the children if the max-depth
10598 is exceeded.
10599 (print_children): When printing the key of a map, allow one extra
10600 level of depth.
10601 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10602 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10603 (user_print_options): Initialise max_depth field.
10604 (val_print_scalar_or_string_type_p): New function.
10605 (val_print): Check to see if the max depth has been reached.
10606 (val_print_check_max_depth): Define new function.
10607 (show_print_max_depth): New function.
10608 (_initialize_valprint): Add 'print max-depth' option.
10609 * valprint.h (struct value_print_options) <max_depth>: New field.
10610 (val_print_check_max_depth): Declare new function.
10611 * NEWS: Document new feature.
10612
4be290b2
AB
106132019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10614
10615 * ada-lang.c (ada_language_defn): Initialise new field.
10616 * c-lang.c (c_is_string_type_p): New function.
10617 (c_language_defn): Initialise new field.
10618 (cplus_language_defn): Initialise new field.
10619 (asm_language_defn): Initialise new field.
10620 (minimal_language_defn): Initialise new field.
10621 * c-lang.h (c_is_string_type_p): Declare new function.
10622 * d-lang.c (d_language_defn): Initialise new field.
10623 * f-lang.c (f_is_string_type_p): New function.
10624 (f_language_defn): Initialise new field.
10625 * go-lang.c (go_is_string_type_p): New function.
10626 (go_language_defn): Initialise new field.
10627 * language.c (default_is_string_type_p): New function.
10628 (unknown_language_defn): Initialise new field.
10629 (auto_language_defn): Initialise new field.
10630 * language.h (struct language_defn) <la_is_string_type_p>: New
10631 member variable.
10632 (default_is_string_type_p): Declare new function.
10633 * m2-lang.c (m2_language_defn): Initialise new field.
10634 * objc-lang.c (objc_language_defn): Initialise new field.
10635 * opencl-lang.c (opencl_language_defn): Initialise new field.
10636 * p-lang.c (pascal_is_string_type_p): New function.
10637 (pascal_language_defn): Initialise new field.
10638 * rust-lang.c (rust_is_string_type_p): New function.
10639 (rust_language_defn): Initialise new field.
10640
721b08c6
AB
106412019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10642
10643 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10644 New field.
10645 * ada-lang.c (ada_language_defn): Initialise new field.
10646 * c-lang.c (c_language_defn): Likewise.
10647 (cplus_language_defn): Likewise.
10648 (asm_language_defn): Likewise.
10649 (minimal_language_defn): Likewise.
10650 * d-lang.c (d_language_defn): Likewise.
10651 * f-lang.c (f_language_defn): Likewise.
10652 * go-lang.c (go_language_defn): Likewise.
10653 * language.c (unknown_language_defn): Likewise.
10654 (auto_language_defn): Likewise.
10655 * m2-lang.c (m2_language_defn): Likewise.
10656 * objc-lang.c (objc_language_defn): Likewise.
10657 * opencl-lang.c (opencl_language_defn): Likewise.
10658 * p-lang.c (pascal_language_defn): Likewise.
10659 * rust-lang.c (rust_language_defn): Likewise.
10660
fc913e53
AB
106612019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10662
10663 * ada-lang.c (ada_is_character_type): Change return type to bool.
10664 (ada_is_string_type): Likewise.
10665 * ada-lang.h (ada_is_character_type): Update declaration
10666 (ada_is_string_type): Likewise.
10667
fa731fa0
PW
106682019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10669
10670 Support style in 'frame|thread apply'
10671
10672 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10673 * record.c (record_start, record_stop): Update callers of
10674 execute_command_to_string with false.
10675 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10676 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10677 methods.
10678 (class string_file): New constructor with term_out parameter.
10679 Override methods term_out and can_emit_style_escape. New member
10680 term_out.
10681 (class stdio_file): Override can_emit_style_escape.
10682 (class tee_file): Override term_out and can_emit_style_escape.
10683 * utils.h (can_emit_style_escape): Remove.
10684 * utils.c (can_emit_style_escape): Likewise.
10685 Update all callers of can_emit_style_escape (SOMESTREAM) to
10686 SOMESTREAM->can_emit_style_escape.
10687 * source-cache.c (source_cache::get_source_lines): Likewise.
10688 * stack.c (frame_apply_command_count): Call execute_command_to_string
10689 passing the term_out characteristic of the current gdb_stdout.
10690 * thread.c (thr_try_catch_cmd): Likewise.
10691 * top.c (execute_command_to_string): pass term_out parameter
10692 to construct the string_file for the command output.
10693 * ui-file.c (term_cli_styling): New function (most code moved
10694 from utils.c can_emit_style_escape).
10695 (string_file::string_file, string_file::can_emit_style_escape,
10696 stdio_file::can_emit_style_escape, tee_file::term_out,
10697 tee_file::can_emit_style_escape): New functions.
10698
136afab8
PW
106992019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10700
10701 * NEWS: Mention the new set|show may-call-functions.
10702 * infcall.c (may_call_functions_p): New variable.
10703 (show_may_call_functions_p): New function.
10704 (call_function_by_hand_dummy): Throws an error if not
10705 may-call-functions.
10706 (_initialize_infcall): Call add_setshow_boolean_cmd for
10707 may-call-functions.
10708
725cbb63
KS
107092019-04-25 Keith Seitz <keiths@redhat.com>
10710
10711 PR c++/24367
10712 * cp-support.c (inspect_type): Don't attempt substitutions
10713 of symbol with the same name.
10714
3d1cbb78
TT
107152019-04-25 Tom Tromey <tromey@adacore.com>
10716
10717 PR gdb/24475:
10718 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10719 static.
10720
94aeb44b
TT
107212019-04-25 Tom Tromey <tromey@adacore.com>
10722
10723 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10724 rvalue reference.
10725 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10726 (gdb_xml_parser::parse): Use std::move.
10727 * python/python-internal.h (gdbpy_convert_exception): Take a const
10728 reference.
10729 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10730 std::move.
10731 * python/py-utils.c (gdbpy_convert_exception): Take a const
10732 reference.
10733 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10734 Use std::move.
10735 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10736 Use std::move.
10737 * mi/mi-main.c (mi_print_exception): Take a const reference.
10738 * main.c (handle_command_errors): Take a const reference.
10739 * linespec.c (parse_linespec): Use std::move.
10740 * infcall.c (run_inferior_call): Use std::move.
10741 (call_function_by_hand_dummy): Use std::move.
10742 * exec.c (try_open_exec_file): Use std::move.
10743 * exceptions.h (exception_print, exception_fprintf)
10744 (exception_print_same): Update.
10745 * exceptions.c (print_exception, exception_print)
10746 (exception_fprintf, exception_print_same): Change parameters to
10747 const reference.
10748 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10749 * common/new-op.c: Use std::move.
10750 * common/common-exceptions.h (struct gdb_exception): Add move
10751 constructor.
10752 (struct gdb_exception_error, struct gdb_exception_quit, struct
10753 gdb_quit_bad_alloc): Change constructor to move constructor.
10754 (throw_exception): Change parameter to rvalue reference.
10755 * common/common-exceptions.c (throw_exception): Take rvalue
10756 reference.
10757 * cli/cli-interp.c (safe_execute_command): Use std::move.
10758 * breakpoint.c (insert_bp_location, location_to_sals): Use
10759 std::move.
10760
680d7fd5
TT
107612019-04-25 Tom Tromey <tromey@adacore.com>
10762
10763 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10764 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10765 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10766 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10767 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10768 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10769 guile/scm-value.c: Use unpack.
10770 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10771 gdbscm_gdb_exception.
10772 (gdbscm_throw_gdb_exception): Likewise.
10773 (struct gdbscm_gdb_exception): New.
10774 (unpack): New function.
10775 (gdbscm_wrap): Use unpack.
10776
c6fdd8b2
TT
107772019-04-25 Tom Tromey <tromey@adacore.com>
10778
10779 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10780 (gdb_rl_callback_handler): Use std::move.
10781 * common/common-exceptions.h (struct gdb_exception): Add move
10782 assignment operator.
10783 (throw_exception_sjlj): Change "exception" to const reference.
10784 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10785 (throw_exception_sjlj): Change "exception" to const reference.
10786
cc06b668
TT
107872019-04-25 Tom Tromey <tromey@adacore.com>
10788
10789 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10790 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10791 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10792 Update.
10793 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10794 Update.
10795 * mi/mi-interp.c (mi_interp::exec): Update.
10796 * linespec.c (parse_linespec): Update.
10797 * infcall.c (run_inferior_call): Update.
10798 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10799 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10800 (gdbscm_lookup_global_symbol): Update.
10801 * guile/scm-param.c (gdbscm_parameter_value): Update.
10802 * guile/scm-frame.c (gdbscm_frame_read_register)
10803 (gdbscm_frame_read_var): Update.
10804 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10805 * exec.c (try_open_exec_file): Update.
10806 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10807 (gdb_rl_callback_handler): Update.
10808 * common/common-exceptions.h (exception_none): Don't declare.
10809 * common/common-exceptions.c (exception_none): Don't define.
10810 (struct catcher) <exception>: Update.
10811 * cli/cli-interp.c (safe_execute_command): Update.
10812 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10813
cf532bd1
AT
108142019-04-25 Ali Tamur <tamur@google.com>
10815
10816 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10817 (read_attribute_value): Likewise.
10818 (dwarf2_read_addr_index): Update comment.
10819 (read_str_index): Add DW_FORM_strx.
10820 (dwarf2_string_attr): Likewise.
10821 (dwarf2_const_value_attr): Likewise.
10822 (dump_die_shallow): Likewise.
10823 (dwarf2_fetch_constant_bytes): Likewise.
10824 (skip_form_bytes): Likewise.
10825 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10826
82433e3e
SDJ
108272019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10828
10829 PR corefiles/11608
10830 PR corefiles/18187
10831 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10832 OFFSET. Verify if current mapping contains an ELF header.
10833 (linux_find_memory_regions_full): Adjust call to
10834 dump_mapping_p.
10835
723adb65
SL
108362019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10837 Kang Li <kanglictf@gmail.com>
10838
10839 PR gdb/21600
10840
10841 * dwarf2-frame.c (read_initial_length): Be consistent about using
10842 unsigned representation of length.
10843 (decode_frame_entry_1): Likewise. Check for wraparound of
10844 end pointer as well as buffer overflow.
10845
596179f7
SDJ
108462019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10847
10848 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10849 "vq".
10850
a59240a4
TT
108512019-04-24 Tom Tromey <tromey@adacore.com>
10852
10853 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10854
f872fdbb
AB
108552019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10856
10857 * s12z-tdep.c (s12z_unwind_pc): Delete.
10858 (s12z_unwind_sp): Delete.
10859 (s12z_gdbarch_init): Don't register deleted functions with
10860 gdbarch.
10861
b614e6f3
AB
108622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10863
10864 * rl78-tdep.c (rl78_unwind_sp): Delete.
10865 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10866
14faed38
AB
108672019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10868
10869 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10870 (xstormy16_unwind_pc): Delete.
10871 (xstormy16_dummy_id): Delete.
10872 (xstormy16_gdbarch_init): Don't register deleted functions with
10873 gdbarch.
10874
541aad8a
AB
108752019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10876
10877 * vax-tdep.c (vax_unwind_pc): Delete.
10878 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10879
29222070
AB
108802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10881
10882 * v850-tdep.c (v850_unwind_sp): Delete.
10883 (v850_unwind_pc): Delete.
10884 (v850_dummy_id): Delete.
10885 (v850_gdbarch_init): Don't register deleted functions with
10886 gdbarch.
10887
0f534d76
AB
108882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10889
10890 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10891 (tilegx_unwind_pc): Delete.
10892 (tilegx_unwind_dummy_id): Delete.
10893 (tilegx_gdbarch_init): Don't register deleted functions with
10894 gdbarch.
10895
1ba7b7f9
AB
108962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10897
10898 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10899 (tic6x_dummy_id): Delete.
10900 (tic6x_gdbarch_init): Don't register deleted functions with
10901 gdbarch.
10902
d31f262c
AB
109032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10904
10905 * sparc-tdep.c (sparc_unwind_pc): Delete.
10906 (sparc32_gdbarch_init): Don't register deleted function with
10907 gdbarch.
10908
6d14d64d
AB
109092019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10910
10911 * sh-tdep.c (sh_unwind_sp): Delete.
10912 (sh_unwind_pc): Delete.
10913 (sh_dummy_id): Delete.
10914 (sh_gdbarch_init): Don't register deleted functions with
10915 gdbarch.
10916
a40dde9d
AB
109172019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10918
10919 * score-tdep.c (score_unwind_sp): Delete.
10920 (score_unwind_pc): Delete.
10921 (score_dummy_id): Delete.
10922 (score_gdbarch_init): Don't register deleted functions with
10923 gdbarch.
10924
47c47d69
AB
109252019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10926
10927 * rx-tdep.c (rx_unwind_pc): Delete.
10928 (rx_unwind_sp): Delete.
10929 (rx_dummy_id): Delete.
10930 (rx_gdbarch_init): Don't register deleted functions with
10931 gdbarch. Update comment.
10932
833a4480
AB
109332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10934
10935 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10936 (rs6000_dummy_id): Delete.
10937 (rs6000_gdbarch_init): Don't register deleted functions with
10938 gdbarch.
10939
3f2cef49
AB
109402019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10941
10942 * or1k-tdep.c (or1k_dummy_id): Delete.
10943 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10944
96acf884
AB
109452019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10946
10947 * nios2-tdep.c (nios2_dummy_id): Delete.
10948 (nios2_unwind_sp): Delete.
10949 (nios2_gdbarch_init): Don't register deleted functions with
10950 gdbarch.
10951
ca0ab0aa
AB
109522019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10953
10954 * nds32-tdep.c (nds32_dummy_id): Delete.
10955 (nds32_unwind_pc): Delete.
10956 (nds32_unwind_sp): Delete.
10957 (nds32_gdbarch_init): Don't register deleted functions with
10958 gdbarch.
10959
c8259044
AB
109602019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10961
10962 * msp430-tdep.c (msp430_unwind_pc): Delete.
10963 (msp430_unwind_sp): Delete.
10964 (msp430_dummy_id): Delete.
10965 (msp430_gdbarch_init): Don't register deleted functions with
10966 gdbarch.
10967
27f113c8
AB
109682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10969
10970 * moxie-tdep.c (moxie_unwind_sp): Delete.
10971 (moxie_unwind_pc): Delete.
10972 (moxie_dummy_id): Delete.
10973 (moxie_gdbarch_init): Don't register deleted functions with
10974 gdbarch.
10975
aee6c3cd
AB
109762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10977
10978 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10979 (mn10300_unwind_pc): Delete.
10980 (mn10300_unwind_sp): Delete.
10981 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10982 mn10300_unwind_sp.
10983 (mn10300_frame_unwind_init): Don't register deleted functions with
10984 gdbarch.
10985
8e2b5aea
AB
109862019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10987
10988 * mep-tdep.c (mep_unwind_pc): Delete.
10989 (mep_unwind_sp): Delete.
10990 (mep_dummy_id): Delete.
10991 (mep_gdbarch_init): Don't register deleted functions with
10992 gdbarch.
10993
43cf3ede
AB
109942019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10995
10996 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10997 (m68hc11_unwind_sp): Delete.
10998 (m68hc11_gdbarch_init): Don't register deleted functions with
10999 gdbarch.
11000
5e79b7bb
AB
110012019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11002
11003 * m32r-tdep.c (m32r_unwind_sp): Delete.
11004 (m32r_unwind_pc): Delete.
11005 (m32r_dummy_id): Delete.
11006 (m32r_gdbarch_init): Don't register deleted functions with
11007 gdbarch.
11008
89b268d8
AB
110092019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11010
11011 * m32c-tdep.c (m32c_unwind_pc): Delete.
11012 (m32c_unwind_sp): Delete.
11013 (m32c_dummy_id): Delete.
11014 (m32c_gdbarch_init): Don't register deleted functions with
11015 gdbarch.
11016
946c28d2
AB
110172019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11018
11019 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11020 (lm32_unwind_pc): Delete.
11021 (lm32_dummy_id): Delete.
11022 (lm32_gdbarch_init): Don't register deleted functions with
11023 gdbarch.
11024
bf12844a
AB
110252019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11026
11027 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11028 (iq2000_unwind_pc): Delete.
11029 (iq2000_dummy_id): Delete.
11030 (iq2000_gdbarch_init): Don't register deleted functions with
11031 gdbarch.
11032
ecbc06d2
AB
110332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11034
11035 * nds32-tdep.c (nds32_type_align): Delete.
11036 (nds32_push_dummy_call): Use type_align instead.
11037
030197b4
AB
110382019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11039
11040 * arm-tdep.c (arm_type_align): Only handle vector override case.
11041 (arm_push_dummy_call): Use type_align.
11042 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11043
b907456c
AB
110442019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11045
11046 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11047 case.
11048 (pass_on_stack): Use type_align.
11049 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11050 function.
11051
9e97ba43
TT
110522019-04-23 Tom Tromey <tromey@adacore.com>
11053
11054 * dwarf2read.c (line_header::file_name_at): Remove unused
11055 overload.
11056
6892f601
TV
110572019-04-23 Tom de Vries <tdevries@suse.de>
11058
11059 PR gdb/24438
11060 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11061 invocation.
11062
336d760d
AT
11063
110642019-03-27 Ali Tamur <tamur@google.com>
11065
11066 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11067 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11068 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11069 (dwarf_expr_context::get_addr_index): Likewise
11070 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11071 (symbol_needs_eval_context::get_addr_index): Likewise
11072 (disassemble_dwarf_expression): Add DW_OP_addrx
11073 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11074 (read_cutu_die_from_dwo): Update comment
11075 (skip_one_die): Add DW_FORM_addrx
11076 (read_attribute_value): Likewise
11077 (var_decode_location): Add DW_OP_addrx
11078 (dwarf2_const_value_attr): Add DW_FORM_addrx
11079 (dump_die_shallow): Likewise
11080 (dwarf2_fetch_constant_bytes): Likewise
11081 (decode_locdesc): Add DW_OP_addrx
11082 (skip_form_bytes): Add DW_FORM_addrx
11083
ad9d13f8
AT
110842019-04-22 Ali Tamur <tamur@google.com>
11085
11086 * MAINTAINERS (Write After Approval): Add self.
11087
d70cc3ba
SM
110882019-04-22 Simon Marchi <simon.marchi@efficios.com>
11089
11090 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11091 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11092 (open_symbol_file_object): Likewise.
11093 (svr4_default_sos): Add info parameter.
11094 (svr4_read_so_list): Likewise.
11095 (svr4_current_sos_direct): Adjust functions calls to pass down
11096 info.
11097 (svr4_current_sos_1): Add info parameter.
11098 (svr4_current_sos): Call get_svr4_info, pass info down to
11099 svr4_current_sos_1.
11100 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11101 get_svr4_info.
11102 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11103 get_svr4_info.
11104 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11105 to get_svr4_info.
11106 (probes_table_remove_objfile_probes): Likewise.
11107 (register_solib_event_probe): Add info parameter.
11108 (solist_update_incremental): Pass info parameter down to
11109 svr4_read_so_list.
11110 (disable_probes_interface): Add info parameter.
11111 (svr4_handle_solib_event): Pass current_program_space to
11112 get_svr4_info. Adjust disable_probes_interface cleanup.
11113 (svr4_create_probe_breakpoints): Add info parameter, pass it
11114 down to register_solib_event_probe.
11115 (svr4_create_solib_event_breakpoints): Add info parameter,
11116 pass it down to svr4_create_probe_breakpoints.
11117 (enable_break): Pass info down to
11118 svr4_create_solib_event_breakpoints.
11119 (svr4_solib_create_inferior_hook): Pass current_program_space to
11120 get_svr4_info.
11121 (svr4_clear_solib): Likewise.
11122
7905fc35
PA
111232019-04-22 Pedro Alves <palves@redhat.com>
11124
11125 * solib-svr4.c (svr4_free_objfile_observer): New.
11126 (probe_and_action::objfile): New field.
11127 (probes_table_htab_remove_objfile_probes)
11128 (probes_table_remove_objfile_probes): New functions.
11129 (register_solib_event_probe): Add 'objfile' parameter. Store it
11130 in the new probe_and_action. Don't store the probe in 'lookup'.
11131 (svr4_create_probe_breakpoints): Pass objfile to
11132 register_solib_event_probe.
11133 (_initialize_svr4_solib): Register a free_objfile observer.
11134
fb881986
TT
111352019-04-19 Tom Tromey <tom@tromey.com>
11136
11137 * common/queue.h: Remove.
11138
8732db6c
TT
111392019-04-19 Tom Tromey <tom@tromey.com>
11140
11141 * event-loop.c: Don't include "common/queue.h".
11142
97dfbadd
TT
111432019-04-19 Tom Tromey <tom@tromey.com>
11144
11145 * remote.c (remote_target): Use delete.
11146 * remote-notif.h: Include <list>, not "common/queue.h".
11147 (notif_client_p): Remove typedef.
11148 (remote_notif_state): Add constructor, destructor, initializer.
11149 <notif_queue>: Now a std::list.
11150 (remote_notif_state_xfree): Don't declare.
11151 * remote-notif.c (remote_notif_process, handle_notification)
11152 (remote_notif_state_allocate): Update.
11153 (~remote_notif_state): Rename from remote_notif_state_xfree.
11154
cf250e36
TT
111552019-04-19 Tom Tromey <tom@tromey.com>
11156
11157 * symfile.c (reread_symbols): Update.
11158 * objfiles.c (objfile_register_static_link)
11159 (objfile_lookup_static_link): Update
11160 (~objfile) Don't delete static_links.
11161 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11162
61f4b350
TT
111632019-04-19 Tom Tromey <tom@tromey.com>
11164
11165 * type-stack.h (struct type_stack) <insert>: Constify string.
11166 * type-stack.c (type_stack::insert): Constify string.
11167 * gdbtypes.h (lookup_template_type): Update.
11168 (address_space_name_to_int): Update.
11169 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11170 const.
11171 (lookup_template_type): Make name const.
11172 * c-exp.y: Update rules.
11173 (lex_one_token, classify_name, classify_inner_name)
11174 (c_print_token): Update.
11175 * p-exp.y: Update rules.
11176 (yylex): Update.
11177 * f-exp.y: Update rules.
11178 (yylex): Update.
11179 * d-exp.y: Update rules.
11180 (lex_one_token, classify_name, classify_inner_name): Update.
11181 * parse.c (write_dollar_variable, copy_name): Return std::string.
11182 * parser-defs.h (copy_name): Change return type.
11183 * m2-exp.y: Update rules.
11184 (yylex): Update.
11185 * go-exp.y (lex_one_token): Update.
11186 Update rules.
11187 (classify_unsafe_function, classify_packaged_name)
11188 (classify_name, yylex): Update.
11189
189b8c2e
ST
111902019-04-19 Sergei Trofimovich <siarheit@google.com>
11191
11192 * configure.ac: add --enable-source-highlight switch.
11193 * configure: Regenerate.
11194 * top.c (print_gdb_version): plumb --enable-source-highlight
11195 status to "show configuration".
11196
8ecb59f8
TT
111972019-04-19 Tom Tromey <tromey@adacore.com>
11198
11199 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11200 Check ADA_TYPE_P.
11201 (empty_record, ada_template_to_fixed_record_type_1)
11202 (template_to_static_fixed_type)
11203 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11204 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11205 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11206 macros.
11207
62160ec9
TT
112082019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11209
11210 PR symtab/24423:
11211 * source.c (print_source_lines_base): Advance "iter" when a
11212 control character is seen.
11213
f2ae8bc8
PW
112142019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11215
11216 * inferior.h (struct infcall_suspend_state_deleter):
11217 Catch exception in destructor to avoid crash.
11218
d563b953
PW
112192019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11220
11221 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11222 close to the add_com "shell".
11223
dc34c897
TT
112242019-04-18 Tom Tromey <tromey@adacore.com>
11225
11226 * process-stratum-target.h (class process_stratum_target)
11227 <stratum>: Add "final".
11228
a12e5744
TT
112292019-04-17 Tom Tromey <tromey@adacore.com>
11230
11231 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11232 against nullptr before use.
11233
a7e559cc
AH
112342019-04-17 Alan Hayward <alan.hayward@arm.com>
11235
11236 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11237
c01660c6
AB
112382019-04-17 Jim Wilson <jimw@sifive.com>
11239 Andrew Burgess <andrew.burgess@embecosm.com>
11240
11241 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11242 code read might fail, assume 4-byte breakpoint in that case.
11243
4aa866af
LS
112442019-04-15 Leszek Swirski <leszeks@google.com>
11245
11246 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11247 rather than a hand-rolled POD check when checking for forced MEMORY
11248 classification.
11249
48574d91
AH
112502019-04-15 Alan Hayward <alan.hayward@arm.com>
11251
11252 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11253 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11254 function.
11255 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11256 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11257 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11258 declaration.
11259
4da037ef
AH
112602019-04-15 Alan Hayward <alan.hayward@arm.com>
11261
11262 * aarch64-linux-nat.c
11263 (aarch64_linux_nat_target::thread_architecture): Add override.
11264 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11265 each VQ.
11266
ccb8d7e8
AH
112672019-04-15 Alan Hayward <alan.hayward@arm.com>
11268
11269 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11270
35add35e
AB
112712019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11272
11273 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11274 target types of size 96-bits, add some additional comments, and
11275 check that the builtin type we found was the correct size.
11276
51196bbc
EZ
112772019-04-12 Eli Zaretskii <eliz@gnu.org>
11278
11279 * utils.c (prompt_for_continue): Don't restore the styling at the
11280 end, as applied_style has the wrong value. This fixes styling in
11281 long lists of file names that are interrupted by the "Continue?"
11282 prompt.
11283
62253a61
AB
112842019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11285
11286 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11287 * c-lang.c (c_language_defn): Likewise.
11288 (cplus_language_defn): Likewise.
11289 (asm_language_defn): Likewise.
11290 (minimal_language_defn): Likewise.
11291 * d-lang.c (d_language_defn): Likewise.
11292 * f-lang.c (f_language_defn): Likewise.
11293 * go-lang.c (go_language_defn): Likewise.
11294 * language.c (unknown_language_defn): Likewise.
11295 (auto_language_defn): Likewise.
11296 * language.h (struct language_defn): Remove la_magic field.
11297 (LANG_MAGIC): Delete.
11298 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11299 * objc-lang.c (objc_language_defn): Likewise.
11300 * opencl-lang.c (opencl_language_defn): Likewise.
11301 * p-lang.c (pascal_language_defn): Likewise.
11302 * rust-lang.c (rust_language_defn): Likewise.
11303
a9158a86
AB
113042019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11305
11306 * riscv-tdep.c (riscv_type_align): New function.
11307 (riscv_type_alignment): Delete.
11308 (riscv_arg_location): Use 'type_align'.
11309 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11310
41077b66
AB
113112019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11312
11313 * gdbtypes.c (type_align): A struct with no non-static fields also
11314 has alignment of 1.
11315
9f0272f8
AB
113162019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11317
11318 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11319 component to 0.
11320 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11321 member.
11322 (riscv_struct_info::analyse): New implementation using new
11323 analyse_inner member function.
11324 (riscv_struct_info::field_offset): New member function.
11325 (riscv_struct_info::m_offsets): New member variable.
11326 (riscv_struct_info::analyse_inner): New private member function,
11327 takes the old implementation of riscv_struct_info::analyse but
11328 extended to track field offsets.
11329 (riscv_call_arg_struct): Update the struct folding special cases
11330 to handle cases where empty C++ structs, which are non-zero
11331 length, are found.
11332 (riscv_arg_location): Initialise the length of each location, a
11333 non-zero length now indicates the location is in use.
11334 (riscv_push_dummy_call): Allow for the first location having a
11335 non-zero offset when setting up arguments.
11336 (riscv_return_value): Likewise, but for return values.
11337
02cf60c7
TT
113382019-04-11 Tom Tromey <tromey@adacore.com>
11339
11340 * utils.c (internal_vproblem): Make "msg" const.
11341
68811f8f
AH
113422019-04-11 Alan Hayward <alan.hayward@arm.com>
11343
11344 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11345 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11346 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11347 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11348
3f52fdbc
KB
113492019-04-10 Kevin Buettner <kevinb@redhat.com>
11350
11351 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11352 function.
11353 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11354 of amd64_collect_native_gregset.
11355 (amd64_linux_nat_target::store_registers): Likewise.
11356
e9ad22ee
TT
113572019-04-10 Tom Tromey <tom@tromey.com>
11358
11359 * symtab.c (lookup_global_symbol_from_objfile)
11360 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11361 * objfiles.h (class separate_debug_iterator): New.
11362 (class separate_debug_range): New.
11363 (struct objfile) <separate_debug_objfiles>: New method.
11364 (objfile_separate_debug_iterate): Don't declare.
11365 * objfiles.c (separate_debug_iterator::operator++): Rename from
11366 objfile_separate_debug_iterate.
11367 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11368 iterator.
11369 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11370 iterator.
11371
ee371134
TT
113722019-04-10 Tom Tromey <tom@tromey.com>
11373
11374 * symfile.c (reread_symbols): Remove old comment.
11375 * objfiles.c (free_all_objfiles): Fix a typo.
11376
bf227d61
TT
113772019-04-10 Tom Tromey <tom@tromey.com>
11378
11379 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11380 * minsyms.c (lookup_minimal_symbol): Use foreach.
11381 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11382 (lookup_minimal_symbol_solib_trampoline): Likewise.
11383 * symfile.c (reread_symbols): Use foreach.
11384
8dc433a0
TT
113852019-04-09 Ivan Begert <ivanbegert@gmail.com>
11386 Tom Tromey <tromey@adacore.com>
11387
11388 PR rust/24414:
11389 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11390 (rust_lex_int_test): Change "value" to be LONGEST.
11391 (rust_lex_tests): Add test for long integer literal.
11392
9ab8741a
TT
113932019-04-09 Tom Tromey <tromey@adacore.com>
11394
11395 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11396 to bool.
11397 (extended_remote_target::attach): Update.
11398 (remote_target::remote_notice_new_inferior): Update.
11399 (remote_target::add_current_inferior_and_thread): Update.
11400 * inferior.c (exit_inferior_1): Use "false".
11401 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11402
e242fd12
SM
114032019-04-09 Simon Marchi <simon.marchi@efficios.com>
11404
9ca1957f 11405 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
11406 the "start" command.
11407
2b0c8b01
KB
114082019-04-08 Kevin Buettner <kevinb@redhat.com>
11409
11410 * python/py-inferior.c (infpy_thread_from_thread_handle):
11411 Adjust comments to reflect renaming of thread_from_thread_handle
11412 to thread_from_handle. Adjust keywords. Fix type error message.
11413 (inferior_object_methods): Add thread_from_handle. Retain
11414 thread_from_thread_handle, but mark it as deprecated.
11415
50a82723
KB
114162019-04-08 Kevin Buettner <kevinb@redhat.com>
11417
11418 * gdbthread.h (find_thread_by_handle): Revise declaration.
11419 * thread.c (find_thread_by_handle): Likewise. Adjust
11420 implementation too.
11421 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11422 support for buffer objects as handles.
11423
cf63b016
KB
114242019-04-08 Kevin Buettner <kevinb@redhat.com>
11425
11426 * python/py-infthread.c (thpy_thread_handle): New function.
11427 (thread_object_methods): Register thpy_thread_handle.
11428
3d6c6204
KB
114292019-04-08 Kevin Buettner <kevinb@redhat.com>
11430
11431 * gdbthread.h (thread_to_thread_handle): Declare.
11432 * thread.c (gdbtypes.h): Include.
11433 (thread_to_thread_handle): New function.
11434
11435 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11436 (target_thread_info_to_thread_handle): Declare.
11437 * target.c (target_thread_info_to_thread_handle): New function.
11438 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11439 * target-delegates.c: Regenerate.
11440
11441 * linux-thread-db.c (class thread_db_target): Add method
11442 thread_info_to_thread_handle.
11443 (thread_db_target::thread_info_to_thread_handle): Define.
11444 * remote.c (class remote_target): Add new method
11445 thread_info_to_thread_handle.
11446 (remote_target::thread_info_to_thread_handle): Define.
11447
56be6ea8
PA
114482019-04-08 Pedro Alves <palves@redhat.com>
11449
11450 * common/common-exceptions.c (throw_exception): Don't create
11451 named object to throw; throw directly.
11452 (throw_it): Likewise. Don't initialize gdb_exception::message
11453 here, with new; pass FMT and AP to the ctor instead.
11454 * common/common-exceptions.h: Include <string>.
11455 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11456 const char *, va_list)): New ctor. Use std::make_shared.
11457 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11458 errors)): Delete.
11459 (gdb_exception_error::gdb_exception_error(enum errors, const char
11460 *, va_list)): New.
11461 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11462 Add assertion.
11463 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11464 errors)): Delete.
11465 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11466 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11467 Add assertion.
11468
eedc3f4f
TT
114692019-04-08 Tom Tromey <tom@tromey.com>
11470
11471 * valops.c (value_rtti_indirect_type): Replace throw_exception
11472 with throw.
11473 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11474 with throw.
11475 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11476 throw.
11477 * target.c (target_translate_tls_address): Replace throw_exception
11478 with throw.
11479 * stack.c (frame_apply_command_count): Replace throw_exception
11480 with throw.
11481 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11482 throw.
11483 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11484 with throw.
11485 * rs6000-tdep.c (rs6000_frame_cache)
11486 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11487 * remote.c: Replace throw_exception with throw.
11488 * record-full.c (record_full_message, record_full_wait_1)
11489 (record_full_restore): Replace throw_exception with throw.
11490 * record-btrace.c:
11491 (get_thread_current_frame_id, record_btrace_start_replaying)
11492 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11493 (cmd_record_btrace_start): Replace throw_exception with throw.
11494 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11495 throw.
11496 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11497 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11498 * linespec.c:
11499 (find_linespec_symbols): Replace throw_exception with throw.
11500 * infrun.c (displaced_step_prepare, resume): Replace
11501 throw_exception with throw.
11502 * infcmd.c (post_create_inferior): Replace throw_exception with
11503 throw.
11504 * inf-loop.c (inferior_event_handler): Replace throw_exception
11505 with throw.
11506 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11507 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11508 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11509 (get_prev_frame_always, get_frame_pc_if_available)
11510 (get_frame_address_in_block_if_available, get_frame_language):
11511 Replace throw_exception with throw.
11512 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11513 throw_exception with throw.
11514 * eval.c (fetch_subexp_value, evaluate_var_value)
11515 (evaluate_funcall, evaluate_subexp_standard): Replace
11516 throw_exception with throw.
11517 * dwarf2loc.c (call_site_find_chain)
11518 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11519 Replace throw_exception with throw.
11520 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11521 with throw.
11522 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11523 throw.
11524 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11525 * completer.c (complete_line_internal): Replace throw_exception
11526 with throw.
11527 * compile/compile-object-run.c (compile_object_run): Replace
11528 throw_exception with throw.
11529 * cli/cli-script.c (process_next_line): Replace throw_exception
11530 with throw.
11531 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11532 (btrace_enable, btrace_maint_update_pt_packets): Replace
11533 throw_exception with throw.
11534 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11535 throw_exception with throw.
11536 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11537 throw_exception with throw.
11538 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11539 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11540 * aarch64-tdep.c (aarch64_make_prologue_cache)
11541 (aarch64_make_stub_cache): Replace throw_exception with throw.
11542
26003a20
TT
115432019-04-08 Tom Tromey <tom@tromey.com>
11544
11545 * common/common-exceptions.c (throw_exception): Rename from
11546 throw_exception_cxx. Remove old copy. Make argument const.
11547 (throw_it): Create and throw exception objects directly.
11548 * common/common-exceptions.h (throw_exception): Make argument
11549 const.
11550 (struct gdb_exception_error): Add constructor.
11551 (struct gdb_exception_quit): Add constructor.
11552
d272eb37
TT
115532019-04-08 Tom Tromey <tom@tromey.com>
11554
11555 * common/common-exceptions.h (exception_rethrow): Don't declare.
11556 (TRY_SJLJ): Update comment.
11557 (TRY, CATCH, END_CATCH): Remove.
11558 * common/common-exceptions.c (exception_rethrow): Remove.
11559
230d2906
TT
115602019-04-08 Tom Tromey <tom@tromey.com>
11561
11562 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11563 Remove.
11564 (gdb_exception_error): Rename from
11565 gdb_exception_RETURN_MASK_ERROR.
11566 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11567 (gdb_quit_bad_alloc): Update.
11568 * aarch64-tdep.c: Update.
11569 * ada-lang.c: Update.
11570 * ada-typeprint.c: Update.
11571 * ada-valprint.c: Update.
11572 * amd64-tdep.c: Update.
11573 * arch-utils.c: Update.
11574 * break-catch-throw.c: Update.
11575 * breakpoint.c: Update.
11576 * btrace.c: Update.
11577 * c-varobj.c: Update.
11578 * cli/cli-cmds.c: Update.
11579 * cli/cli-interp.c: Update.
11580 * cli/cli-script.c: Update.
11581 * common/common-exceptions.c: Update.
11582 * common/new-op.c: Update.
11583 * common/selftest.c: Update.
11584 * compile/compile-c-symbols.c: Update.
11585 * compile/compile-cplus-symbols.c: Update.
11586 * compile/compile-object-load.c: Update.
11587 * compile/compile-object-run.c: Update.
11588 * completer.c: Update.
11589 * corelow.c: Update.
11590 * cp-abi.c: Update.
11591 * cp-support.c: Update.
11592 * cp-valprint.c: Update.
11593 * darwin-nat.c: Update.
11594 * disasm-selftests.c: Update.
11595 * dtrace-probe.c: Update.
11596 * dwarf-index-cache.c: Update.
11597 * dwarf-index-write.c: Update.
11598 * dwarf2-frame-tailcall.c: Update.
11599 * dwarf2-frame.c: Update.
11600 * dwarf2loc.c: Update.
11601 * dwarf2read.c: Update.
11602 * eval.c: Update.
11603 * event-loop.c: Update.
11604 * event-top.c: Update.
11605 * exec.c: Update.
11606 * f-valprint.c: Update.
11607 * fbsd-tdep.c: Update.
11608 * frame-unwind.c: Update.
11609 * frame.c: Update.
11610 * gdbtypes.c: Update.
11611 * gnu-v3-abi.c: Update.
11612 * guile/guile-internal.h: Update.
11613 * guile/scm-block.c: Update.
11614 * guile/scm-breakpoint.c: Update.
11615 * guile/scm-cmd.c: Update.
11616 * guile/scm-disasm.c: Update.
11617 * guile/scm-frame.c: Update.
11618 * guile/scm-lazy-string.c: Update.
11619 * guile/scm-math.c: Update.
11620 * guile/scm-param.c: Update.
11621 * guile/scm-ports.c: Update.
11622 * guile/scm-pretty-print.c: Update.
11623 * guile/scm-symbol.c: Update.
11624 * guile/scm-symtab.c: Update.
11625 * guile/scm-type.c: Update.
11626 * guile/scm-value.c: Update.
11627 * i386-linux-tdep.c: Update.
11628 * i386-tdep.c: Update.
11629 * inf-loop.c: Update.
11630 * infcall.c: Update.
11631 * infcmd.c: Update.
11632 * infrun.c: Update.
11633 * jit.c: Update.
11634 * language.c: Update.
11635 * linespec.c: Update.
11636 * linux-fork.c: Update.
11637 * linux-nat.c: Update.
11638 * linux-tdep.c: Update.
11639 * linux-thread-db.c: Update.
11640 * main.c: Update.
11641 * mi/mi-cmd-break.c: Update.
11642 * mi/mi-cmd-stack.c: Update.
11643 * mi/mi-interp.c: Update.
11644 * mi/mi-main.c: Update.
11645 * objc-lang.c: Update.
11646 * p-valprint.c: Update.
11647 * parse.c: Update.
11648 * ppc-linux-tdep.c: Update.
11649 * printcmd.c: Update.
11650 * python/py-arch.c: Update.
11651 * python/py-breakpoint.c: Update.
11652 * python/py-cmd.c: Update.
11653 * python/py-finishbreakpoint.c: Update.
11654 * python/py-frame.c: Update.
11655 * python/py-framefilter.c: Update.
11656 * python/py-gdb-readline.c: Update.
11657 * python/py-inferior.c: Update.
11658 * python/py-infthread.c: Update.
11659 * python/py-lazy-string.c: Update.
11660 * python/py-linetable.c: Update.
11661 * python/py-objfile.c: Update.
11662 * python/py-param.c: Update.
11663 * python/py-prettyprint.c: Update.
11664 * python/py-progspace.c: Update.
11665 * python/py-record-btrace.c: Update.
11666 * python/py-record.c: Update.
11667 * python/py-symbol.c: Update.
11668 * python/py-type.c: Update.
11669 * python/py-unwind.c: Update.
11670 * python/py-utils.c: Update.
11671 * python/py-value.c: Update.
11672 * python/python.c: Update.
11673 * record-btrace.c: Update.
11674 * record-full.c: Update.
11675 * remote-fileio.c: Update.
11676 * remote.c: Update.
11677 * riscv-tdep.c: Update.
11678 * rs6000-aix-tdep.c: Update.
11679 * rs6000-tdep.c: Update.
11680 * rust-exp.y: Update.
11681 * rust-lang.c: Update.
11682 * s390-tdep.c: Update.
11683 * selftest-arch.c: Update.
11684 * solib-dsbt.c: Update.
11685 * solib-frv.c: Update.
11686 * solib-spu.c: Update.
11687 * solib-svr4.c: Update.
11688 * solib.c: Update.
11689 * sparc64-linux-tdep.c: Update.
11690 * stack.c: Update.
11691 * symfile-mem.c: Update.
11692 * symmisc.c: Update.
11693 * target.c: Update.
11694 * thread.c: Update.
11695 * top.c: Update.
11696 * tracefile-tfile.c: Update.
11697 * tui/tui.c: Update.
11698 * typeprint.c: Update.
11699 * unittests/cli-utils-selftests.c: Update.
11700 * unittests/parse-connection-spec-selftests.c: Update.
11701 * valops.c: Update.
11702 * valprint.c: Update.
11703 * value.c: Update.
11704 * varobj.c: Update.
11705 * windows-nat.c: Update.
11706 * x86-linux-nat.c: Update.
11707 * xml-support.c: Update.
11708
a70b8144
TT
117092019-04-08 Tom Tromey <tom@tromey.com>
11710
11711 * xml-support.c: Use C++ exception handling.
11712 * x86-linux-nat.c: Use C++ exception handling.
11713 * windows-nat.c: Use C++ exception handling.
11714 * varobj.c: Use C++ exception handling.
11715 * value.c: Use C++ exception handling.
11716 * valprint.c: Use C++ exception handling.
11717 * valops.c: Use C++ exception handling.
11718 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11719 handling.
11720 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11721 * typeprint.c: Use C++ exception handling.
11722 * tui/tui.c: Use C++ exception handling.
11723 * tracefile-tfile.c: Use C++ exception handling.
11724 * top.c: Use C++ exception handling.
11725 * thread.c: Use C++ exception handling.
11726 * target.c: Use C++ exception handling.
11727 * symmisc.c: Use C++ exception handling.
11728 * symfile-mem.c: Use C++ exception handling.
11729 * stack.c: Use C++ exception handling.
11730 * sparc64-linux-tdep.c: Use C++ exception handling.
11731 * solib.c: Use C++ exception handling.
11732 * solib-svr4.c: Use C++ exception handling.
11733 * solib-spu.c: Use C++ exception handling.
11734 * solib-frv.c: Use C++ exception handling.
11735 * solib-dsbt.c: Use C++ exception handling.
11736 * selftest-arch.c: Use C++ exception handling.
11737 * s390-tdep.c: Use C++ exception handling.
11738 * rust-lang.c: Use C++ exception handling.
11739 * rust-exp.y: Use C++ exception handling.
11740 * rs6000-tdep.c: Use C++ exception handling.
11741 * rs6000-aix-tdep.c: Use C++ exception handling.
11742 * riscv-tdep.c: Use C++ exception handling.
11743 * remote.c: Use C++ exception handling.
11744 * remote-fileio.c: Use C++ exception handling.
11745 * record-full.c: Use C++ exception handling.
11746 * record-btrace.c: Use C++ exception handling.
11747 * python/python.c: Use C++ exception handling.
11748 * python/py-value.c: Use C++ exception handling.
11749 * python/py-utils.c: Use C++ exception handling.
11750 * python/py-unwind.c: Use C++ exception handling.
11751 * python/py-type.c: Use C++ exception handling.
11752 * python/py-symbol.c: Use C++ exception handling.
11753 * python/py-record.c: Use C++ exception handling.
11754 * python/py-record-btrace.c: Use C++ exception handling.
11755 * python/py-progspace.c: Use C++ exception handling.
11756 * python/py-prettyprint.c: Use C++ exception handling.
11757 * python/py-param.c: Use C++ exception handling.
11758 * python/py-objfile.c: Use C++ exception handling.
11759 * python/py-linetable.c: Use C++ exception handling.
11760 * python/py-lazy-string.c: Use C++ exception handling.
11761 * python/py-infthread.c: Use C++ exception handling.
11762 * python/py-inferior.c: Use C++ exception handling.
11763 * python/py-gdb-readline.c: Use C++ exception handling.
11764 * python/py-framefilter.c: Use C++ exception handling.
11765 * python/py-frame.c: Use C++ exception handling.
11766 * python/py-finishbreakpoint.c: Use C++ exception handling.
11767 * python/py-cmd.c: Use C++ exception handling.
11768 * python/py-breakpoint.c: Use C++ exception handling.
11769 * python/py-arch.c: Use C++ exception handling.
11770 * printcmd.c: Use C++ exception handling.
11771 * ppc-linux-tdep.c: Use C++ exception handling.
11772 * parse.c: Use C++ exception handling.
11773 * p-valprint.c: Use C++ exception handling.
11774 * objc-lang.c: Use C++ exception handling.
11775 * mi/mi-main.c: Use C++ exception handling.
11776 * mi/mi-interp.c: Use C++ exception handling.
11777 * mi/mi-cmd-stack.c: Use C++ exception handling.
11778 * mi/mi-cmd-break.c: Use C++ exception handling.
11779 * main.c: Use C++ exception handling.
11780 * linux-thread-db.c: Use C++ exception handling.
11781 * linux-tdep.c: Use C++ exception handling.
11782 * linux-nat.c: Use C++ exception handling.
11783 * linux-fork.c: Use C++ exception handling.
11784 * linespec.c: Use C++ exception handling.
11785 * language.c: Use C++ exception handling.
11786 * jit.c: Use C++ exception handling.
11787 * infrun.c: Use C++ exception handling.
11788 * infcmd.c: Use C++ exception handling.
11789 * infcall.c: Use C++ exception handling.
11790 * inf-loop.c: Use C++ exception handling.
11791 * i386-tdep.c: Use C++ exception handling.
11792 * i386-linux-tdep.c: Use C++ exception handling.
11793 * guile/scm-value.c: Use C++ exception handling.
11794 * guile/scm-type.c: Use C++ exception handling.
11795 * guile/scm-symtab.c: Use C++ exception handling.
11796 * guile/scm-symbol.c: Use C++ exception handling.
11797 * guile/scm-pretty-print.c: Use C++ exception handling.
11798 * guile/scm-ports.c: Use C++ exception handling.
11799 * guile/scm-param.c: Use C++ exception handling.
11800 * guile/scm-math.c: Use C++ exception handling.
11801 * guile/scm-lazy-string.c: Use C++ exception handling.
11802 * guile/scm-frame.c: Use C++ exception handling.
11803 * guile/scm-disasm.c: Use C++ exception handling.
11804 * guile/scm-cmd.c: Use C++ exception handling.
11805 * guile/scm-breakpoint.c: Use C++ exception handling.
11806 * guile/scm-block.c: Use C++ exception handling.
11807 * guile/guile-internal.h: Use C++ exception handling.
11808 * gnu-v3-abi.c: Use C++ exception handling.
11809 * gdbtypes.c: Use C++ exception handling.
11810 * frame.c: Use C++ exception handling.
11811 * frame-unwind.c: Use C++ exception handling.
11812 * fbsd-tdep.c: Use C++ exception handling.
11813 * f-valprint.c: Use C++ exception handling.
11814 * exec.c: Use C++ exception handling.
11815 * event-top.c: Use C++ exception handling.
11816 * event-loop.c: Use C++ exception handling.
11817 * eval.c: Use C++ exception handling.
11818 * dwarf2read.c: Use C++ exception handling.
11819 * dwarf2loc.c: Use C++ exception handling.
11820 * dwarf2-frame.c: Use C++ exception handling.
11821 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11822 * dwarf-index-write.c: Use C++ exception handling.
11823 * dwarf-index-cache.c: Use C++ exception handling.
11824 * dtrace-probe.c: Use C++ exception handling.
11825 * disasm-selftests.c: Use C++ exception handling.
11826 * darwin-nat.c: Use C++ exception handling.
11827 * cp-valprint.c: Use C++ exception handling.
11828 * cp-support.c: Use C++ exception handling.
11829 * cp-abi.c: Use C++ exception handling.
11830 * corelow.c: Use C++ exception handling.
11831 * completer.c: Use C++ exception handling.
11832 * compile/compile-object-run.c: Use C++ exception handling.
11833 * compile/compile-object-load.c: Use C++ exception handling.
11834 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11835 * compile/compile-c-symbols.c: Use C++ exception handling.
11836 * common/selftest.c: Use C++ exception handling.
11837 * common/new-op.c: Use C++ exception handling.
11838 * cli/cli-script.c: Use C++ exception handling.
11839 * cli/cli-interp.c: Use C++ exception handling.
11840 * cli/cli-cmds.c: Use C++ exception handling.
11841 * c-varobj.c: Use C++ exception handling.
11842 * btrace.c: Use C++ exception handling.
11843 * breakpoint.c: Use C++ exception handling.
11844 * break-catch-throw.c: Use C++ exception handling.
11845 * arch-utils.c: Use C++ exception handling.
11846 * amd64-tdep.c: Use C++ exception handling.
11847 * ada-valprint.c: Use C++ exception handling.
11848 * ada-typeprint.c: Use C++ exception handling.
11849 * ada-lang.c: Use C++ exception handling.
11850 * aarch64-tdep.c: Use C++ exception handling.
11851
3d6e9d23
TT
118522019-04-08 Tom Tromey <tom@tromey.com>
11853
11854 * xml-support.c (gdb_xml_parser::parse): Update.
11855 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11856 * value.c (show_convenience): Update.
11857 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11858 (test_parse_flags_qcs): Update.
11859 * thread.c (thr_try_catch_cmd): Update.
11860 * target.c (target_translate_tls_address): Update.
11861 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11862 (info_frame_command_core, frame_apply_command_count): Update.
11863 * rust-exp.y (rust_lex_exception_test): Update.
11864 * riscv-tdep.c (riscv_print_one_register_info): Update.
11865 * remote.c (remote_target::enable_btrace): Update.
11866 * record-btrace.c (record_btrace_enable_warn): Update.
11867 * python/py-utils.c (gdbpy_convert_exception): Update.
11868 * printcmd.c (do_one_display, print_variable_and_value): Update.
11869 * mi/mi-main.c (mi_print_exception): Update.
11870 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11871 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11872 * linux-nat.c (linux_nat_target::attach): Update.
11873 * linux-fork.c (class scoped_switch_fork_info): Update.
11874 * infrun.c (displaced_step_prepare): Update.
11875 * infcall.c (call_function_by_hand_dummy): Update.
11876 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11877 * gnu-v3-abi.c (print_one_vtable): Update.
11878 * frame.c (get_prev_frame_always): Update.
11879 * f-valprint.c (info_common_command_for_block): Update.
11880 * exec.c (try_open_exec_file): Update.
11881 * exceptions.c (print_exception, exception_print)
11882 (exception_fprintf, exception_print_same): Update.
11883 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11884 * dwarf-index-cache.c (index_cache::store)
11885 (index_cache::lookup_gdb_index): Update.
11886 * darwin-nat.c (maybe_cache_shell): Update.
11887 * cp-valprint.c (cp_print_value_fields): Update.
11888 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11889 (gcc_cplus_symbol_address): Update.
11890 * compile/compile-c-symbols.c (gcc_convert_symbol)
11891 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11892 * common/selftest.c: Update.
11893 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11894 a std::string.
11895 (exception_try_scope_entry, exception_try_scope_exit): Don't
11896 declare.
11897 (struct exception_try_scope): Remove.
11898 (TRY): Don't use exception_try_scope.
11899 (struct gdb_exception): Add constructor, operator=.
11900 <what>: New method.
11901 (struct gdb_exception_RETURN_MASK_ALL)
11902 (struct gdb_exception_RETURN_MASK_ERROR)
11903 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11904 (struct gdb_quit_bad_alloc): Update.
11905 * common/common-exceptions.c (exception_none): Change
11906 initializer.
11907 (struct catcher) <state, exception>: Initialize inline.
11908 <prev>: Remove member.
11909 (current_catcher): Remove.
11910 (catchers): New global.
11911 (exceptions_state_mc_init): Simplify.
11912 (catcher_pop): Remove.
11913 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11914 (try_scope_depth, exception_try_scope_entry)
11915 (exception_try_scope_exit): Remove.
11916 (throw_exception_sjlj): Update.
11917 (exception_messages, exception_messages_size): Remove.
11918 (throw_it): Simplify.
11919 (gdb_exception_sliced_copy): Remove.
11920 (throw_exception_cxx): Update.
11921 * cli/cli-script.c (script_from_file): Update.
11922 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11923 Update.
11924 * ada-valprint.c (ada_val_print): Update.
11925 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11926 (create_excep_cond_exprs): Update.
11927
c5c10118
TT
119282019-04-08 Tom Tromey <tom@tromey.com>
11929
11930 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11931 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11932 (TRY, CATCH, END_CATCH): Remove some definitions.
11933 * common/common-exceptions.c: Don't use GDB_XCPT.
11934 (catcher_list_size): Remove.
11935 (throw_exception, throw_it): Simplify.
11936
4de283e4
TT
119372019-04-05 Tom Tromey <tom@tromey.com>
11938
11939 Revert the header-sorting patch.
11940 * ft32-tdep.c: Revert.
11941 * frv-tdep.c: Revert.
11942 * frv-linux-tdep.c: Revert.
11943 * frame.c: Revert.
11944 * frame-unwind.c: Revert.
11945 * frame-base.c: Revert.
11946 * fork-child.c: Revert.
11947 * findvar.c: Revert.
11948 * findcmd.c: Revert.
11949 * filesystem.c: Revert.
11950 * filename-seen-cache.h: Revert.
11951 * filename-seen-cache.c: Revert.
11952 * fbsd-tdep.c: Revert.
11953 * fbsd-nat.h: Revert.
11954 * fbsd-nat.c: Revert.
11955 * f-valprint.c: Revert.
11956 * f-typeprint.c: Revert.
11957 * f-lang.c: Revert.
11958 * extension.h: Revert.
11959 * extension.c: Revert.
11960 * extension-priv.h: Revert.
11961 * expprint.c: Revert.
11962 * exec.h: Revert.
11963 * exec.c: Revert.
11964 * exceptions.c: Revert.
11965 * event-top.c: Revert.
11966 * event-loop.c: Revert.
11967 * eval.c: Revert.
11968 * elfread.c: Revert.
11969 * dwarf2read.h: Revert.
11970 * dwarf2read.c: Revert.
11971 * dwarf2loc.c: Revert.
11972 * dwarf2expr.h: Revert.
11973 * dwarf2expr.c: Revert.
11974 * dwarf2-frame.c: Revert.
11975 * dwarf2-frame-tailcall.c: Revert.
11976 * dwarf-index-write.h: Revert.
11977 * dwarf-index-write.c: Revert.
11978 * dwarf-index-common.c: Revert.
11979 * dwarf-index-cache.h: Revert.
11980 * dwarf-index-cache.c: Revert.
11981 * dummy-frame.c: Revert.
11982 * dtrace-probe.c: Revert.
11983 * disasm.h: Revert.
11984 * disasm.c: Revert.
11985 * disasm-selftests.c: Revert.
11986 * dictionary.c: Revert.
11987 * dicos-tdep.c: Revert.
11988 * demangle.c: Revert.
11989 * dcache.h: Revert.
11990 * dcache.c: Revert.
11991 * darwin-nat.h: Revert.
11992 * darwin-nat.c: Revert.
11993 * darwin-nat-info.c: Revert.
11994 * d-valprint.c: Revert.
11995 * d-namespace.c: Revert.
11996 * d-lang.c: Revert.
11997 * ctf.c: Revert.
11998 * csky-tdep.c: Revert.
11999 * csky-linux-tdep.c: Revert.
12000 * cris-tdep.c: Revert.
12001 * cris-linux-tdep.c: Revert.
12002 * cp-valprint.c: Revert.
12003 * cp-support.c: Revert.
12004 * cp-namespace.c: Revert.
12005 * cp-abi.c: Revert.
12006 * corelow.c: Revert.
12007 * corefile.c: Revert.
12008 * continuations.c: Revert.
12009 * completer.h: Revert.
12010 * completer.c: Revert.
12011 * complaints.c: Revert.
12012 * coffread.c: Revert.
12013 * coff-pe-read.c: Revert.
12014 * cli-out.h: Revert.
12015 * cli-out.c: Revert.
12016 * charset.c: Revert.
12017 * c-varobj.c: Revert.
12018 * c-valprint.c: Revert.
12019 * c-typeprint.c: Revert.
12020 * c-lang.c: Revert.
12021 * buildsym.c: Revert.
12022 * buildsym-legacy.c: Revert.
12023 * build-id.h: Revert.
12024 * build-id.c: Revert.
12025 * btrace.c: Revert.
12026 * bsd-uthread.c: Revert.
12027 * breakpoint.h: Revert.
12028 * breakpoint.c: Revert.
12029 * break-catch-throw.c: Revert.
12030 * break-catch-syscall.c: Revert.
12031 * break-catch-sig.c: Revert.
12032 * blockframe.c: Revert.
12033 * block.c: Revert.
12034 * bfin-tdep.c: Revert.
12035 * bfin-linux-tdep.c: Revert.
12036 * bfd-target.c: Revert.
12037 * bcache.c: Revert.
12038 * ax-general.c: Revert.
12039 * ax-gdb.h: Revert.
12040 * ax-gdb.c: Revert.
12041 * avr-tdep.c: Revert.
12042 * auxv.c: Revert.
12043 * auto-load.c: Revert.
12044 * arm-wince-tdep.c: Revert.
12045 * arm-tdep.c: Revert.
12046 * arm-symbian-tdep.c: Revert.
12047 * arm-pikeos-tdep.c: Revert.
12048 * arm-obsd-tdep.c: Revert.
12049 * arm-nbsd-tdep.c: Revert.
12050 * arm-nbsd-nat.c: Revert.
12051 * arm-linux-tdep.c: Revert.
12052 * arm-linux-nat.c: Revert.
12053 * arm-fbsd-tdep.c: Revert.
12054 * arm-fbsd-nat.c: Revert.
12055 * arm-bsd-tdep.c: Revert.
12056 * arch-utils.c: Revert.
12057 * arc-tdep.c: Revert.
12058 * arc-newlib-tdep.c: Revert.
12059 * annotate.h: Revert.
12060 * annotate.c: Revert.
12061 * amd64-windows-tdep.c: Revert.
12062 * amd64-windows-nat.c: Revert.
12063 * amd64-tdep.c: Revert.
12064 * amd64-sol2-tdep.c: Revert.
12065 * amd64-obsd-tdep.c: Revert.
12066 * amd64-obsd-nat.c: Revert.
12067 * amd64-nbsd-tdep.c: Revert.
12068 * amd64-nbsd-nat.c: Revert.
12069 * amd64-nat.c: Revert.
12070 * amd64-linux-tdep.c: Revert.
12071 * amd64-linux-nat.c: Revert.
12072 * amd64-fbsd-tdep.c: Revert.
12073 * amd64-fbsd-nat.c: Revert.
12074 * amd64-dicos-tdep.c: Revert.
12075 * amd64-darwin-tdep.c: Revert.
12076 * amd64-bsd-nat.c: Revert.
12077 * alpha-tdep.c: Revert.
12078 * alpha-obsd-tdep.c: Revert.
12079 * alpha-nbsd-tdep.c: Revert.
12080 * alpha-mdebug-tdep.c: Revert.
12081 * alpha-linux-tdep.c: Revert.
12082 * alpha-linux-nat.c: Revert.
12083 * alpha-bsd-tdep.c: Revert.
12084 * alpha-bsd-nat.c: Revert.
12085 * aix-thread.c: Revert.
12086 * agent.c: Revert.
12087 * addrmap.c: Revert.
12088 * ada-varobj.c: Revert.
12089 * ada-valprint.c: Revert.
12090 * ada-typeprint.c: Revert.
12091 * ada-tasks.c: Revert.
12092 * ada-lang.c: Revert.
12093 * aarch64-tdep.c: Revert.
12094 * aarch64-ravenscar-thread.c: Revert.
12095 * aarch64-newlib-tdep.c: Revert.
12096 * aarch64-linux-tdep.c: Revert.
12097 * aarch64-linux-nat.c: Revert.
12098 * aarch64-fbsd-tdep.c: Revert.
12099 * aarch64-fbsd-nat.c: Revert.
12100 * aarch32-linux-nat.c: Revert.
12101
d55e5aa6
TT
121022019-04-05 Tom Tromey <tom@tromey.com>
12103
12104 * ft32-tdep.c: Sort headers.
12105 * frv-tdep.c: Sort headers.
12106 * frv-linux-tdep.c: Sort headers.
12107 * frame.c: Sort headers.
12108 * frame-unwind.c: Sort headers.
12109 * frame-base.c: Sort headers.
12110 * fork-child.c: Sort headers.
12111 * findvar.c: Sort headers.
12112 * findcmd.c: Sort headers.
12113 * filesystem.c: Sort headers.
12114 * filename-seen-cache.h: Sort headers.
12115 * filename-seen-cache.c: Sort headers.
12116 * fbsd-tdep.c: Sort headers.
12117 * fbsd-nat.h: Sort headers.
12118 * fbsd-nat.c: Sort headers.
12119 * f-valprint.c: Sort headers.
12120 * f-typeprint.c: Sort headers.
12121 * f-lang.c: Sort headers.
12122 * extension.h: Sort headers.
12123 * extension.c: Sort headers.
12124 * extension-priv.h: Sort headers.
12125 * expprint.c: Sort headers.
12126 * exec.h: Sort headers.
12127 * exec.c: Sort headers.
12128 * exceptions.c: Sort headers.
12129 * event-top.c: Sort headers.
12130 * event-loop.c: Sort headers.
12131 * eval.c: Sort headers.
12132 * elfread.c: Sort headers.
12133 * dwarf2read.h: Sort headers.
12134 * dwarf2read.c: Sort headers.
12135 * dwarf2loc.c: Sort headers.
12136 * dwarf2expr.h: Sort headers.
12137 * dwarf2expr.c: Sort headers.
12138 * dwarf2-frame.c: Sort headers.
12139 * dwarf2-frame-tailcall.c: Sort headers.
12140 * dwarf-index-write.h: Sort headers.
12141 * dwarf-index-write.c: Sort headers.
12142 * dwarf-index-common.c: Sort headers.
12143 * dwarf-index-cache.h: Sort headers.
12144 * dwarf-index-cache.c: Sort headers.
12145 * dummy-frame.c: Sort headers.
12146 * dtrace-probe.c: Sort headers.
12147 * disasm.h: Sort headers.
12148 * disasm.c: Sort headers.
12149 * disasm-selftests.c: Sort headers.
12150 * dictionary.c: Sort headers.
12151 * dicos-tdep.c: Sort headers.
12152 * demangle.c: Sort headers.
12153 * dcache.h: Sort headers.
12154 * dcache.c: Sort headers.
12155 * darwin-nat.h: Sort headers.
12156 * darwin-nat.c: Sort headers.
12157 * darwin-nat-info.c: Sort headers.
12158 * d-valprint.c: Sort headers.
12159 * d-namespace.c: Sort headers.
12160 * d-lang.c: Sort headers.
12161 * ctf.c: Sort headers.
12162 * csky-tdep.c: Sort headers.
12163 * csky-linux-tdep.c: Sort headers.
12164 * cris-tdep.c: Sort headers.
12165 * cris-linux-tdep.c: Sort headers.
12166 * cp-valprint.c: Sort headers.
12167 * cp-support.c: Sort headers.
12168 * cp-namespace.c: Sort headers.
12169 * cp-abi.c: Sort headers.
12170 * corelow.c: Sort headers.
12171 * corefile.c: Sort headers.
12172 * continuations.c: Sort headers.
12173 * completer.h: Sort headers.
12174 * completer.c: Sort headers.
12175 * complaints.c: Sort headers.
12176 * coffread.c: Sort headers.
12177 * coff-pe-read.c: Sort headers.
12178 * cli-out.h: Sort headers.
12179 * cli-out.c: Sort headers.
12180 * charset.c: Sort headers.
12181 * c-varobj.c: Sort headers.
12182 * c-valprint.c: Sort headers.
12183 * c-typeprint.c: Sort headers.
12184 * c-lang.c: Sort headers.
12185 * buildsym.c: Sort headers.
12186 * buildsym-legacy.c: Sort headers.
12187 * build-id.h: Sort headers.
12188 * build-id.c: Sort headers.
12189 * btrace.c: Sort headers.
12190 * bsd-uthread.c: Sort headers.
12191 * breakpoint.h: Sort headers.
12192 * breakpoint.c: Sort headers.
12193 * break-catch-throw.c: Sort headers.
12194 * break-catch-syscall.c: Sort headers.
12195 * break-catch-sig.c: Sort headers.
12196 * blockframe.c: Sort headers.
12197 * block.c: Sort headers.
12198 * bfin-tdep.c: Sort headers.
12199 * bfin-linux-tdep.c: Sort headers.
12200 * bfd-target.c: Sort headers.
12201 * bcache.c: Sort headers.
12202 * ax-general.c: Sort headers.
12203 * ax-gdb.h: Sort headers.
12204 * ax-gdb.c: Sort headers.
12205 * avr-tdep.c: Sort headers.
12206 * auxv.c: Sort headers.
12207 * auto-load.c: Sort headers.
12208 * arm-wince-tdep.c: Sort headers.
12209 * arm-tdep.c: Sort headers.
12210 * arm-symbian-tdep.c: Sort headers.
12211 * arm-pikeos-tdep.c: Sort headers.
12212 * arm-obsd-tdep.c: Sort headers.
12213 * arm-nbsd-tdep.c: Sort headers.
12214 * arm-nbsd-nat.c: Sort headers.
12215 * arm-linux-tdep.c: Sort headers.
12216 * arm-linux-nat.c: Sort headers.
12217 * arm-fbsd-tdep.c: Sort headers.
12218 * arm-fbsd-nat.c: Sort headers.
12219 * arm-bsd-tdep.c: Sort headers.
12220 * arch-utils.c: Sort headers.
12221 * arc-tdep.c: Sort headers.
12222 * arc-newlib-tdep.c: Sort headers.
12223 * annotate.h: Sort headers.
12224 * annotate.c: Sort headers.
12225 * amd64-windows-tdep.c: Sort headers.
12226 * amd64-windows-nat.c: Sort headers.
12227 * amd64-tdep.c: Sort headers.
12228 * amd64-sol2-tdep.c: Sort headers.
12229 * amd64-obsd-tdep.c: Sort headers.
12230 * amd64-obsd-nat.c: Sort headers.
12231 * amd64-nbsd-tdep.c: Sort headers.
12232 * amd64-nbsd-nat.c: Sort headers.
12233 * amd64-nat.c: Sort headers.
12234 * amd64-linux-tdep.c: Sort headers.
12235 * amd64-linux-nat.c: Sort headers.
12236 * amd64-fbsd-tdep.c: Sort headers.
12237 * amd64-fbsd-nat.c: Sort headers.
12238 * amd64-dicos-tdep.c: Sort headers.
12239 * amd64-darwin-tdep.c: Sort headers.
12240 * amd64-bsd-nat.c: Sort headers.
12241 * alpha-tdep.c: Sort headers.
12242 * alpha-obsd-tdep.c: Sort headers.
12243 * alpha-nbsd-tdep.c: Sort headers.
12244 * alpha-mdebug-tdep.c: Sort headers.
12245 * alpha-linux-tdep.c: Sort headers.
12246 * alpha-linux-nat.c: Sort headers.
12247 * alpha-bsd-tdep.c: Sort headers.
12248 * alpha-bsd-nat.c: Sort headers.
12249 * aix-thread.c: Sort headers.
12250 * agent.c: Sort headers.
12251 * addrmap.c: Sort headers.
12252 * ada-varobj.c: Sort headers.
12253 * ada-valprint.c: Sort headers.
12254 * ada-typeprint.c: Sort headers.
12255 * ada-tasks.c: Sort headers.
12256 * ada-lang.c: Sort headers.
12257 * aarch64-tdep.c: Sort headers.
12258 * aarch64-ravenscar-thread.c: Sort headers.
12259 * aarch64-newlib-tdep.c: Sort headers.
12260 * aarch64-linux-tdep.c: Sort headers.
12261 * aarch64-linux-nat.c: Sort headers.
12262 * aarch64-fbsd-tdep.c: Sort headers.
12263 * aarch64-fbsd-nat.c: Sort headers.
12264 * aarch32-linux-nat.c: Sort headers.
12265
699bd4cf
TT
122662019-04-04 Tom Tromey <tom@tromey.com>
12267
12268 * varobj.c (varobj_create): Update.
12269 * rust-exp.y (struct rust_parser) <update_innermost_block,
12270 lookup_symbol>: New methods.
12271 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12272 Rename.
12273 (rust_parser::rust_lookup_type)
12274 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12275 * printcmd.c (display_command, do_one_display): Update.
12276 * parser-defs.h (struct parser_state) <parser_state>: Add
12277 "tracker" parameter.
12278 (block_tracker): New member.
12279 (class innermost_block_tracker) <innermost_block_tracker>: Add
12280 "types" parameter.
12281 <reset>: Remove method.
12282 (innermost_block): Don't declare.
12283 (null_post_parser): Update.
12284 * parse.c (innermost_block): Remove global.
12285 (write_dollar_variable): Update.
12286 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12287 Remove "tracker_types" parameter.
12288 (parse_expression): Add "tracker" parameter.
12289 (parse_expression_for_completion): Update.
12290 (null_post_parser): Add "tracker" parameter.
12291 * p-exp.y: Update rules.
12292 * m2-exp.y: Update rules.
12293 * language.h (struct language_defn) <la_post_parser>: Add
12294 "tracker" parameter.
12295 * go-exp.y: Update rules.
12296 * f-exp.y: Update rules.
12297 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12298 parameter.
12299 * d-exp.y: Update rules.
12300 * c-exp.y: Update rules.
12301 * breakpoint.c (set_breakpoint_condition): Create an
12302 innermost_block_tracker.
12303 (watch_command_1): Likewise.
12304 * ada-lang.c (resolve): Add "tracker" parameter.
12305 (resolve_subexp): Likewise.
12306 * ada-exp.y (write_var_from_sym): Update.
12307
dac43e32
TT
123082019-04-04 Tom Tromey <tom@tromey.com>
12309
12310 * type-stack.h: New file.
12311 * type-stack.c: New file.
12312 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12313 type-stack.h.
12314 (insert_into_type_stack, insert_type, push_type, push_type_int)
12315 (insert_type_address_space, pop_type, pop_type_int)
12316 (pop_typelist, pop_type_stack, append_type_stack)
12317 (push_type_stack, get_type_stack, push_typelist)
12318 (follow_type_instance_flags, follow_types): Don't declare.
12319 * parse.c (type_stack): Remove global.
12320 (parse_exp_in_context): Update.
12321 (insert_into_type_stack, insert_type, push_type, push_type_int)
12322 (insert_type_address_space, pop_type, pop_type_int)
12323 (pop_typelist, pop_type_stack, append_type_stack)
12324 (push_type_stack, get_type_stack, push_typelist)
12325 (follow_type_instance_flags, follow_types): Remove (moved to
12326 type-stack.c).
12327 * f-exp.y (type_stack): New global.
12328 Update rules.
12329 (push_kind_type, f_parse): Update.
12330 * d-exp.y (type_stack): New global.
12331 Update rules.
12332 (d_parse): Update.
12333 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12334 Update rules.
12335 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12336 (HFILES_NO_SRCDIR): Add type-stack.h.
12337
2a612529
TT
123382019-04-04 Tom Tromey <tom@tromey.com>
12339
12340 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12341 (rust_parser::convert_ast_to_expression, rust_parse)
12342 (rust_lex_test_completion, rust_lex_tests): Update.
12343 * parser-defs.h (struct expr_completion_state): New.
12344 (struct parser_state) <parser_state>: Add completion parameter.
12345 <mark_struct_expression, mark_completion_tag>: New methods.
12346 <parse_completion, m_completion_state>: New members.
12347 (prefixify_expression, null_post_parser): Update.
12348 (mark_struct_expression, mark_completion_tag): Don't declare.
12349 * parse.c (parse_completion, expout_last_struct)
12350 (expout_tag_completion_type, expout_completion_name): Remove
12351 globals.
12352 (parser_state::mark_struct_expression)
12353 (parser_state::mark_completion_tag): Now methods.
12354 (prefixify_expression): Add last_struct parameter.
12355 (prefixify_subexp): Likewise.
12356 (parse_exp_1): Update.
12357 (parse_exp_in_context): Add cstate parameter. Update.
12358 (parse_expression_for_completion): Create an
12359 expr_completion_state.
12360 (null_post_parser): Add "completion" parameter.
12361 * p-exp.y: Update rules.
12362 (yylex): Update.
12363 * language.h (struct language_defn) <la_post_parser>: Add
12364 "completing" parameter.
12365 * go-exp.y: Update rules.
12366 (lex_one_token): Update.
12367 * expression.h (parse_completion): Don't declare.
12368 * d-exp.y: Update rules.
12369 (lex_one_token): Update rules.
12370 * c-exp.y: Update rules.
12371 (lex_one_token): Update.
12372 * ada-lang.c (resolve): Add "parse_completion" parameter.
12373 (resolve_subexp): Likewise.
12374 (ada_resolve_function): Likewise.
12375
43476f0b
TT
123762019-04-04 Tom Tromey <tom@tromey.com>
12377
12378 * parser-defs.h (struct parser_state) <start_arglist,
12379 end_arglist>: New methods.
12380 <arglist_len, m_funcall_chain>: New members.
12381 (arglist_len, start_arglist, end_arglist): Don't declare.
12382 * parse.c (arglist_len, funcall_chain): Remove global.
12383 (start_arglist, end_arglist): Remove functions.
12384 (parse_exp_in_context): Update.
12385 * p-exp.y: Update rules.
12386 * m2-exp.y: Update rules.
12387 * go-exp.y: Update rules.
12388 * f-exp.y: Update rules.
12389 * d-exp.y: Update rules.
12390 * c-exp.y: Update rules.
12391
5776fca3
TT
123922019-04-04 Tom Tromey <tom@tromey.com>
12393
12394 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12395 lex_operator, push_back>: New methods.
12396 Update all rules.
12397 (rust_parser::lex_hex, lex_escape): Rename and update.
12398 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12399 (rust_parser::lex_operator): Rename and update.
12400 (rust_parser::lex_number, rustyylex, rustyyerror)
12401 (rust_lex_test_init, rust_lex_test_sequence)
12402 (rust_lex_test_push_back, rust_lex_tests): Update.
12403 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12404 parameter.
12405 <lexptr, prev_lexptr>: New members.
12406 (lexptr, prev_lexptr): Don't declare.
12407 * parse.c (lexptr, prev_lexptr): Remove globals.
12408 (parse_exp_in_context): Update.
12409 * p-exp.y (yylex, yyerror): Update.
12410 * m2-exp.y (parse_number, yylex, yyerror): Update.
12411 * go-exp.y (lex_one_token, yyerror): Update.
12412 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12413 * d-exp.y (lex_one_token, yyerror): Update.
12414 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12415 (lex_one_token, yyerror): Update.
12416 * ada-lex.l (YY_INPUT): Update.
12417 (rewind_to_char): Update.
12418 * ada-exp.y (yyerror): Update.
12419
8621b685
TT
124202019-04-04 Tom Tromey <tom@tromey.com>
12421
12422 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12423 * parser-defs.h (struct parser_state) <parser_state>: Add new
12424 parameter.
12425 <comma_terminates>: New member.
12426 (comma_terminates): Don't declare global.
12427 * parse.c (comma_terminates): Remove global.
12428 (parse_exp_in_context): Update.
12429 * p-exp.y (yylex): Update.
12430 * m2-exp.y (yylex): Update.
12431 * go-exp.y (lex_one_token): Update.
12432 * f-exp.y (yylex): Update.
12433 * d-exp.y (lex_one_token): Update.
12434 * c-exp.y (lex_one_token): Update.
12435 * ada-lex.l: Update.
12436
28aaf3fd
TT
124372019-04-04 Tom Tromey <tom@tromey.com>
12438
12439 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12440 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12441 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12442 * parser-defs.h (paren_depth): Don't declare.
12443 * parse.c (paren_depth): Remove global.
12444 (parse_exp_in_context): Update.
12445 * p-exp.y (paren_depth): New global.
12446 (pascal_parse): Initialize it.
12447 * m2-exp.y (paren_depth): New global.
12448 (m2_parse): Initialize it.
12449 * go-exp.y (paren_depth): New global.
12450 (go_parse): Initialize it.
12451 * f-exp.y (paren_depth): New global.
12452 (f_parse): Initialize it.
12453 * d-exp.y (paren_depth): New global.
12454 (d_parse): Initialize it.
12455 * c-exp.y (paren_depth): New global.
12456 (c_parse): Initialize it.
12457 * ada-lex.l (paren_depth): New global.
12458 (lexer_init): Initialize it.
12459
1e58a4a4
TT
124602019-04-04 Tom Tromey <tom@tromey.com>
12461
12462 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12463 (rust_parser::convert_ast_to_type)
12464 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12465 * parser-defs.h (struct parser_state) <parser_state>: Add
12466 parameters. Initialize new members.
12467 <expression_context_block, expression_context_pc>: New members.
12468 * parse.c (expression_context_block, expression_context_pc):
12469 Remove globals.
12470 (parse_exp_in_context): Update.
12471 * p-exp.y: Update all rules.
12472 (yylex): Update.
12473 * m2-exp.y: Update all rules.
12474 (yylex): Update.
12475 * go-exp.y (yylex): Update.
12476 * f-exp.y (yylex): Update.
12477 * d-exp.y: Update all rules.
12478 (yylex): Update.
12479 * c-exp.y: Update all rules.
12480 (lex_one_token, classify_name, yylex, c_parse): Update.
12481 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12482
37eedb39
TT
124832019-04-04 Tom Tromey <tom@tromey.com>
12484
12485 * gdbarch.h, gdbarch.c: Rebuild.
12486 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12487 * stap-probe.h:
12488 (struct stap_parse_info): Replace "parser_state" with
12489 "expr_builder".
12490 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12491 (parser_state): New class.
12492 * parse.c (expr_builder): Rename.
12493 (expr_builder::release): Rename.
12494 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12495 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12496 (write_exp_elt_longcst, write_exp_elt_floatcst)
12497 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12498 (write_exp_string_vector, write_exp_bitstring)
12499 (write_exp_msymbol, mark_struct_expression)
12500 (write_dollar_variable)
12501 (insert_type_address_space, increase_expout_size): Replace
12502 "parser_state" with "expr_builder".
12503 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12504 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12505 "parser_state" with "expr_builder".
12506
73923d7e
TT
125072019-04-04 Tom Tromey <tom@tromey.com>
12508
12509 * rust-exp.y: Replace "parse_language" with method call.
12510 * p-exp.y:
12511 (yylex): Replace "parse_language" with method call.
12512 * m2-exp.y:
12513 (yylex): Replace "parse_language" with method call.
12514 * go-exp.y (classify_name): Replace "parse_language" with method
12515 call.
12516 * f-exp.y (yylex): Replace "parse_language" with method call.
12517 * d-exp.y (lex_one_token): Replace "parse_language" with method
12518 call.
12519 * c-exp.y:
12520 (lex_one_token, classify_name, yylex): Replace "parse_language"
12521 with method call.
12522 * ada-exp.y (find_primitive_type, type_char)
12523 (type_system_address): Replace "parse_language" with method call.
12524
fa9f5be6
TT
125252019-04-04 Tom Tromey <tom@tromey.com>
12526
12527 * rust-exp.y: Replace "parse_gdbarch" with method call.
12528 * parse.c (write_dollar_variable, insert_type_address_space):
12529 Replace "parse_gdbarch" with method call.
12530 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12531 call.
12532 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12533 call.
12534 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12535 "parse_gdbarch" with method call.
12536 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12537 with method call.
12538 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12539 "parse_gdbarch" with method call.
12540 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12541 "parse_gdbarch" with method call.
12542 * c-exp.y (parse_type, parse_number, classify_name): Replace
12543 "parse_gdbarch" with method call.
12544 * ada-lex.l: Replace "parse_gdbarch" with method call.
12545 * ada-exp.y (parse_type, find_primitive_type, type_char)
12546 (type_system_address): Replace "parse_gdbarch" with method call.
12547
1201a264
TT
125482019-04-04 Tom Tromey <tom@tromey.com>
12549
12550 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12551 * stap-probe.c (stap_parse_argument): Update.
12552 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12553 initial_size parameter.
12554 * rust-exp.y (rust_lex_tests): Update.
12555 * parse.c (parser_state): Update.
12556 (parse_exp_in_context): Update.
12557 * parser-defs.h (struct parser_state) <parser_state>: Remove
12558 "initial_size" parameter.
12559
e3980ce2
TT
125602019-04-04 Tom Tromey <tom@tromey.com>
12561
12562 * parser-defs.h (increase_expout_size): Don't declare.
12563 * parse.c (increase_expout_size): Now static.
12564
e9f8e3f1
TS
125652019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12566
12567 * gnu-nat.c (gnu_nat_target::wait): Fix
12568 target_waitstatus_to_string call.
12569
d7df6549
AB
125702019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12571
12572 * eval.c (evaluate_subexp_standard): Handle internal functions
12573 during Fortran function call handling.
12574
8bdc1658
AB
125752019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12576
12577 * NEWS: Mention new internal functions.
12578 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12579 (read_base_type): Use dwarf2_init_complex_target_type.
12580 * value.c (creal_internal_fn): New function.
12581 (cimag_internal_fn): New function.
12582 (_initialize_values): Register new internal functions.
12583
c29705b7
PW
125842019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12585
12586 * infrun.c (stop_all_threads): If debug_infrun, always
12587 trace the wait status after wait_one, using
12588 target_waitstatus_to_string and target_pid_to_str.
12589 (handle_inferior_event): Replace various trace of
12590 wait status kind by a single trace.
12591 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12592 wait status kind image by target_waitstatus_to_string.
12593 * target/waitstatus.c (target_waitstatus_to_string): Fix
12594 obsolete comment.
12595
05caa1d2
TT
125962019-04-01 Tom Tromey <tromey@adacore.com>
12597
12598 PR symtab/23331:
12599 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12600
9d1447e0
SDJ
126012019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12602 Pedro Alves <palves@redhat.com>
12603
12604 * top.c (quit_force): Call 'finalize_values'.
12605 * value.c (finalize_values): New function.
12606 * value.h (finalize_values): Declare.
12607
7734102d
EZ
126082019-03-30 Eli Zaretskii <eliz@gnu.org>
12609
12610 * NEWS: Announce $_gdb_major and $_gdb_minor.
12611
12612 * top.c (init_gdb_version_vars): New function.
12613 (gdb_init): Call init_gdb_version_vars.
12614
188e1fa9
TT
126152019-03-29 Tom Tromey <tromey@adacore.com>
12616
12617 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12618 help text. Remove dead code.
12619
2880242d
KS
126202019-03-29 Keith Seitz <keiths@redhat.com>
12621
12622 From Siddhesh Poyarekar:
12623 * f-lang.h (f77_get_upperbound): Return LONGEST.
12624 (f77_get_lowerbound): Likewise.
12625 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12626 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12627 print them.
12628 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12629 plongest to format print it.
12630 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12631 (f77_get_upperbound): Likewise.
12632 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12633 LOWER_BOUND to LONGEST.
12634 (f77_create_arrayprint_offset_tbl): Likewise.
12635
cc1defb1
KS
126362019-03-29 Keith Seitz <keiths@redhat.com>
12637
12638 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12639 %s/pulongest for TYPE_LENGTH instead of %d in format
12640 strings.
12641 * ada-typerint.c (ada_print_type): Likewise.
12642 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12643 * compile/compile-c-support.c (generate_register_struct): Likewise.
12644 * gdbtypes.c (recursive_dump_type): Likewise.
12645 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12646 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12647 instead of %d in format strings.
12648 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12649 to std::min to ULONGEST.
12650 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12651 instead of %d in format strings.
12652 * tracepoint.c (info_scope_command): Likewise.
12653 * typeprint.c (print_offset_data::update)
12654 (print_offset_data::finish): Likewise.
12655 * xtensa-tdep.c (xtensa_store_return_value)
12656 (xtensa_push_dummy_call): Likewise.
12657
e432ccf1
JT
126582019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12659
12660 * windows-nat.c (display_selector): Fixed format specifications
12661 for 64-bit Cygwin.
12662
65d2b333
PW
126632019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12664
12665 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12666
f489207e
SL
126672019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12668
12669 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12670 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12671 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12672 (nios2_linux_init_abi): Install it.
12673
bffa1015
AH
126742019-03-28 Alan Hayward <alan.hayward@arm.com>
12675
12676 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12677
fc96163a
AH
126782019-03-28 Alan Hayward <alan.hayward@arm.com>
12679
12680 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12681
20dc7e9b
PW
126822019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12683 Tom Tromey <tromey@adacore.com>
12684
12685 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12686
7f5331a8
JB
126872019-03-26 Joel Brobecker <brobecker@adacore.com>
12688
12689 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12690 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12691 method to compute the bounds of range types. Also print "[evaluated]"
12692 if the bounds' values come from a dynamic evaluation.
12693
18c77628
AB
126942019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12695
12696 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12697 whitespace when pretty printing is on.
12698
53c973f2
AH
126992019-03-26 Alan Hayward <alan.hayward@arm.com>
12700
e79be6e5 12701 * ppc-linux-nat.c: Add include.
53c973f2 12702
d851aa71
AH
127032019-03-26 Alan Hayward <alan.hayward@arm.com>
12704
e79be6e5 12705 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12706
2fe7bab7
AH
127072019-03-26 Alan Hayward <alan.hayward@arm.com>
12708
e79be6e5 12709 * arm-linux-nat.c: Add include.
2fe7bab7 12710
068ef30e
SM
127112019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12712
12713 * source-cache.c (source_cache::get_source_lines): Re-read
12714 fullname after calling open_source_file.
12715
81a24d04
JB
127162019-03-25 John Baldwin <jhb@FreeBSD.org>
12717
12718 * NEWS: Mention TLS support for FreeBSD.
12719
79e7ae11
TT
127202019-03-25 Tom Tromey <tromey@adacore.com>
12721
12722 * minsyms.c (BUNCH_SIZE): Update comment.
12723 (~minimal_symbol_reader): Remove old comment.
12724 (compact_minimal_symbols): Update comment.
12725 (minimal_symbol_reader::install): Remove old comment. Update
12726 other comments.
12727
d45963c2
AH
127282019-03-25 Alan Hayward <alan.hayward@arm.com>
12729
12730 * s390-linux-nat.c: Add include.
12731
0f83012e
AH
127322019-03-25 Alan Hayward <alan.hayward@arm.com>
12733
12734 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12735 Call linux_get_hwcap.
12736 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12737 Likewise.
12738 (aarch64_linux_get_hwcap): Remove function.
12739 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12740 declaration.
12741 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12742 linux_get_hwcap.
12743 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12744 * linux-tdep.c (linux_get_hwcap): Add function.
12745 (linux_get_hwcap2): Likewise.
12746 * linux-tdep.h (linux_get_hwcap): Add declaration.
12747 (linux_get_hwcap2): Likewise.
12748 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12749 (ppc_linux_get_hwcap2): Likewise.
12750 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12751 linux_get_hwcap.
12752 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12753 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12754 (ppc_linux_nat_target::read_description): Likewise.
12755 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12756 * s390-linux-nat.c: Likewise.
12757 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12758
6640a367
TT
127592019-03-24 Tom Tromey <tom@tromey.com>
12760
12761 * ada-lang.c (standard_lookup): Simplify initialization.
12762 (ada_lookup_symbol_nonlocal): Simplify return.
12763 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12764 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12765 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12766 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12767 initialization.
12768 * solib.c (solib_global_lookup): Simplify.
12769 * symtab.c (null_block_symbol): Remove.
12770 (symbol_cache_lookup): Simplify returns.
12771 (lookup_language_this): Simplify returns.
12772 (lookup_symbol_aux): Simplify return.
12773 (lookup_local_symbol): Simplify returns.
12774 (lookup_global_symbol_from_objfile): Simplify return.
12775 (lookup_symbol_in_objfile_symtabs)
12776 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12777 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12778 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12779 * cp-namespace.c (cp_lookup_bare_symbol)
12780 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12781 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12782 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12783 (cp_lookup_symbol_via_imports): Simplify initialization.
12784 (find_symbol_in_baseclass): Likewise.
12785 * symtab.h (null_block_symbol): Remove.
12786 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12787 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12788 (d_lookup_symbol_module): Likewise.
12789 (find_symbol_in_baseclass): Simplify initialization.
12790
a930ebcd
TT
127912019-03-24 Tom Tromey <tom@tromey.com>
12792
12793 * expression.h: Don't include symtab.h.
12794 (struct block): Forward declare.
12795
582942f4
TT
127962019-03-24 Tom Tromey <tom@tromey.com>
12797
12798 * c-exp.y (typebase): Remove casts.
12799 * gdbtypes.c (lookup_unsigned_typename, )
12800 (lookup_signed_typename): Remove cast.
12801 * eval.c (parse_to_comma_and_eval): Remove cast.
12802 * parse.c (write_dollar_variable): Remove cast.
12803 * block.h (struct block) <superblock>: Now const.
12804 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12805 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12806 (map_block): Make "block" const.
12807 * symfile.h (struct quick_symbol_functions)
12808 <map_matching_symbols>: Constify block argument to "callback".
12809 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12810 const.
12811 (find_pc_sect_compunit_symtab): Make "b" const.
12812 (find_symbol_at_address): Likewise.
12813 (search_symbols): Likewise.
12814 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12815 (dw2_debug_names_lookup_symbol): Likewise.
12816 (dw2_map_matching_symbols): Update.
12817 * p-valprint.c (pascal_val_print): Remove "block".
12818 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12819 (aux_add_nonlocal_symbols): Make "block" const.
12820 (resolve_subexp): Remove cast.
12821 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12822 const.
12823 (iterate_over_file_blocks): Likewise.
12824 * f-exp.y (%union) <bval>: Remove.
12825 * coffread.c (patch_opaque_types): Make "b" const.
12826 * spu-tdep.c (spu_catch_start): Make "block" const.
12827 * c-valprint.c (print_unpacked_pointer): Remove "block".
12828 * symmisc.c (dump_symtab_1): Make "b" const.
12829 (block_depth): Make "block" const.
12830 * d-exp.y (%union) <bval>: Remove.
12831 * cp-support.h (cp_lookup_rtti_type): Update.
12832 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12833 * psymtab.c (psym_lookup_symbol): Make "block" const.
12834 (maintenance_check_psymtabs): Make "b" const.
12835 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12836 (enumerate_locals, enumerate_args): Update.
12837 * python/py-symtab.c (stpy_global_block): Make "block" const.
12838 (stpy_static_block): Likewise.
12839 * inline-frame.c (block_starting_point_at): Make "new_block"
12840 const.
12841 * block.c (find_block_in_blockvector): Make return type const.
12842 (blockvector_for_pc_sect): Make "b" const.
12843 (find_block_in_blockvector): Make "b" const.
12844
7ad417dd
TT
128452019-03-23 Tom Tromey <tom@tromey.com>
12846
12847 * varobj.c (varobj_create): Update.
12848 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12849 * printcmd.c (display_command, do_one_display): Don't reset
12850 innermost_block.
12851 * parser-defs.h (enum innermost_block_tracker_type): Move to
12852 expression.h.
12853 (innermost_block): Update comment.
12854 * parse.c (parse_exp_1): Add tracker_types parameter.
12855 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12856 tracker_types parameter. Reset innermost_block.
12857 (parse_exp_in_context): Remove.
12858 (parse_expression_for_completion): Update.
12859 * objfiles.c (~objfile): Don't reset expression_context_block or
12860 innermost_block.
12861 * expression.h (enum innermost_block_tracker_type): Move from
12862 parser-defs.h.
12863 (parse_exp_1): Add tracker_types parameter.
12864 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12865 reset innermost_block.
12866
b366c208
TT
128672019-03-23 Tom Tromey <tom@tromey.com>
12868
12869 * objfiles.h: Include bcache.h.
12870
9bb9b2f9
TT
128712019-03-23 Tom Tromey <tom@tromey.com>
12872
12873 * linespec.c (get_current_search_block): Use
12874 scoped_restore_current_language.
12875 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12876
59c28372
AH
128772019-03-22 Alan Hayward <alan.hayward@arm.com>
12878 Jiong Wang <jiong.wang@arm.com>
12879
12880 * aarch64-linux-tdep.c
12881 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12882 section.
12883 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12884
17e116a7
AH
128852019-03-22 Alan Hayward <alan.hayward@arm.com>
12886 Jiong Wang <jiong.wang@arm.com>
12887
12888 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12889 instructions.
12890 (aarch64_analyze_prologue_test): Add PACIASP test.
12891 (aarch64_prologue_prev_register): Unmask PC value.
12892
11e1b75f
AH
128932019-03-22 Alan Hayward <alan.hayward@arm.com>
12894 Jiong Wang <jiong.wang@arm.com>
12895
12896 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12897 (aarch64_dwarf2_prev_register): Unmask PC value.
12898 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12899 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12900 DW_CFA_AARCH64_negate_ra_state.
12901 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12902
34dcc7cf
AH
129032019-03-22 Alan Hayward <alan.hayward@arm.com>
12904 Jiong Wang <jiong.wang@arm.com>
12905
12906 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12907 registers.
12908 (aarch64_pseudo_register_name): Likewise.
12909 (aarch64_pseudo_register_type): Likewise.
12910 (aarch64_pseudo_register_reggroup_p): Likewise.
12911 (aarch64_gdbarch_init): Add pauth registers.
12912 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12913 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12914 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12915 (struct gdbarch_tdep): Add regnum for ra_state.
12916
1ef53e6b
AH
129172019-03-22 Alan Hayward <alan.hayward@arm.com>
12918 Jiong Wang <jiong.wang@arm.com>
12919
12920 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12921
76bed0fd
AH
129222019-03-22 Alan Hayward <alan.hayward@arm.com>
12923 Jiong Wang <jiong.wang@arm.com>
12924
12925 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12926 function.
12927 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12928 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12929 (aarch64_gdbarch_init): Add puth registers.
12930 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12931 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12932 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12933
ee4fbcfa
AH
129342019-03-22 Alan Hayward <alan.hayward@arm.com>
12935 Jiong Wang <jiong.wang@arm.com>
12936
12937 * aarch64-linux-nat.c
12938 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12939 * aarch64-linux-tdep.c
12940 (aarch64_linux_core_read_description): Likewise.
12941 (aarch64_linux_get_hwcap): New function.
12942 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12943 (aarch64_linux_get_hwcap): New declaration.
12944
6dc0ebde
AH
129452019-03-22 Alan Hayward <alan.hayward@arm.com>
12946 Jiong Wang <jiong.wang@arm.com>
12947
12948 * aarch64-linux-nat.c
12949 (aarch64_linux_nat_target::read_description): Add pauth param.
12950 * aarch64-linux-tdep.c
12951 (aarch64_linux_core_read_description): Likewise.
12952 * aarch64-tdep.c (struct target_desc): Add in pauth.
12953 (aarch64_read_description): Add pauth param.
12954 (aarch64_gdbarch_init): Likewise.
12955 * aarch64-tdep.h (aarch64_read_description): Likewise.
12956 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12957 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12958 * features/Makefile: Add new files.
12959 * features/aarch64-pauth.c: New file.
12960 * features/aarch64-pauth.xml: New file.
12961
595915c1
TT
129622019-03-20 Tom Tromey <tromey@adacore.com>
12963
12964 * infrun.c (handle_inferior_event): Rename from
12965 handle_inferior_event_1. Create a scoped_value_mark.
12966 (handle_inferior_event): Remove.
12967
4c7d57e7
TT
129682019-03-19 Tom Tromey <tromey@adacore.com>
12969
12970 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12971 * infrun.h (print_stop_event): Add "displays" parameter.
12972 * infrun.c (print_stop_event): Add "displays" parameter.
12973
cb246234
PA
129742019-03-19 Pedro Alves <palves@redhat.com>
12975
12976 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12977 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12978 to -1. Fix TABs vs spaces.
12979 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12980 * tui/tui-out.h (tui_ui_out) Add intro comments.
12981 <m_line, m_start_of_line>: In-class initialize, and add describing
12982 comment.
12983
3a0e45b2
AH
129842019-03-18 Alan Hayward <alan.hayward@arm.com>
12985
12986 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12987 variable names.
12988 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12989
5371b850
PA
129902019-03-18 Pedro Alves <palves@redhat.com>
12991 Eli Zaretskii <eliz@gnu.org>
12992
12993 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12994 m_line and m_start_of_line.
12995
b17c4cd0
EZ
129962019-03-18 Eli Zaretskii <eliz@gnu.org>
12997
12998 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12999 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13000 it returns a newline. This fixes a regression in TU mode, whereby
13001 the next line is output on the same screen line as the user input.
13002
4bd56d18
TT
130032019-03-18 Tom Tromey <tromey@adacore.com>
13004
13005 * minsyms.c (minimal_symbol_reader::install): Remove call to
13006 obstack_blank.
13007
55c10aca
PA
130082019-03-18 Pedro Alves <palves@redhat.com>
13009
13010 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13011 New globals.
13012 (apply_style): New, factored out from ...
13013 (apply_ansi_escape): ... this. Handle reverse video mode.
13014 (tui_set_reverse_mode): New function.
13015 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13016 * tui/tui-winsource.c (tui_show_source_line): Use
13017 tui_set_reverse_mode instead of setting A_STANDOUT.
13018 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13019 New setter methods.
13020
647bb750
HD
130212019-03-18 Hannes Domani <ssbssa@yahoo.de>
13022
13023 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13024 Handle tabs.
13025
bff8c71f
TT
130262019-03-18 Tom Tromey <tromey@adacore.com>
13027
13028 * ada-lang.c (empty_array): Add "high" parameter.
13029 (ada_evaluate_subexp): Update.
13030
58785d98
ST
130312019-03-17 Sergei Trofimovich <siarheit@google.com>
13032
13033 * unittests/string_view-selftests.c: Define
13034 _initialize_string_view_selftests unconditionally.
13035
d4cbef22
ВМ
130362019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13037
13038 PR gdb/24350
13039 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13040
fce4c071
ВМ
130412019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13042
13043 PR gdb/24351
13044 * windows-nat.c (display_selector): Fix format specifiers.
13045
f7f0a123
EZ
130462019-03-17 Eli Zaretskii <eliz@gnu.org>
13047
13048 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13049 tui_refill_source_window instead of tui_refresh_win, to update the
13050 current execution line. This fixes redisplay of the current line
13051 when stepping through the code with "next" or "step".
13052
ab42892f
EZ
130532019-03-16 Eli Zaretskii <eliz@gnu.org>
13054
13055 * source-cache.c (source_cache::get_source_lines): Call
13056 find_source_lines to initialize s->nlines. This fixes vertical
13057 scrolling of TUI source window when the DOWN arrow is pressed.
13058
8d8c087f
PW
130592019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13060
13061 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13062 linux-thread-db.c (_initialize_thread_db): Likewise.
13063
798e1c30
EZ
130642019-03-16 Eli Zaretskii <eliz@gnu.org>
13065
13066 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13067 wclrtoeol in tui_show_source_line". This reverts changes made in
13068 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13069
eefba3da
TT
130702019-03-15 Tom Tromey <tom@tromey.com>
13071
13072 * symtab.h (struct minimal_symbol): Derive from
13073 general_symbol_info.
13074 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13075 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13076 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13077 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13078 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13079 (MSYMBOL_SEARCH_NAME): Update.
13080 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13081 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13082 * minsyms.c (minimal_symbol_reader::record_full): Update.
13083
0de2420c
TT
130842019-03-15 Tom Tromey <tom@tromey.com>
13085
13086 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13087
042d75e4
TT
130882019-03-15 Tom Tromey <tom@tromey.com>
13089
13090 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13091 unique_xmalloc_ptr.
13092 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13093 Update.
13094 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13095 (build_minimal_symbol_hash_tables)
13096 (minimal_symbol_reader::install): Update.
13097
db92718b
TT
130982019-03-15 Tom Tromey <tom@tromey.com>
13099
13100 * symtab.c (create_demangled_names_hash): Update.
13101 (symbol_set_names): Update.
13102 * objfiles.h (struct objfile_per_bfd_storage)
13103 <demangled_names_hash>: Now an htab_up.
13104 * objfiles.c (objfile_per_bfd_storage): Simplify.
13105
d6797f46
TT
131062019-03-15 Tom Tromey <tom@tromey.com>
13107
13108 * objfiles.h (struct objfile_per_bfd_storage): Declare
13109 destructor.
13110 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13111 New.
13112 (get_objfile_bfd_data): Use new. Don't initialize
13113 language_of_main.
13114 (free_objfile_per_bfd_storage): Remove.
13115 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13116
741d7538
TT
131172019-03-15 Tom Tromey <tom@tromey.com>
13118
13119 * symfile.c (reread_symbols): Update.
13120 * objfiles.c (objfile::objfile): Update.
13121 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13122 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13123 comment.
13124 (minimal_symbol_reader::install): Update.
13125 (terminate_minimal_symbol_table): Remove.
13126 * jit.c (jit_object_close_impl): Update.
13127
788c80d1
TT
131282019-03-15 Tom Tromey <tom@tromey.com>
13129
13130 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13131 initializations.
13132
1b7a07cb
TT
131332019-03-15 Tom Tromey <tom@tromey.com>
13134
13135 * objfiles.h (struct objfile_per_bfd_storage)
13136 <demangled_hash_languages>: Now a bitset.
13137 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13138 (lookup_minimal_symbol): Update.
13139
3db066bc
TT
131402019-03-15 Tom Tromey <tom@tromey.com>
13141
13142 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13143 Don't return the symbol.
13144 * coffread.c (record_minimal_symbol): Use record_full.
13145
3fff2c37
EZ
131462019-03-14 Eli Zaretskii <eliz@gnu.org>
13147
13148 The MS-Windows port of ncurses fails to switch to a color pair if
13149 one or both of the colors are the implicit default colors. This
13150 change records the default colors when TUI is initialized, and
13151 then specifies them explicitly when a color pair uses the default
13152 colors. This allows color styling in TUI mode on MS-Windows.
13153
13154 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13155 ncurses_norm_attr.
13156 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13157 colors in ncurses_norm_attr.
13158 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13159 "none", replace it with the default color recorded in
13160 ncurses_norm_attr.
13161
3b336828
TT
131622019-03-14 Tom Tromey <tromey@adacore.com>
13163
13164 * source-cache.h (class source_cache) <get_source_lines>: Return
13165 std::string.
13166 * source-cache.c (source_cache::extract_lines): Handle case where
13167 first_pos==npos. Return std::string.
13168 (source_cache::get_source_lines): Update.
13169
d085f989
TT
131702019-03-14 Tom Tromey <tromey@adacore.com>
13171
13172 * NEWS: Add item for "style sources" commands.
13173 * source-cache.c (source_cache::get_source_lines): Check
13174 source_styling.
13175 * cli/cli-style.c (source_styling): New global.
13176 (_initialize_cli_style): Add "style sources" commands.
13177 (show_style_sources): New function.
13178 * cli/cli-style.h (source_styling): Declare.
13179
6f11e682
TT
131802019-03-14 Pedro Alves <palves@redhat.com>
13181 Tom Tromey <tromey@adacore.com>
13182
13183 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13184 * tui/tui-winsource.c (tui_refill_source_window): New function,
13185 from...
13186 (tui_horizontal_source_scroll): ... here. Move some logic.
13187 * cli/cli-style.c (set_style_enabled): Notify new observable.
13188 * tui/tui-hooks.c (tui_redisplay_source): New function.
13189 (tui_attach_detach_observers): Attach or detach
13190 tui_redisplay_source.
13191 * observable.h (source_styling_changed): New observable.
13192 * observable.c: Define source_styling_changed observable.
13193
a068643d
TT
131942019-03-13 Tom Tromey <tromey@adacore.com>
13195
13196 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13197 (i386_gnu_nat_target::store_registers): Update.
13198 * target-debug.h (target_debug_print_std_string): New macro.
13199 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13200 * windows-tdep.c (display_one_tib): Update.
13201 * tui/tui-stack.c (tui_make_status_line): Update.
13202 * top.c (print_inferior_quit_action): Update.
13203 * thread.c (thr_try_catch_cmd): Update.
13204 (add_thread_with_info): Update.
13205 (thread_target_id_str): Update.
13206 (thr_try_catch_cmd): Update.
13207 (thread_command): Update.
13208 (thread_find_command): Update.
13209 * record-btrace.c (record_btrace_target::info_record)
13210 (record_btrace_resume_thread, record_btrace_target::resume)
13211 (record_btrace_cancel_resume, record_btrace_step_thread)
13212 (record_btrace_target::wait, record_btrace_target::wait)
13213 (record_btrace_target::wait, record_btrace_target::stop): Update.
13214 * progspace.c (print_program_space): Update.
13215 * process-stratum-target.c
13216 (process_stratum_target::thread_address_space): Update.
13217 * linux-fork.c (linux_fork_mourn_inferior)
13218 (detach_checkpoint_command, info_checkpoints_command)
13219 (linux_fork_context): Update.
13220 (linux_fork_detach): Update.
13221 (class scoped_switch_fork_info): Update.
13222 (delete_checkpoint_command): Update.
13223 * infrun.c (follow_fork_inferior): Update.
13224 (follow_fork_inferior): Update.
13225 (proceed_after_vfork_done): Update.
13226 (handle_vfork_child_exec_or_exit): Update.
13227 (follow_exec): Update.
13228 (displaced_step_prepare_throw): Update.
13229 (displaced_step_restore): Update.
13230 (start_step_over): Update.
13231 (resume_1): Update.
13232 (clear_proceed_status_thread): Update.
13233 (proceed): Update.
13234 (print_target_wait_results): Update.
13235 (do_target_wait): Update.
13236 (context_switch): Update.
13237 (stop_all_threads): Update.
13238 (restart_threads): Update.
13239 (finish_step_over): Update.
13240 (handle_signal_stop): Update.
13241 (switch_back_to_stepped_thread): Update.
13242 (keep_going_pass_signal): Update.
13243 (print_exited_reason): Update.
13244 (normal_stop): Update.
13245 * inferior.c (inferior_pid_to_str): Change return type.
13246 (print_selected_inferior): Update.
13247 (add_inferior): Update.
13248 (detach_inferior): Update.
13249 * dummy-frame.c (fprint_dummy_frames): Update.
13250 * dcache.c (dcache_info_1): Update.
13251 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13252 (btrace_fetch, btrace_clear): Update.
13253 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13254 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13255 type.
13256 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13257 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13258 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13259 * gdbarch.c, gdbarch.h: Rebuild.
13260 * gdbarch.sh (core_pid_to_str): Change return type.
13261 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13262 return type.
13263 (windows_nat_target::pid_to_str): Change return type.
13264 (windows_delete_thread): Update.
13265 (windows_nat_target::attach): Update.
13266 (windows_nat_target::files_info): Update.
13267 * target-delegates.c: Rebuild.
13268 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13269 return type.
13270 (sol_thread_target::pid_to_str): Change return type.
13271 * remote.c (class remote_target) <pid_to_str>: Change return
13272 type.
13273 (remote_target::pid_to_str): Change return type.
13274 (extended_remote_target::attach, remote_target::remote_stop_ns)
13275 (remote_target::remote_notif_remove_queued_reply)
13276 (remote_target::push_stop_reply, remote_target::disable_btrace):
13277 Update.
13278 (extended_remote_target::attach): Update.
13279 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13280 type.
13281 (gdbsim_target::pid_to_str): Change return type.
13282 * ravenscar-thread.c (struct ravenscar_thread_target)
13283 <pid_to_str>: Change return type.
13284 (ravenscar_thread_target::pid_to_str): Change return type.
13285 * procfs.c (class procfs_target) <pid_to_str>: Change return
13286 type.
13287 (procfs_target::pid_to_str): Change return type.
13288 (procfs_target::attach): Update.
13289 (procfs_target::detach): Update.
13290 (procfs_target::fetch_registers): Update.
13291 (procfs_target::store_registers): Update.
13292 (procfs_target::wait): Update.
13293 (procfs_target::files_info): Update.
13294 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13295 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13296 return type.
13297 (nto_procfs_target::pid_to_str): Change return type.
13298 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13299 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13300 return type.
13301 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13302 (exit_lwp): Update.
13303 (attach_proc_task_lwp_callback, get_detach_signal)
13304 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13305 (linux_nat_target::resume, wait_lwp, stop_callback)
13306 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13307 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13308 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13309 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13310 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13311 type.
13312 (inf_ptrace_target::attach): Update.
13313 (inf_ptrace_target::files_info): Update.
13314 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13315 type.
13316 (go32_nat_target::pid_to_str): Change return type.
13317 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13318 (gnu_nat_target::wait): Update.
13319 (gnu_nat_target::wait): Update.
13320 (gnu_nat_target::resume): Update.
13321 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13322 (fbsd_nat_target::wait): Update.
13323 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13324 type.
13325 (darwin_nat_target::attach): Update.
13326 * corelow.c (class core_target) <pid_to_str>: Change return type.
13327 (core_target::pid_to_str): Change return type.
13328 * target.c (normal_pid_to_str): Change return type.
13329 (default_pid_to_str): Likewise.
13330 (target_pid_to_str): Change return type.
13331 (target_translate_tls_address): Update.
13332 (target_announce_detach): Update.
13333 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13334 return type.
13335 (bsd_uthread_target::pid_to_str): Change return type.
13336 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13337 type.
13338 (bsd_kvm_target::pid_to_str): Change return type.
13339 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13340 return type.
13341 (aix_thread_target::pid_to_str): Change return type.
13342 * target.h (struct target_ops) <pid_to_str>: Change return type.
13343 (target_pid_to_str, normal_pid_to_str): Likewise.
13344 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13345 type.
13346 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13347 type.
13348 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13349 return type.
13350 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13351 type.
13352 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13353 type.
13354 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13355 return type.
13356
b4be1b06
SM
133572019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13358
13359 * NEWS: Mention that the new default MI version is 3. Mention
13360 changes to the output of commands and events that deal with
13361 multi-location breakpoints.
13362 * breakpoint.c: Include "mi/mi-out.h".
13363 (print_one_breakpoint): Change output syntax if using MI version
13364 >= 3.
13365 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13366 New.
13367 (mi_multi_location_breakpoint_output_fixed): New.
13368 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13369 (mi_cmd_fix_multi_location_breakpoint_output): New.
13370 (mi_multi_location_breakpoint_output_fixed): New.
13371 * mi/mi-cmds.c (mi_cmds): Register command
13372 -fix-multi-location-breakpoint-output.
13373 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13374 interpreter "mi".
13375
8e5e5494
SM
133762019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13377
13378 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13379 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13380 instantiate mi_ui_out based on interpreter name.
13381 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13382 * mi/mi-main.c (mi_load_progress): Likewise.
13383
197df35e
JB
133842019-03-12 John Baldwin <jhb@FreeBSD.org>
13385
13386 * NEWS: Combine separate "New targets" sections for 8.3.
13387
8399425f
JB
133882019-03-12 John Baldwin <jhb@FreeBSD.org>
13389
13390 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13391 (ppcfbsd_init_abi): Install gdbarch
13392 "fetch_tls_load_module_address" and "get_thread_local_address"
13393 methods.
13394
b0f87ed0
JB
133952019-03-12 John Baldwin <jhb@FreeBSD.org>
13396
13397 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13398 (riscv_fbsd_init_abi): Install gdbarch
13399 "fetch_tls_load_module_address" and "get_thread_local_address"
13400 methods.
13401
ce25aa57
JB
134022019-03-12 John Baldwin <jhb@FreeBSD.org>
13403
13404 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13405 (i386fbsd_init_abi): Install gdbarch
13406 "fetch_tls_load_module_address" and "get_thread_local_address"
13407 methods.
13408
f5424cfa
JB
134092019-03-12 John Baldwin <jhb@FreeBSD.org>
13410
13411 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13412 (amd64fbsd_init_abi): Install gdbarch
13413 "fetch_tls_load_module_address" and "get_thread_local_address"
13414 methods.
13415
945f3901
JB
134162019-03-12 John Baldwin <jhb@FreeBSD.org>
13417
13418 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13419 (struct fbsd_pspace_data): New type.
13420 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13421 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13422 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13423 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13424 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13425
ef0bd204
JB
134262019-03-12 John Baldwin <jhb@FreeBSD.org>
13427
13428 * gdbtypes.c (lookup_struct_elt): New function.
13429 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13430 * gdbtypes.h (struct struct_elt): New type.
13431 (lookup_struct_elt): New prototype.
13432
36c53a02
JB
134332019-03-12 John Baldwin <jhb@FreeBSD.org>
13434
13435 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13436 remove disabled code block.
13437
6e056c81
JB
134382019-03-12 John Baldwin <jhb@FreeBSD.org>
13439
13440 * gdbarch.sh (get_thread_local_address): New method.
13441 * gdbarch.h, gdbarch.c: Regenerate.
13442 * target.c (target_translate_tls_address): Use
13443 gdbarch_get_thread_local_address if present instead of
13444 target::get_thread_local_address.
13445
cd250a18
JB
134462019-03-12 John Baldwin <jhb@FreeBSD.org>
13447
13448 * target.h (target::get_thread_local_address): Update comment.
13449
df22c1e5
JB
134502019-03-12 John Baldwin <jhb@FreeBSD.org>
13451
13452 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13453 objfile->separate_debug_objfile_backlink if not NULL.
13454
dd6876c9
JB
134552019-03-12 John Baldwin <jhb@FreeBSD.org>
13456
13457 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13458 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13459 (amd64bsd_store_inferior_registers): Likewise.
13460 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13461 Enable segment base registers.
13462 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13463 PT_GETFSBASE and PT_GETGSBASE.
13464 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13465 PT_SETGSBASE.
13466 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13467 segment base registers.
13468 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13469
1163a4b7
JB
134702019-03-12 John Baldwin <jhb@FreeBSD.org>
13471
13472 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13473 Update calls to i386_target_description to add 'segments'
13474 parameter.
13475 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13476 add segment base registers.
13477 * arch/i386.c (i386_create_target_description): Add 'segments'
13478 parameter to enable segment base registers.
13479 * arch/i386.h (i386_create_target_description): Likewise.
13480 * features/i386/32bit-segments.xml: New file.
13481 * features/i386/32bit-segments.c: Generate.
13482 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13483 call to i386_target_description to add 'segments' parameter.
13484 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13485 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13486 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13487 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13488 if feature is present.
13489 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13490 Add 'segments' parameter to call to i386_target_description.
13491 (i386_target_description): Add 'segments' parameter to enable
13492 segment base registers.
13493 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13494 to call to i386_target_description.
13495 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13496 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13497 Define I386_NUM_REGS.
13498 (i386_target_description): Add 'segments' parameter to enable
13499 segment base registers.
13500
3a350822
EZ
135012019-03-12 Eli Zaretskii <eliz@gnu.org>
13502
13503 PR/24325
13504 * source-cache.c: #undef open and close, to avoid unresolved
13505 externals during linking.
13506
ffdd69cf
TT
135072019-03-12 Tom Tromey <tromey@adacore.com>
13508
13509 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13510 const. Add initializers.
13511 (_initialize_remote): Don't initialize ptid globals.
13512
ec148c57
PA
135132019-03-12 Pedro Alves <palves@redhat.com>
13514
13515 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13516
32764270
PA
135172019-03-12 Pedro Alves <palves@redhat.com>
13518
13519 * cp-name-parser.y (main): Remove unused 'len' variable.
13520
17547186
TT
135212019-03-12 Tom Tromey <tromey@adacore.com>
13522
13523 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13524 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13525
d3a70e03
TT
135262019-03-12 Tom Tromey <tromey@adacore.com>
13527
13528 * linux-nat.c (iterate_over_lwps): Update.
13529 (stop_callback): Remove parameter.
13530 (stop_wait_callback, detach_callback, resume_set_callback)
13531 (select_singlestep_lwp_callback, set_ignore_sigint)
13532 (status_callback, resumed_callback, resume_clear_callback)
13533 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13534 data parameter.
13535 (linux_nat_target::detach, linux_nat_target::resume)
13536 (linux_stop_and_wait_all_lwps, select_event_lwp)
13537 (linux_nat_filter_event, linux_nat_wait_1)
13538 (linux_nat_target::kill, linux_nat_target::stop)
13539 (linux_nat_target::stop): Update.
13540 (linux_nat_resume_callback): Change type.
13541 (resume_stopped_resumed_lwps, count_events_callback)
13542 (select_event_lwp_callback): Likewise.
13543 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13544 * arm-linux-nat.c (struct update_registers_data): Remove.
13545 (update_registers_callback): Change type.
13546 (arm_linux_insert_hw_breakpoint1): Update.
13547 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13548 parameter.
13549 (x86_linux_dr_set_addr): Update.
13550 (x86_linux_dr_set_control): Update.
13551 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13552 (iterate_over_lwps): Use gdb::function_view.
13553 * nat/aarch64-linux-hw-point.c (struct
13554 aarch64_dr_update_callback_param): Remove.
13555 (debug_reg_change_callback): Change type.
13556 (aarch64_notify_debug_reg_change): Update.
13557 * s390-linux-nat.c (s390_refresh_per_info): Update.
13558
82cb27ff
TT
135592019-03-11 Tom Tromey <tromey@adacore.com>
13560
13561 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13562 redundant assignment to "this_cu".
13563
568c0683
SM
135642019-03-08 Simon Marchi <simon.marchi@efficios.com>
13565
13566 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13567
f09ce22d
SM
135682019-03-08 Simon Marchi <simon.marchi@efficios.com>
13569
13570 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13571 from...
13572 (rank_one_type): ... this.
13573
595f96a9
SM
135742019-03-08 Simon Marchi <simon.marchi@efficios.com>
13575
13576 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13577 from...
13578 (rank_one_type): ... this.
13579
2598a94b
SM
135802019-03-08 Simon Marchi <simon.marchi@efficios.com>
13581
13582 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13583 from...
13584 (rank_one_type): ... this.
13585
7f17b20d
SM
135862019-03-08 Simon Marchi <simon.marchi@efficios.com>
13587
13588 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13589 from...
13590 (rank_one_type): ... this.
13591
2c509035
SM
135922019-03-08 Simon Marchi <simon.marchi@efficios.com>
13593
13594 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13595 from...
13596 (rank_one_type): ... this.
13597
0dd322dc
SM
135982019-03-08 Simon Marchi <simon.marchi@efficios.com>
13599
13600 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13601 from...
13602 (rank_one_type): ... this.
13603
41ea4728
SM
136042019-03-08 Simon Marchi <simon.marchi@efficios.com>
13605
13606 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13607 from...
13608 (rank_one_type): ... this.
13609
793cd1d2
SM
136102019-03-08 Simon Marchi <simon.marchi@efficios.com>
13611
13612 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13613 from...
13614 (rank_one_type): ... this.
13615
34910087
SM
136162019-03-08 Simon Marchi <simon.marchi@efficios.com>
13617
13618 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13619 from...
13620 (rank_one_type): ... this.
13621
f1f832d6
SM
136222019-03-08 Simon Marchi <simon.marchi@efficios.com>
13623
13624 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13625 from...
13626 (rank_one_type): ... this.
13627
b9f4512f
SM
136282019-03-08 Simon Marchi <simon.marchi@efficios.com>
13629
13630 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13631 from...
13632 (rank_one_type): ... this.
13633
9293fc63
SM
136342019-03-08 Simon Marchi <simon.marchi@efficios.com>
13635
13636 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13637 from...
13638 (rank_one_type): ... this.
13639
e3abbe7e
PW
136402019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13641
13642 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13643 inferior-events' shows the example events.
13644
e4adb939
EZ
136452019-03-08 Eli Zaretskii <eliz@gnu.org>
13646
13647 Support styling on native MS-Windows console
13648
13649 PR/24315
13650 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13651 on MS-Windows if $TERM is not defined.
13652
13653 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13654
13655 * posix-hdep.c (gdb_console_fputs):
13656 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13657 functions.
13658 * ui-file.h (gdb_console_fputs): Add prototype.
13659
13660 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13661 back to fputs only if the former returns zero.
13662
25629dfd
TT
136632019-03-07 Tom Tromey <tom@tromey.com>
13664
13665 * symmisc.c (print_symbol_bcache_statistics): Update.
13666 (print_objfile_statistics): Update.
13667 * symfile.c (allocate_symtab): Update.
13668 * stabsread.c: Don't include bcache.h.
13669 * psymtab.h (struct psymbol_bcache): Don't declare.
13670 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13671 (psymbol_bcache_init, psymbol_bcache_free)
13672 (psymbol_bcache_get_bcache): Don't declare.
13673 * psymtab.c (struct psymbol_bcache): Remove.
13674 (psymtab_storage::psymtab_storage): Update.
13675 (psymtab_storage::~psymtab_storage): Update.
13676 (psymbol_bcache_init, psymbol_bcache_free)
13677 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13678 (add_psymbol_to_bcache): Update.
13679 (allocate_psymtab): Update.
13680 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13681 macro_cache>: No longer pointers.
13682 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13683 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13684 * macrotab.c (macro_bcache): Update.
13685 * macroexp.c: Don't include bcache.h.
13686 * gdbtypes.c (check_types_worklist): Update.
13687 (types_deeply_equal): Remove TRY/CATCH. Update.
13688 * elfread.c (elf_symtab_read): Update.
13689 * dwarf2read.c: Don't include bcache.h.
13690 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13691 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13692 (print_bcache_statistics, bcache_memory_used): Don't declare.
13693 (struct bcache): Move from bcache.c. Add constructor, destructor,
13694 methods. Rename all data members.
13695 * bcache.c (struct bcache): Move to bcache.h.
13696 (bcache::expand_hash_table): Rename from expand_hash_table.
13697 (bcache): Remove.
13698 (bcache::insert): Rename from bcache_full.
13699 (bcache::compare): Rename from bcache_compare.
13700 (bcache_xmalloc): Remove.
13701 (bcache::~bcache): Rename from bcache_xfree.
13702 (bcache::print_statistics): Rename from print_bcache_statistics.
13703 (bcache::memory_used): Rename from bcache_memory_used.
13704
fe726667
PA
137052019-03-07 Pedro Alves <palves@redhat.com>
13706
13707 * infrun.c (normal_stop): Also check for
13708 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13709
7584bb30
AB
137102019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13711
13712 * f-lang.c (value_from_host_double): Moved to...
13713 * value.c (value_from_host_double): ...here.
13714 * value.h (value_from_host_double): Declare.
13715 * guile/scm-math.c (vlscm_convert_typed_number): Use
13716 value_from_host_double.
13717 (vlscm_convert_number): Likewise.
13718 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13719 * python/py-value.c (convert_value_from_python): Likewise.
13720
a7b1986e
TT
137212019-03-06 Tom Tromey <tom@tromey.com>
13722
13723 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13724
0ccf4211
TT
137252019-03-06 Tom Tromey <tom@tromey.com>
13726
13727 * utils.h (free_current_contents): Don't declare.
13728 * utils.c (free_current_contents): Remove.
13729
fe7b42e5
TT
137302019-03-06 Tom Tromey <tom@tromey.com>
13731
13732 * top.c (quit_force): Update.
13733 * main.c (captured_command_loop): Update.
13734 * common/new-op.c (operator new): Update.
13735 * common/common-exceptions.c (struct catcher)
13736 <save_cleanup_chain>: Remove member.
13737 (exceptions_state_mc_init): Update.
13738 (exception_try_scope_entry): Return nullptr.
13739 (exception_try_scope_exit, exception_rethrow)
13740 (throw_exception_sjlj, throw_exception_cxx): Update.
13741 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13742 (all_cleanups, do_cleanups, discard_cleanups)
13743 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13744 (restore_cleanups, restore_final_cleanups): Don't declare.
13745 (do_final_cleanups): Remove parameter.
13746 * common/cleanups.c (cleanup_chain, make_cleanup)
13747 (make_cleanup_dtor, all_cleanups, do_cleanups)
13748 (discard_my_cleanups, discard_cleanups)
13749 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13750 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13751 (null_cleanup): Remove.
13752 (do_final_cleanups): Remove parameter.
13753
c6321f19
TT
137542019-03-06 Tom Tromey <tom@tromey.com>
13755
13756 * remote.c (remote_target::remote_parse_stop_reply): Use
13757 unique_xmalloc_ptr.
13758
61b30099
TT
137592019-03-06 Tom Tromey <tom@tromey.com>
13760
13761 * stabsread.c (struct stabs_field_info): Rename from field_info.
13762 <list, fnlist>: Add initializers.
13763 <obstack>: New member.
13764 (read_member_functions, read_struct_fields, read_baseclasses):
13765 Allocate on obstack. Don't use cleanups.
13766 (read_one_struct_field, read_member_functions, read_struct_fields)
13767 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13768 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13769 (read_struct_type): Update.
13770
6cceac94
TT
137712019-03-06 Tom Tromey <tom@tromey.com>
13772
13773 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13774 * common/filestuff.h (make_cleanup_close): Don't declare.
13775 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13776 Remove.
13777
72412762
TT
137782019-03-06 Tom Tromey <tom@tromey.com>
13779
13780 * solib-aix.c: Use make_scope_exit.
13781
2b6ff1c0
TT
137822019-03-06 Tom Tromey <tom@tromey.com>
13783
13784 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13785 Use make_scope_exit.
13786
d01c5877
TT
137872019-03-06 Tom Tromey <tom@tromey.com>
13788
13789 * solib-svr4.c (disable_probes_interface): Remove parameter.
13790 (svr4_handle_solib_event): Use make_scope_exit.
13791
32603266
TT
137922019-03-06 Tom Tromey <tom@tromey.com>
13793
13794 * remote.c (struct stop_reply_deleter): Remove.
13795 (stop_reply_up): Update.
13796 (struct stop_reply): Derive from notif_event. Don't typedef.
13797 <regcache>: Now a std::vector.
13798 (stop_reply_xfree): Remove.
13799 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13800 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13801 (remote_target::discard_pending_stop_replies): Use delete.
13802 (remote_target::remote_parse_stop_reply): Update.
13803 (remote_target::process_stop_reply): Update.
13804 * remote-notif.h (struct notif_event): Add virtual destructor.
13805 Remove "dtr" member.
13806 (struct notif_client) <alloc_event>: Return a unique_ptr.
13807 (notif_event_xfree): Don't declare.
13808 (notif_event_up): New typedef.
13809 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13810 (notif_event_xfree, do_notif_event_xfree): Remove.
13811 (remote_notif_state_xfree): Update.
13812
9799571e
TT
138132019-03-06 Tom Tromey <tom@tromey.com>
13814
13815 * infrun.c (displaced_step_clear_cleanup): Now a
13816 forward_scope_exit type.
13817 (displaced_step_prepare_throw): Update.
13818 (displaced_step_fixup): Update.
13819
09e3c4ca
TT
138202019-03-06 Tom Tromey <tom@tromey.com>
13821
13822 * inferior.h (class inferior): Update comment.
13823 * gdbthread.h (class thread_info): Update comment.
13824
e2a03548
TT
138252019-03-06 Joel Brobecker <brobecker@adacore.com>
13826 Tom Tromey <tom@tromey.com>
13827
13828 * stabsread.h (struct stab_section_list): Remove.
13829 (coffstab_build_psymtabs): Update.
13830 * dbxread.c (symbuf_sections): Now a std::vector.
13831 (sect_idx): New global.
13832 (fill_symbuf): Update.
13833 (coffstab_build_psymtabs): Change type of stabsects parameter.
13834 Update.
13835 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13836 std::vector.
13837 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13838 (coff_locate_sections): Update.
13839 (coff_symfile_read): Remove cleanups. Update.
13840 (init_stringtab): Add storage parameter.
13841 (free_stringtab, free_stringtab_cleanup): Remove.
13842 (init_lineno): Add storage parameter.
13843 (free_linetab, free_linetab_cleanup): Remove.
13844
b7e60d85
PA
138452019-03-06 Pedro Alves <palves@redhat.com>
13846
13847 * linux-fork.c (fork_info::clobber_regs): Delete.
13848 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13849 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13850 comment. Adjust.
13851 (scoped_switch_fork_info::scoped_switch_fork_info)
13852 (checkpoint_command, linux_fork_context): Adjust
13853 fork_save_infrun_state calls.
13854
e52c971f
PA
138552019-03-06 Pedro Alves <palves@redhat.com>
13856
13857 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13858 (inf_has_multiple_threads): Return 'bool' and rewrite using
13859 inferior_info::threads().
13860
06974e6c
PA
138612019-03-06 Pedro Alves <palves@redhat.com>
13862
13863 * linux-fork.c: Include <list>.
13864 (fork_list): Now a std::list instance.
13865 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13866 (forks_exist_p, find_last_fork): Adjust.
13867 (new_fork): Delete.
13868 (one_fork_p): New.
13869 (add_fork): Adjust.
13870 (free_fork): Delete, folded into fork_info::~fork_info().
13871 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13872 Adjust.
13873 (init_fork_list): Delete.
13874 (linux_fork_killall, linux_fork_mourn_inferior)
13875 (linux_fork_detach, info_checkpoints_command): Adjust.
13876 (_initialize_linux_fork): No longer call init_fork_list.
13877
72f31aea
PA
138782019-03-06 Pedro Alves <palves@redhat.com>
13879
13880 * linux-fork.c (new_fork): New, split out of ...
13881 (add_fork): ... this. Return void. Move "first fork" special
13882 case from here, to ...
13883 (checkpoint_command): ... here.
13884 * linux-linux.h (add_fork): Return void.
13885
efbecbc1
AB
138862019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13887
13888 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13889
0841c79a
AB
138902019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13891 Chris January <chris.january@arm.com>
13892 David Lecomber <david.lecomber@arm.com>
13893
13894 * f-exp.y: New token, UNOP_INTRINSIC.
13895 (exp): New pattern using UNOP_INTRINSIC token.
13896 (f77_keywords): Add 'abs' keyword.
13897 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13898 (value_from_host_double): New function.
13899 (evaluate_subexp_f): Support UNOP_ABS.
13900
4a270568
AB
139012019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13902
13903 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13904 types.
13905
067630bd
AB
139062019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13907
13908 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13909 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13910 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13911
3be47f7a
AB
139122019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13913
13914 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13915
4d00f5d8
AB
139162019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13917 Chris January <chris.january@arm.com>
13918
13919 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13920 * f-exp.y: Define 'KIND' token.
13921 (exp): New pattern for KIND expressions.
13922 (ptype): Handle types with a kind extension.
13923 (direct_abs_decl): Extend to spot kind extensions.
13924 (f77_keywords): Add 'kind' to the list.
13925 (push_kind_type): New function.
13926 (convert_to_kind_type): New function.
13927 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13928 * parse.c (operator_length_standard): Likewise.
13929 * parser-defs.h (enum type_pieces): Add tp_kind.
13930 * std-operator.def: Add UNOP_KIND.
13931
e454224f
AB
139322019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13933
13934 * f-exp.y (f_parse): Set yydebug.
13935
9dad4a58
AB
139362019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13937
13938 * f-lang.c (evaluate_subexp_f): New function.
13939 (exp_descriptor_f): New global.
13940 (f_language_defn): Use exp_descriptor_f instead of
13941 exp_descriptor_standard.
13942
c8f91604
AB
139432019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13944
13945 * f-exp.y (struct token): Add comments.
13946 (dot_ops): Remove uppercase versions and the end marker.
13947 (f77_keywords): Likewise.
13948 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13949 entries in the dot_ops array are case insensitive, and use
13950 strncasecmp to compare strings. Also some whitespace cleanup in
13951 this area. Similar for the f77_keywords array, except entries in
13952 this list might be case sensitive.
13953
dd9f2c76
AB
139542019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13955
13956 * f-exp.y (struct f77_boolean_val): Add comments.
13957 (boolean_values): Remove uppercase versions, and end marker.
13958 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13959 and use strncasecmp to achieve case insensitivity. Additionally,
13960 perform whitespace cleanup around this code.
13961
67a3048c
TT
139622019-03-06 Tom Tromey <tromey@adacore.com>
13963
13964 * remote-sim.c (gdbsim_target_open): Use result of
13965 gdb_argv::release.
13966
aa3cfbda
RB
139672019-03-06 Richard Bunt <richard.bunt@arm.com>
13968 Dirk Schubert <dirk.schubert@arm.com>
13969 Chris January <chris.january@arm.com>
13970
13971 * eval.c (evaluate_subexp_standard): Call Fortran argument
13972 wrapping logic.
13973 * f-lang.c (struct value): A value which can be passed into a
13974 Fortran function call.
13975 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13976 where appropriate.
13977 (struct type): Value ready for a Fortran function call.
13978 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13979 is needed.
13980 * f-lang.h (fortran_argument_convert): Declaration.
13981 (fortran_preserve_arg_pointer): Declaration.
13982 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13983
ea38e5df
TT
139842019-03-05 Tom Tromey <tromey@adacore.com>
13985
13986 * python/py-prettyprint.c (print_string_repr): Remove #if.
13987 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13988
06b5b831
TT
139892019-03-05 Tom Tromey <tromey@adacore.com>
13990
13991 * target.c (the_dummy_target): Move later. Change type to
13992 "dummy_target".
13993 (initialize_targets): Don't initialize the_dummy_target.
13994
edbd9e45
TT
139952019-03-05 Tom Tromey <tromey@adacore.com>
13996
13997 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13998 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13999
c119e040
TT
140002019-03-05 Tom Tromey <tromey@adacore.com>
14001
14002 * windows-nat.c (windows_nat_target::attach)
14003 (windows_nat_target::detach): Don't call gdb_flush.
14004 * valprint.c (generic_val_print, val_print, val_print_string):
14005 Don't call gdb_flush.
14006 * utils.c (defaulted_query): Don't call gdb_flush.
14007 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14008 * target.c (target_announce_detach): Don't call gdb_flush.
14009 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14010 * remote.c (extended_remote_target::attach): Don't call
14011 gdb_flush.
14012 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14013 * printcmd.c (do_examine): Don't call gdb_flush.
14014 (info_display_command): Don't call gdb_flush.
14015 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14016 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14017 * memattr.c (info_mem_command): Don't call gdb_flush.
14018 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14019 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14020 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14021 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14022 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14023 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14024 (gnu_nat_target::detach): Don't call gdb_flush.
14025 * f-valprint.c (f_val_print): Don't call gdb_flush.
14026 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14027 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14028 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14029 gdb_flush.
14030 * c-valprint.c (c_val_print): Don't call gdb_flush.
14031 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14032
895dafa6
TT
140332019-03-05 Tom Tromey <tromey@adacore.com>
14034
14035 * varobj.c (update_dynamic_varobj_children): Update.
14036 (install_default_visualizer): Use reset, not release.
14037 * value.c (set_internalvar): Update.
14038 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14039 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14040 ATTRIBUTE_UNUSED_RESULT.
14041
88a774b9
TT
140422019-03-05 Tom Tromey <tromey@adacore.com>
14043
14044 * remote.c (class scoped_remote_fd) <release>: Add
14045 ATTRIBUTE_UNUSED_RESULT.
14046
4e4a8b93
TT
140472019-03-05 Tom Tromey <tromey@adacore.com>
14048
14049 * macroexp.c (struct macro_buffer) <release>: Add
14050 ATTRIBUTE_UNUSED_RESULT.
14051
083eef1f
TT
140522019-03-05 Tom Tromey <tromey@adacore.com>
14053
14054 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14055 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14056 ATTRIBUTE_UNUSED_RESULT.
14057
3cabd438
TT
140582019-03-05 Tom Tromey <tromey@adacore.com>
14059
14060 * common/scoped_fd.h (class scoped_fd) <release>: Add
14061 ATTRIBUTE_UNUSED_RESULT.
14062
41e3300a
TT
140632019-03-05 Tom Tromey <tromey@adacore.com>
14064
14065 * parser-defs.h (struct parser_state) <release>: Add
14066 ATTRIBUTE_UNUSED_RESULT.
14067
18cb7c9f
TT
140682019-03-05 Tom Tromey <tromey@adacore.com>
14069
14070 * utils.h (class gdb_argv) <release>: Add
14071 ATTRIBUTE_UNUSED_RESULT.
14072 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14073
41fa577f
EZ
140742019-03-02 Eli Zaretskii <eliz@gnu.org>
14075
a6a4b2c6
EZ
14076 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14077 for-loop range, to avoid compiler warnings.
14078
14079 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14080 avoid compiler warnings about unused variables.
14081
742a7df5
EZ
14082 * NEWS: Mention end of support for native debugging on MS-Windows
14083 before XP.
14084
41fa577f
EZ
14085 PR gdb/24292
14086 * common/netstuff.c:
14087 * gdbserver/gdbreplay.c
14088 * gdbserver/remote-utils.c:
14089 * ser-tcp.c:
14090 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14091 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14092 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14093 'getaddrinfo' and 'freeaddrinfo' were not available before
14094 Windows XP, and mingw.org's MinGW headers by default define
14095 _WIN32_WINNT to 0x500.
14096
827f438f
GB
140972019-03-01 Gary Benson <gbenson@redhat.com>
14098
14099 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14100
92137da0
RO
141012019-02-28 Brian Vandenberg <phantall@gmail.com>
14102 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14103
14104 PR gdb/8527
14105 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14106 set_sigint_trap, clear_sigint_trap.
14107
799efbe8
PW
141082019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14109
14110 * target.c (target_detach): Clear the regcache and the
14111 frame cache.
14112
8ed25214
PA
141132019-02-27 Pedro Alves <palves@redhat.com>
14114
14115 * utils.c (set_screen_size): When we cap the height/width sizes,
14116 tweak the corresponding command variable to show "unlimited":
14117
23031e31
SJ
141182019-02-27 Saagar Jha <saagar@saagarjha.com>
14119 Pedro Alves <palves@redhat.com>
14120
14121 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14122 before calling rl_set_screen_size.
14123
6c28e44a
TT
141242019-02-27 Tom Tromey <tromey@adacore.com>
14125
14126 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14127 define.
14128 * python/py-value.c: Remove Python 2.4 workaround.
14129 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14130 workaround.
14131 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14132 Python 2.4 workaround.
14133 * python/python-internal.h: Remove Python 2.4 comment.
14134 (Py_ssize_t): Don't define.
14135 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14136 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14137 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14138 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14139 * python/python.c (do_start_initialization): Remove Python 2.4
14140 workaround.
14141 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14142 (print_children): Remove Python 2.4 workaround.
14143 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14144 workaround.
14145 (CHARBUFFERPROC_NAME): Remove.
14146 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14147 Python 2.4 workaround.
14148
2c3fc25d 141492019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14150
2c3fc25d
KB
14151 * NEWS: Note minimum Python version.
14152
6ca62222
KB
141532019-02-27 Kevin Buettner <kevinb@redhat.com>
14154
14155 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14156 code from these functions. Remove corresponding ifdefs. Use
14157 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14158 Remove gotos and target of gotos.
14159 (infpy_search_memory): Likewise.
14160
f4bc7d2c
AB
141612019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14162
14163 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14164 (hppa_gdbarch_init): Don't register deleted functions with
14165 gdbarch.
14166
9734a586
AB
141672019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14168
14169 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14170 (h8300_unwind_sp): Delete.
14171 (h8300_dummy_id): Delete.
14172 (h8300_gdbarch_init): Don't register deleted functions with
14173 gdbarch.
14174
68b867f3
AB
141752019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14176
14177 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14178 (ft32_unwind_pc): Delete.
14179 (ft32_unwind_sp): Delete.
14180 (ft32_gdbarch_init): Don't register deleted functions with
14181 gdbarch.
14182
2fbe7ad0
AB
141832019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14184
14185 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14186 (frv_unwind_pc): Delete.
14187 (frv_unwind_sp): Delete.
14188 (frv_gdbarch_init): Don't register deleted functions with
14189 gdbarch.
14190
76055cbe
AB
141912019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14192
14193 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14194 (riscv_unwind_pc): Delete.
14195 (riscv_unwind_sp): Delete.
14196 (riscv_gdbarch_init): Don't register deleted functions with
14197 gdbarch.
14198
4133e5a1
AB
141992019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14200
14201 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14202 (csky_unwind_pc): Delete.
14203 (csky_unwind_sp): Delete.
14204 (csky_gdbarch_init): Don't register deleted functions with
14205 gdbarch.
14206
8010f576
AB
142072019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14208
14209 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14210 (cris_unwind_pc): Delete.
14211 (cris_unwind_sp): Delete.
14212 (cris_gdbarch_init): Don't register deleted functions with
14213 gdbarch.
14214
b56bf084
AB
142152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14216
14217 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14218 (bfin_unwind_pc): Delete.
14219 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14220
a19a650f
AB
142212019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14222
14223 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14224 (arm_unwind_pc): Delete.
14225 (arm_unwind_sp): Delete.
14226 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14227
f8278c3c
AB
142282019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14229
14230 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14231 (arc_unwind_pc): Delete.
14232 (arc_unwind_sp): Delete.
14233 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14234
480e46cf
AB
142352019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14236
14237 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14238 (alpha_unwind_pc): Delete.
14239 (alpha_gdbarch_init): Don't register deleted functions with
14240 gdbarch.
14241
7a995095
AB
142422019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14243
14244 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14245 (aarch64_unwind_pc): Delete.
14246 (aarch64_unwind_sp): Delete.
14247 (aarch64_gdbarch_init): Don't register deleted functions with
14248 gdbarch.
14249
bf9a735e
AB
142502019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14251
14252 * gdbtypes.c (type_align): Don't consider static members when
14253 computing structure alignment.
14254
5561fc30
AB
142552019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14256
14257 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14258 return 0 for other types.
14259 * arch-utils.c (default_type_align): Always return 0.
14260 * gdbarch.h: Regenerate.
14261 * gdbarch.sh (type_align): Extend comment.
14262 * gdbtypes.c (type_align): Add additional comments, always call
14263 gdbarch_type_align before applying the default rules.
14264 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14265 generic code will then apply a suitable default.
14266 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14267 types, return 0 for other types.
14268
9335e75a
JB
142692019-02-27 Joel Brobecker <brobecker@adacore.com>
14270
14271 * NEWS: Create a new section for the next release branch.
14272 Rename the section of the current branch, now that it has
14273 been cut.
14274
3d34d8de
JB
142752019-02-27 Joel Brobecker <brobecker@adacore.com>
14276
14277 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14278 * version.in: Bump version to 8.3.50.DATE-git.
14279
143420fb
SM
142802019-02-26 Simon Marchi <simon.marchi@efficios.com>
14281
14282 * aix-thread.c (ptid_cmp): Remove unused variable.
14283 (get_signaled_thread): Likewise.
14284 (store_regs_user_thread): Likewise.
14285 (store_regs_kernel_thread): Likewise.
14286 (fetch_regs_kernel_thread): Remove shadowed variable.
14287
172fb711
AB
142882019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14289
14290 * features/riscv/32bit-cpu.xml: Add register numbers.
14291 * features/riscv/32bit-fpu.c: Regenerate.
14292 * features/riscv/32bit-fpu.xml: Add register numbers.
14293 * features/riscv/64bit-cpu.xml: Add register numbers.
14294 * features/riscv/64bit-fpu.c: Regenerate.
14295 * features/riscv/64bit-fpu.xml: Add register numbers.
14296
26c89782
KB
142972019-02-26 Kevin Buettner <kevinb@redhat.com>
14298
af54ade9 14299 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14300 * python/py-value.c (convert_buffer_and_type_to_value): New
14301 function.
14302 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14303 Add support for handling an optional second argument. Call
14304 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14305 * python/python-internal.h (Py_buffer_deleter): New struct.
14306 (Py_buffer_up): New typedef.
14307
0f58c9e8
JB
143082019-02-25 John Baldwin <jhb@FreeBSD.org>
14309
14310 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14311 instead of releasing ownership.
14312
0a0f4c01
JR
143132019-02-25 Jordan Rupprecht <rupprecht@google.com>
14314
14315 * dwarf2read.c (open_and_init_dwp_file): Call
14316 elf_numsections instead of bfd_count_sections to initialize
14317 dwp_file->num_sections.
14318
cd5a152c
TT
143192019-02-25 Tom Tromey <tromey@adacore.com>
14320
14321 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14322
8a6a8513
SDJ
143232019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14324
14325 * gcore.in: Add '--readnever' option when invoking GDB.
14326
04dcda9c
SM
143272019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14328
14329 * MAINTAINERS: Update my email address.
14330
07bc701d
SM
143312019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14332
14333 * build-id.c (build_id_to_debug_bfd_1): New function.
14334 (build_id_to_debug_bfd): Look for separate debug file in
14335 sysroot.
14336
c6f4a5d0
AB
143372019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14338
14339 * gdbarch.sh: Update the copyright year range that is placed into
14340 generated files.
14341
9600246d
KS
143422019-02-22 Keith Seitz <keiths@redhat.com>
14343
14344 PR symtab/23853
14345 * linespec.c (create_sals_line_offset): Search for the default
14346 symtab's filename instead of its fullname.
14347
7557a514
AH
143482019-02-21 Alan Hayward <alan.hayward@arm.com>
14349
14350 * NEWS: Update style defaults.
14351
ee2bcb0c
AH
143522019-02-21 Alan Hayward <alan.hayward@arm.com>
14353
14354 * main.c (captured_main_1): Disable styling in batch mode.
14355
0c95f9ed
TT
143562019-02-20 Tom Tromey <tom@tromey.com>
14357
14358 * symtab.c (symtab_symbol_info): Fix typos.
14359
c763b894
TT
143602019-02-20 Tom Tromey <tromey@adacore.com>
14361
14362 * findcmd.c (_initialize_mem_search): Use upper case for
14363 metasyntactic variables.
14364
0ef8a082
AH
143652019-02-20 Alan Hayward <alan.hayward@arm.com>
14366
14367 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14368 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14369
6caa91b6
SM
143702019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14371
14372 * top.h (source_file_name): Change to std::string.
14373 * top.c (source_file_name): Likewise.
14374 (command_line_input): Adjust.
14375 * cli/cli-script.c (script_from_file): Adjust.
14376
98814c6c
TT
143772019-02-19 Tom Tromey <tromey@adacore.com>
14378
14379 * ravenscar-thread.c
14380 (ravenscar_thread_target::update_thread_list): Don't call
14381 ada_build_task_list.
14382 * ada-lang.h (ada_build_task_list): Don't declare.
14383 * ada-tasks.c (struct ada_tasks_inferior_data)
14384 <task_list_valid_p>: Now bool.
14385 (read_known_tasks, ada_task_list_changed)
14386 (ada_tasks_invalidate_inferior_data): Update.
14387 (read_known_tasks_array): Return bool.
14388 (read_known_tasks_list): Likewise.
14389 (read_known_tasks): Return void.
14390 (ada_build_task_list): Now static.
14391
70cd633e
AB
143922019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14393
14394 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14395 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14396
040b3e95
PW
143972019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14398
14399 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14400 variant for ada_tasks_pspace_data_handle and
14401 ada_tasks_inferior_data_handle.
14402 (ada_tasks_pspace_data_cleanup): New function.
14403 (ada_tasks_inferior_data_cleanup): New function.
14404
9409233b
TT
144052019-02-17 Tom Tromey <tom@tromey.com>
14406
14407 * macrotab.h (macro_source_fullname): Return a std::string.
14408 * macrotab.c (macro_include, check_for_redefinition)
14409 (macro_undef, macro_lookup_definition, foreach_macro)
14410 (foreach_macro_in_scope): Update.
14411 (macro_source_fullname): Return a std::string.
14412 * macrocmd.c (show_pp_source_pos): Update.
14413
6506371f
TT
144142019-02-17 Tom Tromey <tom@tromey.com>
14415
14416 * macrocmd.c (show_pp_source_pos): Style the file names.
14417
0c820d67
TT
144182019-02-17 Tom Tromey <tom@tromey.com>
14419
14420 PR tui/24197:
14421 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14422
a0087920
TT
144232019-02-17 Tom Tromey <tom@tromey.com>
14424
14425 * ada-lang.c (user_select_syms): Use filtered printing.
14426 * utils.c (wrap_style): New global.
14427 (desired_style): Remove.
14428 (emit_style_escape): Add stream parameter.
14429 (set_output_style, reset_terminal_style, prompt_for_continue):
14430 Update.
14431 (flush_wrap_buffer): Only flush gdb_stdout.
14432 (wrap_here): Set wrap_style.
14433 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14434 treat escape sequences as a character. Change when wrap buffer is
14435 flushed.
14436 (fputs_styled): Do not set the output style when the default is
14437 requested.
14438 * ui-style.h (struct ui_file_style) <is_default>: New method.
14439 * source.c (print_source_lines_base): Emit escape sequences in one
14440 piece.
14441
75ba10dc
JB
144422019-02-17 Joel Brobecker <brobecker@adacore.com>
14443
14444 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14445 integers and enumeration types.
14446
a2cd4f14
JB
144472019-02-17 Joel Brobecker <brobecker@adacore.com>
14448
14449 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14450 instead of lookup_symbol_in_language
14451 (do_exact_match): New function.
14452 (ada_get_symbol_name_matcher): Return do_exact_match when
14453 doing a verbatim match.
14454
485b851b
TT
144552019-02-15 Tom Tromey <tromey@adacore.com>
14456
14457 * ravenscar-thread.c (ravenscar_thread_target::resume)
14458 (ravenscar_thread_target::wait): Special case wildcard requests.
14459
0b790b1e
TT
144602019-02-15 Tom Tromey <tromey@adacore.com>
14461
14462 * ravenscar-thread.c (base_ptid): Remove.
14463 (struct ravenscar_thread_target) <close>: New method.
14464 <m_base_ptid>: New member.
14465 <update_inferior_ptid, active_task, task_is_currently_active,
14466 runtime_initialized>: Declare methods.
14467 <ravenscar_thread_target>: Add constructor.
14468 (ravenscar_thread_target::task_is_currently_active)
14469 (ravenscar_thread_target::update_inferior_ptid)
14470 (ravenscar_runtime_initialized): Rename. Now methods.
14471 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14472 (ravenscar_thread_target::update_thread_list): Update.
14473 (ravenscar_thread_target::active_task): Now method.
14474 (ravenscar_thread_target::store_registers)
14475 (ravenscar_thread_target::prepare_to_store)
14476 (ravenscar_thread_target::prepare_to_store)
14477 (ravenscar_thread_target::mourn_inferior): Update.
14478 (ravenscar_inferior_created): Use "new" to create target.
14479 (ravenscar_thread_target::get_ada_task_ptid): Update.
14480 (_initialize_ravenscar): Don't initialize base_ptid.
14481 (ravenscar_ops): Remove global.
14482
dea57a62
TT
144832019-02-15 Tom Tromey <tromey@adacore.com>
14484
14485 * target.h (push_target): Declare new overload.
14486 * target.c (push_target): New overload, taking an rvalue reference.
14487 * remote.c (remote_target::open_1): Use push_target overload.
14488 * corelow.c (core_target_open): Use push_target overload.
14489
989f3c58
TT
144902019-02-15 Tom Tromey <tromey@adacore.com>
14491
14492 * ravenscar-thread.c (is_ravenscar_task)
14493 (ravenscar_task_is_currently_active): Return bool.
14494 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14495 (_initialize_ravenscar): Remove "(void)".
14496 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14497 Return bool.
14498
6cbcc006
TT
144992019-02-15 Tom Tromey <tromey@adacore.com>
14500
14501 * ravenscar-thread.c (ravenscar_runtime_initializer)
14502 (has_ravenscar_runtime, get_running_thread_id)
14503 (ravenscar_thread_target::resume): Fix indentation.
14504
7657f14d
TT
145052019-02-15 Tom Tromey <tromey@adacore.com>
14506
14507 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14508 from ravenscar_arch_ops.
14509 (sparc_ravenscar_ops::fetch_registers)
14510 (sparc_ravenscar_ops::store_registers): Now methods.
14511 (sparc_ravenscar_prepare_to_store): Remove.
14512 (sparc_ravenscar_ops): Redefine.
14513 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14514 methods and destructor. Remove members.
14515 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14516 (ravenscar_thread_target::store_registers)
14517 (ravenscar_thread_target::prepare_to_store): Update.
14518 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14519 Remove.
14520 (struct ppc_ravenscar_powerpc_ops): Derive from
14521 ravenscar_arch_ops.
14522 (ppc_ravenscar_powerpc_ops::fetch_registers)
14523 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14524 (ppc_ravenscar_powerpc_ops): Redefine.
14525 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14526 (ppc_ravenscar_e500_ops::fetch_registers)
14527 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14528 (ppc_ravenscar_e500_ops): Redefine.
14529 * aarch64-ravenscar-thread.c
14530 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14531 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14532 (aarch64_ravenscar_fetch_registers)
14533 (aarch64_ravenscar_store_registers): Now methods.
14534 (aarch64_ravenscar_ops): Redefine.
14535
5b6ea500
TT
145362019-02-15 Tom Tromey <tromey@adacore.com>
14537
14538 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14539 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14540 (ravenscar_thread_target::stopped_by_watchpoint)
14541 (ravenscar_thread_target::stopped_data_address)
14542 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14543
e397fd39
TT
145442019-02-15 Tom Tromey <tromey@adacore.com>
14545
14546 * ravenscar-thread.c: Fix some typos.
14547
cc12f4a8
TT
145482019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14549 Tom Tromey <tromey@adacore.com>
14550
14551 * ada-lang.c (ada_exception_sal): Change addr_string to a
14552 std::string.
14553 (create_ada_exception_catchpoint): Update.
14554
5f486660
TT
145552019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14556 Tom Tromey <tromey@adacore.com>
14557
14558 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14559 (bp_location_ops): Remove.
14560 (base_breakpoint_allocate_location): Update.
14561 (free_bp_location): Update.
14562 * ada-lang.c (class ada_catchpoint_location)
14563 <ada_catchpoint_location>: Remove ops parameter.
14564 (ada_catchpoint_location_dtor): Remove.
14565 (ada_catchpoint_location_ops): Remove.
14566 (allocate_location_exception): Update.
14567 * breakpoint.h (struct bp_location_ops): Remove.
14568 (class bp_location) <bp_location>: Remove bp_location_ops
14569 parameter.
14570 <~bp_location>: Add destructor.
14571 <ops>: Remove.
14572
b671c7fb
TS
145732019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14574 Pedro Alves <palves@redhat.com>
14575
14576 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14577 'PATH_MAX'.
14578
8071c5ce
DM
145792019-02-14 David Michael <fedora.dm0@gmail.com>
14580 Samuel Thibault <samuel.thibault@gnu.org>
14581 Thomas Schwinge <thomas@codesourcery.com>
14582
14583 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14584 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14585
b1041ae0
TS
145862019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14587
924514e1
TS
14588 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14589 (check_empty): Use "const char *".
14590
c29ee8d4
TS
14591 * gnu-nat.c (gnu_nat_target::detach): Instead of
14592 'detach_inferior (pid)' call
14593 'detach_inferior (find_inferior_pid (pid))'.
14594
6c6ef69f
TS
14595 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14596 'nat/fork-inferior.o'.
14597 * gnu-nat.c: #include "nat/fork-inferior.h".
14598
2d0a338c
TS
14599 * gnu-nat.c (gnu_nat_target::detach): Instead of
14600 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14601 * gnu-nat.h: #include "inf-child.h".
14602 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14603 'i386_gnu_nat_target::fetch_registers'.
14604 (gnu_store_registers): Rename/move to
14605 'i386_gnu_nat_target::store_registers'.
14606
cabb5f06
TS
14607 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14608 * gnu-nat.h (mach_thread_info): New function.
14609 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14610
b1041ae0
TS
14611 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14612
2988d01e
KF
146132019-02-14 Frederic Konrad <konrad@adacore.com>
14614
14615 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14616
c559d709
JB
146172019-02-14 Joel Brobecker <brobecker@adacore.com>
14618
14619 * windows-nat.c (windows_add_thread): Add new parameter
14620 "main_thread_p" with default value set to false. Update
14621 function documentation as well as all callers.
14622 (windows_delete_thread): Likewise.
14623 (fake_create_process): Update call to windows_add_thread.
14624 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14625 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14626 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14627 call to windows_delete_thread.
14628
007024cc
SM
146292019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14630
14631 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14632
f62318e9
JB
146332019-02-12 John Baldwin <jhb@FreeBSD.org>
14634
14635 * symfile.c (find_separate_debug_file): Use canonical path of
14636 sysroot with child_path instead of gdb_sysroot if it is valid.
14637
cd4b7848
JB
146382019-02-12 John Baldwin <jhb@FreeBSD.org>
14639
14640 * symfile.c (find_separate_debug_file): Use child_path to
14641 determine if an object file is under a sysroot.
14642
efac4bfe
JB
146432019-02-12 John Baldwin <jhb@FreeBSD.org>
14644
14645 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14646 unittests/child-path-selftests.c.
14647 * common/pathstuff.c (child_path): New function.
14648 * common/pathstuff.h (child_path): New prototype.
14649 * unittests/child-path-selftests.c: New file.
14650
402d2bfe
JB
146512019-02-12 John Baldwin <jhb@FreeBSD.org>
14652
14653 * symfile.c (find_separate_debug_file): Look for separate debug
14654 files in debug directories under the sysroot.
14655
1ed9f74e
PW
146562019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14657
14658 * symtab.h (struct minimal_symbol data_p): New const method.
14659 (struct minimal_symbol text_p): Likewise.
14660 * symtab.c (output_source_filename): Use file name style
14661 to print file name.
14662 (print_symbol_info): Likewise.
14663 (print_msymbol_info): Use address style to print addresses.
14664 Use function name style to print executable text symbols.
14665 (expand_symtab_containing_pc): Use data_p.
14666 (find_pc_sect_compunit_symtab): Likewise.
14667
2636d81d
PW
146682019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14669
14670 * breakpoint.c (describe_other_breakpoints): Use address style
14671 to print addresses.
14672 (say_where): Likewise.
14673
ac8c53cc
PW
146742019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14675
14676 * ada-typeprint.c (print_func_type): Print function name
14677 style to print function name.
14678 * c-typeprint.c (c_print_type_1): Likewise.
14679
ea638c43
AH
146802019-02-11 Alan Hayward <alan.hayward@arm.com>
14681
14682 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14683 for execve.
14684
ab759ca8
PW
146852019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14686
14687 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14688 type_stack.
14689
aff29d1c
JB
146902019-02-10 Joel Brobecker <brobecker@adacore.com>
14691
14692 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14693 TYPE_CODE_REF types.
14694
617126bc
JW
146952019-02-08 Jim Wilson <jimw@sifive.com>
14696
14697 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14698 (riscv_linux_fregset): New.
14699 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14700
46e3ed7f
TT
147012019-02-07 Tom Tromey <tom@tromey.com>
14702
14703 * thread.c (thread_cancel_execution_command): Update.
14704 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14705 methods.
14706 (struct thread_fsm_ops): Remove.
14707 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14708 (thread_fsm_should_stop, thread_fsm_return_value)
14709 (thread_fsm_set_finished, thread_fsm_finished_p)
14710 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14711 Don't declare.
14712 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14713 * infrun.c (clear_proceed_status_thread)
14714 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14715 (print_stop_event): Update.
14716 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14717 Add constructor.
14718 (step_command_fsm_ops): Remove.
14719 (new_step_command_fsm): Remove.
14720 (step_1): Update.
14721 (step_command_fsm::should_stop): Rename from
14722 step_command_fsm_should_stop.
14723 (step_command_fsm::clean_up): Rename from
14724 step_command_fsm_clean_up.
14725 (step_command_fsm::do_async_reply_reason): Rename from
14726 step_command_fsm_async_reply_reason.
14727 (struct until_next_fsm): Inherit from thread_fsm. Add
14728 constructor.
14729 (until_next_fsm_ops): Remove.
14730 (new_until_next_fsm): Remove.
14731 (until_next_fsm::should_stop): Rename from
14732 until_next_fsm_should_stop.
14733 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14734 (until_next_fsm::do_async_reply_reason): Rename from
14735 until_next_fsm_async_reply_reason.
14736 (struct finish_command_fsm): Inherit from thread_fsm. Add
14737 constructor. Change type of breakpoint.
14738 (finish_command_fsm_ops): Remove.
14739 (new_finish_command_fsm): Remove.
14740 (finish_command_fsm::should_stop): Rename from
14741 finish_command_fsm_should_stop.
14742 (finish_command_fsm::clean_up): Rename from
14743 finish_command_fsm_clean_up.
14744 (finish_command_fsm::return_value): Rename from
14745 finish_command_fsm_return_value.
14746 (finish_command_fsm::do_async_reply_reason): Rename from
14747 finish_command_fsm_async_reply_reason.
14748 (finish_command): Update.
14749 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14750 Add constructor.
14751 (call_thread_fsm_ops): Remove.
14752 (call_thread_fsm::call_thread_fsm): Rename from
14753 new_call_thread_fsm.
14754 (call_thread_fsm::should_stop): Rename from
14755 call_thread_fsm_should_stop.
14756 (call_thread_fsm::should_notify_stop): Rename from
14757 call_thread_fsm_should_notify_stop.
14758 (run_inferior_call, call_function_by_hand_dummy): Update.
14759 * cli/cli-interp.c (should_print_stop_to_console): Update.
14760 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14761 Add constructor. Change type of location_breakpoint,
14762 caller_breakpoint.
14763 (until_break_fsm_ops): Remove.
14764 (new_until_break_fsm): Remove.
14765 (until_break_fsm::should_stop): Rename from
14766 until_break_fsm_should_stop.
14767 (until_break_fsm::clean_up): Rename from
14768 until_break_fsm_clean_up.
14769 (until_break_fsm::do_async_reply_reason): Rename from
14770 until_break_fsm_async_reply_reason.
14771 (until_break_command): Update.
14772 * thread-fsm.c: Remove.
14773 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14774
1a5c2598
TT
147752019-02-07 Tom Tromey <tom@tromey.com>
14776
14777 * yy-remap.h: Add include guard.
14778 * xtensa-tdep.h: Add include guard.
14779 * xcoffread.h: Rename include guard.
14780 * varobj-iter.h: Add include guard.
14781 * tui/tui.h: Rename include guard.
14782 * tui/tui-winsource.h: Rename include guard.
14783 * tui/tui-wingeneral.h: Rename include guard.
14784 * tui/tui-windata.h: Rename include guard.
14785 * tui/tui-win.h: Rename include guard.
14786 * tui/tui-stack.h: Rename include guard.
14787 * tui/tui-source.h: Rename include guard.
14788 * tui/tui-regs.h: Rename include guard.
14789 * tui/tui-out.h: Rename include guard.
14790 * tui/tui-layout.h: Rename include guard.
14791 * tui/tui-io.h: Rename include guard.
14792 * tui/tui-hooks.h: Rename include guard.
14793 * tui/tui-file.h: Rename include guard.
14794 * tui/tui-disasm.h: Rename include guard.
14795 * tui/tui-data.h: Rename include guard.
14796 * tui/tui-command.h: Rename include guard.
14797 * tic6x-tdep.h: Add include guard.
14798 * target/waitstatus.h: Rename include guard.
14799 * target/wait.h: Rename include guard.
14800 * target/target.h: Rename include guard.
14801 * target/resume.h: Rename include guard.
14802 * target-float.h: Rename include guard.
14803 * stabsread.h: Add include guard.
14804 * rs6000-tdep.h: Add include guard.
14805 * riscv-fbsd-tdep.h: Add include guard.
14806 * regformats/regdef.h: Rename include guard.
14807 * record.h: Rename include guard.
14808 * python/python.h: Rename include guard.
14809 * python/python-internal.h: Rename include guard.
14810 * python/py-stopevent.h: Rename include guard.
14811 * python/py-ref.h: Rename include guard.
14812 * python/py-record.h: Rename include guard.
14813 * python/py-record-full.h: Rename include guard.
14814 * python/py-record-btrace.h: Rename include guard.
14815 * python/py-instruction.h: Rename include guard.
14816 * python/py-events.h: Rename include guard.
14817 * python/py-event.h: Rename include guard.
14818 * procfs.h: Add include guard.
14819 * proc-utils.h: Add include guard.
14820 * p-lang.h: Add include guard.
14821 * or1k-tdep.h: Rename include guard.
14822 * observable.h: Rename include guard.
14823 * nto-tdep.h: Rename include guard.
14824 * nat/x86-linux.h: Rename include guard.
14825 * nat/x86-linux-dregs.h: Rename include guard.
14826 * nat/x86-gcc-cpuid.h: Add include guard.
14827 * nat/x86-dregs.h: Rename include guard.
14828 * nat/x86-cpuid.h: Rename include guard.
14829 * nat/ppc-linux.h: Rename include guard.
14830 * nat/mips-linux-watch.h: Rename include guard.
14831 * nat/linux-waitpid.h: Rename include guard.
14832 * nat/linux-ptrace.h: Rename include guard.
14833 * nat/linux-procfs.h: Rename include guard.
14834 * nat/linux-osdata.h: Rename include guard.
14835 * nat/linux-nat.h: Rename include guard.
14836 * nat/linux-namespaces.h: Rename include guard.
14837 * nat/linux-btrace.h: Rename include guard.
14838 * nat/glibc_thread_db.h: Rename include guard.
14839 * nat/gdb_thread_db.h: Rename include guard.
14840 * nat/gdb_ptrace.h: Rename include guard.
14841 * nat/fork-inferior.h: Rename include guard.
14842 * nat/amd64-linux-siginfo.h: Rename include guard.
14843 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14844 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14845 * nat/aarch64-linux.h: Rename include guard.
14846 * nat/aarch64-linux-hw-point.h: Rename include guard.
14847 * mn10300-tdep.h: Add include guard.
14848 * mips-linux-tdep.h: Add include guard.
14849 * mi/mi-parse.h: Rename include guard.
14850 * mi/mi-out.h: Rename include guard.
14851 * mi/mi-main.h: Rename include guard.
14852 * mi/mi-interp.h: Rename include guard.
14853 * mi/mi-getopt.h: Rename include guard.
14854 * mi/mi-console.h: Rename include guard.
14855 * mi/mi-common.h: Rename include guard.
14856 * mi/mi-cmds.h: Rename include guard.
14857 * mi/mi-cmd-break.h: Rename include guard.
14858 * m2-lang.h: Add include guard.
14859 * location.h: Rename include guard.
14860 * linux-record.h: Rename include guard.
14861 * linux-nat.h: Add include guard.
14862 * linux-fork.h: Add include guard.
14863 * i386-darwin-tdep.h: Rename include guard.
14864 * hppa-linux-offsets.h: Add include guard.
14865 * guile/guile.h: Rename include guard.
14866 * guile/guile-internal.h: Rename include guard.
14867 * gnu-nat.h: Rename include guard.
14868 * gdb-stabs.h: Rename include guard.
14869 * frv-tdep.h: Add include guard.
14870 * f-lang.h: Add include guard.
14871 * event-loop.h: Add include guard.
14872 * darwin-nat.h: Rename include guard.
14873 * cp-abi.h: Rename include guard.
14874 * config/sparc/nm-sol2.h: Rename include guard.
14875 * config/nm-nto.h: Rename include guard.
14876 * config/nm-linux.h: Add include guard.
14877 * config/i386/nm-i386gnu.h: Rename include guard.
14878 * config/djgpp/nl_types.h: Rename include guard.
14879 * config/djgpp/langinfo.h: Rename include guard.
14880 * compile/gcc-cp-plugin.h: Add include guard.
14881 * compile/gcc-c-plugin.h: Add include guard.
14882 * compile/compile.h: Rename include guard.
14883 * compile/compile-object-run.h: Rename include guard.
14884 * compile/compile-object-load.h: Rename include guard.
14885 * compile/compile-internal.h: Rename include guard.
14886 * compile/compile-cplus.h: Rename include guard.
14887 * compile/compile-c.h: Rename include guard.
14888 * common/xml-utils.h: Rename include guard.
14889 * common/x86-xstate.h: Rename include guard.
14890 * common/version.h: Rename include guard.
14891 * common/vec.h: Rename include guard.
14892 * common/tdesc.h: Rename include guard.
14893 * common/selftest.h: Rename include guard.
14894 * common/scoped_restore.h: Rename include guard.
14895 * common/scoped_mmap.h: Rename include guard.
14896 * common/scoped_fd.h: Rename include guard.
14897 * common/safe-iterator.h: Rename include guard.
14898 * common/run-time-clock.h: Rename include guard.
14899 * common/refcounted-object.h: Rename include guard.
14900 * common/queue.h: Rename include guard.
14901 * common/ptid.h: Rename include guard.
14902 * common/print-utils.h: Rename include guard.
14903 * common/preprocessor.h: Rename include guard.
14904 * common/pathstuff.h: Rename include guard.
14905 * common/observable.h: Rename include guard.
14906 * common/netstuff.h: Rename include guard.
14907 * common/job-control.h: Rename include guard.
14908 * common/host-defs.h: Rename include guard.
14909 * common/gdb_wait.h: Rename include guard.
14910 * common/gdb_vecs.h: Rename include guard.
14911 * common/gdb_unlinker.h: Rename include guard.
14912 * common/gdb_unique_ptr.h: Rename include guard.
14913 * common/gdb_tilde_expand.h: Rename include guard.
14914 * common/gdb_sys_time.h: Rename include guard.
14915 * common/gdb_string_view.h: Rename include guard.
14916 * common/gdb_splay_tree.h: Rename include guard.
14917 * common/gdb_setjmp.h: Rename include guard.
14918 * common/gdb_ref_ptr.h: Rename include guard.
14919 * common/gdb_optional.h: Rename include guard.
14920 * common/gdb_locale.h: Rename include guard.
14921 * common/gdb_assert.h: Rename include guard.
14922 * common/filtered-iterator.h: Rename include guard.
14923 * common/filestuff.h: Rename include guard.
14924 * common/fileio.h: Rename include guard.
14925 * common/environ.h: Rename include guard.
14926 * common/common-utils.h: Rename include guard.
14927 * common/common-types.h: Rename include guard.
14928 * common/common-regcache.h: Rename include guard.
14929 * common/common-inferior.h: Rename include guard.
14930 * common/common-gdbthread.h: Rename include guard.
14931 * common/common-exceptions.h: Rename include guard.
14932 * common/common-defs.h: Rename include guard.
14933 * common/common-debug.h: Rename include guard.
14934 * common/cleanups.h: Rename include guard.
14935 * common/buffer.h: Rename include guard.
14936 * common/btrace-common.h: Rename include guard.
14937 * common/break-common.h: Rename include guard.
14938 * cli/cli-utils.h: Rename include guard.
14939 * cli/cli-style.h: Rename include guard.
14940 * cli/cli-setshow.h: Rename include guard.
14941 * cli/cli-script.h: Rename include guard.
14942 * cli/cli-interp.h: Rename include guard.
14943 * cli/cli-decode.h: Rename include guard.
14944 * cli/cli-cmds.h: Rename include guard.
14945 * charset-list.h: Add include guard.
14946 * buildsym-legacy.h: Rename include guard.
14947 * bfin-tdep.h: Add include guard.
14948 * ax.h: Rename include guard.
14949 * arm-linux-tdep.h: Add include guard.
14950 * arm-fbsd-tdep.h: Add include guard.
14951 * arch/xtensa.h: Rename include guard.
14952 * arch/tic6x.h: Add include guard.
14953 * arch/i386.h: Add include guard.
14954 * arch/arm.h: Rename include guard.
14955 * arch/arm-linux.h: Rename include guard.
14956 * arch/arm-get-next-pcs.h: Rename include guard.
14957 * arch/amd64.h: Add include guard.
14958 * arch/aarch64-insn.h: Rename include guard.
14959 * arch-utils.h: Rename include guard.
14960 * annotate.h: Add include guard.
14961 * amd64-darwin-tdep.h: Rename include guard.
14962 * aarch64-linux-tdep.h: Add include guard.
14963 * aarch64-fbsd-tdep.h: Add include guard.
14964 * aarch32-linux-nat.h: Add include guard.
14965
ab9268d2
PW
149662019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14967
14968 * macrotab.c (macro_define_internal): New function that
14969 factorizes macro_define_object_internal and macro_define_function
14970 code.
14971 (macro_define_object_internal): Use macro_define_internal.
14972 (macro_define_function): Likewise.
14973
bb0da2b4
PW
149742019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14975
14976 * macrocmd.c (extract_identifier): Return
14977 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14978 callers.
14979
424eb552
JB
149802019-02-06 John Baldwin <jhb@FreeBSD.org>
14981
14982 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14983
1688cb29
TT
149842019-02-05 Tom Tromey <tom@tromey.com>
14985
14986 * target.c (target_stack::unpush): Move assertion earlier.
14987
b5eba2d8
TT
149882019-01-30 Tom Tromey <tom@tromey.com>
14989
14990 PR python/23615:
14991 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14992 (gdbpy_parse_and_eval): Likewise.
14993 * python/python-internal.h (gdbpy_allow_threads): New class.
14994
7054e2ff
JB
149952019-01-28 John Baldwin <jhb@FreeBSD.org>
14996
14997 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14998 (aarch64_fbsd_fpregmap): Move earlier.
14999 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15000 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15001 instead of individual calls to trad_frame_set_reg_addr.
15002 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15003 earlier.
15004 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15005 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15006 instead of individual calls to trad_frame_set_reg_addr.
15007
36c25ffa
AH
150082019-01-28 Alan Hayward <alan.hayward@arm.com>
15009
15010 * CONTRIBUTE: Replace contribution list with wiki link.
15011
a0707f3c
TT
150122019-01-25 Tom Tromey <tom@tromey.com>
15013
15014 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15015
0747795c
TT
150162019-01-25 Tom Tromey <tom@tromey.com>
15017
15018 * xtensa-linux-nat.c: Fix common/ includes.
15019 * xml-support.h: Fix common/ includes.
15020 * xml-support.c: Fix common/ includes.
15021 * x86-linux-nat.c: Fix common/ includes.
15022 * windows-nat.c: Fix common/ includes.
15023 * varobj.h: Fix common/ includes.
15024 * varobj.c: Fix common/ includes.
15025 * value.c: Fix common/ includes.
15026 * valops.c: Fix common/ includes.
15027 * utils.c: Fix common/ includes.
15028 * unittests/xml-utils-selftests.c: Fix common/ includes.
15029 * unittests/utils-selftests.c: Fix common/ includes.
15030 * unittests/unpack-selftests.c: Fix common/ includes.
15031 * unittests/tracepoint-selftests.c: Fix common/ includes.
15032 * unittests/style-selftests.c: Fix common/ includes.
15033 * unittests/string_view-selftests.c: Fix common/ includes.
15034 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15035 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15036 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15037 * unittests/rsp-low-selftests.c: Fix common/ includes.
15038 * unittests/parse-connection-spec-selftests.c: Fix common/
15039 includes.
15040 * unittests/optional-selftests.c: Fix common/ includes.
15041 * unittests/offset-type-selftests.c: Fix common/ includes.
15042 * unittests/observable-selftests.c: Fix common/ includes.
15043 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15044 * unittests/memrange-selftests.c: Fix common/ includes.
15045 * unittests/memory-map-selftests.c: Fix common/ includes.
15046 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15047 * unittests/function-view-selftests.c: Fix common/ includes.
15048 * unittests/environ-selftests.c: Fix common/ includes.
15049 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15050 * unittests/common-utils-selftests.c: Fix common/ includes.
15051 * unittests/cli-utils-selftests.c: Fix common/ includes.
15052 * unittests/array-view-selftests.c: Fix common/ includes.
15053 * ui-file.c: Fix common/ includes.
15054 * tui/tui-io.c: Fix common/ includes.
15055 * tracepoint.h: Fix common/ includes.
15056 * tracepoint.c: Fix common/ includes.
15057 * tracefile-tfile.c: Fix common/ includes.
15058 * top.h: Fix common/ includes.
15059 * top.c: Fix common/ includes.
15060 * thread.c: Fix common/ includes.
15061 * target/waitstatus.h: Fix common/ includes.
15062 * target/waitstatus.c: Fix common/ includes.
15063 * target.h: Fix common/ includes.
15064 * target.c: Fix common/ includes.
15065 * target-memory.c: Fix common/ includes.
15066 * target-descriptions.c: Fix common/ includes.
15067 * symtab.h: Fix common/ includes.
15068 * symfile.c: Fix common/ includes.
15069 * stap-probe.c: Fix common/ includes.
15070 * spu-linux-nat.c: Fix common/ includes.
15071 * sparc-nat.c: Fix common/ includes.
15072 * source.c: Fix common/ includes.
15073 * solib.c: Fix common/ includes.
15074 * solib-target.c: Fix common/ includes.
15075 * ser-unix.c: Fix common/ includes.
15076 * ser-tcp.c: Fix common/ includes.
15077 * ser-pipe.c: Fix common/ includes.
15078 * ser-base.c: Fix common/ includes.
15079 * selftest-arch.c: Fix common/ includes.
15080 * s12z-tdep.c: Fix common/ includes.
15081 * rust-exp.y: Fix common/ includes.
15082 * rs6000-aix-tdep.c: Fix common/ includes.
15083 * riscv-tdep.c: Fix common/ includes.
15084 * remote.c: Fix common/ includes.
15085 * remote-notif.h: Fix common/ includes.
15086 * remote-fileio.h: Fix common/ includes.
15087 * remote-fileio.c: Fix common/ includes.
15088 * regcache.h: Fix common/ includes.
15089 * regcache.c: Fix common/ includes.
15090 * record-btrace.c: Fix common/ includes.
15091 * python/python.c: Fix common/ includes.
15092 * python/py-type.c: Fix common/ includes.
15093 * python/py-inferior.c: Fix common/ includes.
15094 * progspace.h: Fix common/ includes.
15095 * producer.c: Fix common/ includes.
15096 * procfs.c: Fix common/ includes.
15097 * proc-api.c: Fix common/ includes.
15098 * printcmd.c: Fix common/ includes.
15099 * ppc-linux-nat.c: Fix common/ includes.
15100 * parser-defs.h: Fix common/ includes.
15101 * osdata.c: Fix common/ includes.
15102 * obsd-nat.c: Fix common/ includes.
15103 * nat/x86-linux.c: Fix common/ includes.
15104 * nat/x86-linux-dregs.c: Fix common/ includes.
15105 * nat/x86-dregs.h: Fix common/ includes.
15106 * nat/x86-dregs.c: Fix common/ includes.
15107 * nat/ppc-linux.c: Fix common/ includes.
15108 * nat/mips-linux-watch.h: Fix common/ includes.
15109 * nat/mips-linux-watch.c: Fix common/ includes.
15110 * nat/linux-waitpid.c: Fix common/ includes.
15111 * nat/linux-ptrace.h: Fix common/ includes.
15112 * nat/linux-ptrace.c: Fix common/ includes.
15113 * nat/linux-procfs.c: Fix common/ includes.
15114 * nat/linux-personality.c: Fix common/ includes.
15115 * nat/linux-osdata.c: Fix common/ includes.
15116 * nat/linux-namespaces.c: Fix common/ includes.
15117 * nat/linux-btrace.h: Fix common/ includes.
15118 * nat/linux-btrace.c: Fix common/ includes.
15119 * nat/fork-inferior.c: Fix common/ includes.
15120 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15121 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15122 * nat/aarch64-linux.c: Fix common/ includes.
15123 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15124 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15125 * namespace.h: Fix common/ includes.
15126 * mips-linux-tdep.c: Fix common/ includes.
15127 * minsyms.c: Fix common/ includes.
15128 * mi/mi-parse.h: Fix common/ includes.
15129 * mi/mi-main.c: Fix common/ includes.
15130 * mi/mi-cmd-env.c: Fix common/ includes.
15131 * memrange.h: Fix common/ includes.
15132 * memattr.c: Fix common/ includes.
15133 * maint.h: Fix common/ includes.
15134 * maint.c: Fix common/ includes.
15135 * main.c: Fix common/ includes.
15136 * machoread.c: Fix common/ includes.
15137 * location.c: Fix common/ includes.
15138 * linux-thread-db.c: Fix common/ includes.
15139 * linux-nat.c: Fix common/ includes.
15140 * linux-fork.c: Fix common/ includes.
15141 * inline-frame.c: Fix common/ includes.
15142 * infrun.c: Fix common/ includes.
15143 * inflow.c: Fix common/ includes.
15144 * inferior.h: Fix common/ includes.
15145 * inferior.c: Fix common/ includes.
15146 * infcmd.c: Fix common/ includes.
15147 * inf-ptrace.c: Fix common/ includes.
15148 * inf-child.c: Fix common/ includes.
15149 * ia64-linux-nat.c: Fix common/ includes.
15150 * i387-tdep.c: Fix common/ includes.
15151 * i386-tdep.c: Fix common/ includes.
15152 * i386-linux-tdep.c: Fix common/ includes.
15153 * i386-linux-nat.c: Fix common/ includes.
15154 * i386-go32-tdep.c: Fix common/ includes.
15155 * i386-fbsd-tdep.c: Fix common/ includes.
15156 * i386-fbsd-nat.c: Fix common/ includes.
15157 * guile/scm-type.c: Fix common/ includes.
15158 * guile/guile.c: Fix common/ includes.
15159 * go32-nat.c: Fix common/ includes.
15160 * gnu-nat.c: Fix common/ includes.
15161 * gdbthread.h: Fix common/ includes.
15162 * gdbarch-selftests.c: Fix common/ includes.
15163 * gdb_usleep.c: Fix common/ includes.
15164 * gdb_select.h: Fix common/ includes.
15165 * gdb_bfd.c: Fix common/ includes.
15166 * gcore.c: Fix common/ includes.
15167 * fork-child.c: Fix common/ includes.
15168 * findvar.c: Fix common/ includes.
15169 * fbsd-nat.c: Fix common/ includes.
15170 * event-top.c: Fix common/ includes.
15171 * event-loop.c: Fix common/ includes.
15172 * dwarf2read.c: Fix common/ includes.
15173 * dwarf2loc.c: Fix common/ includes.
15174 * dwarf2-frame.c: Fix common/ includes.
15175 * dwarf-index-cache.c: Fix common/ includes.
15176 * dtrace-probe.c: Fix common/ includes.
15177 * disasm-selftests.c: Fix common/ includes.
15178 * defs.h: Fix common/ includes.
15179 * csky-tdep.c: Fix common/ includes.
15180 * cp-valprint.c: Fix common/ includes.
15181 * cp-support.h: Fix common/ includes.
15182 * cp-support.c: Fix common/ includes.
15183 * corelow.c: Fix common/ includes.
15184 * completer.h: Fix common/ includes.
15185 * completer.c: Fix common/ includes.
15186 * compile/compile.c: Fix common/ includes.
15187 * compile/compile-loc2c.c: Fix common/ includes.
15188 * compile/compile-cplus-types.c: Fix common/ includes.
15189 * compile/compile-cplus-symbols.c: Fix common/ includes.
15190 * command.h: Fix common/ includes.
15191 * cli/cli-dump.c: Fix common/ includes.
15192 * cli/cli-cmds.c: Fix common/ includes.
15193 * charset.c: Fix common/ includes.
15194 * build-id.c: Fix common/ includes.
15195 * btrace.h: Fix common/ includes.
15196 * btrace.c: Fix common/ includes.
15197 * breakpoint.h: Fix common/ includes.
15198 * breakpoint.c: Fix common/ includes.
15199 * ax.h:
15200 (enum agent_op): Fix common/ includes.
15201 * ax-general.c (struct aop_map): Fix common/ includes.
15202 * ax-gdb.c: Fix common/ includes.
15203 * auxv.c: Fix common/ includes.
15204 * auto-load.c: Fix common/ includes.
15205 * arm-tdep.c: Fix common/ includes.
15206 * arch/riscv.c: Fix common/ includes.
15207 * arch/ppc-linux-common.c: Fix common/ includes.
15208 * arch/i386.c: Fix common/ includes.
15209 * arch/arm.c: Fix common/ includes.
15210 * arch/arm-linux.c: Fix common/ includes.
15211 * arch/arm-get-next-pcs.c: Fix common/ includes.
15212 * arch/amd64.c: Fix common/ includes.
15213 * arch/aarch64.c: Fix common/ includes.
15214 * arch/aarch64-insn.c: Fix common/ includes.
15215 * arch-utils.c: Fix common/ includes.
15216 * amd64-windows-tdep.c: Fix common/ includes.
15217 * amd64-tdep.c: Fix common/ includes.
15218 * amd64-sol2-tdep.c: Fix common/ includes.
15219 * amd64-obsd-tdep.c: Fix common/ includes.
15220 * amd64-nbsd-tdep.c: Fix common/ includes.
15221 * amd64-linux-tdep.c: Fix common/ includes.
15222 * amd64-linux-nat.c: Fix common/ includes.
15223 * amd64-fbsd-tdep.c: Fix common/ includes.
15224 * amd64-fbsd-nat.c: Fix common/ includes.
15225 * amd64-dicos-tdep.c: Fix common/ includes.
15226 * amd64-darwin-tdep.c: Fix common/ includes.
15227 * agent.c: Fix common/ includes.
15228 * ada-lang.h: Fix common/ includes.
15229 * ada-lang.c: Fix common/ includes.
15230 * aarch64-tdep.c: Fix common/ includes.
15231
2f5c153e
TT
152322019-01-25 Tom Tromey <tom@tromey.com>
15233
15234 * common/create-version.sh: Use common/version.h.
15235
adc6a863
PA
152362019-01-24 Pedro Alves <palves@redhat.com>
15237
15238 * infrun.c (signal_stop, signal_print, signal_program)
15239 (signal_catch, signal_pass): Now arrays instead of pointers.
15240 (update_signals_program_target, do_target_resume)
15241 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15242 * linux-nat.c (linux_nat_target::pass_signals)
15243 (linux_nat_target::create_inferior, linux_nat_target::attach):
15244 Adjust.
15245 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15246 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15247 * procfs.c (procfs_target::pass_signals): Adjust.
15248 * record-full.c (record_full_target::resume): Adjust.
15249 * remote.c (remote_target::pass_signals)
15250 (remote_target::program_signals): Adjust.
15251 * target-debug.h (target_debug_print_signals): Now takes a
15252 gdb::array_view as parameter. Adjust.
15253 * target.h (target_ops) <pass_signals, program_signals>: Replace
15254 pointer and length parameters with gdb::array_view.
15255 (target_pass_signals, target_program_signals): Likewise.
15256 * target-delegates.c: Regenerate.
15257
3046d67a
PA
152582019-01-24 Pedro Alves <palves@redhat.com>
15259
15260 * common/forward-scope-exit.h
15261 (forward_scope_exit::forward_scope_exit): Pass arguments to
15262 m_bind_function directly, instead of creating a std::bind and
15263 copying that.
15264
353229bf
AH
152652019-01-24 Alan Hayward <alan.hayward@arm.com>
15266
15267 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15268 for static members.
15269 (pass_in_v_vfp_candidate): Likewise.
15270
311dc83a
TT
152712019-01-23 Tom Tromey <tom@tromey.com>
15272 Pedro Alves <palves@redhat.com>
15273
15274 * regcache.c (class regcache_invalidator): Remove.
15275 (regcache::raw_write): Use make_scope_exit.
15276
296bd123
TT
152772019-01-23 Tom Tromey <tom@tromey.com>
15278
15279 * ui-out.h (class ui_out_emit_type): Update comment.
15280
979a0d13
TT
152812019-01-23 Tom Tromey <tom@tromey.com>
15282
15283 * infrun.c (fetch_inferior_event): Update comment.
15284
d238133d
TT
152852019-01-23 Tom Tromey <tom@tromey.com>
15286 Pedro Alves <palves@redhat.com>
15287
15288 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15289 parameter.
15290 (fetch_inferior_event): Use SCOPE_EXIT.
15291
15292
9885e6bb
TT
152932019-01-23 Tom Tromey <tom@tromey.com>
15294 Pedro Alves <palves@redhat.com>
15295
15296 * infrun.c (disable_thread_events): Delete.
15297 (stop_all_threads): Use SCOPE_EXIT.
15298
286526c1
TT
152992019-01-23 Tom Tromey <tom@tromey.com>
15300 Pedro Alves <palves@redhat.com>
15301
15302 * symfile.c: Include forward-scope-exit.h.
15303 (clear_symtab_users_cleanup): Replace forward declaration with
15304 a FORWARD_SCOPE_EXIT.
15305 (syms_from_objfile_1): Use the forward_scope_exit and
15306 gdb::optional instead of cleanup_function.
15307 (reread_symbols): Use the forward_scope_exit instead of
15308 cleanup_function.
15309 (clear_symtab_users_cleanup): Remove function.
15310
1db93f14
TT
153112019-01-23 Tom Tromey <tom@tromey.com>
15312 Pedro Alves <palves@redhat.com>
15313
15314 * linux-nat.c: Include scope-exit.h.
15315 (cleanup_target_stop): Remove.
15316 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15317 SCOPE_EXIT.
15318
2cc83d1e
TT
153192019-01-23 Tom Tromey <tom@tromey.com>
15320 Pedro Alves <palves@redhat.com>
15321
15322 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15323 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15324
694c6bf5
TT
153252019-01-23 Tom Tromey <tom@tromey.com>
15326 Andrew Burgess <andrew.burgess@embecosm.com>
15327 Pedro Alves <palves@redhat.com>
15328
15329 * infrun.c (fetch_inferior_event): Use scope_exit.
15330 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15331 * top.c (execute_command): Use scope_exit.
15332 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15333 * utils.c (do_bpstat_clear_actions_cleanup)
15334 (make_bpstat_clear_actions_cleanup): Remove.
15335
4c41382a
TT
153362019-01-23 Tom Tromey <tom@tromey.com>
15337 Pedro Alves <palves@redhat.com>
15338
15339 * infrun.c: Include "common/scope-exit.h"
15340 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15341 (wait_for_inferior): Use SCOPE_EXIT.
15342 (fetch_inferior_event): Use scope_exit.
15343
89f8fb50
TT
153442019-01-23 Tom Tromey <tom@tromey.com>
15345 Pedro Alves <palves@redhat.com>
15346
15347 * breakpoint.c (create_breakpoint): Remove cleanup.
15348
5419bdae
TT
153492019-01-23 Tom Tromey <tom@tromey.com>
15350 Andrew Burgess <andrew.burgess@embecosm.com>
15351 Pedro Alves <palves@redhat.com>
15352
e587ef42
PA
153532019-01-23 Pedro Alves <palves@redhat.com>
15354
15355 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15356
77f0e74c
PA
153572019-01-23 Pedro Alves <palves@redhat.com>
15358 Andrew Burgess <andrew.burgess@embecosm.com>
15359
15360 * gdbthread.h: Include "common/forward-scope-exit.h".
15361 (scoped_finish_thread_state): Redefine custom class in terms of
15362 forward_scope_exit.
15363
5b9b3e53
PA
153642019-01-23 Pedro Alves <palves@redhat.com>
15365 Andrew Burgess <andrew.burgess@embecosm.com>
15366
15367 * common/forward-scope-exit.h: New file.
15368
54b65c9b
PA
153692019-01-23 Pedro Alves <palves@redhat.com>
15370 Andrew Burgess <andrew.burgess@embecosm.com>
15371 Tom Tromey <tom@tromey.com>
15372
15373 * common/scope-exit.h: New file.
15374
cf08fb29
PA
153752019-01-23 Pedro Alves <palves@redhat.com>
15376
15377 * common/preprocessor.h (ESC): Rename to ...
15378 (ESC_PARENS): ... this.
15379 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15380 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15381
ae73e2e2
TT
153822019-01-23 Tom Tromey <tom@tromey.com>
15383
15384 * language.h (class scoped_switch_to_sym_language_if_auto):
15385 Initialize m_lang in both cases.
15386
6594e122
AH
153872019-01-23 Alan Hayward <alan.hayward@arm.com>
15388
15389 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15390 with XCNEW.
15391
a7c9855d
TT
153922019-01-22 Tom Tromey <tom@tromey.com>
15393
15394 * corelow.c: Do not include sys/file.h.
15395
93cc1d53
TT
153962019-01-22 Tom Tromey <tom@tromey.com>
15397
15398 * tui/tui-wingeneral.h: Include gdb_curses.h.
15399
38561778
TT
154002019-01-22 Tom Tromey <tom@tromey.com>
15401
15402 * source-cache.h (class source_cache) <get_source_lines,
15403 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15404
37b3ab5b
TT
154052019-01-22 Tom Tromey <tom@tromey.com>
15406
15407 * remote-fileio.h (struct remote_target): Declare.
15408
3fabc016
TT
154092019-01-22 Tom Tromey <tom@tromey.com>
15410
15411 * python/py-arch.c: Do not include py-ref.h.
15412 * python/py-bpevent.c: Do not include py-ref.h.
15413 * python/py-cmd.c: Do not include py-ref.h.
15414 * python/py-continueevent.c: Do not include py-ref.h.
15415 * python/py-event.h: Do not include py-ref.h.
15416 * python/py-evtregistry.c: Do not include py-ref.h.
15417 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15418 * python/py-frame.c: Do not include py-ref.h.
15419 * python/py-framefilter.c: Do not include py-ref.h.
15420 * python/py-function.c: Do not include py-ref.h.
15421 * python/py-infevents.c: Do not include py-ref.h.
15422 * python/py-linetable.c: Do not include py-ref.h.
15423 * python/py-objfile.c: Do not include py-ref.h.
15424 * python/py-param.c: Do not include py-ref.h.
15425 * python/py-prettyprint.c: Do not include py-ref.h.
15426 * python/py-progspace.c: Do not include py-ref.h.
15427 * python/py-symbol.c: Do not include py-ref.h.
15428 * python/py-symtab.c: Do not include py-ref.h.
15429 * python/py-type.c: Do not include py-ref.h.
15430 * python/py-unwind.c: Do not include py-ref.h.
15431 * python/py-utils.c: Do not include py-ref.h.
15432 * python/py-value.c: Do not include py-ref.h.
15433 * python/py-varobj.c: Do not include py-ref.h.
15434 * python/py-xmethods.c: Do not include py-ref.h.
15435 * python/python.c: Do not include py-ref.h.
15436 * varobj.c: Do not include py-ref.h.
15437
6b4d7774
TT
154382019-01-22 Tom Tromey <tom@tromey.com>
15439
15440 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15441 keyword for bcache.
15442
7af7e9b5
TT
154432019-01-22 Tom Tromey <tom@tromey.com>
15444
15445 * compile/compile-cplus-types.c: Remove a comment by #include.
15446
951d1049
TT
154472019-01-22 Tom Tromey <tom@tromey.com>
15448
15449 * compile/gcc-c-plugin.h: Include compile-internal.h.
15450
d65d5705
TT
154512019-01-22 Tom Tromey <tom@tromey.com>
15452
15453 * stabsread.c (EXTERN): Do not define.
15454 (symnum, next_symbol_text_func, processing_gcc_compilation)
15455 (within_function, global_sym_chain, global_stabs)
15456 (previous_stab_code, this_object_header_files)
15457 (n_this_object_header_files)
15458 (n_allocated_this_object_header_files): Define.
15459 * stabsread.h (EXTERN): Never define. Use "extern".
15460
b6fb1ee5
PW
154612019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15462
15463 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15464 history_value.
15465
be6d4f74
TT
154662019-01-21 Tom Tromey <tom@tromey.com>
15467
15468 * ui-out.c: Fix includes.
15469 * tui/tui-source.c: Fix includes.
15470 * target.c: Fix includes.
15471 * remote.c: Fix includes.
15472 * regcache.c: Fix includes.
15473 * python/py-block.c: Fix includes.
15474 * printcmd.c: Fix includes.
15475 * or1k-tdep.c: Fix includes.
15476 * mi/mi-main.c: Fix includes.
15477 * m32r-tdep.c: Fix includes.
15478 * csky-tdep.c: Fix includes.
15479 * compile/compile-cplus-types.c: Fix includes.
15480 * cli/cli-interp.c: Fix includes.
15481
73021deb
AH
154822019-01-21 Alan Hayward <alan.hayward@arm.com>
15483
15484 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15485 for padding.
15486
7932255d
TT
154872019-01-16 Tom Tromey <tom@tromey.com>
15488
15489 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15490 earlier.
15491 (struct objfile) <msymbols_range>: Move from top level.
15492 <msymbols>: New method.
15493 (class objfile_msymbols): Remove.
15494 * symtab.c (default_collect_symbol_completion_matches_break_on):
15495 Update.
15496 * symmisc.c (dump_msymbols): Update.
15497 * stabsread.c (scan_file_globals): Update.
15498 * objc-lang.c (info_selectors_command, info_classes_command)
15499 (find_methods): Update.
15500 * minsyms.c (find_solib_trampoline_target): Update.
15501 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15502 * coffread.c (coff_symfile_read): Update.
15503 * ada-lang.c (ada_lookup_simple_minsym)
15504 (ada_collect_symbol_completion_matches): Update.
15505
604b1bfb
TT
155062019-01-16 Tom Tromey <tom@tromey.com>
15507
15508 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15509 type. Remove no-argument constructor.
15510 <iterator::operator++>: Simplify.
15511 <begin>: Update.
15512 <end>: Use minimal_symbol_count.
15513
f252c6d5
TT
155142019-01-16 Tom Tromey <tom@tromey.com>
15515
15516 * objfiles.h (struct objfile) <psymtabs>: New method.
15517 (class objfile_psymtabs): Remove.
15518 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15519 typedef.
15520 <range>: New method.
15521 (require_partial_symbols): Change return type.
15522 * psymtab.c (require_partial_symbols)
15523 (psym_expand_symtabs_matching): Update.
15524 * mdebugread.c (parse_partial_symbols): Update.
15525 * dbxread.c (dbx_end_psymtab): Update.
15526
b669c953
TT
155272019-01-15 Tom Tromey <tom@tromey.com>
15528
15529 * symtab.c (lookup_objfile_from_block)
15530 (lookup_symbol_in_objfile_symtabs)
15531 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15532 (find_line_symtab, info_sources_command)
15533 (default_collect_symbol_completion_matches_break_on)
15534 (make_source_files_completion_list): Update.
15535 * symmisc.c (print_objfile_statistics, dump_objfile)
15536 (maintenance_print_symbols, maintenance_info_symtabs)
15537 (maintenance_check_symtabs, maintenance_info_line_tables):
15538 Update.
15539 * source.c (select_source_symtab)
15540 (forget_cached_source_info_for_objfile): Update.
15541 * objfiles.h (class objfile_compunits): Remove.
15542 (struct objfile) <compunits_range>: New typedef.
15543 (compunits): New method.
15544 * objfiles.c (objfile_relocate1): Update.
15545 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15546 * maint.c (count_symtabs_and_blocks): Update.
15547 * linespec.c (iterate_over_all_matching_symtabs): Update.
15548 * cp-support.c (add_symbol_overload_list_qualified): Update.
15549 * coffread.c (coff_symtab_read): Update.
15550 * ada-lang.c (add_nonlocal_symbols)
15551 (ada_collect_symbol_completion_matches)
15552 (ada_add_global_exceptions): Update.
15553
7e955d83
TT
155542019-01-15 Tom Tromey <tom@tromey.com>
15555
15556 * progspace.h (program_space) <objfiles_safe_range>: New
15557 typedef.
15558 <objfiles_safe>: New method.
15559 * objfiles.h (class all_objfiles_safe): Remove.
15560 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15561 * jit.c (jit_inferior_exit_hook): Update.
15562
2030c079
TT
155632019-01-17 Tom Tromey <tom@tromey.com>
15564
15565 * progspace.h (program_space) <objfiles_range>: New typedef.
15566 <objfiles>: New method.
15567 <objfiles_head>: Rename from objfiles.
15568 (object_files): Update.
15569 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15570 * guile/scm-pretty-print.c
15571 (ppscm_find_pretty_printer_from_objfiles): Update.
15572 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15573 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15574 Update.
15575 * python/py-progspace.c (pspy_get_objfiles): Update.
15576 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15577 Update.
15578 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15579 (objfpy_lookup_objfile_by_build_id): Update.
15580 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15581 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15582 Update.
15583 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15584 (expand_symtab_containing_pc, lookup_objfile_from_block)
15585 (lookup_static_symbol, basic_lookup_transparent_type)
15586 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15587 (find_line_symtab, info_sources_command)
15588 (default_collect_symbol_completion_matches_break_on)
15589 (make_source_files_completion_list, find_main_name): Update.
15590 * symmisc.c (print_symbol_bcache_statistics)
15591 (print_objfile_statistics, maintenance_print_symbols)
15592 (maintenance_print_msymbols, maintenance_print_objfiles)
15593 (maintenance_info_symtabs, maintenance_check_symtabs)
15594 (maintenance_expand_symtabs, maintenance_info_line_tables):
15595 Update.
15596 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15597 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15598 (map_overlay_command, unmap_overlay_command)
15599 (simple_overlay_update, expand_symtabs_matching)
15600 (map_symbol_filenames): Update.
15601 * symfile-debug.c (set_debug_symfile): Update.
15602 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15603 Update.
15604 * source.c (select_source_symtab, forget_cached_source_info):
15605 Update.
15606 * solib.c (solib_read_symbols): Update.
15607 * solib-spu.c (append_ocl_sos): Update.
15608 * psymtab.c (maintenance_print_psymbols)
15609 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15610 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15611 * printcmd.c (info_symbol_command): Update.
15612 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15613 Update.
15614 * objfiles.h (class all_objfiles): Remove.
15615 * objfiles.c (have_partial_symbols, have_full_symbols)
15616 (have_minimal_symbols, qsort_cmp, update_section_map)
15617 (shared_objfile_contains_address_p)
15618 (default_iterate_over_objfiles_in_search_order): Update.
15619 * objc-lang.c (info_selectors_command, info_classes_command)
15620 (find_methods): Update.
15621 * minsyms.c (find_solib_trampoline_target): Update.
15622 * maint.c (maintenance_info_sections)
15623 (maintenance_translate_address, count_symtabs_and_blocks):
15624 Update.
15625 * main.c (captured_main_1): Update.
15626 * linux-thread-db.c (try_thread_db_load_from_pdir)
15627 (has_libpthread): Update.
15628 * linespec.c (iterate_over_all_matching_symtabs)
15629 (search_minsyms_for_name): Update.
15630 * jit.c (jit_find_objf_with_entry_addr): Update.
15631 * hppa-tdep.c (find_unwind_entry)
15632 (hppa_lookup_stub_minimal_symbol): Update.
15633 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15634 Update.
15635 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15636 (elf_gnu_ifunc_resolve_by_got): Update.
15637 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15638 * dwarf-index-write.c (save_gdb_index_command): Update.
15639 * cp-support.c (add_symbol_overload_list_qualified): Update.
15640 * breakpoint.c (create_overlay_event_breakpoint)
15641 (create_longjmp_master_breakpoint)
15642 (create_std_terminate_master_breakpoint)
15643 (create_exception_master_breakpoint): Update.
15644 * blockframe.c (find_pc_partial_function): Update.
15645 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15646 (ada_collect_symbol_completion_matches)
15647 (ada_add_global_exceptions): Update.
15648
776489e0
TT
156492019-01-17 Tom Tromey <tom@tromey.com>
15650
15651 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15652 declare VEC.
15653 (solib_target_parse_libraries): Change return type.
15654 (library_list_start_segment, library_list_start_section)
15655 (library_list_end_library, library_list_start_library); Update.
15656 (solib_target_free_library_list): Remove.
15657 (solib_target_parse_libraries): Remove cleanup. Change return
15658 type.
15659 (solib_target_current_sos): Update.
15660
6471e7d2
TT
156612019-01-17 Tom Tromey <tromey@bapiya>
15662
15663 * valprint.c: Replace "the the" with "the".
15664 * symtab.c: Replace "the the" with "the".
15665 * solib.c: Replace "the the" with "the".
15666 * solib-dsbt.c: Replace "the the" with "the".
15667 * linespec.c: Replace "the the" with "the".
15668 * dwarf2loc.h: Replace "the the" with "the".
15669 * amd64-windows-tdep.c: Replace "the the" with "the".
15670 * aarch64-tdep.c: Replace "the the" with "the".
15671
c24bdb02
KS
156722019-01-16 Keith Seitz <keiths@redhat.com>
15673
15674 PR gdb/23773
15675 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15676 <builder>: Rename to ..
15677 <m_builder>: ... this and make private.
15678 (dwarf2_cu::get_builder): New method. Change all users of
15679 `builder' to use this method.
15680 (dwarf2_start_symtab): Move to ...
15681 (dwarf2_cu::start_symtab): ... here. Update all callers
15682 (setup_type_unit_groups): Move to ...
15683 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15684 callers.
15685 (dwarf2_cu::reset_builder): New method.
15686 (process_full_compunit, process_full_type_unit): Use
15687 dwarf2_cu::reset_builder.
15688 (follow_die_offset): Record the ancestor CU if it is different
15689 from the followed DIE's CU.
15690 (follow_die_sig_1): Likewise.
15691
8d64371b
TT
156922019-01-15 Tom Tromey <tom@tromey.com>
15693
15694 * remote.c (class remote_state) <buf>: Now a char_vector.
15695 <buf_size>: Remove.
15696 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15697 parameter.
15698 (remote_target::getpkt_or_notif_sane_1)
15699 (remote_target::getpkt_sane)
15700 (remote_target::getpkt_or_notif_sane): Likewise.
15701 (class remote_target) <putpkt>: New overload.
15702 (remote_target::read_frame): Change type of "buf_p". Remove
15703 sizeof_p parameter.
15704 (packet_ok): New overload.
15705 (packet_check_result): New overload.
15706 Update all uses.
15707
bb277751
TT
157082019-01-14 Tom Tromey <tom@tromey.com>
15709
15710 * remote-notif.c (handle_notification, remote_notif_ack)
15711 (remote_notif_parse): Make "buf" const.
15712 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15713 const.
15714 (remote_notif_parse, remote_notif_ack, handle_notification):
15715 Likewise.
15716 * remote.c (remote_notif_stop_parse): Make "buf" const.
15717 (remote_target::remote_parse_stop_reply): Make "buf" const.
15718 (remote_notif_stop_ack): Make "buf" const.
15719
05be00a8
TT
157202019-01-14 Tom Tromey <tom@tromey.com>
15721
15722 * remote.c (remote_console_output): Make parameter const.
15723
491adeca
TT
157242019-01-14 Tom Tromey <tom@tromey.com>
15725
15726 * target-debug.h (target_debug_print_signals): Constify.
15727 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15728 * procfs.c (procfs_target::pass_signals): Update.
15729 * linux-nat.c (linux_nat_target::pass_signals): Update.
15730 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15731 * target-delegates.c: Rebuild.
15732 * remote.c (remote_target::program_signals): Update.
15733 (remote_target::pass_signals): Update.
15734 * target.c (target_pass_signals): Constify argument.
15735 (target_program_signals): Likewise.
15736 * target.h (struct target_ops) <pass_signals, program_signals>:
15737 Constify argument.
15738 (target_pass_signals, target_program_signals): Constify argument.
15739
bbd94648
TT
157402019-01-14 Tom Tromey <tom@tromey.com>
15741
15742 PR tui/28819:
15743 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15744
6f072a10
PFC
157452019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15746
15747 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15748 field.
15749 * rs6000-tdep.c: Include reggroups.h.
15750 (IS_V_ALIAS_PSEUDOREG): Define.
15751 (rs6000_register_name): Return names for the "vX" aliases.
15752 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15753 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15754 aliases. Call default_register_reggroup_p for all other
15755 pseudo-registers.
15756 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15757 New functions.
15758 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15759 Handle "vX" aliases.
15760 (v_alias_pseudo_register_collect): New function.
15761 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15762 (rs6000_gdbarch_init): Initialize "vX" aliases as
15763 pseudo-registers. Restore registration of
15764 rs6000_pseudo_register_reggroup_p with
15765 set_tdesc_pseudo_register_reggroup_p.
15766
1a782351
MF
157672019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15768
15769 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15770 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15771 set_gdbarch_num_pseudo_regs.
15772
d73cff18
PW
157732019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15774
15775 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15776 Remove arg prefixname, add do_set and do_show.
15777 Add member functions set_list and show_list.
15778 * cli/cli-style.c (class cli_style_option): Update accordingly.
15779 (style_set_list): Move to file scope.
15780 (style_show_list): Likewise.
15781 (set_style): Call help_list.
15782 (show_style): Call cmd_show_list.
15783 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15784 Update to use the new macro.
15785
60a90376
JB
157862019-10-12 Joel Brobecker <brobecker@adacore.com>
15787
15788 * ada-lang.c (_initialize_ada_language): Expand the help text
15789 for the "catch exception" command.
15790
9d7c67bf
PW
157912019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15792
15793 * symtab.c (matching_obj_sections): Initialize obj,
15794 declare it closer to its usage.
15795
7cf47dc4
TT
157962019-01-10 Tom Tromey <tom@tromey.com>
15797
15798 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15799 (basic_inf_threads_range): Remove.
15800 (inf_threads_range, inf_non_exited_threads_range)
15801 (safe_inf_threads_range): Use next_adapter.
15802
d3cb6808
KS
158032019-01-10 Keith Seitz <keiths@redhat.com>
15804
15805 PR gdb/23712
15806 PR symtab/23010
15807 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15808 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15809
63a20375
KS
158102019-01-10 Keith Seitz <keiths@redhat.com>
15811
15812 PR gdb/23712
15813 PR symtab/23010
15814 * dictionary.c (pending_to_vector): Remove.
15815 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15816 Remove _1 suffix, replacing functions of the same name. Update
15817 all callers.
15818 (dict_create_hashed, dict_create_hashed_expandable)
15819 (dict_create_linear, dict_create_linear_expandable, dict_free)
15820 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15821 Make functions static.
15822
b026f593
KS
158232019-01-10 Keith Seitz <keiths@redhat.com>
15824
15825 PR gdb/23712
15826 PR symtab/23010
15827 * dictionary.h (struct dictionary): Replace declaration with
15828 multidictionary.
15829 (dict_create_hashed, dict_create_hashed_expandable)
15830 (dict_create_linear, dict_create_linear_expandable)
15831 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15832 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15833 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15834 taking multidictionary argument.
15835 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15836 * block.h (struct block) <dict>: Change to multidictionary
15837 and rename `multidict'.
15838 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15839 symmisc.c: Update all dictionary references to multidictionary.
15840
c7748ee9
KS
158412019-01-10 Keith Seitz <keiths@redhat.com>
15842
15843 PR gdb/23712
15844 PR symtab/23010
15845 * dictionary.c: Include unordered_map.
15846 (pending_to_vector): New function.
15847 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15848 Rewrite the non-"_1" functions to take vector instead
15849 of linked list.
15850 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15851 "new" _1 versions of the same name.
15852 (multidictionary): Define.
15853 (std::hash<enum language): New definition.
15854 (collate_pending_symbols_by_language, mdict_create_hashed)
15855 (mdict_create_hashed_expandable, mdict_create_linear)
15856 (mdict_create_linear_expandable, mdict_free)
15857 (find_language_dictionary, create_new_language_dictionary)
15858 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15859 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15860 (mdict_size, mdict_empty): New functions.
15861 * dictionary.h (mdict_iterator): Define.
15862
67aa1f3c
PA
158632019-01-10 Pedro Alves <palves@redhat.com>
15864
15865 * breakpoint.c (read_uploaded_action)
15866 (create_tracepoint_from_upload): Adjust to use
15867 gdb::unique_xmalloc_ptr.
15868 * ctf.c (ctf_write_uploaded_tp):
15869 (SET_ARRAY_FIELD): Use emplace_back.
15870 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15871 * tracefile-tfile.c (tfile_write_uploaded_tp):
15872 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15873 gdb::unique_xmalloc_ptr.
15874 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15875 at_string, cond_string, cmd_strings>: Replace char pointers
15876 with gdb::unique_xmalloc_ptr.
15877
2f667667
PA
158782019-01-10 Pedro Alves <palves@redhat.com>
15879
15880 * solib-target.c (library_list_start_library): Don't xstrdup name.
15881
36cb7237
PA
158822019-01-10 Pedro Alves <palves@redhat.com>
15883
15884 * mdebugread.c (parse_partial_symbols): Use
15885 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15886
da584958
AB
158872019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15888
15889 * linux-fork.c (scoped_switch_fork_info)
15890 <~scoped_switch_fork_info>: Fix incorrect variable name.
15891
1ef8573c
AB
158922019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15893
15894 * linux-fork.c (scoped_switch_fork_info)
15895 <scoped_switch_fork_info>: Make explicit.
15896 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15897
8d7bcccb
TT
158982019-01-10 Tom Tromey <tom@tromey.com>
15899
15900 * objfiles.h (objfile::reset_psymtabs): Update.
15901 * objfiles.c (objfile::objfile): Update.
15902 * psymtab.h (psymtab_storage::obstack): Update.
15903 (psymtab_storage::m_obstack): Use gdb::optional.
15904 (class psymtab_storage): Update comment. Remove objfile
15905 parameter.
15906 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15907
b596a3c7
TT
159082019-01-10 Tom Tromey <tom@tromey.com>
15909
15910 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15911 <free_psymtabs>: Now private.
15912 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15913 (allocate_psymtab): Use new method.
15914
a9342b62
TT
159152019-01-10 Tom Tromey <tom@tromey.com>
15916
15917 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15918 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15919 * mdebugread.c (parse_partial_symbols): Use
15920 allocate_dependencies.
15921 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15922 allocate_dependencies.
15923 (process_psymtab_comp_unit_reader)
15924 (build_type_psymtab_dependencies): Likewise.
15925 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15926
5af70966
TT
159272019-01-10 Tom Tromey <tom@tromey.com>
15928
15929 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15930 PSYMBOL_SET_LANGUAGE.
15931 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15932
5923a04c
TT
159332019-01-10 Tom Tromey <tom@tromey.com>
15934
15935 * psymtab.h (psymtab_storage::obstack): New method.
15936 <m_obstack>: Rename from obstack; now private.
15937 * psymtab.c (psymtab_storage): Update.
15938 * dwarf2read.c (create_addrmap_from_index)
15939 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15940 Update.
15941
6d6a12bf
TT
159422019-01-10 Tom Tromey <tom@tromey.com>
15943
15944 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15945 * objfiles.h (objfile::reset_psymtabs): New method.
15946
d320c2b5
TT
159472019-01-10 Tom Tromey <tom@tromey.com>
15948
15949 * symmisc.c (print_symbol_bcache_statistics): Update.
15950 (print_objfile_statistics): Update.
15951 * symfile.c (reread_symbols): Update.
15952 * psymtab.h (class psymtab_storage): New.
15953 * psymtab.c (psymtab_storage): New constructor.
15954 (~psymtab_storage): New destructor.
15955 (require_partial_symbols): Update.
15956 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15957 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15958 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15959 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15960 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15961 (start_psymtab_common, end_psymtab_common)
15962 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15963 (allocate_psymtab): Update.
15964 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15965 Update.
15966 (dump_psymtab_addrmap, maintenance_print_psymbols)
15967 (maintenance_check_psymtabs): Update.
15968 (class objfile_psymtabs): Move to objfiles.h.
15969 * psympriv.h (discard_psymtab): Now inline.
15970 (psymtab_discarder::psymtab_discarder): Update.
15971 (psymtab_discarder::~psymtab_discarder): Update.
15972 (ALL_OBJFILE_PSYMTABS): Rewrite.
15973 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15974 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15975 Remove fields.
15976 <partial_symtabs>: New field.
15977 (class objfile_psymtabs): Move from psymtab.h. Update.
15978 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15979 psymbol_cache.
15980 (objfile::~objfile): Don't destroy psymbol_cache.
15981 * mdebugread.c (parse_partial_symbols): Update.
15982 * dwarf2read.c (create_addrmap_from_index)
15983 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15984 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15985 (add_partial_subprogram, dwarf2_ranges_read): Update.
15986 * dwarf-index-write.c (write_address_map)
15987 (write_one_signatured_type, recursively_write_psymbols)
15988 (class debug_names, class debug_names, write_psymtabs_to_index):
15989 Update.
15990
1d94a5a3
TT
159912019-01-10 Tom Tromey <tom@tromey.com>
15992
15993 * symtab.h (SYMBOL_SET_NAMES): Update.
15994 (symbol_set_names): Update.
15995 (MSYMBOL_SET_NAMES): Update.
15996 * symtab.c (symbol_set_names): Change argument to be an
15997 objfile_per_bfd_storage.
15998 * psymtab.c (add_psymbol_to_bcache): Update.
15999 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16000
0f14768a
TT
160012019-01-10 Tom Tromey <tom@tromey.com>
16002
16003 * symtab.c (create_demangled_names_hash): Change argument to be an
16004 objfile_per_bfd_storage.
16005 (symbol_set_names): Update.
16006
6eee24ce
TT
160072019-01-10 Tom Tromey <tom@tromey.com>
16008
16009 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16010 init_psymbol_list.
16011 * psymtab.c (init_psymbol_list): Do nothing if already called.
16012 * psympriv.h (init_psymbol_list): Add comment.
16013 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16014 init_psymbol_list.
16015 * dbxread.c (dbx_symfile_read): Unconditionally call
16016 init_psymbol_list.
16017
75aedd27
TT
160182019-01-10 Tom Tromey <tom@tromey.com>
16019
16020 * xcoffread.c (scan_xcoff_symtab): Update.
16021 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16022 "where".
16023 * mdebugread.c (parse_partial_symbols)
16024 (handle_psymbol_enumerators): Update.
16025 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16026 * dbxread.c (read_dbx_symtab): Update.
16027 * psympriv.h (psymbol_placement): New enum.
16028 (add_psymbol_to_list): Update.
16029
939652a5
TT
160302019-01-10 Tom Tromey <tom@tromey.com>
16031
16032 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16033 static_psymbols parameters.
16034 (scan_xcoff_symtab): Update.
16035 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16036 static_psymbols parameters.
16037 * psympriv.h (start_psymtab_common): Update.
16038 * mdebugread.c (parse_partial_symbols): Update.
16039 * dwarf2read.c (create_partial_symtab): Update.
16040 * dbxread.c (read_dbx_symtab): Update.
16041 (start_psymtab): Remove global_psymbols and static_psymbols
16042 parameters.
16043
baa62830
TT
160442019-01-10 Tom Tromey <tom@tromey.com>
16045
16046 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16047 * psymtab.c (allocate_psymtab): Add comment.
16048 * psympriv.h (allocate_psymtab): Add comment.
16049 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16050 initializations.
16051 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16052
0e8f53ba
TT
160532019-01-10 Tom Tromey <tom@tromey.com>
16054
16055 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16056 Don't declare.
16057 * mipsread.c: Include mdebugread.h.
16058 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16059 Declare.
16060 * elfread.c: Include mdebugread.h.
16061
b22a7c6a
TT
160622019-01-09 Tom Tromey <tom@tromey.com>
16063
16064 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16065 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16066 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16067 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16068 (psym_lookup_symbol, psym_find_last_source_symtab)
16069 (psym_forget_cached_source_info, psym_print_stats)
16070 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16071 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16072 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16073 (psym_find_compunit_symtab_by_address)
16074 (maintenance_print_psymbols, maintenance_info_psymtabs)
16075 (maintenance_check_psymtabs): Use ranged for.
16076 * psymtab.h (class objfile_psymtabs): New.
16077 (require_partial_symbols): Return objfile_psymtabs.
16078 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16079
3b9d3ac2
TT
160802019-01-09 Tom Tromey <tom@tromey.com>
16081
16082 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16083 (find_pc_mapped_section, list_overlays_command)
16084 (map_overlay_command, unmap_overlay_command)
16085 (simple_overlay_update): Use all_objfiles.
16086 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16087 * printcmd.c (info_symbol_command): Use all_objfiles.
16088 * objfiles.h (ALL_OBJSECTIONS): Remove.
16089 * maint.c (maintenance_translate_address): Use all_objfiles.
16090 * gcore.c (gcore_create_callback): Use all_objfiles.
16091 (objfile_find_memory_regions): Likewise.
16092
8b31193a
TT
160932019-01-09 Tom Tromey <tom@tromey.com>
16094
16095 * symtab.c (find_line_symtab, info_sources_command)
16096 (make_source_files_completion_list): Use objfile_compunits.
16097 * source.c (select_source_symtab): Use objfile_compunits.
16098 * objfiles.h (struct objfile): Update comment.
16099 (ALL_OBJFILES): Remove.
16100 (ALL_FILETABS): Remove.
16101 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16102 objfile_compunits.
16103
d5da8b3c
TT
161042019-01-09 Tom Tromey <tom@tromey.com>
16105
16106 * symmisc.c (print_objfile_statistics, dump_objfile)
16107 (maintenance_print_symbols): Use compunit_filetabs.
16108 * source.c (forget_cached_source_info_for_objfile): Use
16109 compunit_filetabs.
16110 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16111 (ALL_FILETABS): Use compunit_filetabs.
16112 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16113 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16114
5accd1a0
TT
161152019-01-09 Tom Tromey <tom@tromey.com>
16116
16117 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16118 (compunit_filetabs): New.
16119 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16120 compunit_filetabs.
16121 (info_sources_command, make_source_files_completion_list): Remove
16122 declaration.
16123 * symmisc.c (print_objfile_statistics, dump_objfile)
16124 (maintenance_print_symbols): Remove declaration.
16125 (maintenance_info_symtabs): Use compunit_filetabs.
16126 (maintenance_info_line_tables): Likewise.
16127 * source.c (select_source_symtab): Change local variable name.
16128 (forget_cached_source_info_for_objfile): Remove declaration.
16129 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16130 * objfiles.c (objfile_relocate1): Remove declaration.
16131 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16132 declaration.
16133 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16134 * coffread.c (coff_symtab_read): Remove declaration.
16135 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16136 compunit_filetabs.
16137
d8aeb77f
TT
161382019-01-09 Tom Tromey <tom@tromey.com>
16139
16140 * symtab.c (lookup_objfile_from_block)
16141 (find_pc_sect_compunit_symtab, search_symbols)
16142 (default_collect_symbol_completion_matches_break_on): Use
16143 objfile_compunits.
16144 * objfiles.h (ALL_COMPUNITS): Remove.
16145 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16146 * cp-support.c (add_symbol_overload_list_qualified): Use
16147 objfile_compunits.
16148 * ada-lang.c (ada_collect_symbol_completion_matches)
16149 (ada_add_global_exceptions): Use objfile_compunits.
16150
592553c4
TT
161512019-01-09 Tom Tromey <tom@tromey.com>
16152
16153 * source.c (select_source_symtab)
16154 (forget_cached_source_info_for_objfile): Remove declaration.
16155 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16156 declaration.
16157 * maint.c (count_symtabs_and_blocks): Remove declaration.
16158 * cp-support.c (add_symbol_overload_list_qualified): Remove
16159 declaration.
16160 * coffread.c (coff_symtab_read): Remove declaration.
16161 * symtab.c (lookup_symbol_in_objfile_symtabs)
16162 (basic_lookup_transparent_type_1): Use objfile_compunits.
16163 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16164 (info_sources_command, search_symbols)
16165 (default_collect_symbol_completion_matches_break_on)
16166 (make_source_files_completion_list): Remove declaration.
16167 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16168 (ada_collect_symbol_completion_matches)
16169 (ada_add_global_exceptions): Remove declaration.
16170 * linespec.c (iterate_over_all_matching_symtabs): Use
16171 objfile_compunits.
16172 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16173 (class objfile_compunits): New.
16174 (ALL_COMPUNITS): Use objfile_compunits.
16175 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16176 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16177 objfile_compunits.
16178 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16179
5325b9bf
TT
161802019-01-09 Tom Tromey <tom@tromey.com>
16181
16182 * symtab.c (search_symbols)
16183 (default_collect_symbol_completion_matches_break_on): Use
16184 objfile_msymbols.
16185 * ada-lang.c (ada_lookup_simple_minsym)
16186 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16187 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16188 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16189 objfile_msymbols.
16190 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16191 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16192 * objc-lang.c (find_methods): Use objfile_msymbols.
16193 (info_selectors_command, info_classes_command): Likewise.
16194 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16195 * objfiles.h (class objfile_msymbols): New.
16196 (ALL_OBJFILE_MSYMBOLS): Remove.
16197 (ALL_MSYMBOLS): Remove.
16198
cac85af2
TT
161992019-01-09 Tom Tromey <tom@tromey.com>
16200
16201 * common/next-iterator.h (next_adapter): Add Iterator template
16202 parameter.
16203 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16204 (class all_objfiles_safe): New.
16205 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16206 * objfiles.c (put_objfile_before): Update comment.
16207 (add_separate_debug_objfile): Likewise.
16208 (free_all_objfiles): Use all_objfiles_safe.
16209 (objfile_purge_solibs): Likewise.
16210
aed57c53
TT
162112019-01-09 Tom Tromey <tom@tromey.com>
16212
16213 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16214 (expand_symtab_containing_pc, lookup_static_symbol)
16215 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16216 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16217 all_objfiles.
16218 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16219 * breakpoint.c (create_overlay_event_breakpoint)
16220 (create_longjmp_master_breakpoint)
16221 (create_std_terminate_master_breakpoint)
16222 (create_exception_master_breakpoint): Use all_objfiles.
16223 * linux-thread-db.c (try_thread_db_load_from_pdir)
16224 (has_libpthread): Use all_objfiles.
16225 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16226 * linespec.c (iterate_over_all_matching_symtabs)
16227 (search_minsyms_for_name): Use all_objfiles.
16228 * maint.c (maintenance_info_sections): Use all_objfiles.
16229 * main.c (captured_main_1): Use all_objfiles.
16230 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16231 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16232 * guile/scm-pretty-print.c
16233 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16234 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16235 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16236 (maintenance_print_msymbols): Use all_objfiles.
16237 * source.c (select_source_symtab): Use all_objfiles.
16238 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16239 * symfile.c (remove_symbol_file_command)
16240 (expand_symtabs_matching, map_symbol_filenames): Use
16241 all_objfiles.
16242 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16243 all_objfiles.
16244 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16245 * objc-lang.c (find_methods): Use all_objfiles.
16246 * objfiles.c (have_partial_symbols, have_full_symbols)
16247 (have_minimal_symbols, qsort_cmp)
16248 (default_iterate_over_objfiles_in_search_order): Use
16249 all_objfiles.
16250 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16251 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16252 (maintenance_check_psymtabs): Use all_objfiles.
16253 (ALL_PSYMTABS): Remove.
16254 * compile/compile-object-run.c (do_module_cleanup): Use
16255 all_objfiles.
16256 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16257 * cp-support.c (add_symbol_overload_list_qualified): Use
16258 all_objfiles.
16259 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16260 Use all_objfiles.
16261 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16262 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16263 all_objfiles.
16264 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16265 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16266 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16267 Uses all_objfiles.
16268 * solib.c (solib_read_symbols): Use all_objfiles
16269
99d89cde
TT
162702019-01-09 Tom Tromey <tom@tromey.com>
16271
16272 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16273 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16274 all_objfiles.
16275 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16276 * symmisc.c (print_symbol_bcache_statistics)
16277 (print_objfile_statistics, maintenance_print_objfiles)
16278 (maintenance_info_symtabs, maintenance_check_symtabs)
16279 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16280 all_objfiles.
16281 * source.c (forget_cached_source_info): Use all_objfiles.
16282 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16283 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16284 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16285 * objfiles.c (update_section_map): Use all_objfiles.
16286 (shared_objfile_contains_address_p): Likewise.
16287 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16288 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16289
21708325
TT
162902019-01-09 Tom Tromey <tom@tromey.com>
16291
16292 * common/next-iterator.h: New file.
16293 * objfiles.h (class all_objfiles): New.
16294 (struct objfile_iterator): New.
16295
669e09f6
PW
162962019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16297
16298 * NEWS: Move the description of the changed "frame", "select-frame",
16299 and "info frame" commands to the Changed commands section.
16300
041be526
SM
163012019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16302
16303 * gdbtypes.c (check_stub_method_group): Remove handling of old
16304 mangling schemes.
16305 * linespec.c (find_methods): Likewise.
16306 * stabsread.c (read_member_functions): Likewise.
16307 * valops.c (search_struct_method): Likewise.
16308 (value_struct_elt_for_reference): Likewise.
16309 * NEWS: Mention this change.
16310
0e2a2133
AB
163112019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16312
16313 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16314 print_source_lines.
16315 * source.c (print_source_lines_base): Update line number check.
16316 (print_source_lines): New function.
16317 (source_lines_range::source_lines_range): New function.
16318 * source.h (class source_lines_range): New class.
16319 (print_source_lines): New declaration.
16320
1055a3b4
PW
163212019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16322
16323 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16324
cfeadda5
TT
163252019-01-08 Tom Tromey <tom@tromey.com>
16326 Simon Marchi <simon.marchi@ericsson.com>
16327
16328 PR gdb/24060
16329 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16330 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16331 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16332 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16333 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16334 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16335
583068ca
AB
163362019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16337
16338 * source.c (select_source_symtab): Move header comment to
16339 declaration in source.h.
16340 (forget_cached_source_info_for_objfile): Likewise.
16341 (forget_cached_source_info): Likewise.
16342 (identify_source_line): Likewise.
16343 * source.h (identify_source_line): Move declaration from symtab.h
16344 and add comment from source.c
16345 (print_source_lines): Likewise.
16346 (forget_cached_source_info_for_objfile): Likewise.
16347 (forget_cached_source_info): Likewise.
16348 (select_source_symtab): Likewise.
16349 (enum print_source_lines_flag): Move definition from symtab.h.
16350 * symtab.h (identify_source_line): Move declaration to source.h.
16351 (print_source_lines): Likewise.
16352 (forget_cached_source_info_for_objfile): Likewise.
16353 (forget_cached_source_info): Likewise.
16354 (select_source_symtab): Likewise.
16355 (enum print_source_lines_flag): Move definition to source.h.
16356 * tui/tui-hooks.c: Add 'source.h' include.
16357
ec98a4ad
AB
163582019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16359
16360 * source.c (print_source_lines_base): Handle requests to print
16361 reverse line number sequences, and guard against empty lines
16362 string.
16363
62ea19c1
AB
163642019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16365
16366 * source.c (print_source_lines_base): Fix skip of '\r' if next
16367 character is '\n'.
16368
9d30e1fd
TT
163692019-01-06 Tom Tromey <tom@tromey.com>
16370
16371 * c-exp.y (struct c_parse_state) <macro_original_text,
16372 expansion_obstack>: New member.
16373 (macro_original_text, expansion_obstack): Remove globals.
16374 (scan_macro_expansion, scanning_macro_expansion)
16375 (finished_macro_expansion): Update.
16376 (scan_macro_cleanup): Remove.
16377 (yylex, c_parse): Update.
16378
c65bac38
TT
163792019-01-06 Tom Tromey <tom@tromey.com>
16380
16381 * c-exp.y (struct c_parse_state) <strings>: New member.
16382 (operator_stoken): Update.
16383
02e12e38
TT
163842019-01-06 Tom Tromey <tom@tromey.com>
16385
16386 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16387 (union type_stack_elt) <typelist_val>: Now a pointer to
16388 std::vector.
16389 (type_stack_cleanup): Don't declare.
16390 (push_typelist): Update.
16391 * parse.c (pop_typelist): Return a std::vector.
16392 (push_typelist): Take a std::vector.
16393 (follow_types): Update. Do not free args.
16394 (type_stack_cleanup): Remove.
16395 * c-exp.y (struct c_parse_state): New.
16396 (cpstate): New global.
16397 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16398 (nonempty_typelist): Update.
16399 (func_mod): Create a new vector.
16400 (c_parse): Create a c_parse_state.
16401 (check_parameter_typelist): Do not delete params.
16402 (function_method): Update. Do not delete type_list.
16403
f097f5ad
TT
164042019-01-06 Tom Tromey <tom@tromey.com>
16405
16406 PR gdb/28155:
16407 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16408 check_typedef.
16409 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16410 (print_return_value): Likewise.
16411
d2adf9f1
TT
164122019-01-05 Tom Tromey <tom@tromey.com>
16413
16414 * contrib/cleanup_check.py: Remove.
16415 * contrib/gcc-with-excheck: Remove.
16416 * contrib/exsummary.py: Remove.
16417 * contrib/excheck.py: Remove.
16418
2eab46b1
JB
164192019-01-05 Joel Brobecker <brobecker@adacore.com>
16420
16421 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16422 NULL. Initialize tpprev to NULL instead of assigning it
16423 to NULL on the next statement.
16424 * windows-nat.c (windows_delete_thread): Remove check for
16425 main_thread_id before printing thread exit notifications.
16426 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16427 Remove thread ID check against main_thread_id.
16428 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16429 windows_delete_thread.
16430 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16431
48c5e7e2
TT
164322019-01-04 Tom Tromey <tom@tromey.com>
16433
16434 * compile/compile.c (_initialize_compile): Use upper case for
16435 metasyntactic variables.
16436 * symmisc.c (_initialize_symmisc): Use upper case for
16437 metasyntactic variables.
16438 * psymtab.c (_initialize_psymtab): Use upper case for
16439 metasyntactic variables.
16440 * demangle.c (demangle_command): Use upper case for metasyntactic
16441 variables.
16442 (_initialize_demangler): Likewise.
16443 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16444 variables.
16445
986041cd
TT
164462019-01-03 Tom Tromey <tom@tromey.com>
16447
16448 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16449
7c711119
TT
164502019-01-03 Tom Tromey <tom@tromey.com>
16451
16452 * python/py-symtab.c (salpy_str): Update.
16453 (struct salpy_sal_object) <symtab>: Now a PyObject.
16454 (salpy_dealloc): Update.
16455 (del_objfile_sal): Use gdbpy_ref.
16456
1b20edf0
TT
164572019-01-03 Tom Tromey <tom@tromey.com>
16458
16459 * python/py-type.c (convert_field): Use new_reference. Return
16460 gdbpy_ref.
16461 (make_fielditem): Return gdbpy_ref.
16462 (typy_fields): Update.
16463 (typy_getitem): Update.
16464 (field_name): Return gdbpy_ref. Use new_reference.
16465 (typy_iterator_iternext): Update.
16466
ea41325b
TT
164672019-01-03 Tom Tromey <tom@tromey.com>
16468
16469 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16470
2a3c71d6
TT
164712019-01-03 Tom Tromey <tom@tromey.com>
16472
16473 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16474 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16475 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16476 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16477 (pspy_set_type_printers): Likewise.
16478 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16479 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16480 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16481 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16482 (objfpy_set_type_printers): Likewise.
16483
5c329e6a
TT
164842019-01-03 Tom Tromey <tom@tromey.com>
16485
16486 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16487 (gdbpy_print_stack): Use gdbpy_err_fetch.
16488 * python/python-internal.h (class gdbpy_err_fetch): New class.
16489 (class gdbpy_enter) <m_error_type, m_error_value,
16490 m_error_traceback>: Remove.
16491 <m_error>: New member.
16492 (gdbpy_exception_to_string): Don't declare.
16493 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16494 * python/py-value.c (convert_value_from_python): Use
16495 gdbpy_err_fetch.
16496 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16497 gdbpy_exception_to_string.
16498 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16499 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16500 gdbpy_err_fetch.
16501
169bb27b
AB
165022019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16503
16504 * linux-nat.c (delete_lwp_cleanup): Delete.
16505 (struct lwp_deleter): New struct.
16506 (lwp_info_up): New typedef.
16507 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16508 lwp_info_up.
16509
a07c8880
AB
165102019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16511
16512 * linux-fork.c (class scoped_switch_fork_info): New class.
16513 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16514
26089c49
AB
165152019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16516
16517 * valops.c (find_overload_match): Remove use of null_cleanup, and
16518 calls to do_cleanups.
16519
06d3e5b0
AB
165202019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16521
16522 * compile/compile-cplus-types.c
16523 (compile_cplus_instance::decl_name): Handle changes to
16524 cp_func_name.
16525 * cp-support.c (cp_func_name): Update header comment, update
16526 return type.
16527 * cp-support.h (cp_func_name): Update return type in declaration.
16528 * valops.c (find_overload_match): Move temp_func local to top
16529 level of function and change its type. Use temp_func to hold and
16530 delete temporary string obtained from cp_func_name.
16531
66644cd3
AB
165322019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16533
16534 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16535 gdb::char_vector, remove cleanup, and update uses of `msg`.
16536
592d8c0a
JW
165372019-01-03 Jim Wilson <jimw@sifive.com>
16538
16539 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16540
c55d06ec
TT
165412019-01-02 Tom Tromey <tom@tromey.com>
16542
16543 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16544 (tdesc_parse_xml): Remove cleanups.
16545 * target-descriptions.h (make_cleanup_free_target_description):
16546 Don't declare.
16547 (target_desc_deleter): New struct.
16548 (target_desc_up): New typedef.
16549 * target-descriptions.c (target_desc_deleter::operator()): Rename
16550 from free_target_description.
16551 (make_cleanup_free_target_description): Remove.
16552
3a6ae42d
TT
165532019-01-02 Tom Tromey <tom@tromey.com>
16554
16555 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16556 constructor, destructor.
16557 (linespec_parser): Remove typedef.
16558 (~linespec_parser): Rename from linespec_parser_delete.
16559 (linespec_lex_to_end, linespec_complete_label)
16560 (linespec_complete): Update.
16561 (decode_line_full): Remove cleanups.
16562 (decode_line_1): Update.
16563
61fd3e73
TT
165642019-01-02 Tom Tromey <tom@tromey.com>
16565
16566 * python/python-internal.h (inferior_to_inferior_object): Change
16567 return type.
16568 * python/py-exitedevent.c (create_exited_event_object): Update.
16569 * python/py-inferior.c (inferior_to_inferior_object): Return
16570 gdbpy_ref.
16571 (python_new_inferior, python_inferior_deleted)
16572 (thread_to_thread_object, delete_thread_object)
16573 (build_inferior_list, gdbpy_selected_inferior): Update.
16574 * python/py-infthread.c (create_thread_object): Update. Also fail
16575 if inferior_to_inferior_object fails.
16576
d20172fc
SM
165772019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16578
16579 * inferior.h (class inferior) <displaced_step_state>: New field.
16580 * infrun.h (struct displaced_step_state): Move here from
16581 infrun.c. Initialize fields, add constructor.
16582 <inf>: Remove field.
16583 <reset>: New method.
16584 * infrun.c (struct displaced_step_inferior_state): Move to
16585 infrun.h.
16586 (displaced_step_inferior_states): Remove.
16587 (get_displaced_stepping_state): Adust.
16588 (displaced_step_in_progress_any_inferior): Adjust.
16589 (displaced_step_in_progress_thread): Adjust.
16590 (displaced_step_in_progress): Adjust.
16591 (add_displaced_stepping_state): Remove.
16592 (get_displaced_step_closure_by_addr): Adjust.
16593 (remove_displaced_stepping_state): Remove.
16594 (infrun_inferior_exit): Call displaced_step_state.reset.
16595 (use_displaced_stepping): Don't check for NULL.
16596 (displaced_step_prepare_throw): Call
16597 get_displaced_stepping_state.
16598 (displaced_step_fixup): Don't check for NULL.
16599 (prepare_for_detach): Don't check for NULL.
16600
e3319240
PW
166012019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16602
16603 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16604 in case of call that did not complete.
16605
5d36dfb9
AU
166062019-01-02 Andrey Utkin <autkin@undo.io>
16607
16608 * symfile.c (find_separate_debug_file): Fix search of debug files for
16609 remote debuggee.
16610
8833fbf0
TT
166112019-01-02 Tom Tromey <tom@tromey.com>
16612
16613 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16614 indentation.
16615 * python/py-frame.c (frapy_older): Remove cast.
16616 (frapy_newer): Likewise.
16617 * python/py-breakpoint.c (local_setattro): Remove cast.
16618 * python/py-arch.c (archpy_name): Remove local variable.
16619 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16620
4ada3dfd
JB
166212019-01-02 Joel Brobecker <brobecker@adacore.com>
16622
16623 * unittests/basic_string_view/element_access/char/empty.cc:
16624 Fix year range in copyright header.
16625
113b7b81
AB
166262019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16627
16628 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16629 Delete.
16630 <operator==>: Update with for removed field.
16631 <hash>: Likewise.
16632 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16633 <isa_features>: ...this.
16634 <abi_features>: New field.
16635 (riscv_isa_flen): Update comment.
16636 (riscv_abi_xlen): New declaration.
16637 (riscv_abi_flen): New declaration.
16638 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16639 isa_features.
16640 (riscv_abi_xlen): New function.
16641 (riscv_isa_flen): Update to get answer from isa_features.
16642 (riscv_abi_flen): New function.
16643 (riscv_has_fp_abi): Update to get answer from abi_features.
16644 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16645 xlen and flen.
16646 (riscv_call_info) <xlen, flen>: Update comment.
16647 (riscv_call_arg_struct): Remove invalid assertions
16648 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16649 is removed.
16650 (riscv_gdbarch_init): Gather isa features and abi features
16651 separately, ensure both match on the gdbarch when reusing an old
16652 gdbarch. Relax an error check to allow 32-bit abi float to run on
16653 a target with 64-bit float hardware.
16654
b18ca514
PW
166552019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16656
16657 * source.c (search_command_helper): Stop reverse search
16658 when line 1 has been searched.
16659
ec70d8db
PW
166602019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16661
16662 * record-full.c (record_full_base_target::close): Rewrite
16663 record_full_core_buf_list free logic.
16664
5b38f9c1
PW
166652019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16666
16667 * break-catch-syscall.c (print_one_catch_syscall): xfree
16668 the last text.
16669
66d91b39
JB
166702019-01-01 Joel Brobecker <brobecker@adacore.com>
16671
16672 * top.c (print_gdb_version): Update Copyright year in version
16673 message.
16674
42a4f53d
JB
166752019-01-01 Joel Brobecker <brobecker@adacore.com>
16676
16677 Update copyright year range in all GDB files.
16678
7e955d83 166792019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16680
5bbd631d 16681 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16682
5bbd631d 16683For older changes see ChangeLog-2018.
c906108c
SS
16684\f
16685Local Variables:
16686mode: change-log
16687left-margin: 8
16688fill-column: 74
16689version-control: never
57da7796 16690coding: utf-8
c906108c 16691End:
5bbd631d 16692
This page took 3.216733 seconds and 4 git commands to generate.