gdb/ChangeLog

   1 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
   4         gdb::byte_vector.
   5
   6 2019-12-12  Tom Tromey  <tromey@adacore.com>
   7
   8         * xml-support.c (xml_fetch_content_from_file): Don't call
   9         malloc_failure.
  10         * utils.h (class gdb_argv): Remove malloc_failure comment.
  11         * utils.c (gdb_argv::reset): Don't call malloc_failure.
  12
  13 2019-12-12  Tom Tromey  <tromey@adacore.com>
  14
  15         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
  16         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
  17         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
  18         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
  19         * riscv-ravenscar-thread.c: New file.
  20         * riscv-ravenscar-thread.h: New file.
  21         * riscv-tdep.c (riscv_gdbarch_init): Call
  22         register_riscv_ravenscar_ops.
  23
  24 2019-12-12  Tom Tromey  <tromey@adacore.com>
  25
  26         * gdbsupport/thread-pool.c (set_thread_name): Use
  27         ATTRIBUTE_UNUSED.
  28
  29 2019-12-12  Luis Machado  <luis.machado@linaro.org>
  30
  31         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
  32         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
  33         macros.
  34
  35 2019-12-11  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-win.c (tui_set_win_height_command): Call
  38         tui_adjust_window_height.
  39         (tui_adjust_win_heights, new_height_ok): Remove.
  40         * tui/tui-layout.h (tui_adjust_window_height): Declare.
  41         * tui/tui-layout.c (tui_adjust_window_height): New function.
  42
  43 2019-12-11  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-win.c (tui_resize_all): Remove code, call
  46         tui_apply_current_layout.
  47
  48 2019-12-11  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-layout.h (tui_apply_current_layout): Declare.
  51         * tui/tui-layout.c (standard_layouts, applied_layout): New
  52         globals.
  53         (tui_apply_current_layout): New function.
  54         (show_layout): Set applied_layout.  Call
  55         tui_apply_current_layout.
  56         (show_source_command, show_disasm_command)
  57         (show_source_disasm_command, show_data)
  58         (show_source_or_disasm_and_command): Remove.
  59         (initialize_layouts): New function.
  60         (_initialize_tui_layout): Call initialize_layouts.
  61
  62 2019-12-11  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-layout.h (class tui_layout_base)
  65         (class tui_layout_window, class tui_layout_split): New.
  66         * tui/tui-layout.c (tui_get_window_by_name)
  67         (tui_layout_window::clone, tui_layout_window::apply)
  68         (tui_layout_window::get_sizes, tui_layout_window::add_split)
  69         (tui_layout_split::add_window, tui_layout_split::clone)
  70         (tui_layout_split::get_sizes)
  71         (tui_layout_split::set_weights_from_heights)
  72         (tui_layout_split::adjust_size, tui_layout_split::apply): New
  73         functions.
  74         (tui_layout_split::add_split, tui_layout_split::add_split)
  75         (tui_layout_split::set_weights_from_heights)
  76         (tui_layout_split::set_weights_from_heights): New functions.
  77
  78 2019-12-11  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
  81         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
  82         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
  83         * tui/tui-data.h (struct tui_point): Remove.
  84         (struct tui_gen_win_info) <origin>: Remove.
  85         <x, y>: New fields.
  86         * tui/tui-command.c (tui_cmd_window::resize): Update.
  87
  88 2019-12-11  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
  91         Implement.
  92         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
  93         Implement.
  94         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
  95         method.
  96         (struct tui_win_info) <min_height>: Implement.
  97
  98 2019-12-11  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 101         (struct tui_win_info) <can_box>: Update.
 102
 103 2019-12-11  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 106         method.
 107         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 108         method.
 109         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 110         method.
 111         (struct tui_win_info) <max_height>: Now override.
 112
 113 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 114
 115         * NEWS: Create a new section for the next release branch.
 116         Rename the section of the current branch, now that it has
 117         been cut.
 118
 119 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 120
 121         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 122         * version.in: Bump version to 10.0.50.DATE-git.
 123
 124 2019-12-11  Tom Tromey  <tromey@adacore.com>
 125
 126         PR build/25268:
 127         * gdbsupport/thread-pool.c (set_thread_name): New function.
 128         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 129         (thread_pool::thread_function): Call set_thread_name.
 130
 131 2019-12-11  Tom Tromey  <tromey@adacore.com>
 132
 133         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 134         bfd_get_signed_8.
 135
 136 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 137
 138         * NEWS: Document -raw-values option and the related setting commands.
 139         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 140         only set it on when /r is given.
 141         * valprint.c (value_print_option_defs): New element raw-values.
 142         * Makefile.in: Add the new file.
 143
 144 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 145
 146         * gdbsupport/safe-strerror.c: Supress the unused function warning
 147         for select_strerror_r.
 148
 149 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 150
 151         * config.in: Regenerate.
 152         * configure: Regenerate.
 153         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 154         safe_strerror instead of strerror.
 155         * gdbsupport/common.m4: Don't check for strerror.
 156         * gdbsupport/safe-strerror.c: Support both the glibc version
 157         of strerror_r and the XSI version.
 158
 159 2019-12-10  Tom Tromey  <tromey@adacore.com>
 160
 161         * ada-typeprint.c (print_choices): Use a single "?".
 162         (print_variant_part): Print "?" if the discriminant name
 163         is not known.
 164
 165 2019-12-10  George Barrett  <bob@bob131.so>
 166
 167         Fix scripted probe breakpoints.
 168         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 169         declaration forward.
 170         (breakpoint_ops_for_event_location_type)
 171         (breakpoint_ops_for_event_location): Add function definitions.
 172         (break_command_1, trace_command): Use
 173         breakpoint_ops_for_event_location.
 174         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 175         declarations.
 176         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 177         breakpoint_ops_for_event_location.
 178         * python/py-breakpoint.c (bppy_init): Use
 179         breakpoint_ops_for_event_location.
 180
 181 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 182
 183         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 184         when ranking an lvalue argument for an rvalue parameter.
 185
 186 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 187
 188         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 189         template argument for scoped_restore_tmpl from bool to int.
 190
 191 2019-12-07  Keith Seitz  <keiths@redhat.com>
 192
 193         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 194         (build_id_to_debug_bfd): Make static, rewriting to use
 195         build_id_to_bfd_suffix.
 196         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 197         adding `suffix' parameter. Append SUFFIX to file names
 198         when searching for matching files.
 199         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 200         (build_id_to_exec_bfd): Likewise.
 201         * build-id.h (build_id_to_debug_bfd): Clarify that function
 202         searches for BFD of debug info file.
 203         (build_id_to_exec_bfd): Declare.
 204         * corelow.c: Include build-id.h.
 205         (locate_exec_from_corefile_build_id): New function.
 206         (core_target_open): If no executable BFD is found,
 207         search for a core file BFD using build-id.
 208
 209 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 210
 211         * bcache.c: Put in namespace gdb.
 212         * bcache.h: Likewise.
 213         * gdbtypes.c (check_types_worklist): Update.
 214         (types_deeply_equal): Update.
 215         * macrotab.c (struct macro_table) <bcache>: Update.
 216         (new_macro_table): Update.
 217         * macrotab.h (struct bcache): Put this forward declaration
 218         inside namespace gdb.
 219         (new_macro_table): Update.
 220         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 221         Update.
 222         <macro_cache>: Update.
 223         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 224
 225 2019-12-06  Tom de Vries  <tdevries@suse.de>
 226
 227         PR symtab/24971
 228         * block.c (best_symbol, better_symbol): New function.
 229         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 230         decl.
 231
 232 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 233
 234         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 235         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 236         for ranking see-through reference cases.
 237
 238 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 239         * stack.c (faas_command): Check a command is provided.
 240         * thread.c (taas_command, tfaas_command): Likewise.
 241
 242 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 243         * inferior.c (prune_inferiors):  Only call delete_inferior,
 244         Do not modify the inferior list.
 245
 246 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 247
 248         * c-exp.y: Update calls to lookup_typename,
 249         lookup_signed_typename and lookup_unsigned_typename.
 250         * c-lang.c (evaluate_subexp_c): Likewise.
 251         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 252         Likewise.
 253         * eval.c (binop_promote): Likewise.
 254         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 255         (lookup_unsigned_typename): Likewise.
 256         (lookup_signed_typename): Likewise.
 257         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 258         (lookup_signed_typename): Likewise.
 259         (lookup_typename): Likewise.
 260         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 261         lookup_typename, lookup_signed_typename,
 262         lookup_unsigned_typename.
 263         * m2-exp.y: Likewise.
 264         * printcmd.c (printf_wide_c_string): Likewise.
 265         (ui_printf): Likewise.
 266         * python/py-type.c (typy_lookup_typename): Likewise.
 267         * python/py-xmethods.c (python_xmethod_worker::invoke):
 268         Likewise.
 269         * rust-exp.y: Likewise.
 270
 271 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 272
 273         * configure.nat (obsd64): Add missing files x86-nat.o and
 274         nat/x86-dregs.o.
 275
 276 2019-12-04  Tom Tromey  <tom@tromey.com>
 277
 278         * valprint.c (val_print_string): Use metadata_style.
 279         * go-valprint.c (print_go_string): Use metadata style.
 280         * p-valprint.c (pascal_object_print_static_field): Use metadata
 281         style.
 282         * cp-valprint.c (cp_print_static_field): Use metadata style.
 283
 284 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 285             Chris January  <chris.january@arm.com>
 286
 287         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 288         tokens.
 289         (typebase): New patterns for complex, single/double precision, and
 290         single/double complex.
 291         (f77_keywords): Change token for complex keyword, and add single,
 292         double, and precision keywords.
 293
 294 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 295
 296         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 297         "info io_registers".
 298
 299 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 300
 301         * regcache.c (cooked_read_test): Initialize thread list of
 302         mock_inferior.
 303
 304 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 305
 306         * aarch64-linux-tdep.c: Remove includes.
 307
 308 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 309
 310         * aarch64-tdep.c: Remove includes.
 311
 312 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 313
 314         * filtered-iterator.h (filtered_iterator) <operator==,
 315         operator!=>: Compare wrapped iterators, not wrapped pointers.
 316         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 317         unittests/filtered_iterator-selftests.c.
 318         * unittests/filtered_iterator-selftests.c: New file.
 319
 320 2019-12-04  Tom Tromey  <tromey@adacore.com>
 321
 322         * gdbtypes.c (create_range_type): Inherit endianity
 323         from base type.
 324
 325 2019-12-04  Tom Tromey  <tromey@adacore.com>
 326
 327         * ada-lang.c (decode_constrained_packed_array)
 328         (ada_value_assign, value_assign_to_component): Update.
 329         * dwarf2loc.c (rw_pieced_value, access_memory)
 330         (dwarf2_compile_expr_to_ax): Update.
 331         * dwarf2read.c (dwarf2_add_field): Update.
 332         * eval.c (evaluate_subexp_standard): Update.
 333         * gdbarch.c, gdbarch.h: Rebuild.
 334         * gdbarch.sh (bits_big_endian): Remove.
 335         * gdbtypes.h (union field_location): Update comment.
 336         * target-descriptions.c (make_gdb_type): Update.
 337         * valarith.c (value_bit_index): Update.
 338         * value.c (struct value) <bitpos>: Update comment.
 339         (unpack_bits_as_long, modify_field): Update.
 340         * value.h (value_bitpos): Update comment.
 341
 342 2019-12-04  Tom Tromey  <tromey@adacore.com>
 343
 344         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 345         endian-ness.
 346
 347 2019-12-04  Tom Tromey  <tromey@adacore.com>
 348
 349         * dwarf2read.c (dwarf2_init_float_type)
 350         (dwarf2_init_complex_target_type): Add byte_order parameter.
 351         (read_base_type): Compute byte order earlier.
 352         * gdbtypes.c (init_float_type): Add byte_order parameter.
 353         * gdbtypes.h (init_float_type): Add byte_order parameter.
 354
 355 2019-12-04  Tom Tromey  <tromey@adacore.com>
 356
 357         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 358
 359 2019-12-04  Tom Tromey  <tromey@adacore.com>
 360
 361         * dwarf2read.c (process_structure_scope): Initialize
 362         "discr_offset".
 363
 364 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 365
 366         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 367         add it into the search spec.
 368         (parse_max_results_option): New function.
 369         (mi_info_functions_or_variables): Parse -max-results flag and pass
 370         it to mi_symbol_info.
 371         (mi_cmd_symbol_info_modules): Likewise.
 372         (mi_cmd_symbol_info_types): Likewise.
 373         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 374         return type to bool, change result container into a set, and don't
 375         add new results if we have enough already.
 376         (global_symbol_searcher::add_matching_msymbols): Change return
 377         type to bool, and don't add new results if we have enough already.
 378         (sort_search_symbols_remove_dups): Delete.
 379         (global_symbol_searcher::search): Early exit from search loop when
 380         we have enough results.  Use a std::set to collect the results
 381         from calling add_matching_symbols.
 382         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 383         member function.
 384         (global_symbol_searcher) <m_max_search_results>: New member
 385         variable.
 386         (global_symbol_searcher) <add_matching_symbols>: Update header
 387         comment and change return type to bool.
 388         (global_symbol_searcher) <add_matching_msymbols>: Update header
 389         comment and change return type to bool.
 390
 391 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 392
 393         * symtab.c (symbol_search::compare_search_syms): Update header
 394         comment.
 395         (global_symbol_searcher::is_suitable_msymbol): New function.
 396         (global_symbol_searcher::expand_symtabs): New function.
 397         (global_symbol_searcher::add_matching_symbols): New function.
 398         (global_symbol_searcher::add_matching_msymbols): New function.
 399         (global_symbol_searcher::search): Move most of the content
 400         into the new functions above, and call them as needed.
 401         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 402         function.
 403         (global_symbol_searcher) <add_matching_symbols>: New member
 404         function.
 405         (global_symbol_searcher) <add_matching_msymbols>: New member
 406         function.
 407         (global_symbol_searcher) <is_suitable_msymbol>: New member
 408         function.
 409
 410 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 411
 412         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 413         -symbol-info-module-variables entries.
 414         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 415         (mi_cmd_symbol_info_module_variables): Declare.
 416         * mi/mi-symbol-cmds.c
 417         (module_symbol_search_iterator): New typedef.
 418         (output_module_symbols_in_single_module_and_file): New function.
 419         (output_module_symbols_in_single_module): New function.
 420         (mi_info_module_functions_or_variables): New function.
 421         (mi_cmd_symbol_info_module_functions): New function.
 422         (mi_cmd_symbol_info_module_variables): New function.
 423         * NEWS: Mention new MI command.
 424
 425 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 426
 427         * bcache.c (hash): Remove.
 428         (hash_continue): Remove.
 429         * bcache.h (hash): Remove.
 430         (hash_continue): Remove.
 431         (struct bcache) <ctor>: Update.
 432         * psymtab.c (psymbol_hash): Update.
 433         * stabsread.c (hashname): Update.
 434         * utils.h (fast_hash): Add an argument for a start value,
 435         defaulting to zero.
 436
 437 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 438         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 439         (destroy_block_symbol_cache): New function.
 440         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 441         (resize_symbol_cache): Likewise.
 442
 443 2019-12-02  Tom Tromey  <tom@tromey.com>
 444
 445         * unittests/tui-selftests.c (run_tests): Make conditional.
 446         (_initialize_tui_selftest): Make conditional.
 447
 448 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 449
 450         * aix-thread.c (debug_aix_thread): Change type to bool.
 451
 452 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 453
 454         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 455
 456 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 457
 458         * dwarf2read.c (read_tag_string_type): Read the fields required to
 459         make a dynamic string, and possibly create a dynamic range for the
 460         string.
 461         (attr_to_dynamic_prop): Setup is_reference based on the type of
 462         attribute being processed.
 463         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 464         (resolve_dynamic_array): Rename to...
 465         (resolve_dynamic_array_or_string): ...this, update header comment,
 466         and accept TYPE_CODE_STRING.
 467         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 468
 469 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 470
 471         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 472         of its implementation from...
 473         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 474         the new function.
 475
 476 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 477
 478         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 479         create a range with stride where appropriate.
 480         * f-valprint.c: Include 'gdbarch.h'.
 481         (f77_print_array_1): Take the stride into account when walking the
 482         array.  Also convert the stride into addressable units.
 483         * gdbtypes.c (create_range_type): Initialise the stride to
 484         constant zero.
 485         (create_range_type_with_stride): New function, initialise the
 486         range as normal, and then setup the stride.
 487         (has_static_range): Include the stride here.  Also change the
 488         return type to bool.
 489         (create_array_type_with_stride): Consider the range stride if the
 490         array isn't given its own stride.
 491         (resolve_dynamic_range): Resolve the stride if needed.
 492         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 493         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 494         (TYPE_BIT_STRIDE): Define.
 495         (TYPE_ARRAY_BIT_STRIDE): Define.
 496         (create_range_type_with_stride): Declare.
 497         * valarith.c (value_subscripted_rvalue): Take range stride into
 498         account when walking the array.
 499
 500 2019-12-01  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 503         specially.
 504
 505 2019-12-01  Tom Tromey  <tom@tromey.com>
 506
 507         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 508         \0.
 509         * unittests/tui-selftests.c: New file.
 510         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 511
 512 2019-12-01  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 515
 516 2019-12-01  Tom Tromey  <tom@tromey.com>
 517
 518         * NEWS: Document new settings.
 519         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 520         * tui/tui-win.c (_initialize_tui_win): Add border style
 521         observers.
 522         * tui/tui-io.h (tui_apply_style): Declare.
 523         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 524         longer static.
 525         (apply_ansi_escape, tui_set_reverse_mode): Update.
 526         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 527         Add "skip_intensity" parameter.
 528         <changed>: New member.
 529         <do_set_value>: Declare.
 530         (tui_border_style, tui_active_border_style): Declare.
 531         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 532         globals.
 533         (cli_style_option): Initialize "changed".
 534         (cli_style_option::do_set_value): New function.
 535         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 536         parameter.  Update.
 537         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 538         (_initialize_cli_style): Update.  Create TUI border style
 539         commands.
 540
 541 2019-12-01  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 544         parameter.
 545         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 546         parameter.
 547         * tui/tui-win.h (compact_source): Declare.
 548         * tui/tui-win.c (compact_source): New global.
 549         (tui_set_compact_source, tui_show_compact_source): New functions.
 550         (_initialize_tui_win): Add "compact-source" setting.
 551         * tui/tui-source.c (tui_source_window::set_contents): Handle
 552         compact_source setting.
 553         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 554         * NEWS: Document new setting.
 555
 556 2019-11-30  Tom Tromey  <tom@tromey.com>
 557
 558         * dwarf2read.c (dwarf2_add_field): Include field offset when
 559         computing variant part length.
 560
 561 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 562         * NEWS:  Mention define-prefix.  Tell that command names can now
 563         contain a . character.
 564
 565 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 566
 567         * command.h (valid_cmd_char_p): Declare.
 568         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 569         the check of valid command char.
 570         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 571         valid_cmd_char_p.
 572         * cli/cli-script.c (validate_comname): Likewise.
 573         * completer.c (gdb_completer_command_word_break_characters):
 574         Do not remove . from the word break char, update comments.
 575         (complete_line_internal_1): Use valid_cmd_char_p.
 576         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 577         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 578
 579 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 580
 581         * cli/cli-script.c (do_define_command): Ensure a redefined
 582         prefix command is kept as a prefix command.
 583         (define_prefix_command): New function.
 584         (show_user_1): Report user defined prefixes.
 585         (_initialize_cli_script):  Create the new 'define-prefix' command.
 586         Add completers for 'define' and 'document'.
 587         * top.c (execute_command):  If command is a user-defined prefix only
 588         command, report the list of commands for this prefix command.
 589
 590 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 591
 592         * valops.c (find_oload_champ): Improve debug output.
 593
 594 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 595
 596         * valops.c (find_oload_champ): Print part of debug messages
 597         before the badness vector is std::move'd.
 598
 599 2019-11-28  Tom Tromey  <tom@tromey.com>
 600
 601         * value.c (creal_internal_fn): Fix comment.
 602
 603 2019-11-28  Tom Tromey  <tom@tromey.com>
 604
 605         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 606         flag_bound_evaluated>: Now unsigned.
 607
 608 2019-11-28  Tom Tromey  <tom@tromey.com>
 609
 610         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 611         declare.
 612
 613 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 614
 615         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 616         debug output.
 617         * jit.c (jit_unregister_code): Add debug print to match
 618         `jit_register_code`.
 619
 620 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 621
 622         * NEWS: Mention the new multithreaded symbol loading.
 623
 624 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 625
 626         * maint.c (n_worker_threads): Default to 0.
 627         (worker_threads_disabled): New function.
 628         * maint.h (worker_threads_disabled): New function.
 629         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
 630         here if worker_threads_disabled () is true.
 631         (minimal_symbol_reader::install): Skip all threading if
 632         worker_threads_disabled () is true.
 633
 634 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 635
 636         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
 637         hash code if possible.
 638         (add_minsym_to_demangled_hash_table): Likewise.
 639         (minimal_symbol_reader::install): Compute the hash codes for msymbol
 640         on the background thread.
 641         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
 642         Add these fields.
 643
 644 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 645
 646         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
 647         of the mangled name on the background thread.
 648         * symtab.c (symbol_set_names): Allow passing in the hash of the
 649         linkage_name.
 650         * symtab.h (symbol_set_names): Likewise.
 651
 652 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 653
 654         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
 655         physnames are computed for inherited DIEs.
 656
 657 2019-11-27  Tom Tromey  <tromey@adacore.com>
 658
 659         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 660         backslashes.
 661         * cp-support.c: Remove unnecessary backslashes.
 662
 663 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 664
 665         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 666         with sym->set_linkage_name.
 667         * coffread.c (coff_read_enum_type): Likewise.
 668         * mdebugread.c (parse_symbol): Likewise.
 669         * stabsread.c (patch_block_stabs): Likewise.
 670         (define_symbol): Likewise.
 671         (read_enum_type): Likewise.
 672         (common_block_end): Likewise.
 673         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 674         function.
 675         (SYMBOL_SET_LINKAGE_NAME): Remove.
 676         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 677         with sym->set_linkage_name.
 678
 679 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 680
 681         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 682         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 683         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 684         * NEWS: Mention new MI command.
 685
 686 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 687
 688         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
 689         '-symbol-info-types', and '-symbol-info-variables'.
 690         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
 691         (mi_cmd_symbol_info_types): Declare.
 692         (mi_cmd_symbol_info_variables): Declare.
 693         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
 694         (output_debug_symbol): New function.
 695         (output_nondebug_symbol): New function.
 696         (mi_symbol_info): New function.
 697         (mi_info_functions_or_variables): New function.
 698         (mi_cmd_symbol_info_functions): New function.
 699         (mi_cmd_symbol_info_types): New function.
 700         (mi_cmd_symbol_info_variables): New function.
 701         * NEWS: Mention new commands.
 702
 703 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 704
 705         * symtab.c (symbol_to_info_string): New function, most content
 706         moved from print_symbol_info, but updated to return a std::string.
 707         (print_symbol_info): Update to use symbol_to_info_string and print
 708         returned string.
 709         * symtab.h (symbol_to_info_string): Declare new function.
 710
 711 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 712
 713         * python/python.c (gdbpy_rbreak): Convert to using
 714         global_symbol_searcher.
 715         * symtab.c (file_matches): Convert return type to bool, change
 716         file list to std::vector, update header comment.
 717         (search_symbols): Rename to...
 718         (global_symbol_searcher::search): ...this and update now its
 719         a member function of global_symbol_searcher.  Take account of the
 720         changes to file_matches.
 721         (symtab_symbol_info): Convert to using global_symbol_searcher.
 722         (rbreak_command): Likewise.
 723         (search_module_symbols): Likewise.
 724         * symtab.h (enum symbol_search): Update comment.
 725         (search_symbols): Remove declaration.
 726         (class global_symbol_searcher): New class.
 727
 728 2019-11-26  Tom Tromey  <tromey@adacore.com>
 729
 730         * cp-support.c (_initialize_cp_support): Conditionally initialize
 731         gdb_demangle_attempt_core_dump.
 732
 733 2019-11-26  Tom Tromey  <tom@tromey.com>
 734
 735         * python/py-function.c (fnpy_init): Update.
 736         * value.h (add_internal_function): Adjust declaration.
 737         * value.c (function_destroyer): Remove.
 738         (do_add_internal_function): Don't set destroyer or copy name.
 739         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 740         Set name_allocated.
 741         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 742         (cmdpy_init): Set name_allocated.
 743         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 744         member.
 745         (~cmd_list_element): Free "name" if needed.
 746
 747 2019-11-26  Tom Tromey  <tom@tromey.com>
 748
 749         * value.h (add_internal_function): Add new overload.  Move
 750         documentation from value.h.
 751         * value.c (do_add_internal_function): New function.
 752         (add_internal_function): Use it.  Add new overload.
 753         (function_destroyer): Don't free doc.
 754         * python/py-function.c (fnpy_init): Update.
 755
 756 2019-11-26  Tom Tromey  <tom@tromey.com>
 757
 758         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 759         (cmdpy_init): Set "doc_allocated".
 760
 761 2019-11-26  Tom Tromey  <tom@tromey.com>
 762
 763         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 764         name of worker thread.
 765         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 766         pthread_setname_np.
 767         * configure, config.in: Rebuild.
 768
 769 2019-11-26  Tom Tromey  <tom@tromey.com>
 770
 771         * python/python.c (class gdbpy_gil): New.
 772         (struct gdbpy_event): Add constructor, destructor, operator().
 773         (gdbpy_post_event): Use run_on_main_thread.
 774         (gdbpy_initialize_events): Remove.
 775         (do_start_initialization): Update.
 776
 777 2019-11-26  Tom Tromey  <tom@tromey.com>
 778
 779         * NEWS: Add entry.
 780         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 781         commands.  Call update_thread_pool_size.
 782         (update_thread_pool_size, maintenance_set_worker_threads): New
 783         functions.
 784         (n_worker_threads): New global.
 785
 786 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 787             Tom Tromey  <tom@tromey.com>
 788
 789         * minsyms.c (minimal_symbol_reader::install): Use
 790         parallel_for_each.
 791         * gdbsupport/parallel-for.h: New file.
 792         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 793
 794 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 795             Tom Tromey  <tom@tromey.com>
 796
 797         * gdbsupport/thread-pool.h: New file.
 798         * gdbsupport/thread-pool.c: New file.
 799         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 800         (HFILES_NO_SRCDIR): Add thread-pool.h.
 801
 802 2019-11-26  Tom Tromey  <tom@tromey.com>
 803
 804         * event-top.h (thread_local_segv_handler): Declare.
 805         * event-top.c (thread_local_segv_handler): New global.
 806         (install_handle_sigsegv, handle_sigsegv): New functions.
 807         (async_init_signals): Install SIGSEGV handler.
 808         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 809         thread-local.
 810         (report_failed_demangle): New function.
 811         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 812         handler-setting code, instead use segv_handler.  Run warning code
 813         on main thread.
 814
 815 2019-11-26  Tom Tromey  <tom@tromey.com>
 816
 817         * run-on-main-thread.c: New file.
 818         * run-on-main-thread.h: New file.
 819         * unittests/main-thread-selftests.c: New file.
 820         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 821         main-thread-selftests.c.
 822         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 823         (COMMON_SFILES): Add run-on-main-thread.c.
 824
 825 2019-11-26  Tom Tromey  <tom@tromey.com>
 826
 827         * main.c (setup_alternate_signal_stack): Remove.
 828         (captured_main_1): Use gdb::alternate_signal_stack.
 829         * gdbsupport/alt-stack.h: New file.
 830
 831 2019-11-26  Tom Tromey  <tom@tromey.com>
 832
 833         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 834         Remove comment.
 835         (save_original_signals_state, restore_original_signals_state): Use
 836         gdb_sigmask.
 837         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 838         (_initialize_linux_nat): Use gdb_sigmask.
 839         * guile/guile.c (_initialize_guile): Use block_signals.
 840         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 841         * gdbsupport/gdb-sigmask.h: New file.
 842         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 843         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 844         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 845         pthread_sigmask.
 846         * configure, config.in: Rebuild.
 847         * gdbsupport/block-signals.h: New file.
 848
 849 2019-11-26  Tom Tromey  <tom@tromey.com>
 850
 851         * acinclude.m4: Include ax_pthread.m4.
 852         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 853         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 854         (CLIBS): Use PTHREAD_LIBS.
 855         (aclocal_m4_deps): Add ax_pthread.m4.
 856         * config.in, configure: Rebuild.
 857         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 858
 859 2019-11-26  Tom Tromey  <tom@tromey.com>
 860
 861         * symtab.h (struct minimal_symbol) <name_set>: New member.
 862         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 863         Don't call symbol_set_names.
 864         (minimal_symbol_reader::install): Call symbol_set_names.
 865
 866 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 867
 868         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 869         restore_active_ext_lang, as GIL is needed for (indirectly)
 870         called PyOS_InterruptOccurred.
 871
 872 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 873
 874         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 875         definition.
 876
 877 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 878
 879         * remote-sim.c (simulator_command): Make static, remove
 880         declaration.
 881
 882 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 883
 884         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 885         static.
 886         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 887         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 888         (main): Likewise.
 889         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 890         (main): Likewise.
 891         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 892         (main): Likewise.
 893         * unittests/basic_string_view/element_access/char/1.cc (test01):
 894         Likewise.
 895         (main): Likewise.
 896         * unittests/basic_string_view/element_access/char/empty.cc (main):
 897         Likewise.
 898         * unittests/basic_string_view/element_access/char/front_back.cc
 899         (test01): Likewise.
 900         (main): Likewise.
 901         * unittests/basic_string_view/inserters/char/2.cc (test05):
 902         Likewise.
 903         (main): Likewise.
 904         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 905         (test01): Likewise.
 906         (main): Likewise.
 907         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 908         (test01): Likewise.
 909         (main): Likewise.
 910         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 911         Likewise.
 912         * unittests/basic_string_view/operations/compare/char/1.cc
 913         (test01): Likewise.
 914         (main): Likewise.
 915         * unittests/basic_string_view/operations/compare/char/13650.cc
 916         (test01): Likewise.
 917         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 918         Likewise.
 919         (main): Likewise.
 920         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 921         Likewise.
 922         (main): Likewise.
 923         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 924         Likewise.
 925         (main): Likewise.
 926         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 927         Likewise.
 928         (main): Likewise.
 929         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 930         Likewise.
 931         (main): Likewise.
 932         * unittests/basic_string_view/operations/find/char/4.cc (main):
 933         Likewise.
 934         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 935         Likewise.
 936         (main): Likewise.
 937         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 938         Likewise.
 939         (main): Likewise.
 940         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 941         Likewise.
 942         (main): Likewise.
 943         * unittests/basic_string_view/operations/substr/char/1.cc
 944         (test01): Likewise.
 945         (main): Likewise.
 946         * unittests/basic_string_view/operators/char/2.cc (main):
 947         Likewise.
 948         * unittests/optional/assignment/1.cc (test): Likewise.
 949         * unittests/optional/assignment/2.cc (test): Likewise.
 950         * unittests/optional/assignment/3.cc (test): Likewise.
 951         * unittests/optional/assignment/4.cc (test): Likewise.
 952         * unittests/optional/assignment/5.cc (test): Likewise.
 953         * unittests/optional/assignment/6.cc (test): Likewise.
 954         * unittests/optional/assignment/7.cc (test): Likewise.
 955         * unittests/optional/cons/copy.cc (test): Likewise.
 956         * unittests/optional/cons/default.cc (test): Likewise.
 957         * unittests/optional/cons/move.cc (test): Likewise.
 958         * unittests/optional/cons/value.cc (test): Likewise.
 959         * unittests/optional/in_place.cc (test): Likewise.
 960         * unittests/optional/observers/1.cc (test): Likewise.
 961         * unittests/optional/observers/2.cc (test): Likewise.
 962
 963 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 964
 965         * tui-win.h (tui_set_var_cmd): Remove.
 966         * tui-win.c (tui_set_var_cmd): Make static.
 967
 968 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 969
 970         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 971         rbreak_command_wrapper): Remove.
 972         * symtab.c (rbreak_command_wrapper): Remove.
 973
 974 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 975
 976         * inferior.h (info_terminal_command): Remove declaration.
 977         * inflow.c (info_terminal_command): Make static.
 978
 979 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 980
 981         * inferior.c (exit_inferior_silent): Remove.
 982
 983 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 984
 985         * dictionary.c (dict_empty, mdict_empty): Remove.
 986         * dictionary.c (mdict_empty): Remove.
 987
 988 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 989
 990          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
 991          (arc_insn_get_memory_offset): Likewise.
 992          (arc_insn_dump): Likewise.
 993          * cp-support.c (test_cp_symbol_name_matches): Likewise.
 994          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
 995          * dictionary.c (dict_iterator_next): Likewise.
 996          (dict_iter_match_first): Likewise.
 997          (dict_iter_match_next): Likewise.
 998          * f-lang.c (evaluate_subexp_f): Likewise.
 999          * hppa-tdep.c (hppa_read_pc): Likewise.
1000          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1001          * parse.c (write_exp_elt_msym): Likewise.
1002          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1003          * remote.c (remote_packet_size): Likewise.
1004          (remote_notif_stop_parse): Likewise.
1005          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1006          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1007          * source.c (prepare_path_for_appending): Likewise.
1008          * sparc64-linux-tdep.c
1009          (sparc64_linux_handle_segmentation_fault); Likewise.
1010          * stack.c (frame_selection_by_function_completer): Likewise.
1011
1012 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1013
1014         * completer.c (set_gdb_completion_word_break_characters):
1015         Remove.
1016
1017 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1018
1019         * dwarf-index-write.c: Include dwarf-index-write.h.
1020         * mi/mi-interp.c: Include mi/mi-interp.h.
1021
1022 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1023
1024         * aarch32-tdep.c: Include aarch32-tdep.h.
1025         * aarch32-tdep.h: Forward-declare struct target_desc.
1026
1027 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1028
1029         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1030         strerror.
1031         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1032         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1033
1034 2019-11-25  Tom de Vries  <tdevries@suse.de>
1035
1036         * contrib/words.sh: Add -c option.
1037
1038 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1039
1040         * solib.c (solib_find_1): Change int to bool.
1041         (exec_file_find): Change int to bool.
1042         (solib_find): Change int to bool.
1043         (solib_read_symbols): Change int to bool.
1044         (solib_used): Change int to bool.
1045         (solib_add): Change int to bool.
1046         (info_sharedlibrary_command): Change int to bool.
1047         (solib_contains_address_p): Change int to bool.
1048         (solib_keep_data_in_core): Change int to bool.
1049         (in_solib_dynsym_resolve_code): Change int to bool.
1050         (reload_shared_libraries_1): Change int to bool.
1051         (gdb_sysroot_changed): Change int to bool.
1052         * solib.h (solib_read_symbols): Change int to bool.
1053         (solib_contains_address_p): Change int to bool.
1054         (solib_keep_data_in_core): Change int to bool.
1055         (in_solib_dynsym_resolve_code): Change int to bool.
1056         (libpthread_name_p): Change int to bool.
1057
1058 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1059
1060         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1061         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1062         (remote_packet_max_chars): New static global.
1063         (show_remote_packet_max_chars): New function.
1064         (remote_target::putpkt_binary): Adjust to use new
1065         remote_packet_max_chars option.
1066         (remote_target::getpkt_or_notif_sane_1): Likewise.
1067         (_initialize_remote): Register new remote-packet-max-chars option.
1068
1069 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1070
1071         * m68k-linux-nat.c: Include gdbarch.h.
1072
1073 2019-11-24  Tom Tromey  <tom@tromey.com>
1074
1075         * symfile.c (read_symbols): Update.
1076         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1077         bool.
1078         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1079         (psym_lookup_symbol, psym_find_last_source_symtab)
1080         (psym_forget_cached_source_info, psym_print_stats)
1081         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1082         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1083         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1084         (psym_find_compunit_symtab_by_address)
1085         (maintenance_print_psymbols, maintenance_info_psymtabs)
1086         (maintenance_check_psymtabs): Update.
1087         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1088         bool.
1089
1090 2019-11-22  Tom Tromey  <tom@tromey.com>
1091
1092         * observable.h: Update comments.
1093
1094 2019-11-22  Tom Tromey  <tromey@adacore.com>
1095
1096         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1097         (print_ada_task_info): Don't try to fetch thread id if task is not
1098         alive.
1099
1100 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1101
1102         * ada-exp.y: Update.
1103         * ada-lang.c (sort_choices): Update.
1104         (ada_print_symbol_signature): Update.
1105         (resolve_subexp): Update.
1106         (ada_parse_renaming): Update.
1107         (ada_read_renaming_var_value): Update.
1108         (lesseq_defined_than): Update.
1109         (remove_extra_symbols): Update.
1110         (remove_irrelevant_renamings): Update.
1111         (ada_add_block_symbols): Update.
1112         (ada_collect_symbol_completion_matches): Update.
1113         (ada_is_renaming_symbol): Update.
1114         (aggregate_assign_from_choices): Update.
1115         (ada_evaluate_subexp): Update.
1116         (ada_has_this_exception_support): Update.
1117         (ada_is_non_standard_exception_sym): Update.
1118         (ada_add_exceptions_from_frame): Update.
1119         (ada_add_global_exceptions): Update.
1120         (ada_print_subexp): Update.
1121         * ax-gdb.c (gen_var_ref): Update.
1122         (gen_maybe_namespace_elt): Update.
1123         (gen_expr_for_cast): Update.
1124         (gen_expr): Update.
1125         * block.h: Update.
1126         * blockframe.c (find_pc_partial_function): Update.
1127         * breakpoint.c (print_breakpoint_location): Update.
1128         (update_static_tracepoint): Update.
1129         * btrace.c (ftrace_print_function_name): Update.
1130         (ftrace_function_switched): Update.
1131         * buildsym.c (find_symbol_in_list): Update.
1132         * c-exp.y: Update.
1133         * c-typeprint.c (c_print_typedef): Update.
1134         (c_type_print_template_args): Update.
1135         * cli/cli-cmds.c (edit_command): Update.
1136         (list_command): Update.
1137         (print_sal_location): Update.
1138         * coffread.c (patch_opaque_types): Update.
1139         (process_coff_symbol): Update.
1140         (coff_read_enum_type): Update.
1141         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1142         (convert_one_symbol): Update.
1143         (hash_symname): Update.
1144         (eq_symname): Update.
1145         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1146         * compile/compile-cplus-types.c (debug_print_scope): Update.
1147         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1148         * compile/compile-object-load.c (get_out_value_type): Update.
1149         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1150         (search_symbol_list): Update.
1151         (cp_lookup_symbol_imports_or_template): Update.
1152         * cp-support.c (overload_list_add_symbol): Update.
1153         * ctfread.c (psymtab_to_symtab): Update.
1154         * dbxread.c (cp_set_block_scope): Update.
1155         * dictionary.c (iter_match_first_hashed): Update.
1156         (iter_match_next_hashed): Update.
1157         (insert_symbol_hashed): Update.
1158         (iter_match_next_linear): Update.
1159         * dictionary.h: Update.
1160         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1161         (locexpr_describe_location_piece): Update.
1162         (locexpr_describe_location_1): Update.
1163         (locexpr_generate_c_location): Update.
1164         (loclist_describe_location): Update.
1165         (loclist_generate_c_location): Update.
1166         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1167         (read_func_scope): Update.
1168         (process_enumeration_scope): Update.
1169         (new_symbol): Update.
1170         (dwarf2_const_value): Update.
1171         (dwarf2_symbol_mark_computed): Update.
1172         * eval.c (evaluate_funcall): Update.
1173         (evaluate_subexp_standard): Update.
1174         * expprint.c (print_subexp_standard): Update.
1175         (dump_subexp_body_standard): Update.
1176         * f-valprint.c (info_common_command_for_block): Update.
1177         * findvar.c (get_hosting_frame): Update.
1178         (default_read_var_value): Update.
1179         * go-lang.c (go_symbol_package_name): Update.
1180         * guile/scm-block.c (bkscm_print_block_smob): Update.
1181         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1182         (gdbscm_symbol_name): Update.
1183         (gdbscm_symbol_linkage_name): Update.
1184         (gdbscm_symbol_print_name): Update.
1185         * infcall.c (get_function_name): Update.
1186         * infcmd.c (jump_command): Update.
1187         (finish_command): Update.
1188         * infrun.c (insert_exception_resume_breakpoint): Update.
1189         * linespec.c (canonicalize_linespec): Update.
1190         (create_sals_line_offset): Update.
1191         (convert_linespec_to_sals): Update.
1192         (complete_label): Update.
1193         (find_label_symbols_in_block): Update.
1194         * m2-typeprint.c (m2_print_typedef): Update.
1195         * mdebugread.c (mdebug_reg_to_regnum): Update.
1196         (parse_symbol): Update.
1197         (mylookup_symbol): Update.
1198         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1199         (list_args_or_locals): Update.
1200         * objc-lang.c (compare_selectors): Update.
1201         (info_selectors_command): Update.
1202         (compare_classes): Update.
1203         (info_classes_command): Update.
1204         (find_imps): Update.
1205         * p-typeprint.c (pascal_print_typedef): Update.
1206         * printcmd.c (build_address_symbolic): Update.
1207         (info_address_command): Update.
1208         (print_variable_and_value): Update.
1209         * python/py-framefilter.c (extract_sym): Update.
1210         (py_print_single_arg): Update.
1211         * python/py-symbol.c (sympy_str): Update.
1212         (sympy_get_name): Update.
1213         (sympy_get_linkage_name): Update.
1214         * python/python.c (gdbpy_rbreak): Update.
1215         * record-btrace.c (btrace_get_bfun_name): Update.
1216         (btrace_call_history): Update.
1217         * rust-lang.c (rust_print_typedef): Update.
1218         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1219         * stabsread.c (stab_reg_to_regnum): Update.
1220         (define_symbol): Update.
1221         (read_enum_type): Update.
1222         (common_block_end): Update.
1223         (cleanup_undefined_types_1): Update.
1224         (scan_file_globals): Update.
1225         * stack.c (print_frame_arg): Update.
1226         (print_frame_args): Update.
1227         (find_frame_funname): Update.
1228         (info_frame_command_core): Update.
1229         (iterate_over_block_locals): Update.
1230         (print_block_frame_labels): Update.
1231         (do_print_variable_and_value): Update.
1232         (iterate_over_block_arg_vars): Update.
1233         (return_command): Update.
1234         * symmisc.c (dump_symtab_1): Update.
1235         (print_symbol): Update.
1236         * symtab.c (eq_symbol_entry): Update.
1237         (symbol_cache_dump): Update.
1238         (lookup_language_this): Update.
1239         (find_pc_sect_line): Update.
1240         (skip_prologue_sal): Update.
1241         (symbol_search::compare_search_syms): Update.
1242         (treg_matches_sym_type_name): Update.
1243         (search_symbols): Update.
1244         (print_symbol_info): Update.
1245         (rbreak_command): Update.
1246         (completion_list_add_symbol): Update.
1247         (find_gnu_ifunc): Update.
1248         (get_symbol_address): Update.
1249         (search_module_symbols): Update.
1250         (info_module_subcommand): Update.
1251         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1252         (SYMBOL_LINKAGE_NAME): Remove.
1253         (SYMBOL_DEMANGLED_NAME): Remove.
1254         (SYMBOL_PRINT_NAME): Remove.
1255         (SYMBOL_SEARCH_NAME): Remove.
1256         * tracepoint.c (set_traceframe_context): Update.
1257         (validate_actionline): Update.
1258         (collection_list::collect_symbol): Update.
1259         (encode_actions_1): Update.
1260         (info_scope_command): Update.
1261         (print_one_static_tracepoint_marker): Update.
1262         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1263         * valops.c (address_of_variable): Update.
1264         (find_overload_match): Update.
1265         (find_oload_champ): Update.
1266
1267 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1268
1269         * ada-lang.c (ada_lookup_simple_minsym): Update.
1270         (ada_collect_symbol_completion_matches): Update.
1271         * ada-tasks.c (read_atcb): Update.
1272         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1273         (amd64_windows_skip_trampoline_code): Update.
1274         * arm-tdep.c (skip_prologue_function): Update.
1275         (arm_skip_stack_protector): Update.
1276         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1277         (arm_wince_skip_main_prologue): Update.
1278         * ax-gdb.c (gen_expr): Update.
1279         * block.c (call_site_for_pc): Update.
1280         * blockframe.c (find_pc_partial_function): Update.
1281         * breakpoint.c (set_breakpoint_location_function): Update.
1282         * btrace.c (ftrace_print_function_name): Update.
1283         (ftrace_function_switched): Update.
1284         * c-valprint.c (print_unpacked_pointer): Update.
1285         * coffread.c (coff_symfile_read): Update.
1286         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1287         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1288         * dwarf-index-write.c (write_psymbols): Update.
1289         * dwarf2loc.c (call_site_to_target_addr): Update.
1290         (func_verify_no_selftailcall): Update.
1291         (tailcall_dump): Update.
1292         (call_site_find_chain_1): Update.
1293         (dwarf_expr_reg_to_entry_parameter): Update.
1294         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1295         * eval.c (evaluate_funcall): Update.
1296         (evaluate_subexp_standard): Update.
1297         (evaluate_subexp_for_sizeof): Update.
1298         * expprint.c (print_subexp_standard): Update.
1299         (dump_subexp_body_standard): Update.
1300         * frame.c (get_prev_frame_always_1): Update.
1301         * frv-tdep.c (frv_skip_main_prologue): Update.
1302         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1303         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1304         (gnuv3_get_typename_from_type_info): Update.
1305         (gnuv3_skip_trampoline): Update.
1306         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1307         * i386-tdep.c (i386_skip_main_prologue): Update.
1308         (i386_pe_skip_trampoline_code): Update.
1309         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1310         * infcall.c (get_function_name): Update.
1311         * linespec.c (minsym_found): Update.
1312         * linux-fork.c (info_checkpoints_command): Update.
1313         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1314         (m32c_m16c_pointer_to_address): Update.
1315         * maint.c (maintenance_translate_address): Update.
1316         * minsyms.c (add_minsym_to_hash_table): Update.
1317         (add_minsym_to_demangled_hash_table): Update.
1318         (lookup_minimal_symbol_mangled): Update.
1319         (lookup_minimal_symbol_demangled): Update.
1320         (lookup_minimal_symbol_linkage): Update.
1321         (lookup_minimal_symbol_text): Update.
1322         (lookup_minimal_symbol_by_pc_name): Update.
1323         (minimal_symbol_is_less_than): Update.
1324         (compact_minimal_symbols): Update.
1325         (build_minimal_symbol_hash_tables): Update.
1326         (find_solib_trampoline_target): Update.
1327         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1328         (mips_skip_pic_trampoline_code): Update.
1329         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1330         * objc-lang.c (info_selectors_command): Update.
1331         (info_classes_command): Update.
1332         (find_methods): Update.
1333         (find_imps): Update.
1334         * p-valprint.c (pascal_val_print): Update.
1335         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1336         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1337         * printcmd.c (build_address_symbolic): Update.
1338         (info_symbol_command): Update.
1339         * psymtab.c (psymbol_name_matches): Update.
1340         (match_partial_symbol): Update.
1341         (lookup_partial_symbol): Update.
1342         (print_partial_symbols): Update.
1343         (sort_pst_symbols): Update.
1344         (maintenance_check_psymtabs): Update.
1345         * python/py-framefilter.c (py_print_frame): Update.
1346         * python/python.c (gdbpy_rbreak): Update.
1347         * record-btrace.c (btrace_get_bfun_name): Update.
1348         (btrace_call_history): Update.
1349         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1350         (rs6000_skip_trampoline_code): Update.
1351         * sol-thread.c (info_cb): Update.
1352         * stabsread.c (scan_file_globals): Update.
1353         * stack.c (find_frame_funname): Update.
1354         (info_frame_command_core): Update.
1355         * symmisc.c (dump_msymbols): Update.
1356         * symtab.c (symbol_natural_name): Rename to..,
1357         (general_symbol_info::natural_name): ...this.
1358         (symbol_demangled_name): Rename to...
1359         (general_symbol_info::demangled_name): ...this.
1360         (symbol_search_name): Rename to...
1361         (general_symbol_info::search_name): ...this.
1362         (symbol_matches_search_name): Update.
1363         (find_pc_sect_line): Update.
1364         (skip_prologue_sal): Update.
1365         (search_symbols): Update.
1366         (print_msymbol_info): Update.
1367         (rbreak_command): Update.
1368         (completion_list_add_msymbol): Update.
1369         (completion_list_objc_symbol): Update.
1370         (get_msymbol_address): Update.
1371         * symtab.h (struct general_symbol_info): Add member functions
1372         natural_name (), linkage_name (), print_name (), demangled_name (),
1373         and search_name ().
1374         (SYMBOL_NATURAL_NAME): Update.
1375         (symbol_natural_name): Move to a member function on general_symbol_info.
1376         (SYMBOL_DEMANGLED_NAME): Update.
1377         (symbol_demangled_name): Move to a member function on
1378         general_symbol_info.
1379         (SYMBOL_SEARCH_NAME): Update.
1380         (symbol_search_name): Move to a member function on general_symbol_info.
1381         (MSYMBOL_NATURAL_NAME): Remove.
1382         (MSYMBOL_LINKAGE_NAME): Remove.
1383         (MSYMBOL_PRINT_NAME): Remove.
1384         (MSYMBOL_DEMANGLED_NAME): Remove.
1385         (MSYMBOL_SEARCH_NAME): Remove.
1386         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1387
1388 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1389
1390         * symtab.c (create_demangled_names_hash): Use per_bfd->
1391         minimal_symbol_count for computing the initial size, if greater
1392         than our default size.
1393
1394 2019-11-22  Tom de Vries  <tdevries@suse.de>
1395
1396         * contrib/words.sh: Improve words extraction.
1397
1398 2019-11-22  Tom de Vries  <tdevries@suse.de>
1399
1400         * contrib/words.sh: Combine sed invocations.
1401
1402 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1403
1404         * Makefile.in: Update.
1405         * demangle.c: Rename to...
1406         * gdb-demangle.c: ..this.
1407         (is_cplus_marker): Change return type to bool.
1408         (_initialize_demangler): Rename to...
1409         (_initialize_gdb_demangle): ...this.
1410         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1411         * symtab.h (demangle): Remove declaration; instead include
1412         gdb-demangle.h.
1413
1414 2019-11-21  Tom Tromey  <tromey@adacore.com>
1415
1416         * gdbsupport/format.c (format_pieces): Parse %I64d.
1417         * unittests/format_pieces-selftests.c (test_windows_formats): New
1418         function.
1419         (run_tests): Call it.
1420
1421 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1422
1423         Byte reverse display of variables with DW_END_big, DW_END_little
1424         (DW_AT_endianity) dwarf attributes if different than the native
1425         byte order.
1426         * ada-lang.c (ada_value_binop):
1427         Use type_byte_order instead of gdbarch_byte_order.
1428         * ada-valprint.c (printstr):
1429         (ada_val_print_string):
1430         * ada-lang.c (value_pointer):
1431         (ada_value_binop):
1432         Use type_byte_order instead of gdbarch_byte_order.
1433         * c-lang.c (c_get_string):
1434         Use type_byte_order instead of gdbarch_byte_order.
1435         * c-valprint.c (c_val_print_array):
1436         Use type_byte_order instead of gdbarch_byte_order.
1437         * cp-valprint.c (cp_print_class_member):
1438         Use type_byte_order instead of gdbarch_byte_order.
1439         * dwarf2loc.c (rw_pieced_value):
1440         Use type_byte_order instead of gdbarch_byte_order.
1441         * dwarf2read.c (read_base_type): Handle DW_END_big,
1442         DW_END_little
1443         * f-lang.c (f_get_encoding):
1444         Use type_byte_order instead of gdbarch_byte_order.
1445         * findvar.c (default_read_var_value):
1446         Use type_byte_order instead of gdbarch_byte_order.
1447         * gdbtypes.c (check_types_equal):
1448         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1449         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1450         and TYPE_ENDIANITY_LITTLE if set.
1451         (type_byte_order): new function.
1452         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1453         (struct main_type) <flag_endianity_not_default>:
1454         New field.
1455         (type_byte_order): New function.
1456         * infcmd.c (default_print_one_register_info):
1457         Use type_byte_order instead of gdbarch_byte_order.
1458         * p-lang.c (pascal_printstr):
1459         Use type_byte_order instead of gdbarch_byte_order.
1460         * p-valprint.c (pascal_val_print):
1461         Use type_byte_order instead of gdbarch_byte_order.
1462         * printcmd.c (print_scalar_formatted):
1463         Use type_byte_order instead of gdbarch_byte_order.
1464         * solib-darwin.c (darwin_current_sos):
1465         Use type_byte_order instead of gdbarch_byte_order.
1466         * solib-svr4.c (solib_svr4_r_ldsomap):
1467         Use type_byte_order instead of gdbarch_byte_order.
1468         * stap-probe.c (stap_modify_semaphore):
1469         Use type_byte_order instead of gdbarch_byte_order.
1470         * target-float.c (target_float_same_format_p):
1471         Use type_byte_order instead of gdbarch_byte_order.
1472         * valarith.c (scalar_binop):
1473         (value_bit_index):
1474         Use type_byte_order instead of gdbarch_byte_order.
1475         * valops.c (value_cast):
1476         Use type_byte_order instead of gdbarch_byte_order.
1477         * valprint.c (generic_emit_char):
1478         (generic_printstr):
1479         (val_print_string):
1480         Use type_byte_order instead of gdbarch_byte_order.
1481         * value.c (unpack_long):
1482         (unpack_bits_as_long):
1483         (unpack_value_bitfield):
1484         (modify_field):
1485         (pack_long):
1486         (pack_unsigned_long):
1487         Use type_byte_order instead of gdbarch_byte_order.
1488         * findvar.c (unsigned_pointer_to_address):
1489         (signed_pointer_to_address):
1490         (unsigned_address_to_pointer):
1491         (address_to_signed_pointer):
1492         (default_read_var_value):
1493         (default_value_from_register):
1494         Use type_byte_order instead of gdbarch_byte_order.
1495         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1496         Use type_byte_order instead of gdbarch_byte_order.
1497         * riscv-tdep.c (riscv_print_one_register_info):
1498         Use type_byte_order instead of gdbarch_byte_order.
1499
1500 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1501
1502         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1503         (current_ui_gdb_stdin_ptr): Likewise.
1504         (current_ui_gdb_stderr_ptr): Likewise.
1505         (current_ui_gdb_stdlog_ptr): Likewise.
1506         (current_ui_current_uiout_ptr): Likewise.
1507         (gen_ret_current_ui_field_ptr): Remove.
1508
1509 2019-11-21  Tom de Vries  <tdevries@suse.de>
1510
1511         PR gdb/24956
1512         * cli/cli-script.c (execute_control_command): Only switch to
1513         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1514
1515 2019-11-19  Tom Tromey  <tom@tromey.com>
1516
1517         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1518         Now static.  Change type of "name".
1519         (tui_set_win_height_command): Don't copy "arg".
1520         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1521         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1522
1523 2019-11-19  Ali Tamur <tamur@google.com>
1524
1525         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1526         "if (attr != nullptr)".
1527         (dwarf2_find_base_address): Likewise.
1528         (dwarf2_build_include_psymtabs): Likewise.
1529         (read_cutu_die_from_dwo): Likewise.
1530         (read_func_scope): Likewise.
1531         (read_call_site_scope): Likewise.
1532         (dwarf2_get_pc_bounds): Likewise.
1533         (dwarf2_record_block_ranges): Likewise.
1534         (dwarf2_add_field): Likewise.
1535         (dwarf2_add_member_fn): Likewise.
1536         (read_structure_type): Likewise.
1537         (read_enumeration_type): Likewise.
1538         (read_array_type): Likewise.
1539         (read_array_order): Likewise.
1540         (read_set_type): Likewise.
1541         (read_common_block): Likewise.
1542         (read_tag_reference_type): Likewise.
1543         (read_tag_string_type): Likewise.
1544         (read_subroutine_type): Likewise.
1545         (read_base_type): Likewise.
1546         (read_subrange_type): Likewise.
1547         (new_symbol): Likewise.
1548         (prepare_one_comp_unit): Likewise.
1549
1550 2019-11-19  Tom Tromey  <tromey@adacore.com>
1551
1552         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1553         result in error when DebugActiveProcess fails.
1554
1555 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1556             Pedro Alves  <palves@redhat.com>
1557
1558         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1559         * target.c (target_stack::push): Call 'unpush' if there's a
1560         target on top of the stack.
1561
1562 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1563
1564         * python/py-block.c (blpy_dealloc): Call tp_free.
1565         (blpy_block_syms_dealloc): Likewise.
1566         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1567         * python/py-inferior.c (infpy_dealloc): Likewise.
1568         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1569         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1570         * python/py-symbol.c (sympy_dealloc): Likewise.
1571         * python/py-symtab.c (stpy_dealloc): Likewise.
1572         * python/py-type.c (typy_iterator_dealloc): Likewise.
1573
1574 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1575
1576         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1577         constructor instead of using a class initializer.
1578
1579 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1580
1581         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1582         * configure: Regenerate.
1583         * configure.ac: Don't source common.host.
1584         * gdbsupport/common.host: Remove.
1585         * gdbsupport/mingw-strerror.c: Remove.
1586         * gdbsupport/posix-strerror.c: Rename to...
1587         * gdbsupport/safe-strerror.c: ...this.
1588
1589 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1590
1591         * maint.c (scoped_command_stats::print_time): Use localtime_r
1592         instead of localtime (provided through gnulib if necessary).
1593         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1594         of ctime.
1595
1596 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1597
1598         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1599         avoid compile errors.
1600
1601 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1602
1603         * config.in: Regenerate.
1604         * configure: Regenerate.
1605         * gdbsupport/common.m4: No longer check for strerror_r.
1606         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1607         POSIX version of strerror_r, now that gnulib provides it if
1608         necessary.
1609
1610 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1611
1612         * README (`configure' options): Update.
1613
1614 2019-11-14  Tom Tromey  <tromey@adacore.com>
1615
1616         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1617         expected type for the RHS if the LHS is a convenience variable.
1618
1619 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1620
1621         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1622         Provide explicit default and copy constructor.
1623
1624 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1625
1626         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1627         only call Py_INCREF (newbp) in the bppy_pending_object case.
1628
1629 2019-11-13  Tom Tromey  <tromey@adacore.com>
1630
1631         PR build/25182:
1632         * psympriv.h (partial_symbol): Remove static assert.
1633         * symtab.h (general_symbol_info, symbol): Remove static assert.
1634
1635 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1636
1637         * gdbsupport/format.c (format_pieces::format_pieces): Support
1638         printf 'z' size modifier.
1639         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1640         * printcmd.c (ui_printf):  Handle size_t_arg.
1641         * ui-out.c (ui_out::vmessage): Likewise.
1642         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1643         function.
1644         (run_tests): Call test_format_int_sizes.
1645
1646 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1647
1648         * ada-exp.y (write_ambiguous_var): Update.
1649         * buildsym.c (add_symbol_to_list): Update.
1650         * dwarf2read.c (read_variable): Update.
1651         (new_symbol): Update.
1652         * jit.c (finalize_symtab): Update.
1653         * language.c (language_alloc_type_symbol): Update.
1654         * symtab.c (fixup_symbol_section): Update.
1655         (initialize_objfile_symbol_1): Move code to...
1656         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1657         (allocate_symbol): Update.
1658         (allocate_template_symbol): Update.
1659         (get_symbol_address): Update.
1660         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1661         of having as a field, and add a constructor.
1662         (SYMBOL_VALUE): Update.
1663         (SYMBOL_VALUE_ADDRESS): Update.
1664         (SET_SYMBOL_VALUE_ADDRESS): Update.
1665         (SYMBOL_VALUE_BYTES): Update.
1666         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1667         (SYMBOL_BLOCK_VALUE): Update.
1668         (SYMBOL_VALUE_CHAIN): Update.
1669         (SYMBOL_LANGUAGE): Update.
1670         (SYMBOL_SECTION): Update.
1671         (SYMBOL_OBJ_SECTION): Update.
1672         (SYMBOL_SET_LANGUAGE): Update.
1673         (SYMBOL_SET_LINKAGE_NAME): Update.
1674         (SYMBOL_SET_NAMES): Update.
1675         (SYMBOL_NATURAL_NAME): Update.
1676         (SYMBOL_LINKAGE_NAME): Update.
1677         (SYMBOL_DEMANGLED_NAME): Update.
1678         (SYMBOL_SEARCH_NAME): Update.
1679         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1680         (struct symbol): Update.
1681         (struct template_symbol): Update.
1682         (struct rust_vtable_symbol): Update.
1683         * xcoffread.c (SYMBOL_DUP): Update.
1684
1685 2019-11-12  Tom Tromey  <tom@tromey.com>
1686
1687         * tui/tui-layout.c (show_layout): Set current_layout.
1688         (show_source_disasm_command, show_data)
1689         (show_source_or_disasm_and_command): Don't set current_layout.
1690
1691 2019-11-12  Tom Tromey  <tom@tromey.com>
1692
1693         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1694
1695 2019-11-12  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-win.c (resize_message): New global.
1698         (show_tui_resize_message): New function.
1699         (tui_async_resize_screen): Print message if requested.
1700         (_initialize_tui_win): Add tui-resize-message setting.
1701         * NEWS: Add entry for new commands.
1702
1703 2019-11-11  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1706         functions.
1707
1708 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1709
1710         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1711
1712 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1713
1714         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1715         function.
1716         * python/python-internal.h (gdbpy_lookup_static_symbols):
1717         Declare new function.
1718         * python/python.c (python_GdbMethods): Add
1719         gdb.lookup_static_symbols method.
1720         * NEWS: Mention gdb.lookup_static_symbols.
1721
1722 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1723
1724         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1725         static block of current object file first.  Also fix typo in
1726         header comment.
1727
1728 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1729
1730         * stack.c (set_last_displayed_sal): Delete.
1731         (last_displayed_sal_valid): Delete.
1732         (last_displayed_pspace): Delete.
1733         (last_displayed_addr): Delete.
1734         (last_displayed_symtab): Delete.
1735         (last_displayed_line): Delete.
1736         (class last_displayed_symtab_info_type): New.
1737         (last_displayed_symtab_info): New static global variable.
1738         (print_frame_info): Call methods on last_displayed_symtab_info.
1739         (clear_last_displayed_sal): Update header comment, and make use of
1740         last_displayed_symtab_info.
1741         (last_displayed_sal_is_valid): Likewise.
1742         (get_last_displayed_pspace): Likewise.
1743         (get_last_displayed_addr): Likewise.
1744         (get_last_displayed_symtab): Likewise.
1745         (get_last_displayed_line): Likewise.
1746         (get_last_displayed_sal): Likewise.
1747         * stack.h (clear_last_displayed_sal): Update header comment.
1748         (last_displayed_sal_is_valid): Likewise.
1749         (get_last_displayed_pspace): Likewise.
1750         (get_last_displayed_addr): Likewise.
1751         (get_last_displayed_symtab): Likewise.
1752         (get_last_displayed_line): Likewise.
1753         (get_last_displayed_sal): Likewise.
1754
1755 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1756
1757         * stack.c (frame_show_address): Convert return type to bool.
1758         * stack.h (frame_show_address): Likewise, and update header
1759         comment.
1760
1761 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1762
1763         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1764         * unittests/vec-utils-selftests.c: New file.
1765         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1766
1767 2019-11-10  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1770         (tui_highlight_win): Likewise.
1771         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1772         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1773         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1774         Don't set can_highlight.
1775
1776 2019-11-10  Tom Tromey  <tom@tromey.com>
1777
1778         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1779         Remove unused declaration.
1780
1781 2019-11-08  Tom Tromey  <tromey@adacore.com>
1782
1783         * top.c (read_command_file): Update.
1784         (command_line_input): Make return type const.
1785         * python/py-gdb-readline.c: Update.
1786         * linespec.c (decode_line_2): Update.
1787         * defs.h (command_line_input): Make return type const.
1788         * cli/cli-script.c (read_next_line): Make return type const.
1789         * ada-lang.c (get_selections): Update.
1790
1791 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1792
1793         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1794         * mi/mi-main.c (output_cores): Likewise.
1795         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1796         (linux_xfer_osdata_modules): Likewise.
1797         * remote.c (register_remote_support_xml): Likewise.
1798         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1799         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1800
1801 2019-11-06  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-interp.c: Don't include readline.h.
1804         * tui/tui-hooks.c: Don't include readline.h.
1805         * symmisc.c: Include tilde.h, not readline.h.
1806         * symfile.c: Include tilde.h, not readline.h.
1807         * source.c: Include tilde.h, not readline.h.
1808         * solib.c: Include tilde.h, not readline.h.
1809         * psymtab.c: Include tilde.h, not readline.h.
1810         * exec.c: Include tilde.h, not readline.h.
1811         * corelow.c: Include tilde.h, not readline.h.
1812         * cli/cli-dump.c: Include tilde.h, not readline.h.
1813         * cli/cli-cmds.c: Don't include readline.h.
1814
1815 2019-11-05  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1818         (tui_disassemble): Set addr_size.
1819         (tui_disasm_window::set_contents): Use addr_size.
1820
1821 2019-11-05  Tom Tromey  <tom@tromey.com>
1822
1823         * rust-lang.c (rust_language_defn): Update.
1824         * python/py-value.c (valpy_string): Call c_get_string.
1825         * p-lang.c (pascal_language_defn): Update.
1826         * opencl-lang.c (opencl_language_defn): Update.
1827         * objc-lang.c (objc_language_defn): Update.
1828         * m2-lang.c (m2_language_defn): Update.
1829         * language.c (unknown_language_defn, auto_language_defn): Update.
1830         (default_get_string): Remove.
1831         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1832         * go-lang.c (go_language_defn): Update.
1833         * f-lang.c (f_language_defn): Update.
1834         * d-lang.c (d_language_defn): Update.
1835         * c-lang.c (c_language_defn, cplus_language_defn)
1836         (asm_language_defn, minimal_language_defn): Update.
1837         * ada-lang.c (ada_language_defn): Update.
1838         * language.h (struct language_defn) <la_get_string>: Remove.
1839         (LA_GET_STRING): Remove.
1840         (default_get_string): Don't declare.
1841
1842 2019-11-05  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-source.h (struct tui_source_window): Inline
1845         constructor.  Remove destructor.
1846         <style_changed, m_observable>: Move to superclass.
1847         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1848         (struct tui_source_window_base): Move private members to end.
1849         <style_changed, m_observable>: Move from tui_source_window.
1850         * tui/tui-winsource.c (tui_copy_source_line): Move from
1851         tui-source.c.  Rename from copy_source_line.  Add special handling
1852         for negative line number.
1853         (tui_source_window_base::style_changed): Move from
1854         tui_source_window.
1855         (tui_source_window_base): Register observer.
1856         (~tui_source_window_base): New.
1857         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1858         rename.
1859         (tui_source_window::set_contents): Use tui_copy_source_line.
1860         (tui_source_window::tui_source_window): Move to tui-source.h.
1861         (tui_source_window::~tui_source_window): Remove.
1862         (tui_source_window::style_changed): Move to superclass.
1863         * tui/tui-disasm.c (tui_disassemble): Create string file with
1864         styling, when possible.  Add "addr_size" parameter.
1865         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1866         Don't compute maximum size.
1867         (len_without_escapes): New function
1868
1869 2019-11-05  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1872         std::string.
1873         * tui/tui-winsource.c (tui_show_source_line): Update.
1874         * tui/tui-source.c (tui_source_window::set_contents): Update.
1875         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1876
1877 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1878
1879         * symtab.h (gdb_static_assert): Put && operator at the beginning
1880         of the line instead of the end.
1881
1882 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1883
1884         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1885         and sizeof (symbol).
1886         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1887
1888 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1889
1890         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1891         * configure.host: Mark *-*-solaris2.10* obsolete.
1892         * configure.tgt: Mark Solaris < 11 obsolete.
1893         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1894         Update target triplet.
1895
1896 2019-11-01  Tom Tromey  <tromey@adacore.com>
1897
1898         * utils.c (print_sys_errmsg): Simplify.
1899
1900 2019-11-01  Tom Tromey  <tromey@adacore.com>
1901
1902         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1903
1904 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1905
1906         * configure: Regenerate.
1907         * configure.ac: Remove check for strerror_r.
1908         * gdbsupport/common.m4: Check for strerror_r.
1909
1910 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1911
1912         PR gdb/25124
1913
1914         * arm-tdep.c (arm_per_objfile): Rename to ...
1915         (arm_per_bfd): ... this.
1916         (arm_objfile_data_key): Rename to ...
1917         (arm_bfd_data_key): ... this.
1918         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1919         data.
1920         (arm_record_special_symbol): Likewise.
1921
1922 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1923
1924         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1925         end.
1926         * c-typeprint.c (c_print_typedef): Likewise.
1927         * f-typeprint.c (f_print_typedef): Likewise.
1928         * m2-typeprint.c (m2_print_typedef): Likewise.
1929         * p-typeprint.c (pascal_print_typedef): Likewise.
1930         * rust-lang.c (rust_print_typedef): Likewise.
1931         * symtab.c (print_symbol_info): Print a newline after calling
1932         typedef_print.
1933
1934 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1935
1936         * symtab.c (info_module_cmdlist): New variable.
1937         (info_module_command): New function.
1938         (search_module_symbols): New function.
1939         (info_module_subcommand): New function.
1940         (struct info_modules_var_func_options): New struct.
1941         (info_modules_var_func_options_defs): New variable.
1942         (make_info_modules_var_func_options_def_group): New function.
1943         (info_module_functions_command): New function.
1944         (info_module_variables_command): New function.
1945         (info_module_var_func_command_completer): New function.
1946         (_initialize_symtab): Register new 'info module functions' and
1947         'info module variables' commands.
1948         * symtab.h (typedef symbol_search_in_module): New typedef.
1949         (search_module_symbols): Declare new function.
1950         * NEWS: Mention new commands.
1951
1952 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1953
1954         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1955         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1956         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1957         MODULES_DOMAIN.
1958         (scan_partial_symbols): Only create partial module symbols for non
1959         declarations.
1960         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1961         and MODULES_DOMAIN.
1962         * symtab.c (search_domain_name): Likewise.
1963         (search_symbols): Likewise.
1964         (print_symbol_info): Likewise.
1965         (symtab_symbol_info): Likewise.
1966         (info_modules_command): New function.
1967         (_initialize_symtab): Register 'info modules' command.
1968         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1969         * NEWS: Mention new 'info modules' command.
1970
1971 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1972
1973         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1974         and $_gdb_maint_setting_str.
1975
1976 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1977
1978         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1979         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1980         (str_value_from_setting, gdb_setting_str_internal_fn)
1981         (gdb_maint_setting_str_internal_fn): New functions.
1982         (_initialize_cli_cmds): Define the new convenience functions.
1983         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1984         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1985
1986 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1987
1988         * agent.c (set_can_use_agent): When the setting is turned on,
1989         look up agent symbols if we don't have them yet.
1990         (agent_new_objfile): Don't look up agent symbols when the agent
1991         setting is off.
1992
1993 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1994
1995         * config.in: Regenerate.
1996
1997 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1998
1999         * configure: Regenerate.
2000         * configure.ac: Check for strerror_r.
2001         * gdbsupport/common-utils.h (safe_strerror): Change return value
2002         to const char * and document that this function is now threadsafe.
2003         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2004         thread_local and call strerror_r, if available.
2005         * utils.c (perror_string): Update.
2006         (print_sys_errmsg): Update.
2007
2008 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2009
2010         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2011         objfile_key.
2012         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2013         objfile to fetch per-bfd data.
2014         (arm_find_exidx_entry): Likewise.
2015
2016 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2017
2018         * gdbsupport/agent.c (debug_agent): Change type to bool.
2019         (use_agent): Likewise.
2020         (all_agent_symbols_look_up): Likewise.
2021         (agent_loaded_p): Change return value to bool.
2022         (agent_look_up_symbols): Update.
2023         (agent_capability_check): Change return value to bool.
2024         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2025         (debug_agent): Change type to bool.
2026         (use_agent): Likewise.
2027         (agent_capability_check): Change return value to bool.
2028
2029 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2030
2031         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2032         (build_minimal_symbol_hash_tables): Code to clear the table moved
2033         to clear_minimal_symbol_hash_tables.
2034         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2035         when needed.
2036
2037 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2038
2039         * infcmd.c: Remove includes.
2040         * infrun.c: Remove includes.
2041
2042 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2043
2044         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2045         (grow_vect): Remove declaration.
2046         (ada_type_of_array): Remove declaration.
2047         (ada_update_initial_language): Remove declaration.
2048         (ada_fold_name): Remove declaration.
2049         (ada_fill_in_ada_prototype): Remove declaration.
2050         (user_select_syms): Remove declaration.
2051         (get_selections): Remove declaration.
2052         (ada_tag_type): Remove declaration.
2053         (ada_value_tag): Remove declaration.
2054         (ada_is_others_clause): Remove declaration.
2055         (ada_in_variant): Remove declaration.
2056         (ada_value_struct_elt): Remove declaration.
2057         (ada_attribute_name): Remove declaration.
2058         (ada_system_address_type): Remove declaration.
2059         * ada-lang.c (ada_watch_location_expression): Make static.
2060         (GROW_VECT): Move here from ada-lang.h.
2061         (grow_vect): Make static.
2062         (ada_update_initial_language): Make static.
2063         (ada_fold_name): Make static.
2064         (ada_type_of_array): Make static.
2065         (encoded_ordered_before): Move up.
2066         (sort_choices): Move up.
2067         (print_signatures): Move up.
2068         (ada_print_symbol_signature): Move up.
2069         (get_selections): Move up and make static.
2070         (user_select_syms): Move up and make static.
2071         (ada_value_struct_elt): Move up and make static.
2072         (ada_tag_type): Make static.
2073         (ada_value_tag): Make static.
2074         (ada_is_others_clause): Make static.
2075         (ada_in_variant): Make static.
2076         (ada_attribute_name): Make static.
2077
2078 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2079
2080         * ada-lang.c: Remove includes.
2081         * ada-typeprint.c: Remove includes.
2082         * ada-valprint.c: Remove includes.
2083
2084 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2085
2086         * addrmap.c: Add static assertions of type size, moved from
2087         _initialize_addrmap.
2088         (_initialize_addrmap): Remove.
2089
2090 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2091
2092         * coffread.c (record_minimal_symbol): Update.
2093         (process_coff_symbol): Update.
2094         * dbxread.c (read_dbx_symtab): Update.
2095         * dwarf2read.c (add_partial_symbol): Update.
2096         (fixup_go_packaging): Update.
2097         (load_partial_dies): Update.
2098         (new_symbol): Update.
2099         * elfread.c (record_minimal_symbol): Change signature to use
2100         gdb::string_view instead of name+len.
2101         (elf_symtab_read): Update.
2102         (elf_rel_plt_read): Update.
2103         * mdebugread.c (parse_partial_symbols): Update.
2104         (handle_psymbol_enumerators): Update.
2105         (new_symbol): Update.
2106         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2107         to use gdb::string_view instead of name+len.
2108         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2109         * psympriv.h (add_psymbol_to_list): Likewise.
2110         * psymtab.c (add_psymbol_to_bcache): Likewise.
2111         (add_psymbol_to_list): Likewise.
2112         * stabsread.c (define_symbol): Update.
2113         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2114         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2115         (symbol_set_names): Likewise.
2116         * xcoffread.c (scan_xcoff_symtab): Update.
2117
2118 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2119
2120         * symtab.h (symbol_set_names): Document that copy_name must be
2121         set to true for non-nullterminated strings.
2122         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2123         linkage_name if the entry was not found and we need to demangle.
2124
2125 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2126
2127         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2128         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2129         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2130         * gdbsupport/gdb_binary_search.h: New file.
2131
2132 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2133
2134         * NEWS: Mention new --with-system-gdbinit-dir option.
2135         * config.in: Regenerate.
2136         * configure: Regenerate.
2137         * configure.ac: Add new option --with-system-gdbinit-dir.
2138         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2139         for a ".gdb" suffix.
2140         * main.c (get_init_files): Change system_gdbinit argument to
2141         a vector and return the files in SYSTEM_GDBINIT_DIR in
2142         addition to SYSTEM_GDBINIT.
2143         (captured_main_1): Update.
2144         (print_gdb_help): Update.
2145         * top.c (print_gdb_configuration): Also print the value of
2146         SYSTEM_GDBINIT_DIR.
2147
2148 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2149
2150         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2151         that takes gdb::string_view arguments.
2152
2153 2019-10-26  Tom de Vries  <tdevries@suse.de>
2154
2155         * aarch64-linux-tdep.c: Fix typos in comments.
2156         * aarch64-tdep.c: Same.
2157         * ada-lang.c: Same.
2158         * amd64-nat.c: Same.
2159         * arc-tdep.c: Same.
2160         * arch/aarch64-insn.c: Same.
2161         * block.c: Same.
2162         * breakpoint.h: Same.
2163         * btrace.h: Same.
2164         * c-varobj.c: Same.
2165         * cli/cli-decode.c: Same.
2166         * cli/cli-script.c: Same.
2167         * cli/cli-utils.h: Same.
2168         * coff-pe-read.c: Same.
2169         * coffread.c: Same.
2170         * compile/compile-cplus-symbols.c: Same.
2171         * compile/compile-object-run.c: Same.
2172         * completer.c: Same.
2173         * corelow.c: Same.
2174         * cp-support.c: Same.
2175         * demangle.c: Same.
2176         * dwarf-index-write.c: Same.
2177         * dwarf2-frame.c: Same.
2178         * dwarf2-frame.h: Same.
2179         * eval.c: Same.
2180         * frame-base.h: Same.
2181         * frame.h: Same.
2182         * gdbcmd.h: Same.
2183         * gdbtypes.h: Same.
2184         * gnu-nat.c: Same.
2185         * guile/scm-objfile.c: Same.
2186         * i386-tdep.c: Same.
2187         * i386-tdep.h: Same.
2188         * infcall.c: Same.
2189         * infcall.h: Same.
2190         * linux-nat.c: Same.
2191         * m68k-tdep.c: Same.
2192         * macroexp.c: Same.
2193         * memattr.c: Same.
2194         * mi/mi-cmd-disas.c: Same.
2195         * mi/mi-getopt.h: Same.
2196         * mi/mi-main.c: Same.
2197         * minsyms.c: Same.
2198         * nat/aarch64-sve-linux-sigcontext.h: Same.
2199         * objfiles.h: Same.
2200         * ppc-linux-nat.c: Same.
2201         * ppc-linux-tdep.c: Same.
2202         * ppc-tdep.h: Same.
2203         * progspace.h: Same.
2204         * prologue-value.h: Same.
2205         * python/py-evtregistry.c: Same.
2206         * python/py-instruction.h: Same.
2207         * record-btrace.c: Same.
2208         * record-full.c: Same.
2209         * remote.c: Same.
2210         * rs6000-tdep.c: Same.
2211         * ser-tcp.c: Same.
2212         * sol-thread.c: Same.
2213         * sparc-sol2-tdep.c: Same.
2214         * sparc64-tdep.c: Same.
2215         * stabsread.c: Same.
2216         * symfile.c: Same.
2217         * symtab.h: Same.
2218         * target.c: Same.
2219         * tracepoint.c: Same.
2220         * tui/tui-data.h: Same.
2221         * tui/tui-io.c: Same.
2222         * tui/tui-win.c: Same.
2223         * tui/tui.c: Same.
2224         * unittests/rsp-low-selftests.c: Same.
2225         * user-regs.h: Same.
2226         * utils.c: Same.
2227         * utils.h: Same.
2228         * valarith.c: Same.
2229         * valops.c: Same.
2230         * valprint.c: Same.
2231         * valprint.h: Same.
2232         * value.c: Same.
2233         * value.h: Same.
2234         * varobj.c: Same.
2235         * x86-nat.h: Same.
2236         * xtensa-tdep.c: Same.
2237
2238 2019-10-25  Ali Tamur <tamur@google.com>
2239
2240         * charset.c (find_charset_names): Reflect API change.
2241
2242 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2243
2244         * symtab.c (struct demangled_name_entry): Change demangled name
2245         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2246         part of the struct anymore.
2247         (symbol_set_names): No longer obstack allocate + copy the demangled
2248         name, just store the allocated name from bfd.
2249
2250 2019-10-25  Tom Tromey  <tromey@adacore.com>
2251
2252         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2253         (bsearch_cie_cmp, add_cie): Remove.
2254         (find_cie): Reimplement.
2255         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2256         (dwarf2_build_frame_info): Update.
2257
2258 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2259
2260         PR gdb/25126
2261         * symfile.c (reread_symbols): Call forget_cached_source_info to
2262         clear the stale source cache.
2263
2264 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2265
2266         * configure: Regenerate.
2267         * configure.ac: Remove code that sets python_has_threads.
2268
2269 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2270
2271         * config.in: Regenerate.
2272         * configure: Regenerate.
2273         * configure.ac: Remove the code that uses sed to get the python
2274         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2275
2276 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2277
2278         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2279         error paths.
2280
2281 2019-10-23  Tom Tromey  <tom@tromey.com>
2282
2283         * arc-tdep.c: Remove ".." from include.
2284         * frv-tdep.c: Remove ".." from include.
2285         * lm32-tdep.c: Remove ".." from include.
2286         * microblaze-tdep.c: Remove ".." from include.
2287         * or1k-tdep.h: Remove ".." from include.
2288         * s12z-tdep.c: Remove ".." from include.
2289         * Makefile.in (OPCODES_CFLAGS): Add comment.
2290         (TOP_CFLAGS): New variable.
2291         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2292
2293 2019-10-23  Tom Tromey  <tom@tromey.com>
2294
2295         * Makefile.in (READLINE_DIR): Update.
2296
2297 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2298
2299         * infcall.c (call_function_by_hand_dummy): Fix the function
2300         comment.  And extract out a code section into...
2301         (reserve_stack_space): ...this new function.
2302
2303 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2304
2305         * infcall.c (value_arg_coerce): Remove an unused parameter.
2306         (call_function_by_hand_dummy): Update the call to
2307         'value_arg_coerce'.
2308
2309 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2310
2311         * infcall.c (call_function_by_hand_dummy): Refactor.
2312
2313 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2314
2315         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2316
2317 2019-10-23  Tom Tromey  <tom@tromey.com>
2318
2319         * configure: Rebuild.
2320         * configure.ac: Don't check for sigprocmask.
2321         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2322
2323 2019-10-23  Tom Tromey  <tom@tromey.com>
2324
2325         * configure: Rebuild.
2326         * acinclude.m4: Use m4_include, not sinclude.
2327
2328 2019-10-23  Tom de Vries  <tdevries@suse.de>
2329
2330         PR breakpoints/24687
2331         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2332
2333 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2334
2335         * symtab.c (struct demangled_name_entry) <language>: Change from
2336         bitfield to regular variable.
2337
2338 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2339
2340         * symtab.c (struct demangled_name_entry): Add a constructor.
2341         (free_demangled_name_entry): New function to call the destructor
2342         for demangled_name_entry.
2343         (create_demangled_names_hash): Pass free_demangled_name_entry to
2344         htab_create_alloc.
2345         (symbol_set_names): Call placement new for demangled_name_entry.
2346         * utils.c: No longer include xxhash.h here, now that fast_hash
2347         is inlined in the header.
2348         * utils.h: Instead, include it here.
2349
2350 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2351
2352         * Makefile.in: Link with libxxhash.
2353         * config.in: Regenerate.
2354         * configure: Regenerate.
2355         * configure.ac: Search for libxxhash.
2356         * utils.c (fast_hash): Use xxhash if present.
2357
2358 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2359
2360         * utils.h (fast_hash): New function.
2361         * symtab.c (hash_demangled_name_entry): Call new function
2362         fast_hash.
2363
2364 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2365
2366         * symtab.c (struct demangled_name_entry): Change type of mangled
2367         to gdb::string_view. Also adds a constructor that takes the
2368         mangled name.
2369         (hash_demangled_name_entry): Update.
2370         (eq_demangled_name_entry): Update.
2371         (free_demangled_name_entry): New function to call the destructor
2372         now that this is not a POD anymore.
2373         (create_demangled_names_hash): Pass free_demangled_name_entry to
2374         htab_create_alloc.
2375         (symbol_set_names): Update.
2376
2377 2019-10-21  Ali Tamur  <tamu@google.com>
2378
2379         * dwarf2read.c (dir_index): Change type.
2380         (file_name_index): Likewise.
2381         (line_header::include_dir_at): Change comment and implementation on
2382         whether it is DWARF 5.
2383         (line_header::is_valid_file_index): New function.
2384         (line_header::file_name_at): Change comment and implementation on
2385         whether it is DWARF 5.
2386         (line_header::file_names): Change to private field renamed as
2387         m_file_names and introduce a new accessor method.
2388         (line_header::file_names_size): New method.
2389         (line_header::include_dirs): Change to private field and rename as
2390         m_include_dirs.
2391         (dw2_get_file_names_reader): Define local var at a smaller scope and
2392         reflect API change.
2393         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2394         (process_structure_scope): Likewise.
2395         (line_header::add_include_dir): Change message and reflect renaming.
2396         (line_header::add_file_name): Likewise.
2397         (read_formatted_entries): Handle DW_FORM_data16.
2398         (dwarf_decode_line_header): Fix line header length calculation.
2399         (psymtab_include_file_name): Change comment and API.
2400         (lnp_state_machine::m_file): Update comment and reflect type change.
2401         (lnp_state_machine::record_line): Reflect type change.
2402         (dwarf_decode_lines): Reflect API change.
2403         (file_file_name): Likewise.
2404         (file_full_name): Likewise.
2405
2406 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2407
2408         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2409
2410 2019-10-21  Tom Tromey  <tom@tromey.com>
2411
2412         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2413
2414 2019-10-21  Tom Tromey  <tom@tromey.com>
2415
2416         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2417         NM_H.   Use AC_CONFIG_LINKS.
2418         * configure: Rebuild.
2419         * Makefile.in (NM_H): New variable.
2420         (generated_files): Add NM_H.  Remove gcore.
2421         (nm.h, stamp-nmh): New targets.
2422
2423 2019-10-20  Tom Tromey  <tom@tromey.com>
2424
2425         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2426         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2427         obsolete comment.
2428         (put_objfile_before): Now static.
2429
2430 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2431
2432         * gdbsupport/common-utils.h (startswith): Change return type to
2433         bool.
2434
2435 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2436
2437         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2438         * breakpoint.c (bp_locations_compare): Rename to...
2439         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2440         (update_global_location_list): Use std::sort instead of qsort.
2441         * buildsym.c (compare_line_numbers): Rename to...
2442         (lte_is_less_than): ...this, and change to std::sort semantics.
2443         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2444         instead of qsort.
2445         * disasm.c (compare_lines): Rename to...
2446         (line_is_less_than): ...this, and change to std::sort semantics.
2447         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2448         of qsort.
2449         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2450         (fde_is_less_than): ...this, and change to std::sort semantics.
2451         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2452         * mdebugread.c (compare_blocks):
2453         (block_is_less_than): ...this, and change to std::sort semantics.
2454         (sort_blocks): Call std::sort instead of qsort.
2455         * objfiles.c (qsort_cmp): Rename to...
2456         (sort_cmp): ...this, and change to std::sort semantics.
2457         (update_section_map): Call std::sort instead of qsort.
2458         * remote.c (compare_pnums): Remove.
2459         (map_regcache_remote_table): Call std::sort instead of qsort.
2460         * utils.c (compare_positive_ints): Remove.
2461         * utils.h (compare_positive_ints): Remove.
2462         * xcoffread.c (compare_lte): Remove.
2463         (arrange_linetable): Call std::sort instead of qsort.
2464
2465 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2466
2467         * symfile.c (init_entry_point_info): Fix typo.
2468         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2469
2470 2019-10-18  Tom de Vries  <tdevries@suse.de>
2471
2472         * aarch64-tdep.c: Fix typos in comments.
2473         * ada-lang.c: Same.
2474         * ada-tasks.c: Same.
2475         * alpha-tdep.c: Same.
2476         * alpha-tdep.h: Same.
2477         * amd64-nat.c: Same.
2478         * amd64-windows-tdep.c: Same.
2479         * arc-tdep.c: Same.
2480         * arc-tdep.h: Same.
2481         * arch-utils.c: Same.
2482         * arm-nbsd-tdep.c: Same.
2483         * arm-tdep.c: Same.
2484         * ax-gdb.c: Same.
2485         * blockframe.c: Same.
2486         * btrace.c: Same.
2487         * c-varobj.c: Same.
2488         * coff-pe-read.c: Same.
2489         * coffread.c: Same.
2490         * cris-tdep.c: Same.
2491         * darwin-nat.c: Same.
2492         * dbxread.c: Same.
2493         * dcache.c: Same.
2494         * disasm.c: Same.
2495         * dtrace-probe.c: Same.
2496         * dwarf-index-write.c: Same.
2497         * dwarf2-frame-tailcall.c: Same.
2498         * dwarf2-frame.c: Same.
2499         * dwarf2read.c: Same.
2500         * eval.c: Same.
2501         * exceptions.c: Same.
2502         * fbsd-tdep.c: Same.
2503         * findvar.c: Same.
2504         * frame.c: Same.
2505         * frv-tdep.c: Same.
2506         * gnu-v3-abi.c: Same.
2507         * go32-nat.c: Same.
2508         * h8300-tdep.c: Same.
2509         * hppa-tdep.c: Same.
2510         * i386-linux-tdep.c: Same.
2511         * i386-tdep.c: Same.
2512         * ia64-libunwind-tdep.c: Same.
2513         * ia64-tdep.c: Same.
2514         * infcmd.c: Same.
2515         * infrun.c: Same.
2516         * linespec.c: Same.
2517         * linux-nat.c: Same.
2518         * linux-thread-db.c: Same.
2519         * machoread.c: Same.
2520         * mdebugread.c: Same.
2521         * mep-tdep.c: Same.
2522         * mn10300-tdep.c: Same.
2523         * namespace.c: Same.
2524         * objfiles.c: Same.
2525         * opencl-lang.c: Same.
2526         * or1k-tdep.c: Same.
2527         * osabi.c: Same.
2528         * ppc-linux-nat.c: Same.
2529         * ppc-linux-tdep.c: Same.
2530         * ppc-sysv-tdep.c: Same.
2531         * printcmd.c: Same.
2532         * procfs.c: Same.
2533         * record-btrace.c: Same.
2534         * record-full.c: Same.
2535         * remote-fileio.c: Same.
2536         * remote.c: Same.
2537         * rs6000-tdep.c: Same.
2538         * s12z-tdep.c: Same.
2539         * score-tdep.c: Same.
2540         * ser-base.c: Same.
2541         * ser-go32.c: Same.
2542         * skip.c: Same.
2543         * sol-thread.c: Same.
2544         * solib-svr4.c: Same.
2545         * solib.c: Same.
2546         * source.c: Same.
2547         * sparc-nat.c: Same.
2548         * sparc-sol2-tdep.c: Same.
2549         * sparc-tdep.c: Same.
2550         * sparc64-tdep.c: Same.
2551         * stabsread.c: Same.
2552         * stack.c: Same.
2553         * symfile.c: Same.
2554         * symtab.c: Same.
2555         * target-descriptions.c: Same.
2556         * target-float.c: Same.
2557         * thread.c: Same.
2558         * utils.c: Same.
2559         * valops.c: Same.
2560         * valprint.c: Same.
2561         * value.c: Same.
2562         * varobj.c: Same.
2563         * windows-nat.c: Same.
2564         * xcoffread.c: Same.
2565         * xstormy16-tdep.c: Same.
2566         * xtensa-tdep.c: Same.
2567
2568 2019-10-17  Tom Tromey  <tromey@adacore.com>
2569
2570         * configure: Rebuild.
2571         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2572         in AC_CONFIG_FILES invocation.
2573         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2574         new-style config.status invocation.
2575
2576 2019-10-17  Tom de Vries  <tdevries@suse.de>
2577
2578         * arm-nbsd-nat.c: Fix typos in comments.
2579         * arm-tdep.c: Same.
2580         * darwin-nat-info.c: Same.
2581         * dwarf2read.c: Same.
2582         * elfread.c: Same.
2583         * event-top.c: Same.
2584         * findvar.c: Same.
2585         * gdbtypes.c: Same.
2586         * hppa-tdep.c: Same.
2587         * i386-tdep.c: Same.
2588         * jit.c: Same.
2589         * main.c: Same.
2590         * mdebugread.c: Same.
2591         * moxie-tdep.c: Same.
2592         * nto-procfs.c: Same.
2593         * osabi.c: Same.
2594         * ppc-linux-tdep.c: Same.
2595         * remote.c: Same.
2596         * riscv-tdep.c: Same.
2597         * s390-tdep.c: Same.
2598         * sh-tdep.c: Same.
2599         * sparc-linux-tdep.c: Same.
2600         * sparc-nat.c: Same.
2601         * stack.c: Same.
2602         * target-descriptions.c: Same.
2603         * top.c: Same.
2604         * varobj.c: Same.
2605
2606 2019-10-16  Tom Tromey  <tom@tromey.com>
2607
2608         * objfiles.h (struct objfile) <original_name>: Now const.
2609
2610 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2611
2612         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2613         pass on to sigsetjmp's second argument.
2614         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2615
2616 2019-10-16  Keith Seitz  <keiths@redhat.com>
2617
2618         PR gdb/23567
2619         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2620         sections whose size is greater than the file size.
2621
2622 2019-10-16  Jim Wilson  <jimw@sifive.com>
2623
2624         * riscv-tdep.c (riscv_gcc_target_options): New.
2625         (riscv_gnu_triplet_regexp): New.
2626         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2627         set_gdbarch_gnu_triplet_regexp.
2628
2629 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2630
2631         * Makefile.in: Add xml-builtin.h.
2632         * features/feature_to_c.sh: Add an include for xml-builtin.h
2633         to ensure that the compiler checks that the types match.
2634         * xml-builtin.h: New file.
2635         * xml-support.c (fetch_xml_builtin): Add missing const.
2636         * xml-support.h: Remove declaration of xml_builtins.
2637
2638 2019-10-16  Tom de Vries  <tdevries@suse.de>
2639
2640         PR tdep/25096
2641         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2642         (amd64_classify_aggregate): ... here.
2643         (amd64_classify_aggregate_field): Handled fiels of nested structs
2644         recursively.
2645
2646 2019-10-16  Tom de Vries  <tdevries@suse.de>
2647
2648         PR tdep/24104
2649         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2650         that handles 'theclass'.
2651
2652 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2653
2654         * linespec.c (decode_digits_ordinary): Update comment.
2655         * make-target-delegates: No longer need to handle VEC case.
2656         * memrange.c (normalize_mem_ranges): Update comment.
2657         * namespace.c (add_using_directive): Update comment.
2658         * objc-lang.c (uniquify_strings): Update comment.
2659         * ppc-linux-nat.c (struct thread_points): Update comment.
2660         * probe.h (find_probes_in_objfile): Update comment.
2661         * target.h (enum flash_preserve_mode): Update comment.
2662         * varobj.c (varobj_restrict_range): Update comment.
2663         * varobj.h (varobj_list_children): Update comment.
2664
2665 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2666
2667         * Makefile.in: Remove references to vec.h and vec.c.
2668         * aarch64-tdep.c: No longer include vec.h.
2669         * ada-lang.c: Likewise.
2670         * ada-lang.h: Likewise.
2671         * arm-tdep.c: Likewise.
2672         * ax.h: Likewise.
2673         * breakpoint.h: Likewise.
2674         * charset.c: Likewise.
2675         * cp-support.h: Likewise.
2676         * dtrace-probe.c: Likewise.
2677         * dwarf2read.c: Likewise.
2678         * extension.h: Likewise.
2679         * gdb_bfd.c: Likewise.
2680         * gdbsupport/gdb_vecs.h: Likewise.
2681         * gdbsupport/vec.c: Remove.
2682         * gdbsupport/vec.h: Remove.
2683         * gdbthread.h: Likewise.
2684         * guile/scm-type.c: Likewise.
2685         * inline-frame.c: Likewise.
2686         * machoread.c: Likewise.
2687         * memattr.c: Likewise.
2688         * memrange.h: Likewise.
2689         * namespace.h: Likewise.
2690         * nat/linux-btrace.h: Likewise.
2691         * osdata.c: Likewise.
2692         * parser-defs.h: Likewise.
2693         * progspace.h: Likewise.
2694         * python/py-type.c: Likewise.
2695         * record-btrace.c: Likewise.
2696         * rust-exp.y: Likewise.
2697         * solib-target.c: Likewise.
2698         * stap-probe.c: Likewise.
2699         * target-descriptions.c: Likewise.
2700         * target-memory.c: Likewise.
2701         * target.h: Likewise.
2702         * varobj.c: Likewise.
2703         * varobj.h: Likewise.
2704         * xml-support.h: Likewise.
2705
2706 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2707
2708         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2709         Update for new std::vector based implementation.
2710         (process_psymtab_comp_unit_reader): Likewise.
2711         (scan_partial_symbols): Likewise.
2712         (recursively_compute_inclusions): Likewise.
2713         (compute_compunit_symtab_includes): Likewise.
2714         (process_imported_unit_die): Likewise.
2715         (queue_and_load_dwo_tu): Likewise.
2716         (follow_die_sig_1): Likewise.
2717         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2718         (typedef dwarf2_per_cu_ptr): Remove.
2719         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2720         function.
2721         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2722         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2723         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2724         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2725         std::vector.
2726
2727 2019-10-15  Tom Tromey  <tromey@adacore.com>
2728
2729         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2730         TID.
2731
2732 2019-10-15  Tom Tromey  <tromey@adacore.com>
2733
2734         * windows-nat.c (windows_nat_target::fetch_registers)
2735         (windows_nat_target::store_registers): Rename "pid" to "tid".
2736
2737 2019-10-15  Tom Tromey  <tromey@adacore.com>
2738
2739         * gdbarch.h, gdbarch.c: Rebuild.
2740         * gdbarch.sh (gcc_target_options): Change return type to
2741         std::string.
2742         * compile/compile.c (get_args): Update.
2743         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2744         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2745         std::string.
2746         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2747         std::string.
2748         * arch-utils.c (default_gcc_target_options): Return std::string.
2749         * arch-utils.h (default_gcc_target_options): Return std::string.
2750         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2751
2752 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2753
2754         * breakpoint.c (breakpoint_chain): Make static.
2755         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2756         of accessing breakpoint_chain.
2757
2758 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2759
2760         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2761         to a gdb::function_view and return value to bool.
2762         * breakpoint.h (iterate_over_breakpoints): Likewise.
2763         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2764         (pop_dummy_frame): Update.
2765         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2766         (gdbscm_breakpoints): Update.
2767         * python/py-breakpoint.c (build_bp_list): Update.
2768         (gdbpy_breakpoints): Update.
2769         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2770         Update.
2771         (bpfinishpy_handle_stop): Update.
2772         (bpfinishpy_handle_exit): Update.
2773         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2774         (svr4_update_solib_event_breakpoints): Update.
2775
2776 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2777
2778         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2779         when unwrapping single-field structs.
2780
2781 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2782
2783         * dwarf2read.c: Remove includes.
2784
2785 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2786
2787         * ui-out.c (ui_out::call_do_message): Silence
2788         -Wformat-nonliteral warning.
2789
2790 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2791
2792         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2793         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2794         include: readline/tilde.h.
2795
2796 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2797
2798         * remote.c (remote_target::get_trace_status): Remove declaration of
2799         trace_regblock_size.
2800
2801 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2802
2803         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2804         (show_user): Remove declaration of cmdlist.
2805         * cli/cli-cmds.h (max_user_call_depth): Declare.
2806         * cli/cli-script.c (execute_user_command): Remove declaration
2807         of max_user_call_depth.
2808
2809 2019-10-11  Jim Wilson  <jimw@sifive.com>
2810
2811         * gdbsupport/print-utils.h (pulongest): Fix comment.
2812         (plongest): Likewise.
2813         (phex): Add missing comment, mention leading zeros.
2814         (phex_nz): Add mention of no leading zeros to comment.
2815
2816         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2817         plongest instead of unsigned long long cast.
2818
2819 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2820
2821         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2822         for external_editor_command and gdbtk_test.
2823
2824 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2825
2826         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2827         * varobj.c (varobjdebug): Move comment to...
2828         * varobj.h (varobjdebug): ...here, and declare.
2829
2830 2019-10-09  Tom Tromey  <tom@tromey.com>
2831
2832         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2833         erase_data_content.
2834
2835 2019-10-09  Tom Tromey  <tom@tromey.com>
2836
2837         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2838         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2839         * tui/tui-command.c (tui_cmd_window::resize)
2840         (tui_refresh_cmd_win): Update.
2841         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2842         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2843         * tui/tui-data.c (~tui_gen_win_info): Remove.
2844         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2845         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2846         (tui_redisplay_readline, tui_mld_flush)
2847         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2848         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2849         (tui_data_window::erase_data_content)
2850         (tui_data_item_window::rerender)
2851         (tui_data_item_window::refresh_window): Update.
2852         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2853         (box_win, tui_gen_win_info::make_window)
2854         (tui_gen_win_info::make_visible): Update.
2855         (tui_delete_win): Remove.
2856         * tui/tui-winsource.c
2857         (tui_source_window_base::do_erase_source_content): Update.
2858         (tui_show_source_line, tui_source_window_base::update_tab_width)
2859         (tui_source_window_base::update_exec_info): Update.
2860         * tui/tui-data.h (struct curses_deleter): New.
2861         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2862         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2863
2864 2019-10-09  Tom Tromey  <tom@tromey.com>
2865
2866         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2867
2868 2019-10-09  Tom Tromey  <tom@tromey.com>
2869
2870         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2871         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2872
2873 2019-10-09  Tom Tromey  <tom@tromey.com>
2874
2875         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2876         window height directly.
2877         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2878         declare.
2879         * tui/tui-layout.c (tui_default_win_height): Remove.
2880         (tui_default_win_viewport_height): Remove.
2881
2882 2019-10-09  Tom Tromey  <tom@tromey.com>
2883
2884         * tui/tui.h: Remove comments.
2885
2886 2019-10-09  Tom de Vries  <tdevries@suse.de>
2887
2888         * python/lib/gdb/printer/bound_registers.py: Use
2889         '^builtin_type_bound128' as regexp argument for
2890         add_builtin_pretty_printer.
2891
2892 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2893
2894         * guile/guile.c (guile_extension_script_ops): Remove forward
2895         declaration and mark as static.
2896         (guile_script_ops): Likewise.
2897         (extension_language_guile): Move further down in the file so
2898         it can reference the definitions for guile_{extension_,}script_ops.
2899
2900 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2901
2902         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2903         except SORTL, DFLTCC, and KDSA.
2904
2905 2019-10-08  Tom Tromey  <tromey@adacore.com>
2906
2907         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2908         (struct safe_symbol_file_add_args): Remove.
2909
2910 2019-10-08  Tom Tromey  <tromey@adacore.com>
2911
2912         * windows-nat.c: Don't include buildsym-legacy.h.
2913
2914 2019-10-08  Tom Tromey  <tromey@adacore.com>
2915
2916         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2917
2918 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2919
2920         * gdbtypes.c (overload_debug): Move comment to header.
2921         * gdbtypes.h (overload_debug): Declare.
2922         * valops.c: Remove declaration of overload_debug, instead
2923         include gdbtypes.h.
2924
2925 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2926
2927         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2928         through _().
2929         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2930         move comment...
2931         * language.h (lang_frame_mismatch_warn): ... here. Also add
2932         declaration.
2933         * top.c (lang_frame_mismatch_warn): Remove declaration.
2934         (check_frame_language_change): Pass lang_frame_mismatch_warn
2935         through _().
2936
2937 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2938
2939         * c-lang.h (vtbl_ptr_name): Declare.
2940         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2941         it from the header.
2942         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2943
2944 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2945
2946         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2947         gdb_static_assert.
2948
2949 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2950
2951         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2952         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2953         * ctfread.c: New file.
2954         * ctfread.h: New file.
2955         * elfread.c: Include ctfread.h.
2956         (struct elfinfo text_p): New member ctfsect.
2957         (elf_locate_sections): Mark CTF section.
2958         (elf_symfile_read): Call elfctf_build_psymtabs.
2959         * Makefile.in (LIBCTF): Add.
2960         (CLIBS): Use it.
2961         (CDEPS): Likewise.
2962         (DIST): Add ctfread.c.
2963
2964 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2965
2966         * ctfread.c (struct nextfield): Renamed to ...
2967         (struct ctf_nextfield): ... this.
2968         (struct field_info): Renamed to ...
2969         (strut ctf_field_info): ... this.
2970         (attach_fields_to_type): Update for renamed structures.
2971         (ctf_add_member_cb): Likewise.
2972         (ctf_add_enum_member_cb): Likewise.
2973         (process_struct_members): Likewise.
2974         (process_enum_type): Likewise.
2975
2976 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2977
2978         * tracectf.h: Rename, was ctf.h.
2979         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2980         * tracefile.c: Likewise.
2981         * tracepoint.c: Remove unused include ctf.h.
2982         * mi/mi-main.c: Likewise.
2983         * Makefile.in Replace ctf.c with tracectf.c.
2984
2985 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2986
2987         * version.in: Change version number to "9.0.50.DATE-git".
2988
2989 2019-10-03  Tom Tromey  <tom@tromey.com>
2990
2991         PR rust/24976:
2992         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2993
2994 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2995
2996         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2997         cp_search_name_hash.
2998         * NEWS: Add entry about nested function support.
2999
3000 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3001             Andrew Burgess  <andrew.burgess@embecosm.com>
3002
3003         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3004         for nested static variables when searchin VAR_DOMAIN.
3005         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3006         global scope, update comment.
3007         (add_partial_subprogram): Call add_partial_subprogram recursively
3008         for nested subroutines when processinng Fortran.
3009         (load_partial_dies): Process the child entities of a subprogram
3010         when processing Fortran.
3011         (partial_die_parent_scope): Handle building scope
3012         for Fortran nested functions.
3013         (process_die): Record that nested functions have a scope.
3014         (new_symbol): Always record Fortran subprograms on the global
3015         symbol list.
3016         (determine_prefix): How to build the prefix for Fortran
3017         subprograms.
3018
3019 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3020
3021         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3022         have just sent the thread a SIGSTOP and are waiting for it to
3023         arrive.
3024
3025 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3026
3027         * btrace.c (btrace_add_pc): Remove whitespace before the template
3028         parameter in 'std::vector <...>'.
3029         (parse_xml_btrace_block): Likewise.
3030         (btrace_maint_decode_pt): Likewise.
3031         (btrace_maint_update_packets): Likewise.
3032         (btrace_maint_print_packets): Likewise.
3033         * btrace.h (struct btrace_maint_info): Likewise.
3034         * dwarf2read.c (struct type_unit_group): Likewise.
3035         (build_type_psymtabs_reader): Likewise.
3036         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3037         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3038         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3039
3040 2019-10-03  Tom de Vries  <tdevries@suse.de>
3041
3042         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3043         the first line of the help text for set/show style metadata.
3044
3045 2019-10-02  Tom Tromey  <tromey@adacore.com>
3046
3047         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3048         * gdbsupport/common-inferior.c: New file.
3049         * infcmd.c (startup_with_shell): Don't define.
3050         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3051         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3052         * inferior.h (startup_with_shell): Don't declare.
3053
3054 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3055
3056         * gdbsupport/gdb_assert.h: Include errors.h.
3057         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3058
3059 2019-10-02  Tom Tromey  <tromey@adacore.com>
3060
3061         * NEWS: Add $_ada_exception entry.
3062         * ada-lang.c (struct ada_catchpoint): Add constructor.
3063         <m_kind>: New member.
3064         (allocate_location_exception, re_set_exception): Remove
3065         "ex" parameter.
3066         (should_stop_exception): Compute $_ada_exception.
3067         (check_status_exception, print_it_exception)
3068         (print_one_exception, print_mention_exception): Remove
3069         "ex" parameter.
3070         (allocate_location_catch_exception, re_set_catch_exception)
3071         (check_status_exception, print_it_catch_exception)
3072         (print_one_catch_exception, print_mention_catch_exception)
3073         (print_recreate_catch_exception)
3074         (allocate_location_catch_exception_unhandled)
3075         (re_set_catch_exception_unhandled)
3076         (check_status_exception, print_it_catch_exception_unhandled)
3077         (print_one_catch_exception_unhandled)
3078         (print_mention_catch_exception_unhandled)
3079         (print_recreate_catch_exception_unhandled)
3080         (allocate_location_catch_assert, re_set_catch_assert)
3081         (check_status_assert, print_it_catch_assert)
3082         (print_one_catch_assert, print_mention_catch_assert)
3083         (print_recreate_catch_assert)
3084         (allocate_location_catch_handlers, re_set_catch_handlers)
3085         (check_status_handlers, print_it_catch_handlers)
3086         (print_one_catch_handlers, print_mention_catch_handlers)
3087         (print_recreate_catch_handlers): Remove.
3088         (create_ada_exception_catchpoint): Update.
3089         (initialize_ada_catchpoint_ops): Update.
3090
3091 2019-10-02  Tom Tromey  <tromey@adacore.com>
3092
3093         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3094         (create_excep_cond_exprs): Simplify exception string computation.
3095         (ada_exception_catchpoint_cond_string): Likewise.
3096
3097 2019-10-02  Tom Tromey  <tromey@adacore.com>
3098
3099         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3100         * ada-lang.c (lesseq_defined_than): Handle
3101         LOC_STATIC.
3102         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3103         parameter.
3104         (dwarf2_has_info): Likewise.
3105         (new_symbol): Set maybe_copied on symbol when
3106         appropriate.
3107         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3108         parameter.
3109         <can_copy>: New member.
3110         * elfread.c (record_minimal_symbol): Set maybe_copied
3111         on symbol when appropriate.
3112         (elf_symfile_read): Update call to dwarf2_has_info.
3113         * minsyms.c (lookup_minimal_symbol_linkage): New
3114         function.
3115         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3116         * symtab.c (get_symbol_address, get_msymbol_address):
3117         New functions.
3118         * symtab.h (get_symbol_address, get_msymbol_address):
3119         Declare.
3120         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3121         maybe_copied.
3122         (struct symbol, struct minimal_symbol) <maybe_copied>:
3123         New member.
3124
3125 2019-10-02  Tom Tromey  <tromey@adacore.com>
3126
3127         * source.c (struct current_source_location): New.
3128         (current_source_key): New global.
3129         (current_source_symtab, current_source_line)
3130         (current_source_pspace): Remove.
3131         (get_source_location): New function.
3132         (get_current_source_symtab_and_line)
3133         (set_default_source_symtab_and_line)
3134         (set_current_source_symtab_and_line)
3135         (clear_current_source_symtab_and_line, select_source_symtab)
3136         (info_source_command, print_source_lines_base)
3137         (info_line_command, search_command_helper, _initialize_source):
3138         Update.
3139
3140 2019-10-02  Tom Tromey  <tromey@adacore.com>
3141
3142         * source.c (select_source_symtab): Don't call
3143         decode_line_with_current_source.
3144
3145 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3146
3147         * symtab.c (lookup_global_symbol): Search global block.
3148
3149 2019-10-02  Tom Tromey  <tromey@adacore.com>
3150
3151         * coffread.c (process_coff_symbol): Update.
3152         * dwarf2read.c (var_decode_location, new_symbol): Update.
3153         * mdebugread.c (parse_symbol): Update.
3154         * objfiles.c (relocate_one_symbol): Update.
3155         * stabsread.c (define_symbol, fix_common_block)
3156         (scan_file_globals): Update.
3157         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3158         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3159         * xcoffread.c (process_xcoff_symbol): Update.
3160
3161 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3162
3163         * MAINTAINERS: Update my email address.
3164
3165 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3166
3167         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3168         std::vector.
3169         (build_type_psymtabs_reader): Update for std::vector.
3170         (build_type_psymtab_dependencies): Likewise.
3171         * dwarf2read.h: Remove use of DEF_VEC_P.
3172         (typedef sig_type_ptr): Delete.
3173
3174 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3175
3176         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3177         to std::vector.
3178         (btrace_maint_decode_pt): Likewise, and move allocation of the
3179         vector outside of the loop.
3180         (btrace_maint_update_packets): Update to handle change from VEC to
3181         std::vector.
3182         (btrace_maint_print_packets): Likewise.
3183         (maint_info_btrace_cmd): Likewise.
3184         * btrace.h: Remove use of DEF_VEC_O.
3185         (typedef btrace_pt_packet_s): Delete.
3186         (struct btrace_maint_info) <packets>: Change fromm VEC to
3187         std::vector.
3188         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3189
3190 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3191
3192         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3193         make accesses into the vector constant references.
3194         (btrace_add_pc): Update for std::vector.
3195         (btrace_stitch_bts): Likewise.
3196         (parse_xml_btrace_block): Likewise.
3197         (btrace_maint_update_packets): Likewise.
3198         (btrace_maint_print_packets): Likewise.
3199         (maint_info_btrace_cmd): Likewise.
3200         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3201         std::vector.
3202         (btrace_data::empty): Likewise.
3203         (btrace_data_append): Likewise.
3204         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3205         (typedef btrace_block_s): Delete.
3206         (struct btrace_block): Add constructor.
3207         (struct btrace_data_bts) <blocks>: Change to std::vector.
3208         * nat/linux-btrace.c (perf_event_read_bts): Update for
3209         std::vector.
3210         (linux_read_bts): Likewise.
3211
3212 2019-10-01  Tom Tromey  <tom@tromey.com>
3213
3214         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3215
3216 2019-10-01  Tom Tromey  <tom@tromey.com>
3217
3218         * stack.c (print_frame, info_frame_command_core): Use
3219         styled_string.
3220         * linux-thread-db.c (try_thread_db_load_1)
3221         (try_thread_db_load_from_pdir_1): Use styled_string.
3222         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3223         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3224         (maybe_print_unsupported_script_warning)
3225         (maybe_print_script_not_found_warning): Use styled_string.
3226         * ada-lang.c (user_select_syms): Use styled_string.
3227
3228 2019-10-01  Tom Tromey  <tom@tromey.com>
3229
3230         * p-lang.c (pascal_printstr): Use metadata style.
3231         * value.c (show_convenience): Use metadata style.
3232         * valprint.c (valprint_check_validity, val_print_optimized_out)
3233         (val_print_not_saved, val_print_unavailable)
3234         (val_print_invalid_address, generic_val_print, val_print)
3235         (value_check_printable, val_print_array_elements): Use metadata
3236         style.
3237         * ui-out.h (class ui_out) <field_fmt>: New overload.
3238         <do_field_fmt>: Add style parameter.
3239         * ui-out.c (ui_out::field_fmt): New overload.
3240         * typeprint.c (type_print_unknown_return_type)
3241         (val_print_not_allocated, val_print_not_associated): Use metadata
3242         style.
3243         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3244         parameter.
3245         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3246         * tracepoint.c (tvariables_info_1): Use metadata style.
3247         * stack.c (print_frame_arg, print_frame_info, print_frame)
3248         (info_frame_command_core): Use metadata style.
3249         * skip.c (info_skip_command): Use metadata style.
3250         * rust-lang.c (rust_print_enum): Use metadata style.
3251         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3252         metadata style.
3253         * python/py-framefilter.c (py_print_single_arg): Use metadata
3254         style.
3255         * printcmd.c (do_one_display, print_variable_and_value): Use
3256         metadata style.
3257         * p-valprint.c (pascal_val_print)
3258         (pascal_object_print_value_fields): Use metadata style.
3259         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3260         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3261         parameter.
3262         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3263         * m2-valprint.c (m2_print_long_set): Use metadata style.
3264         * m2-typeprint.c (m2_print_type): Use metadata style.
3265         * infcmd.c (print_return_value_1): Use metadata style.
3266         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3267         * f-valprint.c (info_common_command_for_block): Use metadata
3268         style.
3269         * f-typeprint.c (f_type_print_base): Use metadata style.
3270         * expprint.c (print_subexp_standard): Use metadata style.
3271         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3272         * cli/cli-style.h (class cli_style_option): Add constructor.
3273         (metadata_style): Declare.
3274         * cli/cli-style.c (metadata_style): New global.
3275         (_initialize_cli_style): Register metadata style.
3276         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3277         parameter.
3278         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3279         * c-typeprint.c (c_type_print_base_struct_union)
3280         (c_type_print_base_1): Use metadata style.
3281         * breakpoint.c (watchpoint_value_print)
3282         (print_one_breakpoint_location): Use metadata style.
3283         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3284         style.
3285         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3286         style.
3287         * ada-valprint.c (val_print_packed_array_elements, printstr)
3288         (print_field_values, ada_val_print_ref, ada_val_print): Use
3289         metadata style.
3290         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3291         style.
3292         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3293         style.
3294         * ada-lang.c (user_select_syms): Use metadata style.
3295
3296 2019-10-01  Tom Tromey  <tom@tromey.com>
3297
3298         * cli/cli-cmds.c (pwd_command): Style output.
3299
3300 2019-10-01  Pedro Alves  <palves@redhat.com>
3301             Tom Tromey  <tom@tromey.com>
3302
3303         * symtab.c (print_symbol_info): Use %ps.
3304         (print_msymbol_info): Use %ps.
3305         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3306         * printcmd.c (print_variable_and_value): Use %ps.
3307         * macrocmd.c (show_pp_source_pos): Use %ps.
3308         * infrun.c (print_exited_reason): Use ui_out::message.
3309         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3310         (describe_other_breakpoints): Use ui_out::message and new
3311         formats.
3312         (say_where): Use new formats.
3313         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3314         and new formats.
3315
3316 2019-10-01  Pedro Alves  <palves@redhat.com>
3317             Tom Tromey  <tom@tromey.com>
3318
3319         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3320         (test_gdb_formats): New function.
3321         (run_tests): Call it.
3322         (test_format_specifier): Update.
3323         * utils.h (fputs_filtered): Update comment.
3324         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3325         (fputs_styled_unfiltered): Declare.
3326         * utils.c (fputs_styled_unfiltered): New function.
3327         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3328         (vfprintf_filtered): Update.
3329         (vfprintf_unfiltered, vprintf_filtered): Update.
3330         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3331         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3332         disallow_ui_out_field>: New constants.
3333         (enum class field_kind): New.
3334         (struct base_field_s, struct signed_field_s): New.
3335         (signed_field): New function.
3336         (struct string_field_s): New.
3337         (string_field): New function.
3338         (struct styled_string_s): New.
3339         (styled_string): New function.
3340         (class ui_out) <message>: Add comment.
3341         <vmessage, call_do_message>: New methods.
3342         <do_message>: Add style parameter.
3343         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3344         methods.
3345         (ui_out::message): Rewrite.
3346         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3347         parameter.
3348         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3349         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3350         gdb_extensions parameter.
3351         (class format_piece): Add parameter to constructor.
3352         (n_int_args): New field.
3353         * gdbsupport/format.c (format_pieces::format_pieces): Add
3354         gdb_extensions parameter.  Handle '*'.
3355         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3356         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3357         vfprintf_styled_no_gdbfmt.
3358         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3359         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3360         unfiltered output.
3361         * ui-style.h (struct ui_file_style) <ptr>: New method.
3362
3363 2019-10-01  Tom Tromey  <tom@tromey.com>
3364
3365         * unittests/format_pieces-selftests.c: Update.  Add final format.
3366         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3367         empty literal pieces.
3368
3369 2019-10-01  Tom Tromey  <tom@tromey.com>
3370
3371         * ui-out.h (enum class ui_out_style_kind): Remove.
3372         (class ui_out) <field_string, field_stsream, do_field_string>:
3373         Change type of "style".
3374         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3375         (ui_out::field_string): Update.
3376         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3377         of "style".
3378         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3379         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3380         * stack.c (print_frame_arg, print_frame_info, print_frame):
3381         Update.
3382         * source.c (print_source_lines_base): Update.
3383         * solib.c (info_sharedlibrary_command): Update.
3384         * skip.c (info_skip_command): Update.
3385         * record-btrace.c (btrace_call_history_src_line)
3386         (btrace_call_history): Update.
3387         * python/py-framefilter.c (py_print_frame): Update.
3388         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3389         "style".
3390         * mi/mi-out.c (mi_ui_out::do_table_header)
3391         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3392         (mi_ui_out::do_field_string): Update.
3393         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3394         Update.
3395         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3396         "style".
3397         * cli-out.c (cli_ui_out::do_table_header)
3398         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3399         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3400         (cli_ui_out::do_field_fmt): Update.
3401         * breakpoint.c (print_breakpoint_location): Update.
3402         (update_static_tracepoint): Update.
3403
3404 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3405
3406         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3407         conversion of gdb_datadir.
3408         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3409         remove not needed c_str ().
3410
3411 2019-09-30  Ali Tamur <tamur@google.com>
3412
3413         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3414         (dwarf2_string_attr): Likewise.
3415
3416 2019-09-30  Ali Tamur <tamur@google.com>
3417
3418         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3419         (process_full_type_unit): Likewise.
3420         (dump_die_shallow): Likewise.
3421         (cu_debug_loc_section): Likewise.
3422
3423 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3424
3425         * minsyms.c (compare_minimal_symbols): Rename to...
3426         (minimal_symbol_is_less_than): ...this, and adjust to STL
3427         conventions (return bool, take arguments as references)
3428         (minimal_symbol_reader::install): Call std::sort instead
3429         of qsort.
3430
3431 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3432
3433         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3434         hash and why.
3435         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3436         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3437
3438 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3439
3440         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3441         * psympriv.h (add_psymbol_to_list): Move comment here and update
3442         it.
3443
3444 2019-09-29  Tom de Vries  <tdevries@suse.de>
3445
3446         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3447         Use $tmpdir/$(basename "$output_file").dwz instead of
3448         "${output_file}.dwz".
3449
3450 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3451
3452         PR gdb/25045
3453         * hppa-linux-nat.c: Include gdbarch.h.
3454
3455 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3456
3457         * blockframe.c (find_pc_partial_function): Change return type to bool.
3458         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3459         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3460         (stub_gnu_ifunc_resolve_name): Likewise.
3461         * symtab.c (compare_filenames_for_search): Likewise.
3462         (compare_glob_filenames_for_search): Likewise.
3463         (matching_obj_sections): Likewise.
3464         (symbol_matches_domain): Likewise.
3465         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3466         (find_line_pc): Change return type to bool.
3467         (find_line_pc_range): Likewise.
3468         (producer_is_realview): Likewise.
3469         * symtab.h (symbol_matches_domain): Likewise.
3470         (find_pc_partial_function): Likewise.
3471         (find_pc_line_pc_range): Likewise.
3472         (in_gnu_ifunc_stub): Likewise.
3473         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3474         (find_line_pc): Likewise.
3475         (find_line_pc_range): Likewise.
3476         (matching_obj_sections): Likewise.
3477         (find_line_symtab): Change out parameter to bool.
3478         (producer_is_realview): Change return type to bool.
3479         (compare_filenames_for_search): Likewise.
3480         (compare_glob_filenames_for_search): Likewise.
3481
3482 2019-09-26  Tom Tromey  <tom@tromey.com>
3483
3484         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3485         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3486         * gdb_usleep.h: Remove.
3487         * gdb_usleep.c: Remove.
3488         * utils.c: Don't include gdb_usleep.h.
3489
3490 2019-09-26  Tom Tromey  <tromey@adacore.com>
3491
3492         * python/py-type.c (type_to_type_object): Call check_typedef
3493         for stub types.
3494
3495 2019-09-26  Tom Tromey  <tom@tromey.com>
3496
3497         * utils.h (initialize_utils): Don't declare.
3498         * top.c (gdb_init): Don't call initialize_utils.
3499         * utils.c (initialize_utils): Remove.  Move contents...
3500         (_initialize_utils): ... here.
3501
3502 2019-09-25  Tom Tromey  <tom@tromey.com>
3503
3504         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3505         * utils.h (make_hex_string): Don't declare.
3506         * utils.c (make_hex_string): Remove.
3507
3508 2019-09-24  Tom de Vries  <tdevries@suse.de>
3509
3510         PR gdb/23815
3511         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3512         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3513
3514 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3515
3516         * NEWS: Mention new simulator port for PRU.
3517
3518 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3519
3520         * ada-exp.y (write_object_remaining): Update.
3521         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3522         and eliminate the static buffer.
3523         (ada_decode_symbol): Update.
3524         (ada_la_decode): Update.
3525         (ada_sniff_from_mangled_name): Update.
3526         (is_valid_name_for_wild_match): Update.
3527         (ada_lookup_name_info::matches): Update and simplify.
3528         (name_matches_regex): Update.
3529         (ada_add_global_exceptions): Update.
3530         * ada-lang.h (ada_decode): Update signature.
3531         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3532         * dwarf-index-write.c (debug_names::insert): Update.
3533
3534 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3535
3536         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3537         formatting.
3538
3539 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3540
3541         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3542         Change "nonzero" to "true" in documentation.
3543
3544 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3545
3546         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3547         (_initialize_darwin_solib): Don't set
3548         darwin_so_ops.lookup_lib_global_symbol.
3549         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3550         set_gdbarch_iterate_over_objfiles_in_search_order.
3551         (elf_lookup_lib_symbol): Rename to...
3552         (svr4_iterate_over_objfiles_in_search_order): this, and update
3553         to iterate semantics.
3554         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3555         * solib.c (solib_global_lookup): Remove.
3556         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3557         (solib_global_lookup): Remove.
3558         * symtab.c (lookup_global_or_static_symbol): Remove call to
3559         solib_global_lookup.
3560
3561 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3562
3563         * NEWS: Move entries about default MI version now being
3564         version 3, and about the GDB/MI fix for multi-location
3565         breakpoints to the "since GDB 8.3" section.
3566
3567 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3568
3569         GDB 8.3.1 released.
3570
3571 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3572
3573         * NEWS: Mention that Cell/B.E. debugging support was removed.
3574         * MAINTAINERS: Remove spu target.
3575
3576         * config/djgpp/fnchange.lst: Remove entries for removed files.
3577
3578         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3579         spu-multiarch.o, and spu-tdep.o.
3580         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3581         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3582         spu-multiarch.c, and spu-tdep.c.
3583         * spu-linux-nat.c: Remove file.
3584         * spu-multiarch.c: Remove file.
3585         * spu-tdep.c: Remove file.
3586         * spu-tdep.h: Remove file.
3587         * solib-spu.c: Remove file.
3588         * solib-spu.h: Remove file.
3589
3590         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3591         * configure.nat (spu-linux): Remove.
3592         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3593         solib-multiarch.o from gdb_target_obs.
3594         (spu*-*-*): Remove.
3595
3596         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3597         feature flag.
3598         (ppc_linux_no_features): Update.
3599         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3600         Cell/B.E. support.
3601         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3602         (tdesc_powerpc_cell64l): Likewise.
3603         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3604         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3605         Cell/B.E. support.
3606         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3607         Do not include "features/rs6000/powerpc-cell32l.c" or
3608         "features/rs6000/powerpc-cell64l.c".
3609         (ppc_linux_spu_section): Remove.
3610         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3611         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3612         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3613         (ppc_linux_spe_context_lookup): Remove.
3614         (ppc_linux_spe_context_inferior_created): Remove.
3615         (ppc_linux_spe_context_solib_loaded): Remove.
3616         (ppc_linux_spe_context_solib_unloaded): Remove.
3617         (ppc_linux_spe_context): Remove.
3618         (struct ppu2spu_cache): Remove.
3619         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3620         (struct ppu2spu_data): Remove.
3621         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3622         ppu2spu_unwind): Remove.
3623         (ppc_linux_init_abi): Remove Cell/B.E. support.
3624         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3625
3626         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3627         (rs6000/powerpc-cell64l-expedite): Likewise
3628         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3629         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3630         rs6000/powerpc-cell64l.xml.
3631         * features/rs6000/powerpc-cell32l.xml: Remove.
3632         * features/rs6000/powerpc-cell64l.xml: Likewise.
3633         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3634         * features/rs6000/powerpc-cell64l.c: Likewise.
3635         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3636         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3637         * regformats/reg-spu.dat: Remove.
3638
3639         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3640         * corelow.c (struct spuid_list): Remove.
3641         (add_to_spuid_list): Remove.
3642         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3643         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3644         (remote_protocol_features): Remove associated entries.
3645         (_initialize_remote): No longer initialize them.
3646         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3647         * linux-nat.c (SPUFS_MAGIC): Remove.
3648         (linux_proc_xfer_spu): Remove.
3649         (spu_enumerate_spu_ids): Remove.
3650         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3651         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3652         (linux_make_corefile_notes): No longer call it.
3653
3654         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3655         (cooked_write_test): Likewise.
3656
3657 2019-09-20  Tom Tromey  <tom@tromey.com>
3658
3659         * NEWS: Mention case-sensitivity of TUI commands.
3660         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3661         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3662         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3663
3664 2019-09-20  Tom Tromey  <tom@tromey.com>
3665
3666         * tui/tui-source.c (tui_source_window::set_contents): Use
3667         make_unique_xstrdup.
3668         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3669         make_unique_xstrdup.
3670
3671 2019-09-20  Tom Tromey  <tom@tromey.com>
3672
3673         * tui/tui-data.c: Remove separator comments.
3674         * tui/tui-layout.c: Remove separator comments.
3675         * tui/tui-win.c: Remove separator comments.
3676         * tui/tui-wingeneral.c: Remove separator comments.
3677
3678 2019-09-20  Tom Tromey  <tom@tromey.com>
3679
3680         * tui/tui.h (strcat_to_buf): Don't declare.
3681         * tui/tui.c (strcat_to_buf): Remove.
3682
3683 2019-09-20  Tom Tromey  <tom@tromey.com>
3684
3685         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3686         from "fullname".
3687         * tui/tui-source.c (tui_source_window::set_contents)
3688         (tui_source_window::location_matches_p)
3689         (tui_source_window::maybe_update): Update.
3690
3691 2019-09-20  Tom Tromey  <tom@tromey.com>
3692
3693         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3694         Update.
3695         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3696         prefix.
3697         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3698         (tui_data_window::line_from_reg_element_no)
3699         (tui_data_window::first_reg_element_no_inline)
3700         (tui_data_window::show_registers)
3701         (tui_data_window::show_register_group)
3702         (tui_data_window::display_registers_from)
3703         (tui_data_window::display_registers_from_line)
3704         (tui_data_window::first_data_item_displayed)
3705         (tui_data_window::delete_data_content_windows)
3706         (tui_data_window::erase_data_content)
3707         (tui_data_window::do_scroll_vertical)
3708         (tui_data_window::refresh_window)
3709         (tui_data_window::check_register_values): Update.
3710
3711 2019-09-20  Tom Tromey  <tom@tromey.com>
3712
3713         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3714         (struct tui_locator_window) <full_name, proc_name>: Now
3715         std::string.
3716         * tui/tui-stack.c (tui_locator_window::make_status_line)
3717         (tui_locator_window::set_locator_fullname)
3718         (tui_locator_window::set_locator_info): Update.
3719         * tui/tui-source.c (tui_source_window::set_contents)
3720         (tui_source_window::showing_source_p): Update.
3721
3722 2019-09-20  Tom Tromey  <tom@tromey.com>
3723
3724         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3725         Don't call tui_locator_win_info_ptr.
3726
3727 2019-09-20  Tom Tromey  <tom@tromey.com>
3728
3729         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3730
3731 2019-09-20  Tom Tromey  <tom@tromey.com>
3732
3733         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3734         height for locator.
3735         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3736         * tui/tui-layout.c (show_source_disasm_command, show_data)
3737         (show_source_or_disasm_and_command): Use 1 as height for locator.
3738
3739 2019-09-20  Tom Tromey  <tom@tromey.com>
3740
3741         * tui/tui.c (tui_enable): Update.
3742         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3743         Update.
3744         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3745         Update.
3746         * tui/tui-data.c (win_resized): Now bool.
3747         (tui_win_resized): Return bool.
3748         (tui_set_win_resized_to): Accept a bool.
3749
3750 2019-09-20  Tom Tromey  <tom@tromey.com>
3751
3752         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3753         Change type of "refresh_values_only".
3754         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3755         type of "refresh_values_only".
3756
3757 2019-09-20  Tom Tromey  <tom@tromey.com>
3758
3759         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3760         std::string.
3761         (tui_disassemble): Add "pos" parameter.
3762         (tui_disasm_window::set_contents): Simplify.
3763
3764 2019-09-20  Tom Tromey  <tom@tromey.com>
3765
3766         * tui/tui-winsource.h (struct tui_source_window_base)
3767         <show_source_content>: Now private.
3768         * tui/tui-winsource.c
3769         (tui_source_window_base::show_source_content): Don't handle empty
3770         content case.
3771
3772 2019-09-20  Tom Tromey  <tom@tromey.com>
3773
3774         * tui/tui-layout.c (show_source_disasm_command)
3775         (show_source_or_disasm_and_command): Don't call
3776         show_source_content.
3777
3778 2019-09-20  Tom Tromey  <tom@tromey.com>
3779
3780         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3781         Declare.
3782         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3783         from tui_make_status_line.
3784         (tui_locator_window::rerender): Update.
3785
3786 2019-09-20  Tom Tromey  <tom@tromey.com>
3787
3788         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3789         (tui_locator_window::rerender): Update.
3790
3791 2019-09-20  Tom Tromey  <tom@tromey.com>
3792
3793         * tui/tui-winsource.h (struct tui_source_window_base)
3794         <~tui_source_window_base>: Don't declare.
3795         <fullname>: Remove.
3796         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3797         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3798         member.
3799         * tui/tui-source.c (tui_source_window::set_contents): Update.
3800         (tui_source_window::location_matches_p)
3801         (tui_source_window::maybe_update): Update.
3802
3803 2019-09-20  Tom Tromey  <tom@tromey.com>
3804
3805         * tui/tui-winsource.h (~tui_source_element): Remove.
3806         (tui_source_element): Update.
3807         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3808         * tui/tui-winsource.c (tui_show_source_line): Update.
3809         * tui/tui-source.c (tui_source_window::set_contents): Update.
3810         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3811
3812 2019-09-20  Tom Tromey  <tom@tromey.com>
3813
3814         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3815         declare.
3816         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3817         tui_clear_source_windows_detail.
3818         * tui/tui-winsource.h (struct tui_source_window_base)
3819         <clear_detail>: Don't declare.
3820         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3821         Remove.
3822         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3823
3824 2019-09-20  Tom Tromey  <tromey@adacore.com>
3825
3826         PR ada/24919:
3827         * block.c (contained_in): Fix final return value.
3828
3829 2019-09-20  Alan Modra  <amodra@gmail.com>
3830
3831         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3832         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3833         (read_indirect_string_from_dwz): Use bfd accessor.
3834         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3835         * machoread.c (macho_symfile_read_all_oso): Likewise.
3836         * solib.c (solib_bfd_open): Likewise.
3837
3838 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3839
3840         * eval.c: Move declaration of overload_resolution to...
3841         * value.h: ...here.
3842
3843 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3844
3845         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3846         * arm-linux-tdep.c: Likewise.
3847         * arm-nbsd-nat.c: Likewise.
3848         * arm-tdep.h: Declare arm_apcs_32.
3849         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3850
3851 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3852
3853         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3854         * dwarf2read.h: Declare dwarf_always_disassemble.
3855
3856 2019-09-19  Tom de Vries  <tdevries@suse.de>
3857
3858         PR gdb/25009
3859         * source-cache.c (source_cache::ensure): Catch exception thrown during
3860         construction of the highlighter.
3861
3862 2019-09-18  Alan Modra  <amodra@gmail.com>
3863
3864         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3865         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3866         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3867         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3868         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3869         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3870         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3871         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3872         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3873         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3874         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3875         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3876         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3877         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3878         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3879         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3880         * mi/mi-interp.c: Update throughout for bfd section macro and
3881         function changes.
3882         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3883         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3884
3885 2019-09-18  Tom Tromey  <tom@tromey.com>
3886
3887         * NEWS: Add entry.
3888         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3889         call rl_initialize.
3890         (tui_enable): Do not call rl_initialize.
3891
3892 2019-09-18  Christian Groessler  <chris@groessler.org>
3893
3894         * alpha-linux-nat.c: Include gdbarch.h.
3895
3896 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3897
3898         * ui-file.c: Include cli/cli-style.h.
3899         (term_cli_styling): Remove cli_styling declaration.
3900
3901 2019-09-18  Alan Modra  <amodra@gmail.com>
3902
3903         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3904         to bfd_asymbol_section.
3905
3906 2019-09-18  Alan Modra  <amodra@gmail.com>
3907
3908         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3909         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3910         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3911
3912 2019-09-18  Alan Modra  <amodra@gmail.com>
3913
3914         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3915         * spu-linux-nat.c (spu_bfd_open): Likewise.
3916
3917 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3918
3919         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3920         to bool to match definition in dwarf2read.c.
3921
3922 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3923
3924         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3925         (print_signatures): Likewise.
3926         (trust_pad_over_xvs): Likewise.
3927         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3928         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3929         * arm-linux-nat.c (arm_apcs_32): Likewise.
3930         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3931         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3932         * arm-tdep.c (arm_debug): Likewise.
3933         (arm_apcs_32): Likewise.
3934         * auto-load.c (debug_auto_load): Likewise.
3935         (auto_load_gdb_scripts): Likewise.
3936         (global_auto_load): Likewise.
3937         (auto_load_local_gdbinit): Likewise.
3938         (auto_load_local_gdbinit_loaded): Likewise.
3939         * auto-load.h (global_auto_load): Likewise.
3940         (auto_load_local_gdbinit): Likewise.
3941         (auto_load_local_gdbinit_loaded): Likewise.
3942         * breakpoint.c (disconnected_dprintf): Likewise.
3943         (breakpoint_proceeded): Likewise.
3944         (automatic_hardware_breakpoints): Likewise.
3945         (always_inserted_mode): Likewise.
3946         (target_exact_watchpoints): Likewise.
3947         (_initialize_breakpoint): Update.
3948         * breakpoint.h (target_exact_watchpoints): Change to bool.
3949         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3950         * cli/cli-cmds.c (trace_commands): Likewise.
3951         * cli/cli-cmds.h (trace_commands): Likewise.
3952         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3953         to bool*.
3954         * cli/cli-logging.c (logging_overwrite): Change to bool.
3955         (logging_redirect): Likewise.
3956         (debug_redirect): Likewise.
3957         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3958         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3959         to bool.
3960         <boolean_option_def>: Update.
3961         (struct flag_option_def): Change default type of Context to bool
3962         from int.
3963         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3964         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3965         (get_setshow_command_value_string): Likewise.
3966         * cli/cli-style.c (cli_styling): Change to bool.
3967         (source_styling): Likewise.
3968         * cli/cli-style.h (source_styling): Likewise.
3969         (cli_styling): Likewise.
3970         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3971         to bool.
3972         * command.h (var_types): Update comment.
3973         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3974         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3975         bool.
3976         (debug_compile_cplus_scopes): Likewise.
3977         * compile/compile-internal.h (compile_debug): Likewise.
3978         * compile/compile.c (compile_debug): Likewise.
3979         (struct compile_options) <raw>: Likewise.
3980         * cp-support.c (catch_demangler_crashes): Likewise.
3981         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3982         (usr_cmd_cris_dwarf2_cfi): Likewise.
3983         * csky-tdep.c (csky_debug): Likewise.
3984         * darwin-nat.c (enable_mach_exceptions): Likewise.
3985         * dcache.c (dcache_enabled_p): Likewise.
3986         * defs.h (info_verbose): Likewise.
3987         * demangle.c (demangle): Likewise.
3988         (asm_demangle): Likewise.
3989         * dwarf-index-cache.c (debug_index_cache): Likewise.
3990         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3991         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3992         * dwarf2read.c (check_physname): Likewise.
3993         (use_deprecated_index_sections): Likewise.
3994         (dwarf_always_disassemble): Likewise.
3995         * eval.c (overload_resolution): Likewise.
3996         * event-top.c (set_editing_cmd_var): Likewise.
3997         (exec_done_display_p): Likewise.
3998         * event-top.h (set_editing_cmd_var): Likewise.
3999         (exec_done_display_p): Likewise.
4000         * exec.c (write_files): Likewise.
4001         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4002         (debug_fbsd_nat): Likewise.
4003         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4004         Likewise.
4005         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4006         <backtrace_past_entry> Likewise.
4007         * gdb-demangle.h (demangle): Likewise.
4008         (asm_demangle): Likewise.
4009         * gdb_bfd.c (bfd_sharing): Likewise.
4010         * gdbcore.h (write_files): Likewise.
4011         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4012         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4013         * gdbthread.h (print_thread_events): Likewise.
4014         * gdbtypes.c (opaque_type_resolution): Likewise.
4015         (strict_type_checking): Likewise.
4016         * gnu-nat.c (gnu_debug_flag): Likewise.
4017         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4018         * guile/scm-param.c (pascm_variable): Add boolval.
4019         (add_setshow_generic): Update.
4020         (pascm_param_value): Update.
4021         (pascm_set_param_value_x): Update.
4022         * hppa-tdep.c (hppa_debug): Change to bool..
4023         * infcall.c (may_call_functions_p): Likewise.
4024         (coerce_float_to_double_p): Likewise.
4025         (unwind_on_signal_p): Likewise.
4026         (unwind_on_terminating_exception_p): Likewise.
4027         * infcmd.c (startup_with_shell): Likewise.
4028         * inferior.c (print_inferior_events): Likewise.
4029         * inferior.h (startup_with_shell): Likewise.
4030         (print_inferior_events): Likewise.
4031         * infrun.c (step_stop_if_no_debug): Likewise.
4032         (detach_fork): Likewise.
4033         (debug_displaced): Likewise.
4034         (disable_randomization): Likewise.
4035         (non_stop): Likewise.
4036         (non_stop_1): Likewise.
4037         (observer_mode): Likewise.
4038         (observer_mode_1): Likewise.
4039         (set_observer_mode): Update.
4040         (sched_multi): Change to bool.
4041         * infrun.h (debug_displaced): Likewise.
4042         (sched_multi): Likewise.
4043         (step_stop_if_no_debug): Likewise.
4044         (non_stop): Likewise.
4045         (disable_randomization): Likewise.
4046         * linux-tdep.c (use_coredump_filter): Likewise.
4047         (dump_excluded_mappings): Likewise.
4048         * linux-thread-db.c (auto_load_thread_db): Likewise.
4049         (check_thread_db_on_load): Likewise.
4050         * main.c (captured_main_1): Update.
4051         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4052         xx2_opt, boolean_opt>: Change to bool.
4053         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4054         * maint.c (maintenance_profile_p): Likewise.
4055         (per_command_time): Likewise.
4056         (per_command_space): Likewise.
4057         (per_command_symtab): Likewise.
4058         * memattr.c (inaccessible_by_default): Likewise.
4059         * mi/mi-main.c (mi_async): Likewise.
4060         (mi_async_1): Likewise.
4061         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4062         * nat/fork-inferior.h (startup_with_shell): Likewise.
4063         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4064         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4065         * nios2-tdep.c (nios2_debug): Likewise.
4066         * or1k-tdep.c (or1k_debug): Likewise.
4067         * parse.c (parser_debug): Likewise.
4068         * parser-defs.h (parser_debug): Likewise.
4069         * printcmd.c (print_symbol_filename): Likewise.
4070         * proc-api.c (procfs_trace): Likewise.
4071         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4072         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4073         (set_parameter_value): Update.
4074         (add_setshow_generic): Update.
4075         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4076         to bool*.
4077         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4078         int*.
4079         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4080         * record-btrace.c (record_btrace_target::store_registers): Update.
4081         * record-full.c (record_full_memory_query): Change to bool.
4082         (record_full_stop_at_limit): Likewise.
4083         * record-full.h (record_full_memory_query): Likewise.
4084         * remote-notif.c (notif_debug): Likewise.
4085         * remote-notif.h (notif_debug): Likewise.
4086         * remote.c (use_range_stepping): Likewise.
4087         (interrupt_on_connect): Likewise.
4088         (remote_break): Likewise.
4089         * ser-tcp.c (tcp_auto_retry): Likewise.
4090         * ser-unix.c (serial_hwflow): Likewise.
4091         * skip.c (debug_skip): Likewise.
4092         * solib-aix.c (solib_aix_debug): Likewise.
4093         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4094         (spu_auto_flush_cache_p): Likewise.
4095         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4096         Likewise.
4097         (struct info_print_options) <quiet>: Likewise.
4098         * symfile-debug.c (debug_symfile): Likewise.
4099         * symfile.c (auto_solib_add): Likewise.
4100         (separate_debug_file_debug): Likewise.
4101         * symfile.h (auto_solib_add): Likewise.
4102         (separate_debug_file_debug): Likewise.
4103         * symtab.c (basenames_may_differ): Likewise.
4104         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4105         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4106         (struct info_types_options) <quiet>: Likewise.
4107         * symtab.h (demangle): Likewise.
4108         (basenames_may_differ): Likewise.
4109         * target-dcache.c (stack_cache_enabled_1): Likewise.
4110         (code_cache_enabled_1): Likewise.
4111         * target.c (trust_readonly): Likewise.
4112         (may_write_registers): Likewise.
4113         (may_write_memory): Likewise.
4114         (may_insert_breakpoints): Likewise.
4115         (may_insert_tracepoints): Likewise.
4116         (may_insert_fast_tracepoints): Likewise.
4117         (may_stop): Likewise.
4118         (auto_connect_native_target): Likewise.
4119         (target_stop_and_wait): Update.
4120         (target_async_permitted): Change to bool.
4121         (target_async_permitted_1): Likewise.
4122         (may_write_registers_1): Likewise.
4123         (may_write_memory_1): Likewise.
4124         (may_insert_breakpoints_1): Likewise.
4125         (may_insert_tracepoints_1): Likewise.
4126         (may_insert_fast_tracepoints_1): Likewise.
4127         (may_stop_1): Likewise.
4128         * target.h (target_async_permitted): Likewise.
4129         (may_write_registers): Likewise.
4130         (may_write_memory): Likewise.
4131         (may_insert_breakpoints): Likewise.
4132         (may_insert_tracepoints): Likewise.
4133         (may_insert_fast_tracepoints): Likewise.
4134         (may_stop): Likewise.
4135         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4136         (make_thread_apply_all_options_def_group): Change argument from int*
4137         to bool*.
4138         (thread_apply_all_command): Update.
4139         (print_thread_events): Change to bool.
4140         * top.c (confirm): Likewise.
4141         (command_editing_p): Likewise.
4142         (history_expansion_p): Likewise.
4143         (write_history_p): Likewise.
4144         (info_verbose): Likewise.
4145         * top.h (confirm): Likewise.
4146         (history_expansion_p): Likewise.
4147         * tracepoint.c (disconnected_tracing): Likewise.
4148         (circular_trace_buffer): Likewise.
4149         * typeprint.c (print_methods): Likewise.
4150         (print_typedefs): Likewise.
4151         * utils.c (debug_timestamp): Likewise.
4152         (sevenbit_strings): Likewise.
4153         (pagination_enabled): Likewise.
4154         * utils.h (sevenbit_strings): Likewise.
4155         (pagination_enabled): Likewise.
4156         * valops.c (overload_resolution): Likewise.
4157         * valprint.h (struct value_print_options) <prettyformat_arrays,
4158         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4159         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4160         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4161         Likewise.
4162         * windows-nat.c (new_console): Likewise.
4163         (cygwin_exceptions): Likewise.
4164         (new_group): Likewise.
4165         (debug_exec): Likewise.
4166         (debug_events): Likewise.
4167         (debug_memory): Likewise.
4168         (debug_exceptions): Likewise.
4169         (useshell): Likewise.
4170         * windows-tdep.c (maint_display_all_tib): Likewise.
4171         * xml-support.c (debug_xml): Likewise.
4172
4173 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4174
4175         * source.c (prepare_path_for_appending): New function.
4176         (openp): Make use of new function.
4177         (find_and_open_source): Search for the compilation directory and
4178         source file as a relative path beneath the directory search path.
4179
4180 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4181
4182         * source-cache.c (source_cache::get_line_charpos): Catch
4183         exceptions and return false, this matches the behaviour documented
4184         in the header file.
4185
4186 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4187
4188         * ada-tasks.c (info_task): Remove quoting of the task's name.
4189
4190 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4191
4192         * symfile.c (auto_solib_add): Replace comment with a reference
4193         to the header file.
4194
4195 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4196
4197         * NEWS: Mention that gdb can now be compiled with Python 3
4198         on Windows.
4199
4200 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4201
4202         * maint.c (maint_print_section_data::maint_print_section_data):
4203         Force use of 'float log10 (float)' by casting the argument to
4204         float.
4205
4206 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4207
4208         * maint.c: Add 'cmath' include.
4209         (struct maint_print_section_data): New structure.
4210         (print_section_index): New function.
4211         (print_bfd_section_info): Add header comment, small whitespace
4212         cleanup, and update to call new print_section_index function.
4213         (print_objfile_section_info): Likewise.
4214         (maint_obj_section_from_bfd_section): New function.
4215         (print_bfd_section_info_maybe_relocated): New function.
4216         (maintenance_info_sections): Add header comment, always use
4217         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4218
4219 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4220
4221         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4222         inner scope, add check that the objfile has psymtabs before
4223         checking psymtabs_addrmap.
4224         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4225
4226 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4227
4228         * NEWS: Announce that Ada task names are now shown at more places,
4229         and between quotes (except in info task output).
4230         * gdb/ada-tasks.c (task_to_str): New function.
4231         (display_current_task_id): Call task_to_str.
4232         (task_command_1): Likewise.
4233         (print_ada_task_info): In non-mi mode, Properly align headers and data
4234         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4235
4236 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4237
4238         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4239         prstatus.pr_lwp.pr_info instead of making it up.
4240
4241 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4242
4243         * auto-load.c (auto_load_expand_dir_vars): Update.
4244         * defs.h (gdb_datadir): Change to std::string.
4245         (python_libdir): Likewise.
4246         (relocate_gdb_directory): Change return type to std::string.
4247         * guile/guile.c (gdbscm_data_directory): Update.
4248         (initialize_scheme_side): Update.
4249         * jit.c (jit_reader_dir): Change to std::string.
4250         (jit_reader_load_command): Update.
4251         * main.c (gdb_datadir): Change to std::string.
4252         (python_libdir): Likewise.
4253         (set_gdb_data_directory): Update.
4254         (relocate_path): Change to return std::string.
4255         (relocate_gdb_directory): Change to return std::string.
4256         (relocate_gdbinit_path_maybe_in_datadir): Update.
4257         (captured_main_1): Update.
4258         * python/python.c (do_start_initialization): Update.
4259         * top.c (show_gdb_datadir): Update.
4260         * xml-syscall.c (xml_init_syscalls_info): Update.
4261         (init_syscalls_info): Update.
4262
4263 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4264
4265         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4266         out of get_init_files.
4267         (get_init_files): Update.
4268
4269 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4270
4271         * main.c (get_init_files): Change to use std::string.
4272         (captured_main_1): Update.
4273         (print_gdb_help): Update.
4274
4275 2019-09-11  Ali Tamur  <tamur@google.com>
4276
4277         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4278         implementation.
4279
4280 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4281
4282         * dbxread.c (read_dbx_symtab): Update.
4283         * dwarf2read.c (load_partial_dies): Update.
4284         * mdebugread.c (parse_partial_symbols): Update.
4285         (handle_psymbol_enumerators): Update.
4286         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4287         * psymtab.c (add_psymbol_to_bcache): Likewise.
4288         (add_psymbol_to_list): Likewise.
4289         * symtab.c (symbol_set_names): Likewise.
4290         * symtab.h (symbol_set_names): Likewise.
4291         * xcoffread.c (scan_xcoff_symtab): Update.
4292
4293 2019-09-11  Tom Tromey  <tom@tromey.com>
4294
4295         * symfile-mem.c (symbol_file_add_from_memory): Use
4296         bfd_set_filename.
4297         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4298         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4299
4300 2019-09-10  Tom Tromey  <tromey@adacore.com>
4301
4302         * dwarf-index-write.c (write_psymbols): Extend error message.
4303         (debug_names::insert): Add Ada code.
4304         (debug_names::write_psymbols): Remove Ada check.
4305         (debug_names) <m_string_obstack>: New member.
4306         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4307         (gdb_index_symbol_name_matcher::matches): Remove.
4308         (mapped_index_base::find_name_components_bounds): Add "lang"
4309         parameter.
4310         (mapped_index_base::build_name_components): Also split names
4311         according to Ada syntax.
4312         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4313         type of "match_callback".
4314         (check_match, check_find_bounds_finds)
4315         (dw2_expand_symtabs_matching): Update.
4316         (dw2_debug_names_iterator): Add new constructor.
4317         (dw2_debug_names_map_matching_symbols): New function.
4318         (dw2_debug_names_expand_symtabs_matching): Update.
4319         (dwarf2_debug_names_functions): Use
4320         dw2_debug_names_map_matching_symbols.
4321
4322 2019-09-10  Tom Tromey  <tromey@adacore.com>
4323
4324         * dwarf2read.c (dw2_get_file_names_reader): Add the
4325         CU's file name to the results.
4326
4327 2019-09-10  Tom Tromey  <tromey@adacore.com>
4328
4329         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4330         map_matching_symbols.  Update.
4331         * dwarf2read.c (dw2_map_matching_symbols): Update.
4332         * psymtab.c (match_partial_symbol): Change type; update.
4333         (psym_map_matching_symbols): Likewise.
4334         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4335         type; update.
4336         * symfile.h (struct quick_symbol_functions)
4337         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4338         Remove "match".
4339
4340 2019-09-10  Tom Tromey  <tromey@adacore.com>
4341
4342         * psymtab.c (map_block): Remove.
4343         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4344         * symtab.c (iterate_over_symbols_terminated): New function.
4345         * symtab.c (iterate_over_symbols_terminated): Declare.
4346
4347 2019-09-10  Tom Tromey  <tromey@adacore.com>
4348
4349         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4350         * language.h (struct language_defn) <la_iterate_over_symbols>:
4351         Return bool.
4352         * symtab.c (iterate_over_symbols): Return bool.
4353         * symtab.h (iterate_over_symbols): Return bool.
4354
4355 2019-09-10  Tom Tromey  <tromey@adacore.com>
4356
4357         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4358         (add_nonlocal_symbols): Update.
4359         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4360         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4361         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4362         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4363         Change type of "callback".  Remove "data".
4364
4365
4366 2019-09-09  Ali Tamur  <tamur@google.com>
4367
4368         * dwarf2read.c (comp_unit_head): Update comment.
4369         (dwarf2_dwo_name): New function declaration.
4370         (dwarf_unit_type_name): New function declaration.
4371         (read_comp_unit_head): Add support for new compilation units,
4372         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4373         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4374         (currently named as "signature") in their header. Also clarify error
4375         messages.
4376         (lookup_dwo_id): New function. Returns the dwo id of the given
4377         compile unit.
4378         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4379         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4380         functions.
4381         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4382         (dwarf2_dwo_name): Get the dwo name if present.
4383         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4384         purposes.
4385
4386 2019-09-09  Tom Tromey  <tom@tromey.com>
4387
4388         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4389
4390 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4391
4392         * python/python.c (do_start_initialization): Make progname_copy static,
4393         to avoid a leak report.
4394
4395 2019-09-08  Tom Tromey  <tom@tromey.com>
4396
4397         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4398
4399 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4400
4401         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4402         Change type to gdb::optional<block_enum>.
4403         (dw2_symtab_iter_init): Change block_index parameter type
4404         to gdb::optional<block_enum>.
4405         (dw2_lookup_symbol): Change block_index parameter
4406         type to block_enum.c
4407         (dw2_debug_names_lookup_symbol): Likewise.
4408         * psymtab.c (psym_lookup_symbol): Likewise.
4409         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4410         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4411         Likewise.
4412
4413 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4414
4415         * defs.h (relocate_gdb_directory): Change int to bool in
4416         signature and rename flag to relocatable.
4417         * main.c (relocate_path): Likewise.
4418         (relocate_gdb_directory): Likewise.
4419
4420 2019-09-06  Alan Modra  <amodra@gmail.com>
4421
4422         * coffread.c (coff_symfile_read): Constify filename variable.
4423         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4424         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4425         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4426         * solib.c (reload_shared_libraries_1): Likewise.
4427         * symfile.c (reread_symbols): Likewise.
4428         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4429         * solib-darwin.c (darwin_bfd_open): Likewise.
4430         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4431
4432 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4433
4434         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4435         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4436
4437 2019-09-03  Tom Tromey  <tromey@adacore.com>
4438
4439         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4440         types.
4441         (has_negatives): Unbias a range type bound.
4442         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4443         * gdbtypes.c (operator==): Handle new field.
4444         (create_range_type): Add "bias" parameter.
4445         (create_static_range_type, resolve_dynamic_range): Update.
4446         * gdbtypes.h (struct range_bounds) <bias>: New member.
4447         (create_range_type): Add bias parameter.
4448         * printcmd.c (print_scalar_formatted): Unbias range types.
4449         * value.c (unpack_long): Unbias range types.
4450         (pack_long): Bias range types.
4451
4452 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4453
4454         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4455         probe arguments.
4456
4457 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4458
4459         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4460         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4461         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4462         (compile_probe_arg): Likewise.
4463         * probe.h (get_argument_count): Likewise.
4464         * solib-svr4.c (solib_event_probe_action): Likewise.
4465         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4466
4467 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4468
4469         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4470         code to here...
4471         (svr4_create_solib_event_breakpoints): ...from here.
4472
4473 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4474
4475         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4476         suffix from warning message.
4477
4478 2019-08-30  Tom Tromey  <tom@tromey.com>
4479
4480         * tui/tui-winsource.h (struct tui_source_window_base)
4481         <refresh_all>: Don't declare.
4482         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4483         Remove.
4484         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4485         tui_show_locator_content.
4486         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4487         declare.
4488         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4489         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4490         declare.
4491
4492 2019-08-30  Tom Tromey  <tom@tromey.com>
4493
4494         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4495
4496 2019-08-30  Tom Tromey  <tom@tromey.com>
4497
4498         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4499         Remove unnecessary forward declarations.
4500
4501 2019-08-30  Tom Tromey  <tom@tromey.com>
4502
4503         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4504         rerender.
4505         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4506         tui_show_locator_content.
4507
4508 2019-08-30  Tom Tromey  <tom@tromey.com>
4509
4510         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4511         (tui_locator_window::rerender): Rewrite using body of previous
4512         tui_show_locator_content.
4513
4514 2019-08-30  Tom Tromey  <tom@tromey.com>
4515
4516         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4517         set_locator_fullname>: New methods.
4518         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4519         Rename from tui_set_locator_fullname.
4520         (tui_locator_window::set_locator_info): Rename from
4521         tui_set_locator_info.  Return bool.
4522         (tui_update_locator_fullname, tui_show_frame_info): Update.
4523
4524 2019-08-30  Tom Tromey  <tom@tromey.com>
4525
4526         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4527
4528 2019-08-30  Tom Tromey  <tom@tromey.com>
4529
4530         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4531         call touchwin.
4532
4533 2019-08-30  Tom Tromey  <tom@tromey.com>
4534
4535         * tui/tui-wingeneral.c (box_win): Assume win_info and
4536         win_info->handle cannot be NULL.
4537
4538 2019-08-30  Tom Tromey  <tom@tromey.com>
4539
4540         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4541         refresh_window>: Declare.
4542         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4543         resize.
4544         (tui_data_item_window::rerender): Rename from
4545         tui_display_register.
4546         (tui_data_item_window::refresh_window): New method.
4547         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4548         no-op.
4549
4550 2019-08-30  Tom Tromey  <tom@tromey.com>
4551
4552         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4553         regs_column_count, current_group>: Move later.  Now private.
4554         <get_current_group>: New method.
4555         * tui/tui-regs.c (tui_reg_command): Update.
4556         * tui/tui-layout.c (tui_set_layout): Update.
4557
4558 2019-08-30  Tom Tromey  <tom@tromey.com>
4559
4560         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4561         (tui_data_window::rerender): Don't call
4562         check_and_display_highlight_if_needed.
4563         (tui_data_window::refresh_all): Remove call to
4564         erase_data_content.
4565
4566 2019-08-30  Tom Tromey  <tom@tromey.com>
4567
4568         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4569         (tui_data_window::display_registers_from)
4570         (tui_data_window::display_reg_element_at_line)
4571         (tui_data_window::display_registers_from_line): Remove checks of
4572         "empty".
4573
4574 2019-08-30  Tom Tromey  <tom@tromey.com>
4575
4576         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4577         Don't declare.
4578         * tui/tui-regs.c (tui_data_window::show_registers): Call
4579         rerender.
4580         (tui_data_window::rerender): Rename from display_all_data.
4581         (tui_data_window::rerender): Remove old implementation.
4582
4583 2019-08-30  Tom Tromey  <tom@tromey.com>
4584
4585         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4586         text.
4587         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4588
4589 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4590             Sergio Durigan Junior  <sergiodj@redhat.com>
4591
4592         PR win32/24284
4593         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4594
4595 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4596
4597         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4598         when searching for types.
4599
4600 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4601
4602         * f-lang.c (f_language_defn): Use f_print_typedef.
4603         * f-lang.h (f_print_typedef): Declare.
4604         * f-typeprint.c (f_print_typedef): Define.
4605
4606 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4607
4608         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4609
4610 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4611
4612         * cli/cli-utils.c (info_print_options_defs): Delete.
4613         (make_info_print_options_def_group): Delete.
4614         (extract_info_print_options): Delete.
4615         (info_print_command_completer): Delete.
4616         (info_print_args_help): Add extra parameter, and optionally
4617         include text about -n flag.
4618         * cli/cli-utils.h (struct info_print_options): Delete.
4619         (extract_info_print_options): Delete declaration.
4620         (info_print_command_completer): Delete declaration.
4621         (info_print_args_help): Add extra parameter, extend header
4622         comment.
4623         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4624         search_symbols.
4625         * stack.c (struct info_print_options): New type.
4626         (info_print_options_defs): New file scoped variable.
4627         (make_info_print_options_def_group): New static function.
4628         (info_print_command_completer): New static function.
4629         (info_locals_command): Update to use new local functions.
4630         (info_args_command): Likewise.
4631         (_initialize_stack): Add extra parameter to calls to
4632         info_print_args_help.
4633         * symtab.c (search_symbols): Add extra parameter, use this to
4634         possibly excluse non-debug symbols.
4635         (symtab_symbol_info): Add extra parameter, which is passed on to
4636         search_symbols.
4637         (struct info_print_options): New type.
4638         (info_print_options_defs): New file scoped variable.
4639         (make_info_print_options_def_group): New static function.
4640         (info_print_command_completer): New static function.
4641         (info_variables_command): Update to use local functions, and pass
4642         extra parameter through to symtab_symbol_info.
4643         (info_functions_command): Likewise.
4644         (info_types_command): Pass additional argument through to
4645         symtab_symbol_info.
4646         (rbreak_command): Pass extra argument to search_symbols.
4647         (_initialize_symtab): Add extra arguments for calls to
4648         info_print_args_help, and update help text for 'info variables',
4649         'whereis', and 'info functions' commands.
4650         * symtab.h (search_symbols): Add extra argument to declaration.
4651         * NEWS: Mention new flags.
4652
4653 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4654
4655         * symtab.c (lookup_static_symbol): Call the new function (and move
4656         it down to be next to lookup_global_symbol).
4657         (struct global_sym_lookup_data): Add block_enum member and rename to...
4658         (struct global_or_static_sym_lookup_data): ...this.
4659         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4660         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4661         (lookup_symbol_global_or_static_iterator_cb): ...this.
4662         (lookup_global_or_static_symbol): New function.
4663         (lookup_global_symbol): Call new function.
4664
4665 2019-08-26  Tom de Vries  <tdevries@suse.de>
4666
4667         PR c++/24852
4668         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4669         when pc_probe.prob == NULL.
4670
4671 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4672
4673         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4674         variable symbol_linkage to symbol_linkage_.
4675
4676 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4677
4678         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4679         represent whether the symbol is static, dynamic, or we don't
4680         know.
4681
4682 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4683
4684         * gdb/rx-tdep.c (rx_register_names): New.
4685         (rx_register_name): Delete.
4686         (rx_psw_type): Delete.
4687         (rx_fpsw_type): Delete.
4688         (rx_register_type): Delete.
4689         (rx_gdbarch_init): Convert target-descriptions.
4690         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4691         * gdb/features/Makefile: Add rx.xml.
4692         * gdb/features/rx.xml: New.
4693         * gdb/features/rx.c: Generated.
4694         * gdb/NEWS: Mention target description support.
4695
4696 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4697
4698         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4699         *slot_ptr.
4700
4701 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4702
4703         * configure.ac: Don't check for 'dlfcn.h' (moved to
4704         gdbsupport/common.m4).
4705         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4706         'gdbsupport/'.
4707         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4708         * compile/compile-c-support.c: Include
4709         'gdbsupport/gdb-dlfcn.h'.
4710         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4711         * gdb-dlfcn.c: Move to...
4712         * gdbsupport/gdb-dlfcn.c: ... here.
4713         * gdb-dlfcn.h: Move to...
4714         * gdbsupport/gdb-dlfcn.h: ... here.
4715
4716 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4717
4718         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4719         the offset field signed.
4720
4721 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4722
4723         * python/lib/gdb/__init__.py (_execute_file): New function.
4724         * python/python.c (python_run_simple_file): Call gdb._execute_file
4725         on Windows.
4726
4727 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4728
4729         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4730         all uses as this was never set to anything but a zero value.
4731
4732 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4733
4734         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4735
4736 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4737
4738         * tui/tui-data.h (tui_gen_win_info): Add an =default
4739         move constructor, required by some GCC versions.
4740
4741 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4742
4743         * go32-nat.c (go32_sysinfo): Add hygon_p.
4744
4745 2019-08-20  Tom Tromey  <tom@tromey.com>
4746
4747         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4748         line_from_reg_element_no, first_reg_element_no_inline,
4749         display_all_data, delete_data_content_windows,
4750         erase_data_content>: Now private.
4751
4752 2019-08-20  Tom Tromey  <tom@tromey.com>
4753
4754         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4755         (tui_unhighlight_win, tui_highlight_win)
4756         (tui_win_info::make_window): Update.
4757         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4758
4759 2019-08-20  Tom Tromey  <tom@tromey.com>
4760
4761         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4762         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4763         (MAX_PID_WIDTH): Move to tui-stack.c.
4764         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4765         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4766         (MAX_PID_WIDTH): Move from tui-data.h.
4767
4768 2019-08-20  Tom Tromey  <tom@tromey.com>
4769
4770         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4771         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4772         (box_win): Update.
4773         (tui_gen_win_info::make_window): Rename from tui_make_window.
4774         (tui_win_info::make_window): New method.
4775         (tui_gen_win_info::make_visible): Update.
4776         * tui/tui-source.c (tui_source_window::set_contents): Update.
4777         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4778         (tui_data_window::display_registers_from): Update.
4779         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4780         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4781         Declare.
4782         <can_box>: Remove.
4783         <title>: Remove.
4784         (struct tui_win_info) <make_window>: Declare.
4785         <can_box>: Now virtual.
4786         <title>: New member.
4787         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4788         * tui/tui-command.c (tui_cmd_window::resize): Update.
4789
4790 2019-08-20  Tom Tromey  <tom@tromey.com>
4791
4792         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4793         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4794         (tui_data_window::check_register_values): Update.
4795
4796 2019-08-20  Tom Tromey  <tom@tromey.com>
4797
4798         * tui/tui-regs.h (struct tui_data_window): Use
4799         DISABLE_COPY_AND_ASSIGN.
4800         <regs_content>: Change type, removing unique_ptr.
4801         <tui_data_window>: Add move constructor.
4802         * tui/tui-regs.c (tui_data_window::show_registers)
4803         (tui_data_window::show_register_group)
4804         (tui_data_window::display_registers_from)
4805         (tui_data_window::display_registers_from)
4806         (tui_data_window::first_data_item_displayed)
4807         (tui_data_window::delete_data_content_windows)
4808         (tui_data_window::rerender, tui_data_window::refresh_window)
4809         (tui_data_window::check_register_values): Update.
4810
4811 2019-08-20  Tom Tromey  <tom@tromey.com>
4812
4813         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4814         show_register_group>: Declare.
4815         (tui_show_register_group): Don't declare.
4816         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4817         tui_show_registers.
4818         (tui_data_window::show_register_group): Rename from
4819         tui_show_register_group.
4820         (tui_data_window::check_register_values, tui_reg_command):
4821         Update.
4822         * tui/tui-layout.c (tui_set_layout): Update.
4823
4824 2019-08-20  Tom Tromey  <tom@tromey.com>
4825
4826         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4827         Declare.
4828         (tui_check_register_values): Don't declare.
4829         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4830         from tui_check_register_values.
4831         * tui/tui-hooks.c (tui_register_changed): Update.
4832
4833 2019-08-20  Tom Tromey  <tom@tromey.com>
4834
4835         * tui/tui-regs.c (tui_reg_layout): Move later.
4836         (tui_show_registers): Don't enable TUI mode or change layout.
4837
4838 2019-08-20  Tom Tromey  <tom@tromey.com>
4839
4840         * tui/tui-regs.h (struct tui_data_item_window)
4841         <~tui_data_item_window>: Remove.
4842         <content>: Now a unique_xmalloc_ptr.
4843         * tui/tui-regs.c (tui_register_format): Return a
4844         unique_xmalloc_ptr.
4845         (tui_get_register): Update.
4846         (~tui_data_item_window): Remove.
4847         (tui_data_window::display_registers_from, tui_display_register):
4848         Update.
4849         * tui/tui-io.h (tui_expand_tabs): Update.
4850         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4851         Remove "col" parameter.
4852
4853 2019-08-20  Tom Tromey  <tom@tromey.com>
4854
4855         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4856         field.
4857         * tui/tui-regs.c (~tui_data_item_window): Update.
4858
4859 2019-08-20  Tom Tromey  <tom@tromey.com>
4860
4861         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4862         earlier.
4863
4864 2019-08-20  Tom Tromey  <tom@tromey.com>
4865
4866         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4867
4868 2019-08-20  Tom Tromey  <tom@tromey.com>
4869
4870         * tui/tui-source.h (struct tui_source_window): Update.
4871         * tui/tui-regs.c (tui_show_registers): Update.
4872         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4873         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4874         (NO_REGS_STRING): Remove defines.
4875
4876 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4877
4878         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4879         unnecessary thread walk if remote doesn't support the packet.
4880
4881 2019-08-19  Tom Tromey  <tromey@adacore.com>
4882
4883         * python/py-value.c (value_has_field): Fix indentation.
4884
4885 2019-08-19  Tom Tromey  <tromey@adacore.com>
4886
4887         * printcmd.c (do_one_display, info_display_command): Update.
4888         * block.h (contained_in): Return bool.  Add allow_nested
4889         parameter.
4890         * block.c (contained_in): Return bool.  Add allow_nested
4891         parameter.
4892
4893 2019-08-19  Tom Tromey  <tom@tromey.com>
4894
4895         * configure: Rebuild.
4896         * configure.ac: Disallow the combination of -static-libstdc++ and
4897         source highlight.
4898         * source-cache.c (get_language_name): Handle rust.
4899         (source_cache::get_source_lines): Ignore highlighting exceptions.
4900
4901 2019-08-16  Tom Tromey  <tom@tromey.com>
4902
4903         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4904         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4905         (struct tui_source_window_base) <make_visible, refresh_window,
4906         resize>: Remove methods.
4907         <execution_info>: Remove field.
4908         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4909         (tui_show_source_line, tui_source_window_base)
4910         (~tui_source_window_base): Update.
4911         (tui_source_window_base::resize)
4912         (tui_source_window_base::make_visible)
4913         (tui_source_window_base::refresh_window): Remove.
4914         (tui_source_window_base::update_exec_info): Update.
4915         * tui/tui-source.c (tui_source_window::set_contents): Update.
4916         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4917
4918 2019-08-16  Tom Tromey  <tom@tromey.com>
4919
4920         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4921         deprecated_query_hook.
4922
4923 2019-08-16  Tom Tromey  <tom@tromey.com>
4924
4925         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4926         (tui_update_source_windows_with_line): Update.
4927         * tui/tui-source.h (struct tui_source_window)
4928         <show_symtab_source>: Declare.
4929         (tui_show_symtab_source): Don't declare.
4930         * tui/tui-source.c (tui_show_symtab_source): Rename from
4931         tui_show_symtab_source.
4932
4933 2019-08-16  Tom Tromey  <tom@tromey.com>
4934
4935         * tui/tui-winsource.h (struct tui_source_window_base)
4936         <set_contents>: Declare.
4937         * tui/tui-winsource.c
4938         (tui_source_window_base::update_source_window_as_is): Update.
4939         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4940         Declare.
4941         (tui_set_source_content): Don't declare.
4942         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4943         tui_set_source_content.
4944         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4945         Declare.
4946         (tui_set_disassem_content): Don't declare.
4947         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4948         tui_set_disassem_content.
4949
4950 2019-08-16  Tom Tromey  <tom@tromey.com>
4951
4952         * tui/tui-winsource.h (struct tui_source_window_base)
4953         <update_breakpoint_info>: Declare.
4954         (tui_update_breakpoint_info): Don't declare.
4955         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4956         (tui_update_all_breakpoint_info): Update.
4957         (tui_source_window_base::update_breakpoint_info): Rename from
4958         tui_update_breakpoint_info.
4959         (tui_source_window_base::update_exec_info): Update.
4960
4961 2019-08-16  Tom Tromey  <tom@tromey.com>
4962
4963         * tui/tui-winsource.h (struct tui_source_window_base)
4964         <update_source_window>: Declare.
4965         (tui_update_source_window): Don't declare.
4966         * tui/tui-winsource.c
4967         (tui_source_window_base::update_source_window): Rename from
4968         tui_update_source_window.
4969         (tui_source_window_base::rerender): Update.
4970         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4971         * tui/tui-disasm.c (tui_show_disassem)
4972         (tui_show_disassem_and_update_source)
4973         (tui_disasm_window::maybe_update): Update.
4974
4975 2019-08-16  Tom Tromey  <tom@tromey.com>
4976
4977         * tui/tui-winsource.h (struct tui_source_window_base)
4978         <update_source_window_as_is>: Declare.
4979         (tui_update_source_window_as_is): Don't declare.
4980         * tui/tui-winsource.c (tui_update_source_window): Update
4981         (tui_source_window_base::update_source_window_as_is): Rename from
4982         tui_update_source_window_as_is.
4983         (tui_source_window_base::refill): Update.
4984         * tui/tui-source.c (tui_show_symtab_source): Update.
4985         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4986         Update.
4987
4988 2019-08-16  Tom Tromey  <tom@tromey.com>
4989
4990         * tui/tui-winsource.h (tui_update_source_window)
4991         (tui_update_source_window_as_is): Remove "noerror" parameter.
4992         * tui/tui-winsource.c (tui_update_source_window)
4993         (tui_update_source_window_as_is): Remove "noerror" parameter.
4994         (tui_update_source_windows_with_addr)
4995         (tui_update_source_windows_with_line)
4996         (tui_source_window_base::rerender)
4997         (tui_source_window_base::refill): Update.
4998         * tui/tui-source.h (tui_set_source_content)
4999         (tui_show_symtab_source): Remove "noerror" parameter.
5000         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5001         parameter.
5002         (tui_show_symtab_source): Likewise.
5003         (tui_source_window::maybe_update): Update.
5004         * tui/tui-disasm.c (tui_show_disassem)
5005         (tui_show_disassem_and_update_source)
5006         (tui_disasm_window::do_scroll_vertical)
5007         (tui_disasm_window::maybe_update): Update.
5008
5009 2019-08-16  Tom Tromey  <tom@tromey.com>
5010
5011         * tui/tui.c (tui_is_window_visible): Update.
5012         * tui/tui-wingeneral.c (tui_make_window)
5013         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5014         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5015         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5016         (tui_set_win_height_command, parse_scrolling_args): Update.
5017         * tui/tui-source.c (tui_source_window::style_changed): Update.
5018         * tui/tui-regs.c (tui_show_registers)
5019         (tui_data_window::first_data_item_displayed)
5020         (tui_data_window::delete_data_content_windows)
5021         (tui_check_register_values, tui_reg_command): Update.
5022         * tui/tui-disasm.c (tui_show_disassem): Update.
5023         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5024         method.
5025         <is_visible>: Remove field.
5026         * tui/tui-data.c (tui_next_win, tui_prev_win)
5027         (tui_delete_invisible_windows): Update.
5028
5029 2019-08-16  Tom Tromey  <tom@tromey.com>
5030
5031         * tui/tui-winsource.h (struct tui_source_window_base)
5032         <m_has_locator>: Remove.
5033         * tui/tui-layout.c (show_source_disasm_command, show_data)
5034         (show_source_or_disasm_and_command): Update.
5035
5036 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5037
5038         * NEWS (Other MI changes): New subsection.
5039         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5040         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5041         * arch-utils.c (default_get_pc_address_flags): New function.
5042         * arch-utils.h (default_get_pc_address_flags): New declaration.
5043         * gdbarch.sh: Add get_pc_address_flags.
5044         * gdbarch.c: Regenerate.
5045         * gdbarch.h: Likewise.
5046         * stack.c (print_pc): New function.
5047         (print_frame_info) (print_frame): Call print_pc.
5048
5049 2019-08-16  Tom de Vries  <tdevries@suse.de>
5050
5051         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5052         print_objfile_section_info.
5053
5054 2019-08-15  Tom Tromey  <tom@tromey.com>
5055
5056         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5057         calling update_cmdwin_start_line.
5058         * tui/tui-winsource.h (struct tui_source_window_base)
5059         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5060         <rerender>: Declare.
5061         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5062         Call rerender.
5063         (tui_source_window_base::set_new_height): Remove.
5064         (tui_source_window_base::rerender): Rename from
5065         do_make_visible_with_new_height.
5066         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5067         resize method.
5068         (tui_win_info::make_invisible_and_set_new_height)
5069         (tui_win_info::make_visible_with_new_height): Remove.
5070         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5071         Declare.
5072         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5073         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5074         do_make_visible_with_new_height>: Don't declare.
5075         <rerender>: Declare.
5076         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5077         set_new_height.
5078         (tui_data_window::do_make_visible_with_new_height): Remove.
5079         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5080         call tui_show_locator_content.
5081         (tui_gen_win_info::resize): Call rerender.
5082         (show_source_or_disasm_and_command): Don't call
5083         tui_show_locator_content.
5084         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5085         method.
5086         (struct tui_win_info) <rerender>: Declare.
5087         <set_new_height, make_invisible_and_set_new_height,
5088         make_visible_with_new_height>: Don't declare.
5089         * tui/tui-data.c (tui_win_list::rerender): New method.
5090         * tui/tui-command.h (struct tui_cmd_window)
5091         <do_make_visible_with_new_height>: Don't declare.
5092         * tui/tui-command.c
5093         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5094
5095 2019-08-15  Tom Tromey  <tromey@adacore.com>
5096
5097         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5098         * ada-lang.c (ada_enum_name): Likewise.
5099
5100 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5101
5102         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5103         leading underscore.
5104         (GdbOutputErrorFile): Likewise.
5105         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5106         accordingly.
5107         (execute_unwinders): Rename to have a leading underscore.
5108         (auto_load_packages): Likewise.
5109         (global scope): Adjust call to auto_load_packages accordingly.
5110         (GdbSetPythonDirectory): Likewise.
5111         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5112         instead of execute_unwinders.
5113
5114 2019-08-15  Tom Tromey  <tom@tromey.com>
5115
5116         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5117         (show_data): Don't change window visibility.
5118         (tui_gen_win_info::resize): Remove special case for command
5119         window.  Use wresize, when available.
5120         (show_source_or_disasm_and_command): Don't change window
5121         visibility.
5122         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5123         <make_visible>: New method.
5124         * tui/tui-command.c (tui_cmd_window::resize): New method.
5125
5126 2019-08-15  Tom Tromey  <tom@tromey.com>
5127
5128         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5129         (struct tui_source_windows): New.
5130         * tui/tui-winsource.c (tui_display_main): Update.
5131         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5132         (new_height_ok, parse_scrolling_args): Update.
5133         * tui/tui-layout.c (show_layout, show_data): Update.
5134         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5135         (tui_add_to_source_windows): Don't declare.
5136         * tui/tui-data.c (source_windows, tui_source_windows)
5137         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5138
5139 2019-08-15  Tom Tromey  <tom@tromey.com>
5140
5141         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5142         Rename from reset.
5143         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5144         * tui/tui-layout.c (show_source_disasm_command, show_data):
5145         Update.
5146         (tui_gen_win_info::resize): Rename.
5147         (show_source_or_disasm_and_command): Update.
5148         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5149         reset.
5150
5151 2019-08-15  Tom Tromey  <tom@tromey.com>
5152
5153         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5154         * tui/tui-interp.c (tui_interp::init): Don't call
5155         tui_initialize_static_data.
5156         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5157
5158 2019-08-15  Tom Tromey  <tom@tromey.com>
5159
5160         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5161         examine tui_win_list.
5162
5163 2019-08-15  Tom Tromey  <tom@tromey.com>
5164
5165         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5166         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5167         tui_clear_source_content.
5168         (tui_clear_source_content): Remove.
5169         (tui_source_window_base::do_erase_source_content): Hoist call to
5170         content.clear().
5171         * tui/tui-stack.c (tui_show_frame_info): Don't call
5172         tui_clear_source_content.
5173
5174 2019-08-15  Tom Tromey  <tom@tromey.com>
5175
5176         * tui/tui-winsource.h (struct tui_source_window_base)
5177         <do_erase_source_content>: New method.
5178         <erase_source_content>: New method.
5179         (tui_erase_source_content): Don't declare.
5180         * tui/tui-winsource.c (tui_clear_source_content): Update.
5181         (tui_source_window_base::do_erase_source_content): Rename from
5182         tui_erase_source_content.
5183         (tui_source_window_base::show_source_content): Update.
5184         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5185         * tui/tui-source.h (struct tui_source_window)
5186         <erase_source_content>: New method.
5187         * tui/tui-disasm.h (struct tui_disasm_window)
5188         <erase_source_content>: New method.
5189
5190 2019-08-15  Tom Tromey  <tom@tromey.com>
5191
5192         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5193         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5194         constructor.
5195         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5196         * tui/tui-source.c (tui_set_source_content): Update.
5197         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5198
5199 2019-08-15  Tom Tromey  <tom@tromey.com>
5200
5201         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5202         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5203         tui-source.c.
5204         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5205         Declare.
5206         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5207         method.
5208         (tui_source_window::maybe_update): Update.
5209
5210 2019-08-15  Tom Tromey  <tom@tromey.com>
5211
5212         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5213         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5214         tui-disasm.c.
5215         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5216         Declare.
5217         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5218         method.
5219         (tui_disasm_window::maybe_update): Update.
5220
5221 2019-08-15  Tom Tromey  <tom@tromey.com>
5222
5223         * tui/tui-winsource.h (struct tui_source_window_base)
5224         <maybe_update>: Declare.
5225         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5226         method.
5227         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5228         Declare.
5229         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5230         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5231         Declare.
5232         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5233
5234 2019-08-15  Tom Tromey  <tom@tromey.com>
5235
5236         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5237
5238 2019-08-15  Tom Tromey  <tom@tromey.com>
5239
5240         * tui/tui-wingeneral.c: Include tui-stack.h.
5241         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5242         (struct tui_locator_window): Move from tui-data.h.
5243         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5244         (tui_initialize_static_data): Move from tui-data.c.
5245         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5246         (struct tui_locator_window): Move to tui-stack.c.
5247         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5248         (tui_initialize_static_data): Move to tui-stack.c.
5249
5250 2019-08-15  Tom Tromey  <tom@tromey.com>
5251
5252         * tui/tui-layout.c (show_source_disasm_command)
5253         (show_source_or_disasm_and_command): Use make_visible method, not
5254         tui_make_window.
5255         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5256         Remove.
5257
5258 2019-08-15  Tom Tromey  <tom@tromey.com>
5259
5260         * tui/tui-wingeneral.h (tui_make_window): Update.
5261         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5262         parameter.
5263         (tui_gen_win_info::make_visible): Update.
5264         * tui/tui-regs.c (tui_data_window::display_registers_from):
5265         Update.
5266         * tui/tui-layout.c (show_source_disasm_command)
5267         (show_source_or_disasm_and_command): Update.
5268         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5269         (enum tui_box): Remove.
5270         (struct tui_win_info) <can_box>: New method.
5271         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5272         method.
5273
5274 2019-08-15  Tom de Vries  <tdevries@suse.de>
5275
5276         * linux-nat-trad.c: Include gdbarch.h.
5277
5278 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5279
5280         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5281         register sizes.
5282
5283 2019-08-14  Tom Tromey  <tromey@adacore.com>
5284
5285         * darwin-nat.c: Include gdbarch.h.
5286         * darwin-nat-info.c: Include gdbarch.h.
5287
5288 2019-08-13  Tom Tromey  <tom@tromey.com>
5289
5290         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5291         Remove.
5292         * tui/tui-data.c (tui_initialize_static_data): Update.
5293
5294 2019-08-13  Tom Tromey  <tom@tromey.com>
5295
5296         * tui/tui-winsource.h (struct tui_exec_info_window)
5297         <~tui_exec_info_window, maybe_allocate_content, get_content,
5298         m_content>: Remove.
5299         (struct tui_source_window_base) <set_exec_info_content,
5300         show_exec_info_content>: Don't declare.
5301         * tui/tui-winsource.c
5302         (tui_exec_info_window::maybe_allocate_content): Remove.
5303         (tui_source_window_base::update_exec_info): Rename from
5304         set_exec_info_content.
5305         (tui_source_window_base::show_exec_info_content)
5306         (tui_source_window_base::update_exec_info): Remove.
5307
5308 2019-08-13  Tom Tromey  <tom@tromey.com>
5309
5310         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5311         declare.
5312         * tui/tui-winsource.c (tui_update_source_window_as_is)
5313         (tui_update_source_windows_with_addr, tui_erase_source_content):
5314         Update.
5315         (tui_clear_exec_info_content): Remove.
5316
5317 2019-08-13  Tom Tromey  <tom@tromey.com>
5318
5319         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5320         declare.
5321         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5322         call tui_erase_exec_info_content.
5323         (tui_clear_exec_info_content): Rename from
5324         tui_erase_exec_info_content.
5325         (tui_clear_exec_info_content): Delete.
5326
5327 2019-08-13  Tom Tromey  <tom@tromey.com>
5328
5329         * tui/tui-winsource.h (struct tui_source_window_base)
5330         <show_exec_info_content>: Declare.
5331         (tui_show_exec_info_content): Don't declare.
5332         * tui/tui-winsource.c
5333         (tui_source_window_base::show_exec_info_content): Rename from
5334         tui_show_exec_info_content.
5335         (tui_source_window_base::update_exec_info): Update.
5336
5337 2019-08-13  Tom Tromey  <tom@tromey.com>
5338
5339         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5340         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5341         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5342         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5343         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5344         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5345         ... here.
5346
5347 2019-08-13  Tom Tromey  <tom@tromey.com>
5348
5349         * tui/tui-winsource.h (struct tui_source_window_base)
5350         <update_exec_info>: Declare.
5351         (tui_update_exec_info): Don't declare.
5352         * tui/tui-winsource.c (tui_update_source_window_as_is)
5353         (tui_source_window_base::refresh_all)
5354         (tui_update_all_breakpoint_info): Update.
5355         (tui_source_window_base::update_exec_info): Rename from
5356         tui_update_exec_info.
5357         * tui/tui-stack.c (tui_show_frame_info): Update.
5358
5359 2019-08-13  Tom Tromey  <tom@tromey.com>
5360
5361         * tui/tui-winsource.h (struct tui_source_window_base)
5362         <set_exec_info_content>: Declare.
5363         (tui_set_exec_info_content): Don't declare.
5364         * tui/tui-winsource.c
5365         (tui_source_window_base::set_exec_info_content): Rename from
5366         tui_set_exec_info_content.
5367         (tui_update_exec_info): Update.
5368
5369 2019-08-13  Tom Tromey  <tom@tromey.com>
5370
5371         * tui/tui-winsource.h (struct tui_source_window_base)
5372         <show_source_content>: Declare.
5373         (tui_show_source_content): Don't declare.
5374         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5375         (tui_source_window_base::show_source_content): Rename from
5376         tui_show_source_content.
5377         (tui_source_window_base::refresh_all): Update.
5378         * tui/tui-layout.c (show_source_disasm_command)
5379         (show_source_or_disasm_and_command): Update.
5380
5381 2019-08-13  Tom Tromey  <tom@tromey.com>
5382
5383         * tui/tui-winsource.c (tui_erase_source_content)
5384         (tui_show_source_content, tui_source_window_base::refresh_all):
5385         Update.
5386         * tui/tui-wingeneral.h
5387         (tui_check_and_display_highlight_if_needed): Don't declare.
5388         * tui/tui-wingeneral.c
5389         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5390         check_and_display_highlight_if_needed.
5391         * tui/tui-win.c (tui_rehighlight_all)
5392         (tui_win_info::make_visible_with_new_height): Update.
5393         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5394         (tui_data_window::erase_data_content)
5395         (tui_data_window::display_all_data): Update.
5396         * tui/tui-data.h (struct tui_win_info)
5397         <check_and_display_highlight_if_needed>: Declare.
5398
5399 2019-08-13  Tom Tromey  <tom@tromey.com>
5400
5401         * tui/tui-win.c (tui_resize_all): Call
5402         tui_delete_invisible_windows.
5403         * tui/tui-layout.c (show_layout): Call
5404         tui_delete_invisible_windows.
5405         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5406         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5407
5408 2019-08-13  Tom Tromey  <tom@tromey.com>
5409
5410         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5411         tui_add_win_to_layout.
5412
5413 2019-08-13  Tom Tromey  <tom@tromey.com>
5414
5415         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5416         * tui/tui-layout.c (tui_default_win_height): Now static.
5417
5418 2019-08-13  Tom Tromey  <tom@tromey.com>
5419
5420         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5421         single switch.
5422         (show_source_disasm_command, show_source_or_disasm_and_command):
5423         Don't check current layout.
5424
5425 2019-08-13  Tom Tromey  <tom@tromey.com>
5426
5427         * tui/tui-wingeneral.c (make_all_visible): Remove.
5428         (tui_make_all_invisible): Simplify.
5429         * tui/tui-layout.c (tui_make_all_invisible): Move from
5430         tui-wingeneral.c; simplify.
5431         (show_layout): Hoist call to tui_make_all_invisible.
5432         (show_data): Don't call tui_make_all_invisible.
5433
5434 2019-08-13  Tom Tromey  <tom@tromey.com>
5435
5436         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5437         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5438
5439 2019-08-13  Tom Tromey  <tom@tromey.com>
5440
5441         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5442         tui-data.c.
5443         (show_source_disasm_command, show_data)
5444         (show_source_or_disasm_and_command): Don't use
5445         tui_set_current_layout_to.
5446         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5447         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5448         tui-layout.c.
5449         (tui_set_current_layout_to): Remove.
5450
5451 2019-08-13  Tom Tromey  <tom@tromey.com>
5452
5453         * tui/tui-layout.c (tui_set_layout): Update.
5454         * tui/tui-data.h (struct tui_layout_def): Remove.
5455         (tui_layout_def): Don't declare.
5456         * tui/tui-data.c (layout_def): Remove.
5457         (tui_layout_def): Remove.
5458
5459 2019-08-13  Tom Tromey  <tom@tromey.com>
5460
5461         * tui/tui-winsource.h (struct tui_source_window_base)
5462         <clear_detail>: No longer "override".
5463         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5464         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5465         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5466         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5467         Remove.
5468         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5469
5470 2019-08-13  Tom Tromey  <tromey@adacore.com>
5471
5472         * tracepoint.c: Don't include readline.h or history.h.
5473
5474 2019-08-12  Tom Tromey  <tom@tromey.com>
5475
5476         * configure: Rebuild.
5477         * configure.ac: Check for readline 7.
5478         * NEWS: Mention readline 7 requirement.
5479         * README: Update.
5480
5481 2019-08-12  Tom Tromey  <tom@tromey.com>
5482
5483         * mingw-hdep.c (gdb_select): Remove readline hack.
5484
5485 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5486
5487         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5488         when the function fails.
5489
5490 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5491
5492         * s390-tdep.c (s390_type_align): New function.
5493         (s390_gdbarch_init): Set it as type_align gdbarch method.
5494
5495 2019-08-09  Tom de Vries  <tdevries@suse.de>
5496
5497         PR gdb/24591
5498         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5499         pc_low with relocation offset.
5500
5501 2019-08-07  Tom Tromey  <tromey@adacore.com>
5502
5503         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5504         (print_frame_args): Update.
5505         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5506         Update.
5507         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5508         * frame.h (struct frame_arg): Add initializers.
5509         <error>: Now a unique_xmalloc_ptr.
5510
5511 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5512
5513         * NEWS: Expand the Pointer Authentication entry.
5514         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5515         (aarch64_frame_unmask_lr): ... to this.
5516         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5517         Call aarch64_frame_unmask_lr.
5518         * frame.c (struct frame_info): Add "masked" variable.
5519         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5520         (fprint_frame): Check for masked pc.
5521         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5522         declarations.
5523         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5524         * stack.c (print_frame): Check for masked pc.
5525
5526 2019-08-06  Tom Tromey  <tom@tromey.com>
5527
5528         * stabsread.c (patch_block_stabs, read_one_struct_field)
5529         (read_enum_type): Use obstack_strndup.
5530         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5531         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5532         * dwarf2read.c (guess_full_die_structure_name)
5533         (anonymous_struct_prefix): Use obstack_strndup.
5534         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5535         * c-exp.y (yylex): Use obstack_strndup.
5536         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5537         (write_var_or_type): Use obstack_strndup.
5538
5539 2019-08-06  Tom Tromey  <tom@tromey.com>
5540
5541         * symfile.c (reread_symbols): Use obstack_strdup.
5542         * stabsread.c (read_type): Use obstack_strdup.
5543         * gdb_obstack.h (obstack_strdup): New overload.
5544         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5545         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5546         (dwarf2_canonicalize_name): Use obstack_strdup.
5547         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5548         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5549         Use obstack_strdup.
5550
5551 2019-08-06  Tom Tromey  <tom@tromey.com>
5552
5553         * gdb_obstack.h (obstack_strdup): Define.
5554         * gdb_obstack.c (obstack_strdup): Don't define.
5555
5556 2019-08-06  Tom Tromey  <tom@tromey.com>
5557
5558         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5559         obstack_strdup.
5560         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5561         obstack_strdup.
5562         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5563         * stabsread.c (common_block_start): Use obstack_strdup.
5564         * objfiles.c (set_objfile_main_name, objfile): Use
5565         obstack_strdup.
5566         * namespace.c (add_using_directive): Use obstack_strdup.
5567         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5568         * jit.c (finalize_symtab): Use obstack_strdup.
5569         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5570         (guess_partial_die_structure_name, partial_die_info::fixup)
5571         (dwarf2_name): Use obstack_strdup.
5572         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5573         obstack_strdup.
5574         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5575         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5576         obstack_strdup.
5577         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5578
5579 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5580
5581         * unittests/help-doc-selftests.c: New file.
5582         * Makefile.in: Add the new file.
5583
5584 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5585
5586         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5587         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5588         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5589         the trailing '.' is not output, and the first character is uppercased.
5590         (print_help_for_command): Update call to print_doc_line.
5591         (print_doc_of_command): Likewise.
5592         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5593         * cli/cli-option.c (append_indented_doc): Do not append newline.
5594         (build_help_option): Append newline after first appended_indented_doc
5595         only if a second call is done.
5596         (build_help): Append 2 new lines before each option, except the first
5597         one.
5598         * compile/compile.c (_initialize_compile): Add new lines after
5599         %OPTIONS%, when not at the end of the help.
5600         Change help doc or code
5601         producing the help doc to respect the invariants.
5602         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5603         Also removed the new line after 'Options:', as all other commands
5604         do not put an empty line between 'Options:' and the first option.
5605         * printcmd.c (_initialize_printcmd): Likewise.
5606         * stack.c (_initialize_stack): Likewise.
5607         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5608         incorrectly telling COMMAND is optional.
5609         * ada-lang.c (_initialize_ada_language): Change help doc or code
5610         producing the help doc to respect the invariants.
5611         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5612         * breakpoint.c (_initialize_breakpoint): Likewise.
5613         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5614         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5615         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5616         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5617         _initialize_cli_style): Likewise.
5618         * corelow.c (core_target_info): Likewise.
5619         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5620         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5621         * filesystem.c (_initialize_filesystem): Likewise.
5622         * frame.c (_initialize_frame): Likewise.
5623         * gnu-nat.c (add_task_commands): Likewise.
5624         * infcall.c (_initialize_infcall): Likewise.
5625         * infcmd.c (_initialize_infcmd): Likewise.
5626         * interps.c (_initialize_interpreter): Likewise.
5627         * language.c (_initialize_language): Likewise.
5628         * linux-fork.c (_initialize_linux_fork): Likewise.
5629         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5630         * maint.c (_initialize_maint_cmds): Likewise.
5631         * memattr.c (_initialize_mem): Likewise.
5632         * printcmd.c (_initialize_printcmd): Likewise.
5633         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5634         _RegEx): Likewise.
5635         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5636         * record-btrace.c (_initialize_record_btrace): Likewise.
5637         * record-full.c (_initialize_record_full): Likewise.
5638         * record.c (_initialize_record): Likewise.
5639         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5640         * regcache.c (_initialize_regcache): Likewise.
5641         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5642         _initialize_remote): Likewise.
5643         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5644         * serial.c (_initialize_serial): Likewise.
5645         * skip.c (_initialize_step_skip): Likewise.
5646         * source.c (_initialize_source): Likewise.
5647         * stack.c (_initialize_stack): Likewise.
5648         * symfile.c (_initialize_symfile): Likewise.
5649         * symtab.c (_initialize_symtab): Likewise.
5650         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5651         * top.c (init_main): Likewise.
5652         * tracefile-tfile.c (tfile_target_info): Likewise.
5653         * tracepoint.c (_initialize_tracepoint): Likewise.
5654         * tui/tui-win.c (_initialize_tui_win): Likewise.
5655         * utils.c (add_internal_problem_command): Likewise.
5656         * valprint.c (value_print_option_defs): Likewise.
5657
5658 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5659
5660         PR build/24886
5661         * configure.ac: Drop enable-libmcheck support.
5662         * configure, config.in: Rebuild.
5663         * libmcheck.m4: Remove.
5664         * acinclude.m4: Don't include it.
5665         * Makefile.in: Don't distribute it.
5666         * top.c (print_gdb_configuration): Don't mention it.
5667
5668 2019-08-06  Tom Tromey  <tom@tromey.com>
5669
5670         * utils.c (set_output_style): Sometimes pass stream to
5671         emit_style_escape.
5672         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5673         * record-btrace.c (btrace_insn_history): Update.
5674         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5675         method.
5676         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5677         Update initializers.
5678         <m_uiout>: New field.
5679         <m_di>: Move lower.
5680         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5681         Remove "uiout" parameter.
5682         (dump_insns): Update.
5683         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5684         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5685
5686 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5687
5688         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5689         (error_in_psymtab_expansion): Likewise.
5690         (lookup_symbol_via_quick_fns): Likewise.
5691         (basic_lookup_transparent_type_quick): Likewise.
5692         (basic_lookup_transparent_type_1): Likewise.
5693
5694 2019-08-06  Tom Tromey  <tromey@adacore.com>
5695
5696         * source.c (last_source_error): Now bool.
5697         (print_source_lines_base): Make "noprint" bool.  Only open
5698         source file when last_source_visited changes.
5699
5700 2019-08-06  Tom Tromey  <tromey@adacore.com>
5701
5702         * annotate.c (annotate_source_line): Use g_source_cache.
5703         * source-cache.c (source_cache::get_plain_source_lines): Change
5704         parameters.  Populate m_offset_cache.
5705         (source_cache::ensure): New method.
5706         (source_cache::get_line_charpos): New method.
5707         (extract_lines): Move lower.  Change parameters.
5708         (source_cache::get_source_lines): Move lower.
5709         * source-cache.h (class source_cache): Update comment.
5710         <get_line_charpos>: New method.
5711         <get_source_lines>: Update comment.
5712         <clear>: Clear m_offset_cache.
5713         <get_plain_source_lines>: Change parameters.
5714         <ensure>: New method
5715         <m_offset_cache>: New member.
5716         * source.c (forget_cached_source_info_for_objfile): Update.
5717         (info_source_command): Use g_source_cache.
5718         (find_source_lines, open_source_file_with_line_charpos): Remove.
5719         (print_source_lines_base, search_command_helper): Use g_source_cache.
5720         * source.h (open_source_file_with_line_charpos): Don't declare.
5721         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5722         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5723         Use g_source_cache.
5724
5725 2019-08-06  Tom Tromey  <tromey@adacore.com>
5726
5727         * source-cache.c (source_cache::get_plain_source_lines):
5728         Remove "first_line" and "last_line" parameters.
5729         (source_cache::get_source_lines): Cache plain text.
5730         * source-cache.h (class source_cache)
5731         <get_plain_source_lines>: Update.
5732
5733 2019-08-06  Tom Tromey  <tromey@adacore.com>
5734
5735         * source-cache.c (extract_lines): No longer a method.
5736         Changed type of parameter.  Include final newline.
5737         (selftests::extract_lines_test): New function.
5738         (_initialize_source_cache): Likewise.
5739         * source-cache.h (class source_cache)
5740         <extract_lines>: Don't declare.
5741
5742 2019-08-06  Tom Tromey  <tromey@adacore.com>
5743
5744         * breakpoint.c (init_breakpoint_sal): Update.
5745         (breakpoint): Update.
5746         * breakpoint.h (struct breakpoint) <filter>: Now a
5747         unique_xmalloc_ptr.
5748
5749 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5750
5751         * NEWS: Mention dictionary access on blocks.
5752         * python/py-block.c (blpy_getitem): New function.
5753         (block_object_as_mapping): New struct.
5754         (block_object_type): Use new struct for tp_as_mapping field.
5755
5756 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5757
5758         * objfiles.h (objfile): Add a comment describing partial symbols.
5759
5760 2019-08-05  Tom Tromey  <tromey@adacore.com>
5761
5762         * compile/compile.c (_initialize_compile): Use _(), not N_().
5763         * thread.c (_initialize_thread): Use _(), not N_().
5764         * stack.c (_initialize_stack): Use _(), not N_().
5765         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5766
5767 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5768
5769         * dwarf2read.c (struct dw2_symtab_iterator):
5770         <want_specific_block>: Remove.
5771         <block_index>: Change type to gdb::optional.
5772         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5773         change type of BLOCK_INDEX parameter to gdb::optional.
5774         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5775         (dw2_lookup_symbol): Don't pass argument for
5776         WANT_SPECIFIC_BLOCK.
5777         (dw2_expand_symtabs_for_function): Don't pass argument for
5778         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5779         (class dw2_debug_names_iterator)
5780         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5781         parameter, change BLOCK_INDEX type to gdb::optional.
5782         <m_want_specific_block>: Remove.
5783         <m_block_index>: Change type to gdb::optional.
5784         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5785         gdb::optional.  Re-write in function of gdb::optional.
5786         (dw2_debug_names_lookup_symbol): Don't pass argument for
5787         WANT_SPECIFIC_BLOCK.
5788         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5789         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5790         BLOCK_INDEX.
5791
5792 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5793
5794         * NEWS: Mention changes to "info sources" command.
5795
5796 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5797
5798         * symtab.c (filename_partial_match_opts): New struct type.
5799         (struct output_source_filename_data): New members
5800         regexp, c_regexp, partial_match.
5801         (output_source_filename): Use new members to decide to print file.
5802         (info_sources_option_defs): New variable.
5803         (make_info_sources_options_def_group, print_info_sources_header,
5804         info_sources_command_completer):
5805         New functions.
5806         (info_sources_command): Read new optional arguments.
5807         (_initialize_symtab): Update info sources help.
5808
5809 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5810
5811         * ada-lang.c (exception_support_info_v0): Renamed from...
5812         (default_exception_support_info): ... this.  Create new
5813         definition for v1.
5814         (ada_has_this_exception_support): Look up catch_handlers_sym.
5815         (ada_exception_support_info_sniffer): Try v0 after default.
5816
5817 2019-08-01  Tom Tromey  <tromey@adacore.com>
5818
5819         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5820         gdbarch.h.
5821
5822 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5823
5824         * s12z-tdep.c: Fix include path for s12z-opc.h.
5825
5826 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5827
5828         * NEWS: Require GNU make 3.82.
5829
5830 2019-07-16  Tom Tromey  <tom@tromey.com>
5831
5832         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5833         declare.
5834
5835 2019-07-30  Tom Tromey  <tromey@adacore.com>
5836
5837         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5838
5839 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5840
5841         * printcmd.c (print_address_symbolic): Print negative offsets.
5842         (build_address_symbolic): Force signed arithmetic when computing
5843         offset.
5844
5845 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5846
5847         PR/24474: Add a function to lookup static variables.
5848         * NEWS: Mention this new function.
5849         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5850         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5851         * python/python.c (python_GdbMethods): Add new function.
5852
5853 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5854
5855         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5856         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5857         (objfpy_lookup_static_symbol): New function.
5858         (objfile_object_methods): Add new functions.
5859
5860 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5861
5862         * NEWS: Mention 'set|show print frame-info'.  Mention new
5863         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5864         backtrace argument.  Mention that python frame filtering code
5865         is now consistent with what 'backtrace' command prints.
5866
5867 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5868
5869         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5870         comments.
5871         (print_frame_info_auto, print_frame_info_source_line,
5872         print_frame_info_location, print_frame_info_source_and_location,
5873         print_frame_info_location_and_address, print_frame_info_short_location):
5874         New declarations.
5875         (struct frame_print_options): New member print_frame_info.
5876         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5877         * stack.h (get_user_print_what_frame_info): New declaration.
5878         (frame_show_address): New declaration.
5879         * stack.c (print_frame_arguments_choices): New value 'presence'.
5880         (print_frame_info_auto, print_frame_info_source_line,
5881         print_frame_info_location, print_frame_info_source_and_location,
5882         print_frame_info_location_and_address, print_frame_info_short_location,
5883         print_frame_info_choices, print_frame_info_print_what): New definitions.
5884         (print_frame_args): Only print dots for args if print frame-arguments
5885         is 'presence'.
5886         (frame_print_option_defs): New element for "frame-info".
5887         (get_user_print_what_frame_info): New function.
5888         (frame_show_address): Make non static.  Move comment to stack.h.
5889         (print_frame_info_to_print_what): New function.
5890         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5891         to decide what to print.
5892         (backtrace_command_1): Handle the new print_frame_arguments_presence
5893         value.
5894         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5895         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5896         (py_print_frame): In non-mi mode, use LOCATION as default for
5897         print_what, similarly to frame information printed directly by
5898         backtrace command. Handle frame-info user option in non MI mode.
5899
5900 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5901
5902         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5903         Add case for debugging 32-bit target on 64-bit host.  Revise
5904         comment.
5905
5906 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5907
5908         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5909         instead of find_function_entry_range_from_pc.
5910
5911 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5912
5913         * stack.c (find_frame_funname): Remove code which preferred
5914         minsym over symtab sym in "certain pathological cases".
5915
5916         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5917         parameter.  Change type of "do_demangle" to bool.
5918         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5919         Pass suitable "prefer_sym_over_minsym" flag to
5920         build_address_symbolic().  Don't output "+" for negative offsets.
5921         * printcmd.c (print_address_symbolic): Update invocation of
5922         build_address_symbolic to include a "prefer_sym_over_minsym"
5923         flag.
5924         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5925         Restrict cases in which use of minimal symbol is preferred to that
5926         of a found symbol.  Update comments.
5927
5928         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5929         for entry pc when entry pc is out of range for that FDE.
5930
5931 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5932
5933         PR gdb/24839:
5934         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5935         type.
5936
5937 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5938
5939         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5940         this function's Python signature.
5941
5942
5943 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5944
5945         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5946         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5947         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5948         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5949         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5950
5951
5952 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5953
5954         * h8300-tdep.c (h8300_register_name_common): New.
5955         h8300_register_name): Use h8300_register_name_common.
5956         (h8300s_register_name): Likewise.
5957         (h8300sx_register_name): Likewise.
5958         (h8300h_register_nam): New.
5959         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5960
5961
5962 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5963
5964         * arm-tdep.c (arm_skip_cmse_entry): New function.
5965         (arm_is_sgstubs_section): New function.
5966         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5967
5968 2019-07-22  Tom Tromey  <tom@tromey.com>
5969
5970         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5971         Don't self-assign.
5972
5973 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5974
5975         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5976         type_print.
5977
5978 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5979
5980         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5981         so that GDB doesn't match any msymbols when searching in the
5982         TYPES_DOMAIN.
5983         (print_symbol_info): Print using typedef_print or type_print based
5984         on the type of the symbol.  Add updated FIXME comment moved from...
5985         (_initialize_symtab): ... move and update FIXME comment to above.
5986
5987 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5988
5989         * NEWS: Mention adding -q option to "info types".
5990         * symtab.c (struct info_types_options): New struct.
5991         (info_types_options_defs): New variable.
5992         (make_info_types_options_def_group): New function.
5993         (info_types_command): Use gdb::option framework to parse options.
5994         (info_types_command_completer): New function.
5995         (_initialize_symtab): Extend the help text on "info types" and
5996         register command completer.
5997
5998 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
5999
6000         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6001         (lookup_symbol_in_objfile): Change int to block_enum and add a
6002         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6003
6004 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6005
6006         * MAINTAINERS (Write After Approval): Add self.
6007
6008 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6009
6010         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6011         instruction to the dummy code region.
6012
6013 2019-07-19  Tom Tromey  <tromey@adacore.com>
6014
6015         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6016         (ARGSUSED, PARAMS, __func__): Remove rules.
6017
6018 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6019
6020         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6021         * features/arm/arm-with-iwmmxt.c: Remove.
6022         * features/arm/arm-with-iwmmxt.xml: Remove.
6023         * features/arm/arm-with-m-fpa-layout.c: Remove.
6024         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6025         * features/arm/arm-with-m-vfp-d16.c: Remove.
6026         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6027         * features/arm/arm-with-m.c: Remove.
6028         * features/arm/arm-with-m.xml: Remove.
6029         * features/arm/arm-with-neon.c: Remove.
6030         * features/arm/arm-with-neon.xml: Remove.
6031         * features/arm/arm-with-vfpv2.c: Remove.
6032         * features/arm/arm-with-vfpv2.xml: Remove.
6033         * features/arm/arm-with-vfpv3.c: Remove.
6034         * features/arm/arm-with-vfpv3.xml: Remove.
6035
6036 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6037
6038         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6039
6040 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6041
6042         * arch/aarch32.c (aarch32_create_target_description): Create
6043         target descriptions using features.
6044         * arch/arm.c (arm_create_target_description)
6045         (arm_create_mprofile_target_description): Likewise.
6046         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6047
6048 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6049
6050         * Makefile.in: Add new files.
6051         * aarch32-tdep.c: New file.
6052         * aarch32-tdep.h: New file.
6053         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6054         Call aarch32_read_description.
6055         * arch/aarch32.c: New file.
6056         * arch/aarch32.h: New file.
6057         * arch/arm.c (arm_create_target_description)
6058         (arm_create_mprofile_target_description): New function.
6059         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6060         (arm_create_target_description)
6061         (arm_create_mprofile_target_description): New declaration.
6062         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6063         read_description functions.
6064         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6065         Likewise.
6066         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6067         * arm-tdep.c (tdesc_arm_list): New variable.
6068         (arm_register_g_packet_guesses): Call create description functions.
6069         (arm_read_description) (arm_read_mprofile_description): New
6070         function.
6071         * arm-tdep.h (arm_read_description)
6072         (arm_read_mprofile_description): Add declaration.
6073         * configure.tgt: Add new files.
6074
6075 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6076
6077         * top.c (new_ui_command): Open specified terminal just once.
6078
6079 2019-07-18  Tom Tromey  <tromey@adacore.com>
6080
6081         * symtab.c (main_name): Constify return type.
6082         * symfile.c (set_initial_language): Update.
6083         * symtab.h (main_name): Constify return type.
6084
6085 2019-07-17  Tom Tromey  <tom@tromey.com>
6086
6087         * tui/tui-winsource.c (tui_update_source_window)
6088         (tui_update_source_window_as_is)
6089         (tui_update_source_windows_with_line): Remove return.
6090         * tui/tui-disasm.c (tui_show_disassem)
6091         (tui_show_disassem_and_update_source): Remove return.
6092         * tui/tui.c (tui_reset): Remove return.
6093         * tui/tui-wingeneral.c
6094         (tui_check_and_display_highlight_if_needed): Remove return.
6095
6096 2019-07-17  Tom Tromey  <tom@tromey.com>
6097
6098         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6099
6100 2019-07-17  Tom Tromey  <tom@tromey.com>
6101
6102         * tui/tui-winsource.h (struct tui_exec_info_window)
6103         (struct tui_source_window_base): Move from tui-data.h.
6104         * tui/tui-winsource.c: Move many method definitions from
6105         elsewhere.  Remove "structuring" comments.
6106         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6107         (tui_source_window_base::refresh_window): Move to
6108         tui-winsource.c.
6109         * tui/tui-win.c (tui_source_window_base::refresh_all)
6110         (tui_source_window_base::update_tab_width)
6111         (tui_source_window_base::set_new_height)
6112         (tui_source_window_base::do_make_visible_with_new_height): Move to
6113         tui-winsource.c.
6114         * tui/tui-source.h: Update.
6115         * tui/tui-source.c (tui_source_window_base::reset): Move to
6116         tui-winsource.c.
6117         * tui/tui-disasm.h: Update.
6118         * tui/tui-data.h (struct tui_exec_info_window): Move to
6119         tui-winsource.h.
6120         (struct tui_source_window_base): Likewise.
6121         * tui/tui-data.c (tui_source_window_base::clear_detail)
6122         (tui_source_window_base, ~tui_source_window_base): Move to
6123         tui-winsource.c.
6124
6125 2019-07-17  Tom Tromey  <tom@tromey.com>
6126
6127         * tui/tui-win.c (tui_resize_all)
6128         (tui_source_window_base::update_tab_width)
6129         (tui_adjust_win_heights): Update.
6130         (tui_win_info::make_invisible_and_set_new_height): Rename from
6131         make_invisible_and_set_new_height.
6132         * tui/tui-data.h (struct tui_win_info)
6133         <make_invisible_and_set_new_height>: New method.
6134
6135 2019-07-17  Tom Tromey  <tom@tromey.com>
6136
6137         * tui/tui.c: Update.
6138         * tui/tui-source.h (struct tui_source_window): Move from
6139         tui-data.h.
6140         * tui/tui-layout.c: Update.
6141         * tui/tui-disasm.c: Update.
6142         * tui/tui-data.h (struct tui_source_window): Move to
6143         tui-source.h.
6144
6145 2019-07-17  Tom Tromey  <tom@tromey.com>
6146
6147         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6148         tui-data.h.
6149         * tui/tui-data.h (struct tui_disasm_window): Move to
6150         tui-disasm.h.
6151
6152 2019-07-17  Tom Tromey  <tom@tromey.com>
6153
6154         * tui/tui-regs.h (struct tui_data_item_window): Move from
6155         tui-data.h.
6156         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6157         * tui/tui-data.h (struct tui_data_item_window): Move to
6158         tui-regs.h.
6159         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6160
6161 2019-07-17  Tom Tromey  <tom@tromey.com>
6162
6163         * tui/tui.c: Update.
6164         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6165         (tui_cmd_window::max_height): Move to tui-command.c.
6166         * tui/tui-layout.c: Update.
6167         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6168         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6169         tui-command.c.
6170         * tui/tui-command.h (struct tui_cmd_window): Move from
6171         tui-data.h.
6172         * tui/tui-command.c: Remove "structuring" comments.
6173         (tui_cmd_window::clear_detail)
6174         (tui_cmd_window::do_make_visible_with_new_height)
6175         (tui_cmd_window::max_height): Move from elsewhere.
6176
6177 2019-07-17  Tom Tromey  <tom@tromey.com>
6178
6179         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6180         Now static.
6181         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6182         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6183
6184 2019-07-17  Tom Tromey  <tom@tromey.com>
6185
6186         * tui/tui.c: Update.
6187         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6188         tui-regs.c.
6189         * tui/tui-windata.h: Remove file.
6190         * tui/tui-windata.c: Remove file.
6191         * tui/tui-win.c (tui_data_window::set_new_height)
6192         (tui_data_window::do_make_visible_with_new_height): Move to
6193         tui-regs.c.
6194         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6195         * tui/tui-regs.c: Remove "structuring" comments.
6196         (tui_data_window::first_data_item_displayed)
6197         (tui_data_window::delete_data_content_windows)
6198         (tui_data_window::erase_data_content)
6199         (tui_data_window::display_all_data)
6200         (tui_data_window::refresh_all)
6201         (tui_data_window::do_scroll_vertical)
6202         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6203         (tui_data_window::do_make_visible_with_new_height)
6204         (tui_data_window::refresh_window): Move from elsewhere.
6205         (_initialize_tui_regs): Move to end of file.
6206         * tui/tui-layout.c: Update.
6207         * tui/tui-hooks.c: Update.
6208         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6209         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6210         tui-regs.c.
6211         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6212
6213 2019-07-17  Tom Tromey  <tom@tromey.com>
6214
6215         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6216         seen.
6217
6218 2019-07-17  Tom Tromey  <tom@tromey.com>
6219
6220         * tui/tui-win.c (tui_source_window_base::set_new_height)
6221         (tui_source_window_base::do_make_visible_with_new_height): Use
6222         m_has_locator field directly.
6223         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6224         method.
6225         (struct tui_source_window_base) <has_locator>: Likewise.
6226
6227 2019-07-17  Tom Tromey  <tom@tromey.com>
6228
6229         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6230         Don't declare.
6231         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6232         Remove.
6233         * tui/tui-win.c (tui_source_window_base::set_new_height)
6234         (tui_source_window_base::set_new_height)
6235         (make_invisible_and_set_new_height)
6236         (tui_source_window_base::do_make_visible_with_new_height)
6237         (tui_source_window_base::do_make_visible_with_new_height):
6238         Update.
6239         * tui/tui-layout.c (show_source_disasm_command, show_data)
6240         (show_source_or_disasm_and_command): Update.
6241         * tui/tui-layout.c (show_layout): Update.
6242
6243 2019-07-17  Tom Tromey  <tom@tromey.com>
6244
6245         * tui/tui-layout.c (make_data_window): Remove.
6246         (show_data): Unify creation and re-initialization cases.
6247
6248 2019-07-17  Tom Tromey  <tom@tromey.com>
6249
6250         * tui/tui-layout.c (make_source_window, make_disasm_window):
6251         Remove.
6252         (show_data): Unify creation and re-initialization cases.
6253
6254 2019-07-17  Tom Tromey  <tom@tromey.com>
6255
6256         * tui/tui-layout.c (make_command_window): Remove.
6257         (show_source_disasm_command, show_source_or_disasm_and_command):
6258         Unify creation and re-initialization cases.
6259
6260 2019-07-17  Tom Tromey  <tom@tromey.com>
6261
6262         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6263         creation and re-initialization cases.
6264
6265 2019-07-17  Tom Tromey  <tom@tromey.com>
6266
6267         * tui/tui-regs.c (tui_get_register): Return void.
6268
6269 2019-07-17  Tom Tromey  <tom@tromey.com>
6270
6271         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6272         Simplify.
6273
6274 2019-07-17  Tom Tromey  <tom@tromey.com>
6275
6276         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6277         resetting.
6278
6279 2019-07-17  Tom Tromey  <tom@tromey.com>
6280
6281         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6282         * tui/tui-regs.c (tui_reg_layout): New function.
6283         (tui_show_registers, tui_reg_command): Use it.
6284         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6285         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6286         parameters.
6287         (tui_layout_command): Remove.
6288
6289 2019-07-17  Tom Tromey  <tom@tromey.com>
6290
6291         * tui/tui-layout.h (tui/tui-layout): Return void.
6292         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6293
6294 2019-07-17  Tom Tromey  <tom@tromey.com>
6295
6296         * tui/tui-layout.c (show_source_disasm_command, show_data):
6297         Update.
6298         (reset_locator): Remove.
6299         (show_source_or_disasm_and_command): Update.
6300
6301 2019-07-17  Tom Tromey  <tom@tromey.com>
6302
6303         * tui/tui-source.c (tui_source_window_base::reset): Remove
6304         win_type parameter.
6305         * tui/tui-layout.c (make_command_window, make_source_window)
6306         (make_disasm_window, make_data_window)
6307         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6308         (reset_locator, show_source_or_disasm_and_command): Update.
6309         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6310         win_type parameter.
6311         (struct tui_source_window_base) <reset>: Likewise.
6312
6313 2019-07-17  Tom Tromey  <tom@tromey.com>
6314
6315         * tui/tui-layout.c (show_source_disasm_command): Use
6316         reset_locator.
6317         (reset_locator): New function.
6318         (init_and_make_win): Remove.
6319         (show_source_or_disasm_and_command): Use reset_locator.
6320
6321 2019-07-17  Tom Tromey  <tom@tromey.com>
6322
6323         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6324         condition.
6325         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6326         Remove condition.
6327         * tui/tui-source.c (tui_source_window_base::reset): New method.
6328         * tui/tui-layout.c (make_command_window): Don't call
6329         init_and_make_win.
6330         (make_source_window, make_disasm_window): Don't call
6331         make_source_or_disasm_window.
6332         (make_data_window): Don't call init_and_make_win.  Change calling
6333         convention.
6334         (show_source_disasm_command, show_data): Simplify.
6335         (make_source_or_disasm_window): Remove.
6336         (show_source_or_disasm_and_command): Simplify.
6337         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6338         (struct tui_source_window_base) <reset>: Likewise.
6339         <execution_info>: Remove initializer.
6340         * tui/tui-data.c (tui_source_window_base): Initialize
6341         execution_info.
6342
6343 2019-07-17  Tom Tromey  <tom@tromey.com>
6344
6345         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6346         variable.
6347
6348 2019-07-17  Tom Tromey  <tom@tromey.com>
6349
6350         * tui/tui.c (tui_rl_other_window): Update.
6351         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6352         superclass method first.  Always iterate over regs_content.
6353         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6354         method.
6355         * tui/tui-win.c (tui_set_focus_command): Update.
6356
6357 2019-07-17  Tom Tromey  <tom@tromey.com>
6358
6359         * tui/tui-win.c (tui_set_focus_command): Rename from
6360         tui_set_focus.  Call tui_enable.
6361         (tui_set_focus_command): Remove.
6362
6363 2019-07-17  Tom Tromey  <tom@tromey.com>
6364
6365         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6366         refresh_window.
6367         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6368         touchwin.
6369         (tui_data_window::refresh_window): Call refresh_window on data
6370         items.  Always call superclass refresh_window.
6371         (tui_win_info::refresh): Remove.
6372         (tui_source_window_base::refresh_window): Update.
6373         (tui_refresh_all): Update.
6374         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6375         refresh_window.
6376         (show_source_or_disasm_and_command): Likewise.
6377         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6378         (struct tui_source_window_base) <refresh>: Likewise.
6379
6380 2019-07-17  Tom Tromey  <tom@tromey.com>
6381
6382         * tui/tui-winsource.c (tui_clear_source_content)
6383         (tui_show_source_content): Update.
6384         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6385         whether content is empty.
6386         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6387         Remove.
6388
6389 2019-07-17  Tom Tromey  <tom@tromey.com>
6390
6391         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6392         window's contents.
6393         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6394         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6395
6396 2019-07-17  Tom Tromey  <tom@tromey.com>
6397
6398         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6399         (struct tui_data_item_window): Update.
6400
6401 2019-07-17  Tom Tromey  <tom@tromey.com>
6402
6403         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6404         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6405         defines.
6406
6407 2019-07-17  Tom Tromey  <tom@tromey.com>
6408
6409         * tui/tui-winsource.h (tui_erase_source_content)
6410         (tui_clear_source_content): Remove "display_prompt" parameter.
6411         * tui/tui-winsource.c (tui_update_source_window_as_is)
6412         (tui_update_source_windows_with_addr): Update.
6413         (tui_clear_source_content): Remove "display_prompt" parameter.
6414         (tui_erase_source_content): Likewise.  Simplify.
6415         (tui_show_source_content): Update.
6416         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6417         * tui/tui-stack.c (tui_show_frame_info): Update.
6418         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6419         Remove defines.
6420
6421 2019-07-17  Tom Tromey  <tom@tromey.com>
6422
6423         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6424         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6425         parameter.
6426         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6427         parameter.
6428
6429 2019-07-17  Tom Tromey  <tom@tromey.com>
6430
6431         * tui/tui-winsource.c (tui_clear_source_content)
6432         (tui_show_source_content, tui_show_exec_info_content)
6433         (tui_clear_exec_info_content): Update.
6434         * tui/tui-stack.c (tui_show_locator_content): Update.
6435         (tui_show_frame_info): Update.
6436         * tui/tui-source.h (tui_source_window): Don't declare.
6437         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6438         from tui_source_is_displayed.
6439         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6440         Remove field.
6441         (struct tui_source_window_base) <content_in_use>: New field.  Now
6442         bool.
6443         (struct tui_source_window) <showing_source_p>: New method.
6444         (TUI_SRC_WIN): Change cast.
6445         * tui/tui-data.c (tui_initialize_static_data): Update.
6446
6447 2019-07-17  Tom Tromey  <tom@tromey.com>
6448
6449         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6450         location_matches_p.
6451         * tui/tui-source.c (tui_source_window::location_matches_p): New
6452         method.
6453         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6454         method.
6455         * tui/tui-data.h (struct tui_source_window_base)
6456         <location_matches_p>: New method.
6457         (struct tui_source_window, struct tui_disasm_window)
6458         <location_matches_p>: Likewise.
6459
6460 2019-07-17  Tom Tromey  <tom@tromey.com>
6461
6462         * tui/tui-win.c (tui_set_win_height_command): Rename from
6463         tui_set_win_height.
6464         (tui_set_win_height_command): Remove.
6465
6466 2019-07-17  Tom Tromey  <tom@tromey.com>
6467
6468         * tui/tui-source.c (tui_source_window): New constructor.  Add
6469         observer.
6470         (~tui_source_window): New destructor.
6471         (tui_source_window::style_changed): New method.
6472         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6473         (tui_attach_detach_observers): Update.
6474         * tui/tui-data.h (struct tui_source_window): Make constructor not
6475         inline.  Add destructor.
6476         (struct tui_source_window) <style_changed>: New method.
6477         <m_observable>: New member.
6478
6479 2019-07-17  Tom Tromey  <tom@tromey.com>
6480
6481         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6482         * tui/tui-win.c (tui_resize_all): Fix typo.
6483
6484 2019-07-17  Tom Tromey  <tom@tromey.com>
6485
6486         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6487         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6488         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6489         * tui/tui-win.c (window_name_completer): Use foreach.
6490         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6491         (update_tab_width): Likewise.
6492         * tui/tui-layout.c (show_layout): Update.
6493         * tui/tui-data.h (class tui_window_iterator): New.
6494         (struct all_tui_windows): New.
6495         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6496
6497 2019-07-17  Tom Tromey  <tom@tromey.com>
6498
6499         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6500         parameter.  Don't reference globals.
6501         (tui_reg_command): Update.
6502
6503 2019-07-17  Tom Tromey  <tom@tromey.com>
6504
6505         * tui/tui-regs.c (tui_show_registers): Simplify.
6506
6507 2019-07-17  Tom Tromey  <tom@tromey.com>
6508
6509         * tui/tui-regs.c (tui_show_registers): Update.
6510         (tui_show_register_group): Add win_info parameter.
6511
6512 2019-07-17  Tom Tromey  <tom@tromey.com>
6513
6514         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6515         Rename from tui_display_reg_element_at_line.
6516         (tui_data_window::display_registers_from_line): Update.
6517         * tui/tui-data.h (struct tui_data_window)
6518         <display_reg_element_at_line>: New method.
6519
6520 2019-07-17  Tom Tromey  <tom@tromey.com>
6521
6522         * tui/tui-regs.h (tui_display_registers_from)
6523         (tui_display_registers_from_line): Don't declare.
6524         * tui/tui-windata.c (tui_data_window::display_all_data)
6525         (tui_data_window::refresh_all)
6526         (tui_data_window::do_scroll_vertical): Update.
6527         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6528         from tui_display_registers_from.
6529         (tui_display_reg_element_at_line): Update.
6530         (tui_data_window::display_registers_from_line): Rename from
6531         tui_display_registers_from_line.
6532         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6533         display_registers_from_line>: New methods.
6534
6535 2019-07-17  Tom Tromey  <tom@tromey.com>
6536
6537         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6538         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6539         from tui_erase_data_content.
6540         (tui_data_window::display_all_data)
6541         (tui_data_window::refresh_all)
6542         (tui_data_window::do_scroll_vertical): Update.
6543         * tui/tui-regs.c (tui_show_registers): Update.
6544         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6545         New method.
6546
6547 2019-07-17  Tom Tromey  <tom@tromey.com>
6548
6549         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6550         declare.
6551         * tui/tui-windata.c
6552         (tui_data_window::delete_data_content_windows): Rename from
6553         tui_delete_data_content_windows.
6554         (tui_data_window::display_all_data)
6555         (tui_data_window::do_scroll_vertical): Update.
6556         * tui/tui-data.h (struct tui_data_window)
6557         <delete_data_content_windows>: New method.
6558
6559 2019-07-17  Tom Tromey  <tom@tromey.com>
6560
6561         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6562         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6563
6564 2019-07-17  Tom Tromey  <tom@tromey.com>
6565
6566         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6567         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6568         from tui_display_all_data.
6569         * tui/tui-win.c
6570         (tui_data_window::do_make_visible_with_new_height): Update.
6571         * tui/tui-regs.c (tui_show_registers): Update.
6572         * tui/tui-layout.c (tui_set_layout): Update.
6573         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6574         method.
6575
6576 2019-07-17  Tom Tromey  <tom@tromey.com>
6577
6578         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6579         * tui/tui-windata.c (tui_display_data_from): Remove.
6580         (tui_data_window::refresh_all): Update.
6581
6582 2019-07-17  Tom Tromey  <tom@tromey.com>
6583
6584         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6585         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6586         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6587         tui_display_registers_from_line.
6588         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6589         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6590         "force_display" parameter.
6591
6592 2019-07-17  Tom Tromey  <tom@tromey.com>
6593
6594         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6595         declare.
6596         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6597         Rename from tui_first_reg_element_no_inline.
6598         (tui_display_reg_element_at_line)
6599         (tui_display_registers_from_line): Update.
6600         * tui/tui-data.h (struct tui_data_window)
6601         <first_reg_element_no_inline>: New method.
6602
6603 2019-07-17  Tom Tromey  <tom@tromey.com>
6604
6605         * tui/tui-windata.c (tui_display_data_from)
6606         (tui_data_window::do_scroll_vertical): Update.
6607         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6608         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6609         Rename from tui_line_from_reg_element_no.
6610         (tui_display_registers_from_line): Update.
6611         * tui/tui-data.h (struct tui_data_window)
6612         <line_from_reg_element_no>: New method.
6613
6614 2019-07-17  Tom Tromey  <tom@tromey.com>
6615
6616         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6617         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6618         tui_last_regs_line_no.
6619         (tui_display_reg_element_at_line)
6620         (tui_display_registers_from_line): Update.
6621         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6622         method.
6623
6624 2019-07-17  Tom Tromey  <tom@tromey.com>
6625
6626         PR tui/24722:
6627         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6628         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6629         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6630         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6631         (tui_update_breakpoint_info): Likewise.
6632         * tui/tui-hooks.c (tui_event_create_breakpoint)
6633         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6634         Update.
6635
6636 2019-07-17  Tom Tromey  <tom@tromey.com>
6637
6638         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6639
6640 2019-07-17  Tom Tromey  <tom@tromey.com>
6641
6642         * tui/tui-winsource.c (tui_update_source_window_as_is)
6643         (tui_update_source_windows_with_addr): Update.
6644         * tui/tui-source.h (tui_set_source_content)
6645         (tui_show_symtab_source): Add "win_info" parameter.
6646         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6647         parameter.
6648         (tui_show_symtab_source): Likewise.
6649
6650 2019-07-17  Tom Tromey  <tom@tromey.com>
6651
6652         * tui/tui-wingeneral.c
6653         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6654
6655 2019-07-17  Tom Tromey  <tom@tromey.com>
6656
6657         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6658         (struct tui_cmd_window) <can_scroll>: New method.
6659         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6660         method.
6661
6662 2019-07-17  Tom Tromey  <tromey@adacore.com>
6663
6664         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6665         do_field_signed>: Rename.  Change type of "value".
6666         * ui-out.c (ui_out::field_signed): Rename from field_int.
6667         Change type of "value".
6668         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6669         type of "value".
6670         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6671         do_field_int.  Change type of "value".
6672         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6673         do_field_int.  Change type of "value".
6674         * tracepoint.c (trace_status_mi, tfind_1)
6675         (print_one_static_tracepoint_marker): Update.
6676         * thread.c (print_thread_info_1, print_selected_thread_frame):
6677         Update.
6678         * stack.c (print_frame, print_frame_info): Update.
6679         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6680         Update.
6681         * source.c (print_source_lines_base): Update.
6682         * skip.c (info_skip_command): Update.
6683         * record-btrace.c (btrace_ui_out_decode_error)
6684         (btrace_call_history_src_line): Update.
6685         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6686         Update.
6687         * progspace.c (print_program_space): Update.
6688         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6689         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6690         do_field_int.  Change type of "value".
6691         * mi/mi-out.c (mi_ui_out::do_table_begin)
6692         (mi_ui_out::do_table_header): Update.
6693         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6694         type of "value".
6695         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6696         (mi_cmd_data_list_changed_registers, output_register)
6697         (mi_cmd_data_read_memory, mi_load_progress)
6698         (mi_cmd_trace_frame_collected): Update.
6699         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6700         Update.
6701         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6702         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6703         (mi_cmd_var_list_children, varobj_update_one): Update.
6704         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6705         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6706         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6707         * inferior.c (print_inferior): Update.
6708         * gdb_bfd.c (print_one_bfd): Update.
6709         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6710         Update.
6711         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6712         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6713         do_field_int.  Change type of "value".
6714         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6715         do_field_int.  Change type of "value".
6716         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6717         (print_one_breakpoint_location, print_it_catch_fork)
6718         (print_one_catch_fork, print_it_catch_vfork)
6719         (print_one_catch_vfork, print_it_catch_solib)
6720         (print_it_catch_exec, print_it_ranged_breakpoint)
6721         (print_mention_watchpoint, print_mention_masked_watchpoint)
6722         (bkpt_print_it, update_static_tracepoint): Update.
6723         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6724         * break-catch-syscall.c (print_it_catch_syscall): Update.
6725         * ada-tasks.c (print_ada_task_info): Update.
6726         * ada-lang.c (print_it_exception, print_mention_exception):
6727         Update.
6728
6729 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6730
6731         PR breakpoints/24541
6732         * gdbarch.c: Regenerate.
6733         * gdbarch.h: Regenerate.
6734         * gdbarch.sh: Adjust return type and parameter types for
6735         'stap_adjust_register'.
6736         (i386_stap_adjust_register): Adjust signature and return new
6737         register name.
6738         * stap-probe.c (stap_parse_register_operand): Adjust use of
6739         'gdbarch_stap_adjust_register'.
6740
6741 2019-07-17  Tom Tromey  <tromey@adacore.com>
6742
6743         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6744         declare VEC.
6745         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6746         std::vector.
6747         (struct s390_process_info): Add initializers.
6748         (s390_add_process): Use new.
6749         (s390_linux_nat_target::low_forget_process): Use delete.
6750         (s390_linux_nat_target::low_new_fork)
6751         (s390_linux_nat_target::stopped_by_watchpoint)
6752         (s390_linux_nat_target::low_prepare_to_resume)
6753         (s390_linux_nat_target::insert_watchpoint)
6754         (s390_linux_nat_target::insert_hw_breakpoint)
6755         (s390_linux_nat_target::remove_watchpoint)
6756         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6757
6758 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6759
6760         * aarch64-fbsd-nat.c: Include regcache.h.
6761         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6762         argument.
6763         (aarch64_fbsd_nat_target::fetch_registers)
6764         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6765         variable.
6766         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6767
6768 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6769
6770         * fbsd-nat.c: Include gdbarch.h.
6771
6772 2019-07-15  Tom Tromey  <tromey@adacore.com>
6773
6774         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6775
6776 2019-07-15  Tom Tromey  <tromey@adacore.com>
6777
6778         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6779         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6780         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6781         * cli-out.c (cli_ui_out::do_field_int): New method.
6782         * ui-out.c (ui_out::field_unsigned): New method.
6783         * symfile.c (generic_load): Use field_unsigned.
6784         (print_transfer_performance): Likewise.
6785         * record-btrace.c (ui_out_field_uint): Remove.
6786         (btrace_call_history_insn_range, btrace_call_history): Use
6787         field_unsigned.
6788         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6789         field_unsigned.
6790         * ui-out.h (class ui_out) <field_unsigned>: New method.
6791         <do_field_unsigned>: Likewise.
6792
6793 2019-07-15  Tom Tromey  <tromey@adacore.com>
6794
6795         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6796         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6797         * target.c (flash_erase_command): Use field_string.
6798         * infrun.c (print_signal_received_reason): Use field_string.
6799         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6800         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6801         field_string.
6802         * ada-tasks.c (print_ada_task_info): Use field_string.
6803
6804 2019-07-15  Tom Tromey  <tromey@adacore.com>
6805
6806         * target.c (flash_erase_command): Use field_core_addr.
6807         * symfile.c (generic_load): Use field_core_addr.
6808         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6809         Use field_core_addr.
6810         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6811         field_core_addr.
6812
6813 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6814
6815         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6816         value if its desired type is smaller than a CORE_ADDR and signed.
6817
6818 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6819
6820         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6821         of changes to field names, and use new is_reference field to
6822         decide if a property is a reference or not.
6823         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6824         field.
6825         (struct dwarf2_property_baton): Update header comment, rename
6826         'referenced_type' to 'property_type' and update comments.
6827         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6828         default property type, store in property baton, update to take
6829         accound of renamed field.
6830         (read_func_scope): Update call to attr_to_dynamic_prop.
6831         (read_array_type): Likewise.
6832         (dwarf2_per_cu_addr_sized_int_type): New function.
6833         (read_subrange_index_type): Move type finding code to
6834         dwarf2_per_cu_addr_sized_int_type.
6835         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6836         (dwarf2_per_cu_addr_type): New function.
6837         (set_die_type): Update calls to attr_to_dynamic_prop.
6838
6839 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6840
6841         * dwarf2read.c (read_subrange_index_type): New function.
6842         (read_subrange_type): Move code into new function and call it.
6843         * gdbtypes.c (create_range_type): Add some asserts.
6844
6845 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6846
6847         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6848         update return statements.
6849         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6850         declaration, and update comment to match.
6851         * gdbtypes.c (resolve_dynamic_array): Update call to
6852         dwarf2_evaluate_property to match new return type.
6853
6854 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6855
6856         * valarith.c (value_subscripted_rvalue): Change lowerbound
6857         parameter type from int to LONGEST.
6858         * value.h (value_subscripted_rvalue): Likewise in declaration.
6859
6860 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6861
6862         * cli/cli-utils.c (info_print_command_completer): New function.
6863         * cli/cli-utils.h: Add 'completer.h' include, and forward
6864         declaration for 'struct cmd_list_element'.
6865         (info_print_command_completer): Declare.
6866         * stack.c (_initialize_stack): Add completer for 'info locals' and
6867         'info args'.
6868         * symtab.c (_initialize_symtab): Add completer for 'info
6869         variables' and 'info functions'.
6870         * NEWS: Mention completion for additional info commands.
6871
6872 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6873
6874         * cli/cli-utils.c (extract_info_print_args): Delete.
6875         (extract_arg_maybe_quoted): Delete.
6876         (info_print_options_defs): New variable.
6877         (make_info_print_options_def_group): New function.
6878         (extract_info_print_options): Define new function.
6879         * cli/cli-utils.h (extract_info_print_args): Delete.
6880         (struct info_print_options): New structure.
6881         (extract_info_print_options): Declare new function.
6882         * stack.c (info_locals_command): Update to use new
6883         extract_info_print_options, also add a header comment.
6884         (info_args_command): Likewise.
6885         * symtab.c (info_variables_command): Likewise.
6886         (info_functions_command): Likewise.
6887
6888 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6889
6890         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6891         to extract string arguments.
6892         * common/common-utils.c (extract_string_maybe_quoted): New function.
6893         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6894
6895 2019-07-11  Tom Tromey  <tromey@adacore.com>
6896
6897         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6898         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6899         * top.h (gdbinit): Don't declare.
6900         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6901         into...
6902         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6903         * top.c (gdb_init): Don't call init_cli_cmds.
6904         (gdbinit): Remove.
6905         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6906
6907 2019-07-11  Tom Tromey  <tromey@adacore.com>
6908
6909         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6910         after it has been moved.
6911
6912 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6913
6914         * valops.c (value_must_coerce_to_target): Change return type to
6915         bool.
6916         * value.h (value_must_coerce_to_target): Likewise.
6917
6918 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6919
6920         * breakpoint.c (is_hardware_watchpoint): Remove
6921         forward-declaration.
6922         (is_masked_watchpoint): Change return type to bool.
6923         (is_tracepoint): Likewise.
6924         (is_breakpoint): Likewise.
6925         (is_hardware_watchpoint): Likewise.
6926         (is_watchpoint): Likewise.
6927         (is_no_memory_software_watchpoint): Likewise.
6928         (is_catchpoint): Likewise.
6929         (breakpoint_1): Make FILTER parameter's return type bool.
6930         is_masked_watchpoint): Change return type to bool.
6931         (save_breakpoints): Make FILTER parameter's return type bool.
6932         * breakpoint.h (is_breakpoint): Change return type to bool.
6933         (is_watchpoint): Likewise.
6934         (is_catchpoint): Likewise.
6935         (is_tracepoint): Likewise.
6936
6937 2019-07-10  Tom Tromey  <tom@tromey.com>
6938
6939         * defs.h: Don't include gdbarch.h.
6940         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6941         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6942         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6943         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6944         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6945         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6946         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6947         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6948         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6949         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6950         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6951         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6952         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6953         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6954         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6955         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6956         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6957         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6958         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6959         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6960         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6961         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6962         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6963         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6964         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6965         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6966         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6967
6968 2019-07-10  Tom Tromey  <tromey@adacore.com>
6969
6970         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6971         * breakpoint.c (init_ada_exception_breakpoint): Register as
6972         bp_catchpoint.
6973         (print_one_breakpoint_location, print_one_breakpoint): Use
6974         is_ada_exception_catchpoint.
6975         * ada-lang.c (class ada_catchpoint_location): Pass
6976         bp_loc_software_breakpoint to bp_location constructor.
6977         (is_ada_exception_catchpoint): New function.
6978
6979 2019-07-10  Tom Tromey  <tromey@adacore.com>
6980
6981         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6982         VEC.
6983         (struct arm_exidx_entry): New method operator<.
6984         (struct arm_exidx_data) <section_maps>: Change type.
6985         (arm_exidx_data_free): Remove.
6986         (arm_exidx_data_key): Change type.  Move lower.
6987         (arm_exidx_new_objfile): Update.
6988         (arm_compare_exidx_entries): Remove.
6989         (arm_find_exidx_entry, _initialize_arm_tdep)
6990
6991 2019-07-10  Tom Tromey  <tromey@adacore.com>
6992
6993         * solib-spu.c (ocl_program_data_key): Change type.
6994         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6995         Update.
6996
6997 2019-07-10  Tom Tromey  <tromey@adacore.com>
6998
6999         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7000         (struct solib_aix_inferior_data) <library_list>: Change type.
7001         (solib_aix_inferior_data_handle): Change type.
7002         (get_solib_aix_inferior_data): Update.
7003         (solib_aix_free_library_list): Remove.
7004         (library_list_start_library): Update.
7005         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7006         return type.
7007         (solib_aix_get_library_list)
7008         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7009         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7010
7011 2019-07-10  Tom Tromey  <tromey@adacore.com>
7012
7013         * solib-dsbt.c (struct dsbt_info): Add initializers.
7014         (solib_dsbt_pspace_data): Change type.
7015         (dsbt_pspace_data_cleanup): Remove.
7016         (get_dsbt_info, _initialize_dsbt_solib): Update.
7017
7018 2019-07-10  Tom Tromey  <tromey@adacore.com>
7019
7020         * spu-tdep.c (spu_overlay_data): Change type.
7021         (spu_get_overlay_table, spu_overlay_new_objfile)
7022         (_initialize_spu_tdep): Update.
7023
7024 2019-07-10  Tom Tromey  <tromey@adacore.com>
7025
7026         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7027         destructor.
7028         (dbx_objfile_data_key): Change type and declare later.
7029         (DBX_SYMFILE_INFO): Rewrite.
7030         * dbxread.c (dbx_objfile_data_key): Change type.
7031         (dbx_symfile_init): Update.
7032         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7033         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7034         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7035
7036 2019-07-10  Tom Tromey  <tromey@adacore.com>
7037
7038         * jit.c (jit_program_space_key): Change type.  Move lower.
7039         (get_jit_program_space_data): Update.
7040         (jit_program_space_data_cleanup): Remove.
7041         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7042         Update.
7043         (struct jit_program_space_data): Add initializers.
7044
7045 2019-07-10  Tom Tromey  <tromey@adacore.com>
7046
7047         * solib-darwin.c (struct darwin_info): Add initializers.
7048         (solib_darwin_pspace_data): Change type.
7049         (darwin_pspace_data_cleanup): Remove.
7050         (get_darwin_info, _initialize_darwin_solib): Update.
7051
7052 2019-07-10  Tom Tromey  <tromey@adacore.com>
7053
7054         * remote-sim.c (struct sim_inferior_data): Add initializers,
7055         constructor, and destructor.
7056         (sim_inferior_data_key): Change type.  Move lower.
7057         (check_for_duplicate_sim_descriptor): Update.
7058         (get_sim_inferior_data): Use new.  Update.
7059         (~sim_inferior_data_cleanup): Rename from
7060         sim_inferior_data_cleanup.  Simplify.
7061         (gdbsim_close_inferior, simulator_command)
7062         (sim_command_completer, _initialize_remote_sim): Update.
7063         (next_pid, INITIAL_PID): Move earlier.
7064
7065 2019-07-10  Tom Tromey  <tromey@adacore.com>
7066
7067         * python/python-internal.h (create_thread_object): Return
7068         gdbpy_ref.
7069         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7070         * python/py-inferior.c (struct threadlist_entry): Add
7071         constructor.
7072         <thread_obj>: Now a gdbpy_ref.
7073         (thread_to_thread_object): Update.
7074         (add_thread_object): Use new.
7075         (delete_thread_object): Use delete.
7076         (infpy_threads): Update.
7077         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7078         GIL.
7079
7080 2019-07-10  Tom Tromey  <tromey@adacore.com>
7081
7082         * valops.c (value_cast): Specialize error message for Ada.
7083
7084 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7085
7086         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7087
7088 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7089
7090         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7091         bpstat_should_step): Return bool, adjust comments.
7092         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7093         bpstat_should_step): Likewise.
7094
7095 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7096
7097         * features/Makefile: Use feature target descriptions for Arm.
7098         * features/arm/arm-core.c: Generate new file.
7099         * features/arm/arm-fpa.c: Likewise.
7100         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7101         * features/arm/arm-m-profile.c: Likewise.
7102         * features/arm/arm-vfpv2.c: Likewise.
7103         * features/arm/arm-vfpv3.c: Likewise.
7104         * features/arm/xscale-iwmmxt.c: Likewise.
7105         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7106
7107 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7108
7109         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7110         ptrace earlier.
7111
7112 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7113
7114         * features/aarch64-pauth.c: Regenerate.
7115
7116 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7117
7118         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7119         bool.
7120         (bpstat_what): Use false instead of 0.
7121
7122 2019-07-09  Pedro Alves  <palves@redhat.com>
7123
7124         * break-catch-throw.c (is_exception_catchpoint): New.
7125         * breakpoint.c (print_one_breakpoint_location): New parameter
7126         'raw_loc'.  Handle it.  Use
7127         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7128         looking at the breakpoint's type.
7129         (print_one_breakpoint): If handling "maint info breakpoints", also
7130         print locations of exception catchpoints.
7131         * breakpoint.h (is_exception_catchpoint): Declare.
7132
7133 2019-07-09  Pedro Alves  <palves@redhat.com>
7134
7135         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7136         "addr" field.
7137         (allocate_location_exception_catchpoint): New.
7138         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7139         (initialize_throw_catchpoint_ops): Install
7140         allocate_location_exception_catchpoint as allocate_location
7141         method.
7142         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7143         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7144         bp_loc_other.
7145         (breakpoint_address_is_meaningful): Delete.
7146         (bl_address_is_meaningful): New.
7147         (breakpoint_locations_match): Adjust comment.
7148         (bp_location_from_bp_type): New, factored out of...
7149         (bp_location::bp_location(breakpoint *)): ... this.
7150         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7151         factored out of...
7152         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7153         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7154         breakpoint_address_is_meaningful.
7155         (bp_locations_compare): Adjust comment.
7156         (update_global_location_list): Use bl_address_is_meaningful
7157         instead of breakpoint_address_is_meaningful.
7158         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7159         explicit.
7160         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7161         * python/py-breakpoint.c (bppy_get_location): No longer check
7162         whether location is null.
7163
7164 2019-07-09  Pedro Alves  <palves@redhat.com>
7165
7166         PR c++/15468
7167         * breakpoint.c (print_one_breakpoint_location): Remove
7168         single-location assert.
7169
7170 2019-07-09  Tom Tromey  <tom@tromey.com>
7171
7172         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7173         * configure: Rebuild.
7174         * configure.ac: Change common to gdbsupport.
7175         * gdbsupport: Rename from common.
7176         * acinclude.m4: Change common to gdbsupport.
7177         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7178         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7179         gdbsupport.
7180         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7181         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7182         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7183         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7184         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7185         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7186         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7187         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7188         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7189         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7190         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7191         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7192         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7193         coff-pe-read.c, command.h, compile/compile-c-support.c,
7194         compile/compile-c.h, compile/compile-cplus-symbols.c,
7195         compile/compile-cplus-types.c, compile/compile-cplus.h,
7196         compile/compile-loc2c.c, compile/compile.c, completer.c,
7197         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7198         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7199         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7200         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7201         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7202         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7203         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7204         features/aarch64-core.c, features/aarch64-fpu.c,
7205         features/aarch64-pauth.c, features/aarch64-sve.c,
7206         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7207         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7208         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7209         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7210         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7211         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7212         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7213         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7214         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7215         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7216         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7217         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7218         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7219         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7220         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7221         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7222         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7223         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7224         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7225         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7226         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7227         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7228         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7229         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7230         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7231         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7232         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7233         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7234         minsyms.c, mips-linux-tdep.c, namespace.h,
7235         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7236         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7237         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7238         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7239         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7240         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7241         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7242         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7243         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7244         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7245         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7246         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7247         procfs.c, producer.c, progspace.h, psymtab.h,
7248         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7249         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7250         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7251         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7252         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7253         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7254         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7255         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7256         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7257         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7258         target-memory.c, target.c, target.h, target/waitstatus.c,
7259         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7260         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7261         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7262         unittests/array-view-selftests.c,
7263         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7264         unittests/common-utils-selftests.c,
7265         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7266         unittests/format_pieces-selftests.c,
7267         unittests/function-view-selftests.c,
7268         unittests/lookup_name_info-selftests.c,
7269         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7270         unittests/mkdir-recursive-selftests.c,
7271         unittests/observable-selftests.c,
7272         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7273         unittests/parse-connection-spec-selftests.c,
7274         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7275         unittests/scoped_fd-selftests.c,
7276         unittests/scoped_mmap-selftests.c,
7277         unittests/scoped_restore-selftests.c,
7278         unittests/string_view-selftests.c, unittests/style-selftests.c,
7279         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7280         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7281         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7282         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7283         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7284         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7285
7286 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7287
7288         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7289         bool value.
7290         (decode_digits_ordinary): Set explicit_line field in sal.
7291         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7292         symtab_and_line that was set on an explicit line number in
7293         assembler code.  Do always update the recorded symtab and line if
7294         we do skip the prologue.
7295
7296 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7297
7298         * breakpoint.c (set_breakpoint_location_function): Remove
7299         explicit_loc parameter.
7300         (momentary_breakpoint_from_master): Update call to
7301         set_breakpoint_location_function.
7302         (add_location_to_breakpoint): Likewise.
7303
7304 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7305
7306         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7307         required features based on default bfd type when no specific bfd
7308         is present.
7309
7310 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7311
7312         * NEWS: Mention that GDB printf and eval commands can now print
7313         C-style and Ada-style convenience var strings without
7314         calling the inferior.
7315         * printcmd.c (printf_c_string): Locally print GDB internal var
7316         instead of transiting via the inferior.
7317         (printf_wide_c_string): Likewise.
7318
7319 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7320
7321         PR breakpoints/25011
7322         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7323
7324 2019-07-04  Tom Tromey  <tom@tromey.com>
7325
7326         PR tui/24724:
7327         * tui/tui-winsource.c (tui_clear_source_content): Update.
7328         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7329         (tui_update_breakpoint_info): Update.
7330         (tui_set_exec_info_content): Update.
7331         * tui/tui-source.c (tui_set_source_content_nil): Update.
7332         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7333         has_break.
7334         * tui/tui-data.h (enum tui_bp_flag): New.
7335         (tui_bp_flags): New enum flags type.
7336         (struct tui_source_element) <break_mode>: Change type.  Rename
7337         from has_break.
7338         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7339         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7340         constants.
7341         * tui/tui-winsource.h: Fix comment.
7342
7343 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7344
7345         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7346         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7347         (store_fpregs_to_thread)
7348         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7349         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7350         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7351         (IWMMXT_REGS_SIZE): Add define.
7352         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7353         (fetch_vfp_regs, store_vfp_regs)
7354         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7355         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7356
7357 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7358
7359         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7360         defines.
7361         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7362         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7363         (ARM_INT_REGISTER_SIZE): ...to this.
7364         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7365         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7366         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7367         (arm_linux_collect_gregset, supply_nwfpe_register)
7368         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7369         defines.
7370         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7371         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7372         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7373         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7374         (arm_return_in_memory, arm_store_return_value)
7375         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7376         (arm_record_ld_st_multiple): Likewise.
7377         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7378         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7379
7380 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7381
7382         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7383         AARCH64_DISPLACED_MODIFIED_INSNS.
7384         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7385         (aarch64_displaced_step_copy_insn): Likewise.
7386         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7387         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7388         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7389         ARM_DISPLACED_MODIFIED_INSNS.
7390         * arm-tdep.c (arm_gdbarch_init): Likewise.
7391         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7392         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7393         (struct arm_displaced_step_closure): Use
7394         ARM_DISPLACED_MODIFIED_INSNS.
7395
7396 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7397
7398         * features/Makefile: Remove unused xml files.
7399         * features/aarch64.xml: Remove.
7400         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7401         * features/i386/amd64-avx-avx512.xml: Remove.
7402         * features/i386/amd64-avx-linux.xml: Remove.
7403         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7404         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7405         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7406         * features/i386/amd64-avx-mpx.xml: Remove.
7407         * features/i386/amd64-avx.xml: Remove.
7408         * features/i386/amd64-linux.xml: Remove.
7409         * features/i386/amd64-mpx-linux.xml: Remove.
7410         * features/i386/amd64-mpx.xml: Remove.
7411         * features/i386/amd64.xml: Remove.
7412         * features/i386/i386-avx-avx512-linux.xml: Remove.
7413         * features/i386/i386-avx-avx512.xml: Remove.
7414         * features/i386/i386-avx-linux.xml: Remove.
7415         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7416         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7417         * features/i386/i386-avx-mpx-linux.xml: Remove.
7418         * features/i386/i386-avx-mpx.xml: Remove.
7419         * features/i386/i386-avx.xml: Remove.
7420         * features/i386/i386-linux.xml: Remove.
7421         * features/i386/i386-mmx-linux.xml: Remove.
7422         * features/i386/i386-mmx.xml: Remove.
7423         * features/i386/i386-mpx-linux.xml: Remove.
7424         * features/i386/i386-mpx.xml: Remove.
7425         * features/i386/i386.xml: Remove.
7426         * features/i386/x32-avx-avx512-linux.xml: Remove.
7427         * features/i386/x32-avx-linux.xml: Remove.
7428         * features/i386/x32-linux.xml: Remove.
7429
7430 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7431
7432         * regformats/aarch64.dat: Remove.
7433         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7434         * regformats/i386/amd64-avx-linux.dat: Remove.
7435         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7436         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7437         * regformats/i386/amd64-linux.dat: Remove.
7438         * regformats/i386/amd64-mpx-linux.dat: Remove.
7439         * regformats/i386/amd64.dat: Remove.
7440         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7441         * regformats/i386/i386-avx-linux.dat: Remove.
7442         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7443         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7444         * regformats/i386/i386-linux.dat: Remove.
7445         * regformats/i386/i386-mmx-linux.dat: Remove.
7446         * regformats/i386/i386-mpx-linux.dat: Remove.
7447         * regformats/i386/i386.dat: Remove.
7448         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7449         * regformats/i386/x32-avx-linux.dat: Remove.
7450         * regformats/i386/x32-linux.dat: Remove.
7451
7452 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7453
7454         * aarch64-tdep.c: Remove xml self tests.
7455         * amd64-linux-tdep.c: Likewise.
7456         * amd64-tdep.c: Likewise.
7457         * i386-linux-tdep.c: Likewise.
7458         * i386-tdep.c: Likewise.
7459
7460 2019-07-03  Pedro Alves  <palves@redhat.com>
7461
7462         PR cli/24732
7463         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7464         (pipe_cmd_option_defs): New.
7465         (make_pipe_cmd_options_def_group): New.
7466         (pipe_command): Use gdb::option::process_options.
7467         (pipe_command_completer): New function.
7468         (_initialize_cli_cmds): Install completer for "pipe" command.
7469
7470 2019-07-03  Pedro Alves  <palves@redhat.com>
7471
7472         * cli/cli-option.c (union option_value) <string>: New field.
7473         (struct option_def_and_value): Add ctor, move ctor, dtor and
7474         use DISABLE_COPY_AND_ASSIGN.
7475         (option_def_and_value::clear_value): New.
7476         (parse_option, save_option_value_in_ctx, get_val_type_str)
7477         (add_setshow_cmds_for_options): Handle var_string.
7478         * cli-option.h (union option_def::var_address) <string>: New
7479         field.
7480         (struct string_option_def): New.
7481         * maint-test-options.c (struct test_options_opts): Add default
7482         ctor and use DISABLE_COPY_AND_ASSIGN.
7483         <string_opt>: New field.
7484         (test_options_opts::~test_options_opts): New.
7485         (test_options_opts::dump): Also dump "-string".
7486         (test_options_option_defs): Install "string.
7487
7488 2019-07-03  Pedro Alves  <palves@redhat.com>
7489
7490         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7491         option_value with a null enumeration.
7492         (complete_options): Save the option values in the context.
7493         (save_option_value_in_ctx): New, factored out from ...
7494         (process_options): ... here.
7495         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7496         of the function.
7497         * maint-test-options.c (test_options_opts::dump): New, factored
7498         out from ...
7499         (maintenance_test_options_command_mode): ... here.
7500         (maintenance_test_options_command_completion_result): Delete.
7501         (maintenance_test_options_command_completion_text): Update
7502         comment.
7503         (maintenance_show_test_options_completion_result): Change
7504         prototype.  Just print
7505         maintenance_test_options_command_completion_text.
7506         (save_completion_result): New.
7507         (maintenance_test_options_completer_mode): Pass options context to
7508         complete_options, and then save a dump.
7509         (_initialize_maint_test_options): Use add_cmd to install "maint
7510         show test-options-completion-result".
7511
7512 2019-07-03  Pedro Alves  <palves@redhat.com>
7513
7514         * NEWS (New commands): Mention "with" and "maint with".
7515         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7516         (with_command, with_command_completer): New.
7517         (pipe_command): Adjust to new repeat_previous
7518         interface.
7519         (_initialize_cli_cmds): Install the "with" command and its "w"
7520         alias.
7521         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7522         declarations.
7523         * cli/cli-setshow.c (parse_cli_var_uinteger)
7524         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7525         argument strings for all var_types.
7526         (get_setshow_command_value_string): New, factored out from ...
7527         (do_show_command): ... this.
7528         * cli/cli-setshow.h: Include <string>.
7529         (get_setshow_command_value_string): Declare.
7530         * command.h (repeat_previous): Now returns const char *.  Adjust
7531         comment.
7532         * maint.c: Include "cli/cli-cmds.h".
7533         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7534         (_initialize_maint_cmds): Register the "maintenance with" command.
7535         * top.c (repeat_previous): Move bits from pipe_command here:
7536         Return the saved command line, if any; error out if there's no
7537         command to relaunch.
7538
7539 2019-07-03  Pedro Alves  <palves@redhat.com>
7540
7541         * NEWS (New commands): Mention "maint set/show test-settings"
7542         instead of "maint test-settings".
7543         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7544         (maintenance_test_settings_set_list): Rename to ...
7545         (maintenance_set_test_settings_list): ... this.
7546         (maintenance_test_settings_show_list): Rename to  ...
7547         (maintenance_show_test_settings_list): ... this.
7548         (maintenance_test_settings_cmd): Delete.
7549         (maintenance_test_settings_set_cmd): ...
7550         (maintenance_set_test_settings_cmd): ... this.
7551         (maintenance_test_settings_show_cmd): ...
7552         (maintenance_show_test_settings_cmd): ... this.
7553         (maintenance_test_settings_show_value_cmd):
7554         (maintenance_show_test_settings_value_cmd): ... this.
7555         (_initialize_maint_test_settings): No longer install the "maint
7556         test-settings" prefix command.  Rename "maint test-settings set"
7557         to "maint set test-settings", and "maint test-settings show" to
7558         "maint show test-settings".  Adjust all subcommands.
7559
7560 2019-07-03  Pedro Alves  <palves@redhat.com>
7561
7562         * maint-test-settings.c: Fix file's intro comment.  Replace all
7563         references to "test-options" with references to "test-settings",
7564         in comments.
7565
7566 2019-07-03  Pedro Alves  <palves@redhat.com>
7567
7568         * maint-test-settings.c (maintenance_test_settings_xxx)
7569         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7570         New.
7571         (maintenance_test_settings_enums): Use them.
7572         (maintenance_test_settings_enum): Default to
7573         maintenance_test_settings_xxx.
7574         (_initialize_maint_test_settings): Initialize
7575         MAINTENANCE_TEST_SETTINGS_FILENAME.
7576
7577 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7578
7579         * breakpoint.h (remove_breakpoints_inf): Change return type to
7580         void, move function documentation here.
7581         * breakpoint.c (remove_breakpoints_inf): Change return type to
7582         void, move function documentation to header.
7583
7584 2019-07-02  Pedro Alves  <palves@redhat.com>
7585
7586         * NEWS (Completion improvements): Mention "info threads".
7587         * thread.c (struct info_threads_opts, info_threads_option_defs)
7588         (make_info_threads_options_def_group): New.
7589         (info_threads_command): Use gdb::option::process_options.
7590         (info_threads_command_completer): New.
7591         (_initialize_thread): Use gdb::option::build_help to build the
7592         help text for "info threads".
7593
7594 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7595
7596         * defs.h (generic_load): Move from here...
7597         * symfile.h (generic_load): ... to here.  Rename name parameter
7598         to args.
7599         * symfile.c (generic_load): Add comment.
7600
7601 2019-07-01  Tom Tromey  <tromey@adacore.com>
7602
7603         * dwarf2read.c
7604         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7605         declaration of without_params.  Fix formatting.
7606
7607 2019-07-01  Tom Tromey  <tromey@adacore.com>
7608
7609         * ada-exp.y (find_primitive_type): Update.
7610         * ada-lang.h (ada_lookup_symbol): Update.
7611         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7612         parameter.
7613         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7614
7615 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7616
7617         PR breakpoints/24541
7618         * gdbarch.c: Regenerate.
7619         * gdbarch.h: Regenerate.
7620         * gdbarch.sh: Add 'stap_adjust_register'.
7621         * i386-tdep.c: Include '<unordered_set>'.
7622         (i386_stap_adjust_register): New function.
7623         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7624         * stap-probe.c (stap_parse_register_operand): Call
7625         'gdbarch_stap_adjust_register'.
7626
7627 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7628
7629         PR python/24742
7630         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7631         * python/python.c (do_start_initialization): Use 'xmalloc'
7632         instead of 'PyMem_Malloc'.
7633
7634 2019-06-28  Tom Tromey  <tromey@adacore.com>
7635
7636         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7637         for Ada.
7638
7639 2019-06-27  Tom Tromey  <tromey@adacore.com>
7640
7641         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7642         objfile_key.
7643         (arm_find_mapping_symbol, arm_record_special_symbol)
7644         (_initialize_arm_tdep): Update.
7645         (arm_objfile_data_free): Remove.
7646
7647 2019-06-27  Tom Tromey  <tromey@adacore.com>
7648
7649         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7650         to cp_print_static_field.
7651
7652 2019-06-26  Tom Tromey  <tromey@adacore.com>
7653
7654         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7655         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7656         declare.
7657
7658 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7659
7660         * features/aarch64-core.c (create_feature_aarch64_core):
7661         Regenerate.
7662         * features/aarch64-core.xml: Add cpsr flags.
7663
7664 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7665
7666         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7667         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7668
7669 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7670
7671         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7672         field.
7673         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7674         use.
7675         (arm_record_special_symbol): Don't insert new symbol in sorted
7676         position, push it at the end.
7677
7678 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7679
7680         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7681         (arm_mapping_symbol_s): Remove.
7682         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7683         (arm_mapping_symbol_vec): New typedef.
7684         (struct arm_per_objfile): Add constructor.
7685         <section_maps>: Change type to
7686         std::unique_ptr<arm_mapping_symbol_vec[]>.
7687         (arm_compare_mapping_symbols): Remove.
7688         (arm_find_mapping_symbol): Adjust to section_maps type change.
7689         (arm_objfile_data_free): Call delete on arm_per_objfile.
7690         (arm_record_special_symbol): Adjust to section_maps type change.
7691         Allocate arm_per_objfile with new.
7692
7693 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7694
7695         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7696         with the command prefix.
7697
7698 2019-06-25  Tom Tromey  <tom@tromey.com>
7699
7700         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7701         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7702
7703 2019-06-25  Tom Tromey  <tom@tromey.com>
7704
7705         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7706         type.
7707         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7708         protected.
7709
7710 2019-06-25  Tom Tromey  <tom@tromey.com>
7711
7712         * tui/tui-winsource.c
7713         (tui_source_window_base::set_is_exec_point_at): Add check against
7714         LOA_ADDRESS.
7715
7716 2019-06-25  Tom Tromey  <tom@tromey.com>
7717
7718         * tui/tui-source.c (tui_set_source_content): Don't check before
7719         xfree.
7720         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7721
7722 2019-06-25  Tom Tromey  <tom@tromey.com>
7723
7724         * tui/tui-winsource.h (tui_update_source_window_as_is)
7725         (tui_alloc_source_buffer, tui_line_is_displayed)
7726         (tui_addr_is_displayed): Change type of win_info.
7727         * tui/tui-winsource.c (tui_update_source_window_as_is)
7728         (tui_clear_source_content, tui_show_source_line)
7729         (tui_show_source_content, tui_source_window_base::refill)
7730         (tui_source_window_base::set_is_exec_point_at)
7731         (tui_source_window_base::set_is_exec_point_at)
7732         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7733         (tui_alloc_source_buffer, tui_line_is_displayed)
7734         (tui_addr_is_displayed): Change type of win_info.  Update.
7735         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7736         (tui_source_window_base::do_make_visible_with_new_height):
7737         Update.
7738         * tui/tui-source.c (tui_set_source_content)
7739         (tui_set_source_content_nil)
7740         (tui_source_window::do_scroll_vertical): Update.
7741         * tui/tui-layout.c (show_layout): Update.
7742         * tui/tui-disasm.c (tui_set_disassem_content)
7743         (tui_disasm_window::do_scroll_vertical): Update.
7744         * tui/tui-data.h (tui_win_content): Remove.
7745         (struct tui_gen_win_info) <content, content_size>: Remove.
7746         (struct tui_source_element): Add initializers and destructor.
7747         (union tui_which_element, struct tui_win_element): Remove.
7748         (struct tui_source_window_base) <content>: New field.
7749         (struct tui_data_window): Remove destructor.
7750         (tui_alloc_content, tui_free_win_content)
7751         (tui_free_all_source_wins_content): Don't declare.
7752         * tui/tui-data.c (tui_initialize_static_data): Update.
7753         (init_content_element, tui_alloc_content): Remove.
7754         (~tui_gen_win_info): Update.
7755         (~tui_data_window, tui_free_all_source_wins_content)
7756         (tui_free_win_content, free_content, free_content_elements):
7757         Remove.
7758
7759 2019-06-25  Tom Tromey  <tom@tromey.com>
7760
7761         * tui/tui-winsource.h (tui_clear_source_content)
7762         (tui_erase_source_content, tui_show_source_content): Change type
7763         of win_info.
7764         * tui/tui-winsource.c (tui_clear_source_content)
7765         (tui_erase_source_content, tui_show_source_content): Change type
7766         of win_info.
7767         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7768         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7769         win_info.
7770         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7771         win_info.
7772         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7773
7774 2019-06-25  Tom Tromey  <tom@tromey.com>
7775
7776         * tui/tui-winsource.c (tui_clear_source_content)
7777         (tui_source_window_base::set_is_exec_point_at): Update.
7778         * tui/tui-source.c (tui_set_source_content_nil): Update.
7779         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7780         a bool.
7781         * tui/tui-data.c (init_content_element): Update.
7782
7783 2019-06-25  Tom Tromey  <tom@tromey.com>
7784
7785         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7786         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7787         * tui/tui-layout.c (init_and_make_win): Update.
7788         * tui/tui.h (enum tui_win_type): Update.
7789         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7790         tui_win_is_auxillary.
7791         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7792         tui_win_is_auxillary.
7793
7794 2019-06-25  Tom Tromey  <tom@tromey.com>
7795
7796         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7797         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7798         (tui_delete_data_content_windows, tui_display_all_data)
7799         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7800         Update.
7801         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7802         * tui/tui-regs.c (tui_last_regs_line_no)
7803         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7804         (tui_show_registers): Update.
7805         (tui_show_register_group): Return void.  Update.
7806         (tui_display_registers_from, tui_display_reg_element_at_line)
7807         (tui_display_registers_from_line, tui_check_register_values):
7808         Update.
7809         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7810         member.
7811         (struct tui_data_window) <regs_content>: Now a std::vector.
7812         <regs_content_count>: Remove.
7813         (tui_add_content_elements, tui_free_data_content): Don't declare.
7814         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7815         (init_content_element): Remove DATA_WIN case.  Add assert.
7816         (tui_add_content_elements): Remove.
7817         (tui_data_window): Update.
7818         (tui_free_data_content): Remove.
7819         (free_content_elements): Remove DATA_WIN case.
7820
7821 2019-06-25  Tom Tromey  <tom@tromey.com>
7822
7823         * tui/tui-data.c (tui_data_item_window): Update.
7824         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7825         * tui/tui-windata.c (tui_display_all_data)
7826         (tui_display_data_from_line): Update.
7827         (tui_check_data_values): Remove.
7828         * tui/tui-regs.c (tui_show_register_group)
7829         (tui_display_reg_element_at_line): Update.
7830         * tui/tui-hooks.c (tui_register_changed)
7831         (tui_refresh_frame_and_register_information): Call
7832         tui_check_register_values.
7833         * tui/tui-data.h (struct tui_data_window) <data_content,
7834         data_content_count, data_type>: Remove.
7835         (enum tui_data_type): Remove.
7836
7837         * tui/tui-data.c (tui_data_window::clear_detail)
7838         (~tui_data_window): Update.
7839
7840 2019-06-25  Tom Tromey  <tom@tromey.com>
7841
7842         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7843         declare.
7844         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7845         Rename from tui_first_data_item_displayed.  Update.
7846         (tui_data_window::refresh_all)
7847         (tui_data_window::do_scroll_vertical): Update.
7848         * tui/tui-data.h (struct tui_data_window)
7849         <first_data_item_displayed>: Declare new method.
7850
7851 2019-06-25  Tom Tromey  <tom@tromey.com>
7852
7853         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7854         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7855         contents...
7856         (tui_initialize_static_data): ...here.
7857
7858 2019-06-25  Tom Tromey  <tom@tromey.com>
7859
7860         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7861         (tui_display_registers_from, tui_check_register_values): Update.
7862         (tui_display_register): Remove win_info parameter; update.
7863         (tui_get_register): Change type of parameters.
7864         * tui/tui-data.h (struct tui_data_element): Remove.
7865         (union tui_which_element) <data>: Remove.
7866         <data_window>: Change type.
7867         (struct tui_data_item_window): New.
7868         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7869         case.  Add assert.
7870         (~tui_data_item_window): New destructor.
7871         (free_content_elements): Remove DATA_ITEM_WIN case.
7872
7873 2019-06-25  Tom Tromey  <tom@tromey.com>
7874
7875         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7876         Remove.
7877
7878 2019-06-25  Tom Tromey  <tom@tromey.com>
7879
7880         * tui/tui-data.h (struct tui_command_element): Remove.
7881         (union tui_which_element) <command>: Remove.
7882         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7883         assert.
7884         (free_content_elements): Remove CMD_WIN case.
7885
7886 2019-06-25  Tom Tromey  <tom@tromey.com>
7887
7888         * tui/tui-layout.c (tui_set_layout): Update.
7889         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7890         * tui/tui-data.c (layout_def): Update.
7891
7892 2019-06-25  Tom Tromey  <tom@tromey.com>
7893
7894         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7895         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7896         (tui_source_window_base::set_new_height): Update.
7897         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7898         Update.
7899         (tui_set_locator_fullname, tui_set_locator_info)
7900         (tui_show_frame_info): Update.
7901         * tui/tui-source.c (tui_set_source_content)
7902         (tui_source_is_displayed): Update.
7903         * tui/tui-layout.c (show_source_disasm_command, show_data)
7904         (show_source_or_disasm_and_command): Update.
7905         * tui/tui-disasm.c (tui_set_disassem_content)
7906         (tui_get_begin_asm_address): Update.
7907         * tui/tui-data.h (struct tui_locator_element): Remove.
7908         (union tui_which_element) <locator>: Remove.
7909         (struct tui_locator_window): New.
7910         (tui_locator_win_info_ptr): Change return type.
7911         * tui/tui-data.c (_locator): Change type.
7912         (tui_locator_win_info_ptr): Change return type.
7913         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7914         (tui_alloc_content): Add assert.
7915
7916 2019-06-25  Tom Tromey  <tom@tromey.com>
7917
7918         * tui/tui-winsource.c
7919         (tui_exec_info_window::maybe_allocate_content): New method.
7920         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7921         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7922         (make_source_or_disasm_window): Add cast.
7923         * tui/tui-data.h (union tui_which_element) <simple_string>:
7924         Remove.
7925         (struct tui_source_info): New.
7926         (struct tui_source_window_base) <execution_info>: Change type.
7927         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7928         case, and add assert.
7929         (tui_alloc_content): Add assert.
7930
7931 2019-06-25  Tom Tromey  <tom@tromey.com>
7932
7933         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7934         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7935         * tui/tui-data.c (tui_alloc_win_info): Remove.
7936
7937 2019-06-25  Tom Tromey  <tom@tromey.com>
7938
7939         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7940         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7941         can_highlight.
7942
7943 2019-06-25  Tom Tromey  <tom@tromey.com>
7944
7945         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7946         make_visible_with_new_height method.
7947         (tui_win_info::make_visible_with_new_height): New method.
7948         (tui_source_window_base::do_make_visible_with_new_height)
7949         (tui_data_window::do_make_visible_with_new_height)
7950         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7951         (make_visible_with_new_height): Remove.
7952         (tui_resize_all, tui_adjust_win_heights): Use
7953         make_visible_with_new_height method.
7954         * tui/tui-data.h (struct tui_win_info)
7955         <do_make_visible_with_new_height, make_visible_with_new_height>:
7956         New methods.
7957         (struct tui_source_window_base, struct tui_data_window)
7958         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7959         methods.
7960
7961 2019-06-25  Tom Tromey  <tom@tromey.com>
7962
7963         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7964         method.
7965         (update_tab_width): Call update_tab_width method.
7966         * tui/tui-data.h (struct tui_win_info)
7967         (struct tui_source_window_base) <update_tab_width>: New methods.
7968
7969 2019-06-25  Tom Tromey  <tom@tromey.com>
7970
7971         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7972         parameter.
7973         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7974         parameter.
7975         (tui_gen_win_info::make_visible): Update.
7976         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7977         parameter.
7978         * tui/tui-data.h (enum tui_box): New enum.
7979         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7980
7981 2019-06-25  Tom Tromey  <tom@tromey.com>
7982
7983         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7984         init_and_make_win for EXEC_INFO_WIN.
7985         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7986         longer inline.
7987         (struct tui_win_info) <~tui_win_info>: Inline.
7988         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7989         Don't declare.
7990         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7991         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7992         Remove.
7993         (tui_initialize_static_data): Update.
7994         (~tui_gen_win_info): Handle more cleanup here.
7995         (~tui_source_window_base): Delete "execution_info".
7996         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7997
7998 2019-06-25  Tom Tromey  <tom@tromey.com>
7999
8000         * tui/tui-layout.c (make_command_window): Don't set
8001         can_highlight.
8002         (show_source_disasm_command): Call the reset method.
8003         (show_data): Don't set can_highlight.  Call the reset method.
8004         (tui_gen_win_info::reset): Rename from init_gen_win_info
8005         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8006         (show_source_or_disasm_and_command): Call the reset method.
8007         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8008         (struct tui_cmd_window): Set can_highlight.
8009
8010 2019-06-25  Tom Tromey  <tom@tromey.com>
8011
8012         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8013         from make_visible.
8014         (tui_make_visible, tui_make_invisible): Rewrite.
8015         (tui_win_info::make_visible): Remove.
8016         (tui_source_window_base::make_visible): Update.
8017         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8018         method.  Moved from...
8019         (struct tui_win_info) <make_visible>: ...here.
8020
8021 2019-06-25  Tom Tromey  <tom@tromey.com>
8022
8023         * tui/tui-winsource.c
8024         (tui_source_window_base::do_scroll_horizontal): Remove direction
8025         parameter.
8026         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8027         direction parameter.
8028         * tui/tui-win.c (tui_win_info::forward_scroll)
8029         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8030         (tui_win_info::right_scroll): Update.
8031         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8032         direction parameter.
8033         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8034         direction parameter.
8035         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8036         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8037         Remove direction parameter.
8038         (struct tui_source_window_base, struct tui_source_window)
8039         (struct tui_disasm_window, struct tui_data_window)
8040         (struct tui_cmd_window): Update.
8041
8042 2019-06-25  Tom Tromey  <tom@tromey.com>
8043
8044         * tui/tui-winsource.h (tui_set_exec_info_content)
8045         (tui_show_exec_info_content, tui_erase_exec_info_content)
8046         (tui_clear_exec_info_content, tui_update_exec_info): Change
8047         argument to tui_source_window_base.
8048         * tui/tui-winsource.c (tui_set_exec_info_content)
8049         (tui_show_exec_info_content, tui_erase_exec_info_content)
8050         (tui_clear_exec_info_content, tui_update_exec_info): Change
8051         argument to tui_source_window_base.
8052
8053 2019-06-25  Tom Tromey  <tom@tromey.com>
8054
8055         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8056         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8057
8058 2019-06-25  Tom Tromey  <tom@tromey.com>
8059
8060         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8061         check.
8062
8063 2019-06-25  Tom Tromey  <tom@tromey.com>
8064
8065         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8066         type to void.
8067         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8068         type to void.
8069         * tui/tui-source.c (tui_set_source_content): Update.
8070         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8071
8072 2019-06-25  Tom Tromey  <tom@tromey.com>
8073
8074         * tui/tui-win.c (window_name_completer, tui_set_focus)
8075         (tui_all_windows_info): Use name method.
8076         * tui/tui-data.h (struct tui_gen_win_info)
8077         (struct tui_source_window, struct tui_disasm_window)
8078         (struct tui_data_window, struct tui_cmd_window) <name>: New
8079         method.
8080         (tui_win_name): Don't declare.
8081         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8082         (tui_win_name): Remove.
8083
8084 2019-06-25  Tom Tromey  <tom@tromey.com>
8085
8086         * tui/tui-winsource.h (tui_update_source_window)
8087         (tui_update_source_window_as_is): Change parameter type.
8088         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8089         to be a tui_source_window_base.
8090         (tui_update_source_window_as_is): Likewise.
8091         * tui/tui-win.c (make_visible_with_new_height): Update.
8092
8093 2019-06-25  Tom Tromey  <tom@tromey.com>
8094
8095         * tui/tui-winsource.c (tui_erase_source_content)
8096         (tui_show_source_content, tui_show_exec_info_content)
8097         (tui_erase_exec_info_content): Use refresh_window method.
8098         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8099         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8100         from tui_refresh_win.
8101         (tui_data_window::refresh_window): New method.
8102         (tui_win_info::refresh, tui_source_window_base::refresh)
8103         (tui_refresh_all): Use refresh_window method.
8104         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8105         method.
8106         * tui/tui-regs.c (tui_display_register): Call refresh_window
8107         method.
8108         * tui/tui-layout.c (show_source_disasm_command)
8109         (show_source_or_disasm_and_command): Call refresh_window method.
8110         * tui/tui-data.h (struct tui_gen_win_info)
8111         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8112         New method.
8113
8114 2019-06-25  Tom Tromey  <tom@tromey.com>
8115
8116         * tui/tui.c (tui_rl_other_window, tui_enable)
8117         (tui_is_window_visible, tui_get_command_dimension): Update.
8118         * tui/tui-winsource.c (tui_update_source_window_as_is)
8119         (tui_clear_source_content, tui_erase_source_content)
8120         (tui_show_source_line, tui_source_window_base::refill)
8121         (tui_source_window_base::do_scroll_horizontal)
8122         (tui_source_window_base::set_is_exec_point_at)
8123         (tui_update_breakpoint_info, tui_set_exec_info_content)
8124         (tui_alloc_source_buffer, tui_line_is_displayed)
8125         (tui_addr_is_displayed): Update.
8126         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8127         (tui_check_and_display_highlight_if_needed)
8128         (tui_win_info::make_visible, tui_win_info::refresh)
8129         (tui_refresh_all): Update.
8130         * tui/tui-windata.c (tui_first_data_item_displayed)
8131         (tui_delete_data_content_windows, tui_erase_data_content)
8132         (tui_display_all_data, tui_data_window::refresh_all)
8133         (tui_check_data_values): Update.
8134         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8135         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8136         (tui_win_info::backward_scroll, tui_refresh_all_win)
8137         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8138         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8139         (tui_source_window_base::set_new_height)
8140         (tui_data_window::set_new_height)
8141         (make_invisible_and_set_new_height)
8142         (make_visible_with_new_height, new_height_ok)
8143         (parse_scrolling_args): Update.
8144         * tui/tui-stack.c (tui_show_frame_info): Update.
8145         * tui/tui-source.c (tui_set_source_content)
8146         (tui_set_source_content_nil, tui_source_is_displayed)
8147         (tui_source_window::do_scroll_vertical): Update.
8148         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8149         (tui_display_registers_from, tui_display_reg_element_at_line)
8150         (tui_check_register_values, tui_reg_command): Update.
8151         * tui/tui-layout.c (tui_default_win_height)
8152         (show_source_disasm_command, show_data, init_and_make_win)
8153         (show_source_or_disasm_and_command): Update.
8154         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8155         (tui_redisplay_readline, tui_mld_flush)
8156         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8157         (tui_getc): Update.
8158         * tui/tui-disasm.c (tui_set_disassem_content)
8159         (tui_disasm_window::do_scroll_vertical): Update.
8160         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8161         Now virtual.
8162         (struct tui_win_info): Derive from tui_gen_win_info.
8163         <~tui_win_info>: Mark as override.
8164         <generic>: Remove member.
8165         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8166         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8167         (~tui_data_window, ~tui_win_info)
8168         (tui_free_all_source_wins_content): Update.
8169         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8170
8171 2019-06-25  Tom Tromey  <tom@tromey.com>
8172
8173         * tui/tui-layout.c (init_and_make_win): Use new.
8174         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8175         destructor, initializers.
8176         (tui_alloc_generic_win_info): Don't declare.
8177         * tui/tui-data.c (_locator): Add argument to constructor.
8178         (source_win, disasm_win): New globals.
8179         (exec_info): Remove.
8180         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8181         Update.
8182         (tui_alloc_generic_win_info): Remove.
8183         (init_content_element): Use new.
8184         (tui_win_info::tui_win_info): Update.
8185         (free_content_elements) <case DATA_WIN>: Use delete.
8186
8187 2019-06-25  Tom Tromey  <tom@tromey.com>
8188
8189         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8190         * tui/tui-windata.c (tui_first_data_item_displayed)
8191         (tui_delete_data_content_windows): Update.
8192         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8193         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8194         (tui_display_registers_from, tui_check_register_values): Update.
8195         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8196         pointer.
8197         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8198         window.
8199         (tui_free_data_content): Update.
8200         (free_content_elements) <case DATA_WIN>: Free the window.
8201
8202 2019-06-25  Tom Tromey  <tom@tromey.com>
8203
8204         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8205         Update.
8206         * tui/tui-layout.c (make_command_window)
8207         (show_source_disasm_command, show_data, init_and_make_win)
8208         (show_source_or_disasm_and_command): Update.
8209         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8210         method.
8211         <can_highight, is_highlighted>: Now bool.
8212         (tui_set_win_highlight): Don't declare.
8213         * tui/tui-data.c (tui_set_win_highlight): Remove.
8214
8215 2019-06-25  Tom Tromey  <tom@tromey.com>
8216
8217         * tui/tui-wingeneral.c (make_visible): Remove check of window
8218         type.
8219
8220 2019-06-25  Tom Tromey  <tom@tromey.com>
8221
8222         * tui/tui-win.c (tui_win_info::max_height)
8223         (tui_cmd_window::max_height): New methods.
8224         (new_height_ok): Call max_height.
8225         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8226         <max_height>: New method.
8227
8228 2019-06-25  Tom Tromey  <tom@tromey.com>
8229
8230         * tui/tui-win.c (tui_source_window_base::set_new_height)
8231         (tui_data_window::set_new_height): New methods.
8232         (make_invisible_and_set_new_height): Call set_new_height method.
8233         * tui/tui-data.h (struct tui_win_info)
8234         (struct tui_source_window_base, struct tui_data_window)
8235         <set_new_height>: New method.
8236
8237 2019-06-25  Tom Tromey  <tom@tromey.com>
8238
8239         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8240         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8241         tui_refresh_data_win.
8242         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8243         method.
8244         (tui_refresh_all_win): Call the refresh_all method.
8245         (tui_set_focus): Likewise.
8246         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8247         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8248         Likewise.
8249
8250 2019-06-25  Tom Tromey  <tom@tromey.com>
8251
8252         * tui/tui-winsource.h (tui_refill_source_window)
8253         (tui_set_is_exec_point_at): Don't declare.
8254         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8255         (tui_source_window_base::refill): Rename from
8256         tui_refill_source_window.
8257         (tui_source_window_base::do_scroll_horizontal): Update.
8258         (tui_source_window_base::set_is_exec_point_at): Rename from
8259         tui_set_is_exec_point_at.
8260         (tui_update_all_breakpoint_info): Update.
8261         * tui/tui-stack.c (tui_show_frame_info): Update.
8262         * tui/tui-layout.c (show_data): Add cast.
8263         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8264         * tui/tui-data.h (struct tui_source_window_base) <refill,
8265         set_is_exec_point_at>: New methods.
8266         (tui_source_windows, tui_add_to_source_windows): Update types.
8267         (tui_add_to_source_windows): Remove redundant declaration.
8268         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8269         (tui_source_windows): Change return type.
8270         (tui_clear_source_windows_detail): Update.
8271         (tui_add_to_source_windows): Change type of parameter.
8272         (tui_free_all_source_wins_content): Update.
8273
8274 2019-06-25  Tom Tromey  <tom@tromey.com>
8275
8276         * tui/tui-wingeneral.c (tui_win_info::refresh)
8277         (tui_source_window_base::refresh): New methods.
8278         (tui_refresh_all): Call the refresh method.
8279         * tui/tui-data.h (struct tui_win_info)
8280         (struct tui_source_window_base) <refresh>: New method.
8281
8282 2019-06-25  Tom Tromey  <tom@tromey.com>
8283
8284         * tui/tui.h (tui_is_window_visible): Return bool.
8285         * tui/tui.c (tui_is_window_visible): Return bool.
8286         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8287         (tui_make_visible, tui_make_invisible)
8288         (tui_win_info::make_visible)
8289         (tui_source_window_base::make_visible, make_all_visible)
8290         (tui_make_all_visible, tui_make_all_invisible): Update.
8291         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8292         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8293         bool.
8294         (struct tui_win_info, struct tui_source_window_base)
8295         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8296         * tui/tui-data.c (tui_init_generic_part): Update.
8297
8298 2019-06-25  Tom Tromey  <tom@tromey.com>
8299
8300         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8301         (tui_source_window_base::make_visible): New methods.
8302         (make_all_visible): Make method call.
8303         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8304         (struct tui_source_window_base, struct tui_cmd_window): Override
8305         make_visible.
8306         (tui_win_is_source_type): Don't declare.
8307         * tui/tui-data.c (tui_win_is_source_type): Remove.
8308
8309 2019-06-25  Tom Tromey  <tom@tromey.com>
8310
8311         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8312         NULL check.
8313
8314 2019-06-25  Tom Tromey  <tom@tromey.com>
8315
8316         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8317         Inline constructor.  Add initializers for members.
8318         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8319         constructors; now inline in class.
8320
8321 2019-06-25  Tom Tromey  <tom@tromey.com>
8322
8323         * tui/tui-regs.c (tui_show_registers): Update.
8324         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8325         bool.
8326         * tui/tui-data.c (tui_data_window::clear_detail)
8327         (tui_data_window): Update.
8328
8329 2019-06-25  Tom Tromey  <tom@tromey.com>
8330
8331         * tui/tui-windata.c (tui_display_all_data)
8332         (tui_display_data_from_line, tui_display_data_from)
8333         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8334         Update.
8335         * tui/tui-regs.c (tui_last_regs_line_no)
8336         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8337         (tui_show_registers, tui_show_register_group)
8338         (tui_display_registers_from, tui_display_reg_element_at_line)
8339         (tui_display_registers_from_line, tui_check_register_values)
8340         (tui_reg_next, tui_reg_prev): Update.
8341         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8342         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8343         tui_data_window.
8344         (struct tui_win_info) <detail>: Remove.  Add new fields from
8345         tui_data_info.
8346         (TUI_DATA_WIN): Add cast.
8347         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8348         (~tui_data_window): Simplify.
8349
8350 2019-06-25  Tom Tromey  <tom@tromey.com>
8351
8352         * tui/tui-layout.c (show_source_disasm_command)
8353         (show_source_or_disasm_and_command): Update.
8354         * tui/tui-io.c (update_cmdwin_start_line)
8355         (tui_redisplay_readline): Update.
8356         * tui/tui-data.h (struct tui_command_info): Remove.
8357         (struct tui_win_info) <detail>: Remove command_info member.
8358         (struct tui_data_window) <start_line>: New member, from
8359         tui_command_info.
8360         (TUI_CMD_WIN): Add casts.
8361
8362 2019-06-25  Tom Tromey  <tom@tromey.com>
8363
8364         * tui/tui-winsource.c (tui_update_source_window)
8365         (tui_refill_source_window)
8366         (tui_source_window_base::do_scroll_horizontal)
8367         (tui_update_breakpoint_info, tui_set_exec_info_content)
8368         (tui_show_exec_info_content, tui_erase_exec_info_content)
8369         (tui_clear_exec_info_content): Update.
8370         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8371         Update.
8372         * tui/tui-win.c (make_invisible_and_set_new_height)
8373         (make_visible_with_new_height): Update.
8374         * tui/tui-source.c (tui_set_source_content)
8375         (tui_show_symtab_source): Update.
8376         * tui/tui-layout.c (extract_display_start_addr)
8377         (show_source_disasm_command, show_data)
8378         (make_source_or_disasm_window)
8379         (show_source_or_disasm_and_command): Update.
8380         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8381         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8382         "gdbarch".
8383         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8384         to tui_source_window_base.
8385         (struct tui_win_info) <detail>: Remove source_info member.
8386         (struct tui_source_window_base) <has_locator>: Inline.
8387         Move contents from tui_source_info; rename has_locator member to
8388         m_has_locator.
8389         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8390         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8391         header file.
8392         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8393         Simplify.
8394         (tui_free_all_source_wins_content): Cast to
8395         tui_source_window_base.
8396
8397 2019-06-25  Tom Tromey  <tom@tromey.com>
8398
8399         * tui/tui-win.c (make_invisible_and_set_new_height)
8400         (make_visible_with_new_height): Call has_locator method.
8401         * tui/tui-layout.c (show_source_disasm_command, show_data)
8402         (show_source_or_disasm_and_command): Update for bool change.
8403         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8404         (tui_win_info) <has_locator>: New method.
8405         (struct tui_source_window_base) <has_locator>: New method.
8406         (tui_win_has_locator): Don't declare.
8407         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8408         from tui_win_has_locator.
8409         (tui_source_window_base): Use false, not FALSE.
8410
8411 2019-06-25  Tom Tromey  <tom@tromey.com>
8412
8413         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8414         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8415         clear_detail method directly.
8416         (tui_clear_win_detail): Remove.
8417
8418 2019-06-25  Tom Tromey  <tom@tromey.com>
8419
8420         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8421         "this", not TUI_DISASM_WIN.
8422
8423 2019-06-25  Tom Tromey  <tom@tromey.com>
8424
8425         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8426         declare.
8427         * tui/tui-winsource.c
8428         (tui_source_window_base::do_scroll_horizontal): Rename from
8429         tui_horizontal_source_scroll.
8430         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8431         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8432         from tui_vertical_data_scroll.
8433         * tui/tui-win.h (tui_scroll): Don't declare.
8434         * tui/tui-win.c (tui_win_info::forward_scroll)
8435         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8436         (tui_win_info::right_scroll): Rename and update.
8437         (tui_scroll_forward_command, tui_scroll_backward_command)
8438         (tui_scroll_left_command, tui_scroll_right_command): Update.
8439         (tui_scroll): Remove.
8440         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8441         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8442         from tui_vertical_source_scroll.
8443         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8444         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8445         from tui_vertical_disassem_scroll.
8446         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8447         do_scroll_horizontal>: New methods.
8448         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8449         Likewise.
8450         (struct tui_source_window_base): Add do_scroll_horizontal.
8451         (struct tui_source_window, struct tui_disasm_window): Add
8452         do_scroll_vertical.
8453         (struct tui_data_window, struct tui_cmd_window): Add
8454         do_scroll_horizontal and do_scroll_vertical.
8455         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8456
8457 2019-06-25  Tom Tromey  <tom@tromey.com>
8458
8459         * tui/tui-data.h (struct tui_source_window_base): New struct.
8460         (struct tui_source_window): Derive from tui_source_window_base.
8461         (struct tui_disasm_window): New struct.
8462         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8463         from tui_source_window::clear_detail.
8464         (tui_source_window_base): Rename from tui_source_window.
8465         (~tui_source_window_base): Rename from ~tui_source_window.
8466         (tui_alloc_win_info): Create a tui_disasm_window.
8467
8468 2019-06-25  Tom Tromey  <tom@tromey.com>
8469
8470         * tui/tui-data.h (struct tui_source_window)
8471         (struct tui_data_window): Declare destructors.
8472         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8473         destructors.
8474         (tui_win_info): Simplify.
8475
8476 2019-06-25  Tom Tromey  <tom@tromey.com>
8477
8478         * tui/tui-winsource.c (tui_display_main)
8479         (tui_update_source_windows_with_addr)
8480         (tui_update_all_breakpoint_info): Update.
8481         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8482         (new_height_ok, parse_scrolling_args): Update.
8483         * tui/tui-stack.c (tui_show_frame_info): Update.
8484         * tui/tui-data.h (struct tui_list): Remove.
8485         (tui_source_windows): Return a reference to a std::vector.
8486         * tui/tui-data.c (source_windows): Now a std::vector.
8487         (tui_source_windows): Change return type.
8488         (tui_clear_source_windows): Rewrite.
8489         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8490         (tui_free_all_source_wins_content): Rewrite.
8491
8492 2019-06-25  Tom Tromey  <tom@tromey.com>
8493
8494         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8495         (struct tui_data_window, struct tui_cmd_window): Declare
8496         clear_detail method.
8497         * tui/tui-data.c (tui_source_window::clear_detail)
8498         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8499         methods.
8500         (tui_clear_win_detail): Simplify.
8501
8502 2019-06-25  Tom Tromey  <tom@tromey.com>
8503
8504         * tui/tui-layout.c (make_source_window, make_disasm_window)
8505         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8506         Return the new window.
8507         (show_source_disasm_command, show_data)
8508         (show_source_or_disasm_and_command): Update.
8509
8510 2019-06-25  Tom Tromey  <tom@tromey.com>
8511
8512         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8513         parameter.  Return the new window.
8514         (show_source_disasm_command): Update and remove NULL check.
8515         (show_source_or_disasm_and_command): Update.
8516
8517 2019-06-25  Tom Tromey  <tom@tromey.com>
8518
8519         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8520
8521 2019-06-25  Tom Tromey  <tom@tromey.com>
8522
8523         * tui/tui-data.h (struct tui_win_info): Make constructor
8524         protected.  Make destructor virtual.  Add initializers.
8525         (tui_source_window, tui_data_window, tui_cmd_window): New
8526         classes.
8527         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8528         constructor.  Add "type" parameter.
8529         (tui_source_window, tui_data_window, tui_cmd_window): New
8530         constructors.
8531         (tui_alloc_win_info): Instantiate the appropriate subclass.
8532
8533 2019-06-25  Tom Tromey  <tom@tromey.com>
8534
8535         * tui/tui-win.c (tui_resize_all): Use delete.
8536         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8537         destructor.
8538         (tui_free_window): Don't declare.
8539         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8540         Update.
8541
8542 2019-06-25  Tom Tromey  <tom@tromey.com>
8543
8544         * tui/tui-data.h (struct tui_win_info): Add constructor.
8545         * tui/tui-data.c (tui_alloc_win_info): Use new.
8546         (tui_free_window): Use delete.
8547
8548 2019-06-22  Tom Tromey  <tom@tromey.com>
8549
8550         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8551         declare.
8552         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8553
8554 2019-06-22  Tom Tromey  <tom@tromey.com>
8555
8556         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8557         declare.
8558         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8559
8560 2019-06-22  Tom de Vries  <tdevries@suse.de>
8561
8562         * dwarf2read.c (create_addrmap_from_aranges)
8563         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8564         instead of '%zu'.
8565
8566 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8567
8568         * dwarf2read.h (dwarf2_section_info_def): Remove.
8569         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8570         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8571         std::vector<dwarf2_section_info>.
8572         (struct dwo_file) <~dwo_file>: Remove.
8573         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8574         types field.
8575         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8576         (dwarf2_read_debug_names): Likewise.
8577         (create_debug_types_hash_table): Change parameter type to
8578         array_view, adjust code accordingly.
8579         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8580         (partial_die_info::fixup): Likewise.
8581         (determine_prefix): Likewise.
8582         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8583
8584 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8585
8586         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8587         gdb_bfd_ref_ptr.
8588         <~dwo_file>: Remove call to gdb_bfd_unref.
8589         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8590         gdb_bfd_ref_ptr::get.
8591
8592 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8593
8594         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8595         type to htab_up.
8596         * dwarf2read.c (struct dwo_file): Initialize fields.
8597         <~dwo_file>: New.
8598         (free_dwo_file): Remove, move content to ~dwo_file.
8599         (struct dwo_file_deleter): Remove.
8600         (dwo_file_up>: Remove custom deleter.
8601         (free_dwo_files): Remove.
8602         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8603         dwo_files.
8604         (process_skeletonless_type_units): Call unique_ptr::get.
8605         (allocate_dwo_file_hash_table): Add deleter to created hash
8606         table.  Change return type to htab_up.
8607         (lookup_dwo_file_slot): Don't memset dwo_file, call
8608         unique_ptr::get.
8609         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8610         (create_dwo_unit_in_dwp_v2): Likewise.
8611         (open_and_init_dwo_file): Likewise.
8612         (free_dwo_file_from_slot): Remove.
8613
8614 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8615
8616         * dwarf2read.h (struct dwarf2_section_info) <readin,
8617         is_virtual>: Change type to bool.
8618         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8619         true instead of 1.
8620
8621 2019-06-19  Tom Tromey  <tom@tromey.com>
8622
8623         * tui/tui-data.h (tui_init_content_element): Don't declare.
8624
8625 2019-06-19  Tom Tromey  <tom@tromey.com>
8626
8627         * tui/tui-data.h (tui_init_win_info): Don't declare.
8628
8629 2019-06-19  Tom de Vries  <tdevries@suse.de>
8630
8631         * dwarf2read.h (abstract_to_concrete): Change type to
8632         std::unordered_map<sect_offset, std::vector<sect_offset>,
8633         gdb::hash_enum<sect_offset>>.
8634
8635 2019-06-19  Tom Tromey  <tromey@adacore.com>
8636
8637         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8638         EVAL_AVOID_SIDE_EFFECTS specially.
8639
8640 2019-06-19  Tom Tromey  <tromey@adacore.com>
8641
8642         * source-cache.c (highlighter): New global.
8643         (source_cache::get_source_lines): Create a highlighter on demand.
8644
8645 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8646
8647         * defs.h (deprecated_interactive_hook): Delete declaration.
8648         * interps.c (clear_interpreter_hooks): Remove use of
8649         deprecated_interactive_hook.
8650         * top.c (deprecated_interactive_hook): Delete definition.
8651         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8652
8653 2019-06-18  Tom de Vries  <tdevries@suse.de>
8654
8655         PR gdb/24515
8656         * dwarf2read.h (abstract_to_concrete): Change type from
8657         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8658         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8659         * dwarf2read.c (read_variable): Update.
8660         (dwarf2_fetch_die_loc_sect_off): Update.
8661
8662 2019-06-17  Tom de Vries  <tdevries@suse.de>
8663
8664         PR gdb/24617
8665         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8666         accessing parent[parent_len - 1].
8667
8668 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8669
8670         PR gdb/24364
8671         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8672         call dtrace_process_dof with NULL dof.
8673
8674 2019-06-16  Tom de Vries  <tdevries@suse.de>
8675
8676         PR gdb/24445
8677         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8678
8679 2019-06-16  Tom Tromey  <tom@tromey.com>
8680
8681         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8682         (make_all_visible): Use address of member.
8683
8684 2019-06-16  Tom Tromey  <tom@tromey.com>
8685
8686         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8687         (tui_free_window, free_content, free_content_elements): Remove
8688         unnecessary cast.
8689         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8690         cast.
8691         * tui/tui-regs.c (tui_show_register_group)
8692         (tui_display_registers_from, tui_display_reg_element_at_line):
8693         Remove unnecessary cast.
8694
8695 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8696
8697         * linux-nat.c (normal_mask): Delete.
8698         (_initialize_linux_nat): Don't initialise normal_mask.
8699
8700 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8701
8702         PR gdb/24445
8703         * dwarf-index-write.h (write_psymtabs_to_index): Add
8704         dwz_basename parameter.
8705         * dwarf-index-write.c (write_gdbindex): Move file writing to
8706         write_gdbindex_1.  Change return type void.
8707         (assert_file_size): Move up, remove filename parameter.
8708         (write_gdbindex_1): New function.
8709         (write_debug_names): Change return type to void, call
8710         assert_file_size.
8711         (struct index_wip_file): New struct.
8712         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8713         file logic to index_wip_file.  Write index for dwz file if
8714         needed.
8715         (save_gdb_index_command): Pass basename of dwz file, if present.
8716         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8717         build-id of dwz file, if present.
8718         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8719         (dwarf2_get_dwz_file): Likewise.
8720         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8721         (dwarf2_get_dwz_file): Likewise.
8722
8723 2019-06-16  Tom Tromey  <tom@tromey.com>
8724
8725         * coffread.c (process_coff_symbol): Use xstrdup.
8726         * value.c (create_internalvar): Use xstrdup.
8727
8728 2019-06-16  Tom Tromey  <tom@tromey.com>
8729
8730         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8731         * breakpoint.c (stopin_command, stopat_command)
8732         (until_break_command, decode_location_default): Remove unnecessary
8733         cast.
8734         * utils.c (subset_compare): Remove unnecessary cast.
8735         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8736         cast.
8737         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8738         cast.
8739         * infcmd.c (path_command): Remove unnecessary cast.
8740         * coffread.c (decode_type): Remove unnecessary cast.
8741         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8742         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8743         * tui/tui-stack.c (tui_show_locator_content)
8744         (tui_show_frame_info): Remove unnecessary cast.
8745         * tui/tui-win.c (tui_scroll_forward_command)
8746         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8747         (parse_scrolling_args): Remove unnecessary cast.
8748         * tui/tui-data.c (init_win_info, tui_del_window)
8749         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8750         (free_content_elements): Remove unnecessary cast.
8751         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8752         unnecessary cast.
8753         * tui/tui-source.c (tui_set_source_content)
8754         (tui_vertical_source_scroll): Remove unnecessary cast.
8755         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8756         cast.
8757         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8758         * tui/tui-regs.c (tui_display_registers_from)
8759         (tui_display_register): Remove unnecessary cast.
8760         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8761         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8762         (make_visible): Remove unnecessary cast.
8763         * tui/tui-winsource.c (tui_erase_source_content)
8764         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8765         unnecessary cast.
8766         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8767         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8768         * stabsread.c (read_type, read_array_type, read_range_type):
8769         Remove unnecessary cast.
8770         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8771         (parse_symbol, parse_type, upgrade_type, parse_external)
8772         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8773         unnecessary cast.
8774         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8775
8776 2019-06-16  Tom Tromey  <tom@tromey.com>
8777
8778         * tui/tui-data.c (tui_alloc_generic_win_info)
8779         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8780         checks.
8781
8782 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8783             Andrew Burgess  <andrew.burgess@embecosm.com>
8784
8785         * f-typeprint.c (f_print_type): Don't return early for not
8786         associated or not allocated types.
8787         (f_type_print_varspec_suffix): Add print_rank parameter and print
8788         ranks of array types in case they dangling.
8789         (f_type_print_base): Add print_rank parameter.
8790
8791 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8792
8793         * NEWS: Mention new MI commands.
8794         * break-catch-throw.c (enum exception_event_kind): Move to
8795         breakpoint.h.
8796         (print_mention_exception_catchpoint): Output text as a single
8797         message.
8798         (catch_exception_command_1): Rename to...
8799         (catch_exception_event): ...this, make non-static, update header
8800         command, and change some parameter types.
8801         (catch_catch_command): Update for changes to
8802         catch_exception_command_1.
8803         (catch_throw_command): Likewise.
8804         (catch_rethrow_command): Likewise.
8805         * breakpoint.c (enum exception_event_kind): Delete.
8806         * breakpoint.h (enum exception_event_kind): Moved here from
8807         break-catch-throw.c.
8808         (catch_exception_event): Declare.
8809         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8810         (mi_cmd_catch_throw): New function.
8811         (mi_cmd_catch_rethrow): New function.
8812         (mi_cmd_catch_catch): New function.
8813         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8814         'catch-catch' entries.
8815         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8816         (mi_cmd_catch_rethrow): Declare.
8817         (mi_cmd_catch_catch): Declare.
8818
8819 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8820
8821         * annotate.c (annotate_source_line): Change return type to void,
8822         update implementation to match.
8823         * annotate.h (annotate_source_line): Change return type to void,
8824         update header comment.
8825         * stack.c (print_frame_info): Don't change what frame information
8826         is printed based on whether annotations are on or not.
8827
8828 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8829
8830         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8831         (annotate_source): Make static.
8832         (annotate_source_line): Moved from source.c and renamed from
8833         identify_source_line.  Update the return type.
8834         * annotate.h (annotate_source): Delete declaration.
8835         (annotate_source_line): Declaration moved from source.h, and
8836         renamed from identify_source_line.  Return type updated.
8837         * source.c (identify_source_line): Moved to annotate.c and renamed
8838         to annotate_source_line.
8839         (info_line_command): Remove check of annotation_level.
8840         * source.h (identify_source_line): Move declaration to annotate.h
8841         and rename to annotate_source_line.
8842         * stack.c: Add 'annotate.h' include.
8843         (print_frame_info): Remove check of annotation_level before
8844         calling annotate_source_line.
8845
8846 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8847
8848         * source-cache.c (source_cache::get_plain_source_lines): Use
8849         open_source_file_with_line_charpos instead of just
8850         open_source_file, remove call to find_source_lines.
8851         (source_cache::get_source_lines): Likewise.
8852         * source.c (find_source_lines): Make static.
8853         (get_filename_and_charpos): Renamed into...
8854         (open_source_file_with_line_charpos): ..this along with changes to
8855         return a scoped_fd, and some other minor clean ups.
8856         (identify_source_line): Use open_source_file_with_line_charpos.
8857         (search_command_helper): Use open_source_file_with_line_charpos
8858         instead of just open_source_file, remove call to
8859         find_source_lines.
8860         * source.h (open_source_file_with_line_charpos): Declare new
8861         function.
8862         (find_source_lines): Delete declaration.
8863
8864 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8865
8866         * source.c (get_filename_and_charpos): Remove fullname
8867         parameter.
8868         (identify_source_line): Update call to get_filename_and_charpos.
8869
8870 2019-06-14  Tom Tromey  <tromey@adacore.com>
8871
8872         PR gdb/24502:
8873         * ui-style.h (skip_ansi_escape): Update comment.
8874         * ui-file.h (class no_terminal_escape_file): New class.
8875         * ui-file.c (no_terminal_escape_file::write)
8876         (no_terminal_escape_file::puts): New methods.
8877         * cli/cli-logging.c (handle_redirections): Use
8878         no_terminal_escape_file.
8879
8880 2019-06-14  Tom Tromey  <tromey@adacore.com>
8881
8882         * NEWS: Move convenience variable news above Python news.
8883
8884 2019-06-14  Tom Tromey  <tom@tromey.com>
8885
8886         * gnulib: Move directory to top-level.
8887         * configure.ac: Don't configure gnulib.
8888         * configure: Rebuild.
8889         * common/common-defs.h: Use new path to gnulib.
8890         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8891         (GNULIB_H): Remove.
8892         (INCGNU): Look in new gnulib location.
8893         (HFILES_NO_SRCDIR): Remove gnulib files.
8894         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8895         (generated_files): Remove GNULIB_H.
8896         ($(LIBGNU), all-lib): Remove targets.
8897         (distclean): Don't mention GNULIB_BUILDDIR.
8898         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8899
8900 2019-06-14  Tom Tromey  <tromey@adacore.com>
8901
8902         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8903         Warn if symbol file does not provide any symbols.
8904
8905 2019-06-14  Tom Tromey  <tromey@adacore.com>
8906
8907         * source.c (find_and_open_source): Respect basenames_may_differ.
8908
8909 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8910
8911         * annotate.c (annotate_breakpoints_invalid): Make use of
8912         scoped_restore_terminal_state.
8913         (annotate_frames_invalid): Likewise.
8914
8915 2019-06-14  Tom Tromey  <tromey@adacore.com>
8916
8917         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8918         allow assignment to an internalvar.
8919
8920 2019-06-14  Tom Tromey  <tromey@adacore.com>
8921
8922         * ada-lex.l: Allow "_" in attribute names.
8923
8924 2019-06-14  Tom Tromey  <tromey@adacore.com>
8925
8926         PR gdb/24653:
8927         * regcache.c (registers_changed): Don't call alloca.
8928         * top.c (execute_command): Don't call alloca.
8929
8930 2019-06-13  Pedro Alves  <palves@redhat.com>
8931
8932         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8933         'expression'.  When parsing an expression, error out if there's
8934         junk after "unlimited".
8935         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8936         (do_set_command): Adjust calls to is_unlimited_literal.
8937
8938 2019-06-13  Pedro Alves  <palves@redhat.com>
8939
8940         * compile/compile.c (make_compile_options_def_group): Add braces
8941         around array_view initializer.
8942         * thread.c (make_thread_apply_all_options_def_group)
8943         (make_thread_apply_all_options_def_group): Likewise.
8944
8945 2019-06-13  Pedro Alves  <palves@redhat.com>
8946
8947         * NEWS (New commands): Mention "maint test-options
8948         require-delimiter", "maint test-options unknown-is-error", "maint
8949         test-options unknown-is-operand" and "maint show
8950         test-options-completion-result".
8951         (New command options, command completion): New section.
8952         (Completion improvements): New section.
8953         Mention that you can abbreviate "unlimited".
8954
8955 2019-06-13  Pedro Alves  <palves@redhat.com>
8956
8957         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8958         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8959         * unittests/cli-utils-selftests.c (test_parse_flags)
8960         (test_parse_flags_qcs): Delete.
8961         (test_cli_utils): Don't call deleted functions.
8962
8963 2019-06-13  Pedro Alves  <palves@redhat.com>
8964
8965         * thread.c: Include "cli/cli-option.h".
8966         (tp_array_compar_ascending): Global.
8967         (tp_array_compar): Delete function.
8968         (tp_array_compar_ascending, tp_array_compar_descending): New
8969         functions.
8970         (ascending_option_def, qcs_flag_option_def)
8971         (thr_qcs_flags_option_defs)
8972         (make_thread_apply_all_options_def_group)
8973         (make_thread_apply_options_def_group): New.
8974         (thread_apply_all_command): Use gdb::option::process_options.
8975         (thread_apply_command_completer)
8976         (thread_apply_all_command_completer): New.
8977         (thread_apply_command): Use gdb::option::process_options.
8978         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8979         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8980         to generate help text of "thread apply".  Adjust "taas"'s help.
8981         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8982         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8983
8984 2019-06-13  Pedro Alves  <palves@redhat.com>
8985
8986         * thread.c (thread_apply_command): Check for invalid TID with
8987         isdigit instead of !isalpha.
8988
8989 2019-06-13  Pedro Alves  <palves@redhat.com>
8990
8991         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8992         (validate_flags_qcs): New.
8993         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8994         (validate_flags_qcs): Declare.
8995         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8996         (make_frame_apply_options_def_group): New.
8997         (frame_apply_command_count): Process options with
8998         gdb::option::process_options.
8999         (frame_apply_completer): New.
9000         (frame_apply_level_completer, frame_apply_all_completer)
9001         (frame_apply_completer): New.
9002         (_initialize_stack): Update help of "frame apply", "frame apply
9003         level", "frame apply all" and "faas" to mention supported options
9004         and install command completers.
9005         * stack.h (frame_apply_all_completer): Declare.
9006         * thread.c: Include "stack.h".
9007         (tfaas_command): Add "--".
9008         (_initialize_thread): Update help "tfaas" to mention supported
9009         options and install command completer.
9010
9011 2019-06-13  Pedro Alves  <palves@redhat.com>
9012
9013         * completer.c (complete_nested_command_line): New.
9014         (gdb_completion_word_break_characters_throw): Add assertion.
9015         * completer.h (complete_nested_command_line): Declare.
9016
9017 2019-06-13  Pedro Alves  <palves@redhat.com>
9018
9019         * stack.c (parse_backtrace_qualifiers): New.
9020         (backtrace_command): Use it.
9021         (backtrace_command_completer): Complete on qualifiers.
9022
9023 2019-06-13  Pedro Alves  <palves@redhat.com>
9024
9025         * frame.c: Include "cli/cli-option.h.
9026         (user_set_backtrace_options): New.
9027         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9028         Delete.
9029         (get_prev_frame): Adjust.
9030         (boolean_option_def, uinteger_option_def)
9031         (set_backtrace_option_defs): New.
9032         (_initialize_frame): Adjust and use
9033         gdb::option::add_setshow_cmds_for_options to install "set
9034         backtrace past-main" and "set backtrace past-entry".
9035         * frame.h: Include "cli/cli-option.h".
9036         (struct frame_print_options): Forward declare.
9037         (print_frame_arguments_all, print_frame_arguments_scalars)
9038         (print_frame_arguments_none): Declare.
9039         (print_entry_values): Delete declaration.
9040         (struct frame_print_options, user_frame_print_options): New.
9041         (struct set_backtrace_options): New.
9042         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9043         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9044         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9045         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9046         (list_args_or_locals): Add frame_print_options parameter.
9047         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9048         * python/py-framefilter.c (enumerate_args): Pass down
9049         USER_FRAME_PRINT_OPTIONS.
9050         * stack.c: Include "cli/cli-option.h".
9051         (print_frame_arguments_all, print_frame_arguments_scalars)
9052         (print_frame_arguments_none): Declare.
9053         (print_raw_frame_arguments, print_entry_values): Delete.
9054         (user_frame_print_options): New.
9055         (boolean_option_def, enum_option_def, frame_print_option_defs):
9056         New.
9057         (struct backtrace_cmd_options): New.
9058         (bt_flag_option_def): New.
9059         (backtrace_command_option_defs): New.
9060         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9061         (print_frame_arg, read_frame_arg, print_frame_args)
9062         (print_frame_info, print_frame): Add frame_print_options parameter
9063         and use it.
9064         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9065         (backtrace_command_1): Add frame_print_options and
9066         backtrace_cmd_options parameters and use them.
9067         (make_backtrace_options_def_group): New.
9068         (backtrace_command): Process command options with
9069         gdb::option::process_options.
9070         (backtrace_command_completer): New.
9071         (_initialize_stack): Extend "backtrace"'s help to mention
9072         supported options.  Install completer for "backtrace".
9073         Install some settings commands with add_setshow_cmds_for_options.
9074
9075 2019-06-13  Pedro Alves  <palves@redhat.com>
9076
9077         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9078         and that "set/show print raw frame-arguments" are now deprecated.
9079
9080         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9081         command.
9082         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9083         * stack.c (_initialize_stack): Install "set/show print
9084         raw-frame-arguments", and deprecate "set/show print raw
9085         frame-arguments".
9086         * valprint.c (_initialize_valprint): Deprecate "set/show print
9087         raw".
9088
9089 2019-06-13  Pedro Alves  <palves@redhat.com>
9090
9091         * compile/compile.c (struct compile_options): New.
9092         (compile_flag_option_def, compile_command_option_defs)
9093         (make_compile_options_def_group): New.
9094         (compile_file_command): Handle options with
9095         gdb::option::process_options.
9096         (compile_file_command_completer): New function.
9097         (compile_code_command): Handle options with
9098         gdb::option::process_options.
9099         (compile_code_command_completer): New function.
9100         (_initialize_compiler): Install completers for "compile code" and
9101         "compile file".  Mention available options in "compile code" and
9102         "compile code"'s help.
9103         * completer.c (advance_to_completion_word): New, factored out from
9104         ...
9105         (advance_to_expression_complete_word_point): ... this.
9106         (advance_to_filename_complete_word_point): New.
9107         * completer.h (advance_to_filename_complete_word_point): New
9108         declaration.
9109
9110 2019-06-13  Pedro Alves  <palves@redhat.com>
9111
9112         * compile/compile.c: Include "cli/cli-option.h".
9113         (compile_print_value): Scope data pointer is now a
9114         value_print_options pointer; adjust.
9115         (compile_print_command): Process options.  Scope data pointer is
9116         now a value_print_options pointer; adjust.
9117         (_initialize_compile): Update "compile print"'s help to include
9118         supported options.  Install a completer for "compile print".
9119         * cp-valprint.c (show_vtblprint, show_objectprint)
9120         (show_static_field_print): Delete.
9121         (_initialize_cp_valprint): Don't install "set print
9122         static-members", "set print vtbl", "set print object" here.
9123         * printcmd.c: Include "cli/cli-option.h" and
9124         "common/gdb_optional.h".
9125         (print_command_parse_format): Rework to fill in a
9126         value_print_options instead of a format_data.
9127         (print_value): Change parameter type from format_data pointer to
9128         value_print_options reference.  Adjust.
9129         (print_command_1): Process options.  Adjust to pass down a
9130         value_print_options.
9131         (print_command_completer): New.
9132         (_initialize_printcmd): Install print_command_completer as
9133         handle_brkchars completer for the "print" command.  Update
9134         "print"'s help to include supported options.
9135         * valprint.c: Include "cli/cli-option.h".
9136         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9137         here from cp-valprint.c.
9138         (boolean_option_def, uinteger_option_def)
9139         (value_print_option_defs, make_value_print_options_def_group):
9140         New.  Use gdb::option::add_setshow_cmds_for_options to install
9141         "set print elements", "set print null-stop", "set print repeats",
9142         "set print pretty", "set print union", "set print array", "set
9143         print address", "set print symbol", "set print array-indexes".
9144         * valprint.h: Include <string> and "cli/cli-option.h".
9145         (make_value_print_options_def_group): Declare.
9146         (print_value): Change parameter type from format_data pointer to
9147         value_print_options reference.
9148         (print_command_completer): Declare.
9149
9150 2019-06-13  Pedro Alves  <palves@redhat.com>
9151
9152         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9153         (COMMON_SFILES): Add maint-test-settings.c.
9154         * cli/cli-decode.c (boolean_enums): New global, factored out from
9155         ...
9156         (add_setshow_boolean_cmd): ... here.
9157         * cli/cli-decode.h (boolean_enums): Declare.
9158         * cli/cli-option.c: New file.
9159         * cli/cli-option.h: New file.
9160         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9161         factored out from ...
9162         (parse_cli_boolean_value(const char *)): ... this.
9163         (is_unlimited_literal): Change parameter type to pointer to
9164         pointer.  Adjust and advance ARG pointer.
9165         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9166         (parse_cli_var_enum): New, factored out from ...
9167         (do_set_command): ... this.  Adjust.
9168         * cli/cli-setshow.h (parse_cli_boolean_value)
9169         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9170         (parse_cli_var_enum): Declare.
9171         * cli/cli-utils.c: Include "cli/cli-option.h".
9172         (get_ulongest): New.
9173         * cli/cli-utils.h (get_ulongest): Declare.
9174         (check_for_argument): New overloads.
9175         * maint-test-options.c: New file.
9176
9177 2019-06-13  Pedro Alves  <palves@redhat.com>
9178
9179         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9180         parse a range if "-" is at the end of the string.
9181
9182 2019-06-13  Pedro Alves  <palves@redhat.com>
9183
9184         * cli/cli-setshow.c (parse_auto_binary_operation)
9185         (parse_cli_boolean_value): Don't allow "o".
9186
9187 2019-06-13  Pedro Alves  <palves@redhat.com>
9188
9189         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9190         * NEWS: Mention maint test-settings KIND.
9191         * maint-test-settings.c: New file.
9192
9193 2019-06-13  Pedro Alves  <palves@redhat.com>
9194
9195         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9196         completer.
9197         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9198         "set" completers.
9199
9200 2019-06-13  Pedro Alves  <palves@redhat.com>
9201
9202         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9203         after item.
9204
9205 2019-06-13  Pedro Alves  <palves@redhat.com>
9206
9207         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9208
9209 2019-06-13  Pedro Alves <palves@redhat.com>
9210
9211         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9212         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9213         call.
9214         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9215         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9216         calls.
9217         (check_for_argument): Skip spaces after argument.
9218
9219 2019-06-13  Pedro Alves  <palves@redhat.com>
9220
9221         * thread.c (thread_apply_command): Adjust TID parsing.
9222         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9223         detected before end of string.
9224         (tid_is_in_list): Error out if LIST is invalid.
9225
9226 2019-06-13  Pedro Alves  <palves@redhat.com>
9227
9228         * completer.c (complete_line_internal_1): Rewind completion word
9229         point.
9230         (completion_tracker::advance_custom_word_point_by): Change
9231         parameter type to int.
9232         * completer.h (completion_tracker::advance_custom_word_point_by):
9233         Likewise.
9234
9235 2019-06-13  Pedro Alves  <palves@redhat.com>
9236
9237         * completer.c (advance_to_completion_word): Handle delimiters.
9238
9239 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9240
9241         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9242
9243 2019-06-11  Tom Tromey  <tom@tromey.com>
9244
9245         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9246         (xmalloc_failed): Move to alloc.c.
9247         * alloc.c: New file.
9248         * Makefile.in (COMMON_SFILES): Add alloc.c.
9249
9250 2019-06-11  Tom Tromey  <tom@tromey.com>
9251
9252         * nat/linux-waitpid.c: Don't include server.h.
9253         (linux_debug): Remove.
9254         (my_waitpid): Update.
9255
9256 2019-06-11  Tom Tromey  <tromey@adacore.com>
9257
9258         * infcall.c (_initialize_infcall): Remove trailing newline from
9259         help.
9260         * user-regs.c (_initialize_user_regs): Remove trailing newline
9261         from help.
9262         * typeprint.c (_initialize_typeprint): Remove trailing newline
9263         from help.
9264         * reverse.c (_initialize_reverse): Remove trailing newlines from
9265         help.
9266         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9267         from help.
9268         * language.c (add_set_language_command): Remove trailing newline
9269         from help.
9270         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9271         help.
9272         * disasm.c (_initialize_disasm): Remove trailing newline from
9273         help.
9274         * top.c (init_main): Remove trailing newline from help.
9275         * interps.c (_initialize_interpreter): Remove trailing newline
9276         from help.
9277         * btrace.c (_initialize_btrace): Remove trailing newlines from
9278         help.
9279         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9280         from help.
9281         * python/python.c (_initialize_python): Remove trailing newline
9282         from help.
9283         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9284         help.
9285         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9286         from help.  Reformat some text.
9287         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9288         from help.
9289         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9290         newline from help.
9291
9292 2019-06-11  Tom Tromey  <tromey@adacore.com>
9293
9294         * darwin-nat.c (darwin_decode_exception_message)
9295         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9296
9297 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9298
9299         * valops.c (value_slice): Check for not allocated or not
9300         associated values.
9301
9302 2019-06-10  Tom de Vries  <tdevries@suse.de>
9303
9304         PR gdb/24618
9305         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9306         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9307         invalid.
9308
9309 2019-06-10  Tom de Vries  <tdevries@suse.de>
9310
9311         PR gdb/24611
9312         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9313         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9314
9315 2019-06-10  Tom de Vries  <tdevries@suse.de>
9316
9317         PR symtab/24545
9318         * symtab.c (struct demangled_name_entry): Add language field.
9319         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9320         static minimal symbol".  Set and use language field.
9321
9322 2019-06-10  Tom Tromey  <tromey@adacore.com>
9323
9324         * ada-lang.c (_initialize_ada_language): Update help text.
9325
9326 2019-06-10  Tom Tromey  <tromey@adacore.com>
9327
9328         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9329         with a newline.
9330         * guile/guile.c (handle_boot_error): Don't end warning with a
9331         newline.
9332         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9333         warning with a newline.
9334         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9335         newline.
9336         (s12z_frame_cache): Likewise.
9337         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9338         a newline.
9339         * solib-svr4.c (disable_probes_interface): Don't end warning with
9340         a newline.
9341         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9342         newline.
9343         * python/python.c (do_finish_initialization): Don't end warning
9344         with a newline.
9345
9346 2019-06-10  Tom Tromey  <tom@tromey.com>
9347
9348         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9349         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9350         gdbpy_enter.
9351
9352 2019-06-10  Tom Tromey  <tromey@adacore.com>
9353
9354         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9355         data.
9356         (elf_new_init): Don't call stabsread_new_init.
9357         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9358         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9359         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9360
9361 2019-06-10  Tom de Vries  <tdevries@suse.de>
9362
9363         PR symtab/16264
9364         PR symtab/24517
9365         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9366
9367 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9368
9369         * source.c (find_and_open_source): Also rewrite relative file
9370         names.
9371
9372 2019-04-26  Amos Bird  <amosbird@gmail.com>
9373
9374         * annotate.c (annotate_thread_exited): Add "thread-exited"
9375         annotation.
9376
9377 2019-06-06  Tom Tromey  <tromey@adacore.com>
9378
9379         * maint.h (class scoped_command_stats): Use
9380         DISABLE_COPY_AND_ASSIGN.
9381         <print_time>: New method.
9382         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9383         print_time.
9384         (scoped_command_stats::print_time): New method.
9385
9386 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9387
9388         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9389         instructions of lengths 6 or 8 bytes.
9390
9391 2019-06-04  Pedro Alves  <palves@redhat.com>
9392
9393         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9394
9395         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9396         * breakpoint.c (condition_completer): Likewise.
9397         * cli/cli-dump.c (scan_expression): Likewise.
9398         * common/filestuff.c (mkdir_recursive): Likewise.
9399         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9400         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9401         (gdb_abspath): Likewise.
9402         * compile/compile-cplus-types.c
9403         (compile_cplus_instance::decl_name): Likewise.
9404         * completer.c (complete_explicit_location):
9405         (signal_completer, reg_or_group_completer_1): Likewise.
9406         * cp-support.c (cp_remove_params_if_any): Likewise.
9407         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9408         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9409         * infcmd.c (strip_bg_char): Likewise.
9410         * linespec.c (copy_token_string): Likewise.
9411         * mi/mi-main.c (output_cores): Likewise.
9412         * psymtab.c (psymtab_search_name):
9413         * symfile.c (test_set_ext_lang_command): Likewise.
9414         * target.c (target_fileio_read_stralloc): Likewise.
9415         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9416         * value.c (complete_internalvar): Likewise.
9417
9418 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9419
9420         Add objfile property to gdb.Type.
9421         * NEWS: Mention Python API addition.
9422         * python/py-type.c (typy_get_objfile): New method.
9423
9424 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9425
9426         * NEWS: Mention the new set|show style [title|highlight].
9427         Mention changes to "show style", "help" and "apropos".
9428
9429 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9430
9431         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9432         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9433         instead of print_help_for_command.
9434         (print_doc_of_command): New function.
9435         (help_list): Add 'apropos -v word' suggestion.
9436         (print_help_for_command): Style the command name using title style.
9437         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9438         (_initialize_cli_cmds): Describe -v in apropos_command help.
9439
9440 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9441
9442         * cli/cli-style.h (cli_style_option): Add name in constructor,
9443         add m_name class member, add constructor with intensity,
9444         add name class function.
9445         (cli_style_option::add_setshow_commands): Remove name argument.
9446         (highlight_style, title_style): New styles.
9447         * cli/cli-style.c (do_show): New function that shows a style
9448         characteristic styling the style name with itself.
9449         (set_style_name): New function.
9450         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9451         Update all callers according to the changes in cli/cli-style.h.
9452         * utils.h (fputs_highlighted): New function.
9453         * utils.c (fputs_highlighted): Likewise.
9454
9455 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9456
9457         * NEWS: Mention new pipe command and new convenience variables.
9458
9459 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9460
9461         * cli/cli-cmds.c (pipe_command): New function.
9462         (_initialize_cli_cmds): Call add_com for pipe_command.
9463         Define | as an alias for pipe.
9464         (exit_status_set_internal_vars): New function.
9465         (shell_escape): Call exit_status_set_internal_vars.
9466         cli/cli-decode.c (find_command_name_length): Recognize | as
9467         a single character command.
9468
9469 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9470
9471         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9472         top.c (execute_command_to_ui_file): New function, mostly a copy
9473         of execute_command_to_string.
9474         (execute_command_to_string): Implement by calling
9475         execute_command_to_ui_file.
9476
9477 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9478
9479         * top.h (saved_command_line): Remove declaration.
9480         * top.c (previous_saved_command_line, previous_repeat_arguments):
9481         New variables.
9482         (saved_command_line): Make static, define together with other
9483         'repeat variables'.
9484         (dont_repeat): Clear repeat_arguments.
9485         (repeat_previous, get_saved_command_line, save_command_line):
9486         New functions.
9487         (gdb_init): Initialize saved_command_line
9488         and previous_saved_command_line.
9489         * main.c (captured_main_1): Remove saved_command_line initialization.
9490         * event-top.c (handle_line_of_input): Update to use
9491         the new 'repeat' related functions instead of direct access to
9492         saved_command_line.
9493         * command.h (repeat_previous, get_saved_command_line,
9494         save_command_line): New declarations.
9495         (dont_repeat): Add comment.
9496
9497 2019-05-30  Tom Tromey  <tromey@adacore.com>
9498
9499         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9500         Fix comment.
9501         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9502
9503 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9504
9505         PR cli/24587
9506         * completer.c (complete): Initialize variable word.
9507
9508 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9509
9510         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9511         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9512         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9513         'body' is NULL to the outter 'if', protecting the '!is_define'
9514         situation as well.
9515
9516 2019-05-29  Tom Tromey  <tromey@adacore.com>
9517
9518         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9519         (dwarf_unknown): New function.
9520         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9521         (dwarf_type_encoding_name): Use dwarf_unknown.
9522
9523 2019-05-29  Tom Tromey  <tromey@adacore.com>
9524
9525         PR c++/20020:
9526         * cp-valprint.c (cp_print_value_fields): Call
9527         cp_print_static_field inside "try".
9528
9529 2019-05-29  Tom Tromey  <tromey@adacore.com>
9530
9531         * inflow.c (struct terminal_info): Add default operator=.
9532         * configure: Rebuild.
9533         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9534         -Wdeprecated-copy-dtor, -Wredundant-move.
9535
9536 2019-05-29  Tom Tromey  <tromey@adacore.com>
9537
9538         * NEWS: Add entry.
9539         * infcmd.c (print_return_value_1): Handle finish_print
9540         option.
9541         (show_print_finish): New function.
9542         (_initialize_infcmd): Add "set/show print finish" commands.
9543         * valprint.c (user_print_options): Initialize new member.
9544         * valprint.h (struct value_print_options) <finish_print>: New
9545         member.
9546
9547 2019-05-28  Tom Tromey  <tromey@adacore.com>
9548
9549         * ada-lang.c (ada_remove_Xbn_suffix)
9550         (find_old_style_renaming_symbol)
9551         (parse_old_style_renaming): Remove.
9552         (ada_find_renaming_symbol): Don't call
9553         find_old_style_renaming_symbol.
9554         (ada_is_renaming_symbol): Rename from
9555         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9556         bool.  Now static.
9557         (ada_read_var_value): Update and simplify.
9558         * ada-exp.y (write_var_or_type): Remove old code.
9559
9560 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9561
9562         PR gdb/25010
9563         * event-top.c: Remove include comment.
9564         * inflow.c (class scoped_ignore_sigttou): Move from here...
9565         * inflow.h (class scoped_ignore_sigttou): ...to here.
9566         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9567         * top.c:  Remove include comment.
9568
9569 2019-05-27  Tom Tromey  <tom@tromey.com>
9570
9571         * NEWS: Fix typo.
9572
9573 2019-05-22  Tom Tromey  <tromey@adacore.com>
9574
9575         * target.c (target_follow_exec): Constify parameter.
9576         * target-delegates.c: Rebuild.
9577         * remote.c (remote_target::follow_exec): Constify parameter.
9578         * infrun.c (follow_exec): Constify parameter.
9579         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9580         (target_follow_exec): Likewise.
9581
9582 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9583
9584         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9585         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9586
9587 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9588
9589         * NEWS: Add debugredirect and testsuite sections.
9590
9591 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9592
9593         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9594         target descriptions using exclusively floating point register name
9595         aliases.
9596
9597 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9598
9599         PR gdb/18644:
9600         * f-lang.c (build_fortran_types): Handle the case where
9601         gdbarch_floatformat_for_type returns a nullptr.
9602
9603 2019-05-21  Tom de Vries  <tdevries@suse.de>
9604
9605         PR cli/24587
9606         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9607
9608 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9609
9610         PR gdb/18644:
9611         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9612         16-byte floats.
9613         * i386-tdep.c (i386_floatformat_for_type): Use
9614         floatformats_ia64_quad for the 16-byte floating point component
9615         within a fortran 32-byte complex number.
9616
9617 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9618
9619         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9620         delete default constructor.
9621         (find_partial_die): Update to return const struct.
9622         (partial_die_parent_scope): Move variable declaration into scope
9623         of its use and change its type to auto.
9624         (guess_partial_die_structure_name): Likewise.
9625         (partial_die_info::fixup): Likewise.
9626
9627 2019-05-17  Tom Tromey  <tromey@adacore.com>
9628
9629         * source.c (find_and_open_source): Remove cast.
9630
9631 2019-05-17  Tom Tromey  <tromey@adacore.com>
9632
9633         * annotate.c (annotate_source): Make "filename" const.
9634         * annotate.h (annotate_source): Use const.
9635
9636 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9637
9638         * disasm.c (set_disassembler_options): Send errors to stderr.
9639
9640 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9641
9642         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9643         (cli_interp_base::set_logging): Check debug_redirect.
9644         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9645         * cli/cli-logging.c (debug_redirect): Add static variable.
9646         (pop_output_files): Add default param.
9647         (handle_redirections): Print debug setting.
9648         (show_logging_command): Likewise.
9649         (_initialize_cli_logging): Add debugredirect command.
9650         * interps.c (current_interp_set_logging): Add debug_redirect
9651         parameter.
9652         * interps.h (set_logging): Add debug_redirect parameter.
9653         (current_interp_set_logging): Likewise.
9654         * mi/mi-common.h: Likewise.
9655         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9656
9657 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9658             Tom Tromey  <tromey@adacore.com>
9659
9660         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9661         directly.
9662         * cli/cli-interp.h (make_logging_output): Remove declaration.
9663         * cli/cli-logging.c (make_logging_output): Remove function.
9664         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9665         directly.
9666         * ui-file.c (tee_file::tee_file): Remove bools.
9667         (tee_file::~tee_file): Remove deletes.
9668         * ui-file.h (tee_file): Remove bools.
9669
9670 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9671
9672         * mi/mi-cmds.h (mi_cmd_complete): New function.
9673         * mi/mi-main.c (mi_cmd_complete): Likewise.
9674         * mi/mi-cmds.c: Define new MI command -complete.
9675         * NEWS: Mention new -complete command.
9676
9677 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9678
9679         * completer.h (complete): New function.
9680         * completer.c (complete): Likewise.
9681         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9682         function defined in completer.h.
9683
9684 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9685
9686         * MAINTAINERS (Write After Approval): Add myself.
9687
9688 2019-05-17  Tom de Vries  <tdevries@suse.de>
9689
9690         PR gdb/24094
9691         * dwarf2read.c (struct cu_partial_die_info): New struct.
9692         (find_partial_die): Return cu_partial_die_info.
9693         (partial_die_parent_scope, guess_partial_die_structure_name)
9694         (partial_die_info::fixup): Handle new return type of find_partial_die.
9695
9696 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9697
9698         PR breakpoints/24541
9699         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9700         "std::string", simplifying the algorithm.
9701
9702 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9703
9704         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9705         (stap_static_probe_ops::get_probes): Likewise.
9706
9707 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9708
9709         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9710         '-')" and "else if".
9711         (stap_parse_single_operand): Join checks for
9712         "gdbarch_stap_parse_special_token_p" and
9713         "gdbarch_stap_parse_special_token" in the same "if" statement.
9714         Invert check when verifying for operation on register
9715         displacement.
9716
9717 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9718
9719         * stap-probe.c (stap_get_opcode): Update comment.
9720         (stap_get_expected_argument_type): Likewise.
9721         (handle_stap_probe): Likewise.
9722
9723 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9724
9725         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9726         return type to 'bool'.  Adjust comment.  Use 'bool' when
9727         appropriate.
9728         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9729         * stap-probe.c (stap_parse_argument_1): Likewise.
9730         (stap_is_operator): Likewise.
9731         (stap_is_generic_prefix): Likewise.
9732         (stap_is_register_prefix): Likewise.
9733         (stap_is_register_indirection_prefix): Likewise.
9734         (stap_is_integer_prefix): Likewise.
9735         (stap_generic_check_suffix): Likewise.
9736         (stap_check_integer_suffix): Likewise.
9737         (stap_check_register_suffix): Likewise.
9738         (stap_check_register_indirection_suffix): Likewise.
9739         (stap_parse_register_operand): Likewise.
9740         (stap_parse_single_operand): Likewise.
9741         (stap_parse_argument_1): Likewise.
9742         (stap_probe::get_argument_count): Likewise.
9743         (stap_is_operator): Likewise.
9744
9745 2019-05-16  Tom Tromey  <tromey@adacore.com>
9746
9747         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9748         keyword to foreach.
9749
9750 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9751
9752         * linux-thread-db.c (try_thread_db_load_1): Change return type
9753         to bool.
9754         (try_thread_db_load): Likewise.
9755         (try_thread_db_load_from_pdir_1): Likewise.
9756         (try_thread_db_load_from_pdir): Likewise.
9757         (try_thread_db_load_from_sdir): Likewise.
9758         (try_thread_db_load_from_dir): Likewise.
9759         (thread_db_load_search): Likewise.
9760         (has_libpthread): Likewise.
9761         (thread_db_load): Likewise.
9762
9763 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9764
9765         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9766         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9767         NULL, and complain/return if that's the case.
9768
9769 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9770
9771         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9772         (advance, posn, abstract_read_memory): New functions.
9773         [struct mem_read_abstraction]: New struct.
9774         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9775
9776 2019-05-14  Tom Tromey  <tromey@adacore.com>
9777
9778         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9779         value is not lval_memory.
9780
9781 2019-05-14  Tom Tromey  <tromey@adacore.com>
9782
9783         * solib.c (info_sharedlibrary_command): Style the file name.
9784
9785 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9786
9787         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9788         (aarch64_vnv_type): Likewise.
9789         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9790         * common/tdesc.c: Likewise.
9791         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9792         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9793         * features/aarch64-fpu.xml: Add ieee half view.
9794         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9795         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9796         * gdbtypes.h (struct builtin_type): Likewise.
9797         (struct objfile_type): Likewise.
9798
9799 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9800
9801         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9802         typo.
9803         * location.h (string_to_event_location): Likewise.
9804
9805 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9806
9807         GDB 8.3 released.
9808
9809 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9810
9811         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9812         New variable declaration.
9813         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9814         New variable.
9815         (print_one_breakpoint): Use ui_out::test_flags and new global
9816         variable to compute use_fixed_output.
9817         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9818         Remove.
9819         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9820         (mi_multi_location_breakpoint_output_fixed): Remove.
9821         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9822         new variable.
9823         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9824         fix_multi_location_breakpoint_output flag if version >= 3.
9825         * ui-out.h (enum ui_out_flag)
9826         <fix_multi_location_breakpoint_output>: New enumerator.
9827
9828 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9829
9830         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9831
9832 2019-05-10  Tom Tromey  <tromey@adacore.com>
9833
9834         * ada-lang.c (catch_ada_completer): New function.
9835         (_initialize_ada_language): Use it.
9836
9837 2019-05-10  Tom Tromey  <tromey@adacore.com>
9838
9839         * thread.c (print_thread_info): Make "requested_threads" const.
9840         * gdbthread.h (print_thread_info): Make "requested_threads"
9841         const.
9842         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9843         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9844
9845 2019-05-08  Tom Tromey  <tom@tromey.com>
9846
9847         * gdbtypes.c (objfile_type_data): Change type.
9848         (objfile_type, _initialize_gdbtypes): Update.
9849
9850 2019-05-08  Tom Tromey  <tom@tromey.com>
9851
9852         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9853         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9854         (_initialize_dwarf2_frame): Update.
9855
9856 2019-05-08  Tom Tromey  <tom@tromey.com>
9857
9858         * objc-lang.c (objc_objfile_data): Change type.
9859         (find_methods): Update.
9860         (_initialize_objc_lang): Remove.
9861
9862 2019-05-08  Tom Tromey  <tom@tromey.com>
9863
9864         * stabsread.c (rs6000_builtin_type_data): Change type.
9865         (rs6000_builtin_type, _initialize_stabsread): Update.
9866
9867 2019-05-08  Tom Tromey  <tom@tromey.com>
9868
9869         * mips-tdep.c (mips_pdr_data): Remove.
9870         (_initialize_mips_tdep): Update.
9871
9872 2019-05-08  Tom Tromey  <tom@tromey.com>
9873
9874         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9875         (hppa_init_objfile_priv_data, read_unwind_info)
9876         (find_unwind_entry, _initialize_hppa_tdep): Update.
9877
9878 2019-05-08  Tom Tromey  <tom@tromey.com>
9879
9880         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9881         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9882         on obstack.
9883         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9884
9885 2019-05-08  Tom Tromey  <tom@tromey.com>
9886
9887         * mdebugread.c (basic_type_data): Change type.
9888         (basic_type, _initialize_mdebugread): Update.
9889
9890 2019-05-08  Tom Tromey  <tom@tromey.com>
9891
9892         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9893
9894 2019-05-08  Tom Tromey  <tom@tromey.com>
9895
9896         * nto-tdep.c (nto_inferior_data_reg): Change type.
9897         (nto_inferior_data): Update.
9898         (nto_inferior_data_cleanup, nto_new_inferior_data)
9899         (_initialize_nto_tdep): Remove.
9900         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9901
9902 2019-05-08  Tom Tromey  <tom@tromey.com>
9903
9904         * ada-lang.c (struct ada_inferior_data): Add initializers.
9905         (ada_inferior_data): Change type.
9906         (ada_inferior_data_cleanup): Remove.
9907         (get_ada_inferior_data, ada_inferior_exit)
9908         (struct ada_pspace_data): Add initializers, destructor.
9909         (ada_pspace_data_handle): Change type.
9910         (get_ada_pspace_data): Update.
9911         (ada_pspace_data_cleanup): Remove.
9912
9913 2019-05-08  Tom Tromey  <tom@tromey.com>
9914
9915         * coffread.c (struct coff_symfile_info): Add initializers.
9916         (coff_objfile_data_key): Move lower.  Change type.
9917         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9918         Update.
9919         (coff_free_info): Remove.
9920
9921 2019-05-08  Tom Tromey  <tom@tromey.com>
9922
9923         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9924         (fbsd_pspace_data_handle): Move lower.  Change type.
9925         (get_fbsd_pspace_data): Update.
9926         (fbsd_pspace_data_cleanup): Remove.
9927         (_initialize_fbsd_tdep): Update.
9928
9929 2019-05-08  Tom Tromey  <tom@tromey.com>
9930
9931         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9932         (get_ada_tasks_pspace_data): Update.
9933         (ada_tasks_pspace_data_cleanup): Remove.
9934         (_initialize_tasks): Update.
9935         (ada_tasks_inferior_data_handle): Change type.
9936         (get_ada_tasks_inferior_data): Update.
9937         (ada_tasks_inferior_data_cleanup): Remove.
9938         (struct ada_tasks_pspace_data): Add initializers.
9939
9940 2019-05-08  Tom Tromey  <tom@tromey.com>
9941
9942         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9943         * symfile-debug.c (debug_sym_get_probes): Change type.
9944         * stap-probe.c (handle_stap_probe):
9945         (stap_static_probe_ops::get_probes): Change type.
9946         * probe.h (class static_probe_ops) <get_probes>: Change type.
9947         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9948         (parse_probes_in_pspace): Update.
9949         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9950         Update.
9951         (any_static_probe_ops::get_probes): Change type.
9952         * elfread.c (elfread_data): New typedef.
9953         (probe_key): Change type.
9954         (elf_get_probes): Likewise.  Update.
9955         (probe_key_free): Remove.
9956         (_initialize_elfread): Update.
9957         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9958         Change type.
9959         (dtrace_process_dof_probe, dtrace_process_dof)
9960         (dtrace_static_probe_ops::get_probe): Change type.
9961
9962 2019-05-08  Tom Tromey  <tom@tromey.com>
9963
9964         * xcoffread.c (struct xcoff_symfile_info): Rename from
9965         coff_symfile_info.  Add initializers.
9966         (xcoff_objfile_data_key): Move lower.  Change type.
9967         (XCOFF_DATA): Rewrite.
9968         (xcoff_free_info): Remove.
9969         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9970         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9971         (xcoff_initial_scan): Update.
9972
9973 2019-05-08  Tom Tromey  <tom@tromey.com>
9974
9975         * solib-svr4.c (struct svr4_info): Add initializers and
9976         destructor.
9977         <probes_table>: Now an htab_up.
9978         (solib_svr4_pspace_data): Change type.
9979         (free_probes_table): Simplify.
9980         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9981         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9982         (probes_table_remove_objfile_probes, register_solib_event_probe)
9983         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9984         (_initialize_svr4_solib): Update.
9985
9986 2019-05-08  Tom Tromey  <tom@tromey.com>
9987
9988         * remote.c (remote_pspace_data): Change type.
9989         (remote_pspace_data_cleanup): Remove.
9990         (get_remote_exec_file, set_pspace_remote_exec_file)
9991         (_initialize_remote): Update.
9992
9993 2019-05-08  Tom Tromey  <tom@tromey.com>
9994
9995         * breakpoint.c (breakpoint_objfile_key): Change type.
9996         (get_breakpoint_objfile_data): Update.
9997         (free_breakpoint_objfile_data): Remove.
9998         (_initialize_breakpoint): Update.
9999
10000 2019-05-08  Tom Tromey  <tom@tromey.com>
10001
10002         * linux-tdep.c (struct linux_info): Add initializers.
10003         (linux_inferior_data): Move.  Change type.
10004         (invalidate_linux_cache_inf): Update.
10005         (linux_inferior_data_cleanup): Remove.
10006         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10007
10008 2019-05-08  Tom Tromey  <tom@tromey.com>
10009
10010         * auxv.c (auxv_inferior_data): Move.  Change type.
10011         (auxv_inferior_data_cleanup): Remove.
10012         (invalidate_auxv_cache_inf): Rewrite.
10013         (get_auxv_inferior_data, _initialize_auxv): Update.
10014
10015 2019-05-08  Tom Tromey  <tom@tromey.com>
10016
10017         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10018         (symfile_debug_objfile_data_key): Change type.
10019         (symfile_debug_installed, debug_qf_has_symbols)
10020         (debug_qf_find_last_source_symtab)
10021         (debug_qf_forget_cached_source_info)
10022         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10023         (debug_qf_print_stats, debug_qf_dump)
10024         (debug_qf_expand_symtabs_for_function)
10025         (debug_qf_expand_all_symtabs)
10026         (debug_qf_expand_symtabs_with_fullname)
10027         (debug_qf_map_matching_symbols)
10028         (debug_qf_expand_symtabs_matching)
10029         (debug_qf_find_pc_sect_compunit_symtab)
10030         (debug_qf_map_symbol_filenames)
10031         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10032         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10033         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10034         (debug_sym_read_linetable, debug_sym_relocate): Update.
10035         (symfile_debug_free_objfile): Remove.
10036         (install_symfile_debug_logging, _initialize_symfile_debug):
10037         Update.
10038
10039 2019-05-08  Tom Tromey  <tom@tromey.com>
10040
10041         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10042         allocate_on_obstack.
10043         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10044         (get_dwarf2_per_objfile): Update.
10045         (set_dwarf2_per_objfile): Remove.
10046         (dwarf2_has_info, dwarf2_get_section_info): Update.
10047         (dwarf2_free_objfile): Remove.
10048         (_initialize_dwarf2_read): Update.
10049
10050 2019-05-08  Tom Tromey  <tom@tromey.com>
10051
10052         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10053         initializers.
10054         <unsupported_script_warning_printed,
10055         script_not_found_warning_printed>: Now bool.
10056         (auto_load_pspace_data): Change type.
10057         (~auto_load_pspace_info): Rename from
10058         auto_load_pspace_data_cleanup.
10059         (get_auto_load_pspace_data, init_loaded_scripts_info)
10060         (clear_section_scripts, maybe_print_unsupported_script_warning)
10061         (maybe_print_script_not_found_warning, _initialize_auto_load):
10062         Update.
10063
10064 2019-05-08  Tom Tromey  <tom@tromey.com>
10065
10066         * objfiles.c (objfile_pspace_info): Add destructor and
10067         initializers.
10068         (objfiles_pspace_data): Change type.
10069         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10070         (get_objfile_pspace_data): Update.
10071         (objfiles_bfd_data): Change type.
10072         (get_objfile_bfd_data): Update.
10073         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10074
10075 2019-05-08  Tom Tromey  <tom@tromey.com>
10076
10077         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10078         Change type.
10079         (get_catch_syscall_inferior_data): Update.
10080         (catch_syscall_inferior_data_cleanup): Remove.
10081         (_initialize_break_catch_syscall): Update.
10082
10083 2019-05-08  Tom Tromey  <tom@tromey.com>
10084
10085         * inflow.c (struct terminal_info): Add destructor and
10086         initializers.
10087         (inflow_inferior_data): Change type.
10088         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10089         (get_inflow_inferior_data, inflow_inferior_exit)
10090         (swap_terminal_info, _initialize_inflow): Update.
10091
10092 2019-05-08  Tom Tromey  <tom@tromey.com>
10093
10094         * target-dcache.c (target_dcache_cleanup): Remove.
10095         (target_dcache_aspace_key): Change type.
10096         (target_dcache_init_p, target_dcache_invalidate)
10097         (target_dcache_get, target_dcache_get_or_init)
10098         (_initialize_target_dcache): Update.
10099         * dcache.h (struct dcache_deleter): New.
10100
10101 2019-05-08  Tom Tromey  <tom@tromey.com>
10102
10103         * symtab.c (struct symbol_cache): Add destructor and
10104         initializers.
10105         (symbol_cache_key): Move.  Change type.
10106         (make_symbol_cache, free_symbol_cache): Remove.
10107         (get_symbol_cache): Update.
10108         (symbol_cache_cleanup): Remove.
10109         (ALL_PSPACES, symbol_cache_flush)
10110         (maintenance_print_symbol_cache)
10111         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10112         Update.
10113
10114 2019-05-08  Tom Tromey  <tom@tromey.com>
10115
10116         * symtab.c (struct main_info): Add destructor and initializers.
10117         (main_progspace_key): Move.  Change type.
10118         (get_main_info): Update.
10119         (main_info_cleanup): Remove.
10120         (_initialize_symtab): Update.
10121
10122 2019-05-08  Tom Tromey  <tom@tromey.com>
10123
10124         * registry.h (DECLARE_REGISTRY): Define the _key class.
10125
10126 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10127
10128         * NEWS: Merge two 'New commands' sections.
10129
10130 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10131
10132         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10133         parameter and use Ada language definition instead.
10134         (ada_val_print_ptr): Remove unused language parameter.
10135         (ada_val_print_num): Remove language parameter and use Ada language
10136         definition instead.
10137         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10138         parameter.
10139         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10140         parameter and use Ada language definition instead.
10141         (ada_val_print_1): Update all ada_val_print_xxx calls.
10142         Remove language parameter.
10143         (ada_val_print): Update ada_val_print_1 call.
10144
10145 2019-05-08  Tom Tromey  <tromey@adacore.com>
10146
10147         * remote.c (remote_hw_watchpoint_limit)
10148         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10149         Now static.
10150
10151 2019-05-08  Tom Tromey  <tromey@adacore.com>
10152
10153         * maint.c (_initialize_maint_cmds): Move initialization code to
10154         remote.c.
10155         (watchdog, show_watchdog): Move to remote.c.
10156         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10157         "watchdog" static.
10158         (_initialize_remote): Move initialization code from maint.c.
10159         * defs.h (watchdog): Don't declare.
10160
10161 2019-05-08  Tom Tromey  <tromey@adacore.com>
10162
10163         * tui/tui-interp.c: Include main.h.
10164         * interps.c: Include main.h.
10165         * main.h (interpreter_p): Declare.
10166         * defs.h (interpreter_p): Don't declare.
10167
10168 2019-05-08  Tom Tromey  <tromey@adacore.com>
10169
10170         * dwarf2loc.c: Include dwarf2read.h.
10171         * defs.h (read_unsigned_leb128): Don't declare.
10172         * dwarf2read.h (read_unsigned_leb128): Declare.
10173
10174 2019-05-08  Tom Tromey  <tromey@adacore.com>
10175
10176         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10177         method.
10178
10179 2019-05-08  Tom Tromey  <tromey@adacore.com>
10180
10181         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10182         when no wrap column is set.
10183
10184 2019-05-08  Tom Tromey  <tromey@adacore.com>
10185
10186         * c-lang.c (c_get_string): Handle non-C-style arrays.
10187
10188 2019-05-08  Tom Tromey  <tromey@adacore.com>
10189
10190         * typeprint.c (print_offset_data::update): Print the bit offset,
10191         not the number of bits remaining.
10192
10193 2019-05-08  Tom Tromey  <tromey@adacore.com>
10194
10195         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10196         padding at end of comment.
10197
10198 2019-05-08  Tom Tromey  <tromey@adacore.com>
10199
10200         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10201         Compare main types.
10202
10203 2019-05-06  Tom Tromey  <tom@tromey.com>
10204
10205         * common/scoped_mmap.c: Include common-defs.h.
10206         * common/scoped_mmap.h: Don't include config.h.
10207
10208 2019-05-04  Tom Tromey  <tom@tromey.com>
10209
10210         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10211         (struct aarch64_call_info): Add initializers.
10212         <si>: Now a std::vector.
10213         (pass_on_stack, aarch64_push_dummy_call): Update.
10214
10215 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10216             Tom Tromey  <tom@tromey.com>
10217
10218         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10219         (ppc_threads): Now a std::vector.  Now static.
10220         (hwdebug_find_thread_points_by_tid)
10221         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10222         Update.
10223
10224 2019-05-04  Tom Tromey  <tom@tromey.com>
10225
10226         * arc-tdep.c (arc_tdesc_init): Return bool.
10227
10228 2019-05-04  Tom Tromey  <tom@tromey.com>
10229
10230         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10231         Use gdb_assert_not_reached.
10232
10233 2019-05-04  Tom Tromey  <tom@tromey.com>
10234
10235         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10236         "false".
10237
10238 2019-05-04  Tom Tromey  <tom@tromey.com>
10239
10240         * arc-tdep.c (arc_tdesc_init): Use bool.
10241
10242 2019-05-04  Tom Tromey  <tom@tromey.com>
10243
10244         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10245
10246 2019-05-04  Tom Tromey  <tom@tromey.com>
10247
10248         * cli/cli-cmds.c (valid_command_p): Return bool.
10249
10250 2019-05-04  Tom Tromey  <tom@tromey.com>
10251
10252         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10253         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10254
10255 2019-05-04  Raul Tambre  <raul@tambre.ee>
10256
10257         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10258         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10259         operator for comparison.
10260
10261 2019-05-04  Tom Tromey  <tom@tromey.com>
10262
10263         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10264         (lookup_partial_symbol, print_partial_symbols)
10265         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10266         (psymbol_compare): Update.
10267         (add_psymbol_to_bcache): Clear the entire psymbol.
10268         (maintenance_check_psymtabs): Update.
10269         * psympriv.h (struct partial_symbol): Don't derive from
10270         general_symbol_info.
10271         <obj_section, unrelocated_address, address,
10272         set_unrelocated_address>: Update.
10273         <ginfo>: New member.
10274         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10275         (debug_names::write_psymbols): Update.
10276
10277 2019-05-04  Tom de Vries  <tdevries@suse.de>
10278
10279         * contrib/cc-with-tweaks.sh: Support -n arg.
10280
10281 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10282
10283         * corelow.c (core_target::detach): Ensure frame cache and
10284         register caches are cleared.
10285         inferior.c (exit_inferior_1): Likewise.
10286
10287 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10288             Tom Tromey  <tom@tromey.com>
10289
10290         * dictionary.c (collate_pending_symbols_by_language): Remove
10291         "struct" from foreach.
10292         * symtab.c (lookup_global_symbol_from_objfile)
10293         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10294         foreach.
10295         * ser-tcp.c (net_open): Remove "struct" from foreach.
10296         * objfiles.c (objfile_relocate, objfile_rebase)
10297         (objfile_has_symbols): Remove "struct" from foreach.
10298         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10299         from foreach.
10300         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10301         foreach.
10302         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10303         "struct" from foreach.
10304         * ada-lang.c (create_excep_cond_exprs)
10305         (ada_exception_catchpoint_cond_string): Remove "struct" from
10306         foreach.
10307
10308 2019-05-03  Tom Tromey  <tromey@adacore.com>
10309
10310         * ada-exp.y (convert_char_literal): Check suffix of each
10311         enumerator.
10312
10313 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10314
10315         PR ada/21406:
10316         * ada-exp.y (yywrap): Don't define.
10317         * ada-lex.l (%option): Add noyywrap
10318         (yywrap): Remove.
10319
10320 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10321
10322         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10323         _WIN32_WINNT to the XP level, unless already defined to a higher
10324         level.
10325
10326         * unittests/parse-connection-spec-selftests.c:
10327         * ser-tcp.c:
10328         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10329         override.
10330
10331         * symfile.c (find_separate_debug_file): Remove colon from the
10332         drive spec of DOS/Windows file names of the target, so that the
10333         file name produced from DEBUGDIR and the target's directory will
10334         be valid on DOS/Windows systems.
10335
10336 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10337
10338         * rust-lang.c (val_print_struct): Handle printing structures
10339         containing strings.
10340
10341 2019-05-02  Tom Tromey  <tromey@adacore.com>
10342
10343         * valarith.c (_initialize_valarith): Remove.
10344
10345 2019-05-01  Tom Tromey  <tromey@adacore.com>
10346
10347         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10348         bitfields.
10349
10350 2019-05-01  Tom Tromey  <tromey@adacore.com>
10351
10352         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10353         for big-endian copies.
10354
10355 2019-04-30  Ali Tamur  <tamur@google.com>
10356         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10357         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10358         (read_3_bytes): New function.
10359
10360 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10361
10362         * windows-nat.c (main_thread_id): Delete.
10363         (handle_output_debug_string): Replace main_thread_id by
10364         current_event.dwThreadId.
10365         (fake_create_process): Likewise.
10366         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10367         Do not set main_thread_id.
10368         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10369         current_event.dwThreadId.
10370         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10371
10372 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10373
10374         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10375         Use current_event.dwThreadId instead of main_thread_id.
10376
10377 2019-04-30  Tom Tromey  <tromey@adacore.com>
10378
10379         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10380         (create_excep_cond_exprs): Iterate over program spaces.
10381         (ada_exception_catchpoint_cond_string): Examine all minimal
10382         symbols for exception types.
10383
10384 2019-04-30  Tom Tromey  <tromey@adacore.com>
10385
10386         PR c++/24470:
10387         * dwarf2read.c (process_structure_scope): Handle case where type
10388         has template parameters but no symbol was created.
10389
10390 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10391             Chris January  <chris.january@arm.com>
10392
10393         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10394         qualifier.
10395         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10396
10397 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10398
10399         * f-typeprint.c (f_print_type): Update rules for printing
10400         whitespace.
10401         (f_type_print_varspec_suffix): Likewise.
10402
10403 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10404             Chris January  <chris.january@arm.com>
10405
10406         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10407         function arguments.
10408
10409 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10410
10411         * f-lang.c (build_fortran_types): Change name of void type to
10412         lower case.
10413         * f-typeprint.c (f_type_print_base): Print the name of the void
10414         type, rather than a fixed string.
10415         * f-valprint.c (f_decorations): Use lower case void string.
10416
10417 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10418             Chris January  <chris.january@arm.com>
10419
10420         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10421         types for Fortran.
10422
10423 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10424             Chris January  <chris.january@arm.com>
10425             David Lecomber  <david.lecomber@arm.com>
10426
10427         * f-exp.y (BINOP_INTRINSIC): New token.
10428         (exp): New parser rule handling BINOP_INTRINSIC.
10429         (f77_keywords): Add new builtin procedures.
10430         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10431         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10432         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10433         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10434         (print_unop_subexp_f): New function.
10435         (print_binop_subexp_f): New function.
10436         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10437         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10438         (dump_subexp_body_f): Likewise.
10439         (operator_check_f): Likewise.
10440         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10441         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10442
10443 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10444
10445         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10446         UNOP_KIND.
10447         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10448         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10449         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10450         (operator_length_f): New fuction.
10451         (print_subexp_f): New function.
10452         (op_name_f): New function.
10453         (dump_subexp_body_f): New function.
10454         (operator_check_f): New function.
10455         (exp_descriptor_f): Replace standard expression handling functions
10456         with new functions.
10457         * gdb/fortran-operator.def: New file.
10458         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10459         * gdb/std-operator.def: Remove UNOP_KIND.
10460
10461 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10462
10463         * std-operator.def: Remove unbalanced, stray double quote
10464         character.
10465
10466 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10467             Chris January  <chris.january@arm.com>
10468             Daniel Everett  <daniel.everett@arm.com>
10469             Nick Forrington  <nick.forrington@arm.com>
10470             Richard Bunt  <richard.bunt@arm.com>
10471
10472         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10473         of depth when printing anonymous structs or unions.
10474         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10475         Don't print either the top-level value, or the children if the
10476         max-depth is exceeded.
10477         (ppscm_print_children): When printing the key of a map, allow one
10478         extra level of depth.
10479         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10480         print either the top-level value, or the children if the max-depth
10481         is exceeded.
10482         (print_children): When printing the key of a map, allow one extra
10483         level of depth.
10484         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10485         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10486         (user_print_options): Initialise max_depth field.
10487         (val_print_scalar_or_string_type_p): New function.
10488         (val_print): Check to see if the max depth has been reached.
10489         (val_print_check_max_depth): Define new function.
10490         (show_print_max_depth): New function.
10491         (_initialize_valprint): Add 'print max-depth' option.
10492         * valprint.h (struct value_print_options) <max_depth>: New field.
10493         (val_print_check_max_depth): Declare new function.
10494         * NEWS: Document new feature.
10495
10496 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10497
10498         * ada-lang.c (ada_language_defn): Initialise new field.
10499         * c-lang.c (c_is_string_type_p): New function.
10500         (c_language_defn): Initialise new field.
10501         (cplus_language_defn): Initialise new field.
10502         (asm_language_defn): Initialise new field.
10503         (minimal_language_defn): Initialise new field.
10504         * c-lang.h (c_is_string_type_p): Declare new function.
10505         * d-lang.c (d_language_defn): Initialise new field.
10506         * f-lang.c (f_is_string_type_p): New function.
10507         (f_language_defn): Initialise new field.
10508         * go-lang.c (go_is_string_type_p): New function.
10509         (go_language_defn): Initialise new field.
10510         * language.c (default_is_string_type_p): New function.
10511         (unknown_language_defn): Initialise new field.
10512         (auto_language_defn): Initialise new field.
10513         * language.h (struct language_defn) <la_is_string_type_p>: New
10514         member variable.
10515         (default_is_string_type_p): Declare new function.
10516         * m2-lang.c (m2_language_defn): Initialise new field.
10517         * objc-lang.c (objc_language_defn): Initialise new field.
10518         * opencl-lang.c (opencl_language_defn): Initialise new field.
10519         * p-lang.c (pascal_is_string_type_p): New function.
10520         (pascal_language_defn): Initialise new field.
10521         * rust-lang.c (rust_is_string_type_p): New function.
10522         (rust_language_defn): Initialise new field.
10523
10524 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10525
10526         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10527         New field.
10528         * ada-lang.c (ada_language_defn): Initialise new field.
10529         * c-lang.c (c_language_defn): Likewise.
10530         (cplus_language_defn): Likewise.
10531         (asm_language_defn): Likewise.
10532         (minimal_language_defn): Likewise.
10533         * d-lang.c (d_language_defn): Likewise.
10534         * f-lang.c (f_language_defn): Likewise.
10535         * go-lang.c (go_language_defn): Likewise.
10536         * language.c (unknown_language_defn): Likewise.
10537         (auto_language_defn): Likewise.
10538         * m2-lang.c (m2_language_defn): Likewise.
10539         * objc-lang.c (objc_language_defn): Likewise.
10540         * opencl-lang.c (opencl_language_defn): Likewise.
10541         * p-lang.c (pascal_language_defn): Likewise.
10542         * rust-lang.c (rust_language_defn): Likewise.
10543
10544 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10545
10546         * ada-lang.c (ada_is_character_type): Change return type to bool.
10547         (ada_is_string_type): Likewise.
10548         * ada-lang.h (ada_is_character_type): Update declaration
10549         (ada_is_string_type): Likewise.
10550
10551 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10552
10553         Support style in 'frame|thread apply'
10554
10555         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10556         * record.c (record_start, record_stop): Update callers of
10557         execute_command_to_string with false.
10558         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10559         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10560         methods.
10561         (class string_file): New constructor with term_out parameter.
10562         Override methods term_out and can_emit_style_escape.  New member
10563         term_out.
10564         (class stdio_file): Override can_emit_style_escape.
10565         (class tee_file): Override term_out and can_emit_style_escape.
10566         * utils.h (can_emit_style_escape): Remove.
10567         * utils.c (can_emit_style_escape): Likewise.
10568         Update all callers of can_emit_style_escape (SOMESTREAM) to
10569         SOMESTREAM->can_emit_style_escape.
10570         * source-cache.c (source_cache::get_source_lines): Likewise.
10571         * stack.c (frame_apply_command_count): Call execute_command_to_string
10572         passing the term_out characteristic of the current gdb_stdout.
10573         * thread.c (thr_try_catch_cmd): Likewise.
10574         * top.c (execute_command_to_string): pass term_out parameter
10575         to construct the string_file for the command output.
10576         * ui-file.c (term_cli_styling): New function (most code moved
10577         from utils.c can_emit_style_escape).
10578         (string_file::string_file, string_file::can_emit_style_escape,
10579         stdio_file::can_emit_style_escape, tee_file::term_out,
10580         tee_file::can_emit_style_escape): New functions.
10581
10582 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10583
10584         * NEWS: Mention the new set|show may-call-functions.
10585         * infcall.c (may_call_functions_p): New variable.
10586         (show_may_call_functions_p): New function.
10587         (call_function_by_hand_dummy): Throws an error if not
10588         may-call-functions.
10589         (_initialize_infcall): Call add_setshow_boolean_cmd for
10590         may-call-functions.
10591
10592 2019-04-25  Keith Seitz  <keiths@redhat.com>
10593
10594         PR c++/24367
10595         * cp-support.c (inspect_type): Don't attempt substitutions
10596         of symbol with the same name.
10597
10598 2019-04-25  Tom Tromey  <tromey@adacore.com>
10599
10600         PR gdb/24475:
10601         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10602         static.
10603
10604 2019-04-25  Tom Tromey  <tromey@adacore.com>
10605
10606         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10607         rvalue reference.
10608         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10609         (gdb_xml_parser::parse): Use std::move.
10610         * python/python-internal.h (gdbpy_convert_exception): Take a const
10611         reference.
10612         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10613         std::move.
10614         * python/py-utils.c (gdbpy_convert_exception): Take a const
10615         reference.
10616         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10617         Use std::move.
10618         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10619         Use std::move.
10620         * mi/mi-main.c (mi_print_exception): Take a const reference.
10621         * main.c (handle_command_errors): Take a const reference.
10622         * linespec.c (parse_linespec): Use std::move.
10623         * infcall.c (run_inferior_call): Use std::move.
10624         (call_function_by_hand_dummy): Use std::move.
10625         * exec.c (try_open_exec_file): Use std::move.
10626         * exceptions.h (exception_print, exception_fprintf)
10627         (exception_print_same): Update.
10628         * exceptions.c (print_exception, exception_print)
10629         (exception_fprintf, exception_print_same): Change parameters to
10630         const reference.
10631         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10632         * common/new-op.c: Use std::move.
10633         * common/common-exceptions.h (struct gdb_exception): Add move
10634         constructor.
10635         (struct gdb_exception_error, struct gdb_exception_quit, struct
10636         gdb_quit_bad_alloc): Change constructor to move constructor.
10637         (throw_exception): Change parameter to rvalue reference.
10638         * common/common-exceptions.c (throw_exception): Take rvalue
10639         reference.
10640         * cli/cli-interp.c (safe_execute_command): Use std::move.
10641         * breakpoint.c (insert_bp_location, location_to_sals): Use
10642         std::move.
10643
10644 2019-04-25  Tom Tromey  <tromey@adacore.com>
10645
10646         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10647         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10648         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10649         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10650         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10651         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10652         guile/scm-value.c: Use unpack.
10653         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10654         gdbscm_gdb_exception.
10655         (gdbscm_throw_gdb_exception): Likewise.
10656         (struct gdbscm_gdb_exception): New.
10657         (unpack): New function.
10658         (gdbscm_wrap): Use unpack.
10659
10660 2019-04-25  Tom Tromey  <tromey@adacore.com>
10661
10662         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10663         (gdb_rl_callback_handler): Use std::move.
10664         * common/common-exceptions.h (struct gdb_exception): Add move
10665         assignment operator.
10666         (throw_exception_sjlj): Change "exception" to const reference.
10667         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10668         (throw_exception_sjlj): Change "exception" to const reference.
10669
10670 2019-04-25  Tom Tromey  <tromey@adacore.com>
10671
10672         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10673         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10674         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10675         Update.
10676         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10677         Update.
10678         * mi/mi-interp.c (mi_interp::exec): Update.
10679         * linespec.c (parse_linespec): Update.
10680         * infcall.c (run_inferior_call): Update.
10681         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10682         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10683         (gdbscm_lookup_global_symbol): Update.
10684         * guile/scm-param.c (gdbscm_parameter_value): Update.
10685         * guile/scm-frame.c (gdbscm_frame_read_register)
10686         (gdbscm_frame_read_var): Update.
10687         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10688         * exec.c (try_open_exec_file): Update.
10689         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10690         (gdb_rl_callback_handler): Update.
10691         * common/common-exceptions.h (exception_none): Don't declare.
10692         * common/common-exceptions.c (exception_none): Don't define.
10693         (struct catcher) <exception>: Update.
10694         * cli/cli-interp.c (safe_execute_command): Update.
10695         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10696
10697 2019-04-25  Ali Tamur  <tamur@google.com>
10698
10699         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10700         (read_attribute_value): Likewise.
10701         (dwarf2_read_addr_index): Update comment.
10702         (read_str_index): Add DW_FORM_strx.
10703         (dwarf2_string_attr): Likewise.
10704         (dwarf2_const_value_attr): Likewise.
10705         (dump_die_shallow): Likewise.
10706         (dwarf2_fetch_constant_bytes): Likewise.
10707         (skip_form_bytes): Likewise.
10708         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10709
10710 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10711
10712         PR corefiles/11608
10713         PR corefiles/18187
10714         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10715         OFFSET.  Verify if current mapping contains an ELF header.
10716         (linux_find_memory_regions_full): Adjust call to
10717         dump_mapping_p.
10718
10719 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10720             Kang Li <kanglictf@gmail.com>
10721
10722         PR gdb/21600
10723
10724         * dwarf2-frame.c (read_initial_length): Be consistent about using
10725         unsigned representation of length.
10726         (decode_frame_entry_1): Likewise.  Check for wraparound of
10727         end pointer as well as buffer overflow.
10728
10729 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10730
10731         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10732         "vq".
10733
10734 2019-04-24  Tom Tromey  <tromey@adacore.com>
10735
10736         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10737
10738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10739
10740         * s12z-tdep.c (s12z_unwind_pc): Delete.
10741         (s12z_unwind_sp): Delete.
10742         (s12z_gdbarch_init): Don't register deleted functions with
10743         gdbarch.
10744
10745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10746
10747         * rl78-tdep.c (rl78_unwind_sp): Delete.
10748         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10749
10750 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10751
10752         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10753         (xstormy16_unwind_pc): Delete.
10754         (xstormy16_dummy_id): Delete.
10755         (xstormy16_gdbarch_init): Don't register deleted functions with
10756         gdbarch.
10757
10758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10759
10760         * vax-tdep.c (vax_unwind_pc): Delete.
10761         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10762
10763 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10764
10765         * v850-tdep.c (v850_unwind_sp): Delete.
10766         (v850_unwind_pc): Delete.
10767         (v850_dummy_id): Delete.
10768         (v850_gdbarch_init): Don't register deleted functions with
10769         gdbarch.
10770
10771 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10772
10773         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10774         (tilegx_unwind_pc): Delete.
10775         (tilegx_unwind_dummy_id): Delete.
10776         (tilegx_gdbarch_init): Don't register deleted functions with
10777         gdbarch.
10778
10779 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10780
10781         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10782         (tic6x_dummy_id): Delete.
10783         (tic6x_gdbarch_init): Don't register deleted functions with
10784         gdbarch.
10785
10786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10787
10788         * sparc-tdep.c (sparc_unwind_pc): Delete.
10789         (sparc32_gdbarch_init): Don't register deleted function with
10790         gdbarch.
10791
10792 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10793
10794         * sh-tdep.c (sh_unwind_sp): Delete.
10795         (sh_unwind_pc): Delete.
10796         (sh_dummy_id): Delete.
10797         (sh_gdbarch_init): Don't register deleted functions with
10798         gdbarch.
10799
10800 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10801
10802         * score-tdep.c (score_unwind_sp): Delete.
10803         (score_unwind_pc): Delete.
10804         (score_dummy_id): Delete.
10805         (score_gdbarch_init): Don't register deleted functions with
10806         gdbarch.
10807
10808 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10809
10810         * rx-tdep.c (rx_unwind_pc): Delete.
10811         (rx_unwind_sp): Delete.
10812         (rx_dummy_id): Delete.
10813         (rx_gdbarch_init): Don't register deleted functions with
10814         gdbarch.  Update comment.
10815
10816 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10817
10818         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10819         (rs6000_dummy_id): Delete.
10820         (rs6000_gdbarch_init): Don't register deleted functions with
10821         gdbarch.
10822
10823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10824
10825         * or1k-tdep.c (or1k_dummy_id): Delete.
10826         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10827
10828 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10829
10830         * nios2-tdep.c (nios2_dummy_id): Delete.
10831         (nios2_unwind_sp): Delete.
10832         (nios2_gdbarch_init): Don't register deleted functions with
10833         gdbarch.
10834
10835 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10836
10837         * nds32-tdep.c (nds32_dummy_id): Delete.
10838         (nds32_unwind_pc): Delete.
10839         (nds32_unwind_sp): Delete.
10840         (nds32_gdbarch_init): Don't register deleted functions with
10841         gdbarch.
10842
10843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10844
10845         * msp430-tdep.c (msp430_unwind_pc): Delete.
10846         (msp430_unwind_sp): Delete.
10847         (msp430_dummy_id): Delete.
10848         (msp430_gdbarch_init): Don't register deleted functions with
10849         gdbarch.
10850
10851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10852
10853         * moxie-tdep.c (moxie_unwind_sp): Delete.
10854         (moxie_unwind_pc): Delete.
10855         (moxie_dummy_id): Delete.
10856         (moxie_gdbarch_init): Don't register deleted functions with
10857         gdbarch.
10858
10859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10860
10861         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10862         (mn10300_unwind_pc): Delete.
10863         (mn10300_unwind_sp): Delete.
10864         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10865         mn10300_unwind_sp.
10866         (mn10300_frame_unwind_init): Don't register deleted functions with
10867         gdbarch.
10868
10869 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10870
10871         * mep-tdep.c (mep_unwind_pc): Delete.
10872         (mep_unwind_sp): Delete.
10873         (mep_dummy_id): Delete.
10874         (mep_gdbarch_init): Don't register deleted functions with
10875         gdbarch.
10876
10877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10878
10879         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10880         (m68hc11_unwind_sp): Delete.
10881         (m68hc11_gdbarch_init): Don't register deleted functions with
10882         gdbarch.
10883
10884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10885
10886         * m32r-tdep.c (m32r_unwind_sp): Delete.
10887         (m32r_unwind_pc): Delete.
10888         (m32r_dummy_id): Delete.
10889         (m32r_gdbarch_init): Don't register deleted functions with
10890         gdbarch.
10891
10892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10893
10894         * m32c-tdep.c (m32c_unwind_pc): Delete.
10895         (m32c_unwind_sp): Delete.
10896         (m32c_dummy_id): Delete.
10897         (m32c_gdbarch_init): Don't register deleted functions with
10898         gdbarch.
10899
10900 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10901
10902         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10903         (lm32_unwind_pc): Delete.
10904         (lm32_dummy_id): Delete.
10905         (lm32_gdbarch_init): Don't register deleted functions with
10906         gdbarch.
10907
10908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10909
10910         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10911         (iq2000_unwind_pc): Delete.
10912         (iq2000_dummy_id): Delete.
10913         (iq2000_gdbarch_init): Don't register deleted functions with
10914         gdbarch.
10915
10916 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10917
10918         * nds32-tdep.c (nds32_type_align): Delete.
10919         (nds32_push_dummy_call): Use type_align instead.
10920
10921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10922
10923         * arm-tdep.c (arm_type_align): Only handle vector override case.
10924         (arm_push_dummy_call): Use type_align.
10925         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10926
10927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10928
10929         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10930         case.
10931         (pass_on_stack): Use type_align.
10932         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10933         function.
10934
10935 2019-04-23  Tom Tromey  <tromey@adacore.com>
10936
10937         * dwarf2read.c (line_header::file_name_at): Remove unused
10938         overload.
10939
10940 2019-04-23  Tom de Vries  <tdevries@suse.de>
10941
10942         PR gdb/24438
10943         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10944         invocation.
10945
10946
10947 2019-03-27  Ali Tamur  <tamur@google.com>
10948
10949         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10950         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10951         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10952         (dwarf_expr_context::get_addr_index): Likewise
10953         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10954         (symbol_needs_eval_context::get_addr_index): Likewise
10955         (disassemble_dwarf_expression): Add DW_OP_addrx
10956         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10957         (read_cutu_die_from_dwo): Update comment
10958         (skip_one_die): Add DW_FORM_addrx
10959         (read_attribute_value): Likewise
10960         (var_decode_location): Add DW_OP_addrx
10961         (dwarf2_const_value_attr): Add DW_FORM_addrx
10962         (dump_die_shallow): Likewise
10963         (dwarf2_fetch_constant_bytes): Likewise
10964         (decode_locdesc): Add DW_OP_addrx
10965         (skip_form_bytes): Add DW_FORM_addrx
10966
10967 2019-04-22  Ali Tamur  <tamur@google.com>
10968
10969         * MAINTAINERS (Write After Approval): Add self.
10970
10971 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10972
10973         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10974         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10975         (open_symbol_file_object): Likewise.
10976         (svr4_default_sos): Add info parameter.
10977         (svr4_read_so_list): Likewise.
10978         (svr4_current_sos_direct): Adjust functions calls to pass down
10979         info.
10980         (svr4_current_sos_1): Add info parameter.
10981         (svr4_current_sos): Call get_svr4_info, pass info down to
10982         svr4_current_sos_1.
10983         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10984         get_svr4_info.
10985         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10986         get_svr4_info.
10987         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10988         to get_svr4_info.
10989         (probes_table_remove_objfile_probes): Likewise.
10990         (register_solib_event_probe): Add info parameter.
10991         (solist_update_incremental): Pass info parameter down to
10992         svr4_read_so_list.
10993         (disable_probes_interface): Add info parameter.
10994         (svr4_handle_solib_event): Pass current_program_space to
10995         get_svr4_info.  Adjust disable_probes_interface cleanup.
10996         (svr4_create_probe_breakpoints): Add info parameter, pass it
10997         down to register_solib_event_probe.
10998         (svr4_create_solib_event_breakpoints): Add info parameter,
10999         pass it down to svr4_create_probe_breakpoints.
11000         (enable_break): Pass info down to
11001         svr4_create_solib_event_breakpoints.
11002         (svr4_solib_create_inferior_hook): Pass current_program_space to
11003         get_svr4_info.
11004         (svr4_clear_solib): Likewise.
11005
11006 2019-04-22  Pedro Alves  <palves@redhat.com>
11007
11008         * solib-svr4.c (svr4_free_objfile_observer): New.
11009         (probe_and_action::objfile): New field.
11010         (probes_table_htab_remove_objfile_probes)
11011         (probes_table_remove_objfile_probes): New functions.
11012         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11013         in the new probe_and_action.  Don't store the probe in 'lookup'.
11014         (svr4_create_probe_breakpoints): Pass objfile to
11015         register_solib_event_probe.
11016         (_initialize_svr4_solib): Register a free_objfile observer.
11017
11018 2019-04-19  Tom Tromey  <tom@tromey.com>
11019
11020         * common/queue.h: Remove.
11021
11022 2019-04-19  Tom Tromey  <tom@tromey.com>
11023
11024         * event-loop.c: Don't include "common/queue.h".
11025
11026 2019-04-19  Tom Tromey  <tom@tromey.com>
11027
11028         * remote.c (remote_target): Use delete.
11029         * remote-notif.h: Include <list>, not "common/queue.h".
11030         (notif_client_p): Remove typedef.
11031         (remote_notif_state): Add constructor, destructor, initializer.
11032         <notif_queue>: Now a std::list.
11033         (remote_notif_state_xfree): Don't declare.
11034         * remote-notif.c (remote_notif_process, handle_notification)
11035         (remote_notif_state_allocate): Update.
11036         (~remote_notif_state): Rename from remote_notif_state_xfree.
11037
11038 2019-04-19  Tom Tromey  <tom@tromey.com>
11039
11040         * symfile.c (reread_symbols): Update.
11041         * objfiles.c (objfile_register_static_link)
11042         (objfile_lookup_static_link): Update
11043         (~objfile) Don't delete static_links.
11044         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11045
11046 2019-04-19  Tom Tromey  <tom@tromey.com>
11047
11048         * type-stack.h (struct type_stack) <insert>: Constify string.
11049         * type-stack.c (type_stack::insert): Constify string.
11050         * gdbtypes.h (lookup_template_type): Update.
11051         (address_space_name_to_int): Update.
11052         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11053         const.
11054         (lookup_template_type): Make name const.
11055         * c-exp.y: Update rules.
11056         (lex_one_token, classify_name, classify_inner_name)
11057         (c_print_token): Update.
11058         * p-exp.y: Update rules.
11059         (yylex): Update.
11060         * f-exp.y: Update rules.
11061         (yylex): Update.
11062         * d-exp.y: Update rules.
11063         (lex_one_token, classify_name, classify_inner_name): Update.
11064         * parse.c (write_dollar_variable, copy_name): Return std::string.
11065         * parser-defs.h (copy_name): Change return type.
11066         * m2-exp.y: Update rules.
11067         (yylex): Update.
11068         * go-exp.y (lex_one_token): Update.
11069         Update rules.
11070         (classify_unsafe_function, classify_packaged_name)
11071         (classify_name, yylex): Update.
11072
11073 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11074
11075         * configure.ac: add --enable-source-highlight switch.
11076         * configure: Regenerate.
11077         * top.c (print_gdb_version): plumb --enable-source-highlight
11078         status to "show configuration".
11079
11080 2019-04-19  Tom Tromey  <tromey@adacore.com>
11081
11082         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11083         Check ADA_TYPE_P.
11084         (empty_record, ada_template_to_fixed_record_type_1)
11085         (template_to_static_fixed_type)
11086         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11087         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11088         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11089         macros.
11090
11091 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11092
11093         PR symtab/24423:
11094         * source.c (print_source_lines_base): Advance "iter" when a
11095         control character is seen.
11096
11097 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11098
11099         * inferior.h (struct infcall_suspend_state_deleter):
11100         Catch exception in destructor to avoid crash.
11101
11102 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11103
11104         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11105         close to the add_com "shell".
11106
11107 2019-04-18  Tom Tromey  <tromey@adacore.com>
11108
11109         * process-stratum-target.h (class process_stratum_target)
11110         <stratum>: Add "final".
11111
11112 2019-04-17  Tom Tromey  <tromey@adacore.com>
11113
11114         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11115         against nullptr before use.
11116
11117 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11118
11119         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11120
11121 2019-04-17  Jim Wilson  <jimw@sifive.com>
11122             Andrew Burgess  <andrew.burgess@embecosm.com>
11123
11124         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11125         code read might fail, assume 4-byte breakpoint in that case.
11126
11127 2019-04-15  Leszek Swirski  <leszeks@google.com>
11128
11129         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11130         rather than a hand-rolled POD check when checking for forced MEMORY
11131         classification.
11132
11133 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11134
11135         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11136         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11137         function.
11138         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11139         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11140         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11141         declaration.
11142
11143 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11144
11145         * aarch64-linux-nat.c
11146         (aarch64_linux_nat_target::thread_architecture): Add override.
11147         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11148         each VQ.
11149
11150 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11151
11152         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11153
11154 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11155
11156         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11157         target types of size 96-bits, add some additional comments, and
11158         check that the builtin type we found was the correct size.
11159
11160 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11161
11162         * utils.c (prompt_for_continue): Don't restore the styling at the
11163         end, as applied_style has the wrong value.  This fixes styling in
11164         long lists of file names that are interrupted by the "Continue?"
11165         prompt.
11166
11167 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11168
11169         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11170         * c-lang.c (c_language_defn): Likewise.
11171         (cplus_language_defn): Likewise.
11172         (asm_language_defn): Likewise.
11173         (minimal_language_defn): Likewise.
11174         * d-lang.c (d_language_defn): Likewise.
11175         * f-lang.c (f_language_defn): Likewise.
11176         * go-lang.c (go_language_defn): Likewise.
11177         * language.c (unknown_language_defn): Likewise.
11178         (auto_language_defn): Likewise.
11179         * language.h (struct language_defn): Remove la_magic field.
11180         (LANG_MAGIC): Delete.
11181         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11182         * objc-lang.c (objc_language_defn): Likewise.
11183         * opencl-lang.c (opencl_language_defn): Likewise.
11184         * p-lang.c (pascal_language_defn): Likewise.
11185         * rust-lang.c (rust_language_defn): Likewise.
11186
11187 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11188
11189         * riscv-tdep.c (riscv_type_align): New function.
11190         (riscv_type_alignment): Delete.
11191         (riscv_arg_location): Use 'type_align'.
11192         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11193
11194 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11195
11196         * gdbtypes.c (type_align): A struct with no non-static fields also
11197         has alignment of 1.
11198
11199 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11200
11201         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11202         component to 0.
11203         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11204         member.
11205         (riscv_struct_info::analyse): New implementation using new
11206         analyse_inner member function.
11207         (riscv_struct_info::field_offset): New member function.
11208         (riscv_struct_info::m_offsets): New member variable.
11209         (riscv_struct_info::analyse_inner): New private member function,
11210         takes the old implementation of riscv_struct_info::analyse but
11211         extended to track field offsets.
11212         (riscv_call_arg_struct): Update the struct folding special cases
11213         to handle cases where empty C++ structs, which are non-zero
11214         length, are found.
11215         (riscv_arg_location): Initialise the length of each location, a
11216         non-zero length now indicates the location is in use.
11217         (riscv_push_dummy_call): Allow for the first location having a
11218         non-zero offset when setting up arguments.
11219         (riscv_return_value): Likewise, but for return values.
11220
11221 2019-04-11  Tom Tromey  <tromey@adacore.com>
11222
11223         * utils.c (internal_vproblem): Make "msg" const.
11224
11225 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11226
11227         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11228         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11229         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11230         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11231
11232 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11233
11234         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11235         function.
11236         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11237         of amd64_collect_native_gregset.
11238         (amd64_linux_nat_target::store_registers): Likewise.
11239
11240 2019-04-10  Tom Tromey  <tom@tromey.com>
11241
11242         * symtab.c (lookup_global_symbol_from_objfile)
11243         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11244         * objfiles.h (class separate_debug_iterator): New.
11245         (class separate_debug_range): New.
11246         (struct objfile) <separate_debug_objfiles>: New method.
11247         (objfile_separate_debug_iterate): Don't declare.
11248         * objfiles.c (separate_debug_iterator::operator++): Rename from
11249         objfile_separate_debug_iterate.
11250         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11251         iterator.
11252         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11253         iterator.
11254
11255 2019-04-10  Tom Tromey  <tom@tromey.com>
11256
11257         * symfile.c (reread_symbols): Remove old comment.
11258         * objfiles.c (free_all_objfiles): Fix a typo.
11259
11260 2019-04-10  Tom Tromey  <tom@tromey.com>
11261
11262         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11263         * minsyms.c (lookup_minimal_symbol): Use foreach.
11264         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11265         (lookup_minimal_symbol_solib_trampoline): Likewise.
11266         * symfile.c (reread_symbols): Use foreach.
11267
11268 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11269             Tom Tromey  <tromey@adacore.com>
11270
11271         PR rust/24414:
11272         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11273         (rust_lex_int_test): Change "value" to be LONGEST.
11274         (rust_lex_tests): Add test for long integer literal.
11275
11276 2019-04-09  Tom Tromey  <tromey@adacore.com>
11277
11278         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11279         to bool.
11280         (extended_remote_target::attach): Update.
11281         (remote_target::remote_notice_new_inferior): Update.
11282         (remote_target::add_current_inferior_and_thread): Update.
11283         * inferior.c (exit_inferior_1): Use "false".
11284         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11285
11286 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11287
11288         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11289         the "start" command.
11290
11291 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11292
11293         * python/py-inferior.c (infpy_thread_from_thread_handle):
11294         Adjust comments to reflect renaming of thread_from_thread_handle
11295         to thread_from_handle.  Adjust keywords.  Fix type error message.
11296         (inferior_object_methods): Add thread_from_handle.  Retain
11297         thread_from_thread_handle, but mark it as deprecated.
11298
11299 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11300
11301         * gdbthread.h (find_thread_by_handle): Revise declaration.
11302         * thread.c (find_thread_by_handle): Likewise.  Adjust
11303         implementation too.
11304         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11305         support for buffer objects as handles.
11306
11307 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11308
11309         * python/py-infthread.c (thpy_thread_handle): New function.
11310         (thread_object_methods): Register thpy_thread_handle.
11311
11312 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11313
11314         * gdbthread.h (thread_to_thread_handle): Declare.
11315         * thread.c (gdbtypes.h): Include.
11316         (thread_to_thread_handle): New function.
11317
11318         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11319         (target_thread_info_to_thread_handle): Declare.
11320         * target.c (target_thread_info_to_thread_handle): New function.
11321         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11322         * target-delegates.c: Regenerate.
11323
11324         * linux-thread-db.c (class thread_db_target): Add method
11325         thread_info_to_thread_handle.
11326         (thread_db_target::thread_info_to_thread_handle): Define.
11327         * remote.c (class remote_target): Add new method
11328         thread_info_to_thread_handle.
11329         (remote_target::thread_info_to_thread_handle): Define.
11330
11331 2019-04-08  Pedro Alves  <palves@redhat.com>
11332
11333         * common/common-exceptions.c (throw_exception): Don't create
11334         named object to throw; throw directly.
11335         (throw_it): Likewise.  Don't initialize gdb_exception::message
11336         here, with new; pass FMT and AP to the ctor instead.
11337         * common/common-exceptions.h: Include <string>.
11338         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11339         const char *, va_list)): New ctor.  Use std::make_shared.
11340         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11341         errors)): Delete.
11342         (gdb_exception_error::gdb_exception_error(enum errors, const char
11343         *, va_list)): New.
11344         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11345         Add assertion.
11346         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11347         errors)): Delete.
11348         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11349         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11350         Add assertion.
11351
11352 2019-04-08  Tom Tromey  <tom@tromey.com>
11353
11354         * valops.c (value_rtti_indirect_type): Replace throw_exception
11355         with throw.
11356         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11357         with throw.
11358         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11359         throw.
11360         * target.c (target_translate_tls_address): Replace throw_exception
11361         with throw.
11362         * stack.c (frame_apply_command_count): Replace throw_exception
11363         with throw.
11364         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11365         throw.
11366         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11367         with throw.
11368         * rs6000-tdep.c (rs6000_frame_cache)
11369         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11370         * remote.c: Replace throw_exception with throw.
11371         * record-full.c (record_full_message, record_full_wait_1)
11372         (record_full_restore): Replace throw_exception with throw.
11373         * record-btrace.c:
11374         (get_thread_current_frame_id, record_btrace_start_replaying)
11375         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11376         (cmd_record_btrace_start): Replace throw_exception with throw.
11377         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11378         throw.
11379         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11380         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11381         * linespec.c:
11382         (find_linespec_symbols): Replace throw_exception with throw.
11383         * infrun.c (displaced_step_prepare, resume): Replace
11384         throw_exception with throw.
11385         * infcmd.c (post_create_inferior): Replace throw_exception with
11386         throw.
11387         * inf-loop.c (inferior_event_handler): Replace throw_exception
11388         with throw.
11389         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11390         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11391         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11392         (get_prev_frame_always, get_frame_pc_if_available)
11393         (get_frame_address_in_block_if_available, get_frame_language):
11394         Replace throw_exception with throw.
11395         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11396         throw_exception with throw.
11397         * eval.c (fetch_subexp_value, evaluate_var_value)
11398         (evaluate_funcall, evaluate_subexp_standard): Replace
11399         throw_exception with throw.
11400         * dwarf2loc.c (call_site_find_chain)
11401         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11402         Replace throw_exception with throw.
11403         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11404         with throw.
11405         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11406         throw.
11407         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11408         * completer.c (complete_line_internal): Replace throw_exception
11409         with throw.
11410         * compile/compile-object-run.c (compile_object_run): Replace
11411         throw_exception with throw.
11412         * cli/cli-script.c (process_next_line): Replace throw_exception
11413         with throw.
11414         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11415         (btrace_enable, btrace_maint_update_pt_packets): Replace
11416         throw_exception with throw.
11417         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11418         throw_exception with throw.
11419         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11420         throw_exception with throw.
11421         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11422         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11423         * aarch64-tdep.c (aarch64_make_prologue_cache)
11424         (aarch64_make_stub_cache): Replace throw_exception with throw.
11425
11426 2019-04-08  Tom Tromey  <tom@tromey.com>
11427
11428         * common/common-exceptions.c (throw_exception): Rename from
11429         throw_exception_cxx.  Remove old copy.  Make argument const.
11430         (throw_it): Create and throw exception objects directly.
11431         * common/common-exceptions.h (throw_exception): Make argument
11432         const.
11433         (struct gdb_exception_error): Add constructor.
11434         (struct gdb_exception_quit): Add constructor.
11435
11436 2019-04-08  Tom Tromey  <tom@tromey.com>
11437
11438         * common/common-exceptions.h (exception_rethrow): Don't declare.
11439         (TRY_SJLJ): Update comment.
11440         (TRY, CATCH, END_CATCH): Remove.
11441         * common/common-exceptions.c (exception_rethrow): Remove.
11442
11443 2019-04-08  Tom Tromey  <tom@tromey.com>
11444
11445         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11446         Remove.
11447         (gdb_exception_error): Rename from
11448         gdb_exception_RETURN_MASK_ERROR.
11449         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11450         (gdb_quit_bad_alloc): Update.
11451         * aarch64-tdep.c: Update.
11452         * ada-lang.c: Update.
11453         * ada-typeprint.c: Update.
11454         * ada-valprint.c: Update.
11455         * amd64-tdep.c: Update.
11456         * arch-utils.c: Update.
11457         * break-catch-throw.c: Update.
11458         * breakpoint.c: Update.
11459         * btrace.c: Update.
11460         * c-varobj.c: Update.
11461         * cli/cli-cmds.c: Update.
11462         * cli/cli-interp.c: Update.
11463         * cli/cli-script.c: Update.
11464         * common/common-exceptions.c: Update.
11465         * common/new-op.c: Update.
11466         * common/selftest.c: Update.
11467         * compile/compile-c-symbols.c: Update.
11468         * compile/compile-cplus-symbols.c: Update.
11469         * compile/compile-object-load.c: Update.
11470         * compile/compile-object-run.c: Update.
11471         * completer.c: Update.
11472         * corelow.c: Update.
11473         * cp-abi.c: Update.
11474         * cp-support.c: Update.
11475         * cp-valprint.c: Update.
11476         * darwin-nat.c: Update.
11477         * disasm-selftests.c: Update.
11478         * dtrace-probe.c: Update.
11479         * dwarf-index-cache.c: Update.
11480         * dwarf-index-write.c: Update.
11481         * dwarf2-frame-tailcall.c: Update.
11482         * dwarf2-frame.c: Update.
11483         * dwarf2loc.c: Update.
11484         * dwarf2read.c: Update.
11485         * eval.c: Update.
11486         * event-loop.c: Update.
11487         * event-top.c: Update.
11488         * exec.c: Update.
11489         * f-valprint.c: Update.
11490         * fbsd-tdep.c: Update.
11491         * frame-unwind.c: Update.
11492         * frame.c: Update.
11493         * gdbtypes.c: Update.
11494         * gnu-v3-abi.c: Update.
11495         * guile/guile-internal.h: Update.
11496         * guile/scm-block.c: Update.
11497         * guile/scm-breakpoint.c: Update.
11498         * guile/scm-cmd.c: Update.
11499         * guile/scm-disasm.c: Update.
11500         * guile/scm-frame.c: Update.
11501         * guile/scm-lazy-string.c: Update.
11502         * guile/scm-math.c: Update.
11503         * guile/scm-param.c: Update.
11504         * guile/scm-ports.c: Update.
11505         * guile/scm-pretty-print.c: Update.
11506         * guile/scm-symbol.c: Update.
11507         * guile/scm-symtab.c: Update.
11508         * guile/scm-type.c: Update.
11509         * guile/scm-value.c: Update.
11510         * i386-linux-tdep.c: Update.
11511         * i386-tdep.c: Update.
11512         * inf-loop.c: Update.
11513         * infcall.c: Update.
11514         * infcmd.c: Update.
11515         * infrun.c: Update.
11516         * jit.c: Update.
11517         * language.c: Update.
11518         * linespec.c: Update.
11519         * linux-fork.c: Update.
11520         * linux-nat.c: Update.
11521         * linux-tdep.c: Update.
11522         * linux-thread-db.c: Update.
11523         * main.c: Update.
11524         * mi/mi-cmd-break.c: Update.
11525         * mi/mi-cmd-stack.c: Update.
11526         * mi/mi-interp.c: Update.
11527         * mi/mi-main.c: Update.
11528         * objc-lang.c: Update.
11529         * p-valprint.c: Update.
11530         * parse.c: Update.
11531         * ppc-linux-tdep.c: Update.
11532         * printcmd.c: Update.
11533         * python/py-arch.c: Update.
11534         * python/py-breakpoint.c: Update.
11535         * python/py-cmd.c: Update.
11536         * python/py-finishbreakpoint.c: Update.
11537         * python/py-frame.c: Update.
11538         * python/py-framefilter.c: Update.
11539         * python/py-gdb-readline.c: Update.
11540         * python/py-inferior.c: Update.
11541         * python/py-infthread.c: Update.
11542         * python/py-lazy-string.c: Update.
11543         * python/py-linetable.c: Update.
11544         * python/py-objfile.c: Update.
11545         * python/py-param.c: Update.
11546         * python/py-prettyprint.c: Update.
11547         * python/py-progspace.c: Update.
11548         * python/py-record-btrace.c: Update.
11549         * python/py-record.c: Update.
11550         * python/py-symbol.c: Update.
11551         * python/py-type.c: Update.
11552         * python/py-unwind.c: Update.
11553         * python/py-utils.c: Update.
11554         * python/py-value.c: Update.
11555         * python/python.c: Update.
11556         * record-btrace.c: Update.
11557         * record-full.c: Update.
11558         * remote-fileio.c: Update.
11559         * remote.c: Update.
11560         * riscv-tdep.c: Update.
11561         * rs6000-aix-tdep.c: Update.
11562         * rs6000-tdep.c: Update.
11563         * rust-exp.y: Update.
11564         * rust-lang.c: Update.
11565         * s390-tdep.c: Update.
11566         * selftest-arch.c: Update.
11567         * solib-dsbt.c: Update.
11568         * solib-frv.c: Update.
11569         * solib-spu.c: Update.
11570         * solib-svr4.c: Update.
11571         * solib.c: Update.
11572         * sparc64-linux-tdep.c: Update.
11573         * stack.c: Update.
11574         * symfile-mem.c: Update.
11575         * symmisc.c: Update.
11576         * target.c: Update.
11577         * thread.c: Update.
11578         * top.c: Update.
11579         * tracefile-tfile.c: Update.
11580         * tui/tui.c: Update.
11581         * typeprint.c: Update.
11582         * unittests/cli-utils-selftests.c: Update.
11583         * unittests/parse-connection-spec-selftests.c: Update.
11584         * valops.c: Update.
11585         * valprint.c: Update.
11586         * value.c: Update.
11587         * varobj.c: Update.
11588         * windows-nat.c: Update.
11589         * x86-linux-nat.c: Update.
11590         * xml-support.c: Update.
11591
11592 2019-04-08  Tom Tromey  <tom@tromey.com>
11593
11594         * xml-support.c: Use C++ exception handling.
11595         * x86-linux-nat.c: Use C++ exception handling.
11596         * windows-nat.c: Use C++ exception handling.
11597         * varobj.c: Use C++ exception handling.
11598         * value.c: Use C++ exception handling.
11599         * valprint.c: Use C++ exception handling.
11600         * valops.c: Use C++ exception handling.
11601         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11602         handling.
11603         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11604         * typeprint.c: Use C++ exception handling.
11605         * tui/tui.c: Use C++ exception handling.
11606         * tracefile-tfile.c: Use C++ exception handling.
11607         * top.c: Use C++ exception handling.
11608         * thread.c: Use C++ exception handling.
11609         * target.c: Use C++ exception handling.
11610         * symmisc.c: Use C++ exception handling.
11611         * symfile-mem.c: Use C++ exception handling.
11612         * stack.c: Use C++ exception handling.
11613         * sparc64-linux-tdep.c: Use C++ exception handling.
11614         * solib.c: Use C++ exception handling.
11615         * solib-svr4.c: Use C++ exception handling.
11616         * solib-spu.c: Use C++ exception handling.
11617         * solib-frv.c: Use C++ exception handling.
11618         * solib-dsbt.c: Use C++ exception handling.
11619         * selftest-arch.c: Use C++ exception handling.
11620         * s390-tdep.c: Use C++ exception handling.
11621         * rust-lang.c: Use C++ exception handling.
11622         * rust-exp.y: Use C++ exception handling.
11623         * rs6000-tdep.c: Use C++ exception handling.
11624         * rs6000-aix-tdep.c: Use C++ exception handling.
11625         * riscv-tdep.c: Use C++ exception handling.
11626         * remote.c: Use C++ exception handling.
11627         * remote-fileio.c: Use C++ exception handling.
11628         * record-full.c: Use C++ exception handling.
11629         * record-btrace.c: Use C++ exception handling.
11630         * python/python.c: Use C++ exception handling.
11631         * python/py-value.c: Use C++ exception handling.
11632         * python/py-utils.c: Use C++ exception handling.
11633         * python/py-unwind.c: Use C++ exception handling.
11634         * python/py-type.c: Use C++ exception handling.
11635         * python/py-symbol.c: Use C++ exception handling.
11636         * python/py-record.c: Use C++ exception handling.
11637         * python/py-record-btrace.c: Use C++ exception handling.
11638         * python/py-progspace.c: Use C++ exception handling.
11639         * python/py-prettyprint.c: Use C++ exception handling.
11640         * python/py-param.c: Use C++ exception handling.
11641         * python/py-objfile.c: Use C++ exception handling.
11642         * python/py-linetable.c: Use C++ exception handling.
11643         * python/py-lazy-string.c: Use C++ exception handling.
11644         * python/py-infthread.c: Use C++ exception handling.
11645         * python/py-inferior.c: Use C++ exception handling.
11646         * python/py-gdb-readline.c: Use C++ exception handling.
11647         * python/py-framefilter.c: Use C++ exception handling.
11648         * python/py-frame.c: Use C++ exception handling.
11649         * python/py-finishbreakpoint.c: Use C++ exception handling.
11650         * python/py-cmd.c: Use C++ exception handling.
11651         * python/py-breakpoint.c: Use C++ exception handling.
11652         * python/py-arch.c: Use C++ exception handling.
11653         * printcmd.c: Use C++ exception handling.
11654         * ppc-linux-tdep.c: Use C++ exception handling.
11655         * parse.c: Use C++ exception handling.
11656         * p-valprint.c: Use C++ exception handling.
11657         * objc-lang.c: Use C++ exception handling.
11658         * mi/mi-main.c: Use C++ exception handling.
11659         * mi/mi-interp.c: Use C++ exception handling.
11660         * mi/mi-cmd-stack.c: Use C++ exception handling.
11661         * mi/mi-cmd-break.c: Use C++ exception handling.
11662         * main.c: Use C++ exception handling.
11663         * linux-thread-db.c: Use C++ exception handling.
11664         * linux-tdep.c: Use C++ exception handling.
11665         * linux-nat.c: Use C++ exception handling.
11666         * linux-fork.c: Use C++ exception handling.
11667         * linespec.c: Use C++ exception handling.
11668         * language.c: Use C++ exception handling.
11669         * jit.c: Use C++ exception handling.
11670         * infrun.c: Use C++ exception handling.
11671         * infcmd.c: Use C++ exception handling.
11672         * infcall.c: Use C++ exception handling.
11673         * inf-loop.c: Use C++ exception handling.
11674         * i386-tdep.c: Use C++ exception handling.
11675         * i386-linux-tdep.c: Use C++ exception handling.
11676         * guile/scm-value.c: Use C++ exception handling.
11677         * guile/scm-type.c: Use C++ exception handling.
11678         * guile/scm-symtab.c: Use C++ exception handling.
11679         * guile/scm-symbol.c: Use C++ exception handling.
11680         * guile/scm-pretty-print.c: Use C++ exception handling.
11681         * guile/scm-ports.c: Use C++ exception handling.
11682         * guile/scm-param.c: Use C++ exception handling.
11683         * guile/scm-math.c: Use C++ exception handling.
11684         * guile/scm-lazy-string.c: Use C++ exception handling.
11685         * guile/scm-frame.c: Use C++ exception handling.
11686         * guile/scm-disasm.c: Use C++ exception handling.
11687         * guile/scm-cmd.c: Use C++ exception handling.
11688         * guile/scm-breakpoint.c: Use C++ exception handling.
11689         * guile/scm-block.c: Use C++ exception handling.
11690         * guile/guile-internal.h: Use C++ exception handling.
11691         * gnu-v3-abi.c: Use C++ exception handling.
11692         * gdbtypes.c: Use C++ exception handling.
11693         * frame.c: Use C++ exception handling.
11694         * frame-unwind.c: Use C++ exception handling.
11695         * fbsd-tdep.c: Use C++ exception handling.
11696         * f-valprint.c: Use C++ exception handling.
11697         * exec.c: Use C++ exception handling.
11698         * event-top.c: Use C++ exception handling.
11699         * event-loop.c: Use C++ exception handling.
11700         * eval.c: Use C++ exception handling.
11701         * dwarf2read.c: Use C++ exception handling.
11702         * dwarf2loc.c: Use C++ exception handling.
11703         * dwarf2-frame.c: Use C++ exception handling.
11704         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11705         * dwarf-index-write.c: Use C++ exception handling.
11706         * dwarf-index-cache.c: Use C++ exception handling.
11707         * dtrace-probe.c: Use C++ exception handling.
11708         * disasm-selftests.c: Use C++ exception handling.
11709         * darwin-nat.c: Use C++ exception handling.
11710         * cp-valprint.c: Use C++ exception handling.
11711         * cp-support.c: Use C++ exception handling.
11712         * cp-abi.c: Use C++ exception handling.
11713         * corelow.c: Use C++ exception handling.
11714         * completer.c: Use C++ exception handling.
11715         * compile/compile-object-run.c: Use C++ exception handling.
11716         * compile/compile-object-load.c: Use C++ exception handling.
11717         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11718         * compile/compile-c-symbols.c: Use C++ exception handling.
11719         * common/selftest.c: Use C++ exception handling.
11720         * common/new-op.c: Use C++ exception handling.
11721         * cli/cli-script.c: Use C++ exception handling.
11722         * cli/cli-interp.c: Use C++ exception handling.
11723         * cli/cli-cmds.c: Use C++ exception handling.
11724         * c-varobj.c: Use C++ exception handling.
11725         * btrace.c: Use C++ exception handling.
11726         * breakpoint.c: Use C++ exception handling.
11727         * break-catch-throw.c: Use C++ exception handling.
11728         * arch-utils.c: Use C++ exception handling.
11729         * amd64-tdep.c: Use C++ exception handling.
11730         * ada-valprint.c: Use C++ exception handling.
11731         * ada-typeprint.c: Use C++ exception handling.
11732         * ada-lang.c: Use C++ exception handling.
11733         * aarch64-tdep.c: Use C++ exception handling.
11734
11735 2019-04-08  Tom Tromey  <tom@tromey.com>
11736
11737         * xml-support.c (gdb_xml_parser::parse): Update.
11738         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11739         * value.c (show_convenience): Update.
11740         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11741         (test_parse_flags_qcs): Update.
11742         * thread.c (thr_try_catch_cmd): Update.
11743         * target.c (target_translate_tls_address): Update.
11744         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11745         (info_frame_command_core, frame_apply_command_count): Update.
11746         * rust-exp.y (rust_lex_exception_test): Update.
11747         * riscv-tdep.c (riscv_print_one_register_info): Update.
11748         * remote.c (remote_target::enable_btrace): Update.
11749         * record-btrace.c (record_btrace_enable_warn): Update.
11750         * python/py-utils.c (gdbpy_convert_exception): Update.
11751         * printcmd.c (do_one_display, print_variable_and_value): Update.
11752         * mi/mi-main.c (mi_print_exception): Update.
11753         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11754         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11755         * linux-nat.c (linux_nat_target::attach): Update.
11756         * linux-fork.c (class scoped_switch_fork_info): Update.
11757         * infrun.c (displaced_step_prepare): Update.
11758         * infcall.c (call_function_by_hand_dummy): Update.
11759         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11760         * gnu-v3-abi.c (print_one_vtable): Update.
11761         * frame.c (get_prev_frame_always): Update.
11762         * f-valprint.c (info_common_command_for_block): Update.
11763         * exec.c (try_open_exec_file): Update.
11764         * exceptions.c (print_exception, exception_print)
11765         (exception_fprintf, exception_print_same): Update.
11766         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11767         * dwarf-index-cache.c (index_cache::store)
11768         (index_cache::lookup_gdb_index): Update.
11769         * darwin-nat.c (maybe_cache_shell): Update.
11770         * cp-valprint.c (cp_print_value_fields): Update.
11771         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11772         (gcc_cplus_symbol_address): Update.
11773         * compile/compile-c-symbols.c (gcc_convert_symbol)
11774         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11775         * common/selftest.c: Update.
11776         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11777         a std::string.
11778         (exception_try_scope_entry, exception_try_scope_exit): Don't
11779         declare.
11780         (struct exception_try_scope): Remove.
11781         (TRY): Don't use exception_try_scope.
11782         (struct gdb_exception): Add constructor, operator=.
11783         <what>: New method.
11784         (struct gdb_exception_RETURN_MASK_ALL)
11785         (struct gdb_exception_RETURN_MASK_ERROR)
11786         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11787         (struct gdb_quit_bad_alloc): Update.
11788         * common/common-exceptions.c (exception_none): Change
11789         initializer.
11790         (struct catcher) <state, exception>: Initialize inline.
11791         <prev>: Remove member.
11792         (current_catcher): Remove.
11793         (catchers): New global.
11794         (exceptions_state_mc_init): Simplify.
11795         (catcher_pop): Remove.
11796         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11797         (try_scope_depth, exception_try_scope_entry)
11798         (exception_try_scope_exit): Remove.
11799         (throw_exception_sjlj): Update.
11800         (exception_messages, exception_messages_size): Remove.
11801         (throw_it): Simplify.
11802         (gdb_exception_sliced_copy): Remove.
11803         (throw_exception_cxx): Update.
11804         * cli/cli-script.c (script_from_file): Update.
11805         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11806         Update.
11807         * ada-valprint.c (ada_val_print): Update.
11808         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11809         (create_excep_cond_exprs): Update.
11810
11811 2019-04-08  Tom Tromey  <tom@tromey.com>
11812
11813         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11814         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11815         (TRY, CATCH, END_CATCH): Remove some definitions.
11816         * common/common-exceptions.c: Don't use GDB_XCPT.
11817         (catcher_list_size): Remove.
11818         (throw_exception, throw_it): Simplify.
11819
11820 2019-04-05  Tom Tromey  <tom@tromey.com>
11821
11822         Revert the header-sorting patch.
11823         * ft32-tdep.c: Revert.
11824         * frv-tdep.c: Revert.
11825         * frv-linux-tdep.c: Revert.
11826         * frame.c: Revert.
11827         * frame-unwind.c: Revert.
11828         * frame-base.c: Revert.
11829         * fork-child.c: Revert.
11830         * findvar.c: Revert.
11831         * findcmd.c: Revert.
11832         * filesystem.c: Revert.
11833         * filename-seen-cache.h: Revert.
11834         * filename-seen-cache.c: Revert.
11835         * fbsd-tdep.c: Revert.
11836         * fbsd-nat.h: Revert.
11837         * fbsd-nat.c: Revert.
11838         * f-valprint.c: Revert.
11839         * f-typeprint.c: Revert.
11840         * f-lang.c: Revert.
11841         * extension.h: Revert.
11842         * extension.c: Revert.
11843         * extension-priv.h: Revert.
11844         * expprint.c: Revert.
11845         * exec.h: Revert.
11846         * exec.c: Revert.
11847         * exceptions.c: Revert.
11848         * event-top.c: Revert.
11849         * event-loop.c: Revert.
11850         * eval.c: Revert.
11851         * elfread.c: Revert.
11852         * dwarf2read.h: Revert.
11853         * dwarf2read.c: Revert.
11854         * dwarf2loc.c: Revert.
11855         * dwarf2expr.h: Revert.
11856         * dwarf2expr.c: Revert.
11857         * dwarf2-frame.c: Revert.
11858         * dwarf2-frame-tailcall.c: Revert.
11859         * dwarf-index-write.h: Revert.
11860         * dwarf-index-write.c: Revert.
11861         * dwarf-index-common.c: Revert.
11862         * dwarf-index-cache.h: Revert.
11863         * dwarf-index-cache.c: Revert.
11864         * dummy-frame.c: Revert.
11865         * dtrace-probe.c: Revert.
11866         * disasm.h: Revert.
11867         * disasm.c: Revert.
11868         * disasm-selftests.c: Revert.
11869         * dictionary.c: Revert.
11870         * dicos-tdep.c: Revert.
11871         * demangle.c: Revert.
11872         * dcache.h: Revert.
11873         * dcache.c: Revert.
11874         * darwin-nat.h: Revert.
11875         * darwin-nat.c: Revert.
11876         * darwin-nat-info.c: Revert.
11877         * d-valprint.c: Revert.
11878         * d-namespace.c: Revert.
11879         * d-lang.c: Revert.
11880         * ctf.c: Revert.
11881         * csky-tdep.c: Revert.
11882         * csky-linux-tdep.c: Revert.
11883         * cris-tdep.c: Revert.
11884         * cris-linux-tdep.c: Revert.
11885         * cp-valprint.c: Revert.
11886         * cp-support.c: Revert.
11887         * cp-namespace.c: Revert.
11888         * cp-abi.c: Revert.
11889         * corelow.c: Revert.
11890         * corefile.c: Revert.
11891         * continuations.c: Revert.
11892         * completer.h: Revert.
11893         * completer.c: Revert.
11894         * complaints.c: Revert.
11895         * coffread.c: Revert.
11896         * coff-pe-read.c: Revert.
11897         * cli-out.h: Revert.
11898         * cli-out.c: Revert.
11899         * charset.c: Revert.
11900         * c-varobj.c: Revert.
11901         * c-valprint.c: Revert.
11902         * c-typeprint.c: Revert.
11903         * c-lang.c: Revert.
11904         * buildsym.c: Revert.
11905         * buildsym-legacy.c: Revert.
11906         * build-id.h: Revert.
11907         * build-id.c: Revert.
11908         * btrace.c: Revert.
11909         * bsd-uthread.c: Revert.
11910         * breakpoint.h: Revert.
11911         * breakpoint.c: Revert.
11912         * break-catch-throw.c: Revert.
11913         * break-catch-syscall.c: Revert.
11914         * break-catch-sig.c: Revert.
11915         * blockframe.c: Revert.
11916         * block.c: Revert.
11917         * bfin-tdep.c: Revert.
11918         * bfin-linux-tdep.c: Revert.
11919         * bfd-target.c: Revert.
11920         * bcache.c: Revert.
11921         * ax-general.c: Revert.
11922         * ax-gdb.h: Revert.
11923         * ax-gdb.c: Revert.
11924         * avr-tdep.c: Revert.
11925         * auxv.c: Revert.
11926         * auto-load.c: Revert.
11927         * arm-wince-tdep.c: Revert.
11928         * arm-tdep.c: Revert.
11929         * arm-symbian-tdep.c: Revert.
11930         * arm-pikeos-tdep.c: Revert.
11931         * arm-obsd-tdep.c: Revert.
11932         * arm-nbsd-tdep.c: Revert.
11933         * arm-nbsd-nat.c: Revert.
11934         * arm-linux-tdep.c: Revert.
11935         * arm-linux-nat.c: Revert.
11936         * arm-fbsd-tdep.c: Revert.
11937         * arm-fbsd-nat.c: Revert.
11938         * arm-bsd-tdep.c: Revert.
11939         * arch-utils.c: Revert.
11940         * arc-tdep.c: Revert.
11941         * arc-newlib-tdep.c: Revert.
11942         * annotate.h: Revert.
11943         * annotate.c: Revert.
11944         * amd64-windows-tdep.c: Revert.
11945         * amd64-windows-nat.c: Revert.
11946         * amd64-tdep.c: Revert.
11947         * amd64-sol2-tdep.c: Revert.
11948         * amd64-obsd-tdep.c: Revert.
11949         * amd64-obsd-nat.c: Revert.
11950         * amd64-nbsd-tdep.c: Revert.
11951         * amd64-nbsd-nat.c: Revert.
11952         * amd64-nat.c: Revert.
11953         * amd64-linux-tdep.c: Revert.
11954         * amd64-linux-nat.c: Revert.
11955         * amd64-fbsd-tdep.c: Revert.
11956         * amd64-fbsd-nat.c: Revert.
11957         * amd64-dicos-tdep.c: Revert.
11958         * amd64-darwin-tdep.c: Revert.
11959         * amd64-bsd-nat.c: Revert.
11960         * alpha-tdep.c: Revert.
11961         * alpha-obsd-tdep.c: Revert.
11962         * alpha-nbsd-tdep.c: Revert.
11963         * alpha-mdebug-tdep.c: Revert.
11964         * alpha-linux-tdep.c: Revert.
11965         * alpha-linux-nat.c: Revert.
11966         * alpha-bsd-tdep.c: Revert.
11967         * alpha-bsd-nat.c: Revert.
11968         * aix-thread.c: Revert.
11969         * agent.c: Revert.
11970         * addrmap.c: Revert.
11971         * ada-varobj.c: Revert.
11972         * ada-valprint.c: Revert.
11973         * ada-typeprint.c: Revert.
11974         * ada-tasks.c: Revert.
11975         * ada-lang.c: Revert.
11976         * aarch64-tdep.c: Revert.
11977         * aarch64-ravenscar-thread.c: Revert.
11978         * aarch64-newlib-tdep.c: Revert.
11979         * aarch64-linux-tdep.c: Revert.
11980         * aarch64-linux-nat.c: Revert.
11981         * aarch64-fbsd-tdep.c: Revert.
11982         * aarch64-fbsd-nat.c: Revert.
11983         * aarch32-linux-nat.c: Revert.
11984
11985 2019-04-05  Tom Tromey  <tom@tromey.com>
11986
11987         * ft32-tdep.c: Sort headers.
11988         * frv-tdep.c: Sort headers.
11989         * frv-linux-tdep.c: Sort headers.
11990         * frame.c: Sort headers.
11991         * frame-unwind.c: Sort headers.
11992         * frame-base.c: Sort headers.
11993         * fork-child.c: Sort headers.
11994         * findvar.c: Sort headers.
11995         * findcmd.c: Sort headers.
11996         * filesystem.c: Sort headers.
11997         * filename-seen-cache.h: Sort headers.
11998         * filename-seen-cache.c: Sort headers.
11999         * fbsd-tdep.c: Sort headers.
12000         * fbsd-nat.h: Sort headers.
12001         * fbsd-nat.c: Sort headers.
12002         * f-valprint.c: Sort headers.
12003         * f-typeprint.c: Sort headers.
12004         * f-lang.c: Sort headers.
12005         * extension.h: Sort headers.
12006         * extension.c: Sort headers.
12007         * extension-priv.h: Sort headers.
12008         * expprint.c: Sort headers.
12009         * exec.h: Sort headers.
12010         * exec.c: Sort headers.
12011         * exceptions.c: Sort headers.
12012         * event-top.c: Sort headers.
12013         * event-loop.c: Sort headers.
12014         * eval.c: Sort headers.
12015         * elfread.c: Sort headers.
12016         * dwarf2read.h: Sort headers.
12017         * dwarf2read.c: Sort headers.
12018         * dwarf2loc.c: Sort headers.
12019         * dwarf2expr.h: Sort headers.
12020         * dwarf2expr.c: Sort headers.
12021         * dwarf2-frame.c: Sort headers.
12022         * dwarf2-frame-tailcall.c: Sort headers.
12023         * dwarf-index-write.h: Sort headers.
12024         * dwarf-index-write.c: Sort headers.
12025         * dwarf-index-common.c: Sort headers.
12026         * dwarf-index-cache.h: Sort headers.
12027         * dwarf-index-cache.c: Sort headers.
12028         * dummy-frame.c: Sort headers.
12029         * dtrace-probe.c: Sort headers.
12030         * disasm.h: Sort headers.
12031         * disasm.c: Sort headers.
12032         * disasm-selftests.c: Sort headers.
12033         * dictionary.c: Sort headers.
12034         * dicos-tdep.c: Sort headers.
12035         * demangle.c: Sort headers.
12036         * dcache.h: Sort headers.
12037         * dcache.c: Sort headers.
12038         * darwin-nat.h: Sort headers.
12039         * darwin-nat.c: Sort headers.
12040         * darwin-nat-info.c: Sort headers.
12041         * d-valprint.c: Sort headers.
12042         * d-namespace.c: Sort headers.
12043         * d-lang.c: Sort headers.
12044         * ctf.c: Sort headers.
12045         * csky-tdep.c: Sort headers.
12046         * csky-linux-tdep.c: Sort headers.
12047         * cris-tdep.c: Sort headers.
12048         * cris-linux-tdep.c: Sort headers.
12049         * cp-valprint.c: Sort headers.
12050         * cp-support.c: Sort headers.
12051         * cp-namespace.c: Sort headers.
12052         * cp-abi.c: Sort headers.
12053         * corelow.c: Sort headers.
12054         * corefile.c: Sort headers.
12055         * continuations.c: Sort headers.
12056         * completer.h: Sort headers.
12057         * completer.c: Sort headers.
12058         * complaints.c: Sort headers.
12059         * coffread.c: Sort headers.
12060         * coff-pe-read.c: Sort headers.
12061         * cli-out.h: Sort headers.
12062         * cli-out.c: Sort headers.
12063         * charset.c: Sort headers.
12064         * c-varobj.c: Sort headers.
12065         * c-valprint.c: Sort headers.
12066         * c-typeprint.c: Sort headers.
12067         * c-lang.c: Sort headers.
12068         * buildsym.c: Sort headers.
12069         * buildsym-legacy.c: Sort headers.
12070         * build-id.h: Sort headers.
12071         * build-id.c: Sort headers.
12072         * btrace.c: Sort headers.
12073         * bsd-uthread.c: Sort headers.
12074         * breakpoint.h: Sort headers.
12075         * breakpoint.c: Sort headers.
12076         * break-catch-throw.c: Sort headers.
12077         * break-catch-syscall.c: Sort headers.
12078         * break-catch-sig.c: Sort headers.
12079         * blockframe.c: Sort headers.
12080         * block.c: Sort headers.
12081         * bfin-tdep.c: Sort headers.
12082         * bfin-linux-tdep.c: Sort headers.
12083         * bfd-target.c: Sort headers.
12084         * bcache.c: Sort headers.
12085         * ax-general.c: Sort headers.
12086         * ax-gdb.h: Sort headers.
12087         * ax-gdb.c: Sort headers.
12088         * avr-tdep.c: Sort headers.
12089         * auxv.c: Sort headers.
12090         * auto-load.c: Sort headers.
12091         * arm-wince-tdep.c: Sort headers.
12092         * arm-tdep.c: Sort headers.
12093         * arm-symbian-tdep.c: Sort headers.
12094         * arm-pikeos-tdep.c: Sort headers.
12095         * arm-obsd-tdep.c: Sort headers.
12096         * arm-nbsd-tdep.c: Sort headers.
12097         * arm-nbsd-nat.c: Sort headers.
12098         * arm-linux-tdep.c: Sort headers.
12099         * arm-linux-nat.c: Sort headers.
12100         * arm-fbsd-tdep.c: Sort headers.
12101         * arm-fbsd-nat.c: Sort headers.
12102         * arm-bsd-tdep.c: Sort headers.
12103         * arch-utils.c: Sort headers.
12104         * arc-tdep.c: Sort headers.
12105         * arc-newlib-tdep.c: Sort headers.
12106         * annotate.h: Sort headers.
12107         * annotate.c: Sort headers.
12108         * amd64-windows-tdep.c: Sort headers.
12109         * amd64-windows-nat.c: Sort headers.
12110         * amd64-tdep.c: Sort headers.
12111         * amd64-sol2-tdep.c: Sort headers.
12112         * amd64-obsd-tdep.c: Sort headers.
12113         * amd64-obsd-nat.c: Sort headers.
12114         * amd64-nbsd-tdep.c: Sort headers.
12115         * amd64-nbsd-nat.c: Sort headers.
12116         * amd64-nat.c: Sort headers.
12117         * amd64-linux-tdep.c: Sort headers.
12118         * amd64-linux-nat.c: Sort headers.
12119         * amd64-fbsd-tdep.c: Sort headers.
12120         * amd64-fbsd-nat.c: Sort headers.
12121         * amd64-dicos-tdep.c: Sort headers.
12122         * amd64-darwin-tdep.c: Sort headers.
12123         * amd64-bsd-nat.c: Sort headers.
12124         * alpha-tdep.c: Sort headers.
12125         * alpha-obsd-tdep.c: Sort headers.
12126         * alpha-nbsd-tdep.c: Sort headers.
12127         * alpha-mdebug-tdep.c: Sort headers.
12128         * alpha-linux-tdep.c: Sort headers.
12129         * alpha-linux-nat.c: Sort headers.
12130         * alpha-bsd-tdep.c: Sort headers.
12131         * alpha-bsd-nat.c: Sort headers.
12132         * aix-thread.c: Sort headers.
12133         * agent.c: Sort headers.
12134         * addrmap.c: Sort headers.
12135         * ada-varobj.c: Sort headers.
12136         * ada-valprint.c: Sort headers.
12137         * ada-typeprint.c: Sort headers.
12138         * ada-tasks.c: Sort headers.
12139         * ada-lang.c: Sort headers.
12140         * aarch64-tdep.c: Sort headers.
12141         * aarch64-ravenscar-thread.c: Sort headers.
12142         * aarch64-newlib-tdep.c: Sort headers.
12143         * aarch64-linux-tdep.c: Sort headers.
12144         * aarch64-linux-nat.c: Sort headers.
12145         * aarch64-fbsd-tdep.c: Sort headers.
12146         * aarch64-fbsd-nat.c: Sort headers.
12147         * aarch32-linux-nat.c: Sort headers.
12148
12149 2019-04-04  Tom Tromey  <tom@tromey.com>
12150
12151         * varobj.c (varobj_create): Update.
12152         * rust-exp.y (struct rust_parser) <update_innermost_block,
12153         lookup_symbol>: New methods.
12154         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12155         Rename.
12156         (rust_parser::rust_lookup_type)
12157         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12158         * printcmd.c (display_command, do_one_display): Update.
12159         * parser-defs.h (struct parser_state) <parser_state>: Add
12160         "tracker" parameter.
12161         (block_tracker): New member.
12162         (class innermost_block_tracker) <innermost_block_tracker>: Add
12163         "types" parameter.
12164         <reset>: Remove method.
12165         (innermost_block): Don't declare.
12166         (null_post_parser): Update.
12167         * parse.c (innermost_block): Remove global.
12168         (write_dollar_variable): Update.
12169         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12170         Remove "tracker_types" parameter.
12171         (parse_expression): Add "tracker" parameter.
12172         (parse_expression_for_completion): Update.
12173         (null_post_parser): Add "tracker" parameter.
12174         * p-exp.y: Update rules.
12175         * m2-exp.y: Update rules.
12176         * language.h (struct language_defn) <la_post_parser>: Add
12177         "tracker" parameter.
12178         * go-exp.y: Update rules.
12179         * f-exp.y: Update rules.
12180         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12181         parameter.
12182         * d-exp.y: Update rules.
12183         * c-exp.y: Update rules.
12184         * breakpoint.c (set_breakpoint_condition): Create an
12185         innermost_block_tracker.
12186         (watch_command_1): Likewise.
12187         * ada-lang.c (resolve): Add "tracker" parameter.
12188         (resolve_subexp): Likewise.
12189         * ada-exp.y (write_var_from_sym): Update.
12190
12191 2019-04-04  Tom Tromey  <tom@tromey.com>
12192
12193         * type-stack.h: New file.
12194         * type-stack.c: New file.
12195         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12196         type-stack.h.
12197         (insert_into_type_stack, insert_type, push_type, push_type_int)
12198         (insert_type_address_space, pop_type, pop_type_int)
12199         (pop_typelist, pop_type_stack, append_type_stack)
12200         (push_type_stack, get_type_stack, push_typelist)
12201         (follow_type_instance_flags, follow_types): Don't declare.
12202         * parse.c (type_stack): Remove global.
12203         (parse_exp_in_context): Update.
12204         (insert_into_type_stack, insert_type, push_type, push_type_int)
12205         (insert_type_address_space, pop_type, pop_type_int)
12206         (pop_typelist, pop_type_stack, append_type_stack)
12207         (push_type_stack, get_type_stack, push_typelist)
12208         (follow_type_instance_flags, follow_types): Remove (moved to
12209         type-stack.c).
12210         * f-exp.y (type_stack): New global.
12211         Update rules.
12212         (push_kind_type, f_parse): Update.
12213         * d-exp.y (type_stack): New global.
12214         Update rules.
12215         (d_parse): Update.
12216         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12217         Update rules.
12218         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12219         (HFILES_NO_SRCDIR): Add type-stack.h.
12220
12221 2019-04-04  Tom Tromey  <tom@tromey.com>
12222
12223         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12224         (rust_parser::convert_ast_to_expression, rust_parse)
12225         (rust_lex_test_completion, rust_lex_tests): Update.
12226         * parser-defs.h (struct expr_completion_state): New.
12227         (struct parser_state) <parser_state>: Add completion parameter.
12228         <mark_struct_expression, mark_completion_tag>: New methods.
12229         <parse_completion, m_completion_state>: New members.
12230         (prefixify_expression, null_post_parser): Update.
12231         (mark_struct_expression, mark_completion_tag): Don't declare.
12232         * parse.c (parse_completion, expout_last_struct)
12233         (expout_tag_completion_type, expout_completion_name): Remove
12234         globals.
12235         (parser_state::mark_struct_expression)
12236         (parser_state::mark_completion_tag): Now methods.
12237         (prefixify_expression): Add last_struct parameter.
12238         (prefixify_subexp): Likewise.
12239         (parse_exp_1): Update.
12240         (parse_exp_in_context): Add cstate parameter.  Update.
12241         (parse_expression_for_completion): Create an
12242         expr_completion_state.
12243         (null_post_parser): Add "completion" parameter.
12244         * p-exp.y: Update rules.
12245         (yylex): Update.
12246         * language.h (struct language_defn) <la_post_parser>: Add
12247         "completing" parameter.
12248         * go-exp.y: Update rules.
12249         (lex_one_token): Update.
12250         * expression.h (parse_completion): Don't declare.
12251         * d-exp.y: Update rules.
12252         (lex_one_token): Update rules.
12253         * c-exp.y: Update rules.
12254         (lex_one_token): Update.
12255         * ada-lang.c (resolve): Add "parse_completion" parameter.
12256         (resolve_subexp): Likewise.
12257         (ada_resolve_function): Likewise.
12258
12259 2019-04-04  Tom Tromey  <tom@tromey.com>
12260
12261         * parser-defs.h (struct parser_state) <start_arglist,
12262         end_arglist>: New methods.
12263         <arglist_len, m_funcall_chain>: New members.
12264         (arglist_len, start_arglist, end_arglist): Don't declare.
12265         * parse.c (arglist_len, funcall_chain): Remove global.
12266         (start_arglist, end_arglist): Remove functions.
12267         (parse_exp_in_context): Update.
12268         * p-exp.y: Update rules.
12269         * m2-exp.y: Update rules.
12270         * go-exp.y: Update rules.
12271         * f-exp.y: Update rules.
12272         * d-exp.y: Update rules.
12273         * c-exp.y: Update rules.
12274
12275 2019-04-04  Tom Tromey  <tom@tromey.com>
12276
12277         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12278         lex_operator, push_back>: New methods.
12279         Update all rules.
12280         (rust_parser::lex_hex, lex_escape): Rename and update.
12281         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12282         (rust_parser::lex_operator): Rename and update.
12283         (rust_parser::lex_number, rustyylex, rustyyerror)
12284         (rust_lex_test_init, rust_lex_test_sequence)
12285         (rust_lex_test_push_back, rust_lex_tests): Update.
12286         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12287         parameter.
12288         <lexptr, prev_lexptr>: New members.
12289         (lexptr, prev_lexptr): Don't declare.
12290         * parse.c (lexptr, prev_lexptr): Remove globals.
12291         (parse_exp_in_context): Update.
12292         * p-exp.y (yylex, yyerror): Update.
12293         * m2-exp.y (parse_number, yylex, yyerror): Update.
12294         * go-exp.y (lex_one_token, yyerror): Update.
12295         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12296         * d-exp.y (lex_one_token, yyerror): Update.
12297         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12298         (lex_one_token, yyerror): Update.
12299         * ada-lex.l (YY_INPUT): Update.
12300         (rewind_to_char): Update.
12301         * ada-exp.y (yyerror): Update.
12302
12303 2019-04-04  Tom Tromey  <tom@tromey.com>
12304
12305         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12306         * parser-defs.h (struct parser_state) <parser_state>: Add new
12307         parameter.
12308         <comma_terminates>: New member.
12309         (comma_terminates): Don't declare global.
12310         * parse.c (comma_terminates): Remove global.
12311         (parse_exp_in_context): Update.
12312         * p-exp.y (yylex): Update.
12313         * m2-exp.y (yylex): Update.
12314         * go-exp.y (lex_one_token): Update.
12315         * f-exp.y (yylex): Update.
12316         * d-exp.y (lex_one_token): Update.
12317         * c-exp.y (lex_one_token): Update.
12318         * ada-lex.l: Update.
12319
12320 2019-04-04  Tom Tromey  <tom@tromey.com>
12321
12322         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12323         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12324         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12325         * parser-defs.h (paren_depth): Don't declare.
12326         * parse.c (paren_depth): Remove global.
12327         (parse_exp_in_context): Update.
12328         * p-exp.y (paren_depth): New global.
12329         (pascal_parse): Initialize it.
12330         * m2-exp.y (paren_depth): New global.
12331         (m2_parse): Initialize it.
12332         * go-exp.y (paren_depth): New global.
12333         (go_parse): Initialize it.
12334         * f-exp.y (paren_depth): New global.
12335         (f_parse): Initialize it.
12336         * d-exp.y (paren_depth): New global.
12337         (d_parse): Initialize it.
12338         * c-exp.y (paren_depth): New global.
12339         (c_parse): Initialize it.
12340         * ada-lex.l (paren_depth): New global.
12341         (lexer_init): Initialize it.
12342
12343 2019-04-04  Tom Tromey  <tom@tromey.com>
12344
12345         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12346         (rust_parser::convert_ast_to_type)
12347         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12348         * parser-defs.h (struct parser_state) <parser_state>: Add
12349         parameters.  Initialize new members.
12350         <expression_context_block, expression_context_pc>: New members.
12351         * parse.c (expression_context_block, expression_context_pc):
12352         Remove globals.
12353         (parse_exp_in_context): Update.
12354         * p-exp.y: Update all rules.
12355         (yylex): Update.
12356         * m2-exp.y: Update all rules.
12357         (yylex): Update.
12358         * go-exp.y (yylex): Update.
12359         * f-exp.y (yylex): Update.
12360         * d-exp.y: Update all rules.
12361         (yylex): Update.
12362         * c-exp.y: Update all rules.
12363         (lex_one_token, classify_name, yylex, c_parse): Update.
12364         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12365
12366 2019-04-04  Tom Tromey  <tom@tromey.com>
12367
12368         * gdbarch.h, gdbarch.c: Rebuild.
12369         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12370         * stap-probe.h:
12371         (struct stap_parse_info): Replace "parser_state" with
12372         "expr_builder".
12373         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12374         (parser_state): New class.
12375         * parse.c (expr_builder): Rename.
12376         (expr_builder::release): Rename.
12377         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12378         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12379         (write_exp_elt_longcst, write_exp_elt_floatcst)
12380         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12381         (write_exp_string_vector, write_exp_bitstring)
12382         (write_exp_msymbol, mark_struct_expression)
12383         (write_dollar_variable)
12384         (insert_type_address_space, increase_expout_size): Replace
12385         "parser_state" with "expr_builder".
12386         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12387         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12388         "parser_state" with "expr_builder".
12389
12390 2019-04-04  Tom Tromey  <tom@tromey.com>
12391
12392         * rust-exp.y: Replace "parse_language" with method call.
12393         * p-exp.y:
12394         (yylex): Replace "parse_language" with method call.
12395         * m2-exp.y:
12396         (yylex): Replace "parse_language" with method call.
12397         * go-exp.y (classify_name): Replace "parse_language" with method
12398         call.
12399         * f-exp.y (yylex): Replace "parse_language" with method call.
12400         * d-exp.y (lex_one_token): Replace "parse_language" with method
12401         call.
12402         * c-exp.y:
12403         (lex_one_token, classify_name, yylex): Replace "parse_language"
12404         with method call.
12405         * ada-exp.y (find_primitive_type, type_char)
12406         (type_system_address): Replace "parse_language" with method call.
12407
12408 2019-04-04  Tom Tromey  <tom@tromey.com>
12409
12410         * rust-exp.y: Replace "parse_gdbarch" with method call.
12411         * parse.c (write_dollar_variable, insert_type_address_space):
12412         Replace "parse_gdbarch" with method call.
12413         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12414         call.
12415         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12416         call.
12417         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12418         "parse_gdbarch" with method call.
12419         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12420         with method call.
12421         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12422         "parse_gdbarch" with method call.
12423         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12424         "parse_gdbarch" with method call.
12425         * c-exp.y (parse_type, parse_number, classify_name): Replace
12426         "parse_gdbarch" with method call.
12427         * ada-lex.l: Replace "parse_gdbarch" with method call.
12428         * ada-exp.y (parse_type, find_primitive_type, type_char)
12429         (type_system_address): Replace "parse_gdbarch" with method call.
12430
12431 2019-04-04  Tom Tromey  <tom@tromey.com>
12432
12433         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12434         * stap-probe.c (stap_parse_argument): Update.
12435         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12436         initial_size parameter.
12437         * rust-exp.y (rust_lex_tests): Update.
12438         * parse.c (parser_state): Update.
12439         (parse_exp_in_context): Update.
12440         * parser-defs.h (struct parser_state) <parser_state>: Remove
12441         "initial_size" parameter.
12442
12443 2019-04-04  Tom Tromey  <tom@tromey.com>
12444
12445         * parser-defs.h (increase_expout_size): Don't declare.
12446         * parse.c (increase_expout_size): Now static.
12447
12448 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12449
12450         * gnu-nat.c (gnu_nat_target::wait): Fix
12451         target_waitstatus_to_string call.
12452
12453 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12454
12455         * eval.c (evaluate_subexp_standard): Handle internal functions
12456         during Fortran function call handling.
12457
12458 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12459
12460         * NEWS: Mention new internal functions.
12461         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12462         (read_base_type): Use dwarf2_init_complex_target_type.
12463         * value.c (creal_internal_fn): New function.
12464         (cimag_internal_fn): New function.
12465         (_initialize_values): Register new internal functions.
12466
12467 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12468
12469         * infrun.c (stop_all_threads): If debug_infrun, always
12470         trace the wait status after wait_one, using
12471         target_waitstatus_to_string and target_pid_to_str.
12472         (handle_inferior_event): Replace various trace of
12473         wait status kind by a single trace.
12474         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12475         wait status kind image by target_waitstatus_to_string.
12476         * target/waitstatus.c (target_waitstatus_to_string): Fix
12477         obsolete comment.
12478
12479 2019-04-01  Tom Tromey  <tromey@adacore.com>
12480
12481         PR symtab/23331:
12482         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12483
12484 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12485             Pedro Alves  <palves@redhat.com>
12486
12487         * top.c (quit_force): Call 'finalize_values'.
12488         * value.c (finalize_values): New function.
12489         * value.h (finalize_values): Declare.
12490
12491 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12492
12493         * NEWS: Announce $_gdb_major and $_gdb_minor.
12494
12495         * top.c (init_gdb_version_vars): New function.
12496         (gdb_init): Call init_gdb_version_vars.
12497
12498 2019-03-29  Tom Tromey  <tromey@adacore.com>
12499
12500         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12501         help text.  Remove dead code.
12502
12503 2019-03-29  Keith Seitz  <keiths@redhat.com>
12504
12505         From Siddhesh Poyarekar:
12506         * f-lang.h (f77_get_upperbound): Return LONGEST.
12507         (f77_get_lowerbound): Likewise.
12508         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12509         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12510         print them.
12511         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12512         plongest to format print it.
12513         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12514         (f77_get_upperbound): Likewise.
12515         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12516         LOWER_BOUND to LONGEST.
12517         (f77_create_arrayprint_offset_tbl): Likewise.
12518
12519 2019-03-29  Keith Seitz  <keiths@redhat.com>
12520
12521         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12522         %s/pulongest for TYPE_LENGTH instead of %d in format
12523         strings.
12524         * ada-typerint.c (ada_print_type): Likewise.
12525         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12526         * compile/compile-c-support.c (generate_register_struct): Likewise.
12527         * gdbtypes.c (recursive_dump_type): Likewise.
12528         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12529         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12530         instead of %d in format strings.
12531         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12532         to std::min to ULONGEST.
12533         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12534         instead of %d in format strings.
12535         * tracepoint.c (info_scope_command): Likewise.
12536         * typeprint.c (print_offset_data::update)
12537         (print_offset_data::finish): Likewise.
12538         * xtensa-tdep.c (xtensa_store_return_value)
12539         (xtensa_push_dummy_call): Likewise.
12540
12541 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12542
12543         * windows-nat.c (display_selector): Fixed format specifications
12544         for 64-bit Cygwin.
12545
12546 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12547
12548         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12549
12550 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12551
12552         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12553         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12554         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12555         (nios2_linux_init_abi): Install it.
12556
12557 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12558
12559         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12560
12561 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12562
12563         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12564
12565 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12566             Tom Tromey  <tromey@adacore.com>
12567
12568         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12569
12570 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12571
12572         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12573         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12574         method to compute the bounds of range types. Also print "[evaluated]"
12575         if the bounds' values come from a dynamic evaluation.
12576
12577 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12578
12579         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12580         whitespace when pretty printing is on.
12581
12582 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12583
12584         * ppc-linux-nat.c: Add include.
12585
12586 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12587
12588         * NEWS: Mention AArch64 Pointer Authentication.
12589
12590 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12591
12592         * arm-linux-nat.c: Add include.
12593
12594 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12595
12596         * source-cache.c (source_cache::get_source_lines): Re-read
12597         fullname after calling open_source_file.
12598
12599 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12600
12601         * NEWS: Mention TLS support for FreeBSD.
12602
12603 2019-03-25  Tom Tromey  <tromey@adacore.com>
12604
12605         * minsyms.c (BUNCH_SIZE): Update comment.
12606         (~minimal_symbol_reader): Remove old comment.
12607         (compact_minimal_symbols): Update comment.
12608         (minimal_symbol_reader::install): Remove old comment.  Update
12609         other comments.
12610
12611 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12612
12613         * s390-linux-nat.c: Add include.
12614
12615 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12616
12617         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12618         Call linux_get_hwcap.
12619         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12620         Likewise.
12621         (aarch64_linux_get_hwcap): Remove function.
12622         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12623         declaration.
12624         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12625         linux_get_hwcap.
12626         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12627         * linux-tdep.c (linux_get_hwcap): Add function.
12628         (linux_get_hwcap2): Likewise.
12629         * linux-tdep.h (linux_get_hwcap): Add declaration.
12630         (linux_get_hwcap2): Likewise.
12631         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12632         (ppc_linux_get_hwcap2): Likewise.
12633         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12634         linux_get_hwcap.
12635         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12636         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12637         (ppc_linux_nat_target::read_description): Likewise.
12638         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12639         * s390-linux-nat.c: Likewise.
12640         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12641
12642 2019-03-24  Tom Tromey  <tom@tromey.com>
12643
12644         * ada-lang.c (standard_lookup): Simplify initialization.
12645         (ada_lookup_symbol_nonlocal): Simplify return.
12646         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12647         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12648         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12649         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12650         initialization.
12651         * solib.c (solib_global_lookup): Simplify.
12652         * symtab.c (null_block_symbol): Remove.
12653         (symbol_cache_lookup): Simplify returns.
12654         (lookup_language_this): Simplify returns.
12655         (lookup_symbol_aux): Simplify return.
12656         (lookup_local_symbol): Simplify returns.
12657         (lookup_global_symbol_from_objfile): Simplify return.
12658         (lookup_symbol_in_objfile_symtabs)
12659         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12660         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12661         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12662         * cp-namespace.c (cp_lookup_bare_symbol)
12663         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12664         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12665         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12666         (cp_lookup_symbol_via_imports): Simplify initialization.
12667         (find_symbol_in_baseclass): Likewise.
12668         * symtab.h (null_block_symbol): Remove.
12669         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12670         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12671         (d_lookup_symbol_module): Likewise.
12672         (find_symbol_in_baseclass): Simplify initialization.
12673
12674 2019-03-24  Tom Tromey  <tom@tromey.com>
12675
12676         * expression.h: Don't include symtab.h.
12677         (struct block): Forward declare.
12678
12679 2019-03-24  Tom Tromey  <tom@tromey.com>
12680
12681         * c-exp.y (typebase): Remove casts.
12682         * gdbtypes.c (lookup_unsigned_typename, )
12683         (lookup_signed_typename): Remove cast.
12684         * eval.c (parse_to_comma_and_eval): Remove cast.
12685         * parse.c (write_dollar_variable): Remove cast.
12686         * block.h (struct block) <superblock>: Now const.
12687         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12688         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12689         (map_block): Make "block" const.
12690         * symfile.h (struct quick_symbol_functions)
12691         <map_matching_symbols>: Constify block argument to "callback".
12692         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12693         const.
12694         (find_pc_sect_compunit_symtab): Make "b" const.
12695         (find_symbol_at_address): Likewise.
12696         (search_symbols): Likewise.
12697         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12698         (dw2_debug_names_lookup_symbol): Likewise.
12699         (dw2_map_matching_symbols): Update.
12700         * p-valprint.c (pascal_val_print): Remove "block".
12701         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12702         (aux_add_nonlocal_symbols): Make "block" const.
12703         (resolve_subexp): Remove cast.
12704         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12705         const.
12706         (iterate_over_file_blocks): Likewise.
12707         * f-exp.y (%union) <bval>: Remove.
12708         * coffread.c (patch_opaque_types): Make "b" const.
12709         * spu-tdep.c (spu_catch_start): Make "block" const.
12710         * c-valprint.c (print_unpacked_pointer): Remove "block".
12711         * symmisc.c (dump_symtab_1): Make "b" const.
12712         (block_depth): Make "block" const.
12713         * d-exp.y (%union) <bval>: Remove.
12714         * cp-support.h (cp_lookup_rtti_type): Update.
12715         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12716         * psymtab.c (psym_lookup_symbol): Make "block" const.
12717         (maintenance_check_psymtabs): Make "b" const.
12718         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12719         (enumerate_locals, enumerate_args): Update.
12720         * python/py-symtab.c (stpy_global_block): Make "block" const.
12721         (stpy_static_block): Likewise.
12722         * inline-frame.c (block_starting_point_at): Make "new_block"
12723         const.
12724         * block.c (find_block_in_blockvector): Make return type const.
12725         (blockvector_for_pc_sect): Make "b" const.
12726         (find_block_in_blockvector): Make "b" const.
12727
12728 2019-03-23  Tom Tromey  <tom@tromey.com>
12729
12730         * varobj.c (varobj_create): Update.
12731         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12732         * printcmd.c (display_command, do_one_display): Don't reset
12733         innermost_block.
12734         * parser-defs.h (enum innermost_block_tracker_type): Move to
12735         expression.h.
12736         (innermost_block): Update comment.
12737         * parse.c (parse_exp_1): Add tracker_types parameter.
12738         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12739         tracker_types parameter.  Reset innermost_block.
12740         (parse_exp_in_context): Remove.
12741         (parse_expression_for_completion): Update.
12742         * objfiles.c (~objfile): Don't reset expression_context_block or
12743         innermost_block.
12744         * expression.h (enum innermost_block_tracker_type): Move from
12745         parser-defs.h.
12746         (parse_exp_1): Add tracker_types parameter.
12747         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12748         reset innermost_block.
12749
12750 2019-03-23  Tom Tromey  <tom@tromey.com>
12751
12752         * objfiles.h: Include bcache.h.
12753
12754 2019-03-23  Tom Tromey  <tom@tromey.com>
12755
12756         * linespec.c (get_current_search_block): Use
12757         scoped_restore_current_language.
12758         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12759
12760 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12761             Jiong Wang  <jiong.wang@arm.com>
12762
12763         * aarch64-linux-tdep.c
12764         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12765         section.
12766         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12767
12768 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12769             Jiong Wang  <jiong.wang@arm.com>
12770
12771         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12772         instructions.
12773         (aarch64_analyze_prologue_test): Add PACIASP test.
12774         (aarch64_prologue_prev_register): Unmask PC value.
12775
12776 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12777             Jiong Wang  <jiong.wang@arm.com>
12778
12779         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12780         (aarch64_dwarf2_prev_register): Unmask PC value.
12781         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12782         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12783         DW_CFA_AARCH64_negate_ra_state.
12784         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12785
12786 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12787             Jiong Wang  <jiong.wang@arm.com>
12788
12789         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12790         registers.
12791         (aarch64_pseudo_register_name): Likewise.
12792         (aarch64_pseudo_register_type): Likewise.
12793         (aarch64_pseudo_register_reggroup_p): Likewise.
12794         (aarch64_gdbarch_init): Add pauth registers.
12795         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12796         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12797         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12798         (struct gdbarch_tdep): Add regnum for ra_state.
12799
12800 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12801             Jiong Wang  <jiong.wang@arm.com>
12802
12803         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12804
12805 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12806             Jiong Wang  <jiong.wang@arm.com>
12807
12808         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12809         function.
12810         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12811         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12812         (aarch64_gdbarch_init): Add puth registers.
12813         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12814         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12815         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12816
12817 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12818             Jiong Wang  <jiong.wang@arm.com>
12819
12820         * aarch64-linux-nat.c
12821         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12822         * aarch64-linux-tdep.c
12823         (aarch64_linux_core_read_description): Likewise.
12824         (aarch64_linux_get_hwcap): New function.
12825         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12826         (aarch64_linux_get_hwcap): New declaration.
12827
12828 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12829             Jiong Wang  <jiong.wang@arm.com>
12830
12831         * aarch64-linux-nat.c
12832         (aarch64_linux_nat_target::read_description): Add pauth param.
12833         * aarch64-linux-tdep.c
12834         (aarch64_linux_core_read_description): Likewise.
12835         * aarch64-tdep.c (struct target_desc): Add in pauth.
12836         (aarch64_read_description): Add pauth param.
12837         (aarch64_gdbarch_init): Likewise.
12838         * aarch64-tdep.h (aarch64_read_description): Likewise.
12839         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12840         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12841         * features/Makefile: Add new files.
12842         * features/aarch64-pauth.c: New file.
12843         * features/aarch64-pauth.xml: New file.
12844
12845 2019-03-20  Tom Tromey  <tromey@adacore.com>
12846
12847         * infrun.c (handle_inferior_event): Rename from
12848         handle_inferior_event_1.  Create a scoped_value_mark.
12849         (handle_inferior_event): Remove.
12850
12851 2019-03-19  Tom Tromey  <tromey@adacore.com>
12852
12853         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12854         * infrun.h (print_stop_event): Add "displays" parameter.
12855         * infrun.c (print_stop_event): Add "displays" parameter.
12856
12857 2019-03-19  Pedro Alves  <palves@redhat.com>
12858
12859         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12860         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12861         to -1.  Fix TABs vs spaces.
12862         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12863         * tui/tui-out.h (tui_ui_out) Add intro comments.
12864         <m_line, m_start_of_line>: In-class initialize, and add describing
12865         comment.
12866
12867 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12868
12869         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12870         variable names.
12871         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12872
12873 2019-03-18  Pedro Alves  <palves@redhat.com>
12874             Eli Zaretskii <eliz@gnu.org>
12875
12876         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12877         m_line and m_start_of_line.
12878
12879 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12880
12881         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12882         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12883         it returns a newline.  This fixes a regression in TU mode, whereby
12884         the next line is output on the same screen line as the user input.
12885
12886 2019-03-18  Tom Tromey  <tromey@adacore.com>
12887
12888         * minsyms.c (minimal_symbol_reader::install): Remove call to
12889         obstack_blank.
12890
12891 2019-03-18  Pedro Alves  <palves@redhat.com>
12892
12893         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12894         New globals.
12895         (apply_style): New, factored out from ...
12896         (apply_ansi_escape): ... this.  Handle reverse video mode.
12897         (tui_set_reverse_mode): New function.
12898         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12899         * tui/tui-winsource.c (tui_show_source_line): Use
12900         tui_set_reverse_mode instead of setting A_STANDOUT.
12901         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12902         New setter methods.
12903
12904 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12905
12906         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12907         Handle tabs.
12908
12909 2019-03-18  Tom Tromey  <tromey@adacore.com>
12910
12911         * ada-lang.c (empty_array): Add "high" parameter.
12912         (ada_evaluate_subexp): Update.
12913
12914 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12915
12916         * unittests/string_view-selftests.c: Define
12917         _initialize_string_view_selftests unconditionally.
12918
12919 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12920
12921         PR gdb/24350
12922         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12923
12924 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12925
12926         PR gdb/24351
12927         * windows-nat.c (display_selector): Fix format specifiers.
12928
12929 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12930
12931         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12932         tui_refill_source_window instead of tui_refresh_win, to update the
12933         current execution line.  This fixes redisplay of the current line
12934         when stepping through the code with "next" or "step".
12935
12936 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12937
12938         * source-cache.c (source_cache::get_source_lines): Call
12939         find_source_lines to initialize s->nlines.  This fixes vertical
12940         scrolling of TUI source window when the DOWN arrow is pressed.
12941
12942 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12943
12944         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12945         linux-thread-db.c (_initialize_thread_db): Likewise.
12946
12947 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12948
12949         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12950         wclrtoeol in tui_show_source_line".  This reverts changes made in
12951         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12952
12953 2019-03-15  Tom Tromey  <tom@tromey.com>
12954
12955         * symtab.h (struct minimal_symbol): Derive from
12956         general_symbol_info.
12957         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12958         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12959         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12960         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12961         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12962         (MSYMBOL_SEARCH_NAME): Update.
12963         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12964         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12965         * minsyms.c (minimal_symbol_reader::record_full): Update.
12966
12967 2019-03-15  Tom Tromey  <tom@tromey.com>
12968
12969         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12970
12971 2019-03-15  Tom Tromey  <tom@tromey.com>
12972
12973         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12974         unique_xmalloc_ptr.
12975         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12976         Update.
12977         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12978         (build_minimal_symbol_hash_tables)
12979         (minimal_symbol_reader::install): Update.
12980
12981 2019-03-15  Tom Tromey  <tom@tromey.com>
12982
12983         * symtab.c (create_demangled_names_hash): Update.
12984         (symbol_set_names): Update.
12985         * objfiles.h (struct objfile_per_bfd_storage)
12986         <demangled_names_hash>: Now an htab_up.
12987         * objfiles.c (objfile_per_bfd_storage): Simplify.
12988
12989 2019-03-15  Tom Tromey  <tom@tromey.com>
12990
12991         * objfiles.h (struct objfile_per_bfd_storage): Declare
12992         destructor.
12993         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12994         New.
12995         (get_objfile_bfd_data): Use new.  Don't initialize
12996         language_of_main.
12997         (free_objfile_per_bfd_storage): Remove.
12998         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12999
13000 2019-03-15  Tom Tromey  <tom@tromey.com>
13001
13002         * symfile.c (reread_symbols): Update.
13003         * objfiles.c (objfile::objfile): Update.
13004         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13005         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13006         comment.
13007         (minimal_symbol_reader::install): Update.
13008         (terminate_minimal_symbol_table): Remove.
13009         * jit.c (jit_object_close_impl): Update.
13010
13011 2019-03-15  Tom Tromey  <tom@tromey.com>
13012
13013         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13014         initializations.
13015
13016 2019-03-15  Tom Tromey  <tom@tromey.com>
13017
13018         * objfiles.h (struct objfile_per_bfd_storage)
13019         <demangled_hash_languages>: Now a bitset.
13020         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13021         (lookup_minimal_symbol): Update.
13022
13023 2019-03-15  Tom Tromey  <tom@tromey.com>
13024
13025         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13026         Don't return the symbol.
13027         * coffread.c (record_minimal_symbol): Use record_full.
13028
13029 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13030
13031         The MS-Windows port of ncurses fails to switch to a color pair if
13032         one or both of the colors are the implicit default colors.  This
13033         change records the default colors when TUI is initialized, and
13034         then specifies them explicitly when a color pair uses the default
13035         colors.  This allows color styling in TUI mode on MS-Windows.
13036
13037         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13038         ncurses_norm_attr.
13039         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13040         colors in ncurses_norm_attr.
13041         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13042         "none", replace it with the default color recorded in
13043         ncurses_norm_attr.
13044
13045 2019-03-14  Tom Tromey  <tromey@adacore.com>
13046
13047         * source-cache.h (class source_cache) <get_source_lines>: Return
13048         std::string.
13049         * source-cache.c (source_cache::extract_lines): Handle case where
13050         first_pos==npos.  Return std::string.
13051         (source_cache::get_source_lines): Update.
13052
13053 2019-03-14  Tom Tromey  <tromey@adacore.com>
13054
13055         * NEWS: Add item for "style sources" commands.
13056         * source-cache.c (source_cache::get_source_lines): Check
13057         source_styling.
13058         * cli/cli-style.c (source_styling): New global.
13059         (_initialize_cli_style): Add "style sources" commands.
13060         (show_style_sources): New function.
13061         * cli/cli-style.h (source_styling): Declare.
13062
13063 2019-03-14  Pedro Alves  <palves@redhat.com>
13064             Tom Tromey  <tromey@adacore.com>
13065
13066         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13067         * tui/tui-winsource.c (tui_refill_source_window): New function,
13068         from...
13069         (tui_horizontal_source_scroll): ... here.  Move some logic.
13070         * cli/cli-style.c (set_style_enabled): Notify new observable.
13071         * tui/tui-hooks.c (tui_redisplay_source): New function.
13072         (tui_attach_detach_observers): Attach or detach
13073         tui_redisplay_source.
13074         * observable.h (source_styling_changed): New observable.
13075         * observable.c: Define source_styling_changed observable.
13076
13077 2019-03-13  Tom Tromey  <tromey@adacore.com>
13078
13079         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13080         (i386_gnu_nat_target::store_registers): Update.
13081         * target-debug.h (target_debug_print_std_string): New macro.
13082         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13083         * windows-tdep.c (display_one_tib): Update.
13084         * tui/tui-stack.c (tui_make_status_line): Update.
13085         * top.c (print_inferior_quit_action): Update.
13086         * thread.c (thr_try_catch_cmd): Update.
13087         (add_thread_with_info): Update.
13088         (thread_target_id_str): Update.
13089         (thr_try_catch_cmd): Update.
13090         (thread_command): Update.
13091         (thread_find_command): Update.
13092         * record-btrace.c (record_btrace_target::info_record)
13093         (record_btrace_resume_thread, record_btrace_target::resume)
13094         (record_btrace_cancel_resume, record_btrace_step_thread)
13095         (record_btrace_target::wait, record_btrace_target::wait)
13096         (record_btrace_target::wait, record_btrace_target::stop): Update.
13097         * progspace.c (print_program_space): Update.
13098         * process-stratum-target.c
13099         (process_stratum_target::thread_address_space): Update.
13100         * linux-fork.c (linux_fork_mourn_inferior)
13101         (detach_checkpoint_command, info_checkpoints_command)
13102         (linux_fork_context): Update.
13103         (linux_fork_detach): Update.
13104         (class scoped_switch_fork_info): Update.
13105         (delete_checkpoint_command): Update.
13106         * infrun.c (follow_fork_inferior): Update.
13107         (follow_fork_inferior): Update.
13108         (proceed_after_vfork_done): Update.
13109         (handle_vfork_child_exec_or_exit): Update.
13110         (follow_exec): Update.
13111         (displaced_step_prepare_throw): Update.
13112         (displaced_step_restore): Update.
13113         (start_step_over): Update.
13114         (resume_1): Update.
13115         (clear_proceed_status_thread): Update.
13116         (proceed): Update.
13117         (print_target_wait_results): Update.
13118         (do_target_wait): Update.
13119         (context_switch): Update.
13120         (stop_all_threads): Update.
13121         (restart_threads): Update.
13122         (finish_step_over): Update.
13123         (handle_signal_stop): Update.
13124         (switch_back_to_stepped_thread): Update.
13125         (keep_going_pass_signal): Update.
13126         (print_exited_reason): Update.
13127         (normal_stop): Update.
13128         * inferior.c (inferior_pid_to_str): Change return type.
13129         (print_selected_inferior): Update.
13130         (add_inferior): Update.
13131         (detach_inferior): Update.
13132         * dummy-frame.c (fprint_dummy_frames): Update.
13133         * dcache.c (dcache_info_1): Update.
13134         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13135         (btrace_fetch, btrace_clear): Update.
13136         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13137         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13138         type.
13139         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13140         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13141         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13142         * gdbarch.c, gdbarch.h: Rebuild.
13143         * gdbarch.sh (core_pid_to_str): Change return type.
13144         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13145         return type.
13146         (windows_nat_target::pid_to_str): Change return type.
13147         (windows_delete_thread): Update.
13148         (windows_nat_target::attach): Update.
13149         (windows_nat_target::files_info): Update.
13150         * target-delegates.c: Rebuild.
13151         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13152         return type.
13153         (sol_thread_target::pid_to_str): Change return type.
13154         * remote.c (class remote_target) <pid_to_str>: Change return
13155         type.
13156         (remote_target::pid_to_str): Change return type.
13157         (extended_remote_target::attach, remote_target::remote_stop_ns)
13158         (remote_target::remote_notif_remove_queued_reply)
13159         (remote_target::push_stop_reply, remote_target::disable_btrace):
13160         Update.
13161         (extended_remote_target::attach): Update.
13162         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13163         type.
13164         (gdbsim_target::pid_to_str): Change return type.
13165         * ravenscar-thread.c (struct ravenscar_thread_target)
13166         <pid_to_str>: Change return type.
13167         (ravenscar_thread_target::pid_to_str): Change return type.
13168         * procfs.c (class procfs_target) <pid_to_str>: Change return
13169         type.
13170         (procfs_target::pid_to_str): Change return type.
13171         (procfs_target::attach): Update.
13172         (procfs_target::detach): Update.
13173         (procfs_target::fetch_registers): Update.
13174         (procfs_target::store_registers): Update.
13175         (procfs_target::wait): Update.
13176         (procfs_target::files_info): Update.
13177         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13178         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13179         return type.
13180         (nto_procfs_target::pid_to_str): Change return type.
13181         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13182         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13183         return type.
13184         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13185         (exit_lwp): Update.
13186         (attach_proc_task_lwp_callback, get_detach_signal)
13187         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13188         (linux_nat_target::resume, wait_lwp, stop_callback)
13189         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13190         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13191         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13192         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13193         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13194         type.
13195         (inf_ptrace_target::attach): Update.
13196         (inf_ptrace_target::files_info): Update.
13197         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13198         type.
13199         (go32_nat_target::pid_to_str): Change return type.
13200         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13201         (gnu_nat_target::wait): Update.
13202         (gnu_nat_target::wait): Update.
13203         (gnu_nat_target::resume): Update.
13204         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13205         (fbsd_nat_target::wait): Update.
13206         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13207         type.
13208         (darwin_nat_target::attach): Update.
13209         * corelow.c (class core_target) <pid_to_str>: Change return type.
13210         (core_target::pid_to_str): Change return type.
13211         * target.c (normal_pid_to_str): Change return type.
13212         (default_pid_to_str): Likewise.
13213         (target_pid_to_str): Change return type.
13214         (target_translate_tls_address): Update.
13215         (target_announce_detach): Update.
13216         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13217         return type.
13218         (bsd_uthread_target::pid_to_str): Change return type.
13219         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13220         type.
13221         (bsd_kvm_target::pid_to_str): Change return type.
13222         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13223         return type.
13224         (aix_thread_target::pid_to_str): Change return type.
13225         * target.h (struct target_ops) <pid_to_str>: Change return type.
13226         (target_pid_to_str, normal_pid_to_str): Likewise.
13227         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13228         type.
13229         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13230         type.
13231         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13232         return type.
13233         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13234         type.
13235         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13236         type.
13237         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13238         return type.
13239
13240 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13241
13242         * NEWS: Mention that the new default MI version is 3.  Mention
13243         changes to the output of commands and events that deal with
13244         multi-location breakpoints.
13245         * breakpoint.c: Include "mi/mi-out.h".
13246         (print_one_breakpoint): Change output syntax if using MI version
13247         >= 3.
13248         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13249         New.
13250         (mi_multi_location_breakpoint_output_fixed): New.
13251         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13252         (mi_cmd_fix_multi_location_breakpoint_output): New.
13253         (mi_multi_location_breakpoint_output_fixed): New.
13254         * mi/mi-cmds.c (mi_cmds): Register command
13255         -fix-multi-location-breakpoint-output.
13256         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13257         interpreter "mi".
13258
13259 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13260
13261         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13262         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13263         instantiate mi_ui_out based on interpreter name.
13264         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13265         * mi/mi-main.c (mi_load_progress): Likewise.
13266
13267 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13268
13269         * NEWS: Combine separate "New targets" sections for 8.3.
13270
13271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13272
13273         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13274         (ppcfbsd_init_abi): Install gdbarch
13275         "fetch_tls_load_module_address" and "get_thread_local_address"
13276         methods.
13277
13278 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13279
13280         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13281         (riscv_fbsd_init_abi): Install gdbarch
13282         "fetch_tls_load_module_address" and "get_thread_local_address"
13283         methods.
13284
13285 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13286
13287         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13288         (i386fbsd_init_abi): Install gdbarch
13289         "fetch_tls_load_module_address" and "get_thread_local_address"
13290         methods.
13291
13292 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13293
13294         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13295         (amd64fbsd_init_abi): Install gdbarch
13296         "fetch_tls_load_module_address" and "get_thread_local_address"
13297         methods.
13298
13299 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13300
13301         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13302         (struct fbsd_pspace_data): New type.
13303         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13304         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13305         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13306         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13307         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13308
13309 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13310
13311         * gdbtypes.c (lookup_struct_elt): New function.
13312         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13313         * gdbtypes.h (struct struct_elt): New type.
13314         (lookup_struct_elt): New prototype.
13315
13316 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13317
13318         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13319         remove disabled code block.
13320
13321 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13322
13323         * gdbarch.sh (get_thread_local_address): New method.
13324         * gdbarch.h, gdbarch.c: Regenerate.
13325         * target.c (target_translate_tls_address): Use
13326         gdbarch_get_thread_local_address if present instead of
13327         target::get_thread_local_address.
13328
13329 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13330
13331         * target.h (target::get_thread_local_address): Update comment.
13332
13333 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13334
13335         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13336         objfile->separate_debug_objfile_backlink if not NULL.
13337
13338 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13339
13340         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13341         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13342         (amd64bsd_store_inferior_registers): Likewise.
13343         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13344         Enable segment base registers.
13345         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13346         PT_GETFSBASE and PT_GETGSBASE.
13347         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13348         PT_SETGSBASE.
13349         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13350         segment base registers.
13351         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13352
13353 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13354
13355         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13356         Update calls to i386_target_description to add 'segments'
13357         parameter.
13358         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13359         add segment base registers.
13360         * arch/i386.c (i386_create_target_description): Add 'segments'
13361         parameter to enable segment base registers.
13362         * arch/i386.h (i386_create_target_description): Likewise.
13363         * features/i386/32bit-segments.xml: New file.
13364         * features/i386/32bit-segments.c: Generate.
13365         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13366         call to i386_target_description to add 'segments' parameter.
13367         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13368         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13369         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13370         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13371         if feature is present.
13372         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13373         Add 'segments' parameter to call to i386_target_description.
13374         (i386_target_description): Add 'segments' parameter to enable
13375         segment base registers.
13376         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13377         to call to i386_target_description.
13378         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13379         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13380         Define I386_NUM_REGS.
13381         (i386_target_description): Add 'segments' parameter to enable
13382         segment base registers.
13383
13384 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13385
13386         PR/24325
13387         * source-cache.c: #undef open and close, to avoid unresolved
13388         externals during linking.
13389
13390 2019-03-12  Tom Tromey  <tromey@adacore.com>
13391
13392         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13393         const.  Add initializers.
13394         (_initialize_remote): Don't initialize ptid globals.
13395
13396 2019-03-12  Pedro Alves  <palves@redhat.com>
13397
13398         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13399
13400 2019-03-12  Pedro Alves  <palves@redhat.com>
13401
13402         * cp-name-parser.y (main): Remove unused 'len' variable.
13403
13404 2019-03-12  Tom Tromey  <tromey@adacore.com>
13405
13406         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13407         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13408
13409 2019-03-12  Tom Tromey  <tromey@adacore.com>
13410
13411         * linux-nat.c (iterate_over_lwps): Update.
13412         (stop_callback): Remove parameter.
13413         (stop_wait_callback, detach_callback, resume_set_callback)
13414         (select_singlestep_lwp_callback, set_ignore_sigint)
13415         (status_callback, resumed_callback, resume_clear_callback)
13416         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13417         data parameter.
13418         (linux_nat_target::detach, linux_nat_target::resume)
13419         (linux_stop_and_wait_all_lwps, select_event_lwp)
13420         (linux_nat_filter_event, linux_nat_wait_1)
13421         (linux_nat_target::kill, linux_nat_target::stop)
13422         (linux_nat_target::stop): Update.
13423         (linux_nat_resume_callback): Change type.
13424         (resume_stopped_resumed_lwps, count_events_callback)
13425         (select_event_lwp_callback): Likewise.
13426         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13427         * arm-linux-nat.c (struct update_registers_data): Remove.
13428         (update_registers_callback): Change type.
13429         (arm_linux_insert_hw_breakpoint1): Update.
13430         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13431         parameter.
13432         (x86_linux_dr_set_addr): Update.
13433         (x86_linux_dr_set_control): Update.
13434         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13435         (iterate_over_lwps): Use gdb::function_view.
13436         * nat/aarch64-linux-hw-point.c (struct
13437         aarch64_dr_update_callback_param): Remove.
13438         (debug_reg_change_callback): Change type.
13439         (aarch64_notify_debug_reg_change): Update.
13440         * s390-linux-nat.c (s390_refresh_per_info): Update.
13441
13442 2019-03-11  Tom Tromey  <tromey@adacore.com>
13443
13444         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13445         redundant assignment to "this_cu".
13446
13447 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13448
13449         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13450
13451 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13452
13453         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13454         from...
13455         (rank_one_type): ... this.
13456
13457 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13458
13459         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13460         from...
13461         (rank_one_type): ... this.
13462
13463 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13464
13465         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13466         from...
13467         (rank_one_type): ... this.
13468
13469 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13470
13471         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13472         from...
13473         (rank_one_type): ... this.
13474
13475 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13476
13477         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13478         from...
13479         (rank_one_type): ... this.
13480
13481 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13482
13483         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13484         from...
13485         (rank_one_type): ... this.
13486
13487 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13488
13489         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13490         from...
13491         (rank_one_type): ... this.
13492
13493 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13494
13495         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13496         from...
13497         (rank_one_type): ... this.
13498
13499 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13500
13501         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13502         from...
13503         (rank_one_type): ... this.
13504
13505 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13506
13507         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13508         from...
13509         (rank_one_type): ... this.
13510
13511 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13512
13513         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13514         from...
13515         (rank_one_type): ... this.
13516
13517 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13518
13519         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13520         from...
13521         (rank_one_type): ... this.
13522
13523 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13524
13525         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13526         inferior-events' shows the example events.
13527
13528 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13529
13530         Support styling on native MS-Windows console
13531
13532         PR/24315
13533         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13534         on MS-Windows if $TERM is not defined.
13535
13536         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13537
13538         * posix-hdep.c (gdb_console_fputs):
13539         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13540         functions.
13541         * ui-file.h (gdb_console_fputs): Add prototype.
13542
13543         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13544         back to fputs only if the former returns zero.
13545
13546 2019-03-07  Tom Tromey  <tom@tromey.com>
13547
13548         * symmisc.c (print_symbol_bcache_statistics): Update.
13549         (print_objfile_statistics): Update.
13550         * symfile.c (allocate_symtab): Update.
13551         * stabsread.c: Don't include bcache.h.
13552         * psymtab.h (struct psymbol_bcache): Don't declare.
13553         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13554         (psymbol_bcache_init, psymbol_bcache_free)
13555         (psymbol_bcache_get_bcache): Don't declare.
13556         * psymtab.c (struct psymbol_bcache): Remove.
13557         (psymtab_storage::psymtab_storage): Update.
13558         (psymtab_storage::~psymtab_storage): Update.
13559         (psymbol_bcache_init, psymbol_bcache_free)
13560         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13561         (add_psymbol_to_bcache): Update.
13562         (allocate_psymtab): Update.
13563         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13564         macro_cache>: No longer pointers.
13565         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13566         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13567         * macrotab.c (macro_bcache): Update.
13568         * macroexp.c: Don't include bcache.h.
13569         * gdbtypes.c (check_types_worklist): Update.
13570         (types_deeply_equal): Remove TRY/CATCH.  Update.
13571         * elfread.c (elf_symtab_read): Update.
13572         * dwarf2read.c: Don't include bcache.h.
13573         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13574         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13575         (print_bcache_statistics, bcache_memory_used): Don't declare.
13576         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13577         methods.  Rename all data members.
13578         * bcache.c (struct bcache): Move to bcache.h.
13579         (bcache::expand_hash_table): Rename from expand_hash_table.
13580         (bcache): Remove.
13581         (bcache::insert): Rename from bcache_full.
13582         (bcache::compare): Rename from bcache_compare.
13583         (bcache_xmalloc): Remove.
13584         (bcache::~bcache): Rename from bcache_xfree.
13585         (bcache::print_statistics): Rename from print_bcache_statistics.
13586         (bcache::memory_used): Rename from bcache_memory_used.
13587
13588 2019-03-07  Pedro Alves  <palves@redhat.com>
13589
13590         * infrun.c (normal_stop): Also check for
13591         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13592
13593 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13594
13595         * f-lang.c (value_from_host_double): Moved to...
13596         * value.c (value_from_host_double): ...here.
13597         * value.h (value_from_host_double): Declare.
13598         * guile/scm-math.c (vlscm_convert_typed_number): Use
13599         value_from_host_double.
13600         (vlscm_convert_number): Likewise.
13601         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13602         * python/py-value.c (convert_value_from_python): Likewise.
13603
13604 2019-03-06  Tom Tromey  <tom@tromey.com>
13605
13606         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13607
13608 2019-03-06  Tom Tromey  <tom@tromey.com>
13609
13610         * utils.h (free_current_contents): Don't declare.
13611         * utils.c (free_current_contents): Remove.
13612
13613 2019-03-06  Tom Tromey  <tom@tromey.com>
13614
13615         * top.c (quit_force): Update.
13616         * main.c (captured_command_loop): Update.
13617         * common/new-op.c (operator new): Update.
13618         * common/common-exceptions.c (struct catcher)
13619         <save_cleanup_chain>: Remove member.
13620         (exceptions_state_mc_init): Update.
13621         (exception_try_scope_entry): Return nullptr.
13622         (exception_try_scope_exit, exception_rethrow)
13623         (throw_exception_sjlj, throw_exception_cxx): Update.
13624         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13625         (all_cleanups, do_cleanups, discard_cleanups)
13626         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13627         (restore_cleanups, restore_final_cleanups): Don't declare.
13628         (do_final_cleanups): Remove parameter.
13629         * common/cleanups.c (cleanup_chain, make_cleanup)
13630         (make_cleanup_dtor, all_cleanups, do_cleanups)
13631         (discard_my_cleanups, discard_cleanups)
13632         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13633         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13634         (null_cleanup): Remove.
13635         (do_final_cleanups): Remove parameter.
13636
13637 2019-03-06  Tom Tromey  <tom@tromey.com>
13638
13639         * remote.c (remote_target::remote_parse_stop_reply): Use
13640         unique_xmalloc_ptr.
13641
13642 2019-03-06  Tom Tromey  <tom@tromey.com>
13643
13644         * stabsread.c (struct stabs_field_info): Rename from field_info.
13645         <list, fnlist>: Add initializers.
13646         <obstack>: New member.
13647         (read_member_functions, read_struct_fields, read_baseclasses):
13648         Allocate on obstack.  Don't use cleanups.
13649         (read_one_struct_field, read_member_functions, read_struct_fields)
13650         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13651         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13652         (read_struct_type): Update.
13653
13654 2019-03-06  Tom Tromey  <tom@tromey.com>
13655
13656         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13657         * common/filestuff.h (make_cleanup_close): Don't declare.
13658         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13659         Remove.
13660
13661 2019-03-06  Tom Tromey  <tom@tromey.com>
13662
13663         * solib-aix.c: Use make_scope_exit.
13664
13665 2019-03-06  Tom Tromey  <tom@tromey.com>
13666
13667         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13668         Use make_scope_exit.
13669
13670 2019-03-06  Tom Tromey  <tom@tromey.com>
13671
13672         * solib-svr4.c (disable_probes_interface): Remove parameter.
13673         (svr4_handle_solib_event): Use make_scope_exit.
13674
13675 2019-03-06  Tom Tromey  <tom@tromey.com>
13676
13677         * remote.c (struct stop_reply_deleter): Remove.
13678         (stop_reply_up): Update.
13679         (struct stop_reply): Derive from notif_event.  Don't typedef.
13680         <regcache>: Now a std::vector.
13681         (stop_reply_xfree): Remove.
13682         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13683         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13684         (remote_target::discard_pending_stop_replies): Use delete.
13685         (remote_target::remote_parse_stop_reply): Update.
13686         (remote_target::process_stop_reply): Update.
13687         * remote-notif.h (struct notif_event): Add virtual destructor.
13688         Remove "dtr" member.
13689         (struct notif_client) <alloc_event>: Return a unique_ptr.
13690         (notif_event_xfree): Don't declare.
13691         (notif_event_up): New typedef.
13692         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13693         (notif_event_xfree, do_notif_event_xfree): Remove.
13694         (remote_notif_state_xfree): Update.
13695
13696 2019-03-06  Tom Tromey  <tom@tromey.com>
13697
13698         * infrun.c (displaced_step_clear_cleanup): Now a
13699         forward_scope_exit type.
13700         (displaced_step_prepare_throw): Update.
13701         (displaced_step_fixup): Update.
13702
13703 2019-03-06  Tom Tromey  <tom@tromey.com>
13704
13705         * inferior.h (class inferior): Update comment.
13706         * gdbthread.h (class thread_info): Update comment.
13707
13708 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13709             Tom Tromey  <tom@tromey.com>
13710
13711         * stabsread.h (struct stab_section_list): Remove.
13712         (coffstab_build_psymtabs): Update.
13713         * dbxread.c (symbuf_sections): Now a std::vector.
13714         (sect_idx): New global.
13715         (fill_symbuf): Update.
13716         (coffstab_build_psymtabs): Change type of stabsects parameter.
13717         Update.
13718         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13719         std::vector.
13720         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13721         (coff_locate_sections): Update.
13722         (coff_symfile_read): Remove cleanups.  Update.
13723         (init_stringtab): Add storage parameter.
13724         (free_stringtab, free_stringtab_cleanup): Remove.
13725         (init_lineno): Add storage parameter.
13726         (free_linetab, free_linetab_cleanup): Remove.
13727
13728 2019-03-06  Pedro Alves  <palves@redhat.com>
13729
13730         * linux-fork.c (fork_info::clobber_regs): Delete.
13731         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13732         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13733         comment.  Adjust.
13734         (scoped_switch_fork_info::scoped_switch_fork_info)
13735         (checkpoint_command, linux_fork_context): Adjust
13736         fork_save_infrun_state calls.
13737
13738 2019-03-06  Pedro Alves  <palves@redhat.com>
13739
13740         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13741         (inf_has_multiple_threads): Return 'bool' and rewrite using
13742         inferior_info::threads().
13743
13744 2019-03-06  Pedro Alves  <palves@redhat.com>
13745
13746         * linux-fork.c: Include <list>.
13747         (fork_list): Now a std::list instance.
13748         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13749         (forks_exist_p, find_last_fork): Adjust.
13750         (new_fork): Delete.
13751         (one_fork_p): New.
13752         (add_fork): Adjust.
13753         (free_fork): Delete, folded into fork_info::~fork_info().
13754         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13755         Adjust.
13756         (init_fork_list): Delete.
13757         (linux_fork_killall, linux_fork_mourn_inferior)
13758         (linux_fork_detach, info_checkpoints_command): Adjust.
13759         (_initialize_linux_fork): No longer call init_fork_list.
13760
13761 2019-03-06  Pedro Alves  <palves@redhat.com>
13762
13763         * linux-fork.c (new_fork): New, split out of ...
13764         (add_fork): ... this.  Return void.  Move "first fork" special
13765         case from here, to ...
13766         (checkpoint_command): ... here.
13767         * linux-linux.h (add_fork): Return void.
13768
13769 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13770
13771         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13772
13773 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13774             Chris January  <chris.january@arm.com>
13775             David Lecomber  <david.lecomber@arm.com>
13776
13777         * f-exp.y: New token, UNOP_INTRINSIC.
13778         (exp): New pattern using UNOP_INTRINSIC token.
13779         (f77_keywords): Add 'abs' keyword.
13780         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13781         (value_from_host_double): New function.
13782         (evaluate_subexp_f): Support UNOP_ABS.
13783
13784 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13785
13786         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13787         types.
13788
13789 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13790
13791         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13792         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13793         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13794
13795 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13796
13797         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13798
13799 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13800             Chris January  <chris.january@arm.com>
13801
13802         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13803         * f-exp.y: Define 'KIND' token.
13804         (exp): New pattern for KIND expressions.
13805         (ptype): Handle types with a kind extension.
13806         (direct_abs_decl): Extend to spot kind extensions.
13807         (f77_keywords): Add 'kind' to the list.
13808         (push_kind_type): New function.
13809         (convert_to_kind_type): New function.
13810         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13811         * parse.c (operator_length_standard): Likewise.
13812         * parser-defs.h (enum type_pieces): Add tp_kind.
13813         * std-operator.def: Add UNOP_KIND.
13814
13815 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13816
13817         * f-exp.y (f_parse): Set yydebug.
13818
13819 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13820
13821         * f-lang.c (evaluate_subexp_f): New function.
13822         (exp_descriptor_f): New global.
13823         (f_language_defn): Use exp_descriptor_f instead of
13824         exp_descriptor_standard.
13825
13826 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13827
13828         * f-exp.y (struct token): Add comments.
13829         (dot_ops): Remove uppercase versions and the end marker.
13830         (f77_keywords): Likewise.
13831         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13832         entries in the dot_ops array are case insensitive, and use
13833         strncasecmp to compare strings.  Also some whitespace cleanup in
13834         this area.  Similar for the f77_keywords array, except entries in
13835         this list might be case sensitive.
13836
13837 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13838
13839         * f-exp.y (struct f77_boolean_val): Add comments.
13840         (boolean_values): Remove uppercase versions, and end marker.
13841         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13842         and use strncasecmp to achieve case insensitivity.  Additionally,
13843         perform whitespace cleanup around this code.
13844
13845 2019-03-06  Tom Tromey  <tromey@adacore.com>
13846
13847         * remote-sim.c (gdbsim_target_open): Use result of
13848         gdb_argv::release.
13849
13850 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13851         Dirk Schubert  <dirk.schubert@arm.com>
13852         Chris January  <chris.january@arm.com>
13853
13854         * eval.c (evaluate_subexp_standard): Call Fortran argument
13855         wrapping logic.
13856         * f-lang.c (struct value): A value which can be passed into a
13857         Fortran function call.
13858         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13859         where appropriate.
13860         (struct type): Value ready for a Fortran function call.
13861         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13862         is needed.
13863         * f-lang.h (fortran_argument_convert): Declaration.
13864         (fortran_preserve_arg_pointer): Declaration.
13865         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13866
13867 2019-03-05  Tom Tromey  <tromey@adacore.com>
13868
13869         * python/py-prettyprint.c (print_string_repr): Remove #if.
13870         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13871
13872 2019-03-05  Tom Tromey  <tromey@adacore.com>
13873
13874         * target.c (the_dummy_target): Move later.  Change type to
13875         "dummy_target".
13876         (initialize_targets): Don't initialize the_dummy_target.
13877
13878 2019-03-05  Tom Tromey  <tromey@adacore.com>
13879
13880         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13881         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13882
13883 2019-03-05  Tom Tromey  <tromey@adacore.com>
13884
13885         * windows-nat.c (windows_nat_target::attach)
13886         (windows_nat_target::detach): Don't call gdb_flush.
13887         * valprint.c (generic_val_print, val_print, val_print_string):
13888         Don't call gdb_flush.
13889         * utils.c (defaulted_query): Don't call gdb_flush.
13890         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13891         * target.c (target_announce_detach): Don't call gdb_flush.
13892         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13893         * remote.c (extended_remote_target::attach): Don't call
13894         gdb_flush.
13895         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13896         * printcmd.c (do_examine): Don't call gdb_flush.
13897         (info_display_command): Don't call gdb_flush.
13898         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13899         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13900         * memattr.c (info_mem_command): Don't call gdb_flush.
13901         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13902         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13903         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13904         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13905         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13906         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13907         (gnu_nat_target::detach): Don't call gdb_flush.
13908         * f-valprint.c (f_val_print): Don't call gdb_flush.
13909         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13910         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13911         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13912         gdb_flush.
13913         * c-valprint.c (c_val_print): Don't call gdb_flush.
13914         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13915
13916 2019-03-05  Tom Tromey  <tromey@adacore.com>
13917
13918         * varobj.c (update_dynamic_varobj_children): Update.
13919         (install_default_visualizer): Use reset, not release.
13920         * value.c (set_internalvar): Update.
13921         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13922         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13923         ATTRIBUTE_UNUSED_RESULT.
13924
13925 2019-03-05  Tom Tromey  <tromey@adacore.com>
13926
13927         * remote.c (class scoped_remote_fd) <release>: Add
13928         ATTRIBUTE_UNUSED_RESULT.
13929
13930 2019-03-05  Tom Tromey  <tromey@adacore.com>
13931
13932         * macroexp.c (struct macro_buffer) <release>: Add
13933         ATTRIBUTE_UNUSED_RESULT.
13934
13935 2019-03-05  Tom Tromey  <tromey@adacore.com>
13936
13937         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13938         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13939         ATTRIBUTE_UNUSED_RESULT.
13940
13941 2019-03-05  Tom Tromey  <tromey@adacore.com>
13942
13943         * common/scoped_fd.h (class scoped_fd) <release>: Add
13944         ATTRIBUTE_UNUSED_RESULT.
13945
13946 2019-03-05  Tom Tromey  <tromey@adacore.com>
13947
13948         * parser-defs.h (struct parser_state) <release>: Add
13949         ATTRIBUTE_UNUSED_RESULT.
13950
13951 2019-03-05  Tom Tromey  <tromey@adacore.com>
13952
13953         * utils.h (class gdb_argv) <release>: Add
13954         ATTRIBUTE_UNUSED_RESULT.
13955         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13956
13957 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13958
13959         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13960         for-loop range, to avoid compiler warnings.
13961
13962         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13963         avoid compiler warnings about unused variables.
13964
13965         * NEWS: Mention end of support for native debugging on MS-Windows
13966         before XP.
13967
13968         PR gdb/24292
13969         * common/netstuff.c:
13970         * gdbserver/gdbreplay.c
13971         * gdbserver/remote-utils.c:
13972         * ser-tcp.c:
13973         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13974         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13975         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13976         'getaddrinfo' and 'freeaddrinfo' were not available before
13977         Windows XP, and mingw.org's MinGW headers by default define
13978         _WIN32_WINNT to 0x500.
13979
13980 2019-03-01  Gary Benson <gbenson@redhat.com>
13981
13982         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13983
13984 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13985             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13986
13987         PR gdb/8527
13988         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13989         set_sigint_trap, clear_sigint_trap.
13990
13991 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13992
13993         * target.c (target_detach): Clear the regcache and the
13994         frame cache.
13995
13996 2019-02-27  Pedro Alves  <palves@redhat.com>
13997
13998         * utils.c (set_screen_size): When we cap the height/width sizes,
13999         tweak the corresponding command variable to show "unlimited":
14000
14001 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14002             Pedro Alves  <palves@redhat.com>
14003
14004         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14005         before calling rl_set_screen_size.
14006
14007 2019-02-27  Tom Tromey  <tromey@adacore.com>
14008
14009         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14010         define.
14011         * python/py-value.c: Remove Python 2.4 workaround.
14012         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14013         workaround.
14014         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14015         Python 2.4 workaround.
14016         * python/python-internal.h: Remove Python 2.4 comment.
14017         (Py_ssize_t): Don't define.
14018         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14019         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14020         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14021         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14022         * python/python.c (do_start_initialization): Remove Python 2.4
14023         workaround.
14024         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14025         (print_children): Remove Python 2.4 workaround.
14026         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14027         workaround.
14028         (CHARBUFFERPROC_NAME): Remove.
14029         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14030         Python 2.4 workaround.
14031
14032 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14033
14034         * NEWS: Note minimum Python version.
14035
14036 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14037
14038         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14039         code from these functions.  Remove corresponding ifdefs.  Use
14040         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14041         Remove gotos and target of gotos.
14042         (infpy_search_memory): Likewise.
14043
14044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14045
14046         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14047         (hppa_gdbarch_init): Don't register deleted functions with
14048         gdbarch.
14049
14050 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14051
14052         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14053         (h8300_unwind_sp): Delete.
14054         (h8300_dummy_id): Delete.
14055         (h8300_gdbarch_init): Don't register deleted functions with
14056         gdbarch.
14057
14058 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14059
14060         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14061         (ft32_unwind_pc): Delete.
14062         (ft32_unwind_sp): Delete.
14063         (ft32_gdbarch_init): Don't register deleted functions with
14064         gdbarch.
14065
14066 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14067
14068         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14069         (frv_unwind_pc): Delete.
14070         (frv_unwind_sp): Delete.
14071         (frv_gdbarch_init): Don't register deleted functions with
14072         gdbarch.
14073
14074 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14075
14076         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14077         (riscv_unwind_pc): Delete.
14078         (riscv_unwind_sp): Delete.
14079         (riscv_gdbarch_init): Don't register deleted functions with
14080         gdbarch.
14081
14082 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14083
14084         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14085         (csky_unwind_pc): Delete.
14086         (csky_unwind_sp): Delete.
14087         (csky_gdbarch_init): Don't register deleted functions with
14088         gdbarch.
14089
14090 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14091
14092         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14093         (cris_unwind_pc): Delete.
14094         (cris_unwind_sp): Delete.
14095         (cris_gdbarch_init): Don't register deleted functions with
14096         gdbarch.
14097
14098 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14099
14100         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14101         (bfin_unwind_pc): Delete.
14102         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14103
14104 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14105
14106         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14107         (arm_unwind_pc): Delete.
14108         (arm_unwind_sp): Delete.
14109         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14110
14111 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14112
14113         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14114         (arc_unwind_pc): Delete.
14115         (arc_unwind_sp): Delete.
14116         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14117
14118 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14119
14120         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14121         (alpha_unwind_pc): Delete.
14122         (alpha_gdbarch_init): Don't register deleted functions with
14123         gdbarch.
14124
14125 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14126
14127         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14128         (aarch64_unwind_pc): Delete.
14129         (aarch64_unwind_sp): Delete.
14130         (aarch64_gdbarch_init): Don't register deleted functions with
14131         gdbarch.
14132
14133 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14134
14135         * gdbtypes.c (type_align): Don't consider static members when
14136         computing structure alignment.
14137
14138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14139
14140         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14141         return 0 for other types.
14142         * arch-utils.c (default_type_align): Always return 0.
14143         * gdbarch.h: Regenerate.
14144         * gdbarch.sh (type_align): Extend comment.
14145         * gdbtypes.c (type_align): Add additional comments, always call
14146         gdbarch_type_align before applying the default rules.
14147         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14148         generic code will then apply a suitable default.
14149         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14150         types, return 0 for other types.
14151
14152 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14153
14154         * NEWS: Create a new section for the next release branch.
14155         Rename the section of the current branch, now that it has
14156         been cut.
14157
14158 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14159
14160         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14161         * version.in: Bump version to 8.3.50.DATE-git.
14162
14163 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14164
14165         * aix-thread.c (ptid_cmp): Remove unused variable.
14166         (get_signaled_thread): Likewise.
14167         (store_regs_user_thread): Likewise.
14168         (store_regs_kernel_thread): Likewise.
14169         (fetch_regs_kernel_thread): Remove shadowed variable.
14170
14171 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14172
14173         * features/riscv/32bit-cpu.xml: Add register numbers.
14174         * features/riscv/32bit-fpu.c: Regenerate.
14175         * features/riscv/32bit-fpu.xml: Add register numbers.
14176         * features/riscv/64bit-cpu.xml: Add register numbers.
14177         * features/riscv/64bit-fpu.c: Regenerate.
14178         * features/riscv/64bit-fpu.xml: Add register numbers.
14179
14180 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14181
14182         * NEWS: Mention two argument form of gdb.Value constructor.
14183         * python/py-value.c (convert_buffer_and_type_to_value): New
14184         function.
14185         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14186         Add support for handling an optional second argument.  Call
14187         convert_buffer_and_type_to_value as appropriate.
14188         * python/python-internal.h (Py_buffer_deleter): New struct.
14189         (Py_buffer_up): New typedef.
14190
14191 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14192
14193         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14194         instead of releasing ownership.
14195
14196 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14197
14198         * dwarf2read.c (open_and_init_dwp_file): Call
14199         elf_numsections instead of bfd_count_sections to initialize
14200         dwp_file->num_sections.
14201
14202 2019-02-25  Tom Tromey  <tromey@adacore.com>
14203
14204         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14205
14206 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14207
14208         * gcore.in: Add '--readnever' option when invoking GDB.
14209
14210 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14211
14212         * MAINTAINERS: Update my email address.
14213
14214 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14215
14216         * build-id.c (build_id_to_debug_bfd_1): New function.
14217         (build_id_to_debug_bfd): Look for separate debug file in
14218         sysroot.
14219
14220 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14221
14222         * gdbarch.sh: Update the copyright year range that is placed into
14223         generated files.
14224
14225 2019-02-22  Keith Seitz  <keiths@redhat.com>
14226
14227         PR symtab/23853
14228         * linespec.c (create_sals_line_offset): Search for the default
14229         symtab's filename instead of its fullname.
14230
14231 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14232
14233         * NEWS: Update style defaults.
14234
14235 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14236
14237         * main.c (captured_main_1): Disable styling in batch mode.
14238
14239 2019-02-20  Tom Tromey  <tom@tromey.com>
14240
14241         * symtab.c (symtab_symbol_info): Fix typos.
14242
14243 2019-02-20  Tom Tromey  <tromey@adacore.com>
14244
14245         * findcmd.c (_initialize_mem_search): Use upper case for
14246         metasyntactic variables.
14247
14248 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14249
14250         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14251         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14252
14253 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14254
14255         * top.h (source_file_name): Change to std::string.
14256         * top.c (source_file_name): Likewise.
14257         (command_line_input): Adjust.
14258         * cli/cli-script.c (script_from_file): Adjust.
14259
14260 2019-02-19  Tom Tromey  <tromey@adacore.com>
14261
14262         * ravenscar-thread.c
14263         (ravenscar_thread_target::update_thread_list): Don't call
14264         ada_build_task_list.
14265         * ada-lang.h (ada_build_task_list): Don't declare.
14266         * ada-tasks.c (struct ada_tasks_inferior_data)
14267         <task_list_valid_p>: Now bool.
14268         (read_known_tasks, ada_task_list_changed)
14269         (ada_tasks_invalidate_inferior_data): Update.
14270         (read_known_tasks_array): Return bool.
14271         (read_known_tasks_list): Likewise.
14272         (read_known_tasks): Return void.
14273         (ada_build_task_list): Now static.
14274
14275 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14276
14277         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14278         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14279
14280 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14281
14282         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14283         variant for ada_tasks_pspace_data_handle and
14284         ada_tasks_inferior_data_handle.
14285         (ada_tasks_pspace_data_cleanup): New function.
14286         (ada_tasks_inferior_data_cleanup): New function.
14287
14288 2019-02-17  Tom Tromey  <tom@tromey.com>
14289
14290         * macrotab.h (macro_source_fullname): Return a std::string.
14291         * macrotab.c (macro_include, check_for_redefinition)
14292         (macro_undef, macro_lookup_definition, foreach_macro)
14293         (foreach_macro_in_scope): Update.
14294         (macro_source_fullname): Return a std::string.
14295         * macrocmd.c (show_pp_source_pos): Update.
14296
14297 2019-02-17  Tom Tromey  <tom@tromey.com>
14298
14299         * macrocmd.c (show_pp_source_pos): Style the file names.
14300
14301 2019-02-17  Tom Tromey  <tom@tromey.com>
14302
14303         PR tui/24197:
14304         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14305
14306 2019-02-17  Tom Tromey  <tom@tromey.com>
14307
14308         * ada-lang.c (user_select_syms): Use filtered printing.
14309         * utils.c (wrap_style): New global.
14310         (desired_style): Remove.
14311         (emit_style_escape): Add stream parameter.
14312         (set_output_style, reset_terminal_style, prompt_for_continue):
14313         Update.
14314         (flush_wrap_buffer): Only flush gdb_stdout.
14315         (wrap_here): Set wrap_style.
14316         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14317         treat escape sequences as a character.  Change when wrap buffer is
14318         flushed.
14319         (fputs_styled): Do not set the output style when the default is
14320         requested.
14321         * ui-style.h (struct ui_file_style) <is_default>: New method.
14322         * source.c (print_source_lines_base): Emit escape sequences in one
14323         piece.
14324
14325 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14326
14327         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14328         integers and enumeration types.
14329
14330 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14331
14332         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14333         instead of lookup_symbol_in_language
14334         (do_exact_match): New function.
14335         (ada_get_symbol_name_matcher): Return do_exact_match when
14336         doing a verbatim match.
14337
14338 2019-02-15  Tom Tromey  <tromey@adacore.com>
14339
14340         * ravenscar-thread.c (ravenscar_thread_target::resume)
14341         (ravenscar_thread_target::wait): Special case wildcard requests.
14342
14343 2019-02-15  Tom Tromey  <tromey@adacore.com>
14344
14345         * ravenscar-thread.c (base_ptid): Remove.
14346         (struct ravenscar_thread_target) <close>: New method.
14347         <m_base_ptid>: New member.
14348         <update_inferior_ptid, active_task, task_is_currently_active,
14349         runtime_initialized>: Declare methods.
14350         <ravenscar_thread_target>: Add constructor.
14351         (ravenscar_thread_target::task_is_currently_active)
14352         (ravenscar_thread_target::update_inferior_ptid)
14353         (ravenscar_runtime_initialized): Rename.  Now methods.
14354         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14355         (ravenscar_thread_target::update_thread_list): Update.
14356         (ravenscar_thread_target::active_task): Now method.
14357         (ravenscar_thread_target::store_registers)
14358         (ravenscar_thread_target::prepare_to_store)
14359         (ravenscar_thread_target::prepare_to_store)
14360         (ravenscar_thread_target::mourn_inferior): Update.
14361         (ravenscar_inferior_created): Use "new" to create target.
14362         (ravenscar_thread_target::get_ada_task_ptid): Update.
14363         (_initialize_ravenscar): Don't initialize base_ptid.
14364         (ravenscar_ops): Remove global.
14365
14366 2019-02-15  Tom Tromey  <tromey@adacore.com>
14367
14368         * target.h (push_target): Declare new overload.
14369         * target.c (push_target): New overload, taking an rvalue reference.
14370         * remote.c (remote_target::open_1): Use push_target overload.
14371         * corelow.c (core_target_open): Use push_target overload.
14372
14373 2019-02-15  Tom Tromey  <tromey@adacore.com>
14374
14375         * ravenscar-thread.c (is_ravenscar_task)
14376         (ravenscar_task_is_currently_active): Return bool.
14377         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14378         (_initialize_ravenscar): Remove "(void)".
14379         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14380         Return bool.
14381
14382 2019-02-15  Tom Tromey  <tromey@adacore.com>
14383
14384         * ravenscar-thread.c (ravenscar_runtime_initializer)
14385         (has_ravenscar_runtime, get_running_thread_id)
14386         (ravenscar_thread_target::resume): Fix indentation.
14387
14388 2019-02-15  Tom Tromey  <tromey@adacore.com>
14389
14390         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14391         from ravenscar_arch_ops.
14392         (sparc_ravenscar_ops::fetch_registers)
14393         (sparc_ravenscar_ops::store_registers): Now methods.
14394         (sparc_ravenscar_prepare_to_store): Remove.
14395         (sparc_ravenscar_ops): Redefine.
14396         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14397         methods and destructor.  Remove members.
14398         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14399         (ravenscar_thread_target::store_registers)
14400         (ravenscar_thread_target::prepare_to_store): Update.
14401         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14402         Remove.
14403         (struct ppc_ravenscar_powerpc_ops): Derive from
14404         ravenscar_arch_ops.
14405         (ppc_ravenscar_powerpc_ops::fetch_registers)
14406         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14407         (ppc_ravenscar_powerpc_ops): Redefine.
14408         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14409         (ppc_ravenscar_e500_ops::fetch_registers)
14410         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14411         (ppc_ravenscar_e500_ops): Redefine.
14412         * aarch64-ravenscar-thread.c
14413         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14414         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14415         (aarch64_ravenscar_fetch_registers)
14416         (aarch64_ravenscar_store_registers): Now methods.
14417         (aarch64_ravenscar_ops): Redefine.
14418
14419 2019-02-15  Tom Tromey  <tromey@adacore.com>
14420
14421         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14422         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14423         (ravenscar_thread_target::stopped_by_watchpoint)
14424         (ravenscar_thread_target::stopped_data_address)
14425         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14426
14427 2019-02-15  Tom Tromey  <tromey@adacore.com>
14428
14429         * ravenscar-thread.c: Fix some typos.
14430
14431 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14432             Tom Tromey  <tromey@adacore.com>
14433
14434         * ada-lang.c (ada_exception_sal): Change addr_string to a
14435         std::string.
14436         (create_ada_exception_catchpoint): Update.
14437
14438 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14439             Tom Tromey  <tromey@adacore.com>
14440
14441         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14442         (bp_location_ops): Remove.
14443         (base_breakpoint_allocate_location): Update.
14444         (free_bp_location): Update.
14445         * ada-lang.c (class ada_catchpoint_location)
14446         <ada_catchpoint_location>: Remove ops parameter.
14447         (ada_catchpoint_location_dtor): Remove.
14448         (ada_catchpoint_location_ops): Remove.
14449         (allocate_location_exception): Update.
14450         * breakpoint.h (struct bp_location_ops): Remove.
14451         (class bp_location) <bp_location>: Remove bp_location_ops
14452         parameter.
14453         <~bp_location>: Add destructor.
14454         <ops>: Remove.
14455
14456 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14457             Pedro Alves  <palves@redhat.com>
14458
14459         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14460         'PATH_MAX'.
14461
14462 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14463             Samuel Thibault  <samuel.thibault@gnu.org>
14464             Thomas Schwinge  <thomas@codesourcery.com>
14465
14466         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14467         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14468
14469 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14470
14471         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14472         (check_empty): Use "const char *".
14473
14474         * gnu-nat.c (gnu_nat_target::detach): Instead of
14475         'detach_inferior (pid)' call
14476         'detach_inferior (find_inferior_pid (pid))'.
14477
14478         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14479         'nat/fork-inferior.o'.
14480         * gnu-nat.c: #include "nat/fork-inferior.h".
14481
14482         * gnu-nat.c (gnu_nat_target::detach): Instead of
14483         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14484         * gnu-nat.h: #include "inf-child.h".
14485         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14486         'i386_gnu_nat_target::fetch_registers'.
14487         (gnu_store_registers): Rename/move to
14488         'i386_gnu_nat_target::store_registers'.
14489
14490         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14491         * gnu-nat.h (mach_thread_info): New function.
14492         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14493
14494         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14495
14496 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14497
14498         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14499
14500 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14501
14502         * windows-nat.c (windows_add_thread): Add new parameter
14503         "main_thread_p" with default value set to false.  Update
14504         function documentation as well as all callers.
14505         (windows_delete_thread): Likewise.
14506         (fake_create_process): Update call to windows_add_thread.
14507         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14508         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14509         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14510         call to windows_delete_thread.
14511
14512 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14513
14514         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14515
14516 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14517
14518         * symfile.c (find_separate_debug_file): Use canonical path of
14519         sysroot with child_path instead of gdb_sysroot if it is valid.
14520
14521 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14522
14523         * symfile.c (find_separate_debug_file): Use child_path to
14524         determine if an object file is under a sysroot.
14525
14526 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14527
14528         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14529         unittests/child-path-selftests.c.
14530         * common/pathstuff.c (child_path): New function.
14531         * common/pathstuff.h (child_path): New prototype.
14532         * unittests/child-path-selftests.c: New file.
14533
14534 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14535
14536         * symfile.c (find_separate_debug_file): Look for separate debug
14537         files in debug directories under the sysroot.
14538
14539 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14540
14541         * symtab.h (struct minimal_symbol data_p): New const method.
14542         (struct minimal_symbol text_p): Likewise.
14543         * symtab.c (output_source_filename): Use file name style
14544         to print file name.
14545         (print_symbol_info): Likewise.
14546         (print_msymbol_info): Use address style to print addresses.
14547         Use function name style to print executable text symbols.
14548         (expand_symtab_containing_pc): Use data_p.
14549         (find_pc_sect_compunit_symtab): Likewise.
14550
14551 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14552
14553         * breakpoint.c (describe_other_breakpoints): Use address style
14554         to print addresses.
14555         (say_where): Likewise.
14556
14557 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14558
14559         * ada-typeprint.c (print_func_type): Print function name
14560         style to print function name.
14561         * c-typeprint.c (c_print_type_1): Likewise.
14562
14563 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14564
14565         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14566         for execve.
14567
14568 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14569
14570         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14571         type_stack.
14572
14573 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14574
14575         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14576         TYPE_CODE_REF types.
14577
14578 2019-02-08  Jim Wilson  <jimw@sifive.com>
14579
14580         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14581         (riscv_linux_fregset): New.
14582         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14583
14584 2019-02-07  Tom Tromey  <tom@tromey.com>
14585
14586         * thread.c (thread_cancel_execution_command): Update.
14587         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14588         methods.
14589         (struct thread_fsm_ops): Remove.
14590         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14591         (thread_fsm_should_stop, thread_fsm_return_value)
14592         (thread_fsm_set_finished, thread_fsm_finished_p)
14593         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14594         Don't declare.
14595         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14596         * infrun.c (clear_proceed_status_thread)
14597         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14598         (print_stop_event): Update.
14599         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14600         Add constructor.
14601         (step_command_fsm_ops): Remove.
14602         (new_step_command_fsm): Remove.
14603         (step_1): Update.
14604         (step_command_fsm::should_stop): Rename from
14605         step_command_fsm_should_stop.
14606         (step_command_fsm::clean_up): Rename from
14607         step_command_fsm_clean_up.
14608         (step_command_fsm::do_async_reply_reason): Rename from
14609         step_command_fsm_async_reply_reason.
14610         (struct until_next_fsm): Inherit from thread_fsm.  Add
14611         constructor.
14612         (until_next_fsm_ops): Remove.
14613         (new_until_next_fsm): Remove.
14614         (until_next_fsm::should_stop): Rename from
14615         until_next_fsm_should_stop.
14616         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14617         (until_next_fsm::do_async_reply_reason): Rename from
14618         until_next_fsm_async_reply_reason.
14619         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14620         constructor.  Change type of breakpoint.
14621         (finish_command_fsm_ops): Remove.
14622         (new_finish_command_fsm): Remove.
14623         (finish_command_fsm::should_stop): Rename from
14624         finish_command_fsm_should_stop.
14625         (finish_command_fsm::clean_up): Rename from
14626         finish_command_fsm_clean_up.
14627         (finish_command_fsm::return_value): Rename from
14628         finish_command_fsm_return_value.
14629         (finish_command_fsm::do_async_reply_reason): Rename from
14630         finish_command_fsm_async_reply_reason.
14631         (finish_command): Update.
14632         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14633         Add constructor.
14634         (call_thread_fsm_ops): Remove.
14635         (call_thread_fsm::call_thread_fsm): Rename from
14636         new_call_thread_fsm.
14637         (call_thread_fsm::should_stop): Rename from
14638         call_thread_fsm_should_stop.
14639         (call_thread_fsm::should_notify_stop): Rename from
14640         call_thread_fsm_should_notify_stop.
14641         (run_inferior_call, call_function_by_hand_dummy): Update.
14642         * cli/cli-interp.c (should_print_stop_to_console): Update.
14643         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14644         Add constructor.  Change type of location_breakpoint,
14645         caller_breakpoint.
14646         (until_break_fsm_ops): Remove.
14647         (new_until_break_fsm): Remove.
14648         (until_break_fsm::should_stop): Rename from
14649         until_break_fsm_should_stop.
14650         (until_break_fsm::clean_up): Rename from
14651         until_break_fsm_clean_up.
14652         (until_break_fsm::do_async_reply_reason): Rename from
14653         until_break_fsm_async_reply_reason.
14654         (until_break_command): Update.
14655         * thread-fsm.c: Remove.
14656         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14657
14658 2019-02-07  Tom Tromey  <tom@tromey.com>
14659
14660         * yy-remap.h: Add include guard.
14661         * xtensa-tdep.h: Add include guard.
14662         * xcoffread.h: Rename include guard.
14663         * varobj-iter.h: Add include guard.
14664         * tui/tui.h: Rename include guard.
14665         * tui/tui-winsource.h: Rename include guard.
14666         * tui/tui-wingeneral.h: Rename include guard.
14667         * tui/tui-windata.h: Rename include guard.
14668         * tui/tui-win.h: Rename include guard.
14669         * tui/tui-stack.h: Rename include guard.
14670         * tui/tui-source.h: Rename include guard.
14671         * tui/tui-regs.h: Rename include guard.
14672         * tui/tui-out.h: Rename include guard.
14673         * tui/tui-layout.h: Rename include guard.
14674         * tui/tui-io.h: Rename include guard.
14675         * tui/tui-hooks.h: Rename include guard.
14676         * tui/tui-file.h: Rename include guard.
14677         * tui/tui-disasm.h: Rename include guard.
14678         * tui/tui-data.h: Rename include guard.
14679         * tui/tui-command.h: Rename include guard.
14680         * tic6x-tdep.h: Add include guard.
14681         * target/waitstatus.h: Rename include guard.
14682         * target/wait.h: Rename include guard.
14683         * target/target.h: Rename include guard.
14684         * target/resume.h: Rename include guard.
14685         * target-float.h: Rename include guard.
14686         * stabsread.h: Add include guard.
14687         * rs6000-tdep.h: Add include guard.
14688         * riscv-fbsd-tdep.h: Add include guard.
14689         * regformats/regdef.h: Rename include guard.
14690         * record.h: Rename include guard.
14691         * python/python.h: Rename include guard.
14692         * python/python-internal.h: Rename include guard.
14693         * python/py-stopevent.h: Rename include guard.
14694         * python/py-ref.h: Rename include guard.
14695         * python/py-record.h: Rename include guard.
14696         * python/py-record-full.h: Rename include guard.
14697         * python/py-record-btrace.h: Rename include guard.
14698         * python/py-instruction.h: Rename include guard.
14699         * python/py-events.h: Rename include guard.
14700         * python/py-event.h: Rename include guard.
14701         * procfs.h: Add include guard.
14702         * proc-utils.h: Add include guard.
14703         * p-lang.h: Add include guard.
14704         * or1k-tdep.h: Rename include guard.
14705         * observable.h: Rename include guard.
14706         * nto-tdep.h: Rename include guard.
14707         * nat/x86-linux.h: Rename include guard.
14708         * nat/x86-linux-dregs.h: Rename include guard.
14709         * nat/x86-gcc-cpuid.h: Add include guard.
14710         * nat/x86-dregs.h: Rename include guard.
14711         * nat/x86-cpuid.h: Rename include guard.
14712         * nat/ppc-linux.h: Rename include guard.
14713         * nat/mips-linux-watch.h: Rename include guard.
14714         * nat/linux-waitpid.h: Rename include guard.
14715         * nat/linux-ptrace.h: Rename include guard.
14716         * nat/linux-procfs.h: Rename include guard.
14717         * nat/linux-osdata.h: Rename include guard.
14718         * nat/linux-nat.h: Rename include guard.
14719         * nat/linux-namespaces.h: Rename include guard.
14720         * nat/linux-btrace.h: Rename include guard.
14721         * nat/glibc_thread_db.h: Rename include guard.
14722         * nat/gdb_thread_db.h: Rename include guard.
14723         * nat/gdb_ptrace.h: Rename include guard.
14724         * nat/fork-inferior.h: Rename include guard.
14725         * nat/amd64-linux-siginfo.h: Rename include guard.
14726         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14727         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14728         * nat/aarch64-linux.h: Rename include guard.
14729         * nat/aarch64-linux-hw-point.h: Rename include guard.
14730         * mn10300-tdep.h: Add include guard.
14731         * mips-linux-tdep.h: Add include guard.
14732         * mi/mi-parse.h: Rename include guard.
14733         * mi/mi-out.h: Rename include guard.
14734         * mi/mi-main.h: Rename include guard.
14735         * mi/mi-interp.h: Rename include guard.
14736         * mi/mi-getopt.h: Rename include guard.
14737         * mi/mi-console.h: Rename include guard.
14738         * mi/mi-common.h: Rename include guard.
14739         * mi/mi-cmds.h: Rename include guard.
14740         * mi/mi-cmd-break.h: Rename include guard.
14741         * m2-lang.h: Add include guard.
14742         * location.h: Rename include guard.
14743         * linux-record.h: Rename include guard.
14744         * linux-nat.h: Add include guard.
14745         * linux-fork.h: Add include guard.
14746         * i386-darwin-tdep.h: Rename include guard.
14747         * hppa-linux-offsets.h: Add include guard.
14748         * guile/guile.h: Rename include guard.
14749         * guile/guile-internal.h: Rename include guard.
14750         * gnu-nat.h: Rename include guard.
14751         * gdb-stabs.h: Rename include guard.
14752         * frv-tdep.h: Add include guard.
14753         * f-lang.h: Add include guard.
14754         * event-loop.h: Add include guard.
14755         * darwin-nat.h: Rename include guard.
14756         * cp-abi.h: Rename include guard.
14757         * config/sparc/nm-sol2.h: Rename include guard.
14758         * config/nm-nto.h: Rename include guard.
14759         * config/nm-linux.h: Add include guard.
14760         * config/i386/nm-i386gnu.h: Rename include guard.
14761         * config/djgpp/nl_types.h: Rename include guard.
14762         * config/djgpp/langinfo.h: Rename include guard.
14763         * compile/gcc-cp-plugin.h: Add include guard.
14764         * compile/gcc-c-plugin.h: Add include guard.
14765         * compile/compile.h: Rename include guard.
14766         * compile/compile-object-run.h: Rename include guard.
14767         * compile/compile-object-load.h: Rename include guard.
14768         * compile/compile-internal.h: Rename include guard.
14769         * compile/compile-cplus.h: Rename include guard.
14770         * compile/compile-c.h: Rename include guard.
14771         * common/xml-utils.h: Rename include guard.
14772         * common/x86-xstate.h: Rename include guard.
14773         * common/version.h: Rename include guard.
14774         * common/vec.h: Rename include guard.
14775         * common/tdesc.h: Rename include guard.
14776         * common/selftest.h: Rename include guard.
14777         * common/scoped_restore.h: Rename include guard.
14778         * common/scoped_mmap.h: Rename include guard.
14779         * common/scoped_fd.h: Rename include guard.
14780         * common/safe-iterator.h: Rename include guard.
14781         * common/run-time-clock.h: Rename include guard.
14782         * common/refcounted-object.h: Rename include guard.
14783         * common/queue.h: Rename include guard.
14784         * common/ptid.h: Rename include guard.
14785         * common/print-utils.h: Rename include guard.
14786         * common/preprocessor.h: Rename include guard.
14787         * common/pathstuff.h: Rename include guard.
14788         * common/observable.h: Rename include guard.
14789         * common/netstuff.h: Rename include guard.
14790         * common/job-control.h: Rename include guard.
14791         * common/host-defs.h: Rename include guard.
14792         * common/gdb_wait.h: Rename include guard.
14793         * common/gdb_vecs.h: Rename include guard.
14794         * common/gdb_unlinker.h: Rename include guard.
14795         * common/gdb_unique_ptr.h: Rename include guard.
14796         * common/gdb_tilde_expand.h: Rename include guard.
14797         * common/gdb_sys_time.h: Rename include guard.
14798         * common/gdb_string_view.h: Rename include guard.
14799         * common/gdb_splay_tree.h: Rename include guard.
14800         * common/gdb_setjmp.h: Rename include guard.
14801         * common/gdb_ref_ptr.h: Rename include guard.
14802         * common/gdb_optional.h: Rename include guard.
14803         * common/gdb_locale.h: Rename include guard.
14804         * common/gdb_assert.h: Rename include guard.
14805         * common/filtered-iterator.h: Rename include guard.
14806         * common/filestuff.h: Rename include guard.
14807         * common/fileio.h: Rename include guard.
14808         * common/environ.h: Rename include guard.
14809         * common/common-utils.h: Rename include guard.
14810         * common/common-types.h: Rename include guard.
14811         * common/common-regcache.h: Rename include guard.
14812         * common/common-inferior.h: Rename include guard.
14813         * common/common-gdbthread.h: Rename include guard.
14814         * common/common-exceptions.h: Rename include guard.
14815         * common/common-defs.h: Rename include guard.
14816         * common/common-debug.h: Rename include guard.
14817         * common/cleanups.h: Rename include guard.
14818         * common/buffer.h: Rename include guard.
14819         * common/btrace-common.h: Rename include guard.
14820         * common/break-common.h: Rename include guard.
14821         * cli/cli-utils.h: Rename include guard.
14822         * cli/cli-style.h: Rename include guard.
14823         * cli/cli-setshow.h: Rename include guard.
14824         * cli/cli-script.h: Rename include guard.
14825         * cli/cli-interp.h: Rename include guard.
14826         * cli/cli-decode.h: Rename include guard.
14827         * cli/cli-cmds.h: Rename include guard.
14828         * charset-list.h: Add include guard.
14829         * buildsym-legacy.h: Rename include guard.
14830         * bfin-tdep.h: Add include guard.
14831         * ax.h: Rename include guard.
14832         * arm-linux-tdep.h: Add include guard.
14833         * arm-fbsd-tdep.h: Add include guard.
14834         * arch/xtensa.h: Rename include guard.
14835         * arch/tic6x.h: Add include guard.
14836         * arch/i386.h: Add include guard.
14837         * arch/arm.h: Rename include guard.
14838         * arch/arm-linux.h: Rename include guard.
14839         * arch/arm-get-next-pcs.h: Rename include guard.
14840         * arch/amd64.h: Add include guard.
14841         * arch/aarch64-insn.h: Rename include guard.
14842         * arch-utils.h: Rename include guard.
14843         * annotate.h: Add include guard.
14844         * amd64-darwin-tdep.h: Rename include guard.
14845         * aarch64-linux-tdep.h: Add include guard.
14846         * aarch64-fbsd-tdep.h: Add include guard.
14847         * aarch32-linux-nat.h: Add include guard.
14848
14849 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14850
14851         * macrotab.c (macro_define_internal): New function that
14852         factorizes macro_define_object_internal and macro_define_function
14853         code.
14854         (macro_define_object_internal): Use macro_define_internal.
14855         (macro_define_function): Likewise.
14856
14857 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14858
14859         * macrocmd.c (extract_identifier): Return
14860         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14861         callers.
14862
14863 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14864
14865         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14866
14867 2019-02-05  Tom Tromey  <tom@tromey.com>
14868
14869         * target.c (target_stack::unpush): Move assertion earlier.
14870
14871 2019-01-30  Tom Tromey  <tom@tromey.com>
14872
14873         PR python/23615:
14874         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14875         (gdbpy_parse_and_eval): Likewise.
14876         * python/python-internal.h (gdbpy_allow_threads): New class.
14877
14878 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14879
14880         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14881         (aarch64_fbsd_fpregmap): Move earlier.
14882         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14883         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14884         instead of individual calls to trad_frame_set_reg_addr.
14885         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14886         earlier.
14887         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14888         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14889         instead of individual calls to trad_frame_set_reg_addr.
14890
14891 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14892
14893         * CONTRIBUTE: Replace contribution list with wiki link.
14894
14895 2019-01-25  Tom Tromey  <tom@tromey.com>
14896
14897         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14898
14899 2019-01-25  Tom Tromey  <tom@tromey.com>
14900
14901         * xtensa-linux-nat.c: Fix common/ includes.
14902         * xml-support.h: Fix common/ includes.
14903         * xml-support.c: Fix common/ includes.
14904         * x86-linux-nat.c: Fix common/ includes.
14905         * windows-nat.c: Fix common/ includes.
14906         * varobj.h: Fix common/ includes.
14907         * varobj.c: Fix common/ includes.
14908         * value.c: Fix common/ includes.
14909         * valops.c: Fix common/ includes.
14910         * utils.c: Fix common/ includes.
14911         * unittests/xml-utils-selftests.c: Fix common/ includes.
14912         * unittests/utils-selftests.c: Fix common/ includes.
14913         * unittests/unpack-selftests.c: Fix common/ includes.
14914         * unittests/tracepoint-selftests.c: Fix common/ includes.
14915         * unittests/style-selftests.c: Fix common/ includes.
14916         * unittests/string_view-selftests.c: Fix common/ includes.
14917         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14918         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14919         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14920         * unittests/rsp-low-selftests.c: Fix common/ includes.
14921         * unittests/parse-connection-spec-selftests.c: Fix common/
14922         includes.
14923         * unittests/optional-selftests.c: Fix common/ includes.
14924         * unittests/offset-type-selftests.c: Fix common/ includes.
14925         * unittests/observable-selftests.c: Fix common/ includes.
14926         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14927         * unittests/memrange-selftests.c: Fix common/ includes.
14928         * unittests/memory-map-selftests.c: Fix common/ includes.
14929         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14930         * unittests/function-view-selftests.c: Fix common/ includes.
14931         * unittests/environ-selftests.c: Fix common/ includes.
14932         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14933         * unittests/common-utils-selftests.c: Fix common/ includes.
14934         * unittests/cli-utils-selftests.c: Fix common/ includes.
14935         * unittests/array-view-selftests.c: Fix common/ includes.
14936         * ui-file.c: Fix common/ includes.
14937         * tui/tui-io.c: Fix common/ includes.
14938         * tracepoint.h: Fix common/ includes.
14939         * tracepoint.c: Fix common/ includes.
14940         * tracefile-tfile.c: Fix common/ includes.
14941         * top.h: Fix common/ includes.
14942         * top.c: Fix common/ includes.
14943         * thread.c: Fix common/ includes.
14944         * target/waitstatus.h: Fix common/ includes.
14945         * target/waitstatus.c: Fix common/ includes.
14946         * target.h: Fix common/ includes.
14947         * target.c: Fix common/ includes.
14948         * target-memory.c: Fix common/ includes.
14949         * target-descriptions.c: Fix common/ includes.
14950         * symtab.h: Fix common/ includes.
14951         * symfile.c: Fix common/ includes.
14952         * stap-probe.c: Fix common/ includes.
14953         * spu-linux-nat.c: Fix common/ includes.
14954         * sparc-nat.c: Fix common/ includes.
14955         * source.c: Fix common/ includes.
14956         * solib.c: Fix common/ includes.
14957         * solib-target.c: Fix common/ includes.
14958         * ser-unix.c: Fix common/ includes.
14959         * ser-tcp.c: Fix common/ includes.
14960         * ser-pipe.c: Fix common/ includes.
14961         * ser-base.c: Fix common/ includes.
14962         * selftest-arch.c: Fix common/ includes.
14963         * s12z-tdep.c: Fix common/ includes.
14964         * rust-exp.y: Fix common/ includes.
14965         * rs6000-aix-tdep.c: Fix common/ includes.
14966         * riscv-tdep.c: Fix common/ includes.
14967         * remote.c: Fix common/ includes.
14968         * remote-notif.h: Fix common/ includes.
14969         * remote-fileio.h: Fix common/ includes.
14970         * remote-fileio.c: Fix common/ includes.
14971         * regcache.h: Fix common/ includes.
14972         * regcache.c: Fix common/ includes.
14973         * record-btrace.c: Fix common/ includes.
14974         * python/python.c: Fix common/ includes.
14975         * python/py-type.c: Fix common/ includes.
14976         * python/py-inferior.c: Fix common/ includes.
14977         * progspace.h: Fix common/ includes.
14978         * producer.c: Fix common/ includes.
14979         * procfs.c: Fix common/ includes.
14980         * proc-api.c: Fix common/ includes.
14981         * printcmd.c: Fix common/ includes.
14982         * ppc-linux-nat.c: Fix common/ includes.
14983         * parser-defs.h: Fix common/ includes.
14984         * osdata.c: Fix common/ includes.
14985         * obsd-nat.c: Fix common/ includes.
14986         * nat/x86-linux.c: Fix common/ includes.
14987         * nat/x86-linux-dregs.c: Fix common/ includes.
14988         * nat/x86-dregs.h: Fix common/ includes.
14989         * nat/x86-dregs.c: Fix common/ includes.
14990         * nat/ppc-linux.c: Fix common/ includes.
14991         * nat/mips-linux-watch.h: Fix common/ includes.
14992         * nat/mips-linux-watch.c: Fix common/ includes.
14993         * nat/linux-waitpid.c: Fix common/ includes.
14994         * nat/linux-ptrace.h: Fix common/ includes.
14995         * nat/linux-ptrace.c: Fix common/ includes.
14996         * nat/linux-procfs.c: Fix common/ includes.
14997         * nat/linux-personality.c: Fix common/ includes.
14998         * nat/linux-osdata.c: Fix common/ includes.
14999         * nat/linux-namespaces.c: Fix common/ includes.
15000         * nat/linux-btrace.h: Fix common/ includes.
15001         * nat/linux-btrace.c: Fix common/ includes.
15002         * nat/fork-inferior.c: Fix common/ includes.
15003         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15004         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15005         * nat/aarch64-linux.c: Fix common/ includes.
15006         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15007         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15008         * namespace.h: Fix common/ includes.
15009         * mips-linux-tdep.c: Fix common/ includes.
15010         * minsyms.c: Fix common/ includes.
15011         * mi/mi-parse.h: Fix common/ includes.
15012         * mi/mi-main.c: Fix common/ includes.
15013         * mi/mi-cmd-env.c: Fix common/ includes.
15014         * memrange.h: Fix common/ includes.
15015         * memattr.c: Fix common/ includes.
15016         * maint.h: Fix common/ includes.
15017         * maint.c: Fix common/ includes.
15018         * main.c: Fix common/ includes.
15019         * machoread.c: Fix common/ includes.
15020         * location.c: Fix common/ includes.
15021         * linux-thread-db.c: Fix common/ includes.
15022         * linux-nat.c: Fix common/ includes.
15023         * linux-fork.c: Fix common/ includes.
15024         * inline-frame.c: Fix common/ includes.
15025         * infrun.c: Fix common/ includes.
15026         * inflow.c: Fix common/ includes.
15027         * inferior.h: Fix common/ includes.
15028         * inferior.c: Fix common/ includes.
15029         * infcmd.c: Fix common/ includes.
15030         * inf-ptrace.c: Fix common/ includes.
15031         * inf-child.c: Fix common/ includes.
15032         * ia64-linux-nat.c: Fix common/ includes.
15033         * i387-tdep.c: Fix common/ includes.
15034         * i386-tdep.c: Fix common/ includes.
15035         * i386-linux-tdep.c: Fix common/ includes.
15036         * i386-linux-nat.c: Fix common/ includes.
15037         * i386-go32-tdep.c: Fix common/ includes.
15038         * i386-fbsd-tdep.c: Fix common/ includes.
15039         * i386-fbsd-nat.c: Fix common/ includes.
15040         * guile/scm-type.c: Fix common/ includes.
15041         * guile/guile.c: Fix common/ includes.
15042         * go32-nat.c: Fix common/ includes.
15043         * gnu-nat.c: Fix common/ includes.
15044         * gdbthread.h: Fix common/ includes.
15045         * gdbarch-selftests.c: Fix common/ includes.
15046         * gdb_usleep.c: Fix common/ includes.
15047         * gdb_select.h: Fix common/ includes.
15048         * gdb_bfd.c: Fix common/ includes.
15049         * gcore.c: Fix common/ includes.
15050         * fork-child.c: Fix common/ includes.
15051         * findvar.c: Fix common/ includes.
15052         * fbsd-nat.c: Fix common/ includes.
15053         * event-top.c: Fix common/ includes.
15054         * event-loop.c: Fix common/ includes.
15055         * dwarf2read.c: Fix common/ includes.
15056         * dwarf2loc.c: Fix common/ includes.
15057         * dwarf2-frame.c: Fix common/ includes.
15058         * dwarf-index-cache.c: Fix common/ includes.
15059         * dtrace-probe.c: Fix common/ includes.
15060         * disasm-selftests.c: Fix common/ includes.
15061         * defs.h: Fix common/ includes.
15062         * csky-tdep.c: Fix common/ includes.
15063         * cp-valprint.c: Fix common/ includes.
15064         * cp-support.h: Fix common/ includes.
15065         * cp-support.c: Fix common/ includes.
15066         * corelow.c: Fix common/ includes.
15067         * completer.h: Fix common/ includes.
15068         * completer.c: Fix common/ includes.
15069         * compile/compile.c: Fix common/ includes.
15070         * compile/compile-loc2c.c: Fix common/ includes.
15071         * compile/compile-cplus-types.c: Fix common/ includes.
15072         * compile/compile-cplus-symbols.c: Fix common/ includes.
15073         * command.h: Fix common/ includes.
15074         * cli/cli-dump.c: Fix common/ includes.
15075         * cli/cli-cmds.c: Fix common/ includes.
15076         * charset.c: Fix common/ includes.
15077         * build-id.c: Fix common/ includes.
15078         * btrace.h: Fix common/ includes.
15079         * btrace.c: Fix common/ includes.
15080         * breakpoint.h: Fix common/ includes.
15081         * breakpoint.c: Fix common/ includes.
15082         * ax.h:
15083         (enum agent_op): Fix common/ includes.
15084         * ax-general.c (struct aop_map): Fix common/ includes.
15085         * ax-gdb.c: Fix common/ includes.
15086         * auxv.c: Fix common/ includes.
15087         * auto-load.c: Fix common/ includes.
15088         * arm-tdep.c: Fix common/ includes.
15089         * arch/riscv.c: Fix common/ includes.
15090         * arch/ppc-linux-common.c: Fix common/ includes.
15091         * arch/i386.c: Fix common/ includes.
15092         * arch/arm.c: Fix common/ includes.
15093         * arch/arm-linux.c: Fix common/ includes.
15094         * arch/arm-get-next-pcs.c: Fix common/ includes.
15095         * arch/amd64.c: Fix common/ includes.
15096         * arch/aarch64.c: Fix common/ includes.
15097         * arch/aarch64-insn.c: Fix common/ includes.
15098         * arch-utils.c: Fix common/ includes.
15099         * amd64-windows-tdep.c: Fix common/ includes.
15100         * amd64-tdep.c: Fix common/ includes.
15101         * amd64-sol2-tdep.c: Fix common/ includes.
15102         * amd64-obsd-tdep.c: Fix common/ includes.
15103         * amd64-nbsd-tdep.c: Fix common/ includes.
15104         * amd64-linux-tdep.c: Fix common/ includes.
15105         * amd64-linux-nat.c: Fix common/ includes.
15106         * amd64-fbsd-tdep.c: Fix common/ includes.
15107         * amd64-fbsd-nat.c: Fix common/ includes.
15108         * amd64-dicos-tdep.c: Fix common/ includes.
15109         * amd64-darwin-tdep.c: Fix common/ includes.
15110         * agent.c: Fix common/ includes.
15111         * ada-lang.h: Fix common/ includes.
15112         * ada-lang.c: Fix common/ includes.
15113         * aarch64-tdep.c: Fix common/ includes.
15114
15115 2019-01-25  Tom Tromey  <tom@tromey.com>
15116
15117         * common/create-version.sh: Use common/version.h.
15118
15119 2019-01-24  Pedro Alves  <palves@redhat.com>
15120
15121         * infrun.c (signal_stop, signal_print, signal_program)
15122         (signal_catch, signal_pass): Now arrays instead of pointers.
15123         (update_signals_program_target, do_target_resume)
15124         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15125         * linux-nat.c (linux_nat_target::pass_signals)
15126         (linux_nat_target::create_inferior, linux_nat_target::attach):
15127         Adjust.
15128         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15129         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15130         * procfs.c (procfs_target::pass_signals): Adjust.
15131         * record-full.c (record_full_target::resume): Adjust.
15132         * remote.c (remote_target::pass_signals)
15133         (remote_target::program_signals): Adjust.
15134         * target-debug.h (target_debug_print_signals): Now takes a
15135         gdb::array_view as parameter.  Adjust.
15136         * target.h (target_ops) <pass_signals, program_signals>: Replace
15137         pointer and length parameters with gdb::array_view.
15138         (target_pass_signals, target_program_signals): Likewise.
15139         * target-delegates.c: Regenerate.
15140
15141 2019-01-24  Pedro Alves  <palves@redhat.com>
15142
15143         * common/forward-scope-exit.h
15144         (forward_scope_exit::forward_scope_exit): Pass arguments to
15145         m_bind_function directly, instead of creating a std::bind and
15146         copying that.
15147
15148 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15149
15150         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15151         for static members.
15152         (pass_in_v_vfp_candidate): Likewise.
15153
15154 2019-01-23  Tom Tromey  <tom@tromey.com>
15155             Pedro Alves  <palves@redhat.com>
15156
15157         * regcache.c (class regcache_invalidator): Remove.
15158         (regcache::raw_write): Use make_scope_exit.
15159
15160 2019-01-23  Tom Tromey  <tom@tromey.com>
15161
15162         * ui-out.h (class ui_out_emit_type): Update comment.
15163
15164 2019-01-23  Tom Tromey  <tom@tromey.com>
15165
15166         * infrun.c (fetch_inferior_event): Update comment.
15167
15168 2019-01-23  Tom Tromey  <tom@tromey.com>
15169             Pedro Alves  <palves@redhat.com>
15170
15171         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15172         parameter.
15173         (fetch_inferior_event): Use SCOPE_EXIT.
15174
15175
15176 2019-01-23  Tom Tromey  <tom@tromey.com>
15177             Pedro Alves  <palves@redhat.com>
15178
15179         * infrun.c (disable_thread_events): Delete.
15180         (stop_all_threads): Use SCOPE_EXIT.
15181
15182 2019-01-23  Tom Tromey  <tom@tromey.com>
15183             Pedro Alves  <palves@redhat.com>
15184
15185         * symfile.c: Include forward-scope-exit.h.
15186         (clear_symtab_users_cleanup): Replace forward declaration with
15187         a FORWARD_SCOPE_EXIT.
15188         (syms_from_objfile_1): Use the forward_scope_exit and
15189         gdb::optional instead of cleanup_function.
15190         (reread_symbols): Use the forward_scope_exit instead of
15191         cleanup_function.
15192         (clear_symtab_users_cleanup): Remove function.
15193
15194 2019-01-23  Tom Tromey  <tom@tromey.com>
15195             Pedro Alves  <palves@redhat.com>
15196
15197         * linux-nat.c: Include scope-exit.h.
15198         (cleanup_target_stop): Remove.
15199         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15200         SCOPE_EXIT.
15201
15202 2019-01-23  Tom Tromey  <tom@tromey.com>
15203             Pedro Alves  <palves@redhat.com>
15204
15205         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15206         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15207
15208 2019-01-23  Tom Tromey  <tom@tromey.com>
15209             Andrew Burgess  <andrew.burgess@embecosm.com>
15210             Pedro Alves  <palves@redhat.com>
15211
15212         * infrun.c (fetch_inferior_event): Use scope_exit.
15213         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15214         * top.c (execute_command): Use scope_exit.
15215         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15216         * utils.c (do_bpstat_clear_actions_cleanup)
15217         (make_bpstat_clear_actions_cleanup): Remove.
15218
15219 2019-01-23  Tom Tromey  <tom@tromey.com>
15220             Pedro Alves  <palves@redhat.com>
15221
15222         * infrun.c: Include "common/scope-exit.h"
15223         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15224         (wait_for_inferior): Use SCOPE_EXIT.
15225         (fetch_inferior_event): Use scope_exit.
15226
15227 2019-01-23  Tom Tromey  <tom@tromey.com>
15228             Pedro Alves  <palves@redhat.com>
15229
15230         * breakpoint.c (create_breakpoint): Remove cleanup.
15231
15232 2019-01-23  Tom Tromey  <tom@tromey.com>
15233             Andrew Burgess  <andrew.burgess@embecosm.com>
15234             Pedro Alves  <palves@redhat.com>
15235
15236 2019-01-23  Pedro Alves  <palves@redhat.com>
15237
15238         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15239
15240 2019-01-23  Pedro Alves  <palves@redhat.com>
15241             Andrew Burgess  <andrew.burgess@embecosm.com>
15242
15243         * gdbthread.h: Include "common/forward-scope-exit.h".
15244         (scoped_finish_thread_state): Redefine custom class in terms of
15245         forward_scope_exit.
15246
15247 2019-01-23  Pedro Alves  <palves@redhat.com>
15248             Andrew Burgess  <andrew.burgess@embecosm.com>
15249
15250         * common/forward-scope-exit.h: New file.
15251
15252 2019-01-23  Pedro Alves  <palves@redhat.com>
15253             Andrew Burgess  <andrew.burgess@embecosm.com>
15254             Tom Tromey  <tom@tromey.com>
15255
15256         * common/scope-exit.h: New file.
15257
15258 2019-01-23  Pedro Alves  <palves@redhat.com>
15259
15260         * common/preprocessor.h (ESC): Rename to ...
15261         (ESC_PARENS): ... this.
15262         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15263         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15264
15265 2019-01-23  Tom Tromey  <tom@tromey.com>
15266
15267         * language.h (class scoped_switch_to_sym_language_if_auto):
15268         Initialize m_lang in both cases.
15269
15270 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15271
15272         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15273         with XCNEW.
15274
15275 2019-01-22  Tom Tromey  <tom@tromey.com>
15276
15277         * corelow.c: Do not include sys/file.h.
15278
15279 2019-01-22  Tom Tromey  <tom@tromey.com>
15280
15281         * tui/tui-wingeneral.h: Include gdb_curses.h.
15282
15283 2019-01-22  Tom Tromey  <tom@tromey.com>
15284
15285         * source-cache.h (class source_cache) <get_source_lines,
15286         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15287
15288 2019-01-22  Tom Tromey  <tom@tromey.com>
15289
15290         * remote-fileio.h (struct remote_target): Declare.
15291
15292 2019-01-22  Tom Tromey  <tom@tromey.com>
15293
15294         * python/py-arch.c: Do not include py-ref.h.
15295         * python/py-bpevent.c: Do not include py-ref.h.
15296         * python/py-cmd.c: Do not include py-ref.h.
15297         * python/py-continueevent.c: Do not include py-ref.h.
15298         * python/py-event.h: Do not include py-ref.h.
15299         * python/py-evtregistry.c: Do not include py-ref.h.
15300         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15301         * python/py-frame.c: Do not include py-ref.h.
15302         * python/py-framefilter.c: Do not include py-ref.h.
15303         * python/py-function.c: Do not include py-ref.h.
15304         * python/py-infevents.c: Do not include py-ref.h.
15305         * python/py-linetable.c: Do not include py-ref.h.
15306         * python/py-objfile.c: Do not include py-ref.h.
15307         * python/py-param.c: Do not include py-ref.h.
15308         * python/py-prettyprint.c: Do not include py-ref.h.
15309         * python/py-progspace.c: Do not include py-ref.h.
15310         * python/py-symbol.c: Do not include py-ref.h.
15311         * python/py-symtab.c: Do not include py-ref.h.
15312         * python/py-type.c: Do not include py-ref.h.
15313         * python/py-unwind.c: Do not include py-ref.h.
15314         * python/py-utils.c: Do not include py-ref.h.
15315         * python/py-value.c: Do not include py-ref.h.
15316         * python/py-varobj.c: Do not include py-ref.h.
15317         * python/py-xmethods.c: Do not include py-ref.h.
15318         * python/python.c: Do not include py-ref.h.
15319         * varobj.c: Do not include py-ref.h.
15320
15321 2019-01-22  Tom Tromey  <tom@tromey.com>
15322
15323         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15324         keyword for bcache.
15325
15326 2019-01-22  Tom Tromey  <tom@tromey.com>
15327
15328         * compile/compile-cplus-types.c: Remove a comment by #include.
15329
15330 2019-01-22  Tom Tromey  <tom@tromey.com>
15331
15332         * compile/gcc-c-plugin.h: Include compile-internal.h.
15333
15334 2019-01-22  Tom Tromey  <tom@tromey.com>
15335
15336         * stabsread.c (EXTERN): Do not define.
15337         (symnum, next_symbol_text_func, processing_gcc_compilation)
15338         (within_function, global_sym_chain, global_stabs)
15339         (previous_stab_code, this_object_header_files)
15340         (n_this_object_header_files)
15341         (n_allocated_this_object_header_files): Define.
15342         * stabsread.h (EXTERN): Never define.  Use "extern".
15343
15344 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15345
15346         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15347         history_value.
15348
15349 2019-01-21  Tom Tromey  <tom@tromey.com>
15350
15351         * ui-out.c: Fix includes.
15352         * tui/tui-source.c: Fix includes.
15353         * target.c: Fix includes.
15354         * remote.c: Fix includes.
15355         * regcache.c: Fix includes.
15356         * python/py-block.c: Fix includes.
15357         * printcmd.c: Fix includes.
15358         * or1k-tdep.c: Fix includes.
15359         * mi/mi-main.c: Fix includes.
15360         * m32r-tdep.c: Fix includes.
15361         * csky-tdep.c: Fix includes.
15362         * compile/compile-cplus-types.c: Fix includes.
15363         * cli/cli-interp.c: Fix includes.
15364
15365 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15366
15367         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15368         for padding.
15369
15370 2019-01-16  Tom Tromey  <tom@tromey.com>
15371
15372         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15373         earlier.
15374         (struct objfile) <msymbols_range>: Move from top level.
15375         <msymbols>: New method.
15376         (class objfile_msymbols): Remove.
15377         * symtab.c (default_collect_symbol_completion_matches_break_on):
15378         Update.
15379         * symmisc.c (dump_msymbols): Update.
15380         * stabsread.c (scan_file_globals): Update.
15381         * objc-lang.c (info_selectors_command, info_classes_command)
15382         (find_methods): Update.
15383         * minsyms.c (find_solib_trampoline_target): Update.
15384         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15385         * coffread.c (coff_symfile_read): Update.
15386         * ada-lang.c (ada_lookup_simple_minsym)
15387         (ada_collect_symbol_completion_matches): Update.
15388
15389 2019-01-16  Tom Tromey  <tom@tromey.com>
15390
15391         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15392         type.  Remove no-argument constructor.
15393         <iterator::operator++>: Simplify.
15394         <begin>: Update.
15395         <end>: Use minimal_symbol_count.
15396
15397 2019-01-16  Tom Tromey  <tom@tromey.com>
15398
15399         * objfiles.h (struct objfile) <psymtabs>: New method.
15400         (class objfile_psymtabs): Remove.
15401         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15402         typedef.
15403         <range>: New method.
15404         (require_partial_symbols): Change return type.
15405         * psymtab.c (require_partial_symbols)
15406         (psym_expand_symtabs_matching): Update.
15407         * mdebugread.c (parse_partial_symbols): Update.
15408         * dbxread.c (dbx_end_psymtab): Update.
15409
15410 2019-01-15  Tom Tromey  <tom@tromey.com>
15411
15412         * symtab.c (lookup_objfile_from_block)
15413         (lookup_symbol_in_objfile_symtabs)
15414         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15415         (find_line_symtab, info_sources_command)
15416         (default_collect_symbol_completion_matches_break_on)
15417         (make_source_files_completion_list): Update.
15418         * symmisc.c (print_objfile_statistics, dump_objfile)
15419         (maintenance_print_symbols, maintenance_info_symtabs)
15420         (maintenance_check_symtabs, maintenance_info_line_tables):
15421         Update.
15422         * source.c (select_source_symtab)
15423         (forget_cached_source_info_for_objfile): Update.
15424         * objfiles.h (class objfile_compunits): Remove.
15425         (struct objfile) <compunits_range>: New typedef.
15426         (compunits): New method.
15427         * objfiles.c (objfile_relocate1): Update.
15428         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15429         * maint.c (count_symtabs_and_blocks): Update.
15430         * linespec.c (iterate_over_all_matching_symtabs): Update.
15431         * cp-support.c (add_symbol_overload_list_qualified): Update.
15432         * coffread.c (coff_symtab_read): Update.
15433         * ada-lang.c (add_nonlocal_symbols)
15434         (ada_collect_symbol_completion_matches)
15435         (ada_add_global_exceptions): Update.
15436
15437 2019-01-15  Tom Tromey  <tom@tromey.com>
15438
15439         * progspace.h (program_space) <objfiles_safe_range>: New
15440         typedef.
15441         <objfiles_safe>: New method.
15442         * objfiles.h (class all_objfiles_safe): Remove.
15443         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15444         * jit.c (jit_inferior_exit_hook): Update.
15445
15446 2019-01-17  Tom Tromey  <tom@tromey.com>
15447
15448         * progspace.h (program_space) <objfiles_range>: New typedef.
15449         <objfiles>: New method.
15450         <objfiles_head>: Rename from objfiles.
15451         (object_files): Update.
15452         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15453         * guile/scm-pretty-print.c
15454         (ppscm_find_pretty_printer_from_objfiles): Update.
15455         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15456         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15457         Update.
15458         * python/py-progspace.c (pspy_get_objfiles): Update.
15459         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15460         Update.
15461         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15462         (objfpy_lookup_objfile_by_build_id): Update.
15463         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15464         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15465         Update.
15466         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15467         (expand_symtab_containing_pc, lookup_objfile_from_block)
15468         (lookup_static_symbol, basic_lookup_transparent_type)
15469         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15470         (find_line_symtab, info_sources_command)
15471         (default_collect_symbol_completion_matches_break_on)
15472         (make_source_files_completion_list, find_main_name): Update.
15473         * symmisc.c (print_symbol_bcache_statistics)
15474         (print_objfile_statistics, maintenance_print_symbols)
15475         (maintenance_print_msymbols, maintenance_print_objfiles)
15476         (maintenance_info_symtabs, maintenance_check_symtabs)
15477         (maintenance_expand_symtabs, maintenance_info_line_tables):
15478         Update.
15479         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15480         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15481         (map_overlay_command, unmap_overlay_command)
15482         (simple_overlay_update, expand_symtabs_matching)
15483         (map_symbol_filenames): Update.
15484         * symfile-debug.c (set_debug_symfile): Update.
15485         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15486         Update.
15487         * source.c (select_source_symtab, forget_cached_source_info):
15488         Update.
15489         * solib.c (solib_read_symbols): Update.
15490         * solib-spu.c (append_ocl_sos): Update.
15491         * psymtab.c (maintenance_print_psymbols)
15492         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15493         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15494         * printcmd.c (info_symbol_command): Update.
15495         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15496         Update.
15497         * objfiles.h (class all_objfiles): Remove.
15498         * objfiles.c (have_partial_symbols, have_full_symbols)
15499         (have_minimal_symbols, qsort_cmp, update_section_map)
15500         (shared_objfile_contains_address_p)
15501         (default_iterate_over_objfiles_in_search_order): Update.
15502         * objc-lang.c (info_selectors_command, info_classes_command)
15503         (find_methods): Update.
15504         * minsyms.c (find_solib_trampoline_target): Update.
15505         * maint.c (maintenance_info_sections)
15506         (maintenance_translate_address, count_symtabs_and_blocks):
15507         Update.
15508         * main.c (captured_main_1): Update.
15509         * linux-thread-db.c (try_thread_db_load_from_pdir)
15510         (has_libpthread): Update.
15511         * linespec.c (iterate_over_all_matching_symtabs)
15512         (search_minsyms_for_name): Update.
15513         * jit.c (jit_find_objf_with_entry_addr): Update.
15514         * hppa-tdep.c (find_unwind_entry)
15515         (hppa_lookup_stub_minimal_symbol): Update.
15516         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15517         Update.
15518         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15519         (elf_gnu_ifunc_resolve_by_got): Update.
15520         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15521         * dwarf-index-write.c (save_gdb_index_command): Update.
15522         * cp-support.c (add_symbol_overload_list_qualified): Update.
15523         * breakpoint.c (create_overlay_event_breakpoint)
15524         (create_longjmp_master_breakpoint)
15525         (create_std_terminate_master_breakpoint)
15526         (create_exception_master_breakpoint): Update.
15527         * blockframe.c (find_pc_partial_function): Update.
15528         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15529         (ada_collect_symbol_completion_matches)
15530         (ada_add_global_exceptions): Update.
15531
15532 2019-01-17  Tom Tromey  <tom@tromey.com>
15533
15534         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15535         declare VEC.
15536         (solib_target_parse_libraries): Change return type.
15537         (library_list_start_segment, library_list_start_section)
15538         (library_list_end_library, library_list_start_library); Update.
15539         (solib_target_free_library_list): Remove.
15540         (solib_target_parse_libraries): Remove cleanup.  Change return
15541         type.
15542         (solib_target_current_sos): Update.
15543
15544 2019-01-17  Tom Tromey  <tromey@bapiya>
15545
15546         * valprint.c: Replace "the the" with "the".
15547         * symtab.c: Replace "the the" with "the".
15548         * solib.c: Replace "the the" with "the".
15549         * solib-dsbt.c: Replace "the the" with "the".
15550         * linespec.c: Replace "the the" with "the".
15551         * dwarf2loc.h: Replace "the the" with "the".
15552         * amd64-windows-tdep.c: Replace "the the" with "the".
15553         * aarch64-tdep.c: Replace "the the" with "the".
15554
15555 2019-01-16  Keith Seitz  <keiths@redhat.com>
15556
15557         PR gdb/23773
15558         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15559         <builder>: Rename to ..
15560         <m_builder>: ... this and make private.
15561         (dwarf2_cu::get_builder): New method.  Change all users of
15562         `builder' to use this method.
15563         (dwarf2_start_symtab): Move to ...
15564         (dwarf2_cu::start_symtab): ... here.  Update all callers
15565         (setup_type_unit_groups): Move to ...
15566         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15567         callers.
15568         (dwarf2_cu::reset_builder): New method.
15569         (process_full_compunit, process_full_type_unit): Use
15570         dwarf2_cu::reset_builder.
15571         (follow_die_offset): Record the ancestor CU if it is different
15572         from the followed DIE's CU.
15573         (follow_die_sig_1): Likewise.
15574
15575 2019-01-15  Tom Tromey  <tom@tromey.com>
15576
15577         * remote.c (class remote_state) <buf>: Now a char_vector.
15578         <buf_size>: Remove.
15579         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15580         parameter.
15581         (remote_target::getpkt_or_notif_sane_1)
15582         (remote_target::getpkt_sane)
15583         (remote_target::getpkt_or_notif_sane): Likewise.
15584         (class remote_target) <putpkt>: New overload.
15585         (remote_target::read_frame): Change type of "buf_p".  Remove
15586         sizeof_p parameter.
15587         (packet_ok): New overload.
15588         (packet_check_result): New overload.
15589         Update all uses.
15590
15591 2019-01-14  Tom Tromey  <tom@tromey.com>
15592
15593         * remote-notif.c (handle_notification, remote_notif_ack)
15594         (remote_notif_parse): Make "buf" const.
15595         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15596         const.
15597         (remote_notif_parse, remote_notif_ack, handle_notification):
15598         Likewise.
15599         * remote.c (remote_notif_stop_parse): Make "buf" const.
15600         (remote_target::remote_parse_stop_reply): Make "buf" const.
15601         (remote_notif_stop_ack): Make "buf" const.
15602
15603 2019-01-14  Tom Tromey  <tom@tromey.com>
15604
15605         * remote.c (remote_console_output): Make parameter const.
15606
15607 2019-01-14  Tom Tromey  <tom@tromey.com>
15608
15609         * target-debug.h (target_debug_print_signals): Constify.
15610         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15611         * procfs.c (procfs_target::pass_signals): Update.
15612         * linux-nat.c (linux_nat_target::pass_signals): Update.
15613         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15614         * target-delegates.c: Rebuild.
15615         * remote.c (remote_target::program_signals): Update.
15616         (remote_target::pass_signals): Update.
15617         * target.c (target_pass_signals): Constify argument.
15618         (target_program_signals): Likewise.
15619         * target.h (struct target_ops) <pass_signals, program_signals>:
15620         Constify argument.
15621         (target_pass_signals, target_program_signals): Constify argument.
15622
15623 2019-01-14  Tom Tromey  <tom@tromey.com>
15624
15625         PR tui/28819:
15626         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15627
15628 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15629
15630         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15631         field.
15632         * rs6000-tdep.c: Include reggroups.h.
15633         (IS_V_ALIAS_PSEUDOREG): Define.
15634         (rs6000_register_name): Return names for the "vX" aliases.
15635         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15636         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15637         aliases.  Call default_register_reggroup_p for all other
15638         pseudo-registers.
15639         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15640         New functions.
15641         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15642         Handle "vX" aliases.
15643         (v_alias_pseudo_register_collect): New function.
15644         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15645         (rs6000_gdbarch_init): Initialize "vX" aliases as
15646         pseudo-registers.  Restore registration of
15647         rs6000_pseudo_register_reggroup_p with
15648         set_tdesc_pseudo_register_reggroup_p.
15649
15650 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15651
15652         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15653         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15654         set_gdbarch_num_pseudo_regs.
15655
15656 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15657
15658         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15659         Remove arg prefixname, add do_set and do_show.
15660         Add member functions set_list and show_list.
15661         * cli/cli-style.c (class cli_style_option): Update accordingly.
15662         (style_set_list): Move to file scope.
15663         (style_show_list): Likewise.
15664         (set_style): Call help_list.
15665         (show_style): Call cmd_show_list.
15666         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15667         Update to use the new macro.
15668
15669 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15670
15671         * ada-lang.c (_initialize_ada_language): Expand the help text
15672         for the "catch exception" command.
15673
15674 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15675
15676         * symtab.c (matching_obj_sections): Initialize obj,
15677         declare it closer to its usage.
15678
15679 2019-01-10  Tom Tromey  <tom@tromey.com>
15680
15681         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15682         (basic_inf_threads_range): Remove.
15683         (inf_threads_range, inf_non_exited_threads_range)
15684         (safe_inf_threads_range): Use next_adapter.
15685
15686 2019-01-10  Keith Seitz  <keiths@redhat.com>
15687
15688         PR gdb/23712
15689         PR symtab/23010
15690         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15691         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15692
15693 2019-01-10  Keith Seitz  <keiths@redhat.com>
15694
15695         PR gdb/23712
15696         PR symtab/23010
15697         * dictionary.c (pending_to_vector): Remove.
15698         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15699         Remove _1 suffix, replacing functions of the same name.  Update
15700         all callers.
15701         (dict_create_hashed, dict_create_hashed_expandable)
15702         (dict_create_linear, dict_create_linear_expandable, dict_free)
15703         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15704         Make functions static.
15705
15706 2019-01-10  Keith Seitz  <keiths@redhat.com>
15707
15708         PR gdb/23712
15709         PR symtab/23010
15710         * dictionary.h (struct dictionary): Replace declaration with
15711         multidictionary.
15712         (dict_create_hashed, dict_create_hashed_expandable)
15713         (dict_create_linear, dict_create_linear_expandable)
15714         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15715         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15716         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15717         taking multidictionary argument.
15718         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15719         * block.h (struct block) <dict>: Change to multidictionary
15720         and rename `multidict'.
15721         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15722         symmisc.c: Update all dictionary references to multidictionary.
15723
15724 2019-01-10  Keith Seitz  <keiths@redhat.com>
15725
15726         PR gdb/23712
15727         PR symtab/23010
15728         * dictionary.c: Include unordered_map.
15729         (pending_to_vector): New function.
15730         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15731         Rewrite the non-"_1" functions to take vector instead
15732         of linked list.
15733         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15734         "new" _1 versions of the same name.
15735         (multidictionary): Define.
15736         (std::hash<enum language): New definition.
15737         (collate_pending_symbols_by_language, mdict_create_hashed)
15738         (mdict_create_hashed_expandable, mdict_create_linear)
15739         (mdict_create_linear_expandable, mdict_free)
15740         (find_language_dictionary, create_new_language_dictionary)
15741         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15742         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15743         (mdict_size, mdict_empty): New functions.
15744         * dictionary.h (mdict_iterator): Define.
15745
15746 2019-01-10  Pedro Alves  <palves@redhat.com>
15747
15748         * breakpoint.c (read_uploaded_action)
15749         (create_tracepoint_from_upload): Adjust to use
15750         gdb::unique_xmalloc_ptr.
15751         * ctf.c (ctf_write_uploaded_tp):
15752         (SET_ARRAY_FIELD): Use emplace_back.
15753         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15754         * tracefile-tfile.c (tfile_write_uploaded_tp):
15755         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15756         gdb::unique_xmalloc_ptr.
15757         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15758         at_string, cond_string, cmd_strings>: Replace char pointers
15759         with gdb::unique_xmalloc_ptr.
15760
15761 2019-01-10  Pedro Alves  <palves@redhat.com>
15762
15763         * solib-target.c (library_list_start_library): Don't xstrdup name.
15764
15765 2019-01-10  Pedro Alves  <palves@redhat.com>
15766
15767         * mdebugread.c (parse_partial_symbols): Use
15768         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15769
15770 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15771
15772         * linux-fork.c (scoped_switch_fork_info)
15773         <~scoped_switch_fork_info>: Fix incorrect variable name.
15774
15775 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15776
15777         * linux-fork.c (scoped_switch_fork_info)
15778         <scoped_switch_fork_info>: Make explicit.
15779         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15780
15781 2019-01-10  Tom Tromey  <tom@tromey.com>
15782
15783         * objfiles.h (objfile::reset_psymtabs): Update.
15784         * objfiles.c (objfile::objfile): Update.
15785         * psymtab.h (psymtab_storage::obstack): Update.
15786         (psymtab_storage::m_obstack): Use gdb::optional.
15787         (class psymtab_storage): Update comment.  Remove objfile
15788         parameter.
15789         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15790
15791 2019-01-10  Tom Tromey  <tom@tromey.com>
15792
15793         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15794         <free_psymtabs>: Now private.
15795         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15796         (allocate_psymtab): Use new method.
15797
15798 2019-01-10  Tom Tromey  <tom@tromey.com>
15799
15800         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15801         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15802         * mdebugread.c (parse_partial_symbols): Use
15803         allocate_dependencies.
15804         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15805         allocate_dependencies.
15806         (process_psymtab_comp_unit_reader)
15807         (build_type_psymtab_dependencies): Likewise.
15808         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15809
15810 2019-01-10  Tom Tromey  <tom@tromey.com>
15811
15812         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15813         PSYMBOL_SET_LANGUAGE.
15814         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15815
15816 2019-01-10  Tom Tromey  <tom@tromey.com>
15817
15818         * psymtab.h (psymtab_storage::obstack): New method.
15819         <m_obstack>: Rename from obstack; now private.
15820         * psymtab.c (psymtab_storage): Update.
15821         * dwarf2read.c (create_addrmap_from_index)
15822         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15823         Update.
15824
15825 2019-01-10  Tom Tromey  <tom@tromey.com>
15826
15827         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15828         * objfiles.h (objfile::reset_psymtabs): New method.
15829
15830 2019-01-10  Tom Tromey  <tom@tromey.com>
15831
15832         * symmisc.c (print_symbol_bcache_statistics): Update.
15833         (print_objfile_statistics): Update.
15834         * symfile.c (reread_symbols): Update.
15835         * psymtab.h (class psymtab_storage): New.
15836         * psymtab.c (psymtab_storage): New constructor.
15837         (~psymtab_storage): New destructor.
15838         (require_partial_symbols): Update.
15839         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15840         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15841         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15842         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15843         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15844         (start_psymtab_common, end_psymtab_common)
15845         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15846         (allocate_psymtab): Update.
15847         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15848         Update.
15849         (dump_psymtab_addrmap, maintenance_print_psymbols)
15850         (maintenance_check_psymtabs): Update.
15851         (class objfile_psymtabs): Move to objfiles.h.
15852         * psympriv.h (discard_psymtab): Now inline.
15853         (psymtab_discarder::psymtab_discarder): Update.
15854         (psymtab_discarder::~psymtab_discarder): Update.
15855         (ALL_OBJFILE_PSYMTABS): Rewrite.
15856         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15857         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15858         Remove fields.
15859         <partial_symtabs>: New field.
15860         (class objfile_psymtabs): Move from psymtab.h.  Update.
15861         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15862         psymbol_cache.
15863         (objfile::~objfile): Don't destroy psymbol_cache.
15864         * mdebugread.c (parse_partial_symbols): Update.
15865         * dwarf2read.c (create_addrmap_from_index)
15866         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15867         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15868         (add_partial_subprogram, dwarf2_ranges_read): Update.
15869         * dwarf-index-write.c (write_address_map)
15870         (write_one_signatured_type, recursively_write_psymbols)
15871         (class debug_names, class debug_names, write_psymtabs_to_index):
15872         Update.
15873
15874 2019-01-10  Tom Tromey  <tom@tromey.com>
15875
15876         * symtab.h (SYMBOL_SET_NAMES): Update.
15877         (symbol_set_names): Update.
15878         (MSYMBOL_SET_NAMES): Update.
15879         * symtab.c (symbol_set_names): Change argument to be an
15880         objfile_per_bfd_storage.
15881         * psymtab.c (add_psymbol_to_bcache): Update.
15882         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15883
15884 2019-01-10  Tom Tromey  <tom@tromey.com>
15885
15886         * symtab.c (create_demangled_names_hash): Change argument to be an
15887         objfile_per_bfd_storage.
15888         (symbol_set_names): Update.
15889
15890 2019-01-10  Tom Tromey  <tom@tromey.com>
15891
15892         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15893         init_psymbol_list.
15894         * psymtab.c (init_psymbol_list): Do nothing if already called.
15895         * psympriv.h (init_psymbol_list): Add comment.
15896         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15897         init_psymbol_list.
15898         * dbxread.c (dbx_symfile_read): Unconditionally call
15899         init_psymbol_list.
15900
15901 2019-01-10  Tom Tromey  <tom@tromey.com>
15902
15903         * xcoffread.c (scan_xcoff_symtab): Update.
15904         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15905         "where".
15906         * mdebugread.c (parse_partial_symbols)
15907         (handle_psymbol_enumerators): Update.
15908         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15909         * dbxread.c (read_dbx_symtab): Update.
15910         * psympriv.h (psymbol_placement): New enum.
15911         (add_psymbol_to_list): Update.
15912
15913 2019-01-10  Tom Tromey  <tom@tromey.com>
15914
15915         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15916         static_psymbols parameters.
15917         (scan_xcoff_symtab): Update.
15918         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15919         static_psymbols parameters.
15920         * psympriv.h (start_psymtab_common): Update.
15921         * mdebugread.c (parse_partial_symbols): Update.
15922         * dwarf2read.c (create_partial_symtab): Update.
15923         * dbxread.c (read_dbx_symtab): Update.
15924         (start_psymtab): Remove global_psymbols and static_psymbols
15925         parameters.
15926
15927 2019-01-10  Tom Tromey  <tom@tromey.com>
15928
15929         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15930         * psymtab.c (allocate_psymtab): Add comment.
15931         * psympriv.h (allocate_psymtab): Add comment.
15932         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15933         initializations.
15934         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15935
15936 2019-01-10  Tom Tromey  <tom@tromey.com>
15937
15938         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15939         Don't declare.
15940         * mipsread.c: Include mdebugread.h.
15941         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15942         Declare.
15943         * elfread.c: Include mdebugread.h.
15944
15945 2019-01-09  Tom Tromey  <tom@tromey.com>
15946
15947         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15948         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15949         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15950         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15951         (psym_lookup_symbol, psym_find_last_source_symtab)
15952         (psym_forget_cached_source_info, psym_print_stats)
15953         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15954         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15955         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15956         (psym_find_compunit_symtab_by_address)
15957         (maintenance_print_psymbols, maintenance_info_psymtabs)
15958         (maintenance_check_psymtabs): Use ranged for.
15959         * psymtab.h (class objfile_psymtabs): New.
15960         (require_partial_symbols): Return objfile_psymtabs.
15961         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15962
15963 2019-01-09  Tom Tromey  <tom@tromey.com>
15964
15965         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15966         (find_pc_mapped_section, list_overlays_command)
15967         (map_overlay_command, unmap_overlay_command)
15968         (simple_overlay_update): Use all_objfiles.
15969         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15970         * printcmd.c (info_symbol_command): Use all_objfiles.
15971         * objfiles.h (ALL_OBJSECTIONS): Remove.
15972         * maint.c (maintenance_translate_address): Use all_objfiles.
15973         * gcore.c (gcore_create_callback): Use all_objfiles.
15974         (objfile_find_memory_regions): Likewise.
15975
15976 2019-01-09  Tom Tromey  <tom@tromey.com>
15977
15978         * symtab.c (find_line_symtab, info_sources_command)
15979         (make_source_files_completion_list): Use objfile_compunits.
15980         * source.c (select_source_symtab): Use objfile_compunits.
15981         * objfiles.h (struct objfile): Update comment.
15982         (ALL_OBJFILES): Remove.
15983         (ALL_FILETABS): Remove.
15984         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15985         objfile_compunits.
15986
15987 2019-01-09  Tom Tromey  <tom@tromey.com>
15988
15989         * symmisc.c (print_objfile_statistics, dump_objfile)
15990         (maintenance_print_symbols): Use compunit_filetabs.
15991         * source.c (forget_cached_source_info_for_objfile): Use
15992         compunit_filetabs.
15993         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15994         (ALL_FILETABS): Use compunit_filetabs.
15995         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15996         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15997
15998 2019-01-09  Tom Tromey  <tom@tromey.com>
15999
16000         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16001         (compunit_filetabs): New.
16002         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16003         compunit_filetabs.
16004         (info_sources_command, make_source_files_completion_list): Remove
16005         declaration.
16006         * symmisc.c (print_objfile_statistics, dump_objfile)
16007         (maintenance_print_symbols): Remove declaration.
16008         (maintenance_info_symtabs): Use compunit_filetabs.
16009         (maintenance_info_line_tables): Likewise.
16010         * source.c (select_source_symtab): Change local variable name.
16011         (forget_cached_source_info_for_objfile): Remove declaration.
16012         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16013         * objfiles.c (objfile_relocate1): Remove declaration.
16014         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16015         declaration.
16016         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16017         * coffread.c (coff_symtab_read): Remove declaration.
16018         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16019         compunit_filetabs.
16020
16021 2019-01-09  Tom Tromey  <tom@tromey.com>
16022
16023         * symtab.c (lookup_objfile_from_block)
16024         (find_pc_sect_compunit_symtab, search_symbols)
16025         (default_collect_symbol_completion_matches_break_on): Use
16026         objfile_compunits.
16027         * objfiles.h (ALL_COMPUNITS): Remove.
16028         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16029         * cp-support.c (add_symbol_overload_list_qualified): Use
16030         objfile_compunits.
16031         * ada-lang.c (ada_collect_symbol_completion_matches)
16032         (ada_add_global_exceptions): Use objfile_compunits.
16033
16034 2019-01-09  Tom Tromey  <tom@tromey.com>
16035
16036         * source.c (select_source_symtab)
16037         (forget_cached_source_info_for_objfile): Remove declaration.
16038         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16039         declaration.
16040         * maint.c (count_symtabs_and_blocks): Remove declaration.
16041         * cp-support.c (add_symbol_overload_list_qualified): Remove
16042         declaration.
16043         * coffread.c (coff_symtab_read): Remove declaration.
16044         * symtab.c (lookup_symbol_in_objfile_symtabs)
16045         (basic_lookup_transparent_type_1): Use objfile_compunits.
16046         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16047         (info_sources_command, search_symbols)
16048         (default_collect_symbol_completion_matches_break_on)
16049         (make_source_files_completion_list): Remove declaration.
16050         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16051         (ada_collect_symbol_completion_matches)
16052         (ada_add_global_exceptions): Remove declaration.
16053         * linespec.c (iterate_over_all_matching_symtabs): Use
16054         objfile_compunits.
16055         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16056         (class objfile_compunits): New.
16057         (ALL_COMPUNITS): Use objfile_compunits.
16058         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16059         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16060         objfile_compunits.
16061         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16062
16063 2019-01-09  Tom Tromey  <tom@tromey.com>
16064
16065         * symtab.c (search_symbols)
16066         (default_collect_symbol_completion_matches_break_on): Use
16067         objfile_msymbols.
16068         * ada-lang.c (ada_lookup_simple_minsym)
16069         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16070         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16071         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16072         objfile_msymbols.
16073         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16074         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16075         * objc-lang.c (find_methods): Use objfile_msymbols.
16076         (info_selectors_command, info_classes_command): Likewise.
16077         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16078         * objfiles.h (class objfile_msymbols): New.
16079         (ALL_OBJFILE_MSYMBOLS): Remove.
16080         (ALL_MSYMBOLS): Remove.
16081
16082 2019-01-09  Tom Tromey  <tom@tromey.com>
16083
16084         * common/next-iterator.h (next_adapter): Add Iterator template
16085         parameter.
16086         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16087         (class all_objfiles_safe): New.
16088         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16089         * objfiles.c (put_objfile_before): Update comment.
16090         (add_separate_debug_objfile): Likewise.
16091         (free_all_objfiles): Use all_objfiles_safe.
16092         (objfile_purge_solibs): Likewise.
16093
16094 2019-01-09  Tom Tromey  <tom@tromey.com>
16095
16096         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16097         (expand_symtab_containing_pc, lookup_static_symbol)
16098         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16099         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16100         all_objfiles.
16101         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16102         * breakpoint.c (create_overlay_event_breakpoint)
16103         (create_longjmp_master_breakpoint)
16104         (create_std_terminate_master_breakpoint)
16105         (create_exception_master_breakpoint): Use all_objfiles.
16106         * linux-thread-db.c (try_thread_db_load_from_pdir)
16107         (has_libpthread): Use all_objfiles.
16108         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16109         * linespec.c (iterate_over_all_matching_symtabs)
16110         (search_minsyms_for_name): Use all_objfiles.
16111         * maint.c (maintenance_info_sections): Use all_objfiles.
16112         * main.c (captured_main_1): Use all_objfiles.
16113         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16114         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16115         * guile/scm-pretty-print.c
16116         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16117         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16118         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16119         (maintenance_print_msymbols): Use all_objfiles.
16120         * source.c (select_source_symtab): Use all_objfiles.
16121         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16122         * symfile.c (remove_symbol_file_command)
16123         (expand_symtabs_matching, map_symbol_filenames): Use
16124         all_objfiles.
16125         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16126         all_objfiles.
16127         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16128         * objc-lang.c (find_methods): Use all_objfiles.
16129         * objfiles.c (have_partial_symbols, have_full_symbols)
16130         (have_minimal_symbols, qsort_cmp)
16131         (default_iterate_over_objfiles_in_search_order): Use
16132         all_objfiles.
16133         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16134         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16135         (maintenance_check_psymtabs): Use all_objfiles.
16136         (ALL_PSYMTABS): Remove.
16137         * compile/compile-object-run.c (do_module_cleanup): Use
16138         all_objfiles.
16139         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16140         * cp-support.c (add_symbol_overload_list_qualified): Use
16141         all_objfiles.
16142         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16143         Use all_objfiles.
16144         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16145         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16146         all_objfiles.
16147         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16148         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16149         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16150         Uses all_objfiles.
16151         * solib.c (solib_read_symbols): Use all_objfiles
16152
16153 2019-01-09  Tom Tromey  <tom@tromey.com>
16154
16155         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16156         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16157         all_objfiles.
16158         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16159         * symmisc.c (print_symbol_bcache_statistics)
16160         (print_objfile_statistics, maintenance_print_objfiles)
16161         (maintenance_info_symtabs, maintenance_check_symtabs)
16162         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16163         all_objfiles.
16164         * source.c (forget_cached_source_info): Use all_objfiles.
16165         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16166         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16167         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16168         * objfiles.c (update_section_map): Use all_objfiles.
16169         (shared_objfile_contains_address_p): Likewise.
16170         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16171         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16172
16173 2019-01-09  Tom Tromey  <tom@tromey.com>
16174
16175         * common/next-iterator.h: New file.
16176         * objfiles.h (class all_objfiles): New.
16177         (struct objfile_iterator): New.
16178
16179 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16180
16181         * NEWS: Move the description of the changed "frame", "select-frame",
16182          and "info frame" commands to the Changed commands section.
16183
16184 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16185
16186         * gdbtypes.c (check_stub_method_group): Remove handling of old
16187         mangling schemes.
16188         * linespec.c (find_methods): Likewise.
16189         * stabsread.c (read_member_functions): Likewise.
16190         * valops.c (search_struct_method): Likewise.
16191         (value_struct_elt_for_reference): Likewise.
16192         * NEWS: Mention this change.
16193
16194 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16195
16196         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16197         print_source_lines.
16198         * source.c (print_source_lines_base): Update line number check.
16199         (print_source_lines): New function.
16200         (source_lines_range::source_lines_range): New function.
16201         * source.h (class source_lines_range): New class.
16202         (print_source_lines): New declaration.
16203
16204 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16205
16206         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16207
16208 2019-01-08  Tom Tromey  <tom@tromey.com>
16209             Simon Marchi  <simon.marchi@ericsson.com>
16210
16211         PR gdb/24060
16212         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16213         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16214         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16215         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16216         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16217         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16218
16219 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16220
16221         * source.c (select_source_symtab): Move header comment to
16222         declaration in source.h.
16223         (forget_cached_source_info_for_objfile): Likewise.
16224         (forget_cached_source_info): Likewise.
16225         (identify_source_line): Likewise.
16226         * source.h (identify_source_line): Move declaration from symtab.h
16227         and add comment from source.c
16228         (print_source_lines): Likewise.
16229         (forget_cached_source_info_for_objfile): Likewise.
16230         (forget_cached_source_info): Likewise.
16231         (select_source_symtab): Likewise.
16232         (enum print_source_lines_flag): Move definition from symtab.h.
16233         * symtab.h (identify_source_line): Move declaration to source.h.
16234         (print_source_lines): Likewise.
16235         (forget_cached_source_info_for_objfile): Likewise.
16236         (forget_cached_source_info): Likewise.
16237         (select_source_symtab): Likewise.
16238         (enum print_source_lines_flag): Move definition to source.h.
16239         * tui/tui-hooks.c: Add 'source.h' include.
16240
16241 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16242
16243         * source.c (print_source_lines_base): Handle requests to print
16244         reverse line number sequences, and guard against empty lines
16245         string.
16246
16247 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16248
16249         * source.c (print_source_lines_base): Fix skip of '\r' if next
16250         character is '\n'.
16251
16252 2019-01-06  Tom Tromey  <tom@tromey.com>
16253
16254         * c-exp.y (struct c_parse_state) <macro_original_text,
16255         expansion_obstack>: New member.
16256         (macro_original_text, expansion_obstack): Remove globals.
16257         (scan_macro_expansion, scanning_macro_expansion)
16258         (finished_macro_expansion): Update.
16259         (scan_macro_cleanup): Remove.
16260         (yylex, c_parse): Update.
16261
16262 2019-01-06  Tom Tromey  <tom@tromey.com>
16263
16264         * c-exp.y (struct c_parse_state) <strings>: New member.
16265         (operator_stoken): Update.
16266
16267 2019-01-06  Tom Tromey  <tom@tromey.com>
16268
16269         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16270         (union type_stack_elt) <typelist_val>: Now a pointer to
16271         std::vector.
16272         (type_stack_cleanup): Don't declare.
16273         (push_typelist): Update.
16274         * parse.c (pop_typelist): Return a std::vector.
16275         (push_typelist): Take a std::vector.
16276         (follow_types): Update.  Do not free args.
16277         (type_stack_cleanup): Remove.
16278         * c-exp.y (struct c_parse_state): New.
16279         (cpstate): New global.
16280         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16281         (nonempty_typelist): Update.
16282         (func_mod): Create a new vector.
16283         (c_parse): Create a c_parse_state.
16284         (check_parameter_typelist): Do not delete params.
16285         (function_method): Update.  Do not delete type_list.
16286
16287 2019-01-06  Tom Tromey  <tom@tromey.com>
16288
16289         PR gdb/28155:
16290         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16291         check_typedef.
16292         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16293         (print_return_value): Likewise.
16294
16295 2019-01-05  Tom Tromey  <tom@tromey.com>
16296
16297         * contrib/cleanup_check.py: Remove.
16298         * contrib/gcc-with-excheck: Remove.
16299         * contrib/exsummary.py: Remove.
16300         * contrib/excheck.py: Remove.
16301
16302 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16303
16304         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16305         NULL. Initialize tpprev to NULL instead of assigning it
16306         to NULL on the next statement.
16307         * windows-nat.c (windows_delete_thread): Remove check for
16308         main_thread_id before printing thread exit notifications.
16309         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16310         Remove thread ID check against main_thread_id.
16311         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16312         windows_delete_thread.
16313         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16314
16315 2019-01-04  Tom Tromey  <tom@tromey.com>
16316
16317         * compile/compile.c (_initialize_compile): Use upper case for
16318         metasyntactic variables.
16319         * symmisc.c (_initialize_symmisc): Use upper case for
16320         metasyntactic variables.
16321         * psymtab.c (_initialize_psymtab): Use upper case for
16322         metasyntactic variables.
16323         * demangle.c (demangle_command): Use upper case for metasyntactic
16324         variables.
16325         (_initialize_demangler): Likewise.
16326         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16327         variables.
16328
16329 2019-01-03  Tom Tromey  <tom@tromey.com>
16330
16331         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16332
16333 2019-01-03  Tom Tromey  <tom@tromey.com>
16334
16335         * python/py-symtab.c (salpy_str): Update.
16336         (struct salpy_sal_object) <symtab>: Now a PyObject.
16337         (salpy_dealloc): Update.
16338         (del_objfile_sal): Use gdbpy_ref.
16339
16340 2019-01-03  Tom Tromey  <tom@tromey.com>
16341
16342         * python/py-type.c (convert_field): Use new_reference.  Return
16343         gdbpy_ref.
16344         (make_fielditem): Return gdbpy_ref.
16345         (typy_fields): Update.
16346         (typy_getitem): Update.
16347         (field_name): Return gdbpy_ref.  Use new_reference.
16348         (typy_iterator_iternext): Update.
16349
16350 2019-01-03  Tom Tromey  <tom@tromey.com>
16351
16352         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16353
16354 2019-01-03  Tom Tromey  <tom@tromey.com>
16355
16356         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16357         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16358         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16359         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16360         (pspy_set_type_printers): Likewise.
16361         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16362         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16363         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16364         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16365         (objfpy_set_type_printers): Likewise.
16366
16367 2019-01-03  Tom Tromey  <tom@tromey.com>
16368
16369         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16370         (gdbpy_print_stack): Use gdbpy_err_fetch.
16371         * python/python-internal.h (class gdbpy_err_fetch): New class.
16372         (class gdbpy_enter) <m_error_type, m_error_value,
16373         m_error_traceback>: Remove.
16374         <m_error>: New member.
16375         (gdbpy_exception_to_string): Don't declare.
16376         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16377         * python/py-value.c (convert_value_from_python): Use
16378         gdbpy_err_fetch.
16379         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16380         gdbpy_exception_to_string.
16381         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16382         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16383         gdbpy_err_fetch.
16384
16385 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16386
16387         * linux-nat.c (delete_lwp_cleanup): Delete.
16388         (struct lwp_deleter): New struct.
16389         (lwp_info_up): New typedef.
16390         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16391         lwp_info_up.
16392
16393 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16394
16395         * linux-fork.c (class scoped_switch_fork_info): New class.
16396         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16397
16398 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16399
16400         * valops.c (find_overload_match): Remove use of null_cleanup, and
16401         calls to do_cleanups.
16402
16403 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16404
16405         * compile/compile-cplus-types.c
16406         (compile_cplus_instance::decl_name): Handle changes to
16407         cp_func_name.
16408         * cp-support.c (cp_func_name): Update header comment, update
16409         return type.
16410         * cp-support.h (cp_func_name): Update return type in declaration.
16411         * valops.c (find_overload_match): Move temp_func local to top
16412         level of function and change its type.  Use temp_func to hold and
16413         delete temporary string obtained from cp_func_name.
16414
16415 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16416
16417         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16418         gdb::char_vector, remove cleanup, and update uses of `msg`.
16419
16420 2019-01-03  Jim Wilson  <jimw@sifive.com>
16421
16422         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16423
16424 2019-01-02  Tom Tromey  <tom@tromey.com>
16425
16426         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16427         (tdesc_parse_xml): Remove cleanups.
16428         * target-descriptions.h (make_cleanup_free_target_description):
16429         Don't declare.
16430         (target_desc_deleter): New struct.
16431         (target_desc_up): New typedef.
16432         * target-descriptions.c (target_desc_deleter::operator()): Rename
16433         from free_target_description.
16434         (make_cleanup_free_target_description): Remove.
16435
16436 2019-01-02  Tom Tromey  <tom@tromey.com>
16437
16438         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16439         constructor, destructor.
16440         (linespec_parser): Remove typedef.
16441         (~linespec_parser): Rename from linespec_parser_delete.
16442         (linespec_lex_to_end, linespec_complete_label)
16443         (linespec_complete): Update.
16444         (decode_line_full): Remove cleanups.
16445         (decode_line_1): Update.
16446
16447 2019-01-02  Tom Tromey  <tom@tromey.com>
16448
16449         * python/python-internal.h (inferior_to_inferior_object): Change
16450         return type.
16451         * python/py-exitedevent.c (create_exited_event_object): Update.
16452         * python/py-inferior.c (inferior_to_inferior_object): Return
16453         gdbpy_ref.
16454         (python_new_inferior, python_inferior_deleted)
16455         (thread_to_thread_object, delete_thread_object)
16456         (build_inferior_list, gdbpy_selected_inferior): Update.
16457         * python/py-infthread.c (create_thread_object): Update.  Also fail
16458         if inferior_to_inferior_object fails.
16459
16460 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16461
16462         * inferior.h (class inferior) <displaced_step_state>: New field.
16463         * infrun.h (struct displaced_step_state): Move here from
16464         infrun.c.  Initialize fields, add constructor.
16465         <inf>: Remove field.
16466         <reset>: New method.
16467         * infrun.c (struct displaced_step_inferior_state): Move to
16468         infrun.h.
16469         (displaced_step_inferior_states): Remove.
16470         (get_displaced_stepping_state): Adust.
16471         (displaced_step_in_progress_any_inferior): Adjust.
16472         (displaced_step_in_progress_thread): Adjust.
16473         (displaced_step_in_progress): Adjust.
16474         (add_displaced_stepping_state): Remove.
16475         (get_displaced_step_closure_by_addr): Adjust.
16476         (remove_displaced_stepping_state): Remove.
16477         (infrun_inferior_exit): Call displaced_step_state.reset.
16478         (use_displaced_stepping): Don't check for NULL.
16479         (displaced_step_prepare_throw): Call
16480         get_displaced_stepping_state.
16481         (displaced_step_fixup): Don't check for NULL.
16482         (prepare_for_detach): Don't check for NULL.
16483
16484 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16485
16486         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16487          in case of call that did not complete.
16488
16489 2019-01-02  Andrey Utkin  <autkin@undo.io>
16490
16491         * symfile.c (find_separate_debug_file): Fix search of debug files for
16492         remote debuggee.
16493
16494 2019-01-02  Tom Tromey  <tom@tromey.com>
16495
16496         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16497         indentation.
16498         * python/py-frame.c (frapy_older): Remove cast.
16499         (frapy_newer): Likewise.
16500         * python/py-breakpoint.c (local_setattro): Remove cast.
16501         * python/py-arch.c (archpy_name): Remove local variable.
16502         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16503
16504 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16505
16506         * unittests/basic_string_view/element_access/char/empty.cc:
16507         Fix year range in copyright header.
16508
16509 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16510
16511         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16512         Delete.
16513         <operator==>: Update with for removed field.
16514         <hash>: Likewise.
16515         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16516         <isa_features>: ...this.
16517         <abi_features>: New field.
16518         (riscv_isa_flen): Update comment.
16519         (riscv_abi_xlen): New declaration.
16520         (riscv_abi_flen): New declaration.
16521         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16522         isa_features.
16523         (riscv_abi_xlen): New function.
16524         (riscv_isa_flen): Update to get answer from isa_features.
16525         (riscv_abi_flen): New function.
16526         (riscv_has_fp_abi): Update to get answer from abi_features.
16527         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16528         xlen and flen.
16529         (riscv_call_info) <xlen, flen>: Update comment.
16530         (riscv_call_arg_struct): Remove invalid assertions
16531         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16532         is removed.
16533         (riscv_gdbarch_init): Gather isa features and abi features
16534         separately, ensure both match on the gdbarch when reusing an old
16535         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16536         a target with 64-bit float hardware.
16537
16538 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16539
16540         * source.c (search_command_helper): Stop reverse search
16541         when line 1 has been searched.
16542
16543 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16544
16545         * record-full.c (record_full_base_target::close): Rewrite
16546         record_full_core_buf_list free logic.
16547
16548 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16549
16550         * break-catch-syscall.c (print_one_catch_syscall): xfree
16551         the last text.
16552
16553 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16554
16555         * top.c (print_gdb_version): Update Copyright year in version
16556         message.
16557
16558 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16559
16560         Update copyright year range in all GDB files.
16561
16562 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16563
16564         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16565
16566 For older changes see ChangeLog-2018.
16567 \f
16568 Local Variables:
16569 mode: change-log
16570 left-margin: 8
16571 fill-column: 74
16572 version-control: never
16573 coding: utf-8
16574 End:
16575