5ac4f9cb95e774702432523f926d397e61aeca3f
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2019-12-12 Luis Machado <luis.machado@linaro.org>
2
3 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
4 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
5 macros.
6
7 2019-12-11 Tom Tromey <tom@tromey.com>
8
9 * tui/tui-win.c (tui_set_win_height_command): Call
10 tui_adjust_window_height.
11 (tui_adjust_win_heights, new_height_ok): Remove.
12 * tui/tui-layout.h (tui_adjust_window_height): Declare.
13 * tui/tui-layout.c (tui_adjust_window_height): New function.
14
15 2019-12-11 Tom Tromey <tom@tromey.com>
16
17 * tui/tui-win.c (tui_resize_all): Remove code, call
18 tui_apply_current_layout.
19
20 2019-12-11 Tom Tromey <tom@tromey.com>
21
22 * tui/tui-layout.h (tui_apply_current_layout): Declare.
23 * tui/tui-layout.c (standard_layouts, applied_layout): New
24 globals.
25 (tui_apply_current_layout): New function.
26 (show_layout): Set applied_layout. Call
27 tui_apply_current_layout.
28 (show_source_command, show_disasm_command)
29 (show_source_disasm_command, show_data)
30 (show_source_or_disasm_and_command): Remove.
31 (initialize_layouts): New function.
32 (_initialize_tui_layout): Call initialize_layouts.
33
34 2019-12-11 Tom Tromey <tom@tromey.com>
35
36 * tui/tui-layout.h (class tui_layout_base)
37 (class tui_layout_window, class tui_layout_split): New.
38 * tui/tui-layout.c (tui_get_window_by_name)
39 (tui_layout_window::clone, tui_layout_window::apply)
40 (tui_layout_window::get_sizes, tui_layout_window::add_split)
41 (tui_layout_split::add_window, tui_layout_split::clone)
42 (tui_layout_split::get_sizes)
43 (tui_layout_split::set_weights_from_heights)
44 (tui_layout_split::adjust_size, tui_layout_split::apply): New
45 functions.
46 (tui_layout_split::add_split, tui_layout_split::add_split)
47 (tui_layout_split::set_weights_from_heights)
48 (tui_layout_split::set_weights_from_heights): New functions.
49
50 2019-12-11 Tom Tromey <tom@tromey.com>
51
52 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
53 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
54 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
55 * tui/tui-data.h (struct tui_point): Remove.
56 (struct tui_gen_win_info) <origin>: Remove.
57 <x, y>: New fields.
58 * tui/tui-command.c (tui_cmd_window::resize): Update.
59
60 2019-12-11 Tom Tromey <tom@tromey.com>
61
62 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
63 Implement.
64 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
65 Implement.
66 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
67 method.
68 (struct tui_win_info) <min_height>: Implement.
69
70 2019-12-11 Tom Tromey <tom@tromey.com>
71
72 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
73 (struct tui_win_info) <can_box>: Update.
74
75 2019-12-11 Tom Tromey <tom@tromey.com>
76
77 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
78 method.
79 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
80 method.
81 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
82 method.
83 (struct tui_win_info) <max_height>: Now override.
84
85 2019-12-11 Joel Brobecker <brobecker@adacore.com>
86
87 * NEWS: Create a new section for the next release branch.
88 Rename the section of the current branch, now that it has
89 been cut.
90
91 2019-12-11 Joel Brobecker <brobecker@adacore.com>
92
93 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
94 * version.in: Bump version to 10.0.50.DATE-git.
95
96 2019-12-11 Tom Tromey <tromey@adacore.com>
97
98 PR build/25268:
99 * gdbsupport/thread-pool.c (set_thread_name): New function.
100 (thread_pool::set_thread_count): Don't call pthread_setname_np.
101 (thread_pool::thread_function): Call set_thread_name.
102
103 2019-12-11 Tom Tromey <tromey@adacore.com>
104
105 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
106 bfd_get_signed_8.
107
108 2019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
109
110 * NEWS: Document -raw-values option and the related setting commands.
111 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
112 only set it on when /r is given.
113 * valprint.c (value_print_option_defs): New element raw-values.
114 * Makefile.in: Add the new file.
115
116 2019-12-10 Christian Biesinger <cbiesinger@google.com>
117
118 * gdbsupport/safe-strerror.c: Supress the unused function warning
119 for select_strerror_r.
120
121 2019-12-10 Christian Biesinger <cbiesinger@google.com>
122
123 * config.in: Regenerate.
124 * configure: Regenerate.
125 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
126 safe_strerror instead of strerror.
127 * gdbsupport/common.m4: Don't check for strerror.
128 * gdbsupport/safe-strerror.c: Support both the glibc version
129 of strerror_r and the XSI version.
130
131 2019-12-10 Tom Tromey <tromey@adacore.com>
132
133 * ada-typeprint.c (print_choices): Use a single "?".
134 (print_variant_part): Print "?" if the discriminant name
135 is not known.
136
137 2019-12-10 George Barrett <bob@bob131.so>
138
139 Fix scripted probe breakpoints.
140 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
141 declaration forward.
142 (breakpoint_ops_for_event_location_type)
143 (breakpoint_ops_for_event_location): Add function definitions.
144 (break_command_1, trace_command): Use
145 breakpoint_ops_for_event_location.
146 * breakpoint.h (breakpoint_ops_for_event_location): Add function
147 declarations.
148 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
149 breakpoint_ops_for_event_location.
150 * python/py-breakpoint.c (bppy_init): Use
151 breakpoint_ops_for_event_location.
152
153 2019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
154
155 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
156 when ranking an lvalue argument for an rvalue parameter.
157
158 2019-12-08 Wataru Ashihara <wataash@wataash.com>
159
160 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
161 template argument for scoped_restore_tmpl from bool to int.
162
163 2019-12-07 Keith Seitz <keiths@redhat.com>
164
165 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
166 (build_id_to_debug_bfd): Make static, rewriting to use
167 build_id_to_bfd_suffix.
168 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
169 adding `suffix' parameter. Append SUFFIX to file names
170 when searching for matching files.
171 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
172 (build_id_to_exec_bfd): Likewise.
173 * build-id.h (build_id_to_debug_bfd): Clarify that function
174 searches for BFD of debug info file.
175 (build_id_to_exec_bfd): Declare.
176 * corelow.c: Include build-id.h.
177 (locate_exec_from_corefile_build_id): New function.
178 (core_target_open): If no executable BFD is found,
179 search for a core file BFD using build-id.
180
181 2019-12-06 Christian Biesinger <cbiesinger@google.com>
182
183 * bcache.c: Put in namespace gdb.
184 * bcache.h: Likewise.
185 * gdbtypes.c (check_types_worklist): Update.
186 (types_deeply_equal): Update.
187 * macrotab.c (struct macro_table) <bcache>: Update.
188 (new_macro_table): Update.
189 * macrotab.h (struct bcache): Put this forward declaration
190 inside namespace gdb.
191 (new_macro_table): Update.
192 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
193 Update.
194 <macro_cache>: Update.
195 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
196
197 2019-12-06 Tom de Vries <tdevries@suse.de>
198
199 PR symtab/24971
200 * block.c (best_symbol, better_symbol): New function.
201 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
202 decl.
203
204 2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
205
206 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
207 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
208 for ranking see-through reference cases.
209
210 2019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
211 * stack.c (faas_command): Check a command is provided.
212 * thread.c (taas_command, tfaas_command): Likewise.
213
214 2019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
215 * inferior.c (prune_inferiors): Only call delete_inferior,
216 Do not modify the inferior list.
217
218 2019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
219
220 * c-exp.y: Update calls to lookup_typename,
221 lookup_signed_typename and lookup_unsigned_typename.
222 * c-lang.c (evaluate_subexp_c): Likewise.
223 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
224 Likewise.
225 * eval.c (binop_promote): Likewise.
226 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
227 (lookup_unsigned_typename): Likewise.
228 (lookup_signed_typename): Likewise.
229 * gdbtypes.h (lookup_unsigned_typename): Likewise.
230 (lookup_signed_typename): Likewise.
231 (lookup_typename): Likewise.
232 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
233 lookup_typename, lookup_signed_typename,
234 lookup_unsigned_typename.
235 * m2-exp.y: Likewise.
236 * printcmd.c (printf_wide_c_string): Likewise.
237 (ui_printf): Likewise.
238 * python/py-type.c (typy_lookup_typename): Likewise.
239 * python/py-xmethods.c (python_xmethod_worker::invoke):
240 Likewise.
241 * rust-exp.y: Likewise.
242
243 2019-12-04 Christian Biesinger <cbiesinger@google.com>
244
245 * configure.nat (obsd64): Add missing files x86-nat.o and
246 nat/x86-dregs.o.
247
248 2019-12-04 Tom Tromey <tom@tromey.com>
249
250 * valprint.c (val_print_string): Use metadata_style.
251 * go-valprint.c (print_go_string): Use metadata style.
252 * p-valprint.c (pascal_object_print_static_field): Use metadata
253 style.
254 * cp-valprint.c (cp_print_static_field): Use metadata style.
255
256 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
257 Chris January <chris.january@arm.com>
258
259 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
260 tokens.
261 (typebase): New patterns for complex, single/double precision, and
262 single/double complex.
263 (f77_keywords): Change token for complex keyword, and add single,
264 double, and precision keywords.
265
266 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
267
268 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
269 "info io_registers".
270
271 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
272
273 * regcache.c (cooked_read_test): Initialize thread list of
274 mock_inferior.
275
276 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
277
278 * aarch64-linux-tdep.c: Remove includes.
279
280 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
281
282 * aarch64-tdep.c: Remove includes.
283
284 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
285
286 * filtered-iterator.h (filtered_iterator) <operator==,
287 operator!=>: Compare wrapped iterators, not wrapped pointers.
288 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
289 unittests/filtered_iterator-selftests.c.
290 * unittests/filtered_iterator-selftests.c: New file.
291
292 2019-12-04 Tom Tromey <tromey@adacore.com>
293
294 * gdbtypes.c (create_range_type): Inherit endianity
295 from base type.
296
297 2019-12-04 Tom Tromey <tromey@adacore.com>
298
299 * ada-lang.c (decode_constrained_packed_array)
300 (ada_value_assign, value_assign_to_component): Update.
301 * dwarf2loc.c (rw_pieced_value, access_memory)
302 (dwarf2_compile_expr_to_ax): Update.
303 * dwarf2read.c (dwarf2_add_field): Update.
304 * eval.c (evaluate_subexp_standard): Update.
305 * gdbarch.c, gdbarch.h: Rebuild.
306 * gdbarch.sh (bits_big_endian): Remove.
307 * gdbtypes.h (union field_location): Update comment.
308 * target-descriptions.c (make_gdb_type): Update.
309 * valarith.c (value_bit_index): Update.
310 * value.c (struct value) <bitpos>: Update comment.
311 (unpack_bits_as_long, modify_field): Update.
312 * value.h (value_bitpos): Update comment.
313
314 2019-12-04 Tom Tromey <tromey@adacore.com>
315
316 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
317 endian-ness.
318
319 2019-12-04 Tom Tromey <tromey@adacore.com>
320
321 * dwarf2read.c (dwarf2_init_float_type)
322 (dwarf2_init_complex_target_type): Add byte_order parameter.
323 (read_base_type): Compute byte order earlier.
324 * gdbtypes.c (init_float_type): Add byte_order parameter.
325 * gdbtypes.h (init_float_type): Add byte_order parameter.
326
327 2019-12-04 Tom Tromey <tromey@adacore.com>
328
329 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
330
331 2019-12-04 Tom Tromey <tromey@adacore.com>
332
333 * dwarf2read.c (process_structure_scope): Initialize
334 "discr_offset".
335
336 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
337
338 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
339 add it into the search spec.
340 (parse_max_results_option): New function.
341 (mi_info_functions_or_variables): Parse -max-results flag and pass
342 it to mi_symbol_info.
343 (mi_cmd_symbol_info_modules): Likewise.
344 (mi_cmd_symbol_info_types): Likewise.
345 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
346 return type to bool, change result container into a set, and don't
347 add new results if we have enough already.
348 (global_symbol_searcher::add_matching_msymbols): Change return
349 type to bool, and don't add new results if we have enough already.
350 (sort_search_symbols_remove_dups): Delete.
351 (global_symbol_searcher::search): Early exit from search loop when
352 we have enough results. Use a std::set to collect the results
353 from calling add_matching_symbols.
354 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
355 member function.
356 (global_symbol_searcher) <m_max_search_results>: New member
357 variable.
358 (global_symbol_searcher) <add_matching_symbols>: Update header
359 comment and change return type to bool.
360 (global_symbol_searcher) <add_matching_msymbols>: Update header
361 comment and change return type to bool.
362
363 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
364
365 * symtab.c (symbol_search::compare_search_syms): Update header
366 comment.
367 (global_symbol_searcher::is_suitable_msymbol): New function.
368 (global_symbol_searcher::expand_symtabs): New function.
369 (global_symbol_searcher::add_matching_symbols): New function.
370 (global_symbol_searcher::add_matching_msymbols): New function.
371 (global_symbol_searcher::search): Move most of the content
372 into the new functions above, and call them as needed.
373 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
374 function.
375 (global_symbol_searcher) <add_matching_symbols>: New member
376 function.
377 (global_symbol_searcher) <add_matching_msymbols>: New member
378 function.
379 (global_symbol_searcher) <is_suitable_msymbol>: New member
380 function.
381
382 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
383
384 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
385 -symbol-info-module-variables entries.
386 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
387 (mi_cmd_symbol_info_module_variables): Declare.
388 * mi/mi-symbol-cmds.c
389 (module_symbol_search_iterator): New typedef.
390 (output_module_symbols_in_single_module_and_file): New function.
391 (output_module_symbols_in_single_module): New function.
392 (mi_info_module_functions_or_variables): New function.
393 (mi_cmd_symbol_info_module_functions): New function.
394 (mi_cmd_symbol_info_module_variables): New function.
395 * NEWS: Mention new MI command.
396
397 2019-12-03 Christian Biesinger <cbiesinger@google.com>
398
399 * bcache.c (hash): Remove.
400 (hash_continue): Remove.
401 * bcache.h (hash): Remove.
402 (hash_continue): Remove.
403 (struct bcache) <ctor>: Update.
404 * psymtab.c (psymbol_hash): Update.
405 * stabsread.c (hashname): Update.
406 * utils.h (fast_hash): Add an argument for a start value,
407 defaulting to zero.
408
409 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
410 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
411 (destroy_block_symbol_cache): New function.
412 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
413 (resize_symbol_cache): Likewise.
414
415 2019-12-02 Tom Tromey <tom@tromey.com>
416
417 * unittests/tui-selftests.c (run_tests): Make conditional.
418 (_initialize_tui_selftest): Make conditional.
419
420 2019-12-02 Christian Biesinger <cbiesinger@google.com>
421
422 * aix-thread.c (debug_aix_thread): Change type to bool.
423
424 2019-12-02 Luis Machado <luis.machado@linaro.org>
425
426 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
427
428 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
429
430 * dwarf2read.c (read_tag_string_type): Read the fields required to
431 make a dynamic string, and possibly create a dynamic range for the
432 string.
433 (attr_to_dynamic_prop): Setup is_reference based on the type of
434 attribute being processed.
435 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
436 (resolve_dynamic_array): Rename to...
437 (resolve_dynamic_array_or_string): ...this, update header comment,
438 and accept TYPE_CODE_STRING.
439 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
440
441 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
442
443 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
444 of its implementation from...
445 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
446 the new function.
447
448 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
449
450 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
451 create a range with stride where appropriate.
452 * f-valprint.c: Include 'gdbarch.h'.
453 (f77_print_array_1): Take the stride into account when walking the
454 array. Also convert the stride into addressable units.
455 * gdbtypes.c (create_range_type): Initialise the stride to
456 constant zero.
457 (create_range_type_with_stride): New function, initialise the
458 range as normal, and then setup the stride.
459 (has_static_range): Include the stride here. Also change the
460 return type to bool.
461 (create_array_type_with_stride): Consider the range stride if the
462 array isn't given its own stride.
463 (resolve_dynamic_range): Resolve the stride if needed.
464 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
465 (struct range_bounds) <flag_is_byte_stride>: New member variable.
466 (TYPE_BIT_STRIDE): Define.
467 (TYPE_ARRAY_BIT_STRIDE): Define.
468 (create_range_type_with_stride): Declare.
469 * valarith.c (value_subscripted_rvalue): Take range stride into
470 account when walking the array.
471
472 2019-12-01 Tom Tromey <tom@tromey.com>
473
474 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
475 specially.
476
477 2019-12-01 Tom Tromey <tom@tromey.com>
478
479 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
480 \0.
481 * unittests/tui-selftests.c: New file.
482 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
483
484 2019-12-01 Tom Tromey <tom@tromey.com>
485
486 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
487
488 2019-12-01 Tom Tromey <tom@tromey.com>
489
490 * NEWS: Document new settings.
491 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
492 * tui/tui-win.c (_initialize_tui_win): Add border style
493 observers.
494 * tui/tui-io.h (tui_apply_style): Declare.
495 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
496 longer static.
497 (apply_ansi_escape, tui_set_reverse_mode): Update.
498 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
499 Add "skip_intensity" parameter.
500 <changed>: New member.
501 <do_set_value>: Declare.
502 (tui_border_style, tui_active_border_style): Declare.
503 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
504 globals.
505 (cli_style_option): Initialize "changed".
506 (cli_style_option::do_set_value): New function.
507 (cli_style_option::add_setshow_commands): Add "skip_intensity"
508 parameter. Update.
509 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
510 (_initialize_cli_style): Update. Create TUI border style
511 commands.
512
513 2019-12-01 Tom Tromey <tom@tromey.com>
514
515 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
516 parameter.
517 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
518 parameter.
519 * tui/tui-win.h (compact_source): Declare.
520 * tui/tui-win.c (compact_source): New global.
521 (tui_set_compact_source, tui_show_compact_source): New functions.
522 (_initialize_tui_win): Add "compact-source" setting.
523 * tui/tui-source.c (tui_source_window::set_contents): Handle
524 compact_source setting.
525 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
526 * NEWS: Document new setting.
527
528 2019-11-30 Tom Tromey <tom@tromey.com>
529
530 * dwarf2read.c (dwarf2_add_field): Include field offset when
531 computing variant part length.
532
533 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
534 * NEWS: Mention define-prefix. Tell that command names can now
535 contain a . character.
536
537 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
538
539 * command.h (valid_cmd_char_p): Declare.
540 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
541 the check of valid command char.
542 (find_command_name_length, valid_user_defined_cmd_name_p): Use
543 valid_cmd_char_p.
544 * cli/cli-script.c (validate_comname): Likewise.
545 * completer.c (gdb_completer_command_word_break_characters):
546 Do not remove . from the word break char, update comments.
547 (complete_line_internal_1): Use valid_cmd_char_p.
548 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
549 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
550
551 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
552
553 * cli/cli-script.c (do_define_command): Ensure a redefined
554 prefix command is kept as a prefix command.
555 (define_prefix_command): New function.
556 (show_user_1): Report user defined prefixes.
557 (_initialize_cli_script): Create the new 'define-prefix' command.
558 Add completers for 'define' and 'document'.
559 * top.c (execute_command): If command is a user-defined prefix only
560 command, report the list of commands for this prefix command.
561
562 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
563
564 * valops.c (find_oload_champ): Improve debug output.
565
566 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
567
568 * valops.c (find_oload_champ): Print part of debug messages
569 before the badness vector is std::move'd.
570
571 2019-11-28 Tom Tromey <tom@tromey.com>
572
573 * value.c (creal_internal_fn): Fix comment.
574
575 2019-11-28 Tom Tromey <tom@tromey.com>
576
577 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
578 flag_bound_evaluated>: Now unsigned.
579
580 2019-11-28 Tom Tromey <tom@tromey.com>
581
582 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
583 declare.
584
585 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
586
587 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
588 debug output.
589 * jit.c (jit_unregister_code): Add debug print to match
590 `jit_register_code`.
591
592 2019-11-27 Christian Biesinger <cbiesinger@google.com>
593
594 * NEWS: Mention the new multithreaded symbol loading.
595
596 2019-11-27 Christian Biesinger <cbiesinger@google.com>
597
598 * maint.c (n_worker_threads): Default to 0.
599 (worker_threads_disabled): New function.
600 * maint.h (worker_threads_disabled): New function.
601 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
602 here if worker_threads_disabled () is true.
603 (minimal_symbol_reader::install): Skip all threading if
604 worker_threads_disabled () is true.
605
606 2019-11-27 Christian Biesinger <cbiesinger@google.com>
607
608 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
609 hash code if possible.
610 (add_minsym_to_demangled_hash_table): Likewise.
611 (minimal_symbol_reader::install): Compute the hash codes for msymbol
612 on the background thread.
613 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
614 Add these fields.
615
616 2019-11-27 Christian Biesinger <cbiesinger@google.com>
617
618 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
619 of the mangled name on the background thread.
620 * symtab.c (symbol_set_names): Allow passing in the hash of the
621 linkage_name.
622 * symtab.h (symbol_set_names): Likewise.
623
624 2019-11-27 Kevin Buettner <kevinb@redhat.com>
625
626 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
627 physnames are computed for inherited DIEs.
628
629 2019-11-27 Tom Tromey <tromey@adacore.com>
630
631 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
632 backslashes.
633 * cp-support.c: Remove unnecessary backslashes.
634
635 2019-11-27 Christian Biesinger <cbiesinger@google.com>
636
637 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
638 with sym->set_linkage_name.
639 * coffread.c (coff_read_enum_type): Likewise.
640 * mdebugread.c (parse_symbol): Likewise.
641 * stabsread.c (patch_block_stabs): Likewise.
642 (define_symbol): Likewise.
643 (read_enum_type): Likewise.
644 (common_block_end): Likewise.
645 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
646 function.
647 (SYMBOL_SET_LINKAGE_NAME): Remove.
648 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
649 with sym->set_linkage_name.
650
651 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
652
653 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
654 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
655 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
656 * NEWS: Mention new MI command.
657
658 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
659
660 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
661 '-symbol-info-types', and '-symbol-info-variables'.
662 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
663 (mi_cmd_symbol_info_types): Declare.
664 (mi_cmd_symbol_info_variables): Declare.
665 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
666 (output_debug_symbol): New function.
667 (output_nondebug_symbol): New function.
668 (mi_symbol_info): New function.
669 (mi_info_functions_or_variables): New function.
670 (mi_cmd_symbol_info_functions): New function.
671 (mi_cmd_symbol_info_types): New function.
672 (mi_cmd_symbol_info_variables): New function.
673 * NEWS: Mention new commands.
674
675 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
676
677 * symtab.c (symbol_to_info_string): New function, most content
678 moved from print_symbol_info, but updated to return a std::string.
679 (print_symbol_info): Update to use symbol_to_info_string and print
680 returned string.
681 * symtab.h (symbol_to_info_string): Declare new function.
682
683 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
684
685 * python/python.c (gdbpy_rbreak): Convert to using
686 global_symbol_searcher.
687 * symtab.c (file_matches): Convert return type to bool, change
688 file list to std::vector, update header comment.
689 (search_symbols): Rename to...
690 (global_symbol_searcher::search): ...this and update now its
691 a member function of global_symbol_searcher. Take account of the
692 changes to file_matches.
693 (symtab_symbol_info): Convert to using global_symbol_searcher.
694 (rbreak_command): Likewise.
695 (search_module_symbols): Likewise.
696 * symtab.h (enum symbol_search): Update comment.
697 (search_symbols): Remove declaration.
698 (class global_symbol_searcher): New class.
699
700 2019-11-26 Tom Tromey <tromey@adacore.com>
701
702 * cp-support.c (_initialize_cp_support): Conditionally initialize
703 gdb_demangle_attempt_core_dump.
704
705 2019-11-26 Tom Tromey <tom@tromey.com>
706
707 * python/py-function.c (fnpy_init): Update.
708 * value.h (add_internal_function): Adjust declaration.
709 * value.c (function_destroyer): Remove.
710 (do_add_internal_function): Don't set destroyer or copy name.
711 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
712 Set name_allocated.
713 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
714 (cmdpy_init): Set name_allocated.
715 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
716 member.
717 (~cmd_list_element): Free "name" if needed.
718
719 2019-11-26 Tom Tromey <tom@tromey.com>
720
721 * value.h (add_internal_function): Add new overload. Move
722 documentation from value.h.
723 * value.c (do_add_internal_function): New function.
724 (add_internal_function): Use it. Add new overload.
725 (function_destroyer): Don't free doc.
726 * python/py-function.c (fnpy_init): Update.
727
728 2019-11-26 Tom Tromey <tom@tromey.com>
729
730 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
731 (cmdpy_init): Set "doc_allocated".
732
733 2019-11-26 Tom Tromey <tom@tromey.com>
734
735 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
736 name of worker thread.
737 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
738 pthread_setname_np.
739 * configure, config.in: Rebuild.
740
741 2019-11-26 Tom Tromey <tom@tromey.com>
742
743 * python/python.c (class gdbpy_gil): New.
744 (struct gdbpy_event): Add constructor, destructor, operator().
745 (gdbpy_post_event): Use run_on_main_thread.
746 (gdbpy_initialize_events): Remove.
747 (do_start_initialization): Update.
748
749 2019-11-26 Tom Tromey <tom@tromey.com>
750
751 * NEWS: Add entry.
752 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
753 commands. Call update_thread_pool_size.
754 (update_thread_pool_size, maintenance_set_worker_threads): New
755 functions.
756 (n_worker_threads): New global.
757
758 2019-11-26 Christian Biesinger <cbiesinger@google.com>
759 Tom Tromey <tom@tromey.com>
760
761 * minsyms.c (minimal_symbol_reader::install): Use
762 parallel_for_each.
763 * gdbsupport/parallel-for.h: New file.
764 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
765
766 2019-11-26 Christian Biesinger <cbiesinger@google.com>
767 Tom Tromey <tom@tromey.com>
768
769 * gdbsupport/thread-pool.h: New file.
770 * gdbsupport/thread-pool.c: New file.
771 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
772 (HFILES_NO_SRCDIR): Add thread-pool.h.
773
774 2019-11-26 Tom Tromey <tom@tromey.com>
775
776 * event-top.h (thread_local_segv_handler): Declare.
777 * event-top.c (thread_local_segv_handler): New global.
778 (install_handle_sigsegv, handle_sigsegv): New functions.
779 (async_init_signals): Install SIGSEGV handler.
780 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
781 thread-local.
782 (report_failed_demangle): New function.
783 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
784 handler-setting code, instead use segv_handler. Run warning code
785 on main thread.
786
787 2019-11-26 Tom Tromey <tom@tromey.com>
788
789 * run-on-main-thread.c: New file.
790 * run-on-main-thread.h: New file.
791 * unittests/main-thread-selftests.c: New file.
792 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
793 main-thread-selftests.c.
794 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
795 (COMMON_SFILES): Add run-on-main-thread.c.
796
797 2019-11-26 Tom Tromey <tom@tromey.com>
798
799 * main.c (setup_alternate_signal_stack): Remove.
800 (captured_main_1): Use gdb::alternate_signal_stack.
801 * gdbsupport/alt-stack.h: New file.
802
803 2019-11-26 Tom Tromey <tom@tromey.com>
804
805 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
806 Remove comment.
807 (save_original_signals_state, restore_original_signals_state): Use
808 gdb_sigmask.
809 * linux-nat.c (block_child_signals, restore_child_signals_mask)
810 (_initialize_linux_nat): Use gdb_sigmask.
811 * guile/guile.c (_initialize_guile): Use block_signals.
812 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
813 * gdbsupport/gdb-sigmask.h: New file.
814 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
815 * cp-support.c (gdb_demangle): Use gdb_sigmask.
816 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
817 pthread_sigmask.
818 * configure, config.in: Rebuild.
819 * gdbsupport/block-signals.h: New file.
820
821 2019-11-26 Tom Tromey <tom@tromey.com>
822
823 * acinclude.m4: Include ax_pthread.m4.
824 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
825 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
826 (CLIBS): Use PTHREAD_LIBS.
827 (aclocal_m4_deps): Add ax_pthread.m4.
828 * config.in, configure: Rebuild.
829 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
830
831 2019-11-26 Tom Tromey <tom@tromey.com>
832
833 * symtab.h (struct minimal_symbol) <name_set>: New member.
834 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
835 Don't call symbol_set_names.
836 (minimal_symbol_reader::install): Call symbol_set_names.
837
838 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
839
840 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
841 restore_active_ext_lang, as GIL is needed for (indirectly)
842 called PyOS_InterruptOccurred.
843
844 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
845
846 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
847 definition.
848
849 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
850
851 * remote-sim.c (simulator_command): Make static, remove
852 declaration.
853
854 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
855
856 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
857 static.
858 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
859 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
860 (main): Likewise.
861 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
862 (main): Likewise.
863 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
864 (main): Likewise.
865 * unittests/basic_string_view/element_access/char/1.cc (test01):
866 Likewise.
867 (main): Likewise.
868 * unittests/basic_string_view/element_access/char/empty.cc (main):
869 Likewise.
870 * unittests/basic_string_view/element_access/char/front_back.cc
871 (test01): Likewise.
872 (main): Likewise.
873 * unittests/basic_string_view/inserters/char/2.cc (test05):
874 Likewise.
875 (main): Likewise.
876 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
877 (test01): Likewise.
878 (main): Likewise.
879 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
880 (test01): Likewise.
881 (main): Likewise.
882 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
883 Likewise.
884 * unittests/basic_string_view/operations/compare/char/1.cc
885 (test01): Likewise.
886 (main): Likewise.
887 * unittests/basic_string_view/operations/compare/char/13650.cc
888 (test01): Likewise.
889 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
890 Likewise.
891 (main): Likewise.
892 * unittests/basic_string_view/operations/data/char/1.cc (test01):
893 Likewise.
894 (main): Likewise.
895 * unittests/basic_string_view/operations/find/char/1.cc (test01):
896 Likewise.
897 (main): Likewise.
898 * unittests/basic_string_view/operations/find/char/2.cc (test02):
899 Likewise.
900 (main): Likewise.
901 * unittests/basic_string_view/operations/find/char/3.cc (test03):
902 Likewise.
903 (main): Likewise.
904 * unittests/basic_string_view/operations/find/char/4.cc (main):
905 Likewise.
906 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
907 Likewise.
908 (main): Likewise.
909 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
910 Likewise.
911 (main): Likewise.
912 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
913 Likewise.
914 (main): Likewise.
915 * unittests/basic_string_view/operations/substr/char/1.cc
916 (test01): Likewise.
917 (main): Likewise.
918 * unittests/basic_string_view/operators/char/2.cc (main):
919 Likewise.
920 * unittests/optional/assignment/1.cc (test): Likewise.
921 * unittests/optional/assignment/2.cc (test): Likewise.
922 * unittests/optional/assignment/3.cc (test): Likewise.
923 * unittests/optional/assignment/4.cc (test): Likewise.
924 * unittests/optional/assignment/5.cc (test): Likewise.
925 * unittests/optional/assignment/6.cc (test): Likewise.
926 * unittests/optional/assignment/7.cc (test): Likewise.
927 * unittests/optional/cons/copy.cc (test): Likewise.
928 * unittests/optional/cons/default.cc (test): Likewise.
929 * unittests/optional/cons/move.cc (test): Likewise.
930 * unittests/optional/cons/value.cc (test): Likewise.
931 * unittests/optional/in_place.cc (test): Likewise.
932 * unittests/optional/observers/1.cc (test): Likewise.
933 * unittests/optional/observers/2.cc (test): Likewise.
934
935 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
936
937 * tui-win.h (tui_set_var_cmd): Remove.
938 * tui-win.c (tui_set_var_cmd): Make static.
939
940 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
941
942 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
943 rbreak_command_wrapper): Remove.
944 * symtab.c (rbreak_command_wrapper): Remove.
945
946 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
947
948 * inferior.h (info_terminal_command): Remove declaration.
949 * inflow.c (info_terminal_command): Make static.
950
951 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
952
953 * inferior.c (exit_inferior_silent): Remove.
954
955 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
956
957 * dictionary.c (dict_empty, mdict_empty): Remove.
958 * dictionary.c (mdict_empty): Remove.
959
960 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
961
962 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
963 (arc_insn_get_memory_offset): Likewise.
964 (arc_insn_dump): Likewise.
965 * cp-support.c (test_cp_symbol_name_matches): Likewise.
966 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
967 * dictionary.c (dict_iterator_next): Likewise.
968 (dict_iter_match_first): Likewise.
969 (dict_iter_match_next): Likewise.
970 * f-lang.c (evaluate_subexp_f): Likewise.
971 * hppa-tdep.c (hppa_read_pc): Likewise.
972 * i386-tdep.c (i386_floatformat_for_type): Likewise.
973 * parse.c (write_exp_elt_msym): Likewise.
974 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
975 * remote.c (remote_packet_size): Likewise.
976 (remote_notif_stop_parse): Likewise.
977 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
978 * s12z-tdep.c (s12z_disassemble_info): Likewise.
979 * source.c (prepare_path_for_appending): Likewise.
980 * sparc64-linux-tdep.c
981 (sparc64_linux_handle_segmentation_fault); Likewise.
982 * stack.c (frame_selection_by_function_completer): Likewise.
983
984 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
985
986 * completer.c (set_gdb_completion_word_break_characters):
987 Remove.
988
989 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
990
991 * dwarf-index-write.c: Include dwarf-index-write.h.
992 * mi/mi-interp.c: Include mi/mi-interp.h.
993
994 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
995
996 * aarch32-tdep.c: Include aarch32-tdep.h.
997 * aarch32-tdep.h: Forward-declare struct target_desc.
998
999 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1000
1001 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1002 strerror.
1003 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1004 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1005
1006 2019-11-25 Tom de Vries <tdevries@suse.de>
1007
1008 * contrib/words.sh: Add -c option.
1009
1010 2019-11-25 Christian Biesinger <cbiesinger@google.com>
1011
1012 * solib.c (solib_find_1): Change int to bool.
1013 (exec_file_find): Change int to bool.
1014 (solib_find): Change int to bool.
1015 (solib_read_symbols): Change int to bool.
1016 (solib_used): Change int to bool.
1017 (solib_add): Change int to bool.
1018 (info_sharedlibrary_command): Change int to bool.
1019 (solib_contains_address_p): Change int to bool.
1020 (solib_keep_data_in_core): Change int to bool.
1021 (in_solib_dynsym_resolve_code): Change int to bool.
1022 (reload_shared_libraries_1): Change int to bool.
1023 (gdb_sysroot_changed): Change int to bool.
1024 * solib.h (solib_read_symbols): Change int to bool.
1025 (solib_contains_address_p): Change int to bool.
1026 (solib_keep_data_in_core): Change int to bool.
1027 (in_solib_dynsym_resolve_code): Change int to bool.
1028 (libpthread_name_p): Change int to bool.
1029
1030 2019-11-25 Luis Machado <luis.machado@linaro.org>
1031
1032 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1033 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1034 (remote_packet_max_chars): New static global.
1035 (show_remote_packet_max_chars): New function.
1036 (remote_target::putpkt_binary): Adjust to use new
1037 remote_packet_max_chars option.
1038 (remote_target::getpkt_or_notif_sane_1): Likewise.
1039 (_initialize_remote): Register new remote-packet-max-chars option.
1040
1041 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
1042
1043 * m68k-linux-nat.c: Include gdbarch.h.
1044
1045 2019-11-24 Tom Tromey <tom@tromey.com>
1046
1047 * symfile.c (read_symbols): Update.
1048 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1049 bool.
1050 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1051 (psym_lookup_symbol, psym_find_last_source_symtab)
1052 (psym_forget_cached_source_info, psym_print_stats)
1053 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1054 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1055 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1056 (psym_find_compunit_symtab_by_address)
1057 (maintenance_print_psymbols, maintenance_info_psymtabs)
1058 (maintenance_check_psymtabs): Update.
1059 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1060 bool.
1061
1062 2019-11-22 Tom Tromey <tom@tromey.com>
1063
1064 * observable.h: Update comments.
1065
1066 2019-11-22 Tom Tromey <tromey@adacore.com>
1067
1068 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1069 (print_ada_task_info): Don't try to fetch thread id if task is not
1070 alive.
1071
1072 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1073
1074 * ada-exp.y: Update.
1075 * ada-lang.c (sort_choices): Update.
1076 (ada_print_symbol_signature): Update.
1077 (resolve_subexp): Update.
1078 (ada_parse_renaming): Update.
1079 (ada_read_renaming_var_value): Update.
1080 (lesseq_defined_than): Update.
1081 (remove_extra_symbols): Update.
1082 (remove_irrelevant_renamings): Update.
1083 (ada_add_block_symbols): Update.
1084 (ada_collect_symbol_completion_matches): Update.
1085 (ada_is_renaming_symbol): Update.
1086 (aggregate_assign_from_choices): Update.
1087 (ada_evaluate_subexp): Update.
1088 (ada_has_this_exception_support): Update.
1089 (ada_is_non_standard_exception_sym): Update.
1090 (ada_add_exceptions_from_frame): Update.
1091 (ada_add_global_exceptions): Update.
1092 (ada_print_subexp): Update.
1093 * ax-gdb.c (gen_var_ref): Update.
1094 (gen_maybe_namespace_elt): Update.
1095 (gen_expr_for_cast): Update.
1096 (gen_expr): Update.
1097 * block.h: Update.
1098 * blockframe.c (find_pc_partial_function): Update.
1099 * breakpoint.c (print_breakpoint_location): Update.
1100 (update_static_tracepoint): Update.
1101 * btrace.c (ftrace_print_function_name): Update.
1102 (ftrace_function_switched): Update.
1103 * buildsym.c (find_symbol_in_list): Update.
1104 * c-exp.y: Update.
1105 * c-typeprint.c (c_print_typedef): Update.
1106 (c_type_print_template_args): Update.
1107 * cli/cli-cmds.c (edit_command): Update.
1108 (list_command): Update.
1109 (print_sal_location): Update.
1110 * coffread.c (patch_opaque_types): Update.
1111 (process_coff_symbol): Update.
1112 (coff_read_enum_type): Update.
1113 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1114 (convert_one_symbol): Update.
1115 (hash_symname): Update.
1116 (eq_symname): Update.
1117 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1118 * compile/compile-cplus-types.c (debug_print_scope): Update.
1119 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1120 * compile/compile-object-load.c (get_out_value_type): Update.
1121 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1122 (search_symbol_list): Update.
1123 (cp_lookup_symbol_imports_or_template): Update.
1124 * cp-support.c (overload_list_add_symbol): Update.
1125 * ctfread.c (psymtab_to_symtab): Update.
1126 * dbxread.c (cp_set_block_scope): Update.
1127 * dictionary.c (iter_match_first_hashed): Update.
1128 (iter_match_next_hashed): Update.
1129 (insert_symbol_hashed): Update.
1130 (iter_match_next_linear): Update.
1131 * dictionary.h: Update.
1132 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1133 (locexpr_describe_location_piece): Update.
1134 (locexpr_describe_location_1): Update.
1135 (locexpr_generate_c_location): Update.
1136 (loclist_describe_location): Update.
1137 (loclist_generate_c_location): Update.
1138 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1139 (read_func_scope): Update.
1140 (process_enumeration_scope): Update.
1141 (new_symbol): Update.
1142 (dwarf2_const_value): Update.
1143 (dwarf2_symbol_mark_computed): Update.
1144 * eval.c (evaluate_funcall): Update.
1145 (evaluate_subexp_standard): Update.
1146 * expprint.c (print_subexp_standard): Update.
1147 (dump_subexp_body_standard): Update.
1148 * f-valprint.c (info_common_command_for_block): Update.
1149 * findvar.c (get_hosting_frame): Update.
1150 (default_read_var_value): Update.
1151 * go-lang.c (go_symbol_package_name): Update.
1152 * guile/scm-block.c (bkscm_print_block_smob): Update.
1153 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1154 (gdbscm_symbol_name): Update.
1155 (gdbscm_symbol_linkage_name): Update.
1156 (gdbscm_symbol_print_name): Update.
1157 * infcall.c (get_function_name): Update.
1158 * infcmd.c (jump_command): Update.
1159 (finish_command): Update.
1160 * infrun.c (insert_exception_resume_breakpoint): Update.
1161 * linespec.c (canonicalize_linespec): Update.
1162 (create_sals_line_offset): Update.
1163 (convert_linespec_to_sals): Update.
1164 (complete_label): Update.
1165 (find_label_symbols_in_block): Update.
1166 * m2-typeprint.c (m2_print_typedef): Update.
1167 * mdebugread.c (mdebug_reg_to_regnum): Update.
1168 (parse_symbol): Update.
1169 (mylookup_symbol): Update.
1170 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1171 (list_args_or_locals): Update.
1172 * objc-lang.c (compare_selectors): Update.
1173 (info_selectors_command): Update.
1174 (compare_classes): Update.
1175 (info_classes_command): Update.
1176 (find_imps): Update.
1177 * p-typeprint.c (pascal_print_typedef): Update.
1178 * printcmd.c (build_address_symbolic): Update.
1179 (info_address_command): Update.
1180 (print_variable_and_value): Update.
1181 * python/py-framefilter.c (extract_sym): Update.
1182 (py_print_single_arg): Update.
1183 * python/py-symbol.c (sympy_str): Update.
1184 (sympy_get_name): Update.
1185 (sympy_get_linkage_name): Update.
1186 * python/python.c (gdbpy_rbreak): Update.
1187 * record-btrace.c (btrace_get_bfun_name): Update.
1188 (btrace_call_history): Update.
1189 * rust-lang.c (rust_print_typedef): Update.
1190 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1191 * stabsread.c (stab_reg_to_regnum): Update.
1192 (define_symbol): Update.
1193 (read_enum_type): Update.
1194 (common_block_end): Update.
1195 (cleanup_undefined_types_1): Update.
1196 (scan_file_globals): Update.
1197 * stack.c (print_frame_arg): Update.
1198 (print_frame_args): Update.
1199 (find_frame_funname): Update.
1200 (info_frame_command_core): Update.
1201 (iterate_over_block_locals): Update.
1202 (print_block_frame_labels): Update.
1203 (do_print_variable_and_value): Update.
1204 (iterate_over_block_arg_vars): Update.
1205 (return_command): Update.
1206 * symmisc.c (dump_symtab_1): Update.
1207 (print_symbol): Update.
1208 * symtab.c (eq_symbol_entry): Update.
1209 (symbol_cache_dump): Update.
1210 (lookup_language_this): Update.
1211 (find_pc_sect_line): Update.
1212 (skip_prologue_sal): Update.
1213 (symbol_search::compare_search_syms): Update.
1214 (treg_matches_sym_type_name): Update.
1215 (search_symbols): Update.
1216 (print_symbol_info): Update.
1217 (rbreak_command): Update.
1218 (completion_list_add_symbol): Update.
1219 (find_gnu_ifunc): Update.
1220 (get_symbol_address): Update.
1221 (search_module_symbols): Update.
1222 (info_module_subcommand): Update.
1223 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1224 (SYMBOL_LINKAGE_NAME): Remove.
1225 (SYMBOL_DEMANGLED_NAME): Remove.
1226 (SYMBOL_PRINT_NAME): Remove.
1227 (SYMBOL_SEARCH_NAME): Remove.
1228 * tracepoint.c (set_traceframe_context): Update.
1229 (validate_actionline): Update.
1230 (collection_list::collect_symbol): Update.
1231 (encode_actions_1): Update.
1232 (info_scope_command): Update.
1233 (print_one_static_tracepoint_marker): Update.
1234 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1235 * valops.c (address_of_variable): Update.
1236 (find_overload_match): Update.
1237 (find_oload_champ): Update.
1238
1239 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1240
1241 * ada-lang.c (ada_lookup_simple_minsym): Update.
1242 (ada_collect_symbol_completion_matches): Update.
1243 * ada-tasks.c (read_atcb): Update.
1244 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1245 (amd64_windows_skip_trampoline_code): Update.
1246 * arm-tdep.c (skip_prologue_function): Update.
1247 (arm_skip_stack_protector): Update.
1248 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1249 (arm_wince_skip_main_prologue): Update.
1250 * ax-gdb.c (gen_expr): Update.
1251 * block.c (call_site_for_pc): Update.
1252 * blockframe.c (find_pc_partial_function): Update.
1253 * breakpoint.c (set_breakpoint_location_function): Update.
1254 * btrace.c (ftrace_print_function_name): Update.
1255 (ftrace_function_switched): Update.
1256 * c-valprint.c (print_unpacked_pointer): Update.
1257 * coffread.c (coff_symfile_read): Update.
1258 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1259 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1260 * dwarf-index-write.c (write_psymbols): Update.
1261 * dwarf2loc.c (call_site_to_target_addr): Update.
1262 (func_verify_no_selftailcall): Update.
1263 (tailcall_dump): Update.
1264 (call_site_find_chain_1): Update.
1265 (dwarf_expr_reg_to_entry_parameter): Update.
1266 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1267 * eval.c (evaluate_funcall): Update.
1268 (evaluate_subexp_standard): Update.
1269 (evaluate_subexp_for_sizeof): Update.
1270 * expprint.c (print_subexp_standard): Update.
1271 (dump_subexp_body_standard): Update.
1272 * frame.c (get_prev_frame_always_1): Update.
1273 * frv-tdep.c (frv_skip_main_prologue): Update.
1274 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1275 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1276 (gnuv3_get_typename_from_type_info): Update.
1277 (gnuv3_skip_trampoline): Update.
1278 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1279 * i386-tdep.c (i386_skip_main_prologue): Update.
1280 (i386_pe_skip_trampoline_code): Update.
1281 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1282 * infcall.c (get_function_name): Update.
1283 * linespec.c (minsym_found): Update.
1284 * linux-fork.c (info_checkpoints_command): Update.
1285 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1286 (m32c_m16c_pointer_to_address): Update.
1287 * maint.c (maintenance_translate_address): Update.
1288 * minsyms.c (add_minsym_to_hash_table): Update.
1289 (add_minsym_to_demangled_hash_table): Update.
1290 (lookup_minimal_symbol_mangled): Update.
1291 (lookup_minimal_symbol_demangled): Update.
1292 (lookup_minimal_symbol_linkage): Update.
1293 (lookup_minimal_symbol_text): Update.
1294 (lookup_minimal_symbol_by_pc_name): Update.
1295 (minimal_symbol_is_less_than): Update.
1296 (compact_minimal_symbols): Update.
1297 (build_minimal_symbol_hash_tables): Update.
1298 (find_solib_trampoline_target): Update.
1299 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1300 (mips_skip_pic_trampoline_code): Update.
1301 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1302 * objc-lang.c (info_selectors_command): Update.
1303 (info_classes_command): Update.
1304 (find_methods): Update.
1305 (find_imps): Update.
1306 * p-valprint.c (pascal_val_print): Update.
1307 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1308 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1309 * printcmd.c (build_address_symbolic): Update.
1310 (info_symbol_command): Update.
1311 * psymtab.c (psymbol_name_matches): Update.
1312 (match_partial_symbol): Update.
1313 (lookup_partial_symbol): Update.
1314 (print_partial_symbols): Update.
1315 (sort_pst_symbols): Update.
1316 (maintenance_check_psymtabs): Update.
1317 * python/py-framefilter.c (py_print_frame): Update.
1318 * python/python.c (gdbpy_rbreak): Update.
1319 * record-btrace.c (btrace_get_bfun_name): Update.
1320 (btrace_call_history): Update.
1321 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1322 (rs6000_skip_trampoline_code): Update.
1323 * sol-thread.c (info_cb): Update.
1324 * stabsread.c (scan_file_globals): Update.
1325 * stack.c (find_frame_funname): Update.
1326 (info_frame_command_core): Update.
1327 * symmisc.c (dump_msymbols): Update.
1328 * symtab.c (symbol_natural_name): Rename to..,
1329 (general_symbol_info::natural_name): ...this.
1330 (symbol_demangled_name): Rename to...
1331 (general_symbol_info::demangled_name): ...this.
1332 (symbol_search_name): Rename to...
1333 (general_symbol_info::search_name): ...this.
1334 (symbol_matches_search_name): Update.
1335 (find_pc_sect_line): Update.
1336 (skip_prologue_sal): Update.
1337 (search_symbols): Update.
1338 (print_msymbol_info): Update.
1339 (rbreak_command): Update.
1340 (completion_list_add_msymbol): Update.
1341 (completion_list_objc_symbol): Update.
1342 (get_msymbol_address): Update.
1343 * symtab.h (struct general_symbol_info): Add member functions
1344 natural_name (), linkage_name (), print_name (), demangled_name (),
1345 and search_name ().
1346 (SYMBOL_NATURAL_NAME): Update.
1347 (symbol_natural_name): Move to a member function on general_symbol_info.
1348 (SYMBOL_DEMANGLED_NAME): Update.
1349 (symbol_demangled_name): Move to a member function on
1350 general_symbol_info.
1351 (SYMBOL_SEARCH_NAME): Update.
1352 (symbol_search_name): Move to a member function on general_symbol_info.
1353 (MSYMBOL_NATURAL_NAME): Remove.
1354 (MSYMBOL_LINKAGE_NAME): Remove.
1355 (MSYMBOL_PRINT_NAME): Remove.
1356 (MSYMBOL_DEMANGLED_NAME): Remove.
1357 (MSYMBOL_SEARCH_NAME): Remove.
1358 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1359
1360 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1361
1362 * symtab.c (create_demangled_names_hash): Use per_bfd->
1363 minimal_symbol_count for computing the initial size, if greater
1364 than our default size.
1365
1366 2019-11-22 Tom de Vries <tdevries@suse.de>
1367
1368 * contrib/words.sh: Improve words extraction.
1369
1370 2019-11-22 Tom de Vries <tdevries@suse.de>
1371
1372 * contrib/words.sh: Combine sed invocations.
1373
1374 2019-11-21 Christian Biesinger <cbiesinger@google.com>
1375
1376 * Makefile.in: Update.
1377 * demangle.c: Rename to...
1378 * gdb-demangle.c: ..this.
1379 (is_cplus_marker): Change return type to bool.
1380 (_initialize_demangler): Rename to...
1381 (_initialize_gdb_demangle): ...this.
1382 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1383 * symtab.h (demangle): Remove declaration; instead include
1384 gdb-demangle.h.
1385
1386 2019-11-21 Tom Tromey <tromey@adacore.com>
1387
1388 * gdbsupport/format.c (format_pieces): Parse %I64d.
1389 * unittests/format_pieces-selftests.c (test_windows_formats): New
1390 function.
1391 (run_tests): Call it.
1392
1393 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1394
1395 Byte reverse display of variables with DW_END_big, DW_END_little
1396 (DW_AT_endianity) dwarf attributes if different than the native
1397 byte order.
1398 * ada-lang.c (ada_value_binop):
1399 Use type_byte_order instead of gdbarch_byte_order.
1400 * ada-valprint.c (printstr):
1401 (ada_val_print_string):
1402 * ada-lang.c (value_pointer):
1403 (ada_value_binop):
1404 Use type_byte_order instead of gdbarch_byte_order.
1405 * c-lang.c (c_get_string):
1406 Use type_byte_order instead of gdbarch_byte_order.
1407 * c-valprint.c (c_val_print_array):
1408 Use type_byte_order instead of gdbarch_byte_order.
1409 * cp-valprint.c (cp_print_class_member):
1410 Use type_byte_order instead of gdbarch_byte_order.
1411 * dwarf2loc.c (rw_pieced_value):
1412 Use type_byte_order instead of gdbarch_byte_order.
1413 * dwarf2read.c (read_base_type): Handle DW_END_big,
1414 DW_END_little
1415 * f-lang.c (f_get_encoding):
1416 Use type_byte_order instead of gdbarch_byte_order.
1417 * findvar.c (default_read_var_value):
1418 Use type_byte_order instead of gdbarch_byte_order.
1419 * gdbtypes.c (check_types_equal):
1420 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1421 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1422 and TYPE_ENDIANITY_LITTLE if set.
1423 (type_byte_order): new function.
1424 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1425 (struct main_type) <flag_endianity_not_default>:
1426 New field.
1427 (type_byte_order): New function.
1428 * infcmd.c (default_print_one_register_info):
1429 Use type_byte_order instead of gdbarch_byte_order.
1430 * p-lang.c (pascal_printstr):
1431 Use type_byte_order instead of gdbarch_byte_order.
1432 * p-valprint.c (pascal_val_print):
1433 Use type_byte_order instead of gdbarch_byte_order.
1434 * printcmd.c (print_scalar_formatted):
1435 Use type_byte_order instead of gdbarch_byte_order.
1436 * solib-darwin.c (darwin_current_sos):
1437 Use type_byte_order instead of gdbarch_byte_order.
1438 * solib-svr4.c (solib_svr4_r_ldsomap):
1439 Use type_byte_order instead of gdbarch_byte_order.
1440 * stap-probe.c (stap_modify_semaphore):
1441 Use type_byte_order instead of gdbarch_byte_order.
1442 * target-float.c (target_float_same_format_p):
1443 Use type_byte_order instead of gdbarch_byte_order.
1444 * valarith.c (scalar_binop):
1445 (value_bit_index):
1446 Use type_byte_order instead of gdbarch_byte_order.
1447 * valops.c (value_cast):
1448 Use type_byte_order instead of gdbarch_byte_order.
1449 * valprint.c (generic_emit_char):
1450 (generic_printstr):
1451 (val_print_string):
1452 Use type_byte_order instead of gdbarch_byte_order.
1453 * value.c (unpack_long):
1454 (unpack_bits_as_long):
1455 (unpack_value_bitfield):
1456 (modify_field):
1457 (pack_long):
1458 (pack_unsigned_long):
1459 Use type_byte_order instead of gdbarch_byte_order.
1460 * findvar.c (unsigned_pointer_to_address):
1461 (signed_pointer_to_address):
1462 (unsigned_address_to_pointer):
1463 (address_to_signed_pointer):
1464 (default_read_var_value):
1465 (default_value_from_register):
1466 Use type_byte_order instead of gdbarch_byte_order.
1467 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1468 Use type_byte_order instead of gdbarch_byte_order.
1469 * riscv-tdep.c (riscv_print_one_register_info):
1470 Use type_byte_order instead of gdbarch_byte_order.
1471
1472 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1473
1474 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1475 (current_ui_gdb_stdin_ptr): Likewise.
1476 (current_ui_gdb_stderr_ptr): Likewise.
1477 (current_ui_gdb_stdlog_ptr): Likewise.
1478 (current_ui_current_uiout_ptr): Likewise.
1479 (gen_ret_current_ui_field_ptr): Remove.
1480
1481 2019-11-21 Tom de Vries <tdevries@suse.de>
1482
1483 PR gdb/24956
1484 * cli/cli-script.c (execute_control_command): Only switch to
1485 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1486
1487 2019-11-19 Tom Tromey <tom@tromey.com>
1488
1489 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1490 Now static. Change type of "name".
1491 (tui_set_win_height_command): Don't copy "arg".
1492 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1493 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1494
1495 2019-11-19 Ali Tamur <tamur@google.com>
1496
1497 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1498 "if (attr != nullptr)".
1499 (dwarf2_find_base_address): Likewise.
1500 (dwarf2_build_include_psymtabs): Likewise.
1501 (read_cutu_die_from_dwo): Likewise.
1502 (read_func_scope): Likewise.
1503 (read_call_site_scope): Likewise.
1504 (dwarf2_get_pc_bounds): Likewise.
1505 (dwarf2_record_block_ranges): Likewise.
1506 (dwarf2_add_field): Likewise.
1507 (dwarf2_add_member_fn): Likewise.
1508 (read_structure_type): Likewise.
1509 (read_enumeration_type): Likewise.
1510 (read_array_type): Likewise.
1511 (read_array_order): Likewise.
1512 (read_set_type): Likewise.
1513 (read_common_block): Likewise.
1514 (read_tag_reference_type): Likewise.
1515 (read_tag_string_type): Likewise.
1516 (read_subroutine_type): Likewise.
1517 (read_base_type): Likewise.
1518 (read_subrange_type): Likewise.
1519 (new_symbol): Likewise.
1520 (prepare_one_comp_unit): Likewise.
1521
1522 2019-11-19 Tom Tromey <tromey@adacore.com>
1523
1524 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1525 result in error when DebugActiveProcess fails.
1526
1527 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1528 Pedro Alves <palves@redhat.com>
1529
1530 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1531 * target.c (target_stack::push): Call 'unpush' if there's a
1532 target on top of the stack.
1533
1534 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1535
1536 * python/py-block.c (blpy_dealloc): Call tp_free.
1537 (blpy_block_syms_dealloc): Likewise.
1538 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1539 * python/py-inferior.c (infpy_dealloc): Likewise.
1540 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1541 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1542 * python/py-symbol.c (sympy_dealloc): Likewise.
1543 * python/py-symtab.c (stpy_dealloc): Likewise.
1544 * python/py-type.c (typy_iterator_dealloc): Likewise.
1545
1546 2019-11-18 Christian Biesinger <cbiesinger@google.com>
1547
1548 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1549 constructor instead of using a class initializer.
1550
1551 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1552
1553 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1554 * configure: Regenerate.
1555 * configure.ac: Don't source common.host.
1556 * gdbsupport/common.host: Remove.
1557 * gdbsupport/mingw-strerror.c: Remove.
1558 * gdbsupport/posix-strerror.c: Rename to...
1559 * gdbsupport/safe-strerror.c: ...this.
1560
1561 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1562
1563 * maint.c (scoped_command_stats::print_time): Use localtime_r
1564 instead of localtime (provided through gnulib if necessary).
1565 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1566 of ctime.
1567
1568 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1569
1570 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1571 avoid compile errors.
1572
1573 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1574
1575 * config.in: Regenerate.
1576 * configure: Regenerate.
1577 * gdbsupport/common.m4: No longer check for strerror_r.
1578 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1579 POSIX version of strerror_r, now that gnulib provides it if
1580 necessary.
1581
1582 2019-11-14 Christian Biesinger <cbiesinger@google.com>
1583
1584 * README (`configure' options): Update.
1585
1586 2019-11-14 Tom Tromey <tromey@adacore.com>
1587
1588 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1589 expected type for the RHS if the LHS is a convenience variable.
1590
1591 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1592
1593 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1594 Provide explicit default and copy constructor.
1595
1596 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1597
1598 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1599 only call Py_INCREF (newbp) in the bppy_pending_object case.
1600
1601 2019-11-13 Tom Tromey <tromey@adacore.com>
1602
1603 PR build/25182:
1604 * psympriv.h (partial_symbol): Remove static assert.
1605 * symtab.h (general_symbol_info, symbol): Remove static assert.
1606
1607 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1608
1609 * gdbsupport/format.c (format_pieces::format_pieces): Support
1610 printf 'z' size modifier.
1611 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1612 * printcmd.c (ui_printf): Handle size_t_arg.
1613 * ui-out.c (ui_out::vmessage): Likewise.
1614 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1615 function.
1616 (run_tests): Call test_format_int_sizes.
1617
1618 2019-11-12 Christian Biesinger <cbiesinger@google.com>
1619
1620 * ada-exp.y (write_ambiguous_var): Update.
1621 * buildsym.c (add_symbol_to_list): Update.
1622 * dwarf2read.c (read_variable): Update.
1623 (new_symbol): Update.
1624 * jit.c (finalize_symtab): Update.
1625 * language.c (language_alloc_type_symbol): Update.
1626 * symtab.c (fixup_symbol_section): Update.
1627 (initialize_objfile_symbol_1): Move code to...
1628 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1629 (allocate_symbol): Update.
1630 (allocate_template_symbol): Update.
1631 (get_symbol_address): Update.
1632 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1633 of having as a field, and add a constructor.
1634 (SYMBOL_VALUE): Update.
1635 (SYMBOL_VALUE_ADDRESS): Update.
1636 (SET_SYMBOL_VALUE_ADDRESS): Update.
1637 (SYMBOL_VALUE_BYTES): Update.
1638 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1639 (SYMBOL_BLOCK_VALUE): Update.
1640 (SYMBOL_VALUE_CHAIN): Update.
1641 (SYMBOL_LANGUAGE): Update.
1642 (SYMBOL_SECTION): Update.
1643 (SYMBOL_OBJ_SECTION): Update.
1644 (SYMBOL_SET_LANGUAGE): Update.
1645 (SYMBOL_SET_LINKAGE_NAME): Update.
1646 (SYMBOL_SET_NAMES): Update.
1647 (SYMBOL_NATURAL_NAME): Update.
1648 (SYMBOL_LINKAGE_NAME): Update.
1649 (SYMBOL_DEMANGLED_NAME): Update.
1650 (SYMBOL_SEARCH_NAME): Update.
1651 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1652 (struct symbol): Update.
1653 (struct template_symbol): Update.
1654 (struct rust_vtable_symbol): Update.
1655 * xcoffread.c (SYMBOL_DUP): Update.
1656
1657 2019-11-12 Tom Tromey <tom@tromey.com>
1658
1659 * tui/tui-layout.c (show_layout): Set current_layout.
1660 (show_source_disasm_command, show_data)
1661 (show_source_or_disasm_and_command): Don't set current_layout.
1662
1663 2019-11-12 Tom Tromey <tom@tromey.com>
1664
1665 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1666
1667 2019-11-12 Tom Tromey <tom@tromey.com>
1668
1669 * tui/tui-win.c (resize_message): New global.
1670 (show_tui_resize_message): New function.
1671 (tui_async_resize_screen): Print message if requested.
1672 (_initialize_tui_win): Add tui-resize-message setting.
1673 * NEWS: Add entry for new commands.
1674
1675 2019-11-11 Tom Tromey <tom@tromey.com>
1676
1677 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1678 functions.
1679
1680 2019-11-11 Christian Biesinger <cbiesinger@google.com>
1681
1682 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1683
1684 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1685
1686 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1687 function.
1688 * python/python-internal.h (gdbpy_lookup_static_symbols):
1689 Declare new function.
1690 * python/python.c (python_GdbMethods): Add
1691 gdb.lookup_static_symbols method.
1692 * NEWS: Mention gdb.lookup_static_symbols.
1693
1694 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1695
1696 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1697 static block of current object file first. Also fix typo in
1698 header comment.
1699
1700 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1701
1702 * stack.c (set_last_displayed_sal): Delete.
1703 (last_displayed_sal_valid): Delete.
1704 (last_displayed_pspace): Delete.
1705 (last_displayed_addr): Delete.
1706 (last_displayed_symtab): Delete.
1707 (last_displayed_line): Delete.
1708 (class last_displayed_symtab_info_type): New.
1709 (last_displayed_symtab_info): New static global variable.
1710 (print_frame_info): Call methods on last_displayed_symtab_info.
1711 (clear_last_displayed_sal): Update header comment, and make use of
1712 last_displayed_symtab_info.
1713 (last_displayed_sal_is_valid): Likewise.
1714 (get_last_displayed_pspace): Likewise.
1715 (get_last_displayed_addr): Likewise.
1716 (get_last_displayed_symtab): Likewise.
1717 (get_last_displayed_line): Likewise.
1718 (get_last_displayed_sal): Likewise.
1719 * stack.h (clear_last_displayed_sal): Update header comment.
1720 (last_displayed_sal_is_valid): Likewise.
1721 (get_last_displayed_pspace): Likewise.
1722 (get_last_displayed_addr): Likewise.
1723 (get_last_displayed_symtab): Likewise.
1724 (get_last_displayed_line): Likewise.
1725 (get_last_displayed_sal): Likewise.
1726
1727 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1728
1729 * stack.c (frame_show_address): Convert return type to bool.
1730 * stack.h (frame_show_address): Likewise, and update header
1731 comment.
1732
1733 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1734
1735 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1736 * unittests/vec-utils-selftests.c: New file.
1737 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1738
1739 2019-11-10 Tom Tromey <tom@tromey.com>
1740
1741 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1742 (tui_highlight_win): Likewise.
1743 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1744 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1745 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1746 Don't set can_highlight.
1747
1748 2019-11-10 Tom Tromey <tom@tromey.com>
1749
1750 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1751 Remove unused declaration.
1752
1753 2019-11-08 Tom Tromey <tromey@adacore.com>
1754
1755 * top.c (read_command_file): Update.
1756 (command_line_input): Make return type const.
1757 * python/py-gdb-readline.c: Update.
1758 * linespec.c (decode_line_2): Update.
1759 * defs.h (command_line_input): Make return type const.
1760 * cli/cli-script.c (read_next_line): Make return type const.
1761 * ada-lang.c (get_selections): Update.
1762
1763 2019-11-06 Christian Biesinger <cbiesinger@google.com>
1764
1765 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1766 * mi/mi-main.c (output_cores): Likewise.
1767 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1768 (linux_xfer_osdata_modules): Likewise.
1769 * remote.c (register_remote_support_xml): Likewise.
1770 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1771 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1772
1773 2019-11-06 Tom Tromey <tom@tromey.com>
1774
1775 * tui/tui-interp.c: Don't include readline.h.
1776 * tui/tui-hooks.c: Don't include readline.h.
1777 * symmisc.c: Include tilde.h, not readline.h.
1778 * symfile.c: Include tilde.h, not readline.h.
1779 * source.c: Include tilde.h, not readline.h.
1780 * solib.c: Include tilde.h, not readline.h.
1781 * psymtab.c: Include tilde.h, not readline.h.
1782 * exec.c: Include tilde.h, not readline.h.
1783 * corelow.c: Include tilde.h, not readline.h.
1784 * cli/cli-dump.c: Include tilde.h, not readline.h.
1785 * cli/cli-cmds.c: Don't include readline.h.
1786
1787 2019-11-05 Tom Tromey <tom@tromey.com>
1788
1789 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1790 (tui_disassemble): Set addr_size.
1791 (tui_disasm_window::set_contents): Use addr_size.
1792
1793 2019-11-05 Tom Tromey <tom@tromey.com>
1794
1795 * rust-lang.c (rust_language_defn): Update.
1796 * python/py-value.c (valpy_string): Call c_get_string.
1797 * p-lang.c (pascal_language_defn): Update.
1798 * opencl-lang.c (opencl_language_defn): Update.
1799 * objc-lang.c (objc_language_defn): Update.
1800 * m2-lang.c (m2_language_defn): Update.
1801 * language.c (unknown_language_defn, auto_language_defn): Update.
1802 (default_get_string): Remove.
1803 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1804 * go-lang.c (go_language_defn): Update.
1805 * f-lang.c (f_language_defn): Update.
1806 * d-lang.c (d_language_defn): Update.
1807 * c-lang.c (c_language_defn, cplus_language_defn)
1808 (asm_language_defn, minimal_language_defn): Update.
1809 * ada-lang.c (ada_language_defn): Update.
1810 * language.h (struct language_defn) <la_get_string>: Remove.
1811 (LA_GET_STRING): Remove.
1812 (default_get_string): Don't declare.
1813
1814 2019-11-05 Tom Tromey <tom@tromey.com>
1815
1816 * tui/tui-source.h (struct tui_source_window): Inline
1817 constructor. Remove destructor.
1818 <style_changed, m_observable>: Move to superclass.
1819 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1820 (struct tui_source_window_base): Move private members to end.
1821 <style_changed, m_observable>: Move from tui_source_window.
1822 * tui/tui-winsource.c (tui_copy_source_line): Move from
1823 tui-source.c. Rename from copy_source_line. Add special handling
1824 for negative line number.
1825 (tui_source_window_base::style_changed): Move from
1826 tui_source_window.
1827 (tui_source_window_base): Register observer.
1828 (~tui_source_window_base): New.
1829 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1830 rename.
1831 (tui_source_window::set_contents): Use tui_copy_source_line.
1832 (tui_source_window::tui_source_window): Move to tui-source.h.
1833 (tui_source_window::~tui_source_window): Remove.
1834 (tui_source_window::style_changed): Move to superclass.
1835 * tui/tui-disasm.c (tui_disassemble): Create string file with
1836 styling, when possible. Add "addr_size" parameter.
1837 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1838 Don't compute maximum size.
1839 (len_without_escapes): New function
1840
1841 2019-11-05 Tom Tromey <tom@tromey.com>
1842
1843 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1844 std::string.
1845 * tui/tui-winsource.c (tui_show_source_line): Update.
1846 * tui/tui-source.c (tui_source_window::set_contents): Update.
1847 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1848
1849 2019-11-05 Christian Biesinger <cbiesinger@google.com>
1850
1851 * symtab.h (gdb_static_assert): Put && operator at the beginning
1852 of the line instead of the end.
1853
1854 2019-11-04 Christian Biesinger <cbiesinger@google.com>
1855
1856 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1857 and sizeof (symbol).
1858 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1859
1860 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1861
1862 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1863 * configure.host: Mark *-*-solaris2.10* obsolete.
1864 * configure.tgt: Mark Solaris < 11 obsolete.
1865 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1866 Update target triplet.
1867
1868 2019-11-01 Tom Tromey <tromey@adacore.com>
1869
1870 * utils.c (print_sys_errmsg): Simplify.
1871
1872 2019-11-01 Tom Tromey <tromey@adacore.com>
1873
1874 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1875
1876 2019-11-01 Christian Biesinger <cbiesinger@google.com>
1877
1878 * configure: Regenerate.
1879 * configure.ac: Remove check for strerror_r.
1880 * gdbsupport/common.m4: Check for strerror_r.
1881
1882 2019-11-01 Luis Machado <luis.machado@linaro.org>
1883
1884 PR gdb/25124
1885
1886 * arm-tdep.c (arm_per_objfile): Rename to ...
1887 (arm_per_bfd): ... this.
1888 (arm_objfile_data_key): Rename to ...
1889 (arm_bfd_data_key): ... this.
1890 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1891 data.
1892 (arm_record_special_symbol): Likewise.
1893
1894 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1895
1896 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1897 end.
1898 * c-typeprint.c (c_print_typedef): Likewise.
1899 * f-typeprint.c (f_print_typedef): Likewise.
1900 * m2-typeprint.c (m2_print_typedef): Likewise.
1901 * p-typeprint.c (pascal_print_typedef): Likewise.
1902 * rust-lang.c (rust_print_typedef): Likewise.
1903 * symtab.c (print_symbol_info): Print a newline after calling
1904 typedef_print.
1905
1906 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1907
1908 * symtab.c (info_module_cmdlist): New variable.
1909 (info_module_command): New function.
1910 (search_module_symbols): New function.
1911 (info_module_subcommand): New function.
1912 (struct info_modules_var_func_options): New struct.
1913 (info_modules_var_func_options_defs): New variable.
1914 (make_info_modules_var_func_options_def_group): New function.
1915 (info_module_functions_command): New function.
1916 (info_module_variables_command): New function.
1917 (info_module_var_func_command_completer): New function.
1918 (_initialize_symtab): Register new 'info module functions' and
1919 'info module variables' commands.
1920 * symtab.h (typedef symbol_search_in_module): New typedef.
1921 (search_module_symbols): Declare new function.
1922 * NEWS: Mention new commands.
1923
1924 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1925
1926 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1927 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1928 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1929 MODULES_DOMAIN.
1930 (scan_partial_symbols): Only create partial module symbols for non
1931 declarations.
1932 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1933 and MODULES_DOMAIN.
1934 * symtab.c (search_domain_name): Likewise.
1935 (search_symbols): Likewise.
1936 (print_symbol_info): Likewise.
1937 (symtab_symbol_info): Likewise.
1938 (info_modules_command): New function.
1939 (_initialize_symtab): Register 'info modules' command.
1940 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1941 * NEWS: Mention new 'info modules' command.
1942
1943 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1944
1945 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1946 and $_gdb_maint_setting_str.
1947
1948 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1949
1950 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1951 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1952 (str_value_from_setting, gdb_setting_str_internal_fn)
1953 (gdb_maint_setting_str_internal_fn): New functions.
1954 (_initialize_cli_cmds): Define the new convenience functions.
1955 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1956 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1957
1958 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1959
1960 * agent.c (set_can_use_agent): When the setting is turned on,
1961 look up agent symbols if we don't have them yet.
1962 (agent_new_objfile): Don't look up agent symbols when the agent
1963 setting is off.
1964
1965 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1966
1967 * config.in: Regenerate.
1968
1969 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1970
1971 * configure: Regenerate.
1972 * configure.ac: Check for strerror_r.
1973 * gdbsupport/common-utils.h (safe_strerror): Change return value
1974 to const char * and document that this function is now threadsafe.
1975 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1976 thread_local and call strerror_r, if available.
1977 * utils.c (perror_string): Update.
1978 (print_sys_errmsg): Update.
1979
1980 2019-10-31 Luis Machado <luis.machado@linaro.org>
1981
1982 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1983 objfile_key.
1984 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1985 objfile to fetch per-bfd data.
1986 (arm_find_exidx_entry): Likewise.
1987
1988 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1989
1990 * gdbsupport/agent.c (debug_agent): Change type to bool.
1991 (use_agent): Likewise.
1992 (all_agent_symbols_look_up): Likewise.
1993 (agent_loaded_p): Change return value to bool.
1994 (agent_look_up_symbols): Update.
1995 (agent_capability_check): Change return value to bool.
1996 * gdbsupport/agent.h (agent_loaded_p): Likewise.
1997 (debug_agent): Change type to bool.
1998 (use_agent): Likewise.
1999 (agent_capability_check): Change return value to bool.
2000
2001 2019-10-30 Christian Biesinger <cbiesinger@google.com>
2002
2003 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2004 (build_minimal_symbol_hash_tables): Code to clear the table moved
2005 to clear_minimal_symbol_hash_tables.
2006 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2007 when needed.
2008
2009 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2010
2011 * infcmd.c: Remove includes.
2012 * infrun.c: Remove includes.
2013
2014 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2015
2016 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2017 (grow_vect): Remove declaration.
2018 (ada_type_of_array): Remove declaration.
2019 (ada_update_initial_language): Remove declaration.
2020 (ada_fold_name): Remove declaration.
2021 (ada_fill_in_ada_prototype): Remove declaration.
2022 (user_select_syms): Remove declaration.
2023 (get_selections): Remove declaration.
2024 (ada_tag_type): Remove declaration.
2025 (ada_value_tag): Remove declaration.
2026 (ada_is_others_clause): Remove declaration.
2027 (ada_in_variant): Remove declaration.
2028 (ada_value_struct_elt): Remove declaration.
2029 (ada_attribute_name): Remove declaration.
2030 (ada_system_address_type): Remove declaration.
2031 * ada-lang.c (ada_watch_location_expression): Make static.
2032 (GROW_VECT): Move here from ada-lang.h.
2033 (grow_vect): Make static.
2034 (ada_update_initial_language): Make static.
2035 (ada_fold_name): Make static.
2036 (ada_type_of_array): Make static.
2037 (encoded_ordered_before): Move up.
2038 (sort_choices): Move up.
2039 (print_signatures): Move up.
2040 (ada_print_symbol_signature): Move up.
2041 (get_selections): Move up and make static.
2042 (user_select_syms): Move up and make static.
2043 (ada_value_struct_elt): Move up and make static.
2044 (ada_tag_type): Make static.
2045 (ada_value_tag): Make static.
2046 (ada_is_others_clause): Make static.
2047 (ada_in_variant): Make static.
2048 (ada_attribute_name): Make static.
2049
2050 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2051
2052 * ada-lang.c: Remove includes.
2053 * ada-typeprint.c: Remove includes.
2054 * ada-valprint.c: Remove includes.
2055
2056 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
2057
2058 * addrmap.c: Add static assertions of type size, moved from
2059 _initialize_addrmap.
2060 (_initialize_addrmap): Remove.
2061
2062 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2063
2064 * coffread.c (record_minimal_symbol): Update.
2065 (process_coff_symbol): Update.
2066 * dbxread.c (read_dbx_symtab): Update.
2067 * dwarf2read.c (add_partial_symbol): Update.
2068 (fixup_go_packaging): Update.
2069 (load_partial_dies): Update.
2070 (new_symbol): Update.
2071 * elfread.c (record_minimal_symbol): Change signature to use
2072 gdb::string_view instead of name+len.
2073 (elf_symtab_read): Update.
2074 (elf_rel_plt_read): Update.
2075 * mdebugread.c (parse_partial_symbols): Update.
2076 (handle_psymbol_enumerators): Update.
2077 (new_symbol): Update.
2078 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2079 to use gdb::string_view instead of name+len.
2080 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2081 * psympriv.h (add_psymbol_to_list): Likewise.
2082 * psymtab.c (add_psymbol_to_bcache): Likewise.
2083 (add_psymbol_to_list): Likewise.
2084 * stabsread.c (define_symbol): Update.
2085 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2086 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2087 (symbol_set_names): Likewise.
2088 * xcoffread.c (scan_xcoff_symtab): Update.
2089
2090 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2091
2092 * symtab.h (symbol_set_names): Document that copy_name must be
2093 set to true for non-nullterminated strings.
2094 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2095 linkage_name if the entry was not found and we need to demangle.
2096
2097 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2098
2099 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2100 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2101 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2102 * gdbsupport/gdb_binary_search.h: New file.
2103
2104 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2105
2106 * NEWS: Mention new --with-system-gdbinit-dir option.
2107 * config.in: Regenerate.
2108 * configure: Regenerate.
2109 * configure.ac: Add new option --with-system-gdbinit-dir.
2110 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2111 for a ".gdb" suffix.
2112 * main.c (get_init_files): Change system_gdbinit argument to
2113 a vector and return the files in SYSTEM_GDBINIT_DIR in
2114 addition to SYSTEM_GDBINIT.
2115 (captured_main_1): Update.
2116 (print_gdb_help): Update.
2117 * top.c (print_gdb_configuration): Also print the value of
2118 SYSTEM_GDBINIT_DIR.
2119
2120 2019-10-28 Christian Biesinger <cbiesinger@google.com>
2121
2122 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2123 that takes gdb::string_view arguments.
2124
2125 2019-10-26 Tom de Vries <tdevries@suse.de>
2126
2127 * aarch64-linux-tdep.c: Fix typos in comments.
2128 * aarch64-tdep.c: Same.
2129 * ada-lang.c: Same.
2130 * amd64-nat.c: Same.
2131 * arc-tdep.c: Same.
2132 * arch/aarch64-insn.c: Same.
2133 * block.c: Same.
2134 * breakpoint.h: Same.
2135 * btrace.h: Same.
2136 * c-varobj.c: Same.
2137 * cli/cli-decode.c: Same.
2138 * cli/cli-script.c: Same.
2139 * cli/cli-utils.h: Same.
2140 * coff-pe-read.c: Same.
2141 * coffread.c: Same.
2142 * compile/compile-cplus-symbols.c: Same.
2143 * compile/compile-object-run.c: Same.
2144 * completer.c: Same.
2145 * corelow.c: Same.
2146 * cp-support.c: Same.
2147 * demangle.c: Same.
2148 * dwarf-index-write.c: Same.
2149 * dwarf2-frame.c: Same.
2150 * dwarf2-frame.h: Same.
2151 * eval.c: Same.
2152 * frame-base.h: Same.
2153 * frame.h: Same.
2154 * gdbcmd.h: Same.
2155 * gdbtypes.h: Same.
2156 * gnu-nat.c: Same.
2157 * guile/scm-objfile.c: Same.
2158 * i386-tdep.c: Same.
2159 * i386-tdep.h: Same.
2160 * infcall.c: Same.
2161 * infcall.h: Same.
2162 * linux-nat.c: Same.
2163 * m68k-tdep.c: Same.
2164 * macroexp.c: Same.
2165 * memattr.c: Same.
2166 * mi/mi-cmd-disas.c: Same.
2167 * mi/mi-getopt.h: Same.
2168 * mi/mi-main.c: Same.
2169 * minsyms.c: Same.
2170 * nat/aarch64-sve-linux-sigcontext.h: Same.
2171 * objfiles.h: Same.
2172 * ppc-linux-nat.c: Same.
2173 * ppc-linux-tdep.c: Same.
2174 * ppc-tdep.h: Same.
2175 * progspace.h: Same.
2176 * prologue-value.h: Same.
2177 * python/py-evtregistry.c: Same.
2178 * python/py-instruction.h: Same.
2179 * record-btrace.c: Same.
2180 * record-full.c: Same.
2181 * remote.c: Same.
2182 * rs6000-tdep.c: Same.
2183 * ser-tcp.c: Same.
2184 * sol-thread.c: Same.
2185 * sparc-sol2-tdep.c: Same.
2186 * sparc64-tdep.c: Same.
2187 * stabsread.c: Same.
2188 * symfile.c: Same.
2189 * symtab.h: Same.
2190 * target.c: Same.
2191 * tracepoint.c: Same.
2192 * tui/tui-data.h: Same.
2193 * tui/tui-io.c: Same.
2194 * tui/tui-win.c: Same.
2195 * tui/tui.c: Same.
2196 * unittests/rsp-low-selftests.c: Same.
2197 * user-regs.h: Same.
2198 * utils.c: Same.
2199 * utils.h: Same.
2200 * valarith.c: Same.
2201 * valops.c: Same.
2202 * valprint.c: Same.
2203 * valprint.h: Same.
2204 * value.c: Same.
2205 * value.h: Same.
2206 * varobj.c: Same.
2207 * x86-nat.h: Same.
2208 * xtensa-tdep.c: Same.
2209
2210 2019-10-25 Ali Tamur <tamur@google.com>
2211
2212 * charset.c (find_charset_names): Reflect API change.
2213
2214 2019-10-25 Christian Biesinger <cbiesinger@google.com>
2215
2216 * symtab.c (struct demangled_name_entry): Change demangled name
2217 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2218 part of the struct anymore.
2219 (symbol_set_names): No longer obstack allocate + copy the demangled
2220 name, just store the allocated name from bfd.
2221
2222 2019-10-25 Tom Tromey <tromey@adacore.com>
2223
2224 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2225 (bsearch_cie_cmp, add_cie): Remove.
2226 (find_cie): Reimplement.
2227 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2228 (dwarf2_build_frame_info): Update.
2229
2230 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2231
2232 PR gdb/25126
2233 * symfile.c (reread_symbols): Call forget_cached_source_info to
2234 clear the stale source cache.
2235
2236 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2237
2238 * configure: Regenerate.
2239 * configure.ac: Remove code that sets python_has_threads.
2240
2241 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2242
2243 * config.in: Regenerate.
2244 * configure: Regenerate.
2245 * configure.ac: Remove the code that uses sed to get the python
2246 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2247
2248 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2249
2250 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2251 error paths.
2252
2253 2019-10-23 Tom Tromey <tom@tromey.com>
2254
2255 * arc-tdep.c: Remove ".." from include.
2256 * frv-tdep.c: Remove ".." from include.
2257 * lm32-tdep.c: Remove ".." from include.
2258 * microblaze-tdep.c: Remove ".." from include.
2259 * or1k-tdep.h: Remove ".." from include.
2260 * s12z-tdep.c: Remove ".." from include.
2261 * Makefile.in (OPCODES_CFLAGS): Add comment.
2262 (TOP_CFLAGS): New variable.
2263 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2264
2265 2019-10-23 Tom Tromey <tom@tromey.com>
2266
2267 * Makefile.in (READLINE_DIR): Update.
2268
2269 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2270
2271 * infcall.c (call_function_by_hand_dummy): Fix the function
2272 comment. And extract out a code section into...
2273 (reserve_stack_space): ...this new function.
2274
2275 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2276
2277 * infcall.c (value_arg_coerce): Remove an unused parameter.
2278 (call_function_by_hand_dummy): Update the call to
2279 'value_arg_coerce'.
2280
2281 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2282
2283 * infcall.c (call_function_by_hand_dummy): Refactor.
2284
2285 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2286
2287 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2288
2289 2019-10-23 Tom Tromey <tom@tromey.com>
2290
2291 * configure: Rebuild.
2292 * configure.ac: Don't check for sigprocmask.
2293 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2294
2295 2019-10-23 Tom Tromey <tom@tromey.com>
2296
2297 * configure: Rebuild.
2298 * acinclude.m4: Use m4_include, not sinclude.
2299
2300 2019-10-23 Tom de Vries <tdevries@suse.de>
2301
2302 PR breakpoints/24687
2303 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2304
2305 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2306
2307 * symtab.c (struct demangled_name_entry) <language>: Change from
2308 bitfield to regular variable.
2309
2310 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2311
2312 * symtab.c (struct demangled_name_entry): Add a constructor.
2313 (free_demangled_name_entry): New function to call the destructor
2314 for demangled_name_entry.
2315 (create_demangled_names_hash): Pass free_demangled_name_entry to
2316 htab_create_alloc.
2317 (symbol_set_names): Call placement new for demangled_name_entry.
2318 * utils.c: No longer include xxhash.h here, now that fast_hash
2319 is inlined in the header.
2320 * utils.h: Instead, include it here.
2321
2322 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2323
2324 * Makefile.in: Link with libxxhash.
2325 * config.in: Regenerate.
2326 * configure: Regenerate.
2327 * configure.ac: Search for libxxhash.
2328 * utils.c (fast_hash): Use xxhash if present.
2329
2330 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2331
2332 * utils.h (fast_hash): New function.
2333 * symtab.c (hash_demangled_name_entry): Call new function
2334 fast_hash.
2335
2336 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2337
2338 * symtab.c (struct demangled_name_entry): Change type of mangled
2339 to gdb::string_view. Also adds a constructor that takes the
2340 mangled name.
2341 (hash_demangled_name_entry): Update.
2342 (eq_demangled_name_entry): Update.
2343 (free_demangled_name_entry): New function to call the destructor
2344 now that this is not a POD anymore.
2345 (create_demangled_names_hash): Pass free_demangled_name_entry to
2346 htab_create_alloc.
2347 (symbol_set_names): Update.
2348
2349 2019-10-21 Ali Tamur <tamu@google.com>
2350
2351 * dwarf2read.c (dir_index): Change type.
2352 (file_name_index): Likewise.
2353 (line_header::include_dir_at): Change comment and implementation on
2354 whether it is DWARF 5.
2355 (line_header::is_valid_file_index): New function.
2356 (line_header::file_name_at): Change comment and implementation on
2357 whether it is DWARF 5.
2358 (line_header::file_names): Change to private field renamed as
2359 m_file_names and introduce a new accessor method.
2360 (line_header::file_names_size): New method.
2361 (line_header::include_dirs): Change to private field and rename as
2362 m_include_dirs.
2363 (dw2_get_file_names_reader): Define local var at a smaller scope and
2364 reflect API change.
2365 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2366 (process_structure_scope): Likewise.
2367 (line_header::add_include_dir): Change message and reflect renaming.
2368 (line_header::add_file_name): Likewise.
2369 (read_formatted_entries): Handle DW_FORM_data16.
2370 (dwarf_decode_line_header): Fix line header length calculation.
2371 (psymtab_include_file_name): Change comment and API.
2372 (lnp_state_machine::m_file): Update comment and reflect type change.
2373 (lnp_state_machine::record_line): Reflect type change.
2374 (dwarf_decode_lines): Reflect API change.
2375 (file_file_name): Likewise.
2376 (file_full_name): Likewise.
2377
2378 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2379
2380 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2381
2382 2019-10-21 Tom Tromey <tom@tromey.com>
2383
2384 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2385
2386 2019-10-21 Tom Tromey <tom@tromey.com>
2387
2388 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2389 NM_H. Use AC_CONFIG_LINKS.
2390 * configure: Rebuild.
2391 * Makefile.in (NM_H): New variable.
2392 (generated_files): Add NM_H. Remove gcore.
2393 (nm.h, stamp-nmh): New targets.
2394
2395 2019-10-20 Tom Tromey <tom@tromey.com>
2396
2397 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2398 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2399 obsolete comment.
2400 (put_objfile_before): Now static.
2401
2402 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2403
2404 * gdbsupport/common-utils.h (startswith): Change return type to
2405 bool.
2406
2407 2019-10-19 Christian Biesinger <cbiesinger@google.com>
2408
2409 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2410 * breakpoint.c (bp_locations_compare): Rename to...
2411 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2412 (update_global_location_list): Use std::sort instead of qsort.
2413 * buildsym.c (compare_line_numbers): Rename to...
2414 (lte_is_less_than): ...this, and change to std::sort semantics.
2415 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2416 instead of qsort.
2417 * disasm.c (compare_lines): Rename to...
2418 (line_is_less_than): ...this, and change to std::sort semantics.
2419 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2420 of qsort.
2421 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2422 (fde_is_less_than): ...this, and change to std::sort semantics.
2423 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2424 * mdebugread.c (compare_blocks):
2425 (block_is_less_than): ...this, and change to std::sort semantics.
2426 (sort_blocks): Call std::sort instead of qsort.
2427 * objfiles.c (qsort_cmp): Rename to...
2428 (sort_cmp): ...this, and change to std::sort semantics.
2429 (update_section_map): Call std::sort instead of qsort.
2430 * remote.c (compare_pnums): Remove.
2431 (map_regcache_remote_table): Call std::sort instead of qsort.
2432 * utils.c (compare_positive_ints): Remove.
2433 * utils.h (compare_positive_ints): Remove.
2434 * xcoffread.c (compare_lte): Remove.
2435 (arrange_linetable): Call std::sort instead of qsort.
2436
2437 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2438
2439 * symfile.c (init_entry_point_info): Fix typo.
2440 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2441
2442 2019-10-18 Tom de Vries <tdevries@suse.de>
2443
2444 * aarch64-tdep.c: Fix typos in comments.
2445 * ada-lang.c: Same.
2446 * ada-tasks.c: Same.
2447 * alpha-tdep.c: Same.
2448 * alpha-tdep.h: Same.
2449 * amd64-nat.c: Same.
2450 * amd64-windows-tdep.c: Same.
2451 * arc-tdep.c: Same.
2452 * arc-tdep.h: Same.
2453 * arch-utils.c: Same.
2454 * arm-nbsd-tdep.c: Same.
2455 * arm-tdep.c: Same.
2456 * ax-gdb.c: Same.
2457 * blockframe.c: Same.
2458 * btrace.c: Same.
2459 * c-varobj.c: Same.
2460 * coff-pe-read.c: Same.
2461 * coffread.c: Same.
2462 * cris-tdep.c: Same.
2463 * darwin-nat.c: Same.
2464 * dbxread.c: Same.
2465 * dcache.c: Same.
2466 * disasm.c: Same.
2467 * dtrace-probe.c: Same.
2468 * dwarf-index-write.c: Same.
2469 * dwarf2-frame-tailcall.c: Same.
2470 * dwarf2-frame.c: Same.
2471 * dwarf2read.c: Same.
2472 * eval.c: Same.
2473 * exceptions.c: Same.
2474 * fbsd-tdep.c: Same.
2475 * findvar.c: Same.
2476 * frame.c: Same.
2477 * frv-tdep.c: Same.
2478 * gnu-v3-abi.c: Same.
2479 * go32-nat.c: Same.
2480 * h8300-tdep.c: Same.
2481 * hppa-tdep.c: Same.
2482 * i386-linux-tdep.c: Same.
2483 * i386-tdep.c: Same.
2484 * ia64-libunwind-tdep.c: Same.
2485 * ia64-tdep.c: Same.
2486 * infcmd.c: Same.
2487 * infrun.c: Same.
2488 * linespec.c: Same.
2489 * linux-nat.c: Same.
2490 * linux-thread-db.c: Same.
2491 * machoread.c: Same.
2492 * mdebugread.c: Same.
2493 * mep-tdep.c: Same.
2494 * mn10300-tdep.c: Same.
2495 * namespace.c: Same.
2496 * objfiles.c: Same.
2497 * opencl-lang.c: Same.
2498 * or1k-tdep.c: Same.
2499 * osabi.c: Same.
2500 * ppc-linux-nat.c: Same.
2501 * ppc-linux-tdep.c: Same.
2502 * ppc-sysv-tdep.c: Same.
2503 * printcmd.c: Same.
2504 * procfs.c: Same.
2505 * record-btrace.c: Same.
2506 * record-full.c: Same.
2507 * remote-fileio.c: Same.
2508 * remote.c: Same.
2509 * rs6000-tdep.c: Same.
2510 * s12z-tdep.c: Same.
2511 * score-tdep.c: Same.
2512 * ser-base.c: Same.
2513 * ser-go32.c: Same.
2514 * skip.c: Same.
2515 * sol-thread.c: Same.
2516 * solib-svr4.c: Same.
2517 * solib.c: Same.
2518 * source.c: Same.
2519 * sparc-nat.c: Same.
2520 * sparc-sol2-tdep.c: Same.
2521 * sparc-tdep.c: Same.
2522 * sparc64-tdep.c: Same.
2523 * stabsread.c: Same.
2524 * stack.c: Same.
2525 * symfile.c: Same.
2526 * symtab.c: Same.
2527 * target-descriptions.c: Same.
2528 * target-float.c: Same.
2529 * thread.c: Same.
2530 * utils.c: Same.
2531 * valops.c: Same.
2532 * valprint.c: Same.
2533 * value.c: Same.
2534 * varobj.c: Same.
2535 * windows-nat.c: Same.
2536 * xcoffread.c: Same.
2537 * xstormy16-tdep.c: Same.
2538 * xtensa-tdep.c: Same.
2539
2540 2019-10-17 Tom Tromey <tromey@adacore.com>
2541
2542 * configure: Rebuild.
2543 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2544 in AC_CONFIG_FILES invocation.
2545 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2546 new-style config.status invocation.
2547
2548 2019-10-17 Tom de Vries <tdevries@suse.de>
2549
2550 * arm-nbsd-nat.c: Fix typos in comments.
2551 * arm-tdep.c: Same.
2552 * darwin-nat-info.c: Same.
2553 * dwarf2read.c: Same.
2554 * elfread.c: Same.
2555 * event-top.c: Same.
2556 * findvar.c: Same.
2557 * gdbtypes.c: Same.
2558 * hppa-tdep.c: Same.
2559 * i386-tdep.c: Same.
2560 * jit.c: Same.
2561 * main.c: Same.
2562 * mdebugread.c: Same.
2563 * moxie-tdep.c: Same.
2564 * nto-procfs.c: Same.
2565 * osabi.c: Same.
2566 * ppc-linux-tdep.c: Same.
2567 * remote.c: Same.
2568 * riscv-tdep.c: Same.
2569 * s390-tdep.c: Same.
2570 * sh-tdep.c: Same.
2571 * sparc-linux-tdep.c: Same.
2572 * sparc-nat.c: Same.
2573 * stack.c: Same.
2574 * target-descriptions.c: Same.
2575 * top.c: Same.
2576 * varobj.c: Same.
2577
2578 2019-10-16 Tom Tromey <tom@tromey.com>
2579
2580 * objfiles.h (struct objfile) <original_name>: Now const.
2581
2582 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2583
2584 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2585 pass on to sigsetjmp's second argument.
2586 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2587
2588 2019-10-16 Keith Seitz <keiths@redhat.com>
2589
2590 PR gdb/23567
2591 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2592 sections whose size is greater than the file size.
2593
2594 2019-10-16 Jim Wilson <jimw@sifive.com>
2595
2596 * riscv-tdep.c (riscv_gcc_target_options): New.
2597 (riscv_gnu_triplet_regexp): New.
2598 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2599 set_gdbarch_gnu_triplet_regexp.
2600
2601 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2602
2603 * Makefile.in: Add xml-builtin.h.
2604 * features/feature_to_c.sh: Add an include for xml-builtin.h
2605 to ensure that the compiler checks that the types match.
2606 * xml-builtin.h: New file.
2607 * xml-support.c (fetch_xml_builtin): Add missing const.
2608 * xml-support.h: Remove declaration of xml_builtins.
2609
2610 2019-10-16 Tom de Vries <tdevries@suse.de>
2611
2612 PR tdep/25096
2613 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2614 (amd64_classify_aggregate): ... here.
2615 (amd64_classify_aggregate_field): Handled fiels of nested structs
2616 recursively.
2617
2618 2019-10-16 Tom de Vries <tdevries@suse.de>
2619
2620 PR tdep/24104
2621 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2622 that handles 'theclass'.
2623
2624 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2625
2626 * linespec.c (decode_digits_ordinary): Update comment.
2627 * make-target-delegates: No longer need to handle VEC case.
2628 * memrange.c (normalize_mem_ranges): Update comment.
2629 * namespace.c (add_using_directive): Update comment.
2630 * objc-lang.c (uniquify_strings): Update comment.
2631 * ppc-linux-nat.c (struct thread_points): Update comment.
2632 * probe.h (find_probes_in_objfile): Update comment.
2633 * target.h (enum flash_preserve_mode): Update comment.
2634 * varobj.c (varobj_restrict_range): Update comment.
2635 * varobj.h (varobj_list_children): Update comment.
2636
2637 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2638
2639 * Makefile.in: Remove references to vec.h and vec.c.
2640 * aarch64-tdep.c: No longer include vec.h.
2641 * ada-lang.c: Likewise.
2642 * ada-lang.h: Likewise.
2643 * arm-tdep.c: Likewise.
2644 * ax.h: Likewise.
2645 * breakpoint.h: Likewise.
2646 * charset.c: Likewise.
2647 * cp-support.h: Likewise.
2648 * dtrace-probe.c: Likewise.
2649 * dwarf2read.c: Likewise.
2650 * extension.h: Likewise.
2651 * gdb_bfd.c: Likewise.
2652 * gdbsupport/gdb_vecs.h: Likewise.
2653 * gdbsupport/vec.c: Remove.
2654 * gdbsupport/vec.h: Remove.
2655 * gdbthread.h: Likewise.
2656 * guile/scm-type.c: Likewise.
2657 * inline-frame.c: Likewise.
2658 * machoread.c: Likewise.
2659 * memattr.c: Likewise.
2660 * memrange.h: Likewise.
2661 * namespace.h: Likewise.
2662 * nat/linux-btrace.h: Likewise.
2663 * osdata.c: Likewise.
2664 * parser-defs.h: Likewise.
2665 * progspace.h: Likewise.
2666 * python/py-type.c: Likewise.
2667 * record-btrace.c: Likewise.
2668 * rust-exp.y: Likewise.
2669 * solib-target.c: Likewise.
2670 * stap-probe.c: Likewise.
2671 * target-descriptions.c: Likewise.
2672 * target-memory.c: Likewise.
2673 * target.h: Likewise.
2674 * varobj.c: Likewise.
2675 * varobj.h: Likewise.
2676 * xml-support.h: Likewise.
2677
2678 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2679
2680 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2681 Update for new std::vector based implementation.
2682 (process_psymtab_comp_unit_reader): Likewise.
2683 (scan_partial_symbols): Likewise.
2684 (recursively_compute_inclusions): Likewise.
2685 (compute_compunit_symtab_includes): Likewise.
2686 (process_imported_unit_die): Likewise.
2687 (queue_and_load_dwo_tu): Likewise.
2688 (follow_die_sig_1): Likewise.
2689 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2690 (typedef dwarf2_per_cu_ptr): Remove.
2691 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2692 function.
2693 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2694 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2695 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2696 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2697 std::vector.
2698
2699 2019-10-15 Tom Tromey <tromey@adacore.com>
2700
2701 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2702 TID.
2703
2704 2019-10-15 Tom Tromey <tromey@adacore.com>
2705
2706 * windows-nat.c (windows_nat_target::fetch_registers)
2707 (windows_nat_target::store_registers): Rename "pid" to "tid".
2708
2709 2019-10-15 Tom Tromey <tromey@adacore.com>
2710
2711 * gdbarch.h, gdbarch.c: Rebuild.
2712 * gdbarch.sh (gcc_target_options): Change return type to
2713 std::string.
2714 * compile/compile.c (get_args): Update.
2715 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2716 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2717 std::string.
2718 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2719 std::string.
2720 * arch-utils.c (default_gcc_target_options): Return std::string.
2721 * arch-utils.h (default_gcc_target_options): Return std::string.
2722 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2723
2724 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2725
2726 * breakpoint.c (breakpoint_chain): Make static.
2727 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2728 of accessing breakpoint_chain.
2729
2730 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2731
2732 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2733 to a gdb::function_view and return value to bool.
2734 * breakpoint.h (iterate_over_breakpoints): Likewise.
2735 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2736 (pop_dummy_frame): Update.
2737 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2738 (gdbscm_breakpoints): Update.
2739 * python/py-breakpoint.c (build_bp_list): Update.
2740 (gdbpy_breakpoints): Update.
2741 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2742 Update.
2743 (bpfinishpy_handle_stop): Update.
2744 (bpfinishpy_handle_exit): Update.
2745 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2746 (svr4_update_solib_event_breakpoints): Update.
2747
2748 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2749
2750 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2751 when unwrapping single-field structs.
2752
2753 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2754
2755 * dwarf2read.c: Remove includes.
2756
2757 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2758
2759 * ui-out.c (ui_out::call_do_message): Silence
2760 -Wformat-nonliteral warning.
2761
2762 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2763
2764 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2765 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2766 include: readline/tilde.h.
2767
2768 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2769
2770 * remote.c (remote_target::get_trace_status): Remove declaration of
2771 trace_regblock_size.
2772
2773 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2774
2775 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2776 (show_user): Remove declaration of cmdlist.
2777 * cli/cli-cmds.h (max_user_call_depth): Declare.
2778 * cli/cli-script.c (execute_user_command): Remove declaration
2779 of max_user_call_depth.
2780
2781 2019-10-11 Jim Wilson <jimw@sifive.com>
2782
2783 * gdbsupport/print-utils.h (pulongest): Fix comment.
2784 (plongest): Likewise.
2785 (phex): Add missing comment, mention leading zeros.
2786 (phex_nz): Add mention of no leading zeros to comment.
2787
2788 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2789 plongest instead of unsigned long long cast.
2790
2791 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2792
2793 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2794 for external_editor_command and gdbtk_test.
2795
2796 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2797
2798 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2799 * varobj.c (varobjdebug): Move comment to...
2800 * varobj.h (varobjdebug): ...here, and declare.
2801
2802 2019-10-09 Tom Tromey <tom@tromey.com>
2803
2804 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2805 erase_data_content.
2806
2807 2019-10-09 Tom Tromey <tom@tromey.com>
2808
2809 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2810 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2811 * tui/tui-command.c (tui_cmd_window::resize)
2812 (tui_refresh_cmd_win): Update.
2813 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2814 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2815 * tui/tui-data.c (~tui_gen_win_info): Remove.
2816 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2817 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2818 (tui_redisplay_readline, tui_mld_flush)
2819 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2820 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2821 (tui_data_window::erase_data_content)
2822 (tui_data_item_window::rerender)
2823 (tui_data_item_window::refresh_window): Update.
2824 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2825 (box_win, tui_gen_win_info::make_window)
2826 (tui_gen_win_info::make_visible): Update.
2827 (tui_delete_win): Remove.
2828 * tui/tui-winsource.c
2829 (tui_source_window_base::do_erase_source_content): Update.
2830 (tui_show_source_line, tui_source_window_base::update_tab_width)
2831 (tui_source_window_base::update_exec_info): Update.
2832 * tui/tui-data.h (struct curses_deleter): New.
2833 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2834 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2835
2836 2019-10-09 Tom Tromey <tom@tromey.com>
2837
2838 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2839
2840 2019-10-09 Tom Tromey <tom@tromey.com>
2841
2842 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2843 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2844
2845 2019-10-09 Tom Tromey <tom@tromey.com>
2846
2847 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2848 window height directly.
2849 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2850 declare.
2851 * tui/tui-layout.c (tui_default_win_height): Remove.
2852 (tui_default_win_viewport_height): Remove.
2853
2854 2019-10-09 Tom Tromey <tom@tromey.com>
2855
2856 * tui/tui.h: Remove comments.
2857
2858 2019-10-09 Tom de Vries <tdevries@suse.de>
2859
2860 * python/lib/gdb/printer/bound_registers.py: Use
2861 '^builtin_type_bound128' as regexp argument for
2862 add_builtin_pretty_printer.
2863
2864 2019-10-09 Christian Biesinger <cbiesinger@google.com>
2865
2866 * guile/guile.c (guile_extension_script_ops): Remove forward
2867 declaration and mark as static.
2868 (guile_script_ops): Likewise.
2869 (extension_language_guile): Move further down in the file so
2870 it can reference the definitions for guile_{extension_,}script_ops.
2871
2872 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2873
2874 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2875 except SORTL, DFLTCC, and KDSA.
2876
2877 2019-10-08 Tom Tromey <tromey@adacore.com>
2878
2879 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2880 (struct safe_symbol_file_add_args): Remove.
2881
2882 2019-10-08 Tom Tromey <tromey@adacore.com>
2883
2884 * windows-nat.c: Don't include buildsym-legacy.h.
2885
2886 2019-10-08 Tom Tromey <tromey@adacore.com>
2887
2888 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2889
2890 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2891
2892 * gdbtypes.c (overload_debug): Move comment to header.
2893 * gdbtypes.h (overload_debug): Declare.
2894 * valops.c: Remove declaration of overload_debug, instead
2895 include gdbtypes.h.
2896
2897 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2898
2899 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2900 through _().
2901 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2902 move comment...
2903 * language.h (lang_frame_mismatch_warn): ... here. Also add
2904 declaration.
2905 * top.c (lang_frame_mismatch_warn): Remove declaration.
2906 (check_frame_language_change): Pass lang_frame_mismatch_warn
2907 through _().
2908
2909 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2910
2911 * c-lang.h (vtbl_ptr_name): Declare.
2912 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2913 it from the header.
2914 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2915
2916 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2917
2918 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2919 gdb_static_assert.
2920
2921 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2922
2923 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2924 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2925 * ctfread.c: New file.
2926 * ctfread.h: New file.
2927 * elfread.c: Include ctfread.h.
2928 (struct elfinfo text_p): New member ctfsect.
2929 (elf_locate_sections): Mark CTF section.
2930 (elf_symfile_read): Call elfctf_build_psymtabs.
2931 * Makefile.in (LIBCTF): Add.
2932 (CLIBS): Use it.
2933 (CDEPS): Likewise.
2934 (DIST): Add ctfread.c.
2935
2936 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2937
2938 * ctfread.c (struct nextfield): Renamed to ...
2939 (struct ctf_nextfield): ... this.
2940 (struct field_info): Renamed to ...
2941 (strut ctf_field_info): ... this.
2942 (attach_fields_to_type): Update for renamed structures.
2943 (ctf_add_member_cb): Likewise.
2944 (ctf_add_enum_member_cb): Likewise.
2945 (process_struct_members): Likewise.
2946 (process_enum_type): Likewise.
2947
2948 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2949
2950 * tracectf.h: Rename, was ctf.h.
2951 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2952 * tracefile.c: Likewise.
2953 * tracepoint.c: Remove unused include ctf.h.
2954 * mi/mi-main.c: Likewise.
2955 * Makefile.in Replace ctf.c with tracectf.c.
2956
2957 2019-10-06 Joel Brobecker <brobecker@adacore.com>
2958
2959 * version.in: Change version number to "9.0.50.DATE-git".
2960
2961 2019-10-03 Tom Tromey <tom@tromey.com>
2962
2963 PR rust/24976:
2964 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2965
2966 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2967
2968 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2969 cp_search_name_hash.
2970 * NEWS: Add entry about nested function support.
2971
2972 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
2973 Andrew Burgess <andrew.burgess@embecosm.com>
2974
2975 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2976 for nested static variables when searchin VAR_DOMAIN.
2977 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2978 global scope, update comment.
2979 (add_partial_subprogram): Call add_partial_subprogram recursively
2980 for nested subroutines when processinng Fortran.
2981 (load_partial_dies): Process the child entities of a subprogram
2982 when processing Fortran.
2983 (partial_die_parent_scope): Handle building scope
2984 for Fortran nested functions.
2985 (process_die): Record that nested functions have a scope.
2986 (new_symbol): Always record Fortran subprograms on the global
2987 symbol list.
2988 (determine_prefix): How to build the prefix for Fortran
2989 subprograms.
2990
2991 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2992
2993 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2994 have just sent the thread a SIGSTOP and are waiting for it to
2995 arrive.
2996
2997 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2998
2999 * btrace.c (btrace_add_pc): Remove whitespace before the template
3000 parameter in 'std::vector <...>'.
3001 (parse_xml_btrace_block): Likewise.
3002 (btrace_maint_decode_pt): Likewise.
3003 (btrace_maint_update_packets): Likewise.
3004 (btrace_maint_print_packets): Likewise.
3005 * btrace.h (struct btrace_maint_info): Likewise.
3006 * dwarf2read.c (struct type_unit_group): Likewise.
3007 (build_type_psymtabs_reader): Likewise.
3008 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3009 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3010 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3011
3012 2019-10-03 Tom de Vries <tdevries@suse.de>
3013
3014 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3015 the first line of the help text for set/show style metadata.
3016
3017 2019-10-02 Tom Tromey <tromey@adacore.com>
3018
3019 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3020 * gdbsupport/common-inferior.c: New file.
3021 * infcmd.c (startup_with_shell): Don't define.
3022 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3023 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3024 * inferior.h (startup_with_shell): Don't declare.
3025
3026 2019-10-02 Christian Biesinger <cbiesinger@google.com>
3027
3028 * gdbsupport/gdb_assert.h: Include errors.h.
3029 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3030
3031 2019-10-02 Tom Tromey <tromey@adacore.com>
3032
3033 * NEWS: Add $_ada_exception entry.
3034 * ada-lang.c (struct ada_catchpoint): Add constructor.
3035 <m_kind>: New member.
3036 (allocate_location_exception, re_set_exception): Remove
3037 "ex" parameter.
3038 (should_stop_exception): Compute $_ada_exception.
3039 (check_status_exception, print_it_exception)
3040 (print_one_exception, print_mention_exception): Remove
3041 "ex" parameter.
3042 (allocate_location_catch_exception, re_set_catch_exception)
3043 (check_status_exception, print_it_catch_exception)
3044 (print_one_catch_exception, print_mention_catch_exception)
3045 (print_recreate_catch_exception)
3046 (allocate_location_catch_exception_unhandled)
3047 (re_set_catch_exception_unhandled)
3048 (check_status_exception, print_it_catch_exception_unhandled)
3049 (print_one_catch_exception_unhandled)
3050 (print_mention_catch_exception_unhandled)
3051 (print_recreate_catch_exception_unhandled)
3052 (allocate_location_catch_assert, re_set_catch_assert)
3053 (check_status_assert, print_it_catch_assert)
3054 (print_one_catch_assert, print_mention_catch_assert)
3055 (print_recreate_catch_assert)
3056 (allocate_location_catch_handlers, re_set_catch_handlers)
3057 (check_status_handlers, print_it_catch_handlers)
3058 (print_one_catch_handlers, print_mention_catch_handlers)
3059 (print_recreate_catch_handlers): Remove.
3060 (create_ada_exception_catchpoint): Update.
3061 (initialize_ada_catchpoint_ops): Update.
3062
3063 2019-10-02 Tom Tromey <tromey@adacore.com>
3064
3065 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3066 (create_excep_cond_exprs): Simplify exception string computation.
3067 (ada_exception_catchpoint_cond_string): Likewise.
3068
3069 2019-10-02 Tom Tromey <tromey@adacore.com>
3070
3071 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3072 * ada-lang.c (lesseq_defined_than): Handle
3073 LOC_STATIC.
3074 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3075 parameter.
3076 (dwarf2_has_info): Likewise.
3077 (new_symbol): Set maybe_copied on symbol when
3078 appropriate.
3079 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3080 parameter.
3081 <can_copy>: New member.
3082 * elfread.c (record_minimal_symbol): Set maybe_copied
3083 on symbol when appropriate.
3084 (elf_symfile_read): Update call to dwarf2_has_info.
3085 * minsyms.c (lookup_minimal_symbol_linkage): New
3086 function.
3087 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3088 * symtab.c (get_symbol_address, get_msymbol_address):
3089 New functions.
3090 * symtab.h (get_symbol_address, get_msymbol_address):
3091 Declare.
3092 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3093 maybe_copied.
3094 (struct symbol, struct minimal_symbol) <maybe_copied>:
3095 New member.
3096
3097 2019-10-02 Tom Tromey <tromey@adacore.com>
3098
3099 * source.c (struct current_source_location): New.
3100 (current_source_key): New global.
3101 (current_source_symtab, current_source_line)
3102 (current_source_pspace): Remove.
3103 (get_source_location): New function.
3104 (get_current_source_symtab_and_line)
3105 (set_default_source_symtab_and_line)
3106 (set_current_source_symtab_and_line)
3107 (clear_current_source_symtab_and_line, select_source_symtab)
3108 (info_source_command, print_source_lines_base)
3109 (info_line_command, search_command_helper, _initialize_source):
3110 Update.
3111
3112 2019-10-02 Tom Tromey <tromey@adacore.com>
3113
3114 * source.c (select_source_symtab): Don't call
3115 decode_line_with_current_source.
3116
3117 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3118
3119 * symtab.c (lookup_global_symbol): Search global block.
3120
3121 2019-10-02 Tom Tromey <tromey@adacore.com>
3122
3123 * coffread.c (process_coff_symbol): Update.
3124 * dwarf2read.c (var_decode_location, new_symbol): Update.
3125 * mdebugread.c (parse_symbol): Update.
3126 * objfiles.c (relocate_one_symbol): Update.
3127 * stabsread.c (define_symbol, fix_common_block)
3128 (scan_file_globals): Update.
3129 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3130 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3131 * xcoffread.c (process_xcoff_symbol): Update.
3132
3133 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3134
3135 * MAINTAINERS: Update my email address.
3136
3137 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3138
3139 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3140 std::vector.
3141 (build_type_psymtabs_reader): Update for std::vector.
3142 (build_type_psymtab_dependencies): Likewise.
3143 * dwarf2read.h: Remove use of DEF_VEC_P.
3144 (typedef sig_type_ptr): Delete.
3145
3146 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3147
3148 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3149 to std::vector.
3150 (btrace_maint_decode_pt): Likewise, and move allocation of the
3151 vector outside of the loop.
3152 (btrace_maint_update_packets): Update to handle change from VEC to
3153 std::vector.
3154 (btrace_maint_print_packets): Likewise.
3155 (maint_info_btrace_cmd): Likewise.
3156 * btrace.h: Remove use of DEF_VEC_O.
3157 (typedef btrace_pt_packet_s): Delete.
3158 (struct btrace_maint_info) <packets>: Change fromm VEC to
3159 std::vector.
3160 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3161
3162 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3163
3164 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3165 make accesses into the vector constant references.
3166 (btrace_add_pc): Update for std::vector.
3167 (btrace_stitch_bts): Likewise.
3168 (parse_xml_btrace_block): Likewise.
3169 (btrace_maint_update_packets): Likewise.
3170 (btrace_maint_print_packets): Likewise.
3171 (maint_info_btrace_cmd): Likewise.
3172 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3173 std::vector.
3174 (btrace_data::empty): Likewise.
3175 (btrace_data_append): Likewise.
3176 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3177 (typedef btrace_block_s): Delete.
3178 (struct btrace_block): Add constructor.
3179 (struct btrace_data_bts) <blocks>: Change to std::vector.
3180 * nat/linux-btrace.c (perf_event_read_bts): Update for
3181 std::vector.
3182 (linux_read_bts): Likewise.
3183
3184 2019-10-01 Tom Tromey <tom@tromey.com>
3185
3186 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3187
3188 2019-10-01 Tom Tromey <tom@tromey.com>
3189
3190 * stack.c (print_frame, info_frame_command_core): Use
3191 styled_string.
3192 * linux-thread-db.c (try_thread_db_load_1)
3193 (try_thread_db_load_from_pdir_1): Use styled_string.
3194 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3195 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3196 (maybe_print_unsupported_script_warning)
3197 (maybe_print_script_not_found_warning): Use styled_string.
3198 * ada-lang.c (user_select_syms): Use styled_string.
3199
3200 2019-10-01 Tom Tromey <tom@tromey.com>
3201
3202 * p-lang.c (pascal_printstr): Use metadata style.
3203 * value.c (show_convenience): Use metadata style.
3204 * valprint.c (valprint_check_validity, val_print_optimized_out)
3205 (val_print_not_saved, val_print_unavailable)
3206 (val_print_invalid_address, generic_val_print, val_print)
3207 (value_check_printable, val_print_array_elements): Use metadata
3208 style.
3209 * ui-out.h (class ui_out) <field_fmt>: New overload.
3210 <do_field_fmt>: Add style parameter.
3211 * ui-out.c (ui_out::field_fmt): New overload.
3212 * typeprint.c (type_print_unknown_return_type)
3213 (val_print_not_allocated, val_print_not_associated): Use metadata
3214 style.
3215 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3216 parameter.
3217 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3218 * tracepoint.c (tvariables_info_1): Use metadata style.
3219 * stack.c (print_frame_arg, print_frame_info, print_frame)
3220 (info_frame_command_core): Use metadata style.
3221 * skip.c (info_skip_command): Use metadata style.
3222 * rust-lang.c (rust_print_enum): Use metadata style.
3223 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3224 metadata style.
3225 * python/py-framefilter.c (py_print_single_arg): Use metadata
3226 style.
3227 * printcmd.c (do_one_display, print_variable_and_value): Use
3228 metadata style.
3229 * p-valprint.c (pascal_val_print)
3230 (pascal_object_print_value_fields): Use metadata style.
3231 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3232 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3233 parameter.
3234 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3235 * m2-valprint.c (m2_print_long_set): Use metadata style.
3236 * m2-typeprint.c (m2_print_type): Use metadata style.
3237 * infcmd.c (print_return_value_1): Use metadata style.
3238 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3239 * f-valprint.c (info_common_command_for_block): Use metadata
3240 style.
3241 * f-typeprint.c (f_type_print_base): Use metadata style.
3242 * expprint.c (print_subexp_standard): Use metadata style.
3243 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3244 * cli/cli-style.h (class cli_style_option): Add constructor.
3245 (metadata_style): Declare.
3246 * cli/cli-style.c (metadata_style): New global.
3247 (_initialize_cli_style): Register metadata style.
3248 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3249 parameter.
3250 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3251 * c-typeprint.c (c_type_print_base_struct_union)
3252 (c_type_print_base_1): Use metadata style.
3253 * breakpoint.c (watchpoint_value_print)
3254 (print_one_breakpoint_location): Use metadata style.
3255 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3256 style.
3257 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3258 style.
3259 * ada-valprint.c (val_print_packed_array_elements, printstr)
3260 (print_field_values, ada_val_print_ref, ada_val_print): Use
3261 metadata style.
3262 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3263 style.
3264 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3265 style.
3266 * ada-lang.c (user_select_syms): Use metadata style.
3267
3268 2019-10-01 Tom Tromey <tom@tromey.com>
3269
3270 * cli/cli-cmds.c (pwd_command): Style output.
3271
3272 2019-10-01 Pedro Alves <palves@redhat.com>
3273 Tom Tromey <tom@tromey.com>
3274
3275 * symtab.c (print_symbol_info): Use %ps.
3276 (print_msymbol_info): Use %ps.
3277 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3278 * printcmd.c (print_variable_and_value): Use %ps.
3279 * macrocmd.c (show_pp_source_pos): Use %ps.
3280 * infrun.c (print_exited_reason): Use ui_out::message.
3281 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3282 (describe_other_breakpoints): Use ui_out::message and new
3283 formats.
3284 (say_where): Use new formats.
3285 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3286 and new formats.
3287
3288 2019-10-01 Pedro Alves <palves@redhat.com>
3289 Tom Tromey <tom@tromey.com>
3290
3291 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3292 (test_gdb_formats): New function.
3293 (run_tests): Call it.
3294 (test_format_specifier): Update.
3295 * utils.h (fputs_filtered): Update comment.
3296 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3297 (fputs_styled_unfiltered): Declare.
3298 * utils.c (fputs_styled_unfiltered): New function.
3299 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3300 (vfprintf_filtered): Update.
3301 (vfprintf_unfiltered, vprintf_filtered): Update.
3302 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3303 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3304 disallow_ui_out_field>: New constants.
3305 (enum class field_kind): New.
3306 (struct base_field_s, struct signed_field_s): New.
3307 (signed_field): New function.
3308 (struct string_field_s): New.
3309 (string_field): New function.
3310 (struct styled_string_s): New.
3311 (styled_string): New function.
3312 (class ui_out) <message>: Add comment.
3313 <vmessage, call_do_message>: New methods.
3314 <do_message>: Add style parameter.
3315 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3316 methods.
3317 (ui_out::message): Rewrite.
3318 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3319 parameter.
3320 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3321 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3322 gdb_extensions parameter.
3323 (class format_piece): Add parameter to constructor.
3324 (n_int_args): New field.
3325 * gdbsupport/format.c (format_pieces::format_pieces): Add
3326 gdb_extensions parameter. Handle '*'.
3327 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3328 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3329 vfprintf_styled_no_gdbfmt.
3330 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3331 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3332 unfiltered output.
3333 * ui-style.h (struct ui_file_style) <ptr>: New method.
3334
3335 2019-10-01 Tom Tromey <tom@tromey.com>
3336
3337 * unittests/format_pieces-selftests.c: Update. Add final format.
3338 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3339 empty literal pieces.
3340
3341 2019-10-01 Tom Tromey <tom@tromey.com>
3342
3343 * ui-out.h (enum class ui_out_style_kind): Remove.
3344 (class ui_out) <field_string, field_stsream, do_field_string>:
3345 Change type of "style".
3346 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3347 (ui_out::field_string): Update.
3348 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3349 of "style".
3350 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3351 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3352 * stack.c (print_frame_arg, print_frame_info, print_frame):
3353 Update.
3354 * source.c (print_source_lines_base): Update.
3355 * solib.c (info_sharedlibrary_command): Update.
3356 * skip.c (info_skip_command): Update.
3357 * record-btrace.c (btrace_call_history_src_line)
3358 (btrace_call_history): Update.
3359 * python/py-framefilter.c (py_print_frame): Update.
3360 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3361 "style".
3362 * mi/mi-out.c (mi_ui_out::do_table_header)
3363 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3364 (mi_ui_out::do_field_string): Update.
3365 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3366 Update.
3367 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3368 "style".
3369 * cli-out.c (cli_ui_out::do_table_header)
3370 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3371 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3372 (cli_ui_out::do_field_fmt): Update.
3373 * breakpoint.c (print_breakpoint_location): Update.
3374 (update_static_tracepoint): Update.
3375
3376 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3377
3378 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3379 conversion of gdb_datadir.
3380 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3381 remove not needed c_str ().
3382
3383 2019-09-30 Ali Tamur <tamur@google.com>
3384
3385 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3386 (dwarf2_string_attr): Likewise.
3387
3388 2019-09-30 Ali Tamur <tamur@google.com>
3389
3390 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3391 (process_full_type_unit): Likewise.
3392 (dump_die_shallow): Likewise.
3393 (cu_debug_loc_section): Likewise.
3394
3395 2019-09-28 Christian Biesinger <cbiesinger@google.com>
3396
3397 * minsyms.c (compare_minimal_symbols): Rename to...
3398 (minimal_symbol_is_less_than): ...this, and adjust to STL
3399 conventions (return bool, take arguments as references)
3400 (minimal_symbol_reader::install): Call std::sort instead
3401 of qsort.
3402
3403 2019-09-29 Christian Biesinger <cbiesinger@google.com>
3404
3405 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3406 hash and why.
3407 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3408 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3409
3410 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3411
3412 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3413 * psympriv.h (add_psymbol_to_list): Move comment here and update
3414 it.
3415
3416 2019-09-29 Tom de Vries <tdevries@suse.de>
3417
3418 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3419 Use $tmpdir/$(basename "$output_file").dwz instead of
3420 "${output_file}.dwz".
3421
3422 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3423
3424 PR gdb/25045
3425 * hppa-linux-nat.c: Include gdbarch.h.
3426
3427 2019-09-26 Christian Biesinger <cbiesinger@google.com>
3428
3429 * blockframe.c (find_pc_partial_function): Change return type to bool.
3430 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3431 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3432 (stub_gnu_ifunc_resolve_name): Likewise.
3433 * symtab.c (compare_filenames_for_search): Likewise.
3434 (compare_glob_filenames_for_search): Likewise.
3435 (matching_obj_sections): Likewise.
3436 (symbol_matches_domain): Likewise.
3437 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3438 (find_line_pc): Change return type to bool.
3439 (find_line_pc_range): Likewise.
3440 (producer_is_realview): Likewise.
3441 * symtab.h (symbol_matches_domain): Likewise.
3442 (find_pc_partial_function): Likewise.
3443 (find_pc_line_pc_range): Likewise.
3444 (in_gnu_ifunc_stub): Likewise.
3445 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3446 (find_line_pc): Likewise.
3447 (find_line_pc_range): Likewise.
3448 (matching_obj_sections): Likewise.
3449 (find_line_symtab): Change out parameter to bool.
3450 (producer_is_realview): Change return type to bool.
3451 (compare_filenames_for_search): Likewise.
3452 (compare_glob_filenames_for_search): Likewise.
3453
3454 2019-09-26 Tom Tromey <tom@tromey.com>
3455
3456 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3457 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3458 * gdb_usleep.h: Remove.
3459 * gdb_usleep.c: Remove.
3460 * utils.c: Don't include gdb_usleep.h.
3461
3462 2019-09-26 Tom Tromey <tromey@adacore.com>
3463
3464 * python/py-type.c (type_to_type_object): Call check_typedef
3465 for stub types.
3466
3467 2019-09-26 Tom Tromey <tom@tromey.com>
3468
3469 * utils.h (initialize_utils): Don't declare.
3470 * top.c (gdb_init): Don't call initialize_utils.
3471 * utils.c (initialize_utils): Remove. Move contents...
3472 (_initialize_utils): ... here.
3473
3474 2019-09-25 Tom Tromey <tom@tromey.com>
3475
3476 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3477 * utils.h (make_hex_string): Don't declare.
3478 * utils.c (make_hex_string): Remove.
3479
3480 2019-09-24 Tom de Vries <tdevries@suse.de>
3481
3482 PR gdb/23815
3483 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3484 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3485
3486 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3487
3488 * NEWS: Mention new simulator port for PRU.
3489
3490 2019-09-23 Christian Biesinger <cbiesinger@google.com>
3491
3492 * ada-exp.y (write_object_remaining): Update.
3493 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3494 and eliminate the static buffer.
3495 (ada_decode_symbol): Update.
3496 (ada_la_decode): Update.
3497 (ada_sniff_from_mangled_name): Update.
3498 (is_valid_name_for_wild_match): Update.
3499 (ada_lookup_name_info::matches): Update and simplify.
3500 (name_matches_regex): Update.
3501 (ada_add_global_exceptions): Update.
3502 * ada-lang.h (ada_decode): Update signature.
3503 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3504 * dwarf-index-write.c (debug_names::insert): Update.
3505
3506 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3507
3508 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3509 formatting.
3510
3511 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3512
3513 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3514 Change "nonzero" to "true" in documentation.
3515
3516 2019-09-20 Christian Biesinger <cbiesinger@google.com>
3517
3518 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3519 (_initialize_darwin_solib): Don't set
3520 darwin_so_ops.lookup_lib_global_symbol.
3521 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3522 set_gdbarch_iterate_over_objfiles_in_search_order.
3523 (elf_lookup_lib_symbol): Rename to...
3524 (svr4_iterate_over_objfiles_in_search_order): this, and update
3525 to iterate semantics.
3526 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3527 * solib.c (solib_global_lookup): Remove.
3528 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3529 (solib_global_lookup): Remove.
3530 * symtab.c (lookup_global_or_static_symbol): Remove call to
3531 solib_global_lookup.
3532
3533 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3534
3535 * NEWS: Move entries about default MI version now being
3536 version 3, and about the GDB/MI fix for multi-location
3537 breakpoints to the "since GDB 8.3" section.
3538
3539 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3540
3541 GDB 8.3.1 released.
3542
3543 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3544
3545 * NEWS: Mention that Cell/B.E. debugging support was removed.
3546 * MAINTAINERS: Remove spu target.
3547
3548 * config/djgpp/fnchange.lst: Remove entries for removed files.
3549
3550 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3551 spu-multiarch.o, and spu-tdep.o.
3552 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3553 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3554 spu-multiarch.c, and spu-tdep.c.
3555 * spu-linux-nat.c: Remove file.
3556 * spu-multiarch.c: Remove file.
3557 * spu-tdep.c: Remove file.
3558 * spu-tdep.h: Remove file.
3559 * solib-spu.c: Remove file.
3560 * solib-spu.h: Remove file.
3561
3562 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3563 * configure.nat (spu-linux): Remove.
3564 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3565 solib-multiarch.o from gdb_target_obs.
3566 (spu*-*-*): Remove.
3567
3568 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3569 feature flag.
3570 (ppc_linux_no_features): Update.
3571 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3572 Cell/B.E. support.
3573 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3574 (tdesc_powerpc_cell64l): Likewise.
3575 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3576 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3577 Cell/B.E. support.
3578 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3579 Do not include "features/rs6000/powerpc-cell32l.c" or
3580 "features/rs6000/powerpc-cell64l.c".
3581 (ppc_linux_spu_section): Remove.
3582 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3583 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3584 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3585 (ppc_linux_spe_context_lookup): Remove.
3586 (ppc_linux_spe_context_inferior_created): Remove.
3587 (ppc_linux_spe_context_solib_loaded): Remove.
3588 (ppc_linux_spe_context_solib_unloaded): Remove.
3589 (ppc_linux_spe_context): Remove.
3590 (struct ppu2spu_cache): Remove.
3591 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3592 (struct ppu2spu_data): Remove.
3593 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3594 ppu2spu_unwind): Remove.
3595 (ppc_linux_init_abi): Remove Cell/B.E. support.
3596 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3597
3598 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3599 (rs6000/powerpc-cell64l-expedite): Likewise
3600 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3601 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3602 rs6000/powerpc-cell64l.xml.
3603 * features/rs6000/powerpc-cell32l.xml: Remove.
3604 * features/rs6000/powerpc-cell64l.xml: Likewise.
3605 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3606 * features/rs6000/powerpc-cell64l.c: Likewise.
3607 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3608 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3609 * regformats/reg-spu.dat: Remove.
3610
3611 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3612 * corelow.c (struct spuid_list): Remove.
3613 (add_to_spuid_list): Remove.
3614 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3615 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3616 (remote_protocol_features): Remove associated entries.
3617 (_initialize_remote): No longer initialize them.
3618 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3619 * linux-nat.c (SPUFS_MAGIC): Remove.
3620 (linux_proc_xfer_spu): Remove.
3621 (spu_enumerate_spu_ids): Remove.
3622 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3623 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3624 (linux_make_corefile_notes): No longer call it.
3625
3626 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3627 (cooked_write_test): Likewise.
3628
3629 2019-09-20 Tom Tromey <tom@tromey.com>
3630
3631 * NEWS: Mention case-sensitivity of TUI commands.
3632 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3633 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3634 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3635
3636 2019-09-20 Tom Tromey <tom@tromey.com>
3637
3638 * tui/tui-source.c (tui_source_window::set_contents): Use
3639 make_unique_xstrdup.
3640 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3641 make_unique_xstrdup.
3642
3643 2019-09-20 Tom Tromey <tom@tromey.com>
3644
3645 * tui/tui-data.c: Remove separator comments.
3646 * tui/tui-layout.c: Remove separator comments.
3647 * tui/tui-win.c: Remove separator comments.
3648 * tui/tui-wingeneral.c: Remove separator comments.
3649
3650 2019-09-20 Tom Tromey <tom@tromey.com>
3651
3652 * tui/tui.h (strcat_to_buf): Don't declare.
3653 * tui/tui.c (strcat_to_buf): Remove.
3654
3655 2019-09-20 Tom Tromey <tom@tromey.com>
3656
3657 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3658 from "fullname".
3659 * tui/tui-source.c (tui_source_window::set_contents)
3660 (tui_source_window::location_matches_p)
3661 (tui_source_window::maybe_update): Update.
3662
3663 2019-09-20 Tom Tromey <tom@tromey.com>
3664
3665 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3666 Update.
3667 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3668 prefix.
3669 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3670 (tui_data_window::line_from_reg_element_no)
3671 (tui_data_window::first_reg_element_no_inline)
3672 (tui_data_window::show_registers)
3673 (tui_data_window::show_register_group)
3674 (tui_data_window::display_registers_from)
3675 (tui_data_window::display_registers_from_line)
3676 (tui_data_window::first_data_item_displayed)
3677 (tui_data_window::delete_data_content_windows)
3678 (tui_data_window::erase_data_content)
3679 (tui_data_window::do_scroll_vertical)
3680 (tui_data_window::refresh_window)
3681 (tui_data_window::check_register_values): Update.
3682
3683 2019-09-20 Tom Tromey <tom@tromey.com>
3684
3685 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3686 (struct tui_locator_window) <full_name, proc_name>: Now
3687 std::string.
3688 * tui/tui-stack.c (tui_locator_window::make_status_line)
3689 (tui_locator_window::set_locator_fullname)
3690 (tui_locator_window::set_locator_info): Update.
3691 * tui/tui-source.c (tui_source_window::set_contents)
3692 (tui_source_window::showing_source_p): Update.
3693
3694 2019-09-20 Tom Tromey <tom@tromey.com>
3695
3696 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3697 Don't call tui_locator_win_info_ptr.
3698
3699 2019-09-20 Tom Tromey <tom@tromey.com>
3700
3701 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3702
3703 2019-09-20 Tom Tromey <tom@tromey.com>
3704
3705 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3706 height for locator.
3707 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3708 * tui/tui-layout.c (show_source_disasm_command, show_data)
3709 (show_source_or_disasm_and_command): Use 1 as height for locator.
3710
3711 2019-09-20 Tom Tromey <tom@tromey.com>
3712
3713 * tui/tui.c (tui_enable): Update.
3714 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3715 Update.
3716 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3717 Update.
3718 * tui/tui-data.c (win_resized): Now bool.
3719 (tui_win_resized): Return bool.
3720 (tui_set_win_resized_to): Accept a bool.
3721
3722 2019-09-20 Tom Tromey <tom@tromey.com>
3723
3724 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3725 Change type of "refresh_values_only".
3726 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3727 type of "refresh_values_only".
3728
3729 2019-09-20 Tom Tromey <tom@tromey.com>
3730
3731 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3732 std::string.
3733 (tui_disassemble): Add "pos" parameter.
3734 (tui_disasm_window::set_contents): Simplify.
3735
3736 2019-09-20 Tom Tromey <tom@tromey.com>
3737
3738 * tui/tui-winsource.h (struct tui_source_window_base)
3739 <show_source_content>: Now private.
3740 * tui/tui-winsource.c
3741 (tui_source_window_base::show_source_content): Don't handle empty
3742 content case.
3743
3744 2019-09-20 Tom Tromey <tom@tromey.com>
3745
3746 * tui/tui-layout.c (show_source_disasm_command)
3747 (show_source_or_disasm_and_command): Don't call
3748 show_source_content.
3749
3750 2019-09-20 Tom Tromey <tom@tromey.com>
3751
3752 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3753 Declare.
3754 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3755 from tui_make_status_line.
3756 (tui_locator_window::rerender): Update.
3757
3758 2019-09-20 Tom Tromey <tom@tromey.com>
3759
3760 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3761 (tui_locator_window::rerender): Update.
3762
3763 2019-09-20 Tom Tromey <tom@tromey.com>
3764
3765 * tui/tui-winsource.h (struct tui_source_window_base)
3766 <~tui_source_window_base>: Don't declare.
3767 <fullname>: Remove.
3768 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3769 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3770 member.
3771 * tui/tui-source.c (tui_source_window::set_contents): Update.
3772 (tui_source_window::location_matches_p)
3773 (tui_source_window::maybe_update): Update.
3774
3775 2019-09-20 Tom Tromey <tom@tromey.com>
3776
3777 * tui/tui-winsource.h (~tui_source_element): Remove.
3778 (tui_source_element): Update.
3779 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3780 * tui/tui-winsource.c (tui_show_source_line): Update.
3781 * tui/tui-source.c (tui_source_window::set_contents): Update.
3782 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3783
3784 2019-09-20 Tom Tromey <tom@tromey.com>
3785
3786 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3787 declare.
3788 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3789 tui_clear_source_windows_detail.
3790 * tui/tui-winsource.h (struct tui_source_window_base)
3791 <clear_detail>: Don't declare.
3792 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3793 Remove.
3794 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3795
3796 2019-09-20 Tom Tromey <tromey@adacore.com>
3797
3798 PR ada/24919:
3799 * block.c (contained_in): Fix final return value.
3800
3801 2019-09-20 Alan Modra <amodra@gmail.com>
3802
3803 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3804 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3805 (read_indirect_string_from_dwz): Use bfd accessor.
3806 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3807 * machoread.c (macho_symfile_read_all_oso): Likewise.
3808 * solib.c (solib_bfd_open): Likewise.
3809
3810 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3811
3812 * eval.c: Move declaration of overload_resolution to...
3813 * value.h: ...here.
3814
3815 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3816
3817 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3818 * arm-linux-tdep.c: Likewise.
3819 * arm-nbsd-nat.c: Likewise.
3820 * arm-tdep.h: Declare arm_apcs_32.
3821 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3822
3823 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3824
3825 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3826 * dwarf2read.h: Declare dwarf_always_disassemble.
3827
3828 2019-09-19 Tom de Vries <tdevries@suse.de>
3829
3830 PR gdb/25009
3831 * source-cache.c (source_cache::ensure): Catch exception thrown during
3832 construction of the highlighter.
3833
3834 2019-09-18 Alan Modra <amodra@gmail.com>
3835
3836 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3837 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3838 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3839 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3840 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3841 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3842 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3843 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3844 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3845 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3846 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3847 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3848 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3849 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3850 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3851 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3852 * mi/mi-interp.c: Update throughout for bfd section macro and
3853 function changes.
3854 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3855 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3856
3857 2019-09-18 Tom Tromey <tom@tromey.com>
3858
3859 * NEWS: Add entry.
3860 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3861 call rl_initialize.
3862 (tui_enable): Do not call rl_initialize.
3863
3864 2019-09-18 Christian Groessler <chris@groessler.org>
3865
3866 * alpha-linux-nat.c: Include gdbarch.h.
3867
3868 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3869
3870 * ui-file.c: Include cli/cli-style.h.
3871 (term_cli_styling): Remove cli_styling declaration.
3872
3873 2019-09-18 Alan Modra <amodra@gmail.com>
3874
3875 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3876 to bfd_asymbol_section.
3877
3878 2019-09-18 Alan Modra <amodra@gmail.com>
3879
3880 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3881 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3882 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3883
3884 2019-09-18 Alan Modra <amodra@gmail.com>
3885
3886 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3887 * spu-linux-nat.c (spu_bfd_open): Likewise.
3888
3889 2019-09-18 Christian Biesinger <cbiesinger@google.com>
3890
3891 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3892 to bool to match definition in dwarf2read.c.
3893
3894 2019-09-17 Christian Biesinger <cbiesinger@google.com>
3895
3896 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3897 (print_signatures): Likewise.
3898 (trust_pad_over_xvs): Likewise.
3899 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3900 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3901 * arm-linux-nat.c (arm_apcs_32): Likewise.
3902 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3903 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3904 * arm-tdep.c (arm_debug): Likewise.
3905 (arm_apcs_32): Likewise.
3906 * auto-load.c (debug_auto_load): Likewise.
3907 (auto_load_gdb_scripts): Likewise.
3908 (global_auto_load): Likewise.
3909 (auto_load_local_gdbinit): Likewise.
3910 (auto_load_local_gdbinit_loaded): Likewise.
3911 * auto-load.h (global_auto_load): Likewise.
3912 (auto_load_local_gdbinit): Likewise.
3913 (auto_load_local_gdbinit_loaded): Likewise.
3914 * breakpoint.c (disconnected_dprintf): Likewise.
3915 (breakpoint_proceeded): Likewise.
3916 (automatic_hardware_breakpoints): Likewise.
3917 (always_inserted_mode): Likewise.
3918 (target_exact_watchpoints): Likewise.
3919 (_initialize_breakpoint): Update.
3920 * breakpoint.h (target_exact_watchpoints): Change to bool.
3921 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3922 * cli/cli-cmds.c (trace_commands): Likewise.
3923 * cli/cli-cmds.h (trace_commands): Likewise.
3924 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3925 to bool*.
3926 * cli/cli-logging.c (logging_overwrite): Change to bool.
3927 (logging_redirect): Likewise.
3928 (debug_redirect): Likewise.
3929 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3930 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3931 to bool.
3932 <boolean_option_def>: Update.
3933 (struct flag_option_def): Change default type of Context to bool
3934 from int.
3935 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3936 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3937 (get_setshow_command_value_string): Likewise.
3938 * cli/cli-style.c (cli_styling): Change to bool.
3939 (source_styling): Likewise.
3940 * cli/cli-style.h (source_styling): Likewise.
3941 (cli_styling): Likewise.
3942 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3943 to bool.
3944 * command.h (var_types): Update comment.
3945 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3946 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3947 bool.
3948 (debug_compile_cplus_scopes): Likewise.
3949 * compile/compile-internal.h (compile_debug): Likewise.
3950 * compile/compile.c (compile_debug): Likewise.
3951 (struct compile_options) <raw>: Likewise.
3952 * cp-support.c (catch_demangler_crashes): Likewise.
3953 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3954 (usr_cmd_cris_dwarf2_cfi): Likewise.
3955 * csky-tdep.c (csky_debug): Likewise.
3956 * darwin-nat.c (enable_mach_exceptions): Likewise.
3957 * dcache.c (dcache_enabled_p): Likewise.
3958 * defs.h (info_verbose): Likewise.
3959 * demangle.c (demangle): Likewise.
3960 (asm_demangle): Likewise.
3961 * dwarf-index-cache.c (debug_index_cache): Likewise.
3962 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3963 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3964 * dwarf2read.c (check_physname): Likewise.
3965 (use_deprecated_index_sections): Likewise.
3966 (dwarf_always_disassemble): Likewise.
3967 * eval.c (overload_resolution): Likewise.
3968 * event-top.c (set_editing_cmd_var): Likewise.
3969 (exec_done_display_p): Likewise.
3970 * event-top.h (set_editing_cmd_var): Likewise.
3971 (exec_done_display_p): Likewise.
3972 * exec.c (write_files): Likewise.
3973 * fbsd-nat.c (debug_fbsd_lwp): Likewise
3974 (debug_fbsd_nat): Likewise.
3975 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3976 Likewise.
3977 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3978 <backtrace_past_entry> Likewise.
3979 * gdb-demangle.h (demangle): Likewise.
3980 (asm_demangle): Likewise.
3981 * gdb_bfd.c (bfd_sharing): Likewise.
3982 * gdbcore.h (write_files): Likewise.
3983 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3984 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3985 * gdbthread.h (print_thread_events): Likewise.
3986 * gdbtypes.c (opaque_type_resolution): Likewise.
3987 (strict_type_checking): Likewise.
3988 * gnu-nat.c (gnu_debug_flag): Likewise.
3989 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3990 * guile/scm-param.c (pascm_variable): Add boolval.
3991 (add_setshow_generic): Update.
3992 (pascm_param_value): Update.
3993 (pascm_set_param_value_x): Update.
3994 * hppa-tdep.c (hppa_debug): Change to bool..
3995 * infcall.c (may_call_functions_p): Likewise.
3996 (coerce_float_to_double_p): Likewise.
3997 (unwind_on_signal_p): Likewise.
3998 (unwind_on_terminating_exception_p): Likewise.
3999 * infcmd.c (startup_with_shell): Likewise.
4000 * inferior.c (print_inferior_events): Likewise.
4001 * inferior.h (startup_with_shell): Likewise.
4002 (print_inferior_events): Likewise.
4003 * infrun.c (step_stop_if_no_debug): Likewise.
4004 (detach_fork): Likewise.
4005 (debug_displaced): Likewise.
4006 (disable_randomization): Likewise.
4007 (non_stop): Likewise.
4008 (non_stop_1): Likewise.
4009 (observer_mode): Likewise.
4010 (observer_mode_1): Likewise.
4011 (set_observer_mode): Update.
4012 (sched_multi): Change to bool.
4013 * infrun.h (debug_displaced): Likewise.
4014 (sched_multi): Likewise.
4015 (step_stop_if_no_debug): Likewise.
4016 (non_stop): Likewise.
4017 (disable_randomization): Likewise.
4018 * linux-tdep.c (use_coredump_filter): Likewise.
4019 (dump_excluded_mappings): Likewise.
4020 * linux-thread-db.c (auto_load_thread_db): Likewise.
4021 (check_thread_db_on_load): Likewise.
4022 * main.c (captured_main_1): Update.
4023 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4024 xx2_opt, boolean_opt>: Change to bool.
4025 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4026 * maint.c (maintenance_profile_p): Likewise.
4027 (per_command_time): Likewise.
4028 (per_command_space): Likewise.
4029 (per_command_symtab): Likewise.
4030 * memattr.c (inaccessible_by_default): Likewise.
4031 * mi/mi-main.c (mi_async): Likewise.
4032 (mi_async_1): Likewise.
4033 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4034 * nat/fork-inferior.h (startup_with_shell): Likewise.
4035 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4036 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4037 * nios2-tdep.c (nios2_debug): Likewise.
4038 * or1k-tdep.c (or1k_debug): Likewise.
4039 * parse.c (parser_debug): Likewise.
4040 * parser-defs.h (parser_debug): Likewise.
4041 * printcmd.c (print_symbol_filename): Likewise.
4042 * proc-api.c (procfs_trace): Likewise.
4043 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4044 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4045 (set_parameter_value): Update.
4046 (add_setshow_generic): Update.
4047 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4048 to bool*.
4049 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4050 int*.
4051 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4052 * record-btrace.c (record_btrace_target::store_registers): Update.
4053 * record-full.c (record_full_memory_query): Change to bool.
4054 (record_full_stop_at_limit): Likewise.
4055 * record-full.h (record_full_memory_query): Likewise.
4056 * remote-notif.c (notif_debug): Likewise.
4057 * remote-notif.h (notif_debug): Likewise.
4058 * remote.c (use_range_stepping): Likewise.
4059 (interrupt_on_connect): Likewise.
4060 (remote_break): Likewise.
4061 * ser-tcp.c (tcp_auto_retry): Likewise.
4062 * ser-unix.c (serial_hwflow): Likewise.
4063 * skip.c (debug_skip): Likewise.
4064 * solib-aix.c (solib_aix_debug): Likewise.
4065 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4066 (spu_auto_flush_cache_p): Likewise.
4067 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4068 Likewise.
4069 (struct info_print_options) <quiet>: Likewise.
4070 * symfile-debug.c (debug_symfile): Likewise.
4071 * symfile.c (auto_solib_add): Likewise.
4072 (separate_debug_file_debug): Likewise.
4073 * symfile.h (auto_solib_add): Likewise.
4074 (separate_debug_file_debug): Likewise.
4075 * symtab.c (basenames_may_differ): Likewise.
4076 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4077 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4078 (struct info_types_options) <quiet>: Likewise.
4079 * symtab.h (demangle): Likewise.
4080 (basenames_may_differ): Likewise.
4081 * target-dcache.c (stack_cache_enabled_1): Likewise.
4082 (code_cache_enabled_1): Likewise.
4083 * target.c (trust_readonly): Likewise.
4084 (may_write_registers): Likewise.
4085 (may_write_memory): Likewise.
4086 (may_insert_breakpoints): Likewise.
4087 (may_insert_tracepoints): Likewise.
4088 (may_insert_fast_tracepoints): Likewise.
4089 (may_stop): Likewise.
4090 (auto_connect_native_target): Likewise.
4091 (target_stop_and_wait): Update.
4092 (target_async_permitted): Change to bool.
4093 (target_async_permitted_1): Likewise.
4094 (may_write_registers_1): Likewise.
4095 (may_write_memory_1): Likewise.
4096 (may_insert_breakpoints_1): Likewise.
4097 (may_insert_tracepoints_1): Likewise.
4098 (may_insert_fast_tracepoints_1): Likewise.
4099 (may_stop_1): Likewise.
4100 * target.h (target_async_permitted): Likewise.
4101 (may_write_registers): Likewise.
4102 (may_write_memory): Likewise.
4103 (may_insert_breakpoints): Likewise.
4104 (may_insert_tracepoints): Likewise.
4105 (may_insert_fast_tracepoints): Likewise.
4106 (may_stop): Likewise.
4107 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4108 (make_thread_apply_all_options_def_group): Change argument from int*
4109 to bool*.
4110 (thread_apply_all_command): Update.
4111 (print_thread_events): Change to bool.
4112 * top.c (confirm): Likewise.
4113 (command_editing_p): Likewise.
4114 (history_expansion_p): Likewise.
4115 (write_history_p): Likewise.
4116 (info_verbose): Likewise.
4117 * top.h (confirm): Likewise.
4118 (history_expansion_p): Likewise.
4119 * tracepoint.c (disconnected_tracing): Likewise.
4120 (circular_trace_buffer): Likewise.
4121 * typeprint.c (print_methods): Likewise.
4122 (print_typedefs): Likewise.
4123 * utils.c (debug_timestamp): Likewise.
4124 (sevenbit_strings): Likewise.
4125 (pagination_enabled): Likewise.
4126 * utils.h (sevenbit_strings): Likewise.
4127 (pagination_enabled): Likewise.
4128 * valops.c (overload_resolution): Likewise.
4129 * valprint.h (struct value_print_options) <prettyformat_arrays,
4130 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4131 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4132 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4133 Likewise.
4134 * windows-nat.c (new_console): Likewise.
4135 (cygwin_exceptions): Likewise.
4136 (new_group): Likewise.
4137 (debug_exec): Likewise.
4138 (debug_events): Likewise.
4139 (debug_memory): Likewise.
4140 (debug_exceptions): Likewise.
4141 (useshell): Likewise.
4142 * windows-tdep.c (maint_display_all_tib): Likewise.
4143 * xml-support.c (debug_xml): Likewise.
4144
4145 2019-09-17 Mike Gulick <mgulick@mathworks.com>
4146
4147 * source.c (prepare_path_for_appending): New function.
4148 (openp): Make use of new function.
4149 (find_and_open_source): Search for the compilation directory and
4150 source file as a relative path beneath the directory search path.
4151
4152 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4153
4154 * source-cache.c (source_cache::get_line_charpos): Catch
4155 exceptions and return false, this matches the behaviour documented
4156 in the header file.
4157
4158 2019-09-17 Joel Brobecker <brobecker@adacore.com>
4159
4160 * ada-tasks.c (info_task): Remove quoting of the task's name.
4161
4162 2019-09-16 Christian Biesinger <cbiesinger@google.com>
4163
4164 * symfile.c (auto_solib_add): Replace comment with a reference
4165 to the header file.
4166
4167 2019-09-14 Christian Biesinger <cbiesinger@google.com>
4168
4169 * NEWS: Mention that gdb can now be compiled with Python 3
4170 on Windows.
4171
4172 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4173
4174 * maint.c (maint_print_section_data::maint_print_section_data):
4175 Force use of 'float log10 (float)' by casting the argument to
4176 float.
4177
4178 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4179
4180 * maint.c: Add 'cmath' include.
4181 (struct maint_print_section_data): New structure.
4182 (print_section_index): New function.
4183 (print_bfd_section_info): Add header comment, small whitespace
4184 cleanup, and update to call new print_section_index function.
4185 (print_objfile_section_info): Likewise.
4186 (maint_obj_section_from_bfd_section): New function.
4187 (print_bfd_section_info_maybe_relocated): New function.
4188 (maintenance_info_sections): Add header comment, always use
4189 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4190
4191 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4192
4193 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4194 inner scope, add check that the objfile has psymtabs before
4195 checking psymtabs_addrmap.
4196 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4197
4198 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4199
4200 * NEWS: Announce that Ada task names are now shown at more places,
4201 and between quotes (except in info task output).
4202 * gdb/ada-tasks.c (task_to_str): New function.
4203 (display_current_task_id): Call task_to_str.
4204 (task_command_1): Likewise.
4205 (print_ada_task_info): In non-mi mode, Properly align headers and data
4206 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4207
4208 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4209
4210 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4211 prstatus.pr_lwp.pr_info instead of making it up.
4212
4213 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4214
4215 * auto-load.c (auto_load_expand_dir_vars): Update.
4216 * defs.h (gdb_datadir): Change to std::string.
4217 (python_libdir): Likewise.
4218 (relocate_gdb_directory): Change return type to std::string.
4219 * guile/guile.c (gdbscm_data_directory): Update.
4220 (initialize_scheme_side): Update.
4221 * jit.c (jit_reader_dir): Change to std::string.
4222 (jit_reader_load_command): Update.
4223 * main.c (gdb_datadir): Change to std::string.
4224 (python_libdir): Likewise.
4225 (set_gdb_data_directory): Update.
4226 (relocate_path): Change to return std::string.
4227 (relocate_gdb_directory): Change to return std::string.
4228 (relocate_gdbinit_path_maybe_in_datadir): Update.
4229 (captured_main_1): Update.
4230 * python/python.c (do_start_initialization): Update.
4231 * top.c (show_gdb_datadir): Update.
4232 * xml-syscall.c (xml_init_syscalls_info): Update.
4233 (init_syscalls_info): Update.
4234
4235 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4236
4237 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4238 out of get_init_files.
4239 (get_init_files): Update.
4240
4241 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4242
4243 * main.c (get_init_files): Change to use std::string.
4244 (captured_main_1): Update.
4245 (print_gdb_help): Update.
4246
4247 2019-09-11 Ali Tamur <tamur@google.com>
4248
4249 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4250 implementation.
4251
4252 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4253
4254 * dbxread.c (read_dbx_symtab): Update.
4255 * dwarf2read.c (load_partial_dies): Update.
4256 * mdebugread.c (parse_partial_symbols): Update.
4257 (handle_psymbol_enumerators): Update.
4258 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4259 * psymtab.c (add_psymbol_to_bcache): Likewise.
4260 (add_psymbol_to_list): Likewise.
4261 * symtab.c (symbol_set_names): Likewise.
4262 * symtab.h (symbol_set_names): Likewise.
4263 * xcoffread.c (scan_xcoff_symtab): Update.
4264
4265 2019-09-11 Tom Tromey <tom@tromey.com>
4266
4267 * symfile-mem.c (symbol_file_add_from_memory): Use
4268 bfd_set_filename.
4269 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4270 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4271
4272 2019-09-10 Tom Tromey <tromey@adacore.com>
4273
4274 * dwarf-index-write.c (write_psymbols): Extend error message.
4275 (debug_names::insert): Add Ada code.
4276 (debug_names::write_psymbols): Remove Ada check.
4277 (debug_names) <m_string_obstack>: New member.
4278 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4279 (gdb_index_symbol_name_matcher::matches): Remove.
4280 (mapped_index_base::find_name_components_bounds): Add "lang"
4281 parameter.
4282 (mapped_index_base::build_name_components): Also split names
4283 according to Ada syntax.
4284 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4285 type of "match_callback".
4286 (check_match, check_find_bounds_finds)
4287 (dw2_expand_symtabs_matching): Update.
4288 (dw2_debug_names_iterator): Add new constructor.
4289 (dw2_debug_names_map_matching_symbols): New function.
4290 (dw2_debug_names_expand_symtabs_matching): Update.
4291 (dwarf2_debug_names_functions): Use
4292 dw2_debug_names_map_matching_symbols.
4293
4294 2019-09-10 Tom Tromey <tromey@adacore.com>
4295
4296 * dwarf2read.c (dw2_get_file_names_reader): Add the
4297 CU's file name to the results.
4298
4299 2019-09-10 Tom Tromey <tromey@adacore.com>
4300
4301 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4302 map_matching_symbols. Update.
4303 * dwarf2read.c (dw2_map_matching_symbols): Update.
4304 * psymtab.c (match_partial_symbol): Change type; update.
4305 (psym_map_matching_symbols): Likewise.
4306 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4307 type; update.
4308 * symfile.h (struct quick_symbol_functions)
4309 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4310 Remove "match".
4311
4312 2019-09-10 Tom Tromey <tromey@adacore.com>
4313
4314 * psymtab.c (map_block): Remove.
4315 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4316 * symtab.c (iterate_over_symbols_terminated): New function.
4317 * symtab.c (iterate_over_symbols_terminated): Declare.
4318
4319 2019-09-10 Tom Tromey <tromey@adacore.com>
4320
4321 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4322 * language.h (struct language_defn) <la_iterate_over_symbols>:
4323 Return bool.
4324 * symtab.c (iterate_over_symbols): Return bool.
4325 * symtab.h (iterate_over_symbols): Return bool.
4326
4327 2019-09-10 Tom Tromey <tromey@adacore.com>
4328
4329 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4330 (add_nonlocal_symbols): Update.
4331 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4332 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4333 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4334 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4335 Change type of "callback". Remove "data".
4336
4337
4338 2019-09-09 Ali Tamur <tamur@google.com>
4339
4340 * dwarf2read.c (comp_unit_head): Update comment.
4341 (dwarf2_dwo_name): New function declaration.
4342 (dwarf_unit_type_name): New function declaration.
4343 (read_comp_unit_head): Add support for new compilation units,
4344 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4345 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4346 (currently named as "signature") in their header. Also clarify error
4347 messages.
4348 (lookup_dwo_id): New function. Returns the dwo id of the given
4349 compile unit.
4350 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4351 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4352 functions.
4353 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4354 (dwarf2_dwo_name): Get the dwo name if present.
4355 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4356 purposes.
4357
4358 2019-09-09 Tom Tromey <tom@tromey.com>
4359
4360 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4361
4362 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4363
4364 * python/python.c (do_start_initialization): Make progname_copy static,
4365 to avoid a leak report.
4366
4367 2019-09-08 Tom Tromey <tom@tromey.com>
4368
4369 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4370
4371 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
4372
4373 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4374 Change type to gdb::optional<block_enum>.
4375 (dw2_symtab_iter_init): Change block_index parameter type
4376 to gdb::optional<block_enum>.
4377 (dw2_lookup_symbol): Change block_index parameter
4378 type to block_enum.c
4379 (dw2_debug_names_lookup_symbol): Likewise.
4380 * psymtab.c (psym_lookup_symbol): Likewise.
4381 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4382 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4383 Likewise.
4384
4385 2019-09-06 Christian Biesinger <cbiesinger@google.com>
4386
4387 * defs.h (relocate_gdb_directory): Change int to bool in
4388 signature and rename flag to relocatable.
4389 * main.c (relocate_path): Likewise.
4390 (relocate_gdb_directory): Likewise.
4391
4392 2019-09-06 Alan Modra <amodra@gmail.com>
4393
4394 * coffread.c (coff_symfile_read): Constify filename variable.
4395 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4396 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4397 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4398 * solib.c (reload_shared_libraries_1): Likewise.
4399 * symfile.c (reread_symbols): Likewise.
4400 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4401 * solib-darwin.c (darwin_bfd_open): Likewise.
4402 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4403
4404 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4405
4406 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4407 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4408
4409 2019-09-03 Tom Tromey <tromey@adacore.com>
4410
4411 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4412 types.
4413 (has_negatives): Unbias a range type bound.
4414 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4415 * gdbtypes.c (operator==): Handle new field.
4416 (create_range_type): Add "bias" parameter.
4417 (create_static_range_type, resolve_dynamic_range): Update.
4418 * gdbtypes.h (struct range_bounds) <bias>: New member.
4419 (create_range_type): Add bias parameter.
4420 * printcmd.c (print_scalar_formatted): Unbias range types.
4421 * value.c (unpack_long): Unbias range types.
4422 (pack_long): Bias range types.
4423
4424 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4425
4426 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4427 probe arguments.
4428
4429 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4430
4431 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4432 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4433 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4434 (compile_probe_arg): Likewise.
4435 * probe.h (get_argument_count): Likewise.
4436 * solib-svr4.c (solib_event_probe_action): Likewise.
4437 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4438
4439 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4440
4441 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4442 code to here...
4443 (svr4_create_solib_event_breakpoints): ...from here.
4444
4445 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4446
4447 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4448 suffix from warning message.
4449
4450 2019-08-30 Tom Tromey <tom@tromey.com>
4451
4452 * tui/tui-winsource.h (struct tui_source_window_base)
4453 <refresh_all>: Don't declare.
4454 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4455 Remove.
4456 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4457 tui_show_locator_content.
4458 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4459 declare.
4460 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4461 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4462 declare.
4463
4464 2019-08-30 Tom Tromey <tom@tromey.com>
4465
4466 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4467
4468 2019-08-30 Tom Tromey <tom@tromey.com>
4469
4470 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4471 Remove unnecessary forward declarations.
4472
4473 2019-08-30 Tom Tromey <tom@tromey.com>
4474
4475 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4476 rerender.
4477 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4478 tui_show_locator_content.
4479
4480 2019-08-30 Tom Tromey <tom@tromey.com>
4481
4482 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4483 (tui_locator_window::rerender): Rewrite using body of previous
4484 tui_show_locator_content.
4485
4486 2019-08-30 Tom Tromey <tom@tromey.com>
4487
4488 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4489 set_locator_fullname>: New methods.
4490 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4491 Rename from tui_set_locator_fullname.
4492 (tui_locator_window::set_locator_info): Rename from
4493 tui_set_locator_info. Return bool.
4494 (tui_update_locator_fullname, tui_show_frame_info): Update.
4495
4496 2019-08-30 Tom Tromey <tom@tromey.com>
4497
4498 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4499
4500 2019-08-30 Tom Tromey <tom@tromey.com>
4501
4502 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4503 call touchwin.
4504
4505 2019-08-30 Tom Tromey <tom@tromey.com>
4506
4507 * tui/tui-wingeneral.c (box_win): Assume win_info and
4508 win_info->handle cannot be NULL.
4509
4510 2019-08-30 Tom Tromey <tom@tromey.com>
4511
4512 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4513 refresh_window>: Declare.
4514 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4515 resize.
4516 (tui_data_item_window::rerender): Rename from
4517 tui_display_register.
4518 (tui_data_item_window::refresh_window): New method.
4519 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4520 no-op.
4521
4522 2019-08-30 Tom Tromey <tom@tromey.com>
4523
4524 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4525 regs_column_count, current_group>: Move later. Now private.
4526 <get_current_group>: New method.
4527 * tui/tui-regs.c (tui_reg_command): Update.
4528 * tui/tui-layout.c (tui_set_layout): Update.
4529
4530 2019-08-30 Tom Tromey <tom@tromey.com>
4531
4532 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4533 (tui_data_window::rerender): Don't call
4534 check_and_display_highlight_if_needed.
4535 (tui_data_window::refresh_all): Remove call to
4536 erase_data_content.
4537
4538 2019-08-30 Tom Tromey <tom@tromey.com>
4539
4540 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4541 (tui_data_window::display_registers_from)
4542 (tui_data_window::display_reg_element_at_line)
4543 (tui_data_window::display_registers_from_line): Remove checks of
4544 "empty".
4545
4546 2019-08-30 Tom Tromey <tom@tromey.com>
4547
4548 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4549 Don't declare.
4550 * tui/tui-regs.c (tui_data_window::show_registers): Call
4551 rerender.
4552 (tui_data_window::rerender): Rename from display_all_data.
4553 (tui_data_window::rerender): Remove old implementation.
4554
4555 2019-08-30 Tom Tromey <tom@tromey.com>
4556
4557 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4558 text.
4559 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4560
4561 2019-08-29 Bernhard Wodok <barto@gmx.net>
4562 Sergio Durigan Junior <sergiodj@redhat.com>
4563
4564 PR win32/24284
4565 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4566
4567 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4568
4569 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4570 when searching for types.
4571
4572 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4573
4574 * f-lang.c (f_language_defn): Use f_print_typedef.
4575 * f-lang.h (f_print_typedef): Declare.
4576 * f-typeprint.c (f_print_typedef): Define.
4577
4578 2019-08-27 Christian Biesinger <cbiesinger@google.com>
4579
4580 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4581
4582 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4583
4584 * cli/cli-utils.c (info_print_options_defs): Delete.
4585 (make_info_print_options_def_group): Delete.
4586 (extract_info_print_options): Delete.
4587 (info_print_command_completer): Delete.
4588 (info_print_args_help): Add extra parameter, and optionally
4589 include text about -n flag.
4590 * cli/cli-utils.h (struct info_print_options): Delete.
4591 (extract_info_print_options): Delete declaration.
4592 (info_print_command_completer): Delete declaration.
4593 (info_print_args_help): Add extra parameter, extend header
4594 comment.
4595 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4596 search_symbols.
4597 * stack.c (struct info_print_options): New type.
4598 (info_print_options_defs): New file scoped variable.
4599 (make_info_print_options_def_group): New static function.
4600 (info_print_command_completer): New static function.
4601 (info_locals_command): Update to use new local functions.
4602 (info_args_command): Likewise.
4603 (_initialize_stack): Add extra parameter to calls to
4604 info_print_args_help.
4605 * symtab.c (search_symbols): Add extra parameter, use this to
4606 possibly excluse non-debug symbols.
4607 (symtab_symbol_info): Add extra parameter, which is passed on to
4608 search_symbols.
4609 (struct info_print_options): New type.
4610 (info_print_options_defs): New file scoped variable.
4611 (make_info_print_options_def_group): New static function.
4612 (info_print_command_completer): New static function.
4613 (info_variables_command): Update to use local functions, and pass
4614 extra parameter through to symtab_symbol_info.
4615 (info_functions_command): Likewise.
4616 (info_types_command): Pass additional argument through to
4617 symtab_symbol_info.
4618 (rbreak_command): Pass extra argument to search_symbols.
4619 (_initialize_symtab): Add extra arguments for calls to
4620 info_print_args_help, and update help text for 'info variables',
4621 'whereis', and 'info functions' commands.
4622 * symtab.h (search_symbols): Add extra argument to declaration.
4623 * NEWS: Mention new flags.
4624
4625 2019-08-26 Christian Biesinger <cbiesinger@google.com>
4626
4627 * symtab.c (lookup_static_symbol): Call the new function (and move
4628 it down to be next to lookup_global_symbol).
4629 (struct global_sym_lookup_data): Add block_enum member and rename to...
4630 (struct global_or_static_sym_lookup_data): ...this.
4631 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4632 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4633 (lookup_symbol_global_or_static_iterator_cb): ...this.
4634 (lookup_global_or_static_symbol): New function.
4635 (lookup_global_symbol): Call new function.
4636
4637 2019-08-26 Tom de Vries <tdevries@suse.de>
4638
4639 PR c++/24852
4640 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4641 when pc_probe.prob == NULL.
4642
4643 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4644
4645 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4646 variable symbol_linkage to symbol_linkage_.
4647
4648 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4649
4650 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4651 represent whether the symbol is static, dynamic, or we don't
4652 know.
4653
4654 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4655
4656 * gdb/rx-tdep.c (rx_register_names): New.
4657 (rx_register_name): Delete.
4658 (rx_psw_type): Delete.
4659 (rx_fpsw_type): Delete.
4660 (rx_register_type): Delete.
4661 (rx_gdbarch_init): Convert target-descriptions.
4662 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4663 * gdb/features/Makefile: Add rx.xml.
4664 * gdb/features/rx.xml: New.
4665 * gdb/features/rx.c: Generated.
4666 * gdb/NEWS: Mention target description support.
4667
4668 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4669
4670 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4671 *slot_ptr.
4672
4673 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4674
4675 * configure.ac: Don't check for 'dlfcn.h' (moved to
4676 gdbsupport/common.m4).
4677 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4678 'gdbsupport/'.
4679 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4680 * compile/compile-c-support.c: Include
4681 'gdbsupport/gdb-dlfcn.h'.
4682 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4683 * gdb-dlfcn.c: Move to...
4684 * gdbsupport/gdb-dlfcn.c: ... here.
4685 * gdb-dlfcn.h: Move to...
4686 * gdbsupport/gdb-dlfcn.h: ... here.
4687
4688 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4689
4690 * nios2-tdep.c (struct reg_value): Improve comments. Make
4691 the offset field signed.
4692
4693 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4694
4695 * python/lib/gdb/__init__.py (_execute_file): New function.
4696 * python/python.c (python_run_simple_file): Call gdb._execute_file
4697 on Windows.
4698
4699 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4700
4701 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4702 all uses as this was never set to anything but a zero value.
4703
4704 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4705
4706 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4707
4708 2019-08-21 Christian Biesinger <cbiesinger@google.com>
4709
4710 * tui/tui-data.h (tui_gen_win_info): Add an =default
4711 move constructor, required by some GCC versions.
4712
4713 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
4714
4715 * go32-nat.c (go32_sysinfo): Add hygon_p.
4716
4717 2019-08-20 Tom Tromey <tom@tromey.com>
4718
4719 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4720 line_from_reg_element_no, first_reg_element_no_inline,
4721 display_all_data, delete_data_content_windows,
4722 erase_data_content>: Now private.
4723
4724 2019-08-20 Tom Tromey <tom@tromey.com>
4725
4726 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4727 (tui_unhighlight_win, tui_highlight_win)
4728 (tui_win_info::make_window): Update.
4729 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4730
4731 2019-08-20 Tom Tromey <tom@tromey.com>
4732
4733 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4734 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4735 (MAX_PID_WIDTH): Move to tui-stack.c.
4736 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4737 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4738 (MAX_PID_WIDTH): Move from tui-data.h.
4739
4740 2019-08-20 Tom Tromey <tom@tromey.com>
4741
4742 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4743 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4744 (box_win): Update.
4745 (tui_gen_win_info::make_window): Rename from tui_make_window.
4746 (tui_win_info::make_window): New method.
4747 (tui_gen_win_info::make_visible): Update.
4748 * tui/tui-source.c (tui_source_window::set_contents): Update.
4749 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4750 (tui_data_window::display_registers_from): Update.
4751 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4752 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4753 Declare.
4754 <can_box>: Remove.
4755 <title>: Remove.
4756 (struct tui_win_info) <make_window>: Declare.
4757 <can_box>: Now virtual.
4758 <title>: New member.
4759 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4760 * tui/tui-command.c (tui_cmd_window::resize): Update.
4761
4762 2019-08-20 Tom Tromey <tom@tromey.com>
4763
4764 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4765 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4766 (tui_data_window::check_register_values): Update.
4767
4768 2019-08-20 Tom Tromey <tom@tromey.com>
4769
4770 * tui/tui-regs.h (struct tui_data_window): Use
4771 DISABLE_COPY_AND_ASSIGN.
4772 <regs_content>: Change type, removing unique_ptr.
4773 <tui_data_window>: Add move constructor.
4774 * tui/tui-regs.c (tui_data_window::show_registers)
4775 (tui_data_window::show_register_group)
4776 (tui_data_window::display_registers_from)
4777 (tui_data_window::display_registers_from)
4778 (tui_data_window::first_data_item_displayed)
4779 (tui_data_window::delete_data_content_windows)
4780 (tui_data_window::rerender, tui_data_window::refresh_window)
4781 (tui_data_window::check_register_values): Update.
4782
4783 2019-08-20 Tom Tromey <tom@tromey.com>
4784
4785 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4786 show_register_group>: Declare.
4787 (tui_show_register_group): Don't declare.
4788 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4789 tui_show_registers.
4790 (tui_data_window::show_register_group): Rename from
4791 tui_show_register_group.
4792 (tui_data_window::check_register_values, tui_reg_command):
4793 Update.
4794 * tui/tui-layout.c (tui_set_layout): Update.
4795
4796 2019-08-20 Tom Tromey <tom@tromey.com>
4797
4798 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4799 Declare.
4800 (tui_check_register_values): Don't declare.
4801 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4802 from tui_check_register_values.
4803 * tui/tui-hooks.c (tui_register_changed): Update.
4804
4805 2019-08-20 Tom Tromey <tom@tromey.com>
4806
4807 * tui/tui-regs.c (tui_reg_layout): Move later.
4808 (tui_show_registers): Don't enable TUI mode or change layout.
4809
4810 2019-08-20 Tom Tromey <tom@tromey.com>
4811
4812 * tui/tui-regs.h (struct tui_data_item_window)
4813 <~tui_data_item_window>: Remove.
4814 <content>: Now a unique_xmalloc_ptr.
4815 * tui/tui-regs.c (tui_register_format): Return a
4816 unique_xmalloc_ptr.
4817 (tui_get_register): Update.
4818 (~tui_data_item_window): Remove.
4819 (tui_data_window::display_registers_from, tui_display_register):
4820 Update.
4821 * tui/tui-io.h (tui_expand_tabs): Update.
4822 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4823 Remove "col" parameter.
4824
4825 2019-08-20 Tom Tromey <tom@tromey.com>
4826
4827 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4828 field.
4829 * tui/tui-regs.c (~tui_data_item_window): Update.
4830
4831 2019-08-20 Tom Tromey <tom@tromey.com>
4832
4833 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4834 earlier.
4835
4836 2019-08-20 Tom Tromey <tom@tromey.com>
4837
4838 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4839
4840 2019-08-20 Tom Tromey <tom@tromey.com>
4841
4842 * tui/tui-source.h (struct tui_source_window): Update.
4843 * tui/tui-regs.c (tui_show_registers): Update.
4844 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4845 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4846 (NO_REGS_STRING): Remove defines.
4847
4848 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
4849
4850 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4851 unnecessary thread walk if remote doesn't support the packet.
4852
4853 2019-08-19 Tom Tromey <tromey@adacore.com>
4854
4855 * python/py-value.c (value_has_field): Fix indentation.
4856
4857 2019-08-19 Tom Tromey <tromey@adacore.com>
4858
4859 * printcmd.c (do_one_display, info_display_command): Update.
4860 * block.h (contained_in): Return bool. Add allow_nested
4861 parameter.
4862 * block.c (contained_in): Return bool. Add allow_nested
4863 parameter.
4864
4865 2019-08-19 Tom Tromey <tom@tromey.com>
4866
4867 * configure: Rebuild.
4868 * configure.ac: Disallow the combination of -static-libstdc++ and
4869 source highlight.
4870 * source-cache.c (get_language_name): Handle rust.
4871 (source_cache::get_source_lines): Ignore highlighting exceptions.
4872
4873 2019-08-16 Tom Tromey <tom@tromey.com>
4874
4875 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4876 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4877 (struct tui_source_window_base) <make_visible, refresh_window,
4878 resize>: Remove methods.
4879 <execution_info>: Remove field.
4880 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4881 (tui_show_source_line, tui_source_window_base)
4882 (~tui_source_window_base): Update.
4883 (tui_source_window_base::resize)
4884 (tui_source_window_base::make_visible)
4885 (tui_source_window_base::refresh_window): Remove.
4886 (tui_source_window_base::update_exec_info): Update.
4887 * tui/tui-source.c (tui_source_window::set_contents): Update.
4888 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4889
4890 2019-08-16 Tom Tromey <tom@tromey.com>
4891
4892 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4893 deprecated_query_hook.
4894
4895 2019-08-16 Tom Tromey <tom@tromey.com>
4896
4897 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4898 (tui_update_source_windows_with_line): Update.
4899 * tui/tui-source.h (struct tui_source_window)
4900 <show_symtab_source>: Declare.
4901 (tui_show_symtab_source): Don't declare.
4902 * tui/tui-source.c (tui_show_symtab_source): Rename from
4903 tui_show_symtab_source.
4904
4905 2019-08-16 Tom Tromey <tom@tromey.com>
4906
4907 * tui/tui-winsource.h (struct tui_source_window_base)
4908 <set_contents>: Declare.
4909 * tui/tui-winsource.c
4910 (tui_source_window_base::update_source_window_as_is): Update.
4911 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4912 Declare.
4913 (tui_set_source_content): Don't declare.
4914 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4915 tui_set_source_content.
4916 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4917 Declare.
4918 (tui_set_disassem_content): Don't declare.
4919 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4920 tui_set_disassem_content.
4921
4922 2019-08-16 Tom Tromey <tom@tromey.com>
4923
4924 * tui/tui-winsource.h (struct tui_source_window_base)
4925 <update_breakpoint_info>: Declare.
4926 (tui_update_breakpoint_info): Don't declare.
4927 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4928 (tui_update_all_breakpoint_info): Update.
4929 (tui_source_window_base::update_breakpoint_info): Rename from
4930 tui_update_breakpoint_info.
4931 (tui_source_window_base::update_exec_info): Update.
4932
4933 2019-08-16 Tom Tromey <tom@tromey.com>
4934
4935 * tui/tui-winsource.h (struct tui_source_window_base)
4936 <update_source_window>: Declare.
4937 (tui_update_source_window): Don't declare.
4938 * tui/tui-winsource.c
4939 (tui_source_window_base::update_source_window): Rename from
4940 tui_update_source_window.
4941 (tui_source_window_base::rerender): Update.
4942 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4943 * tui/tui-disasm.c (tui_show_disassem)
4944 (tui_show_disassem_and_update_source)
4945 (tui_disasm_window::maybe_update): Update.
4946
4947 2019-08-16 Tom Tromey <tom@tromey.com>
4948
4949 * tui/tui-winsource.h (struct tui_source_window_base)
4950 <update_source_window_as_is>: Declare.
4951 (tui_update_source_window_as_is): Don't declare.
4952 * tui/tui-winsource.c (tui_update_source_window): Update
4953 (tui_source_window_base::update_source_window_as_is): Rename from
4954 tui_update_source_window_as_is.
4955 (tui_source_window_base::refill): Update.
4956 * tui/tui-source.c (tui_show_symtab_source): Update.
4957 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4958 Update.
4959
4960 2019-08-16 Tom Tromey <tom@tromey.com>
4961
4962 * tui/tui-winsource.h (tui_update_source_window)
4963 (tui_update_source_window_as_is): Remove "noerror" parameter.
4964 * tui/tui-winsource.c (tui_update_source_window)
4965 (tui_update_source_window_as_is): Remove "noerror" parameter.
4966 (tui_update_source_windows_with_addr)
4967 (tui_update_source_windows_with_line)
4968 (tui_source_window_base::rerender)
4969 (tui_source_window_base::refill): Update.
4970 * tui/tui-source.h (tui_set_source_content)
4971 (tui_show_symtab_source): Remove "noerror" parameter.
4972 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4973 parameter.
4974 (tui_show_symtab_source): Likewise.
4975 (tui_source_window::maybe_update): Update.
4976 * tui/tui-disasm.c (tui_show_disassem)
4977 (tui_show_disassem_and_update_source)
4978 (tui_disasm_window::do_scroll_vertical)
4979 (tui_disasm_window::maybe_update): Update.
4980
4981 2019-08-16 Tom Tromey <tom@tromey.com>
4982
4983 * tui/tui.c (tui_is_window_visible): Update.
4984 * tui/tui-wingeneral.c (tui_make_window)
4985 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4986 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4987 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4988 (tui_set_win_height_command, parse_scrolling_args): Update.
4989 * tui/tui-source.c (tui_source_window::style_changed): Update.
4990 * tui/tui-regs.c (tui_show_registers)
4991 (tui_data_window::first_data_item_displayed)
4992 (tui_data_window::delete_data_content_windows)
4993 (tui_check_register_values, tui_reg_command): Update.
4994 * tui/tui-disasm.c (tui_show_disassem): Update.
4995 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4996 method.
4997 <is_visible>: Remove field.
4998 * tui/tui-data.c (tui_next_win, tui_prev_win)
4999 (tui_delete_invisible_windows): Update.
5000
5001 2019-08-16 Tom Tromey <tom@tromey.com>
5002
5003 * tui/tui-winsource.h (struct tui_source_window_base)
5004 <m_has_locator>: Remove.
5005 * tui/tui-layout.c (show_source_disasm_command, show_data)
5006 (show_source_or_disasm_and_command): Update.
5007
5008 2019-08-16 Alan Hayward <alan.hayward@arm.com>
5009
5010 * NEWS (Other MI changes): New subsection.
5011 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5012 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5013 * arch-utils.c (default_get_pc_address_flags): New function.
5014 * arch-utils.h (default_get_pc_address_flags): New declaration.
5015 * gdbarch.sh: Add get_pc_address_flags.
5016 * gdbarch.c: Regenerate.
5017 * gdbarch.h: Likewise.
5018 * stack.c (print_pc): New function.
5019 (print_frame_info) (print_frame): Call print_pc.
5020
5021 2019-08-16 Tom de Vries <tdevries@suse.de>
5022
5023 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5024 print_objfile_section_info.
5025
5026 2019-08-15 Tom Tromey <tom@tromey.com>
5027
5028 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5029 calling update_cmdwin_start_line.
5030 * tui/tui-winsource.h (struct tui_source_window_base)
5031 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5032 <rerender>: Declare.
5033 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5034 Call rerender.
5035 (tui_source_window_base::set_new_height): Remove.
5036 (tui_source_window_base::rerender): Rename from
5037 do_make_visible_with_new_height.
5038 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5039 resize method.
5040 (tui_win_info::make_invisible_and_set_new_height)
5041 (tui_win_info::make_visible_with_new_height): Remove.
5042 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5043 Declare.
5044 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5045 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5046 do_make_visible_with_new_height>: Don't declare.
5047 <rerender>: Declare.
5048 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5049 set_new_height.
5050 (tui_data_window::do_make_visible_with_new_height): Remove.
5051 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5052 call tui_show_locator_content.
5053 (tui_gen_win_info::resize): Call rerender.
5054 (show_source_or_disasm_and_command): Don't call
5055 tui_show_locator_content.
5056 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5057 method.
5058 (struct tui_win_info) <rerender>: Declare.
5059 <set_new_height, make_invisible_and_set_new_height,
5060 make_visible_with_new_height>: Don't declare.
5061 * tui/tui-data.c (tui_win_list::rerender): New method.
5062 * tui/tui-command.h (struct tui_cmd_window)
5063 <do_make_visible_with_new_height>: Don't declare.
5064 * tui/tui-command.c
5065 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5066
5067 2019-08-15 Tom Tromey <tromey@adacore.com>
5068
5069 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5070 * ada-lang.c (ada_enum_name): Likewise.
5071
5072 2019-08-15 Christian Biesinger <cbiesinger@google.com>
5073
5074 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5075 leading underscore.
5076 (GdbOutputErrorFile): Likewise.
5077 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5078 accordingly.
5079 (execute_unwinders): Rename to have a leading underscore.
5080 (auto_load_packages): Likewise.
5081 (global scope): Adjust call to auto_load_packages accordingly.
5082 (GdbSetPythonDirectory): Likewise.
5083 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5084 instead of execute_unwinders.
5085
5086 2019-08-15 Tom Tromey <tom@tromey.com>
5087
5088 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5089 (show_data): Don't change window visibility.
5090 (tui_gen_win_info::resize): Remove special case for command
5091 window. Use wresize, when available.
5092 (show_source_or_disasm_and_command): Don't change window
5093 visibility.
5094 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5095 <make_visible>: New method.
5096 * tui/tui-command.c (tui_cmd_window::resize): New method.
5097
5098 2019-08-15 Tom Tromey <tom@tromey.com>
5099
5100 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5101 (struct tui_source_windows): New.
5102 * tui/tui-winsource.c (tui_display_main): Update.
5103 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5104 (new_height_ok, parse_scrolling_args): Update.
5105 * tui/tui-layout.c (show_layout, show_data): Update.
5106 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5107 (tui_add_to_source_windows): Don't declare.
5108 * tui/tui-data.c (source_windows, tui_source_windows)
5109 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5110
5111 2019-08-15 Tom Tromey <tom@tromey.com>
5112
5113 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5114 Rename from reset.
5115 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5116 * tui/tui-layout.c (show_source_disasm_command, show_data):
5117 Update.
5118 (tui_gen_win_info::resize): Rename.
5119 (show_source_or_disasm_and_command): Update.
5120 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5121 reset.
5122
5123 2019-08-15 Tom Tromey <tom@tromey.com>
5124
5125 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5126 * tui/tui-interp.c (tui_interp::init): Don't call
5127 tui_initialize_static_data.
5128 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5129
5130 2019-08-15 Tom Tromey <tom@tromey.com>
5131
5132 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5133 examine tui_win_list.
5134
5135 2019-08-15 Tom Tromey <tom@tromey.com>
5136
5137 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5138 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5139 tui_clear_source_content.
5140 (tui_clear_source_content): Remove.
5141 (tui_source_window_base::do_erase_source_content): Hoist call to
5142 content.clear().
5143 * tui/tui-stack.c (tui_show_frame_info): Don't call
5144 tui_clear_source_content.
5145
5146 2019-08-15 Tom Tromey <tom@tromey.com>
5147
5148 * tui/tui-winsource.h (struct tui_source_window_base)
5149 <do_erase_source_content>: New method.
5150 <erase_source_content>: New method.
5151 (tui_erase_source_content): Don't declare.
5152 * tui/tui-winsource.c (tui_clear_source_content): Update.
5153 (tui_source_window_base::do_erase_source_content): Rename from
5154 tui_erase_source_content.
5155 (tui_source_window_base::show_source_content): Update.
5156 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5157 * tui/tui-source.h (struct tui_source_window)
5158 <erase_source_content>: New method.
5159 * tui/tui-disasm.h (struct tui_disasm_window)
5160 <erase_source_content>: New method.
5161
5162 2019-08-15 Tom Tromey <tom@tromey.com>
5163
5164 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5165 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5166 constructor.
5167 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5168 * tui/tui-source.c (tui_set_source_content): Update.
5169 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5170
5171 2019-08-15 Tom Tromey <tom@tromey.com>
5172
5173 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5174 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5175 tui-source.c.
5176 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5177 Declare.
5178 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5179 method.
5180 (tui_source_window::maybe_update): Update.
5181
5182 2019-08-15 Tom Tromey <tom@tromey.com>
5183
5184 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5185 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5186 tui-disasm.c.
5187 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5188 Declare.
5189 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5190 method.
5191 (tui_disasm_window::maybe_update): Update.
5192
5193 2019-08-15 Tom Tromey <tom@tromey.com>
5194
5195 * tui/tui-winsource.h (struct tui_source_window_base)
5196 <maybe_update>: Declare.
5197 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5198 method.
5199 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5200 Declare.
5201 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5202 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5203 Declare.
5204 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5205
5206 2019-08-15 Tom Tromey <tom@tromey.com>
5207
5208 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5209
5210 2019-08-15 Tom Tromey <tom@tromey.com>
5211
5212 * tui/tui-wingeneral.c: Include tui-stack.h.
5213 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5214 (struct tui_locator_window): Move from tui-data.h.
5215 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5216 (tui_initialize_static_data): Move from tui-data.c.
5217 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5218 (struct tui_locator_window): Move to tui-stack.c.
5219 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5220 (tui_initialize_static_data): Move to tui-stack.c.
5221
5222 2019-08-15 Tom Tromey <tom@tromey.com>
5223
5224 * tui/tui-layout.c (show_source_disasm_command)
5225 (show_source_or_disasm_and_command): Use make_visible method, not
5226 tui_make_window.
5227 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5228 Remove.
5229
5230 2019-08-15 Tom Tromey <tom@tromey.com>
5231
5232 * tui/tui-wingeneral.h (tui_make_window): Update.
5233 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5234 parameter.
5235 (tui_gen_win_info::make_visible): Update.
5236 * tui/tui-regs.c (tui_data_window::display_registers_from):
5237 Update.
5238 * tui/tui-layout.c (show_source_disasm_command)
5239 (show_source_or_disasm_and_command): Update.
5240 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5241 (enum tui_box): Remove.
5242 (struct tui_win_info) <can_box>: New method.
5243 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5244 method.
5245
5246 2019-08-15 Tom de Vries <tdevries@suse.de>
5247
5248 * linux-nat-trad.c: Include gdbarch.h.
5249
5250 2019-08-14 Alan Hayward <alan.hayward@arm.com>
5251
5252 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5253 register sizes.
5254
5255 2019-08-14 Tom Tromey <tromey@adacore.com>
5256
5257 * darwin-nat.c: Include gdbarch.h.
5258 * darwin-nat-info.c: Include gdbarch.h.
5259
5260 2019-08-13 Tom Tromey <tom@tromey.com>
5261
5262 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5263 Remove.
5264 * tui/tui-data.c (tui_initialize_static_data): Update.
5265
5266 2019-08-13 Tom Tromey <tom@tromey.com>
5267
5268 * tui/tui-winsource.h (struct tui_exec_info_window)
5269 <~tui_exec_info_window, maybe_allocate_content, get_content,
5270 m_content>: Remove.
5271 (struct tui_source_window_base) <set_exec_info_content,
5272 show_exec_info_content>: Don't declare.
5273 * tui/tui-winsource.c
5274 (tui_exec_info_window::maybe_allocate_content): Remove.
5275 (tui_source_window_base::update_exec_info): Rename from
5276 set_exec_info_content.
5277 (tui_source_window_base::show_exec_info_content)
5278 (tui_source_window_base::update_exec_info): Remove.
5279
5280 2019-08-13 Tom Tromey <tom@tromey.com>
5281
5282 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5283 declare.
5284 * tui/tui-winsource.c (tui_update_source_window_as_is)
5285 (tui_update_source_windows_with_addr, tui_erase_source_content):
5286 Update.
5287 (tui_clear_exec_info_content): Remove.
5288
5289 2019-08-13 Tom Tromey <tom@tromey.com>
5290
5291 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5292 declare.
5293 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5294 call tui_erase_exec_info_content.
5295 (tui_clear_exec_info_content): Rename from
5296 tui_erase_exec_info_content.
5297 (tui_clear_exec_info_content): Delete.
5298
5299 2019-08-13 Tom Tromey <tom@tromey.com>
5300
5301 * tui/tui-winsource.h (struct tui_source_window_base)
5302 <show_exec_info_content>: Declare.
5303 (tui_show_exec_info_content): Don't declare.
5304 * tui/tui-winsource.c
5305 (tui_source_window_base::show_exec_info_content): Rename from
5306 tui_show_exec_info_content.
5307 (tui_source_window_base::update_exec_info): Update.
5308
5309 2019-08-13 Tom Tromey <tom@tromey.com>
5310
5311 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5312 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5313 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5314 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5315 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5316 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5317 ... here.
5318
5319 2019-08-13 Tom Tromey <tom@tromey.com>
5320
5321 * tui/tui-winsource.h (struct tui_source_window_base)
5322 <update_exec_info>: Declare.
5323 (tui_update_exec_info): Don't declare.
5324 * tui/tui-winsource.c (tui_update_source_window_as_is)
5325 (tui_source_window_base::refresh_all)
5326 (tui_update_all_breakpoint_info): Update.
5327 (tui_source_window_base::update_exec_info): Rename from
5328 tui_update_exec_info.
5329 * tui/tui-stack.c (tui_show_frame_info): Update.
5330
5331 2019-08-13 Tom Tromey <tom@tromey.com>
5332
5333 * tui/tui-winsource.h (struct tui_source_window_base)
5334 <set_exec_info_content>: Declare.
5335 (tui_set_exec_info_content): Don't declare.
5336 * tui/tui-winsource.c
5337 (tui_source_window_base::set_exec_info_content): Rename from
5338 tui_set_exec_info_content.
5339 (tui_update_exec_info): Update.
5340
5341 2019-08-13 Tom Tromey <tom@tromey.com>
5342
5343 * tui/tui-winsource.h (struct tui_source_window_base)
5344 <show_source_content>: Declare.
5345 (tui_show_source_content): Don't declare.
5346 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5347 (tui_source_window_base::show_source_content): Rename from
5348 tui_show_source_content.
5349 (tui_source_window_base::refresh_all): Update.
5350 * tui/tui-layout.c (show_source_disasm_command)
5351 (show_source_or_disasm_and_command): Update.
5352
5353 2019-08-13 Tom Tromey <tom@tromey.com>
5354
5355 * tui/tui-winsource.c (tui_erase_source_content)
5356 (tui_show_source_content, tui_source_window_base::refresh_all):
5357 Update.
5358 * tui/tui-wingeneral.h
5359 (tui_check_and_display_highlight_if_needed): Don't declare.
5360 * tui/tui-wingeneral.c
5361 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5362 check_and_display_highlight_if_needed.
5363 * tui/tui-win.c (tui_rehighlight_all)
5364 (tui_win_info::make_visible_with_new_height): Update.
5365 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5366 (tui_data_window::erase_data_content)
5367 (tui_data_window::display_all_data): Update.
5368 * tui/tui-data.h (struct tui_win_info)
5369 <check_and_display_highlight_if_needed>: Declare.
5370
5371 2019-08-13 Tom Tromey <tom@tromey.com>
5372
5373 * tui/tui-win.c (tui_resize_all): Call
5374 tui_delete_invisible_windows.
5375 * tui/tui-layout.c (show_layout): Call
5376 tui_delete_invisible_windows.
5377 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5378 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5379
5380 2019-08-13 Tom Tromey <tom@tromey.com>
5381
5382 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5383 tui_add_win_to_layout.
5384
5385 2019-08-13 Tom Tromey <tom@tromey.com>
5386
5387 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5388 * tui/tui-layout.c (tui_default_win_height): Now static.
5389
5390 2019-08-13 Tom Tromey <tom@tromey.com>
5391
5392 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5393 single switch.
5394 (show_source_disasm_command, show_source_or_disasm_and_command):
5395 Don't check current layout.
5396
5397 2019-08-13 Tom Tromey <tom@tromey.com>
5398
5399 * tui/tui-wingeneral.c (make_all_visible): Remove.
5400 (tui_make_all_invisible): Simplify.
5401 * tui/tui-layout.c (tui_make_all_invisible): Move from
5402 tui-wingeneral.c; simplify.
5403 (show_layout): Hoist call to tui_make_all_invisible.
5404 (show_data): Don't call tui_make_all_invisible.
5405
5406 2019-08-13 Tom Tromey <tom@tromey.com>
5407
5408 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5409 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5410
5411 2019-08-13 Tom Tromey <tom@tromey.com>
5412
5413 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5414 tui-data.c.
5415 (show_source_disasm_command, show_data)
5416 (show_source_or_disasm_and_command): Don't use
5417 tui_set_current_layout_to.
5418 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5419 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5420 tui-layout.c.
5421 (tui_set_current_layout_to): Remove.
5422
5423 2019-08-13 Tom Tromey <tom@tromey.com>
5424
5425 * tui/tui-layout.c (tui_set_layout): Update.
5426 * tui/tui-data.h (struct tui_layout_def): Remove.
5427 (tui_layout_def): Don't declare.
5428 * tui/tui-data.c (layout_def): Remove.
5429 (tui_layout_def): Remove.
5430
5431 2019-08-13 Tom Tromey <tom@tromey.com>
5432
5433 * tui/tui-winsource.h (struct tui_source_window_base)
5434 <clear_detail>: No longer "override".
5435 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5436 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5437 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5438 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5439 Remove.
5440 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5441
5442 2019-08-13 Tom Tromey <tromey@adacore.com>
5443
5444 * tracepoint.c: Don't include readline.h or history.h.
5445
5446 2019-08-12 Tom Tromey <tom@tromey.com>
5447
5448 * configure: Rebuild.
5449 * configure.ac: Check for readline 7.
5450 * NEWS: Mention readline 7 requirement.
5451 * README: Update.
5452
5453 2019-08-12 Tom Tromey <tom@tromey.com>
5454
5455 * mingw-hdep.c (gdb_select): Remove readline hack.
5456
5457 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5458
5459 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5460 when the function fails.
5461
5462 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5463
5464 * s390-tdep.c (s390_type_align): New function.
5465 (s390_gdbarch_init): Set it as type_align gdbarch method.
5466
5467 2019-08-09 Tom de Vries <tdevries@suse.de>
5468
5469 PR gdb/24591
5470 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5471 pc_low with relocation offset.
5472
5473 2019-08-07 Tom Tromey <tromey@adacore.com>
5474
5475 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5476 (print_frame_args): Update.
5477 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5478 Update.
5479 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5480 * frame.h (struct frame_arg): Add initializers.
5481 <error>: Now a unique_xmalloc_ptr.
5482
5483 2019-08-07 Alan Hayward <alan.hayward@arm.com>
5484
5485 * NEWS: Expand the Pointer Authentication entry.
5486 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5487 (aarch64_frame_unmask_lr): ... to this.
5488 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5489 Call aarch64_frame_unmask_lr.
5490 * frame.c (struct frame_info): Add "masked" variable.
5491 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5492 (fprint_frame): Check for masked pc.
5493 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5494 declarations.
5495 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5496 * stack.c (print_frame): Check for masked pc.
5497
5498 2019-08-06 Tom Tromey <tom@tromey.com>
5499
5500 * stabsread.c (patch_block_stabs, read_one_struct_field)
5501 (read_enum_type): Use obstack_strndup.
5502 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5503 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5504 * dwarf2read.c (guess_full_die_structure_name)
5505 (anonymous_struct_prefix): Use obstack_strndup.
5506 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5507 * c-exp.y (yylex): Use obstack_strndup.
5508 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5509 (write_var_or_type): Use obstack_strndup.
5510
5511 2019-08-06 Tom Tromey <tom@tromey.com>
5512
5513 * symfile.c (reread_symbols): Use obstack_strdup.
5514 * stabsread.c (read_type): Use obstack_strdup.
5515 * gdb_obstack.h (obstack_strdup): New overload.
5516 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5517 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5518 (dwarf2_canonicalize_name): Use obstack_strdup.
5519 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5520 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5521 Use obstack_strdup.
5522
5523 2019-08-06 Tom Tromey <tom@tromey.com>
5524
5525 * gdb_obstack.h (obstack_strdup): Define.
5526 * gdb_obstack.c (obstack_strdup): Don't define.
5527
5528 2019-08-06 Tom Tromey <tom@tromey.com>
5529
5530 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5531 obstack_strdup.
5532 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5533 obstack_strdup.
5534 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5535 * stabsread.c (common_block_start): Use obstack_strdup.
5536 * objfiles.c (set_objfile_main_name, objfile): Use
5537 obstack_strdup.
5538 * namespace.c (add_using_directive): Use obstack_strdup.
5539 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5540 * jit.c (finalize_symtab): Use obstack_strdup.
5541 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5542 (guess_partial_die_structure_name, partial_die_info::fixup)
5543 (dwarf2_name): Use obstack_strdup.
5544 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5545 obstack_strdup.
5546 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5547 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5548 obstack_strdup.
5549 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5550
5551 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5552
5553 * unittests/help-doc-selftests.c: New file.
5554 * Makefile.in: Add the new file.
5555
5556 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5557
5558 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5559 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5560 the full first line, except when FOR_VALUE_PREFIX. In this case,
5561 the trailing '.' is not output, and the first character is uppercased.
5562 (print_help_for_command): Update call to print_doc_line.
5563 (print_doc_of_command): Likewise.
5564 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5565 * cli/cli-option.c (append_indented_doc): Do not append newline.
5566 (build_help_option): Append newline after first appended_indented_doc
5567 only if a second call is done.
5568 (build_help): Append 2 new lines before each option, except the first
5569 one.
5570 * compile/compile.c (_initialize_compile): Add new lines after
5571 %OPTIONS%, when not at the end of the help.
5572 Change help doc or code
5573 producing the help doc to respect the invariants.
5574 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5575 Also removed the new line after 'Options:', as all other commands
5576 do not put an empty line between 'Options:' and the first option.
5577 * printcmd.c (_initialize_printcmd): Likewise.
5578 * stack.c (_initialize_stack): Likewise.
5579 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5580 incorrectly telling COMMAND is optional.
5581 * ada-lang.c (_initialize_ada_language): Change help doc or code
5582 producing the help doc to respect the invariants.
5583 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5584 * breakpoint.c (_initialize_breakpoint): Likewise.
5585 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5586 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5587 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5588 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5589 _initialize_cli_style): Likewise.
5590 * corelow.c (core_target_info): Likewise.
5591 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5592 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5593 * filesystem.c (_initialize_filesystem): Likewise.
5594 * frame.c (_initialize_frame): Likewise.
5595 * gnu-nat.c (add_task_commands): Likewise.
5596 * infcall.c (_initialize_infcall): Likewise.
5597 * infcmd.c (_initialize_infcmd): Likewise.
5598 * interps.c (_initialize_interpreter): Likewise.
5599 * language.c (_initialize_language): Likewise.
5600 * linux-fork.c (_initialize_linux_fork): Likewise.
5601 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5602 * maint.c (_initialize_maint_cmds): Likewise.
5603 * memattr.c (_initialize_mem): Likewise.
5604 * printcmd.c (_initialize_printcmd): Likewise.
5605 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5606 _RegEx): Likewise.
5607 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5608 * record-btrace.c (_initialize_record_btrace): Likewise.
5609 * record-full.c (_initialize_record_full): Likewise.
5610 * record.c (_initialize_record): Likewise.
5611 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5612 * regcache.c (_initialize_regcache): Likewise.
5613 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5614 _initialize_remote): Likewise.
5615 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5616 * serial.c (_initialize_serial): Likewise.
5617 * skip.c (_initialize_step_skip): Likewise.
5618 * source.c (_initialize_source): Likewise.
5619 * stack.c (_initialize_stack): Likewise.
5620 * symfile.c (_initialize_symfile): Likewise.
5621 * symtab.c (_initialize_symtab): Likewise.
5622 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5623 * top.c (init_main): Likewise.
5624 * tracefile-tfile.c (tfile_target_info): Likewise.
5625 * tracepoint.c (_initialize_tracepoint): Likewise.
5626 * tui/tui-win.c (_initialize_tui_win): Likewise.
5627 * utils.c (add_internal_problem_command): Likewise.
5628 * valprint.c (value_print_option_defs): Likewise.
5629
5630 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
5631
5632 PR build/24886
5633 * configure.ac: Drop enable-libmcheck support.
5634 * configure, config.in: Rebuild.
5635 * libmcheck.m4: Remove.
5636 * acinclude.m4: Don't include it.
5637 * Makefile.in: Don't distribute it.
5638 * top.c (print_gdb_configuration): Don't mention it.
5639
5640 2019-08-06 Tom Tromey <tom@tromey.com>
5641
5642 * utils.c (set_output_style): Sometimes pass stream to
5643 emit_style_escape.
5644 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5645 * record-btrace.c (btrace_insn_history): Update.
5646 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5647 method.
5648 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5649 Update initializers.
5650 <m_uiout>: New field.
5651 <m_di>: Move lower.
5652 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5653 Remove "uiout" parameter.
5654 (dump_insns): Update.
5655 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5656 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5657
5658 2019-08-06 Christian Biesinger <cbiesinger@google.com>
5659
5660 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5661 (error_in_psymtab_expansion): Likewise.
5662 (lookup_symbol_via_quick_fns): Likewise.
5663 (basic_lookup_transparent_type_quick): Likewise.
5664 (basic_lookup_transparent_type_1): Likewise.
5665
5666 2019-08-06 Tom Tromey <tromey@adacore.com>
5667
5668 * source.c (last_source_error): Now bool.
5669 (print_source_lines_base): Make "noprint" bool. Only open
5670 source file when last_source_visited changes.
5671
5672 2019-08-06 Tom Tromey <tromey@adacore.com>
5673
5674 * annotate.c (annotate_source_line): Use g_source_cache.
5675 * source-cache.c (source_cache::get_plain_source_lines): Change
5676 parameters. Populate m_offset_cache.
5677 (source_cache::ensure): New method.
5678 (source_cache::get_line_charpos): New method.
5679 (extract_lines): Move lower. Change parameters.
5680 (source_cache::get_source_lines): Move lower.
5681 * source-cache.h (class source_cache): Update comment.
5682 <get_line_charpos>: New method.
5683 <get_source_lines>: Update comment.
5684 <clear>: Clear m_offset_cache.
5685 <get_plain_source_lines>: Change parameters.
5686 <ensure>: New method
5687 <m_offset_cache>: New member.
5688 * source.c (forget_cached_source_info_for_objfile): Update.
5689 (info_source_command): Use g_source_cache.
5690 (find_source_lines, open_source_file_with_line_charpos): Remove.
5691 (print_source_lines_base, search_command_helper): Use g_source_cache.
5692 * source.h (open_source_file_with_line_charpos): Don't declare.
5693 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5694 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5695 Use g_source_cache.
5696
5697 2019-08-06 Tom Tromey <tromey@adacore.com>
5698
5699 * source-cache.c (source_cache::get_plain_source_lines):
5700 Remove "first_line" and "last_line" parameters.
5701 (source_cache::get_source_lines): Cache plain text.
5702 * source-cache.h (class source_cache)
5703 <get_plain_source_lines>: Update.
5704
5705 2019-08-06 Tom Tromey <tromey@adacore.com>
5706
5707 * source-cache.c (extract_lines): No longer a method.
5708 Changed type of parameter. Include final newline.
5709 (selftests::extract_lines_test): New function.
5710 (_initialize_source_cache): Likewise.
5711 * source-cache.h (class source_cache)
5712 <extract_lines>: Don't declare.
5713
5714 2019-08-06 Tom Tromey <tromey@adacore.com>
5715
5716 * breakpoint.c (init_breakpoint_sal): Update.
5717 (breakpoint): Update.
5718 * breakpoint.h (struct breakpoint) <filter>: Now a
5719 unique_xmalloc_ptr.
5720
5721 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5722
5723 * NEWS: Mention dictionary access on blocks.
5724 * python/py-block.c (blpy_getitem): New function.
5725 (block_object_as_mapping): New struct.
5726 (block_object_type): Use new struct for tp_as_mapping field.
5727
5728 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5729
5730 * objfiles.h (objfile): Add a comment describing partial symbols.
5731
5732 2019-08-05 Tom Tromey <tromey@adacore.com>
5733
5734 * compile/compile.c (_initialize_compile): Use _(), not N_().
5735 * thread.c (_initialize_thread): Use _(), not N_().
5736 * stack.c (_initialize_stack): Use _(), not N_().
5737 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5738
5739 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5740
5741 * dwarf2read.c (struct dw2_symtab_iterator):
5742 <want_specific_block>: Remove.
5743 <block_index>: Change type to gdb::optional.
5744 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5745 change type of BLOCK_INDEX parameter to gdb::optional.
5746 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5747 (dw2_lookup_symbol): Don't pass argument for
5748 WANT_SPECIFIC_BLOCK.
5749 (dw2_expand_symtabs_for_function): Don't pass argument for
5750 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5751 (class dw2_debug_names_iterator)
5752 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5753 parameter, change BLOCK_INDEX type to gdb::optional.
5754 <m_want_specific_block>: Remove.
5755 <m_block_index>: Change type to gdb::optional.
5756 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5757 gdb::optional. Re-write in function of gdb::optional.
5758 (dw2_debug_names_lookup_symbol): Don't pass argument for
5759 WANT_SPECIFIC_BLOCK.
5760 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5761 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5762 BLOCK_INDEX.
5763
5764 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5765
5766 * NEWS: Mention changes to "info sources" command.
5767
5768 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5769
5770 * symtab.c (filename_partial_match_opts): New struct type.
5771 (struct output_source_filename_data): New members
5772 regexp, c_regexp, partial_match.
5773 (output_source_filename): Use new members to decide to print file.
5774 (info_sources_option_defs): New variable.
5775 (make_info_sources_options_def_group, print_info_sources_header,
5776 info_sources_command_completer):
5777 New functions.
5778 (info_sources_command): Read new optional arguments.
5779 (_initialize_symtab): Update info sources help.
5780
5781 2019-08-02 Alexandre Oliva <oliva@adacore.com>
5782
5783 * ada-lang.c (exception_support_info_v0): Renamed from...
5784 (default_exception_support_info): ... this. Create new
5785 definition for v1.
5786 (ada_has_this_exception_support): Look up catch_handlers_sym.
5787 (ada_exception_support_info_sniffer): Try v0 after default.
5788
5789 2019-08-01 Tom Tromey <tromey@adacore.com>
5790
5791 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5792 gdbarch.h.
5793
5794 2019-08-01 Christian Biesinger <cbiesinger@google.com>
5795
5796 * s12z-tdep.c: Fix include path for s12z-opc.h.
5797
5798 2019-08-01 Alan Hayward <alan.hayward@arm.com>
5799
5800 * NEWS: Require GNU make 3.82.
5801
5802 2019-07-16 Tom Tromey <tom@tromey.com>
5803
5804 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5805 declare.
5806
5807 2019-07-30 Tom Tromey <tromey@adacore.com>
5808
5809 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5810
5811 2019-07-30 Kevin Buettner <kevinb@redhat.com>
5812
5813 * printcmd.c (print_address_symbolic): Print negative offsets.
5814 (build_address_symbolic): Force signed arithmetic when computing
5815 offset.
5816
5817 2019-07-30 Christian Biesinger <cbiesinger@google.com>
5818
5819 PR/24474: Add a function to lookup static variables.
5820 * NEWS: Mention this new function.
5821 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5822 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5823 * python/python.c (python_GdbMethods): Add new function.
5824
5825 2019-07-29 Christian Biesinger <cbiesinger@google.com>
5826
5827 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5828 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5829 (objfpy_lookup_static_symbol): New function.
5830 (objfile_object_methods): Add new functions.
5831
5832 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5833
5834 * NEWS: Mention 'set|show print frame-info'. Mention new
5835 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5836 backtrace argument. Mention that python frame filtering code
5837 is now consistent with what 'backtrace' command prints.
5838
5839 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5840
5841 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5842 comments.
5843 (print_frame_info_auto, print_frame_info_source_line,
5844 print_frame_info_location, print_frame_info_source_and_location,
5845 print_frame_info_location_and_address, print_frame_info_short_location):
5846 New declarations.
5847 (struct frame_print_options): New member print_frame_info.
5848 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5849 * stack.h (get_user_print_what_frame_info): New declaration.
5850 (frame_show_address): New declaration.
5851 * stack.c (print_frame_arguments_choices): New value 'presence'.
5852 (print_frame_info_auto, print_frame_info_source_line,
5853 print_frame_info_location, print_frame_info_source_and_location,
5854 print_frame_info_location_and_address, print_frame_info_short_location,
5855 print_frame_info_choices, print_frame_info_print_what): New definitions.
5856 (print_frame_args): Only print dots for args if print frame-arguments
5857 is 'presence'.
5858 (frame_print_option_defs): New element for "frame-info".
5859 (get_user_print_what_frame_info): New function.
5860 (frame_show_address): Make non static. Move comment to stack.h.
5861 (print_frame_info_to_print_what): New function.
5862 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5863 to decide what to print.
5864 (backtrace_command_1): Handle the new print_frame_arguments_presence
5865 value.
5866 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5867 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5868 (py_print_frame): In non-mi mode, use LOCATION as default for
5869 print_what, similarly to frame information printed directly by
5870 backtrace command. Handle frame-info user option in non MI mode.
5871
5872 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5873
5874 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5875 Add case for debugging 32-bit target on 64-bit host. Revise
5876 comment.
5877
5878 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5879
5880 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5881 instead of find_function_entry_range_from_pc.
5882
5883 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5884
5885 * stack.c (find_frame_funname): Remove code which preferred
5886 minsym over symtab sym in "certain pathological cases".
5887
5888 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5889 parameter. Change type of "do_demangle" to bool.
5890 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5891 Pass suitable "prefer_sym_over_minsym" flag to
5892 build_address_symbolic(). Don't output "+" for negative offsets.
5893 * printcmd.c (print_address_symbolic): Update invocation of
5894 build_address_symbolic to include a "prefer_sym_over_minsym"
5895 flag.
5896 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5897 Restrict cases in which use of minimal symbol is preferred to that
5898 of a found symbol. Update comments.
5899
5900 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5901 for entry pc when entry pc is out of range for that FDE.
5902
5903 2019-07-26 Brian Callahan <bcallah@openbsd.org>
5904
5905 PR gdb/24839:
5906 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5907 type.
5908
5909 2019-07-25 Christian Biesinger <cbiesinger@google.com>
5910
5911 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5912 this function's Python signature.
5913
5914
5915 2019-07-24 Christian Biesinger <cbiesinger@google.com>
5916
5917 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5918 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5919 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5920 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5921 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5922
5923
5924 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5925
5926 * h8300-tdep.c (h8300_register_name_common): New.
5927 h8300_register_name): Use h8300_register_name_common.
5928 (h8300s_register_name): Likewise.
5929 (h8300sx_register_name): Likewise.
5930 (h8300h_register_nam): New.
5931 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5932
5933
5934 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5935
5936 * arm-tdep.c (arm_skip_cmse_entry): New function.
5937 (arm_is_sgstubs_section): New function.
5938 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5939
5940 2019-07-22 Tom Tromey <tom@tromey.com>
5941
5942 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5943 Don't self-assign.
5944
5945 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5946
5947 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5948 type_print.
5949
5950 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5951
5952 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5953 so that GDB doesn't match any msymbols when searching in the
5954 TYPES_DOMAIN.
5955 (print_symbol_info): Print using typedef_print or type_print based
5956 on the type of the symbol. Add updated FIXME comment moved from...
5957 (_initialize_symtab): ... move and update FIXME comment to above.
5958
5959 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5960
5961 * NEWS: Mention adding -q option to "info types".
5962 * symtab.c (struct info_types_options): New struct.
5963 (info_types_options_defs): New variable.
5964 (make_info_types_options_def_group): New function.
5965 (info_types_command): Use gdb::option framework to parse options.
5966 (info_types_command_completer): New function.
5967 (_initialize_symtab): Extend the help text on "info types" and
5968 register command completer.
5969
5970 2019-07-21 Christian Biesinger <cbiesinger@google.com>
5971
5972 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5973 (lookup_symbol_in_objfile): Change int to block_enum and add a
5974 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5975
5976 2019-07-20 Christian Biesinger <cbiesinger@google.com>
5977
5978 * MAINTAINERS (Write After Approval): Add self.
5979
5980 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
5981
5982 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5983 instruction to the dummy code region.
5984
5985 2019-07-19 Tom Tromey <tromey@adacore.com>
5986
5987 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5988 (ARGSUSED, PARAMS, __func__): Remove rules.
5989
5990 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5991
5992 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5993 * features/arm/arm-with-iwmmxt.c: Remove.
5994 * features/arm/arm-with-iwmmxt.xml: Remove.
5995 * features/arm/arm-with-m-fpa-layout.c: Remove.
5996 * features/arm/arm-with-m-fpa-layout.xml: Remove.
5997 * features/arm/arm-with-m-vfp-d16.c: Remove.
5998 * features/arm/arm-with-m-vfp-d16.xml: Remove.
5999 * features/arm/arm-with-m.c: Remove.
6000 * features/arm/arm-with-m.xml: Remove.
6001 * features/arm/arm-with-neon.c: Remove.
6002 * features/arm/arm-with-neon.xml: Remove.
6003 * features/arm/arm-with-vfpv2.c: Remove.
6004 * features/arm/arm-with-vfpv2.xml: Remove.
6005 * features/arm/arm-with-vfpv3.c: Remove.
6006 * features/arm/arm-with-vfpv3.xml: Remove.
6007
6008 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6009
6010 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6011
6012 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6013
6014 * arch/aarch32.c (aarch32_create_target_description): Create
6015 target descriptions using features.
6016 * arch/arm.c (arm_create_target_description)
6017 (arm_create_mprofile_target_description): Likewise.
6018 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6019
6020 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6021
6022 * Makefile.in: Add new files.
6023 * aarch32-tdep.c: New file.
6024 * aarch32-tdep.h: New file.
6025 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6026 Call aarch32_read_description.
6027 * arch/aarch32.c: New file.
6028 * arch/aarch32.h: New file.
6029 * arch/arm.c (arm_create_target_description)
6030 (arm_create_mprofile_target_description): New function.
6031 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6032 (arm_create_target_description)
6033 (arm_create_mprofile_target_description): New declaration.
6034 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6035 read_description functions.
6036 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6037 Likewise.
6038 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6039 * arm-tdep.c (tdesc_arm_list): New variable.
6040 (arm_register_g_packet_guesses): Call create description functions.
6041 (arm_read_description) (arm_read_mprofile_description): New
6042 function.
6043 * arm-tdep.h (arm_read_description)
6044 (arm_read_mprofile_description): Add declaration.
6045 * configure.tgt: Add new files.
6046
6047 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6048
6049 * top.c (new_ui_command): Open specified terminal just once.
6050
6051 2019-07-18 Tom Tromey <tromey@adacore.com>
6052
6053 * symtab.c (main_name): Constify return type.
6054 * symfile.c (set_initial_language): Update.
6055 * symtab.h (main_name): Constify return type.
6056
6057 2019-07-17 Tom Tromey <tom@tromey.com>
6058
6059 * tui/tui-winsource.c (tui_update_source_window)
6060 (tui_update_source_window_as_is)
6061 (tui_update_source_windows_with_line): Remove return.
6062 * tui/tui-disasm.c (tui_show_disassem)
6063 (tui_show_disassem_and_update_source): Remove return.
6064 * tui/tui.c (tui_reset): Remove return.
6065 * tui/tui-wingeneral.c
6066 (tui_check_and_display_highlight_if_needed): Remove return.
6067
6068 2019-07-17 Tom Tromey <tom@tromey.com>
6069
6070 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6071
6072 2019-07-17 Tom Tromey <tom@tromey.com>
6073
6074 * tui/tui-winsource.h (struct tui_exec_info_window)
6075 (struct tui_source_window_base): Move from tui-data.h.
6076 * tui/tui-winsource.c: Move many method definitions from
6077 elsewhere. Remove "structuring" comments.
6078 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6079 (tui_source_window_base::refresh_window): Move to
6080 tui-winsource.c.
6081 * tui/tui-win.c (tui_source_window_base::refresh_all)
6082 (tui_source_window_base::update_tab_width)
6083 (tui_source_window_base::set_new_height)
6084 (tui_source_window_base::do_make_visible_with_new_height): Move to
6085 tui-winsource.c.
6086 * tui/tui-source.h: Update.
6087 * tui/tui-source.c (tui_source_window_base::reset): Move to
6088 tui-winsource.c.
6089 * tui/tui-disasm.h: Update.
6090 * tui/tui-data.h (struct tui_exec_info_window): Move to
6091 tui-winsource.h.
6092 (struct tui_source_window_base): Likewise.
6093 * tui/tui-data.c (tui_source_window_base::clear_detail)
6094 (tui_source_window_base, ~tui_source_window_base): Move to
6095 tui-winsource.c.
6096
6097 2019-07-17 Tom Tromey <tom@tromey.com>
6098
6099 * tui/tui-win.c (tui_resize_all)
6100 (tui_source_window_base::update_tab_width)
6101 (tui_adjust_win_heights): Update.
6102 (tui_win_info::make_invisible_and_set_new_height): Rename from
6103 make_invisible_and_set_new_height.
6104 * tui/tui-data.h (struct tui_win_info)
6105 <make_invisible_and_set_new_height>: New method.
6106
6107 2019-07-17 Tom Tromey <tom@tromey.com>
6108
6109 * tui/tui.c: Update.
6110 * tui/tui-source.h (struct tui_source_window): Move from
6111 tui-data.h.
6112 * tui/tui-layout.c: Update.
6113 * tui/tui-disasm.c: Update.
6114 * tui/tui-data.h (struct tui_source_window): Move to
6115 tui-source.h.
6116
6117 2019-07-17 Tom Tromey <tom@tromey.com>
6118
6119 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6120 tui-data.h.
6121 * tui/tui-data.h (struct tui_disasm_window): Move to
6122 tui-disasm.h.
6123
6124 2019-07-17 Tom Tromey <tom@tromey.com>
6125
6126 * tui/tui-regs.h (struct tui_data_item_window): Move from
6127 tui-data.h.
6128 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6129 * tui/tui-data.h (struct tui_data_item_window): Move to
6130 tui-regs.h.
6131 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6132
6133 2019-07-17 Tom Tromey <tom@tromey.com>
6134
6135 * tui/tui.c: Update.
6136 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6137 (tui_cmd_window::max_height): Move to tui-command.c.
6138 * tui/tui-layout.c: Update.
6139 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6140 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6141 tui-command.c.
6142 * tui/tui-command.h (struct tui_cmd_window): Move from
6143 tui-data.h.
6144 * tui/tui-command.c: Remove "structuring" comments.
6145 (tui_cmd_window::clear_detail)
6146 (tui_cmd_window::do_make_visible_with_new_height)
6147 (tui_cmd_window::max_height): Move from elsewhere.
6148
6149 2019-07-17 Tom Tromey <tom@tromey.com>
6150
6151 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6152 Now static.
6153 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6154 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6155
6156 2019-07-17 Tom Tromey <tom@tromey.com>
6157
6158 * tui/tui.c: Update.
6159 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6160 tui-regs.c.
6161 * tui/tui-windata.h: Remove file.
6162 * tui/tui-windata.c: Remove file.
6163 * tui/tui-win.c (tui_data_window::set_new_height)
6164 (tui_data_window::do_make_visible_with_new_height): Move to
6165 tui-regs.c.
6166 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6167 * tui/tui-regs.c: Remove "structuring" comments.
6168 (tui_data_window::first_data_item_displayed)
6169 (tui_data_window::delete_data_content_windows)
6170 (tui_data_window::erase_data_content)
6171 (tui_data_window::display_all_data)
6172 (tui_data_window::refresh_all)
6173 (tui_data_window::do_scroll_vertical)
6174 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6175 (tui_data_window::do_make_visible_with_new_height)
6176 (tui_data_window::refresh_window): Move from elsewhere.
6177 (_initialize_tui_regs): Move to end of file.
6178 * tui/tui-layout.c: Update.
6179 * tui/tui-hooks.c: Update.
6180 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6181 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6182 tui-regs.c.
6183 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6184
6185 2019-07-17 Tom Tromey <tom@tromey.com>
6186
6187 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6188 seen.
6189
6190 2019-07-17 Tom Tromey <tom@tromey.com>
6191
6192 * tui/tui-win.c (tui_source_window_base::set_new_height)
6193 (tui_source_window_base::do_make_visible_with_new_height): Use
6194 m_has_locator field directly.
6195 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6196 method.
6197 (struct tui_source_window_base) <has_locator>: Likewise.
6198
6199 2019-07-17 Tom Tromey <tom@tromey.com>
6200
6201 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6202 Don't declare.
6203 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6204 Remove.
6205 * tui/tui-win.c (tui_source_window_base::set_new_height)
6206 (tui_source_window_base::set_new_height)
6207 (make_invisible_and_set_new_height)
6208 (tui_source_window_base::do_make_visible_with_new_height)
6209 (tui_source_window_base::do_make_visible_with_new_height):
6210 Update.
6211 * tui/tui-layout.c (show_source_disasm_command, show_data)
6212 (show_source_or_disasm_and_command): Update.
6213 * tui/tui-layout.c (show_layout): Update.
6214
6215 2019-07-17 Tom Tromey <tom@tromey.com>
6216
6217 * tui/tui-layout.c (make_data_window): Remove.
6218 (show_data): Unify creation and re-initialization cases.
6219
6220 2019-07-17 Tom Tromey <tom@tromey.com>
6221
6222 * tui/tui-layout.c (make_source_window, make_disasm_window):
6223 Remove.
6224 (show_data): Unify creation and re-initialization cases.
6225
6226 2019-07-17 Tom Tromey <tom@tromey.com>
6227
6228 * tui/tui-layout.c (make_command_window): Remove.
6229 (show_source_disasm_command, show_source_or_disasm_and_command):
6230 Unify creation and re-initialization cases.
6231
6232 2019-07-17 Tom Tromey <tom@tromey.com>
6233
6234 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6235 creation and re-initialization cases.
6236
6237 2019-07-17 Tom Tromey <tom@tromey.com>
6238
6239 * tui/tui-regs.c (tui_get_register): Return void.
6240
6241 2019-07-17 Tom Tromey <tom@tromey.com>
6242
6243 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6244 Simplify.
6245
6246 2019-07-17 Tom Tromey <tom@tromey.com>
6247
6248 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6249 resetting.
6250
6251 2019-07-17 Tom Tromey <tom@tromey.com>
6252
6253 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6254 * tui/tui-regs.c (tui_reg_layout): New function.
6255 (tui_show_registers, tui_reg_command): Use it.
6256 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6257 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6258 parameters.
6259 (tui_layout_command): Remove.
6260
6261 2019-07-17 Tom Tromey <tom@tromey.com>
6262
6263 * tui/tui-layout.h (tui/tui-layout): Return void.
6264 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6265
6266 2019-07-17 Tom Tromey <tom@tromey.com>
6267
6268 * tui/tui-layout.c (show_source_disasm_command, show_data):
6269 Update.
6270 (reset_locator): Remove.
6271 (show_source_or_disasm_and_command): Update.
6272
6273 2019-07-17 Tom Tromey <tom@tromey.com>
6274
6275 * tui/tui-source.c (tui_source_window_base::reset): Remove
6276 win_type parameter.
6277 * tui/tui-layout.c (make_command_window, make_source_window)
6278 (make_disasm_window, make_data_window)
6279 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6280 (reset_locator, show_source_or_disasm_and_command): Update.
6281 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6282 win_type parameter.
6283 (struct tui_source_window_base) <reset>: Likewise.
6284
6285 2019-07-17 Tom Tromey <tom@tromey.com>
6286
6287 * tui/tui-layout.c (show_source_disasm_command): Use
6288 reset_locator.
6289 (reset_locator): New function.
6290 (init_and_make_win): Remove.
6291 (show_source_or_disasm_and_command): Use reset_locator.
6292
6293 2019-07-17 Tom Tromey <tom@tromey.com>
6294
6295 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6296 condition.
6297 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6298 Remove condition.
6299 * tui/tui-source.c (tui_source_window_base::reset): New method.
6300 * tui/tui-layout.c (make_command_window): Don't call
6301 init_and_make_win.
6302 (make_source_window, make_disasm_window): Don't call
6303 make_source_or_disasm_window.
6304 (make_data_window): Don't call init_and_make_win. Change calling
6305 convention.
6306 (show_source_disasm_command, show_data): Simplify.
6307 (make_source_or_disasm_window): Remove.
6308 (show_source_or_disasm_and_command): Simplify.
6309 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6310 (struct tui_source_window_base) <reset>: Likewise.
6311 <execution_info>: Remove initializer.
6312 * tui/tui-data.c (tui_source_window_base): Initialize
6313 execution_info.
6314
6315 2019-07-17 Tom Tromey <tom@tromey.com>
6316
6317 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6318 variable.
6319
6320 2019-07-17 Tom Tromey <tom@tromey.com>
6321
6322 * tui/tui.c (tui_rl_other_window): Update.
6323 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6324 superclass method first. Always iterate over regs_content.
6325 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6326 method.
6327 * tui/tui-win.c (tui_set_focus_command): Update.
6328
6329 2019-07-17 Tom Tromey <tom@tromey.com>
6330
6331 * tui/tui-win.c (tui_set_focus_command): Rename from
6332 tui_set_focus. Call tui_enable.
6333 (tui_set_focus_command): Remove.
6334
6335 2019-07-17 Tom Tromey <tom@tromey.com>
6336
6337 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6338 refresh_window.
6339 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6340 touchwin.
6341 (tui_data_window::refresh_window): Call refresh_window on data
6342 items. Always call superclass refresh_window.
6343 (tui_win_info::refresh): Remove.
6344 (tui_source_window_base::refresh_window): Update.
6345 (tui_refresh_all): Update.
6346 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6347 refresh_window.
6348 (show_source_or_disasm_and_command): Likewise.
6349 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6350 (struct tui_source_window_base) <refresh>: Likewise.
6351
6352 2019-07-17 Tom Tromey <tom@tromey.com>
6353
6354 * tui/tui-winsource.c (tui_clear_source_content)
6355 (tui_show_source_content): Update.
6356 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6357 whether content is empty.
6358 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6359 Remove.
6360
6361 2019-07-17 Tom Tromey <tom@tromey.com>
6362
6363 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6364 window's contents.
6365 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6366 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6367
6368 2019-07-17 Tom Tromey <tom@tromey.com>
6369
6370 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6371 (struct tui_data_item_window): Update.
6372
6373 2019-07-17 Tom Tromey <tom@tromey.com>
6374
6375 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6376 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6377 defines.
6378
6379 2019-07-17 Tom Tromey <tom@tromey.com>
6380
6381 * tui/tui-winsource.h (tui_erase_source_content)
6382 (tui_clear_source_content): Remove "display_prompt" parameter.
6383 * tui/tui-winsource.c (tui_update_source_window_as_is)
6384 (tui_update_source_windows_with_addr): Update.
6385 (tui_clear_source_content): Remove "display_prompt" parameter.
6386 (tui_erase_source_content): Likewise. Simplify.
6387 (tui_show_source_content): Update.
6388 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6389 * tui/tui-stack.c (tui_show_frame_info): Update.
6390 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6391 Remove defines.
6392
6393 2019-07-17 Tom Tromey <tom@tromey.com>
6394
6395 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6396 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6397 parameter.
6398 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6399 parameter.
6400
6401 2019-07-17 Tom Tromey <tom@tromey.com>
6402
6403 * tui/tui-winsource.c (tui_clear_source_content)
6404 (tui_show_source_content, tui_show_exec_info_content)
6405 (tui_clear_exec_info_content): Update.
6406 * tui/tui-stack.c (tui_show_locator_content): Update.
6407 (tui_show_frame_info): Update.
6408 * tui/tui-source.h (tui_source_window): Don't declare.
6409 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6410 from tui_source_is_displayed.
6411 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6412 Remove field.
6413 (struct tui_source_window_base) <content_in_use>: New field. Now
6414 bool.
6415 (struct tui_source_window) <showing_source_p>: New method.
6416 (TUI_SRC_WIN): Change cast.
6417 * tui/tui-data.c (tui_initialize_static_data): Update.
6418
6419 2019-07-17 Tom Tromey <tom@tromey.com>
6420
6421 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6422 location_matches_p.
6423 * tui/tui-source.c (tui_source_window::location_matches_p): New
6424 method.
6425 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6426 method.
6427 * tui/tui-data.h (struct tui_source_window_base)
6428 <location_matches_p>: New method.
6429 (struct tui_source_window, struct tui_disasm_window)
6430 <location_matches_p>: Likewise.
6431
6432 2019-07-17 Tom Tromey <tom@tromey.com>
6433
6434 * tui/tui-win.c (tui_set_win_height_command): Rename from
6435 tui_set_win_height.
6436 (tui_set_win_height_command): Remove.
6437
6438 2019-07-17 Tom Tromey <tom@tromey.com>
6439
6440 * tui/tui-source.c (tui_source_window): New constructor. Add
6441 observer.
6442 (~tui_source_window): New destructor.
6443 (tui_source_window::style_changed): New method.
6444 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6445 (tui_attach_detach_observers): Update.
6446 * tui/tui-data.h (struct tui_source_window): Make constructor not
6447 inline. Add destructor.
6448 (struct tui_source_window) <style_changed>: New method.
6449 <m_observable>: New member.
6450
6451 2019-07-17 Tom Tromey <tom@tromey.com>
6452
6453 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6454 * tui/tui-win.c (tui_resize_all): Fix typo.
6455
6456 2019-07-17 Tom Tromey <tom@tromey.com>
6457
6458 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6459 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6460 (tui_refresh_all): Remove "list" parameter. Use foreach.
6461 * tui/tui-win.c (window_name_completer): Use foreach.
6462 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6463 (update_tab_width): Likewise.
6464 * tui/tui-layout.c (show_layout): Update.
6465 * tui/tui-data.h (class tui_window_iterator): New.
6466 (struct all_tui_windows): New.
6467 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6468
6469 2019-07-17 Tom Tromey <tom@tromey.com>
6470
6471 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6472 parameter. Don't reference globals.
6473 (tui_reg_command): Update.
6474
6475 2019-07-17 Tom Tromey <tom@tromey.com>
6476
6477 * tui/tui-regs.c (tui_show_registers): Simplify.
6478
6479 2019-07-17 Tom Tromey <tom@tromey.com>
6480
6481 * tui/tui-regs.c (tui_show_registers): Update.
6482 (tui_show_register_group): Add win_info parameter.
6483
6484 2019-07-17 Tom Tromey <tom@tromey.com>
6485
6486 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6487 Rename from tui_display_reg_element_at_line.
6488 (tui_data_window::display_registers_from_line): Update.
6489 * tui/tui-data.h (struct tui_data_window)
6490 <display_reg_element_at_line>: New method.
6491
6492 2019-07-17 Tom Tromey <tom@tromey.com>
6493
6494 * tui/tui-regs.h (tui_display_registers_from)
6495 (tui_display_registers_from_line): Don't declare.
6496 * tui/tui-windata.c (tui_data_window::display_all_data)
6497 (tui_data_window::refresh_all)
6498 (tui_data_window::do_scroll_vertical): Update.
6499 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6500 from tui_display_registers_from.
6501 (tui_display_reg_element_at_line): Update.
6502 (tui_data_window::display_registers_from_line): Rename from
6503 tui_display_registers_from_line.
6504 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6505 display_registers_from_line>: New methods.
6506
6507 2019-07-17 Tom Tromey <tom@tromey.com>
6508
6509 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6510 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6511 from tui_erase_data_content.
6512 (tui_data_window::display_all_data)
6513 (tui_data_window::refresh_all)
6514 (tui_data_window::do_scroll_vertical): Update.
6515 * tui/tui-regs.c (tui_show_registers): Update.
6516 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6517 New method.
6518
6519 2019-07-17 Tom Tromey <tom@tromey.com>
6520
6521 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6522 declare.
6523 * tui/tui-windata.c
6524 (tui_data_window::delete_data_content_windows): Rename from
6525 tui_delete_data_content_windows.
6526 (tui_data_window::display_all_data)
6527 (tui_data_window::do_scroll_vertical): Update.
6528 * tui/tui-data.h (struct tui_data_window)
6529 <delete_data_content_windows>: New method.
6530
6531 2019-07-17 Tom Tromey <tom@tromey.com>
6532
6533 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6534 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6535
6536 2019-07-17 Tom Tromey <tom@tromey.com>
6537
6538 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6539 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6540 from tui_display_all_data.
6541 * tui/tui-win.c
6542 (tui_data_window::do_make_visible_with_new_height): Update.
6543 * tui/tui-regs.c (tui_show_registers): Update.
6544 * tui/tui-layout.c (tui_set_layout): Update.
6545 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6546 method.
6547
6548 2019-07-17 Tom Tromey <tom@tromey.com>
6549
6550 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6551 * tui/tui-windata.c (tui_display_data_from): Remove.
6552 (tui_data_window::refresh_all): Update.
6553
6554 2019-07-17 Tom Tromey <tom@tromey.com>
6555
6556 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6557 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6558 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6559 tui_display_registers_from_line.
6560 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6561 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6562 "force_display" parameter.
6563
6564 2019-07-17 Tom Tromey <tom@tromey.com>
6565
6566 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6567 declare.
6568 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6569 Rename from tui_first_reg_element_no_inline.
6570 (tui_display_reg_element_at_line)
6571 (tui_display_registers_from_line): Update.
6572 * tui/tui-data.h (struct tui_data_window)
6573 <first_reg_element_no_inline>: New method.
6574
6575 2019-07-17 Tom Tromey <tom@tromey.com>
6576
6577 * tui/tui-windata.c (tui_display_data_from)
6578 (tui_data_window::do_scroll_vertical): Update.
6579 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6580 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6581 Rename from tui_line_from_reg_element_no.
6582 (tui_display_registers_from_line): Update.
6583 * tui/tui-data.h (struct tui_data_window)
6584 <line_from_reg_element_no>: New method.
6585
6586 2019-07-17 Tom Tromey <tom@tromey.com>
6587
6588 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6589 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6590 tui_last_regs_line_no.
6591 (tui_display_reg_element_at_line)
6592 (tui_display_registers_from_line): Update.
6593 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6594 method.
6595
6596 2019-07-17 Tom Tromey <tom@tromey.com>
6597
6598 PR tui/24722:
6599 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6600 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6601 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6602 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6603 (tui_update_breakpoint_info): Likewise.
6604 * tui/tui-hooks.c (tui_event_create_breakpoint)
6605 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6606 Update.
6607
6608 2019-07-17 Tom Tromey <tom@tromey.com>
6609
6610 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6611
6612 2019-07-17 Tom Tromey <tom@tromey.com>
6613
6614 * tui/tui-winsource.c (tui_update_source_window_as_is)
6615 (tui_update_source_windows_with_addr): Update.
6616 * tui/tui-source.h (tui_set_source_content)
6617 (tui_show_symtab_source): Add "win_info" parameter.
6618 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6619 parameter.
6620 (tui_show_symtab_source): Likewise.
6621
6622 2019-07-17 Tom Tromey <tom@tromey.com>
6623
6624 * tui/tui-wingeneral.c
6625 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6626
6627 2019-07-17 Tom Tromey <tom@tromey.com>
6628
6629 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6630 (struct tui_cmd_window) <can_scroll>: New method.
6631 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6632 method.
6633
6634 2019-07-17 Tom Tromey <tromey@adacore.com>
6635
6636 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6637 do_field_signed>: Rename. Change type of "value".
6638 * ui-out.c (ui_out::field_signed): Rename from field_int.
6639 Change type of "value".
6640 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6641 type of "value".
6642 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6643 do_field_int. Change type of "value".
6644 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6645 do_field_int. Change type of "value".
6646 * tracepoint.c (trace_status_mi, tfind_1)
6647 (print_one_static_tracepoint_marker): Update.
6648 * thread.c (print_thread_info_1, print_selected_thread_frame):
6649 Update.
6650 * stack.c (print_frame, print_frame_info): Update.
6651 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6652 Update.
6653 * source.c (print_source_lines_base): Update.
6654 * skip.c (info_skip_command): Update.
6655 * record-btrace.c (btrace_ui_out_decode_error)
6656 (btrace_call_history_src_line): Update.
6657 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6658 Update.
6659 * progspace.c (print_program_space): Update.
6660 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6661 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6662 do_field_int. Change type of "value".
6663 * mi/mi-out.c (mi_ui_out::do_table_begin)
6664 (mi_ui_out::do_table_header): Update.
6665 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6666 type of "value".
6667 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6668 (mi_cmd_data_list_changed_registers, output_register)
6669 (mi_cmd_data_read_memory, mi_load_progress)
6670 (mi_cmd_trace_frame_collected): Update.
6671 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6672 Update.
6673 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6674 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6675 (mi_cmd_var_list_children, varobj_update_one): Update.
6676 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6677 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6678 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6679 * inferior.c (print_inferior): Update.
6680 * gdb_bfd.c (print_one_bfd): Update.
6681 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6682 Update.
6683 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6684 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6685 do_field_int. Change type of "value".
6686 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6687 do_field_int. Change type of "value".
6688 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6689 (print_one_breakpoint_location, print_it_catch_fork)
6690 (print_one_catch_fork, print_it_catch_vfork)
6691 (print_one_catch_vfork, print_it_catch_solib)
6692 (print_it_catch_exec, print_it_ranged_breakpoint)
6693 (print_mention_watchpoint, print_mention_masked_watchpoint)
6694 (bkpt_print_it, update_static_tracepoint): Update.
6695 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6696 * break-catch-syscall.c (print_it_catch_syscall): Update.
6697 * ada-tasks.c (print_ada_task_info): Update.
6698 * ada-lang.c (print_it_exception, print_mention_exception):
6699 Update.
6700
6701 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6702
6703 PR breakpoints/24541
6704 * gdbarch.c: Regenerate.
6705 * gdbarch.h: Regenerate.
6706 * gdbarch.sh: Adjust return type and parameter types for
6707 'stap_adjust_register'.
6708 (i386_stap_adjust_register): Adjust signature and return new
6709 register name.
6710 * stap-probe.c (stap_parse_register_operand): Adjust use of
6711 'gdbarch_stap_adjust_register'.
6712
6713 2019-07-17 Tom Tromey <tromey@adacore.com>
6714
6715 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6716 declare VEC.
6717 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6718 std::vector.
6719 (struct s390_process_info): Add initializers.
6720 (s390_add_process): Use new.
6721 (s390_linux_nat_target::low_forget_process): Use delete.
6722 (s390_linux_nat_target::low_new_fork)
6723 (s390_linux_nat_target::stopped_by_watchpoint)
6724 (s390_linux_nat_target::low_prepare_to_resume)
6725 (s390_linux_nat_target::insert_watchpoint)
6726 (s390_linux_nat_target::insert_hw_breakpoint)
6727 (s390_linux_nat_target::remove_watchpoint)
6728 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6729
6730 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6731
6732 * aarch64-fbsd-nat.c: Include regcache.h.
6733 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6734 argument.
6735 (aarch64_fbsd_nat_target::fetch_registers)
6736 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6737 variable.
6738 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6739
6740 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6741
6742 * fbsd-nat.c: Include gdbarch.h.
6743
6744 2019-07-15 Tom Tromey <tromey@adacore.com>
6745
6746 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6747
6748 2019-07-15 Tom Tromey <tromey@adacore.com>
6749
6750 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6751 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6752 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6753 * cli-out.c (cli_ui_out::do_field_int): New method.
6754 * ui-out.c (ui_out::field_unsigned): New method.
6755 * symfile.c (generic_load): Use field_unsigned.
6756 (print_transfer_performance): Likewise.
6757 * record-btrace.c (ui_out_field_uint): Remove.
6758 (btrace_call_history_insn_range, btrace_call_history): Use
6759 field_unsigned.
6760 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6761 field_unsigned.
6762 * ui-out.h (class ui_out) <field_unsigned>: New method.
6763 <do_field_unsigned>: Likewise.
6764
6765 2019-07-15 Tom Tromey <tromey@adacore.com>
6766
6767 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6768 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6769 * target.c (flash_erase_command): Use field_string.
6770 * infrun.c (print_signal_received_reason): Use field_string.
6771 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6772 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6773 field_string.
6774 * ada-tasks.c (print_ada_task_info): Use field_string.
6775
6776 2019-07-15 Tom Tromey <tromey@adacore.com>
6777
6778 * target.c (flash_erase_command): Use field_core_addr.
6779 * symfile.c (generic_load): Use field_core_addr.
6780 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6781 Use field_core_addr.
6782 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6783 field_core_addr.
6784
6785 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6786
6787 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6788 value if its desired type is smaller than a CORE_ADDR and signed.
6789
6790 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6791
6792 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6793 of changes to field names, and use new is_reference field to
6794 decide if a property is a reference or not.
6795 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6796 field.
6797 (struct dwarf2_property_baton): Update header comment, rename
6798 'referenced_type' to 'property_type' and update comments.
6799 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6800 default property type, store in property baton, update to take
6801 accound of renamed field.
6802 (read_func_scope): Update call to attr_to_dynamic_prop.
6803 (read_array_type): Likewise.
6804 (dwarf2_per_cu_addr_sized_int_type): New function.
6805 (read_subrange_index_type): Move type finding code to
6806 dwarf2_per_cu_addr_sized_int_type.
6807 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6808 (dwarf2_per_cu_addr_type): New function.
6809 (set_die_type): Update calls to attr_to_dynamic_prop.
6810
6811 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6812
6813 * dwarf2read.c (read_subrange_index_type): New function.
6814 (read_subrange_type): Move code into new function and call it.
6815 * gdbtypes.c (create_range_type): Add some asserts.
6816
6817 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6818
6819 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6820 update return statements.
6821 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6822 declaration, and update comment to match.
6823 * gdbtypes.c (resolve_dynamic_array): Update call to
6824 dwarf2_evaluate_property to match new return type.
6825
6826 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6827
6828 * valarith.c (value_subscripted_rvalue): Change lowerbound
6829 parameter type from int to LONGEST.
6830 * value.h (value_subscripted_rvalue): Likewise in declaration.
6831
6832 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6833
6834 * cli/cli-utils.c (info_print_command_completer): New function.
6835 * cli/cli-utils.h: Add 'completer.h' include, and forward
6836 declaration for 'struct cmd_list_element'.
6837 (info_print_command_completer): Declare.
6838 * stack.c (_initialize_stack): Add completer for 'info locals' and
6839 'info args'.
6840 * symtab.c (_initialize_symtab): Add completer for 'info
6841 variables' and 'info functions'.
6842 * NEWS: Mention completion for additional info commands.
6843
6844 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6845
6846 * cli/cli-utils.c (extract_info_print_args): Delete.
6847 (extract_arg_maybe_quoted): Delete.
6848 (info_print_options_defs): New variable.
6849 (make_info_print_options_def_group): New function.
6850 (extract_info_print_options): Define new function.
6851 * cli/cli-utils.h (extract_info_print_args): Delete.
6852 (struct info_print_options): New structure.
6853 (extract_info_print_options): Declare new function.
6854 * stack.c (info_locals_command): Update to use new
6855 extract_info_print_options, also add a header comment.
6856 (info_args_command): Likewise.
6857 * symtab.c (info_variables_command): Likewise.
6858 (info_functions_command): Likewise.
6859
6860 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6861
6862 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6863 to extract string arguments.
6864 * common/common-utils.c (extract_string_maybe_quoted): New function.
6865 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6866
6867 2019-07-11 Tom Tromey <tromey@adacore.com>
6868
6869 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6870 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6871 * top.h (gdbinit): Don't declare.
6872 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6873 into...
6874 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6875 * top.c (gdb_init): Don't call init_cli_cmds.
6876 (gdbinit): Remove.
6877 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6878
6879 2019-07-11 Tom Tromey <tromey@adacore.com>
6880
6881 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6882 after it has been moved.
6883
6884 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6885
6886 * valops.c (value_must_coerce_to_target): Change return type to
6887 bool.
6888 * value.h (value_must_coerce_to_target): Likewise.
6889
6890 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
6891
6892 * breakpoint.c (is_hardware_watchpoint): Remove
6893 forward-declaration.
6894 (is_masked_watchpoint): Change return type to bool.
6895 (is_tracepoint): Likewise.
6896 (is_breakpoint): Likewise.
6897 (is_hardware_watchpoint): Likewise.
6898 (is_watchpoint): Likewise.
6899 (is_no_memory_software_watchpoint): Likewise.
6900 (is_catchpoint): Likewise.
6901 (breakpoint_1): Make FILTER parameter's return type bool.
6902 is_masked_watchpoint): Change return type to bool.
6903 (save_breakpoints): Make FILTER parameter's return type bool.
6904 * breakpoint.h (is_breakpoint): Change return type to bool.
6905 (is_watchpoint): Likewise.
6906 (is_catchpoint): Likewise.
6907 (is_tracepoint): Likewise.
6908
6909 2019-07-10 Tom Tromey <tom@tromey.com>
6910
6911 * defs.h: Don't include gdbarch.h.
6912 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6913 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6914 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6915 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6916 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6917 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6918 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6919 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6920 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6921 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6922 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6923 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6924 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6925 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6926 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6927 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6928 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6929 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6930 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6931 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6932 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6933 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6934 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6935 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6936 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6937 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6938 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6939
6940 2019-07-10 Tom Tromey <tromey@adacore.com>
6941
6942 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6943 * breakpoint.c (init_ada_exception_breakpoint): Register as
6944 bp_catchpoint.
6945 (print_one_breakpoint_location, print_one_breakpoint): Use
6946 is_ada_exception_catchpoint.
6947 * ada-lang.c (class ada_catchpoint_location): Pass
6948 bp_loc_software_breakpoint to bp_location constructor.
6949 (is_ada_exception_catchpoint): New function.
6950
6951 2019-07-10 Tom Tromey <tromey@adacore.com>
6952
6953 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6954 VEC.
6955 (struct arm_exidx_entry): New method operator<.
6956 (struct arm_exidx_data) <section_maps>: Change type.
6957 (arm_exidx_data_free): Remove.
6958 (arm_exidx_data_key): Change type. Move lower.
6959 (arm_exidx_new_objfile): Update.
6960 (arm_compare_exidx_entries): Remove.
6961 (arm_find_exidx_entry, _initialize_arm_tdep)
6962
6963 2019-07-10 Tom Tromey <tromey@adacore.com>
6964
6965 * solib-spu.c (ocl_program_data_key): Change type.
6966 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6967 Update.
6968
6969 2019-07-10 Tom Tromey <tromey@adacore.com>
6970
6971 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
6972 (struct solib_aix_inferior_data) <library_list>: Change type.
6973 (solib_aix_inferior_data_handle): Change type.
6974 (get_solib_aix_inferior_data): Update.
6975 (solib_aix_free_library_list): Remove.
6976 (library_list_start_library): Update.
6977 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6978 return type.
6979 (solib_aix_get_library_list)
6980 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6981 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6982
6983 2019-07-10 Tom Tromey <tromey@adacore.com>
6984
6985 * solib-dsbt.c (struct dsbt_info): Add initializers.
6986 (solib_dsbt_pspace_data): Change type.
6987 (dsbt_pspace_data_cleanup): Remove.
6988 (get_dsbt_info, _initialize_dsbt_solib): Update.
6989
6990 2019-07-10 Tom Tromey <tromey@adacore.com>
6991
6992 * spu-tdep.c (spu_overlay_data): Change type.
6993 (spu_get_overlay_table, spu_overlay_new_objfile)
6994 (_initialize_spu_tdep): Update.
6995
6996 2019-07-10 Tom Tromey <tromey@adacore.com>
6997
6998 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6999 destructor.
7000 (dbx_objfile_data_key): Change type and declare later.
7001 (DBX_SYMFILE_INFO): Rewrite.
7002 * dbxread.c (dbx_objfile_data_key): Change type.
7003 (dbx_symfile_init): Update.
7004 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7005 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7006 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7007
7008 2019-07-10 Tom Tromey <tromey@adacore.com>
7009
7010 * jit.c (jit_program_space_key): Change type. Move lower.
7011 (get_jit_program_space_data): Update.
7012 (jit_program_space_data_cleanup): Remove.
7013 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7014 Update.
7015 (struct jit_program_space_data): Add initializers.
7016
7017 2019-07-10 Tom Tromey <tromey@adacore.com>
7018
7019 * solib-darwin.c (struct darwin_info): Add initializers.
7020 (solib_darwin_pspace_data): Change type.
7021 (darwin_pspace_data_cleanup): Remove.
7022 (get_darwin_info, _initialize_darwin_solib): Update.
7023
7024 2019-07-10 Tom Tromey <tromey@adacore.com>
7025
7026 * remote-sim.c (struct sim_inferior_data): Add initializers,
7027 constructor, and destructor.
7028 (sim_inferior_data_key): Change type. Move lower.
7029 (check_for_duplicate_sim_descriptor): Update.
7030 (get_sim_inferior_data): Use new. Update.
7031 (~sim_inferior_data_cleanup): Rename from
7032 sim_inferior_data_cleanup. Simplify.
7033 (gdbsim_close_inferior, simulator_command)
7034 (sim_command_completer, _initialize_remote_sim): Update.
7035 (next_pid, INITIAL_PID): Move earlier.
7036
7037 2019-07-10 Tom Tromey <tromey@adacore.com>
7038
7039 * python/python-internal.h (create_thread_object): Return
7040 gdbpy_ref.
7041 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7042 * python/py-inferior.c (struct threadlist_entry): Add
7043 constructor.
7044 <thread_obj>: Now a gdbpy_ref.
7045 (thread_to_thread_object): Update.
7046 (add_thread_object): Use new.
7047 (delete_thread_object): Use delete.
7048 (infpy_threads): Update.
7049 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7050 GIL.
7051
7052 2019-07-10 Tom Tromey <tromey@adacore.com>
7053
7054 * valops.c (value_cast): Specialize error message for Ada.
7055
7056 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7057
7058 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7059
7060 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7061
7062 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7063 bpstat_should_step): Return bool, adjust comments.
7064 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7065 bpstat_should_step): Likewise.
7066
7067 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7068
7069 * features/Makefile: Use feature target descriptions for Arm.
7070 * features/arm/arm-core.c: Generate new file.
7071 * features/arm/arm-fpa.c: Likewise.
7072 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7073 * features/arm/arm-m-profile.c: Likewise.
7074 * features/arm/arm-vfpv2.c: Likewise.
7075 * features/arm/arm-vfpv3.c: Likewise.
7076 * features/arm/xscale-iwmmxt.c: Likewise.
7077 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7078
7079 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7080
7081 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7082 ptrace earlier.
7083
7084 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7085
7086 * features/aarch64-pauth.c: Regenerate.
7087
7088 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7089
7090 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7091 bool.
7092 (bpstat_what): Use false instead of 0.
7093
7094 2019-07-09 Pedro Alves <palves@redhat.com>
7095
7096 * break-catch-throw.c (is_exception_catchpoint): New.
7097 * breakpoint.c (print_one_breakpoint_location): New parameter
7098 'raw_loc'. Handle it. Use
7099 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7100 looking at the breakpoint's type.
7101 (print_one_breakpoint): If handling "maint info breakpoints", also
7102 print locations of exception catchpoints.
7103 * breakpoint.h (is_exception_catchpoint): Declare.
7104
7105 2019-07-09 Pedro Alves <palves@redhat.com>
7106
7107 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7108 "addr" field.
7109 (allocate_location_exception_catchpoint): New.
7110 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7111 (initialize_throw_catchpoint_ops): Install
7112 allocate_location_exception_catchpoint as allocate_location
7113 method.
7114 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7115 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7116 bp_loc_other.
7117 (breakpoint_address_is_meaningful): Delete.
7118 (bl_address_is_meaningful): New.
7119 (breakpoint_locations_match): Adjust comment.
7120 (bp_location_from_bp_type): New, factored out of...
7121 (bp_location::bp_location(breakpoint *)): ... this.
7122 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7123 factored out of...
7124 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7125 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7126 breakpoint_address_is_meaningful.
7127 (bp_locations_compare): Adjust comment.
7128 (update_global_location_list): Use bl_address_is_meaningful
7129 instead of breakpoint_address_is_meaningful.
7130 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7131 explicit.
7132 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7133 * python/py-breakpoint.c (bppy_get_location): No longer check
7134 whether location is null.
7135
7136 2019-07-09 Pedro Alves <palves@redhat.com>
7137
7138 PR c++/15468
7139 * breakpoint.c (print_one_breakpoint_location): Remove
7140 single-location assert.
7141
7142 2019-07-09 Tom Tromey <tom@tromey.com>
7143
7144 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7145 * configure: Rebuild.
7146 * configure.ac: Change common to gdbsupport.
7147 * gdbsupport: Rename from common.
7148 * acinclude.m4: Change common to gdbsupport.
7149 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7150 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7151 gdbsupport.
7152 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7153 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7154 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7155 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7156 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7157 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7158 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7159 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7160 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7161 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7162 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7163 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7164 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7165 coff-pe-read.c, command.h, compile/compile-c-support.c,
7166 compile/compile-c.h, compile/compile-cplus-symbols.c,
7167 compile/compile-cplus-types.c, compile/compile-cplus.h,
7168 compile/compile-loc2c.c, compile/compile.c, completer.c,
7169 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7170 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7171 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7172 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7173 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7174 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7175 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7176 features/aarch64-core.c, features/aarch64-fpu.c,
7177 features/aarch64-pauth.c, features/aarch64-sve.c,
7178 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7179 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7180 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7181 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7182 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7183 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7184 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7185 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7186 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7187 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7188 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7189 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7190 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7191 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7192 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7193 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7194 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7195 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7196 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7197 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7198 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7199 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7200 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7201 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7202 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7203 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7204 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7205 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7206 minsyms.c, mips-linux-tdep.c, namespace.h,
7207 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7208 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7209 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7210 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7211 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7212 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7213 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7214 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7215 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7216 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7217 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7218 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7219 procfs.c, producer.c, progspace.h, psymtab.h,
7220 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7221 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7222 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7223 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7224 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7225 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7226 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7227 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7228 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7229 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7230 target-memory.c, target.c, target.h, target/waitstatus.c,
7231 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7232 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7233 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7234 unittests/array-view-selftests.c,
7235 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7236 unittests/common-utils-selftests.c,
7237 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7238 unittests/format_pieces-selftests.c,
7239 unittests/function-view-selftests.c,
7240 unittests/lookup_name_info-selftests.c,
7241 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7242 unittests/mkdir-recursive-selftests.c,
7243 unittests/observable-selftests.c,
7244 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7245 unittests/parse-connection-spec-selftests.c,
7246 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7247 unittests/scoped_fd-selftests.c,
7248 unittests/scoped_mmap-selftests.c,
7249 unittests/scoped_restore-selftests.c,
7250 unittests/string_view-selftests.c, unittests/style-selftests.c,
7251 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7252 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7253 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7254 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7255 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7256 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7257
7258 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7259
7260 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7261 bool value.
7262 (decode_digits_ordinary): Set explicit_line field in sal.
7263 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7264 symtab_and_line that was set on an explicit line number in
7265 assembler code. Do always update the recorded symtab and line if
7266 we do skip the prologue.
7267
7268 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7269
7270 * breakpoint.c (set_breakpoint_location_function): Remove
7271 explicit_loc parameter.
7272 (momentary_breakpoint_from_master): Update call to
7273 set_breakpoint_location_function.
7274 (add_location_to_breakpoint): Likewise.
7275
7276 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7277
7278 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7279 required features based on default bfd type when no specific bfd
7280 is present.
7281
7282 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7283
7284 * NEWS: Mention that GDB printf and eval commands can now print
7285 C-style and Ada-style convenience var strings without
7286 calling the inferior.
7287 * printcmd.c (printf_c_string): Locally print GDB internal var
7288 instead of transiting via the inferior.
7289 (printf_wide_c_string): Likewise.
7290
7291 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7292
7293 PR breakpoints/25011
7294 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7295
7296 2019-07-04 Tom Tromey <tom@tromey.com>
7297
7298 PR tui/24724:
7299 * tui/tui-winsource.c (tui_clear_source_content): Update.
7300 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7301 (tui_update_breakpoint_info): Update.
7302 (tui_set_exec_info_content): Update.
7303 * tui/tui-source.c (tui_set_source_content_nil): Update.
7304 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7305 has_break.
7306 * tui/tui-data.h (enum tui_bp_flag): New.
7307 (tui_bp_flags): New enum flags type.
7308 (struct tui_source_element) <break_mode>: Change type. Rename
7309 from has_break.
7310 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7311 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7312 constants.
7313 * tui/tui-winsource.h: Fix comment.
7314
7315 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7316
7317 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7318 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7319 (store_fpregs_to_thread)
7320 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7321 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7322 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7323 (IWMMXT_REGS_SIZE): Add define.
7324 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7325 (fetch_vfp_regs, store_vfp_regs)
7326 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7327 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7328
7329 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7330
7331 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7332 defines.
7333 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7334 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7335 (ARM_INT_REGISTER_SIZE): ...to this.
7336 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7337 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7338 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7339 (arm_linux_collect_gregset, supply_nwfpe_register)
7340 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7341 defines.
7342 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7343 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7344 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7345 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7346 (arm_return_in_memory, arm_store_return_value)
7347 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7348 (arm_record_ld_st_multiple): Likewise.
7349 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7350 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7351
7352 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7353
7354 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7355 AARCH64_DISPLACED_MODIFIED_INSNS.
7356 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7357 (aarch64_displaced_step_copy_insn): Likewise.
7358 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7359 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7360 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7361 ARM_DISPLACED_MODIFIED_INSNS.
7362 * arm-tdep.c (arm_gdbarch_init): Likewise.
7363 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7364 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7365 (struct arm_displaced_step_closure): Use
7366 ARM_DISPLACED_MODIFIED_INSNS.
7367
7368 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7369
7370 * features/Makefile: Remove unused xml files.
7371 * features/aarch64.xml: Remove.
7372 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7373 * features/i386/amd64-avx-avx512.xml: Remove.
7374 * features/i386/amd64-avx-linux.xml: Remove.
7375 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7376 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7377 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7378 * features/i386/amd64-avx-mpx.xml: Remove.
7379 * features/i386/amd64-avx.xml: Remove.
7380 * features/i386/amd64-linux.xml: Remove.
7381 * features/i386/amd64-mpx-linux.xml: Remove.
7382 * features/i386/amd64-mpx.xml: Remove.
7383 * features/i386/amd64.xml: Remove.
7384 * features/i386/i386-avx-avx512-linux.xml: Remove.
7385 * features/i386/i386-avx-avx512.xml: Remove.
7386 * features/i386/i386-avx-linux.xml: Remove.
7387 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7388 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7389 * features/i386/i386-avx-mpx-linux.xml: Remove.
7390 * features/i386/i386-avx-mpx.xml: Remove.
7391 * features/i386/i386-avx.xml: Remove.
7392 * features/i386/i386-linux.xml: Remove.
7393 * features/i386/i386-mmx-linux.xml: Remove.
7394 * features/i386/i386-mmx.xml: Remove.
7395 * features/i386/i386-mpx-linux.xml: Remove.
7396 * features/i386/i386-mpx.xml: Remove.
7397 * features/i386/i386.xml: Remove.
7398 * features/i386/x32-avx-avx512-linux.xml: Remove.
7399 * features/i386/x32-avx-linux.xml: Remove.
7400 * features/i386/x32-linux.xml: Remove.
7401
7402 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7403
7404 * regformats/aarch64.dat: Remove.
7405 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7406 * regformats/i386/amd64-avx-linux.dat: Remove.
7407 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7408 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7409 * regformats/i386/amd64-linux.dat: Remove.
7410 * regformats/i386/amd64-mpx-linux.dat: Remove.
7411 * regformats/i386/amd64.dat: Remove.
7412 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7413 * regformats/i386/i386-avx-linux.dat: Remove.
7414 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7415 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7416 * regformats/i386/i386-linux.dat: Remove.
7417 * regformats/i386/i386-mmx-linux.dat: Remove.
7418 * regformats/i386/i386-mpx-linux.dat: Remove.
7419 * regformats/i386/i386.dat: Remove.
7420 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7421 * regformats/i386/x32-avx-linux.dat: Remove.
7422 * regformats/i386/x32-linux.dat: Remove.
7423
7424 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7425
7426 * aarch64-tdep.c: Remove xml self tests.
7427 * amd64-linux-tdep.c: Likewise.
7428 * amd64-tdep.c: Likewise.
7429 * i386-linux-tdep.c: Likewise.
7430 * i386-tdep.c: Likewise.
7431
7432 2019-07-03 Pedro Alves <palves@redhat.com>
7433
7434 PR cli/24732
7435 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7436 (pipe_cmd_option_defs): New.
7437 (make_pipe_cmd_options_def_group): New.
7438 (pipe_command): Use gdb::option::process_options.
7439 (pipe_command_completer): New function.
7440 (_initialize_cli_cmds): Install completer for "pipe" command.
7441
7442 2019-07-03 Pedro Alves <palves@redhat.com>
7443
7444 * cli/cli-option.c (union option_value) <string>: New field.
7445 (struct option_def_and_value): Add ctor, move ctor, dtor and
7446 use DISABLE_COPY_AND_ASSIGN.
7447 (option_def_and_value::clear_value): New.
7448 (parse_option, save_option_value_in_ctx, get_val_type_str)
7449 (add_setshow_cmds_for_options): Handle var_string.
7450 * cli-option.h (union option_def::var_address) <string>: New
7451 field.
7452 (struct string_option_def): New.
7453 * maint-test-options.c (struct test_options_opts): Add default
7454 ctor and use DISABLE_COPY_AND_ASSIGN.
7455 <string_opt>: New field.
7456 (test_options_opts::~test_options_opts): New.
7457 (test_options_opts::dump): Also dump "-string".
7458 (test_options_option_defs): Install "string.
7459
7460 2019-07-03 Pedro Alves <palves@redhat.com>
7461
7462 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7463 option_value with a null enumeration.
7464 (complete_options): Save the option values in the context.
7465 (save_option_value_in_ctx): New, factored out from ...
7466 (process_options): ... here.
7467 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7468 of the function.
7469 * maint-test-options.c (test_options_opts::dump): New, factored
7470 out from ...
7471 (maintenance_test_options_command_mode): ... here.
7472 (maintenance_test_options_command_completion_result): Delete.
7473 (maintenance_test_options_command_completion_text): Update
7474 comment.
7475 (maintenance_show_test_options_completion_result): Change
7476 prototype. Just print
7477 maintenance_test_options_command_completion_text.
7478 (save_completion_result): New.
7479 (maintenance_test_options_completer_mode): Pass options context to
7480 complete_options, and then save a dump.
7481 (_initialize_maint_test_options): Use add_cmd to install "maint
7482 show test-options-completion-result".
7483
7484 2019-07-03 Pedro Alves <palves@redhat.com>
7485
7486 * NEWS (New commands): Mention "with" and "maint with".
7487 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7488 (with_command, with_command_completer): New.
7489 (pipe_command): Adjust to new repeat_previous
7490 interface.
7491 (_initialize_cli_cmds): Install the "with" command and its "w"
7492 alias.
7493 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7494 declarations.
7495 * cli/cli-setshow.c (parse_cli_var_uinteger)
7496 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7497 argument strings for all var_types.
7498 (get_setshow_command_value_string): New, factored out from ...
7499 (do_show_command): ... this.
7500 * cli/cli-setshow.h: Include <string>.
7501 (get_setshow_command_value_string): Declare.
7502 * command.h (repeat_previous): Now returns const char *. Adjust
7503 comment.
7504 * maint.c: Include "cli/cli-cmds.h".
7505 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7506 (_initialize_maint_cmds): Register the "maintenance with" command.
7507 * top.c (repeat_previous): Move bits from pipe_command here:
7508 Return the saved command line, if any; error out if there's no
7509 command to relaunch.
7510
7511 2019-07-03 Pedro Alves <palves@redhat.com>
7512
7513 * NEWS (New commands): Mention "maint set/show test-settings"
7514 instead of "maint test-settings".
7515 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7516 (maintenance_test_settings_set_list): Rename to ...
7517 (maintenance_set_test_settings_list): ... this.
7518 (maintenance_test_settings_show_list): Rename to ...
7519 (maintenance_show_test_settings_list): ... this.
7520 (maintenance_test_settings_cmd): Delete.
7521 (maintenance_test_settings_set_cmd): ...
7522 (maintenance_set_test_settings_cmd): ... this.
7523 (maintenance_test_settings_show_cmd): ...
7524 (maintenance_show_test_settings_cmd): ... this.
7525 (maintenance_test_settings_show_value_cmd):
7526 (maintenance_show_test_settings_value_cmd): ... this.
7527 (_initialize_maint_test_settings): No longer install the "maint
7528 test-settings" prefix command. Rename "maint test-settings set"
7529 to "maint set test-settings", and "maint test-settings show" to
7530 "maint show test-settings". Adjust all subcommands.
7531
7532 2019-07-03 Pedro Alves <palves@redhat.com>
7533
7534 * maint-test-settings.c: Fix file's intro comment. Replace all
7535 references to "test-options" with references to "test-settings",
7536 in comments.
7537
7538 2019-07-03 Pedro Alves <palves@redhat.com>
7539
7540 * maint-test-settings.c (maintenance_test_settings_xxx)
7541 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7542 New.
7543 (maintenance_test_settings_enums): Use them.
7544 (maintenance_test_settings_enum): Default to
7545 maintenance_test_settings_xxx.
7546 (_initialize_maint_test_settings): Initialize
7547 MAINTENANCE_TEST_SETTINGS_FILENAME.
7548
7549 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7550
7551 * breakpoint.h (remove_breakpoints_inf): Change return type to
7552 void, move function documentation here.
7553 * breakpoint.c (remove_breakpoints_inf): Change return type to
7554 void, move function documentation to header.
7555
7556 2019-07-02 Pedro Alves <palves@redhat.com>
7557
7558 * NEWS (Completion improvements): Mention "info threads".
7559 * thread.c (struct info_threads_opts, info_threads_option_defs)
7560 (make_info_threads_options_def_group): New.
7561 (info_threads_command): Use gdb::option::process_options.
7562 (info_threads_command_completer): New.
7563 (_initialize_thread): Use gdb::option::build_help to build the
7564 help text for "info threads".
7565
7566 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7567
7568 * defs.h (generic_load): Move from here...
7569 * symfile.h (generic_load): ... to here. Rename name parameter
7570 to args.
7571 * symfile.c (generic_load): Add comment.
7572
7573 2019-07-01 Tom Tromey <tromey@adacore.com>
7574
7575 * dwarf2read.c
7576 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7577 declaration of without_params. Fix formatting.
7578
7579 2019-07-01 Tom Tromey <tromey@adacore.com>
7580
7581 * ada-exp.y (find_primitive_type): Update.
7582 * ada-lang.h (ada_lookup_symbol): Update.
7583 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7584 parameter.
7585 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7586
7587 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7588
7589 PR breakpoints/24541
7590 * gdbarch.c: Regenerate.
7591 * gdbarch.h: Regenerate.
7592 * gdbarch.sh: Add 'stap_adjust_register'.
7593 * i386-tdep.c: Include '<unordered_set>'.
7594 (i386_stap_adjust_register): New function.
7595 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7596 * stap-probe.c (stap_parse_register_operand): Call
7597 'gdbarch_stap_adjust_register'.
7598
7599 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7600
7601 PR python/24742
7602 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7603 * python/python.c (do_start_initialization): Use 'xmalloc'
7604 instead of 'PyMem_Malloc'.
7605
7606 2019-06-28 Tom Tromey <tromey@adacore.com>
7607
7608 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7609 for Ada.
7610
7611 2019-06-27 Tom Tromey <tromey@adacore.com>
7612
7613 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7614 objfile_key.
7615 (arm_find_mapping_symbol, arm_record_special_symbol)
7616 (_initialize_arm_tdep): Update.
7617 (arm_objfile_data_free): Remove.
7618
7619 2019-06-27 Tom Tromey <tromey@adacore.com>
7620
7621 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7622 to cp_print_static_field.
7623
7624 2019-06-26 Tom Tromey <tromey@adacore.com>
7625
7626 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7627 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7628 declare.
7629
7630 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7631
7632 * features/aarch64-core.c (create_feature_aarch64_core):
7633 Regenerate.
7634 * features/aarch64-core.xml: Add cpsr flags.
7635
7636 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7637
7638 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7639 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7640
7641 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7642
7643 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7644 field.
7645 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7646 use.
7647 (arm_record_special_symbol): Don't insert new symbol in sorted
7648 position, push it at the end.
7649
7650 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7651
7652 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7653 (arm_mapping_symbol_s): Remove.
7654 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7655 (arm_mapping_symbol_vec): New typedef.
7656 (struct arm_per_objfile): Add constructor.
7657 <section_maps>: Change type to
7658 std::unique_ptr<arm_mapping_symbol_vec[]>.
7659 (arm_compare_mapping_symbols): Remove.
7660 (arm_find_mapping_symbol): Adjust to section_maps type change.
7661 (arm_objfile_data_free): Call delete on arm_per_objfile.
7662 (arm_record_special_symbol): Adjust to section_maps type change.
7663 Allocate arm_per_objfile with new.
7664
7665 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7666
7667 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7668 with the command prefix.
7669
7670 2019-06-25 Tom Tromey <tom@tromey.com>
7671
7672 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7673 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7674
7675 2019-06-25 Tom Tromey <tom@tromey.com>
7676
7677 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7678 type.
7679 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7680 protected.
7681
7682 2019-06-25 Tom Tromey <tom@tromey.com>
7683
7684 * tui/tui-winsource.c
7685 (tui_source_window_base::set_is_exec_point_at): Add check against
7686 LOA_ADDRESS.
7687
7688 2019-06-25 Tom Tromey <tom@tromey.com>
7689
7690 * tui/tui-source.c (tui_set_source_content): Don't check before
7691 xfree.
7692 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7693
7694 2019-06-25 Tom Tromey <tom@tromey.com>
7695
7696 * tui/tui-winsource.h (tui_update_source_window_as_is)
7697 (tui_alloc_source_buffer, tui_line_is_displayed)
7698 (tui_addr_is_displayed): Change type of win_info.
7699 * tui/tui-winsource.c (tui_update_source_window_as_is)
7700 (tui_clear_source_content, tui_show_source_line)
7701 (tui_show_source_content, tui_source_window_base::refill)
7702 (tui_source_window_base::set_is_exec_point_at)
7703 (tui_source_window_base::set_is_exec_point_at)
7704 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7705 (tui_alloc_source_buffer, tui_line_is_displayed)
7706 (tui_addr_is_displayed): Change type of win_info. Update.
7707 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7708 (tui_source_window_base::do_make_visible_with_new_height):
7709 Update.
7710 * tui/tui-source.c (tui_set_source_content)
7711 (tui_set_source_content_nil)
7712 (tui_source_window::do_scroll_vertical): Update.
7713 * tui/tui-layout.c (show_layout): Update.
7714 * tui/tui-disasm.c (tui_set_disassem_content)
7715 (tui_disasm_window::do_scroll_vertical): Update.
7716 * tui/tui-data.h (tui_win_content): Remove.
7717 (struct tui_gen_win_info) <content, content_size>: Remove.
7718 (struct tui_source_element): Add initializers and destructor.
7719 (union tui_which_element, struct tui_win_element): Remove.
7720 (struct tui_source_window_base) <content>: New field.
7721 (struct tui_data_window): Remove destructor.
7722 (tui_alloc_content, tui_free_win_content)
7723 (tui_free_all_source_wins_content): Don't declare.
7724 * tui/tui-data.c (tui_initialize_static_data): Update.
7725 (init_content_element, tui_alloc_content): Remove.
7726 (~tui_gen_win_info): Update.
7727 (~tui_data_window, tui_free_all_source_wins_content)
7728 (tui_free_win_content, free_content, free_content_elements):
7729 Remove.
7730
7731 2019-06-25 Tom Tromey <tom@tromey.com>
7732
7733 * tui/tui-winsource.h (tui_clear_source_content)
7734 (tui_erase_source_content, tui_show_source_content): Change type
7735 of win_info.
7736 * tui/tui-winsource.c (tui_clear_source_content)
7737 (tui_erase_source_content, tui_show_source_content): Change type
7738 of win_info.
7739 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7740 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7741 win_info.
7742 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7743 win_info.
7744 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7745
7746 2019-06-25 Tom Tromey <tom@tromey.com>
7747
7748 * tui/tui-winsource.c (tui_clear_source_content)
7749 (tui_source_window_base::set_is_exec_point_at): Update.
7750 * tui/tui-source.c (tui_set_source_content_nil): Update.
7751 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7752 a bool.
7753 * tui/tui-data.c (init_content_element): Update.
7754
7755 2019-06-25 Tom Tromey <tom@tromey.com>
7756
7757 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7758 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7759 * tui/tui-layout.c (init_and_make_win): Update.
7760 * tui/tui.h (enum tui_win_type): Update.
7761 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7762 tui_win_is_auxillary.
7763 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7764 tui_win_is_auxillary.
7765
7766 2019-06-25 Tom Tromey <tom@tromey.com>
7767
7768 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7769 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7770 (tui_delete_data_content_windows, tui_display_all_data)
7771 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7772 Update.
7773 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7774 * tui/tui-regs.c (tui_last_regs_line_no)
7775 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7776 (tui_show_registers): Update.
7777 (tui_show_register_group): Return void. Update.
7778 (tui_display_registers_from, tui_display_reg_element_at_line)
7779 (tui_display_registers_from_line, tui_check_register_values):
7780 Update.
7781 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7782 member.
7783 (struct tui_data_window) <regs_content>: Now a std::vector.
7784 <regs_content_count>: Remove.
7785 (tui_add_content_elements, tui_free_data_content): Don't declare.
7786 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7787 (init_content_element): Remove DATA_WIN case. Add assert.
7788 (tui_add_content_elements): Remove.
7789 (tui_data_window): Update.
7790 (tui_free_data_content): Remove.
7791 (free_content_elements): Remove DATA_WIN case.
7792
7793 2019-06-25 Tom Tromey <tom@tromey.com>
7794
7795 * tui/tui-data.c (tui_data_item_window): Update.
7796 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7797 * tui/tui-windata.c (tui_display_all_data)
7798 (tui_display_data_from_line): Update.
7799 (tui_check_data_values): Remove.
7800 * tui/tui-regs.c (tui_show_register_group)
7801 (tui_display_reg_element_at_line): Update.
7802 * tui/tui-hooks.c (tui_register_changed)
7803 (tui_refresh_frame_and_register_information): Call
7804 tui_check_register_values.
7805 * tui/tui-data.h (struct tui_data_window) <data_content,
7806 data_content_count, data_type>: Remove.
7807 (enum tui_data_type): Remove.
7808
7809 * tui/tui-data.c (tui_data_window::clear_detail)
7810 (~tui_data_window): Update.
7811
7812 2019-06-25 Tom Tromey <tom@tromey.com>
7813
7814 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7815 declare.
7816 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7817 Rename from tui_first_data_item_displayed. Update.
7818 (tui_data_window::refresh_all)
7819 (tui_data_window::do_scroll_vertical): Update.
7820 * tui/tui-data.h (struct tui_data_window)
7821 <first_data_item_displayed>: Declare new method.
7822
7823 2019-06-25 Tom Tromey <tom@tromey.com>
7824
7825 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7826 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7827 contents...
7828 (tui_initialize_static_data): ...here.
7829
7830 2019-06-25 Tom Tromey <tom@tromey.com>
7831
7832 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7833 (tui_display_registers_from, tui_check_register_values): Update.
7834 (tui_display_register): Remove win_info parameter; update.
7835 (tui_get_register): Change type of parameters.
7836 * tui/tui-data.h (struct tui_data_element): Remove.
7837 (union tui_which_element) <data>: Remove.
7838 <data_window>: Change type.
7839 (struct tui_data_item_window): New.
7840 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7841 case. Add assert.
7842 (~tui_data_item_window): New destructor.
7843 (free_content_elements): Remove DATA_ITEM_WIN case.
7844
7845 2019-06-25 Tom Tromey <tom@tromey.com>
7846
7847 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7848 Remove.
7849
7850 2019-06-25 Tom Tromey <tom@tromey.com>
7851
7852 * tui/tui-data.h (struct tui_command_element): Remove.
7853 (union tui_which_element) <command>: Remove.
7854 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7855 assert.
7856 (free_content_elements): Remove CMD_WIN case.
7857
7858 2019-06-25 Tom Tromey <tom@tromey.com>
7859
7860 * tui/tui-layout.c (tui_set_layout): Update.
7861 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7862 * tui/tui-data.c (layout_def): Update.
7863
7864 2019-06-25 Tom Tromey <tom@tromey.com>
7865
7866 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7867 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7868 (tui_source_window_base::set_new_height): Update.
7869 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7870 Update.
7871 (tui_set_locator_fullname, tui_set_locator_info)
7872 (tui_show_frame_info): Update.
7873 * tui/tui-source.c (tui_set_source_content)
7874 (tui_source_is_displayed): Update.
7875 * tui/tui-layout.c (show_source_disasm_command, show_data)
7876 (show_source_or_disasm_and_command): Update.
7877 * tui/tui-disasm.c (tui_set_disassem_content)
7878 (tui_get_begin_asm_address): Update.
7879 * tui/tui-data.h (struct tui_locator_element): Remove.
7880 (union tui_which_element) <locator>: Remove.
7881 (struct tui_locator_window): New.
7882 (tui_locator_win_info_ptr): Change return type.
7883 * tui/tui-data.c (_locator): Change type.
7884 (tui_locator_win_info_ptr): Change return type.
7885 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7886 (tui_alloc_content): Add assert.
7887
7888 2019-06-25 Tom Tromey <tom@tromey.com>
7889
7890 * tui/tui-winsource.c
7891 (tui_exec_info_window::maybe_allocate_content): New method.
7892 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7893 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7894 (make_source_or_disasm_window): Add cast.
7895 * tui/tui-data.h (union tui_which_element) <simple_string>:
7896 Remove.
7897 (struct tui_source_info): New.
7898 (struct tui_source_window_base) <execution_info>: Change type.
7899 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7900 case, and add assert.
7901 (tui_alloc_content): Add assert.
7902
7903 2019-06-25 Tom Tromey <tom@tromey.com>
7904
7905 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7906 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7907 * tui/tui-data.c (tui_alloc_win_info): Remove.
7908
7909 2019-06-25 Tom Tromey <tom@tromey.com>
7910
7911 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7912 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7913 can_highlight.
7914
7915 2019-06-25 Tom Tromey <tom@tromey.com>
7916
7917 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7918 make_visible_with_new_height method.
7919 (tui_win_info::make_visible_with_new_height): New method.
7920 (tui_source_window_base::do_make_visible_with_new_height)
7921 (tui_data_window::do_make_visible_with_new_height)
7922 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7923 (make_visible_with_new_height): Remove.
7924 (tui_resize_all, tui_adjust_win_heights): Use
7925 make_visible_with_new_height method.
7926 * tui/tui-data.h (struct tui_win_info)
7927 <do_make_visible_with_new_height, make_visible_with_new_height>:
7928 New methods.
7929 (struct tui_source_window_base, struct tui_data_window)
7930 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7931 methods.
7932
7933 2019-06-25 Tom Tromey <tom@tromey.com>
7934
7935 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7936 method.
7937 (update_tab_width): Call update_tab_width method.
7938 * tui/tui-data.h (struct tui_win_info)
7939 (struct tui_source_window_base) <update_tab_width>: New methods.
7940
7941 2019-06-25 Tom Tromey <tom@tromey.com>
7942
7943 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7944 parameter.
7945 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7946 parameter.
7947 (tui_gen_win_info::make_visible): Update.
7948 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7949 parameter.
7950 * tui/tui-data.h (enum tui_box): New enum.
7951 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7952
7953 2019-06-25 Tom Tromey <tom@tromey.com>
7954
7955 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7956 init_and_make_win for EXEC_INFO_WIN.
7957 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7958 longer inline.
7959 (struct tui_win_info) <~tui_win_info>: Inline.
7960 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7961 Don't declare.
7962 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7963 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7964 Remove.
7965 (tui_initialize_static_data): Update.
7966 (~tui_gen_win_info): Handle more cleanup here.
7967 (~tui_source_window_base): Delete "execution_info".
7968 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7969
7970 2019-06-25 Tom Tromey <tom@tromey.com>
7971
7972 * tui/tui-layout.c (make_command_window): Don't set
7973 can_highlight.
7974 (show_source_disasm_command): Call the reset method.
7975 (show_data): Don't set can_highlight. Call the reset method.
7976 (tui_gen_win_info::reset): Rename from init_gen_win_info
7977 (init_and_make_win): Simplify. Return tui_gen_win_info.
7978 (show_source_or_disasm_and_command): Call the reset method.
7979 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7980 (struct tui_cmd_window): Set can_highlight.
7981
7982 2019-06-25 Tom Tromey <tom@tromey.com>
7983
7984 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7985 from make_visible.
7986 (tui_make_visible, tui_make_invisible): Rewrite.
7987 (tui_win_info::make_visible): Remove.
7988 (tui_source_window_base::make_visible): Update.
7989 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7990 method. Moved from...
7991 (struct tui_win_info) <make_visible>: ...here.
7992
7993 2019-06-25 Tom Tromey <tom@tromey.com>
7994
7995 * tui/tui-winsource.c
7996 (tui_source_window_base::do_scroll_horizontal): Remove direction
7997 parameter.
7998 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7999 direction parameter.
8000 * tui/tui-win.c (tui_win_info::forward_scroll)
8001 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8002 (tui_win_info::right_scroll): Update.
8003 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8004 direction parameter.
8005 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8006 direction parameter.
8007 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8008 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8009 Remove direction parameter.
8010 (struct tui_source_window_base, struct tui_source_window)
8011 (struct tui_disasm_window, struct tui_data_window)
8012 (struct tui_cmd_window): Update.
8013
8014 2019-06-25 Tom Tromey <tom@tromey.com>
8015
8016 * tui/tui-winsource.h (tui_set_exec_info_content)
8017 (tui_show_exec_info_content, tui_erase_exec_info_content)
8018 (tui_clear_exec_info_content, tui_update_exec_info): Change
8019 argument to tui_source_window_base.
8020 * tui/tui-winsource.c (tui_set_exec_info_content)
8021 (tui_show_exec_info_content, tui_erase_exec_info_content)
8022 (tui_clear_exec_info_content, tui_update_exec_info): Change
8023 argument to tui_source_window_base.
8024
8025 2019-06-25 Tom Tromey <tom@tromey.com>
8026
8027 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8028 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8029
8030 2019-06-25 Tom Tromey <tom@tromey.com>
8031
8032 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8033 check.
8034
8035 2019-06-25 Tom Tromey <tom@tromey.com>
8036
8037 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8038 type to void.
8039 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8040 type to void.
8041 * tui/tui-source.c (tui_set_source_content): Update.
8042 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8043
8044 2019-06-25 Tom Tromey <tom@tromey.com>
8045
8046 * tui/tui-win.c (window_name_completer, tui_set_focus)
8047 (tui_all_windows_info): Use name method.
8048 * tui/tui-data.h (struct tui_gen_win_info)
8049 (struct tui_source_window, struct tui_disasm_window)
8050 (struct tui_data_window, struct tui_cmd_window) <name>: New
8051 method.
8052 (tui_win_name): Don't declare.
8053 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8054 (tui_win_name): Remove.
8055
8056 2019-06-25 Tom Tromey <tom@tromey.com>
8057
8058 * tui/tui-winsource.h (tui_update_source_window)
8059 (tui_update_source_window_as_is): Change parameter type.
8060 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8061 to be a tui_source_window_base.
8062 (tui_update_source_window_as_is): Likewise.
8063 * tui/tui-win.c (make_visible_with_new_height): Update.
8064
8065 2019-06-25 Tom Tromey <tom@tromey.com>
8066
8067 * tui/tui-winsource.c (tui_erase_source_content)
8068 (tui_show_source_content, tui_show_exec_info_content)
8069 (tui_erase_exec_info_content): Use refresh_window method.
8070 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8071 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8072 from tui_refresh_win.
8073 (tui_data_window::refresh_window): New method.
8074 (tui_win_info::refresh, tui_source_window_base::refresh)
8075 (tui_refresh_all): Use refresh_window method.
8076 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8077 method.
8078 * tui/tui-regs.c (tui_display_register): Call refresh_window
8079 method.
8080 * tui/tui-layout.c (show_source_disasm_command)
8081 (show_source_or_disasm_and_command): Call refresh_window method.
8082 * tui/tui-data.h (struct tui_gen_win_info)
8083 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8084 New method.
8085
8086 2019-06-25 Tom Tromey <tom@tromey.com>
8087
8088 * tui/tui.c (tui_rl_other_window, tui_enable)
8089 (tui_is_window_visible, tui_get_command_dimension): Update.
8090 * tui/tui-winsource.c (tui_update_source_window_as_is)
8091 (tui_clear_source_content, tui_erase_source_content)
8092 (tui_show_source_line, tui_source_window_base::refill)
8093 (tui_source_window_base::do_scroll_horizontal)
8094 (tui_source_window_base::set_is_exec_point_at)
8095 (tui_update_breakpoint_info, tui_set_exec_info_content)
8096 (tui_alloc_source_buffer, tui_line_is_displayed)
8097 (tui_addr_is_displayed): Update.
8098 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8099 (tui_check_and_display_highlight_if_needed)
8100 (tui_win_info::make_visible, tui_win_info::refresh)
8101 (tui_refresh_all): Update.
8102 * tui/tui-windata.c (tui_first_data_item_displayed)
8103 (tui_delete_data_content_windows, tui_erase_data_content)
8104 (tui_display_all_data, tui_data_window::refresh_all)
8105 (tui_check_data_values): Update.
8106 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8107 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8108 (tui_win_info::backward_scroll, tui_refresh_all_win)
8109 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8110 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8111 (tui_source_window_base::set_new_height)
8112 (tui_data_window::set_new_height)
8113 (make_invisible_and_set_new_height)
8114 (make_visible_with_new_height, new_height_ok)
8115 (parse_scrolling_args): Update.
8116 * tui/tui-stack.c (tui_show_frame_info): Update.
8117 * tui/tui-source.c (tui_set_source_content)
8118 (tui_set_source_content_nil, tui_source_is_displayed)
8119 (tui_source_window::do_scroll_vertical): Update.
8120 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8121 (tui_display_registers_from, tui_display_reg_element_at_line)
8122 (tui_check_register_values, tui_reg_command): Update.
8123 * tui/tui-layout.c (tui_default_win_height)
8124 (show_source_disasm_command, show_data, init_and_make_win)
8125 (show_source_or_disasm_and_command): Update.
8126 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8127 (tui_redisplay_readline, tui_mld_flush)
8128 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8129 (tui_getc): Update.
8130 * tui/tui-disasm.c (tui_set_disassem_content)
8131 (tui_disasm_window::do_scroll_vertical): Update.
8132 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8133 Now virtual.
8134 (struct tui_win_info): Derive from tui_gen_win_info.
8135 <~tui_win_info>: Mark as override.
8136 <generic>: Remove member.
8137 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8138 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8139 (~tui_data_window, ~tui_win_info)
8140 (tui_free_all_source_wins_content): Update.
8141 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8142
8143 2019-06-25 Tom Tromey <tom@tromey.com>
8144
8145 * tui/tui-layout.c (init_and_make_win): Use new.
8146 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8147 destructor, initializers.
8148 (tui_alloc_generic_win_info): Don't declare.
8149 * tui/tui-data.c (_locator): Add argument to constructor.
8150 (source_win, disasm_win): New globals.
8151 (exec_info): Remove.
8152 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8153 Update.
8154 (tui_alloc_generic_win_info): Remove.
8155 (init_content_element): Use new.
8156 (tui_win_info::tui_win_info): Update.
8157 (free_content_elements) <case DATA_WIN>: Use delete.
8158
8159 2019-06-25 Tom Tromey <tom@tromey.com>
8160
8161 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8162 * tui/tui-windata.c (tui_first_data_item_displayed)
8163 (tui_delete_data_content_windows): Update.
8164 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8165 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8166 (tui_display_registers_from, tui_check_register_values): Update.
8167 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8168 pointer.
8169 * tui/tui-data.c (init_content_element): Update. Allocate the new
8170 window.
8171 (tui_free_data_content): Update.
8172 (free_content_elements) <case DATA_WIN>: Free the window.
8173
8174 2019-06-25 Tom Tromey <tom@tromey.com>
8175
8176 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8177 Update.
8178 * tui/tui-layout.c (make_command_window)
8179 (show_source_disasm_command, show_data, init_and_make_win)
8180 (show_source_or_disasm_and_command): Update.
8181 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8182 method.
8183 <can_highight, is_highlighted>: Now bool.
8184 (tui_set_win_highlight): Don't declare.
8185 * tui/tui-data.c (tui_set_win_highlight): Remove.
8186
8187 2019-06-25 Tom Tromey <tom@tromey.com>
8188
8189 * tui/tui-wingeneral.c (make_visible): Remove check of window
8190 type.
8191
8192 2019-06-25 Tom Tromey <tom@tromey.com>
8193
8194 * tui/tui-win.c (tui_win_info::max_height)
8195 (tui_cmd_window::max_height): New methods.
8196 (new_height_ok): Call max_height.
8197 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8198 <max_height>: New method.
8199
8200 2019-06-25 Tom Tromey <tom@tromey.com>
8201
8202 * tui/tui-win.c (tui_source_window_base::set_new_height)
8203 (tui_data_window::set_new_height): New methods.
8204 (make_invisible_and_set_new_height): Call set_new_height method.
8205 * tui/tui-data.h (struct tui_win_info)
8206 (struct tui_source_window_base, struct tui_data_window)
8207 <set_new_height>: New method.
8208
8209 2019-06-25 Tom Tromey <tom@tromey.com>
8210
8211 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8212 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8213 tui_refresh_data_win.
8214 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8215 method.
8216 (tui_refresh_all_win): Call the refresh_all method.
8217 (tui_set_focus): Likewise.
8218 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8219 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8220 Likewise.
8221
8222 2019-06-25 Tom Tromey <tom@tromey.com>
8223
8224 * tui/tui-winsource.h (tui_refill_source_window)
8225 (tui_set_is_exec_point_at): Don't declare.
8226 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8227 (tui_source_window_base::refill): Rename from
8228 tui_refill_source_window.
8229 (tui_source_window_base::do_scroll_horizontal): Update.
8230 (tui_source_window_base::set_is_exec_point_at): Rename from
8231 tui_set_is_exec_point_at.
8232 (tui_update_all_breakpoint_info): Update.
8233 * tui/tui-stack.c (tui_show_frame_info): Update.
8234 * tui/tui-layout.c (show_data): Add cast.
8235 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8236 * tui/tui-data.h (struct tui_source_window_base) <refill,
8237 set_is_exec_point_at>: New methods.
8238 (tui_source_windows, tui_add_to_source_windows): Update types.
8239 (tui_add_to_source_windows): Remove redundant declaration.
8240 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8241 (tui_source_windows): Change return type.
8242 (tui_clear_source_windows_detail): Update.
8243 (tui_add_to_source_windows): Change type of parameter.
8244 (tui_free_all_source_wins_content): Update.
8245
8246 2019-06-25 Tom Tromey <tom@tromey.com>
8247
8248 * tui/tui-wingeneral.c (tui_win_info::refresh)
8249 (tui_source_window_base::refresh): New methods.
8250 (tui_refresh_all): Call the refresh method.
8251 * tui/tui-data.h (struct tui_win_info)
8252 (struct tui_source_window_base) <refresh>: New method.
8253
8254 2019-06-25 Tom Tromey <tom@tromey.com>
8255
8256 * tui/tui.h (tui_is_window_visible): Return bool.
8257 * tui/tui.c (tui_is_window_visible): Return bool.
8258 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8259 (tui_make_visible, tui_make_invisible)
8260 (tui_win_info::make_visible)
8261 (tui_source_window_base::make_visible, make_all_visible)
8262 (tui_make_all_visible, tui_make_all_invisible): Update.
8263 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8264 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8265 bool.
8266 (struct tui_win_info, struct tui_source_window_base)
8267 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8268 * tui/tui-data.c (tui_init_generic_part): Update.
8269
8270 2019-06-25 Tom Tromey <tom@tromey.com>
8271
8272 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8273 (tui_source_window_base::make_visible): New methods.
8274 (make_all_visible): Make method call.
8275 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8276 (struct tui_source_window_base, struct tui_cmd_window): Override
8277 make_visible.
8278 (tui_win_is_source_type): Don't declare.
8279 * tui/tui-data.c (tui_win_is_source_type): Remove.
8280
8281 2019-06-25 Tom Tromey <tom@tromey.com>
8282
8283 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8284 NULL check.
8285
8286 2019-06-25 Tom Tromey <tom@tromey.com>
8287
8288 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8289 Inline constructor. Add initializers for members.
8290 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8291 constructors; now inline in class.
8292
8293 2019-06-25 Tom Tromey <tom@tromey.com>
8294
8295 * tui/tui-regs.c (tui_show_registers): Update.
8296 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8297 bool.
8298 * tui/tui-data.c (tui_data_window::clear_detail)
8299 (tui_data_window): Update.
8300
8301 2019-06-25 Tom Tromey <tom@tromey.com>
8302
8303 * tui/tui-windata.c (tui_display_all_data)
8304 (tui_display_data_from_line, tui_display_data_from)
8305 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8306 Update.
8307 * tui/tui-regs.c (tui_last_regs_line_no)
8308 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8309 (tui_show_registers, tui_show_register_group)
8310 (tui_display_registers_from, tui_display_reg_element_at_line)
8311 (tui_display_registers_from_line, tui_check_register_values)
8312 (tui_reg_next, tui_reg_prev): Update.
8313 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8314 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8315 tui_data_window.
8316 (struct tui_win_info) <detail>: Remove. Add new fields from
8317 tui_data_info.
8318 (TUI_DATA_WIN): Add cast.
8319 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8320 (~tui_data_window): Simplify.
8321
8322 2019-06-25 Tom Tromey <tom@tromey.com>
8323
8324 * tui/tui-layout.c (show_source_disasm_command)
8325 (show_source_or_disasm_and_command): Update.
8326 * tui/tui-io.c (update_cmdwin_start_line)
8327 (tui_redisplay_readline): Update.
8328 * tui/tui-data.h (struct tui_command_info): Remove.
8329 (struct tui_win_info) <detail>: Remove command_info member.
8330 (struct tui_data_window) <start_line>: New member, from
8331 tui_command_info.
8332 (TUI_CMD_WIN): Add casts.
8333
8334 2019-06-25 Tom Tromey <tom@tromey.com>
8335
8336 * tui/tui-winsource.c (tui_update_source_window)
8337 (tui_refill_source_window)
8338 (tui_source_window_base::do_scroll_horizontal)
8339 (tui_update_breakpoint_info, tui_set_exec_info_content)
8340 (tui_show_exec_info_content, tui_erase_exec_info_content)
8341 (tui_clear_exec_info_content): Update.
8342 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8343 Update.
8344 * tui/tui-win.c (make_invisible_and_set_new_height)
8345 (make_visible_with_new_height): Update.
8346 * tui/tui-source.c (tui_set_source_content)
8347 (tui_show_symtab_source): Update.
8348 * tui/tui-layout.c (extract_display_start_addr)
8349 (show_source_disasm_command, show_data)
8350 (make_source_or_disasm_window)
8351 (show_source_or_disasm_and_command): Update.
8352 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8353 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8354 "gdbarch".
8355 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8356 to tui_source_window_base.
8357 (struct tui_win_info) <detail>: Remove source_info member.
8358 (struct tui_source_window_base) <has_locator>: Inline.
8359 Move contents from tui_source_info; rename has_locator member to
8360 m_has_locator.
8361 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8362 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8363 header file.
8364 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8365 Simplify.
8366 (tui_free_all_source_wins_content): Cast to
8367 tui_source_window_base.
8368
8369 2019-06-25 Tom Tromey <tom@tromey.com>
8370
8371 * tui/tui-win.c (make_invisible_and_set_new_height)
8372 (make_visible_with_new_height): Call has_locator method.
8373 * tui/tui-layout.c (show_source_disasm_command, show_data)
8374 (show_source_or_disasm_and_command): Update for bool change.
8375 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8376 (tui_win_info) <has_locator>: New method.
8377 (struct tui_source_window_base) <has_locator>: New method.
8378 (tui_win_has_locator): Don't declare.
8379 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8380 from tui_win_has_locator.
8381 (tui_source_window_base): Use false, not FALSE.
8382
8383 2019-06-25 Tom Tromey <tom@tromey.com>
8384
8385 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8386 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8387 clear_detail method directly.
8388 (tui_clear_win_detail): Remove.
8389
8390 2019-06-25 Tom Tromey <tom@tromey.com>
8391
8392 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8393 "this", not TUI_DISASM_WIN.
8394
8395 2019-06-25 Tom Tromey <tom@tromey.com>
8396
8397 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8398 declare.
8399 * tui/tui-winsource.c
8400 (tui_source_window_base::do_scroll_horizontal): Rename from
8401 tui_horizontal_source_scroll.
8402 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8403 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8404 from tui_vertical_data_scroll.
8405 * tui/tui-win.h (tui_scroll): Don't declare.
8406 * tui/tui-win.c (tui_win_info::forward_scroll)
8407 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8408 (tui_win_info::right_scroll): Rename and update.
8409 (tui_scroll_forward_command, tui_scroll_backward_command)
8410 (tui_scroll_left_command, tui_scroll_right_command): Update.
8411 (tui_scroll): Remove.
8412 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8413 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8414 from tui_vertical_source_scroll.
8415 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8416 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8417 from tui_vertical_disassem_scroll.
8418 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8419 do_scroll_horizontal>: New methods.
8420 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8421 Likewise.
8422 (struct tui_source_window_base): Add do_scroll_horizontal.
8423 (struct tui_source_window, struct tui_disasm_window): Add
8424 do_scroll_vertical.
8425 (struct tui_data_window, struct tui_cmd_window): Add
8426 do_scroll_horizontal and do_scroll_vertical.
8427 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8428
8429 2019-06-25 Tom Tromey <tom@tromey.com>
8430
8431 * tui/tui-data.h (struct tui_source_window_base): New struct.
8432 (struct tui_source_window): Derive from tui_source_window_base.
8433 (struct tui_disasm_window): New struct.
8434 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8435 from tui_source_window::clear_detail.
8436 (tui_source_window_base): Rename from tui_source_window.
8437 (~tui_source_window_base): Rename from ~tui_source_window.
8438 (tui_alloc_win_info): Create a tui_disasm_window.
8439
8440 2019-06-25 Tom Tromey <tom@tromey.com>
8441
8442 * tui/tui-data.h (struct tui_source_window)
8443 (struct tui_data_window): Declare destructors.
8444 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8445 destructors.
8446 (tui_win_info): Simplify.
8447
8448 2019-06-25 Tom Tromey <tom@tromey.com>
8449
8450 * tui/tui-winsource.c (tui_display_main)
8451 (tui_update_source_windows_with_addr)
8452 (tui_update_all_breakpoint_info): Update.
8453 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8454 (new_height_ok, parse_scrolling_args): Update.
8455 * tui/tui-stack.c (tui_show_frame_info): Update.
8456 * tui/tui-data.h (struct tui_list): Remove.
8457 (tui_source_windows): Return a reference to a std::vector.
8458 * tui/tui-data.c (source_windows): Now a std::vector.
8459 (tui_source_windows): Change return type.
8460 (tui_clear_source_windows): Rewrite.
8461 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8462 (tui_free_all_source_wins_content): Rewrite.
8463
8464 2019-06-25 Tom Tromey <tom@tromey.com>
8465
8466 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8467 (struct tui_data_window, struct tui_cmd_window): Declare
8468 clear_detail method.
8469 * tui/tui-data.c (tui_source_window::clear_detail)
8470 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8471 methods.
8472 (tui_clear_win_detail): Simplify.
8473
8474 2019-06-25 Tom Tromey <tom@tromey.com>
8475
8476 * tui/tui-layout.c (make_source_window, make_disasm_window)
8477 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8478 Return the new window.
8479 (show_source_disasm_command, show_data)
8480 (show_source_or_disasm_and_command): Update.
8481
8482 2019-06-25 Tom Tromey <tom@tromey.com>
8483
8484 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8485 parameter. Return the new window.
8486 (show_source_disasm_command): Update and remove NULL check.
8487 (show_source_or_disasm_and_command): Update.
8488
8489 2019-06-25 Tom Tromey <tom@tromey.com>
8490
8491 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8492
8493 2019-06-25 Tom Tromey <tom@tromey.com>
8494
8495 * tui/tui-data.h (struct tui_win_info): Make constructor
8496 protected. Make destructor virtual. Add initializers.
8497 (tui_source_window, tui_data_window, tui_cmd_window): New
8498 classes.
8499 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8500 constructor. Add "type" parameter.
8501 (tui_source_window, tui_data_window, tui_cmd_window): New
8502 constructors.
8503 (tui_alloc_win_info): Instantiate the appropriate subclass.
8504
8505 2019-06-25 Tom Tromey <tom@tromey.com>
8506
8507 * tui/tui-win.c (tui_resize_all): Use delete.
8508 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8509 destructor.
8510 (tui_free_window): Don't declare.
8511 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8512 Update.
8513
8514 2019-06-25 Tom Tromey <tom@tromey.com>
8515
8516 * tui/tui-data.h (struct tui_win_info): Add constructor.
8517 * tui/tui-data.c (tui_alloc_win_info): Use new.
8518 (tui_free_window): Use delete.
8519
8520 2019-06-22 Tom Tromey <tom@tromey.com>
8521
8522 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8523 declare.
8524 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8525
8526 2019-06-22 Tom Tromey <tom@tromey.com>
8527
8528 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8529 declare.
8530 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8531
8532 2019-06-22 Tom de Vries <tdevries@suse.de>
8533
8534 * dwarf2read.c (create_addrmap_from_aranges)
8535 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8536 instead of '%zu'.
8537
8538 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
8539
8540 * dwarf2read.h (dwarf2_section_info_def): Remove.
8541 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8542 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8543 std::vector<dwarf2_section_info>.
8544 (struct dwo_file) <~dwo_file>: Remove.
8545 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8546 types field.
8547 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8548 (dwarf2_read_debug_names): Likewise.
8549 (create_debug_types_hash_table): Change parameter type to
8550 array_view, adjust code accordingly.
8551 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8552 (partial_die_info::fixup): Likewise.
8553 (determine_prefix): Likewise.
8554 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8555
8556 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8557
8558 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8559 gdb_bfd_ref_ptr.
8560 <~dwo_file>: Remove call to gdb_bfd_unref.
8561 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8562 gdb_bfd_ref_ptr::get.
8563
8564 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8565
8566 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8567 type to htab_up.
8568 * dwarf2read.c (struct dwo_file): Initialize fields.
8569 <~dwo_file>: New.
8570 (free_dwo_file): Remove, move content to ~dwo_file.
8571 (struct dwo_file_deleter): Remove.
8572 (dwo_file_up>: Remove custom deleter.
8573 (free_dwo_files): Remove.
8574 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8575 dwo_files.
8576 (process_skeletonless_type_units): Call unique_ptr::get.
8577 (allocate_dwo_file_hash_table): Add deleter to created hash
8578 table. Change return type to htab_up.
8579 (lookup_dwo_file_slot): Don't memset dwo_file, call
8580 unique_ptr::get.
8581 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8582 (create_dwo_unit_in_dwp_v2): Likewise.
8583 (open_and_init_dwo_file): Likewise.
8584 (free_dwo_file_from_slot): Remove.
8585
8586 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8587
8588 * dwarf2read.h (struct dwarf2_section_info) <readin,
8589 is_virtual>: Change type to bool.
8590 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8591 true instead of 1.
8592
8593 2019-06-19 Tom Tromey <tom@tromey.com>
8594
8595 * tui/tui-data.h (tui_init_content_element): Don't declare.
8596
8597 2019-06-19 Tom Tromey <tom@tromey.com>
8598
8599 * tui/tui-data.h (tui_init_win_info): Don't declare.
8600
8601 2019-06-19 Tom de Vries <tdevries@suse.de>
8602
8603 * dwarf2read.h (abstract_to_concrete): Change type to
8604 std::unordered_map<sect_offset, std::vector<sect_offset>,
8605 gdb::hash_enum<sect_offset>>.
8606
8607 2019-06-19 Tom Tromey <tromey@adacore.com>
8608
8609 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8610 EVAL_AVOID_SIDE_EFFECTS specially.
8611
8612 2019-06-19 Tom Tromey <tromey@adacore.com>
8613
8614 * source-cache.c (highlighter): New global.
8615 (source_cache::get_source_lines): Create a highlighter on demand.
8616
8617 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8618
8619 * defs.h (deprecated_interactive_hook): Delete declaration.
8620 * interps.c (clear_interpreter_hooks): Remove use of
8621 deprecated_interactive_hook.
8622 * top.c (deprecated_interactive_hook): Delete definition.
8623 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8624
8625 2019-06-18 Tom de Vries <tdevries@suse.de>
8626
8627 PR gdb/24515
8628 * dwarf2read.h (abstract_to_concrete): Change type from
8629 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8630 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8631 * dwarf2read.c (read_variable): Update.
8632 (dwarf2_fetch_die_loc_sect_off): Update.
8633
8634 2019-06-17 Tom de Vries <tdevries@suse.de>
8635
8636 PR gdb/24617
8637 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8638 accessing parent[parent_len - 1].
8639
8640 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8641
8642 PR gdb/24364
8643 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8644 call dtrace_process_dof with NULL dof.
8645
8646 2019-06-16 Tom de Vries <tdevries@suse.de>
8647
8648 PR gdb/24445
8649 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8650
8651 2019-06-16 Tom Tromey <tom@tromey.com>
8652
8653 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8654 (make_all_visible): Use address of member.
8655
8656 2019-06-16 Tom Tromey <tom@tromey.com>
8657
8658 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8659 (tui_free_window, free_content, free_content_elements): Remove
8660 unnecessary cast.
8661 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8662 cast.
8663 * tui/tui-regs.c (tui_show_register_group)
8664 (tui_display_registers_from, tui_display_reg_element_at_line):
8665 Remove unnecessary cast.
8666
8667 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8668
8669 * linux-nat.c (normal_mask): Delete.
8670 (_initialize_linux_nat): Don't initialise normal_mask.
8671
8672 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8673
8674 PR gdb/24445
8675 * dwarf-index-write.h (write_psymtabs_to_index): Add
8676 dwz_basename parameter.
8677 * dwarf-index-write.c (write_gdbindex): Move file writing to
8678 write_gdbindex_1. Change return type void.
8679 (assert_file_size): Move up, remove filename parameter.
8680 (write_gdbindex_1): New function.
8681 (write_debug_names): Change return type to void, call
8682 assert_file_size.
8683 (struct index_wip_file): New struct.
8684 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8685 file logic to index_wip_file. Write index for dwz file if
8686 needed.
8687 (save_gdb_index_command): Pass basename of dwz file, if present.
8688 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8689 build-id of dwz file, if present.
8690 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8691 (dwarf2_get_dwz_file): Likewise.
8692 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8693 (dwarf2_get_dwz_file): Likewise.
8694
8695 2019-06-16 Tom Tromey <tom@tromey.com>
8696
8697 * coffread.c (process_coff_symbol): Use xstrdup.
8698 * value.c (create_internalvar): Use xstrdup.
8699
8700 2019-06-16 Tom Tromey <tom@tromey.com>
8701
8702 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8703 * breakpoint.c (stopin_command, stopat_command)
8704 (until_break_command, decode_location_default): Remove unnecessary
8705 cast.
8706 * utils.c (subset_compare): Remove unnecessary cast.
8707 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8708 cast.
8709 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8710 cast.
8711 * infcmd.c (path_command): Remove unnecessary cast.
8712 * coffread.c (decode_type): Remove unnecessary cast.
8713 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8714 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8715 * tui/tui-stack.c (tui_show_locator_content)
8716 (tui_show_frame_info): Remove unnecessary cast.
8717 * tui/tui-win.c (tui_scroll_forward_command)
8718 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8719 (parse_scrolling_args): Remove unnecessary cast.
8720 * tui/tui-data.c (init_win_info, tui_del_window)
8721 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8722 (free_content_elements): Remove unnecessary cast.
8723 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8724 unnecessary cast.
8725 * tui/tui-source.c (tui_set_source_content)
8726 (tui_vertical_source_scroll): Remove unnecessary cast.
8727 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8728 cast.
8729 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8730 * tui/tui-regs.c (tui_display_registers_from)
8731 (tui_display_register): Remove unnecessary cast.
8732 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8733 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8734 (make_visible): Remove unnecessary cast.
8735 * tui/tui-winsource.c (tui_erase_source_content)
8736 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8737 unnecessary cast.
8738 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8739 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8740 * stabsread.c (read_type, read_array_type, read_range_type):
8741 Remove unnecessary cast.
8742 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8743 (parse_symbol, parse_type, upgrade_type, parse_external)
8744 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8745 unnecessary cast.
8746 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8747
8748 2019-06-16 Tom Tromey <tom@tromey.com>
8749
8750 * tui/tui-data.c (tui_alloc_generic_win_info)
8751 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8752 checks.
8753
8754 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8755 Andrew Burgess <andrew.burgess@embecosm.com>
8756
8757 * f-typeprint.c (f_print_type): Don't return early for not
8758 associated or not allocated types.
8759 (f_type_print_varspec_suffix): Add print_rank parameter and print
8760 ranks of array types in case they dangling.
8761 (f_type_print_base): Add print_rank parameter.
8762
8763 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8764
8765 * NEWS: Mention new MI commands.
8766 * break-catch-throw.c (enum exception_event_kind): Move to
8767 breakpoint.h.
8768 (print_mention_exception_catchpoint): Output text as a single
8769 message.
8770 (catch_exception_command_1): Rename to...
8771 (catch_exception_event): ...this, make non-static, update header
8772 command, and change some parameter types.
8773 (catch_catch_command): Update for changes to
8774 catch_exception_command_1.
8775 (catch_throw_command): Likewise.
8776 (catch_rethrow_command): Likewise.
8777 * breakpoint.c (enum exception_event_kind): Delete.
8778 * breakpoint.h (enum exception_event_kind): Moved here from
8779 break-catch-throw.c.
8780 (catch_exception_event): Declare.
8781 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8782 (mi_cmd_catch_throw): New function.
8783 (mi_cmd_catch_rethrow): New function.
8784 (mi_cmd_catch_catch): New function.
8785 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8786 'catch-catch' entries.
8787 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8788 (mi_cmd_catch_rethrow): Declare.
8789 (mi_cmd_catch_catch): Declare.
8790
8791 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8792
8793 * annotate.c (annotate_source_line): Change return type to void,
8794 update implementation to match.
8795 * annotate.h (annotate_source_line): Change return type to void,
8796 update header comment.
8797 * stack.c (print_frame_info): Don't change what frame information
8798 is printed based on whether annotations are on or not.
8799
8800 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8801
8802 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8803 (annotate_source): Make static.
8804 (annotate_source_line): Moved from source.c and renamed from
8805 identify_source_line. Update the return type.
8806 * annotate.h (annotate_source): Delete declaration.
8807 (annotate_source_line): Declaration moved from source.h, and
8808 renamed from identify_source_line. Return type updated.
8809 * source.c (identify_source_line): Moved to annotate.c and renamed
8810 to annotate_source_line.
8811 (info_line_command): Remove check of annotation_level.
8812 * source.h (identify_source_line): Move declaration to annotate.h
8813 and rename to annotate_source_line.
8814 * stack.c: Add 'annotate.h' include.
8815 (print_frame_info): Remove check of annotation_level before
8816 calling annotate_source_line.
8817
8818 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8819
8820 * source-cache.c (source_cache::get_plain_source_lines): Use
8821 open_source_file_with_line_charpos instead of just
8822 open_source_file, remove call to find_source_lines.
8823 (source_cache::get_source_lines): Likewise.
8824 * source.c (find_source_lines): Make static.
8825 (get_filename_and_charpos): Renamed into...
8826 (open_source_file_with_line_charpos): ..this along with changes to
8827 return a scoped_fd, and some other minor clean ups.
8828 (identify_source_line): Use open_source_file_with_line_charpos.
8829 (search_command_helper): Use open_source_file_with_line_charpos
8830 instead of just open_source_file, remove call to
8831 find_source_lines.
8832 * source.h (open_source_file_with_line_charpos): Declare new
8833 function.
8834 (find_source_lines): Delete declaration.
8835
8836 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8837
8838 * source.c (get_filename_and_charpos): Remove fullname
8839 parameter.
8840 (identify_source_line): Update call to get_filename_and_charpos.
8841
8842 2019-06-14 Tom Tromey <tromey@adacore.com>
8843
8844 PR gdb/24502:
8845 * ui-style.h (skip_ansi_escape): Update comment.
8846 * ui-file.h (class no_terminal_escape_file): New class.
8847 * ui-file.c (no_terminal_escape_file::write)
8848 (no_terminal_escape_file::puts): New methods.
8849 * cli/cli-logging.c (handle_redirections): Use
8850 no_terminal_escape_file.
8851
8852 2019-06-14 Tom Tromey <tromey@adacore.com>
8853
8854 * NEWS: Move convenience variable news above Python news.
8855
8856 2019-06-14 Tom Tromey <tom@tromey.com>
8857
8858 * gnulib: Move directory to top-level.
8859 * configure.ac: Don't configure gnulib.
8860 * configure: Rebuild.
8861 * common/common-defs.h: Use new path to gnulib.
8862 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8863 (GNULIB_H): Remove.
8864 (INCGNU): Look in new gnulib location.
8865 (HFILES_NO_SRCDIR): Remove gnulib files.
8866 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8867 (generated_files): Remove GNULIB_H.
8868 ($(LIBGNU), all-lib): Remove targets.
8869 (distclean): Don't mention GNULIB_BUILDDIR.
8870 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8871
8872 2019-06-14 Tom Tromey <tromey@adacore.com>
8873
8874 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8875 Warn if symbol file does not provide any symbols.
8876
8877 2019-06-14 Tom Tromey <tromey@adacore.com>
8878
8879 * source.c (find_and_open_source): Respect basenames_may_differ.
8880
8881 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8882
8883 * annotate.c (annotate_breakpoints_invalid): Make use of
8884 scoped_restore_terminal_state.
8885 (annotate_frames_invalid): Likewise.
8886
8887 2019-06-14 Tom Tromey <tromey@adacore.com>
8888
8889 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8890 allow assignment to an internalvar.
8891
8892 2019-06-14 Tom Tromey <tromey@adacore.com>
8893
8894 * ada-lex.l: Allow "_" in attribute names.
8895
8896 2019-06-14 Tom Tromey <tromey@adacore.com>
8897
8898 PR gdb/24653:
8899 * regcache.c (registers_changed): Don't call alloca.
8900 * top.c (execute_command): Don't call alloca.
8901
8902 2019-06-13 Pedro Alves <palves@redhat.com>
8903
8904 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8905 'expression'. When parsing an expression, error out if there's
8906 junk after "unlimited".
8907 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8908 (do_set_command): Adjust calls to is_unlimited_literal.
8909
8910 2019-06-13 Pedro Alves <palves@redhat.com>
8911
8912 * compile/compile.c (make_compile_options_def_group): Add braces
8913 around array_view initializer.
8914 * thread.c (make_thread_apply_all_options_def_group)
8915 (make_thread_apply_all_options_def_group): Likewise.
8916
8917 2019-06-13 Pedro Alves <palves@redhat.com>
8918
8919 * NEWS (New commands): Mention "maint test-options
8920 require-delimiter", "maint test-options unknown-is-error", "maint
8921 test-options unknown-is-operand" and "maint show
8922 test-options-completion-result".
8923 (New command options, command completion): New section.
8924 (Completion improvements): New section.
8925 Mention that you can abbreviate "unlimited".
8926
8927 2019-06-13 Pedro Alves <palves@redhat.com>
8928
8929 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8930 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8931 * unittests/cli-utils-selftests.c (test_parse_flags)
8932 (test_parse_flags_qcs): Delete.
8933 (test_cli_utils): Don't call deleted functions.
8934
8935 2019-06-13 Pedro Alves <palves@redhat.com>
8936
8937 * thread.c: Include "cli/cli-option.h".
8938 (tp_array_compar_ascending): Global.
8939 (tp_array_compar): Delete function.
8940 (tp_array_compar_ascending, tp_array_compar_descending): New
8941 functions.
8942 (ascending_option_def, qcs_flag_option_def)
8943 (thr_qcs_flags_option_defs)
8944 (make_thread_apply_all_options_def_group)
8945 (make_thread_apply_options_def_group): New.
8946 (thread_apply_all_command): Use gdb::option::process_options.
8947 (thread_apply_command_completer)
8948 (thread_apply_all_command_completer): New.
8949 (thread_apply_command): Use gdb::option::process_options.
8950 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8951 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8952 to generate help text of "thread apply". Adjust "taas"'s help.
8953 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8954 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8955
8956 2019-06-13 Pedro Alves <palves@redhat.com>
8957
8958 * thread.c (thread_apply_command): Check for invalid TID with
8959 isdigit instead of !isalpha.
8960
8961 2019-06-13 Pedro Alves <palves@redhat.com>
8962
8963 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8964 (validate_flags_qcs): New.
8965 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8966 (validate_flags_qcs): Declare.
8967 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8968 (make_frame_apply_options_def_group): New.
8969 (frame_apply_command_count): Process options with
8970 gdb::option::process_options.
8971 (frame_apply_completer): New.
8972 (frame_apply_level_completer, frame_apply_all_completer)
8973 (frame_apply_completer): New.
8974 (_initialize_stack): Update help of "frame apply", "frame apply
8975 level", "frame apply all" and "faas" to mention supported options
8976 and install command completers.
8977 * stack.h (frame_apply_all_completer): Declare.
8978 * thread.c: Include "stack.h".
8979 (tfaas_command): Add "--".
8980 (_initialize_thread): Update help "tfaas" to mention supported
8981 options and install command completer.
8982
8983 2019-06-13 Pedro Alves <palves@redhat.com>
8984
8985 * completer.c (complete_nested_command_line): New.
8986 (gdb_completion_word_break_characters_throw): Add assertion.
8987 * completer.h (complete_nested_command_line): Declare.
8988
8989 2019-06-13 Pedro Alves <palves@redhat.com>
8990
8991 * stack.c (parse_backtrace_qualifiers): New.
8992 (backtrace_command): Use it.
8993 (backtrace_command_completer): Complete on qualifiers.
8994
8995 2019-06-13 Pedro Alves <palves@redhat.com>
8996
8997 * frame.c: Include "cli/cli-option.h.
8998 (user_set_backtrace_options): New.
8999 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9000 Delete.
9001 (get_prev_frame): Adjust.
9002 (boolean_option_def, uinteger_option_def)
9003 (set_backtrace_option_defs): New.
9004 (_initialize_frame): Adjust and use
9005 gdb::option::add_setshow_cmds_for_options to install "set
9006 backtrace past-main" and "set backtrace past-entry".
9007 * frame.h: Include "cli/cli-option.h".
9008 (struct frame_print_options): Forward declare.
9009 (print_frame_arguments_all, print_frame_arguments_scalars)
9010 (print_frame_arguments_none): Declare.
9011 (print_entry_values): Delete declaration.
9012 (struct frame_print_options, user_frame_print_options): New.
9013 (struct set_backtrace_options): New.
9014 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9015 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9016 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9017 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9018 (list_args_or_locals): Add frame_print_options parameter.
9019 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9020 * python/py-framefilter.c (enumerate_args): Pass down
9021 USER_FRAME_PRINT_OPTIONS.
9022 * stack.c: Include "cli/cli-option.h".
9023 (print_frame_arguments_all, print_frame_arguments_scalars)
9024 (print_frame_arguments_none): Declare.
9025 (print_raw_frame_arguments, print_entry_values): Delete.
9026 (user_frame_print_options): New.
9027 (boolean_option_def, enum_option_def, frame_print_option_defs):
9028 New.
9029 (struct backtrace_cmd_options): New.
9030 (bt_flag_option_def): New.
9031 (backtrace_command_option_defs): New.
9032 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9033 (print_frame_arg, read_frame_arg, print_frame_args)
9034 (print_frame_info, print_frame): Add frame_print_options parameter
9035 and use it.
9036 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9037 (backtrace_command_1): Add frame_print_options and
9038 backtrace_cmd_options parameters and use them.
9039 (make_backtrace_options_def_group): New.
9040 (backtrace_command): Process command options with
9041 gdb::option::process_options.
9042 (backtrace_command_completer): New.
9043 (_initialize_stack): Extend "backtrace"'s help to mention
9044 supported options. Install completer for "backtrace".
9045 Install some settings commands with add_setshow_cmds_for_options.
9046
9047 2019-06-13 Pedro Alves <palves@redhat.com>
9048
9049 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9050 and that "set/show print raw frame-arguments" are now deprecated.
9051
9052 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9053 command.
9054 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9055 * stack.c (_initialize_stack): Install "set/show print
9056 raw-frame-arguments", and deprecate "set/show print raw
9057 frame-arguments".
9058 * valprint.c (_initialize_valprint): Deprecate "set/show print
9059 raw".
9060
9061 2019-06-13 Pedro Alves <palves@redhat.com>
9062
9063 * compile/compile.c (struct compile_options): New.
9064 (compile_flag_option_def, compile_command_option_defs)
9065 (make_compile_options_def_group): New.
9066 (compile_file_command): Handle options with
9067 gdb::option::process_options.
9068 (compile_file_command_completer): New function.
9069 (compile_code_command): Handle options with
9070 gdb::option::process_options.
9071 (compile_code_command_completer): New function.
9072 (_initialize_compiler): Install completers for "compile code" and
9073 "compile file". Mention available options in "compile code" and
9074 "compile code"'s help.
9075 * completer.c (advance_to_completion_word): New, factored out from
9076 ...
9077 (advance_to_expression_complete_word_point): ... this.
9078 (advance_to_filename_complete_word_point): New.
9079 * completer.h (advance_to_filename_complete_word_point): New
9080 declaration.
9081
9082 2019-06-13 Pedro Alves <palves@redhat.com>
9083
9084 * compile/compile.c: Include "cli/cli-option.h".
9085 (compile_print_value): Scope data pointer is now a
9086 value_print_options pointer; adjust.
9087 (compile_print_command): Process options. Scope data pointer is
9088 now a value_print_options pointer; adjust.
9089 (_initialize_compile): Update "compile print"'s help to include
9090 supported options. Install a completer for "compile print".
9091 * cp-valprint.c (show_vtblprint, show_objectprint)
9092 (show_static_field_print): Delete.
9093 (_initialize_cp_valprint): Don't install "set print
9094 static-members", "set print vtbl", "set print object" here.
9095 * printcmd.c: Include "cli/cli-option.h" and
9096 "common/gdb_optional.h".
9097 (print_command_parse_format): Rework to fill in a
9098 value_print_options instead of a format_data.
9099 (print_value): Change parameter type from format_data pointer to
9100 value_print_options reference. Adjust.
9101 (print_command_1): Process options. Adjust to pass down a
9102 value_print_options.
9103 (print_command_completer): New.
9104 (_initialize_printcmd): Install print_command_completer as
9105 handle_brkchars completer for the "print" command. Update
9106 "print"'s help to include supported options.
9107 * valprint.c: Include "cli/cli-option.h".
9108 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9109 here from cp-valprint.c.
9110 (boolean_option_def, uinteger_option_def)
9111 (value_print_option_defs, make_value_print_options_def_group):
9112 New. Use gdb::option::add_setshow_cmds_for_options to install
9113 "set print elements", "set print null-stop", "set print repeats",
9114 "set print pretty", "set print union", "set print array", "set
9115 print address", "set print symbol", "set print array-indexes".
9116 * valprint.h: Include <string> and "cli/cli-option.h".
9117 (make_value_print_options_def_group): Declare.
9118 (print_value): Change parameter type from format_data pointer to
9119 value_print_options reference.
9120 (print_command_completer): Declare.
9121
9122 2019-06-13 Pedro Alves <palves@redhat.com>
9123
9124 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9125 (COMMON_SFILES): Add maint-test-settings.c.
9126 * cli/cli-decode.c (boolean_enums): New global, factored out from
9127 ...
9128 (add_setshow_boolean_cmd): ... here.
9129 * cli/cli-decode.h (boolean_enums): Declare.
9130 * cli/cli-option.c: New file.
9131 * cli/cli-option.h: New file.
9132 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9133 factored out from ...
9134 (parse_cli_boolean_value(const char *)): ... this.
9135 (is_unlimited_literal): Change parameter type to pointer to
9136 pointer. Adjust and advance ARG pointer.
9137 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9138 (parse_cli_var_enum): New, factored out from ...
9139 (do_set_command): ... this. Adjust.
9140 * cli/cli-setshow.h (parse_cli_boolean_value)
9141 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9142 (parse_cli_var_enum): Declare.
9143 * cli/cli-utils.c: Include "cli/cli-option.h".
9144 (get_ulongest): New.
9145 * cli/cli-utils.h (get_ulongest): Declare.
9146 (check_for_argument): New overloads.
9147 * maint-test-options.c: New file.
9148
9149 2019-06-13 Pedro Alves <palves@redhat.com>
9150
9151 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9152 parse a range if "-" is at the end of the string.
9153
9154 2019-06-13 Pedro Alves <palves@redhat.com>
9155
9156 * cli/cli-setshow.c (parse_auto_binary_operation)
9157 (parse_cli_boolean_value): Don't allow "o".
9158
9159 2019-06-13 Pedro Alves <palves@redhat.com>
9160
9161 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9162 * NEWS: Mention maint test-settings KIND.
9163 * maint-test-settings.c: New file.
9164
9165 2019-06-13 Pedro Alves <palves@redhat.com>
9166
9167 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9168 completer.
9169 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9170 "set" completers.
9171
9172 2019-06-13 Pedro Alves <palves@redhat.com>
9173
9174 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9175 after item.
9176
9177 2019-06-13 Pedro Alves <palves@redhat.com>
9178
9179 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9180
9181 2019-06-13 Pedro Alves <palves@redhat.com>
9182
9183 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9184 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9185 call.
9186 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9187 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9188 calls.
9189 (check_for_argument): Skip spaces after argument.
9190
9191 2019-06-13 Pedro Alves <palves@redhat.com>
9192
9193 * thread.c (thread_apply_command): Adjust TID parsing.
9194 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9195 detected before end of string.
9196 (tid_is_in_list): Error out if LIST is invalid.
9197
9198 2019-06-13 Pedro Alves <palves@redhat.com>
9199
9200 * completer.c (complete_line_internal_1): Rewind completion word
9201 point.
9202 (completion_tracker::advance_custom_word_point_by): Change
9203 parameter type to int.
9204 * completer.h (completion_tracker::advance_custom_word_point_by):
9205 Likewise.
9206
9207 2019-06-13 Pedro Alves <palves@redhat.com>
9208
9209 * completer.c (advance_to_completion_word): Handle delimiters.
9210
9211 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9212
9213 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9214
9215 2019-06-11 Tom Tromey <tom@tromey.com>
9216
9217 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9218 (xmalloc_failed): Move to alloc.c.
9219 * alloc.c: New file.
9220 * Makefile.in (COMMON_SFILES): Add alloc.c.
9221
9222 2019-06-11 Tom Tromey <tom@tromey.com>
9223
9224 * nat/linux-waitpid.c: Don't include server.h.
9225 (linux_debug): Remove.
9226 (my_waitpid): Update.
9227
9228 2019-06-11 Tom Tromey <tromey@adacore.com>
9229
9230 * infcall.c (_initialize_infcall): Remove trailing newline from
9231 help.
9232 * user-regs.c (_initialize_user_regs): Remove trailing newline
9233 from help.
9234 * typeprint.c (_initialize_typeprint): Remove trailing newline
9235 from help.
9236 * reverse.c (_initialize_reverse): Remove trailing newlines from
9237 help.
9238 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9239 from help.
9240 * language.c (add_set_language_command): Remove trailing newline
9241 from help.
9242 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9243 help.
9244 * disasm.c (_initialize_disasm): Remove trailing newline from
9245 help.
9246 * top.c (init_main): Remove trailing newline from help.
9247 * interps.c (_initialize_interpreter): Remove trailing newline
9248 from help.
9249 * btrace.c (_initialize_btrace): Remove trailing newlines from
9250 help.
9251 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9252 from help.
9253 * python/python.c (_initialize_python): Remove trailing newline
9254 from help.
9255 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9256 help.
9257 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9258 from help. Reformat some text.
9259 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9260 from help.
9261 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9262 newline from help.
9263
9264 2019-06-11 Tom Tromey <tromey@adacore.com>
9265
9266 * darwin-nat.c (darwin_decode_exception_message)
9267 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9268
9269 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9270
9271 * valops.c (value_slice): Check for not allocated or not
9272 associated values.
9273
9274 2019-06-10 Tom de Vries <tdevries@suse.de>
9275
9276 PR gdb/24618
9277 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9278 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9279 invalid.
9280
9281 2019-06-10 Tom de Vries <tdevries@suse.de>
9282
9283 PR gdb/24611
9284 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9285 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9286
9287 2019-06-10 Tom de Vries <tdevries@suse.de>
9288
9289 PR symtab/24545
9290 * symtab.c (struct demangled_name_entry): Add language field.
9291 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9292 static minimal symbol". Set and use language field.
9293
9294 2019-06-10 Tom Tromey <tromey@adacore.com>
9295
9296 * ada-lang.c (_initialize_ada_language): Update help text.
9297
9298 2019-06-10 Tom Tromey <tromey@adacore.com>
9299
9300 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9301 with a newline.
9302 * guile/guile.c (handle_boot_error): Don't end warning with a
9303 newline.
9304 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9305 warning with a newline.
9306 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9307 newline.
9308 (s12z_frame_cache): Likewise.
9309 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9310 a newline.
9311 * solib-svr4.c (disable_probes_interface): Don't end warning with
9312 a newline.
9313 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9314 newline.
9315 * python/python.c (do_finish_initialization): Don't end warning
9316 with a newline.
9317
9318 2019-06-10 Tom Tromey <tom@tromey.com>
9319
9320 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9321 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9322 gdbpy_enter.
9323
9324 2019-06-10 Tom Tromey <tromey@adacore.com>
9325
9326 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9327 data.
9328 (elf_new_init): Don't call stabsread_new_init.
9329 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9330 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9331 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9332
9333 2019-06-10 Tom de Vries <tdevries@suse.de>
9334
9335 PR symtab/16264
9336 PR symtab/24517
9337 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9338
9339 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9340
9341 * source.c (find_and_open_source): Also rewrite relative file
9342 names.
9343
9344 2019-04-26 Amos Bird <amosbird@gmail.com>
9345
9346 * annotate.c (annotate_thread_exited): Add "thread-exited"
9347 annotation.
9348
9349 2019-06-06 Tom Tromey <tromey@adacore.com>
9350
9351 * maint.h (class scoped_command_stats): Use
9352 DISABLE_COPY_AND_ASSIGN.
9353 <print_time>: New method.
9354 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9355 print_time.
9356 (scoped_command_stats::print_time): New method.
9357
9358 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9359
9360 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9361 instructions of lengths 6 or 8 bytes.
9362
9363 2019-06-04 Pedro Alves <palves@redhat.com>
9364
9365 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9366
9367 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9368 * breakpoint.c (condition_completer): Likewise.
9369 * cli/cli-dump.c (scan_expression): Likewise.
9370 * common/filestuff.c (mkdir_recursive): Likewise.
9371 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9372 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9373 (gdb_abspath): Likewise.
9374 * compile/compile-cplus-types.c
9375 (compile_cplus_instance::decl_name): Likewise.
9376 * completer.c (complete_explicit_location):
9377 (signal_completer, reg_or_group_completer_1): Likewise.
9378 * cp-support.c (cp_remove_params_if_any): Likewise.
9379 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9380 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9381 * infcmd.c (strip_bg_char): Likewise.
9382 * linespec.c (copy_token_string): Likewise.
9383 * mi/mi-main.c (output_cores): Likewise.
9384 * psymtab.c (psymtab_search_name):
9385 * symfile.c (test_set_ext_lang_command): Likewise.
9386 * target.c (target_fileio_read_stralloc): Likewise.
9387 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9388 * value.c (complete_internalvar): Likewise.
9389
9390 2019-06-04 Christian Biesinger <cbiesinger@google.com>
9391
9392 Add objfile property to gdb.Type.
9393 * NEWS: Mention Python API addition.
9394 * python/py-type.c (typy_get_objfile): New method.
9395
9396 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9397
9398 * NEWS: Mention the new set|show style [title|highlight].
9399 Mention changes to "show style", "help" and "apropos".
9400
9401 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9402
9403 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9404 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9405 instead of print_help_for_command.
9406 (print_doc_of_command): New function.
9407 (help_list): Add 'apropos -v word' suggestion.
9408 (print_help_for_command): Style the command name using title style.
9409 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9410 (_initialize_cli_cmds): Describe -v in apropos_command help.
9411
9412 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9413
9414 * cli/cli-style.h (cli_style_option): Add name in constructor,
9415 add m_name class member, add constructor with intensity,
9416 add name class function.
9417 (cli_style_option::add_setshow_commands): Remove name argument.
9418 (highlight_style, title_style): New styles.
9419 * cli/cli-style.c (do_show): New function that shows a style
9420 characteristic styling the style name with itself.
9421 (set_style_name): New function.
9422 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9423 Update all callers according to the changes in cli/cli-style.h.
9424 * utils.h (fputs_highlighted): New function.
9425 * utils.c (fputs_highlighted): Likewise.
9426
9427 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9428
9429 * NEWS: Mention new pipe command and new convenience variables.
9430
9431 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9432
9433 * cli/cli-cmds.c (pipe_command): New function.
9434 (_initialize_cli_cmds): Call add_com for pipe_command.
9435 Define | as an alias for pipe.
9436 (exit_status_set_internal_vars): New function.
9437 (shell_escape): Call exit_status_set_internal_vars.
9438 cli/cli-decode.c (find_command_name_length): Recognize | as
9439 a single character command.
9440
9441 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9442
9443 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9444 top.c (execute_command_to_ui_file): New function, mostly a copy
9445 of execute_command_to_string.
9446 (execute_command_to_string): Implement by calling
9447 execute_command_to_ui_file.
9448
9449 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9450
9451 * top.h (saved_command_line): Remove declaration.
9452 * top.c (previous_saved_command_line, previous_repeat_arguments):
9453 New variables.
9454 (saved_command_line): Make static, define together with other
9455 'repeat variables'.
9456 (dont_repeat): Clear repeat_arguments.
9457 (repeat_previous, get_saved_command_line, save_command_line):
9458 New functions.
9459 (gdb_init): Initialize saved_command_line
9460 and previous_saved_command_line.
9461 * main.c (captured_main_1): Remove saved_command_line initialization.
9462 * event-top.c (handle_line_of_input): Update to use
9463 the new 'repeat' related functions instead of direct access to
9464 saved_command_line.
9465 * command.h (repeat_previous, get_saved_command_line,
9466 save_command_line): New declarations.
9467 (dont_repeat): Add comment.
9468
9469 2019-05-30 Tom Tromey <tromey@adacore.com>
9470
9471 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9472 Fix comment.
9473 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9474
9475 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9476
9477 PR cli/24587
9478 * completer.c (complete): Initialize variable word.
9479
9480 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9481
9482 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9483 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9484 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9485 'body' is NULL to the outter 'if', protecting the '!is_define'
9486 situation as well.
9487
9488 2019-05-29 Tom Tromey <tromey@adacore.com>
9489
9490 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9491 (dwarf_unknown): New function.
9492 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9493 (dwarf_type_encoding_name): Use dwarf_unknown.
9494
9495 2019-05-29 Tom Tromey <tromey@adacore.com>
9496
9497 PR c++/20020:
9498 * cp-valprint.c (cp_print_value_fields): Call
9499 cp_print_static_field inside "try".
9500
9501 2019-05-29 Tom Tromey <tromey@adacore.com>
9502
9503 * inflow.c (struct terminal_info): Add default operator=.
9504 * configure: Rebuild.
9505 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9506 -Wdeprecated-copy-dtor, -Wredundant-move.
9507
9508 2019-05-29 Tom Tromey <tromey@adacore.com>
9509
9510 * NEWS: Add entry.
9511 * infcmd.c (print_return_value_1): Handle finish_print
9512 option.
9513 (show_print_finish): New function.
9514 (_initialize_infcmd): Add "set/show print finish" commands.
9515 * valprint.c (user_print_options): Initialize new member.
9516 * valprint.h (struct value_print_options) <finish_print>: New
9517 member.
9518
9519 2019-05-28 Tom Tromey <tromey@adacore.com>
9520
9521 * ada-lang.c (ada_remove_Xbn_suffix)
9522 (find_old_style_renaming_symbol)
9523 (parse_old_style_renaming): Remove.
9524 (ada_find_renaming_symbol): Don't call
9525 find_old_style_renaming_symbol.
9526 (ada_is_renaming_symbol): Rename from
9527 ada_find_renaming_symbol. Remove "block" parameter. Return
9528 bool. Now static.
9529 (ada_read_var_value): Update and simplify.
9530 * ada-exp.y (write_var_or_type): Remove old code.
9531
9532 2019-05-28 Alan Hayward <alan.hayward@arm.com>
9533
9534 PR gdb/25010
9535 * event-top.c: Remove include comment.
9536 * inflow.c (class scoped_ignore_sigttou): Move from here...
9537 * inflow.h (class scoped_ignore_sigttou): ...to here.
9538 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9539 * top.c: Remove include comment.
9540
9541 2019-05-27 Tom Tromey <tom@tromey.com>
9542
9543 * NEWS: Fix typo.
9544
9545 2019-05-22 Tom Tromey <tromey@adacore.com>
9546
9547 * target.c (target_follow_exec): Constify parameter.
9548 * target-delegates.c: Rebuild.
9549 * remote.c (remote_target::follow_exec): Constify parameter.
9550 * infrun.c (follow_exec): Constify parameter.
9551 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9552 (target_follow_exec): Likewise.
9553
9554 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9555
9556 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9557 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9558
9559 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9560
9561 * NEWS: Add debugredirect and testsuite sections.
9562
9563 2019-05-22 Simon Cook <simon.cook@embecosm.com>
9564
9565 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9566 target descriptions using exclusively floating point register name
9567 aliases.
9568
9569 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9570
9571 PR gdb/18644:
9572 * f-lang.c (build_fortran_types): Handle the case where
9573 gdbarch_floatformat_for_type returns a nullptr.
9574
9575 2019-05-21 Tom de Vries <tdevries@suse.de>
9576
9577 PR cli/24587
9578 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9579
9580 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9581
9582 PR gdb/18644:
9583 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9584 16-byte floats.
9585 * i386-tdep.c (i386_floatformat_for_type): Use
9586 floatformats_ia64_quad for the 16-byte floating point component
9587 within a fortran 32-byte complex number.
9588
9589 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9590
9591 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9592 delete default constructor.
9593 (find_partial_die): Update to return const struct.
9594 (partial_die_parent_scope): Move variable declaration into scope
9595 of its use and change its type to auto.
9596 (guess_partial_die_structure_name): Likewise.
9597 (partial_die_info::fixup): Likewise.
9598
9599 2019-05-17 Tom Tromey <tromey@adacore.com>
9600
9601 * source.c (find_and_open_source): Remove cast.
9602
9603 2019-05-17 Tom Tromey <tromey@adacore.com>
9604
9605 * annotate.c (annotate_source): Make "filename" const.
9606 * annotate.h (annotate_source): Use const.
9607
9608 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9609
9610 * disasm.c (set_disassembler_options): Send errors to stderr.
9611
9612 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9613
9614 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9615 (cli_interp_base::set_logging): Check debug_redirect.
9616 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9617 * cli/cli-logging.c (debug_redirect): Add static variable.
9618 (pop_output_files): Add default param.
9619 (handle_redirections): Print debug setting.
9620 (show_logging_command): Likewise.
9621 (_initialize_cli_logging): Add debugredirect command.
9622 * interps.c (current_interp_set_logging): Add debug_redirect
9623 parameter.
9624 * interps.h (set_logging): Add debug_redirect parameter.
9625 (current_interp_set_logging): Likewise.
9626 * mi/mi-common.h: Likewise.
9627 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9628
9629 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9630 Tom Tromey <tromey@adacore.com>
9631
9632 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9633 directly.
9634 * cli/cli-interp.h (make_logging_output): Remove declaration.
9635 * cli/cli-logging.c (make_logging_output): Remove function.
9636 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9637 directly.
9638 * ui-file.c (tee_file::tee_file): Remove bools.
9639 (tee_file::~tee_file): Remove deletes.
9640 * ui-file.h (tee_file): Remove bools.
9641
9642 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9643
9644 * mi/mi-cmds.h (mi_cmd_complete): New function.
9645 * mi/mi-main.c (mi_cmd_complete): Likewise.
9646 * mi/mi-cmds.c: Define new MI command -complete.
9647 * NEWS: Mention new -complete command.
9648
9649 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9650
9651 * completer.h (complete): New function.
9652 * completer.c (complete): Likewise.
9653 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9654 function defined in completer.h.
9655
9656 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9657
9658 * MAINTAINERS (Write After Approval): Add myself.
9659
9660 2019-05-17 Tom de Vries <tdevries@suse.de>
9661
9662 PR gdb/24094
9663 * dwarf2read.c (struct cu_partial_die_info): New struct.
9664 (find_partial_die): Return cu_partial_die_info.
9665 (partial_die_parent_scope, guess_partial_die_structure_name)
9666 (partial_die_info::fixup): Handle new return type of find_partial_die.
9667
9668 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9669
9670 PR breakpoints/24541
9671 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9672 "std::string", simplifying the algorithm.
9673
9674 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9675
9676 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9677 (stap_static_probe_ops::get_probes): Likewise.
9678
9679 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9680
9681 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9682 '-')" and "else if".
9683 (stap_parse_single_operand): Join checks for
9684 "gdbarch_stap_parse_special_token_p" and
9685 "gdbarch_stap_parse_special_token" in the same "if" statement.
9686 Invert check when verifying for operation on register
9687 displacement.
9688
9689 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9690
9691 * stap-probe.c (stap_get_opcode): Update comment.
9692 (stap_get_expected_argument_type): Likewise.
9693 (handle_stap_probe): Likewise.
9694
9695 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9696
9697 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9698 return type to 'bool'. Adjust comment. Use 'bool' when
9699 appropriate.
9700 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9701 * stap-probe.c (stap_parse_argument_1): Likewise.
9702 (stap_is_operator): Likewise.
9703 (stap_is_generic_prefix): Likewise.
9704 (stap_is_register_prefix): Likewise.
9705 (stap_is_register_indirection_prefix): Likewise.
9706 (stap_is_integer_prefix): Likewise.
9707 (stap_generic_check_suffix): Likewise.
9708 (stap_check_integer_suffix): Likewise.
9709 (stap_check_register_suffix): Likewise.
9710 (stap_check_register_indirection_suffix): Likewise.
9711 (stap_parse_register_operand): Likewise.
9712 (stap_parse_single_operand): Likewise.
9713 (stap_parse_argument_1): Likewise.
9714 (stap_probe::get_argument_count): Likewise.
9715 (stap_is_operator): Likewise.
9716
9717 2019-05-16 Tom Tromey <tromey@adacore.com>
9718
9719 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9720 keyword to foreach.
9721
9722 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
9723
9724 * linux-thread-db.c (try_thread_db_load_1): Change return type
9725 to bool.
9726 (try_thread_db_load): Likewise.
9727 (try_thread_db_load_from_pdir_1): Likewise.
9728 (try_thread_db_load_from_pdir): Likewise.
9729 (try_thread_db_load_from_sdir): Likewise.
9730 (try_thread_db_load_from_dir): Likewise.
9731 (thread_db_load_search): Likewise.
9732 (has_libpthread): Likewise.
9733 (thread_db_load): Likewise.
9734
9735 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9736
9737 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9738 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9739 NULL, and complain/return if that's the case.
9740
9741 2019-05-15 John Darrington <john@darrington.wattle.id.au>
9742
9743 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9744 (advance, posn, abstract_read_memory): New functions.
9745 [struct mem_read_abstraction]: New struct.
9746 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9747
9748 2019-05-14 Tom Tromey <tromey@adacore.com>
9749
9750 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9751 value is not lval_memory.
9752
9753 2019-05-14 Tom Tromey <tromey@adacore.com>
9754
9755 * solib.c (info_sharedlibrary_command): Style the file name.
9756
9757 2019-05-14 Alan Hayward <alan.hayward@arm.com>
9758
9759 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9760 (aarch64_vnv_type): Likewise.
9761 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9762 * common/tdesc.c: Likewise.
9763 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9764 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9765 * features/aarch64-fpu.xml: Add ieee half view.
9766 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9767 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9768 * gdbtypes.h (struct builtin_type): Likewise.
9769 (struct objfile_type): Likewise.
9770
9771 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
9772
9773 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9774 typo.
9775 * location.h (string_to_event_location): Likewise.
9776
9777 2019-05-11 Joel Brobecker <brobecker@adacore.com>
9778
9779 GDB 8.3 released.
9780
9781 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9782
9783 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9784 New variable declaration.
9785 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9786 New variable.
9787 (print_one_breakpoint): Use ui_out::test_flags and new global
9788 variable to compute use_fixed_output.
9789 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9790 Remove.
9791 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9792 (mi_multi_location_breakpoint_output_fixed): Remove.
9793 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9794 new variable.
9795 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9796 fix_multi_location_breakpoint_output flag if version >= 3.
9797 * ui-out.h (enum ui_out_flag)
9798 <fix_multi_location_breakpoint_output>: New enumerator.
9799
9800 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9801
9802 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9803
9804 2019-05-10 Tom Tromey <tromey@adacore.com>
9805
9806 * ada-lang.c (catch_ada_completer): New function.
9807 (_initialize_ada_language): Use it.
9808
9809 2019-05-10 Tom Tromey <tromey@adacore.com>
9810
9811 * thread.c (print_thread_info): Make "requested_threads" const.
9812 * gdbthread.h (print_thread_info): Make "requested_threads"
9813 const.
9814 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9815 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9816
9817 2019-05-08 Tom Tromey <tom@tromey.com>
9818
9819 * gdbtypes.c (objfile_type_data): Change type.
9820 (objfile_type, _initialize_gdbtypes): Update.
9821
9822 2019-05-08 Tom Tromey <tom@tromey.com>
9823
9824 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9825 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9826 (_initialize_dwarf2_frame): Update.
9827
9828 2019-05-08 Tom Tromey <tom@tromey.com>
9829
9830 * objc-lang.c (objc_objfile_data): Change type.
9831 (find_methods): Update.
9832 (_initialize_objc_lang): Remove.
9833
9834 2019-05-08 Tom Tromey <tom@tromey.com>
9835
9836 * stabsread.c (rs6000_builtin_type_data): Change type.
9837 (rs6000_builtin_type, _initialize_stabsread): Update.
9838
9839 2019-05-08 Tom Tromey <tom@tromey.com>
9840
9841 * mips-tdep.c (mips_pdr_data): Remove.
9842 (_initialize_mips_tdep): Update.
9843
9844 2019-05-08 Tom Tromey <tom@tromey.com>
9845
9846 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9847 (hppa_init_objfile_priv_data, read_unwind_info)
9848 (find_unwind_entry, _initialize_hppa_tdep): Update.
9849
9850 2019-05-08 Tom Tromey <tom@tromey.com>
9851
9852 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9853 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9854 on obstack.
9855 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9856
9857 2019-05-08 Tom Tromey <tom@tromey.com>
9858
9859 * mdebugread.c (basic_type_data): Change type.
9860 (basic_type, _initialize_mdebugread): Update.
9861
9862 2019-05-08 Tom Tromey <tom@tromey.com>
9863
9864 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9865
9866 2019-05-08 Tom Tromey <tom@tromey.com>
9867
9868 * nto-tdep.c (nto_inferior_data_reg): Change type.
9869 (nto_inferior_data): Update.
9870 (nto_inferior_data_cleanup, nto_new_inferior_data)
9871 (_initialize_nto_tdep): Remove.
9872 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9873
9874 2019-05-08 Tom Tromey <tom@tromey.com>
9875
9876 * ada-lang.c (struct ada_inferior_data): Add initializers.
9877 (ada_inferior_data): Change type.
9878 (ada_inferior_data_cleanup): Remove.
9879 (get_ada_inferior_data, ada_inferior_exit)
9880 (struct ada_pspace_data): Add initializers, destructor.
9881 (ada_pspace_data_handle): Change type.
9882 (get_ada_pspace_data): Update.
9883 (ada_pspace_data_cleanup): Remove.
9884
9885 2019-05-08 Tom Tromey <tom@tromey.com>
9886
9887 * coffread.c (struct coff_symfile_info): Add initializers.
9888 (coff_objfile_data_key): Move lower. Change type.
9889 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9890 Update.
9891 (coff_free_info): Remove.
9892
9893 2019-05-08 Tom Tromey <tom@tromey.com>
9894
9895 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9896 (fbsd_pspace_data_handle): Move lower. Change type.
9897 (get_fbsd_pspace_data): Update.
9898 (fbsd_pspace_data_cleanup): Remove.
9899 (_initialize_fbsd_tdep): Update.
9900
9901 2019-05-08 Tom Tromey <tom@tromey.com>
9902
9903 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9904 (get_ada_tasks_pspace_data): Update.
9905 (ada_tasks_pspace_data_cleanup): Remove.
9906 (_initialize_tasks): Update.
9907 (ada_tasks_inferior_data_handle): Change type.
9908 (get_ada_tasks_inferior_data): Update.
9909 (ada_tasks_inferior_data_cleanup): Remove.
9910 (struct ada_tasks_pspace_data): Add initializers.
9911
9912 2019-05-08 Tom Tromey <tom@tromey.com>
9913
9914 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9915 * symfile-debug.c (debug_sym_get_probes): Change type.
9916 * stap-probe.c (handle_stap_probe):
9917 (stap_static_probe_ops::get_probes): Change type.
9918 * probe.h (class static_probe_ops) <get_probes>: Change type.
9919 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9920 (parse_probes_in_pspace): Update.
9921 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9922 Update.
9923 (any_static_probe_ops::get_probes): Change type.
9924 * elfread.c (elfread_data): New typedef.
9925 (probe_key): Change type.
9926 (elf_get_probes): Likewise. Update.
9927 (probe_key_free): Remove.
9928 (_initialize_elfread): Update.
9929 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9930 Change type.
9931 (dtrace_process_dof_probe, dtrace_process_dof)
9932 (dtrace_static_probe_ops::get_probe): Change type.
9933
9934 2019-05-08 Tom Tromey <tom@tromey.com>
9935
9936 * xcoffread.c (struct xcoff_symfile_info): Rename from
9937 coff_symfile_info. Add initializers.
9938 (xcoff_objfile_data_key): Move lower. Change type.
9939 (XCOFF_DATA): Rewrite.
9940 (xcoff_free_info): Remove.
9941 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9942 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9943 (xcoff_initial_scan): Update.
9944
9945 2019-05-08 Tom Tromey <tom@tromey.com>
9946
9947 * solib-svr4.c (struct svr4_info): Add initializers and
9948 destructor.
9949 <probes_table>: Now an htab_up.
9950 (solib_svr4_pspace_data): Change type.
9951 (free_probes_table): Simplify.
9952 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9953 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9954 (probes_table_remove_objfile_probes, register_solib_event_probe)
9955 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9956 (_initialize_svr4_solib): Update.
9957
9958 2019-05-08 Tom Tromey <tom@tromey.com>
9959
9960 * remote.c (remote_pspace_data): Change type.
9961 (remote_pspace_data_cleanup): Remove.
9962 (get_remote_exec_file, set_pspace_remote_exec_file)
9963 (_initialize_remote): Update.
9964
9965 2019-05-08 Tom Tromey <tom@tromey.com>
9966
9967 * breakpoint.c (breakpoint_objfile_key): Change type.
9968 (get_breakpoint_objfile_data): Update.
9969 (free_breakpoint_objfile_data): Remove.
9970 (_initialize_breakpoint): Update.
9971
9972 2019-05-08 Tom Tromey <tom@tromey.com>
9973
9974 * linux-tdep.c (struct linux_info): Add initializers.
9975 (linux_inferior_data): Move. Change type.
9976 (invalidate_linux_cache_inf): Update.
9977 (linux_inferior_data_cleanup): Remove.
9978 (get_linux_inferior_data, _initialize_linux_tdep): Update.
9979
9980 2019-05-08 Tom Tromey <tom@tromey.com>
9981
9982 * auxv.c (auxv_inferior_data): Move. Change type.
9983 (auxv_inferior_data_cleanup): Remove.
9984 (invalidate_auxv_cache_inf): Rewrite.
9985 (get_auxv_inferior_data, _initialize_auxv): Update.
9986
9987 2019-05-08 Tom Tromey <tom@tromey.com>
9988
9989 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9990 (symfile_debug_objfile_data_key): Change type.
9991 (symfile_debug_installed, debug_qf_has_symbols)
9992 (debug_qf_find_last_source_symtab)
9993 (debug_qf_forget_cached_source_info)
9994 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9995 (debug_qf_print_stats, debug_qf_dump)
9996 (debug_qf_expand_symtabs_for_function)
9997 (debug_qf_expand_all_symtabs)
9998 (debug_qf_expand_symtabs_with_fullname)
9999 (debug_qf_map_matching_symbols)
10000 (debug_qf_expand_symtabs_matching)
10001 (debug_qf_find_pc_sect_compunit_symtab)
10002 (debug_qf_map_symbol_filenames)
10003 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10004 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10005 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10006 (debug_sym_read_linetable, debug_sym_relocate): Update.
10007 (symfile_debug_free_objfile): Remove.
10008 (install_symfile_debug_logging, _initialize_symfile_debug):
10009 Update.
10010
10011 2019-05-08 Tom Tromey <tom@tromey.com>
10012
10013 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10014 allocate_on_obstack.
10015 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10016 (get_dwarf2_per_objfile): Update.
10017 (set_dwarf2_per_objfile): Remove.
10018 (dwarf2_has_info, dwarf2_get_section_info): Update.
10019 (dwarf2_free_objfile): Remove.
10020 (_initialize_dwarf2_read): Update.
10021
10022 2019-05-08 Tom Tromey <tom@tromey.com>
10023
10024 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10025 initializers.
10026 <unsupported_script_warning_printed,
10027 script_not_found_warning_printed>: Now bool.
10028 (auto_load_pspace_data): Change type.
10029 (~auto_load_pspace_info): Rename from
10030 auto_load_pspace_data_cleanup.
10031 (get_auto_load_pspace_data, init_loaded_scripts_info)
10032 (clear_section_scripts, maybe_print_unsupported_script_warning)
10033 (maybe_print_script_not_found_warning, _initialize_auto_load):
10034 Update.
10035
10036 2019-05-08 Tom Tromey <tom@tromey.com>
10037
10038 * objfiles.c (objfile_pspace_info): Add destructor and
10039 initializers.
10040 (objfiles_pspace_data): Change type.
10041 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10042 (get_objfile_pspace_data): Update.
10043 (objfiles_bfd_data): Change type.
10044 (get_objfile_bfd_data): Update.
10045 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10046
10047 2019-05-08 Tom Tromey <tom@tromey.com>
10048
10049 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10050 Change type.
10051 (get_catch_syscall_inferior_data): Update.
10052 (catch_syscall_inferior_data_cleanup): Remove.
10053 (_initialize_break_catch_syscall): Update.
10054
10055 2019-05-08 Tom Tromey <tom@tromey.com>
10056
10057 * inflow.c (struct terminal_info): Add destructor and
10058 initializers.
10059 (inflow_inferior_data): Change type.
10060 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10061 (get_inflow_inferior_data, inflow_inferior_exit)
10062 (swap_terminal_info, _initialize_inflow): Update.
10063
10064 2019-05-08 Tom Tromey <tom@tromey.com>
10065
10066 * target-dcache.c (target_dcache_cleanup): Remove.
10067 (target_dcache_aspace_key): Change type.
10068 (target_dcache_init_p, target_dcache_invalidate)
10069 (target_dcache_get, target_dcache_get_or_init)
10070 (_initialize_target_dcache): Update.
10071 * dcache.h (struct dcache_deleter): New.
10072
10073 2019-05-08 Tom Tromey <tom@tromey.com>
10074
10075 * symtab.c (struct symbol_cache): Add destructor and
10076 initializers.
10077 (symbol_cache_key): Move. Change type.
10078 (make_symbol_cache, free_symbol_cache): Remove.
10079 (get_symbol_cache): Update.
10080 (symbol_cache_cleanup): Remove.
10081 (ALL_PSPACES, symbol_cache_flush)
10082 (maintenance_print_symbol_cache)
10083 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10084 Update.
10085
10086 2019-05-08 Tom Tromey <tom@tromey.com>
10087
10088 * symtab.c (struct main_info): Add destructor and initializers.
10089 (main_progspace_key): Move. Change type.
10090 (get_main_info): Update.
10091 (main_info_cleanup): Remove.
10092 (_initialize_symtab): Update.
10093
10094 2019-05-08 Tom Tromey <tom@tromey.com>
10095
10096 * registry.h (DECLARE_REGISTRY): Define the _key class.
10097
10098 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10099
10100 * NEWS: Merge two 'New commands' sections.
10101
10102 2019-05-08 Joel Brobecker <brobecker@adacore.com>
10103
10104 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10105 parameter and use Ada language definition instead.
10106 (ada_val_print_ptr): Remove unused language parameter.
10107 (ada_val_print_num): Remove language parameter and use Ada language
10108 definition instead.
10109 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10110 parameter.
10111 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10112 parameter and use Ada language definition instead.
10113 (ada_val_print_1): Update all ada_val_print_xxx calls.
10114 Remove language parameter.
10115 (ada_val_print): Update ada_val_print_1 call.
10116
10117 2019-05-08 Tom Tromey <tromey@adacore.com>
10118
10119 * remote.c (remote_hw_watchpoint_limit)
10120 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10121 Now static.
10122
10123 2019-05-08 Tom Tromey <tromey@adacore.com>
10124
10125 * maint.c (_initialize_maint_cmds): Move initialization code to
10126 remote.c.
10127 (watchdog, show_watchdog): Move to remote.c.
10128 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10129 "watchdog" static.
10130 (_initialize_remote): Move initialization code from maint.c.
10131 * defs.h (watchdog): Don't declare.
10132
10133 2019-05-08 Tom Tromey <tromey@adacore.com>
10134
10135 * tui/tui-interp.c: Include main.h.
10136 * interps.c: Include main.h.
10137 * main.h (interpreter_p): Declare.
10138 * defs.h (interpreter_p): Don't declare.
10139
10140 2019-05-08 Tom Tromey <tromey@adacore.com>
10141
10142 * dwarf2loc.c: Include dwarf2read.h.
10143 * defs.h (read_unsigned_leb128): Don't declare.
10144 * dwarf2read.h (read_unsigned_leb128): Declare.
10145
10146 2019-05-08 Tom Tromey <tromey@adacore.com>
10147
10148 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10149 method.
10150
10151 2019-05-08 Tom Tromey <tromey@adacore.com>
10152
10153 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10154 when no wrap column is set.
10155
10156 2019-05-08 Tom Tromey <tromey@adacore.com>
10157
10158 * c-lang.c (c_get_string): Handle non-C-style arrays.
10159
10160 2019-05-08 Tom Tromey <tromey@adacore.com>
10161
10162 * typeprint.c (print_offset_data::update): Print the bit offset,
10163 not the number of bits remaining.
10164
10165 2019-05-08 Tom Tromey <tromey@adacore.com>
10166
10167 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10168 padding at end of comment.
10169
10170 2019-05-08 Tom Tromey <tromey@adacore.com>
10171
10172 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10173 Compare main types.
10174
10175 2019-05-06 Tom Tromey <tom@tromey.com>
10176
10177 * common/scoped_mmap.c: Include common-defs.h.
10178 * common/scoped_mmap.h: Don't include config.h.
10179
10180 2019-05-04 Tom Tromey <tom@tromey.com>
10181
10182 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10183 (struct aarch64_call_info): Add initializers.
10184 <si>: Now a std::vector.
10185 (pass_on_stack, aarch64_push_dummy_call): Update.
10186
10187 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
10188 Tom Tromey <tom@tromey.com>
10189
10190 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10191 (ppc_threads): Now a std::vector. Now static.
10192 (hwdebug_find_thread_points_by_tid)
10193 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10194 Update.
10195
10196 2019-05-04 Tom Tromey <tom@tromey.com>
10197
10198 * arc-tdep.c (arc_tdesc_init): Return bool.
10199
10200 2019-05-04 Tom Tromey <tom@tromey.com>
10201
10202 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10203 Use gdb_assert_not_reached.
10204
10205 2019-05-04 Tom Tromey <tom@tromey.com>
10206
10207 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10208 "false".
10209
10210 2019-05-04 Tom Tromey <tom@tromey.com>
10211
10212 * arc-tdep.c (arc_tdesc_init): Use bool.
10213
10214 2019-05-04 Tom Tromey <tom@tromey.com>
10215
10216 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10217
10218 2019-05-04 Tom Tromey <tom@tromey.com>
10219
10220 * cli/cli-cmds.c (valid_command_p): Return bool.
10221
10222 2019-05-04 Tom Tromey <tom@tromey.com>
10223
10224 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10225 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10226
10227 2019-05-04 Raul Tambre <raul@tambre.ee>
10228
10229 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10230 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10231 operator for comparison.
10232
10233 2019-05-04 Tom Tromey <tom@tromey.com>
10234
10235 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10236 (lookup_partial_symbol, print_partial_symbols)
10237 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10238 (psymbol_compare): Update.
10239 (add_psymbol_to_bcache): Clear the entire psymbol.
10240 (maintenance_check_psymtabs): Update.
10241 * psympriv.h (struct partial_symbol): Don't derive from
10242 general_symbol_info.
10243 <obj_section, unrelocated_address, address,
10244 set_unrelocated_address>: Update.
10245 <ginfo>: New member.
10246 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10247 (debug_names::write_psymbols): Update.
10248
10249 2019-05-04 Tom de Vries <tdevries@suse.de>
10250
10251 * contrib/cc-with-tweaks.sh: Support -n arg.
10252
10253 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10254
10255 * corelow.c (core_target::detach): Ensure frame cache and
10256 register caches are cleared.
10257 inferior.c (exit_inferior_1): Likewise.
10258
10259 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10260 Tom Tromey <tom@tromey.com>
10261
10262 * dictionary.c (collate_pending_symbols_by_language): Remove
10263 "struct" from foreach.
10264 * symtab.c (lookup_global_symbol_from_objfile)
10265 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10266 foreach.
10267 * ser-tcp.c (net_open): Remove "struct" from foreach.
10268 * objfiles.c (objfile_relocate, objfile_rebase)
10269 (objfile_has_symbols): Remove "struct" from foreach.
10270 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10271 from foreach.
10272 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10273 foreach.
10274 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10275 "struct" from foreach.
10276 * ada-lang.c (create_excep_cond_exprs)
10277 (ada_exception_catchpoint_cond_string): Remove "struct" from
10278 foreach.
10279
10280 2019-05-03 Tom Tromey <tromey@adacore.com>
10281
10282 * ada-exp.y (convert_char_literal): Check suffix of each
10283 enumerator.
10284
10285 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10286
10287 PR ada/21406:
10288 * ada-exp.y (yywrap): Don't define.
10289 * ada-lex.l (%option): Add noyywrap
10290 (yywrap): Remove.
10291
10292 2019-05-03 Eli Zaretskii <eliz@gnu.org>
10293
10294 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10295 _WIN32_WINNT to the XP level, unless already defined to a higher
10296 level.
10297
10298 * unittests/parse-connection-spec-selftests.c:
10299 * ser-tcp.c:
10300 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10301 override.
10302
10303 * symfile.c (find_separate_debug_file): Remove colon from the
10304 drive spec of DOS/Windows file names of the target, so that the
10305 file name produced from DEBUGDIR and the target's directory will
10306 be valid on DOS/Windows systems.
10307
10308 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10309
10310 * rust-lang.c (val_print_struct): Handle printing structures
10311 containing strings.
10312
10313 2019-05-02 Tom Tromey <tromey@adacore.com>
10314
10315 * valarith.c (_initialize_valarith): Remove.
10316
10317 2019-05-01 Tom Tromey <tromey@adacore.com>
10318
10319 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10320 bitfields.
10321
10322 2019-05-01 Tom Tromey <tromey@adacore.com>
10323
10324 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10325 for big-endian copies.
10326
10327 2019-04-30 Ali Tamur <tamur@google.com>
10328 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10329 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10330 (read_3_bytes): New function.
10331
10332 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10333
10334 * windows-nat.c (main_thread_id): Delete.
10335 (handle_output_debug_string): Replace main_thread_id by
10336 current_event.dwThreadId.
10337 (fake_create_process): Likewise.
10338 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10339 Do not set main_thread_id.
10340 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10341 current_event.dwThreadId.
10342 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10343
10344 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10345
10346 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10347 Use current_event.dwThreadId instead of main_thread_id.
10348
10349 2019-04-30 Tom Tromey <tromey@adacore.com>
10350
10351 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10352 (create_excep_cond_exprs): Iterate over program spaces.
10353 (ada_exception_catchpoint_cond_string): Examine all minimal
10354 symbols for exception types.
10355
10356 2019-04-30 Tom Tromey <tromey@adacore.com>
10357
10358 PR c++/24470:
10359 * dwarf2read.c (process_structure_scope): Handle case where type
10360 has template parameters but no symbol was created.
10361
10362 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10363 Chris January <chris.january@arm.com>
10364
10365 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10366 qualifier.
10367 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10368
10369 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10370
10371 * f-typeprint.c (f_print_type): Update rules for printing
10372 whitespace.
10373 (f_type_print_varspec_suffix): Likewise.
10374
10375 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10376 Chris January <chris.january@arm.com>
10377
10378 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10379 function arguments.
10380
10381 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10382
10383 * f-lang.c (build_fortran_types): Change name of void type to
10384 lower case.
10385 * f-typeprint.c (f_type_print_base): Print the name of the void
10386 type, rather than a fixed string.
10387 * f-valprint.c (f_decorations): Use lower case void string.
10388
10389 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10390 Chris January <chris.january@arm.com>
10391
10392 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10393 types for Fortran.
10394
10395 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10396 Chris January <chris.january@arm.com>
10397 David Lecomber <david.lecomber@arm.com>
10398
10399 * f-exp.y (BINOP_INTRINSIC): New token.
10400 (exp): New parser rule handling BINOP_INTRINSIC.
10401 (f77_keywords): Add new builtin procedures.
10402 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10403 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10404 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10405 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10406 (print_unop_subexp_f): New function.
10407 (print_binop_subexp_f): New function.
10408 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10409 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10410 (dump_subexp_body_f): Likewise.
10411 (operator_check_f): Likewise.
10412 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10413 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10414
10415 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10416
10417 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10418 UNOP_KIND.
10419 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10420 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10421 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10422 (operator_length_f): New fuction.
10423 (print_subexp_f): New function.
10424 (op_name_f): New function.
10425 (dump_subexp_body_f): New function.
10426 (operator_check_f): New function.
10427 (exp_descriptor_f): Replace standard expression handling functions
10428 with new functions.
10429 * gdb/fortran-operator.def: New file.
10430 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10431 * gdb/std-operator.def: Remove UNOP_KIND.
10432
10433 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10434
10435 * std-operator.def: Remove unbalanced, stray double quote
10436 character.
10437
10438 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10439 Chris January <chris.january@arm.com>
10440 Daniel Everett <daniel.everett@arm.com>
10441 Nick Forrington <nick.forrington@arm.com>
10442 Richard Bunt <richard.bunt@arm.com>
10443
10444 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10445 of depth when printing anonymous structs or unions.
10446 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10447 Don't print either the top-level value, or the children if the
10448 max-depth is exceeded.
10449 (ppscm_print_children): When printing the key of a map, allow one
10450 extra level of depth.
10451 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10452 print either the top-level value, or the children if the max-depth
10453 is exceeded.
10454 (print_children): When printing the key of a map, allow one extra
10455 level of depth.
10456 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10457 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10458 (user_print_options): Initialise max_depth field.
10459 (val_print_scalar_or_string_type_p): New function.
10460 (val_print): Check to see if the max depth has been reached.
10461 (val_print_check_max_depth): Define new function.
10462 (show_print_max_depth): New function.
10463 (_initialize_valprint): Add 'print max-depth' option.
10464 * valprint.h (struct value_print_options) <max_depth>: New field.
10465 (val_print_check_max_depth): Declare new function.
10466 * NEWS: Document new feature.
10467
10468 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10469
10470 * ada-lang.c (ada_language_defn): Initialise new field.
10471 * c-lang.c (c_is_string_type_p): New function.
10472 (c_language_defn): Initialise new field.
10473 (cplus_language_defn): Initialise new field.
10474 (asm_language_defn): Initialise new field.
10475 (minimal_language_defn): Initialise new field.
10476 * c-lang.h (c_is_string_type_p): Declare new function.
10477 * d-lang.c (d_language_defn): Initialise new field.
10478 * f-lang.c (f_is_string_type_p): New function.
10479 (f_language_defn): Initialise new field.
10480 * go-lang.c (go_is_string_type_p): New function.
10481 (go_language_defn): Initialise new field.
10482 * language.c (default_is_string_type_p): New function.
10483 (unknown_language_defn): Initialise new field.
10484 (auto_language_defn): Initialise new field.
10485 * language.h (struct language_defn) <la_is_string_type_p>: New
10486 member variable.
10487 (default_is_string_type_p): Declare new function.
10488 * m2-lang.c (m2_language_defn): Initialise new field.
10489 * objc-lang.c (objc_language_defn): Initialise new field.
10490 * opencl-lang.c (opencl_language_defn): Initialise new field.
10491 * p-lang.c (pascal_is_string_type_p): New function.
10492 (pascal_language_defn): Initialise new field.
10493 * rust-lang.c (rust_is_string_type_p): New function.
10494 (rust_language_defn): Initialise new field.
10495
10496 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10497
10498 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10499 New field.
10500 * ada-lang.c (ada_language_defn): Initialise new field.
10501 * c-lang.c (c_language_defn): Likewise.
10502 (cplus_language_defn): Likewise.
10503 (asm_language_defn): Likewise.
10504 (minimal_language_defn): Likewise.
10505 * d-lang.c (d_language_defn): Likewise.
10506 * f-lang.c (f_language_defn): Likewise.
10507 * go-lang.c (go_language_defn): Likewise.
10508 * language.c (unknown_language_defn): Likewise.
10509 (auto_language_defn): Likewise.
10510 * m2-lang.c (m2_language_defn): Likewise.
10511 * objc-lang.c (objc_language_defn): Likewise.
10512 * opencl-lang.c (opencl_language_defn): Likewise.
10513 * p-lang.c (pascal_language_defn): Likewise.
10514 * rust-lang.c (rust_language_defn): Likewise.
10515
10516 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10517
10518 * ada-lang.c (ada_is_character_type): Change return type to bool.
10519 (ada_is_string_type): Likewise.
10520 * ada-lang.h (ada_is_character_type): Update declaration
10521 (ada_is_string_type): Likewise.
10522
10523 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10524
10525 Support style in 'frame|thread apply'
10526
10527 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10528 * record.c (record_start, record_stop): Update callers of
10529 execute_command_to_string with false.
10530 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10531 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10532 methods.
10533 (class string_file): New constructor with term_out parameter.
10534 Override methods term_out and can_emit_style_escape. New member
10535 term_out.
10536 (class stdio_file): Override can_emit_style_escape.
10537 (class tee_file): Override term_out and can_emit_style_escape.
10538 * utils.h (can_emit_style_escape): Remove.
10539 * utils.c (can_emit_style_escape): Likewise.
10540 Update all callers of can_emit_style_escape (SOMESTREAM) to
10541 SOMESTREAM->can_emit_style_escape.
10542 * source-cache.c (source_cache::get_source_lines): Likewise.
10543 * stack.c (frame_apply_command_count): Call execute_command_to_string
10544 passing the term_out characteristic of the current gdb_stdout.
10545 * thread.c (thr_try_catch_cmd): Likewise.
10546 * top.c (execute_command_to_string): pass term_out parameter
10547 to construct the string_file for the command output.
10548 * ui-file.c (term_cli_styling): New function (most code moved
10549 from utils.c can_emit_style_escape).
10550 (string_file::string_file, string_file::can_emit_style_escape,
10551 stdio_file::can_emit_style_escape, tee_file::term_out,
10552 tee_file::can_emit_style_escape): New functions.
10553
10554 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10555
10556 * NEWS: Mention the new set|show may-call-functions.
10557 * infcall.c (may_call_functions_p): New variable.
10558 (show_may_call_functions_p): New function.
10559 (call_function_by_hand_dummy): Throws an error if not
10560 may-call-functions.
10561 (_initialize_infcall): Call add_setshow_boolean_cmd for
10562 may-call-functions.
10563
10564 2019-04-25 Keith Seitz <keiths@redhat.com>
10565
10566 PR c++/24367
10567 * cp-support.c (inspect_type): Don't attempt substitutions
10568 of symbol with the same name.
10569
10570 2019-04-25 Tom Tromey <tromey@adacore.com>
10571
10572 PR gdb/24475:
10573 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10574 static.
10575
10576 2019-04-25 Tom Tromey <tromey@adacore.com>
10577
10578 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10579 rvalue reference.
10580 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10581 (gdb_xml_parser::parse): Use std::move.
10582 * python/python-internal.h (gdbpy_convert_exception): Take a const
10583 reference.
10584 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10585 std::move.
10586 * python/py-utils.c (gdbpy_convert_exception): Take a const
10587 reference.
10588 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10589 Use std::move.
10590 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10591 Use std::move.
10592 * mi/mi-main.c (mi_print_exception): Take a const reference.
10593 * main.c (handle_command_errors): Take a const reference.
10594 * linespec.c (parse_linespec): Use std::move.
10595 * infcall.c (run_inferior_call): Use std::move.
10596 (call_function_by_hand_dummy): Use std::move.
10597 * exec.c (try_open_exec_file): Use std::move.
10598 * exceptions.h (exception_print, exception_fprintf)
10599 (exception_print_same): Update.
10600 * exceptions.c (print_exception, exception_print)
10601 (exception_fprintf, exception_print_same): Change parameters to
10602 const reference.
10603 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10604 * common/new-op.c: Use std::move.
10605 * common/common-exceptions.h (struct gdb_exception): Add move
10606 constructor.
10607 (struct gdb_exception_error, struct gdb_exception_quit, struct
10608 gdb_quit_bad_alloc): Change constructor to move constructor.
10609 (throw_exception): Change parameter to rvalue reference.
10610 * common/common-exceptions.c (throw_exception): Take rvalue
10611 reference.
10612 * cli/cli-interp.c (safe_execute_command): Use std::move.
10613 * breakpoint.c (insert_bp_location, location_to_sals): Use
10614 std::move.
10615
10616 2019-04-25 Tom Tromey <tromey@adacore.com>
10617
10618 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10619 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10620 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10621 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10622 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10623 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10624 guile/scm-value.c: Use unpack.
10625 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10626 gdbscm_gdb_exception.
10627 (gdbscm_throw_gdb_exception): Likewise.
10628 (struct gdbscm_gdb_exception): New.
10629 (unpack): New function.
10630 (gdbscm_wrap): Use unpack.
10631
10632 2019-04-25 Tom Tromey <tromey@adacore.com>
10633
10634 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10635 (gdb_rl_callback_handler): Use std::move.
10636 * common/common-exceptions.h (struct gdb_exception): Add move
10637 assignment operator.
10638 (throw_exception_sjlj): Change "exception" to const reference.
10639 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10640 (throw_exception_sjlj): Change "exception" to const reference.
10641
10642 2019-04-25 Tom Tromey <tromey@adacore.com>
10643
10644 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10645 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10646 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10647 Update.
10648 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10649 Update.
10650 * mi/mi-interp.c (mi_interp::exec): Update.
10651 * linespec.c (parse_linespec): Update.
10652 * infcall.c (run_inferior_call): Update.
10653 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10654 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10655 (gdbscm_lookup_global_symbol): Update.
10656 * guile/scm-param.c (gdbscm_parameter_value): Update.
10657 * guile/scm-frame.c (gdbscm_frame_read_register)
10658 (gdbscm_frame_read_var): Update.
10659 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10660 * exec.c (try_open_exec_file): Update.
10661 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10662 (gdb_rl_callback_handler): Update.
10663 * common/common-exceptions.h (exception_none): Don't declare.
10664 * common/common-exceptions.c (exception_none): Don't define.
10665 (struct catcher) <exception>: Update.
10666 * cli/cli-interp.c (safe_execute_command): Update.
10667 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10668
10669 2019-04-25 Ali Tamur <tamur@google.com>
10670
10671 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10672 (read_attribute_value): Likewise.
10673 (dwarf2_read_addr_index): Update comment.
10674 (read_str_index): Add DW_FORM_strx.
10675 (dwarf2_string_attr): Likewise.
10676 (dwarf2_const_value_attr): Likewise.
10677 (dump_die_shallow): Likewise.
10678 (dwarf2_fetch_constant_bytes): Likewise.
10679 (skip_form_bytes): Likewise.
10680 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10681
10682 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10683
10684 PR corefiles/11608
10685 PR corefiles/18187
10686 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10687 OFFSET. Verify if current mapping contains an ELF header.
10688 (linux_find_memory_regions_full): Adjust call to
10689 dump_mapping_p.
10690
10691 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10692 Kang Li <kanglictf@gmail.com>
10693
10694 PR gdb/21600
10695
10696 * dwarf2-frame.c (read_initial_length): Be consistent about using
10697 unsigned representation of length.
10698 (decode_frame_entry_1): Likewise. Check for wraparound of
10699 end pointer as well as buffer overflow.
10700
10701 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10702
10703 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10704 "vq".
10705
10706 2019-04-24 Tom Tromey <tromey@adacore.com>
10707
10708 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10709
10710 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10711
10712 * s12z-tdep.c (s12z_unwind_pc): Delete.
10713 (s12z_unwind_sp): Delete.
10714 (s12z_gdbarch_init): Don't register deleted functions with
10715 gdbarch.
10716
10717 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10718
10719 * rl78-tdep.c (rl78_unwind_sp): Delete.
10720 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10721
10722 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10723
10724 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10725 (xstormy16_unwind_pc): Delete.
10726 (xstormy16_dummy_id): Delete.
10727 (xstormy16_gdbarch_init): Don't register deleted functions with
10728 gdbarch.
10729
10730 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10731
10732 * vax-tdep.c (vax_unwind_pc): Delete.
10733 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10734
10735 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10736
10737 * v850-tdep.c (v850_unwind_sp): Delete.
10738 (v850_unwind_pc): Delete.
10739 (v850_dummy_id): Delete.
10740 (v850_gdbarch_init): Don't register deleted functions with
10741 gdbarch.
10742
10743 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10744
10745 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10746 (tilegx_unwind_pc): Delete.
10747 (tilegx_unwind_dummy_id): Delete.
10748 (tilegx_gdbarch_init): Don't register deleted functions with
10749 gdbarch.
10750
10751 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10752
10753 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10754 (tic6x_dummy_id): Delete.
10755 (tic6x_gdbarch_init): Don't register deleted functions with
10756 gdbarch.
10757
10758 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10759
10760 * sparc-tdep.c (sparc_unwind_pc): Delete.
10761 (sparc32_gdbarch_init): Don't register deleted function with
10762 gdbarch.
10763
10764 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10765
10766 * sh-tdep.c (sh_unwind_sp): Delete.
10767 (sh_unwind_pc): Delete.
10768 (sh_dummy_id): Delete.
10769 (sh_gdbarch_init): Don't register deleted functions with
10770 gdbarch.
10771
10772 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10773
10774 * score-tdep.c (score_unwind_sp): Delete.
10775 (score_unwind_pc): Delete.
10776 (score_dummy_id): Delete.
10777 (score_gdbarch_init): Don't register deleted functions with
10778 gdbarch.
10779
10780 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10781
10782 * rx-tdep.c (rx_unwind_pc): Delete.
10783 (rx_unwind_sp): Delete.
10784 (rx_dummy_id): Delete.
10785 (rx_gdbarch_init): Don't register deleted functions with
10786 gdbarch. Update comment.
10787
10788 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10789
10790 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10791 (rs6000_dummy_id): Delete.
10792 (rs6000_gdbarch_init): Don't register deleted functions with
10793 gdbarch.
10794
10795 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10796
10797 * or1k-tdep.c (or1k_dummy_id): Delete.
10798 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10799
10800 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10801
10802 * nios2-tdep.c (nios2_dummy_id): Delete.
10803 (nios2_unwind_sp): Delete.
10804 (nios2_gdbarch_init): Don't register deleted functions with
10805 gdbarch.
10806
10807 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10808
10809 * nds32-tdep.c (nds32_dummy_id): Delete.
10810 (nds32_unwind_pc): Delete.
10811 (nds32_unwind_sp): Delete.
10812 (nds32_gdbarch_init): Don't register deleted functions with
10813 gdbarch.
10814
10815 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10816
10817 * msp430-tdep.c (msp430_unwind_pc): Delete.
10818 (msp430_unwind_sp): Delete.
10819 (msp430_dummy_id): Delete.
10820 (msp430_gdbarch_init): Don't register deleted functions with
10821 gdbarch.
10822
10823 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10824
10825 * moxie-tdep.c (moxie_unwind_sp): Delete.
10826 (moxie_unwind_pc): Delete.
10827 (moxie_dummy_id): Delete.
10828 (moxie_gdbarch_init): Don't register deleted functions with
10829 gdbarch.
10830
10831 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10832
10833 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10834 (mn10300_unwind_pc): Delete.
10835 (mn10300_unwind_sp): Delete.
10836 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10837 mn10300_unwind_sp.
10838 (mn10300_frame_unwind_init): Don't register deleted functions with
10839 gdbarch.
10840
10841 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10842
10843 * mep-tdep.c (mep_unwind_pc): Delete.
10844 (mep_unwind_sp): Delete.
10845 (mep_dummy_id): Delete.
10846 (mep_gdbarch_init): Don't register deleted functions with
10847 gdbarch.
10848
10849 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10850
10851 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10852 (m68hc11_unwind_sp): Delete.
10853 (m68hc11_gdbarch_init): Don't register deleted functions with
10854 gdbarch.
10855
10856 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10857
10858 * m32r-tdep.c (m32r_unwind_sp): Delete.
10859 (m32r_unwind_pc): Delete.
10860 (m32r_dummy_id): Delete.
10861 (m32r_gdbarch_init): Don't register deleted functions with
10862 gdbarch.
10863
10864 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10865
10866 * m32c-tdep.c (m32c_unwind_pc): Delete.
10867 (m32c_unwind_sp): Delete.
10868 (m32c_dummy_id): Delete.
10869 (m32c_gdbarch_init): Don't register deleted functions with
10870 gdbarch.
10871
10872 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10873
10874 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10875 (lm32_unwind_pc): Delete.
10876 (lm32_dummy_id): Delete.
10877 (lm32_gdbarch_init): Don't register deleted functions with
10878 gdbarch.
10879
10880 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10881
10882 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10883 (iq2000_unwind_pc): Delete.
10884 (iq2000_dummy_id): Delete.
10885 (iq2000_gdbarch_init): Don't register deleted functions with
10886 gdbarch.
10887
10888 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10889
10890 * nds32-tdep.c (nds32_type_align): Delete.
10891 (nds32_push_dummy_call): Use type_align instead.
10892
10893 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10894
10895 * arm-tdep.c (arm_type_align): Only handle vector override case.
10896 (arm_push_dummy_call): Use type_align.
10897 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10898
10899 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10900
10901 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10902 case.
10903 (pass_on_stack): Use type_align.
10904 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10905 function.
10906
10907 2019-04-23 Tom Tromey <tromey@adacore.com>
10908
10909 * dwarf2read.c (line_header::file_name_at): Remove unused
10910 overload.
10911
10912 2019-04-23 Tom de Vries <tdevries@suse.de>
10913
10914 PR gdb/24438
10915 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10916 invocation.
10917
10918
10919 2019-03-27 Ali Tamur <tamur@google.com>
10920
10921 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10922 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10923 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10924 (dwarf_expr_context::get_addr_index): Likewise
10925 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10926 (symbol_needs_eval_context::get_addr_index): Likewise
10927 (disassemble_dwarf_expression): Add DW_OP_addrx
10928 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10929 (read_cutu_die_from_dwo): Update comment
10930 (skip_one_die): Add DW_FORM_addrx
10931 (read_attribute_value): Likewise
10932 (var_decode_location): Add DW_OP_addrx
10933 (dwarf2_const_value_attr): Add DW_FORM_addrx
10934 (dump_die_shallow): Likewise
10935 (dwarf2_fetch_constant_bytes): Likewise
10936 (decode_locdesc): Add DW_OP_addrx
10937 (skip_form_bytes): Add DW_FORM_addrx
10938
10939 2019-04-22 Ali Tamur <tamur@google.com>
10940
10941 * MAINTAINERS (Write After Approval): Add self.
10942
10943 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
10944
10945 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10946 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10947 (open_symbol_file_object): Likewise.
10948 (svr4_default_sos): Add info parameter.
10949 (svr4_read_so_list): Likewise.
10950 (svr4_current_sos_direct): Adjust functions calls to pass down
10951 info.
10952 (svr4_current_sos_1): Add info parameter.
10953 (svr4_current_sos): Call get_svr4_info, pass info down to
10954 svr4_current_sos_1.
10955 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10956 get_svr4_info.
10957 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10958 get_svr4_info.
10959 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10960 to get_svr4_info.
10961 (probes_table_remove_objfile_probes): Likewise.
10962 (register_solib_event_probe): Add info parameter.
10963 (solist_update_incremental): Pass info parameter down to
10964 svr4_read_so_list.
10965 (disable_probes_interface): Add info parameter.
10966 (svr4_handle_solib_event): Pass current_program_space to
10967 get_svr4_info. Adjust disable_probes_interface cleanup.
10968 (svr4_create_probe_breakpoints): Add info parameter, pass it
10969 down to register_solib_event_probe.
10970 (svr4_create_solib_event_breakpoints): Add info parameter,
10971 pass it down to svr4_create_probe_breakpoints.
10972 (enable_break): Pass info down to
10973 svr4_create_solib_event_breakpoints.
10974 (svr4_solib_create_inferior_hook): Pass current_program_space to
10975 get_svr4_info.
10976 (svr4_clear_solib): Likewise.
10977
10978 2019-04-22 Pedro Alves <palves@redhat.com>
10979
10980 * solib-svr4.c (svr4_free_objfile_observer): New.
10981 (probe_and_action::objfile): New field.
10982 (probes_table_htab_remove_objfile_probes)
10983 (probes_table_remove_objfile_probes): New functions.
10984 (register_solib_event_probe): Add 'objfile' parameter. Store it
10985 in the new probe_and_action. Don't store the probe in 'lookup'.
10986 (svr4_create_probe_breakpoints): Pass objfile to
10987 register_solib_event_probe.
10988 (_initialize_svr4_solib): Register a free_objfile observer.
10989
10990 2019-04-19 Tom Tromey <tom@tromey.com>
10991
10992 * common/queue.h: Remove.
10993
10994 2019-04-19 Tom Tromey <tom@tromey.com>
10995
10996 * event-loop.c: Don't include "common/queue.h".
10997
10998 2019-04-19 Tom Tromey <tom@tromey.com>
10999
11000 * remote.c (remote_target): Use delete.
11001 * remote-notif.h: Include <list>, not "common/queue.h".
11002 (notif_client_p): Remove typedef.
11003 (remote_notif_state): Add constructor, destructor, initializer.
11004 <notif_queue>: Now a std::list.
11005 (remote_notif_state_xfree): Don't declare.
11006 * remote-notif.c (remote_notif_process, handle_notification)
11007 (remote_notif_state_allocate): Update.
11008 (~remote_notif_state): Rename from remote_notif_state_xfree.
11009
11010 2019-04-19 Tom Tromey <tom@tromey.com>
11011
11012 * symfile.c (reread_symbols): Update.
11013 * objfiles.c (objfile_register_static_link)
11014 (objfile_lookup_static_link): Update
11015 (~objfile) Don't delete static_links.
11016 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11017
11018 2019-04-19 Tom Tromey <tom@tromey.com>
11019
11020 * type-stack.h (struct type_stack) <insert>: Constify string.
11021 * type-stack.c (type_stack::insert): Constify string.
11022 * gdbtypes.h (lookup_template_type): Update.
11023 (address_space_name_to_int): Update.
11024 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11025 const.
11026 (lookup_template_type): Make name const.
11027 * c-exp.y: Update rules.
11028 (lex_one_token, classify_name, classify_inner_name)
11029 (c_print_token): Update.
11030 * p-exp.y: Update rules.
11031 (yylex): Update.
11032 * f-exp.y: Update rules.
11033 (yylex): Update.
11034 * d-exp.y: Update rules.
11035 (lex_one_token, classify_name, classify_inner_name): Update.
11036 * parse.c (write_dollar_variable, copy_name): Return std::string.
11037 * parser-defs.h (copy_name): Change return type.
11038 * m2-exp.y: Update rules.
11039 (yylex): Update.
11040 * go-exp.y (lex_one_token): Update.
11041 Update rules.
11042 (classify_unsafe_function, classify_packaged_name)
11043 (classify_name, yylex): Update.
11044
11045 2019-04-19 Sergei Trofimovich <siarheit@google.com>
11046
11047 * configure.ac: add --enable-source-highlight switch.
11048 * configure: Regenerate.
11049 * top.c (print_gdb_version): plumb --enable-source-highlight
11050 status to "show configuration".
11051
11052 2019-04-19 Tom Tromey <tromey@adacore.com>
11053
11054 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11055 Check ADA_TYPE_P.
11056 (empty_record, ada_template_to_fixed_record_type_1)
11057 (template_to_static_fixed_type)
11058 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11059 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11060 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11061 macros.
11062
11063 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11064
11065 PR symtab/24423:
11066 * source.c (print_source_lines_base): Advance "iter" when a
11067 control character is seen.
11068
11069 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11070
11071 * inferior.h (struct infcall_suspend_state_deleter):
11072 Catch exception in destructor to avoid crash.
11073
11074 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11075
11076 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11077 close to the add_com "shell".
11078
11079 2019-04-18 Tom Tromey <tromey@adacore.com>
11080
11081 * process-stratum-target.h (class process_stratum_target)
11082 <stratum>: Add "final".
11083
11084 2019-04-17 Tom Tromey <tromey@adacore.com>
11085
11086 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11087 against nullptr before use.
11088
11089 2019-04-17 Alan Hayward <alan.hayward@arm.com>
11090
11091 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11092
11093 2019-04-17 Jim Wilson <jimw@sifive.com>
11094 Andrew Burgess <andrew.burgess@embecosm.com>
11095
11096 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11097 code read might fail, assume 4-byte breakpoint in that case.
11098
11099 2019-04-15 Leszek Swirski <leszeks@google.com>
11100
11101 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11102 rather than a hand-rolled POD check when checking for forced MEMORY
11103 classification.
11104
11105 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11106
11107 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11108 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11109 function.
11110 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11111 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11112 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11113 declaration.
11114
11115 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11116
11117 * aarch64-linux-nat.c
11118 (aarch64_linux_nat_target::thread_architecture): Add override.
11119 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11120 each VQ.
11121
11122 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11123
11124 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11125
11126 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11127
11128 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11129 target types of size 96-bits, add some additional comments, and
11130 check that the builtin type we found was the correct size.
11131
11132 2019-04-12 Eli Zaretskii <eliz@gnu.org>
11133
11134 * utils.c (prompt_for_continue): Don't restore the styling at the
11135 end, as applied_style has the wrong value. This fixes styling in
11136 long lists of file names that are interrupted by the "Continue?"
11137 prompt.
11138
11139 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11140
11141 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11142 * c-lang.c (c_language_defn): Likewise.
11143 (cplus_language_defn): Likewise.
11144 (asm_language_defn): Likewise.
11145 (minimal_language_defn): Likewise.
11146 * d-lang.c (d_language_defn): Likewise.
11147 * f-lang.c (f_language_defn): Likewise.
11148 * go-lang.c (go_language_defn): Likewise.
11149 * language.c (unknown_language_defn): Likewise.
11150 (auto_language_defn): Likewise.
11151 * language.h (struct language_defn): Remove la_magic field.
11152 (LANG_MAGIC): Delete.
11153 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11154 * objc-lang.c (objc_language_defn): Likewise.
11155 * opencl-lang.c (opencl_language_defn): Likewise.
11156 * p-lang.c (pascal_language_defn): Likewise.
11157 * rust-lang.c (rust_language_defn): Likewise.
11158
11159 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11160
11161 * riscv-tdep.c (riscv_type_align): New function.
11162 (riscv_type_alignment): Delete.
11163 (riscv_arg_location): Use 'type_align'.
11164 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11165
11166 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11167
11168 * gdbtypes.c (type_align): A struct with no non-static fields also
11169 has alignment of 1.
11170
11171 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11172
11173 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11174 component to 0.
11175 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11176 member.
11177 (riscv_struct_info::analyse): New implementation using new
11178 analyse_inner member function.
11179 (riscv_struct_info::field_offset): New member function.
11180 (riscv_struct_info::m_offsets): New member variable.
11181 (riscv_struct_info::analyse_inner): New private member function,
11182 takes the old implementation of riscv_struct_info::analyse but
11183 extended to track field offsets.
11184 (riscv_call_arg_struct): Update the struct folding special cases
11185 to handle cases where empty C++ structs, which are non-zero
11186 length, are found.
11187 (riscv_arg_location): Initialise the length of each location, a
11188 non-zero length now indicates the location is in use.
11189 (riscv_push_dummy_call): Allow for the first location having a
11190 non-zero offset when setting up arguments.
11191 (riscv_return_value): Likewise, but for return values.
11192
11193 2019-04-11 Tom Tromey <tromey@adacore.com>
11194
11195 * utils.c (internal_vproblem): Make "msg" const.
11196
11197 2019-04-11 Alan Hayward <alan.hayward@arm.com>
11198
11199 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11200 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11201 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11202 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11203
11204 2019-04-10 Kevin Buettner <kevinb@redhat.com>
11205
11206 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11207 function.
11208 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11209 of amd64_collect_native_gregset.
11210 (amd64_linux_nat_target::store_registers): Likewise.
11211
11212 2019-04-10 Tom Tromey <tom@tromey.com>
11213
11214 * symtab.c (lookup_global_symbol_from_objfile)
11215 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11216 * objfiles.h (class separate_debug_iterator): New.
11217 (class separate_debug_range): New.
11218 (struct objfile) <separate_debug_objfiles>: New method.
11219 (objfile_separate_debug_iterate): Don't declare.
11220 * objfiles.c (separate_debug_iterator::operator++): Rename from
11221 objfile_separate_debug_iterate.
11222 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11223 iterator.
11224 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11225 iterator.
11226
11227 2019-04-10 Tom Tromey <tom@tromey.com>
11228
11229 * symfile.c (reread_symbols): Remove old comment.
11230 * objfiles.c (free_all_objfiles): Fix a typo.
11231
11232 2019-04-10 Tom Tromey <tom@tromey.com>
11233
11234 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11235 * minsyms.c (lookup_minimal_symbol): Use foreach.
11236 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11237 (lookup_minimal_symbol_solib_trampoline): Likewise.
11238 * symfile.c (reread_symbols): Use foreach.
11239
11240 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
11241 Tom Tromey <tromey@adacore.com>
11242
11243 PR rust/24414:
11244 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11245 (rust_lex_int_test): Change "value" to be LONGEST.
11246 (rust_lex_tests): Add test for long integer literal.
11247
11248 2019-04-09 Tom Tromey <tromey@adacore.com>
11249
11250 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11251 to bool.
11252 (extended_remote_target::attach): Update.
11253 (remote_target::remote_notice_new_inferior): Update.
11254 (remote_target::add_current_inferior_and_thread): Update.
11255 * inferior.c (exit_inferior_1): Use "false".
11256 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11257
11258 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
11259
11260 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11261 the "start" command.
11262
11263 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11264
11265 * python/py-inferior.c (infpy_thread_from_thread_handle):
11266 Adjust comments to reflect renaming of thread_from_thread_handle
11267 to thread_from_handle. Adjust keywords. Fix type error message.
11268 (inferior_object_methods): Add thread_from_handle. Retain
11269 thread_from_thread_handle, but mark it as deprecated.
11270
11271 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11272
11273 * gdbthread.h (find_thread_by_handle): Revise declaration.
11274 * thread.c (find_thread_by_handle): Likewise. Adjust
11275 implementation too.
11276 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11277 support for buffer objects as handles.
11278
11279 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11280
11281 * python/py-infthread.c (thpy_thread_handle): New function.
11282 (thread_object_methods): Register thpy_thread_handle.
11283
11284 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11285
11286 * gdbthread.h (thread_to_thread_handle): Declare.
11287 * thread.c (gdbtypes.h): Include.
11288 (thread_to_thread_handle): New function.
11289
11290 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11291 (target_thread_info_to_thread_handle): Declare.
11292 * target.c (target_thread_info_to_thread_handle): New function.
11293 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11294 * target-delegates.c: Regenerate.
11295
11296 * linux-thread-db.c (class thread_db_target): Add method
11297 thread_info_to_thread_handle.
11298 (thread_db_target::thread_info_to_thread_handle): Define.
11299 * remote.c (class remote_target): Add new method
11300 thread_info_to_thread_handle.
11301 (remote_target::thread_info_to_thread_handle): Define.
11302
11303 2019-04-08 Pedro Alves <palves@redhat.com>
11304
11305 * common/common-exceptions.c (throw_exception): Don't create
11306 named object to throw; throw directly.
11307 (throw_it): Likewise. Don't initialize gdb_exception::message
11308 here, with new; pass FMT and AP to the ctor instead.
11309 * common/common-exceptions.h: Include <string>.
11310 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11311 const char *, va_list)): New ctor. Use std::make_shared.
11312 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11313 errors)): Delete.
11314 (gdb_exception_error::gdb_exception_error(enum errors, const char
11315 *, va_list)): New.
11316 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11317 Add assertion.
11318 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11319 errors)): Delete.
11320 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11321 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11322 Add assertion.
11323
11324 2019-04-08 Tom Tromey <tom@tromey.com>
11325
11326 * valops.c (value_rtti_indirect_type): Replace throw_exception
11327 with throw.
11328 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11329 with throw.
11330 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11331 throw.
11332 * target.c (target_translate_tls_address): Replace throw_exception
11333 with throw.
11334 * stack.c (frame_apply_command_count): Replace throw_exception
11335 with throw.
11336 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11337 throw.
11338 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11339 with throw.
11340 * rs6000-tdep.c (rs6000_frame_cache)
11341 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11342 * remote.c: Replace throw_exception with throw.
11343 * record-full.c (record_full_message, record_full_wait_1)
11344 (record_full_restore): Replace throw_exception with throw.
11345 * record-btrace.c:
11346 (get_thread_current_frame_id, record_btrace_start_replaying)
11347 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11348 (cmd_record_btrace_start): Replace throw_exception with throw.
11349 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11350 throw.
11351 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11352 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11353 * linespec.c:
11354 (find_linespec_symbols): Replace throw_exception with throw.
11355 * infrun.c (displaced_step_prepare, resume): Replace
11356 throw_exception with throw.
11357 * infcmd.c (post_create_inferior): Replace throw_exception with
11358 throw.
11359 * inf-loop.c (inferior_event_handler): Replace throw_exception
11360 with throw.
11361 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11362 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11363 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11364 (get_prev_frame_always, get_frame_pc_if_available)
11365 (get_frame_address_in_block_if_available, get_frame_language):
11366 Replace throw_exception with throw.
11367 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11368 throw_exception with throw.
11369 * eval.c (fetch_subexp_value, evaluate_var_value)
11370 (evaluate_funcall, evaluate_subexp_standard): Replace
11371 throw_exception with throw.
11372 * dwarf2loc.c (call_site_find_chain)
11373 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11374 Replace throw_exception with throw.
11375 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11376 with throw.
11377 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11378 throw.
11379 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11380 * completer.c (complete_line_internal): Replace throw_exception
11381 with throw.
11382 * compile/compile-object-run.c (compile_object_run): Replace
11383 throw_exception with throw.
11384 * cli/cli-script.c (process_next_line): Replace throw_exception
11385 with throw.
11386 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11387 (btrace_enable, btrace_maint_update_pt_packets): Replace
11388 throw_exception with throw.
11389 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11390 throw_exception with throw.
11391 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11392 throw_exception with throw.
11393 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11394 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11395 * aarch64-tdep.c (aarch64_make_prologue_cache)
11396 (aarch64_make_stub_cache): Replace throw_exception with throw.
11397
11398 2019-04-08 Tom Tromey <tom@tromey.com>
11399
11400 * common/common-exceptions.c (throw_exception): Rename from
11401 throw_exception_cxx. Remove old copy. Make argument const.
11402 (throw_it): Create and throw exception objects directly.
11403 * common/common-exceptions.h (throw_exception): Make argument
11404 const.
11405 (struct gdb_exception_error): Add constructor.
11406 (struct gdb_exception_quit): Add constructor.
11407
11408 2019-04-08 Tom Tromey <tom@tromey.com>
11409
11410 * common/common-exceptions.h (exception_rethrow): Don't declare.
11411 (TRY_SJLJ): Update comment.
11412 (TRY, CATCH, END_CATCH): Remove.
11413 * common/common-exceptions.c (exception_rethrow): Remove.
11414
11415 2019-04-08 Tom Tromey <tom@tromey.com>
11416
11417 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11418 Remove.
11419 (gdb_exception_error): Rename from
11420 gdb_exception_RETURN_MASK_ERROR.
11421 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11422 (gdb_quit_bad_alloc): Update.
11423 * aarch64-tdep.c: Update.
11424 * ada-lang.c: Update.
11425 * ada-typeprint.c: Update.
11426 * ada-valprint.c: Update.
11427 * amd64-tdep.c: Update.
11428 * arch-utils.c: Update.
11429 * break-catch-throw.c: Update.
11430 * breakpoint.c: Update.
11431 * btrace.c: Update.
11432 * c-varobj.c: Update.
11433 * cli/cli-cmds.c: Update.
11434 * cli/cli-interp.c: Update.
11435 * cli/cli-script.c: Update.
11436 * common/common-exceptions.c: Update.
11437 * common/new-op.c: Update.
11438 * common/selftest.c: Update.
11439 * compile/compile-c-symbols.c: Update.
11440 * compile/compile-cplus-symbols.c: Update.
11441 * compile/compile-object-load.c: Update.
11442 * compile/compile-object-run.c: Update.
11443 * completer.c: Update.
11444 * corelow.c: Update.
11445 * cp-abi.c: Update.
11446 * cp-support.c: Update.
11447 * cp-valprint.c: Update.
11448 * darwin-nat.c: Update.
11449 * disasm-selftests.c: Update.
11450 * dtrace-probe.c: Update.
11451 * dwarf-index-cache.c: Update.
11452 * dwarf-index-write.c: Update.
11453 * dwarf2-frame-tailcall.c: Update.
11454 * dwarf2-frame.c: Update.
11455 * dwarf2loc.c: Update.
11456 * dwarf2read.c: Update.
11457 * eval.c: Update.
11458 * event-loop.c: Update.
11459 * event-top.c: Update.
11460 * exec.c: Update.
11461 * f-valprint.c: Update.
11462 * fbsd-tdep.c: Update.
11463 * frame-unwind.c: Update.
11464 * frame.c: Update.
11465 * gdbtypes.c: Update.
11466 * gnu-v3-abi.c: Update.
11467 * guile/guile-internal.h: Update.
11468 * guile/scm-block.c: Update.
11469 * guile/scm-breakpoint.c: Update.
11470 * guile/scm-cmd.c: Update.
11471 * guile/scm-disasm.c: Update.
11472 * guile/scm-frame.c: Update.
11473 * guile/scm-lazy-string.c: Update.
11474 * guile/scm-math.c: Update.
11475 * guile/scm-param.c: Update.
11476 * guile/scm-ports.c: Update.
11477 * guile/scm-pretty-print.c: Update.
11478 * guile/scm-symbol.c: Update.
11479 * guile/scm-symtab.c: Update.
11480 * guile/scm-type.c: Update.
11481 * guile/scm-value.c: Update.
11482 * i386-linux-tdep.c: Update.
11483 * i386-tdep.c: Update.
11484 * inf-loop.c: Update.
11485 * infcall.c: Update.
11486 * infcmd.c: Update.
11487 * infrun.c: Update.
11488 * jit.c: Update.
11489 * language.c: Update.
11490 * linespec.c: Update.
11491 * linux-fork.c: Update.
11492 * linux-nat.c: Update.
11493 * linux-tdep.c: Update.
11494 * linux-thread-db.c: Update.
11495 * main.c: Update.
11496 * mi/mi-cmd-break.c: Update.
11497 * mi/mi-cmd-stack.c: Update.
11498 * mi/mi-interp.c: Update.
11499 * mi/mi-main.c: Update.
11500 * objc-lang.c: Update.
11501 * p-valprint.c: Update.
11502 * parse.c: Update.
11503 * ppc-linux-tdep.c: Update.
11504 * printcmd.c: Update.
11505 * python/py-arch.c: Update.
11506 * python/py-breakpoint.c: Update.
11507 * python/py-cmd.c: Update.
11508 * python/py-finishbreakpoint.c: Update.
11509 * python/py-frame.c: Update.
11510 * python/py-framefilter.c: Update.
11511 * python/py-gdb-readline.c: Update.
11512 * python/py-inferior.c: Update.
11513 * python/py-infthread.c: Update.
11514 * python/py-lazy-string.c: Update.
11515 * python/py-linetable.c: Update.
11516 * python/py-objfile.c: Update.
11517 * python/py-param.c: Update.
11518 * python/py-prettyprint.c: Update.
11519 * python/py-progspace.c: Update.
11520 * python/py-record-btrace.c: Update.
11521 * python/py-record.c: Update.
11522 * python/py-symbol.c: Update.
11523 * python/py-type.c: Update.
11524 * python/py-unwind.c: Update.
11525 * python/py-utils.c: Update.
11526 * python/py-value.c: Update.
11527 * python/python.c: Update.
11528 * record-btrace.c: Update.
11529 * record-full.c: Update.
11530 * remote-fileio.c: Update.
11531 * remote.c: Update.
11532 * riscv-tdep.c: Update.
11533 * rs6000-aix-tdep.c: Update.
11534 * rs6000-tdep.c: Update.
11535 * rust-exp.y: Update.
11536 * rust-lang.c: Update.
11537 * s390-tdep.c: Update.
11538 * selftest-arch.c: Update.
11539 * solib-dsbt.c: Update.
11540 * solib-frv.c: Update.
11541 * solib-spu.c: Update.
11542 * solib-svr4.c: Update.
11543 * solib.c: Update.
11544 * sparc64-linux-tdep.c: Update.
11545 * stack.c: Update.
11546 * symfile-mem.c: Update.
11547 * symmisc.c: Update.
11548 * target.c: Update.
11549 * thread.c: Update.
11550 * top.c: Update.
11551 * tracefile-tfile.c: Update.
11552 * tui/tui.c: Update.
11553 * typeprint.c: Update.
11554 * unittests/cli-utils-selftests.c: Update.
11555 * unittests/parse-connection-spec-selftests.c: Update.
11556 * valops.c: Update.
11557 * valprint.c: Update.
11558 * value.c: Update.
11559 * varobj.c: Update.
11560 * windows-nat.c: Update.
11561 * x86-linux-nat.c: Update.
11562 * xml-support.c: Update.
11563
11564 2019-04-08 Tom Tromey <tom@tromey.com>
11565
11566 * xml-support.c: Use C++ exception handling.
11567 * x86-linux-nat.c: Use C++ exception handling.
11568 * windows-nat.c: Use C++ exception handling.
11569 * varobj.c: Use C++ exception handling.
11570 * value.c: Use C++ exception handling.
11571 * valprint.c: Use C++ exception handling.
11572 * valops.c: Use C++ exception handling.
11573 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11574 handling.
11575 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11576 * typeprint.c: Use C++ exception handling.
11577 * tui/tui.c: Use C++ exception handling.
11578 * tracefile-tfile.c: Use C++ exception handling.
11579 * top.c: Use C++ exception handling.
11580 * thread.c: Use C++ exception handling.
11581 * target.c: Use C++ exception handling.
11582 * symmisc.c: Use C++ exception handling.
11583 * symfile-mem.c: Use C++ exception handling.
11584 * stack.c: Use C++ exception handling.
11585 * sparc64-linux-tdep.c: Use C++ exception handling.
11586 * solib.c: Use C++ exception handling.
11587 * solib-svr4.c: Use C++ exception handling.
11588 * solib-spu.c: Use C++ exception handling.
11589 * solib-frv.c: Use C++ exception handling.
11590 * solib-dsbt.c: Use C++ exception handling.
11591 * selftest-arch.c: Use C++ exception handling.
11592 * s390-tdep.c: Use C++ exception handling.
11593 * rust-lang.c: Use C++ exception handling.
11594 * rust-exp.y: Use C++ exception handling.
11595 * rs6000-tdep.c: Use C++ exception handling.
11596 * rs6000-aix-tdep.c: Use C++ exception handling.
11597 * riscv-tdep.c: Use C++ exception handling.
11598 * remote.c: Use C++ exception handling.
11599 * remote-fileio.c: Use C++ exception handling.
11600 * record-full.c: Use C++ exception handling.
11601 * record-btrace.c: Use C++ exception handling.
11602 * python/python.c: Use C++ exception handling.
11603 * python/py-value.c: Use C++ exception handling.
11604 * python/py-utils.c: Use C++ exception handling.
11605 * python/py-unwind.c: Use C++ exception handling.
11606 * python/py-type.c: Use C++ exception handling.
11607 * python/py-symbol.c: Use C++ exception handling.
11608 * python/py-record.c: Use C++ exception handling.
11609 * python/py-record-btrace.c: Use C++ exception handling.
11610 * python/py-progspace.c: Use C++ exception handling.
11611 * python/py-prettyprint.c: Use C++ exception handling.
11612 * python/py-param.c: Use C++ exception handling.
11613 * python/py-objfile.c: Use C++ exception handling.
11614 * python/py-linetable.c: Use C++ exception handling.
11615 * python/py-lazy-string.c: Use C++ exception handling.
11616 * python/py-infthread.c: Use C++ exception handling.
11617 * python/py-inferior.c: Use C++ exception handling.
11618 * python/py-gdb-readline.c: Use C++ exception handling.
11619 * python/py-framefilter.c: Use C++ exception handling.
11620 * python/py-frame.c: Use C++ exception handling.
11621 * python/py-finishbreakpoint.c: Use C++ exception handling.
11622 * python/py-cmd.c: Use C++ exception handling.
11623 * python/py-breakpoint.c: Use C++ exception handling.
11624 * python/py-arch.c: Use C++ exception handling.
11625 * printcmd.c: Use C++ exception handling.
11626 * ppc-linux-tdep.c: Use C++ exception handling.
11627 * parse.c: Use C++ exception handling.
11628 * p-valprint.c: Use C++ exception handling.
11629 * objc-lang.c: Use C++ exception handling.
11630 * mi/mi-main.c: Use C++ exception handling.
11631 * mi/mi-interp.c: Use C++ exception handling.
11632 * mi/mi-cmd-stack.c: Use C++ exception handling.
11633 * mi/mi-cmd-break.c: Use C++ exception handling.
11634 * main.c: Use C++ exception handling.
11635 * linux-thread-db.c: Use C++ exception handling.
11636 * linux-tdep.c: Use C++ exception handling.
11637 * linux-nat.c: Use C++ exception handling.
11638 * linux-fork.c: Use C++ exception handling.
11639 * linespec.c: Use C++ exception handling.
11640 * language.c: Use C++ exception handling.
11641 * jit.c: Use C++ exception handling.
11642 * infrun.c: Use C++ exception handling.
11643 * infcmd.c: Use C++ exception handling.
11644 * infcall.c: Use C++ exception handling.
11645 * inf-loop.c: Use C++ exception handling.
11646 * i386-tdep.c: Use C++ exception handling.
11647 * i386-linux-tdep.c: Use C++ exception handling.
11648 * guile/scm-value.c: Use C++ exception handling.
11649 * guile/scm-type.c: Use C++ exception handling.
11650 * guile/scm-symtab.c: Use C++ exception handling.
11651 * guile/scm-symbol.c: Use C++ exception handling.
11652 * guile/scm-pretty-print.c: Use C++ exception handling.
11653 * guile/scm-ports.c: Use C++ exception handling.
11654 * guile/scm-param.c: Use C++ exception handling.
11655 * guile/scm-math.c: Use C++ exception handling.
11656 * guile/scm-lazy-string.c: Use C++ exception handling.
11657 * guile/scm-frame.c: Use C++ exception handling.
11658 * guile/scm-disasm.c: Use C++ exception handling.
11659 * guile/scm-cmd.c: Use C++ exception handling.
11660 * guile/scm-breakpoint.c: Use C++ exception handling.
11661 * guile/scm-block.c: Use C++ exception handling.
11662 * guile/guile-internal.h: Use C++ exception handling.
11663 * gnu-v3-abi.c: Use C++ exception handling.
11664 * gdbtypes.c: Use C++ exception handling.
11665 * frame.c: Use C++ exception handling.
11666 * frame-unwind.c: Use C++ exception handling.
11667 * fbsd-tdep.c: Use C++ exception handling.
11668 * f-valprint.c: Use C++ exception handling.
11669 * exec.c: Use C++ exception handling.
11670 * event-top.c: Use C++ exception handling.
11671 * event-loop.c: Use C++ exception handling.
11672 * eval.c: Use C++ exception handling.
11673 * dwarf2read.c: Use C++ exception handling.
11674 * dwarf2loc.c: Use C++ exception handling.
11675 * dwarf2-frame.c: Use C++ exception handling.
11676 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11677 * dwarf-index-write.c: Use C++ exception handling.
11678 * dwarf-index-cache.c: Use C++ exception handling.
11679 * dtrace-probe.c: Use C++ exception handling.
11680 * disasm-selftests.c: Use C++ exception handling.
11681 * darwin-nat.c: Use C++ exception handling.
11682 * cp-valprint.c: Use C++ exception handling.
11683 * cp-support.c: Use C++ exception handling.
11684 * cp-abi.c: Use C++ exception handling.
11685 * corelow.c: Use C++ exception handling.
11686 * completer.c: Use C++ exception handling.
11687 * compile/compile-object-run.c: Use C++ exception handling.
11688 * compile/compile-object-load.c: Use C++ exception handling.
11689 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11690 * compile/compile-c-symbols.c: Use C++ exception handling.
11691 * common/selftest.c: Use C++ exception handling.
11692 * common/new-op.c: Use C++ exception handling.
11693 * cli/cli-script.c: Use C++ exception handling.
11694 * cli/cli-interp.c: Use C++ exception handling.
11695 * cli/cli-cmds.c: Use C++ exception handling.
11696 * c-varobj.c: Use C++ exception handling.
11697 * btrace.c: Use C++ exception handling.
11698 * breakpoint.c: Use C++ exception handling.
11699 * break-catch-throw.c: Use C++ exception handling.
11700 * arch-utils.c: Use C++ exception handling.
11701 * amd64-tdep.c: Use C++ exception handling.
11702 * ada-valprint.c: Use C++ exception handling.
11703 * ada-typeprint.c: Use C++ exception handling.
11704 * ada-lang.c: Use C++ exception handling.
11705 * aarch64-tdep.c: Use C++ exception handling.
11706
11707 2019-04-08 Tom Tromey <tom@tromey.com>
11708
11709 * xml-support.c (gdb_xml_parser::parse): Update.
11710 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11711 * value.c (show_convenience): Update.
11712 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11713 (test_parse_flags_qcs): Update.
11714 * thread.c (thr_try_catch_cmd): Update.
11715 * target.c (target_translate_tls_address): Update.
11716 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11717 (info_frame_command_core, frame_apply_command_count): Update.
11718 * rust-exp.y (rust_lex_exception_test): Update.
11719 * riscv-tdep.c (riscv_print_one_register_info): Update.
11720 * remote.c (remote_target::enable_btrace): Update.
11721 * record-btrace.c (record_btrace_enable_warn): Update.
11722 * python/py-utils.c (gdbpy_convert_exception): Update.
11723 * printcmd.c (do_one_display, print_variable_and_value): Update.
11724 * mi/mi-main.c (mi_print_exception): Update.
11725 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11726 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11727 * linux-nat.c (linux_nat_target::attach): Update.
11728 * linux-fork.c (class scoped_switch_fork_info): Update.
11729 * infrun.c (displaced_step_prepare): Update.
11730 * infcall.c (call_function_by_hand_dummy): Update.
11731 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11732 * gnu-v3-abi.c (print_one_vtable): Update.
11733 * frame.c (get_prev_frame_always): Update.
11734 * f-valprint.c (info_common_command_for_block): Update.
11735 * exec.c (try_open_exec_file): Update.
11736 * exceptions.c (print_exception, exception_print)
11737 (exception_fprintf, exception_print_same): Update.
11738 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11739 * dwarf-index-cache.c (index_cache::store)
11740 (index_cache::lookup_gdb_index): Update.
11741 * darwin-nat.c (maybe_cache_shell): Update.
11742 * cp-valprint.c (cp_print_value_fields): Update.
11743 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11744 (gcc_cplus_symbol_address): Update.
11745 * compile/compile-c-symbols.c (gcc_convert_symbol)
11746 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11747 * common/selftest.c: Update.
11748 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11749 a std::string.
11750 (exception_try_scope_entry, exception_try_scope_exit): Don't
11751 declare.
11752 (struct exception_try_scope): Remove.
11753 (TRY): Don't use exception_try_scope.
11754 (struct gdb_exception): Add constructor, operator=.
11755 <what>: New method.
11756 (struct gdb_exception_RETURN_MASK_ALL)
11757 (struct gdb_exception_RETURN_MASK_ERROR)
11758 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11759 (struct gdb_quit_bad_alloc): Update.
11760 * common/common-exceptions.c (exception_none): Change
11761 initializer.
11762 (struct catcher) <state, exception>: Initialize inline.
11763 <prev>: Remove member.
11764 (current_catcher): Remove.
11765 (catchers): New global.
11766 (exceptions_state_mc_init): Simplify.
11767 (catcher_pop): Remove.
11768 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11769 (try_scope_depth, exception_try_scope_entry)
11770 (exception_try_scope_exit): Remove.
11771 (throw_exception_sjlj): Update.
11772 (exception_messages, exception_messages_size): Remove.
11773 (throw_it): Simplify.
11774 (gdb_exception_sliced_copy): Remove.
11775 (throw_exception_cxx): Update.
11776 * cli/cli-script.c (script_from_file): Update.
11777 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11778 Update.
11779 * ada-valprint.c (ada_val_print): Update.
11780 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11781 (create_excep_cond_exprs): Update.
11782
11783 2019-04-08 Tom Tromey <tom@tromey.com>
11784
11785 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11786 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11787 (TRY, CATCH, END_CATCH): Remove some definitions.
11788 * common/common-exceptions.c: Don't use GDB_XCPT.
11789 (catcher_list_size): Remove.
11790 (throw_exception, throw_it): Simplify.
11791
11792 2019-04-05 Tom Tromey <tom@tromey.com>
11793
11794 Revert the header-sorting patch.
11795 * ft32-tdep.c: Revert.
11796 * frv-tdep.c: Revert.
11797 * frv-linux-tdep.c: Revert.
11798 * frame.c: Revert.
11799 * frame-unwind.c: Revert.
11800 * frame-base.c: Revert.
11801 * fork-child.c: Revert.
11802 * findvar.c: Revert.
11803 * findcmd.c: Revert.
11804 * filesystem.c: Revert.
11805 * filename-seen-cache.h: Revert.
11806 * filename-seen-cache.c: Revert.
11807 * fbsd-tdep.c: Revert.
11808 * fbsd-nat.h: Revert.
11809 * fbsd-nat.c: Revert.
11810 * f-valprint.c: Revert.
11811 * f-typeprint.c: Revert.
11812 * f-lang.c: Revert.
11813 * extension.h: Revert.
11814 * extension.c: Revert.
11815 * extension-priv.h: Revert.
11816 * expprint.c: Revert.
11817 * exec.h: Revert.
11818 * exec.c: Revert.
11819 * exceptions.c: Revert.
11820 * event-top.c: Revert.
11821 * event-loop.c: Revert.
11822 * eval.c: Revert.
11823 * elfread.c: Revert.
11824 * dwarf2read.h: Revert.
11825 * dwarf2read.c: Revert.
11826 * dwarf2loc.c: Revert.
11827 * dwarf2expr.h: Revert.
11828 * dwarf2expr.c: Revert.
11829 * dwarf2-frame.c: Revert.
11830 * dwarf2-frame-tailcall.c: Revert.
11831 * dwarf-index-write.h: Revert.
11832 * dwarf-index-write.c: Revert.
11833 * dwarf-index-common.c: Revert.
11834 * dwarf-index-cache.h: Revert.
11835 * dwarf-index-cache.c: Revert.
11836 * dummy-frame.c: Revert.
11837 * dtrace-probe.c: Revert.
11838 * disasm.h: Revert.
11839 * disasm.c: Revert.
11840 * disasm-selftests.c: Revert.
11841 * dictionary.c: Revert.
11842 * dicos-tdep.c: Revert.
11843 * demangle.c: Revert.
11844 * dcache.h: Revert.
11845 * dcache.c: Revert.
11846 * darwin-nat.h: Revert.
11847 * darwin-nat.c: Revert.
11848 * darwin-nat-info.c: Revert.
11849 * d-valprint.c: Revert.
11850 * d-namespace.c: Revert.
11851 * d-lang.c: Revert.
11852 * ctf.c: Revert.
11853 * csky-tdep.c: Revert.
11854 * csky-linux-tdep.c: Revert.
11855 * cris-tdep.c: Revert.
11856 * cris-linux-tdep.c: Revert.
11857 * cp-valprint.c: Revert.
11858 * cp-support.c: Revert.
11859 * cp-namespace.c: Revert.
11860 * cp-abi.c: Revert.
11861 * corelow.c: Revert.
11862 * corefile.c: Revert.
11863 * continuations.c: Revert.
11864 * completer.h: Revert.
11865 * completer.c: Revert.
11866 * complaints.c: Revert.
11867 * coffread.c: Revert.
11868 * coff-pe-read.c: Revert.
11869 * cli-out.h: Revert.
11870 * cli-out.c: Revert.
11871 * charset.c: Revert.
11872 * c-varobj.c: Revert.
11873 * c-valprint.c: Revert.
11874 * c-typeprint.c: Revert.
11875 * c-lang.c: Revert.
11876 * buildsym.c: Revert.
11877 * buildsym-legacy.c: Revert.
11878 * build-id.h: Revert.
11879 * build-id.c: Revert.
11880 * btrace.c: Revert.
11881 * bsd-uthread.c: Revert.
11882 * breakpoint.h: Revert.
11883 * breakpoint.c: Revert.
11884 * break-catch-throw.c: Revert.
11885 * break-catch-syscall.c: Revert.
11886 * break-catch-sig.c: Revert.
11887 * blockframe.c: Revert.
11888 * block.c: Revert.
11889 * bfin-tdep.c: Revert.
11890 * bfin-linux-tdep.c: Revert.
11891 * bfd-target.c: Revert.
11892 * bcache.c: Revert.
11893 * ax-general.c: Revert.
11894 * ax-gdb.h: Revert.
11895 * ax-gdb.c: Revert.
11896 * avr-tdep.c: Revert.
11897 * auxv.c: Revert.
11898 * auto-load.c: Revert.
11899 * arm-wince-tdep.c: Revert.
11900 * arm-tdep.c: Revert.
11901 * arm-symbian-tdep.c: Revert.
11902 * arm-pikeos-tdep.c: Revert.
11903 * arm-obsd-tdep.c: Revert.
11904 * arm-nbsd-tdep.c: Revert.
11905 * arm-nbsd-nat.c: Revert.
11906 * arm-linux-tdep.c: Revert.
11907 * arm-linux-nat.c: Revert.
11908 * arm-fbsd-tdep.c: Revert.
11909 * arm-fbsd-nat.c: Revert.
11910 * arm-bsd-tdep.c: Revert.
11911 * arch-utils.c: Revert.
11912 * arc-tdep.c: Revert.
11913 * arc-newlib-tdep.c: Revert.
11914 * annotate.h: Revert.
11915 * annotate.c: Revert.
11916 * amd64-windows-tdep.c: Revert.
11917 * amd64-windows-nat.c: Revert.
11918 * amd64-tdep.c: Revert.
11919 * amd64-sol2-tdep.c: Revert.
11920 * amd64-obsd-tdep.c: Revert.
11921 * amd64-obsd-nat.c: Revert.
11922 * amd64-nbsd-tdep.c: Revert.
11923 * amd64-nbsd-nat.c: Revert.
11924 * amd64-nat.c: Revert.
11925 * amd64-linux-tdep.c: Revert.
11926 * amd64-linux-nat.c: Revert.
11927 * amd64-fbsd-tdep.c: Revert.
11928 * amd64-fbsd-nat.c: Revert.
11929 * amd64-dicos-tdep.c: Revert.
11930 * amd64-darwin-tdep.c: Revert.
11931 * amd64-bsd-nat.c: Revert.
11932 * alpha-tdep.c: Revert.
11933 * alpha-obsd-tdep.c: Revert.
11934 * alpha-nbsd-tdep.c: Revert.
11935 * alpha-mdebug-tdep.c: Revert.
11936 * alpha-linux-tdep.c: Revert.
11937 * alpha-linux-nat.c: Revert.
11938 * alpha-bsd-tdep.c: Revert.
11939 * alpha-bsd-nat.c: Revert.
11940 * aix-thread.c: Revert.
11941 * agent.c: Revert.
11942 * addrmap.c: Revert.
11943 * ada-varobj.c: Revert.
11944 * ada-valprint.c: Revert.
11945 * ada-typeprint.c: Revert.
11946 * ada-tasks.c: Revert.
11947 * ada-lang.c: Revert.
11948 * aarch64-tdep.c: Revert.
11949 * aarch64-ravenscar-thread.c: Revert.
11950 * aarch64-newlib-tdep.c: Revert.
11951 * aarch64-linux-tdep.c: Revert.
11952 * aarch64-linux-nat.c: Revert.
11953 * aarch64-fbsd-tdep.c: Revert.
11954 * aarch64-fbsd-nat.c: Revert.
11955 * aarch32-linux-nat.c: Revert.
11956
11957 2019-04-05 Tom Tromey <tom@tromey.com>
11958
11959 * ft32-tdep.c: Sort headers.
11960 * frv-tdep.c: Sort headers.
11961 * frv-linux-tdep.c: Sort headers.
11962 * frame.c: Sort headers.
11963 * frame-unwind.c: Sort headers.
11964 * frame-base.c: Sort headers.
11965 * fork-child.c: Sort headers.
11966 * findvar.c: Sort headers.
11967 * findcmd.c: Sort headers.
11968 * filesystem.c: Sort headers.
11969 * filename-seen-cache.h: Sort headers.
11970 * filename-seen-cache.c: Sort headers.
11971 * fbsd-tdep.c: Sort headers.
11972 * fbsd-nat.h: Sort headers.
11973 * fbsd-nat.c: Sort headers.
11974 * f-valprint.c: Sort headers.
11975 * f-typeprint.c: Sort headers.
11976 * f-lang.c: Sort headers.
11977 * extension.h: Sort headers.
11978 * extension.c: Sort headers.
11979 * extension-priv.h: Sort headers.
11980 * expprint.c: Sort headers.
11981 * exec.h: Sort headers.
11982 * exec.c: Sort headers.
11983 * exceptions.c: Sort headers.
11984 * event-top.c: Sort headers.
11985 * event-loop.c: Sort headers.
11986 * eval.c: Sort headers.
11987 * elfread.c: Sort headers.
11988 * dwarf2read.h: Sort headers.
11989 * dwarf2read.c: Sort headers.
11990 * dwarf2loc.c: Sort headers.
11991 * dwarf2expr.h: Sort headers.
11992 * dwarf2expr.c: Sort headers.
11993 * dwarf2-frame.c: Sort headers.
11994 * dwarf2-frame-tailcall.c: Sort headers.
11995 * dwarf-index-write.h: Sort headers.
11996 * dwarf-index-write.c: Sort headers.
11997 * dwarf-index-common.c: Sort headers.
11998 * dwarf-index-cache.h: Sort headers.
11999 * dwarf-index-cache.c: Sort headers.
12000 * dummy-frame.c: Sort headers.
12001 * dtrace-probe.c: Sort headers.
12002 * disasm.h: Sort headers.
12003 * disasm.c: Sort headers.
12004 * disasm-selftests.c: Sort headers.
12005 * dictionary.c: Sort headers.
12006 * dicos-tdep.c: Sort headers.
12007 * demangle.c: Sort headers.
12008 * dcache.h: Sort headers.
12009 * dcache.c: Sort headers.
12010 * darwin-nat.h: Sort headers.
12011 * darwin-nat.c: Sort headers.
12012 * darwin-nat-info.c: Sort headers.
12013 * d-valprint.c: Sort headers.
12014 * d-namespace.c: Sort headers.
12015 * d-lang.c: Sort headers.
12016 * ctf.c: Sort headers.
12017 * csky-tdep.c: Sort headers.
12018 * csky-linux-tdep.c: Sort headers.
12019 * cris-tdep.c: Sort headers.
12020 * cris-linux-tdep.c: Sort headers.
12021 * cp-valprint.c: Sort headers.
12022 * cp-support.c: Sort headers.
12023 * cp-namespace.c: Sort headers.
12024 * cp-abi.c: Sort headers.
12025 * corelow.c: Sort headers.
12026 * corefile.c: Sort headers.
12027 * continuations.c: Sort headers.
12028 * completer.h: Sort headers.
12029 * completer.c: Sort headers.
12030 * complaints.c: Sort headers.
12031 * coffread.c: Sort headers.
12032 * coff-pe-read.c: Sort headers.
12033 * cli-out.h: Sort headers.
12034 * cli-out.c: Sort headers.
12035 * charset.c: Sort headers.
12036 * c-varobj.c: Sort headers.
12037 * c-valprint.c: Sort headers.
12038 * c-typeprint.c: Sort headers.
12039 * c-lang.c: Sort headers.
12040 * buildsym.c: Sort headers.
12041 * buildsym-legacy.c: Sort headers.
12042 * build-id.h: Sort headers.
12043 * build-id.c: Sort headers.
12044 * btrace.c: Sort headers.
12045 * bsd-uthread.c: Sort headers.
12046 * breakpoint.h: Sort headers.
12047 * breakpoint.c: Sort headers.
12048 * break-catch-throw.c: Sort headers.
12049 * break-catch-syscall.c: Sort headers.
12050 * break-catch-sig.c: Sort headers.
12051 * blockframe.c: Sort headers.
12052 * block.c: Sort headers.
12053 * bfin-tdep.c: Sort headers.
12054 * bfin-linux-tdep.c: Sort headers.
12055 * bfd-target.c: Sort headers.
12056 * bcache.c: Sort headers.
12057 * ax-general.c: Sort headers.
12058 * ax-gdb.h: Sort headers.
12059 * ax-gdb.c: Sort headers.
12060 * avr-tdep.c: Sort headers.
12061 * auxv.c: Sort headers.
12062 * auto-load.c: Sort headers.
12063 * arm-wince-tdep.c: Sort headers.
12064 * arm-tdep.c: Sort headers.
12065 * arm-symbian-tdep.c: Sort headers.
12066 * arm-pikeos-tdep.c: Sort headers.
12067 * arm-obsd-tdep.c: Sort headers.
12068 * arm-nbsd-tdep.c: Sort headers.
12069 * arm-nbsd-nat.c: Sort headers.
12070 * arm-linux-tdep.c: Sort headers.
12071 * arm-linux-nat.c: Sort headers.
12072 * arm-fbsd-tdep.c: Sort headers.
12073 * arm-fbsd-nat.c: Sort headers.
12074 * arm-bsd-tdep.c: Sort headers.
12075 * arch-utils.c: Sort headers.
12076 * arc-tdep.c: Sort headers.
12077 * arc-newlib-tdep.c: Sort headers.
12078 * annotate.h: Sort headers.
12079 * annotate.c: Sort headers.
12080 * amd64-windows-tdep.c: Sort headers.
12081 * amd64-windows-nat.c: Sort headers.
12082 * amd64-tdep.c: Sort headers.
12083 * amd64-sol2-tdep.c: Sort headers.
12084 * amd64-obsd-tdep.c: Sort headers.
12085 * amd64-obsd-nat.c: Sort headers.
12086 * amd64-nbsd-tdep.c: Sort headers.
12087 * amd64-nbsd-nat.c: Sort headers.
12088 * amd64-nat.c: Sort headers.
12089 * amd64-linux-tdep.c: Sort headers.
12090 * amd64-linux-nat.c: Sort headers.
12091 * amd64-fbsd-tdep.c: Sort headers.
12092 * amd64-fbsd-nat.c: Sort headers.
12093 * amd64-dicos-tdep.c: Sort headers.
12094 * amd64-darwin-tdep.c: Sort headers.
12095 * amd64-bsd-nat.c: Sort headers.
12096 * alpha-tdep.c: Sort headers.
12097 * alpha-obsd-tdep.c: Sort headers.
12098 * alpha-nbsd-tdep.c: Sort headers.
12099 * alpha-mdebug-tdep.c: Sort headers.
12100 * alpha-linux-tdep.c: Sort headers.
12101 * alpha-linux-nat.c: Sort headers.
12102 * alpha-bsd-tdep.c: Sort headers.
12103 * alpha-bsd-nat.c: Sort headers.
12104 * aix-thread.c: Sort headers.
12105 * agent.c: Sort headers.
12106 * addrmap.c: Sort headers.
12107 * ada-varobj.c: Sort headers.
12108 * ada-valprint.c: Sort headers.
12109 * ada-typeprint.c: Sort headers.
12110 * ada-tasks.c: Sort headers.
12111 * ada-lang.c: Sort headers.
12112 * aarch64-tdep.c: Sort headers.
12113 * aarch64-ravenscar-thread.c: Sort headers.
12114 * aarch64-newlib-tdep.c: Sort headers.
12115 * aarch64-linux-tdep.c: Sort headers.
12116 * aarch64-linux-nat.c: Sort headers.
12117 * aarch64-fbsd-tdep.c: Sort headers.
12118 * aarch64-fbsd-nat.c: Sort headers.
12119 * aarch32-linux-nat.c: Sort headers.
12120
12121 2019-04-04 Tom Tromey <tom@tromey.com>
12122
12123 * varobj.c (varobj_create): Update.
12124 * rust-exp.y (struct rust_parser) <update_innermost_block,
12125 lookup_symbol>: New methods.
12126 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12127 Rename.
12128 (rust_parser::rust_lookup_type)
12129 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12130 * printcmd.c (display_command, do_one_display): Update.
12131 * parser-defs.h (struct parser_state) <parser_state>: Add
12132 "tracker" parameter.
12133 (block_tracker): New member.
12134 (class innermost_block_tracker) <innermost_block_tracker>: Add
12135 "types" parameter.
12136 <reset>: Remove method.
12137 (innermost_block): Don't declare.
12138 (null_post_parser): Update.
12139 * parse.c (innermost_block): Remove global.
12140 (write_dollar_variable): Update.
12141 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12142 Remove "tracker_types" parameter.
12143 (parse_expression): Add "tracker" parameter.
12144 (parse_expression_for_completion): Update.
12145 (null_post_parser): Add "tracker" parameter.
12146 * p-exp.y: Update rules.
12147 * m2-exp.y: Update rules.
12148 * language.h (struct language_defn) <la_post_parser>: Add
12149 "tracker" parameter.
12150 * go-exp.y: Update rules.
12151 * f-exp.y: Update rules.
12152 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12153 parameter.
12154 * d-exp.y: Update rules.
12155 * c-exp.y: Update rules.
12156 * breakpoint.c (set_breakpoint_condition): Create an
12157 innermost_block_tracker.
12158 (watch_command_1): Likewise.
12159 * ada-lang.c (resolve): Add "tracker" parameter.
12160 (resolve_subexp): Likewise.
12161 * ada-exp.y (write_var_from_sym): Update.
12162
12163 2019-04-04 Tom Tromey <tom@tromey.com>
12164
12165 * type-stack.h: New file.
12166 * type-stack.c: New file.
12167 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12168 type-stack.h.
12169 (insert_into_type_stack, insert_type, push_type, push_type_int)
12170 (insert_type_address_space, pop_type, pop_type_int)
12171 (pop_typelist, pop_type_stack, append_type_stack)
12172 (push_type_stack, get_type_stack, push_typelist)
12173 (follow_type_instance_flags, follow_types): Don't declare.
12174 * parse.c (type_stack): Remove global.
12175 (parse_exp_in_context): Update.
12176 (insert_into_type_stack, insert_type, push_type, push_type_int)
12177 (insert_type_address_space, pop_type, pop_type_int)
12178 (pop_typelist, pop_type_stack, append_type_stack)
12179 (push_type_stack, get_type_stack, push_typelist)
12180 (follow_type_instance_flags, follow_types): Remove (moved to
12181 type-stack.c).
12182 * f-exp.y (type_stack): New global.
12183 Update rules.
12184 (push_kind_type, f_parse): Update.
12185 * d-exp.y (type_stack): New global.
12186 Update rules.
12187 (d_parse): Update.
12188 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12189 Update rules.
12190 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12191 (HFILES_NO_SRCDIR): Add type-stack.h.
12192
12193 2019-04-04 Tom Tromey <tom@tromey.com>
12194
12195 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12196 (rust_parser::convert_ast_to_expression, rust_parse)
12197 (rust_lex_test_completion, rust_lex_tests): Update.
12198 * parser-defs.h (struct expr_completion_state): New.
12199 (struct parser_state) <parser_state>: Add completion parameter.
12200 <mark_struct_expression, mark_completion_tag>: New methods.
12201 <parse_completion, m_completion_state>: New members.
12202 (prefixify_expression, null_post_parser): Update.
12203 (mark_struct_expression, mark_completion_tag): Don't declare.
12204 * parse.c (parse_completion, expout_last_struct)
12205 (expout_tag_completion_type, expout_completion_name): Remove
12206 globals.
12207 (parser_state::mark_struct_expression)
12208 (parser_state::mark_completion_tag): Now methods.
12209 (prefixify_expression): Add last_struct parameter.
12210 (prefixify_subexp): Likewise.
12211 (parse_exp_1): Update.
12212 (parse_exp_in_context): Add cstate parameter. Update.
12213 (parse_expression_for_completion): Create an
12214 expr_completion_state.
12215 (null_post_parser): Add "completion" parameter.
12216 * p-exp.y: Update rules.
12217 (yylex): Update.
12218 * language.h (struct language_defn) <la_post_parser>: Add
12219 "completing" parameter.
12220 * go-exp.y: Update rules.
12221 (lex_one_token): Update.
12222 * expression.h (parse_completion): Don't declare.
12223 * d-exp.y: Update rules.
12224 (lex_one_token): Update rules.
12225 * c-exp.y: Update rules.
12226 (lex_one_token): Update.
12227 * ada-lang.c (resolve): Add "parse_completion" parameter.
12228 (resolve_subexp): Likewise.
12229 (ada_resolve_function): Likewise.
12230
12231 2019-04-04 Tom Tromey <tom@tromey.com>
12232
12233 * parser-defs.h (struct parser_state) <start_arglist,
12234 end_arglist>: New methods.
12235 <arglist_len, m_funcall_chain>: New members.
12236 (arglist_len, start_arglist, end_arglist): Don't declare.
12237 * parse.c (arglist_len, funcall_chain): Remove global.
12238 (start_arglist, end_arglist): Remove functions.
12239 (parse_exp_in_context): Update.
12240 * p-exp.y: Update rules.
12241 * m2-exp.y: Update rules.
12242 * go-exp.y: Update rules.
12243 * f-exp.y: Update rules.
12244 * d-exp.y: Update rules.
12245 * c-exp.y: Update rules.
12246
12247 2019-04-04 Tom Tromey <tom@tromey.com>
12248
12249 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12250 lex_operator, push_back>: New methods.
12251 Update all rules.
12252 (rust_parser::lex_hex, lex_escape): Rename and update.
12253 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12254 (rust_parser::lex_operator): Rename and update.
12255 (rust_parser::lex_number, rustyylex, rustyyerror)
12256 (rust_lex_test_init, rust_lex_test_sequence)
12257 (rust_lex_test_push_back, rust_lex_tests): Update.
12258 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12259 parameter.
12260 <lexptr, prev_lexptr>: New members.
12261 (lexptr, prev_lexptr): Don't declare.
12262 * parse.c (lexptr, prev_lexptr): Remove globals.
12263 (parse_exp_in_context): Update.
12264 * p-exp.y (yylex, yyerror): Update.
12265 * m2-exp.y (parse_number, yylex, yyerror): Update.
12266 * go-exp.y (lex_one_token, yyerror): Update.
12267 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12268 * d-exp.y (lex_one_token, yyerror): Update.
12269 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12270 (lex_one_token, yyerror): Update.
12271 * ada-lex.l (YY_INPUT): Update.
12272 (rewind_to_char): Update.
12273 * ada-exp.y (yyerror): Update.
12274
12275 2019-04-04 Tom Tromey <tom@tromey.com>
12276
12277 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12278 * parser-defs.h (struct parser_state) <parser_state>: Add new
12279 parameter.
12280 <comma_terminates>: New member.
12281 (comma_terminates): Don't declare global.
12282 * parse.c (comma_terminates): Remove global.
12283 (parse_exp_in_context): Update.
12284 * p-exp.y (yylex): Update.
12285 * m2-exp.y (yylex): Update.
12286 * go-exp.y (lex_one_token): Update.
12287 * f-exp.y (yylex): Update.
12288 * d-exp.y (lex_one_token): Update.
12289 * c-exp.y (lex_one_token): Update.
12290 * ada-lex.l: Update.
12291
12292 2019-04-04 Tom Tromey <tom@tromey.com>
12293
12294 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12295 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12296 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12297 * parser-defs.h (paren_depth): Don't declare.
12298 * parse.c (paren_depth): Remove global.
12299 (parse_exp_in_context): Update.
12300 * p-exp.y (paren_depth): New global.
12301 (pascal_parse): Initialize it.
12302 * m2-exp.y (paren_depth): New global.
12303 (m2_parse): Initialize it.
12304 * go-exp.y (paren_depth): New global.
12305 (go_parse): Initialize it.
12306 * f-exp.y (paren_depth): New global.
12307 (f_parse): Initialize it.
12308 * d-exp.y (paren_depth): New global.
12309 (d_parse): Initialize it.
12310 * c-exp.y (paren_depth): New global.
12311 (c_parse): Initialize it.
12312 * ada-lex.l (paren_depth): New global.
12313 (lexer_init): Initialize it.
12314
12315 2019-04-04 Tom Tromey <tom@tromey.com>
12316
12317 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12318 (rust_parser::convert_ast_to_type)
12319 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12320 * parser-defs.h (struct parser_state) <parser_state>: Add
12321 parameters. Initialize new members.
12322 <expression_context_block, expression_context_pc>: New members.
12323 * parse.c (expression_context_block, expression_context_pc):
12324 Remove globals.
12325 (parse_exp_in_context): Update.
12326 * p-exp.y: Update all rules.
12327 (yylex): Update.
12328 * m2-exp.y: Update all rules.
12329 (yylex): Update.
12330 * go-exp.y (yylex): Update.
12331 * f-exp.y (yylex): Update.
12332 * d-exp.y: Update all rules.
12333 (yylex): Update.
12334 * c-exp.y: Update all rules.
12335 (lex_one_token, classify_name, yylex, c_parse): Update.
12336 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12337
12338 2019-04-04 Tom Tromey <tom@tromey.com>
12339
12340 * gdbarch.h, gdbarch.c: Rebuild.
12341 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12342 * stap-probe.h:
12343 (struct stap_parse_info): Replace "parser_state" with
12344 "expr_builder".
12345 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12346 (parser_state): New class.
12347 * parse.c (expr_builder): Rename.
12348 (expr_builder::release): Rename.
12349 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12350 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12351 (write_exp_elt_longcst, write_exp_elt_floatcst)
12352 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12353 (write_exp_string_vector, write_exp_bitstring)
12354 (write_exp_msymbol, mark_struct_expression)
12355 (write_dollar_variable)
12356 (insert_type_address_space, increase_expout_size): Replace
12357 "parser_state" with "expr_builder".
12358 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12359 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12360 "parser_state" with "expr_builder".
12361
12362 2019-04-04 Tom Tromey <tom@tromey.com>
12363
12364 * rust-exp.y: Replace "parse_language" with method call.
12365 * p-exp.y:
12366 (yylex): Replace "parse_language" with method call.
12367 * m2-exp.y:
12368 (yylex): Replace "parse_language" with method call.
12369 * go-exp.y (classify_name): Replace "parse_language" with method
12370 call.
12371 * f-exp.y (yylex): Replace "parse_language" with method call.
12372 * d-exp.y (lex_one_token): Replace "parse_language" with method
12373 call.
12374 * c-exp.y:
12375 (lex_one_token, classify_name, yylex): Replace "parse_language"
12376 with method call.
12377 * ada-exp.y (find_primitive_type, type_char)
12378 (type_system_address): Replace "parse_language" with method call.
12379
12380 2019-04-04 Tom Tromey <tom@tromey.com>
12381
12382 * rust-exp.y: Replace "parse_gdbarch" with method call.
12383 * parse.c (write_dollar_variable, insert_type_address_space):
12384 Replace "parse_gdbarch" with method call.
12385 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12386 call.
12387 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12388 call.
12389 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12390 "parse_gdbarch" with method call.
12391 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12392 with method call.
12393 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12394 "parse_gdbarch" with method call.
12395 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12396 "parse_gdbarch" with method call.
12397 * c-exp.y (parse_type, parse_number, classify_name): Replace
12398 "parse_gdbarch" with method call.
12399 * ada-lex.l: Replace "parse_gdbarch" with method call.
12400 * ada-exp.y (parse_type, find_primitive_type, type_char)
12401 (type_system_address): Replace "parse_gdbarch" with method call.
12402
12403 2019-04-04 Tom Tromey <tom@tromey.com>
12404
12405 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12406 * stap-probe.c (stap_parse_argument): Update.
12407 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12408 initial_size parameter.
12409 * rust-exp.y (rust_lex_tests): Update.
12410 * parse.c (parser_state): Update.
12411 (parse_exp_in_context): Update.
12412 * parser-defs.h (struct parser_state) <parser_state>: Remove
12413 "initial_size" parameter.
12414
12415 2019-04-04 Tom Tromey <tom@tromey.com>
12416
12417 * parser-defs.h (increase_expout_size): Don't declare.
12418 * parse.c (increase_expout_size): Now static.
12419
12420 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12421
12422 * gnu-nat.c (gnu_nat_target::wait): Fix
12423 target_waitstatus_to_string call.
12424
12425 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12426
12427 * eval.c (evaluate_subexp_standard): Handle internal functions
12428 during Fortran function call handling.
12429
12430 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12431
12432 * NEWS: Mention new internal functions.
12433 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12434 (read_base_type): Use dwarf2_init_complex_target_type.
12435 * value.c (creal_internal_fn): New function.
12436 (cimag_internal_fn): New function.
12437 (_initialize_values): Register new internal functions.
12438
12439 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12440
12441 * infrun.c (stop_all_threads): If debug_infrun, always
12442 trace the wait status after wait_one, using
12443 target_waitstatus_to_string and target_pid_to_str.
12444 (handle_inferior_event): Replace various trace of
12445 wait status kind by a single trace.
12446 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12447 wait status kind image by target_waitstatus_to_string.
12448 * target/waitstatus.c (target_waitstatus_to_string): Fix
12449 obsolete comment.
12450
12451 2019-04-01 Tom Tromey <tromey@adacore.com>
12452
12453 PR symtab/23331:
12454 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12455
12456 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12457 Pedro Alves <palves@redhat.com>
12458
12459 * top.c (quit_force): Call 'finalize_values'.
12460 * value.c (finalize_values): New function.
12461 * value.h (finalize_values): Declare.
12462
12463 2019-03-30 Eli Zaretskii <eliz@gnu.org>
12464
12465 * NEWS: Announce $_gdb_major and $_gdb_minor.
12466
12467 * top.c (init_gdb_version_vars): New function.
12468 (gdb_init): Call init_gdb_version_vars.
12469
12470 2019-03-29 Tom Tromey <tromey@adacore.com>
12471
12472 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12473 help text. Remove dead code.
12474
12475 2019-03-29 Keith Seitz <keiths@redhat.com>
12476
12477 From Siddhesh Poyarekar:
12478 * f-lang.h (f77_get_upperbound): Return LONGEST.
12479 (f77_get_lowerbound): Likewise.
12480 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12481 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12482 print them.
12483 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12484 plongest to format print it.
12485 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12486 (f77_get_upperbound): Likewise.
12487 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12488 LOWER_BOUND to LONGEST.
12489 (f77_create_arrayprint_offset_tbl): Likewise.
12490
12491 2019-03-29 Keith Seitz <keiths@redhat.com>
12492
12493 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12494 %s/pulongest for TYPE_LENGTH instead of %d in format
12495 strings.
12496 * ada-typerint.c (ada_print_type): Likewise.
12497 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12498 * compile/compile-c-support.c (generate_register_struct): Likewise.
12499 * gdbtypes.c (recursive_dump_type): Likewise.
12500 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12501 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12502 instead of %d in format strings.
12503 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12504 to std::min to ULONGEST.
12505 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12506 instead of %d in format strings.
12507 * tracepoint.c (info_scope_command): Likewise.
12508 * typeprint.c (print_offset_data::update)
12509 (print_offset_data::finish): Likewise.
12510 * xtensa-tdep.c (xtensa_store_return_value)
12511 (xtensa_push_dummy_call): Likewise.
12512
12513 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12514
12515 * windows-nat.c (display_selector): Fixed format specifications
12516 for 64-bit Cygwin.
12517
12518 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12519
12520 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12521
12522 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12523
12524 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12525 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12526 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12527 (nios2_linux_init_abi): Install it.
12528
12529 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12530
12531 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12532
12533 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12534
12535 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12536
12537 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12538 Tom Tromey <tromey@adacore.com>
12539
12540 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12541
12542 2019-03-26 Joel Brobecker <brobecker@adacore.com>
12543
12544 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12545 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12546 method to compute the bounds of range types. Also print "[evaluated]"
12547 if the bounds' values come from a dynamic evaluation.
12548
12549 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12550
12551 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12552 whitespace when pretty printing is on.
12553
12554 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12555
12556 * ppc-linux-nat.c: Add include.
12557
12558 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12559
12560 * NEWS: Mention AArch64 Pointer Authentication.
12561
12562 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12563
12564 * arm-linux-nat.c: Add include.
12565
12566 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12567
12568 * source-cache.c (source_cache::get_source_lines): Re-read
12569 fullname after calling open_source_file.
12570
12571 2019-03-25 John Baldwin <jhb@FreeBSD.org>
12572
12573 * NEWS: Mention TLS support for FreeBSD.
12574
12575 2019-03-25 Tom Tromey <tromey@adacore.com>
12576
12577 * minsyms.c (BUNCH_SIZE): Update comment.
12578 (~minimal_symbol_reader): Remove old comment.
12579 (compact_minimal_symbols): Update comment.
12580 (minimal_symbol_reader::install): Remove old comment. Update
12581 other comments.
12582
12583 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12584
12585 * s390-linux-nat.c: Add include.
12586
12587 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12588
12589 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12590 Call linux_get_hwcap.
12591 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12592 Likewise.
12593 (aarch64_linux_get_hwcap): Remove function.
12594 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12595 declaration.
12596 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12597 linux_get_hwcap.
12598 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12599 * linux-tdep.c (linux_get_hwcap): Add function.
12600 (linux_get_hwcap2): Likewise.
12601 * linux-tdep.h (linux_get_hwcap): Add declaration.
12602 (linux_get_hwcap2): Likewise.
12603 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12604 (ppc_linux_get_hwcap2): Likewise.
12605 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12606 linux_get_hwcap.
12607 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12608 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12609 (ppc_linux_nat_target::read_description): Likewise.
12610 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12611 * s390-linux-nat.c: Likewise.
12612 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12613
12614 2019-03-24 Tom Tromey <tom@tromey.com>
12615
12616 * ada-lang.c (standard_lookup): Simplify initialization.
12617 (ada_lookup_symbol_nonlocal): Simplify return.
12618 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12619 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12620 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12621 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12622 initialization.
12623 * solib.c (solib_global_lookup): Simplify.
12624 * symtab.c (null_block_symbol): Remove.
12625 (symbol_cache_lookup): Simplify returns.
12626 (lookup_language_this): Simplify returns.
12627 (lookup_symbol_aux): Simplify return.
12628 (lookup_local_symbol): Simplify returns.
12629 (lookup_global_symbol_from_objfile): Simplify return.
12630 (lookup_symbol_in_objfile_symtabs)
12631 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12632 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12633 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12634 * cp-namespace.c (cp_lookup_bare_symbol)
12635 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12636 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12637 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12638 (cp_lookup_symbol_via_imports): Simplify initialization.
12639 (find_symbol_in_baseclass): Likewise.
12640 * symtab.h (null_block_symbol): Remove.
12641 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12642 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12643 (d_lookup_symbol_module): Likewise.
12644 (find_symbol_in_baseclass): Simplify initialization.
12645
12646 2019-03-24 Tom Tromey <tom@tromey.com>
12647
12648 * expression.h: Don't include symtab.h.
12649 (struct block): Forward declare.
12650
12651 2019-03-24 Tom Tromey <tom@tromey.com>
12652
12653 * c-exp.y (typebase): Remove casts.
12654 * gdbtypes.c (lookup_unsigned_typename, )
12655 (lookup_signed_typename): Remove cast.
12656 * eval.c (parse_to_comma_and_eval): Remove cast.
12657 * parse.c (write_dollar_variable): Remove cast.
12658 * block.h (struct block) <superblock>: Now const.
12659 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12660 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12661 (map_block): Make "block" const.
12662 * symfile.h (struct quick_symbol_functions)
12663 <map_matching_symbols>: Constify block argument to "callback".
12664 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12665 const.
12666 (find_pc_sect_compunit_symtab): Make "b" const.
12667 (find_symbol_at_address): Likewise.
12668 (search_symbols): Likewise.
12669 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12670 (dw2_debug_names_lookup_symbol): Likewise.
12671 (dw2_map_matching_symbols): Update.
12672 * p-valprint.c (pascal_val_print): Remove "block".
12673 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12674 (aux_add_nonlocal_symbols): Make "block" const.
12675 (resolve_subexp): Remove cast.
12676 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12677 const.
12678 (iterate_over_file_blocks): Likewise.
12679 * f-exp.y (%union) <bval>: Remove.
12680 * coffread.c (patch_opaque_types): Make "b" const.
12681 * spu-tdep.c (spu_catch_start): Make "block" const.
12682 * c-valprint.c (print_unpacked_pointer): Remove "block".
12683 * symmisc.c (dump_symtab_1): Make "b" const.
12684 (block_depth): Make "block" const.
12685 * d-exp.y (%union) <bval>: Remove.
12686 * cp-support.h (cp_lookup_rtti_type): Update.
12687 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12688 * psymtab.c (psym_lookup_symbol): Make "block" const.
12689 (maintenance_check_psymtabs): Make "b" const.
12690 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12691 (enumerate_locals, enumerate_args): Update.
12692 * python/py-symtab.c (stpy_global_block): Make "block" const.
12693 (stpy_static_block): Likewise.
12694 * inline-frame.c (block_starting_point_at): Make "new_block"
12695 const.
12696 * block.c (find_block_in_blockvector): Make return type const.
12697 (blockvector_for_pc_sect): Make "b" const.
12698 (find_block_in_blockvector): Make "b" const.
12699
12700 2019-03-23 Tom Tromey <tom@tromey.com>
12701
12702 * varobj.c (varobj_create): Update.
12703 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12704 * printcmd.c (display_command, do_one_display): Don't reset
12705 innermost_block.
12706 * parser-defs.h (enum innermost_block_tracker_type): Move to
12707 expression.h.
12708 (innermost_block): Update comment.
12709 * parse.c (parse_exp_1): Add tracker_types parameter.
12710 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12711 tracker_types parameter. Reset innermost_block.
12712 (parse_exp_in_context): Remove.
12713 (parse_expression_for_completion): Update.
12714 * objfiles.c (~objfile): Don't reset expression_context_block or
12715 innermost_block.
12716 * expression.h (enum innermost_block_tracker_type): Move from
12717 parser-defs.h.
12718 (parse_exp_1): Add tracker_types parameter.
12719 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12720 reset innermost_block.
12721
12722 2019-03-23 Tom Tromey <tom@tromey.com>
12723
12724 * objfiles.h: Include bcache.h.
12725
12726 2019-03-23 Tom Tromey <tom@tromey.com>
12727
12728 * linespec.c (get_current_search_block): Use
12729 scoped_restore_current_language.
12730 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12731
12732 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12733 Jiong Wang <jiong.wang@arm.com>
12734
12735 * aarch64-linux-tdep.c
12736 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12737 section.
12738 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12739
12740 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12741 Jiong Wang <jiong.wang@arm.com>
12742
12743 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12744 instructions.
12745 (aarch64_analyze_prologue_test): Add PACIASP test.
12746 (aarch64_prologue_prev_register): Unmask PC value.
12747
12748 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12749 Jiong Wang <jiong.wang@arm.com>
12750
12751 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12752 (aarch64_dwarf2_prev_register): Unmask PC value.
12753 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12754 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12755 DW_CFA_AARCH64_negate_ra_state.
12756 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12757
12758 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12759 Jiong Wang <jiong.wang@arm.com>
12760
12761 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12762 registers.
12763 (aarch64_pseudo_register_name): Likewise.
12764 (aarch64_pseudo_register_type): Likewise.
12765 (aarch64_pseudo_register_reggroup_p): Likewise.
12766 (aarch64_gdbarch_init): Add pauth registers.
12767 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12768 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12769 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12770 (struct gdbarch_tdep): Add regnum for ra_state.
12771
12772 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12773 Jiong Wang <jiong.wang@arm.com>
12774
12775 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12776
12777 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12778 Jiong Wang <jiong.wang@arm.com>
12779
12780 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12781 function.
12782 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12783 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12784 (aarch64_gdbarch_init): Add puth registers.
12785 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12786 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12787 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12788
12789 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12790 Jiong Wang <jiong.wang@arm.com>
12791
12792 * aarch64-linux-nat.c
12793 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12794 * aarch64-linux-tdep.c
12795 (aarch64_linux_core_read_description): Likewise.
12796 (aarch64_linux_get_hwcap): New function.
12797 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12798 (aarch64_linux_get_hwcap): New declaration.
12799
12800 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12801 Jiong Wang <jiong.wang@arm.com>
12802
12803 * aarch64-linux-nat.c
12804 (aarch64_linux_nat_target::read_description): Add pauth param.
12805 * aarch64-linux-tdep.c
12806 (aarch64_linux_core_read_description): Likewise.
12807 * aarch64-tdep.c (struct target_desc): Add in pauth.
12808 (aarch64_read_description): Add pauth param.
12809 (aarch64_gdbarch_init): Likewise.
12810 * aarch64-tdep.h (aarch64_read_description): Likewise.
12811 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12812 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12813 * features/Makefile: Add new files.
12814 * features/aarch64-pauth.c: New file.
12815 * features/aarch64-pauth.xml: New file.
12816
12817 2019-03-20 Tom Tromey <tromey@adacore.com>
12818
12819 * infrun.c (handle_inferior_event): Rename from
12820 handle_inferior_event_1. Create a scoped_value_mark.
12821 (handle_inferior_event): Remove.
12822
12823 2019-03-19 Tom Tromey <tromey@adacore.com>
12824
12825 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12826 * infrun.h (print_stop_event): Add "displays" parameter.
12827 * infrun.c (print_stop_event): Add "displays" parameter.
12828
12829 2019-03-19 Pedro Alves <palves@redhat.com>
12830
12831 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12832 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12833 to -1. Fix TABs vs spaces.
12834 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12835 * tui/tui-out.h (tui_ui_out) Add intro comments.
12836 <m_line, m_start_of_line>: In-class initialize, and add describing
12837 comment.
12838
12839 2019-03-18 Alan Hayward <alan.hayward@arm.com>
12840
12841 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12842 variable names.
12843 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12844
12845 2019-03-18 Pedro Alves <palves@redhat.com>
12846 Eli Zaretskii <eliz@gnu.org>
12847
12848 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12849 m_line and m_start_of_line.
12850
12851 2019-03-18 Eli Zaretskii <eliz@gnu.org>
12852
12853 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12854 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12855 it returns a newline. This fixes a regression in TU mode, whereby
12856 the next line is output on the same screen line as the user input.
12857
12858 2019-03-18 Tom Tromey <tromey@adacore.com>
12859
12860 * minsyms.c (minimal_symbol_reader::install): Remove call to
12861 obstack_blank.
12862
12863 2019-03-18 Pedro Alves <palves@redhat.com>
12864
12865 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12866 New globals.
12867 (apply_style): New, factored out from ...
12868 (apply_ansi_escape): ... this. Handle reverse video mode.
12869 (tui_set_reverse_mode): New function.
12870 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12871 * tui/tui-winsource.c (tui_show_source_line): Use
12872 tui_set_reverse_mode instead of setting A_STANDOUT.
12873 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12874 New setter methods.
12875
12876 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
12877
12878 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12879 Handle tabs.
12880
12881 2019-03-18 Tom Tromey <tromey@adacore.com>
12882
12883 * ada-lang.c (empty_array): Add "high" parameter.
12884 (ada_evaluate_subexp): Update.
12885
12886 2019-03-17 Sergei Trofimovich <siarheit@google.com>
12887
12888 * unittests/string_view-selftests.c: Define
12889 _initialize_string_view_selftests unconditionally.
12890
12891 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12892
12893 PR gdb/24350
12894 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12895
12896 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12897
12898 PR gdb/24351
12899 * windows-nat.c (display_selector): Fix format specifiers.
12900
12901 2019-03-17 Eli Zaretskii <eliz@gnu.org>
12902
12903 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12904 tui_refill_source_window instead of tui_refresh_win, to update the
12905 current execution line. This fixes redisplay of the current line
12906 when stepping through the code with "next" or "step".
12907
12908 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12909
12910 * source-cache.c (source_cache::get_source_lines): Call
12911 find_source_lines to initialize s->nlines. This fixes vertical
12912 scrolling of TUI source window when the DOWN arrow is pressed.
12913
12914 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12915
12916 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12917 linux-thread-db.c (_initialize_thread_db): Likewise.
12918
12919 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12920
12921 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12922 wclrtoeol in tui_show_source_line". This reverts changes made in
12923 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12924
12925 2019-03-15 Tom Tromey <tom@tromey.com>
12926
12927 * symtab.h (struct minimal_symbol): Derive from
12928 general_symbol_info.
12929 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12930 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12931 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12932 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12933 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12934 (MSYMBOL_SEARCH_NAME): Update.
12935 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12936 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12937 * minsyms.c (minimal_symbol_reader::record_full): Update.
12938
12939 2019-03-15 Tom Tromey <tom@tromey.com>
12940
12941 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12942
12943 2019-03-15 Tom Tromey <tom@tromey.com>
12944
12945 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12946 unique_xmalloc_ptr.
12947 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12948 Update.
12949 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12950 (build_minimal_symbol_hash_tables)
12951 (minimal_symbol_reader::install): Update.
12952
12953 2019-03-15 Tom Tromey <tom@tromey.com>
12954
12955 * symtab.c (create_demangled_names_hash): Update.
12956 (symbol_set_names): Update.
12957 * objfiles.h (struct objfile_per_bfd_storage)
12958 <demangled_names_hash>: Now an htab_up.
12959 * objfiles.c (objfile_per_bfd_storage): Simplify.
12960
12961 2019-03-15 Tom Tromey <tom@tromey.com>
12962
12963 * objfiles.h (struct objfile_per_bfd_storage): Declare
12964 destructor.
12965 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12966 New.
12967 (get_objfile_bfd_data): Use new. Don't initialize
12968 language_of_main.
12969 (free_objfile_per_bfd_storage): Remove.
12970 (objfile_bfd_data_free, objfile::~objfile): Use delete.
12971
12972 2019-03-15 Tom Tromey <tom@tromey.com>
12973
12974 * symfile.c (reread_symbols): Update.
12975 * objfiles.c (objfile::objfile): Update.
12976 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12977 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12978 comment.
12979 (minimal_symbol_reader::install): Update.
12980 (terminate_minimal_symbol_table): Remove.
12981 * jit.c (jit_object_close_impl): Update.
12982
12983 2019-03-15 Tom Tromey <tom@tromey.com>
12984
12985 * minsyms.c (minimal_symbol_reader::record_full): Remove some
12986 initializations.
12987
12988 2019-03-15 Tom Tromey <tom@tromey.com>
12989
12990 * objfiles.h (struct objfile_per_bfd_storage)
12991 <demangled_hash_languages>: Now a bitset.
12992 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12993 (lookup_minimal_symbol): Update.
12994
12995 2019-03-15 Tom Tromey <tom@tromey.com>
12996
12997 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12998 Don't return the symbol.
12999 * coffread.c (record_minimal_symbol): Use record_full.
13000
13001 2019-03-14 Eli Zaretskii <eliz@gnu.org>
13002
13003 The MS-Windows port of ncurses fails to switch to a color pair if
13004 one or both of the colors are the implicit default colors. This
13005 change records the default colors when TUI is initialized, and
13006 then specifies them explicitly when a color pair uses the default
13007 colors. This allows color styling in TUI mode on MS-Windows.
13008
13009 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13010 ncurses_norm_attr.
13011 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13012 colors in ncurses_norm_attr.
13013 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13014 "none", replace it with the default color recorded in
13015 ncurses_norm_attr.
13016
13017 2019-03-14 Tom Tromey <tromey@adacore.com>
13018
13019 * source-cache.h (class source_cache) <get_source_lines>: Return
13020 std::string.
13021 * source-cache.c (source_cache::extract_lines): Handle case where
13022 first_pos==npos. Return std::string.
13023 (source_cache::get_source_lines): Update.
13024
13025 2019-03-14 Tom Tromey <tromey@adacore.com>
13026
13027 * NEWS: Add item for "style sources" commands.
13028 * source-cache.c (source_cache::get_source_lines): Check
13029 source_styling.
13030 * cli/cli-style.c (source_styling): New global.
13031 (_initialize_cli_style): Add "style sources" commands.
13032 (show_style_sources): New function.
13033 * cli/cli-style.h (source_styling): Declare.
13034
13035 2019-03-14 Pedro Alves <palves@redhat.com>
13036 Tom Tromey <tromey@adacore.com>
13037
13038 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13039 * tui/tui-winsource.c (tui_refill_source_window): New function,
13040 from...
13041 (tui_horizontal_source_scroll): ... here. Move some logic.
13042 * cli/cli-style.c (set_style_enabled): Notify new observable.
13043 * tui/tui-hooks.c (tui_redisplay_source): New function.
13044 (tui_attach_detach_observers): Attach or detach
13045 tui_redisplay_source.
13046 * observable.h (source_styling_changed): New observable.
13047 * observable.c: Define source_styling_changed observable.
13048
13049 2019-03-13 Tom Tromey <tromey@adacore.com>
13050
13051 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13052 (i386_gnu_nat_target::store_registers): Update.
13053 * target-debug.h (target_debug_print_std_string): New macro.
13054 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13055 * windows-tdep.c (display_one_tib): Update.
13056 * tui/tui-stack.c (tui_make_status_line): Update.
13057 * top.c (print_inferior_quit_action): Update.
13058 * thread.c (thr_try_catch_cmd): Update.
13059 (add_thread_with_info): Update.
13060 (thread_target_id_str): Update.
13061 (thr_try_catch_cmd): Update.
13062 (thread_command): Update.
13063 (thread_find_command): Update.
13064 * record-btrace.c (record_btrace_target::info_record)
13065 (record_btrace_resume_thread, record_btrace_target::resume)
13066 (record_btrace_cancel_resume, record_btrace_step_thread)
13067 (record_btrace_target::wait, record_btrace_target::wait)
13068 (record_btrace_target::wait, record_btrace_target::stop): Update.
13069 * progspace.c (print_program_space): Update.
13070 * process-stratum-target.c
13071 (process_stratum_target::thread_address_space): Update.
13072 * linux-fork.c (linux_fork_mourn_inferior)
13073 (detach_checkpoint_command, info_checkpoints_command)
13074 (linux_fork_context): Update.
13075 (linux_fork_detach): Update.
13076 (class scoped_switch_fork_info): Update.
13077 (delete_checkpoint_command): Update.
13078 * infrun.c (follow_fork_inferior): Update.
13079 (follow_fork_inferior): Update.
13080 (proceed_after_vfork_done): Update.
13081 (handle_vfork_child_exec_or_exit): Update.
13082 (follow_exec): Update.
13083 (displaced_step_prepare_throw): Update.
13084 (displaced_step_restore): Update.
13085 (start_step_over): Update.
13086 (resume_1): Update.
13087 (clear_proceed_status_thread): Update.
13088 (proceed): Update.
13089 (print_target_wait_results): Update.
13090 (do_target_wait): Update.
13091 (context_switch): Update.
13092 (stop_all_threads): Update.
13093 (restart_threads): Update.
13094 (finish_step_over): Update.
13095 (handle_signal_stop): Update.
13096 (switch_back_to_stepped_thread): Update.
13097 (keep_going_pass_signal): Update.
13098 (print_exited_reason): Update.
13099 (normal_stop): Update.
13100 * inferior.c (inferior_pid_to_str): Change return type.
13101 (print_selected_inferior): Update.
13102 (add_inferior): Update.
13103 (detach_inferior): Update.
13104 * dummy-frame.c (fprint_dummy_frames): Update.
13105 * dcache.c (dcache_info_1): Update.
13106 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13107 (btrace_fetch, btrace_clear): Update.
13108 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13109 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13110 type.
13111 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13112 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13113 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13114 * gdbarch.c, gdbarch.h: Rebuild.
13115 * gdbarch.sh (core_pid_to_str): Change return type.
13116 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13117 return type.
13118 (windows_nat_target::pid_to_str): Change return type.
13119 (windows_delete_thread): Update.
13120 (windows_nat_target::attach): Update.
13121 (windows_nat_target::files_info): Update.
13122 * target-delegates.c: Rebuild.
13123 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13124 return type.
13125 (sol_thread_target::pid_to_str): Change return type.
13126 * remote.c (class remote_target) <pid_to_str>: Change return
13127 type.
13128 (remote_target::pid_to_str): Change return type.
13129 (extended_remote_target::attach, remote_target::remote_stop_ns)
13130 (remote_target::remote_notif_remove_queued_reply)
13131 (remote_target::push_stop_reply, remote_target::disable_btrace):
13132 Update.
13133 (extended_remote_target::attach): Update.
13134 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13135 type.
13136 (gdbsim_target::pid_to_str): Change return type.
13137 * ravenscar-thread.c (struct ravenscar_thread_target)
13138 <pid_to_str>: Change return type.
13139 (ravenscar_thread_target::pid_to_str): Change return type.
13140 * procfs.c (class procfs_target) <pid_to_str>: Change return
13141 type.
13142 (procfs_target::pid_to_str): Change return type.
13143 (procfs_target::attach): Update.
13144 (procfs_target::detach): Update.
13145 (procfs_target::fetch_registers): Update.
13146 (procfs_target::store_registers): Update.
13147 (procfs_target::wait): Update.
13148 (procfs_target::files_info): Update.
13149 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13150 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13151 return type.
13152 (nto_procfs_target::pid_to_str): Change return type.
13153 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13154 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13155 return type.
13156 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13157 (exit_lwp): Update.
13158 (attach_proc_task_lwp_callback, get_detach_signal)
13159 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13160 (linux_nat_target::resume, wait_lwp, stop_callback)
13161 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13162 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13163 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13164 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13165 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13166 type.
13167 (inf_ptrace_target::attach): Update.
13168 (inf_ptrace_target::files_info): Update.
13169 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13170 type.
13171 (go32_nat_target::pid_to_str): Change return type.
13172 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13173 (gnu_nat_target::wait): Update.
13174 (gnu_nat_target::wait): Update.
13175 (gnu_nat_target::resume): Update.
13176 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13177 (fbsd_nat_target::wait): Update.
13178 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13179 type.
13180 (darwin_nat_target::attach): Update.
13181 * corelow.c (class core_target) <pid_to_str>: Change return type.
13182 (core_target::pid_to_str): Change return type.
13183 * target.c (normal_pid_to_str): Change return type.
13184 (default_pid_to_str): Likewise.
13185 (target_pid_to_str): Change return type.
13186 (target_translate_tls_address): Update.
13187 (target_announce_detach): Update.
13188 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13189 return type.
13190 (bsd_uthread_target::pid_to_str): Change return type.
13191 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13192 type.
13193 (bsd_kvm_target::pid_to_str): Change return type.
13194 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13195 return type.
13196 (aix_thread_target::pid_to_str): Change return type.
13197 * target.h (struct target_ops) <pid_to_str>: Change return type.
13198 (target_pid_to_str, normal_pid_to_str): Likewise.
13199 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13200 type.
13201 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13202 type.
13203 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13204 return type.
13205 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13206 type.
13207 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13208 type.
13209 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13210 return type.
13211
13212 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13213
13214 * NEWS: Mention that the new default MI version is 3. Mention
13215 changes to the output of commands and events that deal with
13216 multi-location breakpoints.
13217 * breakpoint.c: Include "mi/mi-out.h".
13218 (print_one_breakpoint): Change output syntax if using MI version
13219 >= 3.
13220 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13221 New.
13222 (mi_multi_location_breakpoint_output_fixed): New.
13223 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13224 (mi_cmd_fix_multi_location_breakpoint_output): New.
13225 (mi_multi_location_breakpoint_output_fixed): New.
13226 * mi/mi-cmds.c (mi_cmds): Register command
13227 -fix-multi-location-breakpoint-output.
13228 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13229 interpreter "mi".
13230
13231 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13232
13233 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13234 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13235 instantiate mi_ui_out based on interpreter name.
13236 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13237 * mi/mi-main.c (mi_load_progress): Likewise.
13238
13239 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13240
13241 * NEWS: Combine separate "New targets" sections for 8.3.
13242
13243 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13244
13245 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13246 (ppcfbsd_init_abi): Install gdbarch
13247 "fetch_tls_load_module_address" and "get_thread_local_address"
13248 methods.
13249
13250 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13251
13252 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13253 (riscv_fbsd_init_abi): Install gdbarch
13254 "fetch_tls_load_module_address" and "get_thread_local_address"
13255 methods.
13256
13257 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13258
13259 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13260 (i386fbsd_init_abi): Install gdbarch
13261 "fetch_tls_load_module_address" and "get_thread_local_address"
13262 methods.
13263
13264 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13265
13266 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13267 (amd64fbsd_init_abi): Install gdbarch
13268 "fetch_tls_load_module_address" and "get_thread_local_address"
13269 methods.
13270
13271 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13272
13273 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13274 (struct fbsd_pspace_data): New type.
13275 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13276 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13277 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13278 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13279 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13280
13281 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13282
13283 * gdbtypes.c (lookup_struct_elt): New function.
13284 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13285 * gdbtypes.h (struct struct_elt): New type.
13286 (lookup_struct_elt): New prototype.
13287
13288 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13289
13290 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13291 remove disabled code block.
13292
13293 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13294
13295 * gdbarch.sh (get_thread_local_address): New method.
13296 * gdbarch.h, gdbarch.c: Regenerate.
13297 * target.c (target_translate_tls_address): Use
13298 gdbarch_get_thread_local_address if present instead of
13299 target::get_thread_local_address.
13300
13301 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13302
13303 * target.h (target::get_thread_local_address): Update comment.
13304
13305 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13306
13307 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13308 objfile->separate_debug_objfile_backlink if not NULL.
13309
13310 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13311
13312 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13313 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13314 (amd64bsd_store_inferior_registers): Likewise.
13315 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13316 Enable segment base registers.
13317 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13318 PT_GETFSBASE and PT_GETGSBASE.
13319 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13320 PT_SETGSBASE.
13321 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13322 segment base registers.
13323 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13324
13325 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13326
13327 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13328 Update calls to i386_target_description to add 'segments'
13329 parameter.
13330 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13331 add segment base registers.
13332 * arch/i386.c (i386_create_target_description): Add 'segments'
13333 parameter to enable segment base registers.
13334 * arch/i386.h (i386_create_target_description): Likewise.
13335 * features/i386/32bit-segments.xml: New file.
13336 * features/i386/32bit-segments.c: Generate.
13337 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13338 call to i386_target_description to add 'segments' parameter.
13339 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13340 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13341 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13342 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13343 if feature is present.
13344 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13345 Add 'segments' parameter to call to i386_target_description.
13346 (i386_target_description): Add 'segments' parameter to enable
13347 segment base registers.
13348 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13349 to call to i386_target_description.
13350 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13351 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13352 Define I386_NUM_REGS.
13353 (i386_target_description): Add 'segments' parameter to enable
13354 segment base registers.
13355
13356 2019-03-12 Eli Zaretskii <eliz@gnu.org>
13357
13358 PR/24325
13359 * source-cache.c: #undef open and close, to avoid unresolved
13360 externals during linking.
13361
13362 2019-03-12 Tom Tromey <tromey@adacore.com>
13363
13364 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13365 const. Add initializers.
13366 (_initialize_remote): Don't initialize ptid globals.
13367
13368 2019-03-12 Pedro Alves <palves@redhat.com>
13369
13370 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13371
13372 2019-03-12 Pedro Alves <palves@redhat.com>
13373
13374 * cp-name-parser.y (main): Remove unused 'len' variable.
13375
13376 2019-03-12 Tom Tromey <tromey@adacore.com>
13377
13378 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13379 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13380
13381 2019-03-12 Tom Tromey <tromey@adacore.com>
13382
13383 * linux-nat.c (iterate_over_lwps): Update.
13384 (stop_callback): Remove parameter.
13385 (stop_wait_callback, detach_callback, resume_set_callback)
13386 (select_singlestep_lwp_callback, set_ignore_sigint)
13387 (status_callback, resumed_callback, resume_clear_callback)
13388 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13389 data parameter.
13390 (linux_nat_target::detach, linux_nat_target::resume)
13391 (linux_stop_and_wait_all_lwps, select_event_lwp)
13392 (linux_nat_filter_event, linux_nat_wait_1)
13393 (linux_nat_target::kill, linux_nat_target::stop)
13394 (linux_nat_target::stop): Update.
13395 (linux_nat_resume_callback): Change type.
13396 (resume_stopped_resumed_lwps, count_events_callback)
13397 (select_event_lwp_callback): Likewise.
13398 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13399 * arm-linux-nat.c (struct update_registers_data): Remove.
13400 (update_registers_callback): Change type.
13401 (arm_linux_insert_hw_breakpoint1): Update.
13402 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13403 parameter.
13404 (x86_linux_dr_set_addr): Update.
13405 (x86_linux_dr_set_control): Update.
13406 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13407 (iterate_over_lwps): Use gdb::function_view.
13408 * nat/aarch64-linux-hw-point.c (struct
13409 aarch64_dr_update_callback_param): Remove.
13410 (debug_reg_change_callback): Change type.
13411 (aarch64_notify_debug_reg_change): Update.
13412 * s390-linux-nat.c (s390_refresh_per_info): Update.
13413
13414 2019-03-11 Tom Tromey <tromey@adacore.com>
13415
13416 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13417 redundant assignment to "this_cu".
13418
13419 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13420
13421 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13422
13423 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13424
13425 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13426 from...
13427 (rank_one_type): ... this.
13428
13429 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13430
13431 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13432 from...
13433 (rank_one_type): ... this.
13434
13435 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13436
13437 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13438 from...
13439 (rank_one_type): ... this.
13440
13441 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13442
13443 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13444 from...
13445 (rank_one_type): ... this.
13446
13447 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13448
13449 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13450 from...
13451 (rank_one_type): ... this.
13452
13453 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13454
13455 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13456 from...
13457 (rank_one_type): ... this.
13458
13459 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13460
13461 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13462 from...
13463 (rank_one_type): ... this.
13464
13465 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13466
13467 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13468 from...
13469 (rank_one_type): ... this.
13470
13471 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13472
13473 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13474 from...
13475 (rank_one_type): ... this.
13476
13477 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13478
13479 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13480 from...
13481 (rank_one_type): ... this.
13482
13483 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13484
13485 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13486 from...
13487 (rank_one_type): ... this.
13488
13489 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13490
13491 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13492 from...
13493 (rank_one_type): ... this.
13494
13495 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13496
13497 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13498 inferior-events' shows the example events.
13499
13500 2019-03-08 Eli Zaretskii <eliz@gnu.org>
13501
13502 Support styling on native MS-Windows console
13503
13504 PR/24315
13505 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13506 on MS-Windows if $TERM is not defined.
13507
13508 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13509
13510 * posix-hdep.c (gdb_console_fputs):
13511 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13512 functions.
13513 * ui-file.h (gdb_console_fputs): Add prototype.
13514
13515 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13516 back to fputs only if the former returns zero.
13517
13518 2019-03-07 Tom Tromey <tom@tromey.com>
13519
13520 * symmisc.c (print_symbol_bcache_statistics): Update.
13521 (print_objfile_statistics): Update.
13522 * symfile.c (allocate_symtab): Update.
13523 * stabsread.c: Don't include bcache.h.
13524 * psymtab.h (struct psymbol_bcache): Don't declare.
13525 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13526 (psymbol_bcache_init, psymbol_bcache_free)
13527 (psymbol_bcache_get_bcache): Don't declare.
13528 * psymtab.c (struct psymbol_bcache): Remove.
13529 (psymtab_storage::psymtab_storage): Update.
13530 (psymtab_storage::~psymtab_storage): Update.
13531 (psymbol_bcache_init, psymbol_bcache_free)
13532 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13533 (add_psymbol_to_bcache): Update.
13534 (allocate_psymtab): Update.
13535 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13536 macro_cache>: No longer pointers.
13537 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13538 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13539 * macrotab.c (macro_bcache): Update.
13540 * macroexp.c: Don't include bcache.h.
13541 * gdbtypes.c (check_types_worklist): Update.
13542 (types_deeply_equal): Remove TRY/CATCH. Update.
13543 * elfread.c (elf_symtab_read): Update.
13544 * dwarf2read.c: Don't include bcache.h.
13545 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13546 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13547 (print_bcache_statistics, bcache_memory_used): Don't declare.
13548 (struct bcache): Move from bcache.c. Add constructor, destructor,
13549 methods. Rename all data members.
13550 * bcache.c (struct bcache): Move to bcache.h.
13551 (bcache::expand_hash_table): Rename from expand_hash_table.
13552 (bcache): Remove.
13553 (bcache::insert): Rename from bcache_full.
13554 (bcache::compare): Rename from bcache_compare.
13555 (bcache_xmalloc): Remove.
13556 (bcache::~bcache): Rename from bcache_xfree.
13557 (bcache::print_statistics): Rename from print_bcache_statistics.
13558 (bcache::memory_used): Rename from bcache_memory_used.
13559
13560 2019-03-07 Pedro Alves <palves@redhat.com>
13561
13562 * infrun.c (normal_stop): Also check for
13563 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13564
13565 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13566
13567 * f-lang.c (value_from_host_double): Moved to...
13568 * value.c (value_from_host_double): ...here.
13569 * value.h (value_from_host_double): Declare.
13570 * guile/scm-math.c (vlscm_convert_typed_number): Use
13571 value_from_host_double.
13572 (vlscm_convert_number): Likewise.
13573 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13574 * python/py-value.c (convert_value_from_python): Likewise.
13575
13576 2019-03-06 Tom Tromey <tom@tromey.com>
13577
13578 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13579
13580 2019-03-06 Tom Tromey <tom@tromey.com>
13581
13582 * utils.h (free_current_contents): Don't declare.
13583 * utils.c (free_current_contents): Remove.
13584
13585 2019-03-06 Tom Tromey <tom@tromey.com>
13586
13587 * top.c (quit_force): Update.
13588 * main.c (captured_command_loop): Update.
13589 * common/new-op.c (operator new): Update.
13590 * common/common-exceptions.c (struct catcher)
13591 <save_cleanup_chain>: Remove member.
13592 (exceptions_state_mc_init): Update.
13593 (exception_try_scope_entry): Return nullptr.
13594 (exception_try_scope_exit, exception_rethrow)
13595 (throw_exception_sjlj, throw_exception_cxx): Update.
13596 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13597 (all_cleanups, do_cleanups, discard_cleanups)
13598 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13599 (restore_cleanups, restore_final_cleanups): Don't declare.
13600 (do_final_cleanups): Remove parameter.
13601 * common/cleanups.c (cleanup_chain, make_cleanup)
13602 (make_cleanup_dtor, all_cleanups, do_cleanups)
13603 (discard_my_cleanups, discard_cleanups)
13604 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13605 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13606 (null_cleanup): Remove.
13607 (do_final_cleanups): Remove parameter.
13608
13609 2019-03-06 Tom Tromey <tom@tromey.com>
13610
13611 * remote.c (remote_target::remote_parse_stop_reply): Use
13612 unique_xmalloc_ptr.
13613
13614 2019-03-06 Tom Tromey <tom@tromey.com>
13615
13616 * stabsread.c (struct stabs_field_info): Rename from field_info.
13617 <list, fnlist>: Add initializers.
13618 <obstack>: New member.
13619 (read_member_functions, read_struct_fields, read_baseclasses):
13620 Allocate on obstack. Don't use cleanups.
13621 (read_one_struct_field, read_member_functions, read_struct_fields)
13622 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13623 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13624 (read_struct_type): Update.
13625
13626 2019-03-06 Tom Tromey <tom@tromey.com>
13627
13628 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13629 * common/filestuff.h (make_cleanup_close): Don't declare.
13630 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13631 Remove.
13632
13633 2019-03-06 Tom Tromey <tom@tromey.com>
13634
13635 * solib-aix.c: Use make_scope_exit.
13636
13637 2019-03-06 Tom Tromey <tom@tromey.com>
13638
13639 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13640 Use make_scope_exit.
13641
13642 2019-03-06 Tom Tromey <tom@tromey.com>
13643
13644 * solib-svr4.c (disable_probes_interface): Remove parameter.
13645 (svr4_handle_solib_event): Use make_scope_exit.
13646
13647 2019-03-06 Tom Tromey <tom@tromey.com>
13648
13649 * remote.c (struct stop_reply_deleter): Remove.
13650 (stop_reply_up): Update.
13651 (struct stop_reply): Derive from notif_event. Don't typedef.
13652 <regcache>: Now a std::vector.
13653 (stop_reply_xfree): Remove.
13654 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13655 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13656 (remote_target::discard_pending_stop_replies): Use delete.
13657 (remote_target::remote_parse_stop_reply): Update.
13658 (remote_target::process_stop_reply): Update.
13659 * remote-notif.h (struct notif_event): Add virtual destructor.
13660 Remove "dtr" member.
13661 (struct notif_client) <alloc_event>: Return a unique_ptr.
13662 (notif_event_xfree): Don't declare.
13663 (notif_event_up): New typedef.
13664 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13665 (notif_event_xfree, do_notif_event_xfree): Remove.
13666 (remote_notif_state_xfree): Update.
13667
13668 2019-03-06 Tom Tromey <tom@tromey.com>
13669
13670 * infrun.c (displaced_step_clear_cleanup): Now a
13671 forward_scope_exit type.
13672 (displaced_step_prepare_throw): Update.
13673 (displaced_step_fixup): Update.
13674
13675 2019-03-06 Tom Tromey <tom@tromey.com>
13676
13677 * inferior.h (class inferior): Update comment.
13678 * gdbthread.h (class thread_info): Update comment.
13679
13680 2019-03-06 Joel Brobecker <brobecker@adacore.com>
13681 Tom Tromey <tom@tromey.com>
13682
13683 * stabsread.h (struct stab_section_list): Remove.
13684 (coffstab_build_psymtabs): Update.
13685 * dbxread.c (symbuf_sections): Now a std::vector.
13686 (sect_idx): New global.
13687 (fill_symbuf): Update.
13688 (coffstab_build_psymtabs): Change type of stabsects parameter.
13689 Update.
13690 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13691 std::vector.
13692 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13693 (coff_locate_sections): Update.
13694 (coff_symfile_read): Remove cleanups. Update.
13695 (init_stringtab): Add storage parameter.
13696 (free_stringtab, free_stringtab_cleanup): Remove.
13697 (init_lineno): Add storage parameter.
13698 (free_linetab, free_linetab_cleanup): Remove.
13699
13700 2019-03-06 Pedro Alves <palves@redhat.com>
13701
13702 * linux-fork.c (fork_info::clobber_regs): Delete.
13703 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13704 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13705 comment. Adjust.
13706 (scoped_switch_fork_info::scoped_switch_fork_info)
13707 (checkpoint_command, linux_fork_context): Adjust
13708 fork_save_infrun_state calls.
13709
13710 2019-03-06 Pedro Alves <palves@redhat.com>
13711
13712 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13713 (inf_has_multiple_threads): Return 'bool' and rewrite using
13714 inferior_info::threads().
13715
13716 2019-03-06 Pedro Alves <palves@redhat.com>
13717
13718 * linux-fork.c: Include <list>.
13719 (fork_list): Now a std::list instance.
13720 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13721 (forks_exist_p, find_last_fork): Adjust.
13722 (new_fork): Delete.
13723 (one_fork_p): New.
13724 (add_fork): Adjust.
13725 (free_fork): Delete, folded into fork_info::~fork_info().
13726 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13727 Adjust.
13728 (init_fork_list): Delete.
13729 (linux_fork_killall, linux_fork_mourn_inferior)
13730 (linux_fork_detach, info_checkpoints_command): Adjust.
13731 (_initialize_linux_fork): No longer call init_fork_list.
13732
13733 2019-03-06 Pedro Alves <palves@redhat.com>
13734
13735 * linux-fork.c (new_fork): New, split out of ...
13736 (add_fork): ... this. Return void. Move "first fork" special
13737 case from here, to ...
13738 (checkpoint_command): ... here.
13739 * linux-linux.h (add_fork): Return void.
13740
13741 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13742
13743 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13744
13745 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13746 Chris January <chris.january@arm.com>
13747 David Lecomber <david.lecomber@arm.com>
13748
13749 * f-exp.y: New token, UNOP_INTRINSIC.
13750 (exp): New pattern using UNOP_INTRINSIC token.
13751 (f77_keywords): Add 'abs' keyword.
13752 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13753 (value_from_host_double): New function.
13754 (evaluate_subexp_f): Support UNOP_ABS.
13755
13756 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13757
13758 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13759 types.
13760
13761 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13762
13763 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13764 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13765 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13766
13767 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13768
13769 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13770
13771 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13772 Chris January <chris.january@arm.com>
13773
13774 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13775 * f-exp.y: Define 'KIND' token.
13776 (exp): New pattern for KIND expressions.
13777 (ptype): Handle types with a kind extension.
13778 (direct_abs_decl): Extend to spot kind extensions.
13779 (f77_keywords): Add 'kind' to the list.
13780 (push_kind_type): New function.
13781 (convert_to_kind_type): New function.
13782 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13783 * parse.c (operator_length_standard): Likewise.
13784 * parser-defs.h (enum type_pieces): Add tp_kind.
13785 * std-operator.def: Add UNOP_KIND.
13786
13787 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13788
13789 * f-exp.y (f_parse): Set yydebug.
13790
13791 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13792
13793 * f-lang.c (evaluate_subexp_f): New function.
13794 (exp_descriptor_f): New global.
13795 (f_language_defn): Use exp_descriptor_f instead of
13796 exp_descriptor_standard.
13797
13798 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13799
13800 * f-exp.y (struct token): Add comments.
13801 (dot_ops): Remove uppercase versions and the end marker.
13802 (f77_keywords): Likewise.
13803 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13804 entries in the dot_ops array are case insensitive, and use
13805 strncasecmp to compare strings. Also some whitespace cleanup in
13806 this area. Similar for the f77_keywords array, except entries in
13807 this list might be case sensitive.
13808
13809 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13810
13811 * f-exp.y (struct f77_boolean_val): Add comments.
13812 (boolean_values): Remove uppercase versions, and end marker.
13813 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13814 and use strncasecmp to achieve case insensitivity. Additionally,
13815 perform whitespace cleanup around this code.
13816
13817 2019-03-06 Tom Tromey <tromey@adacore.com>
13818
13819 * remote-sim.c (gdbsim_target_open): Use result of
13820 gdb_argv::release.
13821
13822 2019-03-06 Richard Bunt <richard.bunt@arm.com>
13823 Dirk Schubert <dirk.schubert@arm.com>
13824 Chris January <chris.january@arm.com>
13825
13826 * eval.c (evaluate_subexp_standard): Call Fortran argument
13827 wrapping logic.
13828 * f-lang.c (struct value): A value which can be passed into a
13829 Fortran function call.
13830 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13831 where appropriate.
13832 (struct type): Value ready for a Fortran function call.
13833 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13834 is needed.
13835 * f-lang.h (fortran_argument_convert): Declaration.
13836 (fortran_preserve_arg_pointer): Declaration.
13837 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13838
13839 2019-03-05 Tom Tromey <tromey@adacore.com>
13840
13841 * python/py-prettyprint.c (print_string_repr): Remove #if.
13842 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13843
13844 2019-03-05 Tom Tromey <tromey@adacore.com>
13845
13846 * target.c (the_dummy_target): Move later. Change type to
13847 "dummy_target".
13848 (initialize_targets): Don't initialize the_dummy_target.
13849
13850 2019-03-05 Tom Tromey <tromey@adacore.com>
13851
13852 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13853 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13854
13855 2019-03-05 Tom Tromey <tromey@adacore.com>
13856
13857 * windows-nat.c (windows_nat_target::attach)
13858 (windows_nat_target::detach): Don't call gdb_flush.
13859 * valprint.c (generic_val_print, val_print, val_print_string):
13860 Don't call gdb_flush.
13861 * utils.c (defaulted_query): Don't call gdb_flush.
13862 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13863 * target.c (target_announce_detach): Don't call gdb_flush.
13864 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13865 * remote.c (extended_remote_target::attach): Don't call
13866 gdb_flush.
13867 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13868 * printcmd.c (do_examine): Don't call gdb_flush.
13869 (info_display_command): Don't call gdb_flush.
13870 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13871 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13872 * memattr.c (info_mem_command): Don't call gdb_flush.
13873 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13874 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13875 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13876 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13877 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13878 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13879 (gnu_nat_target::detach): Don't call gdb_flush.
13880 * f-valprint.c (f_val_print): Don't call gdb_flush.
13881 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13882 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13883 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13884 gdb_flush.
13885 * c-valprint.c (c_val_print): Don't call gdb_flush.
13886 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13887
13888 2019-03-05 Tom Tromey <tromey@adacore.com>
13889
13890 * varobj.c (update_dynamic_varobj_children): Update.
13891 (install_default_visualizer): Use reset, not release.
13892 * value.c (set_internalvar): Update.
13893 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13894 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13895 ATTRIBUTE_UNUSED_RESULT.
13896
13897 2019-03-05 Tom Tromey <tromey@adacore.com>
13898
13899 * remote.c (class scoped_remote_fd) <release>: Add
13900 ATTRIBUTE_UNUSED_RESULT.
13901
13902 2019-03-05 Tom Tromey <tromey@adacore.com>
13903
13904 * macroexp.c (struct macro_buffer) <release>: Add
13905 ATTRIBUTE_UNUSED_RESULT.
13906
13907 2019-03-05 Tom Tromey <tromey@adacore.com>
13908
13909 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13910 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13911 ATTRIBUTE_UNUSED_RESULT.
13912
13913 2019-03-05 Tom Tromey <tromey@adacore.com>
13914
13915 * common/scoped_fd.h (class scoped_fd) <release>: Add
13916 ATTRIBUTE_UNUSED_RESULT.
13917
13918 2019-03-05 Tom Tromey <tromey@adacore.com>
13919
13920 * parser-defs.h (struct parser_state) <release>: Add
13921 ATTRIBUTE_UNUSED_RESULT.
13922
13923 2019-03-05 Tom Tromey <tromey@adacore.com>
13924
13925 * utils.h (class gdb_argv) <release>: Add
13926 ATTRIBUTE_UNUSED_RESULT.
13927 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13928
13929 2019-03-02 Eli Zaretskii <eliz@gnu.org>
13930
13931 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13932 for-loop range, to avoid compiler warnings.
13933
13934 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13935 avoid compiler warnings about unused variables.
13936
13937 * NEWS: Mention end of support for native debugging on MS-Windows
13938 before XP.
13939
13940 PR gdb/24292
13941 * common/netstuff.c:
13942 * gdbserver/gdbreplay.c
13943 * gdbserver/remote-utils.c:
13944 * ser-tcp.c:
13945 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13946 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13947 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13948 'getaddrinfo' and 'freeaddrinfo' were not available before
13949 Windows XP, and mingw.org's MinGW headers by default define
13950 _WIN32_WINNT to 0x500.
13951
13952 2019-03-01 Gary Benson <gbenson@redhat.com>
13953
13954 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13955
13956 2019-02-28 Brian Vandenberg <phantall@gmail.com>
13957 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13958
13959 PR gdb/8527
13960 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13961 set_sigint_trap, clear_sigint_trap.
13962
13963 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13964
13965 * target.c (target_detach): Clear the regcache and the
13966 frame cache.
13967
13968 2019-02-27 Pedro Alves <palves@redhat.com>
13969
13970 * utils.c (set_screen_size): When we cap the height/width sizes,
13971 tweak the corresponding command variable to show "unlimited":
13972
13973 2019-02-27 Saagar Jha <saagar@saagarjha.com>
13974 Pedro Alves <palves@redhat.com>
13975
13976 * utils.c (set_screen_size): Reduce "infinite" rows and columns
13977 before calling rl_set_screen_size.
13978
13979 2019-02-27 Tom Tromey <tromey@adacore.com>
13980
13981 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13982 define.
13983 * python/py-value.c: Remove Python 2.4 workaround.
13984 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13985 workaround.
13986 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13987 Python 2.4 workaround.
13988 * python/python-internal.h: Remove Python 2.4 comment.
13989 (Py_ssize_t): Don't define.
13990 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13991 (gdb_Py_DECREF): Remove Python 2.4 workaround.
13992 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13993 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13994 * python/python.c (do_start_initialization): Remove Python 2.4
13995 workaround.
13996 * python/py-prettyprint.c (class dummy_python_frame): Remove.
13997 (print_children): Remove Python 2.4 workaround.
13998 * python/py-inferior.c (buffer_procs): Remove Python 2.4
13999 workaround.
14000 (CHARBUFFERPROC_NAME): Remove.
14001 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14002 Python 2.4 workaround.
14003
14004 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14005
14006 * NEWS: Note minimum Python version.
14007
14008 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14009
14010 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14011 code from these functions. Remove corresponding ifdefs. Use
14012 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14013 Remove gotos and target of gotos.
14014 (infpy_search_memory): Likewise.
14015
14016 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14017
14018 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14019 (hppa_gdbarch_init): Don't register deleted functions with
14020 gdbarch.
14021
14022 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14023
14024 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14025 (h8300_unwind_sp): Delete.
14026 (h8300_dummy_id): Delete.
14027 (h8300_gdbarch_init): Don't register deleted functions with
14028 gdbarch.
14029
14030 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14031
14032 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14033 (ft32_unwind_pc): Delete.
14034 (ft32_unwind_sp): Delete.
14035 (ft32_gdbarch_init): Don't register deleted functions with
14036 gdbarch.
14037
14038 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14039
14040 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14041 (frv_unwind_pc): Delete.
14042 (frv_unwind_sp): Delete.
14043 (frv_gdbarch_init): Don't register deleted functions with
14044 gdbarch.
14045
14046 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14047
14048 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14049 (riscv_unwind_pc): Delete.
14050 (riscv_unwind_sp): Delete.
14051 (riscv_gdbarch_init): Don't register deleted functions with
14052 gdbarch.
14053
14054 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14055
14056 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14057 (csky_unwind_pc): Delete.
14058 (csky_unwind_sp): Delete.
14059 (csky_gdbarch_init): Don't register deleted functions with
14060 gdbarch.
14061
14062 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14063
14064 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14065 (cris_unwind_pc): Delete.
14066 (cris_unwind_sp): Delete.
14067 (cris_gdbarch_init): Don't register deleted functions with
14068 gdbarch.
14069
14070 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14071
14072 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14073 (bfin_unwind_pc): Delete.
14074 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14075
14076 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14077
14078 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14079 (arm_unwind_pc): Delete.
14080 (arm_unwind_sp): Delete.
14081 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14082
14083 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14084
14085 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14086 (arc_unwind_pc): Delete.
14087 (arc_unwind_sp): Delete.
14088 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14089
14090 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14091
14092 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14093 (alpha_unwind_pc): Delete.
14094 (alpha_gdbarch_init): Don't register deleted functions with
14095 gdbarch.
14096
14097 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14098
14099 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14100 (aarch64_unwind_pc): Delete.
14101 (aarch64_unwind_sp): Delete.
14102 (aarch64_gdbarch_init): Don't register deleted functions with
14103 gdbarch.
14104
14105 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14106
14107 * gdbtypes.c (type_align): Don't consider static members when
14108 computing structure alignment.
14109
14110 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14111
14112 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14113 return 0 for other types.
14114 * arch-utils.c (default_type_align): Always return 0.
14115 * gdbarch.h: Regenerate.
14116 * gdbarch.sh (type_align): Extend comment.
14117 * gdbtypes.c (type_align): Add additional comments, always call
14118 gdbarch_type_align before applying the default rules.
14119 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14120 generic code will then apply a suitable default.
14121 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14122 types, return 0 for other types.
14123
14124 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14125
14126 * NEWS: Create a new section for the next release branch.
14127 Rename the section of the current branch, now that it has
14128 been cut.
14129
14130 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14131
14132 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14133 * version.in: Bump version to 8.3.50.DATE-git.
14134
14135 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
14136
14137 * aix-thread.c (ptid_cmp): Remove unused variable.
14138 (get_signaled_thread): Likewise.
14139 (store_regs_user_thread): Likewise.
14140 (store_regs_kernel_thread): Likewise.
14141 (fetch_regs_kernel_thread): Remove shadowed variable.
14142
14143 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14144
14145 * features/riscv/32bit-cpu.xml: Add register numbers.
14146 * features/riscv/32bit-fpu.c: Regenerate.
14147 * features/riscv/32bit-fpu.xml: Add register numbers.
14148 * features/riscv/64bit-cpu.xml: Add register numbers.
14149 * features/riscv/64bit-fpu.c: Regenerate.
14150 * features/riscv/64bit-fpu.xml: Add register numbers.
14151
14152 2019-02-26 Kevin Buettner <kevinb@redhat.com>
14153
14154 * NEWS: Mention two argument form of gdb.Value constructor.
14155 * python/py-value.c (convert_buffer_and_type_to_value): New
14156 function.
14157 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14158 Add support for handling an optional second argument. Call
14159 convert_buffer_and_type_to_value as appropriate.
14160 * python/python-internal.h (Py_buffer_deleter): New struct.
14161 (Py_buffer_up): New typedef.
14162
14163 2019-02-25 John Baldwin <jhb@FreeBSD.org>
14164
14165 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14166 instead of releasing ownership.
14167
14168 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
14169
14170 * dwarf2read.c (open_and_init_dwp_file): Call
14171 elf_numsections instead of bfd_count_sections to initialize
14172 dwp_file->num_sections.
14173
14174 2019-02-25 Tom Tromey <tromey@adacore.com>
14175
14176 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14177
14178 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14179
14180 * gcore.in: Add '--readnever' option when invoking GDB.
14181
14182 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14183
14184 * MAINTAINERS: Update my email address.
14185
14186 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14187
14188 * build-id.c (build_id_to_debug_bfd_1): New function.
14189 (build_id_to_debug_bfd): Look for separate debug file in
14190 sysroot.
14191
14192 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14193
14194 * gdbarch.sh: Update the copyright year range that is placed into
14195 generated files.
14196
14197 2019-02-22 Keith Seitz <keiths@redhat.com>
14198
14199 PR symtab/23853
14200 * linespec.c (create_sals_line_offset): Search for the default
14201 symtab's filename instead of its fullname.
14202
14203 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14204
14205 * NEWS: Update style defaults.
14206
14207 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14208
14209 * main.c (captured_main_1): Disable styling in batch mode.
14210
14211 2019-02-20 Tom Tromey <tom@tromey.com>
14212
14213 * symtab.c (symtab_symbol_info): Fix typos.
14214
14215 2019-02-20 Tom Tromey <tromey@adacore.com>
14216
14217 * findcmd.c (_initialize_mem_search): Use upper case for
14218 metasyntactic variables.
14219
14220 2019-02-20 Alan Hayward <alan.hayward@arm.com>
14221
14222 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14223 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14224
14225 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14226
14227 * top.h (source_file_name): Change to std::string.
14228 * top.c (source_file_name): Likewise.
14229 (command_line_input): Adjust.
14230 * cli/cli-script.c (script_from_file): Adjust.
14231
14232 2019-02-19 Tom Tromey <tromey@adacore.com>
14233
14234 * ravenscar-thread.c
14235 (ravenscar_thread_target::update_thread_list): Don't call
14236 ada_build_task_list.
14237 * ada-lang.h (ada_build_task_list): Don't declare.
14238 * ada-tasks.c (struct ada_tasks_inferior_data)
14239 <task_list_valid_p>: Now bool.
14240 (read_known_tasks, ada_task_list_changed)
14241 (ada_tasks_invalidate_inferior_data): Update.
14242 (read_known_tasks_array): Return bool.
14243 (read_known_tasks_list): Likewise.
14244 (read_known_tasks): Return void.
14245 (ada_build_task_list): Now static.
14246
14247 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14248
14249 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14250 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14251
14252 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14253
14254 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14255 variant for ada_tasks_pspace_data_handle and
14256 ada_tasks_inferior_data_handle.
14257 (ada_tasks_pspace_data_cleanup): New function.
14258 (ada_tasks_inferior_data_cleanup): New function.
14259
14260 2019-02-17 Tom Tromey <tom@tromey.com>
14261
14262 * macrotab.h (macro_source_fullname): Return a std::string.
14263 * macrotab.c (macro_include, check_for_redefinition)
14264 (macro_undef, macro_lookup_definition, foreach_macro)
14265 (foreach_macro_in_scope): Update.
14266 (macro_source_fullname): Return a std::string.
14267 * macrocmd.c (show_pp_source_pos): Update.
14268
14269 2019-02-17 Tom Tromey <tom@tromey.com>
14270
14271 * macrocmd.c (show_pp_source_pos): Style the file names.
14272
14273 2019-02-17 Tom Tromey <tom@tromey.com>
14274
14275 PR tui/24197:
14276 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14277
14278 2019-02-17 Tom Tromey <tom@tromey.com>
14279
14280 * ada-lang.c (user_select_syms): Use filtered printing.
14281 * utils.c (wrap_style): New global.
14282 (desired_style): Remove.
14283 (emit_style_escape): Add stream parameter.
14284 (set_output_style, reset_terminal_style, prompt_for_continue):
14285 Update.
14286 (flush_wrap_buffer): Only flush gdb_stdout.
14287 (wrap_here): Set wrap_style.
14288 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14289 treat escape sequences as a character. Change when wrap buffer is
14290 flushed.
14291 (fputs_styled): Do not set the output style when the default is
14292 requested.
14293 * ui-style.h (struct ui_file_style) <is_default>: New method.
14294 * source.c (print_source_lines_base): Emit escape sequences in one
14295 piece.
14296
14297 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14298
14299 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14300 integers and enumeration types.
14301
14302 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14303
14304 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14305 instead of lookup_symbol_in_language
14306 (do_exact_match): New function.
14307 (ada_get_symbol_name_matcher): Return do_exact_match when
14308 doing a verbatim match.
14309
14310 2019-02-15 Tom Tromey <tromey@adacore.com>
14311
14312 * ravenscar-thread.c (ravenscar_thread_target::resume)
14313 (ravenscar_thread_target::wait): Special case wildcard requests.
14314
14315 2019-02-15 Tom Tromey <tromey@adacore.com>
14316
14317 * ravenscar-thread.c (base_ptid): Remove.
14318 (struct ravenscar_thread_target) <close>: New method.
14319 <m_base_ptid>: New member.
14320 <update_inferior_ptid, active_task, task_is_currently_active,
14321 runtime_initialized>: Declare methods.
14322 <ravenscar_thread_target>: Add constructor.
14323 (ravenscar_thread_target::task_is_currently_active)
14324 (ravenscar_thread_target::update_inferior_ptid)
14325 (ravenscar_runtime_initialized): Rename. Now methods.
14326 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14327 (ravenscar_thread_target::update_thread_list): Update.
14328 (ravenscar_thread_target::active_task): Now method.
14329 (ravenscar_thread_target::store_registers)
14330 (ravenscar_thread_target::prepare_to_store)
14331 (ravenscar_thread_target::prepare_to_store)
14332 (ravenscar_thread_target::mourn_inferior): Update.
14333 (ravenscar_inferior_created): Use "new" to create target.
14334 (ravenscar_thread_target::get_ada_task_ptid): Update.
14335 (_initialize_ravenscar): Don't initialize base_ptid.
14336 (ravenscar_ops): Remove global.
14337
14338 2019-02-15 Tom Tromey <tromey@adacore.com>
14339
14340 * target.h (push_target): Declare new overload.
14341 * target.c (push_target): New overload, taking an rvalue reference.
14342 * remote.c (remote_target::open_1): Use push_target overload.
14343 * corelow.c (core_target_open): Use push_target overload.
14344
14345 2019-02-15 Tom Tromey <tromey@adacore.com>
14346
14347 * ravenscar-thread.c (is_ravenscar_task)
14348 (ravenscar_task_is_currently_active): Return bool.
14349 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14350 (_initialize_ravenscar): Remove "(void)".
14351 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14352 Return bool.
14353
14354 2019-02-15 Tom Tromey <tromey@adacore.com>
14355
14356 * ravenscar-thread.c (ravenscar_runtime_initializer)
14357 (has_ravenscar_runtime, get_running_thread_id)
14358 (ravenscar_thread_target::resume): Fix indentation.
14359
14360 2019-02-15 Tom Tromey <tromey@adacore.com>
14361
14362 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14363 from ravenscar_arch_ops.
14364 (sparc_ravenscar_ops::fetch_registers)
14365 (sparc_ravenscar_ops::store_registers): Now methods.
14366 (sparc_ravenscar_prepare_to_store): Remove.
14367 (sparc_ravenscar_ops): Redefine.
14368 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14369 methods and destructor. Remove members.
14370 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14371 (ravenscar_thread_target::store_registers)
14372 (ravenscar_thread_target::prepare_to_store): Update.
14373 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14374 Remove.
14375 (struct ppc_ravenscar_powerpc_ops): Derive from
14376 ravenscar_arch_ops.
14377 (ppc_ravenscar_powerpc_ops::fetch_registers)
14378 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14379 (ppc_ravenscar_powerpc_ops): Redefine.
14380 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14381 (ppc_ravenscar_e500_ops::fetch_registers)
14382 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14383 (ppc_ravenscar_e500_ops): Redefine.
14384 * aarch64-ravenscar-thread.c
14385 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14386 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14387 (aarch64_ravenscar_fetch_registers)
14388 (aarch64_ravenscar_store_registers): Now methods.
14389 (aarch64_ravenscar_ops): Redefine.
14390
14391 2019-02-15 Tom Tromey <tromey@adacore.com>
14392
14393 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14394 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14395 (ravenscar_thread_target::stopped_by_watchpoint)
14396 (ravenscar_thread_target::stopped_data_address)
14397 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14398
14399 2019-02-15 Tom Tromey <tromey@adacore.com>
14400
14401 * ravenscar-thread.c: Fix some typos.
14402
14403 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14404 Tom Tromey <tromey@adacore.com>
14405
14406 * ada-lang.c (ada_exception_sal): Change addr_string to a
14407 std::string.
14408 (create_ada_exception_catchpoint): Update.
14409
14410 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14411 Tom Tromey <tromey@adacore.com>
14412
14413 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14414 (bp_location_ops): Remove.
14415 (base_breakpoint_allocate_location): Update.
14416 (free_bp_location): Update.
14417 * ada-lang.c (class ada_catchpoint_location)
14418 <ada_catchpoint_location>: Remove ops parameter.
14419 (ada_catchpoint_location_dtor): Remove.
14420 (ada_catchpoint_location_ops): Remove.
14421 (allocate_location_exception): Update.
14422 * breakpoint.h (struct bp_location_ops): Remove.
14423 (class bp_location) <bp_location>: Remove bp_location_ops
14424 parameter.
14425 <~bp_location>: Add destructor.
14426 <ops>: Remove.
14427
14428 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14429 Pedro Alves <palves@redhat.com>
14430
14431 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14432 'PATH_MAX'.
14433
14434 2019-02-14 David Michael <fedora.dm0@gmail.com>
14435 Samuel Thibault <samuel.thibault@gnu.org>
14436 Thomas Schwinge <thomas@codesourcery.com>
14437
14438 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14439 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14440
14441 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14442
14443 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14444 (check_empty): Use "const char *".
14445
14446 * gnu-nat.c (gnu_nat_target::detach): Instead of
14447 'detach_inferior (pid)' call
14448 'detach_inferior (find_inferior_pid (pid))'.
14449
14450 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14451 'nat/fork-inferior.o'.
14452 * gnu-nat.c: #include "nat/fork-inferior.h".
14453
14454 * gnu-nat.c (gnu_nat_target::detach): Instead of
14455 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14456 * gnu-nat.h: #include "inf-child.h".
14457 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14458 'i386_gnu_nat_target::fetch_registers'.
14459 (gnu_store_registers): Rename/move to
14460 'i386_gnu_nat_target::store_registers'.
14461
14462 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14463 * gnu-nat.h (mach_thread_info): New function.
14464 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14465
14466 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14467
14468 2019-02-14 Frederic Konrad <konrad@adacore.com>
14469
14470 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14471
14472 2019-02-14 Joel Brobecker <brobecker@adacore.com>
14473
14474 * windows-nat.c (windows_add_thread): Add new parameter
14475 "main_thread_p" with default value set to false. Update
14476 function documentation as well as all callers.
14477 (windows_delete_thread): Likewise.
14478 (fake_create_process): Update call to windows_add_thread.
14479 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14480 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14481 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14482 call to windows_delete_thread.
14483
14484 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14485
14486 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14487
14488 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14489
14490 * symfile.c (find_separate_debug_file): Use canonical path of
14491 sysroot with child_path instead of gdb_sysroot if it is valid.
14492
14493 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14494
14495 * symfile.c (find_separate_debug_file): Use child_path to
14496 determine if an object file is under a sysroot.
14497
14498 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14499
14500 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14501 unittests/child-path-selftests.c.
14502 * common/pathstuff.c (child_path): New function.
14503 * common/pathstuff.h (child_path): New prototype.
14504 * unittests/child-path-selftests.c: New file.
14505
14506 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14507
14508 * symfile.c (find_separate_debug_file): Look for separate debug
14509 files in debug directories under the sysroot.
14510
14511 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14512
14513 * symtab.h (struct minimal_symbol data_p): New const method.
14514 (struct minimal_symbol text_p): Likewise.
14515 * symtab.c (output_source_filename): Use file name style
14516 to print file name.
14517 (print_symbol_info): Likewise.
14518 (print_msymbol_info): Use address style to print addresses.
14519 Use function name style to print executable text symbols.
14520 (expand_symtab_containing_pc): Use data_p.
14521 (find_pc_sect_compunit_symtab): Likewise.
14522
14523 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14524
14525 * breakpoint.c (describe_other_breakpoints): Use address style
14526 to print addresses.
14527 (say_where): Likewise.
14528
14529 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14530
14531 * ada-typeprint.c (print_func_type): Print function name
14532 style to print function name.
14533 * c-typeprint.c (c_print_type_1): Likewise.
14534
14535 2019-02-11 Alan Hayward <alan.hayward@arm.com>
14536
14537 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14538 for execve.
14539
14540 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14541
14542 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14543 type_stack.
14544
14545 2019-02-10 Joel Brobecker <brobecker@adacore.com>
14546
14547 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14548 TYPE_CODE_REF types.
14549
14550 2019-02-08 Jim Wilson <jimw@sifive.com>
14551
14552 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14553 (riscv_linux_fregset): New.
14554 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14555
14556 2019-02-07 Tom Tromey <tom@tromey.com>
14557
14558 * thread.c (thread_cancel_execution_command): Update.
14559 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14560 methods.
14561 (struct thread_fsm_ops): Remove.
14562 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14563 (thread_fsm_should_stop, thread_fsm_return_value)
14564 (thread_fsm_set_finished, thread_fsm_finished_p)
14565 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14566 Don't declare.
14567 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14568 * infrun.c (clear_proceed_status_thread)
14569 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14570 (print_stop_event): Update.
14571 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14572 Add constructor.
14573 (step_command_fsm_ops): Remove.
14574 (new_step_command_fsm): Remove.
14575 (step_1): Update.
14576 (step_command_fsm::should_stop): Rename from
14577 step_command_fsm_should_stop.
14578 (step_command_fsm::clean_up): Rename from
14579 step_command_fsm_clean_up.
14580 (step_command_fsm::do_async_reply_reason): Rename from
14581 step_command_fsm_async_reply_reason.
14582 (struct until_next_fsm): Inherit from thread_fsm. Add
14583 constructor.
14584 (until_next_fsm_ops): Remove.
14585 (new_until_next_fsm): Remove.
14586 (until_next_fsm::should_stop): Rename from
14587 until_next_fsm_should_stop.
14588 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14589 (until_next_fsm::do_async_reply_reason): Rename from
14590 until_next_fsm_async_reply_reason.
14591 (struct finish_command_fsm): Inherit from thread_fsm. Add
14592 constructor. Change type of breakpoint.
14593 (finish_command_fsm_ops): Remove.
14594 (new_finish_command_fsm): Remove.
14595 (finish_command_fsm::should_stop): Rename from
14596 finish_command_fsm_should_stop.
14597 (finish_command_fsm::clean_up): Rename from
14598 finish_command_fsm_clean_up.
14599 (finish_command_fsm::return_value): Rename from
14600 finish_command_fsm_return_value.
14601 (finish_command_fsm::do_async_reply_reason): Rename from
14602 finish_command_fsm_async_reply_reason.
14603 (finish_command): Update.
14604 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14605 Add constructor.
14606 (call_thread_fsm_ops): Remove.
14607 (call_thread_fsm::call_thread_fsm): Rename from
14608 new_call_thread_fsm.
14609 (call_thread_fsm::should_stop): Rename from
14610 call_thread_fsm_should_stop.
14611 (call_thread_fsm::should_notify_stop): Rename from
14612 call_thread_fsm_should_notify_stop.
14613 (run_inferior_call, call_function_by_hand_dummy): Update.
14614 * cli/cli-interp.c (should_print_stop_to_console): Update.
14615 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14616 Add constructor. Change type of location_breakpoint,
14617 caller_breakpoint.
14618 (until_break_fsm_ops): Remove.
14619 (new_until_break_fsm): Remove.
14620 (until_break_fsm::should_stop): Rename from
14621 until_break_fsm_should_stop.
14622 (until_break_fsm::clean_up): Rename from
14623 until_break_fsm_clean_up.
14624 (until_break_fsm::do_async_reply_reason): Rename from
14625 until_break_fsm_async_reply_reason.
14626 (until_break_command): Update.
14627 * thread-fsm.c: Remove.
14628 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14629
14630 2019-02-07 Tom Tromey <tom@tromey.com>
14631
14632 * yy-remap.h: Add include guard.
14633 * xtensa-tdep.h: Add include guard.
14634 * xcoffread.h: Rename include guard.
14635 * varobj-iter.h: Add include guard.
14636 * tui/tui.h: Rename include guard.
14637 * tui/tui-winsource.h: Rename include guard.
14638 * tui/tui-wingeneral.h: Rename include guard.
14639 * tui/tui-windata.h: Rename include guard.
14640 * tui/tui-win.h: Rename include guard.
14641 * tui/tui-stack.h: Rename include guard.
14642 * tui/tui-source.h: Rename include guard.
14643 * tui/tui-regs.h: Rename include guard.
14644 * tui/tui-out.h: Rename include guard.
14645 * tui/tui-layout.h: Rename include guard.
14646 * tui/tui-io.h: Rename include guard.
14647 * tui/tui-hooks.h: Rename include guard.
14648 * tui/tui-file.h: Rename include guard.
14649 * tui/tui-disasm.h: Rename include guard.
14650 * tui/tui-data.h: Rename include guard.
14651 * tui/tui-command.h: Rename include guard.
14652 * tic6x-tdep.h: Add include guard.
14653 * target/waitstatus.h: Rename include guard.
14654 * target/wait.h: Rename include guard.
14655 * target/target.h: Rename include guard.
14656 * target/resume.h: Rename include guard.
14657 * target-float.h: Rename include guard.
14658 * stabsread.h: Add include guard.
14659 * rs6000-tdep.h: Add include guard.
14660 * riscv-fbsd-tdep.h: Add include guard.
14661 * regformats/regdef.h: Rename include guard.
14662 * record.h: Rename include guard.
14663 * python/python.h: Rename include guard.
14664 * python/python-internal.h: Rename include guard.
14665 * python/py-stopevent.h: Rename include guard.
14666 * python/py-ref.h: Rename include guard.
14667 * python/py-record.h: Rename include guard.
14668 * python/py-record-full.h: Rename include guard.
14669 * python/py-record-btrace.h: Rename include guard.
14670 * python/py-instruction.h: Rename include guard.
14671 * python/py-events.h: Rename include guard.
14672 * python/py-event.h: Rename include guard.
14673 * procfs.h: Add include guard.
14674 * proc-utils.h: Add include guard.
14675 * p-lang.h: Add include guard.
14676 * or1k-tdep.h: Rename include guard.
14677 * observable.h: Rename include guard.
14678 * nto-tdep.h: Rename include guard.
14679 * nat/x86-linux.h: Rename include guard.
14680 * nat/x86-linux-dregs.h: Rename include guard.
14681 * nat/x86-gcc-cpuid.h: Add include guard.
14682 * nat/x86-dregs.h: Rename include guard.
14683 * nat/x86-cpuid.h: Rename include guard.
14684 * nat/ppc-linux.h: Rename include guard.
14685 * nat/mips-linux-watch.h: Rename include guard.
14686 * nat/linux-waitpid.h: Rename include guard.
14687 * nat/linux-ptrace.h: Rename include guard.
14688 * nat/linux-procfs.h: Rename include guard.
14689 * nat/linux-osdata.h: Rename include guard.
14690 * nat/linux-nat.h: Rename include guard.
14691 * nat/linux-namespaces.h: Rename include guard.
14692 * nat/linux-btrace.h: Rename include guard.
14693 * nat/glibc_thread_db.h: Rename include guard.
14694 * nat/gdb_thread_db.h: Rename include guard.
14695 * nat/gdb_ptrace.h: Rename include guard.
14696 * nat/fork-inferior.h: Rename include guard.
14697 * nat/amd64-linux-siginfo.h: Rename include guard.
14698 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14699 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14700 * nat/aarch64-linux.h: Rename include guard.
14701 * nat/aarch64-linux-hw-point.h: Rename include guard.
14702 * mn10300-tdep.h: Add include guard.
14703 * mips-linux-tdep.h: Add include guard.
14704 * mi/mi-parse.h: Rename include guard.
14705 * mi/mi-out.h: Rename include guard.
14706 * mi/mi-main.h: Rename include guard.
14707 * mi/mi-interp.h: Rename include guard.
14708 * mi/mi-getopt.h: Rename include guard.
14709 * mi/mi-console.h: Rename include guard.
14710 * mi/mi-common.h: Rename include guard.
14711 * mi/mi-cmds.h: Rename include guard.
14712 * mi/mi-cmd-break.h: Rename include guard.
14713 * m2-lang.h: Add include guard.
14714 * location.h: Rename include guard.
14715 * linux-record.h: Rename include guard.
14716 * linux-nat.h: Add include guard.
14717 * linux-fork.h: Add include guard.
14718 * i386-darwin-tdep.h: Rename include guard.
14719 * hppa-linux-offsets.h: Add include guard.
14720 * guile/guile.h: Rename include guard.
14721 * guile/guile-internal.h: Rename include guard.
14722 * gnu-nat.h: Rename include guard.
14723 * gdb-stabs.h: Rename include guard.
14724 * frv-tdep.h: Add include guard.
14725 * f-lang.h: Add include guard.
14726 * event-loop.h: Add include guard.
14727 * darwin-nat.h: Rename include guard.
14728 * cp-abi.h: Rename include guard.
14729 * config/sparc/nm-sol2.h: Rename include guard.
14730 * config/nm-nto.h: Rename include guard.
14731 * config/nm-linux.h: Add include guard.
14732 * config/i386/nm-i386gnu.h: Rename include guard.
14733 * config/djgpp/nl_types.h: Rename include guard.
14734 * config/djgpp/langinfo.h: Rename include guard.
14735 * compile/gcc-cp-plugin.h: Add include guard.
14736 * compile/gcc-c-plugin.h: Add include guard.
14737 * compile/compile.h: Rename include guard.
14738 * compile/compile-object-run.h: Rename include guard.
14739 * compile/compile-object-load.h: Rename include guard.
14740 * compile/compile-internal.h: Rename include guard.
14741 * compile/compile-cplus.h: Rename include guard.
14742 * compile/compile-c.h: Rename include guard.
14743 * common/xml-utils.h: Rename include guard.
14744 * common/x86-xstate.h: Rename include guard.
14745 * common/version.h: Rename include guard.
14746 * common/vec.h: Rename include guard.
14747 * common/tdesc.h: Rename include guard.
14748 * common/selftest.h: Rename include guard.
14749 * common/scoped_restore.h: Rename include guard.
14750 * common/scoped_mmap.h: Rename include guard.
14751 * common/scoped_fd.h: Rename include guard.
14752 * common/safe-iterator.h: Rename include guard.
14753 * common/run-time-clock.h: Rename include guard.
14754 * common/refcounted-object.h: Rename include guard.
14755 * common/queue.h: Rename include guard.
14756 * common/ptid.h: Rename include guard.
14757 * common/print-utils.h: Rename include guard.
14758 * common/preprocessor.h: Rename include guard.
14759 * common/pathstuff.h: Rename include guard.
14760 * common/observable.h: Rename include guard.
14761 * common/netstuff.h: Rename include guard.
14762 * common/job-control.h: Rename include guard.
14763 * common/host-defs.h: Rename include guard.
14764 * common/gdb_wait.h: Rename include guard.
14765 * common/gdb_vecs.h: Rename include guard.
14766 * common/gdb_unlinker.h: Rename include guard.
14767 * common/gdb_unique_ptr.h: Rename include guard.
14768 * common/gdb_tilde_expand.h: Rename include guard.
14769 * common/gdb_sys_time.h: Rename include guard.
14770 * common/gdb_string_view.h: Rename include guard.
14771 * common/gdb_splay_tree.h: Rename include guard.
14772 * common/gdb_setjmp.h: Rename include guard.
14773 * common/gdb_ref_ptr.h: Rename include guard.
14774 * common/gdb_optional.h: Rename include guard.
14775 * common/gdb_locale.h: Rename include guard.
14776 * common/gdb_assert.h: Rename include guard.
14777 * common/filtered-iterator.h: Rename include guard.
14778 * common/filestuff.h: Rename include guard.
14779 * common/fileio.h: Rename include guard.
14780 * common/environ.h: Rename include guard.
14781 * common/common-utils.h: Rename include guard.
14782 * common/common-types.h: Rename include guard.
14783 * common/common-regcache.h: Rename include guard.
14784 * common/common-inferior.h: Rename include guard.
14785 * common/common-gdbthread.h: Rename include guard.
14786 * common/common-exceptions.h: Rename include guard.
14787 * common/common-defs.h: Rename include guard.
14788 * common/common-debug.h: Rename include guard.
14789 * common/cleanups.h: Rename include guard.
14790 * common/buffer.h: Rename include guard.
14791 * common/btrace-common.h: Rename include guard.
14792 * common/break-common.h: Rename include guard.
14793 * cli/cli-utils.h: Rename include guard.
14794 * cli/cli-style.h: Rename include guard.
14795 * cli/cli-setshow.h: Rename include guard.
14796 * cli/cli-script.h: Rename include guard.
14797 * cli/cli-interp.h: Rename include guard.
14798 * cli/cli-decode.h: Rename include guard.
14799 * cli/cli-cmds.h: Rename include guard.
14800 * charset-list.h: Add include guard.
14801 * buildsym-legacy.h: Rename include guard.
14802 * bfin-tdep.h: Add include guard.
14803 * ax.h: Rename include guard.
14804 * arm-linux-tdep.h: Add include guard.
14805 * arm-fbsd-tdep.h: Add include guard.
14806 * arch/xtensa.h: Rename include guard.
14807 * arch/tic6x.h: Add include guard.
14808 * arch/i386.h: Add include guard.
14809 * arch/arm.h: Rename include guard.
14810 * arch/arm-linux.h: Rename include guard.
14811 * arch/arm-get-next-pcs.h: Rename include guard.
14812 * arch/amd64.h: Add include guard.
14813 * arch/aarch64-insn.h: Rename include guard.
14814 * arch-utils.h: Rename include guard.
14815 * annotate.h: Add include guard.
14816 * amd64-darwin-tdep.h: Rename include guard.
14817 * aarch64-linux-tdep.h: Add include guard.
14818 * aarch64-fbsd-tdep.h: Add include guard.
14819 * aarch32-linux-nat.h: Add include guard.
14820
14821 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14822
14823 * macrotab.c (macro_define_internal): New function that
14824 factorizes macro_define_object_internal and macro_define_function
14825 code.
14826 (macro_define_object_internal): Use macro_define_internal.
14827 (macro_define_function): Likewise.
14828
14829 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14830
14831 * macrocmd.c (extract_identifier): Return
14832 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14833 callers.
14834
14835 2019-02-06 John Baldwin <jhb@FreeBSD.org>
14836
14837 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14838
14839 2019-02-05 Tom Tromey <tom@tromey.com>
14840
14841 * target.c (target_stack::unpush): Move assertion earlier.
14842
14843 2019-01-30 Tom Tromey <tom@tromey.com>
14844
14845 PR python/23615:
14846 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14847 (gdbpy_parse_and_eval): Likewise.
14848 * python/python-internal.h (gdbpy_allow_threads): New class.
14849
14850 2019-01-28 John Baldwin <jhb@FreeBSD.org>
14851
14852 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14853 (aarch64_fbsd_fpregmap): Move earlier.
14854 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14855 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14856 instead of individual calls to trad_frame_set_reg_addr.
14857 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14858 earlier.
14859 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14860 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14861 instead of individual calls to trad_frame_set_reg_addr.
14862
14863 2019-01-28 Alan Hayward <alan.hayward@arm.com>
14864
14865 * CONTRIBUTE: Replace contribution list with wiki link.
14866
14867 2019-01-25 Tom Tromey <tom@tromey.com>
14868
14869 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14870
14871 2019-01-25 Tom Tromey <tom@tromey.com>
14872
14873 * xtensa-linux-nat.c: Fix common/ includes.
14874 * xml-support.h: Fix common/ includes.
14875 * xml-support.c: Fix common/ includes.
14876 * x86-linux-nat.c: Fix common/ includes.
14877 * windows-nat.c: Fix common/ includes.
14878 * varobj.h: Fix common/ includes.
14879 * varobj.c: Fix common/ includes.
14880 * value.c: Fix common/ includes.
14881 * valops.c: Fix common/ includes.
14882 * utils.c: Fix common/ includes.
14883 * unittests/xml-utils-selftests.c: Fix common/ includes.
14884 * unittests/utils-selftests.c: Fix common/ includes.
14885 * unittests/unpack-selftests.c: Fix common/ includes.
14886 * unittests/tracepoint-selftests.c: Fix common/ includes.
14887 * unittests/style-selftests.c: Fix common/ includes.
14888 * unittests/string_view-selftests.c: Fix common/ includes.
14889 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14890 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14891 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14892 * unittests/rsp-low-selftests.c: Fix common/ includes.
14893 * unittests/parse-connection-spec-selftests.c: Fix common/
14894 includes.
14895 * unittests/optional-selftests.c: Fix common/ includes.
14896 * unittests/offset-type-selftests.c: Fix common/ includes.
14897 * unittests/observable-selftests.c: Fix common/ includes.
14898 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14899 * unittests/memrange-selftests.c: Fix common/ includes.
14900 * unittests/memory-map-selftests.c: Fix common/ includes.
14901 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14902 * unittests/function-view-selftests.c: Fix common/ includes.
14903 * unittests/environ-selftests.c: Fix common/ includes.
14904 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14905 * unittests/common-utils-selftests.c: Fix common/ includes.
14906 * unittests/cli-utils-selftests.c: Fix common/ includes.
14907 * unittests/array-view-selftests.c: Fix common/ includes.
14908 * ui-file.c: Fix common/ includes.
14909 * tui/tui-io.c: Fix common/ includes.
14910 * tracepoint.h: Fix common/ includes.
14911 * tracepoint.c: Fix common/ includes.
14912 * tracefile-tfile.c: Fix common/ includes.
14913 * top.h: Fix common/ includes.
14914 * top.c: Fix common/ includes.
14915 * thread.c: Fix common/ includes.
14916 * target/waitstatus.h: Fix common/ includes.
14917 * target/waitstatus.c: Fix common/ includes.
14918 * target.h: Fix common/ includes.
14919 * target.c: Fix common/ includes.
14920 * target-memory.c: Fix common/ includes.
14921 * target-descriptions.c: Fix common/ includes.
14922 * symtab.h: Fix common/ includes.
14923 * symfile.c: Fix common/ includes.
14924 * stap-probe.c: Fix common/ includes.
14925 * spu-linux-nat.c: Fix common/ includes.
14926 * sparc-nat.c: Fix common/ includes.
14927 * source.c: Fix common/ includes.
14928 * solib.c: Fix common/ includes.
14929 * solib-target.c: Fix common/ includes.
14930 * ser-unix.c: Fix common/ includes.
14931 * ser-tcp.c: Fix common/ includes.
14932 * ser-pipe.c: Fix common/ includes.
14933 * ser-base.c: Fix common/ includes.
14934 * selftest-arch.c: Fix common/ includes.
14935 * s12z-tdep.c: Fix common/ includes.
14936 * rust-exp.y: Fix common/ includes.
14937 * rs6000-aix-tdep.c: Fix common/ includes.
14938 * riscv-tdep.c: Fix common/ includes.
14939 * remote.c: Fix common/ includes.
14940 * remote-notif.h: Fix common/ includes.
14941 * remote-fileio.h: Fix common/ includes.
14942 * remote-fileio.c: Fix common/ includes.
14943 * regcache.h: Fix common/ includes.
14944 * regcache.c: Fix common/ includes.
14945 * record-btrace.c: Fix common/ includes.
14946 * python/python.c: Fix common/ includes.
14947 * python/py-type.c: Fix common/ includes.
14948 * python/py-inferior.c: Fix common/ includes.
14949 * progspace.h: Fix common/ includes.
14950 * producer.c: Fix common/ includes.
14951 * procfs.c: Fix common/ includes.
14952 * proc-api.c: Fix common/ includes.
14953 * printcmd.c: Fix common/ includes.
14954 * ppc-linux-nat.c: Fix common/ includes.
14955 * parser-defs.h: Fix common/ includes.
14956 * osdata.c: Fix common/ includes.
14957 * obsd-nat.c: Fix common/ includes.
14958 * nat/x86-linux.c: Fix common/ includes.
14959 * nat/x86-linux-dregs.c: Fix common/ includes.
14960 * nat/x86-dregs.h: Fix common/ includes.
14961 * nat/x86-dregs.c: Fix common/ includes.
14962 * nat/ppc-linux.c: Fix common/ includes.
14963 * nat/mips-linux-watch.h: Fix common/ includes.
14964 * nat/mips-linux-watch.c: Fix common/ includes.
14965 * nat/linux-waitpid.c: Fix common/ includes.
14966 * nat/linux-ptrace.h: Fix common/ includes.
14967 * nat/linux-ptrace.c: Fix common/ includes.
14968 * nat/linux-procfs.c: Fix common/ includes.
14969 * nat/linux-personality.c: Fix common/ includes.
14970 * nat/linux-osdata.c: Fix common/ includes.
14971 * nat/linux-namespaces.c: Fix common/ includes.
14972 * nat/linux-btrace.h: Fix common/ includes.
14973 * nat/linux-btrace.c: Fix common/ includes.
14974 * nat/fork-inferior.c: Fix common/ includes.
14975 * nat/amd64-linux-siginfo.c: Fix common/ includes.
14976 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14977 * nat/aarch64-linux.c: Fix common/ includes.
14978 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14979 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14980 * namespace.h: Fix common/ includes.
14981 * mips-linux-tdep.c: Fix common/ includes.
14982 * minsyms.c: Fix common/ includes.
14983 * mi/mi-parse.h: Fix common/ includes.
14984 * mi/mi-main.c: Fix common/ includes.
14985 * mi/mi-cmd-env.c: Fix common/ includes.
14986 * memrange.h: Fix common/ includes.
14987 * memattr.c: Fix common/ includes.
14988 * maint.h: Fix common/ includes.
14989 * maint.c: Fix common/ includes.
14990 * main.c: Fix common/ includes.
14991 * machoread.c: Fix common/ includes.
14992 * location.c: Fix common/ includes.
14993 * linux-thread-db.c: Fix common/ includes.
14994 * linux-nat.c: Fix common/ includes.
14995 * linux-fork.c: Fix common/ includes.
14996 * inline-frame.c: Fix common/ includes.
14997 * infrun.c: Fix common/ includes.
14998 * inflow.c: Fix common/ includes.
14999 * inferior.h: Fix common/ includes.
15000 * inferior.c: Fix common/ includes.
15001 * infcmd.c: Fix common/ includes.
15002 * inf-ptrace.c: Fix common/ includes.
15003 * inf-child.c: Fix common/ includes.
15004 * ia64-linux-nat.c: Fix common/ includes.
15005 * i387-tdep.c: Fix common/ includes.
15006 * i386-tdep.c: Fix common/ includes.
15007 * i386-linux-tdep.c: Fix common/ includes.
15008 * i386-linux-nat.c: Fix common/ includes.
15009 * i386-go32-tdep.c: Fix common/ includes.
15010 * i386-fbsd-tdep.c: Fix common/ includes.
15011 * i386-fbsd-nat.c: Fix common/ includes.
15012 * guile/scm-type.c: Fix common/ includes.
15013 * guile/guile.c: Fix common/ includes.
15014 * go32-nat.c: Fix common/ includes.
15015 * gnu-nat.c: Fix common/ includes.
15016 * gdbthread.h: Fix common/ includes.
15017 * gdbarch-selftests.c: Fix common/ includes.
15018 * gdb_usleep.c: Fix common/ includes.
15019 * gdb_select.h: Fix common/ includes.
15020 * gdb_bfd.c: Fix common/ includes.
15021 * gcore.c: Fix common/ includes.
15022 * fork-child.c: Fix common/ includes.
15023 * findvar.c: Fix common/ includes.
15024 * fbsd-nat.c: Fix common/ includes.
15025 * event-top.c: Fix common/ includes.
15026 * event-loop.c: Fix common/ includes.
15027 * dwarf2read.c: Fix common/ includes.
15028 * dwarf2loc.c: Fix common/ includes.
15029 * dwarf2-frame.c: Fix common/ includes.
15030 * dwarf-index-cache.c: Fix common/ includes.
15031 * dtrace-probe.c: Fix common/ includes.
15032 * disasm-selftests.c: Fix common/ includes.
15033 * defs.h: Fix common/ includes.
15034 * csky-tdep.c: Fix common/ includes.
15035 * cp-valprint.c: Fix common/ includes.
15036 * cp-support.h: Fix common/ includes.
15037 * cp-support.c: Fix common/ includes.
15038 * corelow.c: Fix common/ includes.
15039 * completer.h: Fix common/ includes.
15040 * completer.c: Fix common/ includes.
15041 * compile/compile.c: Fix common/ includes.
15042 * compile/compile-loc2c.c: Fix common/ includes.
15043 * compile/compile-cplus-types.c: Fix common/ includes.
15044 * compile/compile-cplus-symbols.c: Fix common/ includes.
15045 * command.h: Fix common/ includes.
15046 * cli/cli-dump.c: Fix common/ includes.
15047 * cli/cli-cmds.c: Fix common/ includes.
15048 * charset.c: Fix common/ includes.
15049 * build-id.c: Fix common/ includes.
15050 * btrace.h: Fix common/ includes.
15051 * btrace.c: Fix common/ includes.
15052 * breakpoint.h: Fix common/ includes.
15053 * breakpoint.c: Fix common/ includes.
15054 * ax.h:
15055 (enum agent_op): Fix common/ includes.
15056 * ax-general.c (struct aop_map): Fix common/ includes.
15057 * ax-gdb.c: Fix common/ includes.
15058 * auxv.c: Fix common/ includes.
15059 * auto-load.c: Fix common/ includes.
15060 * arm-tdep.c: Fix common/ includes.
15061 * arch/riscv.c: Fix common/ includes.
15062 * arch/ppc-linux-common.c: Fix common/ includes.
15063 * arch/i386.c: Fix common/ includes.
15064 * arch/arm.c: Fix common/ includes.
15065 * arch/arm-linux.c: Fix common/ includes.
15066 * arch/arm-get-next-pcs.c: Fix common/ includes.
15067 * arch/amd64.c: Fix common/ includes.
15068 * arch/aarch64.c: Fix common/ includes.
15069 * arch/aarch64-insn.c: Fix common/ includes.
15070 * arch-utils.c: Fix common/ includes.
15071 * amd64-windows-tdep.c: Fix common/ includes.
15072 * amd64-tdep.c: Fix common/ includes.
15073 * amd64-sol2-tdep.c: Fix common/ includes.
15074 * amd64-obsd-tdep.c: Fix common/ includes.
15075 * amd64-nbsd-tdep.c: Fix common/ includes.
15076 * amd64-linux-tdep.c: Fix common/ includes.
15077 * amd64-linux-nat.c: Fix common/ includes.
15078 * amd64-fbsd-tdep.c: Fix common/ includes.
15079 * amd64-fbsd-nat.c: Fix common/ includes.
15080 * amd64-dicos-tdep.c: Fix common/ includes.
15081 * amd64-darwin-tdep.c: Fix common/ includes.
15082 * agent.c: Fix common/ includes.
15083 * ada-lang.h: Fix common/ includes.
15084 * ada-lang.c: Fix common/ includes.
15085 * aarch64-tdep.c: Fix common/ includes.
15086
15087 2019-01-25 Tom Tromey <tom@tromey.com>
15088
15089 * common/create-version.sh: Use common/version.h.
15090
15091 2019-01-24 Pedro Alves <palves@redhat.com>
15092
15093 * infrun.c (signal_stop, signal_print, signal_program)
15094 (signal_catch, signal_pass): Now arrays instead of pointers.
15095 (update_signals_program_target, do_target_resume)
15096 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15097 * linux-nat.c (linux_nat_target::pass_signals)
15098 (linux_nat_target::create_inferior, linux_nat_target::attach):
15099 Adjust.
15100 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15101 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15102 * procfs.c (procfs_target::pass_signals): Adjust.
15103 * record-full.c (record_full_target::resume): Adjust.
15104 * remote.c (remote_target::pass_signals)
15105 (remote_target::program_signals): Adjust.
15106 * target-debug.h (target_debug_print_signals): Now takes a
15107 gdb::array_view as parameter. Adjust.
15108 * target.h (target_ops) <pass_signals, program_signals>: Replace
15109 pointer and length parameters with gdb::array_view.
15110 (target_pass_signals, target_program_signals): Likewise.
15111 * target-delegates.c: Regenerate.
15112
15113 2019-01-24 Pedro Alves <palves@redhat.com>
15114
15115 * common/forward-scope-exit.h
15116 (forward_scope_exit::forward_scope_exit): Pass arguments to
15117 m_bind_function directly, instead of creating a std::bind and
15118 copying that.
15119
15120 2019-01-24 Alan Hayward <alan.hayward@arm.com>
15121
15122 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15123 for static members.
15124 (pass_in_v_vfp_candidate): Likewise.
15125
15126 2019-01-23 Tom Tromey <tom@tromey.com>
15127 Pedro Alves <palves@redhat.com>
15128
15129 * regcache.c (class regcache_invalidator): Remove.
15130 (regcache::raw_write): Use make_scope_exit.
15131
15132 2019-01-23 Tom Tromey <tom@tromey.com>
15133
15134 * ui-out.h (class ui_out_emit_type): Update comment.
15135
15136 2019-01-23 Tom Tromey <tom@tromey.com>
15137
15138 * infrun.c (fetch_inferior_event): Update comment.
15139
15140 2019-01-23 Tom Tromey <tom@tromey.com>
15141 Pedro Alves <palves@redhat.com>
15142
15143 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15144 parameter.
15145 (fetch_inferior_event): Use SCOPE_EXIT.
15146
15147
15148 2019-01-23 Tom Tromey <tom@tromey.com>
15149 Pedro Alves <palves@redhat.com>
15150
15151 * infrun.c (disable_thread_events): Delete.
15152 (stop_all_threads): Use SCOPE_EXIT.
15153
15154 2019-01-23 Tom Tromey <tom@tromey.com>
15155 Pedro Alves <palves@redhat.com>
15156
15157 * symfile.c: Include forward-scope-exit.h.
15158 (clear_symtab_users_cleanup): Replace forward declaration with
15159 a FORWARD_SCOPE_EXIT.
15160 (syms_from_objfile_1): Use the forward_scope_exit and
15161 gdb::optional instead of cleanup_function.
15162 (reread_symbols): Use the forward_scope_exit instead of
15163 cleanup_function.
15164 (clear_symtab_users_cleanup): Remove function.
15165
15166 2019-01-23 Tom Tromey <tom@tromey.com>
15167 Pedro Alves <palves@redhat.com>
15168
15169 * linux-nat.c: Include scope-exit.h.
15170 (cleanup_target_stop): Remove.
15171 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15172 SCOPE_EXIT.
15173
15174 2019-01-23 Tom Tromey <tom@tromey.com>
15175 Pedro Alves <palves@redhat.com>
15176
15177 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15178 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15179
15180 2019-01-23 Tom Tromey <tom@tromey.com>
15181 Andrew Burgess <andrew.burgess@embecosm.com>
15182 Pedro Alves <palves@redhat.com>
15183
15184 * infrun.c (fetch_inferior_event): Use scope_exit.
15185 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15186 * top.c (execute_command): Use scope_exit.
15187 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15188 * utils.c (do_bpstat_clear_actions_cleanup)
15189 (make_bpstat_clear_actions_cleanup): Remove.
15190
15191 2019-01-23 Tom Tromey <tom@tromey.com>
15192 Pedro Alves <palves@redhat.com>
15193
15194 * infrun.c: Include "common/scope-exit.h"
15195 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15196 (wait_for_inferior): Use SCOPE_EXIT.
15197 (fetch_inferior_event): Use scope_exit.
15198
15199 2019-01-23 Tom Tromey <tom@tromey.com>
15200 Pedro Alves <palves@redhat.com>
15201
15202 * breakpoint.c (create_breakpoint): Remove cleanup.
15203
15204 2019-01-23 Tom Tromey <tom@tromey.com>
15205 Andrew Burgess <andrew.burgess@embecosm.com>
15206 Pedro Alves <palves@redhat.com>
15207
15208 2019-01-23 Pedro Alves <palves@redhat.com>
15209
15210 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15211
15212 2019-01-23 Pedro Alves <palves@redhat.com>
15213 Andrew Burgess <andrew.burgess@embecosm.com>
15214
15215 * gdbthread.h: Include "common/forward-scope-exit.h".
15216 (scoped_finish_thread_state): Redefine custom class in terms of
15217 forward_scope_exit.
15218
15219 2019-01-23 Pedro Alves <palves@redhat.com>
15220 Andrew Burgess <andrew.burgess@embecosm.com>
15221
15222 * common/forward-scope-exit.h: New file.
15223
15224 2019-01-23 Pedro Alves <palves@redhat.com>
15225 Andrew Burgess <andrew.burgess@embecosm.com>
15226 Tom Tromey <tom@tromey.com>
15227
15228 * common/scope-exit.h: New file.
15229
15230 2019-01-23 Pedro Alves <palves@redhat.com>
15231
15232 * common/preprocessor.h (ESC): Rename to ...
15233 (ESC_PARENS): ... this.
15234 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15235 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15236
15237 2019-01-23 Tom Tromey <tom@tromey.com>
15238
15239 * language.h (class scoped_switch_to_sym_language_if_auto):
15240 Initialize m_lang in both cases.
15241
15242 2019-01-23 Alan Hayward <alan.hayward@arm.com>
15243
15244 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15245 with XCNEW.
15246
15247 2019-01-22 Tom Tromey <tom@tromey.com>
15248
15249 * corelow.c: Do not include sys/file.h.
15250
15251 2019-01-22 Tom Tromey <tom@tromey.com>
15252
15253 * tui/tui-wingeneral.h: Include gdb_curses.h.
15254
15255 2019-01-22 Tom Tromey <tom@tromey.com>
15256
15257 * source-cache.h (class source_cache) <get_source_lines,
15258 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15259
15260 2019-01-22 Tom Tromey <tom@tromey.com>
15261
15262 * remote-fileio.h (struct remote_target): Declare.
15263
15264 2019-01-22 Tom Tromey <tom@tromey.com>
15265
15266 * python/py-arch.c: Do not include py-ref.h.
15267 * python/py-bpevent.c: Do not include py-ref.h.
15268 * python/py-cmd.c: Do not include py-ref.h.
15269 * python/py-continueevent.c: Do not include py-ref.h.
15270 * python/py-event.h: Do not include py-ref.h.
15271 * python/py-evtregistry.c: Do not include py-ref.h.
15272 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15273 * python/py-frame.c: Do not include py-ref.h.
15274 * python/py-framefilter.c: Do not include py-ref.h.
15275 * python/py-function.c: Do not include py-ref.h.
15276 * python/py-infevents.c: Do not include py-ref.h.
15277 * python/py-linetable.c: Do not include py-ref.h.
15278 * python/py-objfile.c: Do not include py-ref.h.
15279 * python/py-param.c: Do not include py-ref.h.
15280 * python/py-prettyprint.c: Do not include py-ref.h.
15281 * python/py-progspace.c: Do not include py-ref.h.
15282 * python/py-symbol.c: Do not include py-ref.h.
15283 * python/py-symtab.c: Do not include py-ref.h.
15284 * python/py-type.c: Do not include py-ref.h.
15285 * python/py-unwind.c: Do not include py-ref.h.
15286 * python/py-utils.c: Do not include py-ref.h.
15287 * python/py-value.c: Do not include py-ref.h.
15288 * python/py-varobj.c: Do not include py-ref.h.
15289 * python/py-xmethods.c: Do not include py-ref.h.
15290 * python/python.c: Do not include py-ref.h.
15291 * varobj.c: Do not include py-ref.h.
15292
15293 2019-01-22 Tom Tromey <tom@tromey.com>
15294
15295 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15296 keyword for bcache.
15297
15298 2019-01-22 Tom Tromey <tom@tromey.com>
15299
15300 * compile/compile-cplus-types.c: Remove a comment by #include.
15301
15302 2019-01-22 Tom Tromey <tom@tromey.com>
15303
15304 * compile/gcc-c-plugin.h: Include compile-internal.h.
15305
15306 2019-01-22 Tom Tromey <tom@tromey.com>
15307
15308 * stabsread.c (EXTERN): Do not define.
15309 (symnum, next_symbol_text_func, processing_gcc_compilation)
15310 (within_function, global_sym_chain, global_stabs)
15311 (previous_stab_code, this_object_header_files)
15312 (n_this_object_header_files)
15313 (n_allocated_this_object_header_files): Define.
15314 * stabsread.h (EXTERN): Never define. Use "extern".
15315
15316 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15317
15318 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15319 history_value.
15320
15321 2019-01-21 Tom Tromey <tom@tromey.com>
15322
15323 * ui-out.c: Fix includes.
15324 * tui/tui-source.c: Fix includes.
15325 * target.c: Fix includes.
15326 * remote.c: Fix includes.
15327 * regcache.c: Fix includes.
15328 * python/py-block.c: Fix includes.
15329 * printcmd.c: Fix includes.
15330 * or1k-tdep.c: Fix includes.
15331 * mi/mi-main.c: Fix includes.
15332 * m32r-tdep.c: Fix includes.
15333 * csky-tdep.c: Fix includes.
15334 * compile/compile-cplus-types.c: Fix includes.
15335 * cli/cli-interp.c: Fix includes.
15336
15337 2019-01-21 Alan Hayward <alan.hayward@arm.com>
15338
15339 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15340 for padding.
15341
15342 2019-01-16 Tom Tromey <tom@tromey.com>
15343
15344 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15345 earlier.
15346 (struct objfile) <msymbols_range>: Move from top level.
15347 <msymbols>: New method.
15348 (class objfile_msymbols): Remove.
15349 * symtab.c (default_collect_symbol_completion_matches_break_on):
15350 Update.
15351 * symmisc.c (dump_msymbols): Update.
15352 * stabsread.c (scan_file_globals): Update.
15353 * objc-lang.c (info_selectors_command, info_classes_command)
15354 (find_methods): Update.
15355 * minsyms.c (find_solib_trampoline_target): Update.
15356 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15357 * coffread.c (coff_symfile_read): Update.
15358 * ada-lang.c (ada_lookup_simple_minsym)
15359 (ada_collect_symbol_completion_matches): Update.
15360
15361 2019-01-16 Tom Tromey <tom@tromey.com>
15362
15363 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15364 type. Remove no-argument constructor.
15365 <iterator::operator++>: Simplify.
15366 <begin>: Update.
15367 <end>: Use minimal_symbol_count.
15368
15369 2019-01-16 Tom Tromey <tom@tromey.com>
15370
15371 * objfiles.h (struct objfile) <psymtabs>: New method.
15372 (class objfile_psymtabs): Remove.
15373 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15374 typedef.
15375 <range>: New method.
15376 (require_partial_symbols): Change return type.
15377 * psymtab.c (require_partial_symbols)
15378 (psym_expand_symtabs_matching): Update.
15379 * mdebugread.c (parse_partial_symbols): Update.
15380 * dbxread.c (dbx_end_psymtab): Update.
15381
15382 2019-01-15 Tom Tromey <tom@tromey.com>
15383
15384 * symtab.c (lookup_objfile_from_block)
15385 (lookup_symbol_in_objfile_symtabs)
15386 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15387 (find_line_symtab, info_sources_command)
15388 (default_collect_symbol_completion_matches_break_on)
15389 (make_source_files_completion_list): Update.
15390 * symmisc.c (print_objfile_statistics, dump_objfile)
15391 (maintenance_print_symbols, maintenance_info_symtabs)
15392 (maintenance_check_symtabs, maintenance_info_line_tables):
15393 Update.
15394 * source.c (select_source_symtab)
15395 (forget_cached_source_info_for_objfile): Update.
15396 * objfiles.h (class objfile_compunits): Remove.
15397 (struct objfile) <compunits_range>: New typedef.
15398 (compunits): New method.
15399 * objfiles.c (objfile_relocate1): Update.
15400 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15401 * maint.c (count_symtabs_and_blocks): Update.
15402 * linespec.c (iterate_over_all_matching_symtabs): Update.
15403 * cp-support.c (add_symbol_overload_list_qualified): Update.
15404 * coffread.c (coff_symtab_read): Update.
15405 * ada-lang.c (add_nonlocal_symbols)
15406 (ada_collect_symbol_completion_matches)
15407 (ada_add_global_exceptions): Update.
15408
15409 2019-01-15 Tom Tromey <tom@tromey.com>
15410
15411 * progspace.h (program_space) <objfiles_safe_range>: New
15412 typedef.
15413 <objfiles_safe>: New method.
15414 * objfiles.h (class all_objfiles_safe): Remove.
15415 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15416 * jit.c (jit_inferior_exit_hook): Update.
15417
15418 2019-01-17 Tom Tromey <tom@tromey.com>
15419
15420 * progspace.h (program_space) <objfiles_range>: New typedef.
15421 <objfiles>: New method.
15422 <objfiles_head>: Rename from objfiles.
15423 (object_files): Update.
15424 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15425 * guile/scm-pretty-print.c
15426 (ppscm_find_pretty_printer_from_objfiles): Update.
15427 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15428 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15429 Update.
15430 * python/py-progspace.c (pspy_get_objfiles): Update.
15431 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15432 Update.
15433 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15434 (objfpy_lookup_objfile_by_build_id): Update.
15435 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15436 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15437 Update.
15438 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15439 (expand_symtab_containing_pc, lookup_objfile_from_block)
15440 (lookup_static_symbol, basic_lookup_transparent_type)
15441 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15442 (find_line_symtab, info_sources_command)
15443 (default_collect_symbol_completion_matches_break_on)
15444 (make_source_files_completion_list, find_main_name): Update.
15445 * symmisc.c (print_symbol_bcache_statistics)
15446 (print_objfile_statistics, maintenance_print_symbols)
15447 (maintenance_print_msymbols, maintenance_print_objfiles)
15448 (maintenance_info_symtabs, maintenance_check_symtabs)
15449 (maintenance_expand_symtabs, maintenance_info_line_tables):
15450 Update.
15451 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15452 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15453 (map_overlay_command, unmap_overlay_command)
15454 (simple_overlay_update, expand_symtabs_matching)
15455 (map_symbol_filenames): Update.
15456 * symfile-debug.c (set_debug_symfile): Update.
15457 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15458 Update.
15459 * source.c (select_source_symtab, forget_cached_source_info):
15460 Update.
15461 * solib.c (solib_read_symbols): Update.
15462 * solib-spu.c (append_ocl_sos): Update.
15463 * psymtab.c (maintenance_print_psymbols)
15464 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15465 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15466 * printcmd.c (info_symbol_command): Update.
15467 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15468 Update.
15469 * objfiles.h (class all_objfiles): Remove.
15470 * objfiles.c (have_partial_symbols, have_full_symbols)
15471 (have_minimal_symbols, qsort_cmp, update_section_map)
15472 (shared_objfile_contains_address_p)
15473 (default_iterate_over_objfiles_in_search_order): Update.
15474 * objc-lang.c (info_selectors_command, info_classes_command)
15475 (find_methods): Update.
15476 * minsyms.c (find_solib_trampoline_target): Update.
15477 * maint.c (maintenance_info_sections)
15478 (maintenance_translate_address, count_symtabs_and_blocks):
15479 Update.
15480 * main.c (captured_main_1): Update.
15481 * linux-thread-db.c (try_thread_db_load_from_pdir)
15482 (has_libpthread): Update.
15483 * linespec.c (iterate_over_all_matching_symtabs)
15484 (search_minsyms_for_name): Update.
15485 * jit.c (jit_find_objf_with_entry_addr): Update.
15486 * hppa-tdep.c (find_unwind_entry)
15487 (hppa_lookup_stub_minimal_symbol): Update.
15488 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15489 Update.
15490 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15491 (elf_gnu_ifunc_resolve_by_got): Update.
15492 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15493 * dwarf-index-write.c (save_gdb_index_command): Update.
15494 * cp-support.c (add_symbol_overload_list_qualified): Update.
15495 * breakpoint.c (create_overlay_event_breakpoint)
15496 (create_longjmp_master_breakpoint)
15497 (create_std_terminate_master_breakpoint)
15498 (create_exception_master_breakpoint): Update.
15499 * blockframe.c (find_pc_partial_function): Update.
15500 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15501 (ada_collect_symbol_completion_matches)
15502 (ada_add_global_exceptions): Update.
15503
15504 2019-01-17 Tom Tromey <tom@tromey.com>
15505
15506 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15507 declare VEC.
15508 (solib_target_parse_libraries): Change return type.
15509 (library_list_start_segment, library_list_start_section)
15510 (library_list_end_library, library_list_start_library); Update.
15511 (solib_target_free_library_list): Remove.
15512 (solib_target_parse_libraries): Remove cleanup. Change return
15513 type.
15514 (solib_target_current_sos): Update.
15515
15516 2019-01-17 Tom Tromey <tromey@bapiya>
15517
15518 * valprint.c: Replace "the the" with "the".
15519 * symtab.c: Replace "the the" with "the".
15520 * solib.c: Replace "the the" with "the".
15521 * solib-dsbt.c: Replace "the the" with "the".
15522 * linespec.c: Replace "the the" with "the".
15523 * dwarf2loc.h: Replace "the the" with "the".
15524 * amd64-windows-tdep.c: Replace "the the" with "the".
15525 * aarch64-tdep.c: Replace "the the" with "the".
15526
15527 2019-01-16 Keith Seitz <keiths@redhat.com>
15528
15529 PR gdb/23773
15530 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15531 <builder>: Rename to ..
15532 <m_builder>: ... this and make private.
15533 (dwarf2_cu::get_builder): New method. Change all users of
15534 `builder' to use this method.
15535 (dwarf2_start_symtab): Move to ...
15536 (dwarf2_cu::start_symtab): ... here. Update all callers
15537 (setup_type_unit_groups): Move to ...
15538 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15539 callers.
15540 (dwarf2_cu::reset_builder): New method.
15541 (process_full_compunit, process_full_type_unit): Use
15542 dwarf2_cu::reset_builder.
15543 (follow_die_offset): Record the ancestor CU if it is different
15544 from the followed DIE's CU.
15545 (follow_die_sig_1): Likewise.
15546
15547 2019-01-15 Tom Tromey <tom@tromey.com>
15548
15549 * remote.c (class remote_state) <buf>: Now a char_vector.
15550 <buf_size>: Remove.
15551 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15552 parameter.
15553 (remote_target::getpkt_or_notif_sane_1)
15554 (remote_target::getpkt_sane)
15555 (remote_target::getpkt_or_notif_sane): Likewise.
15556 (class remote_target) <putpkt>: New overload.
15557 (remote_target::read_frame): Change type of "buf_p". Remove
15558 sizeof_p parameter.
15559 (packet_ok): New overload.
15560 (packet_check_result): New overload.
15561 Update all uses.
15562
15563 2019-01-14 Tom Tromey <tom@tromey.com>
15564
15565 * remote-notif.c (handle_notification, remote_notif_ack)
15566 (remote_notif_parse): Make "buf" const.
15567 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15568 const.
15569 (remote_notif_parse, remote_notif_ack, handle_notification):
15570 Likewise.
15571 * remote.c (remote_notif_stop_parse): Make "buf" const.
15572 (remote_target::remote_parse_stop_reply): Make "buf" const.
15573 (remote_notif_stop_ack): Make "buf" const.
15574
15575 2019-01-14 Tom Tromey <tom@tromey.com>
15576
15577 * remote.c (remote_console_output): Make parameter const.
15578
15579 2019-01-14 Tom Tromey <tom@tromey.com>
15580
15581 * target-debug.h (target_debug_print_signals): Constify.
15582 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15583 * procfs.c (procfs_target::pass_signals): Update.
15584 * linux-nat.c (linux_nat_target::pass_signals): Update.
15585 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15586 * target-delegates.c: Rebuild.
15587 * remote.c (remote_target::program_signals): Update.
15588 (remote_target::pass_signals): Update.
15589 * target.c (target_pass_signals): Constify argument.
15590 (target_program_signals): Likewise.
15591 * target.h (struct target_ops) <pass_signals, program_signals>:
15592 Constify argument.
15593 (target_pass_signals, target_program_signals): Constify argument.
15594
15595 2019-01-14 Tom Tromey <tom@tromey.com>
15596
15597 PR tui/28819:
15598 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15599
15600 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15601
15602 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15603 field.
15604 * rs6000-tdep.c: Include reggroups.h.
15605 (IS_V_ALIAS_PSEUDOREG): Define.
15606 (rs6000_register_name): Return names for the "vX" aliases.
15607 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15608 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15609 aliases. Call default_register_reggroup_p for all other
15610 pseudo-registers.
15611 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15612 New functions.
15613 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15614 Handle "vX" aliases.
15615 (v_alias_pseudo_register_collect): New function.
15616 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15617 (rs6000_gdbarch_init): Initialize "vX" aliases as
15618 pseudo-registers. Restore registration of
15619 rs6000_pseudo_register_reggroup_p with
15620 set_tdesc_pseudo_register_reggroup_p.
15621
15622 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15623
15624 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15625 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15626 set_gdbarch_num_pseudo_regs.
15627
15628 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15629
15630 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15631 Remove arg prefixname, add do_set and do_show.
15632 Add member functions set_list and show_list.
15633 * cli/cli-style.c (class cli_style_option): Update accordingly.
15634 (style_set_list): Move to file scope.
15635 (style_show_list): Likewise.
15636 (set_style): Call help_list.
15637 (show_style): Call cmd_show_list.
15638 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15639 Update to use the new macro.
15640
15641 2019-10-12 Joel Brobecker <brobecker@adacore.com>
15642
15643 * ada-lang.c (_initialize_ada_language): Expand the help text
15644 for the "catch exception" command.
15645
15646 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15647
15648 * symtab.c (matching_obj_sections): Initialize obj,
15649 declare it closer to its usage.
15650
15651 2019-01-10 Tom Tromey <tom@tromey.com>
15652
15653 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15654 (basic_inf_threads_range): Remove.
15655 (inf_threads_range, inf_non_exited_threads_range)
15656 (safe_inf_threads_range): Use next_adapter.
15657
15658 2019-01-10 Keith Seitz <keiths@redhat.com>
15659
15660 PR gdb/23712
15661 PR symtab/23010
15662 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15663 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15664
15665 2019-01-10 Keith Seitz <keiths@redhat.com>
15666
15667 PR gdb/23712
15668 PR symtab/23010
15669 * dictionary.c (pending_to_vector): Remove.
15670 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15671 Remove _1 suffix, replacing functions of the same name. Update
15672 all callers.
15673 (dict_create_hashed, dict_create_hashed_expandable)
15674 (dict_create_linear, dict_create_linear_expandable, dict_free)
15675 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15676 Make functions static.
15677
15678 2019-01-10 Keith Seitz <keiths@redhat.com>
15679
15680 PR gdb/23712
15681 PR symtab/23010
15682 * dictionary.h (struct dictionary): Replace declaration with
15683 multidictionary.
15684 (dict_create_hashed, dict_create_hashed_expandable)
15685 (dict_create_linear, dict_create_linear_expandable)
15686 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15687 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15688 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15689 taking multidictionary argument.
15690 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15691 * block.h (struct block) <dict>: Change to multidictionary
15692 and rename `multidict'.
15693 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15694 symmisc.c: Update all dictionary references to multidictionary.
15695
15696 2019-01-10 Keith Seitz <keiths@redhat.com>
15697
15698 PR gdb/23712
15699 PR symtab/23010
15700 * dictionary.c: Include unordered_map.
15701 (pending_to_vector): New function.
15702 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15703 Rewrite the non-"_1" functions to take vector instead
15704 of linked list.
15705 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15706 "new" _1 versions of the same name.
15707 (multidictionary): Define.
15708 (std::hash<enum language): New definition.
15709 (collate_pending_symbols_by_language, mdict_create_hashed)
15710 (mdict_create_hashed_expandable, mdict_create_linear)
15711 (mdict_create_linear_expandable, mdict_free)
15712 (find_language_dictionary, create_new_language_dictionary)
15713 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15714 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15715 (mdict_size, mdict_empty): New functions.
15716 * dictionary.h (mdict_iterator): Define.
15717
15718 2019-01-10 Pedro Alves <palves@redhat.com>
15719
15720 * breakpoint.c (read_uploaded_action)
15721 (create_tracepoint_from_upload): Adjust to use
15722 gdb::unique_xmalloc_ptr.
15723 * ctf.c (ctf_write_uploaded_tp):
15724 (SET_ARRAY_FIELD): Use emplace_back.
15725 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15726 * tracefile-tfile.c (tfile_write_uploaded_tp):
15727 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15728 gdb::unique_xmalloc_ptr.
15729 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15730 at_string, cond_string, cmd_strings>: Replace char pointers
15731 with gdb::unique_xmalloc_ptr.
15732
15733 2019-01-10 Pedro Alves <palves@redhat.com>
15734
15735 * solib-target.c (library_list_start_library): Don't xstrdup name.
15736
15737 2019-01-10 Pedro Alves <palves@redhat.com>
15738
15739 * mdebugread.c (parse_partial_symbols): Use
15740 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15741
15742 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15743
15744 * linux-fork.c (scoped_switch_fork_info)
15745 <~scoped_switch_fork_info>: Fix incorrect variable name.
15746
15747 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15748
15749 * linux-fork.c (scoped_switch_fork_info)
15750 <scoped_switch_fork_info>: Make explicit.
15751 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15752
15753 2019-01-10 Tom Tromey <tom@tromey.com>
15754
15755 * objfiles.h (objfile::reset_psymtabs): Update.
15756 * objfiles.c (objfile::objfile): Update.
15757 * psymtab.h (psymtab_storage::obstack): Update.
15758 (psymtab_storage::m_obstack): Use gdb::optional.
15759 (class psymtab_storage): Update comment. Remove objfile
15760 parameter.
15761 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15762
15763 2019-01-10 Tom Tromey <tom@tromey.com>
15764
15765 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15766 <free_psymtabs>: Now private.
15767 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15768 (allocate_psymtab): Use new method.
15769
15770 2019-01-10 Tom Tromey <tom@tromey.com>
15771
15772 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15773 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15774 * mdebugread.c (parse_partial_symbols): Use
15775 allocate_dependencies.
15776 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15777 allocate_dependencies.
15778 (process_psymtab_comp_unit_reader)
15779 (build_type_psymtab_dependencies): Likewise.
15780 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15781
15782 2019-01-10 Tom Tromey <tom@tromey.com>
15783
15784 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15785 PSYMBOL_SET_LANGUAGE.
15786 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15787
15788 2019-01-10 Tom Tromey <tom@tromey.com>
15789
15790 * psymtab.h (psymtab_storage::obstack): New method.
15791 <m_obstack>: Rename from obstack; now private.
15792 * psymtab.c (psymtab_storage): Update.
15793 * dwarf2read.c (create_addrmap_from_index)
15794 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15795 Update.
15796
15797 2019-01-10 Tom Tromey <tom@tromey.com>
15798
15799 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15800 * objfiles.h (objfile::reset_psymtabs): New method.
15801
15802 2019-01-10 Tom Tromey <tom@tromey.com>
15803
15804 * symmisc.c (print_symbol_bcache_statistics): Update.
15805 (print_objfile_statistics): Update.
15806 * symfile.c (reread_symbols): Update.
15807 * psymtab.h (class psymtab_storage): New.
15808 * psymtab.c (psymtab_storage): New constructor.
15809 (~psymtab_storage): New destructor.
15810 (require_partial_symbols): Update.
15811 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15812 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15813 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15814 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15815 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15816 (start_psymtab_common, end_psymtab_common)
15817 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15818 (allocate_psymtab): Update.
15819 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15820 Update.
15821 (dump_psymtab_addrmap, maintenance_print_psymbols)
15822 (maintenance_check_psymtabs): Update.
15823 (class objfile_psymtabs): Move to objfiles.h.
15824 * psympriv.h (discard_psymtab): Now inline.
15825 (psymtab_discarder::psymtab_discarder): Update.
15826 (psymtab_discarder::~psymtab_discarder): Update.
15827 (ALL_OBJFILE_PSYMTABS): Rewrite.
15828 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15829 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15830 Remove fields.
15831 <partial_symtabs>: New field.
15832 (class objfile_psymtabs): Move from psymtab.h. Update.
15833 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15834 psymbol_cache.
15835 (objfile::~objfile): Don't destroy psymbol_cache.
15836 * mdebugread.c (parse_partial_symbols): Update.
15837 * dwarf2read.c (create_addrmap_from_index)
15838 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15839 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15840 (add_partial_subprogram, dwarf2_ranges_read): Update.
15841 * dwarf-index-write.c (write_address_map)
15842 (write_one_signatured_type, recursively_write_psymbols)
15843 (class debug_names, class debug_names, write_psymtabs_to_index):
15844 Update.
15845
15846 2019-01-10 Tom Tromey <tom@tromey.com>
15847
15848 * symtab.h (SYMBOL_SET_NAMES): Update.
15849 (symbol_set_names): Update.
15850 (MSYMBOL_SET_NAMES): Update.
15851 * symtab.c (symbol_set_names): Change argument to be an
15852 objfile_per_bfd_storage.
15853 * psymtab.c (add_psymbol_to_bcache): Update.
15854 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15855
15856 2019-01-10 Tom Tromey <tom@tromey.com>
15857
15858 * symtab.c (create_demangled_names_hash): Change argument to be an
15859 objfile_per_bfd_storage.
15860 (symbol_set_names): Update.
15861
15862 2019-01-10 Tom Tromey <tom@tromey.com>
15863
15864 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15865 init_psymbol_list.
15866 * psymtab.c (init_psymbol_list): Do nothing if already called.
15867 * psympriv.h (init_psymbol_list): Add comment.
15868 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15869 init_psymbol_list.
15870 * dbxread.c (dbx_symfile_read): Unconditionally call
15871 init_psymbol_list.
15872
15873 2019-01-10 Tom Tromey <tom@tromey.com>
15874
15875 * xcoffread.c (scan_xcoff_symtab): Update.
15876 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15877 "where".
15878 * mdebugread.c (parse_partial_symbols)
15879 (handle_psymbol_enumerators): Update.
15880 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15881 * dbxread.c (read_dbx_symtab): Update.
15882 * psympriv.h (psymbol_placement): New enum.
15883 (add_psymbol_to_list): Update.
15884
15885 2019-01-10 Tom Tromey <tom@tromey.com>
15886
15887 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15888 static_psymbols parameters.
15889 (scan_xcoff_symtab): Update.
15890 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15891 static_psymbols parameters.
15892 * psympriv.h (start_psymtab_common): Update.
15893 * mdebugread.c (parse_partial_symbols): Update.
15894 * dwarf2read.c (create_partial_symtab): Update.
15895 * dbxread.c (read_dbx_symtab): Update.
15896 (start_psymtab): Remove global_psymbols and static_psymbols
15897 parameters.
15898
15899 2019-01-10 Tom Tromey <tom@tromey.com>
15900
15901 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15902 * psymtab.c (allocate_psymtab): Add comment.
15903 * psympriv.h (allocate_psymtab): Add comment.
15904 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15905 initializations.
15906 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15907
15908 2019-01-10 Tom Tromey <tom@tromey.com>
15909
15910 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15911 Don't declare.
15912 * mipsread.c: Include mdebugread.h.
15913 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15914 Declare.
15915 * elfread.c: Include mdebugread.h.
15916
15917 2019-01-09 Tom Tromey <tom@tromey.com>
15918
15919 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15920 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15921 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15922 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15923 (psym_lookup_symbol, psym_find_last_source_symtab)
15924 (psym_forget_cached_source_info, psym_print_stats)
15925 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15926 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15927 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15928 (psym_find_compunit_symtab_by_address)
15929 (maintenance_print_psymbols, maintenance_info_psymtabs)
15930 (maintenance_check_psymtabs): Use ranged for.
15931 * psymtab.h (class objfile_psymtabs): New.
15932 (require_partial_symbols): Return objfile_psymtabs.
15933 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15934
15935 2019-01-09 Tom Tromey <tom@tromey.com>
15936
15937 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15938 (find_pc_mapped_section, list_overlays_command)
15939 (map_overlay_command, unmap_overlay_command)
15940 (simple_overlay_update): Use all_objfiles.
15941 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15942 * printcmd.c (info_symbol_command): Use all_objfiles.
15943 * objfiles.h (ALL_OBJSECTIONS): Remove.
15944 * maint.c (maintenance_translate_address): Use all_objfiles.
15945 * gcore.c (gcore_create_callback): Use all_objfiles.
15946 (objfile_find_memory_regions): Likewise.
15947
15948 2019-01-09 Tom Tromey <tom@tromey.com>
15949
15950 * symtab.c (find_line_symtab, info_sources_command)
15951 (make_source_files_completion_list): Use objfile_compunits.
15952 * source.c (select_source_symtab): Use objfile_compunits.
15953 * objfiles.h (struct objfile): Update comment.
15954 (ALL_OBJFILES): Remove.
15955 (ALL_FILETABS): Remove.
15956 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15957 objfile_compunits.
15958
15959 2019-01-09 Tom Tromey <tom@tromey.com>
15960
15961 * symmisc.c (print_objfile_statistics, dump_objfile)
15962 (maintenance_print_symbols): Use compunit_filetabs.
15963 * source.c (forget_cached_source_info_for_objfile): Use
15964 compunit_filetabs.
15965 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15966 (ALL_FILETABS): Use compunit_filetabs.
15967 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15968 * coffread.c (coff_symtab_read): Use compunit_filetabs.
15969
15970 2019-01-09 Tom Tromey <tom@tromey.com>
15971
15972 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15973 (compunit_filetabs): New.
15974 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15975 compunit_filetabs.
15976 (info_sources_command, make_source_files_completion_list): Remove
15977 declaration.
15978 * symmisc.c (print_objfile_statistics, dump_objfile)
15979 (maintenance_print_symbols): Remove declaration.
15980 (maintenance_info_symtabs): Use compunit_filetabs.
15981 (maintenance_info_line_tables): Likewise.
15982 * source.c (select_source_symtab): Change local variable name.
15983 (forget_cached_source_info_for_objfile): Remove declaration.
15984 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15985 * objfiles.c (objfile_relocate1): Remove declaration.
15986 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15987 declaration.
15988 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15989 * coffread.c (coff_symtab_read): Remove declaration.
15990 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15991 compunit_filetabs.
15992
15993 2019-01-09 Tom Tromey <tom@tromey.com>
15994
15995 * symtab.c (lookup_objfile_from_block)
15996 (find_pc_sect_compunit_symtab, search_symbols)
15997 (default_collect_symbol_completion_matches_break_on): Use
15998 objfile_compunits.
15999 * objfiles.h (ALL_COMPUNITS): Remove.
16000 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16001 * cp-support.c (add_symbol_overload_list_qualified): Use
16002 objfile_compunits.
16003 * ada-lang.c (ada_collect_symbol_completion_matches)
16004 (ada_add_global_exceptions): Use objfile_compunits.
16005
16006 2019-01-09 Tom Tromey <tom@tromey.com>
16007
16008 * source.c (select_source_symtab)
16009 (forget_cached_source_info_for_objfile): Remove declaration.
16010 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16011 declaration.
16012 * maint.c (count_symtabs_and_blocks): Remove declaration.
16013 * cp-support.c (add_symbol_overload_list_qualified): Remove
16014 declaration.
16015 * coffread.c (coff_symtab_read): Remove declaration.
16016 * symtab.c (lookup_symbol_in_objfile_symtabs)
16017 (basic_lookup_transparent_type_1): Use objfile_compunits.
16018 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16019 (info_sources_command, search_symbols)
16020 (default_collect_symbol_completion_matches_break_on)
16021 (make_source_files_completion_list): Remove declaration.
16022 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16023 (ada_collect_symbol_completion_matches)
16024 (ada_add_global_exceptions): Remove declaration.
16025 * linespec.c (iterate_over_all_matching_symtabs): Use
16026 objfile_compunits.
16027 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16028 (class objfile_compunits): New.
16029 (ALL_COMPUNITS): Use objfile_compunits.
16030 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16031 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16032 objfile_compunits.
16033 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16034
16035 2019-01-09 Tom Tromey <tom@tromey.com>
16036
16037 * symtab.c (search_symbols)
16038 (default_collect_symbol_completion_matches_break_on): Use
16039 objfile_msymbols.
16040 * ada-lang.c (ada_lookup_simple_minsym)
16041 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16042 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16043 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16044 objfile_msymbols.
16045 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16046 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16047 * objc-lang.c (find_methods): Use objfile_msymbols.
16048 (info_selectors_command, info_classes_command): Likewise.
16049 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16050 * objfiles.h (class objfile_msymbols): New.
16051 (ALL_OBJFILE_MSYMBOLS): Remove.
16052 (ALL_MSYMBOLS): Remove.
16053
16054 2019-01-09 Tom Tromey <tom@tromey.com>
16055
16056 * common/next-iterator.h (next_adapter): Add Iterator template
16057 parameter.
16058 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16059 (class all_objfiles_safe): New.
16060 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16061 * objfiles.c (put_objfile_before): Update comment.
16062 (add_separate_debug_objfile): Likewise.
16063 (free_all_objfiles): Use all_objfiles_safe.
16064 (objfile_purge_solibs): Likewise.
16065
16066 2019-01-09 Tom Tromey <tom@tromey.com>
16067
16068 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16069 (expand_symtab_containing_pc, lookup_static_symbol)
16070 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16071 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16072 all_objfiles.
16073 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16074 * breakpoint.c (create_overlay_event_breakpoint)
16075 (create_longjmp_master_breakpoint)
16076 (create_std_terminate_master_breakpoint)
16077 (create_exception_master_breakpoint): Use all_objfiles.
16078 * linux-thread-db.c (try_thread_db_load_from_pdir)
16079 (has_libpthread): Use all_objfiles.
16080 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16081 * linespec.c (iterate_over_all_matching_symtabs)
16082 (search_minsyms_for_name): Use all_objfiles.
16083 * maint.c (maintenance_info_sections): Use all_objfiles.
16084 * main.c (captured_main_1): Use all_objfiles.
16085 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16086 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16087 * guile/scm-pretty-print.c
16088 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16089 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16090 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16091 (maintenance_print_msymbols): Use all_objfiles.
16092 * source.c (select_source_symtab): Use all_objfiles.
16093 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16094 * symfile.c (remove_symbol_file_command)
16095 (expand_symtabs_matching, map_symbol_filenames): Use
16096 all_objfiles.
16097 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16098 all_objfiles.
16099 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16100 * objc-lang.c (find_methods): Use all_objfiles.
16101 * objfiles.c (have_partial_symbols, have_full_symbols)
16102 (have_minimal_symbols, qsort_cmp)
16103 (default_iterate_over_objfiles_in_search_order): Use
16104 all_objfiles.
16105 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16106 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16107 (maintenance_check_psymtabs): Use all_objfiles.
16108 (ALL_PSYMTABS): Remove.
16109 * compile/compile-object-run.c (do_module_cleanup): Use
16110 all_objfiles.
16111 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16112 * cp-support.c (add_symbol_overload_list_qualified): Use
16113 all_objfiles.
16114 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16115 Use all_objfiles.
16116 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16117 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16118 all_objfiles.
16119 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16120 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16121 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16122 Uses all_objfiles.
16123 * solib.c (solib_read_symbols): Use all_objfiles
16124
16125 2019-01-09 Tom Tromey <tom@tromey.com>
16126
16127 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16128 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16129 all_objfiles.
16130 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16131 * symmisc.c (print_symbol_bcache_statistics)
16132 (print_objfile_statistics, maintenance_print_objfiles)
16133 (maintenance_info_symtabs, maintenance_check_symtabs)
16134 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16135 all_objfiles.
16136 * source.c (forget_cached_source_info): Use all_objfiles.
16137 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16138 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16139 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16140 * objfiles.c (update_section_map): Use all_objfiles.
16141 (shared_objfile_contains_address_p): Likewise.
16142 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16143 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16144
16145 2019-01-09 Tom Tromey <tom@tromey.com>
16146
16147 * common/next-iterator.h: New file.
16148 * objfiles.h (class all_objfiles): New.
16149 (struct objfile_iterator): New.
16150
16151 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16152
16153 * NEWS: Move the description of the changed "frame", "select-frame",
16154 and "info frame" commands to the Changed commands section.
16155
16156 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16157
16158 * gdbtypes.c (check_stub_method_group): Remove handling of old
16159 mangling schemes.
16160 * linespec.c (find_methods): Likewise.
16161 * stabsread.c (read_member_functions): Likewise.
16162 * valops.c (search_struct_method): Likewise.
16163 (value_struct_elt_for_reference): Likewise.
16164 * NEWS: Mention this change.
16165
16166 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16167
16168 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16169 print_source_lines.
16170 * source.c (print_source_lines_base): Update line number check.
16171 (print_source_lines): New function.
16172 (source_lines_range::source_lines_range): New function.
16173 * source.h (class source_lines_range): New class.
16174 (print_source_lines): New declaration.
16175
16176 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16177
16178 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16179
16180 2019-01-08 Tom Tromey <tom@tromey.com>
16181 Simon Marchi <simon.marchi@ericsson.com>
16182
16183 PR gdb/24060
16184 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16185 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16186 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16187 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16188 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16189 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16190
16191 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16192
16193 * source.c (select_source_symtab): Move header comment to
16194 declaration in source.h.
16195 (forget_cached_source_info_for_objfile): Likewise.
16196 (forget_cached_source_info): Likewise.
16197 (identify_source_line): Likewise.
16198 * source.h (identify_source_line): Move declaration from symtab.h
16199 and add comment from source.c
16200 (print_source_lines): Likewise.
16201 (forget_cached_source_info_for_objfile): Likewise.
16202 (forget_cached_source_info): Likewise.
16203 (select_source_symtab): Likewise.
16204 (enum print_source_lines_flag): Move definition from symtab.h.
16205 * symtab.h (identify_source_line): Move declaration to source.h.
16206 (print_source_lines): Likewise.
16207 (forget_cached_source_info_for_objfile): Likewise.
16208 (forget_cached_source_info): Likewise.
16209 (select_source_symtab): Likewise.
16210 (enum print_source_lines_flag): Move definition to source.h.
16211 * tui/tui-hooks.c: Add 'source.h' include.
16212
16213 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16214
16215 * source.c (print_source_lines_base): Handle requests to print
16216 reverse line number sequences, and guard against empty lines
16217 string.
16218
16219 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16220
16221 * source.c (print_source_lines_base): Fix skip of '\r' if next
16222 character is '\n'.
16223
16224 2019-01-06 Tom Tromey <tom@tromey.com>
16225
16226 * c-exp.y (struct c_parse_state) <macro_original_text,
16227 expansion_obstack>: New member.
16228 (macro_original_text, expansion_obstack): Remove globals.
16229 (scan_macro_expansion, scanning_macro_expansion)
16230 (finished_macro_expansion): Update.
16231 (scan_macro_cleanup): Remove.
16232 (yylex, c_parse): Update.
16233
16234 2019-01-06 Tom Tromey <tom@tromey.com>
16235
16236 * c-exp.y (struct c_parse_state) <strings>: New member.
16237 (operator_stoken): Update.
16238
16239 2019-01-06 Tom Tromey <tom@tromey.com>
16240
16241 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16242 (union type_stack_elt) <typelist_val>: Now a pointer to
16243 std::vector.
16244 (type_stack_cleanup): Don't declare.
16245 (push_typelist): Update.
16246 * parse.c (pop_typelist): Return a std::vector.
16247 (push_typelist): Take a std::vector.
16248 (follow_types): Update. Do not free args.
16249 (type_stack_cleanup): Remove.
16250 * c-exp.y (struct c_parse_state): New.
16251 (cpstate): New global.
16252 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16253 (nonempty_typelist): Update.
16254 (func_mod): Create a new vector.
16255 (c_parse): Create a c_parse_state.
16256 (check_parameter_typelist): Do not delete params.
16257 (function_method): Update. Do not delete type_list.
16258
16259 2019-01-06 Tom Tromey <tom@tromey.com>
16260
16261 PR gdb/28155:
16262 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16263 check_typedef.
16264 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16265 (print_return_value): Likewise.
16266
16267 2019-01-05 Tom Tromey <tom@tromey.com>
16268
16269 * contrib/cleanup_check.py: Remove.
16270 * contrib/gcc-with-excheck: Remove.
16271 * contrib/exsummary.py: Remove.
16272 * contrib/excheck.py: Remove.
16273
16274 2019-01-05 Joel Brobecker <brobecker@adacore.com>
16275
16276 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16277 NULL. Initialize tpprev to NULL instead of assigning it
16278 to NULL on the next statement.
16279 * windows-nat.c (windows_delete_thread): Remove check for
16280 main_thread_id before printing thread exit notifications.
16281 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16282 Remove thread ID check against main_thread_id.
16283 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16284 windows_delete_thread.
16285 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16286
16287 2019-01-04 Tom Tromey <tom@tromey.com>
16288
16289 * compile/compile.c (_initialize_compile): Use upper case for
16290 metasyntactic variables.
16291 * symmisc.c (_initialize_symmisc): Use upper case for
16292 metasyntactic variables.
16293 * psymtab.c (_initialize_psymtab): Use upper case for
16294 metasyntactic variables.
16295 * demangle.c (demangle_command): Use upper case for metasyntactic
16296 variables.
16297 (_initialize_demangler): Likewise.
16298 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16299 variables.
16300
16301 2019-01-03 Tom Tromey <tom@tromey.com>
16302
16303 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16304
16305 2019-01-03 Tom Tromey <tom@tromey.com>
16306
16307 * python/py-symtab.c (salpy_str): Update.
16308 (struct salpy_sal_object) <symtab>: Now a PyObject.
16309 (salpy_dealloc): Update.
16310 (del_objfile_sal): Use gdbpy_ref.
16311
16312 2019-01-03 Tom Tromey <tom@tromey.com>
16313
16314 * python/py-type.c (convert_field): Use new_reference. Return
16315 gdbpy_ref.
16316 (make_fielditem): Return gdbpy_ref.
16317 (typy_fields): Update.
16318 (typy_getitem): Update.
16319 (field_name): Return gdbpy_ref. Use new_reference.
16320 (typy_iterator_iternext): Update.
16321
16322 2019-01-03 Tom Tromey <tom@tromey.com>
16323
16324 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16325
16326 2019-01-03 Tom Tromey <tom@tromey.com>
16327
16328 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16329 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16330 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16331 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16332 (pspy_set_type_printers): Likewise.
16333 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16334 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16335 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16336 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16337 (objfpy_set_type_printers): Likewise.
16338
16339 2019-01-03 Tom Tromey <tom@tromey.com>
16340
16341 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16342 (gdbpy_print_stack): Use gdbpy_err_fetch.
16343 * python/python-internal.h (class gdbpy_err_fetch): New class.
16344 (class gdbpy_enter) <m_error_type, m_error_value,
16345 m_error_traceback>: Remove.
16346 <m_error>: New member.
16347 (gdbpy_exception_to_string): Don't declare.
16348 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16349 * python/py-value.c (convert_value_from_python): Use
16350 gdbpy_err_fetch.
16351 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16352 gdbpy_exception_to_string.
16353 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16354 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16355 gdbpy_err_fetch.
16356
16357 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16358
16359 * linux-nat.c (delete_lwp_cleanup): Delete.
16360 (struct lwp_deleter): New struct.
16361 (lwp_info_up): New typedef.
16362 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16363 lwp_info_up.
16364
16365 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16366
16367 * linux-fork.c (class scoped_switch_fork_info): New class.
16368 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16369
16370 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16371
16372 * valops.c (find_overload_match): Remove use of null_cleanup, and
16373 calls to do_cleanups.
16374
16375 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16376
16377 * compile/compile-cplus-types.c
16378 (compile_cplus_instance::decl_name): Handle changes to
16379 cp_func_name.
16380 * cp-support.c (cp_func_name): Update header comment, update
16381 return type.
16382 * cp-support.h (cp_func_name): Update return type in declaration.
16383 * valops.c (find_overload_match): Move temp_func local to top
16384 level of function and change its type. Use temp_func to hold and
16385 delete temporary string obtained from cp_func_name.
16386
16387 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16388
16389 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16390 gdb::char_vector, remove cleanup, and update uses of `msg`.
16391
16392 2019-01-03 Jim Wilson <jimw@sifive.com>
16393
16394 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16395
16396 2019-01-02 Tom Tromey <tom@tromey.com>
16397
16398 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16399 (tdesc_parse_xml): Remove cleanups.
16400 * target-descriptions.h (make_cleanup_free_target_description):
16401 Don't declare.
16402 (target_desc_deleter): New struct.
16403 (target_desc_up): New typedef.
16404 * target-descriptions.c (target_desc_deleter::operator()): Rename
16405 from free_target_description.
16406 (make_cleanup_free_target_description): Remove.
16407
16408 2019-01-02 Tom Tromey <tom@tromey.com>
16409
16410 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16411 constructor, destructor.
16412 (linespec_parser): Remove typedef.
16413 (~linespec_parser): Rename from linespec_parser_delete.
16414 (linespec_lex_to_end, linespec_complete_label)
16415 (linespec_complete): Update.
16416 (decode_line_full): Remove cleanups.
16417 (decode_line_1): Update.
16418
16419 2019-01-02 Tom Tromey <tom@tromey.com>
16420
16421 * python/python-internal.h (inferior_to_inferior_object): Change
16422 return type.
16423 * python/py-exitedevent.c (create_exited_event_object): Update.
16424 * python/py-inferior.c (inferior_to_inferior_object): Return
16425 gdbpy_ref.
16426 (python_new_inferior, python_inferior_deleted)
16427 (thread_to_thread_object, delete_thread_object)
16428 (build_inferior_list, gdbpy_selected_inferior): Update.
16429 * python/py-infthread.c (create_thread_object): Update. Also fail
16430 if inferior_to_inferior_object fails.
16431
16432 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16433
16434 * inferior.h (class inferior) <displaced_step_state>: New field.
16435 * infrun.h (struct displaced_step_state): Move here from
16436 infrun.c. Initialize fields, add constructor.
16437 <inf>: Remove field.
16438 <reset>: New method.
16439 * infrun.c (struct displaced_step_inferior_state): Move to
16440 infrun.h.
16441 (displaced_step_inferior_states): Remove.
16442 (get_displaced_stepping_state): Adust.
16443 (displaced_step_in_progress_any_inferior): Adjust.
16444 (displaced_step_in_progress_thread): Adjust.
16445 (displaced_step_in_progress): Adjust.
16446 (add_displaced_stepping_state): Remove.
16447 (get_displaced_step_closure_by_addr): Adjust.
16448 (remove_displaced_stepping_state): Remove.
16449 (infrun_inferior_exit): Call displaced_step_state.reset.
16450 (use_displaced_stepping): Don't check for NULL.
16451 (displaced_step_prepare_throw): Call
16452 get_displaced_stepping_state.
16453 (displaced_step_fixup): Don't check for NULL.
16454 (prepare_for_detach): Don't check for NULL.
16455
16456 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16457
16458 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16459 in case of call that did not complete.
16460
16461 2019-01-02 Andrey Utkin <autkin@undo.io>
16462
16463 * symfile.c (find_separate_debug_file): Fix search of debug files for
16464 remote debuggee.
16465
16466 2019-01-02 Tom Tromey <tom@tromey.com>
16467
16468 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16469 indentation.
16470 * python/py-frame.c (frapy_older): Remove cast.
16471 (frapy_newer): Likewise.
16472 * python/py-breakpoint.c (local_setattro): Remove cast.
16473 * python/py-arch.c (archpy_name): Remove local variable.
16474 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16475
16476 2019-01-02 Joel Brobecker <brobecker@adacore.com>
16477
16478 * unittests/basic_string_view/element_access/char/empty.cc:
16479 Fix year range in copyright header.
16480
16481 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16482
16483 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16484 Delete.
16485 <operator==>: Update with for removed field.
16486 <hash>: Likewise.
16487 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16488 <isa_features>: ...this.
16489 <abi_features>: New field.
16490 (riscv_isa_flen): Update comment.
16491 (riscv_abi_xlen): New declaration.
16492 (riscv_abi_flen): New declaration.
16493 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16494 isa_features.
16495 (riscv_abi_xlen): New function.
16496 (riscv_isa_flen): Update to get answer from isa_features.
16497 (riscv_abi_flen): New function.
16498 (riscv_has_fp_abi): Update to get answer from abi_features.
16499 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16500 xlen and flen.
16501 (riscv_call_info) <xlen, flen>: Update comment.
16502 (riscv_call_arg_struct): Remove invalid assertions
16503 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16504 is removed.
16505 (riscv_gdbarch_init): Gather isa features and abi features
16506 separately, ensure both match on the gdbarch when reusing an old
16507 gdbarch. Relax an error check to allow 32-bit abi float to run on
16508 a target with 64-bit float hardware.
16509
16510 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16511
16512 * source.c (search_command_helper): Stop reverse search
16513 when line 1 has been searched.
16514
16515 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16516
16517 * record-full.c (record_full_base_target::close): Rewrite
16518 record_full_core_buf_list free logic.
16519
16520 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16521
16522 * break-catch-syscall.c (print_one_catch_syscall): xfree
16523 the last text.
16524
16525 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16526
16527 * top.c (print_gdb_version): Update Copyright year in version
16528 message.
16529
16530 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16531
16532 Update copyright year range in all GDB files.
16533
16534 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16535
16536 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16537
16538 For older changes see ChangeLog-2018.
16539 \f
16540 Local Variables:
16541 mode: change-log
16542 left-margin: 8
16543 fill-column: 74
16544 version-control: never
16545 coding: utf-8
16546 End:
16547
This page took 0.399348 seconds and 3 git commands to generate.