gdb/ChangeLog

   1 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
   4         std::unique_ptr.
   5         (displaced_step_clear): Rename to...
   6         (displaced_step_reset): ... this.  Just call displaced->reset ().
   7         (displaced_step_clear_cleanup): Rename to...
   8         (displaced_step_reset_cleanup): ... this.
   9         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
  10         (displaced_step_fixup): Likewise.
  11         (resume_1): Likewise.
  12         (handle_inferior_event): Restore child's memory before calling
  13         displaced_step_fixup on the parent.
  14         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
  15         to std::unique_ptr.
  16         <step_closure>: Change type to std::unique_ptr.
  17
  18 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
  19
  20         * version.in: Set GDB version number to 9.1.
  21
  22 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
  23
  24         PR gdb/25190:
  25         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
  26         * gdb/remote.c (remote_console_output): Update.
  27         * gdb/ui-file.c (fputs_unfiltered): Rename to...
  28         (ui_file_puts): ...this.
  29         * gdb/ui-file.h (ui_file_puts): Add declaration.
  30         * gdb/utils.c (emit_style_escape): Update.
  31         (flush_wrap_buffer): Update.
  32         (fputs_maybe_filtered): Update.
  33         (fputs_unfiltered): Add function.
  34
  35 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
  36
  37         * gdb/event-loop.c (gdb_wait_for_event): Update.
  38         * gdb/printcmd.c (printf_command): Update.
  39         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
  40         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
  41         (gdb_os_flush_stderr): Update.
  42         * gdb/remote.c (remote_console_output): Update.
  43         * gdb/ui-file.c (gdb_flush): Rename to...
  44         (ui_file_flush): ...this.
  45         (stderr_file::write): Update.
  46         (stderr_file::puts): Update.
  47         * gdb/ui-file.h (gdb_flush): Rename to...
  48         (ui_file_flush): ...this.
  49         * gdb/utils.c (gdb_flush): Add function.
  50         * gdb/utils.h (gdb_flush): Add declaration.
  51
  52 2020-02-07  Tom Tromey  <tromey@adacore.com>
  53
  54         PR breakpoints/24915:
  55         * source.c (find_and_open_source): Do not check basenames_may_differ.
  56
  57 2020-01-10  Christian Biesinger  <cbiesinger@google.com>
  58
  59         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
  60
  61 2020-01-07  Tom Tromey  <tromey@adacore.com>
  62
  63         PR build/24937:
  64         * stap-probe.c (class stap_static_probe_ops): Add constructor.
  65
  66 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
  67
  68         * stack.c (print_frame_info): Move disassemble_next_line code
  69         inside source_print block.
  70
  71 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
  72
  73         * gdbarch.sh: Update copyright year range of generated files.
  74
  75 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
  76
  77         Update copyright year range in all the GDB files automatically
  78         handled by our copyright.py script.
  79
  80 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
  81
  82         * copyright.py: Convert to Python 3.
  83
  84 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
  85
  86         * copyright.py: Adapt after move of gnulib directory from gdb
  87         directory to toplevel directory.
  88
  89 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
  90
  91         * copyright.py (main): Exit if run from the wrong directory.
  92
  93 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
  94
  95         * top.c (print_gdb_version): Change copyright year to 2020.
  96
  97 2019-12-26  Christian Biesinger  <cbiesinger@google.com>
  98
  99         * configure: Regenerate.
 100         * configure.ac: Quote variable arguments of test.
 101         * gdbsupport/common.m4: Likewise.
 102
 103 2019-12-21  Eli Zaretskii  <eliz@gnu.org>
 104
 105         * top.c (print_gdb_configuration): Print "--with-xxhash" or
 106         "--without-xxhash" according to HAVE_LIBXXHASH.
 107
 108 2019-12-18  Tom Tromey  <tromey@adacore.com>
 109
 110         PR build/25268:
 111         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
 112         type on macOS.  Add comment.
 113
 114 2019-12-18  Tom Tromey  <tromey@adacore.com>
 115
 116         PR build/25250:
 117         * ui-out.c (ui_out::vmessage): Update.
 118         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
 119         Rename.
 120         (string_field): Update.
 121         (signed_field): Update.
 122
 123 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 124
 125         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 126
 127 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 128
 129         * version.in: Set GDB version number to 9.0.90.DATE-git.
 130
 131 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 132
 133         GDB 9.0.90 released.
 134
 135 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 136
 137         * version.in: Set GDB version number to 9.0.90.
 138
 139 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 140
 141         * NEWS: Change "Changes since GDB 8.3" into "Changes in GDB 9".
 142
 143 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 144
 145         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 146         * version.in: Bump version to 9.0.90.DATE-git.
 147
 148 2019-12-11  Tom Tromey  <tromey@adacore.com>
 149
 150         PR build/25268:
 151         * gdbsupport/thread-pool.c (set_thread_name): New function.
 152         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 153         (thread_pool::thread_function): Call set_thread_name.
 154
 155 2019-12-11  Tom Tromey  <tromey@adacore.com>
 156
 157         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 158         bfd_get_signed_8.
 159
 160 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 161
 162         * NEWS: Document -raw-values option and the related setting commands.
 163         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 164         only set it on when /r is given.
 165         * valprint.c (value_print_option_defs): New element raw-values.
 166         * Makefile.in: Add the new file.
 167
 168 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 169
 170         * gdbsupport/safe-strerror.c: Supress the unused function warning
 171         for select_strerror_r.
 172
 173 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 174
 175         * config.in: Regenerate.
 176         * configure: Regenerate.
 177         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 178         safe_strerror instead of strerror.
 179         * gdbsupport/common.m4: Don't check for strerror.
 180         * gdbsupport/safe-strerror.c: Support both the glibc version
 181         of strerror_r and the XSI version.
 182
 183 2019-12-10  Tom Tromey  <tromey@adacore.com>
 184
 185         * ada-typeprint.c (print_choices): Use a single "?".
 186         (print_variant_part): Print "?" if the discriminant name
 187         is not known.
 188
 189 2019-12-10  George Barrett  <bob@bob131.so>
 190
 191         Fix scripted probe breakpoints.
 192         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 193         declaration forward.
 194         (breakpoint_ops_for_event_location_type)
 195         (breakpoint_ops_for_event_location): Add function definitions.
 196         (break_command_1, trace_command): Use
 197         breakpoint_ops_for_event_location.
 198         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 199         declarations.
 200         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 201         breakpoint_ops_for_event_location.
 202         * python/py-breakpoint.c (bppy_init): Use
 203         breakpoint_ops_for_event_location.
 204
 205 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 206
 207         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 208         when ranking an lvalue argument for an rvalue parameter.
 209
 210 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 211
 212         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 213         template argument for scoped_restore_tmpl from bool to int.
 214
 215 2019-12-07  Keith Seitz  <keiths@redhat.com>
 216
 217         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 218         (build_id_to_debug_bfd): Make static, rewriting to use
 219         build_id_to_bfd_suffix.
 220         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 221         adding `suffix' parameter. Append SUFFIX to file names
 222         when searching for matching files.
 223         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 224         (build_id_to_exec_bfd): Likewise.
 225         * build-id.h (build_id_to_debug_bfd): Clarify that function
 226         searches for BFD of debug info file.
 227         (build_id_to_exec_bfd): Declare.
 228         * corelow.c: Include build-id.h.
 229         (locate_exec_from_corefile_build_id): New function.
 230         (core_target_open): If no executable BFD is found,
 231         search for a core file BFD using build-id.
 232
 233 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 234
 235         * bcache.c: Put in namespace gdb.
 236         * bcache.h: Likewise.
 237         * gdbtypes.c (check_types_worklist): Update.
 238         (types_deeply_equal): Update.
 239         * macrotab.c (struct macro_table) <bcache>: Update.
 240         (new_macro_table): Update.
 241         * macrotab.h (struct bcache): Put this forward declaration
 242         inside namespace gdb.
 243         (new_macro_table): Update.
 244         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 245         Update.
 246         <macro_cache>: Update.
 247         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 248
 249 2019-12-06  Tom de Vries  <tdevries@suse.de>
 250
 251         PR symtab/24971
 252         * block.c (best_symbol, better_symbol): New function.
 253         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 254         decl.
 255
 256 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 257
 258         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 259         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 260         for ranking see-through reference cases.
 261
 262 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 263         * stack.c (faas_command): Check a command is provided.
 264         * thread.c (taas_command, tfaas_command): Likewise.
 265
 266 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 267         * inferior.c (prune_inferiors):  Only call delete_inferior,
 268         Do not modify the inferior list.
 269
 270 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 271
 272         * c-exp.y: Update calls to lookup_typename,
 273         lookup_signed_typename and lookup_unsigned_typename.
 274         * c-lang.c (evaluate_subexp_c): Likewise.
 275         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 276         Likewise.
 277         * eval.c (binop_promote): Likewise.
 278         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 279         (lookup_unsigned_typename): Likewise.
 280         (lookup_signed_typename): Likewise.
 281         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 282         (lookup_signed_typename): Likewise.
 283         (lookup_typename): Likewise.
 284         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 285         lookup_typename, lookup_signed_typename,
 286         lookup_unsigned_typename.
 287         * m2-exp.y: Likewise.
 288         * printcmd.c (printf_wide_c_string): Likewise.
 289         (ui_printf): Likewise.
 290         * python/py-type.c (typy_lookup_typename): Likewise.
 291         * python/py-xmethods.c (python_xmethod_worker::invoke):
 292         Likewise.
 293         * rust-exp.y: Likewise.
 294
 295 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 296
 297         * configure.nat (obsd64): Add missing files x86-nat.o and
 298         nat/x86-dregs.o.
 299
 300 2019-12-04  Tom Tromey  <tom@tromey.com>
 301
 302         * valprint.c (val_print_string): Use metadata_style.
 303         * go-valprint.c (print_go_string): Use metadata style.
 304         * p-valprint.c (pascal_object_print_static_field): Use metadata
 305         style.
 306         * cp-valprint.c (cp_print_static_field): Use metadata style.
 307
 308 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 309             Chris January  <chris.january@arm.com>
 310
 311         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 312         tokens.
 313         (typebase): New patterns for complex, single/double precision, and
 314         single/double complex.
 315         (f77_keywords): Change token for complex keyword, and add single,
 316         double, and precision keywords.
 317
 318 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 319
 320         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 321         "info io_registers".
 322
 323 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 324
 325         * regcache.c (cooked_read_test): Initialize thread list of
 326         mock_inferior.
 327
 328 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 329
 330         * aarch64-linux-tdep.c: Remove includes.
 331
 332 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 333
 334         * aarch64-tdep.c: Remove includes.
 335
 336 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 337
 338         * filtered-iterator.h (filtered_iterator) <operator==,
 339         operator!=>: Compare wrapped iterators, not wrapped pointers.
 340         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 341         unittests/filtered_iterator-selftests.c.
 342         * unittests/filtered_iterator-selftests.c: New file.
 343
 344 2019-12-04  Tom Tromey  <tromey@adacore.com>
 345
 346         * gdbtypes.c (create_range_type): Inherit endianity
 347         from base type.
 348
 349 2019-12-04  Tom Tromey  <tromey@adacore.com>
 350
 351         * ada-lang.c (decode_constrained_packed_array)
 352         (ada_value_assign, value_assign_to_component): Update.
 353         * dwarf2loc.c (rw_pieced_value, access_memory)
 354         (dwarf2_compile_expr_to_ax): Update.
 355         * dwarf2read.c (dwarf2_add_field): Update.
 356         * eval.c (evaluate_subexp_standard): Update.
 357         * gdbarch.c, gdbarch.h: Rebuild.
 358         * gdbarch.sh (bits_big_endian): Remove.
 359         * gdbtypes.h (union field_location): Update comment.
 360         * target-descriptions.c (make_gdb_type): Update.
 361         * valarith.c (value_bit_index): Update.
 362         * value.c (struct value) <bitpos>: Update comment.
 363         (unpack_bits_as_long, modify_field): Update.
 364         * value.h (value_bitpos): Update comment.
 365
 366 2019-12-04  Tom Tromey  <tromey@adacore.com>
 367
 368         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 369         endian-ness.
 370
 371 2019-12-04  Tom Tromey  <tromey@adacore.com>
 372
 373         * dwarf2read.c (dwarf2_init_float_type)
 374         (dwarf2_init_complex_target_type): Add byte_order parameter.
 375         (read_base_type): Compute byte order earlier.
 376         * gdbtypes.c (init_float_type): Add byte_order parameter.
 377         * gdbtypes.h (init_float_type): Add byte_order parameter.
 378
 379 2019-12-04  Tom Tromey  <tromey@adacore.com>
 380
 381         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 382
 383 2019-12-04  Tom Tromey  <tromey@adacore.com>
 384
 385         * dwarf2read.c (process_structure_scope): Initialize
 386         "discr_offset".
 387
 388 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 389
 390         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 391         add it into the search spec.
 392         (parse_max_results_option): New function.
 393         (mi_info_functions_or_variables): Parse -max-results flag and pass
 394         it to mi_symbol_info.
 395         (mi_cmd_symbol_info_modules): Likewise.
 396         (mi_cmd_symbol_info_types): Likewise.
 397         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 398         return type to bool, change result container into a set, and don't
 399         add new results if we have enough already.
 400         (global_symbol_searcher::add_matching_msymbols): Change return
 401         type to bool, and don't add new results if we have enough already.
 402         (sort_search_symbols_remove_dups): Delete.
 403         (global_symbol_searcher::search): Early exit from search loop when
 404         we have enough results.  Use a std::set to collect the results
 405         from calling add_matching_symbols.
 406         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 407         member function.
 408         (global_symbol_searcher) <m_max_search_results>: New member
 409         variable.
 410         (global_symbol_searcher) <add_matching_symbols>: Update header
 411         comment and change return type to bool.
 412         (global_symbol_searcher) <add_matching_msymbols>: Update header
 413         comment and change return type to bool.
 414
 415 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 416
 417         * symtab.c (symbol_search::compare_search_syms): Update header
 418         comment.
 419         (global_symbol_searcher::is_suitable_msymbol): New function.
 420         (global_symbol_searcher::expand_symtabs): New function.
 421         (global_symbol_searcher::add_matching_symbols): New function.
 422         (global_symbol_searcher::add_matching_msymbols): New function.
 423         (global_symbol_searcher::search): Move most of the content
 424         into the new functions above, and call them as needed.
 425         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 426         function.
 427         (global_symbol_searcher) <add_matching_symbols>: New member
 428         function.
 429         (global_symbol_searcher) <add_matching_msymbols>: New member
 430         function.
 431         (global_symbol_searcher) <is_suitable_msymbol>: New member
 432         function.
 433
 434 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 435
 436         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 437         -symbol-info-module-variables entries.
 438         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 439         (mi_cmd_symbol_info_module_variables): Declare.
 440         * mi/mi-symbol-cmds.c
 441         (module_symbol_search_iterator): New typedef.
 442         (output_module_symbols_in_single_module_and_file): New function.
 443         (output_module_symbols_in_single_module): New function.
 444         (mi_info_module_functions_or_variables): New function.
 445         (mi_cmd_symbol_info_module_functions): New function.
 446         (mi_cmd_symbol_info_module_variables): New function.
 447         * NEWS: Mention new MI command.
 448
 449 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 450
 451         * bcache.c (hash): Remove.
 452         (hash_continue): Remove.
 453         * bcache.h (hash): Remove.
 454         (hash_continue): Remove.
 455         (struct bcache) <ctor>: Update.
 456         * psymtab.c (psymbol_hash): Update.
 457         * stabsread.c (hashname): Update.
 458         * utils.h (fast_hash): Add an argument for a start value,
 459         defaulting to zero.
 460
 461 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 462         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 463         (destroy_block_symbol_cache): New function.
 464         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 465         (resize_symbol_cache): Likewise.
 466
 467 2019-12-02  Tom Tromey  <tom@tromey.com>
 468
 469         * unittests/tui-selftests.c (run_tests): Make conditional.
 470         (_initialize_tui_selftest): Make conditional.
 471
 472 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 473
 474         * aix-thread.c (debug_aix_thread): Change type to bool.
 475
 476 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 477
 478         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 479
 480 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 481
 482         * dwarf2read.c (read_tag_string_type): Read the fields required to
 483         make a dynamic string, and possibly create a dynamic range for the
 484         string.
 485         (attr_to_dynamic_prop): Setup is_reference based on the type of
 486         attribute being processed.
 487         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 488         (resolve_dynamic_array): Rename to...
 489         (resolve_dynamic_array_or_string): ...this, update header comment,
 490         and accept TYPE_CODE_STRING.
 491         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 492
 493 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 494
 495         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 496         of its implementation from...
 497         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 498         the new function.
 499
 500 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 501
 502         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 503         create a range with stride where appropriate.
 504         * f-valprint.c: Include 'gdbarch.h'.
 505         (f77_print_array_1): Take the stride into account when walking the
 506         array.  Also convert the stride into addressable units.
 507         * gdbtypes.c (create_range_type): Initialise the stride to
 508         constant zero.
 509         (create_range_type_with_stride): New function, initialise the
 510         range as normal, and then setup the stride.
 511         (has_static_range): Include the stride here.  Also change the
 512         return type to bool.
 513         (create_array_type_with_stride): Consider the range stride if the
 514         array isn't given its own stride.
 515         (resolve_dynamic_range): Resolve the stride if needed.
 516         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 517         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 518         (TYPE_BIT_STRIDE): Define.
 519         (TYPE_ARRAY_BIT_STRIDE): Define.
 520         (create_range_type_with_stride): Declare.
 521         * valarith.c (value_subscripted_rvalue): Take range stride into
 522         account when walking the array.
 523
 524 2019-12-01  Tom Tromey  <tom@tromey.com>
 525
 526         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 527         specially.
 528
 529 2019-12-01  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 532         \0.
 533         * unittests/tui-selftests.c: New file.
 534         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 535
 536 2019-12-01  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 539
 540 2019-12-01  Tom Tromey  <tom@tromey.com>
 541
 542         * NEWS: Document new settings.
 543         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 544         * tui/tui-win.c (_initialize_tui_win): Add border style
 545         observers.
 546         * tui/tui-io.h (tui_apply_style): Declare.
 547         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 548         longer static.
 549         (apply_ansi_escape, tui_set_reverse_mode): Update.
 550         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 551         Add "skip_intensity" parameter.
 552         <changed>: New member.
 553         <do_set_value>: Declare.
 554         (tui_border_style, tui_active_border_style): Declare.
 555         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 556         globals.
 557         (cli_style_option): Initialize "changed".
 558         (cli_style_option::do_set_value): New function.
 559         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 560         parameter.  Update.
 561         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 562         (_initialize_cli_style): Update.  Create TUI border style
 563         commands.
 564
 565 2019-12-01  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 568         parameter.
 569         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 570         parameter.
 571         * tui/tui-win.h (compact_source): Declare.
 572         * tui/tui-win.c (compact_source): New global.
 573         (tui_set_compact_source, tui_show_compact_source): New functions.
 574         (_initialize_tui_win): Add "compact-source" setting.
 575         * tui/tui-source.c (tui_source_window::set_contents): Handle
 576         compact_source setting.
 577         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 578         * NEWS: Document new setting.
 579
 580 2019-11-30  Tom Tromey  <tom@tromey.com>
 581
 582         * dwarf2read.c (dwarf2_add_field): Include field offset when
 583         computing variant part length.
 584
 585 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 586         * NEWS:  Mention define-prefix.  Tell that command names can now
 587         contain a . character.
 588
 589 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 590
 591         * command.h (valid_cmd_char_p): Declare.
 592         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 593         the check of valid command char.
 594         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 595         valid_cmd_char_p.
 596         * cli/cli-script.c (validate_comname): Likewise.
 597         * completer.c (gdb_completer_command_word_break_characters):
 598         Do not remove . from the word break char, update comments.
 599         (complete_line_internal_1): Use valid_cmd_char_p.
 600         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 601         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 602
 603 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 604
 605         * cli/cli-script.c (do_define_command): Ensure a redefined
 606         prefix command is kept as a prefix command.
 607         (define_prefix_command): New function.
 608         (show_user_1): Report user defined prefixes.
 609         (_initialize_cli_script):  Create the new 'define-prefix' command.
 610         Add completers for 'define' and 'document'.
 611         * top.c (execute_command):  If command is a user-defined prefix only
 612         command, report the list of commands for this prefix command.
 613
 614 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 615
 616         * valops.c (find_oload_champ): Improve debug output.
 617
 618 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 619
 620         * valops.c (find_oload_champ): Print part of debug messages
 621         before the badness vector is std::move'd.
 622
 623 2019-11-28  Tom Tromey  <tom@tromey.com>
 624
 625         * value.c (creal_internal_fn): Fix comment.
 626
 627 2019-11-28  Tom Tromey  <tom@tromey.com>
 628
 629         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 630         flag_bound_evaluated>: Now unsigned.
 631
 632 2019-11-28  Tom Tromey  <tom@tromey.com>
 633
 634         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 635         declare.
 636
 637 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 638
 639         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 640         debug output.
 641         * jit.c (jit_unregister_code): Add debug print to match
 642         `jit_register_code`.
 643
 644 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 645
 646         * NEWS: Mention the new multithreaded symbol loading.
 647
 648 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 649
 650         * maint.c (n_worker_threads): Default to 0.
 651         (worker_threads_disabled): New function.
 652         * maint.h (worker_threads_disabled): New function.
 653         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
 654         here if worker_threads_disabled () is true.
 655         (minimal_symbol_reader::install): Skip all threading if
 656         worker_threads_disabled () is true.
 657
 658 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 659
 660         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
 661         hash code if possible.
 662         (add_minsym_to_demangled_hash_table): Likewise.
 663         (minimal_symbol_reader::install): Compute the hash codes for msymbol
 664         on the background thread.
 665         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
 666         Add these fields.
 667
 668 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 669
 670         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
 671         of the mangled name on the background thread.
 672         * symtab.c (symbol_set_names): Allow passing in the hash of the
 673         linkage_name.
 674         * symtab.h (symbol_set_names): Likewise.
 675
 676 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 677
 678         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
 679         physnames are computed for inherited DIEs.
 680
 681 2019-11-27  Tom Tromey  <tromey@adacore.com>
 682
 683         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 684         backslashes.
 685         * cp-support.c: Remove unnecessary backslashes.
 686
 687 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 688
 689         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 690         with sym->set_linkage_name.
 691         * coffread.c (coff_read_enum_type): Likewise.
 692         * mdebugread.c (parse_symbol): Likewise.
 693         * stabsread.c (patch_block_stabs): Likewise.
 694         (define_symbol): Likewise.
 695         (read_enum_type): Likewise.
 696         (common_block_end): Likewise.
 697         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 698         function.
 699         (SYMBOL_SET_LINKAGE_NAME): Remove.
 700         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 701         with sym->set_linkage_name.
 702
 703 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 704
 705         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 706         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 707         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 708         * NEWS: Mention new MI command.
 709
 710 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 711
 712         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
 713         '-symbol-info-types', and '-symbol-info-variables'.
 714         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
 715         (mi_cmd_symbol_info_types): Declare.
 716         (mi_cmd_symbol_info_variables): Declare.
 717         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
 718         (output_debug_symbol): New function.
 719         (output_nondebug_symbol): New function.
 720         (mi_symbol_info): New function.
 721         (mi_info_functions_or_variables): New function.
 722         (mi_cmd_symbol_info_functions): New function.
 723         (mi_cmd_symbol_info_types): New function.
 724         (mi_cmd_symbol_info_variables): New function.
 725         * NEWS: Mention new commands.
 726
 727 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 728
 729         * symtab.c (symbol_to_info_string): New function, most content
 730         moved from print_symbol_info, but updated to return a std::string.
 731         (print_symbol_info): Update to use symbol_to_info_string and print
 732         returned string.
 733         * symtab.h (symbol_to_info_string): Declare new function.
 734
 735 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 736
 737         * python/python.c (gdbpy_rbreak): Convert to using
 738         global_symbol_searcher.
 739         * symtab.c (file_matches): Convert return type to bool, change
 740         file list to std::vector, update header comment.
 741         (search_symbols): Rename to...
 742         (global_symbol_searcher::search): ...this and update now its
 743         a member function of global_symbol_searcher.  Take account of the
 744         changes to file_matches.
 745         (symtab_symbol_info): Convert to using global_symbol_searcher.
 746         (rbreak_command): Likewise.
 747         (search_module_symbols): Likewise.
 748         * symtab.h (enum symbol_search): Update comment.
 749         (search_symbols): Remove declaration.
 750         (class global_symbol_searcher): New class.
 751
 752 2019-11-26  Tom Tromey  <tromey@adacore.com>
 753
 754         * cp-support.c (_initialize_cp_support): Conditionally initialize
 755         gdb_demangle_attempt_core_dump.
 756
 757 2019-11-26  Tom Tromey  <tom@tromey.com>
 758
 759         * python/py-function.c (fnpy_init): Update.
 760         * value.h (add_internal_function): Adjust declaration.
 761         * value.c (function_destroyer): Remove.
 762         (do_add_internal_function): Don't set destroyer or copy name.
 763         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 764         Set name_allocated.
 765         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 766         (cmdpy_init): Set name_allocated.
 767         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 768         member.
 769         (~cmd_list_element): Free "name" if needed.
 770
 771 2019-11-26  Tom Tromey  <tom@tromey.com>
 772
 773         * value.h (add_internal_function): Add new overload.  Move
 774         documentation from value.h.
 775         * value.c (do_add_internal_function): New function.
 776         (add_internal_function): Use it.  Add new overload.
 777         (function_destroyer): Don't free doc.
 778         * python/py-function.c (fnpy_init): Update.
 779
 780 2019-11-26  Tom Tromey  <tom@tromey.com>
 781
 782         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 783         (cmdpy_init): Set "doc_allocated".
 784
 785 2019-11-26  Tom Tromey  <tom@tromey.com>
 786
 787         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 788         name of worker thread.
 789         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 790         pthread_setname_np.
 791         * configure, config.in: Rebuild.
 792
 793 2019-11-26  Tom Tromey  <tom@tromey.com>
 794
 795         * python/python.c (class gdbpy_gil): New.
 796         (struct gdbpy_event): Add constructor, destructor, operator().
 797         (gdbpy_post_event): Use run_on_main_thread.
 798         (gdbpy_initialize_events): Remove.
 799         (do_start_initialization): Update.
 800
 801 2019-11-26  Tom Tromey  <tom@tromey.com>
 802
 803         * NEWS: Add entry.
 804         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 805         commands.  Call update_thread_pool_size.
 806         (update_thread_pool_size, maintenance_set_worker_threads): New
 807         functions.
 808         (n_worker_threads): New global.
 809
 810 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 811             Tom Tromey  <tom@tromey.com>
 812
 813         * minsyms.c (minimal_symbol_reader::install): Use
 814         parallel_for_each.
 815         * gdbsupport/parallel-for.h: New file.
 816         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 817
 818 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 819             Tom Tromey  <tom@tromey.com>
 820
 821         * gdbsupport/thread-pool.h: New file.
 822         * gdbsupport/thread-pool.c: New file.
 823         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 824         (HFILES_NO_SRCDIR): Add thread-pool.h.
 825
 826 2019-11-26  Tom Tromey  <tom@tromey.com>
 827
 828         * event-top.h (thread_local_segv_handler): Declare.
 829         * event-top.c (thread_local_segv_handler): New global.
 830         (install_handle_sigsegv, handle_sigsegv): New functions.
 831         (async_init_signals): Install SIGSEGV handler.
 832         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 833         thread-local.
 834         (report_failed_demangle): New function.
 835         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 836         handler-setting code, instead use segv_handler.  Run warning code
 837         on main thread.
 838
 839 2019-11-26  Tom Tromey  <tom@tromey.com>
 840
 841         * run-on-main-thread.c: New file.
 842         * run-on-main-thread.h: New file.
 843         * unittests/main-thread-selftests.c: New file.
 844         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 845         main-thread-selftests.c.
 846         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 847         (COMMON_SFILES): Add run-on-main-thread.c.
 848
 849 2019-11-26  Tom Tromey  <tom@tromey.com>
 850
 851         * main.c (setup_alternate_signal_stack): Remove.
 852         (captured_main_1): Use gdb::alternate_signal_stack.
 853         * gdbsupport/alt-stack.h: New file.
 854
 855 2019-11-26  Tom Tromey  <tom@tromey.com>
 856
 857         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 858         Remove comment.
 859         (save_original_signals_state, restore_original_signals_state): Use
 860         gdb_sigmask.
 861         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 862         (_initialize_linux_nat): Use gdb_sigmask.
 863         * guile/guile.c (_initialize_guile): Use block_signals.
 864         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 865         * gdbsupport/gdb-sigmask.h: New file.
 866         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 867         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 868         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 869         pthread_sigmask.
 870         * configure, config.in: Rebuild.
 871         * gdbsupport/block-signals.h: New file.
 872
 873 2019-11-26  Tom Tromey  <tom@tromey.com>
 874
 875         * acinclude.m4: Include ax_pthread.m4.
 876         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 877         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 878         (CLIBS): Use PTHREAD_LIBS.
 879         (aclocal_m4_deps): Add ax_pthread.m4.
 880         * config.in, configure: Rebuild.
 881         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 882
 883 2019-11-26  Tom Tromey  <tom@tromey.com>
 884
 885         * symtab.h (struct minimal_symbol) <name_set>: New member.
 886         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 887         Don't call symbol_set_names.
 888         (minimal_symbol_reader::install): Call symbol_set_names.
 889
 890 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 891
 892         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 893         restore_active_ext_lang, as GIL is needed for (indirectly)
 894         called PyOS_InterruptOccurred.
 895
 896 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 897
 898         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 899         definition.
 900
 901 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 902
 903         * remote-sim.c (simulator_command): Make static, remove
 904         declaration.
 905
 906 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 907
 908         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 909         static.
 910         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 911         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 912         (main): Likewise.
 913         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 914         (main): Likewise.
 915         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 916         (main): Likewise.
 917         * unittests/basic_string_view/element_access/char/1.cc (test01):
 918         Likewise.
 919         (main): Likewise.
 920         * unittests/basic_string_view/element_access/char/empty.cc (main):
 921         Likewise.
 922         * unittests/basic_string_view/element_access/char/front_back.cc
 923         (test01): Likewise.
 924         (main): Likewise.
 925         * unittests/basic_string_view/inserters/char/2.cc (test05):
 926         Likewise.
 927         (main): Likewise.
 928         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 929         (test01): Likewise.
 930         (main): Likewise.
 931         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 932         (test01): Likewise.
 933         (main): Likewise.
 934         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 935         Likewise.
 936         * unittests/basic_string_view/operations/compare/char/1.cc
 937         (test01): Likewise.
 938         (main): Likewise.
 939         * unittests/basic_string_view/operations/compare/char/13650.cc
 940         (test01): Likewise.
 941         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 942         Likewise.
 943         (main): Likewise.
 944         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 945         Likewise.
 946         (main): Likewise.
 947         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 948         Likewise.
 949         (main): Likewise.
 950         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 951         Likewise.
 952         (main): Likewise.
 953         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 954         Likewise.
 955         (main): Likewise.
 956         * unittests/basic_string_view/operations/find/char/4.cc (main):
 957         Likewise.
 958         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 959         Likewise.
 960         (main): Likewise.
 961         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 962         Likewise.
 963         (main): Likewise.
 964         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 965         Likewise.
 966         (main): Likewise.
 967         * unittests/basic_string_view/operations/substr/char/1.cc
 968         (test01): Likewise.
 969         (main): Likewise.
 970         * unittests/basic_string_view/operators/char/2.cc (main):
 971         Likewise.
 972         * unittests/optional/assignment/1.cc (test): Likewise.
 973         * unittests/optional/assignment/2.cc (test): Likewise.
 974         * unittests/optional/assignment/3.cc (test): Likewise.
 975         * unittests/optional/assignment/4.cc (test): Likewise.
 976         * unittests/optional/assignment/5.cc (test): Likewise.
 977         * unittests/optional/assignment/6.cc (test): Likewise.
 978         * unittests/optional/assignment/7.cc (test): Likewise.
 979         * unittests/optional/cons/copy.cc (test): Likewise.
 980         * unittests/optional/cons/default.cc (test): Likewise.
 981         * unittests/optional/cons/move.cc (test): Likewise.
 982         * unittests/optional/cons/value.cc (test): Likewise.
 983         * unittests/optional/in_place.cc (test): Likewise.
 984         * unittests/optional/observers/1.cc (test): Likewise.
 985         * unittests/optional/observers/2.cc (test): Likewise.
 986
 987 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 988
 989         * tui-win.h (tui_set_var_cmd): Remove.
 990         * tui-win.c (tui_set_var_cmd): Make static.
 991
 992 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 993
 994         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 995         rbreak_command_wrapper): Remove.
 996         * symtab.c (rbreak_command_wrapper): Remove.
 997
 998 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 999
1000         * inferior.h (info_terminal_command): Remove declaration.
1001         * inflow.c (info_terminal_command): Make static.
1002
1003 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1004
1005         * inferior.c (exit_inferior_silent): Remove.
1006
1007 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1008
1009         * dictionary.c (dict_empty, mdict_empty): Remove.
1010         * dictionary.c (mdict_empty): Remove.
1011
1012 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1013
1014          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1015          (arc_insn_get_memory_offset): Likewise.
1016          (arc_insn_dump): Likewise.
1017          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1018          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1019          * dictionary.c (dict_iterator_next): Likewise.
1020          (dict_iter_match_first): Likewise.
1021          (dict_iter_match_next): Likewise.
1022          * f-lang.c (evaluate_subexp_f): Likewise.
1023          * hppa-tdep.c (hppa_read_pc): Likewise.
1024          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1025          * parse.c (write_exp_elt_msym): Likewise.
1026          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1027          * remote.c (remote_packet_size): Likewise.
1028          (remote_notif_stop_parse): Likewise.
1029          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1030          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1031          * source.c (prepare_path_for_appending): Likewise.
1032          * sparc64-linux-tdep.c
1033          (sparc64_linux_handle_segmentation_fault); Likewise.
1034          * stack.c (frame_selection_by_function_completer): Likewise.
1035
1036 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1037
1038         * completer.c (set_gdb_completion_word_break_characters):
1039         Remove.
1040
1041 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1042
1043         * dwarf-index-write.c: Include dwarf-index-write.h.
1044         * mi/mi-interp.c: Include mi/mi-interp.h.
1045
1046 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1047
1048         * aarch32-tdep.c: Include aarch32-tdep.h.
1049         * aarch32-tdep.h: Forward-declare struct target_desc.
1050
1051 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1052
1053         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1054         strerror.
1055         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1056         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1057
1058 2019-11-25  Tom de Vries  <tdevries@suse.de>
1059
1060         * contrib/words.sh: Add -c option.
1061
1062 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1063
1064         * solib.c (solib_find_1): Change int to bool.
1065         (exec_file_find): Change int to bool.
1066         (solib_find): Change int to bool.
1067         (solib_read_symbols): Change int to bool.
1068         (solib_used): Change int to bool.
1069         (solib_add): Change int to bool.
1070         (info_sharedlibrary_command): Change int to bool.
1071         (solib_contains_address_p): Change int to bool.
1072         (solib_keep_data_in_core): Change int to bool.
1073         (in_solib_dynsym_resolve_code): Change int to bool.
1074         (reload_shared_libraries_1): Change int to bool.
1075         (gdb_sysroot_changed): Change int to bool.
1076         * solib.h (solib_read_symbols): Change int to bool.
1077         (solib_contains_address_p): Change int to bool.
1078         (solib_keep_data_in_core): Change int to bool.
1079         (in_solib_dynsym_resolve_code): Change int to bool.
1080         (libpthread_name_p): Change int to bool.
1081
1082 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1083
1084         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1085         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1086         (remote_packet_max_chars): New static global.
1087         (show_remote_packet_max_chars): New function.
1088         (remote_target::putpkt_binary): Adjust to use new
1089         remote_packet_max_chars option.
1090         (remote_target::getpkt_or_notif_sane_1): Likewise.
1091         (_initialize_remote): Register new remote-packet-max-chars option.
1092
1093 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1094
1095         * m68k-linux-nat.c: Include gdbarch.h.
1096
1097 2019-11-24  Tom Tromey  <tom@tromey.com>
1098
1099         * symfile.c (read_symbols): Update.
1100         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1101         bool.
1102         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1103         (psym_lookup_symbol, psym_find_last_source_symtab)
1104         (psym_forget_cached_source_info, psym_print_stats)
1105         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1106         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1107         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1108         (psym_find_compunit_symtab_by_address)
1109         (maintenance_print_psymbols, maintenance_info_psymtabs)
1110         (maintenance_check_psymtabs): Update.
1111         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1112         bool.
1113
1114 2019-11-22  Tom Tromey  <tom@tromey.com>
1115
1116         * observable.h: Update comments.
1117
1118 2019-11-22  Tom Tromey  <tromey@adacore.com>
1119
1120         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1121         (print_ada_task_info): Don't try to fetch thread id if task is not
1122         alive.
1123
1124 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1125
1126         * ada-exp.y: Update.
1127         * ada-lang.c (sort_choices): Update.
1128         (ada_print_symbol_signature): Update.
1129         (resolve_subexp): Update.
1130         (ada_parse_renaming): Update.
1131         (ada_read_renaming_var_value): Update.
1132         (lesseq_defined_than): Update.
1133         (remove_extra_symbols): Update.
1134         (remove_irrelevant_renamings): Update.
1135         (ada_add_block_symbols): Update.
1136         (ada_collect_symbol_completion_matches): Update.
1137         (ada_is_renaming_symbol): Update.
1138         (aggregate_assign_from_choices): Update.
1139         (ada_evaluate_subexp): Update.
1140         (ada_has_this_exception_support): Update.
1141         (ada_is_non_standard_exception_sym): Update.
1142         (ada_add_exceptions_from_frame): Update.
1143         (ada_add_global_exceptions): Update.
1144         (ada_print_subexp): Update.
1145         * ax-gdb.c (gen_var_ref): Update.
1146         (gen_maybe_namespace_elt): Update.
1147         (gen_expr_for_cast): Update.
1148         (gen_expr): Update.
1149         * block.h: Update.
1150         * blockframe.c (find_pc_partial_function): Update.
1151         * breakpoint.c (print_breakpoint_location): Update.
1152         (update_static_tracepoint): Update.
1153         * btrace.c (ftrace_print_function_name): Update.
1154         (ftrace_function_switched): Update.
1155         * buildsym.c (find_symbol_in_list): Update.
1156         * c-exp.y: Update.
1157         * c-typeprint.c (c_print_typedef): Update.
1158         (c_type_print_template_args): Update.
1159         * cli/cli-cmds.c (edit_command): Update.
1160         (list_command): Update.
1161         (print_sal_location): Update.
1162         * coffread.c (patch_opaque_types): Update.
1163         (process_coff_symbol): Update.
1164         (coff_read_enum_type): Update.
1165         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1166         (convert_one_symbol): Update.
1167         (hash_symname): Update.
1168         (eq_symname): Update.
1169         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1170         * compile/compile-cplus-types.c (debug_print_scope): Update.
1171         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1172         * compile/compile-object-load.c (get_out_value_type): Update.
1173         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1174         (search_symbol_list): Update.
1175         (cp_lookup_symbol_imports_or_template): Update.
1176         * cp-support.c (overload_list_add_symbol): Update.
1177         * ctfread.c (psymtab_to_symtab): Update.
1178         * dbxread.c (cp_set_block_scope): Update.
1179         * dictionary.c (iter_match_first_hashed): Update.
1180         (iter_match_next_hashed): Update.
1181         (insert_symbol_hashed): Update.
1182         (iter_match_next_linear): Update.
1183         * dictionary.h: Update.
1184         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1185         (locexpr_describe_location_piece): Update.
1186         (locexpr_describe_location_1): Update.
1187         (locexpr_generate_c_location): Update.
1188         (loclist_describe_location): Update.
1189         (loclist_generate_c_location): Update.
1190         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1191         (read_func_scope): Update.
1192         (process_enumeration_scope): Update.
1193         (new_symbol): Update.
1194         (dwarf2_const_value): Update.
1195         (dwarf2_symbol_mark_computed): Update.
1196         * eval.c (evaluate_funcall): Update.
1197         (evaluate_subexp_standard): Update.
1198         * expprint.c (print_subexp_standard): Update.
1199         (dump_subexp_body_standard): Update.
1200         * f-valprint.c (info_common_command_for_block): Update.
1201         * findvar.c (get_hosting_frame): Update.
1202         (default_read_var_value): Update.
1203         * go-lang.c (go_symbol_package_name): Update.
1204         * guile/scm-block.c (bkscm_print_block_smob): Update.
1205         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1206         (gdbscm_symbol_name): Update.
1207         (gdbscm_symbol_linkage_name): Update.
1208         (gdbscm_symbol_print_name): Update.
1209         * infcall.c (get_function_name): Update.
1210         * infcmd.c (jump_command): Update.
1211         (finish_command): Update.
1212         * infrun.c (insert_exception_resume_breakpoint): Update.
1213         * linespec.c (canonicalize_linespec): Update.
1214         (create_sals_line_offset): Update.
1215         (convert_linespec_to_sals): Update.
1216         (complete_label): Update.
1217         (find_label_symbols_in_block): Update.
1218         * m2-typeprint.c (m2_print_typedef): Update.
1219         * mdebugread.c (mdebug_reg_to_regnum): Update.
1220         (parse_symbol): Update.
1221         (mylookup_symbol): Update.
1222         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1223         (list_args_or_locals): Update.
1224         * objc-lang.c (compare_selectors): Update.
1225         (info_selectors_command): Update.
1226         (compare_classes): Update.
1227         (info_classes_command): Update.
1228         (find_imps): Update.
1229         * p-typeprint.c (pascal_print_typedef): Update.
1230         * printcmd.c (build_address_symbolic): Update.
1231         (info_address_command): Update.
1232         (print_variable_and_value): Update.
1233         * python/py-framefilter.c (extract_sym): Update.
1234         (py_print_single_arg): Update.
1235         * python/py-symbol.c (sympy_str): Update.
1236         (sympy_get_name): Update.
1237         (sympy_get_linkage_name): Update.
1238         * python/python.c (gdbpy_rbreak): Update.
1239         * record-btrace.c (btrace_get_bfun_name): Update.
1240         (btrace_call_history): Update.
1241         * rust-lang.c (rust_print_typedef): Update.
1242         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1243         * stabsread.c (stab_reg_to_regnum): Update.
1244         (define_symbol): Update.
1245         (read_enum_type): Update.
1246         (common_block_end): Update.
1247         (cleanup_undefined_types_1): Update.
1248         (scan_file_globals): Update.
1249         * stack.c (print_frame_arg): Update.
1250         (print_frame_args): Update.
1251         (find_frame_funname): Update.
1252         (info_frame_command_core): Update.
1253         (iterate_over_block_locals): Update.
1254         (print_block_frame_labels): Update.
1255         (do_print_variable_and_value): Update.
1256         (iterate_over_block_arg_vars): Update.
1257         (return_command): Update.
1258         * symmisc.c (dump_symtab_1): Update.
1259         (print_symbol): Update.
1260         * symtab.c (eq_symbol_entry): Update.
1261         (symbol_cache_dump): Update.
1262         (lookup_language_this): Update.
1263         (find_pc_sect_line): Update.
1264         (skip_prologue_sal): Update.
1265         (symbol_search::compare_search_syms): Update.
1266         (treg_matches_sym_type_name): Update.
1267         (search_symbols): Update.
1268         (print_symbol_info): Update.
1269         (rbreak_command): Update.
1270         (completion_list_add_symbol): Update.
1271         (find_gnu_ifunc): Update.
1272         (get_symbol_address): Update.
1273         (search_module_symbols): Update.
1274         (info_module_subcommand): Update.
1275         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1276         (SYMBOL_LINKAGE_NAME): Remove.
1277         (SYMBOL_DEMANGLED_NAME): Remove.
1278         (SYMBOL_PRINT_NAME): Remove.
1279         (SYMBOL_SEARCH_NAME): Remove.
1280         * tracepoint.c (set_traceframe_context): Update.
1281         (validate_actionline): Update.
1282         (collection_list::collect_symbol): Update.
1283         (encode_actions_1): Update.
1284         (info_scope_command): Update.
1285         (print_one_static_tracepoint_marker): Update.
1286         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1287         * valops.c (address_of_variable): Update.
1288         (find_overload_match): Update.
1289         (find_oload_champ): Update.
1290
1291 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1292
1293         * ada-lang.c (ada_lookup_simple_minsym): Update.
1294         (ada_collect_symbol_completion_matches): Update.
1295         * ada-tasks.c (read_atcb): Update.
1296         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1297         (amd64_windows_skip_trampoline_code): Update.
1298         * arm-tdep.c (skip_prologue_function): Update.
1299         (arm_skip_stack_protector): Update.
1300         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1301         (arm_wince_skip_main_prologue): Update.
1302         * ax-gdb.c (gen_expr): Update.
1303         * block.c (call_site_for_pc): Update.
1304         * blockframe.c (find_pc_partial_function): Update.
1305         * breakpoint.c (set_breakpoint_location_function): Update.
1306         * btrace.c (ftrace_print_function_name): Update.
1307         (ftrace_function_switched): Update.
1308         * c-valprint.c (print_unpacked_pointer): Update.
1309         * coffread.c (coff_symfile_read): Update.
1310         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1311         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1312         * dwarf-index-write.c (write_psymbols): Update.
1313         * dwarf2loc.c (call_site_to_target_addr): Update.
1314         (func_verify_no_selftailcall): Update.
1315         (tailcall_dump): Update.
1316         (call_site_find_chain_1): Update.
1317         (dwarf_expr_reg_to_entry_parameter): Update.
1318         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1319         * eval.c (evaluate_funcall): Update.
1320         (evaluate_subexp_standard): Update.
1321         (evaluate_subexp_for_sizeof): Update.
1322         * expprint.c (print_subexp_standard): Update.
1323         (dump_subexp_body_standard): Update.
1324         * frame.c (get_prev_frame_always_1): Update.
1325         * frv-tdep.c (frv_skip_main_prologue): Update.
1326         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1327         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1328         (gnuv3_get_typename_from_type_info): Update.
1329         (gnuv3_skip_trampoline): Update.
1330         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1331         * i386-tdep.c (i386_skip_main_prologue): Update.
1332         (i386_pe_skip_trampoline_code): Update.
1333         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1334         * infcall.c (get_function_name): Update.
1335         * linespec.c (minsym_found): Update.
1336         * linux-fork.c (info_checkpoints_command): Update.
1337         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1338         (m32c_m16c_pointer_to_address): Update.
1339         * maint.c (maintenance_translate_address): Update.
1340         * minsyms.c (add_minsym_to_hash_table): Update.
1341         (add_minsym_to_demangled_hash_table): Update.
1342         (lookup_minimal_symbol_mangled): Update.
1343         (lookup_minimal_symbol_demangled): Update.
1344         (lookup_minimal_symbol_linkage): Update.
1345         (lookup_minimal_symbol_text): Update.
1346         (lookup_minimal_symbol_by_pc_name): Update.
1347         (minimal_symbol_is_less_than): Update.
1348         (compact_minimal_symbols): Update.
1349         (build_minimal_symbol_hash_tables): Update.
1350         (find_solib_trampoline_target): Update.
1351         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1352         (mips_skip_pic_trampoline_code): Update.
1353         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1354         * objc-lang.c (info_selectors_command): Update.
1355         (info_classes_command): Update.
1356         (find_methods): Update.
1357         (find_imps): Update.
1358         * p-valprint.c (pascal_val_print): Update.
1359         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1360         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1361         * printcmd.c (build_address_symbolic): Update.
1362         (info_symbol_command): Update.
1363         * psymtab.c (psymbol_name_matches): Update.
1364         (match_partial_symbol): Update.
1365         (lookup_partial_symbol): Update.
1366         (print_partial_symbols): Update.
1367         (sort_pst_symbols): Update.
1368         (maintenance_check_psymtabs): Update.
1369         * python/py-framefilter.c (py_print_frame): Update.
1370         * python/python.c (gdbpy_rbreak): Update.
1371         * record-btrace.c (btrace_get_bfun_name): Update.
1372         (btrace_call_history): Update.
1373         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1374         (rs6000_skip_trampoline_code): Update.
1375         * sol-thread.c (info_cb): Update.
1376         * stabsread.c (scan_file_globals): Update.
1377         * stack.c (find_frame_funname): Update.
1378         (info_frame_command_core): Update.
1379         * symmisc.c (dump_msymbols): Update.
1380         * symtab.c (symbol_natural_name): Rename to..,
1381         (general_symbol_info::natural_name): ...this.
1382         (symbol_demangled_name): Rename to...
1383         (general_symbol_info::demangled_name): ...this.
1384         (symbol_search_name): Rename to...
1385         (general_symbol_info::search_name): ...this.
1386         (symbol_matches_search_name): Update.
1387         (find_pc_sect_line): Update.
1388         (skip_prologue_sal): Update.
1389         (search_symbols): Update.
1390         (print_msymbol_info): Update.
1391         (rbreak_command): Update.
1392         (completion_list_add_msymbol): Update.
1393         (completion_list_objc_symbol): Update.
1394         (get_msymbol_address): Update.
1395         * symtab.h (struct general_symbol_info): Add member functions
1396         natural_name (), linkage_name (), print_name (), demangled_name (),
1397         and search_name ().
1398         (SYMBOL_NATURAL_NAME): Update.
1399         (symbol_natural_name): Move to a member function on general_symbol_info.
1400         (SYMBOL_DEMANGLED_NAME): Update.
1401         (symbol_demangled_name): Move to a member function on
1402         general_symbol_info.
1403         (SYMBOL_SEARCH_NAME): Update.
1404         (symbol_search_name): Move to a member function on general_symbol_info.
1405         (MSYMBOL_NATURAL_NAME): Remove.
1406         (MSYMBOL_LINKAGE_NAME): Remove.
1407         (MSYMBOL_PRINT_NAME): Remove.
1408         (MSYMBOL_DEMANGLED_NAME): Remove.
1409         (MSYMBOL_SEARCH_NAME): Remove.
1410         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1411
1412 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1413
1414         * symtab.c (create_demangled_names_hash): Use per_bfd->
1415         minimal_symbol_count for computing the initial size, if greater
1416         than our default size.
1417
1418 2019-11-22  Tom de Vries  <tdevries@suse.de>
1419
1420         * contrib/words.sh: Improve words extraction.
1421
1422 2019-11-22  Tom de Vries  <tdevries@suse.de>
1423
1424         * contrib/words.sh: Combine sed invocations.
1425
1426 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1427
1428         * Makefile.in: Update.
1429         * demangle.c: Rename to...
1430         * gdb-demangle.c: ..this.
1431         (is_cplus_marker): Change return type to bool.
1432         (_initialize_demangler): Rename to...
1433         (_initialize_gdb_demangle): ...this.
1434         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1435         * symtab.h (demangle): Remove declaration; instead include
1436         gdb-demangle.h.
1437
1438 2019-11-21  Tom Tromey  <tromey@adacore.com>
1439
1440         * gdbsupport/format.c (format_pieces): Parse %I64d.
1441         * unittests/format_pieces-selftests.c (test_windows_formats): New
1442         function.
1443         (run_tests): Call it.
1444
1445 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1446
1447         Byte reverse display of variables with DW_END_big, DW_END_little
1448         (DW_AT_endianity) dwarf attributes if different than the native
1449         byte order.
1450         * ada-lang.c (ada_value_binop):
1451         Use type_byte_order instead of gdbarch_byte_order.
1452         * ada-valprint.c (printstr):
1453         (ada_val_print_string):
1454         * ada-lang.c (value_pointer):
1455         (ada_value_binop):
1456         Use type_byte_order instead of gdbarch_byte_order.
1457         * c-lang.c (c_get_string):
1458         Use type_byte_order instead of gdbarch_byte_order.
1459         * c-valprint.c (c_val_print_array):
1460         Use type_byte_order instead of gdbarch_byte_order.
1461         * cp-valprint.c (cp_print_class_member):
1462         Use type_byte_order instead of gdbarch_byte_order.
1463         * dwarf2loc.c (rw_pieced_value):
1464         Use type_byte_order instead of gdbarch_byte_order.
1465         * dwarf2read.c (read_base_type): Handle DW_END_big,
1466         DW_END_little
1467         * f-lang.c (f_get_encoding):
1468         Use type_byte_order instead of gdbarch_byte_order.
1469         * findvar.c (default_read_var_value):
1470         Use type_byte_order instead of gdbarch_byte_order.
1471         * gdbtypes.c (check_types_equal):
1472         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1473         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1474         and TYPE_ENDIANITY_LITTLE if set.
1475         (type_byte_order): new function.
1476         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1477         (struct main_type) <flag_endianity_not_default>:
1478         New field.
1479         (type_byte_order): New function.
1480         * infcmd.c (default_print_one_register_info):
1481         Use type_byte_order instead of gdbarch_byte_order.
1482         * p-lang.c (pascal_printstr):
1483         Use type_byte_order instead of gdbarch_byte_order.
1484         * p-valprint.c (pascal_val_print):
1485         Use type_byte_order instead of gdbarch_byte_order.
1486         * printcmd.c (print_scalar_formatted):
1487         Use type_byte_order instead of gdbarch_byte_order.
1488         * solib-darwin.c (darwin_current_sos):
1489         Use type_byte_order instead of gdbarch_byte_order.
1490         * solib-svr4.c (solib_svr4_r_ldsomap):
1491         Use type_byte_order instead of gdbarch_byte_order.
1492         * stap-probe.c (stap_modify_semaphore):
1493         Use type_byte_order instead of gdbarch_byte_order.
1494         * target-float.c (target_float_same_format_p):
1495         Use type_byte_order instead of gdbarch_byte_order.
1496         * valarith.c (scalar_binop):
1497         (value_bit_index):
1498         Use type_byte_order instead of gdbarch_byte_order.
1499         * valops.c (value_cast):
1500         Use type_byte_order instead of gdbarch_byte_order.
1501         * valprint.c (generic_emit_char):
1502         (generic_printstr):
1503         (val_print_string):
1504         Use type_byte_order instead of gdbarch_byte_order.
1505         * value.c (unpack_long):
1506         (unpack_bits_as_long):
1507         (unpack_value_bitfield):
1508         (modify_field):
1509         (pack_long):
1510         (pack_unsigned_long):
1511         Use type_byte_order instead of gdbarch_byte_order.
1512         * findvar.c (unsigned_pointer_to_address):
1513         (signed_pointer_to_address):
1514         (unsigned_address_to_pointer):
1515         (address_to_signed_pointer):
1516         (default_read_var_value):
1517         (default_value_from_register):
1518         Use type_byte_order instead of gdbarch_byte_order.
1519         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1520         Use type_byte_order instead of gdbarch_byte_order.
1521         * riscv-tdep.c (riscv_print_one_register_info):
1522         Use type_byte_order instead of gdbarch_byte_order.
1523
1524 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1525
1526         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1527         (current_ui_gdb_stdin_ptr): Likewise.
1528         (current_ui_gdb_stderr_ptr): Likewise.
1529         (current_ui_gdb_stdlog_ptr): Likewise.
1530         (current_ui_current_uiout_ptr): Likewise.
1531         (gen_ret_current_ui_field_ptr): Remove.
1532
1533 2019-11-21  Tom de Vries  <tdevries@suse.de>
1534
1535         PR gdb/24956
1536         * cli/cli-script.c (execute_control_command): Only switch to
1537         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1538
1539 2019-11-19  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1542         Now static.  Change type of "name".
1543         (tui_set_win_height_command): Don't copy "arg".
1544         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1545         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1546
1547 2019-11-19  Ali Tamur <tamur@google.com>
1548
1549         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1550         "if (attr != nullptr)".
1551         (dwarf2_find_base_address): Likewise.
1552         (dwarf2_build_include_psymtabs): Likewise.
1553         (read_cutu_die_from_dwo): Likewise.
1554         (read_func_scope): Likewise.
1555         (read_call_site_scope): Likewise.
1556         (dwarf2_get_pc_bounds): Likewise.
1557         (dwarf2_record_block_ranges): Likewise.
1558         (dwarf2_add_field): Likewise.
1559         (dwarf2_add_member_fn): Likewise.
1560         (read_structure_type): Likewise.
1561         (read_enumeration_type): Likewise.
1562         (read_array_type): Likewise.
1563         (read_array_order): Likewise.
1564         (read_set_type): Likewise.
1565         (read_common_block): Likewise.
1566         (read_tag_reference_type): Likewise.
1567         (read_tag_string_type): Likewise.
1568         (read_subroutine_type): Likewise.
1569         (read_base_type): Likewise.
1570         (read_subrange_type): Likewise.
1571         (new_symbol): Likewise.
1572         (prepare_one_comp_unit): Likewise.
1573
1574 2019-11-19  Tom Tromey  <tromey@adacore.com>
1575
1576         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1577         result in error when DebugActiveProcess fails.
1578
1579 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1580             Pedro Alves  <palves@redhat.com>
1581
1582         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1583         * target.c (target_stack::push): Call 'unpush' if there's a
1584         target on top of the stack.
1585
1586 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1587
1588         * python/py-block.c (blpy_dealloc): Call tp_free.
1589         (blpy_block_syms_dealloc): Likewise.
1590         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1591         * python/py-inferior.c (infpy_dealloc): Likewise.
1592         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1593         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1594         * python/py-symbol.c (sympy_dealloc): Likewise.
1595         * python/py-symtab.c (stpy_dealloc): Likewise.
1596         * python/py-type.c (typy_iterator_dealloc): Likewise.
1597
1598 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1599
1600         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1601         constructor instead of using a class initializer.
1602
1603 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1604
1605         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1606         * configure: Regenerate.
1607         * configure.ac: Don't source common.host.
1608         * gdbsupport/common.host: Remove.
1609         * gdbsupport/mingw-strerror.c: Remove.
1610         * gdbsupport/posix-strerror.c: Rename to...
1611         * gdbsupport/safe-strerror.c: ...this.
1612
1613 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1614
1615         * maint.c (scoped_command_stats::print_time): Use localtime_r
1616         instead of localtime (provided through gnulib if necessary).
1617         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1618         of ctime.
1619
1620 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1621
1622         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1623         avoid compile errors.
1624
1625 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1626
1627         * config.in: Regenerate.
1628         * configure: Regenerate.
1629         * gdbsupport/common.m4: No longer check for strerror_r.
1630         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1631         POSIX version of strerror_r, now that gnulib provides it if
1632         necessary.
1633
1634 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1635
1636         * README (`configure' options): Update.
1637
1638 2019-11-14  Tom Tromey  <tromey@adacore.com>
1639
1640         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1641         expected type for the RHS if the LHS is a convenience variable.
1642
1643 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1644
1645         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1646         Provide explicit default and copy constructor.
1647
1648 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1649
1650         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1651         only call Py_INCREF (newbp) in the bppy_pending_object case.
1652
1653 2019-11-13  Tom Tromey  <tromey@adacore.com>
1654
1655         PR build/25182:
1656         * psympriv.h (partial_symbol): Remove static assert.
1657         * symtab.h (general_symbol_info, symbol): Remove static assert.
1658
1659 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1660
1661         * gdbsupport/format.c (format_pieces::format_pieces): Support
1662         printf 'z' size modifier.
1663         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1664         * printcmd.c (ui_printf):  Handle size_t_arg.
1665         * ui-out.c (ui_out::vmessage): Likewise.
1666         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1667         function.
1668         (run_tests): Call test_format_int_sizes.
1669
1670 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1671
1672         * ada-exp.y (write_ambiguous_var): Update.
1673         * buildsym.c (add_symbol_to_list): Update.
1674         * dwarf2read.c (read_variable): Update.
1675         (new_symbol): Update.
1676         * jit.c (finalize_symtab): Update.
1677         * language.c (language_alloc_type_symbol): Update.
1678         * symtab.c (fixup_symbol_section): Update.
1679         (initialize_objfile_symbol_1): Move code to...
1680         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1681         (allocate_symbol): Update.
1682         (allocate_template_symbol): Update.
1683         (get_symbol_address): Update.
1684         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1685         of having as a field, and add a constructor.
1686         (SYMBOL_VALUE): Update.
1687         (SYMBOL_VALUE_ADDRESS): Update.
1688         (SET_SYMBOL_VALUE_ADDRESS): Update.
1689         (SYMBOL_VALUE_BYTES): Update.
1690         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1691         (SYMBOL_BLOCK_VALUE): Update.
1692         (SYMBOL_VALUE_CHAIN): Update.
1693         (SYMBOL_LANGUAGE): Update.
1694         (SYMBOL_SECTION): Update.
1695         (SYMBOL_OBJ_SECTION): Update.
1696         (SYMBOL_SET_LANGUAGE): Update.
1697         (SYMBOL_SET_LINKAGE_NAME): Update.
1698         (SYMBOL_SET_NAMES): Update.
1699         (SYMBOL_NATURAL_NAME): Update.
1700         (SYMBOL_LINKAGE_NAME): Update.
1701         (SYMBOL_DEMANGLED_NAME): Update.
1702         (SYMBOL_SEARCH_NAME): Update.
1703         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1704         (struct symbol): Update.
1705         (struct template_symbol): Update.
1706         (struct rust_vtable_symbol): Update.
1707         * xcoffread.c (SYMBOL_DUP): Update.
1708
1709 2019-11-12  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-layout.c (show_layout): Set current_layout.
1712         (show_source_disasm_command, show_data)
1713         (show_source_or_disasm_and_command): Don't set current_layout.
1714
1715 2019-11-12  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1718
1719 2019-11-12  Tom Tromey  <tom@tromey.com>
1720
1721         * tui/tui-win.c (resize_message): New global.
1722         (show_tui_resize_message): New function.
1723         (tui_async_resize_screen): Print message if requested.
1724         (_initialize_tui_win): Add tui-resize-message setting.
1725         * NEWS: Add entry for new commands.
1726
1727 2019-11-11  Tom Tromey  <tom@tromey.com>
1728
1729         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1730         functions.
1731
1732 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1733
1734         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1735
1736 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1737
1738         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1739         function.
1740         * python/python-internal.h (gdbpy_lookup_static_symbols):
1741         Declare new function.
1742         * python/python.c (python_GdbMethods): Add
1743         gdb.lookup_static_symbols method.
1744         * NEWS: Mention gdb.lookup_static_symbols.
1745
1746 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1747
1748         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1749         static block of current object file first.  Also fix typo in
1750         header comment.
1751
1752 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1753
1754         * stack.c (set_last_displayed_sal): Delete.
1755         (last_displayed_sal_valid): Delete.
1756         (last_displayed_pspace): Delete.
1757         (last_displayed_addr): Delete.
1758         (last_displayed_symtab): Delete.
1759         (last_displayed_line): Delete.
1760         (class last_displayed_symtab_info_type): New.
1761         (last_displayed_symtab_info): New static global variable.
1762         (print_frame_info): Call methods on last_displayed_symtab_info.
1763         (clear_last_displayed_sal): Update header comment, and make use of
1764         last_displayed_symtab_info.
1765         (last_displayed_sal_is_valid): Likewise.
1766         (get_last_displayed_pspace): Likewise.
1767         (get_last_displayed_addr): Likewise.
1768         (get_last_displayed_symtab): Likewise.
1769         (get_last_displayed_line): Likewise.
1770         (get_last_displayed_sal): Likewise.
1771         * stack.h (clear_last_displayed_sal): Update header comment.
1772         (last_displayed_sal_is_valid): Likewise.
1773         (get_last_displayed_pspace): Likewise.
1774         (get_last_displayed_addr): Likewise.
1775         (get_last_displayed_symtab): Likewise.
1776         (get_last_displayed_line): Likewise.
1777         (get_last_displayed_sal): Likewise.
1778
1779 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1780
1781         * stack.c (frame_show_address): Convert return type to bool.
1782         * stack.h (frame_show_address): Likewise, and update header
1783         comment.
1784
1785 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1786
1787         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1788         * unittests/vec-utils-selftests.c: New file.
1789         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1790
1791 2019-11-10  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1794         (tui_highlight_win): Likewise.
1795         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1796         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1797         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1798         Don't set can_highlight.
1799
1800 2019-11-10  Tom Tromey  <tom@tromey.com>
1801
1802         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1803         Remove unused declaration.
1804
1805 2019-11-08  Tom Tromey  <tromey@adacore.com>
1806
1807         * top.c (read_command_file): Update.
1808         (command_line_input): Make return type const.
1809         * python/py-gdb-readline.c: Update.
1810         * linespec.c (decode_line_2): Update.
1811         * defs.h (command_line_input): Make return type const.
1812         * cli/cli-script.c (read_next_line): Make return type const.
1813         * ada-lang.c (get_selections): Update.
1814
1815 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1816
1817         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1818         * mi/mi-main.c (output_cores): Likewise.
1819         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1820         (linux_xfer_osdata_modules): Likewise.
1821         * remote.c (register_remote_support_xml): Likewise.
1822         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1823         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1824
1825 2019-11-06  Tom Tromey  <tom@tromey.com>
1826
1827         * tui/tui-interp.c: Don't include readline.h.
1828         * tui/tui-hooks.c: Don't include readline.h.
1829         * symmisc.c: Include tilde.h, not readline.h.
1830         * symfile.c: Include tilde.h, not readline.h.
1831         * source.c: Include tilde.h, not readline.h.
1832         * solib.c: Include tilde.h, not readline.h.
1833         * psymtab.c: Include tilde.h, not readline.h.
1834         * exec.c: Include tilde.h, not readline.h.
1835         * corelow.c: Include tilde.h, not readline.h.
1836         * cli/cli-dump.c: Include tilde.h, not readline.h.
1837         * cli/cli-cmds.c: Don't include readline.h.
1838
1839 2019-11-05  Tom Tromey  <tom@tromey.com>
1840
1841         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1842         (tui_disassemble): Set addr_size.
1843         (tui_disasm_window::set_contents): Use addr_size.
1844
1845 2019-11-05  Tom Tromey  <tom@tromey.com>
1846
1847         * rust-lang.c (rust_language_defn): Update.
1848         * python/py-value.c (valpy_string): Call c_get_string.
1849         * p-lang.c (pascal_language_defn): Update.
1850         * opencl-lang.c (opencl_language_defn): Update.
1851         * objc-lang.c (objc_language_defn): Update.
1852         * m2-lang.c (m2_language_defn): Update.
1853         * language.c (unknown_language_defn, auto_language_defn): Update.
1854         (default_get_string): Remove.
1855         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1856         * go-lang.c (go_language_defn): Update.
1857         * f-lang.c (f_language_defn): Update.
1858         * d-lang.c (d_language_defn): Update.
1859         * c-lang.c (c_language_defn, cplus_language_defn)
1860         (asm_language_defn, minimal_language_defn): Update.
1861         * ada-lang.c (ada_language_defn): Update.
1862         * language.h (struct language_defn) <la_get_string>: Remove.
1863         (LA_GET_STRING): Remove.
1864         (default_get_string): Don't declare.
1865
1866 2019-11-05  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-source.h (struct tui_source_window): Inline
1869         constructor.  Remove destructor.
1870         <style_changed, m_observable>: Move to superclass.
1871         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1872         (struct tui_source_window_base): Move private members to end.
1873         <style_changed, m_observable>: Move from tui_source_window.
1874         * tui/tui-winsource.c (tui_copy_source_line): Move from
1875         tui-source.c.  Rename from copy_source_line.  Add special handling
1876         for negative line number.
1877         (tui_source_window_base::style_changed): Move from
1878         tui_source_window.
1879         (tui_source_window_base): Register observer.
1880         (~tui_source_window_base): New.
1881         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1882         rename.
1883         (tui_source_window::set_contents): Use tui_copy_source_line.
1884         (tui_source_window::tui_source_window): Move to tui-source.h.
1885         (tui_source_window::~tui_source_window): Remove.
1886         (tui_source_window::style_changed): Move to superclass.
1887         * tui/tui-disasm.c (tui_disassemble): Create string file with
1888         styling, when possible.  Add "addr_size" parameter.
1889         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1890         Don't compute maximum size.
1891         (len_without_escapes): New function
1892
1893 2019-11-05  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1896         std::string.
1897         * tui/tui-winsource.c (tui_show_source_line): Update.
1898         * tui/tui-source.c (tui_source_window::set_contents): Update.
1899         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1900
1901 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1902
1903         * symtab.h (gdb_static_assert): Put && operator at the beginning
1904         of the line instead of the end.
1905
1906 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1907
1908         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1909         and sizeof (symbol).
1910         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1911
1912 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1913
1914         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1915         * configure.host: Mark *-*-solaris2.10* obsolete.
1916         * configure.tgt: Mark Solaris < 11 obsolete.
1917         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1918         Update target triplet.
1919
1920 2019-11-01  Tom Tromey  <tromey@adacore.com>
1921
1922         * utils.c (print_sys_errmsg): Simplify.
1923
1924 2019-11-01  Tom Tromey  <tromey@adacore.com>
1925
1926         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1927
1928 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1929
1930         * configure: Regenerate.
1931         * configure.ac: Remove check for strerror_r.
1932         * gdbsupport/common.m4: Check for strerror_r.
1933
1934 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1935
1936         PR gdb/25124
1937
1938         * arm-tdep.c (arm_per_objfile): Rename to ...
1939         (arm_per_bfd): ... this.
1940         (arm_objfile_data_key): Rename to ...
1941         (arm_bfd_data_key): ... this.
1942         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1943         data.
1944         (arm_record_special_symbol): Likewise.
1945
1946 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1947
1948         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1949         end.
1950         * c-typeprint.c (c_print_typedef): Likewise.
1951         * f-typeprint.c (f_print_typedef): Likewise.
1952         * m2-typeprint.c (m2_print_typedef): Likewise.
1953         * p-typeprint.c (pascal_print_typedef): Likewise.
1954         * rust-lang.c (rust_print_typedef): Likewise.
1955         * symtab.c (print_symbol_info): Print a newline after calling
1956         typedef_print.
1957
1958 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1959
1960         * symtab.c (info_module_cmdlist): New variable.
1961         (info_module_command): New function.
1962         (search_module_symbols): New function.
1963         (info_module_subcommand): New function.
1964         (struct info_modules_var_func_options): New struct.
1965         (info_modules_var_func_options_defs): New variable.
1966         (make_info_modules_var_func_options_def_group): New function.
1967         (info_module_functions_command): New function.
1968         (info_module_variables_command): New function.
1969         (info_module_var_func_command_completer): New function.
1970         (_initialize_symtab): Register new 'info module functions' and
1971         'info module variables' commands.
1972         * symtab.h (typedef symbol_search_in_module): New typedef.
1973         (search_module_symbols): Declare new function.
1974         * NEWS: Mention new commands.
1975
1976 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1977
1978         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1979         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1980         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1981         MODULES_DOMAIN.
1982         (scan_partial_symbols): Only create partial module symbols for non
1983         declarations.
1984         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1985         and MODULES_DOMAIN.
1986         * symtab.c (search_domain_name): Likewise.
1987         (search_symbols): Likewise.
1988         (print_symbol_info): Likewise.
1989         (symtab_symbol_info): Likewise.
1990         (info_modules_command): New function.
1991         (_initialize_symtab): Register 'info modules' command.
1992         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1993         * NEWS: Mention new 'info modules' command.
1994
1995 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1996
1997         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1998         and $_gdb_maint_setting_str.
1999
2000 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2001
2002         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2003         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2004         (str_value_from_setting, gdb_setting_str_internal_fn)
2005         (gdb_maint_setting_str_internal_fn): New functions.
2006         (_initialize_cli_cmds): Define the new convenience functions.
2007         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2008         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2009
2010 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2011
2012         * agent.c (set_can_use_agent): When the setting is turned on,
2013         look up agent symbols if we don't have them yet.
2014         (agent_new_objfile): Don't look up agent symbols when the agent
2015         setting is off.
2016
2017 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2018
2019         * config.in: Regenerate.
2020
2021 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2022
2023         * configure: Regenerate.
2024         * configure.ac: Check for strerror_r.
2025         * gdbsupport/common-utils.h (safe_strerror): Change return value
2026         to const char * and document that this function is now threadsafe.
2027         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2028         thread_local and call strerror_r, if available.
2029         * utils.c (perror_string): Update.
2030         (print_sys_errmsg): Update.
2031
2032 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2033
2034         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2035         objfile_key.
2036         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2037         objfile to fetch per-bfd data.
2038         (arm_find_exidx_entry): Likewise.
2039
2040 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2041
2042         * gdbsupport/agent.c (debug_agent): Change type to bool.
2043         (use_agent): Likewise.
2044         (all_agent_symbols_look_up): Likewise.
2045         (agent_loaded_p): Change return value to bool.
2046         (agent_look_up_symbols): Update.
2047         (agent_capability_check): Change return value to bool.
2048         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2049         (debug_agent): Change type to bool.
2050         (use_agent): Likewise.
2051         (agent_capability_check): Change return value to bool.
2052
2053 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2054
2055         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2056         (build_minimal_symbol_hash_tables): Code to clear the table moved
2057         to clear_minimal_symbol_hash_tables.
2058         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2059         when needed.
2060
2061 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2062
2063         * infcmd.c: Remove includes.
2064         * infrun.c: Remove includes.
2065
2066 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2067
2068         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2069         (grow_vect): Remove declaration.
2070         (ada_type_of_array): Remove declaration.
2071         (ada_update_initial_language): Remove declaration.
2072         (ada_fold_name): Remove declaration.
2073         (ada_fill_in_ada_prototype): Remove declaration.
2074         (user_select_syms): Remove declaration.
2075         (get_selections): Remove declaration.
2076         (ada_tag_type): Remove declaration.
2077         (ada_value_tag): Remove declaration.
2078         (ada_is_others_clause): Remove declaration.
2079         (ada_in_variant): Remove declaration.
2080         (ada_value_struct_elt): Remove declaration.
2081         (ada_attribute_name): Remove declaration.
2082         (ada_system_address_type): Remove declaration.
2083         * ada-lang.c (ada_watch_location_expression): Make static.
2084         (GROW_VECT): Move here from ada-lang.h.
2085         (grow_vect): Make static.
2086         (ada_update_initial_language): Make static.
2087         (ada_fold_name): Make static.
2088         (ada_type_of_array): Make static.
2089         (encoded_ordered_before): Move up.
2090         (sort_choices): Move up.
2091         (print_signatures): Move up.
2092         (ada_print_symbol_signature): Move up.
2093         (get_selections): Move up and make static.
2094         (user_select_syms): Move up and make static.
2095         (ada_value_struct_elt): Move up and make static.
2096         (ada_tag_type): Make static.
2097         (ada_value_tag): Make static.
2098         (ada_is_others_clause): Make static.
2099         (ada_in_variant): Make static.
2100         (ada_attribute_name): Make static.
2101
2102 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2103
2104         * ada-lang.c: Remove includes.
2105         * ada-typeprint.c: Remove includes.
2106         * ada-valprint.c: Remove includes.
2107
2108 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2109
2110         * addrmap.c: Add static assertions of type size, moved from
2111         _initialize_addrmap.
2112         (_initialize_addrmap): Remove.
2113
2114 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2115
2116         * coffread.c (record_minimal_symbol): Update.
2117         (process_coff_symbol): Update.
2118         * dbxread.c (read_dbx_symtab): Update.
2119         * dwarf2read.c (add_partial_symbol): Update.
2120         (fixup_go_packaging): Update.
2121         (load_partial_dies): Update.
2122         (new_symbol): Update.
2123         * elfread.c (record_minimal_symbol): Change signature to use
2124         gdb::string_view instead of name+len.
2125         (elf_symtab_read): Update.
2126         (elf_rel_plt_read): Update.
2127         * mdebugread.c (parse_partial_symbols): Update.
2128         (handle_psymbol_enumerators): Update.
2129         (new_symbol): Update.
2130         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2131         to use gdb::string_view instead of name+len.
2132         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2133         * psympriv.h (add_psymbol_to_list): Likewise.
2134         * psymtab.c (add_psymbol_to_bcache): Likewise.
2135         (add_psymbol_to_list): Likewise.
2136         * stabsread.c (define_symbol): Update.
2137         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2138         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2139         (symbol_set_names): Likewise.
2140         * xcoffread.c (scan_xcoff_symtab): Update.
2141
2142 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2143
2144         * symtab.h (symbol_set_names): Document that copy_name must be
2145         set to true for non-nullterminated strings.
2146         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2147         linkage_name if the entry was not found and we need to demangle.
2148
2149 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2150
2151         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2152         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2153         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2154         * gdbsupport/gdb_binary_search.h: New file.
2155
2156 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2157
2158         * NEWS: Mention new --with-system-gdbinit-dir option.
2159         * config.in: Regenerate.
2160         * configure: Regenerate.
2161         * configure.ac: Add new option --with-system-gdbinit-dir.
2162         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2163         for a ".gdb" suffix.
2164         * main.c (get_init_files): Change system_gdbinit argument to
2165         a vector and return the files in SYSTEM_GDBINIT_DIR in
2166         addition to SYSTEM_GDBINIT.
2167         (captured_main_1): Update.
2168         (print_gdb_help): Update.
2169         * top.c (print_gdb_configuration): Also print the value of
2170         SYSTEM_GDBINIT_DIR.
2171
2172 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2173
2174         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2175         that takes gdb::string_view arguments.
2176
2177 2019-10-26  Tom de Vries  <tdevries@suse.de>
2178
2179         * aarch64-linux-tdep.c: Fix typos in comments.
2180         * aarch64-tdep.c: Same.
2181         * ada-lang.c: Same.
2182         * amd64-nat.c: Same.
2183         * arc-tdep.c: Same.
2184         * arch/aarch64-insn.c: Same.
2185         * block.c: Same.
2186         * breakpoint.h: Same.
2187         * btrace.h: Same.
2188         * c-varobj.c: Same.
2189         * cli/cli-decode.c: Same.
2190         * cli/cli-script.c: Same.
2191         * cli/cli-utils.h: Same.
2192         * coff-pe-read.c: Same.
2193         * coffread.c: Same.
2194         * compile/compile-cplus-symbols.c: Same.
2195         * compile/compile-object-run.c: Same.
2196         * completer.c: Same.
2197         * corelow.c: Same.
2198         * cp-support.c: Same.
2199         * demangle.c: Same.
2200         * dwarf-index-write.c: Same.
2201         * dwarf2-frame.c: Same.
2202         * dwarf2-frame.h: Same.
2203         * eval.c: Same.
2204         * frame-base.h: Same.
2205         * frame.h: Same.
2206         * gdbcmd.h: Same.
2207         * gdbtypes.h: Same.
2208         * gnu-nat.c: Same.
2209         * guile/scm-objfile.c: Same.
2210         * i386-tdep.c: Same.
2211         * i386-tdep.h: Same.
2212         * infcall.c: Same.
2213         * infcall.h: Same.
2214         * linux-nat.c: Same.
2215         * m68k-tdep.c: Same.
2216         * macroexp.c: Same.
2217         * memattr.c: Same.
2218         * mi/mi-cmd-disas.c: Same.
2219         * mi/mi-getopt.h: Same.
2220         * mi/mi-main.c: Same.
2221         * minsyms.c: Same.
2222         * nat/aarch64-sve-linux-sigcontext.h: Same.
2223         * objfiles.h: Same.
2224         * ppc-linux-nat.c: Same.
2225         * ppc-linux-tdep.c: Same.
2226         * ppc-tdep.h: Same.
2227         * progspace.h: Same.
2228         * prologue-value.h: Same.
2229         * python/py-evtregistry.c: Same.
2230         * python/py-instruction.h: Same.
2231         * record-btrace.c: Same.
2232         * record-full.c: Same.
2233         * remote.c: Same.
2234         * rs6000-tdep.c: Same.
2235         * ser-tcp.c: Same.
2236         * sol-thread.c: Same.
2237         * sparc-sol2-tdep.c: Same.
2238         * sparc64-tdep.c: Same.
2239         * stabsread.c: Same.
2240         * symfile.c: Same.
2241         * symtab.h: Same.
2242         * target.c: Same.
2243         * tracepoint.c: Same.
2244         * tui/tui-data.h: Same.
2245         * tui/tui-io.c: Same.
2246         * tui/tui-win.c: Same.
2247         * tui/tui.c: Same.
2248         * unittests/rsp-low-selftests.c: Same.
2249         * user-regs.h: Same.
2250         * utils.c: Same.
2251         * utils.h: Same.
2252         * valarith.c: Same.
2253         * valops.c: Same.
2254         * valprint.c: Same.
2255         * valprint.h: Same.
2256         * value.c: Same.
2257         * value.h: Same.
2258         * varobj.c: Same.
2259         * x86-nat.h: Same.
2260         * xtensa-tdep.c: Same.
2261
2262 2019-10-25  Ali Tamur <tamur@google.com>
2263
2264         * charset.c (find_charset_names): Reflect API change.
2265
2266 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2267
2268         * symtab.c (struct demangled_name_entry): Change demangled name
2269         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2270         part of the struct anymore.
2271         (symbol_set_names): No longer obstack allocate + copy the demangled
2272         name, just store the allocated name from bfd.
2273
2274 2019-10-25  Tom Tromey  <tromey@adacore.com>
2275
2276         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2277         (bsearch_cie_cmp, add_cie): Remove.
2278         (find_cie): Reimplement.
2279         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2280         (dwarf2_build_frame_info): Update.
2281
2282 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2283
2284         PR gdb/25126
2285         * symfile.c (reread_symbols): Call forget_cached_source_info to
2286         clear the stale source cache.
2287
2288 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2289
2290         * configure: Regenerate.
2291         * configure.ac: Remove code that sets python_has_threads.
2292
2293 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2294
2295         * config.in: Regenerate.
2296         * configure: Regenerate.
2297         * configure.ac: Remove the code that uses sed to get the python
2298         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2299
2300 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2301
2302         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2303         error paths.
2304
2305 2019-10-23  Tom Tromey  <tom@tromey.com>
2306
2307         * arc-tdep.c: Remove ".." from include.
2308         * frv-tdep.c: Remove ".." from include.
2309         * lm32-tdep.c: Remove ".." from include.
2310         * microblaze-tdep.c: Remove ".." from include.
2311         * or1k-tdep.h: Remove ".." from include.
2312         * s12z-tdep.c: Remove ".." from include.
2313         * Makefile.in (OPCODES_CFLAGS): Add comment.
2314         (TOP_CFLAGS): New variable.
2315         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2316
2317 2019-10-23  Tom Tromey  <tom@tromey.com>
2318
2319         * Makefile.in (READLINE_DIR): Update.
2320
2321 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2322
2323         * infcall.c (call_function_by_hand_dummy): Fix the function
2324         comment.  And extract out a code section into...
2325         (reserve_stack_space): ...this new function.
2326
2327 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2328
2329         * infcall.c (value_arg_coerce): Remove an unused parameter.
2330         (call_function_by_hand_dummy): Update the call to
2331         'value_arg_coerce'.
2332
2333 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2334
2335         * infcall.c (call_function_by_hand_dummy): Refactor.
2336
2337 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2338
2339         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2340
2341 2019-10-23  Tom Tromey  <tom@tromey.com>
2342
2343         * configure: Rebuild.
2344         * configure.ac: Don't check for sigprocmask.
2345         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2346
2347 2019-10-23  Tom Tromey  <tom@tromey.com>
2348
2349         * configure: Rebuild.
2350         * acinclude.m4: Use m4_include, not sinclude.
2351
2352 2019-10-23  Tom de Vries  <tdevries@suse.de>
2353
2354         PR breakpoints/24687
2355         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2356
2357 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2358
2359         * symtab.c (struct demangled_name_entry) <language>: Change from
2360         bitfield to regular variable.
2361
2362 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2363
2364         * symtab.c (struct demangled_name_entry): Add a constructor.
2365         (free_demangled_name_entry): New function to call the destructor
2366         for demangled_name_entry.
2367         (create_demangled_names_hash): Pass free_demangled_name_entry to
2368         htab_create_alloc.
2369         (symbol_set_names): Call placement new for demangled_name_entry.
2370         * utils.c: No longer include xxhash.h here, now that fast_hash
2371         is inlined in the header.
2372         * utils.h: Instead, include it here.
2373
2374 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2375
2376         * Makefile.in: Link with libxxhash.
2377         * config.in: Regenerate.
2378         * configure: Regenerate.
2379         * configure.ac: Search for libxxhash.
2380         * utils.c (fast_hash): Use xxhash if present.
2381
2382 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2383
2384         * utils.h (fast_hash): New function.
2385         * symtab.c (hash_demangled_name_entry): Call new function
2386         fast_hash.
2387
2388 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2389
2390         * symtab.c (struct demangled_name_entry): Change type of mangled
2391         to gdb::string_view. Also adds a constructor that takes the
2392         mangled name.
2393         (hash_demangled_name_entry): Update.
2394         (eq_demangled_name_entry): Update.
2395         (free_demangled_name_entry): New function to call the destructor
2396         now that this is not a POD anymore.
2397         (create_demangled_names_hash): Pass free_demangled_name_entry to
2398         htab_create_alloc.
2399         (symbol_set_names): Update.
2400
2401 2019-10-21  Ali Tamur  <tamu@google.com>
2402
2403         * dwarf2read.c (dir_index): Change type.
2404         (file_name_index): Likewise.
2405         (line_header::include_dir_at): Change comment and implementation on
2406         whether it is DWARF 5.
2407         (line_header::is_valid_file_index): New function.
2408         (line_header::file_name_at): Change comment and implementation on
2409         whether it is DWARF 5.
2410         (line_header::file_names): Change to private field renamed as
2411         m_file_names and introduce a new accessor method.
2412         (line_header::file_names_size): New method.
2413         (line_header::include_dirs): Change to private field and rename as
2414         m_include_dirs.
2415         (dw2_get_file_names_reader): Define local var at a smaller scope and
2416         reflect API change.
2417         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2418         (process_structure_scope): Likewise.
2419         (line_header::add_include_dir): Change message and reflect renaming.
2420         (line_header::add_file_name): Likewise.
2421         (read_formatted_entries): Handle DW_FORM_data16.
2422         (dwarf_decode_line_header): Fix line header length calculation.
2423         (psymtab_include_file_name): Change comment and API.
2424         (lnp_state_machine::m_file): Update comment and reflect type change.
2425         (lnp_state_machine::record_line): Reflect type change.
2426         (dwarf_decode_lines): Reflect API change.
2427         (file_file_name): Likewise.
2428         (file_full_name): Likewise.
2429
2430 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2431
2432         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2433
2434 2019-10-21  Tom Tromey  <tom@tromey.com>
2435
2436         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2437
2438 2019-10-21  Tom Tromey  <tom@tromey.com>
2439
2440         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2441         NM_H.   Use AC_CONFIG_LINKS.
2442         * configure: Rebuild.
2443         * Makefile.in (NM_H): New variable.
2444         (generated_files): Add NM_H.  Remove gcore.
2445         (nm.h, stamp-nmh): New targets.
2446
2447 2019-10-20  Tom Tromey  <tom@tromey.com>
2448
2449         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2450         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2451         obsolete comment.
2452         (put_objfile_before): Now static.
2453
2454 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2455
2456         * gdbsupport/common-utils.h (startswith): Change return type to
2457         bool.
2458
2459 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2460
2461         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2462         * breakpoint.c (bp_locations_compare): Rename to...
2463         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2464         (update_global_location_list): Use std::sort instead of qsort.
2465         * buildsym.c (compare_line_numbers): Rename to...
2466         (lte_is_less_than): ...this, and change to std::sort semantics.
2467         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2468         instead of qsort.
2469         * disasm.c (compare_lines): Rename to...
2470         (line_is_less_than): ...this, and change to std::sort semantics.
2471         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2472         of qsort.
2473         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2474         (fde_is_less_than): ...this, and change to std::sort semantics.
2475         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2476         * mdebugread.c (compare_blocks):
2477         (block_is_less_than): ...this, and change to std::sort semantics.
2478         (sort_blocks): Call std::sort instead of qsort.
2479         * objfiles.c (qsort_cmp): Rename to...
2480         (sort_cmp): ...this, and change to std::sort semantics.
2481         (update_section_map): Call std::sort instead of qsort.
2482         * remote.c (compare_pnums): Remove.
2483         (map_regcache_remote_table): Call std::sort instead of qsort.
2484         * utils.c (compare_positive_ints): Remove.
2485         * utils.h (compare_positive_ints): Remove.
2486         * xcoffread.c (compare_lte): Remove.
2487         (arrange_linetable): Call std::sort instead of qsort.
2488
2489 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2490
2491         * symfile.c (init_entry_point_info): Fix typo.
2492         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2493
2494 2019-10-18  Tom de Vries  <tdevries@suse.de>
2495
2496         * aarch64-tdep.c: Fix typos in comments.
2497         * ada-lang.c: Same.
2498         * ada-tasks.c: Same.
2499         * alpha-tdep.c: Same.
2500         * alpha-tdep.h: Same.
2501         * amd64-nat.c: Same.
2502         * amd64-windows-tdep.c: Same.
2503         * arc-tdep.c: Same.
2504         * arc-tdep.h: Same.
2505         * arch-utils.c: Same.
2506         * arm-nbsd-tdep.c: Same.
2507         * arm-tdep.c: Same.
2508         * ax-gdb.c: Same.
2509         * blockframe.c: Same.
2510         * btrace.c: Same.
2511         * c-varobj.c: Same.
2512         * coff-pe-read.c: Same.
2513         * coffread.c: Same.
2514         * cris-tdep.c: Same.
2515         * darwin-nat.c: Same.
2516         * dbxread.c: Same.
2517         * dcache.c: Same.
2518         * disasm.c: Same.
2519         * dtrace-probe.c: Same.
2520         * dwarf-index-write.c: Same.
2521         * dwarf2-frame-tailcall.c: Same.
2522         * dwarf2-frame.c: Same.
2523         * dwarf2read.c: Same.
2524         * eval.c: Same.
2525         * exceptions.c: Same.
2526         * fbsd-tdep.c: Same.
2527         * findvar.c: Same.
2528         * frame.c: Same.
2529         * frv-tdep.c: Same.
2530         * gnu-v3-abi.c: Same.
2531         * go32-nat.c: Same.
2532         * h8300-tdep.c: Same.
2533         * hppa-tdep.c: Same.
2534         * i386-linux-tdep.c: Same.
2535         * i386-tdep.c: Same.
2536         * ia64-libunwind-tdep.c: Same.
2537         * ia64-tdep.c: Same.
2538         * infcmd.c: Same.
2539         * infrun.c: Same.
2540         * linespec.c: Same.
2541         * linux-nat.c: Same.
2542         * linux-thread-db.c: Same.
2543         * machoread.c: Same.
2544         * mdebugread.c: Same.
2545         * mep-tdep.c: Same.
2546         * mn10300-tdep.c: Same.
2547         * namespace.c: Same.
2548         * objfiles.c: Same.
2549         * opencl-lang.c: Same.
2550         * or1k-tdep.c: Same.
2551         * osabi.c: Same.
2552         * ppc-linux-nat.c: Same.
2553         * ppc-linux-tdep.c: Same.
2554         * ppc-sysv-tdep.c: Same.
2555         * printcmd.c: Same.
2556         * procfs.c: Same.
2557         * record-btrace.c: Same.
2558         * record-full.c: Same.
2559         * remote-fileio.c: Same.
2560         * remote.c: Same.
2561         * rs6000-tdep.c: Same.
2562         * s12z-tdep.c: Same.
2563         * score-tdep.c: Same.
2564         * ser-base.c: Same.
2565         * ser-go32.c: Same.
2566         * skip.c: Same.
2567         * sol-thread.c: Same.
2568         * solib-svr4.c: Same.
2569         * solib.c: Same.
2570         * source.c: Same.
2571         * sparc-nat.c: Same.
2572         * sparc-sol2-tdep.c: Same.
2573         * sparc-tdep.c: Same.
2574         * sparc64-tdep.c: Same.
2575         * stabsread.c: Same.
2576         * stack.c: Same.
2577         * symfile.c: Same.
2578         * symtab.c: Same.
2579         * target-descriptions.c: Same.
2580         * target-float.c: Same.
2581         * thread.c: Same.
2582         * utils.c: Same.
2583         * valops.c: Same.
2584         * valprint.c: Same.
2585         * value.c: Same.
2586         * varobj.c: Same.
2587         * windows-nat.c: Same.
2588         * xcoffread.c: Same.
2589         * xstormy16-tdep.c: Same.
2590         * xtensa-tdep.c: Same.
2591
2592 2019-10-17  Tom Tromey  <tromey@adacore.com>
2593
2594         * configure: Rebuild.
2595         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2596         in AC_CONFIG_FILES invocation.
2597         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2598         new-style config.status invocation.
2599
2600 2019-10-17  Tom de Vries  <tdevries@suse.de>
2601
2602         * arm-nbsd-nat.c: Fix typos in comments.
2603         * arm-tdep.c: Same.
2604         * darwin-nat-info.c: Same.
2605         * dwarf2read.c: Same.
2606         * elfread.c: Same.
2607         * event-top.c: Same.
2608         * findvar.c: Same.
2609         * gdbtypes.c: Same.
2610         * hppa-tdep.c: Same.
2611         * i386-tdep.c: Same.
2612         * jit.c: Same.
2613         * main.c: Same.
2614         * mdebugread.c: Same.
2615         * moxie-tdep.c: Same.
2616         * nto-procfs.c: Same.
2617         * osabi.c: Same.
2618         * ppc-linux-tdep.c: Same.
2619         * remote.c: Same.
2620         * riscv-tdep.c: Same.
2621         * s390-tdep.c: Same.
2622         * sh-tdep.c: Same.
2623         * sparc-linux-tdep.c: Same.
2624         * sparc-nat.c: Same.
2625         * stack.c: Same.
2626         * target-descriptions.c: Same.
2627         * top.c: Same.
2628         * varobj.c: Same.
2629
2630 2019-10-16  Tom Tromey  <tom@tromey.com>
2631
2632         * objfiles.h (struct objfile) <original_name>: Now const.
2633
2634 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2635
2636         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2637         pass on to sigsetjmp's second argument.
2638         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2639
2640 2019-10-16  Keith Seitz  <keiths@redhat.com>
2641
2642         PR gdb/23567
2643         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2644         sections whose size is greater than the file size.
2645
2646 2019-10-16  Jim Wilson  <jimw@sifive.com>
2647
2648         * riscv-tdep.c (riscv_gcc_target_options): New.
2649         (riscv_gnu_triplet_regexp): New.
2650         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2651         set_gdbarch_gnu_triplet_regexp.
2652
2653 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2654
2655         * Makefile.in: Add xml-builtin.h.
2656         * features/feature_to_c.sh: Add an include for xml-builtin.h
2657         to ensure that the compiler checks that the types match.
2658         * xml-builtin.h: New file.
2659         * xml-support.c (fetch_xml_builtin): Add missing const.
2660         * xml-support.h: Remove declaration of xml_builtins.
2661
2662 2019-10-16  Tom de Vries  <tdevries@suse.de>
2663
2664         PR tdep/25096
2665         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2666         (amd64_classify_aggregate): ... here.
2667         (amd64_classify_aggregate_field): Handled fiels of nested structs
2668         recursively.
2669
2670 2019-10-16  Tom de Vries  <tdevries@suse.de>
2671
2672         PR tdep/24104
2673         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2674         that handles 'theclass'.
2675
2676 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2677
2678         * linespec.c (decode_digits_ordinary): Update comment.
2679         * make-target-delegates: No longer need to handle VEC case.
2680         * memrange.c (normalize_mem_ranges): Update comment.
2681         * namespace.c (add_using_directive): Update comment.
2682         * objc-lang.c (uniquify_strings): Update comment.
2683         * ppc-linux-nat.c (struct thread_points): Update comment.
2684         * probe.h (find_probes_in_objfile): Update comment.
2685         * target.h (enum flash_preserve_mode): Update comment.
2686         * varobj.c (varobj_restrict_range): Update comment.
2687         * varobj.h (varobj_list_children): Update comment.
2688
2689 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2690
2691         * Makefile.in: Remove references to vec.h and vec.c.
2692         * aarch64-tdep.c: No longer include vec.h.
2693         * ada-lang.c: Likewise.
2694         * ada-lang.h: Likewise.
2695         * arm-tdep.c: Likewise.
2696         * ax.h: Likewise.
2697         * breakpoint.h: Likewise.
2698         * charset.c: Likewise.
2699         * cp-support.h: Likewise.
2700         * dtrace-probe.c: Likewise.
2701         * dwarf2read.c: Likewise.
2702         * extension.h: Likewise.
2703         * gdb_bfd.c: Likewise.
2704         * gdbsupport/gdb_vecs.h: Likewise.
2705         * gdbsupport/vec.c: Remove.
2706         * gdbsupport/vec.h: Remove.
2707         * gdbthread.h: Likewise.
2708         * guile/scm-type.c: Likewise.
2709         * inline-frame.c: Likewise.
2710         * machoread.c: Likewise.
2711         * memattr.c: Likewise.
2712         * memrange.h: Likewise.
2713         * namespace.h: Likewise.
2714         * nat/linux-btrace.h: Likewise.
2715         * osdata.c: Likewise.
2716         * parser-defs.h: Likewise.
2717         * progspace.h: Likewise.
2718         * python/py-type.c: Likewise.
2719         * record-btrace.c: Likewise.
2720         * rust-exp.y: Likewise.
2721         * solib-target.c: Likewise.
2722         * stap-probe.c: Likewise.
2723         * target-descriptions.c: Likewise.
2724         * target-memory.c: Likewise.
2725         * target.h: Likewise.
2726         * varobj.c: Likewise.
2727         * varobj.h: Likewise.
2728         * xml-support.h: Likewise.
2729
2730 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2731
2732         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2733         Update for new std::vector based implementation.
2734         (process_psymtab_comp_unit_reader): Likewise.
2735         (scan_partial_symbols): Likewise.
2736         (recursively_compute_inclusions): Likewise.
2737         (compute_compunit_symtab_includes): Likewise.
2738         (process_imported_unit_die): Likewise.
2739         (queue_and_load_dwo_tu): Likewise.
2740         (follow_die_sig_1): Likewise.
2741         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2742         (typedef dwarf2_per_cu_ptr): Remove.
2743         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2744         function.
2745         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2746         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2747         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2748         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2749         std::vector.
2750
2751 2019-10-15  Tom Tromey  <tromey@adacore.com>
2752
2753         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2754         TID.
2755
2756 2019-10-15  Tom Tromey  <tromey@adacore.com>
2757
2758         * windows-nat.c (windows_nat_target::fetch_registers)
2759         (windows_nat_target::store_registers): Rename "pid" to "tid".
2760
2761 2019-10-15  Tom Tromey  <tromey@adacore.com>
2762
2763         * gdbarch.h, gdbarch.c: Rebuild.
2764         * gdbarch.sh (gcc_target_options): Change return type to
2765         std::string.
2766         * compile/compile.c (get_args): Update.
2767         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2768         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2769         std::string.
2770         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2771         std::string.
2772         * arch-utils.c (default_gcc_target_options): Return std::string.
2773         * arch-utils.h (default_gcc_target_options): Return std::string.
2774         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2775
2776 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2777
2778         * breakpoint.c (breakpoint_chain): Make static.
2779         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2780         of accessing breakpoint_chain.
2781
2782 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2783
2784         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2785         to a gdb::function_view and return value to bool.
2786         * breakpoint.h (iterate_over_breakpoints): Likewise.
2787         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2788         (pop_dummy_frame): Update.
2789         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2790         (gdbscm_breakpoints): Update.
2791         * python/py-breakpoint.c (build_bp_list): Update.
2792         (gdbpy_breakpoints): Update.
2793         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2794         Update.
2795         (bpfinishpy_handle_stop): Update.
2796         (bpfinishpy_handle_exit): Update.
2797         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2798         (svr4_update_solib_event_breakpoints): Update.
2799
2800 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2801
2802         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2803         when unwrapping single-field structs.
2804
2805 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2806
2807         * dwarf2read.c: Remove includes.
2808
2809 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2810
2811         * ui-out.c (ui_out::call_do_message): Silence
2812         -Wformat-nonliteral warning.
2813
2814 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2815
2816         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2817         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2818         include: readline/tilde.h.
2819
2820 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2821
2822         * remote.c (remote_target::get_trace_status): Remove declaration of
2823         trace_regblock_size.
2824
2825 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2826
2827         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2828         (show_user): Remove declaration of cmdlist.
2829         * cli/cli-cmds.h (max_user_call_depth): Declare.
2830         * cli/cli-script.c (execute_user_command): Remove declaration
2831         of max_user_call_depth.
2832
2833 2019-10-11  Jim Wilson  <jimw@sifive.com>
2834
2835         * gdbsupport/print-utils.h (pulongest): Fix comment.
2836         (plongest): Likewise.
2837         (phex): Add missing comment, mention leading zeros.
2838         (phex_nz): Add mention of no leading zeros to comment.
2839
2840         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2841         plongest instead of unsigned long long cast.
2842
2843 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2844
2845         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2846         for external_editor_command and gdbtk_test.
2847
2848 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2849
2850         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2851         * varobj.c (varobjdebug): Move comment to...
2852         * varobj.h (varobjdebug): ...here, and declare.
2853
2854 2019-10-09  Tom Tromey  <tom@tromey.com>
2855
2856         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2857         erase_data_content.
2858
2859 2019-10-09  Tom Tromey  <tom@tromey.com>
2860
2861         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2862         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2863         * tui/tui-command.c (tui_cmd_window::resize)
2864         (tui_refresh_cmd_win): Update.
2865         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2866         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2867         * tui/tui-data.c (~tui_gen_win_info): Remove.
2868         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2869         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2870         (tui_redisplay_readline, tui_mld_flush)
2871         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2872         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2873         (tui_data_window::erase_data_content)
2874         (tui_data_item_window::rerender)
2875         (tui_data_item_window::refresh_window): Update.
2876         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2877         (box_win, tui_gen_win_info::make_window)
2878         (tui_gen_win_info::make_visible): Update.
2879         (tui_delete_win): Remove.
2880         * tui/tui-winsource.c
2881         (tui_source_window_base::do_erase_source_content): Update.
2882         (tui_show_source_line, tui_source_window_base::update_tab_width)
2883         (tui_source_window_base::update_exec_info): Update.
2884         * tui/tui-data.h (struct curses_deleter): New.
2885         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2886         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2887
2888 2019-10-09  Tom Tromey  <tom@tromey.com>
2889
2890         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2891
2892 2019-10-09  Tom Tromey  <tom@tromey.com>
2893
2894         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2895         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2896
2897 2019-10-09  Tom Tromey  <tom@tromey.com>
2898
2899         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2900         window height directly.
2901         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2902         declare.
2903         * tui/tui-layout.c (tui_default_win_height): Remove.
2904         (tui_default_win_viewport_height): Remove.
2905
2906 2019-10-09  Tom Tromey  <tom@tromey.com>
2907
2908         * tui/tui.h: Remove comments.
2909
2910 2019-10-09  Tom de Vries  <tdevries@suse.de>
2911
2912         * python/lib/gdb/printer/bound_registers.py: Use
2913         '^builtin_type_bound128' as regexp argument for
2914         add_builtin_pretty_printer.
2915
2916 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2917
2918         * guile/guile.c (guile_extension_script_ops): Remove forward
2919         declaration and mark as static.
2920         (guile_script_ops): Likewise.
2921         (extension_language_guile): Move further down in the file so
2922         it can reference the definitions for guile_{extension_,}script_ops.
2923
2924 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2925
2926         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2927         except SORTL, DFLTCC, and KDSA.
2928
2929 2019-10-08  Tom Tromey  <tromey@adacore.com>
2930
2931         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2932         (struct safe_symbol_file_add_args): Remove.
2933
2934 2019-10-08  Tom Tromey  <tromey@adacore.com>
2935
2936         * windows-nat.c: Don't include buildsym-legacy.h.
2937
2938 2019-10-08  Tom Tromey  <tromey@adacore.com>
2939
2940         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2941
2942 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2943
2944         * gdbtypes.c (overload_debug): Move comment to header.
2945         * gdbtypes.h (overload_debug): Declare.
2946         * valops.c: Remove declaration of overload_debug, instead
2947         include gdbtypes.h.
2948
2949 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2950
2951         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2952         through _().
2953         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2954         move comment...
2955         * language.h (lang_frame_mismatch_warn): ... here. Also add
2956         declaration.
2957         * top.c (lang_frame_mismatch_warn): Remove declaration.
2958         (check_frame_language_change): Pass lang_frame_mismatch_warn
2959         through _().
2960
2961 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2962
2963         * c-lang.h (vtbl_ptr_name): Declare.
2964         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2965         it from the header.
2966         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2967
2968 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2969
2970         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2971         gdb_static_assert.
2972
2973 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2974
2975         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2976         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2977         * ctfread.c: New file.
2978         * ctfread.h: New file.
2979         * elfread.c: Include ctfread.h.
2980         (struct elfinfo text_p): New member ctfsect.
2981         (elf_locate_sections): Mark CTF section.
2982         (elf_symfile_read): Call elfctf_build_psymtabs.
2983         * Makefile.in (LIBCTF): Add.
2984         (CLIBS): Use it.
2985         (CDEPS): Likewise.
2986         (DIST): Add ctfread.c.
2987
2988 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2989
2990         * ctfread.c (struct nextfield): Renamed to ...
2991         (struct ctf_nextfield): ... this.
2992         (struct field_info): Renamed to ...
2993         (strut ctf_field_info): ... this.
2994         (attach_fields_to_type): Update for renamed structures.
2995         (ctf_add_member_cb): Likewise.
2996         (ctf_add_enum_member_cb): Likewise.
2997         (process_struct_members): Likewise.
2998         (process_enum_type): Likewise.
2999
3000 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3001
3002         * tracectf.h: Rename, was ctf.h.
3003         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3004         * tracefile.c: Likewise.
3005         * tracepoint.c: Remove unused include ctf.h.
3006         * mi/mi-main.c: Likewise.
3007         * Makefile.in Replace ctf.c with tracectf.c.
3008
3009 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3010
3011         * version.in: Change version number to "9.0.50.DATE-git".
3012
3013 2019-10-03  Tom Tromey  <tom@tromey.com>
3014
3015         PR rust/24976:
3016         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3017
3018 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3019
3020         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3021         cp_search_name_hash.
3022         * NEWS: Add entry about nested function support.
3023
3024 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3025             Andrew Burgess  <andrew.burgess@embecosm.com>
3026
3027         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3028         for nested static variables when searchin VAR_DOMAIN.
3029         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3030         global scope, update comment.
3031         (add_partial_subprogram): Call add_partial_subprogram recursively
3032         for nested subroutines when processinng Fortran.
3033         (load_partial_dies): Process the child entities of a subprogram
3034         when processing Fortran.
3035         (partial_die_parent_scope): Handle building scope
3036         for Fortran nested functions.
3037         (process_die): Record that nested functions have a scope.
3038         (new_symbol): Always record Fortran subprograms on the global
3039         symbol list.
3040         (determine_prefix): How to build the prefix for Fortran
3041         subprograms.
3042
3043 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3044
3045         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3046         have just sent the thread a SIGSTOP and are waiting for it to
3047         arrive.
3048
3049 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3050
3051         * btrace.c (btrace_add_pc): Remove whitespace before the template
3052         parameter in 'std::vector <...>'.
3053         (parse_xml_btrace_block): Likewise.
3054         (btrace_maint_decode_pt): Likewise.
3055         (btrace_maint_update_packets): Likewise.
3056         (btrace_maint_print_packets): Likewise.
3057         * btrace.h (struct btrace_maint_info): Likewise.
3058         * dwarf2read.c (struct type_unit_group): Likewise.
3059         (build_type_psymtabs_reader): Likewise.
3060         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3061         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3062         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3063
3064 2019-10-03  Tom de Vries  <tdevries@suse.de>
3065
3066         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3067         the first line of the help text for set/show style metadata.
3068
3069 2019-10-02  Tom Tromey  <tromey@adacore.com>
3070
3071         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3072         * gdbsupport/common-inferior.c: New file.
3073         * infcmd.c (startup_with_shell): Don't define.
3074         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3075         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3076         * inferior.h (startup_with_shell): Don't declare.
3077
3078 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3079
3080         * gdbsupport/gdb_assert.h: Include errors.h.
3081         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3082
3083 2019-10-02  Tom Tromey  <tromey@adacore.com>
3084
3085         * NEWS: Add $_ada_exception entry.
3086         * ada-lang.c (struct ada_catchpoint): Add constructor.
3087         <m_kind>: New member.
3088         (allocate_location_exception, re_set_exception): Remove
3089         "ex" parameter.
3090         (should_stop_exception): Compute $_ada_exception.
3091         (check_status_exception, print_it_exception)
3092         (print_one_exception, print_mention_exception): Remove
3093         "ex" parameter.
3094         (allocate_location_catch_exception, re_set_catch_exception)
3095         (check_status_exception, print_it_catch_exception)
3096         (print_one_catch_exception, print_mention_catch_exception)
3097         (print_recreate_catch_exception)
3098         (allocate_location_catch_exception_unhandled)
3099         (re_set_catch_exception_unhandled)
3100         (check_status_exception, print_it_catch_exception_unhandled)
3101         (print_one_catch_exception_unhandled)
3102         (print_mention_catch_exception_unhandled)
3103         (print_recreate_catch_exception_unhandled)
3104         (allocate_location_catch_assert, re_set_catch_assert)
3105         (check_status_assert, print_it_catch_assert)
3106         (print_one_catch_assert, print_mention_catch_assert)
3107         (print_recreate_catch_assert)
3108         (allocate_location_catch_handlers, re_set_catch_handlers)
3109         (check_status_handlers, print_it_catch_handlers)
3110         (print_one_catch_handlers, print_mention_catch_handlers)
3111         (print_recreate_catch_handlers): Remove.
3112         (create_ada_exception_catchpoint): Update.
3113         (initialize_ada_catchpoint_ops): Update.
3114
3115 2019-10-02  Tom Tromey  <tromey@adacore.com>
3116
3117         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3118         (create_excep_cond_exprs): Simplify exception string computation.
3119         (ada_exception_catchpoint_cond_string): Likewise.
3120
3121 2019-10-02  Tom Tromey  <tromey@adacore.com>
3122
3123         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3124         * ada-lang.c (lesseq_defined_than): Handle
3125         LOC_STATIC.
3126         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3127         parameter.
3128         (dwarf2_has_info): Likewise.
3129         (new_symbol): Set maybe_copied on symbol when
3130         appropriate.
3131         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3132         parameter.
3133         <can_copy>: New member.
3134         * elfread.c (record_minimal_symbol): Set maybe_copied
3135         on symbol when appropriate.
3136         (elf_symfile_read): Update call to dwarf2_has_info.
3137         * minsyms.c (lookup_minimal_symbol_linkage): New
3138         function.
3139         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3140         * symtab.c (get_symbol_address, get_msymbol_address):
3141         New functions.
3142         * symtab.h (get_symbol_address, get_msymbol_address):
3143         Declare.
3144         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3145         maybe_copied.
3146         (struct symbol, struct minimal_symbol) <maybe_copied>:
3147         New member.
3148
3149 2019-10-02  Tom Tromey  <tromey@adacore.com>
3150
3151         * source.c (struct current_source_location): New.
3152         (current_source_key): New global.
3153         (current_source_symtab, current_source_line)
3154         (current_source_pspace): Remove.
3155         (get_source_location): New function.
3156         (get_current_source_symtab_and_line)
3157         (set_default_source_symtab_and_line)
3158         (set_current_source_symtab_and_line)
3159         (clear_current_source_symtab_and_line, select_source_symtab)
3160         (info_source_command, print_source_lines_base)
3161         (info_line_command, search_command_helper, _initialize_source):
3162         Update.
3163
3164 2019-10-02  Tom Tromey  <tromey@adacore.com>
3165
3166         * source.c (select_source_symtab): Don't call
3167         decode_line_with_current_source.
3168
3169 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3170
3171         * symtab.c (lookup_global_symbol): Search global block.
3172
3173 2019-10-02  Tom Tromey  <tromey@adacore.com>
3174
3175         * coffread.c (process_coff_symbol): Update.
3176         * dwarf2read.c (var_decode_location, new_symbol): Update.
3177         * mdebugread.c (parse_symbol): Update.
3178         * objfiles.c (relocate_one_symbol): Update.
3179         * stabsread.c (define_symbol, fix_common_block)
3180         (scan_file_globals): Update.
3181         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3182         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3183         * xcoffread.c (process_xcoff_symbol): Update.
3184
3185 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3186
3187         * MAINTAINERS: Update my email address.
3188
3189 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3190
3191         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3192         std::vector.
3193         (build_type_psymtabs_reader): Update for std::vector.
3194         (build_type_psymtab_dependencies): Likewise.
3195         * dwarf2read.h: Remove use of DEF_VEC_P.
3196         (typedef sig_type_ptr): Delete.
3197
3198 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3199
3200         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3201         to std::vector.
3202         (btrace_maint_decode_pt): Likewise, and move allocation of the
3203         vector outside of the loop.
3204         (btrace_maint_update_packets): Update to handle change from VEC to
3205         std::vector.
3206         (btrace_maint_print_packets): Likewise.
3207         (maint_info_btrace_cmd): Likewise.
3208         * btrace.h: Remove use of DEF_VEC_O.
3209         (typedef btrace_pt_packet_s): Delete.
3210         (struct btrace_maint_info) <packets>: Change fromm VEC to
3211         std::vector.
3212         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3213
3214 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3215
3216         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3217         make accesses into the vector constant references.
3218         (btrace_add_pc): Update for std::vector.
3219         (btrace_stitch_bts): Likewise.
3220         (parse_xml_btrace_block): Likewise.
3221         (btrace_maint_update_packets): Likewise.
3222         (btrace_maint_print_packets): Likewise.
3223         (maint_info_btrace_cmd): Likewise.
3224         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3225         std::vector.
3226         (btrace_data::empty): Likewise.
3227         (btrace_data_append): Likewise.
3228         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3229         (typedef btrace_block_s): Delete.
3230         (struct btrace_block): Add constructor.
3231         (struct btrace_data_bts) <blocks>: Change to std::vector.
3232         * nat/linux-btrace.c (perf_event_read_bts): Update for
3233         std::vector.
3234         (linux_read_bts): Likewise.
3235
3236 2019-10-01  Tom Tromey  <tom@tromey.com>
3237
3238         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3239
3240 2019-10-01  Tom Tromey  <tom@tromey.com>
3241
3242         * stack.c (print_frame, info_frame_command_core): Use
3243         styled_string.
3244         * linux-thread-db.c (try_thread_db_load_1)
3245         (try_thread_db_load_from_pdir_1): Use styled_string.
3246         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3247         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3248         (maybe_print_unsupported_script_warning)
3249         (maybe_print_script_not_found_warning): Use styled_string.
3250         * ada-lang.c (user_select_syms): Use styled_string.
3251
3252 2019-10-01  Tom Tromey  <tom@tromey.com>
3253
3254         * p-lang.c (pascal_printstr): Use metadata style.
3255         * value.c (show_convenience): Use metadata style.
3256         * valprint.c (valprint_check_validity, val_print_optimized_out)
3257         (val_print_not_saved, val_print_unavailable)
3258         (val_print_invalid_address, generic_val_print, val_print)
3259         (value_check_printable, val_print_array_elements): Use metadata
3260         style.
3261         * ui-out.h (class ui_out) <field_fmt>: New overload.
3262         <do_field_fmt>: Add style parameter.
3263         * ui-out.c (ui_out::field_fmt): New overload.
3264         * typeprint.c (type_print_unknown_return_type)
3265         (val_print_not_allocated, val_print_not_associated): Use metadata
3266         style.
3267         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3268         parameter.
3269         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3270         * tracepoint.c (tvariables_info_1): Use metadata style.
3271         * stack.c (print_frame_arg, print_frame_info, print_frame)
3272         (info_frame_command_core): Use metadata style.
3273         * skip.c (info_skip_command): Use metadata style.
3274         * rust-lang.c (rust_print_enum): Use metadata style.
3275         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3276         metadata style.
3277         * python/py-framefilter.c (py_print_single_arg): Use metadata
3278         style.
3279         * printcmd.c (do_one_display, print_variable_and_value): Use
3280         metadata style.
3281         * p-valprint.c (pascal_val_print)
3282         (pascal_object_print_value_fields): Use metadata style.
3283         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3284         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3285         parameter.
3286         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3287         * m2-valprint.c (m2_print_long_set): Use metadata style.
3288         * m2-typeprint.c (m2_print_type): Use metadata style.
3289         * infcmd.c (print_return_value_1): Use metadata style.
3290         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3291         * f-valprint.c (info_common_command_for_block): Use metadata
3292         style.
3293         * f-typeprint.c (f_type_print_base): Use metadata style.
3294         * expprint.c (print_subexp_standard): Use metadata style.
3295         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3296         * cli/cli-style.h (class cli_style_option): Add constructor.
3297         (metadata_style): Declare.
3298         * cli/cli-style.c (metadata_style): New global.
3299         (_initialize_cli_style): Register metadata style.
3300         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3301         parameter.
3302         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3303         * c-typeprint.c (c_type_print_base_struct_union)
3304         (c_type_print_base_1): Use metadata style.
3305         * breakpoint.c (watchpoint_value_print)
3306         (print_one_breakpoint_location): Use metadata style.
3307         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3308         style.
3309         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3310         style.
3311         * ada-valprint.c (val_print_packed_array_elements, printstr)
3312         (print_field_values, ada_val_print_ref, ada_val_print): Use
3313         metadata style.
3314         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3315         style.
3316         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3317         style.
3318         * ada-lang.c (user_select_syms): Use metadata style.
3319
3320 2019-10-01  Tom Tromey  <tom@tromey.com>
3321
3322         * cli/cli-cmds.c (pwd_command): Style output.
3323
3324 2019-10-01  Pedro Alves  <palves@redhat.com>
3325             Tom Tromey  <tom@tromey.com>
3326
3327         * symtab.c (print_symbol_info): Use %ps.
3328         (print_msymbol_info): Use %ps.
3329         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3330         * printcmd.c (print_variable_and_value): Use %ps.
3331         * macrocmd.c (show_pp_source_pos): Use %ps.
3332         * infrun.c (print_exited_reason): Use ui_out::message.
3333         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3334         (describe_other_breakpoints): Use ui_out::message and new
3335         formats.
3336         (say_where): Use new formats.
3337         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3338         and new formats.
3339
3340 2019-10-01  Pedro Alves  <palves@redhat.com>
3341             Tom Tromey  <tom@tromey.com>
3342
3343         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3344         (test_gdb_formats): New function.
3345         (run_tests): Call it.
3346         (test_format_specifier): Update.
3347         * utils.h (fputs_filtered): Update comment.
3348         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3349         (fputs_styled_unfiltered): Declare.
3350         * utils.c (fputs_styled_unfiltered): New function.
3351         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3352         (vfprintf_filtered): Update.
3353         (vfprintf_unfiltered, vprintf_filtered): Update.
3354         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3355         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3356         disallow_ui_out_field>: New constants.
3357         (enum class field_kind): New.
3358         (struct base_field_s, struct signed_field_s): New.
3359         (signed_field): New function.
3360         (struct string_field_s): New.
3361         (string_field): New function.
3362         (struct styled_string_s): New.
3363         (styled_string): New function.
3364         (class ui_out) <message>: Add comment.
3365         <vmessage, call_do_message>: New methods.
3366         <do_message>: Add style parameter.
3367         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3368         methods.
3369         (ui_out::message): Rewrite.
3370         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3371         parameter.
3372         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3373         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3374         gdb_extensions parameter.
3375         (class format_piece): Add parameter to constructor.
3376         (n_int_args): New field.
3377         * gdbsupport/format.c (format_pieces::format_pieces): Add
3378         gdb_extensions parameter.  Handle '*'.
3379         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3380         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3381         vfprintf_styled_no_gdbfmt.
3382         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3383         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3384         unfiltered output.
3385         * ui-style.h (struct ui_file_style) <ptr>: New method.
3386
3387 2019-10-01  Tom Tromey  <tom@tromey.com>
3388
3389         * unittests/format_pieces-selftests.c: Update.  Add final format.
3390         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3391         empty literal pieces.
3392
3393 2019-10-01  Tom Tromey  <tom@tromey.com>
3394
3395         * ui-out.h (enum class ui_out_style_kind): Remove.
3396         (class ui_out) <field_string, field_stsream, do_field_string>:
3397         Change type of "style".
3398         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3399         (ui_out::field_string): Update.
3400         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3401         of "style".
3402         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3403         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3404         * stack.c (print_frame_arg, print_frame_info, print_frame):
3405         Update.
3406         * source.c (print_source_lines_base): Update.
3407         * solib.c (info_sharedlibrary_command): Update.
3408         * skip.c (info_skip_command): Update.
3409         * record-btrace.c (btrace_call_history_src_line)
3410         (btrace_call_history): Update.
3411         * python/py-framefilter.c (py_print_frame): Update.
3412         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3413         "style".
3414         * mi/mi-out.c (mi_ui_out::do_table_header)
3415         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3416         (mi_ui_out::do_field_string): Update.
3417         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3418         Update.
3419         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3420         "style".
3421         * cli-out.c (cli_ui_out::do_table_header)
3422         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3423         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3424         (cli_ui_out::do_field_fmt): Update.
3425         * breakpoint.c (print_breakpoint_location): Update.
3426         (update_static_tracepoint): Update.
3427
3428 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3429
3430         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3431         conversion of gdb_datadir.
3432         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3433         remove not needed c_str ().
3434
3435 2019-09-30  Ali Tamur <tamur@google.com>
3436
3437         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3438         (dwarf2_string_attr): Likewise.
3439
3440 2019-09-30  Ali Tamur <tamur@google.com>
3441
3442         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3443         (process_full_type_unit): Likewise.
3444         (dump_die_shallow): Likewise.
3445         (cu_debug_loc_section): Likewise.
3446
3447 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3448
3449         * minsyms.c (compare_minimal_symbols): Rename to...
3450         (minimal_symbol_is_less_than): ...this, and adjust to STL
3451         conventions (return bool, take arguments as references)
3452         (minimal_symbol_reader::install): Call std::sort instead
3453         of qsort.
3454
3455 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3456
3457         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3458         hash and why.
3459         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3460         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3461
3462 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3463
3464         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3465         * psympriv.h (add_psymbol_to_list): Move comment here and update
3466         it.
3467
3468 2019-09-29  Tom de Vries  <tdevries@suse.de>
3469
3470         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3471         Use $tmpdir/$(basename "$output_file").dwz instead of
3472         "${output_file}.dwz".
3473
3474 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3475
3476         PR gdb/25045
3477         * hppa-linux-nat.c: Include gdbarch.h.
3478
3479 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3480
3481         * blockframe.c (find_pc_partial_function): Change return type to bool.
3482         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3483         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3484         (stub_gnu_ifunc_resolve_name): Likewise.
3485         * symtab.c (compare_filenames_for_search): Likewise.
3486         (compare_glob_filenames_for_search): Likewise.
3487         (matching_obj_sections): Likewise.
3488         (symbol_matches_domain): Likewise.
3489         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3490         (find_line_pc): Change return type to bool.
3491         (find_line_pc_range): Likewise.
3492         (producer_is_realview): Likewise.
3493         * symtab.h (symbol_matches_domain): Likewise.
3494         (find_pc_partial_function): Likewise.
3495         (find_pc_line_pc_range): Likewise.
3496         (in_gnu_ifunc_stub): Likewise.
3497         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3498         (find_line_pc): Likewise.
3499         (find_line_pc_range): Likewise.
3500         (matching_obj_sections): Likewise.
3501         (find_line_symtab): Change out parameter to bool.
3502         (producer_is_realview): Change return type to bool.
3503         (compare_filenames_for_search): Likewise.
3504         (compare_glob_filenames_for_search): Likewise.
3505
3506 2019-09-26  Tom Tromey  <tom@tromey.com>
3507
3508         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3509         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3510         * gdb_usleep.h: Remove.
3511         * gdb_usleep.c: Remove.
3512         * utils.c: Don't include gdb_usleep.h.
3513
3514 2019-09-26  Tom Tromey  <tromey@adacore.com>
3515
3516         * python/py-type.c (type_to_type_object): Call check_typedef
3517         for stub types.
3518
3519 2019-09-26  Tom Tromey  <tom@tromey.com>
3520
3521         * utils.h (initialize_utils): Don't declare.
3522         * top.c (gdb_init): Don't call initialize_utils.
3523         * utils.c (initialize_utils): Remove.  Move contents...
3524         (_initialize_utils): ... here.
3525
3526 2019-09-25  Tom Tromey  <tom@tromey.com>
3527
3528         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3529         * utils.h (make_hex_string): Don't declare.
3530         * utils.c (make_hex_string): Remove.
3531
3532 2019-09-24  Tom de Vries  <tdevries@suse.de>
3533
3534         PR gdb/23815
3535         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3536         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3537
3538 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3539
3540         * NEWS: Mention new simulator port for PRU.
3541
3542 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3543
3544         * ada-exp.y (write_object_remaining): Update.
3545         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3546         and eliminate the static buffer.
3547         (ada_decode_symbol): Update.
3548         (ada_la_decode): Update.
3549         (ada_sniff_from_mangled_name): Update.
3550         (is_valid_name_for_wild_match): Update.
3551         (ada_lookup_name_info::matches): Update and simplify.
3552         (name_matches_regex): Update.
3553         (ada_add_global_exceptions): Update.
3554         * ada-lang.h (ada_decode): Update signature.
3555         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3556         * dwarf-index-write.c (debug_names::insert): Update.
3557
3558 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3559
3560         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3561         formatting.
3562
3563 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3564
3565         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3566         Change "nonzero" to "true" in documentation.
3567
3568 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3569
3570         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3571         (_initialize_darwin_solib): Don't set
3572         darwin_so_ops.lookup_lib_global_symbol.
3573         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3574         set_gdbarch_iterate_over_objfiles_in_search_order.
3575         (elf_lookup_lib_symbol): Rename to...
3576         (svr4_iterate_over_objfiles_in_search_order): this, and update
3577         to iterate semantics.
3578         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3579         * solib.c (solib_global_lookup): Remove.
3580         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3581         (solib_global_lookup): Remove.
3582         * symtab.c (lookup_global_or_static_symbol): Remove call to
3583         solib_global_lookup.
3584
3585 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3586
3587         * NEWS: Move entries about default MI version now being
3588         version 3, and about the GDB/MI fix for multi-location
3589         breakpoints to the "since GDB 8.3" section.
3590
3591 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3592
3593         GDB 8.3.1 released.
3594
3595 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3596
3597         * NEWS: Mention that Cell/B.E. debugging support was removed.
3598         * MAINTAINERS: Remove spu target.
3599
3600         * config/djgpp/fnchange.lst: Remove entries for removed files.
3601
3602         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3603         spu-multiarch.o, and spu-tdep.o.
3604         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3605         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3606         spu-multiarch.c, and spu-tdep.c.
3607         * spu-linux-nat.c: Remove file.
3608         * spu-multiarch.c: Remove file.
3609         * spu-tdep.c: Remove file.
3610         * spu-tdep.h: Remove file.
3611         * solib-spu.c: Remove file.
3612         * solib-spu.h: Remove file.
3613
3614         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3615         * configure.nat (spu-linux): Remove.
3616         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3617         solib-multiarch.o from gdb_target_obs.
3618         (spu*-*-*): Remove.
3619
3620         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3621         feature flag.
3622         (ppc_linux_no_features): Update.
3623         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3624         Cell/B.E. support.
3625         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3626         (tdesc_powerpc_cell64l): Likewise.
3627         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3628         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3629         Cell/B.E. support.
3630         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3631         Do not include "features/rs6000/powerpc-cell32l.c" or
3632         "features/rs6000/powerpc-cell64l.c".
3633         (ppc_linux_spu_section): Remove.
3634         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3635         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3636         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3637         (ppc_linux_spe_context_lookup): Remove.
3638         (ppc_linux_spe_context_inferior_created): Remove.
3639         (ppc_linux_spe_context_solib_loaded): Remove.
3640         (ppc_linux_spe_context_solib_unloaded): Remove.
3641         (ppc_linux_spe_context): Remove.
3642         (struct ppu2spu_cache): Remove.
3643         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3644         (struct ppu2spu_data): Remove.
3645         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3646         ppu2spu_unwind): Remove.
3647         (ppc_linux_init_abi): Remove Cell/B.E. support.
3648         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3649
3650         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3651         (rs6000/powerpc-cell64l-expedite): Likewise
3652         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3653         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3654         rs6000/powerpc-cell64l.xml.
3655         * features/rs6000/powerpc-cell32l.xml: Remove.
3656         * features/rs6000/powerpc-cell64l.xml: Likewise.
3657         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3658         * features/rs6000/powerpc-cell64l.c: Likewise.
3659         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3660         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3661         * regformats/reg-spu.dat: Remove.
3662
3663         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3664         * corelow.c (struct spuid_list): Remove.
3665         (add_to_spuid_list): Remove.
3666         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3667         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3668         (remote_protocol_features): Remove associated entries.
3669         (_initialize_remote): No longer initialize them.
3670         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3671         * linux-nat.c (SPUFS_MAGIC): Remove.
3672         (linux_proc_xfer_spu): Remove.
3673         (spu_enumerate_spu_ids): Remove.
3674         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3675         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3676         (linux_make_corefile_notes): No longer call it.
3677
3678         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3679         (cooked_write_test): Likewise.
3680
3681 2019-09-20  Tom Tromey  <tom@tromey.com>
3682
3683         * NEWS: Mention case-sensitivity of TUI commands.
3684         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3685         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3686         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3687
3688 2019-09-20  Tom Tromey  <tom@tromey.com>
3689
3690         * tui/tui-source.c (tui_source_window::set_contents): Use
3691         make_unique_xstrdup.
3692         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3693         make_unique_xstrdup.
3694
3695 2019-09-20  Tom Tromey  <tom@tromey.com>
3696
3697         * tui/tui-data.c: Remove separator comments.
3698         * tui/tui-layout.c: Remove separator comments.
3699         * tui/tui-win.c: Remove separator comments.
3700         * tui/tui-wingeneral.c: Remove separator comments.
3701
3702 2019-09-20  Tom Tromey  <tom@tromey.com>
3703
3704         * tui/tui.h (strcat_to_buf): Don't declare.
3705         * tui/tui.c (strcat_to_buf): Remove.
3706
3707 2019-09-20  Tom Tromey  <tom@tromey.com>
3708
3709         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3710         from "fullname".
3711         * tui/tui-source.c (tui_source_window::set_contents)
3712         (tui_source_window::location_matches_p)
3713         (tui_source_window::maybe_update): Update.
3714
3715 2019-09-20  Tom Tromey  <tom@tromey.com>
3716
3717         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3718         Update.
3719         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3720         prefix.
3721         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3722         (tui_data_window::line_from_reg_element_no)
3723         (tui_data_window::first_reg_element_no_inline)
3724         (tui_data_window::show_registers)
3725         (tui_data_window::show_register_group)
3726         (tui_data_window::display_registers_from)
3727         (tui_data_window::display_registers_from_line)
3728         (tui_data_window::first_data_item_displayed)
3729         (tui_data_window::delete_data_content_windows)
3730         (tui_data_window::erase_data_content)
3731         (tui_data_window::do_scroll_vertical)
3732         (tui_data_window::refresh_window)
3733         (tui_data_window::check_register_values): Update.
3734
3735 2019-09-20  Tom Tromey  <tom@tromey.com>
3736
3737         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3738         (struct tui_locator_window) <full_name, proc_name>: Now
3739         std::string.
3740         * tui/tui-stack.c (tui_locator_window::make_status_line)
3741         (tui_locator_window::set_locator_fullname)
3742         (tui_locator_window::set_locator_info): Update.
3743         * tui/tui-source.c (tui_source_window::set_contents)
3744         (tui_source_window::showing_source_p): Update.
3745
3746 2019-09-20  Tom Tromey  <tom@tromey.com>
3747
3748         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3749         Don't call tui_locator_win_info_ptr.
3750
3751 2019-09-20  Tom Tromey  <tom@tromey.com>
3752
3753         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3754
3755 2019-09-20  Tom Tromey  <tom@tromey.com>
3756
3757         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3758         height for locator.
3759         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3760         * tui/tui-layout.c (show_source_disasm_command, show_data)
3761         (show_source_or_disasm_and_command): Use 1 as height for locator.
3762
3763 2019-09-20  Tom Tromey  <tom@tromey.com>
3764
3765         * tui/tui.c (tui_enable): Update.
3766         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3767         Update.
3768         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3769         Update.
3770         * tui/tui-data.c (win_resized): Now bool.
3771         (tui_win_resized): Return bool.
3772         (tui_set_win_resized_to): Accept a bool.
3773
3774 2019-09-20  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3777         Change type of "refresh_values_only".
3778         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3779         type of "refresh_values_only".
3780
3781 2019-09-20  Tom Tromey  <tom@tromey.com>
3782
3783         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3784         std::string.
3785         (tui_disassemble): Add "pos" parameter.
3786         (tui_disasm_window::set_contents): Simplify.
3787
3788 2019-09-20  Tom Tromey  <tom@tromey.com>
3789
3790         * tui/tui-winsource.h (struct tui_source_window_base)
3791         <show_source_content>: Now private.
3792         * tui/tui-winsource.c
3793         (tui_source_window_base::show_source_content): Don't handle empty
3794         content case.
3795
3796 2019-09-20  Tom Tromey  <tom@tromey.com>
3797
3798         * tui/tui-layout.c (show_source_disasm_command)
3799         (show_source_or_disasm_and_command): Don't call
3800         show_source_content.
3801
3802 2019-09-20  Tom Tromey  <tom@tromey.com>
3803
3804         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3805         Declare.
3806         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3807         from tui_make_status_line.
3808         (tui_locator_window::rerender): Update.
3809
3810 2019-09-20  Tom Tromey  <tom@tromey.com>
3811
3812         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3813         (tui_locator_window::rerender): Update.
3814
3815 2019-09-20  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-winsource.h (struct tui_source_window_base)
3818         <~tui_source_window_base>: Don't declare.
3819         <fullname>: Remove.
3820         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3821         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3822         member.
3823         * tui/tui-source.c (tui_source_window::set_contents): Update.
3824         (tui_source_window::location_matches_p)
3825         (tui_source_window::maybe_update): Update.
3826
3827 2019-09-20  Tom Tromey  <tom@tromey.com>
3828
3829         * tui/tui-winsource.h (~tui_source_element): Remove.
3830         (tui_source_element): Update.
3831         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3832         * tui/tui-winsource.c (tui_show_source_line): Update.
3833         * tui/tui-source.c (tui_source_window::set_contents): Update.
3834         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3835
3836 2019-09-20  Tom Tromey  <tom@tromey.com>
3837
3838         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3839         declare.
3840         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3841         tui_clear_source_windows_detail.
3842         * tui/tui-winsource.h (struct tui_source_window_base)
3843         <clear_detail>: Don't declare.
3844         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3845         Remove.
3846         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3847
3848 2019-09-20  Tom Tromey  <tromey@adacore.com>
3849
3850         PR ada/24919:
3851         * block.c (contained_in): Fix final return value.
3852
3853 2019-09-20  Alan Modra  <amodra@gmail.com>
3854
3855         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3856         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3857         (read_indirect_string_from_dwz): Use bfd accessor.
3858         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3859         * machoread.c (macho_symfile_read_all_oso): Likewise.
3860         * solib.c (solib_bfd_open): Likewise.
3861
3862 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3863
3864         * eval.c: Move declaration of overload_resolution to...
3865         * value.h: ...here.
3866
3867 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3868
3869         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3870         * arm-linux-tdep.c: Likewise.
3871         * arm-nbsd-nat.c: Likewise.
3872         * arm-tdep.h: Declare arm_apcs_32.
3873         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3874
3875 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3876
3877         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3878         * dwarf2read.h: Declare dwarf_always_disassemble.
3879
3880 2019-09-19  Tom de Vries  <tdevries@suse.de>
3881
3882         PR gdb/25009
3883         * source-cache.c (source_cache::ensure): Catch exception thrown during
3884         construction of the highlighter.
3885
3886 2019-09-18  Alan Modra  <amodra@gmail.com>
3887
3888         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3889         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3890         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3891         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3892         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3893         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3894         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3895         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3896         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3897         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3898         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3899         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3900         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3901         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3902         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3903         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3904         * mi/mi-interp.c: Update throughout for bfd section macro and
3905         function changes.
3906         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3907         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3908
3909 2019-09-18  Tom Tromey  <tom@tromey.com>
3910
3911         * NEWS: Add entry.
3912         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3913         call rl_initialize.
3914         (tui_enable): Do not call rl_initialize.
3915
3916 2019-09-18  Christian Groessler  <chris@groessler.org>
3917
3918         * alpha-linux-nat.c: Include gdbarch.h.
3919
3920 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3921
3922         * ui-file.c: Include cli/cli-style.h.
3923         (term_cli_styling): Remove cli_styling declaration.
3924
3925 2019-09-18  Alan Modra  <amodra@gmail.com>
3926
3927         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3928         to bfd_asymbol_section.
3929
3930 2019-09-18  Alan Modra  <amodra@gmail.com>
3931
3932         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3933         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3934         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3935
3936 2019-09-18  Alan Modra  <amodra@gmail.com>
3937
3938         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3939         * spu-linux-nat.c (spu_bfd_open): Likewise.
3940
3941 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3942
3943         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3944         to bool to match definition in dwarf2read.c.
3945
3946 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3947
3948         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3949         (print_signatures): Likewise.
3950         (trust_pad_over_xvs): Likewise.
3951         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3952         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3953         * arm-linux-nat.c (arm_apcs_32): Likewise.
3954         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3955         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3956         * arm-tdep.c (arm_debug): Likewise.
3957         (arm_apcs_32): Likewise.
3958         * auto-load.c (debug_auto_load): Likewise.
3959         (auto_load_gdb_scripts): Likewise.
3960         (global_auto_load): Likewise.
3961         (auto_load_local_gdbinit): Likewise.
3962         (auto_load_local_gdbinit_loaded): Likewise.
3963         * auto-load.h (global_auto_load): Likewise.
3964         (auto_load_local_gdbinit): Likewise.
3965         (auto_load_local_gdbinit_loaded): Likewise.
3966         * breakpoint.c (disconnected_dprintf): Likewise.
3967         (breakpoint_proceeded): Likewise.
3968         (automatic_hardware_breakpoints): Likewise.
3969         (always_inserted_mode): Likewise.
3970         (target_exact_watchpoints): Likewise.
3971         (_initialize_breakpoint): Update.
3972         * breakpoint.h (target_exact_watchpoints): Change to bool.
3973         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3974         * cli/cli-cmds.c (trace_commands): Likewise.
3975         * cli/cli-cmds.h (trace_commands): Likewise.
3976         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3977         to bool*.
3978         * cli/cli-logging.c (logging_overwrite): Change to bool.
3979         (logging_redirect): Likewise.
3980         (debug_redirect): Likewise.
3981         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3982         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3983         to bool.
3984         <boolean_option_def>: Update.
3985         (struct flag_option_def): Change default type of Context to bool
3986         from int.
3987         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3988         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3989         (get_setshow_command_value_string): Likewise.
3990         * cli/cli-style.c (cli_styling): Change to bool.
3991         (source_styling): Likewise.
3992         * cli/cli-style.h (source_styling): Likewise.
3993         (cli_styling): Likewise.
3994         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3995         to bool.
3996         * command.h (var_types): Update comment.
3997         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3998         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3999         bool.
4000         (debug_compile_cplus_scopes): Likewise.
4001         * compile/compile-internal.h (compile_debug): Likewise.
4002         * compile/compile.c (compile_debug): Likewise.
4003         (struct compile_options) <raw>: Likewise.
4004         * cp-support.c (catch_demangler_crashes): Likewise.
4005         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4006         (usr_cmd_cris_dwarf2_cfi): Likewise.
4007         * csky-tdep.c (csky_debug): Likewise.
4008         * darwin-nat.c (enable_mach_exceptions): Likewise.
4009         * dcache.c (dcache_enabled_p): Likewise.
4010         * defs.h (info_verbose): Likewise.
4011         * demangle.c (demangle): Likewise.
4012         (asm_demangle): Likewise.
4013         * dwarf-index-cache.c (debug_index_cache): Likewise.
4014         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4015         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4016         * dwarf2read.c (check_physname): Likewise.
4017         (use_deprecated_index_sections): Likewise.
4018         (dwarf_always_disassemble): Likewise.
4019         * eval.c (overload_resolution): Likewise.
4020         * event-top.c (set_editing_cmd_var): Likewise.
4021         (exec_done_display_p): Likewise.
4022         * event-top.h (set_editing_cmd_var): Likewise.
4023         (exec_done_display_p): Likewise.
4024         * exec.c (write_files): Likewise.
4025         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4026         (debug_fbsd_nat): Likewise.
4027         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4028         Likewise.
4029         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4030         <backtrace_past_entry> Likewise.
4031         * gdb-demangle.h (demangle): Likewise.
4032         (asm_demangle): Likewise.
4033         * gdb_bfd.c (bfd_sharing): Likewise.
4034         * gdbcore.h (write_files): Likewise.
4035         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4036         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4037         * gdbthread.h (print_thread_events): Likewise.
4038         * gdbtypes.c (opaque_type_resolution): Likewise.
4039         (strict_type_checking): Likewise.
4040         * gnu-nat.c (gnu_debug_flag): Likewise.
4041         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4042         * guile/scm-param.c (pascm_variable): Add boolval.
4043         (add_setshow_generic): Update.
4044         (pascm_param_value): Update.
4045         (pascm_set_param_value_x): Update.
4046         * hppa-tdep.c (hppa_debug): Change to bool..
4047         * infcall.c (may_call_functions_p): Likewise.
4048         (coerce_float_to_double_p): Likewise.
4049         (unwind_on_signal_p): Likewise.
4050         (unwind_on_terminating_exception_p): Likewise.
4051         * infcmd.c (startup_with_shell): Likewise.
4052         * inferior.c (print_inferior_events): Likewise.
4053         * inferior.h (startup_with_shell): Likewise.
4054         (print_inferior_events): Likewise.
4055         * infrun.c (step_stop_if_no_debug): Likewise.
4056         (detach_fork): Likewise.
4057         (debug_displaced): Likewise.
4058         (disable_randomization): Likewise.
4059         (non_stop): Likewise.
4060         (non_stop_1): Likewise.
4061         (observer_mode): Likewise.
4062         (observer_mode_1): Likewise.
4063         (set_observer_mode): Update.
4064         (sched_multi): Change to bool.
4065         * infrun.h (debug_displaced): Likewise.
4066         (sched_multi): Likewise.
4067         (step_stop_if_no_debug): Likewise.
4068         (non_stop): Likewise.
4069         (disable_randomization): Likewise.
4070         * linux-tdep.c (use_coredump_filter): Likewise.
4071         (dump_excluded_mappings): Likewise.
4072         * linux-thread-db.c (auto_load_thread_db): Likewise.
4073         (check_thread_db_on_load): Likewise.
4074         * main.c (captured_main_1): Update.
4075         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4076         xx2_opt, boolean_opt>: Change to bool.
4077         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4078         * maint.c (maintenance_profile_p): Likewise.
4079         (per_command_time): Likewise.
4080         (per_command_space): Likewise.
4081         (per_command_symtab): Likewise.
4082         * memattr.c (inaccessible_by_default): Likewise.
4083         * mi/mi-main.c (mi_async): Likewise.
4084         (mi_async_1): Likewise.
4085         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4086         * nat/fork-inferior.h (startup_with_shell): Likewise.
4087         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4088         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4089         * nios2-tdep.c (nios2_debug): Likewise.
4090         * or1k-tdep.c (or1k_debug): Likewise.
4091         * parse.c (parser_debug): Likewise.
4092         * parser-defs.h (parser_debug): Likewise.
4093         * printcmd.c (print_symbol_filename): Likewise.
4094         * proc-api.c (procfs_trace): Likewise.
4095         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4096         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4097         (set_parameter_value): Update.
4098         (add_setshow_generic): Update.
4099         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4100         to bool*.
4101         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4102         int*.
4103         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4104         * record-btrace.c (record_btrace_target::store_registers): Update.
4105         * record-full.c (record_full_memory_query): Change to bool.
4106         (record_full_stop_at_limit): Likewise.
4107         * record-full.h (record_full_memory_query): Likewise.
4108         * remote-notif.c (notif_debug): Likewise.
4109         * remote-notif.h (notif_debug): Likewise.
4110         * remote.c (use_range_stepping): Likewise.
4111         (interrupt_on_connect): Likewise.
4112         (remote_break): Likewise.
4113         * ser-tcp.c (tcp_auto_retry): Likewise.
4114         * ser-unix.c (serial_hwflow): Likewise.
4115         * skip.c (debug_skip): Likewise.
4116         * solib-aix.c (solib_aix_debug): Likewise.
4117         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4118         (spu_auto_flush_cache_p): Likewise.
4119         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4120         Likewise.
4121         (struct info_print_options) <quiet>: Likewise.
4122         * symfile-debug.c (debug_symfile): Likewise.
4123         * symfile.c (auto_solib_add): Likewise.
4124         (separate_debug_file_debug): Likewise.
4125         * symfile.h (auto_solib_add): Likewise.
4126         (separate_debug_file_debug): Likewise.
4127         * symtab.c (basenames_may_differ): Likewise.
4128         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4129         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4130         (struct info_types_options) <quiet>: Likewise.
4131         * symtab.h (demangle): Likewise.
4132         (basenames_may_differ): Likewise.
4133         * target-dcache.c (stack_cache_enabled_1): Likewise.
4134         (code_cache_enabled_1): Likewise.
4135         * target.c (trust_readonly): Likewise.
4136         (may_write_registers): Likewise.
4137         (may_write_memory): Likewise.
4138         (may_insert_breakpoints): Likewise.
4139         (may_insert_tracepoints): Likewise.
4140         (may_insert_fast_tracepoints): Likewise.
4141         (may_stop): Likewise.
4142         (auto_connect_native_target): Likewise.
4143         (target_stop_and_wait): Update.
4144         (target_async_permitted): Change to bool.
4145         (target_async_permitted_1): Likewise.
4146         (may_write_registers_1): Likewise.
4147         (may_write_memory_1): Likewise.
4148         (may_insert_breakpoints_1): Likewise.
4149         (may_insert_tracepoints_1): Likewise.
4150         (may_insert_fast_tracepoints_1): Likewise.
4151         (may_stop_1): Likewise.
4152         * target.h (target_async_permitted): Likewise.
4153         (may_write_registers): Likewise.
4154         (may_write_memory): Likewise.
4155         (may_insert_breakpoints): Likewise.
4156         (may_insert_tracepoints): Likewise.
4157         (may_insert_fast_tracepoints): Likewise.
4158         (may_stop): Likewise.
4159         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4160         (make_thread_apply_all_options_def_group): Change argument from int*
4161         to bool*.
4162         (thread_apply_all_command): Update.
4163         (print_thread_events): Change to bool.
4164         * top.c (confirm): Likewise.
4165         (command_editing_p): Likewise.
4166         (history_expansion_p): Likewise.
4167         (write_history_p): Likewise.
4168         (info_verbose): Likewise.
4169         * top.h (confirm): Likewise.
4170         (history_expansion_p): Likewise.
4171         * tracepoint.c (disconnected_tracing): Likewise.
4172         (circular_trace_buffer): Likewise.
4173         * typeprint.c (print_methods): Likewise.
4174         (print_typedefs): Likewise.
4175         * utils.c (debug_timestamp): Likewise.
4176         (sevenbit_strings): Likewise.
4177         (pagination_enabled): Likewise.
4178         * utils.h (sevenbit_strings): Likewise.
4179         (pagination_enabled): Likewise.
4180         * valops.c (overload_resolution): Likewise.
4181         * valprint.h (struct value_print_options) <prettyformat_arrays,
4182         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4183         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4184         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4185         Likewise.
4186         * windows-nat.c (new_console): Likewise.
4187         (cygwin_exceptions): Likewise.
4188         (new_group): Likewise.
4189         (debug_exec): Likewise.
4190         (debug_events): Likewise.
4191         (debug_memory): Likewise.
4192         (debug_exceptions): Likewise.
4193         (useshell): Likewise.
4194         * windows-tdep.c (maint_display_all_tib): Likewise.
4195         * xml-support.c (debug_xml): Likewise.
4196
4197 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4198
4199         * source.c (prepare_path_for_appending): New function.
4200         (openp): Make use of new function.
4201         (find_and_open_source): Search for the compilation directory and
4202         source file as a relative path beneath the directory search path.
4203
4204 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4205
4206         * source-cache.c (source_cache::get_line_charpos): Catch
4207         exceptions and return false, this matches the behaviour documented
4208         in the header file.
4209
4210 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4211
4212         * ada-tasks.c (info_task): Remove quoting of the task's name.
4213
4214 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4215
4216         * symfile.c (auto_solib_add): Replace comment with a reference
4217         to the header file.
4218
4219 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4220
4221         * NEWS: Mention that gdb can now be compiled with Python 3
4222         on Windows.
4223
4224 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4225
4226         * maint.c (maint_print_section_data::maint_print_section_data):
4227         Force use of 'float log10 (float)' by casting the argument to
4228         float.
4229
4230 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4231
4232         * maint.c: Add 'cmath' include.
4233         (struct maint_print_section_data): New structure.
4234         (print_section_index): New function.
4235         (print_bfd_section_info): Add header comment, small whitespace
4236         cleanup, and update to call new print_section_index function.
4237         (print_objfile_section_info): Likewise.
4238         (maint_obj_section_from_bfd_section): New function.
4239         (print_bfd_section_info_maybe_relocated): New function.
4240         (maintenance_info_sections): Add header comment, always use
4241         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4242
4243 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4244
4245         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4246         inner scope, add check that the objfile has psymtabs before
4247         checking psymtabs_addrmap.
4248         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4249
4250 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4251
4252         * NEWS: Announce that Ada task names are now shown at more places,
4253         and between quotes (except in info task output).
4254         * gdb/ada-tasks.c (task_to_str): New function.
4255         (display_current_task_id): Call task_to_str.
4256         (task_command_1): Likewise.
4257         (print_ada_task_info): In non-mi mode, Properly align headers and data
4258         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4259
4260 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4261
4262         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4263         prstatus.pr_lwp.pr_info instead of making it up.
4264
4265 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4266
4267         * auto-load.c (auto_load_expand_dir_vars): Update.
4268         * defs.h (gdb_datadir): Change to std::string.
4269         (python_libdir): Likewise.
4270         (relocate_gdb_directory): Change return type to std::string.
4271         * guile/guile.c (gdbscm_data_directory): Update.
4272         (initialize_scheme_side): Update.
4273         * jit.c (jit_reader_dir): Change to std::string.
4274         (jit_reader_load_command): Update.
4275         * main.c (gdb_datadir): Change to std::string.
4276         (python_libdir): Likewise.
4277         (set_gdb_data_directory): Update.
4278         (relocate_path): Change to return std::string.
4279         (relocate_gdb_directory): Change to return std::string.
4280         (relocate_gdbinit_path_maybe_in_datadir): Update.
4281         (captured_main_1): Update.
4282         * python/python.c (do_start_initialization): Update.
4283         * top.c (show_gdb_datadir): Update.
4284         * xml-syscall.c (xml_init_syscalls_info): Update.
4285         (init_syscalls_info): Update.
4286
4287 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4288
4289         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4290         out of get_init_files.
4291         (get_init_files): Update.
4292
4293 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4294
4295         * main.c (get_init_files): Change to use std::string.
4296         (captured_main_1): Update.
4297         (print_gdb_help): Update.
4298
4299 2019-09-11  Ali Tamur  <tamur@google.com>
4300
4301         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4302         implementation.
4303
4304 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4305
4306         * dbxread.c (read_dbx_symtab): Update.
4307         * dwarf2read.c (load_partial_dies): Update.
4308         * mdebugread.c (parse_partial_symbols): Update.
4309         (handle_psymbol_enumerators): Update.
4310         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4311         * psymtab.c (add_psymbol_to_bcache): Likewise.
4312         (add_psymbol_to_list): Likewise.
4313         * symtab.c (symbol_set_names): Likewise.
4314         * symtab.h (symbol_set_names): Likewise.
4315         * xcoffread.c (scan_xcoff_symtab): Update.
4316
4317 2019-09-11  Tom Tromey  <tom@tromey.com>
4318
4319         * symfile-mem.c (symbol_file_add_from_memory): Use
4320         bfd_set_filename.
4321         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4322         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4323
4324 2019-09-10  Tom Tromey  <tromey@adacore.com>
4325
4326         * dwarf-index-write.c (write_psymbols): Extend error message.
4327         (debug_names::insert): Add Ada code.
4328         (debug_names::write_psymbols): Remove Ada check.
4329         (debug_names) <m_string_obstack>: New member.
4330         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4331         (gdb_index_symbol_name_matcher::matches): Remove.
4332         (mapped_index_base::find_name_components_bounds): Add "lang"
4333         parameter.
4334         (mapped_index_base::build_name_components): Also split names
4335         according to Ada syntax.
4336         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4337         type of "match_callback".
4338         (check_match, check_find_bounds_finds)
4339         (dw2_expand_symtabs_matching): Update.
4340         (dw2_debug_names_iterator): Add new constructor.
4341         (dw2_debug_names_map_matching_symbols): New function.
4342         (dw2_debug_names_expand_symtabs_matching): Update.
4343         (dwarf2_debug_names_functions): Use
4344         dw2_debug_names_map_matching_symbols.
4345
4346 2019-09-10  Tom Tromey  <tromey@adacore.com>
4347
4348         * dwarf2read.c (dw2_get_file_names_reader): Add the
4349         CU's file name to the results.
4350
4351 2019-09-10  Tom Tromey  <tromey@adacore.com>
4352
4353         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4354         map_matching_symbols.  Update.
4355         * dwarf2read.c (dw2_map_matching_symbols): Update.
4356         * psymtab.c (match_partial_symbol): Change type; update.
4357         (psym_map_matching_symbols): Likewise.
4358         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4359         type; update.
4360         * symfile.h (struct quick_symbol_functions)
4361         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4362         Remove "match".
4363
4364 2019-09-10  Tom Tromey  <tromey@adacore.com>
4365
4366         * psymtab.c (map_block): Remove.
4367         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4368         * symtab.c (iterate_over_symbols_terminated): New function.
4369         * symtab.c (iterate_over_symbols_terminated): Declare.
4370
4371 2019-09-10  Tom Tromey  <tromey@adacore.com>
4372
4373         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4374         * language.h (struct language_defn) <la_iterate_over_symbols>:
4375         Return bool.
4376         * symtab.c (iterate_over_symbols): Return bool.
4377         * symtab.h (iterate_over_symbols): Return bool.
4378
4379 2019-09-10  Tom Tromey  <tromey@adacore.com>
4380
4381         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4382         (add_nonlocal_symbols): Update.
4383         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4384         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4385         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4386         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4387         Change type of "callback".  Remove "data".
4388
4389
4390 2019-09-09  Ali Tamur  <tamur@google.com>
4391
4392         * dwarf2read.c (comp_unit_head): Update comment.
4393         (dwarf2_dwo_name): New function declaration.
4394         (dwarf_unit_type_name): New function declaration.
4395         (read_comp_unit_head): Add support for new compilation units,
4396         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4397         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4398         (currently named as "signature") in their header. Also clarify error
4399         messages.
4400         (lookup_dwo_id): New function. Returns the dwo id of the given
4401         compile unit.
4402         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4403         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4404         functions.
4405         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4406         (dwarf2_dwo_name): Get the dwo name if present.
4407         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4408         purposes.
4409
4410 2019-09-09  Tom Tromey  <tom@tromey.com>
4411
4412         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4413
4414 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4415
4416         * python/python.c (do_start_initialization): Make progname_copy static,
4417         to avoid a leak report.
4418
4419 2019-09-08  Tom Tromey  <tom@tromey.com>
4420
4421         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4422
4423 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4424
4425         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4426         Change type to gdb::optional<block_enum>.
4427         (dw2_symtab_iter_init): Change block_index parameter type
4428         to gdb::optional<block_enum>.
4429         (dw2_lookup_symbol): Change block_index parameter
4430         type to block_enum.c
4431         (dw2_debug_names_lookup_symbol): Likewise.
4432         * psymtab.c (psym_lookup_symbol): Likewise.
4433         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4434         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4435         Likewise.
4436
4437 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4438
4439         * defs.h (relocate_gdb_directory): Change int to bool in
4440         signature and rename flag to relocatable.
4441         * main.c (relocate_path): Likewise.
4442         (relocate_gdb_directory): Likewise.
4443
4444 2019-09-06  Alan Modra  <amodra@gmail.com>
4445
4446         * coffread.c (coff_symfile_read): Constify filename variable.
4447         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4448         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4449         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4450         * solib.c (reload_shared_libraries_1): Likewise.
4451         * symfile.c (reread_symbols): Likewise.
4452         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4453         * solib-darwin.c (darwin_bfd_open): Likewise.
4454         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4455
4456 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4457
4458         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4459         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4460
4461 2019-09-03  Tom Tromey  <tromey@adacore.com>
4462
4463         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4464         types.
4465         (has_negatives): Unbias a range type bound.
4466         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4467         * gdbtypes.c (operator==): Handle new field.
4468         (create_range_type): Add "bias" parameter.
4469         (create_static_range_type, resolve_dynamic_range): Update.
4470         * gdbtypes.h (struct range_bounds) <bias>: New member.
4471         (create_range_type): Add bias parameter.
4472         * printcmd.c (print_scalar_formatted): Unbias range types.
4473         * value.c (unpack_long): Unbias range types.
4474         (pack_long): Bias range types.
4475
4476 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4477
4478         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4479         probe arguments.
4480
4481 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4482
4483         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4484         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4485         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4486         (compile_probe_arg): Likewise.
4487         * probe.h (get_argument_count): Likewise.
4488         * solib-svr4.c (solib_event_probe_action): Likewise.
4489         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4490
4491 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4492
4493         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4494         code to here...
4495         (svr4_create_solib_event_breakpoints): ...from here.
4496
4497 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4498
4499         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4500         suffix from warning message.
4501
4502 2019-08-30  Tom Tromey  <tom@tromey.com>
4503
4504         * tui/tui-winsource.h (struct tui_source_window_base)
4505         <refresh_all>: Don't declare.
4506         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4507         Remove.
4508         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4509         tui_show_locator_content.
4510         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4511         declare.
4512         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4513         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4514         declare.
4515
4516 2019-08-30  Tom Tromey  <tom@tromey.com>
4517
4518         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4519
4520 2019-08-30  Tom Tromey  <tom@tromey.com>
4521
4522         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4523         Remove unnecessary forward declarations.
4524
4525 2019-08-30  Tom Tromey  <tom@tromey.com>
4526
4527         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4528         rerender.
4529         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4530         tui_show_locator_content.
4531
4532 2019-08-30  Tom Tromey  <tom@tromey.com>
4533
4534         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4535         (tui_locator_window::rerender): Rewrite using body of previous
4536         tui_show_locator_content.
4537
4538 2019-08-30  Tom Tromey  <tom@tromey.com>
4539
4540         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4541         set_locator_fullname>: New methods.
4542         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4543         Rename from tui_set_locator_fullname.
4544         (tui_locator_window::set_locator_info): Rename from
4545         tui_set_locator_info.  Return bool.
4546         (tui_update_locator_fullname, tui_show_frame_info): Update.
4547
4548 2019-08-30  Tom Tromey  <tom@tromey.com>
4549
4550         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4551
4552 2019-08-30  Tom Tromey  <tom@tromey.com>
4553
4554         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4555         call touchwin.
4556
4557 2019-08-30  Tom Tromey  <tom@tromey.com>
4558
4559         * tui/tui-wingeneral.c (box_win): Assume win_info and
4560         win_info->handle cannot be NULL.
4561
4562 2019-08-30  Tom Tromey  <tom@tromey.com>
4563
4564         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4565         refresh_window>: Declare.
4566         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4567         resize.
4568         (tui_data_item_window::rerender): Rename from
4569         tui_display_register.
4570         (tui_data_item_window::refresh_window): New method.
4571         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4572         no-op.
4573
4574 2019-08-30  Tom Tromey  <tom@tromey.com>
4575
4576         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4577         regs_column_count, current_group>: Move later.  Now private.
4578         <get_current_group>: New method.
4579         * tui/tui-regs.c (tui_reg_command): Update.
4580         * tui/tui-layout.c (tui_set_layout): Update.
4581
4582 2019-08-30  Tom Tromey  <tom@tromey.com>
4583
4584         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4585         (tui_data_window::rerender): Don't call
4586         check_and_display_highlight_if_needed.
4587         (tui_data_window::refresh_all): Remove call to
4588         erase_data_content.
4589
4590 2019-08-30  Tom Tromey  <tom@tromey.com>
4591
4592         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4593         (tui_data_window::display_registers_from)
4594         (tui_data_window::display_reg_element_at_line)
4595         (tui_data_window::display_registers_from_line): Remove checks of
4596         "empty".
4597
4598 2019-08-30  Tom Tromey  <tom@tromey.com>
4599
4600         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4601         Don't declare.
4602         * tui/tui-regs.c (tui_data_window::show_registers): Call
4603         rerender.
4604         (tui_data_window::rerender): Rename from display_all_data.
4605         (tui_data_window::rerender): Remove old implementation.
4606
4607 2019-08-30  Tom Tromey  <tom@tromey.com>
4608
4609         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4610         text.
4611         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4612
4613 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4614             Sergio Durigan Junior  <sergiodj@redhat.com>
4615
4616         PR win32/24284
4617         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4618
4619 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4620
4621         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4622         when searching for types.
4623
4624 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4625
4626         * f-lang.c (f_language_defn): Use f_print_typedef.
4627         * f-lang.h (f_print_typedef): Declare.
4628         * f-typeprint.c (f_print_typedef): Define.
4629
4630 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4631
4632         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4633
4634 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4635
4636         * cli/cli-utils.c (info_print_options_defs): Delete.
4637         (make_info_print_options_def_group): Delete.
4638         (extract_info_print_options): Delete.
4639         (info_print_command_completer): Delete.
4640         (info_print_args_help): Add extra parameter, and optionally
4641         include text about -n flag.
4642         * cli/cli-utils.h (struct info_print_options): Delete.
4643         (extract_info_print_options): Delete declaration.
4644         (info_print_command_completer): Delete declaration.
4645         (info_print_args_help): Add extra parameter, extend header
4646         comment.
4647         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4648         search_symbols.
4649         * stack.c (struct info_print_options): New type.
4650         (info_print_options_defs): New file scoped variable.
4651         (make_info_print_options_def_group): New static function.
4652         (info_print_command_completer): New static function.
4653         (info_locals_command): Update to use new local functions.
4654         (info_args_command): Likewise.
4655         (_initialize_stack): Add extra parameter to calls to
4656         info_print_args_help.
4657         * symtab.c (search_symbols): Add extra parameter, use this to
4658         possibly excluse non-debug symbols.
4659         (symtab_symbol_info): Add extra parameter, which is passed on to
4660         search_symbols.
4661         (struct info_print_options): New type.
4662         (info_print_options_defs): New file scoped variable.
4663         (make_info_print_options_def_group): New static function.
4664         (info_print_command_completer): New static function.
4665         (info_variables_command): Update to use local functions, and pass
4666         extra parameter through to symtab_symbol_info.
4667         (info_functions_command): Likewise.
4668         (info_types_command): Pass additional argument through to
4669         symtab_symbol_info.
4670         (rbreak_command): Pass extra argument to search_symbols.
4671         (_initialize_symtab): Add extra arguments for calls to
4672         info_print_args_help, and update help text for 'info variables',
4673         'whereis', and 'info functions' commands.
4674         * symtab.h (search_symbols): Add extra argument to declaration.
4675         * NEWS: Mention new flags.
4676
4677 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4678
4679         * symtab.c (lookup_static_symbol): Call the new function (and move
4680         it down to be next to lookup_global_symbol).
4681         (struct global_sym_lookup_data): Add block_enum member and rename to...
4682         (struct global_or_static_sym_lookup_data): ...this.
4683         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4684         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4685         (lookup_symbol_global_or_static_iterator_cb): ...this.
4686         (lookup_global_or_static_symbol): New function.
4687         (lookup_global_symbol): Call new function.
4688
4689 2019-08-26  Tom de Vries  <tdevries@suse.de>
4690
4691         PR c++/24852
4692         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4693         when pc_probe.prob == NULL.
4694
4695 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4696
4697         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4698         variable symbol_linkage to symbol_linkage_.
4699
4700 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4701
4702         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4703         represent whether the symbol is static, dynamic, or we don't
4704         know.
4705
4706 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4707
4708         * gdb/rx-tdep.c (rx_register_names): New.
4709         (rx_register_name): Delete.
4710         (rx_psw_type): Delete.
4711         (rx_fpsw_type): Delete.
4712         (rx_register_type): Delete.
4713         (rx_gdbarch_init): Convert target-descriptions.
4714         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4715         * gdb/features/Makefile: Add rx.xml.
4716         * gdb/features/rx.xml: New.
4717         * gdb/features/rx.c: Generated.
4718         * gdb/NEWS: Mention target description support.
4719
4720 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4721
4722         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4723         *slot_ptr.
4724
4725 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4726
4727         * configure.ac: Don't check for 'dlfcn.h' (moved to
4728         gdbsupport/common.m4).
4729         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4730         'gdbsupport/'.
4731         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4732         * compile/compile-c-support.c: Include
4733         'gdbsupport/gdb-dlfcn.h'.
4734         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4735         * gdb-dlfcn.c: Move to...
4736         * gdbsupport/gdb-dlfcn.c: ... here.
4737         * gdb-dlfcn.h: Move to...
4738         * gdbsupport/gdb-dlfcn.h: ... here.
4739
4740 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4741
4742         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4743         the offset field signed.
4744
4745 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4746
4747         * python/lib/gdb/__init__.py (_execute_file): New function.
4748         * python/python.c (python_run_simple_file): Call gdb._execute_file
4749         on Windows.
4750
4751 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4752
4753         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4754         all uses as this was never set to anything but a zero value.
4755
4756 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4757
4758         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4759
4760 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4761
4762         * tui/tui-data.h (tui_gen_win_info): Add an =default
4763         move constructor, required by some GCC versions.
4764
4765 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4766
4767         * go32-nat.c (go32_sysinfo): Add hygon_p.
4768
4769 2019-08-20  Tom Tromey  <tom@tromey.com>
4770
4771         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4772         line_from_reg_element_no, first_reg_element_no_inline,
4773         display_all_data, delete_data_content_windows,
4774         erase_data_content>: Now private.
4775
4776 2019-08-20  Tom Tromey  <tom@tromey.com>
4777
4778         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4779         (tui_unhighlight_win, tui_highlight_win)
4780         (tui_win_info::make_window): Update.
4781         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4782
4783 2019-08-20  Tom Tromey  <tom@tromey.com>
4784
4785         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4786         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4787         (MAX_PID_WIDTH): Move to tui-stack.c.
4788         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4789         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4790         (MAX_PID_WIDTH): Move from tui-data.h.
4791
4792 2019-08-20  Tom Tromey  <tom@tromey.com>
4793
4794         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4795         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4796         (box_win): Update.
4797         (tui_gen_win_info::make_window): Rename from tui_make_window.
4798         (tui_win_info::make_window): New method.
4799         (tui_gen_win_info::make_visible): Update.
4800         * tui/tui-source.c (tui_source_window::set_contents): Update.
4801         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4802         (tui_data_window::display_registers_from): Update.
4803         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4804         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4805         Declare.
4806         <can_box>: Remove.
4807         <title>: Remove.
4808         (struct tui_win_info) <make_window>: Declare.
4809         <can_box>: Now virtual.
4810         <title>: New member.
4811         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4812         * tui/tui-command.c (tui_cmd_window::resize): Update.
4813
4814 2019-08-20  Tom Tromey  <tom@tromey.com>
4815
4816         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4817         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4818         (tui_data_window::check_register_values): Update.
4819
4820 2019-08-20  Tom Tromey  <tom@tromey.com>
4821
4822         * tui/tui-regs.h (struct tui_data_window): Use
4823         DISABLE_COPY_AND_ASSIGN.
4824         <regs_content>: Change type, removing unique_ptr.
4825         <tui_data_window>: Add move constructor.
4826         * tui/tui-regs.c (tui_data_window::show_registers)
4827         (tui_data_window::show_register_group)
4828         (tui_data_window::display_registers_from)
4829         (tui_data_window::display_registers_from)
4830         (tui_data_window::first_data_item_displayed)
4831         (tui_data_window::delete_data_content_windows)
4832         (tui_data_window::rerender, tui_data_window::refresh_window)
4833         (tui_data_window::check_register_values): Update.
4834
4835 2019-08-20  Tom Tromey  <tom@tromey.com>
4836
4837         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4838         show_register_group>: Declare.
4839         (tui_show_register_group): Don't declare.
4840         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4841         tui_show_registers.
4842         (tui_data_window::show_register_group): Rename from
4843         tui_show_register_group.
4844         (tui_data_window::check_register_values, tui_reg_command):
4845         Update.
4846         * tui/tui-layout.c (tui_set_layout): Update.
4847
4848 2019-08-20  Tom Tromey  <tom@tromey.com>
4849
4850         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4851         Declare.
4852         (tui_check_register_values): Don't declare.
4853         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4854         from tui_check_register_values.
4855         * tui/tui-hooks.c (tui_register_changed): Update.
4856
4857 2019-08-20  Tom Tromey  <tom@tromey.com>
4858
4859         * tui/tui-regs.c (tui_reg_layout): Move later.
4860         (tui_show_registers): Don't enable TUI mode or change layout.
4861
4862 2019-08-20  Tom Tromey  <tom@tromey.com>
4863
4864         * tui/tui-regs.h (struct tui_data_item_window)
4865         <~tui_data_item_window>: Remove.
4866         <content>: Now a unique_xmalloc_ptr.
4867         * tui/tui-regs.c (tui_register_format): Return a
4868         unique_xmalloc_ptr.
4869         (tui_get_register): Update.
4870         (~tui_data_item_window): Remove.
4871         (tui_data_window::display_registers_from, tui_display_register):
4872         Update.
4873         * tui/tui-io.h (tui_expand_tabs): Update.
4874         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4875         Remove "col" parameter.
4876
4877 2019-08-20  Tom Tromey  <tom@tromey.com>
4878
4879         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4880         field.
4881         * tui/tui-regs.c (~tui_data_item_window): Update.
4882
4883 2019-08-20  Tom Tromey  <tom@tromey.com>
4884
4885         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4886         earlier.
4887
4888 2019-08-20  Tom Tromey  <tom@tromey.com>
4889
4890         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4891
4892 2019-08-20  Tom Tromey  <tom@tromey.com>
4893
4894         * tui/tui-source.h (struct tui_source_window): Update.
4895         * tui/tui-regs.c (tui_show_registers): Update.
4896         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4897         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4898         (NO_REGS_STRING): Remove defines.
4899
4900 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4901
4902         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4903         unnecessary thread walk if remote doesn't support the packet.
4904
4905 2019-08-19  Tom Tromey  <tromey@adacore.com>
4906
4907         * python/py-value.c (value_has_field): Fix indentation.
4908
4909 2019-08-19  Tom Tromey  <tromey@adacore.com>
4910
4911         * printcmd.c (do_one_display, info_display_command): Update.
4912         * block.h (contained_in): Return bool.  Add allow_nested
4913         parameter.
4914         * block.c (contained_in): Return bool.  Add allow_nested
4915         parameter.
4916
4917 2019-08-19  Tom Tromey  <tom@tromey.com>
4918
4919         * configure: Rebuild.
4920         * configure.ac: Disallow the combination of -static-libstdc++ and
4921         source highlight.
4922         * source-cache.c (get_language_name): Handle rust.
4923         (source_cache::get_source_lines): Ignore highlighting exceptions.
4924
4925 2019-08-16  Tom Tromey  <tom@tromey.com>
4926
4927         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4928         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4929         (struct tui_source_window_base) <make_visible, refresh_window,
4930         resize>: Remove methods.
4931         <execution_info>: Remove field.
4932         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4933         (tui_show_source_line, tui_source_window_base)
4934         (~tui_source_window_base): Update.
4935         (tui_source_window_base::resize)
4936         (tui_source_window_base::make_visible)
4937         (tui_source_window_base::refresh_window): Remove.
4938         (tui_source_window_base::update_exec_info): Update.
4939         * tui/tui-source.c (tui_source_window::set_contents): Update.
4940         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4941
4942 2019-08-16  Tom Tromey  <tom@tromey.com>
4943
4944         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4945         deprecated_query_hook.
4946
4947 2019-08-16  Tom Tromey  <tom@tromey.com>
4948
4949         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4950         (tui_update_source_windows_with_line): Update.
4951         * tui/tui-source.h (struct tui_source_window)
4952         <show_symtab_source>: Declare.
4953         (tui_show_symtab_source): Don't declare.
4954         * tui/tui-source.c (tui_show_symtab_source): Rename from
4955         tui_show_symtab_source.
4956
4957 2019-08-16  Tom Tromey  <tom@tromey.com>
4958
4959         * tui/tui-winsource.h (struct tui_source_window_base)
4960         <set_contents>: Declare.
4961         * tui/tui-winsource.c
4962         (tui_source_window_base::update_source_window_as_is): Update.
4963         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4964         Declare.
4965         (tui_set_source_content): Don't declare.
4966         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4967         tui_set_source_content.
4968         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4969         Declare.
4970         (tui_set_disassem_content): Don't declare.
4971         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4972         tui_set_disassem_content.
4973
4974 2019-08-16  Tom Tromey  <tom@tromey.com>
4975
4976         * tui/tui-winsource.h (struct tui_source_window_base)
4977         <update_breakpoint_info>: Declare.
4978         (tui_update_breakpoint_info): Don't declare.
4979         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4980         (tui_update_all_breakpoint_info): Update.
4981         (tui_source_window_base::update_breakpoint_info): Rename from
4982         tui_update_breakpoint_info.
4983         (tui_source_window_base::update_exec_info): Update.
4984
4985 2019-08-16  Tom Tromey  <tom@tromey.com>
4986
4987         * tui/tui-winsource.h (struct tui_source_window_base)
4988         <update_source_window>: Declare.
4989         (tui_update_source_window): Don't declare.
4990         * tui/tui-winsource.c
4991         (tui_source_window_base::update_source_window): Rename from
4992         tui_update_source_window.
4993         (tui_source_window_base::rerender): Update.
4994         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4995         * tui/tui-disasm.c (tui_show_disassem)
4996         (tui_show_disassem_and_update_source)
4997         (tui_disasm_window::maybe_update): Update.
4998
4999 2019-08-16  Tom Tromey  <tom@tromey.com>
5000
5001         * tui/tui-winsource.h (struct tui_source_window_base)
5002         <update_source_window_as_is>: Declare.
5003         (tui_update_source_window_as_is): Don't declare.
5004         * tui/tui-winsource.c (tui_update_source_window): Update
5005         (tui_source_window_base::update_source_window_as_is): Rename from
5006         tui_update_source_window_as_is.
5007         (tui_source_window_base::refill): Update.
5008         * tui/tui-source.c (tui_show_symtab_source): Update.
5009         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5010         Update.
5011
5012 2019-08-16  Tom Tromey  <tom@tromey.com>
5013
5014         * tui/tui-winsource.h (tui_update_source_window)
5015         (tui_update_source_window_as_is): Remove "noerror" parameter.
5016         * tui/tui-winsource.c (tui_update_source_window)
5017         (tui_update_source_window_as_is): Remove "noerror" parameter.
5018         (tui_update_source_windows_with_addr)
5019         (tui_update_source_windows_with_line)
5020         (tui_source_window_base::rerender)
5021         (tui_source_window_base::refill): Update.
5022         * tui/tui-source.h (tui_set_source_content)
5023         (tui_show_symtab_source): Remove "noerror" parameter.
5024         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5025         parameter.
5026         (tui_show_symtab_source): Likewise.
5027         (tui_source_window::maybe_update): Update.
5028         * tui/tui-disasm.c (tui_show_disassem)
5029         (tui_show_disassem_and_update_source)
5030         (tui_disasm_window::do_scroll_vertical)
5031         (tui_disasm_window::maybe_update): Update.
5032
5033 2019-08-16  Tom Tromey  <tom@tromey.com>
5034
5035         * tui/tui.c (tui_is_window_visible): Update.
5036         * tui/tui-wingeneral.c (tui_make_window)
5037         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5038         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5039         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5040         (tui_set_win_height_command, parse_scrolling_args): Update.
5041         * tui/tui-source.c (tui_source_window::style_changed): Update.
5042         * tui/tui-regs.c (tui_show_registers)
5043         (tui_data_window::first_data_item_displayed)
5044         (tui_data_window::delete_data_content_windows)
5045         (tui_check_register_values, tui_reg_command): Update.
5046         * tui/tui-disasm.c (tui_show_disassem): Update.
5047         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5048         method.
5049         <is_visible>: Remove field.
5050         * tui/tui-data.c (tui_next_win, tui_prev_win)
5051         (tui_delete_invisible_windows): Update.
5052
5053 2019-08-16  Tom Tromey  <tom@tromey.com>
5054
5055         * tui/tui-winsource.h (struct tui_source_window_base)
5056         <m_has_locator>: Remove.
5057         * tui/tui-layout.c (show_source_disasm_command, show_data)
5058         (show_source_or_disasm_and_command): Update.
5059
5060 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5061
5062         * NEWS (Other MI changes): New subsection.
5063         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5064         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5065         * arch-utils.c (default_get_pc_address_flags): New function.
5066         * arch-utils.h (default_get_pc_address_flags): New declaration.
5067         * gdbarch.sh: Add get_pc_address_flags.
5068         * gdbarch.c: Regenerate.
5069         * gdbarch.h: Likewise.
5070         * stack.c (print_pc): New function.
5071         (print_frame_info) (print_frame): Call print_pc.
5072
5073 2019-08-16  Tom de Vries  <tdevries@suse.de>
5074
5075         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5076         print_objfile_section_info.
5077
5078 2019-08-15  Tom Tromey  <tom@tromey.com>
5079
5080         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5081         calling update_cmdwin_start_line.
5082         * tui/tui-winsource.h (struct tui_source_window_base)
5083         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5084         <rerender>: Declare.
5085         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5086         Call rerender.
5087         (tui_source_window_base::set_new_height): Remove.
5088         (tui_source_window_base::rerender): Rename from
5089         do_make_visible_with_new_height.
5090         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5091         resize method.
5092         (tui_win_info::make_invisible_and_set_new_height)
5093         (tui_win_info::make_visible_with_new_height): Remove.
5094         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5095         Declare.
5096         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5097         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5098         do_make_visible_with_new_height>: Don't declare.
5099         <rerender>: Declare.
5100         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5101         set_new_height.
5102         (tui_data_window::do_make_visible_with_new_height): Remove.
5103         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5104         call tui_show_locator_content.
5105         (tui_gen_win_info::resize): Call rerender.
5106         (show_source_or_disasm_and_command): Don't call
5107         tui_show_locator_content.
5108         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5109         method.
5110         (struct tui_win_info) <rerender>: Declare.
5111         <set_new_height, make_invisible_and_set_new_height,
5112         make_visible_with_new_height>: Don't declare.
5113         * tui/tui-data.c (tui_win_list::rerender): New method.
5114         * tui/tui-command.h (struct tui_cmd_window)
5115         <do_make_visible_with_new_height>: Don't declare.
5116         * tui/tui-command.c
5117         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5118
5119 2019-08-15  Tom Tromey  <tromey@adacore.com>
5120
5121         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5122         * ada-lang.c (ada_enum_name): Likewise.
5123
5124 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5125
5126         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5127         leading underscore.
5128         (GdbOutputErrorFile): Likewise.
5129         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5130         accordingly.
5131         (execute_unwinders): Rename to have a leading underscore.
5132         (auto_load_packages): Likewise.
5133         (global scope): Adjust call to auto_load_packages accordingly.
5134         (GdbSetPythonDirectory): Likewise.
5135         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5136         instead of execute_unwinders.
5137
5138 2019-08-15  Tom Tromey  <tom@tromey.com>
5139
5140         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5141         (show_data): Don't change window visibility.
5142         (tui_gen_win_info::resize): Remove special case for command
5143         window.  Use wresize, when available.
5144         (show_source_or_disasm_and_command): Don't change window
5145         visibility.
5146         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5147         <make_visible>: New method.
5148         * tui/tui-command.c (tui_cmd_window::resize): New method.
5149
5150 2019-08-15  Tom Tromey  <tom@tromey.com>
5151
5152         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5153         (struct tui_source_windows): New.
5154         * tui/tui-winsource.c (tui_display_main): Update.
5155         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5156         (new_height_ok, parse_scrolling_args): Update.
5157         * tui/tui-layout.c (show_layout, show_data): Update.
5158         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5159         (tui_add_to_source_windows): Don't declare.
5160         * tui/tui-data.c (source_windows, tui_source_windows)
5161         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5162
5163 2019-08-15  Tom Tromey  <tom@tromey.com>
5164
5165         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5166         Rename from reset.
5167         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5168         * tui/tui-layout.c (show_source_disasm_command, show_data):
5169         Update.
5170         (tui_gen_win_info::resize): Rename.
5171         (show_source_or_disasm_and_command): Update.
5172         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5173         reset.
5174
5175 2019-08-15  Tom Tromey  <tom@tromey.com>
5176
5177         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5178         * tui/tui-interp.c (tui_interp::init): Don't call
5179         tui_initialize_static_data.
5180         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5181
5182 2019-08-15  Tom Tromey  <tom@tromey.com>
5183
5184         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5185         examine tui_win_list.
5186
5187 2019-08-15  Tom Tromey  <tom@tromey.com>
5188
5189         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5190         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5191         tui_clear_source_content.
5192         (tui_clear_source_content): Remove.
5193         (tui_source_window_base::do_erase_source_content): Hoist call to
5194         content.clear().
5195         * tui/tui-stack.c (tui_show_frame_info): Don't call
5196         tui_clear_source_content.
5197
5198 2019-08-15  Tom Tromey  <tom@tromey.com>
5199
5200         * tui/tui-winsource.h (struct tui_source_window_base)
5201         <do_erase_source_content>: New method.
5202         <erase_source_content>: New method.
5203         (tui_erase_source_content): Don't declare.
5204         * tui/tui-winsource.c (tui_clear_source_content): Update.
5205         (tui_source_window_base::do_erase_source_content): Rename from
5206         tui_erase_source_content.
5207         (tui_source_window_base::show_source_content): Update.
5208         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5209         * tui/tui-source.h (struct tui_source_window)
5210         <erase_source_content>: New method.
5211         * tui/tui-disasm.h (struct tui_disasm_window)
5212         <erase_source_content>: New method.
5213
5214 2019-08-15  Tom Tromey  <tom@tromey.com>
5215
5216         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5217         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5218         constructor.
5219         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5220         * tui/tui-source.c (tui_set_source_content): Update.
5221         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5222
5223 2019-08-15  Tom Tromey  <tom@tromey.com>
5224
5225         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5226         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5227         tui-source.c.
5228         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5229         Declare.
5230         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5231         method.
5232         (tui_source_window::maybe_update): Update.
5233
5234 2019-08-15  Tom Tromey  <tom@tromey.com>
5235
5236         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5237         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5238         tui-disasm.c.
5239         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5240         Declare.
5241         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5242         method.
5243         (tui_disasm_window::maybe_update): Update.
5244
5245 2019-08-15  Tom Tromey  <tom@tromey.com>
5246
5247         * tui/tui-winsource.h (struct tui_source_window_base)
5248         <maybe_update>: Declare.
5249         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5250         method.
5251         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5252         Declare.
5253         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5254         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5255         Declare.
5256         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5257
5258 2019-08-15  Tom Tromey  <tom@tromey.com>
5259
5260         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5261
5262 2019-08-15  Tom Tromey  <tom@tromey.com>
5263
5264         * tui/tui-wingeneral.c: Include tui-stack.h.
5265         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5266         (struct tui_locator_window): Move from tui-data.h.
5267         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5268         (tui_initialize_static_data): Move from tui-data.c.
5269         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5270         (struct tui_locator_window): Move to tui-stack.c.
5271         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5272         (tui_initialize_static_data): Move to tui-stack.c.
5273
5274 2019-08-15  Tom Tromey  <tom@tromey.com>
5275
5276         * tui/tui-layout.c (show_source_disasm_command)
5277         (show_source_or_disasm_and_command): Use make_visible method, not
5278         tui_make_window.
5279         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5280         Remove.
5281
5282 2019-08-15  Tom Tromey  <tom@tromey.com>
5283
5284         * tui/tui-wingeneral.h (tui_make_window): Update.
5285         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5286         parameter.
5287         (tui_gen_win_info::make_visible): Update.
5288         * tui/tui-regs.c (tui_data_window::display_registers_from):
5289         Update.
5290         * tui/tui-layout.c (show_source_disasm_command)
5291         (show_source_or_disasm_and_command): Update.
5292         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5293         (enum tui_box): Remove.
5294         (struct tui_win_info) <can_box>: New method.
5295         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5296         method.
5297
5298 2019-08-15  Tom de Vries  <tdevries@suse.de>
5299
5300         * linux-nat-trad.c: Include gdbarch.h.
5301
5302 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5303
5304         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5305         register sizes.
5306
5307 2019-08-14  Tom Tromey  <tromey@adacore.com>
5308
5309         * darwin-nat.c: Include gdbarch.h.
5310         * darwin-nat-info.c: Include gdbarch.h.
5311
5312 2019-08-13  Tom Tromey  <tom@tromey.com>
5313
5314         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5315         Remove.
5316         * tui/tui-data.c (tui_initialize_static_data): Update.
5317
5318 2019-08-13  Tom Tromey  <tom@tromey.com>
5319
5320         * tui/tui-winsource.h (struct tui_exec_info_window)
5321         <~tui_exec_info_window, maybe_allocate_content, get_content,
5322         m_content>: Remove.
5323         (struct tui_source_window_base) <set_exec_info_content,
5324         show_exec_info_content>: Don't declare.
5325         * tui/tui-winsource.c
5326         (tui_exec_info_window::maybe_allocate_content): Remove.
5327         (tui_source_window_base::update_exec_info): Rename from
5328         set_exec_info_content.
5329         (tui_source_window_base::show_exec_info_content)
5330         (tui_source_window_base::update_exec_info): Remove.
5331
5332 2019-08-13  Tom Tromey  <tom@tromey.com>
5333
5334         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5335         declare.
5336         * tui/tui-winsource.c (tui_update_source_window_as_is)
5337         (tui_update_source_windows_with_addr, tui_erase_source_content):
5338         Update.
5339         (tui_clear_exec_info_content): Remove.
5340
5341 2019-08-13  Tom Tromey  <tom@tromey.com>
5342
5343         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5344         declare.
5345         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5346         call tui_erase_exec_info_content.
5347         (tui_clear_exec_info_content): Rename from
5348         tui_erase_exec_info_content.
5349         (tui_clear_exec_info_content): Delete.
5350
5351 2019-08-13  Tom Tromey  <tom@tromey.com>
5352
5353         * tui/tui-winsource.h (struct tui_source_window_base)
5354         <show_exec_info_content>: Declare.
5355         (tui_show_exec_info_content): Don't declare.
5356         * tui/tui-winsource.c
5357         (tui_source_window_base::show_exec_info_content): Rename from
5358         tui_show_exec_info_content.
5359         (tui_source_window_base::update_exec_info): Update.
5360
5361 2019-08-13  Tom Tromey  <tom@tromey.com>
5362
5363         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5364         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5365         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5366         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5367         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5368         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5369         ... here.
5370
5371 2019-08-13  Tom Tromey  <tom@tromey.com>
5372
5373         * tui/tui-winsource.h (struct tui_source_window_base)
5374         <update_exec_info>: Declare.
5375         (tui_update_exec_info): Don't declare.
5376         * tui/tui-winsource.c (tui_update_source_window_as_is)
5377         (tui_source_window_base::refresh_all)
5378         (tui_update_all_breakpoint_info): Update.
5379         (tui_source_window_base::update_exec_info): Rename from
5380         tui_update_exec_info.
5381         * tui/tui-stack.c (tui_show_frame_info): Update.
5382
5383 2019-08-13  Tom Tromey  <tom@tromey.com>
5384
5385         * tui/tui-winsource.h (struct tui_source_window_base)
5386         <set_exec_info_content>: Declare.
5387         (tui_set_exec_info_content): Don't declare.
5388         * tui/tui-winsource.c
5389         (tui_source_window_base::set_exec_info_content): Rename from
5390         tui_set_exec_info_content.
5391         (tui_update_exec_info): Update.
5392
5393 2019-08-13  Tom Tromey  <tom@tromey.com>
5394
5395         * tui/tui-winsource.h (struct tui_source_window_base)
5396         <show_source_content>: Declare.
5397         (tui_show_source_content): Don't declare.
5398         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5399         (tui_source_window_base::show_source_content): Rename from
5400         tui_show_source_content.
5401         (tui_source_window_base::refresh_all): Update.
5402         * tui/tui-layout.c (show_source_disasm_command)
5403         (show_source_or_disasm_and_command): Update.
5404
5405 2019-08-13  Tom Tromey  <tom@tromey.com>
5406
5407         * tui/tui-winsource.c (tui_erase_source_content)
5408         (tui_show_source_content, tui_source_window_base::refresh_all):
5409         Update.
5410         * tui/tui-wingeneral.h
5411         (tui_check_and_display_highlight_if_needed): Don't declare.
5412         * tui/tui-wingeneral.c
5413         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5414         check_and_display_highlight_if_needed.
5415         * tui/tui-win.c (tui_rehighlight_all)
5416         (tui_win_info::make_visible_with_new_height): Update.
5417         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5418         (tui_data_window::erase_data_content)
5419         (tui_data_window::display_all_data): Update.
5420         * tui/tui-data.h (struct tui_win_info)
5421         <check_and_display_highlight_if_needed>: Declare.
5422
5423 2019-08-13  Tom Tromey  <tom@tromey.com>
5424
5425         * tui/tui-win.c (tui_resize_all): Call
5426         tui_delete_invisible_windows.
5427         * tui/tui-layout.c (show_layout): Call
5428         tui_delete_invisible_windows.
5429         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5430         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5431
5432 2019-08-13  Tom Tromey  <tom@tromey.com>
5433
5434         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5435         tui_add_win_to_layout.
5436
5437 2019-08-13  Tom Tromey  <tom@tromey.com>
5438
5439         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5440         * tui/tui-layout.c (tui_default_win_height): Now static.
5441
5442 2019-08-13  Tom Tromey  <tom@tromey.com>
5443
5444         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5445         single switch.
5446         (show_source_disasm_command, show_source_or_disasm_and_command):
5447         Don't check current layout.
5448
5449 2019-08-13  Tom Tromey  <tom@tromey.com>
5450
5451         * tui/tui-wingeneral.c (make_all_visible): Remove.
5452         (tui_make_all_invisible): Simplify.
5453         * tui/tui-layout.c (tui_make_all_invisible): Move from
5454         tui-wingeneral.c; simplify.
5455         (show_layout): Hoist call to tui_make_all_invisible.
5456         (show_data): Don't call tui_make_all_invisible.
5457
5458 2019-08-13  Tom Tromey  <tom@tromey.com>
5459
5460         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5461         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5462
5463 2019-08-13  Tom Tromey  <tom@tromey.com>
5464
5465         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5466         tui-data.c.
5467         (show_source_disasm_command, show_data)
5468         (show_source_or_disasm_and_command): Don't use
5469         tui_set_current_layout_to.
5470         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5471         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5472         tui-layout.c.
5473         (tui_set_current_layout_to): Remove.
5474
5475 2019-08-13  Tom Tromey  <tom@tromey.com>
5476
5477         * tui/tui-layout.c (tui_set_layout): Update.
5478         * tui/tui-data.h (struct tui_layout_def): Remove.
5479         (tui_layout_def): Don't declare.
5480         * tui/tui-data.c (layout_def): Remove.
5481         (tui_layout_def): Remove.
5482
5483 2019-08-13  Tom Tromey  <tom@tromey.com>
5484
5485         * tui/tui-winsource.h (struct tui_source_window_base)
5486         <clear_detail>: No longer "override".
5487         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5488         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5489         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5490         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5491         Remove.
5492         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5493
5494 2019-08-13  Tom Tromey  <tromey@adacore.com>
5495
5496         * tracepoint.c: Don't include readline.h or history.h.
5497
5498 2019-08-12  Tom Tromey  <tom@tromey.com>
5499
5500         * configure: Rebuild.
5501         * configure.ac: Check for readline 7.
5502         * NEWS: Mention readline 7 requirement.
5503         * README: Update.
5504
5505 2019-08-12  Tom Tromey  <tom@tromey.com>
5506
5507         * mingw-hdep.c (gdb_select): Remove readline hack.
5508
5509 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5510
5511         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5512         when the function fails.
5513
5514 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5515
5516         * s390-tdep.c (s390_type_align): New function.
5517         (s390_gdbarch_init): Set it as type_align gdbarch method.
5518
5519 2019-08-09  Tom de Vries  <tdevries@suse.de>
5520
5521         PR gdb/24591
5522         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5523         pc_low with relocation offset.
5524
5525 2019-08-07  Tom Tromey  <tromey@adacore.com>
5526
5527         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5528         (print_frame_args): Update.
5529         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5530         Update.
5531         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5532         * frame.h (struct frame_arg): Add initializers.
5533         <error>: Now a unique_xmalloc_ptr.
5534
5535 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5536
5537         * NEWS: Expand the Pointer Authentication entry.
5538         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5539         (aarch64_frame_unmask_lr): ... to this.
5540         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5541         Call aarch64_frame_unmask_lr.
5542         * frame.c (struct frame_info): Add "masked" variable.
5543         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5544         (fprint_frame): Check for masked pc.
5545         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5546         declarations.
5547         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5548         * stack.c (print_frame): Check for masked pc.
5549
5550 2019-08-06  Tom Tromey  <tom@tromey.com>
5551
5552         * stabsread.c (patch_block_stabs, read_one_struct_field)
5553         (read_enum_type): Use obstack_strndup.
5554         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5555         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5556         * dwarf2read.c (guess_full_die_structure_name)
5557         (anonymous_struct_prefix): Use obstack_strndup.
5558         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5559         * c-exp.y (yylex): Use obstack_strndup.
5560         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5561         (write_var_or_type): Use obstack_strndup.
5562
5563 2019-08-06  Tom Tromey  <tom@tromey.com>
5564
5565         * symfile.c (reread_symbols): Use obstack_strdup.
5566         * stabsread.c (read_type): Use obstack_strdup.
5567         * gdb_obstack.h (obstack_strdup): New overload.
5568         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5569         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5570         (dwarf2_canonicalize_name): Use obstack_strdup.
5571         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5572         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5573         Use obstack_strdup.
5574
5575 2019-08-06  Tom Tromey  <tom@tromey.com>
5576
5577         * gdb_obstack.h (obstack_strdup): Define.
5578         * gdb_obstack.c (obstack_strdup): Don't define.
5579
5580 2019-08-06  Tom Tromey  <tom@tromey.com>
5581
5582         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5583         obstack_strdup.
5584         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5585         obstack_strdup.
5586         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5587         * stabsread.c (common_block_start): Use obstack_strdup.
5588         * objfiles.c (set_objfile_main_name, objfile): Use
5589         obstack_strdup.
5590         * namespace.c (add_using_directive): Use obstack_strdup.
5591         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5592         * jit.c (finalize_symtab): Use obstack_strdup.
5593         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5594         (guess_partial_die_structure_name, partial_die_info::fixup)
5595         (dwarf2_name): Use obstack_strdup.
5596         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5597         obstack_strdup.
5598         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5599         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5600         obstack_strdup.
5601         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5602
5603 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5604
5605         * unittests/help-doc-selftests.c: New file.
5606         * Makefile.in: Add the new file.
5607
5608 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5609
5610         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5611         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5612         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5613         the trailing '.' is not output, and the first character is uppercased.
5614         (print_help_for_command): Update call to print_doc_line.
5615         (print_doc_of_command): Likewise.
5616         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5617         * cli/cli-option.c (append_indented_doc): Do not append newline.
5618         (build_help_option): Append newline after first appended_indented_doc
5619         only if a second call is done.
5620         (build_help): Append 2 new lines before each option, except the first
5621         one.
5622         * compile/compile.c (_initialize_compile): Add new lines after
5623         %OPTIONS%, when not at the end of the help.
5624         Change help doc or code
5625         producing the help doc to respect the invariants.
5626         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5627         Also removed the new line after 'Options:', as all other commands
5628         do not put an empty line between 'Options:' and the first option.
5629         * printcmd.c (_initialize_printcmd): Likewise.
5630         * stack.c (_initialize_stack): Likewise.
5631         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5632         incorrectly telling COMMAND is optional.
5633         * ada-lang.c (_initialize_ada_language): Change help doc or code
5634         producing the help doc to respect the invariants.
5635         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5636         * breakpoint.c (_initialize_breakpoint): Likewise.
5637         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5638         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5639         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5640         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5641         _initialize_cli_style): Likewise.
5642         * corelow.c (core_target_info): Likewise.
5643         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5644         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5645         * filesystem.c (_initialize_filesystem): Likewise.
5646         * frame.c (_initialize_frame): Likewise.
5647         * gnu-nat.c (add_task_commands): Likewise.
5648         * infcall.c (_initialize_infcall): Likewise.
5649         * infcmd.c (_initialize_infcmd): Likewise.
5650         * interps.c (_initialize_interpreter): Likewise.
5651         * language.c (_initialize_language): Likewise.
5652         * linux-fork.c (_initialize_linux_fork): Likewise.
5653         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5654         * maint.c (_initialize_maint_cmds): Likewise.
5655         * memattr.c (_initialize_mem): Likewise.
5656         * printcmd.c (_initialize_printcmd): Likewise.
5657         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5658         _RegEx): Likewise.
5659         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5660         * record-btrace.c (_initialize_record_btrace): Likewise.
5661         * record-full.c (_initialize_record_full): Likewise.
5662         * record.c (_initialize_record): Likewise.
5663         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5664         * regcache.c (_initialize_regcache): Likewise.
5665         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5666         _initialize_remote): Likewise.
5667         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5668         * serial.c (_initialize_serial): Likewise.
5669         * skip.c (_initialize_step_skip): Likewise.
5670         * source.c (_initialize_source): Likewise.
5671         * stack.c (_initialize_stack): Likewise.
5672         * symfile.c (_initialize_symfile): Likewise.
5673         * symtab.c (_initialize_symtab): Likewise.
5674         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5675         * top.c (init_main): Likewise.
5676         * tracefile-tfile.c (tfile_target_info): Likewise.
5677         * tracepoint.c (_initialize_tracepoint): Likewise.
5678         * tui/tui-win.c (_initialize_tui_win): Likewise.
5679         * utils.c (add_internal_problem_command): Likewise.
5680         * valprint.c (value_print_option_defs): Likewise.
5681
5682 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5683
5684         PR build/24886
5685         * configure.ac: Drop enable-libmcheck support.
5686         * configure, config.in: Rebuild.
5687         * libmcheck.m4: Remove.
5688         * acinclude.m4: Don't include it.
5689         * Makefile.in: Don't distribute it.
5690         * top.c (print_gdb_configuration): Don't mention it.
5691
5692 2019-08-06  Tom Tromey  <tom@tromey.com>
5693
5694         * utils.c (set_output_style): Sometimes pass stream to
5695         emit_style_escape.
5696         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5697         * record-btrace.c (btrace_insn_history): Update.
5698         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5699         method.
5700         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5701         Update initializers.
5702         <m_uiout>: New field.
5703         <m_di>: Move lower.
5704         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5705         Remove "uiout" parameter.
5706         (dump_insns): Update.
5707         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5708         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5709
5710 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5711
5712         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5713         (error_in_psymtab_expansion): Likewise.
5714         (lookup_symbol_via_quick_fns): Likewise.
5715         (basic_lookup_transparent_type_quick): Likewise.
5716         (basic_lookup_transparent_type_1): Likewise.
5717
5718 2019-08-06  Tom Tromey  <tromey@adacore.com>
5719
5720         * source.c (last_source_error): Now bool.
5721         (print_source_lines_base): Make "noprint" bool.  Only open
5722         source file when last_source_visited changes.
5723
5724 2019-08-06  Tom Tromey  <tromey@adacore.com>
5725
5726         * annotate.c (annotate_source_line): Use g_source_cache.
5727         * source-cache.c (source_cache::get_plain_source_lines): Change
5728         parameters.  Populate m_offset_cache.
5729         (source_cache::ensure): New method.
5730         (source_cache::get_line_charpos): New method.
5731         (extract_lines): Move lower.  Change parameters.
5732         (source_cache::get_source_lines): Move lower.
5733         * source-cache.h (class source_cache): Update comment.
5734         <get_line_charpos>: New method.
5735         <get_source_lines>: Update comment.
5736         <clear>: Clear m_offset_cache.
5737         <get_plain_source_lines>: Change parameters.
5738         <ensure>: New method
5739         <m_offset_cache>: New member.
5740         * source.c (forget_cached_source_info_for_objfile): Update.
5741         (info_source_command): Use g_source_cache.
5742         (find_source_lines, open_source_file_with_line_charpos): Remove.
5743         (print_source_lines_base, search_command_helper): Use g_source_cache.
5744         * source.h (open_source_file_with_line_charpos): Don't declare.
5745         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5746         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5747         Use g_source_cache.
5748
5749 2019-08-06  Tom Tromey  <tromey@adacore.com>
5750
5751         * source-cache.c (source_cache::get_plain_source_lines):
5752         Remove "first_line" and "last_line" parameters.
5753         (source_cache::get_source_lines): Cache plain text.
5754         * source-cache.h (class source_cache)
5755         <get_plain_source_lines>: Update.
5756
5757 2019-08-06  Tom Tromey  <tromey@adacore.com>
5758
5759         * source-cache.c (extract_lines): No longer a method.
5760         Changed type of parameter.  Include final newline.
5761         (selftests::extract_lines_test): New function.
5762         (_initialize_source_cache): Likewise.
5763         * source-cache.h (class source_cache)
5764         <extract_lines>: Don't declare.
5765
5766 2019-08-06  Tom Tromey  <tromey@adacore.com>
5767
5768         * breakpoint.c (init_breakpoint_sal): Update.
5769         (breakpoint): Update.
5770         * breakpoint.h (struct breakpoint) <filter>: Now a
5771         unique_xmalloc_ptr.
5772
5773 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5774
5775         * NEWS: Mention dictionary access on blocks.
5776         * python/py-block.c (blpy_getitem): New function.
5777         (block_object_as_mapping): New struct.
5778         (block_object_type): Use new struct for tp_as_mapping field.
5779
5780 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5781
5782         * objfiles.h (objfile): Add a comment describing partial symbols.
5783
5784 2019-08-05  Tom Tromey  <tromey@adacore.com>
5785
5786         * compile/compile.c (_initialize_compile): Use _(), not N_().
5787         * thread.c (_initialize_thread): Use _(), not N_().
5788         * stack.c (_initialize_stack): Use _(), not N_().
5789         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5790
5791 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5792
5793         * dwarf2read.c (struct dw2_symtab_iterator):
5794         <want_specific_block>: Remove.
5795         <block_index>: Change type to gdb::optional.
5796         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5797         change type of BLOCK_INDEX parameter to gdb::optional.
5798         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5799         (dw2_lookup_symbol): Don't pass argument for
5800         WANT_SPECIFIC_BLOCK.
5801         (dw2_expand_symtabs_for_function): Don't pass argument for
5802         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5803         (class dw2_debug_names_iterator)
5804         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5805         parameter, change BLOCK_INDEX type to gdb::optional.
5806         <m_want_specific_block>: Remove.
5807         <m_block_index>: Change type to gdb::optional.
5808         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5809         gdb::optional.  Re-write in function of gdb::optional.
5810         (dw2_debug_names_lookup_symbol): Don't pass argument for
5811         WANT_SPECIFIC_BLOCK.
5812         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5813         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5814         BLOCK_INDEX.
5815
5816 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5817
5818         * NEWS: Mention changes to "info sources" command.
5819
5820 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5821
5822         * symtab.c (filename_partial_match_opts): New struct type.
5823         (struct output_source_filename_data): New members
5824         regexp, c_regexp, partial_match.
5825         (output_source_filename): Use new members to decide to print file.
5826         (info_sources_option_defs): New variable.
5827         (make_info_sources_options_def_group, print_info_sources_header,
5828         info_sources_command_completer):
5829         New functions.
5830         (info_sources_command): Read new optional arguments.
5831         (_initialize_symtab): Update info sources help.
5832
5833 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5834
5835         * ada-lang.c (exception_support_info_v0): Renamed from...
5836         (default_exception_support_info): ... this.  Create new
5837         definition for v1.
5838         (ada_has_this_exception_support): Look up catch_handlers_sym.
5839         (ada_exception_support_info_sniffer): Try v0 after default.
5840
5841 2019-08-01  Tom Tromey  <tromey@adacore.com>
5842
5843         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5844         gdbarch.h.
5845
5846 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5847
5848         * s12z-tdep.c: Fix include path for s12z-opc.h.
5849
5850 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5851
5852         * NEWS: Require GNU make 3.82.
5853
5854 2019-07-16  Tom Tromey  <tom@tromey.com>
5855
5856         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5857         declare.
5858
5859 2019-07-30  Tom Tromey  <tromey@adacore.com>
5860
5861         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5862
5863 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5864
5865         * printcmd.c (print_address_symbolic): Print negative offsets.
5866         (build_address_symbolic): Force signed arithmetic when computing
5867         offset.
5868
5869 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5870
5871         PR/24474: Add a function to lookup static variables.
5872         * NEWS: Mention this new function.
5873         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5874         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5875         * python/python.c (python_GdbMethods): Add new function.
5876
5877 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5878
5879         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5880         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5881         (objfpy_lookup_static_symbol): New function.
5882         (objfile_object_methods): Add new functions.
5883
5884 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5885
5886         * NEWS: Mention 'set|show print frame-info'.  Mention new
5887         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5888         backtrace argument.  Mention that python frame filtering code
5889         is now consistent with what 'backtrace' command prints.
5890
5891 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5892
5893         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5894         comments.
5895         (print_frame_info_auto, print_frame_info_source_line,
5896         print_frame_info_location, print_frame_info_source_and_location,
5897         print_frame_info_location_and_address, print_frame_info_short_location):
5898         New declarations.
5899         (struct frame_print_options): New member print_frame_info.
5900         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5901         * stack.h (get_user_print_what_frame_info): New declaration.
5902         (frame_show_address): New declaration.
5903         * stack.c (print_frame_arguments_choices): New value 'presence'.
5904         (print_frame_info_auto, print_frame_info_source_line,
5905         print_frame_info_location, print_frame_info_source_and_location,
5906         print_frame_info_location_and_address, print_frame_info_short_location,
5907         print_frame_info_choices, print_frame_info_print_what): New definitions.
5908         (print_frame_args): Only print dots for args if print frame-arguments
5909         is 'presence'.
5910         (frame_print_option_defs): New element for "frame-info".
5911         (get_user_print_what_frame_info): New function.
5912         (frame_show_address): Make non static.  Move comment to stack.h.
5913         (print_frame_info_to_print_what): New function.
5914         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5915         to decide what to print.
5916         (backtrace_command_1): Handle the new print_frame_arguments_presence
5917         value.
5918         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5919         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5920         (py_print_frame): In non-mi mode, use LOCATION as default for
5921         print_what, similarly to frame information printed directly by
5922         backtrace command. Handle frame-info user option in non MI mode.
5923
5924 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5925
5926         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5927         Add case for debugging 32-bit target on 64-bit host.  Revise
5928         comment.
5929
5930 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5931
5932         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5933         instead of find_function_entry_range_from_pc.
5934
5935 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5936
5937         * stack.c (find_frame_funname): Remove code which preferred
5938         minsym over symtab sym in "certain pathological cases".
5939
5940         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5941         parameter.  Change type of "do_demangle" to bool.
5942         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5943         Pass suitable "prefer_sym_over_minsym" flag to
5944         build_address_symbolic().  Don't output "+" for negative offsets.
5945         * printcmd.c (print_address_symbolic): Update invocation of
5946         build_address_symbolic to include a "prefer_sym_over_minsym"
5947         flag.
5948         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5949         Restrict cases in which use of minimal symbol is preferred to that
5950         of a found symbol.  Update comments.
5951
5952         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5953         for entry pc when entry pc is out of range for that FDE.
5954
5955 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5956
5957         PR gdb/24839:
5958         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5959         type.
5960
5961 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5962
5963         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5964         this function's Python signature.
5965
5966
5967 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5968
5969         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5970         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5971         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5972         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5973         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5974
5975
5976 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5977
5978         * h8300-tdep.c (h8300_register_name_common): New.
5979         h8300_register_name): Use h8300_register_name_common.
5980         (h8300s_register_name): Likewise.
5981         (h8300sx_register_name): Likewise.
5982         (h8300h_register_nam): New.
5983         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5984
5985
5986 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5987
5988         * arm-tdep.c (arm_skip_cmse_entry): New function.
5989         (arm_is_sgstubs_section): New function.
5990         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5991
5992 2019-07-22  Tom Tromey  <tom@tromey.com>
5993
5994         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5995         Don't self-assign.
5996
5997 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5998
5999         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6000         type_print.
6001
6002 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6003
6004         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6005         so that GDB doesn't match any msymbols when searching in the
6006         TYPES_DOMAIN.
6007         (print_symbol_info): Print using typedef_print or type_print based
6008         on the type of the symbol.  Add updated FIXME comment moved from...
6009         (_initialize_symtab): ... move and update FIXME comment to above.
6010
6011 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6012
6013         * NEWS: Mention adding -q option to "info types".
6014         * symtab.c (struct info_types_options): New struct.
6015         (info_types_options_defs): New variable.
6016         (make_info_types_options_def_group): New function.
6017         (info_types_command): Use gdb::option framework to parse options.
6018         (info_types_command_completer): New function.
6019         (_initialize_symtab): Extend the help text on "info types" and
6020         register command completer.
6021
6022 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6023
6024         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6025         (lookup_symbol_in_objfile): Change int to block_enum and add a
6026         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6027
6028 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6029
6030         * MAINTAINERS (Write After Approval): Add self.
6031
6032 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6033
6034         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6035         instruction to the dummy code region.
6036
6037 2019-07-19  Tom Tromey  <tromey@adacore.com>
6038
6039         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6040         (ARGSUSED, PARAMS, __func__): Remove rules.
6041
6042 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6043
6044         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6045         * features/arm/arm-with-iwmmxt.c: Remove.
6046         * features/arm/arm-with-iwmmxt.xml: Remove.
6047         * features/arm/arm-with-m-fpa-layout.c: Remove.
6048         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6049         * features/arm/arm-with-m-vfp-d16.c: Remove.
6050         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6051         * features/arm/arm-with-m.c: Remove.
6052         * features/arm/arm-with-m.xml: Remove.
6053         * features/arm/arm-with-neon.c: Remove.
6054         * features/arm/arm-with-neon.xml: Remove.
6055         * features/arm/arm-with-vfpv2.c: Remove.
6056         * features/arm/arm-with-vfpv2.xml: Remove.
6057         * features/arm/arm-with-vfpv3.c: Remove.
6058         * features/arm/arm-with-vfpv3.xml: Remove.
6059
6060 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6061
6062         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6063
6064 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6065
6066         * arch/aarch32.c (aarch32_create_target_description): Create
6067         target descriptions using features.
6068         * arch/arm.c (arm_create_target_description)
6069         (arm_create_mprofile_target_description): Likewise.
6070         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6071
6072 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6073
6074         * Makefile.in: Add new files.
6075         * aarch32-tdep.c: New file.
6076         * aarch32-tdep.h: New file.
6077         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6078         Call aarch32_read_description.
6079         * arch/aarch32.c: New file.
6080         * arch/aarch32.h: New file.
6081         * arch/arm.c (arm_create_target_description)
6082         (arm_create_mprofile_target_description): New function.
6083         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6084         (arm_create_target_description)
6085         (arm_create_mprofile_target_description): New declaration.
6086         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6087         read_description functions.
6088         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6089         Likewise.
6090         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6091         * arm-tdep.c (tdesc_arm_list): New variable.
6092         (arm_register_g_packet_guesses): Call create description functions.
6093         (arm_read_description) (arm_read_mprofile_description): New
6094         function.
6095         * arm-tdep.h (arm_read_description)
6096         (arm_read_mprofile_description): Add declaration.
6097         * configure.tgt: Add new files.
6098
6099 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6100
6101         * top.c (new_ui_command): Open specified terminal just once.
6102
6103 2019-07-18  Tom Tromey  <tromey@adacore.com>
6104
6105         * symtab.c (main_name): Constify return type.
6106         * symfile.c (set_initial_language): Update.
6107         * symtab.h (main_name): Constify return type.
6108
6109 2019-07-17  Tom Tromey  <tom@tromey.com>
6110
6111         * tui/tui-winsource.c (tui_update_source_window)
6112         (tui_update_source_window_as_is)
6113         (tui_update_source_windows_with_line): Remove return.
6114         * tui/tui-disasm.c (tui_show_disassem)
6115         (tui_show_disassem_and_update_source): Remove return.
6116         * tui/tui.c (tui_reset): Remove return.
6117         * tui/tui-wingeneral.c
6118         (tui_check_and_display_highlight_if_needed): Remove return.
6119
6120 2019-07-17  Tom Tromey  <tom@tromey.com>
6121
6122         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6123
6124 2019-07-17  Tom Tromey  <tom@tromey.com>
6125
6126         * tui/tui-winsource.h (struct tui_exec_info_window)
6127         (struct tui_source_window_base): Move from tui-data.h.
6128         * tui/tui-winsource.c: Move many method definitions from
6129         elsewhere.  Remove "structuring" comments.
6130         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6131         (tui_source_window_base::refresh_window): Move to
6132         tui-winsource.c.
6133         * tui/tui-win.c (tui_source_window_base::refresh_all)
6134         (tui_source_window_base::update_tab_width)
6135         (tui_source_window_base::set_new_height)
6136         (tui_source_window_base::do_make_visible_with_new_height): Move to
6137         tui-winsource.c.
6138         * tui/tui-source.h: Update.
6139         * tui/tui-source.c (tui_source_window_base::reset): Move to
6140         tui-winsource.c.
6141         * tui/tui-disasm.h: Update.
6142         * tui/tui-data.h (struct tui_exec_info_window): Move to
6143         tui-winsource.h.
6144         (struct tui_source_window_base): Likewise.
6145         * tui/tui-data.c (tui_source_window_base::clear_detail)
6146         (tui_source_window_base, ~tui_source_window_base): Move to
6147         tui-winsource.c.
6148
6149 2019-07-17  Tom Tromey  <tom@tromey.com>
6150
6151         * tui/tui-win.c (tui_resize_all)
6152         (tui_source_window_base::update_tab_width)
6153         (tui_adjust_win_heights): Update.
6154         (tui_win_info::make_invisible_and_set_new_height): Rename from
6155         make_invisible_and_set_new_height.
6156         * tui/tui-data.h (struct tui_win_info)
6157         <make_invisible_and_set_new_height>: New method.
6158
6159 2019-07-17  Tom Tromey  <tom@tromey.com>
6160
6161         * tui/tui.c: Update.
6162         * tui/tui-source.h (struct tui_source_window): Move from
6163         tui-data.h.
6164         * tui/tui-layout.c: Update.
6165         * tui/tui-disasm.c: Update.
6166         * tui/tui-data.h (struct tui_source_window): Move to
6167         tui-source.h.
6168
6169 2019-07-17  Tom Tromey  <tom@tromey.com>
6170
6171         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6172         tui-data.h.
6173         * tui/tui-data.h (struct tui_disasm_window): Move to
6174         tui-disasm.h.
6175
6176 2019-07-17  Tom Tromey  <tom@tromey.com>
6177
6178         * tui/tui-regs.h (struct tui_data_item_window): Move from
6179         tui-data.h.
6180         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6181         * tui/tui-data.h (struct tui_data_item_window): Move to
6182         tui-regs.h.
6183         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6184
6185 2019-07-17  Tom Tromey  <tom@tromey.com>
6186
6187         * tui/tui.c: Update.
6188         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6189         (tui_cmd_window::max_height): Move to tui-command.c.
6190         * tui/tui-layout.c: Update.
6191         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6192         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6193         tui-command.c.
6194         * tui/tui-command.h (struct tui_cmd_window): Move from
6195         tui-data.h.
6196         * tui/tui-command.c: Remove "structuring" comments.
6197         (tui_cmd_window::clear_detail)
6198         (tui_cmd_window::do_make_visible_with_new_height)
6199         (tui_cmd_window::max_height): Move from elsewhere.
6200
6201 2019-07-17  Tom Tromey  <tom@tromey.com>
6202
6203         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6204         Now static.
6205         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6206         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6207
6208 2019-07-17  Tom Tromey  <tom@tromey.com>
6209
6210         * tui/tui.c: Update.
6211         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6212         tui-regs.c.
6213         * tui/tui-windata.h: Remove file.
6214         * tui/tui-windata.c: Remove file.
6215         * tui/tui-win.c (tui_data_window::set_new_height)
6216         (tui_data_window::do_make_visible_with_new_height): Move to
6217         tui-regs.c.
6218         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6219         * tui/tui-regs.c: Remove "structuring" comments.
6220         (tui_data_window::first_data_item_displayed)
6221         (tui_data_window::delete_data_content_windows)
6222         (tui_data_window::erase_data_content)
6223         (tui_data_window::display_all_data)
6224         (tui_data_window::refresh_all)
6225         (tui_data_window::do_scroll_vertical)
6226         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6227         (tui_data_window::do_make_visible_with_new_height)
6228         (tui_data_window::refresh_window): Move from elsewhere.
6229         (_initialize_tui_regs): Move to end of file.
6230         * tui/tui-layout.c: Update.
6231         * tui/tui-hooks.c: Update.
6232         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6233         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6234         tui-regs.c.
6235         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6236
6237 2019-07-17  Tom Tromey  <tom@tromey.com>
6238
6239         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6240         seen.
6241
6242 2019-07-17  Tom Tromey  <tom@tromey.com>
6243
6244         * tui/tui-win.c (tui_source_window_base::set_new_height)
6245         (tui_source_window_base::do_make_visible_with_new_height): Use
6246         m_has_locator field directly.
6247         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6248         method.
6249         (struct tui_source_window_base) <has_locator>: Likewise.
6250
6251 2019-07-17  Tom Tromey  <tom@tromey.com>
6252
6253         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6254         Don't declare.
6255         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6256         Remove.
6257         * tui/tui-win.c (tui_source_window_base::set_new_height)
6258         (tui_source_window_base::set_new_height)
6259         (make_invisible_and_set_new_height)
6260         (tui_source_window_base::do_make_visible_with_new_height)
6261         (tui_source_window_base::do_make_visible_with_new_height):
6262         Update.
6263         * tui/tui-layout.c (show_source_disasm_command, show_data)
6264         (show_source_or_disasm_and_command): Update.
6265         * tui/tui-layout.c (show_layout): Update.
6266
6267 2019-07-17  Tom Tromey  <tom@tromey.com>
6268
6269         * tui/tui-layout.c (make_data_window): Remove.
6270         (show_data): Unify creation and re-initialization cases.
6271
6272 2019-07-17  Tom Tromey  <tom@tromey.com>
6273
6274         * tui/tui-layout.c (make_source_window, make_disasm_window):
6275         Remove.
6276         (show_data): Unify creation and re-initialization cases.
6277
6278 2019-07-17  Tom Tromey  <tom@tromey.com>
6279
6280         * tui/tui-layout.c (make_command_window): Remove.
6281         (show_source_disasm_command, show_source_or_disasm_and_command):
6282         Unify creation and re-initialization cases.
6283
6284 2019-07-17  Tom Tromey  <tom@tromey.com>
6285
6286         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6287         creation and re-initialization cases.
6288
6289 2019-07-17  Tom Tromey  <tom@tromey.com>
6290
6291         * tui/tui-regs.c (tui_get_register): Return void.
6292
6293 2019-07-17  Tom Tromey  <tom@tromey.com>
6294
6295         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6296         Simplify.
6297
6298 2019-07-17  Tom Tromey  <tom@tromey.com>
6299
6300         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6301         resetting.
6302
6303 2019-07-17  Tom Tromey  <tom@tromey.com>
6304
6305         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6306         * tui/tui-regs.c (tui_reg_layout): New function.
6307         (tui_show_registers, tui_reg_command): Use it.
6308         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6309         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6310         parameters.
6311         (tui_layout_command): Remove.
6312
6313 2019-07-17  Tom Tromey  <tom@tromey.com>
6314
6315         * tui/tui-layout.h (tui/tui-layout): Return void.
6316         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6317
6318 2019-07-17  Tom Tromey  <tom@tromey.com>
6319
6320         * tui/tui-layout.c (show_source_disasm_command, show_data):
6321         Update.
6322         (reset_locator): Remove.
6323         (show_source_or_disasm_and_command): Update.
6324
6325 2019-07-17  Tom Tromey  <tom@tromey.com>
6326
6327         * tui/tui-source.c (tui_source_window_base::reset): Remove
6328         win_type parameter.
6329         * tui/tui-layout.c (make_command_window, make_source_window)
6330         (make_disasm_window, make_data_window)
6331         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6332         (reset_locator, show_source_or_disasm_and_command): Update.
6333         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6334         win_type parameter.
6335         (struct tui_source_window_base) <reset>: Likewise.
6336
6337 2019-07-17  Tom Tromey  <tom@tromey.com>
6338
6339         * tui/tui-layout.c (show_source_disasm_command): Use
6340         reset_locator.
6341         (reset_locator): New function.
6342         (init_and_make_win): Remove.
6343         (show_source_or_disasm_and_command): Use reset_locator.
6344
6345 2019-07-17  Tom Tromey  <tom@tromey.com>
6346
6347         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6348         condition.
6349         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6350         Remove condition.
6351         * tui/tui-source.c (tui_source_window_base::reset): New method.
6352         * tui/tui-layout.c (make_command_window): Don't call
6353         init_and_make_win.
6354         (make_source_window, make_disasm_window): Don't call
6355         make_source_or_disasm_window.
6356         (make_data_window): Don't call init_and_make_win.  Change calling
6357         convention.
6358         (show_source_disasm_command, show_data): Simplify.
6359         (make_source_or_disasm_window): Remove.
6360         (show_source_or_disasm_and_command): Simplify.
6361         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6362         (struct tui_source_window_base) <reset>: Likewise.
6363         <execution_info>: Remove initializer.
6364         * tui/tui-data.c (tui_source_window_base): Initialize
6365         execution_info.
6366
6367 2019-07-17  Tom Tromey  <tom@tromey.com>
6368
6369         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6370         variable.
6371
6372 2019-07-17  Tom Tromey  <tom@tromey.com>
6373
6374         * tui/tui.c (tui_rl_other_window): Update.
6375         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6376         superclass method first.  Always iterate over regs_content.
6377         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6378         method.
6379         * tui/tui-win.c (tui_set_focus_command): Update.
6380
6381 2019-07-17  Tom Tromey  <tom@tromey.com>
6382
6383         * tui/tui-win.c (tui_set_focus_command): Rename from
6384         tui_set_focus.  Call tui_enable.
6385         (tui_set_focus_command): Remove.
6386
6387 2019-07-17  Tom Tromey  <tom@tromey.com>
6388
6389         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6390         refresh_window.
6391         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6392         touchwin.
6393         (tui_data_window::refresh_window): Call refresh_window on data
6394         items.  Always call superclass refresh_window.
6395         (tui_win_info::refresh): Remove.
6396         (tui_source_window_base::refresh_window): Update.
6397         (tui_refresh_all): Update.
6398         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6399         refresh_window.
6400         (show_source_or_disasm_and_command): Likewise.
6401         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6402         (struct tui_source_window_base) <refresh>: Likewise.
6403
6404 2019-07-17  Tom Tromey  <tom@tromey.com>
6405
6406         * tui/tui-winsource.c (tui_clear_source_content)
6407         (tui_show_source_content): Update.
6408         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6409         whether content is empty.
6410         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6411         Remove.
6412
6413 2019-07-17  Tom Tromey  <tom@tromey.com>
6414
6415         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6416         window's contents.
6417         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6418         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6419
6420 2019-07-17  Tom Tromey  <tom@tromey.com>
6421
6422         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6423         (struct tui_data_item_window): Update.
6424
6425 2019-07-17  Tom Tromey  <tom@tromey.com>
6426
6427         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6428         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6429         defines.
6430
6431 2019-07-17  Tom Tromey  <tom@tromey.com>
6432
6433         * tui/tui-winsource.h (tui_erase_source_content)
6434         (tui_clear_source_content): Remove "display_prompt" parameter.
6435         * tui/tui-winsource.c (tui_update_source_window_as_is)
6436         (tui_update_source_windows_with_addr): Update.
6437         (tui_clear_source_content): Remove "display_prompt" parameter.
6438         (tui_erase_source_content): Likewise.  Simplify.
6439         (tui_show_source_content): Update.
6440         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6441         * tui/tui-stack.c (tui_show_frame_info): Update.
6442         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6443         Remove defines.
6444
6445 2019-07-17  Tom Tromey  <tom@tromey.com>
6446
6447         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6448         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6449         parameter.
6450         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6451         parameter.
6452
6453 2019-07-17  Tom Tromey  <tom@tromey.com>
6454
6455         * tui/tui-winsource.c (tui_clear_source_content)
6456         (tui_show_source_content, tui_show_exec_info_content)
6457         (tui_clear_exec_info_content): Update.
6458         * tui/tui-stack.c (tui_show_locator_content): Update.
6459         (tui_show_frame_info): Update.
6460         * tui/tui-source.h (tui_source_window): Don't declare.
6461         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6462         from tui_source_is_displayed.
6463         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6464         Remove field.
6465         (struct tui_source_window_base) <content_in_use>: New field.  Now
6466         bool.
6467         (struct tui_source_window) <showing_source_p>: New method.
6468         (TUI_SRC_WIN): Change cast.
6469         * tui/tui-data.c (tui_initialize_static_data): Update.
6470
6471 2019-07-17  Tom Tromey  <tom@tromey.com>
6472
6473         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6474         location_matches_p.
6475         * tui/tui-source.c (tui_source_window::location_matches_p): New
6476         method.
6477         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6478         method.
6479         * tui/tui-data.h (struct tui_source_window_base)
6480         <location_matches_p>: New method.
6481         (struct tui_source_window, struct tui_disasm_window)
6482         <location_matches_p>: Likewise.
6483
6484 2019-07-17  Tom Tromey  <tom@tromey.com>
6485
6486         * tui/tui-win.c (tui_set_win_height_command): Rename from
6487         tui_set_win_height.
6488         (tui_set_win_height_command): Remove.
6489
6490 2019-07-17  Tom Tromey  <tom@tromey.com>
6491
6492         * tui/tui-source.c (tui_source_window): New constructor.  Add
6493         observer.
6494         (~tui_source_window): New destructor.
6495         (tui_source_window::style_changed): New method.
6496         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6497         (tui_attach_detach_observers): Update.
6498         * tui/tui-data.h (struct tui_source_window): Make constructor not
6499         inline.  Add destructor.
6500         (struct tui_source_window) <style_changed>: New method.
6501         <m_observable>: New member.
6502
6503 2019-07-17  Tom Tromey  <tom@tromey.com>
6504
6505         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6506         * tui/tui-win.c (tui_resize_all): Fix typo.
6507
6508 2019-07-17  Tom Tromey  <tom@tromey.com>
6509
6510         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6511         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6512         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6513         * tui/tui-win.c (window_name_completer): Use foreach.
6514         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6515         (update_tab_width): Likewise.
6516         * tui/tui-layout.c (show_layout): Update.
6517         * tui/tui-data.h (class tui_window_iterator): New.
6518         (struct all_tui_windows): New.
6519         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6520
6521 2019-07-17  Tom Tromey  <tom@tromey.com>
6522
6523         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6524         parameter.  Don't reference globals.
6525         (tui_reg_command): Update.
6526
6527 2019-07-17  Tom Tromey  <tom@tromey.com>
6528
6529         * tui/tui-regs.c (tui_show_registers): Simplify.
6530
6531 2019-07-17  Tom Tromey  <tom@tromey.com>
6532
6533         * tui/tui-regs.c (tui_show_registers): Update.
6534         (tui_show_register_group): Add win_info parameter.
6535
6536 2019-07-17  Tom Tromey  <tom@tromey.com>
6537
6538         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6539         Rename from tui_display_reg_element_at_line.
6540         (tui_data_window::display_registers_from_line): Update.
6541         * tui/tui-data.h (struct tui_data_window)
6542         <display_reg_element_at_line>: New method.
6543
6544 2019-07-17  Tom Tromey  <tom@tromey.com>
6545
6546         * tui/tui-regs.h (tui_display_registers_from)
6547         (tui_display_registers_from_line): Don't declare.
6548         * tui/tui-windata.c (tui_data_window::display_all_data)
6549         (tui_data_window::refresh_all)
6550         (tui_data_window::do_scroll_vertical): Update.
6551         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6552         from tui_display_registers_from.
6553         (tui_display_reg_element_at_line): Update.
6554         (tui_data_window::display_registers_from_line): Rename from
6555         tui_display_registers_from_line.
6556         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6557         display_registers_from_line>: New methods.
6558
6559 2019-07-17  Tom Tromey  <tom@tromey.com>
6560
6561         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6562         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6563         from tui_erase_data_content.
6564         (tui_data_window::display_all_data)
6565         (tui_data_window::refresh_all)
6566         (tui_data_window::do_scroll_vertical): Update.
6567         * tui/tui-regs.c (tui_show_registers): Update.
6568         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6569         New method.
6570
6571 2019-07-17  Tom Tromey  <tom@tromey.com>
6572
6573         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6574         declare.
6575         * tui/tui-windata.c
6576         (tui_data_window::delete_data_content_windows): Rename from
6577         tui_delete_data_content_windows.
6578         (tui_data_window::display_all_data)
6579         (tui_data_window::do_scroll_vertical): Update.
6580         * tui/tui-data.h (struct tui_data_window)
6581         <delete_data_content_windows>: New method.
6582
6583 2019-07-17  Tom Tromey  <tom@tromey.com>
6584
6585         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6586         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6587
6588 2019-07-17  Tom Tromey  <tom@tromey.com>
6589
6590         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6591         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6592         from tui_display_all_data.
6593         * tui/tui-win.c
6594         (tui_data_window::do_make_visible_with_new_height): Update.
6595         * tui/tui-regs.c (tui_show_registers): Update.
6596         * tui/tui-layout.c (tui_set_layout): Update.
6597         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6598         method.
6599
6600 2019-07-17  Tom Tromey  <tom@tromey.com>
6601
6602         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6603         * tui/tui-windata.c (tui_display_data_from): Remove.
6604         (tui_data_window::refresh_all): Update.
6605
6606 2019-07-17  Tom Tromey  <tom@tromey.com>
6607
6608         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6609         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6610         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6611         tui_display_registers_from_line.
6612         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6613         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6614         "force_display" parameter.
6615
6616 2019-07-17  Tom Tromey  <tom@tromey.com>
6617
6618         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6619         declare.
6620         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6621         Rename from tui_first_reg_element_no_inline.
6622         (tui_display_reg_element_at_line)
6623         (tui_display_registers_from_line): Update.
6624         * tui/tui-data.h (struct tui_data_window)
6625         <first_reg_element_no_inline>: New method.
6626
6627 2019-07-17  Tom Tromey  <tom@tromey.com>
6628
6629         * tui/tui-windata.c (tui_display_data_from)
6630         (tui_data_window::do_scroll_vertical): Update.
6631         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6632         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6633         Rename from tui_line_from_reg_element_no.
6634         (tui_display_registers_from_line): Update.
6635         * tui/tui-data.h (struct tui_data_window)
6636         <line_from_reg_element_no>: New method.
6637
6638 2019-07-17  Tom Tromey  <tom@tromey.com>
6639
6640         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6641         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6642         tui_last_regs_line_no.
6643         (tui_display_reg_element_at_line)
6644         (tui_display_registers_from_line): Update.
6645         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6646         method.
6647
6648 2019-07-17  Tom Tromey  <tom@tromey.com>
6649
6650         PR tui/24722:
6651         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6652         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6653         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6654         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6655         (tui_update_breakpoint_info): Likewise.
6656         * tui/tui-hooks.c (tui_event_create_breakpoint)
6657         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6658         Update.
6659
6660 2019-07-17  Tom Tromey  <tom@tromey.com>
6661
6662         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6663
6664 2019-07-17  Tom Tromey  <tom@tromey.com>
6665
6666         * tui/tui-winsource.c (tui_update_source_window_as_is)
6667         (tui_update_source_windows_with_addr): Update.
6668         * tui/tui-source.h (tui_set_source_content)
6669         (tui_show_symtab_source): Add "win_info" parameter.
6670         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6671         parameter.
6672         (tui_show_symtab_source): Likewise.
6673
6674 2019-07-17  Tom Tromey  <tom@tromey.com>
6675
6676         * tui/tui-wingeneral.c
6677         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6678
6679 2019-07-17  Tom Tromey  <tom@tromey.com>
6680
6681         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6682         (struct tui_cmd_window) <can_scroll>: New method.
6683         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6684         method.
6685
6686 2019-07-17  Tom Tromey  <tromey@adacore.com>
6687
6688         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6689         do_field_signed>: Rename.  Change type of "value".
6690         * ui-out.c (ui_out::field_signed): Rename from field_int.
6691         Change type of "value".
6692         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6693         type of "value".
6694         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6695         do_field_int.  Change type of "value".
6696         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6697         do_field_int.  Change type of "value".
6698         * tracepoint.c (trace_status_mi, tfind_1)
6699         (print_one_static_tracepoint_marker): Update.
6700         * thread.c (print_thread_info_1, print_selected_thread_frame):
6701         Update.
6702         * stack.c (print_frame, print_frame_info): Update.
6703         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6704         Update.
6705         * source.c (print_source_lines_base): Update.
6706         * skip.c (info_skip_command): Update.
6707         * record-btrace.c (btrace_ui_out_decode_error)
6708         (btrace_call_history_src_line): Update.
6709         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6710         Update.
6711         * progspace.c (print_program_space): Update.
6712         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6713         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6714         do_field_int.  Change type of "value".
6715         * mi/mi-out.c (mi_ui_out::do_table_begin)
6716         (mi_ui_out::do_table_header): Update.
6717         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6718         type of "value".
6719         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6720         (mi_cmd_data_list_changed_registers, output_register)
6721         (mi_cmd_data_read_memory, mi_load_progress)
6722         (mi_cmd_trace_frame_collected): Update.
6723         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6724         Update.
6725         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6726         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6727         (mi_cmd_var_list_children, varobj_update_one): Update.
6728         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6729         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6730         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6731         * inferior.c (print_inferior): Update.
6732         * gdb_bfd.c (print_one_bfd): Update.
6733         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6734         Update.
6735         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6736         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6737         do_field_int.  Change type of "value".
6738         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6739         do_field_int.  Change type of "value".
6740         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6741         (print_one_breakpoint_location, print_it_catch_fork)
6742         (print_one_catch_fork, print_it_catch_vfork)
6743         (print_one_catch_vfork, print_it_catch_solib)
6744         (print_it_catch_exec, print_it_ranged_breakpoint)
6745         (print_mention_watchpoint, print_mention_masked_watchpoint)
6746         (bkpt_print_it, update_static_tracepoint): Update.
6747         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6748         * break-catch-syscall.c (print_it_catch_syscall): Update.
6749         * ada-tasks.c (print_ada_task_info): Update.
6750         * ada-lang.c (print_it_exception, print_mention_exception):
6751         Update.
6752
6753 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6754
6755         PR breakpoints/24541
6756         * gdbarch.c: Regenerate.
6757         * gdbarch.h: Regenerate.
6758         * gdbarch.sh: Adjust return type and parameter types for
6759         'stap_adjust_register'.
6760         (i386_stap_adjust_register): Adjust signature and return new
6761         register name.
6762         * stap-probe.c (stap_parse_register_operand): Adjust use of
6763         'gdbarch_stap_adjust_register'.
6764
6765 2019-07-17  Tom Tromey  <tromey@adacore.com>
6766
6767         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6768         declare VEC.
6769         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6770         std::vector.
6771         (struct s390_process_info): Add initializers.
6772         (s390_add_process): Use new.
6773         (s390_linux_nat_target::low_forget_process): Use delete.
6774         (s390_linux_nat_target::low_new_fork)
6775         (s390_linux_nat_target::stopped_by_watchpoint)
6776         (s390_linux_nat_target::low_prepare_to_resume)
6777         (s390_linux_nat_target::insert_watchpoint)
6778         (s390_linux_nat_target::insert_hw_breakpoint)
6779         (s390_linux_nat_target::remove_watchpoint)
6780         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6781
6782 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6783
6784         * aarch64-fbsd-nat.c: Include regcache.h.
6785         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6786         argument.
6787         (aarch64_fbsd_nat_target::fetch_registers)
6788         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6789         variable.
6790         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6791
6792 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6793
6794         * fbsd-nat.c: Include gdbarch.h.
6795
6796 2019-07-15  Tom Tromey  <tromey@adacore.com>
6797
6798         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6799
6800 2019-07-15  Tom Tromey  <tromey@adacore.com>
6801
6802         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6803         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6804         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6805         * cli-out.c (cli_ui_out::do_field_int): New method.
6806         * ui-out.c (ui_out::field_unsigned): New method.
6807         * symfile.c (generic_load): Use field_unsigned.
6808         (print_transfer_performance): Likewise.
6809         * record-btrace.c (ui_out_field_uint): Remove.
6810         (btrace_call_history_insn_range, btrace_call_history): Use
6811         field_unsigned.
6812         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6813         field_unsigned.
6814         * ui-out.h (class ui_out) <field_unsigned>: New method.
6815         <do_field_unsigned>: Likewise.
6816
6817 2019-07-15  Tom Tromey  <tromey@adacore.com>
6818
6819         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6820         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6821         * target.c (flash_erase_command): Use field_string.
6822         * infrun.c (print_signal_received_reason): Use field_string.
6823         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6824         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6825         field_string.
6826         * ada-tasks.c (print_ada_task_info): Use field_string.
6827
6828 2019-07-15  Tom Tromey  <tromey@adacore.com>
6829
6830         * target.c (flash_erase_command): Use field_core_addr.
6831         * symfile.c (generic_load): Use field_core_addr.
6832         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6833         Use field_core_addr.
6834         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6835         field_core_addr.
6836
6837 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6838
6839         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6840         value if its desired type is smaller than a CORE_ADDR and signed.
6841
6842 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6843
6844         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6845         of changes to field names, and use new is_reference field to
6846         decide if a property is a reference or not.
6847         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6848         field.
6849         (struct dwarf2_property_baton): Update header comment, rename
6850         'referenced_type' to 'property_type' and update comments.
6851         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6852         default property type, store in property baton, update to take
6853         accound of renamed field.
6854         (read_func_scope): Update call to attr_to_dynamic_prop.
6855         (read_array_type): Likewise.
6856         (dwarf2_per_cu_addr_sized_int_type): New function.
6857         (read_subrange_index_type): Move type finding code to
6858         dwarf2_per_cu_addr_sized_int_type.
6859         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6860         (dwarf2_per_cu_addr_type): New function.
6861         (set_die_type): Update calls to attr_to_dynamic_prop.
6862
6863 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6864
6865         * dwarf2read.c (read_subrange_index_type): New function.
6866         (read_subrange_type): Move code into new function and call it.
6867         * gdbtypes.c (create_range_type): Add some asserts.
6868
6869 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6870
6871         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6872         update return statements.
6873         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6874         declaration, and update comment to match.
6875         * gdbtypes.c (resolve_dynamic_array): Update call to
6876         dwarf2_evaluate_property to match new return type.
6877
6878 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6879
6880         * valarith.c (value_subscripted_rvalue): Change lowerbound
6881         parameter type from int to LONGEST.
6882         * value.h (value_subscripted_rvalue): Likewise in declaration.
6883
6884 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6885
6886         * cli/cli-utils.c (info_print_command_completer): New function.
6887         * cli/cli-utils.h: Add 'completer.h' include, and forward
6888         declaration for 'struct cmd_list_element'.
6889         (info_print_command_completer): Declare.
6890         * stack.c (_initialize_stack): Add completer for 'info locals' and
6891         'info args'.
6892         * symtab.c (_initialize_symtab): Add completer for 'info
6893         variables' and 'info functions'.
6894         * NEWS: Mention completion for additional info commands.
6895
6896 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6897
6898         * cli/cli-utils.c (extract_info_print_args): Delete.
6899         (extract_arg_maybe_quoted): Delete.
6900         (info_print_options_defs): New variable.
6901         (make_info_print_options_def_group): New function.
6902         (extract_info_print_options): Define new function.
6903         * cli/cli-utils.h (extract_info_print_args): Delete.
6904         (struct info_print_options): New structure.
6905         (extract_info_print_options): Declare new function.
6906         * stack.c (info_locals_command): Update to use new
6907         extract_info_print_options, also add a header comment.
6908         (info_args_command): Likewise.
6909         * symtab.c (info_variables_command): Likewise.
6910         (info_functions_command): Likewise.
6911
6912 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6913
6914         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6915         to extract string arguments.
6916         * common/common-utils.c (extract_string_maybe_quoted): New function.
6917         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6918
6919 2019-07-11  Tom Tromey  <tromey@adacore.com>
6920
6921         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6922         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6923         * top.h (gdbinit): Don't declare.
6924         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6925         into...
6926         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6927         * top.c (gdb_init): Don't call init_cli_cmds.
6928         (gdbinit): Remove.
6929         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6930
6931 2019-07-11  Tom Tromey  <tromey@adacore.com>
6932
6933         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6934         after it has been moved.
6935
6936 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6937
6938         * valops.c (value_must_coerce_to_target): Change return type to
6939         bool.
6940         * value.h (value_must_coerce_to_target): Likewise.
6941
6942 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6943
6944         * breakpoint.c (is_hardware_watchpoint): Remove
6945         forward-declaration.
6946         (is_masked_watchpoint): Change return type to bool.
6947         (is_tracepoint): Likewise.
6948         (is_breakpoint): Likewise.
6949         (is_hardware_watchpoint): Likewise.
6950         (is_watchpoint): Likewise.
6951         (is_no_memory_software_watchpoint): Likewise.
6952         (is_catchpoint): Likewise.
6953         (breakpoint_1): Make FILTER parameter's return type bool.
6954         is_masked_watchpoint): Change return type to bool.
6955         (save_breakpoints): Make FILTER parameter's return type bool.
6956         * breakpoint.h (is_breakpoint): Change return type to bool.
6957         (is_watchpoint): Likewise.
6958         (is_catchpoint): Likewise.
6959         (is_tracepoint): Likewise.
6960
6961 2019-07-10  Tom Tromey  <tom@tromey.com>
6962
6963         * defs.h: Don't include gdbarch.h.
6964         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6965         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6966         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6967         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6968         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6969         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6970         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6971         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6972         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6973         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6974         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6975         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6976         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6977         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6978         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6979         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6980         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6981         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6982         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6983         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6984         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6985         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6986         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6987         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6988         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6989         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6990         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6991
6992 2019-07-10  Tom Tromey  <tromey@adacore.com>
6993
6994         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6995         * breakpoint.c (init_ada_exception_breakpoint): Register as
6996         bp_catchpoint.
6997         (print_one_breakpoint_location, print_one_breakpoint): Use
6998         is_ada_exception_catchpoint.
6999         * ada-lang.c (class ada_catchpoint_location): Pass
7000         bp_loc_software_breakpoint to bp_location constructor.
7001         (is_ada_exception_catchpoint): New function.
7002
7003 2019-07-10  Tom Tromey  <tromey@adacore.com>
7004
7005         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7006         VEC.
7007         (struct arm_exidx_entry): New method operator<.
7008         (struct arm_exidx_data) <section_maps>: Change type.
7009         (arm_exidx_data_free): Remove.
7010         (arm_exidx_data_key): Change type.  Move lower.
7011         (arm_exidx_new_objfile): Update.
7012         (arm_compare_exidx_entries): Remove.
7013         (arm_find_exidx_entry, _initialize_arm_tdep)
7014
7015 2019-07-10  Tom Tromey  <tromey@adacore.com>
7016
7017         * solib-spu.c (ocl_program_data_key): Change type.
7018         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7019         Update.
7020
7021 2019-07-10  Tom Tromey  <tromey@adacore.com>
7022
7023         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7024         (struct solib_aix_inferior_data) <library_list>: Change type.
7025         (solib_aix_inferior_data_handle): Change type.
7026         (get_solib_aix_inferior_data): Update.
7027         (solib_aix_free_library_list): Remove.
7028         (library_list_start_library): Update.
7029         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7030         return type.
7031         (solib_aix_get_library_list)
7032         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7033         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7034
7035 2019-07-10  Tom Tromey  <tromey@adacore.com>
7036
7037         * solib-dsbt.c (struct dsbt_info): Add initializers.
7038         (solib_dsbt_pspace_data): Change type.
7039         (dsbt_pspace_data_cleanup): Remove.
7040         (get_dsbt_info, _initialize_dsbt_solib): Update.
7041
7042 2019-07-10  Tom Tromey  <tromey@adacore.com>
7043
7044         * spu-tdep.c (spu_overlay_data): Change type.
7045         (spu_get_overlay_table, spu_overlay_new_objfile)
7046         (_initialize_spu_tdep): Update.
7047
7048 2019-07-10  Tom Tromey  <tromey@adacore.com>
7049
7050         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7051         destructor.
7052         (dbx_objfile_data_key): Change type and declare later.
7053         (DBX_SYMFILE_INFO): Rewrite.
7054         * dbxread.c (dbx_objfile_data_key): Change type.
7055         (dbx_symfile_init): Update.
7056         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7057         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7058         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7059
7060 2019-07-10  Tom Tromey  <tromey@adacore.com>
7061
7062         * jit.c (jit_program_space_key): Change type.  Move lower.
7063         (get_jit_program_space_data): Update.
7064         (jit_program_space_data_cleanup): Remove.
7065         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7066         Update.
7067         (struct jit_program_space_data): Add initializers.
7068
7069 2019-07-10  Tom Tromey  <tromey@adacore.com>
7070
7071         * solib-darwin.c (struct darwin_info): Add initializers.
7072         (solib_darwin_pspace_data): Change type.
7073         (darwin_pspace_data_cleanup): Remove.
7074         (get_darwin_info, _initialize_darwin_solib): Update.
7075
7076 2019-07-10  Tom Tromey  <tromey@adacore.com>
7077
7078         * remote-sim.c (struct sim_inferior_data): Add initializers,
7079         constructor, and destructor.
7080         (sim_inferior_data_key): Change type.  Move lower.
7081         (check_for_duplicate_sim_descriptor): Update.
7082         (get_sim_inferior_data): Use new.  Update.
7083         (~sim_inferior_data_cleanup): Rename from
7084         sim_inferior_data_cleanup.  Simplify.
7085         (gdbsim_close_inferior, simulator_command)
7086         (sim_command_completer, _initialize_remote_sim): Update.
7087         (next_pid, INITIAL_PID): Move earlier.
7088
7089 2019-07-10  Tom Tromey  <tromey@adacore.com>
7090
7091         * python/python-internal.h (create_thread_object): Return
7092         gdbpy_ref.
7093         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7094         * python/py-inferior.c (struct threadlist_entry): Add
7095         constructor.
7096         <thread_obj>: Now a gdbpy_ref.
7097         (thread_to_thread_object): Update.
7098         (add_thread_object): Use new.
7099         (delete_thread_object): Use delete.
7100         (infpy_threads): Update.
7101         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7102         GIL.
7103
7104 2019-07-10  Tom Tromey  <tromey@adacore.com>
7105
7106         * valops.c (value_cast): Specialize error message for Ada.
7107
7108 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7109
7110         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7111
7112 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7113
7114         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7115         bpstat_should_step): Return bool, adjust comments.
7116         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7117         bpstat_should_step): Likewise.
7118
7119 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7120
7121         * features/Makefile: Use feature target descriptions for Arm.
7122         * features/arm/arm-core.c: Generate new file.
7123         * features/arm/arm-fpa.c: Likewise.
7124         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7125         * features/arm/arm-m-profile.c: Likewise.
7126         * features/arm/arm-vfpv2.c: Likewise.
7127         * features/arm/arm-vfpv3.c: Likewise.
7128         * features/arm/xscale-iwmmxt.c: Likewise.
7129         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7130
7131 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7132
7133         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7134         ptrace earlier.
7135
7136 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7137
7138         * features/aarch64-pauth.c: Regenerate.
7139
7140 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7141
7142         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7143         bool.
7144         (bpstat_what): Use false instead of 0.
7145
7146 2019-07-09  Pedro Alves  <palves@redhat.com>
7147
7148         * break-catch-throw.c (is_exception_catchpoint): New.
7149         * breakpoint.c (print_one_breakpoint_location): New parameter
7150         'raw_loc'.  Handle it.  Use
7151         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7152         looking at the breakpoint's type.
7153         (print_one_breakpoint): If handling "maint info breakpoints", also
7154         print locations of exception catchpoints.
7155         * breakpoint.h (is_exception_catchpoint): Declare.
7156
7157 2019-07-09  Pedro Alves  <palves@redhat.com>
7158
7159         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7160         "addr" field.
7161         (allocate_location_exception_catchpoint): New.
7162         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7163         (initialize_throw_catchpoint_ops): Install
7164         allocate_location_exception_catchpoint as allocate_location
7165         method.
7166         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7167         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7168         bp_loc_other.
7169         (breakpoint_address_is_meaningful): Delete.
7170         (bl_address_is_meaningful): New.
7171         (breakpoint_locations_match): Adjust comment.
7172         (bp_location_from_bp_type): New, factored out of...
7173         (bp_location::bp_location(breakpoint *)): ... this.
7174         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7175         factored out of...
7176         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7177         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7178         breakpoint_address_is_meaningful.
7179         (bp_locations_compare): Adjust comment.
7180         (update_global_location_list): Use bl_address_is_meaningful
7181         instead of breakpoint_address_is_meaningful.
7182         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7183         explicit.
7184         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7185         * python/py-breakpoint.c (bppy_get_location): No longer check
7186         whether location is null.
7187
7188 2019-07-09  Pedro Alves  <palves@redhat.com>
7189
7190         PR c++/15468
7191         * breakpoint.c (print_one_breakpoint_location): Remove
7192         single-location assert.
7193
7194 2019-07-09  Tom Tromey  <tom@tromey.com>
7195
7196         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7197         * configure: Rebuild.
7198         * configure.ac: Change common to gdbsupport.
7199         * gdbsupport: Rename from common.
7200         * acinclude.m4: Change common to gdbsupport.
7201         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7202         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7203         gdbsupport.
7204         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7205         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7206         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7207         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7208         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7209         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7210         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7211         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7212         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7213         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7214         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7215         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7216         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7217         coff-pe-read.c, command.h, compile/compile-c-support.c,
7218         compile/compile-c.h, compile/compile-cplus-symbols.c,
7219         compile/compile-cplus-types.c, compile/compile-cplus.h,
7220         compile/compile-loc2c.c, compile/compile.c, completer.c,
7221         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7222         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7223         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7224         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7225         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7226         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7227         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7228         features/aarch64-core.c, features/aarch64-fpu.c,
7229         features/aarch64-pauth.c, features/aarch64-sve.c,
7230         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7231         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7232         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7233         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7234         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7235         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7236         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7237         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7238         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7239         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7240         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7241         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7242         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7243         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7244         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7245         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7246         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7247         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7248         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7249         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7250         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7251         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7252         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7253         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7254         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7255         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7256         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7257         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7258         minsyms.c, mips-linux-tdep.c, namespace.h,
7259         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7260         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7261         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7262         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7263         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7264         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7265         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7266         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7267         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7268         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7269         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7270         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7271         procfs.c, producer.c, progspace.h, psymtab.h,
7272         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7273         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7274         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7275         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7276         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7277         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7278         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7279         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7280         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7281         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7282         target-memory.c, target.c, target.h, target/waitstatus.c,
7283         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7284         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7285         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7286         unittests/array-view-selftests.c,
7287         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7288         unittests/common-utils-selftests.c,
7289         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7290         unittests/format_pieces-selftests.c,
7291         unittests/function-view-selftests.c,
7292         unittests/lookup_name_info-selftests.c,
7293         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7294         unittests/mkdir-recursive-selftests.c,
7295         unittests/observable-selftests.c,
7296         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7297         unittests/parse-connection-spec-selftests.c,
7298         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7299         unittests/scoped_fd-selftests.c,
7300         unittests/scoped_mmap-selftests.c,
7301         unittests/scoped_restore-selftests.c,
7302         unittests/string_view-selftests.c, unittests/style-selftests.c,
7303         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7304         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7305         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7306         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7307         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7308         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7309
7310 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7311
7312         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7313         bool value.
7314         (decode_digits_ordinary): Set explicit_line field in sal.
7315         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7316         symtab_and_line that was set on an explicit line number in
7317         assembler code.  Do always update the recorded symtab and line if
7318         we do skip the prologue.
7319
7320 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7321
7322         * breakpoint.c (set_breakpoint_location_function): Remove
7323         explicit_loc parameter.
7324         (momentary_breakpoint_from_master): Update call to
7325         set_breakpoint_location_function.
7326         (add_location_to_breakpoint): Likewise.
7327
7328 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7329
7330         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7331         required features based on default bfd type when no specific bfd
7332         is present.
7333
7334 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7335
7336         * NEWS: Mention that GDB printf and eval commands can now print
7337         C-style and Ada-style convenience var strings without
7338         calling the inferior.
7339         * printcmd.c (printf_c_string): Locally print GDB internal var
7340         instead of transiting via the inferior.
7341         (printf_wide_c_string): Likewise.
7342
7343 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7344
7345         PR breakpoints/25011
7346         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7347
7348 2019-07-04  Tom Tromey  <tom@tromey.com>
7349
7350         PR tui/24724:
7351         * tui/tui-winsource.c (tui_clear_source_content): Update.
7352         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7353         (tui_update_breakpoint_info): Update.
7354         (tui_set_exec_info_content): Update.
7355         * tui/tui-source.c (tui_set_source_content_nil): Update.
7356         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7357         has_break.
7358         * tui/tui-data.h (enum tui_bp_flag): New.
7359         (tui_bp_flags): New enum flags type.
7360         (struct tui_source_element) <break_mode>: Change type.  Rename
7361         from has_break.
7362         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7363         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7364         constants.
7365         * tui/tui-winsource.h: Fix comment.
7366
7367 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7368
7369         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7370         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7371         (store_fpregs_to_thread)
7372         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7373         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7374         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7375         (IWMMXT_REGS_SIZE): Add define.
7376         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7377         (fetch_vfp_regs, store_vfp_regs)
7378         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7379         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7380
7381 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7382
7383         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7384         defines.
7385         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7386         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7387         (ARM_INT_REGISTER_SIZE): ...to this.
7388         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7389         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7390         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7391         (arm_linux_collect_gregset, supply_nwfpe_register)
7392         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7393         defines.
7394         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7395         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7396         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7397         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7398         (arm_return_in_memory, arm_store_return_value)
7399         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7400         (arm_record_ld_st_multiple): Likewise.
7401         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7402         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7403
7404 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7405
7406         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7407         AARCH64_DISPLACED_MODIFIED_INSNS.
7408         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7409         (aarch64_displaced_step_copy_insn): Likewise.
7410         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7411         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7412         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7413         ARM_DISPLACED_MODIFIED_INSNS.
7414         * arm-tdep.c (arm_gdbarch_init): Likewise.
7415         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7416         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7417         (struct arm_displaced_step_closure): Use
7418         ARM_DISPLACED_MODIFIED_INSNS.
7419
7420 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7421
7422         * features/Makefile: Remove unused xml files.
7423         * features/aarch64.xml: Remove.
7424         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7425         * features/i386/amd64-avx-avx512.xml: Remove.
7426         * features/i386/amd64-avx-linux.xml: Remove.
7427         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7428         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7429         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7430         * features/i386/amd64-avx-mpx.xml: Remove.
7431         * features/i386/amd64-avx.xml: Remove.
7432         * features/i386/amd64-linux.xml: Remove.
7433         * features/i386/amd64-mpx-linux.xml: Remove.
7434         * features/i386/amd64-mpx.xml: Remove.
7435         * features/i386/amd64.xml: Remove.
7436         * features/i386/i386-avx-avx512-linux.xml: Remove.
7437         * features/i386/i386-avx-avx512.xml: Remove.
7438         * features/i386/i386-avx-linux.xml: Remove.
7439         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7440         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7441         * features/i386/i386-avx-mpx-linux.xml: Remove.
7442         * features/i386/i386-avx-mpx.xml: Remove.
7443         * features/i386/i386-avx.xml: Remove.
7444         * features/i386/i386-linux.xml: Remove.
7445         * features/i386/i386-mmx-linux.xml: Remove.
7446         * features/i386/i386-mmx.xml: Remove.
7447         * features/i386/i386-mpx-linux.xml: Remove.
7448         * features/i386/i386-mpx.xml: Remove.
7449         * features/i386/i386.xml: Remove.
7450         * features/i386/x32-avx-avx512-linux.xml: Remove.
7451         * features/i386/x32-avx-linux.xml: Remove.
7452         * features/i386/x32-linux.xml: Remove.
7453
7454 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7455
7456         * regformats/aarch64.dat: Remove.
7457         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7458         * regformats/i386/amd64-avx-linux.dat: Remove.
7459         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7460         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7461         * regformats/i386/amd64-linux.dat: Remove.
7462         * regformats/i386/amd64-mpx-linux.dat: Remove.
7463         * regformats/i386/amd64.dat: Remove.
7464         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7465         * regformats/i386/i386-avx-linux.dat: Remove.
7466         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7467         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7468         * regformats/i386/i386-linux.dat: Remove.
7469         * regformats/i386/i386-mmx-linux.dat: Remove.
7470         * regformats/i386/i386-mpx-linux.dat: Remove.
7471         * regformats/i386/i386.dat: Remove.
7472         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7473         * regformats/i386/x32-avx-linux.dat: Remove.
7474         * regformats/i386/x32-linux.dat: Remove.
7475
7476 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7477
7478         * aarch64-tdep.c: Remove xml self tests.
7479         * amd64-linux-tdep.c: Likewise.
7480         * amd64-tdep.c: Likewise.
7481         * i386-linux-tdep.c: Likewise.
7482         * i386-tdep.c: Likewise.
7483
7484 2019-07-03  Pedro Alves  <palves@redhat.com>
7485
7486         PR cli/24732
7487         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7488         (pipe_cmd_option_defs): New.
7489         (make_pipe_cmd_options_def_group): New.
7490         (pipe_command): Use gdb::option::process_options.
7491         (pipe_command_completer): New function.
7492         (_initialize_cli_cmds): Install completer for "pipe" command.
7493
7494 2019-07-03  Pedro Alves  <palves@redhat.com>
7495
7496         * cli/cli-option.c (union option_value) <string>: New field.
7497         (struct option_def_and_value): Add ctor, move ctor, dtor and
7498         use DISABLE_COPY_AND_ASSIGN.
7499         (option_def_and_value::clear_value): New.
7500         (parse_option, save_option_value_in_ctx, get_val_type_str)
7501         (add_setshow_cmds_for_options): Handle var_string.
7502         * cli-option.h (union option_def::var_address) <string>: New
7503         field.
7504         (struct string_option_def): New.
7505         * maint-test-options.c (struct test_options_opts): Add default
7506         ctor and use DISABLE_COPY_AND_ASSIGN.
7507         <string_opt>: New field.
7508         (test_options_opts::~test_options_opts): New.
7509         (test_options_opts::dump): Also dump "-string".
7510         (test_options_option_defs): Install "string.
7511
7512 2019-07-03  Pedro Alves  <palves@redhat.com>
7513
7514         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7515         option_value with a null enumeration.
7516         (complete_options): Save the option values in the context.
7517         (save_option_value_in_ctx): New, factored out from ...
7518         (process_options): ... here.
7519         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7520         of the function.
7521         * maint-test-options.c (test_options_opts::dump): New, factored
7522         out from ...
7523         (maintenance_test_options_command_mode): ... here.
7524         (maintenance_test_options_command_completion_result): Delete.
7525         (maintenance_test_options_command_completion_text): Update
7526         comment.
7527         (maintenance_show_test_options_completion_result): Change
7528         prototype.  Just print
7529         maintenance_test_options_command_completion_text.
7530         (save_completion_result): New.
7531         (maintenance_test_options_completer_mode): Pass options context to
7532         complete_options, and then save a dump.
7533         (_initialize_maint_test_options): Use add_cmd to install "maint
7534         show test-options-completion-result".
7535
7536 2019-07-03  Pedro Alves  <palves@redhat.com>
7537
7538         * NEWS (New commands): Mention "with" and "maint with".
7539         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7540         (with_command, with_command_completer): New.
7541         (pipe_command): Adjust to new repeat_previous
7542         interface.
7543         (_initialize_cli_cmds): Install the "with" command and its "w"
7544         alias.
7545         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7546         declarations.
7547         * cli/cli-setshow.c (parse_cli_var_uinteger)
7548         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7549         argument strings for all var_types.
7550         (get_setshow_command_value_string): New, factored out from ...
7551         (do_show_command): ... this.
7552         * cli/cli-setshow.h: Include <string>.
7553         (get_setshow_command_value_string): Declare.
7554         * command.h (repeat_previous): Now returns const char *.  Adjust
7555         comment.
7556         * maint.c: Include "cli/cli-cmds.h".
7557         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7558         (_initialize_maint_cmds): Register the "maintenance with" command.
7559         * top.c (repeat_previous): Move bits from pipe_command here:
7560         Return the saved command line, if any; error out if there's no
7561         command to relaunch.
7562
7563 2019-07-03  Pedro Alves  <palves@redhat.com>
7564
7565         * NEWS (New commands): Mention "maint set/show test-settings"
7566         instead of "maint test-settings".
7567         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7568         (maintenance_test_settings_set_list): Rename to ...
7569         (maintenance_set_test_settings_list): ... this.
7570         (maintenance_test_settings_show_list): Rename to  ...
7571         (maintenance_show_test_settings_list): ... this.
7572         (maintenance_test_settings_cmd): Delete.
7573         (maintenance_test_settings_set_cmd): ...
7574         (maintenance_set_test_settings_cmd): ... this.
7575         (maintenance_test_settings_show_cmd): ...
7576         (maintenance_show_test_settings_cmd): ... this.
7577         (maintenance_test_settings_show_value_cmd):
7578         (maintenance_show_test_settings_value_cmd): ... this.
7579         (_initialize_maint_test_settings): No longer install the "maint
7580         test-settings" prefix command.  Rename "maint test-settings set"
7581         to "maint set test-settings", and "maint test-settings show" to
7582         "maint show test-settings".  Adjust all subcommands.
7583
7584 2019-07-03  Pedro Alves  <palves@redhat.com>
7585
7586         * maint-test-settings.c: Fix file's intro comment.  Replace all
7587         references to "test-options" with references to "test-settings",
7588         in comments.
7589
7590 2019-07-03  Pedro Alves  <palves@redhat.com>
7591
7592         * maint-test-settings.c (maintenance_test_settings_xxx)
7593         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7594         New.
7595         (maintenance_test_settings_enums): Use them.
7596         (maintenance_test_settings_enum): Default to
7597         maintenance_test_settings_xxx.
7598         (_initialize_maint_test_settings): Initialize
7599         MAINTENANCE_TEST_SETTINGS_FILENAME.
7600
7601 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7602
7603         * breakpoint.h (remove_breakpoints_inf): Change return type to
7604         void, move function documentation here.
7605         * breakpoint.c (remove_breakpoints_inf): Change return type to
7606         void, move function documentation to header.
7607
7608 2019-07-02  Pedro Alves  <palves@redhat.com>
7609
7610         * NEWS (Completion improvements): Mention "info threads".
7611         * thread.c (struct info_threads_opts, info_threads_option_defs)
7612         (make_info_threads_options_def_group): New.
7613         (info_threads_command): Use gdb::option::process_options.
7614         (info_threads_command_completer): New.
7615         (_initialize_thread): Use gdb::option::build_help to build the
7616         help text for "info threads".
7617
7618 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7619
7620         * defs.h (generic_load): Move from here...
7621         * symfile.h (generic_load): ... to here.  Rename name parameter
7622         to args.
7623         * symfile.c (generic_load): Add comment.
7624
7625 2019-07-01  Tom Tromey  <tromey@adacore.com>
7626
7627         * dwarf2read.c
7628         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7629         declaration of without_params.  Fix formatting.
7630
7631 2019-07-01  Tom Tromey  <tromey@adacore.com>
7632
7633         * ada-exp.y (find_primitive_type): Update.
7634         * ada-lang.h (ada_lookup_symbol): Update.
7635         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7636         parameter.
7637         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7638
7639 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7640
7641         PR breakpoints/24541
7642         * gdbarch.c: Regenerate.
7643         * gdbarch.h: Regenerate.
7644         * gdbarch.sh: Add 'stap_adjust_register'.
7645         * i386-tdep.c: Include '<unordered_set>'.
7646         (i386_stap_adjust_register): New function.
7647         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7648         * stap-probe.c (stap_parse_register_operand): Call
7649         'gdbarch_stap_adjust_register'.
7650
7651 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7652
7653         PR python/24742
7654         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7655         * python/python.c (do_start_initialization): Use 'xmalloc'
7656         instead of 'PyMem_Malloc'.
7657
7658 2019-06-28  Tom Tromey  <tromey@adacore.com>
7659
7660         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7661         for Ada.
7662
7663 2019-06-27  Tom Tromey  <tromey@adacore.com>
7664
7665         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7666         objfile_key.
7667         (arm_find_mapping_symbol, arm_record_special_symbol)
7668         (_initialize_arm_tdep): Update.
7669         (arm_objfile_data_free): Remove.
7670
7671 2019-06-27  Tom Tromey  <tromey@adacore.com>
7672
7673         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7674         to cp_print_static_field.
7675
7676 2019-06-26  Tom Tromey  <tromey@adacore.com>
7677
7678         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7679         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7680         declare.
7681
7682 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7683
7684         * features/aarch64-core.c (create_feature_aarch64_core):
7685         Regenerate.
7686         * features/aarch64-core.xml: Add cpsr flags.
7687
7688 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7689
7690         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7691         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7692
7693 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7694
7695         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7696         field.
7697         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7698         use.
7699         (arm_record_special_symbol): Don't insert new symbol in sorted
7700         position, push it at the end.
7701
7702 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7703
7704         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7705         (arm_mapping_symbol_s): Remove.
7706         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7707         (arm_mapping_symbol_vec): New typedef.
7708         (struct arm_per_objfile): Add constructor.
7709         <section_maps>: Change type to
7710         std::unique_ptr<arm_mapping_symbol_vec[]>.
7711         (arm_compare_mapping_symbols): Remove.
7712         (arm_find_mapping_symbol): Adjust to section_maps type change.
7713         (arm_objfile_data_free): Call delete on arm_per_objfile.
7714         (arm_record_special_symbol): Adjust to section_maps type change.
7715         Allocate arm_per_objfile with new.
7716
7717 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7718
7719         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7720         with the command prefix.
7721
7722 2019-06-25  Tom Tromey  <tom@tromey.com>
7723
7724         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7725         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7726
7727 2019-06-25  Tom Tromey  <tom@tromey.com>
7728
7729         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7730         type.
7731         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7732         protected.
7733
7734 2019-06-25  Tom Tromey  <tom@tromey.com>
7735
7736         * tui/tui-winsource.c
7737         (tui_source_window_base::set_is_exec_point_at): Add check against
7738         LOA_ADDRESS.
7739
7740 2019-06-25  Tom Tromey  <tom@tromey.com>
7741
7742         * tui/tui-source.c (tui_set_source_content): Don't check before
7743         xfree.
7744         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7745
7746 2019-06-25  Tom Tromey  <tom@tromey.com>
7747
7748         * tui/tui-winsource.h (tui_update_source_window_as_is)
7749         (tui_alloc_source_buffer, tui_line_is_displayed)
7750         (tui_addr_is_displayed): Change type of win_info.
7751         * tui/tui-winsource.c (tui_update_source_window_as_is)
7752         (tui_clear_source_content, tui_show_source_line)
7753         (tui_show_source_content, tui_source_window_base::refill)
7754         (tui_source_window_base::set_is_exec_point_at)
7755         (tui_source_window_base::set_is_exec_point_at)
7756         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7757         (tui_alloc_source_buffer, tui_line_is_displayed)
7758         (tui_addr_is_displayed): Change type of win_info.  Update.
7759         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7760         (tui_source_window_base::do_make_visible_with_new_height):
7761         Update.
7762         * tui/tui-source.c (tui_set_source_content)
7763         (tui_set_source_content_nil)
7764         (tui_source_window::do_scroll_vertical): Update.
7765         * tui/tui-layout.c (show_layout): Update.
7766         * tui/tui-disasm.c (tui_set_disassem_content)
7767         (tui_disasm_window::do_scroll_vertical): Update.
7768         * tui/tui-data.h (tui_win_content): Remove.
7769         (struct tui_gen_win_info) <content, content_size>: Remove.
7770         (struct tui_source_element): Add initializers and destructor.
7771         (union tui_which_element, struct tui_win_element): Remove.
7772         (struct tui_source_window_base) <content>: New field.
7773         (struct tui_data_window): Remove destructor.
7774         (tui_alloc_content, tui_free_win_content)
7775         (tui_free_all_source_wins_content): Don't declare.
7776         * tui/tui-data.c (tui_initialize_static_data): Update.
7777         (init_content_element, tui_alloc_content): Remove.
7778         (~tui_gen_win_info): Update.
7779         (~tui_data_window, tui_free_all_source_wins_content)
7780         (tui_free_win_content, free_content, free_content_elements):
7781         Remove.
7782
7783 2019-06-25  Tom Tromey  <tom@tromey.com>
7784
7785         * tui/tui-winsource.h (tui_clear_source_content)
7786         (tui_erase_source_content, tui_show_source_content): Change type
7787         of win_info.
7788         * tui/tui-winsource.c (tui_clear_source_content)
7789         (tui_erase_source_content, tui_show_source_content): Change type
7790         of win_info.
7791         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7792         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7793         win_info.
7794         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7795         win_info.
7796         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7797
7798 2019-06-25  Tom Tromey  <tom@tromey.com>
7799
7800         * tui/tui-winsource.c (tui_clear_source_content)
7801         (tui_source_window_base::set_is_exec_point_at): Update.
7802         * tui/tui-source.c (tui_set_source_content_nil): Update.
7803         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7804         a bool.
7805         * tui/tui-data.c (init_content_element): Update.
7806
7807 2019-06-25  Tom Tromey  <tom@tromey.com>
7808
7809         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7810         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7811         * tui/tui-layout.c (init_and_make_win): Update.
7812         * tui/tui.h (enum tui_win_type): Update.
7813         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7814         tui_win_is_auxillary.
7815         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7816         tui_win_is_auxillary.
7817
7818 2019-06-25  Tom Tromey  <tom@tromey.com>
7819
7820         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7821         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7822         (tui_delete_data_content_windows, tui_display_all_data)
7823         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7824         Update.
7825         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7826         * tui/tui-regs.c (tui_last_regs_line_no)
7827         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7828         (tui_show_registers): Update.
7829         (tui_show_register_group): Return void.  Update.
7830         (tui_display_registers_from, tui_display_reg_element_at_line)
7831         (tui_display_registers_from_line, tui_check_register_values):
7832         Update.
7833         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7834         member.
7835         (struct tui_data_window) <regs_content>: Now a std::vector.
7836         <regs_content_count>: Remove.
7837         (tui_add_content_elements, tui_free_data_content): Don't declare.
7838         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7839         (init_content_element): Remove DATA_WIN case.  Add assert.
7840         (tui_add_content_elements): Remove.
7841         (tui_data_window): Update.
7842         (tui_free_data_content): Remove.
7843         (free_content_elements): Remove DATA_WIN case.
7844
7845 2019-06-25  Tom Tromey  <tom@tromey.com>
7846
7847         * tui/tui-data.c (tui_data_item_window): Update.
7848         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7849         * tui/tui-windata.c (tui_display_all_data)
7850         (tui_display_data_from_line): Update.
7851         (tui_check_data_values): Remove.
7852         * tui/tui-regs.c (tui_show_register_group)
7853         (tui_display_reg_element_at_line): Update.
7854         * tui/tui-hooks.c (tui_register_changed)
7855         (tui_refresh_frame_and_register_information): Call
7856         tui_check_register_values.
7857         * tui/tui-data.h (struct tui_data_window) <data_content,
7858         data_content_count, data_type>: Remove.
7859         (enum tui_data_type): Remove.
7860
7861         * tui/tui-data.c (tui_data_window::clear_detail)
7862         (~tui_data_window): Update.
7863
7864 2019-06-25  Tom Tromey  <tom@tromey.com>
7865
7866         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7867         declare.
7868         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7869         Rename from tui_first_data_item_displayed.  Update.
7870         (tui_data_window::refresh_all)
7871         (tui_data_window::do_scroll_vertical): Update.
7872         * tui/tui-data.h (struct tui_data_window)
7873         <first_data_item_displayed>: Declare new method.
7874
7875 2019-06-25  Tom Tromey  <tom@tromey.com>
7876
7877         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7878         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7879         contents...
7880         (tui_initialize_static_data): ...here.
7881
7882 2019-06-25  Tom Tromey  <tom@tromey.com>
7883
7884         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7885         (tui_display_registers_from, tui_check_register_values): Update.
7886         (tui_display_register): Remove win_info parameter; update.
7887         (tui_get_register): Change type of parameters.
7888         * tui/tui-data.h (struct tui_data_element): Remove.
7889         (union tui_which_element) <data>: Remove.
7890         <data_window>: Change type.
7891         (struct tui_data_item_window): New.
7892         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7893         case.  Add assert.
7894         (~tui_data_item_window): New destructor.
7895         (free_content_elements): Remove DATA_ITEM_WIN case.
7896
7897 2019-06-25  Tom Tromey  <tom@tromey.com>
7898
7899         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7900         Remove.
7901
7902 2019-06-25  Tom Tromey  <tom@tromey.com>
7903
7904         * tui/tui-data.h (struct tui_command_element): Remove.
7905         (union tui_which_element) <command>: Remove.
7906         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7907         assert.
7908         (free_content_elements): Remove CMD_WIN case.
7909
7910 2019-06-25  Tom Tromey  <tom@tromey.com>
7911
7912         * tui/tui-layout.c (tui_set_layout): Update.
7913         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7914         * tui/tui-data.c (layout_def): Update.
7915
7916 2019-06-25  Tom Tromey  <tom@tromey.com>
7917
7918         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7919         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7920         (tui_source_window_base::set_new_height): Update.
7921         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7922         Update.
7923         (tui_set_locator_fullname, tui_set_locator_info)
7924         (tui_show_frame_info): Update.
7925         * tui/tui-source.c (tui_set_source_content)
7926         (tui_source_is_displayed): Update.
7927         * tui/tui-layout.c (show_source_disasm_command, show_data)
7928         (show_source_or_disasm_and_command): Update.
7929         * tui/tui-disasm.c (tui_set_disassem_content)
7930         (tui_get_begin_asm_address): Update.
7931         * tui/tui-data.h (struct tui_locator_element): Remove.
7932         (union tui_which_element) <locator>: Remove.
7933         (struct tui_locator_window): New.
7934         (tui_locator_win_info_ptr): Change return type.
7935         * tui/tui-data.c (_locator): Change type.
7936         (tui_locator_win_info_ptr): Change return type.
7937         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7938         (tui_alloc_content): Add assert.
7939
7940 2019-06-25  Tom Tromey  <tom@tromey.com>
7941
7942         * tui/tui-winsource.c
7943         (tui_exec_info_window::maybe_allocate_content): New method.
7944         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7945         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7946         (make_source_or_disasm_window): Add cast.
7947         * tui/tui-data.h (union tui_which_element) <simple_string>:
7948         Remove.
7949         (struct tui_source_info): New.
7950         (struct tui_source_window_base) <execution_info>: Change type.
7951         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7952         case, and add assert.
7953         (tui_alloc_content): Add assert.
7954
7955 2019-06-25  Tom Tromey  <tom@tromey.com>
7956
7957         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7958         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7959         * tui/tui-data.c (tui_alloc_win_info): Remove.
7960
7961 2019-06-25  Tom Tromey  <tom@tromey.com>
7962
7963         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7964         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7965         can_highlight.
7966
7967 2019-06-25  Tom Tromey  <tom@tromey.com>
7968
7969         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7970         make_visible_with_new_height method.
7971         (tui_win_info::make_visible_with_new_height): New method.
7972         (tui_source_window_base::do_make_visible_with_new_height)
7973         (tui_data_window::do_make_visible_with_new_height)
7974         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7975         (make_visible_with_new_height): Remove.
7976         (tui_resize_all, tui_adjust_win_heights): Use
7977         make_visible_with_new_height method.
7978         * tui/tui-data.h (struct tui_win_info)
7979         <do_make_visible_with_new_height, make_visible_with_new_height>:
7980         New methods.
7981         (struct tui_source_window_base, struct tui_data_window)
7982         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7983         methods.
7984
7985 2019-06-25  Tom Tromey  <tom@tromey.com>
7986
7987         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7988         method.
7989         (update_tab_width): Call update_tab_width method.
7990         * tui/tui-data.h (struct tui_win_info)
7991         (struct tui_source_window_base) <update_tab_width>: New methods.
7992
7993 2019-06-25  Tom Tromey  <tom@tromey.com>
7994
7995         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7996         parameter.
7997         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7998         parameter.
7999         (tui_gen_win_info::make_visible): Update.
8000         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8001         parameter.
8002         * tui/tui-data.h (enum tui_box): New enum.
8003         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8004
8005 2019-06-25  Tom Tromey  <tom@tromey.com>
8006
8007         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8008         init_and_make_win for EXEC_INFO_WIN.
8009         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8010         longer inline.
8011         (struct tui_win_info) <~tui_win_info>: Inline.
8012         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8013         Don't declare.
8014         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8015         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8016         Remove.
8017         (tui_initialize_static_data): Update.
8018         (~tui_gen_win_info): Handle more cleanup here.
8019         (~tui_source_window_base): Delete "execution_info".
8020         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8021
8022 2019-06-25  Tom Tromey  <tom@tromey.com>
8023
8024         * tui/tui-layout.c (make_command_window): Don't set
8025         can_highlight.
8026         (show_source_disasm_command): Call the reset method.
8027         (show_data): Don't set can_highlight.  Call the reset method.
8028         (tui_gen_win_info::reset): Rename from init_gen_win_info
8029         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8030         (show_source_or_disasm_and_command): Call the reset method.
8031         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8032         (struct tui_cmd_window): Set can_highlight.
8033
8034 2019-06-25  Tom Tromey  <tom@tromey.com>
8035
8036         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8037         from make_visible.
8038         (tui_make_visible, tui_make_invisible): Rewrite.
8039         (tui_win_info::make_visible): Remove.
8040         (tui_source_window_base::make_visible): Update.
8041         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8042         method.  Moved from...
8043         (struct tui_win_info) <make_visible>: ...here.
8044
8045 2019-06-25  Tom Tromey  <tom@tromey.com>
8046
8047         * tui/tui-winsource.c
8048         (tui_source_window_base::do_scroll_horizontal): Remove direction
8049         parameter.
8050         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8051         direction parameter.
8052         * tui/tui-win.c (tui_win_info::forward_scroll)
8053         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8054         (tui_win_info::right_scroll): Update.
8055         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8056         direction parameter.
8057         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8058         direction parameter.
8059         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8060         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8061         Remove direction parameter.
8062         (struct tui_source_window_base, struct tui_source_window)
8063         (struct tui_disasm_window, struct tui_data_window)
8064         (struct tui_cmd_window): Update.
8065
8066 2019-06-25  Tom Tromey  <tom@tromey.com>
8067
8068         * tui/tui-winsource.h (tui_set_exec_info_content)
8069         (tui_show_exec_info_content, tui_erase_exec_info_content)
8070         (tui_clear_exec_info_content, tui_update_exec_info): Change
8071         argument to tui_source_window_base.
8072         * tui/tui-winsource.c (tui_set_exec_info_content)
8073         (tui_show_exec_info_content, tui_erase_exec_info_content)
8074         (tui_clear_exec_info_content, tui_update_exec_info): Change
8075         argument to tui_source_window_base.
8076
8077 2019-06-25  Tom Tromey  <tom@tromey.com>
8078
8079         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8080         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8081
8082 2019-06-25  Tom Tromey  <tom@tromey.com>
8083
8084         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8085         check.
8086
8087 2019-06-25  Tom Tromey  <tom@tromey.com>
8088
8089         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8090         type to void.
8091         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8092         type to void.
8093         * tui/tui-source.c (tui_set_source_content): Update.
8094         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8095
8096 2019-06-25  Tom Tromey  <tom@tromey.com>
8097
8098         * tui/tui-win.c (window_name_completer, tui_set_focus)
8099         (tui_all_windows_info): Use name method.
8100         * tui/tui-data.h (struct tui_gen_win_info)
8101         (struct tui_source_window, struct tui_disasm_window)
8102         (struct tui_data_window, struct tui_cmd_window) <name>: New
8103         method.
8104         (tui_win_name): Don't declare.
8105         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8106         (tui_win_name): Remove.
8107
8108 2019-06-25  Tom Tromey  <tom@tromey.com>
8109
8110         * tui/tui-winsource.h (tui_update_source_window)
8111         (tui_update_source_window_as_is): Change parameter type.
8112         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8113         to be a tui_source_window_base.
8114         (tui_update_source_window_as_is): Likewise.
8115         * tui/tui-win.c (make_visible_with_new_height): Update.
8116
8117 2019-06-25  Tom Tromey  <tom@tromey.com>
8118
8119         * tui/tui-winsource.c (tui_erase_source_content)
8120         (tui_show_source_content, tui_show_exec_info_content)
8121         (tui_erase_exec_info_content): Use refresh_window method.
8122         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8123         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8124         from tui_refresh_win.
8125         (tui_data_window::refresh_window): New method.
8126         (tui_win_info::refresh, tui_source_window_base::refresh)
8127         (tui_refresh_all): Use refresh_window method.
8128         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8129         method.
8130         * tui/tui-regs.c (tui_display_register): Call refresh_window
8131         method.
8132         * tui/tui-layout.c (show_source_disasm_command)
8133         (show_source_or_disasm_and_command): Call refresh_window method.
8134         * tui/tui-data.h (struct tui_gen_win_info)
8135         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8136         New method.
8137
8138 2019-06-25  Tom Tromey  <tom@tromey.com>
8139
8140         * tui/tui.c (tui_rl_other_window, tui_enable)
8141         (tui_is_window_visible, tui_get_command_dimension): Update.
8142         * tui/tui-winsource.c (tui_update_source_window_as_is)
8143         (tui_clear_source_content, tui_erase_source_content)
8144         (tui_show_source_line, tui_source_window_base::refill)
8145         (tui_source_window_base::do_scroll_horizontal)
8146         (tui_source_window_base::set_is_exec_point_at)
8147         (tui_update_breakpoint_info, tui_set_exec_info_content)
8148         (tui_alloc_source_buffer, tui_line_is_displayed)
8149         (tui_addr_is_displayed): Update.
8150         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8151         (tui_check_and_display_highlight_if_needed)
8152         (tui_win_info::make_visible, tui_win_info::refresh)
8153         (tui_refresh_all): Update.
8154         * tui/tui-windata.c (tui_first_data_item_displayed)
8155         (tui_delete_data_content_windows, tui_erase_data_content)
8156         (tui_display_all_data, tui_data_window::refresh_all)
8157         (tui_check_data_values): Update.
8158         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8159         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8160         (tui_win_info::backward_scroll, tui_refresh_all_win)
8161         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8162         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8163         (tui_source_window_base::set_new_height)
8164         (tui_data_window::set_new_height)
8165         (make_invisible_and_set_new_height)
8166         (make_visible_with_new_height, new_height_ok)
8167         (parse_scrolling_args): Update.
8168         * tui/tui-stack.c (tui_show_frame_info): Update.
8169         * tui/tui-source.c (tui_set_source_content)
8170         (tui_set_source_content_nil, tui_source_is_displayed)
8171         (tui_source_window::do_scroll_vertical): Update.
8172         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8173         (tui_display_registers_from, tui_display_reg_element_at_line)
8174         (tui_check_register_values, tui_reg_command): Update.
8175         * tui/tui-layout.c (tui_default_win_height)
8176         (show_source_disasm_command, show_data, init_and_make_win)
8177         (show_source_or_disasm_and_command): Update.
8178         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8179         (tui_redisplay_readline, tui_mld_flush)
8180         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8181         (tui_getc): Update.
8182         * tui/tui-disasm.c (tui_set_disassem_content)
8183         (tui_disasm_window::do_scroll_vertical): Update.
8184         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8185         Now virtual.
8186         (struct tui_win_info): Derive from tui_gen_win_info.
8187         <~tui_win_info>: Mark as override.
8188         <generic>: Remove member.
8189         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8190         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8191         (~tui_data_window, ~tui_win_info)
8192         (tui_free_all_source_wins_content): Update.
8193         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8194
8195 2019-06-25  Tom Tromey  <tom@tromey.com>
8196
8197         * tui/tui-layout.c (init_and_make_win): Use new.
8198         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8199         destructor, initializers.
8200         (tui_alloc_generic_win_info): Don't declare.
8201         * tui/tui-data.c (_locator): Add argument to constructor.
8202         (source_win, disasm_win): New globals.
8203         (exec_info): Remove.
8204         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8205         Update.
8206         (tui_alloc_generic_win_info): Remove.
8207         (init_content_element): Use new.
8208         (tui_win_info::tui_win_info): Update.
8209         (free_content_elements) <case DATA_WIN>: Use delete.
8210
8211 2019-06-25  Tom Tromey  <tom@tromey.com>
8212
8213         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8214         * tui/tui-windata.c (tui_first_data_item_displayed)
8215         (tui_delete_data_content_windows): Update.
8216         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8217         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8218         (tui_display_registers_from, tui_check_register_values): Update.
8219         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8220         pointer.
8221         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8222         window.
8223         (tui_free_data_content): Update.
8224         (free_content_elements) <case DATA_WIN>: Free the window.
8225
8226 2019-06-25  Tom Tromey  <tom@tromey.com>
8227
8228         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8229         Update.
8230         * tui/tui-layout.c (make_command_window)
8231         (show_source_disasm_command, show_data, init_and_make_win)
8232         (show_source_or_disasm_and_command): Update.
8233         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8234         method.
8235         <can_highight, is_highlighted>: Now bool.
8236         (tui_set_win_highlight): Don't declare.
8237         * tui/tui-data.c (tui_set_win_highlight): Remove.
8238
8239 2019-06-25  Tom Tromey  <tom@tromey.com>
8240
8241         * tui/tui-wingeneral.c (make_visible): Remove check of window
8242         type.
8243
8244 2019-06-25  Tom Tromey  <tom@tromey.com>
8245
8246         * tui/tui-win.c (tui_win_info::max_height)
8247         (tui_cmd_window::max_height): New methods.
8248         (new_height_ok): Call max_height.
8249         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8250         <max_height>: New method.
8251
8252 2019-06-25  Tom Tromey  <tom@tromey.com>
8253
8254         * tui/tui-win.c (tui_source_window_base::set_new_height)
8255         (tui_data_window::set_new_height): New methods.
8256         (make_invisible_and_set_new_height): Call set_new_height method.
8257         * tui/tui-data.h (struct tui_win_info)
8258         (struct tui_source_window_base, struct tui_data_window)
8259         <set_new_height>: New method.
8260
8261 2019-06-25  Tom Tromey  <tom@tromey.com>
8262
8263         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8264         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8265         tui_refresh_data_win.
8266         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8267         method.
8268         (tui_refresh_all_win): Call the refresh_all method.
8269         (tui_set_focus): Likewise.
8270         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8271         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8272         Likewise.
8273
8274 2019-06-25  Tom Tromey  <tom@tromey.com>
8275
8276         * tui/tui-winsource.h (tui_refill_source_window)
8277         (tui_set_is_exec_point_at): Don't declare.
8278         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8279         (tui_source_window_base::refill): Rename from
8280         tui_refill_source_window.
8281         (tui_source_window_base::do_scroll_horizontal): Update.
8282         (tui_source_window_base::set_is_exec_point_at): Rename from
8283         tui_set_is_exec_point_at.
8284         (tui_update_all_breakpoint_info): Update.
8285         * tui/tui-stack.c (tui_show_frame_info): Update.
8286         * tui/tui-layout.c (show_data): Add cast.
8287         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8288         * tui/tui-data.h (struct tui_source_window_base) <refill,
8289         set_is_exec_point_at>: New methods.
8290         (tui_source_windows, tui_add_to_source_windows): Update types.
8291         (tui_add_to_source_windows): Remove redundant declaration.
8292         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8293         (tui_source_windows): Change return type.
8294         (tui_clear_source_windows_detail): Update.
8295         (tui_add_to_source_windows): Change type of parameter.
8296         (tui_free_all_source_wins_content): Update.
8297
8298 2019-06-25  Tom Tromey  <tom@tromey.com>
8299
8300         * tui/tui-wingeneral.c (tui_win_info::refresh)
8301         (tui_source_window_base::refresh): New methods.
8302         (tui_refresh_all): Call the refresh method.
8303         * tui/tui-data.h (struct tui_win_info)
8304         (struct tui_source_window_base) <refresh>: New method.
8305
8306 2019-06-25  Tom Tromey  <tom@tromey.com>
8307
8308         * tui/tui.h (tui_is_window_visible): Return bool.
8309         * tui/tui.c (tui_is_window_visible): Return bool.
8310         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8311         (tui_make_visible, tui_make_invisible)
8312         (tui_win_info::make_visible)
8313         (tui_source_window_base::make_visible, make_all_visible)
8314         (tui_make_all_visible, tui_make_all_invisible): Update.
8315         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8316         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8317         bool.
8318         (struct tui_win_info, struct tui_source_window_base)
8319         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8320         * tui/tui-data.c (tui_init_generic_part): Update.
8321
8322 2019-06-25  Tom Tromey  <tom@tromey.com>
8323
8324         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8325         (tui_source_window_base::make_visible): New methods.
8326         (make_all_visible): Make method call.
8327         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8328         (struct tui_source_window_base, struct tui_cmd_window): Override
8329         make_visible.
8330         (tui_win_is_source_type): Don't declare.
8331         * tui/tui-data.c (tui_win_is_source_type): Remove.
8332
8333 2019-06-25  Tom Tromey  <tom@tromey.com>
8334
8335         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8336         NULL check.
8337
8338 2019-06-25  Tom Tromey  <tom@tromey.com>
8339
8340         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8341         Inline constructor.  Add initializers for members.
8342         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8343         constructors; now inline in class.
8344
8345 2019-06-25  Tom Tromey  <tom@tromey.com>
8346
8347         * tui/tui-regs.c (tui_show_registers): Update.
8348         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8349         bool.
8350         * tui/tui-data.c (tui_data_window::clear_detail)
8351         (tui_data_window): Update.
8352
8353 2019-06-25  Tom Tromey  <tom@tromey.com>
8354
8355         * tui/tui-windata.c (tui_display_all_data)
8356         (tui_display_data_from_line, tui_display_data_from)
8357         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8358         Update.
8359         * tui/tui-regs.c (tui_last_regs_line_no)
8360         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8361         (tui_show_registers, tui_show_register_group)
8362         (tui_display_registers_from, tui_display_reg_element_at_line)
8363         (tui_display_registers_from_line, tui_check_register_values)
8364         (tui_reg_next, tui_reg_prev): Update.
8365         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8366         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8367         tui_data_window.
8368         (struct tui_win_info) <detail>: Remove.  Add new fields from
8369         tui_data_info.
8370         (TUI_DATA_WIN): Add cast.
8371         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8372         (~tui_data_window): Simplify.
8373
8374 2019-06-25  Tom Tromey  <tom@tromey.com>
8375
8376         * tui/tui-layout.c (show_source_disasm_command)
8377         (show_source_or_disasm_and_command): Update.
8378         * tui/tui-io.c (update_cmdwin_start_line)
8379         (tui_redisplay_readline): Update.
8380         * tui/tui-data.h (struct tui_command_info): Remove.
8381         (struct tui_win_info) <detail>: Remove command_info member.
8382         (struct tui_data_window) <start_line>: New member, from
8383         tui_command_info.
8384         (TUI_CMD_WIN): Add casts.
8385
8386 2019-06-25  Tom Tromey  <tom@tromey.com>
8387
8388         * tui/tui-winsource.c (tui_update_source_window)
8389         (tui_refill_source_window)
8390         (tui_source_window_base::do_scroll_horizontal)
8391         (tui_update_breakpoint_info, tui_set_exec_info_content)
8392         (tui_show_exec_info_content, tui_erase_exec_info_content)
8393         (tui_clear_exec_info_content): Update.
8394         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8395         Update.
8396         * tui/tui-win.c (make_invisible_and_set_new_height)
8397         (make_visible_with_new_height): Update.
8398         * tui/tui-source.c (tui_set_source_content)
8399         (tui_show_symtab_source): Update.
8400         * tui/tui-layout.c (extract_display_start_addr)
8401         (show_source_disasm_command, show_data)
8402         (make_source_or_disasm_window)
8403         (show_source_or_disasm_and_command): Update.
8404         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8405         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8406         "gdbarch".
8407         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8408         to tui_source_window_base.
8409         (struct tui_win_info) <detail>: Remove source_info member.
8410         (struct tui_source_window_base) <has_locator>: Inline.
8411         Move contents from tui_source_info; rename has_locator member to
8412         m_has_locator.
8413         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8414         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8415         header file.
8416         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8417         Simplify.
8418         (tui_free_all_source_wins_content): Cast to
8419         tui_source_window_base.
8420
8421 2019-06-25  Tom Tromey  <tom@tromey.com>
8422
8423         * tui/tui-win.c (make_invisible_and_set_new_height)
8424         (make_visible_with_new_height): Call has_locator method.
8425         * tui/tui-layout.c (show_source_disasm_command, show_data)
8426         (show_source_or_disasm_and_command): Update for bool change.
8427         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8428         (tui_win_info) <has_locator>: New method.
8429         (struct tui_source_window_base) <has_locator>: New method.
8430         (tui_win_has_locator): Don't declare.
8431         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8432         from tui_win_has_locator.
8433         (tui_source_window_base): Use false, not FALSE.
8434
8435 2019-06-25  Tom Tromey  <tom@tromey.com>
8436
8437         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8438         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8439         clear_detail method directly.
8440         (tui_clear_win_detail): Remove.
8441
8442 2019-06-25  Tom Tromey  <tom@tromey.com>
8443
8444         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8445         "this", not TUI_DISASM_WIN.
8446
8447 2019-06-25  Tom Tromey  <tom@tromey.com>
8448
8449         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8450         declare.
8451         * tui/tui-winsource.c
8452         (tui_source_window_base::do_scroll_horizontal): Rename from
8453         tui_horizontal_source_scroll.
8454         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8455         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8456         from tui_vertical_data_scroll.
8457         * tui/tui-win.h (tui_scroll): Don't declare.
8458         * tui/tui-win.c (tui_win_info::forward_scroll)
8459         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8460         (tui_win_info::right_scroll): Rename and update.
8461         (tui_scroll_forward_command, tui_scroll_backward_command)
8462         (tui_scroll_left_command, tui_scroll_right_command): Update.
8463         (tui_scroll): Remove.
8464         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8465         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8466         from tui_vertical_source_scroll.
8467         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8468         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8469         from tui_vertical_disassem_scroll.
8470         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8471         do_scroll_horizontal>: New methods.
8472         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8473         Likewise.
8474         (struct tui_source_window_base): Add do_scroll_horizontal.
8475         (struct tui_source_window, struct tui_disasm_window): Add
8476         do_scroll_vertical.
8477         (struct tui_data_window, struct tui_cmd_window): Add
8478         do_scroll_horizontal and do_scroll_vertical.
8479         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8480
8481 2019-06-25  Tom Tromey  <tom@tromey.com>
8482
8483         * tui/tui-data.h (struct tui_source_window_base): New struct.
8484         (struct tui_source_window): Derive from tui_source_window_base.
8485         (struct tui_disasm_window): New struct.
8486         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8487         from tui_source_window::clear_detail.
8488         (tui_source_window_base): Rename from tui_source_window.
8489         (~tui_source_window_base): Rename from ~tui_source_window.
8490         (tui_alloc_win_info): Create a tui_disasm_window.
8491
8492 2019-06-25  Tom Tromey  <tom@tromey.com>
8493
8494         * tui/tui-data.h (struct tui_source_window)
8495         (struct tui_data_window): Declare destructors.
8496         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8497         destructors.
8498         (tui_win_info): Simplify.
8499
8500 2019-06-25  Tom Tromey  <tom@tromey.com>
8501
8502         * tui/tui-winsource.c (tui_display_main)
8503         (tui_update_source_windows_with_addr)
8504         (tui_update_all_breakpoint_info): Update.
8505         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8506         (new_height_ok, parse_scrolling_args): Update.
8507         * tui/tui-stack.c (tui_show_frame_info): Update.
8508         * tui/tui-data.h (struct tui_list): Remove.
8509         (tui_source_windows): Return a reference to a std::vector.
8510         * tui/tui-data.c (source_windows): Now a std::vector.
8511         (tui_source_windows): Change return type.
8512         (tui_clear_source_windows): Rewrite.
8513         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8514         (tui_free_all_source_wins_content): Rewrite.
8515
8516 2019-06-25  Tom Tromey  <tom@tromey.com>
8517
8518         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8519         (struct tui_data_window, struct tui_cmd_window): Declare
8520         clear_detail method.
8521         * tui/tui-data.c (tui_source_window::clear_detail)
8522         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8523         methods.
8524         (tui_clear_win_detail): Simplify.
8525
8526 2019-06-25  Tom Tromey  <tom@tromey.com>
8527
8528         * tui/tui-layout.c (make_source_window, make_disasm_window)
8529         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8530         Return the new window.
8531         (show_source_disasm_command, show_data)
8532         (show_source_or_disasm_and_command): Update.
8533
8534 2019-06-25  Tom Tromey  <tom@tromey.com>
8535
8536         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8537         parameter.  Return the new window.
8538         (show_source_disasm_command): Update and remove NULL check.
8539         (show_source_or_disasm_and_command): Update.
8540
8541 2019-06-25  Tom Tromey  <tom@tromey.com>
8542
8543         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8544
8545 2019-06-25  Tom Tromey  <tom@tromey.com>
8546
8547         * tui/tui-data.h (struct tui_win_info): Make constructor
8548         protected.  Make destructor virtual.  Add initializers.
8549         (tui_source_window, tui_data_window, tui_cmd_window): New
8550         classes.
8551         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8552         constructor.  Add "type" parameter.
8553         (tui_source_window, tui_data_window, tui_cmd_window): New
8554         constructors.
8555         (tui_alloc_win_info): Instantiate the appropriate subclass.
8556
8557 2019-06-25  Tom Tromey  <tom@tromey.com>
8558
8559         * tui/tui-win.c (tui_resize_all): Use delete.
8560         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8561         destructor.
8562         (tui_free_window): Don't declare.
8563         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8564         Update.
8565
8566 2019-06-25  Tom Tromey  <tom@tromey.com>
8567
8568         * tui/tui-data.h (struct tui_win_info): Add constructor.
8569         * tui/tui-data.c (tui_alloc_win_info): Use new.
8570         (tui_free_window): Use delete.
8571
8572 2019-06-22  Tom Tromey  <tom@tromey.com>
8573
8574         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8575         declare.
8576         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8577
8578 2019-06-22  Tom Tromey  <tom@tromey.com>
8579
8580         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8581         declare.
8582         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8583
8584 2019-06-22  Tom de Vries  <tdevries@suse.de>
8585
8586         * dwarf2read.c (create_addrmap_from_aranges)
8587         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8588         instead of '%zu'.
8589
8590 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8591
8592         * dwarf2read.h (dwarf2_section_info_def): Remove.
8593         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8594         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8595         std::vector<dwarf2_section_info>.
8596         (struct dwo_file) <~dwo_file>: Remove.
8597         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8598         types field.
8599         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8600         (dwarf2_read_debug_names): Likewise.
8601         (create_debug_types_hash_table): Change parameter type to
8602         array_view, adjust code accordingly.
8603         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8604         (partial_die_info::fixup): Likewise.
8605         (determine_prefix): Likewise.
8606         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8607
8608 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8609
8610         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8611         gdb_bfd_ref_ptr.
8612         <~dwo_file>: Remove call to gdb_bfd_unref.
8613         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8614         gdb_bfd_ref_ptr::get.
8615
8616 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8617
8618         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8619         type to htab_up.
8620         * dwarf2read.c (struct dwo_file): Initialize fields.
8621         <~dwo_file>: New.
8622         (free_dwo_file): Remove, move content to ~dwo_file.
8623         (struct dwo_file_deleter): Remove.
8624         (dwo_file_up>: Remove custom deleter.
8625         (free_dwo_files): Remove.
8626         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8627         dwo_files.
8628         (process_skeletonless_type_units): Call unique_ptr::get.
8629         (allocate_dwo_file_hash_table): Add deleter to created hash
8630         table.  Change return type to htab_up.
8631         (lookup_dwo_file_slot): Don't memset dwo_file, call
8632         unique_ptr::get.
8633         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8634         (create_dwo_unit_in_dwp_v2): Likewise.
8635         (open_and_init_dwo_file): Likewise.
8636         (free_dwo_file_from_slot): Remove.
8637
8638 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8639
8640         * dwarf2read.h (struct dwarf2_section_info) <readin,
8641         is_virtual>: Change type to bool.
8642         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8643         true instead of 1.
8644
8645 2019-06-19  Tom Tromey  <tom@tromey.com>
8646
8647         * tui/tui-data.h (tui_init_content_element): Don't declare.
8648
8649 2019-06-19  Tom Tromey  <tom@tromey.com>
8650
8651         * tui/tui-data.h (tui_init_win_info): Don't declare.
8652
8653 2019-06-19  Tom de Vries  <tdevries@suse.de>
8654
8655         * dwarf2read.h (abstract_to_concrete): Change type to
8656         std::unordered_map<sect_offset, std::vector<sect_offset>,
8657         gdb::hash_enum<sect_offset>>.
8658
8659 2019-06-19  Tom Tromey  <tromey@adacore.com>
8660
8661         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8662         EVAL_AVOID_SIDE_EFFECTS specially.
8663
8664 2019-06-19  Tom Tromey  <tromey@adacore.com>
8665
8666         * source-cache.c (highlighter): New global.
8667         (source_cache::get_source_lines): Create a highlighter on demand.
8668
8669 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8670
8671         * defs.h (deprecated_interactive_hook): Delete declaration.
8672         * interps.c (clear_interpreter_hooks): Remove use of
8673         deprecated_interactive_hook.
8674         * top.c (deprecated_interactive_hook): Delete definition.
8675         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8676
8677 2019-06-18  Tom de Vries  <tdevries@suse.de>
8678
8679         PR gdb/24515
8680         * dwarf2read.h (abstract_to_concrete): Change type from
8681         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8682         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8683         * dwarf2read.c (read_variable): Update.
8684         (dwarf2_fetch_die_loc_sect_off): Update.
8685
8686 2019-06-17  Tom de Vries  <tdevries@suse.de>
8687
8688         PR gdb/24617
8689         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8690         accessing parent[parent_len - 1].
8691
8692 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8693
8694         PR gdb/24364
8695         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8696         call dtrace_process_dof with NULL dof.
8697
8698 2019-06-16  Tom de Vries  <tdevries@suse.de>
8699
8700         PR gdb/24445
8701         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8702
8703 2019-06-16  Tom Tromey  <tom@tromey.com>
8704
8705         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8706         (make_all_visible): Use address of member.
8707
8708 2019-06-16  Tom Tromey  <tom@tromey.com>
8709
8710         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8711         (tui_free_window, free_content, free_content_elements): Remove
8712         unnecessary cast.
8713         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8714         cast.
8715         * tui/tui-regs.c (tui_show_register_group)
8716         (tui_display_registers_from, tui_display_reg_element_at_line):
8717         Remove unnecessary cast.
8718
8719 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8720
8721         * linux-nat.c (normal_mask): Delete.
8722         (_initialize_linux_nat): Don't initialise normal_mask.
8723
8724 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8725
8726         PR gdb/24445
8727         * dwarf-index-write.h (write_psymtabs_to_index): Add
8728         dwz_basename parameter.
8729         * dwarf-index-write.c (write_gdbindex): Move file writing to
8730         write_gdbindex_1.  Change return type void.
8731         (assert_file_size): Move up, remove filename parameter.
8732         (write_gdbindex_1): New function.
8733         (write_debug_names): Change return type to void, call
8734         assert_file_size.
8735         (struct index_wip_file): New struct.
8736         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8737         file logic to index_wip_file.  Write index for dwz file if
8738         needed.
8739         (save_gdb_index_command): Pass basename of dwz file, if present.
8740         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8741         build-id of dwz file, if present.
8742         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8743         (dwarf2_get_dwz_file): Likewise.
8744         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8745         (dwarf2_get_dwz_file): Likewise.
8746
8747 2019-06-16  Tom Tromey  <tom@tromey.com>
8748
8749         * coffread.c (process_coff_symbol): Use xstrdup.
8750         * value.c (create_internalvar): Use xstrdup.
8751
8752 2019-06-16  Tom Tromey  <tom@tromey.com>
8753
8754         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8755         * breakpoint.c (stopin_command, stopat_command)
8756         (until_break_command, decode_location_default): Remove unnecessary
8757         cast.
8758         * utils.c (subset_compare): Remove unnecessary cast.
8759         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8760         cast.
8761         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8762         cast.
8763         * infcmd.c (path_command): Remove unnecessary cast.
8764         * coffread.c (decode_type): Remove unnecessary cast.
8765         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8766         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8767         * tui/tui-stack.c (tui_show_locator_content)
8768         (tui_show_frame_info): Remove unnecessary cast.
8769         * tui/tui-win.c (tui_scroll_forward_command)
8770         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8771         (parse_scrolling_args): Remove unnecessary cast.
8772         * tui/tui-data.c (init_win_info, tui_del_window)
8773         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8774         (free_content_elements): Remove unnecessary cast.
8775         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8776         unnecessary cast.
8777         * tui/tui-source.c (tui_set_source_content)
8778         (tui_vertical_source_scroll): Remove unnecessary cast.
8779         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8780         cast.
8781         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8782         * tui/tui-regs.c (tui_display_registers_from)
8783         (tui_display_register): Remove unnecessary cast.
8784         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8785         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8786         (make_visible): Remove unnecessary cast.
8787         * tui/tui-winsource.c (tui_erase_source_content)
8788         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8789         unnecessary cast.
8790         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8791         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8792         * stabsread.c (read_type, read_array_type, read_range_type):
8793         Remove unnecessary cast.
8794         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8795         (parse_symbol, parse_type, upgrade_type, parse_external)
8796         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8797         unnecessary cast.
8798         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8799
8800 2019-06-16  Tom Tromey  <tom@tromey.com>
8801
8802         * tui/tui-data.c (tui_alloc_generic_win_info)
8803         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8804         checks.
8805
8806 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8807             Andrew Burgess  <andrew.burgess@embecosm.com>
8808
8809         * f-typeprint.c (f_print_type): Don't return early for not
8810         associated or not allocated types.
8811         (f_type_print_varspec_suffix): Add print_rank parameter and print
8812         ranks of array types in case they dangling.
8813         (f_type_print_base): Add print_rank parameter.
8814
8815 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8816
8817         * NEWS: Mention new MI commands.
8818         * break-catch-throw.c (enum exception_event_kind): Move to
8819         breakpoint.h.
8820         (print_mention_exception_catchpoint): Output text as a single
8821         message.
8822         (catch_exception_command_1): Rename to...
8823         (catch_exception_event): ...this, make non-static, update header
8824         command, and change some parameter types.
8825         (catch_catch_command): Update for changes to
8826         catch_exception_command_1.
8827         (catch_throw_command): Likewise.
8828         (catch_rethrow_command): Likewise.
8829         * breakpoint.c (enum exception_event_kind): Delete.
8830         * breakpoint.h (enum exception_event_kind): Moved here from
8831         break-catch-throw.c.
8832         (catch_exception_event): Declare.
8833         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8834         (mi_cmd_catch_throw): New function.
8835         (mi_cmd_catch_rethrow): New function.
8836         (mi_cmd_catch_catch): New function.
8837         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8838         'catch-catch' entries.
8839         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8840         (mi_cmd_catch_rethrow): Declare.
8841         (mi_cmd_catch_catch): Declare.
8842
8843 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8844
8845         * annotate.c (annotate_source_line): Change return type to void,
8846         update implementation to match.
8847         * annotate.h (annotate_source_line): Change return type to void,
8848         update header comment.
8849         * stack.c (print_frame_info): Don't change what frame information
8850         is printed based on whether annotations are on or not.
8851
8852 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8853
8854         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8855         (annotate_source): Make static.
8856         (annotate_source_line): Moved from source.c and renamed from
8857         identify_source_line.  Update the return type.
8858         * annotate.h (annotate_source): Delete declaration.
8859         (annotate_source_line): Declaration moved from source.h, and
8860         renamed from identify_source_line.  Return type updated.
8861         * source.c (identify_source_line): Moved to annotate.c and renamed
8862         to annotate_source_line.
8863         (info_line_command): Remove check of annotation_level.
8864         * source.h (identify_source_line): Move declaration to annotate.h
8865         and rename to annotate_source_line.
8866         * stack.c: Add 'annotate.h' include.
8867         (print_frame_info): Remove check of annotation_level before
8868         calling annotate_source_line.
8869
8870 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8871
8872         * source-cache.c (source_cache::get_plain_source_lines): Use
8873         open_source_file_with_line_charpos instead of just
8874         open_source_file, remove call to find_source_lines.
8875         (source_cache::get_source_lines): Likewise.
8876         * source.c (find_source_lines): Make static.
8877         (get_filename_and_charpos): Renamed into...
8878         (open_source_file_with_line_charpos): ..this along with changes to
8879         return a scoped_fd, and some other minor clean ups.
8880         (identify_source_line): Use open_source_file_with_line_charpos.
8881         (search_command_helper): Use open_source_file_with_line_charpos
8882         instead of just open_source_file, remove call to
8883         find_source_lines.
8884         * source.h (open_source_file_with_line_charpos): Declare new
8885         function.
8886         (find_source_lines): Delete declaration.
8887
8888 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8889
8890         * source.c (get_filename_and_charpos): Remove fullname
8891         parameter.
8892         (identify_source_line): Update call to get_filename_and_charpos.
8893
8894 2019-06-14  Tom Tromey  <tromey@adacore.com>
8895
8896         PR gdb/24502:
8897         * ui-style.h (skip_ansi_escape): Update comment.
8898         * ui-file.h (class no_terminal_escape_file): New class.
8899         * ui-file.c (no_terminal_escape_file::write)
8900         (no_terminal_escape_file::puts): New methods.
8901         * cli/cli-logging.c (handle_redirections): Use
8902         no_terminal_escape_file.
8903
8904 2019-06-14  Tom Tromey  <tromey@adacore.com>
8905
8906         * NEWS: Move convenience variable news above Python news.
8907
8908 2019-06-14  Tom Tromey  <tom@tromey.com>
8909
8910         * gnulib: Move directory to top-level.
8911         * configure.ac: Don't configure gnulib.
8912         * configure: Rebuild.
8913         * common/common-defs.h: Use new path to gnulib.
8914         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8915         (GNULIB_H): Remove.
8916         (INCGNU): Look in new gnulib location.
8917         (HFILES_NO_SRCDIR): Remove gnulib files.
8918         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8919         (generated_files): Remove GNULIB_H.
8920         ($(LIBGNU), all-lib): Remove targets.
8921         (distclean): Don't mention GNULIB_BUILDDIR.
8922         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8923
8924 2019-06-14  Tom Tromey  <tromey@adacore.com>
8925
8926         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8927         Warn if symbol file does not provide any symbols.
8928
8929 2019-06-14  Tom Tromey  <tromey@adacore.com>
8930
8931         * source.c (find_and_open_source): Respect basenames_may_differ.
8932
8933 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8934
8935         * annotate.c (annotate_breakpoints_invalid): Make use of
8936         scoped_restore_terminal_state.
8937         (annotate_frames_invalid): Likewise.
8938
8939 2019-06-14  Tom Tromey  <tromey@adacore.com>
8940
8941         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8942         allow assignment to an internalvar.
8943
8944 2019-06-14  Tom Tromey  <tromey@adacore.com>
8945
8946         * ada-lex.l: Allow "_" in attribute names.
8947
8948 2019-06-14  Tom Tromey  <tromey@adacore.com>
8949
8950         PR gdb/24653:
8951         * regcache.c (registers_changed): Don't call alloca.
8952         * top.c (execute_command): Don't call alloca.
8953
8954 2019-06-13  Pedro Alves  <palves@redhat.com>
8955
8956         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8957         'expression'.  When parsing an expression, error out if there's
8958         junk after "unlimited".
8959         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8960         (do_set_command): Adjust calls to is_unlimited_literal.
8961
8962 2019-06-13  Pedro Alves  <palves@redhat.com>
8963
8964         * compile/compile.c (make_compile_options_def_group): Add braces
8965         around array_view initializer.
8966         * thread.c (make_thread_apply_all_options_def_group)
8967         (make_thread_apply_all_options_def_group): Likewise.
8968
8969 2019-06-13  Pedro Alves  <palves@redhat.com>
8970
8971         * NEWS (New commands): Mention "maint test-options
8972         require-delimiter", "maint test-options unknown-is-error", "maint
8973         test-options unknown-is-operand" and "maint show
8974         test-options-completion-result".
8975         (New command options, command completion): New section.
8976         (Completion improvements): New section.
8977         Mention that you can abbreviate "unlimited".
8978
8979 2019-06-13  Pedro Alves  <palves@redhat.com>
8980
8981         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8982         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8983         * unittests/cli-utils-selftests.c (test_parse_flags)
8984         (test_parse_flags_qcs): Delete.
8985         (test_cli_utils): Don't call deleted functions.
8986
8987 2019-06-13  Pedro Alves  <palves@redhat.com>
8988
8989         * thread.c: Include "cli/cli-option.h".
8990         (tp_array_compar_ascending): Global.
8991         (tp_array_compar): Delete function.
8992         (tp_array_compar_ascending, tp_array_compar_descending): New
8993         functions.
8994         (ascending_option_def, qcs_flag_option_def)
8995         (thr_qcs_flags_option_defs)
8996         (make_thread_apply_all_options_def_group)
8997         (make_thread_apply_options_def_group): New.
8998         (thread_apply_all_command): Use gdb::option::process_options.
8999         (thread_apply_command_completer)
9000         (thread_apply_all_command_completer): New.
9001         (thread_apply_command): Use gdb::option::process_options.
9002         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9003         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9004         to generate help text of "thread apply".  Adjust "taas"'s help.
9005         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9006         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9007
9008 2019-06-13  Pedro Alves  <palves@redhat.com>
9009
9010         * thread.c (thread_apply_command): Check for invalid TID with
9011         isdigit instead of !isalpha.
9012
9013 2019-06-13  Pedro Alves  <palves@redhat.com>
9014
9015         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9016         (validate_flags_qcs): New.
9017         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9018         (validate_flags_qcs): Declare.
9019         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9020         (make_frame_apply_options_def_group): New.
9021         (frame_apply_command_count): Process options with
9022         gdb::option::process_options.
9023         (frame_apply_completer): New.
9024         (frame_apply_level_completer, frame_apply_all_completer)
9025         (frame_apply_completer): New.
9026         (_initialize_stack): Update help of "frame apply", "frame apply
9027         level", "frame apply all" and "faas" to mention supported options
9028         and install command completers.
9029         * stack.h (frame_apply_all_completer): Declare.
9030         * thread.c: Include "stack.h".
9031         (tfaas_command): Add "--".
9032         (_initialize_thread): Update help "tfaas" to mention supported
9033         options and install command completer.
9034
9035 2019-06-13  Pedro Alves  <palves@redhat.com>
9036
9037         * completer.c (complete_nested_command_line): New.
9038         (gdb_completion_word_break_characters_throw): Add assertion.
9039         * completer.h (complete_nested_command_line): Declare.
9040
9041 2019-06-13  Pedro Alves  <palves@redhat.com>
9042
9043         * stack.c (parse_backtrace_qualifiers): New.
9044         (backtrace_command): Use it.
9045         (backtrace_command_completer): Complete on qualifiers.
9046
9047 2019-06-13  Pedro Alves  <palves@redhat.com>
9048
9049         * frame.c: Include "cli/cli-option.h.
9050         (user_set_backtrace_options): New.
9051         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9052         Delete.
9053         (get_prev_frame): Adjust.
9054         (boolean_option_def, uinteger_option_def)
9055         (set_backtrace_option_defs): New.
9056         (_initialize_frame): Adjust and use
9057         gdb::option::add_setshow_cmds_for_options to install "set
9058         backtrace past-main" and "set backtrace past-entry".
9059         * frame.h: Include "cli/cli-option.h".
9060         (struct frame_print_options): Forward declare.
9061         (print_frame_arguments_all, print_frame_arguments_scalars)
9062         (print_frame_arguments_none): Declare.
9063         (print_entry_values): Delete declaration.
9064         (struct frame_print_options, user_frame_print_options): New.
9065         (struct set_backtrace_options): New.
9066         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9067         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9068         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9069         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9070         (list_args_or_locals): Add frame_print_options parameter.
9071         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9072         * python/py-framefilter.c (enumerate_args): Pass down
9073         USER_FRAME_PRINT_OPTIONS.
9074         * stack.c: Include "cli/cli-option.h".
9075         (print_frame_arguments_all, print_frame_arguments_scalars)
9076         (print_frame_arguments_none): Declare.
9077         (print_raw_frame_arguments, print_entry_values): Delete.
9078         (user_frame_print_options): New.
9079         (boolean_option_def, enum_option_def, frame_print_option_defs):
9080         New.
9081         (struct backtrace_cmd_options): New.
9082         (bt_flag_option_def): New.
9083         (backtrace_command_option_defs): New.
9084         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9085         (print_frame_arg, read_frame_arg, print_frame_args)
9086         (print_frame_info, print_frame): Add frame_print_options parameter
9087         and use it.
9088         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9089         (backtrace_command_1): Add frame_print_options and
9090         backtrace_cmd_options parameters and use them.
9091         (make_backtrace_options_def_group): New.
9092         (backtrace_command): Process command options with
9093         gdb::option::process_options.
9094         (backtrace_command_completer): New.
9095         (_initialize_stack): Extend "backtrace"'s help to mention
9096         supported options.  Install completer for "backtrace".
9097         Install some settings commands with add_setshow_cmds_for_options.
9098
9099 2019-06-13  Pedro Alves  <palves@redhat.com>
9100
9101         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9102         and that "set/show print raw frame-arguments" are now deprecated.
9103
9104         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9105         command.
9106         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9107         * stack.c (_initialize_stack): Install "set/show print
9108         raw-frame-arguments", and deprecate "set/show print raw
9109         frame-arguments".
9110         * valprint.c (_initialize_valprint): Deprecate "set/show print
9111         raw".
9112
9113 2019-06-13  Pedro Alves  <palves@redhat.com>
9114
9115         * compile/compile.c (struct compile_options): New.
9116         (compile_flag_option_def, compile_command_option_defs)
9117         (make_compile_options_def_group): New.
9118         (compile_file_command): Handle options with
9119         gdb::option::process_options.
9120         (compile_file_command_completer): New function.
9121         (compile_code_command): Handle options with
9122         gdb::option::process_options.
9123         (compile_code_command_completer): New function.
9124         (_initialize_compiler): Install completers for "compile code" and
9125         "compile file".  Mention available options in "compile code" and
9126         "compile code"'s help.
9127         * completer.c (advance_to_completion_word): New, factored out from
9128         ...
9129         (advance_to_expression_complete_word_point): ... this.
9130         (advance_to_filename_complete_word_point): New.
9131         * completer.h (advance_to_filename_complete_word_point): New
9132         declaration.
9133
9134 2019-06-13  Pedro Alves  <palves@redhat.com>
9135
9136         * compile/compile.c: Include "cli/cli-option.h".
9137         (compile_print_value): Scope data pointer is now a
9138         value_print_options pointer; adjust.
9139         (compile_print_command): Process options.  Scope data pointer is
9140         now a value_print_options pointer; adjust.
9141         (_initialize_compile): Update "compile print"'s help to include
9142         supported options.  Install a completer for "compile print".
9143         * cp-valprint.c (show_vtblprint, show_objectprint)
9144         (show_static_field_print): Delete.
9145         (_initialize_cp_valprint): Don't install "set print
9146         static-members", "set print vtbl", "set print object" here.
9147         * printcmd.c: Include "cli/cli-option.h" and
9148         "common/gdb_optional.h".
9149         (print_command_parse_format): Rework to fill in a
9150         value_print_options instead of a format_data.
9151         (print_value): Change parameter type from format_data pointer to
9152         value_print_options reference.  Adjust.
9153         (print_command_1): Process options.  Adjust to pass down a
9154         value_print_options.
9155         (print_command_completer): New.
9156         (_initialize_printcmd): Install print_command_completer as
9157         handle_brkchars completer for the "print" command.  Update
9158         "print"'s help to include supported options.
9159         * valprint.c: Include "cli/cli-option.h".
9160         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9161         here from cp-valprint.c.
9162         (boolean_option_def, uinteger_option_def)
9163         (value_print_option_defs, make_value_print_options_def_group):
9164         New.  Use gdb::option::add_setshow_cmds_for_options to install
9165         "set print elements", "set print null-stop", "set print repeats",
9166         "set print pretty", "set print union", "set print array", "set
9167         print address", "set print symbol", "set print array-indexes".
9168         * valprint.h: Include <string> and "cli/cli-option.h".
9169         (make_value_print_options_def_group): Declare.
9170         (print_value): Change parameter type from format_data pointer to
9171         value_print_options reference.
9172         (print_command_completer): Declare.
9173
9174 2019-06-13  Pedro Alves  <palves@redhat.com>
9175
9176         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9177         (COMMON_SFILES): Add maint-test-settings.c.
9178         * cli/cli-decode.c (boolean_enums): New global, factored out from
9179         ...
9180         (add_setshow_boolean_cmd): ... here.
9181         * cli/cli-decode.h (boolean_enums): Declare.
9182         * cli/cli-option.c: New file.
9183         * cli/cli-option.h: New file.
9184         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9185         factored out from ...
9186         (parse_cli_boolean_value(const char *)): ... this.
9187         (is_unlimited_literal): Change parameter type to pointer to
9188         pointer.  Adjust and advance ARG pointer.
9189         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9190         (parse_cli_var_enum): New, factored out from ...
9191         (do_set_command): ... this.  Adjust.
9192         * cli/cli-setshow.h (parse_cli_boolean_value)
9193         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9194         (parse_cli_var_enum): Declare.
9195         * cli/cli-utils.c: Include "cli/cli-option.h".
9196         (get_ulongest): New.
9197         * cli/cli-utils.h (get_ulongest): Declare.
9198         (check_for_argument): New overloads.
9199         * maint-test-options.c: New file.
9200
9201 2019-06-13  Pedro Alves  <palves@redhat.com>
9202
9203         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9204         parse a range if "-" is at the end of the string.
9205
9206 2019-06-13  Pedro Alves  <palves@redhat.com>
9207
9208         * cli/cli-setshow.c (parse_auto_binary_operation)
9209         (parse_cli_boolean_value): Don't allow "o".
9210
9211 2019-06-13  Pedro Alves  <palves@redhat.com>
9212
9213         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9214         * NEWS: Mention maint test-settings KIND.
9215         * maint-test-settings.c: New file.
9216
9217 2019-06-13  Pedro Alves  <palves@redhat.com>
9218
9219         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9220         completer.
9221         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9222         "set" completers.
9223
9224 2019-06-13  Pedro Alves  <palves@redhat.com>
9225
9226         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9227         after item.
9228
9229 2019-06-13  Pedro Alves  <palves@redhat.com>
9230
9231         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9232
9233 2019-06-13  Pedro Alves <palves@redhat.com>
9234
9235         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9236         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9237         call.
9238         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9239         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9240         calls.
9241         (check_for_argument): Skip spaces after argument.
9242
9243 2019-06-13  Pedro Alves  <palves@redhat.com>
9244
9245         * thread.c (thread_apply_command): Adjust TID parsing.
9246         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9247         detected before end of string.
9248         (tid_is_in_list): Error out if LIST is invalid.
9249
9250 2019-06-13  Pedro Alves  <palves@redhat.com>
9251
9252         * completer.c (complete_line_internal_1): Rewind completion word
9253         point.
9254         (completion_tracker::advance_custom_word_point_by): Change
9255         parameter type to int.
9256         * completer.h (completion_tracker::advance_custom_word_point_by):
9257         Likewise.
9258
9259 2019-06-13  Pedro Alves  <palves@redhat.com>
9260
9261         * completer.c (advance_to_completion_word): Handle delimiters.
9262
9263 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9264
9265         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9266
9267 2019-06-11  Tom Tromey  <tom@tromey.com>
9268
9269         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9270         (xmalloc_failed): Move to alloc.c.
9271         * alloc.c: New file.
9272         * Makefile.in (COMMON_SFILES): Add alloc.c.
9273
9274 2019-06-11  Tom Tromey  <tom@tromey.com>
9275
9276         * nat/linux-waitpid.c: Don't include server.h.
9277         (linux_debug): Remove.
9278         (my_waitpid): Update.
9279
9280 2019-06-11  Tom Tromey  <tromey@adacore.com>
9281
9282         * infcall.c (_initialize_infcall): Remove trailing newline from
9283         help.
9284         * user-regs.c (_initialize_user_regs): Remove trailing newline
9285         from help.
9286         * typeprint.c (_initialize_typeprint): Remove trailing newline
9287         from help.
9288         * reverse.c (_initialize_reverse): Remove trailing newlines from
9289         help.
9290         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9291         from help.
9292         * language.c (add_set_language_command): Remove trailing newline
9293         from help.
9294         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9295         help.
9296         * disasm.c (_initialize_disasm): Remove trailing newline from
9297         help.
9298         * top.c (init_main): Remove trailing newline from help.
9299         * interps.c (_initialize_interpreter): Remove trailing newline
9300         from help.
9301         * btrace.c (_initialize_btrace): Remove trailing newlines from
9302         help.
9303         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9304         from help.
9305         * python/python.c (_initialize_python): Remove trailing newline
9306         from help.
9307         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9308         help.
9309         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9310         from help.  Reformat some text.
9311         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9312         from help.
9313         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9314         newline from help.
9315
9316 2019-06-11  Tom Tromey  <tromey@adacore.com>
9317
9318         * darwin-nat.c (darwin_decode_exception_message)
9319         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9320
9321 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9322
9323         * valops.c (value_slice): Check for not allocated or not
9324         associated values.
9325
9326 2019-06-10  Tom de Vries  <tdevries@suse.de>
9327
9328         PR gdb/24618
9329         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9330         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9331         invalid.
9332
9333 2019-06-10  Tom de Vries  <tdevries@suse.de>
9334
9335         PR gdb/24611
9336         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9337         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9338
9339 2019-06-10  Tom de Vries  <tdevries@suse.de>
9340
9341         PR symtab/24545
9342         * symtab.c (struct demangled_name_entry): Add language field.
9343         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9344         static minimal symbol".  Set and use language field.
9345
9346 2019-06-10  Tom Tromey  <tromey@adacore.com>
9347
9348         * ada-lang.c (_initialize_ada_language): Update help text.
9349
9350 2019-06-10  Tom Tromey  <tromey@adacore.com>
9351
9352         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9353         with a newline.
9354         * guile/guile.c (handle_boot_error): Don't end warning with a
9355         newline.
9356         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9357         warning with a newline.
9358         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9359         newline.
9360         (s12z_frame_cache): Likewise.
9361         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9362         a newline.
9363         * solib-svr4.c (disable_probes_interface): Don't end warning with
9364         a newline.
9365         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9366         newline.
9367         * python/python.c (do_finish_initialization): Don't end warning
9368         with a newline.
9369
9370 2019-06-10  Tom Tromey  <tom@tromey.com>
9371
9372         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9373         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9374         gdbpy_enter.
9375
9376 2019-06-10  Tom Tromey  <tromey@adacore.com>
9377
9378         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9379         data.
9380         (elf_new_init): Don't call stabsread_new_init.
9381         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9382         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9383         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9384
9385 2019-06-10  Tom de Vries  <tdevries@suse.de>
9386
9387         PR symtab/16264
9388         PR symtab/24517
9389         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9390
9391 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9392
9393         * source.c (find_and_open_source): Also rewrite relative file
9394         names.
9395
9396 2019-04-26  Amos Bird  <amosbird@gmail.com>
9397
9398         * annotate.c (annotate_thread_exited): Add "thread-exited"
9399         annotation.
9400
9401 2019-06-06  Tom Tromey  <tromey@adacore.com>
9402
9403         * maint.h (class scoped_command_stats): Use
9404         DISABLE_COPY_AND_ASSIGN.
9405         <print_time>: New method.
9406         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9407         print_time.
9408         (scoped_command_stats::print_time): New method.
9409
9410 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9411
9412         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9413         instructions of lengths 6 or 8 bytes.
9414
9415 2019-06-04  Pedro Alves  <palves@redhat.com>
9416
9417         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9418
9419         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9420         * breakpoint.c (condition_completer): Likewise.
9421         * cli/cli-dump.c (scan_expression): Likewise.
9422         * common/filestuff.c (mkdir_recursive): Likewise.
9423         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9424         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9425         (gdb_abspath): Likewise.
9426         * compile/compile-cplus-types.c
9427         (compile_cplus_instance::decl_name): Likewise.
9428         * completer.c (complete_explicit_location):
9429         (signal_completer, reg_or_group_completer_1): Likewise.
9430         * cp-support.c (cp_remove_params_if_any): Likewise.
9431         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9432         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9433         * infcmd.c (strip_bg_char): Likewise.
9434         * linespec.c (copy_token_string): Likewise.
9435         * mi/mi-main.c (output_cores): Likewise.
9436         * psymtab.c (psymtab_search_name):
9437         * symfile.c (test_set_ext_lang_command): Likewise.
9438         * target.c (target_fileio_read_stralloc): Likewise.
9439         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9440         * value.c (complete_internalvar): Likewise.
9441
9442 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9443
9444         Add objfile property to gdb.Type.
9445         * NEWS: Mention Python API addition.
9446         * python/py-type.c (typy_get_objfile): New method.
9447
9448 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9449
9450         * NEWS: Mention the new set|show style [title|highlight].
9451         Mention changes to "show style", "help" and "apropos".
9452
9453 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9454
9455         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9456         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9457         instead of print_help_for_command.
9458         (print_doc_of_command): New function.
9459         (help_list): Add 'apropos -v word' suggestion.
9460         (print_help_for_command): Style the command name using title style.
9461         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9462         (_initialize_cli_cmds): Describe -v in apropos_command help.
9463
9464 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9465
9466         * cli/cli-style.h (cli_style_option): Add name in constructor,
9467         add m_name class member, add constructor with intensity,
9468         add name class function.
9469         (cli_style_option::add_setshow_commands): Remove name argument.
9470         (highlight_style, title_style): New styles.
9471         * cli/cli-style.c (do_show): New function that shows a style
9472         characteristic styling the style name with itself.
9473         (set_style_name): New function.
9474         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9475         Update all callers according to the changes in cli/cli-style.h.
9476         * utils.h (fputs_highlighted): New function.
9477         * utils.c (fputs_highlighted): Likewise.
9478
9479 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9480
9481         * NEWS: Mention new pipe command and new convenience variables.
9482
9483 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9484
9485         * cli/cli-cmds.c (pipe_command): New function.
9486         (_initialize_cli_cmds): Call add_com for pipe_command.
9487         Define | as an alias for pipe.
9488         (exit_status_set_internal_vars): New function.
9489         (shell_escape): Call exit_status_set_internal_vars.
9490         cli/cli-decode.c (find_command_name_length): Recognize | as
9491         a single character command.
9492
9493 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9494
9495         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9496         top.c (execute_command_to_ui_file): New function, mostly a copy
9497         of execute_command_to_string.
9498         (execute_command_to_string): Implement by calling
9499         execute_command_to_ui_file.
9500
9501 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9502
9503         * top.h (saved_command_line): Remove declaration.
9504         * top.c (previous_saved_command_line, previous_repeat_arguments):
9505         New variables.
9506         (saved_command_line): Make static, define together with other
9507         'repeat variables'.
9508         (dont_repeat): Clear repeat_arguments.
9509         (repeat_previous, get_saved_command_line, save_command_line):
9510         New functions.
9511         (gdb_init): Initialize saved_command_line
9512         and previous_saved_command_line.
9513         * main.c (captured_main_1): Remove saved_command_line initialization.
9514         * event-top.c (handle_line_of_input): Update to use
9515         the new 'repeat' related functions instead of direct access to
9516         saved_command_line.
9517         * command.h (repeat_previous, get_saved_command_line,
9518         save_command_line): New declarations.
9519         (dont_repeat): Add comment.
9520
9521 2019-05-30  Tom Tromey  <tromey@adacore.com>
9522
9523         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9524         Fix comment.
9525         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9526
9527 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9528
9529         PR cli/24587
9530         * completer.c (complete): Initialize variable word.
9531
9532 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9533
9534         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9535         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9536         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9537         'body' is NULL to the outter 'if', protecting the '!is_define'
9538         situation as well.
9539
9540 2019-05-29  Tom Tromey  <tromey@adacore.com>
9541
9542         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9543         (dwarf_unknown): New function.
9544         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9545         (dwarf_type_encoding_name): Use dwarf_unknown.
9546
9547 2019-05-29  Tom Tromey  <tromey@adacore.com>
9548
9549         PR c++/20020:
9550         * cp-valprint.c (cp_print_value_fields): Call
9551         cp_print_static_field inside "try".
9552
9553 2019-05-29  Tom Tromey  <tromey@adacore.com>
9554
9555         * inflow.c (struct terminal_info): Add default operator=.
9556         * configure: Rebuild.
9557         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9558         -Wdeprecated-copy-dtor, -Wredundant-move.
9559
9560 2019-05-29  Tom Tromey  <tromey@adacore.com>
9561
9562         * NEWS: Add entry.
9563         * infcmd.c (print_return_value_1): Handle finish_print
9564         option.
9565         (show_print_finish): New function.
9566         (_initialize_infcmd): Add "set/show print finish" commands.
9567         * valprint.c (user_print_options): Initialize new member.
9568         * valprint.h (struct value_print_options) <finish_print>: New
9569         member.
9570
9571 2019-05-28  Tom Tromey  <tromey@adacore.com>
9572
9573         * ada-lang.c (ada_remove_Xbn_suffix)
9574         (find_old_style_renaming_symbol)
9575         (parse_old_style_renaming): Remove.
9576         (ada_find_renaming_symbol): Don't call
9577         find_old_style_renaming_symbol.
9578         (ada_is_renaming_symbol): Rename from
9579         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9580         bool.  Now static.
9581         (ada_read_var_value): Update and simplify.
9582         * ada-exp.y (write_var_or_type): Remove old code.
9583
9584 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9585
9586         PR gdb/25010
9587         * event-top.c: Remove include comment.
9588         * inflow.c (class scoped_ignore_sigttou): Move from here...
9589         * inflow.h (class scoped_ignore_sigttou): ...to here.
9590         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9591         * top.c:  Remove include comment.
9592
9593 2019-05-27  Tom Tromey  <tom@tromey.com>
9594
9595         * NEWS: Fix typo.
9596
9597 2019-05-22  Tom Tromey  <tromey@adacore.com>
9598
9599         * target.c (target_follow_exec): Constify parameter.
9600         * target-delegates.c: Rebuild.
9601         * remote.c (remote_target::follow_exec): Constify parameter.
9602         * infrun.c (follow_exec): Constify parameter.
9603         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9604         (target_follow_exec): Likewise.
9605
9606 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9607
9608         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9609         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9610
9611 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9612
9613         * NEWS: Add debugredirect and testsuite sections.
9614
9615 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9616
9617         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9618         target descriptions using exclusively floating point register name
9619         aliases.
9620
9621 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9622
9623         PR gdb/18644:
9624         * f-lang.c (build_fortran_types): Handle the case where
9625         gdbarch_floatformat_for_type returns a nullptr.
9626
9627 2019-05-21  Tom de Vries  <tdevries@suse.de>
9628
9629         PR cli/24587
9630         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9631
9632 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9633
9634         PR gdb/18644:
9635         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9636         16-byte floats.
9637         * i386-tdep.c (i386_floatformat_for_type): Use
9638         floatformats_ia64_quad for the 16-byte floating point component
9639         within a fortran 32-byte complex number.
9640
9641 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9642
9643         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9644         delete default constructor.
9645         (find_partial_die): Update to return const struct.
9646         (partial_die_parent_scope): Move variable declaration into scope
9647         of its use and change its type to auto.
9648         (guess_partial_die_structure_name): Likewise.
9649         (partial_die_info::fixup): Likewise.
9650
9651 2019-05-17  Tom Tromey  <tromey@adacore.com>
9652
9653         * source.c (find_and_open_source): Remove cast.
9654
9655 2019-05-17  Tom Tromey  <tromey@adacore.com>
9656
9657         * annotate.c (annotate_source): Make "filename" const.
9658         * annotate.h (annotate_source): Use const.
9659
9660 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9661
9662         * disasm.c (set_disassembler_options): Send errors to stderr.
9663
9664 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9665
9666         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9667         (cli_interp_base::set_logging): Check debug_redirect.
9668         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9669         * cli/cli-logging.c (debug_redirect): Add static variable.
9670         (pop_output_files): Add default param.
9671         (handle_redirections): Print debug setting.
9672         (show_logging_command): Likewise.
9673         (_initialize_cli_logging): Add debugredirect command.
9674         * interps.c (current_interp_set_logging): Add debug_redirect
9675         parameter.
9676         * interps.h (set_logging): Add debug_redirect parameter.
9677         (current_interp_set_logging): Likewise.
9678         * mi/mi-common.h: Likewise.
9679         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9680
9681 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9682             Tom Tromey  <tromey@adacore.com>
9683
9684         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9685         directly.
9686         * cli/cli-interp.h (make_logging_output): Remove declaration.
9687         * cli/cli-logging.c (make_logging_output): Remove function.
9688         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9689         directly.
9690         * ui-file.c (tee_file::tee_file): Remove bools.
9691         (tee_file::~tee_file): Remove deletes.
9692         * ui-file.h (tee_file): Remove bools.
9693
9694 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9695
9696         * mi/mi-cmds.h (mi_cmd_complete): New function.
9697         * mi/mi-main.c (mi_cmd_complete): Likewise.
9698         * mi/mi-cmds.c: Define new MI command -complete.
9699         * NEWS: Mention new -complete command.
9700
9701 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9702
9703         * completer.h (complete): New function.
9704         * completer.c (complete): Likewise.
9705         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9706         function defined in completer.h.
9707
9708 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9709
9710         * MAINTAINERS (Write After Approval): Add myself.
9711
9712 2019-05-17  Tom de Vries  <tdevries@suse.de>
9713
9714         PR gdb/24094
9715         * dwarf2read.c (struct cu_partial_die_info): New struct.
9716         (find_partial_die): Return cu_partial_die_info.
9717         (partial_die_parent_scope, guess_partial_die_structure_name)
9718         (partial_die_info::fixup): Handle new return type of find_partial_die.
9719
9720 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9721
9722         PR breakpoints/24541
9723         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9724         "std::string", simplifying the algorithm.
9725
9726 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9727
9728         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9729         (stap_static_probe_ops::get_probes): Likewise.
9730
9731 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9732
9733         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9734         '-')" and "else if".
9735         (stap_parse_single_operand): Join checks for
9736         "gdbarch_stap_parse_special_token_p" and
9737         "gdbarch_stap_parse_special_token" in the same "if" statement.
9738         Invert check when verifying for operation on register
9739         displacement.
9740
9741 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9742
9743         * stap-probe.c (stap_get_opcode): Update comment.
9744         (stap_get_expected_argument_type): Likewise.
9745         (handle_stap_probe): Likewise.
9746
9747 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9748
9749         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9750         return type to 'bool'.  Adjust comment.  Use 'bool' when
9751         appropriate.
9752         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9753         * stap-probe.c (stap_parse_argument_1): Likewise.
9754         (stap_is_operator): Likewise.
9755         (stap_is_generic_prefix): Likewise.
9756         (stap_is_register_prefix): Likewise.
9757         (stap_is_register_indirection_prefix): Likewise.
9758         (stap_is_integer_prefix): Likewise.
9759         (stap_generic_check_suffix): Likewise.
9760         (stap_check_integer_suffix): Likewise.
9761         (stap_check_register_suffix): Likewise.
9762         (stap_check_register_indirection_suffix): Likewise.
9763         (stap_parse_register_operand): Likewise.
9764         (stap_parse_single_operand): Likewise.
9765         (stap_parse_argument_1): Likewise.
9766         (stap_probe::get_argument_count): Likewise.
9767         (stap_is_operator): Likewise.
9768
9769 2019-05-16  Tom Tromey  <tromey@adacore.com>
9770
9771         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9772         keyword to foreach.
9773
9774 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9775
9776         * linux-thread-db.c (try_thread_db_load_1): Change return type
9777         to bool.
9778         (try_thread_db_load): Likewise.
9779         (try_thread_db_load_from_pdir_1): Likewise.
9780         (try_thread_db_load_from_pdir): Likewise.
9781         (try_thread_db_load_from_sdir): Likewise.
9782         (try_thread_db_load_from_dir): Likewise.
9783         (thread_db_load_search): Likewise.
9784         (has_libpthread): Likewise.
9785         (thread_db_load): Likewise.
9786
9787 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9788
9789         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9790         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9791         NULL, and complain/return if that's the case.
9792
9793 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9794
9795         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9796         (advance, posn, abstract_read_memory): New functions.
9797         [struct mem_read_abstraction]: New struct.
9798         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9799
9800 2019-05-14  Tom Tromey  <tromey@adacore.com>
9801
9802         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9803         value is not lval_memory.
9804
9805 2019-05-14  Tom Tromey  <tromey@adacore.com>
9806
9807         * solib.c (info_sharedlibrary_command): Style the file name.
9808
9809 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9810
9811         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9812         (aarch64_vnv_type): Likewise.
9813         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9814         * common/tdesc.c: Likewise.
9815         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9816         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9817         * features/aarch64-fpu.xml: Add ieee half view.
9818         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9819         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9820         * gdbtypes.h (struct builtin_type): Likewise.
9821         (struct objfile_type): Likewise.
9822
9823 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9824
9825         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9826         typo.
9827         * location.h (string_to_event_location): Likewise.
9828
9829 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9830
9831         GDB 8.3 released.
9832
9833 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9834
9835         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9836         New variable declaration.
9837         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9838         New variable.
9839         (print_one_breakpoint): Use ui_out::test_flags and new global
9840         variable to compute use_fixed_output.
9841         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9842         Remove.
9843         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9844         (mi_multi_location_breakpoint_output_fixed): Remove.
9845         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9846         new variable.
9847         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9848         fix_multi_location_breakpoint_output flag if version >= 3.
9849         * ui-out.h (enum ui_out_flag)
9850         <fix_multi_location_breakpoint_output>: New enumerator.
9851
9852 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9853
9854         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9855
9856 2019-05-10  Tom Tromey  <tromey@adacore.com>
9857
9858         * ada-lang.c (catch_ada_completer): New function.
9859         (_initialize_ada_language): Use it.
9860
9861 2019-05-10  Tom Tromey  <tromey@adacore.com>
9862
9863         * thread.c (print_thread_info): Make "requested_threads" const.
9864         * gdbthread.h (print_thread_info): Make "requested_threads"
9865         const.
9866         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9867         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9868
9869 2019-05-08  Tom Tromey  <tom@tromey.com>
9870
9871         * gdbtypes.c (objfile_type_data): Change type.
9872         (objfile_type, _initialize_gdbtypes): Update.
9873
9874 2019-05-08  Tom Tromey  <tom@tromey.com>
9875
9876         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9877         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9878         (_initialize_dwarf2_frame): Update.
9879
9880 2019-05-08  Tom Tromey  <tom@tromey.com>
9881
9882         * objc-lang.c (objc_objfile_data): Change type.
9883         (find_methods): Update.
9884         (_initialize_objc_lang): Remove.
9885
9886 2019-05-08  Tom Tromey  <tom@tromey.com>
9887
9888         * stabsread.c (rs6000_builtin_type_data): Change type.
9889         (rs6000_builtin_type, _initialize_stabsread): Update.
9890
9891 2019-05-08  Tom Tromey  <tom@tromey.com>
9892
9893         * mips-tdep.c (mips_pdr_data): Remove.
9894         (_initialize_mips_tdep): Update.
9895
9896 2019-05-08  Tom Tromey  <tom@tromey.com>
9897
9898         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9899         (hppa_init_objfile_priv_data, read_unwind_info)
9900         (find_unwind_entry, _initialize_hppa_tdep): Update.
9901
9902 2019-05-08  Tom Tromey  <tom@tromey.com>
9903
9904         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9905         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9906         on obstack.
9907         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9908
9909 2019-05-08  Tom Tromey  <tom@tromey.com>
9910
9911         * mdebugread.c (basic_type_data): Change type.
9912         (basic_type, _initialize_mdebugread): Update.
9913
9914 2019-05-08  Tom Tromey  <tom@tromey.com>
9915
9916         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9917
9918 2019-05-08  Tom Tromey  <tom@tromey.com>
9919
9920         * nto-tdep.c (nto_inferior_data_reg): Change type.
9921         (nto_inferior_data): Update.
9922         (nto_inferior_data_cleanup, nto_new_inferior_data)
9923         (_initialize_nto_tdep): Remove.
9924         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9925
9926 2019-05-08  Tom Tromey  <tom@tromey.com>
9927
9928         * ada-lang.c (struct ada_inferior_data): Add initializers.
9929         (ada_inferior_data): Change type.
9930         (ada_inferior_data_cleanup): Remove.
9931         (get_ada_inferior_data, ada_inferior_exit)
9932         (struct ada_pspace_data): Add initializers, destructor.
9933         (ada_pspace_data_handle): Change type.
9934         (get_ada_pspace_data): Update.
9935         (ada_pspace_data_cleanup): Remove.
9936
9937 2019-05-08  Tom Tromey  <tom@tromey.com>
9938
9939         * coffread.c (struct coff_symfile_info): Add initializers.
9940         (coff_objfile_data_key): Move lower.  Change type.
9941         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9942         Update.
9943         (coff_free_info): Remove.
9944
9945 2019-05-08  Tom Tromey  <tom@tromey.com>
9946
9947         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9948         (fbsd_pspace_data_handle): Move lower.  Change type.
9949         (get_fbsd_pspace_data): Update.
9950         (fbsd_pspace_data_cleanup): Remove.
9951         (_initialize_fbsd_tdep): Update.
9952
9953 2019-05-08  Tom Tromey  <tom@tromey.com>
9954
9955         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9956         (get_ada_tasks_pspace_data): Update.
9957         (ada_tasks_pspace_data_cleanup): Remove.
9958         (_initialize_tasks): Update.
9959         (ada_tasks_inferior_data_handle): Change type.
9960         (get_ada_tasks_inferior_data): Update.
9961         (ada_tasks_inferior_data_cleanup): Remove.
9962         (struct ada_tasks_pspace_data): Add initializers.
9963
9964 2019-05-08  Tom Tromey  <tom@tromey.com>
9965
9966         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9967         * symfile-debug.c (debug_sym_get_probes): Change type.
9968         * stap-probe.c (handle_stap_probe):
9969         (stap_static_probe_ops::get_probes): Change type.
9970         * probe.h (class static_probe_ops) <get_probes>: Change type.
9971         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9972         (parse_probes_in_pspace): Update.
9973         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9974         Update.
9975         (any_static_probe_ops::get_probes): Change type.
9976         * elfread.c (elfread_data): New typedef.
9977         (probe_key): Change type.
9978         (elf_get_probes): Likewise.  Update.
9979         (probe_key_free): Remove.
9980         (_initialize_elfread): Update.
9981         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9982         Change type.
9983         (dtrace_process_dof_probe, dtrace_process_dof)
9984         (dtrace_static_probe_ops::get_probe): Change type.
9985
9986 2019-05-08  Tom Tromey  <tom@tromey.com>
9987
9988         * xcoffread.c (struct xcoff_symfile_info): Rename from
9989         coff_symfile_info.  Add initializers.
9990         (xcoff_objfile_data_key): Move lower.  Change type.
9991         (XCOFF_DATA): Rewrite.
9992         (xcoff_free_info): Remove.
9993         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9994         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9995         (xcoff_initial_scan): Update.
9996
9997 2019-05-08  Tom Tromey  <tom@tromey.com>
9998
9999         * solib-svr4.c (struct svr4_info): Add initializers and
10000         destructor.
10001         <probes_table>: Now an htab_up.
10002         (solib_svr4_pspace_data): Change type.
10003         (free_probes_table): Simplify.
10004         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10005         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10006         (probes_table_remove_objfile_probes, register_solib_event_probe)
10007         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10008         (_initialize_svr4_solib): Update.
10009
10010 2019-05-08  Tom Tromey  <tom@tromey.com>
10011
10012         * remote.c (remote_pspace_data): Change type.
10013         (remote_pspace_data_cleanup): Remove.
10014         (get_remote_exec_file, set_pspace_remote_exec_file)
10015         (_initialize_remote): Update.
10016
10017 2019-05-08  Tom Tromey  <tom@tromey.com>
10018
10019         * breakpoint.c (breakpoint_objfile_key): Change type.
10020         (get_breakpoint_objfile_data): Update.
10021         (free_breakpoint_objfile_data): Remove.
10022         (_initialize_breakpoint): Update.
10023
10024 2019-05-08  Tom Tromey  <tom@tromey.com>
10025
10026         * linux-tdep.c (struct linux_info): Add initializers.
10027         (linux_inferior_data): Move.  Change type.
10028         (invalidate_linux_cache_inf): Update.
10029         (linux_inferior_data_cleanup): Remove.
10030         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10031
10032 2019-05-08  Tom Tromey  <tom@tromey.com>
10033
10034         * auxv.c (auxv_inferior_data): Move.  Change type.
10035         (auxv_inferior_data_cleanup): Remove.
10036         (invalidate_auxv_cache_inf): Rewrite.
10037         (get_auxv_inferior_data, _initialize_auxv): Update.
10038
10039 2019-05-08  Tom Tromey  <tom@tromey.com>
10040
10041         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10042         (symfile_debug_objfile_data_key): Change type.
10043         (symfile_debug_installed, debug_qf_has_symbols)
10044         (debug_qf_find_last_source_symtab)
10045         (debug_qf_forget_cached_source_info)
10046         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10047         (debug_qf_print_stats, debug_qf_dump)
10048         (debug_qf_expand_symtabs_for_function)
10049         (debug_qf_expand_all_symtabs)
10050         (debug_qf_expand_symtabs_with_fullname)
10051         (debug_qf_map_matching_symbols)
10052         (debug_qf_expand_symtabs_matching)
10053         (debug_qf_find_pc_sect_compunit_symtab)
10054         (debug_qf_map_symbol_filenames)
10055         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10056         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10057         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10058         (debug_sym_read_linetable, debug_sym_relocate): Update.
10059         (symfile_debug_free_objfile): Remove.
10060         (install_symfile_debug_logging, _initialize_symfile_debug):
10061         Update.
10062
10063 2019-05-08  Tom Tromey  <tom@tromey.com>
10064
10065         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10066         allocate_on_obstack.
10067         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10068         (get_dwarf2_per_objfile): Update.
10069         (set_dwarf2_per_objfile): Remove.
10070         (dwarf2_has_info, dwarf2_get_section_info): Update.
10071         (dwarf2_free_objfile): Remove.
10072         (_initialize_dwarf2_read): Update.
10073
10074 2019-05-08  Tom Tromey  <tom@tromey.com>
10075
10076         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10077         initializers.
10078         <unsupported_script_warning_printed,
10079         script_not_found_warning_printed>: Now bool.
10080         (auto_load_pspace_data): Change type.
10081         (~auto_load_pspace_info): Rename from
10082         auto_load_pspace_data_cleanup.
10083         (get_auto_load_pspace_data, init_loaded_scripts_info)
10084         (clear_section_scripts, maybe_print_unsupported_script_warning)
10085         (maybe_print_script_not_found_warning, _initialize_auto_load):
10086         Update.
10087
10088 2019-05-08  Tom Tromey  <tom@tromey.com>
10089
10090         * objfiles.c (objfile_pspace_info): Add destructor and
10091         initializers.
10092         (objfiles_pspace_data): Change type.
10093         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10094         (get_objfile_pspace_data): Update.
10095         (objfiles_bfd_data): Change type.
10096         (get_objfile_bfd_data): Update.
10097         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10098
10099 2019-05-08  Tom Tromey  <tom@tromey.com>
10100
10101         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10102         Change type.
10103         (get_catch_syscall_inferior_data): Update.
10104         (catch_syscall_inferior_data_cleanup): Remove.
10105         (_initialize_break_catch_syscall): Update.
10106
10107 2019-05-08  Tom Tromey  <tom@tromey.com>
10108
10109         * inflow.c (struct terminal_info): Add destructor and
10110         initializers.
10111         (inflow_inferior_data): Change type.
10112         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10113         (get_inflow_inferior_data, inflow_inferior_exit)
10114         (swap_terminal_info, _initialize_inflow): Update.
10115
10116 2019-05-08  Tom Tromey  <tom@tromey.com>
10117
10118         * target-dcache.c (target_dcache_cleanup): Remove.
10119         (target_dcache_aspace_key): Change type.
10120         (target_dcache_init_p, target_dcache_invalidate)
10121         (target_dcache_get, target_dcache_get_or_init)
10122         (_initialize_target_dcache): Update.
10123         * dcache.h (struct dcache_deleter): New.
10124
10125 2019-05-08  Tom Tromey  <tom@tromey.com>
10126
10127         * symtab.c (struct symbol_cache): Add destructor and
10128         initializers.
10129         (symbol_cache_key): Move.  Change type.
10130         (make_symbol_cache, free_symbol_cache): Remove.
10131         (get_symbol_cache): Update.
10132         (symbol_cache_cleanup): Remove.
10133         (ALL_PSPACES, symbol_cache_flush)
10134         (maintenance_print_symbol_cache)
10135         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10136         Update.
10137
10138 2019-05-08  Tom Tromey  <tom@tromey.com>
10139
10140         * symtab.c (struct main_info): Add destructor and initializers.
10141         (main_progspace_key): Move.  Change type.
10142         (get_main_info): Update.
10143         (main_info_cleanup): Remove.
10144         (_initialize_symtab): Update.
10145
10146 2019-05-08  Tom Tromey  <tom@tromey.com>
10147
10148         * registry.h (DECLARE_REGISTRY): Define the _key class.
10149
10150 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10151
10152         * NEWS: Merge two 'New commands' sections.
10153
10154 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10155
10156         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10157         parameter and use Ada language definition instead.
10158         (ada_val_print_ptr): Remove unused language parameter.
10159         (ada_val_print_num): Remove language parameter and use Ada language
10160         definition instead.
10161         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10162         parameter.
10163         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10164         parameter and use Ada language definition instead.
10165         (ada_val_print_1): Update all ada_val_print_xxx calls.
10166         Remove language parameter.
10167         (ada_val_print): Update ada_val_print_1 call.
10168
10169 2019-05-08  Tom Tromey  <tromey@adacore.com>
10170
10171         * remote.c (remote_hw_watchpoint_limit)
10172         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10173         Now static.
10174
10175 2019-05-08  Tom Tromey  <tromey@adacore.com>
10176
10177         * maint.c (_initialize_maint_cmds): Move initialization code to
10178         remote.c.
10179         (watchdog, show_watchdog): Move to remote.c.
10180         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10181         "watchdog" static.
10182         (_initialize_remote): Move initialization code from maint.c.
10183         * defs.h (watchdog): Don't declare.
10184
10185 2019-05-08  Tom Tromey  <tromey@adacore.com>
10186
10187         * tui/tui-interp.c: Include main.h.
10188         * interps.c: Include main.h.
10189         * main.h (interpreter_p): Declare.
10190         * defs.h (interpreter_p): Don't declare.
10191
10192 2019-05-08  Tom Tromey  <tromey@adacore.com>
10193
10194         * dwarf2loc.c: Include dwarf2read.h.
10195         * defs.h (read_unsigned_leb128): Don't declare.
10196         * dwarf2read.h (read_unsigned_leb128): Declare.
10197
10198 2019-05-08  Tom Tromey  <tromey@adacore.com>
10199
10200         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10201         method.
10202
10203 2019-05-08  Tom Tromey  <tromey@adacore.com>
10204
10205         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10206         when no wrap column is set.
10207
10208 2019-05-08  Tom Tromey  <tromey@adacore.com>
10209
10210         * c-lang.c (c_get_string): Handle non-C-style arrays.
10211
10212 2019-05-08  Tom Tromey  <tromey@adacore.com>
10213
10214         * typeprint.c (print_offset_data::update): Print the bit offset,
10215         not the number of bits remaining.
10216
10217 2019-05-08  Tom Tromey  <tromey@adacore.com>
10218
10219         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10220         padding at end of comment.
10221
10222 2019-05-08  Tom Tromey  <tromey@adacore.com>
10223
10224         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10225         Compare main types.
10226
10227 2019-05-06  Tom Tromey  <tom@tromey.com>
10228
10229         * common/scoped_mmap.c: Include common-defs.h.
10230         * common/scoped_mmap.h: Don't include config.h.
10231
10232 2019-05-04  Tom Tromey  <tom@tromey.com>
10233
10234         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10235         (struct aarch64_call_info): Add initializers.
10236         <si>: Now a std::vector.
10237         (pass_on_stack, aarch64_push_dummy_call): Update.
10238
10239 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10240             Tom Tromey  <tom@tromey.com>
10241
10242         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10243         (ppc_threads): Now a std::vector.  Now static.
10244         (hwdebug_find_thread_points_by_tid)
10245         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10246         Update.
10247
10248 2019-05-04  Tom Tromey  <tom@tromey.com>
10249
10250         * arc-tdep.c (arc_tdesc_init): Return bool.
10251
10252 2019-05-04  Tom Tromey  <tom@tromey.com>
10253
10254         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10255         Use gdb_assert_not_reached.
10256
10257 2019-05-04  Tom Tromey  <tom@tromey.com>
10258
10259         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10260         "false".
10261
10262 2019-05-04  Tom Tromey  <tom@tromey.com>
10263
10264         * arc-tdep.c (arc_tdesc_init): Use bool.
10265
10266 2019-05-04  Tom Tromey  <tom@tromey.com>
10267
10268         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10269
10270 2019-05-04  Tom Tromey  <tom@tromey.com>
10271
10272         * cli/cli-cmds.c (valid_command_p): Return bool.
10273
10274 2019-05-04  Tom Tromey  <tom@tromey.com>
10275
10276         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10277         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10278
10279 2019-05-04  Raul Tambre  <raul@tambre.ee>
10280
10281         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10282         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10283         operator for comparison.
10284
10285 2019-05-04  Tom Tromey  <tom@tromey.com>
10286
10287         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10288         (lookup_partial_symbol, print_partial_symbols)
10289         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10290         (psymbol_compare): Update.
10291         (add_psymbol_to_bcache): Clear the entire psymbol.
10292         (maintenance_check_psymtabs): Update.
10293         * psympriv.h (struct partial_symbol): Don't derive from
10294         general_symbol_info.
10295         <obj_section, unrelocated_address, address,
10296         set_unrelocated_address>: Update.
10297         <ginfo>: New member.
10298         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10299         (debug_names::write_psymbols): Update.
10300
10301 2019-05-04  Tom de Vries  <tdevries@suse.de>
10302
10303         * contrib/cc-with-tweaks.sh: Support -n arg.
10304
10305 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10306
10307         * corelow.c (core_target::detach): Ensure frame cache and
10308         register caches are cleared.
10309         inferior.c (exit_inferior_1): Likewise.
10310
10311 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10312             Tom Tromey  <tom@tromey.com>
10313
10314         * dictionary.c (collate_pending_symbols_by_language): Remove
10315         "struct" from foreach.
10316         * symtab.c (lookup_global_symbol_from_objfile)
10317         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10318         foreach.
10319         * ser-tcp.c (net_open): Remove "struct" from foreach.
10320         * objfiles.c (objfile_relocate, objfile_rebase)
10321         (objfile_has_symbols): Remove "struct" from foreach.
10322         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10323         from foreach.
10324         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10325         foreach.
10326         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10327         "struct" from foreach.
10328         * ada-lang.c (create_excep_cond_exprs)
10329         (ada_exception_catchpoint_cond_string): Remove "struct" from
10330         foreach.
10331
10332 2019-05-03  Tom Tromey  <tromey@adacore.com>
10333
10334         * ada-exp.y (convert_char_literal): Check suffix of each
10335         enumerator.
10336
10337 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10338
10339         PR ada/21406:
10340         * ada-exp.y (yywrap): Don't define.
10341         * ada-lex.l (%option): Add noyywrap
10342         (yywrap): Remove.
10343
10344 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10345
10346         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10347         _WIN32_WINNT to the XP level, unless already defined to a higher
10348         level.
10349
10350         * unittests/parse-connection-spec-selftests.c:
10351         * ser-tcp.c:
10352         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10353         override.
10354
10355         * symfile.c (find_separate_debug_file): Remove colon from the
10356         drive spec of DOS/Windows file names of the target, so that the
10357         file name produced from DEBUGDIR and the target's directory will
10358         be valid on DOS/Windows systems.
10359
10360 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10361
10362         * rust-lang.c (val_print_struct): Handle printing structures
10363         containing strings.
10364
10365 2019-05-02  Tom Tromey  <tromey@adacore.com>
10366
10367         * valarith.c (_initialize_valarith): Remove.
10368
10369 2019-05-01  Tom Tromey  <tromey@adacore.com>
10370
10371         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10372         bitfields.
10373
10374 2019-05-01  Tom Tromey  <tromey@adacore.com>
10375
10376         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10377         for big-endian copies.
10378
10379 2019-04-30  Ali Tamur  <tamur@google.com>
10380         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10381         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10382         (read_3_bytes): New function.
10383
10384 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10385
10386         * windows-nat.c (main_thread_id): Delete.
10387         (handle_output_debug_string): Replace main_thread_id by
10388         current_event.dwThreadId.
10389         (fake_create_process): Likewise.
10390         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10391         Do not set main_thread_id.
10392         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10393         current_event.dwThreadId.
10394         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10395
10396 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10397
10398         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10399         Use current_event.dwThreadId instead of main_thread_id.
10400
10401 2019-04-30  Tom Tromey  <tromey@adacore.com>
10402
10403         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10404         (create_excep_cond_exprs): Iterate over program spaces.
10405         (ada_exception_catchpoint_cond_string): Examine all minimal
10406         symbols for exception types.
10407
10408 2019-04-30  Tom Tromey  <tromey@adacore.com>
10409
10410         PR c++/24470:
10411         * dwarf2read.c (process_structure_scope): Handle case where type
10412         has template parameters but no symbol was created.
10413
10414 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10415             Chris January  <chris.january@arm.com>
10416
10417         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10418         qualifier.
10419         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10420
10421 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10422
10423         * f-typeprint.c (f_print_type): Update rules for printing
10424         whitespace.
10425         (f_type_print_varspec_suffix): Likewise.
10426
10427 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10428             Chris January  <chris.january@arm.com>
10429
10430         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10431         function arguments.
10432
10433 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10434
10435         * f-lang.c (build_fortran_types): Change name of void type to
10436         lower case.
10437         * f-typeprint.c (f_type_print_base): Print the name of the void
10438         type, rather than a fixed string.
10439         * f-valprint.c (f_decorations): Use lower case void string.
10440
10441 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10442             Chris January  <chris.january@arm.com>
10443
10444         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10445         types for Fortran.
10446
10447 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10448             Chris January  <chris.january@arm.com>
10449             David Lecomber  <david.lecomber@arm.com>
10450
10451         * f-exp.y (BINOP_INTRINSIC): New token.
10452         (exp): New parser rule handling BINOP_INTRINSIC.
10453         (f77_keywords): Add new builtin procedures.
10454         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10455         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10456         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10457         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10458         (print_unop_subexp_f): New function.
10459         (print_binop_subexp_f): New function.
10460         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10461         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10462         (dump_subexp_body_f): Likewise.
10463         (operator_check_f): Likewise.
10464         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10465         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10466
10467 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10468
10469         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10470         UNOP_KIND.
10471         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10472         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10473         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10474         (operator_length_f): New fuction.
10475         (print_subexp_f): New function.
10476         (op_name_f): New function.
10477         (dump_subexp_body_f): New function.
10478         (operator_check_f): New function.
10479         (exp_descriptor_f): Replace standard expression handling functions
10480         with new functions.
10481         * gdb/fortran-operator.def: New file.
10482         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10483         * gdb/std-operator.def: Remove UNOP_KIND.
10484
10485 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10486
10487         * std-operator.def: Remove unbalanced, stray double quote
10488         character.
10489
10490 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10491             Chris January  <chris.january@arm.com>
10492             Daniel Everett  <daniel.everett@arm.com>
10493             Nick Forrington  <nick.forrington@arm.com>
10494             Richard Bunt  <richard.bunt@arm.com>
10495
10496         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10497         of depth when printing anonymous structs or unions.
10498         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10499         Don't print either the top-level value, or the children if the
10500         max-depth is exceeded.
10501         (ppscm_print_children): When printing the key of a map, allow one
10502         extra level of depth.
10503         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10504         print either the top-level value, or the children if the max-depth
10505         is exceeded.
10506         (print_children): When printing the key of a map, allow one extra
10507         level of depth.
10508         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10509         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10510         (user_print_options): Initialise max_depth field.
10511         (val_print_scalar_or_string_type_p): New function.
10512         (val_print): Check to see if the max depth has been reached.
10513         (val_print_check_max_depth): Define new function.
10514         (show_print_max_depth): New function.
10515         (_initialize_valprint): Add 'print max-depth' option.
10516         * valprint.h (struct value_print_options) <max_depth>: New field.
10517         (val_print_check_max_depth): Declare new function.
10518         * NEWS: Document new feature.
10519
10520 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10521
10522         * ada-lang.c (ada_language_defn): Initialise new field.
10523         * c-lang.c (c_is_string_type_p): New function.
10524         (c_language_defn): Initialise new field.
10525         (cplus_language_defn): Initialise new field.
10526         (asm_language_defn): Initialise new field.
10527         (minimal_language_defn): Initialise new field.
10528         * c-lang.h (c_is_string_type_p): Declare new function.
10529         * d-lang.c (d_language_defn): Initialise new field.
10530         * f-lang.c (f_is_string_type_p): New function.
10531         (f_language_defn): Initialise new field.
10532         * go-lang.c (go_is_string_type_p): New function.
10533         (go_language_defn): Initialise new field.
10534         * language.c (default_is_string_type_p): New function.
10535         (unknown_language_defn): Initialise new field.
10536         (auto_language_defn): Initialise new field.
10537         * language.h (struct language_defn) <la_is_string_type_p>: New
10538         member variable.
10539         (default_is_string_type_p): Declare new function.
10540         * m2-lang.c (m2_language_defn): Initialise new field.
10541         * objc-lang.c (objc_language_defn): Initialise new field.
10542         * opencl-lang.c (opencl_language_defn): Initialise new field.
10543         * p-lang.c (pascal_is_string_type_p): New function.
10544         (pascal_language_defn): Initialise new field.
10545         * rust-lang.c (rust_is_string_type_p): New function.
10546         (rust_language_defn): Initialise new field.
10547
10548 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10549
10550         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10551         New field.
10552         * ada-lang.c (ada_language_defn): Initialise new field.
10553         * c-lang.c (c_language_defn): Likewise.
10554         (cplus_language_defn): Likewise.
10555         (asm_language_defn): Likewise.
10556         (minimal_language_defn): Likewise.
10557         * d-lang.c (d_language_defn): Likewise.
10558         * f-lang.c (f_language_defn): Likewise.
10559         * go-lang.c (go_language_defn): Likewise.
10560         * language.c (unknown_language_defn): Likewise.
10561         (auto_language_defn): Likewise.
10562         * m2-lang.c (m2_language_defn): Likewise.
10563         * objc-lang.c (objc_language_defn): Likewise.
10564         * opencl-lang.c (opencl_language_defn): Likewise.
10565         * p-lang.c (pascal_language_defn): Likewise.
10566         * rust-lang.c (rust_language_defn): Likewise.
10567
10568 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10569
10570         * ada-lang.c (ada_is_character_type): Change return type to bool.
10571         (ada_is_string_type): Likewise.
10572         * ada-lang.h (ada_is_character_type): Update declaration
10573         (ada_is_string_type): Likewise.
10574
10575 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10576
10577         Support style in 'frame|thread apply'
10578
10579         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10580         * record.c (record_start, record_stop): Update callers of
10581         execute_command_to_string with false.
10582         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10583         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10584         methods.
10585         (class string_file): New constructor with term_out parameter.
10586         Override methods term_out and can_emit_style_escape.  New member
10587         term_out.
10588         (class stdio_file): Override can_emit_style_escape.
10589         (class tee_file): Override term_out and can_emit_style_escape.
10590         * utils.h (can_emit_style_escape): Remove.
10591         * utils.c (can_emit_style_escape): Likewise.
10592         Update all callers of can_emit_style_escape (SOMESTREAM) to
10593         SOMESTREAM->can_emit_style_escape.
10594         * source-cache.c (source_cache::get_source_lines): Likewise.
10595         * stack.c (frame_apply_command_count): Call execute_command_to_string
10596         passing the term_out characteristic of the current gdb_stdout.
10597         * thread.c (thr_try_catch_cmd): Likewise.
10598         * top.c (execute_command_to_string): pass term_out parameter
10599         to construct the string_file for the command output.
10600         * ui-file.c (term_cli_styling): New function (most code moved
10601         from utils.c can_emit_style_escape).
10602         (string_file::string_file, string_file::can_emit_style_escape,
10603         stdio_file::can_emit_style_escape, tee_file::term_out,
10604         tee_file::can_emit_style_escape): New functions.
10605
10606 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10607
10608         * NEWS: Mention the new set|show may-call-functions.
10609         * infcall.c (may_call_functions_p): New variable.
10610         (show_may_call_functions_p): New function.
10611         (call_function_by_hand_dummy): Throws an error if not
10612         may-call-functions.
10613         (_initialize_infcall): Call add_setshow_boolean_cmd for
10614         may-call-functions.
10615
10616 2019-04-25  Keith Seitz  <keiths@redhat.com>
10617
10618         PR c++/24367
10619         * cp-support.c (inspect_type): Don't attempt substitutions
10620         of symbol with the same name.
10621
10622 2019-04-25  Tom Tromey  <tromey@adacore.com>
10623
10624         PR gdb/24475:
10625         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10626         static.
10627
10628 2019-04-25  Tom Tromey  <tromey@adacore.com>
10629
10630         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10631         rvalue reference.
10632         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10633         (gdb_xml_parser::parse): Use std::move.
10634         * python/python-internal.h (gdbpy_convert_exception): Take a const
10635         reference.
10636         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10637         std::move.
10638         * python/py-utils.c (gdbpy_convert_exception): Take a const
10639         reference.
10640         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10641         Use std::move.
10642         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10643         Use std::move.
10644         * mi/mi-main.c (mi_print_exception): Take a const reference.
10645         * main.c (handle_command_errors): Take a const reference.
10646         * linespec.c (parse_linespec): Use std::move.
10647         * infcall.c (run_inferior_call): Use std::move.
10648         (call_function_by_hand_dummy): Use std::move.
10649         * exec.c (try_open_exec_file): Use std::move.
10650         * exceptions.h (exception_print, exception_fprintf)
10651         (exception_print_same): Update.
10652         * exceptions.c (print_exception, exception_print)
10653         (exception_fprintf, exception_print_same): Change parameters to
10654         const reference.
10655         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10656         * common/new-op.c: Use std::move.
10657         * common/common-exceptions.h (struct gdb_exception): Add move
10658         constructor.
10659         (struct gdb_exception_error, struct gdb_exception_quit, struct
10660         gdb_quit_bad_alloc): Change constructor to move constructor.
10661         (throw_exception): Change parameter to rvalue reference.
10662         * common/common-exceptions.c (throw_exception): Take rvalue
10663         reference.
10664         * cli/cli-interp.c (safe_execute_command): Use std::move.
10665         * breakpoint.c (insert_bp_location, location_to_sals): Use
10666         std::move.
10667
10668 2019-04-25  Tom Tromey  <tromey@adacore.com>
10669
10670         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10671         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10672         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10673         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10674         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10675         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10676         guile/scm-value.c: Use unpack.
10677         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10678         gdbscm_gdb_exception.
10679         (gdbscm_throw_gdb_exception): Likewise.
10680         (struct gdbscm_gdb_exception): New.
10681         (unpack): New function.
10682         (gdbscm_wrap): Use unpack.
10683
10684 2019-04-25  Tom Tromey  <tromey@adacore.com>
10685
10686         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10687         (gdb_rl_callback_handler): Use std::move.
10688         * common/common-exceptions.h (struct gdb_exception): Add move
10689         assignment operator.
10690         (throw_exception_sjlj): Change "exception" to const reference.
10691         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10692         (throw_exception_sjlj): Change "exception" to const reference.
10693
10694 2019-04-25  Tom Tromey  <tromey@adacore.com>
10695
10696         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10697         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10698         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10699         Update.
10700         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10701         Update.
10702         * mi/mi-interp.c (mi_interp::exec): Update.
10703         * linespec.c (parse_linespec): Update.
10704         * infcall.c (run_inferior_call): Update.
10705         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10706         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10707         (gdbscm_lookup_global_symbol): Update.
10708         * guile/scm-param.c (gdbscm_parameter_value): Update.
10709         * guile/scm-frame.c (gdbscm_frame_read_register)
10710         (gdbscm_frame_read_var): Update.
10711         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10712         * exec.c (try_open_exec_file): Update.
10713         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10714         (gdb_rl_callback_handler): Update.
10715         * common/common-exceptions.h (exception_none): Don't declare.
10716         * common/common-exceptions.c (exception_none): Don't define.
10717         (struct catcher) <exception>: Update.
10718         * cli/cli-interp.c (safe_execute_command): Update.
10719         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10720
10721 2019-04-25  Ali Tamur  <tamur@google.com>
10722
10723         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10724         (read_attribute_value): Likewise.
10725         (dwarf2_read_addr_index): Update comment.
10726         (read_str_index): Add DW_FORM_strx.
10727         (dwarf2_string_attr): Likewise.
10728         (dwarf2_const_value_attr): Likewise.
10729         (dump_die_shallow): Likewise.
10730         (dwarf2_fetch_constant_bytes): Likewise.
10731         (skip_form_bytes): Likewise.
10732         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10733
10734 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10735
10736         PR corefiles/11608
10737         PR corefiles/18187
10738         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10739         OFFSET.  Verify if current mapping contains an ELF header.
10740         (linux_find_memory_regions_full): Adjust call to
10741         dump_mapping_p.
10742
10743 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10744             Kang Li <kanglictf@gmail.com>
10745
10746         PR gdb/21600
10747
10748         * dwarf2-frame.c (read_initial_length): Be consistent about using
10749         unsigned representation of length.
10750         (decode_frame_entry_1): Likewise.  Check for wraparound of
10751         end pointer as well as buffer overflow.
10752
10753 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10754
10755         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10756         "vq".
10757
10758 2019-04-24  Tom Tromey  <tromey@adacore.com>
10759
10760         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10761
10762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10763
10764         * s12z-tdep.c (s12z_unwind_pc): Delete.
10765         (s12z_unwind_sp): Delete.
10766         (s12z_gdbarch_init): Don't register deleted functions with
10767         gdbarch.
10768
10769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10770
10771         * rl78-tdep.c (rl78_unwind_sp): Delete.
10772         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10773
10774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10775
10776         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10777         (xstormy16_unwind_pc): Delete.
10778         (xstormy16_dummy_id): Delete.
10779         (xstormy16_gdbarch_init): Don't register deleted functions with
10780         gdbarch.
10781
10782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10783
10784         * vax-tdep.c (vax_unwind_pc): Delete.
10785         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10786
10787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10788
10789         * v850-tdep.c (v850_unwind_sp): Delete.
10790         (v850_unwind_pc): Delete.
10791         (v850_dummy_id): Delete.
10792         (v850_gdbarch_init): Don't register deleted functions with
10793         gdbarch.
10794
10795 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10796
10797         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10798         (tilegx_unwind_pc): Delete.
10799         (tilegx_unwind_dummy_id): Delete.
10800         (tilegx_gdbarch_init): Don't register deleted functions with
10801         gdbarch.
10802
10803 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10804
10805         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10806         (tic6x_dummy_id): Delete.
10807         (tic6x_gdbarch_init): Don't register deleted functions with
10808         gdbarch.
10809
10810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10811
10812         * sparc-tdep.c (sparc_unwind_pc): Delete.
10813         (sparc32_gdbarch_init): Don't register deleted function with
10814         gdbarch.
10815
10816 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10817
10818         * sh-tdep.c (sh_unwind_sp): Delete.
10819         (sh_unwind_pc): Delete.
10820         (sh_dummy_id): Delete.
10821         (sh_gdbarch_init): Don't register deleted functions with
10822         gdbarch.
10823
10824 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10825
10826         * score-tdep.c (score_unwind_sp): Delete.
10827         (score_unwind_pc): Delete.
10828         (score_dummy_id): Delete.
10829         (score_gdbarch_init): Don't register deleted functions with
10830         gdbarch.
10831
10832 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10833
10834         * rx-tdep.c (rx_unwind_pc): Delete.
10835         (rx_unwind_sp): Delete.
10836         (rx_dummy_id): Delete.
10837         (rx_gdbarch_init): Don't register deleted functions with
10838         gdbarch.  Update comment.
10839
10840 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10841
10842         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10843         (rs6000_dummy_id): Delete.
10844         (rs6000_gdbarch_init): Don't register deleted functions with
10845         gdbarch.
10846
10847 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10848
10849         * or1k-tdep.c (or1k_dummy_id): Delete.
10850         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10851
10852 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10853
10854         * nios2-tdep.c (nios2_dummy_id): Delete.
10855         (nios2_unwind_sp): Delete.
10856         (nios2_gdbarch_init): Don't register deleted functions with
10857         gdbarch.
10858
10859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10860
10861         * nds32-tdep.c (nds32_dummy_id): Delete.
10862         (nds32_unwind_pc): Delete.
10863         (nds32_unwind_sp): Delete.
10864         (nds32_gdbarch_init): Don't register deleted functions with
10865         gdbarch.
10866
10867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10868
10869         * msp430-tdep.c (msp430_unwind_pc): Delete.
10870         (msp430_unwind_sp): Delete.
10871         (msp430_dummy_id): Delete.
10872         (msp430_gdbarch_init): Don't register deleted functions with
10873         gdbarch.
10874
10875 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10876
10877         * moxie-tdep.c (moxie_unwind_sp): Delete.
10878         (moxie_unwind_pc): Delete.
10879         (moxie_dummy_id): Delete.
10880         (moxie_gdbarch_init): Don't register deleted functions with
10881         gdbarch.
10882
10883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10884
10885         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10886         (mn10300_unwind_pc): Delete.
10887         (mn10300_unwind_sp): Delete.
10888         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10889         mn10300_unwind_sp.
10890         (mn10300_frame_unwind_init): Don't register deleted functions with
10891         gdbarch.
10892
10893 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10894
10895         * mep-tdep.c (mep_unwind_pc): Delete.
10896         (mep_unwind_sp): Delete.
10897         (mep_dummy_id): Delete.
10898         (mep_gdbarch_init): Don't register deleted functions with
10899         gdbarch.
10900
10901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10902
10903         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10904         (m68hc11_unwind_sp): Delete.
10905         (m68hc11_gdbarch_init): Don't register deleted functions with
10906         gdbarch.
10907
10908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10909
10910         * m32r-tdep.c (m32r_unwind_sp): Delete.
10911         (m32r_unwind_pc): Delete.
10912         (m32r_dummy_id): Delete.
10913         (m32r_gdbarch_init): Don't register deleted functions with
10914         gdbarch.
10915
10916 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10917
10918         * m32c-tdep.c (m32c_unwind_pc): Delete.
10919         (m32c_unwind_sp): Delete.
10920         (m32c_dummy_id): Delete.
10921         (m32c_gdbarch_init): Don't register deleted functions with
10922         gdbarch.
10923
10924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10925
10926         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10927         (lm32_unwind_pc): Delete.
10928         (lm32_dummy_id): Delete.
10929         (lm32_gdbarch_init): Don't register deleted functions with
10930         gdbarch.
10931
10932 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10933
10934         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10935         (iq2000_unwind_pc): Delete.
10936         (iq2000_dummy_id): Delete.
10937         (iq2000_gdbarch_init): Don't register deleted functions with
10938         gdbarch.
10939
10940 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10941
10942         * nds32-tdep.c (nds32_type_align): Delete.
10943         (nds32_push_dummy_call): Use type_align instead.
10944
10945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10946
10947         * arm-tdep.c (arm_type_align): Only handle vector override case.
10948         (arm_push_dummy_call): Use type_align.
10949         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10950
10951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10952
10953         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10954         case.
10955         (pass_on_stack): Use type_align.
10956         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10957         function.
10958
10959 2019-04-23  Tom Tromey  <tromey@adacore.com>
10960
10961         * dwarf2read.c (line_header::file_name_at): Remove unused
10962         overload.
10963
10964 2019-04-23  Tom de Vries  <tdevries@suse.de>
10965
10966         PR gdb/24438
10967         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10968         invocation.
10969
10970
10971 2019-03-27  Ali Tamur  <tamur@google.com>
10972
10973         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10974         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10975         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10976         (dwarf_expr_context::get_addr_index): Likewise
10977         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10978         (symbol_needs_eval_context::get_addr_index): Likewise
10979         (disassemble_dwarf_expression): Add DW_OP_addrx
10980         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10981         (read_cutu_die_from_dwo): Update comment
10982         (skip_one_die): Add DW_FORM_addrx
10983         (read_attribute_value): Likewise
10984         (var_decode_location): Add DW_OP_addrx
10985         (dwarf2_const_value_attr): Add DW_FORM_addrx
10986         (dump_die_shallow): Likewise
10987         (dwarf2_fetch_constant_bytes): Likewise
10988         (decode_locdesc): Add DW_OP_addrx
10989         (skip_form_bytes): Add DW_FORM_addrx
10990
10991 2019-04-22  Ali Tamur  <tamur@google.com>
10992
10993         * MAINTAINERS (Write After Approval): Add self.
10994
10995 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10996
10997         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10998         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10999         (open_symbol_file_object): Likewise.
11000         (svr4_default_sos): Add info parameter.
11001         (svr4_read_so_list): Likewise.
11002         (svr4_current_sos_direct): Adjust functions calls to pass down
11003         info.
11004         (svr4_current_sos_1): Add info parameter.
11005         (svr4_current_sos): Call get_svr4_info, pass info down to
11006         svr4_current_sos_1.
11007         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11008         get_svr4_info.
11009         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11010         get_svr4_info.
11011         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11012         to get_svr4_info.
11013         (probes_table_remove_objfile_probes): Likewise.
11014         (register_solib_event_probe): Add info parameter.
11015         (solist_update_incremental): Pass info parameter down to
11016         svr4_read_so_list.
11017         (disable_probes_interface): Add info parameter.
11018         (svr4_handle_solib_event): Pass current_program_space to
11019         get_svr4_info.  Adjust disable_probes_interface cleanup.
11020         (svr4_create_probe_breakpoints): Add info parameter, pass it
11021         down to register_solib_event_probe.
11022         (svr4_create_solib_event_breakpoints): Add info parameter,
11023         pass it down to svr4_create_probe_breakpoints.
11024         (enable_break): Pass info down to
11025         svr4_create_solib_event_breakpoints.
11026         (svr4_solib_create_inferior_hook): Pass current_program_space to
11027         get_svr4_info.
11028         (svr4_clear_solib): Likewise.
11029
11030 2019-04-22  Pedro Alves  <palves@redhat.com>
11031
11032         * solib-svr4.c (svr4_free_objfile_observer): New.
11033         (probe_and_action::objfile): New field.
11034         (probes_table_htab_remove_objfile_probes)
11035         (probes_table_remove_objfile_probes): New functions.
11036         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11037         in the new probe_and_action.  Don't store the probe in 'lookup'.
11038         (svr4_create_probe_breakpoints): Pass objfile to
11039         register_solib_event_probe.
11040         (_initialize_svr4_solib): Register a free_objfile observer.
11041
11042 2019-04-19  Tom Tromey  <tom@tromey.com>
11043
11044         * common/queue.h: Remove.
11045
11046 2019-04-19  Tom Tromey  <tom@tromey.com>
11047
11048         * event-loop.c: Don't include "common/queue.h".
11049
11050 2019-04-19  Tom Tromey  <tom@tromey.com>
11051
11052         * remote.c (remote_target): Use delete.
11053         * remote-notif.h: Include <list>, not "common/queue.h".
11054         (notif_client_p): Remove typedef.
11055         (remote_notif_state): Add constructor, destructor, initializer.
11056         <notif_queue>: Now a std::list.
11057         (remote_notif_state_xfree): Don't declare.
11058         * remote-notif.c (remote_notif_process, handle_notification)
11059         (remote_notif_state_allocate): Update.
11060         (~remote_notif_state): Rename from remote_notif_state_xfree.
11061
11062 2019-04-19  Tom Tromey  <tom@tromey.com>
11063
11064         * symfile.c (reread_symbols): Update.
11065         * objfiles.c (objfile_register_static_link)
11066         (objfile_lookup_static_link): Update
11067         (~objfile) Don't delete static_links.
11068         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11069
11070 2019-04-19  Tom Tromey  <tom@tromey.com>
11071
11072         * type-stack.h (struct type_stack) <insert>: Constify string.
11073         * type-stack.c (type_stack::insert): Constify string.
11074         * gdbtypes.h (lookup_template_type): Update.
11075         (address_space_name_to_int): Update.
11076         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11077         const.
11078         (lookup_template_type): Make name const.
11079         * c-exp.y: Update rules.
11080         (lex_one_token, classify_name, classify_inner_name)
11081         (c_print_token): Update.
11082         * p-exp.y: Update rules.
11083         (yylex): Update.
11084         * f-exp.y: Update rules.
11085         (yylex): Update.
11086         * d-exp.y: Update rules.
11087         (lex_one_token, classify_name, classify_inner_name): Update.
11088         * parse.c (write_dollar_variable, copy_name): Return std::string.
11089         * parser-defs.h (copy_name): Change return type.
11090         * m2-exp.y: Update rules.
11091         (yylex): Update.
11092         * go-exp.y (lex_one_token): Update.
11093         Update rules.
11094         (classify_unsafe_function, classify_packaged_name)
11095         (classify_name, yylex): Update.
11096
11097 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11098
11099         * configure.ac: add --enable-source-highlight switch.
11100         * configure: Regenerate.
11101         * top.c (print_gdb_version): plumb --enable-source-highlight
11102         status to "show configuration".
11103
11104 2019-04-19  Tom Tromey  <tromey@adacore.com>
11105
11106         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11107         Check ADA_TYPE_P.
11108         (empty_record, ada_template_to_fixed_record_type_1)
11109         (template_to_static_fixed_type)
11110         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11111         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11112         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11113         macros.
11114
11115 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11116
11117         PR symtab/24423:
11118         * source.c (print_source_lines_base): Advance "iter" when a
11119         control character is seen.
11120
11121 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11122
11123         * inferior.h (struct infcall_suspend_state_deleter):
11124         Catch exception in destructor to avoid crash.
11125
11126 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11127
11128         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11129         close to the add_com "shell".
11130
11131 2019-04-18  Tom Tromey  <tromey@adacore.com>
11132
11133         * process-stratum-target.h (class process_stratum_target)
11134         <stratum>: Add "final".
11135
11136 2019-04-17  Tom Tromey  <tromey@adacore.com>
11137
11138         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11139         against nullptr before use.
11140
11141 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11142
11143         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11144
11145 2019-04-17  Jim Wilson  <jimw@sifive.com>
11146             Andrew Burgess  <andrew.burgess@embecosm.com>
11147
11148         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11149         code read might fail, assume 4-byte breakpoint in that case.
11150
11151 2019-04-15  Leszek Swirski  <leszeks@google.com>
11152
11153         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11154         rather than a hand-rolled POD check when checking for forced MEMORY
11155         classification.
11156
11157 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11158
11159         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11160         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11161         function.
11162         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11163         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11164         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11165         declaration.
11166
11167 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11168
11169         * aarch64-linux-nat.c
11170         (aarch64_linux_nat_target::thread_architecture): Add override.
11171         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11172         each VQ.
11173
11174 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11175
11176         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11177
11178 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11179
11180         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11181         target types of size 96-bits, add some additional comments, and
11182         check that the builtin type we found was the correct size.
11183
11184 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11185
11186         * utils.c (prompt_for_continue): Don't restore the styling at the
11187         end, as applied_style has the wrong value.  This fixes styling in
11188         long lists of file names that are interrupted by the "Continue?"
11189         prompt.
11190
11191 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11192
11193         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11194         * c-lang.c (c_language_defn): Likewise.
11195         (cplus_language_defn): Likewise.
11196         (asm_language_defn): Likewise.
11197         (minimal_language_defn): Likewise.
11198         * d-lang.c (d_language_defn): Likewise.
11199         * f-lang.c (f_language_defn): Likewise.
11200         * go-lang.c (go_language_defn): Likewise.
11201         * language.c (unknown_language_defn): Likewise.
11202         (auto_language_defn): Likewise.
11203         * language.h (struct language_defn): Remove la_magic field.
11204         (LANG_MAGIC): Delete.
11205         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11206         * objc-lang.c (objc_language_defn): Likewise.
11207         * opencl-lang.c (opencl_language_defn): Likewise.
11208         * p-lang.c (pascal_language_defn): Likewise.
11209         * rust-lang.c (rust_language_defn): Likewise.
11210
11211 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11212
11213         * riscv-tdep.c (riscv_type_align): New function.
11214         (riscv_type_alignment): Delete.
11215         (riscv_arg_location): Use 'type_align'.
11216         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11217
11218 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11219
11220         * gdbtypes.c (type_align): A struct with no non-static fields also
11221         has alignment of 1.
11222
11223 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11224
11225         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11226         component to 0.
11227         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11228         member.
11229         (riscv_struct_info::analyse): New implementation using new
11230         analyse_inner member function.
11231         (riscv_struct_info::field_offset): New member function.
11232         (riscv_struct_info::m_offsets): New member variable.
11233         (riscv_struct_info::analyse_inner): New private member function,
11234         takes the old implementation of riscv_struct_info::analyse but
11235         extended to track field offsets.
11236         (riscv_call_arg_struct): Update the struct folding special cases
11237         to handle cases where empty C++ structs, which are non-zero
11238         length, are found.
11239         (riscv_arg_location): Initialise the length of each location, a
11240         non-zero length now indicates the location is in use.
11241         (riscv_push_dummy_call): Allow for the first location having a
11242         non-zero offset when setting up arguments.
11243         (riscv_return_value): Likewise, but for return values.
11244
11245 2019-04-11  Tom Tromey  <tromey@adacore.com>
11246
11247         * utils.c (internal_vproblem): Make "msg" const.
11248
11249 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11250
11251         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11252         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11253         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11254         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11255
11256 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11257
11258         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11259         function.
11260         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11261         of amd64_collect_native_gregset.
11262         (amd64_linux_nat_target::store_registers): Likewise.
11263
11264 2019-04-10  Tom Tromey  <tom@tromey.com>
11265
11266         * symtab.c (lookup_global_symbol_from_objfile)
11267         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11268         * objfiles.h (class separate_debug_iterator): New.
11269         (class separate_debug_range): New.
11270         (struct objfile) <separate_debug_objfiles>: New method.
11271         (objfile_separate_debug_iterate): Don't declare.
11272         * objfiles.c (separate_debug_iterator::operator++): Rename from
11273         objfile_separate_debug_iterate.
11274         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11275         iterator.
11276         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11277         iterator.
11278
11279 2019-04-10  Tom Tromey  <tom@tromey.com>
11280
11281         * symfile.c (reread_symbols): Remove old comment.
11282         * objfiles.c (free_all_objfiles): Fix a typo.
11283
11284 2019-04-10  Tom Tromey  <tom@tromey.com>
11285
11286         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11287         * minsyms.c (lookup_minimal_symbol): Use foreach.
11288         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11289         (lookup_minimal_symbol_solib_trampoline): Likewise.
11290         * symfile.c (reread_symbols): Use foreach.
11291
11292 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11293             Tom Tromey  <tromey@adacore.com>
11294
11295         PR rust/24414:
11296         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11297         (rust_lex_int_test): Change "value" to be LONGEST.
11298         (rust_lex_tests): Add test for long integer literal.
11299
11300 2019-04-09  Tom Tromey  <tromey@adacore.com>
11301
11302         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11303         to bool.
11304         (extended_remote_target::attach): Update.
11305         (remote_target::remote_notice_new_inferior): Update.
11306         (remote_target::add_current_inferior_and_thread): Update.
11307         * inferior.c (exit_inferior_1): Use "false".
11308         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11309
11310 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11311
11312         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11313         the "start" command.
11314
11315 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11316
11317         * python/py-inferior.c (infpy_thread_from_thread_handle):
11318         Adjust comments to reflect renaming of thread_from_thread_handle
11319         to thread_from_handle.  Adjust keywords.  Fix type error message.
11320         (inferior_object_methods): Add thread_from_handle.  Retain
11321         thread_from_thread_handle, but mark it as deprecated.
11322
11323 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11324
11325         * gdbthread.h (find_thread_by_handle): Revise declaration.
11326         * thread.c (find_thread_by_handle): Likewise.  Adjust
11327         implementation too.
11328         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11329         support for buffer objects as handles.
11330
11331 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11332
11333         * python/py-infthread.c (thpy_thread_handle): New function.
11334         (thread_object_methods): Register thpy_thread_handle.
11335
11336 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11337
11338         * gdbthread.h (thread_to_thread_handle): Declare.
11339         * thread.c (gdbtypes.h): Include.
11340         (thread_to_thread_handle): New function.
11341
11342         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11343         (target_thread_info_to_thread_handle): Declare.
11344         * target.c (target_thread_info_to_thread_handle): New function.
11345         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11346         * target-delegates.c: Regenerate.
11347
11348         * linux-thread-db.c (class thread_db_target): Add method
11349         thread_info_to_thread_handle.
11350         (thread_db_target::thread_info_to_thread_handle): Define.
11351         * remote.c (class remote_target): Add new method
11352         thread_info_to_thread_handle.
11353         (remote_target::thread_info_to_thread_handle): Define.
11354
11355 2019-04-08  Pedro Alves  <palves@redhat.com>
11356
11357         * common/common-exceptions.c (throw_exception): Don't create
11358         named object to throw; throw directly.
11359         (throw_it): Likewise.  Don't initialize gdb_exception::message
11360         here, with new; pass FMT and AP to the ctor instead.
11361         * common/common-exceptions.h: Include <string>.
11362         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11363         const char *, va_list)): New ctor.  Use std::make_shared.
11364         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11365         errors)): Delete.
11366         (gdb_exception_error::gdb_exception_error(enum errors, const char
11367         *, va_list)): New.
11368         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11369         Add assertion.
11370         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11371         errors)): Delete.
11372         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11373         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11374         Add assertion.
11375
11376 2019-04-08  Tom Tromey  <tom@tromey.com>
11377
11378         * valops.c (value_rtti_indirect_type): Replace throw_exception
11379         with throw.
11380         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11381         with throw.
11382         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11383         throw.
11384         * target.c (target_translate_tls_address): Replace throw_exception
11385         with throw.
11386         * stack.c (frame_apply_command_count): Replace throw_exception
11387         with throw.
11388         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11389         throw.
11390         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11391         with throw.
11392         * rs6000-tdep.c (rs6000_frame_cache)
11393         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11394         * remote.c: Replace throw_exception with throw.
11395         * record-full.c (record_full_message, record_full_wait_1)
11396         (record_full_restore): Replace throw_exception with throw.
11397         * record-btrace.c:
11398         (get_thread_current_frame_id, record_btrace_start_replaying)
11399         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11400         (cmd_record_btrace_start): Replace throw_exception with throw.
11401         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11402         throw.
11403         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11404         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11405         * linespec.c:
11406         (find_linespec_symbols): Replace throw_exception with throw.
11407         * infrun.c (displaced_step_prepare, resume): Replace
11408         throw_exception with throw.
11409         * infcmd.c (post_create_inferior): Replace throw_exception with
11410         throw.
11411         * inf-loop.c (inferior_event_handler): Replace throw_exception
11412         with throw.
11413         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11414         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11415         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11416         (get_prev_frame_always, get_frame_pc_if_available)
11417         (get_frame_address_in_block_if_available, get_frame_language):
11418         Replace throw_exception with throw.
11419         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11420         throw_exception with throw.
11421         * eval.c (fetch_subexp_value, evaluate_var_value)
11422         (evaluate_funcall, evaluate_subexp_standard): Replace
11423         throw_exception with throw.
11424         * dwarf2loc.c (call_site_find_chain)
11425         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11426         Replace throw_exception with throw.
11427         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11428         with throw.
11429         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11430         throw.
11431         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11432         * completer.c (complete_line_internal): Replace throw_exception
11433         with throw.
11434         * compile/compile-object-run.c (compile_object_run): Replace
11435         throw_exception with throw.
11436         * cli/cli-script.c (process_next_line): Replace throw_exception
11437         with throw.
11438         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11439         (btrace_enable, btrace_maint_update_pt_packets): Replace
11440         throw_exception with throw.
11441         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11442         throw_exception with throw.
11443         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11444         throw_exception with throw.
11445         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11446         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11447         * aarch64-tdep.c (aarch64_make_prologue_cache)
11448         (aarch64_make_stub_cache): Replace throw_exception with throw.
11449
11450 2019-04-08  Tom Tromey  <tom@tromey.com>
11451
11452         * common/common-exceptions.c (throw_exception): Rename from
11453         throw_exception_cxx.  Remove old copy.  Make argument const.
11454         (throw_it): Create and throw exception objects directly.
11455         * common/common-exceptions.h (throw_exception): Make argument
11456         const.
11457         (struct gdb_exception_error): Add constructor.
11458         (struct gdb_exception_quit): Add constructor.
11459
11460 2019-04-08  Tom Tromey  <tom@tromey.com>
11461
11462         * common/common-exceptions.h (exception_rethrow): Don't declare.
11463         (TRY_SJLJ): Update comment.
11464         (TRY, CATCH, END_CATCH): Remove.
11465         * common/common-exceptions.c (exception_rethrow): Remove.
11466
11467 2019-04-08  Tom Tromey  <tom@tromey.com>
11468
11469         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11470         Remove.
11471         (gdb_exception_error): Rename from
11472         gdb_exception_RETURN_MASK_ERROR.
11473         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11474         (gdb_quit_bad_alloc): Update.
11475         * aarch64-tdep.c: Update.
11476         * ada-lang.c: Update.
11477         * ada-typeprint.c: Update.
11478         * ada-valprint.c: Update.
11479         * amd64-tdep.c: Update.
11480         * arch-utils.c: Update.
11481         * break-catch-throw.c: Update.
11482         * breakpoint.c: Update.
11483         * btrace.c: Update.
11484         * c-varobj.c: Update.
11485         * cli/cli-cmds.c: Update.
11486         * cli/cli-interp.c: Update.
11487         * cli/cli-script.c: Update.
11488         * common/common-exceptions.c: Update.
11489         * common/new-op.c: Update.
11490         * common/selftest.c: Update.
11491         * compile/compile-c-symbols.c: Update.
11492         * compile/compile-cplus-symbols.c: Update.
11493         * compile/compile-object-load.c: Update.
11494         * compile/compile-object-run.c: Update.
11495         * completer.c: Update.
11496         * corelow.c: Update.
11497         * cp-abi.c: Update.
11498         * cp-support.c: Update.
11499         * cp-valprint.c: Update.
11500         * darwin-nat.c: Update.
11501         * disasm-selftests.c: Update.
11502         * dtrace-probe.c: Update.
11503         * dwarf-index-cache.c: Update.
11504         * dwarf-index-write.c: Update.
11505         * dwarf2-frame-tailcall.c: Update.
11506         * dwarf2-frame.c: Update.
11507         * dwarf2loc.c: Update.
11508         * dwarf2read.c: Update.
11509         * eval.c: Update.
11510         * event-loop.c: Update.
11511         * event-top.c: Update.
11512         * exec.c: Update.
11513         * f-valprint.c: Update.
11514         * fbsd-tdep.c: Update.
11515         * frame-unwind.c: Update.
11516         * frame.c: Update.
11517         * gdbtypes.c: Update.
11518         * gnu-v3-abi.c: Update.
11519         * guile/guile-internal.h: Update.
11520         * guile/scm-block.c: Update.
11521         * guile/scm-breakpoint.c: Update.
11522         * guile/scm-cmd.c: Update.
11523         * guile/scm-disasm.c: Update.
11524         * guile/scm-frame.c: Update.
11525         * guile/scm-lazy-string.c: Update.
11526         * guile/scm-math.c: Update.
11527         * guile/scm-param.c: Update.
11528         * guile/scm-ports.c: Update.
11529         * guile/scm-pretty-print.c: Update.
11530         * guile/scm-symbol.c: Update.
11531         * guile/scm-symtab.c: Update.
11532         * guile/scm-type.c: Update.
11533         * guile/scm-value.c: Update.
11534         * i386-linux-tdep.c: Update.
11535         * i386-tdep.c: Update.
11536         * inf-loop.c: Update.
11537         * infcall.c: Update.
11538         * infcmd.c: Update.
11539         * infrun.c: Update.
11540         * jit.c: Update.
11541         * language.c: Update.
11542         * linespec.c: Update.
11543         * linux-fork.c: Update.
11544         * linux-nat.c: Update.
11545         * linux-tdep.c: Update.
11546         * linux-thread-db.c: Update.
11547         * main.c: Update.
11548         * mi/mi-cmd-break.c: Update.
11549         * mi/mi-cmd-stack.c: Update.
11550         * mi/mi-interp.c: Update.
11551         * mi/mi-main.c: Update.
11552         * objc-lang.c: Update.
11553         * p-valprint.c: Update.
11554         * parse.c: Update.
11555         * ppc-linux-tdep.c: Update.
11556         * printcmd.c: Update.
11557         * python/py-arch.c: Update.
11558         * python/py-breakpoint.c: Update.
11559         * python/py-cmd.c: Update.
11560         * python/py-finishbreakpoint.c: Update.
11561         * python/py-frame.c: Update.
11562         * python/py-framefilter.c: Update.
11563         * python/py-gdb-readline.c: Update.
11564         * python/py-inferior.c: Update.
11565         * python/py-infthread.c: Update.
11566         * python/py-lazy-string.c: Update.
11567         * python/py-linetable.c: Update.
11568         * python/py-objfile.c: Update.
11569         * python/py-param.c: Update.
11570         * python/py-prettyprint.c: Update.
11571         * python/py-progspace.c: Update.
11572         * python/py-record-btrace.c: Update.
11573         * python/py-record.c: Update.
11574         * python/py-symbol.c: Update.
11575         * python/py-type.c: Update.
11576         * python/py-unwind.c: Update.
11577         * python/py-utils.c: Update.
11578         * python/py-value.c: Update.
11579         * python/python.c: Update.
11580         * record-btrace.c: Update.
11581         * record-full.c: Update.
11582         * remote-fileio.c: Update.
11583         * remote.c: Update.
11584         * riscv-tdep.c: Update.
11585         * rs6000-aix-tdep.c: Update.
11586         * rs6000-tdep.c: Update.
11587         * rust-exp.y: Update.
11588         * rust-lang.c: Update.
11589         * s390-tdep.c: Update.
11590         * selftest-arch.c: Update.
11591         * solib-dsbt.c: Update.
11592         * solib-frv.c: Update.
11593         * solib-spu.c: Update.
11594         * solib-svr4.c: Update.
11595         * solib.c: Update.
11596         * sparc64-linux-tdep.c: Update.
11597         * stack.c: Update.
11598         * symfile-mem.c: Update.
11599         * symmisc.c: Update.
11600         * target.c: Update.
11601         * thread.c: Update.
11602         * top.c: Update.
11603         * tracefile-tfile.c: Update.
11604         * tui/tui.c: Update.
11605         * typeprint.c: Update.
11606         * unittests/cli-utils-selftests.c: Update.
11607         * unittests/parse-connection-spec-selftests.c: Update.
11608         * valops.c: Update.
11609         * valprint.c: Update.
11610         * value.c: Update.
11611         * varobj.c: Update.
11612         * windows-nat.c: Update.
11613         * x86-linux-nat.c: Update.
11614         * xml-support.c: Update.
11615
11616 2019-04-08  Tom Tromey  <tom@tromey.com>
11617
11618         * xml-support.c: Use C++ exception handling.
11619         * x86-linux-nat.c: Use C++ exception handling.
11620         * windows-nat.c: Use C++ exception handling.
11621         * varobj.c: Use C++ exception handling.
11622         * value.c: Use C++ exception handling.
11623         * valprint.c: Use C++ exception handling.
11624         * valops.c: Use C++ exception handling.
11625         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11626         handling.
11627         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11628         * typeprint.c: Use C++ exception handling.
11629         * tui/tui.c: Use C++ exception handling.
11630         * tracefile-tfile.c: Use C++ exception handling.
11631         * top.c: Use C++ exception handling.
11632         * thread.c: Use C++ exception handling.
11633         * target.c: Use C++ exception handling.
11634         * symmisc.c: Use C++ exception handling.
11635         * symfile-mem.c: Use C++ exception handling.
11636         * stack.c: Use C++ exception handling.
11637         * sparc64-linux-tdep.c: Use C++ exception handling.
11638         * solib.c: Use C++ exception handling.
11639         * solib-svr4.c: Use C++ exception handling.
11640         * solib-spu.c: Use C++ exception handling.
11641         * solib-frv.c: Use C++ exception handling.
11642         * solib-dsbt.c: Use C++ exception handling.
11643         * selftest-arch.c: Use C++ exception handling.
11644         * s390-tdep.c: Use C++ exception handling.
11645         * rust-lang.c: Use C++ exception handling.
11646         * rust-exp.y: Use C++ exception handling.
11647         * rs6000-tdep.c: Use C++ exception handling.
11648         * rs6000-aix-tdep.c: Use C++ exception handling.
11649         * riscv-tdep.c: Use C++ exception handling.
11650         * remote.c: Use C++ exception handling.
11651         * remote-fileio.c: Use C++ exception handling.
11652         * record-full.c: Use C++ exception handling.
11653         * record-btrace.c: Use C++ exception handling.
11654         * python/python.c: Use C++ exception handling.
11655         * python/py-value.c: Use C++ exception handling.
11656         * python/py-utils.c: Use C++ exception handling.
11657         * python/py-unwind.c: Use C++ exception handling.
11658         * python/py-type.c: Use C++ exception handling.
11659         * python/py-symbol.c: Use C++ exception handling.
11660         * python/py-record.c: Use C++ exception handling.
11661         * python/py-record-btrace.c: Use C++ exception handling.
11662         * python/py-progspace.c: Use C++ exception handling.
11663         * python/py-prettyprint.c: Use C++ exception handling.
11664         * python/py-param.c: Use C++ exception handling.
11665         * python/py-objfile.c: Use C++ exception handling.
11666         * python/py-linetable.c: Use C++ exception handling.
11667         * python/py-lazy-string.c: Use C++ exception handling.
11668         * python/py-infthread.c: Use C++ exception handling.
11669         * python/py-inferior.c: Use C++ exception handling.
11670         * python/py-gdb-readline.c: Use C++ exception handling.
11671         * python/py-framefilter.c: Use C++ exception handling.
11672         * python/py-frame.c: Use C++ exception handling.
11673         * python/py-finishbreakpoint.c: Use C++ exception handling.
11674         * python/py-cmd.c: Use C++ exception handling.
11675         * python/py-breakpoint.c: Use C++ exception handling.
11676         * python/py-arch.c: Use C++ exception handling.
11677         * printcmd.c: Use C++ exception handling.
11678         * ppc-linux-tdep.c: Use C++ exception handling.
11679         * parse.c: Use C++ exception handling.
11680         * p-valprint.c: Use C++ exception handling.
11681         * objc-lang.c: Use C++ exception handling.
11682         * mi/mi-main.c: Use C++ exception handling.
11683         * mi/mi-interp.c: Use C++ exception handling.
11684         * mi/mi-cmd-stack.c: Use C++ exception handling.
11685         * mi/mi-cmd-break.c: Use C++ exception handling.
11686         * main.c: Use C++ exception handling.
11687         * linux-thread-db.c: Use C++ exception handling.
11688         * linux-tdep.c: Use C++ exception handling.
11689         * linux-nat.c: Use C++ exception handling.
11690         * linux-fork.c: Use C++ exception handling.
11691         * linespec.c: Use C++ exception handling.
11692         * language.c: Use C++ exception handling.
11693         * jit.c: Use C++ exception handling.
11694         * infrun.c: Use C++ exception handling.
11695         * infcmd.c: Use C++ exception handling.
11696         * infcall.c: Use C++ exception handling.
11697         * inf-loop.c: Use C++ exception handling.
11698         * i386-tdep.c: Use C++ exception handling.
11699         * i386-linux-tdep.c: Use C++ exception handling.
11700         * guile/scm-value.c: Use C++ exception handling.
11701         * guile/scm-type.c: Use C++ exception handling.
11702         * guile/scm-symtab.c: Use C++ exception handling.
11703         * guile/scm-symbol.c: Use C++ exception handling.
11704         * guile/scm-pretty-print.c: Use C++ exception handling.
11705         * guile/scm-ports.c: Use C++ exception handling.
11706         * guile/scm-param.c: Use C++ exception handling.
11707         * guile/scm-math.c: Use C++ exception handling.
11708         * guile/scm-lazy-string.c: Use C++ exception handling.
11709         * guile/scm-frame.c: Use C++ exception handling.
11710         * guile/scm-disasm.c: Use C++ exception handling.
11711         * guile/scm-cmd.c: Use C++ exception handling.
11712         * guile/scm-breakpoint.c: Use C++ exception handling.
11713         * guile/scm-block.c: Use C++ exception handling.
11714         * guile/guile-internal.h: Use C++ exception handling.
11715         * gnu-v3-abi.c: Use C++ exception handling.
11716         * gdbtypes.c: Use C++ exception handling.
11717         * frame.c: Use C++ exception handling.
11718         * frame-unwind.c: Use C++ exception handling.
11719         * fbsd-tdep.c: Use C++ exception handling.
11720         * f-valprint.c: Use C++ exception handling.
11721         * exec.c: Use C++ exception handling.
11722         * event-top.c: Use C++ exception handling.
11723         * event-loop.c: Use C++ exception handling.
11724         * eval.c: Use C++ exception handling.
11725         * dwarf2read.c: Use C++ exception handling.
11726         * dwarf2loc.c: Use C++ exception handling.
11727         * dwarf2-frame.c: Use C++ exception handling.
11728         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11729         * dwarf-index-write.c: Use C++ exception handling.
11730         * dwarf-index-cache.c: Use C++ exception handling.
11731         * dtrace-probe.c: Use C++ exception handling.
11732         * disasm-selftests.c: Use C++ exception handling.
11733         * darwin-nat.c: Use C++ exception handling.
11734         * cp-valprint.c: Use C++ exception handling.
11735         * cp-support.c: Use C++ exception handling.
11736         * cp-abi.c: Use C++ exception handling.
11737         * corelow.c: Use C++ exception handling.
11738         * completer.c: Use C++ exception handling.
11739         * compile/compile-object-run.c: Use C++ exception handling.
11740         * compile/compile-object-load.c: Use C++ exception handling.
11741         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11742         * compile/compile-c-symbols.c: Use C++ exception handling.
11743         * common/selftest.c: Use C++ exception handling.
11744         * common/new-op.c: Use C++ exception handling.
11745         * cli/cli-script.c: Use C++ exception handling.
11746         * cli/cli-interp.c: Use C++ exception handling.
11747         * cli/cli-cmds.c: Use C++ exception handling.
11748         * c-varobj.c: Use C++ exception handling.
11749         * btrace.c: Use C++ exception handling.
11750         * breakpoint.c: Use C++ exception handling.
11751         * break-catch-throw.c: Use C++ exception handling.
11752         * arch-utils.c: Use C++ exception handling.
11753         * amd64-tdep.c: Use C++ exception handling.
11754         * ada-valprint.c: Use C++ exception handling.
11755         * ada-typeprint.c: Use C++ exception handling.
11756         * ada-lang.c: Use C++ exception handling.
11757         * aarch64-tdep.c: Use C++ exception handling.
11758
11759 2019-04-08  Tom Tromey  <tom@tromey.com>
11760
11761         * xml-support.c (gdb_xml_parser::parse): Update.
11762         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11763         * value.c (show_convenience): Update.
11764         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11765         (test_parse_flags_qcs): Update.
11766         * thread.c (thr_try_catch_cmd): Update.
11767         * target.c (target_translate_tls_address): Update.
11768         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11769         (info_frame_command_core, frame_apply_command_count): Update.
11770         * rust-exp.y (rust_lex_exception_test): Update.
11771         * riscv-tdep.c (riscv_print_one_register_info): Update.
11772         * remote.c (remote_target::enable_btrace): Update.
11773         * record-btrace.c (record_btrace_enable_warn): Update.
11774         * python/py-utils.c (gdbpy_convert_exception): Update.
11775         * printcmd.c (do_one_display, print_variable_and_value): Update.
11776         * mi/mi-main.c (mi_print_exception): Update.
11777         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11778         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11779         * linux-nat.c (linux_nat_target::attach): Update.
11780         * linux-fork.c (class scoped_switch_fork_info): Update.
11781         * infrun.c (displaced_step_prepare): Update.
11782         * infcall.c (call_function_by_hand_dummy): Update.
11783         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11784         * gnu-v3-abi.c (print_one_vtable): Update.
11785         * frame.c (get_prev_frame_always): Update.
11786         * f-valprint.c (info_common_command_for_block): Update.
11787         * exec.c (try_open_exec_file): Update.
11788         * exceptions.c (print_exception, exception_print)
11789         (exception_fprintf, exception_print_same): Update.
11790         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11791         * dwarf-index-cache.c (index_cache::store)
11792         (index_cache::lookup_gdb_index): Update.
11793         * darwin-nat.c (maybe_cache_shell): Update.
11794         * cp-valprint.c (cp_print_value_fields): Update.
11795         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11796         (gcc_cplus_symbol_address): Update.
11797         * compile/compile-c-symbols.c (gcc_convert_symbol)
11798         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11799         * common/selftest.c: Update.
11800         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11801         a std::string.
11802         (exception_try_scope_entry, exception_try_scope_exit): Don't
11803         declare.
11804         (struct exception_try_scope): Remove.
11805         (TRY): Don't use exception_try_scope.
11806         (struct gdb_exception): Add constructor, operator=.
11807         <what>: New method.
11808         (struct gdb_exception_RETURN_MASK_ALL)
11809         (struct gdb_exception_RETURN_MASK_ERROR)
11810         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11811         (struct gdb_quit_bad_alloc): Update.
11812         * common/common-exceptions.c (exception_none): Change
11813         initializer.
11814         (struct catcher) <state, exception>: Initialize inline.
11815         <prev>: Remove member.
11816         (current_catcher): Remove.
11817         (catchers): New global.
11818         (exceptions_state_mc_init): Simplify.
11819         (catcher_pop): Remove.
11820         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11821         (try_scope_depth, exception_try_scope_entry)
11822         (exception_try_scope_exit): Remove.
11823         (throw_exception_sjlj): Update.
11824         (exception_messages, exception_messages_size): Remove.
11825         (throw_it): Simplify.
11826         (gdb_exception_sliced_copy): Remove.
11827         (throw_exception_cxx): Update.
11828         * cli/cli-script.c (script_from_file): Update.
11829         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11830         Update.
11831         * ada-valprint.c (ada_val_print): Update.
11832         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11833         (create_excep_cond_exprs): Update.
11834
11835 2019-04-08  Tom Tromey  <tom@tromey.com>
11836
11837         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11838         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11839         (TRY, CATCH, END_CATCH): Remove some definitions.
11840         * common/common-exceptions.c: Don't use GDB_XCPT.
11841         (catcher_list_size): Remove.
11842         (throw_exception, throw_it): Simplify.
11843
11844 2019-04-05  Tom Tromey  <tom@tromey.com>
11845
11846         Revert the header-sorting patch.
11847         * ft32-tdep.c: Revert.
11848         * frv-tdep.c: Revert.
11849         * frv-linux-tdep.c: Revert.
11850         * frame.c: Revert.
11851         * frame-unwind.c: Revert.
11852         * frame-base.c: Revert.
11853         * fork-child.c: Revert.
11854         * findvar.c: Revert.
11855         * findcmd.c: Revert.
11856         * filesystem.c: Revert.
11857         * filename-seen-cache.h: Revert.
11858         * filename-seen-cache.c: Revert.
11859         * fbsd-tdep.c: Revert.
11860         * fbsd-nat.h: Revert.
11861         * fbsd-nat.c: Revert.
11862         * f-valprint.c: Revert.
11863         * f-typeprint.c: Revert.
11864         * f-lang.c: Revert.
11865         * extension.h: Revert.
11866         * extension.c: Revert.
11867         * extension-priv.h: Revert.
11868         * expprint.c: Revert.
11869         * exec.h: Revert.
11870         * exec.c: Revert.
11871         * exceptions.c: Revert.
11872         * event-top.c: Revert.
11873         * event-loop.c: Revert.
11874         * eval.c: Revert.
11875         * elfread.c: Revert.
11876         * dwarf2read.h: Revert.
11877         * dwarf2read.c: Revert.
11878         * dwarf2loc.c: Revert.
11879         * dwarf2expr.h: Revert.
11880         * dwarf2expr.c: Revert.
11881         * dwarf2-frame.c: Revert.
11882         * dwarf2-frame-tailcall.c: Revert.
11883         * dwarf-index-write.h: Revert.
11884         * dwarf-index-write.c: Revert.
11885         * dwarf-index-common.c: Revert.
11886         * dwarf-index-cache.h: Revert.
11887         * dwarf-index-cache.c: Revert.
11888         * dummy-frame.c: Revert.
11889         * dtrace-probe.c: Revert.
11890         * disasm.h: Revert.
11891         * disasm.c: Revert.
11892         * disasm-selftests.c: Revert.
11893         * dictionary.c: Revert.
11894         * dicos-tdep.c: Revert.
11895         * demangle.c: Revert.
11896         * dcache.h: Revert.
11897         * dcache.c: Revert.
11898         * darwin-nat.h: Revert.
11899         * darwin-nat.c: Revert.
11900         * darwin-nat-info.c: Revert.
11901         * d-valprint.c: Revert.
11902         * d-namespace.c: Revert.
11903         * d-lang.c: Revert.
11904         * ctf.c: Revert.
11905         * csky-tdep.c: Revert.
11906         * csky-linux-tdep.c: Revert.
11907         * cris-tdep.c: Revert.
11908         * cris-linux-tdep.c: Revert.
11909         * cp-valprint.c: Revert.
11910         * cp-support.c: Revert.
11911         * cp-namespace.c: Revert.
11912         * cp-abi.c: Revert.
11913         * corelow.c: Revert.
11914         * corefile.c: Revert.
11915         * continuations.c: Revert.
11916         * completer.h: Revert.
11917         * completer.c: Revert.
11918         * complaints.c: Revert.
11919         * coffread.c: Revert.
11920         * coff-pe-read.c: Revert.
11921         * cli-out.h: Revert.
11922         * cli-out.c: Revert.
11923         * charset.c: Revert.
11924         * c-varobj.c: Revert.
11925         * c-valprint.c: Revert.
11926         * c-typeprint.c: Revert.
11927         * c-lang.c: Revert.
11928         * buildsym.c: Revert.
11929         * buildsym-legacy.c: Revert.
11930         * build-id.h: Revert.
11931         * build-id.c: Revert.
11932         * btrace.c: Revert.
11933         * bsd-uthread.c: Revert.
11934         * breakpoint.h: Revert.
11935         * breakpoint.c: Revert.
11936         * break-catch-throw.c: Revert.
11937         * break-catch-syscall.c: Revert.
11938         * break-catch-sig.c: Revert.
11939         * blockframe.c: Revert.
11940         * block.c: Revert.
11941         * bfin-tdep.c: Revert.
11942         * bfin-linux-tdep.c: Revert.
11943         * bfd-target.c: Revert.
11944         * bcache.c: Revert.
11945         * ax-general.c: Revert.
11946         * ax-gdb.h: Revert.
11947         * ax-gdb.c: Revert.
11948         * avr-tdep.c: Revert.
11949         * auxv.c: Revert.
11950         * auto-load.c: Revert.
11951         * arm-wince-tdep.c: Revert.
11952         * arm-tdep.c: Revert.
11953         * arm-symbian-tdep.c: Revert.
11954         * arm-pikeos-tdep.c: Revert.
11955         * arm-obsd-tdep.c: Revert.
11956         * arm-nbsd-tdep.c: Revert.
11957         * arm-nbsd-nat.c: Revert.
11958         * arm-linux-tdep.c: Revert.
11959         * arm-linux-nat.c: Revert.
11960         * arm-fbsd-tdep.c: Revert.
11961         * arm-fbsd-nat.c: Revert.
11962         * arm-bsd-tdep.c: Revert.
11963         * arch-utils.c: Revert.
11964         * arc-tdep.c: Revert.
11965         * arc-newlib-tdep.c: Revert.
11966         * annotate.h: Revert.
11967         * annotate.c: Revert.
11968         * amd64-windows-tdep.c: Revert.
11969         * amd64-windows-nat.c: Revert.
11970         * amd64-tdep.c: Revert.
11971         * amd64-sol2-tdep.c: Revert.
11972         * amd64-obsd-tdep.c: Revert.
11973         * amd64-obsd-nat.c: Revert.
11974         * amd64-nbsd-tdep.c: Revert.
11975         * amd64-nbsd-nat.c: Revert.
11976         * amd64-nat.c: Revert.
11977         * amd64-linux-tdep.c: Revert.
11978         * amd64-linux-nat.c: Revert.
11979         * amd64-fbsd-tdep.c: Revert.
11980         * amd64-fbsd-nat.c: Revert.
11981         * amd64-dicos-tdep.c: Revert.
11982         * amd64-darwin-tdep.c: Revert.
11983         * amd64-bsd-nat.c: Revert.
11984         * alpha-tdep.c: Revert.
11985         * alpha-obsd-tdep.c: Revert.
11986         * alpha-nbsd-tdep.c: Revert.
11987         * alpha-mdebug-tdep.c: Revert.
11988         * alpha-linux-tdep.c: Revert.
11989         * alpha-linux-nat.c: Revert.
11990         * alpha-bsd-tdep.c: Revert.
11991         * alpha-bsd-nat.c: Revert.
11992         * aix-thread.c: Revert.
11993         * agent.c: Revert.
11994         * addrmap.c: Revert.
11995         * ada-varobj.c: Revert.
11996         * ada-valprint.c: Revert.
11997         * ada-typeprint.c: Revert.
11998         * ada-tasks.c: Revert.
11999         * ada-lang.c: Revert.
12000         * aarch64-tdep.c: Revert.
12001         * aarch64-ravenscar-thread.c: Revert.
12002         * aarch64-newlib-tdep.c: Revert.
12003         * aarch64-linux-tdep.c: Revert.
12004         * aarch64-linux-nat.c: Revert.
12005         * aarch64-fbsd-tdep.c: Revert.
12006         * aarch64-fbsd-nat.c: Revert.
12007         * aarch32-linux-nat.c: Revert.
12008
12009 2019-04-05  Tom Tromey  <tom@tromey.com>
12010
12011         * ft32-tdep.c: Sort headers.
12012         * frv-tdep.c: Sort headers.
12013         * frv-linux-tdep.c: Sort headers.
12014         * frame.c: Sort headers.
12015         * frame-unwind.c: Sort headers.
12016         * frame-base.c: Sort headers.
12017         * fork-child.c: Sort headers.
12018         * findvar.c: Sort headers.
12019         * findcmd.c: Sort headers.
12020         * filesystem.c: Sort headers.
12021         * filename-seen-cache.h: Sort headers.
12022         * filename-seen-cache.c: Sort headers.
12023         * fbsd-tdep.c: Sort headers.
12024         * fbsd-nat.h: Sort headers.
12025         * fbsd-nat.c: Sort headers.
12026         * f-valprint.c: Sort headers.
12027         * f-typeprint.c: Sort headers.
12028         * f-lang.c: Sort headers.
12029         * extension.h: Sort headers.
12030         * extension.c: Sort headers.
12031         * extension-priv.h: Sort headers.
12032         * expprint.c: Sort headers.
12033         * exec.h: Sort headers.
12034         * exec.c: Sort headers.
12035         * exceptions.c: Sort headers.
12036         * event-top.c: Sort headers.
12037         * event-loop.c: Sort headers.
12038         * eval.c: Sort headers.
12039         * elfread.c: Sort headers.
12040         * dwarf2read.h: Sort headers.
12041         * dwarf2read.c: Sort headers.
12042         * dwarf2loc.c: Sort headers.
12043         * dwarf2expr.h: Sort headers.
12044         * dwarf2expr.c: Sort headers.
12045         * dwarf2-frame.c: Sort headers.
12046         * dwarf2-frame-tailcall.c: Sort headers.
12047         * dwarf-index-write.h: Sort headers.
12048         * dwarf-index-write.c: Sort headers.
12049         * dwarf-index-common.c: Sort headers.
12050         * dwarf-index-cache.h: Sort headers.
12051         * dwarf-index-cache.c: Sort headers.
12052         * dummy-frame.c: Sort headers.
12053         * dtrace-probe.c: Sort headers.
12054         * disasm.h: Sort headers.
12055         * disasm.c: Sort headers.
12056         * disasm-selftests.c: Sort headers.
12057         * dictionary.c: Sort headers.
12058         * dicos-tdep.c: Sort headers.
12059         * demangle.c: Sort headers.
12060         * dcache.h: Sort headers.
12061         * dcache.c: Sort headers.
12062         * darwin-nat.h: Sort headers.
12063         * darwin-nat.c: Sort headers.
12064         * darwin-nat-info.c: Sort headers.
12065         * d-valprint.c: Sort headers.
12066         * d-namespace.c: Sort headers.
12067         * d-lang.c: Sort headers.
12068         * ctf.c: Sort headers.
12069         * csky-tdep.c: Sort headers.
12070         * csky-linux-tdep.c: Sort headers.
12071         * cris-tdep.c: Sort headers.
12072         * cris-linux-tdep.c: Sort headers.
12073         * cp-valprint.c: Sort headers.
12074         * cp-support.c: Sort headers.
12075         * cp-namespace.c: Sort headers.
12076         * cp-abi.c: Sort headers.
12077         * corelow.c: Sort headers.
12078         * corefile.c: Sort headers.
12079         * continuations.c: Sort headers.
12080         * completer.h: Sort headers.
12081         * completer.c: Sort headers.
12082         * complaints.c: Sort headers.
12083         * coffread.c: Sort headers.
12084         * coff-pe-read.c: Sort headers.
12085         * cli-out.h: Sort headers.
12086         * cli-out.c: Sort headers.
12087         * charset.c: Sort headers.
12088         * c-varobj.c: Sort headers.
12089         * c-valprint.c: Sort headers.
12090         * c-typeprint.c: Sort headers.
12091         * c-lang.c: Sort headers.
12092         * buildsym.c: Sort headers.
12093         * buildsym-legacy.c: Sort headers.
12094         * build-id.h: Sort headers.
12095         * build-id.c: Sort headers.
12096         * btrace.c: Sort headers.
12097         * bsd-uthread.c: Sort headers.
12098         * breakpoint.h: Sort headers.
12099         * breakpoint.c: Sort headers.
12100         * break-catch-throw.c: Sort headers.
12101         * break-catch-syscall.c: Sort headers.
12102         * break-catch-sig.c: Sort headers.
12103         * blockframe.c: Sort headers.
12104         * block.c: Sort headers.
12105         * bfin-tdep.c: Sort headers.
12106         * bfin-linux-tdep.c: Sort headers.
12107         * bfd-target.c: Sort headers.
12108         * bcache.c: Sort headers.
12109         * ax-general.c: Sort headers.
12110         * ax-gdb.h: Sort headers.
12111         * ax-gdb.c: Sort headers.
12112         * avr-tdep.c: Sort headers.
12113         * auxv.c: Sort headers.
12114         * auto-load.c: Sort headers.
12115         * arm-wince-tdep.c: Sort headers.
12116         * arm-tdep.c: Sort headers.
12117         * arm-symbian-tdep.c: Sort headers.
12118         * arm-pikeos-tdep.c: Sort headers.
12119         * arm-obsd-tdep.c: Sort headers.
12120         * arm-nbsd-tdep.c: Sort headers.
12121         * arm-nbsd-nat.c: Sort headers.
12122         * arm-linux-tdep.c: Sort headers.
12123         * arm-linux-nat.c: Sort headers.
12124         * arm-fbsd-tdep.c: Sort headers.
12125         * arm-fbsd-nat.c: Sort headers.
12126         * arm-bsd-tdep.c: Sort headers.
12127         * arch-utils.c: Sort headers.
12128         * arc-tdep.c: Sort headers.
12129         * arc-newlib-tdep.c: Sort headers.
12130         * annotate.h: Sort headers.
12131         * annotate.c: Sort headers.
12132         * amd64-windows-tdep.c: Sort headers.
12133         * amd64-windows-nat.c: Sort headers.
12134         * amd64-tdep.c: Sort headers.
12135         * amd64-sol2-tdep.c: Sort headers.
12136         * amd64-obsd-tdep.c: Sort headers.
12137         * amd64-obsd-nat.c: Sort headers.
12138         * amd64-nbsd-tdep.c: Sort headers.
12139         * amd64-nbsd-nat.c: Sort headers.
12140         * amd64-nat.c: Sort headers.
12141         * amd64-linux-tdep.c: Sort headers.
12142         * amd64-linux-nat.c: Sort headers.
12143         * amd64-fbsd-tdep.c: Sort headers.
12144         * amd64-fbsd-nat.c: Sort headers.
12145         * amd64-dicos-tdep.c: Sort headers.
12146         * amd64-darwin-tdep.c: Sort headers.
12147         * amd64-bsd-nat.c: Sort headers.
12148         * alpha-tdep.c: Sort headers.
12149         * alpha-obsd-tdep.c: Sort headers.
12150         * alpha-nbsd-tdep.c: Sort headers.
12151         * alpha-mdebug-tdep.c: Sort headers.
12152         * alpha-linux-tdep.c: Sort headers.
12153         * alpha-linux-nat.c: Sort headers.
12154         * alpha-bsd-tdep.c: Sort headers.
12155         * alpha-bsd-nat.c: Sort headers.
12156         * aix-thread.c: Sort headers.
12157         * agent.c: Sort headers.
12158         * addrmap.c: Sort headers.
12159         * ada-varobj.c: Sort headers.
12160         * ada-valprint.c: Sort headers.
12161         * ada-typeprint.c: Sort headers.
12162         * ada-tasks.c: Sort headers.
12163         * ada-lang.c: Sort headers.
12164         * aarch64-tdep.c: Sort headers.
12165         * aarch64-ravenscar-thread.c: Sort headers.
12166         * aarch64-newlib-tdep.c: Sort headers.
12167         * aarch64-linux-tdep.c: Sort headers.
12168         * aarch64-linux-nat.c: Sort headers.
12169         * aarch64-fbsd-tdep.c: Sort headers.
12170         * aarch64-fbsd-nat.c: Sort headers.
12171         * aarch32-linux-nat.c: Sort headers.
12172
12173 2019-04-04  Tom Tromey  <tom@tromey.com>
12174
12175         * varobj.c (varobj_create): Update.
12176         * rust-exp.y (struct rust_parser) <update_innermost_block,
12177         lookup_symbol>: New methods.
12178         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12179         Rename.
12180         (rust_parser::rust_lookup_type)
12181         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12182         * printcmd.c (display_command, do_one_display): Update.
12183         * parser-defs.h (struct parser_state) <parser_state>: Add
12184         "tracker" parameter.
12185         (block_tracker): New member.
12186         (class innermost_block_tracker) <innermost_block_tracker>: Add
12187         "types" parameter.
12188         <reset>: Remove method.
12189         (innermost_block): Don't declare.
12190         (null_post_parser): Update.
12191         * parse.c (innermost_block): Remove global.
12192         (write_dollar_variable): Update.
12193         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12194         Remove "tracker_types" parameter.
12195         (parse_expression): Add "tracker" parameter.
12196         (parse_expression_for_completion): Update.
12197         (null_post_parser): Add "tracker" parameter.
12198         * p-exp.y: Update rules.
12199         * m2-exp.y: Update rules.
12200         * language.h (struct language_defn) <la_post_parser>: Add
12201         "tracker" parameter.
12202         * go-exp.y: Update rules.
12203         * f-exp.y: Update rules.
12204         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12205         parameter.
12206         * d-exp.y: Update rules.
12207         * c-exp.y: Update rules.
12208         * breakpoint.c (set_breakpoint_condition): Create an
12209         innermost_block_tracker.
12210         (watch_command_1): Likewise.
12211         * ada-lang.c (resolve): Add "tracker" parameter.
12212         (resolve_subexp): Likewise.
12213         * ada-exp.y (write_var_from_sym): Update.
12214
12215 2019-04-04  Tom Tromey  <tom@tromey.com>
12216
12217         * type-stack.h: New file.
12218         * type-stack.c: New file.
12219         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12220         type-stack.h.
12221         (insert_into_type_stack, insert_type, push_type, push_type_int)
12222         (insert_type_address_space, pop_type, pop_type_int)
12223         (pop_typelist, pop_type_stack, append_type_stack)
12224         (push_type_stack, get_type_stack, push_typelist)
12225         (follow_type_instance_flags, follow_types): Don't declare.
12226         * parse.c (type_stack): Remove global.
12227         (parse_exp_in_context): Update.
12228         (insert_into_type_stack, insert_type, push_type, push_type_int)
12229         (insert_type_address_space, pop_type, pop_type_int)
12230         (pop_typelist, pop_type_stack, append_type_stack)
12231         (push_type_stack, get_type_stack, push_typelist)
12232         (follow_type_instance_flags, follow_types): Remove (moved to
12233         type-stack.c).
12234         * f-exp.y (type_stack): New global.
12235         Update rules.
12236         (push_kind_type, f_parse): Update.
12237         * d-exp.y (type_stack): New global.
12238         Update rules.
12239         (d_parse): Update.
12240         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12241         Update rules.
12242         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12243         (HFILES_NO_SRCDIR): Add type-stack.h.
12244
12245 2019-04-04  Tom Tromey  <tom@tromey.com>
12246
12247         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12248         (rust_parser::convert_ast_to_expression, rust_parse)
12249         (rust_lex_test_completion, rust_lex_tests): Update.
12250         * parser-defs.h (struct expr_completion_state): New.
12251         (struct parser_state) <parser_state>: Add completion parameter.
12252         <mark_struct_expression, mark_completion_tag>: New methods.
12253         <parse_completion, m_completion_state>: New members.
12254         (prefixify_expression, null_post_parser): Update.
12255         (mark_struct_expression, mark_completion_tag): Don't declare.
12256         * parse.c (parse_completion, expout_last_struct)
12257         (expout_tag_completion_type, expout_completion_name): Remove
12258         globals.
12259         (parser_state::mark_struct_expression)
12260         (parser_state::mark_completion_tag): Now methods.
12261         (prefixify_expression): Add last_struct parameter.
12262         (prefixify_subexp): Likewise.
12263         (parse_exp_1): Update.
12264         (parse_exp_in_context): Add cstate parameter.  Update.
12265         (parse_expression_for_completion): Create an
12266         expr_completion_state.
12267         (null_post_parser): Add "completion" parameter.
12268         * p-exp.y: Update rules.
12269         (yylex): Update.
12270         * language.h (struct language_defn) <la_post_parser>: Add
12271         "completing" parameter.
12272         * go-exp.y: Update rules.
12273         (lex_one_token): Update.
12274         * expression.h (parse_completion): Don't declare.
12275         * d-exp.y: Update rules.
12276         (lex_one_token): Update rules.
12277         * c-exp.y: Update rules.
12278         (lex_one_token): Update.
12279         * ada-lang.c (resolve): Add "parse_completion" parameter.
12280         (resolve_subexp): Likewise.
12281         (ada_resolve_function): Likewise.
12282
12283 2019-04-04  Tom Tromey  <tom@tromey.com>
12284
12285         * parser-defs.h (struct parser_state) <start_arglist,
12286         end_arglist>: New methods.
12287         <arglist_len, m_funcall_chain>: New members.
12288         (arglist_len, start_arglist, end_arglist): Don't declare.
12289         * parse.c (arglist_len, funcall_chain): Remove global.
12290         (start_arglist, end_arglist): Remove functions.
12291         (parse_exp_in_context): Update.
12292         * p-exp.y: Update rules.
12293         * m2-exp.y: Update rules.
12294         * go-exp.y: Update rules.
12295         * f-exp.y: Update rules.
12296         * d-exp.y: Update rules.
12297         * c-exp.y: Update rules.
12298
12299 2019-04-04  Tom Tromey  <tom@tromey.com>
12300
12301         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12302         lex_operator, push_back>: New methods.
12303         Update all rules.
12304         (rust_parser::lex_hex, lex_escape): Rename and update.
12305         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12306         (rust_parser::lex_operator): Rename and update.
12307         (rust_parser::lex_number, rustyylex, rustyyerror)
12308         (rust_lex_test_init, rust_lex_test_sequence)
12309         (rust_lex_test_push_back, rust_lex_tests): Update.
12310         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12311         parameter.
12312         <lexptr, prev_lexptr>: New members.
12313         (lexptr, prev_lexptr): Don't declare.
12314         * parse.c (lexptr, prev_lexptr): Remove globals.
12315         (parse_exp_in_context): Update.
12316         * p-exp.y (yylex, yyerror): Update.
12317         * m2-exp.y (parse_number, yylex, yyerror): Update.
12318         * go-exp.y (lex_one_token, yyerror): Update.
12319         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12320         * d-exp.y (lex_one_token, yyerror): Update.
12321         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12322         (lex_one_token, yyerror): Update.
12323         * ada-lex.l (YY_INPUT): Update.
12324         (rewind_to_char): Update.
12325         * ada-exp.y (yyerror): Update.
12326
12327 2019-04-04  Tom Tromey  <tom@tromey.com>
12328
12329         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12330         * parser-defs.h (struct parser_state) <parser_state>: Add new
12331         parameter.
12332         <comma_terminates>: New member.
12333         (comma_terminates): Don't declare global.
12334         * parse.c (comma_terminates): Remove global.
12335         (parse_exp_in_context): Update.
12336         * p-exp.y (yylex): Update.
12337         * m2-exp.y (yylex): Update.
12338         * go-exp.y (lex_one_token): Update.
12339         * f-exp.y (yylex): Update.
12340         * d-exp.y (lex_one_token): Update.
12341         * c-exp.y (lex_one_token): Update.
12342         * ada-lex.l: Update.
12343
12344 2019-04-04  Tom Tromey  <tom@tromey.com>
12345
12346         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12347         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12348         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12349         * parser-defs.h (paren_depth): Don't declare.
12350         * parse.c (paren_depth): Remove global.
12351         (parse_exp_in_context): Update.
12352         * p-exp.y (paren_depth): New global.
12353         (pascal_parse): Initialize it.
12354         * m2-exp.y (paren_depth): New global.
12355         (m2_parse): Initialize it.
12356         * go-exp.y (paren_depth): New global.
12357         (go_parse): Initialize it.
12358         * f-exp.y (paren_depth): New global.
12359         (f_parse): Initialize it.
12360         * d-exp.y (paren_depth): New global.
12361         (d_parse): Initialize it.
12362         * c-exp.y (paren_depth): New global.
12363         (c_parse): Initialize it.
12364         * ada-lex.l (paren_depth): New global.
12365         (lexer_init): Initialize it.
12366
12367 2019-04-04  Tom Tromey  <tom@tromey.com>
12368
12369         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12370         (rust_parser::convert_ast_to_type)
12371         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12372         * parser-defs.h (struct parser_state) <parser_state>: Add
12373         parameters.  Initialize new members.
12374         <expression_context_block, expression_context_pc>: New members.
12375         * parse.c (expression_context_block, expression_context_pc):
12376         Remove globals.
12377         (parse_exp_in_context): Update.
12378         * p-exp.y: Update all rules.
12379         (yylex): Update.
12380         * m2-exp.y: Update all rules.
12381         (yylex): Update.
12382         * go-exp.y (yylex): Update.
12383         * f-exp.y (yylex): Update.
12384         * d-exp.y: Update all rules.
12385         (yylex): Update.
12386         * c-exp.y: Update all rules.
12387         (lex_one_token, classify_name, yylex, c_parse): Update.
12388         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12389
12390 2019-04-04  Tom Tromey  <tom@tromey.com>
12391
12392         * gdbarch.h, gdbarch.c: Rebuild.
12393         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12394         * stap-probe.h:
12395         (struct stap_parse_info): Replace "parser_state" with
12396         "expr_builder".
12397         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12398         (parser_state): New class.
12399         * parse.c (expr_builder): Rename.
12400         (expr_builder::release): Rename.
12401         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12402         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12403         (write_exp_elt_longcst, write_exp_elt_floatcst)
12404         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12405         (write_exp_string_vector, write_exp_bitstring)
12406         (write_exp_msymbol, mark_struct_expression)
12407         (write_dollar_variable)
12408         (insert_type_address_space, increase_expout_size): Replace
12409         "parser_state" with "expr_builder".
12410         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12411         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12412         "parser_state" with "expr_builder".
12413
12414 2019-04-04  Tom Tromey  <tom@tromey.com>
12415
12416         * rust-exp.y: Replace "parse_language" with method call.
12417         * p-exp.y:
12418         (yylex): Replace "parse_language" with method call.
12419         * m2-exp.y:
12420         (yylex): Replace "parse_language" with method call.
12421         * go-exp.y (classify_name): Replace "parse_language" with method
12422         call.
12423         * f-exp.y (yylex): Replace "parse_language" with method call.
12424         * d-exp.y (lex_one_token): Replace "parse_language" with method
12425         call.
12426         * c-exp.y:
12427         (lex_one_token, classify_name, yylex): Replace "parse_language"
12428         with method call.
12429         * ada-exp.y (find_primitive_type, type_char)
12430         (type_system_address): Replace "parse_language" with method call.
12431
12432 2019-04-04  Tom Tromey  <tom@tromey.com>
12433
12434         * rust-exp.y: Replace "parse_gdbarch" with method call.
12435         * parse.c (write_dollar_variable, insert_type_address_space):
12436         Replace "parse_gdbarch" with method call.
12437         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12438         call.
12439         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12440         call.
12441         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12442         "parse_gdbarch" with method call.
12443         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12444         with method call.
12445         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12446         "parse_gdbarch" with method call.
12447         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12448         "parse_gdbarch" with method call.
12449         * c-exp.y (parse_type, parse_number, classify_name): Replace
12450         "parse_gdbarch" with method call.
12451         * ada-lex.l: Replace "parse_gdbarch" with method call.
12452         * ada-exp.y (parse_type, find_primitive_type, type_char)
12453         (type_system_address): Replace "parse_gdbarch" with method call.
12454
12455 2019-04-04  Tom Tromey  <tom@tromey.com>
12456
12457         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12458         * stap-probe.c (stap_parse_argument): Update.
12459         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12460         initial_size parameter.
12461         * rust-exp.y (rust_lex_tests): Update.
12462         * parse.c (parser_state): Update.
12463         (parse_exp_in_context): Update.
12464         * parser-defs.h (struct parser_state) <parser_state>: Remove
12465         "initial_size" parameter.
12466
12467 2019-04-04  Tom Tromey  <tom@tromey.com>
12468
12469         * parser-defs.h (increase_expout_size): Don't declare.
12470         * parse.c (increase_expout_size): Now static.
12471
12472 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12473
12474         * gnu-nat.c (gnu_nat_target::wait): Fix
12475         target_waitstatus_to_string call.
12476
12477 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12478
12479         * eval.c (evaluate_subexp_standard): Handle internal functions
12480         during Fortran function call handling.
12481
12482 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12483
12484         * NEWS: Mention new internal functions.
12485         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12486         (read_base_type): Use dwarf2_init_complex_target_type.
12487         * value.c (creal_internal_fn): New function.
12488         (cimag_internal_fn): New function.
12489         (_initialize_values): Register new internal functions.
12490
12491 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12492
12493         * infrun.c (stop_all_threads): If debug_infrun, always
12494         trace the wait status after wait_one, using
12495         target_waitstatus_to_string and target_pid_to_str.
12496         (handle_inferior_event): Replace various trace of
12497         wait status kind by a single trace.
12498         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12499         wait status kind image by target_waitstatus_to_string.
12500         * target/waitstatus.c (target_waitstatus_to_string): Fix
12501         obsolete comment.
12502
12503 2019-04-01  Tom Tromey  <tromey@adacore.com>
12504
12505         PR symtab/23331:
12506         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12507
12508 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12509             Pedro Alves  <palves@redhat.com>
12510
12511         * top.c (quit_force): Call 'finalize_values'.
12512         * value.c (finalize_values): New function.
12513         * value.h (finalize_values): Declare.
12514
12515 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12516
12517         * NEWS: Announce $_gdb_major and $_gdb_minor.
12518
12519         * top.c (init_gdb_version_vars): New function.
12520         (gdb_init): Call init_gdb_version_vars.
12521
12522 2019-03-29  Tom Tromey  <tromey@adacore.com>
12523
12524         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12525         help text.  Remove dead code.
12526
12527 2019-03-29  Keith Seitz  <keiths@redhat.com>
12528
12529         From Siddhesh Poyarekar:
12530         * f-lang.h (f77_get_upperbound): Return LONGEST.
12531         (f77_get_lowerbound): Likewise.
12532         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12533         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12534         print them.
12535         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12536         plongest to format print it.
12537         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12538         (f77_get_upperbound): Likewise.
12539         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12540         LOWER_BOUND to LONGEST.
12541         (f77_create_arrayprint_offset_tbl): Likewise.
12542
12543 2019-03-29  Keith Seitz  <keiths@redhat.com>
12544
12545         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12546         %s/pulongest for TYPE_LENGTH instead of %d in format
12547         strings.
12548         * ada-typerint.c (ada_print_type): Likewise.
12549         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12550         * compile/compile-c-support.c (generate_register_struct): Likewise.
12551         * gdbtypes.c (recursive_dump_type): Likewise.
12552         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12553         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12554         instead of %d in format strings.
12555         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12556         to std::min to ULONGEST.
12557         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12558         instead of %d in format strings.
12559         * tracepoint.c (info_scope_command): Likewise.
12560         * typeprint.c (print_offset_data::update)
12561         (print_offset_data::finish): Likewise.
12562         * xtensa-tdep.c (xtensa_store_return_value)
12563         (xtensa_push_dummy_call): Likewise.
12564
12565 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12566
12567         * windows-nat.c (display_selector): Fixed format specifications
12568         for 64-bit Cygwin.
12569
12570 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12571
12572         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12573
12574 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12575
12576         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12577         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12578         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12579         (nios2_linux_init_abi): Install it.
12580
12581 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12582
12583         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12584
12585 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12586
12587         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12588
12589 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12590             Tom Tromey  <tromey@adacore.com>
12591
12592         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12593
12594 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12595
12596         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12597         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12598         method to compute the bounds of range types. Also print "[evaluated]"
12599         if the bounds' values come from a dynamic evaluation.
12600
12601 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12602
12603         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12604         whitespace when pretty printing is on.
12605
12606 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12607
12608         * ppc-linux-nat.c: Add include.
12609
12610 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12611
12612         * NEWS: Mention AArch64 Pointer Authentication.
12613
12614 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12615
12616         * arm-linux-nat.c: Add include.
12617
12618 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12619
12620         * source-cache.c (source_cache::get_source_lines): Re-read
12621         fullname after calling open_source_file.
12622
12623 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12624
12625         * NEWS: Mention TLS support for FreeBSD.
12626
12627 2019-03-25  Tom Tromey  <tromey@adacore.com>
12628
12629         * minsyms.c (BUNCH_SIZE): Update comment.
12630         (~minimal_symbol_reader): Remove old comment.
12631         (compact_minimal_symbols): Update comment.
12632         (minimal_symbol_reader::install): Remove old comment.  Update
12633         other comments.
12634
12635 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12636
12637         * s390-linux-nat.c: Add include.
12638
12639 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12640
12641         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12642         Call linux_get_hwcap.
12643         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12644         Likewise.
12645         (aarch64_linux_get_hwcap): Remove function.
12646         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12647         declaration.
12648         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12649         linux_get_hwcap.
12650         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12651         * linux-tdep.c (linux_get_hwcap): Add function.
12652         (linux_get_hwcap2): Likewise.
12653         * linux-tdep.h (linux_get_hwcap): Add declaration.
12654         (linux_get_hwcap2): Likewise.
12655         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12656         (ppc_linux_get_hwcap2): Likewise.
12657         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12658         linux_get_hwcap.
12659         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12660         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12661         (ppc_linux_nat_target::read_description): Likewise.
12662         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12663         * s390-linux-nat.c: Likewise.
12664         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12665
12666 2019-03-24  Tom Tromey  <tom@tromey.com>
12667
12668         * ada-lang.c (standard_lookup): Simplify initialization.
12669         (ada_lookup_symbol_nonlocal): Simplify return.
12670         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12671         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12672         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12673         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12674         initialization.
12675         * solib.c (solib_global_lookup): Simplify.
12676         * symtab.c (null_block_symbol): Remove.
12677         (symbol_cache_lookup): Simplify returns.
12678         (lookup_language_this): Simplify returns.
12679         (lookup_symbol_aux): Simplify return.
12680         (lookup_local_symbol): Simplify returns.
12681         (lookup_global_symbol_from_objfile): Simplify return.
12682         (lookup_symbol_in_objfile_symtabs)
12683         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12684         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12685         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12686         * cp-namespace.c (cp_lookup_bare_symbol)
12687         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12688         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12689         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12690         (cp_lookup_symbol_via_imports): Simplify initialization.
12691         (find_symbol_in_baseclass): Likewise.
12692         * symtab.h (null_block_symbol): Remove.
12693         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12694         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12695         (d_lookup_symbol_module): Likewise.
12696         (find_symbol_in_baseclass): Simplify initialization.
12697
12698 2019-03-24  Tom Tromey  <tom@tromey.com>
12699
12700         * expression.h: Don't include symtab.h.
12701         (struct block): Forward declare.
12702
12703 2019-03-24  Tom Tromey  <tom@tromey.com>
12704
12705         * c-exp.y (typebase): Remove casts.
12706         * gdbtypes.c (lookup_unsigned_typename, )
12707         (lookup_signed_typename): Remove cast.
12708         * eval.c (parse_to_comma_and_eval): Remove cast.
12709         * parse.c (write_dollar_variable): Remove cast.
12710         * block.h (struct block) <superblock>: Now const.
12711         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12712         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12713         (map_block): Make "block" const.
12714         * symfile.h (struct quick_symbol_functions)
12715         <map_matching_symbols>: Constify block argument to "callback".
12716         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12717         const.
12718         (find_pc_sect_compunit_symtab): Make "b" const.
12719         (find_symbol_at_address): Likewise.
12720         (search_symbols): Likewise.
12721         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12722         (dw2_debug_names_lookup_symbol): Likewise.
12723         (dw2_map_matching_symbols): Update.
12724         * p-valprint.c (pascal_val_print): Remove "block".
12725         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12726         (aux_add_nonlocal_symbols): Make "block" const.
12727         (resolve_subexp): Remove cast.
12728         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12729         const.
12730         (iterate_over_file_blocks): Likewise.
12731         * f-exp.y (%union) <bval>: Remove.
12732         * coffread.c (patch_opaque_types): Make "b" const.
12733         * spu-tdep.c (spu_catch_start): Make "block" const.
12734         * c-valprint.c (print_unpacked_pointer): Remove "block".
12735         * symmisc.c (dump_symtab_1): Make "b" const.
12736         (block_depth): Make "block" const.
12737         * d-exp.y (%union) <bval>: Remove.
12738         * cp-support.h (cp_lookup_rtti_type): Update.
12739         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12740         * psymtab.c (psym_lookup_symbol): Make "block" const.
12741         (maintenance_check_psymtabs): Make "b" const.
12742         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12743         (enumerate_locals, enumerate_args): Update.
12744         * python/py-symtab.c (stpy_global_block): Make "block" const.
12745         (stpy_static_block): Likewise.
12746         * inline-frame.c (block_starting_point_at): Make "new_block"
12747         const.
12748         * block.c (find_block_in_blockvector): Make return type const.
12749         (blockvector_for_pc_sect): Make "b" const.
12750         (find_block_in_blockvector): Make "b" const.
12751
12752 2019-03-23  Tom Tromey  <tom@tromey.com>
12753
12754         * varobj.c (varobj_create): Update.
12755         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12756         * printcmd.c (display_command, do_one_display): Don't reset
12757         innermost_block.
12758         * parser-defs.h (enum innermost_block_tracker_type): Move to
12759         expression.h.
12760         (innermost_block): Update comment.
12761         * parse.c (parse_exp_1): Add tracker_types parameter.
12762         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12763         tracker_types parameter.  Reset innermost_block.
12764         (parse_exp_in_context): Remove.
12765         (parse_expression_for_completion): Update.
12766         * objfiles.c (~objfile): Don't reset expression_context_block or
12767         innermost_block.
12768         * expression.h (enum innermost_block_tracker_type): Move from
12769         parser-defs.h.
12770         (parse_exp_1): Add tracker_types parameter.
12771         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12772         reset innermost_block.
12773
12774 2019-03-23  Tom Tromey  <tom@tromey.com>
12775
12776         * objfiles.h: Include bcache.h.
12777
12778 2019-03-23  Tom Tromey  <tom@tromey.com>
12779
12780         * linespec.c (get_current_search_block): Use
12781         scoped_restore_current_language.
12782         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12783
12784 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12785             Jiong Wang  <jiong.wang@arm.com>
12786
12787         * aarch64-linux-tdep.c
12788         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12789         section.
12790         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12791
12792 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12793             Jiong Wang  <jiong.wang@arm.com>
12794
12795         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12796         instructions.
12797         (aarch64_analyze_prologue_test): Add PACIASP test.
12798         (aarch64_prologue_prev_register): Unmask PC value.
12799
12800 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12801             Jiong Wang  <jiong.wang@arm.com>
12802
12803         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12804         (aarch64_dwarf2_prev_register): Unmask PC value.
12805         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12806         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12807         DW_CFA_AARCH64_negate_ra_state.
12808         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12809
12810 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12811             Jiong Wang  <jiong.wang@arm.com>
12812
12813         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12814         registers.
12815         (aarch64_pseudo_register_name): Likewise.
12816         (aarch64_pseudo_register_type): Likewise.
12817         (aarch64_pseudo_register_reggroup_p): Likewise.
12818         (aarch64_gdbarch_init): Add pauth registers.
12819         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12820         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12821         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12822         (struct gdbarch_tdep): Add regnum for ra_state.
12823
12824 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12825             Jiong Wang  <jiong.wang@arm.com>
12826
12827         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12828
12829 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12830             Jiong Wang  <jiong.wang@arm.com>
12831
12832         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12833         function.
12834         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12835         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12836         (aarch64_gdbarch_init): Add puth registers.
12837         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12838         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12839         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12840
12841 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12842             Jiong Wang  <jiong.wang@arm.com>
12843
12844         * aarch64-linux-nat.c
12845         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12846         * aarch64-linux-tdep.c
12847         (aarch64_linux_core_read_description): Likewise.
12848         (aarch64_linux_get_hwcap): New function.
12849         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12850         (aarch64_linux_get_hwcap): New declaration.
12851
12852 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12853             Jiong Wang  <jiong.wang@arm.com>
12854
12855         * aarch64-linux-nat.c
12856         (aarch64_linux_nat_target::read_description): Add pauth param.
12857         * aarch64-linux-tdep.c
12858         (aarch64_linux_core_read_description): Likewise.
12859         * aarch64-tdep.c (struct target_desc): Add in pauth.
12860         (aarch64_read_description): Add pauth param.
12861         (aarch64_gdbarch_init): Likewise.
12862         * aarch64-tdep.h (aarch64_read_description): Likewise.
12863         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12864         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12865         * features/Makefile: Add new files.
12866         * features/aarch64-pauth.c: New file.
12867         * features/aarch64-pauth.xml: New file.
12868
12869 2019-03-20  Tom Tromey  <tromey@adacore.com>
12870
12871         * infrun.c (handle_inferior_event): Rename from
12872         handle_inferior_event_1.  Create a scoped_value_mark.
12873         (handle_inferior_event): Remove.
12874
12875 2019-03-19  Tom Tromey  <tromey@adacore.com>
12876
12877         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12878         * infrun.h (print_stop_event): Add "displays" parameter.
12879         * infrun.c (print_stop_event): Add "displays" parameter.
12880
12881 2019-03-19  Pedro Alves  <palves@redhat.com>
12882
12883         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12884         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12885         to -1.  Fix TABs vs spaces.
12886         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12887         * tui/tui-out.h (tui_ui_out) Add intro comments.
12888         <m_line, m_start_of_line>: In-class initialize, and add describing
12889         comment.
12890
12891 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12892
12893         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12894         variable names.
12895         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12896
12897 2019-03-18  Pedro Alves  <palves@redhat.com>
12898             Eli Zaretskii <eliz@gnu.org>
12899
12900         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12901         m_line and m_start_of_line.
12902
12903 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12904
12905         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12906         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12907         it returns a newline.  This fixes a regression in TU mode, whereby
12908         the next line is output on the same screen line as the user input.
12909
12910 2019-03-18  Tom Tromey  <tromey@adacore.com>
12911
12912         * minsyms.c (minimal_symbol_reader::install): Remove call to
12913         obstack_blank.
12914
12915 2019-03-18  Pedro Alves  <palves@redhat.com>
12916
12917         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12918         New globals.
12919         (apply_style): New, factored out from ...
12920         (apply_ansi_escape): ... this.  Handle reverse video mode.
12921         (tui_set_reverse_mode): New function.
12922         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12923         * tui/tui-winsource.c (tui_show_source_line): Use
12924         tui_set_reverse_mode instead of setting A_STANDOUT.
12925         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12926         New setter methods.
12927
12928 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12929
12930         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12931         Handle tabs.
12932
12933 2019-03-18  Tom Tromey  <tromey@adacore.com>
12934
12935         * ada-lang.c (empty_array): Add "high" parameter.
12936         (ada_evaluate_subexp): Update.
12937
12938 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12939
12940         * unittests/string_view-selftests.c: Define
12941         _initialize_string_view_selftests unconditionally.
12942
12943 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12944
12945         PR gdb/24350
12946         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12947
12948 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12949
12950         PR gdb/24351
12951         * windows-nat.c (display_selector): Fix format specifiers.
12952
12953 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12954
12955         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12956         tui_refill_source_window instead of tui_refresh_win, to update the
12957         current execution line.  This fixes redisplay of the current line
12958         when stepping through the code with "next" or "step".
12959
12960 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12961
12962         * source-cache.c (source_cache::get_source_lines): Call
12963         find_source_lines to initialize s->nlines.  This fixes vertical
12964         scrolling of TUI source window when the DOWN arrow is pressed.
12965
12966 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12967
12968         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12969         linux-thread-db.c (_initialize_thread_db): Likewise.
12970
12971 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12972
12973         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12974         wclrtoeol in tui_show_source_line".  This reverts changes made in
12975         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12976
12977 2019-03-15  Tom Tromey  <tom@tromey.com>
12978
12979         * symtab.h (struct minimal_symbol): Derive from
12980         general_symbol_info.
12981         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12982         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12983         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12984         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12985         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12986         (MSYMBOL_SEARCH_NAME): Update.
12987         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12988         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12989         * minsyms.c (minimal_symbol_reader::record_full): Update.
12990
12991 2019-03-15  Tom Tromey  <tom@tromey.com>
12992
12993         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12994
12995 2019-03-15  Tom Tromey  <tom@tromey.com>
12996
12997         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12998         unique_xmalloc_ptr.
12999         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13000         Update.
13001         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13002         (build_minimal_symbol_hash_tables)
13003         (minimal_symbol_reader::install): Update.
13004
13005 2019-03-15  Tom Tromey  <tom@tromey.com>
13006
13007         * symtab.c (create_demangled_names_hash): Update.
13008         (symbol_set_names): Update.
13009         * objfiles.h (struct objfile_per_bfd_storage)
13010         <demangled_names_hash>: Now an htab_up.
13011         * objfiles.c (objfile_per_bfd_storage): Simplify.
13012
13013 2019-03-15  Tom Tromey  <tom@tromey.com>
13014
13015         * objfiles.h (struct objfile_per_bfd_storage): Declare
13016         destructor.
13017         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13018         New.
13019         (get_objfile_bfd_data): Use new.  Don't initialize
13020         language_of_main.
13021         (free_objfile_per_bfd_storage): Remove.
13022         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13023
13024 2019-03-15  Tom Tromey  <tom@tromey.com>
13025
13026         * symfile.c (reread_symbols): Update.
13027         * objfiles.c (objfile::objfile): Update.
13028         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13029         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13030         comment.
13031         (minimal_symbol_reader::install): Update.
13032         (terminate_minimal_symbol_table): Remove.
13033         * jit.c (jit_object_close_impl): Update.
13034
13035 2019-03-15  Tom Tromey  <tom@tromey.com>
13036
13037         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13038         initializations.
13039
13040 2019-03-15  Tom Tromey  <tom@tromey.com>
13041
13042         * objfiles.h (struct objfile_per_bfd_storage)
13043         <demangled_hash_languages>: Now a bitset.
13044         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13045         (lookup_minimal_symbol): Update.
13046
13047 2019-03-15  Tom Tromey  <tom@tromey.com>
13048
13049         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13050         Don't return the symbol.
13051         * coffread.c (record_minimal_symbol): Use record_full.
13052
13053 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13054
13055         The MS-Windows port of ncurses fails to switch to a color pair if
13056         one or both of the colors are the implicit default colors.  This
13057         change records the default colors when TUI is initialized, and
13058         then specifies them explicitly when a color pair uses the default
13059         colors.  This allows color styling in TUI mode on MS-Windows.
13060
13061         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13062         ncurses_norm_attr.
13063         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13064         colors in ncurses_norm_attr.
13065         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13066         "none", replace it with the default color recorded in
13067         ncurses_norm_attr.
13068
13069 2019-03-14  Tom Tromey  <tromey@adacore.com>
13070
13071         * source-cache.h (class source_cache) <get_source_lines>: Return
13072         std::string.
13073         * source-cache.c (source_cache::extract_lines): Handle case where
13074         first_pos==npos.  Return std::string.
13075         (source_cache::get_source_lines): Update.
13076
13077 2019-03-14  Tom Tromey  <tromey@adacore.com>
13078
13079         * NEWS: Add item for "style sources" commands.
13080         * source-cache.c (source_cache::get_source_lines): Check
13081         source_styling.
13082         * cli/cli-style.c (source_styling): New global.
13083         (_initialize_cli_style): Add "style sources" commands.
13084         (show_style_sources): New function.
13085         * cli/cli-style.h (source_styling): Declare.
13086
13087 2019-03-14  Pedro Alves  <palves@redhat.com>
13088             Tom Tromey  <tromey@adacore.com>
13089
13090         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13091         * tui/tui-winsource.c (tui_refill_source_window): New function,
13092         from...
13093         (tui_horizontal_source_scroll): ... here.  Move some logic.
13094         * cli/cli-style.c (set_style_enabled): Notify new observable.
13095         * tui/tui-hooks.c (tui_redisplay_source): New function.
13096         (tui_attach_detach_observers): Attach or detach
13097         tui_redisplay_source.
13098         * observable.h (source_styling_changed): New observable.
13099         * observable.c: Define source_styling_changed observable.
13100
13101 2019-03-13  Tom Tromey  <tromey@adacore.com>
13102
13103         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13104         (i386_gnu_nat_target::store_registers): Update.
13105         * target-debug.h (target_debug_print_std_string): New macro.
13106         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13107         * windows-tdep.c (display_one_tib): Update.
13108         * tui/tui-stack.c (tui_make_status_line): Update.
13109         * top.c (print_inferior_quit_action): Update.
13110         * thread.c (thr_try_catch_cmd): Update.
13111         (add_thread_with_info): Update.
13112         (thread_target_id_str): Update.
13113         (thr_try_catch_cmd): Update.
13114         (thread_command): Update.
13115         (thread_find_command): Update.
13116         * record-btrace.c (record_btrace_target::info_record)
13117         (record_btrace_resume_thread, record_btrace_target::resume)
13118         (record_btrace_cancel_resume, record_btrace_step_thread)
13119         (record_btrace_target::wait, record_btrace_target::wait)
13120         (record_btrace_target::wait, record_btrace_target::stop): Update.
13121         * progspace.c (print_program_space): Update.
13122         * process-stratum-target.c
13123         (process_stratum_target::thread_address_space): Update.
13124         * linux-fork.c (linux_fork_mourn_inferior)
13125         (detach_checkpoint_command, info_checkpoints_command)
13126         (linux_fork_context): Update.
13127         (linux_fork_detach): Update.
13128         (class scoped_switch_fork_info): Update.
13129         (delete_checkpoint_command): Update.
13130         * infrun.c (follow_fork_inferior): Update.
13131         (follow_fork_inferior): Update.
13132         (proceed_after_vfork_done): Update.
13133         (handle_vfork_child_exec_or_exit): Update.
13134         (follow_exec): Update.
13135         (displaced_step_prepare_throw): Update.
13136         (displaced_step_restore): Update.
13137         (start_step_over): Update.
13138         (resume_1): Update.
13139         (clear_proceed_status_thread): Update.
13140         (proceed): Update.
13141         (print_target_wait_results): Update.
13142         (do_target_wait): Update.
13143         (context_switch): Update.
13144         (stop_all_threads): Update.
13145         (restart_threads): Update.
13146         (finish_step_over): Update.
13147         (handle_signal_stop): Update.
13148         (switch_back_to_stepped_thread): Update.
13149         (keep_going_pass_signal): Update.
13150         (print_exited_reason): Update.
13151         (normal_stop): Update.
13152         * inferior.c (inferior_pid_to_str): Change return type.
13153         (print_selected_inferior): Update.
13154         (add_inferior): Update.
13155         (detach_inferior): Update.
13156         * dummy-frame.c (fprint_dummy_frames): Update.
13157         * dcache.c (dcache_info_1): Update.
13158         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13159         (btrace_fetch, btrace_clear): Update.
13160         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13161         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13162         type.
13163         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13164         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13165         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13166         * gdbarch.c, gdbarch.h: Rebuild.
13167         * gdbarch.sh (core_pid_to_str): Change return type.
13168         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13169         return type.
13170         (windows_nat_target::pid_to_str): Change return type.
13171         (windows_delete_thread): Update.
13172         (windows_nat_target::attach): Update.
13173         (windows_nat_target::files_info): Update.
13174         * target-delegates.c: Rebuild.
13175         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13176         return type.
13177         (sol_thread_target::pid_to_str): Change return type.
13178         * remote.c (class remote_target) <pid_to_str>: Change return
13179         type.
13180         (remote_target::pid_to_str): Change return type.
13181         (extended_remote_target::attach, remote_target::remote_stop_ns)
13182         (remote_target::remote_notif_remove_queued_reply)
13183         (remote_target::push_stop_reply, remote_target::disable_btrace):
13184         Update.
13185         (extended_remote_target::attach): Update.
13186         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13187         type.
13188         (gdbsim_target::pid_to_str): Change return type.
13189         * ravenscar-thread.c (struct ravenscar_thread_target)
13190         <pid_to_str>: Change return type.
13191         (ravenscar_thread_target::pid_to_str): Change return type.
13192         * procfs.c (class procfs_target) <pid_to_str>: Change return
13193         type.
13194         (procfs_target::pid_to_str): Change return type.
13195         (procfs_target::attach): Update.
13196         (procfs_target::detach): Update.
13197         (procfs_target::fetch_registers): Update.
13198         (procfs_target::store_registers): Update.
13199         (procfs_target::wait): Update.
13200         (procfs_target::files_info): Update.
13201         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13202         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13203         return type.
13204         (nto_procfs_target::pid_to_str): Change return type.
13205         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13206         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13207         return type.
13208         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13209         (exit_lwp): Update.
13210         (attach_proc_task_lwp_callback, get_detach_signal)
13211         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13212         (linux_nat_target::resume, wait_lwp, stop_callback)
13213         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13214         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13215         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13216         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13217         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13218         type.
13219         (inf_ptrace_target::attach): Update.
13220         (inf_ptrace_target::files_info): Update.
13221         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13222         type.
13223         (go32_nat_target::pid_to_str): Change return type.
13224         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13225         (gnu_nat_target::wait): Update.
13226         (gnu_nat_target::wait): Update.
13227         (gnu_nat_target::resume): Update.
13228         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13229         (fbsd_nat_target::wait): Update.
13230         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13231         type.
13232         (darwin_nat_target::attach): Update.
13233         * corelow.c (class core_target) <pid_to_str>: Change return type.
13234         (core_target::pid_to_str): Change return type.
13235         * target.c (normal_pid_to_str): Change return type.
13236         (default_pid_to_str): Likewise.
13237         (target_pid_to_str): Change return type.
13238         (target_translate_tls_address): Update.
13239         (target_announce_detach): Update.
13240         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13241         return type.
13242         (bsd_uthread_target::pid_to_str): Change return type.
13243         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13244         type.
13245         (bsd_kvm_target::pid_to_str): Change return type.
13246         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13247         return type.
13248         (aix_thread_target::pid_to_str): Change return type.
13249         * target.h (struct target_ops) <pid_to_str>: Change return type.
13250         (target_pid_to_str, normal_pid_to_str): Likewise.
13251         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13252         type.
13253         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13254         type.
13255         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13256         return type.
13257         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13258         type.
13259         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13260         type.
13261         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13262         return type.
13263
13264 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13265
13266         * NEWS: Mention that the new default MI version is 3.  Mention
13267         changes to the output of commands and events that deal with
13268         multi-location breakpoints.
13269         * breakpoint.c: Include "mi/mi-out.h".
13270         (print_one_breakpoint): Change output syntax if using MI version
13271         >= 3.
13272         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13273         New.
13274         (mi_multi_location_breakpoint_output_fixed): New.
13275         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13276         (mi_cmd_fix_multi_location_breakpoint_output): New.
13277         (mi_multi_location_breakpoint_output_fixed): New.
13278         * mi/mi-cmds.c (mi_cmds): Register command
13279         -fix-multi-location-breakpoint-output.
13280         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13281         interpreter "mi".
13282
13283 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13284
13285         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13286         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13287         instantiate mi_ui_out based on interpreter name.
13288         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13289         * mi/mi-main.c (mi_load_progress): Likewise.
13290
13291 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13292
13293         * NEWS: Combine separate "New targets" sections for 8.3.
13294
13295 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13296
13297         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13298         (ppcfbsd_init_abi): Install gdbarch
13299         "fetch_tls_load_module_address" and "get_thread_local_address"
13300         methods.
13301
13302 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13303
13304         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13305         (riscv_fbsd_init_abi): Install gdbarch
13306         "fetch_tls_load_module_address" and "get_thread_local_address"
13307         methods.
13308
13309 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13310
13311         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13312         (i386fbsd_init_abi): Install gdbarch
13313         "fetch_tls_load_module_address" and "get_thread_local_address"
13314         methods.
13315
13316 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13317
13318         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13319         (amd64fbsd_init_abi): Install gdbarch
13320         "fetch_tls_load_module_address" and "get_thread_local_address"
13321         methods.
13322
13323 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13324
13325         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13326         (struct fbsd_pspace_data): New type.
13327         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13328         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13329         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13330         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13331         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13332
13333 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13334
13335         * gdbtypes.c (lookup_struct_elt): New function.
13336         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13337         * gdbtypes.h (struct struct_elt): New type.
13338         (lookup_struct_elt): New prototype.
13339
13340 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13341
13342         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13343         remove disabled code block.
13344
13345 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13346
13347         * gdbarch.sh (get_thread_local_address): New method.
13348         * gdbarch.h, gdbarch.c: Regenerate.
13349         * target.c (target_translate_tls_address): Use
13350         gdbarch_get_thread_local_address if present instead of
13351         target::get_thread_local_address.
13352
13353 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13354
13355         * target.h (target::get_thread_local_address): Update comment.
13356
13357 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13358
13359         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13360         objfile->separate_debug_objfile_backlink if not NULL.
13361
13362 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13363
13364         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13365         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13366         (amd64bsd_store_inferior_registers): Likewise.
13367         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13368         Enable segment base registers.
13369         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13370         PT_GETFSBASE and PT_GETGSBASE.
13371         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13372         PT_SETGSBASE.
13373         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13374         segment base registers.
13375         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13376
13377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13378
13379         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13380         Update calls to i386_target_description to add 'segments'
13381         parameter.
13382         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13383         add segment base registers.
13384         * arch/i386.c (i386_create_target_description): Add 'segments'
13385         parameter to enable segment base registers.
13386         * arch/i386.h (i386_create_target_description): Likewise.
13387         * features/i386/32bit-segments.xml: New file.
13388         * features/i386/32bit-segments.c: Generate.
13389         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13390         call to i386_target_description to add 'segments' parameter.
13391         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13392         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13393         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13394         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13395         if feature is present.
13396         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13397         Add 'segments' parameter to call to i386_target_description.
13398         (i386_target_description): Add 'segments' parameter to enable
13399         segment base registers.
13400         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13401         to call to i386_target_description.
13402         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13403         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13404         Define I386_NUM_REGS.
13405         (i386_target_description): Add 'segments' parameter to enable
13406         segment base registers.
13407
13408 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13409
13410         PR/24325
13411         * source-cache.c: #undef open and close, to avoid unresolved
13412         externals during linking.
13413
13414 2019-03-12  Tom Tromey  <tromey@adacore.com>
13415
13416         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13417         const.  Add initializers.
13418         (_initialize_remote): Don't initialize ptid globals.
13419
13420 2019-03-12  Pedro Alves  <palves@redhat.com>
13421
13422         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13423
13424 2019-03-12  Pedro Alves  <palves@redhat.com>
13425
13426         * cp-name-parser.y (main): Remove unused 'len' variable.
13427
13428 2019-03-12  Tom Tromey  <tromey@adacore.com>
13429
13430         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13431         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13432
13433 2019-03-12  Tom Tromey  <tromey@adacore.com>
13434
13435         * linux-nat.c (iterate_over_lwps): Update.
13436         (stop_callback): Remove parameter.
13437         (stop_wait_callback, detach_callback, resume_set_callback)
13438         (select_singlestep_lwp_callback, set_ignore_sigint)
13439         (status_callback, resumed_callback, resume_clear_callback)
13440         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13441         data parameter.
13442         (linux_nat_target::detach, linux_nat_target::resume)
13443         (linux_stop_and_wait_all_lwps, select_event_lwp)
13444         (linux_nat_filter_event, linux_nat_wait_1)
13445         (linux_nat_target::kill, linux_nat_target::stop)
13446         (linux_nat_target::stop): Update.
13447         (linux_nat_resume_callback): Change type.
13448         (resume_stopped_resumed_lwps, count_events_callback)
13449         (select_event_lwp_callback): Likewise.
13450         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13451         * arm-linux-nat.c (struct update_registers_data): Remove.
13452         (update_registers_callback): Change type.
13453         (arm_linux_insert_hw_breakpoint1): Update.
13454         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13455         parameter.
13456         (x86_linux_dr_set_addr): Update.
13457         (x86_linux_dr_set_control): Update.
13458         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13459         (iterate_over_lwps): Use gdb::function_view.
13460         * nat/aarch64-linux-hw-point.c (struct
13461         aarch64_dr_update_callback_param): Remove.
13462         (debug_reg_change_callback): Change type.
13463         (aarch64_notify_debug_reg_change): Update.
13464         * s390-linux-nat.c (s390_refresh_per_info): Update.
13465
13466 2019-03-11  Tom Tromey  <tromey@adacore.com>
13467
13468         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13469         redundant assignment to "this_cu".
13470
13471 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13472
13473         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13474
13475 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13476
13477         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13478         from...
13479         (rank_one_type): ... this.
13480
13481 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13482
13483         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13484         from...
13485         (rank_one_type): ... this.
13486
13487 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13488
13489         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13490         from...
13491         (rank_one_type): ... this.
13492
13493 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13494
13495         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13496         from...
13497         (rank_one_type): ... this.
13498
13499 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13500
13501         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13502         from...
13503         (rank_one_type): ... this.
13504
13505 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13506
13507         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13508         from...
13509         (rank_one_type): ... this.
13510
13511 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13512
13513         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13514         from...
13515         (rank_one_type): ... this.
13516
13517 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13518
13519         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13520         from...
13521         (rank_one_type): ... this.
13522
13523 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13524
13525         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13526         from...
13527         (rank_one_type): ... this.
13528
13529 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13530
13531         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13532         from...
13533         (rank_one_type): ... this.
13534
13535 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13536
13537         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13538         from...
13539         (rank_one_type): ... this.
13540
13541 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13542
13543         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13544         from...
13545         (rank_one_type): ... this.
13546
13547 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13548
13549         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13550         inferior-events' shows the example events.
13551
13552 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13553
13554         Support styling on native MS-Windows console
13555
13556         PR/24315
13557         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13558         on MS-Windows if $TERM is not defined.
13559
13560         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13561
13562         * posix-hdep.c (gdb_console_fputs):
13563         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13564         functions.
13565         * ui-file.h (gdb_console_fputs): Add prototype.
13566
13567         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13568         back to fputs only if the former returns zero.
13569
13570 2019-03-07  Tom Tromey  <tom@tromey.com>
13571
13572         * symmisc.c (print_symbol_bcache_statistics): Update.
13573         (print_objfile_statistics): Update.
13574         * symfile.c (allocate_symtab): Update.
13575         * stabsread.c: Don't include bcache.h.
13576         * psymtab.h (struct psymbol_bcache): Don't declare.
13577         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13578         (psymbol_bcache_init, psymbol_bcache_free)
13579         (psymbol_bcache_get_bcache): Don't declare.
13580         * psymtab.c (struct psymbol_bcache): Remove.
13581         (psymtab_storage::psymtab_storage): Update.
13582         (psymtab_storage::~psymtab_storage): Update.
13583         (psymbol_bcache_init, psymbol_bcache_free)
13584         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13585         (add_psymbol_to_bcache): Update.
13586         (allocate_psymtab): Update.
13587         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13588         macro_cache>: No longer pointers.
13589         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13590         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13591         * macrotab.c (macro_bcache): Update.
13592         * macroexp.c: Don't include bcache.h.
13593         * gdbtypes.c (check_types_worklist): Update.
13594         (types_deeply_equal): Remove TRY/CATCH.  Update.
13595         * elfread.c (elf_symtab_read): Update.
13596         * dwarf2read.c: Don't include bcache.h.
13597         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13598         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13599         (print_bcache_statistics, bcache_memory_used): Don't declare.
13600         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13601         methods.  Rename all data members.
13602         * bcache.c (struct bcache): Move to bcache.h.
13603         (bcache::expand_hash_table): Rename from expand_hash_table.
13604         (bcache): Remove.
13605         (bcache::insert): Rename from bcache_full.
13606         (bcache::compare): Rename from bcache_compare.
13607         (bcache_xmalloc): Remove.
13608         (bcache::~bcache): Rename from bcache_xfree.
13609         (bcache::print_statistics): Rename from print_bcache_statistics.
13610         (bcache::memory_used): Rename from bcache_memory_used.
13611
13612 2019-03-07  Pedro Alves  <palves@redhat.com>
13613
13614         * infrun.c (normal_stop): Also check for
13615         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13616
13617 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13618
13619         * f-lang.c (value_from_host_double): Moved to...
13620         * value.c (value_from_host_double): ...here.
13621         * value.h (value_from_host_double): Declare.
13622         * guile/scm-math.c (vlscm_convert_typed_number): Use
13623         value_from_host_double.
13624         (vlscm_convert_number): Likewise.
13625         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13626         * python/py-value.c (convert_value_from_python): Likewise.
13627
13628 2019-03-06  Tom Tromey  <tom@tromey.com>
13629
13630         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13631
13632 2019-03-06  Tom Tromey  <tom@tromey.com>
13633
13634         * utils.h (free_current_contents): Don't declare.
13635         * utils.c (free_current_contents): Remove.
13636
13637 2019-03-06  Tom Tromey  <tom@tromey.com>
13638
13639         * top.c (quit_force): Update.
13640         * main.c (captured_command_loop): Update.
13641         * common/new-op.c (operator new): Update.
13642         * common/common-exceptions.c (struct catcher)
13643         <save_cleanup_chain>: Remove member.
13644         (exceptions_state_mc_init): Update.
13645         (exception_try_scope_entry): Return nullptr.
13646         (exception_try_scope_exit, exception_rethrow)
13647         (throw_exception_sjlj, throw_exception_cxx): Update.
13648         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13649         (all_cleanups, do_cleanups, discard_cleanups)
13650         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13651         (restore_cleanups, restore_final_cleanups): Don't declare.
13652         (do_final_cleanups): Remove parameter.
13653         * common/cleanups.c (cleanup_chain, make_cleanup)
13654         (make_cleanup_dtor, all_cleanups, do_cleanups)
13655         (discard_my_cleanups, discard_cleanups)
13656         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13657         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13658         (null_cleanup): Remove.
13659         (do_final_cleanups): Remove parameter.
13660
13661 2019-03-06  Tom Tromey  <tom@tromey.com>
13662
13663         * remote.c (remote_target::remote_parse_stop_reply): Use
13664         unique_xmalloc_ptr.
13665
13666 2019-03-06  Tom Tromey  <tom@tromey.com>
13667
13668         * stabsread.c (struct stabs_field_info): Rename from field_info.
13669         <list, fnlist>: Add initializers.
13670         <obstack>: New member.
13671         (read_member_functions, read_struct_fields, read_baseclasses):
13672         Allocate on obstack.  Don't use cleanups.
13673         (read_one_struct_field, read_member_functions, read_struct_fields)
13674         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13675         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13676         (read_struct_type): Update.
13677
13678 2019-03-06  Tom Tromey  <tom@tromey.com>
13679
13680         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13681         * common/filestuff.h (make_cleanup_close): Don't declare.
13682         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13683         Remove.
13684
13685 2019-03-06  Tom Tromey  <tom@tromey.com>
13686
13687         * solib-aix.c: Use make_scope_exit.
13688
13689 2019-03-06  Tom Tromey  <tom@tromey.com>
13690
13691         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13692         Use make_scope_exit.
13693
13694 2019-03-06  Tom Tromey  <tom@tromey.com>
13695
13696         * solib-svr4.c (disable_probes_interface): Remove parameter.
13697         (svr4_handle_solib_event): Use make_scope_exit.
13698
13699 2019-03-06  Tom Tromey  <tom@tromey.com>
13700
13701         * remote.c (struct stop_reply_deleter): Remove.
13702         (stop_reply_up): Update.
13703         (struct stop_reply): Derive from notif_event.  Don't typedef.
13704         <regcache>: Now a std::vector.
13705         (stop_reply_xfree): Remove.
13706         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13707         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13708         (remote_target::discard_pending_stop_replies): Use delete.
13709         (remote_target::remote_parse_stop_reply): Update.
13710         (remote_target::process_stop_reply): Update.
13711         * remote-notif.h (struct notif_event): Add virtual destructor.
13712         Remove "dtr" member.
13713         (struct notif_client) <alloc_event>: Return a unique_ptr.
13714         (notif_event_xfree): Don't declare.
13715         (notif_event_up): New typedef.
13716         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13717         (notif_event_xfree, do_notif_event_xfree): Remove.
13718         (remote_notif_state_xfree): Update.
13719
13720 2019-03-06  Tom Tromey  <tom@tromey.com>
13721
13722         * infrun.c (displaced_step_clear_cleanup): Now a
13723         forward_scope_exit type.
13724         (displaced_step_prepare_throw): Update.
13725         (displaced_step_fixup): Update.
13726
13727 2019-03-06  Tom Tromey  <tom@tromey.com>
13728
13729         * inferior.h (class inferior): Update comment.
13730         * gdbthread.h (class thread_info): Update comment.
13731
13732 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13733             Tom Tromey  <tom@tromey.com>
13734
13735         * stabsread.h (struct stab_section_list): Remove.
13736         (coffstab_build_psymtabs): Update.
13737         * dbxread.c (symbuf_sections): Now a std::vector.
13738         (sect_idx): New global.
13739         (fill_symbuf): Update.
13740         (coffstab_build_psymtabs): Change type of stabsects parameter.
13741         Update.
13742         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13743         std::vector.
13744         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13745         (coff_locate_sections): Update.
13746         (coff_symfile_read): Remove cleanups.  Update.
13747         (init_stringtab): Add storage parameter.
13748         (free_stringtab, free_stringtab_cleanup): Remove.
13749         (init_lineno): Add storage parameter.
13750         (free_linetab, free_linetab_cleanup): Remove.
13751
13752 2019-03-06  Pedro Alves  <palves@redhat.com>
13753
13754         * linux-fork.c (fork_info::clobber_regs): Delete.
13755         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13756         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13757         comment.  Adjust.
13758         (scoped_switch_fork_info::scoped_switch_fork_info)
13759         (checkpoint_command, linux_fork_context): Adjust
13760         fork_save_infrun_state calls.
13761
13762 2019-03-06  Pedro Alves  <palves@redhat.com>
13763
13764         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13765         (inf_has_multiple_threads): Return 'bool' and rewrite using
13766         inferior_info::threads().
13767
13768 2019-03-06  Pedro Alves  <palves@redhat.com>
13769
13770         * linux-fork.c: Include <list>.
13771         (fork_list): Now a std::list instance.
13772         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13773         (forks_exist_p, find_last_fork): Adjust.
13774         (new_fork): Delete.
13775         (one_fork_p): New.
13776         (add_fork): Adjust.
13777         (free_fork): Delete, folded into fork_info::~fork_info().
13778         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13779         Adjust.
13780         (init_fork_list): Delete.
13781         (linux_fork_killall, linux_fork_mourn_inferior)
13782         (linux_fork_detach, info_checkpoints_command): Adjust.
13783         (_initialize_linux_fork): No longer call init_fork_list.
13784
13785 2019-03-06  Pedro Alves  <palves@redhat.com>
13786
13787         * linux-fork.c (new_fork): New, split out of ...
13788         (add_fork): ... this.  Return void.  Move "first fork" special
13789         case from here, to ...
13790         (checkpoint_command): ... here.
13791         * linux-linux.h (add_fork): Return void.
13792
13793 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13794
13795         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13796
13797 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13798             Chris January  <chris.january@arm.com>
13799             David Lecomber  <david.lecomber@arm.com>
13800
13801         * f-exp.y: New token, UNOP_INTRINSIC.
13802         (exp): New pattern using UNOP_INTRINSIC token.
13803         (f77_keywords): Add 'abs' keyword.
13804         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13805         (value_from_host_double): New function.
13806         (evaluate_subexp_f): Support UNOP_ABS.
13807
13808 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13809
13810         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13811         types.
13812
13813 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13814
13815         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13816         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13817         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13818
13819 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13820
13821         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13822
13823 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13824             Chris January  <chris.january@arm.com>
13825
13826         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13827         * f-exp.y: Define 'KIND' token.
13828         (exp): New pattern for KIND expressions.
13829         (ptype): Handle types with a kind extension.
13830         (direct_abs_decl): Extend to spot kind extensions.
13831         (f77_keywords): Add 'kind' to the list.
13832         (push_kind_type): New function.
13833         (convert_to_kind_type): New function.
13834         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13835         * parse.c (operator_length_standard): Likewise.
13836         * parser-defs.h (enum type_pieces): Add tp_kind.
13837         * std-operator.def: Add UNOP_KIND.
13838
13839 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13840
13841         * f-exp.y (f_parse): Set yydebug.
13842
13843 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13844
13845         * f-lang.c (evaluate_subexp_f): New function.
13846         (exp_descriptor_f): New global.
13847         (f_language_defn): Use exp_descriptor_f instead of
13848         exp_descriptor_standard.
13849
13850 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13851
13852         * f-exp.y (struct token): Add comments.
13853         (dot_ops): Remove uppercase versions and the end marker.
13854         (f77_keywords): Likewise.
13855         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13856         entries in the dot_ops array are case insensitive, and use
13857         strncasecmp to compare strings.  Also some whitespace cleanup in
13858         this area.  Similar for the f77_keywords array, except entries in
13859         this list might be case sensitive.
13860
13861 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13862
13863         * f-exp.y (struct f77_boolean_val): Add comments.
13864         (boolean_values): Remove uppercase versions, and end marker.
13865         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13866         and use strncasecmp to achieve case insensitivity.  Additionally,
13867         perform whitespace cleanup around this code.
13868
13869 2019-03-06  Tom Tromey  <tromey@adacore.com>
13870
13871         * remote-sim.c (gdbsim_target_open): Use result of
13872         gdb_argv::release.
13873
13874 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13875         Dirk Schubert  <dirk.schubert@arm.com>
13876         Chris January  <chris.january@arm.com>
13877
13878         * eval.c (evaluate_subexp_standard): Call Fortran argument
13879         wrapping logic.
13880         * f-lang.c (struct value): A value which can be passed into a
13881         Fortran function call.
13882         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13883         where appropriate.
13884         (struct type): Value ready for a Fortran function call.
13885         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13886         is needed.
13887         * f-lang.h (fortran_argument_convert): Declaration.
13888         (fortran_preserve_arg_pointer): Declaration.
13889         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13890
13891 2019-03-05  Tom Tromey  <tromey@adacore.com>
13892
13893         * python/py-prettyprint.c (print_string_repr): Remove #if.
13894         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13895
13896 2019-03-05  Tom Tromey  <tromey@adacore.com>
13897
13898         * target.c (the_dummy_target): Move later.  Change type to
13899         "dummy_target".
13900         (initialize_targets): Don't initialize the_dummy_target.
13901
13902 2019-03-05  Tom Tromey  <tromey@adacore.com>
13903
13904         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13905         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13906
13907 2019-03-05  Tom Tromey  <tromey@adacore.com>
13908
13909         * windows-nat.c (windows_nat_target::attach)
13910         (windows_nat_target::detach): Don't call gdb_flush.
13911         * valprint.c (generic_val_print, val_print, val_print_string):
13912         Don't call gdb_flush.
13913         * utils.c (defaulted_query): Don't call gdb_flush.
13914         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13915         * target.c (target_announce_detach): Don't call gdb_flush.
13916         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13917         * remote.c (extended_remote_target::attach): Don't call
13918         gdb_flush.
13919         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13920         * printcmd.c (do_examine): Don't call gdb_flush.
13921         (info_display_command): Don't call gdb_flush.
13922         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13923         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13924         * memattr.c (info_mem_command): Don't call gdb_flush.
13925         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13926         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13927         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13928         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13929         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13930         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13931         (gnu_nat_target::detach): Don't call gdb_flush.
13932         * f-valprint.c (f_val_print): Don't call gdb_flush.
13933         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13934         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13935         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13936         gdb_flush.
13937         * c-valprint.c (c_val_print): Don't call gdb_flush.
13938         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13939
13940 2019-03-05  Tom Tromey  <tromey@adacore.com>
13941
13942         * varobj.c (update_dynamic_varobj_children): Update.
13943         (install_default_visualizer): Use reset, not release.
13944         * value.c (set_internalvar): Update.
13945         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13946         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13947         ATTRIBUTE_UNUSED_RESULT.
13948
13949 2019-03-05  Tom Tromey  <tromey@adacore.com>
13950
13951         * remote.c (class scoped_remote_fd) <release>: Add
13952         ATTRIBUTE_UNUSED_RESULT.
13953
13954 2019-03-05  Tom Tromey  <tromey@adacore.com>
13955
13956         * macroexp.c (struct macro_buffer) <release>: Add
13957         ATTRIBUTE_UNUSED_RESULT.
13958
13959 2019-03-05  Tom Tromey  <tromey@adacore.com>
13960
13961         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13962         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13963         ATTRIBUTE_UNUSED_RESULT.
13964
13965 2019-03-05  Tom Tromey  <tromey@adacore.com>
13966
13967         * common/scoped_fd.h (class scoped_fd) <release>: Add
13968         ATTRIBUTE_UNUSED_RESULT.
13969
13970 2019-03-05  Tom Tromey  <tromey@adacore.com>
13971
13972         * parser-defs.h (struct parser_state) <release>: Add
13973         ATTRIBUTE_UNUSED_RESULT.
13974
13975 2019-03-05  Tom Tromey  <tromey@adacore.com>
13976
13977         * utils.h (class gdb_argv) <release>: Add
13978         ATTRIBUTE_UNUSED_RESULT.
13979         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13980
13981 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13982
13983         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13984         for-loop range, to avoid compiler warnings.
13985
13986         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13987         avoid compiler warnings about unused variables.
13988
13989         * NEWS: Mention end of support for native debugging on MS-Windows
13990         before XP.
13991
13992         PR gdb/24292
13993         * common/netstuff.c:
13994         * gdbserver/gdbreplay.c
13995         * gdbserver/remote-utils.c:
13996         * ser-tcp.c:
13997         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13998         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13999         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14000         'getaddrinfo' and 'freeaddrinfo' were not available before
14001         Windows XP, and mingw.org's MinGW headers by default define
14002         _WIN32_WINNT to 0x500.
14003
14004 2019-03-01  Gary Benson <gbenson@redhat.com>
14005
14006         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14007
14008 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14009             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14010
14011         PR gdb/8527
14012         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14013         set_sigint_trap, clear_sigint_trap.
14014
14015 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14016
14017         * target.c (target_detach): Clear the regcache and the
14018         frame cache.
14019
14020 2019-02-27  Pedro Alves  <palves@redhat.com>
14021
14022         * utils.c (set_screen_size): When we cap the height/width sizes,
14023         tweak the corresponding command variable to show "unlimited":
14024
14025 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14026             Pedro Alves  <palves@redhat.com>
14027
14028         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14029         before calling rl_set_screen_size.
14030
14031 2019-02-27  Tom Tromey  <tromey@adacore.com>
14032
14033         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14034         define.
14035         * python/py-value.c: Remove Python 2.4 workaround.
14036         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14037         workaround.
14038         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14039         Python 2.4 workaround.
14040         * python/python-internal.h: Remove Python 2.4 comment.
14041         (Py_ssize_t): Don't define.
14042         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14043         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14044         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14045         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14046         * python/python.c (do_start_initialization): Remove Python 2.4
14047         workaround.
14048         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14049         (print_children): Remove Python 2.4 workaround.
14050         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14051         workaround.
14052         (CHARBUFFERPROC_NAME): Remove.
14053         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14054         Python 2.4 workaround.
14055
14056 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14057
14058         * NEWS: Note minimum Python version.
14059
14060 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14061
14062         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14063         code from these functions.  Remove corresponding ifdefs.  Use
14064         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14065         Remove gotos and target of gotos.
14066         (infpy_search_memory): Likewise.
14067
14068 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14069
14070         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14071         (hppa_gdbarch_init): Don't register deleted functions with
14072         gdbarch.
14073
14074 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14075
14076         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14077         (h8300_unwind_sp): Delete.
14078         (h8300_dummy_id): Delete.
14079         (h8300_gdbarch_init): Don't register deleted functions with
14080         gdbarch.
14081
14082 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14083
14084         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14085         (ft32_unwind_pc): Delete.
14086         (ft32_unwind_sp): Delete.
14087         (ft32_gdbarch_init): Don't register deleted functions with
14088         gdbarch.
14089
14090 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14091
14092         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14093         (frv_unwind_pc): Delete.
14094         (frv_unwind_sp): Delete.
14095         (frv_gdbarch_init): Don't register deleted functions with
14096         gdbarch.
14097
14098 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14099
14100         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14101         (riscv_unwind_pc): Delete.
14102         (riscv_unwind_sp): Delete.
14103         (riscv_gdbarch_init): Don't register deleted functions with
14104         gdbarch.
14105
14106 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14107
14108         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14109         (csky_unwind_pc): Delete.
14110         (csky_unwind_sp): Delete.
14111         (csky_gdbarch_init): Don't register deleted functions with
14112         gdbarch.
14113
14114 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14115
14116         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14117         (cris_unwind_pc): Delete.
14118         (cris_unwind_sp): Delete.
14119         (cris_gdbarch_init): Don't register deleted functions with
14120         gdbarch.
14121
14122 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14123
14124         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14125         (bfin_unwind_pc): Delete.
14126         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14127
14128 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14129
14130         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14131         (arm_unwind_pc): Delete.
14132         (arm_unwind_sp): Delete.
14133         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14134
14135 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14136
14137         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14138         (arc_unwind_pc): Delete.
14139         (arc_unwind_sp): Delete.
14140         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14141
14142 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14143
14144         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14145         (alpha_unwind_pc): Delete.
14146         (alpha_gdbarch_init): Don't register deleted functions with
14147         gdbarch.
14148
14149 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14150
14151         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14152         (aarch64_unwind_pc): Delete.
14153         (aarch64_unwind_sp): Delete.
14154         (aarch64_gdbarch_init): Don't register deleted functions with
14155         gdbarch.
14156
14157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14158
14159         * gdbtypes.c (type_align): Don't consider static members when
14160         computing structure alignment.
14161
14162 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14163
14164         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14165         return 0 for other types.
14166         * arch-utils.c (default_type_align): Always return 0.
14167         * gdbarch.h: Regenerate.
14168         * gdbarch.sh (type_align): Extend comment.
14169         * gdbtypes.c (type_align): Add additional comments, always call
14170         gdbarch_type_align before applying the default rules.
14171         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14172         generic code will then apply a suitable default.
14173         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14174         types, return 0 for other types.
14175
14176 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14177
14178         * NEWS: Create a new section for the next release branch.
14179         Rename the section of the current branch, now that it has
14180         been cut.
14181
14182 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14183
14184         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14185         * version.in: Bump version to 8.3.50.DATE-git.
14186
14187 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14188
14189         * aix-thread.c (ptid_cmp): Remove unused variable.
14190         (get_signaled_thread): Likewise.
14191         (store_regs_user_thread): Likewise.
14192         (store_regs_kernel_thread): Likewise.
14193         (fetch_regs_kernel_thread): Remove shadowed variable.
14194
14195 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14196
14197         * features/riscv/32bit-cpu.xml: Add register numbers.
14198         * features/riscv/32bit-fpu.c: Regenerate.
14199         * features/riscv/32bit-fpu.xml: Add register numbers.
14200         * features/riscv/64bit-cpu.xml: Add register numbers.
14201         * features/riscv/64bit-fpu.c: Regenerate.
14202         * features/riscv/64bit-fpu.xml: Add register numbers.
14203
14204 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14205
14206         * NEWS: Mention two argument form of gdb.Value constructor.
14207         * python/py-value.c (convert_buffer_and_type_to_value): New
14208         function.
14209         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14210         Add support for handling an optional second argument.  Call
14211         convert_buffer_and_type_to_value as appropriate.
14212         * python/python-internal.h (Py_buffer_deleter): New struct.
14213         (Py_buffer_up): New typedef.
14214
14215 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14216
14217         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14218         instead of releasing ownership.
14219
14220 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14221
14222         * dwarf2read.c (open_and_init_dwp_file): Call
14223         elf_numsections instead of bfd_count_sections to initialize
14224         dwp_file->num_sections.
14225
14226 2019-02-25  Tom Tromey  <tromey@adacore.com>
14227
14228         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14229
14230 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14231
14232         * gcore.in: Add '--readnever' option when invoking GDB.
14233
14234 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14235
14236         * MAINTAINERS: Update my email address.
14237
14238 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14239
14240         * build-id.c (build_id_to_debug_bfd_1): New function.
14241         (build_id_to_debug_bfd): Look for separate debug file in
14242         sysroot.
14243
14244 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14245
14246         * gdbarch.sh: Update the copyright year range that is placed into
14247         generated files.
14248
14249 2019-02-22  Keith Seitz  <keiths@redhat.com>
14250
14251         PR symtab/23853
14252         * linespec.c (create_sals_line_offset): Search for the default
14253         symtab's filename instead of its fullname.
14254
14255 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14256
14257         * NEWS: Update style defaults.
14258
14259 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14260
14261         * main.c (captured_main_1): Disable styling in batch mode.
14262
14263 2019-02-20  Tom Tromey  <tom@tromey.com>
14264
14265         * symtab.c (symtab_symbol_info): Fix typos.
14266
14267 2019-02-20  Tom Tromey  <tromey@adacore.com>
14268
14269         * findcmd.c (_initialize_mem_search): Use upper case for
14270         metasyntactic variables.
14271
14272 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14273
14274         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14275         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14276
14277 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14278
14279         * top.h (source_file_name): Change to std::string.
14280         * top.c (source_file_name): Likewise.
14281         (command_line_input): Adjust.
14282         * cli/cli-script.c (script_from_file): Adjust.
14283
14284 2019-02-19  Tom Tromey  <tromey@adacore.com>
14285
14286         * ravenscar-thread.c
14287         (ravenscar_thread_target::update_thread_list): Don't call
14288         ada_build_task_list.
14289         * ada-lang.h (ada_build_task_list): Don't declare.
14290         * ada-tasks.c (struct ada_tasks_inferior_data)
14291         <task_list_valid_p>: Now bool.
14292         (read_known_tasks, ada_task_list_changed)
14293         (ada_tasks_invalidate_inferior_data): Update.
14294         (read_known_tasks_array): Return bool.
14295         (read_known_tasks_list): Likewise.
14296         (read_known_tasks): Return void.
14297         (ada_build_task_list): Now static.
14298
14299 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14300
14301         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14302         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14303
14304 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14305
14306         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14307         variant for ada_tasks_pspace_data_handle and
14308         ada_tasks_inferior_data_handle.
14309         (ada_tasks_pspace_data_cleanup): New function.
14310         (ada_tasks_inferior_data_cleanup): New function.
14311
14312 2019-02-17  Tom Tromey  <tom@tromey.com>
14313
14314         * macrotab.h (macro_source_fullname): Return a std::string.
14315         * macrotab.c (macro_include, check_for_redefinition)
14316         (macro_undef, macro_lookup_definition, foreach_macro)
14317         (foreach_macro_in_scope): Update.
14318         (macro_source_fullname): Return a std::string.
14319         * macrocmd.c (show_pp_source_pos): Update.
14320
14321 2019-02-17  Tom Tromey  <tom@tromey.com>
14322
14323         * macrocmd.c (show_pp_source_pos): Style the file names.
14324
14325 2019-02-17  Tom Tromey  <tom@tromey.com>
14326
14327         PR tui/24197:
14328         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14329
14330 2019-02-17  Tom Tromey  <tom@tromey.com>
14331
14332         * ada-lang.c (user_select_syms): Use filtered printing.
14333         * utils.c (wrap_style): New global.
14334         (desired_style): Remove.
14335         (emit_style_escape): Add stream parameter.
14336         (set_output_style, reset_terminal_style, prompt_for_continue):
14337         Update.
14338         (flush_wrap_buffer): Only flush gdb_stdout.
14339         (wrap_here): Set wrap_style.
14340         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14341         treat escape sequences as a character.  Change when wrap buffer is
14342         flushed.
14343         (fputs_styled): Do not set the output style when the default is
14344         requested.
14345         * ui-style.h (struct ui_file_style) <is_default>: New method.
14346         * source.c (print_source_lines_base): Emit escape sequences in one
14347         piece.
14348
14349 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14350
14351         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14352         integers and enumeration types.
14353
14354 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14355
14356         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14357         instead of lookup_symbol_in_language
14358         (do_exact_match): New function.
14359         (ada_get_symbol_name_matcher): Return do_exact_match when
14360         doing a verbatim match.
14361
14362 2019-02-15  Tom Tromey  <tromey@adacore.com>
14363
14364         * ravenscar-thread.c (ravenscar_thread_target::resume)
14365         (ravenscar_thread_target::wait): Special case wildcard requests.
14366
14367 2019-02-15  Tom Tromey  <tromey@adacore.com>
14368
14369         * ravenscar-thread.c (base_ptid): Remove.
14370         (struct ravenscar_thread_target) <close>: New method.
14371         <m_base_ptid>: New member.
14372         <update_inferior_ptid, active_task, task_is_currently_active,
14373         runtime_initialized>: Declare methods.
14374         <ravenscar_thread_target>: Add constructor.
14375         (ravenscar_thread_target::task_is_currently_active)
14376         (ravenscar_thread_target::update_inferior_ptid)
14377         (ravenscar_runtime_initialized): Rename.  Now methods.
14378         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14379         (ravenscar_thread_target::update_thread_list): Update.
14380         (ravenscar_thread_target::active_task): Now method.
14381         (ravenscar_thread_target::store_registers)
14382         (ravenscar_thread_target::prepare_to_store)
14383         (ravenscar_thread_target::prepare_to_store)
14384         (ravenscar_thread_target::mourn_inferior): Update.
14385         (ravenscar_inferior_created): Use "new" to create target.
14386         (ravenscar_thread_target::get_ada_task_ptid): Update.
14387         (_initialize_ravenscar): Don't initialize base_ptid.
14388         (ravenscar_ops): Remove global.
14389
14390 2019-02-15  Tom Tromey  <tromey@adacore.com>
14391
14392         * target.h (push_target): Declare new overload.
14393         * target.c (push_target): New overload, taking an rvalue reference.
14394         * remote.c (remote_target::open_1): Use push_target overload.
14395         * corelow.c (core_target_open): Use push_target overload.
14396
14397 2019-02-15  Tom Tromey  <tromey@adacore.com>
14398
14399         * ravenscar-thread.c (is_ravenscar_task)
14400         (ravenscar_task_is_currently_active): Return bool.
14401         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14402         (_initialize_ravenscar): Remove "(void)".
14403         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14404         Return bool.
14405
14406 2019-02-15  Tom Tromey  <tromey@adacore.com>
14407
14408         * ravenscar-thread.c (ravenscar_runtime_initializer)
14409         (has_ravenscar_runtime, get_running_thread_id)
14410         (ravenscar_thread_target::resume): Fix indentation.
14411
14412 2019-02-15  Tom Tromey  <tromey@adacore.com>
14413
14414         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14415         from ravenscar_arch_ops.
14416         (sparc_ravenscar_ops::fetch_registers)
14417         (sparc_ravenscar_ops::store_registers): Now methods.
14418         (sparc_ravenscar_prepare_to_store): Remove.
14419         (sparc_ravenscar_ops): Redefine.
14420         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14421         methods and destructor.  Remove members.
14422         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14423         (ravenscar_thread_target::store_registers)
14424         (ravenscar_thread_target::prepare_to_store): Update.
14425         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14426         Remove.
14427         (struct ppc_ravenscar_powerpc_ops): Derive from
14428         ravenscar_arch_ops.
14429         (ppc_ravenscar_powerpc_ops::fetch_registers)
14430         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14431         (ppc_ravenscar_powerpc_ops): Redefine.
14432         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14433         (ppc_ravenscar_e500_ops::fetch_registers)
14434         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14435         (ppc_ravenscar_e500_ops): Redefine.
14436         * aarch64-ravenscar-thread.c
14437         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14438         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14439         (aarch64_ravenscar_fetch_registers)
14440         (aarch64_ravenscar_store_registers): Now methods.
14441         (aarch64_ravenscar_ops): Redefine.
14442
14443 2019-02-15  Tom Tromey  <tromey@adacore.com>
14444
14445         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14446         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14447         (ravenscar_thread_target::stopped_by_watchpoint)
14448         (ravenscar_thread_target::stopped_data_address)
14449         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14450
14451 2019-02-15  Tom Tromey  <tromey@adacore.com>
14452
14453         * ravenscar-thread.c: Fix some typos.
14454
14455 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14456             Tom Tromey  <tromey@adacore.com>
14457
14458         * ada-lang.c (ada_exception_sal): Change addr_string to a
14459         std::string.
14460         (create_ada_exception_catchpoint): Update.
14461
14462 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14463             Tom Tromey  <tromey@adacore.com>
14464
14465         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14466         (bp_location_ops): Remove.
14467         (base_breakpoint_allocate_location): Update.
14468         (free_bp_location): Update.
14469         * ada-lang.c (class ada_catchpoint_location)
14470         <ada_catchpoint_location>: Remove ops parameter.
14471         (ada_catchpoint_location_dtor): Remove.
14472         (ada_catchpoint_location_ops): Remove.
14473         (allocate_location_exception): Update.
14474         * breakpoint.h (struct bp_location_ops): Remove.
14475         (class bp_location) <bp_location>: Remove bp_location_ops
14476         parameter.
14477         <~bp_location>: Add destructor.
14478         <ops>: Remove.
14479
14480 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14481             Pedro Alves  <palves@redhat.com>
14482
14483         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14484         'PATH_MAX'.
14485
14486 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14487             Samuel Thibault  <samuel.thibault@gnu.org>
14488             Thomas Schwinge  <thomas@codesourcery.com>
14489
14490         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14491         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14492
14493 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14494
14495         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14496         (check_empty): Use "const char *".
14497
14498         * gnu-nat.c (gnu_nat_target::detach): Instead of
14499         'detach_inferior (pid)' call
14500         'detach_inferior (find_inferior_pid (pid))'.
14501
14502         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14503         'nat/fork-inferior.o'.
14504         * gnu-nat.c: #include "nat/fork-inferior.h".
14505
14506         * gnu-nat.c (gnu_nat_target::detach): Instead of
14507         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14508         * gnu-nat.h: #include "inf-child.h".
14509         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14510         'i386_gnu_nat_target::fetch_registers'.
14511         (gnu_store_registers): Rename/move to
14512         'i386_gnu_nat_target::store_registers'.
14513
14514         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14515         * gnu-nat.h (mach_thread_info): New function.
14516         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14517
14518         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14519
14520 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14521
14522         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14523
14524 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14525
14526         * windows-nat.c (windows_add_thread): Add new parameter
14527         "main_thread_p" with default value set to false.  Update
14528         function documentation as well as all callers.
14529         (windows_delete_thread): Likewise.
14530         (fake_create_process): Update call to windows_add_thread.
14531         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14532         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14533         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14534         call to windows_delete_thread.
14535
14536 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14537
14538         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14539
14540 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14541
14542         * symfile.c (find_separate_debug_file): Use canonical path of
14543         sysroot with child_path instead of gdb_sysroot if it is valid.
14544
14545 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14546
14547         * symfile.c (find_separate_debug_file): Use child_path to
14548         determine if an object file is under a sysroot.
14549
14550 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14551
14552         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14553         unittests/child-path-selftests.c.
14554         * common/pathstuff.c (child_path): New function.
14555         * common/pathstuff.h (child_path): New prototype.
14556         * unittests/child-path-selftests.c: New file.
14557
14558 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14559
14560         * symfile.c (find_separate_debug_file): Look for separate debug
14561         files in debug directories under the sysroot.
14562
14563 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14564
14565         * symtab.h (struct minimal_symbol data_p): New const method.
14566         (struct minimal_symbol text_p): Likewise.
14567         * symtab.c (output_source_filename): Use file name style
14568         to print file name.
14569         (print_symbol_info): Likewise.
14570         (print_msymbol_info): Use address style to print addresses.
14571         Use function name style to print executable text symbols.
14572         (expand_symtab_containing_pc): Use data_p.
14573         (find_pc_sect_compunit_symtab): Likewise.
14574
14575 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14576
14577         * breakpoint.c (describe_other_breakpoints): Use address style
14578         to print addresses.
14579         (say_where): Likewise.
14580
14581 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14582
14583         * ada-typeprint.c (print_func_type): Print function name
14584         style to print function name.
14585         * c-typeprint.c (c_print_type_1): Likewise.
14586
14587 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14588
14589         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14590         for execve.
14591
14592 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14593
14594         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14595         type_stack.
14596
14597 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14598
14599         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14600         TYPE_CODE_REF types.
14601
14602 2019-02-08  Jim Wilson  <jimw@sifive.com>
14603
14604         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14605         (riscv_linux_fregset): New.
14606         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14607
14608 2019-02-07  Tom Tromey  <tom@tromey.com>
14609
14610         * thread.c (thread_cancel_execution_command): Update.
14611         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14612         methods.
14613         (struct thread_fsm_ops): Remove.
14614         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14615         (thread_fsm_should_stop, thread_fsm_return_value)
14616         (thread_fsm_set_finished, thread_fsm_finished_p)
14617         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14618         Don't declare.
14619         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14620         * infrun.c (clear_proceed_status_thread)
14621         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14622         (print_stop_event): Update.
14623         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14624         Add constructor.
14625         (step_command_fsm_ops): Remove.
14626         (new_step_command_fsm): Remove.
14627         (step_1): Update.
14628         (step_command_fsm::should_stop): Rename from
14629         step_command_fsm_should_stop.
14630         (step_command_fsm::clean_up): Rename from
14631         step_command_fsm_clean_up.
14632         (step_command_fsm::do_async_reply_reason): Rename from
14633         step_command_fsm_async_reply_reason.
14634         (struct until_next_fsm): Inherit from thread_fsm.  Add
14635         constructor.
14636         (until_next_fsm_ops): Remove.
14637         (new_until_next_fsm): Remove.
14638         (until_next_fsm::should_stop): Rename from
14639         until_next_fsm_should_stop.
14640         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14641         (until_next_fsm::do_async_reply_reason): Rename from
14642         until_next_fsm_async_reply_reason.
14643         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14644         constructor.  Change type of breakpoint.
14645         (finish_command_fsm_ops): Remove.
14646         (new_finish_command_fsm): Remove.
14647         (finish_command_fsm::should_stop): Rename from
14648         finish_command_fsm_should_stop.
14649         (finish_command_fsm::clean_up): Rename from
14650         finish_command_fsm_clean_up.
14651         (finish_command_fsm::return_value): Rename from
14652         finish_command_fsm_return_value.
14653         (finish_command_fsm::do_async_reply_reason): Rename from
14654         finish_command_fsm_async_reply_reason.
14655         (finish_command): Update.
14656         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14657         Add constructor.
14658         (call_thread_fsm_ops): Remove.
14659         (call_thread_fsm::call_thread_fsm): Rename from
14660         new_call_thread_fsm.
14661         (call_thread_fsm::should_stop): Rename from
14662         call_thread_fsm_should_stop.
14663         (call_thread_fsm::should_notify_stop): Rename from
14664         call_thread_fsm_should_notify_stop.
14665         (run_inferior_call, call_function_by_hand_dummy): Update.
14666         * cli/cli-interp.c (should_print_stop_to_console): Update.
14667         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14668         Add constructor.  Change type of location_breakpoint,
14669         caller_breakpoint.
14670         (until_break_fsm_ops): Remove.
14671         (new_until_break_fsm): Remove.
14672         (until_break_fsm::should_stop): Rename from
14673         until_break_fsm_should_stop.
14674         (until_break_fsm::clean_up): Rename from
14675         until_break_fsm_clean_up.
14676         (until_break_fsm::do_async_reply_reason): Rename from
14677         until_break_fsm_async_reply_reason.
14678         (until_break_command): Update.
14679         * thread-fsm.c: Remove.
14680         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14681
14682 2019-02-07  Tom Tromey  <tom@tromey.com>
14683
14684         * yy-remap.h: Add include guard.
14685         * xtensa-tdep.h: Add include guard.
14686         * xcoffread.h: Rename include guard.
14687         * varobj-iter.h: Add include guard.
14688         * tui/tui.h: Rename include guard.
14689         * tui/tui-winsource.h: Rename include guard.
14690         * tui/tui-wingeneral.h: Rename include guard.
14691         * tui/tui-windata.h: Rename include guard.
14692         * tui/tui-win.h: Rename include guard.
14693         * tui/tui-stack.h: Rename include guard.
14694         * tui/tui-source.h: Rename include guard.
14695         * tui/tui-regs.h: Rename include guard.
14696         * tui/tui-out.h: Rename include guard.
14697         * tui/tui-layout.h: Rename include guard.
14698         * tui/tui-io.h: Rename include guard.
14699         * tui/tui-hooks.h: Rename include guard.
14700         * tui/tui-file.h: Rename include guard.
14701         * tui/tui-disasm.h: Rename include guard.
14702         * tui/tui-data.h: Rename include guard.
14703         * tui/tui-command.h: Rename include guard.
14704         * tic6x-tdep.h: Add include guard.
14705         * target/waitstatus.h: Rename include guard.
14706         * target/wait.h: Rename include guard.
14707         * target/target.h: Rename include guard.
14708         * target/resume.h: Rename include guard.
14709         * target-float.h: Rename include guard.
14710         * stabsread.h: Add include guard.
14711         * rs6000-tdep.h: Add include guard.
14712         * riscv-fbsd-tdep.h: Add include guard.
14713         * regformats/regdef.h: Rename include guard.
14714         * record.h: Rename include guard.
14715         * python/python.h: Rename include guard.
14716         * python/python-internal.h: Rename include guard.
14717         * python/py-stopevent.h: Rename include guard.
14718         * python/py-ref.h: Rename include guard.
14719         * python/py-record.h: Rename include guard.
14720         * python/py-record-full.h: Rename include guard.
14721         * python/py-record-btrace.h: Rename include guard.
14722         * python/py-instruction.h: Rename include guard.
14723         * python/py-events.h: Rename include guard.
14724         * python/py-event.h: Rename include guard.
14725         * procfs.h: Add include guard.
14726         * proc-utils.h: Add include guard.
14727         * p-lang.h: Add include guard.
14728         * or1k-tdep.h: Rename include guard.
14729         * observable.h: Rename include guard.
14730         * nto-tdep.h: Rename include guard.
14731         * nat/x86-linux.h: Rename include guard.
14732         * nat/x86-linux-dregs.h: Rename include guard.
14733         * nat/x86-gcc-cpuid.h: Add include guard.
14734         * nat/x86-dregs.h: Rename include guard.
14735         * nat/x86-cpuid.h: Rename include guard.
14736         * nat/ppc-linux.h: Rename include guard.
14737         * nat/mips-linux-watch.h: Rename include guard.
14738         * nat/linux-waitpid.h: Rename include guard.
14739         * nat/linux-ptrace.h: Rename include guard.
14740         * nat/linux-procfs.h: Rename include guard.
14741         * nat/linux-osdata.h: Rename include guard.
14742         * nat/linux-nat.h: Rename include guard.
14743         * nat/linux-namespaces.h: Rename include guard.
14744         * nat/linux-btrace.h: Rename include guard.
14745         * nat/glibc_thread_db.h: Rename include guard.
14746         * nat/gdb_thread_db.h: Rename include guard.
14747         * nat/gdb_ptrace.h: Rename include guard.
14748         * nat/fork-inferior.h: Rename include guard.
14749         * nat/amd64-linux-siginfo.h: Rename include guard.
14750         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14751         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14752         * nat/aarch64-linux.h: Rename include guard.
14753         * nat/aarch64-linux-hw-point.h: Rename include guard.
14754         * mn10300-tdep.h: Add include guard.
14755         * mips-linux-tdep.h: Add include guard.
14756         * mi/mi-parse.h: Rename include guard.
14757         * mi/mi-out.h: Rename include guard.
14758         * mi/mi-main.h: Rename include guard.
14759         * mi/mi-interp.h: Rename include guard.
14760         * mi/mi-getopt.h: Rename include guard.
14761         * mi/mi-console.h: Rename include guard.
14762         * mi/mi-common.h: Rename include guard.
14763         * mi/mi-cmds.h: Rename include guard.
14764         * mi/mi-cmd-break.h: Rename include guard.
14765         * m2-lang.h: Add include guard.
14766         * location.h: Rename include guard.
14767         * linux-record.h: Rename include guard.
14768         * linux-nat.h: Add include guard.
14769         * linux-fork.h: Add include guard.
14770         * i386-darwin-tdep.h: Rename include guard.
14771         * hppa-linux-offsets.h: Add include guard.
14772         * guile/guile.h: Rename include guard.
14773         * guile/guile-internal.h: Rename include guard.
14774         * gnu-nat.h: Rename include guard.
14775         * gdb-stabs.h: Rename include guard.
14776         * frv-tdep.h: Add include guard.
14777         * f-lang.h: Add include guard.
14778         * event-loop.h: Add include guard.
14779         * darwin-nat.h: Rename include guard.
14780         * cp-abi.h: Rename include guard.
14781         * config/sparc/nm-sol2.h: Rename include guard.
14782         * config/nm-nto.h: Rename include guard.
14783         * config/nm-linux.h: Add include guard.
14784         * config/i386/nm-i386gnu.h: Rename include guard.
14785         * config/djgpp/nl_types.h: Rename include guard.
14786         * config/djgpp/langinfo.h: Rename include guard.
14787         * compile/gcc-cp-plugin.h: Add include guard.
14788         * compile/gcc-c-plugin.h: Add include guard.
14789         * compile/compile.h: Rename include guard.
14790         * compile/compile-object-run.h: Rename include guard.
14791         * compile/compile-object-load.h: Rename include guard.
14792         * compile/compile-internal.h: Rename include guard.
14793         * compile/compile-cplus.h: Rename include guard.
14794         * compile/compile-c.h: Rename include guard.
14795         * common/xml-utils.h: Rename include guard.
14796         * common/x86-xstate.h: Rename include guard.
14797         * common/version.h: Rename include guard.
14798         * common/vec.h: Rename include guard.
14799         * common/tdesc.h: Rename include guard.
14800         * common/selftest.h: Rename include guard.
14801         * common/scoped_restore.h: Rename include guard.
14802         * common/scoped_mmap.h: Rename include guard.
14803         * common/scoped_fd.h: Rename include guard.
14804         * common/safe-iterator.h: Rename include guard.
14805         * common/run-time-clock.h: Rename include guard.
14806         * common/refcounted-object.h: Rename include guard.
14807         * common/queue.h: Rename include guard.
14808         * common/ptid.h: Rename include guard.
14809         * common/print-utils.h: Rename include guard.
14810         * common/preprocessor.h: Rename include guard.
14811         * common/pathstuff.h: Rename include guard.
14812         * common/observable.h: Rename include guard.
14813         * common/netstuff.h: Rename include guard.
14814         * common/job-control.h: Rename include guard.
14815         * common/host-defs.h: Rename include guard.
14816         * common/gdb_wait.h: Rename include guard.
14817         * common/gdb_vecs.h: Rename include guard.
14818         * common/gdb_unlinker.h: Rename include guard.
14819         * common/gdb_unique_ptr.h: Rename include guard.
14820         * common/gdb_tilde_expand.h: Rename include guard.
14821         * common/gdb_sys_time.h: Rename include guard.
14822         * common/gdb_string_view.h: Rename include guard.
14823         * common/gdb_splay_tree.h: Rename include guard.
14824         * common/gdb_setjmp.h: Rename include guard.
14825         * common/gdb_ref_ptr.h: Rename include guard.
14826         * common/gdb_optional.h: Rename include guard.
14827         * common/gdb_locale.h: Rename include guard.
14828         * common/gdb_assert.h: Rename include guard.
14829         * common/filtered-iterator.h: Rename include guard.
14830         * common/filestuff.h: Rename include guard.
14831         * common/fileio.h: Rename include guard.
14832         * common/environ.h: Rename include guard.
14833         * common/common-utils.h: Rename include guard.
14834         * common/common-types.h: Rename include guard.
14835         * common/common-regcache.h: Rename include guard.
14836         * common/common-inferior.h: Rename include guard.
14837         * common/common-gdbthread.h: Rename include guard.
14838         * common/common-exceptions.h: Rename include guard.
14839         * common/common-defs.h: Rename include guard.
14840         * common/common-debug.h: Rename include guard.
14841         * common/cleanups.h: Rename include guard.
14842         * common/buffer.h: Rename include guard.
14843         * common/btrace-common.h: Rename include guard.
14844         * common/break-common.h: Rename include guard.
14845         * cli/cli-utils.h: Rename include guard.
14846         * cli/cli-style.h: Rename include guard.
14847         * cli/cli-setshow.h: Rename include guard.
14848         * cli/cli-script.h: Rename include guard.
14849         * cli/cli-interp.h: Rename include guard.
14850         * cli/cli-decode.h: Rename include guard.
14851         * cli/cli-cmds.h: Rename include guard.
14852         * charset-list.h: Add include guard.
14853         * buildsym-legacy.h: Rename include guard.
14854         * bfin-tdep.h: Add include guard.
14855         * ax.h: Rename include guard.
14856         * arm-linux-tdep.h: Add include guard.
14857         * arm-fbsd-tdep.h: Add include guard.
14858         * arch/xtensa.h: Rename include guard.
14859         * arch/tic6x.h: Add include guard.
14860         * arch/i386.h: Add include guard.
14861         * arch/arm.h: Rename include guard.
14862         * arch/arm-linux.h: Rename include guard.
14863         * arch/arm-get-next-pcs.h: Rename include guard.
14864         * arch/amd64.h: Add include guard.
14865         * arch/aarch64-insn.h: Rename include guard.
14866         * arch-utils.h: Rename include guard.
14867         * annotate.h: Add include guard.
14868         * amd64-darwin-tdep.h: Rename include guard.
14869         * aarch64-linux-tdep.h: Add include guard.
14870         * aarch64-fbsd-tdep.h: Add include guard.
14871         * aarch32-linux-nat.h: Add include guard.
14872
14873 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14874
14875         * macrotab.c (macro_define_internal): New function that
14876         factorizes macro_define_object_internal and macro_define_function
14877         code.
14878         (macro_define_object_internal): Use macro_define_internal.
14879         (macro_define_function): Likewise.
14880
14881 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14882
14883         * macrocmd.c (extract_identifier): Return
14884         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14885         callers.
14886
14887 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14888
14889         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14890
14891 2019-02-05  Tom Tromey  <tom@tromey.com>
14892
14893         * target.c (target_stack::unpush): Move assertion earlier.
14894
14895 2019-01-30  Tom Tromey  <tom@tromey.com>
14896
14897         PR python/23615:
14898         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14899         (gdbpy_parse_and_eval): Likewise.
14900         * python/python-internal.h (gdbpy_allow_threads): New class.
14901
14902 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14903
14904         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14905         (aarch64_fbsd_fpregmap): Move earlier.
14906         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14907         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14908         instead of individual calls to trad_frame_set_reg_addr.
14909         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14910         earlier.
14911         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14912         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14913         instead of individual calls to trad_frame_set_reg_addr.
14914
14915 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14916
14917         * CONTRIBUTE: Replace contribution list with wiki link.
14918
14919 2019-01-25  Tom Tromey  <tom@tromey.com>
14920
14921         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14922
14923 2019-01-25  Tom Tromey  <tom@tromey.com>
14924
14925         * xtensa-linux-nat.c: Fix common/ includes.
14926         * xml-support.h: Fix common/ includes.
14927         * xml-support.c: Fix common/ includes.
14928         * x86-linux-nat.c: Fix common/ includes.
14929         * windows-nat.c: Fix common/ includes.
14930         * varobj.h: Fix common/ includes.
14931         * varobj.c: Fix common/ includes.
14932         * value.c: Fix common/ includes.
14933         * valops.c: Fix common/ includes.
14934         * utils.c: Fix common/ includes.
14935         * unittests/xml-utils-selftests.c: Fix common/ includes.
14936         * unittests/utils-selftests.c: Fix common/ includes.
14937         * unittests/unpack-selftests.c: Fix common/ includes.
14938         * unittests/tracepoint-selftests.c: Fix common/ includes.
14939         * unittests/style-selftests.c: Fix common/ includes.
14940         * unittests/string_view-selftests.c: Fix common/ includes.
14941         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14942         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14943         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14944         * unittests/rsp-low-selftests.c: Fix common/ includes.
14945         * unittests/parse-connection-spec-selftests.c: Fix common/
14946         includes.
14947         * unittests/optional-selftests.c: Fix common/ includes.
14948         * unittests/offset-type-selftests.c: Fix common/ includes.
14949         * unittests/observable-selftests.c: Fix common/ includes.
14950         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14951         * unittests/memrange-selftests.c: Fix common/ includes.
14952         * unittests/memory-map-selftests.c: Fix common/ includes.
14953         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14954         * unittests/function-view-selftests.c: Fix common/ includes.
14955         * unittests/environ-selftests.c: Fix common/ includes.
14956         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14957         * unittests/common-utils-selftests.c: Fix common/ includes.
14958         * unittests/cli-utils-selftests.c: Fix common/ includes.
14959         * unittests/array-view-selftests.c: Fix common/ includes.
14960         * ui-file.c: Fix common/ includes.
14961         * tui/tui-io.c: Fix common/ includes.
14962         * tracepoint.h: Fix common/ includes.
14963         * tracepoint.c: Fix common/ includes.
14964         * tracefile-tfile.c: Fix common/ includes.
14965         * top.h: Fix common/ includes.
14966         * top.c: Fix common/ includes.
14967         * thread.c: Fix common/ includes.
14968         * target/waitstatus.h: Fix common/ includes.
14969         * target/waitstatus.c: Fix common/ includes.
14970         * target.h: Fix common/ includes.
14971         * target.c: Fix common/ includes.
14972         * target-memory.c: Fix common/ includes.
14973         * target-descriptions.c: Fix common/ includes.
14974         * symtab.h: Fix common/ includes.
14975         * symfile.c: Fix common/ includes.
14976         * stap-probe.c: Fix common/ includes.
14977         * spu-linux-nat.c: Fix common/ includes.
14978         * sparc-nat.c: Fix common/ includes.
14979         * source.c: Fix common/ includes.
14980         * solib.c: Fix common/ includes.
14981         * solib-target.c: Fix common/ includes.
14982         * ser-unix.c: Fix common/ includes.
14983         * ser-tcp.c: Fix common/ includes.
14984         * ser-pipe.c: Fix common/ includes.
14985         * ser-base.c: Fix common/ includes.
14986         * selftest-arch.c: Fix common/ includes.
14987         * s12z-tdep.c: Fix common/ includes.
14988         * rust-exp.y: Fix common/ includes.
14989         * rs6000-aix-tdep.c: Fix common/ includes.
14990         * riscv-tdep.c: Fix common/ includes.
14991         * remote.c: Fix common/ includes.
14992         * remote-notif.h: Fix common/ includes.
14993         * remote-fileio.h: Fix common/ includes.
14994         * remote-fileio.c: Fix common/ includes.
14995         * regcache.h: Fix common/ includes.
14996         * regcache.c: Fix common/ includes.
14997         * record-btrace.c: Fix common/ includes.
14998         * python/python.c: Fix common/ includes.
14999         * python/py-type.c: Fix common/ includes.
15000         * python/py-inferior.c: Fix common/ includes.
15001         * progspace.h: Fix common/ includes.
15002         * producer.c: Fix common/ includes.
15003         * procfs.c: Fix common/ includes.
15004         * proc-api.c: Fix common/ includes.
15005         * printcmd.c: Fix common/ includes.
15006         * ppc-linux-nat.c: Fix common/ includes.
15007         * parser-defs.h: Fix common/ includes.
15008         * osdata.c: Fix common/ includes.
15009         * obsd-nat.c: Fix common/ includes.
15010         * nat/x86-linux.c: Fix common/ includes.
15011         * nat/x86-linux-dregs.c: Fix common/ includes.
15012         * nat/x86-dregs.h: Fix common/ includes.
15013         * nat/x86-dregs.c: Fix common/ includes.
15014         * nat/ppc-linux.c: Fix common/ includes.
15015         * nat/mips-linux-watch.h: Fix common/ includes.
15016         * nat/mips-linux-watch.c: Fix common/ includes.
15017         * nat/linux-waitpid.c: Fix common/ includes.
15018         * nat/linux-ptrace.h: Fix common/ includes.
15019         * nat/linux-ptrace.c: Fix common/ includes.
15020         * nat/linux-procfs.c: Fix common/ includes.
15021         * nat/linux-personality.c: Fix common/ includes.
15022         * nat/linux-osdata.c: Fix common/ includes.
15023         * nat/linux-namespaces.c: Fix common/ includes.
15024         * nat/linux-btrace.h: Fix common/ includes.
15025         * nat/linux-btrace.c: Fix common/ includes.
15026         * nat/fork-inferior.c: Fix common/ includes.
15027         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15028         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15029         * nat/aarch64-linux.c: Fix common/ includes.
15030         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15031         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15032         * namespace.h: Fix common/ includes.
15033         * mips-linux-tdep.c: Fix common/ includes.
15034         * minsyms.c: Fix common/ includes.
15035         * mi/mi-parse.h: Fix common/ includes.
15036         * mi/mi-main.c: Fix common/ includes.
15037         * mi/mi-cmd-env.c: Fix common/ includes.
15038         * memrange.h: Fix common/ includes.
15039         * memattr.c: Fix common/ includes.
15040         * maint.h: Fix common/ includes.
15041         * maint.c: Fix common/ includes.
15042         * main.c: Fix common/ includes.
15043         * machoread.c: Fix common/ includes.
15044         * location.c: Fix common/ includes.
15045         * linux-thread-db.c: Fix common/ includes.
15046         * linux-nat.c: Fix common/ includes.
15047         * linux-fork.c: Fix common/ includes.
15048         * inline-frame.c: Fix common/ includes.
15049         * infrun.c: Fix common/ includes.
15050         * inflow.c: Fix common/ includes.
15051         * inferior.h: Fix common/ includes.
15052         * inferior.c: Fix common/ includes.
15053         * infcmd.c: Fix common/ includes.
15054         * inf-ptrace.c: Fix common/ includes.
15055         * inf-child.c: Fix common/ includes.
15056         * ia64-linux-nat.c: Fix common/ includes.
15057         * i387-tdep.c: Fix common/ includes.
15058         * i386-tdep.c: Fix common/ includes.
15059         * i386-linux-tdep.c: Fix common/ includes.
15060         * i386-linux-nat.c: Fix common/ includes.
15061         * i386-go32-tdep.c: Fix common/ includes.
15062         * i386-fbsd-tdep.c: Fix common/ includes.
15063         * i386-fbsd-nat.c: Fix common/ includes.
15064         * guile/scm-type.c: Fix common/ includes.
15065         * guile/guile.c: Fix common/ includes.
15066         * go32-nat.c: Fix common/ includes.
15067         * gnu-nat.c: Fix common/ includes.
15068         * gdbthread.h: Fix common/ includes.
15069         * gdbarch-selftests.c: Fix common/ includes.
15070         * gdb_usleep.c: Fix common/ includes.
15071         * gdb_select.h: Fix common/ includes.
15072         * gdb_bfd.c: Fix common/ includes.
15073         * gcore.c: Fix common/ includes.
15074         * fork-child.c: Fix common/ includes.
15075         * findvar.c: Fix common/ includes.
15076         * fbsd-nat.c: Fix common/ includes.
15077         * event-top.c: Fix common/ includes.
15078         * event-loop.c: Fix common/ includes.
15079         * dwarf2read.c: Fix common/ includes.
15080         * dwarf2loc.c: Fix common/ includes.
15081         * dwarf2-frame.c: Fix common/ includes.
15082         * dwarf-index-cache.c: Fix common/ includes.
15083         * dtrace-probe.c: Fix common/ includes.
15084         * disasm-selftests.c: Fix common/ includes.
15085         * defs.h: Fix common/ includes.
15086         * csky-tdep.c: Fix common/ includes.
15087         * cp-valprint.c: Fix common/ includes.
15088         * cp-support.h: Fix common/ includes.
15089         * cp-support.c: Fix common/ includes.
15090         * corelow.c: Fix common/ includes.
15091         * completer.h: Fix common/ includes.
15092         * completer.c: Fix common/ includes.
15093         * compile/compile.c: Fix common/ includes.
15094         * compile/compile-loc2c.c: Fix common/ includes.
15095         * compile/compile-cplus-types.c: Fix common/ includes.
15096         * compile/compile-cplus-symbols.c: Fix common/ includes.
15097         * command.h: Fix common/ includes.
15098         * cli/cli-dump.c: Fix common/ includes.
15099         * cli/cli-cmds.c: Fix common/ includes.
15100         * charset.c: Fix common/ includes.
15101         * build-id.c: Fix common/ includes.
15102         * btrace.h: Fix common/ includes.
15103         * btrace.c: Fix common/ includes.
15104         * breakpoint.h: Fix common/ includes.
15105         * breakpoint.c: Fix common/ includes.
15106         * ax.h:
15107         (enum agent_op): Fix common/ includes.
15108         * ax-general.c (struct aop_map): Fix common/ includes.
15109         * ax-gdb.c: Fix common/ includes.
15110         * auxv.c: Fix common/ includes.
15111         * auto-load.c: Fix common/ includes.
15112         * arm-tdep.c: Fix common/ includes.
15113         * arch/riscv.c: Fix common/ includes.
15114         * arch/ppc-linux-common.c: Fix common/ includes.
15115         * arch/i386.c: Fix common/ includes.
15116         * arch/arm.c: Fix common/ includes.
15117         * arch/arm-linux.c: Fix common/ includes.
15118         * arch/arm-get-next-pcs.c: Fix common/ includes.
15119         * arch/amd64.c: Fix common/ includes.
15120         * arch/aarch64.c: Fix common/ includes.
15121         * arch/aarch64-insn.c: Fix common/ includes.
15122         * arch-utils.c: Fix common/ includes.
15123         * amd64-windows-tdep.c: Fix common/ includes.
15124         * amd64-tdep.c: Fix common/ includes.
15125         * amd64-sol2-tdep.c: Fix common/ includes.
15126         * amd64-obsd-tdep.c: Fix common/ includes.
15127         * amd64-nbsd-tdep.c: Fix common/ includes.
15128         * amd64-linux-tdep.c: Fix common/ includes.
15129         * amd64-linux-nat.c: Fix common/ includes.
15130         * amd64-fbsd-tdep.c: Fix common/ includes.
15131         * amd64-fbsd-nat.c: Fix common/ includes.
15132         * amd64-dicos-tdep.c: Fix common/ includes.
15133         * amd64-darwin-tdep.c: Fix common/ includes.
15134         * agent.c: Fix common/ includes.
15135         * ada-lang.h: Fix common/ includes.
15136         * ada-lang.c: Fix common/ includes.
15137         * aarch64-tdep.c: Fix common/ includes.
15138
15139 2019-01-25  Tom Tromey  <tom@tromey.com>
15140
15141         * common/create-version.sh: Use common/version.h.
15142
15143 2019-01-24  Pedro Alves  <palves@redhat.com>
15144
15145         * infrun.c (signal_stop, signal_print, signal_program)
15146         (signal_catch, signal_pass): Now arrays instead of pointers.
15147         (update_signals_program_target, do_target_resume)
15148         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15149         * linux-nat.c (linux_nat_target::pass_signals)
15150         (linux_nat_target::create_inferior, linux_nat_target::attach):
15151         Adjust.
15152         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15153         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15154         * procfs.c (procfs_target::pass_signals): Adjust.
15155         * record-full.c (record_full_target::resume): Adjust.
15156         * remote.c (remote_target::pass_signals)
15157         (remote_target::program_signals): Adjust.
15158         * target-debug.h (target_debug_print_signals): Now takes a
15159         gdb::array_view as parameter.  Adjust.
15160         * target.h (target_ops) <pass_signals, program_signals>: Replace
15161         pointer and length parameters with gdb::array_view.
15162         (target_pass_signals, target_program_signals): Likewise.
15163         * target-delegates.c: Regenerate.
15164
15165 2019-01-24  Pedro Alves  <palves@redhat.com>
15166
15167         * common/forward-scope-exit.h
15168         (forward_scope_exit::forward_scope_exit): Pass arguments to
15169         m_bind_function directly, instead of creating a std::bind and
15170         copying that.
15171
15172 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15173
15174         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15175         for static members.
15176         (pass_in_v_vfp_candidate): Likewise.
15177
15178 2019-01-23  Tom Tromey  <tom@tromey.com>
15179             Pedro Alves  <palves@redhat.com>
15180
15181         * regcache.c (class regcache_invalidator): Remove.
15182         (regcache::raw_write): Use make_scope_exit.
15183
15184 2019-01-23  Tom Tromey  <tom@tromey.com>
15185
15186         * ui-out.h (class ui_out_emit_type): Update comment.
15187
15188 2019-01-23  Tom Tromey  <tom@tromey.com>
15189
15190         * infrun.c (fetch_inferior_event): Update comment.
15191
15192 2019-01-23  Tom Tromey  <tom@tromey.com>
15193             Pedro Alves  <palves@redhat.com>
15194
15195         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15196         parameter.
15197         (fetch_inferior_event): Use SCOPE_EXIT.
15198
15199
15200 2019-01-23  Tom Tromey  <tom@tromey.com>
15201             Pedro Alves  <palves@redhat.com>
15202
15203         * infrun.c (disable_thread_events): Delete.
15204         (stop_all_threads): Use SCOPE_EXIT.
15205
15206 2019-01-23  Tom Tromey  <tom@tromey.com>
15207             Pedro Alves  <palves@redhat.com>
15208
15209         * symfile.c: Include forward-scope-exit.h.
15210         (clear_symtab_users_cleanup): Replace forward declaration with
15211         a FORWARD_SCOPE_EXIT.
15212         (syms_from_objfile_1): Use the forward_scope_exit and
15213         gdb::optional instead of cleanup_function.
15214         (reread_symbols): Use the forward_scope_exit instead of
15215         cleanup_function.
15216         (clear_symtab_users_cleanup): Remove function.
15217
15218 2019-01-23  Tom Tromey  <tom@tromey.com>
15219             Pedro Alves  <palves@redhat.com>
15220
15221         * linux-nat.c: Include scope-exit.h.
15222         (cleanup_target_stop): Remove.
15223         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15224         SCOPE_EXIT.
15225
15226 2019-01-23  Tom Tromey  <tom@tromey.com>
15227             Pedro Alves  <palves@redhat.com>
15228
15229         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15230         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15231
15232 2019-01-23  Tom Tromey  <tom@tromey.com>
15233             Andrew Burgess  <andrew.burgess@embecosm.com>
15234             Pedro Alves  <palves@redhat.com>
15235
15236         * infrun.c (fetch_inferior_event): Use scope_exit.
15237         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15238         * top.c (execute_command): Use scope_exit.
15239         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15240         * utils.c (do_bpstat_clear_actions_cleanup)
15241         (make_bpstat_clear_actions_cleanup): Remove.
15242
15243 2019-01-23  Tom Tromey  <tom@tromey.com>
15244             Pedro Alves  <palves@redhat.com>
15245
15246         * infrun.c: Include "common/scope-exit.h"
15247         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15248         (wait_for_inferior): Use SCOPE_EXIT.
15249         (fetch_inferior_event): Use scope_exit.
15250
15251 2019-01-23  Tom Tromey  <tom@tromey.com>
15252             Pedro Alves  <palves@redhat.com>
15253
15254         * breakpoint.c (create_breakpoint): Remove cleanup.
15255
15256 2019-01-23  Tom Tromey  <tom@tromey.com>
15257             Andrew Burgess  <andrew.burgess@embecosm.com>
15258             Pedro Alves  <palves@redhat.com>
15259
15260 2019-01-23  Pedro Alves  <palves@redhat.com>
15261
15262         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15263
15264 2019-01-23  Pedro Alves  <palves@redhat.com>
15265             Andrew Burgess  <andrew.burgess@embecosm.com>
15266
15267         * gdbthread.h: Include "common/forward-scope-exit.h".
15268         (scoped_finish_thread_state): Redefine custom class in terms of
15269         forward_scope_exit.
15270
15271 2019-01-23  Pedro Alves  <palves@redhat.com>
15272             Andrew Burgess  <andrew.burgess@embecosm.com>
15273
15274         * common/forward-scope-exit.h: New file.
15275
15276 2019-01-23  Pedro Alves  <palves@redhat.com>
15277             Andrew Burgess  <andrew.burgess@embecosm.com>
15278             Tom Tromey  <tom@tromey.com>
15279
15280         * common/scope-exit.h: New file.
15281
15282 2019-01-23  Pedro Alves  <palves@redhat.com>
15283
15284         * common/preprocessor.h (ESC): Rename to ...
15285         (ESC_PARENS): ... this.
15286         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15287         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15288
15289 2019-01-23  Tom Tromey  <tom@tromey.com>
15290
15291         * language.h (class scoped_switch_to_sym_language_if_auto):
15292         Initialize m_lang in both cases.
15293
15294 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15295
15296         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15297         with XCNEW.
15298
15299 2019-01-22  Tom Tromey  <tom@tromey.com>
15300
15301         * corelow.c: Do not include sys/file.h.
15302
15303 2019-01-22  Tom Tromey  <tom@tromey.com>
15304
15305         * tui/tui-wingeneral.h: Include gdb_curses.h.
15306
15307 2019-01-22  Tom Tromey  <tom@tromey.com>
15308
15309         * source-cache.h (class source_cache) <get_source_lines,
15310         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15311
15312 2019-01-22  Tom Tromey  <tom@tromey.com>
15313
15314         * remote-fileio.h (struct remote_target): Declare.
15315
15316 2019-01-22  Tom Tromey  <tom@tromey.com>
15317
15318         * python/py-arch.c: Do not include py-ref.h.
15319         * python/py-bpevent.c: Do not include py-ref.h.
15320         * python/py-cmd.c: Do not include py-ref.h.
15321         * python/py-continueevent.c: Do not include py-ref.h.
15322         * python/py-event.h: Do not include py-ref.h.
15323         * python/py-evtregistry.c: Do not include py-ref.h.
15324         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15325         * python/py-frame.c: Do not include py-ref.h.
15326         * python/py-framefilter.c: Do not include py-ref.h.
15327         * python/py-function.c: Do not include py-ref.h.
15328         * python/py-infevents.c: Do not include py-ref.h.
15329         * python/py-linetable.c: Do not include py-ref.h.
15330         * python/py-objfile.c: Do not include py-ref.h.
15331         * python/py-param.c: Do not include py-ref.h.
15332         * python/py-prettyprint.c: Do not include py-ref.h.
15333         * python/py-progspace.c: Do not include py-ref.h.
15334         * python/py-symbol.c: Do not include py-ref.h.
15335         * python/py-symtab.c: Do not include py-ref.h.
15336         * python/py-type.c: Do not include py-ref.h.
15337         * python/py-unwind.c: Do not include py-ref.h.
15338         * python/py-utils.c: Do not include py-ref.h.
15339         * python/py-value.c: Do not include py-ref.h.
15340         * python/py-varobj.c: Do not include py-ref.h.
15341         * python/py-xmethods.c: Do not include py-ref.h.
15342         * python/python.c: Do not include py-ref.h.
15343         * varobj.c: Do not include py-ref.h.
15344
15345 2019-01-22  Tom Tromey  <tom@tromey.com>
15346
15347         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15348         keyword for bcache.
15349
15350 2019-01-22  Tom Tromey  <tom@tromey.com>
15351
15352         * compile/compile-cplus-types.c: Remove a comment by #include.
15353
15354 2019-01-22  Tom Tromey  <tom@tromey.com>
15355
15356         * compile/gcc-c-plugin.h: Include compile-internal.h.
15357
15358 2019-01-22  Tom Tromey  <tom@tromey.com>
15359
15360         * stabsread.c (EXTERN): Do not define.
15361         (symnum, next_symbol_text_func, processing_gcc_compilation)
15362         (within_function, global_sym_chain, global_stabs)
15363         (previous_stab_code, this_object_header_files)
15364         (n_this_object_header_files)
15365         (n_allocated_this_object_header_files): Define.
15366         * stabsread.h (EXTERN): Never define.  Use "extern".
15367
15368 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15369
15370         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15371         history_value.
15372
15373 2019-01-21  Tom Tromey  <tom@tromey.com>
15374
15375         * ui-out.c: Fix includes.
15376         * tui/tui-source.c: Fix includes.
15377         * target.c: Fix includes.
15378         * remote.c: Fix includes.
15379         * regcache.c: Fix includes.
15380         * python/py-block.c: Fix includes.
15381         * printcmd.c: Fix includes.
15382         * or1k-tdep.c: Fix includes.
15383         * mi/mi-main.c: Fix includes.
15384         * m32r-tdep.c: Fix includes.
15385         * csky-tdep.c: Fix includes.
15386         * compile/compile-cplus-types.c: Fix includes.
15387         * cli/cli-interp.c: Fix includes.
15388
15389 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15390
15391         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15392         for padding.
15393
15394 2019-01-16  Tom Tromey  <tom@tromey.com>
15395
15396         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15397         earlier.
15398         (struct objfile) <msymbols_range>: Move from top level.
15399         <msymbols>: New method.
15400         (class objfile_msymbols): Remove.
15401         * symtab.c (default_collect_symbol_completion_matches_break_on):
15402         Update.
15403         * symmisc.c (dump_msymbols): Update.
15404         * stabsread.c (scan_file_globals): Update.
15405         * objc-lang.c (info_selectors_command, info_classes_command)
15406         (find_methods): Update.
15407         * minsyms.c (find_solib_trampoline_target): Update.
15408         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15409         * coffread.c (coff_symfile_read): Update.
15410         * ada-lang.c (ada_lookup_simple_minsym)
15411         (ada_collect_symbol_completion_matches): Update.
15412
15413 2019-01-16  Tom Tromey  <tom@tromey.com>
15414
15415         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15416         type.  Remove no-argument constructor.
15417         <iterator::operator++>: Simplify.
15418         <begin>: Update.
15419         <end>: Use minimal_symbol_count.
15420
15421 2019-01-16  Tom Tromey  <tom@tromey.com>
15422
15423         * objfiles.h (struct objfile) <psymtabs>: New method.
15424         (class objfile_psymtabs): Remove.
15425         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15426         typedef.
15427         <range>: New method.
15428         (require_partial_symbols): Change return type.
15429         * psymtab.c (require_partial_symbols)
15430         (psym_expand_symtabs_matching): Update.
15431         * mdebugread.c (parse_partial_symbols): Update.
15432         * dbxread.c (dbx_end_psymtab): Update.
15433
15434 2019-01-15  Tom Tromey  <tom@tromey.com>
15435
15436         * symtab.c (lookup_objfile_from_block)
15437         (lookup_symbol_in_objfile_symtabs)
15438         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15439         (find_line_symtab, info_sources_command)
15440         (default_collect_symbol_completion_matches_break_on)
15441         (make_source_files_completion_list): Update.
15442         * symmisc.c (print_objfile_statistics, dump_objfile)
15443         (maintenance_print_symbols, maintenance_info_symtabs)
15444         (maintenance_check_symtabs, maintenance_info_line_tables):
15445         Update.
15446         * source.c (select_source_symtab)
15447         (forget_cached_source_info_for_objfile): Update.
15448         * objfiles.h (class objfile_compunits): Remove.
15449         (struct objfile) <compunits_range>: New typedef.
15450         (compunits): New method.
15451         * objfiles.c (objfile_relocate1): Update.
15452         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15453         * maint.c (count_symtabs_and_blocks): Update.
15454         * linespec.c (iterate_over_all_matching_symtabs): Update.
15455         * cp-support.c (add_symbol_overload_list_qualified): Update.
15456         * coffread.c (coff_symtab_read): Update.
15457         * ada-lang.c (add_nonlocal_symbols)
15458         (ada_collect_symbol_completion_matches)
15459         (ada_add_global_exceptions): Update.
15460
15461 2019-01-15  Tom Tromey  <tom@tromey.com>
15462
15463         * progspace.h (program_space) <objfiles_safe_range>: New
15464         typedef.
15465         <objfiles_safe>: New method.
15466         * objfiles.h (class all_objfiles_safe): Remove.
15467         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15468         * jit.c (jit_inferior_exit_hook): Update.
15469
15470 2019-01-17  Tom Tromey  <tom@tromey.com>
15471
15472         * progspace.h (program_space) <objfiles_range>: New typedef.
15473         <objfiles>: New method.
15474         <objfiles_head>: Rename from objfiles.
15475         (object_files): Update.
15476         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15477         * guile/scm-pretty-print.c
15478         (ppscm_find_pretty_printer_from_objfiles): Update.
15479         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15480         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15481         Update.
15482         * python/py-progspace.c (pspy_get_objfiles): Update.
15483         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15484         Update.
15485         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15486         (objfpy_lookup_objfile_by_build_id): Update.
15487         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15488         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15489         Update.
15490         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15491         (expand_symtab_containing_pc, lookup_objfile_from_block)
15492         (lookup_static_symbol, basic_lookup_transparent_type)
15493         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15494         (find_line_symtab, info_sources_command)
15495         (default_collect_symbol_completion_matches_break_on)
15496         (make_source_files_completion_list, find_main_name): Update.
15497         * symmisc.c (print_symbol_bcache_statistics)
15498         (print_objfile_statistics, maintenance_print_symbols)
15499         (maintenance_print_msymbols, maintenance_print_objfiles)
15500         (maintenance_info_symtabs, maintenance_check_symtabs)
15501         (maintenance_expand_symtabs, maintenance_info_line_tables):
15502         Update.
15503         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15504         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15505         (map_overlay_command, unmap_overlay_command)
15506         (simple_overlay_update, expand_symtabs_matching)
15507         (map_symbol_filenames): Update.
15508         * symfile-debug.c (set_debug_symfile): Update.
15509         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15510         Update.
15511         * source.c (select_source_symtab, forget_cached_source_info):
15512         Update.
15513         * solib.c (solib_read_symbols): Update.
15514         * solib-spu.c (append_ocl_sos): Update.
15515         * psymtab.c (maintenance_print_psymbols)
15516         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15517         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15518         * printcmd.c (info_symbol_command): Update.
15519         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15520         Update.
15521         * objfiles.h (class all_objfiles): Remove.
15522         * objfiles.c (have_partial_symbols, have_full_symbols)
15523         (have_minimal_symbols, qsort_cmp, update_section_map)
15524         (shared_objfile_contains_address_p)
15525         (default_iterate_over_objfiles_in_search_order): Update.
15526         * objc-lang.c (info_selectors_command, info_classes_command)
15527         (find_methods): Update.
15528         * minsyms.c (find_solib_trampoline_target): Update.
15529         * maint.c (maintenance_info_sections)
15530         (maintenance_translate_address, count_symtabs_and_blocks):
15531         Update.
15532         * main.c (captured_main_1): Update.
15533         * linux-thread-db.c (try_thread_db_load_from_pdir)
15534         (has_libpthread): Update.
15535         * linespec.c (iterate_over_all_matching_symtabs)
15536         (search_minsyms_for_name): Update.
15537         * jit.c (jit_find_objf_with_entry_addr): Update.
15538         * hppa-tdep.c (find_unwind_entry)
15539         (hppa_lookup_stub_minimal_symbol): Update.
15540         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15541         Update.
15542         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15543         (elf_gnu_ifunc_resolve_by_got): Update.
15544         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15545         * dwarf-index-write.c (save_gdb_index_command): Update.
15546         * cp-support.c (add_symbol_overload_list_qualified): Update.
15547         * breakpoint.c (create_overlay_event_breakpoint)
15548         (create_longjmp_master_breakpoint)
15549         (create_std_terminate_master_breakpoint)
15550         (create_exception_master_breakpoint): Update.
15551         * blockframe.c (find_pc_partial_function): Update.
15552         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15553         (ada_collect_symbol_completion_matches)
15554         (ada_add_global_exceptions): Update.
15555
15556 2019-01-17  Tom Tromey  <tom@tromey.com>
15557
15558         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15559         declare VEC.
15560         (solib_target_parse_libraries): Change return type.
15561         (library_list_start_segment, library_list_start_section)
15562         (library_list_end_library, library_list_start_library); Update.
15563         (solib_target_free_library_list): Remove.
15564         (solib_target_parse_libraries): Remove cleanup.  Change return
15565         type.
15566         (solib_target_current_sos): Update.
15567
15568 2019-01-17  Tom Tromey  <tromey@bapiya>
15569
15570         * valprint.c: Replace "the the" with "the".
15571         * symtab.c: Replace "the the" with "the".
15572         * solib.c: Replace "the the" with "the".
15573         * solib-dsbt.c: Replace "the the" with "the".
15574         * linespec.c: Replace "the the" with "the".
15575         * dwarf2loc.h: Replace "the the" with "the".
15576         * amd64-windows-tdep.c: Replace "the the" with "the".
15577         * aarch64-tdep.c: Replace "the the" with "the".
15578
15579 2019-01-16  Keith Seitz  <keiths@redhat.com>
15580
15581         PR gdb/23773
15582         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15583         <builder>: Rename to ..
15584         <m_builder>: ... this and make private.
15585         (dwarf2_cu::get_builder): New method.  Change all users of
15586         `builder' to use this method.
15587         (dwarf2_start_symtab): Move to ...
15588         (dwarf2_cu::start_symtab): ... here.  Update all callers
15589         (setup_type_unit_groups): Move to ...
15590         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15591         callers.
15592         (dwarf2_cu::reset_builder): New method.
15593         (process_full_compunit, process_full_type_unit): Use
15594         dwarf2_cu::reset_builder.
15595         (follow_die_offset): Record the ancestor CU if it is different
15596         from the followed DIE's CU.
15597         (follow_die_sig_1): Likewise.
15598
15599 2019-01-15  Tom Tromey  <tom@tromey.com>
15600
15601         * remote.c (class remote_state) <buf>: Now a char_vector.
15602         <buf_size>: Remove.
15603         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15604         parameter.
15605         (remote_target::getpkt_or_notif_sane_1)
15606         (remote_target::getpkt_sane)
15607         (remote_target::getpkt_or_notif_sane): Likewise.
15608         (class remote_target) <putpkt>: New overload.
15609         (remote_target::read_frame): Change type of "buf_p".  Remove
15610         sizeof_p parameter.
15611         (packet_ok): New overload.
15612         (packet_check_result): New overload.
15613         Update all uses.
15614
15615 2019-01-14  Tom Tromey  <tom@tromey.com>
15616
15617         * remote-notif.c (handle_notification, remote_notif_ack)
15618         (remote_notif_parse): Make "buf" const.
15619         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15620         const.
15621         (remote_notif_parse, remote_notif_ack, handle_notification):
15622         Likewise.
15623         * remote.c (remote_notif_stop_parse): Make "buf" const.
15624         (remote_target::remote_parse_stop_reply): Make "buf" const.
15625         (remote_notif_stop_ack): Make "buf" const.
15626
15627 2019-01-14  Tom Tromey  <tom@tromey.com>
15628
15629         * remote.c (remote_console_output): Make parameter const.
15630
15631 2019-01-14  Tom Tromey  <tom@tromey.com>
15632
15633         * target-debug.h (target_debug_print_signals): Constify.
15634         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15635         * procfs.c (procfs_target::pass_signals): Update.
15636         * linux-nat.c (linux_nat_target::pass_signals): Update.
15637         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15638         * target-delegates.c: Rebuild.
15639         * remote.c (remote_target::program_signals): Update.
15640         (remote_target::pass_signals): Update.
15641         * target.c (target_pass_signals): Constify argument.
15642         (target_program_signals): Likewise.
15643         * target.h (struct target_ops) <pass_signals, program_signals>:
15644         Constify argument.
15645         (target_pass_signals, target_program_signals): Constify argument.
15646
15647 2019-01-14  Tom Tromey  <tom@tromey.com>
15648
15649         PR tui/28819:
15650         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15651
15652 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15653
15654         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15655         field.
15656         * rs6000-tdep.c: Include reggroups.h.
15657         (IS_V_ALIAS_PSEUDOREG): Define.
15658         (rs6000_register_name): Return names for the "vX" aliases.
15659         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15660         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15661         aliases.  Call default_register_reggroup_p for all other
15662         pseudo-registers.
15663         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15664         New functions.
15665         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15666         Handle "vX" aliases.
15667         (v_alias_pseudo_register_collect): New function.
15668         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15669         (rs6000_gdbarch_init): Initialize "vX" aliases as
15670         pseudo-registers.  Restore registration of
15671         rs6000_pseudo_register_reggroup_p with
15672         set_tdesc_pseudo_register_reggroup_p.
15673
15674 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15675
15676         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15677         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15678         set_gdbarch_num_pseudo_regs.
15679
15680 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15681
15682         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15683         Remove arg prefixname, add do_set and do_show.
15684         Add member functions set_list and show_list.
15685         * cli/cli-style.c (class cli_style_option): Update accordingly.
15686         (style_set_list): Move to file scope.
15687         (style_show_list): Likewise.
15688         (set_style): Call help_list.
15689         (show_style): Call cmd_show_list.
15690         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15691         Update to use the new macro.
15692
15693 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15694
15695         * ada-lang.c (_initialize_ada_language): Expand the help text
15696         for the "catch exception" command.
15697
15698 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15699
15700         * symtab.c (matching_obj_sections): Initialize obj,
15701         declare it closer to its usage.
15702
15703 2019-01-10  Tom Tromey  <tom@tromey.com>
15704
15705         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15706         (basic_inf_threads_range): Remove.
15707         (inf_threads_range, inf_non_exited_threads_range)
15708         (safe_inf_threads_range): Use next_adapter.
15709
15710 2019-01-10  Keith Seitz  <keiths@redhat.com>
15711
15712         PR gdb/23712
15713         PR symtab/23010
15714         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15715         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15716
15717 2019-01-10  Keith Seitz  <keiths@redhat.com>
15718
15719         PR gdb/23712
15720         PR symtab/23010
15721         * dictionary.c (pending_to_vector): Remove.
15722         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15723         Remove _1 suffix, replacing functions of the same name.  Update
15724         all callers.
15725         (dict_create_hashed, dict_create_hashed_expandable)
15726         (dict_create_linear, dict_create_linear_expandable, dict_free)
15727         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15728         Make functions static.
15729
15730 2019-01-10  Keith Seitz  <keiths@redhat.com>
15731
15732         PR gdb/23712
15733         PR symtab/23010
15734         * dictionary.h (struct dictionary): Replace declaration with
15735         multidictionary.
15736         (dict_create_hashed, dict_create_hashed_expandable)
15737         (dict_create_linear, dict_create_linear_expandable)
15738         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15739         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15740         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15741         taking multidictionary argument.
15742         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15743         * block.h (struct block) <dict>: Change to multidictionary
15744         and rename `multidict'.
15745         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15746         symmisc.c: Update all dictionary references to multidictionary.
15747
15748 2019-01-10  Keith Seitz  <keiths@redhat.com>
15749
15750         PR gdb/23712
15751         PR symtab/23010
15752         * dictionary.c: Include unordered_map.
15753         (pending_to_vector): New function.
15754         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15755         Rewrite the non-"_1" functions to take vector instead
15756         of linked list.
15757         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15758         "new" _1 versions of the same name.
15759         (multidictionary): Define.
15760         (std::hash<enum language): New definition.
15761         (collate_pending_symbols_by_language, mdict_create_hashed)
15762         (mdict_create_hashed_expandable, mdict_create_linear)
15763         (mdict_create_linear_expandable, mdict_free)
15764         (find_language_dictionary, create_new_language_dictionary)
15765         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15766         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15767         (mdict_size, mdict_empty): New functions.
15768         * dictionary.h (mdict_iterator): Define.
15769
15770 2019-01-10  Pedro Alves  <palves@redhat.com>
15771
15772         * breakpoint.c (read_uploaded_action)
15773         (create_tracepoint_from_upload): Adjust to use
15774         gdb::unique_xmalloc_ptr.
15775         * ctf.c (ctf_write_uploaded_tp):
15776         (SET_ARRAY_FIELD): Use emplace_back.
15777         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15778         * tracefile-tfile.c (tfile_write_uploaded_tp):
15779         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15780         gdb::unique_xmalloc_ptr.
15781         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15782         at_string, cond_string, cmd_strings>: Replace char pointers
15783         with gdb::unique_xmalloc_ptr.
15784
15785 2019-01-10  Pedro Alves  <palves@redhat.com>
15786
15787         * solib-target.c (library_list_start_library): Don't xstrdup name.
15788
15789 2019-01-10  Pedro Alves  <palves@redhat.com>
15790
15791         * mdebugread.c (parse_partial_symbols): Use
15792         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15793
15794 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15795
15796         * linux-fork.c (scoped_switch_fork_info)
15797         <~scoped_switch_fork_info>: Fix incorrect variable name.
15798
15799 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15800
15801         * linux-fork.c (scoped_switch_fork_info)
15802         <scoped_switch_fork_info>: Make explicit.
15803         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15804
15805 2019-01-10  Tom Tromey  <tom@tromey.com>
15806
15807         * objfiles.h (objfile::reset_psymtabs): Update.
15808         * objfiles.c (objfile::objfile): Update.
15809         * psymtab.h (psymtab_storage::obstack): Update.
15810         (psymtab_storage::m_obstack): Use gdb::optional.
15811         (class psymtab_storage): Update comment.  Remove objfile
15812         parameter.
15813         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15814
15815 2019-01-10  Tom Tromey  <tom@tromey.com>
15816
15817         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15818         <free_psymtabs>: Now private.
15819         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15820         (allocate_psymtab): Use new method.
15821
15822 2019-01-10  Tom Tromey  <tom@tromey.com>
15823
15824         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15825         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15826         * mdebugread.c (parse_partial_symbols): Use
15827         allocate_dependencies.
15828         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15829         allocate_dependencies.
15830         (process_psymtab_comp_unit_reader)
15831         (build_type_psymtab_dependencies): Likewise.
15832         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15833
15834 2019-01-10  Tom Tromey  <tom@tromey.com>
15835
15836         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15837         PSYMBOL_SET_LANGUAGE.
15838         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15839
15840 2019-01-10  Tom Tromey  <tom@tromey.com>
15841
15842         * psymtab.h (psymtab_storage::obstack): New method.
15843         <m_obstack>: Rename from obstack; now private.
15844         * psymtab.c (psymtab_storage): Update.
15845         * dwarf2read.c (create_addrmap_from_index)
15846         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15847         Update.
15848
15849 2019-01-10  Tom Tromey  <tom@tromey.com>
15850
15851         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15852         * objfiles.h (objfile::reset_psymtabs): New method.
15853
15854 2019-01-10  Tom Tromey  <tom@tromey.com>
15855
15856         * symmisc.c (print_symbol_bcache_statistics): Update.
15857         (print_objfile_statistics): Update.
15858         * symfile.c (reread_symbols): Update.
15859         * psymtab.h (class psymtab_storage): New.
15860         * psymtab.c (psymtab_storage): New constructor.
15861         (~psymtab_storage): New destructor.
15862         (require_partial_symbols): Update.
15863         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15864         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15865         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15866         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15867         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15868         (start_psymtab_common, end_psymtab_common)
15869         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15870         (allocate_psymtab): Update.
15871         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15872         Update.
15873         (dump_psymtab_addrmap, maintenance_print_psymbols)
15874         (maintenance_check_psymtabs): Update.
15875         (class objfile_psymtabs): Move to objfiles.h.
15876         * psympriv.h (discard_psymtab): Now inline.
15877         (psymtab_discarder::psymtab_discarder): Update.
15878         (psymtab_discarder::~psymtab_discarder): Update.
15879         (ALL_OBJFILE_PSYMTABS): Rewrite.
15880         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15881         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15882         Remove fields.
15883         <partial_symtabs>: New field.
15884         (class objfile_psymtabs): Move from psymtab.h.  Update.
15885         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15886         psymbol_cache.
15887         (objfile::~objfile): Don't destroy psymbol_cache.
15888         * mdebugread.c (parse_partial_symbols): Update.
15889         * dwarf2read.c (create_addrmap_from_index)
15890         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15891         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15892         (add_partial_subprogram, dwarf2_ranges_read): Update.
15893         * dwarf-index-write.c (write_address_map)
15894         (write_one_signatured_type, recursively_write_psymbols)
15895         (class debug_names, class debug_names, write_psymtabs_to_index):
15896         Update.
15897
15898 2019-01-10  Tom Tromey  <tom@tromey.com>
15899
15900         * symtab.h (SYMBOL_SET_NAMES): Update.
15901         (symbol_set_names): Update.
15902         (MSYMBOL_SET_NAMES): Update.
15903         * symtab.c (symbol_set_names): Change argument to be an
15904         objfile_per_bfd_storage.
15905         * psymtab.c (add_psymbol_to_bcache): Update.
15906         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15907
15908 2019-01-10  Tom Tromey  <tom@tromey.com>
15909
15910         * symtab.c (create_demangled_names_hash): Change argument to be an
15911         objfile_per_bfd_storage.
15912         (symbol_set_names): Update.
15913
15914 2019-01-10  Tom Tromey  <tom@tromey.com>
15915
15916         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15917         init_psymbol_list.
15918         * psymtab.c (init_psymbol_list): Do nothing if already called.
15919         * psympriv.h (init_psymbol_list): Add comment.
15920         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15921         init_psymbol_list.
15922         * dbxread.c (dbx_symfile_read): Unconditionally call
15923         init_psymbol_list.
15924
15925 2019-01-10  Tom Tromey  <tom@tromey.com>
15926
15927         * xcoffread.c (scan_xcoff_symtab): Update.
15928         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15929         "where".
15930         * mdebugread.c (parse_partial_symbols)
15931         (handle_psymbol_enumerators): Update.
15932         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15933         * dbxread.c (read_dbx_symtab): Update.
15934         * psympriv.h (psymbol_placement): New enum.
15935         (add_psymbol_to_list): Update.
15936
15937 2019-01-10  Tom Tromey  <tom@tromey.com>
15938
15939         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15940         static_psymbols parameters.
15941         (scan_xcoff_symtab): Update.
15942         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15943         static_psymbols parameters.
15944         * psympriv.h (start_psymtab_common): Update.
15945         * mdebugread.c (parse_partial_symbols): Update.
15946         * dwarf2read.c (create_partial_symtab): Update.
15947         * dbxread.c (read_dbx_symtab): Update.
15948         (start_psymtab): Remove global_psymbols and static_psymbols
15949         parameters.
15950
15951 2019-01-10  Tom Tromey  <tom@tromey.com>
15952
15953         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15954         * psymtab.c (allocate_psymtab): Add comment.
15955         * psympriv.h (allocate_psymtab): Add comment.
15956         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15957         initializations.
15958         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15959
15960 2019-01-10  Tom Tromey  <tom@tromey.com>
15961
15962         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15963         Don't declare.
15964         * mipsread.c: Include mdebugread.h.
15965         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15966         Declare.
15967         * elfread.c: Include mdebugread.h.
15968
15969 2019-01-09  Tom Tromey  <tom@tromey.com>
15970
15971         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15972         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15973         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15974         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15975         (psym_lookup_symbol, psym_find_last_source_symtab)
15976         (psym_forget_cached_source_info, psym_print_stats)
15977         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15978         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15979         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15980         (psym_find_compunit_symtab_by_address)
15981         (maintenance_print_psymbols, maintenance_info_psymtabs)
15982         (maintenance_check_psymtabs): Use ranged for.
15983         * psymtab.h (class objfile_psymtabs): New.
15984         (require_partial_symbols): Return objfile_psymtabs.
15985         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15986
15987 2019-01-09  Tom Tromey  <tom@tromey.com>
15988
15989         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15990         (find_pc_mapped_section, list_overlays_command)
15991         (map_overlay_command, unmap_overlay_command)
15992         (simple_overlay_update): Use all_objfiles.
15993         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15994         * printcmd.c (info_symbol_command): Use all_objfiles.
15995         * objfiles.h (ALL_OBJSECTIONS): Remove.
15996         * maint.c (maintenance_translate_address): Use all_objfiles.
15997         * gcore.c (gcore_create_callback): Use all_objfiles.
15998         (objfile_find_memory_regions): Likewise.
15999
16000 2019-01-09  Tom Tromey  <tom@tromey.com>
16001
16002         * symtab.c (find_line_symtab, info_sources_command)
16003         (make_source_files_completion_list): Use objfile_compunits.
16004         * source.c (select_source_symtab): Use objfile_compunits.
16005         * objfiles.h (struct objfile): Update comment.
16006         (ALL_OBJFILES): Remove.
16007         (ALL_FILETABS): Remove.
16008         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16009         objfile_compunits.
16010
16011 2019-01-09  Tom Tromey  <tom@tromey.com>
16012
16013         * symmisc.c (print_objfile_statistics, dump_objfile)
16014         (maintenance_print_symbols): Use compunit_filetabs.
16015         * source.c (forget_cached_source_info_for_objfile): Use
16016         compunit_filetabs.
16017         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16018         (ALL_FILETABS): Use compunit_filetabs.
16019         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16020         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16021
16022 2019-01-09  Tom Tromey  <tom@tromey.com>
16023
16024         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16025         (compunit_filetabs): New.
16026         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16027         compunit_filetabs.
16028         (info_sources_command, make_source_files_completion_list): Remove
16029         declaration.
16030         * symmisc.c (print_objfile_statistics, dump_objfile)
16031         (maintenance_print_symbols): Remove declaration.
16032         (maintenance_info_symtabs): Use compunit_filetabs.
16033         (maintenance_info_line_tables): Likewise.
16034         * source.c (select_source_symtab): Change local variable name.
16035         (forget_cached_source_info_for_objfile): Remove declaration.
16036         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16037         * objfiles.c (objfile_relocate1): Remove declaration.
16038         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16039         declaration.
16040         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16041         * coffread.c (coff_symtab_read): Remove declaration.
16042         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16043         compunit_filetabs.
16044
16045 2019-01-09  Tom Tromey  <tom@tromey.com>
16046
16047         * symtab.c (lookup_objfile_from_block)
16048         (find_pc_sect_compunit_symtab, search_symbols)
16049         (default_collect_symbol_completion_matches_break_on): Use
16050         objfile_compunits.
16051         * objfiles.h (ALL_COMPUNITS): Remove.
16052         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16053         * cp-support.c (add_symbol_overload_list_qualified): Use
16054         objfile_compunits.
16055         * ada-lang.c (ada_collect_symbol_completion_matches)
16056         (ada_add_global_exceptions): Use objfile_compunits.
16057
16058 2019-01-09  Tom Tromey  <tom@tromey.com>
16059
16060         * source.c (select_source_symtab)
16061         (forget_cached_source_info_for_objfile): Remove declaration.
16062         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16063         declaration.
16064         * maint.c (count_symtabs_and_blocks): Remove declaration.
16065         * cp-support.c (add_symbol_overload_list_qualified): Remove
16066         declaration.
16067         * coffread.c (coff_symtab_read): Remove declaration.
16068         * symtab.c (lookup_symbol_in_objfile_symtabs)
16069         (basic_lookup_transparent_type_1): Use objfile_compunits.
16070         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16071         (info_sources_command, search_symbols)
16072         (default_collect_symbol_completion_matches_break_on)
16073         (make_source_files_completion_list): Remove declaration.
16074         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16075         (ada_collect_symbol_completion_matches)
16076         (ada_add_global_exceptions): Remove declaration.
16077         * linespec.c (iterate_over_all_matching_symtabs): Use
16078         objfile_compunits.
16079         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16080         (class objfile_compunits): New.
16081         (ALL_COMPUNITS): Use objfile_compunits.
16082         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16083         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16084         objfile_compunits.
16085         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16086
16087 2019-01-09  Tom Tromey  <tom@tromey.com>
16088
16089         * symtab.c (search_symbols)
16090         (default_collect_symbol_completion_matches_break_on): Use
16091         objfile_msymbols.
16092         * ada-lang.c (ada_lookup_simple_minsym)
16093         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16094         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16095         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16096         objfile_msymbols.
16097         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16098         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16099         * objc-lang.c (find_methods): Use objfile_msymbols.
16100         (info_selectors_command, info_classes_command): Likewise.
16101         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16102         * objfiles.h (class objfile_msymbols): New.
16103         (ALL_OBJFILE_MSYMBOLS): Remove.
16104         (ALL_MSYMBOLS): Remove.
16105
16106 2019-01-09  Tom Tromey  <tom@tromey.com>
16107
16108         * common/next-iterator.h (next_adapter): Add Iterator template
16109         parameter.
16110         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16111         (class all_objfiles_safe): New.
16112         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16113         * objfiles.c (put_objfile_before): Update comment.
16114         (add_separate_debug_objfile): Likewise.
16115         (free_all_objfiles): Use all_objfiles_safe.
16116         (objfile_purge_solibs): Likewise.
16117
16118 2019-01-09  Tom Tromey  <tom@tromey.com>
16119
16120         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16121         (expand_symtab_containing_pc, lookup_static_symbol)
16122         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16123         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16124         all_objfiles.
16125         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16126         * breakpoint.c (create_overlay_event_breakpoint)
16127         (create_longjmp_master_breakpoint)
16128         (create_std_terminate_master_breakpoint)
16129         (create_exception_master_breakpoint): Use all_objfiles.
16130         * linux-thread-db.c (try_thread_db_load_from_pdir)
16131         (has_libpthread): Use all_objfiles.
16132         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16133         * linespec.c (iterate_over_all_matching_symtabs)
16134         (search_minsyms_for_name): Use all_objfiles.
16135         * maint.c (maintenance_info_sections): Use all_objfiles.
16136         * main.c (captured_main_1): Use all_objfiles.
16137         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16138         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16139         * guile/scm-pretty-print.c
16140         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16141         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16142         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16143         (maintenance_print_msymbols): Use all_objfiles.
16144         * source.c (select_source_symtab): Use all_objfiles.
16145         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16146         * symfile.c (remove_symbol_file_command)
16147         (expand_symtabs_matching, map_symbol_filenames): Use
16148         all_objfiles.
16149         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16150         all_objfiles.
16151         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16152         * objc-lang.c (find_methods): Use all_objfiles.
16153         * objfiles.c (have_partial_symbols, have_full_symbols)
16154         (have_minimal_symbols, qsort_cmp)
16155         (default_iterate_over_objfiles_in_search_order): Use
16156         all_objfiles.
16157         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16158         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16159         (maintenance_check_psymtabs): Use all_objfiles.
16160         (ALL_PSYMTABS): Remove.
16161         * compile/compile-object-run.c (do_module_cleanup): Use
16162         all_objfiles.
16163         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16164         * cp-support.c (add_symbol_overload_list_qualified): Use
16165         all_objfiles.
16166         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16167         Use all_objfiles.
16168         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16169         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16170         all_objfiles.
16171         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16172         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16173         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16174         Uses all_objfiles.
16175         * solib.c (solib_read_symbols): Use all_objfiles
16176
16177 2019-01-09  Tom Tromey  <tom@tromey.com>
16178
16179         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16180         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16181         all_objfiles.
16182         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16183         * symmisc.c (print_symbol_bcache_statistics)
16184         (print_objfile_statistics, maintenance_print_objfiles)
16185         (maintenance_info_symtabs, maintenance_check_symtabs)
16186         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16187         all_objfiles.
16188         * source.c (forget_cached_source_info): Use all_objfiles.
16189         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16190         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16191         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16192         * objfiles.c (update_section_map): Use all_objfiles.
16193         (shared_objfile_contains_address_p): Likewise.
16194         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16195         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16196
16197 2019-01-09  Tom Tromey  <tom@tromey.com>
16198
16199         * common/next-iterator.h: New file.
16200         * objfiles.h (class all_objfiles): New.
16201         (struct objfile_iterator): New.
16202
16203 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16204
16205         * NEWS: Move the description of the changed "frame", "select-frame",
16206          and "info frame" commands to the Changed commands section.
16207
16208 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16209
16210         * gdbtypes.c (check_stub_method_group): Remove handling of old
16211         mangling schemes.
16212         * linespec.c (find_methods): Likewise.
16213         * stabsread.c (read_member_functions): Likewise.
16214         * valops.c (search_struct_method): Likewise.
16215         (value_struct_elt_for_reference): Likewise.
16216         * NEWS: Mention this change.
16217
16218 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16219
16220         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16221         print_source_lines.
16222         * source.c (print_source_lines_base): Update line number check.
16223         (print_source_lines): New function.
16224         (source_lines_range::source_lines_range): New function.
16225         * source.h (class source_lines_range): New class.
16226         (print_source_lines): New declaration.
16227
16228 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16229
16230         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16231
16232 2019-01-08  Tom Tromey  <tom@tromey.com>
16233             Simon Marchi  <simon.marchi@ericsson.com>
16234
16235         PR gdb/24060
16236         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16237         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16238         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16239         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16240         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16241         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16242
16243 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16244
16245         * source.c (select_source_symtab): Move header comment to
16246         declaration in source.h.
16247         (forget_cached_source_info_for_objfile): Likewise.
16248         (forget_cached_source_info): Likewise.
16249         (identify_source_line): Likewise.
16250         * source.h (identify_source_line): Move declaration from symtab.h
16251         and add comment from source.c
16252         (print_source_lines): Likewise.
16253         (forget_cached_source_info_for_objfile): Likewise.
16254         (forget_cached_source_info): Likewise.
16255         (select_source_symtab): Likewise.
16256         (enum print_source_lines_flag): Move definition from symtab.h.
16257         * symtab.h (identify_source_line): Move declaration to source.h.
16258         (print_source_lines): Likewise.
16259         (forget_cached_source_info_for_objfile): Likewise.
16260         (forget_cached_source_info): Likewise.
16261         (select_source_symtab): Likewise.
16262         (enum print_source_lines_flag): Move definition to source.h.
16263         * tui/tui-hooks.c: Add 'source.h' include.
16264
16265 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16266
16267         * source.c (print_source_lines_base): Handle requests to print
16268         reverse line number sequences, and guard against empty lines
16269         string.
16270
16271 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16272
16273         * source.c (print_source_lines_base): Fix skip of '\r' if next
16274         character is '\n'.
16275
16276 2019-01-06  Tom Tromey  <tom@tromey.com>
16277
16278         * c-exp.y (struct c_parse_state) <macro_original_text,
16279         expansion_obstack>: New member.
16280         (macro_original_text, expansion_obstack): Remove globals.
16281         (scan_macro_expansion, scanning_macro_expansion)
16282         (finished_macro_expansion): Update.
16283         (scan_macro_cleanup): Remove.
16284         (yylex, c_parse): Update.
16285
16286 2019-01-06  Tom Tromey  <tom@tromey.com>
16287
16288         * c-exp.y (struct c_parse_state) <strings>: New member.
16289         (operator_stoken): Update.
16290
16291 2019-01-06  Tom Tromey  <tom@tromey.com>
16292
16293         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16294         (union type_stack_elt) <typelist_val>: Now a pointer to
16295         std::vector.
16296         (type_stack_cleanup): Don't declare.
16297         (push_typelist): Update.
16298         * parse.c (pop_typelist): Return a std::vector.
16299         (push_typelist): Take a std::vector.
16300         (follow_types): Update.  Do not free args.
16301         (type_stack_cleanup): Remove.
16302         * c-exp.y (struct c_parse_state): New.
16303         (cpstate): New global.
16304         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16305         (nonempty_typelist): Update.
16306         (func_mod): Create a new vector.
16307         (c_parse): Create a c_parse_state.
16308         (check_parameter_typelist): Do not delete params.
16309         (function_method): Update.  Do not delete type_list.
16310
16311 2019-01-06  Tom Tromey  <tom@tromey.com>
16312
16313         PR gdb/28155:
16314         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16315         check_typedef.
16316         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16317         (print_return_value): Likewise.
16318
16319 2019-01-05  Tom Tromey  <tom@tromey.com>
16320
16321         * contrib/cleanup_check.py: Remove.
16322         * contrib/gcc-with-excheck: Remove.
16323         * contrib/exsummary.py: Remove.
16324         * contrib/excheck.py: Remove.
16325
16326 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16327
16328         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16329         NULL. Initialize tpprev to NULL instead of assigning it
16330         to NULL on the next statement.
16331         * windows-nat.c (windows_delete_thread): Remove check for
16332         main_thread_id before printing thread exit notifications.
16333         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16334         Remove thread ID check against main_thread_id.
16335         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16336         windows_delete_thread.
16337         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16338
16339 2019-01-04  Tom Tromey  <tom@tromey.com>
16340
16341         * compile/compile.c (_initialize_compile): Use upper case for
16342         metasyntactic variables.
16343         * symmisc.c (_initialize_symmisc): Use upper case for
16344         metasyntactic variables.
16345         * psymtab.c (_initialize_psymtab): Use upper case for
16346         metasyntactic variables.
16347         * demangle.c (demangle_command): Use upper case for metasyntactic
16348         variables.
16349         (_initialize_demangler): Likewise.
16350         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16351         variables.
16352
16353 2019-01-03  Tom Tromey  <tom@tromey.com>
16354
16355         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16356
16357 2019-01-03  Tom Tromey  <tom@tromey.com>
16358
16359         * python/py-symtab.c (salpy_str): Update.
16360         (struct salpy_sal_object) <symtab>: Now a PyObject.
16361         (salpy_dealloc): Update.
16362         (del_objfile_sal): Use gdbpy_ref.
16363
16364 2019-01-03  Tom Tromey  <tom@tromey.com>
16365
16366         * python/py-type.c (convert_field): Use new_reference.  Return
16367         gdbpy_ref.
16368         (make_fielditem): Return gdbpy_ref.
16369         (typy_fields): Update.
16370         (typy_getitem): Update.
16371         (field_name): Return gdbpy_ref.  Use new_reference.
16372         (typy_iterator_iternext): Update.
16373
16374 2019-01-03  Tom Tromey  <tom@tromey.com>
16375
16376         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16377
16378 2019-01-03  Tom Tromey  <tom@tromey.com>
16379
16380         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16381         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16382         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16383         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16384         (pspy_set_type_printers): Likewise.
16385         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16386         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16387         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16388         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16389         (objfpy_set_type_printers): Likewise.
16390
16391 2019-01-03  Tom Tromey  <tom@tromey.com>
16392
16393         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16394         (gdbpy_print_stack): Use gdbpy_err_fetch.
16395         * python/python-internal.h (class gdbpy_err_fetch): New class.
16396         (class gdbpy_enter) <m_error_type, m_error_value,
16397         m_error_traceback>: Remove.
16398         <m_error>: New member.
16399         (gdbpy_exception_to_string): Don't declare.
16400         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16401         * python/py-value.c (convert_value_from_python): Use
16402         gdbpy_err_fetch.
16403         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16404         gdbpy_exception_to_string.
16405         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16406         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16407         gdbpy_err_fetch.
16408
16409 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16410
16411         * linux-nat.c (delete_lwp_cleanup): Delete.
16412         (struct lwp_deleter): New struct.
16413         (lwp_info_up): New typedef.
16414         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16415         lwp_info_up.
16416
16417 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16418
16419         * linux-fork.c (class scoped_switch_fork_info): New class.
16420         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16421
16422 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16423
16424         * valops.c (find_overload_match): Remove use of null_cleanup, and
16425         calls to do_cleanups.
16426
16427 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16428
16429         * compile/compile-cplus-types.c
16430         (compile_cplus_instance::decl_name): Handle changes to
16431         cp_func_name.
16432         * cp-support.c (cp_func_name): Update header comment, update
16433         return type.
16434         * cp-support.h (cp_func_name): Update return type in declaration.
16435         * valops.c (find_overload_match): Move temp_func local to top
16436         level of function and change its type.  Use temp_func to hold and
16437         delete temporary string obtained from cp_func_name.
16438
16439 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16440
16441         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16442         gdb::char_vector, remove cleanup, and update uses of `msg`.
16443
16444 2019-01-03  Jim Wilson  <jimw@sifive.com>
16445
16446         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16447
16448 2019-01-02  Tom Tromey  <tom@tromey.com>
16449
16450         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16451         (tdesc_parse_xml): Remove cleanups.
16452         * target-descriptions.h (make_cleanup_free_target_description):
16453         Don't declare.
16454         (target_desc_deleter): New struct.
16455         (target_desc_up): New typedef.
16456         * target-descriptions.c (target_desc_deleter::operator()): Rename
16457         from free_target_description.
16458         (make_cleanup_free_target_description): Remove.
16459
16460 2019-01-02  Tom Tromey  <tom@tromey.com>
16461
16462         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16463         constructor, destructor.
16464         (linespec_parser): Remove typedef.
16465         (~linespec_parser): Rename from linespec_parser_delete.
16466         (linespec_lex_to_end, linespec_complete_label)
16467         (linespec_complete): Update.
16468         (decode_line_full): Remove cleanups.
16469         (decode_line_1): Update.
16470
16471 2019-01-02  Tom Tromey  <tom@tromey.com>
16472
16473         * python/python-internal.h (inferior_to_inferior_object): Change
16474         return type.
16475         * python/py-exitedevent.c (create_exited_event_object): Update.
16476         * python/py-inferior.c (inferior_to_inferior_object): Return
16477         gdbpy_ref.
16478         (python_new_inferior, python_inferior_deleted)
16479         (thread_to_thread_object, delete_thread_object)
16480         (build_inferior_list, gdbpy_selected_inferior): Update.
16481         * python/py-infthread.c (create_thread_object): Update.  Also fail
16482         if inferior_to_inferior_object fails.
16483
16484 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16485
16486         * inferior.h (class inferior) <displaced_step_state>: New field.
16487         * infrun.h (struct displaced_step_state): Move here from
16488         infrun.c.  Initialize fields, add constructor.
16489         <inf>: Remove field.
16490         <reset>: New method.
16491         * infrun.c (struct displaced_step_inferior_state): Move to
16492         infrun.h.
16493         (displaced_step_inferior_states): Remove.
16494         (get_displaced_stepping_state): Adust.
16495         (displaced_step_in_progress_any_inferior): Adjust.
16496         (displaced_step_in_progress_thread): Adjust.
16497         (displaced_step_in_progress): Adjust.
16498         (add_displaced_stepping_state): Remove.
16499         (get_displaced_step_closure_by_addr): Adjust.
16500         (remove_displaced_stepping_state): Remove.
16501         (infrun_inferior_exit): Call displaced_step_state.reset.
16502         (use_displaced_stepping): Don't check for NULL.
16503         (displaced_step_prepare_throw): Call
16504         get_displaced_stepping_state.
16505         (displaced_step_fixup): Don't check for NULL.
16506         (prepare_for_detach): Don't check for NULL.
16507
16508 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16509
16510         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16511          in case of call that did not complete.
16512
16513 2019-01-02  Andrey Utkin  <autkin@undo.io>
16514
16515         * symfile.c (find_separate_debug_file): Fix search of debug files for
16516         remote debuggee.
16517
16518 2019-01-02  Tom Tromey  <tom@tromey.com>
16519
16520         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16521         indentation.
16522         * python/py-frame.c (frapy_older): Remove cast.
16523         (frapy_newer): Likewise.
16524         * python/py-breakpoint.c (local_setattro): Remove cast.
16525         * python/py-arch.c (archpy_name): Remove local variable.
16526         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16527
16528 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16529
16530         * unittests/basic_string_view/element_access/char/empty.cc:
16531         Fix year range in copyright header.
16532
16533 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16534
16535         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16536         Delete.
16537         <operator==>: Update with for removed field.
16538         <hash>: Likewise.
16539         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16540         <isa_features>: ...this.
16541         <abi_features>: New field.
16542         (riscv_isa_flen): Update comment.
16543         (riscv_abi_xlen): New declaration.
16544         (riscv_abi_flen): New declaration.
16545         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16546         isa_features.
16547         (riscv_abi_xlen): New function.
16548         (riscv_isa_flen): Update to get answer from isa_features.
16549         (riscv_abi_flen): New function.
16550         (riscv_has_fp_abi): Update to get answer from abi_features.
16551         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16552         xlen and flen.
16553         (riscv_call_info) <xlen, flen>: Update comment.
16554         (riscv_call_arg_struct): Remove invalid assertions
16555         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16556         is removed.
16557         (riscv_gdbarch_init): Gather isa features and abi features
16558         separately, ensure both match on the gdbarch when reusing an old
16559         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16560         a target with 64-bit float hardware.
16561
16562 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16563
16564         * source.c (search_command_helper): Stop reverse search
16565         when line 1 has been searched.
16566
16567 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16568
16569         * record-full.c (record_full_base_target::close): Rewrite
16570         record_full_core_buf_list free logic.
16571
16572 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16573
16574         * break-catch-syscall.c (print_one_catch_syscall): xfree
16575         the last text.
16576
16577 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16578
16579         * top.c (print_gdb_version): Update Copyright year in version
16580         message.
16581
16582 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16583
16584         Update copyright year range in all GDB files.
16585
16586 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16587
16588         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16589
16590 For older changes see ChangeLog-2018.
16591 \f
16592 Local Variables:
16593 mode: change-log
16594 left-margin: 8
16595 fill-column: 74
16596 version-control: never
16597 coding: utf-8
16598 End:
16599