gdb/ChangeLog

   1 2020-01-10  Pedro Alves  <palves@redhat.com>
   2
   3         Revert:
   4         2016-04-12  Pedro Alves  <palves@redhat.com>
   5         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
   6         Remove references to name.
   7         * serial.h (struct serial) <name>: Delete.
   8
   9 2020-01-10  Pedro Alves  <palves@redhat.com>
  10
  11         * gdbarch-selftests.c (register_to_value_test): Remove "target
  12         already pushed" check.
  13
  14 2020-01-10  Pedro Alves  <palves@redhat.com>
  15             John Baldwin  <jhb@FreeBSD.org>
  16
  17         * aarch64-linux-nat.c
  18         (aarch64_linux_nat_target::thread_architecture): Adjust.
  19         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
  20         (task_command_1): Likewise.
  21         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
  22         (aix_thread_target::wait, aix_thread_target::fetch_registers)
  23         (aix_thread_target::store_registers)
  24         (aix_thread_target::thread_alive): Adjust.
  25         * amd64-fbsd-tdep.c: Include "inferior.h".
  26         (amd64fbsd_get_thread_local_address): Pass down target.
  27         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
  28         thread's gdbarch instead of target_gdbarch.
  29         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
  30         get_last_target_status.
  31         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
  32         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
  33         inferiors.
  34         (update_inserted_breakpoint_locations): Skip if inferiors with no
  35         execution.
  36         (update_global_location_list): When handling moribund locations,
  37         find representative inferior for location's pspace, and use thread
  38         count of its process_stratum target.
  39         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
  40         * bsd-uthread.c (bsd_uthread_target::wait): Use
  41         as_process_stratum_target and adjust thread_change_ptid and
  42         add_thread calls.
  43         (bsd_uthread_target::update_thread_list): Use
  44         as_process_stratum_target and adjust find_thread_ptid,
  45         thread_change_ptid and add_thread calls.
  46         * btrace.c (maint_btrace_packet_history_cmd): Adjust
  47         find_thread_ptid call.
  48         * corelow.c (add_to_thread_list): Adjust add_thread call.
  49         (core_target_open): Adjust add_thread_silent and thread_count
  50         calls.
  51         (core_target::pid_to_str): Adjust find_inferior_ptid call.
  52         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
  53         * event-top.c (async_disconnect): Pop targets from all inferiors.
  54         * exec.c (add_target_sections): Push exec target on all inferiors
  55         sharing the program space.
  56         (remove_target_sections): Remove the exec target from all
  57         inferiors sharing the program space.
  58         (exec_on_vfork): New.
  59         * exec.h (exec_on_vfork): Declare.
  60         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
  61         Pass it down.
  62         (fbsd_nat_target::update_thread_list): Adjust.
  63         (fbsd_nat_target::resume): Adjust.
  64         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
  65         down.
  66         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
  67         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
  68         get_thread_arch_regcache call.
  69         * fork-child.c (gdb_startup_inferior): Pass target down to
  70         startup_inferior and set_executing.
  71         * gdbthread.h (struct process_stratum_target): Forward declare.
  72         (add_thread, add_thread_silent, add_thread_with_info)
  73         (in_thread_list): Add process_stratum_target parameter.
  74         (find_thread_ptid(inferior*, ptid_t)): New overload.
  75         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
  76         parameter.
  77         (all_threads()): Delete overload.
  78         (all_threads, all_non_exited_threads): Add process_stratum_target
  79         parameter.
  80         (all_threads_safe): Use brace initialization.
  81         (thread_count): Add process_stratum_target parameter.
  82         (set_resumed, set_running, set_stop_requested, set_executing)
  83         (threads_are_executing, finish_thread_state): Add
  84         process_stratum_target parameter.
  85         (switch_to_thread): Use is_current_thread.
  86         * i386-fbsd-tdep.c: Include "inferior.h".
  87         (i386fbsd_get_thread_local_address): Pass down target.
  88         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
  89         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
  90         have_inferiors check.
  91         * inf-ptrace.c (inf_ptrace_target::create_inferior)
  92         (inf_ptrace_target::attach): Adjust.
  93         * infcall.c (run_inferior_call): Adjust.
  94         * infcmd.c (run_command_1): Pass target to
  95         scoped_finish_thread_state.
  96         (proceed_thread_callback): Skip inferiors with no execution.
  97         (continue_command): Rename 'all_threads' local to avoid hiding
  98         'all_threads' function.  Adjust get_last_target_status call.
  99         (prepare_one_step): Adjust set_running call.
 100         (signal_command): Use user_visible_resume_target.  Compare thread
 101         pointers instead of inferior_ptid.
 102         (info_program_command): Adjust to pass down target.
 103         (attach_command): Mark target's 'thread_executing' flag.
 104         (stop_current_target_threads_ns): New, factored out from ...
 105         (interrupt_target_1): ... this.  Switch inferior before making
 106         target calls.
 107         * inferior-iter.h
 108         (struct all_inferiors_iterator, struct all_inferiors_range)
 109         (struct all_inferiors_safe_range)
 110         (struct all_non_exited_inferiors_range): Filter on
 111         process_stratum_target too.  Remove explicit.
 112         * inferior.c (inferior::inferior): Push dummy target on target
 113         stack.
 114         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
 115         Add process_stratum_target parameter, and pass it down.
 116         (have_live_inferiors): Adjust.
 117         (switch_to_inferior_and_push_target): New.
 118         (add_inferior_command, clone_inferior_command): Handle
 119         "-no-connection" parameter.  Use
 120         switch_to_inferior_and_push_target.
 121         (_initialize_inferior): Mention "-no-connection" option in
 122         the help of "add-inferior" and "clone-inferior" commands.
 123         * inferior.h: Include "process-stratum-target.h".
 124         (interrupt_target_1): Use bool.
 125         (struct inferior) <push_target, unpush_target, target_is_pushed,
 126         find_target_beneath, top_target, process_target, target_at,
 127         m_stack>: New.
 128         (discard_all_inferiors): Delete.
 129         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
 130         (all_inferiors, all_non_exited_inferiors): Add
 131         process_stratum_target parameter.
 132         * infrun.c: Include "gdb_select.h" and <unordered_map>.
 133         (target_last_proc_target): New global.
 134         (follow_fork_inferior): Push target on new inferior.  Pass target
 135         to add_thread_silent.  Call exec_on_vfork.  Handle target's
 136         reference count.
 137         (follow_fork): Adjust get_last_target_status call.  Also consider
 138         target.
 139         (follow_exec): Push target on new inferior.
 140         (struct execution_control_state) <target>: New field.
 141         (user_visible_resume_target): New.
 142         (do_target_resume): Call target_async.
 143         (resume_1): Set target's threads_executing flag.  Consider resume
 144         target.
 145         (commit_resume_all_targets): New.
 146         (proceed): Also consider resume target.  Skip threads of inferiors
 147         with no execution.  Commit resumtion in all targets.
 148         (start_remote): Pass current inferior to wait_for_inferior.
 149         (infrun_thread_stop_requested): Consider target as well.  Pass
 150         thread_info pointer to clear_inline_frame_state instead of ptid.
 151         (infrun_thread_thread_exit): Consider target as well.
 152         (random_pending_event_thread): New inferior parameter.  Use it.
 153         (do_target_wait): Rename to ...
 154         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
 155         down.
 156         (threads_are_resumed_pending_p, do_target_wait): New.
 157         (prepare_for_detach): Adjust calls.
 158         (wait_for_inferior): New inferior parameter.  Handle it.  Use
 159         do_target_wait_1 instead of do_target_wait.
 160         (fetch_inferior_event): Adjust.  Switch to representative
 161         inferior.  Pass target down.
 162         (set_last_target_status): Add process_stratum_target parameter.
 163         Save target in global.
 164         (get_last_target_status): Add process_stratum_target parameter and
 165         handle it.
 166         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
 167         (context_switch): Check inferior_ptid == null_ptid before calling
 168         inferior_thread().
 169         (get_inferior_stop_soon): Pass down target.
 170         (wait_one): Rename to ...
 171         (poll_one_curr_target): ... this.
 172         (struct wait_one_event): New.
 173         (wait_one): New.
 174         (stop_all_threads): Adjust.
 175         (handle_no_resumed, handle_inferior_event): Adjust to consider the
 176         event's target.
 177         (switch_back_to_stepped_thread): Also consider target.
 178         (print_stop_event): Update.
 179         (normal_stop): Update.  Also consider the resume target.
 180         * infrun.h (wait_for_inferior): Remove declaration.
 181         (user_visible_resume_target): New declaration.
 182         (get_last_target_status, set_last_target_status): New
 183         process_stratum_target parameter.
 184         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
 185         process_stratum_target parameter, and use it.
 186         (clear_inline_frame_state (thread_info*)): New.
 187         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
 188         process_stratum_target parameter.
 189         (clear_inline_frame_state (thread_info*)): Declare.
 190         * linux-fork.c (delete_checkpoint_command): Pass target down to
 191         find_thread_ptid.
 192         (checkpoint_command): Adjust.
 193         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
 194         instead of just tweaking inferior_ptid.
 195         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
 196         (exit_lwp): Pass target down to find_thread_ptid.
 197         (attach_proc_task_lwp_callback): Pass target down to
 198         add_thread/set_running/set_executing.
 199         (linux_nat_target::attach): Pass target down to
 200         thread_change_ptid.
 201         (get_detach_signal): Pass target down to find_thread_ptid.
 202         Consider last target status's target.
 203         (linux_resume_one_lwp_throw, resume_lwp)
 204         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
 205         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
 206         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
 207         (linux_nat_target::async_wait_fd): New.
 208         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
 209         target down.
 210         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
 211         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
 212         * linux-thread-db.c (struct thread_db_info::process_target): New
 213         field.
 214         (add_thread_db_info): Save target.
 215         (get_thread_db_info): New process_stratum_target parameter.  Also
 216         match target.
 217         (delete_thread_db_info): New process_stratum_target parameter.
 218         Also match target.
 219         (thread_from_lwp): Adjust to pass down target.
 220         (thread_db_notice_clone): Pass down target.
 221         (check_thread_db_callback): Pass down target.
 222         (try_thread_db_load_1): Always push the thread_db target.
 223         (try_thread_db_load, record_thread): Pass target down.
 224         (thread_db_target::detach): Pass target down.  Always unpush the
 225         thread_db target.
 226         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
 227         target down.  Always unpush the thread_db target.
 228         (find_new_threads_callback, thread_db_find_new_threads_2)
 229         (thread_db_target::update_thread_list): Pass target down.
 230         (thread_db_target::pid_to_str): Pass current inferior down.
 231         (thread_db_target::get_thread_local_address): Pass target down.
 232         (thread_db_target::resume, maintenance_check_libthread_db): Pass
 233         target down.
 234         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
 235         * procfs.c (procfs_target::procfs_init_inferior): Declare.
 236         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
 237         (procfs_init_inferior): Rename to ...
 238         (procfs_target::procfs_init_inferior): ... this and adjust.
 239         (procfs_target::create_inferior, procfs_notice_thread)
 240         (procfs_do_thread_registers): Adjust.
 241         * ppc-fbsd-tdep.c: Include "inferior.h".
 242         (ppcfbsd_get_thread_local_address): Pass down target.
 243         * proc-service.c (ps_xfer_memory): Switch current inferior and
 244         program space as well.
 245         (get_ps_regcache): Pass target down.
 246         * process-stratum-target.c
 247         (process_stratum_target::thread_address_space)
 248         (process_stratum_target::thread_architecture): Pass target down.
 249         * process-stratum-target.h
 250         (process_stratum_target::threads_executing): New field.
 251         (as_process_stratum_target): New.
 252         * ravenscar-thread.c
 253         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
 254         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
 255         down.
 256         * record-btrace.c (record_btrace_target::info_record): Adjust.
 257         (record_btrace_target::record_method)
 258         (record_btrace_target::record_is_replaying)
 259         (record_btrace_target::fetch_registers)
 260         (get_thread_current_frame_id, record_btrace_target::resume)
 261         (record_btrace_target::wait, record_btrace_target::stop): Pass
 262         target down.
 263         * record-full.c (record_full_wait_1): Switch to event thread.
 264         Pass target down.
 265         * regcache.c (regcache::regcache)
 266         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
 267         process_stratum_target parameter and handle it.
 268         (current_thread_target): New global.
 269         (get_thread_regcache): Add process_stratum_target parameter and
 270         handle it.  Switch inferior before calling target method.
 271         (get_thread_regcache): Pass target down.
 272         (get_thread_regcache_for_ptid): Pass target down.
 273         (registers_changed_ptid): Add process_stratum_target parameter and
 274         handle it.
 275         (registers_changed_thread, registers_changed): Pass target down.
 276         (test_get_thread_arch_aspace_regcache): New.
 277         (current_regcache_test): Define a couple local test_target_ops
 278         instances and use them for testing.
 279         (readwrite_regcache): Pass process_stratum_target parameter.
 280         (cooked_read_test, cooked_write_test): Pass mock_target down.
 281         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
 282         (get_thread_arch_aspace_regcache): Add process_stratum_target
 283         parameter.
 284         (regcache::target): New method.
 285         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
 286         (regcache::registers_changed_ptid): Add process_stratum_target
 287         parameter.
 288         (regcache::m_target): New field.
 289         (registers_changed_ptid): Add process_stratum_target parameter.
 290         * remote.c (remote_state::supports_vCont_probed): New field.
 291         (remote_target::async_wait_fd): New method.
 292         (remote_unpush_and_throw): Add remote_target parameter.
 293         (get_current_remote_target): Adjust.
 294         (remote_target::remote_add_inferior): Push target.
 295         (remote_target::remote_add_thread)
 296         (remote_target::remote_notice_new_inferior)
 297         (get_remote_thread_info): Pass target down.
 298         (remote_target::update_thread_list): Skip threads of inferiors
 299         bound to other targets.  (remote_target::close): Don't discard
 300         inferiors.  (remote_target::add_current_inferior_and_thread)
 301         (remote_target::process_initial_stop_replies)
 302         (remote_target::start_remote)
 303         (remote_target::remote_serial_quit_handler): Pass down target.
 304         (remote_target::remote_unpush_target): New remote_target
 305         parameter.  Unpush the target from all inferiors.
 306         (remote_target::remote_unpush_and_throw): New remote_target
 307         parameter.  Pass it down.
 308         (remote_target::open_1): Check whether the current inferior has
 309         execution instead of checking whether any inferior is live.  Pass
 310         target down.
 311         (remote_target::remote_detach_1): Pass down target.  Use
 312         remote_unpush_target.
 313         (extended_remote_target::attach): Pass down target.
 314         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
 315         (remote_target::append_resumption): Pass down target.
 316         (remote_target::append_pending_thread_resumptions)
 317         (remote_target::remote_resume_with_hc, remote_target::resume)
 318         (remote_target::commit_resume): Pass down target.
 319         (remote_target::remote_stop_ns): Check supports_vCont_probed.
 320         (remote_target::interrupt_query)
 321         (remote_target::remove_new_fork_children)
 322         (remote_target::check_pending_events_prevent_wildcard_vcont)
 323         (remote_target::remote_parse_stop_reply)
 324         (remote_target::process_stop_reply): Pass down target.
 325         (first_remote_resumed_thread): New remote_target parameter.  Pass
 326         it down.
 327         (remote_target::wait_as): Pass down target.
 328         (unpush_and_perror): New remote_target parameter.  Pass it down.
 329         (remote_target::readchar, remote_target::remote_serial_write)
 330         (remote_target::getpkt_or_notif_sane_1)
 331         (remote_target::kill_new_fork_children, remote_target::kill): Pass
 332         down target.
 333         (remote_target::mourn_inferior): Pass down target.  Use
 334         remote_unpush_target.
 335         (remote_target::core_of_thread)
 336         (remote_target::remote_btrace_maybe_reopen): Pass down target.
 337         (remote_target::pid_to_exec_file)
 338         (remote_target::thread_handle_to_thread_info): Pass down target.
 339         (remote_target::async_wait_fd): New.
 340         * riscv-fbsd-tdep.c: Include "inferior.h".
 341         (riscv_fbsd_get_thread_local_address): Pass down target.
 342         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
 343         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
 344         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
 345         Adjust.
 346         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
 347         * solib-svr4.c (enable_break): Pass down target.
 348         * spu-multiarch.c (parse_spufs_run): Pass down target.
 349         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
 350         * target-delegates.c: Regenerate.
 351         * target.c (g_target_stack): Delete.
 352         (current_top_target): Return the current inferior's top target.
 353         (target_has_execution_1): Refer to the passed-in inferior's top
 354         target.
 355         (target_supports_terminal_ours): Check whether the initial
 356         inferior was already created.
 357         (decref_target): New.
 358         (target_stack::push): Incref/decref the target.
 359         (push_target, push_target, unpush_target): Adjust.
 360         (target_stack::unpush): Defref target.
 361         (target_is_pushed): Return bool.  Adjust to refer to the current
 362         inferior's target stack.
 363         (dispose_inferior): Delete, and inline parts ...
 364         (target_preopen): ... here.  Only dispose of the current inferior.
 365         (target_detach): Hold strong target reference while detaching.
 366         Pass target down.
 367         (target_thread_name): Add assertion.
 368         (target_resume): Pass down target.
 369         (target_ops::beneath, find_target_at): Adjust to refer to the
 370         current inferior's target stack.
 371         (get_dummy_target): New.
 372         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
 373         has a thread running.
 374         (initialize_targets): Rename to ...
 375         (_initialize_target): ... this.
 376         * target.h: Include "gdbsupport/refcounted-object.h".
 377         (struct target_ops): Inherit refcounted_object.
 378         (target_ops::shortname, target_ops::longname): Make const.
 379         (target_ops::async_wait_fd): New method.
 380         (decref_target): Declare.
 381         (struct target_ops_ref_policy): New.
 382         (target_ops_ref): New typedef.
 383         (get_dummy_target): Declare function.
 384         (target_is_pushed): Return bool.
 385         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
 386         (all_matching_threads_iterator::all_matching_threads_iterator):
 387         Handle filter target.
 388         * thread-iter.h (struct all_matching_threads_iterator, struct
 389         all_matching_threads_range, class all_non_exited_threads_range):
 390         Filter by target too.  Remove explicit.
 391         * thread.c (threads_executing): Delete.
 392         (inferior_thread): Pass down current inferior.
 393         (clear_thread_inferior_resources): Pass down thread pointer
 394         instead of ptid_t.
 395         (add_thread_silent, add_thread_with_info, add_thread): Add
 396         process_stratum_target parameter.  Use it for thread and inferior
 397         searches.
 398         (is_current_thread): New.
 399         (thread_info::deletable): Use it.
 400         (find_thread_ptid, thread_count, in_thread_list)
 401         (thread_change_ptid, set_resumed, set_running): New
 402         process_stratum_target parameter.  Pass it down.
 403         (set_executing): New process_stratum_target parameter.  Pass it
 404         down.  Adjust reference to 'threads_executing'.
 405         (threads_are_executing): New process_stratum_target parameter.
 406         Adjust reference to 'threads_executing'.
 407         (set_stop_requested, finish_thread_state): New
 408         process_stratum_target parameter.  Pass it down.
 409         (switch_to_thread): Also match inferior.
 410         (switch_to_thread): New process_stratum_target parameter.  Pass it
 411         down.
 412         (update_threads_executing): Reimplement.
 413         * top.c (quit_force): Pop targets from all inferior.
 414         (gdb_init): Don't call initialize_targets.
 415         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
 416         Declare.
 417         (windows_add_thread, windows_delete_thread): Adjust.
 418         (get_windows_debug_event): Rename to ...
 419         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
 420         * tracefile-tfile.c (tfile_target_open): Pass down target.
 421         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
 422         Forward declare.
 423         (switch_to_thread): Add process_stratum_target parameter.
 424         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
 425         parameter.  Use it.
 426         (mi_on_resume): Pass target down.
 427         * nat/fork-inferior.c (startup_inferior): Add
 428         process_stratum_target parameter.  Pass it down.
 429         * nat/fork-inferior.h (startup_inferior): Add
 430         process_stratum_target parameter.
 431         * python/py-threadevent.c (py_get_event_thread): Pass target down.
 432
 433 2020-01-10  Pedro Alves  <palves@redhat.com>
 434
 435         * remote.c (remote_target::start_remote): Don't set inferior_ptid
 436         directly.  Instead find the first thread in the thread list and
 437         use switch_to_thread.
 438
 439 2020-01-10  Pedro Alves  <palves@redhat.com>
 440
 441         * remote.c (remote_target::remote_add_inferior): Don't bind a
 442         process to the current inferior if the current inferior is already
 443         bound to a process.
 444
 445 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 446             Pedro Alves  <palves@redhat.com>
 447
 448         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
 449         If no process is specified, return null_ptid instead of
 450         inferior_ptid.
 451         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
 452         TARGET_WAITKIND_SIGNALLED with no pid.
 453
 454 2020-01-10  Pedro Alves  <palves@redhat.com>
 455
 456         * remote.c (first_remote_resumed_thread): New.
 457         (remote_target::wait_as): Use it as default event_ptid instead of
 458         inferior_ptid.
 459
 460 2020-01-10  Pedro Alves  <palves@redhat.com>
 461
 462         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
 463
 464 2020-01-10  Pedro Alves  <palves@redhat.com>
 465
 466         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
 467         not -1.
 468
 469 2020-01-10  Pedro Alves  <palves@redhat.com>
 470
 471         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
 472         ptid to get_last_target_status.
 473         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
 474         ptid to get_last_target_status.
 475         * infcmd.c (continue_command): Don't pass a target_waitstatus to
 476         get_last_target_status.
 477         (info_program_command): Don't pass a target_waitstatus to
 478         get_last_target_status.
 479         * infrun.c (init_wait_for_inferior): Use
 480         nullify_last_target_wait_ptid.
 481         (get_last_target_status): Handle nullptr arguments.
 482         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
 483         (print_stop_event): Don't pass a ptid to get_last_target_status.
 484         (normal_stop): Don't pass a ptid to get_last_target_status.
 485         * infrun.h (get_last_target_status, set_last_target_status): Move
 486         comments here and update.
 487         (nullify_last_target_wait_ptid): Declare.
 488         * linux-fork.c (fork_load_infrun_state): Remove local extern
 489         declaration of nullify_last_target_wait_ptid.
 490         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
 491         to get_last_target_status.
 492
 493 2020-01-10  Pedro Alves  <palves@redhat.com>
 494
 495         * gdbthread.h (scoped_restore_current_thread)
 496         <dont_restore, restore, m_dont_restore>: Declare.
 497         * thread.c (thread_alive): Add assertion.  Return bool.
 498         (switch_to_thread_if_alive): New.
 499         (prune_threads): Switch inferior/thread.
 500         (print_thread_info_1): Switch thread before calling target methods.
 501         (scoped_restore_current_thread::restore): New, factored out from
 502         ...
 503         (scoped_restore_current_thread::~scoped_restore_current_thread):
 504         ... this.
 505         (scoped_restore_current_thread::scoped_restore_current_thread):
 506         Add assertion.
 507         (thread_apply_all_command, thread_select): Use
 508         switch_to_thread_if_alive.
 509         * infrun.c (proceed, restart_threads, handle_signal_stop)
 510         (switch_back_to_stepped_thread): Switch current thread before
 511         calling target methods.
 512
 513 2020-01-10  Pedro Alves <palves@redhat.com>
 514
 515         * inferior.c (switch_to_inferior_no_thread): New function,
 516         factored out from ...
 517         (inferior_command): ... here.
 518         * inferior.h (switch_to_inferior_no_thread): Declare.
 519         * mi/mi-main.c (run_one_inferior): Use
 520         switch_to_inferior_no_thread.
 521
 522 2020-01-10  Pedro Alves  <palves@redhat.com>
 523
 524         * infcmd.c (kill_command): Remove dead code.
 525
 526 2020-01-10  Pedro Alves  <palves@redhat.com>
 527
 528         * remote.c (remote_target::mourn_inferior): No longer check
 529         whether the target is running.
 530
 531 2020-01-10  Pedro Alves  <palves@redhat.com>
 532
 533         * corelow.c (core_target::has_execution): Change parameter type to
 534         inferior pointer.
 535         * inferior.c (number_of_live_inferiors): Use
 536         inferior::has_execution instead of target_has_execution_1.
 537         * inferior.h (inferior::has_execution): New.
 538         * linux-thread-db.c (thread_db_target::update_thread_list): Use
 539         inferior::has_execution instead of target_has_execution_1.
 540         * process-stratum-target.c
 541         (process_stratum_target::has_execution): Change parameter type to
 542         inferior pointer.  Check the inferior's PID instead of
 543         inferior_ptid.
 544         * process-stratum-target.h
 545         (process_stratum_target::has_execution): Change parameter type to
 546         inferior pointer.
 547         * record-full.c (record_full_core_target::has_execution): Change
 548         parameter type to inferior pointer.
 549         * target.c (target_has_execution_1): Change parameter type to
 550         inferior pointer.
 551         (target_has_execution_current): Adjust.
 552         * target.h (target_ops::has_execution): Change parameter type to
 553         inferior pointer.
 554         (target_has_execution_1): Change parameter type to inferior
 555         pointer.  Change return type to bool.
 556         * tracefile.h (tracefile_target::has_execution): Change parameter
 557         type to inferior pointer.
 558
 559 2020-01-10  Pedro Alves  <palves@redhat.com>
 560
 561         * exceptions.c (print_flush): Remove current_top_target() check.
 562
 563 2020-01-10  Pedro Alves  <palves@redhat.com>
 564
 565         * remote.c (show_remote_exec_file): Show the current inferior's
 566         exec-file instead of the command variable's value.
 567
 568 2020-01-10  Pedro Alves  <palves@redhat.com>
 569
 570         * record-full.c (record_full_resume_ptid): New global.
 571         (record_full_target::resume): Set it.
 572         (record_full_wait_1): Use record_full_resume_ptid instead of
 573         inferior_ptid.
 574
 575 2020-01-10  Pedro Alves  <palves@redhat.com>
 576
 577         * gdbthread.h (scoped_restore_current_thread)
 578         <dont_restore, restore, m_dont_restore>: Declare.
 579         * thread.c (thread_alive): Add assertion.  Return bool.
 580         (switch_to_thread_if_alive): New.
 581         (prune_threads): Switch inferior/thread.
 582         (print_thread_info_1): Switch thread before calling target methods.
 583         (scoped_restore_current_thread::restore): New, factored out from
 584         ...
 585         (scoped_restore_current_thread::~scoped_restore_current_thread):
 586         ... this.
 587         (scoped_restore_current_thread::scoped_restore_current_thread):
 588         Add assertion.
 589         (thread_apply_all_command, thread_select): Use
 590         switch_to_thread_if_alive.
 591
 592 2020-01-10  George Barrett  <bob@bob131.so>
 593
 594         * stap-probe.c (stap_modify_semaphore): Don't check for null
 595         semaphores.
 596         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
 597         for null semaphores.
 598
 599 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 600
 601         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
 602         all source windows, and maintain horizontal scroll status while
 603         doing so.
 604
 605 2020-01-09  Tom Tromey  <tom@tromey.com>
 606
 607         PR tui/18932:
 608         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
 609         update_source_window, not print_source_lines.
 610
 611 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 612
 613         * tui/tui.c (tui_enable): Register tui hooks after calling
 614         tui_display_main.
 615
 616 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
 617
 618         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
 619
 620 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
 621
 622         * thread.c (print_thread_info_1): Fix indentation.
 623
 624 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
 625
 626         * symtab.c (general_symbol_info::compute_and_set_names): Move the
 627         unique_xmalloc_ptr outside the if to always free the demangled name.
 628
 629 2020-01-08  Tom Tromey  <tromey@adacore.com>
 630
 631         * xcoffread.c (enter_line_range, read_xcoff_symtab)
 632         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
 633         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
 634         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
 635         Remove.
 636         (section_offsets): New typedef.
 637         * symtab.c (fixup_section, get_msymbol_address): Update.
 638         * symmisc.c (dump_msymbols): Update.
 639         * symfile.h (relative_addr_info_to_section_offsets)
 640         (symfile_map_offsets_to_segments): Update.
 641         * symfile.c (build_section_addr_info_from_objfile)
 642         (init_objfile_sect_indices): Update.
 643         (struct place_section_arg): Change type of "offsets".
 644         (place_section): Update.
 645         (relative_addr_info_to_section_offsets): Change type of
 646         "section_offsets".  Remove "num_sections" parameter.
 647         (default_symfile_offsets, syms_from_objfile_1)
 648         (set_objfile_default_section_offset): Update.
 649         (reread_symbols): No need to preserve section offsets by hand.
 650         (symfile_map_offsets_to_segments): Change type of "offsets".
 651         * stap-probe.c (relocate_address): Update.
 652         * stabsread.h (process_one_symbol): Update.
 653         * solib-target.c (struct lm_info_target) <offsets>: Change type.
 654         (solib_target_relocate_section_addresses): Update.
 655         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
 656         Update.
 657         * solib-frv.c (frv_relocate_main_executable): Update.
 658         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
 659         * solib-aix.c (solib_aix_get_section_offsets): Change return
 660         type.
 661         (solib_aix_solib_create_inferior_hook): Update.
 662         * remote.c (remote_target::get_offsets): Update.
 663         * psymtab.c (find_pc_sect_psymtab): Update.
 664         * psympriv.h (struct partial_symbol) <address, text_low,
 665         text_high>: Update.
 666         * objfiles.h (obj_section_offset): Update.
 667         (struct objfile) <section_offsets>: Change type.
 668         <num_sections>: Remove.
 669         (objfile_relocate): Update.
 670         * objfiles.c (entry_point_address_query): Update
 671         (relocate_one_symbol): Change type of "section_offsets".
 672         (objfile_relocate1, objfile_relocate1): Change type of
 673         "new_offsets".
 674         (objfile_rebase1): Update.
 675         * mipsread.c (mipscoff_symfile_read): Update.
 676         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
 677         parameter.
 678         * mdebugread.c (parse_symbol): Change type of "section_offsets".
 679         (parse_external, psymtab_to_symtab_1): Update.
 680         * machoread.c (macho_symfile_offsets): Update.
 681         * ia64-tdep.c (ia64_find_unwind_table): Update.
 682         * hppa-tdep.c (read_unwind_info): Update.
 683         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
 684         * dwarf2read.c (create_addrmap_from_index)
 685         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 686         (process_psymtab_comp_unit_reader, add_partial_symbol)
 687         (add_partial_subprogram, process_full_comp_unit)
 688         (read_file_scope, read_func_scope, read_lexical_block_scope)
 689         (read_call_site_scope, dwarf2_rnglists_process)
 690         (dwarf2_ranges_process, dwarf2_ranges_read)
 691         (dwarf_decode_lines_1, var_decode_location, new_symbol)
 692         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
 693         Update.
 694         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
 695         Update.
 696         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
 697         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
 698         (process_one_symbol): Change type of "section_offsets".
 699         * ctfread.c (get_objfile_text_range): Update.
 700         * coffread.c (coff_symtab_read, enter_linenos)
 701         (process_coff_symbol): Update.
 702         * coff-pe-read.c (add_pe_forwarded_sym): Update.
 703         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
 704
 705 2020-01-08  Tom Tromey  <tromey@adacore.com>
 706
 707         * dwarf2read.c (parse_macro_definition): Use std::string.
 708         (parse_macro_definition): Likewise.
 709
 710 2020-01-08  Tom Tromey  <tromey@adacore.com>
 711
 712         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
 713         (ATTR_ALLOC_CHUNK): Remove.
 714
 715 2020-01-08  Tom Tromey  <tromey@adacore.com>
 716
 717         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
 718
 719 2020-01-08  Tom Tromey  <tromey@adacore.com>
 720
 721         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
 722         (dwarf2_compute_name, open_dwo_file): Likewise.
 723         (process_enumeration_scope): Use std::vector.
 724         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
 725         (partial_die_info::fixup, dwarf2_start_subfile)
 726         (guess_full_die_structure_name, dwarf2_name): Likewise.
 727         (determine_prefix): Update.
 728         (guess_full_die_structure_name): Make return type const.
 729         (partial_die_full_name): Return unique_xmalloc_ptr.
 730         (DW_FIELD_ALLOC_CHUNK): Remove.
 731
 732 2020-01-07  Tom Tromey  <tromey@adacore.com>
 733
 734         PR build/24937:
 735         * stap-probe.c (class stap_static_probe_ops): Add constructor.
 736
 737 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
 738
 739         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
 740
 741 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 742
 743         * stack.c (print_frame_info): Move disassemble_next_line code
 744         inside source_print block.
 745
 746 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
 747
 748         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
 749         gdb/signals.h, as we are now using native signal symbols.
 750
 751 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
 752
 753         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
 754         overflow by an early check of content vs threshold.
 755         * tui/tui-source.c (tui_source_window::line_is_displayed):
 756         Likewise.
 757
 758 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
 759
 760         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
 761
 762 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
 763
 764         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
 765         export table if no section contains it's RVA.
 766
 767 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
 768
 769         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
 770
 771 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
 772
 773         * source.c (print_source_lines_base): Set last_line_listed.
 774
 775 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
 776
 777         * tui/tui-disasm.c: Remove trailing spaces.
 778
 779 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
 780             Pedro Alves  <palves@redhat.com>
 781
 782         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
 783         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
 784         (windows_gdb_signal_to_target): New function, uses the above
 785         enumeration to convert GDB internal signal codes to equivalent
 786         Windows codes.
 787         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
 788         * windows-nat.c: Include "gdb_wait.h".
 789         (get_windows_debug_event): Extract the fatal exception from the
 790         exit status and convert to the equivalent Posix signal number.
 791         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
 792         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
 793         * gdbsupport/gdb_wait.c: New file, implements
 794         windows_status_to_termsig.
 795         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
 796         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
 797
 798 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 799
 800         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
 801         show_layout.
 802
 803 2020-01-05  Luis Machado  <luis.machado@linaro.org>
 804
 805         * aarch64-linux-nat.c
 806         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
 807         and bfd_mach_aarch64.
 808
 809 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 810
 811         * ui-file.c (stdio_file::can_emit_style_escape)
 812         (tee_file::can_emit_style_escape): Ensure style is used also on
 813         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
 814         to gdb_stdout.
 815         * main.c (set_gdb_data_directory): Use file style to output the
 816         warning that the given pathname is not a directory.
 817         * top.c (show_history_filename, gdb_safe_append_history)
 818         (show_gdb_datadir): Use file style.
 819
 820 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
 821
 822         * solib-target.c (struct lm_info_target):
 823         Change offsets to be a unique_xmalloc_ptr.
 824         (solib_target_relocate_section_addresses): Update.
 825
 826 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
 827
 828         * windows-nat.c (windows_clear_solib): Free so_list linked list.
 829
 830 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 831
 832         * MAINTAINERS (Write After Approval): Add myself.
 833
 834 2020-01-02  Luis Machado  <luis.machado@linaro.org>
 835
 836         * proc-service.c (get_ps_regcache): Remove reference to obsolete
 837         Cell BE architecture.
 838         * target.h (struct target_ops) <thread_architecture>: Likewise.
 839
 840 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
 841
 842         * Makefile.in: Use INSTALL_PROGRAM_ENV.
 843
 844 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
 845
 846         * MAINTAINERS (Write After Approval): Add myself.
 847
 848 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
 849
 850         * gdbarch.sh: Update copyright year range of generated files.
 851
 852 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
 853
 854         Update copyright year range in all GDB files.
 855
 856 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
 857
 858         * copyright.py: Convert to Python 3.
 859
 860 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
 861
 862         * copyright.py: Adapt after move of gnulib directory from gdb
 863         directory to toplevel directory.
 864
 865 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
 866
 867         * copyright.py (main): Exit if run from the wrong directory.
 868
 869 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
 870
 871         * top.c (print_gdb_version): Change copyright year to 2020.
 872
 873 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
 874
 875         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
 876
 877 For older changes see ChangeLog-2019.
 878 \f
 879 Local Variables:
 880 mode: change-log
 881 left-margin: 8
 882 fill-column: 74
 883 version-control: never
 884 coding: utf-8
 885 End: