gdb/ChangeLog

   1 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * jit.c (struct gdb_symtab): Add constructor, destructor,
   4         initialize fields.
   5         <linetable>: Change type to unique_xmalloc_ptr.
   6         <file_name>: Change type to std::string.
   7         (jit_symtab_open_impl): Allocate gdb_symtab with new.
   8         (jit_symtab_line_mapping_add_impl): Adjust.
   9         (finalize_symtab): Adjust, call delete on stab.
  10
  11 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  12
  13         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
  14
  15 2019-12-16  Tom Tromey  <tromey@adacore.com>
  16
  17         * windows-nat.c (windows_nat_target::attach): Update.
  18         * remote.c (extended_remote_target::attach): Update.
  19         * procfs.c (procfs_target::attach): Update.
  20         * nto-procfs.c (nto_procfs_target::attach): Update.
  21         (nto_procfs_target::create_inferior): Update.
  22         * inf-ptrace.c (inf_ptrace_target::attach): Update.
  23         * gnu-nat.c (gnu_nat_target::attach): Update.
  24         (gnu_nat_target::detach): Update.
  25         * darwin-nat.c (darwin_nat_target::attach): Update.
  26         * corefile.c (get_exec_file): Constify result.  Remove extraneous
  27         return.
  28         * bsd-kvm.c (bsd_kvm_target_open): Update.
  29         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
  30
  31 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
  32
  33         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
  34         (we no longer need to include time.h before pathmax.h)
  35
  36 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
  37
  38         * ada-exp.y (write_ambiguous_var): Update.
  39         * coffread.c (process_coff_symbol): Update.
  40         * ctfread.c (ctf_add_enum_member_cb): Update.
  41         (new_symbol): Update.
  42         * dwarf2read.c (fixup_go_packaging): Update.
  43         (new_symbol): Update.
  44         * language.c (language_alloc_type_symbol): Update.
  45         * mdebugread.c (new_symbol): Update.
  46         * minsyms.c (minimal_symbol_reader::record_full): Update.
  47         * psymtab.c (add_psymbol_to_bcache): Update.
  48         * stabsread.c (define_symbol): Update.
  49         (read_enum_type): Update.
  50         * symtab.c (symbol_set_language): Make this a member function...
  51         (general_symbol_info::set_language): ... here.
  52         * symtab.h (struct general_symbol_info) <set_language>: New function.
  53         (SYMBOL_SET_LANGUAGE): Remove.
  54         (symbol_set_language): Remove.
  55
  56 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
  57
  58         * ada-lang.c (ada_add_block_symbols): Update.
  59         (ada_collect_symbol_completion_matches): Update.
  60         * ax-gdb.c (gen_expr): Update.
  61         * block.c (block_lookup_symbol): Update.
  62         (block_lookup_symbol_primary): Update.
  63         (block_find_symbol): Update.
  64         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
  65         * dbxread.c (process_one_symbol): Update.
  66         * dictionary.c (insert_symbol_hashed): Update.
  67         (collate_pending_symbols_by_language): Update.
  68         (mdict_add_symbol): Update.
  69         * dwarf-index-write.c (write_psymbols): Update.
  70         * dwarf2read.c (fixup_go_packaging): Update.
  71         * findvar.c (read_var_value): Update.
  72         * ft32-tdep.c (ft32_skip_prologue): Update.
  73         * go-lang.c (go_symbol_package_name): Update.
  74         * language.h (scoped_switch_to_sym_language_if_auto::
  75         scoped_switch_to_sym_language_if_auto): Update.
  76         * linespec.c (find_method): Update.
  77         (find_label_symbols_in_block): Update.
  78         * mdebugread.c (parse_symbol): Update.
  79         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
  80         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
  81         (minimal_symbol_reader::install): Update.
  82         * moxie-tdep.c (moxie_skip_prologue): Update.
  83         * parse.c (parse_exp_in_context): Update.
  84         * psymtab.c (psymbol_name_matches): Update.
  85         (match_partial_symbol): Update.
  86         (lookup_partial_symbol): Update.
  87         (psymbol_hash): Update.
  88         (psymbol_compare): Update.
  89         * python/py-framefilter.c (extract_sym): Update.
  90         (py_print_single_arg): Update.
  91         * stabsread.c (define_symbol): Update.
  92         * stack.c (print_frame_arg): Update.
  93         (find_frame_funname): Update.
  94         (info_frame_command_core): Update.
  95         * symfile.c (set_initial_language): Update.
  96         * symtab.c (symbol_set_demangled_name): Update.
  97         (symbol_get_demangled_name): Update.
  98         (symbol_set_language): Update.
  99         (symbol_find_demangled_name): Update.
 100         (symbol_set_names): Update.
 101         (general_symbol_info::natural_name): Update.
 102         (general_symbol_info::demangled_name): Update.
 103         (general_symbol_info::search_name): Update.
 104         (symbol_matches_search_name): Update.
 105         (eq_symbol_entry): Update.
 106         (iterate_over_symbols): Update.
 107         (completion_list_add_symbol): Update.
 108         (completion_list_add_msymbol): Update.
 109         (completion_list_add_fields): Update.
 110         * symtab.h (struct general_symbol_info) <language>: New function.
 111         <language>: Rename to...
 112         <m_language>: ...this.
 113         (SYMBOL_LANGUAGE): Remove.
 114         (MSYMBOL_LANGUAGE): Remove.
 115         (struct symbol) <ctor>: Update.
 116         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 117
 118 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 119
 120         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 121         set the language of sym.
 122         * language.c (language_alloc_type_symbol): Likewise.
 123
 124 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 125
 126         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 127         PR gdb/23613
 128         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 129         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 130         (core_target_open): Use 'gdb_abspath'.
 131         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 132         'current_directory == NULL' case.
 133         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 134         explain what happens when 'current_directory' is NULL.
 135         * go32-nat.c (go32_nat_target::wait): Check if
 136         'current_directory' is NULL before call to 'chdir'.
 137         * source.c (add_path): Use 'gdb_abspath'.
 138         * top.c: Include 'gdbsupport/pathstuff.h'.
 139         (init_history): Use 'gdb_abspath'.
 140         (set_history_filename): Likewise.
 141         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 142         (tfile_target_open): Use 'gdb_abspath'.
 143
 144 2019-12-13  Tom Tromey  <tromey@adacore.com>
 145
 146         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 147         warning or error.
 148
 149 2019-12-13  Tom Tromey  <tromey@adacore.com>
 150
 151         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 152
 153 2019-12-13  Tom Tromey  <tromey@adacore.com>
 154
 155         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 156
 157 2019-12-13  Tom Tromey  <tromey@adacore.com>
 158
 159         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 160
 161 2019-12-13  Tom Tromey  <tromey@adacore.com>
 162
 163         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 164         (string_vappendf): Add ARI comment.
 165
 166 2019-12-13  Tom Tromey  <tromey@adacore.com>
 167
 168         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 169         floatformat_to_double.
 170         * target-float.c (host_float_ops<T>::from_target): Add ARI
 171         comment.
 172
 173 2019-12-13  Tom Tromey  <tromey@adacore.com>
 174
 175         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 176         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 177         ARI marker to abort.
 178         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 179
 180 2019-12-13  Tom Tromey  <tromey@adacore.com>
 181
 182         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 183
 184 2019-12-13  Tom Tromey  <tromey@adacore.com>
 185
 186         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 187
 188 2019-12-13  Tom Tromey  <tromey@adacore.com>
 189
 190         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 191         checks.
 192
 193 2019-12-13  Tom Tromey  <tromey@adacore.com>
 194
 195         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 196         end>: No longer "const".
 197
 198 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 199
 200         * jit.c: Fix indentation, replace spaces with tabs where
 201         applicable.
 202
 203 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 204
 205         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 206
 207 2019-12-12  Tom Tromey  <tom@tromey.com>
 208
 209         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 210         unique_ptr.
 211
 212 2019-12-12  Tom Tromey  <tom@tromey.com>
 213
 214         * progspace.h (objfile_list): New typedef.
 215         (class unwrapping_objfile_iterator)
 216         (struct unwrapping_objfile_range): Newl
 217         (struct program_space) <objfiles_range>: Change type.
 218         <objfiles>: Change return type.
 219         <add_objfile>: Change type of "objfile" parameter.
 220         <objfiles_list>: Now a list of shared_ptr.
 221         * progspace.c (program_space::add_objfile): Change type of
 222         "objfile".  Update.
 223         (program_space::remove_objfile): Update.
 224         * objfiles.h (struct objfile) <~objfile>: Make public.
 225         * objfiles.c (objfile::make): Update.
 226         (objfile::unlink): Don't call delete.
 227
 228 2019-12-12  Tom Tromey  <tom@tromey.com>
 229
 230         * symfile.c (symbol_file_clear): Update.
 231         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 232         method.
 233         * progspace.c (program_space::free_all_objfiles): New method.
 234         * objfiles.h (free_all_objfiles): Don't declare.
 235         * objfiles.c (free_all_objfiles): Move to program_space.
 236
 237 2019-12-12  Tom Tromey  <tom@tromey.com>
 238
 239         * progspace.c (program_space::add_objfile)
 240         (program_space::remove_objfile): Update.
 241         (program_space::multi_objfile_p): Remove.
 242         * objfiles.h (struct objfile) <next>: Remove.
 243         * objfiles.c (objfile::objfile): Update.
 244         (put_objfile_before): Update.
 245         (unlink_objfile): Update.
 246         * progspace.h (object_files): Remove.
 247         (struct program_space) <objfiles_head>: Remove.
 248         <objfiles_list>: New member.
 249         <objfiles_range, objfiles_safe_range>: Change type.
 250         (objfiles): Change return type.
 251         (objfiles_safe): Update.
 252         (multi_objfile_p): Rewrite and inline.
 253         (object_files): Remove macro.
 254
 255 2019-12-12  Tom Tromey  <tom@tromey.com>
 256
 257         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 258         second constructor.
 259         (basic_safe_range): New class.
 260
 261 2019-12-12  Tom Tromey  <tom@tromey.com>
 262
 263         * progspace.c (program_space::multi_objfile_p): New method.
 264         * printcmd.c (info_symbol_command): Update.
 265         * maint.c (maintenance_translate_address): Update.
 266         * objfiles.h (MULTI_OBJFILE_P): Remove.
 267         * progspace.h (struct program_space) <multi_objfile_p>: New
 268         method.
 269
 270 2019-12-12  Tom Tromey  <tom@tromey.com>
 271
 272         * progspace.h (struct program_space) <remove_objfile>: Declare.
 273         * progspace.c (program_space::remove_objfile): New method.
 274         * objfiles.c (unlink_objfile): Remove.
 275         (objfile::unlink): Call remove_objfile.
 276         (objfile): Don't call unlink_objfile.
 277
 278 2019-12-12  Tom Tromey  <tom@tromey.com>
 279
 280         * progspace.h (struct program_space) <add_objfile>: Declare
 281         method.
 282         * progspace.c (program_space::add_objfile): New method.
 283         * objfiles.c (~objfile): Don't unlink objfile.
 284         (put_objfile_before): Remove.
 285         (add_separate_debug_objfile): Don't call put_objfile_before.
 286         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 287         the per-program-space data.
 288
 289 2019-12-12  Tom Tromey  <tom@tromey.com>
 290
 291         * symfile.c (syms_from_objfile_1): Use objfile_up.
 292         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 293         method.
 294         (reread_symbols): Use objfile_up.
 295         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 296         unlink method.
 297         * objfiles.h (struct objfile) <~objfile>: Now private.
 298         <unlink>: New method.
 299         (struct objfile_deleter): New.
 300         (objfile_up): New typedef.
 301         * objfiles.c (objfile::unlink): New method.
 302         (free_objfile_separate_debug, free_all_objfiles)
 303         (objfile_purge_solibs): Use it.
 304         * jit.c (jit_unregister_code): Remove.
 305         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 306         objfile.
 307         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 308         objfile.
 309         * compile/compile-object-load.c (compile_object_load): Use
 310         objfile_up.
 311
 312 2019-12-12  Tom Tromey  <tom@tromey.com>
 313
 314         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 315         objfile::make.
 316         * objfiles.h (struct objjfile) <make>: No longer inline.
 317         (add_separate_debug_objfile): Don't declare.
 318         * objfiles.c (add_separate_debug_objfile): Now static.
 319         (objfile::make): Move from objfiles.h.  Call
 320         add_separate_debug_objfile.  Add "parent" parameter.
 321
 322 2019-12-12  Tom Tromey  <tom@tromey.com>
 323
 324         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 325         * objfiles.h (struct objfile): Make constructor private.
 326         <make>: New static method.
 327         * jit.c (jit_object_close_impl): Update.
 328
 329 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 330
 331         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 332         gdb::byte_vector.
 333
 334 2019-12-12  Tom Tromey  <tromey@adacore.com>
 335
 336         * xml-support.c (xml_fetch_content_from_file): Don't call
 337         malloc_failure.
 338         * utils.h (class gdb_argv): Remove malloc_failure comment.
 339         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 340
 341 2019-12-12  Tom Tromey  <tromey@adacore.com>
 342
 343         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 344         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 345         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 346         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 347         * riscv-ravenscar-thread.c: New file.
 348         * riscv-ravenscar-thread.h: New file.
 349         * riscv-tdep.c (riscv_gdbarch_init): Call
 350         register_riscv_ravenscar_ops.
 351
 352 2019-12-12  Tom Tromey  <tromey@adacore.com>
 353
 354         * gdbsupport/thread-pool.c (set_thread_name): Use
 355         ATTRIBUTE_UNUSED.
 356
 357 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 358
 359         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 360         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 361         macros.
 362
 363 2019-12-11  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-win.c (tui_set_win_height_command): Call
 366         tui_adjust_window_height.
 367         (tui_adjust_win_heights, new_height_ok): Remove.
 368         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 369         * tui/tui-layout.c (tui_adjust_window_height): New function.
 370
 371 2019-12-11  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-win.c (tui_resize_all): Remove code, call
 374         tui_apply_current_layout.
 375
 376 2019-12-11  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 379         * tui/tui-layout.c (standard_layouts, applied_layout): New
 380         globals.
 381         (tui_apply_current_layout): New function.
 382         (show_layout): Set applied_layout.  Call
 383         tui_apply_current_layout.
 384         (show_source_command, show_disasm_command)
 385         (show_source_disasm_command, show_data)
 386         (show_source_or_disasm_and_command): Remove.
 387         (initialize_layouts): New function.
 388         (_initialize_tui_layout): Call initialize_layouts.
 389
 390 2019-12-11  Tom Tromey  <tom@tromey.com>
 391
 392         * tui/tui-layout.h (class tui_layout_base)
 393         (class tui_layout_window, class tui_layout_split): New.
 394         * tui/tui-layout.c (tui_get_window_by_name)
 395         (tui_layout_window::clone, tui_layout_window::apply)
 396         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 397         (tui_layout_split::add_window, tui_layout_split::clone)
 398         (tui_layout_split::get_sizes)
 399         (tui_layout_split::set_weights_from_heights)
 400         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 401         functions.
 402         (tui_layout_split::add_split, tui_layout_split::add_split)
 403         (tui_layout_split::set_weights_from_heights)
 404         (tui_layout_split::set_weights_from_heights): New functions.
 405
 406 2019-12-11  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 409         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 410         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 411         * tui/tui-data.h (struct tui_point): Remove.
 412         (struct tui_gen_win_info) <origin>: Remove.
 413         <x, y>: New fields.
 414         * tui/tui-command.c (tui_cmd_window::resize): Update.
 415
 416 2019-12-11  Tom Tromey  <tom@tromey.com>
 417
 418         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 419         Implement.
 420         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 421         Implement.
 422         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 423         method.
 424         (struct tui_win_info) <min_height>: Implement.
 425
 426 2019-12-11  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 429         (struct tui_win_info) <can_box>: Update.
 430
 431 2019-12-11  Tom Tromey  <tom@tromey.com>
 432
 433         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 434         method.
 435         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 436         method.
 437         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 438         method.
 439         (struct tui_win_info) <max_height>: Now override.
 440
 441 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 442
 443         * NEWS: Create a new section for the next release branch.
 444         Rename the section of the current branch, now that it has
 445         been cut.
 446
 447 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 448
 449         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 450         * version.in: Bump version to 10.0.50.DATE-git.
 451
 452 2019-12-11  Tom Tromey  <tromey@adacore.com>
 453
 454         PR build/25268:
 455         * gdbsupport/thread-pool.c (set_thread_name): New function.
 456         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 457         (thread_pool::thread_function): Call set_thread_name.
 458
 459 2019-12-11  Tom Tromey  <tromey@adacore.com>
 460
 461         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 462         bfd_get_signed_8.
 463
 464 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 465
 466         * NEWS: Document -raw-values option and the related setting commands.
 467         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 468         only set it on when /r is given.
 469         * valprint.c (value_print_option_defs): New element raw-values.
 470         * Makefile.in: Add the new file.
 471
 472 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 473
 474         * gdbsupport/safe-strerror.c: Supress the unused function warning
 475         for select_strerror_r.
 476
 477 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 478
 479         * config.in: Regenerate.
 480         * configure: Regenerate.
 481         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 482         safe_strerror instead of strerror.
 483         * gdbsupport/common.m4: Don't check for strerror.
 484         * gdbsupport/safe-strerror.c: Support both the glibc version
 485         of strerror_r and the XSI version.
 486
 487 2019-12-10  Tom Tromey  <tromey@adacore.com>
 488
 489         * ada-typeprint.c (print_choices): Use a single "?".
 490         (print_variant_part): Print "?" if the discriminant name
 491         is not known.
 492
 493 2019-12-10  George Barrett  <bob@bob131.so>
 494
 495         Fix scripted probe breakpoints.
 496         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 497         declaration forward.
 498         (breakpoint_ops_for_event_location_type)
 499         (breakpoint_ops_for_event_location): Add function definitions.
 500         (break_command_1, trace_command): Use
 501         breakpoint_ops_for_event_location.
 502         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 503         declarations.
 504         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 505         breakpoint_ops_for_event_location.
 506         * python/py-breakpoint.c (bppy_init): Use
 507         breakpoint_ops_for_event_location.
 508
 509 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 510
 511         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 512         when ranking an lvalue argument for an rvalue parameter.
 513
 514 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 515
 516         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 517         template argument for scoped_restore_tmpl from bool to int.
 518
 519 2019-12-07  Keith Seitz  <keiths@redhat.com>
 520
 521         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 522         (build_id_to_debug_bfd): Make static, rewriting to use
 523         build_id_to_bfd_suffix.
 524         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 525         adding `suffix' parameter. Append SUFFIX to file names
 526         when searching for matching files.
 527         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 528         (build_id_to_exec_bfd): Likewise.
 529         * build-id.h (build_id_to_debug_bfd): Clarify that function
 530         searches for BFD of debug info file.
 531         (build_id_to_exec_bfd): Declare.
 532         * corelow.c: Include build-id.h.
 533         (locate_exec_from_corefile_build_id): New function.
 534         (core_target_open): If no executable BFD is found,
 535         search for a core file BFD using build-id.
 536
 537 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 538
 539         * bcache.c: Put in namespace gdb.
 540         * bcache.h: Likewise.
 541         * gdbtypes.c (check_types_worklist): Update.
 542         (types_deeply_equal): Update.
 543         * macrotab.c (struct macro_table) <bcache>: Update.
 544         (new_macro_table): Update.
 545         * macrotab.h (struct bcache): Put this forward declaration
 546         inside namespace gdb.
 547         (new_macro_table): Update.
 548         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 549         Update.
 550         <macro_cache>: Update.
 551         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 552
 553 2019-12-06  Tom de Vries  <tdevries@suse.de>
 554
 555         PR symtab/24971
 556         * block.c (best_symbol, better_symbol): New function.
 557         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 558         decl.
 559
 560 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 561
 562         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 563         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 564         for ranking see-through reference cases.
 565
 566 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 567         * stack.c (faas_command): Check a command is provided.
 568         * thread.c (taas_command, tfaas_command): Likewise.
 569
 570 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 571         * inferior.c (prune_inferiors):  Only call delete_inferior,
 572         Do not modify the inferior list.
 573
 574 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 575
 576         * c-exp.y: Update calls to lookup_typename,
 577         lookup_signed_typename and lookup_unsigned_typename.
 578         * c-lang.c (evaluate_subexp_c): Likewise.
 579         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 580         Likewise.
 581         * eval.c (binop_promote): Likewise.
 582         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 583         (lookup_unsigned_typename): Likewise.
 584         (lookup_signed_typename): Likewise.
 585         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 586         (lookup_signed_typename): Likewise.
 587         (lookup_typename): Likewise.
 588         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 589         lookup_typename, lookup_signed_typename,
 590         lookup_unsigned_typename.
 591         * m2-exp.y: Likewise.
 592         * printcmd.c (printf_wide_c_string): Likewise.
 593         (ui_printf): Likewise.
 594         * python/py-type.c (typy_lookup_typename): Likewise.
 595         * python/py-xmethods.c (python_xmethod_worker::invoke):
 596         Likewise.
 597         * rust-exp.y: Likewise.
 598
 599 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 600
 601         * configure.nat (obsd64): Add missing files x86-nat.o and
 602         nat/x86-dregs.o.
 603
 604 2019-12-04  Tom Tromey  <tom@tromey.com>
 605
 606         * valprint.c (val_print_string): Use metadata_style.
 607         * go-valprint.c (print_go_string): Use metadata style.
 608         * p-valprint.c (pascal_object_print_static_field): Use metadata
 609         style.
 610         * cp-valprint.c (cp_print_static_field): Use metadata style.
 611
 612 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 613             Chris January  <chris.january@arm.com>
 614
 615         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 616         tokens.
 617         (typebase): New patterns for complex, single/double precision, and
 618         single/double complex.
 619         (f77_keywords): Change token for complex keyword, and add single,
 620         double, and precision keywords.
 621
 622 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 623
 624         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 625         "info io_registers".
 626
 627 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 628
 629         * regcache.c (cooked_read_test): Initialize thread list of
 630         mock_inferior.
 631
 632 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 633
 634         * aarch64-linux-tdep.c: Remove includes.
 635
 636 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 637
 638         * aarch64-tdep.c: Remove includes.
 639
 640 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 641
 642         * filtered-iterator.h (filtered_iterator) <operator==,
 643         operator!=>: Compare wrapped iterators, not wrapped pointers.
 644         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 645         unittests/filtered_iterator-selftests.c.
 646         * unittests/filtered_iterator-selftests.c: New file.
 647
 648 2019-12-04  Tom Tromey  <tromey@adacore.com>
 649
 650         * gdbtypes.c (create_range_type): Inherit endianity
 651         from base type.
 652
 653 2019-12-04  Tom Tromey  <tromey@adacore.com>
 654
 655         * ada-lang.c (decode_constrained_packed_array)
 656         (ada_value_assign, value_assign_to_component): Update.
 657         * dwarf2loc.c (rw_pieced_value, access_memory)
 658         (dwarf2_compile_expr_to_ax): Update.
 659         * dwarf2read.c (dwarf2_add_field): Update.
 660         * eval.c (evaluate_subexp_standard): Update.
 661         * gdbarch.c, gdbarch.h: Rebuild.
 662         * gdbarch.sh (bits_big_endian): Remove.
 663         * gdbtypes.h (union field_location): Update comment.
 664         * target-descriptions.c (make_gdb_type): Update.
 665         * valarith.c (value_bit_index): Update.
 666         * value.c (struct value) <bitpos>: Update comment.
 667         (unpack_bits_as_long, modify_field): Update.
 668         * value.h (value_bitpos): Update comment.
 669
 670 2019-12-04  Tom Tromey  <tromey@adacore.com>
 671
 672         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 673         endian-ness.
 674
 675 2019-12-04  Tom Tromey  <tromey@adacore.com>
 676
 677         * dwarf2read.c (dwarf2_init_float_type)
 678         (dwarf2_init_complex_target_type): Add byte_order parameter.
 679         (read_base_type): Compute byte order earlier.
 680         * gdbtypes.c (init_float_type): Add byte_order parameter.
 681         * gdbtypes.h (init_float_type): Add byte_order parameter.
 682
 683 2019-12-04  Tom Tromey  <tromey@adacore.com>
 684
 685         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 686
 687 2019-12-04  Tom Tromey  <tromey@adacore.com>
 688
 689         * dwarf2read.c (process_structure_scope): Initialize
 690         "discr_offset".
 691
 692 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 693
 694         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 695         add it into the search spec.
 696         (parse_max_results_option): New function.
 697         (mi_info_functions_or_variables): Parse -max-results flag and pass
 698         it to mi_symbol_info.
 699         (mi_cmd_symbol_info_modules): Likewise.
 700         (mi_cmd_symbol_info_types): Likewise.
 701         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 702         return type to bool, change result container into a set, and don't
 703         add new results if we have enough already.
 704         (global_symbol_searcher::add_matching_msymbols): Change return
 705         type to bool, and don't add new results if we have enough already.
 706         (sort_search_symbols_remove_dups): Delete.
 707         (global_symbol_searcher::search): Early exit from search loop when
 708         we have enough results.  Use a std::set to collect the results
 709         from calling add_matching_symbols.
 710         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 711         member function.
 712         (global_symbol_searcher) <m_max_search_results>: New member
 713         variable.
 714         (global_symbol_searcher) <add_matching_symbols>: Update header
 715         comment and change return type to bool.
 716         (global_symbol_searcher) <add_matching_msymbols>: Update header
 717         comment and change return type to bool.
 718
 719 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 720
 721         * symtab.c (symbol_search::compare_search_syms): Update header
 722         comment.
 723         (global_symbol_searcher::is_suitable_msymbol): New function.
 724         (global_symbol_searcher::expand_symtabs): New function.
 725         (global_symbol_searcher::add_matching_symbols): New function.
 726         (global_symbol_searcher::add_matching_msymbols): New function.
 727         (global_symbol_searcher::search): Move most of the content
 728         into the new functions above, and call them as needed.
 729         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 730         function.
 731         (global_symbol_searcher) <add_matching_symbols>: New member
 732         function.
 733         (global_symbol_searcher) <add_matching_msymbols>: New member
 734         function.
 735         (global_symbol_searcher) <is_suitable_msymbol>: New member
 736         function.
 737
 738 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 739
 740         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 741         -symbol-info-module-variables entries.
 742         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 743         (mi_cmd_symbol_info_module_variables): Declare.
 744         * mi/mi-symbol-cmds.c
 745         (module_symbol_search_iterator): New typedef.
 746         (output_module_symbols_in_single_module_and_file): New function.
 747         (output_module_symbols_in_single_module): New function.
 748         (mi_info_module_functions_or_variables): New function.
 749         (mi_cmd_symbol_info_module_functions): New function.
 750         (mi_cmd_symbol_info_module_variables): New function.
 751         * NEWS: Mention new MI command.
 752
 753 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 754
 755         * bcache.c (hash): Remove.
 756         (hash_continue): Remove.
 757         * bcache.h (hash): Remove.
 758         (hash_continue): Remove.
 759         (struct bcache) <ctor>: Update.
 760         * psymtab.c (psymbol_hash): Update.
 761         * stabsread.c (hashname): Update.
 762         * utils.h (fast_hash): Add an argument for a start value,
 763         defaulting to zero.
 764
 765 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 766         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 767         (destroy_block_symbol_cache): New function.
 768         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 769         (resize_symbol_cache): Likewise.
 770
 771 2019-12-02  Tom Tromey  <tom@tromey.com>
 772
 773         * unittests/tui-selftests.c (run_tests): Make conditional.
 774         (_initialize_tui_selftest): Make conditional.
 775
 776 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 777
 778         * aix-thread.c (debug_aix_thread): Change type to bool.
 779
 780 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 781
 782         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 783
 784 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 785
 786         * dwarf2read.c (read_tag_string_type): Read the fields required to
 787         make a dynamic string, and possibly create a dynamic range for the
 788         string.
 789         (attr_to_dynamic_prop): Setup is_reference based on the type of
 790         attribute being processed.
 791         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 792         (resolve_dynamic_array): Rename to...
 793         (resolve_dynamic_array_or_string): ...this, update header comment,
 794         and accept TYPE_CODE_STRING.
 795         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 796
 797 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 798
 799         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 800         of its implementation from...
 801         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 802         the new function.
 803
 804 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 805
 806         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 807         create a range with stride where appropriate.
 808         * f-valprint.c: Include 'gdbarch.h'.
 809         (f77_print_array_1): Take the stride into account when walking the
 810         array.  Also convert the stride into addressable units.
 811         * gdbtypes.c (create_range_type): Initialise the stride to
 812         constant zero.
 813         (create_range_type_with_stride): New function, initialise the
 814         range as normal, and then setup the stride.
 815         (has_static_range): Include the stride here.  Also change the
 816         return type to bool.
 817         (create_array_type_with_stride): Consider the range stride if the
 818         array isn't given its own stride.
 819         (resolve_dynamic_range): Resolve the stride if needed.
 820         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 821         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 822         (TYPE_BIT_STRIDE): Define.
 823         (TYPE_ARRAY_BIT_STRIDE): Define.
 824         (create_range_type_with_stride): Declare.
 825         * valarith.c (value_subscripted_rvalue): Take range stride into
 826         account when walking the array.
 827
 828 2019-12-01  Tom Tromey  <tom@tromey.com>
 829
 830         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 831         specially.
 832
 833 2019-12-01  Tom Tromey  <tom@tromey.com>
 834
 835         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 836         \0.
 837         * unittests/tui-selftests.c: New file.
 838         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 839
 840 2019-12-01  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 843
 844 2019-12-01  Tom Tromey  <tom@tromey.com>
 845
 846         * NEWS: Document new settings.
 847         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 848         * tui/tui-win.c (_initialize_tui_win): Add border style
 849         observers.
 850         * tui/tui-io.h (tui_apply_style): Declare.
 851         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 852         longer static.
 853         (apply_ansi_escape, tui_set_reverse_mode): Update.
 854         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 855         Add "skip_intensity" parameter.
 856         <changed>: New member.
 857         <do_set_value>: Declare.
 858         (tui_border_style, tui_active_border_style): Declare.
 859         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 860         globals.
 861         (cli_style_option): Initialize "changed".
 862         (cli_style_option::do_set_value): New function.
 863         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 864         parameter.  Update.
 865         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 866         (_initialize_cli_style): Update.  Create TUI border style
 867         commands.
 868
 869 2019-12-01  Tom Tromey  <tom@tromey.com>
 870
 871         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 872         parameter.
 873         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 874         parameter.
 875         * tui/tui-win.h (compact_source): Declare.
 876         * tui/tui-win.c (compact_source): New global.
 877         (tui_set_compact_source, tui_show_compact_source): New functions.
 878         (_initialize_tui_win): Add "compact-source" setting.
 879         * tui/tui-source.c (tui_source_window::set_contents): Handle
 880         compact_source setting.
 881         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 882         * NEWS: Document new setting.
 883
 884 2019-11-30  Tom Tromey  <tom@tromey.com>
 885
 886         * dwarf2read.c (dwarf2_add_field): Include field offset when
 887         computing variant part length.
 888
 889 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 890         * NEWS:  Mention define-prefix.  Tell that command names can now
 891         contain a . character.
 892
 893 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 894
 895         * command.h (valid_cmd_char_p): Declare.
 896         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 897         the check of valid command char.
 898         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 899         valid_cmd_char_p.
 900         * cli/cli-script.c (validate_comname): Likewise.
 901         * completer.c (gdb_completer_command_word_break_characters):
 902         Do not remove . from the word break char, update comments.
 903         (complete_line_internal_1): Use valid_cmd_char_p.
 904         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 905         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 906
 907 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 908
 909         * cli/cli-script.c (do_define_command): Ensure a redefined
 910         prefix command is kept as a prefix command.
 911         (define_prefix_command): New function.
 912         (show_user_1): Report user defined prefixes.
 913         (_initialize_cli_script):  Create the new 'define-prefix' command.
 914         Add completers for 'define' and 'document'.
 915         * top.c (execute_command):  If command is a user-defined prefix only
 916         command, report the list of commands for this prefix command.
 917
 918 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 919
 920         * valops.c (find_oload_champ): Improve debug output.
 921
 922 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 923
 924         * valops.c (find_oload_champ): Print part of debug messages
 925         before the badness vector is std::move'd.
 926
 927 2019-11-28  Tom Tromey  <tom@tromey.com>
 928
 929         * value.c (creal_internal_fn): Fix comment.
 930
 931 2019-11-28  Tom Tromey  <tom@tromey.com>
 932
 933         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 934         flag_bound_evaluated>: Now unsigned.
 935
 936 2019-11-28  Tom Tromey  <tom@tromey.com>
 937
 938         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 939         declare.
 940
 941 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 942
 943         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 944         debug output.
 945         * jit.c (jit_unregister_code): Add debug print to match
 946         `jit_register_code`.
 947
 948 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 949
 950         * NEWS: Mention the new multithreaded symbol loading.
 951
 952 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 953
 954         * maint.c (n_worker_threads): Default to 0.
 955         (worker_threads_disabled): New function.
 956         * maint.h (worker_threads_disabled): New function.
 957         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
 958         here if worker_threads_disabled () is true.
 959         (minimal_symbol_reader::install): Skip all threading if
 960         worker_threads_disabled () is true.
 961
 962 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 963
 964         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
 965         hash code if possible.
 966         (add_minsym_to_demangled_hash_table): Likewise.
 967         (minimal_symbol_reader::install): Compute the hash codes for msymbol
 968         on the background thread.
 969         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
 970         Add these fields.
 971
 972 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 973
 974         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
 975         of the mangled name on the background thread.
 976         * symtab.c (symbol_set_names): Allow passing in the hash of the
 977         linkage_name.
 978         * symtab.h (symbol_set_names): Likewise.
 979
 980 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 981
 982         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
 983         physnames are computed for inherited DIEs.
 984
 985 2019-11-27  Tom Tromey  <tromey@adacore.com>
 986
 987         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 988         backslashes.
 989         * cp-support.c: Remove unnecessary backslashes.
 990
 991 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 992
 993         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 994         with sym->set_linkage_name.
 995         * coffread.c (coff_read_enum_type): Likewise.
 996         * mdebugread.c (parse_symbol): Likewise.
 997         * stabsread.c (patch_block_stabs): Likewise.
 998         (define_symbol): Likewise.
 999         (read_enum_type): Likewise.
1000         (common_block_end): Likewise.
1001         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1002         function.
1003         (SYMBOL_SET_LINKAGE_NAME): Remove.
1004         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1005         with sym->set_linkage_name.
1006
1007 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1010         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1011         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1012         * NEWS: Mention new MI command.
1013
1014 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1015
1016         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1017         '-symbol-info-types', and '-symbol-info-variables'.
1018         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1019         (mi_cmd_symbol_info_types): Declare.
1020         (mi_cmd_symbol_info_variables): Declare.
1021         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1022         (output_debug_symbol): New function.
1023         (output_nondebug_symbol): New function.
1024         (mi_symbol_info): New function.
1025         (mi_info_functions_or_variables): New function.
1026         (mi_cmd_symbol_info_functions): New function.
1027         (mi_cmd_symbol_info_types): New function.
1028         (mi_cmd_symbol_info_variables): New function.
1029         * NEWS: Mention new commands.
1030
1031 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1032
1033         * symtab.c (symbol_to_info_string): New function, most content
1034         moved from print_symbol_info, but updated to return a std::string.
1035         (print_symbol_info): Update to use symbol_to_info_string and print
1036         returned string.
1037         * symtab.h (symbol_to_info_string): Declare new function.
1038
1039 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1040
1041         * python/python.c (gdbpy_rbreak): Convert to using
1042         global_symbol_searcher.
1043         * symtab.c (file_matches): Convert return type to bool, change
1044         file list to std::vector, update header comment.
1045         (search_symbols): Rename to...
1046         (global_symbol_searcher::search): ...this and update now its
1047         a member function of global_symbol_searcher.  Take account of the
1048         changes to file_matches.
1049         (symtab_symbol_info): Convert to using global_symbol_searcher.
1050         (rbreak_command): Likewise.
1051         (search_module_symbols): Likewise.
1052         * symtab.h (enum symbol_search): Update comment.
1053         (search_symbols): Remove declaration.
1054         (class global_symbol_searcher): New class.
1055
1056 2019-11-26  Tom Tromey  <tromey@adacore.com>
1057
1058         * cp-support.c (_initialize_cp_support): Conditionally initialize
1059         gdb_demangle_attempt_core_dump.
1060
1061 2019-11-26  Tom Tromey  <tom@tromey.com>
1062
1063         * python/py-function.c (fnpy_init): Update.
1064         * value.h (add_internal_function): Adjust declaration.
1065         * value.c (function_destroyer): Remove.
1066         (do_add_internal_function): Don't set destroyer or copy name.
1067         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1068         Set name_allocated.
1069         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1070         (cmdpy_init): Set name_allocated.
1071         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1072         member.
1073         (~cmd_list_element): Free "name" if needed.
1074
1075 2019-11-26  Tom Tromey  <tom@tromey.com>
1076
1077         * value.h (add_internal_function): Add new overload.  Move
1078         documentation from value.h.
1079         * value.c (do_add_internal_function): New function.
1080         (add_internal_function): Use it.  Add new overload.
1081         (function_destroyer): Don't free doc.
1082         * python/py-function.c (fnpy_init): Update.
1083
1084 2019-11-26  Tom Tromey  <tom@tromey.com>
1085
1086         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1087         (cmdpy_init): Set "doc_allocated".
1088
1089 2019-11-26  Tom Tromey  <tom@tromey.com>
1090
1091         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1092         name of worker thread.
1093         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1094         pthread_setname_np.
1095         * configure, config.in: Rebuild.
1096
1097 2019-11-26  Tom Tromey  <tom@tromey.com>
1098
1099         * python/python.c (class gdbpy_gil): New.
1100         (struct gdbpy_event): Add constructor, destructor, operator().
1101         (gdbpy_post_event): Use run_on_main_thread.
1102         (gdbpy_initialize_events): Remove.
1103         (do_start_initialization): Update.
1104
1105 2019-11-26  Tom Tromey  <tom@tromey.com>
1106
1107         * NEWS: Add entry.
1108         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1109         commands.  Call update_thread_pool_size.
1110         (update_thread_pool_size, maintenance_set_worker_threads): New
1111         functions.
1112         (n_worker_threads): New global.
1113
1114 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1115             Tom Tromey  <tom@tromey.com>
1116
1117         * minsyms.c (minimal_symbol_reader::install): Use
1118         parallel_for_each.
1119         * gdbsupport/parallel-for.h: New file.
1120         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1121
1122 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1123             Tom Tromey  <tom@tromey.com>
1124
1125         * gdbsupport/thread-pool.h: New file.
1126         * gdbsupport/thread-pool.c: New file.
1127         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1128         (HFILES_NO_SRCDIR): Add thread-pool.h.
1129
1130 2019-11-26  Tom Tromey  <tom@tromey.com>
1131
1132         * event-top.h (thread_local_segv_handler): Declare.
1133         * event-top.c (thread_local_segv_handler): New global.
1134         (install_handle_sigsegv, handle_sigsegv): New functions.
1135         (async_init_signals): Install SIGSEGV handler.
1136         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1137         thread-local.
1138         (report_failed_demangle): New function.
1139         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1140         handler-setting code, instead use segv_handler.  Run warning code
1141         on main thread.
1142
1143 2019-11-26  Tom Tromey  <tom@tromey.com>
1144
1145         * run-on-main-thread.c: New file.
1146         * run-on-main-thread.h: New file.
1147         * unittests/main-thread-selftests.c: New file.
1148         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1149         main-thread-selftests.c.
1150         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1151         (COMMON_SFILES): Add run-on-main-thread.c.
1152
1153 2019-11-26  Tom Tromey  <tom@tromey.com>
1154
1155         * main.c (setup_alternate_signal_stack): Remove.
1156         (captured_main_1): Use gdb::alternate_signal_stack.
1157         * gdbsupport/alt-stack.h: New file.
1158
1159 2019-11-26  Tom Tromey  <tom@tromey.com>
1160
1161         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1162         Remove comment.
1163         (save_original_signals_state, restore_original_signals_state): Use
1164         gdb_sigmask.
1165         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1166         (_initialize_linux_nat): Use gdb_sigmask.
1167         * guile/guile.c (_initialize_guile): Use block_signals.
1168         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1169         * gdbsupport/gdb-sigmask.h: New file.
1170         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1171         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1172         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1173         pthread_sigmask.
1174         * configure, config.in: Rebuild.
1175         * gdbsupport/block-signals.h: New file.
1176
1177 2019-11-26  Tom Tromey  <tom@tromey.com>
1178
1179         * acinclude.m4: Include ax_pthread.m4.
1180         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1181         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1182         (CLIBS): Use PTHREAD_LIBS.
1183         (aclocal_m4_deps): Add ax_pthread.m4.
1184         * config.in, configure: Rebuild.
1185         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1186
1187 2019-11-26  Tom Tromey  <tom@tromey.com>
1188
1189         * symtab.h (struct minimal_symbol) <name_set>: New member.
1190         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1191         Don't call symbol_set_names.
1192         (minimal_symbol_reader::install): Call symbol_set_names.
1193
1194 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1195
1196         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1197         restore_active_ext_lang, as GIL is needed for (indirectly)
1198         called PyOS_InterruptOccurred.
1199
1200 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1201
1202         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1203         definition.
1204
1205 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1206
1207         * remote-sim.c (simulator_command): Make static, remove
1208         declaration.
1209
1210 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1211
1212         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1213         static.
1214         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1215         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1216         (main): Likewise.
1217         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1218         (main): Likewise.
1219         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1220         (main): Likewise.
1221         * unittests/basic_string_view/element_access/char/1.cc (test01):
1222         Likewise.
1223         (main): Likewise.
1224         * unittests/basic_string_view/element_access/char/empty.cc (main):
1225         Likewise.
1226         * unittests/basic_string_view/element_access/char/front_back.cc
1227         (test01): Likewise.
1228         (main): Likewise.
1229         * unittests/basic_string_view/inserters/char/2.cc (test05):
1230         Likewise.
1231         (main): Likewise.
1232         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1233         (test01): Likewise.
1234         (main): Likewise.
1235         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1236         (test01): Likewise.
1237         (main): Likewise.
1238         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1239         Likewise.
1240         * unittests/basic_string_view/operations/compare/char/1.cc
1241         (test01): Likewise.
1242         (main): Likewise.
1243         * unittests/basic_string_view/operations/compare/char/13650.cc
1244         (test01): Likewise.
1245         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1246         Likewise.
1247         (main): Likewise.
1248         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1249         Likewise.
1250         (main): Likewise.
1251         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1252         Likewise.
1253         (main): Likewise.
1254         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1255         Likewise.
1256         (main): Likewise.
1257         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1258         Likewise.
1259         (main): Likewise.
1260         * unittests/basic_string_view/operations/find/char/4.cc (main):
1261         Likewise.
1262         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1263         Likewise.
1264         (main): Likewise.
1265         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1266         Likewise.
1267         (main): Likewise.
1268         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1269         Likewise.
1270         (main): Likewise.
1271         * unittests/basic_string_view/operations/substr/char/1.cc
1272         (test01): Likewise.
1273         (main): Likewise.
1274         * unittests/basic_string_view/operators/char/2.cc (main):
1275         Likewise.
1276         * unittests/optional/assignment/1.cc (test): Likewise.
1277         * unittests/optional/assignment/2.cc (test): Likewise.
1278         * unittests/optional/assignment/3.cc (test): Likewise.
1279         * unittests/optional/assignment/4.cc (test): Likewise.
1280         * unittests/optional/assignment/5.cc (test): Likewise.
1281         * unittests/optional/assignment/6.cc (test): Likewise.
1282         * unittests/optional/assignment/7.cc (test): Likewise.
1283         * unittests/optional/cons/copy.cc (test): Likewise.
1284         * unittests/optional/cons/default.cc (test): Likewise.
1285         * unittests/optional/cons/move.cc (test): Likewise.
1286         * unittests/optional/cons/value.cc (test): Likewise.
1287         * unittests/optional/in_place.cc (test): Likewise.
1288         * unittests/optional/observers/1.cc (test): Likewise.
1289         * unittests/optional/observers/2.cc (test): Likewise.
1290
1291 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1292
1293         * tui-win.h (tui_set_var_cmd): Remove.
1294         * tui-win.c (tui_set_var_cmd): Make static.
1295
1296 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1297
1298         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1299         rbreak_command_wrapper): Remove.
1300         * symtab.c (rbreak_command_wrapper): Remove.
1301
1302 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1303
1304         * inferior.h (info_terminal_command): Remove declaration.
1305         * inflow.c (info_terminal_command): Make static.
1306
1307 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1308
1309         * inferior.c (exit_inferior_silent): Remove.
1310
1311 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1312
1313         * dictionary.c (dict_empty, mdict_empty): Remove.
1314         * dictionary.c (mdict_empty): Remove.
1315
1316 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1317
1318          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1319          (arc_insn_get_memory_offset): Likewise.
1320          (arc_insn_dump): Likewise.
1321          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1322          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1323          * dictionary.c (dict_iterator_next): Likewise.
1324          (dict_iter_match_first): Likewise.
1325          (dict_iter_match_next): Likewise.
1326          * f-lang.c (evaluate_subexp_f): Likewise.
1327          * hppa-tdep.c (hppa_read_pc): Likewise.
1328          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1329          * parse.c (write_exp_elt_msym): Likewise.
1330          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1331          * remote.c (remote_packet_size): Likewise.
1332          (remote_notif_stop_parse): Likewise.
1333          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1334          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1335          * source.c (prepare_path_for_appending): Likewise.
1336          * sparc64-linux-tdep.c
1337          (sparc64_linux_handle_segmentation_fault); Likewise.
1338          * stack.c (frame_selection_by_function_completer): Likewise.
1339
1340 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1341
1342         * completer.c (set_gdb_completion_word_break_characters):
1343         Remove.
1344
1345 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1346
1347         * dwarf-index-write.c: Include dwarf-index-write.h.
1348         * mi/mi-interp.c: Include mi/mi-interp.h.
1349
1350 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1351
1352         * aarch32-tdep.c: Include aarch32-tdep.h.
1353         * aarch32-tdep.h: Forward-declare struct target_desc.
1354
1355 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1356
1357         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1358         strerror.
1359         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1360         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1361
1362 2019-11-25  Tom de Vries  <tdevries@suse.de>
1363
1364         * contrib/words.sh: Add -c option.
1365
1366 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1367
1368         * solib.c (solib_find_1): Change int to bool.
1369         (exec_file_find): Change int to bool.
1370         (solib_find): Change int to bool.
1371         (solib_read_symbols): Change int to bool.
1372         (solib_used): Change int to bool.
1373         (solib_add): Change int to bool.
1374         (info_sharedlibrary_command): Change int to bool.
1375         (solib_contains_address_p): Change int to bool.
1376         (solib_keep_data_in_core): Change int to bool.
1377         (in_solib_dynsym_resolve_code): Change int to bool.
1378         (reload_shared_libraries_1): Change int to bool.
1379         (gdb_sysroot_changed): Change int to bool.
1380         * solib.h (solib_read_symbols): Change int to bool.
1381         (solib_contains_address_p): Change int to bool.
1382         (solib_keep_data_in_core): Change int to bool.
1383         (in_solib_dynsym_resolve_code): Change int to bool.
1384         (libpthread_name_p): Change int to bool.
1385
1386 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1387
1388         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1389         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1390         (remote_packet_max_chars): New static global.
1391         (show_remote_packet_max_chars): New function.
1392         (remote_target::putpkt_binary): Adjust to use new
1393         remote_packet_max_chars option.
1394         (remote_target::getpkt_or_notif_sane_1): Likewise.
1395         (_initialize_remote): Register new remote-packet-max-chars option.
1396
1397 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1398
1399         * m68k-linux-nat.c: Include gdbarch.h.
1400
1401 2019-11-24  Tom Tromey  <tom@tromey.com>
1402
1403         * symfile.c (read_symbols): Update.
1404         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1405         bool.
1406         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1407         (psym_lookup_symbol, psym_find_last_source_symtab)
1408         (psym_forget_cached_source_info, psym_print_stats)
1409         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1410         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1411         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1412         (psym_find_compunit_symtab_by_address)
1413         (maintenance_print_psymbols, maintenance_info_psymtabs)
1414         (maintenance_check_psymtabs): Update.
1415         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1416         bool.
1417
1418 2019-11-22  Tom Tromey  <tom@tromey.com>
1419
1420         * observable.h: Update comments.
1421
1422 2019-11-22  Tom Tromey  <tromey@adacore.com>
1423
1424         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1425         (print_ada_task_info): Don't try to fetch thread id if task is not
1426         alive.
1427
1428 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1429
1430         * ada-exp.y: Update.
1431         * ada-lang.c (sort_choices): Update.
1432         (ada_print_symbol_signature): Update.
1433         (resolve_subexp): Update.
1434         (ada_parse_renaming): Update.
1435         (ada_read_renaming_var_value): Update.
1436         (lesseq_defined_than): Update.
1437         (remove_extra_symbols): Update.
1438         (remove_irrelevant_renamings): Update.
1439         (ada_add_block_symbols): Update.
1440         (ada_collect_symbol_completion_matches): Update.
1441         (ada_is_renaming_symbol): Update.
1442         (aggregate_assign_from_choices): Update.
1443         (ada_evaluate_subexp): Update.
1444         (ada_has_this_exception_support): Update.
1445         (ada_is_non_standard_exception_sym): Update.
1446         (ada_add_exceptions_from_frame): Update.
1447         (ada_add_global_exceptions): Update.
1448         (ada_print_subexp): Update.
1449         * ax-gdb.c (gen_var_ref): Update.
1450         (gen_maybe_namespace_elt): Update.
1451         (gen_expr_for_cast): Update.
1452         (gen_expr): Update.
1453         * block.h: Update.
1454         * blockframe.c (find_pc_partial_function): Update.
1455         * breakpoint.c (print_breakpoint_location): Update.
1456         (update_static_tracepoint): Update.
1457         * btrace.c (ftrace_print_function_name): Update.
1458         (ftrace_function_switched): Update.
1459         * buildsym.c (find_symbol_in_list): Update.
1460         * c-exp.y: Update.
1461         * c-typeprint.c (c_print_typedef): Update.
1462         (c_type_print_template_args): Update.
1463         * cli/cli-cmds.c (edit_command): Update.
1464         (list_command): Update.
1465         (print_sal_location): Update.
1466         * coffread.c (patch_opaque_types): Update.
1467         (process_coff_symbol): Update.
1468         (coff_read_enum_type): Update.
1469         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1470         (convert_one_symbol): Update.
1471         (hash_symname): Update.
1472         (eq_symname): Update.
1473         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1474         * compile/compile-cplus-types.c (debug_print_scope): Update.
1475         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1476         * compile/compile-object-load.c (get_out_value_type): Update.
1477         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1478         (search_symbol_list): Update.
1479         (cp_lookup_symbol_imports_or_template): Update.
1480         * cp-support.c (overload_list_add_symbol): Update.
1481         * ctfread.c (psymtab_to_symtab): Update.
1482         * dbxread.c (cp_set_block_scope): Update.
1483         * dictionary.c (iter_match_first_hashed): Update.
1484         (iter_match_next_hashed): Update.
1485         (insert_symbol_hashed): Update.
1486         (iter_match_next_linear): Update.
1487         * dictionary.h: Update.
1488         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1489         (locexpr_describe_location_piece): Update.
1490         (locexpr_describe_location_1): Update.
1491         (locexpr_generate_c_location): Update.
1492         (loclist_describe_location): Update.
1493         (loclist_generate_c_location): Update.
1494         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1495         (read_func_scope): Update.
1496         (process_enumeration_scope): Update.
1497         (new_symbol): Update.
1498         (dwarf2_const_value): Update.
1499         (dwarf2_symbol_mark_computed): Update.
1500         * eval.c (evaluate_funcall): Update.
1501         (evaluate_subexp_standard): Update.
1502         * expprint.c (print_subexp_standard): Update.
1503         (dump_subexp_body_standard): Update.
1504         * f-valprint.c (info_common_command_for_block): Update.
1505         * findvar.c (get_hosting_frame): Update.
1506         (default_read_var_value): Update.
1507         * go-lang.c (go_symbol_package_name): Update.
1508         * guile/scm-block.c (bkscm_print_block_smob): Update.
1509         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1510         (gdbscm_symbol_name): Update.
1511         (gdbscm_symbol_linkage_name): Update.
1512         (gdbscm_symbol_print_name): Update.
1513         * infcall.c (get_function_name): Update.
1514         * infcmd.c (jump_command): Update.
1515         (finish_command): Update.
1516         * infrun.c (insert_exception_resume_breakpoint): Update.
1517         * linespec.c (canonicalize_linespec): Update.
1518         (create_sals_line_offset): Update.
1519         (convert_linespec_to_sals): Update.
1520         (complete_label): Update.
1521         (find_label_symbols_in_block): Update.
1522         * m2-typeprint.c (m2_print_typedef): Update.
1523         * mdebugread.c (mdebug_reg_to_regnum): Update.
1524         (parse_symbol): Update.
1525         (mylookup_symbol): Update.
1526         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1527         (list_args_or_locals): Update.
1528         * objc-lang.c (compare_selectors): Update.
1529         (info_selectors_command): Update.
1530         (compare_classes): Update.
1531         (info_classes_command): Update.
1532         (find_imps): Update.
1533         * p-typeprint.c (pascal_print_typedef): Update.
1534         * printcmd.c (build_address_symbolic): Update.
1535         (info_address_command): Update.
1536         (print_variable_and_value): Update.
1537         * python/py-framefilter.c (extract_sym): Update.
1538         (py_print_single_arg): Update.
1539         * python/py-symbol.c (sympy_str): Update.
1540         (sympy_get_name): Update.
1541         (sympy_get_linkage_name): Update.
1542         * python/python.c (gdbpy_rbreak): Update.
1543         * record-btrace.c (btrace_get_bfun_name): Update.
1544         (btrace_call_history): Update.
1545         * rust-lang.c (rust_print_typedef): Update.
1546         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1547         * stabsread.c (stab_reg_to_regnum): Update.
1548         (define_symbol): Update.
1549         (read_enum_type): Update.
1550         (common_block_end): Update.
1551         (cleanup_undefined_types_1): Update.
1552         (scan_file_globals): Update.
1553         * stack.c (print_frame_arg): Update.
1554         (print_frame_args): Update.
1555         (find_frame_funname): Update.
1556         (info_frame_command_core): Update.
1557         (iterate_over_block_locals): Update.
1558         (print_block_frame_labels): Update.
1559         (do_print_variable_and_value): Update.
1560         (iterate_over_block_arg_vars): Update.
1561         (return_command): Update.
1562         * symmisc.c (dump_symtab_1): Update.
1563         (print_symbol): Update.
1564         * symtab.c (eq_symbol_entry): Update.
1565         (symbol_cache_dump): Update.
1566         (lookup_language_this): Update.
1567         (find_pc_sect_line): Update.
1568         (skip_prologue_sal): Update.
1569         (symbol_search::compare_search_syms): Update.
1570         (treg_matches_sym_type_name): Update.
1571         (search_symbols): Update.
1572         (print_symbol_info): Update.
1573         (rbreak_command): Update.
1574         (completion_list_add_symbol): Update.
1575         (find_gnu_ifunc): Update.
1576         (get_symbol_address): Update.
1577         (search_module_symbols): Update.
1578         (info_module_subcommand): Update.
1579         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1580         (SYMBOL_LINKAGE_NAME): Remove.
1581         (SYMBOL_DEMANGLED_NAME): Remove.
1582         (SYMBOL_PRINT_NAME): Remove.
1583         (SYMBOL_SEARCH_NAME): Remove.
1584         * tracepoint.c (set_traceframe_context): Update.
1585         (validate_actionline): Update.
1586         (collection_list::collect_symbol): Update.
1587         (encode_actions_1): Update.
1588         (info_scope_command): Update.
1589         (print_one_static_tracepoint_marker): Update.
1590         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1591         * valops.c (address_of_variable): Update.
1592         (find_overload_match): Update.
1593         (find_oload_champ): Update.
1594
1595 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1596
1597         * ada-lang.c (ada_lookup_simple_minsym): Update.
1598         (ada_collect_symbol_completion_matches): Update.
1599         * ada-tasks.c (read_atcb): Update.
1600         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1601         (amd64_windows_skip_trampoline_code): Update.
1602         * arm-tdep.c (skip_prologue_function): Update.
1603         (arm_skip_stack_protector): Update.
1604         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1605         (arm_wince_skip_main_prologue): Update.
1606         * ax-gdb.c (gen_expr): Update.
1607         * block.c (call_site_for_pc): Update.
1608         * blockframe.c (find_pc_partial_function): Update.
1609         * breakpoint.c (set_breakpoint_location_function): Update.
1610         * btrace.c (ftrace_print_function_name): Update.
1611         (ftrace_function_switched): Update.
1612         * c-valprint.c (print_unpacked_pointer): Update.
1613         * coffread.c (coff_symfile_read): Update.
1614         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1615         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1616         * dwarf-index-write.c (write_psymbols): Update.
1617         * dwarf2loc.c (call_site_to_target_addr): Update.
1618         (func_verify_no_selftailcall): Update.
1619         (tailcall_dump): Update.
1620         (call_site_find_chain_1): Update.
1621         (dwarf_expr_reg_to_entry_parameter): Update.
1622         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1623         * eval.c (evaluate_funcall): Update.
1624         (evaluate_subexp_standard): Update.
1625         (evaluate_subexp_for_sizeof): Update.
1626         * expprint.c (print_subexp_standard): Update.
1627         (dump_subexp_body_standard): Update.
1628         * frame.c (get_prev_frame_always_1): Update.
1629         * frv-tdep.c (frv_skip_main_prologue): Update.
1630         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1631         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1632         (gnuv3_get_typename_from_type_info): Update.
1633         (gnuv3_skip_trampoline): Update.
1634         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1635         * i386-tdep.c (i386_skip_main_prologue): Update.
1636         (i386_pe_skip_trampoline_code): Update.
1637         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1638         * infcall.c (get_function_name): Update.
1639         * linespec.c (minsym_found): Update.
1640         * linux-fork.c (info_checkpoints_command): Update.
1641         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1642         (m32c_m16c_pointer_to_address): Update.
1643         * maint.c (maintenance_translate_address): Update.
1644         * minsyms.c (add_minsym_to_hash_table): Update.
1645         (add_minsym_to_demangled_hash_table): Update.
1646         (lookup_minimal_symbol_mangled): Update.
1647         (lookup_minimal_symbol_demangled): Update.
1648         (lookup_minimal_symbol_linkage): Update.
1649         (lookup_minimal_symbol_text): Update.
1650         (lookup_minimal_symbol_by_pc_name): Update.
1651         (minimal_symbol_is_less_than): Update.
1652         (compact_minimal_symbols): Update.
1653         (build_minimal_symbol_hash_tables): Update.
1654         (find_solib_trampoline_target): Update.
1655         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1656         (mips_skip_pic_trampoline_code): Update.
1657         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1658         * objc-lang.c (info_selectors_command): Update.
1659         (info_classes_command): Update.
1660         (find_methods): Update.
1661         (find_imps): Update.
1662         * p-valprint.c (pascal_val_print): Update.
1663         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1664         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1665         * printcmd.c (build_address_symbolic): Update.
1666         (info_symbol_command): Update.
1667         * psymtab.c (psymbol_name_matches): Update.
1668         (match_partial_symbol): Update.
1669         (lookup_partial_symbol): Update.
1670         (print_partial_symbols): Update.
1671         (sort_pst_symbols): Update.
1672         (maintenance_check_psymtabs): Update.
1673         * python/py-framefilter.c (py_print_frame): Update.
1674         * python/python.c (gdbpy_rbreak): Update.
1675         * record-btrace.c (btrace_get_bfun_name): Update.
1676         (btrace_call_history): Update.
1677         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1678         (rs6000_skip_trampoline_code): Update.
1679         * sol-thread.c (info_cb): Update.
1680         * stabsread.c (scan_file_globals): Update.
1681         * stack.c (find_frame_funname): Update.
1682         (info_frame_command_core): Update.
1683         * symmisc.c (dump_msymbols): Update.
1684         * symtab.c (symbol_natural_name): Rename to..,
1685         (general_symbol_info::natural_name): ...this.
1686         (symbol_demangled_name): Rename to...
1687         (general_symbol_info::demangled_name): ...this.
1688         (symbol_search_name): Rename to...
1689         (general_symbol_info::search_name): ...this.
1690         (symbol_matches_search_name): Update.
1691         (find_pc_sect_line): Update.
1692         (skip_prologue_sal): Update.
1693         (search_symbols): Update.
1694         (print_msymbol_info): Update.
1695         (rbreak_command): Update.
1696         (completion_list_add_msymbol): Update.
1697         (completion_list_objc_symbol): Update.
1698         (get_msymbol_address): Update.
1699         * symtab.h (struct general_symbol_info): Add member functions
1700         natural_name (), linkage_name (), print_name (), demangled_name (),
1701         and search_name ().
1702         (SYMBOL_NATURAL_NAME): Update.
1703         (symbol_natural_name): Move to a member function on general_symbol_info.
1704         (SYMBOL_DEMANGLED_NAME): Update.
1705         (symbol_demangled_name): Move to a member function on
1706         general_symbol_info.
1707         (SYMBOL_SEARCH_NAME): Update.
1708         (symbol_search_name): Move to a member function on general_symbol_info.
1709         (MSYMBOL_NATURAL_NAME): Remove.
1710         (MSYMBOL_LINKAGE_NAME): Remove.
1711         (MSYMBOL_PRINT_NAME): Remove.
1712         (MSYMBOL_DEMANGLED_NAME): Remove.
1713         (MSYMBOL_SEARCH_NAME): Remove.
1714         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1715
1716 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1717
1718         * symtab.c (create_demangled_names_hash): Use per_bfd->
1719         minimal_symbol_count for computing the initial size, if greater
1720         than our default size.
1721
1722 2019-11-22  Tom de Vries  <tdevries@suse.de>
1723
1724         * contrib/words.sh: Improve words extraction.
1725
1726 2019-11-22  Tom de Vries  <tdevries@suse.de>
1727
1728         * contrib/words.sh: Combine sed invocations.
1729
1730 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1731
1732         * Makefile.in: Update.
1733         * demangle.c: Rename to...
1734         * gdb-demangle.c: ..this.
1735         (is_cplus_marker): Change return type to bool.
1736         (_initialize_demangler): Rename to...
1737         (_initialize_gdb_demangle): ...this.
1738         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1739         * symtab.h (demangle): Remove declaration; instead include
1740         gdb-demangle.h.
1741
1742 2019-11-21  Tom Tromey  <tromey@adacore.com>
1743
1744         * gdbsupport/format.c (format_pieces): Parse %I64d.
1745         * unittests/format_pieces-selftests.c (test_windows_formats): New
1746         function.
1747         (run_tests): Call it.
1748
1749 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1750
1751         Byte reverse display of variables with DW_END_big, DW_END_little
1752         (DW_AT_endianity) dwarf attributes if different than the native
1753         byte order.
1754         * ada-lang.c (ada_value_binop):
1755         Use type_byte_order instead of gdbarch_byte_order.
1756         * ada-valprint.c (printstr):
1757         (ada_val_print_string):
1758         * ada-lang.c (value_pointer):
1759         (ada_value_binop):
1760         Use type_byte_order instead of gdbarch_byte_order.
1761         * c-lang.c (c_get_string):
1762         Use type_byte_order instead of gdbarch_byte_order.
1763         * c-valprint.c (c_val_print_array):
1764         Use type_byte_order instead of gdbarch_byte_order.
1765         * cp-valprint.c (cp_print_class_member):
1766         Use type_byte_order instead of gdbarch_byte_order.
1767         * dwarf2loc.c (rw_pieced_value):
1768         Use type_byte_order instead of gdbarch_byte_order.
1769         * dwarf2read.c (read_base_type): Handle DW_END_big,
1770         DW_END_little
1771         * f-lang.c (f_get_encoding):
1772         Use type_byte_order instead of gdbarch_byte_order.
1773         * findvar.c (default_read_var_value):
1774         Use type_byte_order instead of gdbarch_byte_order.
1775         * gdbtypes.c (check_types_equal):
1776         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1777         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1778         and TYPE_ENDIANITY_LITTLE if set.
1779         (type_byte_order): new function.
1780         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1781         (struct main_type) <flag_endianity_not_default>:
1782         New field.
1783         (type_byte_order): New function.
1784         * infcmd.c (default_print_one_register_info):
1785         Use type_byte_order instead of gdbarch_byte_order.
1786         * p-lang.c (pascal_printstr):
1787         Use type_byte_order instead of gdbarch_byte_order.
1788         * p-valprint.c (pascal_val_print):
1789         Use type_byte_order instead of gdbarch_byte_order.
1790         * printcmd.c (print_scalar_formatted):
1791         Use type_byte_order instead of gdbarch_byte_order.
1792         * solib-darwin.c (darwin_current_sos):
1793         Use type_byte_order instead of gdbarch_byte_order.
1794         * solib-svr4.c (solib_svr4_r_ldsomap):
1795         Use type_byte_order instead of gdbarch_byte_order.
1796         * stap-probe.c (stap_modify_semaphore):
1797         Use type_byte_order instead of gdbarch_byte_order.
1798         * target-float.c (target_float_same_format_p):
1799         Use type_byte_order instead of gdbarch_byte_order.
1800         * valarith.c (scalar_binop):
1801         (value_bit_index):
1802         Use type_byte_order instead of gdbarch_byte_order.
1803         * valops.c (value_cast):
1804         Use type_byte_order instead of gdbarch_byte_order.
1805         * valprint.c (generic_emit_char):
1806         (generic_printstr):
1807         (val_print_string):
1808         Use type_byte_order instead of gdbarch_byte_order.
1809         * value.c (unpack_long):
1810         (unpack_bits_as_long):
1811         (unpack_value_bitfield):
1812         (modify_field):
1813         (pack_long):
1814         (pack_unsigned_long):
1815         Use type_byte_order instead of gdbarch_byte_order.
1816         * findvar.c (unsigned_pointer_to_address):
1817         (signed_pointer_to_address):
1818         (unsigned_address_to_pointer):
1819         (address_to_signed_pointer):
1820         (default_read_var_value):
1821         (default_value_from_register):
1822         Use type_byte_order instead of gdbarch_byte_order.
1823         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1824         Use type_byte_order instead of gdbarch_byte_order.
1825         * riscv-tdep.c (riscv_print_one_register_info):
1826         Use type_byte_order instead of gdbarch_byte_order.
1827
1828 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1829
1830         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1831         (current_ui_gdb_stdin_ptr): Likewise.
1832         (current_ui_gdb_stderr_ptr): Likewise.
1833         (current_ui_gdb_stdlog_ptr): Likewise.
1834         (current_ui_current_uiout_ptr): Likewise.
1835         (gen_ret_current_ui_field_ptr): Remove.
1836
1837 2019-11-21  Tom de Vries  <tdevries@suse.de>
1838
1839         PR gdb/24956
1840         * cli/cli-script.c (execute_control_command): Only switch to
1841         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1842
1843 2019-11-19  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1846         Now static.  Change type of "name".
1847         (tui_set_win_height_command): Don't copy "arg".
1848         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1849         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1850
1851 2019-11-19  Ali Tamur <tamur@google.com>
1852
1853         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1854         "if (attr != nullptr)".
1855         (dwarf2_find_base_address): Likewise.
1856         (dwarf2_build_include_psymtabs): Likewise.
1857         (read_cutu_die_from_dwo): Likewise.
1858         (read_func_scope): Likewise.
1859         (read_call_site_scope): Likewise.
1860         (dwarf2_get_pc_bounds): Likewise.
1861         (dwarf2_record_block_ranges): Likewise.
1862         (dwarf2_add_field): Likewise.
1863         (dwarf2_add_member_fn): Likewise.
1864         (read_structure_type): Likewise.
1865         (read_enumeration_type): Likewise.
1866         (read_array_type): Likewise.
1867         (read_array_order): Likewise.
1868         (read_set_type): Likewise.
1869         (read_common_block): Likewise.
1870         (read_tag_reference_type): Likewise.
1871         (read_tag_string_type): Likewise.
1872         (read_subroutine_type): Likewise.
1873         (read_base_type): Likewise.
1874         (read_subrange_type): Likewise.
1875         (new_symbol): Likewise.
1876         (prepare_one_comp_unit): Likewise.
1877
1878 2019-11-19  Tom Tromey  <tromey@adacore.com>
1879
1880         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1881         result in error when DebugActiveProcess fails.
1882
1883 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1884             Pedro Alves  <palves@redhat.com>
1885
1886         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1887         * target.c (target_stack::push): Call 'unpush' if there's a
1888         target on top of the stack.
1889
1890 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1891
1892         * python/py-block.c (blpy_dealloc): Call tp_free.
1893         (blpy_block_syms_dealloc): Likewise.
1894         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1895         * python/py-inferior.c (infpy_dealloc): Likewise.
1896         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1897         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1898         * python/py-symbol.c (sympy_dealloc): Likewise.
1899         * python/py-symtab.c (stpy_dealloc): Likewise.
1900         * python/py-type.c (typy_iterator_dealloc): Likewise.
1901
1902 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1903
1904         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1905         constructor instead of using a class initializer.
1906
1907 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1908
1909         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1910         * configure: Regenerate.
1911         * configure.ac: Don't source common.host.
1912         * gdbsupport/common.host: Remove.
1913         * gdbsupport/mingw-strerror.c: Remove.
1914         * gdbsupport/posix-strerror.c: Rename to...
1915         * gdbsupport/safe-strerror.c: ...this.
1916
1917 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1918
1919         * maint.c (scoped_command_stats::print_time): Use localtime_r
1920         instead of localtime (provided through gnulib if necessary).
1921         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1922         of ctime.
1923
1924 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1925
1926         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1927         avoid compile errors.
1928
1929 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1930
1931         * config.in: Regenerate.
1932         * configure: Regenerate.
1933         * gdbsupport/common.m4: No longer check for strerror_r.
1934         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1935         POSIX version of strerror_r, now that gnulib provides it if
1936         necessary.
1937
1938 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1939
1940         * README (`configure' options): Update.
1941
1942 2019-11-14  Tom Tromey  <tromey@adacore.com>
1943
1944         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1945         expected type for the RHS if the LHS is a convenience variable.
1946
1947 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1948
1949         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1950         Provide explicit default and copy constructor.
1951
1952 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1953
1954         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1955         only call Py_INCREF (newbp) in the bppy_pending_object case.
1956
1957 2019-11-13  Tom Tromey  <tromey@adacore.com>
1958
1959         PR build/25182:
1960         * psympriv.h (partial_symbol): Remove static assert.
1961         * symtab.h (general_symbol_info, symbol): Remove static assert.
1962
1963 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1964
1965         * gdbsupport/format.c (format_pieces::format_pieces): Support
1966         printf 'z' size modifier.
1967         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1968         * printcmd.c (ui_printf):  Handle size_t_arg.
1969         * ui-out.c (ui_out::vmessage): Likewise.
1970         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1971         function.
1972         (run_tests): Call test_format_int_sizes.
1973
1974 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1975
1976         * ada-exp.y (write_ambiguous_var): Update.
1977         * buildsym.c (add_symbol_to_list): Update.
1978         * dwarf2read.c (read_variable): Update.
1979         (new_symbol): Update.
1980         * jit.c (finalize_symtab): Update.
1981         * language.c (language_alloc_type_symbol): Update.
1982         * symtab.c (fixup_symbol_section): Update.
1983         (initialize_objfile_symbol_1): Move code to...
1984         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1985         (allocate_symbol): Update.
1986         (allocate_template_symbol): Update.
1987         (get_symbol_address): Update.
1988         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1989         of having as a field, and add a constructor.
1990         (SYMBOL_VALUE): Update.
1991         (SYMBOL_VALUE_ADDRESS): Update.
1992         (SET_SYMBOL_VALUE_ADDRESS): Update.
1993         (SYMBOL_VALUE_BYTES): Update.
1994         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1995         (SYMBOL_BLOCK_VALUE): Update.
1996         (SYMBOL_VALUE_CHAIN): Update.
1997         (SYMBOL_LANGUAGE): Update.
1998         (SYMBOL_SECTION): Update.
1999         (SYMBOL_OBJ_SECTION): Update.
2000         (SYMBOL_SET_LANGUAGE): Update.
2001         (SYMBOL_SET_LINKAGE_NAME): Update.
2002         (SYMBOL_SET_NAMES): Update.
2003         (SYMBOL_NATURAL_NAME): Update.
2004         (SYMBOL_LINKAGE_NAME): Update.
2005         (SYMBOL_DEMANGLED_NAME): Update.
2006         (SYMBOL_SEARCH_NAME): Update.
2007         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2008         (struct symbol): Update.
2009         (struct template_symbol): Update.
2010         (struct rust_vtable_symbol): Update.
2011         * xcoffread.c (SYMBOL_DUP): Update.
2012
2013 2019-11-12  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-layout.c (show_layout): Set current_layout.
2016         (show_source_disasm_command, show_data)
2017         (show_source_or_disasm_and_command): Don't set current_layout.
2018
2019 2019-11-12  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2022
2023 2019-11-12  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-win.c (resize_message): New global.
2026         (show_tui_resize_message): New function.
2027         (tui_async_resize_screen): Print message if requested.
2028         (_initialize_tui_win): Add tui-resize-message setting.
2029         * NEWS: Add entry for new commands.
2030
2031 2019-11-11  Tom Tromey  <tom@tromey.com>
2032
2033         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2034         functions.
2035
2036 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2037
2038         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2039
2040 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2041
2042         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2043         function.
2044         * python/python-internal.h (gdbpy_lookup_static_symbols):
2045         Declare new function.
2046         * python/python.c (python_GdbMethods): Add
2047         gdb.lookup_static_symbols method.
2048         * NEWS: Mention gdb.lookup_static_symbols.
2049
2050 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2051
2052         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2053         static block of current object file first.  Also fix typo in
2054         header comment.
2055
2056 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2057
2058         * stack.c (set_last_displayed_sal): Delete.
2059         (last_displayed_sal_valid): Delete.
2060         (last_displayed_pspace): Delete.
2061         (last_displayed_addr): Delete.
2062         (last_displayed_symtab): Delete.
2063         (last_displayed_line): Delete.
2064         (class last_displayed_symtab_info_type): New.
2065         (last_displayed_symtab_info): New static global variable.
2066         (print_frame_info): Call methods on last_displayed_symtab_info.
2067         (clear_last_displayed_sal): Update header comment, and make use of
2068         last_displayed_symtab_info.
2069         (last_displayed_sal_is_valid): Likewise.
2070         (get_last_displayed_pspace): Likewise.
2071         (get_last_displayed_addr): Likewise.
2072         (get_last_displayed_symtab): Likewise.
2073         (get_last_displayed_line): Likewise.
2074         (get_last_displayed_sal): Likewise.
2075         * stack.h (clear_last_displayed_sal): Update header comment.
2076         (last_displayed_sal_is_valid): Likewise.
2077         (get_last_displayed_pspace): Likewise.
2078         (get_last_displayed_addr): Likewise.
2079         (get_last_displayed_symtab): Likewise.
2080         (get_last_displayed_line): Likewise.
2081         (get_last_displayed_sal): Likewise.
2082
2083 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2084
2085         * stack.c (frame_show_address): Convert return type to bool.
2086         * stack.h (frame_show_address): Likewise, and update header
2087         comment.
2088
2089 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2090
2091         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2092         * unittests/vec-utils-selftests.c: New file.
2093         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2094
2095 2019-11-10  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2098         (tui_highlight_win): Likewise.
2099         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2100         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2101         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2102         Don't set can_highlight.
2103
2104 2019-11-10  Tom Tromey  <tom@tromey.com>
2105
2106         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2107         Remove unused declaration.
2108
2109 2019-11-08  Tom Tromey  <tromey@adacore.com>
2110
2111         * top.c (read_command_file): Update.
2112         (command_line_input): Make return type const.
2113         * python/py-gdb-readline.c: Update.
2114         * linespec.c (decode_line_2): Update.
2115         * defs.h (command_line_input): Make return type const.
2116         * cli/cli-script.c (read_next_line): Make return type const.
2117         * ada-lang.c (get_selections): Update.
2118
2119 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2120
2121         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2122         * mi/mi-main.c (output_cores): Likewise.
2123         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2124         (linux_xfer_osdata_modules): Likewise.
2125         * remote.c (register_remote_support_xml): Likewise.
2126         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2127         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2128
2129 2019-11-06  Tom Tromey  <tom@tromey.com>
2130
2131         * tui/tui-interp.c: Don't include readline.h.
2132         * tui/tui-hooks.c: Don't include readline.h.
2133         * symmisc.c: Include tilde.h, not readline.h.
2134         * symfile.c: Include tilde.h, not readline.h.
2135         * source.c: Include tilde.h, not readline.h.
2136         * solib.c: Include tilde.h, not readline.h.
2137         * psymtab.c: Include tilde.h, not readline.h.
2138         * exec.c: Include tilde.h, not readline.h.
2139         * corelow.c: Include tilde.h, not readline.h.
2140         * cli/cli-dump.c: Include tilde.h, not readline.h.
2141         * cli/cli-cmds.c: Don't include readline.h.
2142
2143 2019-11-05  Tom Tromey  <tom@tromey.com>
2144
2145         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2146         (tui_disassemble): Set addr_size.
2147         (tui_disasm_window::set_contents): Use addr_size.
2148
2149 2019-11-05  Tom Tromey  <tom@tromey.com>
2150
2151         * rust-lang.c (rust_language_defn): Update.
2152         * python/py-value.c (valpy_string): Call c_get_string.
2153         * p-lang.c (pascal_language_defn): Update.
2154         * opencl-lang.c (opencl_language_defn): Update.
2155         * objc-lang.c (objc_language_defn): Update.
2156         * m2-lang.c (m2_language_defn): Update.
2157         * language.c (unknown_language_defn, auto_language_defn): Update.
2158         (default_get_string): Remove.
2159         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2160         * go-lang.c (go_language_defn): Update.
2161         * f-lang.c (f_language_defn): Update.
2162         * d-lang.c (d_language_defn): Update.
2163         * c-lang.c (c_language_defn, cplus_language_defn)
2164         (asm_language_defn, minimal_language_defn): Update.
2165         * ada-lang.c (ada_language_defn): Update.
2166         * language.h (struct language_defn) <la_get_string>: Remove.
2167         (LA_GET_STRING): Remove.
2168         (default_get_string): Don't declare.
2169
2170 2019-11-05  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-source.h (struct tui_source_window): Inline
2173         constructor.  Remove destructor.
2174         <style_changed, m_observable>: Move to superclass.
2175         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2176         (struct tui_source_window_base): Move private members to end.
2177         <style_changed, m_observable>: Move from tui_source_window.
2178         * tui/tui-winsource.c (tui_copy_source_line): Move from
2179         tui-source.c.  Rename from copy_source_line.  Add special handling
2180         for negative line number.
2181         (tui_source_window_base::style_changed): Move from
2182         tui_source_window.
2183         (tui_source_window_base): Register observer.
2184         (~tui_source_window_base): New.
2185         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2186         rename.
2187         (tui_source_window::set_contents): Use tui_copy_source_line.
2188         (tui_source_window::tui_source_window): Move to tui-source.h.
2189         (tui_source_window::~tui_source_window): Remove.
2190         (tui_source_window::style_changed): Move to superclass.
2191         * tui/tui-disasm.c (tui_disassemble): Create string file with
2192         styling, when possible.  Add "addr_size" parameter.
2193         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2194         Don't compute maximum size.
2195         (len_without_escapes): New function
2196
2197 2019-11-05  Tom Tromey  <tom@tromey.com>
2198
2199         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2200         std::string.
2201         * tui/tui-winsource.c (tui_show_source_line): Update.
2202         * tui/tui-source.c (tui_source_window::set_contents): Update.
2203         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2204
2205 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2206
2207         * symtab.h (gdb_static_assert): Put && operator at the beginning
2208         of the line instead of the end.
2209
2210 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2211
2212         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2213         and sizeof (symbol).
2214         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2215
2216 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2217
2218         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2219         * configure.host: Mark *-*-solaris2.10* obsolete.
2220         * configure.tgt: Mark Solaris < 11 obsolete.
2221         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2222         Update target triplet.
2223
2224 2019-11-01  Tom Tromey  <tromey@adacore.com>
2225
2226         * utils.c (print_sys_errmsg): Simplify.
2227
2228 2019-11-01  Tom Tromey  <tromey@adacore.com>
2229
2230         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2231
2232 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2233
2234         * configure: Regenerate.
2235         * configure.ac: Remove check for strerror_r.
2236         * gdbsupport/common.m4: Check for strerror_r.
2237
2238 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2239
2240         PR gdb/25124
2241
2242         * arm-tdep.c (arm_per_objfile): Rename to ...
2243         (arm_per_bfd): ... this.
2244         (arm_objfile_data_key): Rename to ...
2245         (arm_bfd_data_key): ... this.
2246         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2247         data.
2248         (arm_record_special_symbol): Likewise.
2249
2250 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2251
2252         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2253         end.
2254         * c-typeprint.c (c_print_typedef): Likewise.
2255         * f-typeprint.c (f_print_typedef): Likewise.
2256         * m2-typeprint.c (m2_print_typedef): Likewise.
2257         * p-typeprint.c (pascal_print_typedef): Likewise.
2258         * rust-lang.c (rust_print_typedef): Likewise.
2259         * symtab.c (print_symbol_info): Print a newline after calling
2260         typedef_print.
2261
2262 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2263
2264         * symtab.c (info_module_cmdlist): New variable.
2265         (info_module_command): New function.
2266         (search_module_symbols): New function.
2267         (info_module_subcommand): New function.
2268         (struct info_modules_var_func_options): New struct.
2269         (info_modules_var_func_options_defs): New variable.
2270         (make_info_modules_var_func_options_def_group): New function.
2271         (info_module_functions_command): New function.
2272         (info_module_variables_command): New function.
2273         (info_module_var_func_command_completer): New function.
2274         (_initialize_symtab): Register new 'info module functions' and
2275         'info module variables' commands.
2276         * symtab.h (typedef symbol_search_in_module): New typedef.
2277         (search_module_symbols): Declare new function.
2278         * NEWS: Mention new commands.
2279
2280 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2281
2282         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2283         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2284         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2285         MODULES_DOMAIN.
2286         (scan_partial_symbols): Only create partial module symbols for non
2287         declarations.
2288         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2289         and MODULES_DOMAIN.
2290         * symtab.c (search_domain_name): Likewise.
2291         (search_symbols): Likewise.
2292         (print_symbol_info): Likewise.
2293         (symtab_symbol_info): Likewise.
2294         (info_modules_command): New function.
2295         (_initialize_symtab): Register 'info modules' command.
2296         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2297         * NEWS: Mention new 'info modules' command.
2298
2299 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2300
2301         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2302         and $_gdb_maint_setting_str.
2303
2304 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2305
2306         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2307         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2308         (str_value_from_setting, gdb_setting_str_internal_fn)
2309         (gdb_maint_setting_str_internal_fn): New functions.
2310         (_initialize_cli_cmds): Define the new convenience functions.
2311         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2312         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2313
2314 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2315
2316         * agent.c (set_can_use_agent): When the setting is turned on,
2317         look up agent symbols if we don't have them yet.
2318         (agent_new_objfile): Don't look up agent symbols when the agent
2319         setting is off.
2320
2321 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2322
2323         * config.in: Regenerate.
2324
2325 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2326
2327         * configure: Regenerate.
2328         * configure.ac: Check for strerror_r.
2329         * gdbsupport/common-utils.h (safe_strerror): Change return value
2330         to const char * and document that this function is now threadsafe.
2331         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2332         thread_local and call strerror_r, if available.
2333         * utils.c (perror_string): Update.
2334         (print_sys_errmsg): Update.
2335
2336 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2337
2338         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2339         objfile_key.
2340         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2341         objfile to fetch per-bfd data.
2342         (arm_find_exidx_entry): Likewise.
2343
2344 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2345
2346         * gdbsupport/agent.c (debug_agent): Change type to bool.
2347         (use_agent): Likewise.
2348         (all_agent_symbols_look_up): Likewise.
2349         (agent_loaded_p): Change return value to bool.
2350         (agent_look_up_symbols): Update.
2351         (agent_capability_check): Change return value to bool.
2352         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2353         (debug_agent): Change type to bool.
2354         (use_agent): Likewise.
2355         (agent_capability_check): Change return value to bool.
2356
2357 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2358
2359         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2360         (build_minimal_symbol_hash_tables): Code to clear the table moved
2361         to clear_minimal_symbol_hash_tables.
2362         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2363         when needed.
2364
2365 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2366
2367         * infcmd.c: Remove includes.
2368         * infrun.c: Remove includes.
2369
2370 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2371
2372         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2373         (grow_vect): Remove declaration.
2374         (ada_type_of_array): Remove declaration.
2375         (ada_update_initial_language): Remove declaration.
2376         (ada_fold_name): Remove declaration.
2377         (ada_fill_in_ada_prototype): Remove declaration.
2378         (user_select_syms): Remove declaration.
2379         (get_selections): Remove declaration.
2380         (ada_tag_type): Remove declaration.
2381         (ada_value_tag): Remove declaration.
2382         (ada_is_others_clause): Remove declaration.
2383         (ada_in_variant): Remove declaration.
2384         (ada_value_struct_elt): Remove declaration.
2385         (ada_attribute_name): Remove declaration.
2386         (ada_system_address_type): Remove declaration.
2387         * ada-lang.c (ada_watch_location_expression): Make static.
2388         (GROW_VECT): Move here from ada-lang.h.
2389         (grow_vect): Make static.
2390         (ada_update_initial_language): Make static.
2391         (ada_fold_name): Make static.
2392         (ada_type_of_array): Make static.
2393         (encoded_ordered_before): Move up.
2394         (sort_choices): Move up.
2395         (print_signatures): Move up.
2396         (ada_print_symbol_signature): Move up.
2397         (get_selections): Move up and make static.
2398         (user_select_syms): Move up and make static.
2399         (ada_value_struct_elt): Move up and make static.
2400         (ada_tag_type): Make static.
2401         (ada_value_tag): Make static.
2402         (ada_is_others_clause): Make static.
2403         (ada_in_variant): Make static.
2404         (ada_attribute_name): Make static.
2405
2406 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2407
2408         * ada-lang.c: Remove includes.
2409         * ada-typeprint.c: Remove includes.
2410         * ada-valprint.c: Remove includes.
2411
2412 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2413
2414         * addrmap.c: Add static assertions of type size, moved from
2415         _initialize_addrmap.
2416         (_initialize_addrmap): Remove.
2417
2418 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2419
2420         * coffread.c (record_minimal_symbol): Update.
2421         (process_coff_symbol): Update.
2422         * dbxread.c (read_dbx_symtab): Update.
2423         * dwarf2read.c (add_partial_symbol): Update.
2424         (fixup_go_packaging): Update.
2425         (load_partial_dies): Update.
2426         (new_symbol): Update.
2427         * elfread.c (record_minimal_symbol): Change signature to use
2428         gdb::string_view instead of name+len.
2429         (elf_symtab_read): Update.
2430         (elf_rel_plt_read): Update.
2431         * mdebugread.c (parse_partial_symbols): Update.
2432         (handle_psymbol_enumerators): Update.
2433         (new_symbol): Update.
2434         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2435         to use gdb::string_view instead of name+len.
2436         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2437         * psympriv.h (add_psymbol_to_list): Likewise.
2438         * psymtab.c (add_psymbol_to_bcache): Likewise.
2439         (add_psymbol_to_list): Likewise.
2440         * stabsread.c (define_symbol): Update.
2441         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2442         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2443         (symbol_set_names): Likewise.
2444         * xcoffread.c (scan_xcoff_symtab): Update.
2445
2446 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2447
2448         * symtab.h (symbol_set_names): Document that copy_name must be
2449         set to true for non-nullterminated strings.
2450         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2451         linkage_name if the entry was not found and we need to demangle.
2452
2453 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2454
2455         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2456         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2457         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2458         * gdbsupport/gdb_binary_search.h: New file.
2459
2460 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2461
2462         * NEWS: Mention new --with-system-gdbinit-dir option.
2463         * config.in: Regenerate.
2464         * configure: Regenerate.
2465         * configure.ac: Add new option --with-system-gdbinit-dir.
2466         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2467         for a ".gdb" suffix.
2468         * main.c (get_init_files): Change system_gdbinit argument to
2469         a vector and return the files in SYSTEM_GDBINIT_DIR in
2470         addition to SYSTEM_GDBINIT.
2471         (captured_main_1): Update.
2472         (print_gdb_help): Update.
2473         * top.c (print_gdb_configuration): Also print the value of
2474         SYSTEM_GDBINIT_DIR.
2475
2476 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2477
2478         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2479         that takes gdb::string_view arguments.
2480
2481 2019-10-26  Tom de Vries  <tdevries@suse.de>
2482
2483         * aarch64-linux-tdep.c: Fix typos in comments.
2484         * aarch64-tdep.c: Same.
2485         * ada-lang.c: Same.
2486         * amd64-nat.c: Same.
2487         * arc-tdep.c: Same.
2488         * arch/aarch64-insn.c: Same.
2489         * block.c: Same.
2490         * breakpoint.h: Same.
2491         * btrace.h: Same.
2492         * c-varobj.c: Same.
2493         * cli/cli-decode.c: Same.
2494         * cli/cli-script.c: Same.
2495         * cli/cli-utils.h: Same.
2496         * coff-pe-read.c: Same.
2497         * coffread.c: Same.
2498         * compile/compile-cplus-symbols.c: Same.
2499         * compile/compile-object-run.c: Same.
2500         * completer.c: Same.
2501         * corelow.c: Same.
2502         * cp-support.c: Same.
2503         * demangle.c: Same.
2504         * dwarf-index-write.c: Same.
2505         * dwarf2-frame.c: Same.
2506         * dwarf2-frame.h: Same.
2507         * eval.c: Same.
2508         * frame-base.h: Same.
2509         * frame.h: Same.
2510         * gdbcmd.h: Same.
2511         * gdbtypes.h: Same.
2512         * gnu-nat.c: Same.
2513         * guile/scm-objfile.c: Same.
2514         * i386-tdep.c: Same.
2515         * i386-tdep.h: Same.
2516         * infcall.c: Same.
2517         * infcall.h: Same.
2518         * linux-nat.c: Same.
2519         * m68k-tdep.c: Same.
2520         * macroexp.c: Same.
2521         * memattr.c: Same.
2522         * mi/mi-cmd-disas.c: Same.
2523         * mi/mi-getopt.h: Same.
2524         * mi/mi-main.c: Same.
2525         * minsyms.c: Same.
2526         * nat/aarch64-sve-linux-sigcontext.h: Same.
2527         * objfiles.h: Same.
2528         * ppc-linux-nat.c: Same.
2529         * ppc-linux-tdep.c: Same.
2530         * ppc-tdep.h: Same.
2531         * progspace.h: Same.
2532         * prologue-value.h: Same.
2533         * python/py-evtregistry.c: Same.
2534         * python/py-instruction.h: Same.
2535         * record-btrace.c: Same.
2536         * record-full.c: Same.
2537         * remote.c: Same.
2538         * rs6000-tdep.c: Same.
2539         * ser-tcp.c: Same.
2540         * sol-thread.c: Same.
2541         * sparc-sol2-tdep.c: Same.
2542         * sparc64-tdep.c: Same.
2543         * stabsread.c: Same.
2544         * symfile.c: Same.
2545         * symtab.h: Same.
2546         * target.c: Same.
2547         * tracepoint.c: Same.
2548         * tui/tui-data.h: Same.
2549         * tui/tui-io.c: Same.
2550         * tui/tui-win.c: Same.
2551         * tui/tui.c: Same.
2552         * unittests/rsp-low-selftests.c: Same.
2553         * user-regs.h: Same.
2554         * utils.c: Same.
2555         * utils.h: Same.
2556         * valarith.c: Same.
2557         * valops.c: Same.
2558         * valprint.c: Same.
2559         * valprint.h: Same.
2560         * value.c: Same.
2561         * value.h: Same.
2562         * varobj.c: Same.
2563         * x86-nat.h: Same.
2564         * xtensa-tdep.c: Same.
2565
2566 2019-10-25  Ali Tamur <tamur@google.com>
2567
2568         * charset.c (find_charset_names): Reflect API change.
2569
2570 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2571
2572         * symtab.c (struct demangled_name_entry): Change demangled name
2573         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2574         part of the struct anymore.
2575         (symbol_set_names): No longer obstack allocate + copy the demangled
2576         name, just store the allocated name from bfd.
2577
2578 2019-10-25  Tom Tromey  <tromey@adacore.com>
2579
2580         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2581         (bsearch_cie_cmp, add_cie): Remove.
2582         (find_cie): Reimplement.
2583         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2584         (dwarf2_build_frame_info): Update.
2585
2586 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2587
2588         PR gdb/25126
2589         * symfile.c (reread_symbols): Call forget_cached_source_info to
2590         clear the stale source cache.
2591
2592 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2593
2594         * configure: Regenerate.
2595         * configure.ac: Remove code that sets python_has_threads.
2596
2597 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2598
2599         * config.in: Regenerate.
2600         * configure: Regenerate.
2601         * configure.ac: Remove the code that uses sed to get the python
2602         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2603
2604 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2605
2606         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2607         error paths.
2608
2609 2019-10-23  Tom Tromey  <tom@tromey.com>
2610
2611         * arc-tdep.c: Remove ".." from include.
2612         * frv-tdep.c: Remove ".." from include.
2613         * lm32-tdep.c: Remove ".." from include.
2614         * microblaze-tdep.c: Remove ".." from include.
2615         * or1k-tdep.h: Remove ".." from include.
2616         * s12z-tdep.c: Remove ".." from include.
2617         * Makefile.in (OPCODES_CFLAGS): Add comment.
2618         (TOP_CFLAGS): New variable.
2619         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2620
2621 2019-10-23  Tom Tromey  <tom@tromey.com>
2622
2623         * Makefile.in (READLINE_DIR): Update.
2624
2625 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2626
2627         * infcall.c (call_function_by_hand_dummy): Fix the function
2628         comment.  And extract out a code section into...
2629         (reserve_stack_space): ...this new function.
2630
2631 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2632
2633         * infcall.c (value_arg_coerce): Remove an unused parameter.
2634         (call_function_by_hand_dummy): Update the call to
2635         'value_arg_coerce'.
2636
2637 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2638
2639         * infcall.c (call_function_by_hand_dummy): Refactor.
2640
2641 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2642
2643         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2644
2645 2019-10-23  Tom Tromey  <tom@tromey.com>
2646
2647         * configure: Rebuild.
2648         * configure.ac: Don't check for sigprocmask.
2649         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2650
2651 2019-10-23  Tom Tromey  <tom@tromey.com>
2652
2653         * configure: Rebuild.
2654         * acinclude.m4: Use m4_include, not sinclude.
2655
2656 2019-10-23  Tom de Vries  <tdevries@suse.de>
2657
2658         PR breakpoints/24687
2659         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2660
2661 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2662
2663         * symtab.c (struct demangled_name_entry) <language>: Change from
2664         bitfield to regular variable.
2665
2666 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2667
2668         * symtab.c (struct demangled_name_entry): Add a constructor.
2669         (free_demangled_name_entry): New function to call the destructor
2670         for demangled_name_entry.
2671         (create_demangled_names_hash): Pass free_demangled_name_entry to
2672         htab_create_alloc.
2673         (symbol_set_names): Call placement new for demangled_name_entry.
2674         * utils.c: No longer include xxhash.h here, now that fast_hash
2675         is inlined in the header.
2676         * utils.h: Instead, include it here.
2677
2678 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2679
2680         * Makefile.in: Link with libxxhash.
2681         * config.in: Regenerate.
2682         * configure: Regenerate.
2683         * configure.ac: Search for libxxhash.
2684         * utils.c (fast_hash): Use xxhash if present.
2685
2686 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2687
2688         * utils.h (fast_hash): New function.
2689         * symtab.c (hash_demangled_name_entry): Call new function
2690         fast_hash.
2691
2692 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2693
2694         * symtab.c (struct demangled_name_entry): Change type of mangled
2695         to gdb::string_view. Also adds a constructor that takes the
2696         mangled name.
2697         (hash_demangled_name_entry): Update.
2698         (eq_demangled_name_entry): Update.
2699         (free_demangled_name_entry): New function to call the destructor
2700         now that this is not a POD anymore.
2701         (create_demangled_names_hash): Pass free_demangled_name_entry to
2702         htab_create_alloc.
2703         (symbol_set_names): Update.
2704
2705 2019-10-21  Ali Tamur  <tamu@google.com>
2706
2707         * dwarf2read.c (dir_index): Change type.
2708         (file_name_index): Likewise.
2709         (line_header::include_dir_at): Change comment and implementation on
2710         whether it is DWARF 5.
2711         (line_header::is_valid_file_index): New function.
2712         (line_header::file_name_at): Change comment and implementation on
2713         whether it is DWARF 5.
2714         (line_header::file_names): Change to private field renamed as
2715         m_file_names and introduce a new accessor method.
2716         (line_header::file_names_size): New method.
2717         (line_header::include_dirs): Change to private field and rename as
2718         m_include_dirs.
2719         (dw2_get_file_names_reader): Define local var at a smaller scope and
2720         reflect API change.
2721         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2722         (process_structure_scope): Likewise.
2723         (line_header::add_include_dir): Change message and reflect renaming.
2724         (line_header::add_file_name): Likewise.
2725         (read_formatted_entries): Handle DW_FORM_data16.
2726         (dwarf_decode_line_header): Fix line header length calculation.
2727         (psymtab_include_file_name): Change comment and API.
2728         (lnp_state_machine::m_file): Update comment and reflect type change.
2729         (lnp_state_machine::record_line): Reflect type change.
2730         (dwarf_decode_lines): Reflect API change.
2731         (file_file_name): Likewise.
2732         (file_full_name): Likewise.
2733
2734 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2735
2736         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2737
2738 2019-10-21  Tom Tromey  <tom@tromey.com>
2739
2740         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2741
2742 2019-10-21  Tom Tromey  <tom@tromey.com>
2743
2744         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2745         NM_H.   Use AC_CONFIG_LINKS.
2746         * configure: Rebuild.
2747         * Makefile.in (NM_H): New variable.
2748         (generated_files): Add NM_H.  Remove gcore.
2749         (nm.h, stamp-nmh): New targets.
2750
2751 2019-10-20  Tom Tromey  <tom@tromey.com>
2752
2753         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2754         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2755         obsolete comment.
2756         (put_objfile_before): Now static.
2757
2758 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2759
2760         * gdbsupport/common-utils.h (startswith): Change return type to
2761         bool.
2762
2763 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2764
2765         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2766         * breakpoint.c (bp_locations_compare): Rename to...
2767         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2768         (update_global_location_list): Use std::sort instead of qsort.
2769         * buildsym.c (compare_line_numbers): Rename to...
2770         (lte_is_less_than): ...this, and change to std::sort semantics.
2771         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2772         instead of qsort.
2773         * disasm.c (compare_lines): Rename to...
2774         (line_is_less_than): ...this, and change to std::sort semantics.
2775         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2776         of qsort.
2777         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2778         (fde_is_less_than): ...this, and change to std::sort semantics.
2779         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2780         * mdebugread.c (compare_blocks):
2781         (block_is_less_than): ...this, and change to std::sort semantics.
2782         (sort_blocks): Call std::sort instead of qsort.
2783         * objfiles.c (qsort_cmp): Rename to...
2784         (sort_cmp): ...this, and change to std::sort semantics.
2785         (update_section_map): Call std::sort instead of qsort.
2786         * remote.c (compare_pnums): Remove.
2787         (map_regcache_remote_table): Call std::sort instead of qsort.
2788         * utils.c (compare_positive_ints): Remove.
2789         * utils.h (compare_positive_ints): Remove.
2790         * xcoffread.c (compare_lte): Remove.
2791         (arrange_linetable): Call std::sort instead of qsort.
2792
2793 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2794
2795         * symfile.c (init_entry_point_info): Fix typo.
2796         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2797
2798 2019-10-18  Tom de Vries  <tdevries@suse.de>
2799
2800         * aarch64-tdep.c: Fix typos in comments.
2801         * ada-lang.c: Same.
2802         * ada-tasks.c: Same.
2803         * alpha-tdep.c: Same.
2804         * alpha-tdep.h: Same.
2805         * amd64-nat.c: Same.
2806         * amd64-windows-tdep.c: Same.
2807         * arc-tdep.c: Same.
2808         * arc-tdep.h: Same.
2809         * arch-utils.c: Same.
2810         * arm-nbsd-tdep.c: Same.
2811         * arm-tdep.c: Same.
2812         * ax-gdb.c: Same.
2813         * blockframe.c: Same.
2814         * btrace.c: Same.
2815         * c-varobj.c: Same.
2816         * coff-pe-read.c: Same.
2817         * coffread.c: Same.
2818         * cris-tdep.c: Same.
2819         * darwin-nat.c: Same.
2820         * dbxread.c: Same.
2821         * dcache.c: Same.
2822         * disasm.c: Same.
2823         * dtrace-probe.c: Same.
2824         * dwarf-index-write.c: Same.
2825         * dwarf2-frame-tailcall.c: Same.
2826         * dwarf2-frame.c: Same.
2827         * dwarf2read.c: Same.
2828         * eval.c: Same.
2829         * exceptions.c: Same.
2830         * fbsd-tdep.c: Same.
2831         * findvar.c: Same.
2832         * frame.c: Same.
2833         * frv-tdep.c: Same.
2834         * gnu-v3-abi.c: Same.
2835         * go32-nat.c: Same.
2836         * h8300-tdep.c: Same.
2837         * hppa-tdep.c: Same.
2838         * i386-linux-tdep.c: Same.
2839         * i386-tdep.c: Same.
2840         * ia64-libunwind-tdep.c: Same.
2841         * ia64-tdep.c: Same.
2842         * infcmd.c: Same.
2843         * infrun.c: Same.
2844         * linespec.c: Same.
2845         * linux-nat.c: Same.
2846         * linux-thread-db.c: Same.
2847         * machoread.c: Same.
2848         * mdebugread.c: Same.
2849         * mep-tdep.c: Same.
2850         * mn10300-tdep.c: Same.
2851         * namespace.c: Same.
2852         * objfiles.c: Same.
2853         * opencl-lang.c: Same.
2854         * or1k-tdep.c: Same.
2855         * osabi.c: Same.
2856         * ppc-linux-nat.c: Same.
2857         * ppc-linux-tdep.c: Same.
2858         * ppc-sysv-tdep.c: Same.
2859         * printcmd.c: Same.
2860         * procfs.c: Same.
2861         * record-btrace.c: Same.
2862         * record-full.c: Same.
2863         * remote-fileio.c: Same.
2864         * remote.c: Same.
2865         * rs6000-tdep.c: Same.
2866         * s12z-tdep.c: Same.
2867         * score-tdep.c: Same.
2868         * ser-base.c: Same.
2869         * ser-go32.c: Same.
2870         * skip.c: Same.
2871         * sol-thread.c: Same.
2872         * solib-svr4.c: Same.
2873         * solib.c: Same.
2874         * source.c: Same.
2875         * sparc-nat.c: Same.
2876         * sparc-sol2-tdep.c: Same.
2877         * sparc-tdep.c: Same.
2878         * sparc64-tdep.c: Same.
2879         * stabsread.c: Same.
2880         * stack.c: Same.
2881         * symfile.c: Same.
2882         * symtab.c: Same.
2883         * target-descriptions.c: Same.
2884         * target-float.c: Same.
2885         * thread.c: Same.
2886         * utils.c: Same.
2887         * valops.c: Same.
2888         * valprint.c: Same.
2889         * value.c: Same.
2890         * varobj.c: Same.
2891         * windows-nat.c: Same.
2892         * xcoffread.c: Same.
2893         * xstormy16-tdep.c: Same.
2894         * xtensa-tdep.c: Same.
2895
2896 2019-10-17  Tom Tromey  <tromey@adacore.com>
2897
2898         * configure: Rebuild.
2899         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2900         in AC_CONFIG_FILES invocation.
2901         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2902         new-style config.status invocation.
2903
2904 2019-10-17  Tom de Vries  <tdevries@suse.de>
2905
2906         * arm-nbsd-nat.c: Fix typos in comments.
2907         * arm-tdep.c: Same.
2908         * darwin-nat-info.c: Same.
2909         * dwarf2read.c: Same.
2910         * elfread.c: Same.
2911         * event-top.c: Same.
2912         * findvar.c: Same.
2913         * gdbtypes.c: Same.
2914         * hppa-tdep.c: Same.
2915         * i386-tdep.c: Same.
2916         * jit.c: Same.
2917         * main.c: Same.
2918         * mdebugread.c: Same.
2919         * moxie-tdep.c: Same.
2920         * nto-procfs.c: Same.
2921         * osabi.c: Same.
2922         * ppc-linux-tdep.c: Same.
2923         * remote.c: Same.
2924         * riscv-tdep.c: Same.
2925         * s390-tdep.c: Same.
2926         * sh-tdep.c: Same.
2927         * sparc-linux-tdep.c: Same.
2928         * sparc-nat.c: Same.
2929         * stack.c: Same.
2930         * target-descriptions.c: Same.
2931         * top.c: Same.
2932         * varobj.c: Same.
2933
2934 2019-10-16  Tom Tromey  <tom@tromey.com>
2935
2936         * objfiles.h (struct objfile) <original_name>: Now const.
2937
2938 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2939
2940         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2941         pass on to sigsetjmp's second argument.
2942         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2943
2944 2019-10-16  Keith Seitz  <keiths@redhat.com>
2945
2946         PR gdb/23567
2947         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2948         sections whose size is greater than the file size.
2949
2950 2019-10-16  Jim Wilson  <jimw@sifive.com>
2951
2952         * riscv-tdep.c (riscv_gcc_target_options): New.
2953         (riscv_gnu_triplet_regexp): New.
2954         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2955         set_gdbarch_gnu_triplet_regexp.
2956
2957 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2958
2959         * Makefile.in: Add xml-builtin.h.
2960         * features/feature_to_c.sh: Add an include for xml-builtin.h
2961         to ensure that the compiler checks that the types match.
2962         * xml-builtin.h: New file.
2963         * xml-support.c (fetch_xml_builtin): Add missing const.
2964         * xml-support.h: Remove declaration of xml_builtins.
2965
2966 2019-10-16  Tom de Vries  <tdevries@suse.de>
2967
2968         PR tdep/25096
2969         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2970         (amd64_classify_aggregate): ... here.
2971         (amd64_classify_aggregate_field): Handled fiels of nested structs
2972         recursively.
2973
2974 2019-10-16  Tom de Vries  <tdevries@suse.de>
2975
2976         PR tdep/24104
2977         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2978         that handles 'theclass'.
2979
2980 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2981
2982         * linespec.c (decode_digits_ordinary): Update comment.
2983         * make-target-delegates: No longer need to handle VEC case.
2984         * memrange.c (normalize_mem_ranges): Update comment.
2985         * namespace.c (add_using_directive): Update comment.
2986         * objc-lang.c (uniquify_strings): Update comment.
2987         * ppc-linux-nat.c (struct thread_points): Update comment.
2988         * probe.h (find_probes_in_objfile): Update comment.
2989         * target.h (enum flash_preserve_mode): Update comment.
2990         * varobj.c (varobj_restrict_range): Update comment.
2991         * varobj.h (varobj_list_children): Update comment.
2992
2993 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2994
2995         * Makefile.in: Remove references to vec.h and vec.c.
2996         * aarch64-tdep.c: No longer include vec.h.
2997         * ada-lang.c: Likewise.
2998         * ada-lang.h: Likewise.
2999         * arm-tdep.c: Likewise.
3000         * ax.h: Likewise.
3001         * breakpoint.h: Likewise.
3002         * charset.c: Likewise.
3003         * cp-support.h: Likewise.
3004         * dtrace-probe.c: Likewise.
3005         * dwarf2read.c: Likewise.
3006         * extension.h: Likewise.
3007         * gdb_bfd.c: Likewise.
3008         * gdbsupport/gdb_vecs.h: Likewise.
3009         * gdbsupport/vec.c: Remove.
3010         * gdbsupport/vec.h: Remove.
3011         * gdbthread.h: Likewise.
3012         * guile/scm-type.c: Likewise.
3013         * inline-frame.c: Likewise.
3014         * machoread.c: Likewise.
3015         * memattr.c: Likewise.
3016         * memrange.h: Likewise.
3017         * namespace.h: Likewise.
3018         * nat/linux-btrace.h: Likewise.
3019         * osdata.c: Likewise.
3020         * parser-defs.h: Likewise.
3021         * progspace.h: Likewise.
3022         * python/py-type.c: Likewise.
3023         * record-btrace.c: Likewise.
3024         * rust-exp.y: Likewise.
3025         * solib-target.c: Likewise.
3026         * stap-probe.c: Likewise.
3027         * target-descriptions.c: Likewise.
3028         * target-memory.c: Likewise.
3029         * target.h: Likewise.
3030         * varobj.c: Likewise.
3031         * varobj.h: Likewise.
3032         * xml-support.h: Likewise.
3033
3034 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3035
3036         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3037         Update for new std::vector based implementation.
3038         (process_psymtab_comp_unit_reader): Likewise.
3039         (scan_partial_symbols): Likewise.
3040         (recursively_compute_inclusions): Likewise.
3041         (compute_compunit_symtab_includes): Likewise.
3042         (process_imported_unit_die): Likewise.
3043         (queue_and_load_dwo_tu): Likewise.
3044         (follow_die_sig_1): Likewise.
3045         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3046         (typedef dwarf2_per_cu_ptr): Remove.
3047         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3048         function.
3049         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3050         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3051         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3052         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3053         std::vector.
3054
3055 2019-10-15  Tom Tromey  <tromey@adacore.com>
3056
3057         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3058         TID.
3059
3060 2019-10-15  Tom Tromey  <tromey@adacore.com>
3061
3062         * windows-nat.c (windows_nat_target::fetch_registers)
3063         (windows_nat_target::store_registers): Rename "pid" to "tid".
3064
3065 2019-10-15  Tom Tromey  <tromey@adacore.com>
3066
3067         * gdbarch.h, gdbarch.c: Rebuild.
3068         * gdbarch.sh (gcc_target_options): Change return type to
3069         std::string.
3070         * compile/compile.c (get_args): Update.
3071         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3072         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3073         std::string.
3074         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3075         std::string.
3076         * arch-utils.c (default_gcc_target_options): Return std::string.
3077         * arch-utils.h (default_gcc_target_options): Return std::string.
3078         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3079
3080 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3081
3082         * breakpoint.c (breakpoint_chain): Make static.
3083         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3084         of accessing breakpoint_chain.
3085
3086 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3087
3088         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3089         to a gdb::function_view and return value to bool.
3090         * breakpoint.h (iterate_over_breakpoints): Likewise.
3091         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3092         (pop_dummy_frame): Update.
3093         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3094         (gdbscm_breakpoints): Update.
3095         * python/py-breakpoint.c (build_bp_list): Update.
3096         (gdbpy_breakpoints): Update.
3097         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3098         Update.
3099         (bpfinishpy_handle_stop): Update.
3100         (bpfinishpy_handle_exit): Update.
3101         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3102         (svr4_update_solib_event_breakpoints): Update.
3103
3104 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3105
3106         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3107         when unwrapping single-field structs.
3108
3109 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3110
3111         * dwarf2read.c: Remove includes.
3112
3113 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3114
3115         * ui-out.c (ui_out::call_do_message): Silence
3116         -Wformat-nonliteral warning.
3117
3118 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3119
3120         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3121         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3122         include: readline/tilde.h.
3123
3124 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3125
3126         * remote.c (remote_target::get_trace_status): Remove declaration of
3127         trace_regblock_size.
3128
3129 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3130
3131         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3132         (show_user): Remove declaration of cmdlist.
3133         * cli/cli-cmds.h (max_user_call_depth): Declare.
3134         * cli/cli-script.c (execute_user_command): Remove declaration
3135         of max_user_call_depth.
3136
3137 2019-10-11  Jim Wilson  <jimw@sifive.com>
3138
3139         * gdbsupport/print-utils.h (pulongest): Fix comment.
3140         (plongest): Likewise.
3141         (phex): Add missing comment, mention leading zeros.
3142         (phex_nz): Add mention of no leading zeros to comment.
3143
3144         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3145         plongest instead of unsigned long long cast.
3146
3147 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3148
3149         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3150         for external_editor_command and gdbtk_test.
3151
3152 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3153
3154         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3155         * varobj.c (varobjdebug): Move comment to...
3156         * varobj.h (varobjdebug): ...here, and declare.
3157
3158 2019-10-09  Tom Tromey  <tom@tromey.com>
3159
3160         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3161         erase_data_content.
3162
3163 2019-10-09  Tom Tromey  <tom@tromey.com>
3164
3165         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3166         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3167         * tui/tui-command.c (tui_cmd_window::resize)
3168         (tui_refresh_cmd_win): Update.
3169         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3170         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3171         * tui/tui-data.c (~tui_gen_win_info): Remove.
3172         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3173         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3174         (tui_redisplay_readline, tui_mld_flush)
3175         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3176         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3177         (tui_data_window::erase_data_content)
3178         (tui_data_item_window::rerender)
3179         (tui_data_item_window::refresh_window): Update.
3180         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3181         (box_win, tui_gen_win_info::make_window)
3182         (tui_gen_win_info::make_visible): Update.
3183         (tui_delete_win): Remove.
3184         * tui/tui-winsource.c
3185         (tui_source_window_base::do_erase_source_content): Update.
3186         (tui_show_source_line, tui_source_window_base::update_tab_width)
3187         (tui_source_window_base::update_exec_info): Update.
3188         * tui/tui-data.h (struct curses_deleter): New.
3189         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3190         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3191
3192 2019-10-09  Tom Tromey  <tom@tromey.com>
3193
3194         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3195
3196 2019-10-09  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3199         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3200
3201 2019-10-09  Tom Tromey  <tom@tromey.com>
3202
3203         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3204         window height directly.
3205         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3206         declare.
3207         * tui/tui-layout.c (tui_default_win_height): Remove.
3208         (tui_default_win_viewport_height): Remove.
3209
3210 2019-10-09  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui.h: Remove comments.
3213
3214 2019-10-09  Tom de Vries  <tdevries@suse.de>
3215
3216         * python/lib/gdb/printer/bound_registers.py: Use
3217         '^builtin_type_bound128' as regexp argument for
3218         add_builtin_pretty_printer.
3219
3220 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3221
3222         * guile/guile.c (guile_extension_script_ops): Remove forward
3223         declaration and mark as static.
3224         (guile_script_ops): Likewise.
3225         (extension_language_guile): Move further down in the file so
3226         it can reference the definitions for guile_{extension_,}script_ops.
3227
3228 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3229
3230         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3231         except SORTL, DFLTCC, and KDSA.
3232
3233 2019-10-08  Tom Tromey  <tromey@adacore.com>
3234
3235         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3236         (struct safe_symbol_file_add_args): Remove.
3237
3238 2019-10-08  Tom Tromey  <tromey@adacore.com>
3239
3240         * windows-nat.c: Don't include buildsym-legacy.h.
3241
3242 2019-10-08  Tom Tromey  <tromey@adacore.com>
3243
3244         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3245
3246 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3247
3248         * gdbtypes.c (overload_debug): Move comment to header.
3249         * gdbtypes.h (overload_debug): Declare.
3250         * valops.c: Remove declaration of overload_debug, instead
3251         include gdbtypes.h.
3252
3253 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3254
3255         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3256         through _().
3257         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3258         move comment...
3259         * language.h (lang_frame_mismatch_warn): ... here. Also add
3260         declaration.
3261         * top.c (lang_frame_mismatch_warn): Remove declaration.
3262         (check_frame_language_change): Pass lang_frame_mismatch_warn
3263         through _().
3264
3265 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3266
3267         * c-lang.h (vtbl_ptr_name): Declare.
3268         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3269         it from the header.
3270         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3271
3272 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3273
3274         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3275         gdb_static_assert.
3276
3277 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3278
3279         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3280         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3281         * ctfread.c: New file.
3282         * ctfread.h: New file.
3283         * elfread.c: Include ctfread.h.
3284         (struct elfinfo text_p): New member ctfsect.
3285         (elf_locate_sections): Mark CTF section.
3286         (elf_symfile_read): Call elfctf_build_psymtabs.
3287         * Makefile.in (LIBCTF): Add.
3288         (CLIBS): Use it.
3289         (CDEPS): Likewise.
3290         (DIST): Add ctfread.c.
3291
3292 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3293
3294         * ctfread.c (struct nextfield): Renamed to ...
3295         (struct ctf_nextfield): ... this.
3296         (struct field_info): Renamed to ...
3297         (strut ctf_field_info): ... this.
3298         (attach_fields_to_type): Update for renamed structures.
3299         (ctf_add_member_cb): Likewise.
3300         (ctf_add_enum_member_cb): Likewise.
3301         (process_struct_members): Likewise.
3302         (process_enum_type): Likewise.
3303
3304 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3305
3306         * tracectf.h: Rename, was ctf.h.
3307         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3308         * tracefile.c: Likewise.
3309         * tracepoint.c: Remove unused include ctf.h.
3310         * mi/mi-main.c: Likewise.
3311         * Makefile.in Replace ctf.c with tracectf.c.
3312
3313 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3314
3315         * version.in: Change version number to "9.0.50.DATE-git".
3316
3317 2019-10-03  Tom Tromey  <tom@tromey.com>
3318
3319         PR rust/24976:
3320         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3321
3322 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3323
3324         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3325         cp_search_name_hash.
3326         * NEWS: Add entry about nested function support.
3327
3328 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3329             Andrew Burgess  <andrew.burgess@embecosm.com>
3330
3331         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3332         for nested static variables when searchin VAR_DOMAIN.
3333         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3334         global scope, update comment.
3335         (add_partial_subprogram): Call add_partial_subprogram recursively
3336         for nested subroutines when processinng Fortran.
3337         (load_partial_dies): Process the child entities of a subprogram
3338         when processing Fortran.
3339         (partial_die_parent_scope): Handle building scope
3340         for Fortran nested functions.
3341         (process_die): Record that nested functions have a scope.
3342         (new_symbol): Always record Fortran subprograms on the global
3343         symbol list.
3344         (determine_prefix): How to build the prefix for Fortran
3345         subprograms.
3346
3347 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3348
3349         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3350         have just sent the thread a SIGSTOP and are waiting for it to
3351         arrive.
3352
3353 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3354
3355         * btrace.c (btrace_add_pc): Remove whitespace before the template
3356         parameter in 'std::vector <...>'.
3357         (parse_xml_btrace_block): Likewise.
3358         (btrace_maint_decode_pt): Likewise.
3359         (btrace_maint_update_packets): Likewise.
3360         (btrace_maint_print_packets): Likewise.
3361         * btrace.h (struct btrace_maint_info): Likewise.
3362         * dwarf2read.c (struct type_unit_group): Likewise.
3363         (build_type_psymtabs_reader): Likewise.
3364         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3365         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3366         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3367
3368 2019-10-03  Tom de Vries  <tdevries@suse.de>
3369
3370         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3371         the first line of the help text for set/show style metadata.
3372
3373 2019-10-02  Tom Tromey  <tromey@adacore.com>
3374
3375         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3376         * gdbsupport/common-inferior.c: New file.
3377         * infcmd.c (startup_with_shell): Don't define.
3378         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3379         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3380         * inferior.h (startup_with_shell): Don't declare.
3381
3382 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3383
3384         * gdbsupport/gdb_assert.h: Include errors.h.
3385         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3386
3387 2019-10-02  Tom Tromey  <tromey@adacore.com>
3388
3389         * NEWS: Add $_ada_exception entry.
3390         * ada-lang.c (struct ada_catchpoint): Add constructor.
3391         <m_kind>: New member.
3392         (allocate_location_exception, re_set_exception): Remove
3393         "ex" parameter.
3394         (should_stop_exception): Compute $_ada_exception.
3395         (check_status_exception, print_it_exception)
3396         (print_one_exception, print_mention_exception): Remove
3397         "ex" parameter.
3398         (allocate_location_catch_exception, re_set_catch_exception)
3399         (check_status_exception, print_it_catch_exception)
3400         (print_one_catch_exception, print_mention_catch_exception)
3401         (print_recreate_catch_exception)
3402         (allocate_location_catch_exception_unhandled)
3403         (re_set_catch_exception_unhandled)
3404         (check_status_exception, print_it_catch_exception_unhandled)
3405         (print_one_catch_exception_unhandled)
3406         (print_mention_catch_exception_unhandled)
3407         (print_recreate_catch_exception_unhandled)
3408         (allocate_location_catch_assert, re_set_catch_assert)
3409         (check_status_assert, print_it_catch_assert)
3410         (print_one_catch_assert, print_mention_catch_assert)
3411         (print_recreate_catch_assert)
3412         (allocate_location_catch_handlers, re_set_catch_handlers)
3413         (check_status_handlers, print_it_catch_handlers)
3414         (print_one_catch_handlers, print_mention_catch_handlers)
3415         (print_recreate_catch_handlers): Remove.
3416         (create_ada_exception_catchpoint): Update.
3417         (initialize_ada_catchpoint_ops): Update.
3418
3419 2019-10-02  Tom Tromey  <tromey@adacore.com>
3420
3421         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3422         (create_excep_cond_exprs): Simplify exception string computation.
3423         (ada_exception_catchpoint_cond_string): Likewise.
3424
3425 2019-10-02  Tom Tromey  <tromey@adacore.com>
3426
3427         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3428         * ada-lang.c (lesseq_defined_than): Handle
3429         LOC_STATIC.
3430         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3431         parameter.
3432         (dwarf2_has_info): Likewise.
3433         (new_symbol): Set maybe_copied on symbol when
3434         appropriate.
3435         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3436         parameter.
3437         <can_copy>: New member.
3438         * elfread.c (record_minimal_symbol): Set maybe_copied
3439         on symbol when appropriate.
3440         (elf_symfile_read): Update call to dwarf2_has_info.
3441         * minsyms.c (lookup_minimal_symbol_linkage): New
3442         function.
3443         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3444         * symtab.c (get_symbol_address, get_msymbol_address):
3445         New functions.
3446         * symtab.h (get_symbol_address, get_msymbol_address):
3447         Declare.
3448         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3449         maybe_copied.
3450         (struct symbol, struct minimal_symbol) <maybe_copied>:
3451         New member.
3452
3453 2019-10-02  Tom Tromey  <tromey@adacore.com>
3454
3455         * source.c (struct current_source_location): New.
3456         (current_source_key): New global.
3457         (current_source_symtab, current_source_line)
3458         (current_source_pspace): Remove.
3459         (get_source_location): New function.
3460         (get_current_source_symtab_and_line)
3461         (set_default_source_symtab_and_line)
3462         (set_current_source_symtab_and_line)
3463         (clear_current_source_symtab_and_line, select_source_symtab)
3464         (info_source_command, print_source_lines_base)
3465         (info_line_command, search_command_helper, _initialize_source):
3466         Update.
3467
3468 2019-10-02  Tom Tromey  <tromey@adacore.com>
3469
3470         * source.c (select_source_symtab): Don't call
3471         decode_line_with_current_source.
3472
3473 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3474
3475         * symtab.c (lookup_global_symbol): Search global block.
3476
3477 2019-10-02  Tom Tromey  <tromey@adacore.com>
3478
3479         * coffread.c (process_coff_symbol): Update.
3480         * dwarf2read.c (var_decode_location, new_symbol): Update.
3481         * mdebugread.c (parse_symbol): Update.
3482         * objfiles.c (relocate_one_symbol): Update.
3483         * stabsread.c (define_symbol, fix_common_block)
3484         (scan_file_globals): Update.
3485         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3486         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3487         * xcoffread.c (process_xcoff_symbol): Update.
3488
3489 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3490
3491         * MAINTAINERS: Update my email address.
3492
3493 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3494
3495         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3496         std::vector.
3497         (build_type_psymtabs_reader): Update for std::vector.
3498         (build_type_psymtab_dependencies): Likewise.
3499         * dwarf2read.h: Remove use of DEF_VEC_P.
3500         (typedef sig_type_ptr): Delete.
3501
3502 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3503
3504         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3505         to std::vector.
3506         (btrace_maint_decode_pt): Likewise, and move allocation of the
3507         vector outside of the loop.
3508         (btrace_maint_update_packets): Update to handle change from VEC to
3509         std::vector.
3510         (btrace_maint_print_packets): Likewise.
3511         (maint_info_btrace_cmd): Likewise.
3512         * btrace.h: Remove use of DEF_VEC_O.
3513         (typedef btrace_pt_packet_s): Delete.
3514         (struct btrace_maint_info) <packets>: Change fromm VEC to
3515         std::vector.
3516         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3517
3518 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3519
3520         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3521         make accesses into the vector constant references.
3522         (btrace_add_pc): Update for std::vector.
3523         (btrace_stitch_bts): Likewise.
3524         (parse_xml_btrace_block): Likewise.
3525         (btrace_maint_update_packets): Likewise.
3526         (btrace_maint_print_packets): Likewise.
3527         (maint_info_btrace_cmd): Likewise.
3528         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3529         std::vector.
3530         (btrace_data::empty): Likewise.
3531         (btrace_data_append): Likewise.
3532         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3533         (typedef btrace_block_s): Delete.
3534         (struct btrace_block): Add constructor.
3535         (struct btrace_data_bts) <blocks>: Change to std::vector.
3536         * nat/linux-btrace.c (perf_event_read_bts): Update for
3537         std::vector.
3538         (linux_read_bts): Likewise.
3539
3540 2019-10-01  Tom Tromey  <tom@tromey.com>
3541
3542         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3543
3544 2019-10-01  Tom Tromey  <tom@tromey.com>
3545
3546         * stack.c (print_frame, info_frame_command_core): Use
3547         styled_string.
3548         * linux-thread-db.c (try_thread_db_load_1)
3549         (try_thread_db_load_from_pdir_1): Use styled_string.
3550         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3551         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3552         (maybe_print_unsupported_script_warning)
3553         (maybe_print_script_not_found_warning): Use styled_string.
3554         * ada-lang.c (user_select_syms): Use styled_string.
3555
3556 2019-10-01  Tom Tromey  <tom@tromey.com>
3557
3558         * p-lang.c (pascal_printstr): Use metadata style.
3559         * value.c (show_convenience): Use metadata style.
3560         * valprint.c (valprint_check_validity, val_print_optimized_out)
3561         (val_print_not_saved, val_print_unavailable)
3562         (val_print_invalid_address, generic_val_print, val_print)
3563         (value_check_printable, val_print_array_elements): Use metadata
3564         style.
3565         * ui-out.h (class ui_out) <field_fmt>: New overload.
3566         <do_field_fmt>: Add style parameter.
3567         * ui-out.c (ui_out::field_fmt): New overload.
3568         * typeprint.c (type_print_unknown_return_type)
3569         (val_print_not_allocated, val_print_not_associated): Use metadata
3570         style.
3571         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3572         parameter.
3573         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3574         * tracepoint.c (tvariables_info_1): Use metadata style.
3575         * stack.c (print_frame_arg, print_frame_info, print_frame)
3576         (info_frame_command_core): Use metadata style.
3577         * skip.c (info_skip_command): Use metadata style.
3578         * rust-lang.c (rust_print_enum): Use metadata style.
3579         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3580         metadata style.
3581         * python/py-framefilter.c (py_print_single_arg): Use metadata
3582         style.
3583         * printcmd.c (do_one_display, print_variable_and_value): Use
3584         metadata style.
3585         * p-valprint.c (pascal_val_print)
3586         (pascal_object_print_value_fields): Use metadata style.
3587         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3588         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3589         parameter.
3590         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3591         * m2-valprint.c (m2_print_long_set): Use metadata style.
3592         * m2-typeprint.c (m2_print_type): Use metadata style.
3593         * infcmd.c (print_return_value_1): Use metadata style.
3594         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3595         * f-valprint.c (info_common_command_for_block): Use metadata
3596         style.
3597         * f-typeprint.c (f_type_print_base): Use metadata style.
3598         * expprint.c (print_subexp_standard): Use metadata style.
3599         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3600         * cli/cli-style.h (class cli_style_option): Add constructor.
3601         (metadata_style): Declare.
3602         * cli/cli-style.c (metadata_style): New global.
3603         (_initialize_cli_style): Register metadata style.
3604         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3605         parameter.
3606         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3607         * c-typeprint.c (c_type_print_base_struct_union)
3608         (c_type_print_base_1): Use metadata style.
3609         * breakpoint.c (watchpoint_value_print)
3610         (print_one_breakpoint_location): Use metadata style.
3611         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3612         style.
3613         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3614         style.
3615         * ada-valprint.c (val_print_packed_array_elements, printstr)
3616         (print_field_values, ada_val_print_ref, ada_val_print): Use
3617         metadata style.
3618         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3619         style.
3620         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3621         style.
3622         * ada-lang.c (user_select_syms): Use metadata style.
3623
3624 2019-10-01  Tom Tromey  <tom@tromey.com>
3625
3626         * cli/cli-cmds.c (pwd_command): Style output.
3627
3628 2019-10-01  Pedro Alves  <palves@redhat.com>
3629             Tom Tromey  <tom@tromey.com>
3630
3631         * symtab.c (print_symbol_info): Use %ps.
3632         (print_msymbol_info): Use %ps.
3633         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3634         * printcmd.c (print_variable_and_value): Use %ps.
3635         * macrocmd.c (show_pp_source_pos): Use %ps.
3636         * infrun.c (print_exited_reason): Use ui_out::message.
3637         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3638         (describe_other_breakpoints): Use ui_out::message and new
3639         formats.
3640         (say_where): Use new formats.
3641         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3642         and new formats.
3643
3644 2019-10-01  Pedro Alves  <palves@redhat.com>
3645             Tom Tromey  <tom@tromey.com>
3646
3647         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3648         (test_gdb_formats): New function.
3649         (run_tests): Call it.
3650         (test_format_specifier): Update.
3651         * utils.h (fputs_filtered): Update comment.
3652         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3653         (fputs_styled_unfiltered): Declare.
3654         * utils.c (fputs_styled_unfiltered): New function.
3655         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3656         (vfprintf_filtered): Update.
3657         (vfprintf_unfiltered, vprintf_filtered): Update.
3658         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3659         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3660         disallow_ui_out_field>: New constants.
3661         (enum class field_kind): New.
3662         (struct base_field_s, struct signed_field_s): New.
3663         (signed_field): New function.
3664         (struct string_field_s): New.
3665         (string_field): New function.
3666         (struct styled_string_s): New.
3667         (styled_string): New function.
3668         (class ui_out) <message>: Add comment.
3669         <vmessage, call_do_message>: New methods.
3670         <do_message>: Add style parameter.
3671         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3672         methods.
3673         (ui_out::message): Rewrite.
3674         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3675         parameter.
3676         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3677         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3678         gdb_extensions parameter.
3679         (class format_piece): Add parameter to constructor.
3680         (n_int_args): New field.
3681         * gdbsupport/format.c (format_pieces::format_pieces): Add
3682         gdb_extensions parameter.  Handle '*'.
3683         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3684         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3685         vfprintf_styled_no_gdbfmt.
3686         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3687         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3688         unfiltered output.
3689         * ui-style.h (struct ui_file_style) <ptr>: New method.
3690
3691 2019-10-01  Tom Tromey  <tom@tromey.com>
3692
3693         * unittests/format_pieces-selftests.c: Update.  Add final format.
3694         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3695         empty literal pieces.
3696
3697 2019-10-01  Tom Tromey  <tom@tromey.com>
3698
3699         * ui-out.h (enum class ui_out_style_kind): Remove.
3700         (class ui_out) <field_string, field_stsream, do_field_string>:
3701         Change type of "style".
3702         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3703         (ui_out::field_string): Update.
3704         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3705         of "style".
3706         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3707         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3708         * stack.c (print_frame_arg, print_frame_info, print_frame):
3709         Update.
3710         * source.c (print_source_lines_base): Update.
3711         * solib.c (info_sharedlibrary_command): Update.
3712         * skip.c (info_skip_command): Update.
3713         * record-btrace.c (btrace_call_history_src_line)
3714         (btrace_call_history): Update.
3715         * python/py-framefilter.c (py_print_frame): Update.
3716         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3717         "style".
3718         * mi/mi-out.c (mi_ui_out::do_table_header)
3719         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3720         (mi_ui_out::do_field_string): Update.
3721         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3722         Update.
3723         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3724         "style".
3725         * cli-out.c (cli_ui_out::do_table_header)
3726         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3727         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3728         (cli_ui_out::do_field_fmt): Update.
3729         * breakpoint.c (print_breakpoint_location): Update.
3730         (update_static_tracepoint): Update.
3731
3732 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3733
3734         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3735         conversion of gdb_datadir.
3736         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3737         remove not needed c_str ().
3738
3739 2019-09-30  Ali Tamur <tamur@google.com>
3740
3741         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3742         (dwarf2_string_attr): Likewise.
3743
3744 2019-09-30  Ali Tamur <tamur@google.com>
3745
3746         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3747         (process_full_type_unit): Likewise.
3748         (dump_die_shallow): Likewise.
3749         (cu_debug_loc_section): Likewise.
3750
3751 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3752
3753         * minsyms.c (compare_minimal_symbols): Rename to...
3754         (minimal_symbol_is_less_than): ...this, and adjust to STL
3755         conventions (return bool, take arguments as references)
3756         (minimal_symbol_reader::install): Call std::sort instead
3757         of qsort.
3758
3759 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3760
3761         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3762         hash and why.
3763         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3764         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3765
3766 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3767
3768         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3769         * psympriv.h (add_psymbol_to_list): Move comment here and update
3770         it.
3771
3772 2019-09-29  Tom de Vries  <tdevries@suse.de>
3773
3774         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3775         Use $tmpdir/$(basename "$output_file").dwz instead of
3776         "${output_file}.dwz".
3777
3778 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3779
3780         PR gdb/25045
3781         * hppa-linux-nat.c: Include gdbarch.h.
3782
3783 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3784
3785         * blockframe.c (find_pc_partial_function): Change return type to bool.
3786         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3787         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3788         (stub_gnu_ifunc_resolve_name): Likewise.
3789         * symtab.c (compare_filenames_for_search): Likewise.
3790         (compare_glob_filenames_for_search): Likewise.
3791         (matching_obj_sections): Likewise.
3792         (symbol_matches_domain): Likewise.
3793         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3794         (find_line_pc): Change return type to bool.
3795         (find_line_pc_range): Likewise.
3796         (producer_is_realview): Likewise.
3797         * symtab.h (symbol_matches_domain): Likewise.
3798         (find_pc_partial_function): Likewise.
3799         (find_pc_line_pc_range): Likewise.
3800         (in_gnu_ifunc_stub): Likewise.
3801         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3802         (find_line_pc): Likewise.
3803         (find_line_pc_range): Likewise.
3804         (matching_obj_sections): Likewise.
3805         (find_line_symtab): Change out parameter to bool.
3806         (producer_is_realview): Change return type to bool.
3807         (compare_filenames_for_search): Likewise.
3808         (compare_glob_filenames_for_search): Likewise.
3809
3810 2019-09-26  Tom Tromey  <tom@tromey.com>
3811
3812         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3813         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3814         * gdb_usleep.h: Remove.
3815         * gdb_usleep.c: Remove.
3816         * utils.c: Don't include gdb_usleep.h.
3817
3818 2019-09-26  Tom Tromey  <tromey@adacore.com>
3819
3820         * python/py-type.c (type_to_type_object): Call check_typedef
3821         for stub types.
3822
3823 2019-09-26  Tom Tromey  <tom@tromey.com>
3824
3825         * utils.h (initialize_utils): Don't declare.
3826         * top.c (gdb_init): Don't call initialize_utils.
3827         * utils.c (initialize_utils): Remove.  Move contents...
3828         (_initialize_utils): ... here.
3829
3830 2019-09-25  Tom Tromey  <tom@tromey.com>
3831
3832         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3833         * utils.h (make_hex_string): Don't declare.
3834         * utils.c (make_hex_string): Remove.
3835
3836 2019-09-24  Tom de Vries  <tdevries@suse.de>
3837
3838         PR gdb/23815
3839         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3840         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3841
3842 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3843
3844         * NEWS: Mention new simulator port for PRU.
3845
3846 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3847
3848         * ada-exp.y (write_object_remaining): Update.
3849         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3850         and eliminate the static buffer.
3851         (ada_decode_symbol): Update.
3852         (ada_la_decode): Update.
3853         (ada_sniff_from_mangled_name): Update.
3854         (is_valid_name_for_wild_match): Update.
3855         (ada_lookup_name_info::matches): Update and simplify.
3856         (name_matches_regex): Update.
3857         (ada_add_global_exceptions): Update.
3858         * ada-lang.h (ada_decode): Update signature.
3859         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3860         * dwarf-index-write.c (debug_names::insert): Update.
3861
3862 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3863
3864         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3865         formatting.
3866
3867 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3868
3869         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3870         Change "nonzero" to "true" in documentation.
3871
3872 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3873
3874         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3875         (_initialize_darwin_solib): Don't set
3876         darwin_so_ops.lookup_lib_global_symbol.
3877         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3878         set_gdbarch_iterate_over_objfiles_in_search_order.
3879         (elf_lookup_lib_symbol): Rename to...
3880         (svr4_iterate_over_objfiles_in_search_order): this, and update
3881         to iterate semantics.
3882         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3883         * solib.c (solib_global_lookup): Remove.
3884         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3885         (solib_global_lookup): Remove.
3886         * symtab.c (lookup_global_or_static_symbol): Remove call to
3887         solib_global_lookup.
3888
3889 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3890
3891         * NEWS: Move entries about default MI version now being
3892         version 3, and about the GDB/MI fix for multi-location
3893         breakpoints to the "since GDB 8.3" section.
3894
3895 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3896
3897         GDB 8.3.1 released.
3898
3899 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3900
3901         * NEWS: Mention that Cell/B.E. debugging support was removed.
3902         * MAINTAINERS: Remove spu target.
3903
3904         * config/djgpp/fnchange.lst: Remove entries for removed files.
3905
3906         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3907         spu-multiarch.o, and spu-tdep.o.
3908         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3909         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3910         spu-multiarch.c, and spu-tdep.c.
3911         * spu-linux-nat.c: Remove file.
3912         * spu-multiarch.c: Remove file.
3913         * spu-tdep.c: Remove file.
3914         * spu-tdep.h: Remove file.
3915         * solib-spu.c: Remove file.
3916         * solib-spu.h: Remove file.
3917
3918         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3919         * configure.nat (spu-linux): Remove.
3920         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3921         solib-multiarch.o from gdb_target_obs.
3922         (spu*-*-*): Remove.
3923
3924         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3925         feature flag.
3926         (ppc_linux_no_features): Update.
3927         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3928         Cell/B.E. support.
3929         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3930         (tdesc_powerpc_cell64l): Likewise.
3931         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3932         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3933         Cell/B.E. support.
3934         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3935         Do not include "features/rs6000/powerpc-cell32l.c" or
3936         "features/rs6000/powerpc-cell64l.c".
3937         (ppc_linux_spu_section): Remove.
3938         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3939         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3940         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3941         (ppc_linux_spe_context_lookup): Remove.
3942         (ppc_linux_spe_context_inferior_created): Remove.
3943         (ppc_linux_spe_context_solib_loaded): Remove.
3944         (ppc_linux_spe_context_solib_unloaded): Remove.
3945         (ppc_linux_spe_context): Remove.
3946         (struct ppu2spu_cache): Remove.
3947         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3948         (struct ppu2spu_data): Remove.
3949         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3950         ppu2spu_unwind): Remove.
3951         (ppc_linux_init_abi): Remove Cell/B.E. support.
3952         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3953
3954         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3955         (rs6000/powerpc-cell64l-expedite): Likewise
3956         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3957         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3958         rs6000/powerpc-cell64l.xml.
3959         * features/rs6000/powerpc-cell32l.xml: Remove.
3960         * features/rs6000/powerpc-cell64l.xml: Likewise.
3961         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3962         * features/rs6000/powerpc-cell64l.c: Likewise.
3963         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3964         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3965         * regformats/reg-spu.dat: Remove.
3966
3967         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3968         * corelow.c (struct spuid_list): Remove.
3969         (add_to_spuid_list): Remove.
3970         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3971         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3972         (remote_protocol_features): Remove associated entries.
3973         (_initialize_remote): No longer initialize them.
3974         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3975         * linux-nat.c (SPUFS_MAGIC): Remove.
3976         (linux_proc_xfer_spu): Remove.
3977         (spu_enumerate_spu_ids): Remove.
3978         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3979         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3980         (linux_make_corefile_notes): No longer call it.
3981
3982         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3983         (cooked_write_test): Likewise.
3984
3985 2019-09-20  Tom Tromey  <tom@tromey.com>
3986
3987         * NEWS: Mention case-sensitivity of TUI commands.
3988         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3989         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3990         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3991
3992 2019-09-20  Tom Tromey  <tom@tromey.com>
3993
3994         * tui/tui-source.c (tui_source_window::set_contents): Use
3995         make_unique_xstrdup.
3996         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3997         make_unique_xstrdup.
3998
3999 2019-09-20  Tom Tromey  <tom@tromey.com>
4000
4001         * tui/tui-data.c: Remove separator comments.
4002         * tui/tui-layout.c: Remove separator comments.
4003         * tui/tui-win.c: Remove separator comments.
4004         * tui/tui-wingeneral.c: Remove separator comments.
4005
4006 2019-09-20  Tom Tromey  <tom@tromey.com>
4007
4008         * tui/tui.h (strcat_to_buf): Don't declare.
4009         * tui/tui.c (strcat_to_buf): Remove.
4010
4011 2019-09-20  Tom Tromey  <tom@tromey.com>
4012
4013         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4014         from "fullname".
4015         * tui/tui-source.c (tui_source_window::set_contents)
4016         (tui_source_window::location_matches_p)
4017         (tui_source_window::maybe_update): Update.
4018
4019 2019-09-20  Tom Tromey  <tom@tromey.com>
4020
4021         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4022         Update.
4023         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4024         prefix.
4025         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4026         (tui_data_window::line_from_reg_element_no)
4027         (tui_data_window::first_reg_element_no_inline)
4028         (tui_data_window::show_registers)
4029         (tui_data_window::show_register_group)
4030         (tui_data_window::display_registers_from)
4031         (tui_data_window::display_registers_from_line)
4032         (tui_data_window::first_data_item_displayed)
4033         (tui_data_window::delete_data_content_windows)
4034         (tui_data_window::erase_data_content)
4035         (tui_data_window::do_scroll_vertical)
4036         (tui_data_window::refresh_window)
4037         (tui_data_window::check_register_values): Update.
4038
4039 2019-09-20  Tom Tromey  <tom@tromey.com>
4040
4041         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4042         (struct tui_locator_window) <full_name, proc_name>: Now
4043         std::string.
4044         * tui/tui-stack.c (tui_locator_window::make_status_line)
4045         (tui_locator_window::set_locator_fullname)
4046         (tui_locator_window::set_locator_info): Update.
4047         * tui/tui-source.c (tui_source_window::set_contents)
4048         (tui_source_window::showing_source_p): Update.
4049
4050 2019-09-20  Tom Tromey  <tom@tromey.com>
4051
4052         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4053         Don't call tui_locator_win_info_ptr.
4054
4055 2019-09-20  Tom Tromey  <tom@tromey.com>
4056
4057         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4058
4059 2019-09-20  Tom Tromey  <tom@tromey.com>
4060
4061         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4062         height for locator.
4063         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4064         * tui/tui-layout.c (show_source_disasm_command, show_data)
4065         (show_source_or_disasm_and_command): Use 1 as height for locator.
4066
4067 2019-09-20  Tom Tromey  <tom@tromey.com>
4068
4069         * tui/tui.c (tui_enable): Update.
4070         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4071         Update.
4072         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4073         Update.
4074         * tui/tui-data.c (win_resized): Now bool.
4075         (tui_win_resized): Return bool.
4076         (tui_set_win_resized_to): Accept a bool.
4077
4078 2019-09-20  Tom Tromey  <tom@tromey.com>
4079
4080         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4081         Change type of "refresh_values_only".
4082         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4083         type of "refresh_values_only".
4084
4085 2019-09-20  Tom Tromey  <tom@tromey.com>
4086
4087         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4088         std::string.
4089         (tui_disassemble): Add "pos" parameter.
4090         (tui_disasm_window::set_contents): Simplify.
4091
4092 2019-09-20  Tom Tromey  <tom@tromey.com>
4093
4094         * tui/tui-winsource.h (struct tui_source_window_base)
4095         <show_source_content>: Now private.
4096         * tui/tui-winsource.c
4097         (tui_source_window_base::show_source_content): Don't handle empty
4098         content case.
4099
4100 2019-09-20  Tom Tromey  <tom@tromey.com>
4101
4102         * tui/tui-layout.c (show_source_disasm_command)
4103         (show_source_or_disasm_and_command): Don't call
4104         show_source_content.
4105
4106 2019-09-20  Tom Tromey  <tom@tromey.com>
4107
4108         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4109         Declare.
4110         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4111         from tui_make_status_line.
4112         (tui_locator_window::rerender): Update.
4113
4114 2019-09-20  Tom Tromey  <tom@tromey.com>
4115
4116         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4117         (tui_locator_window::rerender): Update.
4118
4119 2019-09-20  Tom Tromey  <tom@tromey.com>
4120
4121         * tui/tui-winsource.h (struct tui_source_window_base)
4122         <~tui_source_window_base>: Don't declare.
4123         <fullname>: Remove.
4124         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4125         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4126         member.
4127         * tui/tui-source.c (tui_source_window::set_contents): Update.
4128         (tui_source_window::location_matches_p)
4129         (tui_source_window::maybe_update): Update.
4130
4131 2019-09-20  Tom Tromey  <tom@tromey.com>
4132
4133         * tui/tui-winsource.h (~tui_source_element): Remove.
4134         (tui_source_element): Update.
4135         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4136         * tui/tui-winsource.c (tui_show_source_line): Update.
4137         * tui/tui-source.c (tui_source_window::set_contents): Update.
4138         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4139
4140 2019-09-20  Tom Tromey  <tom@tromey.com>
4141
4142         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4143         declare.
4144         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4145         tui_clear_source_windows_detail.
4146         * tui/tui-winsource.h (struct tui_source_window_base)
4147         <clear_detail>: Don't declare.
4148         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4149         Remove.
4150         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4151
4152 2019-09-20  Tom Tromey  <tromey@adacore.com>
4153
4154         PR ada/24919:
4155         * block.c (contained_in): Fix final return value.
4156
4157 2019-09-20  Alan Modra  <amodra@gmail.com>
4158
4159         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4160         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4161         (read_indirect_string_from_dwz): Use bfd accessor.
4162         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4163         * machoread.c (macho_symfile_read_all_oso): Likewise.
4164         * solib.c (solib_bfd_open): Likewise.
4165
4166 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4167
4168         * eval.c: Move declaration of overload_resolution to...
4169         * value.h: ...here.
4170
4171 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4172
4173         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4174         * arm-linux-tdep.c: Likewise.
4175         * arm-nbsd-nat.c: Likewise.
4176         * arm-tdep.h: Declare arm_apcs_32.
4177         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4178
4179 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4180
4181         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4182         * dwarf2read.h: Declare dwarf_always_disassemble.
4183
4184 2019-09-19  Tom de Vries  <tdevries@suse.de>
4185
4186         PR gdb/25009
4187         * source-cache.c (source_cache::ensure): Catch exception thrown during
4188         construction of the highlighter.
4189
4190 2019-09-18  Alan Modra  <amodra@gmail.com>
4191
4192         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4193         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4194         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4195         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4196         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4197         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4198         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4199         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4200         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4201         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4202         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4203         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4204         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4205         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4206         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4207         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4208         * mi/mi-interp.c: Update throughout for bfd section macro and
4209         function changes.
4210         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4211         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4212
4213 2019-09-18  Tom Tromey  <tom@tromey.com>
4214
4215         * NEWS: Add entry.
4216         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4217         call rl_initialize.
4218         (tui_enable): Do not call rl_initialize.
4219
4220 2019-09-18  Christian Groessler  <chris@groessler.org>
4221
4222         * alpha-linux-nat.c: Include gdbarch.h.
4223
4224 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4225
4226         * ui-file.c: Include cli/cli-style.h.
4227         (term_cli_styling): Remove cli_styling declaration.
4228
4229 2019-09-18  Alan Modra  <amodra@gmail.com>
4230
4231         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4232         to bfd_asymbol_section.
4233
4234 2019-09-18  Alan Modra  <amodra@gmail.com>
4235
4236         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4237         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4238         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4239
4240 2019-09-18  Alan Modra  <amodra@gmail.com>
4241
4242         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4243         * spu-linux-nat.c (spu_bfd_open): Likewise.
4244
4245 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4246
4247         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4248         to bool to match definition in dwarf2read.c.
4249
4250 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4251
4252         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4253         (print_signatures): Likewise.
4254         (trust_pad_over_xvs): Likewise.
4255         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4256         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4257         * arm-linux-nat.c (arm_apcs_32): Likewise.
4258         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4259         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4260         * arm-tdep.c (arm_debug): Likewise.
4261         (arm_apcs_32): Likewise.
4262         * auto-load.c (debug_auto_load): Likewise.
4263         (auto_load_gdb_scripts): Likewise.
4264         (global_auto_load): Likewise.
4265         (auto_load_local_gdbinit): Likewise.
4266         (auto_load_local_gdbinit_loaded): Likewise.
4267         * auto-load.h (global_auto_load): Likewise.
4268         (auto_load_local_gdbinit): Likewise.
4269         (auto_load_local_gdbinit_loaded): Likewise.
4270         * breakpoint.c (disconnected_dprintf): Likewise.
4271         (breakpoint_proceeded): Likewise.
4272         (automatic_hardware_breakpoints): Likewise.
4273         (always_inserted_mode): Likewise.
4274         (target_exact_watchpoints): Likewise.
4275         (_initialize_breakpoint): Update.
4276         * breakpoint.h (target_exact_watchpoints): Change to bool.
4277         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4278         * cli/cli-cmds.c (trace_commands): Likewise.
4279         * cli/cli-cmds.h (trace_commands): Likewise.
4280         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4281         to bool*.
4282         * cli/cli-logging.c (logging_overwrite): Change to bool.
4283         (logging_redirect): Likewise.
4284         (debug_redirect): Likewise.
4285         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4286         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4287         to bool.
4288         <boolean_option_def>: Update.
4289         (struct flag_option_def): Change default type of Context to bool
4290         from int.
4291         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4292         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4293         (get_setshow_command_value_string): Likewise.
4294         * cli/cli-style.c (cli_styling): Change to bool.
4295         (source_styling): Likewise.
4296         * cli/cli-style.h (source_styling): Likewise.
4297         (cli_styling): Likewise.
4298         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4299         to bool.
4300         * command.h (var_types): Update comment.
4301         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4302         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4303         bool.
4304         (debug_compile_cplus_scopes): Likewise.
4305         * compile/compile-internal.h (compile_debug): Likewise.
4306         * compile/compile.c (compile_debug): Likewise.
4307         (struct compile_options) <raw>: Likewise.
4308         * cp-support.c (catch_demangler_crashes): Likewise.
4309         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4310         (usr_cmd_cris_dwarf2_cfi): Likewise.
4311         * csky-tdep.c (csky_debug): Likewise.
4312         * darwin-nat.c (enable_mach_exceptions): Likewise.
4313         * dcache.c (dcache_enabled_p): Likewise.
4314         * defs.h (info_verbose): Likewise.
4315         * demangle.c (demangle): Likewise.
4316         (asm_demangle): Likewise.
4317         * dwarf-index-cache.c (debug_index_cache): Likewise.
4318         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4319         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4320         * dwarf2read.c (check_physname): Likewise.
4321         (use_deprecated_index_sections): Likewise.
4322         (dwarf_always_disassemble): Likewise.
4323         * eval.c (overload_resolution): Likewise.
4324         * event-top.c (set_editing_cmd_var): Likewise.
4325         (exec_done_display_p): Likewise.
4326         * event-top.h (set_editing_cmd_var): Likewise.
4327         (exec_done_display_p): Likewise.
4328         * exec.c (write_files): Likewise.
4329         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4330         (debug_fbsd_nat): Likewise.
4331         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4332         Likewise.
4333         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4334         <backtrace_past_entry> Likewise.
4335         * gdb-demangle.h (demangle): Likewise.
4336         (asm_demangle): Likewise.
4337         * gdb_bfd.c (bfd_sharing): Likewise.
4338         * gdbcore.h (write_files): Likewise.
4339         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4340         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4341         * gdbthread.h (print_thread_events): Likewise.
4342         * gdbtypes.c (opaque_type_resolution): Likewise.
4343         (strict_type_checking): Likewise.
4344         * gnu-nat.c (gnu_debug_flag): Likewise.
4345         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4346         * guile/scm-param.c (pascm_variable): Add boolval.
4347         (add_setshow_generic): Update.
4348         (pascm_param_value): Update.
4349         (pascm_set_param_value_x): Update.
4350         * hppa-tdep.c (hppa_debug): Change to bool..
4351         * infcall.c (may_call_functions_p): Likewise.
4352         (coerce_float_to_double_p): Likewise.
4353         (unwind_on_signal_p): Likewise.
4354         (unwind_on_terminating_exception_p): Likewise.
4355         * infcmd.c (startup_with_shell): Likewise.
4356         * inferior.c (print_inferior_events): Likewise.
4357         * inferior.h (startup_with_shell): Likewise.
4358         (print_inferior_events): Likewise.
4359         * infrun.c (step_stop_if_no_debug): Likewise.
4360         (detach_fork): Likewise.
4361         (debug_displaced): Likewise.
4362         (disable_randomization): Likewise.
4363         (non_stop): Likewise.
4364         (non_stop_1): Likewise.
4365         (observer_mode): Likewise.
4366         (observer_mode_1): Likewise.
4367         (set_observer_mode): Update.
4368         (sched_multi): Change to bool.
4369         * infrun.h (debug_displaced): Likewise.
4370         (sched_multi): Likewise.
4371         (step_stop_if_no_debug): Likewise.
4372         (non_stop): Likewise.
4373         (disable_randomization): Likewise.
4374         * linux-tdep.c (use_coredump_filter): Likewise.
4375         (dump_excluded_mappings): Likewise.
4376         * linux-thread-db.c (auto_load_thread_db): Likewise.
4377         (check_thread_db_on_load): Likewise.
4378         * main.c (captured_main_1): Update.
4379         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4380         xx2_opt, boolean_opt>: Change to bool.
4381         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4382         * maint.c (maintenance_profile_p): Likewise.
4383         (per_command_time): Likewise.
4384         (per_command_space): Likewise.
4385         (per_command_symtab): Likewise.
4386         * memattr.c (inaccessible_by_default): Likewise.
4387         * mi/mi-main.c (mi_async): Likewise.
4388         (mi_async_1): Likewise.
4389         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4390         * nat/fork-inferior.h (startup_with_shell): Likewise.
4391         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4392         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4393         * nios2-tdep.c (nios2_debug): Likewise.
4394         * or1k-tdep.c (or1k_debug): Likewise.
4395         * parse.c (parser_debug): Likewise.
4396         * parser-defs.h (parser_debug): Likewise.
4397         * printcmd.c (print_symbol_filename): Likewise.
4398         * proc-api.c (procfs_trace): Likewise.
4399         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4400         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4401         (set_parameter_value): Update.
4402         (add_setshow_generic): Update.
4403         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4404         to bool*.
4405         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4406         int*.
4407         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4408         * record-btrace.c (record_btrace_target::store_registers): Update.
4409         * record-full.c (record_full_memory_query): Change to bool.
4410         (record_full_stop_at_limit): Likewise.
4411         * record-full.h (record_full_memory_query): Likewise.
4412         * remote-notif.c (notif_debug): Likewise.
4413         * remote-notif.h (notif_debug): Likewise.
4414         * remote.c (use_range_stepping): Likewise.
4415         (interrupt_on_connect): Likewise.
4416         (remote_break): Likewise.
4417         * ser-tcp.c (tcp_auto_retry): Likewise.
4418         * ser-unix.c (serial_hwflow): Likewise.
4419         * skip.c (debug_skip): Likewise.
4420         * solib-aix.c (solib_aix_debug): Likewise.
4421         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4422         (spu_auto_flush_cache_p): Likewise.
4423         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4424         Likewise.
4425         (struct info_print_options) <quiet>: Likewise.
4426         * symfile-debug.c (debug_symfile): Likewise.
4427         * symfile.c (auto_solib_add): Likewise.
4428         (separate_debug_file_debug): Likewise.
4429         * symfile.h (auto_solib_add): Likewise.
4430         (separate_debug_file_debug): Likewise.
4431         * symtab.c (basenames_may_differ): Likewise.
4432         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4433         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4434         (struct info_types_options) <quiet>: Likewise.
4435         * symtab.h (demangle): Likewise.
4436         (basenames_may_differ): Likewise.
4437         * target-dcache.c (stack_cache_enabled_1): Likewise.
4438         (code_cache_enabled_1): Likewise.
4439         * target.c (trust_readonly): Likewise.
4440         (may_write_registers): Likewise.
4441         (may_write_memory): Likewise.
4442         (may_insert_breakpoints): Likewise.
4443         (may_insert_tracepoints): Likewise.
4444         (may_insert_fast_tracepoints): Likewise.
4445         (may_stop): Likewise.
4446         (auto_connect_native_target): Likewise.
4447         (target_stop_and_wait): Update.
4448         (target_async_permitted): Change to bool.
4449         (target_async_permitted_1): Likewise.
4450         (may_write_registers_1): Likewise.
4451         (may_write_memory_1): Likewise.
4452         (may_insert_breakpoints_1): Likewise.
4453         (may_insert_tracepoints_1): Likewise.
4454         (may_insert_fast_tracepoints_1): Likewise.
4455         (may_stop_1): Likewise.
4456         * target.h (target_async_permitted): Likewise.
4457         (may_write_registers): Likewise.
4458         (may_write_memory): Likewise.
4459         (may_insert_breakpoints): Likewise.
4460         (may_insert_tracepoints): Likewise.
4461         (may_insert_fast_tracepoints): Likewise.
4462         (may_stop): Likewise.
4463         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4464         (make_thread_apply_all_options_def_group): Change argument from int*
4465         to bool*.
4466         (thread_apply_all_command): Update.
4467         (print_thread_events): Change to bool.
4468         * top.c (confirm): Likewise.
4469         (command_editing_p): Likewise.
4470         (history_expansion_p): Likewise.
4471         (write_history_p): Likewise.
4472         (info_verbose): Likewise.
4473         * top.h (confirm): Likewise.
4474         (history_expansion_p): Likewise.
4475         * tracepoint.c (disconnected_tracing): Likewise.
4476         (circular_trace_buffer): Likewise.
4477         * typeprint.c (print_methods): Likewise.
4478         (print_typedefs): Likewise.
4479         * utils.c (debug_timestamp): Likewise.
4480         (sevenbit_strings): Likewise.
4481         (pagination_enabled): Likewise.
4482         * utils.h (sevenbit_strings): Likewise.
4483         (pagination_enabled): Likewise.
4484         * valops.c (overload_resolution): Likewise.
4485         * valprint.h (struct value_print_options) <prettyformat_arrays,
4486         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4487         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4488         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4489         Likewise.
4490         * windows-nat.c (new_console): Likewise.
4491         (cygwin_exceptions): Likewise.
4492         (new_group): Likewise.
4493         (debug_exec): Likewise.
4494         (debug_events): Likewise.
4495         (debug_memory): Likewise.
4496         (debug_exceptions): Likewise.
4497         (useshell): Likewise.
4498         * windows-tdep.c (maint_display_all_tib): Likewise.
4499         * xml-support.c (debug_xml): Likewise.
4500
4501 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4502
4503         * source.c (prepare_path_for_appending): New function.
4504         (openp): Make use of new function.
4505         (find_and_open_source): Search for the compilation directory and
4506         source file as a relative path beneath the directory search path.
4507
4508 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4509
4510         * source-cache.c (source_cache::get_line_charpos): Catch
4511         exceptions and return false, this matches the behaviour documented
4512         in the header file.
4513
4514 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4515
4516         * ada-tasks.c (info_task): Remove quoting of the task's name.
4517
4518 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4519
4520         * symfile.c (auto_solib_add): Replace comment with a reference
4521         to the header file.
4522
4523 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4524
4525         * NEWS: Mention that gdb can now be compiled with Python 3
4526         on Windows.
4527
4528 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4529
4530         * maint.c (maint_print_section_data::maint_print_section_data):
4531         Force use of 'float log10 (float)' by casting the argument to
4532         float.
4533
4534 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4535
4536         * maint.c: Add 'cmath' include.
4537         (struct maint_print_section_data): New structure.
4538         (print_section_index): New function.
4539         (print_bfd_section_info): Add header comment, small whitespace
4540         cleanup, and update to call new print_section_index function.
4541         (print_objfile_section_info): Likewise.
4542         (maint_obj_section_from_bfd_section): New function.
4543         (print_bfd_section_info_maybe_relocated): New function.
4544         (maintenance_info_sections): Add header comment, always use
4545         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4546
4547 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4548
4549         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4550         inner scope, add check that the objfile has psymtabs before
4551         checking psymtabs_addrmap.
4552         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4553
4554 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4555
4556         * NEWS: Announce that Ada task names are now shown at more places,
4557         and between quotes (except in info task output).
4558         * gdb/ada-tasks.c (task_to_str): New function.
4559         (display_current_task_id): Call task_to_str.
4560         (task_command_1): Likewise.
4561         (print_ada_task_info): In non-mi mode, Properly align headers and data
4562         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4563
4564 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4565
4566         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4567         prstatus.pr_lwp.pr_info instead of making it up.
4568
4569 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4570
4571         * auto-load.c (auto_load_expand_dir_vars): Update.
4572         * defs.h (gdb_datadir): Change to std::string.
4573         (python_libdir): Likewise.
4574         (relocate_gdb_directory): Change return type to std::string.
4575         * guile/guile.c (gdbscm_data_directory): Update.
4576         (initialize_scheme_side): Update.
4577         * jit.c (jit_reader_dir): Change to std::string.
4578         (jit_reader_load_command): Update.
4579         * main.c (gdb_datadir): Change to std::string.
4580         (python_libdir): Likewise.
4581         (set_gdb_data_directory): Update.
4582         (relocate_path): Change to return std::string.
4583         (relocate_gdb_directory): Change to return std::string.
4584         (relocate_gdbinit_path_maybe_in_datadir): Update.
4585         (captured_main_1): Update.
4586         * python/python.c (do_start_initialization): Update.
4587         * top.c (show_gdb_datadir): Update.
4588         * xml-syscall.c (xml_init_syscalls_info): Update.
4589         (init_syscalls_info): Update.
4590
4591 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4592
4593         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4594         out of get_init_files.
4595         (get_init_files): Update.
4596
4597 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4598
4599         * main.c (get_init_files): Change to use std::string.
4600         (captured_main_1): Update.
4601         (print_gdb_help): Update.
4602
4603 2019-09-11  Ali Tamur  <tamur@google.com>
4604
4605         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4606         implementation.
4607
4608 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4609
4610         * dbxread.c (read_dbx_symtab): Update.
4611         * dwarf2read.c (load_partial_dies): Update.
4612         * mdebugread.c (parse_partial_symbols): Update.
4613         (handle_psymbol_enumerators): Update.
4614         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4615         * psymtab.c (add_psymbol_to_bcache): Likewise.
4616         (add_psymbol_to_list): Likewise.
4617         * symtab.c (symbol_set_names): Likewise.
4618         * symtab.h (symbol_set_names): Likewise.
4619         * xcoffread.c (scan_xcoff_symtab): Update.
4620
4621 2019-09-11  Tom Tromey  <tom@tromey.com>
4622
4623         * symfile-mem.c (symbol_file_add_from_memory): Use
4624         bfd_set_filename.
4625         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4626         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4627
4628 2019-09-10  Tom Tromey  <tromey@adacore.com>
4629
4630         * dwarf-index-write.c (write_psymbols): Extend error message.
4631         (debug_names::insert): Add Ada code.
4632         (debug_names::write_psymbols): Remove Ada check.
4633         (debug_names) <m_string_obstack>: New member.
4634         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4635         (gdb_index_symbol_name_matcher::matches): Remove.
4636         (mapped_index_base::find_name_components_bounds): Add "lang"
4637         parameter.
4638         (mapped_index_base::build_name_components): Also split names
4639         according to Ada syntax.
4640         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4641         type of "match_callback".
4642         (check_match, check_find_bounds_finds)
4643         (dw2_expand_symtabs_matching): Update.
4644         (dw2_debug_names_iterator): Add new constructor.
4645         (dw2_debug_names_map_matching_symbols): New function.
4646         (dw2_debug_names_expand_symtabs_matching): Update.
4647         (dwarf2_debug_names_functions): Use
4648         dw2_debug_names_map_matching_symbols.
4649
4650 2019-09-10  Tom Tromey  <tromey@adacore.com>
4651
4652         * dwarf2read.c (dw2_get_file_names_reader): Add the
4653         CU's file name to the results.
4654
4655 2019-09-10  Tom Tromey  <tromey@adacore.com>
4656
4657         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4658         map_matching_symbols.  Update.
4659         * dwarf2read.c (dw2_map_matching_symbols): Update.
4660         * psymtab.c (match_partial_symbol): Change type; update.
4661         (psym_map_matching_symbols): Likewise.
4662         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4663         type; update.
4664         * symfile.h (struct quick_symbol_functions)
4665         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4666         Remove "match".
4667
4668 2019-09-10  Tom Tromey  <tromey@adacore.com>
4669
4670         * psymtab.c (map_block): Remove.
4671         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4672         * symtab.c (iterate_over_symbols_terminated): New function.
4673         * symtab.c (iterate_over_symbols_terminated): Declare.
4674
4675 2019-09-10  Tom Tromey  <tromey@adacore.com>
4676
4677         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4678         * language.h (struct language_defn) <la_iterate_over_symbols>:
4679         Return bool.
4680         * symtab.c (iterate_over_symbols): Return bool.
4681         * symtab.h (iterate_over_symbols): Return bool.
4682
4683 2019-09-10  Tom Tromey  <tromey@adacore.com>
4684
4685         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4686         (add_nonlocal_symbols): Update.
4687         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4688         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4689         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4690         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4691         Change type of "callback".  Remove "data".
4692
4693
4694 2019-09-09  Ali Tamur  <tamur@google.com>
4695
4696         * dwarf2read.c (comp_unit_head): Update comment.
4697         (dwarf2_dwo_name): New function declaration.
4698         (dwarf_unit_type_name): New function declaration.
4699         (read_comp_unit_head): Add support for new compilation units,
4700         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4701         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4702         (currently named as "signature") in their header. Also clarify error
4703         messages.
4704         (lookup_dwo_id): New function. Returns the dwo id of the given
4705         compile unit.
4706         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4707         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4708         functions.
4709         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4710         (dwarf2_dwo_name): Get the dwo name if present.
4711         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4712         purposes.
4713
4714 2019-09-09  Tom Tromey  <tom@tromey.com>
4715
4716         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4717
4718 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4719
4720         * python/python.c (do_start_initialization): Make progname_copy static,
4721         to avoid a leak report.
4722
4723 2019-09-08  Tom Tromey  <tom@tromey.com>
4724
4725         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4726
4727 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4728
4729         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4730         Change type to gdb::optional<block_enum>.
4731         (dw2_symtab_iter_init): Change block_index parameter type
4732         to gdb::optional<block_enum>.
4733         (dw2_lookup_symbol): Change block_index parameter
4734         type to block_enum.c
4735         (dw2_debug_names_lookup_symbol): Likewise.
4736         * psymtab.c (psym_lookup_symbol): Likewise.
4737         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4738         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4739         Likewise.
4740
4741 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4742
4743         * defs.h (relocate_gdb_directory): Change int to bool in
4744         signature and rename flag to relocatable.
4745         * main.c (relocate_path): Likewise.
4746         (relocate_gdb_directory): Likewise.
4747
4748 2019-09-06  Alan Modra  <amodra@gmail.com>
4749
4750         * coffread.c (coff_symfile_read): Constify filename variable.
4751         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4752         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4753         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4754         * solib.c (reload_shared_libraries_1): Likewise.
4755         * symfile.c (reread_symbols): Likewise.
4756         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4757         * solib-darwin.c (darwin_bfd_open): Likewise.
4758         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4759
4760 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4761
4762         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4763         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4764
4765 2019-09-03  Tom Tromey  <tromey@adacore.com>
4766
4767         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4768         types.
4769         (has_negatives): Unbias a range type bound.
4770         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4771         * gdbtypes.c (operator==): Handle new field.
4772         (create_range_type): Add "bias" parameter.
4773         (create_static_range_type, resolve_dynamic_range): Update.
4774         * gdbtypes.h (struct range_bounds) <bias>: New member.
4775         (create_range_type): Add bias parameter.
4776         * printcmd.c (print_scalar_formatted): Unbias range types.
4777         * value.c (unpack_long): Unbias range types.
4778         (pack_long): Bias range types.
4779
4780 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4781
4782         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4783         probe arguments.
4784
4785 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4786
4787         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4788         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4789         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4790         (compile_probe_arg): Likewise.
4791         * probe.h (get_argument_count): Likewise.
4792         * solib-svr4.c (solib_event_probe_action): Likewise.
4793         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4794
4795 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4796
4797         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4798         code to here...
4799         (svr4_create_solib_event_breakpoints): ...from here.
4800
4801 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4802
4803         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4804         suffix from warning message.
4805
4806 2019-08-30  Tom Tromey  <tom@tromey.com>
4807
4808         * tui/tui-winsource.h (struct tui_source_window_base)
4809         <refresh_all>: Don't declare.
4810         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4811         Remove.
4812         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4813         tui_show_locator_content.
4814         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4815         declare.
4816         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4817         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4818         declare.
4819
4820 2019-08-30  Tom Tromey  <tom@tromey.com>
4821
4822         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4823
4824 2019-08-30  Tom Tromey  <tom@tromey.com>
4825
4826         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4827         Remove unnecessary forward declarations.
4828
4829 2019-08-30  Tom Tromey  <tom@tromey.com>
4830
4831         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4832         rerender.
4833         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4834         tui_show_locator_content.
4835
4836 2019-08-30  Tom Tromey  <tom@tromey.com>
4837
4838         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4839         (tui_locator_window::rerender): Rewrite using body of previous
4840         tui_show_locator_content.
4841
4842 2019-08-30  Tom Tromey  <tom@tromey.com>
4843
4844         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4845         set_locator_fullname>: New methods.
4846         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4847         Rename from tui_set_locator_fullname.
4848         (tui_locator_window::set_locator_info): Rename from
4849         tui_set_locator_info.  Return bool.
4850         (tui_update_locator_fullname, tui_show_frame_info): Update.
4851
4852 2019-08-30  Tom Tromey  <tom@tromey.com>
4853
4854         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4855
4856 2019-08-30  Tom Tromey  <tom@tromey.com>
4857
4858         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4859         call touchwin.
4860
4861 2019-08-30  Tom Tromey  <tom@tromey.com>
4862
4863         * tui/tui-wingeneral.c (box_win): Assume win_info and
4864         win_info->handle cannot be NULL.
4865
4866 2019-08-30  Tom Tromey  <tom@tromey.com>
4867
4868         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4869         refresh_window>: Declare.
4870         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4871         resize.
4872         (tui_data_item_window::rerender): Rename from
4873         tui_display_register.
4874         (tui_data_item_window::refresh_window): New method.
4875         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4876         no-op.
4877
4878 2019-08-30  Tom Tromey  <tom@tromey.com>
4879
4880         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4881         regs_column_count, current_group>: Move later.  Now private.
4882         <get_current_group>: New method.
4883         * tui/tui-regs.c (tui_reg_command): Update.
4884         * tui/tui-layout.c (tui_set_layout): Update.
4885
4886 2019-08-30  Tom Tromey  <tom@tromey.com>
4887
4888         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4889         (tui_data_window::rerender): Don't call
4890         check_and_display_highlight_if_needed.
4891         (tui_data_window::refresh_all): Remove call to
4892         erase_data_content.
4893
4894 2019-08-30  Tom Tromey  <tom@tromey.com>
4895
4896         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4897         (tui_data_window::display_registers_from)
4898         (tui_data_window::display_reg_element_at_line)
4899         (tui_data_window::display_registers_from_line): Remove checks of
4900         "empty".
4901
4902 2019-08-30  Tom Tromey  <tom@tromey.com>
4903
4904         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4905         Don't declare.
4906         * tui/tui-regs.c (tui_data_window::show_registers): Call
4907         rerender.
4908         (tui_data_window::rerender): Rename from display_all_data.
4909         (tui_data_window::rerender): Remove old implementation.
4910
4911 2019-08-30  Tom Tromey  <tom@tromey.com>
4912
4913         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4914         text.
4915         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4916
4917 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4918             Sergio Durigan Junior  <sergiodj@redhat.com>
4919
4920         PR win32/24284
4921         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4922
4923 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4924
4925         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4926         when searching for types.
4927
4928 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4929
4930         * f-lang.c (f_language_defn): Use f_print_typedef.
4931         * f-lang.h (f_print_typedef): Declare.
4932         * f-typeprint.c (f_print_typedef): Define.
4933
4934 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4935
4936         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4937
4938 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4939
4940         * cli/cli-utils.c (info_print_options_defs): Delete.
4941         (make_info_print_options_def_group): Delete.
4942         (extract_info_print_options): Delete.
4943         (info_print_command_completer): Delete.
4944         (info_print_args_help): Add extra parameter, and optionally
4945         include text about -n flag.
4946         * cli/cli-utils.h (struct info_print_options): Delete.
4947         (extract_info_print_options): Delete declaration.
4948         (info_print_command_completer): Delete declaration.
4949         (info_print_args_help): Add extra parameter, extend header
4950         comment.
4951         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4952         search_symbols.
4953         * stack.c (struct info_print_options): New type.
4954         (info_print_options_defs): New file scoped variable.
4955         (make_info_print_options_def_group): New static function.
4956         (info_print_command_completer): New static function.
4957         (info_locals_command): Update to use new local functions.
4958         (info_args_command): Likewise.
4959         (_initialize_stack): Add extra parameter to calls to
4960         info_print_args_help.
4961         * symtab.c (search_symbols): Add extra parameter, use this to
4962         possibly excluse non-debug symbols.
4963         (symtab_symbol_info): Add extra parameter, which is passed on to
4964         search_symbols.
4965         (struct info_print_options): New type.
4966         (info_print_options_defs): New file scoped variable.
4967         (make_info_print_options_def_group): New static function.
4968         (info_print_command_completer): New static function.
4969         (info_variables_command): Update to use local functions, and pass
4970         extra parameter through to symtab_symbol_info.
4971         (info_functions_command): Likewise.
4972         (info_types_command): Pass additional argument through to
4973         symtab_symbol_info.
4974         (rbreak_command): Pass extra argument to search_symbols.
4975         (_initialize_symtab): Add extra arguments for calls to
4976         info_print_args_help, and update help text for 'info variables',
4977         'whereis', and 'info functions' commands.
4978         * symtab.h (search_symbols): Add extra argument to declaration.
4979         * NEWS: Mention new flags.
4980
4981 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4982
4983         * symtab.c (lookup_static_symbol): Call the new function (and move
4984         it down to be next to lookup_global_symbol).
4985         (struct global_sym_lookup_data): Add block_enum member and rename to...
4986         (struct global_or_static_sym_lookup_data): ...this.
4987         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4988         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4989         (lookup_symbol_global_or_static_iterator_cb): ...this.
4990         (lookup_global_or_static_symbol): New function.
4991         (lookup_global_symbol): Call new function.
4992
4993 2019-08-26  Tom de Vries  <tdevries@suse.de>
4994
4995         PR c++/24852
4996         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4997         when pc_probe.prob == NULL.
4998
4999 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5000
5001         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5002         variable symbol_linkage to symbol_linkage_.
5003
5004 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5005
5006         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5007         represent whether the symbol is static, dynamic, or we don't
5008         know.
5009
5010 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5011
5012         * gdb/rx-tdep.c (rx_register_names): New.
5013         (rx_register_name): Delete.
5014         (rx_psw_type): Delete.
5015         (rx_fpsw_type): Delete.
5016         (rx_register_type): Delete.
5017         (rx_gdbarch_init): Convert target-descriptions.
5018         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5019         * gdb/features/Makefile: Add rx.xml.
5020         * gdb/features/rx.xml: New.
5021         * gdb/features/rx.c: Generated.
5022         * gdb/NEWS: Mention target description support.
5023
5024 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5025
5026         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5027         *slot_ptr.
5028
5029 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5030
5031         * configure.ac: Don't check for 'dlfcn.h' (moved to
5032         gdbsupport/common.m4).
5033         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5034         'gdbsupport/'.
5035         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5036         * compile/compile-c-support.c: Include
5037         'gdbsupport/gdb-dlfcn.h'.
5038         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5039         * gdb-dlfcn.c: Move to...
5040         * gdbsupport/gdb-dlfcn.c: ... here.
5041         * gdb-dlfcn.h: Move to...
5042         * gdbsupport/gdb-dlfcn.h: ... here.
5043
5044 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5045
5046         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5047         the offset field signed.
5048
5049 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5050
5051         * python/lib/gdb/__init__.py (_execute_file): New function.
5052         * python/python.c (python_run_simple_file): Call gdb._execute_file
5053         on Windows.
5054
5055 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5056
5057         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5058         all uses as this was never set to anything but a zero value.
5059
5060 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5061
5062         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5063
5064 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5065
5066         * tui/tui-data.h (tui_gen_win_info): Add an =default
5067         move constructor, required by some GCC versions.
5068
5069 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5070
5071         * go32-nat.c (go32_sysinfo): Add hygon_p.
5072
5073 2019-08-20  Tom Tromey  <tom@tromey.com>
5074
5075         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5076         line_from_reg_element_no, first_reg_element_no_inline,
5077         display_all_data, delete_data_content_windows,
5078         erase_data_content>: Now private.
5079
5080 2019-08-20  Tom Tromey  <tom@tromey.com>
5081
5082         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5083         (tui_unhighlight_win, tui_highlight_win)
5084         (tui_win_info::make_window): Update.
5085         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5086
5087 2019-08-20  Tom Tromey  <tom@tromey.com>
5088
5089         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5090         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5091         (MAX_PID_WIDTH): Move to tui-stack.c.
5092         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5093         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5094         (MAX_PID_WIDTH): Move from tui-data.h.
5095
5096 2019-08-20  Tom Tromey  <tom@tromey.com>
5097
5098         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5099         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5100         (box_win): Update.
5101         (tui_gen_win_info::make_window): Rename from tui_make_window.
5102         (tui_win_info::make_window): New method.
5103         (tui_gen_win_info::make_visible): Update.
5104         * tui/tui-source.c (tui_source_window::set_contents): Update.
5105         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5106         (tui_data_window::display_registers_from): Update.
5107         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5108         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5109         Declare.
5110         <can_box>: Remove.
5111         <title>: Remove.
5112         (struct tui_win_info) <make_window>: Declare.
5113         <can_box>: Now virtual.
5114         <title>: New member.
5115         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5116         * tui/tui-command.c (tui_cmd_window::resize): Update.
5117
5118 2019-08-20  Tom Tromey  <tom@tromey.com>
5119
5120         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5121         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5122         (tui_data_window::check_register_values): Update.
5123
5124 2019-08-20  Tom Tromey  <tom@tromey.com>
5125
5126         * tui/tui-regs.h (struct tui_data_window): Use
5127         DISABLE_COPY_AND_ASSIGN.
5128         <regs_content>: Change type, removing unique_ptr.
5129         <tui_data_window>: Add move constructor.
5130         * tui/tui-regs.c (tui_data_window::show_registers)
5131         (tui_data_window::show_register_group)
5132         (tui_data_window::display_registers_from)
5133         (tui_data_window::display_registers_from)
5134         (tui_data_window::first_data_item_displayed)
5135         (tui_data_window::delete_data_content_windows)
5136         (tui_data_window::rerender, tui_data_window::refresh_window)
5137         (tui_data_window::check_register_values): Update.
5138
5139 2019-08-20  Tom Tromey  <tom@tromey.com>
5140
5141         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5142         show_register_group>: Declare.
5143         (tui_show_register_group): Don't declare.
5144         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5145         tui_show_registers.
5146         (tui_data_window::show_register_group): Rename from
5147         tui_show_register_group.
5148         (tui_data_window::check_register_values, tui_reg_command):
5149         Update.
5150         * tui/tui-layout.c (tui_set_layout): Update.
5151
5152 2019-08-20  Tom Tromey  <tom@tromey.com>
5153
5154         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5155         Declare.
5156         (tui_check_register_values): Don't declare.
5157         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5158         from tui_check_register_values.
5159         * tui/tui-hooks.c (tui_register_changed): Update.
5160
5161 2019-08-20  Tom Tromey  <tom@tromey.com>
5162
5163         * tui/tui-regs.c (tui_reg_layout): Move later.
5164         (tui_show_registers): Don't enable TUI mode or change layout.
5165
5166 2019-08-20  Tom Tromey  <tom@tromey.com>
5167
5168         * tui/tui-regs.h (struct tui_data_item_window)
5169         <~tui_data_item_window>: Remove.
5170         <content>: Now a unique_xmalloc_ptr.
5171         * tui/tui-regs.c (tui_register_format): Return a
5172         unique_xmalloc_ptr.
5173         (tui_get_register): Update.
5174         (~tui_data_item_window): Remove.
5175         (tui_data_window::display_registers_from, tui_display_register):
5176         Update.
5177         * tui/tui-io.h (tui_expand_tabs): Update.
5178         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5179         Remove "col" parameter.
5180
5181 2019-08-20  Tom Tromey  <tom@tromey.com>
5182
5183         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5184         field.
5185         * tui/tui-regs.c (~tui_data_item_window): Update.
5186
5187 2019-08-20  Tom Tromey  <tom@tromey.com>
5188
5189         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5190         earlier.
5191
5192 2019-08-20  Tom Tromey  <tom@tromey.com>
5193
5194         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5195
5196 2019-08-20  Tom Tromey  <tom@tromey.com>
5197
5198         * tui/tui-source.h (struct tui_source_window): Update.
5199         * tui/tui-regs.c (tui_show_registers): Update.
5200         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5201         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5202         (NO_REGS_STRING): Remove defines.
5203
5204 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5205
5206         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5207         unnecessary thread walk if remote doesn't support the packet.
5208
5209 2019-08-19  Tom Tromey  <tromey@adacore.com>
5210
5211         * python/py-value.c (value_has_field): Fix indentation.
5212
5213 2019-08-19  Tom Tromey  <tromey@adacore.com>
5214
5215         * printcmd.c (do_one_display, info_display_command): Update.
5216         * block.h (contained_in): Return bool.  Add allow_nested
5217         parameter.
5218         * block.c (contained_in): Return bool.  Add allow_nested
5219         parameter.
5220
5221 2019-08-19  Tom Tromey  <tom@tromey.com>
5222
5223         * configure: Rebuild.
5224         * configure.ac: Disallow the combination of -static-libstdc++ and
5225         source highlight.
5226         * source-cache.c (get_language_name): Handle rust.
5227         (source_cache::get_source_lines): Ignore highlighting exceptions.
5228
5229 2019-08-16  Tom Tromey  <tom@tromey.com>
5230
5231         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5232         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5233         (struct tui_source_window_base) <make_visible, refresh_window,
5234         resize>: Remove methods.
5235         <execution_info>: Remove field.
5236         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5237         (tui_show_source_line, tui_source_window_base)
5238         (~tui_source_window_base): Update.
5239         (tui_source_window_base::resize)
5240         (tui_source_window_base::make_visible)
5241         (tui_source_window_base::refresh_window): Remove.
5242         (tui_source_window_base::update_exec_info): Update.
5243         * tui/tui-source.c (tui_source_window::set_contents): Update.
5244         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5245
5246 2019-08-16  Tom Tromey  <tom@tromey.com>
5247
5248         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5249         deprecated_query_hook.
5250
5251 2019-08-16  Tom Tromey  <tom@tromey.com>
5252
5253         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5254         (tui_update_source_windows_with_line): Update.
5255         * tui/tui-source.h (struct tui_source_window)
5256         <show_symtab_source>: Declare.
5257         (tui_show_symtab_source): Don't declare.
5258         * tui/tui-source.c (tui_show_symtab_source): Rename from
5259         tui_show_symtab_source.
5260
5261 2019-08-16  Tom Tromey  <tom@tromey.com>
5262
5263         * tui/tui-winsource.h (struct tui_source_window_base)
5264         <set_contents>: Declare.
5265         * tui/tui-winsource.c
5266         (tui_source_window_base::update_source_window_as_is): Update.
5267         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5268         Declare.
5269         (tui_set_source_content): Don't declare.
5270         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5271         tui_set_source_content.
5272         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5273         Declare.
5274         (tui_set_disassem_content): Don't declare.
5275         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5276         tui_set_disassem_content.
5277
5278 2019-08-16  Tom Tromey  <tom@tromey.com>
5279
5280         * tui/tui-winsource.h (struct tui_source_window_base)
5281         <update_breakpoint_info>: Declare.
5282         (tui_update_breakpoint_info): Don't declare.
5283         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5284         (tui_update_all_breakpoint_info): Update.
5285         (tui_source_window_base::update_breakpoint_info): Rename from
5286         tui_update_breakpoint_info.
5287         (tui_source_window_base::update_exec_info): Update.
5288
5289 2019-08-16  Tom Tromey  <tom@tromey.com>
5290
5291         * tui/tui-winsource.h (struct tui_source_window_base)
5292         <update_source_window>: Declare.
5293         (tui_update_source_window): Don't declare.
5294         * tui/tui-winsource.c
5295         (tui_source_window_base::update_source_window): Rename from
5296         tui_update_source_window.
5297         (tui_source_window_base::rerender): Update.
5298         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5299         * tui/tui-disasm.c (tui_show_disassem)
5300         (tui_show_disassem_and_update_source)
5301         (tui_disasm_window::maybe_update): Update.
5302
5303 2019-08-16  Tom Tromey  <tom@tromey.com>
5304
5305         * tui/tui-winsource.h (struct tui_source_window_base)
5306         <update_source_window_as_is>: Declare.
5307         (tui_update_source_window_as_is): Don't declare.
5308         * tui/tui-winsource.c (tui_update_source_window): Update
5309         (tui_source_window_base::update_source_window_as_is): Rename from
5310         tui_update_source_window_as_is.
5311         (tui_source_window_base::refill): Update.
5312         * tui/tui-source.c (tui_show_symtab_source): Update.
5313         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5314         Update.
5315
5316 2019-08-16  Tom Tromey  <tom@tromey.com>
5317
5318         * tui/tui-winsource.h (tui_update_source_window)
5319         (tui_update_source_window_as_is): Remove "noerror" parameter.
5320         * tui/tui-winsource.c (tui_update_source_window)
5321         (tui_update_source_window_as_is): Remove "noerror" parameter.
5322         (tui_update_source_windows_with_addr)
5323         (tui_update_source_windows_with_line)
5324         (tui_source_window_base::rerender)
5325         (tui_source_window_base::refill): Update.
5326         * tui/tui-source.h (tui_set_source_content)
5327         (tui_show_symtab_source): Remove "noerror" parameter.
5328         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5329         parameter.
5330         (tui_show_symtab_source): Likewise.
5331         (tui_source_window::maybe_update): Update.
5332         * tui/tui-disasm.c (tui_show_disassem)
5333         (tui_show_disassem_and_update_source)
5334         (tui_disasm_window::do_scroll_vertical)
5335         (tui_disasm_window::maybe_update): Update.
5336
5337 2019-08-16  Tom Tromey  <tom@tromey.com>
5338
5339         * tui/tui.c (tui_is_window_visible): Update.
5340         * tui/tui-wingeneral.c (tui_make_window)
5341         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5342         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5343         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5344         (tui_set_win_height_command, parse_scrolling_args): Update.
5345         * tui/tui-source.c (tui_source_window::style_changed): Update.
5346         * tui/tui-regs.c (tui_show_registers)
5347         (tui_data_window::first_data_item_displayed)
5348         (tui_data_window::delete_data_content_windows)
5349         (tui_check_register_values, tui_reg_command): Update.
5350         * tui/tui-disasm.c (tui_show_disassem): Update.
5351         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5352         method.
5353         <is_visible>: Remove field.
5354         * tui/tui-data.c (tui_next_win, tui_prev_win)
5355         (tui_delete_invisible_windows): Update.
5356
5357 2019-08-16  Tom Tromey  <tom@tromey.com>
5358
5359         * tui/tui-winsource.h (struct tui_source_window_base)
5360         <m_has_locator>: Remove.
5361         * tui/tui-layout.c (show_source_disasm_command, show_data)
5362         (show_source_or_disasm_and_command): Update.
5363
5364 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5365
5366         * NEWS (Other MI changes): New subsection.
5367         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5368         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5369         * arch-utils.c (default_get_pc_address_flags): New function.
5370         * arch-utils.h (default_get_pc_address_flags): New declaration.
5371         * gdbarch.sh: Add get_pc_address_flags.
5372         * gdbarch.c: Regenerate.
5373         * gdbarch.h: Likewise.
5374         * stack.c (print_pc): New function.
5375         (print_frame_info) (print_frame): Call print_pc.
5376
5377 2019-08-16  Tom de Vries  <tdevries@suse.de>
5378
5379         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5380         print_objfile_section_info.
5381
5382 2019-08-15  Tom Tromey  <tom@tromey.com>
5383
5384         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5385         calling update_cmdwin_start_line.
5386         * tui/tui-winsource.h (struct tui_source_window_base)
5387         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5388         <rerender>: Declare.
5389         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5390         Call rerender.
5391         (tui_source_window_base::set_new_height): Remove.
5392         (tui_source_window_base::rerender): Rename from
5393         do_make_visible_with_new_height.
5394         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5395         resize method.
5396         (tui_win_info::make_invisible_and_set_new_height)
5397         (tui_win_info::make_visible_with_new_height): Remove.
5398         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5399         Declare.
5400         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5401         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5402         do_make_visible_with_new_height>: Don't declare.
5403         <rerender>: Declare.
5404         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5405         set_new_height.
5406         (tui_data_window::do_make_visible_with_new_height): Remove.
5407         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5408         call tui_show_locator_content.
5409         (tui_gen_win_info::resize): Call rerender.
5410         (show_source_or_disasm_and_command): Don't call
5411         tui_show_locator_content.
5412         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5413         method.
5414         (struct tui_win_info) <rerender>: Declare.
5415         <set_new_height, make_invisible_and_set_new_height,
5416         make_visible_with_new_height>: Don't declare.
5417         * tui/tui-data.c (tui_win_list::rerender): New method.
5418         * tui/tui-command.h (struct tui_cmd_window)
5419         <do_make_visible_with_new_height>: Don't declare.
5420         * tui/tui-command.c
5421         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5422
5423 2019-08-15  Tom Tromey  <tromey@adacore.com>
5424
5425         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5426         * ada-lang.c (ada_enum_name): Likewise.
5427
5428 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5429
5430         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5431         leading underscore.
5432         (GdbOutputErrorFile): Likewise.
5433         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5434         accordingly.
5435         (execute_unwinders): Rename to have a leading underscore.
5436         (auto_load_packages): Likewise.
5437         (global scope): Adjust call to auto_load_packages accordingly.
5438         (GdbSetPythonDirectory): Likewise.
5439         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5440         instead of execute_unwinders.
5441
5442 2019-08-15  Tom Tromey  <tom@tromey.com>
5443
5444         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5445         (show_data): Don't change window visibility.
5446         (tui_gen_win_info::resize): Remove special case for command
5447         window.  Use wresize, when available.
5448         (show_source_or_disasm_and_command): Don't change window
5449         visibility.
5450         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5451         <make_visible>: New method.
5452         * tui/tui-command.c (tui_cmd_window::resize): New method.
5453
5454 2019-08-15  Tom Tromey  <tom@tromey.com>
5455
5456         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5457         (struct tui_source_windows): New.
5458         * tui/tui-winsource.c (tui_display_main): Update.
5459         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5460         (new_height_ok, parse_scrolling_args): Update.
5461         * tui/tui-layout.c (show_layout, show_data): Update.
5462         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5463         (tui_add_to_source_windows): Don't declare.
5464         * tui/tui-data.c (source_windows, tui_source_windows)
5465         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5466
5467 2019-08-15  Tom Tromey  <tom@tromey.com>
5468
5469         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5470         Rename from reset.
5471         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5472         * tui/tui-layout.c (show_source_disasm_command, show_data):
5473         Update.
5474         (tui_gen_win_info::resize): Rename.
5475         (show_source_or_disasm_and_command): Update.
5476         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5477         reset.
5478
5479 2019-08-15  Tom Tromey  <tom@tromey.com>
5480
5481         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5482         * tui/tui-interp.c (tui_interp::init): Don't call
5483         tui_initialize_static_data.
5484         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5485
5486 2019-08-15  Tom Tromey  <tom@tromey.com>
5487
5488         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5489         examine tui_win_list.
5490
5491 2019-08-15  Tom Tromey  <tom@tromey.com>
5492
5493         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5494         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5495         tui_clear_source_content.
5496         (tui_clear_source_content): Remove.
5497         (tui_source_window_base::do_erase_source_content): Hoist call to
5498         content.clear().
5499         * tui/tui-stack.c (tui_show_frame_info): Don't call
5500         tui_clear_source_content.
5501
5502 2019-08-15  Tom Tromey  <tom@tromey.com>
5503
5504         * tui/tui-winsource.h (struct tui_source_window_base)
5505         <do_erase_source_content>: New method.
5506         <erase_source_content>: New method.
5507         (tui_erase_source_content): Don't declare.
5508         * tui/tui-winsource.c (tui_clear_source_content): Update.
5509         (tui_source_window_base::do_erase_source_content): Rename from
5510         tui_erase_source_content.
5511         (tui_source_window_base::show_source_content): Update.
5512         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5513         * tui/tui-source.h (struct tui_source_window)
5514         <erase_source_content>: New method.
5515         * tui/tui-disasm.h (struct tui_disasm_window)
5516         <erase_source_content>: New method.
5517
5518 2019-08-15  Tom Tromey  <tom@tromey.com>
5519
5520         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5521         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5522         constructor.
5523         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5524         * tui/tui-source.c (tui_set_source_content): Update.
5525         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5526
5527 2019-08-15  Tom Tromey  <tom@tromey.com>
5528
5529         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5530         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5531         tui-source.c.
5532         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5533         Declare.
5534         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5535         method.
5536         (tui_source_window::maybe_update): Update.
5537
5538 2019-08-15  Tom Tromey  <tom@tromey.com>
5539
5540         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5541         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5542         tui-disasm.c.
5543         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5544         Declare.
5545         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5546         method.
5547         (tui_disasm_window::maybe_update): Update.
5548
5549 2019-08-15  Tom Tromey  <tom@tromey.com>
5550
5551         * tui/tui-winsource.h (struct tui_source_window_base)
5552         <maybe_update>: Declare.
5553         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5554         method.
5555         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5556         Declare.
5557         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5558         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5559         Declare.
5560         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5561
5562 2019-08-15  Tom Tromey  <tom@tromey.com>
5563
5564         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5565
5566 2019-08-15  Tom Tromey  <tom@tromey.com>
5567
5568         * tui/tui-wingeneral.c: Include tui-stack.h.
5569         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5570         (struct tui_locator_window): Move from tui-data.h.
5571         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5572         (tui_initialize_static_data): Move from tui-data.c.
5573         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5574         (struct tui_locator_window): Move to tui-stack.c.
5575         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5576         (tui_initialize_static_data): Move to tui-stack.c.
5577
5578 2019-08-15  Tom Tromey  <tom@tromey.com>
5579
5580         * tui/tui-layout.c (show_source_disasm_command)
5581         (show_source_or_disasm_and_command): Use make_visible method, not
5582         tui_make_window.
5583         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5584         Remove.
5585
5586 2019-08-15  Tom Tromey  <tom@tromey.com>
5587
5588         * tui/tui-wingeneral.h (tui_make_window): Update.
5589         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5590         parameter.
5591         (tui_gen_win_info::make_visible): Update.
5592         * tui/tui-regs.c (tui_data_window::display_registers_from):
5593         Update.
5594         * tui/tui-layout.c (show_source_disasm_command)
5595         (show_source_or_disasm_and_command): Update.
5596         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5597         (enum tui_box): Remove.
5598         (struct tui_win_info) <can_box>: New method.
5599         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5600         method.
5601
5602 2019-08-15  Tom de Vries  <tdevries@suse.de>
5603
5604         * linux-nat-trad.c: Include gdbarch.h.
5605
5606 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5607
5608         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5609         register sizes.
5610
5611 2019-08-14  Tom Tromey  <tromey@adacore.com>
5612
5613         * darwin-nat.c: Include gdbarch.h.
5614         * darwin-nat-info.c: Include gdbarch.h.
5615
5616 2019-08-13  Tom Tromey  <tom@tromey.com>
5617
5618         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5619         Remove.
5620         * tui/tui-data.c (tui_initialize_static_data): Update.
5621
5622 2019-08-13  Tom Tromey  <tom@tromey.com>
5623
5624         * tui/tui-winsource.h (struct tui_exec_info_window)
5625         <~tui_exec_info_window, maybe_allocate_content, get_content,
5626         m_content>: Remove.
5627         (struct tui_source_window_base) <set_exec_info_content,
5628         show_exec_info_content>: Don't declare.
5629         * tui/tui-winsource.c
5630         (tui_exec_info_window::maybe_allocate_content): Remove.
5631         (tui_source_window_base::update_exec_info): Rename from
5632         set_exec_info_content.
5633         (tui_source_window_base::show_exec_info_content)
5634         (tui_source_window_base::update_exec_info): Remove.
5635
5636 2019-08-13  Tom Tromey  <tom@tromey.com>
5637
5638         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5639         declare.
5640         * tui/tui-winsource.c (tui_update_source_window_as_is)
5641         (tui_update_source_windows_with_addr, tui_erase_source_content):
5642         Update.
5643         (tui_clear_exec_info_content): Remove.
5644
5645 2019-08-13  Tom Tromey  <tom@tromey.com>
5646
5647         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5648         declare.
5649         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5650         call tui_erase_exec_info_content.
5651         (tui_clear_exec_info_content): Rename from
5652         tui_erase_exec_info_content.
5653         (tui_clear_exec_info_content): Delete.
5654
5655 2019-08-13  Tom Tromey  <tom@tromey.com>
5656
5657         * tui/tui-winsource.h (struct tui_source_window_base)
5658         <show_exec_info_content>: Declare.
5659         (tui_show_exec_info_content): Don't declare.
5660         * tui/tui-winsource.c
5661         (tui_source_window_base::show_exec_info_content): Rename from
5662         tui_show_exec_info_content.
5663         (tui_source_window_base::update_exec_info): Update.
5664
5665 2019-08-13  Tom Tromey  <tom@tromey.com>
5666
5667         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5668         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5669         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5670         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5671         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5672         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5673         ... here.
5674
5675 2019-08-13  Tom Tromey  <tom@tromey.com>
5676
5677         * tui/tui-winsource.h (struct tui_source_window_base)
5678         <update_exec_info>: Declare.
5679         (tui_update_exec_info): Don't declare.
5680         * tui/tui-winsource.c (tui_update_source_window_as_is)
5681         (tui_source_window_base::refresh_all)
5682         (tui_update_all_breakpoint_info): Update.
5683         (tui_source_window_base::update_exec_info): Rename from
5684         tui_update_exec_info.
5685         * tui/tui-stack.c (tui_show_frame_info): Update.
5686
5687 2019-08-13  Tom Tromey  <tom@tromey.com>
5688
5689         * tui/tui-winsource.h (struct tui_source_window_base)
5690         <set_exec_info_content>: Declare.
5691         (tui_set_exec_info_content): Don't declare.
5692         * tui/tui-winsource.c
5693         (tui_source_window_base::set_exec_info_content): Rename from
5694         tui_set_exec_info_content.
5695         (tui_update_exec_info): Update.
5696
5697 2019-08-13  Tom Tromey  <tom@tromey.com>
5698
5699         * tui/tui-winsource.h (struct tui_source_window_base)
5700         <show_source_content>: Declare.
5701         (tui_show_source_content): Don't declare.
5702         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5703         (tui_source_window_base::show_source_content): Rename from
5704         tui_show_source_content.
5705         (tui_source_window_base::refresh_all): Update.
5706         * tui/tui-layout.c (show_source_disasm_command)
5707         (show_source_or_disasm_and_command): Update.
5708
5709 2019-08-13  Tom Tromey  <tom@tromey.com>
5710
5711         * tui/tui-winsource.c (tui_erase_source_content)
5712         (tui_show_source_content, tui_source_window_base::refresh_all):
5713         Update.
5714         * tui/tui-wingeneral.h
5715         (tui_check_and_display_highlight_if_needed): Don't declare.
5716         * tui/tui-wingeneral.c
5717         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5718         check_and_display_highlight_if_needed.
5719         * tui/tui-win.c (tui_rehighlight_all)
5720         (tui_win_info::make_visible_with_new_height): Update.
5721         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5722         (tui_data_window::erase_data_content)
5723         (tui_data_window::display_all_data): Update.
5724         * tui/tui-data.h (struct tui_win_info)
5725         <check_and_display_highlight_if_needed>: Declare.
5726
5727 2019-08-13  Tom Tromey  <tom@tromey.com>
5728
5729         * tui/tui-win.c (tui_resize_all): Call
5730         tui_delete_invisible_windows.
5731         * tui/tui-layout.c (show_layout): Call
5732         tui_delete_invisible_windows.
5733         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5734         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5735
5736 2019-08-13  Tom Tromey  <tom@tromey.com>
5737
5738         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5739         tui_add_win_to_layout.
5740
5741 2019-08-13  Tom Tromey  <tom@tromey.com>
5742
5743         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5744         * tui/tui-layout.c (tui_default_win_height): Now static.
5745
5746 2019-08-13  Tom Tromey  <tom@tromey.com>
5747
5748         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5749         single switch.
5750         (show_source_disasm_command, show_source_or_disasm_and_command):
5751         Don't check current layout.
5752
5753 2019-08-13  Tom Tromey  <tom@tromey.com>
5754
5755         * tui/tui-wingeneral.c (make_all_visible): Remove.
5756         (tui_make_all_invisible): Simplify.
5757         * tui/tui-layout.c (tui_make_all_invisible): Move from
5758         tui-wingeneral.c; simplify.
5759         (show_layout): Hoist call to tui_make_all_invisible.
5760         (show_data): Don't call tui_make_all_invisible.
5761
5762 2019-08-13  Tom Tromey  <tom@tromey.com>
5763
5764         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5765         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5766
5767 2019-08-13  Tom Tromey  <tom@tromey.com>
5768
5769         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5770         tui-data.c.
5771         (show_source_disasm_command, show_data)
5772         (show_source_or_disasm_and_command): Don't use
5773         tui_set_current_layout_to.
5774         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5775         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5776         tui-layout.c.
5777         (tui_set_current_layout_to): Remove.
5778
5779 2019-08-13  Tom Tromey  <tom@tromey.com>
5780
5781         * tui/tui-layout.c (tui_set_layout): Update.
5782         * tui/tui-data.h (struct tui_layout_def): Remove.
5783         (tui_layout_def): Don't declare.
5784         * tui/tui-data.c (layout_def): Remove.
5785         (tui_layout_def): Remove.
5786
5787 2019-08-13  Tom Tromey  <tom@tromey.com>
5788
5789         * tui/tui-winsource.h (struct tui_source_window_base)
5790         <clear_detail>: No longer "override".
5791         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5792         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5793         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5794         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5795         Remove.
5796         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5797
5798 2019-08-13  Tom Tromey  <tromey@adacore.com>
5799
5800         * tracepoint.c: Don't include readline.h or history.h.
5801
5802 2019-08-12  Tom Tromey  <tom@tromey.com>
5803
5804         * configure: Rebuild.
5805         * configure.ac: Check for readline 7.
5806         * NEWS: Mention readline 7 requirement.
5807         * README: Update.
5808
5809 2019-08-12  Tom Tromey  <tom@tromey.com>
5810
5811         * mingw-hdep.c (gdb_select): Remove readline hack.
5812
5813 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5814
5815         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5816         when the function fails.
5817
5818 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5819
5820         * s390-tdep.c (s390_type_align): New function.
5821         (s390_gdbarch_init): Set it as type_align gdbarch method.
5822
5823 2019-08-09  Tom de Vries  <tdevries@suse.de>
5824
5825         PR gdb/24591
5826         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5827         pc_low with relocation offset.
5828
5829 2019-08-07  Tom Tromey  <tromey@adacore.com>
5830
5831         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5832         (print_frame_args): Update.
5833         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5834         Update.
5835         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5836         * frame.h (struct frame_arg): Add initializers.
5837         <error>: Now a unique_xmalloc_ptr.
5838
5839 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5840
5841         * NEWS: Expand the Pointer Authentication entry.
5842         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5843         (aarch64_frame_unmask_lr): ... to this.
5844         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5845         Call aarch64_frame_unmask_lr.
5846         * frame.c (struct frame_info): Add "masked" variable.
5847         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5848         (fprint_frame): Check for masked pc.
5849         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5850         declarations.
5851         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5852         * stack.c (print_frame): Check for masked pc.
5853
5854 2019-08-06  Tom Tromey  <tom@tromey.com>
5855
5856         * stabsread.c (patch_block_stabs, read_one_struct_field)
5857         (read_enum_type): Use obstack_strndup.
5858         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5859         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5860         * dwarf2read.c (guess_full_die_structure_name)
5861         (anonymous_struct_prefix): Use obstack_strndup.
5862         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5863         * c-exp.y (yylex): Use obstack_strndup.
5864         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5865         (write_var_or_type): Use obstack_strndup.
5866
5867 2019-08-06  Tom Tromey  <tom@tromey.com>
5868
5869         * symfile.c (reread_symbols): Use obstack_strdup.
5870         * stabsread.c (read_type): Use obstack_strdup.
5871         * gdb_obstack.h (obstack_strdup): New overload.
5872         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5873         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5874         (dwarf2_canonicalize_name): Use obstack_strdup.
5875         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5876         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5877         Use obstack_strdup.
5878
5879 2019-08-06  Tom Tromey  <tom@tromey.com>
5880
5881         * gdb_obstack.h (obstack_strdup): Define.
5882         * gdb_obstack.c (obstack_strdup): Don't define.
5883
5884 2019-08-06  Tom Tromey  <tom@tromey.com>
5885
5886         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5887         obstack_strdup.
5888         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5889         obstack_strdup.
5890         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5891         * stabsread.c (common_block_start): Use obstack_strdup.
5892         * objfiles.c (set_objfile_main_name, objfile): Use
5893         obstack_strdup.
5894         * namespace.c (add_using_directive): Use obstack_strdup.
5895         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5896         * jit.c (finalize_symtab): Use obstack_strdup.
5897         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5898         (guess_partial_die_structure_name, partial_die_info::fixup)
5899         (dwarf2_name): Use obstack_strdup.
5900         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5901         obstack_strdup.
5902         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5903         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5904         obstack_strdup.
5905         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5906
5907 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5908
5909         * unittests/help-doc-selftests.c: New file.
5910         * Makefile.in: Add the new file.
5911
5912 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5913
5914         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5915         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5916         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5917         the trailing '.' is not output, and the first character is uppercased.
5918         (print_help_for_command): Update call to print_doc_line.
5919         (print_doc_of_command): Likewise.
5920         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5921         * cli/cli-option.c (append_indented_doc): Do not append newline.
5922         (build_help_option): Append newline after first appended_indented_doc
5923         only if a second call is done.
5924         (build_help): Append 2 new lines before each option, except the first
5925         one.
5926         * compile/compile.c (_initialize_compile): Add new lines after
5927         %OPTIONS%, when not at the end of the help.
5928         Change help doc or code
5929         producing the help doc to respect the invariants.
5930         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5931         Also removed the new line after 'Options:', as all other commands
5932         do not put an empty line between 'Options:' and the first option.
5933         * printcmd.c (_initialize_printcmd): Likewise.
5934         * stack.c (_initialize_stack): Likewise.
5935         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5936         incorrectly telling COMMAND is optional.
5937         * ada-lang.c (_initialize_ada_language): Change help doc or code
5938         producing the help doc to respect the invariants.
5939         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5940         * breakpoint.c (_initialize_breakpoint): Likewise.
5941         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5942         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5943         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5944         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5945         _initialize_cli_style): Likewise.
5946         * corelow.c (core_target_info): Likewise.
5947         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5948         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5949         * filesystem.c (_initialize_filesystem): Likewise.
5950         * frame.c (_initialize_frame): Likewise.
5951         * gnu-nat.c (add_task_commands): Likewise.
5952         * infcall.c (_initialize_infcall): Likewise.
5953         * infcmd.c (_initialize_infcmd): Likewise.
5954         * interps.c (_initialize_interpreter): Likewise.
5955         * language.c (_initialize_language): Likewise.
5956         * linux-fork.c (_initialize_linux_fork): Likewise.
5957         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5958         * maint.c (_initialize_maint_cmds): Likewise.
5959         * memattr.c (_initialize_mem): Likewise.
5960         * printcmd.c (_initialize_printcmd): Likewise.
5961         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5962         _RegEx): Likewise.
5963         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5964         * record-btrace.c (_initialize_record_btrace): Likewise.
5965         * record-full.c (_initialize_record_full): Likewise.
5966         * record.c (_initialize_record): Likewise.
5967         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5968         * regcache.c (_initialize_regcache): Likewise.
5969         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5970         _initialize_remote): Likewise.
5971         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5972         * serial.c (_initialize_serial): Likewise.
5973         * skip.c (_initialize_step_skip): Likewise.
5974         * source.c (_initialize_source): Likewise.
5975         * stack.c (_initialize_stack): Likewise.
5976         * symfile.c (_initialize_symfile): Likewise.
5977         * symtab.c (_initialize_symtab): Likewise.
5978         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5979         * top.c (init_main): Likewise.
5980         * tracefile-tfile.c (tfile_target_info): Likewise.
5981         * tracepoint.c (_initialize_tracepoint): Likewise.
5982         * tui/tui-win.c (_initialize_tui_win): Likewise.
5983         * utils.c (add_internal_problem_command): Likewise.
5984         * valprint.c (value_print_option_defs): Likewise.
5985
5986 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5987
5988         PR build/24886
5989         * configure.ac: Drop enable-libmcheck support.
5990         * configure, config.in: Rebuild.
5991         * libmcheck.m4: Remove.
5992         * acinclude.m4: Don't include it.
5993         * Makefile.in: Don't distribute it.
5994         * top.c (print_gdb_configuration): Don't mention it.
5995
5996 2019-08-06  Tom Tromey  <tom@tromey.com>
5997
5998         * utils.c (set_output_style): Sometimes pass stream to
5999         emit_style_escape.
6000         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6001         * record-btrace.c (btrace_insn_history): Update.
6002         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6003         method.
6004         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6005         Update initializers.
6006         <m_uiout>: New field.
6007         <m_di>: Move lower.
6008         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6009         Remove "uiout" parameter.
6010         (dump_insns): Update.
6011         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6012         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6013
6014 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6015
6016         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6017         (error_in_psymtab_expansion): Likewise.
6018         (lookup_symbol_via_quick_fns): Likewise.
6019         (basic_lookup_transparent_type_quick): Likewise.
6020         (basic_lookup_transparent_type_1): Likewise.
6021
6022 2019-08-06  Tom Tromey  <tromey@adacore.com>
6023
6024         * source.c (last_source_error): Now bool.
6025         (print_source_lines_base): Make "noprint" bool.  Only open
6026         source file when last_source_visited changes.
6027
6028 2019-08-06  Tom Tromey  <tromey@adacore.com>
6029
6030         * annotate.c (annotate_source_line): Use g_source_cache.
6031         * source-cache.c (source_cache::get_plain_source_lines): Change
6032         parameters.  Populate m_offset_cache.
6033         (source_cache::ensure): New method.
6034         (source_cache::get_line_charpos): New method.
6035         (extract_lines): Move lower.  Change parameters.
6036         (source_cache::get_source_lines): Move lower.
6037         * source-cache.h (class source_cache): Update comment.
6038         <get_line_charpos>: New method.
6039         <get_source_lines>: Update comment.
6040         <clear>: Clear m_offset_cache.
6041         <get_plain_source_lines>: Change parameters.
6042         <ensure>: New method
6043         <m_offset_cache>: New member.
6044         * source.c (forget_cached_source_info_for_objfile): Update.
6045         (info_source_command): Use g_source_cache.
6046         (find_source_lines, open_source_file_with_line_charpos): Remove.
6047         (print_source_lines_base, search_command_helper): Use g_source_cache.
6048         * source.h (open_source_file_with_line_charpos): Don't declare.
6049         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6050         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6051         Use g_source_cache.
6052
6053 2019-08-06  Tom Tromey  <tromey@adacore.com>
6054
6055         * source-cache.c (source_cache::get_plain_source_lines):
6056         Remove "first_line" and "last_line" parameters.
6057         (source_cache::get_source_lines): Cache plain text.
6058         * source-cache.h (class source_cache)
6059         <get_plain_source_lines>: Update.
6060
6061 2019-08-06  Tom Tromey  <tromey@adacore.com>
6062
6063         * source-cache.c (extract_lines): No longer a method.
6064         Changed type of parameter.  Include final newline.
6065         (selftests::extract_lines_test): New function.
6066         (_initialize_source_cache): Likewise.
6067         * source-cache.h (class source_cache)
6068         <extract_lines>: Don't declare.
6069
6070 2019-08-06  Tom Tromey  <tromey@adacore.com>
6071
6072         * breakpoint.c (init_breakpoint_sal): Update.
6073         (breakpoint): Update.
6074         * breakpoint.h (struct breakpoint) <filter>: Now a
6075         unique_xmalloc_ptr.
6076
6077 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6078
6079         * NEWS: Mention dictionary access on blocks.
6080         * python/py-block.c (blpy_getitem): New function.
6081         (block_object_as_mapping): New struct.
6082         (block_object_type): Use new struct for tp_as_mapping field.
6083
6084 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6085
6086         * objfiles.h (objfile): Add a comment describing partial symbols.
6087
6088 2019-08-05  Tom Tromey  <tromey@adacore.com>
6089
6090         * compile/compile.c (_initialize_compile): Use _(), not N_().
6091         * thread.c (_initialize_thread): Use _(), not N_().
6092         * stack.c (_initialize_stack): Use _(), not N_().
6093         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6094
6095 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6096
6097         * dwarf2read.c (struct dw2_symtab_iterator):
6098         <want_specific_block>: Remove.
6099         <block_index>: Change type to gdb::optional.
6100         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6101         change type of BLOCK_INDEX parameter to gdb::optional.
6102         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6103         (dw2_lookup_symbol): Don't pass argument for
6104         WANT_SPECIFIC_BLOCK.
6105         (dw2_expand_symtabs_for_function): Don't pass argument for
6106         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6107         (class dw2_debug_names_iterator)
6108         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6109         parameter, change BLOCK_INDEX type to gdb::optional.
6110         <m_want_specific_block>: Remove.
6111         <m_block_index>: Change type to gdb::optional.
6112         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6113         gdb::optional.  Re-write in function of gdb::optional.
6114         (dw2_debug_names_lookup_symbol): Don't pass argument for
6115         WANT_SPECIFIC_BLOCK.
6116         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6117         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6118         BLOCK_INDEX.
6119
6120 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6121
6122         * NEWS: Mention changes to "info sources" command.
6123
6124 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6125
6126         * symtab.c (filename_partial_match_opts): New struct type.
6127         (struct output_source_filename_data): New members
6128         regexp, c_regexp, partial_match.
6129         (output_source_filename): Use new members to decide to print file.
6130         (info_sources_option_defs): New variable.
6131         (make_info_sources_options_def_group, print_info_sources_header,
6132         info_sources_command_completer):
6133         New functions.
6134         (info_sources_command): Read new optional arguments.
6135         (_initialize_symtab): Update info sources help.
6136
6137 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6138
6139         * ada-lang.c (exception_support_info_v0): Renamed from...
6140         (default_exception_support_info): ... this.  Create new
6141         definition for v1.
6142         (ada_has_this_exception_support): Look up catch_handlers_sym.
6143         (ada_exception_support_info_sniffer): Try v0 after default.
6144
6145 2019-08-01  Tom Tromey  <tromey@adacore.com>
6146
6147         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6148         gdbarch.h.
6149
6150 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6151
6152         * s12z-tdep.c: Fix include path for s12z-opc.h.
6153
6154 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6155
6156         * NEWS: Require GNU make 3.82.
6157
6158 2019-07-16  Tom Tromey  <tom@tromey.com>
6159
6160         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6161         declare.
6162
6163 2019-07-30  Tom Tromey  <tromey@adacore.com>
6164
6165         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6166
6167 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6168
6169         * printcmd.c (print_address_symbolic): Print negative offsets.
6170         (build_address_symbolic): Force signed arithmetic when computing
6171         offset.
6172
6173 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6174
6175         PR/24474: Add a function to lookup static variables.
6176         * NEWS: Mention this new function.
6177         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6178         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6179         * python/python.c (python_GdbMethods): Add new function.
6180
6181 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6182
6183         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6184         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6185         (objfpy_lookup_static_symbol): New function.
6186         (objfile_object_methods): Add new functions.
6187
6188 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6189
6190         * NEWS: Mention 'set|show print frame-info'.  Mention new
6191         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6192         backtrace argument.  Mention that python frame filtering code
6193         is now consistent with what 'backtrace' command prints.
6194
6195 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6196
6197         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6198         comments.
6199         (print_frame_info_auto, print_frame_info_source_line,
6200         print_frame_info_location, print_frame_info_source_and_location,
6201         print_frame_info_location_and_address, print_frame_info_short_location):
6202         New declarations.
6203         (struct frame_print_options): New member print_frame_info.
6204         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6205         * stack.h (get_user_print_what_frame_info): New declaration.
6206         (frame_show_address): New declaration.
6207         * stack.c (print_frame_arguments_choices): New value 'presence'.
6208         (print_frame_info_auto, print_frame_info_source_line,
6209         print_frame_info_location, print_frame_info_source_and_location,
6210         print_frame_info_location_and_address, print_frame_info_short_location,
6211         print_frame_info_choices, print_frame_info_print_what): New definitions.
6212         (print_frame_args): Only print dots for args if print frame-arguments
6213         is 'presence'.
6214         (frame_print_option_defs): New element for "frame-info".
6215         (get_user_print_what_frame_info): New function.
6216         (frame_show_address): Make non static.  Move comment to stack.h.
6217         (print_frame_info_to_print_what): New function.
6218         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6219         to decide what to print.
6220         (backtrace_command_1): Handle the new print_frame_arguments_presence
6221         value.
6222         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6223         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6224         (py_print_frame): In non-mi mode, use LOCATION as default for
6225         print_what, similarly to frame information printed directly by
6226         backtrace command. Handle frame-info user option in non MI mode.
6227
6228 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6229
6230         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6231         Add case for debugging 32-bit target on 64-bit host.  Revise
6232         comment.
6233
6234 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6235
6236         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6237         instead of find_function_entry_range_from_pc.
6238
6239 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6240
6241         * stack.c (find_frame_funname): Remove code which preferred
6242         minsym over symtab sym in "certain pathological cases".
6243
6244         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6245         parameter.  Change type of "do_demangle" to bool.
6246         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6247         Pass suitable "prefer_sym_over_minsym" flag to
6248         build_address_symbolic().  Don't output "+" for negative offsets.
6249         * printcmd.c (print_address_symbolic): Update invocation of
6250         build_address_symbolic to include a "prefer_sym_over_minsym"
6251         flag.
6252         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6253         Restrict cases in which use of minimal symbol is preferred to that
6254         of a found symbol.  Update comments.
6255
6256         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6257         for entry pc when entry pc is out of range for that FDE.
6258
6259 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6260
6261         PR gdb/24839:
6262         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6263         type.
6264
6265 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6266
6267         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6268         this function's Python signature.
6269
6270
6271 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6272
6273         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6274         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6275         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6276         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6277         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6278
6279
6280 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6281
6282         * h8300-tdep.c (h8300_register_name_common): New.
6283         h8300_register_name): Use h8300_register_name_common.
6284         (h8300s_register_name): Likewise.
6285         (h8300sx_register_name): Likewise.
6286         (h8300h_register_nam): New.
6287         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6288
6289
6290 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6291
6292         * arm-tdep.c (arm_skip_cmse_entry): New function.
6293         (arm_is_sgstubs_section): New function.
6294         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6295
6296 2019-07-22  Tom Tromey  <tom@tromey.com>
6297
6298         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6299         Don't self-assign.
6300
6301 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6302
6303         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6304         type_print.
6305
6306 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6307
6308         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6309         so that GDB doesn't match any msymbols when searching in the
6310         TYPES_DOMAIN.
6311         (print_symbol_info): Print using typedef_print or type_print based
6312         on the type of the symbol.  Add updated FIXME comment moved from...
6313         (_initialize_symtab): ... move and update FIXME comment to above.
6314
6315 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6316
6317         * NEWS: Mention adding -q option to "info types".
6318         * symtab.c (struct info_types_options): New struct.
6319         (info_types_options_defs): New variable.
6320         (make_info_types_options_def_group): New function.
6321         (info_types_command): Use gdb::option framework to parse options.
6322         (info_types_command_completer): New function.
6323         (_initialize_symtab): Extend the help text on "info types" and
6324         register command completer.
6325
6326 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6327
6328         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6329         (lookup_symbol_in_objfile): Change int to block_enum and add a
6330         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6331
6332 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6333
6334         * MAINTAINERS (Write After Approval): Add self.
6335
6336 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6337
6338         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6339         instruction to the dummy code region.
6340
6341 2019-07-19  Tom Tromey  <tromey@adacore.com>
6342
6343         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6344         (ARGSUSED, PARAMS, __func__): Remove rules.
6345
6346 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6347
6348         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6349         * features/arm/arm-with-iwmmxt.c: Remove.
6350         * features/arm/arm-with-iwmmxt.xml: Remove.
6351         * features/arm/arm-with-m-fpa-layout.c: Remove.
6352         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6353         * features/arm/arm-with-m-vfp-d16.c: Remove.
6354         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6355         * features/arm/arm-with-m.c: Remove.
6356         * features/arm/arm-with-m.xml: Remove.
6357         * features/arm/arm-with-neon.c: Remove.
6358         * features/arm/arm-with-neon.xml: Remove.
6359         * features/arm/arm-with-vfpv2.c: Remove.
6360         * features/arm/arm-with-vfpv2.xml: Remove.
6361         * features/arm/arm-with-vfpv3.c: Remove.
6362         * features/arm/arm-with-vfpv3.xml: Remove.
6363
6364 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6365
6366         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6367
6368 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6369
6370         * arch/aarch32.c (aarch32_create_target_description): Create
6371         target descriptions using features.
6372         * arch/arm.c (arm_create_target_description)
6373         (arm_create_mprofile_target_description): Likewise.
6374         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6375
6376 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6377
6378         * Makefile.in: Add new files.
6379         * aarch32-tdep.c: New file.
6380         * aarch32-tdep.h: New file.
6381         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6382         Call aarch32_read_description.
6383         * arch/aarch32.c: New file.
6384         * arch/aarch32.h: New file.
6385         * arch/arm.c (arm_create_target_description)
6386         (arm_create_mprofile_target_description): New function.
6387         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6388         (arm_create_target_description)
6389         (arm_create_mprofile_target_description): New declaration.
6390         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6391         read_description functions.
6392         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6393         Likewise.
6394         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6395         * arm-tdep.c (tdesc_arm_list): New variable.
6396         (arm_register_g_packet_guesses): Call create description functions.
6397         (arm_read_description) (arm_read_mprofile_description): New
6398         function.
6399         * arm-tdep.h (arm_read_description)
6400         (arm_read_mprofile_description): Add declaration.
6401         * configure.tgt: Add new files.
6402
6403 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6404
6405         * top.c (new_ui_command): Open specified terminal just once.
6406
6407 2019-07-18  Tom Tromey  <tromey@adacore.com>
6408
6409         * symtab.c (main_name): Constify return type.
6410         * symfile.c (set_initial_language): Update.
6411         * symtab.h (main_name): Constify return type.
6412
6413 2019-07-17  Tom Tromey  <tom@tromey.com>
6414
6415         * tui/tui-winsource.c (tui_update_source_window)
6416         (tui_update_source_window_as_is)
6417         (tui_update_source_windows_with_line): Remove return.
6418         * tui/tui-disasm.c (tui_show_disassem)
6419         (tui_show_disassem_and_update_source): Remove return.
6420         * tui/tui.c (tui_reset): Remove return.
6421         * tui/tui-wingeneral.c
6422         (tui_check_and_display_highlight_if_needed): Remove return.
6423
6424 2019-07-17  Tom Tromey  <tom@tromey.com>
6425
6426         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6427
6428 2019-07-17  Tom Tromey  <tom@tromey.com>
6429
6430         * tui/tui-winsource.h (struct tui_exec_info_window)
6431         (struct tui_source_window_base): Move from tui-data.h.
6432         * tui/tui-winsource.c: Move many method definitions from
6433         elsewhere.  Remove "structuring" comments.
6434         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6435         (tui_source_window_base::refresh_window): Move to
6436         tui-winsource.c.
6437         * tui/tui-win.c (tui_source_window_base::refresh_all)
6438         (tui_source_window_base::update_tab_width)
6439         (tui_source_window_base::set_new_height)
6440         (tui_source_window_base::do_make_visible_with_new_height): Move to
6441         tui-winsource.c.
6442         * tui/tui-source.h: Update.
6443         * tui/tui-source.c (tui_source_window_base::reset): Move to
6444         tui-winsource.c.
6445         * tui/tui-disasm.h: Update.
6446         * tui/tui-data.h (struct tui_exec_info_window): Move to
6447         tui-winsource.h.
6448         (struct tui_source_window_base): Likewise.
6449         * tui/tui-data.c (tui_source_window_base::clear_detail)
6450         (tui_source_window_base, ~tui_source_window_base): Move to
6451         tui-winsource.c.
6452
6453 2019-07-17  Tom Tromey  <tom@tromey.com>
6454
6455         * tui/tui-win.c (tui_resize_all)
6456         (tui_source_window_base::update_tab_width)
6457         (tui_adjust_win_heights): Update.
6458         (tui_win_info::make_invisible_and_set_new_height): Rename from
6459         make_invisible_and_set_new_height.
6460         * tui/tui-data.h (struct tui_win_info)
6461         <make_invisible_and_set_new_height>: New method.
6462
6463 2019-07-17  Tom Tromey  <tom@tromey.com>
6464
6465         * tui/tui.c: Update.
6466         * tui/tui-source.h (struct tui_source_window): Move from
6467         tui-data.h.
6468         * tui/tui-layout.c: Update.
6469         * tui/tui-disasm.c: Update.
6470         * tui/tui-data.h (struct tui_source_window): Move to
6471         tui-source.h.
6472
6473 2019-07-17  Tom Tromey  <tom@tromey.com>
6474
6475         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6476         tui-data.h.
6477         * tui/tui-data.h (struct tui_disasm_window): Move to
6478         tui-disasm.h.
6479
6480 2019-07-17  Tom Tromey  <tom@tromey.com>
6481
6482         * tui/tui-regs.h (struct tui_data_item_window): Move from
6483         tui-data.h.
6484         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6485         * tui/tui-data.h (struct tui_data_item_window): Move to
6486         tui-regs.h.
6487         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6488
6489 2019-07-17  Tom Tromey  <tom@tromey.com>
6490
6491         * tui/tui.c: Update.
6492         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6493         (tui_cmd_window::max_height): Move to tui-command.c.
6494         * tui/tui-layout.c: Update.
6495         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6496         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6497         tui-command.c.
6498         * tui/tui-command.h (struct tui_cmd_window): Move from
6499         tui-data.h.
6500         * tui/tui-command.c: Remove "structuring" comments.
6501         (tui_cmd_window::clear_detail)
6502         (tui_cmd_window::do_make_visible_with_new_height)
6503         (tui_cmd_window::max_height): Move from elsewhere.
6504
6505 2019-07-17  Tom Tromey  <tom@tromey.com>
6506
6507         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6508         Now static.
6509         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6510         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6511
6512 2019-07-17  Tom Tromey  <tom@tromey.com>
6513
6514         * tui/tui.c: Update.
6515         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6516         tui-regs.c.
6517         * tui/tui-windata.h: Remove file.
6518         * tui/tui-windata.c: Remove file.
6519         * tui/tui-win.c (tui_data_window::set_new_height)
6520         (tui_data_window::do_make_visible_with_new_height): Move to
6521         tui-regs.c.
6522         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6523         * tui/tui-regs.c: Remove "structuring" comments.
6524         (tui_data_window::first_data_item_displayed)
6525         (tui_data_window::delete_data_content_windows)
6526         (tui_data_window::erase_data_content)
6527         (tui_data_window::display_all_data)
6528         (tui_data_window::refresh_all)
6529         (tui_data_window::do_scroll_vertical)
6530         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6531         (tui_data_window::do_make_visible_with_new_height)
6532         (tui_data_window::refresh_window): Move from elsewhere.
6533         (_initialize_tui_regs): Move to end of file.
6534         * tui/tui-layout.c: Update.
6535         * tui/tui-hooks.c: Update.
6536         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6537         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6538         tui-regs.c.
6539         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6540
6541 2019-07-17  Tom Tromey  <tom@tromey.com>
6542
6543         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6544         seen.
6545
6546 2019-07-17  Tom Tromey  <tom@tromey.com>
6547
6548         * tui/tui-win.c (tui_source_window_base::set_new_height)
6549         (tui_source_window_base::do_make_visible_with_new_height): Use
6550         m_has_locator field directly.
6551         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6552         method.
6553         (struct tui_source_window_base) <has_locator>: Likewise.
6554
6555 2019-07-17  Tom Tromey  <tom@tromey.com>
6556
6557         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6558         Don't declare.
6559         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6560         Remove.
6561         * tui/tui-win.c (tui_source_window_base::set_new_height)
6562         (tui_source_window_base::set_new_height)
6563         (make_invisible_and_set_new_height)
6564         (tui_source_window_base::do_make_visible_with_new_height)
6565         (tui_source_window_base::do_make_visible_with_new_height):
6566         Update.
6567         * tui/tui-layout.c (show_source_disasm_command, show_data)
6568         (show_source_or_disasm_and_command): Update.
6569         * tui/tui-layout.c (show_layout): Update.
6570
6571 2019-07-17  Tom Tromey  <tom@tromey.com>
6572
6573         * tui/tui-layout.c (make_data_window): Remove.
6574         (show_data): Unify creation and re-initialization cases.
6575
6576 2019-07-17  Tom Tromey  <tom@tromey.com>
6577
6578         * tui/tui-layout.c (make_source_window, make_disasm_window):
6579         Remove.
6580         (show_data): Unify creation and re-initialization cases.
6581
6582 2019-07-17  Tom Tromey  <tom@tromey.com>
6583
6584         * tui/tui-layout.c (make_command_window): Remove.
6585         (show_source_disasm_command, show_source_or_disasm_and_command):
6586         Unify creation and re-initialization cases.
6587
6588 2019-07-17  Tom Tromey  <tom@tromey.com>
6589
6590         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6591         creation and re-initialization cases.
6592
6593 2019-07-17  Tom Tromey  <tom@tromey.com>
6594
6595         * tui/tui-regs.c (tui_get_register): Return void.
6596
6597 2019-07-17  Tom Tromey  <tom@tromey.com>
6598
6599         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6600         Simplify.
6601
6602 2019-07-17  Tom Tromey  <tom@tromey.com>
6603
6604         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6605         resetting.
6606
6607 2019-07-17  Tom Tromey  <tom@tromey.com>
6608
6609         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6610         * tui/tui-regs.c (tui_reg_layout): New function.
6611         (tui_show_registers, tui_reg_command): Use it.
6612         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6613         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6614         parameters.
6615         (tui_layout_command): Remove.
6616
6617 2019-07-17  Tom Tromey  <tom@tromey.com>
6618
6619         * tui/tui-layout.h (tui/tui-layout): Return void.
6620         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6621
6622 2019-07-17  Tom Tromey  <tom@tromey.com>
6623
6624         * tui/tui-layout.c (show_source_disasm_command, show_data):
6625         Update.
6626         (reset_locator): Remove.
6627         (show_source_or_disasm_and_command): Update.
6628
6629 2019-07-17  Tom Tromey  <tom@tromey.com>
6630
6631         * tui/tui-source.c (tui_source_window_base::reset): Remove
6632         win_type parameter.
6633         * tui/tui-layout.c (make_command_window, make_source_window)
6634         (make_disasm_window, make_data_window)
6635         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6636         (reset_locator, show_source_or_disasm_and_command): Update.
6637         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6638         win_type parameter.
6639         (struct tui_source_window_base) <reset>: Likewise.
6640
6641 2019-07-17  Tom Tromey  <tom@tromey.com>
6642
6643         * tui/tui-layout.c (show_source_disasm_command): Use
6644         reset_locator.
6645         (reset_locator): New function.
6646         (init_and_make_win): Remove.
6647         (show_source_or_disasm_and_command): Use reset_locator.
6648
6649 2019-07-17  Tom Tromey  <tom@tromey.com>
6650
6651         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6652         condition.
6653         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6654         Remove condition.
6655         * tui/tui-source.c (tui_source_window_base::reset): New method.
6656         * tui/tui-layout.c (make_command_window): Don't call
6657         init_and_make_win.
6658         (make_source_window, make_disasm_window): Don't call
6659         make_source_or_disasm_window.
6660         (make_data_window): Don't call init_and_make_win.  Change calling
6661         convention.
6662         (show_source_disasm_command, show_data): Simplify.
6663         (make_source_or_disasm_window): Remove.
6664         (show_source_or_disasm_and_command): Simplify.
6665         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6666         (struct tui_source_window_base) <reset>: Likewise.
6667         <execution_info>: Remove initializer.
6668         * tui/tui-data.c (tui_source_window_base): Initialize
6669         execution_info.
6670
6671 2019-07-17  Tom Tromey  <tom@tromey.com>
6672
6673         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6674         variable.
6675
6676 2019-07-17  Tom Tromey  <tom@tromey.com>
6677
6678         * tui/tui.c (tui_rl_other_window): Update.
6679         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6680         superclass method first.  Always iterate over regs_content.
6681         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6682         method.
6683         * tui/tui-win.c (tui_set_focus_command): Update.
6684
6685 2019-07-17  Tom Tromey  <tom@tromey.com>
6686
6687         * tui/tui-win.c (tui_set_focus_command): Rename from
6688         tui_set_focus.  Call tui_enable.
6689         (tui_set_focus_command): Remove.
6690
6691 2019-07-17  Tom Tromey  <tom@tromey.com>
6692
6693         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6694         refresh_window.
6695         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6696         touchwin.
6697         (tui_data_window::refresh_window): Call refresh_window on data
6698         items.  Always call superclass refresh_window.
6699         (tui_win_info::refresh): Remove.
6700         (tui_source_window_base::refresh_window): Update.
6701         (tui_refresh_all): Update.
6702         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6703         refresh_window.
6704         (show_source_or_disasm_and_command): Likewise.
6705         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6706         (struct tui_source_window_base) <refresh>: Likewise.
6707
6708 2019-07-17  Tom Tromey  <tom@tromey.com>
6709
6710         * tui/tui-winsource.c (tui_clear_source_content)
6711         (tui_show_source_content): Update.
6712         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6713         whether content is empty.
6714         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6715         Remove.
6716
6717 2019-07-17  Tom Tromey  <tom@tromey.com>
6718
6719         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6720         window's contents.
6721         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6722         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6723
6724 2019-07-17  Tom Tromey  <tom@tromey.com>
6725
6726         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6727         (struct tui_data_item_window): Update.
6728
6729 2019-07-17  Tom Tromey  <tom@tromey.com>
6730
6731         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6732         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6733         defines.
6734
6735 2019-07-17  Tom Tromey  <tom@tromey.com>
6736
6737         * tui/tui-winsource.h (tui_erase_source_content)
6738         (tui_clear_source_content): Remove "display_prompt" parameter.
6739         * tui/tui-winsource.c (tui_update_source_window_as_is)
6740         (tui_update_source_windows_with_addr): Update.
6741         (tui_clear_source_content): Remove "display_prompt" parameter.
6742         (tui_erase_source_content): Likewise.  Simplify.
6743         (tui_show_source_content): Update.
6744         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6745         * tui/tui-stack.c (tui_show_frame_info): Update.
6746         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6747         Remove defines.
6748
6749 2019-07-17  Tom Tromey  <tom@tromey.com>
6750
6751         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6752         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6753         parameter.
6754         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6755         parameter.
6756
6757 2019-07-17  Tom Tromey  <tom@tromey.com>
6758
6759         * tui/tui-winsource.c (tui_clear_source_content)
6760         (tui_show_source_content, tui_show_exec_info_content)
6761         (tui_clear_exec_info_content): Update.
6762         * tui/tui-stack.c (tui_show_locator_content): Update.
6763         (tui_show_frame_info): Update.
6764         * tui/tui-source.h (tui_source_window): Don't declare.
6765         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6766         from tui_source_is_displayed.
6767         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6768         Remove field.
6769         (struct tui_source_window_base) <content_in_use>: New field.  Now
6770         bool.
6771         (struct tui_source_window) <showing_source_p>: New method.
6772         (TUI_SRC_WIN): Change cast.
6773         * tui/tui-data.c (tui_initialize_static_data): Update.
6774
6775 2019-07-17  Tom Tromey  <tom@tromey.com>
6776
6777         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6778         location_matches_p.
6779         * tui/tui-source.c (tui_source_window::location_matches_p): New
6780         method.
6781         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6782         method.
6783         * tui/tui-data.h (struct tui_source_window_base)
6784         <location_matches_p>: New method.
6785         (struct tui_source_window, struct tui_disasm_window)
6786         <location_matches_p>: Likewise.
6787
6788 2019-07-17  Tom Tromey  <tom@tromey.com>
6789
6790         * tui/tui-win.c (tui_set_win_height_command): Rename from
6791         tui_set_win_height.
6792         (tui_set_win_height_command): Remove.
6793
6794 2019-07-17  Tom Tromey  <tom@tromey.com>
6795
6796         * tui/tui-source.c (tui_source_window): New constructor.  Add
6797         observer.
6798         (~tui_source_window): New destructor.
6799         (tui_source_window::style_changed): New method.
6800         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6801         (tui_attach_detach_observers): Update.
6802         * tui/tui-data.h (struct tui_source_window): Make constructor not
6803         inline.  Add destructor.
6804         (struct tui_source_window) <style_changed>: New method.
6805         <m_observable>: New member.
6806
6807 2019-07-17  Tom Tromey  <tom@tromey.com>
6808
6809         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6810         * tui/tui-win.c (tui_resize_all): Fix typo.
6811
6812 2019-07-17  Tom Tromey  <tom@tromey.com>
6813
6814         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6815         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6816         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6817         * tui/tui-win.c (window_name_completer): Use foreach.
6818         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6819         (update_tab_width): Likewise.
6820         * tui/tui-layout.c (show_layout): Update.
6821         * tui/tui-data.h (class tui_window_iterator): New.
6822         (struct all_tui_windows): New.
6823         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6824
6825 2019-07-17  Tom Tromey  <tom@tromey.com>
6826
6827         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6828         parameter.  Don't reference globals.
6829         (tui_reg_command): Update.
6830
6831 2019-07-17  Tom Tromey  <tom@tromey.com>
6832
6833         * tui/tui-regs.c (tui_show_registers): Simplify.
6834
6835 2019-07-17  Tom Tromey  <tom@tromey.com>
6836
6837         * tui/tui-regs.c (tui_show_registers): Update.
6838         (tui_show_register_group): Add win_info parameter.
6839
6840 2019-07-17  Tom Tromey  <tom@tromey.com>
6841
6842         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6843         Rename from tui_display_reg_element_at_line.
6844         (tui_data_window::display_registers_from_line): Update.
6845         * tui/tui-data.h (struct tui_data_window)
6846         <display_reg_element_at_line>: New method.
6847
6848 2019-07-17  Tom Tromey  <tom@tromey.com>
6849
6850         * tui/tui-regs.h (tui_display_registers_from)
6851         (tui_display_registers_from_line): Don't declare.
6852         * tui/tui-windata.c (tui_data_window::display_all_data)
6853         (tui_data_window::refresh_all)
6854         (tui_data_window::do_scroll_vertical): Update.
6855         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6856         from tui_display_registers_from.
6857         (tui_display_reg_element_at_line): Update.
6858         (tui_data_window::display_registers_from_line): Rename from
6859         tui_display_registers_from_line.
6860         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6861         display_registers_from_line>: New methods.
6862
6863 2019-07-17  Tom Tromey  <tom@tromey.com>
6864
6865         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6866         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6867         from tui_erase_data_content.
6868         (tui_data_window::display_all_data)
6869         (tui_data_window::refresh_all)
6870         (tui_data_window::do_scroll_vertical): Update.
6871         * tui/tui-regs.c (tui_show_registers): Update.
6872         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6873         New method.
6874
6875 2019-07-17  Tom Tromey  <tom@tromey.com>
6876
6877         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6878         declare.
6879         * tui/tui-windata.c
6880         (tui_data_window::delete_data_content_windows): Rename from
6881         tui_delete_data_content_windows.
6882         (tui_data_window::display_all_data)
6883         (tui_data_window::do_scroll_vertical): Update.
6884         * tui/tui-data.h (struct tui_data_window)
6885         <delete_data_content_windows>: New method.
6886
6887 2019-07-17  Tom Tromey  <tom@tromey.com>
6888
6889         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6890         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6891
6892 2019-07-17  Tom Tromey  <tom@tromey.com>
6893
6894         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6895         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6896         from tui_display_all_data.
6897         * tui/tui-win.c
6898         (tui_data_window::do_make_visible_with_new_height): Update.
6899         * tui/tui-regs.c (tui_show_registers): Update.
6900         * tui/tui-layout.c (tui_set_layout): Update.
6901         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6902         method.
6903
6904 2019-07-17  Tom Tromey  <tom@tromey.com>
6905
6906         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6907         * tui/tui-windata.c (tui_display_data_from): Remove.
6908         (tui_data_window::refresh_all): Update.
6909
6910 2019-07-17  Tom Tromey  <tom@tromey.com>
6911
6912         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6913         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6914         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6915         tui_display_registers_from_line.
6916         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6917         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6918         "force_display" parameter.
6919
6920 2019-07-17  Tom Tromey  <tom@tromey.com>
6921
6922         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6923         declare.
6924         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6925         Rename from tui_first_reg_element_no_inline.
6926         (tui_display_reg_element_at_line)
6927         (tui_display_registers_from_line): Update.
6928         * tui/tui-data.h (struct tui_data_window)
6929         <first_reg_element_no_inline>: New method.
6930
6931 2019-07-17  Tom Tromey  <tom@tromey.com>
6932
6933         * tui/tui-windata.c (tui_display_data_from)
6934         (tui_data_window::do_scroll_vertical): Update.
6935         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6936         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6937         Rename from tui_line_from_reg_element_no.
6938         (tui_display_registers_from_line): Update.
6939         * tui/tui-data.h (struct tui_data_window)
6940         <line_from_reg_element_no>: New method.
6941
6942 2019-07-17  Tom Tromey  <tom@tromey.com>
6943
6944         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6945         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6946         tui_last_regs_line_no.
6947         (tui_display_reg_element_at_line)
6948         (tui_display_registers_from_line): Update.
6949         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6950         method.
6951
6952 2019-07-17  Tom Tromey  <tom@tromey.com>
6953
6954         PR tui/24722:
6955         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6956         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6957         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6958         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6959         (tui_update_breakpoint_info): Likewise.
6960         * tui/tui-hooks.c (tui_event_create_breakpoint)
6961         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6962         Update.
6963
6964 2019-07-17  Tom Tromey  <tom@tromey.com>
6965
6966         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6967
6968 2019-07-17  Tom Tromey  <tom@tromey.com>
6969
6970         * tui/tui-winsource.c (tui_update_source_window_as_is)
6971         (tui_update_source_windows_with_addr): Update.
6972         * tui/tui-source.h (tui_set_source_content)
6973         (tui_show_symtab_source): Add "win_info" parameter.
6974         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6975         parameter.
6976         (tui_show_symtab_source): Likewise.
6977
6978 2019-07-17  Tom Tromey  <tom@tromey.com>
6979
6980         * tui/tui-wingeneral.c
6981         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6982
6983 2019-07-17  Tom Tromey  <tom@tromey.com>
6984
6985         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6986         (struct tui_cmd_window) <can_scroll>: New method.
6987         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6988         method.
6989
6990 2019-07-17  Tom Tromey  <tromey@adacore.com>
6991
6992         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6993         do_field_signed>: Rename.  Change type of "value".
6994         * ui-out.c (ui_out::field_signed): Rename from field_int.
6995         Change type of "value".
6996         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6997         type of "value".
6998         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6999         do_field_int.  Change type of "value".
7000         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7001         do_field_int.  Change type of "value".
7002         * tracepoint.c (trace_status_mi, tfind_1)
7003         (print_one_static_tracepoint_marker): Update.
7004         * thread.c (print_thread_info_1, print_selected_thread_frame):
7005         Update.
7006         * stack.c (print_frame, print_frame_info): Update.
7007         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7008         Update.
7009         * source.c (print_source_lines_base): Update.
7010         * skip.c (info_skip_command): Update.
7011         * record-btrace.c (btrace_ui_out_decode_error)
7012         (btrace_call_history_src_line): Update.
7013         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7014         Update.
7015         * progspace.c (print_program_space): Update.
7016         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7017         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7018         do_field_int.  Change type of "value".
7019         * mi/mi-out.c (mi_ui_out::do_table_begin)
7020         (mi_ui_out::do_table_header): Update.
7021         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7022         type of "value".
7023         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7024         (mi_cmd_data_list_changed_registers, output_register)
7025         (mi_cmd_data_read_memory, mi_load_progress)
7026         (mi_cmd_trace_frame_collected): Update.
7027         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7028         Update.
7029         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7030         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7031         (mi_cmd_var_list_children, varobj_update_one): Update.
7032         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7033         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7034         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7035         * inferior.c (print_inferior): Update.
7036         * gdb_bfd.c (print_one_bfd): Update.
7037         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7038         Update.
7039         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7040         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7041         do_field_int.  Change type of "value".
7042         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7043         do_field_int.  Change type of "value".
7044         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7045         (print_one_breakpoint_location, print_it_catch_fork)
7046         (print_one_catch_fork, print_it_catch_vfork)
7047         (print_one_catch_vfork, print_it_catch_solib)
7048         (print_it_catch_exec, print_it_ranged_breakpoint)
7049         (print_mention_watchpoint, print_mention_masked_watchpoint)
7050         (bkpt_print_it, update_static_tracepoint): Update.
7051         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7052         * break-catch-syscall.c (print_it_catch_syscall): Update.
7053         * ada-tasks.c (print_ada_task_info): Update.
7054         * ada-lang.c (print_it_exception, print_mention_exception):
7055         Update.
7056
7057 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7058
7059         PR breakpoints/24541
7060         * gdbarch.c: Regenerate.
7061         * gdbarch.h: Regenerate.
7062         * gdbarch.sh: Adjust return type and parameter types for
7063         'stap_adjust_register'.
7064         (i386_stap_adjust_register): Adjust signature and return new
7065         register name.
7066         * stap-probe.c (stap_parse_register_operand): Adjust use of
7067         'gdbarch_stap_adjust_register'.
7068
7069 2019-07-17  Tom Tromey  <tromey@adacore.com>
7070
7071         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7072         declare VEC.
7073         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7074         std::vector.
7075         (struct s390_process_info): Add initializers.
7076         (s390_add_process): Use new.
7077         (s390_linux_nat_target::low_forget_process): Use delete.
7078         (s390_linux_nat_target::low_new_fork)
7079         (s390_linux_nat_target::stopped_by_watchpoint)
7080         (s390_linux_nat_target::low_prepare_to_resume)
7081         (s390_linux_nat_target::insert_watchpoint)
7082         (s390_linux_nat_target::insert_hw_breakpoint)
7083         (s390_linux_nat_target::remove_watchpoint)
7084         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7085
7086 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7087
7088         * aarch64-fbsd-nat.c: Include regcache.h.
7089         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7090         argument.
7091         (aarch64_fbsd_nat_target::fetch_registers)
7092         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7093         variable.
7094         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7095
7096 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7097
7098         * fbsd-nat.c: Include gdbarch.h.
7099
7100 2019-07-15  Tom Tromey  <tromey@adacore.com>
7101
7102         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7103
7104 2019-07-15  Tom Tromey  <tromey@adacore.com>
7105
7106         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7107         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7108         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7109         * cli-out.c (cli_ui_out::do_field_int): New method.
7110         * ui-out.c (ui_out::field_unsigned): New method.
7111         * symfile.c (generic_load): Use field_unsigned.
7112         (print_transfer_performance): Likewise.
7113         * record-btrace.c (ui_out_field_uint): Remove.
7114         (btrace_call_history_insn_range, btrace_call_history): Use
7115         field_unsigned.
7116         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7117         field_unsigned.
7118         * ui-out.h (class ui_out) <field_unsigned>: New method.
7119         <do_field_unsigned>: Likewise.
7120
7121 2019-07-15  Tom Tromey  <tromey@adacore.com>
7122
7123         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7124         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7125         * target.c (flash_erase_command): Use field_string.
7126         * infrun.c (print_signal_received_reason): Use field_string.
7127         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7128         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7129         field_string.
7130         * ada-tasks.c (print_ada_task_info): Use field_string.
7131
7132 2019-07-15  Tom Tromey  <tromey@adacore.com>
7133
7134         * target.c (flash_erase_command): Use field_core_addr.
7135         * symfile.c (generic_load): Use field_core_addr.
7136         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7137         Use field_core_addr.
7138         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7139         field_core_addr.
7140
7141 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7142
7143         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7144         value if its desired type is smaller than a CORE_ADDR and signed.
7145
7146 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7147
7148         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7149         of changes to field names, and use new is_reference field to
7150         decide if a property is a reference or not.
7151         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7152         field.
7153         (struct dwarf2_property_baton): Update header comment, rename
7154         'referenced_type' to 'property_type' and update comments.
7155         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7156         default property type, store in property baton, update to take
7157         accound of renamed field.
7158         (read_func_scope): Update call to attr_to_dynamic_prop.
7159         (read_array_type): Likewise.
7160         (dwarf2_per_cu_addr_sized_int_type): New function.
7161         (read_subrange_index_type): Move type finding code to
7162         dwarf2_per_cu_addr_sized_int_type.
7163         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7164         (dwarf2_per_cu_addr_type): New function.
7165         (set_die_type): Update calls to attr_to_dynamic_prop.
7166
7167 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7168
7169         * dwarf2read.c (read_subrange_index_type): New function.
7170         (read_subrange_type): Move code into new function and call it.
7171         * gdbtypes.c (create_range_type): Add some asserts.
7172
7173 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7174
7175         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7176         update return statements.
7177         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7178         declaration, and update comment to match.
7179         * gdbtypes.c (resolve_dynamic_array): Update call to
7180         dwarf2_evaluate_property to match new return type.
7181
7182 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7183
7184         * valarith.c (value_subscripted_rvalue): Change lowerbound
7185         parameter type from int to LONGEST.
7186         * value.h (value_subscripted_rvalue): Likewise in declaration.
7187
7188 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7189
7190         * cli/cli-utils.c (info_print_command_completer): New function.
7191         * cli/cli-utils.h: Add 'completer.h' include, and forward
7192         declaration for 'struct cmd_list_element'.
7193         (info_print_command_completer): Declare.
7194         * stack.c (_initialize_stack): Add completer for 'info locals' and
7195         'info args'.
7196         * symtab.c (_initialize_symtab): Add completer for 'info
7197         variables' and 'info functions'.
7198         * NEWS: Mention completion for additional info commands.
7199
7200 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7201
7202         * cli/cli-utils.c (extract_info_print_args): Delete.
7203         (extract_arg_maybe_quoted): Delete.
7204         (info_print_options_defs): New variable.
7205         (make_info_print_options_def_group): New function.
7206         (extract_info_print_options): Define new function.
7207         * cli/cli-utils.h (extract_info_print_args): Delete.
7208         (struct info_print_options): New structure.
7209         (extract_info_print_options): Declare new function.
7210         * stack.c (info_locals_command): Update to use new
7211         extract_info_print_options, also add a header comment.
7212         (info_args_command): Likewise.
7213         * symtab.c (info_variables_command): Likewise.
7214         (info_functions_command): Likewise.
7215
7216 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7217
7218         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7219         to extract string arguments.
7220         * common/common-utils.c (extract_string_maybe_quoted): New function.
7221         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7222
7223 2019-07-11  Tom Tromey  <tromey@adacore.com>
7224
7225         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7226         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7227         * top.h (gdbinit): Don't declare.
7228         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7229         into...
7230         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7231         * top.c (gdb_init): Don't call init_cli_cmds.
7232         (gdbinit): Remove.
7233         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7234
7235 2019-07-11  Tom Tromey  <tromey@adacore.com>
7236
7237         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7238         after it has been moved.
7239
7240 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7241
7242         * valops.c (value_must_coerce_to_target): Change return type to
7243         bool.
7244         * value.h (value_must_coerce_to_target): Likewise.
7245
7246 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7247
7248         * breakpoint.c (is_hardware_watchpoint): Remove
7249         forward-declaration.
7250         (is_masked_watchpoint): Change return type to bool.
7251         (is_tracepoint): Likewise.
7252         (is_breakpoint): Likewise.
7253         (is_hardware_watchpoint): Likewise.
7254         (is_watchpoint): Likewise.
7255         (is_no_memory_software_watchpoint): Likewise.
7256         (is_catchpoint): Likewise.
7257         (breakpoint_1): Make FILTER parameter's return type bool.
7258         is_masked_watchpoint): Change return type to bool.
7259         (save_breakpoints): Make FILTER parameter's return type bool.
7260         * breakpoint.h (is_breakpoint): Change return type to bool.
7261         (is_watchpoint): Likewise.
7262         (is_catchpoint): Likewise.
7263         (is_tracepoint): Likewise.
7264
7265 2019-07-10  Tom Tromey  <tom@tromey.com>
7266
7267         * defs.h: Don't include gdbarch.h.
7268         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7269         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7270         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7271         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7272         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7273         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7274         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7275         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7276         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7277         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7278         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7279         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7280         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7281         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7282         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7283         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7284         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7285         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7286         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7287         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7288         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7289         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7290         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7291         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7292         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7293         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7294         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7295
7296 2019-07-10  Tom Tromey  <tromey@adacore.com>
7297
7298         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7299         * breakpoint.c (init_ada_exception_breakpoint): Register as
7300         bp_catchpoint.
7301         (print_one_breakpoint_location, print_one_breakpoint): Use
7302         is_ada_exception_catchpoint.
7303         * ada-lang.c (class ada_catchpoint_location): Pass
7304         bp_loc_software_breakpoint to bp_location constructor.
7305         (is_ada_exception_catchpoint): New function.
7306
7307 2019-07-10  Tom Tromey  <tromey@adacore.com>
7308
7309         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7310         VEC.
7311         (struct arm_exidx_entry): New method operator<.
7312         (struct arm_exidx_data) <section_maps>: Change type.
7313         (arm_exidx_data_free): Remove.
7314         (arm_exidx_data_key): Change type.  Move lower.
7315         (arm_exidx_new_objfile): Update.
7316         (arm_compare_exidx_entries): Remove.
7317         (arm_find_exidx_entry, _initialize_arm_tdep)
7318
7319 2019-07-10  Tom Tromey  <tromey@adacore.com>
7320
7321         * solib-spu.c (ocl_program_data_key): Change type.
7322         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7323         Update.
7324
7325 2019-07-10  Tom Tromey  <tromey@adacore.com>
7326
7327         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7328         (struct solib_aix_inferior_data) <library_list>: Change type.
7329         (solib_aix_inferior_data_handle): Change type.
7330         (get_solib_aix_inferior_data): Update.
7331         (solib_aix_free_library_list): Remove.
7332         (library_list_start_library): Update.
7333         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7334         return type.
7335         (solib_aix_get_library_list)
7336         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7337         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7338
7339 2019-07-10  Tom Tromey  <tromey@adacore.com>
7340
7341         * solib-dsbt.c (struct dsbt_info): Add initializers.
7342         (solib_dsbt_pspace_data): Change type.
7343         (dsbt_pspace_data_cleanup): Remove.
7344         (get_dsbt_info, _initialize_dsbt_solib): Update.
7345
7346 2019-07-10  Tom Tromey  <tromey@adacore.com>
7347
7348         * spu-tdep.c (spu_overlay_data): Change type.
7349         (spu_get_overlay_table, spu_overlay_new_objfile)
7350         (_initialize_spu_tdep): Update.
7351
7352 2019-07-10  Tom Tromey  <tromey@adacore.com>
7353
7354         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7355         destructor.
7356         (dbx_objfile_data_key): Change type and declare later.
7357         (DBX_SYMFILE_INFO): Rewrite.
7358         * dbxread.c (dbx_objfile_data_key): Change type.
7359         (dbx_symfile_init): Update.
7360         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7361         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7362         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7363
7364 2019-07-10  Tom Tromey  <tromey@adacore.com>
7365
7366         * jit.c (jit_program_space_key): Change type.  Move lower.
7367         (get_jit_program_space_data): Update.
7368         (jit_program_space_data_cleanup): Remove.
7369         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7370         Update.
7371         (struct jit_program_space_data): Add initializers.
7372
7373 2019-07-10  Tom Tromey  <tromey@adacore.com>
7374
7375         * solib-darwin.c (struct darwin_info): Add initializers.
7376         (solib_darwin_pspace_data): Change type.
7377         (darwin_pspace_data_cleanup): Remove.
7378         (get_darwin_info, _initialize_darwin_solib): Update.
7379
7380 2019-07-10  Tom Tromey  <tromey@adacore.com>
7381
7382         * remote-sim.c (struct sim_inferior_data): Add initializers,
7383         constructor, and destructor.
7384         (sim_inferior_data_key): Change type.  Move lower.
7385         (check_for_duplicate_sim_descriptor): Update.
7386         (get_sim_inferior_data): Use new.  Update.
7387         (~sim_inferior_data_cleanup): Rename from
7388         sim_inferior_data_cleanup.  Simplify.
7389         (gdbsim_close_inferior, simulator_command)
7390         (sim_command_completer, _initialize_remote_sim): Update.
7391         (next_pid, INITIAL_PID): Move earlier.
7392
7393 2019-07-10  Tom Tromey  <tromey@adacore.com>
7394
7395         * python/python-internal.h (create_thread_object): Return
7396         gdbpy_ref.
7397         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7398         * python/py-inferior.c (struct threadlist_entry): Add
7399         constructor.
7400         <thread_obj>: Now a gdbpy_ref.
7401         (thread_to_thread_object): Update.
7402         (add_thread_object): Use new.
7403         (delete_thread_object): Use delete.
7404         (infpy_threads): Update.
7405         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7406         GIL.
7407
7408 2019-07-10  Tom Tromey  <tromey@adacore.com>
7409
7410         * valops.c (value_cast): Specialize error message for Ada.
7411
7412 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7413
7414         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7415
7416 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7417
7418         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7419         bpstat_should_step): Return bool, adjust comments.
7420         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7421         bpstat_should_step): Likewise.
7422
7423 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7424
7425         * features/Makefile: Use feature target descriptions for Arm.
7426         * features/arm/arm-core.c: Generate new file.
7427         * features/arm/arm-fpa.c: Likewise.
7428         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7429         * features/arm/arm-m-profile.c: Likewise.
7430         * features/arm/arm-vfpv2.c: Likewise.
7431         * features/arm/arm-vfpv3.c: Likewise.
7432         * features/arm/xscale-iwmmxt.c: Likewise.
7433         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7434
7435 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7436
7437         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7438         ptrace earlier.
7439
7440 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7441
7442         * features/aarch64-pauth.c: Regenerate.
7443
7444 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7445
7446         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7447         bool.
7448         (bpstat_what): Use false instead of 0.
7449
7450 2019-07-09  Pedro Alves  <palves@redhat.com>
7451
7452         * break-catch-throw.c (is_exception_catchpoint): New.
7453         * breakpoint.c (print_one_breakpoint_location): New parameter
7454         'raw_loc'.  Handle it.  Use
7455         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7456         looking at the breakpoint's type.
7457         (print_one_breakpoint): If handling "maint info breakpoints", also
7458         print locations of exception catchpoints.
7459         * breakpoint.h (is_exception_catchpoint): Declare.
7460
7461 2019-07-09  Pedro Alves  <palves@redhat.com>
7462
7463         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7464         "addr" field.
7465         (allocate_location_exception_catchpoint): New.
7466         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7467         (initialize_throw_catchpoint_ops): Install
7468         allocate_location_exception_catchpoint as allocate_location
7469         method.
7470         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7471         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7472         bp_loc_other.
7473         (breakpoint_address_is_meaningful): Delete.
7474         (bl_address_is_meaningful): New.
7475         (breakpoint_locations_match): Adjust comment.
7476         (bp_location_from_bp_type): New, factored out of...
7477         (bp_location::bp_location(breakpoint *)): ... this.
7478         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7479         factored out of...
7480         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7481         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7482         breakpoint_address_is_meaningful.
7483         (bp_locations_compare): Adjust comment.
7484         (update_global_location_list): Use bl_address_is_meaningful
7485         instead of breakpoint_address_is_meaningful.
7486         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7487         explicit.
7488         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7489         * python/py-breakpoint.c (bppy_get_location): No longer check
7490         whether location is null.
7491
7492 2019-07-09  Pedro Alves  <palves@redhat.com>
7493
7494         PR c++/15468
7495         * breakpoint.c (print_one_breakpoint_location): Remove
7496         single-location assert.
7497
7498 2019-07-09  Tom Tromey  <tom@tromey.com>
7499
7500         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7501         * configure: Rebuild.
7502         * configure.ac: Change common to gdbsupport.
7503         * gdbsupport: Rename from common.
7504         * acinclude.m4: Change common to gdbsupport.
7505         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7506         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7507         gdbsupport.
7508         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7509         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7510         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7511         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7512         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7513         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7514         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7515         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7516         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7517         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7518         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7519         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7520         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7521         coff-pe-read.c, command.h, compile/compile-c-support.c,
7522         compile/compile-c.h, compile/compile-cplus-symbols.c,
7523         compile/compile-cplus-types.c, compile/compile-cplus.h,
7524         compile/compile-loc2c.c, compile/compile.c, completer.c,
7525         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7526         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7527         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7528         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7529         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7530         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7531         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7532         features/aarch64-core.c, features/aarch64-fpu.c,
7533         features/aarch64-pauth.c, features/aarch64-sve.c,
7534         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7535         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7536         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7537         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7538         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7539         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7540         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7541         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7542         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7543         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7544         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7545         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7546         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7547         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7548         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7549         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7550         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7551         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7552         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7553         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7554         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7555         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7556         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7557         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7558         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7559         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7560         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7561         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7562         minsyms.c, mips-linux-tdep.c, namespace.h,
7563         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7564         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7565         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7566         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7567         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7568         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7569         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7570         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7571         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7572         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7573         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7574         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7575         procfs.c, producer.c, progspace.h, psymtab.h,
7576         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7577         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7578         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7579         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7580         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7581         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7582         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7583         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7584         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7585         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7586         target-memory.c, target.c, target.h, target/waitstatus.c,
7587         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7588         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7589         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7590         unittests/array-view-selftests.c,
7591         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7592         unittests/common-utils-selftests.c,
7593         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7594         unittests/format_pieces-selftests.c,
7595         unittests/function-view-selftests.c,
7596         unittests/lookup_name_info-selftests.c,
7597         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7598         unittests/mkdir-recursive-selftests.c,
7599         unittests/observable-selftests.c,
7600         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7601         unittests/parse-connection-spec-selftests.c,
7602         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7603         unittests/scoped_fd-selftests.c,
7604         unittests/scoped_mmap-selftests.c,
7605         unittests/scoped_restore-selftests.c,
7606         unittests/string_view-selftests.c, unittests/style-selftests.c,
7607         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7608         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7609         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7610         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7611         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7612         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7613
7614 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7615
7616         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7617         bool value.
7618         (decode_digits_ordinary): Set explicit_line field in sal.
7619         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7620         symtab_and_line that was set on an explicit line number in
7621         assembler code.  Do always update the recorded symtab and line if
7622         we do skip the prologue.
7623
7624 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7625
7626         * breakpoint.c (set_breakpoint_location_function): Remove
7627         explicit_loc parameter.
7628         (momentary_breakpoint_from_master): Update call to
7629         set_breakpoint_location_function.
7630         (add_location_to_breakpoint): Likewise.
7631
7632 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7633
7634         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7635         required features based on default bfd type when no specific bfd
7636         is present.
7637
7638 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7639
7640         * NEWS: Mention that GDB printf and eval commands can now print
7641         C-style and Ada-style convenience var strings without
7642         calling the inferior.
7643         * printcmd.c (printf_c_string): Locally print GDB internal var
7644         instead of transiting via the inferior.
7645         (printf_wide_c_string): Likewise.
7646
7647 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7648
7649         PR breakpoints/25011
7650         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7651
7652 2019-07-04  Tom Tromey  <tom@tromey.com>
7653
7654         PR tui/24724:
7655         * tui/tui-winsource.c (tui_clear_source_content): Update.
7656         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7657         (tui_update_breakpoint_info): Update.
7658         (tui_set_exec_info_content): Update.
7659         * tui/tui-source.c (tui_set_source_content_nil): Update.
7660         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7661         has_break.
7662         * tui/tui-data.h (enum tui_bp_flag): New.
7663         (tui_bp_flags): New enum flags type.
7664         (struct tui_source_element) <break_mode>: Change type.  Rename
7665         from has_break.
7666         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7667         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7668         constants.
7669         * tui/tui-winsource.h: Fix comment.
7670
7671 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7672
7673         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7674         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7675         (store_fpregs_to_thread)
7676         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7677         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7678         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7679         (IWMMXT_REGS_SIZE): Add define.
7680         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7681         (fetch_vfp_regs, store_vfp_regs)
7682         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7683         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7684
7685 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7686
7687         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7688         defines.
7689         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7690         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7691         (ARM_INT_REGISTER_SIZE): ...to this.
7692         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7693         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7694         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7695         (arm_linux_collect_gregset, supply_nwfpe_register)
7696         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7697         defines.
7698         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7699         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7700         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7701         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7702         (arm_return_in_memory, arm_store_return_value)
7703         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7704         (arm_record_ld_st_multiple): Likewise.
7705         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7706         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7707
7708 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7709
7710         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7711         AARCH64_DISPLACED_MODIFIED_INSNS.
7712         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7713         (aarch64_displaced_step_copy_insn): Likewise.
7714         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7715         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7716         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7717         ARM_DISPLACED_MODIFIED_INSNS.
7718         * arm-tdep.c (arm_gdbarch_init): Likewise.
7719         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7720         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7721         (struct arm_displaced_step_closure): Use
7722         ARM_DISPLACED_MODIFIED_INSNS.
7723
7724 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7725
7726         * features/Makefile: Remove unused xml files.
7727         * features/aarch64.xml: Remove.
7728         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7729         * features/i386/amd64-avx-avx512.xml: Remove.
7730         * features/i386/amd64-avx-linux.xml: Remove.
7731         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7732         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7733         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7734         * features/i386/amd64-avx-mpx.xml: Remove.
7735         * features/i386/amd64-avx.xml: Remove.
7736         * features/i386/amd64-linux.xml: Remove.
7737         * features/i386/amd64-mpx-linux.xml: Remove.
7738         * features/i386/amd64-mpx.xml: Remove.
7739         * features/i386/amd64.xml: Remove.
7740         * features/i386/i386-avx-avx512-linux.xml: Remove.
7741         * features/i386/i386-avx-avx512.xml: Remove.
7742         * features/i386/i386-avx-linux.xml: Remove.
7743         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7744         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7745         * features/i386/i386-avx-mpx-linux.xml: Remove.
7746         * features/i386/i386-avx-mpx.xml: Remove.
7747         * features/i386/i386-avx.xml: Remove.
7748         * features/i386/i386-linux.xml: Remove.
7749         * features/i386/i386-mmx-linux.xml: Remove.
7750         * features/i386/i386-mmx.xml: Remove.
7751         * features/i386/i386-mpx-linux.xml: Remove.
7752         * features/i386/i386-mpx.xml: Remove.
7753         * features/i386/i386.xml: Remove.
7754         * features/i386/x32-avx-avx512-linux.xml: Remove.
7755         * features/i386/x32-avx-linux.xml: Remove.
7756         * features/i386/x32-linux.xml: Remove.
7757
7758 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7759
7760         * regformats/aarch64.dat: Remove.
7761         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7762         * regformats/i386/amd64-avx-linux.dat: Remove.
7763         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7764         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7765         * regformats/i386/amd64-linux.dat: Remove.
7766         * regformats/i386/amd64-mpx-linux.dat: Remove.
7767         * regformats/i386/amd64.dat: Remove.
7768         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7769         * regformats/i386/i386-avx-linux.dat: Remove.
7770         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7771         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7772         * regformats/i386/i386-linux.dat: Remove.
7773         * regformats/i386/i386-mmx-linux.dat: Remove.
7774         * regformats/i386/i386-mpx-linux.dat: Remove.
7775         * regformats/i386/i386.dat: Remove.
7776         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7777         * regformats/i386/x32-avx-linux.dat: Remove.
7778         * regformats/i386/x32-linux.dat: Remove.
7779
7780 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7781
7782         * aarch64-tdep.c: Remove xml self tests.
7783         * amd64-linux-tdep.c: Likewise.
7784         * amd64-tdep.c: Likewise.
7785         * i386-linux-tdep.c: Likewise.
7786         * i386-tdep.c: Likewise.
7787
7788 2019-07-03  Pedro Alves  <palves@redhat.com>
7789
7790         PR cli/24732
7791         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7792         (pipe_cmd_option_defs): New.
7793         (make_pipe_cmd_options_def_group): New.
7794         (pipe_command): Use gdb::option::process_options.
7795         (pipe_command_completer): New function.
7796         (_initialize_cli_cmds): Install completer for "pipe" command.
7797
7798 2019-07-03  Pedro Alves  <palves@redhat.com>
7799
7800         * cli/cli-option.c (union option_value) <string>: New field.
7801         (struct option_def_and_value): Add ctor, move ctor, dtor and
7802         use DISABLE_COPY_AND_ASSIGN.
7803         (option_def_and_value::clear_value): New.
7804         (parse_option, save_option_value_in_ctx, get_val_type_str)
7805         (add_setshow_cmds_for_options): Handle var_string.
7806         * cli-option.h (union option_def::var_address) <string>: New
7807         field.
7808         (struct string_option_def): New.
7809         * maint-test-options.c (struct test_options_opts): Add default
7810         ctor and use DISABLE_COPY_AND_ASSIGN.
7811         <string_opt>: New field.
7812         (test_options_opts::~test_options_opts): New.
7813         (test_options_opts::dump): Also dump "-string".
7814         (test_options_option_defs): Install "string.
7815
7816 2019-07-03  Pedro Alves  <palves@redhat.com>
7817
7818         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7819         option_value with a null enumeration.
7820         (complete_options): Save the option values in the context.
7821         (save_option_value_in_ctx): New, factored out from ...
7822         (process_options): ... here.
7823         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7824         of the function.
7825         * maint-test-options.c (test_options_opts::dump): New, factored
7826         out from ...
7827         (maintenance_test_options_command_mode): ... here.
7828         (maintenance_test_options_command_completion_result): Delete.
7829         (maintenance_test_options_command_completion_text): Update
7830         comment.
7831         (maintenance_show_test_options_completion_result): Change
7832         prototype.  Just print
7833         maintenance_test_options_command_completion_text.
7834         (save_completion_result): New.
7835         (maintenance_test_options_completer_mode): Pass options context to
7836         complete_options, and then save a dump.
7837         (_initialize_maint_test_options): Use add_cmd to install "maint
7838         show test-options-completion-result".
7839
7840 2019-07-03  Pedro Alves  <palves@redhat.com>
7841
7842         * NEWS (New commands): Mention "with" and "maint with".
7843         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7844         (with_command, with_command_completer): New.
7845         (pipe_command): Adjust to new repeat_previous
7846         interface.
7847         (_initialize_cli_cmds): Install the "with" command and its "w"
7848         alias.
7849         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7850         declarations.
7851         * cli/cli-setshow.c (parse_cli_var_uinteger)
7852         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7853         argument strings for all var_types.
7854         (get_setshow_command_value_string): New, factored out from ...
7855         (do_show_command): ... this.
7856         * cli/cli-setshow.h: Include <string>.
7857         (get_setshow_command_value_string): Declare.
7858         * command.h (repeat_previous): Now returns const char *.  Adjust
7859         comment.
7860         * maint.c: Include "cli/cli-cmds.h".
7861         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7862         (_initialize_maint_cmds): Register the "maintenance with" command.
7863         * top.c (repeat_previous): Move bits from pipe_command here:
7864         Return the saved command line, if any; error out if there's no
7865         command to relaunch.
7866
7867 2019-07-03  Pedro Alves  <palves@redhat.com>
7868
7869         * NEWS (New commands): Mention "maint set/show test-settings"
7870         instead of "maint test-settings".
7871         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7872         (maintenance_test_settings_set_list): Rename to ...
7873         (maintenance_set_test_settings_list): ... this.
7874         (maintenance_test_settings_show_list): Rename to  ...
7875         (maintenance_show_test_settings_list): ... this.
7876         (maintenance_test_settings_cmd): Delete.
7877         (maintenance_test_settings_set_cmd): ...
7878         (maintenance_set_test_settings_cmd): ... this.
7879         (maintenance_test_settings_show_cmd): ...
7880         (maintenance_show_test_settings_cmd): ... this.
7881         (maintenance_test_settings_show_value_cmd):
7882         (maintenance_show_test_settings_value_cmd): ... this.
7883         (_initialize_maint_test_settings): No longer install the "maint
7884         test-settings" prefix command.  Rename "maint test-settings set"
7885         to "maint set test-settings", and "maint test-settings show" to
7886         "maint show test-settings".  Adjust all subcommands.
7887
7888 2019-07-03  Pedro Alves  <palves@redhat.com>
7889
7890         * maint-test-settings.c: Fix file's intro comment.  Replace all
7891         references to "test-options" with references to "test-settings",
7892         in comments.
7893
7894 2019-07-03  Pedro Alves  <palves@redhat.com>
7895
7896         * maint-test-settings.c (maintenance_test_settings_xxx)
7897         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7898         New.
7899         (maintenance_test_settings_enums): Use them.
7900         (maintenance_test_settings_enum): Default to
7901         maintenance_test_settings_xxx.
7902         (_initialize_maint_test_settings): Initialize
7903         MAINTENANCE_TEST_SETTINGS_FILENAME.
7904
7905 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7906
7907         * breakpoint.h (remove_breakpoints_inf): Change return type to
7908         void, move function documentation here.
7909         * breakpoint.c (remove_breakpoints_inf): Change return type to
7910         void, move function documentation to header.
7911
7912 2019-07-02  Pedro Alves  <palves@redhat.com>
7913
7914         * NEWS (Completion improvements): Mention "info threads".
7915         * thread.c (struct info_threads_opts, info_threads_option_defs)
7916         (make_info_threads_options_def_group): New.
7917         (info_threads_command): Use gdb::option::process_options.
7918         (info_threads_command_completer): New.
7919         (_initialize_thread): Use gdb::option::build_help to build the
7920         help text for "info threads".
7921
7922 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7923
7924         * defs.h (generic_load): Move from here...
7925         * symfile.h (generic_load): ... to here.  Rename name parameter
7926         to args.
7927         * symfile.c (generic_load): Add comment.
7928
7929 2019-07-01  Tom Tromey  <tromey@adacore.com>
7930
7931         * dwarf2read.c
7932         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7933         declaration of without_params.  Fix formatting.
7934
7935 2019-07-01  Tom Tromey  <tromey@adacore.com>
7936
7937         * ada-exp.y (find_primitive_type): Update.
7938         * ada-lang.h (ada_lookup_symbol): Update.
7939         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7940         parameter.
7941         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7942
7943 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7944
7945         PR breakpoints/24541
7946         * gdbarch.c: Regenerate.
7947         * gdbarch.h: Regenerate.
7948         * gdbarch.sh: Add 'stap_adjust_register'.
7949         * i386-tdep.c: Include '<unordered_set>'.
7950         (i386_stap_adjust_register): New function.
7951         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7952         * stap-probe.c (stap_parse_register_operand): Call
7953         'gdbarch_stap_adjust_register'.
7954
7955 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7956
7957         PR python/24742
7958         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7959         * python/python.c (do_start_initialization): Use 'xmalloc'
7960         instead of 'PyMem_Malloc'.
7961
7962 2019-06-28  Tom Tromey  <tromey@adacore.com>
7963
7964         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7965         for Ada.
7966
7967 2019-06-27  Tom Tromey  <tromey@adacore.com>
7968
7969         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7970         objfile_key.
7971         (arm_find_mapping_symbol, arm_record_special_symbol)
7972         (_initialize_arm_tdep): Update.
7973         (arm_objfile_data_free): Remove.
7974
7975 2019-06-27  Tom Tromey  <tromey@adacore.com>
7976
7977         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7978         to cp_print_static_field.
7979
7980 2019-06-26  Tom Tromey  <tromey@adacore.com>
7981
7982         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7983         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7984         declare.
7985
7986 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7987
7988         * features/aarch64-core.c (create_feature_aarch64_core):
7989         Regenerate.
7990         * features/aarch64-core.xml: Add cpsr flags.
7991
7992 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7993
7994         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7995         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7996
7997 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7998
7999         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8000         field.
8001         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8002         use.
8003         (arm_record_special_symbol): Don't insert new symbol in sorted
8004         position, push it at the end.
8005
8006 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8007
8008         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8009         (arm_mapping_symbol_s): Remove.
8010         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8011         (arm_mapping_symbol_vec): New typedef.
8012         (struct arm_per_objfile): Add constructor.
8013         <section_maps>: Change type to
8014         std::unique_ptr<arm_mapping_symbol_vec[]>.
8015         (arm_compare_mapping_symbols): Remove.
8016         (arm_find_mapping_symbol): Adjust to section_maps type change.
8017         (arm_objfile_data_free): Call delete on arm_per_objfile.
8018         (arm_record_special_symbol): Adjust to section_maps type change.
8019         Allocate arm_per_objfile with new.
8020
8021 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8022
8023         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8024         with the command prefix.
8025
8026 2019-06-25  Tom Tromey  <tom@tromey.com>
8027
8028         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8029         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8030
8031 2019-06-25  Tom Tromey  <tom@tromey.com>
8032
8033         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8034         type.
8035         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8036         protected.
8037
8038 2019-06-25  Tom Tromey  <tom@tromey.com>
8039
8040         * tui/tui-winsource.c
8041         (tui_source_window_base::set_is_exec_point_at): Add check against
8042         LOA_ADDRESS.
8043
8044 2019-06-25  Tom Tromey  <tom@tromey.com>
8045
8046         * tui/tui-source.c (tui_set_source_content): Don't check before
8047         xfree.
8048         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8049
8050 2019-06-25  Tom Tromey  <tom@tromey.com>
8051
8052         * tui/tui-winsource.h (tui_update_source_window_as_is)
8053         (tui_alloc_source_buffer, tui_line_is_displayed)
8054         (tui_addr_is_displayed): Change type of win_info.
8055         * tui/tui-winsource.c (tui_update_source_window_as_is)
8056         (tui_clear_source_content, tui_show_source_line)
8057         (tui_show_source_content, tui_source_window_base::refill)
8058         (tui_source_window_base::set_is_exec_point_at)
8059         (tui_source_window_base::set_is_exec_point_at)
8060         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8061         (tui_alloc_source_buffer, tui_line_is_displayed)
8062         (tui_addr_is_displayed): Change type of win_info.  Update.
8063         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8064         (tui_source_window_base::do_make_visible_with_new_height):
8065         Update.
8066         * tui/tui-source.c (tui_set_source_content)
8067         (tui_set_source_content_nil)
8068         (tui_source_window::do_scroll_vertical): Update.
8069         * tui/tui-layout.c (show_layout): Update.
8070         * tui/tui-disasm.c (tui_set_disassem_content)
8071         (tui_disasm_window::do_scroll_vertical): Update.
8072         * tui/tui-data.h (tui_win_content): Remove.
8073         (struct tui_gen_win_info) <content, content_size>: Remove.
8074         (struct tui_source_element): Add initializers and destructor.
8075         (union tui_which_element, struct tui_win_element): Remove.
8076         (struct tui_source_window_base) <content>: New field.
8077         (struct tui_data_window): Remove destructor.
8078         (tui_alloc_content, tui_free_win_content)
8079         (tui_free_all_source_wins_content): Don't declare.
8080         * tui/tui-data.c (tui_initialize_static_data): Update.
8081         (init_content_element, tui_alloc_content): Remove.
8082         (~tui_gen_win_info): Update.
8083         (~tui_data_window, tui_free_all_source_wins_content)
8084         (tui_free_win_content, free_content, free_content_elements):
8085         Remove.
8086
8087 2019-06-25  Tom Tromey  <tom@tromey.com>
8088
8089         * tui/tui-winsource.h (tui_clear_source_content)
8090         (tui_erase_source_content, tui_show_source_content): Change type
8091         of win_info.
8092         * tui/tui-winsource.c (tui_clear_source_content)
8093         (tui_erase_source_content, tui_show_source_content): Change type
8094         of win_info.
8095         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8096         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8097         win_info.
8098         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8099         win_info.
8100         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8101
8102 2019-06-25  Tom Tromey  <tom@tromey.com>
8103
8104         * tui/tui-winsource.c (tui_clear_source_content)
8105         (tui_source_window_base::set_is_exec_point_at): Update.
8106         * tui/tui-source.c (tui_set_source_content_nil): Update.
8107         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8108         a bool.
8109         * tui/tui-data.c (init_content_element): Update.
8110
8111 2019-06-25  Tom Tromey  <tom@tromey.com>
8112
8113         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8114         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8115         * tui/tui-layout.c (init_and_make_win): Update.
8116         * tui/tui.h (enum tui_win_type): Update.
8117         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8118         tui_win_is_auxillary.
8119         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8120         tui_win_is_auxillary.
8121
8122 2019-06-25  Tom Tromey  <tom@tromey.com>
8123
8124         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8125         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8126         (tui_delete_data_content_windows, tui_display_all_data)
8127         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8128         Update.
8129         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8130         * tui/tui-regs.c (tui_last_regs_line_no)
8131         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8132         (tui_show_registers): Update.
8133         (tui_show_register_group): Return void.  Update.
8134         (tui_display_registers_from, tui_display_reg_element_at_line)
8135         (tui_display_registers_from_line, tui_check_register_values):
8136         Update.
8137         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8138         member.
8139         (struct tui_data_window) <regs_content>: Now a std::vector.
8140         <regs_content_count>: Remove.
8141         (tui_add_content_elements, tui_free_data_content): Don't declare.
8142         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8143         (init_content_element): Remove DATA_WIN case.  Add assert.
8144         (tui_add_content_elements): Remove.
8145         (tui_data_window): Update.
8146         (tui_free_data_content): Remove.
8147         (free_content_elements): Remove DATA_WIN case.
8148
8149 2019-06-25  Tom Tromey  <tom@tromey.com>
8150
8151         * tui/tui-data.c (tui_data_item_window): Update.
8152         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8153         * tui/tui-windata.c (tui_display_all_data)
8154         (tui_display_data_from_line): Update.
8155         (tui_check_data_values): Remove.
8156         * tui/tui-regs.c (tui_show_register_group)
8157         (tui_display_reg_element_at_line): Update.
8158         * tui/tui-hooks.c (tui_register_changed)
8159         (tui_refresh_frame_and_register_information): Call
8160         tui_check_register_values.
8161         * tui/tui-data.h (struct tui_data_window) <data_content,
8162         data_content_count, data_type>: Remove.
8163         (enum tui_data_type): Remove.
8164
8165         * tui/tui-data.c (tui_data_window::clear_detail)
8166         (~tui_data_window): Update.
8167
8168 2019-06-25  Tom Tromey  <tom@tromey.com>
8169
8170         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8171         declare.
8172         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8173         Rename from tui_first_data_item_displayed.  Update.
8174         (tui_data_window::refresh_all)
8175         (tui_data_window::do_scroll_vertical): Update.
8176         * tui/tui-data.h (struct tui_data_window)
8177         <first_data_item_displayed>: Declare new method.
8178
8179 2019-06-25  Tom Tromey  <tom@tromey.com>
8180
8181         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8182         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8183         contents...
8184         (tui_initialize_static_data): ...here.
8185
8186 2019-06-25  Tom Tromey  <tom@tromey.com>
8187
8188         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8189         (tui_display_registers_from, tui_check_register_values): Update.
8190         (tui_display_register): Remove win_info parameter; update.
8191         (tui_get_register): Change type of parameters.
8192         * tui/tui-data.h (struct tui_data_element): Remove.
8193         (union tui_which_element) <data>: Remove.
8194         <data_window>: Change type.
8195         (struct tui_data_item_window): New.
8196         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8197         case.  Add assert.
8198         (~tui_data_item_window): New destructor.
8199         (free_content_elements): Remove DATA_ITEM_WIN case.
8200
8201 2019-06-25  Tom Tromey  <tom@tromey.com>
8202
8203         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8204         Remove.
8205
8206 2019-06-25  Tom Tromey  <tom@tromey.com>
8207
8208         * tui/tui-data.h (struct tui_command_element): Remove.
8209         (union tui_which_element) <command>: Remove.
8210         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8211         assert.
8212         (free_content_elements): Remove CMD_WIN case.
8213
8214 2019-06-25  Tom Tromey  <tom@tromey.com>
8215
8216         * tui/tui-layout.c (tui_set_layout): Update.
8217         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8218         * tui/tui-data.c (layout_def): Update.
8219
8220 2019-06-25  Tom Tromey  <tom@tromey.com>
8221
8222         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8223         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8224         (tui_source_window_base::set_new_height): Update.
8225         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8226         Update.
8227         (tui_set_locator_fullname, tui_set_locator_info)
8228         (tui_show_frame_info): Update.
8229         * tui/tui-source.c (tui_set_source_content)
8230         (tui_source_is_displayed): Update.
8231         * tui/tui-layout.c (show_source_disasm_command, show_data)
8232         (show_source_or_disasm_and_command): Update.
8233         * tui/tui-disasm.c (tui_set_disassem_content)
8234         (tui_get_begin_asm_address): Update.
8235         * tui/tui-data.h (struct tui_locator_element): Remove.
8236         (union tui_which_element) <locator>: Remove.
8237         (struct tui_locator_window): New.
8238         (tui_locator_win_info_ptr): Change return type.
8239         * tui/tui-data.c (_locator): Change type.
8240         (tui_locator_win_info_ptr): Change return type.
8241         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8242         (tui_alloc_content): Add assert.
8243
8244 2019-06-25  Tom Tromey  <tom@tromey.com>
8245
8246         * tui/tui-winsource.c
8247         (tui_exec_info_window::maybe_allocate_content): New method.
8248         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8249         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8250         (make_source_or_disasm_window): Add cast.
8251         * tui/tui-data.h (union tui_which_element) <simple_string>:
8252         Remove.
8253         (struct tui_source_info): New.
8254         (struct tui_source_window_base) <execution_info>: Change type.
8255         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8256         case, and add assert.
8257         (tui_alloc_content): Add assert.
8258
8259 2019-06-25  Tom Tromey  <tom@tromey.com>
8260
8261         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8262         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8263         * tui/tui-data.c (tui_alloc_win_info): Remove.
8264
8265 2019-06-25  Tom Tromey  <tom@tromey.com>
8266
8267         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8268         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8269         can_highlight.
8270
8271 2019-06-25  Tom Tromey  <tom@tromey.com>
8272
8273         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8274         make_visible_with_new_height method.
8275         (tui_win_info::make_visible_with_new_height): New method.
8276         (tui_source_window_base::do_make_visible_with_new_height)
8277         (tui_data_window::do_make_visible_with_new_height)
8278         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8279         (make_visible_with_new_height): Remove.
8280         (tui_resize_all, tui_adjust_win_heights): Use
8281         make_visible_with_new_height method.
8282         * tui/tui-data.h (struct tui_win_info)
8283         <do_make_visible_with_new_height, make_visible_with_new_height>:
8284         New methods.
8285         (struct tui_source_window_base, struct tui_data_window)
8286         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8287         methods.
8288
8289 2019-06-25  Tom Tromey  <tom@tromey.com>
8290
8291         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8292         method.
8293         (update_tab_width): Call update_tab_width method.
8294         * tui/tui-data.h (struct tui_win_info)
8295         (struct tui_source_window_base) <update_tab_width>: New methods.
8296
8297 2019-06-25  Tom Tromey  <tom@tromey.com>
8298
8299         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8300         parameter.
8301         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8302         parameter.
8303         (tui_gen_win_info::make_visible): Update.
8304         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8305         parameter.
8306         * tui/tui-data.h (enum tui_box): New enum.
8307         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8308
8309 2019-06-25  Tom Tromey  <tom@tromey.com>
8310
8311         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8312         init_and_make_win for EXEC_INFO_WIN.
8313         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8314         longer inline.
8315         (struct tui_win_info) <~tui_win_info>: Inline.
8316         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8317         Don't declare.
8318         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8319         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8320         Remove.
8321         (tui_initialize_static_data): Update.
8322         (~tui_gen_win_info): Handle more cleanup here.
8323         (~tui_source_window_base): Delete "execution_info".
8324         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8325
8326 2019-06-25  Tom Tromey  <tom@tromey.com>
8327
8328         * tui/tui-layout.c (make_command_window): Don't set
8329         can_highlight.
8330         (show_source_disasm_command): Call the reset method.
8331         (show_data): Don't set can_highlight.  Call the reset method.
8332         (tui_gen_win_info::reset): Rename from init_gen_win_info
8333         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8334         (show_source_or_disasm_and_command): Call the reset method.
8335         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8336         (struct tui_cmd_window): Set can_highlight.
8337
8338 2019-06-25  Tom Tromey  <tom@tromey.com>
8339
8340         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8341         from make_visible.
8342         (tui_make_visible, tui_make_invisible): Rewrite.
8343         (tui_win_info::make_visible): Remove.
8344         (tui_source_window_base::make_visible): Update.
8345         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8346         method.  Moved from...
8347         (struct tui_win_info) <make_visible>: ...here.
8348
8349 2019-06-25  Tom Tromey  <tom@tromey.com>
8350
8351         * tui/tui-winsource.c
8352         (tui_source_window_base::do_scroll_horizontal): Remove direction
8353         parameter.
8354         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8355         direction parameter.
8356         * tui/tui-win.c (tui_win_info::forward_scroll)
8357         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8358         (tui_win_info::right_scroll): Update.
8359         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8360         direction parameter.
8361         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8362         direction parameter.
8363         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8364         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8365         Remove direction parameter.
8366         (struct tui_source_window_base, struct tui_source_window)
8367         (struct tui_disasm_window, struct tui_data_window)
8368         (struct tui_cmd_window): Update.
8369
8370 2019-06-25  Tom Tromey  <tom@tromey.com>
8371
8372         * tui/tui-winsource.h (tui_set_exec_info_content)
8373         (tui_show_exec_info_content, tui_erase_exec_info_content)
8374         (tui_clear_exec_info_content, tui_update_exec_info): Change
8375         argument to tui_source_window_base.
8376         * tui/tui-winsource.c (tui_set_exec_info_content)
8377         (tui_show_exec_info_content, tui_erase_exec_info_content)
8378         (tui_clear_exec_info_content, tui_update_exec_info): Change
8379         argument to tui_source_window_base.
8380
8381 2019-06-25  Tom Tromey  <tom@tromey.com>
8382
8383         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8384         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8385
8386 2019-06-25  Tom Tromey  <tom@tromey.com>
8387
8388         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8389         check.
8390
8391 2019-06-25  Tom Tromey  <tom@tromey.com>
8392
8393         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8394         type to void.
8395         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8396         type to void.
8397         * tui/tui-source.c (tui_set_source_content): Update.
8398         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8399
8400 2019-06-25  Tom Tromey  <tom@tromey.com>
8401
8402         * tui/tui-win.c (window_name_completer, tui_set_focus)
8403         (tui_all_windows_info): Use name method.
8404         * tui/tui-data.h (struct tui_gen_win_info)
8405         (struct tui_source_window, struct tui_disasm_window)
8406         (struct tui_data_window, struct tui_cmd_window) <name>: New
8407         method.
8408         (tui_win_name): Don't declare.
8409         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8410         (tui_win_name): Remove.
8411
8412 2019-06-25  Tom Tromey  <tom@tromey.com>
8413
8414         * tui/tui-winsource.h (tui_update_source_window)
8415         (tui_update_source_window_as_is): Change parameter type.
8416         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8417         to be a tui_source_window_base.
8418         (tui_update_source_window_as_is): Likewise.
8419         * tui/tui-win.c (make_visible_with_new_height): Update.
8420
8421 2019-06-25  Tom Tromey  <tom@tromey.com>
8422
8423         * tui/tui-winsource.c (tui_erase_source_content)
8424         (tui_show_source_content, tui_show_exec_info_content)
8425         (tui_erase_exec_info_content): Use refresh_window method.
8426         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8427         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8428         from tui_refresh_win.
8429         (tui_data_window::refresh_window): New method.
8430         (tui_win_info::refresh, tui_source_window_base::refresh)
8431         (tui_refresh_all): Use refresh_window method.
8432         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8433         method.
8434         * tui/tui-regs.c (tui_display_register): Call refresh_window
8435         method.
8436         * tui/tui-layout.c (show_source_disasm_command)
8437         (show_source_or_disasm_and_command): Call refresh_window method.
8438         * tui/tui-data.h (struct tui_gen_win_info)
8439         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8440         New method.
8441
8442 2019-06-25  Tom Tromey  <tom@tromey.com>
8443
8444         * tui/tui.c (tui_rl_other_window, tui_enable)
8445         (tui_is_window_visible, tui_get_command_dimension): Update.
8446         * tui/tui-winsource.c (tui_update_source_window_as_is)
8447         (tui_clear_source_content, tui_erase_source_content)
8448         (tui_show_source_line, tui_source_window_base::refill)
8449         (tui_source_window_base::do_scroll_horizontal)
8450         (tui_source_window_base::set_is_exec_point_at)
8451         (tui_update_breakpoint_info, tui_set_exec_info_content)
8452         (tui_alloc_source_buffer, tui_line_is_displayed)
8453         (tui_addr_is_displayed): Update.
8454         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8455         (tui_check_and_display_highlight_if_needed)
8456         (tui_win_info::make_visible, tui_win_info::refresh)
8457         (tui_refresh_all): Update.
8458         * tui/tui-windata.c (tui_first_data_item_displayed)
8459         (tui_delete_data_content_windows, tui_erase_data_content)
8460         (tui_display_all_data, tui_data_window::refresh_all)
8461         (tui_check_data_values): Update.
8462         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8463         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8464         (tui_win_info::backward_scroll, tui_refresh_all_win)
8465         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8466         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8467         (tui_source_window_base::set_new_height)
8468         (tui_data_window::set_new_height)
8469         (make_invisible_and_set_new_height)
8470         (make_visible_with_new_height, new_height_ok)
8471         (parse_scrolling_args): Update.
8472         * tui/tui-stack.c (tui_show_frame_info): Update.
8473         * tui/tui-source.c (tui_set_source_content)
8474         (tui_set_source_content_nil, tui_source_is_displayed)
8475         (tui_source_window::do_scroll_vertical): Update.
8476         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8477         (tui_display_registers_from, tui_display_reg_element_at_line)
8478         (tui_check_register_values, tui_reg_command): Update.
8479         * tui/tui-layout.c (tui_default_win_height)
8480         (show_source_disasm_command, show_data, init_and_make_win)
8481         (show_source_or_disasm_and_command): Update.
8482         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8483         (tui_redisplay_readline, tui_mld_flush)
8484         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8485         (tui_getc): Update.
8486         * tui/tui-disasm.c (tui_set_disassem_content)
8487         (tui_disasm_window::do_scroll_vertical): Update.
8488         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8489         Now virtual.
8490         (struct tui_win_info): Derive from tui_gen_win_info.
8491         <~tui_win_info>: Mark as override.
8492         <generic>: Remove member.
8493         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8494         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8495         (~tui_data_window, ~tui_win_info)
8496         (tui_free_all_source_wins_content): Update.
8497         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8498
8499 2019-06-25  Tom Tromey  <tom@tromey.com>
8500
8501         * tui/tui-layout.c (init_and_make_win): Use new.
8502         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8503         destructor, initializers.
8504         (tui_alloc_generic_win_info): Don't declare.
8505         * tui/tui-data.c (_locator): Add argument to constructor.
8506         (source_win, disasm_win): New globals.
8507         (exec_info): Remove.
8508         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8509         Update.
8510         (tui_alloc_generic_win_info): Remove.
8511         (init_content_element): Use new.
8512         (tui_win_info::tui_win_info): Update.
8513         (free_content_elements) <case DATA_WIN>: Use delete.
8514
8515 2019-06-25  Tom Tromey  <tom@tromey.com>
8516
8517         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8518         * tui/tui-windata.c (tui_first_data_item_displayed)
8519         (tui_delete_data_content_windows): Update.
8520         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8521         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8522         (tui_display_registers_from, tui_check_register_values): Update.
8523         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8524         pointer.
8525         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8526         window.
8527         (tui_free_data_content): Update.
8528         (free_content_elements) <case DATA_WIN>: Free the window.
8529
8530 2019-06-25  Tom Tromey  <tom@tromey.com>
8531
8532         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8533         Update.
8534         * tui/tui-layout.c (make_command_window)
8535         (show_source_disasm_command, show_data, init_and_make_win)
8536         (show_source_or_disasm_and_command): Update.
8537         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8538         method.
8539         <can_highight, is_highlighted>: Now bool.
8540         (tui_set_win_highlight): Don't declare.
8541         * tui/tui-data.c (tui_set_win_highlight): Remove.
8542
8543 2019-06-25  Tom Tromey  <tom@tromey.com>
8544
8545         * tui/tui-wingeneral.c (make_visible): Remove check of window
8546         type.
8547
8548 2019-06-25  Tom Tromey  <tom@tromey.com>
8549
8550         * tui/tui-win.c (tui_win_info::max_height)
8551         (tui_cmd_window::max_height): New methods.
8552         (new_height_ok): Call max_height.
8553         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8554         <max_height>: New method.
8555
8556 2019-06-25  Tom Tromey  <tom@tromey.com>
8557
8558         * tui/tui-win.c (tui_source_window_base::set_new_height)
8559         (tui_data_window::set_new_height): New methods.
8560         (make_invisible_and_set_new_height): Call set_new_height method.
8561         * tui/tui-data.h (struct tui_win_info)
8562         (struct tui_source_window_base, struct tui_data_window)
8563         <set_new_height>: New method.
8564
8565 2019-06-25  Tom Tromey  <tom@tromey.com>
8566
8567         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8568         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8569         tui_refresh_data_win.
8570         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8571         method.
8572         (tui_refresh_all_win): Call the refresh_all method.
8573         (tui_set_focus): Likewise.
8574         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8575         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8576         Likewise.
8577
8578 2019-06-25  Tom Tromey  <tom@tromey.com>
8579
8580         * tui/tui-winsource.h (tui_refill_source_window)
8581         (tui_set_is_exec_point_at): Don't declare.
8582         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8583         (tui_source_window_base::refill): Rename from
8584         tui_refill_source_window.
8585         (tui_source_window_base::do_scroll_horizontal): Update.
8586         (tui_source_window_base::set_is_exec_point_at): Rename from
8587         tui_set_is_exec_point_at.
8588         (tui_update_all_breakpoint_info): Update.
8589         * tui/tui-stack.c (tui_show_frame_info): Update.
8590         * tui/tui-layout.c (show_data): Add cast.
8591         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8592         * tui/tui-data.h (struct tui_source_window_base) <refill,
8593         set_is_exec_point_at>: New methods.
8594         (tui_source_windows, tui_add_to_source_windows): Update types.
8595         (tui_add_to_source_windows): Remove redundant declaration.
8596         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8597         (tui_source_windows): Change return type.
8598         (tui_clear_source_windows_detail): Update.
8599         (tui_add_to_source_windows): Change type of parameter.
8600         (tui_free_all_source_wins_content): Update.
8601
8602 2019-06-25  Tom Tromey  <tom@tromey.com>
8603
8604         * tui/tui-wingeneral.c (tui_win_info::refresh)
8605         (tui_source_window_base::refresh): New methods.
8606         (tui_refresh_all): Call the refresh method.
8607         * tui/tui-data.h (struct tui_win_info)
8608         (struct tui_source_window_base) <refresh>: New method.
8609
8610 2019-06-25  Tom Tromey  <tom@tromey.com>
8611
8612         * tui/tui.h (tui_is_window_visible): Return bool.
8613         * tui/tui.c (tui_is_window_visible): Return bool.
8614         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8615         (tui_make_visible, tui_make_invisible)
8616         (tui_win_info::make_visible)
8617         (tui_source_window_base::make_visible, make_all_visible)
8618         (tui_make_all_visible, tui_make_all_invisible): Update.
8619         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8620         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8621         bool.
8622         (struct tui_win_info, struct tui_source_window_base)
8623         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8624         * tui/tui-data.c (tui_init_generic_part): Update.
8625
8626 2019-06-25  Tom Tromey  <tom@tromey.com>
8627
8628         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8629         (tui_source_window_base::make_visible): New methods.
8630         (make_all_visible): Make method call.
8631         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8632         (struct tui_source_window_base, struct tui_cmd_window): Override
8633         make_visible.
8634         (tui_win_is_source_type): Don't declare.
8635         * tui/tui-data.c (tui_win_is_source_type): Remove.
8636
8637 2019-06-25  Tom Tromey  <tom@tromey.com>
8638
8639         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8640         NULL check.
8641
8642 2019-06-25  Tom Tromey  <tom@tromey.com>
8643
8644         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8645         Inline constructor.  Add initializers for members.
8646         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8647         constructors; now inline in class.
8648
8649 2019-06-25  Tom Tromey  <tom@tromey.com>
8650
8651         * tui/tui-regs.c (tui_show_registers): Update.
8652         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8653         bool.
8654         * tui/tui-data.c (tui_data_window::clear_detail)
8655         (tui_data_window): Update.
8656
8657 2019-06-25  Tom Tromey  <tom@tromey.com>
8658
8659         * tui/tui-windata.c (tui_display_all_data)
8660         (tui_display_data_from_line, tui_display_data_from)
8661         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8662         Update.
8663         * tui/tui-regs.c (tui_last_regs_line_no)
8664         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8665         (tui_show_registers, tui_show_register_group)
8666         (tui_display_registers_from, tui_display_reg_element_at_line)
8667         (tui_display_registers_from_line, tui_check_register_values)
8668         (tui_reg_next, tui_reg_prev): Update.
8669         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8670         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8671         tui_data_window.
8672         (struct tui_win_info) <detail>: Remove.  Add new fields from
8673         tui_data_info.
8674         (TUI_DATA_WIN): Add cast.
8675         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8676         (~tui_data_window): Simplify.
8677
8678 2019-06-25  Tom Tromey  <tom@tromey.com>
8679
8680         * tui/tui-layout.c (show_source_disasm_command)
8681         (show_source_or_disasm_and_command): Update.
8682         * tui/tui-io.c (update_cmdwin_start_line)
8683         (tui_redisplay_readline): Update.
8684         * tui/tui-data.h (struct tui_command_info): Remove.
8685         (struct tui_win_info) <detail>: Remove command_info member.
8686         (struct tui_data_window) <start_line>: New member, from
8687         tui_command_info.
8688         (TUI_CMD_WIN): Add casts.
8689
8690 2019-06-25  Tom Tromey  <tom@tromey.com>
8691
8692         * tui/tui-winsource.c (tui_update_source_window)
8693         (tui_refill_source_window)
8694         (tui_source_window_base::do_scroll_horizontal)
8695         (tui_update_breakpoint_info, tui_set_exec_info_content)
8696         (tui_show_exec_info_content, tui_erase_exec_info_content)
8697         (tui_clear_exec_info_content): Update.
8698         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8699         Update.
8700         * tui/tui-win.c (make_invisible_and_set_new_height)
8701         (make_visible_with_new_height): Update.
8702         * tui/tui-source.c (tui_set_source_content)
8703         (tui_show_symtab_source): Update.
8704         * tui/tui-layout.c (extract_display_start_addr)
8705         (show_source_disasm_command, show_data)
8706         (make_source_or_disasm_window)
8707         (show_source_or_disasm_and_command): Update.
8708         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8709         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8710         "gdbarch".
8711         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8712         to tui_source_window_base.
8713         (struct tui_win_info) <detail>: Remove source_info member.
8714         (struct tui_source_window_base) <has_locator>: Inline.
8715         Move contents from tui_source_info; rename has_locator member to
8716         m_has_locator.
8717         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8718         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8719         header file.
8720         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8721         Simplify.
8722         (tui_free_all_source_wins_content): Cast to
8723         tui_source_window_base.
8724
8725 2019-06-25  Tom Tromey  <tom@tromey.com>
8726
8727         * tui/tui-win.c (make_invisible_and_set_new_height)
8728         (make_visible_with_new_height): Call has_locator method.
8729         * tui/tui-layout.c (show_source_disasm_command, show_data)
8730         (show_source_or_disasm_and_command): Update for bool change.
8731         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8732         (tui_win_info) <has_locator>: New method.
8733         (struct tui_source_window_base) <has_locator>: New method.
8734         (tui_win_has_locator): Don't declare.
8735         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8736         from tui_win_has_locator.
8737         (tui_source_window_base): Use false, not FALSE.
8738
8739 2019-06-25  Tom Tromey  <tom@tromey.com>
8740
8741         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8742         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8743         clear_detail method directly.
8744         (tui_clear_win_detail): Remove.
8745
8746 2019-06-25  Tom Tromey  <tom@tromey.com>
8747
8748         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8749         "this", not TUI_DISASM_WIN.
8750
8751 2019-06-25  Tom Tromey  <tom@tromey.com>
8752
8753         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8754         declare.
8755         * tui/tui-winsource.c
8756         (tui_source_window_base::do_scroll_horizontal): Rename from
8757         tui_horizontal_source_scroll.
8758         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8759         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8760         from tui_vertical_data_scroll.
8761         * tui/tui-win.h (tui_scroll): Don't declare.
8762         * tui/tui-win.c (tui_win_info::forward_scroll)
8763         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8764         (tui_win_info::right_scroll): Rename and update.
8765         (tui_scroll_forward_command, tui_scroll_backward_command)
8766         (tui_scroll_left_command, tui_scroll_right_command): Update.
8767         (tui_scroll): Remove.
8768         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8769         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8770         from tui_vertical_source_scroll.
8771         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8772         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8773         from tui_vertical_disassem_scroll.
8774         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8775         do_scroll_horizontal>: New methods.
8776         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8777         Likewise.
8778         (struct tui_source_window_base): Add do_scroll_horizontal.
8779         (struct tui_source_window, struct tui_disasm_window): Add
8780         do_scroll_vertical.
8781         (struct tui_data_window, struct tui_cmd_window): Add
8782         do_scroll_horizontal and do_scroll_vertical.
8783         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8784
8785 2019-06-25  Tom Tromey  <tom@tromey.com>
8786
8787         * tui/tui-data.h (struct tui_source_window_base): New struct.
8788         (struct tui_source_window): Derive from tui_source_window_base.
8789         (struct tui_disasm_window): New struct.
8790         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8791         from tui_source_window::clear_detail.
8792         (tui_source_window_base): Rename from tui_source_window.
8793         (~tui_source_window_base): Rename from ~tui_source_window.
8794         (tui_alloc_win_info): Create a tui_disasm_window.
8795
8796 2019-06-25  Tom Tromey  <tom@tromey.com>
8797
8798         * tui/tui-data.h (struct tui_source_window)
8799         (struct tui_data_window): Declare destructors.
8800         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8801         destructors.
8802         (tui_win_info): Simplify.
8803
8804 2019-06-25  Tom Tromey  <tom@tromey.com>
8805
8806         * tui/tui-winsource.c (tui_display_main)
8807         (tui_update_source_windows_with_addr)
8808         (tui_update_all_breakpoint_info): Update.
8809         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8810         (new_height_ok, parse_scrolling_args): Update.
8811         * tui/tui-stack.c (tui_show_frame_info): Update.
8812         * tui/tui-data.h (struct tui_list): Remove.
8813         (tui_source_windows): Return a reference to a std::vector.
8814         * tui/tui-data.c (source_windows): Now a std::vector.
8815         (tui_source_windows): Change return type.
8816         (tui_clear_source_windows): Rewrite.
8817         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8818         (tui_free_all_source_wins_content): Rewrite.
8819
8820 2019-06-25  Tom Tromey  <tom@tromey.com>
8821
8822         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8823         (struct tui_data_window, struct tui_cmd_window): Declare
8824         clear_detail method.
8825         * tui/tui-data.c (tui_source_window::clear_detail)
8826         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8827         methods.
8828         (tui_clear_win_detail): Simplify.
8829
8830 2019-06-25  Tom Tromey  <tom@tromey.com>
8831
8832         * tui/tui-layout.c (make_source_window, make_disasm_window)
8833         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8834         Return the new window.
8835         (show_source_disasm_command, show_data)
8836         (show_source_or_disasm_and_command): Update.
8837
8838 2019-06-25  Tom Tromey  <tom@tromey.com>
8839
8840         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8841         parameter.  Return the new window.
8842         (show_source_disasm_command): Update and remove NULL check.
8843         (show_source_or_disasm_and_command): Update.
8844
8845 2019-06-25  Tom Tromey  <tom@tromey.com>
8846
8847         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8848
8849 2019-06-25  Tom Tromey  <tom@tromey.com>
8850
8851         * tui/tui-data.h (struct tui_win_info): Make constructor
8852         protected.  Make destructor virtual.  Add initializers.
8853         (tui_source_window, tui_data_window, tui_cmd_window): New
8854         classes.
8855         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8856         constructor.  Add "type" parameter.
8857         (tui_source_window, tui_data_window, tui_cmd_window): New
8858         constructors.
8859         (tui_alloc_win_info): Instantiate the appropriate subclass.
8860
8861 2019-06-25  Tom Tromey  <tom@tromey.com>
8862
8863         * tui/tui-win.c (tui_resize_all): Use delete.
8864         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8865         destructor.
8866         (tui_free_window): Don't declare.
8867         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8868         Update.
8869
8870 2019-06-25  Tom Tromey  <tom@tromey.com>
8871
8872         * tui/tui-data.h (struct tui_win_info): Add constructor.
8873         * tui/tui-data.c (tui_alloc_win_info): Use new.
8874         (tui_free_window): Use delete.
8875
8876 2019-06-22  Tom Tromey  <tom@tromey.com>
8877
8878         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8879         declare.
8880         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8881
8882 2019-06-22  Tom Tromey  <tom@tromey.com>
8883
8884         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8885         declare.
8886         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8887
8888 2019-06-22  Tom de Vries  <tdevries@suse.de>
8889
8890         * dwarf2read.c (create_addrmap_from_aranges)
8891         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8892         instead of '%zu'.
8893
8894 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8895
8896         * dwarf2read.h (dwarf2_section_info_def): Remove.
8897         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8898         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8899         std::vector<dwarf2_section_info>.
8900         (struct dwo_file) <~dwo_file>: Remove.
8901         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8902         types field.
8903         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8904         (dwarf2_read_debug_names): Likewise.
8905         (create_debug_types_hash_table): Change parameter type to
8906         array_view, adjust code accordingly.
8907         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8908         (partial_die_info::fixup): Likewise.
8909         (determine_prefix): Likewise.
8910         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8911
8912 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8913
8914         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8915         gdb_bfd_ref_ptr.
8916         <~dwo_file>: Remove call to gdb_bfd_unref.
8917         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8918         gdb_bfd_ref_ptr::get.
8919
8920 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8921
8922         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8923         type to htab_up.
8924         * dwarf2read.c (struct dwo_file): Initialize fields.
8925         <~dwo_file>: New.
8926         (free_dwo_file): Remove, move content to ~dwo_file.
8927         (struct dwo_file_deleter): Remove.
8928         (dwo_file_up>: Remove custom deleter.
8929         (free_dwo_files): Remove.
8930         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8931         dwo_files.
8932         (process_skeletonless_type_units): Call unique_ptr::get.
8933         (allocate_dwo_file_hash_table): Add deleter to created hash
8934         table.  Change return type to htab_up.
8935         (lookup_dwo_file_slot): Don't memset dwo_file, call
8936         unique_ptr::get.
8937         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8938         (create_dwo_unit_in_dwp_v2): Likewise.
8939         (open_and_init_dwo_file): Likewise.
8940         (free_dwo_file_from_slot): Remove.
8941
8942 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8943
8944         * dwarf2read.h (struct dwarf2_section_info) <readin,
8945         is_virtual>: Change type to bool.
8946         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8947         true instead of 1.
8948
8949 2019-06-19  Tom Tromey  <tom@tromey.com>
8950
8951         * tui/tui-data.h (tui_init_content_element): Don't declare.
8952
8953 2019-06-19  Tom Tromey  <tom@tromey.com>
8954
8955         * tui/tui-data.h (tui_init_win_info): Don't declare.
8956
8957 2019-06-19  Tom de Vries  <tdevries@suse.de>
8958
8959         * dwarf2read.h (abstract_to_concrete): Change type to
8960         std::unordered_map<sect_offset, std::vector<sect_offset>,
8961         gdb::hash_enum<sect_offset>>.
8962
8963 2019-06-19  Tom Tromey  <tromey@adacore.com>
8964
8965         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8966         EVAL_AVOID_SIDE_EFFECTS specially.
8967
8968 2019-06-19  Tom Tromey  <tromey@adacore.com>
8969
8970         * source-cache.c (highlighter): New global.
8971         (source_cache::get_source_lines): Create a highlighter on demand.
8972
8973 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8974
8975         * defs.h (deprecated_interactive_hook): Delete declaration.
8976         * interps.c (clear_interpreter_hooks): Remove use of
8977         deprecated_interactive_hook.
8978         * top.c (deprecated_interactive_hook): Delete definition.
8979         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8980
8981 2019-06-18  Tom de Vries  <tdevries@suse.de>
8982
8983         PR gdb/24515
8984         * dwarf2read.h (abstract_to_concrete): Change type from
8985         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8986         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8987         * dwarf2read.c (read_variable): Update.
8988         (dwarf2_fetch_die_loc_sect_off): Update.
8989
8990 2019-06-17  Tom de Vries  <tdevries@suse.de>
8991
8992         PR gdb/24617
8993         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8994         accessing parent[parent_len - 1].
8995
8996 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8997
8998         PR gdb/24364
8999         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9000         call dtrace_process_dof with NULL dof.
9001
9002 2019-06-16  Tom de Vries  <tdevries@suse.de>
9003
9004         PR gdb/24445
9005         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9006
9007 2019-06-16  Tom Tromey  <tom@tromey.com>
9008
9009         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9010         (make_all_visible): Use address of member.
9011
9012 2019-06-16  Tom Tromey  <tom@tromey.com>
9013
9014         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9015         (tui_free_window, free_content, free_content_elements): Remove
9016         unnecessary cast.
9017         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9018         cast.
9019         * tui/tui-regs.c (tui_show_register_group)
9020         (tui_display_registers_from, tui_display_reg_element_at_line):
9021         Remove unnecessary cast.
9022
9023 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9024
9025         * linux-nat.c (normal_mask): Delete.
9026         (_initialize_linux_nat): Don't initialise normal_mask.
9027
9028 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9029
9030         PR gdb/24445
9031         * dwarf-index-write.h (write_psymtabs_to_index): Add
9032         dwz_basename parameter.
9033         * dwarf-index-write.c (write_gdbindex): Move file writing to
9034         write_gdbindex_1.  Change return type void.
9035         (assert_file_size): Move up, remove filename parameter.
9036         (write_gdbindex_1): New function.
9037         (write_debug_names): Change return type to void, call
9038         assert_file_size.
9039         (struct index_wip_file): New struct.
9040         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9041         file logic to index_wip_file.  Write index for dwz file if
9042         needed.
9043         (save_gdb_index_command): Pass basename of dwz file, if present.
9044         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9045         build-id of dwz file, if present.
9046         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9047         (dwarf2_get_dwz_file): Likewise.
9048         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9049         (dwarf2_get_dwz_file): Likewise.
9050
9051 2019-06-16  Tom Tromey  <tom@tromey.com>
9052
9053         * coffread.c (process_coff_symbol): Use xstrdup.
9054         * value.c (create_internalvar): Use xstrdup.
9055
9056 2019-06-16  Tom Tromey  <tom@tromey.com>
9057
9058         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9059         * breakpoint.c (stopin_command, stopat_command)
9060         (until_break_command, decode_location_default): Remove unnecessary
9061         cast.
9062         * utils.c (subset_compare): Remove unnecessary cast.
9063         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9064         cast.
9065         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9066         cast.
9067         * infcmd.c (path_command): Remove unnecessary cast.
9068         * coffread.c (decode_type): Remove unnecessary cast.
9069         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9070         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9071         * tui/tui-stack.c (tui_show_locator_content)
9072         (tui_show_frame_info): Remove unnecessary cast.
9073         * tui/tui-win.c (tui_scroll_forward_command)
9074         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9075         (parse_scrolling_args): Remove unnecessary cast.
9076         * tui/tui-data.c (init_win_info, tui_del_window)
9077         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9078         (free_content_elements): Remove unnecessary cast.
9079         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9080         unnecessary cast.
9081         * tui/tui-source.c (tui_set_source_content)
9082         (tui_vertical_source_scroll): Remove unnecessary cast.
9083         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9084         cast.
9085         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9086         * tui/tui-regs.c (tui_display_registers_from)
9087         (tui_display_register): Remove unnecessary cast.
9088         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9089         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9090         (make_visible): Remove unnecessary cast.
9091         * tui/tui-winsource.c (tui_erase_source_content)
9092         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9093         unnecessary cast.
9094         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9095         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9096         * stabsread.c (read_type, read_array_type, read_range_type):
9097         Remove unnecessary cast.
9098         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9099         (parse_symbol, parse_type, upgrade_type, parse_external)
9100         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9101         unnecessary cast.
9102         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9103
9104 2019-06-16  Tom Tromey  <tom@tromey.com>
9105
9106         * tui/tui-data.c (tui_alloc_generic_win_info)
9107         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9108         checks.
9109
9110 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9111             Andrew Burgess  <andrew.burgess@embecosm.com>
9112
9113         * f-typeprint.c (f_print_type): Don't return early for not
9114         associated or not allocated types.
9115         (f_type_print_varspec_suffix): Add print_rank parameter and print
9116         ranks of array types in case they dangling.
9117         (f_type_print_base): Add print_rank parameter.
9118
9119 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9120
9121         * NEWS: Mention new MI commands.
9122         * break-catch-throw.c (enum exception_event_kind): Move to
9123         breakpoint.h.
9124         (print_mention_exception_catchpoint): Output text as a single
9125         message.
9126         (catch_exception_command_1): Rename to...
9127         (catch_exception_event): ...this, make non-static, update header
9128         command, and change some parameter types.
9129         (catch_catch_command): Update for changes to
9130         catch_exception_command_1.
9131         (catch_throw_command): Likewise.
9132         (catch_rethrow_command): Likewise.
9133         * breakpoint.c (enum exception_event_kind): Delete.
9134         * breakpoint.h (enum exception_event_kind): Moved here from
9135         break-catch-throw.c.
9136         (catch_exception_event): Declare.
9137         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9138         (mi_cmd_catch_throw): New function.
9139         (mi_cmd_catch_rethrow): New function.
9140         (mi_cmd_catch_catch): New function.
9141         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9142         'catch-catch' entries.
9143         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9144         (mi_cmd_catch_rethrow): Declare.
9145         (mi_cmd_catch_catch): Declare.
9146
9147 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9148
9149         * annotate.c (annotate_source_line): Change return type to void,
9150         update implementation to match.
9151         * annotate.h (annotate_source_line): Change return type to void,
9152         update header comment.
9153         * stack.c (print_frame_info): Don't change what frame information
9154         is printed based on whether annotations are on or not.
9155
9156 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9157
9158         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9159         (annotate_source): Make static.
9160         (annotate_source_line): Moved from source.c and renamed from
9161         identify_source_line.  Update the return type.
9162         * annotate.h (annotate_source): Delete declaration.
9163         (annotate_source_line): Declaration moved from source.h, and
9164         renamed from identify_source_line.  Return type updated.
9165         * source.c (identify_source_line): Moved to annotate.c and renamed
9166         to annotate_source_line.
9167         (info_line_command): Remove check of annotation_level.
9168         * source.h (identify_source_line): Move declaration to annotate.h
9169         and rename to annotate_source_line.
9170         * stack.c: Add 'annotate.h' include.
9171         (print_frame_info): Remove check of annotation_level before
9172         calling annotate_source_line.
9173
9174 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9175
9176         * source-cache.c (source_cache::get_plain_source_lines): Use
9177         open_source_file_with_line_charpos instead of just
9178         open_source_file, remove call to find_source_lines.
9179         (source_cache::get_source_lines): Likewise.
9180         * source.c (find_source_lines): Make static.
9181         (get_filename_and_charpos): Renamed into...
9182         (open_source_file_with_line_charpos): ..this along with changes to
9183         return a scoped_fd, and some other minor clean ups.
9184         (identify_source_line): Use open_source_file_with_line_charpos.
9185         (search_command_helper): Use open_source_file_with_line_charpos
9186         instead of just open_source_file, remove call to
9187         find_source_lines.
9188         * source.h (open_source_file_with_line_charpos): Declare new
9189         function.
9190         (find_source_lines): Delete declaration.
9191
9192 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9193
9194         * source.c (get_filename_and_charpos): Remove fullname
9195         parameter.
9196         (identify_source_line): Update call to get_filename_and_charpos.
9197
9198 2019-06-14  Tom Tromey  <tromey@adacore.com>
9199
9200         PR gdb/24502:
9201         * ui-style.h (skip_ansi_escape): Update comment.
9202         * ui-file.h (class no_terminal_escape_file): New class.
9203         * ui-file.c (no_terminal_escape_file::write)
9204         (no_terminal_escape_file::puts): New methods.
9205         * cli/cli-logging.c (handle_redirections): Use
9206         no_terminal_escape_file.
9207
9208 2019-06-14  Tom Tromey  <tromey@adacore.com>
9209
9210         * NEWS: Move convenience variable news above Python news.
9211
9212 2019-06-14  Tom Tromey  <tom@tromey.com>
9213
9214         * gnulib: Move directory to top-level.
9215         * configure.ac: Don't configure gnulib.
9216         * configure: Rebuild.
9217         * common/common-defs.h: Use new path to gnulib.
9218         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9219         (GNULIB_H): Remove.
9220         (INCGNU): Look in new gnulib location.
9221         (HFILES_NO_SRCDIR): Remove gnulib files.
9222         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9223         (generated_files): Remove GNULIB_H.
9224         ($(LIBGNU), all-lib): Remove targets.
9225         (distclean): Don't mention GNULIB_BUILDDIR.
9226         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9227
9228 2019-06-14  Tom Tromey  <tromey@adacore.com>
9229
9230         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9231         Warn if symbol file does not provide any symbols.
9232
9233 2019-06-14  Tom Tromey  <tromey@adacore.com>
9234
9235         * source.c (find_and_open_source): Respect basenames_may_differ.
9236
9237 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9238
9239         * annotate.c (annotate_breakpoints_invalid): Make use of
9240         scoped_restore_terminal_state.
9241         (annotate_frames_invalid): Likewise.
9242
9243 2019-06-14  Tom Tromey  <tromey@adacore.com>
9244
9245         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9246         allow assignment to an internalvar.
9247
9248 2019-06-14  Tom Tromey  <tromey@adacore.com>
9249
9250         * ada-lex.l: Allow "_" in attribute names.
9251
9252 2019-06-14  Tom Tromey  <tromey@adacore.com>
9253
9254         PR gdb/24653:
9255         * regcache.c (registers_changed): Don't call alloca.
9256         * top.c (execute_command): Don't call alloca.
9257
9258 2019-06-13  Pedro Alves  <palves@redhat.com>
9259
9260         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9261         'expression'.  When parsing an expression, error out if there's
9262         junk after "unlimited".
9263         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9264         (do_set_command): Adjust calls to is_unlimited_literal.
9265
9266 2019-06-13  Pedro Alves  <palves@redhat.com>
9267
9268         * compile/compile.c (make_compile_options_def_group): Add braces
9269         around array_view initializer.
9270         * thread.c (make_thread_apply_all_options_def_group)
9271         (make_thread_apply_all_options_def_group): Likewise.
9272
9273 2019-06-13  Pedro Alves  <palves@redhat.com>
9274
9275         * NEWS (New commands): Mention "maint test-options
9276         require-delimiter", "maint test-options unknown-is-error", "maint
9277         test-options unknown-is-operand" and "maint show
9278         test-options-completion-result".
9279         (New command options, command completion): New section.
9280         (Completion improvements): New section.
9281         Mention that you can abbreviate "unlimited".
9282
9283 2019-06-13  Pedro Alves  <palves@redhat.com>
9284
9285         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9286         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9287         * unittests/cli-utils-selftests.c (test_parse_flags)
9288         (test_parse_flags_qcs): Delete.
9289         (test_cli_utils): Don't call deleted functions.
9290
9291 2019-06-13  Pedro Alves  <palves@redhat.com>
9292
9293         * thread.c: Include "cli/cli-option.h".
9294         (tp_array_compar_ascending): Global.
9295         (tp_array_compar): Delete function.
9296         (tp_array_compar_ascending, tp_array_compar_descending): New
9297         functions.
9298         (ascending_option_def, qcs_flag_option_def)
9299         (thr_qcs_flags_option_defs)
9300         (make_thread_apply_all_options_def_group)
9301         (make_thread_apply_options_def_group): New.
9302         (thread_apply_all_command): Use gdb::option::process_options.
9303         (thread_apply_command_completer)
9304         (thread_apply_all_command_completer): New.
9305         (thread_apply_command): Use gdb::option::process_options.
9306         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9307         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9308         to generate help text of "thread apply".  Adjust "taas"'s help.
9309         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9310         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9311
9312 2019-06-13  Pedro Alves  <palves@redhat.com>
9313
9314         * thread.c (thread_apply_command): Check for invalid TID with
9315         isdigit instead of !isalpha.
9316
9317 2019-06-13  Pedro Alves  <palves@redhat.com>
9318
9319         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9320         (validate_flags_qcs): New.
9321         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9322         (validate_flags_qcs): Declare.
9323         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9324         (make_frame_apply_options_def_group): New.
9325         (frame_apply_command_count): Process options with
9326         gdb::option::process_options.
9327         (frame_apply_completer): New.
9328         (frame_apply_level_completer, frame_apply_all_completer)
9329         (frame_apply_completer): New.
9330         (_initialize_stack): Update help of "frame apply", "frame apply
9331         level", "frame apply all" and "faas" to mention supported options
9332         and install command completers.
9333         * stack.h (frame_apply_all_completer): Declare.
9334         * thread.c: Include "stack.h".
9335         (tfaas_command): Add "--".
9336         (_initialize_thread): Update help "tfaas" to mention supported
9337         options and install command completer.
9338
9339 2019-06-13  Pedro Alves  <palves@redhat.com>
9340
9341         * completer.c (complete_nested_command_line): New.
9342         (gdb_completion_word_break_characters_throw): Add assertion.
9343         * completer.h (complete_nested_command_line): Declare.
9344
9345 2019-06-13  Pedro Alves  <palves@redhat.com>
9346
9347         * stack.c (parse_backtrace_qualifiers): New.
9348         (backtrace_command): Use it.
9349         (backtrace_command_completer): Complete on qualifiers.
9350
9351 2019-06-13  Pedro Alves  <palves@redhat.com>
9352
9353         * frame.c: Include "cli/cli-option.h.
9354         (user_set_backtrace_options): New.
9355         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9356         Delete.
9357         (get_prev_frame): Adjust.
9358         (boolean_option_def, uinteger_option_def)
9359         (set_backtrace_option_defs): New.
9360         (_initialize_frame): Adjust and use
9361         gdb::option::add_setshow_cmds_for_options to install "set
9362         backtrace past-main" and "set backtrace past-entry".
9363         * frame.h: Include "cli/cli-option.h".
9364         (struct frame_print_options): Forward declare.
9365         (print_frame_arguments_all, print_frame_arguments_scalars)
9366         (print_frame_arguments_none): Declare.
9367         (print_entry_values): Delete declaration.
9368         (struct frame_print_options, user_frame_print_options): New.
9369         (struct set_backtrace_options): New.
9370         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9371         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9372         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9373         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9374         (list_args_or_locals): Add frame_print_options parameter.
9375         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9376         * python/py-framefilter.c (enumerate_args): Pass down
9377         USER_FRAME_PRINT_OPTIONS.
9378         * stack.c: Include "cli/cli-option.h".
9379         (print_frame_arguments_all, print_frame_arguments_scalars)
9380         (print_frame_arguments_none): Declare.
9381         (print_raw_frame_arguments, print_entry_values): Delete.
9382         (user_frame_print_options): New.
9383         (boolean_option_def, enum_option_def, frame_print_option_defs):
9384         New.
9385         (struct backtrace_cmd_options): New.
9386         (bt_flag_option_def): New.
9387         (backtrace_command_option_defs): New.
9388         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9389         (print_frame_arg, read_frame_arg, print_frame_args)
9390         (print_frame_info, print_frame): Add frame_print_options parameter
9391         and use it.
9392         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9393         (backtrace_command_1): Add frame_print_options and
9394         backtrace_cmd_options parameters and use them.
9395         (make_backtrace_options_def_group): New.
9396         (backtrace_command): Process command options with
9397         gdb::option::process_options.
9398         (backtrace_command_completer): New.
9399         (_initialize_stack): Extend "backtrace"'s help to mention
9400         supported options.  Install completer for "backtrace".
9401         Install some settings commands with add_setshow_cmds_for_options.
9402
9403 2019-06-13  Pedro Alves  <palves@redhat.com>
9404
9405         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9406         and that "set/show print raw frame-arguments" are now deprecated.
9407
9408         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9409         command.
9410         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9411         * stack.c (_initialize_stack): Install "set/show print
9412         raw-frame-arguments", and deprecate "set/show print raw
9413         frame-arguments".
9414         * valprint.c (_initialize_valprint): Deprecate "set/show print
9415         raw".
9416
9417 2019-06-13  Pedro Alves  <palves@redhat.com>
9418
9419         * compile/compile.c (struct compile_options): New.
9420         (compile_flag_option_def, compile_command_option_defs)
9421         (make_compile_options_def_group): New.
9422         (compile_file_command): Handle options with
9423         gdb::option::process_options.
9424         (compile_file_command_completer): New function.
9425         (compile_code_command): Handle options with
9426         gdb::option::process_options.
9427         (compile_code_command_completer): New function.
9428         (_initialize_compiler): Install completers for "compile code" and
9429         "compile file".  Mention available options in "compile code" and
9430         "compile code"'s help.
9431         * completer.c (advance_to_completion_word): New, factored out from
9432         ...
9433         (advance_to_expression_complete_word_point): ... this.
9434         (advance_to_filename_complete_word_point): New.
9435         * completer.h (advance_to_filename_complete_word_point): New
9436         declaration.
9437
9438 2019-06-13  Pedro Alves  <palves@redhat.com>
9439
9440         * compile/compile.c: Include "cli/cli-option.h".
9441         (compile_print_value): Scope data pointer is now a
9442         value_print_options pointer; adjust.
9443         (compile_print_command): Process options.  Scope data pointer is
9444         now a value_print_options pointer; adjust.
9445         (_initialize_compile): Update "compile print"'s help to include
9446         supported options.  Install a completer for "compile print".
9447         * cp-valprint.c (show_vtblprint, show_objectprint)
9448         (show_static_field_print): Delete.
9449         (_initialize_cp_valprint): Don't install "set print
9450         static-members", "set print vtbl", "set print object" here.
9451         * printcmd.c: Include "cli/cli-option.h" and
9452         "common/gdb_optional.h".
9453         (print_command_parse_format): Rework to fill in a
9454         value_print_options instead of a format_data.
9455         (print_value): Change parameter type from format_data pointer to
9456         value_print_options reference.  Adjust.
9457         (print_command_1): Process options.  Adjust to pass down a
9458         value_print_options.
9459         (print_command_completer): New.
9460         (_initialize_printcmd): Install print_command_completer as
9461         handle_brkchars completer for the "print" command.  Update
9462         "print"'s help to include supported options.
9463         * valprint.c: Include "cli/cli-option.h".
9464         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9465         here from cp-valprint.c.
9466         (boolean_option_def, uinteger_option_def)
9467         (value_print_option_defs, make_value_print_options_def_group):
9468         New.  Use gdb::option::add_setshow_cmds_for_options to install
9469         "set print elements", "set print null-stop", "set print repeats",
9470         "set print pretty", "set print union", "set print array", "set
9471         print address", "set print symbol", "set print array-indexes".
9472         * valprint.h: Include <string> and "cli/cli-option.h".
9473         (make_value_print_options_def_group): Declare.
9474         (print_value): Change parameter type from format_data pointer to
9475         value_print_options reference.
9476         (print_command_completer): Declare.
9477
9478 2019-06-13  Pedro Alves  <palves@redhat.com>
9479
9480         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9481         (COMMON_SFILES): Add maint-test-settings.c.
9482         * cli/cli-decode.c (boolean_enums): New global, factored out from
9483         ...
9484         (add_setshow_boolean_cmd): ... here.
9485         * cli/cli-decode.h (boolean_enums): Declare.
9486         * cli/cli-option.c: New file.
9487         * cli/cli-option.h: New file.
9488         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9489         factored out from ...
9490         (parse_cli_boolean_value(const char *)): ... this.
9491         (is_unlimited_literal): Change parameter type to pointer to
9492         pointer.  Adjust and advance ARG pointer.
9493         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9494         (parse_cli_var_enum): New, factored out from ...
9495         (do_set_command): ... this.  Adjust.
9496         * cli/cli-setshow.h (parse_cli_boolean_value)
9497         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9498         (parse_cli_var_enum): Declare.
9499         * cli/cli-utils.c: Include "cli/cli-option.h".
9500         (get_ulongest): New.
9501         * cli/cli-utils.h (get_ulongest): Declare.
9502         (check_for_argument): New overloads.
9503         * maint-test-options.c: New file.
9504
9505 2019-06-13  Pedro Alves  <palves@redhat.com>
9506
9507         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9508         parse a range if "-" is at the end of the string.
9509
9510 2019-06-13  Pedro Alves  <palves@redhat.com>
9511
9512         * cli/cli-setshow.c (parse_auto_binary_operation)
9513         (parse_cli_boolean_value): Don't allow "o".
9514
9515 2019-06-13  Pedro Alves  <palves@redhat.com>
9516
9517         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9518         * NEWS: Mention maint test-settings KIND.
9519         * maint-test-settings.c: New file.
9520
9521 2019-06-13  Pedro Alves  <palves@redhat.com>
9522
9523         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9524         completer.
9525         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9526         "set" completers.
9527
9528 2019-06-13  Pedro Alves  <palves@redhat.com>
9529
9530         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9531         after item.
9532
9533 2019-06-13  Pedro Alves  <palves@redhat.com>
9534
9535         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9536
9537 2019-06-13  Pedro Alves <palves@redhat.com>
9538
9539         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9540         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9541         call.
9542         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9543         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9544         calls.
9545         (check_for_argument): Skip spaces after argument.
9546
9547 2019-06-13  Pedro Alves  <palves@redhat.com>
9548
9549         * thread.c (thread_apply_command): Adjust TID parsing.
9550         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9551         detected before end of string.
9552         (tid_is_in_list): Error out if LIST is invalid.
9553
9554 2019-06-13  Pedro Alves  <palves@redhat.com>
9555
9556         * completer.c (complete_line_internal_1): Rewind completion word
9557         point.
9558         (completion_tracker::advance_custom_word_point_by): Change
9559         parameter type to int.
9560         * completer.h (completion_tracker::advance_custom_word_point_by):
9561         Likewise.
9562
9563 2019-06-13  Pedro Alves  <palves@redhat.com>
9564
9565         * completer.c (advance_to_completion_word): Handle delimiters.
9566
9567 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9568
9569         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9570
9571 2019-06-11  Tom Tromey  <tom@tromey.com>
9572
9573         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9574         (xmalloc_failed): Move to alloc.c.
9575         * alloc.c: New file.
9576         * Makefile.in (COMMON_SFILES): Add alloc.c.
9577
9578 2019-06-11  Tom Tromey  <tom@tromey.com>
9579
9580         * nat/linux-waitpid.c: Don't include server.h.
9581         (linux_debug): Remove.
9582         (my_waitpid): Update.
9583
9584 2019-06-11  Tom Tromey  <tromey@adacore.com>
9585
9586         * infcall.c (_initialize_infcall): Remove trailing newline from
9587         help.
9588         * user-regs.c (_initialize_user_regs): Remove trailing newline
9589         from help.
9590         * typeprint.c (_initialize_typeprint): Remove trailing newline
9591         from help.
9592         * reverse.c (_initialize_reverse): Remove trailing newlines from
9593         help.
9594         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9595         from help.
9596         * language.c (add_set_language_command): Remove trailing newline
9597         from help.
9598         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9599         help.
9600         * disasm.c (_initialize_disasm): Remove trailing newline from
9601         help.
9602         * top.c (init_main): Remove trailing newline from help.
9603         * interps.c (_initialize_interpreter): Remove trailing newline
9604         from help.
9605         * btrace.c (_initialize_btrace): Remove trailing newlines from
9606         help.
9607         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9608         from help.
9609         * python/python.c (_initialize_python): Remove trailing newline
9610         from help.
9611         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9612         help.
9613         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9614         from help.  Reformat some text.
9615         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9616         from help.
9617         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9618         newline from help.
9619
9620 2019-06-11  Tom Tromey  <tromey@adacore.com>
9621
9622         * darwin-nat.c (darwin_decode_exception_message)
9623         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9624
9625 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9626
9627         * valops.c (value_slice): Check for not allocated or not
9628         associated values.
9629
9630 2019-06-10  Tom de Vries  <tdevries@suse.de>
9631
9632         PR gdb/24618
9633         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9634         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9635         invalid.
9636
9637 2019-06-10  Tom de Vries  <tdevries@suse.de>
9638
9639         PR gdb/24611
9640         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9641         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9642
9643 2019-06-10  Tom de Vries  <tdevries@suse.de>
9644
9645         PR symtab/24545
9646         * symtab.c (struct demangled_name_entry): Add language field.
9647         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9648         static minimal symbol".  Set and use language field.
9649
9650 2019-06-10  Tom Tromey  <tromey@adacore.com>
9651
9652         * ada-lang.c (_initialize_ada_language): Update help text.
9653
9654 2019-06-10  Tom Tromey  <tromey@adacore.com>
9655
9656         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9657         with a newline.
9658         * guile/guile.c (handle_boot_error): Don't end warning with a
9659         newline.
9660         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9661         warning with a newline.
9662         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9663         newline.
9664         (s12z_frame_cache): Likewise.
9665         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9666         a newline.
9667         * solib-svr4.c (disable_probes_interface): Don't end warning with
9668         a newline.
9669         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9670         newline.
9671         * python/python.c (do_finish_initialization): Don't end warning
9672         with a newline.
9673
9674 2019-06-10  Tom Tromey  <tom@tromey.com>
9675
9676         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9677         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9678         gdbpy_enter.
9679
9680 2019-06-10  Tom Tromey  <tromey@adacore.com>
9681
9682         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9683         data.
9684         (elf_new_init): Don't call stabsread_new_init.
9685         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9686         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9687         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9688
9689 2019-06-10  Tom de Vries  <tdevries@suse.de>
9690
9691         PR symtab/16264
9692         PR symtab/24517
9693         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9694
9695 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9696
9697         * source.c (find_and_open_source): Also rewrite relative file
9698         names.
9699
9700 2019-04-26  Amos Bird  <amosbird@gmail.com>
9701
9702         * annotate.c (annotate_thread_exited): Add "thread-exited"
9703         annotation.
9704
9705 2019-06-06  Tom Tromey  <tromey@adacore.com>
9706
9707         * maint.h (class scoped_command_stats): Use
9708         DISABLE_COPY_AND_ASSIGN.
9709         <print_time>: New method.
9710         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9711         print_time.
9712         (scoped_command_stats::print_time): New method.
9713
9714 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9715
9716         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9717         instructions of lengths 6 or 8 bytes.
9718
9719 2019-06-04  Pedro Alves  <palves@redhat.com>
9720
9721         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9722
9723         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9724         * breakpoint.c (condition_completer): Likewise.
9725         * cli/cli-dump.c (scan_expression): Likewise.
9726         * common/filestuff.c (mkdir_recursive): Likewise.
9727         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9728         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9729         (gdb_abspath): Likewise.
9730         * compile/compile-cplus-types.c
9731         (compile_cplus_instance::decl_name): Likewise.
9732         * completer.c (complete_explicit_location):
9733         (signal_completer, reg_or_group_completer_1): Likewise.
9734         * cp-support.c (cp_remove_params_if_any): Likewise.
9735         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9736         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9737         * infcmd.c (strip_bg_char): Likewise.
9738         * linespec.c (copy_token_string): Likewise.
9739         * mi/mi-main.c (output_cores): Likewise.
9740         * psymtab.c (psymtab_search_name):
9741         * symfile.c (test_set_ext_lang_command): Likewise.
9742         * target.c (target_fileio_read_stralloc): Likewise.
9743         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9744         * value.c (complete_internalvar): Likewise.
9745
9746 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9747
9748         Add objfile property to gdb.Type.
9749         * NEWS: Mention Python API addition.
9750         * python/py-type.c (typy_get_objfile): New method.
9751
9752 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9753
9754         * NEWS: Mention the new set|show style [title|highlight].
9755         Mention changes to "show style", "help" and "apropos".
9756
9757 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9758
9759         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9760         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9761         instead of print_help_for_command.
9762         (print_doc_of_command): New function.
9763         (help_list): Add 'apropos -v word' suggestion.
9764         (print_help_for_command): Style the command name using title style.
9765         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9766         (_initialize_cli_cmds): Describe -v in apropos_command help.
9767
9768 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9769
9770         * cli/cli-style.h (cli_style_option): Add name in constructor,
9771         add m_name class member, add constructor with intensity,
9772         add name class function.
9773         (cli_style_option::add_setshow_commands): Remove name argument.
9774         (highlight_style, title_style): New styles.
9775         * cli/cli-style.c (do_show): New function that shows a style
9776         characteristic styling the style name with itself.
9777         (set_style_name): New function.
9778         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9779         Update all callers according to the changes in cli/cli-style.h.
9780         * utils.h (fputs_highlighted): New function.
9781         * utils.c (fputs_highlighted): Likewise.
9782
9783 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9784
9785         * NEWS: Mention new pipe command and new convenience variables.
9786
9787 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9788
9789         * cli/cli-cmds.c (pipe_command): New function.
9790         (_initialize_cli_cmds): Call add_com for pipe_command.
9791         Define | as an alias for pipe.
9792         (exit_status_set_internal_vars): New function.
9793         (shell_escape): Call exit_status_set_internal_vars.
9794         cli/cli-decode.c (find_command_name_length): Recognize | as
9795         a single character command.
9796
9797 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9798
9799         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9800         top.c (execute_command_to_ui_file): New function, mostly a copy
9801         of execute_command_to_string.
9802         (execute_command_to_string): Implement by calling
9803         execute_command_to_ui_file.
9804
9805 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9806
9807         * top.h (saved_command_line): Remove declaration.
9808         * top.c (previous_saved_command_line, previous_repeat_arguments):
9809         New variables.
9810         (saved_command_line): Make static, define together with other
9811         'repeat variables'.
9812         (dont_repeat): Clear repeat_arguments.
9813         (repeat_previous, get_saved_command_line, save_command_line):
9814         New functions.
9815         (gdb_init): Initialize saved_command_line
9816         and previous_saved_command_line.
9817         * main.c (captured_main_1): Remove saved_command_line initialization.
9818         * event-top.c (handle_line_of_input): Update to use
9819         the new 'repeat' related functions instead of direct access to
9820         saved_command_line.
9821         * command.h (repeat_previous, get_saved_command_line,
9822         save_command_line): New declarations.
9823         (dont_repeat): Add comment.
9824
9825 2019-05-30  Tom Tromey  <tromey@adacore.com>
9826
9827         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9828         Fix comment.
9829         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9830
9831 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9832
9833         PR cli/24587
9834         * completer.c (complete): Initialize variable word.
9835
9836 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9837
9838         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9839         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9840         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9841         'body' is NULL to the outter 'if', protecting the '!is_define'
9842         situation as well.
9843
9844 2019-05-29  Tom Tromey  <tromey@adacore.com>
9845
9846         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9847         (dwarf_unknown): New function.
9848         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9849         (dwarf_type_encoding_name): Use dwarf_unknown.
9850
9851 2019-05-29  Tom Tromey  <tromey@adacore.com>
9852
9853         PR c++/20020:
9854         * cp-valprint.c (cp_print_value_fields): Call
9855         cp_print_static_field inside "try".
9856
9857 2019-05-29  Tom Tromey  <tromey@adacore.com>
9858
9859         * inflow.c (struct terminal_info): Add default operator=.
9860         * configure: Rebuild.
9861         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9862         -Wdeprecated-copy-dtor, -Wredundant-move.
9863
9864 2019-05-29  Tom Tromey  <tromey@adacore.com>
9865
9866         * NEWS: Add entry.
9867         * infcmd.c (print_return_value_1): Handle finish_print
9868         option.
9869         (show_print_finish): New function.
9870         (_initialize_infcmd): Add "set/show print finish" commands.
9871         * valprint.c (user_print_options): Initialize new member.
9872         * valprint.h (struct value_print_options) <finish_print>: New
9873         member.
9874
9875 2019-05-28  Tom Tromey  <tromey@adacore.com>
9876
9877         * ada-lang.c (ada_remove_Xbn_suffix)
9878         (find_old_style_renaming_symbol)
9879         (parse_old_style_renaming): Remove.
9880         (ada_find_renaming_symbol): Don't call
9881         find_old_style_renaming_symbol.
9882         (ada_is_renaming_symbol): Rename from
9883         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9884         bool.  Now static.
9885         (ada_read_var_value): Update and simplify.
9886         * ada-exp.y (write_var_or_type): Remove old code.
9887
9888 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9889
9890         PR gdb/25010
9891         * event-top.c: Remove include comment.
9892         * inflow.c (class scoped_ignore_sigttou): Move from here...
9893         * inflow.h (class scoped_ignore_sigttou): ...to here.
9894         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9895         * top.c:  Remove include comment.
9896
9897 2019-05-27  Tom Tromey  <tom@tromey.com>
9898
9899         * NEWS: Fix typo.
9900
9901 2019-05-22  Tom Tromey  <tromey@adacore.com>
9902
9903         * target.c (target_follow_exec): Constify parameter.
9904         * target-delegates.c: Rebuild.
9905         * remote.c (remote_target::follow_exec): Constify parameter.
9906         * infrun.c (follow_exec): Constify parameter.
9907         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9908         (target_follow_exec): Likewise.
9909
9910 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9911
9912         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9913         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9914
9915 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9916
9917         * NEWS: Add debugredirect and testsuite sections.
9918
9919 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9920
9921         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9922         target descriptions using exclusively floating point register name
9923         aliases.
9924
9925 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9926
9927         PR gdb/18644:
9928         * f-lang.c (build_fortran_types): Handle the case where
9929         gdbarch_floatformat_for_type returns a nullptr.
9930
9931 2019-05-21  Tom de Vries  <tdevries@suse.de>
9932
9933         PR cli/24587
9934         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9935
9936 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9937
9938         PR gdb/18644:
9939         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9940         16-byte floats.
9941         * i386-tdep.c (i386_floatformat_for_type): Use
9942         floatformats_ia64_quad for the 16-byte floating point component
9943         within a fortran 32-byte complex number.
9944
9945 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9946
9947         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9948         delete default constructor.
9949         (find_partial_die): Update to return const struct.
9950         (partial_die_parent_scope): Move variable declaration into scope
9951         of its use and change its type to auto.
9952         (guess_partial_die_structure_name): Likewise.
9953         (partial_die_info::fixup): Likewise.
9954
9955 2019-05-17  Tom Tromey  <tromey@adacore.com>
9956
9957         * source.c (find_and_open_source): Remove cast.
9958
9959 2019-05-17  Tom Tromey  <tromey@adacore.com>
9960
9961         * annotate.c (annotate_source): Make "filename" const.
9962         * annotate.h (annotate_source): Use const.
9963
9964 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9965
9966         * disasm.c (set_disassembler_options): Send errors to stderr.
9967
9968 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9969
9970         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9971         (cli_interp_base::set_logging): Check debug_redirect.
9972         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9973         * cli/cli-logging.c (debug_redirect): Add static variable.
9974         (pop_output_files): Add default param.
9975         (handle_redirections): Print debug setting.
9976         (show_logging_command): Likewise.
9977         (_initialize_cli_logging): Add debugredirect command.
9978         * interps.c (current_interp_set_logging): Add debug_redirect
9979         parameter.
9980         * interps.h (set_logging): Add debug_redirect parameter.
9981         (current_interp_set_logging): Likewise.
9982         * mi/mi-common.h: Likewise.
9983         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9984
9985 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9986             Tom Tromey  <tromey@adacore.com>
9987
9988         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9989         directly.
9990         * cli/cli-interp.h (make_logging_output): Remove declaration.
9991         * cli/cli-logging.c (make_logging_output): Remove function.
9992         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9993         directly.
9994         * ui-file.c (tee_file::tee_file): Remove bools.
9995         (tee_file::~tee_file): Remove deletes.
9996         * ui-file.h (tee_file): Remove bools.
9997
9998 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9999
10000         * mi/mi-cmds.h (mi_cmd_complete): New function.
10001         * mi/mi-main.c (mi_cmd_complete): Likewise.
10002         * mi/mi-cmds.c: Define new MI command -complete.
10003         * NEWS: Mention new -complete command.
10004
10005 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10006
10007         * completer.h (complete): New function.
10008         * completer.c (complete): Likewise.
10009         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10010         function defined in completer.h.
10011
10012 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10013
10014         * MAINTAINERS (Write After Approval): Add myself.
10015
10016 2019-05-17  Tom de Vries  <tdevries@suse.de>
10017
10018         PR gdb/24094
10019         * dwarf2read.c (struct cu_partial_die_info): New struct.
10020         (find_partial_die): Return cu_partial_die_info.
10021         (partial_die_parent_scope, guess_partial_die_structure_name)
10022         (partial_die_info::fixup): Handle new return type of find_partial_die.
10023
10024 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10025
10026         PR breakpoints/24541
10027         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10028         "std::string", simplifying the algorithm.
10029
10030 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10031
10032         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10033         (stap_static_probe_ops::get_probes): Likewise.
10034
10035 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10036
10037         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10038         '-')" and "else if".
10039         (stap_parse_single_operand): Join checks for
10040         "gdbarch_stap_parse_special_token_p" and
10041         "gdbarch_stap_parse_special_token" in the same "if" statement.
10042         Invert check when verifying for operation on register
10043         displacement.
10044
10045 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10046
10047         * stap-probe.c (stap_get_opcode): Update comment.
10048         (stap_get_expected_argument_type): Likewise.
10049         (handle_stap_probe): Likewise.
10050
10051 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10052
10053         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10054         return type to 'bool'.  Adjust comment.  Use 'bool' when
10055         appropriate.
10056         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10057         * stap-probe.c (stap_parse_argument_1): Likewise.
10058         (stap_is_operator): Likewise.
10059         (stap_is_generic_prefix): Likewise.
10060         (stap_is_register_prefix): Likewise.
10061         (stap_is_register_indirection_prefix): Likewise.
10062         (stap_is_integer_prefix): Likewise.
10063         (stap_generic_check_suffix): Likewise.
10064         (stap_check_integer_suffix): Likewise.
10065         (stap_check_register_suffix): Likewise.
10066         (stap_check_register_indirection_suffix): Likewise.
10067         (stap_parse_register_operand): Likewise.
10068         (stap_parse_single_operand): Likewise.
10069         (stap_parse_argument_1): Likewise.
10070         (stap_probe::get_argument_count): Likewise.
10071         (stap_is_operator): Likewise.
10072
10073 2019-05-16  Tom Tromey  <tromey@adacore.com>
10074
10075         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10076         keyword to foreach.
10077
10078 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10079
10080         * linux-thread-db.c (try_thread_db_load_1): Change return type
10081         to bool.
10082         (try_thread_db_load): Likewise.
10083         (try_thread_db_load_from_pdir_1): Likewise.
10084         (try_thread_db_load_from_pdir): Likewise.
10085         (try_thread_db_load_from_sdir): Likewise.
10086         (try_thread_db_load_from_dir): Likewise.
10087         (thread_db_load_search): Likewise.
10088         (has_libpthread): Likewise.
10089         (thread_db_load): Likewise.
10090
10091 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10092
10093         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10094         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10095         NULL, and complain/return if that's the case.
10096
10097 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10098
10099         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10100         (advance, posn, abstract_read_memory): New functions.
10101         [struct mem_read_abstraction]: New struct.
10102         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10103
10104 2019-05-14  Tom Tromey  <tromey@adacore.com>
10105
10106         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10107         value is not lval_memory.
10108
10109 2019-05-14  Tom Tromey  <tromey@adacore.com>
10110
10111         * solib.c (info_sharedlibrary_command): Style the file name.
10112
10113 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10114
10115         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10116         (aarch64_vnv_type): Likewise.
10117         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10118         * common/tdesc.c: Likewise.
10119         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10120         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10121         * features/aarch64-fpu.xml: Add ieee half view.
10122         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10123         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10124         * gdbtypes.h (struct builtin_type): Likewise.
10125         (struct objfile_type): Likewise.
10126
10127 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10128
10129         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10130         typo.
10131         * location.h (string_to_event_location): Likewise.
10132
10133 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10134
10135         GDB 8.3 released.
10136
10137 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10138
10139         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10140         New variable declaration.
10141         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10142         New variable.
10143         (print_one_breakpoint): Use ui_out::test_flags and new global
10144         variable to compute use_fixed_output.
10145         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10146         Remove.
10147         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10148         (mi_multi_location_breakpoint_output_fixed): Remove.
10149         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10150         new variable.
10151         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10152         fix_multi_location_breakpoint_output flag if version >= 3.
10153         * ui-out.h (enum ui_out_flag)
10154         <fix_multi_location_breakpoint_output>: New enumerator.
10155
10156 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10157
10158         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10159
10160 2019-05-10  Tom Tromey  <tromey@adacore.com>
10161
10162         * ada-lang.c (catch_ada_completer): New function.
10163         (_initialize_ada_language): Use it.
10164
10165 2019-05-10  Tom Tromey  <tromey@adacore.com>
10166
10167         * thread.c (print_thread_info): Make "requested_threads" const.
10168         * gdbthread.h (print_thread_info): Make "requested_threads"
10169         const.
10170         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10171         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10172
10173 2019-05-08  Tom Tromey  <tom@tromey.com>
10174
10175         * gdbtypes.c (objfile_type_data): Change type.
10176         (objfile_type, _initialize_gdbtypes): Update.
10177
10178 2019-05-08  Tom Tromey  <tom@tromey.com>
10179
10180         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10181         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10182         (_initialize_dwarf2_frame): Update.
10183
10184 2019-05-08  Tom Tromey  <tom@tromey.com>
10185
10186         * objc-lang.c (objc_objfile_data): Change type.
10187         (find_methods): Update.
10188         (_initialize_objc_lang): Remove.
10189
10190 2019-05-08  Tom Tromey  <tom@tromey.com>
10191
10192         * stabsread.c (rs6000_builtin_type_data): Change type.
10193         (rs6000_builtin_type, _initialize_stabsread): Update.
10194
10195 2019-05-08  Tom Tromey  <tom@tromey.com>
10196
10197         * mips-tdep.c (mips_pdr_data): Remove.
10198         (_initialize_mips_tdep): Update.
10199
10200 2019-05-08  Tom Tromey  <tom@tromey.com>
10201
10202         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10203         (hppa_init_objfile_priv_data, read_unwind_info)
10204         (find_unwind_entry, _initialize_hppa_tdep): Update.
10205
10206 2019-05-08  Tom Tromey  <tom@tromey.com>
10207
10208         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10209         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10210         on obstack.
10211         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10212
10213 2019-05-08  Tom Tromey  <tom@tromey.com>
10214
10215         * mdebugread.c (basic_type_data): Change type.
10216         (basic_type, _initialize_mdebugread): Update.
10217
10218 2019-05-08  Tom Tromey  <tom@tromey.com>
10219
10220         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10221
10222 2019-05-08  Tom Tromey  <tom@tromey.com>
10223
10224         * nto-tdep.c (nto_inferior_data_reg): Change type.
10225         (nto_inferior_data): Update.
10226         (nto_inferior_data_cleanup, nto_new_inferior_data)
10227         (_initialize_nto_tdep): Remove.
10228         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10229
10230 2019-05-08  Tom Tromey  <tom@tromey.com>
10231
10232         * ada-lang.c (struct ada_inferior_data): Add initializers.
10233         (ada_inferior_data): Change type.
10234         (ada_inferior_data_cleanup): Remove.
10235         (get_ada_inferior_data, ada_inferior_exit)
10236         (struct ada_pspace_data): Add initializers, destructor.
10237         (ada_pspace_data_handle): Change type.
10238         (get_ada_pspace_data): Update.
10239         (ada_pspace_data_cleanup): Remove.
10240
10241 2019-05-08  Tom Tromey  <tom@tromey.com>
10242
10243         * coffread.c (struct coff_symfile_info): Add initializers.
10244         (coff_objfile_data_key): Move lower.  Change type.
10245         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10246         Update.
10247         (coff_free_info): Remove.
10248
10249 2019-05-08  Tom Tromey  <tom@tromey.com>
10250
10251         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10252         (fbsd_pspace_data_handle): Move lower.  Change type.
10253         (get_fbsd_pspace_data): Update.
10254         (fbsd_pspace_data_cleanup): Remove.
10255         (_initialize_fbsd_tdep): Update.
10256
10257 2019-05-08  Tom Tromey  <tom@tromey.com>
10258
10259         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10260         (get_ada_tasks_pspace_data): Update.
10261         (ada_tasks_pspace_data_cleanup): Remove.
10262         (_initialize_tasks): Update.
10263         (ada_tasks_inferior_data_handle): Change type.
10264         (get_ada_tasks_inferior_data): Update.
10265         (ada_tasks_inferior_data_cleanup): Remove.
10266         (struct ada_tasks_pspace_data): Add initializers.
10267
10268 2019-05-08  Tom Tromey  <tom@tromey.com>
10269
10270         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10271         * symfile-debug.c (debug_sym_get_probes): Change type.
10272         * stap-probe.c (handle_stap_probe):
10273         (stap_static_probe_ops::get_probes): Change type.
10274         * probe.h (class static_probe_ops) <get_probes>: Change type.
10275         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10276         (parse_probes_in_pspace): Update.
10277         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10278         Update.
10279         (any_static_probe_ops::get_probes): Change type.
10280         * elfread.c (elfread_data): New typedef.
10281         (probe_key): Change type.
10282         (elf_get_probes): Likewise.  Update.
10283         (probe_key_free): Remove.
10284         (_initialize_elfread): Update.
10285         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10286         Change type.
10287         (dtrace_process_dof_probe, dtrace_process_dof)
10288         (dtrace_static_probe_ops::get_probe): Change type.
10289
10290 2019-05-08  Tom Tromey  <tom@tromey.com>
10291
10292         * xcoffread.c (struct xcoff_symfile_info): Rename from
10293         coff_symfile_info.  Add initializers.
10294         (xcoff_objfile_data_key): Move lower.  Change type.
10295         (XCOFF_DATA): Rewrite.
10296         (xcoff_free_info): Remove.
10297         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10298         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10299         (xcoff_initial_scan): Update.
10300
10301 2019-05-08  Tom Tromey  <tom@tromey.com>
10302
10303         * solib-svr4.c (struct svr4_info): Add initializers and
10304         destructor.
10305         <probes_table>: Now an htab_up.
10306         (solib_svr4_pspace_data): Change type.
10307         (free_probes_table): Simplify.
10308         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10309         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10310         (probes_table_remove_objfile_probes, register_solib_event_probe)
10311         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10312         (_initialize_svr4_solib): Update.
10313
10314 2019-05-08  Tom Tromey  <tom@tromey.com>
10315
10316         * remote.c (remote_pspace_data): Change type.
10317         (remote_pspace_data_cleanup): Remove.
10318         (get_remote_exec_file, set_pspace_remote_exec_file)
10319         (_initialize_remote): Update.
10320
10321 2019-05-08  Tom Tromey  <tom@tromey.com>
10322
10323         * breakpoint.c (breakpoint_objfile_key): Change type.
10324         (get_breakpoint_objfile_data): Update.
10325         (free_breakpoint_objfile_data): Remove.
10326         (_initialize_breakpoint): Update.
10327
10328 2019-05-08  Tom Tromey  <tom@tromey.com>
10329
10330         * linux-tdep.c (struct linux_info): Add initializers.
10331         (linux_inferior_data): Move.  Change type.
10332         (invalidate_linux_cache_inf): Update.
10333         (linux_inferior_data_cleanup): Remove.
10334         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10335
10336 2019-05-08  Tom Tromey  <tom@tromey.com>
10337
10338         * auxv.c (auxv_inferior_data): Move.  Change type.
10339         (auxv_inferior_data_cleanup): Remove.
10340         (invalidate_auxv_cache_inf): Rewrite.
10341         (get_auxv_inferior_data, _initialize_auxv): Update.
10342
10343 2019-05-08  Tom Tromey  <tom@tromey.com>
10344
10345         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10346         (symfile_debug_objfile_data_key): Change type.
10347         (symfile_debug_installed, debug_qf_has_symbols)
10348         (debug_qf_find_last_source_symtab)
10349         (debug_qf_forget_cached_source_info)
10350         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10351         (debug_qf_print_stats, debug_qf_dump)
10352         (debug_qf_expand_symtabs_for_function)
10353         (debug_qf_expand_all_symtabs)
10354         (debug_qf_expand_symtabs_with_fullname)
10355         (debug_qf_map_matching_symbols)
10356         (debug_qf_expand_symtabs_matching)
10357         (debug_qf_find_pc_sect_compunit_symtab)
10358         (debug_qf_map_symbol_filenames)
10359         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10360         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10361         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10362         (debug_sym_read_linetable, debug_sym_relocate): Update.
10363         (symfile_debug_free_objfile): Remove.
10364         (install_symfile_debug_logging, _initialize_symfile_debug):
10365         Update.
10366
10367 2019-05-08  Tom Tromey  <tom@tromey.com>
10368
10369         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10370         allocate_on_obstack.
10371         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10372         (get_dwarf2_per_objfile): Update.
10373         (set_dwarf2_per_objfile): Remove.
10374         (dwarf2_has_info, dwarf2_get_section_info): Update.
10375         (dwarf2_free_objfile): Remove.
10376         (_initialize_dwarf2_read): Update.
10377
10378 2019-05-08  Tom Tromey  <tom@tromey.com>
10379
10380         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10381         initializers.
10382         <unsupported_script_warning_printed,
10383         script_not_found_warning_printed>: Now bool.
10384         (auto_load_pspace_data): Change type.
10385         (~auto_load_pspace_info): Rename from
10386         auto_load_pspace_data_cleanup.
10387         (get_auto_load_pspace_data, init_loaded_scripts_info)
10388         (clear_section_scripts, maybe_print_unsupported_script_warning)
10389         (maybe_print_script_not_found_warning, _initialize_auto_load):
10390         Update.
10391
10392 2019-05-08  Tom Tromey  <tom@tromey.com>
10393
10394         * objfiles.c (objfile_pspace_info): Add destructor and
10395         initializers.
10396         (objfiles_pspace_data): Change type.
10397         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10398         (get_objfile_pspace_data): Update.
10399         (objfiles_bfd_data): Change type.
10400         (get_objfile_bfd_data): Update.
10401         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10402
10403 2019-05-08  Tom Tromey  <tom@tromey.com>
10404
10405         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10406         Change type.
10407         (get_catch_syscall_inferior_data): Update.
10408         (catch_syscall_inferior_data_cleanup): Remove.
10409         (_initialize_break_catch_syscall): Update.
10410
10411 2019-05-08  Tom Tromey  <tom@tromey.com>
10412
10413         * inflow.c (struct terminal_info): Add destructor and
10414         initializers.
10415         (inflow_inferior_data): Change type.
10416         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10417         (get_inflow_inferior_data, inflow_inferior_exit)
10418         (swap_terminal_info, _initialize_inflow): Update.
10419
10420 2019-05-08  Tom Tromey  <tom@tromey.com>
10421
10422         * target-dcache.c (target_dcache_cleanup): Remove.
10423         (target_dcache_aspace_key): Change type.
10424         (target_dcache_init_p, target_dcache_invalidate)
10425         (target_dcache_get, target_dcache_get_or_init)
10426         (_initialize_target_dcache): Update.
10427         * dcache.h (struct dcache_deleter): New.
10428
10429 2019-05-08  Tom Tromey  <tom@tromey.com>
10430
10431         * symtab.c (struct symbol_cache): Add destructor and
10432         initializers.
10433         (symbol_cache_key): Move.  Change type.
10434         (make_symbol_cache, free_symbol_cache): Remove.
10435         (get_symbol_cache): Update.
10436         (symbol_cache_cleanup): Remove.
10437         (ALL_PSPACES, symbol_cache_flush)
10438         (maintenance_print_symbol_cache)
10439         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10440         Update.
10441
10442 2019-05-08  Tom Tromey  <tom@tromey.com>
10443
10444         * symtab.c (struct main_info): Add destructor and initializers.
10445         (main_progspace_key): Move.  Change type.
10446         (get_main_info): Update.
10447         (main_info_cleanup): Remove.
10448         (_initialize_symtab): Update.
10449
10450 2019-05-08  Tom Tromey  <tom@tromey.com>
10451
10452         * registry.h (DECLARE_REGISTRY): Define the _key class.
10453
10454 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10455
10456         * NEWS: Merge two 'New commands' sections.
10457
10458 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10459
10460         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10461         parameter and use Ada language definition instead.
10462         (ada_val_print_ptr): Remove unused language parameter.
10463         (ada_val_print_num): Remove language parameter and use Ada language
10464         definition instead.
10465         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10466         parameter.
10467         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10468         parameter and use Ada language definition instead.
10469         (ada_val_print_1): Update all ada_val_print_xxx calls.
10470         Remove language parameter.
10471         (ada_val_print): Update ada_val_print_1 call.
10472
10473 2019-05-08  Tom Tromey  <tromey@adacore.com>
10474
10475         * remote.c (remote_hw_watchpoint_limit)
10476         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10477         Now static.
10478
10479 2019-05-08  Tom Tromey  <tromey@adacore.com>
10480
10481         * maint.c (_initialize_maint_cmds): Move initialization code to
10482         remote.c.
10483         (watchdog, show_watchdog): Move to remote.c.
10484         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10485         "watchdog" static.
10486         (_initialize_remote): Move initialization code from maint.c.
10487         * defs.h (watchdog): Don't declare.
10488
10489 2019-05-08  Tom Tromey  <tromey@adacore.com>
10490
10491         * tui/tui-interp.c: Include main.h.
10492         * interps.c: Include main.h.
10493         * main.h (interpreter_p): Declare.
10494         * defs.h (interpreter_p): Don't declare.
10495
10496 2019-05-08  Tom Tromey  <tromey@adacore.com>
10497
10498         * dwarf2loc.c: Include dwarf2read.h.
10499         * defs.h (read_unsigned_leb128): Don't declare.
10500         * dwarf2read.h (read_unsigned_leb128): Declare.
10501
10502 2019-05-08  Tom Tromey  <tromey@adacore.com>
10503
10504         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10505         method.
10506
10507 2019-05-08  Tom Tromey  <tromey@adacore.com>
10508
10509         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10510         when no wrap column is set.
10511
10512 2019-05-08  Tom Tromey  <tromey@adacore.com>
10513
10514         * c-lang.c (c_get_string): Handle non-C-style arrays.
10515
10516 2019-05-08  Tom Tromey  <tromey@adacore.com>
10517
10518         * typeprint.c (print_offset_data::update): Print the bit offset,
10519         not the number of bits remaining.
10520
10521 2019-05-08  Tom Tromey  <tromey@adacore.com>
10522
10523         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10524         padding at end of comment.
10525
10526 2019-05-08  Tom Tromey  <tromey@adacore.com>
10527
10528         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10529         Compare main types.
10530
10531 2019-05-06  Tom Tromey  <tom@tromey.com>
10532
10533         * common/scoped_mmap.c: Include common-defs.h.
10534         * common/scoped_mmap.h: Don't include config.h.
10535
10536 2019-05-04  Tom Tromey  <tom@tromey.com>
10537
10538         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10539         (struct aarch64_call_info): Add initializers.
10540         <si>: Now a std::vector.
10541         (pass_on_stack, aarch64_push_dummy_call): Update.
10542
10543 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10544             Tom Tromey  <tom@tromey.com>
10545
10546         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10547         (ppc_threads): Now a std::vector.  Now static.
10548         (hwdebug_find_thread_points_by_tid)
10549         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10550         Update.
10551
10552 2019-05-04  Tom Tromey  <tom@tromey.com>
10553
10554         * arc-tdep.c (arc_tdesc_init): Return bool.
10555
10556 2019-05-04  Tom Tromey  <tom@tromey.com>
10557
10558         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10559         Use gdb_assert_not_reached.
10560
10561 2019-05-04  Tom Tromey  <tom@tromey.com>
10562
10563         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10564         "false".
10565
10566 2019-05-04  Tom Tromey  <tom@tromey.com>
10567
10568         * arc-tdep.c (arc_tdesc_init): Use bool.
10569
10570 2019-05-04  Tom Tromey  <tom@tromey.com>
10571
10572         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10573
10574 2019-05-04  Tom Tromey  <tom@tromey.com>
10575
10576         * cli/cli-cmds.c (valid_command_p): Return bool.
10577
10578 2019-05-04  Tom Tromey  <tom@tromey.com>
10579
10580         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10581         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10582
10583 2019-05-04  Raul Tambre  <raul@tambre.ee>
10584
10585         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10586         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10587         operator for comparison.
10588
10589 2019-05-04  Tom Tromey  <tom@tromey.com>
10590
10591         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10592         (lookup_partial_symbol, print_partial_symbols)
10593         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10594         (psymbol_compare): Update.
10595         (add_psymbol_to_bcache): Clear the entire psymbol.
10596         (maintenance_check_psymtabs): Update.
10597         * psympriv.h (struct partial_symbol): Don't derive from
10598         general_symbol_info.
10599         <obj_section, unrelocated_address, address,
10600         set_unrelocated_address>: Update.
10601         <ginfo>: New member.
10602         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10603         (debug_names::write_psymbols): Update.
10604
10605 2019-05-04  Tom de Vries  <tdevries@suse.de>
10606
10607         * contrib/cc-with-tweaks.sh: Support -n arg.
10608
10609 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10610
10611         * corelow.c (core_target::detach): Ensure frame cache and
10612         register caches are cleared.
10613         inferior.c (exit_inferior_1): Likewise.
10614
10615 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10616             Tom Tromey  <tom@tromey.com>
10617
10618         * dictionary.c (collate_pending_symbols_by_language): Remove
10619         "struct" from foreach.
10620         * symtab.c (lookup_global_symbol_from_objfile)
10621         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10622         foreach.
10623         * ser-tcp.c (net_open): Remove "struct" from foreach.
10624         * objfiles.c (objfile_relocate, objfile_rebase)
10625         (objfile_has_symbols): Remove "struct" from foreach.
10626         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10627         from foreach.
10628         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10629         foreach.
10630         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10631         "struct" from foreach.
10632         * ada-lang.c (create_excep_cond_exprs)
10633         (ada_exception_catchpoint_cond_string): Remove "struct" from
10634         foreach.
10635
10636 2019-05-03  Tom Tromey  <tromey@adacore.com>
10637
10638         * ada-exp.y (convert_char_literal): Check suffix of each
10639         enumerator.
10640
10641 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10642
10643         PR ada/21406:
10644         * ada-exp.y (yywrap): Don't define.
10645         * ada-lex.l (%option): Add noyywrap
10646         (yywrap): Remove.
10647
10648 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10649
10650         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10651         _WIN32_WINNT to the XP level, unless already defined to a higher
10652         level.
10653
10654         * unittests/parse-connection-spec-selftests.c:
10655         * ser-tcp.c:
10656         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10657         override.
10658
10659         * symfile.c (find_separate_debug_file): Remove colon from the
10660         drive spec of DOS/Windows file names of the target, so that the
10661         file name produced from DEBUGDIR and the target's directory will
10662         be valid on DOS/Windows systems.
10663
10664 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10665
10666         * rust-lang.c (val_print_struct): Handle printing structures
10667         containing strings.
10668
10669 2019-05-02  Tom Tromey  <tromey@adacore.com>
10670
10671         * valarith.c (_initialize_valarith): Remove.
10672
10673 2019-05-01  Tom Tromey  <tromey@adacore.com>
10674
10675         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10676         bitfields.
10677
10678 2019-05-01  Tom Tromey  <tromey@adacore.com>
10679
10680         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10681         for big-endian copies.
10682
10683 2019-04-30  Ali Tamur  <tamur@google.com>
10684         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10685         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10686         (read_3_bytes): New function.
10687
10688 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10689
10690         * windows-nat.c (main_thread_id): Delete.
10691         (handle_output_debug_string): Replace main_thread_id by
10692         current_event.dwThreadId.
10693         (fake_create_process): Likewise.
10694         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10695         Do not set main_thread_id.
10696         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10697         current_event.dwThreadId.
10698         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10699
10700 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10701
10702         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10703         Use current_event.dwThreadId instead of main_thread_id.
10704
10705 2019-04-30  Tom Tromey  <tromey@adacore.com>
10706
10707         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10708         (create_excep_cond_exprs): Iterate over program spaces.
10709         (ada_exception_catchpoint_cond_string): Examine all minimal
10710         symbols for exception types.
10711
10712 2019-04-30  Tom Tromey  <tromey@adacore.com>
10713
10714         PR c++/24470:
10715         * dwarf2read.c (process_structure_scope): Handle case where type
10716         has template parameters but no symbol was created.
10717
10718 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10719             Chris January  <chris.january@arm.com>
10720
10721         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10722         qualifier.
10723         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10724
10725 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10726
10727         * f-typeprint.c (f_print_type): Update rules for printing
10728         whitespace.
10729         (f_type_print_varspec_suffix): Likewise.
10730
10731 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10732             Chris January  <chris.january@arm.com>
10733
10734         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10735         function arguments.
10736
10737 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10738
10739         * f-lang.c (build_fortran_types): Change name of void type to
10740         lower case.
10741         * f-typeprint.c (f_type_print_base): Print the name of the void
10742         type, rather than a fixed string.
10743         * f-valprint.c (f_decorations): Use lower case void string.
10744
10745 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10746             Chris January  <chris.january@arm.com>
10747
10748         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10749         types for Fortran.
10750
10751 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10752             Chris January  <chris.january@arm.com>
10753             David Lecomber  <david.lecomber@arm.com>
10754
10755         * f-exp.y (BINOP_INTRINSIC): New token.
10756         (exp): New parser rule handling BINOP_INTRINSIC.
10757         (f77_keywords): Add new builtin procedures.
10758         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10759         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10760         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10761         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10762         (print_unop_subexp_f): New function.
10763         (print_binop_subexp_f): New function.
10764         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10765         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10766         (dump_subexp_body_f): Likewise.
10767         (operator_check_f): Likewise.
10768         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10769         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10770
10771 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10772
10773         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10774         UNOP_KIND.
10775         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10776         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10777         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10778         (operator_length_f): New fuction.
10779         (print_subexp_f): New function.
10780         (op_name_f): New function.
10781         (dump_subexp_body_f): New function.
10782         (operator_check_f): New function.
10783         (exp_descriptor_f): Replace standard expression handling functions
10784         with new functions.
10785         * gdb/fortran-operator.def: New file.
10786         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10787         * gdb/std-operator.def: Remove UNOP_KIND.
10788
10789 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10790
10791         * std-operator.def: Remove unbalanced, stray double quote
10792         character.
10793
10794 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10795             Chris January  <chris.january@arm.com>
10796             Daniel Everett  <daniel.everett@arm.com>
10797             Nick Forrington  <nick.forrington@arm.com>
10798             Richard Bunt  <richard.bunt@arm.com>
10799
10800         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10801         of depth when printing anonymous structs or unions.
10802         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10803         Don't print either the top-level value, or the children if the
10804         max-depth is exceeded.
10805         (ppscm_print_children): When printing the key of a map, allow one
10806         extra level of depth.
10807         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10808         print either the top-level value, or the children if the max-depth
10809         is exceeded.
10810         (print_children): When printing the key of a map, allow one extra
10811         level of depth.
10812         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10813         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10814         (user_print_options): Initialise max_depth field.
10815         (val_print_scalar_or_string_type_p): New function.
10816         (val_print): Check to see if the max depth has been reached.
10817         (val_print_check_max_depth): Define new function.
10818         (show_print_max_depth): New function.
10819         (_initialize_valprint): Add 'print max-depth' option.
10820         * valprint.h (struct value_print_options) <max_depth>: New field.
10821         (val_print_check_max_depth): Declare new function.
10822         * NEWS: Document new feature.
10823
10824 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10825
10826         * ada-lang.c (ada_language_defn): Initialise new field.
10827         * c-lang.c (c_is_string_type_p): New function.
10828         (c_language_defn): Initialise new field.
10829         (cplus_language_defn): Initialise new field.
10830         (asm_language_defn): Initialise new field.
10831         (minimal_language_defn): Initialise new field.
10832         * c-lang.h (c_is_string_type_p): Declare new function.
10833         * d-lang.c (d_language_defn): Initialise new field.
10834         * f-lang.c (f_is_string_type_p): New function.
10835         (f_language_defn): Initialise new field.
10836         * go-lang.c (go_is_string_type_p): New function.
10837         (go_language_defn): Initialise new field.
10838         * language.c (default_is_string_type_p): New function.
10839         (unknown_language_defn): Initialise new field.
10840         (auto_language_defn): Initialise new field.
10841         * language.h (struct language_defn) <la_is_string_type_p>: New
10842         member variable.
10843         (default_is_string_type_p): Declare new function.
10844         * m2-lang.c (m2_language_defn): Initialise new field.
10845         * objc-lang.c (objc_language_defn): Initialise new field.
10846         * opencl-lang.c (opencl_language_defn): Initialise new field.
10847         * p-lang.c (pascal_is_string_type_p): New function.
10848         (pascal_language_defn): Initialise new field.
10849         * rust-lang.c (rust_is_string_type_p): New function.
10850         (rust_language_defn): Initialise new field.
10851
10852 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10853
10854         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10855         New field.
10856         * ada-lang.c (ada_language_defn): Initialise new field.
10857         * c-lang.c (c_language_defn): Likewise.
10858         (cplus_language_defn): Likewise.
10859         (asm_language_defn): Likewise.
10860         (minimal_language_defn): Likewise.
10861         * d-lang.c (d_language_defn): Likewise.
10862         * f-lang.c (f_language_defn): Likewise.
10863         * go-lang.c (go_language_defn): Likewise.
10864         * language.c (unknown_language_defn): Likewise.
10865         (auto_language_defn): Likewise.
10866         * m2-lang.c (m2_language_defn): Likewise.
10867         * objc-lang.c (objc_language_defn): Likewise.
10868         * opencl-lang.c (opencl_language_defn): Likewise.
10869         * p-lang.c (pascal_language_defn): Likewise.
10870         * rust-lang.c (rust_language_defn): Likewise.
10871
10872 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10873
10874         * ada-lang.c (ada_is_character_type): Change return type to bool.
10875         (ada_is_string_type): Likewise.
10876         * ada-lang.h (ada_is_character_type): Update declaration
10877         (ada_is_string_type): Likewise.
10878
10879 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10880
10881         Support style in 'frame|thread apply'
10882
10883         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10884         * record.c (record_start, record_stop): Update callers of
10885         execute_command_to_string with false.
10886         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10887         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10888         methods.
10889         (class string_file): New constructor with term_out parameter.
10890         Override methods term_out and can_emit_style_escape.  New member
10891         term_out.
10892         (class stdio_file): Override can_emit_style_escape.
10893         (class tee_file): Override term_out and can_emit_style_escape.
10894         * utils.h (can_emit_style_escape): Remove.
10895         * utils.c (can_emit_style_escape): Likewise.
10896         Update all callers of can_emit_style_escape (SOMESTREAM) to
10897         SOMESTREAM->can_emit_style_escape.
10898         * source-cache.c (source_cache::get_source_lines): Likewise.
10899         * stack.c (frame_apply_command_count): Call execute_command_to_string
10900         passing the term_out characteristic of the current gdb_stdout.
10901         * thread.c (thr_try_catch_cmd): Likewise.
10902         * top.c (execute_command_to_string): pass term_out parameter
10903         to construct the string_file for the command output.
10904         * ui-file.c (term_cli_styling): New function (most code moved
10905         from utils.c can_emit_style_escape).
10906         (string_file::string_file, string_file::can_emit_style_escape,
10907         stdio_file::can_emit_style_escape, tee_file::term_out,
10908         tee_file::can_emit_style_escape): New functions.
10909
10910 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10911
10912         * NEWS: Mention the new set|show may-call-functions.
10913         * infcall.c (may_call_functions_p): New variable.
10914         (show_may_call_functions_p): New function.
10915         (call_function_by_hand_dummy): Throws an error if not
10916         may-call-functions.
10917         (_initialize_infcall): Call add_setshow_boolean_cmd for
10918         may-call-functions.
10919
10920 2019-04-25  Keith Seitz  <keiths@redhat.com>
10921
10922         PR c++/24367
10923         * cp-support.c (inspect_type): Don't attempt substitutions
10924         of symbol with the same name.
10925
10926 2019-04-25  Tom Tromey  <tromey@adacore.com>
10927
10928         PR gdb/24475:
10929         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10930         static.
10931
10932 2019-04-25  Tom Tromey  <tromey@adacore.com>
10933
10934         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10935         rvalue reference.
10936         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10937         (gdb_xml_parser::parse): Use std::move.
10938         * python/python-internal.h (gdbpy_convert_exception): Take a const
10939         reference.
10940         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10941         std::move.
10942         * python/py-utils.c (gdbpy_convert_exception): Take a const
10943         reference.
10944         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10945         Use std::move.
10946         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10947         Use std::move.
10948         * mi/mi-main.c (mi_print_exception): Take a const reference.
10949         * main.c (handle_command_errors): Take a const reference.
10950         * linespec.c (parse_linespec): Use std::move.
10951         * infcall.c (run_inferior_call): Use std::move.
10952         (call_function_by_hand_dummy): Use std::move.
10953         * exec.c (try_open_exec_file): Use std::move.
10954         * exceptions.h (exception_print, exception_fprintf)
10955         (exception_print_same): Update.
10956         * exceptions.c (print_exception, exception_print)
10957         (exception_fprintf, exception_print_same): Change parameters to
10958         const reference.
10959         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10960         * common/new-op.c: Use std::move.
10961         * common/common-exceptions.h (struct gdb_exception): Add move
10962         constructor.
10963         (struct gdb_exception_error, struct gdb_exception_quit, struct
10964         gdb_quit_bad_alloc): Change constructor to move constructor.
10965         (throw_exception): Change parameter to rvalue reference.
10966         * common/common-exceptions.c (throw_exception): Take rvalue
10967         reference.
10968         * cli/cli-interp.c (safe_execute_command): Use std::move.
10969         * breakpoint.c (insert_bp_location, location_to_sals): Use
10970         std::move.
10971
10972 2019-04-25  Tom Tromey  <tromey@adacore.com>
10973
10974         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10975         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10976         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10977         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10978         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10979         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10980         guile/scm-value.c: Use unpack.
10981         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10982         gdbscm_gdb_exception.
10983         (gdbscm_throw_gdb_exception): Likewise.
10984         (struct gdbscm_gdb_exception): New.
10985         (unpack): New function.
10986         (gdbscm_wrap): Use unpack.
10987
10988 2019-04-25  Tom Tromey  <tromey@adacore.com>
10989
10990         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10991         (gdb_rl_callback_handler): Use std::move.
10992         * common/common-exceptions.h (struct gdb_exception): Add move
10993         assignment operator.
10994         (throw_exception_sjlj): Change "exception" to const reference.
10995         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10996         (throw_exception_sjlj): Change "exception" to const reference.
10997
10998 2019-04-25  Tom Tromey  <tromey@adacore.com>
10999
11000         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11001         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11002         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11003         Update.
11004         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11005         Update.
11006         * mi/mi-interp.c (mi_interp::exec): Update.
11007         * linespec.c (parse_linespec): Update.
11008         * infcall.c (run_inferior_call): Update.
11009         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11010         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11011         (gdbscm_lookup_global_symbol): Update.
11012         * guile/scm-param.c (gdbscm_parameter_value): Update.
11013         * guile/scm-frame.c (gdbscm_frame_read_register)
11014         (gdbscm_frame_read_var): Update.
11015         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11016         * exec.c (try_open_exec_file): Update.
11017         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11018         (gdb_rl_callback_handler): Update.
11019         * common/common-exceptions.h (exception_none): Don't declare.
11020         * common/common-exceptions.c (exception_none): Don't define.
11021         (struct catcher) <exception>: Update.
11022         * cli/cli-interp.c (safe_execute_command): Update.
11023         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11024
11025 2019-04-25  Ali Tamur  <tamur@google.com>
11026
11027         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11028         (read_attribute_value): Likewise.
11029         (dwarf2_read_addr_index): Update comment.
11030         (read_str_index): Add DW_FORM_strx.
11031         (dwarf2_string_attr): Likewise.
11032         (dwarf2_const_value_attr): Likewise.
11033         (dump_die_shallow): Likewise.
11034         (dwarf2_fetch_constant_bytes): Likewise.
11035         (skip_form_bytes): Likewise.
11036         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11037
11038 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11039
11040         PR corefiles/11608
11041         PR corefiles/18187
11042         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11043         OFFSET.  Verify if current mapping contains an ELF header.
11044         (linux_find_memory_regions_full): Adjust call to
11045         dump_mapping_p.
11046
11047 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11048             Kang Li <kanglictf@gmail.com>
11049
11050         PR gdb/21600
11051
11052         * dwarf2-frame.c (read_initial_length): Be consistent about using
11053         unsigned representation of length.
11054         (decode_frame_entry_1): Likewise.  Check for wraparound of
11055         end pointer as well as buffer overflow.
11056
11057 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11058
11059         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11060         "vq".
11061
11062 2019-04-24  Tom Tromey  <tromey@adacore.com>
11063
11064         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11065
11066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11067
11068         * s12z-tdep.c (s12z_unwind_pc): Delete.
11069         (s12z_unwind_sp): Delete.
11070         (s12z_gdbarch_init): Don't register deleted functions with
11071         gdbarch.
11072
11073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11074
11075         * rl78-tdep.c (rl78_unwind_sp): Delete.
11076         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11077
11078 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11079
11080         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11081         (xstormy16_unwind_pc): Delete.
11082         (xstormy16_dummy_id): Delete.
11083         (xstormy16_gdbarch_init): Don't register deleted functions with
11084         gdbarch.
11085
11086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11087
11088         * vax-tdep.c (vax_unwind_pc): Delete.
11089         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11090
11091 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11092
11093         * v850-tdep.c (v850_unwind_sp): Delete.
11094         (v850_unwind_pc): Delete.
11095         (v850_dummy_id): Delete.
11096         (v850_gdbarch_init): Don't register deleted functions with
11097         gdbarch.
11098
11099 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11100
11101         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11102         (tilegx_unwind_pc): Delete.
11103         (tilegx_unwind_dummy_id): Delete.
11104         (tilegx_gdbarch_init): Don't register deleted functions with
11105         gdbarch.
11106
11107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11108
11109         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11110         (tic6x_dummy_id): Delete.
11111         (tic6x_gdbarch_init): Don't register deleted functions with
11112         gdbarch.
11113
11114 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11115
11116         * sparc-tdep.c (sparc_unwind_pc): Delete.
11117         (sparc32_gdbarch_init): Don't register deleted function with
11118         gdbarch.
11119
11120 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11121
11122         * sh-tdep.c (sh_unwind_sp): Delete.
11123         (sh_unwind_pc): Delete.
11124         (sh_dummy_id): Delete.
11125         (sh_gdbarch_init): Don't register deleted functions with
11126         gdbarch.
11127
11128 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11129
11130         * score-tdep.c (score_unwind_sp): Delete.
11131         (score_unwind_pc): Delete.
11132         (score_dummy_id): Delete.
11133         (score_gdbarch_init): Don't register deleted functions with
11134         gdbarch.
11135
11136 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11137
11138         * rx-tdep.c (rx_unwind_pc): Delete.
11139         (rx_unwind_sp): Delete.
11140         (rx_dummy_id): Delete.
11141         (rx_gdbarch_init): Don't register deleted functions with
11142         gdbarch.  Update comment.
11143
11144 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11145
11146         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11147         (rs6000_dummy_id): Delete.
11148         (rs6000_gdbarch_init): Don't register deleted functions with
11149         gdbarch.
11150
11151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11152
11153         * or1k-tdep.c (or1k_dummy_id): Delete.
11154         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11155
11156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11157
11158         * nios2-tdep.c (nios2_dummy_id): Delete.
11159         (nios2_unwind_sp): Delete.
11160         (nios2_gdbarch_init): Don't register deleted functions with
11161         gdbarch.
11162
11163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11164
11165         * nds32-tdep.c (nds32_dummy_id): Delete.
11166         (nds32_unwind_pc): Delete.
11167         (nds32_unwind_sp): Delete.
11168         (nds32_gdbarch_init): Don't register deleted functions with
11169         gdbarch.
11170
11171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11172
11173         * msp430-tdep.c (msp430_unwind_pc): Delete.
11174         (msp430_unwind_sp): Delete.
11175         (msp430_dummy_id): Delete.
11176         (msp430_gdbarch_init): Don't register deleted functions with
11177         gdbarch.
11178
11179 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11180
11181         * moxie-tdep.c (moxie_unwind_sp): Delete.
11182         (moxie_unwind_pc): Delete.
11183         (moxie_dummy_id): Delete.
11184         (moxie_gdbarch_init): Don't register deleted functions with
11185         gdbarch.
11186
11187 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11188
11189         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11190         (mn10300_unwind_pc): Delete.
11191         (mn10300_unwind_sp): Delete.
11192         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11193         mn10300_unwind_sp.
11194         (mn10300_frame_unwind_init): Don't register deleted functions with
11195         gdbarch.
11196
11197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11198
11199         * mep-tdep.c (mep_unwind_pc): Delete.
11200         (mep_unwind_sp): Delete.
11201         (mep_dummy_id): Delete.
11202         (mep_gdbarch_init): Don't register deleted functions with
11203         gdbarch.
11204
11205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11206
11207         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11208         (m68hc11_unwind_sp): Delete.
11209         (m68hc11_gdbarch_init): Don't register deleted functions with
11210         gdbarch.
11211
11212 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11213
11214         * m32r-tdep.c (m32r_unwind_sp): Delete.
11215         (m32r_unwind_pc): Delete.
11216         (m32r_dummy_id): Delete.
11217         (m32r_gdbarch_init): Don't register deleted functions with
11218         gdbarch.
11219
11220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11221
11222         * m32c-tdep.c (m32c_unwind_pc): Delete.
11223         (m32c_unwind_sp): Delete.
11224         (m32c_dummy_id): Delete.
11225         (m32c_gdbarch_init): Don't register deleted functions with
11226         gdbarch.
11227
11228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11229
11230         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11231         (lm32_unwind_pc): Delete.
11232         (lm32_dummy_id): Delete.
11233         (lm32_gdbarch_init): Don't register deleted functions with
11234         gdbarch.
11235
11236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11237
11238         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11239         (iq2000_unwind_pc): Delete.
11240         (iq2000_dummy_id): Delete.
11241         (iq2000_gdbarch_init): Don't register deleted functions with
11242         gdbarch.
11243
11244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11245
11246         * nds32-tdep.c (nds32_type_align): Delete.
11247         (nds32_push_dummy_call): Use type_align instead.
11248
11249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11250
11251         * arm-tdep.c (arm_type_align): Only handle vector override case.
11252         (arm_push_dummy_call): Use type_align.
11253         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11254
11255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11256
11257         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11258         case.
11259         (pass_on_stack): Use type_align.
11260         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11261         function.
11262
11263 2019-04-23  Tom Tromey  <tromey@adacore.com>
11264
11265         * dwarf2read.c (line_header::file_name_at): Remove unused
11266         overload.
11267
11268 2019-04-23  Tom de Vries  <tdevries@suse.de>
11269
11270         PR gdb/24438
11271         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11272         invocation.
11273
11274
11275 2019-03-27  Ali Tamur  <tamur@google.com>
11276
11277         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11278         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11279         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11280         (dwarf_expr_context::get_addr_index): Likewise
11281         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11282         (symbol_needs_eval_context::get_addr_index): Likewise
11283         (disassemble_dwarf_expression): Add DW_OP_addrx
11284         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11285         (read_cutu_die_from_dwo): Update comment
11286         (skip_one_die): Add DW_FORM_addrx
11287         (read_attribute_value): Likewise
11288         (var_decode_location): Add DW_OP_addrx
11289         (dwarf2_const_value_attr): Add DW_FORM_addrx
11290         (dump_die_shallow): Likewise
11291         (dwarf2_fetch_constant_bytes): Likewise
11292         (decode_locdesc): Add DW_OP_addrx
11293         (skip_form_bytes): Add DW_FORM_addrx
11294
11295 2019-04-22  Ali Tamur  <tamur@google.com>
11296
11297         * MAINTAINERS (Write After Approval): Add self.
11298
11299 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11300
11301         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11302         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11303         (open_symbol_file_object): Likewise.
11304         (svr4_default_sos): Add info parameter.
11305         (svr4_read_so_list): Likewise.
11306         (svr4_current_sos_direct): Adjust functions calls to pass down
11307         info.
11308         (svr4_current_sos_1): Add info parameter.
11309         (svr4_current_sos): Call get_svr4_info, pass info down to
11310         svr4_current_sos_1.
11311         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11312         get_svr4_info.
11313         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11314         get_svr4_info.
11315         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11316         to get_svr4_info.
11317         (probes_table_remove_objfile_probes): Likewise.
11318         (register_solib_event_probe): Add info parameter.
11319         (solist_update_incremental): Pass info parameter down to
11320         svr4_read_so_list.
11321         (disable_probes_interface): Add info parameter.
11322         (svr4_handle_solib_event): Pass current_program_space to
11323         get_svr4_info.  Adjust disable_probes_interface cleanup.
11324         (svr4_create_probe_breakpoints): Add info parameter, pass it
11325         down to register_solib_event_probe.
11326         (svr4_create_solib_event_breakpoints): Add info parameter,
11327         pass it down to svr4_create_probe_breakpoints.
11328         (enable_break): Pass info down to
11329         svr4_create_solib_event_breakpoints.
11330         (svr4_solib_create_inferior_hook): Pass current_program_space to
11331         get_svr4_info.
11332         (svr4_clear_solib): Likewise.
11333
11334 2019-04-22  Pedro Alves  <palves@redhat.com>
11335
11336         * solib-svr4.c (svr4_free_objfile_observer): New.
11337         (probe_and_action::objfile): New field.
11338         (probes_table_htab_remove_objfile_probes)
11339         (probes_table_remove_objfile_probes): New functions.
11340         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11341         in the new probe_and_action.  Don't store the probe in 'lookup'.
11342         (svr4_create_probe_breakpoints): Pass objfile to
11343         register_solib_event_probe.
11344         (_initialize_svr4_solib): Register a free_objfile observer.
11345
11346 2019-04-19  Tom Tromey  <tom@tromey.com>
11347
11348         * common/queue.h: Remove.
11349
11350 2019-04-19  Tom Tromey  <tom@tromey.com>
11351
11352         * event-loop.c: Don't include "common/queue.h".
11353
11354 2019-04-19  Tom Tromey  <tom@tromey.com>
11355
11356         * remote.c (remote_target): Use delete.
11357         * remote-notif.h: Include <list>, not "common/queue.h".
11358         (notif_client_p): Remove typedef.
11359         (remote_notif_state): Add constructor, destructor, initializer.
11360         <notif_queue>: Now a std::list.
11361         (remote_notif_state_xfree): Don't declare.
11362         * remote-notif.c (remote_notif_process, handle_notification)
11363         (remote_notif_state_allocate): Update.
11364         (~remote_notif_state): Rename from remote_notif_state_xfree.
11365
11366 2019-04-19  Tom Tromey  <tom@tromey.com>
11367
11368         * symfile.c (reread_symbols): Update.
11369         * objfiles.c (objfile_register_static_link)
11370         (objfile_lookup_static_link): Update
11371         (~objfile) Don't delete static_links.
11372         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11373
11374 2019-04-19  Tom Tromey  <tom@tromey.com>
11375
11376         * type-stack.h (struct type_stack) <insert>: Constify string.
11377         * type-stack.c (type_stack::insert): Constify string.
11378         * gdbtypes.h (lookup_template_type): Update.
11379         (address_space_name_to_int): Update.
11380         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11381         const.
11382         (lookup_template_type): Make name const.
11383         * c-exp.y: Update rules.
11384         (lex_one_token, classify_name, classify_inner_name)
11385         (c_print_token): Update.
11386         * p-exp.y: Update rules.
11387         (yylex): Update.
11388         * f-exp.y: Update rules.
11389         (yylex): Update.
11390         * d-exp.y: Update rules.
11391         (lex_one_token, classify_name, classify_inner_name): Update.
11392         * parse.c (write_dollar_variable, copy_name): Return std::string.
11393         * parser-defs.h (copy_name): Change return type.
11394         * m2-exp.y: Update rules.
11395         (yylex): Update.
11396         * go-exp.y (lex_one_token): Update.
11397         Update rules.
11398         (classify_unsafe_function, classify_packaged_name)
11399         (classify_name, yylex): Update.
11400
11401 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11402
11403         * configure.ac: add --enable-source-highlight switch.
11404         * configure: Regenerate.
11405         * top.c (print_gdb_version): plumb --enable-source-highlight
11406         status to "show configuration".
11407
11408 2019-04-19  Tom Tromey  <tromey@adacore.com>
11409
11410         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11411         Check ADA_TYPE_P.
11412         (empty_record, ada_template_to_fixed_record_type_1)
11413         (template_to_static_fixed_type)
11414         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11415         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11416         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11417         macros.
11418
11419 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11420
11421         PR symtab/24423:
11422         * source.c (print_source_lines_base): Advance "iter" when a
11423         control character is seen.
11424
11425 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11426
11427         * inferior.h (struct infcall_suspend_state_deleter):
11428         Catch exception in destructor to avoid crash.
11429
11430 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11431
11432         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11433         close to the add_com "shell".
11434
11435 2019-04-18  Tom Tromey  <tromey@adacore.com>
11436
11437         * process-stratum-target.h (class process_stratum_target)
11438         <stratum>: Add "final".
11439
11440 2019-04-17  Tom Tromey  <tromey@adacore.com>
11441
11442         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11443         against nullptr before use.
11444
11445 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11446
11447         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11448
11449 2019-04-17  Jim Wilson  <jimw@sifive.com>
11450             Andrew Burgess  <andrew.burgess@embecosm.com>
11451
11452         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11453         code read might fail, assume 4-byte breakpoint in that case.
11454
11455 2019-04-15  Leszek Swirski  <leszeks@google.com>
11456
11457         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11458         rather than a hand-rolled POD check when checking for forced MEMORY
11459         classification.
11460
11461 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11462
11463         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11464         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11465         function.
11466         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11467         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11468         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11469         declaration.
11470
11471 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11472
11473         * aarch64-linux-nat.c
11474         (aarch64_linux_nat_target::thread_architecture): Add override.
11475         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11476         each VQ.
11477
11478 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11479
11480         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11481
11482 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11483
11484         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11485         target types of size 96-bits, add some additional comments, and
11486         check that the builtin type we found was the correct size.
11487
11488 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11489
11490         * utils.c (prompt_for_continue): Don't restore the styling at the
11491         end, as applied_style has the wrong value.  This fixes styling in
11492         long lists of file names that are interrupted by the "Continue?"
11493         prompt.
11494
11495 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11496
11497         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11498         * c-lang.c (c_language_defn): Likewise.
11499         (cplus_language_defn): Likewise.
11500         (asm_language_defn): Likewise.
11501         (minimal_language_defn): Likewise.
11502         * d-lang.c (d_language_defn): Likewise.
11503         * f-lang.c (f_language_defn): Likewise.
11504         * go-lang.c (go_language_defn): Likewise.
11505         * language.c (unknown_language_defn): Likewise.
11506         (auto_language_defn): Likewise.
11507         * language.h (struct language_defn): Remove la_magic field.
11508         (LANG_MAGIC): Delete.
11509         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11510         * objc-lang.c (objc_language_defn): Likewise.
11511         * opencl-lang.c (opencl_language_defn): Likewise.
11512         * p-lang.c (pascal_language_defn): Likewise.
11513         * rust-lang.c (rust_language_defn): Likewise.
11514
11515 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11516
11517         * riscv-tdep.c (riscv_type_align): New function.
11518         (riscv_type_alignment): Delete.
11519         (riscv_arg_location): Use 'type_align'.
11520         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11521
11522 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11523
11524         * gdbtypes.c (type_align): A struct with no non-static fields also
11525         has alignment of 1.
11526
11527 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11528
11529         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11530         component to 0.
11531         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11532         member.
11533         (riscv_struct_info::analyse): New implementation using new
11534         analyse_inner member function.
11535         (riscv_struct_info::field_offset): New member function.
11536         (riscv_struct_info::m_offsets): New member variable.
11537         (riscv_struct_info::analyse_inner): New private member function,
11538         takes the old implementation of riscv_struct_info::analyse but
11539         extended to track field offsets.
11540         (riscv_call_arg_struct): Update the struct folding special cases
11541         to handle cases where empty C++ structs, which are non-zero
11542         length, are found.
11543         (riscv_arg_location): Initialise the length of each location, a
11544         non-zero length now indicates the location is in use.
11545         (riscv_push_dummy_call): Allow for the first location having a
11546         non-zero offset when setting up arguments.
11547         (riscv_return_value): Likewise, but for return values.
11548
11549 2019-04-11  Tom Tromey  <tromey@adacore.com>
11550
11551         * utils.c (internal_vproblem): Make "msg" const.
11552
11553 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11554
11555         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11556         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11557         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11558         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11559
11560 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11561
11562         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11563         function.
11564         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11565         of amd64_collect_native_gregset.
11566         (amd64_linux_nat_target::store_registers): Likewise.
11567
11568 2019-04-10  Tom Tromey  <tom@tromey.com>
11569
11570         * symtab.c (lookup_global_symbol_from_objfile)
11571         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11572         * objfiles.h (class separate_debug_iterator): New.
11573         (class separate_debug_range): New.
11574         (struct objfile) <separate_debug_objfiles>: New method.
11575         (objfile_separate_debug_iterate): Don't declare.
11576         * objfiles.c (separate_debug_iterator::operator++): Rename from
11577         objfile_separate_debug_iterate.
11578         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11579         iterator.
11580         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11581         iterator.
11582
11583 2019-04-10  Tom Tromey  <tom@tromey.com>
11584
11585         * symfile.c (reread_symbols): Remove old comment.
11586         * objfiles.c (free_all_objfiles): Fix a typo.
11587
11588 2019-04-10  Tom Tromey  <tom@tromey.com>
11589
11590         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11591         * minsyms.c (lookup_minimal_symbol): Use foreach.
11592         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11593         (lookup_minimal_symbol_solib_trampoline): Likewise.
11594         * symfile.c (reread_symbols): Use foreach.
11595
11596 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11597             Tom Tromey  <tromey@adacore.com>
11598
11599         PR rust/24414:
11600         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11601         (rust_lex_int_test): Change "value" to be LONGEST.
11602         (rust_lex_tests): Add test for long integer literal.
11603
11604 2019-04-09  Tom Tromey  <tromey@adacore.com>
11605
11606         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11607         to bool.
11608         (extended_remote_target::attach): Update.
11609         (remote_target::remote_notice_new_inferior): Update.
11610         (remote_target::add_current_inferior_and_thread): Update.
11611         * inferior.c (exit_inferior_1): Use "false".
11612         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11613
11614 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11615
11616         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11617         the "start" command.
11618
11619 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11620
11621         * python/py-inferior.c (infpy_thread_from_thread_handle):
11622         Adjust comments to reflect renaming of thread_from_thread_handle
11623         to thread_from_handle.  Adjust keywords.  Fix type error message.
11624         (inferior_object_methods): Add thread_from_handle.  Retain
11625         thread_from_thread_handle, but mark it as deprecated.
11626
11627 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11628
11629         * gdbthread.h (find_thread_by_handle): Revise declaration.
11630         * thread.c (find_thread_by_handle): Likewise.  Adjust
11631         implementation too.
11632         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11633         support for buffer objects as handles.
11634
11635 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11636
11637         * python/py-infthread.c (thpy_thread_handle): New function.
11638         (thread_object_methods): Register thpy_thread_handle.
11639
11640 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11641
11642         * gdbthread.h (thread_to_thread_handle): Declare.
11643         * thread.c (gdbtypes.h): Include.
11644         (thread_to_thread_handle): New function.
11645
11646         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11647         (target_thread_info_to_thread_handle): Declare.
11648         * target.c (target_thread_info_to_thread_handle): New function.
11649         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11650         * target-delegates.c: Regenerate.
11651
11652         * linux-thread-db.c (class thread_db_target): Add method
11653         thread_info_to_thread_handle.
11654         (thread_db_target::thread_info_to_thread_handle): Define.
11655         * remote.c (class remote_target): Add new method
11656         thread_info_to_thread_handle.
11657         (remote_target::thread_info_to_thread_handle): Define.
11658
11659 2019-04-08  Pedro Alves  <palves@redhat.com>
11660
11661         * common/common-exceptions.c (throw_exception): Don't create
11662         named object to throw; throw directly.
11663         (throw_it): Likewise.  Don't initialize gdb_exception::message
11664         here, with new; pass FMT and AP to the ctor instead.
11665         * common/common-exceptions.h: Include <string>.
11666         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11667         const char *, va_list)): New ctor.  Use std::make_shared.
11668         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11669         errors)): Delete.
11670         (gdb_exception_error::gdb_exception_error(enum errors, const char
11671         *, va_list)): New.
11672         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11673         Add assertion.
11674         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11675         errors)): Delete.
11676         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11677         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11678         Add assertion.
11679
11680 2019-04-08  Tom Tromey  <tom@tromey.com>
11681
11682         * valops.c (value_rtti_indirect_type): Replace throw_exception
11683         with throw.
11684         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11685         with throw.
11686         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11687         throw.
11688         * target.c (target_translate_tls_address): Replace throw_exception
11689         with throw.
11690         * stack.c (frame_apply_command_count): Replace throw_exception
11691         with throw.
11692         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11693         throw.
11694         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11695         with throw.
11696         * rs6000-tdep.c (rs6000_frame_cache)
11697         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11698         * remote.c: Replace throw_exception with throw.
11699         * record-full.c (record_full_message, record_full_wait_1)
11700         (record_full_restore): Replace throw_exception with throw.
11701         * record-btrace.c:
11702         (get_thread_current_frame_id, record_btrace_start_replaying)
11703         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11704         (cmd_record_btrace_start): Replace throw_exception with throw.
11705         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11706         throw.
11707         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11708         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11709         * linespec.c:
11710         (find_linespec_symbols): Replace throw_exception with throw.
11711         * infrun.c (displaced_step_prepare, resume): Replace
11712         throw_exception with throw.
11713         * infcmd.c (post_create_inferior): Replace throw_exception with
11714         throw.
11715         * inf-loop.c (inferior_event_handler): Replace throw_exception
11716         with throw.
11717         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11718         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11719         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11720         (get_prev_frame_always, get_frame_pc_if_available)
11721         (get_frame_address_in_block_if_available, get_frame_language):
11722         Replace throw_exception with throw.
11723         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11724         throw_exception with throw.
11725         * eval.c (fetch_subexp_value, evaluate_var_value)
11726         (evaluate_funcall, evaluate_subexp_standard): Replace
11727         throw_exception with throw.
11728         * dwarf2loc.c (call_site_find_chain)
11729         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11730         Replace throw_exception with throw.
11731         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11732         with throw.
11733         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11734         throw.
11735         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11736         * completer.c (complete_line_internal): Replace throw_exception
11737         with throw.
11738         * compile/compile-object-run.c (compile_object_run): Replace
11739         throw_exception with throw.
11740         * cli/cli-script.c (process_next_line): Replace throw_exception
11741         with throw.
11742         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11743         (btrace_enable, btrace_maint_update_pt_packets): Replace
11744         throw_exception with throw.
11745         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11746         throw_exception with throw.
11747         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11748         throw_exception with throw.
11749         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11750         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11751         * aarch64-tdep.c (aarch64_make_prologue_cache)
11752         (aarch64_make_stub_cache): Replace throw_exception with throw.
11753
11754 2019-04-08  Tom Tromey  <tom@tromey.com>
11755
11756         * common/common-exceptions.c (throw_exception): Rename from
11757         throw_exception_cxx.  Remove old copy.  Make argument const.
11758         (throw_it): Create and throw exception objects directly.
11759         * common/common-exceptions.h (throw_exception): Make argument
11760         const.
11761         (struct gdb_exception_error): Add constructor.
11762         (struct gdb_exception_quit): Add constructor.
11763
11764 2019-04-08  Tom Tromey  <tom@tromey.com>
11765
11766         * common/common-exceptions.h (exception_rethrow): Don't declare.
11767         (TRY_SJLJ): Update comment.
11768         (TRY, CATCH, END_CATCH): Remove.
11769         * common/common-exceptions.c (exception_rethrow): Remove.
11770
11771 2019-04-08  Tom Tromey  <tom@tromey.com>
11772
11773         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11774         Remove.
11775         (gdb_exception_error): Rename from
11776         gdb_exception_RETURN_MASK_ERROR.
11777         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11778         (gdb_quit_bad_alloc): Update.
11779         * aarch64-tdep.c: Update.
11780         * ada-lang.c: Update.
11781         * ada-typeprint.c: Update.
11782         * ada-valprint.c: Update.
11783         * amd64-tdep.c: Update.
11784         * arch-utils.c: Update.
11785         * break-catch-throw.c: Update.
11786         * breakpoint.c: Update.
11787         * btrace.c: Update.
11788         * c-varobj.c: Update.
11789         * cli/cli-cmds.c: Update.
11790         * cli/cli-interp.c: Update.
11791         * cli/cli-script.c: Update.
11792         * common/common-exceptions.c: Update.
11793         * common/new-op.c: Update.
11794         * common/selftest.c: Update.
11795         * compile/compile-c-symbols.c: Update.
11796         * compile/compile-cplus-symbols.c: Update.
11797         * compile/compile-object-load.c: Update.
11798         * compile/compile-object-run.c: Update.
11799         * completer.c: Update.
11800         * corelow.c: Update.
11801         * cp-abi.c: Update.
11802         * cp-support.c: Update.
11803         * cp-valprint.c: Update.
11804         * darwin-nat.c: Update.
11805         * disasm-selftests.c: Update.
11806         * dtrace-probe.c: Update.
11807         * dwarf-index-cache.c: Update.
11808         * dwarf-index-write.c: Update.
11809         * dwarf2-frame-tailcall.c: Update.
11810         * dwarf2-frame.c: Update.
11811         * dwarf2loc.c: Update.
11812         * dwarf2read.c: Update.
11813         * eval.c: Update.
11814         * event-loop.c: Update.
11815         * event-top.c: Update.
11816         * exec.c: Update.
11817         * f-valprint.c: Update.
11818         * fbsd-tdep.c: Update.
11819         * frame-unwind.c: Update.
11820         * frame.c: Update.
11821         * gdbtypes.c: Update.
11822         * gnu-v3-abi.c: Update.
11823         * guile/guile-internal.h: Update.
11824         * guile/scm-block.c: Update.
11825         * guile/scm-breakpoint.c: Update.
11826         * guile/scm-cmd.c: Update.
11827         * guile/scm-disasm.c: Update.
11828         * guile/scm-frame.c: Update.
11829         * guile/scm-lazy-string.c: Update.
11830         * guile/scm-math.c: Update.
11831         * guile/scm-param.c: Update.
11832         * guile/scm-ports.c: Update.
11833         * guile/scm-pretty-print.c: Update.
11834         * guile/scm-symbol.c: Update.
11835         * guile/scm-symtab.c: Update.
11836         * guile/scm-type.c: Update.
11837         * guile/scm-value.c: Update.
11838         * i386-linux-tdep.c: Update.
11839         * i386-tdep.c: Update.
11840         * inf-loop.c: Update.
11841         * infcall.c: Update.
11842         * infcmd.c: Update.
11843         * infrun.c: Update.
11844         * jit.c: Update.
11845         * language.c: Update.
11846         * linespec.c: Update.
11847         * linux-fork.c: Update.
11848         * linux-nat.c: Update.
11849         * linux-tdep.c: Update.
11850         * linux-thread-db.c: Update.
11851         * main.c: Update.
11852         * mi/mi-cmd-break.c: Update.
11853         * mi/mi-cmd-stack.c: Update.
11854         * mi/mi-interp.c: Update.
11855         * mi/mi-main.c: Update.
11856         * objc-lang.c: Update.
11857         * p-valprint.c: Update.
11858         * parse.c: Update.
11859         * ppc-linux-tdep.c: Update.
11860         * printcmd.c: Update.
11861         * python/py-arch.c: Update.
11862         * python/py-breakpoint.c: Update.
11863         * python/py-cmd.c: Update.
11864         * python/py-finishbreakpoint.c: Update.
11865         * python/py-frame.c: Update.
11866         * python/py-framefilter.c: Update.
11867         * python/py-gdb-readline.c: Update.
11868         * python/py-inferior.c: Update.
11869         * python/py-infthread.c: Update.
11870         * python/py-lazy-string.c: Update.
11871         * python/py-linetable.c: Update.
11872         * python/py-objfile.c: Update.
11873         * python/py-param.c: Update.
11874         * python/py-prettyprint.c: Update.
11875         * python/py-progspace.c: Update.
11876         * python/py-record-btrace.c: Update.
11877         * python/py-record.c: Update.
11878         * python/py-symbol.c: Update.
11879         * python/py-type.c: Update.
11880         * python/py-unwind.c: Update.
11881         * python/py-utils.c: Update.
11882         * python/py-value.c: Update.
11883         * python/python.c: Update.
11884         * record-btrace.c: Update.
11885         * record-full.c: Update.
11886         * remote-fileio.c: Update.
11887         * remote.c: Update.
11888         * riscv-tdep.c: Update.
11889         * rs6000-aix-tdep.c: Update.
11890         * rs6000-tdep.c: Update.
11891         * rust-exp.y: Update.
11892         * rust-lang.c: Update.
11893         * s390-tdep.c: Update.
11894         * selftest-arch.c: Update.
11895         * solib-dsbt.c: Update.
11896         * solib-frv.c: Update.
11897         * solib-spu.c: Update.
11898         * solib-svr4.c: Update.
11899         * solib.c: Update.
11900         * sparc64-linux-tdep.c: Update.
11901         * stack.c: Update.
11902         * symfile-mem.c: Update.
11903         * symmisc.c: Update.
11904         * target.c: Update.
11905         * thread.c: Update.
11906         * top.c: Update.
11907         * tracefile-tfile.c: Update.
11908         * tui/tui.c: Update.
11909         * typeprint.c: Update.
11910         * unittests/cli-utils-selftests.c: Update.
11911         * unittests/parse-connection-spec-selftests.c: Update.
11912         * valops.c: Update.
11913         * valprint.c: Update.
11914         * value.c: Update.
11915         * varobj.c: Update.
11916         * windows-nat.c: Update.
11917         * x86-linux-nat.c: Update.
11918         * xml-support.c: Update.
11919
11920 2019-04-08  Tom Tromey  <tom@tromey.com>
11921
11922         * xml-support.c: Use C++ exception handling.
11923         * x86-linux-nat.c: Use C++ exception handling.
11924         * windows-nat.c: Use C++ exception handling.
11925         * varobj.c: Use C++ exception handling.
11926         * value.c: Use C++ exception handling.
11927         * valprint.c: Use C++ exception handling.
11928         * valops.c: Use C++ exception handling.
11929         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11930         handling.
11931         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11932         * typeprint.c: Use C++ exception handling.
11933         * tui/tui.c: Use C++ exception handling.
11934         * tracefile-tfile.c: Use C++ exception handling.
11935         * top.c: Use C++ exception handling.
11936         * thread.c: Use C++ exception handling.
11937         * target.c: Use C++ exception handling.
11938         * symmisc.c: Use C++ exception handling.
11939         * symfile-mem.c: Use C++ exception handling.
11940         * stack.c: Use C++ exception handling.
11941         * sparc64-linux-tdep.c: Use C++ exception handling.
11942         * solib.c: Use C++ exception handling.
11943         * solib-svr4.c: Use C++ exception handling.
11944         * solib-spu.c: Use C++ exception handling.
11945         * solib-frv.c: Use C++ exception handling.
11946         * solib-dsbt.c: Use C++ exception handling.
11947         * selftest-arch.c: Use C++ exception handling.
11948         * s390-tdep.c: Use C++ exception handling.
11949         * rust-lang.c: Use C++ exception handling.
11950         * rust-exp.y: Use C++ exception handling.
11951         * rs6000-tdep.c: Use C++ exception handling.
11952         * rs6000-aix-tdep.c: Use C++ exception handling.
11953         * riscv-tdep.c: Use C++ exception handling.
11954         * remote.c: Use C++ exception handling.
11955         * remote-fileio.c: Use C++ exception handling.
11956         * record-full.c: Use C++ exception handling.
11957         * record-btrace.c: Use C++ exception handling.
11958         * python/python.c: Use C++ exception handling.
11959         * python/py-value.c: Use C++ exception handling.
11960         * python/py-utils.c: Use C++ exception handling.
11961         * python/py-unwind.c: Use C++ exception handling.
11962         * python/py-type.c: Use C++ exception handling.
11963         * python/py-symbol.c: Use C++ exception handling.
11964         * python/py-record.c: Use C++ exception handling.
11965         * python/py-record-btrace.c: Use C++ exception handling.
11966         * python/py-progspace.c: Use C++ exception handling.
11967         * python/py-prettyprint.c: Use C++ exception handling.
11968         * python/py-param.c: Use C++ exception handling.
11969         * python/py-objfile.c: Use C++ exception handling.
11970         * python/py-linetable.c: Use C++ exception handling.
11971         * python/py-lazy-string.c: Use C++ exception handling.
11972         * python/py-infthread.c: Use C++ exception handling.
11973         * python/py-inferior.c: Use C++ exception handling.
11974         * python/py-gdb-readline.c: Use C++ exception handling.
11975         * python/py-framefilter.c: Use C++ exception handling.
11976         * python/py-frame.c: Use C++ exception handling.
11977         * python/py-finishbreakpoint.c: Use C++ exception handling.
11978         * python/py-cmd.c: Use C++ exception handling.
11979         * python/py-breakpoint.c: Use C++ exception handling.
11980         * python/py-arch.c: Use C++ exception handling.
11981         * printcmd.c: Use C++ exception handling.
11982         * ppc-linux-tdep.c: Use C++ exception handling.
11983         * parse.c: Use C++ exception handling.
11984         * p-valprint.c: Use C++ exception handling.
11985         * objc-lang.c: Use C++ exception handling.
11986         * mi/mi-main.c: Use C++ exception handling.
11987         * mi/mi-interp.c: Use C++ exception handling.
11988         * mi/mi-cmd-stack.c: Use C++ exception handling.
11989         * mi/mi-cmd-break.c: Use C++ exception handling.
11990         * main.c: Use C++ exception handling.
11991         * linux-thread-db.c: Use C++ exception handling.
11992         * linux-tdep.c: Use C++ exception handling.
11993         * linux-nat.c: Use C++ exception handling.
11994         * linux-fork.c: Use C++ exception handling.
11995         * linespec.c: Use C++ exception handling.
11996         * language.c: Use C++ exception handling.
11997         * jit.c: Use C++ exception handling.
11998         * infrun.c: Use C++ exception handling.
11999         * infcmd.c: Use C++ exception handling.
12000         * infcall.c: Use C++ exception handling.
12001         * inf-loop.c: Use C++ exception handling.
12002         * i386-tdep.c: Use C++ exception handling.
12003         * i386-linux-tdep.c: Use C++ exception handling.
12004         * guile/scm-value.c: Use C++ exception handling.
12005         * guile/scm-type.c: Use C++ exception handling.
12006         * guile/scm-symtab.c: Use C++ exception handling.
12007         * guile/scm-symbol.c: Use C++ exception handling.
12008         * guile/scm-pretty-print.c: Use C++ exception handling.
12009         * guile/scm-ports.c: Use C++ exception handling.
12010         * guile/scm-param.c: Use C++ exception handling.
12011         * guile/scm-math.c: Use C++ exception handling.
12012         * guile/scm-lazy-string.c: Use C++ exception handling.
12013         * guile/scm-frame.c: Use C++ exception handling.
12014         * guile/scm-disasm.c: Use C++ exception handling.
12015         * guile/scm-cmd.c: Use C++ exception handling.
12016         * guile/scm-breakpoint.c: Use C++ exception handling.
12017         * guile/scm-block.c: Use C++ exception handling.
12018         * guile/guile-internal.h: Use C++ exception handling.
12019         * gnu-v3-abi.c: Use C++ exception handling.
12020         * gdbtypes.c: Use C++ exception handling.
12021         * frame.c: Use C++ exception handling.
12022         * frame-unwind.c: Use C++ exception handling.
12023         * fbsd-tdep.c: Use C++ exception handling.
12024         * f-valprint.c: Use C++ exception handling.
12025         * exec.c: Use C++ exception handling.
12026         * event-top.c: Use C++ exception handling.
12027         * event-loop.c: Use C++ exception handling.
12028         * eval.c: Use C++ exception handling.
12029         * dwarf2read.c: Use C++ exception handling.
12030         * dwarf2loc.c: Use C++ exception handling.
12031         * dwarf2-frame.c: Use C++ exception handling.
12032         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12033         * dwarf-index-write.c: Use C++ exception handling.
12034         * dwarf-index-cache.c: Use C++ exception handling.
12035         * dtrace-probe.c: Use C++ exception handling.
12036         * disasm-selftests.c: Use C++ exception handling.
12037         * darwin-nat.c: Use C++ exception handling.
12038         * cp-valprint.c: Use C++ exception handling.
12039         * cp-support.c: Use C++ exception handling.
12040         * cp-abi.c: Use C++ exception handling.
12041         * corelow.c: Use C++ exception handling.
12042         * completer.c: Use C++ exception handling.
12043         * compile/compile-object-run.c: Use C++ exception handling.
12044         * compile/compile-object-load.c: Use C++ exception handling.
12045         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12046         * compile/compile-c-symbols.c: Use C++ exception handling.
12047         * common/selftest.c: Use C++ exception handling.
12048         * common/new-op.c: Use C++ exception handling.
12049         * cli/cli-script.c: Use C++ exception handling.
12050         * cli/cli-interp.c: Use C++ exception handling.
12051         * cli/cli-cmds.c: Use C++ exception handling.
12052         * c-varobj.c: Use C++ exception handling.
12053         * btrace.c: Use C++ exception handling.
12054         * breakpoint.c: Use C++ exception handling.
12055         * break-catch-throw.c: Use C++ exception handling.
12056         * arch-utils.c: Use C++ exception handling.
12057         * amd64-tdep.c: Use C++ exception handling.
12058         * ada-valprint.c: Use C++ exception handling.
12059         * ada-typeprint.c: Use C++ exception handling.
12060         * ada-lang.c: Use C++ exception handling.
12061         * aarch64-tdep.c: Use C++ exception handling.
12062
12063 2019-04-08  Tom Tromey  <tom@tromey.com>
12064
12065         * xml-support.c (gdb_xml_parser::parse): Update.
12066         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12067         * value.c (show_convenience): Update.
12068         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12069         (test_parse_flags_qcs): Update.
12070         * thread.c (thr_try_catch_cmd): Update.
12071         * target.c (target_translate_tls_address): Update.
12072         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12073         (info_frame_command_core, frame_apply_command_count): Update.
12074         * rust-exp.y (rust_lex_exception_test): Update.
12075         * riscv-tdep.c (riscv_print_one_register_info): Update.
12076         * remote.c (remote_target::enable_btrace): Update.
12077         * record-btrace.c (record_btrace_enable_warn): Update.
12078         * python/py-utils.c (gdbpy_convert_exception): Update.
12079         * printcmd.c (do_one_display, print_variable_and_value): Update.
12080         * mi/mi-main.c (mi_print_exception): Update.
12081         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12082         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12083         * linux-nat.c (linux_nat_target::attach): Update.
12084         * linux-fork.c (class scoped_switch_fork_info): Update.
12085         * infrun.c (displaced_step_prepare): Update.
12086         * infcall.c (call_function_by_hand_dummy): Update.
12087         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12088         * gnu-v3-abi.c (print_one_vtable): Update.
12089         * frame.c (get_prev_frame_always): Update.
12090         * f-valprint.c (info_common_command_for_block): Update.
12091         * exec.c (try_open_exec_file): Update.
12092         * exceptions.c (print_exception, exception_print)
12093         (exception_fprintf, exception_print_same): Update.
12094         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12095         * dwarf-index-cache.c (index_cache::store)
12096         (index_cache::lookup_gdb_index): Update.
12097         * darwin-nat.c (maybe_cache_shell): Update.
12098         * cp-valprint.c (cp_print_value_fields): Update.
12099         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12100         (gcc_cplus_symbol_address): Update.
12101         * compile/compile-c-symbols.c (gcc_convert_symbol)
12102         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12103         * common/selftest.c: Update.
12104         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12105         a std::string.
12106         (exception_try_scope_entry, exception_try_scope_exit): Don't
12107         declare.
12108         (struct exception_try_scope): Remove.
12109         (TRY): Don't use exception_try_scope.
12110         (struct gdb_exception): Add constructor, operator=.
12111         <what>: New method.
12112         (struct gdb_exception_RETURN_MASK_ALL)
12113         (struct gdb_exception_RETURN_MASK_ERROR)
12114         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12115         (struct gdb_quit_bad_alloc): Update.
12116         * common/common-exceptions.c (exception_none): Change
12117         initializer.
12118         (struct catcher) <state, exception>: Initialize inline.
12119         <prev>: Remove member.
12120         (current_catcher): Remove.
12121         (catchers): New global.
12122         (exceptions_state_mc_init): Simplify.
12123         (catcher_pop): Remove.
12124         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12125         (try_scope_depth, exception_try_scope_entry)
12126         (exception_try_scope_exit): Remove.
12127         (throw_exception_sjlj): Update.
12128         (exception_messages, exception_messages_size): Remove.
12129         (throw_it): Simplify.
12130         (gdb_exception_sliced_copy): Remove.
12131         (throw_exception_cxx): Update.
12132         * cli/cli-script.c (script_from_file): Update.
12133         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12134         Update.
12135         * ada-valprint.c (ada_val_print): Update.
12136         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12137         (create_excep_cond_exprs): Update.
12138
12139 2019-04-08  Tom Tromey  <tom@tromey.com>
12140
12141         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12142         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12143         (TRY, CATCH, END_CATCH): Remove some definitions.
12144         * common/common-exceptions.c: Don't use GDB_XCPT.
12145         (catcher_list_size): Remove.
12146         (throw_exception, throw_it): Simplify.
12147
12148 2019-04-05  Tom Tromey  <tom@tromey.com>
12149
12150         Revert the header-sorting patch.
12151         * ft32-tdep.c: Revert.
12152         * frv-tdep.c: Revert.
12153         * frv-linux-tdep.c: Revert.
12154         * frame.c: Revert.
12155         * frame-unwind.c: Revert.
12156         * frame-base.c: Revert.
12157         * fork-child.c: Revert.
12158         * findvar.c: Revert.
12159         * findcmd.c: Revert.
12160         * filesystem.c: Revert.
12161         * filename-seen-cache.h: Revert.
12162         * filename-seen-cache.c: Revert.
12163         * fbsd-tdep.c: Revert.
12164         * fbsd-nat.h: Revert.
12165         * fbsd-nat.c: Revert.
12166         * f-valprint.c: Revert.
12167         * f-typeprint.c: Revert.
12168         * f-lang.c: Revert.
12169         * extension.h: Revert.
12170         * extension.c: Revert.
12171         * extension-priv.h: Revert.
12172         * expprint.c: Revert.
12173         * exec.h: Revert.
12174         * exec.c: Revert.
12175         * exceptions.c: Revert.
12176         * event-top.c: Revert.
12177         * event-loop.c: Revert.
12178         * eval.c: Revert.
12179         * elfread.c: Revert.
12180         * dwarf2read.h: Revert.
12181         * dwarf2read.c: Revert.
12182         * dwarf2loc.c: Revert.
12183         * dwarf2expr.h: Revert.
12184         * dwarf2expr.c: Revert.
12185         * dwarf2-frame.c: Revert.
12186         * dwarf2-frame-tailcall.c: Revert.
12187         * dwarf-index-write.h: Revert.
12188         * dwarf-index-write.c: Revert.
12189         * dwarf-index-common.c: Revert.
12190         * dwarf-index-cache.h: Revert.
12191         * dwarf-index-cache.c: Revert.
12192         * dummy-frame.c: Revert.
12193         * dtrace-probe.c: Revert.
12194         * disasm.h: Revert.
12195         * disasm.c: Revert.
12196         * disasm-selftests.c: Revert.
12197         * dictionary.c: Revert.
12198         * dicos-tdep.c: Revert.
12199         * demangle.c: Revert.
12200         * dcache.h: Revert.
12201         * dcache.c: Revert.
12202         * darwin-nat.h: Revert.
12203         * darwin-nat.c: Revert.
12204         * darwin-nat-info.c: Revert.
12205         * d-valprint.c: Revert.
12206         * d-namespace.c: Revert.
12207         * d-lang.c: Revert.
12208         * ctf.c: Revert.
12209         * csky-tdep.c: Revert.
12210         * csky-linux-tdep.c: Revert.
12211         * cris-tdep.c: Revert.
12212         * cris-linux-tdep.c: Revert.
12213         * cp-valprint.c: Revert.
12214         * cp-support.c: Revert.
12215         * cp-namespace.c: Revert.
12216         * cp-abi.c: Revert.
12217         * corelow.c: Revert.
12218         * corefile.c: Revert.
12219         * continuations.c: Revert.
12220         * completer.h: Revert.
12221         * completer.c: Revert.
12222         * complaints.c: Revert.
12223         * coffread.c: Revert.
12224         * coff-pe-read.c: Revert.
12225         * cli-out.h: Revert.
12226         * cli-out.c: Revert.
12227         * charset.c: Revert.
12228         * c-varobj.c: Revert.
12229         * c-valprint.c: Revert.
12230         * c-typeprint.c: Revert.
12231         * c-lang.c: Revert.
12232         * buildsym.c: Revert.
12233         * buildsym-legacy.c: Revert.
12234         * build-id.h: Revert.
12235         * build-id.c: Revert.
12236         * btrace.c: Revert.
12237         * bsd-uthread.c: Revert.
12238         * breakpoint.h: Revert.
12239         * breakpoint.c: Revert.
12240         * break-catch-throw.c: Revert.
12241         * break-catch-syscall.c: Revert.
12242         * break-catch-sig.c: Revert.
12243         * blockframe.c: Revert.
12244         * block.c: Revert.
12245         * bfin-tdep.c: Revert.
12246         * bfin-linux-tdep.c: Revert.
12247         * bfd-target.c: Revert.
12248         * bcache.c: Revert.
12249         * ax-general.c: Revert.
12250         * ax-gdb.h: Revert.
12251         * ax-gdb.c: Revert.
12252         * avr-tdep.c: Revert.
12253         * auxv.c: Revert.
12254         * auto-load.c: Revert.
12255         * arm-wince-tdep.c: Revert.
12256         * arm-tdep.c: Revert.
12257         * arm-symbian-tdep.c: Revert.
12258         * arm-pikeos-tdep.c: Revert.
12259         * arm-obsd-tdep.c: Revert.
12260         * arm-nbsd-tdep.c: Revert.
12261         * arm-nbsd-nat.c: Revert.
12262         * arm-linux-tdep.c: Revert.
12263         * arm-linux-nat.c: Revert.
12264         * arm-fbsd-tdep.c: Revert.
12265         * arm-fbsd-nat.c: Revert.
12266         * arm-bsd-tdep.c: Revert.
12267         * arch-utils.c: Revert.
12268         * arc-tdep.c: Revert.
12269         * arc-newlib-tdep.c: Revert.
12270         * annotate.h: Revert.
12271         * annotate.c: Revert.
12272         * amd64-windows-tdep.c: Revert.
12273         * amd64-windows-nat.c: Revert.
12274         * amd64-tdep.c: Revert.
12275         * amd64-sol2-tdep.c: Revert.
12276         * amd64-obsd-tdep.c: Revert.
12277         * amd64-obsd-nat.c: Revert.
12278         * amd64-nbsd-tdep.c: Revert.
12279         * amd64-nbsd-nat.c: Revert.
12280         * amd64-nat.c: Revert.
12281         * amd64-linux-tdep.c: Revert.
12282         * amd64-linux-nat.c: Revert.
12283         * amd64-fbsd-tdep.c: Revert.
12284         * amd64-fbsd-nat.c: Revert.
12285         * amd64-dicos-tdep.c: Revert.
12286         * amd64-darwin-tdep.c: Revert.
12287         * amd64-bsd-nat.c: Revert.
12288         * alpha-tdep.c: Revert.
12289         * alpha-obsd-tdep.c: Revert.
12290         * alpha-nbsd-tdep.c: Revert.
12291         * alpha-mdebug-tdep.c: Revert.
12292         * alpha-linux-tdep.c: Revert.
12293         * alpha-linux-nat.c: Revert.
12294         * alpha-bsd-tdep.c: Revert.
12295         * alpha-bsd-nat.c: Revert.
12296         * aix-thread.c: Revert.
12297         * agent.c: Revert.
12298         * addrmap.c: Revert.
12299         * ada-varobj.c: Revert.
12300         * ada-valprint.c: Revert.
12301         * ada-typeprint.c: Revert.
12302         * ada-tasks.c: Revert.
12303         * ada-lang.c: Revert.
12304         * aarch64-tdep.c: Revert.
12305         * aarch64-ravenscar-thread.c: Revert.
12306         * aarch64-newlib-tdep.c: Revert.
12307         * aarch64-linux-tdep.c: Revert.
12308         * aarch64-linux-nat.c: Revert.
12309         * aarch64-fbsd-tdep.c: Revert.
12310         * aarch64-fbsd-nat.c: Revert.
12311         * aarch32-linux-nat.c: Revert.
12312
12313 2019-04-05  Tom Tromey  <tom@tromey.com>
12314
12315         * ft32-tdep.c: Sort headers.
12316         * frv-tdep.c: Sort headers.
12317         * frv-linux-tdep.c: Sort headers.
12318         * frame.c: Sort headers.
12319         * frame-unwind.c: Sort headers.
12320         * frame-base.c: Sort headers.
12321         * fork-child.c: Sort headers.
12322         * findvar.c: Sort headers.
12323         * findcmd.c: Sort headers.
12324         * filesystem.c: Sort headers.
12325         * filename-seen-cache.h: Sort headers.
12326         * filename-seen-cache.c: Sort headers.
12327         * fbsd-tdep.c: Sort headers.
12328         * fbsd-nat.h: Sort headers.
12329         * fbsd-nat.c: Sort headers.
12330         * f-valprint.c: Sort headers.
12331         * f-typeprint.c: Sort headers.
12332         * f-lang.c: Sort headers.
12333         * extension.h: Sort headers.
12334         * extension.c: Sort headers.
12335         * extension-priv.h: Sort headers.
12336         * expprint.c: Sort headers.
12337         * exec.h: Sort headers.
12338         * exec.c: Sort headers.
12339         * exceptions.c: Sort headers.
12340         * event-top.c: Sort headers.
12341         * event-loop.c: Sort headers.
12342         * eval.c: Sort headers.
12343         * elfread.c: Sort headers.
12344         * dwarf2read.h: Sort headers.
12345         * dwarf2read.c: Sort headers.
12346         * dwarf2loc.c: Sort headers.
12347         * dwarf2expr.h: Sort headers.
12348         * dwarf2expr.c: Sort headers.
12349         * dwarf2-frame.c: Sort headers.
12350         * dwarf2-frame-tailcall.c: Sort headers.
12351         * dwarf-index-write.h: Sort headers.
12352         * dwarf-index-write.c: Sort headers.
12353         * dwarf-index-common.c: Sort headers.
12354         * dwarf-index-cache.h: Sort headers.
12355         * dwarf-index-cache.c: Sort headers.
12356         * dummy-frame.c: Sort headers.
12357         * dtrace-probe.c: Sort headers.
12358         * disasm.h: Sort headers.
12359         * disasm.c: Sort headers.
12360         * disasm-selftests.c: Sort headers.
12361         * dictionary.c: Sort headers.
12362         * dicos-tdep.c: Sort headers.
12363         * demangle.c: Sort headers.
12364         * dcache.h: Sort headers.
12365         * dcache.c: Sort headers.
12366         * darwin-nat.h: Sort headers.
12367         * darwin-nat.c: Sort headers.
12368         * darwin-nat-info.c: Sort headers.
12369         * d-valprint.c: Sort headers.
12370         * d-namespace.c: Sort headers.
12371         * d-lang.c: Sort headers.
12372         * ctf.c: Sort headers.
12373         * csky-tdep.c: Sort headers.
12374         * csky-linux-tdep.c: Sort headers.
12375         * cris-tdep.c: Sort headers.
12376         * cris-linux-tdep.c: Sort headers.
12377         * cp-valprint.c: Sort headers.
12378         * cp-support.c: Sort headers.
12379         * cp-namespace.c: Sort headers.
12380         * cp-abi.c: Sort headers.
12381         * corelow.c: Sort headers.
12382         * corefile.c: Sort headers.
12383         * continuations.c: Sort headers.
12384         * completer.h: Sort headers.
12385         * completer.c: Sort headers.
12386         * complaints.c: Sort headers.
12387         * coffread.c: Sort headers.
12388         * coff-pe-read.c: Sort headers.
12389         * cli-out.h: Sort headers.
12390         * cli-out.c: Sort headers.
12391         * charset.c: Sort headers.
12392         * c-varobj.c: Sort headers.
12393         * c-valprint.c: Sort headers.
12394         * c-typeprint.c: Sort headers.
12395         * c-lang.c: Sort headers.
12396         * buildsym.c: Sort headers.
12397         * buildsym-legacy.c: Sort headers.
12398         * build-id.h: Sort headers.
12399         * build-id.c: Sort headers.
12400         * btrace.c: Sort headers.
12401         * bsd-uthread.c: Sort headers.
12402         * breakpoint.h: Sort headers.
12403         * breakpoint.c: Sort headers.
12404         * break-catch-throw.c: Sort headers.
12405         * break-catch-syscall.c: Sort headers.
12406         * break-catch-sig.c: Sort headers.
12407         * blockframe.c: Sort headers.
12408         * block.c: Sort headers.
12409         * bfin-tdep.c: Sort headers.
12410         * bfin-linux-tdep.c: Sort headers.
12411         * bfd-target.c: Sort headers.
12412         * bcache.c: Sort headers.
12413         * ax-general.c: Sort headers.
12414         * ax-gdb.h: Sort headers.
12415         * ax-gdb.c: Sort headers.
12416         * avr-tdep.c: Sort headers.
12417         * auxv.c: Sort headers.
12418         * auto-load.c: Sort headers.
12419         * arm-wince-tdep.c: Sort headers.
12420         * arm-tdep.c: Sort headers.
12421         * arm-symbian-tdep.c: Sort headers.
12422         * arm-pikeos-tdep.c: Sort headers.
12423         * arm-obsd-tdep.c: Sort headers.
12424         * arm-nbsd-tdep.c: Sort headers.
12425         * arm-nbsd-nat.c: Sort headers.
12426         * arm-linux-tdep.c: Sort headers.
12427         * arm-linux-nat.c: Sort headers.
12428         * arm-fbsd-tdep.c: Sort headers.
12429         * arm-fbsd-nat.c: Sort headers.
12430         * arm-bsd-tdep.c: Sort headers.
12431         * arch-utils.c: Sort headers.
12432         * arc-tdep.c: Sort headers.
12433         * arc-newlib-tdep.c: Sort headers.
12434         * annotate.h: Sort headers.
12435         * annotate.c: Sort headers.
12436         * amd64-windows-tdep.c: Sort headers.
12437         * amd64-windows-nat.c: Sort headers.
12438         * amd64-tdep.c: Sort headers.
12439         * amd64-sol2-tdep.c: Sort headers.
12440         * amd64-obsd-tdep.c: Sort headers.
12441         * amd64-obsd-nat.c: Sort headers.
12442         * amd64-nbsd-tdep.c: Sort headers.
12443         * amd64-nbsd-nat.c: Sort headers.
12444         * amd64-nat.c: Sort headers.
12445         * amd64-linux-tdep.c: Sort headers.
12446         * amd64-linux-nat.c: Sort headers.
12447         * amd64-fbsd-tdep.c: Sort headers.
12448         * amd64-fbsd-nat.c: Sort headers.
12449         * amd64-dicos-tdep.c: Sort headers.
12450         * amd64-darwin-tdep.c: Sort headers.
12451         * amd64-bsd-nat.c: Sort headers.
12452         * alpha-tdep.c: Sort headers.
12453         * alpha-obsd-tdep.c: Sort headers.
12454         * alpha-nbsd-tdep.c: Sort headers.
12455         * alpha-mdebug-tdep.c: Sort headers.
12456         * alpha-linux-tdep.c: Sort headers.
12457         * alpha-linux-nat.c: Sort headers.
12458         * alpha-bsd-tdep.c: Sort headers.
12459         * alpha-bsd-nat.c: Sort headers.
12460         * aix-thread.c: Sort headers.
12461         * agent.c: Sort headers.
12462         * addrmap.c: Sort headers.
12463         * ada-varobj.c: Sort headers.
12464         * ada-valprint.c: Sort headers.
12465         * ada-typeprint.c: Sort headers.
12466         * ada-tasks.c: Sort headers.
12467         * ada-lang.c: Sort headers.
12468         * aarch64-tdep.c: Sort headers.
12469         * aarch64-ravenscar-thread.c: Sort headers.
12470         * aarch64-newlib-tdep.c: Sort headers.
12471         * aarch64-linux-tdep.c: Sort headers.
12472         * aarch64-linux-nat.c: Sort headers.
12473         * aarch64-fbsd-tdep.c: Sort headers.
12474         * aarch64-fbsd-nat.c: Sort headers.
12475         * aarch32-linux-nat.c: Sort headers.
12476
12477 2019-04-04  Tom Tromey  <tom@tromey.com>
12478
12479         * varobj.c (varobj_create): Update.
12480         * rust-exp.y (struct rust_parser) <update_innermost_block,
12481         lookup_symbol>: New methods.
12482         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12483         Rename.
12484         (rust_parser::rust_lookup_type)
12485         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12486         * printcmd.c (display_command, do_one_display): Update.
12487         * parser-defs.h (struct parser_state) <parser_state>: Add
12488         "tracker" parameter.
12489         (block_tracker): New member.
12490         (class innermost_block_tracker) <innermost_block_tracker>: Add
12491         "types" parameter.
12492         <reset>: Remove method.
12493         (innermost_block): Don't declare.
12494         (null_post_parser): Update.
12495         * parse.c (innermost_block): Remove global.
12496         (write_dollar_variable): Update.
12497         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12498         Remove "tracker_types" parameter.
12499         (parse_expression): Add "tracker" parameter.
12500         (parse_expression_for_completion): Update.
12501         (null_post_parser): Add "tracker" parameter.
12502         * p-exp.y: Update rules.
12503         * m2-exp.y: Update rules.
12504         * language.h (struct language_defn) <la_post_parser>: Add
12505         "tracker" parameter.
12506         * go-exp.y: Update rules.
12507         * f-exp.y: Update rules.
12508         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12509         parameter.
12510         * d-exp.y: Update rules.
12511         * c-exp.y: Update rules.
12512         * breakpoint.c (set_breakpoint_condition): Create an
12513         innermost_block_tracker.
12514         (watch_command_1): Likewise.
12515         * ada-lang.c (resolve): Add "tracker" parameter.
12516         (resolve_subexp): Likewise.
12517         * ada-exp.y (write_var_from_sym): Update.
12518
12519 2019-04-04  Tom Tromey  <tom@tromey.com>
12520
12521         * type-stack.h: New file.
12522         * type-stack.c: New file.
12523         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12524         type-stack.h.
12525         (insert_into_type_stack, insert_type, push_type, push_type_int)
12526         (insert_type_address_space, pop_type, pop_type_int)
12527         (pop_typelist, pop_type_stack, append_type_stack)
12528         (push_type_stack, get_type_stack, push_typelist)
12529         (follow_type_instance_flags, follow_types): Don't declare.
12530         * parse.c (type_stack): Remove global.
12531         (parse_exp_in_context): Update.
12532         (insert_into_type_stack, insert_type, push_type, push_type_int)
12533         (insert_type_address_space, pop_type, pop_type_int)
12534         (pop_typelist, pop_type_stack, append_type_stack)
12535         (push_type_stack, get_type_stack, push_typelist)
12536         (follow_type_instance_flags, follow_types): Remove (moved to
12537         type-stack.c).
12538         * f-exp.y (type_stack): New global.
12539         Update rules.
12540         (push_kind_type, f_parse): Update.
12541         * d-exp.y (type_stack): New global.
12542         Update rules.
12543         (d_parse): Update.
12544         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12545         Update rules.
12546         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12547         (HFILES_NO_SRCDIR): Add type-stack.h.
12548
12549 2019-04-04  Tom Tromey  <tom@tromey.com>
12550
12551         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12552         (rust_parser::convert_ast_to_expression, rust_parse)
12553         (rust_lex_test_completion, rust_lex_tests): Update.
12554         * parser-defs.h (struct expr_completion_state): New.
12555         (struct parser_state) <parser_state>: Add completion parameter.
12556         <mark_struct_expression, mark_completion_tag>: New methods.
12557         <parse_completion, m_completion_state>: New members.
12558         (prefixify_expression, null_post_parser): Update.
12559         (mark_struct_expression, mark_completion_tag): Don't declare.
12560         * parse.c (parse_completion, expout_last_struct)
12561         (expout_tag_completion_type, expout_completion_name): Remove
12562         globals.
12563         (parser_state::mark_struct_expression)
12564         (parser_state::mark_completion_tag): Now methods.
12565         (prefixify_expression): Add last_struct parameter.
12566         (prefixify_subexp): Likewise.
12567         (parse_exp_1): Update.
12568         (parse_exp_in_context): Add cstate parameter.  Update.
12569         (parse_expression_for_completion): Create an
12570         expr_completion_state.
12571         (null_post_parser): Add "completion" parameter.
12572         * p-exp.y: Update rules.
12573         (yylex): Update.
12574         * language.h (struct language_defn) <la_post_parser>: Add
12575         "completing" parameter.
12576         * go-exp.y: Update rules.
12577         (lex_one_token): Update.
12578         * expression.h (parse_completion): Don't declare.
12579         * d-exp.y: Update rules.
12580         (lex_one_token): Update rules.
12581         * c-exp.y: Update rules.
12582         (lex_one_token): Update.
12583         * ada-lang.c (resolve): Add "parse_completion" parameter.
12584         (resolve_subexp): Likewise.
12585         (ada_resolve_function): Likewise.
12586
12587 2019-04-04  Tom Tromey  <tom@tromey.com>
12588
12589         * parser-defs.h (struct parser_state) <start_arglist,
12590         end_arglist>: New methods.
12591         <arglist_len, m_funcall_chain>: New members.
12592         (arglist_len, start_arglist, end_arglist): Don't declare.
12593         * parse.c (arglist_len, funcall_chain): Remove global.
12594         (start_arglist, end_arglist): Remove functions.
12595         (parse_exp_in_context): Update.
12596         * p-exp.y: Update rules.
12597         * m2-exp.y: Update rules.
12598         * go-exp.y: Update rules.
12599         * f-exp.y: Update rules.
12600         * d-exp.y: Update rules.
12601         * c-exp.y: Update rules.
12602
12603 2019-04-04  Tom Tromey  <tom@tromey.com>
12604
12605         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12606         lex_operator, push_back>: New methods.
12607         Update all rules.
12608         (rust_parser::lex_hex, lex_escape): Rename and update.
12609         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12610         (rust_parser::lex_operator): Rename and update.
12611         (rust_parser::lex_number, rustyylex, rustyyerror)
12612         (rust_lex_test_init, rust_lex_test_sequence)
12613         (rust_lex_test_push_back, rust_lex_tests): Update.
12614         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12615         parameter.
12616         <lexptr, prev_lexptr>: New members.
12617         (lexptr, prev_lexptr): Don't declare.
12618         * parse.c (lexptr, prev_lexptr): Remove globals.
12619         (parse_exp_in_context): Update.
12620         * p-exp.y (yylex, yyerror): Update.
12621         * m2-exp.y (parse_number, yylex, yyerror): Update.
12622         * go-exp.y (lex_one_token, yyerror): Update.
12623         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12624         * d-exp.y (lex_one_token, yyerror): Update.
12625         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12626         (lex_one_token, yyerror): Update.
12627         * ada-lex.l (YY_INPUT): Update.
12628         (rewind_to_char): Update.
12629         * ada-exp.y (yyerror): Update.
12630
12631 2019-04-04  Tom Tromey  <tom@tromey.com>
12632
12633         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12634         * parser-defs.h (struct parser_state) <parser_state>: Add new
12635         parameter.
12636         <comma_terminates>: New member.
12637         (comma_terminates): Don't declare global.
12638         * parse.c (comma_terminates): Remove global.
12639         (parse_exp_in_context): Update.
12640         * p-exp.y (yylex): Update.
12641         * m2-exp.y (yylex): Update.
12642         * go-exp.y (lex_one_token): Update.
12643         * f-exp.y (yylex): Update.
12644         * d-exp.y (lex_one_token): Update.
12645         * c-exp.y (lex_one_token): Update.
12646         * ada-lex.l: Update.
12647
12648 2019-04-04  Tom Tromey  <tom@tromey.com>
12649
12650         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12651         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12652         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12653         * parser-defs.h (paren_depth): Don't declare.
12654         * parse.c (paren_depth): Remove global.
12655         (parse_exp_in_context): Update.
12656         * p-exp.y (paren_depth): New global.
12657         (pascal_parse): Initialize it.
12658         * m2-exp.y (paren_depth): New global.
12659         (m2_parse): Initialize it.
12660         * go-exp.y (paren_depth): New global.
12661         (go_parse): Initialize it.
12662         * f-exp.y (paren_depth): New global.
12663         (f_parse): Initialize it.
12664         * d-exp.y (paren_depth): New global.
12665         (d_parse): Initialize it.
12666         * c-exp.y (paren_depth): New global.
12667         (c_parse): Initialize it.
12668         * ada-lex.l (paren_depth): New global.
12669         (lexer_init): Initialize it.
12670
12671 2019-04-04  Tom Tromey  <tom@tromey.com>
12672
12673         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12674         (rust_parser::convert_ast_to_type)
12675         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12676         * parser-defs.h (struct parser_state) <parser_state>: Add
12677         parameters.  Initialize new members.
12678         <expression_context_block, expression_context_pc>: New members.
12679         * parse.c (expression_context_block, expression_context_pc):
12680         Remove globals.
12681         (parse_exp_in_context): Update.
12682         * p-exp.y: Update all rules.
12683         (yylex): Update.
12684         * m2-exp.y: Update all rules.
12685         (yylex): Update.
12686         * go-exp.y (yylex): Update.
12687         * f-exp.y (yylex): Update.
12688         * d-exp.y: Update all rules.
12689         (yylex): Update.
12690         * c-exp.y: Update all rules.
12691         (lex_one_token, classify_name, yylex, c_parse): Update.
12692         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12693
12694 2019-04-04  Tom Tromey  <tom@tromey.com>
12695
12696         * gdbarch.h, gdbarch.c: Rebuild.
12697         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12698         * stap-probe.h:
12699         (struct stap_parse_info): Replace "parser_state" with
12700         "expr_builder".
12701         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12702         (parser_state): New class.
12703         * parse.c (expr_builder): Rename.
12704         (expr_builder::release): Rename.
12705         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12706         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12707         (write_exp_elt_longcst, write_exp_elt_floatcst)
12708         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12709         (write_exp_string_vector, write_exp_bitstring)
12710         (write_exp_msymbol, mark_struct_expression)
12711         (write_dollar_variable)
12712         (insert_type_address_space, increase_expout_size): Replace
12713         "parser_state" with "expr_builder".
12714         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12715         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12716         "parser_state" with "expr_builder".
12717
12718 2019-04-04  Tom Tromey  <tom@tromey.com>
12719
12720         * rust-exp.y: Replace "parse_language" with method call.
12721         * p-exp.y:
12722         (yylex): Replace "parse_language" with method call.
12723         * m2-exp.y:
12724         (yylex): Replace "parse_language" with method call.
12725         * go-exp.y (classify_name): Replace "parse_language" with method
12726         call.
12727         * f-exp.y (yylex): Replace "parse_language" with method call.
12728         * d-exp.y (lex_one_token): Replace "parse_language" with method
12729         call.
12730         * c-exp.y:
12731         (lex_one_token, classify_name, yylex): Replace "parse_language"
12732         with method call.
12733         * ada-exp.y (find_primitive_type, type_char)
12734         (type_system_address): Replace "parse_language" with method call.
12735
12736 2019-04-04  Tom Tromey  <tom@tromey.com>
12737
12738         * rust-exp.y: Replace "parse_gdbarch" with method call.
12739         * parse.c (write_dollar_variable, insert_type_address_space):
12740         Replace "parse_gdbarch" with method call.
12741         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12742         call.
12743         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12744         call.
12745         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12746         "parse_gdbarch" with method call.
12747         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12748         with method call.
12749         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12750         "parse_gdbarch" with method call.
12751         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12752         "parse_gdbarch" with method call.
12753         * c-exp.y (parse_type, parse_number, classify_name): Replace
12754         "parse_gdbarch" with method call.
12755         * ada-lex.l: Replace "parse_gdbarch" with method call.
12756         * ada-exp.y (parse_type, find_primitive_type, type_char)
12757         (type_system_address): Replace "parse_gdbarch" with method call.
12758
12759 2019-04-04  Tom Tromey  <tom@tromey.com>
12760
12761         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12762         * stap-probe.c (stap_parse_argument): Update.
12763         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12764         initial_size parameter.
12765         * rust-exp.y (rust_lex_tests): Update.
12766         * parse.c (parser_state): Update.
12767         (parse_exp_in_context): Update.
12768         * parser-defs.h (struct parser_state) <parser_state>: Remove
12769         "initial_size" parameter.
12770
12771 2019-04-04  Tom Tromey  <tom@tromey.com>
12772
12773         * parser-defs.h (increase_expout_size): Don't declare.
12774         * parse.c (increase_expout_size): Now static.
12775
12776 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12777
12778         * gnu-nat.c (gnu_nat_target::wait): Fix
12779         target_waitstatus_to_string call.
12780
12781 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12782
12783         * eval.c (evaluate_subexp_standard): Handle internal functions
12784         during Fortran function call handling.
12785
12786 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12787
12788         * NEWS: Mention new internal functions.
12789         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12790         (read_base_type): Use dwarf2_init_complex_target_type.
12791         * value.c (creal_internal_fn): New function.
12792         (cimag_internal_fn): New function.
12793         (_initialize_values): Register new internal functions.
12794
12795 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12796
12797         * infrun.c (stop_all_threads): If debug_infrun, always
12798         trace the wait status after wait_one, using
12799         target_waitstatus_to_string and target_pid_to_str.
12800         (handle_inferior_event): Replace various trace of
12801         wait status kind by a single trace.
12802         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12803         wait status kind image by target_waitstatus_to_string.
12804         * target/waitstatus.c (target_waitstatus_to_string): Fix
12805         obsolete comment.
12806
12807 2019-04-01  Tom Tromey  <tromey@adacore.com>
12808
12809         PR symtab/23331:
12810         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12811
12812 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12813             Pedro Alves  <palves@redhat.com>
12814
12815         * top.c (quit_force): Call 'finalize_values'.
12816         * value.c (finalize_values): New function.
12817         * value.h (finalize_values): Declare.
12818
12819 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12820
12821         * NEWS: Announce $_gdb_major and $_gdb_minor.
12822
12823         * top.c (init_gdb_version_vars): New function.
12824         (gdb_init): Call init_gdb_version_vars.
12825
12826 2019-03-29  Tom Tromey  <tromey@adacore.com>
12827
12828         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12829         help text.  Remove dead code.
12830
12831 2019-03-29  Keith Seitz  <keiths@redhat.com>
12832
12833         From Siddhesh Poyarekar:
12834         * f-lang.h (f77_get_upperbound): Return LONGEST.
12835         (f77_get_lowerbound): Likewise.
12836         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12837         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12838         print them.
12839         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12840         plongest to format print it.
12841         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12842         (f77_get_upperbound): Likewise.
12843         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12844         LOWER_BOUND to LONGEST.
12845         (f77_create_arrayprint_offset_tbl): Likewise.
12846
12847 2019-03-29  Keith Seitz  <keiths@redhat.com>
12848
12849         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12850         %s/pulongest for TYPE_LENGTH instead of %d in format
12851         strings.
12852         * ada-typerint.c (ada_print_type): Likewise.
12853         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12854         * compile/compile-c-support.c (generate_register_struct): Likewise.
12855         * gdbtypes.c (recursive_dump_type): Likewise.
12856         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12857         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12858         instead of %d in format strings.
12859         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12860         to std::min to ULONGEST.
12861         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12862         instead of %d in format strings.
12863         * tracepoint.c (info_scope_command): Likewise.
12864         * typeprint.c (print_offset_data::update)
12865         (print_offset_data::finish): Likewise.
12866         * xtensa-tdep.c (xtensa_store_return_value)
12867         (xtensa_push_dummy_call): Likewise.
12868
12869 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12870
12871         * windows-nat.c (display_selector): Fixed format specifications
12872         for 64-bit Cygwin.
12873
12874 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12875
12876         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12877
12878 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12879
12880         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12881         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12882         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12883         (nios2_linux_init_abi): Install it.
12884
12885 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12886
12887         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12888
12889 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12890
12891         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12892
12893 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12894             Tom Tromey  <tromey@adacore.com>
12895
12896         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12897
12898 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12899
12900         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12901         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12902         method to compute the bounds of range types. Also print "[evaluated]"
12903         if the bounds' values come from a dynamic evaluation.
12904
12905 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12906
12907         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12908         whitespace when pretty printing is on.
12909
12910 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12911
12912         * ppc-linux-nat.c: Add include.
12913
12914 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12915
12916         * NEWS: Mention AArch64 Pointer Authentication.
12917
12918 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12919
12920         * arm-linux-nat.c: Add include.
12921
12922 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12923
12924         * source-cache.c (source_cache::get_source_lines): Re-read
12925         fullname after calling open_source_file.
12926
12927 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12928
12929         * NEWS: Mention TLS support for FreeBSD.
12930
12931 2019-03-25  Tom Tromey  <tromey@adacore.com>
12932
12933         * minsyms.c (BUNCH_SIZE): Update comment.
12934         (~minimal_symbol_reader): Remove old comment.
12935         (compact_minimal_symbols): Update comment.
12936         (minimal_symbol_reader::install): Remove old comment.  Update
12937         other comments.
12938
12939 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12940
12941         * s390-linux-nat.c: Add include.
12942
12943 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12944
12945         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12946         Call linux_get_hwcap.
12947         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12948         Likewise.
12949         (aarch64_linux_get_hwcap): Remove function.
12950         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12951         declaration.
12952         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12953         linux_get_hwcap.
12954         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12955         * linux-tdep.c (linux_get_hwcap): Add function.
12956         (linux_get_hwcap2): Likewise.
12957         * linux-tdep.h (linux_get_hwcap): Add declaration.
12958         (linux_get_hwcap2): Likewise.
12959         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12960         (ppc_linux_get_hwcap2): Likewise.
12961         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12962         linux_get_hwcap.
12963         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12964         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12965         (ppc_linux_nat_target::read_description): Likewise.
12966         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12967         * s390-linux-nat.c: Likewise.
12968         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12969
12970 2019-03-24  Tom Tromey  <tom@tromey.com>
12971
12972         * ada-lang.c (standard_lookup): Simplify initialization.
12973         (ada_lookup_symbol_nonlocal): Simplify return.
12974         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12975         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12976         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12977         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12978         initialization.
12979         * solib.c (solib_global_lookup): Simplify.
12980         * symtab.c (null_block_symbol): Remove.
12981         (symbol_cache_lookup): Simplify returns.
12982         (lookup_language_this): Simplify returns.
12983         (lookup_symbol_aux): Simplify return.
12984         (lookup_local_symbol): Simplify returns.
12985         (lookup_global_symbol_from_objfile): Simplify return.
12986         (lookup_symbol_in_objfile_symtabs)
12987         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12988         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12989         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12990         * cp-namespace.c (cp_lookup_bare_symbol)
12991         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12992         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12993         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12994         (cp_lookup_symbol_via_imports): Simplify initialization.
12995         (find_symbol_in_baseclass): Likewise.
12996         * symtab.h (null_block_symbol): Remove.
12997         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12998         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12999         (d_lookup_symbol_module): Likewise.
13000         (find_symbol_in_baseclass): Simplify initialization.
13001
13002 2019-03-24  Tom Tromey  <tom@tromey.com>
13003
13004         * expression.h: Don't include symtab.h.
13005         (struct block): Forward declare.
13006
13007 2019-03-24  Tom Tromey  <tom@tromey.com>
13008
13009         * c-exp.y (typebase): Remove casts.
13010         * gdbtypes.c (lookup_unsigned_typename, )
13011         (lookup_signed_typename): Remove cast.
13012         * eval.c (parse_to_comma_and_eval): Remove cast.
13013         * parse.c (write_dollar_variable): Remove cast.
13014         * block.h (struct block) <superblock>: Now const.
13015         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13016         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13017         (map_block): Make "block" const.
13018         * symfile.h (struct quick_symbol_functions)
13019         <map_matching_symbols>: Constify block argument to "callback".
13020         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13021         const.
13022         (find_pc_sect_compunit_symtab): Make "b" const.
13023         (find_symbol_at_address): Likewise.
13024         (search_symbols): Likewise.
13025         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13026         (dw2_debug_names_lookup_symbol): Likewise.
13027         (dw2_map_matching_symbols): Update.
13028         * p-valprint.c (pascal_val_print): Remove "block".
13029         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13030         (aux_add_nonlocal_symbols): Make "block" const.
13031         (resolve_subexp): Remove cast.
13032         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13033         const.
13034         (iterate_over_file_blocks): Likewise.
13035         * f-exp.y (%union) <bval>: Remove.
13036         * coffread.c (patch_opaque_types): Make "b" const.
13037         * spu-tdep.c (spu_catch_start): Make "block" const.
13038         * c-valprint.c (print_unpacked_pointer): Remove "block".
13039         * symmisc.c (dump_symtab_1): Make "b" const.
13040         (block_depth): Make "block" const.
13041         * d-exp.y (%union) <bval>: Remove.
13042         * cp-support.h (cp_lookup_rtti_type): Update.
13043         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13044         * psymtab.c (psym_lookup_symbol): Make "block" const.
13045         (maintenance_check_psymtabs): Make "b" const.
13046         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13047         (enumerate_locals, enumerate_args): Update.
13048         * python/py-symtab.c (stpy_global_block): Make "block" const.
13049         (stpy_static_block): Likewise.
13050         * inline-frame.c (block_starting_point_at): Make "new_block"
13051         const.
13052         * block.c (find_block_in_blockvector): Make return type const.
13053         (blockvector_for_pc_sect): Make "b" const.
13054         (find_block_in_blockvector): Make "b" const.
13055
13056 2019-03-23  Tom Tromey  <tom@tromey.com>
13057
13058         * varobj.c (varobj_create): Update.
13059         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13060         * printcmd.c (display_command, do_one_display): Don't reset
13061         innermost_block.
13062         * parser-defs.h (enum innermost_block_tracker_type): Move to
13063         expression.h.
13064         (innermost_block): Update comment.
13065         * parse.c (parse_exp_1): Add tracker_types parameter.
13066         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13067         tracker_types parameter.  Reset innermost_block.
13068         (parse_exp_in_context): Remove.
13069         (parse_expression_for_completion): Update.
13070         * objfiles.c (~objfile): Don't reset expression_context_block or
13071         innermost_block.
13072         * expression.h (enum innermost_block_tracker_type): Move from
13073         parser-defs.h.
13074         (parse_exp_1): Add tracker_types parameter.
13075         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13076         reset innermost_block.
13077
13078 2019-03-23  Tom Tromey  <tom@tromey.com>
13079
13080         * objfiles.h: Include bcache.h.
13081
13082 2019-03-23  Tom Tromey  <tom@tromey.com>
13083
13084         * linespec.c (get_current_search_block): Use
13085         scoped_restore_current_language.
13086         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13087
13088 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13089             Jiong Wang  <jiong.wang@arm.com>
13090
13091         * aarch64-linux-tdep.c
13092         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13093         section.
13094         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13095
13096 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13097             Jiong Wang  <jiong.wang@arm.com>
13098
13099         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13100         instructions.
13101         (aarch64_analyze_prologue_test): Add PACIASP test.
13102         (aarch64_prologue_prev_register): Unmask PC value.
13103
13104 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13105             Jiong Wang  <jiong.wang@arm.com>
13106
13107         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13108         (aarch64_dwarf2_prev_register): Unmask PC value.
13109         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13110         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13111         DW_CFA_AARCH64_negate_ra_state.
13112         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13113
13114 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13115             Jiong Wang  <jiong.wang@arm.com>
13116
13117         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13118         registers.
13119         (aarch64_pseudo_register_name): Likewise.
13120         (aarch64_pseudo_register_type): Likewise.
13121         (aarch64_pseudo_register_reggroup_p): Likewise.
13122         (aarch64_gdbarch_init): Add pauth registers.
13123         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13124         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13125         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13126         (struct gdbarch_tdep): Add regnum for ra_state.
13127
13128 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13129             Jiong Wang  <jiong.wang@arm.com>
13130
13131         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13132
13133 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13134             Jiong Wang  <jiong.wang@arm.com>
13135
13136         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13137         function.
13138         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13139         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13140         (aarch64_gdbarch_init): Add puth registers.
13141         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13142         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13143         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13144
13145 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13146             Jiong Wang  <jiong.wang@arm.com>
13147
13148         * aarch64-linux-nat.c
13149         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13150         * aarch64-linux-tdep.c
13151         (aarch64_linux_core_read_description): Likewise.
13152         (aarch64_linux_get_hwcap): New function.
13153         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13154         (aarch64_linux_get_hwcap): New declaration.
13155
13156 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13157             Jiong Wang  <jiong.wang@arm.com>
13158
13159         * aarch64-linux-nat.c
13160         (aarch64_linux_nat_target::read_description): Add pauth param.
13161         * aarch64-linux-tdep.c
13162         (aarch64_linux_core_read_description): Likewise.
13163         * aarch64-tdep.c (struct target_desc): Add in pauth.
13164         (aarch64_read_description): Add pauth param.
13165         (aarch64_gdbarch_init): Likewise.
13166         * aarch64-tdep.h (aarch64_read_description): Likewise.
13167         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13168         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13169         * features/Makefile: Add new files.
13170         * features/aarch64-pauth.c: New file.
13171         * features/aarch64-pauth.xml: New file.
13172
13173 2019-03-20  Tom Tromey  <tromey@adacore.com>
13174
13175         * infrun.c (handle_inferior_event): Rename from
13176         handle_inferior_event_1.  Create a scoped_value_mark.
13177         (handle_inferior_event): Remove.
13178
13179 2019-03-19  Tom Tromey  <tromey@adacore.com>
13180
13181         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13182         * infrun.h (print_stop_event): Add "displays" parameter.
13183         * infrun.c (print_stop_event): Add "displays" parameter.
13184
13185 2019-03-19  Pedro Alves  <palves@redhat.com>
13186
13187         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13188         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13189         to -1.  Fix TABs vs spaces.
13190         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13191         * tui/tui-out.h (tui_ui_out) Add intro comments.
13192         <m_line, m_start_of_line>: In-class initialize, and add describing
13193         comment.
13194
13195 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13196
13197         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13198         variable names.
13199         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13200
13201 2019-03-18  Pedro Alves  <palves@redhat.com>
13202             Eli Zaretskii <eliz@gnu.org>
13203
13204         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13205         m_line and m_start_of_line.
13206
13207 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13208
13209         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13210         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13211         it returns a newline.  This fixes a regression in TU mode, whereby
13212         the next line is output on the same screen line as the user input.
13213
13214 2019-03-18  Tom Tromey  <tromey@adacore.com>
13215
13216         * minsyms.c (minimal_symbol_reader::install): Remove call to
13217         obstack_blank.
13218
13219 2019-03-18  Pedro Alves  <palves@redhat.com>
13220
13221         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13222         New globals.
13223         (apply_style): New, factored out from ...
13224         (apply_ansi_escape): ... this.  Handle reverse video mode.
13225         (tui_set_reverse_mode): New function.
13226         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13227         * tui/tui-winsource.c (tui_show_source_line): Use
13228         tui_set_reverse_mode instead of setting A_STANDOUT.
13229         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13230         New setter methods.
13231
13232 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13233
13234         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13235         Handle tabs.
13236
13237 2019-03-18  Tom Tromey  <tromey@adacore.com>
13238
13239         * ada-lang.c (empty_array): Add "high" parameter.
13240         (ada_evaluate_subexp): Update.
13241
13242 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13243
13244         * unittests/string_view-selftests.c: Define
13245         _initialize_string_view_selftests unconditionally.
13246
13247 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13248
13249         PR gdb/24350
13250         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13251
13252 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13253
13254         PR gdb/24351
13255         * windows-nat.c (display_selector): Fix format specifiers.
13256
13257 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13258
13259         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13260         tui_refill_source_window instead of tui_refresh_win, to update the
13261         current execution line.  This fixes redisplay of the current line
13262         when stepping through the code with "next" or "step".
13263
13264 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13265
13266         * source-cache.c (source_cache::get_source_lines): Call
13267         find_source_lines to initialize s->nlines.  This fixes vertical
13268         scrolling of TUI source window when the DOWN arrow is pressed.
13269
13270 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13271
13272         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13273         linux-thread-db.c (_initialize_thread_db): Likewise.
13274
13275 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13276
13277         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13278         wclrtoeol in tui_show_source_line".  This reverts changes made in
13279         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13280
13281 2019-03-15  Tom Tromey  <tom@tromey.com>
13282
13283         * symtab.h (struct minimal_symbol): Derive from
13284         general_symbol_info.
13285         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13286         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13287         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13288         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13289         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13290         (MSYMBOL_SEARCH_NAME): Update.
13291         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13292         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13293         * minsyms.c (minimal_symbol_reader::record_full): Update.
13294
13295 2019-03-15  Tom Tromey  <tom@tromey.com>
13296
13297         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13298
13299 2019-03-15  Tom Tromey  <tom@tromey.com>
13300
13301         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13302         unique_xmalloc_ptr.
13303         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13304         Update.
13305         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13306         (build_minimal_symbol_hash_tables)
13307         (minimal_symbol_reader::install): Update.
13308
13309 2019-03-15  Tom Tromey  <tom@tromey.com>
13310
13311         * symtab.c (create_demangled_names_hash): Update.
13312         (symbol_set_names): Update.
13313         * objfiles.h (struct objfile_per_bfd_storage)
13314         <demangled_names_hash>: Now an htab_up.
13315         * objfiles.c (objfile_per_bfd_storage): Simplify.
13316
13317 2019-03-15  Tom Tromey  <tom@tromey.com>
13318
13319         * objfiles.h (struct objfile_per_bfd_storage): Declare
13320         destructor.
13321         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13322         New.
13323         (get_objfile_bfd_data): Use new.  Don't initialize
13324         language_of_main.
13325         (free_objfile_per_bfd_storage): Remove.
13326         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13327
13328 2019-03-15  Tom Tromey  <tom@tromey.com>
13329
13330         * symfile.c (reread_symbols): Update.
13331         * objfiles.c (objfile::objfile): Update.
13332         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13333         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13334         comment.
13335         (minimal_symbol_reader::install): Update.
13336         (terminate_minimal_symbol_table): Remove.
13337         * jit.c (jit_object_close_impl): Update.
13338
13339 2019-03-15  Tom Tromey  <tom@tromey.com>
13340
13341         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13342         initializations.
13343
13344 2019-03-15  Tom Tromey  <tom@tromey.com>
13345
13346         * objfiles.h (struct objfile_per_bfd_storage)
13347         <demangled_hash_languages>: Now a bitset.
13348         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13349         (lookup_minimal_symbol): Update.
13350
13351 2019-03-15  Tom Tromey  <tom@tromey.com>
13352
13353         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13354         Don't return the symbol.
13355         * coffread.c (record_minimal_symbol): Use record_full.
13356
13357 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13358
13359         The MS-Windows port of ncurses fails to switch to a color pair if
13360         one or both of the colors are the implicit default colors.  This
13361         change records the default colors when TUI is initialized, and
13362         then specifies them explicitly when a color pair uses the default
13363         colors.  This allows color styling in TUI mode on MS-Windows.
13364
13365         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13366         ncurses_norm_attr.
13367         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13368         colors in ncurses_norm_attr.
13369         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13370         "none", replace it with the default color recorded in
13371         ncurses_norm_attr.
13372
13373 2019-03-14  Tom Tromey  <tromey@adacore.com>
13374
13375         * source-cache.h (class source_cache) <get_source_lines>: Return
13376         std::string.
13377         * source-cache.c (source_cache::extract_lines): Handle case where
13378         first_pos==npos.  Return std::string.
13379         (source_cache::get_source_lines): Update.
13380
13381 2019-03-14  Tom Tromey  <tromey@adacore.com>
13382
13383         * NEWS: Add item for "style sources" commands.
13384         * source-cache.c (source_cache::get_source_lines): Check
13385         source_styling.
13386         * cli/cli-style.c (source_styling): New global.
13387         (_initialize_cli_style): Add "style sources" commands.
13388         (show_style_sources): New function.
13389         * cli/cli-style.h (source_styling): Declare.
13390
13391 2019-03-14  Pedro Alves  <palves@redhat.com>
13392             Tom Tromey  <tromey@adacore.com>
13393
13394         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13395         * tui/tui-winsource.c (tui_refill_source_window): New function,
13396         from...
13397         (tui_horizontal_source_scroll): ... here.  Move some logic.
13398         * cli/cli-style.c (set_style_enabled): Notify new observable.
13399         * tui/tui-hooks.c (tui_redisplay_source): New function.
13400         (tui_attach_detach_observers): Attach or detach
13401         tui_redisplay_source.
13402         * observable.h (source_styling_changed): New observable.
13403         * observable.c: Define source_styling_changed observable.
13404
13405 2019-03-13  Tom Tromey  <tromey@adacore.com>
13406
13407         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13408         (i386_gnu_nat_target::store_registers): Update.
13409         * target-debug.h (target_debug_print_std_string): New macro.
13410         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13411         * windows-tdep.c (display_one_tib): Update.
13412         * tui/tui-stack.c (tui_make_status_line): Update.
13413         * top.c (print_inferior_quit_action): Update.
13414         * thread.c (thr_try_catch_cmd): Update.
13415         (add_thread_with_info): Update.
13416         (thread_target_id_str): Update.
13417         (thr_try_catch_cmd): Update.
13418         (thread_command): Update.
13419         (thread_find_command): Update.
13420         * record-btrace.c (record_btrace_target::info_record)
13421         (record_btrace_resume_thread, record_btrace_target::resume)
13422         (record_btrace_cancel_resume, record_btrace_step_thread)
13423         (record_btrace_target::wait, record_btrace_target::wait)
13424         (record_btrace_target::wait, record_btrace_target::stop): Update.
13425         * progspace.c (print_program_space): Update.
13426         * process-stratum-target.c
13427         (process_stratum_target::thread_address_space): Update.
13428         * linux-fork.c (linux_fork_mourn_inferior)
13429         (detach_checkpoint_command, info_checkpoints_command)
13430         (linux_fork_context): Update.
13431         (linux_fork_detach): Update.
13432         (class scoped_switch_fork_info): Update.
13433         (delete_checkpoint_command): Update.
13434         * infrun.c (follow_fork_inferior): Update.
13435         (follow_fork_inferior): Update.
13436         (proceed_after_vfork_done): Update.
13437         (handle_vfork_child_exec_or_exit): Update.
13438         (follow_exec): Update.
13439         (displaced_step_prepare_throw): Update.
13440         (displaced_step_restore): Update.
13441         (start_step_over): Update.
13442         (resume_1): Update.
13443         (clear_proceed_status_thread): Update.
13444         (proceed): Update.
13445         (print_target_wait_results): Update.
13446         (do_target_wait): Update.
13447         (context_switch): Update.
13448         (stop_all_threads): Update.
13449         (restart_threads): Update.
13450         (finish_step_over): Update.
13451         (handle_signal_stop): Update.
13452         (switch_back_to_stepped_thread): Update.
13453         (keep_going_pass_signal): Update.
13454         (print_exited_reason): Update.
13455         (normal_stop): Update.
13456         * inferior.c (inferior_pid_to_str): Change return type.
13457         (print_selected_inferior): Update.
13458         (add_inferior): Update.
13459         (detach_inferior): Update.
13460         * dummy-frame.c (fprint_dummy_frames): Update.
13461         * dcache.c (dcache_info_1): Update.
13462         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13463         (btrace_fetch, btrace_clear): Update.
13464         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13465         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13466         type.
13467         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13468         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13469         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13470         * gdbarch.c, gdbarch.h: Rebuild.
13471         * gdbarch.sh (core_pid_to_str): Change return type.
13472         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13473         return type.
13474         (windows_nat_target::pid_to_str): Change return type.
13475         (windows_delete_thread): Update.
13476         (windows_nat_target::attach): Update.
13477         (windows_nat_target::files_info): Update.
13478         * target-delegates.c: Rebuild.
13479         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13480         return type.
13481         (sol_thread_target::pid_to_str): Change return type.
13482         * remote.c (class remote_target) <pid_to_str>: Change return
13483         type.
13484         (remote_target::pid_to_str): Change return type.
13485         (extended_remote_target::attach, remote_target::remote_stop_ns)
13486         (remote_target::remote_notif_remove_queued_reply)
13487         (remote_target::push_stop_reply, remote_target::disable_btrace):
13488         Update.
13489         (extended_remote_target::attach): Update.
13490         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13491         type.
13492         (gdbsim_target::pid_to_str): Change return type.
13493         * ravenscar-thread.c (struct ravenscar_thread_target)
13494         <pid_to_str>: Change return type.
13495         (ravenscar_thread_target::pid_to_str): Change return type.
13496         * procfs.c (class procfs_target) <pid_to_str>: Change return
13497         type.
13498         (procfs_target::pid_to_str): Change return type.
13499         (procfs_target::attach): Update.
13500         (procfs_target::detach): Update.
13501         (procfs_target::fetch_registers): Update.
13502         (procfs_target::store_registers): Update.
13503         (procfs_target::wait): Update.
13504         (procfs_target::files_info): Update.
13505         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13506         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13507         return type.
13508         (nto_procfs_target::pid_to_str): Change return type.
13509         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13510         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13511         return type.
13512         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13513         (exit_lwp): Update.
13514         (attach_proc_task_lwp_callback, get_detach_signal)
13515         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13516         (linux_nat_target::resume, wait_lwp, stop_callback)
13517         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13518         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13519         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13520         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13521         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13522         type.
13523         (inf_ptrace_target::attach): Update.
13524         (inf_ptrace_target::files_info): Update.
13525         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13526         type.
13527         (go32_nat_target::pid_to_str): Change return type.
13528         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13529         (gnu_nat_target::wait): Update.
13530         (gnu_nat_target::wait): Update.
13531         (gnu_nat_target::resume): Update.
13532         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13533         (fbsd_nat_target::wait): Update.
13534         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13535         type.
13536         (darwin_nat_target::attach): Update.
13537         * corelow.c (class core_target) <pid_to_str>: Change return type.
13538         (core_target::pid_to_str): Change return type.
13539         * target.c (normal_pid_to_str): Change return type.
13540         (default_pid_to_str): Likewise.
13541         (target_pid_to_str): Change return type.
13542         (target_translate_tls_address): Update.
13543         (target_announce_detach): Update.
13544         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13545         return type.
13546         (bsd_uthread_target::pid_to_str): Change return type.
13547         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13548         type.
13549         (bsd_kvm_target::pid_to_str): Change return type.
13550         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13551         return type.
13552         (aix_thread_target::pid_to_str): Change return type.
13553         * target.h (struct target_ops) <pid_to_str>: Change return type.
13554         (target_pid_to_str, normal_pid_to_str): Likewise.
13555         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13556         type.
13557         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13558         type.
13559         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13560         return type.
13561         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13562         type.
13563         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13564         type.
13565         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13566         return type.
13567
13568 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13569
13570         * NEWS: Mention that the new default MI version is 3.  Mention
13571         changes to the output of commands and events that deal with
13572         multi-location breakpoints.
13573         * breakpoint.c: Include "mi/mi-out.h".
13574         (print_one_breakpoint): Change output syntax if using MI version
13575         >= 3.
13576         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13577         New.
13578         (mi_multi_location_breakpoint_output_fixed): New.
13579         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13580         (mi_cmd_fix_multi_location_breakpoint_output): New.
13581         (mi_multi_location_breakpoint_output_fixed): New.
13582         * mi/mi-cmds.c (mi_cmds): Register command
13583         -fix-multi-location-breakpoint-output.
13584         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13585         interpreter "mi".
13586
13587 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13588
13589         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13590         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13591         instantiate mi_ui_out based on interpreter name.
13592         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13593         * mi/mi-main.c (mi_load_progress): Likewise.
13594
13595 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13596
13597         * NEWS: Combine separate "New targets" sections for 8.3.
13598
13599 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13600
13601         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13602         (ppcfbsd_init_abi): Install gdbarch
13603         "fetch_tls_load_module_address" and "get_thread_local_address"
13604         methods.
13605
13606 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13607
13608         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13609         (riscv_fbsd_init_abi): Install gdbarch
13610         "fetch_tls_load_module_address" and "get_thread_local_address"
13611         methods.
13612
13613 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13614
13615         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13616         (i386fbsd_init_abi): Install gdbarch
13617         "fetch_tls_load_module_address" and "get_thread_local_address"
13618         methods.
13619
13620 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13621
13622         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13623         (amd64fbsd_init_abi): Install gdbarch
13624         "fetch_tls_load_module_address" and "get_thread_local_address"
13625         methods.
13626
13627 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13628
13629         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13630         (struct fbsd_pspace_data): New type.
13631         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13632         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13633         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13634         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13635         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13636
13637 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13638
13639         * gdbtypes.c (lookup_struct_elt): New function.
13640         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13641         * gdbtypes.h (struct struct_elt): New type.
13642         (lookup_struct_elt): New prototype.
13643
13644 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13645
13646         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13647         remove disabled code block.
13648
13649 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13650
13651         * gdbarch.sh (get_thread_local_address): New method.
13652         * gdbarch.h, gdbarch.c: Regenerate.
13653         * target.c (target_translate_tls_address): Use
13654         gdbarch_get_thread_local_address if present instead of
13655         target::get_thread_local_address.
13656
13657 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13658
13659         * target.h (target::get_thread_local_address): Update comment.
13660
13661 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13662
13663         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13664         objfile->separate_debug_objfile_backlink if not NULL.
13665
13666 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13667
13668         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13669         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13670         (amd64bsd_store_inferior_registers): Likewise.
13671         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13672         Enable segment base registers.
13673         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13674         PT_GETFSBASE and PT_GETGSBASE.
13675         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13676         PT_SETGSBASE.
13677         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13678         segment base registers.
13679         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13680
13681 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13682
13683         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13684         Update calls to i386_target_description to add 'segments'
13685         parameter.
13686         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13687         add segment base registers.
13688         * arch/i386.c (i386_create_target_description): Add 'segments'
13689         parameter to enable segment base registers.
13690         * arch/i386.h (i386_create_target_description): Likewise.
13691         * features/i386/32bit-segments.xml: New file.
13692         * features/i386/32bit-segments.c: Generate.
13693         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13694         call to i386_target_description to add 'segments' parameter.
13695         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13696         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13697         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13698         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13699         if feature is present.
13700         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13701         Add 'segments' parameter to call to i386_target_description.
13702         (i386_target_description): Add 'segments' parameter to enable
13703         segment base registers.
13704         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13705         to call to i386_target_description.
13706         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13707         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13708         Define I386_NUM_REGS.
13709         (i386_target_description): Add 'segments' parameter to enable
13710         segment base registers.
13711
13712 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13713
13714         PR/24325
13715         * source-cache.c: #undef open and close, to avoid unresolved
13716         externals during linking.
13717
13718 2019-03-12  Tom Tromey  <tromey@adacore.com>
13719
13720         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13721         const.  Add initializers.
13722         (_initialize_remote): Don't initialize ptid globals.
13723
13724 2019-03-12  Pedro Alves  <palves@redhat.com>
13725
13726         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13727
13728 2019-03-12  Pedro Alves  <palves@redhat.com>
13729
13730         * cp-name-parser.y (main): Remove unused 'len' variable.
13731
13732 2019-03-12  Tom Tromey  <tromey@adacore.com>
13733
13734         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13735         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13736
13737 2019-03-12  Tom Tromey  <tromey@adacore.com>
13738
13739         * linux-nat.c (iterate_over_lwps): Update.
13740         (stop_callback): Remove parameter.
13741         (stop_wait_callback, detach_callback, resume_set_callback)
13742         (select_singlestep_lwp_callback, set_ignore_sigint)
13743         (status_callback, resumed_callback, resume_clear_callback)
13744         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13745         data parameter.
13746         (linux_nat_target::detach, linux_nat_target::resume)
13747         (linux_stop_and_wait_all_lwps, select_event_lwp)
13748         (linux_nat_filter_event, linux_nat_wait_1)
13749         (linux_nat_target::kill, linux_nat_target::stop)
13750         (linux_nat_target::stop): Update.
13751         (linux_nat_resume_callback): Change type.
13752         (resume_stopped_resumed_lwps, count_events_callback)
13753         (select_event_lwp_callback): Likewise.
13754         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13755         * arm-linux-nat.c (struct update_registers_data): Remove.
13756         (update_registers_callback): Change type.
13757         (arm_linux_insert_hw_breakpoint1): Update.
13758         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13759         parameter.
13760         (x86_linux_dr_set_addr): Update.
13761         (x86_linux_dr_set_control): Update.
13762         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13763         (iterate_over_lwps): Use gdb::function_view.
13764         * nat/aarch64-linux-hw-point.c (struct
13765         aarch64_dr_update_callback_param): Remove.
13766         (debug_reg_change_callback): Change type.
13767         (aarch64_notify_debug_reg_change): Update.
13768         * s390-linux-nat.c (s390_refresh_per_info): Update.
13769
13770 2019-03-11  Tom Tromey  <tromey@adacore.com>
13771
13772         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13773         redundant assignment to "this_cu".
13774
13775 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13776
13777         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13778
13779 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13780
13781         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13782         from...
13783         (rank_one_type): ... this.
13784
13785 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13786
13787         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13788         from...
13789         (rank_one_type): ... this.
13790
13791 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13792
13793         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13794         from...
13795         (rank_one_type): ... this.
13796
13797 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13798
13799         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13800         from...
13801         (rank_one_type): ... this.
13802
13803 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13804
13805         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13806         from...
13807         (rank_one_type): ... this.
13808
13809 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13810
13811         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13812         from...
13813         (rank_one_type): ... this.
13814
13815 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13816
13817         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13818         from...
13819         (rank_one_type): ... this.
13820
13821 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13822
13823         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13824         from...
13825         (rank_one_type): ... this.
13826
13827 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13828
13829         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13830         from...
13831         (rank_one_type): ... this.
13832
13833 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13834
13835         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13836         from...
13837         (rank_one_type): ... this.
13838
13839 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13840
13841         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13842         from...
13843         (rank_one_type): ... this.
13844
13845 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13846
13847         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13848         from...
13849         (rank_one_type): ... this.
13850
13851 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13852
13853         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13854         inferior-events' shows the example events.
13855
13856 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13857
13858         Support styling on native MS-Windows console
13859
13860         PR/24315
13861         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13862         on MS-Windows if $TERM is not defined.
13863
13864         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13865
13866         * posix-hdep.c (gdb_console_fputs):
13867         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13868         functions.
13869         * ui-file.h (gdb_console_fputs): Add prototype.
13870
13871         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13872         back to fputs only if the former returns zero.
13873
13874 2019-03-07  Tom Tromey  <tom@tromey.com>
13875
13876         * symmisc.c (print_symbol_bcache_statistics): Update.
13877         (print_objfile_statistics): Update.
13878         * symfile.c (allocate_symtab): Update.
13879         * stabsread.c: Don't include bcache.h.
13880         * psymtab.h (struct psymbol_bcache): Don't declare.
13881         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13882         (psymbol_bcache_init, psymbol_bcache_free)
13883         (psymbol_bcache_get_bcache): Don't declare.
13884         * psymtab.c (struct psymbol_bcache): Remove.
13885         (psymtab_storage::psymtab_storage): Update.
13886         (psymtab_storage::~psymtab_storage): Update.
13887         (psymbol_bcache_init, psymbol_bcache_free)
13888         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13889         (add_psymbol_to_bcache): Update.
13890         (allocate_psymtab): Update.
13891         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13892         macro_cache>: No longer pointers.
13893         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13894         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13895         * macrotab.c (macro_bcache): Update.
13896         * macroexp.c: Don't include bcache.h.
13897         * gdbtypes.c (check_types_worklist): Update.
13898         (types_deeply_equal): Remove TRY/CATCH.  Update.
13899         * elfread.c (elf_symtab_read): Update.
13900         * dwarf2read.c: Don't include bcache.h.
13901         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13902         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13903         (print_bcache_statistics, bcache_memory_used): Don't declare.
13904         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13905         methods.  Rename all data members.
13906         * bcache.c (struct bcache): Move to bcache.h.
13907         (bcache::expand_hash_table): Rename from expand_hash_table.
13908         (bcache): Remove.
13909         (bcache::insert): Rename from bcache_full.
13910         (bcache::compare): Rename from bcache_compare.
13911         (bcache_xmalloc): Remove.
13912         (bcache::~bcache): Rename from bcache_xfree.
13913         (bcache::print_statistics): Rename from print_bcache_statistics.
13914         (bcache::memory_used): Rename from bcache_memory_used.
13915
13916 2019-03-07  Pedro Alves  <palves@redhat.com>
13917
13918         * infrun.c (normal_stop): Also check for
13919         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13920
13921 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13922
13923         * f-lang.c (value_from_host_double): Moved to...
13924         * value.c (value_from_host_double): ...here.
13925         * value.h (value_from_host_double): Declare.
13926         * guile/scm-math.c (vlscm_convert_typed_number): Use
13927         value_from_host_double.
13928         (vlscm_convert_number): Likewise.
13929         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13930         * python/py-value.c (convert_value_from_python): Likewise.
13931
13932 2019-03-06  Tom Tromey  <tom@tromey.com>
13933
13934         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13935
13936 2019-03-06  Tom Tromey  <tom@tromey.com>
13937
13938         * utils.h (free_current_contents): Don't declare.
13939         * utils.c (free_current_contents): Remove.
13940
13941 2019-03-06  Tom Tromey  <tom@tromey.com>
13942
13943         * top.c (quit_force): Update.
13944         * main.c (captured_command_loop): Update.
13945         * common/new-op.c (operator new): Update.
13946         * common/common-exceptions.c (struct catcher)
13947         <save_cleanup_chain>: Remove member.
13948         (exceptions_state_mc_init): Update.
13949         (exception_try_scope_entry): Return nullptr.
13950         (exception_try_scope_exit, exception_rethrow)
13951         (throw_exception_sjlj, throw_exception_cxx): Update.
13952         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13953         (all_cleanups, do_cleanups, discard_cleanups)
13954         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13955         (restore_cleanups, restore_final_cleanups): Don't declare.
13956         (do_final_cleanups): Remove parameter.
13957         * common/cleanups.c (cleanup_chain, make_cleanup)
13958         (make_cleanup_dtor, all_cleanups, do_cleanups)
13959         (discard_my_cleanups, discard_cleanups)
13960         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13961         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13962         (null_cleanup): Remove.
13963         (do_final_cleanups): Remove parameter.
13964
13965 2019-03-06  Tom Tromey  <tom@tromey.com>
13966
13967         * remote.c (remote_target::remote_parse_stop_reply): Use
13968         unique_xmalloc_ptr.
13969
13970 2019-03-06  Tom Tromey  <tom@tromey.com>
13971
13972         * stabsread.c (struct stabs_field_info): Rename from field_info.
13973         <list, fnlist>: Add initializers.
13974         <obstack>: New member.
13975         (read_member_functions, read_struct_fields, read_baseclasses):
13976         Allocate on obstack.  Don't use cleanups.
13977         (read_one_struct_field, read_member_functions, read_struct_fields)
13978         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13979         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13980         (read_struct_type): Update.
13981
13982 2019-03-06  Tom Tromey  <tom@tromey.com>
13983
13984         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13985         * common/filestuff.h (make_cleanup_close): Don't declare.
13986         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13987         Remove.
13988
13989 2019-03-06  Tom Tromey  <tom@tromey.com>
13990
13991         * solib-aix.c: Use make_scope_exit.
13992
13993 2019-03-06  Tom Tromey  <tom@tromey.com>
13994
13995         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13996         Use make_scope_exit.
13997
13998 2019-03-06  Tom Tromey  <tom@tromey.com>
13999
14000         * solib-svr4.c (disable_probes_interface): Remove parameter.
14001         (svr4_handle_solib_event): Use make_scope_exit.
14002
14003 2019-03-06  Tom Tromey  <tom@tromey.com>
14004
14005         * remote.c (struct stop_reply_deleter): Remove.
14006         (stop_reply_up): Update.
14007         (struct stop_reply): Derive from notif_event.  Don't typedef.
14008         <regcache>: Now a std::vector.
14009         (stop_reply_xfree): Remove.
14010         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14011         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14012         (remote_target::discard_pending_stop_replies): Use delete.
14013         (remote_target::remote_parse_stop_reply): Update.
14014         (remote_target::process_stop_reply): Update.
14015         * remote-notif.h (struct notif_event): Add virtual destructor.
14016         Remove "dtr" member.
14017         (struct notif_client) <alloc_event>: Return a unique_ptr.
14018         (notif_event_xfree): Don't declare.
14019         (notif_event_up): New typedef.
14020         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14021         (notif_event_xfree, do_notif_event_xfree): Remove.
14022         (remote_notif_state_xfree): Update.
14023
14024 2019-03-06  Tom Tromey  <tom@tromey.com>
14025
14026         * infrun.c (displaced_step_clear_cleanup): Now a
14027         forward_scope_exit type.
14028         (displaced_step_prepare_throw): Update.
14029         (displaced_step_fixup): Update.
14030
14031 2019-03-06  Tom Tromey  <tom@tromey.com>
14032
14033         * inferior.h (class inferior): Update comment.
14034         * gdbthread.h (class thread_info): Update comment.
14035
14036 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14037             Tom Tromey  <tom@tromey.com>
14038
14039         * stabsread.h (struct stab_section_list): Remove.
14040         (coffstab_build_psymtabs): Update.
14041         * dbxread.c (symbuf_sections): Now a std::vector.
14042         (sect_idx): New global.
14043         (fill_symbuf): Update.
14044         (coffstab_build_psymtabs): Change type of stabsects parameter.
14045         Update.
14046         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14047         std::vector.
14048         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14049         (coff_locate_sections): Update.
14050         (coff_symfile_read): Remove cleanups.  Update.
14051         (init_stringtab): Add storage parameter.
14052         (free_stringtab, free_stringtab_cleanup): Remove.
14053         (init_lineno): Add storage parameter.
14054         (free_linetab, free_linetab_cleanup): Remove.
14055
14056 2019-03-06  Pedro Alves  <palves@redhat.com>
14057
14058         * linux-fork.c (fork_info::clobber_regs): Delete.
14059         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14060         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14061         comment.  Adjust.
14062         (scoped_switch_fork_info::scoped_switch_fork_info)
14063         (checkpoint_command, linux_fork_context): Adjust
14064         fork_save_infrun_state calls.
14065
14066 2019-03-06  Pedro Alves  <palves@redhat.com>
14067
14068         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14069         (inf_has_multiple_threads): Return 'bool' and rewrite using
14070         inferior_info::threads().
14071
14072 2019-03-06  Pedro Alves  <palves@redhat.com>
14073
14074         * linux-fork.c: Include <list>.
14075         (fork_list): Now a std::list instance.
14076         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14077         (forks_exist_p, find_last_fork): Adjust.
14078         (new_fork): Delete.
14079         (one_fork_p): New.
14080         (add_fork): Adjust.
14081         (free_fork): Delete, folded into fork_info::~fork_info().
14082         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14083         Adjust.
14084         (init_fork_list): Delete.
14085         (linux_fork_killall, linux_fork_mourn_inferior)
14086         (linux_fork_detach, info_checkpoints_command): Adjust.
14087         (_initialize_linux_fork): No longer call init_fork_list.
14088
14089 2019-03-06  Pedro Alves  <palves@redhat.com>
14090
14091         * linux-fork.c (new_fork): New, split out of ...
14092         (add_fork): ... this.  Return void.  Move "first fork" special
14093         case from here, to ...
14094         (checkpoint_command): ... here.
14095         * linux-linux.h (add_fork): Return void.
14096
14097 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14098
14099         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14100
14101 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14102             Chris January  <chris.january@arm.com>
14103             David Lecomber  <david.lecomber@arm.com>
14104
14105         * f-exp.y: New token, UNOP_INTRINSIC.
14106         (exp): New pattern using UNOP_INTRINSIC token.
14107         (f77_keywords): Add 'abs' keyword.
14108         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14109         (value_from_host_double): New function.
14110         (evaluate_subexp_f): Support UNOP_ABS.
14111
14112 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14113
14114         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14115         types.
14116
14117 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14118
14119         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14120         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14121         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14122
14123 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14124
14125         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14126
14127 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14128             Chris January  <chris.january@arm.com>
14129
14130         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14131         * f-exp.y: Define 'KIND' token.
14132         (exp): New pattern for KIND expressions.
14133         (ptype): Handle types with a kind extension.
14134         (direct_abs_decl): Extend to spot kind extensions.
14135         (f77_keywords): Add 'kind' to the list.
14136         (push_kind_type): New function.
14137         (convert_to_kind_type): New function.
14138         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14139         * parse.c (operator_length_standard): Likewise.
14140         * parser-defs.h (enum type_pieces): Add tp_kind.
14141         * std-operator.def: Add UNOP_KIND.
14142
14143 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14144
14145         * f-exp.y (f_parse): Set yydebug.
14146
14147 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14148
14149         * f-lang.c (evaluate_subexp_f): New function.
14150         (exp_descriptor_f): New global.
14151         (f_language_defn): Use exp_descriptor_f instead of
14152         exp_descriptor_standard.
14153
14154 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14155
14156         * f-exp.y (struct token): Add comments.
14157         (dot_ops): Remove uppercase versions and the end marker.
14158         (f77_keywords): Likewise.
14159         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14160         entries in the dot_ops array are case insensitive, and use
14161         strncasecmp to compare strings.  Also some whitespace cleanup in
14162         this area.  Similar for the f77_keywords array, except entries in
14163         this list might be case sensitive.
14164
14165 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14166
14167         * f-exp.y (struct f77_boolean_val): Add comments.
14168         (boolean_values): Remove uppercase versions, and end marker.
14169         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14170         and use strncasecmp to achieve case insensitivity.  Additionally,
14171         perform whitespace cleanup around this code.
14172
14173 2019-03-06  Tom Tromey  <tromey@adacore.com>
14174
14175         * remote-sim.c (gdbsim_target_open): Use result of
14176         gdb_argv::release.
14177
14178 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14179         Dirk Schubert  <dirk.schubert@arm.com>
14180         Chris January  <chris.january@arm.com>
14181
14182         * eval.c (evaluate_subexp_standard): Call Fortran argument
14183         wrapping logic.
14184         * f-lang.c (struct value): A value which can be passed into a
14185         Fortran function call.
14186         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14187         where appropriate.
14188         (struct type): Value ready for a Fortran function call.
14189         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14190         is needed.
14191         * f-lang.h (fortran_argument_convert): Declaration.
14192         (fortran_preserve_arg_pointer): Declaration.
14193         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14194
14195 2019-03-05  Tom Tromey  <tromey@adacore.com>
14196
14197         * python/py-prettyprint.c (print_string_repr): Remove #if.
14198         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14199
14200 2019-03-05  Tom Tromey  <tromey@adacore.com>
14201
14202         * target.c (the_dummy_target): Move later.  Change type to
14203         "dummy_target".
14204         (initialize_targets): Don't initialize the_dummy_target.
14205
14206 2019-03-05  Tom Tromey  <tromey@adacore.com>
14207
14208         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14209         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14210
14211 2019-03-05  Tom Tromey  <tromey@adacore.com>
14212
14213         * windows-nat.c (windows_nat_target::attach)
14214         (windows_nat_target::detach): Don't call gdb_flush.
14215         * valprint.c (generic_val_print, val_print, val_print_string):
14216         Don't call gdb_flush.
14217         * utils.c (defaulted_query): Don't call gdb_flush.
14218         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14219         * target.c (target_announce_detach): Don't call gdb_flush.
14220         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14221         * remote.c (extended_remote_target::attach): Don't call
14222         gdb_flush.
14223         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14224         * printcmd.c (do_examine): Don't call gdb_flush.
14225         (info_display_command): Don't call gdb_flush.
14226         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14227         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14228         * memattr.c (info_mem_command): Don't call gdb_flush.
14229         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14230         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14231         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14232         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14233         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14234         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14235         (gnu_nat_target::detach): Don't call gdb_flush.
14236         * f-valprint.c (f_val_print): Don't call gdb_flush.
14237         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14238         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14239         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14240         gdb_flush.
14241         * c-valprint.c (c_val_print): Don't call gdb_flush.
14242         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14243
14244 2019-03-05  Tom Tromey  <tromey@adacore.com>
14245
14246         * varobj.c (update_dynamic_varobj_children): Update.
14247         (install_default_visualizer): Use reset, not release.
14248         * value.c (set_internalvar): Update.
14249         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14250         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14251         ATTRIBUTE_UNUSED_RESULT.
14252
14253 2019-03-05  Tom Tromey  <tromey@adacore.com>
14254
14255         * remote.c (class scoped_remote_fd) <release>: Add
14256         ATTRIBUTE_UNUSED_RESULT.
14257
14258 2019-03-05  Tom Tromey  <tromey@adacore.com>
14259
14260         * macroexp.c (struct macro_buffer) <release>: Add
14261         ATTRIBUTE_UNUSED_RESULT.
14262
14263 2019-03-05  Tom Tromey  <tromey@adacore.com>
14264
14265         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14266         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14267         ATTRIBUTE_UNUSED_RESULT.
14268
14269 2019-03-05  Tom Tromey  <tromey@adacore.com>
14270
14271         * common/scoped_fd.h (class scoped_fd) <release>: Add
14272         ATTRIBUTE_UNUSED_RESULT.
14273
14274 2019-03-05  Tom Tromey  <tromey@adacore.com>
14275
14276         * parser-defs.h (struct parser_state) <release>: Add
14277         ATTRIBUTE_UNUSED_RESULT.
14278
14279 2019-03-05  Tom Tromey  <tromey@adacore.com>
14280
14281         * utils.h (class gdb_argv) <release>: Add
14282         ATTRIBUTE_UNUSED_RESULT.
14283         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14284
14285 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14286
14287         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14288         for-loop range, to avoid compiler warnings.
14289
14290         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14291         avoid compiler warnings about unused variables.
14292
14293         * NEWS: Mention end of support for native debugging on MS-Windows
14294         before XP.
14295
14296         PR gdb/24292
14297         * common/netstuff.c:
14298         * gdbserver/gdbreplay.c
14299         * gdbserver/remote-utils.c:
14300         * ser-tcp.c:
14301         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14302         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14303         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14304         'getaddrinfo' and 'freeaddrinfo' were not available before
14305         Windows XP, and mingw.org's MinGW headers by default define
14306         _WIN32_WINNT to 0x500.
14307
14308 2019-03-01  Gary Benson <gbenson@redhat.com>
14309
14310         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14311
14312 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14313             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14314
14315         PR gdb/8527
14316         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14317         set_sigint_trap, clear_sigint_trap.
14318
14319 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14320
14321         * target.c (target_detach): Clear the regcache and the
14322         frame cache.
14323
14324 2019-02-27  Pedro Alves  <palves@redhat.com>
14325
14326         * utils.c (set_screen_size): When we cap the height/width sizes,
14327         tweak the corresponding command variable to show "unlimited":
14328
14329 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14330             Pedro Alves  <palves@redhat.com>
14331
14332         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14333         before calling rl_set_screen_size.
14334
14335 2019-02-27  Tom Tromey  <tromey@adacore.com>
14336
14337         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14338         define.
14339         * python/py-value.c: Remove Python 2.4 workaround.
14340         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14341         workaround.
14342         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14343         Python 2.4 workaround.
14344         * python/python-internal.h: Remove Python 2.4 comment.
14345         (Py_ssize_t): Don't define.
14346         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14347         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14348         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14349         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14350         * python/python.c (do_start_initialization): Remove Python 2.4
14351         workaround.
14352         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14353         (print_children): Remove Python 2.4 workaround.
14354         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14355         workaround.
14356         (CHARBUFFERPROC_NAME): Remove.
14357         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14358         Python 2.4 workaround.
14359
14360 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14361
14362         * NEWS: Note minimum Python version.
14363
14364 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14365
14366         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14367         code from these functions.  Remove corresponding ifdefs.  Use
14368         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14369         Remove gotos and target of gotos.
14370         (infpy_search_memory): Likewise.
14371
14372 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14373
14374         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14375         (hppa_gdbarch_init): Don't register deleted functions with
14376         gdbarch.
14377
14378 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14379
14380         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14381         (h8300_unwind_sp): Delete.
14382         (h8300_dummy_id): Delete.
14383         (h8300_gdbarch_init): Don't register deleted functions with
14384         gdbarch.
14385
14386 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14387
14388         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14389         (ft32_unwind_pc): Delete.
14390         (ft32_unwind_sp): Delete.
14391         (ft32_gdbarch_init): Don't register deleted functions with
14392         gdbarch.
14393
14394 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14395
14396         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14397         (frv_unwind_pc): Delete.
14398         (frv_unwind_sp): Delete.
14399         (frv_gdbarch_init): Don't register deleted functions with
14400         gdbarch.
14401
14402 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14403
14404         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14405         (riscv_unwind_pc): Delete.
14406         (riscv_unwind_sp): Delete.
14407         (riscv_gdbarch_init): Don't register deleted functions with
14408         gdbarch.
14409
14410 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14411
14412         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14413         (csky_unwind_pc): Delete.
14414         (csky_unwind_sp): Delete.
14415         (csky_gdbarch_init): Don't register deleted functions with
14416         gdbarch.
14417
14418 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14419
14420         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14421         (cris_unwind_pc): Delete.
14422         (cris_unwind_sp): Delete.
14423         (cris_gdbarch_init): Don't register deleted functions with
14424         gdbarch.
14425
14426 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14427
14428         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14429         (bfin_unwind_pc): Delete.
14430         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14431
14432 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14433
14434         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14435         (arm_unwind_pc): Delete.
14436         (arm_unwind_sp): Delete.
14437         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14438
14439 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14440
14441         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14442         (arc_unwind_pc): Delete.
14443         (arc_unwind_sp): Delete.
14444         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14445
14446 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14447
14448         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14449         (alpha_unwind_pc): Delete.
14450         (alpha_gdbarch_init): Don't register deleted functions with
14451         gdbarch.
14452
14453 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14454
14455         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14456         (aarch64_unwind_pc): Delete.
14457         (aarch64_unwind_sp): Delete.
14458         (aarch64_gdbarch_init): Don't register deleted functions with
14459         gdbarch.
14460
14461 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14462
14463         * gdbtypes.c (type_align): Don't consider static members when
14464         computing structure alignment.
14465
14466 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14467
14468         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14469         return 0 for other types.
14470         * arch-utils.c (default_type_align): Always return 0.
14471         * gdbarch.h: Regenerate.
14472         * gdbarch.sh (type_align): Extend comment.
14473         * gdbtypes.c (type_align): Add additional comments, always call
14474         gdbarch_type_align before applying the default rules.
14475         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14476         generic code will then apply a suitable default.
14477         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14478         types, return 0 for other types.
14479
14480 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14481
14482         * NEWS: Create a new section for the next release branch.
14483         Rename the section of the current branch, now that it has
14484         been cut.
14485
14486 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14487
14488         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14489         * version.in: Bump version to 8.3.50.DATE-git.
14490
14491 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14492
14493         * aix-thread.c (ptid_cmp): Remove unused variable.
14494         (get_signaled_thread): Likewise.
14495         (store_regs_user_thread): Likewise.
14496         (store_regs_kernel_thread): Likewise.
14497         (fetch_regs_kernel_thread): Remove shadowed variable.
14498
14499 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14500
14501         * features/riscv/32bit-cpu.xml: Add register numbers.
14502         * features/riscv/32bit-fpu.c: Regenerate.
14503         * features/riscv/32bit-fpu.xml: Add register numbers.
14504         * features/riscv/64bit-cpu.xml: Add register numbers.
14505         * features/riscv/64bit-fpu.c: Regenerate.
14506         * features/riscv/64bit-fpu.xml: Add register numbers.
14507
14508 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14509
14510         * NEWS: Mention two argument form of gdb.Value constructor.
14511         * python/py-value.c (convert_buffer_and_type_to_value): New
14512         function.
14513         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14514         Add support for handling an optional second argument.  Call
14515         convert_buffer_and_type_to_value as appropriate.
14516         * python/python-internal.h (Py_buffer_deleter): New struct.
14517         (Py_buffer_up): New typedef.
14518
14519 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14520
14521         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14522         instead of releasing ownership.
14523
14524 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14525
14526         * dwarf2read.c (open_and_init_dwp_file): Call
14527         elf_numsections instead of bfd_count_sections to initialize
14528         dwp_file->num_sections.
14529
14530 2019-02-25  Tom Tromey  <tromey@adacore.com>
14531
14532         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14533
14534 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14535
14536         * gcore.in: Add '--readnever' option when invoking GDB.
14537
14538 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14539
14540         * MAINTAINERS: Update my email address.
14541
14542 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14543
14544         * build-id.c (build_id_to_debug_bfd_1): New function.
14545         (build_id_to_debug_bfd): Look for separate debug file in
14546         sysroot.
14547
14548 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14549
14550         * gdbarch.sh: Update the copyright year range that is placed into
14551         generated files.
14552
14553 2019-02-22  Keith Seitz  <keiths@redhat.com>
14554
14555         PR symtab/23853
14556         * linespec.c (create_sals_line_offset): Search for the default
14557         symtab's filename instead of its fullname.
14558
14559 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14560
14561         * NEWS: Update style defaults.
14562
14563 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14564
14565         * main.c (captured_main_1): Disable styling in batch mode.
14566
14567 2019-02-20  Tom Tromey  <tom@tromey.com>
14568
14569         * symtab.c (symtab_symbol_info): Fix typos.
14570
14571 2019-02-20  Tom Tromey  <tromey@adacore.com>
14572
14573         * findcmd.c (_initialize_mem_search): Use upper case for
14574         metasyntactic variables.
14575
14576 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14577
14578         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14579         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14580
14581 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14582
14583         * top.h (source_file_name): Change to std::string.
14584         * top.c (source_file_name): Likewise.
14585         (command_line_input): Adjust.
14586         * cli/cli-script.c (script_from_file): Adjust.
14587
14588 2019-02-19  Tom Tromey  <tromey@adacore.com>
14589
14590         * ravenscar-thread.c
14591         (ravenscar_thread_target::update_thread_list): Don't call
14592         ada_build_task_list.
14593         * ada-lang.h (ada_build_task_list): Don't declare.
14594         * ada-tasks.c (struct ada_tasks_inferior_data)
14595         <task_list_valid_p>: Now bool.
14596         (read_known_tasks, ada_task_list_changed)
14597         (ada_tasks_invalidate_inferior_data): Update.
14598         (read_known_tasks_array): Return bool.
14599         (read_known_tasks_list): Likewise.
14600         (read_known_tasks): Return void.
14601         (ada_build_task_list): Now static.
14602
14603 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14604
14605         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14606         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14607
14608 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14609
14610         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14611         variant for ada_tasks_pspace_data_handle and
14612         ada_tasks_inferior_data_handle.
14613         (ada_tasks_pspace_data_cleanup): New function.
14614         (ada_tasks_inferior_data_cleanup): New function.
14615
14616 2019-02-17  Tom Tromey  <tom@tromey.com>
14617
14618         * macrotab.h (macro_source_fullname): Return a std::string.
14619         * macrotab.c (macro_include, check_for_redefinition)
14620         (macro_undef, macro_lookup_definition, foreach_macro)
14621         (foreach_macro_in_scope): Update.
14622         (macro_source_fullname): Return a std::string.
14623         * macrocmd.c (show_pp_source_pos): Update.
14624
14625 2019-02-17  Tom Tromey  <tom@tromey.com>
14626
14627         * macrocmd.c (show_pp_source_pos): Style the file names.
14628
14629 2019-02-17  Tom Tromey  <tom@tromey.com>
14630
14631         PR tui/24197:
14632         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14633
14634 2019-02-17  Tom Tromey  <tom@tromey.com>
14635
14636         * ada-lang.c (user_select_syms): Use filtered printing.
14637         * utils.c (wrap_style): New global.
14638         (desired_style): Remove.
14639         (emit_style_escape): Add stream parameter.
14640         (set_output_style, reset_terminal_style, prompt_for_continue):
14641         Update.
14642         (flush_wrap_buffer): Only flush gdb_stdout.
14643         (wrap_here): Set wrap_style.
14644         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14645         treat escape sequences as a character.  Change when wrap buffer is
14646         flushed.
14647         (fputs_styled): Do not set the output style when the default is
14648         requested.
14649         * ui-style.h (struct ui_file_style) <is_default>: New method.
14650         * source.c (print_source_lines_base): Emit escape sequences in one
14651         piece.
14652
14653 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14654
14655         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14656         integers and enumeration types.
14657
14658 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14659
14660         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14661         instead of lookup_symbol_in_language
14662         (do_exact_match): New function.
14663         (ada_get_symbol_name_matcher): Return do_exact_match when
14664         doing a verbatim match.
14665
14666 2019-02-15  Tom Tromey  <tromey@adacore.com>
14667
14668         * ravenscar-thread.c (ravenscar_thread_target::resume)
14669         (ravenscar_thread_target::wait): Special case wildcard requests.
14670
14671 2019-02-15  Tom Tromey  <tromey@adacore.com>
14672
14673         * ravenscar-thread.c (base_ptid): Remove.
14674         (struct ravenscar_thread_target) <close>: New method.
14675         <m_base_ptid>: New member.
14676         <update_inferior_ptid, active_task, task_is_currently_active,
14677         runtime_initialized>: Declare methods.
14678         <ravenscar_thread_target>: Add constructor.
14679         (ravenscar_thread_target::task_is_currently_active)
14680         (ravenscar_thread_target::update_inferior_ptid)
14681         (ravenscar_runtime_initialized): Rename.  Now methods.
14682         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14683         (ravenscar_thread_target::update_thread_list): Update.
14684         (ravenscar_thread_target::active_task): Now method.
14685         (ravenscar_thread_target::store_registers)
14686         (ravenscar_thread_target::prepare_to_store)
14687         (ravenscar_thread_target::prepare_to_store)
14688         (ravenscar_thread_target::mourn_inferior): Update.
14689         (ravenscar_inferior_created): Use "new" to create target.
14690         (ravenscar_thread_target::get_ada_task_ptid): Update.
14691         (_initialize_ravenscar): Don't initialize base_ptid.
14692         (ravenscar_ops): Remove global.
14693
14694 2019-02-15  Tom Tromey  <tromey@adacore.com>
14695
14696         * target.h (push_target): Declare new overload.
14697         * target.c (push_target): New overload, taking an rvalue reference.
14698         * remote.c (remote_target::open_1): Use push_target overload.
14699         * corelow.c (core_target_open): Use push_target overload.
14700
14701 2019-02-15  Tom Tromey  <tromey@adacore.com>
14702
14703         * ravenscar-thread.c (is_ravenscar_task)
14704         (ravenscar_task_is_currently_active): Return bool.
14705         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14706         (_initialize_ravenscar): Remove "(void)".
14707         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14708         Return bool.
14709
14710 2019-02-15  Tom Tromey  <tromey@adacore.com>
14711
14712         * ravenscar-thread.c (ravenscar_runtime_initializer)
14713         (has_ravenscar_runtime, get_running_thread_id)
14714         (ravenscar_thread_target::resume): Fix indentation.
14715
14716 2019-02-15  Tom Tromey  <tromey@adacore.com>
14717
14718         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14719         from ravenscar_arch_ops.
14720         (sparc_ravenscar_ops::fetch_registers)
14721         (sparc_ravenscar_ops::store_registers): Now methods.
14722         (sparc_ravenscar_prepare_to_store): Remove.
14723         (sparc_ravenscar_ops): Redefine.
14724         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14725         methods and destructor.  Remove members.
14726         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14727         (ravenscar_thread_target::store_registers)
14728         (ravenscar_thread_target::prepare_to_store): Update.
14729         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14730         Remove.
14731         (struct ppc_ravenscar_powerpc_ops): Derive from
14732         ravenscar_arch_ops.
14733         (ppc_ravenscar_powerpc_ops::fetch_registers)
14734         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14735         (ppc_ravenscar_powerpc_ops): Redefine.
14736         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14737         (ppc_ravenscar_e500_ops::fetch_registers)
14738         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14739         (ppc_ravenscar_e500_ops): Redefine.
14740         * aarch64-ravenscar-thread.c
14741         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14742         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14743         (aarch64_ravenscar_fetch_registers)
14744         (aarch64_ravenscar_store_registers): Now methods.
14745         (aarch64_ravenscar_ops): Redefine.
14746
14747 2019-02-15  Tom Tromey  <tromey@adacore.com>
14748
14749         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14750         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14751         (ravenscar_thread_target::stopped_by_watchpoint)
14752         (ravenscar_thread_target::stopped_data_address)
14753         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14754
14755 2019-02-15  Tom Tromey  <tromey@adacore.com>
14756
14757         * ravenscar-thread.c: Fix some typos.
14758
14759 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14760             Tom Tromey  <tromey@adacore.com>
14761
14762         * ada-lang.c (ada_exception_sal): Change addr_string to a
14763         std::string.
14764         (create_ada_exception_catchpoint): Update.
14765
14766 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14767             Tom Tromey  <tromey@adacore.com>
14768
14769         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14770         (bp_location_ops): Remove.
14771         (base_breakpoint_allocate_location): Update.
14772         (free_bp_location): Update.
14773         * ada-lang.c (class ada_catchpoint_location)
14774         <ada_catchpoint_location>: Remove ops parameter.
14775         (ada_catchpoint_location_dtor): Remove.
14776         (ada_catchpoint_location_ops): Remove.
14777         (allocate_location_exception): Update.
14778         * breakpoint.h (struct bp_location_ops): Remove.
14779         (class bp_location) <bp_location>: Remove bp_location_ops
14780         parameter.
14781         <~bp_location>: Add destructor.
14782         <ops>: Remove.
14783
14784 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14785             Pedro Alves  <palves@redhat.com>
14786
14787         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14788         'PATH_MAX'.
14789
14790 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14791             Samuel Thibault  <samuel.thibault@gnu.org>
14792             Thomas Schwinge  <thomas@codesourcery.com>
14793
14794         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14795         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14796
14797 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14798
14799         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14800         (check_empty): Use "const char *".
14801
14802         * gnu-nat.c (gnu_nat_target::detach): Instead of
14803         'detach_inferior (pid)' call
14804         'detach_inferior (find_inferior_pid (pid))'.
14805
14806         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14807         'nat/fork-inferior.o'.
14808         * gnu-nat.c: #include "nat/fork-inferior.h".
14809
14810         * gnu-nat.c (gnu_nat_target::detach): Instead of
14811         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14812         * gnu-nat.h: #include "inf-child.h".
14813         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14814         'i386_gnu_nat_target::fetch_registers'.
14815         (gnu_store_registers): Rename/move to
14816         'i386_gnu_nat_target::store_registers'.
14817
14818         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14819         * gnu-nat.h (mach_thread_info): New function.
14820         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14821
14822         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14823
14824 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14825
14826         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14827
14828 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14829
14830         * windows-nat.c (windows_add_thread): Add new parameter
14831         "main_thread_p" with default value set to false.  Update
14832         function documentation as well as all callers.
14833         (windows_delete_thread): Likewise.
14834         (fake_create_process): Update call to windows_add_thread.
14835         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14836         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14837         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14838         call to windows_delete_thread.
14839
14840 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14841
14842         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14843
14844 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14845
14846         * symfile.c (find_separate_debug_file): Use canonical path of
14847         sysroot with child_path instead of gdb_sysroot if it is valid.
14848
14849 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14850
14851         * symfile.c (find_separate_debug_file): Use child_path to
14852         determine if an object file is under a sysroot.
14853
14854 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14855
14856         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14857         unittests/child-path-selftests.c.
14858         * common/pathstuff.c (child_path): New function.
14859         * common/pathstuff.h (child_path): New prototype.
14860         * unittests/child-path-selftests.c: New file.
14861
14862 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14863
14864         * symfile.c (find_separate_debug_file): Look for separate debug
14865         files in debug directories under the sysroot.
14866
14867 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14868
14869         * symtab.h (struct minimal_symbol data_p): New const method.
14870         (struct minimal_symbol text_p): Likewise.
14871         * symtab.c (output_source_filename): Use file name style
14872         to print file name.
14873         (print_symbol_info): Likewise.
14874         (print_msymbol_info): Use address style to print addresses.
14875         Use function name style to print executable text symbols.
14876         (expand_symtab_containing_pc): Use data_p.
14877         (find_pc_sect_compunit_symtab): Likewise.
14878
14879 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14880
14881         * breakpoint.c (describe_other_breakpoints): Use address style
14882         to print addresses.
14883         (say_where): Likewise.
14884
14885 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14886
14887         * ada-typeprint.c (print_func_type): Print function name
14888         style to print function name.
14889         * c-typeprint.c (c_print_type_1): Likewise.
14890
14891 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14892
14893         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14894         for execve.
14895
14896 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14897
14898         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14899         type_stack.
14900
14901 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14902
14903         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14904         TYPE_CODE_REF types.
14905
14906 2019-02-08  Jim Wilson  <jimw@sifive.com>
14907
14908         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14909         (riscv_linux_fregset): New.
14910         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14911
14912 2019-02-07  Tom Tromey  <tom@tromey.com>
14913
14914         * thread.c (thread_cancel_execution_command): Update.
14915         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14916         methods.
14917         (struct thread_fsm_ops): Remove.
14918         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14919         (thread_fsm_should_stop, thread_fsm_return_value)
14920         (thread_fsm_set_finished, thread_fsm_finished_p)
14921         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14922         Don't declare.
14923         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14924         * infrun.c (clear_proceed_status_thread)
14925         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14926         (print_stop_event): Update.
14927         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14928         Add constructor.
14929         (step_command_fsm_ops): Remove.
14930         (new_step_command_fsm): Remove.
14931         (step_1): Update.
14932         (step_command_fsm::should_stop): Rename from
14933         step_command_fsm_should_stop.
14934         (step_command_fsm::clean_up): Rename from
14935         step_command_fsm_clean_up.
14936         (step_command_fsm::do_async_reply_reason): Rename from
14937         step_command_fsm_async_reply_reason.
14938         (struct until_next_fsm): Inherit from thread_fsm.  Add
14939         constructor.
14940         (until_next_fsm_ops): Remove.
14941         (new_until_next_fsm): Remove.
14942         (until_next_fsm::should_stop): Rename from
14943         until_next_fsm_should_stop.
14944         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14945         (until_next_fsm::do_async_reply_reason): Rename from
14946         until_next_fsm_async_reply_reason.
14947         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14948         constructor.  Change type of breakpoint.
14949         (finish_command_fsm_ops): Remove.
14950         (new_finish_command_fsm): Remove.
14951         (finish_command_fsm::should_stop): Rename from
14952         finish_command_fsm_should_stop.
14953         (finish_command_fsm::clean_up): Rename from
14954         finish_command_fsm_clean_up.
14955         (finish_command_fsm::return_value): Rename from
14956         finish_command_fsm_return_value.
14957         (finish_command_fsm::do_async_reply_reason): Rename from
14958         finish_command_fsm_async_reply_reason.
14959         (finish_command): Update.
14960         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14961         Add constructor.
14962         (call_thread_fsm_ops): Remove.
14963         (call_thread_fsm::call_thread_fsm): Rename from
14964         new_call_thread_fsm.
14965         (call_thread_fsm::should_stop): Rename from
14966         call_thread_fsm_should_stop.
14967         (call_thread_fsm::should_notify_stop): Rename from
14968         call_thread_fsm_should_notify_stop.
14969         (run_inferior_call, call_function_by_hand_dummy): Update.
14970         * cli/cli-interp.c (should_print_stop_to_console): Update.
14971         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14972         Add constructor.  Change type of location_breakpoint,
14973         caller_breakpoint.
14974         (until_break_fsm_ops): Remove.
14975         (new_until_break_fsm): Remove.
14976         (until_break_fsm::should_stop): Rename from
14977         until_break_fsm_should_stop.
14978         (until_break_fsm::clean_up): Rename from
14979         until_break_fsm_clean_up.
14980         (until_break_fsm::do_async_reply_reason): Rename from
14981         until_break_fsm_async_reply_reason.
14982         (until_break_command): Update.
14983         * thread-fsm.c: Remove.
14984         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14985
14986 2019-02-07  Tom Tromey  <tom@tromey.com>
14987
14988         * yy-remap.h: Add include guard.
14989         * xtensa-tdep.h: Add include guard.
14990         * xcoffread.h: Rename include guard.
14991         * varobj-iter.h: Add include guard.
14992         * tui/tui.h: Rename include guard.
14993         * tui/tui-winsource.h: Rename include guard.
14994         * tui/tui-wingeneral.h: Rename include guard.
14995         * tui/tui-windata.h: Rename include guard.
14996         * tui/tui-win.h: Rename include guard.
14997         * tui/tui-stack.h: Rename include guard.
14998         * tui/tui-source.h: Rename include guard.
14999         * tui/tui-regs.h: Rename include guard.
15000         * tui/tui-out.h: Rename include guard.
15001         * tui/tui-layout.h: Rename include guard.
15002         * tui/tui-io.h: Rename include guard.
15003         * tui/tui-hooks.h: Rename include guard.
15004         * tui/tui-file.h: Rename include guard.
15005         * tui/tui-disasm.h: Rename include guard.
15006         * tui/tui-data.h: Rename include guard.
15007         * tui/tui-command.h: Rename include guard.
15008         * tic6x-tdep.h: Add include guard.
15009         * target/waitstatus.h: Rename include guard.
15010         * target/wait.h: Rename include guard.
15011         * target/target.h: Rename include guard.
15012         * target/resume.h: Rename include guard.
15013         * target-float.h: Rename include guard.
15014         * stabsread.h: Add include guard.
15015         * rs6000-tdep.h: Add include guard.
15016         * riscv-fbsd-tdep.h: Add include guard.
15017         * regformats/regdef.h: Rename include guard.
15018         * record.h: Rename include guard.
15019         * python/python.h: Rename include guard.
15020         * python/python-internal.h: Rename include guard.
15021         * python/py-stopevent.h: Rename include guard.
15022         * python/py-ref.h: Rename include guard.
15023         * python/py-record.h: Rename include guard.
15024         * python/py-record-full.h: Rename include guard.
15025         * python/py-record-btrace.h: Rename include guard.
15026         * python/py-instruction.h: Rename include guard.
15027         * python/py-events.h: Rename include guard.
15028         * python/py-event.h: Rename include guard.
15029         * procfs.h: Add include guard.
15030         * proc-utils.h: Add include guard.
15031         * p-lang.h: Add include guard.
15032         * or1k-tdep.h: Rename include guard.
15033         * observable.h: Rename include guard.
15034         * nto-tdep.h: Rename include guard.
15035         * nat/x86-linux.h: Rename include guard.
15036         * nat/x86-linux-dregs.h: Rename include guard.
15037         * nat/x86-gcc-cpuid.h: Add include guard.
15038         * nat/x86-dregs.h: Rename include guard.
15039         * nat/x86-cpuid.h: Rename include guard.
15040         * nat/ppc-linux.h: Rename include guard.
15041         * nat/mips-linux-watch.h: Rename include guard.
15042         * nat/linux-waitpid.h: Rename include guard.
15043         * nat/linux-ptrace.h: Rename include guard.
15044         * nat/linux-procfs.h: Rename include guard.
15045         * nat/linux-osdata.h: Rename include guard.
15046         * nat/linux-nat.h: Rename include guard.
15047         * nat/linux-namespaces.h: Rename include guard.
15048         * nat/linux-btrace.h: Rename include guard.
15049         * nat/glibc_thread_db.h: Rename include guard.
15050         * nat/gdb_thread_db.h: Rename include guard.
15051         * nat/gdb_ptrace.h: Rename include guard.
15052         * nat/fork-inferior.h: Rename include guard.
15053         * nat/amd64-linux-siginfo.h: Rename include guard.
15054         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15055         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15056         * nat/aarch64-linux.h: Rename include guard.
15057         * nat/aarch64-linux-hw-point.h: Rename include guard.
15058         * mn10300-tdep.h: Add include guard.
15059         * mips-linux-tdep.h: Add include guard.
15060         * mi/mi-parse.h: Rename include guard.
15061         * mi/mi-out.h: Rename include guard.
15062         * mi/mi-main.h: Rename include guard.
15063         * mi/mi-interp.h: Rename include guard.
15064         * mi/mi-getopt.h: Rename include guard.
15065         * mi/mi-console.h: Rename include guard.
15066         * mi/mi-common.h: Rename include guard.
15067         * mi/mi-cmds.h: Rename include guard.
15068         * mi/mi-cmd-break.h: Rename include guard.
15069         * m2-lang.h: Add include guard.
15070         * location.h: Rename include guard.
15071         * linux-record.h: Rename include guard.
15072         * linux-nat.h: Add include guard.
15073         * linux-fork.h: Add include guard.
15074         * i386-darwin-tdep.h: Rename include guard.
15075         * hppa-linux-offsets.h: Add include guard.
15076         * guile/guile.h: Rename include guard.
15077         * guile/guile-internal.h: Rename include guard.
15078         * gnu-nat.h: Rename include guard.
15079         * gdb-stabs.h: Rename include guard.
15080         * frv-tdep.h: Add include guard.
15081         * f-lang.h: Add include guard.
15082         * event-loop.h: Add include guard.
15083         * darwin-nat.h: Rename include guard.
15084         * cp-abi.h: Rename include guard.
15085         * config/sparc/nm-sol2.h: Rename include guard.
15086         * config/nm-nto.h: Rename include guard.
15087         * config/nm-linux.h: Add include guard.
15088         * config/i386/nm-i386gnu.h: Rename include guard.
15089         * config/djgpp/nl_types.h: Rename include guard.
15090         * config/djgpp/langinfo.h: Rename include guard.
15091         * compile/gcc-cp-plugin.h: Add include guard.
15092         * compile/gcc-c-plugin.h: Add include guard.
15093         * compile/compile.h: Rename include guard.
15094         * compile/compile-object-run.h: Rename include guard.
15095         * compile/compile-object-load.h: Rename include guard.
15096         * compile/compile-internal.h: Rename include guard.
15097         * compile/compile-cplus.h: Rename include guard.
15098         * compile/compile-c.h: Rename include guard.
15099         * common/xml-utils.h: Rename include guard.
15100         * common/x86-xstate.h: Rename include guard.
15101         * common/version.h: Rename include guard.
15102         * common/vec.h: Rename include guard.
15103         * common/tdesc.h: Rename include guard.
15104         * common/selftest.h: Rename include guard.
15105         * common/scoped_restore.h: Rename include guard.
15106         * common/scoped_mmap.h: Rename include guard.
15107         * common/scoped_fd.h: Rename include guard.
15108         * common/safe-iterator.h: Rename include guard.
15109         * common/run-time-clock.h: Rename include guard.
15110         * common/refcounted-object.h: Rename include guard.
15111         * common/queue.h: Rename include guard.
15112         * common/ptid.h: Rename include guard.
15113         * common/print-utils.h: Rename include guard.
15114         * common/preprocessor.h: Rename include guard.
15115         * common/pathstuff.h: Rename include guard.
15116         * common/observable.h: Rename include guard.
15117         * common/netstuff.h: Rename include guard.
15118         * common/job-control.h: Rename include guard.
15119         * common/host-defs.h: Rename include guard.
15120         * common/gdb_wait.h: Rename include guard.
15121         * common/gdb_vecs.h: Rename include guard.
15122         * common/gdb_unlinker.h: Rename include guard.
15123         * common/gdb_unique_ptr.h: Rename include guard.
15124         * common/gdb_tilde_expand.h: Rename include guard.
15125         * common/gdb_sys_time.h: Rename include guard.
15126         * common/gdb_string_view.h: Rename include guard.
15127         * common/gdb_splay_tree.h: Rename include guard.
15128         * common/gdb_setjmp.h: Rename include guard.
15129         * common/gdb_ref_ptr.h: Rename include guard.
15130         * common/gdb_optional.h: Rename include guard.
15131         * common/gdb_locale.h: Rename include guard.
15132         * common/gdb_assert.h: Rename include guard.
15133         * common/filtered-iterator.h: Rename include guard.
15134         * common/filestuff.h: Rename include guard.
15135         * common/fileio.h: Rename include guard.
15136         * common/environ.h: Rename include guard.
15137         * common/common-utils.h: Rename include guard.
15138         * common/common-types.h: Rename include guard.
15139         * common/common-regcache.h: Rename include guard.
15140         * common/common-inferior.h: Rename include guard.
15141         * common/common-gdbthread.h: Rename include guard.
15142         * common/common-exceptions.h: Rename include guard.
15143         * common/common-defs.h: Rename include guard.
15144         * common/common-debug.h: Rename include guard.
15145         * common/cleanups.h: Rename include guard.
15146         * common/buffer.h: Rename include guard.
15147         * common/btrace-common.h: Rename include guard.
15148         * common/break-common.h: Rename include guard.
15149         * cli/cli-utils.h: Rename include guard.
15150         * cli/cli-style.h: Rename include guard.
15151         * cli/cli-setshow.h: Rename include guard.
15152         * cli/cli-script.h: Rename include guard.
15153         * cli/cli-interp.h: Rename include guard.
15154         * cli/cli-decode.h: Rename include guard.
15155         * cli/cli-cmds.h: Rename include guard.
15156         * charset-list.h: Add include guard.
15157         * buildsym-legacy.h: Rename include guard.
15158         * bfin-tdep.h: Add include guard.
15159         * ax.h: Rename include guard.
15160         * arm-linux-tdep.h: Add include guard.
15161         * arm-fbsd-tdep.h: Add include guard.
15162         * arch/xtensa.h: Rename include guard.
15163         * arch/tic6x.h: Add include guard.
15164         * arch/i386.h: Add include guard.
15165         * arch/arm.h: Rename include guard.
15166         * arch/arm-linux.h: Rename include guard.
15167         * arch/arm-get-next-pcs.h: Rename include guard.
15168         * arch/amd64.h: Add include guard.
15169         * arch/aarch64-insn.h: Rename include guard.
15170         * arch-utils.h: Rename include guard.
15171         * annotate.h: Add include guard.
15172         * amd64-darwin-tdep.h: Rename include guard.
15173         * aarch64-linux-tdep.h: Add include guard.
15174         * aarch64-fbsd-tdep.h: Add include guard.
15175         * aarch32-linux-nat.h: Add include guard.
15176
15177 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15178
15179         * macrotab.c (macro_define_internal): New function that
15180         factorizes macro_define_object_internal and macro_define_function
15181         code.
15182         (macro_define_object_internal): Use macro_define_internal.
15183         (macro_define_function): Likewise.
15184
15185 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15186
15187         * macrocmd.c (extract_identifier): Return
15188         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15189         callers.
15190
15191 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15192
15193         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15194
15195 2019-02-05  Tom Tromey  <tom@tromey.com>
15196
15197         * target.c (target_stack::unpush): Move assertion earlier.
15198
15199 2019-01-30  Tom Tromey  <tom@tromey.com>
15200
15201         PR python/23615:
15202         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15203         (gdbpy_parse_and_eval): Likewise.
15204         * python/python-internal.h (gdbpy_allow_threads): New class.
15205
15206 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15207
15208         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15209         (aarch64_fbsd_fpregmap): Move earlier.
15210         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15211         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15212         instead of individual calls to trad_frame_set_reg_addr.
15213         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15214         earlier.
15215         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15216         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15217         instead of individual calls to trad_frame_set_reg_addr.
15218
15219 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15220
15221         * CONTRIBUTE: Replace contribution list with wiki link.
15222
15223 2019-01-25  Tom Tromey  <tom@tromey.com>
15224
15225         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15226
15227 2019-01-25  Tom Tromey  <tom@tromey.com>
15228
15229         * xtensa-linux-nat.c: Fix common/ includes.
15230         * xml-support.h: Fix common/ includes.
15231         * xml-support.c: Fix common/ includes.
15232         * x86-linux-nat.c: Fix common/ includes.
15233         * windows-nat.c: Fix common/ includes.
15234         * varobj.h: Fix common/ includes.
15235         * varobj.c: Fix common/ includes.
15236         * value.c: Fix common/ includes.
15237         * valops.c: Fix common/ includes.
15238         * utils.c: Fix common/ includes.
15239         * unittests/xml-utils-selftests.c: Fix common/ includes.
15240         * unittests/utils-selftests.c: Fix common/ includes.
15241         * unittests/unpack-selftests.c: Fix common/ includes.
15242         * unittests/tracepoint-selftests.c: Fix common/ includes.
15243         * unittests/style-selftests.c: Fix common/ includes.
15244         * unittests/string_view-selftests.c: Fix common/ includes.
15245         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15246         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15247         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15248         * unittests/rsp-low-selftests.c: Fix common/ includes.
15249         * unittests/parse-connection-spec-selftests.c: Fix common/
15250         includes.
15251         * unittests/optional-selftests.c: Fix common/ includes.
15252         * unittests/offset-type-selftests.c: Fix common/ includes.
15253         * unittests/observable-selftests.c: Fix common/ includes.
15254         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15255         * unittests/memrange-selftests.c: Fix common/ includes.
15256         * unittests/memory-map-selftests.c: Fix common/ includes.
15257         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15258         * unittests/function-view-selftests.c: Fix common/ includes.
15259         * unittests/environ-selftests.c: Fix common/ includes.
15260         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15261         * unittests/common-utils-selftests.c: Fix common/ includes.
15262         * unittests/cli-utils-selftests.c: Fix common/ includes.
15263         * unittests/array-view-selftests.c: Fix common/ includes.
15264         * ui-file.c: Fix common/ includes.
15265         * tui/tui-io.c: Fix common/ includes.
15266         * tracepoint.h: Fix common/ includes.
15267         * tracepoint.c: Fix common/ includes.
15268         * tracefile-tfile.c: Fix common/ includes.
15269         * top.h: Fix common/ includes.
15270         * top.c: Fix common/ includes.
15271         * thread.c: Fix common/ includes.
15272         * target/waitstatus.h: Fix common/ includes.
15273         * target/waitstatus.c: Fix common/ includes.
15274         * target.h: Fix common/ includes.
15275         * target.c: Fix common/ includes.
15276         * target-memory.c: Fix common/ includes.
15277         * target-descriptions.c: Fix common/ includes.
15278         * symtab.h: Fix common/ includes.
15279         * symfile.c: Fix common/ includes.
15280         * stap-probe.c: Fix common/ includes.
15281         * spu-linux-nat.c: Fix common/ includes.
15282         * sparc-nat.c: Fix common/ includes.
15283         * source.c: Fix common/ includes.
15284         * solib.c: Fix common/ includes.
15285         * solib-target.c: Fix common/ includes.
15286         * ser-unix.c: Fix common/ includes.
15287         * ser-tcp.c: Fix common/ includes.
15288         * ser-pipe.c: Fix common/ includes.
15289         * ser-base.c: Fix common/ includes.
15290         * selftest-arch.c: Fix common/ includes.
15291         * s12z-tdep.c: Fix common/ includes.
15292         * rust-exp.y: Fix common/ includes.
15293         * rs6000-aix-tdep.c: Fix common/ includes.
15294         * riscv-tdep.c: Fix common/ includes.
15295         * remote.c: Fix common/ includes.
15296         * remote-notif.h: Fix common/ includes.
15297         * remote-fileio.h: Fix common/ includes.
15298         * remote-fileio.c: Fix common/ includes.
15299         * regcache.h: Fix common/ includes.
15300         * regcache.c: Fix common/ includes.
15301         * record-btrace.c: Fix common/ includes.
15302         * python/python.c: Fix common/ includes.
15303         * python/py-type.c: Fix common/ includes.
15304         * python/py-inferior.c: Fix common/ includes.
15305         * progspace.h: Fix common/ includes.
15306         * producer.c: Fix common/ includes.
15307         * procfs.c: Fix common/ includes.
15308         * proc-api.c: Fix common/ includes.
15309         * printcmd.c: Fix common/ includes.
15310         * ppc-linux-nat.c: Fix common/ includes.
15311         * parser-defs.h: Fix common/ includes.
15312         * osdata.c: Fix common/ includes.
15313         * obsd-nat.c: Fix common/ includes.
15314         * nat/x86-linux.c: Fix common/ includes.
15315         * nat/x86-linux-dregs.c: Fix common/ includes.
15316         * nat/x86-dregs.h: Fix common/ includes.
15317         * nat/x86-dregs.c: Fix common/ includes.
15318         * nat/ppc-linux.c: Fix common/ includes.
15319         * nat/mips-linux-watch.h: Fix common/ includes.
15320         * nat/mips-linux-watch.c: Fix common/ includes.
15321         * nat/linux-waitpid.c: Fix common/ includes.
15322         * nat/linux-ptrace.h: Fix common/ includes.
15323         * nat/linux-ptrace.c: Fix common/ includes.
15324         * nat/linux-procfs.c: Fix common/ includes.
15325         * nat/linux-personality.c: Fix common/ includes.
15326         * nat/linux-osdata.c: Fix common/ includes.
15327         * nat/linux-namespaces.c: Fix common/ includes.
15328         * nat/linux-btrace.h: Fix common/ includes.
15329         * nat/linux-btrace.c: Fix common/ includes.
15330         * nat/fork-inferior.c: Fix common/ includes.
15331         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15332         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15333         * nat/aarch64-linux.c: Fix common/ includes.
15334         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15335         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15336         * namespace.h: Fix common/ includes.
15337         * mips-linux-tdep.c: Fix common/ includes.
15338         * minsyms.c: Fix common/ includes.
15339         * mi/mi-parse.h: Fix common/ includes.
15340         * mi/mi-main.c: Fix common/ includes.
15341         * mi/mi-cmd-env.c: Fix common/ includes.
15342         * memrange.h: Fix common/ includes.
15343         * memattr.c: Fix common/ includes.
15344         * maint.h: Fix common/ includes.
15345         * maint.c: Fix common/ includes.
15346         * main.c: Fix common/ includes.
15347         * machoread.c: Fix common/ includes.
15348         * location.c: Fix common/ includes.
15349         * linux-thread-db.c: Fix common/ includes.
15350         * linux-nat.c: Fix common/ includes.
15351         * linux-fork.c: Fix common/ includes.
15352         * inline-frame.c: Fix common/ includes.
15353         * infrun.c: Fix common/ includes.
15354         * inflow.c: Fix common/ includes.
15355         * inferior.h: Fix common/ includes.
15356         * inferior.c: Fix common/ includes.
15357         * infcmd.c: Fix common/ includes.
15358         * inf-ptrace.c: Fix common/ includes.
15359         * inf-child.c: Fix common/ includes.
15360         * ia64-linux-nat.c: Fix common/ includes.
15361         * i387-tdep.c: Fix common/ includes.
15362         * i386-tdep.c: Fix common/ includes.
15363         * i386-linux-tdep.c: Fix common/ includes.
15364         * i386-linux-nat.c: Fix common/ includes.
15365         * i386-go32-tdep.c: Fix common/ includes.
15366         * i386-fbsd-tdep.c: Fix common/ includes.
15367         * i386-fbsd-nat.c: Fix common/ includes.
15368         * guile/scm-type.c: Fix common/ includes.
15369         * guile/guile.c: Fix common/ includes.
15370         * go32-nat.c: Fix common/ includes.
15371         * gnu-nat.c: Fix common/ includes.
15372         * gdbthread.h: Fix common/ includes.
15373         * gdbarch-selftests.c: Fix common/ includes.
15374         * gdb_usleep.c: Fix common/ includes.
15375         * gdb_select.h: Fix common/ includes.
15376         * gdb_bfd.c: Fix common/ includes.
15377         * gcore.c: Fix common/ includes.
15378         * fork-child.c: Fix common/ includes.
15379         * findvar.c: Fix common/ includes.
15380         * fbsd-nat.c: Fix common/ includes.
15381         * event-top.c: Fix common/ includes.
15382         * event-loop.c: Fix common/ includes.
15383         * dwarf2read.c: Fix common/ includes.
15384         * dwarf2loc.c: Fix common/ includes.
15385         * dwarf2-frame.c: Fix common/ includes.
15386         * dwarf-index-cache.c: Fix common/ includes.
15387         * dtrace-probe.c: Fix common/ includes.
15388         * disasm-selftests.c: Fix common/ includes.
15389         * defs.h: Fix common/ includes.
15390         * csky-tdep.c: Fix common/ includes.
15391         * cp-valprint.c: Fix common/ includes.
15392         * cp-support.h: Fix common/ includes.
15393         * cp-support.c: Fix common/ includes.
15394         * corelow.c: Fix common/ includes.
15395         * completer.h: Fix common/ includes.
15396         * completer.c: Fix common/ includes.
15397         * compile/compile.c: Fix common/ includes.
15398         * compile/compile-loc2c.c: Fix common/ includes.
15399         * compile/compile-cplus-types.c: Fix common/ includes.
15400         * compile/compile-cplus-symbols.c: Fix common/ includes.
15401         * command.h: Fix common/ includes.
15402         * cli/cli-dump.c: Fix common/ includes.
15403         * cli/cli-cmds.c: Fix common/ includes.
15404         * charset.c: Fix common/ includes.
15405         * build-id.c: Fix common/ includes.
15406         * btrace.h: Fix common/ includes.
15407         * btrace.c: Fix common/ includes.
15408         * breakpoint.h: Fix common/ includes.
15409         * breakpoint.c: Fix common/ includes.
15410         * ax.h:
15411         (enum agent_op): Fix common/ includes.
15412         * ax-general.c (struct aop_map): Fix common/ includes.
15413         * ax-gdb.c: Fix common/ includes.
15414         * auxv.c: Fix common/ includes.
15415         * auto-load.c: Fix common/ includes.
15416         * arm-tdep.c: Fix common/ includes.
15417         * arch/riscv.c: Fix common/ includes.
15418         * arch/ppc-linux-common.c: Fix common/ includes.
15419         * arch/i386.c: Fix common/ includes.
15420         * arch/arm.c: Fix common/ includes.
15421         * arch/arm-linux.c: Fix common/ includes.
15422         * arch/arm-get-next-pcs.c: Fix common/ includes.
15423         * arch/amd64.c: Fix common/ includes.
15424         * arch/aarch64.c: Fix common/ includes.
15425         * arch/aarch64-insn.c: Fix common/ includes.
15426         * arch-utils.c: Fix common/ includes.
15427         * amd64-windows-tdep.c: Fix common/ includes.
15428         * amd64-tdep.c: Fix common/ includes.
15429         * amd64-sol2-tdep.c: Fix common/ includes.
15430         * amd64-obsd-tdep.c: Fix common/ includes.
15431         * amd64-nbsd-tdep.c: Fix common/ includes.
15432         * amd64-linux-tdep.c: Fix common/ includes.
15433         * amd64-linux-nat.c: Fix common/ includes.
15434         * amd64-fbsd-tdep.c: Fix common/ includes.
15435         * amd64-fbsd-nat.c: Fix common/ includes.
15436         * amd64-dicos-tdep.c: Fix common/ includes.
15437         * amd64-darwin-tdep.c: Fix common/ includes.
15438         * agent.c: Fix common/ includes.
15439         * ada-lang.h: Fix common/ includes.
15440         * ada-lang.c: Fix common/ includes.
15441         * aarch64-tdep.c: Fix common/ includes.
15442
15443 2019-01-25  Tom Tromey  <tom@tromey.com>
15444
15445         * common/create-version.sh: Use common/version.h.
15446
15447 2019-01-24  Pedro Alves  <palves@redhat.com>
15448
15449         * infrun.c (signal_stop, signal_print, signal_program)
15450         (signal_catch, signal_pass): Now arrays instead of pointers.
15451         (update_signals_program_target, do_target_resume)
15452         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15453         * linux-nat.c (linux_nat_target::pass_signals)
15454         (linux_nat_target::create_inferior, linux_nat_target::attach):
15455         Adjust.
15456         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15457         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15458         * procfs.c (procfs_target::pass_signals): Adjust.
15459         * record-full.c (record_full_target::resume): Adjust.
15460         * remote.c (remote_target::pass_signals)
15461         (remote_target::program_signals): Adjust.
15462         * target-debug.h (target_debug_print_signals): Now takes a
15463         gdb::array_view as parameter.  Adjust.
15464         * target.h (target_ops) <pass_signals, program_signals>: Replace
15465         pointer and length parameters with gdb::array_view.
15466         (target_pass_signals, target_program_signals): Likewise.
15467         * target-delegates.c: Regenerate.
15468
15469 2019-01-24  Pedro Alves  <palves@redhat.com>
15470
15471         * common/forward-scope-exit.h
15472         (forward_scope_exit::forward_scope_exit): Pass arguments to
15473         m_bind_function directly, instead of creating a std::bind and
15474         copying that.
15475
15476 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15477
15478         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15479         for static members.
15480         (pass_in_v_vfp_candidate): Likewise.
15481
15482 2019-01-23  Tom Tromey  <tom@tromey.com>
15483             Pedro Alves  <palves@redhat.com>
15484
15485         * regcache.c (class regcache_invalidator): Remove.
15486         (regcache::raw_write): Use make_scope_exit.
15487
15488 2019-01-23  Tom Tromey  <tom@tromey.com>
15489
15490         * ui-out.h (class ui_out_emit_type): Update comment.
15491
15492 2019-01-23  Tom Tromey  <tom@tromey.com>
15493
15494         * infrun.c (fetch_inferior_event): Update comment.
15495
15496 2019-01-23  Tom Tromey  <tom@tromey.com>
15497             Pedro Alves  <palves@redhat.com>
15498
15499         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15500         parameter.
15501         (fetch_inferior_event): Use SCOPE_EXIT.
15502
15503
15504 2019-01-23  Tom Tromey  <tom@tromey.com>
15505             Pedro Alves  <palves@redhat.com>
15506
15507         * infrun.c (disable_thread_events): Delete.
15508         (stop_all_threads): Use SCOPE_EXIT.
15509
15510 2019-01-23  Tom Tromey  <tom@tromey.com>
15511             Pedro Alves  <palves@redhat.com>
15512
15513         * symfile.c: Include forward-scope-exit.h.
15514         (clear_symtab_users_cleanup): Replace forward declaration with
15515         a FORWARD_SCOPE_EXIT.
15516         (syms_from_objfile_1): Use the forward_scope_exit and
15517         gdb::optional instead of cleanup_function.
15518         (reread_symbols): Use the forward_scope_exit instead of
15519         cleanup_function.
15520         (clear_symtab_users_cleanup): Remove function.
15521
15522 2019-01-23  Tom Tromey  <tom@tromey.com>
15523             Pedro Alves  <palves@redhat.com>
15524
15525         * linux-nat.c: Include scope-exit.h.
15526         (cleanup_target_stop): Remove.
15527         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15528         SCOPE_EXIT.
15529
15530 2019-01-23  Tom Tromey  <tom@tromey.com>
15531             Pedro Alves  <palves@redhat.com>
15532
15533         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15534         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15535
15536 2019-01-23  Tom Tromey  <tom@tromey.com>
15537             Andrew Burgess  <andrew.burgess@embecosm.com>
15538             Pedro Alves  <palves@redhat.com>
15539
15540         * infrun.c (fetch_inferior_event): Use scope_exit.
15541         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15542         * top.c (execute_command): Use scope_exit.
15543         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15544         * utils.c (do_bpstat_clear_actions_cleanup)
15545         (make_bpstat_clear_actions_cleanup): Remove.
15546
15547 2019-01-23  Tom Tromey  <tom@tromey.com>
15548             Pedro Alves  <palves@redhat.com>
15549
15550         * infrun.c: Include "common/scope-exit.h"
15551         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15552         (wait_for_inferior): Use SCOPE_EXIT.
15553         (fetch_inferior_event): Use scope_exit.
15554
15555 2019-01-23  Tom Tromey  <tom@tromey.com>
15556             Pedro Alves  <palves@redhat.com>
15557
15558         * breakpoint.c (create_breakpoint): Remove cleanup.
15559
15560 2019-01-23  Tom Tromey  <tom@tromey.com>
15561             Andrew Burgess  <andrew.burgess@embecosm.com>
15562             Pedro Alves  <palves@redhat.com>
15563
15564 2019-01-23  Pedro Alves  <palves@redhat.com>
15565
15566         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15567
15568 2019-01-23  Pedro Alves  <palves@redhat.com>
15569             Andrew Burgess  <andrew.burgess@embecosm.com>
15570
15571         * gdbthread.h: Include "common/forward-scope-exit.h".
15572         (scoped_finish_thread_state): Redefine custom class in terms of
15573         forward_scope_exit.
15574
15575 2019-01-23  Pedro Alves  <palves@redhat.com>
15576             Andrew Burgess  <andrew.burgess@embecosm.com>
15577
15578         * common/forward-scope-exit.h: New file.
15579
15580 2019-01-23  Pedro Alves  <palves@redhat.com>
15581             Andrew Burgess  <andrew.burgess@embecosm.com>
15582             Tom Tromey  <tom@tromey.com>
15583
15584         * common/scope-exit.h: New file.
15585
15586 2019-01-23  Pedro Alves  <palves@redhat.com>
15587
15588         * common/preprocessor.h (ESC): Rename to ...
15589         (ESC_PARENS): ... this.
15590         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15591         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15592
15593 2019-01-23  Tom Tromey  <tom@tromey.com>
15594
15595         * language.h (class scoped_switch_to_sym_language_if_auto):
15596         Initialize m_lang in both cases.
15597
15598 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15599
15600         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15601         with XCNEW.
15602
15603 2019-01-22  Tom Tromey  <tom@tromey.com>
15604
15605         * corelow.c: Do not include sys/file.h.
15606
15607 2019-01-22  Tom Tromey  <tom@tromey.com>
15608
15609         * tui/tui-wingeneral.h: Include gdb_curses.h.
15610
15611 2019-01-22  Tom Tromey  <tom@tromey.com>
15612
15613         * source-cache.h (class source_cache) <get_source_lines,
15614         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15615
15616 2019-01-22  Tom Tromey  <tom@tromey.com>
15617
15618         * remote-fileio.h (struct remote_target): Declare.
15619
15620 2019-01-22  Tom Tromey  <tom@tromey.com>
15621
15622         * python/py-arch.c: Do not include py-ref.h.
15623         * python/py-bpevent.c: Do not include py-ref.h.
15624         * python/py-cmd.c: Do not include py-ref.h.
15625         * python/py-continueevent.c: Do not include py-ref.h.
15626         * python/py-event.h: Do not include py-ref.h.
15627         * python/py-evtregistry.c: Do not include py-ref.h.
15628         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15629         * python/py-frame.c: Do not include py-ref.h.
15630         * python/py-framefilter.c: Do not include py-ref.h.
15631         * python/py-function.c: Do not include py-ref.h.
15632         * python/py-infevents.c: Do not include py-ref.h.
15633         * python/py-linetable.c: Do not include py-ref.h.
15634         * python/py-objfile.c: Do not include py-ref.h.
15635         * python/py-param.c: Do not include py-ref.h.
15636         * python/py-prettyprint.c: Do not include py-ref.h.
15637         * python/py-progspace.c: Do not include py-ref.h.
15638         * python/py-symbol.c: Do not include py-ref.h.
15639         * python/py-symtab.c: Do not include py-ref.h.
15640         * python/py-type.c: Do not include py-ref.h.
15641         * python/py-unwind.c: Do not include py-ref.h.
15642         * python/py-utils.c: Do not include py-ref.h.
15643         * python/py-value.c: Do not include py-ref.h.
15644         * python/py-varobj.c: Do not include py-ref.h.
15645         * python/py-xmethods.c: Do not include py-ref.h.
15646         * python/python.c: Do not include py-ref.h.
15647         * varobj.c: Do not include py-ref.h.
15648
15649 2019-01-22  Tom Tromey  <tom@tromey.com>
15650
15651         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15652         keyword for bcache.
15653
15654 2019-01-22  Tom Tromey  <tom@tromey.com>
15655
15656         * compile/compile-cplus-types.c: Remove a comment by #include.
15657
15658 2019-01-22  Tom Tromey  <tom@tromey.com>
15659
15660         * compile/gcc-c-plugin.h: Include compile-internal.h.
15661
15662 2019-01-22  Tom Tromey  <tom@tromey.com>
15663
15664         * stabsread.c (EXTERN): Do not define.
15665         (symnum, next_symbol_text_func, processing_gcc_compilation)
15666         (within_function, global_sym_chain, global_stabs)
15667         (previous_stab_code, this_object_header_files)
15668         (n_this_object_header_files)
15669         (n_allocated_this_object_header_files): Define.
15670         * stabsread.h (EXTERN): Never define.  Use "extern".
15671
15672 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15673
15674         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15675         history_value.
15676
15677 2019-01-21  Tom Tromey  <tom@tromey.com>
15678
15679         * ui-out.c: Fix includes.
15680         * tui/tui-source.c: Fix includes.
15681         * target.c: Fix includes.
15682         * remote.c: Fix includes.
15683         * regcache.c: Fix includes.
15684         * python/py-block.c: Fix includes.
15685         * printcmd.c: Fix includes.
15686         * or1k-tdep.c: Fix includes.
15687         * mi/mi-main.c: Fix includes.
15688         * m32r-tdep.c: Fix includes.
15689         * csky-tdep.c: Fix includes.
15690         * compile/compile-cplus-types.c: Fix includes.
15691         * cli/cli-interp.c: Fix includes.
15692
15693 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15694
15695         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15696         for padding.
15697
15698 2019-01-16  Tom Tromey  <tom@tromey.com>
15699
15700         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15701         earlier.
15702         (struct objfile) <msymbols_range>: Move from top level.
15703         <msymbols>: New method.
15704         (class objfile_msymbols): Remove.
15705         * symtab.c (default_collect_symbol_completion_matches_break_on):
15706         Update.
15707         * symmisc.c (dump_msymbols): Update.
15708         * stabsread.c (scan_file_globals): Update.
15709         * objc-lang.c (info_selectors_command, info_classes_command)
15710         (find_methods): Update.
15711         * minsyms.c (find_solib_trampoline_target): Update.
15712         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15713         * coffread.c (coff_symfile_read): Update.
15714         * ada-lang.c (ada_lookup_simple_minsym)
15715         (ada_collect_symbol_completion_matches): Update.
15716
15717 2019-01-16  Tom Tromey  <tom@tromey.com>
15718
15719         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15720         type.  Remove no-argument constructor.
15721         <iterator::operator++>: Simplify.
15722         <begin>: Update.
15723         <end>: Use minimal_symbol_count.
15724
15725 2019-01-16  Tom Tromey  <tom@tromey.com>
15726
15727         * objfiles.h (struct objfile) <psymtabs>: New method.
15728         (class objfile_psymtabs): Remove.
15729         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15730         typedef.
15731         <range>: New method.
15732         (require_partial_symbols): Change return type.
15733         * psymtab.c (require_partial_symbols)
15734         (psym_expand_symtabs_matching): Update.
15735         * mdebugread.c (parse_partial_symbols): Update.
15736         * dbxread.c (dbx_end_psymtab): Update.
15737
15738 2019-01-15  Tom Tromey  <tom@tromey.com>
15739
15740         * symtab.c (lookup_objfile_from_block)
15741         (lookup_symbol_in_objfile_symtabs)
15742         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15743         (find_line_symtab, info_sources_command)
15744         (default_collect_symbol_completion_matches_break_on)
15745         (make_source_files_completion_list): Update.
15746         * symmisc.c (print_objfile_statistics, dump_objfile)
15747         (maintenance_print_symbols, maintenance_info_symtabs)
15748         (maintenance_check_symtabs, maintenance_info_line_tables):
15749         Update.
15750         * source.c (select_source_symtab)
15751         (forget_cached_source_info_for_objfile): Update.
15752         * objfiles.h (class objfile_compunits): Remove.
15753         (struct objfile) <compunits_range>: New typedef.
15754         (compunits): New method.
15755         * objfiles.c (objfile_relocate1): Update.
15756         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15757         * maint.c (count_symtabs_and_blocks): Update.
15758         * linespec.c (iterate_over_all_matching_symtabs): Update.
15759         * cp-support.c (add_symbol_overload_list_qualified): Update.
15760         * coffread.c (coff_symtab_read): Update.
15761         * ada-lang.c (add_nonlocal_symbols)
15762         (ada_collect_symbol_completion_matches)
15763         (ada_add_global_exceptions): Update.
15764
15765 2019-01-15  Tom Tromey  <tom@tromey.com>
15766
15767         * progspace.h (program_space) <objfiles_safe_range>: New
15768         typedef.
15769         <objfiles_safe>: New method.
15770         * objfiles.h (class all_objfiles_safe): Remove.
15771         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15772         * jit.c (jit_inferior_exit_hook): Update.
15773
15774 2019-01-17  Tom Tromey  <tom@tromey.com>
15775
15776         * progspace.h (program_space) <objfiles_range>: New typedef.
15777         <objfiles>: New method.
15778         <objfiles_head>: Rename from objfiles.
15779         (object_files): Update.
15780         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15781         * guile/scm-pretty-print.c
15782         (ppscm_find_pretty_printer_from_objfiles): Update.
15783         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15784         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15785         Update.
15786         * python/py-progspace.c (pspy_get_objfiles): Update.
15787         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15788         Update.
15789         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15790         (objfpy_lookup_objfile_by_build_id): Update.
15791         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15792         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15793         Update.
15794         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15795         (expand_symtab_containing_pc, lookup_objfile_from_block)
15796         (lookup_static_symbol, basic_lookup_transparent_type)
15797         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15798         (find_line_symtab, info_sources_command)
15799         (default_collect_symbol_completion_matches_break_on)
15800         (make_source_files_completion_list, find_main_name): Update.
15801         * symmisc.c (print_symbol_bcache_statistics)
15802         (print_objfile_statistics, maintenance_print_symbols)
15803         (maintenance_print_msymbols, maintenance_print_objfiles)
15804         (maintenance_info_symtabs, maintenance_check_symtabs)
15805         (maintenance_expand_symtabs, maintenance_info_line_tables):
15806         Update.
15807         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15808         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15809         (map_overlay_command, unmap_overlay_command)
15810         (simple_overlay_update, expand_symtabs_matching)
15811         (map_symbol_filenames): Update.
15812         * symfile-debug.c (set_debug_symfile): Update.
15813         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15814         Update.
15815         * source.c (select_source_symtab, forget_cached_source_info):
15816         Update.
15817         * solib.c (solib_read_symbols): Update.
15818         * solib-spu.c (append_ocl_sos): Update.
15819         * psymtab.c (maintenance_print_psymbols)
15820         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15821         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15822         * printcmd.c (info_symbol_command): Update.
15823         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15824         Update.
15825         * objfiles.h (class all_objfiles): Remove.
15826         * objfiles.c (have_partial_symbols, have_full_symbols)
15827         (have_minimal_symbols, qsort_cmp, update_section_map)
15828         (shared_objfile_contains_address_p)
15829         (default_iterate_over_objfiles_in_search_order): Update.
15830         * objc-lang.c (info_selectors_command, info_classes_command)
15831         (find_methods): Update.
15832         * minsyms.c (find_solib_trampoline_target): Update.
15833         * maint.c (maintenance_info_sections)
15834         (maintenance_translate_address, count_symtabs_and_blocks):
15835         Update.
15836         * main.c (captured_main_1): Update.
15837         * linux-thread-db.c (try_thread_db_load_from_pdir)
15838         (has_libpthread): Update.
15839         * linespec.c (iterate_over_all_matching_symtabs)
15840         (search_minsyms_for_name): Update.
15841         * jit.c (jit_find_objf_with_entry_addr): Update.
15842         * hppa-tdep.c (find_unwind_entry)
15843         (hppa_lookup_stub_minimal_symbol): Update.
15844         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15845         Update.
15846         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15847         (elf_gnu_ifunc_resolve_by_got): Update.
15848         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15849         * dwarf-index-write.c (save_gdb_index_command): Update.
15850         * cp-support.c (add_symbol_overload_list_qualified): Update.
15851         * breakpoint.c (create_overlay_event_breakpoint)
15852         (create_longjmp_master_breakpoint)
15853         (create_std_terminate_master_breakpoint)
15854         (create_exception_master_breakpoint): Update.
15855         * blockframe.c (find_pc_partial_function): Update.
15856         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15857         (ada_collect_symbol_completion_matches)
15858         (ada_add_global_exceptions): Update.
15859
15860 2019-01-17  Tom Tromey  <tom@tromey.com>
15861
15862         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15863         declare VEC.
15864         (solib_target_parse_libraries): Change return type.
15865         (library_list_start_segment, library_list_start_section)
15866         (library_list_end_library, library_list_start_library); Update.
15867         (solib_target_free_library_list): Remove.
15868         (solib_target_parse_libraries): Remove cleanup.  Change return
15869         type.
15870         (solib_target_current_sos): Update.
15871
15872 2019-01-17  Tom Tromey  <tromey@bapiya>
15873
15874         * valprint.c: Replace "the the" with "the".
15875         * symtab.c: Replace "the the" with "the".
15876         * solib.c: Replace "the the" with "the".
15877         * solib-dsbt.c: Replace "the the" with "the".
15878         * linespec.c: Replace "the the" with "the".
15879         * dwarf2loc.h: Replace "the the" with "the".
15880         * amd64-windows-tdep.c: Replace "the the" with "the".
15881         * aarch64-tdep.c: Replace "the the" with "the".
15882
15883 2019-01-16  Keith Seitz  <keiths@redhat.com>
15884
15885         PR gdb/23773
15886         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15887         <builder>: Rename to ..
15888         <m_builder>: ... this and make private.
15889         (dwarf2_cu::get_builder): New method.  Change all users of
15890         `builder' to use this method.
15891         (dwarf2_start_symtab): Move to ...
15892         (dwarf2_cu::start_symtab): ... here.  Update all callers
15893         (setup_type_unit_groups): Move to ...
15894         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15895         callers.
15896         (dwarf2_cu::reset_builder): New method.
15897         (process_full_compunit, process_full_type_unit): Use
15898         dwarf2_cu::reset_builder.
15899         (follow_die_offset): Record the ancestor CU if it is different
15900         from the followed DIE's CU.
15901         (follow_die_sig_1): Likewise.
15902
15903 2019-01-15  Tom Tromey  <tom@tromey.com>
15904
15905         * remote.c (class remote_state) <buf>: Now a char_vector.
15906         <buf_size>: Remove.
15907         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15908         parameter.
15909         (remote_target::getpkt_or_notif_sane_1)
15910         (remote_target::getpkt_sane)
15911         (remote_target::getpkt_or_notif_sane): Likewise.
15912         (class remote_target) <putpkt>: New overload.
15913         (remote_target::read_frame): Change type of "buf_p".  Remove
15914         sizeof_p parameter.
15915         (packet_ok): New overload.
15916         (packet_check_result): New overload.
15917         Update all uses.
15918
15919 2019-01-14  Tom Tromey  <tom@tromey.com>
15920
15921         * remote-notif.c (handle_notification, remote_notif_ack)
15922         (remote_notif_parse): Make "buf" const.
15923         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15924         const.
15925         (remote_notif_parse, remote_notif_ack, handle_notification):
15926         Likewise.
15927         * remote.c (remote_notif_stop_parse): Make "buf" const.
15928         (remote_target::remote_parse_stop_reply): Make "buf" const.
15929         (remote_notif_stop_ack): Make "buf" const.
15930
15931 2019-01-14  Tom Tromey  <tom@tromey.com>
15932
15933         * remote.c (remote_console_output): Make parameter const.
15934
15935 2019-01-14  Tom Tromey  <tom@tromey.com>
15936
15937         * target-debug.h (target_debug_print_signals): Constify.
15938         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15939         * procfs.c (procfs_target::pass_signals): Update.
15940         * linux-nat.c (linux_nat_target::pass_signals): Update.
15941         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15942         * target-delegates.c: Rebuild.
15943         * remote.c (remote_target::program_signals): Update.
15944         (remote_target::pass_signals): Update.
15945         * target.c (target_pass_signals): Constify argument.
15946         (target_program_signals): Likewise.
15947         * target.h (struct target_ops) <pass_signals, program_signals>:
15948         Constify argument.
15949         (target_pass_signals, target_program_signals): Constify argument.
15950
15951 2019-01-14  Tom Tromey  <tom@tromey.com>
15952
15953         PR tui/28819:
15954         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15955
15956 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15957
15958         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15959         field.
15960         * rs6000-tdep.c: Include reggroups.h.
15961         (IS_V_ALIAS_PSEUDOREG): Define.
15962         (rs6000_register_name): Return names for the "vX" aliases.
15963         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15964         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15965         aliases.  Call default_register_reggroup_p for all other
15966         pseudo-registers.
15967         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15968         New functions.
15969         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15970         Handle "vX" aliases.
15971         (v_alias_pseudo_register_collect): New function.
15972         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15973         (rs6000_gdbarch_init): Initialize "vX" aliases as
15974         pseudo-registers.  Restore registration of
15975         rs6000_pseudo_register_reggroup_p with
15976         set_tdesc_pseudo_register_reggroup_p.
15977
15978 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15979
15980         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15981         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15982         set_gdbarch_num_pseudo_regs.
15983
15984 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15985
15986         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15987         Remove arg prefixname, add do_set and do_show.
15988         Add member functions set_list and show_list.
15989         * cli/cli-style.c (class cli_style_option): Update accordingly.
15990         (style_set_list): Move to file scope.
15991         (style_show_list): Likewise.
15992         (set_style): Call help_list.
15993         (show_style): Call cmd_show_list.
15994         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15995         Update to use the new macro.
15996
15997 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15998
15999         * ada-lang.c (_initialize_ada_language): Expand the help text
16000         for the "catch exception" command.
16001
16002 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16003
16004         * symtab.c (matching_obj_sections): Initialize obj,
16005         declare it closer to its usage.
16006
16007 2019-01-10  Tom Tromey  <tom@tromey.com>
16008
16009         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16010         (basic_inf_threads_range): Remove.
16011         (inf_threads_range, inf_non_exited_threads_range)
16012         (safe_inf_threads_range): Use next_adapter.
16013
16014 2019-01-10  Keith Seitz  <keiths@redhat.com>
16015
16016         PR gdb/23712
16017         PR symtab/23010
16018         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16019         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16020
16021 2019-01-10  Keith Seitz  <keiths@redhat.com>
16022
16023         PR gdb/23712
16024         PR symtab/23010
16025         * dictionary.c (pending_to_vector): Remove.
16026         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16027         Remove _1 suffix, replacing functions of the same name.  Update
16028         all callers.
16029         (dict_create_hashed, dict_create_hashed_expandable)
16030         (dict_create_linear, dict_create_linear_expandable, dict_free)
16031         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16032         Make functions static.
16033
16034 2019-01-10  Keith Seitz  <keiths@redhat.com>
16035
16036         PR gdb/23712
16037         PR symtab/23010
16038         * dictionary.h (struct dictionary): Replace declaration with
16039         multidictionary.
16040         (dict_create_hashed, dict_create_hashed_expandable)
16041         (dict_create_linear, dict_create_linear_expandable)
16042         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16043         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16044         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16045         taking multidictionary argument.
16046         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16047         * block.h (struct block) <dict>: Change to multidictionary
16048         and rename `multidict'.
16049         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16050         symmisc.c: Update all dictionary references to multidictionary.
16051
16052 2019-01-10  Keith Seitz  <keiths@redhat.com>
16053
16054         PR gdb/23712
16055         PR symtab/23010
16056         * dictionary.c: Include unordered_map.
16057         (pending_to_vector): New function.
16058         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16059         Rewrite the non-"_1" functions to take vector instead
16060         of linked list.
16061         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16062         "new" _1 versions of the same name.
16063         (multidictionary): Define.
16064         (std::hash<enum language): New definition.
16065         (collate_pending_symbols_by_language, mdict_create_hashed)
16066         (mdict_create_hashed_expandable, mdict_create_linear)
16067         (mdict_create_linear_expandable, mdict_free)
16068         (find_language_dictionary, create_new_language_dictionary)
16069         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16070         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16071         (mdict_size, mdict_empty): New functions.
16072         * dictionary.h (mdict_iterator): Define.
16073
16074 2019-01-10  Pedro Alves  <palves@redhat.com>
16075
16076         * breakpoint.c (read_uploaded_action)
16077         (create_tracepoint_from_upload): Adjust to use
16078         gdb::unique_xmalloc_ptr.
16079         * ctf.c (ctf_write_uploaded_tp):
16080         (SET_ARRAY_FIELD): Use emplace_back.
16081         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16082         * tracefile-tfile.c (tfile_write_uploaded_tp):
16083         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16084         gdb::unique_xmalloc_ptr.
16085         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16086         at_string, cond_string, cmd_strings>: Replace char pointers
16087         with gdb::unique_xmalloc_ptr.
16088
16089 2019-01-10  Pedro Alves  <palves@redhat.com>
16090
16091         * solib-target.c (library_list_start_library): Don't xstrdup name.
16092
16093 2019-01-10  Pedro Alves  <palves@redhat.com>
16094
16095         * mdebugread.c (parse_partial_symbols): Use
16096         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16097
16098 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16099
16100         * linux-fork.c (scoped_switch_fork_info)
16101         <~scoped_switch_fork_info>: Fix incorrect variable name.
16102
16103 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16104
16105         * linux-fork.c (scoped_switch_fork_info)
16106         <scoped_switch_fork_info>: Make explicit.
16107         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16108
16109 2019-01-10  Tom Tromey  <tom@tromey.com>
16110
16111         * objfiles.h (objfile::reset_psymtabs): Update.
16112         * objfiles.c (objfile::objfile): Update.
16113         * psymtab.h (psymtab_storage::obstack): Update.
16114         (psymtab_storage::m_obstack): Use gdb::optional.
16115         (class psymtab_storage): Update comment.  Remove objfile
16116         parameter.
16117         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16118
16119 2019-01-10  Tom Tromey  <tom@tromey.com>
16120
16121         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16122         <free_psymtabs>: Now private.
16123         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16124         (allocate_psymtab): Use new method.
16125
16126 2019-01-10  Tom Tromey  <tom@tromey.com>
16127
16128         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16129         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16130         * mdebugread.c (parse_partial_symbols): Use
16131         allocate_dependencies.
16132         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16133         allocate_dependencies.
16134         (process_psymtab_comp_unit_reader)
16135         (build_type_psymtab_dependencies): Likewise.
16136         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16137
16138 2019-01-10  Tom Tromey  <tom@tromey.com>
16139
16140         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16141         PSYMBOL_SET_LANGUAGE.
16142         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16143
16144 2019-01-10  Tom Tromey  <tom@tromey.com>
16145
16146         * psymtab.h (psymtab_storage::obstack): New method.
16147         <m_obstack>: Rename from obstack; now private.
16148         * psymtab.c (psymtab_storage): Update.
16149         * dwarf2read.c (create_addrmap_from_index)
16150         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16151         Update.
16152
16153 2019-01-10  Tom Tromey  <tom@tromey.com>
16154
16155         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16156         * objfiles.h (objfile::reset_psymtabs): New method.
16157
16158 2019-01-10  Tom Tromey  <tom@tromey.com>
16159
16160         * symmisc.c (print_symbol_bcache_statistics): Update.
16161         (print_objfile_statistics): Update.
16162         * symfile.c (reread_symbols): Update.
16163         * psymtab.h (class psymtab_storage): New.
16164         * psymtab.c (psymtab_storage): New constructor.
16165         (~psymtab_storage): New destructor.
16166         (require_partial_symbols): Update.
16167         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16168         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16169         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16170         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16171         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16172         (start_psymtab_common, end_psymtab_common)
16173         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16174         (allocate_psymtab): Update.
16175         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16176         Update.
16177         (dump_psymtab_addrmap, maintenance_print_psymbols)
16178         (maintenance_check_psymtabs): Update.
16179         (class objfile_psymtabs): Move to objfiles.h.
16180         * psympriv.h (discard_psymtab): Now inline.
16181         (psymtab_discarder::psymtab_discarder): Update.
16182         (psymtab_discarder::~psymtab_discarder): Update.
16183         (ALL_OBJFILE_PSYMTABS): Rewrite.
16184         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16185         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16186         Remove fields.
16187         <partial_symtabs>: New field.
16188         (class objfile_psymtabs): Move from psymtab.h.  Update.
16189         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16190         psymbol_cache.
16191         (objfile::~objfile): Don't destroy psymbol_cache.
16192         * mdebugread.c (parse_partial_symbols): Update.
16193         * dwarf2read.c (create_addrmap_from_index)
16194         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16195         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16196         (add_partial_subprogram, dwarf2_ranges_read): Update.
16197         * dwarf-index-write.c (write_address_map)
16198         (write_one_signatured_type, recursively_write_psymbols)
16199         (class debug_names, class debug_names, write_psymtabs_to_index):
16200         Update.
16201
16202 2019-01-10  Tom Tromey  <tom@tromey.com>
16203
16204         * symtab.h (SYMBOL_SET_NAMES): Update.
16205         (symbol_set_names): Update.
16206         (MSYMBOL_SET_NAMES): Update.
16207         * symtab.c (symbol_set_names): Change argument to be an
16208         objfile_per_bfd_storage.
16209         * psymtab.c (add_psymbol_to_bcache): Update.
16210         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16211
16212 2019-01-10  Tom Tromey  <tom@tromey.com>
16213
16214         * symtab.c (create_demangled_names_hash): Change argument to be an
16215         objfile_per_bfd_storage.
16216         (symbol_set_names): Update.
16217
16218 2019-01-10  Tom Tromey  <tom@tromey.com>
16219
16220         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16221         init_psymbol_list.
16222         * psymtab.c (init_psymbol_list): Do nothing if already called.
16223         * psympriv.h (init_psymbol_list): Add comment.
16224         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16225         init_psymbol_list.
16226         * dbxread.c (dbx_symfile_read): Unconditionally call
16227         init_psymbol_list.
16228
16229 2019-01-10  Tom Tromey  <tom@tromey.com>
16230
16231         * xcoffread.c (scan_xcoff_symtab): Update.
16232         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16233         "where".
16234         * mdebugread.c (parse_partial_symbols)
16235         (handle_psymbol_enumerators): Update.
16236         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16237         * dbxread.c (read_dbx_symtab): Update.
16238         * psympriv.h (psymbol_placement): New enum.
16239         (add_psymbol_to_list): Update.
16240
16241 2019-01-10  Tom Tromey  <tom@tromey.com>
16242
16243         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16244         static_psymbols parameters.
16245         (scan_xcoff_symtab): Update.
16246         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16247         static_psymbols parameters.
16248         * psympriv.h (start_psymtab_common): Update.
16249         * mdebugread.c (parse_partial_symbols): Update.
16250         * dwarf2read.c (create_partial_symtab): Update.
16251         * dbxread.c (read_dbx_symtab): Update.
16252         (start_psymtab): Remove global_psymbols and static_psymbols
16253         parameters.
16254
16255 2019-01-10  Tom Tromey  <tom@tromey.com>
16256
16257         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16258         * psymtab.c (allocate_psymtab): Add comment.
16259         * psympriv.h (allocate_psymtab): Add comment.
16260         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16261         initializations.
16262         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16263
16264 2019-01-10  Tom Tromey  <tom@tromey.com>
16265
16266         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16267         Don't declare.
16268         * mipsread.c: Include mdebugread.h.
16269         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16270         Declare.
16271         * elfread.c: Include mdebugread.h.
16272
16273 2019-01-09  Tom Tromey  <tom@tromey.com>
16274
16275         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16276         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16277         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16278         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16279         (psym_lookup_symbol, psym_find_last_source_symtab)
16280         (psym_forget_cached_source_info, psym_print_stats)
16281         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16282         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16283         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16284         (psym_find_compunit_symtab_by_address)
16285         (maintenance_print_psymbols, maintenance_info_psymtabs)
16286         (maintenance_check_psymtabs): Use ranged for.
16287         * psymtab.h (class objfile_psymtabs): New.
16288         (require_partial_symbols): Return objfile_psymtabs.
16289         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16290
16291 2019-01-09  Tom Tromey  <tom@tromey.com>
16292
16293         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16294         (find_pc_mapped_section, list_overlays_command)
16295         (map_overlay_command, unmap_overlay_command)
16296         (simple_overlay_update): Use all_objfiles.
16297         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16298         * printcmd.c (info_symbol_command): Use all_objfiles.
16299         * objfiles.h (ALL_OBJSECTIONS): Remove.
16300         * maint.c (maintenance_translate_address): Use all_objfiles.
16301         * gcore.c (gcore_create_callback): Use all_objfiles.
16302         (objfile_find_memory_regions): Likewise.
16303
16304 2019-01-09  Tom Tromey  <tom@tromey.com>
16305
16306         * symtab.c (find_line_symtab, info_sources_command)
16307         (make_source_files_completion_list): Use objfile_compunits.
16308         * source.c (select_source_symtab): Use objfile_compunits.
16309         * objfiles.h (struct objfile): Update comment.
16310         (ALL_OBJFILES): Remove.
16311         (ALL_FILETABS): Remove.
16312         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16313         objfile_compunits.
16314
16315 2019-01-09  Tom Tromey  <tom@tromey.com>
16316
16317         * symmisc.c (print_objfile_statistics, dump_objfile)
16318         (maintenance_print_symbols): Use compunit_filetabs.
16319         * source.c (forget_cached_source_info_for_objfile): Use
16320         compunit_filetabs.
16321         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16322         (ALL_FILETABS): Use compunit_filetabs.
16323         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16324         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16325
16326 2019-01-09  Tom Tromey  <tom@tromey.com>
16327
16328         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16329         (compunit_filetabs): New.
16330         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16331         compunit_filetabs.
16332         (info_sources_command, make_source_files_completion_list): Remove
16333         declaration.
16334         * symmisc.c (print_objfile_statistics, dump_objfile)
16335         (maintenance_print_symbols): Remove declaration.
16336         (maintenance_info_symtabs): Use compunit_filetabs.
16337         (maintenance_info_line_tables): Likewise.
16338         * source.c (select_source_symtab): Change local variable name.
16339         (forget_cached_source_info_for_objfile): Remove declaration.
16340         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16341         * objfiles.c (objfile_relocate1): Remove declaration.
16342         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16343         declaration.
16344         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16345         * coffread.c (coff_symtab_read): Remove declaration.
16346         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16347         compunit_filetabs.
16348
16349 2019-01-09  Tom Tromey  <tom@tromey.com>
16350
16351         * symtab.c (lookup_objfile_from_block)
16352         (find_pc_sect_compunit_symtab, search_symbols)
16353         (default_collect_symbol_completion_matches_break_on): Use
16354         objfile_compunits.
16355         * objfiles.h (ALL_COMPUNITS): Remove.
16356         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16357         * cp-support.c (add_symbol_overload_list_qualified): Use
16358         objfile_compunits.
16359         * ada-lang.c (ada_collect_symbol_completion_matches)
16360         (ada_add_global_exceptions): Use objfile_compunits.
16361
16362 2019-01-09  Tom Tromey  <tom@tromey.com>
16363
16364         * source.c (select_source_symtab)
16365         (forget_cached_source_info_for_objfile): Remove declaration.
16366         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16367         declaration.
16368         * maint.c (count_symtabs_and_blocks): Remove declaration.
16369         * cp-support.c (add_symbol_overload_list_qualified): Remove
16370         declaration.
16371         * coffread.c (coff_symtab_read): Remove declaration.
16372         * symtab.c (lookup_symbol_in_objfile_symtabs)
16373         (basic_lookup_transparent_type_1): Use objfile_compunits.
16374         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16375         (info_sources_command, search_symbols)
16376         (default_collect_symbol_completion_matches_break_on)
16377         (make_source_files_completion_list): Remove declaration.
16378         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16379         (ada_collect_symbol_completion_matches)
16380         (ada_add_global_exceptions): Remove declaration.
16381         * linespec.c (iterate_over_all_matching_symtabs): Use
16382         objfile_compunits.
16383         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16384         (class objfile_compunits): New.
16385         (ALL_COMPUNITS): Use objfile_compunits.
16386         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16387         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16388         objfile_compunits.
16389         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16390
16391 2019-01-09  Tom Tromey  <tom@tromey.com>
16392
16393         * symtab.c (search_symbols)
16394         (default_collect_symbol_completion_matches_break_on): Use
16395         objfile_msymbols.
16396         * ada-lang.c (ada_lookup_simple_minsym)
16397         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16398         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16399         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16400         objfile_msymbols.
16401         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16402         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16403         * objc-lang.c (find_methods): Use objfile_msymbols.
16404         (info_selectors_command, info_classes_command): Likewise.
16405         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16406         * objfiles.h (class objfile_msymbols): New.
16407         (ALL_OBJFILE_MSYMBOLS): Remove.
16408         (ALL_MSYMBOLS): Remove.
16409
16410 2019-01-09  Tom Tromey  <tom@tromey.com>
16411
16412         * common/next-iterator.h (next_adapter): Add Iterator template
16413         parameter.
16414         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16415         (class all_objfiles_safe): New.
16416         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16417         * objfiles.c (put_objfile_before): Update comment.
16418         (add_separate_debug_objfile): Likewise.
16419         (free_all_objfiles): Use all_objfiles_safe.
16420         (objfile_purge_solibs): Likewise.
16421
16422 2019-01-09  Tom Tromey  <tom@tromey.com>
16423
16424         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16425         (expand_symtab_containing_pc, lookup_static_symbol)
16426         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16427         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16428         all_objfiles.
16429         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16430         * breakpoint.c (create_overlay_event_breakpoint)
16431         (create_longjmp_master_breakpoint)
16432         (create_std_terminate_master_breakpoint)
16433         (create_exception_master_breakpoint): Use all_objfiles.
16434         * linux-thread-db.c (try_thread_db_load_from_pdir)
16435         (has_libpthread): Use all_objfiles.
16436         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16437         * linespec.c (iterate_over_all_matching_symtabs)
16438         (search_minsyms_for_name): Use all_objfiles.
16439         * maint.c (maintenance_info_sections): Use all_objfiles.
16440         * main.c (captured_main_1): Use all_objfiles.
16441         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16442         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16443         * guile/scm-pretty-print.c
16444         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16445         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16446         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16447         (maintenance_print_msymbols): Use all_objfiles.
16448         * source.c (select_source_symtab): Use all_objfiles.
16449         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16450         * symfile.c (remove_symbol_file_command)
16451         (expand_symtabs_matching, map_symbol_filenames): Use
16452         all_objfiles.
16453         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16454         all_objfiles.
16455         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16456         * objc-lang.c (find_methods): Use all_objfiles.
16457         * objfiles.c (have_partial_symbols, have_full_symbols)
16458         (have_minimal_symbols, qsort_cmp)
16459         (default_iterate_over_objfiles_in_search_order): Use
16460         all_objfiles.
16461         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16462         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16463         (maintenance_check_psymtabs): Use all_objfiles.
16464         (ALL_PSYMTABS): Remove.
16465         * compile/compile-object-run.c (do_module_cleanup): Use
16466         all_objfiles.
16467         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16468         * cp-support.c (add_symbol_overload_list_qualified): Use
16469         all_objfiles.
16470         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16471         Use all_objfiles.
16472         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16473         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16474         all_objfiles.
16475         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16476         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16477         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16478         Uses all_objfiles.
16479         * solib.c (solib_read_symbols): Use all_objfiles
16480
16481 2019-01-09  Tom Tromey  <tom@tromey.com>
16482
16483         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16484         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16485         all_objfiles.
16486         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16487         * symmisc.c (print_symbol_bcache_statistics)
16488         (print_objfile_statistics, maintenance_print_objfiles)
16489         (maintenance_info_symtabs, maintenance_check_symtabs)
16490         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16491         all_objfiles.
16492         * source.c (forget_cached_source_info): Use all_objfiles.
16493         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16494         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16495         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16496         * objfiles.c (update_section_map): Use all_objfiles.
16497         (shared_objfile_contains_address_p): Likewise.
16498         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16499         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16500
16501 2019-01-09  Tom Tromey  <tom@tromey.com>
16502
16503         * common/next-iterator.h: New file.
16504         * objfiles.h (class all_objfiles): New.
16505         (struct objfile_iterator): New.
16506
16507 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16508
16509         * NEWS: Move the description of the changed "frame", "select-frame",
16510          and "info frame" commands to the Changed commands section.
16511
16512 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16513
16514         * gdbtypes.c (check_stub_method_group): Remove handling of old
16515         mangling schemes.
16516         * linespec.c (find_methods): Likewise.
16517         * stabsread.c (read_member_functions): Likewise.
16518         * valops.c (search_struct_method): Likewise.
16519         (value_struct_elt_for_reference): Likewise.
16520         * NEWS: Mention this change.
16521
16522 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16523
16524         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16525         print_source_lines.
16526         * source.c (print_source_lines_base): Update line number check.
16527         (print_source_lines): New function.
16528         (source_lines_range::source_lines_range): New function.
16529         * source.h (class source_lines_range): New class.
16530         (print_source_lines): New declaration.
16531
16532 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16533
16534         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16535
16536 2019-01-08  Tom Tromey  <tom@tromey.com>
16537             Simon Marchi  <simon.marchi@ericsson.com>
16538
16539         PR gdb/24060
16540         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16541         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16542         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16543         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16544         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16545         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16546
16547 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16548
16549         * source.c (select_source_symtab): Move header comment to
16550         declaration in source.h.
16551         (forget_cached_source_info_for_objfile): Likewise.
16552         (forget_cached_source_info): Likewise.
16553         (identify_source_line): Likewise.
16554         * source.h (identify_source_line): Move declaration from symtab.h
16555         and add comment from source.c
16556         (print_source_lines): Likewise.
16557         (forget_cached_source_info_for_objfile): Likewise.
16558         (forget_cached_source_info): Likewise.
16559         (select_source_symtab): Likewise.
16560         (enum print_source_lines_flag): Move definition from symtab.h.
16561         * symtab.h (identify_source_line): Move declaration to source.h.
16562         (print_source_lines): Likewise.
16563         (forget_cached_source_info_for_objfile): Likewise.
16564         (forget_cached_source_info): Likewise.
16565         (select_source_symtab): Likewise.
16566         (enum print_source_lines_flag): Move definition to source.h.
16567         * tui/tui-hooks.c: Add 'source.h' include.
16568
16569 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16570
16571         * source.c (print_source_lines_base): Handle requests to print
16572         reverse line number sequences, and guard against empty lines
16573         string.
16574
16575 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16576
16577         * source.c (print_source_lines_base): Fix skip of '\r' if next
16578         character is '\n'.
16579
16580 2019-01-06  Tom Tromey  <tom@tromey.com>
16581
16582         * c-exp.y (struct c_parse_state) <macro_original_text,
16583         expansion_obstack>: New member.
16584         (macro_original_text, expansion_obstack): Remove globals.
16585         (scan_macro_expansion, scanning_macro_expansion)
16586         (finished_macro_expansion): Update.
16587         (scan_macro_cleanup): Remove.
16588         (yylex, c_parse): Update.
16589
16590 2019-01-06  Tom Tromey  <tom@tromey.com>
16591
16592         * c-exp.y (struct c_parse_state) <strings>: New member.
16593         (operator_stoken): Update.
16594
16595 2019-01-06  Tom Tromey  <tom@tromey.com>
16596
16597         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16598         (union type_stack_elt) <typelist_val>: Now a pointer to
16599         std::vector.
16600         (type_stack_cleanup): Don't declare.
16601         (push_typelist): Update.
16602         * parse.c (pop_typelist): Return a std::vector.
16603         (push_typelist): Take a std::vector.
16604         (follow_types): Update.  Do not free args.
16605         (type_stack_cleanup): Remove.
16606         * c-exp.y (struct c_parse_state): New.
16607         (cpstate): New global.
16608         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16609         (nonempty_typelist): Update.
16610         (func_mod): Create a new vector.
16611         (c_parse): Create a c_parse_state.
16612         (check_parameter_typelist): Do not delete params.
16613         (function_method): Update.  Do not delete type_list.
16614
16615 2019-01-06  Tom Tromey  <tom@tromey.com>
16616
16617         PR gdb/28155:
16618         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16619         check_typedef.
16620         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16621         (print_return_value): Likewise.
16622
16623 2019-01-05  Tom Tromey  <tom@tromey.com>
16624
16625         * contrib/cleanup_check.py: Remove.
16626         * contrib/gcc-with-excheck: Remove.
16627         * contrib/exsummary.py: Remove.
16628         * contrib/excheck.py: Remove.
16629
16630 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16631
16632         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16633         NULL. Initialize tpprev to NULL instead of assigning it
16634         to NULL on the next statement.
16635         * windows-nat.c (windows_delete_thread): Remove check for
16636         main_thread_id before printing thread exit notifications.
16637         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16638         Remove thread ID check against main_thread_id.
16639         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16640         windows_delete_thread.
16641         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16642
16643 2019-01-04  Tom Tromey  <tom@tromey.com>
16644
16645         * compile/compile.c (_initialize_compile): Use upper case for
16646         metasyntactic variables.
16647         * symmisc.c (_initialize_symmisc): Use upper case for
16648         metasyntactic variables.
16649         * psymtab.c (_initialize_psymtab): Use upper case for
16650         metasyntactic variables.
16651         * demangle.c (demangle_command): Use upper case for metasyntactic
16652         variables.
16653         (_initialize_demangler): Likewise.
16654         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16655         variables.
16656
16657 2019-01-03  Tom Tromey  <tom@tromey.com>
16658
16659         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16660
16661 2019-01-03  Tom Tromey  <tom@tromey.com>
16662
16663         * python/py-symtab.c (salpy_str): Update.
16664         (struct salpy_sal_object) <symtab>: Now a PyObject.
16665         (salpy_dealloc): Update.
16666         (del_objfile_sal): Use gdbpy_ref.
16667
16668 2019-01-03  Tom Tromey  <tom@tromey.com>
16669
16670         * python/py-type.c (convert_field): Use new_reference.  Return
16671         gdbpy_ref.
16672         (make_fielditem): Return gdbpy_ref.
16673         (typy_fields): Update.
16674         (typy_getitem): Update.
16675         (field_name): Return gdbpy_ref.  Use new_reference.
16676         (typy_iterator_iternext): Update.
16677
16678 2019-01-03  Tom Tromey  <tom@tromey.com>
16679
16680         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16681
16682 2019-01-03  Tom Tromey  <tom@tromey.com>
16683
16684         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16685         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16686         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16687         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16688         (pspy_set_type_printers): Likewise.
16689         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16690         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16691         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16692         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16693         (objfpy_set_type_printers): Likewise.
16694
16695 2019-01-03  Tom Tromey  <tom@tromey.com>
16696
16697         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16698         (gdbpy_print_stack): Use gdbpy_err_fetch.
16699         * python/python-internal.h (class gdbpy_err_fetch): New class.
16700         (class gdbpy_enter) <m_error_type, m_error_value,
16701         m_error_traceback>: Remove.
16702         <m_error>: New member.
16703         (gdbpy_exception_to_string): Don't declare.
16704         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16705         * python/py-value.c (convert_value_from_python): Use
16706         gdbpy_err_fetch.
16707         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16708         gdbpy_exception_to_string.
16709         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16710         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16711         gdbpy_err_fetch.
16712
16713 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16714
16715         * linux-nat.c (delete_lwp_cleanup): Delete.
16716         (struct lwp_deleter): New struct.
16717         (lwp_info_up): New typedef.
16718         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16719         lwp_info_up.
16720
16721 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16722
16723         * linux-fork.c (class scoped_switch_fork_info): New class.
16724         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16725
16726 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16727
16728         * valops.c (find_overload_match): Remove use of null_cleanup, and
16729         calls to do_cleanups.
16730
16731 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16732
16733         * compile/compile-cplus-types.c
16734         (compile_cplus_instance::decl_name): Handle changes to
16735         cp_func_name.
16736         * cp-support.c (cp_func_name): Update header comment, update
16737         return type.
16738         * cp-support.h (cp_func_name): Update return type in declaration.
16739         * valops.c (find_overload_match): Move temp_func local to top
16740         level of function and change its type.  Use temp_func to hold and
16741         delete temporary string obtained from cp_func_name.
16742
16743 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16744
16745         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16746         gdb::char_vector, remove cleanup, and update uses of `msg`.
16747
16748 2019-01-03  Jim Wilson  <jimw@sifive.com>
16749
16750         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16751
16752 2019-01-02  Tom Tromey  <tom@tromey.com>
16753
16754         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16755         (tdesc_parse_xml): Remove cleanups.
16756         * target-descriptions.h (make_cleanup_free_target_description):
16757         Don't declare.
16758         (target_desc_deleter): New struct.
16759         (target_desc_up): New typedef.
16760         * target-descriptions.c (target_desc_deleter::operator()): Rename
16761         from free_target_description.
16762         (make_cleanup_free_target_description): Remove.
16763
16764 2019-01-02  Tom Tromey  <tom@tromey.com>
16765
16766         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16767         constructor, destructor.
16768         (linespec_parser): Remove typedef.
16769         (~linespec_parser): Rename from linespec_parser_delete.
16770         (linespec_lex_to_end, linespec_complete_label)
16771         (linespec_complete): Update.
16772         (decode_line_full): Remove cleanups.
16773         (decode_line_1): Update.
16774
16775 2019-01-02  Tom Tromey  <tom@tromey.com>
16776
16777         * python/python-internal.h (inferior_to_inferior_object): Change
16778         return type.
16779         * python/py-exitedevent.c (create_exited_event_object): Update.
16780         * python/py-inferior.c (inferior_to_inferior_object): Return
16781         gdbpy_ref.
16782         (python_new_inferior, python_inferior_deleted)
16783         (thread_to_thread_object, delete_thread_object)
16784         (build_inferior_list, gdbpy_selected_inferior): Update.
16785         * python/py-infthread.c (create_thread_object): Update.  Also fail
16786         if inferior_to_inferior_object fails.
16787
16788 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16789
16790         * inferior.h (class inferior) <displaced_step_state>: New field.
16791         * infrun.h (struct displaced_step_state): Move here from
16792         infrun.c.  Initialize fields, add constructor.
16793         <inf>: Remove field.
16794         <reset>: New method.
16795         * infrun.c (struct displaced_step_inferior_state): Move to
16796         infrun.h.
16797         (displaced_step_inferior_states): Remove.
16798         (get_displaced_stepping_state): Adust.
16799         (displaced_step_in_progress_any_inferior): Adjust.
16800         (displaced_step_in_progress_thread): Adjust.
16801         (displaced_step_in_progress): Adjust.
16802         (add_displaced_stepping_state): Remove.
16803         (get_displaced_step_closure_by_addr): Adjust.
16804         (remove_displaced_stepping_state): Remove.
16805         (infrun_inferior_exit): Call displaced_step_state.reset.
16806         (use_displaced_stepping): Don't check for NULL.
16807         (displaced_step_prepare_throw): Call
16808         get_displaced_stepping_state.
16809         (displaced_step_fixup): Don't check for NULL.
16810         (prepare_for_detach): Don't check for NULL.
16811
16812 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16813
16814         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16815          in case of call that did not complete.
16816
16817 2019-01-02  Andrey Utkin  <autkin@undo.io>
16818
16819         * symfile.c (find_separate_debug_file): Fix search of debug files for
16820         remote debuggee.
16821
16822 2019-01-02  Tom Tromey  <tom@tromey.com>
16823
16824         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16825         indentation.
16826         * python/py-frame.c (frapy_older): Remove cast.
16827         (frapy_newer): Likewise.
16828         * python/py-breakpoint.c (local_setattro): Remove cast.
16829         * python/py-arch.c (archpy_name): Remove local variable.
16830         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16831
16832 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16833
16834         * unittests/basic_string_view/element_access/char/empty.cc:
16835         Fix year range in copyright header.
16836
16837 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16838
16839         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16840         Delete.
16841         <operator==>: Update with for removed field.
16842         <hash>: Likewise.
16843         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16844         <isa_features>: ...this.
16845         <abi_features>: New field.
16846         (riscv_isa_flen): Update comment.
16847         (riscv_abi_xlen): New declaration.
16848         (riscv_abi_flen): New declaration.
16849         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16850         isa_features.
16851         (riscv_abi_xlen): New function.
16852         (riscv_isa_flen): Update to get answer from isa_features.
16853         (riscv_abi_flen): New function.
16854         (riscv_has_fp_abi): Update to get answer from abi_features.
16855         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16856         xlen and flen.
16857         (riscv_call_info) <xlen, flen>: Update comment.
16858         (riscv_call_arg_struct): Remove invalid assertions
16859         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16860         is removed.
16861         (riscv_gdbarch_init): Gather isa features and abi features
16862         separately, ensure both match on the gdbarch when reusing an old
16863         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16864         a target with 64-bit float hardware.
16865
16866 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16867
16868         * source.c (search_command_helper): Stop reverse search
16869         when line 1 has been searched.
16870
16871 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16872
16873         * record-full.c (record_full_base_target::close): Rewrite
16874         record_full_core_buf_list free logic.
16875
16876 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16877
16878         * break-catch-syscall.c (print_one_catch_syscall): xfree
16879         the last text.
16880
16881 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16882
16883         * top.c (print_gdb_version): Update Copyright year in version
16884         message.
16885
16886 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16887
16888         Update copyright year range in all GDB files.
16889
16890 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16891
16892         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16893
16894 For older changes see ChangeLog-2018.
16895 \f
16896 Local Variables:
16897 mode: change-log
16898 left-margin: 8
16899 fill-column: 74
16900 version-control: never
16901 coding: utf-8
16902 End:
16903