gdb/ChangeLog

   1 2019-12-18  Tom Tromey  <tromey@adacore.com>
   2
   3         PR build/25268:
   4         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
   5         type on macOS.  Add comment.
   6
   7 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
   8
   9         * c-lang.c (c_get_string, asm_language_defn): Remove space
  10         before tab.
  11
  12 2019-12-18  Tom Tromey  <tromey@adacore.com>
  13
  14         PR build/25250:
  15         * ui-out.c (ui_out::vmessage): Update.
  16         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
  17         Rename.
  18         (string_field): Update.
  19         (signed_field): Update.
  20
  21 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
  22
  23         * top.c (print_gdb_configuration): Adjust indentation.
  24
  25 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
  26
  27         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
  28
  29 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
  30
  31         * tui/tui-layout.h (class tui_layout_base): Add virtual
  32         destructor.
  33
  34 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
  35
  36         * infcmd.c (prepare_one_step): Step over skipped inline functions.
  37         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
  38         (process_event_stop_test): Keep stepping over skipped inline functions.
  39
  40 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  41
  42         * jit.c (struct gdb_block) <next>: Remove field.
  43         (struct gdb_symtab) <~gdb_symtab>: Remove.
  44         <blocks>: Change type to std::forward_list<gdb_block>.
  45         (compare_block): Remove.
  46         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
  47         block at the beginning, don't mind about sorting.
  48         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
  49         before using it.
  50
  51 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  52
  53         * jit.c (struct gdb_block): Add constructor, initialize
  54         real_block and next fields.
  55         <name>: Change type to gdb::unique_xmalloc_ptr.
  56         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
  57         (jit_block_open_impl): Allocate gdb_block with new.
  58         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
  59
  60 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  61
  62         * jit.c: Include forward_list.
  63         (struct gdb_symtab) <next>: Remove field.
  64         (struct gdb_object) <symtabs>: Change type to
  65         std::forward_list<gdb_symtab>.
  66         (jit_object_open_impl): Allocate gdb_object with new.
  67         (jit_symtab_open_impl): Adjust to std::forward_list.
  68         (finalize_symtab): Don't delete symtab.
  69         (jit_object_close_impl):  Adjust to std::forward_list.  Free
  70         gdb_object with delete.
  71
  72 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  73
  74         * jit.c (struct gdb_symtab): Add constructor, destructor,
  75         initialize fields.
  76         <linetable>: Change type to unique_xmalloc_ptr.
  77         <file_name>: Change type to std::string.
  78         (jit_symtab_open_impl): Allocate gdb_symtab with new.
  79         (jit_symtab_line_mapping_add_impl): Adjust.
  80         (finalize_symtab): Adjust, call delete on stab.
  81
  82 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  83
  84         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
  85
  86 2019-12-16  Tom Tromey  <tromey@adacore.com>
  87
  88         * windows-nat.c (windows_nat_target::attach): Update.
  89         * remote.c (extended_remote_target::attach): Update.
  90         * procfs.c (procfs_target::attach): Update.
  91         * nto-procfs.c (nto_procfs_target::attach): Update.
  92         (nto_procfs_target::create_inferior): Update.
  93         * inf-ptrace.c (inf_ptrace_target::attach): Update.
  94         * gnu-nat.c (gnu_nat_target::attach): Update.
  95         (gnu_nat_target::detach): Update.
  96         * darwin-nat.c (darwin_nat_target::attach): Update.
  97         * corefile.c (get_exec_file): Constify result.  Remove extraneous
  98         return.
  99         * bsd-kvm.c (bsd_kvm_target_open): Update.
 100         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 101
 102 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 103
 104         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 105         (we no longer need to include time.h before pathmax.h)
 106
 107 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 108
 109         * ada-exp.y (write_ambiguous_var): Update.
 110         * coffread.c (process_coff_symbol): Update.
 111         * ctfread.c (ctf_add_enum_member_cb): Update.
 112         (new_symbol): Update.
 113         * dwarf2read.c (fixup_go_packaging): Update.
 114         (new_symbol): Update.
 115         * language.c (language_alloc_type_symbol): Update.
 116         * mdebugread.c (new_symbol): Update.
 117         * minsyms.c (minimal_symbol_reader::record_full): Update.
 118         * psymtab.c (add_psymbol_to_bcache): Update.
 119         * stabsread.c (define_symbol): Update.
 120         (read_enum_type): Update.
 121         * symtab.c (symbol_set_language): Make this a member function...
 122         (general_symbol_info::set_language): ... here.
 123         * symtab.h (struct general_symbol_info) <set_language>: New function.
 124         (SYMBOL_SET_LANGUAGE): Remove.
 125         (symbol_set_language): Remove.
 126
 127 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 128
 129         * ada-lang.c (ada_add_block_symbols): Update.
 130         (ada_collect_symbol_completion_matches): Update.
 131         * ax-gdb.c (gen_expr): Update.
 132         * block.c (block_lookup_symbol): Update.
 133         (block_lookup_symbol_primary): Update.
 134         (block_find_symbol): Update.
 135         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 136         * dbxread.c (process_one_symbol): Update.
 137         * dictionary.c (insert_symbol_hashed): Update.
 138         (collate_pending_symbols_by_language): Update.
 139         (mdict_add_symbol): Update.
 140         * dwarf-index-write.c (write_psymbols): Update.
 141         * dwarf2read.c (fixup_go_packaging): Update.
 142         * findvar.c (read_var_value): Update.
 143         * ft32-tdep.c (ft32_skip_prologue): Update.
 144         * go-lang.c (go_symbol_package_name): Update.
 145         * language.h (scoped_switch_to_sym_language_if_auto::
 146         scoped_switch_to_sym_language_if_auto): Update.
 147         * linespec.c (find_method): Update.
 148         (find_label_symbols_in_block): Update.
 149         * mdebugread.c (parse_symbol): Update.
 150         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 151         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 152         (minimal_symbol_reader::install): Update.
 153         * moxie-tdep.c (moxie_skip_prologue): Update.
 154         * parse.c (parse_exp_in_context): Update.
 155         * psymtab.c (psymbol_name_matches): Update.
 156         (match_partial_symbol): Update.
 157         (lookup_partial_symbol): Update.
 158         (psymbol_hash): Update.
 159         (psymbol_compare): Update.
 160         * python/py-framefilter.c (extract_sym): Update.
 161         (py_print_single_arg): Update.
 162         * stabsread.c (define_symbol): Update.
 163         * stack.c (print_frame_arg): Update.
 164         (find_frame_funname): Update.
 165         (info_frame_command_core): Update.
 166         * symfile.c (set_initial_language): Update.
 167         * symtab.c (symbol_set_demangled_name): Update.
 168         (symbol_get_demangled_name): Update.
 169         (symbol_set_language): Update.
 170         (symbol_find_demangled_name): Update.
 171         (symbol_set_names): Update.
 172         (general_symbol_info::natural_name): Update.
 173         (general_symbol_info::demangled_name): Update.
 174         (general_symbol_info::search_name): Update.
 175         (symbol_matches_search_name): Update.
 176         (eq_symbol_entry): Update.
 177         (iterate_over_symbols): Update.
 178         (completion_list_add_symbol): Update.
 179         (completion_list_add_msymbol): Update.
 180         (completion_list_add_fields): Update.
 181         * symtab.h (struct general_symbol_info) <language>: New function.
 182         <language>: Rename to...
 183         <m_language>: ...this.
 184         (SYMBOL_LANGUAGE): Remove.
 185         (MSYMBOL_LANGUAGE): Remove.
 186         (struct symbol) <ctor>: Update.
 187         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 188
 189 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 190
 191         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 192         set the language of sym.
 193         * language.c (language_alloc_type_symbol): Likewise.
 194
 195 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 196
 197         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 198         PR gdb/23613
 199         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 200         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 201         (core_target_open): Use 'gdb_abspath'.
 202         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 203         'current_directory == NULL' case.
 204         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 205         explain what happens when 'current_directory' is NULL.
 206         * go32-nat.c (go32_nat_target::wait): Check if
 207         'current_directory' is NULL before call to 'chdir'.
 208         * source.c (add_path): Use 'gdb_abspath'.
 209         * top.c: Include 'gdbsupport/pathstuff.h'.
 210         (init_history): Use 'gdb_abspath'.
 211         (set_history_filename): Likewise.
 212         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 213         (tfile_target_open): Use 'gdb_abspath'.
 214
 215 2019-12-13  Tom Tromey  <tromey@adacore.com>
 216
 217         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 218         warning or error.
 219
 220 2019-12-13  Tom Tromey  <tromey@adacore.com>
 221
 222         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 223
 224 2019-12-13  Tom Tromey  <tromey@adacore.com>
 225
 226         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 227
 228 2019-12-13  Tom Tromey  <tromey@adacore.com>
 229
 230         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 231
 232 2019-12-13  Tom Tromey  <tromey@adacore.com>
 233
 234         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 235         (string_vappendf): Add ARI comment.
 236
 237 2019-12-13  Tom Tromey  <tromey@adacore.com>
 238
 239         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 240         floatformat_to_double.
 241         * target-float.c (host_float_ops<T>::from_target): Add ARI
 242         comment.
 243
 244 2019-12-13  Tom Tromey  <tromey@adacore.com>
 245
 246         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 247         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 248         ARI marker to abort.
 249         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 250
 251 2019-12-13  Tom Tromey  <tromey@adacore.com>
 252
 253         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 254
 255 2019-12-13  Tom Tromey  <tromey@adacore.com>
 256
 257         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 258
 259 2019-12-13  Tom Tromey  <tromey@adacore.com>
 260
 261         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 262         checks.
 263
 264 2019-12-13  Tom Tromey  <tromey@adacore.com>
 265
 266         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 267         end>: No longer "const".
 268
 269 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 270
 271         * jit.c: Fix indentation, replace spaces with tabs where
 272         applicable.
 273
 274 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 275
 276         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 277
 278 2019-12-12  Tom Tromey  <tom@tromey.com>
 279
 280         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 281         unique_ptr.
 282
 283 2019-12-12  Tom Tromey  <tom@tromey.com>
 284
 285         * progspace.h (objfile_list): New typedef.
 286         (class unwrapping_objfile_iterator)
 287         (struct unwrapping_objfile_range): Newl
 288         (struct program_space) <objfiles_range>: Change type.
 289         <objfiles>: Change return type.
 290         <add_objfile>: Change type of "objfile" parameter.
 291         <objfiles_list>: Now a list of shared_ptr.
 292         * progspace.c (program_space::add_objfile): Change type of
 293         "objfile".  Update.
 294         (program_space::remove_objfile): Update.
 295         * objfiles.h (struct objfile) <~objfile>: Make public.
 296         * objfiles.c (objfile::make): Update.
 297         (objfile::unlink): Don't call delete.
 298
 299 2019-12-12  Tom Tromey  <tom@tromey.com>
 300
 301         * symfile.c (symbol_file_clear): Update.
 302         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 303         method.
 304         * progspace.c (program_space::free_all_objfiles): New method.
 305         * objfiles.h (free_all_objfiles): Don't declare.
 306         * objfiles.c (free_all_objfiles): Move to program_space.
 307
 308 2019-12-12  Tom Tromey  <tom@tromey.com>
 309
 310         * progspace.c (program_space::add_objfile)
 311         (program_space::remove_objfile): Update.
 312         (program_space::multi_objfile_p): Remove.
 313         * objfiles.h (struct objfile) <next>: Remove.
 314         * objfiles.c (objfile::objfile): Update.
 315         (put_objfile_before): Update.
 316         (unlink_objfile): Update.
 317         * progspace.h (object_files): Remove.
 318         (struct program_space) <objfiles_head>: Remove.
 319         <objfiles_list>: New member.
 320         <objfiles_range, objfiles_safe_range>: Change type.
 321         (objfiles): Change return type.
 322         (objfiles_safe): Update.
 323         (multi_objfile_p): Rewrite and inline.
 324         (object_files): Remove macro.
 325
 326 2019-12-12  Tom Tromey  <tom@tromey.com>
 327
 328         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 329         second constructor.
 330         (basic_safe_range): New class.
 331
 332 2019-12-12  Tom Tromey  <tom@tromey.com>
 333
 334         * progspace.c (program_space::multi_objfile_p): New method.
 335         * printcmd.c (info_symbol_command): Update.
 336         * maint.c (maintenance_translate_address): Update.
 337         * objfiles.h (MULTI_OBJFILE_P): Remove.
 338         * progspace.h (struct program_space) <multi_objfile_p>: New
 339         method.
 340
 341 2019-12-12  Tom Tromey  <tom@tromey.com>
 342
 343         * progspace.h (struct program_space) <remove_objfile>: Declare.
 344         * progspace.c (program_space::remove_objfile): New method.
 345         * objfiles.c (unlink_objfile): Remove.
 346         (objfile::unlink): Call remove_objfile.
 347         (objfile): Don't call unlink_objfile.
 348
 349 2019-12-12  Tom Tromey  <tom@tromey.com>
 350
 351         * progspace.h (struct program_space) <add_objfile>: Declare
 352         method.
 353         * progspace.c (program_space::add_objfile): New method.
 354         * objfiles.c (~objfile): Don't unlink objfile.
 355         (put_objfile_before): Remove.
 356         (add_separate_debug_objfile): Don't call put_objfile_before.
 357         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 358         the per-program-space data.
 359
 360 2019-12-12  Tom Tromey  <tom@tromey.com>
 361
 362         * symfile.c (syms_from_objfile_1): Use objfile_up.
 363         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 364         method.
 365         (reread_symbols): Use objfile_up.
 366         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 367         unlink method.
 368         * objfiles.h (struct objfile) <~objfile>: Now private.
 369         <unlink>: New method.
 370         (struct objfile_deleter): New.
 371         (objfile_up): New typedef.
 372         * objfiles.c (objfile::unlink): New method.
 373         (free_objfile_separate_debug, free_all_objfiles)
 374         (objfile_purge_solibs): Use it.
 375         * jit.c (jit_unregister_code): Remove.
 376         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 377         objfile.
 378         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 379         objfile.
 380         * compile/compile-object-load.c (compile_object_load): Use
 381         objfile_up.
 382
 383 2019-12-12  Tom Tromey  <tom@tromey.com>
 384
 385         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 386         objfile::make.
 387         * objfiles.h (struct objjfile) <make>: No longer inline.
 388         (add_separate_debug_objfile): Don't declare.
 389         * objfiles.c (add_separate_debug_objfile): Now static.
 390         (objfile::make): Move from objfiles.h.  Call
 391         add_separate_debug_objfile.  Add "parent" parameter.
 392
 393 2019-12-12  Tom Tromey  <tom@tromey.com>
 394
 395         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 396         * objfiles.h (struct objfile): Make constructor private.
 397         <make>: New static method.
 398         * jit.c (jit_object_close_impl): Update.
 399
 400 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 401
 402         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 403         gdb::byte_vector.
 404
 405 2019-12-12  Tom Tromey  <tromey@adacore.com>
 406
 407         * xml-support.c (xml_fetch_content_from_file): Don't call
 408         malloc_failure.
 409         * utils.h (class gdb_argv): Remove malloc_failure comment.
 410         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 411
 412 2019-12-12  Tom Tromey  <tromey@adacore.com>
 413
 414         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 415         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 416         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 417         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 418         * riscv-ravenscar-thread.c: New file.
 419         * riscv-ravenscar-thread.h: New file.
 420         * riscv-tdep.c (riscv_gdbarch_init): Call
 421         register_riscv_ravenscar_ops.
 422
 423 2019-12-12  Tom Tromey  <tromey@adacore.com>
 424
 425         * gdbsupport/thread-pool.c (set_thread_name): Use
 426         ATTRIBUTE_UNUSED.
 427
 428 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 429
 430         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 431         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 432         macros.
 433
 434 2019-12-11  Tom Tromey  <tom@tromey.com>
 435
 436         * tui/tui-win.c (tui_set_win_height_command): Call
 437         tui_adjust_window_height.
 438         (tui_adjust_win_heights, new_height_ok): Remove.
 439         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 440         * tui/tui-layout.c (tui_adjust_window_height): New function.
 441
 442 2019-12-11  Tom Tromey  <tom@tromey.com>
 443
 444         * tui/tui-win.c (tui_resize_all): Remove code, call
 445         tui_apply_current_layout.
 446
 447 2019-12-11  Tom Tromey  <tom@tromey.com>
 448
 449         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 450         * tui/tui-layout.c (standard_layouts, applied_layout): New
 451         globals.
 452         (tui_apply_current_layout): New function.
 453         (show_layout): Set applied_layout.  Call
 454         tui_apply_current_layout.
 455         (show_source_command, show_disasm_command)
 456         (show_source_disasm_command, show_data)
 457         (show_source_or_disasm_and_command): Remove.
 458         (initialize_layouts): New function.
 459         (_initialize_tui_layout): Call initialize_layouts.
 460
 461 2019-12-11  Tom Tromey  <tom@tromey.com>
 462
 463         * tui/tui-layout.h (class tui_layout_base)
 464         (class tui_layout_window, class tui_layout_split): New.
 465         * tui/tui-layout.c (tui_get_window_by_name)
 466         (tui_layout_window::clone, tui_layout_window::apply)
 467         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 468         (tui_layout_split::add_window, tui_layout_split::clone)
 469         (tui_layout_split::get_sizes)
 470         (tui_layout_split::set_weights_from_heights)
 471         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 472         functions.
 473         (tui_layout_split::add_split, tui_layout_split::add_split)
 474         (tui_layout_split::set_weights_from_heights)
 475         (tui_layout_split::set_weights_from_heights): New functions.
 476
 477 2019-12-11  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 480         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 481         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 482         * tui/tui-data.h (struct tui_point): Remove.
 483         (struct tui_gen_win_info) <origin>: Remove.
 484         <x, y>: New fields.
 485         * tui/tui-command.c (tui_cmd_window::resize): Update.
 486
 487 2019-12-11  Tom Tromey  <tom@tromey.com>
 488
 489         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 490         Implement.
 491         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 492         Implement.
 493         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 494         method.
 495         (struct tui_win_info) <min_height>: Implement.
 496
 497 2019-12-11  Tom Tromey  <tom@tromey.com>
 498
 499         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 500         (struct tui_win_info) <can_box>: Update.
 501
 502 2019-12-11  Tom Tromey  <tom@tromey.com>
 503
 504         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 505         method.
 506         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 507         method.
 508         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 509         method.
 510         (struct tui_win_info) <max_height>: Now override.
 511
 512 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 513
 514         * NEWS: Create a new section for the next release branch.
 515         Rename the section of the current branch, now that it has
 516         been cut.
 517
 518 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 519
 520         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 521         * version.in: Bump version to 10.0.50.DATE-git.
 522
 523 2019-12-11  Tom Tromey  <tromey@adacore.com>
 524
 525         PR build/25268:
 526         * gdbsupport/thread-pool.c (set_thread_name): New function.
 527         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 528         (thread_pool::thread_function): Call set_thread_name.
 529
 530 2019-12-11  Tom Tromey  <tromey@adacore.com>
 531
 532         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 533         bfd_get_signed_8.
 534
 535 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 536
 537         * NEWS: Document -raw-values option and the related setting commands.
 538         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 539         only set it on when /r is given.
 540         * valprint.c (value_print_option_defs): New element raw-values.
 541         * Makefile.in: Add the new file.
 542
 543 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 544
 545         * gdbsupport/safe-strerror.c: Supress the unused function warning
 546         for select_strerror_r.
 547
 548 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 549
 550         * config.in: Regenerate.
 551         * configure: Regenerate.
 552         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 553         safe_strerror instead of strerror.
 554         * gdbsupport/common.m4: Don't check for strerror.
 555         * gdbsupport/safe-strerror.c: Support both the glibc version
 556         of strerror_r and the XSI version.
 557
 558 2019-12-10  Tom Tromey  <tromey@adacore.com>
 559
 560         * ada-typeprint.c (print_choices): Use a single "?".
 561         (print_variant_part): Print "?" if the discriminant name
 562         is not known.
 563
 564 2019-12-10  George Barrett  <bob@bob131.so>
 565
 566         Fix scripted probe breakpoints.
 567         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 568         declaration forward.
 569         (breakpoint_ops_for_event_location_type)
 570         (breakpoint_ops_for_event_location): Add function definitions.
 571         (break_command_1, trace_command): Use
 572         breakpoint_ops_for_event_location.
 573         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 574         declarations.
 575         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 576         breakpoint_ops_for_event_location.
 577         * python/py-breakpoint.c (bppy_init): Use
 578         breakpoint_ops_for_event_location.
 579
 580 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 581
 582         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 583         when ranking an lvalue argument for an rvalue parameter.
 584
 585 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 586
 587         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 588         template argument for scoped_restore_tmpl from bool to int.
 589
 590 2019-12-07  Keith Seitz  <keiths@redhat.com>
 591
 592         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 593         (build_id_to_debug_bfd): Make static, rewriting to use
 594         build_id_to_bfd_suffix.
 595         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 596         adding `suffix' parameter. Append SUFFIX to file names
 597         when searching for matching files.
 598         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 599         (build_id_to_exec_bfd): Likewise.
 600         * build-id.h (build_id_to_debug_bfd): Clarify that function
 601         searches for BFD of debug info file.
 602         (build_id_to_exec_bfd): Declare.
 603         * corelow.c: Include build-id.h.
 604         (locate_exec_from_corefile_build_id): New function.
 605         (core_target_open): If no executable BFD is found,
 606         search for a core file BFD using build-id.
 607
 608 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 609
 610         * bcache.c: Put in namespace gdb.
 611         * bcache.h: Likewise.
 612         * gdbtypes.c (check_types_worklist): Update.
 613         (types_deeply_equal): Update.
 614         * macrotab.c (struct macro_table) <bcache>: Update.
 615         (new_macro_table): Update.
 616         * macrotab.h (struct bcache): Put this forward declaration
 617         inside namespace gdb.
 618         (new_macro_table): Update.
 619         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 620         Update.
 621         <macro_cache>: Update.
 622         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 623
 624 2019-12-06  Tom de Vries  <tdevries@suse.de>
 625
 626         PR symtab/24971
 627         * block.c (best_symbol, better_symbol): New function.
 628         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 629         decl.
 630
 631 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 632
 633         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 634         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 635         for ranking see-through reference cases.
 636
 637 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 638         * stack.c (faas_command): Check a command is provided.
 639         * thread.c (taas_command, tfaas_command): Likewise.
 640
 641 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 642         * inferior.c (prune_inferiors):  Only call delete_inferior,
 643         Do not modify the inferior list.
 644
 645 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 646
 647         * c-exp.y: Update calls to lookup_typename,
 648         lookup_signed_typename and lookup_unsigned_typename.
 649         * c-lang.c (evaluate_subexp_c): Likewise.
 650         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 651         Likewise.
 652         * eval.c (binop_promote): Likewise.
 653         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 654         (lookup_unsigned_typename): Likewise.
 655         (lookup_signed_typename): Likewise.
 656         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 657         (lookup_signed_typename): Likewise.
 658         (lookup_typename): Likewise.
 659         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 660         lookup_typename, lookup_signed_typename,
 661         lookup_unsigned_typename.
 662         * m2-exp.y: Likewise.
 663         * printcmd.c (printf_wide_c_string): Likewise.
 664         (ui_printf): Likewise.
 665         * python/py-type.c (typy_lookup_typename): Likewise.
 666         * python/py-xmethods.c (python_xmethod_worker::invoke):
 667         Likewise.
 668         * rust-exp.y: Likewise.
 669
 670 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 671
 672         * configure.nat (obsd64): Add missing files x86-nat.o and
 673         nat/x86-dregs.o.
 674
 675 2019-12-04  Tom Tromey  <tom@tromey.com>
 676
 677         * valprint.c (val_print_string): Use metadata_style.
 678         * go-valprint.c (print_go_string): Use metadata style.
 679         * p-valprint.c (pascal_object_print_static_field): Use metadata
 680         style.
 681         * cp-valprint.c (cp_print_static_field): Use metadata style.
 682
 683 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 684             Chris January  <chris.january@arm.com>
 685
 686         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 687         tokens.
 688         (typebase): New patterns for complex, single/double precision, and
 689         single/double complex.
 690         (f77_keywords): Change token for complex keyword, and add single,
 691         double, and precision keywords.
 692
 693 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 694
 695         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 696         "info io_registers".
 697
 698 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 699
 700         * regcache.c (cooked_read_test): Initialize thread list of
 701         mock_inferior.
 702
 703 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 704
 705         * aarch64-linux-tdep.c: Remove includes.
 706
 707 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 708
 709         * aarch64-tdep.c: Remove includes.
 710
 711 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 712
 713         * filtered-iterator.h (filtered_iterator) <operator==,
 714         operator!=>: Compare wrapped iterators, not wrapped pointers.
 715         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 716         unittests/filtered_iterator-selftests.c.
 717         * unittests/filtered_iterator-selftests.c: New file.
 718
 719 2019-12-04  Tom Tromey  <tromey@adacore.com>
 720
 721         * gdbtypes.c (create_range_type): Inherit endianity
 722         from base type.
 723
 724 2019-12-04  Tom Tromey  <tromey@adacore.com>
 725
 726         * ada-lang.c (decode_constrained_packed_array)
 727         (ada_value_assign, value_assign_to_component): Update.
 728         * dwarf2loc.c (rw_pieced_value, access_memory)
 729         (dwarf2_compile_expr_to_ax): Update.
 730         * dwarf2read.c (dwarf2_add_field): Update.
 731         * eval.c (evaluate_subexp_standard): Update.
 732         * gdbarch.c, gdbarch.h: Rebuild.
 733         * gdbarch.sh (bits_big_endian): Remove.
 734         * gdbtypes.h (union field_location): Update comment.
 735         * target-descriptions.c (make_gdb_type): Update.
 736         * valarith.c (value_bit_index): Update.
 737         * value.c (struct value) <bitpos>: Update comment.
 738         (unpack_bits_as_long, modify_field): Update.
 739         * value.h (value_bitpos): Update comment.
 740
 741 2019-12-04  Tom Tromey  <tromey@adacore.com>
 742
 743         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 744         endian-ness.
 745
 746 2019-12-04  Tom Tromey  <tromey@adacore.com>
 747
 748         * dwarf2read.c (dwarf2_init_float_type)
 749         (dwarf2_init_complex_target_type): Add byte_order parameter.
 750         (read_base_type): Compute byte order earlier.
 751         * gdbtypes.c (init_float_type): Add byte_order parameter.
 752         * gdbtypes.h (init_float_type): Add byte_order parameter.
 753
 754 2019-12-04  Tom Tromey  <tromey@adacore.com>
 755
 756         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 757
 758 2019-12-04  Tom Tromey  <tromey@adacore.com>
 759
 760         * dwarf2read.c (process_structure_scope): Initialize
 761         "discr_offset".
 762
 763 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 764
 765         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 766         add it into the search spec.
 767         (parse_max_results_option): New function.
 768         (mi_info_functions_or_variables): Parse -max-results flag and pass
 769         it to mi_symbol_info.
 770         (mi_cmd_symbol_info_modules): Likewise.
 771         (mi_cmd_symbol_info_types): Likewise.
 772         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 773         return type to bool, change result container into a set, and don't
 774         add new results if we have enough already.
 775         (global_symbol_searcher::add_matching_msymbols): Change return
 776         type to bool, and don't add new results if we have enough already.
 777         (sort_search_symbols_remove_dups): Delete.
 778         (global_symbol_searcher::search): Early exit from search loop when
 779         we have enough results.  Use a std::set to collect the results
 780         from calling add_matching_symbols.
 781         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 782         member function.
 783         (global_symbol_searcher) <m_max_search_results>: New member
 784         variable.
 785         (global_symbol_searcher) <add_matching_symbols>: Update header
 786         comment and change return type to bool.
 787         (global_symbol_searcher) <add_matching_msymbols>: Update header
 788         comment and change return type to bool.
 789
 790 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 791
 792         * symtab.c (symbol_search::compare_search_syms): Update header
 793         comment.
 794         (global_symbol_searcher::is_suitable_msymbol): New function.
 795         (global_symbol_searcher::expand_symtabs): New function.
 796         (global_symbol_searcher::add_matching_symbols): New function.
 797         (global_symbol_searcher::add_matching_msymbols): New function.
 798         (global_symbol_searcher::search): Move most of the content
 799         into the new functions above, and call them as needed.
 800         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 801         function.
 802         (global_symbol_searcher) <add_matching_symbols>: New member
 803         function.
 804         (global_symbol_searcher) <add_matching_msymbols>: New member
 805         function.
 806         (global_symbol_searcher) <is_suitable_msymbol>: New member
 807         function.
 808
 809 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 810
 811         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 812         -symbol-info-module-variables entries.
 813         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 814         (mi_cmd_symbol_info_module_variables): Declare.
 815         * mi/mi-symbol-cmds.c
 816         (module_symbol_search_iterator): New typedef.
 817         (output_module_symbols_in_single_module_and_file): New function.
 818         (output_module_symbols_in_single_module): New function.
 819         (mi_info_module_functions_or_variables): New function.
 820         (mi_cmd_symbol_info_module_functions): New function.
 821         (mi_cmd_symbol_info_module_variables): New function.
 822         * NEWS: Mention new MI command.
 823
 824 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 825
 826         * bcache.c (hash): Remove.
 827         (hash_continue): Remove.
 828         * bcache.h (hash): Remove.
 829         (hash_continue): Remove.
 830         (struct bcache) <ctor>: Update.
 831         * psymtab.c (psymbol_hash): Update.
 832         * stabsread.c (hashname): Update.
 833         * utils.h (fast_hash): Add an argument for a start value,
 834         defaulting to zero.
 835
 836 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 837         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 838         (destroy_block_symbol_cache): New function.
 839         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 840         (resize_symbol_cache): Likewise.
 841
 842 2019-12-02  Tom Tromey  <tom@tromey.com>
 843
 844         * unittests/tui-selftests.c (run_tests): Make conditional.
 845         (_initialize_tui_selftest): Make conditional.
 846
 847 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 848
 849         * aix-thread.c (debug_aix_thread): Change type to bool.
 850
 851 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 852
 853         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 854
 855 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 856
 857         * dwarf2read.c (read_tag_string_type): Read the fields required to
 858         make a dynamic string, and possibly create a dynamic range for the
 859         string.
 860         (attr_to_dynamic_prop): Setup is_reference based on the type of
 861         attribute being processed.
 862         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 863         (resolve_dynamic_array): Rename to...
 864         (resolve_dynamic_array_or_string): ...this, update header comment,
 865         and accept TYPE_CODE_STRING.
 866         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 867
 868 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 869
 870         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 871         of its implementation from...
 872         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 873         the new function.
 874
 875 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 876
 877         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 878         create a range with stride where appropriate.
 879         * f-valprint.c: Include 'gdbarch.h'.
 880         (f77_print_array_1): Take the stride into account when walking the
 881         array.  Also convert the stride into addressable units.
 882         * gdbtypes.c (create_range_type): Initialise the stride to
 883         constant zero.
 884         (create_range_type_with_stride): New function, initialise the
 885         range as normal, and then setup the stride.
 886         (has_static_range): Include the stride here.  Also change the
 887         return type to bool.
 888         (create_array_type_with_stride): Consider the range stride if the
 889         array isn't given its own stride.
 890         (resolve_dynamic_range): Resolve the stride if needed.
 891         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 892         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 893         (TYPE_BIT_STRIDE): Define.
 894         (TYPE_ARRAY_BIT_STRIDE): Define.
 895         (create_range_type_with_stride): Declare.
 896         * valarith.c (value_subscripted_rvalue): Take range stride into
 897         account when walking the array.
 898
 899 2019-12-01  Tom Tromey  <tom@tromey.com>
 900
 901         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 902         specially.
 903
 904 2019-12-01  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 907         \0.
 908         * unittests/tui-selftests.c: New file.
 909         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 910
 911 2019-12-01  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 914
 915 2019-12-01  Tom Tromey  <tom@tromey.com>
 916
 917         * NEWS: Document new settings.
 918         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 919         * tui/tui-win.c (_initialize_tui_win): Add border style
 920         observers.
 921         * tui/tui-io.h (tui_apply_style): Declare.
 922         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 923         longer static.
 924         (apply_ansi_escape, tui_set_reverse_mode): Update.
 925         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 926         Add "skip_intensity" parameter.
 927         <changed>: New member.
 928         <do_set_value>: Declare.
 929         (tui_border_style, tui_active_border_style): Declare.
 930         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 931         globals.
 932         (cli_style_option): Initialize "changed".
 933         (cli_style_option::do_set_value): New function.
 934         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 935         parameter.  Update.
 936         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 937         (_initialize_cli_style): Update.  Create TUI border style
 938         commands.
 939
 940 2019-12-01  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 943         parameter.
 944         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 945         parameter.
 946         * tui/tui-win.h (compact_source): Declare.
 947         * tui/tui-win.c (compact_source): New global.
 948         (tui_set_compact_source, tui_show_compact_source): New functions.
 949         (_initialize_tui_win): Add "compact-source" setting.
 950         * tui/tui-source.c (tui_source_window::set_contents): Handle
 951         compact_source setting.
 952         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 953         * NEWS: Document new setting.
 954
 955 2019-11-30  Tom Tromey  <tom@tromey.com>
 956
 957         * dwarf2read.c (dwarf2_add_field): Include field offset when
 958         computing variant part length.
 959
 960 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 961         * NEWS:  Mention define-prefix.  Tell that command names can now
 962         contain a . character.
 963
 964 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 965
 966         * command.h (valid_cmd_char_p): Declare.
 967         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 968         the check of valid command char.
 969         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 970         valid_cmd_char_p.
 971         * cli/cli-script.c (validate_comname): Likewise.
 972         * completer.c (gdb_completer_command_word_break_characters):
 973         Do not remove . from the word break char, update comments.
 974         (complete_line_internal_1): Use valid_cmd_char_p.
 975         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 976         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 977
 978 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 979
 980         * cli/cli-script.c (do_define_command): Ensure a redefined
 981         prefix command is kept as a prefix command.
 982         (define_prefix_command): New function.
 983         (show_user_1): Report user defined prefixes.
 984         (_initialize_cli_script):  Create the new 'define-prefix' command.
 985         Add completers for 'define' and 'document'.
 986         * top.c (execute_command):  If command is a user-defined prefix only
 987         command, report the list of commands for this prefix command.
 988
 989 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 990
 991         * valops.c (find_oload_champ): Improve debug output.
 992
 993 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 994
 995         * valops.c (find_oload_champ): Print part of debug messages
 996         before the badness vector is std::move'd.
 997
 998 2019-11-28  Tom Tromey  <tom@tromey.com>
 999
1000         * value.c (creal_internal_fn): Fix comment.
1001
1002 2019-11-28  Tom Tromey  <tom@tromey.com>
1003
1004         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1005         flag_bound_evaluated>: Now unsigned.
1006
1007 2019-11-28  Tom Tromey  <tom@tromey.com>
1008
1009         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1010         declare.
1011
1012 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1013
1014         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1015         debug output.
1016         * jit.c (jit_unregister_code): Add debug print to match
1017         `jit_register_code`.
1018
1019 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1020
1021         * NEWS: Mention the new multithreaded symbol loading.
1022
1023 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1024
1025         * maint.c (n_worker_threads): Default to 0.
1026         (worker_threads_disabled): New function.
1027         * maint.h (worker_threads_disabled): New function.
1028         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1029         here if worker_threads_disabled () is true.
1030         (minimal_symbol_reader::install): Skip all threading if
1031         worker_threads_disabled () is true.
1032
1033 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1034
1035         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1036         hash code if possible.
1037         (add_minsym_to_demangled_hash_table): Likewise.
1038         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1039         on the background thread.
1040         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1041         Add these fields.
1042
1043 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1044
1045         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1046         of the mangled name on the background thread.
1047         * symtab.c (symbol_set_names): Allow passing in the hash of the
1048         linkage_name.
1049         * symtab.h (symbol_set_names): Likewise.
1050
1051 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1052
1053         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1054         physnames are computed for inherited DIEs.
1055
1056 2019-11-27  Tom Tromey  <tromey@adacore.com>
1057
1058         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1059         backslashes.
1060         * cp-support.c: Remove unnecessary backslashes.
1061
1062 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1063
1064         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1065         with sym->set_linkage_name.
1066         * coffread.c (coff_read_enum_type): Likewise.
1067         * mdebugread.c (parse_symbol): Likewise.
1068         * stabsread.c (patch_block_stabs): Likewise.
1069         (define_symbol): Likewise.
1070         (read_enum_type): Likewise.
1071         (common_block_end): Likewise.
1072         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1073         function.
1074         (SYMBOL_SET_LINKAGE_NAME): Remove.
1075         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1076         with sym->set_linkage_name.
1077
1078 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1081         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1082         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1083         * NEWS: Mention new MI command.
1084
1085 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1086
1087         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1088         '-symbol-info-types', and '-symbol-info-variables'.
1089         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1090         (mi_cmd_symbol_info_types): Declare.
1091         (mi_cmd_symbol_info_variables): Declare.
1092         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1093         (output_debug_symbol): New function.
1094         (output_nondebug_symbol): New function.
1095         (mi_symbol_info): New function.
1096         (mi_info_functions_or_variables): New function.
1097         (mi_cmd_symbol_info_functions): New function.
1098         (mi_cmd_symbol_info_types): New function.
1099         (mi_cmd_symbol_info_variables): New function.
1100         * NEWS: Mention new commands.
1101
1102 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1103
1104         * symtab.c (symbol_to_info_string): New function, most content
1105         moved from print_symbol_info, but updated to return a std::string.
1106         (print_symbol_info): Update to use symbol_to_info_string and print
1107         returned string.
1108         * symtab.h (symbol_to_info_string): Declare new function.
1109
1110 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1111
1112         * python/python.c (gdbpy_rbreak): Convert to using
1113         global_symbol_searcher.
1114         * symtab.c (file_matches): Convert return type to bool, change
1115         file list to std::vector, update header comment.
1116         (search_symbols): Rename to...
1117         (global_symbol_searcher::search): ...this and update now its
1118         a member function of global_symbol_searcher.  Take account of the
1119         changes to file_matches.
1120         (symtab_symbol_info): Convert to using global_symbol_searcher.
1121         (rbreak_command): Likewise.
1122         (search_module_symbols): Likewise.
1123         * symtab.h (enum symbol_search): Update comment.
1124         (search_symbols): Remove declaration.
1125         (class global_symbol_searcher): New class.
1126
1127 2019-11-26  Tom Tromey  <tromey@adacore.com>
1128
1129         * cp-support.c (_initialize_cp_support): Conditionally initialize
1130         gdb_demangle_attempt_core_dump.
1131
1132 2019-11-26  Tom Tromey  <tom@tromey.com>
1133
1134         * python/py-function.c (fnpy_init): Update.
1135         * value.h (add_internal_function): Adjust declaration.
1136         * value.c (function_destroyer): Remove.
1137         (do_add_internal_function): Don't set destroyer or copy name.
1138         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1139         Set name_allocated.
1140         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1141         (cmdpy_init): Set name_allocated.
1142         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1143         member.
1144         (~cmd_list_element): Free "name" if needed.
1145
1146 2019-11-26  Tom Tromey  <tom@tromey.com>
1147
1148         * value.h (add_internal_function): Add new overload.  Move
1149         documentation from value.h.
1150         * value.c (do_add_internal_function): New function.
1151         (add_internal_function): Use it.  Add new overload.
1152         (function_destroyer): Don't free doc.
1153         * python/py-function.c (fnpy_init): Update.
1154
1155 2019-11-26  Tom Tromey  <tom@tromey.com>
1156
1157         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1158         (cmdpy_init): Set "doc_allocated".
1159
1160 2019-11-26  Tom Tromey  <tom@tromey.com>
1161
1162         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1163         name of worker thread.
1164         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1165         pthread_setname_np.
1166         * configure, config.in: Rebuild.
1167
1168 2019-11-26  Tom Tromey  <tom@tromey.com>
1169
1170         * python/python.c (class gdbpy_gil): New.
1171         (struct gdbpy_event): Add constructor, destructor, operator().
1172         (gdbpy_post_event): Use run_on_main_thread.
1173         (gdbpy_initialize_events): Remove.
1174         (do_start_initialization): Update.
1175
1176 2019-11-26  Tom Tromey  <tom@tromey.com>
1177
1178         * NEWS: Add entry.
1179         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1180         commands.  Call update_thread_pool_size.
1181         (update_thread_pool_size, maintenance_set_worker_threads): New
1182         functions.
1183         (n_worker_threads): New global.
1184
1185 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1186             Tom Tromey  <tom@tromey.com>
1187
1188         * minsyms.c (minimal_symbol_reader::install): Use
1189         parallel_for_each.
1190         * gdbsupport/parallel-for.h: New file.
1191         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1192
1193 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1194             Tom Tromey  <tom@tromey.com>
1195
1196         * gdbsupport/thread-pool.h: New file.
1197         * gdbsupport/thread-pool.c: New file.
1198         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1199         (HFILES_NO_SRCDIR): Add thread-pool.h.
1200
1201 2019-11-26  Tom Tromey  <tom@tromey.com>
1202
1203         * event-top.h (thread_local_segv_handler): Declare.
1204         * event-top.c (thread_local_segv_handler): New global.
1205         (install_handle_sigsegv, handle_sigsegv): New functions.
1206         (async_init_signals): Install SIGSEGV handler.
1207         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1208         thread-local.
1209         (report_failed_demangle): New function.
1210         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1211         handler-setting code, instead use segv_handler.  Run warning code
1212         on main thread.
1213
1214 2019-11-26  Tom Tromey  <tom@tromey.com>
1215
1216         * run-on-main-thread.c: New file.
1217         * run-on-main-thread.h: New file.
1218         * unittests/main-thread-selftests.c: New file.
1219         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1220         main-thread-selftests.c.
1221         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1222         (COMMON_SFILES): Add run-on-main-thread.c.
1223
1224 2019-11-26  Tom Tromey  <tom@tromey.com>
1225
1226         * main.c (setup_alternate_signal_stack): Remove.
1227         (captured_main_1): Use gdb::alternate_signal_stack.
1228         * gdbsupport/alt-stack.h: New file.
1229
1230 2019-11-26  Tom Tromey  <tom@tromey.com>
1231
1232         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1233         Remove comment.
1234         (save_original_signals_state, restore_original_signals_state): Use
1235         gdb_sigmask.
1236         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1237         (_initialize_linux_nat): Use gdb_sigmask.
1238         * guile/guile.c (_initialize_guile): Use block_signals.
1239         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1240         * gdbsupport/gdb-sigmask.h: New file.
1241         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1242         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1243         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1244         pthread_sigmask.
1245         * configure, config.in: Rebuild.
1246         * gdbsupport/block-signals.h: New file.
1247
1248 2019-11-26  Tom Tromey  <tom@tromey.com>
1249
1250         * acinclude.m4: Include ax_pthread.m4.
1251         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1252         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1253         (CLIBS): Use PTHREAD_LIBS.
1254         (aclocal_m4_deps): Add ax_pthread.m4.
1255         * config.in, configure: Rebuild.
1256         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1257
1258 2019-11-26  Tom Tromey  <tom@tromey.com>
1259
1260         * symtab.h (struct minimal_symbol) <name_set>: New member.
1261         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1262         Don't call symbol_set_names.
1263         (minimal_symbol_reader::install): Call symbol_set_names.
1264
1265 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1266
1267         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1268         restore_active_ext_lang, as GIL is needed for (indirectly)
1269         called PyOS_InterruptOccurred.
1270
1271 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1272
1273         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1274         definition.
1275
1276 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1277
1278         * remote-sim.c (simulator_command): Make static, remove
1279         declaration.
1280
1281 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1282
1283         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1284         static.
1285         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1286         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1287         (main): Likewise.
1288         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1289         (main): Likewise.
1290         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1291         (main): Likewise.
1292         * unittests/basic_string_view/element_access/char/1.cc (test01):
1293         Likewise.
1294         (main): Likewise.
1295         * unittests/basic_string_view/element_access/char/empty.cc (main):
1296         Likewise.
1297         * unittests/basic_string_view/element_access/char/front_back.cc
1298         (test01): Likewise.
1299         (main): Likewise.
1300         * unittests/basic_string_view/inserters/char/2.cc (test05):
1301         Likewise.
1302         (main): Likewise.
1303         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1304         (test01): Likewise.
1305         (main): Likewise.
1306         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1307         (test01): Likewise.
1308         (main): Likewise.
1309         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1310         Likewise.
1311         * unittests/basic_string_view/operations/compare/char/1.cc
1312         (test01): Likewise.
1313         (main): Likewise.
1314         * unittests/basic_string_view/operations/compare/char/13650.cc
1315         (test01): Likewise.
1316         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1317         Likewise.
1318         (main): Likewise.
1319         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1320         Likewise.
1321         (main): Likewise.
1322         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1323         Likewise.
1324         (main): Likewise.
1325         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1326         Likewise.
1327         (main): Likewise.
1328         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1329         Likewise.
1330         (main): Likewise.
1331         * unittests/basic_string_view/operations/find/char/4.cc (main):
1332         Likewise.
1333         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1334         Likewise.
1335         (main): Likewise.
1336         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1337         Likewise.
1338         (main): Likewise.
1339         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1340         Likewise.
1341         (main): Likewise.
1342         * unittests/basic_string_view/operations/substr/char/1.cc
1343         (test01): Likewise.
1344         (main): Likewise.
1345         * unittests/basic_string_view/operators/char/2.cc (main):
1346         Likewise.
1347         * unittests/optional/assignment/1.cc (test): Likewise.
1348         * unittests/optional/assignment/2.cc (test): Likewise.
1349         * unittests/optional/assignment/3.cc (test): Likewise.
1350         * unittests/optional/assignment/4.cc (test): Likewise.
1351         * unittests/optional/assignment/5.cc (test): Likewise.
1352         * unittests/optional/assignment/6.cc (test): Likewise.
1353         * unittests/optional/assignment/7.cc (test): Likewise.
1354         * unittests/optional/cons/copy.cc (test): Likewise.
1355         * unittests/optional/cons/default.cc (test): Likewise.
1356         * unittests/optional/cons/move.cc (test): Likewise.
1357         * unittests/optional/cons/value.cc (test): Likewise.
1358         * unittests/optional/in_place.cc (test): Likewise.
1359         * unittests/optional/observers/1.cc (test): Likewise.
1360         * unittests/optional/observers/2.cc (test): Likewise.
1361
1362 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1363
1364         * tui-win.h (tui_set_var_cmd): Remove.
1365         * tui-win.c (tui_set_var_cmd): Make static.
1366
1367 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1368
1369         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1370         rbreak_command_wrapper): Remove.
1371         * symtab.c (rbreak_command_wrapper): Remove.
1372
1373 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1374
1375         * inferior.h (info_terminal_command): Remove declaration.
1376         * inflow.c (info_terminal_command): Make static.
1377
1378 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1379
1380         * inferior.c (exit_inferior_silent): Remove.
1381
1382 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1383
1384         * dictionary.c (dict_empty, mdict_empty): Remove.
1385         * dictionary.c (mdict_empty): Remove.
1386
1387 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1388
1389          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1390          (arc_insn_get_memory_offset): Likewise.
1391          (arc_insn_dump): Likewise.
1392          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1393          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1394          * dictionary.c (dict_iterator_next): Likewise.
1395          (dict_iter_match_first): Likewise.
1396          (dict_iter_match_next): Likewise.
1397          * f-lang.c (evaluate_subexp_f): Likewise.
1398          * hppa-tdep.c (hppa_read_pc): Likewise.
1399          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1400          * parse.c (write_exp_elt_msym): Likewise.
1401          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1402          * remote.c (remote_packet_size): Likewise.
1403          (remote_notif_stop_parse): Likewise.
1404          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1405          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1406          * source.c (prepare_path_for_appending): Likewise.
1407          * sparc64-linux-tdep.c
1408          (sparc64_linux_handle_segmentation_fault); Likewise.
1409          * stack.c (frame_selection_by_function_completer): Likewise.
1410
1411 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1412
1413         * completer.c (set_gdb_completion_word_break_characters):
1414         Remove.
1415
1416 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1417
1418         * dwarf-index-write.c: Include dwarf-index-write.h.
1419         * mi/mi-interp.c: Include mi/mi-interp.h.
1420
1421 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1422
1423         * aarch32-tdep.c: Include aarch32-tdep.h.
1424         * aarch32-tdep.h: Forward-declare struct target_desc.
1425
1426 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1427
1428         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1429         strerror.
1430         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1431         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1432
1433 2019-11-25  Tom de Vries  <tdevries@suse.de>
1434
1435         * contrib/words.sh: Add -c option.
1436
1437 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1438
1439         * solib.c (solib_find_1): Change int to bool.
1440         (exec_file_find): Change int to bool.
1441         (solib_find): Change int to bool.
1442         (solib_read_symbols): Change int to bool.
1443         (solib_used): Change int to bool.
1444         (solib_add): Change int to bool.
1445         (info_sharedlibrary_command): Change int to bool.
1446         (solib_contains_address_p): Change int to bool.
1447         (solib_keep_data_in_core): Change int to bool.
1448         (in_solib_dynsym_resolve_code): Change int to bool.
1449         (reload_shared_libraries_1): Change int to bool.
1450         (gdb_sysroot_changed): Change int to bool.
1451         * solib.h (solib_read_symbols): Change int to bool.
1452         (solib_contains_address_p): Change int to bool.
1453         (solib_keep_data_in_core): Change int to bool.
1454         (in_solib_dynsym_resolve_code): Change int to bool.
1455         (libpthread_name_p): Change int to bool.
1456
1457 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1458
1459         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1460         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1461         (remote_packet_max_chars): New static global.
1462         (show_remote_packet_max_chars): New function.
1463         (remote_target::putpkt_binary): Adjust to use new
1464         remote_packet_max_chars option.
1465         (remote_target::getpkt_or_notif_sane_1): Likewise.
1466         (_initialize_remote): Register new remote-packet-max-chars option.
1467
1468 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1469
1470         * m68k-linux-nat.c: Include gdbarch.h.
1471
1472 2019-11-24  Tom Tromey  <tom@tromey.com>
1473
1474         * symfile.c (read_symbols): Update.
1475         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1476         bool.
1477         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1478         (psym_lookup_symbol, psym_find_last_source_symtab)
1479         (psym_forget_cached_source_info, psym_print_stats)
1480         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1481         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1482         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1483         (psym_find_compunit_symtab_by_address)
1484         (maintenance_print_psymbols, maintenance_info_psymtabs)
1485         (maintenance_check_psymtabs): Update.
1486         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1487         bool.
1488
1489 2019-11-22  Tom Tromey  <tom@tromey.com>
1490
1491         * observable.h: Update comments.
1492
1493 2019-11-22  Tom Tromey  <tromey@adacore.com>
1494
1495         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1496         (print_ada_task_info): Don't try to fetch thread id if task is not
1497         alive.
1498
1499 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1500
1501         * ada-exp.y: Update.
1502         * ada-lang.c (sort_choices): Update.
1503         (ada_print_symbol_signature): Update.
1504         (resolve_subexp): Update.
1505         (ada_parse_renaming): Update.
1506         (ada_read_renaming_var_value): Update.
1507         (lesseq_defined_than): Update.
1508         (remove_extra_symbols): Update.
1509         (remove_irrelevant_renamings): Update.
1510         (ada_add_block_symbols): Update.
1511         (ada_collect_symbol_completion_matches): Update.
1512         (ada_is_renaming_symbol): Update.
1513         (aggregate_assign_from_choices): Update.
1514         (ada_evaluate_subexp): Update.
1515         (ada_has_this_exception_support): Update.
1516         (ada_is_non_standard_exception_sym): Update.
1517         (ada_add_exceptions_from_frame): Update.
1518         (ada_add_global_exceptions): Update.
1519         (ada_print_subexp): Update.
1520         * ax-gdb.c (gen_var_ref): Update.
1521         (gen_maybe_namespace_elt): Update.
1522         (gen_expr_for_cast): Update.
1523         (gen_expr): Update.
1524         * block.h: Update.
1525         * blockframe.c (find_pc_partial_function): Update.
1526         * breakpoint.c (print_breakpoint_location): Update.
1527         (update_static_tracepoint): Update.
1528         * btrace.c (ftrace_print_function_name): Update.
1529         (ftrace_function_switched): Update.
1530         * buildsym.c (find_symbol_in_list): Update.
1531         * c-exp.y: Update.
1532         * c-typeprint.c (c_print_typedef): Update.
1533         (c_type_print_template_args): Update.
1534         * cli/cli-cmds.c (edit_command): Update.
1535         (list_command): Update.
1536         (print_sal_location): Update.
1537         * coffread.c (patch_opaque_types): Update.
1538         (process_coff_symbol): Update.
1539         (coff_read_enum_type): Update.
1540         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1541         (convert_one_symbol): Update.
1542         (hash_symname): Update.
1543         (eq_symname): Update.
1544         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1545         * compile/compile-cplus-types.c (debug_print_scope): Update.
1546         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1547         * compile/compile-object-load.c (get_out_value_type): Update.
1548         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1549         (search_symbol_list): Update.
1550         (cp_lookup_symbol_imports_or_template): Update.
1551         * cp-support.c (overload_list_add_symbol): Update.
1552         * ctfread.c (psymtab_to_symtab): Update.
1553         * dbxread.c (cp_set_block_scope): Update.
1554         * dictionary.c (iter_match_first_hashed): Update.
1555         (iter_match_next_hashed): Update.
1556         (insert_symbol_hashed): Update.
1557         (iter_match_next_linear): Update.
1558         * dictionary.h: Update.
1559         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1560         (locexpr_describe_location_piece): Update.
1561         (locexpr_describe_location_1): Update.
1562         (locexpr_generate_c_location): Update.
1563         (loclist_describe_location): Update.
1564         (loclist_generate_c_location): Update.
1565         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1566         (read_func_scope): Update.
1567         (process_enumeration_scope): Update.
1568         (new_symbol): Update.
1569         (dwarf2_const_value): Update.
1570         (dwarf2_symbol_mark_computed): Update.
1571         * eval.c (evaluate_funcall): Update.
1572         (evaluate_subexp_standard): Update.
1573         * expprint.c (print_subexp_standard): Update.
1574         (dump_subexp_body_standard): Update.
1575         * f-valprint.c (info_common_command_for_block): Update.
1576         * findvar.c (get_hosting_frame): Update.
1577         (default_read_var_value): Update.
1578         * go-lang.c (go_symbol_package_name): Update.
1579         * guile/scm-block.c (bkscm_print_block_smob): Update.
1580         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1581         (gdbscm_symbol_name): Update.
1582         (gdbscm_symbol_linkage_name): Update.
1583         (gdbscm_symbol_print_name): Update.
1584         * infcall.c (get_function_name): Update.
1585         * infcmd.c (jump_command): Update.
1586         (finish_command): Update.
1587         * infrun.c (insert_exception_resume_breakpoint): Update.
1588         * linespec.c (canonicalize_linespec): Update.
1589         (create_sals_line_offset): Update.
1590         (convert_linespec_to_sals): Update.
1591         (complete_label): Update.
1592         (find_label_symbols_in_block): Update.
1593         * m2-typeprint.c (m2_print_typedef): Update.
1594         * mdebugread.c (mdebug_reg_to_regnum): Update.
1595         (parse_symbol): Update.
1596         (mylookup_symbol): Update.
1597         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1598         (list_args_or_locals): Update.
1599         * objc-lang.c (compare_selectors): Update.
1600         (info_selectors_command): Update.
1601         (compare_classes): Update.
1602         (info_classes_command): Update.
1603         (find_imps): Update.
1604         * p-typeprint.c (pascal_print_typedef): Update.
1605         * printcmd.c (build_address_symbolic): Update.
1606         (info_address_command): Update.
1607         (print_variable_and_value): Update.
1608         * python/py-framefilter.c (extract_sym): Update.
1609         (py_print_single_arg): Update.
1610         * python/py-symbol.c (sympy_str): Update.
1611         (sympy_get_name): Update.
1612         (sympy_get_linkage_name): Update.
1613         * python/python.c (gdbpy_rbreak): Update.
1614         * record-btrace.c (btrace_get_bfun_name): Update.
1615         (btrace_call_history): Update.
1616         * rust-lang.c (rust_print_typedef): Update.
1617         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1618         * stabsread.c (stab_reg_to_regnum): Update.
1619         (define_symbol): Update.
1620         (read_enum_type): Update.
1621         (common_block_end): Update.
1622         (cleanup_undefined_types_1): Update.
1623         (scan_file_globals): Update.
1624         * stack.c (print_frame_arg): Update.
1625         (print_frame_args): Update.
1626         (find_frame_funname): Update.
1627         (info_frame_command_core): Update.
1628         (iterate_over_block_locals): Update.
1629         (print_block_frame_labels): Update.
1630         (do_print_variable_and_value): Update.
1631         (iterate_over_block_arg_vars): Update.
1632         (return_command): Update.
1633         * symmisc.c (dump_symtab_1): Update.
1634         (print_symbol): Update.
1635         * symtab.c (eq_symbol_entry): Update.
1636         (symbol_cache_dump): Update.
1637         (lookup_language_this): Update.
1638         (find_pc_sect_line): Update.
1639         (skip_prologue_sal): Update.
1640         (symbol_search::compare_search_syms): Update.
1641         (treg_matches_sym_type_name): Update.
1642         (search_symbols): Update.
1643         (print_symbol_info): Update.
1644         (rbreak_command): Update.
1645         (completion_list_add_symbol): Update.
1646         (find_gnu_ifunc): Update.
1647         (get_symbol_address): Update.
1648         (search_module_symbols): Update.
1649         (info_module_subcommand): Update.
1650         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1651         (SYMBOL_LINKAGE_NAME): Remove.
1652         (SYMBOL_DEMANGLED_NAME): Remove.
1653         (SYMBOL_PRINT_NAME): Remove.
1654         (SYMBOL_SEARCH_NAME): Remove.
1655         * tracepoint.c (set_traceframe_context): Update.
1656         (validate_actionline): Update.
1657         (collection_list::collect_symbol): Update.
1658         (encode_actions_1): Update.
1659         (info_scope_command): Update.
1660         (print_one_static_tracepoint_marker): Update.
1661         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1662         * valops.c (address_of_variable): Update.
1663         (find_overload_match): Update.
1664         (find_oload_champ): Update.
1665
1666 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1667
1668         * ada-lang.c (ada_lookup_simple_minsym): Update.
1669         (ada_collect_symbol_completion_matches): Update.
1670         * ada-tasks.c (read_atcb): Update.
1671         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1672         (amd64_windows_skip_trampoline_code): Update.
1673         * arm-tdep.c (skip_prologue_function): Update.
1674         (arm_skip_stack_protector): Update.
1675         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1676         (arm_wince_skip_main_prologue): Update.
1677         * ax-gdb.c (gen_expr): Update.
1678         * block.c (call_site_for_pc): Update.
1679         * blockframe.c (find_pc_partial_function): Update.
1680         * breakpoint.c (set_breakpoint_location_function): Update.
1681         * btrace.c (ftrace_print_function_name): Update.
1682         (ftrace_function_switched): Update.
1683         * c-valprint.c (print_unpacked_pointer): Update.
1684         * coffread.c (coff_symfile_read): Update.
1685         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1686         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1687         * dwarf-index-write.c (write_psymbols): Update.
1688         * dwarf2loc.c (call_site_to_target_addr): Update.
1689         (func_verify_no_selftailcall): Update.
1690         (tailcall_dump): Update.
1691         (call_site_find_chain_1): Update.
1692         (dwarf_expr_reg_to_entry_parameter): Update.
1693         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1694         * eval.c (evaluate_funcall): Update.
1695         (evaluate_subexp_standard): Update.
1696         (evaluate_subexp_for_sizeof): Update.
1697         * expprint.c (print_subexp_standard): Update.
1698         (dump_subexp_body_standard): Update.
1699         * frame.c (get_prev_frame_always_1): Update.
1700         * frv-tdep.c (frv_skip_main_prologue): Update.
1701         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1702         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1703         (gnuv3_get_typename_from_type_info): Update.
1704         (gnuv3_skip_trampoline): Update.
1705         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1706         * i386-tdep.c (i386_skip_main_prologue): Update.
1707         (i386_pe_skip_trampoline_code): Update.
1708         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1709         * infcall.c (get_function_name): Update.
1710         * linespec.c (minsym_found): Update.
1711         * linux-fork.c (info_checkpoints_command): Update.
1712         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1713         (m32c_m16c_pointer_to_address): Update.
1714         * maint.c (maintenance_translate_address): Update.
1715         * minsyms.c (add_minsym_to_hash_table): Update.
1716         (add_minsym_to_demangled_hash_table): Update.
1717         (lookup_minimal_symbol_mangled): Update.
1718         (lookup_minimal_symbol_demangled): Update.
1719         (lookup_minimal_symbol_linkage): Update.
1720         (lookup_minimal_symbol_text): Update.
1721         (lookup_minimal_symbol_by_pc_name): Update.
1722         (minimal_symbol_is_less_than): Update.
1723         (compact_minimal_symbols): Update.
1724         (build_minimal_symbol_hash_tables): Update.
1725         (find_solib_trampoline_target): Update.
1726         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1727         (mips_skip_pic_trampoline_code): Update.
1728         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1729         * objc-lang.c (info_selectors_command): Update.
1730         (info_classes_command): Update.
1731         (find_methods): Update.
1732         (find_imps): Update.
1733         * p-valprint.c (pascal_val_print): Update.
1734         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1735         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1736         * printcmd.c (build_address_symbolic): Update.
1737         (info_symbol_command): Update.
1738         * psymtab.c (psymbol_name_matches): Update.
1739         (match_partial_symbol): Update.
1740         (lookup_partial_symbol): Update.
1741         (print_partial_symbols): Update.
1742         (sort_pst_symbols): Update.
1743         (maintenance_check_psymtabs): Update.
1744         * python/py-framefilter.c (py_print_frame): Update.
1745         * python/python.c (gdbpy_rbreak): Update.
1746         * record-btrace.c (btrace_get_bfun_name): Update.
1747         (btrace_call_history): Update.
1748         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1749         (rs6000_skip_trampoline_code): Update.
1750         * sol-thread.c (info_cb): Update.
1751         * stabsread.c (scan_file_globals): Update.
1752         * stack.c (find_frame_funname): Update.
1753         (info_frame_command_core): Update.
1754         * symmisc.c (dump_msymbols): Update.
1755         * symtab.c (symbol_natural_name): Rename to..,
1756         (general_symbol_info::natural_name): ...this.
1757         (symbol_demangled_name): Rename to...
1758         (general_symbol_info::demangled_name): ...this.
1759         (symbol_search_name): Rename to...
1760         (general_symbol_info::search_name): ...this.
1761         (symbol_matches_search_name): Update.
1762         (find_pc_sect_line): Update.
1763         (skip_prologue_sal): Update.
1764         (search_symbols): Update.
1765         (print_msymbol_info): Update.
1766         (rbreak_command): Update.
1767         (completion_list_add_msymbol): Update.
1768         (completion_list_objc_symbol): Update.
1769         (get_msymbol_address): Update.
1770         * symtab.h (struct general_symbol_info): Add member functions
1771         natural_name (), linkage_name (), print_name (), demangled_name (),
1772         and search_name ().
1773         (SYMBOL_NATURAL_NAME): Update.
1774         (symbol_natural_name): Move to a member function on general_symbol_info.
1775         (SYMBOL_DEMANGLED_NAME): Update.
1776         (symbol_demangled_name): Move to a member function on
1777         general_symbol_info.
1778         (SYMBOL_SEARCH_NAME): Update.
1779         (symbol_search_name): Move to a member function on general_symbol_info.
1780         (MSYMBOL_NATURAL_NAME): Remove.
1781         (MSYMBOL_LINKAGE_NAME): Remove.
1782         (MSYMBOL_PRINT_NAME): Remove.
1783         (MSYMBOL_DEMANGLED_NAME): Remove.
1784         (MSYMBOL_SEARCH_NAME): Remove.
1785         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1786
1787 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1788
1789         * symtab.c (create_demangled_names_hash): Use per_bfd->
1790         minimal_symbol_count for computing the initial size, if greater
1791         than our default size.
1792
1793 2019-11-22  Tom de Vries  <tdevries@suse.de>
1794
1795         * contrib/words.sh: Improve words extraction.
1796
1797 2019-11-22  Tom de Vries  <tdevries@suse.de>
1798
1799         * contrib/words.sh: Combine sed invocations.
1800
1801 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1802
1803         * Makefile.in: Update.
1804         * demangle.c: Rename to...
1805         * gdb-demangle.c: ..this.
1806         (is_cplus_marker): Change return type to bool.
1807         (_initialize_demangler): Rename to...
1808         (_initialize_gdb_demangle): ...this.
1809         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1810         * symtab.h (demangle): Remove declaration; instead include
1811         gdb-demangle.h.
1812
1813 2019-11-21  Tom Tromey  <tromey@adacore.com>
1814
1815         * gdbsupport/format.c (format_pieces): Parse %I64d.
1816         * unittests/format_pieces-selftests.c (test_windows_formats): New
1817         function.
1818         (run_tests): Call it.
1819
1820 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1821
1822         Byte reverse display of variables with DW_END_big, DW_END_little
1823         (DW_AT_endianity) dwarf attributes if different than the native
1824         byte order.
1825         * ada-lang.c (ada_value_binop):
1826         Use type_byte_order instead of gdbarch_byte_order.
1827         * ada-valprint.c (printstr):
1828         (ada_val_print_string):
1829         * ada-lang.c (value_pointer):
1830         (ada_value_binop):
1831         Use type_byte_order instead of gdbarch_byte_order.
1832         * c-lang.c (c_get_string):
1833         Use type_byte_order instead of gdbarch_byte_order.
1834         * c-valprint.c (c_val_print_array):
1835         Use type_byte_order instead of gdbarch_byte_order.
1836         * cp-valprint.c (cp_print_class_member):
1837         Use type_byte_order instead of gdbarch_byte_order.
1838         * dwarf2loc.c (rw_pieced_value):
1839         Use type_byte_order instead of gdbarch_byte_order.
1840         * dwarf2read.c (read_base_type): Handle DW_END_big,
1841         DW_END_little
1842         * f-lang.c (f_get_encoding):
1843         Use type_byte_order instead of gdbarch_byte_order.
1844         * findvar.c (default_read_var_value):
1845         Use type_byte_order instead of gdbarch_byte_order.
1846         * gdbtypes.c (check_types_equal):
1847         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1848         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1849         and TYPE_ENDIANITY_LITTLE if set.
1850         (type_byte_order): new function.
1851         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1852         (struct main_type) <flag_endianity_not_default>:
1853         New field.
1854         (type_byte_order): New function.
1855         * infcmd.c (default_print_one_register_info):
1856         Use type_byte_order instead of gdbarch_byte_order.
1857         * p-lang.c (pascal_printstr):
1858         Use type_byte_order instead of gdbarch_byte_order.
1859         * p-valprint.c (pascal_val_print):
1860         Use type_byte_order instead of gdbarch_byte_order.
1861         * printcmd.c (print_scalar_formatted):
1862         Use type_byte_order instead of gdbarch_byte_order.
1863         * solib-darwin.c (darwin_current_sos):
1864         Use type_byte_order instead of gdbarch_byte_order.
1865         * solib-svr4.c (solib_svr4_r_ldsomap):
1866         Use type_byte_order instead of gdbarch_byte_order.
1867         * stap-probe.c (stap_modify_semaphore):
1868         Use type_byte_order instead of gdbarch_byte_order.
1869         * target-float.c (target_float_same_format_p):
1870         Use type_byte_order instead of gdbarch_byte_order.
1871         * valarith.c (scalar_binop):
1872         (value_bit_index):
1873         Use type_byte_order instead of gdbarch_byte_order.
1874         * valops.c (value_cast):
1875         Use type_byte_order instead of gdbarch_byte_order.
1876         * valprint.c (generic_emit_char):
1877         (generic_printstr):
1878         (val_print_string):
1879         Use type_byte_order instead of gdbarch_byte_order.
1880         * value.c (unpack_long):
1881         (unpack_bits_as_long):
1882         (unpack_value_bitfield):
1883         (modify_field):
1884         (pack_long):
1885         (pack_unsigned_long):
1886         Use type_byte_order instead of gdbarch_byte_order.
1887         * findvar.c (unsigned_pointer_to_address):
1888         (signed_pointer_to_address):
1889         (unsigned_address_to_pointer):
1890         (address_to_signed_pointer):
1891         (default_read_var_value):
1892         (default_value_from_register):
1893         Use type_byte_order instead of gdbarch_byte_order.
1894         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1895         Use type_byte_order instead of gdbarch_byte_order.
1896         * riscv-tdep.c (riscv_print_one_register_info):
1897         Use type_byte_order instead of gdbarch_byte_order.
1898
1899 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1900
1901         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1902         (current_ui_gdb_stdin_ptr): Likewise.
1903         (current_ui_gdb_stderr_ptr): Likewise.
1904         (current_ui_gdb_stdlog_ptr): Likewise.
1905         (current_ui_current_uiout_ptr): Likewise.
1906         (gen_ret_current_ui_field_ptr): Remove.
1907
1908 2019-11-21  Tom de Vries  <tdevries@suse.de>
1909
1910         PR gdb/24956
1911         * cli/cli-script.c (execute_control_command): Only switch to
1912         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1913
1914 2019-11-19  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1917         Now static.  Change type of "name".
1918         (tui_set_win_height_command): Don't copy "arg".
1919         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1920         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1921
1922 2019-11-19  Ali Tamur <tamur@google.com>
1923
1924         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1925         "if (attr != nullptr)".
1926         (dwarf2_find_base_address): Likewise.
1927         (dwarf2_build_include_psymtabs): Likewise.
1928         (read_cutu_die_from_dwo): Likewise.
1929         (read_func_scope): Likewise.
1930         (read_call_site_scope): Likewise.
1931         (dwarf2_get_pc_bounds): Likewise.
1932         (dwarf2_record_block_ranges): Likewise.
1933         (dwarf2_add_field): Likewise.
1934         (dwarf2_add_member_fn): Likewise.
1935         (read_structure_type): Likewise.
1936         (read_enumeration_type): Likewise.
1937         (read_array_type): Likewise.
1938         (read_array_order): Likewise.
1939         (read_set_type): Likewise.
1940         (read_common_block): Likewise.
1941         (read_tag_reference_type): Likewise.
1942         (read_tag_string_type): Likewise.
1943         (read_subroutine_type): Likewise.
1944         (read_base_type): Likewise.
1945         (read_subrange_type): Likewise.
1946         (new_symbol): Likewise.
1947         (prepare_one_comp_unit): Likewise.
1948
1949 2019-11-19  Tom Tromey  <tromey@adacore.com>
1950
1951         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1952         result in error when DebugActiveProcess fails.
1953
1954 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1955             Pedro Alves  <palves@redhat.com>
1956
1957         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1958         * target.c (target_stack::push): Call 'unpush' if there's a
1959         target on top of the stack.
1960
1961 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1962
1963         * python/py-block.c (blpy_dealloc): Call tp_free.
1964         (blpy_block_syms_dealloc): Likewise.
1965         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1966         * python/py-inferior.c (infpy_dealloc): Likewise.
1967         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1968         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1969         * python/py-symbol.c (sympy_dealloc): Likewise.
1970         * python/py-symtab.c (stpy_dealloc): Likewise.
1971         * python/py-type.c (typy_iterator_dealloc): Likewise.
1972
1973 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1974
1975         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1976         constructor instead of using a class initializer.
1977
1978 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1979
1980         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1981         * configure: Regenerate.
1982         * configure.ac: Don't source common.host.
1983         * gdbsupport/common.host: Remove.
1984         * gdbsupport/mingw-strerror.c: Remove.
1985         * gdbsupport/posix-strerror.c: Rename to...
1986         * gdbsupport/safe-strerror.c: ...this.
1987
1988 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1989
1990         * maint.c (scoped_command_stats::print_time): Use localtime_r
1991         instead of localtime (provided through gnulib if necessary).
1992         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1993         of ctime.
1994
1995 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1996
1997         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1998         avoid compile errors.
1999
2000 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2001
2002         * config.in: Regenerate.
2003         * configure: Regenerate.
2004         * gdbsupport/common.m4: No longer check for strerror_r.
2005         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2006         POSIX version of strerror_r, now that gnulib provides it if
2007         necessary.
2008
2009 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2010
2011         * README (`configure' options): Update.
2012
2013 2019-11-14  Tom Tromey  <tromey@adacore.com>
2014
2015         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2016         expected type for the RHS if the LHS is a convenience variable.
2017
2018 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2019
2020         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2021         Provide explicit default and copy constructor.
2022
2023 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2024
2025         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2026         only call Py_INCREF (newbp) in the bppy_pending_object case.
2027
2028 2019-11-13  Tom Tromey  <tromey@adacore.com>
2029
2030         PR build/25182:
2031         * psympriv.h (partial_symbol): Remove static assert.
2032         * symtab.h (general_symbol_info, symbol): Remove static assert.
2033
2034 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2035
2036         * gdbsupport/format.c (format_pieces::format_pieces): Support
2037         printf 'z' size modifier.
2038         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2039         * printcmd.c (ui_printf):  Handle size_t_arg.
2040         * ui-out.c (ui_out::vmessage): Likewise.
2041         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2042         function.
2043         (run_tests): Call test_format_int_sizes.
2044
2045 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2046
2047         * ada-exp.y (write_ambiguous_var): Update.
2048         * buildsym.c (add_symbol_to_list): Update.
2049         * dwarf2read.c (read_variable): Update.
2050         (new_symbol): Update.
2051         * jit.c (finalize_symtab): Update.
2052         * language.c (language_alloc_type_symbol): Update.
2053         * symtab.c (fixup_symbol_section): Update.
2054         (initialize_objfile_symbol_1): Move code to...
2055         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2056         (allocate_symbol): Update.
2057         (allocate_template_symbol): Update.
2058         (get_symbol_address): Update.
2059         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2060         of having as a field, and add a constructor.
2061         (SYMBOL_VALUE): Update.
2062         (SYMBOL_VALUE_ADDRESS): Update.
2063         (SET_SYMBOL_VALUE_ADDRESS): Update.
2064         (SYMBOL_VALUE_BYTES): Update.
2065         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2066         (SYMBOL_BLOCK_VALUE): Update.
2067         (SYMBOL_VALUE_CHAIN): Update.
2068         (SYMBOL_LANGUAGE): Update.
2069         (SYMBOL_SECTION): Update.
2070         (SYMBOL_OBJ_SECTION): Update.
2071         (SYMBOL_SET_LANGUAGE): Update.
2072         (SYMBOL_SET_LINKAGE_NAME): Update.
2073         (SYMBOL_SET_NAMES): Update.
2074         (SYMBOL_NATURAL_NAME): Update.
2075         (SYMBOL_LINKAGE_NAME): Update.
2076         (SYMBOL_DEMANGLED_NAME): Update.
2077         (SYMBOL_SEARCH_NAME): Update.
2078         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2079         (struct symbol): Update.
2080         (struct template_symbol): Update.
2081         (struct rust_vtable_symbol): Update.
2082         * xcoffread.c (SYMBOL_DUP): Update.
2083
2084 2019-11-12  Tom Tromey  <tom@tromey.com>
2085
2086         * tui/tui-layout.c (show_layout): Set current_layout.
2087         (show_source_disasm_command, show_data)
2088         (show_source_or_disasm_and_command): Don't set current_layout.
2089
2090 2019-11-12  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2093
2094 2019-11-12  Tom Tromey  <tom@tromey.com>
2095
2096         * tui/tui-win.c (resize_message): New global.
2097         (show_tui_resize_message): New function.
2098         (tui_async_resize_screen): Print message if requested.
2099         (_initialize_tui_win): Add tui-resize-message setting.
2100         * NEWS: Add entry for new commands.
2101
2102 2019-11-11  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2105         functions.
2106
2107 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2108
2109         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2110
2111 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2112
2113         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2114         function.
2115         * python/python-internal.h (gdbpy_lookup_static_symbols):
2116         Declare new function.
2117         * python/python.c (python_GdbMethods): Add
2118         gdb.lookup_static_symbols method.
2119         * NEWS: Mention gdb.lookup_static_symbols.
2120
2121 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2122
2123         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2124         static block of current object file first.  Also fix typo in
2125         header comment.
2126
2127 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2128
2129         * stack.c (set_last_displayed_sal): Delete.
2130         (last_displayed_sal_valid): Delete.
2131         (last_displayed_pspace): Delete.
2132         (last_displayed_addr): Delete.
2133         (last_displayed_symtab): Delete.
2134         (last_displayed_line): Delete.
2135         (class last_displayed_symtab_info_type): New.
2136         (last_displayed_symtab_info): New static global variable.
2137         (print_frame_info): Call methods on last_displayed_symtab_info.
2138         (clear_last_displayed_sal): Update header comment, and make use of
2139         last_displayed_symtab_info.
2140         (last_displayed_sal_is_valid): Likewise.
2141         (get_last_displayed_pspace): Likewise.
2142         (get_last_displayed_addr): Likewise.
2143         (get_last_displayed_symtab): Likewise.
2144         (get_last_displayed_line): Likewise.
2145         (get_last_displayed_sal): Likewise.
2146         * stack.h (clear_last_displayed_sal): Update header comment.
2147         (last_displayed_sal_is_valid): Likewise.
2148         (get_last_displayed_pspace): Likewise.
2149         (get_last_displayed_addr): Likewise.
2150         (get_last_displayed_symtab): Likewise.
2151         (get_last_displayed_line): Likewise.
2152         (get_last_displayed_sal): Likewise.
2153
2154 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2155
2156         * stack.c (frame_show_address): Convert return type to bool.
2157         * stack.h (frame_show_address): Likewise, and update header
2158         comment.
2159
2160 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2161
2162         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2163         * unittests/vec-utils-selftests.c: New file.
2164         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2165
2166 2019-11-10  Tom Tromey  <tom@tromey.com>
2167
2168         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2169         (tui_highlight_win): Likewise.
2170         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2171         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2172         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2173         Don't set can_highlight.
2174
2175 2019-11-10  Tom Tromey  <tom@tromey.com>
2176
2177         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2178         Remove unused declaration.
2179
2180 2019-11-08  Tom Tromey  <tromey@adacore.com>
2181
2182         * top.c (read_command_file): Update.
2183         (command_line_input): Make return type const.
2184         * python/py-gdb-readline.c: Update.
2185         * linespec.c (decode_line_2): Update.
2186         * defs.h (command_line_input): Make return type const.
2187         * cli/cli-script.c (read_next_line): Make return type const.
2188         * ada-lang.c (get_selections): Update.
2189
2190 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2191
2192         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2193         * mi/mi-main.c (output_cores): Likewise.
2194         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2195         (linux_xfer_osdata_modules): Likewise.
2196         * remote.c (register_remote_support_xml): Likewise.
2197         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2198         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2199
2200 2019-11-06  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-interp.c: Don't include readline.h.
2203         * tui/tui-hooks.c: Don't include readline.h.
2204         * symmisc.c: Include tilde.h, not readline.h.
2205         * symfile.c: Include tilde.h, not readline.h.
2206         * source.c: Include tilde.h, not readline.h.
2207         * solib.c: Include tilde.h, not readline.h.
2208         * psymtab.c: Include tilde.h, not readline.h.
2209         * exec.c: Include tilde.h, not readline.h.
2210         * corelow.c: Include tilde.h, not readline.h.
2211         * cli/cli-dump.c: Include tilde.h, not readline.h.
2212         * cli/cli-cmds.c: Don't include readline.h.
2213
2214 2019-11-05  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2217         (tui_disassemble): Set addr_size.
2218         (tui_disasm_window::set_contents): Use addr_size.
2219
2220 2019-11-05  Tom Tromey  <tom@tromey.com>
2221
2222         * rust-lang.c (rust_language_defn): Update.
2223         * python/py-value.c (valpy_string): Call c_get_string.
2224         * p-lang.c (pascal_language_defn): Update.
2225         * opencl-lang.c (opencl_language_defn): Update.
2226         * objc-lang.c (objc_language_defn): Update.
2227         * m2-lang.c (m2_language_defn): Update.
2228         * language.c (unknown_language_defn, auto_language_defn): Update.
2229         (default_get_string): Remove.
2230         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2231         * go-lang.c (go_language_defn): Update.
2232         * f-lang.c (f_language_defn): Update.
2233         * d-lang.c (d_language_defn): Update.
2234         * c-lang.c (c_language_defn, cplus_language_defn)
2235         (asm_language_defn, minimal_language_defn): Update.
2236         * ada-lang.c (ada_language_defn): Update.
2237         * language.h (struct language_defn) <la_get_string>: Remove.
2238         (LA_GET_STRING): Remove.
2239         (default_get_string): Don't declare.
2240
2241 2019-11-05  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-source.h (struct tui_source_window): Inline
2244         constructor.  Remove destructor.
2245         <style_changed, m_observable>: Move to superclass.
2246         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2247         (struct tui_source_window_base): Move private members to end.
2248         <style_changed, m_observable>: Move from tui_source_window.
2249         * tui/tui-winsource.c (tui_copy_source_line): Move from
2250         tui-source.c.  Rename from copy_source_line.  Add special handling
2251         for negative line number.
2252         (tui_source_window_base::style_changed): Move from
2253         tui_source_window.
2254         (tui_source_window_base): Register observer.
2255         (~tui_source_window_base): New.
2256         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2257         rename.
2258         (tui_source_window::set_contents): Use tui_copy_source_line.
2259         (tui_source_window::tui_source_window): Move to tui-source.h.
2260         (tui_source_window::~tui_source_window): Remove.
2261         (tui_source_window::style_changed): Move to superclass.
2262         * tui/tui-disasm.c (tui_disassemble): Create string file with
2263         styling, when possible.  Add "addr_size" parameter.
2264         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2265         Don't compute maximum size.
2266         (len_without_escapes): New function
2267
2268 2019-11-05  Tom Tromey  <tom@tromey.com>
2269
2270         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2271         std::string.
2272         * tui/tui-winsource.c (tui_show_source_line): Update.
2273         * tui/tui-source.c (tui_source_window::set_contents): Update.
2274         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2275
2276 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2277
2278         * symtab.h (gdb_static_assert): Put && operator at the beginning
2279         of the line instead of the end.
2280
2281 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2282
2283         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2284         and sizeof (symbol).
2285         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2286
2287 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2288
2289         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2290         * configure.host: Mark *-*-solaris2.10* obsolete.
2291         * configure.tgt: Mark Solaris < 11 obsolete.
2292         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2293         Update target triplet.
2294
2295 2019-11-01  Tom Tromey  <tromey@adacore.com>
2296
2297         * utils.c (print_sys_errmsg): Simplify.
2298
2299 2019-11-01  Tom Tromey  <tromey@adacore.com>
2300
2301         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2302
2303 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2304
2305         * configure: Regenerate.
2306         * configure.ac: Remove check for strerror_r.
2307         * gdbsupport/common.m4: Check for strerror_r.
2308
2309 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2310
2311         PR gdb/25124
2312
2313         * arm-tdep.c (arm_per_objfile): Rename to ...
2314         (arm_per_bfd): ... this.
2315         (arm_objfile_data_key): Rename to ...
2316         (arm_bfd_data_key): ... this.
2317         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2318         data.
2319         (arm_record_special_symbol): Likewise.
2320
2321 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2322
2323         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2324         end.
2325         * c-typeprint.c (c_print_typedef): Likewise.
2326         * f-typeprint.c (f_print_typedef): Likewise.
2327         * m2-typeprint.c (m2_print_typedef): Likewise.
2328         * p-typeprint.c (pascal_print_typedef): Likewise.
2329         * rust-lang.c (rust_print_typedef): Likewise.
2330         * symtab.c (print_symbol_info): Print a newline after calling
2331         typedef_print.
2332
2333 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2334
2335         * symtab.c (info_module_cmdlist): New variable.
2336         (info_module_command): New function.
2337         (search_module_symbols): New function.
2338         (info_module_subcommand): New function.
2339         (struct info_modules_var_func_options): New struct.
2340         (info_modules_var_func_options_defs): New variable.
2341         (make_info_modules_var_func_options_def_group): New function.
2342         (info_module_functions_command): New function.
2343         (info_module_variables_command): New function.
2344         (info_module_var_func_command_completer): New function.
2345         (_initialize_symtab): Register new 'info module functions' and
2346         'info module variables' commands.
2347         * symtab.h (typedef symbol_search_in_module): New typedef.
2348         (search_module_symbols): Declare new function.
2349         * NEWS: Mention new commands.
2350
2351 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2352
2353         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2354         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2355         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2356         MODULES_DOMAIN.
2357         (scan_partial_symbols): Only create partial module symbols for non
2358         declarations.
2359         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2360         and MODULES_DOMAIN.
2361         * symtab.c (search_domain_name): Likewise.
2362         (search_symbols): Likewise.
2363         (print_symbol_info): Likewise.
2364         (symtab_symbol_info): Likewise.
2365         (info_modules_command): New function.
2366         (_initialize_symtab): Register 'info modules' command.
2367         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2368         * NEWS: Mention new 'info modules' command.
2369
2370 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2371
2372         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2373         and $_gdb_maint_setting_str.
2374
2375 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2376
2377         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2378         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2379         (str_value_from_setting, gdb_setting_str_internal_fn)
2380         (gdb_maint_setting_str_internal_fn): New functions.
2381         (_initialize_cli_cmds): Define the new convenience functions.
2382         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2383         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2384
2385 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2386
2387         * agent.c (set_can_use_agent): When the setting is turned on,
2388         look up agent symbols if we don't have them yet.
2389         (agent_new_objfile): Don't look up agent symbols when the agent
2390         setting is off.
2391
2392 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2393
2394         * config.in: Regenerate.
2395
2396 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2397
2398         * configure: Regenerate.
2399         * configure.ac: Check for strerror_r.
2400         * gdbsupport/common-utils.h (safe_strerror): Change return value
2401         to const char * and document that this function is now threadsafe.
2402         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2403         thread_local and call strerror_r, if available.
2404         * utils.c (perror_string): Update.
2405         (print_sys_errmsg): Update.
2406
2407 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2408
2409         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2410         objfile_key.
2411         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2412         objfile to fetch per-bfd data.
2413         (arm_find_exidx_entry): Likewise.
2414
2415 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2416
2417         * gdbsupport/agent.c (debug_agent): Change type to bool.
2418         (use_agent): Likewise.
2419         (all_agent_symbols_look_up): Likewise.
2420         (agent_loaded_p): Change return value to bool.
2421         (agent_look_up_symbols): Update.
2422         (agent_capability_check): Change return value to bool.
2423         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2424         (debug_agent): Change type to bool.
2425         (use_agent): Likewise.
2426         (agent_capability_check): Change return value to bool.
2427
2428 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2429
2430         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2431         (build_minimal_symbol_hash_tables): Code to clear the table moved
2432         to clear_minimal_symbol_hash_tables.
2433         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2434         when needed.
2435
2436 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2437
2438         * infcmd.c: Remove includes.
2439         * infrun.c: Remove includes.
2440
2441 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2442
2443         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2444         (grow_vect): Remove declaration.
2445         (ada_type_of_array): Remove declaration.
2446         (ada_update_initial_language): Remove declaration.
2447         (ada_fold_name): Remove declaration.
2448         (ada_fill_in_ada_prototype): Remove declaration.
2449         (user_select_syms): Remove declaration.
2450         (get_selections): Remove declaration.
2451         (ada_tag_type): Remove declaration.
2452         (ada_value_tag): Remove declaration.
2453         (ada_is_others_clause): Remove declaration.
2454         (ada_in_variant): Remove declaration.
2455         (ada_value_struct_elt): Remove declaration.
2456         (ada_attribute_name): Remove declaration.
2457         (ada_system_address_type): Remove declaration.
2458         * ada-lang.c (ada_watch_location_expression): Make static.
2459         (GROW_VECT): Move here from ada-lang.h.
2460         (grow_vect): Make static.
2461         (ada_update_initial_language): Make static.
2462         (ada_fold_name): Make static.
2463         (ada_type_of_array): Make static.
2464         (encoded_ordered_before): Move up.
2465         (sort_choices): Move up.
2466         (print_signatures): Move up.
2467         (ada_print_symbol_signature): Move up.
2468         (get_selections): Move up and make static.
2469         (user_select_syms): Move up and make static.
2470         (ada_value_struct_elt): Move up and make static.
2471         (ada_tag_type): Make static.
2472         (ada_value_tag): Make static.
2473         (ada_is_others_clause): Make static.
2474         (ada_in_variant): Make static.
2475         (ada_attribute_name): Make static.
2476
2477 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2478
2479         * ada-lang.c: Remove includes.
2480         * ada-typeprint.c: Remove includes.
2481         * ada-valprint.c: Remove includes.
2482
2483 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2484
2485         * addrmap.c: Add static assertions of type size, moved from
2486         _initialize_addrmap.
2487         (_initialize_addrmap): Remove.
2488
2489 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2490
2491         * coffread.c (record_minimal_symbol): Update.
2492         (process_coff_symbol): Update.
2493         * dbxread.c (read_dbx_symtab): Update.
2494         * dwarf2read.c (add_partial_symbol): Update.
2495         (fixup_go_packaging): Update.
2496         (load_partial_dies): Update.
2497         (new_symbol): Update.
2498         * elfread.c (record_minimal_symbol): Change signature to use
2499         gdb::string_view instead of name+len.
2500         (elf_symtab_read): Update.
2501         (elf_rel_plt_read): Update.
2502         * mdebugread.c (parse_partial_symbols): Update.
2503         (handle_psymbol_enumerators): Update.
2504         (new_symbol): Update.
2505         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2506         to use gdb::string_view instead of name+len.
2507         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2508         * psympriv.h (add_psymbol_to_list): Likewise.
2509         * psymtab.c (add_psymbol_to_bcache): Likewise.
2510         (add_psymbol_to_list): Likewise.
2511         * stabsread.c (define_symbol): Update.
2512         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2513         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2514         (symbol_set_names): Likewise.
2515         * xcoffread.c (scan_xcoff_symtab): Update.
2516
2517 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2518
2519         * symtab.h (symbol_set_names): Document that copy_name must be
2520         set to true for non-nullterminated strings.
2521         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2522         linkage_name if the entry was not found and we need to demangle.
2523
2524 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2525
2526         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2527         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2528         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2529         * gdbsupport/gdb_binary_search.h: New file.
2530
2531 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2532
2533         * NEWS: Mention new --with-system-gdbinit-dir option.
2534         * config.in: Regenerate.
2535         * configure: Regenerate.
2536         * configure.ac: Add new option --with-system-gdbinit-dir.
2537         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2538         for a ".gdb" suffix.
2539         * main.c (get_init_files): Change system_gdbinit argument to
2540         a vector and return the files in SYSTEM_GDBINIT_DIR in
2541         addition to SYSTEM_GDBINIT.
2542         (captured_main_1): Update.
2543         (print_gdb_help): Update.
2544         * top.c (print_gdb_configuration): Also print the value of
2545         SYSTEM_GDBINIT_DIR.
2546
2547 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2548
2549         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2550         that takes gdb::string_view arguments.
2551
2552 2019-10-26  Tom de Vries  <tdevries@suse.de>
2553
2554         * aarch64-linux-tdep.c: Fix typos in comments.
2555         * aarch64-tdep.c: Same.
2556         * ada-lang.c: Same.
2557         * amd64-nat.c: Same.
2558         * arc-tdep.c: Same.
2559         * arch/aarch64-insn.c: Same.
2560         * block.c: Same.
2561         * breakpoint.h: Same.
2562         * btrace.h: Same.
2563         * c-varobj.c: Same.
2564         * cli/cli-decode.c: Same.
2565         * cli/cli-script.c: Same.
2566         * cli/cli-utils.h: Same.
2567         * coff-pe-read.c: Same.
2568         * coffread.c: Same.
2569         * compile/compile-cplus-symbols.c: Same.
2570         * compile/compile-object-run.c: Same.
2571         * completer.c: Same.
2572         * corelow.c: Same.
2573         * cp-support.c: Same.
2574         * demangle.c: Same.
2575         * dwarf-index-write.c: Same.
2576         * dwarf2-frame.c: Same.
2577         * dwarf2-frame.h: Same.
2578         * eval.c: Same.
2579         * frame-base.h: Same.
2580         * frame.h: Same.
2581         * gdbcmd.h: Same.
2582         * gdbtypes.h: Same.
2583         * gnu-nat.c: Same.
2584         * guile/scm-objfile.c: Same.
2585         * i386-tdep.c: Same.
2586         * i386-tdep.h: Same.
2587         * infcall.c: Same.
2588         * infcall.h: Same.
2589         * linux-nat.c: Same.
2590         * m68k-tdep.c: Same.
2591         * macroexp.c: Same.
2592         * memattr.c: Same.
2593         * mi/mi-cmd-disas.c: Same.
2594         * mi/mi-getopt.h: Same.
2595         * mi/mi-main.c: Same.
2596         * minsyms.c: Same.
2597         * nat/aarch64-sve-linux-sigcontext.h: Same.
2598         * objfiles.h: Same.
2599         * ppc-linux-nat.c: Same.
2600         * ppc-linux-tdep.c: Same.
2601         * ppc-tdep.h: Same.
2602         * progspace.h: Same.
2603         * prologue-value.h: Same.
2604         * python/py-evtregistry.c: Same.
2605         * python/py-instruction.h: Same.
2606         * record-btrace.c: Same.
2607         * record-full.c: Same.
2608         * remote.c: Same.
2609         * rs6000-tdep.c: Same.
2610         * ser-tcp.c: Same.
2611         * sol-thread.c: Same.
2612         * sparc-sol2-tdep.c: Same.
2613         * sparc64-tdep.c: Same.
2614         * stabsread.c: Same.
2615         * symfile.c: Same.
2616         * symtab.h: Same.
2617         * target.c: Same.
2618         * tracepoint.c: Same.
2619         * tui/tui-data.h: Same.
2620         * tui/tui-io.c: Same.
2621         * tui/tui-win.c: Same.
2622         * tui/tui.c: Same.
2623         * unittests/rsp-low-selftests.c: Same.
2624         * user-regs.h: Same.
2625         * utils.c: Same.
2626         * utils.h: Same.
2627         * valarith.c: Same.
2628         * valops.c: Same.
2629         * valprint.c: Same.
2630         * valprint.h: Same.
2631         * value.c: Same.
2632         * value.h: Same.
2633         * varobj.c: Same.
2634         * x86-nat.h: Same.
2635         * xtensa-tdep.c: Same.
2636
2637 2019-10-25  Ali Tamur <tamur@google.com>
2638
2639         * charset.c (find_charset_names): Reflect API change.
2640
2641 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2642
2643         * symtab.c (struct demangled_name_entry): Change demangled name
2644         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2645         part of the struct anymore.
2646         (symbol_set_names): No longer obstack allocate + copy the demangled
2647         name, just store the allocated name from bfd.
2648
2649 2019-10-25  Tom Tromey  <tromey@adacore.com>
2650
2651         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2652         (bsearch_cie_cmp, add_cie): Remove.
2653         (find_cie): Reimplement.
2654         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2655         (dwarf2_build_frame_info): Update.
2656
2657 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2658
2659         PR gdb/25126
2660         * symfile.c (reread_symbols): Call forget_cached_source_info to
2661         clear the stale source cache.
2662
2663 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2664
2665         * configure: Regenerate.
2666         * configure.ac: Remove code that sets python_has_threads.
2667
2668 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2669
2670         * config.in: Regenerate.
2671         * configure: Regenerate.
2672         * configure.ac: Remove the code that uses sed to get the python
2673         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2674
2675 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2676
2677         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2678         error paths.
2679
2680 2019-10-23  Tom Tromey  <tom@tromey.com>
2681
2682         * arc-tdep.c: Remove ".." from include.
2683         * frv-tdep.c: Remove ".." from include.
2684         * lm32-tdep.c: Remove ".." from include.
2685         * microblaze-tdep.c: Remove ".." from include.
2686         * or1k-tdep.h: Remove ".." from include.
2687         * s12z-tdep.c: Remove ".." from include.
2688         * Makefile.in (OPCODES_CFLAGS): Add comment.
2689         (TOP_CFLAGS): New variable.
2690         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2691
2692 2019-10-23  Tom Tromey  <tom@tromey.com>
2693
2694         * Makefile.in (READLINE_DIR): Update.
2695
2696 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2697
2698         * infcall.c (call_function_by_hand_dummy): Fix the function
2699         comment.  And extract out a code section into...
2700         (reserve_stack_space): ...this new function.
2701
2702 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2703
2704         * infcall.c (value_arg_coerce): Remove an unused parameter.
2705         (call_function_by_hand_dummy): Update the call to
2706         'value_arg_coerce'.
2707
2708 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2709
2710         * infcall.c (call_function_by_hand_dummy): Refactor.
2711
2712 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2713
2714         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2715
2716 2019-10-23  Tom Tromey  <tom@tromey.com>
2717
2718         * configure: Rebuild.
2719         * configure.ac: Don't check for sigprocmask.
2720         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2721
2722 2019-10-23  Tom Tromey  <tom@tromey.com>
2723
2724         * configure: Rebuild.
2725         * acinclude.m4: Use m4_include, not sinclude.
2726
2727 2019-10-23  Tom de Vries  <tdevries@suse.de>
2728
2729         PR breakpoints/24687
2730         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2731
2732 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2733
2734         * symtab.c (struct demangled_name_entry) <language>: Change from
2735         bitfield to regular variable.
2736
2737 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2738
2739         * symtab.c (struct demangled_name_entry): Add a constructor.
2740         (free_demangled_name_entry): New function to call the destructor
2741         for demangled_name_entry.
2742         (create_demangled_names_hash): Pass free_demangled_name_entry to
2743         htab_create_alloc.
2744         (symbol_set_names): Call placement new for demangled_name_entry.
2745         * utils.c: No longer include xxhash.h here, now that fast_hash
2746         is inlined in the header.
2747         * utils.h: Instead, include it here.
2748
2749 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2750
2751         * Makefile.in: Link with libxxhash.
2752         * config.in: Regenerate.
2753         * configure: Regenerate.
2754         * configure.ac: Search for libxxhash.
2755         * utils.c (fast_hash): Use xxhash if present.
2756
2757 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2758
2759         * utils.h (fast_hash): New function.
2760         * symtab.c (hash_demangled_name_entry): Call new function
2761         fast_hash.
2762
2763 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2764
2765         * symtab.c (struct demangled_name_entry): Change type of mangled
2766         to gdb::string_view. Also adds a constructor that takes the
2767         mangled name.
2768         (hash_demangled_name_entry): Update.
2769         (eq_demangled_name_entry): Update.
2770         (free_demangled_name_entry): New function to call the destructor
2771         now that this is not a POD anymore.
2772         (create_demangled_names_hash): Pass free_demangled_name_entry to
2773         htab_create_alloc.
2774         (symbol_set_names): Update.
2775
2776 2019-10-21  Ali Tamur  <tamu@google.com>
2777
2778         * dwarf2read.c (dir_index): Change type.
2779         (file_name_index): Likewise.
2780         (line_header::include_dir_at): Change comment and implementation on
2781         whether it is DWARF 5.
2782         (line_header::is_valid_file_index): New function.
2783         (line_header::file_name_at): Change comment and implementation on
2784         whether it is DWARF 5.
2785         (line_header::file_names): Change to private field renamed as
2786         m_file_names and introduce a new accessor method.
2787         (line_header::file_names_size): New method.
2788         (line_header::include_dirs): Change to private field and rename as
2789         m_include_dirs.
2790         (dw2_get_file_names_reader): Define local var at a smaller scope and
2791         reflect API change.
2792         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2793         (process_structure_scope): Likewise.
2794         (line_header::add_include_dir): Change message and reflect renaming.
2795         (line_header::add_file_name): Likewise.
2796         (read_formatted_entries): Handle DW_FORM_data16.
2797         (dwarf_decode_line_header): Fix line header length calculation.
2798         (psymtab_include_file_name): Change comment and API.
2799         (lnp_state_machine::m_file): Update comment and reflect type change.
2800         (lnp_state_machine::record_line): Reflect type change.
2801         (dwarf_decode_lines): Reflect API change.
2802         (file_file_name): Likewise.
2803         (file_full_name): Likewise.
2804
2805 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2806
2807         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2808
2809 2019-10-21  Tom Tromey  <tom@tromey.com>
2810
2811         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2812
2813 2019-10-21  Tom Tromey  <tom@tromey.com>
2814
2815         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2816         NM_H.   Use AC_CONFIG_LINKS.
2817         * configure: Rebuild.
2818         * Makefile.in (NM_H): New variable.
2819         (generated_files): Add NM_H.  Remove gcore.
2820         (nm.h, stamp-nmh): New targets.
2821
2822 2019-10-20  Tom Tromey  <tom@tromey.com>
2823
2824         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2825         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2826         obsolete comment.
2827         (put_objfile_before): Now static.
2828
2829 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2830
2831         * gdbsupport/common-utils.h (startswith): Change return type to
2832         bool.
2833
2834 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2835
2836         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2837         * breakpoint.c (bp_locations_compare): Rename to...
2838         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2839         (update_global_location_list): Use std::sort instead of qsort.
2840         * buildsym.c (compare_line_numbers): Rename to...
2841         (lte_is_less_than): ...this, and change to std::sort semantics.
2842         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2843         instead of qsort.
2844         * disasm.c (compare_lines): Rename to...
2845         (line_is_less_than): ...this, and change to std::sort semantics.
2846         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2847         of qsort.
2848         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2849         (fde_is_less_than): ...this, and change to std::sort semantics.
2850         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2851         * mdebugread.c (compare_blocks):
2852         (block_is_less_than): ...this, and change to std::sort semantics.
2853         (sort_blocks): Call std::sort instead of qsort.
2854         * objfiles.c (qsort_cmp): Rename to...
2855         (sort_cmp): ...this, and change to std::sort semantics.
2856         (update_section_map): Call std::sort instead of qsort.
2857         * remote.c (compare_pnums): Remove.
2858         (map_regcache_remote_table): Call std::sort instead of qsort.
2859         * utils.c (compare_positive_ints): Remove.
2860         * utils.h (compare_positive_ints): Remove.
2861         * xcoffread.c (compare_lte): Remove.
2862         (arrange_linetable): Call std::sort instead of qsort.
2863
2864 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2865
2866         * symfile.c (init_entry_point_info): Fix typo.
2867         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2868
2869 2019-10-18  Tom de Vries  <tdevries@suse.de>
2870
2871         * aarch64-tdep.c: Fix typos in comments.
2872         * ada-lang.c: Same.
2873         * ada-tasks.c: Same.
2874         * alpha-tdep.c: Same.
2875         * alpha-tdep.h: Same.
2876         * amd64-nat.c: Same.
2877         * amd64-windows-tdep.c: Same.
2878         * arc-tdep.c: Same.
2879         * arc-tdep.h: Same.
2880         * arch-utils.c: Same.
2881         * arm-nbsd-tdep.c: Same.
2882         * arm-tdep.c: Same.
2883         * ax-gdb.c: Same.
2884         * blockframe.c: Same.
2885         * btrace.c: Same.
2886         * c-varobj.c: Same.
2887         * coff-pe-read.c: Same.
2888         * coffread.c: Same.
2889         * cris-tdep.c: Same.
2890         * darwin-nat.c: Same.
2891         * dbxread.c: Same.
2892         * dcache.c: Same.
2893         * disasm.c: Same.
2894         * dtrace-probe.c: Same.
2895         * dwarf-index-write.c: Same.
2896         * dwarf2-frame-tailcall.c: Same.
2897         * dwarf2-frame.c: Same.
2898         * dwarf2read.c: Same.
2899         * eval.c: Same.
2900         * exceptions.c: Same.
2901         * fbsd-tdep.c: Same.
2902         * findvar.c: Same.
2903         * frame.c: Same.
2904         * frv-tdep.c: Same.
2905         * gnu-v3-abi.c: Same.
2906         * go32-nat.c: Same.
2907         * h8300-tdep.c: Same.
2908         * hppa-tdep.c: Same.
2909         * i386-linux-tdep.c: Same.
2910         * i386-tdep.c: Same.
2911         * ia64-libunwind-tdep.c: Same.
2912         * ia64-tdep.c: Same.
2913         * infcmd.c: Same.
2914         * infrun.c: Same.
2915         * linespec.c: Same.
2916         * linux-nat.c: Same.
2917         * linux-thread-db.c: Same.
2918         * machoread.c: Same.
2919         * mdebugread.c: Same.
2920         * mep-tdep.c: Same.
2921         * mn10300-tdep.c: Same.
2922         * namespace.c: Same.
2923         * objfiles.c: Same.
2924         * opencl-lang.c: Same.
2925         * or1k-tdep.c: Same.
2926         * osabi.c: Same.
2927         * ppc-linux-nat.c: Same.
2928         * ppc-linux-tdep.c: Same.
2929         * ppc-sysv-tdep.c: Same.
2930         * printcmd.c: Same.
2931         * procfs.c: Same.
2932         * record-btrace.c: Same.
2933         * record-full.c: Same.
2934         * remote-fileio.c: Same.
2935         * remote.c: Same.
2936         * rs6000-tdep.c: Same.
2937         * s12z-tdep.c: Same.
2938         * score-tdep.c: Same.
2939         * ser-base.c: Same.
2940         * ser-go32.c: Same.
2941         * skip.c: Same.
2942         * sol-thread.c: Same.
2943         * solib-svr4.c: Same.
2944         * solib.c: Same.
2945         * source.c: Same.
2946         * sparc-nat.c: Same.
2947         * sparc-sol2-tdep.c: Same.
2948         * sparc-tdep.c: Same.
2949         * sparc64-tdep.c: Same.
2950         * stabsread.c: Same.
2951         * stack.c: Same.
2952         * symfile.c: Same.
2953         * symtab.c: Same.
2954         * target-descriptions.c: Same.
2955         * target-float.c: Same.
2956         * thread.c: Same.
2957         * utils.c: Same.
2958         * valops.c: Same.
2959         * valprint.c: Same.
2960         * value.c: Same.
2961         * varobj.c: Same.
2962         * windows-nat.c: Same.
2963         * xcoffread.c: Same.
2964         * xstormy16-tdep.c: Same.
2965         * xtensa-tdep.c: Same.
2966
2967 2019-10-17  Tom Tromey  <tromey@adacore.com>
2968
2969         * configure: Rebuild.
2970         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2971         in AC_CONFIG_FILES invocation.
2972         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2973         new-style config.status invocation.
2974
2975 2019-10-17  Tom de Vries  <tdevries@suse.de>
2976
2977         * arm-nbsd-nat.c: Fix typos in comments.
2978         * arm-tdep.c: Same.
2979         * darwin-nat-info.c: Same.
2980         * dwarf2read.c: Same.
2981         * elfread.c: Same.
2982         * event-top.c: Same.
2983         * findvar.c: Same.
2984         * gdbtypes.c: Same.
2985         * hppa-tdep.c: Same.
2986         * i386-tdep.c: Same.
2987         * jit.c: Same.
2988         * main.c: Same.
2989         * mdebugread.c: Same.
2990         * moxie-tdep.c: Same.
2991         * nto-procfs.c: Same.
2992         * osabi.c: Same.
2993         * ppc-linux-tdep.c: Same.
2994         * remote.c: Same.
2995         * riscv-tdep.c: Same.
2996         * s390-tdep.c: Same.
2997         * sh-tdep.c: Same.
2998         * sparc-linux-tdep.c: Same.
2999         * sparc-nat.c: Same.
3000         * stack.c: Same.
3001         * target-descriptions.c: Same.
3002         * top.c: Same.
3003         * varobj.c: Same.
3004
3005 2019-10-16  Tom Tromey  <tom@tromey.com>
3006
3007         * objfiles.h (struct objfile) <original_name>: Now const.
3008
3009 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3010
3011         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3012         pass on to sigsetjmp's second argument.
3013         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3014
3015 2019-10-16  Keith Seitz  <keiths@redhat.com>
3016
3017         PR gdb/23567
3018         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3019         sections whose size is greater than the file size.
3020
3021 2019-10-16  Jim Wilson  <jimw@sifive.com>
3022
3023         * riscv-tdep.c (riscv_gcc_target_options): New.
3024         (riscv_gnu_triplet_regexp): New.
3025         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3026         set_gdbarch_gnu_triplet_regexp.
3027
3028 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3029
3030         * Makefile.in: Add xml-builtin.h.
3031         * features/feature_to_c.sh: Add an include for xml-builtin.h
3032         to ensure that the compiler checks that the types match.
3033         * xml-builtin.h: New file.
3034         * xml-support.c (fetch_xml_builtin): Add missing const.
3035         * xml-support.h: Remove declaration of xml_builtins.
3036
3037 2019-10-16  Tom de Vries  <tdevries@suse.de>
3038
3039         PR tdep/25096
3040         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3041         (amd64_classify_aggregate): ... here.
3042         (amd64_classify_aggregate_field): Handled fiels of nested structs
3043         recursively.
3044
3045 2019-10-16  Tom de Vries  <tdevries@suse.de>
3046
3047         PR tdep/24104
3048         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3049         that handles 'theclass'.
3050
3051 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3052
3053         * linespec.c (decode_digits_ordinary): Update comment.
3054         * make-target-delegates: No longer need to handle VEC case.
3055         * memrange.c (normalize_mem_ranges): Update comment.
3056         * namespace.c (add_using_directive): Update comment.
3057         * objc-lang.c (uniquify_strings): Update comment.
3058         * ppc-linux-nat.c (struct thread_points): Update comment.
3059         * probe.h (find_probes_in_objfile): Update comment.
3060         * target.h (enum flash_preserve_mode): Update comment.
3061         * varobj.c (varobj_restrict_range): Update comment.
3062         * varobj.h (varobj_list_children): Update comment.
3063
3064 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3065
3066         * Makefile.in: Remove references to vec.h and vec.c.
3067         * aarch64-tdep.c: No longer include vec.h.
3068         * ada-lang.c: Likewise.
3069         * ada-lang.h: Likewise.
3070         * arm-tdep.c: Likewise.
3071         * ax.h: Likewise.
3072         * breakpoint.h: Likewise.
3073         * charset.c: Likewise.
3074         * cp-support.h: Likewise.
3075         * dtrace-probe.c: Likewise.
3076         * dwarf2read.c: Likewise.
3077         * extension.h: Likewise.
3078         * gdb_bfd.c: Likewise.
3079         * gdbsupport/gdb_vecs.h: Likewise.
3080         * gdbsupport/vec.c: Remove.
3081         * gdbsupport/vec.h: Remove.
3082         * gdbthread.h: Likewise.
3083         * guile/scm-type.c: Likewise.
3084         * inline-frame.c: Likewise.
3085         * machoread.c: Likewise.
3086         * memattr.c: Likewise.
3087         * memrange.h: Likewise.
3088         * namespace.h: Likewise.
3089         * nat/linux-btrace.h: Likewise.
3090         * osdata.c: Likewise.
3091         * parser-defs.h: Likewise.
3092         * progspace.h: Likewise.
3093         * python/py-type.c: Likewise.
3094         * record-btrace.c: Likewise.
3095         * rust-exp.y: Likewise.
3096         * solib-target.c: Likewise.
3097         * stap-probe.c: Likewise.
3098         * target-descriptions.c: Likewise.
3099         * target-memory.c: Likewise.
3100         * target.h: Likewise.
3101         * varobj.c: Likewise.
3102         * varobj.h: Likewise.
3103         * xml-support.h: Likewise.
3104
3105 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3106
3107         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3108         Update for new std::vector based implementation.
3109         (process_psymtab_comp_unit_reader): Likewise.
3110         (scan_partial_symbols): Likewise.
3111         (recursively_compute_inclusions): Likewise.
3112         (compute_compunit_symtab_includes): Likewise.
3113         (process_imported_unit_die): Likewise.
3114         (queue_and_load_dwo_tu): Likewise.
3115         (follow_die_sig_1): Likewise.
3116         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3117         (typedef dwarf2_per_cu_ptr): Remove.
3118         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3119         function.
3120         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3121         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3122         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3123         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3124         std::vector.
3125
3126 2019-10-15  Tom Tromey  <tromey@adacore.com>
3127
3128         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3129         TID.
3130
3131 2019-10-15  Tom Tromey  <tromey@adacore.com>
3132
3133         * windows-nat.c (windows_nat_target::fetch_registers)
3134         (windows_nat_target::store_registers): Rename "pid" to "tid".
3135
3136 2019-10-15  Tom Tromey  <tromey@adacore.com>
3137
3138         * gdbarch.h, gdbarch.c: Rebuild.
3139         * gdbarch.sh (gcc_target_options): Change return type to
3140         std::string.
3141         * compile/compile.c (get_args): Update.
3142         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3143         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3144         std::string.
3145         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3146         std::string.
3147         * arch-utils.c (default_gcc_target_options): Return std::string.
3148         * arch-utils.h (default_gcc_target_options): Return std::string.
3149         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3150
3151 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3152
3153         * breakpoint.c (breakpoint_chain): Make static.
3154         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3155         of accessing breakpoint_chain.
3156
3157 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3158
3159         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3160         to a gdb::function_view and return value to bool.
3161         * breakpoint.h (iterate_over_breakpoints): Likewise.
3162         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3163         (pop_dummy_frame): Update.
3164         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3165         (gdbscm_breakpoints): Update.
3166         * python/py-breakpoint.c (build_bp_list): Update.
3167         (gdbpy_breakpoints): Update.
3168         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3169         Update.
3170         (bpfinishpy_handle_stop): Update.
3171         (bpfinishpy_handle_exit): Update.
3172         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3173         (svr4_update_solib_event_breakpoints): Update.
3174
3175 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3176
3177         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3178         when unwrapping single-field structs.
3179
3180 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3181
3182         * dwarf2read.c: Remove includes.
3183
3184 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3185
3186         * ui-out.c (ui_out::call_do_message): Silence
3187         -Wformat-nonliteral warning.
3188
3189 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3190
3191         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3192         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3193         include: readline/tilde.h.
3194
3195 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3196
3197         * remote.c (remote_target::get_trace_status): Remove declaration of
3198         trace_regblock_size.
3199
3200 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3201
3202         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3203         (show_user): Remove declaration of cmdlist.
3204         * cli/cli-cmds.h (max_user_call_depth): Declare.
3205         * cli/cli-script.c (execute_user_command): Remove declaration
3206         of max_user_call_depth.
3207
3208 2019-10-11  Jim Wilson  <jimw@sifive.com>
3209
3210         * gdbsupport/print-utils.h (pulongest): Fix comment.
3211         (plongest): Likewise.
3212         (phex): Add missing comment, mention leading zeros.
3213         (phex_nz): Add mention of no leading zeros to comment.
3214
3215         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3216         plongest instead of unsigned long long cast.
3217
3218 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3219
3220         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3221         for external_editor_command and gdbtk_test.
3222
3223 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3224
3225         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3226         * varobj.c (varobjdebug): Move comment to...
3227         * varobj.h (varobjdebug): ...here, and declare.
3228
3229 2019-10-09  Tom Tromey  <tom@tromey.com>
3230
3231         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3232         erase_data_content.
3233
3234 2019-10-09  Tom Tromey  <tom@tromey.com>
3235
3236         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3237         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3238         * tui/tui-command.c (tui_cmd_window::resize)
3239         (tui_refresh_cmd_win): Update.
3240         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3241         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3242         * tui/tui-data.c (~tui_gen_win_info): Remove.
3243         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3244         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3245         (tui_redisplay_readline, tui_mld_flush)
3246         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3247         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3248         (tui_data_window::erase_data_content)
3249         (tui_data_item_window::rerender)
3250         (tui_data_item_window::refresh_window): Update.
3251         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3252         (box_win, tui_gen_win_info::make_window)
3253         (tui_gen_win_info::make_visible): Update.
3254         (tui_delete_win): Remove.
3255         * tui/tui-winsource.c
3256         (tui_source_window_base::do_erase_source_content): Update.
3257         (tui_show_source_line, tui_source_window_base::update_tab_width)
3258         (tui_source_window_base::update_exec_info): Update.
3259         * tui/tui-data.h (struct curses_deleter): New.
3260         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3261         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3262
3263 2019-10-09  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3266
3267 2019-10-09  Tom Tromey  <tom@tromey.com>
3268
3269         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3270         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3271
3272 2019-10-09  Tom Tromey  <tom@tromey.com>
3273
3274         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3275         window height directly.
3276         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3277         declare.
3278         * tui/tui-layout.c (tui_default_win_height): Remove.
3279         (tui_default_win_viewport_height): Remove.
3280
3281 2019-10-09  Tom Tromey  <tom@tromey.com>
3282
3283         * tui/tui.h: Remove comments.
3284
3285 2019-10-09  Tom de Vries  <tdevries@suse.de>
3286
3287         * python/lib/gdb/printer/bound_registers.py: Use
3288         '^builtin_type_bound128' as regexp argument for
3289         add_builtin_pretty_printer.
3290
3291 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3292
3293         * guile/guile.c (guile_extension_script_ops): Remove forward
3294         declaration and mark as static.
3295         (guile_script_ops): Likewise.
3296         (extension_language_guile): Move further down in the file so
3297         it can reference the definitions for guile_{extension_,}script_ops.
3298
3299 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3300
3301         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3302         except SORTL, DFLTCC, and KDSA.
3303
3304 2019-10-08  Tom Tromey  <tromey@adacore.com>
3305
3306         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3307         (struct safe_symbol_file_add_args): Remove.
3308
3309 2019-10-08  Tom Tromey  <tromey@adacore.com>
3310
3311         * windows-nat.c: Don't include buildsym-legacy.h.
3312
3313 2019-10-08  Tom Tromey  <tromey@adacore.com>
3314
3315         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3316
3317 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3318
3319         * gdbtypes.c (overload_debug): Move comment to header.
3320         * gdbtypes.h (overload_debug): Declare.
3321         * valops.c: Remove declaration of overload_debug, instead
3322         include gdbtypes.h.
3323
3324 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3325
3326         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3327         through _().
3328         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3329         move comment...
3330         * language.h (lang_frame_mismatch_warn): ... here. Also add
3331         declaration.
3332         * top.c (lang_frame_mismatch_warn): Remove declaration.
3333         (check_frame_language_change): Pass lang_frame_mismatch_warn
3334         through _().
3335
3336 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3337
3338         * c-lang.h (vtbl_ptr_name): Declare.
3339         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3340         it from the header.
3341         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3342
3343 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3344
3345         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3346         gdb_static_assert.
3347
3348 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3349
3350         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3351         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3352         * ctfread.c: New file.
3353         * ctfread.h: New file.
3354         * elfread.c: Include ctfread.h.
3355         (struct elfinfo text_p): New member ctfsect.
3356         (elf_locate_sections): Mark CTF section.
3357         (elf_symfile_read): Call elfctf_build_psymtabs.
3358         * Makefile.in (LIBCTF): Add.
3359         (CLIBS): Use it.
3360         (CDEPS): Likewise.
3361         (DIST): Add ctfread.c.
3362
3363 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3364
3365         * ctfread.c (struct nextfield): Renamed to ...
3366         (struct ctf_nextfield): ... this.
3367         (struct field_info): Renamed to ...
3368         (strut ctf_field_info): ... this.
3369         (attach_fields_to_type): Update for renamed structures.
3370         (ctf_add_member_cb): Likewise.
3371         (ctf_add_enum_member_cb): Likewise.
3372         (process_struct_members): Likewise.
3373         (process_enum_type): Likewise.
3374
3375 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3376
3377         * tracectf.h: Rename, was ctf.h.
3378         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3379         * tracefile.c: Likewise.
3380         * tracepoint.c: Remove unused include ctf.h.
3381         * mi/mi-main.c: Likewise.
3382         * Makefile.in Replace ctf.c with tracectf.c.
3383
3384 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3385
3386         * version.in: Change version number to "9.0.50.DATE-git".
3387
3388 2019-10-03  Tom Tromey  <tom@tromey.com>
3389
3390         PR rust/24976:
3391         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3392
3393 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3394
3395         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3396         cp_search_name_hash.
3397         * NEWS: Add entry about nested function support.
3398
3399 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3400             Andrew Burgess  <andrew.burgess@embecosm.com>
3401
3402         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3403         for nested static variables when searchin VAR_DOMAIN.
3404         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3405         global scope, update comment.
3406         (add_partial_subprogram): Call add_partial_subprogram recursively
3407         for nested subroutines when processinng Fortran.
3408         (load_partial_dies): Process the child entities of a subprogram
3409         when processing Fortran.
3410         (partial_die_parent_scope): Handle building scope
3411         for Fortran nested functions.
3412         (process_die): Record that nested functions have a scope.
3413         (new_symbol): Always record Fortran subprograms on the global
3414         symbol list.
3415         (determine_prefix): How to build the prefix for Fortran
3416         subprograms.
3417
3418 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3419
3420         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3421         have just sent the thread a SIGSTOP and are waiting for it to
3422         arrive.
3423
3424 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3425
3426         * btrace.c (btrace_add_pc): Remove whitespace before the template
3427         parameter in 'std::vector <...>'.
3428         (parse_xml_btrace_block): Likewise.
3429         (btrace_maint_decode_pt): Likewise.
3430         (btrace_maint_update_packets): Likewise.
3431         (btrace_maint_print_packets): Likewise.
3432         * btrace.h (struct btrace_maint_info): Likewise.
3433         * dwarf2read.c (struct type_unit_group): Likewise.
3434         (build_type_psymtabs_reader): Likewise.
3435         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3436         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3437         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3438
3439 2019-10-03  Tom de Vries  <tdevries@suse.de>
3440
3441         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3442         the first line of the help text for set/show style metadata.
3443
3444 2019-10-02  Tom Tromey  <tromey@adacore.com>
3445
3446         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3447         * gdbsupport/common-inferior.c: New file.
3448         * infcmd.c (startup_with_shell): Don't define.
3449         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3450         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3451         * inferior.h (startup_with_shell): Don't declare.
3452
3453 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3454
3455         * gdbsupport/gdb_assert.h: Include errors.h.
3456         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3457
3458 2019-10-02  Tom Tromey  <tromey@adacore.com>
3459
3460         * NEWS: Add $_ada_exception entry.
3461         * ada-lang.c (struct ada_catchpoint): Add constructor.
3462         <m_kind>: New member.
3463         (allocate_location_exception, re_set_exception): Remove
3464         "ex" parameter.
3465         (should_stop_exception): Compute $_ada_exception.
3466         (check_status_exception, print_it_exception)
3467         (print_one_exception, print_mention_exception): Remove
3468         "ex" parameter.
3469         (allocate_location_catch_exception, re_set_catch_exception)
3470         (check_status_exception, print_it_catch_exception)
3471         (print_one_catch_exception, print_mention_catch_exception)
3472         (print_recreate_catch_exception)
3473         (allocate_location_catch_exception_unhandled)
3474         (re_set_catch_exception_unhandled)
3475         (check_status_exception, print_it_catch_exception_unhandled)
3476         (print_one_catch_exception_unhandled)
3477         (print_mention_catch_exception_unhandled)
3478         (print_recreate_catch_exception_unhandled)
3479         (allocate_location_catch_assert, re_set_catch_assert)
3480         (check_status_assert, print_it_catch_assert)
3481         (print_one_catch_assert, print_mention_catch_assert)
3482         (print_recreate_catch_assert)
3483         (allocate_location_catch_handlers, re_set_catch_handlers)
3484         (check_status_handlers, print_it_catch_handlers)
3485         (print_one_catch_handlers, print_mention_catch_handlers)
3486         (print_recreate_catch_handlers): Remove.
3487         (create_ada_exception_catchpoint): Update.
3488         (initialize_ada_catchpoint_ops): Update.
3489
3490 2019-10-02  Tom Tromey  <tromey@adacore.com>
3491
3492         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3493         (create_excep_cond_exprs): Simplify exception string computation.
3494         (ada_exception_catchpoint_cond_string): Likewise.
3495
3496 2019-10-02  Tom Tromey  <tromey@adacore.com>
3497
3498         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3499         * ada-lang.c (lesseq_defined_than): Handle
3500         LOC_STATIC.
3501         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3502         parameter.
3503         (dwarf2_has_info): Likewise.
3504         (new_symbol): Set maybe_copied on symbol when
3505         appropriate.
3506         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3507         parameter.
3508         <can_copy>: New member.
3509         * elfread.c (record_minimal_symbol): Set maybe_copied
3510         on symbol when appropriate.
3511         (elf_symfile_read): Update call to dwarf2_has_info.
3512         * minsyms.c (lookup_minimal_symbol_linkage): New
3513         function.
3514         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3515         * symtab.c (get_symbol_address, get_msymbol_address):
3516         New functions.
3517         * symtab.h (get_symbol_address, get_msymbol_address):
3518         Declare.
3519         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3520         maybe_copied.
3521         (struct symbol, struct minimal_symbol) <maybe_copied>:
3522         New member.
3523
3524 2019-10-02  Tom Tromey  <tromey@adacore.com>
3525
3526         * source.c (struct current_source_location): New.
3527         (current_source_key): New global.
3528         (current_source_symtab, current_source_line)
3529         (current_source_pspace): Remove.
3530         (get_source_location): New function.
3531         (get_current_source_symtab_and_line)
3532         (set_default_source_symtab_and_line)
3533         (set_current_source_symtab_and_line)
3534         (clear_current_source_symtab_and_line, select_source_symtab)
3535         (info_source_command, print_source_lines_base)
3536         (info_line_command, search_command_helper, _initialize_source):
3537         Update.
3538
3539 2019-10-02  Tom Tromey  <tromey@adacore.com>
3540
3541         * source.c (select_source_symtab): Don't call
3542         decode_line_with_current_source.
3543
3544 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3545
3546         * symtab.c (lookup_global_symbol): Search global block.
3547
3548 2019-10-02  Tom Tromey  <tromey@adacore.com>
3549
3550         * coffread.c (process_coff_symbol): Update.
3551         * dwarf2read.c (var_decode_location, new_symbol): Update.
3552         * mdebugread.c (parse_symbol): Update.
3553         * objfiles.c (relocate_one_symbol): Update.
3554         * stabsread.c (define_symbol, fix_common_block)
3555         (scan_file_globals): Update.
3556         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3557         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3558         * xcoffread.c (process_xcoff_symbol): Update.
3559
3560 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3561
3562         * MAINTAINERS: Update my email address.
3563
3564 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3565
3566         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3567         std::vector.
3568         (build_type_psymtabs_reader): Update for std::vector.
3569         (build_type_psymtab_dependencies): Likewise.
3570         * dwarf2read.h: Remove use of DEF_VEC_P.
3571         (typedef sig_type_ptr): Delete.
3572
3573 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3574
3575         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3576         to std::vector.
3577         (btrace_maint_decode_pt): Likewise, and move allocation of the
3578         vector outside of the loop.
3579         (btrace_maint_update_packets): Update to handle change from VEC to
3580         std::vector.
3581         (btrace_maint_print_packets): Likewise.
3582         (maint_info_btrace_cmd): Likewise.
3583         * btrace.h: Remove use of DEF_VEC_O.
3584         (typedef btrace_pt_packet_s): Delete.
3585         (struct btrace_maint_info) <packets>: Change fromm VEC to
3586         std::vector.
3587         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3588
3589 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3590
3591         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3592         make accesses into the vector constant references.
3593         (btrace_add_pc): Update for std::vector.
3594         (btrace_stitch_bts): Likewise.
3595         (parse_xml_btrace_block): Likewise.
3596         (btrace_maint_update_packets): Likewise.
3597         (btrace_maint_print_packets): Likewise.
3598         (maint_info_btrace_cmd): Likewise.
3599         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3600         std::vector.
3601         (btrace_data::empty): Likewise.
3602         (btrace_data_append): Likewise.
3603         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3604         (typedef btrace_block_s): Delete.
3605         (struct btrace_block): Add constructor.
3606         (struct btrace_data_bts) <blocks>: Change to std::vector.
3607         * nat/linux-btrace.c (perf_event_read_bts): Update for
3608         std::vector.
3609         (linux_read_bts): Likewise.
3610
3611 2019-10-01  Tom Tromey  <tom@tromey.com>
3612
3613         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3614
3615 2019-10-01  Tom Tromey  <tom@tromey.com>
3616
3617         * stack.c (print_frame, info_frame_command_core): Use
3618         styled_string.
3619         * linux-thread-db.c (try_thread_db_load_1)
3620         (try_thread_db_load_from_pdir_1): Use styled_string.
3621         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3622         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3623         (maybe_print_unsupported_script_warning)
3624         (maybe_print_script_not_found_warning): Use styled_string.
3625         * ada-lang.c (user_select_syms): Use styled_string.
3626
3627 2019-10-01  Tom Tromey  <tom@tromey.com>
3628
3629         * p-lang.c (pascal_printstr): Use metadata style.
3630         * value.c (show_convenience): Use metadata style.
3631         * valprint.c (valprint_check_validity, val_print_optimized_out)
3632         (val_print_not_saved, val_print_unavailable)
3633         (val_print_invalid_address, generic_val_print, val_print)
3634         (value_check_printable, val_print_array_elements): Use metadata
3635         style.
3636         * ui-out.h (class ui_out) <field_fmt>: New overload.
3637         <do_field_fmt>: Add style parameter.
3638         * ui-out.c (ui_out::field_fmt): New overload.
3639         * typeprint.c (type_print_unknown_return_type)
3640         (val_print_not_allocated, val_print_not_associated): Use metadata
3641         style.
3642         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3643         parameter.
3644         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3645         * tracepoint.c (tvariables_info_1): Use metadata style.
3646         * stack.c (print_frame_arg, print_frame_info, print_frame)
3647         (info_frame_command_core): Use metadata style.
3648         * skip.c (info_skip_command): Use metadata style.
3649         * rust-lang.c (rust_print_enum): Use metadata style.
3650         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3651         metadata style.
3652         * python/py-framefilter.c (py_print_single_arg): Use metadata
3653         style.
3654         * printcmd.c (do_one_display, print_variable_and_value): Use
3655         metadata style.
3656         * p-valprint.c (pascal_val_print)
3657         (pascal_object_print_value_fields): Use metadata style.
3658         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3659         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3660         parameter.
3661         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3662         * m2-valprint.c (m2_print_long_set): Use metadata style.
3663         * m2-typeprint.c (m2_print_type): Use metadata style.
3664         * infcmd.c (print_return_value_1): Use metadata style.
3665         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3666         * f-valprint.c (info_common_command_for_block): Use metadata
3667         style.
3668         * f-typeprint.c (f_type_print_base): Use metadata style.
3669         * expprint.c (print_subexp_standard): Use metadata style.
3670         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3671         * cli/cli-style.h (class cli_style_option): Add constructor.
3672         (metadata_style): Declare.
3673         * cli/cli-style.c (metadata_style): New global.
3674         (_initialize_cli_style): Register metadata style.
3675         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3676         parameter.
3677         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3678         * c-typeprint.c (c_type_print_base_struct_union)
3679         (c_type_print_base_1): Use metadata style.
3680         * breakpoint.c (watchpoint_value_print)
3681         (print_one_breakpoint_location): Use metadata style.
3682         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3683         style.
3684         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3685         style.
3686         * ada-valprint.c (val_print_packed_array_elements, printstr)
3687         (print_field_values, ada_val_print_ref, ada_val_print): Use
3688         metadata style.
3689         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3690         style.
3691         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3692         style.
3693         * ada-lang.c (user_select_syms): Use metadata style.
3694
3695 2019-10-01  Tom Tromey  <tom@tromey.com>
3696
3697         * cli/cli-cmds.c (pwd_command): Style output.
3698
3699 2019-10-01  Pedro Alves  <palves@redhat.com>
3700             Tom Tromey  <tom@tromey.com>
3701
3702         * symtab.c (print_symbol_info): Use %ps.
3703         (print_msymbol_info): Use %ps.
3704         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3705         * printcmd.c (print_variable_and_value): Use %ps.
3706         * macrocmd.c (show_pp_source_pos): Use %ps.
3707         * infrun.c (print_exited_reason): Use ui_out::message.
3708         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3709         (describe_other_breakpoints): Use ui_out::message and new
3710         formats.
3711         (say_where): Use new formats.
3712         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3713         and new formats.
3714
3715 2019-10-01  Pedro Alves  <palves@redhat.com>
3716             Tom Tromey  <tom@tromey.com>
3717
3718         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3719         (test_gdb_formats): New function.
3720         (run_tests): Call it.
3721         (test_format_specifier): Update.
3722         * utils.h (fputs_filtered): Update comment.
3723         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3724         (fputs_styled_unfiltered): Declare.
3725         * utils.c (fputs_styled_unfiltered): New function.
3726         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3727         (vfprintf_filtered): Update.
3728         (vfprintf_unfiltered, vprintf_filtered): Update.
3729         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3730         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3731         disallow_ui_out_field>: New constants.
3732         (enum class field_kind): New.
3733         (struct base_field_s, struct signed_field_s): New.
3734         (signed_field): New function.
3735         (struct string_field_s): New.
3736         (string_field): New function.
3737         (struct styled_string_s): New.
3738         (styled_string): New function.
3739         (class ui_out) <message>: Add comment.
3740         <vmessage, call_do_message>: New methods.
3741         <do_message>: Add style parameter.
3742         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3743         methods.
3744         (ui_out::message): Rewrite.
3745         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3746         parameter.
3747         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3748         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3749         gdb_extensions parameter.
3750         (class format_piece): Add parameter to constructor.
3751         (n_int_args): New field.
3752         * gdbsupport/format.c (format_pieces::format_pieces): Add
3753         gdb_extensions parameter.  Handle '*'.
3754         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3755         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3756         vfprintf_styled_no_gdbfmt.
3757         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3758         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3759         unfiltered output.
3760         * ui-style.h (struct ui_file_style) <ptr>: New method.
3761
3762 2019-10-01  Tom Tromey  <tom@tromey.com>
3763
3764         * unittests/format_pieces-selftests.c: Update.  Add final format.
3765         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3766         empty literal pieces.
3767
3768 2019-10-01  Tom Tromey  <tom@tromey.com>
3769
3770         * ui-out.h (enum class ui_out_style_kind): Remove.
3771         (class ui_out) <field_string, field_stsream, do_field_string>:
3772         Change type of "style".
3773         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3774         (ui_out::field_string): Update.
3775         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3776         of "style".
3777         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3778         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3779         * stack.c (print_frame_arg, print_frame_info, print_frame):
3780         Update.
3781         * source.c (print_source_lines_base): Update.
3782         * solib.c (info_sharedlibrary_command): Update.
3783         * skip.c (info_skip_command): Update.
3784         * record-btrace.c (btrace_call_history_src_line)
3785         (btrace_call_history): Update.
3786         * python/py-framefilter.c (py_print_frame): Update.
3787         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3788         "style".
3789         * mi/mi-out.c (mi_ui_out::do_table_header)
3790         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3791         (mi_ui_out::do_field_string): Update.
3792         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3793         Update.
3794         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3795         "style".
3796         * cli-out.c (cli_ui_out::do_table_header)
3797         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3798         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3799         (cli_ui_out::do_field_fmt): Update.
3800         * breakpoint.c (print_breakpoint_location): Update.
3801         (update_static_tracepoint): Update.
3802
3803 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3804
3805         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3806         conversion of gdb_datadir.
3807         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3808         remove not needed c_str ().
3809
3810 2019-09-30  Ali Tamur <tamur@google.com>
3811
3812         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3813         (dwarf2_string_attr): Likewise.
3814
3815 2019-09-30  Ali Tamur <tamur@google.com>
3816
3817         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3818         (process_full_type_unit): Likewise.
3819         (dump_die_shallow): Likewise.
3820         (cu_debug_loc_section): Likewise.
3821
3822 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3823
3824         * minsyms.c (compare_minimal_symbols): Rename to...
3825         (minimal_symbol_is_less_than): ...this, and adjust to STL
3826         conventions (return bool, take arguments as references)
3827         (minimal_symbol_reader::install): Call std::sort instead
3828         of qsort.
3829
3830 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3831
3832         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3833         hash and why.
3834         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3835         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3836
3837 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3838
3839         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3840         * psympriv.h (add_psymbol_to_list): Move comment here and update
3841         it.
3842
3843 2019-09-29  Tom de Vries  <tdevries@suse.de>
3844
3845         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3846         Use $tmpdir/$(basename "$output_file").dwz instead of
3847         "${output_file}.dwz".
3848
3849 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3850
3851         PR gdb/25045
3852         * hppa-linux-nat.c: Include gdbarch.h.
3853
3854 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3855
3856         * blockframe.c (find_pc_partial_function): Change return type to bool.
3857         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3858         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3859         (stub_gnu_ifunc_resolve_name): Likewise.
3860         * symtab.c (compare_filenames_for_search): Likewise.
3861         (compare_glob_filenames_for_search): Likewise.
3862         (matching_obj_sections): Likewise.
3863         (symbol_matches_domain): Likewise.
3864         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3865         (find_line_pc): Change return type to bool.
3866         (find_line_pc_range): Likewise.
3867         (producer_is_realview): Likewise.
3868         * symtab.h (symbol_matches_domain): Likewise.
3869         (find_pc_partial_function): Likewise.
3870         (find_pc_line_pc_range): Likewise.
3871         (in_gnu_ifunc_stub): Likewise.
3872         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3873         (find_line_pc): Likewise.
3874         (find_line_pc_range): Likewise.
3875         (matching_obj_sections): Likewise.
3876         (find_line_symtab): Change out parameter to bool.
3877         (producer_is_realview): Change return type to bool.
3878         (compare_filenames_for_search): Likewise.
3879         (compare_glob_filenames_for_search): Likewise.
3880
3881 2019-09-26  Tom Tromey  <tom@tromey.com>
3882
3883         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3884         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3885         * gdb_usleep.h: Remove.
3886         * gdb_usleep.c: Remove.
3887         * utils.c: Don't include gdb_usleep.h.
3888
3889 2019-09-26  Tom Tromey  <tromey@adacore.com>
3890
3891         * python/py-type.c (type_to_type_object): Call check_typedef
3892         for stub types.
3893
3894 2019-09-26  Tom Tromey  <tom@tromey.com>
3895
3896         * utils.h (initialize_utils): Don't declare.
3897         * top.c (gdb_init): Don't call initialize_utils.
3898         * utils.c (initialize_utils): Remove.  Move contents...
3899         (_initialize_utils): ... here.
3900
3901 2019-09-25  Tom Tromey  <tom@tromey.com>
3902
3903         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3904         * utils.h (make_hex_string): Don't declare.
3905         * utils.c (make_hex_string): Remove.
3906
3907 2019-09-24  Tom de Vries  <tdevries@suse.de>
3908
3909         PR gdb/23815
3910         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3911         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3912
3913 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3914
3915         * NEWS: Mention new simulator port for PRU.
3916
3917 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3918
3919         * ada-exp.y (write_object_remaining): Update.
3920         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3921         and eliminate the static buffer.
3922         (ada_decode_symbol): Update.
3923         (ada_la_decode): Update.
3924         (ada_sniff_from_mangled_name): Update.
3925         (is_valid_name_for_wild_match): Update.
3926         (ada_lookup_name_info::matches): Update and simplify.
3927         (name_matches_regex): Update.
3928         (ada_add_global_exceptions): Update.
3929         * ada-lang.h (ada_decode): Update signature.
3930         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3931         * dwarf-index-write.c (debug_names::insert): Update.
3932
3933 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3934
3935         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3936         formatting.
3937
3938 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3939
3940         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3941         Change "nonzero" to "true" in documentation.
3942
3943 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3944
3945         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3946         (_initialize_darwin_solib): Don't set
3947         darwin_so_ops.lookup_lib_global_symbol.
3948         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3949         set_gdbarch_iterate_over_objfiles_in_search_order.
3950         (elf_lookup_lib_symbol): Rename to...
3951         (svr4_iterate_over_objfiles_in_search_order): this, and update
3952         to iterate semantics.
3953         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3954         * solib.c (solib_global_lookup): Remove.
3955         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3956         (solib_global_lookup): Remove.
3957         * symtab.c (lookup_global_or_static_symbol): Remove call to
3958         solib_global_lookup.
3959
3960 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3961
3962         * NEWS: Move entries about default MI version now being
3963         version 3, and about the GDB/MI fix for multi-location
3964         breakpoints to the "since GDB 8.3" section.
3965
3966 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3967
3968         GDB 8.3.1 released.
3969
3970 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3971
3972         * NEWS: Mention that Cell/B.E. debugging support was removed.
3973         * MAINTAINERS: Remove spu target.
3974
3975         * config/djgpp/fnchange.lst: Remove entries for removed files.
3976
3977         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3978         spu-multiarch.o, and spu-tdep.o.
3979         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3980         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3981         spu-multiarch.c, and spu-tdep.c.
3982         * spu-linux-nat.c: Remove file.
3983         * spu-multiarch.c: Remove file.
3984         * spu-tdep.c: Remove file.
3985         * spu-tdep.h: Remove file.
3986         * solib-spu.c: Remove file.
3987         * solib-spu.h: Remove file.
3988
3989         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3990         * configure.nat (spu-linux): Remove.
3991         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3992         solib-multiarch.o from gdb_target_obs.
3993         (spu*-*-*): Remove.
3994
3995         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3996         feature flag.
3997         (ppc_linux_no_features): Update.
3998         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3999         Cell/B.E. support.
4000         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4001         (tdesc_powerpc_cell64l): Likewise.
4002         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4003         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4004         Cell/B.E. support.
4005         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4006         Do not include "features/rs6000/powerpc-cell32l.c" or
4007         "features/rs6000/powerpc-cell64l.c".
4008         (ppc_linux_spu_section): Remove.
4009         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4010         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4011         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4012         (ppc_linux_spe_context_lookup): Remove.
4013         (ppc_linux_spe_context_inferior_created): Remove.
4014         (ppc_linux_spe_context_solib_loaded): Remove.
4015         (ppc_linux_spe_context_solib_unloaded): Remove.
4016         (ppc_linux_spe_context): Remove.
4017         (struct ppu2spu_cache): Remove.
4018         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4019         (struct ppu2spu_data): Remove.
4020         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4021         ppu2spu_unwind): Remove.
4022         (ppc_linux_init_abi): Remove Cell/B.E. support.
4023         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4024
4025         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4026         (rs6000/powerpc-cell64l-expedite): Likewise
4027         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4028         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4029         rs6000/powerpc-cell64l.xml.
4030         * features/rs6000/powerpc-cell32l.xml: Remove.
4031         * features/rs6000/powerpc-cell64l.xml: Likewise.
4032         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4033         * features/rs6000/powerpc-cell64l.c: Likewise.
4034         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4035         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4036         * regformats/reg-spu.dat: Remove.
4037
4038         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4039         * corelow.c (struct spuid_list): Remove.
4040         (add_to_spuid_list): Remove.
4041         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4042         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4043         (remote_protocol_features): Remove associated entries.
4044         (_initialize_remote): No longer initialize them.
4045         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4046         * linux-nat.c (SPUFS_MAGIC): Remove.
4047         (linux_proc_xfer_spu): Remove.
4048         (spu_enumerate_spu_ids): Remove.
4049         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4050         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4051         (linux_make_corefile_notes): No longer call it.
4052
4053         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4054         (cooked_write_test): Likewise.
4055
4056 2019-09-20  Tom Tromey  <tom@tromey.com>
4057
4058         * NEWS: Mention case-sensitivity of TUI commands.
4059         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4060         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4061         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4062
4063 2019-09-20  Tom Tromey  <tom@tromey.com>
4064
4065         * tui/tui-source.c (tui_source_window::set_contents): Use
4066         make_unique_xstrdup.
4067         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4068         make_unique_xstrdup.
4069
4070 2019-09-20  Tom Tromey  <tom@tromey.com>
4071
4072         * tui/tui-data.c: Remove separator comments.
4073         * tui/tui-layout.c: Remove separator comments.
4074         * tui/tui-win.c: Remove separator comments.
4075         * tui/tui-wingeneral.c: Remove separator comments.
4076
4077 2019-09-20  Tom Tromey  <tom@tromey.com>
4078
4079         * tui/tui.h (strcat_to_buf): Don't declare.
4080         * tui/tui.c (strcat_to_buf): Remove.
4081
4082 2019-09-20  Tom Tromey  <tom@tromey.com>
4083
4084         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4085         from "fullname".
4086         * tui/tui-source.c (tui_source_window::set_contents)
4087         (tui_source_window::location_matches_p)
4088         (tui_source_window::maybe_update): Update.
4089
4090 2019-09-20  Tom Tromey  <tom@tromey.com>
4091
4092         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4093         Update.
4094         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4095         prefix.
4096         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4097         (tui_data_window::line_from_reg_element_no)
4098         (tui_data_window::first_reg_element_no_inline)
4099         (tui_data_window::show_registers)
4100         (tui_data_window::show_register_group)
4101         (tui_data_window::display_registers_from)
4102         (tui_data_window::display_registers_from_line)
4103         (tui_data_window::first_data_item_displayed)
4104         (tui_data_window::delete_data_content_windows)
4105         (tui_data_window::erase_data_content)
4106         (tui_data_window::do_scroll_vertical)
4107         (tui_data_window::refresh_window)
4108         (tui_data_window::check_register_values): Update.
4109
4110 2019-09-20  Tom Tromey  <tom@tromey.com>
4111
4112         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4113         (struct tui_locator_window) <full_name, proc_name>: Now
4114         std::string.
4115         * tui/tui-stack.c (tui_locator_window::make_status_line)
4116         (tui_locator_window::set_locator_fullname)
4117         (tui_locator_window::set_locator_info): Update.
4118         * tui/tui-source.c (tui_source_window::set_contents)
4119         (tui_source_window::showing_source_p): Update.
4120
4121 2019-09-20  Tom Tromey  <tom@tromey.com>
4122
4123         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4124         Don't call tui_locator_win_info_ptr.
4125
4126 2019-09-20  Tom Tromey  <tom@tromey.com>
4127
4128         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4129
4130 2019-09-20  Tom Tromey  <tom@tromey.com>
4131
4132         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4133         height for locator.
4134         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4135         * tui/tui-layout.c (show_source_disasm_command, show_data)
4136         (show_source_or_disasm_and_command): Use 1 as height for locator.
4137
4138 2019-09-20  Tom Tromey  <tom@tromey.com>
4139
4140         * tui/tui.c (tui_enable): Update.
4141         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4142         Update.
4143         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4144         Update.
4145         * tui/tui-data.c (win_resized): Now bool.
4146         (tui_win_resized): Return bool.
4147         (tui_set_win_resized_to): Accept a bool.
4148
4149 2019-09-20  Tom Tromey  <tom@tromey.com>
4150
4151         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4152         Change type of "refresh_values_only".
4153         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4154         type of "refresh_values_only".
4155
4156 2019-09-20  Tom Tromey  <tom@tromey.com>
4157
4158         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4159         std::string.
4160         (tui_disassemble): Add "pos" parameter.
4161         (tui_disasm_window::set_contents): Simplify.
4162
4163 2019-09-20  Tom Tromey  <tom@tromey.com>
4164
4165         * tui/tui-winsource.h (struct tui_source_window_base)
4166         <show_source_content>: Now private.
4167         * tui/tui-winsource.c
4168         (tui_source_window_base::show_source_content): Don't handle empty
4169         content case.
4170
4171 2019-09-20  Tom Tromey  <tom@tromey.com>
4172
4173         * tui/tui-layout.c (show_source_disasm_command)
4174         (show_source_or_disasm_and_command): Don't call
4175         show_source_content.
4176
4177 2019-09-20  Tom Tromey  <tom@tromey.com>
4178
4179         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4180         Declare.
4181         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4182         from tui_make_status_line.
4183         (tui_locator_window::rerender): Update.
4184
4185 2019-09-20  Tom Tromey  <tom@tromey.com>
4186
4187         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4188         (tui_locator_window::rerender): Update.
4189
4190 2019-09-20  Tom Tromey  <tom@tromey.com>
4191
4192         * tui/tui-winsource.h (struct tui_source_window_base)
4193         <~tui_source_window_base>: Don't declare.
4194         <fullname>: Remove.
4195         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4196         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4197         member.
4198         * tui/tui-source.c (tui_source_window::set_contents): Update.
4199         (tui_source_window::location_matches_p)
4200         (tui_source_window::maybe_update): Update.
4201
4202 2019-09-20  Tom Tromey  <tom@tromey.com>
4203
4204         * tui/tui-winsource.h (~tui_source_element): Remove.
4205         (tui_source_element): Update.
4206         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4207         * tui/tui-winsource.c (tui_show_source_line): Update.
4208         * tui/tui-source.c (tui_source_window::set_contents): Update.
4209         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4210
4211 2019-09-20  Tom Tromey  <tom@tromey.com>
4212
4213         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4214         declare.
4215         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4216         tui_clear_source_windows_detail.
4217         * tui/tui-winsource.h (struct tui_source_window_base)
4218         <clear_detail>: Don't declare.
4219         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4220         Remove.
4221         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4222
4223 2019-09-20  Tom Tromey  <tromey@adacore.com>
4224
4225         PR ada/24919:
4226         * block.c (contained_in): Fix final return value.
4227
4228 2019-09-20  Alan Modra  <amodra@gmail.com>
4229
4230         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4231         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4232         (read_indirect_string_from_dwz): Use bfd accessor.
4233         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4234         * machoread.c (macho_symfile_read_all_oso): Likewise.
4235         * solib.c (solib_bfd_open): Likewise.
4236
4237 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4238
4239         * eval.c: Move declaration of overload_resolution to...
4240         * value.h: ...here.
4241
4242 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4243
4244         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4245         * arm-linux-tdep.c: Likewise.
4246         * arm-nbsd-nat.c: Likewise.
4247         * arm-tdep.h: Declare arm_apcs_32.
4248         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4249
4250 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4251
4252         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4253         * dwarf2read.h: Declare dwarf_always_disassemble.
4254
4255 2019-09-19  Tom de Vries  <tdevries@suse.de>
4256
4257         PR gdb/25009
4258         * source-cache.c (source_cache::ensure): Catch exception thrown during
4259         construction of the highlighter.
4260
4261 2019-09-18  Alan Modra  <amodra@gmail.com>
4262
4263         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4264         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4265         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4266         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4267         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4268         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4269         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4270         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4271         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4272         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4273         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4274         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4275         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4276         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4277         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4278         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4279         * mi/mi-interp.c: Update throughout for bfd section macro and
4280         function changes.
4281         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4282         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4283
4284 2019-09-18  Tom Tromey  <tom@tromey.com>
4285
4286         * NEWS: Add entry.
4287         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4288         call rl_initialize.
4289         (tui_enable): Do not call rl_initialize.
4290
4291 2019-09-18  Christian Groessler  <chris@groessler.org>
4292
4293         * alpha-linux-nat.c: Include gdbarch.h.
4294
4295 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4296
4297         * ui-file.c: Include cli/cli-style.h.
4298         (term_cli_styling): Remove cli_styling declaration.
4299
4300 2019-09-18  Alan Modra  <amodra@gmail.com>
4301
4302         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4303         to bfd_asymbol_section.
4304
4305 2019-09-18  Alan Modra  <amodra@gmail.com>
4306
4307         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4308         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4309         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4310
4311 2019-09-18  Alan Modra  <amodra@gmail.com>
4312
4313         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4314         * spu-linux-nat.c (spu_bfd_open): Likewise.
4315
4316 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4317
4318         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4319         to bool to match definition in dwarf2read.c.
4320
4321 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4322
4323         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4324         (print_signatures): Likewise.
4325         (trust_pad_over_xvs): Likewise.
4326         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4327         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4328         * arm-linux-nat.c (arm_apcs_32): Likewise.
4329         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4330         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4331         * arm-tdep.c (arm_debug): Likewise.
4332         (arm_apcs_32): Likewise.
4333         * auto-load.c (debug_auto_load): Likewise.
4334         (auto_load_gdb_scripts): Likewise.
4335         (global_auto_load): Likewise.
4336         (auto_load_local_gdbinit): Likewise.
4337         (auto_load_local_gdbinit_loaded): Likewise.
4338         * auto-load.h (global_auto_load): Likewise.
4339         (auto_load_local_gdbinit): Likewise.
4340         (auto_load_local_gdbinit_loaded): Likewise.
4341         * breakpoint.c (disconnected_dprintf): Likewise.
4342         (breakpoint_proceeded): Likewise.
4343         (automatic_hardware_breakpoints): Likewise.
4344         (always_inserted_mode): Likewise.
4345         (target_exact_watchpoints): Likewise.
4346         (_initialize_breakpoint): Update.
4347         * breakpoint.h (target_exact_watchpoints): Change to bool.
4348         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4349         * cli/cli-cmds.c (trace_commands): Likewise.
4350         * cli/cli-cmds.h (trace_commands): Likewise.
4351         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4352         to bool*.
4353         * cli/cli-logging.c (logging_overwrite): Change to bool.
4354         (logging_redirect): Likewise.
4355         (debug_redirect): Likewise.
4356         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4357         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4358         to bool.
4359         <boolean_option_def>: Update.
4360         (struct flag_option_def): Change default type of Context to bool
4361         from int.
4362         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4363         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4364         (get_setshow_command_value_string): Likewise.
4365         * cli/cli-style.c (cli_styling): Change to bool.
4366         (source_styling): Likewise.
4367         * cli/cli-style.h (source_styling): Likewise.
4368         (cli_styling): Likewise.
4369         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4370         to bool.
4371         * command.h (var_types): Update comment.
4372         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4373         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4374         bool.
4375         (debug_compile_cplus_scopes): Likewise.
4376         * compile/compile-internal.h (compile_debug): Likewise.
4377         * compile/compile.c (compile_debug): Likewise.
4378         (struct compile_options) <raw>: Likewise.
4379         * cp-support.c (catch_demangler_crashes): Likewise.
4380         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4381         (usr_cmd_cris_dwarf2_cfi): Likewise.
4382         * csky-tdep.c (csky_debug): Likewise.
4383         * darwin-nat.c (enable_mach_exceptions): Likewise.
4384         * dcache.c (dcache_enabled_p): Likewise.
4385         * defs.h (info_verbose): Likewise.
4386         * demangle.c (demangle): Likewise.
4387         (asm_demangle): Likewise.
4388         * dwarf-index-cache.c (debug_index_cache): Likewise.
4389         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4390         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4391         * dwarf2read.c (check_physname): Likewise.
4392         (use_deprecated_index_sections): Likewise.
4393         (dwarf_always_disassemble): Likewise.
4394         * eval.c (overload_resolution): Likewise.
4395         * event-top.c (set_editing_cmd_var): Likewise.
4396         (exec_done_display_p): Likewise.
4397         * event-top.h (set_editing_cmd_var): Likewise.
4398         (exec_done_display_p): Likewise.
4399         * exec.c (write_files): Likewise.
4400         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4401         (debug_fbsd_nat): Likewise.
4402         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4403         Likewise.
4404         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4405         <backtrace_past_entry> Likewise.
4406         * gdb-demangle.h (demangle): Likewise.
4407         (asm_demangle): Likewise.
4408         * gdb_bfd.c (bfd_sharing): Likewise.
4409         * gdbcore.h (write_files): Likewise.
4410         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4411         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4412         * gdbthread.h (print_thread_events): Likewise.
4413         * gdbtypes.c (opaque_type_resolution): Likewise.
4414         (strict_type_checking): Likewise.
4415         * gnu-nat.c (gnu_debug_flag): Likewise.
4416         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4417         * guile/scm-param.c (pascm_variable): Add boolval.
4418         (add_setshow_generic): Update.
4419         (pascm_param_value): Update.
4420         (pascm_set_param_value_x): Update.
4421         * hppa-tdep.c (hppa_debug): Change to bool..
4422         * infcall.c (may_call_functions_p): Likewise.
4423         (coerce_float_to_double_p): Likewise.
4424         (unwind_on_signal_p): Likewise.
4425         (unwind_on_terminating_exception_p): Likewise.
4426         * infcmd.c (startup_with_shell): Likewise.
4427         * inferior.c (print_inferior_events): Likewise.
4428         * inferior.h (startup_with_shell): Likewise.
4429         (print_inferior_events): Likewise.
4430         * infrun.c (step_stop_if_no_debug): Likewise.
4431         (detach_fork): Likewise.
4432         (debug_displaced): Likewise.
4433         (disable_randomization): Likewise.
4434         (non_stop): Likewise.
4435         (non_stop_1): Likewise.
4436         (observer_mode): Likewise.
4437         (observer_mode_1): Likewise.
4438         (set_observer_mode): Update.
4439         (sched_multi): Change to bool.
4440         * infrun.h (debug_displaced): Likewise.
4441         (sched_multi): Likewise.
4442         (step_stop_if_no_debug): Likewise.
4443         (non_stop): Likewise.
4444         (disable_randomization): Likewise.
4445         * linux-tdep.c (use_coredump_filter): Likewise.
4446         (dump_excluded_mappings): Likewise.
4447         * linux-thread-db.c (auto_load_thread_db): Likewise.
4448         (check_thread_db_on_load): Likewise.
4449         * main.c (captured_main_1): Update.
4450         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4451         xx2_opt, boolean_opt>: Change to bool.
4452         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4453         * maint.c (maintenance_profile_p): Likewise.
4454         (per_command_time): Likewise.
4455         (per_command_space): Likewise.
4456         (per_command_symtab): Likewise.
4457         * memattr.c (inaccessible_by_default): Likewise.
4458         * mi/mi-main.c (mi_async): Likewise.
4459         (mi_async_1): Likewise.
4460         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4461         * nat/fork-inferior.h (startup_with_shell): Likewise.
4462         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4463         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4464         * nios2-tdep.c (nios2_debug): Likewise.
4465         * or1k-tdep.c (or1k_debug): Likewise.
4466         * parse.c (parser_debug): Likewise.
4467         * parser-defs.h (parser_debug): Likewise.
4468         * printcmd.c (print_symbol_filename): Likewise.
4469         * proc-api.c (procfs_trace): Likewise.
4470         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4471         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4472         (set_parameter_value): Update.
4473         (add_setshow_generic): Update.
4474         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4475         to bool*.
4476         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4477         int*.
4478         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4479         * record-btrace.c (record_btrace_target::store_registers): Update.
4480         * record-full.c (record_full_memory_query): Change to bool.
4481         (record_full_stop_at_limit): Likewise.
4482         * record-full.h (record_full_memory_query): Likewise.
4483         * remote-notif.c (notif_debug): Likewise.
4484         * remote-notif.h (notif_debug): Likewise.
4485         * remote.c (use_range_stepping): Likewise.
4486         (interrupt_on_connect): Likewise.
4487         (remote_break): Likewise.
4488         * ser-tcp.c (tcp_auto_retry): Likewise.
4489         * ser-unix.c (serial_hwflow): Likewise.
4490         * skip.c (debug_skip): Likewise.
4491         * solib-aix.c (solib_aix_debug): Likewise.
4492         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4493         (spu_auto_flush_cache_p): Likewise.
4494         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4495         Likewise.
4496         (struct info_print_options) <quiet>: Likewise.
4497         * symfile-debug.c (debug_symfile): Likewise.
4498         * symfile.c (auto_solib_add): Likewise.
4499         (separate_debug_file_debug): Likewise.
4500         * symfile.h (auto_solib_add): Likewise.
4501         (separate_debug_file_debug): Likewise.
4502         * symtab.c (basenames_may_differ): Likewise.
4503         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4504         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4505         (struct info_types_options) <quiet>: Likewise.
4506         * symtab.h (demangle): Likewise.
4507         (basenames_may_differ): Likewise.
4508         * target-dcache.c (stack_cache_enabled_1): Likewise.
4509         (code_cache_enabled_1): Likewise.
4510         * target.c (trust_readonly): Likewise.
4511         (may_write_registers): Likewise.
4512         (may_write_memory): Likewise.
4513         (may_insert_breakpoints): Likewise.
4514         (may_insert_tracepoints): Likewise.
4515         (may_insert_fast_tracepoints): Likewise.
4516         (may_stop): Likewise.
4517         (auto_connect_native_target): Likewise.
4518         (target_stop_and_wait): Update.
4519         (target_async_permitted): Change to bool.
4520         (target_async_permitted_1): Likewise.
4521         (may_write_registers_1): Likewise.
4522         (may_write_memory_1): Likewise.
4523         (may_insert_breakpoints_1): Likewise.
4524         (may_insert_tracepoints_1): Likewise.
4525         (may_insert_fast_tracepoints_1): Likewise.
4526         (may_stop_1): Likewise.
4527         * target.h (target_async_permitted): Likewise.
4528         (may_write_registers): Likewise.
4529         (may_write_memory): Likewise.
4530         (may_insert_breakpoints): Likewise.
4531         (may_insert_tracepoints): Likewise.
4532         (may_insert_fast_tracepoints): Likewise.
4533         (may_stop): Likewise.
4534         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4535         (make_thread_apply_all_options_def_group): Change argument from int*
4536         to bool*.
4537         (thread_apply_all_command): Update.
4538         (print_thread_events): Change to bool.
4539         * top.c (confirm): Likewise.
4540         (command_editing_p): Likewise.
4541         (history_expansion_p): Likewise.
4542         (write_history_p): Likewise.
4543         (info_verbose): Likewise.
4544         * top.h (confirm): Likewise.
4545         (history_expansion_p): Likewise.
4546         * tracepoint.c (disconnected_tracing): Likewise.
4547         (circular_trace_buffer): Likewise.
4548         * typeprint.c (print_methods): Likewise.
4549         (print_typedefs): Likewise.
4550         * utils.c (debug_timestamp): Likewise.
4551         (sevenbit_strings): Likewise.
4552         (pagination_enabled): Likewise.
4553         * utils.h (sevenbit_strings): Likewise.
4554         (pagination_enabled): Likewise.
4555         * valops.c (overload_resolution): Likewise.
4556         * valprint.h (struct value_print_options) <prettyformat_arrays,
4557         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4558         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4559         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4560         Likewise.
4561         * windows-nat.c (new_console): Likewise.
4562         (cygwin_exceptions): Likewise.
4563         (new_group): Likewise.
4564         (debug_exec): Likewise.
4565         (debug_events): Likewise.
4566         (debug_memory): Likewise.
4567         (debug_exceptions): Likewise.
4568         (useshell): Likewise.
4569         * windows-tdep.c (maint_display_all_tib): Likewise.
4570         * xml-support.c (debug_xml): Likewise.
4571
4572 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4573
4574         * source.c (prepare_path_for_appending): New function.
4575         (openp): Make use of new function.
4576         (find_and_open_source): Search for the compilation directory and
4577         source file as a relative path beneath the directory search path.
4578
4579 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4580
4581         * source-cache.c (source_cache::get_line_charpos): Catch
4582         exceptions and return false, this matches the behaviour documented
4583         in the header file.
4584
4585 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4586
4587         * ada-tasks.c (info_task): Remove quoting of the task's name.
4588
4589 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4590
4591         * symfile.c (auto_solib_add): Replace comment with a reference
4592         to the header file.
4593
4594 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4595
4596         * NEWS: Mention that gdb can now be compiled with Python 3
4597         on Windows.
4598
4599 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4600
4601         * maint.c (maint_print_section_data::maint_print_section_data):
4602         Force use of 'float log10 (float)' by casting the argument to
4603         float.
4604
4605 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4606
4607         * maint.c: Add 'cmath' include.
4608         (struct maint_print_section_data): New structure.
4609         (print_section_index): New function.
4610         (print_bfd_section_info): Add header comment, small whitespace
4611         cleanup, and update to call new print_section_index function.
4612         (print_objfile_section_info): Likewise.
4613         (maint_obj_section_from_bfd_section): New function.
4614         (print_bfd_section_info_maybe_relocated): New function.
4615         (maintenance_info_sections): Add header comment, always use
4616         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4617
4618 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4619
4620         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4621         inner scope, add check that the objfile has psymtabs before
4622         checking psymtabs_addrmap.
4623         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4624
4625 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4626
4627         * NEWS: Announce that Ada task names are now shown at more places,
4628         and between quotes (except in info task output).
4629         * gdb/ada-tasks.c (task_to_str): New function.
4630         (display_current_task_id): Call task_to_str.
4631         (task_command_1): Likewise.
4632         (print_ada_task_info): In non-mi mode, Properly align headers and data
4633         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4634
4635 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4636
4637         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4638         prstatus.pr_lwp.pr_info instead of making it up.
4639
4640 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4641
4642         * auto-load.c (auto_load_expand_dir_vars): Update.
4643         * defs.h (gdb_datadir): Change to std::string.
4644         (python_libdir): Likewise.
4645         (relocate_gdb_directory): Change return type to std::string.
4646         * guile/guile.c (gdbscm_data_directory): Update.
4647         (initialize_scheme_side): Update.
4648         * jit.c (jit_reader_dir): Change to std::string.
4649         (jit_reader_load_command): Update.
4650         * main.c (gdb_datadir): Change to std::string.
4651         (python_libdir): Likewise.
4652         (set_gdb_data_directory): Update.
4653         (relocate_path): Change to return std::string.
4654         (relocate_gdb_directory): Change to return std::string.
4655         (relocate_gdbinit_path_maybe_in_datadir): Update.
4656         (captured_main_1): Update.
4657         * python/python.c (do_start_initialization): Update.
4658         * top.c (show_gdb_datadir): Update.
4659         * xml-syscall.c (xml_init_syscalls_info): Update.
4660         (init_syscalls_info): Update.
4661
4662 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4663
4664         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4665         out of get_init_files.
4666         (get_init_files): Update.
4667
4668 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4669
4670         * main.c (get_init_files): Change to use std::string.
4671         (captured_main_1): Update.
4672         (print_gdb_help): Update.
4673
4674 2019-09-11  Ali Tamur  <tamur@google.com>
4675
4676         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4677         implementation.
4678
4679 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4680
4681         * dbxread.c (read_dbx_symtab): Update.
4682         * dwarf2read.c (load_partial_dies): Update.
4683         * mdebugread.c (parse_partial_symbols): Update.
4684         (handle_psymbol_enumerators): Update.
4685         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4686         * psymtab.c (add_psymbol_to_bcache): Likewise.
4687         (add_psymbol_to_list): Likewise.
4688         * symtab.c (symbol_set_names): Likewise.
4689         * symtab.h (symbol_set_names): Likewise.
4690         * xcoffread.c (scan_xcoff_symtab): Update.
4691
4692 2019-09-11  Tom Tromey  <tom@tromey.com>
4693
4694         * symfile-mem.c (symbol_file_add_from_memory): Use
4695         bfd_set_filename.
4696         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4697         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4698
4699 2019-09-10  Tom Tromey  <tromey@adacore.com>
4700
4701         * dwarf-index-write.c (write_psymbols): Extend error message.
4702         (debug_names::insert): Add Ada code.
4703         (debug_names::write_psymbols): Remove Ada check.
4704         (debug_names) <m_string_obstack>: New member.
4705         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4706         (gdb_index_symbol_name_matcher::matches): Remove.
4707         (mapped_index_base::find_name_components_bounds): Add "lang"
4708         parameter.
4709         (mapped_index_base::build_name_components): Also split names
4710         according to Ada syntax.
4711         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4712         type of "match_callback".
4713         (check_match, check_find_bounds_finds)
4714         (dw2_expand_symtabs_matching): Update.
4715         (dw2_debug_names_iterator): Add new constructor.
4716         (dw2_debug_names_map_matching_symbols): New function.
4717         (dw2_debug_names_expand_symtabs_matching): Update.
4718         (dwarf2_debug_names_functions): Use
4719         dw2_debug_names_map_matching_symbols.
4720
4721 2019-09-10  Tom Tromey  <tromey@adacore.com>
4722
4723         * dwarf2read.c (dw2_get_file_names_reader): Add the
4724         CU's file name to the results.
4725
4726 2019-09-10  Tom Tromey  <tromey@adacore.com>
4727
4728         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4729         map_matching_symbols.  Update.
4730         * dwarf2read.c (dw2_map_matching_symbols): Update.
4731         * psymtab.c (match_partial_symbol): Change type; update.
4732         (psym_map_matching_symbols): Likewise.
4733         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4734         type; update.
4735         * symfile.h (struct quick_symbol_functions)
4736         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4737         Remove "match".
4738
4739 2019-09-10  Tom Tromey  <tromey@adacore.com>
4740
4741         * psymtab.c (map_block): Remove.
4742         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4743         * symtab.c (iterate_over_symbols_terminated): New function.
4744         * symtab.c (iterate_over_symbols_terminated): Declare.
4745
4746 2019-09-10  Tom Tromey  <tromey@adacore.com>
4747
4748         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4749         * language.h (struct language_defn) <la_iterate_over_symbols>:
4750         Return bool.
4751         * symtab.c (iterate_over_symbols): Return bool.
4752         * symtab.h (iterate_over_symbols): Return bool.
4753
4754 2019-09-10  Tom Tromey  <tromey@adacore.com>
4755
4756         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4757         (add_nonlocal_symbols): Update.
4758         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4759         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4760         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4761         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4762         Change type of "callback".  Remove "data".
4763
4764
4765 2019-09-09  Ali Tamur  <tamur@google.com>
4766
4767         * dwarf2read.c (comp_unit_head): Update comment.
4768         (dwarf2_dwo_name): New function declaration.
4769         (dwarf_unit_type_name): New function declaration.
4770         (read_comp_unit_head): Add support for new compilation units,
4771         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4772         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4773         (currently named as "signature") in their header. Also clarify error
4774         messages.
4775         (lookup_dwo_id): New function. Returns the dwo id of the given
4776         compile unit.
4777         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4778         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4779         functions.
4780         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4781         (dwarf2_dwo_name): Get the dwo name if present.
4782         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4783         purposes.
4784
4785 2019-09-09  Tom Tromey  <tom@tromey.com>
4786
4787         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4788
4789 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4790
4791         * python/python.c (do_start_initialization): Make progname_copy static,
4792         to avoid a leak report.
4793
4794 2019-09-08  Tom Tromey  <tom@tromey.com>
4795
4796         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4797
4798 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4799
4800         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4801         Change type to gdb::optional<block_enum>.
4802         (dw2_symtab_iter_init): Change block_index parameter type
4803         to gdb::optional<block_enum>.
4804         (dw2_lookup_symbol): Change block_index parameter
4805         type to block_enum.c
4806         (dw2_debug_names_lookup_symbol): Likewise.
4807         * psymtab.c (psym_lookup_symbol): Likewise.
4808         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4809         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4810         Likewise.
4811
4812 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4813
4814         * defs.h (relocate_gdb_directory): Change int to bool in
4815         signature and rename flag to relocatable.
4816         * main.c (relocate_path): Likewise.
4817         (relocate_gdb_directory): Likewise.
4818
4819 2019-09-06  Alan Modra  <amodra@gmail.com>
4820
4821         * coffread.c (coff_symfile_read): Constify filename variable.
4822         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4823         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4824         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4825         * solib.c (reload_shared_libraries_1): Likewise.
4826         * symfile.c (reread_symbols): Likewise.
4827         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4828         * solib-darwin.c (darwin_bfd_open): Likewise.
4829         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4830
4831 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4832
4833         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4834         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4835
4836 2019-09-03  Tom Tromey  <tromey@adacore.com>
4837
4838         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4839         types.
4840         (has_negatives): Unbias a range type bound.
4841         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4842         * gdbtypes.c (operator==): Handle new field.
4843         (create_range_type): Add "bias" parameter.
4844         (create_static_range_type, resolve_dynamic_range): Update.
4845         * gdbtypes.h (struct range_bounds) <bias>: New member.
4846         (create_range_type): Add bias parameter.
4847         * printcmd.c (print_scalar_formatted): Unbias range types.
4848         * value.c (unpack_long): Unbias range types.
4849         (pack_long): Bias range types.
4850
4851 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4852
4853         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4854         probe arguments.
4855
4856 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4857
4858         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4859         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4860         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4861         (compile_probe_arg): Likewise.
4862         * probe.h (get_argument_count): Likewise.
4863         * solib-svr4.c (solib_event_probe_action): Likewise.
4864         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4865
4866 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4867
4868         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4869         code to here...
4870         (svr4_create_solib_event_breakpoints): ...from here.
4871
4872 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4873
4874         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4875         suffix from warning message.
4876
4877 2019-08-30  Tom Tromey  <tom@tromey.com>
4878
4879         * tui/tui-winsource.h (struct tui_source_window_base)
4880         <refresh_all>: Don't declare.
4881         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4882         Remove.
4883         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4884         tui_show_locator_content.
4885         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4886         declare.
4887         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4888         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4889         declare.
4890
4891 2019-08-30  Tom Tromey  <tom@tromey.com>
4892
4893         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4894
4895 2019-08-30  Tom Tromey  <tom@tromey.com>
4896
4897         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4898         Remove unnecessary forward declarations.
4899
4900 2019-08-30  Tom Tromey  <tom@tromey.com>
4901
4902         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4903         rerender.
4904         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4905         tui_show_locator_content.
4906
4907 2019-08-30  Tom Tromey  <tom@tromey.com>
4908
4909         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4910         (tui_locator_window::rerender): Rewrite using body of previous
4911         tui_show_locator_content.
4912
4913 2019-08-30  Tom Tromey  <tom@tromey.com>
4914
4915         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4916         set_locator_fullname>: New methods.
4917         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4918         Rename from tui_set_locator_fullname.
4919         (tui_locator_window::set_locator_info): Rename from
4920         tui_set_locator_info.  Return bool.
4921         (tui_update_locator_fullname, tui_show_frame_info): Update.
4922
4923 2019-08-30  Tom Tromey  <tom@tromey.com>
4924
4925         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4926
4927 2019-08-30  Tom Tromey  <tom@tromey.com>
4928
4929         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4930         call touchwin.
4931
4932 2019-08-30  Tom Tromey  <tom@tromey.com>
4933
4934         * tui/tui-wingeneral.c (box_win): Assume win_info and
4935         win_info->handle cannot be NULL.
4936
4937 2019-08-30  Tom Tromey  <tom@tromey.com>
4938
4939         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4940         refresh_window>: Declare.
4941         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4942         resize.
4943         (tui_data_item_window::rerender): Rename from
4944         tui_display_register.
4945         (tui_data_item_window::refresh_window): New method.
4946         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4947         no-op.
4948
4949 2019-08-30  Tom Tromey  <tom@tromey.com>
4950
4951         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4952         regs_column_count, current_group>: Move later.  Now private.
4953         <get_current_group>: New method.
4954         * tui/tui-regs.c (tui_reg_command): Update.
4955         * tui/tui-layout.c (tui_set_layout): Update.
4956
4957 2019-08-30  Tom Tromey  <tom@tromey.com>
4958
4959         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4960         (tui_data_window::rerender): Don't call
4961         check_and_display_highlight_if_needed.
4962         (tui_data_window::refresh_all): Remove call to
4963         erase_data_content.
4964
4965 2019-08-30  Tom Tromey  <tom@tromey.com>
4966
4967         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4968         (tui_data_window::display_registers_from)
4969         (tui_data_window::display_reg_element_at_line)
4970         (tui_data_window::display_registers_from_line): Remove checks of
4971         "empty".
4972
4973 2019-08-30  Tom Tromey  <tom@tromey.com>
4974
4975         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4976         Don't declare.
4977         * tui/tui-regs.c (tui_data_window::show_registers): Call
4978         rerender.
4979         (tui_data_window::rerender): Rename from display_all_data.
4980         (tui_data_window::rerender): Remove old implementation.
4981
4982 2019-08-30  Tom Tromey  <tom@tromey.com>
4983
4984         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4985         text.
4986         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4987
4988 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4989             Sergio Durigan Junior  <sergiodj@redhat.com>
4990
4991         PR win32/24284
4992         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4993
4994 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4995
4996         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4997         when searching for types.
4998
4999 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5000
5001         * f-lang.c (f_language_defn): Use f_print_typedef.
5002         * f-lang.h (f_print_typedef): Declare.
5003         * f-typeprint.c (f_print_typedef): Define.
5004
5005 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5006
5007         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5008
5009 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5010
5011         * cli/cli-utils.c (info_print_options_defs): Delete.
5012         (make_info_print_options_def_group): Delete.
5013         (extract_info_print_options): Delete.
5014         (info_print_command_completer): Delete.
5015         (info_print_args_help): Add extra parameter, and optionally
5016         include text about -n flag.
5017         * cli/cli-utils.h (struct info_print_options): Delete.
5018         (extract_info_print_options): Delete declaration.
5019         (info_print_command_completer): Delete declaration.
5020         (info_print_args_help): Add extra parameter, extend header
5021         comment.
5022         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5023         search_symbols.
5024         * stack.c (struct info_print_options): New type.
5025         (info_print_options_defs): New file scoped variable.
5026         (make_info_print_options_def_group): New static function.
5027         (info_print_command_completer): New static function.
5028         (info_locals_command): Update to use new local functions.
5029         (info_args_command): Likewise.
5030         (_initialize_stack): Add extra parameter to calls to
5031         info_print_args_help.
5032         * symtab.c (search_symbols): Add extra parameter, use this to
5033         possibly excluse non-debug symbols.
5034         (symtab_symbol_info): Add extra parameter, which is passed on to
5035         search_symbols.
5036         (struct info_print_options): New type.
5037         (info_print_options_defs): New file scoped variable.
5038         (make_info_print_options_def_group): New static function.
5039         (info_print_command_completer): New static function.
5040         (info_variables_command): Update to use local functions, and pass
5041         extra parameter through to symtab_symbol_info.
5042         (info_functions_command): Likewise.
5043         (info_types_command): Pass additional argument through to
5044         symtab_symbol_info.
5045         (rbreak_command): Pass extra argument to search_symbols.
5046         (_initialize_symtab): Add extra arguments for calls to
5047         info_print_args_help, and update help text for 'info variables',
5048         'whereis', and 'info functions' commands.
5049         * symtab.h (search_symbols): Add extra argument to declaration.
5050         * NEWS: Mention new flags.
5051
5052 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5053
5054         * symtab.c (lookup_static_symbol): Call the new function (and move
5055         it down to be next to lookup_global_symbol).
5056         (struct global_sym_lookup_data): Add block_enum member and rename to...
5057         (struct global_or_static_sym_lookup_data): ...this.
5058         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5059         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5060         (lookup_symbol_global_or_static_iterator_cb): ...this.
5061         (lookup_global_or_static_symbol): New function.
5062         (lookup_global_symbol): Call new function.
5063
5064 2019-08-26  Tom de Vries  <tdevries@suse.de>
5065
5066         PR c++/24852
5067         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5068         when pc_probe.prob == NULL.
5069
5070 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5071
5072         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5073         variable symbol_linkage to symbol_linkage_.
5074
5075 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5076
5077         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5078         represent whether the symbol is static, dynamic, or we don't
5079         know.
5080
5081 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5082
5083         * gdb/rx-tdep.c (rx_register_names): New.
5084         (rx_register_name): Delete.
5085         (rx_psw_type): Delete.
5086         (rx_fpsw_type): Delete.
5087         (rx_register_type): Delete.
5088         (rx_gdbarch_init): Convert target-descriptions.
5089         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5090         * gdb/features/Makefile: Add rx.xml.
5091         * gdb/features/rx.xml: New.
5092         * gdb/features/rx.c: Generated.
5093         * gdb/NEWS: Mention target description support.
5094
5095 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5096
5097         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5098         *slot_ptr.
5099
5100 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5101
5102         * configure.ac: Don't check for 'dlfcn.h' (moved to
5103         gdbsupport/common.m4).
5104         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5105         'gdbsupport/'.
5106         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5107         * compile/compile-c-support.c: Include
5108         'gdbsupport/gdb-dlfcn.h'.
5109         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5110         * gdb-dlfcn.c: Move to...
5111         * gdbsupport/gdb-dlfcn.c: ... here.
5112         * gdb-dlfcn.h: Move to...
5113         * gdbsupport/gdb-dlfcn.h: ... here.
5114
5115 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5116
5117         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5118         the offset field signed.
5119
5120 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5121
5122         * python/lib/gdb/__init__.py (_execute_file): New function.
5123         * python/python.c (python_run_simple_file): Call gdb._execute_file
5124         on Windows.
5125
5126 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5127
5128         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5129         all uses as this was never set to anything but a zero value.
5130
5131 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5132
5133         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5134
5135 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5136
5137         * tui/tui-data.h (tui_gen_win_info): Add an =default
5138         move constructor, required by some GCC versions.
5139
5140 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5141
5142         * go32-nat.c (go32_sysinfo): Add hygon_p.
5143
5144 2019-08-20  Tom Tromey  <tom@tromey.com>
5145
5146         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5147         line_from_reg_element_no, first_reg_element_no_inline,
5148         display_all_data, delete_data_content_windows,
5149         erase_data_content>: Now private.
5150
5151 2019-08-20  Tom Tromey  <tom@tromey.com>
5152
5153         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5154         (tui_unhighlight_win, tui_highlight_win)
5155         (tui_win_info::make_window): Update.
5156         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5157
5158 2019-08-20  Tom Tromey  <tom@tromey.com>
5159
5160         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5161         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5162         (MAX_PID_WIDTH): Move to tui-stack.c.
5163         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5164         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5165         (MAX_PID_WIDTH): Move from tui-data.h.
5166
5167 2019-08-20  Tom Tromey  <tom@tromey.com>
5168
5169         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5170         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5171         (box_win): Update.
5172         (tui_gen_win_info::make_window): Rename from tui_make_window.
5173         (tui_win_info::make_window): New method.
5174         (tui_gen_win_info::make_visible): Update.
5175         * tui/tui-source.c (tui_source_window::set_contents): Update.
5176         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5177         (tui_data_window::display_registers_from): Update.
5178         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5179         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5180         Declare.
5181         <can_box>: Remove.
5182         <title>: Remove.
5183         (struct tui_win_info) <make_window>: Declare.
5184         <can_box>: Now virtual.
5185         <title>: New member.
5186         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5187         * tui/tui-command.c (tui_cmd_window::resize): Update.
5188
5189 2019-08-20  Tom Tromey  <tom@tromey.com>
5190
5191         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5192         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5193         (tui_data_window::check_register_values): Update.
5194
5195 2019-08-20  Tom Tromey  <tom@tromey.com>
5196
5197         * tui/tui-regs.h (struct tui_data_window): Use
5198         DISABLE_COPY_AND_ASSIGN.
5199         <regs_content>: Change type, removing unique_ptr.
5200         <tui_data_window>: Add move constructor.
5201         * tui/tui-regs.c (tui_data_window::show_registers)
5202         (tui_data_window::show_register_group)
5203         (tui_data_window::display_registers_from)
5204         (tui_data_window::display_registers_from)
5205         (tui_data_window::first_data_item_displayed)
5206         (tui_data_window::delete_data_content_windows)
5207         (tui_data_window::rerender, tui_data_window::refresh_window)
5208         (tui_data_window::check_register_values): Update.
5209
5210 2019-08-20  Tom Tromey  <tom@tromey.com>
5211
5212         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5213         show_register_group>: Declare.
5214         (tui_show_register_group): Don't declare.
5215         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5216         tui_show_registers.
5217         (tui_data_window::show_register_group): Rename from
5218         tui_show_register_group.
5219         (tui_data_window::check_register_values, tui_reg_command):
5220         Update.
5221         * tui/tui-layout.c (tui_set_layout): Update.
5222
5223 2019-08-20  Tom Tromey  <tom@tromey.com>
5224
5225         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5226         Declare.
5227         (tui_check_register_values): Don't declare.
5228         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5229         from tui_check_register_values.
5230         * tui/tui-hooks.c (tui_register_changed): Update.
5231
5232 2019-08-20  Tom Tromey  <tom@tromey.com>
5233
5234         * tui/tui-regs.c (tui_reg_layout): Move later.
5235         (tui_show_registers): Don't enable TUI mode or change layout.
5236
5237 2019-08-20  Tom Tromey  <tom@tromey.com>
5238
5239         * tui/tui-regs.h (struct tui_data_item_window)
5240         <~tui_data_item_window>: Remove.
5241         <content>: Now a unique_xmalloc_ptr.
5242         * tui/tui-regs.c (tui_register_format): Return a
5243         unique_xmalloc_ptr.
5244         (tui_get_register): Update.
5245         (~tui_data_item_window): Remove.
5246         (tui_data_window::display_registers_from, tui_display_register):
5247         Update.
5248         * tui/tui-io.h (tui_expand_tabs): Update.
5249         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5250         Remove "col" parameter.
5251
5252 2019-08-20  Tom Tromey  <tom@tromey.com>
5253
5254         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5255         field.
5256         * tui/tui-regs.c (~tui_data_item_window): Update.
5257
5258 2019-08-20  Tom Tromey  <tom@tromey.com>
5259
5260         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5261         earlier.
5262
5263 2019-08-20  Tom Tromey  <tom@tromey.com>
5264
5265         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5266
5267 2019-08-20  Tom Tromey  <tom@tromey.com>
5268
5269         * tui/tui-source.h (struct tui_source_window): Update.
5270         * tui/tui-regs.c (tui_show_registers): Update.
5271         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5272         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5273         (NO_REGS_STRING): Remove defines.
5274
5275 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5276
5277         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5278         unnecessary thread walk if remote doesn't support the packet.
5279
5280 2019-08-19  Tom Tromey  <tromey@adacore.com>
5281
5282         * python/py-value.c (value_has_field): Fix indentation.
5283
5284 2019-08-19  Tom Tromey  <tromey@adacore.com>
5285
5286         * printcmd.c (do_one_display, info_display_command): Update.
5287         * block.h (contained_in): Return bool.  Add allow_nested
5288         parameter.
5289         * block.c (contained_in): Return bool.  Add allow_nested
5290         parameter.
5291
5292 2019-08-19  Tom Tromey  <tom@tromey.com>
5293
5294         * configure: Rebuild.
5295         * configure.ac: Disallow the combination of -static-libstdc++ and
5296         source highlight.
5297         * source-cache.c (get_language_name): Handle rust.
5298         (source_cache::get_source_lines): Ignore highlighting exceptions.
5299
5300 2019-08-16  Tom Tromey  <tom@tromey.com>
5301
5302         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5303         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5304         (struct tui_source_window_base) <make_visible, refresh_window,
5305         resize>: Remove methods.
5306         <execution_info>: Remove field.
5307         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5308         (tui_show_source_line, tui_source_window_base)
5309         (~tui_source_window_base): Update.
5310         (tui_source_window_base::resize)
5311         (tui_source_window_base::make_visible)
5312         (tui_source_window_base::refresh_window): Remove.
5313         (tui_source_window_base::update_exec_info): Update.
5314         * tui/tui-source.c (tui_source_window::set_contents): Update.
5315         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5316
5317 2019-08-16  Tom Tromey  <tom@tromey.com>
5318
5319         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5320         deprecated_query_hook.
5321
5322 2019-08-16  Tom Tromey  <tom@tromey.com>
5323
5324         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5325         (tui_update_source_windows_with_line): Update.
5326         * tui/tui-source.h (struct tui_source_window)
5327         <show_symtab_source>: Declare.
5328         (tui_show_symtab_source): Don't declare.
5329         * tui/tui-source.c (tui_show_symtab_source): Rename from
5330         tui_show_symtab_source.
5331
5332 2019-08-16  Tom Tromey  <tom@tromey.com>
5333
5334         * tui/tui-winsource.h (struct tui_source_window_base)
5335         <set_contents>: Declare.
5336         * tui/tui-winsource.c
5337         (tui_source_window_base::update_source_window_as_is): Update.
5338         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5339         Declare.
5340         (tui_set_source_content): Don't declare.
5341         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5342         tui_set_source_content.
5343         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5344         Declare.
5345         (tui_set_disassem_content): Don't declare.
5346         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5347         tui_set_disassem_content.
5348
5349 2019-08-16  Tom Tromey  <tom@tromey.com>
5350
5351         * tui/tui-winsource.h (struct tui_source_window_base)
5352         <update_breakpoint_info>: Declare.
5353         (tui_update_breakpoint_info): Don't declare.
5354         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5355         (tui_update_all_breakpoint_info): Update.
5356         (tui_source_window_base::update_breakpoint_info): Rename from
5357         tui_update_breakpoint_info.
5358         (tui_source_window_base::update_exec_info): Update.
5359
5360 2019-08-16  Tom Tromey  <tom@tromey.com>
5361
5362         * tui/tui-winsource.h (struct tui_source_window_base)
5363         <update_source_window>: Declare.
5364         (tui_update_source_window): Don't declare.
5365         * tui/tui-winsource.c
5366         (tui_source_window_base::update_source_window): Rename from
5367         tui_update_source_window.
5368         (tui_source_window_base::rerender): Update.
5369         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5370         * tui/tui-disasm.c (tui_show_disassem)
5371         (tui_show_disassem_and_update_source)
5372         (tui_disasm_window::maybe_update): Update.
5373
5374 2019-08-16  Tom Tromey  <tom@tromey.com>
5375
5376         * tui/tui-winsource.h (struct tui_source_window_base)
5377         <update_source_window_as_is>: Declare.
5378         (tui_update_source_window_as_is): Don't declare.
5379         * tui/tui-winsource.c (tui_update_source_window): Update
5380         (tui_source_window_base::update_source_window_as_is): Rename from
5381         tui_update_source_window_as_is.
5382         (tui_source_window_base::refill): Update.
5383         * tui/tui-source.c (tui_show_symtab_source): Update.
5384         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5385         Update.
5386
5387 2019-08-16  Tom Tromey  <tom@tromey.com>
5388
5389         * tui/tui-winsource.h (tui_update_source_window)
5390         (tui_update_source_window_as_is): Remove "noerror" parameter.
5391         * tui/tui-winsource.c (tui_update_source_window)
5392         (tui_update_source_window_as_is): Remove "noerror" parameter.
5393         (tui_update_source_windows_with_addr)
5394         (tui_update_source_windows_with_line)
5395         (tui_source_window_base::rerender)
5396         (tui_source_window_base::refill): Update.
5397         * tui/tui-source.h (tui_set_source_content)
5398         (tui_show_symtab_source): Remove "noerror" parameter.
5399         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5400         parameter.
5401         (tui_show_symtab_source): Likewise.
5402         (tui_source_window::maybe_update): Update.
5403         * tui/tui-disasm.c (tui_show_disassem)
5404         (tui_show_disassem_and_update_source)
5405         (tui_disasm_window::do_scroll_vertical)
5406         (tui_disasm_window::maybe_update): Update.
5407
5408 2019-08-16  Tom Tromey  <tom@tromey.com>
5409
5410         * tui/tui.c (tui_is_window_visible): Update.
5411         * tui/tui-wingeneral.c (tui_make_window)
5412         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5413         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5414         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5415         (tui_set_win_height_command, parse_scrolling_args): Update.
5416         * tui/tui-source.c (tui_source_window::style_changed): Update.
5417         * tui/tui-regs.c (tui_show_registers)
5418         (tui_data_window::first_data_item_displayed)
5419         (tui_data_window::delete_data_content_windows)
5420         (tui_check_register_values, tui_reg_command): Update.
5421         * tui/tui-disasm.c (tui_show_disassem): Update.
5422         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5423         method.
5424         <is_visible>: Remove field.
5425         * tui/tui-data.c (tui_next_win, tui_prev_win)
5426         (tui_delete_invisible_windows): Update.
5427
5428 2019-08-16  Tom Tromey  <tom@tromey.com>
5429
5430         * tui/tui-winsource.h (struct tui_source_window_base)
5431         <m_has_locator>: Remove.
5432         * tui/tui-layout.c (show_source_disasm_command, show_data)
5433         (show_source_or_disasm_and_command): Update.
5434
5435 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5436
5437         * NEWS (Other MI changes): New subsection.
5438         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5439         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5440         * arch-utils.c (default_get_pc_address_flags): New function.
5441         * arch-utils.h (default_get_pc_address_flags): New declaration.
5442         * gdbarch.sh: Add get_pc_address_flags.
5443         * gdbarch.c: Regenerate.
5444         * gdbarch.h: Likewise.
5445         * stack.c (print_pc): New function.
5446         (print_frame_info) (print_frame): Call print_pc.
5447
5448 2019-08-16  Tom de Vries  <tdevries@suse.de>
5449
5450         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5451         print_objfile_section_info.
5452
5453 2019-08-15  Tom Tromey  <tom@tromey.com>
5454
5455         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5456         calling update_cmdwin_start_line.
5457         * tui/tui-winsource.h (struct tui_source_window_base)
5458         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5459         <rerender>: Declare.
5460         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5461         Call rerender.
5462         (tui_source_window_base::set_new_height): Remove.
5463         (tui_source_window_base::rerender): Rename from
5464         do_make_visible_with_new_height.
5465         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5466         resize method.
5467         (tui_win_info::make_invisible_and_set_new_height)
5468         (tui_win_info::make_visible_with_new_height): Remove.
5469         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5470         Declare.
5471         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5472         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5473         do_make_visible_with_new_height>: Don't declare.
5474         <rerender>: Declare.
5475         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5476         set_new_height.
5477         (tui_data_window::do_make_visible_with_new_height): Remove.
5478         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5479         call tui_show_locator_content.
5480         (tui_gen_win_info::resize): Call rerender.
5481         (show_source_or_disasm_and_command): Don't call
5482         tui_show_locator_content.
5483         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5484         method.
5485         (struct tui_win_info) <rerender>: Declare.
5486         <set_new_height, make_invisible_and_set_new_height,
5487         make_visible_with_new_height>: Don't declare.
5488         * tui/tui-data.c (tui_win_list::rerender): New method.
5489         * tui/tui-command.h (struct tui_cmd_window)
5490         <do_make_visible_with_new_height>: Don't declare.
5491         * tui/tui-command.c
5492         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5493
5494 2019-08-15  Tom Tromey  <tromey@adacore.com>
5495
5496         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5497         * ada-lang.c (ada_enum_name): Likewise.
5498
5499 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5500
5501         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5502         leading underscore.
5503         (GdbOutputErrorFile): Likewise.
5504         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5505         accordingly.
5506         (execute_unwinders): Rename to have a leading underscore.
5507         (auto_load_packages): Likewise.
5508         (global scope): Adjust call to auto_load_packages accordingly.
5509         (GdbSetPythonDirectory): Likewise.
5510         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5511         instead of execute_unwinders.
5512
5513 2019-08-15  Tom Tromey  <tom@tromey.com>
5514
5515         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5516         (show_data): Don't change window visibility.
5517         (tui_gen_win_info::resize): Remove special case for command
5518         window.  Use wresize, when available.
5519         (show_source_or_disasm_and_command): Don't change window
5520         visibility.
5521         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5522         <make_visible>: New method.
5523         * tui/tui-command.c (tui_cmd_window::resize): New method.
5524
5525 2019-08-15  Tom Tromey  <tom@tromey.com>
5526
5527         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5528         (struct tui_source_windows): New.
5529         * tui/tui-winsource.c (tui_display_main): Update.
5530         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5531         (new_height_ok, parse_scrolling_args): Update.
5532         * tui/tui-layout.c (show_layout, show_data): Update.
5533         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5534         (tui_add_to_source_windows): Don't declare.
5535         * tui/tui-data.c (source_windows, tui_source_windows)
5536         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5537
5538 2019-08-15  Tom Tromey  <tom@tromey.com>
5539
5540         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5541         Rename from reset.
5542         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5543         * tui/tui-layout.c (show_source_disasm_command, show_data):
5544         Update.
5545         (tui_gen_win_info::resize): Rename.
5546         (show_source_or_disasm_and_command): Update.
5547         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5548         reset.
5549
5550 2019-08-15  Tom Tromey  <tom@tromey.com>
5551
5552         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5553         * tui/tui-interp.c (tui_interp::init): Don't call
5554         tui_initialize_static_data.
5555         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5556
5557 2019-08-15  Tom Tromey  <tom@tromey.com>
5558
5559         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5560         examine tui_win_list.
5561
5562 2019-08-15  Tom Tromey  <tom@tromey.com>
5563
5564         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5565         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5566         tui_clear_source_content.
5567         (tui_clear_source_content): Remove.
5568         (tui_source_window_base::do_erase_source_content): Hoist call to
5569         content.clear().
5570         * tui/tui-stack.c (tui_show_frame_info): Don't call
5571         tui_clear_source_content.
5572
5573 2019-08-15  Tom Tromey  <tom@tromey.com>
5574
5575         * tui/tui-winsource.h (struct tui_source_window_base)
5576         <do_erase_source_content>: New method.
5577         <erase_source_content>: New method.
5578         (tui_erase_source_content): Don't declare.
5579         * tui/tui-winsource.c (tui_clear_source_content): Update.
5580         (tui_source_window_base::do_erase_source_content): Rename from
5581         tui_erase_source_content.
5582         (tui_source_window_base::show_source_content): Update.
5583         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5584         * tui/tui-source.h (struct tui_source_window)
5585         <erase_source_content>: New method.
5586         * tui/tui-disasm.h (struct tui_disasm_window)
5587         <erase_source_content>: New method.
5588
5589 2019-08-15  Tom Tromey  <tom@tromey.com>
5590
5591         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5592         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5593         constructor.
5594         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5595         * tui/tui-source.c (tui_set_source_content): Update.
5596         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5597
5598 2019-08-15  Tom Tromey  <tom@tromey.com>
5599
5600         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5601         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5602         tui-source.c.
5603         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5604         Declare.
5605         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5606         method.
5607         (tui_source_window::maybe_update): Update.
5608
5609 2019-08-15  Tom Tromey  <tom@tromey.com>
5610
5611         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5612         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5613         tui-disasm.c.
5614         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5615         Declare.
5616         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5617         method.
5618         (tui_disasm_window::maybe_update): Update.
5619
5620 2019-08-15  Tom Tromey  <tom@tromey.com>
5621
5622         * tui/tui-winsource.h (struct tui_source_window_base)
5623         <maybe_update>: Declare.
5624         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5625         method.
5626         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5627         Declare.
5628         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5629         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5630         Declare.
5631         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5632
5633 2019-08-15  Tom Tromey  <tom@tromey.com>
5634
5635         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5636
5637 2019-08-15  Tom Tromey  <tom@tromey.com>
5638
5639         * tui/tui-wingeneral.c: Include tui-stack.h.
5640         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5641         (struct tui_locator_window): Move from tui-data.h.
5642         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5643         (tui_initialize_static_data): Move from tui-data.c.
5644         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5645         (struct tui_locator_window): Move to tui-stack.c.
5646         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5647         (tui_initialize_static_data): Move to tui-stack.c.
5648
5649 2019-08-15  Tom Tromey  <tom@tromey.com>
5650
5651         * tui/tui-layout.c (show_source_disasm_command)
5652         (show_source_or_disasm_and_command): Use make_visible method, not
5653         tui_make_window.
5654         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5655         Remove.
5656
5657 2019-08-15  Tom Tromey  <tom@tromey.com>
5658
5659         * tui/tui-wingeneral.h (tui_make_window): Update.
5660         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5661         parameter.
5662         (tui_gen_win_info::make_visible): Update.
5663         * tui/tui-regs.c (tui_data_window::display_registers_from):
5664         Update.
5665         * tui/tui-layout.c (show_source_disasm_command)
5666         (show_source_or_disasm_and_command): Update.
5667         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5668         (enum tui_box): Remove.
5669         (struct tui_win_info) <can_box>: New method.
5670         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5671         method.
5672
5673 2019-08-15  Tom de Vries  <tdevries@suse.de>
5674
5675         * linux-nat-trad.c: Include gdbarch.h.
5676
5677 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5678
5679         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5680         register sizes.
5681
5682 2019-08-14  Tom Tromey  <tromey@adacore.com>
5683
5684         * darwin-nat.c: Include gdbarch.h.
5685         * darwin-nat-info.c: Include gdbarch.h.
5686
5687 2019-08-13  Tom Tromey  <tom@tromey.com>
5688
5689         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5690         Remove.
5691         * tui/tui-data.c (tui_initialize_static_data): Update.
5692
5693 2019-08-13  Tom Tromey  <tom@tromey.com>
5694
5695         * tui/tui-winsource.h (struct tui_exec_info_window)
5696         <~tui_exec_info_window, maybe_allocate_content, get_content,
5697         m_content>: Remove.
5698         (struct tui_source_window_base) <set_exec_info_content,
5699         show_exec_info_content>: Don't declare.
5700         * tui/tui-winsource.c
5701         (tui_exec_info_window::maybe_allocate_content): Remove.
5702         (tui_source_window_base::update_exec_info): Rename from
5703         set_exec_info_content.
5704         (tui_source_window_base::show_exec_info_content)
5705         (tui_source_window_base::update_exec_info): Remove.
5706
5707 2019-08-13  Tom Tromey  <tom@tromey.com>
5708
5709         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5710         declare.
5711         * tui/tui-winsource.c (tui_update_source_window_as_is)
5712         (tui_update_source_windows_with_addr, tui_erase_source_content):
5713         Update.
5714         (tui_clear_exec_info_content): Remove.
5715
5716 2019-08-13  Tom Tromey  <tom@tromey.com>
5717
5718         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5719         declare.
5720         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5721         call tui_erase_exec_info_content.
5722         (tui_clear_exec_info_content): Rename from
5723         tui_erase_exec_info_content.
5724         (tui_clear_exec_info_content): Delete.
5725
5726 2019-08-13  Tom Tromey  <tom@tromey.com>
5727
5728         * tui/tui-winsource.h (struct tui_source_window_base)
5729         <show_exec_info_content>: Declare.
5730         (tui_show_exec_info_content): Don't declare.
5731         * tui/tui-winsource.c
5732         (tui_source_window_base::show_exec_info_content): Rename from
5733         tui_show_exec_info_content.
5734         (tui_source_window_base::update_exec_info): Update.
5735
5736 2019-08-13  Tom Tromey  <tom@tromey.com>
5737
5738         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5739         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5740         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5741         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5742         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5743         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5744         ... here.
5745
5746 2019-08-13  Tom Tromey  <tom@tromey.com>
5747
5748         * tui/tui-winsource.h (struct tui_source_window_base)
5749         <update_exec_info>: Declare.
5750         (tui_update_exec_info): Don't declare.
5751         * tui/tui-winsource.c (tui_update_source_window_as_is)
5752         (tui_source_window_base::refresh_all)
5753         (tui_update_all_breakpoint_info): Update.
5754         (tui_source_window_base::update_exec_info): Rename from
5755         tui_update_exec_info.
5756         * tui/tui-stack.c (tui_show_frame_info): Update.
5757
5758 2019-08-13  Tom Tromey  <tom@tromey.com>
5759
5760         * tui/tui-winsource.h (struct tui_source_window_base)
5761         <set_exec_info_content>: Declare.
5762         (tui_set_exec_info_content): Don't declare.
5763         * tui/tui-winsource.c
5764         (tui_source_window_base::set_exec_info_content): Rename from
5765         tui_set_exec_info_content.
5766         (tui_update_exec_info): Update.
5767
5768 2019-08-13  Tom Tromey  <tom@tromey.com>
5769
5770         * tui/tui-winsource.h (struct tui_source_window_base)
5771         <show_source_content>: Declare.
5772         (tui_show_source_content): Don't declare.
5773         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5774         (tui_source_window_base::show_source_content): Rename from
5775         tui_show_source_content.
5776         (tui_source_window_base::refresh_all): Update.
5777         * tui/tui-layout.c (show_source_disasm_command)
5778         (show_source_or_disasm_and_command): Update.
5779
5780 2019-08-13  Tom Tromey  <tom@tromey.com>
5781
5782         * tui/tui-winsource.c (tui_erase_source_content)
5783         (tui_show_source_content, tui_source_window_base::refresh_all):
5784         Update.
5785         * tui/tui-wingeneral.h
5786         (tui_check_and_display_highlight_if_needed): Don't declare.
5787         * tui/tui-wingeneral.c
5788         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5789         check_and_display_highlight_if_needed.
5790         * tui/tui-win.c (tui_rehighlight_all)
5791         (tui_win_info::make_visible_with_new_height): Update.
5792         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5793         (tui_data_window::erase_data_content)
5794         (tui_data_window::display_all_data): Update.
5795         * tui/tui-data.h (struct tui_win_info)
5796         <check_and_display_highlight_if_needed>: Declare.
5797
5798 2019-08-13  Tom Tromey  <tom@tromey.com>
5799
5800         * tui/tui-win.c (tui_resize_all): Call
5801         tui_delete_invisible_windows.
5802         * tui/tui-layout.c (show_layout): Call
5803         tui_delete_invisible_windows.
5804         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5805         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5806
5807 2019-08-13  Tom Tromey  <tom@tromey.com>
5808
5809         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5810         tui_add_win_to_layout.
5811
5812 2019-08-13  Tom Tromey  <tom@tromey.com>
5813
5814         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5815         * tui/tui-layout.c (tui_default_win_height): Now static.
5816
5817 2019-08-13  Tom Tromey  <tom@tromey.com>
5818
5819         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5820         single switch.
5821         (show_source_disasm_command, show_source_or_disasm_and_command):
5822         Don't check current layout.
5823
5824 2019-08-13  Tom Tromey  <tom@tromey.com>
5825
5826         * tui/tui-wingeneral.c (make_all_visible): Remove.
5827         (tui_make_all_invisible): Simplify.
5828         * tui/tui-layout.c (tui_make_all_invisible): Move from
5829         tui-wingeneral.c; simplify.
5830         (show_layout): Hoist call to tui_make_all_invisible.
5831         (show_data): Don't call tui_make_all_invisible.
5832
5833 2019-08-13  Tom Tromey  <tom@tromey.com>
5834
5835         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5836         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5837
5838 2019-08-13  Tom Tromey  <tom@tromey.com>
5839
5840         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5841         tui-data.c.
5842         (show_source_disasm_command, show_data)
5843         (show_source_or_disasm_and_command): Don't use
5844         tui_set_current_layout_to.
5845         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5846         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5847         tui-layout.c.
5848         (tui_set_current_layout_to): Remove.
5849
5850 2019-08-13  Tom Tromey  <tom@tromey.com>
5851
5852         * tui/tui-layout.c (tui_set_layout): Update.
5853         * tui/tui-data.h (struct tui_layout_def): Remove.
5854         (tui_layout_def): Don't declare.
5855         * tui/tui-data.c (layout_def): Remove.
5856         (tui_layout_def): Remove.
5857
5858 2019-08-13  Tom Tromey  <tom@tromey.com>
5859
5860         * tui/tui-winsource.h (struct tui_source_window_base)
5861         <clear_detail>: No longer "override".
5862         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5863         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5864         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5865         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5866         Remove.
5867         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5868
5869 2019-08-13  Tom Tromey  <tromey@adacore.com>
5870
5871         * tracepoint.c: Don't include readline.h or history.h.
5872
5873 2019-08-12  Tom Tromey  <tom@tromey.com>
5874
5875         * configure: Rebuild.
5876         * configure.ac: Check for readline 7.
5877         * NEWS: Mention readline 7 requirement.
5878         * README: Update.
5879
5880 2019-08-12  Tom Tromey  <tom@tromey.com>
5881
5882         * mingw-hdep.c (gdb_select): Remove readline hack.
5883
5884 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5885
5886         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5887         when the function fails.
5888
5889 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5890
5891         * s390-tdep.c (s390_type_align): New function.
5892         (s390_gdbarch_init): Set it as type_align gdbarch method.
5893
5894 2019-08-09  Tom de Vries  <tdevries@suse.de>
5895
5896         PR gdb/24591
5897         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5898         pc_low with relocation offset.
5899
5900 2019-08-07  Tom Tromey  <tromey@adacore.com>
5901
5902         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5903         (print_frame_args): Update.
5904         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5905         Update.
5906         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5907         * frame.h (struct frame_arg): Add initializers.
5908         <error>: Now a unique_xmalloc_ptr.
5909
5910 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5911
5912         * NEWS: Expand the Pointer Authentication entry.
5913         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5914         (aarch64_frame_unmask_lr): ... to this.
5915         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5916         Call aarch64_frame_unmask_lr.
5917         * frame.c (struct frame_info): Add "masked" variable.
5918         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5919         (fprint_frame): Check for masked pc.
5920         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5921         declarations.
5922         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5923         * stack.c (print_frame): Check for masked pc.
5924
5925 2019-08-06  Tom Tromey  <tom@tromey.com>
5926
5927         * stabsread.c (patch_block_stabs, read_one_struct_field)
5928         (read_enum_type): Use obstack_strndup.
5929         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5930         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5931         * dwarf2read.c (guess_full_die_structure_name)
5932         (anonymous_struct_prefix): Use obstack_strndup.
5933         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5934         * c-exp.y (yylex): Use obstack_strndup.
5935         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5936         (write_var_or_type): Use obstack_strndup.
5937
5938 2019-08-06  Tom Tromey  <tom@tromey.com>
5939
5940         * symfile.c (reread_symbols): Use obstack_strdup.
5941         * stabsread.c (read_type): Use obstack_strdup.
5942         * gdb_obstack.h (obstack_strdup): New overload.
5943         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5944         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5945         (dwarf2_canonicalize_name): Use obstack_strdup.
5946         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5947         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5948         Use obstack_strdup.
5949
5950 2019-08-06  Tom Tromey  <tom@tromey.com>
5951
5952         * gdb_obstack.h (obstack_strdup): Define.
5953         * gdb_obstack.c (obstack_strdup): Don't define.
5954
5955 2019-08-06  Tom Tromey  <tom@tromey.com>
5956
5957         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5958         obstack_strdup.
5959         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5960         obstack_strdup.
5961         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5962         * stabsread.c (common_block_start): Use obstack_strdup.
5963         * objfiles.c (set_objfile_main_name, objfile): Use
5964         obstack_strdup.
5965         * namespace.c (add_using_directive): Use obstack_strdup.
5966         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5967         * jit.c (finalize_symtab): Use obstack_strdup.
5968         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5969         (guess_partial_die_structure_name, partial_die_info::fixup)
5970         (dwarf2_name): Use obstack_strdup.
5971         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5972         obstack_strdup.
5973         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5974         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5975         obstack_strdup.
5976         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5977
5978 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5979
5980         * unittests/help-doc-selftests.c: New file.
5981         * Makefile.in: Add the new file.
5982
5983 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5984
5985         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5986         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5987         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5988         the trailing '.' is not output, and the first character is uppercased.
5989         (print_help_for_command): Update call to print_doc_line.
5990         (print_doc_of_command): Likewise.
5991         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5992         * cli/cli-option.c (append_indented_doc): Do not append newline.
5993         (build_help_option): Append newline after first appended_indented_doc
5994         only if a second call is done.
5995         (build_help): Append 2 new lines before each option, except the first
5996         one.
5997         * compile/compile.c (_initialize_compile): Add new lines after
5998         %OPTIONS%, when not at the end of the help.
5999         Change help doc or code
6000         producing the help doc to respect the invariants.
6001         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6002         Also removed the new line after 'Options:', as all other commands
6003         do not put an empty line between 'Options:' and the first option.
6004         * printcmd.c (_initialize_printcmd): Likewise.
6005         * stack.c (_initialize_stack): Likewise.
6006         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6007         incorrectly telling COMMAND is optional.
6008         * ada-lang.c (_initialize_ada_language): Change help doc or code
6009         producing the help doc to respect the invariants.
6010         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6011         * breakpoint.c (_initialize_breakpoint): Likewise.
6012         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6013         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6014         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6015         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6016         _initialize_cli_style): Likewise.
6017         * corelow.c (core_target_info): Likewise.
6018         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6019         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6020         * filesystem.c (_initialize_filesystem): Likewise.
6021         * frame.c (_initialize_frame): Likewise.
6022         * gnu-nat.c (add_task_commands): Likewise.
6023         * infcall.c (_initialize_infcall): Likewise.
6024         * infcmd.c (_initialize_infcmd): Likewise.
6025         * interps.c (_initialize_interpreter): Likewise.
6026         * language.c (_initialize_language): Likewise.
6027         * linux-fork.c (_initialize_linux_fork): Likewise.
6028         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6029         * maint.c (_initialize_maint_cmds): Likewise.
6030         * memattr.c (_initialize_mem): Likewise.
6031         * printcmd.c (_initialize_printcmd): Likewise.
6032         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6033         _RegEx): Likewise.
6034         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6035         * record-btrace.c (_initialize_record_btrace): Likewise.
6036         * record-full.c (_initialize_record_full): Likewise.
6037         * record.c (_initialize_record): Likewise.
6038         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6039         * regcache.c (_initialize_regcache): Likewise.
6040         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6041         _initialize_remote): Likewise.
6042         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6043         * serial.c (_initialize_serial): Likewise.
6044         * skip.c (_initialize_step_skip): Likewise.
6045         * source.c (_initialize_source): Likewise.
6046         * stack.c (_initialize_stack): Likewise.
6047         * symfile.c (_initialize_symfile): Likewise.
6048         * symtab.c (_initialize_symtab): Likewise.
6049         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6050         * top.c (init_main): Likewise.
6051         * tracefile-tfile.c (tfile_target_info): Likewise.
6052         * tracepoint.c (_initialize_tracepoint): Likewise.
6053         * tui/tui-win.c (_initialize_tui_win): Likewise.
6054         * utils.c (add_internal_problem_command): Likewise.
6055         * valprint.c (value_print_option_defs): Likewise.
6056
6057 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6058
6059         PR build/24886
6060         * configure.ac: Drop enable-libmcheck support.
6061         * configure, config.in: Rebuild.
6062         * libmcheck.m4: Remove.
6063         * acinclude.m4: Don't include it.
6064         * Makefile.in: Don't distribute it.
6065         * top.c (print_gdb_configuration): Don't mention it.
6066
6067 2019-08-06  Tom Tromey  <tom@tromey.com>
6068
6069         * utils.c (set_output_style): Sometimes pass stream to
6070         emit_style_escape.
6071         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6072         * record-btrace.c (btrace_insn_history): Update.
6073         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6074         method.
6075         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6076         Update initializers.
6077         <m_uiout>: New field.
6078         <m_di>: Move lower.
6079         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6080         Remove "uiout" parameter.
6081         (dump_insns): Update.
6082         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6083         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6084
6085 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6086
6087         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6088         (error_in_psymtab_expansion): Likewise.
6089         (lookup_symbol_via_quick_fns): Likewise.
6090         (basic_lookup_transparent_type_quick): Likewise.
6091         (basic_lookup_transparent_type_1): Likewise.
6092
6093 2019-08-06  Tom Tromey  <tromey@adacore.com>
6094
6095         * source.c (last_source_error): Now bool.
6096         (print_source_lines_base): Make "noprint" bool.  Only open
6097         source file when last_source_visited changes.
6098
6099 2019-08-06  Tom Tromey  <tromey@adacore.com>
6100
6101         * annotate.c (annotate_source_line): Use g_source_cache.
6102         * source-cache.c (source_cache::get_plain_source_lines): Change
6103         parameters.  Populate m_offset_cache.
6104         (source_cache::ensure): New method.
6105         (source_cache::get_line_charpos): New method.
6106         (extract_lines): Move lower.  Change parameters.
6107         (source_cache::get_source_lines): Move lower.
6108         * source-cache.h (class source_cache): Update comment.
6109         <get_line_charpos>: New method.
6110         <get_source_lines>: Update comment.
6111         <clear>: Clear m_offset_cache.
6112         <get_plain_source_lines>: Change parameters.
6113         <ensure>: New method
6114         <m_offset_cache>: New member.
6115         * source.c (forget_cached_source_info_for_objfile): Update.
6116         (info_source_command): Use g_source_cache.
6117         (find_source_lines, open_source_file_with_line_charpos): Remove.
6118         (print_source_lines_base, search_command_helper): Use g_source_cache.
6119         * source.h (open_source_file_with_line_charpos): Don't declare.
6120         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6121         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6122         Use g_source_cache.
6123
6124 2019-08-06  Tom Tromey  <tromey@adacore.com>
6125
6126         * source-cache.c (source_cache::get_plain_source_lines):
6127         Remove "first_line" and "last_line" parameters.
6128         (source_cache::get_source_lines): Cache plain text.
6129         * source-cache.h (class source_cache)
6130         <get_plain_source_lines>: Update.
6131
6132 2019-08-06  Tom Tromey  <tromey@adacore.com>
6133
6134         * source-cache.c (extract_lines): No longer a method.
6135         Changed type of parameter.  Include final newline.
6136         (selftests::extract_lines_test): New function.
6137         (_initialize_source_cache): Likewise.
6138         * source-cache.h (class source_cache)
6139         <extract_lines>: Don't declare.
6140
6141 2019-08-06  Tom Tromey  <tromey@adacore.com>
6142
6143         * breakpoint.c (init_breakpoint_sal): Update.
6144         (breakpoint): Update.
6145         * breakpoint.h (struct breakpoint) <filter>: Now a
6146         unique_xmalloc_ptr.
6147
6148 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6149
6150         * NEWS: Mention dictionary access on blocks.
6151         * python/py-block.c (blpy_getitem): New function.
6152         (block_object_as_mapping): New struct.
6153         (block_object_type): Use new struct for tp_as_mapping field.
6154
6155 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6156
6157         * objfiles.h (objfile): Add a comment describing partial symbols.
6158
6159 2019-08-05  Tom Tromey  <tromey@adacore.com>
6160
6161         * compile/compile.c (_initialize_compile): Use _(), not N_().
6162         * thread.c (_initialize_thread): Use _(), not N_().
6163         * stack.c (_initialize_stack): Use _(), not N_().
6164         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6165
6166 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6167
6168         * dwarf2read.c (struct dw2_symtab_iterator):
6169         <want_specific_block>: Remove.
6170         <block_index>: Change type to gdb::optional.
6171         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6172         change type of BLOCK_INDEX parameter to gdb::optional.
6173         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6174         (dw2_lookup_symbol): Don't pass argument for
6175         WANT_SPECIFIC_BLOCK.
6176         (dw2_expand_symtabs_for_function): Don't pass argument for
6177         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6178         (class dw2_debug_names_iterator)
6179         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6180         parameter, change BLOCK_INDEX type to gdb::optional.
6181         <m_want_specific_block>: Remove.
6182         <m_block_index>: Change type to gdb::optional.
6183         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6184         gdb::optional.  Re-write in function of gdb::optional.
6185         (dw2_debug_names_lookup_symbol): Don't pass argument for
6186         WANT_SPECIFIC_BLOCK.
6187         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6188         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6189         BLOCK_INDEX.
6190
6191 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6192
6193         * NEWS: Mention changes to "info sources" command.
6194
6195 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6196
6197         * symtab.c (filename_partial_match_opts): New struct type.
6198         (struct output_source_filename_data): New members
6199         regexp, c_regexp, partial_match.
6200         (output_source_filename): Use new members to decide to print file.
6201         (info_sources_option_defs): New variable.
6202         (make_info_sources_options_def_group, print_info_sources_header,
6203         info_sources_command_completer):
6204         New functions.
6205         (info_sources_command): Read new optional arguments.
6206         (_initialize_symtab): Update info sources help.
6207
6208 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6209
6210         * ada-lang.c (exception_support_info_v0): Renamed from...
6211         (default_exception_support_info): ... this.  Create new
6212         definition for v1.
6213         (ada_has_this_exception_support): Look up catch_handlers_sym.
6214         (ada_exception_support_info_sniffer): Try v0 after default.
6215
6216 2019-08-01  Tom Tromey  <tromey@adacore.com>
6217
6218         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6219         gdbarch.h.
6220
6221 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6222
6223         * s12z-tdep.c: Fix include path for s12z-opc.h.
6224
6225 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6226
6227         * NEWS: Require GNU make 3.82.
6228
6229 2019-07-16  Tom Tromey  <tom@tromey.com>
6230
6231         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6232         declare.
6233
6234 2019-07-30  Tom Tromey  <tromey@adacore.com>
6235
6236         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6237
6238 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6239
6240         * printcmd.c (print_address_symbolic): Print negative offsets.
6241         (build_address_symbolic): Force signed arithmetic when computing
6242         offset.
6243
6244 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6245
6246         PR/24474: Add a function to lookup static variables.
6247         * NEWS: Mention this new function.
6248         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6249         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6250         * python/python.c (python_GdbMethods): Add new function.
6251
6252 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6253
6254         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6255         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6256         (objfpy_lookup_static_symbol): New function.
6257         (objfile_object_methods): Add new functions.
6258
6259 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6260
6261         * NEWS: Mention 'set|show print frame-info'.  Mention new
6262         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6263         backtrace argument.  Mention that python frame filtering code
6264         is now consistent with what 'backtrace' command prints.
6265
6266 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6267
6268         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6269         comments.
6270         (print_frame_info_auto, print_frame_info_source_line,
6271         print_frame_info_location, print_frame_info_source_and_location,
6272         print_frame_info_location_and_address, print_frame_info_short_location):
6273         New declarations.
6274         (struct frame_print_options): New member print_frame_info.
6275         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6276         * stack.h (get_user_print_what_frame_info): New declaration.
6277         (frame_show_address): New declaration.
6278         * stack.c (print_frame_arguments_choices): New value 'presence'.
6279         (print_frame_info_auto, print_frame_info_source_line,
6280         print_frame_info_location, print_frame_info_source_and_location,
6281         print_frame_info_location_and_address, print_frame_info_short_location,
6282         print_frame_info_choices, print_frame_info_print_what): New definitions.
6283         (print_frame_args): Only print dots for args if print frame-arguments
6284         is 'presence'.
6285         (frame_print_option_defs): New element for "frame-info".
6286         (get_user_print_what_frame_info): New function.
6287         (frame_show_address): Make non static.  Move comment to stack.h.
6288         (print_frame_info_to_print_what): New function.
6289         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6290         to decide what to print.
6291         (backtrace_command_1): Handle the new print_frame_arguments_presence
6292         value.
6293         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6294         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6295         (py_print_frame): In non-mi mode, use LOCATION as default for
6296         print_what, similarly to frame information printed directly by
6297         backtrace command. Handle frame-info user option in non MI mode.
6298
6299 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6300
6301         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6302         Add case for debugging 32-bit target on 64-bit host.  Revise
6303         comment.
6304
6305 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6306
6307         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6308         instead of find_function_entry_range_from_pc.
6309
6310 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6311
6312         * stack.c (find_frame_funname): Remove code which preferred
6313         minsym over symtab sym in "certain pathological cases".
6314
6315         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6316         parameter.  Change type of "do_demangle" to bool.
6317         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6318         Pass suitable "prefer_sym_over_minsym" flag to
6319         build_address_symbolic().  Don't output "+" for negative offsets.
6320         * printcmd.c (print_address_symbolic): Update invocation of
6321         build_address_symbolic to include a "prefer_sym_over_minsym"
6322         flag.
6323         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6324         Restrict cases in which use of minimal symbol is preferred to that
6325         of a found symbol.  Update comments.
6326
6327         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6328         for entry pc when entry pc is out of range for that FDE.
6329
6330 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6331
6332         PR gdb/24839:
6333         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6334         type.
6335
6336 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6337
6338         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6339         this function's Python signature.
6340
6341
6342 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6343
6344         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6345         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6346         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6347         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6348         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6349
6350
6351 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6352
6353         * h8300-tdep.c (h8300_register_name_common): New.
6354         h8300_register_name): Use h8300_register_name_common.
6355         (h8300s_register_name): Likewise.
6356         (h8300sx_register_name): Likewise.
6357         (h8300h_register_nam): New.
6358         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6359
6360
6361 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6362
6363         * arm-tdep.c (arm_skip_cmse_entry): New function.
6364         (arm_is_sgstubs_section): New function.
6365         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6366
6367 2019-07-22  Tom Tromey  <tom@tromey.com>
6368
6369         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6370         Don't self-assign.
6371
6372 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6373
6374         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6375         type_print.
6376
6377 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6378
6379         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6380         so that GDB doesn't match any msymbols when searching in the
6381         TYPES_DOMAIN.
6382         (print_symbol_info): Print using typedef_print or type_print based
6383         on the type of the symbol.  Add updated FIXME comment moved from...
6384         (_initialize_symtab): ... move and update FIXME comment to above.
6385
6386 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6387
6388         * NEWS: Mention adding -q option to "info types".
6389         * symtab.c (struct info_types_options): New struct.
6390         (info_types_options_defs): New variable.
6391         (make_info_types_options_def_group): New function.
6392         (info_types_command): Use gdb::option framework to parse options.
6393         (info_types_command_completer): New function.
6394         (_initialize_symtab): Extend the help text on "info types" and
6395         register command completer.
6396
6397 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6398
6399         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6400         (lookup_symbol_in_objfile): Change int to block_enum and add a
6401         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6402
6403 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6404
6405         * MAINTAINERS (Write After Approval): Add self.
6406
6407 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6408
6409         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6410         instruction to the dummy code region.
6411
6412 2019-07-19  Tom Tromey  <tromey@adacore.com>
6413
6414         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6415         (ARGSUSED, PARAMS, __func__): Remove rules.
6416
6417 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6418
6419         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6420         * features/arm/arm-with-iwmmxt.c: Remove.
6421         * features/arm/arm-with-iwmmxt.xml: Remove.
6422         * features/arm/arm-with-m-fpa-layout.c: Remove.
6423         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6424         * features/arm/arm-with-m-vfp-d16.c: Remove.
6425         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6426         * features/arm/arm-with-m.c: Remove.
6427         * features/arm/arm-with-m.xml: Remove.
6428         * features/arm/arm-with-neon.c: Remove.
6429         * features/arm/arm-with-neon.xml: Remove.
6430         * features/arm/arm-with-vfpv2.c: Remove.
6431         * features/arm/arm-with-vfpv2.xml: Remove.
6432         * features/arm/arm-with-vfpv3.c: Remove.
6433         * features/arm/arm-with-vfpv3.xml: Remove.
6434
6435 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6436
6437         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6438
6439 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6440
6441         * arch/aarch32.c (aarch32_create_target_description): Create
6442         target descriptions using features.
6443         * arch/arm.c (arm_create_target_description)
6444         (arm_create_mprofile_target_description): Likewise.
6445         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6446
6447 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6448
6449         * Makefile.in: Add new files.
6450         * aarch32-tdep.c: New file.
6451         * aarch32-tdep.h: New file.
6452         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6453         Call aarch32_read_description.
6454         * arch/aarch32.c: New file.
6455         * arch/aarch32.h: New file.
6456         * arch/arm.c (arm_create_target_description)
6457         (arm_create_mprofile_target_description): New function.
6458         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6459         (arm_create_target_description)
6460         (arm_create_mprofile_target_description): New declaration.
6461         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6462         read_description functions.
6463         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6464         Likewise.
6465         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6466         * arm-tdep.c (tdesc_arm_list): New variable.
6467         (arm_register_g_packet_guesses): Call create description functions.
6468         (arm_read_description) (arm_read_mprofile_description): New
6469         function.
6470         * arm-tdep.h (arm_read_description)
6471         (arm_read_mprofile_description): Add declaration.
6472         * configure.tgt: Add new files.
6473
6474 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6475
6476         * top.c (new_ui_command): Open specified terminal just once.
6477
6478 2019-07-18  Tom Tromey  <tromey@adacore.com>
6479
6480         * symtab.c (main_name): Constify return type.
6481         * symfile.c (set_initial_language): Update.
6482         * symtab.h (main_name): Constify return type.
6483
6484 2019-07-17  Tom Tromey  <tom@tromey.com>
6485
6486         * tui/tui-winsource.c (tui_update_source_window)
6487         (tui_update_source_window_as_is)
6488         (tui_update_source_windows_with_line): Remove return.
6489         * tui/tui-disasm.c (tui_show_disassem)
6490         (tui_show_disassem_and_update_source): Remove return.
6491         * tui/tui.c (tui_reset): Remove return.
6492         * tui/tui-wingeneral.c
6493         (tui_check_and_display_highlight_if_needed): Remove return.
6494
6495 2019-07-17  Tom Tromey  <tom@tromey.com>
6496
6497         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6498
6499 2019-07-17  Tom Tromey  <tom@tromey.com>
6500
6501         * tui/tui-winsource.h (struct tui_exec_info_window)
6502         (struct tui_source_window_base): Move from tui-data.h.
6503         * tui/tui-winsource.c: Move many method definitions from
6504         elsewhere.  Remove "structuring" comments.
6505         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6506         (tui_source_window_base::refresh_window): Move to
6507         tui-winsource.c.
6508         * tui/tui-win.c (tui_source_window_base::refresh_all)
6509         (tui_source_window_base::update_tab_width)
6510         (tui_source_window_base::set_new_height)
6511         (tui_source_window_base::do_make_visible_with_new_height): Move to
6512         tui-winsource.c.
6513         * tui/tui-source.h: Update.
6514         * tui/tui-source.c (tui_source_window_base::reset): Move to
6515         tui-winsource.c.
6516         * tui/tui-disasm.h: Update.
6517         * tui/tui-data.h (struct tui_exec_info_window): Move to
6518         tui-winsource.h.
6519         (struct tui_source_window_base): Likewise.
6520         * tui/tui-data.c (tui_source_window_base::clear_detail)
6521         (tui_source_window_base, ~tui_source_window_base): Move to
6522         tui-winsource.c.
6523
6524 2019-07-17  Tom Tromey  <tom@tromey.com>
6525
6526         * tui/tui-win.c (tui_resize_all)
6527         (tui_source_window_base::update_tab_width)
6528         (tui_adjust_win_heights): Update.
6529         (tui_win_info::make_invisible_and_set_new_height): Rename from
6530         make_invisible_and_set_new_height.
6531         * tui/tui-data.h (struct tui_win_info)
6532         <make_invisible_and_set_new_height>: New method.
6533
6534 2019-07-17  Tom Tromey  <tom@tromey.com>
6535
6536         * tui/tui.c: Update.
6537         * tui/tui-source.h (struct tui_source_window): Move from
6538         tui-data.h.
6539         * tui/tui-layout.c: Update.
6540         * tui/tui-disasm.c: Update.
6541         * tui/tui-data.h (struct tui_source_window): Move to
6542         tui-source.h.
6543
6544 2019-07-17  Tom Tromey  <tom@tromey.com>
6545
6546         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6547         tui-data.h.
6548         * tui/tui-data.h (struct tui_disasm_window): Move to
6549         tui-disasm.h.
6550
6551 2019-07-17  Tom Tromey  <tom@tromey.com>
6552
6553         * tui/tui-regs.h (struct tui_data_item_window): Move from
6554         tui-data.h.
6555         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6556         * tui/tui-data.h (struct tui_data_item_window): Move to
6557         tui-regs.h.
6558         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6559
6560 2019-07-17  Tom Tromey  <tom@tromey.com>
6561
6562         * tui/tui.c: Update.
6563         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6564         (tui_cmd_window::max_height): Move to tui-command.c.
6565         * tui/tui-layout.c: Update.
6566         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6567         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6568         tui-command.c.
6569         * tui/tui-command.h (struct tui_cmd_window): Move from
6570         tui-data.h.
6571         * tui/tui-command.c: Remove "structuring" comments.
6572         (tui_cmd_window::clear_detail)
6573         (tui_cmd_window::do_make_visible_with_new_height)
6574         (tui_cmd_window::max_height): Move from elsewhere.
6575
6576 2019-07-17  Tom Tromey  <tom@tromey.com>
6577
6578         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6579         Now static.
6580         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6581         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6582
6583 2019-07-17  Tom Tromey  <tom@tromey.com>
6584
6585         * tui/tui.c: Update.
6586         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6587         tui-regs.c.
6588         * tui/tui-windata.h: Remove file.
6589         * tui/tui-windata.c: Remove file.
6590         * tui/tui-win.c (tui_data_window::set_new_height)
6591         (tui_data_window::do_make_visible_with_new_height): Move to
6592         tui-regs.c.
6593         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6594         * tui/tui-regs.c: Remove "structuring" comments.
6595         (tui_data_window::first_data_item_displayed)
6596         (tui_data_window::delete_data_content_windows)
6597         (tui_data_window::erase_data_content)
6598         (tui_data_window::display_all_data)
6599         (tui_data_window::refresh_all)
6600         (tui_data_window::do_scroll_vertical)
6601         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6602         (tui_data_window::do_make_visible_with_new_height)
6603         (tui_data_window::refresh_window): Move from elsewhere.
6604         (_initialize_tui_regs): Move to end of file.
6605         * tui/tui-layout.c: Update.
6606         * tui/tui-hooks.c: Update.
6607         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6608         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6609         tui-regs.c.
6610         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6611
6612 2019-07-17  Tom Tromey  <tom@tromey.com>
6613
6614         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6615         seen.
6616
6617 2019-07-17  Tom Tromey  <tom@tromey.com>
6618
6619         * tui/tui-win.c (tui_source_window_base::set_new_height)
6620         (tui_source_window_base::do_make_visible_with_new_height): Use
6621         m_has_locator field directly.
6622         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6623         method.
6624         (struct tui_source_window_base) <has_locator>: Likewise.
6625
6626 2019-07-17  Tom Tromey  <tom@tromey.com>
6627
6628         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6629         Don't declare.
6630         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6631         Remove.
6632         * tui/tui-win.c (tui_source_window_base::set_new_height)
6633         (tui_source_window_base::set_new_height)
6634         (make_invisible_and_set_new_height)
6635         (tui_source_window_base::do_make_visible_with_new_height)
6636         (tui_source_window_base::do_make_visible_with_new_height):
6637         Update.
6638         * tui/tui-layout.c (show_source_disasm_command, show_data)
6639         (show_source_or_disasm_and_command): Update.
6640         * tui/tui-layout.c (show_layout): Update.
6641
6642 2019-07-17  Tom Tromey  <tom@tromey.com>
6643
6644         * tui/tui-layout.c (make_data_window): Remove.
6645         (show_data): Unify creation and re-initialization cases.
6646
6647 2019-07-17  Tom Tromey  <tom@tromey.com>
6648
6649         * tui/tui-layout.c (make_source_window, make_disasm_window):
6650         Remove.
6651         (show_data): Unify creation and re-initialization cases.
6652
6653 2019-07-17  Tom Tromey  <tom@tromey.com>
6654
6655         * tui/tui-layout.c (make_command_window): Remove.
6656         (show_source_disasm_command, show_source_or_disasm_and_command):
6657         Unify creation and re-initialization cases.
6658
6659 2019-07-17  Tom Tromey  <tom@tromey.com>
6660
6661         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6662         creation and re-initialization cases.
6663
6664 2019-07-17  Tom Tromey  <tom@tromey.com>
6665
6666         * tui/tui-regs.c (tui_get_register): Return void.
6667
6668 2019-07-17  Tom Tromey  <tom@tromey.com>
6669
6670         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6671         Simplify.
6672
6673 2019-07-17  Tom Tromey  <tom@tromey.com>
6674
6675         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6676         resetting.
6677
6678 2019-07-17  Tom Tromey  <tom@tromey.com>
6679
6680         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6681         * tui/tui-regs.c (tui_reg_layout): New function.
6682         (tui_show_registers, tui_reg_command): Use it.
6683         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6684         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6685         parameters.
6686         (tui_layout_command): Remove.
6687
6688 2019-07-17  Tom Tromey  <tom@tromey.com>
6689
6690         * tui/tui-layout.h (tui/tui-layout): Return void.
6691         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6692
6693 2019-07-17  Tom Tromey  <tom@tromey.com>
6694
6695         * tui/tui-layout.c (show_source_disasm_command, show_data):
6696         Update.
6697         (reset_locator): Remove.
6698         (show_source_or_disasm_and_command): Update.
6699
6700 2019-07-17  Tom Tromey  <tom@tromey.com>
6701
6702         * tui/tui-source.c (tui_source_window_base::reset): Remove
6703         win_type parameter.
6704         * tui/tui-layout.c (make_command_window, make_source_window)
6705         (make_disasm_window, make_data_window)
6706         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6707         (reset_locator, show_source_or_disasm_and_command): Update.
6708         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6709         win_type parameter.
6710         (struct tui_source_window_base) <reset>: Likewise.
6711
6712 2019-07-17  Tom Tromey  <tom@tromey.com>
6713
6714         * tui/tui-layout.c (show_source_disasm_command): Use
6715         reset_locator.
6716         (reset_locator): New function.
6717         (init_and_make_win): Remove.
6718         (show_source_or_disasm_and_command): Use reset_locator.
6719
6720 2019-07-17  Tom Tromey  <tom@tromey.com>
6721
6722         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6723         condition.
6724         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6725         Remove condition.
6726         * tui/tui-source.c (tui_source_window_base::reset): New method.
6727         * tui/tui-layout.c (make_command_window): Don't call
6728         init_and_make_win.
6729         (make_source_window, make_disasm_window): Don't call
6730         make_source_or_disasm_window.
6731         (make_data_window): Don't call init_and_make_win.  Change calling
6732         convention.
6733         (show_source_disasm_command, show_data): Simplify.
6734         (make_source_or_disasm_window): Remove.
6735         (show_source_or_disasm_and_command): Simplify.
6736         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6737         (struct tui_source_window_base) <reset>: Likewise.
6738         <execution_info>: Remove initializer.
6739         * tui/tui-data.c (tui_source_window_base): Initialize
6740         execution_info.
6741
6742 2019-07-17  Tom Tromey  <tom@tromey.com>
6743
6744         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6745         variable.
6746
6747 2019-07-17  Tom Tromey  <tom@tromey.com>
6748
6749         * tui/tui.c (tui_rl_other_window): Update.
6750         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6751         superclass method first.  Always iterate over regs_content.
6752         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6753         method.
6754         * tui/tui-win.c (tui_set_focus_command): Update.
6755
6756 2019-07-17  Tom Tromey  <tom@tromey.com>
6757
6758         * tui/tui-win.c (tui_set_focus_command): Rename from
6759         tui_set_focus.  Call tui_enable.
6760         (tui_set_focus_command): Remove.
6761
6762 2019-07-17  Tom Tromey  <tom@tromey.com>
6763
6764         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6765         refresh_window.
6766         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6767         touchwin.
6768         (tui_data_window::refresh_window): Call refresh_window on data
6769         items.  Always call superclass refresh_window.
6770         (tui_win_info::refresh): Remove.
6771         (tui_source_window_base::refresh_window): Update.
6772         (tui_refresh_all): Update.
6773         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6774         refresh_window.
6775         (show_source_or_disasm_and_command): Likewise.
6776         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6777         (struct tui_source_window_base) <refresh>: Likewise.
6778
6779 2019-07-17  Tom Tromey  <tom@tromey.com>
6780
6781         * tui/tui-winsource.c (tui_clear_source_content)
6782         (tui_show_source_content): Update.
6783         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6784         whether content is empty.
6785         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6786         Remove.
6787
6788 2019-07-17  Tom Tromey  <tom@tromey.com>
6789
6790         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6791         window's contents.
6792         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6793         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6794
6795 2019-07-17  Tom Tromey  <tom@tromey.com>
6796
6797         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6798         (struct tui_data_item_window): Update.
6799
6800 2019-07-17  Tom Tromey  <tom@tromey.com>
6801
6802         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6803         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6804         defines.
6805
6806 2019-07-17  Tom Tromey  <tom@tromey.com>
6807
6808         * tui/tui-winsource.h (tui_erase_source_content)
6809         (tui_clear_source_content): Remove "display_prompt" parameter.
6810         * tui/tui-winsource.c (tui_update_source_window_as_is)
6811         (tui_update_source_windows_with_addr): Update.
6812         (tui_clear_source_content): Remove "display_prompt" parameter.
6813         (tui_erase_source_content): Likewise.  Simplify.
6814         (tui_show_source_content): Update.
6815         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6816         * tui/tui-stack.c (tui_show_frame_info): Update.
6817         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6818         Remove defines.
6819
6820 2019-07-17  Tom Tromey  <tom@tromey.com>
6821
6822         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6823         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6824         parameter.
6825         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6826         parameter.
6827
6828 2019-07-17  Tom Tromey  <tom@tromey.com>
6829
6830         * tui/tui-winsource.c (tui_clear_source_content)
6831         (tui_show_source_content, tui_show_exec_info_content)
6832         (tui_clear_exec_info_content): Update.
6833         * tui/tui-stack.c (tui_show_locator_content): Update.
6834         (tui_show_frame_info): Update.
6835         * tui/tui-source.h (tui_source_window): Don't declare.
6836         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6837         from tui_source_is_displayed.
6838         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6839         Remove field.
6840         (struct tui_source_window_base) <content_in_use>: New field.  Now
6841         bool.
6842         (struct tui_source_window) <showing_source_p>: New method.
6843         (TUI_SRC_WIN): Change cast.
6844         * tui/tui-data.c (tui_initialize_static_data): Update.
6845
6846 2019-07-17  Tom Tromey  <tom@tromey.com>
6847
6848         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6849         location_matches_p.
6850         * tui/tui-source.c (tui_source_window::location_matches_p): New
6851         method.
6852         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6853         method.
6854         * tui/tui-data.h (struct tui_source_window_base)
6855         <location_matches_p>: New method.
6856         (struct tui_source_window, struct tui_disasm_window)
6857         <location_matches_p>: Likewise.
6858
6859 2019-07-17  Tom Tromey  <tom@tromey.com>
6860
6861         * tui/tui-win.c (tui_set_win_height_command): Rename from
6862         tui_set_win_height.
6863         (tui_set_win_height_command): Remove.
6864
6865 2019-07-17  Tom Tromey  <tom@tromey.com>
6866
6867         * tui/tui-source.c (tui_source_window): New constructor.  Add
6868         observer.
6869         (~tui_source_window): New destructor.
6870         (tui_source_window::style_changed): New method.
6871         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6872         (tui_attach_detach_observers): Update.
6873         * tui/tui-data.h (struct tui_source_window): Make constructor not
6874         inline.  Add destructor.
6875         (struct tui_source_window) <style_changed>: New method.
6876         <m_observable>: New member.
6877
6878 2019-07-17  Tom Tromey  <tom@tromey.com>
6879
6880         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6881         * tui/tui-win.c (tui_resize_all): Fix typo.
6882
6883 2019-07-17  Tom Tromey  <tom@tromey.com>
6884
6885         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6886         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6887         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6888         * tui/tui-win.c (window_name_completer): Use foreach.
6889         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6890         (update_tab_width): Likewise.
6891         * tui/tui-layout.c (show_layout): Update.
6892         * tui/tui-data.h (class tui_window_iterator): New.
6893         (struct all_tui_windows): New.
6894         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6895
6896 2019-07-17  Tom Tromey  <tom@tromey.com>
6897
6898         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6899         parameter.  Don't reference globals.
6900         (tui_reg_command): Update.
6901
6902 2019-07-17  Tom Tromey  <tom@tromey.com>
6903
6904         * tui/tui-regs.c (tui_show_registers): Simplify.
6905
6906 2019-07-17  Tom Tromey  <tom@tromey.com>
6907
6908         * tui/tui-regs.c (tui_show_registers): Update.
6909         (tui_show_register_group): Add win_info parameter.
6910
6911 2019-07-17  Tom Tromey  <tom@tromey.com>
6912
6913         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6914         Rename from tui_display_reg_element_at_line.
6915         (tui_data_window::display_registers_from_line): Update.
6916         * tui/tui-data.h (struct tui_data_window)
6917         <display_reg_element_at_line>: New method.
6918
6919 2019-07-17  Tom Tromey  <tom@tromey.com>
6920
6921         * tui/tui-regs.h (tui_display_registers_from)
6922         (tui_display_registers_from_line): Don't declare.
6923         * tui/tui-windata.c (tui_data_window::display_all_data)
6924         (tui_data_window::refresh_all)
6925         (tui_data_window::do_scroll_vertical): Update.
6926         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6927         from tui_display_registers_from.
6928         (tui_display_reg_element_at_line): Update.
6929         (tui_data_window::display_registers_from_line): Rename from
6930         tui_display_registers_from_line.
6931         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6932         display_registers_from_line>: New methods.
6933
6934 2019-07-17  Tom Tromey  <tom@tromey.com>
6935
6936         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6937         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6938         from tui_erase_data_content.
6939         (tui_data_window::display_all_data)
6940         (tui_data_window::refresh_all)
6941         (tui_data_window::do_scroll_vertical): Update.
6942         * tui/tui-regs.c (tui_show_registers): Update.
6943         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6944         New method.
6945
6946 2019-07-17  Tom Tromey  <tom@tromey.com>
6947
6948         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6949         declare.
6950         * tui/tui-windata.c
6951         (tui_data_window::delete_data_content_windows): Rename from
6952         tui_delete_data_content_windows.
6953         (tui_data_window::display_all_data)
6954         (tui_data_window::do_scroll_vertical): Update.
6955         * tui/tui-data.h (struct tui_data_window)
6956         <delete_data_content_windows>: New method.
6957
6958 2019-07-17  Tom Tromey  <tom@tromey.com>
6959
6960         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6961         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6962
6963 2019-07-17  Tom Tromey  <tom@tromey.com>
6964
6965         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6966         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6967         from tui_display_all_data.
6968         * tui/tui-win.c
6969         (tui_data_window::do_make_visible_with_new_height): Update.
6970         * tui/tui-regs.c (tui_show_registers): Update.
6971         * tui/tui-layout.c (tui_set_layout): Update.
6972         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6973         method.
6974
6975 2019-07-17  Tom Tromey  <tom@tromey.com>
6976
6977         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6978         * tui/tui-windata.c (tui_display_data_from): Remove.
6979         (tui_data_window::refresh_all): Update.
6980
6981 2019-07-17  Tom Tromey  <tom@tromey.com>
6982
6983         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6984         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6985         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6986         tui_display_registers_from_line.
6987         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6988         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6989         "force_display" parameter.
6990
6991 2019-07-17  Tom Tromey  <tom@tromey.com>
6992
6993         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6994         declare.
6995         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6996         Rename from tui_first_reg_element_no_inline.
6997         (tui_display_reg_element_at_line)
6998         (tui_display_registers_from_line): Update.
6999         * tui/tui-data.h (struct tui_data_window)
7000         <first_reg_element_no_inline>: New method.
7001
7002 2019-07-17  Tom Tromey  <tom@tromey.com>
7003
7004         * tui/tui-windata.c (tui_display_data_from)
7005         (tui_data_window::do_scroll_vertical): Update.
7006         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7007         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7008         Rename from tui_line_from_reg_element_no.
7009         (tui_display_registers_from_line): Update.
7010         * tui/tui-data.h (struct tui_data_window)
7011         <line_from_reg_element_no>: New method.
7012
7013 2019-07-17  Tom Tromey  <tom@tromey.com>
7014
7015         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7016         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7017         tui_last_regs_line_no.
7018         (tui_display_reg_element_at_line)
7019         (tui_display_registers_from_line): Update.
7020         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7021         method.
7022
7023 2019-07-17  Tom Tromey  <tom@tromey.com>
7024
7025         PR tui/24722:
7026         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7027         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7028         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7029         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7030         (tui_update_breakpoint_info): Likewise.
7031         * tui/tui-hooks.c (tui_event_create_breakpoint)
7032         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7033         Update.
7034
7035 2019-07-17  Tom Tromey  <tom@tromey.com>
7036
7037         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7038
7039 2019-07-17  Tom Tromey  <tom@tromey.com>
7040
7041         * tui/tui-winsource.c (tui_update_source_window_as_is)
7042         (tui_update_source_windows_with_addr): Update.
7043         * tui/tui-source.h (tui_set_source_content)
7044         (tui_show_symtab_source): Add "win_info" parameter.
7045         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7046         parameter.
7047         (tui_show_symtab_source): Likewise.
7048
7049 2019-07-17  Tom Tromey  <tom@tromey.com>
7050
7051         * tui/tui-wingeneral.c
7052         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7053
7054 2019-07-17  Tom Tromey  <tom@tromey.com>
7055
7056         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7057         (struct tui_cmd_window) <can_scroll>: New method.
7058         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7059         method.
7060
7061 2019-07-17  Tom Tromey  <tromey@adacore.com>
7062
7063         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7064         do_field_signed>: Rename.  Change type of "value".
7065         * ui-out.c (ui_out::field_signed): Rename from field_int.
7066         Change type of "value".
7067         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7068         type of "value".
7069         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7070         do_field_int.  Change type of "value".
7071         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7072         do_field_int.  Change type of "value".
7073         * tracepoint.c (trace_status_mi, tfind_1)
7074         (print_one_static_tracepoint_marker): Update.
7075         * thread.c (print_thread_info_1, print_selected_thread_frame):
7076         Update.
7077         * stack.c (print_frame, print_frame_info): Update.
7078         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7079         Update.
7080         * source.c (print_source_lines_base): Update.
7081         * skip.c (info_skip_command): Update.
7082         * record-btrace.c (btrace_ui_out_decode_error)
7083         (btrace_call_history_src_line): Update.
7084         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7085         Update.
7086         * progspace.c (print_program_space): Update.
7087         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7088         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7089         do_field_int.  Change type of "value".
7090         * mi/mi-out.c (mi_ui_out::do_table_begin)
7091         (mi_ui_out::do_table_header): Update.
7092         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7093         type of "value".
7094         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7095         (mi_cmd_data_list_changed_registers, output_register)
7096         (mi_cmd_data_read_memory, mi_load_progress)
7097         (mi_cmd_trace_frame_collected): Update.
7098         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7099         Update.
7100         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7101         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7102         (mi_cmd_var_list_children, varobj_update_one): Update.
7103         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7104         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7105         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7106         * inferior.c (print_inferior): Update.
7107         * gdb_bfd.c (print_one_bfd): Update.
7108         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7109         Update.
7110         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7111         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7112         do_field_int.  Change type of "value".
7113         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7114         do_field_int.  Change type of "value".
7115         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7116         (print_one_breakpoint_location, print_it_catch_fork)
7117         (print_one_catch_fork, print_it_catch_vfork)
7118         (print_one_catch_vfork, print_it_catch_solib)
7119         (print_it_catch_exec, print_it_ranged_breakpoint)
7120         (print_mention_watchpoint, print_mention_masked_watchpoint)
7121         (bkpt_print_it, update_static_tracepoint): Update.
7122         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7123         * break-catch-syscall.c (print_it_catch_syscall): Update.
7124         * ada-tasks.c (print_ada_task_info): Update.
7125         * ada-lang.c (print_it_exception, print_mention_exception):
7126         Update.
7127
7128 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7129
7130         PR breakpoints/24541
7131         * gdbarch.c: Regenerate.
7132         * gdbarch.h: Regenerate.
7133         * gdbarch.sh: Adjust return type and parameter types for
7134         'stap_adjust_register'.
7135         (i386_stap_adjust_register): Adjust signature and return new
7136         register name.
7137         * stap-probe.c (stap_parse_register_operand): Adjust use of
7138         'gdbarch_stap_adjust_register'.
7139
7140 2019-07-17  Tom Tromey  <tromey@adacore.com>
7141
7142         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7143         declare VEC.
7144         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7145         std::vector.
7146         (struct s390_process_info): Add initializers.
7147         (s390_add_process): Use new.
7148         (s390_linux_nat_target::low_forget_process): Use delete.
7149         (s390_linux_nat_target::low_new_fork)
7150         (s390_linux_nat_target::stopped_by_watchpoint)
7151         (s390_linux_nat_target::low_prepare_to_resume)
7152         (s390_linux_nat_target::insert_watchpoint)
7153         (s390_linux_nat_target::insert_hw_breakpoint)
7154         (s390_linux_nat_target::remove_watchpoint)
7155         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7156
7157 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7158
7159         * aarch64-fbsd-nat.c: Include regcache.h.
7160         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7161         argument.
7162         (aarch64_fbsd_nat_target::fetch_registers)
7163         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7164         variable.
7165         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7166
7167 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7168
7169         * fbsd-nat.c: Include gdbarch.h.
7170
7171 2019-07-15  Tom Tromey  <tromey@adacore.com>
7172
7173         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7174
7175 2019-07-15  Tom Tromey  <tromey@adacore.com>
7176
7177         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7178         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7179         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7180         * cli-out.c (cli_ui_out::do_field_int): New method.
7181         * ui-out.c (ui_out::field_unsigned): New method.
7182         * symfile.c (generic_load): Use field_unsigned.
7183         (print_transfer_performance): Likewise.
7184         * record-btrace.c (ui_out_field_uint): Remove.
7185         (btrace_call_history_insn_range, btrace_call_history): Use
7186         field_unsigned.
7187         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7188         field_unsigned.
7189         * ui-out.h (class ui_out) <field_unsigned>: New method.
7190         <do_field_unsigned>: Likewise.
7191
7192 2019-07-15  Tom Tromey  <tromey@adacore.com>
7193
7194         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7195         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7196         * target.c (flash_erase_command): Use field_string.
7197         * infrun.c (print_signal_received_reason): Use field_string.
7198         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7199         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7200         field_string.
7201         * ada-tasks.c (print_ada_task_info): Use field_string.
7202
7203 2019-07-15  Tom Tromey  <tromey@adacore.com>
7204
7205         * target.c (flash_erase_command): Use field_core_addr.
7206         * symfile.c (generic_load): Use field_core_addr.
7207         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7208         Use field_core_addr.
7209         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7210         field_core_addr.
7211
7212 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7213
7214         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7215         value if its desired type is smaller than a CORE_ADDR and signed.
7216
7217 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7218
7219         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7220         of changes to field names, and use new is_reference field to
7221         decide if a property is a reference or not.
7222         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7223         field.
7224         (struct dwarf2_property_baton): Update header comment, rename
7225         'referenced_type' to 'property_type' and update comments.
7226         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7227         default property type, store in property baton, update to take
7228         accound of renamed field.
7229         (read_func_scope): Update call to attr_to_dynamic_prop.
7230         (read_array_type): Likewise.
7231         (dwarf2_per_cu_addr_sized_int_type): New function.
7232         (read_subrange_index_type): Move type finding code to
7233         dwarf2_per_cu_addr_sized_int_type.
7234         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7235         (dwarf2_per_cu_addr_type): New function.
7236         (set_die_type): Update calls to attr_to_dynamic_prop.
7237
7238 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7239
7240         * dwarf2read.c (read_subrange_index_type): New function.
7241         (read_subrange_type): Move code into new function and call it.
7242         * gdbtypes.c (create_range_type): Add some asserts.
7243
7244 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7245
7246         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7247         update return statements.
7248         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7249         declaration, and update comment to match.
7250         * gdbtypes.c (resolve_dynamic_array): Update call to
7251         dwarf2_evaluate_property to match new return type.
7252
7253 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7254
7255         * valarith.c (value_subscripted_rvalue): Change lowerbound
7256         parameter type from int to LONGEST.
7257         * value.h (value_subscripted_rvalue): Likewise in declaration.
7258
7259 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7260
7261         * cli/cli-utils.c (info_print_command_completer): New function.
7262         * cli/cli-utils.h: Add 'completer.h' include, and forward
7263         declaration for 'struct cmd_list_element'.
7264         (info_print_command_completer): Declare.
7265         * stack.c (_initialize_stack): Add completer for 'info locals' and
7266         'info args'.
7267         * symtab.c (_initialize_symtab): Add completer for 'info
7268         variables' and 'info functions'.
7269         * NEWS: Mention completion for additional info commands.
7270
7271 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7272
7273         * cli/cli-utils.c (extract_info_print_args): Delete.
7274         (extract_arg_maybe_quoted): Delete.
7275         (info_print_options_defs): New variable.
7276         (make_info_print_options_def_group): New function.
7277         (extract_info_print_options): Define new function.
7278         * cli/cli-utils.h (extract_info_print_args): Delete.
7279         (struct info_print_options): New structure.
7280         (extract_info_print_options): Declare new function.
7281         * stack.c (info_locals_command): Update to use new
7282         extract_info_print_options, also add a header comment.
7283         (info_args_command): Likewise.
7284         * symtab.c (info_variables_command): Likewise.
7285         (info_functions_command): Likewise.
7286
7287 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7288
7289         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7290         to extract string arguments.
7291         * common/common-utils.c (extract_string_maybe_quoted): New function.
7292         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7293
7294 2019-07-11  Tom Tromey  <tromey@adacore.com>
7295
7296         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7297         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7298         * top.h (gdbinit): Don't declare.
7299         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7300         into...
7301         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7302         * top.c (gdb_init): Don't call init_cli_cmds.
7303         (gdbinit): Remove.
7304         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7305
7306 2019-07-11  Tom Tromey  <tromey@adacore.com>
7307
7308         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7309         after it has been moved.
7310
7311 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7312
7313         * valops.c (value_must_coerce_to_target): Change return type to
7314         bool.
7315         * value.h (value_must_coerce_to_target): Likewise.
7316
7317 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7318
7319         * breakpoint.c (is_hardware_watchpoint): Remove
7320         forward-declaration.
7321         (is_masked_watchpoint): Change return type to bool.
7322         (is_tracepoint): Likewise.
7323         (is_breakpoint): Likewise.
7324         (is_hardware_watchpoint): Likewise.
7325         (is_watchpoint): Likewise.
7326         (is_no_memory_software_watchpoint): Likewise.
7327         (is_catchpoint): Likewise.
7328         (breakpoint_1): Make FILTER parameter's return type bool.
7329         is_masked_watchpoint): Change return type to bool.
7330         (save_breakpoints): Make FILTER parameter's return type bool.
7331         * breakpoint.h (is_breakpoint): Change return type to bool.
7332         (is_watchpoint): Likewise.
7333         (is_catchpoint): Likewise.
7334         (is_tracepoint): Likewise.
7335
7336 2019-07-10  Tom Tromey  <tom@tromey.com>
7337
7338         * defs.h: Don't include gdbarch.h.
7339         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7340         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7341         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7342         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7343         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7344         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7345         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7346         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7347         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7348         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7349         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7350         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7351         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7352         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7353         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7354         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7355         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7356         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7357         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7358         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7359         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7360         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7361         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7362         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7363         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7364         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7365         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7366
7367 2019-07-10  Tom Tromey  <tromey@adacore.com>
7368
7369         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7370         * breakpoint.c (init_ada_exception_breakpoint): Register as
7371         bp_catchpoint.
7372         (print_one_breakpoint_location, print_one_breakpoint): Use
7373         is_ada_exception_catchpoint.
7374         * ada-lang.c (class ada_catchpoint_location): Pass
7375         bp_loc_software_breakpoint to bp_location constructor.
7376         (is_ada_exception_catchpoint): New function.
7377
7378 2019-07-10  Tom Tromey  <tromey@adacore.com>
7379
7380         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7381         VEC.
7382         (struct arm_exidx_entry): New method operator<.
7383         (struct arm_exidx_data) <section_maps>: Change type.
7384         (arm_exidx_data_free): Remove.
7385         (arm_exidx_data_key): Change type.  Move lower.
7386         (arm_exidx_new_objfile): Update.
7387         (arm_compare_exidx_entries): Remove.
7388         (arm_find_exidx_entry, _initialize_arm_tdep)
7389
7390 2019-07-10  Tom Tromey  <tromey@adacore.com>
7391
7392         * solib-spu.c (ocl_program_data_key): Change type.
7393         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7394         Update.
7395
7396 2019-07-10  Tom Tromey  <tromey@adacore.com>
7397
7398         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7399         (struct solib_aix_inferior_data) <library_list>: Change type.
7400         (solib_aix_inferior_data_handle): Change type.
7401         (get_solib_aix_inferior_data): Update.
7402         (solib_aix_free_library_list): Remove.
7403         (library_list_start_library): Update.
7404         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7405         return type.
7406         (solib_aix_get_library_list)
7407         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7408         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7409
7410 2019-07-10  Tom Tromey  <tromey@adacore.com>
7411
7412         * solib-dsbt.c (struct dsbt_info): Add initializers.
7413         (solib_dsbt_pspace_data): Change type.
7414         (dsbt_pspace_data_cleanup): Remove.
7415         (get_dsbt_info, _initialize_dsbt_solib): Update.
7416
7417 2019-07-10  Tom Tromey  <tromey@adacore.com>
7418
7419         * spu-tdep.c (spu_overlay_data): Change type.
7420         (spu_get_overlay_table, spu_overlay_new_objfile)
7421         (_initialize_spu_tdep): Update.
7422
7423 2019-07-10  Tom Tromey  <tromey@adacore.com>
7424
7425         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7426         destructor.
7427         (dbx_objfile_data_key): Change type and declare later.
7428         (DBX_SYMFILE_INFO): Rewrite.
7429         * dbxread.c (dbx_objfile_data_key): Change type.
7430         (dbx_symfile_init): Update.
7431         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7432         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7433         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7434
7435 2019-07-10  Tom Tromey  <tromey@adacore.com>
7436
7437         * jit.c (jit_program_space_key): Change type.  Move lower.
7438         (get_jit_program_space_data): Update.
7439         (jit_program_space_data_cleanup): Remove.
7440         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7441         Update.
7442         (struct jit_program_space_data): Add initializers.
7443
7444 2019-07-10  Tom Tromey  <tromey@adacore.com>
7445
7446         * solib-darwin.c (struct darwin_info): Add initializers.
7447         (solib_darwin_pspace_data): Change type.
7448         (darwin_pspace_data_cleanup): Remove.
7449         (get_darwin_info, _initialize_darwin_solib): Update.
7450
7451 2019-07-10  Tom Tromey  <tromey@adacore.com>
7452
7453         * remote-sim.c (struct sim_inferior_data): Add initializers,
7454         constructor, and destructor.
7455         (sim_inferior_data_key): Change type.  Move lower.
7456         (check_for_duplicate_sim_descriptor): Update.
7457         (get_sim_inferior_data): Use new.  Update.
7458         (~sim_inferior_data_cleanup): Rename from
7459         sim_inferior_data_cleanup.  Simplify.
7460         (gdbsim_close_inferior, simulator_command)
7461         (sim_command_completer, _initialize_remote_sim): Update.
7462         (next_pid, INITIAL_PID): Move earlier.
7463
7464 2019-07-10  Tom Tromey  <tromey@adacore.com>
7465
7466         * python/python-internal.h (create_thread_object): Return
7467         gdbpy_ref.
7468         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7469         * python/py-inferior.c (struct threadlist_entry): Add
7470         constructor.
7471         <thread_obj>: Now a gdbpy_ref.
7472         (thread_to_thread_object): Update.
7473         (add_thread_object): Use new.
7474         (delete_thread_object): Use delete.
7475         (infpy_threads): Update.
7476         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7477         GIL.
7478
7479 2019-07-10  Tom Tromey  <tromey@adacore.com>
7480
7481         * valops.c (value_cast): Specialize error message for Ada.
7482
7483 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7484
7485         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7486
7487 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7488
7489         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7490         bpstat_should_step): Return bool, adjust comments.
7491         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7492         bpstat_should_step): Likewise.
7493
7494 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7495
7496         * features/Makefile: Use feature target descriptions for Arm.
7497         * features/arm/arm-core.c: Generate new file.
7498         * features/arm/arm-fpa.c: Likewise.
7499         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7500         * features/arm/arm-m-profile.c: Likewise.
7501         * features/arm/arm-vfpv2.c: Likewise.
7502         * features/arm/arm-vfpv3.c: Likewise.
7503         * features/arm/xscale-iwmmxt.c: Likewise.
7504         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7505
7506 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7507
7508         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7509         ptrace earlier.
7510
7511 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7512
7513         * features/aarch64-pauth.c: Regenerate.
7514
7515 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7516
7517         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7518         bool.
7519         (bpstat_what): Use false instead of 0.
7520
7521 2019-07-09  Pedro Alves  <palves@redhat.com>
7522
7523         * break-catch-throw.c (is_exception_catchpoint): New.
7524         * breakpoint.c (print_one_breakpoint_location): New parameter
7525         'raw_loc'.  Handle it.  Use
7526         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7527         looking at the breakpoint's type.
7528         (print_one_breakpoint): If handling "maint info breakpoints", also
7529         print locations of exception catchpoints.
7530         * breakpoint.h (is_exception_catchpoint): Declare.
7531
7532 2019-07-09  Pedro Alves  <palves@redhat.com>
7533
7534         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7535         "addr" field.
7536         (allocate_location_exception_catchpoint): New.
7537         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7538         (initialize_throw_catchpoint_ops): Install
7539         allocate_location_exception_catchpoint as allocate_location
7540         method.
7541         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7542         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7543         bp_loc_other.
7544         (breakpoint_address_is_meaningful): Delete.
7545         (bl_address_is_meaningful): New.
7546         (breakpoint_locations_match): Adjust comment.
7547         (bp_location_from_bp_type): New, factored out of...
7548         (bp_location::bp_location(breakpoint *)): ... this.
7549         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7550         factored out of...
7551         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7552         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7553         breakpoint_address_is_meaningful.
7554         (bp_locations_compare): Adjust comment.
7555         (update_global_location_list): Use bl_address_is_meaningful
7556         instead of breakpoint_address_is_meaningful.
7557         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7558         explicit.
7559         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7560         * python/py-breakpoint.c (bppy_get_location): No longer check
7561         whether location is null.
7562
7563 2019-07-09  Pedro Alves  <palves@redhat.com>
7564
7565         PR c++/15468
7566         * breakpoint.c (print_one_breakpoint_location): Remove
7567         single-location assert.
7568
7569 2019-07-09  Tom Tromey  <tom@tromey.com>
7570
7571         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7572         * configure: Rebuild.
7573         * configure.ac: Change common to gdbsupport.
7574         * gdbsupport: Rename from common.
7575         * acinclude.m4: Change common to gdbsupport.
7576         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7577         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7578         gdbsupport.
7579         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7580         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7581         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7582         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7583         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7584         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7585         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7586         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7587         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7588         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7589         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7590         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7591         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7592         coff-pe-read.c, command.h, compile/compile-c-support.c,
7593         compile/compile-c.h, compile/compile-cplus-symbols.c,
7594         compile/compile-cplus-types.c, compile/compile-cplus.h,
7595         compile/compile-loc2c.c, compile/compile.c, completer.c,
7596         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7597         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7598         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7599         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7600         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7601         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7602         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7603         features/aarch64-core.c, features/aarch64-fpu.c,
7604         features/aarch64-pauth.c, features/aarch64-sve.c,
7605         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7606         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7607         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7608         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7609         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7610         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7611         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7612         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7613         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7614         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7615         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7616         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7617         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7618         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7619         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7620         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7621         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7622         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7623         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7624         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7625         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7626         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7627         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7628         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7629         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7630         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7631         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7632         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7633         minsyms.c, mips-linux-tdep.c, namespace.h,
7634         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7635         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7636         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7637         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7638         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7639         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7640         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7641         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7642         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7643         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7644         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7645         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7646         procfs.c, producer.c, progspace.h, psymtab.h,
7647         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7648         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7649         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7650         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7651         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7652         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7653         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7654         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7655         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7656         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7657         target-memory.c, target.c, target.h, target/waitstatus.c,
7658         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7659         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7660         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7661         unittests/array-view-selftests.c,
7662         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7663         unittests/common-utils-selftests.c,
7664         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7665         unittests/format_pieces-selftests.c,
7666         unittests/function-view-selftests.c,
7667         unittests/lookup_name_info-selftests.c,
7668         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7669         unittests/mkdir-recursive-selftests.c,
7670         unittests/observable-selftests.c,
7671         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7672         unittests/parse-connection-spec-selftests.c,
7673         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7674         unittests/scoped_fd-selftests.c,
7675         unittests/scoped_mmap-selftests.c,
7676         unittests/scoped_restore-selftests.c,
7677         unittests/string_view-selftests.c, unittests/style-selftests.c,
7678         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7679         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7680         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7681         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7682         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7683         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7684
7685 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7686
7687         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7688         bool value.
7689         (decode_digits_ordinary): Set explicit_line field in sal.
7690         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7691         symtab_and_line that was set on an explicit line number in
7692         assembler code.  Do always update the recorded symtab and line if
7693         we do skip the prologue.
7694
7695 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7696
7697         * breakpoint.c (set_breakpoint_location_function): Remove
7698         explicit_loc parameter.
7699         (momentary_breakpoint_from_master): Update call to
7700         set_breakpoint_location_function.
7701         (add_location_to_breakpoint): Likewise.
7702
7703 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7704
7705         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7706         required features based on default bfd type when no specific bfd
7707         is present.
7708
7709 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7710
7711         * NEWS: Mention that GDB printf and eval commands can now print
7712         C-style and Ada-style convenience var strings without
7713         calling the inferior.
7714         * printcmd.c (printf_c_string): Locally print GDB internal var
7715         instead of transiting via the inferior.
7716         (printf_wide_c_string): Likewise.
7717
7718 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7719
7720         PR breakpoints/25011
7721         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7722
7723 2019-07-04  Tom Tromey  <tom@tromey.com>
7724
7725         PR tui/24724:
7726         * tui/tui-winsource.c (tui_clear_source_content): Update.
7727         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7728         (tui_update_breakpoint_info): Update.
7729         (tui_set_exec_info_content): Update.
7730         * tui/tui-source.c (tui_set_source_content_nil): Update.
7731         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7732         has_break.
7733         * tui/tui-data.h (enum tui_bp_flag): New.
7734         (tui_bp_flags): New enum flags type.
7735         (struct tui_source_element) <break_mode>: Change type.  Rename
7736         from has_break.
7737         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7738         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7739         constants.
7740         * tui/tui-winsource.h: Fix comment.
7741
7742 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7743
7744         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7745         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7746         (store_fpregs_to_thread)
7747         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7748         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7749         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7750         (IWMMXT_REGS_SIZE): Add define.
7751         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7752         (fetch_vfp_regs, store_vfp_regs)
7753         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7754         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7755
7756 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7757
7758         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7759         defines.
7760         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7761         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7762         (ARM_INT_REGISTER_SIZE): ...to this.
7763         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7764         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7765         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7766         (arm_linux_collect_gregset, supply_nwfpe_register)
7767         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7768         defines.
7769         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7770         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7771         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7772         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7773         (arm_return_in_memory, arm_store_return_value)
7774         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7775         (arm_record_ld_st_multiple): Likewise.
7776         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7777         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7778
7779 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7780
7781         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7782         AARCH64_DISPLACED_MODIFIED_INSNS.
7783         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7784         (aarch64_displaced_step_copy_insn): Likewise.
7785         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7786         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7787         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7788         ARM_DISPLACED_MODIFIED_INSNS.
7789         * arm-tdep.c (arm_gdbarch_init): Likewise.
7790         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7791         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7792         (struct arm_displaced_step_closure): Use
7793         ARM_DISPLACED_MODIFIED_INSNS.
7794
7795 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7796
7797         * features/Makefile: Remove unused xml files.
7798         * features/aarch64.xml: Remove.
7799         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7800         * features/i386/amd64-avx-avx512.xml: Remove.
7801         * features/i386/amd64-avx-linux.xml: Remove.
7802         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7803         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7804         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7805         * features/i386/amd64-avx-mpx.xml: Remove.
7806         * features/i386/amd64-avx.xml: Remove.
7807         * features/i386/amd64-linux.xml: Remove.
7808         * features/i386/amd64-mpx-linux.xml: Remove.
7809         * features/i386/amd64-mpx.xml: Remove.
7810         * features/i386/amd64.xml: Remove.
7811         * features/i386/i386-avx-avx512-linux.xml: Remove.
7812         * features/i386/i386-avx-avx512.xml: Remove.
7813         * features/i386/i386-avx-linux.xml: Remove.
7814         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7815         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7816         * features/i386/i386-avx-mpx-linux.xml: Remove.
7817         * features/i386/i386-avx-mpx.xml: Remove.
7818         * features/i386/i386-avx.xml: Remove.
7819         * features/i386/i386-linux.xml: Remove.
7820         * features/i386/i386-mmx-linux.xml: Remove.
7821         * features/i386/i386-mmx.xml: Remove.
7822         * features/i386/i386-mpx-linux.xml: Remove.
7823         * features/i386/i386-mpx.xml: Remove.
7824         * features/i386/i386.xml: Remove.
7825         * features/i386/x32-avx-avx512-linux.xml: Remove.
7826         * features/i386/x32-avx-linux.xml: Remove.
7827         * features/i386/x32-linux.xml: Remove.
7828
7829 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7830
7831         * regformats/aarch64.dat: Remove.
7832         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7833         * regformats/i386/amd64-avx-linux.dat: Remove.
7834         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7835         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7836         * regformats/i386/amd64-linux.dat: Remove.
7837         * regformats/i386/amd64-mpx-linux.dat: Remove.
7838         * regformats/i386/amd64.dat: Remove.
7839         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7840         * regformats/i386/i386-avx-linux.dat: Remove.
7841         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7842         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7843         * regformats/i386/i386-linux.dat: Remove.
7844         * regformats/i386/i386-mmx-linux.dat: Remove.
7845         * regformats/i386/i386-mpx-linux.dat: Remove.
7846         * regformats/i386/i386.dat: Remove.
7847         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7848         * regformats/i386/x32-avx-linux.dat: Remove.
7849         * regformats/i386/x32-linux.dat: Remove.
7850
7851 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7852
7853         * aarch64-tdep.c: Remove xml self tests.
7854         * amd64-linux-tdep.c: Likewise.
7855         * amd64-tdep.c: Likewise.
7856         * i386-linux-tdep.c: Likewise.
7857         * i386-tdep.c: Likewise.
7858
7859 2019-07-03  Pedro Alves  <palves@redhat.com>
7860
7861         PR cli/24732
7862         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7863         (pipe_cmd_option_defs): New.
7864         (make_pipe_cmd_options_def_group): New.
7865         (pipe_command): Use gdb::option::process_options.
7866         (pipe_command_completer): New function.
7867         (_initialize_cli_cmds): Install completer for "pipe" command.
7868
7869 2019-07-03  Pedro Alves  <palves@redhat.com>
7870
7871         * cli/cli-option.c (union option_value) <string>: New field.
7872         (struct option_def_and_value): Add ctor, move ctor, dtor and
7873         use DISABLE_COPY_AND_ASSIGN.
7874         (option_def_and_value::clear_value): New.
7875         (parse_option, save_option_value_in_ctx, get_val_type_str)
7876         (add_setshow_cmds_for_options): Handle var_string.
7877         * cli-option.h (union option_def::var_address) <string>: New
7878         field.
7879         (struct string_option_def): New.
7880         * maint-test-options.c (struct test_options_opts): Add default
7881         ctor and use DISABLE_COPY_AND_ASSIGN.
7882         <string_opt>: New field.
7883         (test_options_opts::~test_options_opts): New.
7884         (test_options_opts::dump): Also dump "-string".
7885         (test_options_option_defs): Install "string.
7886
7887 2019-07-03  Pedro Alves  <palves@redhat.com>
7888
7889         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7890         option_value with a null enumeration.
7891         (complete_options): Save the option values in the context.
7892         (save_option_value_in_ctx): New, factored out from ...
7893         (process_options): ... here.
7894         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7895         of the function.
7896         * maint-test-options.c (test_options_opts::dump): New, factored
7897         out from ...
7898         (maintenance_test_options_command_mode): ... here.
7899         (maintenance_test_options_command_completion_result): Delete.
7900         (maintenance_test_options_command_completion_text): Update
7901         comment.
7902         (maintenance_show_test_options_completion_result): Change
7903         prototype.  Just print
7904         maintenance_test_options_command_completion_text.
7905         (save_completion_result): New.
7906         (maintenance_test_options_completer_mode): Pass options context to
7907         complete_options, and then save a dump.
7908         (_initialize_maint_test_options): Use add_cmd to install "maint
7909         show test-options-completion-result".
7910
7911 2019-07-03  Pedro Alves  <palves@redhat.com>
7912
7913         * NEWS (New commands): Mention "with" and "maint with".
7914         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7915         (with_command, with_command_completer): New.
7916         (pipe_command): Adjust to new repeat_previous
7917         interface.
7918         (_initialize_cli_cmds): Install the "with" command and its "w"
7919         alias.
7920         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7921         declarations.
7922         * cli/cli-setshow.c (parse_cli_var_uinteger)
7923         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7924         argument strings for all var_types.
7925         (get_setshow_command_value_string): New, factored out from ...
7926         (do_show_command): ... this.
7927         * cli/cli-setshow.h: Include <string>.
7928         (get_setshow_command_value_string): Declare.
7929         * command.h (repeat_previous): Now returns const char *.  Adjust
7930         comment.
7931         * maint.c: Include "cli/cli-cmds.h".
7932         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7933         (_initialize_maint_cmds): Register the "maintenance with" command.
7934         * top.c (repeat_previous): Move bits from pipe_command here:
7935         Return the saved command line, if any; error out if there's no
7936         command to relaunch.
7937
7938 2019-07-03  Pedro Alves  <palves@redhat.com>
7939
7940         * NEWS (New commands): Mention "maint set/show test-settings"
7941         instead of "maint test-settings".
7942         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7943         (maintenance_test_settings_set_list): Rename to ...
7944         (maintenance_set_test_settings_list): ... this.
7945         (maintenance_test_settings_show_list): Rename to  ...
7946         (maintenance_show_test_settings_list): ... this.
7947         (maintenance_test_settings_cmd): Delete.
7948         (maintenance_test_settings_set_cmd): ...
7949         (maintenance_set_test_settings_cmd): ... this.
7950         (maintenance_test_settings_show_cmd): ...
7951         (maintenance_show_test_settings_cmd): ... this.
7952         (maintenance_test_settings_show_value_cmd):
7953         (maintenance_show_test_settings_value_cmd): ... this.
7954         (_initialize_maint_test_settings): No longer install the "maint
7955         test-settings" prefix command.  Rename "maint test-settings set"
7956         to "maint set test-settings", and "maint test-settings show" to
7957         "maint show test-settings".  Adjust all subcommands.
7958
7959 2019-07-03  Pedro Alves  <palves@redhat.com>
7960
7961         * maint-test-settings.c: Fix file's intro comment.  Replace all
7962         references to "test-options" with references to "test-settings",
7963         in comments.
7964
7965 2019-07-03  Pedro Alves  <palves@redhat.com>
7966
7967         * maint-test-settings.c (maintenance_test_settings_xxx)
7968         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7969         New.
7970         (maintenance_test_settings_enums): Use them.
7971         (maintenance_test_settings_enum): Default to
7972         maintenance_test_settings_xxx.
7973         (_initialize_maint_test_settings): Initialize
7974         MAINTENANCE_TEST_SETTINGS_FILENAME.
7975
7976 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7977
7978         * breakpoint.h (remove_breakpoints_inf): Change return type to
7979         void, move function documentation here.
7980         * breakpoint.c (remove_breakpoints_inf): Change return type to
7981         void, move function documentation to header.
7982
7983 2019-07-02  Pedro Alves  <palves@redhat.com>
7984
7985         * NEWS (Completion improvements): Mention "info threads".
7986         * thread.c (struct info_threads_opts, info_threads_option_defs)
7987         (make_info_threads_options_def_group): New.
7988         (info_threads_command): Use gdb::option::process_options.
7989         (info_threads_command_completer): New.
7990         (_initialize_thread): Use gdb::option::build_help to build the
7991         help text for "info threads".
7992
7993 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7994
7995         * defs.h (generic_load): Move from here...
7996         * symfile.h (generic_load): ... to here.  Rename name parameter
7997         to args.
7998         * symfile.c (generic_load): Add comment.
7999
8000 2019-07-01  Tom Tromey  <tromey@adacore.com>
8001
8002         * dwarf2read.c
8003         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8004         declaration of without_params.  Fix formatting.
8005
8006 2019-07-01  Tom Tromey  <tromey@adacore.com>
8007
8008         * ada-exp.y (find_primitive_type): Update.
8009         * ada-lang.h (ada_lookup_symbol): Update.
8010         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8011         parameter.
8012         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8013
8014 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8015
8016         PR breakpoints/24541
8017         * gdbarch.c: Regenerate.
8018         * gdbarch.h: Regenerate.
8019         * gdbarch.sh: Add 'stap_adjust_register'.
8020         * i386-tdep.c: Include '<unordered_set>'.
8021         (i386_stap_adjust_register): New function.
8022         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8023         * stap-probe.c (stap_parse_register_operand): Call
8024         'gdbarch_stap_adjust_register'.
8025
8026 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8027
8028         PR python/24742
8029         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8030         * python/python.c (do_start_initialization): Use 'xmalloc'
8031         instead of 'PyMem_Malloc'.
8032
8033 2019-06-28  Tom Tromey  <tromey@adacore.com>
8034
8035         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8036         for Ada.
8037
8038 2019-06-27  Tom Tromey  <tromey@adacore.com>
8039
8040         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8041         objfile_key.
8042         (arm_find_mapping_symbol, arm_record_special_symbol)
8043         (_initialize_arm_tdep): Update.
8044         (arm_objfile_data_free): Remove.
8045
8046 2019-06-27  Tom Tromey  <tromey@adacore.com>
8047
8048         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8049         to cp_print_static_field.
8050
8051 2019-06-26  Tom Tromey  <tromey@adacore.com>
8052
8053         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8054         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8055         declare.
8056
8057 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8058
8059         * features/aarch64-core.c (create_feature_aarch64_core):
8060         Regenerate.
8061         * features/aarch64-core.xml: Add cpsr flags.
8062
8063 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8064
8065         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8066         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8067
8068 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8069
8070         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8071         field.
8072         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8073         use.
8074         (arm_record_special_symbol): Don't insert new symbol in sorted
8075         position, push it at the end.
8076
8077 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8078
8079         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8080         (arm_mapping_symbol_s): Remove.
8081         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8082         (arm_mapping_symbol_vec): New typedef.
8083         (struct arm_per_objfile): Add constructor.
8084         <section_maps>: Change type to
8085         std::unique_ptr<arm_mapping_symbol_vec[]>.
8086         (arm_compare_mapping_symbols): Remove.
8087         (arm_find_mapping_symbol): Adjust to section_maps type change.
8088         (arm_objfile_data_free): Call delete on arm_per_objfile.
8089         (arm_record_special_symbol): Adjust to section_maps type change.
8090         Allocate arm_per_objfile with new.
8091
8092 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8093
8094         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8095         with the command prefix.
8096
8097 2019-06-25  Tom Tromey  <tom@tromey.com>
8098
8099         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8100         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8101
8102 2019-06-25  Tom Tromey  <tom@tromey.com>
8103
8104         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8105         type.
8106         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8107         protected.
8108
8109 2019-06-25  Tom Tromey  <tom@tromey.com>
8110
8111         * tui/tui-winsource.c
8112         (tui_source_window_base::set_is_exec_point_at): Add check against
8113         LOA_ADDRESS.
8114
8115 2019-06-25  Tom Tromey  <tom@tromey.com>
8116
8117         * tui/tui-source.c (tui_set_source_content): Don't check before
8118         xfree.
8119         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8120
8121 2019-06-25  Tom Tromey  <tom@tromey.com>
8122
8123         * tui/tui-winsource.h (tui_update_source_window_as_is)
8124         (tui_alloc_source_buffer, tui_line_is_displayed)
8125         (tui_addr_is_displayed): Change type of win_info.
8126         * tui/tui-winsource.c (tui_update_source_window_as_is)
8127         (tui_clear_source_content, tui_show_source_line)
8128         (tui_show_source_content, tui_source_window_base::refill)
8129         (tui_source_window_base::set_is_exec_point_at)
8130         (tui_source_window_base::set_is_exec_point_at)
8131         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8132         (tui_alloc_source_buffer, tui_line_is_displayed)
8133         (tui_addr_is_displayed): Change type of win_info.  Update.
8134         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8135         (tui_source_window_base::do_make_visible_with_new_height):
8136         Update.
8137         * tui/tui-source.c (tui_set_source_content)
8138         (tui_set_source_content_nil)
8139         (tui_source_window::do_scroll_vertical): Update.
8140         * tui/tui-layout.c (show_layout): Update.
8141         * tui/tui-disasm.c (tui_set_disassem_content)
8142         (tui_disasm_window::do_scroll_vertical): Update.
8143         * tui/tui-data.h (tui_win_content): Remove.
8144         (struct tui_gen_win_info) <content, content_size>: Remove.
8145         (struct tui_source_element): Add initializers and destructor.
8146         (union tui_which_element, struct tui_win_element): Remove.
8147         (struct tui_source_window_base) <content>: New field.
8148         (struct tui_data_window): Remove destructor.
8149         (tui_alloc_content, tui_free_win_content)
8150         (tui_free_all_source_wins_content): Don't declare.
8151         * tui/tui-data.c (tui_initialize_static_data): Update.
8152         (init_content_element, tui_alloc_content): Remove.
8153         (~tui_gen_win_info): Update.
8154         (~tui_data_window, tui_free_all_source_wins_content)
8155         (tui_free_win_content, free_content, free_content_elements):
8156         Remove.
8157
8158 2019-06-25  Tom Tromey  <tom@tromey.com>
8159
8160         * tui/tui-winsource.h (tui_clear_source_content)
8161         (tui_erase_source_content, tui_show_source_content): Change type
8162         of win_info.
8163         * tui/tui-winsource.c (tui_clear_source_content)
8164         (tui_erase_source_content, tui_show_source_content): Change type
8165         of win_info.
8166         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8167         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8168         win_info.
8169         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8170         win_info.
8171         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8172
8173 2019-06-25  Tom Tromey  <tom@tromey.com>
8174
8175         * tui/tui-winsource.c (tui_clear_source_content)
8176         (tui_source_window_base::set_is_exec_point_at): Update.
8177         * tui/tui-source.c (tui_set_source_content_nil): Update.
8178         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8179         a bool.
8180         * tui/tui-data.c (init_content_element): Update.
8181
8182 2019-06-25  Tom Tromey  <tom@tromey.com>
8183
8184         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8185         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8186         * tui/tui-layout.c (init_and_make_win): Update.
8187         * tui/tui.h (enum tui_win_type): Update.
8188         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8189         tui_win_is_auxillary.
8190         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8191         tui_win_is_auxillary.
8192
8193 2019-06-25  Tom Tromey  <tom@tromey.com>
8194
8195         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8196         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8197         (tui_delete_data_content_windows, tui_display_all_data)
8198         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8199         Update.
8200         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8201         * tui/tui-regs.c (tui_last_regs_line_no)
8202         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8203         (tui_show_registers): Update.
8204         (tui_show_register_group): Return void.  Update.
8205         (tui_display_registers_from, tui_display_reg_element_at_line)
8206         (tui_display_registers_from_line, tui_check_register_values):
8207         Update.
8208         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8209         member.
8210         (struct tui_data_window) <regs_content>: Now a std::vector.
8211         <regs_content_count>: Remove.
8212         (tui_add_content_elements, tui_free_data_content): Don't declare.
8213         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8214         (init_content_element): Remove DATA_WIN case.  Add assert.
8215         (tui_add_content_elements): Remove.
8216         (tui_data_window): Update.
8217         (tui_free_data_content): Remove.
8218         (free_content_elements): Remove DATA_WIN case.
8219
8220 2019-06-25  Tom Tromey  <tom@tromey.com>
8221
8222         * tui/tui-data.c (tui_data_item_window): Update.
8223         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8224         * tui/tui-windata.c (tui_display_all_data)
8225         (tui_display_data_from_line): Update.
8226         (tui_check_data_values): Remove.
8227         * tui/tui-regs.c (tui_show_register_group)
8228         (tui_display_reg_element_at_line): Update.
8229         * tui/tui-hooks.c (tui_register_changed)
8230         (tui_refresh_frame_and_register_information): Call
8231         tui_check_register_values.
8232         * tui/tui-data.h (struct tui_data_window) <data_content,
8233         data_content_count, data_type>: Remove.
8234         (enum tui_data_type): Remove.
8235
8236         * tui/tui-data.c (tui_data_window::clear_detail)
8237         (~tui_data_window): Update.
8238
8239 2019-06-25  Tom Tromey  <tom@tromey.com>
8240
8241         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8242         declare.
8243         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8244         Rename from tui_first_data_item_displayed.  Update.
8245         (tui_data_window::refresh_all)
8246         (tui_data_window::do_scroll_vertical): Update.
8247         * tui/tui-data.h (struct tui_data_window)
8248         <first_data_item_displayed>: Declare new method.
8249
8250 2019-06-25  Tom Tromey  <tom@tromey.com>
8251
8252         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8253         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8254         contents...
8255         (tui_initialize_static_data): ...here.
8256
8257 2019-06-25  Tom Tromey  <tom@tromey.com>
8258
8259         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8260         (tui_display_registers_from, tui_check_register_values): Update.
8261         (tui_display_register): Remove win_info parameter; update.
8262         (tui_get_register): Change type of parameters.
8263         * tui/tui-data.h (struct tui_data_element): Remove.
8264         (union tui_which_element) <data>: Remove.
8265         <data_window>: Change type.
8266         (struct tui_data_item_window): New.
8267         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8268         case.  Add assert.
8269         (~tui_data_item_window): New destructor.
8270         (free_content_elements): Remove DATA_ITEM_WIN case.
8271
8272 2019-06-25  Tom Tromey  <tom@tromey.com>
8273
8274         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8275         Remove.
8276
8277 2019-06-25  Tom Tromey  <tom@tromey.com>
8278
8279         * tui/tui-data.h (struct tui_command_element): Remove.
8280         (union tui_which_element) <command>: Remove.
8281         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8282         assert.
8283         (free_content_elements): Remove CMD_WIN case.
8284
8285 2019-06-25  Tom Tromey  <tom@tromey.com>
8286
8287         * tui/tui-layout.c (tui_set_layout): Update.
8288         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8289         * tui/tui-data.c (layout_def): Update.
8290
8291 2019-06-25  Tom Tromey  <tom@tromey.com>
8292
8293         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8294         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8295         (tui_source_window_base::set_new_height): Update.
8296         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8297         Update.
8298         (tui_set_locator_fullname, tui_set_locator_info)
8299         (tui_show_frame_info): Update.
8300         * tui/tui-source.c (tui_set_source_content)
8301         (tui_source_is_displayed): Update.
8302         * tui/tui-layout.c (show_source_disasm_command, show_data)
8303         (show_source_or_disasm_and_command): Update.
8304         * tui/tui-disasm.c (tui_set_disassem_content)
8305         (tui_get_begin_asm_address): Update.
8306         * tui/tui-data.h (struct tui_locator_element): Remove.
8307         (union tui_which_element) <locator>: Remove.
8308         (struct tui_locator_window): New.
8309         (tui_locator_win_info_ptr): Change return type.
8310         * tui/tui-data.c (_locator): Change type.
8311         (tui_locator_win_info_ptr): Change return type.
8312         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8313         (tui_alloc_content): Add assert.
8314
8315 2019-06-25  Tom Tromey  <tom@tromey.com>
8316
8317         * tui/tui-winsource.c
8318         (tui_exec_info_window::maybe_allocate_content): New method.
8319         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8320         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8321         (make_source_or_disasm_window): Add cast.
8322         * tui/tui-data.h (union tui_which_element) <simple_string>:
8323         Remove.
8324         (struct tui_source_info): New.
8325         (struct tui_source_window_base) <execution_info>: Change type.
8326         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8327         case, and add assert.
8328         (tui_alloc_content): Add assert.
8329
8330 2019-06-25  Tom Tromey  <tom@tromey.com>
8331
8332         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8333         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8334         * tui/tui-data.c (tui_alloc_win_info): Remove.
8335
8336 2019-06-25  Tom Tromey  <tom@tromey.com>
8337
8338         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8339         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8340         can_highlight.
8341
8342 2019-06-25  Tom Tromey  <tom@tromey.com>
8343
8344         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8345         make_visible_with_new_height method.
8346         (tui_win_info::make_visible_with_new_height): New method.
8347         (tui_source_window_base::do_make_visible_with_new_height)
8348         (tui_data_window::do_make_visible_with_new_height)
8349         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8350         (make_visible_with_new_height): Remove.
8351         (tui_resize_all, tui_adjust_win_heights): Use
8352         make_visible_with_new_height method.
8353         * tui/tui-data.h (struct tui_win_info)
8354         <do_make_visible_with_new_height, make_visible_with_new_height>:
8355         New methods.
8356         (struct tui_source_window_base, struct tui_data_window)
8357         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8358         methods.
8359
8360 2019-06-25  Tom Tromey  <tom@tromey.com>
8361
8362         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8363         method.
8364         (update_tab_width): Call update_tab_width method.
8365         * tui/tui-data.h (struct tui_win_info)
8366         (struct tui_source_window_base) <update_tab_width>: New methods.
8367
8368 2019-06-25  Tom Tromey  <tom@tromey.com>
8369
8370         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8371         parameter.
8372         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8373         parameter.
8374         (tui_gen_win_info::make_visible): Update.
8375         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8376         parameter.
8377         * tui/tui-data.h (enum tui_box): New enum.
8378         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8379
8380 2019-06-25  Tom Tromey  <tom@tromey.com>
8381
8382         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8383         init_and_make_win for EXEC_INFO_WIN.
8384         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8385         longer inline.
8386         (struct tui_win_info) <~tui_win_info>: Inline.
8387         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8388         Don't declare.
8389         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8390         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8391         Remove.
8392         (tui_initialize_static_data): Update.
8393         (~tui_gen_win_info): Handle more cleanup here.
8394         (~tui_source_window_base): Delete "execution_info".
8395         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8396
8397 2019-06-25  Tom Tromey  <tom@tromey.com>
8398
8399         * tui/tui-layout.c (make_command_window): Don't set
8400         can_highlight.
8401         (show_source_disasm_command): Call the reset method.
8402         (show_data): Don't set can_highlight.  Call the reset method.
8403         (tui_gen_win_info::reset): Rename from init_gen_win_info
8404         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8405         (show_source_or_disasm_and_command): Call the reset method.
8406         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8407         (struct tui_cmd_window): Set can_highlight.
8408
8409 2019-06-25  Tom Tromey  <tom@tromey.com>
8410
8411         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8412         from make_visible.
8413         (tui_make_visible, tui_make_invisible): Rewrite.
8414         (tui_win_info::make_visible): Remove.
8415         (tui_source_window_base::make_visible): Update.
8416         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8417         method.  Moved from...
8418         (struct tui_win_info) <make_visible>: ...here.
8419
8420 2019-06-25  Tom Tromey  <tom@tromey.com>
8421
8422         * tui/tui-winsource.c
8423         (tui_source_window_base::do_scroll_horizontal): Remove direction
8424         parameter.
8425         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8426         direction parameter.
8427         * tui/tui-win.c (tui_win_info::forward_scroll)
8428         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8429         (tui_win_info::right_scroll): Update.
8430         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8431         direction parameter.
8432         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8433         direction parameter.
8434         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8435         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8436         Remove direction parameter.
8437         (struct tui_source_window_base, struct tui_source_window)
8438         (struct tui_disasm_window, struct tui_data_window)
8439         (struct tui_cmd_window): Update.
8440
8441 2019-06-25  Tom Tromey  <tom@tromey.com>
8442
8443         * tui/tui-winsource.h (tui_set_exec_info_content)
8444         (tui_show_exec_info_content, tui_erase_exec_info_content)
8445         (tui_clear_exec_info_content, tui_update_exec_info): Change
8446         argument to tui_source_window_base.
8447         * tui/tui-winsource.c (tui_set_exec_info_content)
8448         (tui_show_exec_info_content, tui_erase_exec_info_content)
8449         (tui_clear_exec_info_content, tui_update_exec_info): Change
8450         argument to tui_source_window_base.
8451
8452 2019-06-25  Tom Tromey  <tom@tromey.com>
8453
8454         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8455         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8456
8457 2019-06-25  Tom Tromey  <tom@tromey.com>
8458
8459         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8460         check.
8461
8462 2019-06-25  Tom Tromey  <tom@tromey.com>
8463
8464         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8465         type to void.
8466         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8467         type to void.
8468         * tui/tui-source.c (tui_set_source_content): Update.
8469         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8470
8471 2019-06-25  Tom Tromey  <tom@tromey.com>
8472
8473         * tui/tui-win.c (window_name_completer, tui_set_focus)
8474         (tui_all_windows_info): Use name method.
8475         * tui/tui-data.h (struct tui_gen_win_info)
8476         (struct tui_source_window, struct tui_disasm_window)
8477         (struct tui_data_window, struct tui_cmd_window) <name>: New
8478         method.
8479         (tui_win_name): Don't declare.
8480         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8481         (tui_win_name): Remove.
8482
8483 2019-06-25  Tom Tromey  <tom@tromey.com>
8484
8485         * tui/tui-winsource.h (tui_update_source_window)
8486         (tui_update_source_window_as_is): Change parameter type.
8487         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8488         to be a tui_source_window_base.
8489         (tui_update_source_window_as_is): Likewise.
8490         * tui/tui-win.c (make_visible_with_new_height): Update.
8491
8492 2019-06-25  Tom Tromey  <tom@tromey.com>
8493
8494         * tui/tui-winsource.c (tui_erase_source_content)
8495         (tui_show_source_content, tui_show_exec_info_content)
8496         (tui_erase_exec_info_content): Use refresh_window method.
8497         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8498         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8499         from tui_refresh_win.
8500         (tui_data_window::refresh_window): New method.
8501         (tui_win_info::refresh, tui_source_window_base::refresh)
8502         (tui_refresh_all): Use refresh_window method.
8503         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8504         method.
8505         * tui/tui-regs.c (tui_display_register): Call refresh_window
8506         method.
8507         * tui/tui-layout.c (show_source_disasm_command)
8508         (show_source_or_disasm_and_command): Call refresh_window method.
8509         * tui/tui-data.h (struct tui_gen_win_info)
8510         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8511         New method.
8512
8513 2019-06-25  Tom Tromey  <tom@tromey.com>
8514
8515         * tui/tui.c (tui_rl_other_window, tui_enable)
8516         (tui_is_window_visible, tui_get_command_dimension): Update.
8517         * tui/tui-winsource.c (tui_update_source_window_as_is)
8518         (tui_clear_source_content, tui_erase_source_content)
8519         (tui_show_source_line, tui_source_window_base::refill)
8520         (tui_source_window_base::do_scroll_horizontal)
8521         (tui_source_window_base::set_is_exec_point_at)
8522         (tui_update_breakpoint_info, tui_set_exec_info_content)
8523         (tui_alloc_source_buffer, tui_line_is_displayed)
8524         (tui_addr_is_displayed): Update.
8525         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8526         (tui_check_and_display_highlight_if_needed)
8527         (tui_win_info::make_visible, tui_win_info::refresh)
8528         (tui_refresh_all): Update.
8529         * tui/tui-windata.c (tui_first_data_item_displayed)
8530         (tui_delete_data_content_windows, tui_erase_data_content)
8531         (tui_display_all_data, tui_data_window::refresh_all)
8532         (tui_check_data_values): Update.
8533         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8534         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8535         (tui_win_info::backward_scroll, tui_refresh_all_win)
8536         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8537         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8538         (tui_source_window_base::set_new_height)
8539         (tui_data_window::set_new_height)
8540         (make_invisible_and_set_new_height)
8541         (make_visible_with_new_height, new_height_ok)
8542         (parse_scrolling_args): Update.
8543         * tui/tui-stack.c (tui_show_frame_info): Update.
8544         * tui/tui-source.c (tui_set_source_content)
8545         (tui_set_source_content_nil, tui_source_is_displayed)
8546         (tui_source_window::do_scroll_vertical): Update.
8547         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8548         (tui_display_registers_from, tui_display_reg_element_at_line)
8549         (tui_check_register_values, tui_reg_command): Update.
8550         * tui/tui-layout.c (tui_default_win_height)
8551         (show_source_disasm_command, show_data, init_and_make_win)
8552         (show_source_or_disasm_and_command): Update.
8553         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8554         (tui_redisplay_readline, tui_mld_flush)
8555         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8556         (tui_getc): Update.
8557         * tui/tui-disasm.c (tui_set_disassem_content)
8558         (tui_disasm_window::do_scroll_vertical): Update.
8559         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8560         Now virtual.
8561         (struct tui_win_info): Derive from tui_gen_win_info.
8562         <~tui_win_info>: Mark as override.
8563         <generic>: Remove member.
8564         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8565         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8566         (~tui_data_window, ~tui_win_info)
8567         (tui_free_all_source_wins_content): Update.
8568         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8569
8570 2019-06-25  Tom Tromey  <tom@tromey.com>
8571
8572         * tui/tui-layout.c (init_and_make_win): Use new.
8573         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8574         destructor, initializers.
8575         (tui_alloc_generic_win_info): Don't declare.
8576         * tui/tui-data.c (_locator): Add argument to constructor.
8577         (source_win, disasm_win): New globals.
8578         (exec_info): Remove.
8579         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8580         Update.
8581         (tui_alloc_generic_win_info): Remove.
8582         (init_content_element): Use new.
8583         (tui_win_info::tui_win_info): Update.
8584         (free_content_elements) <case DATA_WIN>: Use delete.
8585
8586 2019-06-25  Tom Tromey  <tom@tromey.com>
8587
8588         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8589         * tui/tui-windata.c (tui_first_data_item_displayed)
8590         (tui_delete_data_content_windows): Update.
8591         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8592         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8593         (tui_display_registers_from, tui_check_register_values): Update.
8594         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8595         pointer.
8596         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8597         window.
8598         (tui_free_data_content): Update.
8599         (free_content_elements) <case DATA_WIN>: Free the window.
8600
8601 2019-06-25  Tom Tromey  <tom@tromey.com>
8602
8603         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8604         Update.
8605         * tui/tui-layout.c (make_command_window)
8606         (show_source_disasm_command, show_data, init_and_make_win)
8607         (show_source_or_disasm_and_command): Update.
8608         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8609         method.
8610         <can_highight, is_highlighted>: Now bool.
8611         (tui_set_win_highlight): Don't declare.
8612         * tui/tui-data.c (tui_set_win_highlight): Remove.
8613
8614 2019-06-25  Tom Tromey  <tom@tromey.com>
8615
8616         * tui/tui-wingeneral.c (make_visible): Remove check of window
8617         type.
8618
8619 2019-06-25  Tom Tromey  <tom@tromey.com>
8620
8621         * tui/tui-win.c (tui_win_info::max_height)
8622         (tui_cmd_window::max_height): New methods.
8623         (new_height_ok): Call max_height.
8624         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8625         <max_height>: New method.
8626
8627 2019-06-25  Tom Tromey  <tom@tromey.com>
8628
8629         * tui/tui-win.c (tui_source_window_base::set_new_height)
8630         (tui_data_window::set_new_height): New methods.
8631         (make_invisible_and_set_new_height): Call set_new_height method.
8632         * tui/tui-data.h (struct tui_win_info)
8633         (struct tui_source_window_base, struct tui_data_window)
8634         <set_new_height>: New method.
8635
8636 2019-06-25  Tom Tromey  <tom@tromey.com>
8637
8638         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8639         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8640         tui_refresh_data_win.
8641         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8642         method.
8643         (tui_refresh_all_win): Call the refresh_all method.
8644         (tui_set_focus): Likewise.
8645         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8646         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8647         Likewise.
8648
8649 2019-06-25  Tom Tromey  <tom@tromey.com>
8650
8651         * tui/tui-winsource.h (tui_refill_source_window)
8652         (tui_set_is_exec_point_at): Don't declare.
8653         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8654         (tui_source_window_base::refill): Rename from
8655         tui_refill_source_window.
8656         (tui_source_window_base::do_scroll_horizontal): Update.
8657         (tui_source_window_base::set_is_exec_point_at): Rename from
8658         tui_set_is_exec_point_at.
8659         (tui_update_all_breakpoint_info): Update.
8660         * tui/tui-stack.c (tui_show_frame_info): Update.
8661         * tui/tui-layout.c (show_data): Add cast.
8662         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8663         * tui/tui-data.h (struct tui_source_window_base) <refill,
8664         set_is_exec_point_at>: New methods.
8665         (tui_source_windows, tui_add_to_source_windows): Update types.
8666         (tui_add_to_source_windows): Remove redundant declaration.
8667         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8668         (tui_source_windows): Change return type.
8669         (tui_clear_source_windows_detail): Update.
8670         (tui_add_to_source_windows): Change type of parameter.
8671         (tui_free_all_source_wins_content): Update.
8672
8673 2019-06-25  Tom Tromey  <tom@tromey.com>
8674
8675         * tui/tui-wingeneral.c (tui_win_info::refresh)
8676         (tui_source_window_base::refresh): New methods.
8677         (tui_refresh_all): Call the refresh method.
8678         * tui/tui-data.h (struct tui_win_info)
8679         (struct tui_source_window_base) <refresh>: New method.
8680
8681 2019-06-25  Tom Tromey  <tom@tromey.com>
8682
8683         * tui/tui.h (tui_is_window_visible): Return bool.
8684         * tui/tui.c (tui_is_window_visible): Return bool.
8685         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8686         (tui_make_visible, tui_make_invisible)
8687         (tui_win_info::make_visible)
8688         (tui_source_window_base::make_visible, make_all_visible)
8689         (tui_make_all_visible, tui_make_all_invisible): Update.
8690         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8691         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8692         bool.
8693         (struct tui_win_info, struct tui_source_window_base)
8694         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8695         * tui/tui-data.c (tui_init_generic_part): Update.
8696
8697 2019-06-25  Tom Tromey  <tom@tromey.com>
8698
8699         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8700         (tui_source_window_base::make_visible): New methods.
8701         (make_all_visible): Make method call.
8702         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8703         (struct tui_source_window_base, struct tui_cmd_window): Override
8704         make_visible.
8705         (tui_win_is_source_type): Don't declare.
8706         * tui/tui-data.c (tui_win_is_source_type): Remove.
8707
8708 2019-06-25  Tom Tromey  <tom@tromey.com>
8709
8710         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8711         NULL check.
8712
8713 2019-06-25  Tom Tromey  <tom@tromey.com>
8714
8715         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8716         Inline constructor.  Add initializers for members.
8717         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8718         constructors; now inline in class.
8719
8720 2019-06-25  Tom Tromey  <tom@tromey.com>
8721
8722         * tui/tui-regs.c (tui_show_registers): Update.
8723         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8724         bool.
8725         * tui/tui-data.c (tui_data_window::clear_detail)
8726         (tui_data_window): Update.
8727
8728 2019-06-25  Tom Tromey  <tom@tromey.com>
8729
8730         * tui/tui-windata.c (tui_display_all_data)
8731         (tui_display_data_from_line, tui_display_data_from)
8732         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8733         Update.
8734         * tui/tui-regs.c (tui_last_regs_line_no)
8735         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8736         (tui_show_registers, tui_show_register_group)
8737         (tui_display_registers_from, tui_display_reg_element_at_line)
8738         (tui_display_registers_from_line, tui_check_register_values)
8739         (tui_reg_next, tui_reg_prev): Update.
8740         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8741         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8742         tui_data_window.
8743         (struct tui_win_info) <detail>: Remove.  Add new fields from
8744         tui_data_info.
8745         (TUI_DATA_WIN): Add cast.
8746         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8747         (~tui_data_window): Simplify.
8748
8749 2019-06-25  Tom Tromey  <tom@tromey.com>
8750
8751         * tui/tui-layout.c (show_source_disasm_command)
8752         (show_source_or_disasm_and_command): Update.
8753         * tui/tui-io.c (update_cmdwin_start_line)
8754         (tui_redisplay_readline): Update.
8755         * tui/tui-data.h (struct tui_command_info): Remove.
8756         (struct tui_win_info) <detail>: Remove command_info member.
8757         (struct tui_data_window) <start_line>: New member, from
8758         tui_command_info.
8759         (TUI_CMD_WIN): Add casts.
8760
8761 2019-06-25  Tom Tromey  <tom@tromey.com>
8762
8763         * tui/tui-winsource.c (tui_update_source_window)
8764         (tui_refill_source_window)
8765         (tui_source_window_base::do_scroll_horizontal)
8766         (tui_update_breakpoint_info, tui_set_exec_info_content)
8767         (tui_show_exec_info_content, tui_erase_exec_info_content)
8768         (tui_clear_exec_info_content): Update.
8769         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8770         Update.
8771         * tui/tui-win.c (make_invisible_and_set_new_height)
8772         (make_visible_with_new_height): Update.
8773         * tui/tui-source.c (tui_set_source_content)
8774         (tui_show_symtab_source): Update.
8775         * tui/tui-layout.c (extract_display_start_addr)
8776         (show_source_disasm_command, show_data)
8777         (make_source_or_disasm_window)
8778         (show_source_or_disasm_and_command): Update.
8779         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8780         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8781         "gdbarch".
8782         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8783         to tui_source_window_base.
8784         (struct tui_win_info) <detail>: Remove source_info member.
8785         (struct tui_source_window_base) <has_locator>: Inline.
8786         Move contents from tui_source_info; rename has_locator member to
8787         m_has_locator.
8788         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8789         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8790         header file.
8791         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8792         Simplify.
8793         (tui_free_all_source_wins_content): Cast to
8794         tui_source_window_base.
8795
8796 2019-06-25  Tom Tromey  <tom@tromey.com>
8797
8798         * tui/tui-win.c (make_invisible_and_set_new_height)
8799         (make_visible_with_new_height): Call has_locator method.
8800         * tui/tui-layout.c (show_source_disasm_command, show_data)
8801         (show_source_or_disasm_and_command): Update for bool change.
8802         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8803         (tui_win_info) <has_locator>: New method.
8804         (struct tui_source_window_base) <has_locator>: New method.
8805         (tui_win_has_locator): Don't declare.
8806         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8807         from tui_win_has_locator.
8808         (tui_source_window_base): Use false, not FALSE.
8809
8810 2019-06-25  Tom Tromey  <tom@tromey.com>
8811
8812         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8813         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8814         clear_detail method directly.
8815         (tui_clear_win_detail): Remove.
8816
8817 2019-06-25  Tom Tromey  <tom@tromey.com>
8818
8819         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8820         "this", not TUI_DISASM_WIN.
8821
8822 2019-06-25  Tom Tromey  <tom@tromey.com>
8823
8824         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8825         declare.
8826         * tui/tui-winsource.c
8827         (tui_source_window_base::do_scroll_horizontal): Rename from
8828         tui_horizontal_source_scroll.
8829         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8830         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8831         from tui_vertical_data_scroll.
8832         * tui/tui-win.h (tui_scroll): Don't declare.
8833         * tui/tui-win.c (tui_win_info::forward_scroll)
8834         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8835         (tui_win_info::right_scroll): Rename and update.
8836         (tui_scroll_forward_command, tui_scroll_backward_command)
8837         (tui_scroll_left_command, tui_scroll_right_command): Update.
8838         (tui_scroll): Remove.
8839         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8840         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8841         from tui_vertical_source_scroll.
8842         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8843         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8844         from tui_vertical_disassem_scroll.
8845         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8846         do_scroll_horizontal>: New methods.
8847         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8848         Likewise.
8849         (struct tui_source_window_base): Add do_scroll_horizontal.
8850         (struct tui_source_window, struct tui_disasm_window): Add
8851         do_scroll_vertical.
8852         (struct tui_data_window, struct tui_cmd_window): Add
8853         do_scroll_horizontal and do_scroll_vertical.
8854         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8855
8856 2019-06-25  Tom Tromey  <tom@tromey.com>
8857
8858         * tui/tui-data.h (struct tui_source_window_base): New struct.
8859         (struct tui_source_window): Derive from tui_source_window_base.
8860         (struct tui_disasm_window): New struct.
8861         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8862         from tui_source_window::clear_detail.
8863         (tui_source_window_base): Rename from tui_source_window.
8864         (~tui_source_window_base): Rename from ~tui_source_window.
8865         (tui_alloc_win_info): Create a tui_disasm_window.
8866
8867 2019-06-25  Tom Tromey  <tom@tromey.com>
8868
8869         * tui/tui-data.h (struct tui_source_window)
8870         (struct tui_data_window): Declare destructors.
8871         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8872         destructors.
8873         (tui_win_info): Simplify.
8874
8875 2019-06-25  Tom Tromey  <tom@tromey.com>
8876
8877         * tui/tui-winsource.c (tui_display_main)
8878         (tui_update_source_windows_with_addr)
8879         (tui_update_all_breakpoint_info): Update.
8880         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8881         (new_height_ok, parse_scrolling_args): Update.
8882         * tui/tui-stack.c (tui_show_frame_info): Update.
8883         * tui/tui-data.h (struct tui_list): Remove.
8884         (tui_source_windows): Return a reference to a std::vector.
8885         * tui/tui-data.c (source_windows): Now a std::vector.
8886         (tui_source_windows): Change return type.
8887         (tui_clear_source_windows): Rewrite.
8888         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8889         (tui_free_all_source_wins_content): Rewrite.
8890
8891 2019-06-25  Tom Tromey  <tom@tromey.com>
8892
8893         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8894         (struct tui_data_window, struct tui_cmd_window): Declare
8895         clear_detail method.
8896         * tui/tui-data.c (tui_source_window::clear_detail)
8897         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8898         methods.
8899         (tui_clear_win_detail): Simplify.
8900
8901 2019-06-25  Tom Tromey  <tom@tromey.com>
8902
8903         * tui/tui-layout.c (make_source_window, make_disasm_window)
8904         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8905         Return the new window.
8906         (show_source_disasm_command, show_data)
8907         (show_source_or_disasm_and_command): Update.
8908
8909 2019-06-25  Tom Tromey  <tom@tromey.com>
8910
8911         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8912         parameter.  Return the new window.
8913         (show_source_disasm_command): Update and remove NULL check.
8914         (show_source_or_disasm_and_command): Update.
8915
8916 2019-06-25  Tom Tromey  <tom@tromey.com>
8917
8918         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8919
8920 2019-06-25  Tom Tromey  <tom@tromey.com>
8921
8922         * tui/tui-data.h (struct tui_win_info): Make constructor
8923         protected.  Make destructor virtual.  Add initializers.
8924         (tui_source_window, tui_data_window, tui_cmd_window): New
8925         classes.
8926         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8927         constructor.  Add "type" parameter.
8928         (tui_source_window, tui_data_window, tui_cmd_window): New
8929         constructors.
8930         (tui_alloc_win_info): Instantiate the appropriate subclass.
8931
8932 2019-06-25  Tom Tromey  <tom@tromey.com>
8933
8934         * tui/tui-win.c (tui_resize_all): Use delete.
8935         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8936         destructor.
8937         (tui_free_window): Don't declare.
8938         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8939         Update.
8940
8941 2019-06-25  Tom Tromey  <tom@tromey.com>
8942
8943         * tui/tui-data.h (struct tui_win_info): Add constructor.
8944         * tui/tui-data.c (tui_alloc_win_info): Use new.
8945         (tui_free_window): Use delete.
8946
8947 2019-06-22  Tom Tromey  <tom@tromey.com>
8948
8949         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8950         declare.
8951         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8952
8953 2019-06-22  Tom Tromey  <tom@tromey.com>
8954
8955         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8956         declare.
8957         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8958
8959 2019-06-22  Tom de Vries  <tdevries@suse.de>
8960
8961         * dwarf2read.c (create_addrmap_from_aranges)
8962         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8963         instead of '%zu'.
8964
8965 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8966
8967         * dwarf2read.h (dwarf2_section_info_def): Remove.
8968         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8969         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8970         std::vector<dwarf2_section_info>.
8971         (struct dwo_file) <~dwo_file>: Remove.
8972         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8973         types field.
8974         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8975         (dwarf2_read_debug_names): Likewise.
8976         (create_debug_types_hash_table): Change parameter type to
8977         array_view, adjust code accordingly.
8978         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8979         (partial_die_info::fixup): Likewise.
8980         (determine_prefix): Likewise.
8981         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8982
8983 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8984
8985         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8986         gdb_bfd_ref_ptr.
8987         <~dwo_file>: Remove call to gdb_bfd_unref.
8988         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8989         gdb_bfd_ref_ptr::get.
8990
8991 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8992
8993         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8994         type to htab_up.
8995         * dwarf2read.c (struct dwo_file): Initialize fields.
8996         <~dwo_file>: New.
8997         (free_dwo_file): Remove, move content to ~dwo_file.
8998         (struct dwo_file_deleter): Remove.
8999         (dwo_file_up>: Remove custom deleter.
9000         (free_dwo_files): Remove.
9001         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9002         dwo_files.
9003         (process_skeletonless_type_units): Call unique_ptr::get.
9004         (allocate_dwo_file_hash_table): Add deleter to created hash
9005         table.  Change return type to htab_up.
9006         (lookup_dwo_file_slot): Don't memset dwo_file, call
9007         unique_ptr::get.
9008         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9009         (create_dwo_unit_in_dwp_v2): Likewise.
9010         (open_and_init_dwo_file): Likewise.
9011         (free_dwo_file_from_slot): Remove.
9012
9013 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9014
9015         * dwarf2read.h (struct dwarf2_section_info) <readin,
9016         is_virtual>: Change type to bool.
9017         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9018         true instead of 1.
9019
9020 2019-06-19  Tom Tromey  <tom@tromey.com>
9021
9022         * tui/tui-data.h (tui_init_content_element): Don't declare.
9023
9024 2019-06-19  Tom Tromey  <tom@tromey.com>
9025
9026         * tui/tui-data.h (tui_init_win_info): Don't declare.
9027
9028 2019-06-19  Tom de Vries  <tdevries@suse.de>
9029
9030         * dwarf2read.h (abstract_to_concrete): Change type to
9031         std::unordered_map<sect_offset, std::vector<sect_offset>,
9032         gdb::hash_enum<sect_offset>>.
9033
9034 2019-06-19  Tom Tromey  <tromey@adacore.com>
9035
9036         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9037         EVAL_AVOID_SIDE_EFFECTS specially.
9038
9039 2019-06-19  Tom Tromey  <tromey@adacore.com>
9040
9041         * source-cache.c (highlighter): New global.
9042         (source_cache::get_source_lines): Create a highlighter on demand.
9043
9044 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9045
9046         * defs.h (deprecated_interactive_hook): Delete declaration.
9047         * interps.c (clear_interpreter_hooks): Remove use of
9048         deprecated_interactive_hook.
9049         * top.c (deprecated_interactive_hook): Delete definition.
9050         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9051
9052 2019-06-18  Tom de Vries  <tdevries@suse.de>
9053
9054         PR gdb/24515
9055         * dwarf2read.h (abstract_to_concrete): Change type from
9056         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9057         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9058         * dwarf2read.c (read_variable): Update.
9059         (dwarf2_fetch_die_loc_sect_off): Update.
9060
9061 2019-06-17  Tom de Vries  <tdevries@suse.de>
9062
9063         PR gdb/24617
9064         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9065         accessing parent[parent_len - 1].
9066
9067 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9068
9069         PR gdb/24364
9070         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9071         call dtrace_process_dof with NULL dof.
9072
9073 2019-06-16  Tom de Vries  <tdevries@suse.de>
9074
9075         PR gdb/24445
9076         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9077
9078 2019-06-16  Tom Tromey  <tom@tromey.com>
9079
9080         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9081         (make_all_visible): Use address of member.
9082
9083 2019-06-16  Tom Tromey  <tom@tromey.com>
9084
9085         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9086         (tui_free_window, free_content, free_content_elements): Remove
9087         unnecessary cast.
9088         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9089         cast.
9090         * tui/tui-regs.c (tui_show_register_group)
9091         (tui_display_registers_from, tui_display_reg_element_at_line):
9092         Remove unnecessary cast.
9093
9094 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9095
9096         * linux-nat.c (normal_mask): Delete.
9097         (_initialize_linux_nat): Don't initialise normal_mask.
9098
9099 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9100
9101         PR gdb/24445
9102         * dwarf-index-write.h (write_psymtabs_to_index): Add
9103         dwz_basename parameter.
9104         * dwarf-index-write.c (write_gdbindex): Move file writing to
9105         write_gdbindex_1.  Change return type void.
9106         (assert_file_size): Move up, remove filename parameter.
9107         (write_gdbindex_1): New function.
9108         (write_debug_names): Change return type to void, call
9109         assert_file_size.
9110         (struct index_wip_file): New struct.
9111         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9112         file logic to index_wip_file.  Write index for dwz file if
9113         needed.
9114         (save_gdb_index_command): Pass basename of dwz file, if present.
9115         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9116         build-id of dwz file, if present.
9117         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9118         (dwarf2_get_dwz_file): Likewise.
9119         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9120         (dwarf2_get_dwz_file): Likewise.
9121
9122 2019-06-16  Tom Tromey  <tom@tromey.com>
9123
9124         * coffread.c (process_coff_symbol): Use xstrdup.
9125         * value.c (create_internalvar): Use xstrdup.
9126
9127 2019-06-16  Tom Tromey  <tom@tromey.com>
9128
9129         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9130         * breakpoint.c (stopin_command, stopat_command)
9131         (until_break_command, decode_location_default): Remove unnecessary
9132         cast.
9133         * utils.c (subset_compare): Remove unnecessary cast.
9134         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9135         cast.
9136         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9137         cast.
9138         * infcmd.c (path_command): Remove unnecessary cast.
9139         * coffread.c (decode_type): Remove unnecessary cast.
9140         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9141         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9142         * tui/tui-stack.c (tui_show_locator_content)
9143         (tui_show_frame_info): Remove unnecessary cast.
9144         * tui/tui-win.c (tui_scroll_forward_command)
9145         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9146         (parse_scrolling_args): Remove unnecessary cast.
9147         * tui/tui-data.c (init_win_info, tui_del_window)
9148         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9149         (free_content_elements): Remove unnecessary cast.
9150         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9151         unnecessary cast.
9152         * tui/tui-source.c (tui_set_source_content)
9153         (tui_vertical_source_scroll): Remove unnecessary cast.
9154         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9155         cast.
9156         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9157         * tui/tui-regs.c (tui_display_registers_from)
9158         (tui_display_register): Remove unnecessary cast.
9159         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9160         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9161         (make_visible): Remove unnecessary cast.
9162         * tui/tui-winsource.c (tui_erase_source_content)
9163         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9164         unnecessary cast.
9165         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9166         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9167         * stabsread.c (read_type, read_array_type, read_range_type):
9168         Remove unnecessary cast.
9169         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9170         (parse_symbol, parse_type, upgrade_type, parse_external)
9171         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9172         unnecessary cast.
9173         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9174
9175 2019-06-16  Tom Tromey  <tom@tromey.com>
9176
9177         * tui/tui-data.c (tui_alloc_generic_win_info)
9178         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9179         checks.
9180
9181 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9182             Andrew Burgess  <andrew.burgess@embecosm.com>
9183
9184         * f-typeprint.c (f_print_type): Don't return early for not
9185         associated or not allocated types.
9186         (f_type_print_varspec_suffix): Add print_rank parameter and print
9187         ranks of array types in case they dangling.
9188         (f_type_print_base): Add print_rank parameter.
9189
9190 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9191
9192         * NEWS: Mention new MI commands.
9193         * break-catch-throw.c (enum exception_event_kind): Move to
9194         breakpoint.h.
9195         (print_mention_exception_catchpoint): Output text as a single
9196         message.
9197         (catch_exception_command_1): Rename to...
9198         (catch_exception_event): ...this, make non-static, update header
9199         command, and change some parameter types.
9200         (catch_catch_command): Update for changes to
9201         catch_exception_command_1.
9202         (catch_throw_command): Likewise.
9203         (catch_rethrow_command): Likewise.
9204         * breakpoint.c (enum exception_event_kind): Delete.
9205         * breakpoint.h (enum exception_event_kind): Moved here from
9206         break-catch-throw.c.
9207         (catch_exception_event): Declare.
9208         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9209         (mi_cmd_catch_throw): New function.
9210         (mi_cmd_catch_rethrow): New function.
9211         (mi_cmd_catch_catch): New function.
9212         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9213         'catch-catch' entries.
9214         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9215         (mi_cmd_catch_rethrow): Declare.
9216         (mi_cmd_catch_catch): Declare.
9217
9218 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9219
9220         * annotate.c (annotate_source_line): Change return type to void,
9221         update implementation to match.
9222         * annotate.h (annotate_source_line): Change return type to void,
9223         update header comment.
9224         * stack.c (print_frame_info): Don't change what frame information
9225         is printed based on whether annotations are on or not.
9226
9227 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9228
9229         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9230         (annotate_source): Make static.
9231         (annotate_source_line): Moved from source.c and renamed from
9232         identify_source_line.  Update the return type.
9233         * annotate.h (annotate_source): Delete declaration.
9234         (annotate_source_line): Declaration moved from source.h, and
9235         renamed from identify_source_line.  Return type updated.
9236         * source.c (identify_source_line): Moved to annotate.c and renamed
9237         to annotate_source_line.
9238         (info_line_command): Remove check of annotation_level.
9239         * source.h (identify_source_line): Move declaration to annotate.h
9240         and rename to annotate_source_line.
9241         * stack.c: Add 'annotate.h' include.
9242         (print_frame_info): Remove check of annotation_level before
9243         calling annotate_source_line.
9244
9245 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9246
9247         * source-cache.c (source_cache::get_plain_source_lines): Use
9248         open_source_file_with_line_charpos instead of just
9249         open_source_file, remove call to find_source_lines.
9250         (source_cache::get_source_lines): Likewise.
9251         * source.c (find_source_lines): Make static.
9252         (get_filename_and_charpos): Renamed into...
9253         (open_source_file_with_line_charpos): ..this along with changes to
9254         return a scoped_fd, and some other minor clean ups.
9255         (identify_source_line): Use open_source_file_with_line_charpos.
9256         (search_command_helper): Use open_source_file_with_line_charpos
9257         instead of just open_source_file, remove call to
9258         find_source_lines.
9259         * source.h (open_source_file_with_line_charpos): Declare new
9260         function.
9261         (find_source_lines): Delete declaration.
9262
9263 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9264
9265         * source.c (get_filename_and_charpos): Remove fullname
9266         parameter.
9267         (identify_source_line): Update call to get_filename_and_charpos.
9268
9269 2019-06-14  Tom Tromey  <tromey@adacore.com>
9270
9271         PR gdb/24502:
9272         * ui-style.h (skip_ansi_escape): Update comment.
9273         * ui-file.h (class no_terminal_escape_file): New class.
9274         * ui-file.c (no_terminal_escape_file::write)
9275         (no_terminal_escape_file::puts): New methods.
9276         * cli/cli-logging.c (handle_redirections): Use
9277         no_terminal_escape_file.
9278
9279 2019-06-14  Tom Tromey  <tromey@adacore.com>
9280
9281         * NEWS: Move convenience variable news above Python news.
9282
9283 2019-06-14  Tom Tromey  <tom@tromey.com>
9284
9285         * gnulib: Move directory to top-level.
9286         * configure.ac: Don't configure gnulib.
9287         * configure: Rebuild.
9288         * common/common-defs.h: Use new path to gnulib.
9289         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9290         (GNULIB_H): Remove.
9291         (INCGNU): Look in new gnulib location.
9292         (HFILES_NO_SRCDIR): Remove gnulib files.
9293         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9294         (generated_files): Remove GNULIB_H.
9295         ($(LIBGNU), all-lib): Remove targets.
9296         (distclean): Don't mention GNULIB_BUILDDIR.
9297         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9298
9299 2019-06-14  Tom Tromey  <tromey@adacore.com>
9300
9301         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9302         Warn if symbol file does not provide any symbols.
9303
9304 2019-06-14  Tom Tromey  <tromey@adacore.com>
9305
9306         * source.c (find_and_open_source): Respect basenames_may_differ.
9307
9308 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9309
9310         * annotate.c (annotate_breakpoints_invalid): Make use of
9311         scoped_restore_terminal_state.
9312         (annotate_frames_invalid): Likewise.
9313
9314 2019-06-14  Tom Tromey  <tromey@adacore.com>
9315
9316         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9317         allow assignment to an internalvar.
9318
9319 2019-06-14  Tom Tromey  <tromey@adacore.com>
9320
9321         * ada-lex.l: Allow "_" in attribute names.
9322
9323 2019-06-14  Tom Tromey  <tromey@adacore.com>
9324
9325         PR gdb/24653:
9326         * regcache.c (registers_changed): Don't call alloca.
9327         * top.c (execute_command): Don't call alloca.
9328
9329 2019-06-13  Pedro Alves  <palves@redhat.com>
9330
9331         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9332         'expression'.  When parsing an expression, error out if there's
9333         junk after "unlimited".
9334         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9335         (do_set_command): Adjust calls to is_unlimited_literal.
9336
9337 2019-06-13  Pedro Alves  <palves@redhat.com>
9338
9339         * compile/compile.c (make_compile_options_def_group): Add braces
9340         around array_view initializer.
9341         * thread.c (make_thread_apply_all_options_def_group)
9342         (make_thread_apply_all_options_def_group): Likewise.
9343
9344 2019-06-13  Pedro Alves  <palves@redhat.com>
9345
9346         * NEWS (New commands): Mention "maint test-options
9347         require-delimiter", "maint test-options unknown-is-error", "maint
9348         test-options unknown-is-operand" and "maint show
9349         test-options-completion-result".
9350         (New command options, command completion): New section.
9351         (Completion improvements): New section.
9352         Mention that you can abbreviate "unlimited".
9353
9354 2019-06-13  Pedro Alves  <palves@redhat.com>
9355
9356         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9357         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9358         * unittests/cli-utils-selftests.c (test_parse_flags)
9359         (test_parse_flags_qcs): Delete.
9360         (test_cli_utils): Don't call deleted functions.
9361
9362 2019-06-13  Pedro Alves  <palves@redhat.com>
9363
9364         * thread.c: Include "cli/cli-option.h".
9365         (tp_array_compar_ascending): Global.
9366         (tp_array_compar): Delete function.
9367         (tp_array_compar_ascending, tp_array_compar_descending): New
9368         functions.
9369         (ascending_option_def, qcs_flag_option_def)
9370         (thr_qcs_flags_option_defs)
9371         (make_thread_apply_all_options_def_group)
9372         (make_thread_apply_options_def_group): New.
9373         (thread_apply_all_command): Use gdb::option::process_options.
9374         (thread_apply_command_completer)
9375         (thread_apply_all_command_completer): New.
9376         (thread_apply_command): Use gdb::option::process_options.
9377         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9378         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9379         to generate help text of "thread apply".  Adjust "taas"'s help.
9380         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9381         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9382
9383 2019-06-13  Pedro Alves  <palves@redhat.com>
9384
9385         * thread.c (thread_apply_command): Check for invalid TID with
9386         isdigit instead of !isalpha.
9387
9388 2019-06-13  Pedro Alves  <palves@redhat.com>
9389
9390         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9391         (validate_flags_qcs): New.
9392         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9393         (validate_flags_qcs): Declare.
9394         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9395         (make_frame_apply_options_def_group): New.
9396         (frame_apply_command_count): Process options with
9397         gdb::option::process_options.
9398         (frame_apply_completer): New.
9399         (frame_apply_level_completer, frame_apply_all_completer)
9400         (frame_apply_completer): New.
9401         (_initialize_stack): Update help of "frame apply", "frame apply
9402         level", "frame apply all" and "faas" to mention supported options
9403         and install command completers.
9404         * stack.h (frame_apply_all_completer): Declare.
9405         * thread.c: Include "stack.h".
9406         (tfaas_command): Add "--".
9407         (_initialize_thread): Update help "tfaas" to mention supported
9408         options and install command completer.
9409
9410 2019-06-13  Pedro Alves  <palves@redhat.com>
9411
9412         * completer.c (complete_nested_command_line): New.
9413         (gdb_completion_word_break_characters_throw): Add assertion.
9414         * completer.h (complete_nested_command_line): Declare.
9415
9416 2019-06-13  Pedro Alves  <palves@redhat.com>
9417
9418         * stack.c (parse_backtrace_qualifiers): New.
9419         (backtrace_command): Use it.
9420         (backtrace_command_completer): Complete on qualifiers.
9421
9422 2019-06-13  Pedro Alves  <palves@redhat.com>
9423
9424         * frame.c: Include "cli/cli-option.h.
9425         (user_set_backtrace_options): New.
9426         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9427         Delete.
9428         (get_prev_frame): Adjust.
9429         (boolean_option_def, uinteger_option_def)
9430         (set_backtrace_option_defs): New.
9431         (_initialize_frame): Adjust and use
9432         gdb::option::add_setshow_cmds_for_options to install "set
9433         backtrace past-main" and "set backtrace past-entry".
9434         * frame.h: Include "cli/cli-option.h".
9435         (struct frame_print_options): Forward declare.
9436         (print_frame_arguments_all, print_frame_arguments_scalars)
9437         (print_frame_arguments_none): Declare.
9438         (print_entry_values): Delete declaration.
9439         (struct frame_print_options, user_frame_print_options): New.
9440         (struct set_backtrace_options): New.
9441         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9442         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9443         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9444         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9445         (list_args_or_locals): Add frame_print_options parameter.
9446         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9447         * python/py-framefilter.c (enumerate_args): Pass down
9448         USER_FRAME_PRINT_OPTIONS.
9449         * stack.c: Include "cli/cli-option.h".
9450         (print_frame_arguments_all, print_frame_arguments_scalars)
9451         (print_frame_arguments_none): Declare.
9452         (print_raw_frame_arguments, print_entry_values): Delete.
9453         (user_frame_print_options): New.
9454         (boolean_option_def, enum_option_def, frame_print_option_defs):
9455         New.
9456         (struct backtrace_cmd_options): New.
9457         (bt_flag_option_def): New.
9458         (backtrace_command_option_defs): New.
9459         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9460         (print_frame_arg, read_frame_arg, print_frame_args)
9461         (print_frame_info, print_frame): Add frame_print_options parameter
9462         and use it.
9463         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9464         (backtrace_command_1): Add frame_print_options and
9465         backtrace_cmd_options parameters and use them.
9466         (make_backtrace_options_def_group): New.
9467         (backtrace_command): Process command options with
9468         gdb::option::process_options.
9469         (backtrace_command_completer): New.
9470         (_initialize_stack): Extend "backtrace"'s help to mention
9471         supported options.  Install completer for "backtrace".
9472         Install some settings commands with add_setshow_cmds_for_options.
9473
9474 2019-06-13  Pedro Alves  <palves@redhat.com>
9475
9476         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9477         and that "set/show print raw frame-arguments" are now deprecated.
9478
9479         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9480         command.
9481         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9482         * stack.c (_initialize_stack): Install "set/show print
9483         raw-frame-arguments", and deprecate "set/show print raw
9484         frame-arguments".
9485         * valprint.c (_initialize_valprint): Deprecate "set/show print
9486         raw".
9487
9488 2019-06-13  Pedro Alves  <palves@redhat.com>
9489
9490         * compile/compile.c (struct compile_options): New.
9491         (compile_flag_option_def, compile_command_option_defs)
9492         (make_compile_options_def_group): New.
9493         (compile_file_command): Handle options with
9494         gdb::option::process_options.
9495         (compile_file_command_completer): New function.
9496         (compile_code_command): Handle options with
9497         gdb::option::process_options.
9498         (compile_code_command_completer): New function.
9499         (_initialize_compiler): Install completers for "compile code" and
9500         "compile file".  Mention available options in "compile code" and
9501         "compile code"'s help.
9502         * completer.c (advance_to_completion_word): New, factored out from
9503         ...
9504         (advance_to_expression_complete_word_point): ... this.
9505         (advance_to_filename_complete_word_point): New.
9506         * completer.h (advance_to_filename_complete_word_point): New
9507         declaration.
9508
9509 2019-06-13  Pedro Alves  <palves@redhat.com>
9510
9511         * compile/compile.c: Include "cli/cli-option.h".
9512         (compile_print_value): Scope data pointer is now a
9513         value_print_options pointer; adjust.
9514         (compile_print_command): Process options.  Scope data pointer is
9515         now a value_print_options pointer; adjust.
9516         (_initialize_compile): Update "compile print"'s help to include
9517         supported options.  Install a completer for "compile print".
9518         * cp-valprint.c (show_vtblprint, show_objectprint)
9519         (show_static_field_print): Delete.
9520         (_initialize_cp_valprint): Don't install "set print
9521         static-members", "set print vtbl", "set print object" here.
9522         * printcmd.c: Include "cli/cli-option.h" and
9523         "common/gdb_optional.h".
9524         (print_command_parse_format): Rework to fill in a
9525         value_print_options instead of a format_data.
9526         (print_value): Change parameter type from format_data pointer to
9527         value_print_options reference.  Adjust.
9528         (print_command_1): Process options.  Adjust to pass down a
9529         value_print_options.
9530         (print_command_completer): New.
9531         (_initialize_printcmd): Install print_command_completer as
9532         handle_brkchars completer for the "print" command.  Update
9533         "print"'s help to include supported options.
9534         * valprint.c: Include "cli/cli-option.h".
9535         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9536         here from cp-valprint.c.
9537         (boolean_option_def, uinteger_option_def)
9538         (value_print_option_defs, make_value_print_options_def_group):
9539         New.  Use gdb::option::add_setshow_cmds_for_options to install
9540         "set print elements", "set print null-stop", "set print repeats",
9541         "set print pretty", "set print union", "set print array", "set
9542         print address", "set print symbol", "set print array-indexes".
9543         * valprint.h: Include <string> and "cli/cli-option.h".
9544         (make_value_print_options_def_group): Declare.
9545         (print_value): Change parameter type from format_data pointer to
9546         value_print_options reference.
9547         (print_command_completer): Declare.
9548
9549 2019-06-13  Pedro Alves  <palves@redhat.com>
9550
9551         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9552         (COMMON_SFILES): Add maint-test-settings.c.
9553         * cli/cli-decode.c (boolean_enums): New global, factored out from
9554         ...
9555         (add_setshow_boolean_cmd): ... here.
9556         * cli/cli-decode.h (boolean_enums): Declare.
9557         * cli/cli-option.c: New file.
9558         * cli/cli-option.h: New file.
9559         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9560         factored out from ...
9561         (parse_cli_boolean_value(const char *)): ... this.
9562         (is_unlimited_literal): Change parameter type to pointer to
9563         pointer.  Adjust and advance ARG pointer.
9564         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9565         (parse_cli_var_enum): New, factored out from ...
9566         (do_set_command): ... this.  Adjust.
9567         * cli/cli-setshow.h (parse_cli_boolean_value)
9568         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9569         (parse_cli_var_enum): Declare.
9570         * cli/cli-utils.c: Include "cli/cli-option.h".
9571         (get_ulongest): New.
9572         * cli/cli-utils.h (get_ulongest): Declare.
9573         (check_for_argument): New overloads.
9574         * maint-test-options.c: New file.
9575
9576 2019-06-13  Pedro Alves  <palves@redhat.com>
9577
9578         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9579         parse a range if "-" is at the end of the string.
9580
9581 2019-06-13  Pedro Alves  <palves@redhat.com>
9582
9583         * cli/cli-setshow.c (parse_auto_binary_operation)
9584         (parse_cli_boolean_value): Don't allow "o".
9585
9586 2019-06-13  Pedro Alves  <palves@redhat.com>
9587
9588         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9589         * NEWS: Mention maint test-settings KIND.
9590         * maint-test-settings.c: New file.
9591
9592 2019-06-13  Pedro Alves  <palves@redhat.com>
9593
9594         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9595         completer.
9596         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9597         "set" completers.
9598
9599 2019-06-13  Pedro Alves  <palves@redhat.com>
9600
9601         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9602         after item.
9603
9604 2019-06-13  Pedro Alves  <palves@redhat.com>
9605
9606         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9607
9608 2019-06-13  Pedro Alves <palves@redhat.com>
9609
9610         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9611         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9612         call.
9613         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9614         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9615         calls.
9616         (check_for_argument): Skip spaces after argument.
9617
9618 2019-06-13  Pedro Alves  <palves@redhat.com>
9619
9620         * thread.c (thread_apply_command): Adjust TID parsing.
9621         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9622         detected before end of string.
9623         (tid_is_in_list): Error out if LIST is invalid.
9624
9625 2019-06-13  Pedro Alves  <palves@redhat.com>
9626
9627         * completer.c (complete_line_internal_1): Rewind completion word
9628         point.
9629         (completion_tracker::advance_custom_word_point_by): Change
9630         parameter type to int.
9631         * completer.h (completion_tracker::advance_custom_word_point_by):
9632         Likewise.
9633
9634 2019-06-13  Pedro Alves  <palves@redhat.com>
9635
9636         * completer.c (advance_to_completion_word): Handle delimiters.
9637
9638 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9639
9640         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9641
9642 2019-06-11  Tom Tromey  <tom@tromey.com>
9643
9644         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9645         (xmalloc_failed): Move to alloc.c.
9646         * alloc.c: New file.
9647         * Makefile.in (COMMON_SFILES): Add alloc.c.
9648
9649 2019-06-11  Tom Tromey  <tom@tromey.com>
9650
9651         * nat/linux-waitpid.c: Don't include server.h.
9652         (linux_debug): Remove.
9653         (my_waitpid): Update.
9654
9655 2019-06-11  Tom Tromey  <tromey@adacore.com>
9656
9657         * infcall.c (_initialize_infcall): Remove trailing newline from
9658         help.
9659         * user-regs.c (_initialize_user_regs): Remove trailing newline
9660         from help.
9661         * typeprint.c (_initialize_typeprint): Remove trailing newline
9662         from help.
9663         * reverse.c (_initialize_reverse): Remove trailing newlines from
9664         help.
9665         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9666         from help.
9667         * language.c (add_set_language_command): Remove trailing newline
9668         from help.
9669         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9670         help.
9671         * disasm.c (_initialize_disasm): Remove trailing newline from
9672         help.
9673         * top.c (init_main): Remove trailing newline from help.
9674         * interps.c (_initialize_interpreter): Remove trailing newline
9675         from help.
9676         * btrace.c (_initialize_btrace): Remove trailing newlines from
9677         help.
9678         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9679         from help.
9680         * python/python.c (_initialize_python): Remove trailing newline
9681         from help.
9682         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9683         help.
9684         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9685         from help.  Reformat some text.
9686         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9687         from help.
9688         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9689         newline from help.
9690
9691 2019-06-11  Tom Tromey  <tromey@adacore.com>
9692
9693         * darwin-nat.c (darwin_decode_exception_message)
9694         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9695
9696 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9697
9698         * valops.c (value_slice): Check for not allocated or not
9699         associated values.
9700
9701 2019-06-10  Tom de Vries  <tdevries@suse.de>
9702
9703         PR gdb/24618
9704         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9705         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9706         invalid.
9707
9708 2019-06-10  Tom de Vries  <tdevries@suse.de>
9709
9710         PR gdb/24611
9711         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9712         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9713
9714 2019-06-10  Tom de Vries  <tdevries@suse.de>
9715
9716         PR symtab/24545
9717         * symtab.c (struct demangled_name_entry): Add language field.
9718         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9719         static minimal symbol".  Set and use language field.
9720
9721 2019-06-10  Tom Tromey  <tromey@adacore.com>
9722
9723         * ada-lang.c (_initialize_ada_language): Update help text.
9724
9725 2019-06-10  Tom Tromey  <tromey@adacore.com>
9726
9727         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9728         with a newline.
9729         * guile/guile.c (handle_boot_error): Don't end warning with a
9730         newline.
9731         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9732         warning with a newline.
9733         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9734         newline.
9735         (s12z_frame_cache): Likewise.
9736         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9737         a newline.
9738         * solib-svr4.c (disable_probes_interface): Don't end warning with
9739         a newline.
9740         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9741         newline.
9742         * python/python.c (do_finish_initialization): Don't end warning
9743         with a newline.
9744
9745 2019-06-10  Tom Tromey  <tom@tromey.com>
9746
9747         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9748         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9749         gdbpy_enter.
9750
9751 2019-06-10  Tom Tromey  <tromey@adacore.com>
9752
9753         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9754         data.
9755         (elf_new_init): Don't call stabsread_new_init.
9756         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9757         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9758         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9759
9760 2019-06-10  Tom de Vries  <tdevries@suse.de>
9761
9762         PR symtab/16264
9763         PR symtab/24517
9764         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9765
9766 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9767
9768         * source.c (find_and_open_source): Also rewrite relative file
9769         names.
9770
9771 2019-04-26  Amos Bird  <amosbird@gmail.com>
9772
9773         * annotate.c (annotate_thread_exited): Add "thread-exited"
9774         annotation.
9775
9776 2019-06-06  Tom Tromey  <tromey@adacore.com>
9777
9778         * maint.h (class scoped_command_stats): Use
9779         DISABLE_COPY_AND_ASSIGN.
9780         <print_time>: New method.
9781         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9782         print_time.
9783         (scoped_command_stats::print_time): New method.
9784
9785 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9786
9787         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9788         instructions of lengths 6 or 8 bytes.
9789
9790 2019-06-04  Pedro Alves  <palves@redhat.com>
9791
9792         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9793
9794         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9795         * breakpoint.c (condition_completer): Likewise.
9796         * cli/cli-dump.c (scan_expression): Likewise.
9797         * common/filestuff.c (mkdir_recursive): Likewise.
9798         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9799         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9800         (gdb_abspath): Likewise.
9801         * compile/compile-cplus-types.c
9802         (compile_cplus_instance::decl_name): Likewise.
9803         * completer.c (complete_explicit_location):
9804         (signal_completer, reg_or_group_completer_1): Likewise.
9805         * cp-support.c (cp_remove_params_if_any): Likewise.
9806         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9807         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9808         * infcmd.c (strip_bg_char): Likewise.
9809         * linespec.c (copy_token_string): Likewise.
9810         * mi/mi-main.c (output_cores): Likewise.
9811         * psymtab.c (psymtab_search_name):
9812         * symfile.c (test_set_ext_lang_command): Likewise.
9813         * target.c (target_fileio_read_stralloc): Likewise.
9814         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9815         * value.c (complete_internalvar): Likewise.
9816
9817 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9818
9819         Add objfile property to gdb.Type.
9820         * NEWS: Mention Python API addition.
9821         * python/py-type.c (typy_get_objfile): New method.
9822
9823 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9824
9825         * NEWS: Mention the new set|show style [title|highlight].
9826         Mention changes to "show style", "help" and "apropos".
9827
9828 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9829
9830         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9831         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9832         instead of print_help_for_command.
9833         (print_doc_of_command): New function.
9834         (help_list): Add 'apropos -v word' suggestion.
9835         (print_help_for_command): Style the command name using title style.
9836         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9837         (_initialize_cli_cmds): Describe -v in apropos_command help.
9838
9839 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9840
9841         * cli/cli-style.h (cli_style_option): Add name in constructor,
9842         add m_name class member, add constructor with intensity,
9843         add name class function.
9844         (cli_style_option::add_setshow_commands): Remove name argument.
9845         (highlight_style, title_style): New styles.
9846         * cli/cli-style.c (do_show): New function that shows a style
9847         characteristic styling the style name with itself.
9848         (set_style_name): New function.
9849         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9850         Update all callers according to the changes in cli/cli-style.h.
9851         * utils.h (fputs_highlighted): New function.
9852         * utils.c (fputs_highlighted): Likewise.
9853
9854 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9855
9856         * NEWS: Mention new pipe command and new convenience variables.
9857
9858 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9859
9860         * cli/cli-cmds.c (pipe_command): New function.
9861         (_initialize_cli_cmds): Call add_com for pipe_command.
9862         Define | as an alias for pipe.
9863         (exit_status_set_internal_vars): New function.
9864         (shell_escape): Call exit_status_set_internal_vars.
9865         cli/cli-decode.c (find_command_name_length): Recognize | as
9866         a single character command.
9867
9868 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9869
9870         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9871         top.c (execute_command_to_ui_file): New function, mostly a copy
9872         of execute_command_to_string.
9873         (execute_command_to_string): Implement by calling
9874         execute_command_to_ui_file.
9875
9876 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9877
9878         * top.h (saved_command_line): Remove declaration.
9879         * top.c (previous_saved_command_line, previous_repeat_arguments):
9880         New variables.
9881         (saved_command_line): Make static, define together with other
9882         'repeat variables'.
9883         (dont_repeat): Clear repeat_arguments.
9884         (repeat_previous, get_saved_command_line, save_command_line):
9885         New functions.
9886         (gdb_init): Initialize saved_command_line
9887         and previous_saved_command_line.
9888         * main.c (captured_main_1): Remove saved_command_line initialization.
9889         * event-top.c (handle_line_of_input): Update to use
9890         the new 'repeat' related functions instead of direct access to
9891         saved_command_line.
9892         * command.h (repeat_previous, get_saved_command_line,
9893         save_command_line): New declarations.
9894         (dont_repeat): Add comment.
9895
9896 2019-05-30  Tom Tromey  <tromey@adacore.com>
9897
9898         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9899         Fix comment.
9900         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9901
9902 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9903
9904         PR cli/24587
9905         * completer.c (complete): Initialize variable word.
9906
9907 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9908
9909         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9910         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9911         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9912         'body' is NULL to the outter 'if', protecting the '!is_define'
9913         situation as well.
9914
9915 2019-05-29  Tom Tromey  <tromey@adacore.com>
9916
9917         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9918         (dwarf_unknown): New function.
9919         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9920         (dwarf_type_encoding_name): Use dwarf_unknown.
9921
9922 2019-05-29  Tom Tromey  <tromey@adacore.com>
9923
9924         PR c++/20020:
9925         * cp-valprint.c (cp_print_value_fields): Call
9926         cp_print_static_field inside "try".
9927
9928 2019-05-29  Tom Tromey  <tromey@adacore.com>
9929
9930         * inflow.c (struct terminal_info): Add default operator=.
9931         * configure: Rebuild.
9932         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9933         -Wdeprecated-copy-dtor, -Wredundant-move.
9934
9935 2019-05-29  Tom Tromey  <tromey@adacore.com>
9936
9937         * NEWS: Add entry.
9938         * infcmd.c (print_return_value_1): Handle finish_print
9939         option.
9940         (show_print_finish): New function.
9941         (_initialize_infcmd): Add "set/show print finish" commands.
9942         * valprint.c (user_print_options): Initialize new member.
9943         * valprint.h (struct value_print_options) <finish_print>: New
9944         member.
9945
9946 2019-05-28  Tom Tromey  <tromey@adacore.com>
9947
9948         * ada-lang.c (ada_remove_Xbn_suffix)
9949         (find_old_style_renaming_symbol)
9950         (parse_old_style_renaming): Remove.
9951         (ada_find_renaming_symbol): Don't call
9952         find_old_style_renaming_symbol.
9953         (ada_is_renaming_symbol): Rename from
9954         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9955         bool.  Now static.
9956         (ada_read_var_value): Update and simplify.
9957         * ada-exp.y (write_var_or_type): Remove old code.
9958
9959 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9960
9961         PR gdb/25010
9962         * event-top.c: Remove include comment.
9963         * inflow.c (class scoped_ignore_sigttou): Move from here...
9964         * inflow.h (class scoped_ignore_sigttou): ...to here.
9965         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9966         * top.c:  Remove include comment.
9967
9968 2019-05-27  Tom Tromey  <tom@tromey.com>
9969
9970         * NEWS: Fix typo.
9971
9972 2019-05-22  Tom Tromey  <tromey@adacore.com>
9973
9974         * target.c (target_follow_exec): Constify parameter.
9975         * target-delegates.c: Rebuild.
9976         * remote.c (remote_target::follow_exec): Constify parameter.
9977         * infrun.c (follow_exec): Constify parameter.
9978         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9979         (target_follow_exec): Likewise.
9980
9981 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9982
9983         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9984         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9985
9986 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9987
9988         * NEWS: Add debugredirect and testsuite sections.
9989
9990 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9991
9992         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9993         target descriptions using exclusively floating point register name
9994         aliases.
9995
9996 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9997
9998         PR gdb/18644:
9999         * f-lang.c (build_fortran_types): Handle the case where
10000         gdbarch_floatformat_for_type returns a nullptr.
10001
10002 2019-05-21  Tom de Vries  <tdevries@suse.de>
10003
10004         PR cli/24587
10005         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10006
10007 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10008
10009         PR gdb/18644:
10010         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10011         16-byte floats.
10012         * i386-tdep.c (i386_floatformat_for_type): Use
10013         floatformats_ia64_quad for the 16-byte floating point component
10014         within a fortran 32-byte complex number.
10015
10016 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10017
10018         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10019         delete default constructor.
10020         (find_partial_die): Update to return const struct.
10021         (partial_die_parent_scope): Move variable declaration into scope
10022         of its use and change its type to auto.
10023         (guess_partial_die_structure_name): Likewise.
10024         (partial_die_info::fixup): Likewise.
10025
10026 2019-05-17  Tom Tromey  <tromey@adacore.com>
10027
10028         * source.c (find_and_open_source): Remove cast.
10029
10030 2019-05-17  Tom Tromey  <tromey@adacore.com>
10031
10032         * annotate.c (annotate_source): Make "filename" const.
10033         * annotate.h (annotate_source): Use const.
10034
10035 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10036
10037         * disasm.c (set_disassembler_options): Send errors to stderr.
10038
10039 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10040
10041         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10042         (cli_interp_base::set_logging): Check debug_redirect.
10043         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10044         * cli/cli-logging.c (debug_redirect): Add static variable.
10045         (pop_output_files): Add default param.
10046         (handle_redirections): Print debug setting.
10047         (show_logging_command): Likewise.
10048         (_initialize_cli_logging): Add debugredirect command.
10049         * interps.c (current_interp_set_logging): Add debug_redirect
10050         parameter.
10051         * interps.h (set_logging): Add debug_redirect parameter.
10052         (current_interp_set_logging): Likewise.
10053         * mi/mi-common.h: Likewise.
10054         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10055
10056 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10057             Tom Tromey  <tromey@adacore.com>
10058
10059         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10060         directly.
10061         * cli/cli-interp.h (make_logging_output): Remove declaration.
10062         * cli/cli-logging.c (make_logging_output): Remove function.
10063         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10064         directly.
10065         * ui-file.c (tee_file::tee_file): Remove bools.
10066         (tee_file::~tee_file): Remove deletes.
10067         * ui-file.h (tee_file): Remove bools.
10068
10069 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10070
10071         * mi/mi-cmds.h (mi_cmd_complete): New function.
10072         * mi/mi-main.c (mi_cmd_complete): Likewise.
10073         * mi/mi-cmds.c: Define new MI command -complete.
10074         * NEWS: Mention new -complete command.
10075
10076 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10077
10078         * completer.h (complete): New function.
10079         * completer.c (complete): Likewise.
10080         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10081         function defined in completer.h.
10082
10083 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10084
10085         * MAINTAINERS (Write After Approval): Add myself.
10086
10087 2019-05-17  Tom de Vries  <tdevries@suse.de>
10088
10089         PR gdb/24094
10090         * dwarf2read.c (struct cu_partial_die_info): New struct.
10091         (find_partial_die): Return cu_partial_die_info.
10092         (partial_die_parent_scope, guess_partial_die_structure_name)
10093         (partial_die_info::fixup): Handle new return type of find_partial_die.
10094
10095 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10096
10097         PR breakpoints/24541
10098         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10099         "std::string", simplifying the algorithm.
10100
10101 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10102
10103         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10104         (stap_static_probe_ops::get_probes): Likewise.
10105
10106 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10107
10108         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10109         '-')" and "else if".
10110         (stap_parse_single_operand): Join checks for
10111         "gdbarch_stap_parse_special_token_p" and
10112         "gdbarch_stap_parse_special_token" in the same "if" statement.
10113         Invert check when verifying for operation on register
10114         displacement.
10115
10116 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10117
10118         * stap-probe.c (stap_get_opcode): Update comment.
10119         (stap_get_expected_argument_type): Likewise.
10120         (handle_stap_probe): Likewise.
10121
10122 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10123
10124         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10125         return type to 'bool'.  Adjust comment.  Use 'bool' when
10126         appropriate.
10127         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10128         * stap-probe.c (stap_parse_argument_1): Likewise.
10129         (stap_is_operator): Likewise.
10130         (stap_is_generic_prefix): Likewise.
10131         (stap_is_register_prefix): Likewise.
10132         (stap_is_register_indirection_prefix): Likewise.
10133         (stap_is_integer_prefix): Likewise.
10134         (stap_generic_check_suffix): Likewise.
10135         (stap_check_integer_suffix): Likewise.
10136         (stap_check_register_suffix): Likewise.
10137         (stap_check_register_indirection_suffix): Likewise.
10138         (stap_parse_register_operand): Likewise.
10139         (stap_parse_single_operand): Likewise.
10140         (stap_parse_argument_1): Likewise.
10141         (stap_probe::get_argument_count): Likewise.
10142         (stap_is_operator): Likewise.
10143
10144 2019-05-16  Tom Tromey  <tromey@adacore.com>
10145
10146         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10147         keyword to foreach.
10148
10149 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10150
10151         * linux-thread-db.c (try_thread_db_load_1): Change return type
10152         to bool.
10153         (try_thread_db_load): Likewise.
10154         (try_thread_db_load_from_pdir_1): Likewise.
10155         (try_thread_db_load_from_pdir): Likewise.
10156         (try_thread_db_load_from_sdir): Likewise.
10157         (try_thread_db_load_from_dir): Likewise.
10158         (thread_db_load_search): Likewise.
10159         (has_libpthread): Likewise.
10160         (thread_db_load): Likewise.
10161
10162 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10163
10164         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10165         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10166         NULL, and complain/return if that's the case.
10167
10168 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10169
10170         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10171         (advance, posn, abstract_read_memory): New functions.
10172         [struct mem_read_abstraction]: New struct.
10173         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10174
10175 2019-05-14  Tom Tromey  <tromey@adacore.com>
10176
10177         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10178         value is not lval_memory.
10179
10180 2019-05-14  Tom Tromey  <tromey@adacore.com>
10181
10182         * solib.c (info_sharedlibrary_command): Style the file name.
10183
10184 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10185
10186         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10187         (aarch64_vnv_type): Likewise.
10188         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10189         * common/tdesc.c: Likewise.
10190         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10191         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10192         * features/aarch64-fpu.xml: Add ieee half view.
10193         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10194         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10195         * gdbtypes.h (struct builtin_type): Likewise.
10196         (struct objfile_type): Likewise.
10197
10198 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10199
10200         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10201         typo.
10202         * location.h (string_to_event_location): Likewise.
10203
10204 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10205
10206         GDB 8.3 released.
10207
10208 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10209
10210         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10211         New variable declaration.
10212         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10213         New variable.
10214         (print_one_breakpoint): Use ui_out::test_flags and new global
10215         variable to compute use_fixed_output.
10216         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10217         Remove.
10218         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10219         (mi_multi_location_breakpoint_output_fixed): Remove.
10220         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10221         new variable.
10222         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10223         fix_multi_location_breakpoint_output flag if version >= 3.
10224         * ui-out.h (enum ui_out_flag)
10225         <fix_multi_location_breakpoint_output>: New enumerator.
10226
10227 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10228
10229         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10230
10231 2019-05-10  Tom Tromey  <tromey@adacore.com>
10232
10233         * ada-lang.c (catch_ada_completer): New function.
10234         (_initialize_ada_language): Use it.
10235
10236 2019-05-10  Tom Tromey  <tromey@adacore.com>
10237
10238         * thread.c (print_thread_info): Make "requested_threads" const.
10239         * gdbthread.h (print_thread_info): Make "requested_threads"
10240         const.
10241         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10242         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10243
10244 2019-05-08  Tom Tromey  <tom@tromey.com>
10245
10246         * gdbtypes.c (objfile_type_data): Change type.
10247         (objfile_type, _initialize_gdbtypes): Update.
10248
10249 2019-05-08  Tom Tromey  <tom@tromey.com>
10250
10251         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10252         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10253         (_initialize_dwarf2_frame): Update.
10254
10255 2019-05-08  Tom Tromey  <tom@tromey.com>
10256
10257         * objc-lang.c (objc_objfile_data): Change type.
10258         (find_methods): Update.
10259         (_initialize_objc_lang): Remove.
10260
10261 2019-05-08  Tom Tromey  <tom@tromey.com>
10262
10263         * stabsread.c (rs6000_builtin_type_data): Change type.
10264         (rs6000_builtin_type, _initialize_stabsread): Update.
10265
10266 2019-05-08  Tom Tromey  <tom@tromey.com>
10267
10268         * mips-tdep.c (mips_pdr_data): Remove.
10269         (_initialize_mips_tdep): Update.
10270
10271 2019-05-08  Tom Tromey  <tom@tromey.com>
10272
10273         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10274         (hppa_init_objfile_priv_data, read_unwind_info)
10275         (find_unwind_entry, _initialize_hppa_tdep): Update.
10276
10277 2019-05-08  Tom Tromey  <tom@tromey.com>
10278
10279         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10280         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10281         on obstack.
10282         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10283
10284 2019-05-08  Tom Tromey  <tom@tromey.com>
10285
10286         * mdebugread.c (basic_type_data): Change type.
10287         (basic_type, _initialize_mdebugread): Update.
10288
10289 2019-05-08  Tom Tromey  <tom@tromey.com>
10290
10291         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10292
10293 2019-05-08  Tom Tromey  <tom@tromey.com>
10294
10295         * nto-tdep.c (nto_inferior_data_reg): Change type.
10296         (nto_inferior_data): Update.
10297         (nto_inferior_data_cleanup, nto_new_inferior_data)
10298         (_initialize_nto_tdep): Remove.
10299         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10300
10301 2019-05-08  Tom Tromey  <tom@tromey.com>
10302
10303         * ada-lang.c (struct ada_inferior_data): Add initializers.
10304         (ada_inferior_data): Change type.
10305         (ada_inferior_data_cleanup): Remove.
10306         (get_ada_inferior_data, ada_inferior_exit)
10307         (struct ada_pspace_data): Add initializers, destructor.
10308         (ada_pspace_data_handle): Change type.
10309         (get_ada_pspace_data): Update.
10310         (ada_pspace_data_cleanup): Remove.
10311
10312 2019-05-08  Tom Tromey  <tom@tromey.com>
10313
10314         * coffread.c (struct coff_symfile_info): Add initializers.
10315         (coff_objfile_data_key): Move lower.  Change type.
10316         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10317         Update.
10318         (coff_free_info): Remove.
10319
10320 2019-05-08  Tom Tromey  <tom@tromey.com>
10321
10322         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10323         (fbsd_pspace_data_handle): Move lower.  Change type.
10324         (get_fbsd_pspace_data): Update.
10325         (fbsd_pspace_data_cleanup): Remove.
10326         (_initialize_fbsd_tdep): Update.
10327
10328 2019-05-08  Tom Tromey  <tom@tromey.com>
10329
10330         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10331         (get_ada_tasks_pspace_data): Update.
10332         (ada_tasks_pspace_data_cleanup): Remove.
10333         (_initialize_tasks): Update.
10334         (ada_tasks_inferior_data_handle): Change type.
10335         (get_ada_tasks_inferior_data): Update.
10336         (ada_tasks_inferior_data_cleanup): Remove.
10337         (struct ada_tasks_pspace_data): Add initializers.
10338
10339 2019-05-08  Tom Tromey  <tom@tromey.com>
10340
10341         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10342         * symfile-debug.c (debug_sym_get_probes): Change type.
10343         * stap-probe.c (handle_stap_probe):
10344         (stap_static_probe_ops::get_probes): Change type.
10345         * probe.h (class static_probe_ops) <get_probes>: Change type.
10346         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10347         (parse_probes_in_pspace): Update.
10348         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10349         Update.
10350         (any_static_probe_ops::get_probes): Change type.
10351         * elfread.c (elfread_data): New typedef.
10352         (probe_key): Change type.
10353         (elf_get_probes): Likewise.  Update.
10354         (probe_key_free): Remove.
10355         (_initialize_elfread): Update.
10356         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10357         Change type.
10358         (dtrace_process_dof_probe, dtrace_process_dof)
10359         (dtrace_static_probe_ops::get_probe): Change type.
10360
10361 2019-05-08  Tom Tromey  <tom@tromey.com>
10362
10363         * xcoffread.c (struct xcoff_symfile_info): Rename from
10364         coff_symfile_info.  Add initializers.
10365         (xcoff_objfile_data_key): Move lower.  Change type.
10366         (XCOFF_DATA): Rewrite.
10367         (xcoff_free_info): Remove.
10368         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10369         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10370         (xcoff_initial_scan): Update.
10371
10372 2019-05-08  Tom Tromey  <tom@tromey.com>
10373
10374         * solib-svr4.c (struct svr4_info): Add initializers and
10375         destructor.
10376         <probes_table>: Now an htab_up.
10377         (solib_svr4_pspace_data): Change type.
10378         (free_probes_table): Simplify.
10379         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10380         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10381         (probes_table_remove_objfile_probes, register_solib_event_probe)
10382         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10383         (_initialize_svr4_solib): Update.
10384
10385 2019-05-08  Tom Tromey  <tom@tromey.com>
10386
10387         * remote.c (remote_pspace_data): Change type.
10388         (remote_pspace_data_cleanup): Remove.
10389         (get_remote_exec_file, set_pspace_remote_exec_file)
10390         (_initialize_remote): Update.
10391
10392 2019-05-08  Tom Tromey  <tom@tromey.com>
10393
10394         * breakpoint.c (breakpoint_objfile_key): Change type.
10395         (get_breakpoint_objfile_data): Update.
10396         (free_breakpoint_objfile_data): Remove.
10397         (_initialize_breakpoint): Update.
10398
10399 2019-05-08  Tom Tromey  <tom@tromey.com>
10400
10401         * linux-tdep.c (struct linux_info): Add initializers.
10402         (linux_inferior_data): Move.  Change type.
10403         (invalidate_linux_cache_inf): Update.
10404         (linux_inferior_data_cleanup): Remove.
10405         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10406
10407 2019-05-08  Tom Tromey  <tom@tromey.com>
10408
10409         * auxv.c (auxv_inferior_data): Move.  Change type.
10410         (auxv_inferior_data_cleanup): Remove.
10411         (invalidate_auxv_cache_inf): Rewrite.
10412         (get_auxv_inferior_data, _initialize_auxv): Update.
10413
10414 2019-05-08  Tom Tromey  <tom@tromey.com>
10415
10416         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10417         (symfile_debug_objfile_data_key): Change type.
10418         (symfile_debug_installed, debug_qf_has_symbols)
10419         (debug_qf_find_last_source_symtab)
10420         (debug_qf_forget_cached_source_info)
10421         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10422         (debug_qf_print_stats, debug_qf_dump)
10423         (debug_qf_expand_symtabs_for_function)
10424         (debug_qf_expand_all_symtabs)
10425         (debug_qf_expand_symtabs_with_fullname)
10426         (debug_qf_map_matching_symbols)
10427         (debug_qf_expand_symtabs_matching)
10428         (debug_qf_find_pc_sect_compunit_symtab)
10429         (debug_qf_map_symbol_filenames)
10430         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10431         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10432         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10433         (debug_sym_read_linetable, debug_sym_relocate): Update.
10434         (symfile_debug_free_objfile): Remove.
10435         (install_symfile_debug_logging, _initialize_symfile_debug):
10436         Update.
10437
10438 2019-05-08  Tom Tromey  <tom@tromey.com>
10439
10440         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10441         allocate_on_obstack.
10442         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10443         (get_dwarf2_per_objfile): Update.
10444         (set_dwarf2_per_objfile): Remove.
10445         (dwarf2_has_info, dwarf2_get_section_info): Update.
10446         (dwarf2_free_objfile): Remove.
10447         (_initialize_dwarf2_read): Update.
10448
10449 2019-05-08  Tom Tromey  <tom@tromey.com>
10450
10451         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10452         initializers.
10453         <unsupported_script_warning_printed,
10454         script_not_found_warning_printed>: Now bool.
10455         (auto_load_pspace_data): Change type.
10456         (~auto_load_pspace_info): Rename from
10457         auto_load_pspace_data_cleanup.
10458         (get_auto_load_pspace_data, init_loaded_scripts_info)
10459         (clear_section_scripts, maybe_print_unsupported_script_warning)
10460         (maybe_print_script_not_found_warning, _initialize_auto_load):
10461         Update.
10462
10463 2019-05-08  Tom Tromey  <tom@tromey.com>
10464
10465         * objfiles.c (objfile_pspace_info): Add destructor and
10466         initializers.
10467         (objfiles_pspace_data): Change type.
10468         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10469         (get_objfile_pspace_data): Update.
10470         (objfiles_bfd_data): Change type.
10471         (get_objfile_bfd_data): Update.
10472         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10473
10474 2019-05-08  Tom Tromey  <tom@tromey.com>
10475
10476         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10477         Change type.
10478         (get_catch_syscall_inferior_data): Update.
10479         (catch_syscall_inferior_data_cleanup): Remove.
10480         (_initialize_break_catch_syscall): Update.
10481
10482 2019-05-08  Tom Tromey  <tom@tromey.com>
10483
10484         * inflow.c (struct terminal_info): Add destructor and
10485         initializers.
10486         (inflow_inferior_data): Change type.
10487         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10488         (get_inflow_inferior_data, inflow_inferior_exit)
10489         (swap_terminal_info, _initialize_inflow): Update.
10490
10491 2019-05-08  Tom Tromey  <tom@tromey.com>
10492
10493         * target-dcache.c (target_dcache_cleanup): Remove.
10494         (target_dcache_aspace_key): Change type.
10495         (target_dcache_init_p, target_dcache_invalidate)
10496         (target_dcache_get, target_dcache_get_or_init)
10497         (_initialize_target_dcache): Update.
10498         * dcache.h (struct dcache_deleter): New.
10499
10500 2019-05-08  Tom Tromey  <tom@tromey.com>
10501
10502         * symtab.c (struct symbol_cache): Add destructor and
10503         initializers.
10504         (symbol_cache_key): Move.  Change type.
10505         (make_symbol_cache, free_symbol_cache): Remove.
10506         (get_symbol_cache): Update.
10507         (symbol_cache_cleanup): Remove.
10508         (ALL_PSPACES, symbol_cache_flush)
10509         (maintenance_print_symbol_cache)
10510         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10511         Update.
10512
10513 2019-05-08  Tom Tromey  <tom@tromey.com>
10514
10515         * symtab.c (struct main_info): Add destructor and initializers.
10516         (main_progspace_key): Move.  Change type.
10517         (get_main_info): Update.
10518         (main_info_cleanup): Remove.
10519         (_initialize_symtab): Update.
10520
10521 2019-05-08  Tom Tromey  <tom@tromey.com>
10522
10523         * registry.h (DECLARE_REGISTRY): Define the _key class.
10524
10525 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10526
10527         * NEWS: Merge two 'New commands' sections.
10528
10529 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10530
10531         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10532         parameter and use Ada language definition instead.
10533         (ada_val_print_ptr): Remove unused language parameter.
10534         (ada_val_print_num): Remove language parameter and use Ada language
10535         definition instead.
10536         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10537         parameter.
10538         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10539         parameter and use Ada language definition instead.
10540         (ada_val_print_1): Update all ada_val_print_xxx calls.
10541         Remove language parameter.
10542         (ada_val_print): Update ada_val_print_1 call.
10543
10544 2019-05-08  Tom Tromey  <tromey@adacore.com>
10545
10546         * remote.c (remote_hw_watchpoint_limit)
10547         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10548         Now static.
10549
10550 2019-05-08  Tom Tromey  <tromey@adacore.com>
10551
10552         * maint.c (_initialize_maint_cmds): Move initialization code to
10553         remote.c.
10554         (watchdog, show_watchdog): Move to remote.c.
10555         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10556         "watchdog" static.
10557         (_initialize_remote): Move initialization code from maint.c.
10558         * defs.h (watchdog): Don't declare.
10559
10560 2019-05-08  Tom Tromey  <tromey@adacore.com>
10561
10562         * tui/tui-interp.c: Include main.h.
10563         * interps.c: Include main.h.
10564         * main.h (interpreter_p): Declare.
10565         * defs.h (interpreter_p): Don't declare.
10566
10567 2019-05-08  Tom Tromey  <tromey@adacore.com>
10568
10569         * dwarf2loc.c: Include dwarf2read.h.
10570         * defs.h (read_unsigned_leb128): Don't declare.
10571         * dwarf2read.h (read_unsigned_leb128): Declare.
10572
10573 2019-05-08  Tom Tromey  <tromey@adacore.com>
10574
10575         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10576         method.
10577
10578 2019-05-08  Tom Tromey  <tromey@adacore.com>
10579
10580         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10581         when no wrap column is set.
10582
10583 2019-05-08  Tom Tromey  <tromey@adacore.com>
10584
10585         * c-lang.c (c_get_string): Handle non-C-style arrays.
10586
10587 2019-05-08  Tom Tromey  <tromey@adacore.com>
10588
10589         * typeprint.c (print_offset_data::update): Print the bit offset,
10590         not the number of bits remaining.
10591
10592 2019-05-08  Tom Tromey  <tromey@adacore.com>
10593
10594         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10595         padding at end of comment.
10596
10597 2019-05-08  Tom Tromey  <tromey@adacore.com>
10598
10599         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10600         Compare main types.
10601
10602 2019-05-06  Tom Tromey  <tom@tromey.com>
10603
10604         * common/scoped_mmap.c: Include common-defs.h.
10605         * common/scoped_mmap.h: Don't include config.h.
10606
10607 2019-05-04  Tom Tromey  <tom@tromey.com>
10608
10609         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10610         (struct aarch64_call_info): Add initializers.
10611         <si>: Now a std::vector.
10612         (pass_on_stack, aarch64_push_dummy_call): Update.
10613
10614 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10615             Tom Tromey  <tom@tromey.com>
10616
10617         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10618         (ppc_threads): Now a std::vector.  Now static.
10619         (hwdebug_find_thread_points_by_tid)
10620         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10621         Update.
10622
10623 2019-05-04  Tom Tromey  <tom@tromey.com>
10624
10625         * arc-tdep.c (arc_tdesc_init): Return bool.
10626
10627 2019-05-04  Tom Tromey  <tom@tromey.com>
10628
10629         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10630         Use gdb_assert_not_reached.
10631
10632 2019-05-04  Tom Tromey  <tom@tromey.com>
10633
10634         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10635         "false".
10636
10637 2019-05-04  Tom Tromey  <tom@tromey.com>
10638
10639         * arc-tdep.c (arc_tdesc_init): Use bool.
10640
10641 2019-05-04  Tom Tromey  <tom@tromey.com>
10642
10643         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10644
10645 2019-05-04  Tom Tromey  <tom@tromey.com>
10646
10647         * cli/cli-cmds.c (valid_command_p): Return bool.
10648
10649 2019-05-04  Tom Tromey  <tom@tromey.com>
10650
10651         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10652         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10653
10654 2019-05-04  Raul Tambre  <raul@tambre.ee>
10655
10656         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10657         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10658         operator for comparison.
10659
10660 2019-05-04  Tom Tromey  <tom@tromey.com>
10661
10662         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10663         (lookup_partial_symbol, print_partial_symbols)
10664         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10665         (psymbol_compare): Update.
10666         (add_psymbol_to_bcache): Clear the entire psymbol.
10667         (maintenance_check_psymtabs): Update.
10668         * psympriv.h (struct partial_symbol): Don't derive from
10669         general_symbol_info.
10670         <obj_section, unrelocated_address, address,
10671         set_unrelocated_address>: Update.
10672         <ginfo>: New member.
10673         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10674         (debug_names::write_psymbols): Update.
10675
10676 2019-05-04  Tom de Vries  <tdevries@suse.de>
10677
10678         * contrib/cc-with-tweaks.sh: Support -n arg.
10679
10680 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10681
10682         * corelow.c (core_target::detach): Ensure frame cache and
10683         register caches are cleared.
10684         inferior.c (exit_inferior_1): Likewise.
10685
10686 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10687             Tom Tromey  <tom@tromey.com>
10688
10689         * dictionary.c (collate_pending_symbols_by_language): Remove
10690         "struct" from foreach.
10691         * symtab.c (lookup_global_symbol_from_objfile)
10692         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10693         foreach.
10694         * ser-tcp.c (net_open): Remove "struct" from foreach.
10695         * objfiles.c (objfile_relocate, objfile_rebase)
10696         (objfile_has_symbols): Remove "struct" from foreach.
10697         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10698         from foreach.
10699         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10700         foreach.
10701         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10702         "struct" from foreach.
10703         * ada-lang.c (create_excep_cond_exprs)
10704         (ada_exception_catchpoint_cond_string): Remove "struct" from
10705         foreach.
10706
10707 2019-05-03  Tom Tromey  <tromey@adacore.com>
10708
10709         * ada-exp.y (convert_char_literal): Check suffix of each
10710         enumerator.
10711
10712 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10713
10714         PR ada/21406:
10715         * ada-exp.y (yywrap): Don't define.
10716         * ada-lex.l (%option): Add noyywrap
10717         (yywrap): Remove.
10718
10719 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10720
10721         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10722         _WIN32_WINNT to the XP level, unless already defined to a higher
10723         level.
10724
10725         * unittests/parse-connection-spec-selftests.c:
10726         * ser-tcp.c:
10727         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10728         override.
10729
10730         * symfile.c (find_separate_debug_file): Remove colon from the
10731         drive spec of DOS/Windows file names of the target, so that the
10732         file name produced from DEBUGDIR and the target's directory will
10733         be valid on DOS/Windows systems.
10734
10735 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10736
10737         * rust-lang.c (val_print_struct): Handle printing structures
10738         containing strings.
10739
10740 2019-05-02  Tom Tromey  <tromey@adacore.com>
10741
10742         * valarith.c (_initialize_valarith): Remove.
10743
10744 2019-05-01  Tom Tromey  <tromey@adacore.com>
10745
10746         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10747         bitfields.
10748
10749 2019-05-01  Tom Tromey  <tromey@adacore.com>
10750
10751         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10752         for big-endian copies.
10753
10754 2019-04-30  Ali Tamur  <tamur@google.com>
10755         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10756         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10757         (read_3_bytes): New function.
10758
10759 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10760
10761         * windows-nat.c (main_thread_id): Delete.
10762         (handle_output_debug_string): Replace main_thread_id by
10763         current_event.dwThreadId.
10764         (fake_create_process): Likewise.
10765         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10766         Do not set main_thread_id.
10767         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10768         current_event.dwThreadId.
10769         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10770
10771 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10772
10773         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10774         Use current_event.dwThreadId instead of main_thread_id.
10775
10776 2019-04-30  Tom Tromey  <tromey@adacore.com>
10777
10778         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10779         (create_excep_cond_exprs): Iterate over program spaces.
10780         (ada_exception_catchpoint_cond_string): Examine all minimal
10781         symbols for exception types.
10782
10783 2019-04-30  Tom Tromey  <tromey@adacore.com>
10784
10785         PR c++/24470:
10786         * dwarf2read.c (process_structure_scope): Handle case where type
10787         has template parameters but no symbol was created.
10788
10789 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10790             Chris January  <chris.january@arm.com>
10791
10792         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10793         qualifier.
10794         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10795
10796 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10797
10798         * f-typeprint.c (f_print_type): Update rules for printing
10799         whitespace.
10800         (f_type_print_varspec_suffix): Likewise.
10801
10802 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10803             Chris January  <chris.january@arm.com>
10804
10805         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10806         function arguments.
10807
10808 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10809
10810         * f-lang.c (build_fortran_types): Change name of void type to
10811         lower case.
10812         * f-typeprint.c (f_type_print_base): Print the name of the void
10813         type, rather than a fixed string.
10814         * f-valprint.c (f_decorations): Use lower case void string.
10815
10816 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10817             Chris January  <chris.january@arm.com>
10818
10819         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10820         types for Fortran.
10821
10822 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10823             Chris January  <chris.january@arm.com>
10824             David Lecomber  <david.lecomber@arm.com>
10825
10826         * f-exp.y (BINOP_INTRINSIC): New token.
10827         (exp): New parser rule handling BINOP_INTRINSIC.
10828         (f77_keywords): Add new builtin procedures.
10829         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10830         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10831         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10832         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10833         (print_unop_subexp_f): New function.
10834         (print_binop_subexp_f): New function.
10835         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10836         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10837         (dump_subexp_body_f): Likewise.
10838         (operator_check_f): Likewise.
10839         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10840         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10841
10842 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10843
10844         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10845         UNOP_KIND.
10846         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10847         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10848         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10849         (operator_length_f): New fuction.
10850         (print_subexp_f): New function.
10851         (op_name_f): New function.
10852         (dump_subexp_body_f): New function.
10853         (operator_check_f): New function.
10854         (exp_descriptor_f): Replace standard expression handling functions
10855         with new functions.
10856         * gdb/fortran-operator.def: New file.
10857         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10858         * gdb/std-operator.def: Remove UNOP_KIND.
10859
10860 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10861
10862         * std-operator.def: Remove unbalanced, stray double quote
10863         character.
10864
10865 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10866             Chris January  <chris.january@arm.com>
10867             Daniel Everett  <daniel.everett@arm.com>
10868             Nick Forrington  <nick.forrington@arm.com>
10869             Richard Bunt  <richard.bunt@arm.com>
10870
10871         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10872         of depth when printing anonymous structs or unions.
10873         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10874         Don't print either the top-level value, or the children if the
10875         max-depth is exceeded.
10876         (ppscm_print_children): When printing the key of a map, allow one
10877         extra level of depth.
10878         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10879         print either the top-level value, or the children if the max-depth
10880         is exceeded.
10881         (print_children): When printing the key of a map, allow one extra
10882         level of depth.
10883         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10884         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10885         (user_print_options): Initialise max_depth field.
10886         (val_print_scalar_or_string_type_p): New function.
10887         (val_print): Check to see if the max depth has been reached.
10888         (val_print_check_max_depth): Define new function.
10889         (show_print_max_depth): New function.
10890         (_initialize_valprint): Add 'print max-depth' option.
10891         * valprint.h (struct value_print_options) <max_depth>: New field.
10892         (val_print_check_max_depth): Declare new function.
10893         * NEWS: Document new feature.
10894
10895 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10896
10897         * ada-lang.c (ada_language_defn): Initialise new field.
10898         * c-lang.c (c_is_string_type_p): New function.
10899         (c_language_defn): Initialise new field.
10900         (cplus_language_defn): Initialise new field.
10901         (asm_language_defn): Initialise new field.
10902         (minimal_language_defn): Initialise new field.
10903         * c-lang.h (c_is_string_type_p): Declare new function.
10904         * d-lang.c (d_language_defn): Initialise new field.
10905         * f-lang.c (f_is_string_type_p): New function.
10906         (f_language_defn): Initialise new field.
10907         * go-lang.c (go_is_string_type_p): New function.
10908         (go_language_defn): Initialise new field.
10909         * language.c (default_is_string_type_p): New function.
10910         (unknown_language_defn): Initialise new field.
10911         (auto_language_defn): Initialise new field.
10912         * language.h (struct language_defn) <la_is_string_type_p>: New
10913         member variable.
10914         (default_is_string_type_p): Declare new function.
10915         * m2-lang.c (m2_language_defn): Initialise new field.
10916         * objc-lang.c (objc_language_defn): Initialise new field.
10917         * opencl-lang.c (opencl_language_defn): Initialise new field.
10918         * p-lang.c (pascal_is_string_type_p): New function.
10919         (pascal_language_defn): Initialise new field.
10920         * rust-lang.c (rust_is_string_type_p): New function.
10921         (rust_language_defn): Initialise new field.
10922
10923 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10924
10925         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10926         New field.
10927         * ada-lang.c (ada_language_defn): Initialise new field.
10928         * c-lang.c (c_language_defn): Likewise.
10929         (cplus_language_defn): Likewise.
10930         (asm_language_defn): Likewise.
10931         (minimal_language_defn): Likewise.
10932         * d-lang.c (d_language_defn): Likewise.
10933         * f-lang.c (f_language_defn): Likewise.
10934         * go-lang.c (go_language_defn): Likewise.
10935         * language.c (unknown_language_defn): Likewise.
10936         (auto_language_defn): Likewise.
10937         * m2-lang.c (m2_language_defn): Likewise.
10938         * objc-lang.c (objc_language_defn): Likewise.
10939         * opencl-lang.c (opencl_language_defn): Likewise.
10940         * p-lang.c (pascal_language_defn): Likewise.
10941         * rust-lang.c (rust_language_defn): Likewise.
10942
10943 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10944
10945         * ada-lang.c (ada_is_character_type): Change return type to bool.
10946         (ada_is_string_type): Likewise.
10947         * ada-lang.h (ada_is_character_type): Update declaration
10948         (ada_is_string_type): Likewise.
10949
10950 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10951
10952         Support style in 'frame|thread apply'
10953
10954         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10955         * record.c (record_start, record_stop): Update callers of
10956         execute_command_to_string with false.
10957         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10958         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10959         methods.
10960         (class string_file): New constructor with term_out parameter.
10961         Override methods term_out and can_emit_style_escape.  New member
10962         term_out.
10963         (class stdio_file): Override can_emit_style_escape.
10964         (class tee_file): Override term_out and can_emit_style_escape.
10965         * utils.h (can_emit_style_escape): Remove.
10966         * utils.c (can_emit_style_escape): Likewise.
10967         Update all callers of can_emit_style_escape (SOMESTREAM) to
10968         SOMESTREAM->can_emit_style_escape.
10969         * source-cache.c (source_cache::get_source_lines): Likewise.
10970         * stack.c (frame_apply_command_count): Call execute_command_to_string
10971         passing the term_out characteristic of the current gdb_stdout.
10972         * thread.c (thr_try_catch_cmd): Likewise.
10973         * top.c (execute_command_to_string): pass term_out parameter
10974         to construct the string_file for the command output.
10975         * ui-file.c (term_cli_styling): New function (most code moved
10976         from utils.c can_emit_style_escape).
10977         (string_file::string_file, string_file::can_emit_style_escape,
10978         stdio_file::can_emit_style_escape, tee_file::term_out,
10979         tee_file::can_emit_style_escape): New functions.
10980
10981 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10982
10983         * NEWS: Mention the new set|show may-call-functions.
10984         * infcall.c (may_call_functions_p): New variable.
10985         (show_may_call_functions_p): New function.
10986         (call_function_by_hand_dummy): Throws an error if not
10987         may-call-functions.
10988         (_initialize_infcall): Call add_setshow_boolean_cmd for
10989         may-call-functions.
10990
10991 2019-04-25  Keith Seitz  <keiths@redhat.com>
10992
10993         PR c++/24367
10994         * cp-support.c (inspect_type): Don't attempt substitutions
10995         of symbol with the same name.
10996
10997 2019-04-25  Tom Tromey  <tromey@adacore.com>
10998
10999         PR gdb/24475:
11000         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11001         static.
11002
11003 2019-04-25  Tom Tromey  <tromey@adacore.com>
11004
11005         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11006         rvalue reference.
11007         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11008         (gdb_xml_parser::parse): Use std::move.
11009         * python/python-internal.h (gdbpy_convert_exception): Take a const
11010         reference.
11011         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11012         std::move.
11013         * python/py-utils.c (gdbpy_convert_exception): Take a const
11014         reference.
11015         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11016         Use std::move.
11017         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11018         Use std::move.
11019         * mi/mi-main.c (mi_print_exception): Take a const reference.
11020         * main.c (handle_command_errors): Take a const reference.
11021         * linespec.c (parse_linespec): Use std::move.
11022         * infcall.c (run_inferior_call): Use std::move.
11023         (call_function_by_hand_dummy): Use std::move.
11024         * exec.c (try_open_exec_file): Use std::move.
11025         * exceptions.h (exception_print, exception_fprintf)
11026         (exception_print_same): Update.
11027         * exceptions.c (print_exception, exception_print)
11028         (exception_fprintf, exception_print_same): Change parameters to
11029         const reference.
11030         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11031         * common/new-op.c: Use std::move.
11032         * common/common-exceptions.h (struct gdb_exception): Add move
11033         constructor.
11034         (struct gdb_exception_error, struct gdb_exception_quit, struct
11035         gdb_quit_bad_alloc): Change constructor to move constructor.
11036         (throw_exception): Change parameter to rvalue reference.
11037         * common/common-exceptions.c (throw_exception): Take rvalue
11038         reference.
11039         * cli/cli-interp.c (safe_execute_command): Use std::move.
11040         * breakpoint.c (insert_bp_location, location_to_sals): Use
11041         std::move.
11042
11043 2019-04-25  Tom Tromey  <tromey@adacore.com>
11044
11045         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11046         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11047         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11048         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11049         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11050         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11051         guile/scm-value.c: Use unpack.
11052         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11053         gdbscm_gdb_exception.
11054         (gdbscm_throw_gdb_exception): Likewise.
11055         (struct gdbscm_gdb_exception): New.
11056         (unpack): New function.
11057         (gdbscm_wrap): Use unpack.
11058
11059 2019-04-25  Tom Tromey  <tromey@adacore.com>
11060
11061         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11062         (gdb_rl_callback_handler): Use std::move.
11063         * common/common-exceptions.h (struct gdb_exception): Add move
11064         assignment operator.
11065         (throw_exception_sjlj): Change "exception" to const reference.
11066         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11067         (throw_exception_sjlj): Change "exception" to const reference.
11068
11069 2019-04-25  Tom Tromey  <tromey@adacore.com>
11070
11071         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11072         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11073         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11074         Update.
11075         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11076         Update.
11077         * mi/mi-interp.c (mi_interp::exec): Update.
11078         * linespec.c (parse_linespec): Update.
11079         * infcall.c (run_inferior_call): Update.
11080         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11081         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11082         (gdbscm_lookup_global_symbol): Update.
11083         * guile/scm-param.c (gdbscm_parameter_value): Update.
11084         * guile/scm-frame.c (gdbscm_frame_read_register)
11085         (gdbscm_frame_read_var): Update.
11086         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11087         * exec.c (try_open_exec_file): Update.
11088         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11089         (gdb_rl_callback_handler): Update.
11090         * common/common-exceptions.h (exception_none): Don't declare.
11091         * common/common-exceptions.c (exception_none): Don't define.
11092         (struct catcher) <exception>: Update.
11093         * cli/cli-interp.c (safe_execute_command): Update.
11094         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11095
11096 2019-04-25  Ali Tamur  <tamur@google.com>
11097
11098         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11099         (read_attribute_value): Likewise.
11100         (dwarf2_read_addr_index): Update comment.
11101         (read_str_index): Add DW_FORM_strx.
11102         (dwarf2_string_attr): Likewise.
11103         (dwarf2_const_value_attr): Likewise.
11104         (dump_die_shallow): Likewise.
11105         (dwarf2_fetch_constant_bytes): Likewise.
11106         (skip_form_bytes): Likewise.
11107         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11108
11109 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11110
11111         PR corefiles/11608
11112         PR corefiles/18187
11113         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11114         OFFSET.  Verify if current mapping contains an ELF header.
11115         (linux_find_memory_regions_full): Adjust call to
11116         dump_mapping_p.
11117
11118 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11119             Kang Li <kanglictf@gmail.com>
11120
11121         PR gdb/21600
11122
11123         * dwarf2-frame.c (read_initial_length): Be consistent about using
11124         unsigned representation of length.
11125         (decode_frame_entry_1): Likewise.  Check for wraparound of
11126         end pointer as well as buffer overflow.
11127
11128 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11129
11130         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11131         "vq".
11132
11133 2019-04-24  Tom Tromey  <tromey@adacore.com>
11134
11135         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11136
11137 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11138
11139         * s12z-tdep.c (s12z_unwind_pc): Delete.
11140         (s12z_unwind_sp): Delete.
11141         (s12z_gdbarch_init): Don't register deleted functions with
11142         gdbarch.
11143
11144 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11145
11146         * rl78-tdep.c (rl78_unwind_sp): Delete.
11147         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11148
11149 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11150
11151         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11152         (xstormy16_unwind_pc): Delete.
11153         (xstormy16_dummy_id): Delete.
11154         (xstormy16_gdbarch_init): Don't register deleted functions with
11155         gdbarch.
11156
11157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11158
11159         * vax-tdep.c (vax_unwind_pc): Delete.
11160         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11161
11162 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11163
11164         * v850-tdep.c (v850_unwind_sp): Delete.
11165         (v850_unwind_pc): Delete.
11166         (v850_dummy_id): Delete.
11167         (v850_gdbarch_init): Don't register deleted functions with
11168         gdbarch.
11169
11170 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11171
11172         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11173         (tilegx_unwind_pc): Delete.
11174         (tilegx_unwind_dummy_id): Delete.
11175         (tilegx_gdbarch_init): Don't register deleted functions with
11176         gdbarch.
11177
11178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11179
11180         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11181         (tic6x_dummy_id): Delete.
11182         (tic6x_gdbarch_init): Don't register deleted functions with
11183         gdbarch.
11184
11185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11186
11187         * sparc-tdep.c (sparc_unwind_pc): Delete.
11188         (sparc32_gdbarch_init): Don't register deleted function with
11189         gdbarch.
11190
11191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11192
11193         * sh-tdep.c (sh_unwind_sp): Delete.
11194         (sh_unwind_pc): Delete.
11195         (sh_dummy_id): Delete.
11196         (sh_gdbarch_init): Don't register deleted functions with
11197         gdbarch.
11198
11199 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11200
11201         * score-tdep.c (score_unwind_sp): Delete.
11202         (score_unwind_pc): Delete.
11203         (score_dummy_id): Delete.
11204         (score_gdbarch_init): Don't register deleted functions with
11205         gdbarch.
11206
11207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11208
11209         * rx-tdep.c (rx_unwind_pc): Delete.
11210         (rx_unwind_sp): Delete.
11211         (rx_dummy_id): Delete.
11212         (rx_gdbarch_init): Don't register deleted functions with
11213         gdbarch.  Update comment.
11214
11215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11216
11217         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11218         (rs6000_dummy_id): Delete.
11219         (rs6000_gdbarch_init): Don't register deleted functions with
11220         gdbarch.
11221
11222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11223
11224         * or1k-tdep.c (or1k_dummy_id): Delete.
11225         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11226
11227 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11228
11229         * nios2-tdep.c (nios2_dummy_id): Delete.
11230         (nios2_unwind_sp): Delete.
11231         (nios2_gdbarch_init): Don't register deleted functions with
11232         gdbarch.
11233
11234 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11235
11236         * nds32-tdep.c (nds32_dummy_id): Delete.
11237         (nds32_unwind_pc): Delete.
11238         (nds32_unwind_sp): Delete.
11239         (nds32_gdbarch_init): Don't register deleted functions with
11240         gdbarch.
11241
11242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11243
11244         * msp430-tdep.c (msp430_unwind_pc): Delete.
11245         (msp430_unwind_sp): Delete.
11246         (msp430_dummy_id): Delete.
11247         (msp430_gdbarch_init): Don't register deleted functions with
11248         gdbarch.
11249
11250 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11251
11252         * moxie-tdep.c (moxie_unwind_sp): Delete.
11253         (moxie_unwind_pc): Delete.
11254         (moxie_dummy_id): Delete.
11255         (moxie_gdbarch_init): Don't register deleted functions with
11256         gdbarch.
11257
11258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11259
11260         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11261         (mn10300_unwind_pc): Delete.
11262         (mn10300_unwind_sp): Delete.
11263         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11264         mn10300_unwind_sp.
11265         (mn10300_frame_unwind_init): Don't register deleted functions with
11266         gdbarch.
11267
11268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11269
11270         * mep-tdep.c (mep_unwind_pc): Delete.
11271         (mep_unwind_sp): Delete.
11272         (mep_dummy_id): Delete.
11273         (mep_gdbarch_init): Don't register deleted functions with
11274         gdbarch.
11275
11276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11277
11278         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11279         (m68hc11_unwind_sp): Delete.
11280         (m68hc11_gdbarch_init): Don't register deleted functions with
11281         gdbarch.
11282
11283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11284
11285         * m32r-tdep.c (m32r_unwind_sp): Delete.
11286         (m32r_unwind_pc): Delete.
11287         (m32r_dummy_id): Delete.
11288         (m32r_gdbarch_init): Don't register deleted functions with
11289         gdbarch.
11290
11291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11292
11293         * m32c-tdep.c (m32c_unwind_pc): Delete.
11294         (m32c_unwind_sp): Delete.
11295         (m32c_dummy_id): Delete.
11296         (m32c_gdbarch_init): Don't register deleted functions with
11297         gdbarch.
11298
11299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11300
11301         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11302         (lm32_unwind_pc): Delete.
11303         (lm32_dummy_id): Delete.
11304         (lm32_gdbarch_init): Don't register deleted functions with
11305         gdbarch.
11306
11307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11308
11309         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11310         (iq2000_unwind_pc): Delete.
11311         (iq2000_dummy_id): Delete.
11312         (iq2000_gdbarch_init): Don't register deleted functions with
11313         gdbarch.
11314
11315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11316
11317         * nds32-tdep.c (nds32_type_align): Delete.
11318         (nds32_push_dummy_call): Use type_align instead.
11319
11320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11321
11322         * arm-tdep.c (arm_type_align): Only handle vector override case.
11323         (arm_push_dummy_call): Use type_align.
11324         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11325
11326 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11327
11328         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11329         case.
11330         (pass_on_stack): Use type_align.
11331         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11332         function.
11333
11334 2019-04-23  Tom Tromey  <tromey@adacore.com>
11335
11336         * dwarf2read.c (line_header::file_name_at): Remove unused
11337         overload.
11338
11339 2019-04-23  Tom de Vries  <tdevries@suse.de>
11340
11341         PR gdb/24438
11342         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11343         invocation.
11344
11345
11346 2019-03-27  Ali Tamur  <tamur@google.com>
11347
11348         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11349         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11350         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11351         (dwarf_expr_context::get_addr_index): Likewise
11352         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11353         (symbol_needs_eval_context::get_addr_index): Likewise
11354         (disassemble_dwarf_expression): Add DW_OP_addrx
11355         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11356         (read_cutu_die_from_dwo): Update comment
11357         (skip_one_die): Add DW_FORM_addrx
11358         (read_attribute_value): Likewise
11359         (var_decode_location): Add DW_OP_addrx
11360         (dwarf2_const_value_attr): Add DW_FORM_addrx
11361         (dump_die_shallow): Likewise
11362         (dwarf2_fetch_constant_bytes): Likewise
11363         (decode_locdesc): Add DW_OP_addrx
11364         (skip_form_bytes): Add DW_FORM_addrx
11365
11366 2019-04-22  Ali Tamur  <tamur@google.com>
11367
11368         * MAINTAINERS (Write After Approval): Add self.
11369
11370 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11371
11372         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11373         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11374         (open_symbol_file_object): Likewise.
11375         (svr4_default_sos): Add info parameter.
11376         (svr4_read_so_list): Likewise.
11377         (svr4_current_sos_direct): Adjust functions calls to pass down
11378         info.
11379         (svr4_current_sos_1): Add info parameter.
11380         (svr4_current_sos): Call get_svr4_info, pass info down to
11381         svr4_current_sos_1.
11382         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11383         get_svr4_info.
11384         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11385         get_svr4_info.
11386         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11387         to get_svr4_info.
11388         (probes_table_remove_objfile_probes): Likewise.
11389         (register_solib_event_probe): Add info parameter.
11390         (solist_update_incremental): Pass info parameter down to
11391         svr4_read_so_list.
11392         (disable_probes_interface): Add info parameter.
11393         (svr4_handle_solib_event): Pass current_program_space to
11394         get_svr4_info.  Adjust disable_probes_interface cleanup.
11395         (svr4_create_probe_breakpoints): Add info parameter, pass it
11396         down to register_solib_event_probe.
11397         (svr4_create_solib_event_breakpoints): Add info parameter,
11398         pass it down to svr4_create_probe_breakpoints.
11399         (enable_break): Pass info down to
11400         svr4_create_solib_event_breakpoints.
11401         (svr4_solib_create_inferior_hook): Pass current_program_space to
11402         get_svr4_info.
11403         (svr4_clear_solib): Likewise.
11404
11405 2019-04-22  Pedro Alves  <palves@redhat.com>
11406
11407         * solib-svr4.c (svr4_free_objfile_observer): New.
11408         (probe_and_action::objfile): New field.
11409         (probes_table_htab_remove_objfile_probes)
11410         (probes_table_remove_objfile_probes): New functions.
11411         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11412         in the new probe_and_action.  Don't store the probe in 'lookup'.
11413         (svr4_create_probe_breakpoints): Pass objfile to
11414         register_solib_event_probe.
11415         (_initialize_svr4_solib): Register a free_objfile observer.
11416
11417 2019-04-19  Tom Tromey  <tom@tromey.com>
11418
11419         * common/queue.h: Remove.
11420
11421 2019-04-19  Tom Tromey  <tom@tromey.com>
11422
11423         * event-loop.c: Don't include "common/queue.h".
11424
11425 2019-04-19  Tom Tromey  <tom@tromey.com>
11426
11427         * remote.c (remote_target): Use delete.
11428         * remote-notif.h: Include <list>, not "common/queue.h".
11429         (notif_client_p): Remove typedef.
11430         (remote_notif_state): Add constructor, destructor, initializer.
11431         <notif_queue>: Now a std::list.
11432         (remote_notif_state_xfree): Don't declare.
11433         * remote-notif.c (remote_notif_process, handle_notification)
11434         (remote_notif_state_allocate): Update.
11435         (~remote_notif_state): Rename from remote_notif_state_xfree.
11436
11437 2019-04-19  Tom Tromey  <tom@tromey.com>
11438
11439         * symfile.c (reread_symbols): Update.
11440         * objfiles.c (objfile_register_static_link)
11441         (objfile_lookup_static_link): Update
11442         (~objfile) Don't delete static_links.
11443         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11444
11445 2019-04-19  Tom Tromey  <tom@tromey.com>
11446
11447         * type-stack.h (struct type_stack) <insert>: Constify string.
11448         * type-stack.c (type_stack::insert): Constify string.
11449         * gdbtypes.h (lookup_template_type): Update.
11450         (address_space_name_to_int): Update.
11451         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11452         const.
11453         (lookup_template_type): Make name const.
11454         * c-exp.y: Update rules.
11455         (lex_one_token, classify_name, classify_inner_name)
11456         (c_print_token): Update.
11457         * p-exp.y: Update rules.
11458         (yylex): Update.
11459         * f-exp.y: Update rules.
11460         (yylex): Update.
11461         * d-exp.y: Update rules.
11462         (lex_one_token, classify_name, classify_inner_name): Update.
11463         * parse.c (write_dollar_variable, copy_name): Return std::string.
11464         * parser-defs.h (copy_name): Change return type.
11465         * m2-exp.y: Update rules.
11466         (yylex): Update.
11467         * go-exp.y (lex_one_token): Update.
11468         Update rules.
11469         (classify_unsafe_function, classify_packaged_name)
11470         (classify_name, yylex): Update.
11471
11472 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11473
11474         * configure.ac: add --enable-source-highlight switch.
11475         * configure: Regenerate.
11476         * top.c (print_gdb_version): plumb --enable-source-highlight
11477         status to "show configuration".
11478
11479 2019-04-19  Tom Tromey  <tromey@adacore.com>
11480
11481         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11482         Check ADA_TYPE_P.
11483         (empty_record, ada_template_to_fixed_record_type_1)
11484         (template_to_static_fixed_type)
11485         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11486         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11487         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11488         macros.
11489
11490 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11491
11492         PR symtab/24423:
11493         * source.c (print_source_lines_base): Advance "iter" when a
11494         control character is seen.
11495
11496 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11497
11498         * inferior.h (struct infcall_suspend_state_deleter):
11499         Catch exception in destructor to avoid crash.
11500
11501 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11502
11503         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11504         close to the add_com "shell".
11505
11506 2019-04-18  Tom Tromey  <tromey@adacore.com>
11507
11508         * process-stratum-target.h (class process_stratum_target)
11509         <stratum>: Add "final".
11510
11511 2019-04-17  Tom Tromey  <tromey@adacore.com>
11512
11513         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11514         against nullptr before use.
11515
11516 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11517
11518         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11519
11520 2019-04-17  Jim Wilson  <jimw@sifive.com>
11521             Andrew Burgess  <andrew.burgess@embecosm.com>
11522
11523         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11524         code read might fail, assume 4-byte breakpoint in that case.
11525
11526 2019-04-15  Leszek Swirski  <leszeks@google.com>
11527
11528         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11529         rather than a hand-rolled POD check when checking for forced MEMORY
11530         classification.
11531
11532 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11533
11534         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11535         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11536         function.
11537         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11538         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11539         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11540         declaration.
11541
11542 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11543
11544         * aarch64-linux-nat.c
11545         (aarch64_linux_nat_target::thread_architecture): Add override.
11546         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11547         each VQ.
11548
11549 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11550
11551         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11552
11553 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11554
11555         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11556         target types of size 96-bits, add some additional comments, and
11557         check that the builtin type we found was the correct size.
11558
11559 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11560
11561         * utils.c (prompt_for_continue): Don't restore the styling at the
11562         end, as applied_style has the wrong value.  This fixes styling in
11563         long lists of file names that are interrupted by the "Continue?"
11564         prompt.
11565
11566 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11567
11568         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11569         * c-lang.c (c_language_defn): Likewise.
11570         (cplus_language_defn): Likewise.
11571         (asm_language_defn): Likewise.
11572         (minimal_language_defn): Likewise.
11573         * d-lang.c (d_language_defn): Likewise.
11574         * f-lang.c (f_language_defn): Likewise.
11575         * go-lang.c (go_language_defn): Likewise.
11576         * language.c (unknown_language_defn): Likewise.
11577         (auto_language_defn): Likewise.
11578         * language.h (struct language_defn): Remove la_magic field.
11579         (LANG_MAGIC): Delete.
11580         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11581         * objc-lang.c (objc_language_defn): Likewise.
11582         * opencl-lang.c (opencl_language_defn): Likewise.
11583         * p-lang.c (pascal_language_defn): Likewise.
11584         * rust-lang.c (rust_language_defn): Likewise.
11585
11586 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11587
11588         * riscv-tdep.c (riscv_type_align): New function.
11589         (riscv_type_alignment): Delete.
11590         (riscv_arg_location): Use 'type_align'.
11591         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11592
11593 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11594
11595         * gdbtypes.c (type_align): A struct with no non-static fields also
11596         has alignment of 1.
11597
11598 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11599
11600         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11601         component to 0.
11602         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11603         member.
11604         (riscv_struct_info::analyse): New implementation using new
11605         analyse_inner member function.
11606         (riscv_struct_info::field_offset): New member function.
11607         (riscv_struct_info::m_offsets): New member variable.
11608         (riscv_struct_info::analyse_inner): New private member function,
11609         takes the old implementation of riscv_struct_info::analyse but
11610         extended to track field offsets.
11611         (riscv_call_arg_struct): Update the struct folding special cases
11612         to handle cases where empty C++ structs, which are non-zero
11613         length, are found.
11614         (riscv_arg_location): Initialise the length of each location, a
11615         non-zero length now indicates the location is in use.
11616         (riscv_push_dummy_call): Allow for the first location having a
11617         non-zero offset when setting up arguments.
11618         (riscv_return_value): Likewise, but for return values.
11619
11620 2019-04-11  Tom Tromey  <tromey@adacore.com>
11621
11622         * utils.c (internal_vproblem): Make "msg" const.
11623
11624 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11625
11626         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11627         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11628         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11629         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11630
11631 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11632
11633         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11634         function.
11635         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11636         of amd64_collect_native_gregset.
11637         (amd64_linux_nat_target::store_registers): Likewise.
11638
11639 2019-04-10  Tom Tromey  <tom@tromey.com>
11640
11641         * symtab.c (lookup_global_symbol_from_objfile)
11642         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11643         * objfiles.h (class separate_debug_iterator): New.
11644         (class separate_debug_range): New.
11645         (struct objfile) <separate_debug_objfiles>: New method.
11646         (objfile_separate_debug_iterate): Don't declare.
11647         * objfiles.c (separate_debug_iterator::operator++): Rename from
11648         objfile_separate_debug_iterate.
11649         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11650         iterator.
11651         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11652         iterator.
11653
11654 2019-04-10  Tom Tromey  <tom@tromey.com>
11655
11656         * symfile.c (reread_symbols): Remove old comment.
11657         * objfiles.c (free_all_objfiles): Fix a typo.
11658
11659 2019-04-10  Tom Tromey  <tom@tromey.com>
11660
11661         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11662         * minsyms.c (lookup_minimal_symbol): Use foreach.
11663         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11664         (lookup_minimal_symbol_solib_trampoline): Likewise.
11665         * symfile.c (reread_symbols): Use foreach.
11666
11667 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11668             Tom Tromey  <tromey@adacore.com>
11669
11670         PR rust/24414:
11671         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11672         (rust_lex_int_test): Change "value" to be LONGEST.
11673         (rust_lex_tests): Add test for long integer literal.
11674
11675 2019-04-09  Tom Tromey  <tromey@adacore.com>
11676
11677         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11678         to bool.
11679         (extended_remote_target::attach): Update.
11680         (remote_target::remote_notice_new_inferior): Update.
11681         (remote_target::add_current_inferior_and_thread): Update.
11682         * inferior.c (exit_inferior_1): Use "false".
11683         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11684
11685 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11686
11687         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11688         the "start" command.
11689
11690 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11691
11692         * python/py-inferior.c (infpy_thread_from_thread_handle):
11693         Adjust comments to reflect renaming of thread_from_thread_handle
11694         to thread_from_handle.  Adjust keywords.  Fix type error message.
11695         (inferior_object_methods): Add thread_from_handle.  Retain
11696         thread_from_thread_handle, but mark it as deprecated.
11697
11698 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11699
11700         * gdbthread.h (find_thread_by_handle): Revise declaration.
11701         * thread.c (find_thread_by_handle): Likewise.  Adjust
11702         implementation too.
11703         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11704         support for buffer objects as handles.
11705
11706 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11707
11708         * python/py-infthread.c (thpy_thread_handle): New function.
11709         (thread_object_methods): Register thpy_thread_handle.
11710
11711 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11712
11713         * gdbthread.h (thread_to_thread_handle): Declare.
11714         * thread.c (gdbtypes.h): Include.
11715         (thread_to_thread_handle): New function.
11716
11717         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11718         (target_thread_info_to_thread_handle): Declare.
11719         * target.c (target_thread_info_to_thread_handle): New function.
11720         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11721         * target-delegates.c: Regenerate.
11722
11723         * linux-thread-db.c (class thread_db_target): Add method
11724         thread_info_to_thread_handle.
11725         (thread_db_target::thread_info_to_thread_handle): Define.
11726         * remote.c (class remote_target): Add new method
11727         thread_info_to_thread_handle.
11728         (remote_target::thread_info_to_thread_handle): Define.
11729
11730 2019-04-08  Pedro Alves  <palves@redhat.com>
11731
11732         * common/common-exceptions.c (throw_exception): Don't create
11733         named object to throw; throw directly.
11734         (throw_it): Likewise.  Don't initialize gdb_exception::message
11735         here, with new; pass FMT and AP to the ctor instead.
11736         * common/common-exceptions.h: Include <string>.
11737         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11738         const char *, va_list)): New ctor.  Use std::make_shared.
11739         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11740         errors)): Delete.
11741         (gdb_exception_error::gdb_exception_error(enum errors, const char
11742         *, va_list)): New.
11743         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11744         Add assertion.
11745         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11746         errors)): Delete.
11747         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11748         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11749         Add assertion.
11750
11751 2019-04-08  Tom Tromey  <tom@tromey.com>
11752
11753         * valops.c (value_rtti_indirect_type): Replace throw_exception
11754         with throw.
11755         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11756         with throw.
11757         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11758         throw.
11759         * target.c (target_translate_tls_address): Replace throw_exception
11760         with throw.
11761         * stack.c (frame_apply_command_count): Replace throw_exception
11762         with throw.
11763         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11764         throw.
11765         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11766         with throw.
11767         * rs6000-tdep.c (rs6000_frame_cache)
11768         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11769         * remote.c: Replace throw_exception with throw.
11770         * record-full.c (record_full_message, record_full_wait_1)
11771         (record_full_restore): Replace throw_exception with throw.
11772         * record-btrace.c:
11773         (get_thread_current_frame_id, record_btrace_start_replaying)
11774         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11775         (cmd_record_btrace_start): Replace throw_exception with throw.
11776         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11777         throw.
11778         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11779         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11780         * linespec.c:
11781         (find_linespec_symbols): Replace throw_exception with throw.
11782         * infrun.c (displaced_step_prepare, resume): Replace
11783         throw_exception with throw.
11784         * infcmd.c (post_create_inferior): Replace throw_exception with
11785         throw.
11786         * inf-loop.c (inferior_event_handler): Replace throw_exception
11787         with throw.
11788         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11789         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11790         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11791         (get_prev_frame_always, get_frame_pc_if_available)
11792         (get_frame_address_in_block_if_available, get_frame_language):
11793         Replace throw_exception with throw.
11794         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11795         throw_exception with throw.
11796         * eval.c (fetch_subexp_value, evaluate_var_value)
11797         (evaluate_funcall, evaluate_subexp_standard): Replace
11798         throw_exception with throw.
11799         * dwarf2loc.c (call_site_find_chain)
11800         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11801         Replace throw_exception with throw.
11802         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11803         with throw.
11804         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11805         throw.
11806         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11807         * completer.c (complete_line_internal): Replace throw_exception
11808         with throw.
11809         * compile/compile-object-run.c (compile_object_run): Replace
11810         throw_exception with throw.
11811         * cli/cli-script.c (process_next_line): Replace throw_exception
11812         with throw.
11813         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11814         (btrace_enable, btrace_maint_update_pt_packets): Replace
11815         throw_exception with throw.
11816         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11817         throw_exception with throw.
11818         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11819         throw_exception with throw.
11820         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11821         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11822         * aarch64-tdep.c (aarch64_make_prologue_cache)
11823         (aarch64_make_stub_cache): Replace throw_exception with throw.
11824
11825 2019-04-08  Tom Tromey  <tom@tromey.com>
11826
11827         * common/common-exceptions.c (throw_exception): Rename from
11828         throw_exception_cxx.  Remove old copy.  Make argument const.
11829         (throw_it): Create and throw exception objects directly.
11830         * common/common-exceptions.h (throw_exception): Make argument
11831         const.
11832         (struct gdb_exception_error): Add constructor.
11833         (struct gdb_exception_quit): Add constructor.
11834
11835 2019-04-08  Tom Tromey  <tom@tromey.com>
11836
11837         * common/common-exceptions.h (exception_rethrow): Don't declare.
11838         (TRY_SJLJ): Update comment.
11839         (TRY, CATCH, END_CATCH): Remove.
11840         * common/common-exceptions.c (exception_rethrow): Remove.
11841
11842 2019-04-08  Tom Tromey  <tom@tromey.com>
11843
11844         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11845         Remove.
11846         (gdb_exception_error): Rename from
11847         gdb_exception_RETURN_MASK_ERROR.
11848         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11849         (gdb_quit_bad_alloc): Update.
11850         * aarch64-tdep.c: Update.
11851         * ada-lang.c: Update.
11852         * ada-typeprint.c: Update.
11853         * ada-valprint.c: Update.
11854         * amd64-tdep.c: Update.
11855         * arch-utils.c: Update.
11856         * break-catch-throw.c: Update.
11857         * breakpoint.c: Update.
11858         * btrace.c: Update.
11859         * c-varobj.c: Update.
11860         * cli/cli-cmds.c: Update.
11861         * cli/cli-interp.c: Update.
11862         * cli/cli-script.c: Update.
11863         * common/common-exceptions.c: Update.
11864         * common/new-op.c: Update.
11865         * common/selftest.c: Update.
11866         * compile/compile-c-symbols.c: Update.
11867         * compile/compile-cplus-symbols.c: Update.
11868         * compile/compile-object-load.c: Update.
11869         * compile/compile-object-run.c: Update.
11870         * completer.c: Update.
11871         * corelow.c: Update.
11872         * cp-abi.c: Update.
11873         * cp-support.c: Update.
11874         * cp-valprint.c: Update.
11875         * darwin-nat.c: Update.
11876         * disasm-selftests.c: Update.
11877         * dtrace-probe.c: Update.
11878         * dwarf-index-cache.c: Update.
11879         * dwarf-index-write.c: Update.
11880         * dwarf2-frame-tailcall.c: Update.
11881         * dwarf2-frame.c: Update.
11882         * dwarf2loc.c: Update.
11883         * dwarf2read.c: Update.
11884         * eval.c: Update.
11885         * event-loop.c: Update.
11886         * event-top.c: Update.
11887         * exec.c: Update.
11888         * f-valprint.c: Update.
11889         * fbsd-tdep.c: Update.
11890         * frame-unwind.c: Update.
11891         * frame.c: Update.
11892         * gdbtypes.c: Update.
11893         * gnu-v3-abi.c: Update.
11894         * guile/guile-internal.h: Update.
11895         * guile/scm-block.c: Update.
11896         * guile/scm-breakpoint.c: Update.
11897         * guile/scm-cmd.c: Update.
11898         * guile/scm-disasm.c: Update.
11899         * guile/scm-frame.c: Update.
11900         * guile/scm-lazy-string.c: Update.
11901         * guile/scm-math.c: Update.
11902         * guile/scm-param.c: Update.
11903         * guile/scm-ports.c: Update.
11904         * guile/scm-pretty-print.c: Update.
11905         * guile/scm-symbol.c: Update.
11906         * guile/scm-symtab.c: Update.
11907         * guile/scm-type.c: Update.
11908         * guile/scm-value.c: Update.
11909         * i386-linux-tdep.c: Update.
11910         * i386-tdep.c: Update.
11911         * inf-loop.c: Update.
11912         * infcall.c: Update.
11913         * infcmd.c: Update.
11914         * infrun.c: Update.
11915         * jit.c: Update.
11916         * language.c: Update.
11917         * linespec.c: Update.
11918         * linux-fork.c: Update.
11919         * linux-nat.c: Update.
11920         * linux-tdep.c: Update.
11921         * linux-thread-db.c: Update.
11922         * main.c: Update.
11923         * mi/mi-cmd-break.c: Update.
11924         * mi/mi-cmd-stack.c: Update.
11925         * mi/mi-interp.c: Update.
11926         * mi/mi-main.c: Update.
11927         * objc-lang.c: Update.
11928         * p-valprint.c: Update.
11929         * parse.c: Update.
11930         * ppc-linux-tdep.c: Update.
11931         * printcmd.c: Update.
11932         * python/py-arch.c: Update.
11933         * python/py-breakpoint.c: Update.
11934         * python/py-cmd.c: Update.
11935         * python/py-finishbreakpoint.c: Update.
11936         * python/py-frame.c: Update.
11937         * python/py-framefilter.c: Update.
11938         * python/py-gdb-readline.c: Update.
11939         * python/py-inferior.c: Update.
11940         * python/py-infthread.c: Update.
11941         * python/py-lazy-string.c: Update.
11942         * python/py-linetable.c: Update.
11943         * python/py-objfile.c: Update.
11944         * python/py-param.c: Update.
11945         * python/py-prettyprint.c: Update.
11946         * python/py-progspace.c: Update.
11947         * python/py-record-btrace.c: Update.
11948         * python/py-record.c: Update.
11949         * python/py-symbol.c: Update.
11950         * python/py-type.c: Update.
11951         * python/py-unwind.c: Update.
11952         * python/py-utils.c: Update.
11953         * python/py-value.c: Update.
11954         * python/python.c: Update.
11955         * record-btrace.c: Update.
11956         * record-full.c: Update.
11957         * remote-fileio.c: Update.
11958         * remote.c: Update.
11959         * riscv-tdep.c: Update.
11960         * rs6000-aix-tdep.c: Update.
11961         * rs6000-tdep.c: Update.
11962         * rust-exp.y: Update.
11963         * rust-lang.c: Update.
11964         * s390-tdep.c: Update.
11965         * selftest-arch.c: Update.
11966         * solib-dsbt.c: Update.
11967         * solib-frv.c: Update.
11968         * solib-spu.c: Update.
11969         * solib-svr4.c: Update.
11970         * solib.c: Update.
11971         * sparc64-linux-tdep.c: Update.
11972         * stack.c: Update.
11973         * symfile-mem.c: Update.
11974         * symmisc.c: Update.
11975         * target.c: Update.
11976         * thread.c: Update.
11977         * top.c: Update.
11978         * tracefile-tfile.c: Update.
11979         * tui/tui.c: Update.
11980         * typeprint.c: Update.
11981         * unittests/cli-utils-selftests.c: Update.
11982         * unittests/parse-connection-spec-selftests.c: Update.
11983         * valops.c: Update.
11984         * valprint.c: Update.
11985         * value.c: Update.
11986         * varobj.c: Update.
11987         * windows-nat.c: Update.
11988         * x86-linux-nat.c: Update.
11989         * xml-support.c: Update.
11990
11991 2019-04-08  Tom Tromey  <tom@tromey.com>
11992
11993         * xml-support.c: Use C++ exception handling.
11994         * x86-linux-nat.c: Use C++ exception handling.
11995         * windows-nat.c: Use C++ exception handling.
11996         * varobj.c: Use C++ exception handling.
11997         * value.c: Use C++ exception handling.
11998         * valprint.c: Use C++ exception handling.
11999         * valops.c: Use C++ exception handling.
12000         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12001         handling.
12002         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12003         * typeprint.c: Use C++ exception handling.
12004         * tui/tui.c: Use C++ exception handling.
12005         * tracefile-tfile.c: Use C++ exception handling.
12006         * top.c: Use C++ exception handling.
12007         * thread.c: Use C++ exception handling.
12008         * target.c: Use C++ exception handling.
12009         * symmisc.c: Use C++ exception handling.
12010         * symfile-mem.c: Use C++ exception handling.
12011         * stack.c: Use C++ exception handling.
12012         * sparc64-linux-tdep.c: Use C++ exception handling.
12013         * solib.c: Use C++ exception handling.
12014         * solib-svr4.c: Use C++ exception handling.
12015         * solib-spu.c: Use C++ exception handling.
12016         * solib-frv.c: Use C++ exception handling.
12017         * solib-dsbt.c: Use C++ exception handling.
12018         * selftest-arch.c: Use C++ exception handling.
12019         * s390-tdep.c: Use C++ exception handling.
12020         * rust-lang.c: Use C++ exception handling.
12021         * rust-exp.y: Use C++ exception handling.
12022         * rs6000-tdep.c: Use C++ exception handling.
12023         * rs6000-aix-tdep.c: Use C++ exception handling.
12024         * riscv-tdep.c: Use C++ exception handling.
12025         * remote.c: Use C++ exception handling.
12026         * remote-fileio.c: Use C++ exception handling.
12027         * record-full.c: Use C++ exception handling.
12028         * record-btrace.c: Use C++ exception handling.
12029         * python/python.c: Use C++ exception handling.
12030         * python/py-value.c: Use C++ exception handling.
12031         * python/py-utils.c: Use C++ exception handling.
12032         * python/py-unwind.c: Use C++ exception handling.
12033         * python/py-type.c: Use C++ exception handling.
12034         * python/py-symbol.c: Use C++ exception handling.
12035         * python/py-record.c: Use C++ exception handling.
12036         * python/py-record-btrace.c: Use C++ exception handling.
12037         * python/py-progspace.c: Use C++ exception handling.
12038         * python/py-prettyprint.c: Use C++ exception handling.
12039         * python/py-param.c: Use C++ exception handling.
12040         * python/py-objfile.c: Use C++ exception handling.
12041         * python/py-linetable.c: Use C++ exception handling.
12042         * python/py-lazy-string.c: Use C++ exception handling.
12043         * python/py-infthread.c: Use C++ exception handling.
12044         * python/py-inferior.c: Use C++ exception handling.
12045         * python/py-gdb-readline.c: Use C++ exception handling.
12046         * python/py-framefilter.c: Use C++ exception handling.
12047         * python/py-frame.c: Use C++ exception handling.
12048         * python/py-finishbreakpoint.c: Use C++ exception handling.
12049         * python/py-cmd.c: Use C++ exception handling.
12050         * python/py-breakpoint.c: Use C++ exception handling.
12051         * python/py-arch.c: Use C++ exception handling.
12052         * printcmd.c: Use C++ exception handling.
12053         * ppc-linux-tdep.c: Use C++ exception handling.
12054         * parse.c: Use C++ exception handling.
12055         * p-valprint.c: Use C++ exception handling.
12056         * objc-lang.c: Use C++ exception handling.
12057         * mi/mi-main.c: Use C++ exception handling.
12058         * mi/mi-interp.c: Use C++ exception handling.
12059         * mi/mi-cmd-stack.c: Use C++ exception handling.
12060         * mi/mi-cmd-break.c: Use C++ exception handling.
12061         * main.c: Use C++ exception handling.
12062         * linux-thread-db.c: Use C++ exception handling.
12063         * linux-tdep.c: Use C++ exception handling.
12064         * linux-nat.c: Use C++ exception handling.
12065         * linux-fork.c: Use C++ exception handling.
12066         * linespec.c: Use C++ exception handling.
12067         * language.c: Use C++ exception handling.
12068         * jit.c: Use C++ exception handling.
12069         * infrun.c: Use C++ exception handling.
12070         * infcmd.c: Use C++ exception handling.
12071         * infcall.c: Use C++ exception handling.
12072         * inf-loop.c: Use C++ exception handling.
12073         * i386-tdep.c: Use C++ exception handling.
12074         * i386-linux-tdep.c: Use C++ exception handling.
12075         * guile/scm-value.c: Use C++ exception handling.
12076         * guile/scm-type.c: Use C++ exception handling.
12077         * guile/scm-symtab.c: Use C++ exception handling.
12078         * guile/scm-symbol.c: Use C++ exception handling.
12079         * guile/scm-pretty-print.c: Use C++ exception handling.
12080         * guile/scm-ports.c: Use C++ exception handling.
12081         * guile/scm-param.c: Use C++ exception handling.
12082         * guile/scm-math.c: Use C++ exception handling.
12083         * guile/scm-lazy-string.c: Use C++ exception handling.
12084         * guile/scm-frame.c: Use C++ exception handling.
12085         * guile/scm-disasm.c: Use C++ exception handling.
12086         * guile/scm-cmd.c: Use C++ exception handling.
12087         * guile/scm-breakpoint.c: Use C++ exception handling.
12088         * guile/scm-block.c: Use C++ exception handling.
12089         * guile/guile-internal.h: Use C++ exception handling.
12090         * gnu-v3-abi.c: Use C++ exception handling.
12091         * gdbtypes.c: Use C++ exception handling.
12092         * frame.c: Use C++ exception handling.
12093         * frame-unwind.c: Use C++ exception handling.
12094         * fbsd-tdep.c: Use C++ exception handling.
12095         * f-valprint.c: Use C++ exception handling.
12096         * exec.c: Use C++ exception handling.
12097         * event-top.c: Use C++ exception handling.
12098         * event-loop.c: Use C++ exception handling.
12099         * eval.c: Use C++ exception handling.
12100         * dwarf2read.c: Use C++ exception handling.
12101         * dwarf2loc.c: Use C++ exception handling.
12102         * dwarf2-frame.c: Use C++ exception handling.
12103         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12104         * dwarf-index-write.c: Use C++ exception handling.
12105         * dwarf-index-cache.c: Use C++ exception handling.
12106         * dtrace-probe.c: Use C++ exception handling.
12107         * disasm-selftests.c: Use C++ exception handling.
12108         * darwin-nat.c: Use C++ exception handling.
12109         * cp-valprint.c: Use C++ exception handling.
12110         * cp-support.c: Use C++ exception handling.
12111         * cp-abi.c: Use C++ exception handling.
12112         * corelow.c: Use C++ exception handling.
12113         * completer.c: Use C++ exception handling.
12114         * compile/compile-object-run.c: Use C++ exception handling.
12115         * compile/compile-object-load.c: Use C++ exception handling.
12116         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12117         * compile/compile-c-symbols.c: Use C++ exception handling.
12118         * common/selftest.c: Use C++ exception handling.
12119         * common/new-op.c: Use C++ exception handling.
12120         * cli/cli-script.c: Use C++ exception handling.
12121         * cli/cli-interp.c: Use C++ exception handling.
12122         * cli/cli-cmds.c: Use C++ exception handling.
12123         * c-varobj.c: Use C++ exception handling.
12124         * btrace.c: Use C++ exception handling.
12125         * breakpoint.c: Use C++ exception handling.
12126         * break-catch-throw.c: Use C++ exception handling.
12127         * arch-utils.c: Use C++ exception handling.
12128         * amd64-tdep.c: Use C++ exception handling.
12129         * ada-valprint.c: Use C++ exception handling.
12130         * ada-typeprint.c: Use C++ exception handling.
12131         * ada-lang.c: Use C++ exception handling.
12132         * aarch64-tdep.c: Use C++ exception handling.
12133
12134 2019-04-08  Tom Tromey  <tom@tromey.com>
12135
12136         * xml-support.c (gdb_xml_parser::parse): Update.
12137         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12138         * value.c (show_convenience): Update.
12139         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12140         (test_parse_flags_qcs): Update.
12141         * thread.c (thr_try_catch_cmd): Update.
12142         * target.c (target_translate_tls_address): Update.
12143         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12144         (info_frame_command_core, frame_apply_command_count): Update.
12145         * rust-exp.y (rust_lex_exception_test): Update.
12146         * riscv-tdep.c (riscv_print_one_register_info): Update.
12147         * remote.c (remote_target::enable_btrace): Update.
12148         * record-btrace.c (record_btrace_enable_warn): Update.
12149         * python/py-utils.c (gdbpy_convert_exception): Update.
12150         * printcmd.c (do_one_display, print_variable_and_value): Update.
12151         * mi/mi-main.c (mi_print_exception): Update.
12152         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12153         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12154         * linux-nat.c (linux_nat_target::attach): Update.
12155         * linux-fork.c (class scoped_switch_fork_info): Update.
12156         * infrun.c (displaced_step_prepare): Update.
12157         * infcall.c (call_function_by_hand_dummy): Update.
12158         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12159         * gnu-v3-abi.c (print_one_vtable): Update.
12160         * frame.c (get_prev_frame_always): Update.
12161         * f-valprint.c (info_common_command_for_block): Update.
12162         * exec.c (try_open_exec_file): Update.
12163         * exceptions.c (print_exception, exception_print)
12164         (exception_fprintf, exception_print_same): Update.
12165         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12166         * dwarf-index-cache.c (index_cache::store)
12167         (index_cache::lookup_gdb_index): Update.
12168         * darwin-nat.c (maybe_cache_shell): Update.
12169         * cp-valprint.c (cp_print_value_fields): Update.
12170         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12171         (gcc_cplus_symbol_address): Update.
12172         * compile/compile-c-symbols.c (gcc_convert_symbol)
12173         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12174         * common/selftest.c: Update.
12175         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12176         a std::string.
12177         (exception_try_scope_entry, exception_try_scope_exit): Don't
12178         declare.
12179         (struct exception_try_scope): Remove.
12180         (TRY): Don't use exception_try_scope.
12181         (struct gdb_exception): Add constructor, operator=.
12182         <what>: New method.
12183         (struct gdb_exception_RETURN_MASK_ALL)
12184         (struct gdb_exception_RETURN_MASK_ERROR)
12185         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12186         (struct gdb_quit_bad_alloc): Update.
12187         * common/common-exceptions.c (exception_none): Change
12188         initializer.
12189         (struct catcher) <state, exception>: Initialize inline.
12190         <prev>: Remove member.
12191         (current_catcher): Remove.
12192         (catchers): New global.
12193         (exceptions_state_mc_init): Simplify.
12194         (catcher_pop): Remove.
12195         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12196         (try_scope_depth, exception_try_scope_entry)
12197         (exception_try_scope_exit): Remove.
12198         (throw_exception_sjlj): Update.
12199         (exception_messages, exception_messages_size): Remove.
12200         (throw_it): Simplify.
12201         (gdb_exception_sliced_copy): Remove.
12202         (throw_exception_cxx): Update.
12203         * cli/cli-script.c (script_from_file): Update.
12204         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12205         Update.
12206         * ada-valprint.c (ada_val_print): Update.
12207         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12208         (create_excep_cond_exprs): Update.
12209
12210 2019-04-08  Tom Tromey  <tom@tromey.com>
12211
12212         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12213         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12214         (TRY, CATCH, END_CATCH): Remove some definitions.
12215         * common/common-exceptions.c: Don't use GDB_XCPT.
12216         (catcher_list_size): Remove.
12217         (throw_exception, throw_it): Simplify.
12218
12219 2019-04-05  Tom Tromey  <tom@tromey.com>
12220
12221         Revert the header-sorting patch.
12222         * ft32-tdep.c: Revert.
12223         * frv-tdep.c: Revert.
12224         * frv-linux-tdep.c: Revert.
12225         * frame.c: Revert.
12226         * frame-unwind.c: Revert.
12227         * frame-base.c: Revert.
12228         * fork-child.c: Revert.
12229         * findvar.c: Revert.
12230         * findcmd.c: Revert.
12231         * filesystem.c: Revert.
12232         * filename-seen-cache.h: Revert.
12233         * filename-seen-cache.c: Revert.
12234         * fbsd-tdep.c: Revert.
12235         * fbsd-nat.h: Revert.
12236         * fbsd-nat.c: Revert.
12237         * f-valprint.c: Revert.
12238         * f-typeprint.c: Revert.
12239         * f-lang.c: Revert.
12240         * extension.h: Revert.
12241         * extension.c: Revert.
12242         * extension-priv.h: Revert.
12243         * expprint.c: Revert.
12244         * exec.h: Revert.
12245         * exec.c: Revert.
12246         * exceptions.c: Revert.
12247         * event-top.c: Revert.
12248         * event-loop.c: Revert.
12249         * eval.c: Revert.
12250         * elfread.c: Revert.
12251         * dwarf2read.h: Revert.
12252         * dwarf2read.c: Revert.
12253         * dwarf2loc.c: Revert.
12254         * dwarf2expr.h: Revert.
12255         * dwarf2expr.c: Revert.
12256         * dwarf2-frame.c: Revert.
12257         * dwarf2-frame-tailcall.c: Revert.
12258         * dwarf-index-write.h: Revert.
12259         * dwarf-index-write.c: Revert.
12260         * dwarf-index-common.c: Revert.
12261         * dwarf-index-cache.h: Revert.
12262         * dwarf-index-cache.c: Revert.
12263         * dummy-frame.c: Revert.
12264         * dtrace-probe.c: Revert.
12265         * disasm.h: Revert.
12266         * disasm.c: Revert.
12267         * disasm-selftests.c: Revert.
12268         * dictionary.c: Revert.
12269         * dicos-tdep.c: Revert.
12270         * demangle.c: Revert.
12271         * dcache.h: Revert.
12272         * dcache.c: Revert.
12273         * darwin-nat.h: Revert.
12274         * darwin-nat.c: Revert.
12275         * darwin-nat-info.c: Revert.
12276         * d-valprint.c: Revert.
12277         * d-namespace.c: Revert.
12278         * d-lang.c: Revert.
12279         * ctf.c: Revert.
12280         * csky-tdep.c: Revert.
12281         * csky-linux-tdep.c: Revert.
12282         * cris-tdep.c: Revert.
12283         * cris-linux-tdep.c: Revert.
12284         * cp-valprint.c: Revert.
12285         * cp-support.c: Revert.
12286         * cp-namespace.c: Revert.
12287         * cp-abi.c: Revert.
12288         * corelow.c: Revert.
12289         * corefile.c: Revert.
12290         * continuations.c: Revert.
12291         * completer.h: Revert.
12292         * completer.c: Revert.
12293         * complaints.c: Revert.
12294         * coffread.c: Revert.
12295         * coff-pe-read.c: Revert.
12296         * cli-out.h: Revert.
12297         * cli-out.c: Revert.
12298         * charset.c: Revert.
12299         * c-varobj.c: Revert.
12300         * c-valprint.c: Revert.
12301         * c-typeprint.c: Revert.
12302         * c-lang.c: Revert.
12303         * buildsym.c: Revert.
12304         * buildsym-legacy.c: Revert.
12305         * build-id.h: Revert.
12306         * build-id.c: Revert.
12307         * btrace.c: Revert.
12308         * bsd-uthread.c: Revert.
12309         * breakpoint.h: Revert.
12310         * breakpoint.c: Revert.
12311         * break-catch-throw.c: Revert.
12312         * break-catch-syscall.c: Revert.
12313         * break-catch-sig.c: Revert.
12314         * blockframe.c: Revert.
12315         * block.c: Revert.
12316         * bfin-tdep.c: Revert.
12317         * bfin-linux-tdep.c: Revert.
12318         * bfd-target.c: Revert.
12319         * bcache.c: Revert.
12320         * ax-general.c: Revert.
12321         * ax-gdb.h: Revert.
12322         * ax-gdb.c: Revert.
12323         * avr-tdep.c: Revert.
12324         * auxv.c: Revert.
12325         * auto-load.c: Revert.
12326         * arm-wince-tdep.c: Revert.
12327         * arm-tdep.c: Revert.
12328         * arm-symbian-tdep.c: Revert.
12329         * arm-pikeos-tdep.c: Revert.
12330         * arm-obsd-tdep.c: Revert.
12331         * arm-nbsd-tdep.c: Revert.
12332         * arm-nbsd-nat.c: Revert.
12333         * arm-linux-tdep.c: Revert.
12334         * arm-linux-nat.c: Revert.
12335         * arm-fbsd-tdep.c: Revert.
12336         * arm-fbsd-nat.c: Revert.
12337         * arm-bsd-tdep.c: Revert.
12338         * arch-utils.c: Revert.
12339         * arc-tdep.c: Revert.
12340         * arc-newlib-tdep.c: Revert.
12341         * annotate.h: Revert.
12342         * annotate.c: Revert.
12343         * amd64-windows-tdep.c: Revert.
12344         * amd64-windows-nat.c: Revert.
12345         * amd64-tdep.c: Revert.
12346         * amd64-sol2-tdep.c: Revert.
12347         * amd64-obsd-tdep.c: Revert.
12348         * amd64-obsd-nat.c: Revert.
12349         * amd64-nbsd-tdep.c: Revert.
12350         * amd64-nbsd-nat.c: Revert.
12351         * amd64-nat.c: Revert.
12352         * amd64-linux-tdep.c: Revert.
12353         * amd64-linux-nat.c: Revert.
12354         * amd64-fbsd-tdep.c: Revert.
12355         * amd64-fbsd-nat.c: Revert.
12356         * amd64-dicos-tdep.c: Revert.
12357         * amd64-darwin-tdep.c: Revert.
12358         * amd64-bsd-nat.c: Revert.
12359         * alpha-tdep.c: Revert.
12360         * alpha-obsd-tdep.c: Revert.
12361         * alpha-nbsd-tdep.c: Revert.
12362         * alpha-mdebug-tdep.c: Revert.
12363         * alpha-linux-tdep.c: Revert.
12364         * alpha-linux-nat.c: Revert.
12365         * alpha-bsd-tdep.c: Revert.
12366         * alpha-bsd-nat.c: Revert.
12367         * aix-thread.c: Revert.
12368         * agent.c: Revert.
12369         * addrmap.c: Revert.
12370         * ada-varobj.c: Revert.
12371         * ada-valprint.c: Revert.
12372         * ada-typeprint.c: Revert.
12373         * ada-tasks.c: Revert.
12374         * ada-lang.c: Revert.
12375         * aarch64-tdep.c: Revert.
12376         * aarch64-ravenscar-thread.c: Revert.
12377         * aarch64-newlib-tdep.c: Revert.
12378         * aarch64-linux-tdep.c: Revert.
12379         * aarch64-linux-nat.c: Revert.
12380         * aarch64-fbsd-tdep.c: Revert.
12381         * aarch64-fbsd-nat.c: Revert.
12382         * aarch32-linux-nat.c: Revert.
12383
12384 2019-04-05  Tom Tromey  <tom@tromey.com>
12385
12386         * ft32-tdep.c: Sort headers.
12387         * frv-tdep.c: Sort headers.
12388         * frv-linux-tdep.c: Sort headers.
12389         * frame.c: Sort headers.
12390         * frame-unwind.c: Sort headers.
12391         * frame-base.c: Sort headers.
12392         * fork-child.c: Sort headers.
12393         * findvar.c: Sort headers.
12394         * findcmd.c: Sort headers.
12395         * filesystem.c: Sort headers.
12396         * filename-seen-cache.h: Sort headers.
12397         * filename-seen-cache.c: Sort headers.
12398         * fbsd-tdep.c: Sort headers.
12399         * fbsd-nat.h: Sort headers.
12400         * fbsd-nat.c: Sort headers.
12401         * f-valprint.c: Sort headers.
12402         * f-typeprint.c: Sort headers.
12403         * f-lang.c: Sort headers.
12404         * extension.h: Sort headers.
12405         * extension.c: Sort headers.
12406         * extension-priv.h: Sort headers.
12407         * expprint.c: Sort headers.
12408         * exec.h: Sort headers.
12409         * exec.c: Sort headers.
12410         * exceptions.c: Sort headers.
12411         * event-top.c: Sort headers.
12412         * event-loop.c: Sort headers.
12413         * eval.c: Sort headers.
12414         * elfread.c: Sort headers.
12415         * dwarf2read.h: Sort headers.
12416         * dwarf2read.c: Sort headers.
12417         * dwarf2loc.c: Sort headers.
12418         * dwarf2expr.h: Sort headers.
12419         * dwarf2expr.c: Sort headers.
12420         * dwarf2-frame.c: Sort headers.
12421         * dwarf2-frame-tailcall.c: Sort headers.
12422         * dwarf-index-write.h: Sort headers.
12423         * dwarf-index-write.c: Sort headers.
12424         * dwarf-index-common.c: Sort headers.
12425         * dwarf-index-cache.h: Sort headers.
12426         * dwarf-index-cache.c: Sort headers.
12427         * dummy-frame.c: Sort headers.
12428         * dtrace-probe.c: Sort headers.
12429         * disasm.h: Sort headers.
12430         * disasm.c: Sort headers.
12431         * disasm-selftests.c: Sort headers.
12432         * dictionary.c: Sort headers.
12433         * dicos-tdep.c: Sort headers.
12434         * demangle.c: Sort headers.
12435         * dcache.h: Sort headers.
12436         * dcache.c: Sort headers.
12437         * darwin-nat.h: Sort headers.
12438         * darwin-nat.c: Sort headers.
12439         * darwin-nat-info.c: Sort headers.
12440         * d-valprint.c: Sort headers.
12441         * d-namespace.c: Sort headers.
12442         * d-lang.c: Sort headers.
12443         * ctf.c: Sort headers.
12444         * csky-tdep.c: Sort headers.
12445         * csky-linux-tdep.c: Sort headers.
12446         * cris-tdep.c: Sort headers.
12447         * cris-linux-tdep.c: Sort headers.
12448         * cp-valprint.c: Sort headers.
12449         * cp-support.c: Sort headers.
12450         * cp-namespace.c: Sort headers.
12451         * cp-abi.c: Sort headers.
12452         * corelow.c: Sort headers.
12453         * corefile.c: Sort headers.
12454         * continuations.c: Sort headers.
12455         * completer.h: Sort headers.
12456         * completer.c: Sort headers.
12457         * complaints.c: Sort headers.
12458         * coffread.c: Sort headers.
12459         * coff-pe-read.c: Sort headers.
12460         * cli-out.h: Sort headers.
12461         * cli-out.c: Sort headers.
12462         * charset.c: Sort headers.
12463         * c-varobj.c: Sort headers.
12464         * c-valprint.c: Sort headers.
12465         * c-typeprint.c: Sort headers.
12466         * c-lang.c: Sort headers.
12467         * buildsym.c: Sort headers.
12468         * buildsym-legacy.c: Sort headers.
12469         * build-id.h: Sort headers.
12470         * build-id.c: Sort headers.
12471         * btrace.c: Sort headers.
12472         * bsd-uthread.c: Sort headers.
12473         * breakpoint.h: Sort headers.
12474         * breakpoint.c: Sort headers.
12475         * break-catch-throw.c: Sort headers.
12476         * break-catch-syscall.c: Sort headers.
12477         * break-catch-sig.c: Sort headers.
12478         * blockframe.c: Sort headers.
12479         * block.c: Sort headers.
12480         * bfin-tdep.c: Sort headers.
12481         * bfin-linux-tdep.c: Sort headers.
12482         * bfd-target.c: Sort headers.
12483         * bcache.c: Sort headers.
12484         * ax-general.c: Sort headers.
12485         * ax-gdb.h: Sort headers.
12486         * ax-gdb.c: Sort headers.
12487         * avr-tdep.c: Sort headers.
12488         * auxv.c: Sort headers.
12489         * auto-load.c: Sort headers.
12490         * arm-wince-tdep.c: Sort headers.
12491         * arm-tdep.c: Sort headers.
12492         * arm-symbian-tdep.c: Sort headers.
12493         * arm-pikeos-tdep.c: Sort headers.
12494         * arm-obsd-tdep.c: Sort headers.
12495         * arm-nbsd-tdep.c: Sort headers.
12496         * arm-nbsd-nat.c: Sort headers.
12497         * arm-linux-tdep.c: Sort headers.
12498         * arm-linux-nat.c: Sort headers.
12499         * arm-fbsd-tdep.c: Sort headers.
12500         * arm-fbsd-nat.c: Sort headers.
12501         * arm-bsd-tdep.c: Sort headers.
12502         * arch-utils.c: Sort headers.
12503         * arc-tdep.c: Sort headers.
12504         * arc-newlib-tdep.c: Sort headers.
12505         * annotate.h: Sort headers.
12506         * annotate.c: Sort headers.
12507         * amd64-windows-tdep.c: Sort headers.
12508         * amd64-windows-nat.c: Sort headers.
12509         * amd64-tdep.c: Sort headers.
12510         * amd64-sol2-tdep.c: Sort headers.
12511         * amd64-obsd-tdep.c: Sort headers.
12512         * amd64-obsd-nat.c: Sort headers.
12513         * amd64-nbsd-tdep.c: Sort headers.
12514         * amd64-nbsd-nat.c: Sort headers.
12515         * amd64-nat.c: Sort headers.
12516         * amd64-linux-tdep.c: Sort headers.
12517         * amd64-linux-nat.c: Sort headers.
12518         * amd64-fbsd-tdep.c: Sort headers.
12519         * amd64-fbsd-nat.c: Sort headers.
12520         * amd64-dicos-tdep.c: Sort headers.
12521         * amd64-darwin-tdep.c: Sort headers.
12522         * amd64-bsd-nat.c: Sort headers.
12523         * alpha-tdep.c: Sort headers.
12524         * alpha-obsd-tdep.c: Sort headers.
12525         * alpha-nbsd-tdep.c: Sort headers.
12526         * alpha-mdebug-tdep.c: Sort headers.
12527         * alpha-linux-tdep.c: Sort headers.
12528         * alpha-linux-nat.c: Sort headers.
12529         * alpha-bsd-tdep.c: Sort headers.
12530         * alpha-bsd-nat.c: Sort headers.
12531         * aix-thread.c: Sort headers.
12532         * agent.c: Sort headers.
12533         * addrmap.c: Sort headers.
12534         * ada-varobj.c: Sort headers.
12535         * ada-valprint.c: Sort headers.
12536         * ada-typeprint.c: Sort headers.
12537         * ada-tasks.c: Sort headers.
12538         * ada-lang.c: Sort headers.
12539         * aarch64-tdep.c: Sort headers.
12540         * aarch64-ravenscar-thread.c: Sort headers.
12541         * aarch64-newlib-tdep.c: Sort headers.
12542         * aarch64-linux-tdep.c: Sort headers.
12543         * aarch64-linux-nat.c: Sort headers.
12544         * aarch64-fbsd-tdep.c: Sort headers.
12545         * aarch64-fbsd-nat.c: Sort headers.
12546         * aarch32-linux-nat.c: Sort headers.
12547
12548 2019-04-04  Tom Tromey  <tom@tromey.com>
12549
12550         * varobj.c (varobj_create): Update.
12551         * rust-exp.y (struct rust_parser) <update_innermost_block,
12552         lookup_symbol>: New methods.
12553         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12554         Rename.
12555         (rust_parser::rust_lookup_type)
12556         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12557         * printcmd.c (display_command, do_one_display): Update.
12558         * parser-defs.h (struct parser_state) <parser_state>: Add
12559         "tracker" parameter.
12560         (block_tracker): New member.
12561         (class innermost_block_tracker) <innermost_block_tracker>: Add
12562         "types" parameter.
12563         <reset>: Remove method.
12564         (innermost_block): Don't declare.
12565         (null_post_parser): Update.
12566         * parse.c (innermost_block): Remove global.
12567         (write_dollar_variable): Update.
12568         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12569         Remove "tracker_types" parameter.
12570         (parse_expression): Add "tracker" parameter.
12571         (parse_expression_for_completion): Update.
12572         (null_post_parser): Add "tracker" parameter.
12573         * p-exp.y: Update rules.
12574         * m2-exp.y: Update rules.
12575         * language.h (struct language_defn) <la_post_parser>: Add
12576         "tracker" parameter.
12577         * go-exp.y: Update rules.
12578         * f-exp.y: Update rules.
12579         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12580         parameter.
12581         * d-exp.y: Update rules.
12582         * c-exp.y: Update rules.
12583         * breakpoint.c (set_breakpoint_condition): Create an
12584         innermost_block_tracker.
12585         (watch_command_1): Likewise.
12586         * ada-lang.c (resolve): Add "tracker" parameter.
12587         (resolve_subexp): Likewise.
12588         * ada-exp.y (write_var_from_sym): Update.
12589
12590 2019-04-04  Tom Tromey  <tom@tromey.com>
12591
12592         * type-stack.h: New file.
12593         * type-stack.c: New file.
12594         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12595         type-stack.h.
12596         (insert_into_type_stack, insert_type, push_type, push_type_int)
12597         (insert_type_address_space, pop_type, pop_type_int)
12598         (pop_typelist, pop_type_stack, append_type_stack)
12599         (push_type_stack, get_type_stack, push_typelist)
12600         (follow_type_instance_flags, follow_types): Don't declare.
12601         * parse.c (type_stack): Remove global.
12602         (parse_exp_in_context): Update.
12603         (insert_into_type_stack, insert_type, push_type, push_type_int)
12604         (insert_type_address_space, pop_type, pop_type_int)
12605         (pop_typelist, pop_type_stack, append_type_stack)
12606         (push_type_stack, get_type_stack, push_typelist)
12607         (follow_type_instance_flags, follow_types): Remove (moved to
12608         type-stack.c).
12609         * f-exp.y (type_stack): New global.
12610         Update rules.
12611         (push_kind_type, f_parse): Update.
12612         * d-exp.y (type_stack): New global.
12613         Update rules.
12614         (d_parse): Update.
12615         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12616         Update rules.
12617         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12618         (HFILES_NO_SRCDIR): Add type-stack.h.
12619
12620 2019-04-04  Tom Tromey  <tom@tromey.com>
12621
12622         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12623         (rust_parser::convert_ast_to_expression, rust_parse)
12624         (rust_lex_test_completion, rust_lex_tests): Update.
12625         * parser-defs.h (struct expr_completion_state): New.
12626         (struct parser_state) <parser_state>: Add completion parameter.
12627         <mark_struct_expression, mark_completion_tag>: New methods.
12628         <parse_completion, m_completion_state>: New members.
12629         (prefixify_expression, null_post_parser): Update.
12630         (mark_struct_expression, mark_completion_tag): Don't declare.
12631         * parse.c (parse_completion, expout_last_struct)
12632         (expout_tag_completion_type, expout_completion_name): Remove
12633         globals.
12634         (parser_state::mark_struct_expression)
12635         (parser_state::mark_completion_tag): Now methods.
12636         (prefixify_expression): Add last_struct parameter.
12637         (prefixify_subexp): Likewise.
12638         (parse_exp_1): Update.
12639         (parse_exp_in_context): Add cstate parameter.  Update.
12640         (parse_expression_for_completion): Create an
12641         expr_completion_state.
12642         (null_post_parser): Add "completion" parameter.
12643         * p-exp.y: Update rules.
12644         (yylex): Update.
12645         * language.h (struct language_defn) <la_post_parser>: Add
12646         "completing" parameter.
12647         * go-exp.y: Update rules.
12648         (lex_one_token): Update.
12649         * expression.h (parse_completion): Don't declare.
12650         * d-exp.y: Update rules.
12651         (lex_one_token): Update rules.
12652         * c-exp.y: Update rules.
12653         (lex_one_token): Update.
12654         * ada-lang.c (resolve): Add "parse_completion" parameter.
12655         (resolve_subexp): Likewise.
12656         (ada_resolve_function): Likewise.
12657
12658 2019-04-04  Tom Tromey  <tom@tromey.com>
12659
12660         * parser-defs.h (struct parser_state) <start_arglist,
12661         end_arglist>: New methods.
12662         <arglist_len, m_funcall_chain>: New members.
12663         (arglist_len, start_arglist, end_arglist): Don't declare.
12664         * parse.c (arglist_len, funcall_chain): Remove global.
12665         (start_arglist, end_arglist): Remove functions.
12666         (parse_exp_in_context): Update.
12667         * p-exp.y: Update rules.
12668         * m2-exp.y: Update rules.
12669         * go-exp.y: Update rules.
12670         * f-exp.y: Update rules.
12671         * d-exp.y: Update rules.
12672         * c-exp.y: Update rules.
12673
12674 2019-04-04  Tom Tromey  <tom@tromey.com>
12675
12676         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12677         lex_operator, push_back>: New methods.
12678         Update all rules.
12679         (rust_parser::lex_hex, lex_escape): Rename and update.
12680         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12681         (rust_parser::lex_operator): Rename and update.
12682         (rust_parser::lex_number, rustyylex, rustyyerror)
12683         (rust_lex_test_init, rust_lex_test_sequence)
12684         (rust_lex_test_push_back, rust_lex_tests): Update.
12685         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12686         parameter.
12687         <lexptr, prev_lexptr>: New members.
12688         (lexptr, prev_lexptr): Don't declare.
12689         * parse.c (lexptr, prev_lexptr): Remove globals.
12690         (parse_exp_in_context): Update.
12691         * p-exp.y (yylex, yyerror): Update.
12692         * m2-exp.y (parse_number, yylex, yyerror): Update.
12693         * go-exp.y (lex_one_token, yyerror): Update.
12694         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12695         * d-exp.y (lex_one_token, yyerror): Update.
12696         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12697         (lex_one_token, yyerror): Update.
12698         * ada-lex.l (YY_INPUT): Update.
12699         (rewind_to_char): Update.
12700         * ada-exp.y (yyerror): Update.
12701
12702 2019-04-04  Tom Tromey  <tom@tromey.com>
12703
12704         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12705         * parser-defs.h (struct parser_state) <parser_state>: Add new
12706         parameter.
12707         <comma_terminates>: New member.
12708         (comma_terminates): Don't declare global.
12709         * parse.c (comma_terminates): Remove global.
12710         (parse_exp_in_context): Update.
12711         * p-exp.y (yylex): Update.
12712         * m2-exp.y (yylex): Update.
12713         * go-exp.y (lex_one_token): Update.
12714         * f-exp.y (yylex): Update.
12715         * d-exp.y (lex_one_token): Update.
12716         * c-exp.y (lex_one_token): Update.
12717         * ada-lex.l: Update.
12718
12719 2019-04-04  Tom Tromey  <tom@tromey.com>
12720
12721         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12722         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12723         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12724         * parser-defs.h (paren_depth): Don't declare.
12725         * parse.c (paren_depth): Remove global.
12726         (parse_exp_in_context): Update.
12727         * p-exp.y (paren_depth): New global.
12728         (pascal_parse): Initialize it.
12729         * m2-exp.y (paren_depth): New global.
12730         (m2_parse): Initialize it.
12731         * go-exp.y (paren_depth): New global.
12732         (go_parse): Initialize it.
12733         * f-exp.y (paren_depth): New global.
12734         (f_parse): Initialize it.
12735         * d-exp.y (paren_depth): New global.
12736         (d_parse): Initialize it.
12737         * c-exp.y (paren_depth): New global.
12738         (c_parse): Initialize it.
12739         * ada-lex.l (paren_depth): New global.
12740         (lexer_init): Initialize it.
12741
12742 2019-04-04  Tom Tromey  <tom@tromey.com>
12743
12744         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12745         (rust_parser::convert_ast_to_type)
12746         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12747         * parser-defs.h (struct parser_state) <parser_state>: Add
12748         parameters.  Initialize new members.
12749         <expression_context_block, expression_context_pc>: New members.
12750         * parse.c (expression_context_block, expression_context_pc):
12751         Remove globals.
12752         (parse_exp_in_context): Update.
12753         * p-exp.y: Update all rules.
12754         (yylex): Update.
12755         * m2-exp.y: Update all rules.
12756         (yylex): Update.
12757         * go-exp.y (yylex): Update.
12758         * f-exp.y (yylex): Update.
12759         * d-exp.y: Update all rules.
12760         (yylex): Update.
12761         * c-exp.y: Update all rules.
12762         (lex_one_token, classify_name, yylex, c_parse): Update.
12763         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12764
12765 2019-04-04  Tom Tromey  <tom@tromey.com>
12766
12767         * gdbarch.h, gdbarch.c: Rebuild.
12768         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12769         * stap-probe.h:
12770         (struct stap_parse_info): Replace "parser_state" with
12771         "expr_builder".
12772         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12773         (parser_state): New class.
12774         * parse.c (expr_builder): Rename.
12775         (expr_builder::release): Rename.
12776         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12777         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12778         (write_exp_elt_longcst, write_exp_elt_floatcst)
12779         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12780         (write_exp_string_vector, write_exp_bitstring)
12781         (write_exp_msymbol, mark_struct_expression)
12782         (write_dollar_variable)
12783         (insert_type_address_space, increase_expout_size): Replace
12784         "parser_state" with "expr_builder".
12785         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12786         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12787         "parser_state" with "expr_builder".
12788
12789 2019-04-04  Tom Tromey  <tom@tromey.com>
12790
12791         * rust-exp.y: Replace "parse_language" with method call.
12792         * p-exp.y:
12793         (yylex): Replace "parse_language" with method call.
12794         * m2-exp.y:
12795         (yylex): Replace "parse_language" with method call.
12796         * go-exp.y (classify_name): Replace "parse_language" with method
12797         call.
12798         * f-exp.y (yylex): Replace "parse_language" with method call.
12799         * d-exp.y (lex_one_token): Replace "parse_language" with method
12800         call.
12801         * c-exp.y:
12802         (lex_one_token, classify_name, yylex): Replace "parse_language"
12803         with method call.
12804         * ada-exp.y (find_primitive_type, type_char)
12805         (type_system_address): Replace "parse_language" with method call.
12806
12807 2019-04-04  Tom Tromey  <tom@tromey.com>
12808
12809         * rust-exp.y: Replace "parse_gdbarch" with method call.
12810         * parse.c (write_dollar_variable, insert_type_address_space):
12811         Replace "parse_gdbarch" with method call.
12812         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12813         call.
12814         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12815         call.
12816         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12817         "parse_gdbarch" with method call.
12818         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12819         with method call.
12820         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12821         "parse_gdbarch" with method call.
12822         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12823         "parse_gdbarch" with method call.
12824         * c-exp.y (parse_type, parse_number, classify_name): Replace
12825         "parse_gdbarch" with method call.
12826         * ada-lex.l: Replace "parse_gdbarch" with method call.
12827         * ada-exp.y (parse_type, find_primitive_type, type_char)
12828         (type_system_address): Replace "parse_gdbarch" with method call.
12829
12830 2019-04-04  Tom Tromey  <tom@tromey.com>
12831
12832         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12833         * stap-probe.c (stap_parse_argument): Update.
12834         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12835         initial_size parameter.
12836         * rust-exp.y (rust_lex_tests): Update.
12837         * parse.c (parser_state): Update.
12838         (parse_exp_in_context): Update.
12839         * parser-defs.h (struct parser_state) <parser_state>: Remove
12840         "initial_size" parameter.
12841
12842 2019-04-04  Tom Tromey  <tom@tromey.com>
12843
12844         * parser-defs.h (increase_expout_size): Don't declare.
12845         * parse.c (increase_expout_size): Now static.
12846
12847 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12848
12849         * gnu-nat.c (gnu_nat_target::wait): Fix
12850         target_waitstatus_to_string call.
12851
12852 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12853
12854         * eval.c (evaluate_subexp_standard): Handle internal functions
12855         during Fortran function call handling.
12856
12857 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12858
12859         * NEWS: Mention new internal functions.
12860         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12861         (read_base_type): Use dwarf2_init_complex_target_type.
12862         * value.c (creal_internal_fn): New function.
12863         (cimag_internal_fn): New function.
12864         (_initialize_values): Register new internal functions.
12865
12866 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12867
12868         * infrun.c (stop_all_threads): If debug_infrun, always
12869         trace the wait status after wait_one, using
12870         target_waitstatus_to_string and target_pid_to_str.
12871         (handle_inferior_event): Replace various trace of
12872         wait status kind by a single trace.
12873         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12874         wait status kind image by target_waitstatus_to_string.
12875         * target/waitstatus.c (target_waitstatus_to_string): Fix
12876         obsolete comment.
12877
12878 2019-04-01  Tom Tromey  <tromey@adacore.com>
12879
12880         PR symtab/23331:
12881         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12882
12883 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12884             Pedro Alves  <palves@redhat.com>
12885
12886         * top.c (quit_force): Call 'finalize_values'.
12887         * value.c (finalize_values): New function.
12888         * value.h (finalize_values): Declare.
12889
12890 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12891
12892         * NEWS: Announce $_gdb_major and $_gdb_minor.
12893
12894         * top.c (init_gdb_version_vars): New function.
12895         (gdb_init): Call init_gdb_version_vars.
12896
12897 2019-03-29  Tom Tromey  <tromey@adacore.com>
12898
12899         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12900         help text.  Remove dead code.
12901
12902 2019-03-29  Keith Seitz  <keiths@redhat.com>
12903
12904         From Siddhesh Poyarekar:
12905         * f-lang.h (f77_get_upperbound): Return LONGEST.
12906         (f77_get_lowerbound): Likewise.
12907         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12908         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12909         print them.
12910         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12911         plongest to format print it.
12912         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12913         (f77_get_upperbound): Likewise.
12914         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12915         LOWER_BOUND to LONGEST.
12916         (f77_create_arrayprint_offset_tbl): Likewise.
12917
12918 2019-03-29  Keith Seitz  <keiths@redhat.com>
12919
12920         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12921         %s/pulongest for TYPE_LENGTH instead of %d in format
12922         strings.
12923         * ada-typerint.c (ada_print_type): Likewise.
12924         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12925         * compile/compile-c-support.c (generate_register_struct): Likewise.
12926         * gdbtypes.c (recursive_dump_type): Likewise.
12927         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12928         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12929         instead of %d in format strings.
12930         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12931         to std::min to ULONGEST.
12932         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12933         instead of %d in format strings.
12934         * tracepoint.c (info_scope_command): Likewise.
12935         * typeprint.c (print_offset_data::update)
12936         (print_offset_data::finish): Likewise.
12937         * xtensa-tdep.c (xtensa_store_return_value)
12938         (xtensa_push_dummy_call): Likewise.
12939
12940 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12941
12942         * windows-nat.c (display_selector): Fixed format specifications
12943         for 64-bit Cygwin.
12944
12945 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12946
12947         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12948
12949 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12950
12951         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12952         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12953         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12954         (nios2_linux_init_abi): Install it.
12955
12956 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12957
12958         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12959
12960 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12961
12962         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12963
12964 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12965             Tom Tromey  <tromey@adacore.com>
12966
12967         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12968
12969 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12970
12971         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12972         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12973         method to compute the bounds of range types. Also print "[evaluated]"
12974         if the bounds' values come from a dynamic evaluation.
12975
12976 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12977
12978         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12979         whitespace when pretty printing is on.
12980
12981 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12982
12983         * ppc-linux-nat.c: Add include.
12984
12985 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12986
12987         * NEWS: Mention AArch64 Pointer Authentication.
12988
12989 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12990
12991         * arm-linux-nat.c: Add include.
12992
12993 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12994
12995         * source-cache.c (source_cache::get_source_lines): Re-read
12996         fullname after calling open_source_file.
12997
12998 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12999
13000         * NEWS: Mention TLS support for FreeBSD.
13001
13002 2019-03-25  Tom Tromey  <tromey@adacore.com>
13003
13004         * minsyms.c (BUNCH_SIZE): Update comment.
13005         (~minimal_symbol_reader): Remove old comment.
13006         (compact_minimal_symbols): Update comment.
13007         (minimal_symbol_reader::install): Remove old comment.  Update
13008         other comments.
13009
13010 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13011
13012         * s390-linux-nat.c: Add include.
13013
13014 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13015
13016         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13017         Call linux_get_hwcap.
13018         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13019         Likewise.
13020         (aarch64_linux_get_hwcap): Remove function.
13021         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13022         declaration.
13023         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13024         linux_get_hwcap.
13025         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13026         * linux-tdep.c (linux_get_hwcap): Add function.
13027         (linux_get_hwcap2): Likewise.
13028         * linux-tdep.h (linux_get_hwcap): Add declaration.
13029         (linux_get_hwcap2): Likewise.
13030         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13031         (ppc_linux_get_hwcap2): Likewise.
13032         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13033         linux_get_hwcap.
13034         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13035         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13036         (ppc_linux_nat_target::read_description): Likewise.
13037         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13038         * s390-linux-nat.c: Likewise.
13039         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13040
13041 2019-03-24  Tom Tromey  <tom@tromey.com>
13042
13043         * ada-lang.c (standard_lookup): Simplify initialization.
13044         (ada_lookup_symbol_nonlocal): Simplify return.
13045         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13046         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13047         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13048         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13049         initialization.
13050         * solib.c (solib_global_lookup): Simplify.
13051         * symtab.c (null_block_symbol): Remove.
13052         (symbol_cache_lookup): Simplify returns.
13053         (lookup_language_this): Simplify returns.
13054         (lookup_symbol_aux): Simplify return.
13055         (lookup_local_symbol): Simplify returns.
13056         (lookup_global_symbol_from_objfile): Simplify return.
13057         (lookup_symbol_in_objfile_symtabs)
13058         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13059         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13060         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13061         * cp-namespace.c (cp_lookup_bare_symbol)
13062         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13063         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13064         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13065         (cp_lookup_symbol_via_imports): Simplify initialization.
13066         (find_symbol_in_baseclass): Likewise.
13067         * symtab.h (null_block_symbol): Remove.
13068         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13069         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13070         (d_lookup_symbol_module): Likewise.
13071         (find_symbol_in_baseclass): Simplify initialization.
13072
13073 2019-03-24  Tom Tromey  <tom@tromey.com>
13074
13075         * expression.h: Don't include symtab.h.
13076         (struct block): Forward declare.
13077
13078 2019-03-24  Tom Tromey  <tom@tromey.com>
13079
13080         * c-exp.y (typebase): Remove casts.
13081         * gdbtypes.c (lookup_unsigned_typename, )
13082         (lookup_signed_typename): Remove cast.
13083         * eval.c (parse_to_comma_and_eval): Remove cast.
13084         * parse.c (write_dollar_variable): Remove cast.
13085         * block.h (struct block) <superblock>: Now const.
13086         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13087         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13088         (map_block): Make "block" const.
13089         * symfile.h (struct quick_symbol_functions)
13090         <map_matching_symbols>: Constify block argument to "callback".
13091         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13092         const.
13093         (find_pc_sect_compunit_symtab): Make "b" const.
13094         (find_symbol_at_address): Likewise.
13095         (search_symbols): Likewise.
13096         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13097         (dw2_debug_names_lookup_symbol): Likewise.
13098         (dw2_map_matching_symbols): Update.
13099         * p-valprint.c (pascal_val_print): Remove "block".
13100         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13101         (aux_add_nonlocal_symbols): Make "block" const.
13102         (resolve_subexp): Remove cast.
13103         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13104         const.
13105         (iterate_over_file_blocks): Likewise.
13106         * f-exp.y (%union) <bval>: Remove.
13107         * coffread.c (patch_opaque_types): Make "b" const.
13108         * spu-tdep.c (spu_catch_start): Make "block" const.
13109         * c-valprint.c (print_unpacked_pointer): Remove "block".
13110         * symmisc.c (dump_symtab_1): Make "b" const.
13111         (block_depth): Make "block" const.
13112         * d-exp.y (%union) <bval>: Remove.
13113         * cp-support.h (cp_lookup_rtti_type): Update.
13114         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13115         * psymtab.c (psym_lookup_symbol): Make "block" const.
13116         (maintenance_check_psymtabs): Make "b" const.
13117         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13118         (enumerate_locals, enumerate_args): Update.
13119         * python/py-symtab.c (stpy_global_block): Make "block" const.
13120         (stpy_static_block): Likewise.
13121         * inline-frame.c (block_starting_point_at): Make "new_block"
13122         const.
13123         * block.c (find_block_in_blockvector): Make return type const.
13124         (blockvector_for_pc_sect): Make "b" const.
13125         (find_block_in_blockvector): Make "b" const.
13126
13127 2019-03-23  Tom Tromey  <tom@tromey.com>
13128
13129         * varobj.c (varobj_create): Update.
13130         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13131         * printcmd.c (display_command, do_one_display): Don't reset
13132         innermost_block.
13133         * parser-defs.h (enum innermost_block_tracker_type): Move to
13134         expression.h.
13135         (innermost_block): Update comment.
13136         * parse.c (parse_exp_1): Add tracker_types parameter.
13137         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13138         tracker_types parameter.  Reset innermost_block.
13139         (parse_exp_in_context): Remove.
13140         (parse_expression_for_completion): Update.
13141         * objfiles.c (~objfile): Don't reset expression_context_block or
13142         innermost_block.
13143         * expression.h (enum innermost_block_tracker_type): Move from
13144         parser-defs.h.
13145         (parse_exp_1): Add tracker_types parameter.
13146         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13147         reset innermost_block.
13148
13149 2019-03-23  Tom Tromey  <tom@tromey.com>
13150
13151         * objfiles.h: Include bcache.h.
13152
13153 2019-03-23  Tom Tromey  <tom@tromey.com>
13154
13155         * linespec.c (get_current_search_block): Use
13156         scoped_restore_current_language.
13157         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13158
13159 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13160             Jiong Wang  <jiong.wang@arm.com>
13161
13162         * aarch64-linux-tdep.c
13163         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13164         section.
13165         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13166
13167 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13168             Jiong Wang  <jiong.wang@arm.com>
13169
13170         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13171         instructions.
13172         (aarch64_analyze_prologue_test): Add PACIASP test.
13173         (aarch64_prologue_prev_register): Unmask PC value.
13174
13175 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13176             Jiong Wang  <jiong.wang@arm.com>
13177
13178         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13179         (aarch64_dwarf2_prev_register): Unmask PC value.
13180         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13181         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13182         DW_CFA_AARCH64_negate_ra_state.
13183         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13184
13185 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13186             Jiong Wang  <jiong.wang@arm.com>
13187
13188         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13189         registers.
13190         (aarch64_pseudo_register_name): Likewise.
13191         (aarch64_pseudo_register_type): Likewise.
13192         (aarch64_pseudo_register_reggroup_p): Likewise.
13193         (aarch64_gdbarch_init): Add pauth registers.
13194         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13195         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13196         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13197         (struct gdbarch_tdep): Add regnum for ra_state.
13198
13199 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13200             Jiong Wang  <jiong.wang@arm.com>
13201
13202         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13203
13204 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13205             Jiong Wang  <jiong.wang@arm.com>
13206
13207         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13208         function.
13209         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13210         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13211         (aarch64_gdbarch_init): Add puth registers.
13212         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13213         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13214         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13215
13216 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13217             Jiong Wang  <jiong.wang@arm.com>
13218
13219         * aarch64-linux-nat.c
13220         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13221         * aarch64-linux-tdep.c
13222         (aarch64_linux_core_read_description): Likewise.
13223         (aarch64_linux_get_hwcap): New function.
13224         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13225         (aarch64_linux_get_hwcap): New declaration.
13226
13227 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13228             Jiong Wang  <jiong.wang@arm.com>
13229
13230         * aarch64-linux-nat.c
13231         (aarch64_linux_nat_target::read_description): Add pauth param.
13232         * aarch64-linux-tdep.c
13233         (aarch64_linux_core_read_description): Likewise.
13234         * aarch64-tdep.c (struct target_desc): Add in pauth.
13235         (aarch64_read_description): Add pauth param.
13236         (aarch64_gdbarch_init): Likewise.
13237         * aarch64-tdep.h (aarch64_read_description): Likewise.
13238         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13239         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13240         * features/Makefile: Add new files.
13241         * features/aarch64-pauth.c: New file.
13242         * features/aarch64-pauth.xml: New file.
13243
13244 2019-03-20  Tom Tromey  <tromey@adacore.com>
13245
13246         * infrun.c (handle_inferior_event): Rename from
13247         handle_inferior_event_1.  Create a scoped_value_mark.
13248         (handle_inferior_event): Remove.
13249
13250 2019-03-19  Tom Tromey  <tromey@adacore.com>
13251
13252         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13253         * infrun.h (print_stop_event): Add "displays" parameter.
13254         * infrun.c (print_stop_event): Add "displays" parameter.
13255
13256 2019-03-19  Pedro Alves  <palves@redhat.com>
13257
13258         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13259         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13260         to -1.  Fix TABs vs spaces.
13261         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13262         * tui/tui-out.h (tui_ui_out) Add intro comments.
13263         <m_line, m_start_of_line>: In-class initialize, and add describing
13264         comment.
13265
13266 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13267
13268         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13269         variable names.
13270         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13271
13272 2019-03-18  Pedro Alves  <palves@redhat.com>
13273             Eli Zaretskii <eliz@gnu.org>
13274
13275         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13276         m_line and m_start_of_line.
13277
13278 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13279
13280         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13281         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13282         it returns a newline.  This fixes a regression in TU mode, whereby
13283         the next line is output on the same screen line as the user input.
13284
13285 2019-03-18  Tom Tromey  <tromey@adacore.com>
13286
13287         * minsyms.c (minimal_symbol_reader::install): Remove call to
13288         obstack_blank.
13289
13290 2019-03-18  Pedro Alves  <palves@redhat.com>
13291
13292         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13293         New globals.
13294         (apply_style): New, factored out from ...
13295         (apply_ansi_escape): ... this.  Handle reverse video mode.
13296         (tui_set_reverse_mode): New function.
13297         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13298         * tui/tui-winsource.c (tui_show_source_line): Use
13299         tui_set_reverse_mode instead of setting A_STANDOUT.
13300         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13301         New setter methods.
13302
13303 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13304
13305         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13306         Handle tabs.
13307
13308 2019-03-18  Tom Tromey  <tromey@adacore.com>
13309
13310         * ada-lang.c (empty_array): Add "high" parameter.
13311         (ada_evaluate_subexp): Update.
13312
13313 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13314
13315         * unittests/string_view-selftests.c: Define
13316         _initialize_string_view_selftests unconditionally.
13317
13318 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13319
13320         PR gdb/24350
13321         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13322
13323 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13324
13325         PR gdb/24351
13326         * windows-nat.c (display_selector): Fix format specifiers.
13327
13328 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13329
13330         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13331         tui_refill_source_window instead of tui_refresh_win, to update the
13332         current execution line.  This fixes redisplay of the current line
13333         when stepping through the code with "next" or "step".
13334
13335 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13336
13337         * source-cache.c (source_cache::get_source_lines): Call
13338         find_source_lines to initialize s->nlines.  This fixes vertical
13339         scrolling of TUI source window when the DOWN arrow is pressed.
13340
13341 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13342
13343         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13344         linux-thread-db.c (_initialize_thread_db): Likewise.
13345
13346 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13347
13348         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13349         wclrtoeol in tui_show_source_line".  This reverts changes made in
13350         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13351
13352 2019-03-15  Tom Tromey  <tom@tromey.com>
13353
13354         * symtab.h (struct minimal_symbol): Derive from
13355         general_symbol_info.
13356         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13357         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13358         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13359         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13360         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13361         (MSYMBOL_SEARCH_NAME): Update.
13362         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13363         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13364         * minsyms.c (minimal_symbol_reader::record_full): Update.
13365
13366 2019-03-15  Tom Tromey  <tom@tromey.com>
13367
13368         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13369
13370 2019-03-15  Tom Tromey  <tom@tromey.com>
13371
13372         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13373         unique_xmalloc_ptr.
13374         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13375         Update.
13376         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13377         (build_minimal_symbol_hash_tables)
13378         (minimal_symbol_reader::install): Update.
13379
13380 2019-03-15  Tom Tromey  <tom@tromey.com>
13381
13382         * symtab.c (create_demangled_names_hash): Update.
13383         (symbol_set_names): Update.
13384         * objfiles.h (struct objfile_per_bfd_storage)
13385         <demangled_names_hash>: Now an htab_up.
13386         * objfiles.c (objfile_per_bfd_storage): Simplify.
13387
13388 2019-03-15  Tom Tromey  <tom@tromey.com>
13389
13390         * objfiles.h (struct objfile_per_bfd_storage): Declare
13391         destructor.
13392         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13393         New.
13394         (get_objfile_bfd_data): Use new.  Don't initialize
13395         language_of_main.
13396         (free_objfile_per_bfd_storage): Remove.
13397         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13398
13399 2019-03-15  Tom Tromey  <tom@tromey.com>
13400
13401         * symfile.c (reread_symbols): Update.
13402         * objfiles.c (objfile::objfile): Update.
13403         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13404         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13405         comment.
13406         (minimal_symbol_reader::install): Update.
13407         (terminate_minimal_symbol_table): Remove.
13408         * jit.c (jit_object_close_impl): Update.
13409
13410 2019-03-15  Tom Tromey  <tom@tromey.com>
13411
13412         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13413         initializations.
13414
13415 2019-03-15  Tom Tromey  <tom@tromey.com>
13416
13417         * objfiles.h (struct objfile_per_bfd_storage)
13418         <demangled_hash_languages>: Now a bitset.
13419         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13420         (lookup_minimal_symbol): Update.
13421
13422 2019-03-15  Tom Tromey  <tom@tromey.com>
13423
13424         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13425         Don't return the symbol.
13426         * coffread.c (record_minimal_symbol): Use record_full.
13427
13428 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13429
13430         The MS-Windows port of ncurses fails to switch to a color pair if
13431         one or both of the colors are the implicit default colors.  This
13432         change records the default colors when TUI is initialized, and
13433         then specifies them explicitly when a color pair uses the default
13434         colors.  This allows color styling in TUI mode on MS-Windows.
13435
13436         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13437         ncurses_norm_attr.
13438         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13439         colors in ncurses_norm_attr.
13440         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13441         "none", replace it with the default color recorded in
13442         ncurses_norm_attr.
13443
13444 2019-03-14  Tom Tromey  <tromey@adacore.com>
13445
13446         * source-cache.h (class source_cache) <get_source_lines>: Return
13447         std::string.
13448         * source-cache.c (source_cache::extract_lines): Handle case where
13449         first_pos==npos.  Return std::string.
13450         (source_cache::get_source_lines): Update.
13451
13452 2019-03-14  Tom Tromey  <tromey@adacore.com>
13453
13454         * NEWS: Add item for "style sources" commands.
13455         * source-cache.c (source_cache::get_source_lines): Check
13456         source_styling.
13457         * cli/cli-style.c (source_styling): New global.
13458         (_initialize_cli_style): Add "style sources" commands.
13459         (show_style_sources): New function.
13460         * cli/cli-style.h (source_styling): Declare.
13461
13462 2019-03-14  Pedro Alves  <palves@redhat.com>
13463             Tom Tromey  <tromey@adacore.com>
13464
13465         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13466         * tui/tui-winsource.c (tui_refill_source_window): New function,
13467         from...
13468         (tui_horizontal_source_scroll): ... here.  Move some logic.
13469         * cli/cli-style.c (set_style_enabled): Notify new observable.
13470         * tui/tui-hooks.c (tui_redisplay_source): New function.
13471         (tui_attach_detach_observers): Attach or detach
13472         tui_redisplay_source.
13473         * observable.h (source_styling_changed): New observable.
13474         * observable.c: Define source_styling_changed observable.
13475
13476 2019-03-13  Tom Tromey  <tromey@adacore.com>
13477
13478         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13479         (i386_gnu_nat_target::store_registers): Update.
13480         * target-debug.h (target_debug_print_std_string): New macro.
13481         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13482         * windows-tdep.c (display_one_tib): Update.
13483         * tui/tui-stack.c (tui_make_status_line): Update.
13484         * top.c (print_inferior_quit_action): Update.
13485         * thread.c (thr_try_catch_cmd): Update.
13486         (add_thread_with_info): Update.
13487         (thread_target_id_str): Update.
13488         (thr_try_catch_cmd): Update.
13489         (thread_command): Update.
13490         (thread_find_command): Update.
13491         * record-btrace.c (record_btrace_target::info_record)
13492         (record_btrace_resume_thread, record_btrace_target::resume)
13493         (record_btrace_cancel_resume, record_btrace_step_thread)
13494         (record_btrace_target::wait, record_btrace_target::wait)
13495         (record_btrace_target::wait, record_btrace_target::stop): Update.
13496         * progspace.c (print_program_space): Update.
13497         * process-stratum-target.c
13498         (process_stratum_target::thread_address_space): Update.
13499         * linux-fork.c (linux_fork_mourn_inferior)
13500         (detach_checkpoint_command, info_checkpoints_command)
13501         (linux_fork_context): Update.
13502         (linux_fork_detach): Update.
13503         (class scoped_switch_fork_info): Update.
13504         (delete_checkpoint_command): Update.
13505         * infrun.c (follow_fork_inferior): Update.
13506         (follow_fork_inferior): Update.
13507         (proceed_after_vfork_done): Update.
13508         (handle_vfork_child_exec_or_exit): Update.
13509         (follow_exec): Update.
13510         (displaced_step_prepare_throw): Update.
13511         (displaced_step_restore): Update.
13512         (start_step_over): Update.
13513         (resume_1): Update.
13514         (clear_proceed_status_thread): Update.
13515         (proceed): Update.
13516         (print_target_wait_results): Update.
13517         (do_target_wait): Update.
13518         (context_switch): Update.
13519         (stop_all_threads): Update.
13520         (restart_threads): Update.
13521         (finish_step_over): Update.
13522         (handle_signal_stop): Update.
13523         (switch_back_to_stepped_thread): Update.
13524         (keep_going_pass_signal): Update.
13525         (print_exited_reason): Update.
13526         (normal_stop): Update.
13527         * inferior.c (inferior_pid_to_str): Change return type.
13528         (print_selected_inferior): Update.
13529         (add_inferior): Update.
13530         (detach_inferior): Update.
13531         * dummy-frame.c (fprint_dummy_frames): Update.
13532         * dcache.c (dcache_info_1): Update.
13533         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13534         (btrace_fetch, btrace_clear): Update.
13535         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13536         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13537         type.
13538         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13539         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13540         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13541         * gdbarch.c, gdbarch.h: Rebuild.
13542         * gdbarch.sh (core_pid_to_str): Change return type.
13543         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13544         return type.
13545         (windows_nat_target::pid_to_str): Change return type.
13546         (windows_delete_thread): Update.
13547         (windows_nat_target::attach): Update.
13548         (windows_nat_target::files_info): Update.
13549         * target-delegates.c: Rebuild.
13550         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13551         return type.
13552         (sol_thread_target::pid_to_str): Change return type.
13553         * remote.c (class remote_target) <pid_to_str>: Change return
13554         type.
13555         (remote_target::pid_to_str): Change return type.
13556         (extended_remote_target::attach, remote_target::remote_stop_ns)
13557         (remote_target::remote_notif_remove_queued_reply)
13558         (remote_target::push_stop_reply, remote_target::disable_btrace):
13559         Update.
13560         (extended_remote_target::attach): Update.
13561         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13562         type.
13563         (gdbsim_target::pid_to_str): Change return type.
13564         * ravenscar-thread.c (struct ravenscar_thread_target)
13565         <pid_to_str>: Change return type.
13566         (ravenscar_thread_target::pid_to_str): Change return type.
13567         * procfs.c (class procfs_target) <pid_to_str>: Change return
13568         type.
13569         (procfs_target::pid_to_str): Change return type.
13570         (procfs_target::attach): Update.
13571         (procfs_target::detach): Update.
13572         (procfs_target::fetch_registers): Update.
13573         (procfs_target::store_registers): Update.
13574         (procfs_target::wait): Update.
13575         (procfs_target::files_info): Update.
13576         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13577         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13578         return type.
13579         (nto_procfs_target::pid_to_str): Change return type.
13580         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13581         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13582         return type.
13583         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13584         (exit_lwp): Update.
13585         (attach_proc_task_lwp_callback, get_detach_signal)
13586         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13587         (linux_nat_target::resume, wait_lwp, stop_callback)
13588         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13589         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13590         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13591         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13592         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13593         type.
13594         (inf_ptrace_target::attach): Update.
13595         (inf_ptrace_target::files_info): Update.
13596         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13597         type.
13598         (go32_nat_target::pid_to_str): Change return type.
13599         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13600         (gnu_nat_target::wait): Update.
13601         (gnu_nat_target::wait): Update.
13602         (gnu_nat_target::resume): Update.
13603         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13604         (fbsd_nat_target::wait): Update.
13605         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13606         type.
13607         (darwin_nat_target::attach): Update.
13608         * corelow.c (class core_target) <pid_to_str>: Change return type.
13609         (core_target::pid_to_str): Change return type.
13610         * target.c (normal_pid_to_str): Change return type.
13611         (default_pid_to_str): Likewise.
13612         (target_pid_to_str): Change return type.
13613         (target_translate_tls_address): Update.
13614         (target_announce_detach): Update.
13615         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13616         return type.
13617         (bsd_uthread_target::pid_to_str): Change return type.
13618         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13619         type.
13620         (bsd_kvm_target::pid_to_str): Change return type.
13621         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13622         return type.
13623         (aix_thread_target::pid_to_str): Change return type.
13624         * target.h (struct target_ops) <pid_to_str>: Change return type.
13625         (target_pid_to_str, normal_pid_to_str): Likewise.
13626         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13627         type.
13628         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13629         type.
13630         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13631         return type.
13632         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13633         type.
13634         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13635         type.
13636         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13637         return type.
13638
13639 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13640
13641         * NEWS: Mention that the new default MI version is 3.  Mention
13642         changes to the output of commands and events that deal with
13643         multi-location breakpoints.
13644         * breakpoint.c: Include "mi/mi-out.h".
13645         (print_one_breakpoint): Change output syntax if using MI version
13646         >= 3.
13647         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13648         New.
13649         (mi_multi_location_breakpoint_output_fixed): New.
13650         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13651         (mi_cmd_fix_multi_location_breakpoint_output): New.
13652         (mi_multi_location_breakpoint_output_fixed): New.
13653         * mi/mi-cmds.c (mi_cmds): Register command
13654         -fix-multi-location-breakpoint-output.
13655         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13656         interpreter "mi".
13657
13658 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13659
13660         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13661         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13662         instantiate mi_ui_out based on interpreter name.
13663         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13664         * mi/mi-main.c (mi_load_progress): Likewise.
13665
13666 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13667
13668         * NEWS: Combine separate "New targets" sections for 8.3.
13669
13670 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13671
13672         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13673         (ppcfbsd_init_abi): Install gdbarch
13674         "fetch_tls_load_module_address" and "get_thread_local_address"
13675         methods.
13676
13677 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13678
13679         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13680         (riscv_fbsd_init_abi): Install gdbarch
13681         "fetch_tls_load_module_address" and "get_thread_local_address"
13682         methods.
13683
13684 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13685
13686         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13687         (i386fbsd_init_abi): Install gdbarch
13688         "fetch_tls_load_module_address" and "get_thread_local_address"
13689         methods.
13690
13691 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13692
13693         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13694         (amd64fbsd_init_abi): Install gdbarch
13695         "fetch_tls_load_module_address" and "get_thread_local_address"
13696         methods.
13697
13698 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13699
13700         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13701         (struct fbsd_pspace_data): New type.
13702         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13703         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13704         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13705         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13706         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13707
13708 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13709
13710         * gdbtypes.c (lookup_struct_elt): New function.
13711         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13712         * gdbtypes.h (struct struct_elt): New type.
13713         (lookup_struct_elt): New prototype.
13714
13715 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13716
13717         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13718         remove disabled code block.
13719
13720 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13721
13722         * gdbarch.sh (get_thread_local_address): New method.
13723         * gdbarch.h, gdbarch.c: Regenerate.
13724         * target.c (target_translate_tls_address): Use
13725         gdbarch_get_thread_local_address if present instead of
13726         target::get_thread_local_address.
13727
13728 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13729
13730         * target.h (target::get_thread_local_address): Update comment.
13731
13732 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13733
13734         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13735         objfile->separate_debug_objfile_backlink if not NULL.
13736
13737 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13738
13739         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13740         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13741         (amd64bsd_store_inferior_registers): Likewise.
13742         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13743         Enable segment base registers.
13744         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13745         PT_GETFSBASE and PT_GETGSBASE.
13746         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13747         PT_SETGSBASE.
13748         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13749         segment base registers.
13750         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13751
13752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13753
13754         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13755         Update calls to i386_target_description to add 'segments'
13756         parameter.
13757         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13758         add segment base registers.
13759         * arch/i386.c (i386_create_target_description): Add 'segments'
13760         parameter to enable segment base registers.
13761         * arch/i386.h (i386_create_target_description): Likewise.
13762         * features/i386/32bit-segments.xml: New file.
13763         * features/i386/32bit-segments.c: Generate.
13764         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13765         call to i386_target_description to add 'segments' parameter.
13766         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13767         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13768         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13769         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13770         if feature is present.
13771         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13772         Add 'segments' parameter to call to i386_target_description.
13773         (i386_target_description): Add 'segments' parameter to enable
13774         segment base registers.
13775         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13776         to call to i386_target_description.
13777         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13778         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13779         Define I386_NUM_REGS.
13780         (i386_target_description): Add 'segments' parameter to enable
13781         segment base registers.
13782
13783 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13784
13785         PR/24325
13786         * source-cache.c: #undef open and close, to avoid unresolved
13787         externals during linking.
13788
13789 2019-03-12  Tom Tromey  <tromey@adacore.com>
13790
13791         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13792         const.  Add initializers.
13793         (_initialize_remote): Don't initialize ptid globals.
13794
13795 2019-03-12  Pedro Alves  <palves@redhat.com>
13796
13797         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13798
13799 2019-03-12  Pedro Alves  <palves@redhat.com>
13800
13801         * cp-name-parser.y (main): Remove unused 'len' variable.
13802
13803 2019-03-12  Tom Tromey  <tromey@adacore.com>
13804
13805         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13806         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13807
13808 2019-03-12  Tom Tromey  <tromey@adacore.com>
13809
13810         * linux-nat.c (iterate_over_lwps): Update.
13811         (stop_callback): Remove parameter.
13812         (stop_wait_callback, detach_callback, resume_set_callback)
13813         (select_singlestep_lwp_callback, set_ignore_sigint)
13814         (status_callback, resumed_callback, resume_clear_callback)
13815         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13816         data parameter.
13817         (linux_nat_target::detach, linux_nat_target::resume)
13818         (linux_stop_and_wait_all_lwps, select_event_lwp)
13819         (linux_nat_filter_event, linux_nat_wait_1)
13820         (linux_nat_target::kill, linux_nat_target::stop)
13821         (linux_nat_target::stop): Update.
13822         (linux_nat_resume_callback): Change type.
13823         (resume_stopped_resumed_lwps, count_events_callback)
13824         (select_event_lwp_callback): Likewise.
13825         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13826         * arm-linux-nat.c (struct update_registers_data): Remove.
13827         (update_registers_callback): Change type.
13828         (arm_linux_insert_hw_breakpoint1): Update.
13829         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13830         parameter.
13831         (x86_linux_dr_set_addr): Update.
13832         (x86_linux_dr_set_control): Update.
13833         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13834         (iterate_over_lwps): Use gdb::function_view.
13835         * nat/aarch64-linux-hw-point.c (struct
13836         aarch64_dr_update_callback_param): Remove.
13837         (debug_reg_change_callback): Change type.
13838         (aarch64_notify_debug_reg_change): Update.
13839         * s390-linux-nat.c (s390_refresh_per_info): Update.
13840
13841 2019-03-11  Tom Tromey  <tromey@adacore.com>
13842
13843         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13844         redundant assignment to "this_cu".
13845
13846 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13847
13848         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13849
13850 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13851
13852         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13853         from...
13854         (rank_one_type): ... this.
13855
13856 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13857
13858         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13859         from...
13860         (rank_one_type): ... this.
13861
13862 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13863
13864         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13865         from...
13866         (rank_one_type): ... this.
13867
13868 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13869
13870         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13871         from...
13872         (rank_one_type): ... this.
13873
13874 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13875
13876         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13877         from...
13878         (rank_one_type): ... this.
13879
13880 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13881
13882         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13883         from...
13884         (rank_one_type): ... this.
13885
13886 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13887
13888         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13889         from...
13890         (rank_one_type): ... this.
13891
13892 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13893
13894         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13895         from...
13896         (rank_one_type): ... this.
13897
13898 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13899
13900         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13901         from...
13902         (rank_one_type): ... this.
13903
13904 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13905
13906         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13907         from...
13908         (rank_one_type): ... this.
13909
13910 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13911
13912         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13913         from...
13914         (rank_one_type): ... this.
13915
13916 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13917
13918         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13919         from...
13920         (rank_one_type): ... this.
13921
13922 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13923
13924         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13925         inferior-events' shows the example events.
13926
13927 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13928
13929         Support styling on native MS-Windows console
13930
13931         PR/24315
13932         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13933         on MS-Windows if $TERM is not defined.
13934
13935         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13936
13937         * posix-hdep.c (gdb_console_fputs):
13938         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13939         functions.
13940         * ui-file.h (gdb_console_fputs): Add prototype.
13941
13942         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13943         back to fputs only if the former returns zero.
13944
13945 2019-03-07  Tom Tromey  <tom@tromey.com>
13946
13947         * symmisc.c (print_symbol_bcache_statistics): Update.
13948         (print_objfile_statistics): Update.
13949         * symfile.c (allocate_symtab): Update.
13950         * stabsread.c: Don't include bcache.h.
13951         * psymtab.h (struct psymbol_bcache): Don't declare.
13952         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13953         (psymbol_bcache_init, psymbol_bcache_free)
13954         (psymbol_bcache_get_bcache): Don't declare.
13955         * psymtab.c (struct psymbol_bcache): Remove.
13956         (psymtab_storage::psymtab_storage): Update.
13957         (psymtab_storage::~psymtab_storage): Update.
13958         (psymbol_bcache_init, psymbol_bcache_free)
13959         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13960         (add_psymbol_to_bcache): Update.
13961         (allocate_psymtab): Update.
13962         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13963         macro_cache>: No longer pointers.
13964         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13965         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13966         * macrotab.c (macro_bcache): Update.
13967         * macroexp.c: Don't include bcache.h.
13968         * gdbtypes.c (check_types_worklist): Update.
13969         (types_deeply_equal): Remove TRY/CATCH.  Update.
13970         * elfread.c (elf_symtab_read): Update.
13971         * dwarf2read.c: Don't include bcache.h.
13972         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13973         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13974         (print_bcache_statistics, bcache_memory_used): Don't declare.
13975         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13976         methods.  Rename all data members.
13977         * bcache.c (struct bcache): Move to bcache.h.
13978         (bcache::expand_hash_table): Rename from expand_hash_table.
13979         (bcache): Remove.
13980         (bcache::insert): Rename from bcache_full.
13981         (bcache::compare): Rename from bcache_compare.
13982         (bcache_xmalloc): Remove.
13983         (bcache::~bcache): Rename from bcache_xfree.
13984         (bcache::print_statistics): Rename from print_bcache_statistics.
13985         (bcache::memory_used): Rename from bcache_memory_used.
13986
13987 2019-03-07  Pedro Alves  <palves@redhat.com>
13988
13989         * infrun.c (normal_stop): Also check for
13990         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13991
13992 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13993
13994         * f-lang.c (value_from_host_double): Moved to...
13995         * value.c (value_from_host_double): ...here.
13996         * value.h (value_from_host_double): Declare.
13997         * guile/scm-math.c (vlscm_convert_typed_number): Use
13998         value_from_host_double.
13999         (vlscm_convert_number): Likewise.
14000         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14001         * python/py-value.c (convert_value_from_python): Likewise.
14002
14003 2019-03-06  Tom Tromey  <tom@tromey.com>
14004
14005         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14006
14007 2019-03-06  Tom Tromey  <tom@tromey.com>
14008
14009         * utils.h (free_current_contents): Don't declare.
14010         * utils.c (free_current_contents): Remove.
14011
14012 2019-03-06  Tom Tromey  <tom@tromey.com>
14013
14014         * top.c (quit_force): Update.
14015         * main.c (captured_command_loop): Update.
14016         * common/new-op.c (operator new): Update.
14017         * common/common-exceptions.c (struct catcher)
14018         <save_cleanup_chain>: Remove member.
14019         (exceptions_state_mc_init): Update.
14020         (exception_try_scope_entry): Return nullptr.
14021         (exception_try_scope_exit, exception_rethrow)
14022         (throw_exception_sjlj, throw_exception_cxx): Update.
14023         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14024         (all_cleanups, do_cleanups, discard_cleanups)
14025         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14026         (restore_cleanups, restore_final_cleanups): Don't declare.
14027         (do_final_cleanups): Remove parameter.
14028         * common/cleanups.c (cleanup_chain, make_cleanup)
14029         (make_cleanup_dtor, all_cleanups, do_cleanups)
14030         (discard_my_cleanups, discard_cleanups)
14031         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14032         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14033         (null_cleanup): Remove.
14034         (do_final_cleanups): Remove parameter.
14035
14036 2019-03-06  Tom Tromey  <tom@tromey.com>
14037
14038         * remote.c (remote_target::remote_parse_stop_reply): Use
14039         unique_xmalloc_ptr.
14040
14041 2019-03-06  Tom Tromey  <tom@tromey.com>
14042
14043         * stabsread.c (struct stabs_field_info): Rename from field_info.
14044         <list, fnlist>: Add initializers.
14045         <obstack>: New member.
14046         (read_member_functions, read_struct_fields, read_baseclasses):
14047         Allocate on obstack.  Don't use cleanups.
14048         (read_one_struct_field, read_member_functions, read_struct_fields)
14049         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14050         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14051         (read_struct_type): Update.
14052
14053 2019-03-06  Tom Tromey  <tom@tromey.com>
14054
14055         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14056         * common/filestuff.h (make_cleanup_close): Don't declare.
14057         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14058         Remove.
14059
14060 2019-03-06  Tom Tromey  <tom@tromey.com>
14061
14062         * solib-aix.c: Use make_scope_exit.
14063
14064 2019-03-06  Tom Tromey  <tom@tromey.com>
14065
14066         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14067         Use make_scope_exit.
14068
14069 2019-03-06  Tom Tromey  <tom@tromey.com>
14070
14071         * solib-svr4.c (disable_probes_interface): Remove parameter.
14072         (svr4_handle_solib_event): Use make_scope_exit.
14073
14074 2019-03-06  Tom Tromey  <tom@tromey.com>
14075
14076         * remote.c (struct stop_reply_deleter): Remove.
14077         (stop_reply_up): Update.
14078         (struct stop_reply): Derive from notif_event.  Don't typedef.
14079         <regcache>: Now a std::vector.
14080         (stop_reply_xfree): Remove.
14081         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14082         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14083         (remote_target::discard_pending_stop_replies): Use delete.
14084         (remote_target::remote_parse_stop_reply): Update.
14085         (remote_target::process_stop_reply): Update.
14086         * remote-notif.h (struct notif_event): Add virtual destructor.
14087         Remove "dtr" member.
14088         (struct notif_client) <alloc_event>: Return a unique_ptr.
14089         (notif_event_xfree): Don't declare.
14090         (notif_event_up): New typedef.
14091         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14092         (notif_event_xfree, do_notif_event_xfree): Remove.
14093         (remote_notif_state_xfree): Update.
14094
14095 2019-03-06  Tom Tromey  <tom@tromey.com>
14096
14097         * infrun.c (displaced_step_clear_cleanup): Now a
14098         forward_scope_exit type.
14099         (displaced_step_prepare_throw): Update.
14100         (displaced_step_fixup): Update.
14101
14102 2019-03-06  Tom Tromey  <tom@tromey.com>
14103
14104         * inferior.h (class inferior): Update comment.
14105         * gdbthread.h (class thread_info): Update comment.
14106
14107 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14108             Tom Tromey  <tom@tromey.com>
14109
14110         * stabsread.h (struct stab_section_list): Remove.
14111         (coffstab_build_psymtabs): Update.
14112         * dbxread.c (symbuf_sections): Now a std::vector.
14113         (sect_idx): New global.
14114         (fill_symbuf): Update.
14115         (coffstab_build_psymtabs): Change type of stabsects parameter.
14116         Update.
14117         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14118         std::vector.
14119         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14120         (coff_locate_sections): Update.
14121         (coff_symfile_read): Remove cleanups.  Update.
14122         (init_stringtab): Add storage parameter.
14123         (free_stringtab, free_stringtab_cleanup): Remove.
14124         (init_lineno): Add storage parameter.
14125         (free_linetab, free_linetab_cleanup): Remove.
14126
14127 2019-03-06  Pedro Alves  <palves@redhat.com>
14128
14129         * linux-fork.c (fork_info::clobber_regs): Delete.
14130         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14131         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14132         comment.  Adjust.
14133         (scoped_switch_fork_info::scoped_switch_fork_info)
14134         (checkpoint_command, linux_fork_context): Adjust
14135         fork_save_infrun_state calls.
14136
14137 2019-03-06  Pedro Alves  <palves@redhat.com>
14138
14139         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14140         (inf_has_multiple_threads): Return 'bool' and rewrite using
14141         inferior_info::threads().
14142
14143 2019-03-06  Pedro Alves  <palves@redhat.com>
14144
14145         * linux-fork.c: Include <list>.
14146         (fork_list): Now a std::list instance.
14147         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14148         (forks_exist_p, find_last_fork): Adjust.
14149         (new_fork): Delete.
14150         (one_fork_p): New.
14151         (add_fork): Adjust.
14152         (free_fork): Delete, folded into fork_info::~fork_info().
14153         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14154         Adjust.
14155         (init_fork_list): Delete.
14156         (linux_fork_killall, linux_fork_mourn_inferior)
14157         (linux_fork_detach, info_checkpoints_command): Adjust.
14158         (_initialize_linux_fork): No longer call init_fork_list.
14159
14160 2019-03-06  Pedro Alves  <palves@redhat.com>
14161
14162         * linux-fork.c (new_fork): New, split out of ...
14163         (add_fork): ... this.  Return void.  Move "first fork" special
14164         case from here, to ...
14165         (checkpoint_command): ... here.
14166         * linux-linux.h (add_fork): Return void.
14167
14168 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14169
14170         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14171
14172 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14173             Chris January  <chris.january@arm.com>
14174             David Lecomber  <david.lecomber@arm.com>
14175
14176         * f-exp.y: New token, UNOP_INTRINSIC.
14177         (exp): New pattern using UNOP_INTRINSIC token.
14178         (f77_keywords): Add 'abs' keyword.
14179         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14180         (value_from_host_double): New function.
14181         (evaluate_subexp_f): Support UNOP_ABS.
14182
14183 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14184
14185         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14186         types.
14187
14188 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14189
14190         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14191         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14192         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14193
14194 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14195
14196         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14197
14198 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14199             Chris January  <chris.january@arm.com>
14200
14201         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14202         * f-exp.y: Define 'KIND' token.
14203         (exp): New pattern for KIND expressions.
14204         (ptype): Handle types with a kind extension.
14205         (direct_abs_decl): Extend to spot kind extensions.
14206         (f77_keywords): Add 'kind' to the list.
14207         (push_kind_type): New function.
14208         (convert_to_kind_type): New function.
14209         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14210         * parse.c (operator_length_standard): Likewise.
14211         * parser-defs.h (enum type_pieces): Add tp_kind.
14212         * std-operator.def: Add UNOP_KIND.
14213
14214 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14215
14216         * f-exp.y (f_parse): Set yydebug.
14217
14218 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14219
14220         * f-lang.c (evaluate_subexp_f): New function.
14221         (exp_descriptor_f): New global.
14222         (f_language_defn): Use exp_descriptor_f instead of
14223         exp_descriptor_standard.
14224
14225 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14226
14227         * f-exp.y (struct token): Add comments.
14228         (dot_ops): Remove uppercase versions and the end marker.
14229         (f77_keywords): Likewise.
14230         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14231         entries in the dot_ops array are case insensitive, and use
14232         strncasecmp to compare strings.  Also some whitespace cleanup in
14233         this area.  Similar for the f77_keywords array, except entries in
14234         this list might be case sensitive.
14235
14236 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14237
14238         * f-exp.y (struct f77_boolean_val): Add comments.
14239         (boolean_values): Remove uppercase versions, and end marker.
14240         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14241         and use strncasecmp to achieve case insensitivity.  Additionally,
14242         perform whitespace cleanup around this code.
14243
14244 2019-03-06  Tom Tromey  <tromey@adacore.com>
14245
14246         * remote-sim.c (gdbsim_target_open): Use result of
14247         gdb_argv::release.
14248
14249 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14250         Dirk Schubert  <dirk.schubert@arm.com>
14251         Chris January  <chris.january@arm.com>
14252
14253         * eval.c (evaluate_subexp_standard): Call Fortran argument
14254         wrapping logic.
14255         * f-lang.c (struct value): A value which can be passed into a
14256         Fortran function call.
14257         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14258         where appropriate.
14259         (struct type): Value ready for a Fortran function call.
14260         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14261         is needed.
14262         * f-lang.h (fortran_argument_convert): Declaration.
14263         (fortran_preserve_arg_pointer): Declaration.
14264         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14265
14266 2019-03-05  Tom Tromey  <tromey@adacore.com>
14267
14268         * python/py-prettyprint.c (print_string_repr): Remove #if.
14269         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14270
14271 2019-03-05  Tom Tromey  <tromey@adacore.com>
14272
14273         * target.c (the_dummy_target): Move later.  Change type to
14274         "dummy_target".
14275         (initialize_targets): Don't initialize the_dummy_target.
14276
14277 2019-03-05  Tom Tromey  <tromey@adacore.com>
14278
14279         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14280         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14281
14282 2019-03-05  Tom Tromey  <tromey@adacore.com>
14283
14284         * windows-nat.c (windows_nat_target::attach)
14285         (windows_nat_target::detach): Don't call gdb_flush.
14286         * valprint.c (generic_val_print, val_print, val_print_string):
14287         Don't call gdb_flush.
14288         * utils.c (defaulted_query): Don't call gdb_flush.
14289         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14290         * target.c (target_announce_detach): Don't call gdb_flush.
14291         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14292         * remote.c (extended_remote_target::attach): Don't call
14293         gdb_flush.
14294         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14295         * printcmd.c (do_examine): Don't call gdb_flush.
14296         (info_display_command): Don't call gdb_flush.
14297         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14298         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14299         * memattr.c (info_mem_command): Don't call gdb_flush.
14300         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14301         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14302         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14303         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14304         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14305         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14306         (gnu_nat_target::detach): Don't call gdb_flush.
14307         * f-valprint.c (f_val_print): Don't call gdb_flush.
14308         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14309         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14310         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14311         gdb_flush.
14312         * c-valprint.c (c_val_print): Don't call gdb_flush.
14313         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14314
14315 2019-03-05  Tom Tromey  <tromey@adacore.com>
14316
14317         * varobj.c (update_dynamic_varobj_children): Update.
14318         (install_default_visualizer): Use reset, not release.
14319         * value.c (set_internalvar): Update.
14320         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14321         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14322         ATTRIBUTE_UNUSED_RESULT.
14323
14324 2019-03-05  Tom Tromey  <tromey@adacore.com>
14325
14326         * remote.c (class scoped_remote_fd) <release>: Add
14327         ATTRIBUTE_UNUSED_RESULT.
14328
14329 2019-03-05  Tom Tromey  <tromey@adacore.com>
14330
14331         * macroexp.c (struct macro_buffer) <release>: Add
14332         ATTRIBUTE_UNUSED_RESULT.
14333
14334 2019-03-05  Tom Tromey  <tromey@adacore.com>
14335
14336         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14337         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14338         ATTRIBUTE_UNUSED_RESULT.
14339
14340 2019-03-05  Tom Tromey  <tromey@adacore.com>
14341
14342         * common/scoped_fd.h (class scoped_fd) <release>: Add
14343         ATTRIBUTE_UNUSED_RESULT.
14344
14345 2019-03-05  Tom Tromey  <tromey@adacore.com>
14346
14347         * parser-defs.h (struct parser_state) <release>: Add
14348         ATTRIBUTE_UNUSED_RESULT.
14349
14350 2019-03-05  Tom Tromey  <tromey@adacore.com>
14351
14352         * utils.h (class gdb_argv) <release>: Add
14353         ATTRIBUTE_UNUSED_RESULT.
14354         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14355
14356 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14357
14358         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14359         for-loop range, to avoid compiler warnings.
14360
14361         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14362         avoid compiler warnings about unused variables.
14363
14364         * NEWS: Mention end of support for native debugging on MS-Windows
14365         before XP.
14366
14367         PR gdb/24292
14368         * common/netstuff.c:
14369         * gdbserver/gdbreplay.c
14370         * gdbserver/remote-utils.c:
14371         * ser-tcp.c:
14372         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14373         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14374         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14375         'getaddrinfo' and 'freeaddrinfo' were not available before
14376         Windows XP, and mingw.org's MinGW headers by default define
14377         _WIN32_WINNT to 0x500.
14378
14379 2019-03-01  Gary Benson <gbenson@redhat.com>
14380
14381         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14382
14383 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14384             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14385
14386         PR gdb/8527
14387         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14388         set_sigint_trap, clear_sigint_trap.
14389
14390 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14391
14392         * target.c (target_detach): Clear the regcache and the
14393         frame cache.
14394
14395 2019-02-27  Pedro Alves  <palves@redhat.com>
14396
14397         * utils.c (set_screen_size): When we cap the height/width sizes,
14398         tweak the corresponding command variable to show "unlimited":
14399
14400 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14401             Pedro Alves  <palves@redhat.com>
14402
14403         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14404         before calling rl_set_screen_size.
14405
14406 2019-02-27  Tom Tromey  <tromey@adacore.com>
14407
14408         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14409         define.
14410         * python/py-value.c: Remove Python 2.4 workaround.
14411         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14412         workaround.
14413         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14414         Python 2.4 workaround.
14415         * python/python-internal.h: Remove Python 2.4 comment.
14416         (Py_ssize_t): Don't define.
14417         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14418         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14419         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14420         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14421         * python/python.c (do_start_initialization): Remove Python 2.4
14422         workaround.
14423         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14424         (print_children): Remove Python 2.4 workaround.
14425         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14426         workaround.
14427         (CHARBUFFERPROC_NAME): Remove.
14428         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14429         Python 2.4 workaround.
14430
14431 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14432
14433         * NEWS: Note minimum Python version.
14434
14435 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14436
14437         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14438         code from these functions.  Remove corresponding ifdefs.  Use
14439         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14440         Remove gotos and target of gotos.
14441         (infpy_search_memory): Likewise.
14442
14443 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14444
14445         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14446         (hppa_gdbarch_init): Don't register deleted functions with
14447         gdbarch.
14448
14449 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14450
14451         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14452         (h8300_unwind_sp): Delete.
14453         (h8300_dummy_id): Delete.
14454         (h8300_gdbarch_init): Don't register deleted functions with
14455         gdbarch.
14456
14457 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14458
14459         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14460         (ft32_unwind_pc): Delete.
14461         (ft32_unwind_sp): Delete.
14462         (ft32_gdbarch_init): Don't register deleted functions with
14463         gdbarch.
14464
14465 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14466
14467         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14468         (frv_unwind_pc): Delete.
14469         (frv_unwind_sp): Delete.
14470         (frv_gdbarch_init): Don't register deleted functions with
14471         gdbarch.
14472
14473 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14474
14475         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14476         (riscv_unwind_pc): Delete.
14477         (riscv_unwind_sp): Delete.
14478         (riscv_gdbarch_init): Don't register deleted functions with
14479         gdbarch.
14480
14481 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14482
14483         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14484         (csky_unwind_pc): Delete.
14485         (csky_unwind_sp): Delete.
14486         (csky_gdbarch_init): Don't register deleted functions with
14487         gdbarch.
14488
14489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14490
14491         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14492         (cris_unwind_pc): Delete.
14493         (cris_unwind_sp): Delete.
14494         (cris_gdbarch_init): Don't register deleted functions with
14495         gdbarch.
14496
14497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14498
14499         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14500         (bfin_unwind_pc): Delete.
14501         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14502
14503 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14504
14505         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14506         (arm_unwind_pc): Delete.
14507         (arm_unwind_sp): Delete.
14508         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14509
14510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14511
14512         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14513         (arc_unwind_pc): Delete.
14514         (arc_unwind_sp): Delete.
14515         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14516
14517 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14518
14519         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14520         (alpha_unwind_pc): Delete.
14521         (alpha_gdbarch_init): Don't register deleted functions with
14522         gdbarch.
14523
14524 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14525
14526         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14527         (aarch64_unwind_pc): Delete.
14528         (aarch64_unwind_sp): Delete.
14529         (aarch64_gdbarch_init): Don't register deleted functions with
14530         gdbarch.
14531
14532 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14533
14534         * gdbtypes.c (type_align): Don't consider static members when
14535         computing structure alignment.
14536
14537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14538
14539         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14540         return 0 for other types.
14541         * arch-utils.c (default_type_align): Always return 0.
14542         * gdbarch.h: Regenerate.
14543         * gdbarch.sh (type_align): Extend comment.
14544         * gdbtypes.c (type_align): Add additional comments, always call
14545         gdbarch_type_align before applying the default rules.
14546         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14547         generic code will then apply a suitable default.
14548         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14549         types, return 0 for other types.
14550
14551 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14552
14553         * NEWS: Create a new section for the next release branch.
14554         Rename the section of the current branch, now that it has
14555         been cut.
14556
14557 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14558
14559         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14560         * version.in: Bump version to 8.3.50.DATE-git.
14561
14562 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14563
14564         * aix-thread.c (ptid_cmp): Remove unused variable.
14565         (get_signaled_thread): Likewise.
14566         (store_regs_user_thread): Likewise.
14567         (store_regs_kernel_thread): Likewise.
14568         (fetch_regs_kernel_thread): Remove shadowed variable.
14569
14570 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14571
14572         * features/riscv/32bit-cpu.xml: Add register numbers.
14573         * features/riscv/32bit-fpu.c: Regenerate.
14574         * features/riscv/32bit-fpu.xml: Add register numbers.
14575         * features/riscv/64bit-cpu.xml: Add register numbers.
14576         * features/riscv/64bit-fpu.c: Regenerate.
14577         * features/riscv/64bit-fpu.xml: Add register numbers.
14578
14579 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14580
14581         * NEWS: Mention two argument form of gdb.Value constructor.
14582         * python/py-value.c (convert_buffer_and_type_to_value): New
14583         function.
14584         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14585         Add support for handling an optional second argument.  Call
14586         convert_buffer_and_type_to_value as appropriate.
14587         * python/python-internal.h (Py_buffer_deleter): New struct.
14588         (Py_buffer_up): New typedef.
14589
14590 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14591
14592         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14593         instead of releasing ownership.
14594
14595 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14596
14597         * dwarf2read.c (open_and_init_dwp_file): Call
14598         elf_numsections instead of bfd_count_sections to initialize
14599         dwp_file->num_sections.
14600
14601 2019-02-25  Tom Tromey  <tromey@adacore.com>
14602
14603         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14604
14605 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14606
14607         * gcore.in: Add '--readnever' option when invoking GDB.
14608
14609 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14610
14611         * MAINTAINERS: Update my email address.
14612
14613 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14614
14615         * build-id.c (build_id_to_debug_bfd_1): New function.
14616         (build_id_to_debug_bfd): Look for separate debug file in
14617         sysroot.
14618
14619 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14620
14621         * gdbarch.sh: Update the copyright year range that is placed into
14622         generated files.
14623
14624 2019-02-22  Keith Seitz  <keiths@redhat.com>
14625
14626         PR symtab/23853
14627         * linespec.c (create_sals_line_offset): Search for the default
14628         symtab's filename instead of its fullname.
14629
14630 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14631
14632         * NEWS: Update style defaults.
14633
14634 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14635
14636         * main.c (captured_main_1): Disable styling in batch mode.
14637
14638 2019-02-20  Tom Tromey  <tom@tromey.com>
14639
14640         * symtab.c (symtab_symbol_info): Fix typos.
14641
14642 2019-02-20  Tom Tromey  <tromey@adacore.com>
14643
14644         * findcmd.c (_initialize_mem_search): Use upper case for
14645         metasyntactic variables.
14646
14647 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14648
14649         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14650         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14651
14652 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14653
14654         * top.h (source_file_name): Change to std::string.
14655         * top.c (source_file_name): Likewise.
14656         (command_line_input): Adjust.
14657         * cli/cli-script.c (script_from_file): Adjust.
14658
14659 2019-02-19  Tom Tromey  <tromey@adacore.com>
14660
14661         * ravenscar-thread.c
14662         (ravenscar_thread_target::update_thread_list): Don't call
14663         ada_build_task_list.
14664         * ada-lang.h (ada_build_task_list): Don't declare.
14665         * ada-tasks.c (struct ada_tasks_inferior_data)
14666         <task_list_valid_p>: Now bool.
14667         (read_known_tasks, ada_task_list_changed)
14668         (ada_tasks_invalidate_inferior_data): Update.
14669         (read_known_tasks_array): Return bool.
14670         (read_known_tasks_list): Likewise.
14671         (read_known_tasks): Return void.
14672         (ada_build_task_list): Now static.
14673
14674 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14675
14676         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14677         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14678
14679 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14680
14681         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14682         variant for ada_tasks_pspace_data_handle and
14683         ada_tasks_inferior_data_handle.
14684         (ada_tasks_pspace_data_cleanup): New function.
14685         (ada_tasks_inferior_data_cleanup): New function.
14686
14687 2019-02-17  Tom Tromey  <tom@tromey.com>
14688
14689         * macrotab.h (macro_source_fullname): Return a std::string.
14690         * macrotab.c (macro_include, check_for_redefinition)
14691         (macro_undef, macro_lookup_definition, foreach_macro)
14692         (foreach_macro_in_scope): Update.
14693         (macro_source_fullname): Return a std::string.
14694         * macrocmd.c (show_pp_source_pos): Update.
14695
14696 2019-02-17  Tom Tromey  <tom@tromey.com>
14697
14698         * macrocmd.c (show_pp_source_pos): Style the file names.
14699
14700 2019-02-17  Tom Tromey  <tom@tromey.com>
14701
14702         PR tui/24197:
14703         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14704
14705 2019-02-17  Tom Tromey  <tom@tromey.com>
14706
14707         * ada-lang.c (user_select_syms): Use filtered printing.
14708         * utils.c (wrap_style): New global.
14709         (desired_style): Remove.
14710         (emit_style_escape): Add stream parameter.
14711         (set_output_style, reset_terminal_style, prompt_for_continue):
14712         Update.
14713         (flush_wrap_buffer): Only flush gdb_stdout.
14714         (wrap_here): Set wrap_style.
14715         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14716         treat escape sequences as a character.  Change when wrap buffer is
14717         flushed.
14718         (fputs_styled): Do not set the output style when the default is
14719         requested.
14720         * ui-style.h (struct ui_file_style) <is_default>: New method.
14721         * source.c (print_source_lines_base): Emit escape sequences in one
14722         piece.
14723
14724 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14725
14726         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14727         integers and enumeration types.
14728
14729 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14730
14731         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14732         instead of lookup_symbol_in_language
14733         (do_exact_match): New function.
14734         (ada_get_symbol_name_matcher): Return do_exact_match when
14735         doing a verbatim match.
14736
14737 2019-02-15  Tom Tromey  <tromey@adacore.com>
14738
14739         * ravenscar-thread.c (ravenscar_thread_target::resume)
14740         (ravenscar_thread_target::wait): Special case wildcard requests.
14741
14742 2019-02-15  Tom Tromey  <tromey@adacore.com>
14743
14744         * ravenscar-thread.c (base_ptid): Remove.
14745         (struct ravenscar_thread_target) <close>: New method.
14746         <m_base_ptid>: New member.
14747         <update_inferior_ptid, active_task, task_is_currently_active,
14748         runtime_initialized>: Declare methods.
14749         <ravenscar_thread_target>: Add constructor.
14750         (ravenscar_thread_target::task_is_currently_active)
14751         (ravenscar_thread_target::update_inferior_ptid)
14752         (ravenscar_runtime_initialized): Rename.  Now methods.
14753         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14754         (ravenscar_thread_target::update_thread_list): Update.
14755         (ravenscar_thread_target::active_task): Now method.
14756         (ravenscar_thread_target::store_registers)
14757         (ravenscar_thread_target::prepare_to_store)
14758         (ravenscar_thread_target::prepare_to_store)
14759         (ravenscar_thread_target::mourn_inferior): Update.
14760         (ravenscar_inferior_created): Use "new" to create target.
14761         (ravenscar_thread_target::get_ada_task_ptid): Update.
14762         (_initialize_ravenscar): Don't initialize base_ptid.
14763         (ravenscar_ops): Remove global.
14764
14765 2019-02-15  Tom Tromey  <tromey@adacore.com>
14766
14767         * target.h (push_target): Declare new overload.
14768         * target.c (push_target): New overload, taking an rvalue reference.
14769         * remote.c (remote_target::open_1): Use push_target overload.
14770         * corelow.c (core_target_open): Use push_target overload.
14771
14772 2019-02-15  Tom Tromey  <tromey@adacore.com>
14773
14774         * ravenscar-thread.c (is_ravenscar_task)
14775         (ravenscar_task_is_currently_active): Return bool.
14776         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14777         (_initialize_ravenscar): Remove "(void)".
14778         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14779         Return bool.
14780
14781 2019-02-15  Tom Tromey  <tromey@adacore.com>
14782
14783         * ravenscar-thread.c (ravenscar_runtime_initializer)
14784         (has_ravenscar_runtime, get_running_thread_id)
14785         (ravenscar_thread_target::resume): Fix indentation.
14786
14787 2019-02-15  Tom Tromey  <tromey@adacore.com>
14788
14789         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14790         from ravenscar_arch_ops.
14791         (sparc_ravenscar_ops::fetch_registers)
14792         (sparc_ravenscar_ops::store_registers): Now methods.
14793         (sparc_ravenscar_prepare_to_store): Remove.
14794         (sparc_ravenscar_ops): Redefine.
14795         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14796         methods and destructor.  Remove members.
14797         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14798         (ravenscar_thread_target::store_registers)
14799         (ravenscar_thread_target::prepare_to_store): Update.
14800         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14801         Remove.
14802         (struct ppc_ravenscar_powerpc_ops): Derive from
14803         ravenscar_arch_ops.
14804         (ppc_ravenscar_powerpc_ops::fetch_registers)
14805         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14806         (ppc_ravenscar_powerpc_ops): Redefine.
14807         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14808         (ppc_ravenscar_e500_ops::fetch_registers)
14809         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14810         (ppc_ravenscar_e500_ops): Redefine.
14811         * aarch64-ravenscar-thread.c
14812         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14813         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14814         (aarch64_ravenscar_fetch_registers)
14815         (aarch64_ravenscar_store_registers): Now methods.
14816         (aarch64_ravenscar_ops): Redefine.
14817
14818 2019-02-15  Tom Tromey  <tromey@adacore.com>
14819
14820         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14821         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14822         (ravenscar_thread_target::stopped_by_watchpoint)
14823         (ravenscar_thread_target::stopped_data_address)
14824         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14825
14826 2019-02-15  Tom Tromey  <tromey@adacore.com>
14827
14828         * ravenscar-thread.c: Fix some typos.
14829
14830 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14831             Tom Tromey  <tromey@adacore.com>
14832
14833         * ada-lang.c (ada_exception_sal): Change addr_string to a
14834         std::string.
14835         (create_ada_exception_catchpoint): Update.
14836
14837 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14838             Tom Tromey  <tromey@adacore.com>
14839
14840         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14841         (bp_location_ops): Remove.
14842         (base_breakpoint_allocate_location): Update.
14843         (free_bp_location): Update.
14844         * ada-lang.c (class ada_catchpoint_location)
14845         <ada_catchpoint_location>: Remove ops parameter.
14846         (ada_catchpoint_location_dtor): Remove.
14847         (ada_catchpoint_location_ops): Remove.
14848         (allocate_location_exception): Update.
14849         * breakpoint.h (struct bp_location_ops): Remove.
14850         (class bp_location) <bp_location>: Remove bp_location_ops
14851         parameter.
14852         <~bp_location>: Add destructor.
14853         <ops>: Remove.
14854
14855 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14856             Pedro Alves  <palves@redhat.com>
14857
14858         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14859         'PATH_MAX'.
14860
14861 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14862             Samuel Thibault  <samuel.thibault@gnu.org>
14863             Thomas Schwinge  <thomas@codesourcery.com>
14864
14865         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14866         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14867
14868 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14869
14870         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14871         (check_empty): Use "const char *".
14872
14873         * gnu-nat.c (gnu_nat_target::detach): Instead of
14874         'detach_inferior (pid)' call
14875         'detach_inferior (find_inferior_pid (pid))'.
14876
14877         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14878         'nat/fork-inferior.o'.
14879         * gnu-nat.c: #include "nat/fork-inferior.h".
14880
14881         * gnu-nat.c (gnu_nat_target::detach): Instead of
14882         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14883         * gnu-nat.h: #include "inf-child.h".
14884         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14885         'i386_gnu_nat_target::fetch_registers'.
14886         (gnu_store_registers): Rename/move to
14887         'i386_gnu_nat_target::store_registers'.
14888
14889         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14890         * gnu-nat.h (mach_thread_info): New function.
14891         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14892
14893         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14894
14895 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14896
14897         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14898
14899 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14900
14901         * windows-nat.c (windows_add_thread): Add new parameter
14902         "main_thread_p" with default value set to false.  Update
14903         function documentation as well as all callers.
14904         (windows_delete_thread): Likewise.
14905         (fake_create_process): Update call to windows_add_thread.
14906         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14907         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14908         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14909         call to windows_delete_thread.
14910
14911 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14912
14913         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14914
14915 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14916
14917         * symfile.c (find_separate_debug_file): Use canonical path of
14918         sysroot with child_path instead of gdb_sysroot if it is valid.
14919
14920 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14921
14922         * symfile.c (find_separate_debug_file): Use child_path to
14923         determine if an object file is under a sysroot.
14924
14925 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14926
14927         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14928         unittests/child-path-selftests.c.
14929         * common/pathstuff.c (child_path): New function.
14930         * common/pathstuff.h (child_path): New prototype.
14931         * unittests/child-path-selftests.c: New file.
14932
14933 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14934
14935         * symfile.c (find_separate_debug_file): Look for separate debug
14936         files in debug directories under the sysroot.
14937
14938 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14939
14940         * symtab.h (struct minimal_symbol data_p): New const method.
14941         (struct minimal_symbol text_p): Likewise.
14942         * symtab.c (output_source_filename): Use file name style
14943         to print file name.
14944         (print_symbol_info): Likewise.
14945         (print_msymbol_info): Use address style to print addresses.
14946         Use function name style to print executable text symbols.
14947         (expand_symtab_containing_pc): Use data_p.
14948         (find_pc_sect_compunit_symtab): Likewise.
14949
14950 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14951
14952         * breakpoint.c (describe_other_breakpoints): Use address style
14953         to print addresses.
14954         (say_where): Likewise.
14955
14956 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14957
14958         * ada-typeprint.c (print_func_type): Print function name
14959         style to print function name.
14960         * c-typeprint.c (c_print_type_1): Likewise.
14961
14962 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14963
14964         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14965         for execve.
14966
14967 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14968
14969         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14970         type_stack.
14971
14972 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14973
14974         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14975         TYPE_CODE_REF types.
14976
14977 2019-02-08  Jim Wilson  <jimw@sifive.com>
14978
14979         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14980         (riscv_linux_fregset): New.
14981         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14982
14983 2019-02-07  Tom Tromey  <tom@tromey.com>
14984
14985         * thread.c (thread_cancel_execution_command): Update.
14986         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14987         methods.
14988         (struct thread_fsm_ops): Remove.
14989         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14990         (thread_fsm_should_stop, thread_fsm_return_value)
14991         (thread_fsm_set_finished, thread_fsm_finished_p)
14992         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14993         Don't declare.
14994         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14995         * infrun.c (clear_proceed_status_thread)
14996         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14997         (print_stop_event): Update.
14998         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14999         Add constructor.
15000         (step_command_fsm_ops): Remove.
15001         (new_step_command_fsm): Remove.
15002         (step_1): Update.
15003         (step_command_fsm::should_stop): Rename from
15004         step_command_fsm_should_stop.
15005         (step_command_fsm::clean_up): Rename from
15006         step_command_fsm_clean_up.
15007         (step_command_fsm::do_async_reply_reason): Rename from
15008         step_command_fsm_async_reply_reason.
15009         (struct until_next_fsm): Inherit from thread_fsm.  Add
15010         constructor.
15011         (until_next_fsm_ops): Remove.
15012         (new_until_next_fsm): Remove.
15013         (until_next_fsm::should_stop): Rename from
15014         until_next_fsm_should_stop.
15015         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15016         (until_next_fsm::do_async_reply_reason): Rename from
15017         until_next_fsm_async_reply_reason.
15018         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15019         constructor.  Change type of breakpoint.
15020         (finish_command_fsm_ops): Remove.
15021         (new_finish_command_fsm): Remove.
15022         (finish_command_fsm::should_stop): Rename from
15023         finish_command_fsm_should_stop.
15024         (finish_command_fsm::clean_up): Rename from
15025         finish_command_fsm_clean_up.
15026         (finish_command_fsm::return_value): Rename from
15027         finish_command_fsm_return_value.
15028         (finish_command_fsm::do_async_reply_reason): Rename from
15029         finish_command_fsm_async_reply_reason.
15030         (finish_command): Update.
15031         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15032         Add constructor.
15033         (call_thread_fsm_ops): Remove.
15034         (call_thread_fsm::call_thread_fsm): Rename from
15035         new_call_thread_fsm.
15036         (call_thread_fsm::should_stop): Rename from
15037         call_thread_fsm_should_stop.
15038         (call_thread_fsm::should_notify_stop): Rename from
15039         call_thread_fsm_should_notify_stop.
15040         (run_inferior_call, call_function_by_hand_dummy): Update.
15041         * cli/cli-interp.c (should_print_stop_to_console): Update.
15042         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15043         Add constructor.  Change type of location_breakpoint,
15044         caller_breakpoint.
15045         (until_break_fsm_ops): Remove.
15046         (new_until_break_fsm): Remove.
15047         (until_break_fsm::should_stop): Rename from
15048         until_break_fsm_should_stop.
15049         (until_break_fsm::clean_up): Rename from
15050         until_break_fsm_clean_up.
15051         (until_break_fsm::do_async_reply_reason): Rename from
15052         until_break_fsm_async_reply_reason.
15053         (until_break_command): Update.
15054         * thread-fsm.c: Remove.
15055         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15056
15057 2019-02-07  Tom Tromey  <tom@tromey.com>
15058
15059         * yy-remap.h: Add include guard.
15060         * xtensa-tdep.h: Add include guard.
15061         * xcoffread.h: Rename include guard.
15062         * varobj-iter.h: Add include guard.
15063         * tui/tui.h: Rename include guard.
15064         * tui/tui-winsource.h: Rename include guard.
15065         * tui/tui-wingeneral.h: Rename include guard.
15066         * tui/tui-windata.h: Rename include guard.
15067         * tui/tui-win.h: Rename include guard.
15068         * tui/tui-stack.h: Rename include guard.
15069         * tui/tui-source.h: Rename include guard.
15070         * tui/tui-regs.h: Rename include guard.
15071         * tui/tui-out.h: Rename include guard.
15072         * tui/tui-layout.h: Rename include guard.
15073         * tui/tui-io.h: Rename include guard.
15074         * tui/tui-hooks.h: Rename include guard.
15075         * tui/tui-file.h: Rename include guard.
15076         * tui/tui-disasm.h: Rename include guard.
15077         * tui/tui-data.h: Rename include guard.
15078         * tui/tui-command.h: Rename include guard.
15079         * tic6x-tdep.h: Add include guard.
15080         * target/waitstatus.h: Rename include guard.
15081         * target/wait.h: Rename include guard.
15082         * target/target.h: Rename include guard.
15083         * target/resume.h: Rename include guard.
15084         * target-float.h: Rename include guard.
15085         * stabsread.h: Add include guard.
15086         * rs6000-tdep.h: Add include guard.
15087         * riscv-fbsd-tdep.h: Add include guard.
15088         * regformats/regdef.h: Rename include guard.
15089         * record.h: Rename include guard.
15090         * python/python.h: Rename include guard.
15091         * python/python-internal.h: Rename include guard.
15092         * python/py-stopevent.h: Rename include guard.
15093         * python/py-ref.h: Rename include guard.
15094         * python/py-record.h: Rename include guard.
15095         * python/py-record-full.h: Rename include guard.
15096         * python/py-record-btrace.h: Rename include guard.
15097         * python/py-instruction.h: Rename include guard.
15098         * python/py-events.h: Rename include guard.
15099         * python/py-event.h: Rename include guard.
15100         * procfs.h: Add include guard.
15101         * proc-utils.h: Add include guard.
15102         * p-lang.h: Add include guard.
15103         * or1k-tdep.h: Rename include guard.
15104         * observable.h: Rename include guard.
15105         * nto-tdep.h: Rename include guard.
15106         * nat/x86-linux.h: Rename include guard.
15107         * nat/x86-linux-dregs.h: Rename include guard.
15108         * nat/x86-gcc-cpuid.h: Add include guard.
15109         * nat/x86-dregs.h: Rename include guard.
15110         * nat/x86-cpuid.h: Rename include guard.
15111         * nat/ppc-linux.h: Rename include guard.
15112         * nat/mips-linux-watch.h: Rename include guard.
15113         * nat/linux-waitpid.h: Rename include guard.
15114         * nat/linux-ptrace.h: Rename include guard.
15115         * nat/linux-procfs.h: Rename include guard.
15116         * nat/linux-osdata.h: Rename include guard.
15117         * nat/linux-nat.h: Rename include guard.
15118         * nat/linux-namespaces.h: Rename include guard.
15119         * nat/linux-btrace.h: Rename include guard.
15120         * nat/glibc_thread_db.h: Rename include guard.
15121         * nat/gdb_thread_db.h: Rename include guard.
15122         * nat/gdb_ptrace.h: Rename include guard.
15123         * nat/fork-inferior.h: Rename include guard.
15124         * nat/amd64-linux-siginfo.h: Rename include guard.
15125         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15126         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15127         * nat/aarch64-linux.h: Rename include guard.
15128         * nat/aarch64-linux-hw-point.h: Rename include guard.
15129         * mn10300-tdep.h: Add include guard.
15130         * mips-linux-tdep.h: Add include guard.
15131         * mi/mi-parse.h: Rename include guard.
15132         * mi/mi-out.h: Rename include guard.
15133         * mi/mi-main.h: Rename include guard.
15134         * mi/mi-interp.h: Rename include guard.
15135         * mi/mi-getopt.h: Rename include guard.
15136         * mi/mi-console.h: Rename include guard.
15137         * mi/mi-common.h: Rename include guard.
15138         * mi/mi-cmds.h: Rename include guard.
15139         * mi/mi-cmd-break.h: Rename include guard.
15140         * m2-lang.h: Add include guard.
15141         * location.h: Rename include guard.
15142         * linux-record.h: Rename include guard.
15143         * linux-nat.h: Add include guard.
15144         * linux-fork.h: Add include guard.
15145         * i386-darwin-tdep.h: Rename include guard.
15146         * hppa-linux-offsets.h: Add include guard.
15147         * guile/guile.h: Rename include guard.
15148         * guile/guile-internal.h: Rename include guard.
15149         * gnu-nat.h: Rename include guard.
15150         * gdb-stabs.h: Rename include guard.
15151         * frv-tdep.h: Add include guard.
15152         * f-lang.h: Add include guard.
15153         * event-loop.h: Add include guard.
15154         * darwin-nat.h: Rename include guard.
15155         * cp-abi.h: Rename include guard.
15156         * config/sparc/nm-sol2.h: Rename include guard.
15157         * config/nm-nto.h: Rename include guard.
15158         * config/nm-linux.h: Add include guard.
15159         * config/i386/nm-i386gnu.h: Rename include guard.
15160         * config/djgpp/nl_types.h: Rename include guard.
15161         * config/djgpp/langinfo.h: Rename include guard.
15162         * compile/gcc-cp-plugin.h: Add include guard.
15163         * compile/gcc-c-plugin.h: Add include guard.
15164         * compile/compile.h: Rename include guard.
15165         * compile/compile-object-run.h: Rename include guard.
15166         * compile/compile-object-load.h: Rename include guard.
15167         * compile/compile-internal.h: Rename include guard.
15168         * compile/compile-cplus.h: Rename include guard.
15169         * compile/compile-c.h: Rename include guard.
15170         * common/xml-utils.h: Rename include guard.
15171         * common/x86-xstate.h: Rename include guard.
15172         * common/version.h: Rename include guard.
15173         * common/vec.h: Rename include guard.
15174         * common/tdesc.h: Rename include guard.
15175         * common/selftest.h: Rename include guard.
15176         * common/scoped_restore.h: Rename include guard.
15177         * common/scoped_mmap.h: Rename include guard.
15178         * common/scoped_fd.h: Rename include guard.
15179         * common/safe-iterator.h: Rename include guard.
15180         * common/run-time-clock.h: Rename include guard.
15181         * common/refcounted-object.h: Rename include guard.
15182         * common/queue.h: Rename include guard.
15183         * common/ptid.h: Rename include guard.
15184         * common/print-utils.h: Rename include guard.
15185         * common/preprocessor.h: Rename include guard.
15186         * common/pathstuff.h: Rename include guard.
15187         * common/observable.h: Rename include guard.
15188         * common/netstuff.h: Rename include guard.
15189         * common/job-control.h: Rename include guard.
15190         * common/host-defs.h: Rename include guard.
15191         * common/gdb_wait.h: Rename include guard.
15192         * common/gdb_vecs.h: Rename include guard.
15193         * common/gdb_unlinker.h: Rename include guard.
15194         * common/gdb_unique_ptr.h: Rename include guard.
15195         * common/gdb_tilde_expand.h: Rename include guard.
15196         * common/gdb_sys_time.h: Rename include guard.
15197         * common/gdb_string_view.h: Rename include guard.
15198         * common/gdb_splay_tree.h: Rename include guard.
15199         * common/gdb_setjmp.h: Rename include guard.
15200         * common/gdb_ref_ptr.h: Rename include guard.
15201         * common/gdb_optional.h: Rename include guard.
15202         * common/gdb_locale.h: Rename include guard.
15203         * common/gdb_assert.h: Rename include guard.
15204         * common/filtered-iterator.h: Rename include guard.
15205         * common/filestuff.h: Rename include guard.
15206         * common/fileio.h: Rename include guard.
15207         * common/environ.h: Rename include guard.
15208         * common/common-utils.h: Rename include guard.
15209         * common/common-types.h: Rename include guard.
15210         * common/common-regcache.h: Rename include guard.
15211         * common/common-inferior.h: Rename include guard.
15212         * common/common-gdbthread.h: Rename include guard.
15213         * common/common-exceptions.h: Rename include guard.
15214         * common/common-defs.h: Rename include guard.
15215         * common/common-debug.h: Rename include guard.
15216         * common/cleanups.h: Rename include guard.
15217         * common/buffer.h: Rename include guard.
15218         * common/btrace-common.h: Rename include guard.
15219         * common/break-common.h: Rename include guard.
15220         * cli/cli-utils.h: Rename include guard.
15221         * cli/cli-style.h: Rename include guard.
15222         * cli/cli-setshow.h: Rename include guard.
15223         * cli/cli-script.h: Rename include guard.
15224         * cli/cli-interp.h: Rename include guard.
15225         * cli/cli-decode.h: Rename include guard.
15226         * cli/cli-cmds.h: Rename include guard.
15227         * charset-list.h: Add include guard.
15228         * buildsym-legacy.h: Rename include guard.
15229         * bfin-tdep.h: Add include guard.
15230         * ax.h: Rename include guard.
15231         * arm-linux-tdep.h: Add include guard.
15232         * arm-fbsd-tdep.h: Add include guard.
15233         * arch/xtensa.h: Rename include guard.
15234         * arch/tic6x.h: Add include guard.
15235         * arch/i386.h: Add include guard.
15236         * arch/arm.h: Rename include guard.
15237         * arch/arm-linux.h: Rename include guard.
15238         * arch/arm-get-next-pcs.h: Rename include guard.
15239         * arch/amd64.h: Add include guard.
15240         * arch/aarch64-insn.h: Rename include guard.
15241         * arch-utils.h: Rename include guard.
15242         * annotate.h: Add include guard.
15243         * amd64-darwin-tdep.h: Rename include guard.
15244         * aarch64-linux-tdep.h: Add include guard.
15245         * aarch64-fbsd-tdep.h: Add include guard.
15246         * aarch32-linux-nat.h: Add include guard.
15247
15248 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15249
15250         * macrotab.c (macro_define_internal): New function that
15251         factorizes macro_define_object_internal and macro_define_function
15252         code.
15253         (macro_define_object_internal): Use macro_define_internal.
15254         (macro_define_function): Likewise.
15255
15256 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15257
15258         * macrocmd.c (extract_identifier): Return
15259         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15260         callers.
15261
15262 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15263
15264         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15265
15266 2019-02-05  Tom Tromey  <tom@tromey.com>
15267
15268         * target.c (target_stack::unpush): Move assertion earlier.
15269
15270 2019-01-30  Tom Tromey  <tom@tromey.com>
15271
15272         PR python/23615:
15273         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15274         (gdbpy_parse_and_eval): Likewise.
15275         * python/python-internal.h (gdbpy_allow_threads): New class.
15276
15277 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15278
15279         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15280         (aarch64_fbsd_fpregmap): Move earlier.
15281         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15282         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15283         instead of individual calls to trad_frame_set_reg_addr.
15284         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15285         earlier.
15286         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15287         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15288         instead of individual calls to trad_frame_set_reg_addr.
15289
15290 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15291
15292         * CONTRIBUTE: Replace contribution list with wiki link.
15293
15294 2019-01-25  Tom Tromey  <tom@tromey.com>
15295
15296         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15297
15298 2019-01-25  Tom Tromey  <tom@tromey.com>
15299
15300         * xtensa-linux-nat.c: Fix common/ includes.
15301         * xml-support.h: Fix common/ includes.
15302         * xml-support.c: Fix common/ includes.
15303         * x86-linux-nat.c: Fix common/ includes.
15304         * windows-nat.c: Fix common/ includes.
15305         * varobj.h: Fix common/ includes.
15306         * varobj.c: Fix common/ includes.
15307         * value.c: Fix common/ includes.
15308         * valops.c: Fix common/ includes.
15309         * utils.c: Fix common/ includes.
15310         * unittests/xml-utils-selftests.c: Fix common/ includes.
15311         * unittests/utils-selftests.c: Fix common/ includes.
15312         * unittests/unpack-selftests.c: Fix common/ includes.
15313         * unittests/tracepoint-selftests.c: Fix common/ includes.
15314         * unittests/style-selftests.c: Fix common/ includes.
15315         * unittests/string_view-selftests.c: Fix common/ includes.
15316         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15317         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15318         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15319         * unittests/rsp-low-selftests.c: Fix common/ includes.
15320         * unittests/parse-connection-spec-selftests.c: Fix common/
15321         includes.
15322         * unittests/optional-selftests.c: Fix common/ includes.
15323         * unittests/offset-type-selftests.c: Fix common/ includes.
15324         * unittests/observable-selftests.c: Fix common/ includes.
15325         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15326         * unittests/memrange-selftests.c: Fix common/ includes.
15327         * unittests/memory-map-selftests.c: Fix common/ includes.
15328         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15329         * unittests/function-view-selftests.c: Fix common/ includes.
15330         * unittests/environ-selftests.c: Fix common/ includes.
15331         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15332         * unittests/common-utils-selftests.c: Fix common/ includes.
15333         * unittests/cli-utils-selftests.c: Fix common/ includes.
15334         * unittests/array-view-selftests.c: Fix common/ includes.
15335         * ui-file.c: Fix common/ includes.
15336         * tui/tui-io.c: Fix common/ includes.
15337         * tracepoint.h: Fix common/ includes.
15338         * tracepoint.c: Fix common/ includes.
15339         * tracefile-tfile.c: Fix common/ includes.
15340         * top.h: Fix common/ includes.
15341         * top.c: Fix common/ includes.
15342         * thread.c: Fix common/ includes.
15343         * target/waitstatus.h: Fix common/ includes.
15344         * target/waitstatus.c: Fix common/ includes.
15345         * target.h: Fix common/ includes.
15346         * target.c: Fix common/ includes.
15347         * target-memory.c: Fix common/ includes.
15348         * target-descriptions.c: Fix common/ includes.
15349         * symtab.h: Fix common/ includes.
15350         * symfile.c: Fix common/ includes.
15351         * stap-probe.c: Fix common/ includes.
15352         * spu-linux-nat.c: Fix common/ includes.
15353         * sparc-nat.c: Fix common/ includes.
15354         * source.c: Fix common/ includes.
15355         * solib.c: Fix common/ includes.
15356         * solib-target.c: Fix common/ includes.
15357         * ser-unix.c: Fix common/ includes.
15358         * ser-tcp.c: Fix common/ includes.
15359         * ser-pipe.c: Fix common/ includes.
15360         * ser-base.c: Fix common/ includes.
15361         * selftest-arch.c: Fix common/ includes.
15362         * s12z-tdep.c: Fix common/ includes.
15363         * rust-exp.y: Fix common/ includes.
15364         * rs6000-aix-tdep.c: Fix common/ includes.
15365         * riscv-tdep.c: Fix common/ includes.
15366         * remote.c: Fix common/ includes.
15367         * remote-notif.h: Fix common/ includes.
15368         * remote-fileio.h: Fix common/ includes.
15369         * remote-fileio.c: Fix common/ includes.
15370         * regcache.h: Fix common/ includes.
15371         * regcache.c: Fix common/ includes.
15372         * record-btrace.c: Fix common/ includes.
15373         * python/python.c: Fix common/ includes.
15374         * python/py-type.c: Fix common/ includes.
15375         * python/py-inferior.c: Fix common/ includes.
15376         * progspace.h: Fix common/ includes.
15377         * producer.c: Fix common/ includes.
15378         * procfs.c: Fix common/ includes.
15379         * proc-api.c: Fix common/ includes.
15380         * printcmd.c: Fix common/ includes.
15381         * ppc-linux-nat.c: Fix common/ includes.
15382         * parser-defs.h: Fix common/ includes.
15383         * osdata.c: Fix common/ includes.
15384         * obsd-nat.c: Fix common/ includes.
15385         * nat/x86-linux.c: Fix common/ includes.
15386         * nat/x86-linux-dregs.c: Fix common/ includes.
15387         * nat/x86-dregs.h: Fix common/ includes.
15388         * nat/x86-dregs.c: Fix common/ includes.
15389         * nat/ppc-linux.c: Fix common/ includes.
15390         * nat/mips-linux-watch.h: Fix common/ includes.
15391         * nat/mips-linux-watch.c: Fix common/ includes.
15392         * nat/linux-waitpid.c: Fix common/ includes.
15393         * nat/linux-ptrace.h: Fix common/ includes.
15394         * nat/linux-ptrace.c: Fix common/ includes.
15395         * nat/linux-procfs.c: Fix common/ includes.
15396         * nat/linux-personality.c: Fix common/ includes.
15397         * nat/linux-osdata.c: Fix common/ includes.
15398         * nat/linux-namespaces.c: Fix common/ includes.
15399         * nat/linux-btrace.h: Fix common/ includes.
15400         * nat/linux-btrace.c: Fix common/ includes.
15401         * nat/fork-inferior.c: Fix common/ includes.
15402         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15403         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15404         * nat/aarch64-linux.c: Fix common/ includes.
15405         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15406         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15407         * namespace.h: Fix common/ includes.
15408         * mips-linux-tdep.c: Fix common/ includes.
15409         * minsyms.c: Fix common/ includes.
15410         * mi/mi-parse.h: Fix common/ includes.
15411         * mi/mi-main.c: Fix common/ includes.
15412         * mi/mi-cmd-env.c: Fix common/ includes.
15413         * memrange.h: Fix common/ includes.
15414         * memattr.c: Fix common/ includes.
15415         * maint.h: Fix common/ includes.
15416         * maint.c: Fix common/ includes.
15417         * main.c: Fix common/ includes.
15418         * machoread.c: Fix common/ includes.
15419         * location.c: Fix common/ includes.
15420         * linux-thread-db.c: Fix common/ includes.
15421         * linux-nat.c: Fix common/ includes.
15422         * linux-fork.c: Fix common/ includes.
15423         * inline-frame.c: Fix common/ includes.
15424         * infrun.c: Fix common/ includes.
15425         * inflow.c: Fix common/ includes.
15426         * inferior.h: Fix common/ includes.
15427         * inferior.c: Fix common/ includes.
15428         * infcmd.c: Fix common/ includes.
15429         * inf-ptrace.c: Fix common/ includes.
15430         * inf-child.c: Fix common/ includes.
15431         * ia64-linux-nat.c: Fix common/ includes.
15432         * i387-tdep.c: Fix common/ includes.
15433         * i386-tdep.c: Fix common/ includes.
15434         * i386-linux-tdep.c: Fix common/ includes.
15435         * i386-linux-nat.c: Fix common/ includes.
15436         * i386-go32-tdep.c: Fix common/ includes.
15437         * i386-fbsd-tdep.c: Fix common/ includes.
15438         * i386-fbsd-nat.c: Fix common/ includes.
15439         * guile/scm-type.c: Fix common/ includes.
15440         * guile/guile.c: Fix common/ includes.
15441         * go32-nat.c: Fix common/ includes.
15442         * gnu-nat.c: Fix common/ includes.
15443         * gdbthread.h: Fix common/ includes.
15444         * gdbarch-selftests.c: Fix common/ includes.
15445         * gdb_usleep.c: Fix common/ includes.
15446         * gdb_select.h: Fix common/ includes.
15447         * gdb_bfd.c: Fix common/ includes.
15448         * gcore.c: Fix common/ includes.
15449         * fork-child.c: Fix common/ includes.
15450         * findvar.c: Fix common/ includes.
15451         * fbsd-nat.c: Fix common/ includes.
15452         * event-top.c: Fix common/ includes.
15453         * event-loop.c: Fix common/ includes.
15454         * dwarf2read.c: Fix common/ includes.
15455         * dwarf2loc.c: Fix common/ includes.
15456         * dwarf2-frame.c: Fix common/ includes.
15457         * dwarf-index-cache.c: Fix common/ includes.
15458         * dtrace-probe.c: Fix common/ includes.
15459         * disasm-selftests.c: Fix common/ includes.
15460         * defs.h: Fix common/ includes.
15461         * csky-tdep.c: Fix common/ includes.
15462         * cp-valprint.c: Fix common/ includes.
15463         * cp-support.h: Fix common/ includes.
15464         * cp-support.c: Fix common/ includes.
15465         * corelow.c: Fix common/ includes.
15466         * completer.h: Fix common/ includes.
15467         * completer.c: Fix common/ includes.
15468         * compile/compile.c: Fix common/ includes.
15469         * compile/compile-loc2c.c: Fix common/ includes.
15470         * compile/compile-cplus-types.c: Fix common/ includes.
15471         * compile/compile-cplus-symbols.c: Fix common/ includes.
15472         * command.h: Fix common/ includes.
15473         * cli/cli-dump.c: Fix common/ includes.
15474         * cli/cli-cmds.c: Fix common/ includes.
15475         * charset.c: Fix common/ includes.
15476         * build-id.c: Fix common/ includes.
15477         * btrace.h: Fix common/ includes.
15478         * btrace.c: Fix common/ includes.
15479         * breakpoint.h: Fix common/ includes.
15480         * breakpoint.c: Fix common/ includes.
15481         * ax.h:
15482         (enum agent_op): Fix common/ includes.
15483         * ax-general.c (struct aop_map): Fix common/ includes.
15484         * ax-gdb.c: Fix common/ includes.
15485         * auxv.c: Fix common/ includes.
15486         * auto-load.c: Fix common/ includes.
15487         * arm-tdep.c: Fix common/ includes.
15488         * arch/riscv.c: Fix common/ includes.
15489         * arch/ppc-linux-common.c: Fix common/ includes.
15490         * arch/i386.c: Fix common/ includes.
15491         * arch/arm.c: Fix common/ includes.
15492         * arch/arm-linux.c: Fix common/ includes.
15493         * arch/arm-get-next-pcs.c: Fix common/ includes.
15494         * arch/amd64.c: Fix common/ includes.
15495         * arch/aarch64.c: Fix common/ includes.
15496         * arch/aarch64-insn.c: Fix common/ includes.
15497         * arch-utils.c: Fix common/ includes.
15498         * amd64-windows-tdep.c: Fix common/ includes.
15499         * amd64-tdep.c: Fix common/ includes.
15500         * amd64-sol2-tdep.c: Fix common/ includes.
15501         * amd64-obsd-tdep.c: Fix common/ includes.
15502         * amd64-nbsd-tdep.c: Fix common/ includes.
15503         * amd64-linux-tdep.c: Fix common/ includes.
15504         * amd64-linux-nat.c: Fix common/ includes.
15505         * amd64-fbsd-tdep.c: Fix common/ includes.
15506         * amd64-fbsd-nat.c: Fix common/ includes.
15507         * amd64-dicos-tdep.c: Fix common/ includes.
15508         * amd64-darwin-tdep.c: Fix common/ includes.
15509         * agent.c: Fix common/ includes.
15510         * ada-lang.h: Fix common/ includes.
15511         * ada-lang.c: Fix common/ includes.
15512         * aarch64-tdep.c: Fix common/ includes.
15513
15514 2019-01-25  Tom Tromey  <tom@tromey.com>
15515
15516         * common/create-version.sh: Use common/version.h.
15517
15518 2019-01-24  Pedro Alves  <palves@redhat.com>
15519
15520         * infrun.c (signal_stop, signal_print, signal_program)
15521         (signal_catch, signal_pass): Now arrays instead of pointers.
15522         (update_signals_program_target, do_target_resume)
15523         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15524         * linux-nat.c (linux_nat_target::pass_signals)
15525         (linux_nat_target::create_inferior, linux_nat_target::attach):
15526         Adjust.
15527         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15528         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15529         * procfs.c (procfs_target::pass_signals): Adjust.
15530         * record-full.c (record_full_target::resume): Adjust.
15531         * remote.c (remote_target::pass_signals)
15532         (remote_target::program_signals): Adjust.
15533         * target-debug.h (target_debug_print_signals): Now takes a
15534         gdb::array_view as parameter.  Adjust.
15535         * target.h (target_ops) <pass_signals, program_signals>: Replace
15536         pointer and length parameters with gdb::array_view.
15537         (target_pass_signals, target_program_signals): Likewise.
15538         * target-delegates.c: Regenerate.
15539
15540 2019-01-24  Pedro Alves  <palves@redhat.com>
15541
15542         * common/forward-scope-exit.h
15543         (forward_scope_exit::forward_scope_exit): Pass arguments to
15544         m_bind_function directly, instead of creating a std::bind and
15545         copying that.
15546
15547 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15548
15549         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15550         for static members.
15551         (pass_in_v_vfp_candidate): Likewise.
15552
15553 2019-01-23  Tom Tromey  <tom@tromey.com>
15554             Pedro Alves  <palves@redhat.com>
15555
15556         * regcache.c (class regcache_invalidator): Remove.
15557         (regcache::raw_write): Use make_scope_exit.
15558
15559 2019-01-23  Tom Tromey  <tom@tromey.com>
15560
15561         * ui-out.h (class ui_out_emit_type): Update comment.
15562
15563 2019-01-23  Tom Tromey  <tom@tromey.com>
15564
15565         * infrun.c (fetch_inferior_event): Update comment.
15566
15567 2019-01-23  Tom Tromey  <tom@tromey.com>
15568             Pedro Alves  <palves@redhat.com>
15569
15570         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15571         parameter.
15572         (fetch_inferior_event): Use SCOPE_EXIT.
15573
15574
15575 2019-01-23  Tom Tromey  <tom@tromey.com>
15576             Pedro Alves  <palves@redhat.com>
15577
15578         * infrun.c (disable_thread_events): Delete.
15579         (stop_all_threads): Use SCOPE_EXIT.
15580
15581 2019-01-23  Tom Tromey  <tom@tromey.com>
15582             Pedro Alves  <palves@redhat.com>
15583
15584         * symfile.c: Include forward-scope-exit.h.
15585         (clear_symtab_users_cleanup): Replace forward declaration with
15586         a FORWARD_SCOPE_EXIT.
15587         (syms_from_objfile_1): Use the forward_scope_exit and
15588         gdb::optional instead of cleanup_function.
15589         (reread_symbols): Use the forward_scope_exit instead of
15590         cleanup_function.
15591         (clear_symtab_users_cleanup): Remove function.
15592
15593 2019-01-23  Tom Tromey  <tom@tromey.com>
15594             Pedro Alves  <palves@redhat.com>
15595
15596         * linux-nat.c: Include scope-exit.h.
15597         (cleanup_target_stop): Remove.
15598         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15599         SCOPE_EXIT.
15600
15601 2019-01-23  Tom Tromey  <tom@tromey.com>
15602             Pedro Alves  <palves@redhat.com>
15603
15604         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15605         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15606
15607 2019-01-23  Tom Tromey  <tom@tromey.com>
15608             Andrew Burgess  <andrew.burgess@embecosm.com>
15609             Pedro Alves  <palves@redhat.com>
15610
15611         * infrun.c (fetch_inferior_event): Use scope_exit.
15612         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15613         * top.c (execute_command): Use scope_exit.
15614         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15615         * utils.c (do_bpstat_clear_actions_cleanup)
15616         (make_bpstat_clear_actions_cleanup): Remove.
15617
15618 2019-01-23  Tom Tromey  <tom@tromey.com>
15619             Pedro Alves  <palves@redhat.com>
15620
15621         * infrun.c: Include "common/scope-exit.h"
15622         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15623         (wait_for_inferior): Use SCOPE_EXIT.
15624         (fetch_inferior_event): Use scope_exit.
15625
15626 2019-01-23  Tom Tromey  <tom@tromey.com>
15627             Pedro Alves  <palves@redhat.com>
15628
15629         * breakpoint.c (create_breakpoint): Remove cleanup.
15630
15631 2019-01-23  Tom Tromey  <tom@tromey.com>
15632             Andrew Burgess  <andrew.burgess@embecosm.com>
15633             Pedro Alves  <palves@redhat.com>
15634
15635 2019-01-23  Pedro Alves  <palves@redhat.com>
15636
15637         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15638
15639 2019-01-23  Pedro Alves  <palves@redhat.com>
15640             Andrew Burgess  <andrew.burgess@embecosm.com>
15641
15642         * gdbthread.h: Include "common/forward-scope-exit.h".
15643         (scoped_finish_thread_state): Redefine custom class in terms of
15644         forward_scope_exit.
15645
15646 2019-01-23  Pedro Alves  <palves@redhat.com>
15647             Andrew Burgess  <andrew.burgess@embecosm.com>
15648
15649         * common/forward-scope-exit.h: New file.
15650
15651 2019-01-23  Pedro Alves  <palves@redhat.com>
15652             Andrew Burgess  <andrew.burgess@embecosm.com>
15653             Tom Tromey  <tom@tromey.com>
15654
15655         * common/scope-exit.h: New file.
15656
15657 2019-01-23  Pedro Alves  <palves@redhat.com>
15658
15659         * common/preprocessor.h (ESC): Rename to ...
15660         (ESC_PARENS): ... this.
15661         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15662         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15663
15664 2019-01-23  Tom Tromey  <tom@tromey.com>
15665
15666         * language.h (class scoped_switch_to_sym_language_if_auto):
15667         Initialize m_lang in both cases.
15668
15669 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15670
15671         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15672         with XCNEW.
15673
15674 2019-01-22  Tom Tromey  <tom@tromey.com>
15675
15676         * corelow.c: Do not include sys/file.h.
15677
15678 2019-01-22  Tom Tromey  <tom@tromey.com>
15679
15680         * tui/tui-wingeneral.h: Include gdb_curses.h.
15681
15682 2019-01-22  Tom Tromey  <tom@tromey.com>
15683
15684         * source-cache.h (class source_cache) <get_source_lines,
15685         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15686
15687 2019-01-22  Tom Tromey  <tom@tromey.com>
15688
15689         * remote-fileio.h (struct remote_target): Declare.
15690
15691 2019-01-22  Tom Tromey  <tom@tromey.com>
15692
15693         * python/py-arch.c: Do not include py-ref.h.
15694         * python/py-bpevent.c: Do not include py-ref.h.
15695         * python/py-cmd.c: Do not include py-ref.h.
15696         * python/py-continueevent.c: Do not include py-ref.h.
15697         * python/py-event.h: Do not include py-ref.h.
15698         * python/py-evtregistry.c: Do not include py-ref.h.
15699         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15700         * python/py-frame.c: Do not include py-ref.h.
15701         * python/py-framefilter.c: Do not include py-ref.h.
15702         * python/py-function.c: Do not include py-ref.h.
15703         * python/py-infevents.c: Do not include py-ref.h.
15704         * python/py-linetable.c: Do not include py-ref.h.
15705         * python/py-objfile.c: Do not include py-ref.h.
15706         * python/py-param.c: Do not include py-ref.h.
15707         * python/py-prettyprint.c: Do not include py-ref.h.
15708         * python/py-progspace.c: Do not include py-ref.h.
15709         * python/py-symbol.c: Do not include py-ref.h.
15710         * python/py-symtab.c: Do not include py-ref.h.
15711         * python/py-type.c: Do not include py-ref.h.
15712         * python/py-unwind.c: Do not include py-ref.h.
15713         * python/py-utils.c: Do not include py-ref.h.
15714         * python/py-value.c: Do not include py-ref.h.
15715         * python/py-varobj.c: Do not include py-ref.h.
15716         * python/py-xmethods.c: Do not include py-ref.h.
15717         * python/python.c: Do not include py-ref.h.
15718         * varobj.c: Do not include py-ref.h.
15719
15720 2019-01-22  Tom Tromey  <tom@tromey.com>
15721
15722         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15723         keyword for bcache.
15724
15725 2019-01-22  Tom Tromey  <tom@tromey.com>
15726
15727         * compile/compile-cplus-types.c: Remove a comment by #include.
15728
15729 2019-01-22  Tom Tromey  <tom@tromey.com>
15730
15731         * compile/gcc-c-plugin.h: Include compile-internal.h.
15732
15733 2019-01-22  Tom Tromey  <tom@tromey.com>
15734
15735         * stabsread.c (EXTERN): Do not define.
15736         (symnum, next_symbol_text_func, processing_gcc_compilation)
15737         (within_function, global_sym_chain, global_stabs)
15738         (previous_stab_code, this_object_header_files)
15739         (n_this_object_header_files)
15740         (n_allocated_this_object_header_files): Define.
15741         * stabsread.h (EXTERN): Never define.  Use "extern".
15742
15743 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15744
15745         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15746         history_value.
15747
15748 2019-01-21  Tom Tromey  <tom@tromey.com>
15749
15750         * ui-out.c: Fix includes.
15751         * tui/tui-source.c: Fix includes.
15752         * target.c: Fix includes.
15753         * remote.c: Fix includes.
15754         * regcache.c: Fix includes.
15755         * python/py-block.c: Fix includes.
15756         * printcmd.c: Fix includes.
15757         * or1k-tdep.c: Fix includes.
15758         * mi/mi-main.c: Fix includes.
15759         * m32r-tdep.c: Fix includes.
15760         * csky-tdep.c: Fix includes.
15761         * compile/compile-cplus-types.c: Fix includes.
15762         * cli/cli-interp.c: Fix includes.
15763
15764 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15765
15766         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15767         for padding.
15768
15769 2019-01-16  Tom Tromey  <tom@tromey.com>
15770
15771         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15772         earlier.
15773         (struct objfile) <msymbols_range>: Move from top level.
15774         <msymbols>: New method.
15775         (class objfile_msymbols): Remove.
15776         * symtab.c (default_collect_symbol_completion_matches_break_on):
15777         Update.
15778         * symmisc.c (dump_msymbols): Update.
15779         * stabsread.c (scan_file_globals): Update.
15780         * objc-lang.c (info_selectors_command, info_classes_command)
15781         (find_methods): Update.
15782         * minsyms.c (find_solib_trampoline_target): Update.
15783         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15784         * coffread.c (coff_symfile_read): Update.
15785         * ada-lang.c (ada_lookup_simple_minsym)
15786         (ada_collect_symbol_completion_matches): Update.
15787
15788 2019-01-16  Tom Tromey  <tom@tromey.com>
15789
15790         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15791         type.  Remove no-argument constructor.
15792         <iterator::operator++>: Simplify.
15793         <begin>: Update.
15794         <end>: Use minimal_symbol_count.
15795
15796 2019-01-16  Tom Tromey  <tom@tromey.com>
15797
15798         * objfiles.h (struct objfile) <psymtabs>: New method.
15799         (class objfile_psymtabs): Remove.
15800         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15801         typedef.
15802         <range>: New method.
15803         (require_partial_symbols): Change return type.
15804         * psymtab.c (require_partial_symbols)
15805         (psym_expand_symtabs_matching): Update.
15806         * mdebugread.c (parse_partial_symbols): Update.
15807         * dbxread.c (dbx_end_psymtab): Update.
15808
15809 2019-01-15  Tom Tromey  <tom@tromey.com>
15810
15811         * symtab.c (lookup_objfile_from_block)
15812         (lookup_symbol_in_objfile_symtabs)
15813         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15814         (find_line_symtab, info_sources_command)
15815         (default_collect_symbol_completion_matches_break_on)
15816         (make_source_files_completion_list): Update.
15817         * symmisc.c (print_objfile_statistics, dump_objfile)
15818         (maintenance_print_symbols, maintenance_info_symtabs)
15819         (maintenance_check_symtabs, maintenance_info_line_tables):
15820         Update.
15821         * source.c (select_source_symtab)
15822         (forget_cached_source_info_for_objfile): Update.
15823         * objfiles.h (class objfile_compunits): Remove.
15824         (struct objfile) <compunits_range>: New typedef.
15825         (compunits): New method.
15826         * objfiles.c (objfile_relocate1): Update.
15827         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15828         * maint.c (count_symtabs_and_blocks): Update.
15829         * linespec.c (iterate_over_all_matching_symtabs): Update.
15830         * cp-support.c (add_symbol_overload_list_qualified): Update.
15831         * coffread.c (coff_symtab_read): Update.
15832         * ada-lang.c (add_nonlocal_symbols)
15833         (ada_collect_symbol_completion_matches)
15834         (ada_add_global_exceptions): Update.
15835
15836 2019-01-15  Tom Tromey  <tom@tromey.com>
15837
15838         * progspace.h (program_space) <objfiles_safe_range>: New
15839         typedef.
15840         <objfiles_safe>: New method.
15841         * objfiles.h (class all_objfiles_safe): Remove.
15842         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15843         * jit.c (jit_inferior_exit_hook): Update.
15844
15845 2019-01-17  Tom Tromey  <tom@tromey.com>
15846
15847         * progspace.h (program_space) <objfiles_range>: New typedef.
15848         <objfiles>: New method.
15849         <objfiles_head>: Rename from objfiles.
15850         (object_files): Update.
15851         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15852         * guile/scm-pretty-print.c
15853         (ppscm_find_pretty_printer_from_objfiles): Update.
15854         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15855         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15856         Update.
15857         * python/py-progspace.c (pspy_get_objfiles): Update.
15858         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15859         Update.
15860         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15861         (objfpy_lookup_objfile_by_build_id): Update.
15862         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15863         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15864         Update.
15865         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15866         (expand_symtab_containing_pc, lookup_objfile_from_block)
15867         (lookup_static_symbol, basic_lookup_transparent_type)
15868         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15869         (find_line_symtab, info_sources_command)
15870         (default_collect_symbol_completion_matches_break_on)
15871         (make_source_files_completion_list, find_main_name): Update.
15872         * symmisc.c (print_symbol_bcache_statistics)
15873         (print_objfile_statistics, maintenance_print_symbols)
15874         (maintenance_print_msymbols, maintenance_print_objfiles)
15875         (maintenance_info_symtabs, maintenance_check_symtabs)
15876         (maintenance_expand_symtabs, maintenance_info_line_tables):
15877         Update.
15878         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15879         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15880         (map_overlay_command, unmap_overlay_command)
15881         (simple_overlay_update, expand_symtabs_matching)
15882         (map_symbol_filenames): Update.
15883         * symfile-debug.c (set_debug_symfile): Update.
15884         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15885         Update.
15886         * source.c (select_source_symtab, forget_cached_source_info):
15887         Update.
15888         * solib.c (solib_read_symbols): Update.
15889         * solib-spu.c (append_ocl_sos): Update.
15890         * psymtab.c (maintenance_print_psymbols)
15891         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15892         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15893         * printcmd.c (info_symbol_command): Update.
15894         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15895         Update.
15896         * objfiles.h (class all_objfiles): Remove.
15897         * objfiles.c (have_partial_symbols, have_full_symbols)
15898         (have_minimal_symbols, qsort_cmp, update_section_map)
15899         (shared_objfile_contains_address_p)
15900         (default_iterate_over_objfiles_in_search_order): Update.
15901         * objc-lang.c (info_selectors_command, info_classes_command)
15902         (find_methods): Update.
15903         * minsyms.c (find_solib_trampoline_target): Update.
15904         * maint.c (maintenance_info_sections)
15905         (maintenance_translate_address, count_symtabs_and_blocks):
15906         Update.
15907         * main.c (captured_main_1): Update.
15908         * linux-thread-db.c (try_thread_db_load_from_pdir)
15909         (has_libpthread): Update.
15910         * linespec.c (iterate_over_all_matching_symtabs)
15911         (search_minsyms_for_name): Update.
15912         * jit.c (jit_find_objf_with_entry_addr): Update.
15913         * hppa-tdep.c (find_unwind_entry)
15914         (hppa_lookup_stub_minimal_symbol): Update.
15915         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15916         Update.
15917         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15918         (elf_gnu_ifunc_resolve_by_got): Update.
15919         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15920         * dwarf-index-write.c (save_gdb_index_command): Update.
15921         * cp-support.c (add_symbol_overload_list_qualified): Update.
15922         * breakpoint.c (create_overlay_event_breakpoint)
15923         (create_longjmp_master_breakpoint)
15924         (create_std_terminate_master_breakpoint)
15925         (create_exception_master_breakpoint): Update.
15926         * blockframe.c (find_pc_partial_function): Update.
15927         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15928         (ada_collect_symbol_completion_matches)
15929         (ada_add_global_exceptions): Update.
15930
15931 2019-01-17  Tom Tromey  <tom@tromey.com>
15932
15933         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15934         declare VEC.
15935         (solib_target_parse_libraries): Change return type.
15936         (library_list_start_segment, library_list_start_section)
15937         (library_list_end_library, library_list_start_library); Update.
15938         (solib_target_free_library_list): Remove.
15939         (solib_target_parse_libraries): Remove cleanup.  Change return
15940         type.
15941         (solib_target_current_sos): Update.
15942
15943 2019-01-17  Tom Tromey  <tromey@bapiya>
15944
15945         * valprint.c: Replace "the the" with "the".
15946         * symtab.c: Replace "the the" with "the".
15947         * solib.c: Replace "the the" with "the".
15948         * solib-dsbt.c: Replace "the the" with "the".
15949         * linespec.c: Replace "the the" with "the".
15950         * dwarf2loc.h: Replace "the the" with "the".
15951         * amd64-windows-tdep.c: Replace "the the" with "the".
15952         * aarch64-tdep.c: Replace "the the" with "the".
15953
15954 2019-01-16  Keith Seitz  <keiths@redhat.com>
15955
15956         PR gdb/23773
15957         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15958         <builder>: Rename to ..
15959         <m_builder>: ... this and make private.
15960         (dwarf2_cu::get_builder): New method.  Change all users of
15961         `builder' to use this method.
15962         (dwarf2_start_symtab): Move to ...
15963         (dwarf2_cu::start_symtab): ... here.  Update all callers
15964         (setup_type_unit_groups): Move to ...
15965         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15966         callers.
15967         (dwarf2_cu::reset_builder): New method.
15968         (process_full_compunit, process_full_type_unit): Use
15969         dwarf2_cu::reset_builder.
15970         (follow_die_offset): Record the ancestor CU if it is different
15971         from the followed DIE's CU.
15972         (follow_die_sig_1): Likewise.
15973
15974 2019-01-15  Tom Tromey  <tom@tromey.com>
15975
15976         * remote.c (class remote_state) <buf>: Now a char_vector.
15977         <buf_size>: Remove.
15978         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15979         parameter.
15980         (remote_target::getpkt_or_notif_sane_1)
15981         (remote_target::getpkt_sane)
15982         (remote_target::getpkt_or_notif_sane): Likewise.
15983         (class remote_target) <putpkt>: New overload.
15984         (remote_target::read_frame): Change type of "buf_p".  Remove
15985         sizeof_p parameter.
15986         (packet_ok): New overload.
15987         (packet_check_result): New overload.
15988         Update all uses.
15989
15990 2019-01-14  Tom Tromey  <tom@tromey.com>
15991
15992         * remote-notif.c (handle_notification, remote_notif_ack)
15993         (remote_notif_parse): Make "buf" const.
15994         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15995         const.
15996         (remote_notif_parse, remote_notif_ack, handle_notification):
15997         Likewise.
15998         * remote.c (remote_notif_stop_parse): Make "buf" const.
15999         (remote_target::remote_parse_stop_reply): Make "buf" const.
16000         (remote_notif_stop_ack): Make "buf" const.
16001
16002 2019-01-14  Tom Tromey  <tom@tromey.com>
16003
16004         * remote.c (remote_console_output): Make parameter const.
16005
16006 2019-01-14  Tom Tromey  <tom@tromey.com>
16007
16008         * target-debug.h (target_debug_print_signals): Constify.
16009         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16010         * procfs.c (procfs_target::pass_signals): Update.
16011         * linux-nat.c (linux_nat_target::pass_signals): Update.
16012         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16013         * target-delegates.c: Rebuild.
16014         * remote.c (remote_target::program_signals): Update.
16015         (remote_target::pass_signals): Update.
16016         * target.c (target_pass_signals): Constify argument.
16017         (target_program_signals): Likewise.
16018         * target.h (struct target_ops) <pass_signals, program_signals>:
16019         Constify argument.
16020         (target_pass_signals, target_program_signals): Constify argument.
16021
16022 2019-01-14  Tom Tromey  <tom@tromey.com>
16023
16024         PR tui/28819:
16025         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16026
16027 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16028
16029         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16030         field.
16031         * rs6000-tdep.c: Include reggroups.h.
16032         (IS_V_ALIAS_PSEUDOREG): Define.
16033         (rs6000_register_name): Return names for the "vX" aliases.
16034         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16035         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16036         aliases.  Call default_register_reggroup_p for all other
16037         pseudo-registers.
16038         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16039         New functions.
16040         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16041         Handle "vX" aliases.
16042         (v_alias_pseudo_register_collect): New function.
16043         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16044         (rs6000_gdbarch_init): Initialize "vX" aliases as
16045         pseudo-registers.  Restore registration of
16046         rs6000_pseudo_register_reggroup_p with
16047         set_tdesc_pseudo_register_reggroup_p.
16048
16049 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16050
16051         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16052         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16053         set_gdbarch_num_pseudo_regs.
16054
16055 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16056
16057         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16058         Remove arg prefixname, add do_set and do_show.
16059         Add member functions set_list and show_list.
16060         * cli/cli-style.c (class cli_style_option): Update accordingly.
16061         (style_set_list): Move to file scope.
16062         (style_show_list): Likewise.
16063         (set_style): Call help_list.
16064         (show_style): Call cmd_show_list.
16065         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16066         Update to use the new macro.
16067
16068 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16069
16070         * ada-lang.c (_initialize_ada_language): Expand the help text
16071         for the "catch exception" command.
16072
16073 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16074
16075         * symtab.c (matching_obj_sections): Initialize obj,
16076         declare it closer to its usage.
16077
16078 2019-01-10  Tom Tromey  <tom@tromey.com>
16079
16080         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16081         (basic_inf_threads_range): Remove.
16082         (inf_threads_range, inf_non_exited_threads_range)
16083         (safe_inf_threads_range): Use next_adapter.
16084
16085 2019-01-10  Keith Seitz  <keiths@redhat.com>
16086
16087         PR gdb/23712
16088         PR symtab/23010
16089         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16090         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16091
16092 2019-01-10  Keith Seitz  <keiths@redhat.com>
16093
16094         PR gdb/23712
16095         PR symtab/23010
16096         * dictionary.c (pending_to_vector): Remove.
16097         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16098         Remove _1 suffix, replacing functions of the same name.  Update
16099         all callers.
16100         (dict_create_hashed, dict_create_hashed_expandable)
16101         (dict_create_linear, dict_create_linear_expandable, dict_free)
16102         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16103         Make functions static.
16104
16105 2019-01-10  Keith Seitz  <keiths@redhat.com>
16106
16107         PR gdb/23712
16108         PR symtab/23010
16109         * dictionary.h (struct dictionary): Replace declaration with
16110         multidictionary.
16111         (dict_create_hashed, dict_create_hashed_expandable)
16112         (dict_create_linear, dict_create_linear_expandable)
16113         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16114         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16115         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16116         taking multidictionary argument.
16117         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16118         * block.h (struct block) <dict>: Change to multidictionary
16119         and rename `multidict'.
16120         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16121         symmisc.c: Update all dictionary references to multidictionary.
16122
16123 2019-01-10  Keith Seitz  <keiths@redhat.com>
16124
16125         PR gdb/23712
16126         PR symtab/23010
16127         * dictionary.c: Include unordered_map.
16128         (pending_to_vector): New function.
16129         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16130         Rewrite the non-"_1" functions to take vector instead
16131         of linked list.
16132         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16133         "new" _1 versions of the same name.
16134         (multidictionary): Define.
16135         (std::hash<enum language): New definition.
16136         (collate_pending_symbols_by_language, mdict_create_hashed)
16137         (mdict_create_hashed_expandable, mdict_create_linear)
16138         (mdict_create_linear_expandable, mdict_free)
16139         (find_language_dictionary, create_new_language_dictionary)
16140         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16141         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16142         (mdict_size, mdict_empty): New functions.
16143         * dictionary.h (mdict_iterator): Define.
16144
16145 2019-01-10  Pedro Alves  <palves@redhat.com>
16146
16147         * breakpoint.c (read_uploaded_action)
16148         (create_tracepoint_from_upload): Adjust to use
16149         gdb::unique_xmalloc_ptr.
16150         * ctf.c (ctf_write_uploaded_tp):
16151         (SET_ARRAY_FIELD): Use emplace_back.
16152         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16153         * tracefile-tfile.c (tfile_write_uploaded_tp):
16154         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16155         gdb::unique_xmalloc_ptr.
16156         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16157         at_string, cond_string, cmd_strings>: Replace char pointers
16158         with gdb::unique_xmalloc_ptr.
16159
16160 2019-01-10  Pedro Alves  <palves@redhat.com>
16161
16162         * solib-target.c (library_list_start_library): Don't xstrdup name.
16163
16164 2019-01-10  Pedro Alves  <palves@redhat.com>
16165
16166         * mdebugread.c (parse_partial_symbols): Use
16167         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16168
16169 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16170
16171         * linux-fork.c (scoped_switch_fork_info)
16172         <~scoped_switch_fork_info>: Fix incorrect variable name.
16173
16174 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16175
16176         * linux-fork.c (scoped_switch_fork_info)
16177         <scoped_switch_fork_info>: Make explicit.
16178         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16179
16180 2019-01-10  Tom Tromey  <tom@tromey.com>
16181
16182         * objfiles.h (objfile::reset_psymtabs): Update.
16183         * objfiles.c (objfile::objfile): Update.
16184         * psymtab.h (psymtab_storage::obstack): Update.
16185         (psymtab_storage::m_obstack): Use gdb::optional.
16186         (class psymtab_storage): Update comment.  Remove objfile
16187         parameter.
16188         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16189
16190 2019-01-10  Tom Tromey  <tom@tromey.com>
16191
16192         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16193         <free_psymtabs>: Now private.
16194         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16195         (allocate_psymtab): Use new method.
16196
16197 2019-01-10  Tom Tromey  <tom@tromey.com>
16198
16199         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16200         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16201         * mdebugread.c (parse_partial_symbols): Use
16202         allocate_dependencies.
16203         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16204         allocate_dependencies.
16205         (process_psymtab_comp_unit_reader)
16206         (build_type_psymtab_dependencies): Likewise.
16207         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16208
16209 2019-01-10  Tom Tromey  <tom@tromey.com>
16210
16211         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16212         PSYMBOL_SET_LANGUAGE.
16213         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16214
16215 2019-01-10  Tom Tromey  <tom@tromey.com>
16216
16217         * psymtab.h (psymtab_storage::obstack): New method.
16218         <m_obstack>: Rename from obstack; now private.
16219         * psymtab.c (psymtab_storage): Update.
16220         * dwarf2read.c (create_addrmap_from_index)
16221         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16222         Update.
16223
16224 2019-01-10  Tom Tromey  <tom@tromey.com>
16225
16226         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16227         * objfiles.h (objfile::reset_psymtabs): New method.
16228
16229 2019-01-10  Tom Tromey  <tom@tromey.com>
16230
16231         * symmisc.c (print_symbol_bcache_statistics): Update.
16232         (print_objfile_statistics): Update.
16233         * symfile.c (reread_symbols): Update.
16234         * psymtab.h (class psymtab_storage): New.
16235         * psymtab.c (psymtab_storage): New constructor.
16236         (~psymtab_storage): New destructor.
16237         (require_partial_symbols): Update.
16238         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16239         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16240         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16241         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16242         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16243         (start_psymtab_common, end_psymtab_common)
16244         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16245         (allocate_psymtab): Update.
16246         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16247         Update.
16248         (dump_psymtab_addrmap, maintenance_print_psymbols)
16249         (maintenance_check_psymtabs): Update.
16250         (class objfile_psymtabs): Move to objfiles.h.
16251         * psympriv.h (discard_psymtab): Now inline.
16252         (psymtab_discarder::psymtab_discarder): Update.
16253         (psymtab_discarder::~psymtab_discarder): Update.
16254         (ALL_OBJFILE_PSYMTABS): Rewrite.
16255         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16256         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16257         Remove fields.
16258         <partial_symtabs>: New field.
16259         (class objfile_psymtabs): Move from psymtab.h.  Update.
16260         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16261         psymbol_cache.
16262         (objfile::~objfile): Don't destroy psymbol_cache.
16263         * mdebugread.c (parse_partial_symbols): Update.
16264         * dwarf2read.c (create_addrmap_from_index)
16265         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16266         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16267         (add_partial_subprogram, dwarf2_ranges_read): Update.
16268         * dwarf-index-write.c (write_address_map)
16269         (write_one_signatured_type, recursively_write_psymbols)
16270         (class debug_names, class debug_names, write_psymtabs_to_index):
16271         Update.
16272
16273 2019-01-10  Tom Tromey  <tom@tromey.com>
16274
16275         * symtab.h (SYMBOL_SET_NAMES): Update.
16276         (symbol_set_names): Update.
16277         (MSYMBOL_SET_NAMES): Update.
16278         * symtab.c (symbol_set_names): Change argument to be an
16279         objfile_per_bfd_storage.
16280         * psymtab.c (add_psymbol_to_bcache): Update.
16281         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16282
16283 2019-01-10  Tom Tromey  <tom@tromey.com>
16284
16285         * symtab.c (create_demangled_names_hash): Change argument to be an
16286         objfile_per_bfd_storage.
16287         (symbol_set_names): Update.
16288
16289 2019-01-10  Tom Tromey  <tom@tromey.com>
16290
16291         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16292         init_psymbol_list.
16293         * psymtab.c (init_psymbol_list): Do nothing if already called.
16294         * psympriv.h (init_psymbol_list): Add comment.
16295         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16296         init_psymbol_list.
16297         * dbxread.c (dbx_symfile_read): Unconditionally call
16298         init_psymbol_list.
16299
16300 2019-01-10  Tom Tromey  <tom@tromey.com>
16301
16302         * xcoffread.c (scan_xcoff_symtab): Update.
16303         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16304         "where".
16305         * mdebugread.c (parse_partial_symbols)
16306         (handle_psymbol_enumerators): Update.
16307         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16308         * dbxread.c (read_dbx_symtab): Update.
16309         * psympriv.h (psymbol_placement): New enum.
16310         (add_psymbol_to_list): Update.
16311
16312 2019-01-10  Tom Tromey  <tom@tromey.com>
16313
16314         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16315         static_psymbols parameters.
16316         (scan_xcoff_symtab): Update.
16317         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16318         static_psymbols parameters.
16319         * psympriv.h (start_psymtab_common): Update.
16320         * mdebugread.c (parse_partial_symbols): Update.
16321         * dwarf2read.c (create_partial_symtab): Update.
16322         * dbxread.c (read_dbx_symtab): Update.
16323         (start_psymtab): Remove global_psymbols and static_psymbols
16324         parameters.
16325
16326 2019-01-10  Tom Tromey  <tom@tromey.com>
16327
16328         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16329         * psymtab.c (allocate_psymtab): Add comment.
16330         * psympriv.h (allocate_psymtab): Add comment.
16331         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16332         initializations.
16333         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16334
16335 2019-01-10  Tom Tromey  <tom@tromey.com>
16336
16337         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16338         Don't declare.
16339         * mipsread.c: Include mdebugread.h.
16340         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16341         Declare.
16342         * elfread.c: Include mdebugread.h.
16343
16344 2019-01-09  Tom Tromey  <tom@tromey.com>
16345
16346         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16347         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16348         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16349         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16350         (psym_lookup_symbol, psym_find_last_source_symtab)
16351         (psym_forget_cached_source_info, psym_print_stats)
16352         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16353         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16354         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16355         (psym_find_compunit_symtab_by_address)
16356         (maintenance_print_psymbols, maintenance_info_psymtabs)
16357         (maintenance_check_psymtabs): Use ranged for.
16358         * psymtab.h (class objfile_psymtabs): New.
16359         (require_partial_symbols): Return objfile_psymtabs.
16360         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16361
16362 2019-01-09  Tom Tromey  <tom@tromey.com>
16363
16364         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16365         (find_pc_mapped_section, list_overlays_command)
16366         (map_overlay_command, unmap_overlay_command)
16367         (simple_overlay_update): Use all_objfiles.
16368         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16369         * printcmd.c (info_symbol_command): Use all_objfiles.
16370         * objfiles.h (ALL_OBJSECTIONS): Remove.
16371         * maint.c (maintenance_translate_address): Use all_objfiles.
16372         * gcore.c (gcore_create_callback): Use all_objfiles.
16373         (objfile_find_memory_regions): Likewise.
16374
16375 2019-01-09  Tom Tromey  <tom@tromey.com>
16376
16377         * symtab.c (find_line_symtab, info_sources_command)
16378         (make_source_files_completion_list): Use objfile_compunits.
16379         * source.c (select_source_symtab): Use objfile_compunits.
16380         * objfiles.h (struct objfile): Update comment.
16381         (ALL_OBJFILES): Remove.
16382         (ALL_FILETABS): Remove.
16383         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16384         objfile_compunits.
16385
16386 2019-01-09  Tom Tromey  <tom@tromey.com>
16387
16388         * symmisc.c (print_objfile_statistics, dump_objfile)
16389         (maintenance_print_symbols): Use compunit_filetabs.
16390         * source.c (forget_cached_source_info_for_objfile): Use
16391         compunit_filetabs.
16392         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16393         (ALL_FILETABS): Use compunit_filetabs.
16394         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16395         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16396
16397 2019-01-09  Tom Tromey  <tom@tromey.com>
16398
16399         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16400         (compunit_filetabs): New.
16401         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16402         compunit_filetabs.
16403         (info_sources_command, make_source_files_completion_list): Remove
16404         declaration.
16405         * symmisc.c (print_objfile_statistics, dump_objfile)
16406         (maintenance_print_symbols): Remove declaration.
16407         (maintenance_info_symtabs): Use compunit_filetabs.
16408         (maintenance_info_line_tables): Likewise.
16409         * source.c (select_source_symtab): Change local variable name.
16410         (forget_cached_source_info_for_objfile): Remove declaration.
16411         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16412         * objfiles.c (objfile_relocate1): Remove declaration.
16413         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16414         declaration.
16415         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16416         * coffread.c (coff_symtab_read): Remove declaration.
16417         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16418         compunit_filetabs.
16419
16420 2019-01-09  Tom Tromey  <tom@tromey.com>
16421
16422         * symtab.c (lookup_objfile_from_block)
16423         (find_pc_sect_compunit_symtab, search_symbols)
16424         (default_collect_symbol_completion_matches_break_on): Use
16425         objfile_compunits.
16426         * objfiles.h (ALL_COMPUNITS): Remove.
16427         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16428         * cp-support.c (add_symbol_overload_list_qualified): Use
16429         objfile_compunits.
16430         * ada-lang.c (ada_collect_symbol_completion_matches)
16431         (ada_add_global_exceptions): Use objfile_compunits.
16432
16433 2019-01-09  Tom Tromey  <tom@tromey.com>
16434
16435         * source.c (select_source_symtab)
16436         (forget_cached_source_info_for_objfile): Remove declaration.
16437         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16438         declaration.
16439         * maint.c (count_symtabs_and_blocks): Remove declaration.
16440         * cp-support.c (add_symbol_overload_list_qualified): Remove
16441         declaration.
16442         * coffread.c (coff_symtab_read): Remove declaration.
16443         * symtab.c (lookup_symbol_in_objfile_symtabs)
16444         (basic_lookup_transparent_type_1): Use objfile_compunits.
16445         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16446         (info_sources_command, search_symbols)
16447         (default_collect_symbol_completion_matches_break_on)
16448         (make_source_files_completion_list): Remove declaration.
16449         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16450         (ada_collect_symbol_completion_matches)
16451         (ada_add_global_exceptions): Remove declaration.
16452         * linespec.c (iterate_over_all_matching_symtabs): Use
16453         objfile_compunits.
16454         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16455         (class objfile_compunits): New.
16456         (ALL_COMPUNITS): Use objfile_compunits.
16457         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16458         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16459         objfile_compunits.
16460         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16461
16462 2019-01-09  Tom Tromey  <tom@tromey.com>
16463
16464         * symtab.c (search_symbols)
16465         (default_collect_symbol_completion_matches_break_on): Use
16466         objfile_msymbols.
16467         * ada-lang.c (ada_lookup_simple_minsym)
16468         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16469         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16470         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16471         objfile_msymbols.
16472         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16473         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16474         * objc-lang.c (find_methods): Use objfile_msymbols.
16475         (info_selectors_command, info_classes_command): Likewise.
16476         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16477         * objfiles.h (class objfile_msymbols): New.
16478         (ALL_OBJFILE_MSYMBOLS): Remove.
16479         (ALL_MSYMBOLS): Remove.
16480
16481 2019-01-09  Tom Tromey  <tom@tromey.com>
16482
16483         * common/next-iterator.h (next_adapter): Add Iterator template
16484         parameter.
16485         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16486         (class all_objfiles_safe): New.
16487         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16488         * objfiles.c (put_objfile_before): Update comment.
16489         (add_separate_debug_objfile): Likewise.
16490         (free_all_objfiles): Use all_objfiles_safe.
16491         (objfile_purge_solibs): Likewise.
16492
16493 2019-01-09  Tom Tromey  <tom@tromey.com>
16494
16495         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16496         (expand_symtab_containing_pc, lookup_static_symbol)
16497         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16498         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16499         all_objfiles.
16500         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16501         * breakpoint.c (create_overlay_event_breakpoint)
16502         (create_longjmp_master_breakpoint)
16503         (create_std_terminate_master_breakpoint)
16504         (create_exception_master_breakpoint): Use all_objfiles.
16505         * linux-thread-db.c (try_thread_db_load_from_pdir)
16506         (has_libpthread): Use all_objfiles.
16507         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16508         * linespec.c (iterate_over_all_matching_symtabs)
16509         (search_minsyms_for_name): Use all_objfiles.
16510         * maint.c (maintenance_info_sections): Use all_objfiles.
16511         * main.c (captured_main_1): Use all_objfiles.
16512         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16513         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16514         * guile/scm-pretty-print.c
16515         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16516         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16517         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16518         (maintenance_print_msymbols): Use all_objfiles.
16519         * source.c (select_source_symtab): Use all_objfiles.
16520         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16521         * symfile.c (remove_symbol_file_command)
16522         (expand_symtabs_matching, map_symbol_filenames): Use
16523         all_objfiles.
16524         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16525         all_objfiles.
16526         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16527         * objc-lang.c (find_methods): Use all_objfiles.
16528         * objfiles.c (have_partial_symbols, have_full_symbols)
16529         (have_minimal_symbols, qsort_cmp)
16530         (default_iterate_over_objfiles_in_search_order): Use
16531         all_objfiles.
16532         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16533         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16534         (maintenance_check_psymtabs): Use all_objfiles.
16535         (ALL_PSYMTABS): Remove.
16536         * compile/compile-object-run.c (do_module_cleanup): Use
16537         all_objfiles.
16538         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16539         * cp-support.c (add_symbol_overload_list_qualified): Use
16540         all_objfiles.
16541         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16542         Use all_objfiles.
16543         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16544         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16545         all_objfiles.
16546         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16547         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16548         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16549         Uses all_objfiles.
16550         * solib.c (solib_read_symbols): Use all_objfiles
16551
16552 2019-01-09  Tom Tromey  <tom@tromey.com>
16553
16554         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16555         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16556         all_objfiles.
16557         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16558         * symmisc.c (print_symbol_bcache_statistics)
16559         (print_objfile_statistics, maintenance_print_objfiles)
16560         (maintenance_info_symtabs, maintenance_check_symtabs)
16561         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16562         all_objfiles.
16563         * source.c (forget_cached_source_info): Use all_objfiles.
16564         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16565         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16566         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16567         * objfiles.c (update_section_map): Use all_objfiles.
16568         (shared_objfile_contains_address_p): Likewise.
16569         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16570         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16571
16572 2019-01-09  Tom Tromey  <tom@tromey.com>
16573
16574         * common/next-iterator.h: New file.
16575         * objfiles.h (class all_objfiles): New.
16576         (struct objfile_iterator): New.
16577
16578 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16579
16580         * NEWS: Move the description of the changed "frame", "select-frame",
16581          and "info frame" commands to the Changed commands section.
16582
16583 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16584
16585         * gdbtypes.c (check_stub_method_group): Remove handling of old
16586         mangling schemes.
16587         * linespec.c (find_methods): Likewise.
16588         * stabsread.c (read_member_functions): Likewise.
16589         * valops.c (search_struct_method): Likewise.
16590         (value_struct_elt_for_reference): Likewise.
16591         * NEWS: Mention this change.
16592
16593 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16594
16595         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16596         print_source_lines.
16597         * source.c (print_source_lines_base): Update line number check.
16598         (print_source_lines): New function.
16599         (source_lines_range::source_lines_range): New function.
16600         * source.h (class source_lines_range): New class.
16601         (print_source_lines): New declaration.
16602
16603 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16604
16605         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16606
16607 2019-01-08  Tom Tromey  <tom@tromey.com>
16608             Simon Marchi  <simon.marchi@ericsson.com>
16609
16610         PR gdb/24060
16611         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16612         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16613         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16614         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16615         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16616         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16617
16618 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16619
16620         * source.c (select_source_symtab): Move header comment to
16621         declaration in source.h.
16622         (forget_cached_source_info_for_objfile): Likewise.
16623         (forget_cached_source_info): Likewise.
16624         (identify_source_line): Likewise.
16625         * source.h (identify_source_line): Move declaration from symtab.h
16626         and add comment from source.c
16627         (print_source_lines): Likewise.
16628         (forget_cached_source_info_for_objfile): Likewise.
16629         (forget_cached_source_info): Likewise.
16630         (select_source_symtab): Likewise.
16631         (enum print_source_lines_flag): Move definition from symtab.h.
16632         * symtab.h (identify_source_line): Move declaration to source.h.
16633         (print_source_lines): Likewise.
16634         (forget_cached_source_info_for_objfile): Likewise.
16635         (forget_cached_source_info): Likewise.
16636         (select_source_symtab): Likewise.
16637         (enum print_source_lines_flag): Move definition to source.h.
16638         * tui/tui-hooks.c: Add 'source.h' include.
16639
16640 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16641
16642         * source.c (print_source_lines_base): Handle requests to print
16643         reverse line number sequences, and guard against empty lines
16644         string.
16645
16646 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16647
16648         * source.c (print_source_lines_base): Fix skip of '\r' if next
16649         character is '\n'.
16650
16651 2019-01-06  Tom Tromey  <tom@tromey.com>
16652
16653         * c-exp.y (struct c_parse_state) <macro_original_text,
16654         expansion_obstack>: New member.
16655         (macro_original_text, expansion_obstack): Remove globals.
16656         (scan_macro_expansion, scanning_macro_expansion)
16657         (finished_macro_expansion): Update.
16658         (scan_macro_cleanup): Remove.
16659         (yylex, c_parse): Update.
16660
16661 2019-01-06  Tom Tromey  <tom@tromey.com>
16662
16663         * c-exp.y (struct c_parse_state) <strings>: New member.
16664         (operator_stoken): Update.
16665
16666 2019-01-06  Tom Tromey  <tom@tromey.com>
16667
16668         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16669         (union type_stack_elt) <typelist_val>: Now a pointer to
16670         std::vector.
16671         (type_stack_cleanup): Don't declare.
16672         (push_typelist): Update.
16673         * parse.c (pop_typelist): Return a std::vector.
16674         (push_typelist): Take a std::vector.
16675         (follow_types): Update.  Do not free args.
16676         (type_stack_cleanup): Remove.
16677         * c-exp.y (struct c_parse_state): New.
16678         (cpstate): New global.
16679         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16680         (nonempty_typelist): Update.
16681         (func_mod): Create a new vector.
16682         (c_parse): Create a c_parse_state.
16683         (check_parameter_typelist): Do not delete params.
16684         (function_method): Update.  Do not delete type_list.
16685
16686 2019-01-06  Tom Tromey  <tom@tromey.com>
16687
16688         PR gdb/28155:
16689         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16690         check_typedef.
16691         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16692         (print_return_value): Likewise.
16693
16694 2019-01-05  Tom Tromey  <tom@tromey.com>
16695
16696         * contrib/cleanup_check.py: Remove.
16697         * contrib/gcc-with-excheck: Remove.
16698         * contrib/exsummary.py: Remove.
16699         * contrib/excheck.py: Remove.
16700
16701 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16702
16703         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16704         NULL. Initialize tpprev to NULL instead of assigning it
16705         to NULL on the next statement.
16706         * windows-nat.c (windows_delete_thread): Remove check for
16707         main_thread_id before printing thread exit notifications.
16708         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16709         Remove thread ID check against main_thread_id.
16710         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16711         windows_delete_thread.
16712         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16713
16714 2019-01-04  Tom Tromey  <tom@tromey.com>
16715
16716         * compile/compile.c (_initialize_compile): Use upper case for
16717         metasyntactic variables.
16718         * symmisc.c (_initialize_symmisc): Use upper case for
16719         metasyntactic variables.
16720         * psymtab.c (_initialize_psymtab): Use upper case for
16721         metasyntactic variables.
16722         * demangle.c (demangle_command): Use upper case for metasyntactic
16723         variables.
16724         (_initialize_demangler): Likewise.
16725         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16726         variables.
16727
16728 2019-01-03  Tom Tromey  <tom@tromey.com>
16729
16730         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16731
16732 2019-01-03  Tom Tromey  <tom@tromey.com>
16733
16734         * python/py-symtab.c (salpy_str): Update.
16735         (struct salpy_sal_object) <symtab>: Now a PyObject.
16736         (salpy_dealloc): Update.
16737         (del_objfile_sal): Use gdbpy_ref.
16738
16739 2019-01-03  Tom Tromey  <tom@tromey.com>
16740
16741         * python/py-type.c (convert_field): Use new_reference.  Return
16742         gdbpy_ref.
16743         (make_fielditem): Return gdbpy_ref.
16744         (typy_fields): Update.
16745         (typy_getitem): Update.
16746         (field_name): Return gdbpy_ref.  Use new_reference.
16747         (typy_iterator_iternext): Update.
16748
16749 2019-01-03  Tom Tromey  <tom@tromey.com>
16750
16751         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16752
16753 2019-01-03  Tom Tromey  <tom@tromey.com>
16754
16755         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16756         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16757         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16758         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16759         (pspy_set_type_printers): Likewise.
16760         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16761         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16762         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16763         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16764         (objfpy_set_type_printers): Likewise.
16765
16766 2019-01-03  Tom Tromey  <tom@tromey.com>
16767
16768         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16769         (gdbpy_print_stack): Use gdbpy_err_fetch.
16770         * python/python-internal.h (class gdbpy_err_fetch): New class.
16771         (class gdbpy_enter) <m_error_type, m_error_value,
16772         m_error_traceback>: Remove.
16773         <m_error>: New member.
16774         (gdbpy_exception_to_string): Don't declare.
16775         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16776         * python/py-value.c (convert_value_from_python): Use
16777         gdbpy_err_fetch.
16778         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16779         gdbpy_exception_to_string.
16780         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16781         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16782         gdbpy_err_fetch.
16783
16784 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16785
16786         * linux-nat.c (delete_lwp_cleanup): Delete.
16787         (struct lwp_deleter): New struct.
16788         (lwp_info_up): New typedef.
16789         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16790         lwp_info_up.
16791
16792 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16793
16794         * linux-fork.c (class scoped_switch_fork_info): New class.
16795         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16796
16797 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16798
16799         * valops.c (find_overload_match): Remove use of null_cleanup, and
16800         calls to do_cleanups.
16801
16802 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16803
16804         * compile/compile-cplus-types.c
16805         (compile_cplus_instance::decl_name): Handle changes to
16806         cp_func_name.
16807         * cp-support.c (cp_func_name): Update header comment, update
16808         return type.
16809         * cp-support.h (cp_func_name): Update return type in declaration.
16810         * valops.c (find_overload_match): Move temp_func local to top
16811         level of function and change its type.  Use temp_func to hold and
16812         delete temporary string obtained from cp_func_name.
16813
16814 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16815
16816         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16817         gdb::char_vector, remove cleanup, and update uses of `msg`.
16818
16819 2019-01-03  Jim Wilson  <jimw@sifive.com>
16820
16821         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16822
16823 2019-01-02  Tom Tromey  <tom@tromey.com>
16824
16825         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16826         (tdesc_parse_xml): Remove cleanups.
16827         * target-descriptions.h (make_cleanup_free_target_description):
16828         Don't declare.
16829         (target_desc_deleter): New struct.
16830         (target_desc_up): New typedef.
16831         * target-descriptions.c (target_desc_deleter::operator()): Rename
16832         from free_target_description.
16833         (make_cleanup_free_target_description): Remove.
16834
16835 2019-01-02  Tom Tromey  <tom@tromey.com>
16836
16837         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16838         constructor, destructor.
16839         (linespec_parser): Remove typedef.
16840         (~linespec_parser): Rename from linespec_parser_delete.
16841         (linespec_lex_to_end, linespec_complete_label)
16842         (linespec_complete): Update.
16843         (decode_line_full): Remove cleanups.
16844         (decode_line_1): Update.
16845
16846 2019-01-02  Tom Tromey  <tom@tromey.com>
16847
16848         * python/python-internal.h (inferior_to_inferior_object): Change
16849         return type.
16850         * python/py-exitedevent.c (create_exited_event_object): Update.
16851         * python/py-inferior.c (inferior_to_inferior_object): Return
16852         gdbpy_ref.
16853         (python_new_inferior, python_inferior_deleted)
16854         (thread_to_thread_object, delete_thread_object)
16855         (build_inferior_list, gdbpy_selected_inferior): Update.
16856         * python/py-infthread.c (create_thread_object): Update.  Also fail
16857         if inferior_to_inferior_object fails.
16858
16859 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16860
16861         * inferior.h (class inferior) <displaced_step_state>: New field.
16862         * infrun.h (struct displaced_step_state): Move here from
16863         infrun.c.  Initialize fields, add constructor.
16864         <inf>: Remove field.
16865         <reset>: New method.
16866         * infrun.c (struct displaced_step_inferior_state): Move to
16867         infrun.h.
16868         (displaced_step_inferior_states): Remove.
16869         (get_displaced_stepping_state): Adust.
16870         (displaced_step_in_progress_any_inferior): Adjust.
16871         (displaced_step_in_progress_thread): Adjust.
16872         (displaced_step_in_progress): Adjust.
16873         (add_displaced_stepping_state): Remove.
16874         (get_displaced_step_closure_by_addr): Adjust.
16875         (remove_displaced_stepping_state): Remove.
16876         (infrun_inferior_exit): Call displaced_step_state.reset.
16877         (use_displaced_stepping): Don't check for NULL.
16878         (displaced_step_prepare_throw): Call
16879         get_displaced_stepping_state.
16880         (displaced_step_fixup): Don't check for NULL.
16881         (prepare_for_detach): Don't check for NULL.
16882
16883 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16884
16885         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16886          in case of call that did not complete.
16887
16888 2019-01-02  Andrey Utkin  <autkin@undo.io>
16889
16890         * symfile.c (find_separate_debug_file): Fix search of debug files for
16891         remote debuggee.
16892
16893 2019-01-02  Tom Tromey  <tom@tromey.com>
16894
16895         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16896         indentation.
16897         * python/py-frame.c (frapy_older): Remove cast.
16898         (frapy_newer): Likewise.
16899         * python/py-breakpoint.c (local_setattro): Remove cast.
16900         * python/py-arch.c (archpy_name): Remove local variable.
16901         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16902
16903 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16904
16905         * unittests/basic_string_view/element_access/char/empty.cc:
16906         Fix year range in copyright header.
16907
16908 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16909
16910         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16911         Delete.
16912         <operator==>: Update with for removed field.
16913         <hash>: Likewise.
16914         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16915         <isa_features>: ...this.
16916         <abi_features>: New field.
16917         (riscv_isa_flen): Update comment.
16918         (riscv_abi_xlen): New declaration.
16919         (riscv_abi_flen): New declaration.
16920         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16921         isa_features.
16922         (riscv_abi_xlen): New function.
16923         (riscv_isa_flen): Update to get answer from isa_features.
16924         (riscv_abi_flen): New function.
16925         (riscv_has_fp_abi): Update to get answer from abi_features.
16926         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16927         xlen and flen.
16928         (riscv_call_info) <xlen, flen>: Update comment.
16929         (riscv_call_arg_struct): Remove invalid assertions
16930         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16931         is removed.
16932         (riscv_gdbarch_init): Gather isa features and abi features
16933         separately, ensure both match on the gdbarch when reusing an old
16934         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16935         a target with 64-bit float hardware.
16936
16937 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16938
16939         * source.c (search_command_helper): Stop reverse search
16940         when line 1 has been searched.
16941
16942 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16943
16944         * record-full.c (record_full_base_target::close): Rewrite
16945         record_full_core_buf_list free logic.
16946
16947 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16948
16949         * break-catch-syscall.c (print_one_catch_syscall): xfree
16950         the last text.
16951
16952 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16953
16954         * top.c (print_gdb_version): Update Copyright year in version
16955         message.
16956
16957 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16958
16959         Update copyright year range in all GDB files.
16960
16961 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16962
16963         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16964
16965 For older changes see ChangeLog-2018.
16966 \f
16967 Local Variables:
16968 mode: change-log
16969 left-margin: 8
16970 fill-column: 74
16971 version-control: never
16972 coding: utf-8
16973 End:
16974