gdb/ChangeLog

   1 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
   4
   5 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
   6
   7         * tui/tui-layout.h (class tui_layout_base): Add virtual
   8         destructor.
   9
  10 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
  11
  12         * infcmd.c (prepare_one_step): Step over skipped inline functions.
  13         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
  14         (process_event_stop_test): Keep stepping over skipped inline functions.
  15
  16 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  17
  18         * jit.c (struct gdb_block) <next>: Remove field.
  19         (struct gdb_symtab) <~gdb_symtab>: Remove.
  20         <blocks>: Change type to std::forward_list<gdb_block>.
  21         (compare_block): Remove.
  22         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
  23         block at the beginning, don't mind about sorting.
  24         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
  25         before using it.
  26
  27 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  28
  29         * jit.c (struct gdb_block): Add constructor, initialize
  30         real_block and next fields.
  31         <name>: Change type to gdb::unique_xmalloc_ptr.
  32         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
  33         (jit_block_open_impl): Allocate gdb_block with new.
  34         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
  35
  36 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  37
  38         * jit.c: Include forward_list.
  39         (struct gdb_symtab) <next>: Remove field.
  40         (struct gdb_object) <symtabs>: Change type to
  41         std::forward_list<gdb_symtab>.
  42         (jit_object_open_impl): Allocate gdb_object with new.
  43         (jit_symtab_open_impl): Adjust to std::forward_list.
  44         (finalize_symtab): Don't delete symtab.
  45         (jit_object_close_impl):  Adjust to std::forward_list.  Free
  46         gdb_object with delete.
  47
  48 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  49
  50         * jit.c (struct gdb_symtab): Add constructor, destructor,
  51         initialize fields.
  52         <linetable>: Change type to unique_xmalloc_ptr.
  53         <file_name>: Change type to std::string.
  54         (jit_symtab_open_impl): Allocate gdb_symtab with new.
  55         (jit_symtab_line_mapping_add_impl): Adjust.
  56         (finalize_symtab): Adjust, call delete on stab.
  57
  58 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  59
  60         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
  61
  62 2019-12-16  Tom Tromey  <tromey@adacore.com>
  63
  64         * windows-nat.c (windows_nat_target::attach): Update.
  65         * remote.c (extended_remote_target::attach): Update.
  66         * procfs.c (procfs_target::attach): Update.
  67         * nto-procfs.c (nto_procfs_target::attach): Update.
  68         (nto_procfs_target::create_inferior): Update.
  69         * inf-ptrace.c (inf_ptrace_target::attach): Update.
  70         * gnu-nat.c (gnu_nat_target::attach): Update.
  71         (gnu_nat_target::detach): Update.
  72         * darwin-nat.c (darwin_nat_target::attach): Update.
  73         * corefile.c (get_exec_file): Constify result.  Remove extraneous
  74         return.
  75         * bsd-kvm.c (bsd_kvm_target_open): Update.
  76         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
  77
  78 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
  79
  80         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
  81         (we no longer need to include time.h before pathmax.h)
  82
  83 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
  84
  85         * ada-exp.y (write_ambiguous_var): Update.
  86         * coffread.c (process_coff_symbol): Update.
  87         * ctfread.c (ctf_add_enum_member_cb): Update.
  88         (new_symbol): Update.
  89         * dwarf2read.c (fixup_go_packaging): Update.
  90         (new_symbol): Update.
  91         * language.c (language_alloc_type_symbol): Update.
  92         * mdebugread.c (new_symbol): Update.
  93         * minsyms.c (minimal_symbol_reader::record_full): Update.
  94         * psymtab.c (add_psymbol_to_bcache): Update.
  95         * stabsread.c (define_symbol): Update.
  96         (read_enum_type): Update.
  97         * symtab.c (symbol_set_language): Make this a member function...
  98         (general_symbol_info::set_language): ... here.
  99         * symtab.h (struct general_symbol_info) <set_language>: New function.
 100         (SYMBOL_SET_LANGUAGE): Remove.
 101         (symbol_set_language): Remove.
 102
 103 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 104
 105         * ada-lang.c (ada_add_block_symbols): Update.
 106         (ada_collect_symbol_completion_matches): Update.
 107         * ax-gdb.c (gen_expr): Update.
 108         * block.c (block_lookup_symbol): Update.
 109         (block_lookup_symbol_primary): Update.
 110         (block_find_symbol): Update.
 111         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 112         * dbxread.c (process_one_symbol): Update.
 113         * dictionary.c (insert_symbol_hashed): Update.
 114         (collate_pending_symbols_by_language): Update.
 115         (mdict_add_symbol): Update.
 116         * dwarf-index-write.c (write_psymbols): Update.
 117         * dwarf2read.c (fixup_go_packaging): Update.
 118         * findvar.c (read_var_value): Update.
 119         * ft32-tdep.c (ft32_skip_prologue): Update.
 120         * go-lang.c (go_symbol_package_name): Update.
 121         * language.h (scoped_switch_to_sym_language_if_auto::
 122         scoped_switch_to_sym_language_if_auto): Update.
 123         * linespec.c (find_method): Update.
 124         (find_label_symbols_in_block): Update.
 125         * mdebugread.c (parse_symbol): Update.
 126         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 127         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 128         (minimal_symbol_reader::install): Update.
 129         * moxie-tdep.c (moxie_skip_prologue): Update.
 130         * parse.c (parse_exp_in_context): Update.
 131         * psymtab.c (psymbol_name_matches): Update.
 132         (match_partial_symbol): Update.
 133         (lookup_partial_symbol): Update.
 134         (psymbol_hash): Update.
 135         (psymbol_compare): Update.
 136         * python/py-framefilter.c (extract_sym): Update.
 137         (py_print_single_arg): Update.
 138         * stabsread.c (define_symbol): Update.
 139         * stack.c (print_frame_arg): Update.
 140         (find_frame_funname): Update.
 141         (info_frame_command_core): Update.
 142         * symfile.c (set_initial_language): Update.
 143         * symtab.c (symbol_set_demangled_name): Update.
 144         (symbol_get_demangled_name): Update.
 145         (symbol_set_language): Update.
 146         (symbol_find_demangled_name): Update.
 147         (symbol_set_names): Update.
 148         (general_symbol_info::natural_name): Update.
 149         (general_symbol_info::demangled_name): Update.
 150         (general_symbol_info::search_name): Update.
 151         (symbol_matches_search_name): Update.
 152         (eq_symbol_entry): Update.
 153         (iterate_over_symbols): Update.
 154         (completion_list_add_symbol): Update.
 155         (completion_list_add_msymbol): Update.
 156         (completion_list_add_fields): Update.
 157         * symtab.h (struct general_symbol_info) <language>: New function.
 158         <language>: Rename to...
 159         <m_language>: ...this.
 160         (SYMBOL_LANGUAGE): Remove.
 161         (MSYMBOL_LANGUAGE): Remove.
 162         (struct symbol) <ctor>: Update.
 163         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 164
 165 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 166
 167         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 168         set the language of sym.
 169         * language.c (language_alloc_type_symbol): Likewise.
 170
 171 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 172
 173         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 174         PR gdb/23613
 175         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 176         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 177         (core_target_open): Use 'gdb_abspath'.
 178         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 179         'current_directory == NULL' case.
 180         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 181         explain what happens when 'current_directory' is NULL.
 182         * go32-nat.c (go32_nat_target::wait): Check if
 183         'current_directory' is NULL before call to 'chdir'.
 184         * source.c (add_path): Use 'gdb_abspath'.
 185         * top.c: Include 'gdbsupport/pathstuff.h'.
 186         (init_history): Use 'gdb_abspath'.
 187         (set_history_filename): Likewise.
 188         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 189         (tfile_target_open): Use 'gdb_abspath'.
 190
 191 2019-12-13  Tom Tromey  <tromey@adacore.com>
 192
 193         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 194         warning or error.
 195
 196 2019-12-13  Tom Tromey  <tromey@adacore.com>
 197
 198         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 199
 200 2019-12-13  Tom Tromey  <tromey@adacore.com>
 201
 202         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 203
 204 2019-12-13  Tom Tromey  <tromey@adacore.com>
 205
 206         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 207
 208 2019-12-13  Tom Tromey  <tromey@adacore.com>
 209
 210         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 211         (string_vappendf): Add ARI comment.
 212
 213 2019-12-13  Tom Tromey  <tromey@adacore.com>
 214
 215         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 216         floatformat_to_double.
 217         * target-float.c (host_float_ops<T>::from_target): Add ARI
 218         comment.
 219
 220 2019-12-13  Tom Tromey  <tromey@adacore.com>
 221
 222         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 223         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 224         ARI marker to abort.
 225         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 226
 227 2019-12-13  Tom Tromey  <tromey@adacore.com>
 228
 229         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 230
 231 2019-12-13  Tom Tromey  <tromey@adacore.com>
 232
 233         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 234
 235 2019-12-13  Tom Tromey  <tromey@adacore.com>
 236
 237         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 238         checks.
 239
 240 2019-12-13  Tom Tromey  <tromey@adacore.com>
 241
 242         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 243         end>: No longer "const".
 244
 245 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 246
 247         * jit.c: Fix indentation, replace spaces with tabs where
 248         applicable.
 249
 250 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 251
 252         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 253
 254 2019-12-12  Tom Tromey  <tom@tromey.com>
 255
 256         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 257         unique_ptr.
 258
 259 2019-12-12  Tom Tromey  <tom@tromey.com>
 260
 261         * progspace.h (objfile_list): New typedef.
 262         (class unwrapping_objfile_iterator)
 263         (struct unwrapping_objfile_range): Newl
 264         (struct program_space) <objfiles_range>: Change type.
 265         <objfiles>: Change return type.
 266         <add_objfile>: Change type of "objfile" parameter.
 267         <objfiles_list>: Now a list of shared_ptr.
 268         * progspace.c (program_space::add_objfile): Change type of
 269         "objfile".  Update.
 270         (program_space::remove_objfile): Update.
 271         * objfiles.h (struct objfile) <~objfile>: Make public.
 272         * objfiles.c (objfile::make): Update.
 273         (objfile::unlink): Don't call delete.
 274
 275 2019-12-12  Tom Tromey  <tom@tromey.com>
 276
 277         * symfile.c (symbol_file_clear): Update.
 278         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 279         method.
 280         * progspace.c (program_space::free_all_objfiles): New method.
 281         * objfiles.h (free_all_objfiles): Don't declare.
 282         * objfiles.c (free_all_objfiles): Move to program_space.
 283
 284 2019-12-12  Tom Tromey  <tom@tromey.com>
 285
 286         * progspace.c (program_space::add_objfile)
 287         (program_space::remove_objfile): Update.
 288         (program_space::multi_objfile_p): Remove.
 289         * objfiles.h (struct objfile) <next>: Remove.
 290         * objfiles.c (objfile::objfile): Update.
 291         (put_objfile_before): Update.
 292         (unlink_objfile): Update.
 293         * progspace.h (object_files): Remove.
 294         (struct program_space) <objfiles_head>: Remove.
 295         <objfiles_list>: New member.
 296         <objfiles_range, objfiles_safe_range>: Change type.
 297         (objfiles): Change return type.
 298         (objfiles_safe): Update.
 299         (multi_objfile_p): Rewrite and inline.
 300         (object_files): Remove macro.
 301
 302 2019-12-12  Tom Tromey  <tom@tromey.com>
 303
 304         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 305         second constructor.
 306         (basic_safe_range): New class.
 307
 308 2019-12-12  Tom Tromey  <tom@tromey.com>
 309
 310         * progspace.c (program_space::multi_objfile_p): New method.
 311         * printcmd.c (info_symbol_command): Update.
 312         * maint.c (maintenance_translate_address): Update.
 313         * objfiles.h (MULTI_OBJFILE_P): Remove.
 314         * progspace.h (struct program_space) <multi_objfile_p>: New
 315         method.
 316
 317 2019-12-12  Tom Tromey  <tom@tromey.com>
 318
 319         * progspace.h (struct program_space) <remove_objfile>: Declare.
 320         * progspace.c (program_space::remove_objfile): New method.
 321         * objfiles.c (unlink_objfile): Remove.
 322         (objfile::unlink): Call remove_objfile.
 323         (objfile): Don't call unlink_objfile.
 324
 325 2019-12-12  Tom Tromey  <tom@tromey.com>
 326
 327         * progspace.h (struct program_space) <add_objfile>: Declare
 328         method.
 329         * progspace.c (program_space::add_objfile): New method.
 330         * objfiles.c (~objfile): Don't unlink objfile.
 331         (put_objfile_before): Remove.
 332         (add_separate_debug_objfile): Don't call put_objfile_before.
 333         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 334         the per-program-space data.
 335
 336 2019-12-12  Tom Tromey  <tom@tromey.com>
 337
 338         * symfile.c (syms_from_objfile_1): Use objfile_up.
 339         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 340         method.
 341         (reread_symbols): Use objfile_up.
 342         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 343         unlink method.
 344         * objfiles.h (struct objfile) <~objfile>: Now private.
 345         <unlink>: New method.
 346         (struct objfile_deleter): New.
 347         (objfile_up): New typedef.
 348         * objfiles.c (objfile::unlink): New method.
 349         (free_objfile_separate_debug, free_all_objfiles)
 350         (objfile_purge_solibs): Use it.
 351         * jit.c (jit_unregister_code): Remove.
 352         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 353         objfile.
 354         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 355         objfile.
 356         * compile/compile-object-load.c (compile_object_load): Use
 357         objfile_up.
 358
 359 2019-12-12  Tom Tromey  <tom@tromey.com>
 360
 361         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 362         objfile::make.
 363         * objfiles.h (struct objjfile) <make>: No longer inline.
 364         (add_separate_debug_objfile): Don't declare.
 365         * objfiles.c (add_separate_debug_objfile): Now static.
 366         (objfile::make): Move from objfiles.h.  Call
 367         add_separate_debug_objfile.  Add "parent" parameter.
 368
 369 2019-12-12  Tom Tromey  <tom@tromey.com>
 370
 371         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 372         * objfiles.h (struct objfile): Make constructor private.
 373         <make>: New static method.
 374         * jit.c (jit_object_close_impl): Update.
 375
 376 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 377
 378         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 379         gdb::byte_vector.
 380
 381 2019-12-12  Tom Tromey  <tromey@adacore.com>
 382
 383         * xml-support.c (xml_fetch_content_from_file): Don't call
 384         malloc_failure.
 385         * utils.h (class gdb_argv): Remove malloc_failure comment.
 386         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 387
 388 2019-12-12  Tom Tromey  <tromey@adacore.com>
 389
 390         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 391         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 392         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 393         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 394         * riscv-ravenscar-thread.c: New file.
 395         * riscv-ravenscar-thread.h: New file.
 396         * riscv-tdep.c (riscv_gdbarch_init): Call
 397         register_riscv_ravenscar_ops.
 398
 399 2019-12-12  Tom Tromey  <tromey@adacore.com>
 400
 401         * gdbsupport/thread-pool.c (set_thread_name): Use
 402         ATTRIBUTE_UNUSED.
 403
 404 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 405
 406         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 407         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 408         macros.
 409
 410 2019-12-11  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-win.c (tui_set_win_height_command): Call
 413         tui_adjust_window_height.
 414         (tui_adjust_win_heights, new_height_ok): Remove.
 415         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 416         * tui/tui-layout.c (tui_adjust_window_height): New function.
 417
 418 2019-12-11  Tom Tromey  <tom@tromey.com>
 419
 420         * tui/tui-win.c (tui_resize_all): Remove code, call
 421         tui_apply_current_layout.
 422
 423 2019-12-11  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 426         * tui/tui-layout.c (standard_layouts, applied_layout): New
 427         globals.
 428         (tui_apply_current_layout): New function.
 429         (show_layout): Set applied_layout.  Call
 430         tui_apply_current_layout.
 431         (show_source_command, show_disasm_command)
 432         (show_source_disasm_command, show_data)
 433         (show_source_or_disasm_and_command): Remove.
 434         (initialize_layouts): New function.
 435         (_initialize_tui_layout): Call initialize_layouts.
 436
 437 2019-12-11  Tom Tromey  <tom@tromey.com>
 438
 439         * tui/tui-layout.h (class tui_layout_base)
 440         (class tui_layout_window, class tui_layout_split): New.
 441         * tui/tui-layout.c (tui_get_window_by_name)
 442         (tui_layout_window::clone, tui_layout_window::apply)
 443         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 444         (tui_layout_split::add_window, tui_layout_split::clone)
 445         (tui_layout_split::get_sizes)
 446         (tui_layout_split::set_weights_from_heights)
 447         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 448         functions.
 449         (tui_layout_split::add_split, tui_layout_split::add_split)
 450         (tui_layout_split::set_weights_from_heights)
 451         (tui_layout_split::set_weights_from_heights): New functions.
 452
 453 2019-12-11  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 456         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 457         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 458         * tui/tui-data.h (struct tui_point): Remove.
 459         (struct tui_gen_win_info) <origin>: Remove.
 460         <x, y>: New fields.
 461         * tui/tui-command.c (tui_cmd_window::resize): Update.
 462
 463 2019-12-11  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 466         Implement.
 467         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 468         Implement.
 469         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 470         method.
 471         (struct tui_win_info) <min_height>: Implement.
 472
 473 2019-12-11  Tom Tromey  <tom@tromey.com>
 474
 475         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 476         (struct tui_win_info) <can_box>: Update.
 477
 478 2019-12-11  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 481         method.
 482         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 483         method.
 484         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 485         method.
 486         (struct tui_win_info) <max_height>: Now override.
 487
 488 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 489
 490         * NEWS: Create a new section for the next release branch.
 491         Rename the section of the current branch, now that it has
 492         been cut.
 493
 494 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 495
 496         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 497         * version.in: Bump version to 10.0.50.DATE-git.
 498
 499 2019-12-11  Tom Tromey  <tromey@adacore.com>
 500
 501         PR build/25268:
 502         * gdbsupport/thread-pool.c (set_thread_name): New function.
 503         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 504         (thread_pool::thread_function): Call set_thread_name.
 505
 506 2019-12-11  Tom Tromey  <tromey@adacore.com>
 507
 508         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 509         bfd_get_signed_8.
 510
 511 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 512
 513         * NEWS: Document -raw-values option and the related setting commands.
 514         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 515         only set it on when /r is given.
 516         * valprint.c (value_print_option_defs): New element raw-values.
 517         * Makefile.in: Add the new file.
 518
 519 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 520
 521         * gdbsupport/safe-strerror.c: Supress the unused function warning
 522         for select_strerror_r.
 523
 524 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 525
 526         * config.in: Regenerate.
 527         * configure: Regenerate.
 528         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 529         safe_strerror instead of strerror.
 530         * gdbsupport/common.m4: Don't check for strerror.
 531         * gdbsupport/safe-strerror.c: Support both the glibc version
 532         of strerror_r and the XSI version.
 533
 534 2019-12-10  Tom Tromey  <tromey@adacore.com>
 535
 536         * ada-typeprint.c (print_choices): Use a single "?".
 537         (print_variant_part): Print "?" if the discriminant name
 538         is not known.
 539
 540 2019-12-10  George Barrett  <bob@bob131.so>
 541
 542         Fix scripted probe breakpoints.
 543         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 544         declaration forward.
 545         (breakpoint_ops_for_event_location_type)
 546         (breakpoint_ops_for_event_location): Add function definitions.
 547         (break_command_1, trace_command): Use
 548         breakpoint_ops_for_event_location.
 549         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 550         declarations.
 551         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 552         breakpoint_ops_for_event_location.
 553         * python/py-breakpoint.c (bppy_init): Use
 554         breakpoint_ops_for_event_location.
 555
 556 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 557
 558         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 559         when ranking an lvalue argument for an rvalue parameter.
 560
 561 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 562
 563         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 564         template argument for scoped_restore_tmpl from bool to int.
 565
 566 2019-12-07  Keith Seitz  <keiths@redhat.com>
 567
 568         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 569         (build_id_to_debug_bfd): Make static, rewriting to use
 570         build_id_to_bfd_suffix.
 571         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 572         adding `suffix' parameter. Append SUFFIX to file names
 573         when searching for matching files.
 574         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 575         (build_id_to_exec_bfd): Likewise.
 576         * build-id.h (build_id_to_debug_bfd): Clarify that function
 577         searches for BFD of debug info file.
 578         (build_id_to_exec_bfd): Declare.
 579         * corelow.c: Include build-id.h.
 580         (locate_exec_from_corefile_build_id): New function.
 581         (core_target_open): If no executable BFD is found,
 582         search for a core file BFD using build-id.
 583
 584 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 585
 586         * bcache.c: Put in namespace gdb.
 587         * bcache.h: Likewise.
 588         * gdbtypes.c (check_types_worklist): Update.
 589         (types_deeply_equal): Update.
 590         * macrotab.c (struct macro_table) <bcache>: Update.
 591         (new_macro_table): Update.
 592         * macrotab.h (struct bcache): Put this forward declaration
 593         inside namespace gdb.
 594         (new_macro_table): Update.
 595         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 596         Update.
 597         <macro_cache>: Update.
 598         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 599
 600 2019-12-06  Tom de Vries  <tdevries@suse.de>
 601
 602         PR symtab/24971
 603         * block.c (best_symbol, better_symbol): New function.
 604         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 605         decl.
 606
 607 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 608
 609         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 610         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 611         for ranking see-through reference cases.
 612
 613 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 614         * stack.c (faas_command): Check a command is provided.
 615         * thread.c (taas_command, tfaas_command): Likewise.
 616
 617 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 618         * inferior.c (prune_inferiors):  Only call delete_inferior,
 619         Do not modify the inferior list.
 620
 621 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 622
 623         * c-exp.y: Update calls to lookup_typename,
 624         lookup_signed_typename and lookup_unsigned_typename.
 625         * c-lang.c (evaluate_subexp_c): Likewise.
 626         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 627         Likewise.
 628         * eval.c (binop_promote): Likewise.
 629         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 630         (lookup_unsigned_typename): Likewise.
 631         (lookup_signed_typename): Likewise.
 632         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 633         (lookup_signed_typename): Likewise.
 634         (lookup_typename): Likewise.
 635         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 636         lookup_typename, lookup_signed_typename,
 637         lookup_unsigned_typename.
 638         * m2-exp.y: Likewise.
 639         * printcmd.c (printf_wide_c_string): Likewise.
 640         (ui_printf): Likewise.
 641         * python/py-type.c (typy_lookup_typename): Likewise.
 642         * python/py-xmethods.c (python_xmethod_worker::invoke):
 643         Likewise.
 644         * rust-exp.y: Likewise.
 645
 646 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 647
 648         * configure.nat (obsd64): Add missing files x86-nat.o and
 649         nat/x86-dregs.o.
 650
 651 2019-12-04  Tom Tromey  <tom@tromey.com>
 652
 653         * valprint.c (val_print_string): Use metadata_style.
 654         * go-valprint.c (print_go_string): Use metadata style.
 655         * p-valprint.c (pascal_object_print_static_field): Use metadata
 656         style.
 657         * cp-valprint.c (cp_print_static_field): Use metadata style.
 658
 659 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 660             Chris January  <chris.january@arm.com>
 661
 662         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 663         tokens.
 664         (typebase): New patterns for complex, single/double precision, and
 665         single/double complex.
 666         (f77_keywords): Change token for complex keyword, and add single,
 667         double, and precision keywords.
 668
 669 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 670
 671         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 672         "info io_registers".
 673
 674 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 675
 676         * regcache.c (cooked_read_test): Initialize thread list of
 677         mock_inferior.
 678
 679 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 680
 681         * aarch64-linux-tdep.c: Remove includes.
 682
 683 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 684
 685         * aarch64-tdep.c: Remove includes.
 686
 687 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 688
 689         * filtered-iterator.h (filtered_iterator) <operator==,
 690         operator!=>: Compare wrapped iterators, not wrapped pointers.
 691         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 692         unittests/filtered_iterator-selftests.c.
 693         * unittests/filtered_iterator-selftests.c: New file.
 694
 695 2019-12-04  Tom Tromey  <tromey@adacore.com>
 696
 697         * gdbtypes.c (create_range_type): Inherit endianity
 698         from base type.
 699
 700 2019-12-04  Tom Tromey  <tromey@adacore.com>
 701
 702         * ada-lang.c (decode_constrained_packed_array)
 703         (ada_value_assign, value_assign_to_component): Update.
 704         * dwarf2loc.c (rw_pieced_value, access_memory)
 705         (dwarf2_compile_expr_to_ax): Update.
 706         * dwarf2read.c (dwarf2_add_field): Update.
 707         * eval.c (evaluate_subexp_standard): Update.
 708         * gdbarch.c, gdbarch.h: Rebuild.
 709         * gdbarch.sh (bits_big_endian): Remove.
 710         * gdbtypes.h (union field_location): Update comment.
 711         * target-descriptions.c (make_gdb_type): Update.
 712         * valarith.c (value_bit_index): Update.
 713         * value.c (struct value) <bitpos>: Update comment.
 714         (unpack_bits_as_long, modify_field): Update.
 715         * value.h (value_bitpos): Update comment.
 716
 717 2019-12-04  Tom Tromey  <tromey@adacore.com>
 718
 719         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 720         endian-ness.
 721
 722 2019-12-04  Tom Tromey  <tromey@adacore.com>
 723
 724         * dwarf2read.c (dwarf2_init_float_type)
 725         (dwarf2_init_complex_target_type): Add byte_order parameter.
 726         (read_base_type): Compute byte order earlier.
 727         * gdbtypes.c (init_float_type): Add byte_order parameter.
 728         * gdbtypes.h (init_float_type): Add byte_order parameter.
 729
 730 2019-12-04  Tom Tromey  <tromey@adacore.com>
 731
 732         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 733
 734 2019-12-04  Tom Tromey  <tromey@adacore.com>
 735
 736         * dwarf2read.c (process_structure_scope): Initialize
 737         "discr_offset".
 738
 739 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 740
 741         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 742         add it into the search spec.
 743         (parse_max_results_option): New function.
 744         (mi_info_functions_or_variables): Parse -max-results flag and pass
 745         it to mi_symbol_info.
 746         (mi_cmd_symbol_info_modules): Likewise.
 747         (mi_cmd_symbol_info_types): Likewise.
 748         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 749         return type to bool, change result container into a set, and don't
 750         add new results if we have enough already.
 751         (global_symbol_searcher::add_matching_msymbols): Change return
 752         type to bool, and don't add new results if we have enough already.
 753         (sort_search_symbols_remove_dups): Delete.
 754         (global_symbol_searcher::search): Early exit from search loop when
 755         we have enough results.  Use a std::set to collect the results
 756         from calling add_matching_symbols.
 757         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 758         member function.
 759         (global_symbol_searcher) <m_max_search_results>: New member
 760         variable.
 761         (global_symbol_searcher) <add_matching_symbols>: Update header
 762         comment and change return type to bool.
 763         (global_symbol_searcher) <add_matching_msymbols>: Update header
 764         comment and change return type to bool.
 765
 766 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 767
 768         * symtab.c (symbol_search::compare_search_syms): Update header
 769         comment.
 770         (global_symbol_searcher::is_suitable_msymbol): New function.
 771         (global_symbol_searcher::expand_symtabs): New function.
 772         (global_symbol_searcher::add_matching_symbols): New function.
 773         (global_symbol_searcher::add_matching_msymbols): New function.
 774         (global_symbol_searcher::search): Move most of the content
 775         into the new functions above, and call them as needed.
 776         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 777         function.
 778         (global_symbol_searcher) <add_matching_symbols>: New member
 779         function.
 780         (global_symbol_searcher) <add_matching_msymbols>: New member
 781         function.
 782         (global_symbol_searcher) <is_suitable_msymbol>: New member
 783         function.
 784
 785 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 786
 787         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 788         -symbol-info-module-variables entries.
 789         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 790         (mi_cmd_symbol_info_module_variables): Declare.
 791         * mi/mi-symbol-cmds.c
 792         (module_symbol_search_iterator): New typedef.
 793         (output_module_symbols_in_single_module_and_file): New function.
 794         (output_module_symbols_in_single_module): New function.
 795         (mi_info_module_functions_or_variables): New function.
 796         (mi_cmd_symbol_info_module_functions): New function.
 797         (mi_cmd_symbol_info_module_variables): New function.
 798         * NEWS: Mention new MI command.
 799
 800 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 801
 802         * bcache.c (hash): Remove.
 803         (hash_continue): Remove.
 804         * bcache.h (hash): Remove.
 805         (hash_continue): Remove.
 806         (struct bcache) <ctor>: Update.
 807         * psymtab.c (psymbol_hash): Update.
 808         * stabsread.c (hashname): Update.
 809         * utils.h (fast_hash): Add an argument for a start value,
 810         defaulting to zero.
 811
 812 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 813         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 814         (destroy_block_symbol_cache): New function.
 815         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 816         (resize_symbol_cache): Likewise.
 817
 818 2019-12-02  Tom Tromey  <tom@tromey.com>
 819
 820         * unittests/tui-selftests.c (run_tests): Make conditional.
 821         (_initialize_tui_selftest): Make conditional.
 822
 823 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 824
 825         * aix-thread.c (debug_aix_thread): Change type to bool.
 826
 827 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 828
 829         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 830
 831 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 832
 833         * dwarf2read.c (read_tag_string_type): Read the fields required to
 834         make a dynamic string, and possibly create a dynamic range for the
 835         string.
 836         (attr_to_dynamic_prop): Setup is_reference based on the type of
 837         attribute being processed.
 838         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 839         (resolve_dynamic_array): Rename to...
 840         (resolve_dynamic_array_or_string): ...this, update header comment,
 841         and accept TYPE_CODE_STRING.
 842         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 843
 844 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 845
 846         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 847         of its implementation from...
 848         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 849         the new function.
 850
 851 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 852
 853         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 854         create a range with stride where appropriate.
 855         * f-valprint.c: Include 'gdbarch.h'.
 856         (f77_print_array_1): Take the stride into account when walking the
 857         array.  Also convert the stride into addressable units.
 858         * gdbtypes.c (create_range_type): Initialise the stride to
 859         constant zero.
 860         (create_range_type_with_stride): New function, initialise the
 861         range as normal, and then setup the stride.
 862         (has_static_range): Include the stride here.  Also change the
 863         return type to bool.
 864         (create_array_type_with_stride): Consider the range stride if the
 865         array isn't given its own stride.
 866         (resolve_dynamic_range): Resolve the stride if needed.
 867         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 868         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 869         (TYPE_BIT_STRIDE): Define.
 870         (TYPE_ARRAY_BIT_STRIDE): Define.
 871         (create_range_type_with_stride): Declare.
 872         * valarith.c (value_subscripted_rvalue): Take range stride into
 873         account when walking the array.
 874
 875 2019-12-01  Tom Tromey  <tom@tromey.com>
 876
 877         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 878         specially.
 879
 880 2019-12-01  Tom Tromey  <tom@tromey.com>
 881
 882         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 883         \0.
 884         * unittests/tui-selftests.c: New file.
 885         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 886
 887 2019-12-01  Tom Tromey  <tom@tromey.com>
 888
 889         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 890
 891 2019-12-01  Tom Tromey  <tom@tromey.com>
 892
 893         * NEWS: Document new settings.
 894         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 895         * tui/tui-win.c (_initialize_tui_win): Add border style
 896         observers.
 897         * tui/tui-io.h (tui_apply_style): Declare.
 898         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 899         longer static.
 900         (apply_ansi_escape, tui_set_reverse_mode): Update.
 901         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 902         Add "skip_intensity" parameter.
 903         <changed>: New member.
 904         <do_set_value>: Declare.
 905         (tui_border_style, tui_active_border_style): Declare.
 906         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 907         globals.
 908         (cli_style_option): Initialize "changed".
 909         (cli_style_option::do_set_value): New function.
 910         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 911         parameter.  Update.
 912         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 913         (_initialize_cli_style): Update.  Create TUI border style
 914         commands.
 915
 916 2019-12-01  Tom Tromey  <tom@tromey.com>
 917
 918         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 919         parameter.
 920         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 921         parameter.
 922         * tui/tui-win.h (compact_source): Declare.
 923         * tui/tui-win.c (compact_source): New global.
 924         (tui_set_compact_source, tui_show_compact_source): New functions.
 925         (_initialize_tui_win): Add "compact-source" setting.
 926         * tui/tui-source.c (tui_source_window::set_contents): Handle
 927         compact_source setting.
 928         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 929         * NEWS: Document new setting.
 930
 931 2019-11-30  Tom Tromey  <tom@tromey.com>
 932
 933         * dwarf2read.c (dwarf2_add_field): Include field offset when
 934         computing variant part length.
 935
 936 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 937         * NEWS:  Mention define-prefix.  Tell that command names can now
 938         contain a . character.
 939
 940 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 941
 942         * command.h (valid_cmd_char_p): Declare.
 943         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 944         the check of valid command char.
 945         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 946         valid_cmd_char_p.
 947         * cli/cli-script.c (validate_comname): Likewise.
 948         * completer.c (gdb_completer_command_word_break_characters):
 949         Do not remove . from the word break char, update comments.
 950         (complete_line_internal_1): Use valid_cmd_char_p.
 951         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 952         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 953
 954 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 955
 956         * cli/cli-script.c (do_define_command): Ensure a redefined
 957         prefix command is kept as a prefix command.
 958         (define_prefix_command): New function.
 959         (show_user_1): Report user defined prefixes.
 960         (_initialize_cli_script):  Create the new 'define-prefix' command.
 961         Add completers for 'define' and 'document'.
 962         * top.c (execute_command):  If command is a user-defined prefix only
 963         command, report the list of commands for this prefix command.
 964
 965 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 966
 967         * valops.c (find_oload_champ): Improve debug output.
 968
 969 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 970
 971         * valops.c (find_oload_champ): Print part of debug messages
 972         before the badness vector is std::move'd.
 973
 974 2019-11-28  Tom Tromey  <tom@tromey.com>
 975
 976         * value.c (creal_internal_fn): Fix comment.
 977
 978 2019-11-28  Tom Tromey  <tom@tromey.com>
 979
 980         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 981         flag_bound_evaluated>: Now unsigned.
 982
 983 2019-11-28  Tom Tromey  <tom@tromey.com>
 984
 985         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 986         declare.
 987
 988 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 989
 990         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 991         debug output.
 992         * jit.c (jit_unregister_code): Add debug print to match
 993         `jit_register_code`.
 994
 995 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 996
 997         * NEWS: Mention the new multithreaded symbol loading.
 998
 999 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1000
1001         * maint.c (n_worker_threads): Default to 0.
1002         (worker_threads_disabled): New function.
1003         * maint.h (worker_threads_disabled): New function.
1004         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1005         here if worker_threads_disabled () is true.
1006         (minimal_symbol_reader::install): Skip all threading if
1007         worker_threads_disabled () is true.
1008
1009 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1010
1011         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1012         hash code if possible.
1013         (add_minsym_to_demangled_hash_table): Likewise.
1014         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1015         on the background thread.
1016         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1017         Add these fields.
1018
1019 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1020
1021         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1022         of the mangled name on the background thread.
1023         * symtab.c (symbol_set_names): Allow passing in the hash of the
1024         linkage_name.
1025         * symtab.h (symbol_set_names): Likewise.
1026
1027 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1028
1029         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1030         physnames are computed for inherited DIEs.
1031
1032 2019-11-27  Tom Tromey  <tromey@adacore.com>
1033
1034         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1035         backslashes.
1036         * cp-support.c: Remove unnecessary backslashes.
1037
1038 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1039
1040         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1041         with sym->set_linkage_name.
1042         * coffread.c (coff_read_enum_type): Likewise.
1043         * mdebugread.c (parse_symbol): Likewise.
1044         * stabsread.c (patch_block_stabs): Likewise.
1045         (define_symbol): Likewise.
1046         (read_enum_type): Likewise.
1047         (common_block_end): Likewise.
1048         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1049         function.
1050         (SYMBOL_SET_LINKAGE_NAME): Remove.
1051         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1052         with sym->set_linkage_name.
1053
1054 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1055
1056         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1057         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1058         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1059         * NEWS: Mention new MI command.
1060
1061 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1062
1063         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1064         '-symbol-info-types', and '-symbol-info-variables'.
1065         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1066         (mi_cmd_symbol_info_types): Declare.
1067         (mi_cmd_symbol_info_variables): Declare.
1068         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1069         (output_debug_symbol): New function.
1070         (output_nondebug_symbol): New function.
1071         (mi_symbol_info): New function.
1072         (mi_info_functions_or_variables): New function.
1073         (mi_cmd_symbol_info_functions): New function.
1074         (mi_cmd_symbol_info_types): New function.
1075         (mi_cmd_symbol_info_variables): New function.
1076         * NEWS: Mention new commands.
1077
1078 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * symtab.c (symbol_to_info_string): New function, most content
1081         moved from print_symbol_info, but updated to return a std::string.
1082         (print_symbol_info): Update to use symbol_to_info_string and print
1083         returned string.
1084         * symtab.h (symbol_to_info_string): Declare new function.
1085
1086 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1087
1088         * python/python.c (gdbpy_rbreak): Convert to using
1089         global_symbol_searcher.
1090         * symtab.c (file_matches): Convert return type to bool, change
1091         file list to std::vector, update header comment.
1092         (search_symbols): Rename to...
1093         (global_symbol_searcher::search): ...this and update now its
1094         a member function of global_symbol_searcher.  Take account of the
1095         changes to file_matches.
1096         (symtab_symbol_info): Convert to using global_symbol_searcher.
1097         (rbreak_command): Likewise.
1098         (search_module_symbols): Likewise.
1099         * symtab.h (enum symbol_search): Update comment.
1100         (search_symbols): Remove declaration.
1101         (class global_symbol_searcher): New class.
1102
1103 2019-11-26  Tom Tromey  <tromey@adacore.com>
1104
1105         * cp-support.c (_initialize_cp_support): Conditionally initialize
1106         gdb_demangle_attempt_core_dump.
1107
1108 2019-11-26  Tom Tromey  <tom@tromey.com>
1109
1110         * python/py-function.c (fnpy_init): Update.
1111         * value.h (add_internal_function): Adjust declaration.
1112         * value.c (function_destroyer): Remove.
1113         (do_add_internal_function): Don't set destroyer or copy name.
1114         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1115         Set name_allocated.
1116         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1117         (cmdpy_init): Set name_allocated.
1118         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1119         member.
1120         (~cmd_list_element): Free "name" if needed.
1121
1122 2019-11-26  Tom Tromey  <tom@tromey.com>
1123
1124         * value.h (add_internal_function): Add new overload.  Move
1125         documentation from value.h.
1126         * value.c (do_add_internal_function): New function.
1127         (add_internal_function): Use it.  Add new overload.
1128         (function_destroyer): Don't free doc.
1129         * python/py-function.c (fnpy_init): Update.
1130
1131 2019-11-26  Tom Tromey  <tom@tromey.com>
1132
1133         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1134         (cmdpy_init): Set "doc_allocated".
1135
1136 2019-11-26  Tom Tromey  <tom@tromey.com>
1137
1138         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1139         name of worker thread.
1140         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1141         pthread_setname_np.
1142         * configure, config.in: Rebuild.
1143
1144 2019-11-26  Tom Tromey  <tom@tromey.com>
1145
1146         * python/python.c (class gdbpy_gil): New.
1147         (struct gdbpy_event): Add constructor, destructor, operator().
1148         (gdbpy_post_event): Use run_on_main_thread.
1149         (gdbpy_initialize_events): Remove.
1150         (do_start_initialization): Update.
1151
1152 2019-11-26  Tom Tromey  <tom@tromey.com>
1153
1154         * NEWS: Add entry.
1155         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1156         commands.  Call update_thread_pool_size.
1157         (update_thread_pool_size, maintenance_set_worker_threads): New
1158         functions.
1159         (n_worker_threads): New global.
1160
1161 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1162             Tom Tromey  <tom@tromey.com>
1163
1164         * minsyms.c (minimal_symbol_reader::install): Use
1165         parallel_for_each.
1166         * gdbsupport/parallel-for.h: New file.
1167         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1168
1169 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1170             Tom Tromey  <tom@tromey.com>
1171
1172         * gdbsupport/thread-pool.h: New file.
1173         * gdbsupport/thread-pool.c: New file.
1174         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1175         (HFILES_NO_SRCDIR): Add thread-pool.h.
1176
1177 2019-11-26  Tom Tromey  <tom@tromey.com>
1178
1179         * event-top.h (thread_local_segv_handler): Declare.
1180         * event-top.c (thread_local_segv_handler): New global.
1181         (install_handle_sigsegv, handle_sigsegv): New functions.
1182         (async_init_signals): Install SIGSEGV handler.
1183         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1184         thread-local.
1185         (report_failed_demangle): New function.
1186         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1187         handler-setting code, instead use segv_handler.  Run warning code
1188         on main thread.
1189
1190 2019-11-26  Tom Tromey  <tom@tromey.com>
1191
1192         * run-on-main-thread.c: New file.
1193         * run-on-main-thread.h: New file.
1194         * unittests/main-thread-selftests.c: New file.
1195         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1196         main-thread-selftests.c.
1197         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1198         (COMMON_SFILES): Add run-on-main-thread.c.
1199
1200 2019-11-26  Tom Tromey  <tom@tromey.com>
1201
1202         * main.c (setup_alternate_signal_stack): Remove.
1203         (captured_main_1): Use gdb::alternate_signal_stack.
1204         * gdbsupport/alt-stack.h: New file.
1205
1206 2019-11-26  Tom Tromey  <tom@tromey.com>
1207
1208         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1209         Remove comment.
1210         (save_original_signals_state, restore_original_signals_state): Use
1211         gdb_sigmask.
1212         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1213         (_initialize_linux_nat): Use gdb_sigmask.
1214         * guile/guile.c (_initialize_guile): Use block_signals.
1215         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1216         * gdbsupport/gdb-sigmask.h: New file.
1217         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1218         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1219         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1220         pthread_sigmask.
1221         * configure, config.in: Rebuild.
1222         * gdbsupport/block-signals.h: New file.
1223
1224 2019-11-26  Tom Tromey  <tom@tromey.com>
1225
1226         * acinclude.m4: Include ax_pthread.m4.
1227         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1228         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1229         (CLIBS): Use PTHREAD_LIBS.
1230         (aclocal_m4_deps): Add ax_pthread.m4.
1231         * config.in, configure: Rebuild.
1232         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1233
1234 2019-11-26  Tom Tromey  <tom@tromey.com>
1235
1236         * symtab.h (struct minimal_symbol) <name_set>: New member.
1237         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1238         Don't call symbol_set_names.
1239         (minimal_symbol_reader::install): Call symbol_set_names.
1240
1241 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1242
1243         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1244         restore_active_ext_lang, as GIL is needed for (indirectly)
1245         called PyOS_InterruptOccurred.
1246
1247 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1248
1249         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1250         definition.
1251
1252 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1253
1254         * remote-sim.c (simulator_command): Make static, remove
1255         declaration.
1256
1257 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1258
1259         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1260         static.
1261         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1262         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1263         (main): Likewise.
1264         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1265         (main): Likewise.
1266         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1267         (main): Likewise.
1268         * unittests/basic_string_view/element_access/char/1.cc (test01):
1269         Likewise.
1270         (main): Likewise.
1271         * unittests/basic_string_view/element_access/char/empty.cc (main):
1272         Likewise.
1273         * unittests/basic_string_view/element_access/char/front_back.cc
1274         (test01): Likewise.
1275         (main): Likewise.
1276         * unittests/basic_string_view/inserters/char/2.cc (test05):
1277         Likewise.
1278         (main): Likewise.
1279         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1280         (test01): Likewise.
1281         (main): Likewise.
1282         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1283         (test01): Likewise.
1284         (main): Likewise.
1285         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1286         Likewise.
1287         * unittests/basic_string_view/operations/compare/char/1.cc
1288         (test01): Likewise.
1289         (main): Likewise.
1290         * unittests/basic_string_view/operations/compare/char/13650.cc
1291         (test01): Likewise.
1292         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1293         Likewise.
1294         (main): Likewise.
1295         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1296         Likewise.
1297         (main): Likewise.
1298         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1299         Likewise.
1300         (main): Likewise.
1301         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1302         Likewise.
1303         (main): Likewise.
1304         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1305         Likewise.
1306         (main): Likewise.
1307         * unittests/basic_string_view/operations/find/char/4.cc (main):
1308         Likewise.
1309         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1310         Likewise.
1311         (main): Likewise.
1312         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1313         Likewise.
1314         (main): Likewise.
1315         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1316         Likewise.
1317         (main): Likewise.
1318         * unittests/basic_string_view/operations/substr/char/1.cc
1319         (test01): Likewise.
1320         (main): Likewise.
1321         * unittests/basic_string_view/operators/char/2.cc (main):
1322         Likewise.
1323         * unittests/optional/assignment/1.cc (test): Likewise.
1324         * unittests/optional/assignment/2.cc (test): Likewise.
1325         * unittests/optional/assignment/3.cc (test): Likewise.
1326         * unittests/optional/assignment/4.cc (test): Likewise.
1327         * unittests/optional/assignment/5.cc (test): Likewise.
1328         * unittests/optional/assignment/6.cc (test): Likewise.
1329         * unittests/optional/assignment/7.cc (test): Likewise.
1330         * unittests/optional/cons/copy.cc (test): Likewise.
1331         * unittests/optional/cons/default.cc (test): Likewise.
1332         * unittests/optional/cons/move.cc (test): Likewise.
1333         * unittests/optional/cons/value.cc (test): Likewise.
1334         * unittests/optional/in_place.cc (test): Likewise.
1335         * unittests/optional/observers/1.cc (test): Likewise.
1336         * unittests/optional/observers/2.cc (test): Likewise.
1337
1338 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1339
1340         * tui-win.h (tui_set_var_cmd): Remove.
1341         * tui-win.c (tui_set_var_cmd): Make static.
1342
1343 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1344
1345         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1346         rbreak_command_wrapper): Remove.
1347         * symtab.c (rbreak_command_wrapper): Remove.
1348
1349 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1350
1351         * inferior.h (info_terminal_command): Remove declaration.
1352         * inflow.c (info_terminal_command): Make static.
1353
1354 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1355
1356         * inferior.c (exit_inferior_silent): Remove.
1357
1358 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1359
1360         * dictionary.c (dict_empty, mdict_empty): Remove.
1361         * dictionary.c (mdict_empty): Remove.
1362
1363 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1364
1365          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1366          (arc_insn_get_memory_offset): Likewise.
1367          (arc_insn_dump): Likewise.
1368          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1369          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1370          * dictionary.c (dict_iterator_next): Likewise.
1371          (dict_iter_match_first): Likewise.
1372          (dict_iter_match_next): Likewise.
1373          * f-lang.c (evaluate_subexp_f): Likewise.
1374          * hppa-tdep.c (hppa_read_pc): Likewise.
1375          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1376          * parse.c (write_exp_elt_msym): Likewise.
1377          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1378          * remote.c (remote_packet_size): Likewise.
1379          (remote_notif_stop_parse): Likewise.
1380          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1381          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1382          * source.c (prepare_path_for_appending): Likewise.
1383          * sparc64-linux-tdep.c
1384          (sparc64_linux_handle_segmentation_fault); Likewise.
1385          * stack.c (frame_selection_by_function_completer): Likewise.
1386
1387 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1388
1389         * completer.c (set_gdb_completion_word_break_characters):
1390         Remove.
1391
1392 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1393
1394         * dwarf-index-write.c: Include dwarf-index-write.h.
1395         * mi/mi-interp.c: Include mi/mi-interp.h.
1396
1397 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1398
1399         * aarch32-tdep.c: Include aarch32-tdep.h.
1400         * aarch32-tdep.h: Forward-declare struct target_desc.
1401
1402 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1403
1404         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1405         strerror.
1406         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1407         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1408
1409 2019-11-25  Tom de Vries  <tdevries@suse.de>
1410
1411         * contrib/words.sh: Add -c option.
1412
1413 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1414
1415         * solib.c (solib_find_1): Change int to bool.
1416         (exec_file_find): Change int to bool.
1417         (solib_find): Change int to bool.
1418         (solib_read_symbols): Change int to bool.
1419         (solib_used): Change int to bool.
1420         (solib_add): Change int to bool.
1421         (info_sharedlibrary_command): Change int to bool.
1422         (solib_contains_address_p): Change int to bool.
1423         (solib_keep_data_in_core): Change int to bool.
1424         (in_solib_dynsym_resolve_code): Change int to bool.
1425         (reload_shared_libraries_1): Change int to bool.
1426         (gdb_sysroot_changed): Change int to bool.
1427         * solib.h (solib_read_symbols): Change int to bool.
1428         (solib_contains_address_p): Change int to bool.
1429         (solib_keep_data_in_core): Change int to bool.
1430         (in_solib_dynsym_resolve_code): Change int to bool.
1431         (libpthread_name_p): Change int to bool.
1432
1433 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1434
1435         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1436         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1437         (remote_packet_max_chars): New static global.
1438         (show_remote_packet_max_chars): New function.
1439         (remote_target::putpkt_binary): Adjust to use new
1440         remote_packet_max_chars option.
1441         (remote_target::getpkt_or_notif_sane_1): Likewise.
1442         (_initialize_remote): Register new remote-packet-max-chars option.
1443
1444 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1445
1446         * m68k-linux-nat.c: Include gdbarch.h.
1447
1448 2019-11-24  Tom Tromey  <tom@tromey.com>
1449
1450         * symfile.c (read_symbols): Update.
1451         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1452         bool.
1453         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1454         (psym_lookup_symbol, psym_find_last_source_symtab)
1455         (psym_forget_cached_source_info, psym_print_stats)
1456         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1457         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1458         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1459         (psym_find_compunit_symtab_by_address)
1460         (maintenance_print_psymbols, maintenance_info_psymtabs)
1461         (maintenance_check_psymtabs): Update.
1462         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1463         bool.
1464
1465 2019-11-22  Tom Tromey  <tom@tromey.com>
1466
1467         * observable.h: Update comments.
1468
1469 2019-11-22  Tom Tromey  <tromey@adacore.com>
1470
1471         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1472         (print_ada_task_info): Don't try to fetch thread id if task is not
1473         alive.
1474
1475 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1476
1477         * ada-exp.y: Update.
1478         * ada-lang.c (sort_choices): Update.
1479         (ada_print_symbol_signature): Update.
1480         (resolve_subexp): Update.
1481         (ada_parse_renaming): Update.
1482         (ada_read_renaming_var_value): Update.
1483         (lesseq_defined_than): Update.
1484         (remove_extra_symbols): Update.
1485         (remove_irrelevant_renamings): Update.
1486         (ada_add_block_symbols): Update.
1487         (ada_collect_symbol_completion_matches): Update.
1488         (ada_is_renaming_symbol): Update.
1489         (aggregate_assign_from_choices): Update.
1490         (ada_evaluate_subexp): Update.
1491         (ada_has_this_exception_support): Update.
1492         (ada_is_non_standard_exception_sym): Update.
1493         (ada_add_exceptions_from_frame): Update.
1494         (ada_add_global_exceptions): Update.
1495         (ada_print_subexp): Update.
1496         * ax-gdb.c (gen_var_ref): Update.
1497         (gen_maybe_namespace_elt): Update.
1498         (gen_expr_for_cast): Update.
1499         (gen_expr): Update.
1500         * block.h: Update.
1501         * blockframe.c (find_pc_partial_function): Update.
1502         * breakpoint.c (print_breakpoint_location): Update.
1503         (update_static_tracepoint): Update.
1504         * btrace.c (ftrace_print_function_name): Update.
1505         (ftrace_function_switched): Update.
1506         * buildsym.c (find_symbol_in_list): Update.
1507         * c-exp.y: Update.
1508         * c-typeprint.c (c_print_typedef): Update.
1509         (c_type_print_template_args): Update.
1510         * cli/cli-cmds.c (edit_command): Update.
1511         (list_command): Update.
1512         (print_sal_location): Update.
1513         * coffread.c (patch_opaque_types): Update.
1514         (process_coff_symbol): Update.
1515         (coff_read_enum_type): Update.
1516         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1517         (convert_one_symbol): Update.
1518         (hash_symname): Update.
1519         (eq_symname): Update.
1520         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1521         * compile/compile-cplus-types.c (debug_print_scope): Update.
1522         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1523         * compile/compile-object-load.c (get_out_value_type): Update.
1524         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1525         (search_symbol_list): Update.
1526         (cp_lookup_symbol_imports_or_template): Update.
1527         * cp-support.c (overload_list_add_symbol): Update.
1528         * ctfread.c (psymtab_to_symtab): Update.
1529         * dbxread.c (cp_set_block_scope): Update.
1530         * dictionary.c (iter_match_first_hashed): Update.
1531         (iter_match_next_hashed): Update.
1532         (insert_symbol_hashed): Update.
1533         (iter_match_next_linear): Update.
1534         * dictionary.h: Update.
1535         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1536         (locexpr_describe_location_piece): Update.
1537         (locexpr_describe_location_1): Update.
1538         (locexpr_generate_c_location): Update.
1539         (loclist_describe_location): Update.
1540         (loclist_generate_c_location): Update.
1541         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1542         (read_func_scope): Update.
1543         (process_enumeration_scope): Update.
1544         (new_symbol): Update.
1545         (dwarf2_const_value): Update.
1546         (dwarf2_symbol_mark_computed): Update.
1547         * eval.c (evaluate_funcall): Update.
1548         (evaluate_subexp_standard): Update.
1549         * expprint.c (print_subexp_standard): Update.
1550         (dump_subexp_body_standard): Update.
1551         * f-valprint.c (info_common_command_for_block): Update.
1552         * findvar.c (get_hosting_frame): Update.
1553         (default_read_var_value): Update.
1554         * go-lang.c (go_symbol_package_name): Update.
1555         * guile/scm-block.c (bkscm_print_block_smob): Update.
1556         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1557         (gdbscm_symbol_name): Update.
1558         (gdbscm_symbol_linkage_name): Update.
1559         (gdbscm_symbol_print_name): Update.
1560         * infcall.c (get_function_name): Update.
1561         * infcmd.c (jump_command): Update.
1562         (finish_command): Update.
1563         * infrun.c (insert_exception_resume_breakpoint): Update.
1564         * linespec.c (canonicalize_linespec): Update.
1565         (create_sals_line_offset): Update.
1566         (convert_linespec_to_sals): Update.
1567         (complete_label): Update.
1568         (find_label_symbols_in_block): Update.
1569         * m2-typeprint.c (m2_print_typedef): Update.
1570         * mdebugread.c (mdebug_reg_to_regnum): Update.
1571         (parse_symbol): Update.
1572         (mylookup_symbol): Update.
1573         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1574         (list_args_or_locals): Update.
1575         * objc-lang.c (compare_selectors): Update.
1576         (info_selectors_command): Update.
1577         (compare_classes): Update.
1578         (info_classes_command): Update.
1579         (find_imps): Update.
1580         * p-typeprint.c (pascal_print_typedef): Update.
1581         * printcmd.c (build_address_symbolic): Update.
1582         (info_address_command): Update.
1583         (print_variable_and_value): Update.
1584         * python/py-framefilter.c (extract_sym): Update.
1585         (py_print_single_arg): Update.
1586         * python/py-symbol.c (sympy_str): Update.
1587         (sympy_get_name): Update.
1588         (sympy_get_linkage_name): Update.
1589         * python/python.c (gdbpy_rbreak): Update.
1590         * record-btrace.c (btrace_get_bfun_name): Update.
1591         (btrace_call_history): Update.
1592         * rust-lang.c (rust_print_typedef): Update.
1593         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1594         * stabsread.c (stab_reg_to_regnum): Update.
1595         (define_symbol): Update.
1596         (read_enum_type): Update.
1597         (common_block_end): Update.
1598         (cleanup_undefined_types_1): Update.
1599         (scan_file_globals): Update.
1600         * stack.c (print_frame_arg): Update.
1601         (print_frame_args): Update.
1602         (find_frame_funname): Update.
1603         (info_frame_command_core): Update.
1604         (iterate_over_block_locals): Update.
1605         (print_block_frame_labels): Update.
1606         (do_print_variable_and_value): Update.
1607         (iterate_over_block_arg_vars): Update.
1608         (return_command): Update.
1609         * symmisc.c (dump_symtab_1): Update.
1610         (print_symbol): Update.
1611         * symtab.c (eq_symbol_entry): Update.
1612         (symbol_cache_dump): Update.
1613         (lookup_language_this): Update.
1614         (find_pc_sect_line): Update.
1615         (skip_prologue_sal): Update.
1616         (symbol_search::compare_search_syms): Update.
1617         (treg_matches_sym_type_name): Update.
1618         (search_symbols): Update.
1619         (print_symbol_info): Update.
1620         (rbreak_command): Update.
1621         (completion_list_add_symbol): Update.
1622         (find_gnu_ifunc): Update.
1623         (get_symbol_address): Update.
1624         (search_module_symbols): Update.
1625         (info_module_subcommand): Update.
1626         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1627         (SYMBOL_LINKAGE_NAME): Remove.
1628         (SYMBOL_DEMANGLED_NAME): Remove.
1629         (SYMBOL_PRINT_NAME): Remove.
1630         (SYMBOL_SEARCH_NAME): Remove.
1631         * tracepoint.c (set_traceframe_context): Update.
1632         (validate_actionline): Update.
1633         (collection_list::collect_symbol): Update.
1634         (encode_actions_1): Update.
1635         (info_scope_command): Update.
1636         (print_one_static_tracepoint_marker): Update.
1637         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1638         * valops.c (address_of_variable): Update.
1639         (find_overload_match): Update.
1640         (find_oload_champ): Update.
1641
1642 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1643
1644         * ada-lang.c (ada_lookup_simple_minsym): Update.
1645         (ada_collect_symbol_completion_matches): Update.
1646         * ada-tasks.c (read_atcb): Update.
1647         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1648         (amd64_windows_skip_trampoline_code): Update.
1649         * arm-tdep.c (skip_prologue_function): Update.
1650         (arm_skip_stack_protector): Update.
1651         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1652         (arm_wince_skip_main_prologue): Update.
1653         * ax-gdb.c (gen_expr): Update.
1654         * block.c (call_site_for_pc): Update.
1655         * blockframe.c (find_pc_partial_function): Update.
1656         * breakpoint.c (set_breakpoint_location_function): Update.
1657         * btrace.c (ftrace_print_function_name): Update.
1658         (ftrace_function_switched): Update.
1659         * c-valprint.c (print_unpacked_pointer): Update.
1660         * coffread.c (coff_symfile_read): Update.
1661         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1662         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1663         * dwarf-index-write.c (write_psymbols): Update.
1664         * dwarf2loc.c (call_site_to_target_addr): Update.
1665         (func_verify_no_selftailcall): Update.
1666         (tailcall_dump): Update.
1667         (call_site_find_chain_1): Update.
1668         (dwarf_expr_reg_to_entry_parameter): Update.
1669         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1670         * eval.c (evaluate_funcall): Update.
1671         (evaluate_subexp_standard): Update.
1672         (evaluate_subexp_for_sizeof): Update.
1673         * expprint.c (print_subexp_standard): Update.
1674         (dump_subexp_body_standard): Update.
1675         * frame.c (get_prev_frame_always_1): Update.
1676         * frv-tdep.c (frv_skip_main_prologue): Update.
1677         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1678         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1679         (gnuv3_get_typename_from_type_info): Update.
1680         (gnuv3_skip_trampoline): Update.
1681         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1682         * i386-tdep.c (i386_skip_main_prologue): Update.
1683         (i386_pe_skip_trampoline_code): Update.
1684         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1685         * infcall.c (get_function_name): Update.
1686         * linespec.c (minsym_found): Update.
1687         * linux-fork.c (info_checkpoints_command): Update.
1688         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1689         (m32c_m16c_pointer_to_address): Update.
1690         * maint.c (maintenance_translate_address): Update.
1691         * minsyms.c (add_minsym_to_hash_table): Update.
1692         (add_minsym_to_demangled_hash_table): Update.
1693         (lookup_minimal_symbol_mangled): Update.
1694         (lookup_minimal_symbol_demangled): Update.
1695         (lookup_minimal_symbol_linkage): Update.
1696         (lookup_minimal_symbol_text): Update.
1697         (lookup_minimal_symbol_by_pc_name): Update.
1698         (minimal_symbol_is_less_than): Update.
1699         (compact_minimal_symbols): Update.
1700         (build_minimal_symbol_hash_tables): Update.
1701         (find_solib_trampoline_target): Update.
1702         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1703         (mips_skip_pic_trampoline_code): Update.
1704         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1705         * objc-lang.c (info_selectors_command): Update.
1706         (info_classes_command): Update.
1707         (find_methods): Update.
1708         (find_imps): Update.
1709         * p-valprint.c (pascal_val_print): Update.
1710         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1711         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1712         * printcmd.c (build_address_symbolic): Update.
1713         (info_symbol_command): Update.
1714         * psymtab.c (psymbol_name_matches): Update.
1715         (match_partial_symbol): Update.
1716         (lookup_partial_symbol): Update.
1717         (print_partial_symbols): Update.
1718         (sort_pst_symbols): Update.
1719         (maintenance_check_psymtabs): Update.
1720         * python/py-framefilter.c (py_print_frame): Update.
1721         * python/python.c (gdbpy_rbreak): Update.
1722         * record-btrace.c (btrace_get_bfun_name): Update.
1723         (btrace_call_history): Update.
1724         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1725         (rs6000_skip_trampoline_code): Update.
1726         * sol-thread.c (info_cb): Update.
1727         * stabsread.c (scan_file_globals): Update.
1728         * stack.c (find_frame_funname): Update.
1729         (info_frame_command_core): Update.
1730         * symmisc.c (dump_msymbols): Update.
1731         * symtab.c (symbol_natural_name): Rename to..,
1732         (general_symbol_info::natural_name): ...this.
1733         (symbol_demangled_name): Rename to...
1734         (general_symbol_info::demangled_name): ...this.
1735         (symbol_search_name): Rename to...
1736         (general_symbol_info::search_name): ...this.
1737         (symbol_matches_search_name): Update.
1738         (find_pc_sect_line): Update.
1739         (skip_prologue_sal): Update.
1740         (search_symbols): Update.
1741         (print_msymbol_info): Update.
1742         (rbreak_command): Update.
1743         (completion_list_add_msymbol): Update.
1744         (completion_list_objc_symbol): Update.
1745         (get_msymbol_address): Update.
1746         * symtab.h (struct general_symbol_info): Add member functions
1747         natural_name (), linkage_name (), print_name (), demangled_name (),
1748         and search_name ().
1749         (SYMBOL_NATURAL_NAME): Update.
1750         (symbol_natural_name): Move to a member function on general_symbol_info.
1751         (SYMBOL_DEMANGLED_NAME): Update.
1752         (symbol_demangled_name): Move to a member function on
1753         general_symbol_info.
1754         (SYMBOL_SEARCH_NAME): Update.
1755         (symbol_search_name): Move to a member function on general_symbol_info.
1756         (MSYMBOL_NATURAL_NAME): Remove.
1757         (MSYMBOL_LINKAGE_NAME): Remove.
1758         (MSYMBOL_PRINT_NAME): Remove.
1759         (MSYMBOL_DEMANGLED_NAME): Remove.
1760         (MSYMBOL_SEARCH_NAME): Remove.
1761         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1762
1763 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1764
1765         * symtab.c (create_demangled_names_hash): Use per_bfd->
1766         minimal_symbol_count for computing the initial size, if greater
1767         than our default size.
1768
1769 2019-11-22  Tom de Vries  <tdevries@suse.de>
1770
1771         * contrib/words.sh: Improve words extraction.
1772
1773 2019-11-22  Tom de Vries  <tdevries@suse.de>
1774
1775         * contrib/words.sh: Combine sed invocations.
1776
1777 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1778
1779         * Makefile.in: Update.
1780         * demangle.c: Rename to...
1781         * gdb-demangle.c: ..this.
1782         (is_cplus_marker): Change return type to bool.
1783         (_initialize_demangler): Rename to...
1784         (_initialize_gdb_demangle): ...this.
1785         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1786         * symtab.h (demangle): Remove declaration; instead include
1787         gdb-demangle.h.
1788
1789 2019-11-21  Tom Tromey  <tromey@adacore.com>
1790
1791         * gdbsupport/format.c (format_pieces): Parse %I64d.
1792         * unittests/format_pieces-selftests.c (test_windows_formats): New
1793         function.
1794         (run_tests): Call it.
1795
1796 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1797
1798         Byte reverse display of variables with DW_END_big, DW_END_little
1799         (DW_AT_endianity) dwarf attributes if different than the native
1800         byte order.
1801         * ada-lang.c (ada_value_binop):
1802         Use type_byte_order instead of gdbarch_byte_order.
1803         * ada-valprint.c (printstr):
1804         (ada_val_print_string):
1805         * ada-lang.c (value_pointer):
1806         (ada_value_binop):
1807         Use type_byte_order instead of gdbarch_byte_order.
1808         * c-lang.c (c_get_string):
1809         Use type_byte_order instead of gdbarch_byte_order.
1810         * c-valprint.c (c_val_print_array):
1811         Use type_byte_order instead of gdbarch_byte_order.
1812         * cp-valprint.c (cp_print_class_member):
1813         Use type_byte_order instead of gdbarch_byte_order.
1814         * dwarf2loc.c (rw_pieced_value):
1815         Use type_byte_order instead of gdbarch_byte_order.
1816         * dwarf2read.c (read_base_type): Handle DW_END_big,
1817         DW_END_little
1818         * f-lang.c (f_get_encoding):
1819         Use type_byte_order instead of gdbarch_byte_order.
1820         * findvar.c (default_read_var_value):
1821         Use type_byte_order instead of gdbarch_byte_order.
1822         * gdbtypes.c (check_types_equal):
1823         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1824         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1825         and TYPE_ENDIANITY_LITTLE if set.
1826         (type_byte_order): new function.
1827         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1828         (struct main_type) <flag_endianity_not_default>:
1829         New field.
1830         (type_byte_order): New function.
1831         * infcmd.c (default_print_one_register_info):
1832         Use type_byte_order instead of gdbarch_byte_order.
1833         * p-lang.c (pascal_printstr):
1834         Use type_byte_order instead of gdbarch_byte_order.
1835         * p-valprint.c (pascal_val_print):
1836         Use type_byte_order instead of gdbarch_byte_order.
1837         * printcmd.c (print_scalar_formatted):
1838         Use type_byte_order instead of gdbarch_byte_order.
1839         * solib-darwin.c (darwin_current_sos):
1840         Use type_byte_order instead of gdbarch_byte_order.
1841         * solib-svr4.c (solib_svr4_r_ldsomap):
1842         Use type_byte_order instead of gdbarch_byte_order.
1843         * stap-probe.c (stap_modify_semaphore):
1844         Use type_byte_order instead of gdbarch_byte_order.
1845         * target-float.c (target_float_same_format_p):
1846         Use type_byte_order instead of gdbarch_byte_order.
1847         * valarith.c (scalar_binop):
1848         (value_bit_index):
1849         Use type_byte_order instead of gdbarch_byte_order.
1850         * valops.c (value_cast):
1851         Use type_byte_order instead of gdbarch_byte_order.
1852         * valprint.c (generic_emit_char):
1853         (generic_printstr):
1854         (val_print_string):
1855         Use type_byte_order instead of gdbarch_byte_order.
1856         * value.c (unpack_long):
1857         (unpack_bits_as_long):
1858         (unpack_value_bitfield):
1859         (modify_field):
1860         (pack_long):
1861         (pack_unsigned_long):
1862         Use type_byte_order instead of gdbarch_byte_order.
1863         * findvar.c (unsigned_pointer_to_address):
1864         (signed_pointer_to_address):
1865         (unsigned_address_to_pointer):
1866         (address_to_signed_pointer):
1867         (default_read_var_value):
1868         (default_value_from_register):
1869         Use type_byte_order instead of gdbarch_byte_order.
1870         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1871         Use type_byte_order instead of gdbarch_byte_order.
1872         * riscv-tdep.c (riscv_print_one_register_info):
1873         Use type_byte_order instead of gdbarch_byte_order.
1874
1875 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1876
1877         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1878         (current_ui_gdb_stdin_ptr): Likewise.
1879         (current_ui_gdb_stderr_ptr): Likewise.
1880         (current_ui_gdb_stdlog_ptr): Likewise.
1881         (current_ui_current_uiout_ptr): Likewise.
1882         (gen_ret_current_ui_field_ptr): Remove.
1883
1884 2019-11-21  Tom de Vries  <tdevries@suse.de>
1885
1886         PR gdb/24956
1887         * cli/cli-script.c (execute_control_command): Only switch to
1888         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1889
1890 2019-11-19  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1893         Now static.  Change type of "name".
1894         (tui_set_win_height_command): Don't copy "arg".
1895         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1896         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1897
1898 2019-11-19  Ali Tamur <tamur@google.com>
1899
1900         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1901         "if (attr != nullptr)".
1902         (dwarf2_find_base_address): Likewise.
1903         (dwarf2_build_include_psymtabs): Likewise.
1904         (read_cutu_die_from_dwo): Likewise.
1905         (read_func_scope): Likewise.
1906         (read_call_site_scope): Likewise.
1907         (dwarf2_get_pc_bounds): Likewise.
1908         (dwarf2_record_block_ranges): Likewise.
1909         (dwarf2_add_field): Likewise.
1910         (dwarf2_add_member_fn): Likewise.
1911         (read_structure_type): Likewise.
1912         (read_enumeration_type): Likewise.
1913         (read_array_type): Likewise.
1914         (read_array_order): Likewise.
1915         (read_set_type): Likewise.
1916         (read_common_block): Likewise.
1917         (read_tag_reference_type): Likewise.
1918         (read_tag_string_type): Likewise.
1919         (read_subroutine_type): Likewise.
1920         (read_base_type): Likewise.
1921         (read_subrange_type): Likewise.
1922         (new_symbol): Likewise.
1923         (prepare_one_comp_unit): Likewise.
1924
1925 2019-11-19  Tom Tromey  <tromey@adacore.com>
1926
1927         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1928         result in error when DebugActiveProcess fails.
1929
1930 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1931             Pedro Alves  <palves@redhat.com>
1932
1933         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1934         * target.c (target_stack::push): Call 'unpush' if there's a
1935         target on top of the stack.
1936
1937 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1938
1939         * python/py-block.c (blpy_dealloc): Call tp_free.
1940         (blpy_block_syms_dealloc): Likewise.
1941         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1942         * python/py-inferior.c (infpy_dealloc): Likewise.
1943         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1944         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1945         * python/py-symbol.c (sympy_dealloc): Likewise.
1946         * python/py-symtab.c (stpy_dealloc): Likewise.
1947         * python/py-type.c (typy_iterator_dealloc): Likewise.
1948
1949 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1950
1951         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1952         constructor instead of using a class initializer.
1953
1954 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1955
1956         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1957         * configure: Regenerate.
1958         * configure.ac: Don't source common.host.
1959         * gdbsupport/common.host: Remove.
1960         * gdbsupport/mingw-strerror.c: Remove.
1961         * gdbsupport/posix-strerror.c: Rename to...
1962         * gdbsupport/safe-strerror.c: ...this.
1963
1964 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1965
1966         * maint.c (scoped_command_stats::print_time): Use localtime_r
1967         instead of localtime (provided through gnulib if necessary).
1968         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1969         of ctime.
1970
1971 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1972
1973         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1974         avoid compile errors.
1975
1976 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1977
1978         * config.in: Regenerate.
1979         * configure: Regenerate.
1980         * gdbsupport/common.m4: No longer check for strerror_r.
1981         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1982         POSIX version of strerror_r, now that gnulib provides it if
1983         necessary.
1984
1985 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1986
1987         * README (`configure' options): Update.
1988
1989 2019-11-14  Tom Tromey  <tromey@adacore.com>
1990
1991         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1992         expected type for the RHS if the LHS is a convenience variable.
1993
1994 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1995
1996         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1997         Provide explicit default and copy constructor.
1998
1999 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2000
2001         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2002         only call Py_INCREF (newbp) in the bppy_pending_object case.
2003
2004 2019-11-13  Tom Tromey  <tromey@adacore.com>
2005
2006         PR build/25182:
2007         * psympriv.h (partial_symbol): Remove static assert.
2008         * symtab.h (general_symbol_info, symbol): Remove static assert.
2009
2010 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2011
2012         * gdbsupport/format.c (format_pieces::format_pieces): Support
2013         printf 'z' size modifier.
2014         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2015         * printcmd.c (ui_printf):  Handle size_t_arg.
2016         * ui-out.c (ui_out::vmessage): Likewise.
2017         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2018         function.
2019         (run_tests): Call test_format_int_sizes.
2020
2021 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2022
2023         * ada-exp.y (write_ambiguous_var): Update.
2024         * buildsym.c (add_symbol_to_list): Update.
2025         * dwarf2read.c (read_variable): Update.
2026         (new_symbol): Update.
2027         * jit.c (finalize_symtab): Update.
2028         * language.c (language_alloc_type_symbol): Update.
2029         * symtab.c (fixup_symbol_section): Update.
2030         (initialize_objfile_symbol_1): Move code to...
2031         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2032         (allocate_symbol): Update.
2033         (allocate_template_symbol): Update.
2034         (get_symbol_address): Update.
2035         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2036         of having as a field, and add a constructor.
2037         (SYMBOL_VALUE): Update.
2038         (SYMBOL_VALUE_ADDRESS): Update.
2039         (SET_SYMBOL_VALUE_ADDRESS): Update.
2040         (SYMBOL_VALUE_BYTES): Update.
2041         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2042         (SYMBOL_BLOCK_VALUE): Update.
2043         (SYMBOL_VALUE_CHAIN): Update.
2044         (SYMBOL_LANGUAGE): Update.
2045         (SYMBOL_SECTION): Update.
2046         (SYMBOL_OBJ_SECTION): Update.
2047         (SYMBOL_SET_LANGUAGE): Update.
2048         (SYMBOL_SET_LINKAGE_NAME): Update.
2049         (SYMBOL_SET_NAMES): Update.
2050         (SYMBOL_NATURAL_NAME): Update.
2051         (SYMBOL_LINKAGE_NAME): Update.
2052         (SYMBOL_DEMANGLED_NAME): Update.
2053         (SYMBOL_SEARCH_NAME): Update.
2054         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2055         (struct symbol): Update.
2056         (struct template_symbol): Update.
2057         (struct rust_vtable_symbol): Update.
2058         * xcoffread.c (SYMBOL_DUP): Update.
2059
2060 2019-11-12  Tom Tromey  <tom@tromey.com>
2061
2062         * tui/tui-layout.c (show_layout): Set current_layout.
2063         (show_source_disasm_command, show_data)
2064         (show_source_or_disasm_and_command): Don't set current_layout.
2065
2066 2019-11-12  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2069
2070 2019-11-12  Tom Tromey  <tom@tromey.com>
2071
2072         * tui/tui-win.c (resize_message): New global.
2073         (show_tui_resize_message): New function.
2074         (tui_async_resize_screen): Print message if requested.
2075         (_initialize_tui_win): Add tui-resize-message setting.
2076         * NEWS: Add entry for new commands.
2077
2078 2019-11-11  Tom Tromey  <tom@tromey.com>
2079
2080         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2081         functions.
2082
2083 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2084
2085         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2086
2087 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2088
2089         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2090         function.
2091         * python/python-internal.h (gdbpy_lookup_static_symbols):
2092         Declare new function.
2093         * python/python.c (python_GdbMethods): Add
2094         gdb.lookup_static_symbols method.
2095         * NEWS: Mention gdb.lookup_static_symbols.
2096
2097 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2098
2099         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2100         static block of current object file first.  Also fix typo in
2101         header comment.
2102
2103 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2104
2105         * stack.c (set_last_displayed_sal): Delete.
2106         (last_displayed_sal_valid): Delete.
2107         (last_displayed_pspace): Delete.
2108         (last_displayed_addr): Delete.
2109         (last_displayed_symtab): Delete.
2110         (last_displayed_line): Delete.
2111         (class last_displayed_symtab_info_type): New.
2112         (last_displayed_symtab_info): New static global variable.
2113         (print_frame_info): Call methods on last_displayed_symtab_info.
2114         (clear_last_displayed_sal): Update header comment, and make use of
2115         last_displayed_symtab_info.
2116         (last_displayed_sal_is_valid): Likewise.
2117         (get_last_displayed_pspace): Likewise.
2118         (get_last_displayed_addr): Likewise.
2119         (get_last_displayed_symtab): Likewise.
2120         (get_last_displayed_line): Likewise.
2121         (get_last_displayed_sal): Likewise.
2122         * stack.h (clear_last_displayed_sal): Update header comment.
2123         (last_displayed_sal_is_valid): Likewise.
2124         (get_last_displayed_pspace): Likewise.
2125         (get_last_displayed_addr): Likewise.
2126         (get_last_displayed_symtab): Likewise.
2127         (get_last_displayed_line): Likewise.
2128         (get_last_displayed_sal): Likewise.
2129
2130 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2131
2132         * stack.c (frame_show_address): Convert return type to bool.
2133         * stack.h (frame_show_address): Likewise, and update header
2134         comment.
2135
2136 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2137
2138         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2139         * unittests/vec-utils-selftests.c: New file.
2140         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2141
2142 2019-11-10  Tom Tromey  <tom@tromey.com>
2143
2144         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2145         (tui_highlight_win): Likewise.
2146         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2147         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2148         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2149         Don't set can_highlight.
2150
2151 2019-11-10  Tom Tromey  <tom@tromey.com>
2152
2153         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2154         Remove unused declaration.
2155
2156 2019-11-08  Tom Tromey  <tromey@adacore.com>
2157
2158         * top.c (read_command_file): Update.
2159         (command_line_input): Make return type const.
2160         * python/py-gdb-readline.c: Update.
2161         * linespec.c (decode_line_2): Update.
2162         * defs.h (command_line_input): Make return type const.
2163         * cli/cli-script.c (read_next_line): Make return type const.
2164         * ada-lang.c (get_selections): Update.
2165
2166 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2167
2168         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2169         * mi/mi-main.c (output_cores): Likewise.
2170         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2171         (linux_xfer_osdata_modules): Likewise.
2172         * remote.c (register_remote_support_xml): Likewise.
2173         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2174         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2175
2176 2019-11-06  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui-interp.c: Don't include readline.h.
2179         * tui/tui-hooks.c: Don't include readline.h.
2180         * symmisc.c: Include tilde.h, not readline.h.
2181         * symfile.c: Include tilde.h, not readline.h.
2182         * source.c: Include tilde.h, not readline.h.
2183         * solib.c: Include tilde.h, not readline.h.
2184         * psymtab.c: Include tilde.h, not readline.h.
2185         * exec.c: Include tilde.h, not readline.h.
2186         * corelow.c: Include tilde.h, not readline.h.
2187         * cli/cli-dump.c: Include tilde.h, not readline.h.
2188         * cli/cli-cmds.c: Don't include readline.h.
2189
2190 2019-11-05  Tom Tromey  <tom@tromey.com>
2191
2192         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2193         (tui_disassemble): Set addr_size.
2194         (tui_disasm_window::set_contents): Use addr_size.
2195
2196 2019-11-05  Tom Tromey  <tom@tromey.com>
2197
2198         * rust-lang.c (rust_language_defn): Update.
2199         * python/py-value.c (valpy_string): Call c_get_string.
2200         * p-lang.c (pascal_language_defn): Update.
2201         * opencl-lang.c (opencl_language_defn): Update.
2202         * objc-lang.c (objc_language_defn): Update.
2203         * m2-lang.c (m2_language_defn): Update.
2204         * language.c (unknown_language_defn, auto_language_defn): Update.
2205         (default_get_string): Remove.
2206         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2207         * go-lang.c (go_language_defn): Update.
2208         * f-lang.c (f_language_defn): Update.
2209         * d-lang.c (d_language_defn): Update.
2210         * c-lang.c (c_language_defn, cplus_language_defn)
2211         (asm_language_defn, minimal_language_defn): Update.
2212         * ada-lang.c (ada_language_defn): Update.
2213         * language.h (struct language_defn) <la_get_string>: Remove.
2214         (LA_GET_STRING): Remove.
2215         (default_get_string): Don't declare.
2216
2217 2019-11-05  Tom Tromey  <tom@tromey.com>
2218
2219         * tui/tui-source.h (struct tui_source_window): Inline
2220         constructor.  Remove destructor.
2221         <style_changed, m_observable>: Move to superclass.
2222         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2223         (struct tui_source_window_base): Move private members to end.
2224         <style_changed, m_observable>: Move from tui_source_window.
2225         * tui/tui-winsource.c (tui_copy_source_line): Move from
2226         tui-source.c.  Rename from copy_source_line.  Add special handling
2227         for negative line number.
2228         (tui_source_window_base::style_changed): Move from
2229         tui_source_window.
2230         (tui_source_window_base): Register observer.
2231         (~tui_source_window_base): New.
2232         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2233         rename.
2234         (tui_source_window::set_contents): Use tui_copy_source_line.
2235         (tui_source_window::tui_source_window): Move to tui-source.h.
2236         (tui_source_window::~tui_source_window): Remove.
2237         (tui_source_window::style_changed): Move to superclass.
2238         * tui/tui-disasm.c (tui_disassemble): Create string file with
2239         styling, when possible.  Add "addr_size" parameter.
2240         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2241         Don't compute maximum size.
2242         (len_without_escapes): New function
2243
2244 2019-11-05  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2247         std::string.
2248         * tui/tui-winsource.c (tui_show_source_line): Update.
2249         * tui/tui-source.c (tui_source_window::set_contents): Update.
2250         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2251
2252 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2253
2254         * symtab.h (gdb_static_assert): Put && operator at the beginning
2255         of the line instead of the end.
2256
2257 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2258
2259         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2260         and sizeof (symbol).
2261         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2262
2263 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2264
2265         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2266         * configure.host: Mark *-*-solaris2.10* obsolete.
2267         * configure.tgt: Mark Solaris < 11 obsolete.
2268         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2269         Update target triplet.
2270
2271 2019-11-01  Tom Tromey  <tromey@adacore.com>
2272
2273         * utils.c (print_sys_errmsg): Simplify.
2274
2275 2019-11-01  Tom Tromey  <tromey@adacore.com>
2276
2277         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2278
2279 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2280
2281         * configure: Regenerate.
2282         * configure.ac: Remove check for strerror_r.
2283         * gdbsupport/common.m4: Check for strerror_r.
2284
2285 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2286
2287         PR gdb/25124
2288
2289         * arm-tdep.c (arm_per_objfile): Rename to ...
2290         (arm_per_bfd): ... this.
2291         (arm_objfile_data_key): Rename to ...
2292         (arm_bfd_data_key): ... this.
2293         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2294         data.
2295         (arm_record_special_symbol): Likewise.
2296
2297 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2298
2299         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2300         end.
2301         * c-typeprint.c (c_print_typedef): Likewise.
2302         * f-typeprint.c (f_print_typedef): Likewise.
2303         * m2-typeprint.c (m2_print_typedef): Likewise.
2304         * p-typeprint.c (pascal_print_typedef): Likewise.
2305         * rust-lang.c (rust_print_typedef): Likewise.
2306         * symtab.c (print_symbol_info): Print a newline after calling
2307         typedef_print.
2308
2309 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2310
2311         * symtab.c (info_module_cmdlist): New variable.
2312         (info_module_command): New function.
2313         (search_module_symbols): New function.
2314         (info_module_subcommand): New function.
2315         (struct info_modules_var_func_options): New struct.
2316         (info_modules_var_func_options_defs): New variable.
2317         (make_info_modules_var_func_options_def_group): New function.
2318         (info_module_functions_command): New function.
2319         (info_module_variables_command): New function.
2320         (info_module_var_func_command_completer): New function.
2321         (_initialize_symtab): Register new 'info module functions' and
2322         'info module variables' commands.
2323         * symtab.h (typedef symbol_search_in_module): New typedef.
2324         (search_module_symbols): Declare new function.
2325         * NEWS: Mention new commands.
2326
2327 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2328
2329         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2330         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2331         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2332         MODULES_DOMAIN.
2333         (scan_partial_symbols): Only create partial module symbols for non
2334         declarations.
2335         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2336         and MODULES_DOMAIN.
2337         * symtab.c (search_domain_name): Likewise.
2338         (search_symbols): Likewise.
2339         (print_symbol_info): Likewise.
2340         (symtab_symbol_info): Likewise.
2341         (info_modules_command): New function.
2342         (_initialize_symtab): Register 'info modules' command.
2343         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2344         * NEWS: Mention new 'info modules' command.
2345
2346 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2347
2348         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2349         and $_gdb_maint_setting_str.
2350
2351 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2352
2353         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2354         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2355         (str_value_from_setting, gdb_setting_str_internal_fn)
2356         (gdb_maint_setting_str_internal_fn): New functions.
2357         (_initialize_cli_cmds): Define the new convenience functions.
2358         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2359         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2360
2361 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2362
2363         * agent.c (set_can_use_agent): When the setting is turned on,
2364         look up agent symbols if we don't have them yet.
2365         (agent_new_objfile): Don't look up agent symbols when the agent
2366         setting is off.
2367
2368 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2369
2370         * config.in: Regenerate.
2371
2372 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2373
2374         * configure: Regenerate.
2375         * configure.ac: Check for strerror_r.
2376         * gdbsupport/common-utils.h (safe_strerror): Change return value
2377         to const char * and document that this function is now threadsafe.
2378         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2379         thread_local and call strerror_r, if available.
2380         * utils.c (perror_string): Update.
2381         (print_sys_errmsg): Update.
2382
2383 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2384
2385         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2386         objfile_key.
2387         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2388         objfile to fetch per-bfd data.
2389         (arm_find_exidx_entry): Likewise.
2390
2391 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2392
2393         * gdbsupport/agent.c (debug_agent): Change type to bool.
2394         (use_agent): Likewise.
2395         (all_agent_symbols_look_up): Likewise.
2396         (agent_loaded_p): Change return value to bool.
2397         (agent_look_up_symbols): Update.
2398         (agent_capability_check): Change return value to bool.
2399         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2400         (debug_agent): Change type to bool.
2401         (use_agent): Likewise.
2402         (agent_capability_check): Change return value to bool.
2403
2404 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2405
2406         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2407         (build_minimal_symbol_hash_tables): Code to clear the table moved
2408         to clear_minimal_symbol_hash_tables.
2409         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2410         when needed.
2411
2412 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2413
2414         * infcmd.c: Remove includes.
2415         * infrun.c: Remove includes.
2416
2417 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2418
2419         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2420         (grow_vect): Remove declaration.
2421         (ada_type_of_array): Remove declaration.
2422         (ada_update_initial_language): Remove declaration.
2423         (ada_fold_name): Remove declaration.
2424         (ada_fill_in_ada_prototype): Remove declaration.
2425         (user_select_syms): Remove declaration.
2426         (get_selections): Remove declaration.
2427         (ada_tag_type): Remove declaration.
2428         (ada_value_tag): Remove declaration.
2429         (ada_is_others_clause): Remove declaration.
2430         (ada_in_variant): Remove declaration.
2431         (ada_value_struct_elt): Remove declaration.
2432         (ada_attribute_name): Remove declaration.
2433         (ada_system_address_type): Remove declaration.
2434         * ada-lang.c (ada_watch_location_expression): Make static.
2435         (GROW_VECT): Move here from ada-lang.h.
2436         (grow_vect): Make static.
2437         (ada_update_initial_language): Make static.
2438         (ada_fold_name): Make static.
2439         (ada_type_of_array): Make static.
2440         (encoded_ordered_before): Move up.
2441         (sort_choices): Move up.
2442         (print_signatures): Move up.
2443         (ada_print_symbol_signature): Move up.
2444         (get_selections): Move up and make static.
2445         (user_select_syms): Move up and make static.
2446         (ada_value_struct_elt): Move up and make static.
2447         (ada_tag_type): Make static.
2448         (ada_value_tag): Make static.
2449         (ada_is_others_clause): Make static.
2450         (ada_in_variant): Make static.
2451         (ada_attribute_name): Make static.
2452
2453 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2454
2455         * ada-lang.c: Remove includes.
2456         * ada-typeprint.c: Remove includes.
2457         * ada-valprint.c: Remove includes.
2458
2459 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2460
2461         * addrmap.c: Add static assertions of type size, moved from
2462         _initialize_addrmap.
2463         (_initialize_addrmap): Remove.
2464
2465 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2466
2467         * coffread.c (record_minimal_symbol): Update.
2468         (process_coff_symbol): Update.
2469         * dbxread.c (read_dbx_symtab): Update.
2470         * dwarf2read.c (add_partial_symbol): Update.
2471         (fixup_go_packaging): Update.
2472         (load_partial_dies): Update.
2473         (new_symbol): Update.
2474         * elfread.c (record_minimal_symbol): Change signature to use
2475         gdb::string_view instead of name+len.
2476         (elf_symtab_read): Update.
2477         (elf_rel_plt_read): Update.
2478         * mdebugread.c (parse_partial_symbols): Update.
2479         (handle_psymbol_enumerators): Update.
2480         (new_symbol): Update.
2481         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2482         to use gdb::string_view instead of name+len.
2483         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2484         * psympriv.h (add_psymbol_to_list): Likewise.
2485         * psymtab.c (add_psymbol_to_bcache): Likewise.
2486         (add_psymbol_to_list): Likewise.
2487         * stabsread.c (define_symbol): Update.
2488         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2489         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2490         (symbol_set_names): Likewise.
2491         * xcoffread.c (scan_xcoff_symtab): Update.
2492
2493 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2494
2495         * symtab.h (symbol_set_names): Document that copy_name must be
2496         set to true for non-nullterminated strings.
2497         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2498         linkage_name if the entry was not found and we need to demangle.
2499
2500 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2501
2502         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2503         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2504         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2505         * gdbsupport/gdb_binary_search.h: New file.
2506
2507 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2508
2509         * NEWS: Mention new --with-system-gdbinit-dir option.
2510         * config.in: Regenerate.
2511         * configure: Regenerate.
2512         * configure.ac: Add new option --with-system-gdbinit-dir.
2513         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2514         for a ".gdb" suffix.
2515         * main.c (get_init_files): Change system_gdbinit argument to
2516         a vector and return the files in SYSTEM_GDBINIT_DIR in
2517         addition to SYSTEM_GDBINIT.
2518         (captured_main_1): Update.
2519         (print_gdb_help): Update.
2520         * top.c (print_gdb_configuration): Also print the value of
2521         SYSTEM_GDBINIT_DIR.
2522
2523 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2524
2525         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2526         that takes gdb::string_view arguments.
2527
2528 2019-10-26  Tom de Vries  <tdevries@suse.de>
2529
2530         * aarch64-linux-tdep.c: Fix typos in comments.
2531         * aarch64-tdep.c: Same.
2532         * ada-lang.c: Same.
2533         * amd64-nat.c: Same.
2534         * arc-tdep.c: Same.
2535         * arch/aarch64-insn.c: Same.
2536         * block.c: Same.
2537         * breakpoint.h: Same.
2538         * btrace.h: Same.
2539         * c-varobj.c: Same.
2540         * cli/cli-decode.c: Same.
2541         * cli/cli-script.c: Same.
2542         * cli/cli-utils.h: Same.
2543         * coff-pe-read.c: Same.
2544         * coffread.c: Same.
2545         * compile/compile-cplus-symbols.c: Same.
2546         * compile/compile-object-run.c: Same.
2547         * completer.c: Same.
2548         * corelow.c: Same.
2549         * cp-support.c: Same.
2550         * demangle.c: Same.
2551         * dwarf-index-write.c: Same.
2552         * dwarf2-frame.c: Same.
2553         * dwarf2-frame.h: Same.
2554         * eval.c: Same.
2555         * frame-base.h: Same.
2556         * frame.h: Same.
2557         * gdbcmd.h: Same.
2558         * gdbtypes.h: Same.
2559         * gnu-nat.c: Same.
2560         * guile/scm-objfile.c: Same.
2561         * i386-tdep.c: Same.
2562         * i386-tdep.h: Same.
2563         * infcall.c: Same.
2564         * infcall.h: Same.
2565         * linux-nat.c: Same.
2566         * m68k-tdep.c: Same.
2567         * macroexp.c: Same.
2568         * memattr.c: Same.
2569         * mi/mi-cmd-disas.c: Same.
2570         * mi/mi-getopt.h: Same.
2571         * mi/mi-main.c: Same.
2572         * minsyms.c: Same.
2573         * nat/aarch64-sve-linux-sigcontext.h: Same.
2574         * objfiles.h: Same.
2575         * ppc-linux-nat.c: Same.
2576         * ppc-linux-tdep.c: Same.
2577         * ppc-tdep.h: Same.
2578         * progspace.h: Same.
2579         * prologue-value.h: Same.
2580         * python/py-evtregistry.c: Same.
2581         * python/py-instruction.h: Same.
2582         * record-btrace.c: Same.
2583         * record-full.c: Same.
2584         * remote.c: Same.
2585         * rs6000-tdep.c: Same.
2586         * ser-tcp.c: Same.
2587         * sol-thread.c: Same.
2588         * sparc-sol2-tdep.c: Same.
2589         * sparc64-tdep.c: Same.
2590         * stabsread.c: Same.
2591         * symfile.c: Same.
2592         * symtab.h: Same.
2593         * target.c: Same.
2594         * tracepoint.c: Same.
2595         * tui/tui-data.h: Same.
2596         * tui/tui-io.c: Same.
2597         * tui/tui-win.c: Same.
2598         * tui/tui.c: Same.
2599         * unittests/rsp-low-selftests.c: Same.
2600         * user-regs.h: Same.
2601         * utils.c: Same.
2602         * utils.h: Same.
2603         * valarith.c: Same.
2604         * valops.c: Same.
2605         * valprint.c: Same.
2606         * valprint.h: Same.
2607         * value.c: Same.
2608         * value.h: Same.
2609         * varobj.c: Same.
2610         * x86-nat.h: Same.
2611         * xtensa-tdep.c: Same.
2612
2613 2019-10-25  Ali Tamur <tamur@google.com>
2614
2615         * charset.c (find_charset_names): Reflect API change.
2616
2617 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2618
2619         * symtab.c (struct demangled_name_entry): Change demangled name
2620         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2621         part of the struct anymore.
2622         (symbol_set_names): No longer obstack allocate + copy the demangled
2623         name, just store the allocated name from bfd.
2624
2625 2019-10-25  Tom Tromey  <tromey@adacore.com>
2626
2627         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2628         (bsearch_cie_cmp, add_cie): Remove.
2629         (find_cie): Reimplement.
2630         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2631         (dwarf2_build_frame_info): Update.
2632
2633 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2634
2635         PR gdb/25126
2636         * symfile.c (reread_symbols): Call forget_cached_source_info to
2637         clear the stale source cache.
2638
2639 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2640
2641         * configure: Regenerate.
2642         * configure.ac: Remove code that sets python_has_threads.
2643
2644 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2645
2646         * config.in: Regenerate.
2647         * configure: Regenerate.
2648         * configure.ac: Remove the code that uses sed to get the python
2649         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2650
2651 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2652
2653         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2654         error paths.
2655
2656 2019-10-23  Tom Tromey  <tom@tromey.com>
2657
2658         * arc-tdep.c: Remove ".." from include.
2659         * frv-tdep.c: Remove ".." from include.
2660         * lm32-tdep.c: Remove ".." from include.
2661         * microblaze-tdep.c: Remove ".." from include.
2662         * or1k-tdep.h: Remove ".." from include.
2663         * s12z-tdep.c: Remove ".." from include.
2664         * Makefile.in (OPCODES_CFLAGS): Add comment.
2665         (TOP_CFLAGS): New variable.
2666         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2667
2668 2019-10-23  Tom Tromey  <tom@tromey.com>
2669
2670         * Makefile.in (READLINE_DIR): Update.
2671
2672 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2673
2674         * infcall.c (call_function_by_hand_dummy): Fix the function
2675         comment.  And extract out a code section into...
2676         (reserve_stack_space): ...this new function.
2677
2678 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2679
2680         * infcall.c (value_arg_coerce): Remove an unused parameter.
2681         (call_function_by_hand_dummy): Update the call to
2682         'value_arg_coerce'.
2683
2684 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2685
2686         * infcall.c (call_function_by_hand_dummy): Refactor.
2687
2688 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2689
2690         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2691
2692 2019-10-23  Tom Tromey  <tom@tromey.com>
2693
2694         * configure: Rebuild.
2695         * configure.ac: Don't check for sigprocmask.
2696         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2697
2698 2019-10-23  Tom Tromey  <tom@tromey.com>
2699
2700         * configure: Rebuild.
2701         * acinclude.m4: Use m4_include, not sinclude.
2702
2703 2019-10-23  Tom de Vries  <tdevries@suse.de>
2704
2705         PR breakpoints/24687
2706         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2707
2708 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2709
2710         * symtab.c (struct demangled_name_entry) <language>: Change from
2711         bitfield to regular variable.
2712
2713 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2714
2715         * symtab.c (struct demangled_name_entry): Add a constructor.
2716         (free_demangled_name_entry): New function to call the destructor
2717         for demangled_name_entry.
2718         (create_demangled_names_hash): Pass free_demangled_name_entry to
2719         htab_create_alloc.
2720         (symbol_set_names): Call placement new for demangled_name_entry.
2721         * utils.c: No longer include xxhash.h here, now that fast_hash
2722         is inlined in the header.
2723         * utils.h: Instead, include it here.
2724
2725 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2726
2727         * Makefile.in: Link with libxxhash.
2728         * config.in: Regenerate.
2729         * configure: Regenerate.
2730         * configure.ac: Search for libxxhash.
2731         * utils.c (fast_hash): Use xxhash if present.
2732
2733 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2734
2735         * utils.h (fast_hash): New function.
2736         * symtab.c (hash_demangled_name_entry): Call new function
2737         fast_hash.
2738
2739 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2740
2741         * symtab.c (struct demangled_name_entry): Change type of mangled
2742         to gdb::string_view. Also adds a constructor that takes the
2743         mangled name.
2744         (hash_demangled_name_entry): Update.
2745         (eq_demangled_name_entry): Update.
2746         (free_demangled_name_entry): New function to call the destructor
2747         now that this is not a POD anymore.
2748         (create_demangled_names_hash): Pass free_demangled_name_entry to
2749         htab_create_alloc.
2750         (symbol_set_names): Update.
2751
2752 2019-10-21  Ali Tamur  <tamu@google.com>
2753
2754         * dwarf2read.c (dir_index): Change type.
2755         (file_name_index): Likewise.
2756         (line_header::include_dir_at): Change comment and implementation on
2757         whether it is DWARF 5.
2758         (line_header::is_valid_file_index): New function.
2759         (line_header::file_name_at): Change comment and implementation on
2760         whether it is DWARF 5.
2761         (line_header::file_names): Change to private field renamed as
2762         m_file_names and introduce a new accessor method.
2763         (line_header::file_names_size): New method.
2764         (line_header::include_dirs): Change to private field and rename as
2765         m_include_dirs.
2766         (dw2_get_file_names_reader): Define local var at a smaller scope and
2767         reflect API change.
2768         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2769         (process_structure_scope): Likewise.
2770         (line_header::add_include_dir): Change message and reflect renaming.
2771         (line_header::add_file_name): Likewise.
2772         (read_formatted_entries): Handle DW_FORM_data16.
2773         (dwarf_decode_line_header): Fix line header length calculation.
2774         (psymtab_include_file_name): Change comment and API.
2775         (lnp_state_machine::m_file): Update comment and reflect type change.
2776         (lnp_state_machine::record_line): Reflect type change.
2777         (dwarf_decode_lines): Reflect API change.
2778         (file_file_name): Likewise.
2779         (file_full_name): Likewise.
2780
2781 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2782
2783         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2784
2785 2019-10-21  Tom Tromey  <tom@tromey.com>
2786
2787         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2788
2789 2019-10-21  Tom Tromey  <tom@tromey.com>
2790
2791         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2792         NM_H.   Use AC_CONFIG_LINKS.
2793         * configure: Rebuild.
2794         * Makefile.in (NM_H): New variable.
2795         (generated_files): Add NM_H.  Remove gcore.
2796         (nm.h, stamp-nmh): New targets.
2797
2798 2019-10-20  Tom Tromey  <tom@tromey.com>
2799
2800         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2801         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2802         obsolete comment.
2803         (put_objfile_before): Now static.
2804
2805 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2806
2807         * gdbsupport/common-utils.h (startswith): Change return type to
2808         bool.
2809
2810 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2811
2812         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2813         * breakpoint.c (bp_locations_compare): Rename to...
2814         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2815         (update_global_location_list): Use std::sort instead of qsort.
2816         * buildsym.c (compare_line_numbers): Rename to...
2817         (lte_is_less_than): ...this, and change to std::sort semantics.
2818         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2819         instead of qsort.
2820         * disasm.c (compare_lines): Rename to...
2821         (line_is_less_than): ...this, and change to std::sort semantics.
2822         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2823         of qsort.
2824         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2825         (fde_is_less_than): ...this, and change to std::sort semantics.
2826         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2827         * mdebugread.c (compare_blocks):
2828         (block_is_less_than): ...this, and change to std::sort semantics.
2829         (sort_blocks): Call std::sort instead of qsort.
2830         * objfiles.c (qsort_cmp): Rename to...
2831         (sort_cmp): ...this, and change to std::sort semantics.
2832         (update_section_map): Call std::sort instead of qsort.
2833         * remote.c (compare_pnums): Remove.
2834         (map_regcache_remote_table): Call std::sort instead of qsort.
2835         * utils.c (compare_positive_ints): Remove.
2836         * utils.h (compare_positive_ints): Remove.
2837         * xcoffread.c (compare_lte): Remove.
2838         (arrange_linetable): Call std::sort instead of qsort.
2839
2840 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2841
2842         * symfile.c (init_entry_point_info): Fix typo.
2843         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2844
2845 2019-10-18  Tom de Vries  <tdevries@suse.de>
2846
2847         * aarch64-tdep.c: Fix typos in comments.
2848         * ada-lang.c: Same.
2849         * ada-tasks.c: Same.
2850         * alpha-tdep.c: Same.
2851         * alpha-tdep.h: Same.
2852         * amd64-nat.c: Same.
2853         * amd64-windows-tdep.c: Same.
2854         * arc-tdep.c: Same.
2855         * arc-tdep.h: Same.
2856         * arch-utils.c: Same.
2857         * arm-nbsd-tdep.c: Same.
2858         * arm-tdep.c: Same.
2859         * ax-gdb.c: Same.
2860         * blockframe.c: Same.
2861         * btrace.c: Same.
2862         * c-varobj.c: Same.
2863         * coff-pe-read.c: Same.
2864         * coffread.c: Same.
2865         * cris-tdep.c: Same.
2866         * darwin-nat.c: Same.
2867         * dbxread.c: Same.
2868         * dcache.c: Same.
2869         * disasm.c: Same.
2870         * dtrace-probe.c: Same.
2871         * dwarf-index-write.c: Same.
2872         * dwarf2-frame-tailcall.c: Same.
2873         * dwarf2-frame.c: Same.
2874         * dwarf2read.c: Same.
2875         * eval.c: Same.
2876         * exceptions.c: Same.
2877         * fbsd-tdep.c: Same.
2878         * findvar.c: Same.
2879         * frame.c: Same.
2880         * frv-tdep.c: Same.
2881         * gnu-v3-abi.c: Same.
2882         * go32-nat.c: Same.
2883         * h8300-tdep.c: Same.
2884         * hppa-tdep.c: Same.
2885         * i386-linux-tdep.c: Same.
2886         * i386-tdep.c: Same.
2887         * ia64-libunwind-tdep.c: Same.
2888         * ia64-tdep.c: Same.
2889         * infcmd.c: Same.
2890         * infrun.c: Same.
2891         * linespec.c: Same.
2892         * linux-nat.c: Same.
2893         * linux-thread-db.c: Same.
2894         * machoread.c: Same.
2895         * mdebugread.c: Same.
2896         * mep-tdep.c: Same.
2897         * mn10300-tdep.c: Same.
2898         * namespace.c: Same.
2899         * objfiles.c: Same.
2900         * opencl-lang.c: Same.
2901         * or1k-tdep.c: Same.
2902         * osabi.c: Same.
2903         * ppc-linux-nat.c: Same.
2904         * ppc-linux-tdep.c: Same.
2905         * ppc-sysv-tdep.c: Same.
2906         * printcmd.c: Same.
2907         * procfs.c: Same.
2908         * record-btrace.c: Same.
2909         * record-full.c: Same.
2910         * remote-fileio.c: Same.
2911         * remote.c: Same.
2912         * rs6000-tdep.c: Same.
2913         * s12z-tdep.c: Same.
2914         * score-tdep.c: Same.
2915         * ser-base.c: Same.
2916         * ser-go32.c: Same.
2917         * skip.c: Same.
2918         * sol-thread.c: Same.
2919         * solib-svr4.c: Same.
2920         * solib.c: Same.
2921         * source.c: Same.
2922         * sparc-nat.c: Same.
2923         * sparc-sol2-tdep.c: Same.
2924         * sparc-tdep.c: Same.
2925         * sparc64-tdep.c: Same.
2926         * stabsread.c: Same.
2927         * stack.c: Same.
2928         * symfile.c: Same.
2929         * symtab.c: Same.
2930         * target-descriptions.c: Same.
2931         * target-float.c: Same.
2932         * thread.c: Same.
2933         * utils.c: Same.
2934         * valops.c: Same.
2935         * valprint.c: Same.
2936         * value.c: Same.
2937         * varobj.c: Same.
2938         * windows-nat.c: Same.
2939         * xcoffread.c: Same.
2940         * xstormy16-tdep.c: Same.
2941         * xtensa-tdep.c: Same.
2942
2943 2019-10-17  Tom Tromey  <tromey@adacore.com>
2944
2945         * configure: Rebuild.
2946         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2947         in AC_CONFIG_FILES invocation.
2948         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2949         new-style config.status invocation.
2950
2951 2019-10-17  Tom de Vries  <tdevries@suse.de>
2952
2953         * arm-nbsd-nat.c: Fix typos in comments.
2954         * arm-tdep.c: Same.
2955         * darwin-nat-info.c: Same.
2956         * dwarf2read.c: Same.
2957         * elfread.c: Same.
2958         * event-top.c: Same.
2959         * findvar.c: Same.
2960         * gdbtypes.c: Same.
2961         * hppa-tdep.c: Same.
2962         * i386-tdep.c: Same.
2963         * jit.c: Same.
2964         * main.c: Same.
2965         * mdebugread.c: Same.
2966         * moxie-tdep.c: Same.
2967         * nto-procfs.c: Same.
2968         * osabi.c: Same.
2969         * ppc-linux-tdep.c: Same.
2970         * remote.c: Same.
2971         * riscv-tdep.c: Same.
2972         * s390-tdep.c: Same.
2973         * sh-tdep.c: Same.
2974         * sparc-linux-tdep.c: Same.
2975         * sparc-nat.c: Same.
2976         * stack.c: Same.
2977         * target-descriptions.c: Same.
2978         * top.c: Same.
2979         * varobj.c: Same.
2980
2981 2019-10-16  Tom Tromey  <tom@tromey.com>
2982
2983         * objfiles.h (struct objfile) <original_name>: Now const.
2984
2985 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2986
2987         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2988         pass on to sigsetjmp's second argument.
2989         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2990
2991 2019-10-16  Keith Seitz  <keiths@redhat.com>
2992
2993         PR gdb/23567
2994         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2995         sections whose size is greater than the file size.
2996
2997 2019-10-16  Jim Wilson  <jimw@sifive.com>
2998
2999         * riscv-tdep.c (riscv_gcc_target_options): New.
3000         (riscv_gnu_triplet_regexp): New.
3001         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3002         set_gdbarch_gnu_triplet_regexp.
3003
3004 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3005
3006         * Makefile.in: Add xml-builtin.h.
3007         * features/feature_to_c.sh: Add an include for xml-builtin.h
3008         to ensure that the compiler checks that the types match.
3009         * xml-builtin.h: New file.
3010         * xml-support.c (fetch_xml_builtin): Add missing const.
3011         * xml-support.h: Remove declaration of xml_builtins.
3012
3013 2019-10-16  Tom de Vries  <tdevries@suse.de>
3014
3015         PR tdep/25096
3016         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3017         (amd64_classify_aggregate): ... here.
3018         (amd64_classify_aggregate_field): Handled fiels of nested structs
3019         recursively.
3020
3021 2019-10-16  Tom de Vries  <tdevries@suse.de>
3022
3023         PR tdep/24104
3024         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3025         that handles 'theclass'.
3026
3027 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3028
3029         * linespec.c (decode_digits_ordinary): Update comment.
3030         * make-target-delegates: No longer need to handle VEC case.
3031         * memrange.c (normalize_mem_ranges): Update comment.
3032         * namespace.c (add_using_directive): Update comment.
3033         * objc-lang.c (uniquify_strings): Update comment.
3034         * ppc-linux-nat.c (struct thread_points): Update comment.
3035         * probe.h (find_probes_in_objfile): Update comment.
3036         * target.h (enum flash_preserve_mode): Update comment.
3037         * varobj.c (varobj_restrict_range): Update comment.
3038         * varobj.h (varobj_list_children): Update comment.
3039
3040 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3041
3042         * Makefile.in: Remove references to vec.h and vec.c.
3043         * aarch64-tdep.c: No longer include vec.h.
3044         * ada-lang.c: Likewise.
3045         * ada-lang.h: Likewise.
3046         * arm-tdep.c: Likewise.
3047         * ax.h: Likewise.
3048         * breakpoint.h: Likewise.
3049         * charset.c: Likewise.
3050         * cp-support.h: Likewise.
3051         * dtrace-probe.c: Likewise.
3052         * dwarf2read.c: Likewise.
3053         * extension.h: Likewise.
3054         * gdb_bfd.c: Likewise.
3055         * gdbsupport/gdb_vecs.h: Likewise.
3056         * gdbsupport/vec.c: Remove.
3057         * gdbsupport/vec.h: Remove.
3058         * gdbthread.h: Likewise.
3059         * guile/scm-type.c: Likewise.
3060         * inline-frame.c: Likewise.
3061         * machoread.c: Likewise.
3062         * memattr.c: Likewise.
3063         * memrange.h: Likewise.
3064         * namespace.h: Likewise.
3065         * nat/linux-btrace.h: Likewise.
3066         * osdata.c: Likewise.
3067         * parser-defs.h: Likewise.
3068         * progspace.h: Likewise.
3069         * python/py-type.c: Likewise.
3070         * record-btrace.c: Likewise.
3071         * rust-exp.y: Likewise.
3072         * solib-target.c: Likewise.
3073         * stap-probe.c: Likewise.
3074         * target-descriptions.c: Likewise.
3075         * target-memory.c: Likewise.
3076         * target.h: Likewise.
3077         * varobj.c: Likewise.
3078         * varobj.h: Likewise.
3079         * xml-support.h: Likewise.
3080
3081 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3082
3083         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3084         Update for new std::vector based implementation.
3085         (process_psymtab_comp_unit_reader): Likewise.
3086         (scan_partial_symbols): Likewise.
3087         (recursively_compute_inclusions): Likewise.
3088         (compute_compunit_symtab_includes): Likewise.
3089         (process_imported_unit_die): Likewise.
3090         (queue_and_load_dwo_tu): Likewise.
3091         (follow_die_sig_1): Likewise.
3092         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3093         (typedef dwarf2_per_cu_ptr): Remove.
3094         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3095         function.
3096         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3097         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3098         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3099         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3100         std::vector.
3101
3102 2019-10-15  Tom Tromey  <tromey@adacore.com>
3103
3104         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3105         TID.
3106
3107 2019-10-15  Tom Tromey  <tromey@adacore.com>
3108
3109         * windows-nat.c (windows_nat_target::fetch_registers)
3110         (windows_nat_target::store_registers): Rename "pid" to "tid".
3111
3112 2019-10-15  Tom Tromey  <tromey@adacore.com>
3113
3114         * gdbarch.h, gdbarch.c: Rebuild.
3115         * gdbarch.sh (gcc_target_options): Change return type to
3116         std::string.
3117         * compile/compile.c (get_args): Update.
3118         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3119         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3120         std::string.
3121         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3122         std::string.
3123         * arch-utils.c (default_gcc_target_options): Return std::string.
3124         * arch-utils.h (default_gcc_target_options): Return std::string.
3125         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3126
3127 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3128
3129         * breakpoint.c (breakpoint_chain): Make static.
3130         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3131         of accessing breakpoint_chain.
3132
3133 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3134
3135         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3136         to a gdb::function_view and return value to bool.
3137         * breakpoint.h (iterate_over_breakpoints): Likewise.
3138         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3139         (pop_dummy_frame): Update.
3140         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3141         (gdbscm_breakpoints): Update.
3142         * python/py-breakpoint.c (build_bp_list): Update.
3143         (gdbpy_breakpoints): Update.
3144         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3145         Update.
3146         (bpfinishpy_handle_stop): Update.
3147         (bpfinishpy_handle_exit): Update.
3148         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3149         (svr4_update_solib_event_breakpoints): Update.
3150
3151 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3152
3153         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3154         when unwrapping single-field structs.
3155
3156 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3157
3158         * dwarf2read.c: Remove includes.
3159
3160 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3161
3162         * ui-out.c (ui_out::call_do_message): Silence
3163         -Wformat-nonliteral warning.
3164
3165 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3166
3167         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3168         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3169         include: readline/tilde.h.
3170
3171 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3172
3173         * remote.c (remote_target::get_trace_status): Remove declaration of
3174         trace_regblock_size.
3175
3176 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3177
3178         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3179         (show_user): Remove declaration of cmdlist.
3180         * cli/cli-cmds.h (max_user_call_depth): Declare.
3181         * cli/cli-script.c (execute_user_command): Remove declaration
3182         of max_user_call_depth.
3183
3184 2019-10-11  Jim Wilson  <jimw@sifive.com>
3185
3186         * gdbsupport/print-utils.h (pulongest): Fix comment.
3187         (plongest): Likewise.
3188         (phex): Add missing comment, mention leading zeros.
3189         (phex_nz): Add mention of no leading zeros to comment.
3190
3191         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3192         plongest instead of unsigned long long cast.
3193
3194 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3195
3196         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3197         for external_editor_command and gdbtk_test.
3198
3199 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3200
3201         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3202         * varobj.c (varobjdebug): Move comment to...
3203         * varobj.h (varobjdebug): ...here, and declare.
3204
3205 2019-10-09  Tom Tromey  <tom@tromey.com>
3206
3207         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3208         erase_data_content.
3209
3210 2019-10-09  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3213         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3214         * tui/tui-command.c (tui_cmd_window::resize)
3215         (tui_refresh_cmd_win): Update.
3216         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3217         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3218         * tui/tui-data.c (~tui_gen_win_info): Remove.
3219         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3220         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3221         (tui_redisplay_readline, tui_mld_flush)
3222         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3223         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3224         (tui_data_window::erase_data_content)
3225         (tui_data_item_window::rerender)
3226         (tui_data_item_window::refresh_window): Update.
3227         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3228         (box_win, tui_gen_win_info::make_window)
3229         (tui_gen_win_info::make_visible): Update.
3230         (tui_delete_win): Remove.
3231         * tui/tui-winsource.c
3232         (tui_source_window_base::do_erase_source_content): Update.
3233         (tui_show_source_line, tui_source_window_base::update_tab_width)
3234         (tui_source_window_base::update_exec_info): Update.
3235         * tui/tui-data.h (struct curses_deleter): New.
3236         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3237         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3238
3239 2019-10-09  Tom Tromey  <tom@tromey.com>
3240
3241         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3242
3243 2019-10-09  Tom Tromey  <tom@tromey.com>
3244
3245         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3246         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3247
3248 2019-10-09  Tom Tromey  <tom@tromey.com>
3249
3250         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3251         window height directly.
3252         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3253         declare.
3254         * tui/tui-layout.c (tui_default_win_height): Remove.
3255         (tui_default_win_viewport_height): Remove.
3256
3257 2019-10-09  Tom Tromey  <tom@tromey.com>
3258
3259         * tui/tui.h: Remove comments.
3260
3261 2019-10-09  Tom de Vries  <tdevries@suse.de>
3262
3263         * python/lib/gdb/printer/bound_registers.py: Use
3264         '^builtin_type_bound128' as regexp argument for
3265         add_builtin_pretty_printer.
3266
3267 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3268
3269         * guile/guile.c (guile_extension_script_ops): Remove forward
3270         declaration and mark as static.
3271         (guile_script_ops): Likewise.
3272         (extension_language_guile): Move further down in the file so
3273         it can reference the definitions for guile_{extension_,}script_ops.
3274
3275 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3276
3277         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3278         except SORTL, DFLTCC, and KDSA.
3279
3280 2019-10-08  Tom Tromey  <tromey@adacore.com>
3281
3282         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3283         (struct safe_symbol_file_add_args): Remove.
3284
3285 2019-10-08  Tom Tromey  <tromey@adacore.com>
3286
3287         * windows-nat.c: Don't include buildsym-legacy.h.
3288
3289 2019-10-08  Tom Tromey  <tromey@adacore.com>
3290
3291         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3292
3293 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3294
3295         * gdbtypes.c (overload_debug): Move comment to header.
3296         * gdbtypes.h (overload_debug): Declare.
3297         * valops.c: Remove declaration of overload_debug, instead
3298         include gdbtypes.h.
3299
3300 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3301
3302         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3303         through _().
3304         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3305         move comment...
3306         * language.h (lang_frame_mismatch_warn): ... here. Also add
3307         declaration.
3308         * top.c (lang_frame_mismatch_warn): Remove declaration.
3309         (check_frame_language_change): Pass lang_frame_mismatch_warn
3310         through _().
3311
3312 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3313
3314         * c-lang.h (vtbl_ptr_name): Declare.
3315         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3316         it from the header.
3317         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3318
3319 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3320
3321         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3322         gdb_static_assert.
3323
3324 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3325
3326         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3327         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3328         * ctfread.c: New file.
3329         * ctfread.h: New file.
3330         * elfread.c: Include ctfread.h.
3331         (struct elfinfo text_p): New member ctfsect.
3332         (elf_locate_sections): Mark CTF section.
3333         (elf_symfile_read): Call elfctf_build_psymtabs.
3334         * Makefile.in (LIBCTF): Add.
3335         (CLIBS): Use it.
3336         (CDEPS): Likewise.
3337         (DIST): Add ctfread.c.
3338
3339 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3340
3341         * ctfread.c (struct nextfield): Renamed to ...
3342         (struct ctf_nextfield): ... this.
3343         (struct field_info): Renamed to ...
3344         (strut ctf_field_info): ... this.
3345         (attach_fields_to_type): Update for renamed structures.
3346         (ctf_add_member_cb): Likewise.
3347         (ctf_add_enum_member_cb): Likewise.
3348         (process_struct_members): Likewise.
3349         (process_enum_type): Likewise.
3350
3351 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3352
3353         * tracectf.h: Rename, was ctf.h.
3354         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3355         * tracefile.c: Likewise.
3356         * tracepoint.c: Remove unused include ctf.h.
3357         * mi/mi-main.c: Likewise.
3358         * Makefile.in Replace ctf.c with tracectf.c.
3359
3360 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3361
3362         * version.in: Change version number to "9.0.50.DATE-git".
3363
3364 2019-10-03  Tom Tromey  <tom@tromey.com>
3365
3366         PR rust/24976:
3367         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3368
3369 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3370
3371         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3372         cp_search_name_hash.
3373         * NEWS: Add entry about nested function support.
3374
3375 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3376             Andrew Burgess  <andrew.burgess@embecosm.com>
3377
3378         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3379         for nested static variables when searchin VAR_DOMAIN.
3380         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3381         global scope, update comment.
3382         (add_partial_subprogram): Call add_partial_subprogram recursively
3383         for nested subroutines when processinng Fortran.
3384         (load_partial_dies): Process the child entities of a subprogram
3385         when processing Fortran.
3386         (partial_die_parent_scope): Handle building scope
3387         for Fortran nested functions.
3388         (process_die): Record that nested functions have a scope.
3389         (new_symbol): Always record Fortran subprograms on the global
3390         symbol list.
3391         (determine_prefix): How to build the prefix for Fortran
3392         subprograms.
3393
3394 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3395
3396         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3397         have just sent the thread a SIGSTOP and are waiting for it to
3398         arrive.
3399
3400 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3401
3402         * btrace.c (btrace_add_pc): Remove whitespace before the template
3403         parameter in 'std::vector <...>'.
3404         (parse_xml_btrace_block): Likewise.
3405         (btrace_maint_decode_pt): Likewise.
3406         (btrace_maint_update_packets): Likewise.
3407         (btrace_maint_print_packets): Likewise.
3408         * btrace.h (struct btrace_maint_info): Likewise.
3409         * dwarf2read.c (struct type_unit_group): Likewise.
3410         (build_type_psymtabs_reader): Likewise.
3411         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3412         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3413         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3414
3415 2019-10-03  Tom de Vries  <tdevries@suse.de>
3416
3417         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3418         the first line of the help text for set/show style metadata.
3419
3420 2019-10-02  Tom Tromey  <tromey@adacore.com>
3421
3422         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3423         * gdbsupport/common-inferior.c: New file.
3424         * infcmd.c (startup_with_shell): Don't define.
3425         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3426         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3427         * inferior.h (startup_with_shell): Don't declare.
3428
3429 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3430
3431         * gdbsupport/gdb_assert.h: Include errors.h.
3432         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3433
3434 2019-10-02  Tom Tromey  <tromey@adacore.com>
3435
3436         * NEWS: Add $_ada_exception entry.
3437         * ada-lang.c (struct ada_catchpoint): Add constructor.
3438         <m_kind>: New member.
3439         (allocate_location_exception, re_set_exception): Remove
3440         "ex" parameter.
3441         (should_stop_exception): Compute $_ada_exception.
3442         (check_status_exception, print_it_exception)
3443         (print_one_exception, print_mention_exception): Remove
3444         "ex" parameter.
3445         (allocate_location_catch_exception, re_set_catch_exception)
3446         (check_status_exception, print_it_catch_exception)
3447         (print_one_catch_exception, print_mention_catch_exception)
3448         (print_recreate_catch_exception)
3449         (allocate_location_catch_exception_unhandled)
3450         (re_set_catch_exception_unhandled)
3451         (check_status_exception, print_it_catch_exception_unhandled)
3452         (print_one_catch_exception_unhandled)
3453         (print_mention_catch_exception_unhandled)
3454         (print_recreate_catch_exception_unhandled)
3455         (allocate_location_catch_assert, re_set_catch_assert)
3456         (check_status_assert, print_it_catch_assert)
3457         (print_one_catch_assert, print_mention_catch_assert)
3458         (print_recreate_catch_assert)
3459         (allocate_location_catch_handlers, re_set_catch_handlers)
3460         (check_status_handlers, print_it_catch_handlers)
3461         (print_one_catch_handlers, print_mention_catch_handlers)
3462         (print_recreate_catch_handlers): Remove.
3463         (create_ada_exception_catchpoint): Update.
3464         (initialize_ada_catchpoint_ops): Update.
3465
3466 2019-10-02  Tom Tromey  <tromey@adacore.com>
3467
3468         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3469         (create_excep_cond_exprs): Simplify exception string computation.
3470         (ada_exception_catchpoint_cond_string): Likewise.
3471
3472 2019-10-02  Tom Tromey  <tromey@adacore.com>
3473
3474         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3475         * ada-lang.c (lesseq_defined_than): Handle
3476         LOC_STATIC.
3477         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3478         parameter.
3479         (dwarf2_has_info): Likewise.
3480         (new_symbol): Set maybe_copied on symbol when
3481         appropriate.
3482         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3483         parameter.
3484         <can_copy>: New member.
3485         * elfread.c (record_minimal_symbol): Set maybe_copied
3486         on symbol when appropriate.
3487         (elf_symfile_read): Update call to dwarf2_has_info.
3488         * minsyms.c (lookup_minimal_symbol_linkage): New
3489         function.
3490         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3491         * symtab.c (get_symbol_address, get_msymbol_address):
3492         New functions.
3493         * symtab.h (get_symbol_address, get_msymbol_address):
3494         Declare.
3495         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3496         maybe_copied.
3497         (struct symbol, struct minimal_symbol) <maybe_copied>:
3498         New member.
3499
3500 2019-10-02  Tom Tromey  <tromey@adacore.com>
3501
3502         * source.c (struct current_source_location): New.
3503         (current_source_key): New global.
3504         (current_source_symtab, current_source_line)
3505         (current_source_pspace): Remove.
3506         (get_source_location): New function.
3507         (get_current_source_symtab_and_line)
3508         (set_default_source_symtab_and_line)
3509         (set_current_source_symtab_and_line)
3510         (clear_current_source_symtab_and_line, select_source_symtab)
3511         (info_source_command, print_source_lines_base)
3512         (info_line_command, search_command_helper, _initialize_source):
3513         Update.
3514
3515 2019-10-02  Tom Tromey  <tromey@adacore.com>
3516
3517         * source.c (select_source_symtab): Don't call
3518         decode_line_with_current_source.
3519
3520 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3521
3522         * symtab.c (lookup_global_symbol): Search global block.
3523
3524 2019-10-02  Tom Tromey  <tromey@adacore.com>
3525
3526         * coffread.c (process_coff_symbol): Update.
3527         * dwarf2read.c (var_decode_location, new_symbol): Update.
3528         * mdebugread.c (parse_symbol): Update.
3529         * objfiles.c (relocate_one_symbol): Update.
3530         * stabsread.c (define_symbol, fix_common_block)
3531         (scan_file_globals): Update.
3532         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3533         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3534         * xcoffread.c (process_xcoff_symbol): Update.
3535
3536 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3537
3538         * MAINTAINERS: Update my email address.
3539
3540 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3541
3542         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3543         std::vector.
3544         (build_type_psymtabs_reader): Update for std::vector.
3545         (build_type_psymtab_dependencies): Likewise.
3546         * dwarf2read.h: Remove use of DEF_VEC_P.
3547         (typedef sig_type_ptr): Delete.
3548
3549 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3550
3551         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3552         to std::vector.
3553         (btrace_maint_decode_pt): Likewise, and move allocation of the
3554         vector outside of the loop.
3555         (btrace_maint_update_packets): Update to handle change from VEC to
3556         std::vector.
3557         (btrace_maint_print_packets): Likewise.
3558         (maint_info_btrace_cmd): Likewise.
3559         * btrace.h: Remove use of DEF_VEC_O.
3560         (typedef btrace_pt_packet_s): Delete.
3561         (struct btrace_maint_info) <packets>: Change fromm VEC to
3562         std::vector.
3563         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3564
3565 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3566
3567         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3568         make accesses into the vector constant references.
3569         (btrace_add_pc): Update for std::vector.
3570         (btrace_stitch_bts): Likewise.
3571         (parse_xml_btrace_block): Likewise.
3572         (btrace_maint_update_packets): Likewise.
3573         (btrace_maint_print_packets): Likewise.
3574         (maint_info_btrace_cmd): Likewise.
3575         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3576         std::vector.
3577         (btrace_data::empty): Likewise.
3578         (btrace_data_append): Likewise.
3579         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3580         (typedef btrace_block_s): Delete.
3581         (struct btrace_block): Add constructor.
3582         (struct btrace_data_bts) <blocks>: Change to std::vector.
3583         * nat/linux-btrace.c (perf_event_read_bts): Update for
3584         std::vector.
3585         (linux_read_bts): Likewise.
3586
3587 2019-10-01  Tom Tromey  <tom@tromey.com>
3588
3589         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3590
3591 2019-10-01  Tom Tromey  <tom@tromey.com>
3592
3593         * stack.c (print_frame, info_frame_command_core): Use
3594         styled_string.
3595         * linux-thread-db.c (try_thread_db_load_1)
3596         (try_thread_db_load_from_pdir_1): Use styled_string.
3597         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3598         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3599         (maybe_print_unsupported_script_warning)
3600         (maybe_print_script_not_found_warning): Use styled_string.
3601         * ada-lang.c (user_select_syms): Use styled_string.
3602
3603 2019-10-01  Tom Tromey  <tom@tromey.com>
3604
3605         * p-lang.c (pascal_printstr): Use metadata style.
3606         * value.c (show_convenience): Use metadata style.
3607         * valprint.c (valprint_check_validity, val_print_optimized_out)
3608         (val_print_not_saved, val_print_unavailable)
3609         (val_print_invalid_address, generic_val_print, val_print)
3610         (value_check_printable, val_print_array_elements): Use metadata
3611         style.
3612         * ui-out.h (class ui_out) <field_fmt>: New overload.
3613         <do_field_fmt>: Add style parameter.
3614         * ui-out.c (ui_out::field_fmt): New overload.
3615         * typeprint.c (type_print_unknown_return_type)
3616         (val_print_not_allocated, val_print_not_associated): Use metadata
3617         style.
3618         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3619         parameter.
3620         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3621         * tracepoint.c (tvariables_info_1): Use metadata style.
3622         * stack.c (print_frame_arg, print_frame_info, print_frame)
3623         (info_frame_command_core): Use metadata style.
3624         * skip.c (info_skip_command): Use metadata style.
3625         * rust-lang.c (rust_print_enum): Use metadata style.
3626         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3627         metadata style.
3628         * python/py-framefilter.c (py_print_single_arg): Use metadata
3629         style.
3630         * printcmd.c (do_one_display, print_variable_and_value): Use
3631         metadata style.
3632         * p-valprint.c (pascal_val_print)
3633         (pascal_object_print_value_fields): Use metadata style.
3634         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3635         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3636         parameter.
3637         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3638         * m2-valprint.c (m2_print_long_set): Use metadata style.
3639         * m2-typeprint.c (m2_print_type): Use metadata style.
3640         * infcmd.c (print_return_value_1): Use metadata style.
3641         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3642         * f-valprint.c (info_common_command_for_block): Use metadata
3643         style.
3644         * f-typeprint.c (f_type_print_base): Use metadata style.
3645         * expprint.c (print_subexp_standard): Use metadata style.
3646         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3647         * cli/cli-style.h (class cli_style_option): Add constructor.
3648         (metadata_style): Declare.
3649         * cli/cli-style.c (metadata_style): New global.
3650         (_initialize_cli_style): Register metadata style.
3651         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3652         parameter.
3653         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3654         * c-typeprint.c (c_type_print_base_struct_union)
3655         (c_type_print_base_1): Use metadata style.
3656         * breakpoint.c (watchpoint_value_print)
3657         (print_one_breakpoint_location): Use metadata style.
3658         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3659         style.
3660         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3661         style.
3662         * ada-valprint.c (val_print_packed_array_elements, printstr)
3663         (print_field_values, ada_val_print_ref, ada_val_print): Use
3664         metadata style.
3665         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3666         style.
3667         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3668         style.
3669         * ada-lang.c (user_select_syms): Use metadata style.
3670
3671 2019-10-01  Tom Tromey  <tom@tromey.com>
3672
3673         * cli/cli-cmds.c (pwd_command): Style output.
3674
3675 2019-10-01  Pedro Alves  <palves@redhat.com>
3676             Tom Tromey  <tom@tromey.com>
3677
3678         * symtab.c (print_symbol_info): Use %ps.
3679         (print_msymbol_info): Use %ps.
3680         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3681         * printcmd.c (print_variable_and_value): Use %ps.
3682         * macrocmd.c (show_pp_source_pos): Use %ps.
3683         * infrun.c (print_exited_reason): Use ui_out::message.
3684         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3685         (describe_other_breakpoints): Use ui_out::message and new
3686         formats.
3687         (say_where): Use new formats.
3688         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3689         and new formats.
3690
3691 2019-10-01  Pedro Alves  <palves@redhat.com>
3692             Tom Tromey  <tom@tromey.com>
3693
3694         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3695         (test_gdb_formats): New function.
3696         (run_tests): Call it.
3697         (test_format_specifier): Update.
3698         * utils.h (fputs_filtered): Update comment.
3699         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3700         (fputs_styled_unfiltered): Declare.
3701         * utils.c (fputs_styled_unfiltered): New function.
3702         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3703         (vfprintf_filtered): Update.
3704         (vfprintf_unfiltered, vprintf_filtered): Update.
3705         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3706         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3707         disallow_ui_out_field>: New constants.
3708         (enum class field_kind): New.
3709         (struct base_field_s, struct signed_field_s): New.
3710         (signed_field): New function.
3711         (struct string_field_s): New.
3712         (string_field): New function.
3713         (struct styled_string_s): New.
3714         (styled_string): New function.
3715         (class ui_out) <message>: Add comment.
3716         <vmessage, call_do_message>: New methods.
3717         <do_message>: Add style parameter.
3718         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3719         methods.
3720         (ui_out::message): Rewrite.
3721         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3722         parameter.
3723         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3724         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3725         gdb_extensions parameter.
3726         (class format_piece): Add parameter to constructor.
3727         (n_int_args): New field.
3728         * gdbsupport/format.c (format_pieces::format_pieces): Add
3729         gdb_extensions parameter.  Handle '*'.
3730         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3731         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3732         vfprintf_styled_no_gdbfmt.
3733         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3734         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3735         unfiltered output.
3736         * ui-style.h (struct ui_file_style) <ptr>: New method.
3737
3738 2019-10-01  Tom Tromey  <tom@tromey.com>
3739
3740         * unittests/format_pieces-selftests.c: Update.  Add final format.
3741         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3742         empty literal pieces.
3743
3744 2019-10-01  Tom Tromey  <tom@tromey.com>
3745
3746         * ui-out.h (enum class ui_out_style_kind): Remove.
3747         (class ui_out) <field_string, field_stsream, do_field_string>:
3748         Change type of "style".
3749         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3750         (ui_out::field_string): Update.
3751         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3752         of "style".
3753         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3754         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3755         * stack.c (print_frame_arg, print_frame_info, print_frame):
3756         Update.
3757         * source.c (print_source_lines_base): Update.
3758         * solib.c (info_sharedlibrary_command): Update.
3759         * skip.c (info_skip_command): Update.
3760         * record-btrace.c (btrace_call_history_src_line)
3761         (btrace_call_history): Update.
3762         * python/py-framefilter.c (py_print_frame): Update.
3763         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3764         "style".
3765         * mi/mi-out.c (mi_ui_out::do_table_header)
3766         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3767         (mi_ui_out::do_field_string): Update.
3768         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3769         Update.
3770         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3771         "style".
3772         * cli-out.c (cli_ui_out::do_table_header)
3773         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3774         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3775         (cli_ui_out::do_field_fmt): Update.
3776         * breakpoint.c (print_breakpoint_location): Update.
3777         (update_static_tracepoint): Update.
3778
3779 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3780
3781         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3782         conversion of gdb_datadir.
3783         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3784         remove not needed c_str ().
3785
3786 2019-09-30  Ali Tamur <tamur@google.com>
3787
3788         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3789         (dwarf2_string_attr): Likewise.
3790
3791 2019-09-30  Ali Tamur <tamur@google.com>
3792
3793         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3794         (process_full_type_unit): Likewise.
3795         (dump_die_shallow): Likewise.
3796         (cu_debug_loc_section): Likewise.
3797
3798 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3799
3800         * minsyms.c (compare_minimal_symbols): Rename to...
3801         (minimal_symbol_is_less_than): ...this, and adjust to STL
3802         conventions (return bool, take arguments as references)
3803         (minimal_symbol_reader::install): Call std::sort instead
3804         of qsort.
3805
3806 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3807
3808         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3809         hash and why.
3810         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3811         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3812
3813 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3814
3815         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3816         * psympriv.h (add_psymbol_to_list): Move comment here and update
3817         it.
3818
3819 2019-09-29  Tom de Vries  <tdevries@suse.de>
3820
3821         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3822         Use $tmpdir/$(basename "$output_file").dwz instead of
3823         "${output_file}.dwz".
3824
3825 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3826
3827         PR gdb/25045
3828         * hppa-linux-nat.c: Include gdbarch.h.
3829
3830 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3831
3832         * blockframe.c (find_pc_partial_function): Change return type to bool.
3833         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3834         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3835         (stub_gnu_ifunc_resolve_name): Likewise.
3836         * symtab.c (compare_filenames_for_search): Likewise.
3837         (compare_glob_filenames_for_search): Likewise.
3838         (matching_obj_sections): Likewise.
3839         (symbol_matches_domain): Likewise.
3840         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3841         (find_line_pc): Change return type to bool.
3842         (find_line_pc_range): Likewise.
3843         (producer_is_realview): Likewise.
3844         * symtab.h (symbol_matches_domain): Likewise.
3845         (find_pc_partial_function): Likewise.
3846         (find_pc_line_pc_range): Likewise.
3847         (in_gnu_ifunc_stub): Likewise.
3848         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3849         (find_line_pc): Likewise.
3850         (find_line_pc_range): Likewise.
3851         (matching_obj_sections): Likewise.
3852         (find_line_symtab): Change out parameter to bool.
3853         (producer_is_realview): Change return type to bool.
3854         (compare_filenames_for_search): Likewise.
3855         (compare_glob_filenames_for_search): Likewise.
3856
3857 2019-09-26  Tom Tromey  <tom@tromey.com>
3858
3859         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3860         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3861         * gdb_usleep.h: Remove.
3862         * gdb_usleep.c: Remove.
3863         * utils.c: Don't include gdb_usleep.h.
3864
3865 2019-09-26  Tom Tromey  <tromey@adacore.com>
3866
3867         * python/py-type.c (type_to_type_object): Call check_typedef
3868         for stub types.
3869
3870 2019-09-26  Tom Tromey  <tom@tromey.com>
3871
3872         * utils.h (initialize_utils): Don't declare.
3873         * top.c (gdb_init): Don't call initialize_utils.
3874         * utils.c (initialize_utils): Remove.  Move contents...
3875         (_initialize_utils): ... here.
3876
3877 2019-09-25  Tom Tromey  <tom@tromey.com>
3878
3879         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3880         * utils.h (make_hex_string): Don't declare.
3881         * utils.c (make_hex_string): Remove.
3882
3883 2019-09-24  Tom de Vries  <tdevries@suse.de>
3884
3885         PR gdb/23815
3886         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3887         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3888
3889 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3890
3891         * NEWS: Mention new simulator port for PRU.
3892
3893 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3894
3895         * ada-exp.y (write_object_remaining): Update.
3896         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3897         and eliminate the static buffer.
3898         (ada_decode_symbol): Update.
3899         (ada_la_decode): Update.
3900         (ada_sniff_from_mangled_name): Update.
3901         (is_valid_name_for_wild_match): Update.
3902         (ada_lookup_name_info::matches): Update and simplify.
3903         (name_matches_regex): Update.
3904         (ada_add_global_exceptions): Update.
3905         * ada-lang.h (ada_decode): Update signature.
3906         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3907         * dwarf-index-write.c (debug_names::insert): Update.
3908
3909 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3910
3911         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3912         formatting.
3913
3914 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3915
3916         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3917         Change "nonzero" to "true" in documentation.
3918
3919 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3920
3921         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3922         (_initialize_darwin_solib): Don't set
3923         darwin_so_ops.lookup_lib_global_symbol.
3924         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3925         set_gdbarch_iterate_over_objfiles_in_search_order.
3926         (elf_lookup_lib_symbol): Rename to...
3927         (svr4_iterate_over_objfiles_in_search_order): this, and update
3928         to iterate semantics.
3929         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3930         * solib.c (solib_global_lookup): Remove.
3931         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3932         (solib_global_lookup): Remove.
3933         * symtab.c (lookup_global_or_static_symbol): Remove call to
3934         solib_global_lookup.
3935
3936 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3937
3938         * NEWS: Move entries about default MI version now being
3939         version 3, and about the GDB/MI fix for multi-location
3940         breakpoints to the "since GDB 8.3" section.
3941
3942 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3943
3944         GDB 8.3.1 released.
3945
3946 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3947
3948         * NEWS: Mention that Cell/B.E. debugging support was removed.
3949         * MAINTAINERS: Remove spu target.
3950
3951         * config/djgpp/fnchange.lst: Remove entries for removed files.
3952
3953         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3954         spu-multiarch.o, and spu-tdep.o.
3955         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3956         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3957         spu-multiarch.c, and spu-tdep.c.
3958         * spu-linux-nat.c: Remove file.
3959         * spu-multiarch.c: Remove file.
3960         * spu-tdep.c: Remove file.
3961         * spu-tdep.h: Remove file.
3962         * solib-spu.c: Remove file.
3963         * solib-spu.h: Remove file.
3964
3965         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3966         * configure.nat (spu-linux): Remove.
3967         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3968         solib-multiarch.o from gdb_target_obs.
3969         (spu*-*-*): Remove.
3970
3971         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3972         feature flag.
3973         (ppc_linux_no_features): Update.
3974         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3975         Cell/B.E. support.
3976         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3977         (tdesc_powerpc_cell64l): Likewise.
3978         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3979         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3980         Cell/B.E. support.
3981         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3982         Do not include "features/rs6000/powerpc-cell32l.c" or
3983         "features/rs6000/powerpc-cell64l.c".
3984         (ppc_linux_spu_section): Remove.
3985         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3986         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3987         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3988         (ppc_linux_spe_context_lookup): Remove.
3989         (ppc_linux_spe_context_inferior_created): Remove.
3990         (ppc_linux_spe_context_solib_loaded): Remove.
3991         (ppc_linux_spe_context_solib_unloaded): Remove.
3992         (ppc_linux_spe_context): Remove.
3993         (struct ppu2spu_cache): Remove.
3994         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3995         (struct ppu2spu_data): Remove.
3996         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3997         ppu2spu_unwind): Remove.
3998         (ppc_linux_init_abi): Remove Cell/B.E. support.
3999         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4000
4001         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4002         (rs6000/powerpc-cell64l-expedite): Likewise
4003         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4004         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4005         rs6000/powerpc-cell64l.xml.
4006         * features/rs6000/powerpc-cell32l.xml: Remove.
4007         * features/rs6000/powerpc-cell64l.xml: Likewise.
4008         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4009         * features/rs6000/powerpc-cell64l.c: Likewise.
4010         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4011         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4012         * regformats/reg-spu.dat: Remove.
4013
4014         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4015         * corelow.c (struct spuid_list): Remove.
4016         (add_to_spuid_list): Remove.
4017         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4018         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4019         (remote_protocol_features): Remove associated entries.
4020         (_initialize_remote): No longer initialize them.
4021         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4022         * linux-nat.c (SPUFS_MAGIC): Remove.
4023         (linux_proc_xfer_spu): Remove.
4024         (spu_enumerate_spu_ids): Remove.
4025         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4026         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4027         (linux_make_corefile_notes): No longer call it.
4028
4029         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4030         (cooked_write_test): Likewise.
4031
4032 2019-09-20  Tom Tromey  <tom@tromey.com>
4033
4034         * NEWS: Mention case-sensitivity of TUI commands.
4035         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4036         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4037         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4038
4039 2019-09-20  Tom Tromey  <tom@tromey.com>
4040
4041         * tui/tui-source.c (tui_source_window::set_contents): Use
4042         make_unique_xstrdup.
4043         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4044         make_unique_xstrdup.
4045
4046 2019-09-20  Tom Tromey  <tom@tromey.com>
4047
4048         * tui/tui-data.c: Remove separator comments.
4049         * tui/tui-layout.c: Remove separator comments.
4050         * tui/tui-win.c: Remove separator comments.
4051         * tui/tui-wingeneral.c: Remove separator comments.
4052
4053 2019-09-20  Tom Tromey  <tom@tromey.com>
4054
4055         * tui/tui.h (strcat_to_buf): Don't declare.
4056         * tui/tui.c (strcat_to_buf): Remove.
4057
4058 2019-09-20  Tom Tromey  <tom@tromey.com>
4059
4060         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4061         from "fullname".
4062         * tui/tui-source.c (tui_source_window::set_contents)
4063         (tui_source_window::location_matches_p)
4064         (tui_source_window::maybe_update): Update.
4065
4066 2019-09-20  Tom Tromey  <tom@tromey.com>
4067
4068         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4069         Update.
4070         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4071         prefix.
4072         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4073         (tui_data_window::line_from_reg_element_no)
4074         (tui_data_window::first_reg_element_no_inline)
4075         (tui_data_window::show_registers)
4076         (tui_data_window::show_register_group)
4077         (tui_data_window::display_registers_from)
4078         (tui_data_window::display_registers_from_line)
4079         (tui_data_window::first_data_item_displayed)
4080         (tui_data_window::delete_data_content_windows)
4081         (tui_data_window::erase_data_content)
4082         (tui_data_window::do_scroll_vertical)
4083         (tui_data_window::refresh_window)
4084         (tui_data_window::check_register_values): Update.
4085
4086 2019-09-20  Tom Tromey  <tom@tromey.com>
4087
4088         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4089         (struct tui_locator_window) <full_name, proc_name>: Now
4090         std::string.
4091         * tui/tui-stack.c (tui_locator_window::make_status_line)
4092         (tui_locator_window::set_locator_fullname)
4093         (tui_locator_window::set_locator_info): Update.
4094         * tui/tui-source.c (tui_source_window::set_contents)
4095         (tui_source_window::showing_source_p): Update.
4096
4097 2019-09-20  Tom Tromey  <tom@tromey.com>
4098
4099         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4100         Don't call tui_locator_win_info_ptr.
4101
4102 2019-09-20  Tom Tromey  <tom@tromey.com>
4103
4104         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4105
4106 2019-09-20  Tom Tromey  <tom@tromey.com>
4107
4108         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4109         height for locator.
4110         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4111         * tui/tui-layout.c (show_source_disasm_command, show_data)
4112         (show_source_or_disasm_and_command): Use 1 as height for locator.
4113
4114 2019-09-20  Tom Tromey  <tom@tromey.com>
4115
4116         * tui/tui.c (tui_enable): Update.
4117         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4118         Update.
4119         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4120         Update.
4121         * tui/tui-data.c (win_resized): Now bool.
4122         (tui_win_resized): Return bool.
4123         (tui_set_win_resized_to): Accept a bool.
4124
4125 2019-09-20  Tom Tromey  <tom@tromey.com>
4126
4127         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4128         Change type of "refresh_values_only".
4129         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4130         type of "refresh_values_only".
4131
4132 2019-09-20  Tom Tromey  <tom@tromey.com>
4133
4134         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4135         std::string.
4136         (tui_disassemble): Add "pos" parameter.
4137         (tui_disasm_window::set_contents): Simplify.
4138
4139 2019-09-20  Tom Tromey  <tom@tromey.com>
4140
4141         * tui/tui-winsource.h (struct tui_source_window_base)
4142         <show_source_content>: Now private.
4143         * tui/tui-winsource.c
4144         (tui_source_window_base::show_source_content): Don't handle empty
4145         content case.
4146
4147 2019-09-20  Tom Tromey  <tom@tromey.com>
4148
4149         * tui/tui-layout.c (show_source_disasm_command)
4150         (show_source_or_disasm_and_command): Don't call
4151         show_source_content.
4152
4153 2019-09-20  Tom Tromey  <tom@tromey.com>
4154
4155         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4156         Declare.
4157         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4158         from tui_make_status_line.
4159         (tui_locator_window::rerender): Update.
4160
4161 2019-09-20  Tom Tromey  <tom@tromey.com>
4162
4163         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4164         (tui_locator_window::rerender): Update.
4165
4166 2019-09-20  Tom Tromey  <tom@tromey.com>
4167
4168         * tui/tui-winsource.h (struct tui_source_window_base)
4169         <~tui_source_window_base>: Don't declare.
4170         <fullname>: Remove.
4171         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4172         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4173         member.
4174         * tui/tui-source.c (tui_source_window::set_contents): Update.
4175         (tui_source_window::location_matches_p)
4176         (tui_source_window::maybe_update): Update.
4177
4178 2019-09-20  Tom Tromey  <tom@tromey.com>
4179
4180         * tui/tui-winsource.h (~tui_source_element): Remove.
4181         (tui_source_element): Update.
4182         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4183         * tui/tui-winsource.c (tui_show_source_line): Update.
4184         * tui/tui-source.c (tui_source_window::set_contents): Update.
4185         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4186
4187 2019-09-20  Tom Tromey  <tom@tromey.com>
4188
4189         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4190         declare.
4191         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4192         tui_clear_source_windows_detail.
4193         * tui/tui-winsource.h (struct tui_source_window_base)
4194         <clear_detail>: Don't declare.
4195         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4196         Remove.
4197         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4198
4199 2019-09-20  Tom Tromey  <tromey@adacore.com>
4200
4201         PR ada/24919:
4202         * block.c (contained_in): Fix final return value.
4203
4204 2019-09-20  Alan Modra  <amodra@gmail.com>
4205
4206         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4207         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4208         (read_indirect_string_from_dwz): Use bfd accessor.
4209         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4210         * machoread.c (macho_symfile_read_all_oso): Likewise.
4211         * solib.c (solib_bfd_open): Likewise.
4212
4213 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4214
4215         * eval.c: Move declaration of overload_resolution to...
4216         * value.h: ...here.
4217
4218 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4219
4220         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4221         * arm-linux-tdep.c: Likewise.
4222         * arm-nbsd-nat.c: Likewise.
4223         * arm-tdep.h: Declare arm_apcs_32.
4224         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4225
4226 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4227
4228         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4229         * dwarf2read.h: Declare dwarf_always_disassemble.
4230
4231 2019-09-19  Tom de Vries  <tdevries@suse.de>
4232
4233         PR gdb/25009
4234         * source-cache.c (source_cache::ensure): Catch exception thrown during
4235         construction of the highlighter.
4236
4237 2019-09-18  Alan Modra  <amodra@gmail.com>
4238
4239         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4240         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4241         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4242         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4243         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4244         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4245         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4246         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4247         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4248         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4249         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4250         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4251         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4252         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4253         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4254         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4255         * mi/mi-interp.c: Update throughout for bfd section macro and
4256         function changes.
4257         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4258         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4259
4260 2019-09-18  Tom Tromey  <tom@tromey.com>
4261
4262         * NEWS: Add entry.
4263         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4264         call rl_initialize.
4265         (tui_enable): Do not call rl_initialize.
4266
4267 2019-09-18  Christian Groessler  <chris@groessler.org>
4268
4269         * alpha-linux-nat.c: Include gdbarch.h.
4270
4271 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4272
4273         * ui-file.c: Include cli/cli-style.h.
4274         (term_cli_styling): Remove cli_styling declaration.
4275
4276 2019-09-18  Alan Modra  <amodra@gmail.com>
4277
4278         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4279         to bfd_asymbol_section.
4280
4281 2019-09-18  Alan Modra  <amodra@gmail.com>
4282
4283         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4284         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4285         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4286
4287 2019-09-18  Alan Modra  <amodra@gmail.com>
4288
4289         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4290         * spu-linux-nat.c (spu_bfd_open): Likewise.
4291
4292 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4293
4294         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4295         to bool to match definition in dwarf2read.c.
4296
4297 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4298
4299         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4300         (print_signatures): Likewise.
4301         (trust_pad_over_xvs): Likewise.
4302         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4303         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4304         * arm-linux-nat.c (arm_apcs_32): Likewise.
4305         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4306         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4307         * arm-tdep.c (arm_debug): Likewise.
4308         (arm_apcs_32): Likewise.
4309         * auto-load.c (debug_auto_load): Likewise.
4310         (auto_load_gdb_scripts): Likewise.
4311         (global_auto_load): Likewise.
4312         (auto_load_local_gdbinit): Likewise.
4313         (auto_load_local_gdbinit_loaded): Likewise.
4314         * auto-load.h (global_auto_load): Likewise.
4315         (auto_load_local_gdbinit): Likewise.
4316         (auto_load_local_gdbinit_loaded): Likewise.
4317         * breakpoint.c (disconnected_dprintf): Likewise.
4318         (breakpoint_proceeded): Likewise.
4319         (automatic_hardware_breakpoints): Likewise.
4320         (always_inserted_mode): Likewise.
4321         (target_exact_watchpoints): Likewise.
4322         (_initialize_breakpoint): Update.
4323         * breakpoint.h (target_exact_watchpoints): Change to bool.
4324         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4325         * cli/cli-cmds.c (trace_commands): Likewise.
4326         * cli/cli-cmds.h (trace_commands): Likewise.
4327         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4328         to bool*.
4329         * cli/cli-logging.c (logging_overwrite): Change to bool.
4330         (logging_redirect): Likewise.
4331         (debug_redirect): Likewise.
4332         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4333         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4334         to bool.
4335         <boolean_option_def>: Update.
4336         (struct flag_option_def): Change default type of Context to bool
4337         from int.
4338         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4339         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4340         (get_setshow_command_value_string): Likewise.
4341         * cli/cli-style.c (cli_styling): Change to bool.
4342         (source_styling): Likewise.
4343         * cli/cli-style.h (source_styling): Likewise.
4344         (cli_styling): Likewise.
4345         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4346         to bool.
4347         * command.h (var_types): Update comment.
4348         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4349         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4350         bool.
4351         (debug_compile_cplus_scopes): Likewise.
4352         * compile/compile-internal.h (compile_debug): Likewise.
4353         * compile/compile.c (compile_debug): Likewise.
4354         (struct compile_options) <raw>: Likewise.
4355         * cp-support.c (catch_demangler_crashes): Likewise.
4356         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4357         (usr_cmd_cris_dwarf2_cfi): Likewise.
4358         * csky-tdep.c (csky_debug): Likewise.
4359         * darwin-nat.c (enable_mach_exceptions): Likewise.
4360         * dcache.c (dcache_enabled_p): Likewise.
4361         * defs.h (info_verbose): Likewise.
4362         * demangle.c (demangle): Likewise.
4363         (asm_demangle): Likewise.
4364         * dwarf-index-cache.c (debug_index_cache): Likewise.
4365         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4366         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4367         * dwarf2read.c (check_physname): Likewise.
4368         (use_deprecated_index_sections): Likewise.
4369         (dwarf_always_disassemble): Likewise.
4370         * eval.c (overload_resolution): Likewise.
4371         * event-top.c (set_editing_cmd_var): Likewise.
4372         (exec_done_display_p): Likewise.
4373         * event-top.h (set_editing_cmd_var): Likewise.
4374         (exec_done_display_p): Likewise.
4375         * exec.c (write_files): Likewise.
4376         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4377         (debug_fbsd_nat): Likewise.
4378         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4379         Likewise.
4380         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4381         <backtrace_past_entry> Likewise.
4382         * gdb-demangle.h (demangle): Likewise.
4383         (asm_demangle): Likewise.
4384         * gdb_bfd.c (bfd_sharing): Likewise.
4385         * gdbcore.h (write_files): Likewise.
4386         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4387         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4388         * gdbthread.h (print_thread_events): Likewise.
4389         * gdbtypes.c (opaque_type_resolution): Likewise.
4390         (strict_type_checking): Likewise.
4391         * gnu-nat.c (gnu_debug_flag): Likewise.
4392         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4393         * guile/scm-param.c (pascm_variable): Add boolval.
4394         (add_setshow_generic): Update.
4395         (pascm_param_value): Update.
4396         (pascm_set_param_value_x): Update.
4397         * hppa-tdep.c (hppa_debug): Change to bool..
4398         * infcall.c (may_call_functions_p): Likewise.
4399         (coerce_float_to_double_p): Likewise.
4400         (unwind_on_signal_p): Likewise.
4401         (unwind_on_terminating_exception_p): Likewise.
4402         * infcmd.c (startup_with_shell): Likewise.
4403         * inferior.c (print_inferior_events): Likewise.
4404         * inferior.h (startup_with_shell): Likewise.
4405         (print_inferior_events): Likewise.
4406         * infrun.c (step_stop_if_no_debug): Likewise.
4407         (detach_fork): Likewise.
4408         (debug_displaced): Likewise.
4409         (disable_randomization): Likewise.
4410         (non_stop): Likewise.
4411         (non_stop_1): Likewise.
4412         (observer_mode): Likewise.
4413         (observer_mode_1): Likewise.
4414         (set_observer_mode): Update.
4415         (sched_multi): Change to bool.
4416         * infrun.h (debug_displaced): Likewise.
4417         (sched_multi): Likewise.
4418         (step_stop_if_no_debug): Likewise.
4419         (non_stop): Likewise.
4420         (disable_randomization): Likewise.
4421         * linux-tdep.c (use_coredump_filter): Likewise.
4422         (dump_excluded_mappings): Likewise.
4423         * linux-thread-db.c (auto_load_thread_db): Likewise.
4424         (check_thread_db_on_load): Likewise.
4425         * main.c (captured_main_1): Update.
4426         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4427         xx2_opt, boolean_opt>: Change to bool.
4428         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4429         * maint.c (maintenance_profile_p): Likewise.
4430         (per_command_time): Likewise.
4431         (per_command_space): Likewise.
4432         (per_command_symtab): Likewise.
4433         * memattr.c (inaccessible_by_default): Likewise.
4434         * mi/mi-main.c (mi_async): Likewise.
4435         (mi_async_1): Likewise.
4436         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4437         * nat/fork-inferior.h (startup_with_shell): Likewise.
4438         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4439         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4440         * nios2-tdep.c (nios2_debug): Likewise.
4441         * or1k-tdep.c (or1k_debug): Likewise.
4442         * parse.c (parser_debug): Likewise.
4443         * parser-defs.h (parser_debug): Likewise.
4444         * printcmd.c (print_symbol_filename): Likewise.
4445         * proc-api.c (procfs_trace): Likewise.
4446         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4447         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4448         (set_parameter_value): Update.
4449         (add_setshow_generic): Update.
4450         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4451         to bool*.
4452         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4453         int*.
4454         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4455         * record-btrace.c (record_btrace_target::store_registers): Update.
4456         * record-full.c (record_full_memory_query): Change to bool.
4457         (record_full_stop_at_limit): Likewise.
4458         * record-full.h (record_full_memory_query): Likewise.
4459         * remote-notif.c (notif_debug): Likewise.
4460         * remote-notif.h (notif_debug): Likewise.
4461         * remote.c (use_range_stepping): Likewise.
4462         (interrupt_on_connect): Likewise.
4463         (remote_break): Likewise.
4464         * ser-tcp.c (tcp_auto_retry): Likewise.
4465         * ser-unix.c (serial_hwflow): Likewise.
4466         * skip.c (debug_skip): Likewise.
4467         * solib-aix.c (solib_aix_debug): Likewise.
4468         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4469         (spu_auto_flush_cache_p): Likewise.
4470         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4471         Likewise.
4472         (struct info_print_options) <quiet>: Likewise.
4473         * symfile-debug.c (debug_symfile): Likewise.
4474         * symfile.c (auto_solib_add): Likewise.
4475         (separate_debug_file_debug): Likewise.
4476         * symfile.h (auto_solib_add): Likewise.
4477         (separate_debug_file_debug): Likewise.
4478         * symtab.c (basenames_may_differ): Likewise.
4479         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4480         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4481         (struct info_types_options) <quiet>: Likewise.
4482         * symtab.h (demangle): Likewise.
4483         (basenames_may_differ): Likewise.
4484         * target-dcache.c (stack_cache_enabled_1): Likewise.
4485         (code_cache_enabled_1): Likewise.
4486         * target.c (trust_readonly): Likewise.
4487         (may_write_registers): Likewise.
4488         (may_write_memory): Likewise.
4489         (may_insert_breakpoints): Likewise.
4490         (may_insert_tracepoints): Likewise.
4491         (may_insert_fast_tracepoints): Likewise.
4492         (may_stop): Likewise.
4493         (auto_connect_native_target): Likewise.
4494         (target_stop_and_wait): Update.
4495         (target_async_permitted): Change to bool.
4496         (target_async_permitted_1): Likewise.
4497         (may_write_registers_1): Likewise.
4498         (may_write_memory_1): Likewise.
4499         (may_insert_breakpoints_1): Likewise.
4500         (may_insert_tracepoints_1): Likewise.
4501         (may_insert_fast_tracepoints_1): Likewise.
4502         (may_stop_1): Likewise.
4503         * target.h (target_async_permitted): Likewise.
4504         (may_write_registers): Likewise.
4505         (may_write_memory): Likewise.
4506         (may_insert_breakpoints): Likewise.
4507         (may_insert_tracepoints): Likewise.
4508         (may_insert_fast_tracepoints): Likewise.
4509         (may_stop): Likewise.
4510         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4511         (make_thread_apply_all_options_def_group): Change argument from int*
4512         to bool*.
4513         (thread_apply_all_command): Update.
4514         (print_thread_events): Change to bool.
4515         * top.c (confirm): Likewise.
4516         (command_editing_p): Likewise.
4517         (history_expansion_p): Likewise.
4518         (write_history_p): Likewise.
4519         (info_verbose): Likewise.
4520         * top.h (confirm): Likewise.
4521         (history_expansion_p): Likewise.
4522         * tracepoint.c (disconnected_tracing): Likewise.
4523         (circular_trace_buffer): Likewise.
4524         * typeprint.c (print_methods): Likewise.
4525         (print_typedefs): Likewise.
4526         * utils.c (debug_timestamp): Likewise.
4527         (sevenbit_strings): Likewise.
4528         (pagination_enabled): Likewise.
4529         * utils.h (sevenbit_strings): Likewise.
4530         (pagination_enabled): Likewise.
4531         * valops.c (overload_resolution): Likewise.
4532         * valprint.h (struct value_print_options) <prettyformat_arrays,
4533         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4534         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4535         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4536         Likewise.
4537         * windows-nat.c (new_console): Likewise.
4538         (cygwin_exceptions): Likewise.
4539         (new_group): Likewise.
4540         (debug_exec): Likewise.
4541         (debug_events): Likewise.
4542         (debug_memory): Likewise.
4543         (debug_exceptions): Likewise.
4544         (useshell): Likewise.
4545         * windows-tdep.c (maint_display_all_tib): Likewise.
4546         * xml-support.c (debug_xml): Likewise.
4547
4548 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4549
4550         * source.c (prepare_path_for_appending): New function.
4551         (openp): Make use of new function.
4552         (find_and_open_source): Search for the compilation directory and
4553         source file as a relative path beneath the directory search path.
4554
4555 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4556
4557         * source-cache.c (source_cache::get_line_charpos): Catch
4558         exceptions and return false, this matches the behaviour documented
4559         in the header file.
4560
4561 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4562
4563         * ada-tasks.c (info_task): Remove quoting of the task's name.
4564
4565 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4566
4567         * symfile.c (auto_solib_add): Replace comment with a reference
4568         to the header file.
4569
4570 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4571
4572         * NEWS: Mention that gdb can now be compiled with Python 3
4573         on Windows.
4574
4575 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4576
4577         * maint.c (maint_print_section_data::maint_print_section_data):
4578         Force use of 'float log10 (float)' by casting the argument to
4579         float.
4580
4581 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4582
4583         * maint.c: Add 'cmath' include.
4584         (struct maint_print_section_data): New structure.
4585         (print_section_index): New function.
4586         (print_bfd_section_info): Add header comment, small whitespace
4587         cleanup, and update to call new print_section_index function.
4588         (print_objfile_section_info): Likewise.
4589         (maint_obj_section_from_bfd_section): New function.
4590         (print_bfd_section_info_maybe_relocated): New function.
4591         (maintenance_info_sections): Add header comment, always use
4592         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4593
4594 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4595
4596         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4597         inner scope, add check that the objfile has psymtabs before
4598         checking psymtabs_addrmap.
4599         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4600
4601 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4602
4603         * NEWS: Announce that Ada task names are now shown at more places,
4604         and between quotes (except in info task output).
4605         * gdb/ada-tasks.c (task_to_str): New function.
4606         (display_current_task_id): Call task_to_str.
4607         (task_command_1): Likewise.
4608         (print_ada_task_info): In non-mi mode, Properly align headers and data
4609         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4610
4611 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4612
4613         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4614         prstatus.pr_lwp.pr_info instead of making it up.
4615
4616 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4617
4618         * auto-load.c (auto_load_expand_dir_vars): Update.
4619         * defs.h (gdb_datadir): Change to std::string.
4620         (python_libdir): Likewise.
4621         (relocate_gdb_directory): Change return type to std::string.
4622         * guile/guile.c (gdbscm_data_directory): Update.
4623         (initialize_scheme_side): Update.
4624         * jit.c (jit_reader_dir): Change to std::string.
4625         (jit_reader_load_command): Update.
4626         * main.c (gdb_datadir): Change to std::string.
4627         (python_libdir): Likewise.
4628         (set_gdb_data_directory): Update.
4629         (relocate_path): Change to return std::string.
4630         (relocate_gdb_directory): Change to return std::string.
4631         (relocate_gdbinit_path_maybe_in_datadir): Update.
4632         (captured_main_1): Update.
4633         * python/python.c (do_start_initialization): Update.
4634         * top.c (show_gdb_datadir): Update.
4635         * xml-syscall.c (xml_init_syscalls_info): Update.
4636         (init_syscalls_info): Update.
4637
4638 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4639
4640         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4641         out of get_init_files.
4642         (get_init_files): Update.
4643
4644 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4645
4646         * main.c (get_init_files): Change to use std::string.
4647         (captured_main_1): Update.
4648         (print_gdb_help): Update.
4649
4650 2019-09-11  Ali Tamur  <tamur@google.com>
4651
4652         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4653         implementation.
4654
4655 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4656
4657         * dbxread.c (read_dbx_symtab): Update.
4658         * dwarf2read.c (load_partial_dies): Update.
4659         * mdebugread.c (parse_partial_symbols): Update.
4660         (handle_psymbol_enumerators): Update.
4661         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4662         * psymtab.c (add_psymbol_to_bcache): Likewise.
4663         (add_psymbol_to_list): Likewise.
4664         * symtab.c (symbol_set_names): Likewise.
4665         * symtab.h (symbol_set_names): Likewise.
4666         * xcoffread.c (scan_xcoff_symtab): Update.
4667
4668 2019-09-11  Tom Tromey  <tom@tromey.com>
4669
4670         * symfile-mem.c (symbol_file_add_from_memory): Use
4671         bfd_set_filename.
4672         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4673         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4674
4675 2019-09-10  Tom Tromey  <tromey@adacore.com>
4676
4677         * dwarf-index-write.c (write_psymbols): Extend error message.
4678         (debug_names::insert): Add Ada code.
4679         (debug_names::write_psymbols): Remove Ada check.
4680         (debug_names) <m_string_obstack>: New member.
4681         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4682         (gdb_index_symbol_name_matcher::matches): Remove.
4683         (mapped_index_base::find_name_components_bounds): Add "lang"
4684         parameter.
4685         (mapped_index_base::build_name_components): Also split names
4686         according to Ada syntax.
4687         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4688         type of "match_callback".
4689         (check_match, check_find_bounds_finds)
4690         (dw2_expand_symtabs_matching): Update.
4691         (dw2_debug_names_iterator): Add new constructor.
4692         (dw2_debug_names_map_matching_symbols): New function.
4693         (dw2_debug_names_expand_symtabs_matching): Update.
4694         (dwarf2_debug_names_functions): Use
4695         dw2_debug_names_map_matching_symbols.
4696
4697 2019-09-10  Tom Tromey  <tromey@adacore.com>
4698
4699         * dwarf2read.c (dw2_get_file_names_reader): Add the
4700         CU's file name to the results.
4701
4702 2019-09-10  Tom Tromey  <tromey@adacore.com>
4703
4704         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4705         map_matching_symbols.  Update.
4706         * dwarf2read.c (dw2_map_matching_symbols): Update.
4707         * psymtab.c (match_partial_symbol): Change type; update.
4708         (psym_map_matching_symbols): Likewise.
4709         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4710         type; update.
4711         * symfile.h (struct quick_symbol_functions)
4712         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4713         Remove "match".
4714
4715 2019-09-10  Tom Tromey  <tromey@adacore.com>
4716
4717         * psymtab.c (map_block): Remove.
4718         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4719         * symtab.c (iterate_over_symbols_terminated): New function.
4720         * symtab.c (iterate_over_symbols_terminated): Declare.
4721
4722 2019-09-10  Tom Tromey  <tromey@adacore.com>
4723
4724         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4725         * language.h (struct language_defn) <la_iterate_over_symbols>:
4726         Return bool.
4727         * symtab.c (iterate_over_symbols): Return bool.
4728         * symtab.h (iterate_over_symbols): Return bool.
4729
4730 2019-09-10  Tom Tromey  <tromey@adacore.com>
4731
4732         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4733         (add_nonlocal_symbols): Update.
4734         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4735         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4736         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4737         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4738         Change type of "callback".  Remove "data".
4739
4740
4741 2019-09-09  Ali Tamur  <tamur@google.com>
4742
4743         * dwarf2read.c (comp_unit_head): Update comment.
4744         (dwarf2_dwo_name): New function declaration.
4745         (dwarf_unit_type_name): New function declaration.
4746         (read_comp_unit_head): Add support for new compilation units,
4747         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4748         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4749         (currently named as "signature") in their header. Also clarify error
4750         messages.
4751         (lookup_dwo_id): New function. Returns the dwo id of the given
4752         compile unit.
4753         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4754         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4755         functions.
4756         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4757         (dwarf2_dwo_name): Get the dwo name if present.
4758         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4759         purposes.
4760
4761 2019-09-09  Tom Tromey  <tom@tromey.com>
4762
4763         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4764
4765 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4766
4767         * python/python.c (do_start_initialization): Make progname_copy static,
4768         to avoid a leak report.
4769
4770 2019-09-08  Tom Tromey  <tom@tromey.com>
4771
4772         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4773
4774 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4775
4776         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4777         Change type to gdb::optional<block_enum>.
4778         (dw2_symtab_iter_init): Change block_index parameter type
4779         to gdb::optional<block_enum>.
4780         (dw2_lookup_symbol): Change block_index parameter
4781         type to block_enum.c
4782         (dw2_debug_names_lookup_symbol): Likewise.
4783         * psymtab.c (psym_lookup_symbol): Likewise.
4784         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4785         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4786         Likewise.
4787
4788 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4789
4790         * defs.h (relocate_gdb_directory): Change int to bool in
4791         signature and rename flag to relocatable.
4792         * main.c (relocate_path): Likewise.
4793         (relocate_gdb_directory): Likewise.
4794
4795 2019-09-06  Alan Modra  <amodra@gmail.com>
4796
4797         * coffread.c (coff_symfile_read): Constify filename variable.
4798         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4799         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4800         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4801         * solib.c (reload_shared_libraries_1): Likewise.
4802         * symfile.c (reread_symbols): Likewise.
4803         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4804         * solib-darwin.c (darwin_bfd_open): Likewise.
4805         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4806
4807 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4808
4809         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4810         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4811
4812 2019-09-03  Tom Tromey  <tromey@adacore.com>
4813
4814         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4815         types.
4816         (has_negatives): Unbias a range type bound.
4817         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4818         * gdbtypes.c (operator==): Handle new field.
4819         (create_range_type): Add "bias" parameter.
4820         (create_static_range_type, resolve_dynamic_range): Update.
4821         * gdbtypes.h (struct range_bounds) <bias>: New member.
4822         (create_range_type): Add bias parameter.
4823         * printcmd.c (print_scalar_formatted): Unbias range types.
4824         * value.c (unpack_long): Unbias range types.
4825         (pack_long): Bias range types.
4826
4827 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4828
4829         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4830         probe arguments.
4831
4832 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4833
4834         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4835         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4836         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4837         (compile_probe_arg): Likewise.
4838         * probe.h (get_argument_count): Likewise.
4839         * solib-svr4.c (solib_event_probe_action): Likewise.
4840         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4841
4842 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4843
4844         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4845         code to here...
4846         (svr4_create_solib_event_breakpoints): ...from here.
4847
4848 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4849
4850         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4851         suffix from warning message.
4852
4853 2019-08-30  Tom Tromey  <tom@tromey.com>
4854
4855         * tui/tui-winsource.h (struct tui_source_window_base)
4856         <refresh_all>: Don't declare.
4857         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4858         Remove.
4859         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4860         tui_show_locator_content.
4861         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4862         declare.
4863         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4864         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4865         declare.
4866
4867 2019-08-30  Tom Tromey  <tom@tromey.com>
4868
4869         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4870
4871 2019-08-30  Tom Tromey  <tom@tromey.com>
4872
4873         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4874         Remove unnecessary forward declarations.
4875
4876 2019-08-30  Tom Tromey  <tom@tromey.com>
4877
4878         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4879         rerender.
4880         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4881         tui_show_locator_content.
4882
4883 2019-08-30  Tom Tromey  <tom@tromey.com>
4884
4885         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4886         (tui_locator_window::rerender): Rewrite using body of previous
4887         tui_show_locator_content.
4888
4889 2019-08-30  Tom Tromey  <tom@tromey.com>
4890
4891         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4892         set_locator_fullname>: New methods.
4893         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4894         Rename from tui_set_locator_fullname.
4895         (tui_locator_window::set_locator_info): Rename from
4896         tui_set_locator_info.  Return bool.
4897         (tui_update_locator_fullname, tui_show_frame_info): Update.
4898
4899 2019-08-30  Tom Tromey  <tom@tromey.com>
4900
4901         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4902
4903 2019-08-30  Tom Tromey  <tom@tromey.com>
4904
4905         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4906         call touchwin.
4907
4908 2019-08-30  Tom Tromey  <tom@tromey.com>
4909
4910         * tui/tui-wingeneral.c (box_win): Assume win_info and
4911         win_info->handle cannot be NULL.
4912
4913 2019-08-30  Tom Tromey  <tom@tromey.com>
4914
4915         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4916         refresh_window>: Declare.
4917         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4918         resize.
4919         (tui_data_item_window::rerender): Rename from
4920         tui_display_register.
4921         (tui_data_item_window::refresh_window): New method.
4922         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4923         no-op.
4924
4925 2019-08-30  Tom Tromey  <tom@tromey.com>
4926
4927         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4928         regs_column_count, current_group>: Move later.  Now private.
4929         <get_current_group>: New method.
4930         * tui/tui-regs.c (tui_reg_command): Update.
4931         * tui/tui-layout.c (tui_set_layout): Update.
4932
4933 2019-08-30  Tom Tromey  <tom@tromey.com>
4934
4935         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4936         (tui_data_window::rerender): Don't call
4937         check_and_display_highlight_if_needed.
4938         (tui_data_window::refresh_all): Remove call to
4939         erase_data_content.
4940
4941 2019-08-30  Tom Tromey  <tom@tromey.com>
4942
4943         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4944         (tui_data_window::display_registers_from)
4945         (tui_data_window::display_reg_element_at_line)
4946         (tui_data_window::display_registers_from_line): Remove checks of
4947         "empty".
4948
4949 2019-08-30  Tom Tromey  <tom@tromey.com>
4950
4951         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4952         Don't declare.
4953         * tui/tui-regs.c (tui_data_window::show_registers): Call
4954         rerender.
4955         (tui_data_window::rerender): Rename from display_all_data.
4956         (tui_data_window::rerender): Remove old implementation.
4957
4958 2019-08-30  Tom Tromey  <tom@tromey.com>
4959
4960         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4961         text.
4962         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4963
4964 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4965             Sergio Durigan Junior  <sergiodj@redhat.com>
4966
4967         PR win32/24284
4968         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4969
4970 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4971
4972         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4973         when searching for types.
4974
4975 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4976
4977         * f-lang.c (f_language_defn): Use f_print_typedef.
4978         * f-lang.h (f_print_typedef): Declare.
4979         * f-typeprint.c (f_print_typedef): Define.
4980
4981 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4982
4983         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4984
4985 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4986
4987         * cli/cli-utils.c (info_print_options_defs): Delete.
4988         (make_info_print_options_def_group): Delete.
4989         (extract_info_print_options): Delete.
4990         (info_print_command_completer): Delete.
4991         (info_print_args_help): Add extra parameter, and optionally
4992         include text about -n flag.
4993         * cli/cli-utils.h (struct info_print_options): Delete.
4994         (extract_info_print_options): Delete declaration.
4995         (info_print_command_completer): Delete declaration.
4996         (info_print_args_help): Add extra parameter, extend header
4997         comment.
4998         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4999         search_symbols.
5000         * stack.c (struct info_print_options): New type.
5001         (info_print_options_defs): New file scoped variable.
5002         (make_info_print_options_def_group): New static function.
5003         (info_print_command_completer): New static function.
5004         (info_locals_command): Update to use new local functions.
5005         (info_args_command): Likewise.
5006         (_initialize_stack): Add extra parameter to calls to
5007         info_print_args_help.
5008         * symtab.c (search_symbols): Add extra parameter, use this to
5009         possibly excluse non-debug symbols.
5010         (symtab_symbol_info): Add extra parameter, which is passed on to
5011         search_symbols.
5012         (struct info_print_options): New type.
5013         (info_print_options_defs): New file scoped variable.
5014         (make_info_print_options_def_group): New static function.
5015         (info_print_command_completer): New static function.
5016         (info_variables_command): Update to use local functions, and pass
5017         extra parameter through to symtab_symbol_info.
5018         (info_functions_command): Likewise.
5019         (info_types_command): Pass additional argument through to
5020         symtab_symbol_info.
5021         (rbreak_command): Pass extra argument to search_symbols.
5022         (_initialize_symtab): Add extra arguments for calls to
5023         info_print_args_help, and update help text for 'info variables',
5024         'whereis', and 'info functions' commands.
5025         * symtab.h (search_symbols): Add extra argument to declaration.
5026         * NEWS: Mention new flags.
5027
5028 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5029
5030         * symtab.c (lookup_static_symbol): Call the new function (and move
5031         it down to be next to lookup_global_symbol).
5032         (struct global_sym_lookup_data): Add block_enum member and rename to...
5033         (struct global_or_static_sym_lookup_data): ...this.
5034         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5035         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5036         (lookup_symbol_global_or_static_iterator_cb): ...this.
5037         (lookup_global_or_static_symbol): New function.
5038         (lookup_global_symbol): Call new function.
5039
5040 2019-08-26  Tom de Vries  <tdevries@suse.de>
5041
5042         PR c++/24852
5043         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5044         when pc_probe.prob == NULL.
5045
5046 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5047
5048         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5049         variable symbol_linkage to symbol_linkage_.
5050
5051 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5052
5053         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5054         represent whether the symbol is static, dynamic, or we don't
5055         know.
5056
5057 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5058
5059         * gdb/rx-tdep.c (rx_register_names): New.
5060         (rx_register_name): Delete.
5061         (rx_psw_type): Delete.
5062         (rx_fpsw_type): Delete.
5063         (rx_register_type): Delete.
5064         (rx_gdbarch_init): Convert target-descriptions.
5065         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5066         * gdb/features/Makefile: Add rx.xml.
5067         * gdb/features/rx.xml: New.
5068         * gdb/features/rx.c: Generated.
5069         * gdb/NEWS: Mention target description support.
5070
5071 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5072
5073         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5074         *slot_ptr.
5075
5076 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5077
5078         * configure.ac: Don't check for 'dlfcn.h' (moved to
5079         gdbsupport/common.m4).
5080         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5081         'gdbsupport/'.
5082         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5083         * compile/compile-c-support.c: Include
5084         'gdbsupport/gdb-dlfcn.h'.
5085         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5086         * gdb-dlfcn.c: Move to...
5087         * gdbsupport/gdb-dlfcn.c: ... here.
5088         * gdb-dlfcn.h: Move to...
5089         * gdbsupport/gdb-dlfcn.h: ... here.
5090
5091 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5092
5093         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5094         the offset field signed.
5095
5096 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5097
5098         * python/lib/gdb/__init__.py (_execute_file): New function.
5099         * python/python.c (python_run_simple_file): Call gdb._execute_file
5100         on Windows.
5101
5102 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5103
5104         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5105         all uses as this was never set to anything but a zero value.
5106
5107 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5108
5109         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5110
5111 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5112
5113         * tui/tui-data.h (tui_gen_win_info): Add an =default
5114         move constructor, required by some GCC versions.
5115
5116 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5117
5118         * go32-nat.c (go32_sysinfo): Add hygon_p.
5119
5120 2019-08-20  Tom Tromey  <tom@tromey.com>
5121
5122         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5123         line_from_reg_element_no, first_reg_element_no_inline,
5124         display_all_data, delete_data_content_windows,
5125         erase_data_content>: Now private.
5126
5127 2019-08-20  Tom Tromey  <tom@tromey.com>
5128
5129         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5130         (tui_unhighlight_win, tui_highlight_win)
5131         (tui_win_info::make_window): Update.
5132         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5133
5134 2019-08-20  Tom Tromey  <tom@tromey.com>
5135
5136         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5137         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5138         (MAX_PID_WIDTH): Move to tui-stack.c.
5139         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5140         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5141         (MAX_PID_WIDTH): Move from tui-data.h.
5142
5143 2019-08-20  Tom Tromey  <tom@tromey.com>
5144
5145         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5146         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5147         (box_win): Update.
5148         (tui_gen_win_info::make_window): Rename from tui_make_window.
5149         (tui_win_info::make_window): New method.
5150         (tui_gen_win_info::make_visible): Update.
5151         * tui/tui-source.c (tui_source_window::set_contents): Update.
5152         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5153         (tui_data_window::display_registers_from): Update.
5154         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5155         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5156         Declare.
5157         <can_box>: Remove.
5158         <title>: Remove.
5159         (struct tui_win_info) <make_window>: Declare.
5160         <can_box>: Now virtual.
5161         <title>: New member.
5162         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5163         * tui/tui-command.c (tui_cmd_window::resize): Update.
5164
5165 2019-08-20  Tom Tromey  <tom@tromey.com>
5166
5167         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5168         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5169         (tui_data_window::check_register_values): Update.
5170
5171 2019-08-20  Tom Tromey  <tom@tromey.com>
5172
5173         * tui/tui-regs.h (struct tui_data_window): Use
5174         DISABLE_COPY_AND_ASSIGN.
5175         <regs_content>: Change type, removing unique_ptr.
5176         <tui_data_window>: Add move constructor.
5177         * tui/tui-regs.c (tui_data_window::show_registers)
5178         (tui_data_window::show_register_group)
5179         (tui_data_window::display_registers_from)
5180         (tui_data_window::display_registers_from)
5181         (tui_data_window::first_data_item_displayed)
5182         (tui_data_window::delete_data_content_windows)
5183         (tui_data_window::rerender, tui_data_window::refresh_window)
5184         (tui_data_window::check_register_values): Update.
5185
5186 2019-08-20  Tom Tromey  <tom@tromey.com>
5187
5188         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5189         show_register_group>: Declare.
5190         (tui_show_register_group): Don't declare.
5191         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5192         tui_show_registers.
5193         (tui_data_window::show_register_group): Rename from
5194         tui_show_register_group.
5195         (tui_data_window::check_register_values, tui_reg_command):
5196         Update.
5197         * tui/tui-layout.c (tui_set_layout): Update.
5198
5199 2019-08-20  Tom Tromey  <tom@tromey.com>
5200
5201         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5202         Declare.
5203         (tui_check_register_values): Don't declare.
5204         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5205         from tui_check_register_values.
5206         * tui/tui-hooks.c (tui_register_changed): Update.
5207
5208 2019-08-20  Tom Tromey  <tom@tromey.com>
5209
5210         * tui/tui-regs.c (tui_reg_layout): Move later.
5211         (tui_show_registers): Don't enable TUI mode or change layout.
5212
5213 2019-08-20  Tom Tromey  <tom@tromey.com>
5214
5215         * tui/tui-regs.h (struct tui_data_item_window)
5216         <~tui_data_item_window>: Remove.
5217         <content>: Now a unique_xmalloc_ptr.
5218         * tui/tui-regs.c (tui_register_format): Return a
5219         unique_xmalloc_ptr.
5220         (tui_get_register): Update.
5221         (~tui_data_item_window): Remove.
5222         (tui_data_window::display_registers_from, tui_display_register):
5223         Update.
5224         * tui/tui-io.h (tui_expand_tabs): Update.
5225         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5226         Remove "col" parameter.
5227
5228 2019-08-20  Tom Tromey  <tom@tromey.com>
5229
5230         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5231         field.
5232         * tui/tui-regs.c (~tui_data_item_window): Update.
5233
5234 2019-08-20  Tom Tromey  <tom@tromey.com>
5235
5236         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5237         earlier.
5238
5239 2019-08-20  Tom Tromey  <tom@tromey.com>
5240
5241         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5242
5243 2019-08-20  Tom Tromey  <tom@tromey.com>
5244
5245         * tui/tui-source.h (struct tui_source_window): Update.
5246         * tui/tui-regs.c (tui_show_registers): Update.
5247         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5248         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5249         (NO_REGS_STRING): Remove defines.
5250
5251 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5252
5253         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5254         unnecessary thread walk if remote doesn't support the packet.
5255
5256 2019-08-19  Tom Tromey  <tromey@adacore.com>
5257
5258         * python/py-value.c (value_has_field): Fix indentation.
5259
5260 2019-08-19  Tom Tromey  <tromey@adacore.com>
5261
5262         * printcmd.c (do_one_display, info_display_command): Update.
5263         * block.h (contained_in): Return bool.  Add allow_nested
5264         parameter.
5265         * block.c (contained_in): Return bool.  Add allow_nested
5266         parameter.
5267
5268 2019-08-19  Tom Tromey  <tom@tromey.com>
5269
5270         * configure: Rebuild.
5271         * configure.ac: Disallow the combination of -static-libstdc++ and
5272         source highlight.
5273         * source-cache.c (get_language_name): Handle rust.
5274         (source_cache::get_source_lines): Ignore highlighting exceptions.
5275
5276 2019-08-16  Tom Tromey  <tom@tromey.com>
5277
5278         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5279         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5280         (struct tui_source_window_base) <make_visible, refresh_window,
5281         resize>: Remove methods.
5282         <execution_info>: Remove field.
5283         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5284         (tui_show_source_line, tui_source_window_base)
5285         (~tui_source_window_base): Update.
5286         (tui_source_window_base::resize)
5287         (tui_source_window_base::make_visible)
5288         (tui_source_window_base::refresh_window): Remove.
5289         (tui_source_window_base::update_exec_info): Update.
5290         * tui/tui-source.c (tui_source_window::set_contents): Update.
5291         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5292
5293 2019-08-16  Tom Tromey  <tom@tromey.com>
5294
5295         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5296         deprecated_query_hook.
5297
5298 2019-08-16  Tom Tromey  <tom@tromey.com>
5299
5300         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5301         (tui_update_source_windows_with_line): Update.
5302         * tui/tui-source.h (struct tui_source_window)
5303         <show_symtab_source>: Declare.
5304         (tui_show_symtab_source): Don't declare.
5305         * tui/tui-source.c (tui_show_symtab_source): Rename from
5306         tui_show_symtab_source.
5307
5308 2019-08-16  Tom Tromey  <tom@tromey.com>
5309
5310         * tui/tui-winsource.h (struct tui_source_window_base)
5311         <set_contents>: Declare.
5312         * tui/tui-winsource.c
5313         (tui_source_window_base::update_source_window_as_is): Update.
5314         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5315         Declare.
5316         (tui_set_source_content): Don't declare.
5317         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5318         tui_set_source_content.
5319         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5320         Declare.
5321         (tui_set_disassem_content): Don't declare.
5322         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5323         tui_set_disassem_content.
5324
5325 2019-08-16  Tom Tromey  <tom@tromey.com>
5326
5327         * tui/tui-winsource.h (struct tui_source_window_base)
5328         <update_breakpoint_info>: Declare.
5329         (tui_update_breakpoint_info): Don't declare.
5330         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5331         (tui_update_all_breakpoint_info): Update.
5332         (tui_source_window_base::update_breakpoint_info): Rename from
5333         tui_update_breakpoint_info.
5334         (tui_source_window_base::update_exec_info): Update.
5335
5336 2019-08-16  Tom Tromey  <tom@tromey.com>
5337
5338         * tui/tui-winsource.h (struct tui_source_window_base)
5339         <update_source_window>: Declare.
5340         (tui_update_source_window): Don't declare.
5341         * tui/tui-winsource.c
5342         (tui_source_window_base::update_source_window): Rename from
5343         tui_update_source_window.
5344         (tui_source_window_base::rerender): Update.
5345         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5346         * tui/tui-disasm.c (tui_show_disassem)
5347         (tui_show_disassem_and_update_source)
5348         (tui_disasm_window::maybe_update): Update.
5349
5350 2019-08-16  Tom Tromey  <tom@tromey.com>
5351
5352         * tui/tui-winsource.h (struct tui_source_window_base)
5353         <update_source_window_as_is>: Declare.
5354         (tui_update_source_window_as_is): Don't declare.
5355         * tui/tui-winsource.c (tui_update_source_window): Update
5356         (tui_source_window_base::update_source_window_as_is): Rename from
5357         tui_update_source_window_as_is.
5358         (tui_source_window_base::refill): Update.
5359         * tui/tui-source.c (tui_show_symtab_source): Update.
5360         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5361         Update.
5362
5363 2019-08-16  Tom Tromey  <tom@tromey.com>
5364
5365         * tui/tui-winsource.h (tui_update_source_window)
5366         (tui_update_source_window_as_is): Remove "noerror" parameter.
5367         * tui/tui-winsource.c (tui_update_source_window)
5368         (tui_update_source_window_as_is): Remove "noerror" parameter.
5369         (tui_update_source_windows_with_addr)
5370         (tui_update_source_windows_with_line)
5371         (tui_source_window_base::rerender)
5372         (tui_source_window_base::refill): Update.
5373         * tui/tui-source.h (tui_set_source_content)
5374         (tui_show_symtab_source): Remove "noerror" parameter.
5375         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5376         parameter.
5377         (tui_show_symtab_source): Likewise.
5378         (tui_source_window::maybe_update): Update.
5379         * tui/tui-disasm.c (tui_show_disassem)
5380         (tui_show_disassem_and_update_source)
5381         (tui_disasm_window::do_scroll_vertical)
5382         (tui_disasm_window::maybe_update): Update.
5383
5384 2019-08-16  Tom Tromey  <tom@tromey.com>
5385
5386         * tui/tui.c (tui_is_window_visible): Update.
5387         * tui/tui-wingeneral.c (tui_make_window)
5388         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5389         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5390         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5391         (tui_set_win_height_command, parse_scrolling_args): Update.
5392         * tui/tui-source.c (tui_source_window::style_changed): Update.
5393         * tui/tui-regs.c (tui_show_registers)
5394         (tui_data_window::first_data_item_displayed)
5395         (tui_data_window::delete_data_content_windows)
5396         (tui_check_register_values, tui_reg_command): Update.
5397         * tui/tui-disasm.c (tui_show_disassem): Update.
5398         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5399         method.
5400         <is_visible>: Remove field.
5401         * tui/tui-data.c (tui_next_win, tui_prev_win)
5402         (tui_delete_invisible_windows): Update.
5403
5404 2019-08-16  Tom Tromey  <tom@tromey.com>
5405
5406         * tui/tui-winsource.h (struct tui_source_window_base)
5407         <m_has_locator>: Remove.
5408         * tui/tui-layout.c (show_source_disasm_command, show_data)
5409         (show_source_or_disasm_and_command): Update.
5410
5411 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5412
5413         * NEWS (Other MI changes): New subsection.
5414         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5415         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5416         * arch-utils.c (default_get_pc_address_flags): New function.
5417         * arch-utils.h (default_get_pc_address_flags): New declaration.
5418         * gdbarch.sh: Add get_pc_address_flags.
5419         * gdbarch.c: Regenerate.
5420         * gdbarch.h: Likewise.
5421         * stack.c (print_pc): New function.
5422         (print_frame_info) (print_frame): Call print_pc.
5423
5424 2019-08-16  Tom de Vries  <tdevries@suse.de>
5425
5426         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5427         print_objfile_section_info.
5428
5429 2019-08-15  Tom Tromey  <tom@tromey.com>
5430
5431         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5432         calling update_cmdwin_start_line.
5433         * tui/tui-winsource.h (struct tui_source_window_base)
5434         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5435         <rerender>: Declare.
5436         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5437         Call rerender.
5438         (tui_source_window_base::set_new_height): Remove.
5439         (tui_source_window_base::rerender): Rename from
5440         do_make_visible_with_new_height.
5441         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5442         resize method.
5443         (tui_win_info::make_invisible_and_set_new_height)
5444         (tui_win_info::make_visible_with_new_height): Remove.
5445         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5446         Declare.
5447         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5448         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5449         do_make_visible_with_new_height>: Don't declare.
5450         <rerender>: Declare.
5451         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5452         set_new_height.
5453         (tui_data_window::do_make_visible_with_new_height): Remove.
5454         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5455         call tui_show_locator_content.
5456         (tui_gen_win_info::resize): Call rerender.
5457         (show_source_or_disasm_and_command): Don't call
5458         tui_show_locator_content.
5459         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5460         method.
5461         (struct tui_win_info) <rerender>: Declare.
5462         <set_new_height, make_invisible_and_set_new_height,
5463         make_visible_with_new_height>: Don't declare.
5464         * tui/tui-data.c (tui_win_list::rerender): New method.
5465         * tui/tui-command.h (struct tui_cmd_window)
5466         <do_make_visible_with_new_height>: Don't declare.
5467         * tui/tui-command.c
5468         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5469
5470 2019-08-15  Tom Tromey  <tromey@adacore.com>
5471
5472         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5473         * ada-lang.c (ada_enum_name): Likewise.
5474
5475 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5476
5477         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5478         leading underscore.
5479         (GdbOutputErrorFile): Likewise.
5480         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5481         accordingly.
5482         (execute_unwinders): Rename to have a leading underscore.
5483         (auto_load_packages): Likewise.
5484         (global scope): Adjust call to auto_load_packages accordingly.
5485         (GdbSetPythonDirectory): Likewise.
5486         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5487         instead of execute_unwinders.
5488
5489 2019-08-15  Tom Tromey  <tom@tromey.com>
5490
5491         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5492         (show_data): Don't change window visibility.
5493         (tui_gen_win_info::resize): Remove special case for command
5494         window.  Use wresize, when available.
5495         (show_source_or_disasm_and_command): Don't change window
5496         visibility.
5497         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5498         <make_visible>: New method.
5499         * tui/tui-command.c (tui_cmd_window::resize): New method.
5500
5501 2019-08-15  Tom Tromey  <tom@tromey.com>
5502
5503         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5504         (struct tui_source_windows): New.
5505         * tui/tui-winsource.c (tui_display_main): Update.
5506         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5507         (new_height_ok, parse_scrolling_args): Update.
5508         * tui/tui-layout.c (show_layout, show_data): Update.
5509         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5510         (tui_add_to_source_windows): Don't declare.
5511         * tui/tui-data.c (source_windows, tui_source_windows)
5512         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5513
5514 2019-08-15  Tom Tromey  <tom@tromey.com>
5515
5516         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5517         Rename from reset.
5518         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5519         * tui/tui-layout.c (show_source_disasm_command, show_data):
5520         Update.
5521         (tui_gen_win_info::resize): Rename.
5522         (show_source_or_disasm_and_command): Update.
5523         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5524         reset.
5525
5526 2019-08-15  Tom Tromey  <tom@tromey.com>
5527
5528         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5529         * tui/tui-interp.c (tui_interp::init): Don't call
5530         tui_initialize_static_data.
5531         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5532
5533 2019-08-15  Tom Tromey  <tom@tromey.com>
5534
5535         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5536         examine tui_win_list.
5537
5538 2019-08-15  Tom Tromey  <tom@tromey.com>
5539
5540         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5541         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5542         tui_clear_source_content.
5543         (tui_clear_source_content): Remove.
5544         (tui_source_window_base::do_erase_source_content): Hoist call to
5545         content.clear().
5546         * tui/tui-stack.c (tui_show_frame_info): Don't call
5547         tui_clear_source_content.
5548
5549 2019-08-15  Tom Tromey  <tom@tromey.com>
5550
5551         * tui/tui-winsource.h (struct tui_source_window_base)
5552         <do_erase_source_content>: New method.
5553         <erase_source_content>: New method.
5554         (tui_erase_source_content): Don't declare.
5555         * tui/tui-winsource.c (tui_clear_source_content): Update.
5556         (tui_source_window_base::do_erase_source_content): Rename from
5557         tui_erase_source_content.
5558         (tui_source_window_base::show_source_content): Update.
5559         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5560         * tui/tui-source.h (struct tui_source_window)
5561         <erase_source_content>: New method.
5562         * tui/tui-disasm.h (struct tui_disasm_window)
5563         <erase_source_content>: New method.
5564
5565 2019-08-15  Tom Tromey  <tom@tromey.com>
5566
5567         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5568         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5569         constructor.
5570         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5571         * tui/tui-source.c (tui_set_source_content): Update.
5572         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5573
5574 2019-08-15  Tom Tromey  <tom@tromey.com>
5575
5576         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5577         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5578         tui-source.c.
5579         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5580         Declare.
5581         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5582         method.
5583         (tui_source_window::maybe_update): Update.
5584
5585 2019-08-15  Tom Tromey  <tom@tromey.com>
5586
5587         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5588         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5589         tui-disasm.c.
5590         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5591         Declare.
5592         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5593         method.
5594         (tui_disasm_window::maybe_update): Update.
5595
5596 2019-08-15  Tom Tromey  <tom@tromey.com>
5597
5598         * tui/tui-winsource.h (struct tui_source_window_base)
5599         <maybe_update>: Declare.
5600         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5601         method.
5602         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5603         Declare.
5604         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5605         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5606         Declare.
5607         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5608
5609 2019-08-15  Tom Tromey  <tom@tromey.com>
5610
5611         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5612
5613 2019-08-15  Tom Tromey  <tom@tromey.com>
5614
5615         * tui/tui-wingeneral.c: Include tui-stack.h.
5616         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5617         (struct tui_locator_window): Move from tui-data.h.
5618         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5619         (tui_initialize_static_data): Move from tui-data.c.
5620         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5621         (struct tui_locator_window): Move to tui-stack.c.
5622         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5623         (tui_initialize_static_data): Move to tui-stack.c.
5624
5625 2019-08-15  Tom Tromey  <tom@tromey.com>
5626
5627         * tui/tui-layout.c (show_source_disasm_command)
5628         (show_source_or_disasm_and_command): Use make_visible method, not
5629         tui_make_window.
5630         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5631         Remove.
5632
5633 2019-08-15  Tom Tromey  <tom@tromey.com>
5634
5635         * tui/tui-wingeneral.h (tui_make_window): Update.
5636         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5637         parameter.
5638         (tui_gen_win_info::make_visible): Update.
5639         * tui/tui-regs.c (tui_data_window::display_registers_from):
5640         Update.
5641         * tui/tui-layout.c (show_source_disasm_command)
5642         (show_source_or_disasm_and_command): Update.
5643         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5644         (enum tui_box): Remove.
5645         (struct tui_win_info) <can_box>: New method.
5646         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5647         method.
5648
5649 2019-08-15  Tom de Vries  <tdevries@suse.de>
5650
5651         * linux-nat-trad.c: Include gdbarch.h.
5652
5653 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5654
5655         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5656         register sizes.
5657
5658 2019-08-14  Tom Tromey  <tromey@adacore.com>
5659
5660         * darwin-nat.c: Include gdbarch.h.
5661         * darwin-nat-info.c: Include gdbarch.h.
5662
5663 2019-08-13  Tom Tromey  <tom@tromey.com>
5664
5665         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5666         Remove.
5667         * tui/tui-data.c (tui_initialize_static_data): Update.
5668
5669 2019-08-13  Tom Tromey  <tom@tromey.com>
5670
5671         * tui/tui-winsource.h (struct tui_exec_info_window)
5672         <~tui_exec_info_window, maybe_allocate_content, get_content,
5673         m_content>: Remove.
5674         (struct tui_source_window_base) <set_exec_info_content,
5675         show_exec_info_content>: Don't declare.
5676         * tui/tui-winsource.c
5677         (tui_exec_info_window::maybe_allocate_content): Remove.
5678         (tui_source_window_base::update_exec_info): Rename from
5679         set_exec_info_content.
5680         (tui_source_window_base::show_exec_info_content)
5681         (tui_source_window_base::update_exec_info): Remove.
5682
5683 2019-08-13  Tom Tromey  <tom@tromey.com>
5684
5685         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5686         declare.
5687         * tui/tui-winsource.c (tui_update_source_window_as_is)
5688         (tui_update_source_windows_with_addr, tui_erase_source_content):
5689         Update.
5690         (tui_clear_exec_info_content): Remove.
5691
5692 2019-08-13  Tom Tromey  <tom@tromey.com>
5693
5694         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5695         declare.
5696         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5697         call tui_erase_exec_info_content.
5698         (tui_clear_exec_info_content): Rename from
5699         tui_erase_exec_info_content.
5700         (tui_clear_exec_info_content): Delete.
5701
5702 2019-08-13  Tom Tromey  <tom@tromey.com>
5703
5704         * tui/tui-winsource.h (struct tui_source_window_base)
5705         <show_exec_info_content>: Declare.
5706         (tui_show_exec_info_content): Don't declare.
5707         * tui/tui-winsource.c
5708         (tui_source_window_base::show_exec_info_content): Rename from
5709         tui_show_exec_info_content.
5710         (tui_source_window_base::update_exec_info): Update.
5711
5712 2019-08-13  Tom Tromey  <tom@tromey.com>
5713
5714         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5715         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5716         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5717         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5718         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5719         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5720         ... here.
5721
5722 2019-08-13  Tom Tromey  <tom@tromey.com>
5723
5724         * tui/tui-winsource.h (struct tui_source_window_base)
5725         <update_exec_info>: Declare.
5726         (tui_update_exec_info): Don't declare.
5727         * tui/tui-winsource.c (tui_update_source_window_as_is)
5728         (tui_source_window_base::refresh_all)
5729         (tui_update_all_breakpoint_info): Update.
5730         (tui_source_window_base::update_exec_info): Rename from
5731         tui_update_exec_info.
5732         * tui/tui-stack.c (tui_show_frame_info): Update.
5733
5734 2019-08-13  Tom Tromey  <tom@tromey.com>
5735
5736         * tui/tui-winsource.h (struct tui_source_window_base)
5737         <set_exec_info_content>: Declare.
5738         (tui_set_exec_info_content): Don't declare.
5739         * tui/tui-winsource.c
5740         (tui_source_window_base::set_exec_info_content): Rename from
5741         tui_set_exec_info_content.
5742         (tui_update_exec_info): Update.
5743
5744 2019-08-13  Tom Tromey  <tom@tromey.com>
5745
5746         * tui/tui-winsource.h (struct tui_source_window_base)
5747         <show_source_content>: Declare.
5748         (tui_show_source_content): Don't declare.
5749         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5750         (tui_source_window_base::show_source_content): Rename from
5751         tui_show_source_content.
5752         (tui_source_window_base::refresh_all): Update.
5753         * tui/tui-layout.c (show_source_disasm_command)
5754         (show_source_or_disasm_and_command): Update.
5755
5756 2019-08-13  Tom Tromey  <tom@tromey.com>
5757
5758         * tui/tui-winsource.c (tui_erase_source_content)
5759         (tui_show_source_content, tui_source_window_base::refresh_all):
5760         Update.
5761         * tui/tui-wingeneral.h
5762         (tui_check_and_display_highlight_if_needed): Don't declare.
5763         * tui/tui-wingeneral.c
5764         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5765         check_and_display_highlight_if_needed.
5766         * tui/tui-win.c (tui_rehighlight_all)
5767         (tui_win_info::make_visible_with_new_height): Update.
5768         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5769         (tui_data_window::erase_data_content)
5770         (tui_data_window::display_all_data): Update.
5771         * tui/tui-data.h (struct tui_win_info)
5772         <check_and_display_highlight_if_needed>: Declare.
5773
5774 2019-08-13  Tom Tromey  <tom@tromey.com>
5775
5776         * tui/tui-win.c (tui_resize_all): Call
5777         tui_delete_invisible_windows.
5778         * tui/tui-layout.c (show_layout): Call
5779         tui_delete_invisible_windows.
5780         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5781         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5782
5783 2019-08-13  Tom Tromey  <tom@tromey.com>
5784
5785         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5786         tui_add_win_to_layout.
5787
5788 2019-08-13  Tom Tromey  <tom@tromey.com>
5789
5790         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5791         * tui/tui-layout.c (tui_default_win_height): Now static.
5792
5793 2019-08-13  Tom Tromey  <tom@tromey.com>
5794
5795         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5796         single switch.
5797         (show_source_disasm_command, show_source_or_disasm_and_command):
5798         Don't check current layout.
5799
5800 2019-08-13  Tom Tromey  <tom@tromey.com>
5801
5802         * tui/tui-wingeneral.c (make_all_visible): Remove.
5803         (tui_make_all_invisible): Simplify.
5804         * tui/tui-layout.c (tui_make_all_invisible): Move from
5805         tui-wingeneral.c; simplify.
5806         (show_layout): Hoist call to tui_make_all_invisible.
5807         (show_data): Don't call tui_make_all_invisible.
5808
5809 2019-08-13  Tom Tromey  <tom@tromey.com>
5810
5811         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5812         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5813
5814 2019-08-13  Tom Tromey  <tom@tromey.com>
5815
5816         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5817         tui-data.c.
5818         (show_source_disasm_command, show_data)
5819         (show_source_or_disasm_and_command): Don't use
5820         tui_set_current_layout_to.
5821         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5822         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5823         tui-layout.c.
5824         (tui_set_current_layout_to): Remove.
5825
5826 2019-08-13  Tom Tromey  <tom@tromey.com>
5827
5828         * tui/tui-layout.c (tui_set_layout): Update.
5829         * tui/tui-data.h (struct tui_layout_def): Remove.
5830         (tui_layout_def): Don't declare.
5831         * tui/tui-data.c (layout_def): Remove.
5832         (tui_layout_def): Remove.
5833
5834 2019-08-13  Tom Tromey  <tom@tromey.com>
5835
5836         * tui/tui-winsource.h (struct tui_source_window_base)
5837         <clear_detail>: No longer "override".
5838         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5839         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5840         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5841         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5842         Remove.
5843         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5844
5845 2019-08-13  Tom Tromey  <tromey@adacore.com>
5846
5847         * tracepoint.c: Don't include readline.h or history.h.
5848
5849 2019-08-12  Tom Tromey  <tom@tromey.com>
5850
5851         * configure: Rebuild.
5852         * configure.ac: Check for readline 7.
5853         * NEWS: Mention readline 7 requirement.
5854         * README: Update.
5855
5856 2019-08-12  Tom Tromey  <tom@tromey.com>
5857
5858         * mingw-hdep.c (gdb_select): Remove readline hack.
5859
5860 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5861
5862         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5863         when the function fails.
5864
5865 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5866
5867         * s390-tdep.c (s390_type_align): New function.
5868         (s390_gdbarch_init): Set it as type_align gdbarch method.
5869
5870 2019-08-09  Tom de Vries  <tdevries@suse.de>
5871
5872         PR gdb/24591
5873         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5874         pc_low with relocation offset.
5875
5876 2019-08-07  Tom Tromey  <tromey@adacore.com>
5877
5878         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5879         (print_frame_args): Update.
5880         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5881         Update.
5882         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5883         * frame.h (struct frame_arg): Add initializers.
5884         <error>: Now a unique_xmalloc_ptr.
5885
5886 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5887
5888         * NEWS: Expand the Pointer Authentication entry.
5889         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5890         (aarch64_frame_unmask_lr): ... to this.
5891         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5892         Call aarch64_frame_unmask_lr.
5893         * frame.c (struct frame_info): Add "masked" variable.
5894         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5895         (fprint_frame): Check for masked pc.
5896         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5897         declarations.
5898         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5899         * stack.c (print_frame): Check for masked pc.
5900
5901 2019-08-06  Tom Tromey  <tom@tromey.com>
5902
5903         * stabsread.c (patch_block_stabs, read_one_struct_field)
5904         (read_enum_type): Use obstack_strndup.
5905         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5906         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5907         * dwarf2read.c (guess_full_die_structure_name)
5908         (anonymous_struct_prefix): Use obstack_strndup.
5909         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5910         * c-exp.y (yylex): Use obstack_strndup.
5911         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5912         (write_var_or_type): Use obstack_strndup.
5913
5914 2019-08-06  Tom Tromey  <tom@tromey.com>
5915
5916         * symfile.c (reread_symbols): Use obstack_strdup.
5917         * stabsread.c (read_type): Use obstack_strdup.
5918         * gdb_obstack.h (obstack_strdup): New overload.
5919         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5920         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5921         (dwarf2_canonicalize_name): Use obstack_strdup.
5922         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5923         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5924         Use obstack_strdup.
5925
5926 2019-08-06  Tom Tromey  <tom@tromey.com>
5927
5928         * gdb_obstack.h (obstack_strdup): Define.
5929         * gdb_obstack.c (obstack_strdup): Don't define.
5930
5931 2019-08-06  Tom Tromey  <tom@tromey.com>
5932
5933         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5934         obstack_strdup.
5935         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5936         obstack_strdup.
5937         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5938         * stabsread.c (common_block_start): Use obstack_strdup.
5939         * objfiles.c (set_objfile_main_name, objfile): Use
5940         obstack_strdup.
5941         * namespace.c (add_using_directive): Use obstack_strdup.
5942         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5943         * jit.c (finalize_symtab): Use obstack_strdup.
5944         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5945         (guess_partial_die_structure_name, partial_die_info::fixup)
5946         (dwarf2_name): Use obstack_strdup.
5947         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5948         obstack_strdup.
5949         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5950         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5951         obstack_strdup.
5952         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5953
5954 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5955
5956         * unittests/help-doc-selftests.c: New file.
5957         * Makefile.in: Add the new file.
5958
5959 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5960
5961         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5962         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5963         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5964         the trailing '.' is not output, and the first character is uppercased.
5965         (print_help_for_command): Update call to print_doc_line.
5966         (print_doc_of_command): Likewise.
5967         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5968         * cli/cli-option.c (append_indented_doc): Do not append newline.
5969         (build_help_option): Append newline after first appended_indented_doc
5970         only if a second call is done.
5971         (build_help): Append 2 new lines before each option, except the first
5972         one.
5973         * compile/compile.c (_initialize_compile): Add new lines after
5974         %OPTIONS%, when not at the end of the help.
5975         Change help doc or code
5976         producing the help doc to respect the invariants.
5977         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5978         Also removed the new line after 'Options:', as all other commands
5979         do not put an empty line between 'Options:' and the first option.
5980         * printcmd.c (_initialize_printcmd): Likewise.
5981         * stack.c (_initialize_stack): Likewise.
5982         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5983         incorrectly telling COMMAND is optional.
5984         * ada-lang.c (_initialize_ada_language): Change help doc or code
5985         producing the help doc to respect the invariants.
5986         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5987         * breakpoint.c (_initialize_breakpoint): Likewise.
5988         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5989         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5990         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5991         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5992         _initialize_cli_style): Likewise.
5993         * corelow.c (core_target_info): Likewise.
5994         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5995         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5996         * filesystem.c (_initialize_filesystem): Likewise.
5997         * frame.c (_initialize_frame): Likewise.
5998         * gnu-nat.c (add_task_commands): Likewise.
5999         * infcall.c (_initialize_infcall): Likewise.
6000         * infcmd.c (_initialize_infcmd): Likewise.
6001         * interps.c (_initialize_interpreter): Likewise.
6002         * language.c (_initialize_language): Likewise.
6003         * linux-fork.c (_initialize_linux_fork): Likewise.
6004         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6005         * maint.c (_initialize_maint_cmds): Likewise.
6006         * memattr.c (_initialize_mem): Likewise.
6007         * printcmd.c (_initialize_printcmd): Likewise.
6008         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6009         _RegEx): Likewise.
6010         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6011         * record-btrace.c (_initialize_record_btrace): Likewise.
6012         * record-full.c (_initialize_record_full): Likewise.
6013         * record.c (_initialize_record): Likewise.
6014         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6015         * regcache.c (_initialize_regcache): Likewise.
6016         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6017         _initialize_remote): Likewise.
6018         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6019         * serial.c (_initialize_serial): Likewise.
6020         * skip.c (_initialize_step_skip): Likewise.
6021         * source.c (_initialize_source): Likewise.
6022         * stack.c (_initialize_stack): Likewise.
6023         * symfile.c (_initialize_symfile): Likewise.
6024         * symtab.c (_initialize_symtab): Likewise.
6025         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6026         * top.c (init_main): Likewise.
6027         * tracefile-tfile.c (tfile_target_info): Likewise.
6028         * tracepoint.c (_initialize_tracepoint): Likewise.
6029         * tui/tui-win.c (_initialize_tui_win): Likewise.
6030         * utils.c (add_internal_problem_command): Likewise.
6031         * valprint.c (value_print_option_defs): Likewise.
6032
6033 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6034
6035         PR build/24886
6036         * configure.ac: Drop enable-libmcheck support.
6037         * configure, config.in: Rebuild.
6038         * libmcheck.m4: Remove.
6039         * acinclude.m4: Don't include it.
6040         * Makefile.in: Don't distribute it.
6041         * top.c (print_gdb_configuration): Don't mention it.
6042
6043 2019-08-06  Tom Tromey  <tom@tromey.com>
6044
6045         * utils.c (set_output_style): Sometimes pass stream to
6046         emit_style_escape.
6047         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6048         * record-btrace.c (btrace_insn_history): Update.
6049         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6050         method.
6051         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6052         Update initializers.
6053         <m_uiout>: New field.
6054         <m_di>: Move lower.
6055         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6056         Remove "uiout" parameter.
6057         (dump_insns): Update.
6058         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6059         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6060
6061 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6062
6063         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6064         (error_in_psymtab_expansion): Likewise.
6065         (lookup_symbol_via_quick_fns): Likewise.
6066         (basic_lookup_transparent_type_quick): Likewise.
6067         (basic_lookup_transparent_type_1): Likewise.
6068
6069 2019-08-06  Tom Tromey  <tromey@adacore.com>
6070
6071         * source.c (last_source_error): Now bool.
6072         (print_source_lines_base): Make "noprint" bool.  Only open
6073         source file when last_source_visited changes.
6074
6075 2019-08-06  Tom Tromey  <tromey@adacore.com>
6076
6077         * annotate.c (annotate_source_line): Use g_source_cache.
6078         * source-cache.c (source_cache::get_plain_source_lines): Change
6079         parameters.  Populate m_offset_cache.
6080         (source_cache::ensure): New method.
6081         (source_cache::get_line_charpos): New method.
6082         (extract_lines): Move lower.  Change parameters.
6083         (source_cache::get_source_lines): Move lower.
6084         * source-cache.h (class source_cache): Update comment.
6085         <get_line_charpos>: New method.
6086         <get_source_lines>: Update comment.
6087         <clear>: Clear m_offset_cache.
6088         <get_plain_source_lines>: Change parameters.
6089         <ensure>: New method
6090         <m_offset_cache>: New member.
6091         * source.c (forget_cached_source_info_for_objfile): Update.
6092         (info_source_command): Use g_source_cache.
6093         (find_source_lines, open_source_file_with_line_charpos): Remove.
6094         (print_source_lines_base, search_command_helper): Use g_source_cache.
6095         * source.h (open_source_file_with_line_charpos): Don't declare.
6096         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6097         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6098         Use g_source_cache.
6099
6100 2019-08-06  Tom Tromey  <tromey@adacore.com>
6101
6102         * source-cache.c (source_cache::get_plain_source_lines):
6103         Remove "first_line" and "last_line" parameters.
6104         (source_cache::get_source_lines): Cache plain text.
6105         * source-cache.h (class source_cache)
6106         <get_plain_source_lines>: Update.
6107
6108 2019-08-06  Tom Tromey  <tromey@adacore.com>
6109
6110         * source-cache.c (extract_lines): No longer a method.
6111         Changed type of parameter.  Include final newline.
6112         (selftests::extract_lines_test): New function.
6113         (_initialize_source_cache): Likewise.
6114         * source-cache.h (class source_cache)
6115         <extract_lines>: Don't declare.
6116
6117 2019-08-06  Tom Tromey  <tromey@adacore.com>
6118
6119         * breakpoint.c (init_breakpoint_sal): Update.
6120         (breakpoint): Update.
6121         * breakpoint.h (struct breakpoint) <filter>: Now a
6122         unique_xmalloc_ptr.
6123
6124 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6125
6126         * NEWS: Mention dictionary access on blocks.
6127         * python/py-block.c (blpy_getitem): New function.
6128         (block_object_as_mapping): New struct.
6129         (block_object_type): Use new struct for tp_as_mapping field.
6130
6131 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6132
6133         * objfiles.h (objfile): Add a comment describing partial symbols.
6134
6135 2019-08-05  Tom Tromey  <tromey@adacore.com>
6136
6137         * compile/compile.c (_initialize_compile): Use _(), not N_().
6138         * thread.c (_initialize_thread): Use _(), not N_().
6139         * stack.c (_initialize_stack): Use _(), not N_().
6140         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6141
6142 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6143
6144         * dwarf2read.c (struct dw2_symtab_iterator):
6145         <want_specific_block>: Remove.
6146         <block_index>: Change type to gdb::optional.
6147         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6148         change type of BLOCK_INDEX parameter to gdb::optional.
6149         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6150         (dw2_lookup_symbol): Don't pass argument for
6151         WANT_SPECIFIC_BLOCK.
6152         (dw2_expand_symtabs_for_function): Don't pass argument for
6153         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6154         (class dw2_debug_names_iterator)
6155         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6156         parameter, change BLOCK_INDEX type to gdb::optional.
6157         <m_want_specific_block>: Remove.
6158         <m_block_index>: Change type to gdb::optional.
6159         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6160         gdb::optional.  Re-write in function of gdb::optional.
6161         (dw2_debug_names_lookup_symbol): Don't pass argument for
6162         WANT_SPECIFIC_BLOCK.
6163         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6164         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6165         BLOCK_INDEX.
6166
6167 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6168
6169         * NEWS: Mention changes to "info sources" command.
6170
6171 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6172
6173         * symtab.c (filename_partial_match_opts): New struct type.
6174         (struct output_source_filename_data): New members
6175         regexp, c_regexp, partial_match.
6176         (output_source_filename): Use new members to decide to print file.
6177         (info_sources_option_defs): New variable.
6178         (make_info_sources_options_def_group, print_info_sources_header,
6179         info_sources_command_completer):
6180         New functions.
6181         (info_sources_command): Read new optional arguments.
6182         (_initialize_symtab): Update info sources help.
6183
6184 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6185
6186         * ada-lang.c (exception_support_info_v0): Renamed from...
6187         (default_exception_support_info): ... this.  Create new
6188         definition for v1.
6189         (ada_has_this_exception_support): Look up catch_handlers_sym.
6190         (ada_exception_support_info_sniffer): Try v0 after default.
6191
6192 2019-08-01  Tom Tromey  <tromey@adacore.com>
6193
6194         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6195         gdbarch.h.
6196
6197 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6198
6199         * s12z-tdep.c: Fix include path for s12z-opc.h.
6200
6201 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6202
6203         * NEWS: Require GNU make 3.82.
6204
6205 2019-07-16  Tom Tromey  <tom@tromey.com>
6206
6207         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6208         declare.
6209
6210 2019-07-30  Tom Tromey  <tromey@adacore.com>
6211
6212         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6213
6214 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6215
6216         * printcmd.c (print_address_symbolic): Print negative offsets.
6217         (build_address_symbolic): Force signed arithmetic when computing
6218         offset.
6219
6220 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6221
6222         PR/24474: Add a function to lookup static variables.
6223         * NEWS: Mention this new function.
6224         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6225         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6226         * python/python.c (python_GdbMethods): Add new function.
6227
6228 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6229
6230         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6231         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6232         (objfpy_lookup_static_symbol): New function.
6233         (objfile_object_methods): Add new functions.
6234
6235 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6236
6237         * NEWS: Mention 'set|show print frame-info'.  Mention new
6238         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6239         backtrace argument.  Mention that python frame filtering code
6240         is now consistent with what 'backtrace' command prints.
6241
6242 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6243
6244         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6245         comments.
6246         (print_frame_info_auto, print_frame_info_source_line,
6247         print_frame_info_location, print_frame_info_source_and_location,
6248         print_frame_info_location_and_address, print_frame_info_short_location):
6249         New declarations.
6250         (struct frame_print_options): New member print_frame_info.
6251         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6252         * stack.h (get_user_print_what_frame_info): New declaration.
6253         (frame_show_address): New declaration.
6254         * stack.c (print_frame_arguments_choices): New value 'presence'.
6255         (print_frame_info_auto, print_frame_info_source_line,
6256         print_frame_info_location, print_frame_info_source_and_location,
6257         print_frame_info_location_and_address, print_frame_info_short_location,
6258         print_frame_info_choices, print_frame_info_print_what): New definitions.
6259         (print_frame_args): Only print dots for args if print frame-arguments
6260         is 'presence'.
6261         (frame_print_option_defs): New element for "frame-info".
6262         (get_user_print_what_frame_info): New function.
6263         (frame_show_address): Make non static.  Move comment to stack.h.
6264         (print_frame_info_to_print_what): New function.
6265         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6266         to decide what to print.
6267         (backtrace_command_1): Handle the new print_frame_arguments_presence
6268         value.
6269         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6270         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6271         (py_print_frame): In non-mi mode, use LOCATION as default for
6272         print_what, similarly to frame information printed directly by
6273         backtrace command. Handle frame-info user option in non MI mode.
6274
6275 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6276
6277         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6278         Add case for debugging 32-bit target on 64-bit host.  Revise
6279         comment.
6280
6281 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6282
6283         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6284         instead of find_function_entry_range_from_pc.
6285
6286 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6287
6288         * stack.c (find_frame_funname): Remove code which preferred
6289         minsym over symtab sym in "certain pathological cases".
6290
6291         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6292         parameter.  Change type of "do_demangle" to bool.
6293         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6294         Pass suitable "prefer_sym_over_minsym" flag to
6295         build_address_symbolic().  Don't output "+" for negative offsets.
6296         * printcmd.c (print_address_symbolic): Update invocation of
6297         build_address_symbolic to include a "prefer_sym_over_minsym"
6298         flag.
6299         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6300         Restrict cases in which use of minimal symbol is preferred to that
6301         of a found symbol.  Update comments.
6302
6303         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6304         for entry pc when entry pc is out of range for that FDE.
6305
6306 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6307
6308         PR gdb/24839:
6309         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6310         type.
6311
6312 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6313
6314         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6315         this function's Python signature.
6316
6317
6318 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6319
6320         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6321         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6322         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6323         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6324         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6325
6326
6327 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6328
6329         * h8300-tdep.c (h8300_register_name_common): New.
6330         h8300_register_name): Use h8300_register_name_common.
6331         (h8300s_register_name): Likewise.
6332         (h8300sx_register_name): Likewise.
6333         (h8300h_register_nam): New.
6334         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6335
6336
6337 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6338
6339         * arm-tdep.c (arm_skip_cmse_entry): New function.
6340         (arm_is_sgstubs_section): New function.
6341         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6342
6343 2019-07-22  Tom Tromey  <tom@tromey.com>
6344
6345         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6346         Don't self-assign.
6347
6348 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6349
6350         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6351         type_print.
6352
6353 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6354
6355         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6356         so that GDB doesn't match any msymbols when searching in the
6357         TYPES_DOMAIN.
6358         (print_symbol_info): Print using typedef_print or type_print based
6359         on the type of the symbol.  Add updated FIXME comment moved from...
6360         (_initialize_symtab): ... move and update FIXME comment to above.
6361
6362 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6363
6364         * NEWS: Mention adding -q option to "info types".
6365         * symtab.c (struct info_types_options): New struct.
6366         (info_types_options_defs): New variable.
6367         (make_info_types_options_def_group): New function.
6368         (info_types_command): Use gdb::option framework to parse options.
6369         (info_types_command_completer): New function.
6370         (_initialize_symtab): Extend the help text on "info types" and
6371         register command completer.
6372
6373 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6374
6375         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6376         (lookup_symbol_in_objfile): Change int to block_enum and add a
6377         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6378
6379 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6380
6381         * MAINTAINERS (Write After Approval): Add self.
6382
6383 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6384
6385         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6386         instruction to the dummy code region.
6387
6388 2019-07-19  Tom Tromey  <tromey@adacore.com>
6389
6390         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6391         (ARGSUSED, PARAMS, __func__): Remove rules.
6392
6393 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6394
6395         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6396         * features/arm/arm-with-iwmmxt.c: Remove.
6397         * features/arm/arm-with-iwmmxt.xml: Remove.
6398         * features/arm/arm-with-m-fpa-layout.c: Remove.
6399         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6400         * features/arm/arm-with-m-vfp-d16.c: Remove.
6401         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6402         * features/arm/arm-with-m.c: Remove.
6403         * features/arm/arm-with-m.xml: Remove.
6404         * features/arm/arm-with-neon.c: Remove.
6405         * features/arm/arm-with-neon.xml: Remove.
6406         * features/arm/arm-with-vfpv2.c: Remove.
6407         * features/arm/arm-with-vfpv2.xml: Remove.
6408         * features/arm/arm-with-vfpv3.c: Remove.
6409         * features/arm/arm-with-vfpv3.xml: Remove.
6410
6411 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6412
6413         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6414
6415 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6416
6417         * arch/aarch32.c (aarch32_create_target_description): Create
6418         target descriptions using features.
6419         * arch/arm.c (arm_create_target_description)
6420         (arm_create_mprofile_target_description): Likewise.
6421         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6422
6423 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6424
6425         * Makefile.in: Add new files.
6426         * aarch32-tdep.c: New file.
6427         * aarch32-tdep.h: New file.
6428         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6429         Call aarch32_read_description.
6430         * arch/aarch32.c: New file.
6431         * arch/aarch32.h: New file.
6432         * arch/arm.c (arm_create_target_description)
6433         (arm_create_mprofile_target_description): New function.
6434         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6435         (arm_create_target_description)
6436         (arm_create_mprofile_target_description): New declaration.
6437         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6438         read_description functions.
6439         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6440         Likewise.
6441         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6442         * arm-tdep.c (tdesc_arm_list): New variable.
6443         (arm_register_g_packet_guesses): Call create description functions.
6444         (arm_read_description) (arm_read_mprofile_description): New
6445         function.
6446         * arm-tdep.h (arm_read_description)
6447         (arm_read_mprofile_description): Add declaration.
6448         * configure.tgt: Add new files.
6449
6450 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6451
6452         * top.c (new_ui_command): Open specified terminal just once.
6453
6454 2019-07-18  Tom Tromey  <tromey@adacore.com>
6455
6456         * symtab.c (main_name): Constify return type.
6457         * symfile.c (set_initial_language): Update.
6458         * symtab.h (main_name): Constify return type.
6459
6460 2019-07-17  Tom Tromey  <tom@tromey.com>
6461
6462         * tui/tui-winsource.c (tui_update_source_window)
6463         (tui_update_source_window_as_is)
6464         (tui_update_source_windows_with_line): Remove return.
6465         * tui/tui-disasm.c (tui_show_disassem)
6466         (tui_show_disassem_and_update_source): Remove return.
6467         * tui/tui.c (tui_reset): Remove return.
6468         * tui/tui-wingeneral.c
6469         (tui_check_and_display_highlight_if_needed): Remove return.
6470
6471 2019-07-17  Tom Tromey  <tom@tromey.com>
6472
6473         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6474
6475 2019-07-17  Tom Tromey  <tom@tromey.com>
6476
6477         * tui/tui-winsource.h (struct tui_exec_info_window)
6478         (struct tui_source_window_base): Move from tui-data.h.
6479         * tui/tui-winsource.c: Move many method definitions from
6480         elsewhere.  Remove "structuring" comments.
6481         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6482         (tui_source_window_base::refresh_window): Move to
6483         tui-winsource.c.
6484         * tui/tui-win.c (tui_source_window_base::refresh_all)
6485         (tui_source_window_base::update_tab_width)
6486         (tui_source_window_base::set_new_height)
6487         (tui_source_window_base::do_make_visible_with_new_height): Move to
6488         tui-winsource.c.
6489         * tui/tui-source.h: Update.
6490         * tui/tui-source.c (tui_source_window_base::reset): Move to
6491         tui-winsource.c.
6492         * tui/tui-disasm.h: Update.
6493         * tui/tui-data.h (struct tui_exec_info_window): Move to
6494         tui-winsource.h.
6495         (struct tui_source_window_base): Likewise.
6496         * tui/tui-data.c (tui_source_window_base::clear_detail)
6497         (tui_source_window_base, ~tui_source_window_base): Move to
6498         tui-winsource.c.
6499
6500 2019-07-17  Tom Tromey  <tom@tromey.com>
6501
6502         * tui/tui-win.c (tui_resize_all)
6503         (tui_source_window_base::update_tab_width)
6504         (tui_adjust_win_heights): Update.
6505         (tui_win_info::make_invisible_and_set_new_height): Rename from
6506         make_invisible_and_set_new_height.
6507         * tui/tui-data.h (struct tui_win_info)
6508         <make_invisible_and_set_new_height>: New method.
6509
6510 2019-07-17  Tom Tromey  <tom@tromey.com>
6511
6512         * tui/tui.c: Update.
6513         * tui/tui-source.h (struct tui_source_window): Move from
6514         tui-data.h.
6515         * tui/tui-layout.c: Update.
6516         * tui/tui-disasm.c: Update.
6517         * tui/tui-data.h (struct tui_source_window): Move to
6518         tui-source.h.
6519
6520 2019-07-17  Tom Tromey  <tom@tromey.com>
6521
6522         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6523         tui-data.h.
6524         * tui/tui-data.h (struct tui_disasm_window): Move to
6525         tui-disasm.h.
6526
6527 2019-07-17  Tom Tromey  <tom@tromey.com>
6528
6529         * tui/tui-regs.h (struct tui_data_item_window): Move from
6530         tui-data.h.
6531         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6532         * tui/tui-data.h (struct tui_data_item_window): Move to
6533         tui-regs.h.
6534         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6535
6536 2019-07-17  Tom Tromey  <tom@tromey.com>
6537
6538         * tui/tui.c: Update.
6539         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6540         (tui_cmd_window::max_height): Move to tui-command.c.
6541         * tui/tui-layout.c: Update.
6542         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6543         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6544         tui-command.c.
6545         * tui/tui-command.h (struct tui_cmd_window): Move from
6546         tui-data.h.
6547         * tui/tui-command.c: Remove "structuring" comments.
6548         (tui_cmd_window::clear_detail)
6549         (tui_cmd_window::do_make_visible_with_new_height)
6550         (tui_cmd_window::max_height): Move from elsewhere.
6551
6552 2019-07-17  Tom Tromey  <tom@tromey.com>
6553
6554         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6555         Now static.
6556         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6557         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6558
6559 2019-07-17  Tom Tromey  <tom@tromey.com>
6560
6561         * tui/tui.c: Update.
6562         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6563         tui-regs.c.
6564         * tui/tui-windata.h: Remove file.
6565         * tui/tui-windata.c: Remove file.
6566         * tui/tui-win.c (tui_data_window::set_new_height)
6567         (tui_data_window::do_make_visible_with_new_height): Move to
6568         tui-regs.c.
6569         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6570         * tui/tui-regs.c: Remove "structuring" comments.
6571         (tui_data_window::first_data_item_displayed)
6572         (tui_data_window::delete_data_content_windows)
6573         (tui_data_window::erase_data_content)
6574         (tui_data_window::display_all_data)
6575         (tui_data_window::refresh_all)
6576         (tui_data_window::do_scroll_vertical)
6577         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6578         (tui_data_window::do_make_visible_with_new_height)
6579         (tui_data_window::refresh_window): Move from elsewhere.
6580         (_initialize_tui_regs): Move to end of file.
6581         * tui/tui-layout.c: Update.
6582         * tui/tui-hooks.c: Update.
6583         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6584         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6585         tui-regs.c.
6586         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6587
6588 2019-07-17  Tom Tromey  <tom@tromey.com>
6589
6590         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6591         seen.
6592
6593 2019-07-17  Tom Tromey  <tom@tromey.com>
6594
6595         * tui/tui-win.c (tui_source_window_base::set_new_height)
6596         (tui_source_window_base::do_make_visible_with_new_height): Use
6597         m_has_locator field directly.
6598         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6599         method.
6600         (struct tui_source_window_base) <has_locator>: Likewise.
6601
6602 2019-07-17  Tom Tromey  <tom@tromey.com>
6603
6604         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6605         Don't declare.
6606         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6607         Remove.
6608         * tui/tui-win.c (tui_source_window_base::set_new_height)
6609         (tui_source_window_base::set_new_height)
6610         (make_invisible_and_set_new_height)
6611         (tui_source_window_base::do_make_visible_with_new_height)
6612         (tui_source_window_base::do_make_visible_with_new_height):
6613         Update.
6614         * tui/tui-layout.c (show_source_disasm_command, show_data)
6615         (show_source_or_disasm_and_command): Update.
6616         * tui/tui-layout.c (show_layout): Update.
6617
6618 2019-07-17  Tom Tromey  <tom@tromey.com>
6619
6620         * tui/tui-layout.c (make_data_window): Remove.
6621         (show_data): Unify creation and re-initialization cases.
6622
6623 2019-07-17  Tom Tromey  <tom@tromey.com>
6624
6625         * tui/tui-layout.c (make_source_window, make_disasm_window):
6626         Remove.
6627         (show_data): Unify creation and re-initialization cases.
6628
6629 2019-07-17  Tom Tromey  <tom@tromey.com>
6630
6631         * tui/tui-layout.c (make_command_window): Remove.
6632         (show_source_disasm_command, show_source_or_disasm_and_command):
6633         Unify creation and re-initialization cases.
6634
6635 2019-07-17  Tom Tromey  <tom@tromey.com>
6636
6637         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6638         creation and re-initialization cases.
6639
6640 2019-07-17  Tom Tromey  <tom@tromey.com>
6641
6642         * tui/tui-regs.c (tui_get_register): Return void.
6643
6644 2019-07-17  Tom Tromey  <tom@tromey.com>
6645
6646         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6647         Simplify.
6648
6649 2019-07-17  Tom Tromey  <tom@tromey.com>
6650
6651         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6652         resetting.
6653
6654 2019-07-17  Tom Tromey  <tom@tromey.com>
6655
6656         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6657         * tui/tui-regs.c (tui_reg_layout): New function.
6658         (tui_show_registers, tui_reg_command): Use it.
6659         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6660         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6661         parameters.
6662         (tui_layout_command): Remove.
6663
6664 2019-07-17  Tom Tromey  <tom@tromey.com>
6665
6666         * tui/tui-layout.h (tui/tui-layout): Return void.
6667         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6668
6669 2019-07-17  Tom Tromey  <tom@tromey.com>
6670
6671         * tui/tui-layout.c (show_source_disasm_command, show_data):
6672         Update.
6673         (reset_locator): Remove.
6674         (show_source_or_disasm_and_command): Update.
6675
6676 2019-07-17  Tom Tromey  <tom@tromey.com>
6677
6678         * tui/tui-source.c (tui_source_window_base::reset): Remove
6679         win_type parameter.
6680         * tui/tui-layout.c (make_command_window, make_source_window)
6681         (make_disasm_window, make_data_window)
6682         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6683         (reset_locator, show_source_or_disasm_and_command): Update.
6684         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6685         win_type parameter.
6686         (struct tui_source_window_base) <reset>: Likewise.
6687
6688 2019-07-17  Tom Tromey  <tom@tromey.com>
6689
6690         * tui/tui-layout.c (show_source_disasm_command): Use
6691         reset_locator.
6692         (reset_locator): New function.
6693         (init_and_make_win): Remove.
6694         (show_source_or_disasm_and_command): Use reset_locator.
6695
6696 2019-07-17  Tom Tromey  <tom@tromey.com>
6697
6698         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6699         condition.
6700         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6701         Remove condition.
6702         * tui/tui-source.c (tui_source_window_base::reset): New method.
6703         * tui/tui-layout.c (make_command_window): Don't call
6704         init_and_make_win.
6705         (make_source_window, make_disasm_window): Don't call
6706         make_source_or_disasm_window.
6707         (make_data_window): Don't call init_and_make_win.  Change calling
6708         convention.
6709         (show_source_disasm_command, show_data): Simplify.
6710         (make_source_or_disasm_window): Remove.
6711         (show_source_or_disasm_and_command): Simplify.
6712         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6713         (struct tui_source_window_base) <reset>: Likewise.
6714         <execution_info>: Remove initializer.
6715         * tui/tui-data.c (tui_source_window_base): Initialize
6716         execution_info.
6717
6718 2019-07-17  Tom Tromey  <tom@tromey.com>
6719
6720         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6721         variable.
6722
6723 2019-07-17  Tom Tromey  <tom@tromey.com>
6724
6725         * tui/tui.c (tui_rl_other_window): Update.
6726         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6727         superclass method first.  Always iterate over regs_content.
6728         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6729         method.
6730         * tui/tui-win.c (tui_set_focus_command): Update.
6731
6732 2019-07-17  Tom Tromey  <tom@tromey.com>
6733
6734         * tui/tui-win.c (tui_set_focus_command): Rename from
6735         tui_set_focus.  Call tui_enable.
6736         (tui_set_focus_command): Remove.
6737
6738 2019-07-17  Tom Tromey  <tom@tromey.com>
6739
6740         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6741         refresh_window.
6742         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6743         touchwin.
6744         (tui_data_window::refresh_window): Call refresh_window on data
6745         items.  Always call superclass refresh_window.
6746         (tui_win_info::refresh): Remove.
6747         (tui_source_window_base::refresh_window): Update.
6748         (tui_refresh_all): Update.
6749         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6750         refresh_window.
6751         (show_source_or_disasm_and_command): Likewise.
6752         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6753         (struct tui_source_window_base) <refresh>: Likewise.
6754
6755 2019-07-17  Tom Tromey  <tom@tromey.com>
6756
6757         * tui/tui-winsource.c (tui_clear_source_content)
6758         (tui_show_source_content): Update.
6759         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6760         whether content is empty.
6761         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6762         Remove.
6763
6764 2019-07-17  Tom Tromey  <tom@tromey.com>
6765
6766         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6767         window's contents.
6768         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6769         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6770
6771 2019-07-17  Tom Tromey  <tom@tromey.com>
6772
6773         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6774         (struct tui_data_item_window): Update.
6775
6776 2019-07-17  Tom Tromey  <tom@tromey.com>
6777
6778         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6779         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6780         defines.
6781
6782 2019-07-17  Tom Tromey  <tom@tromey.com>
6783
6784         * tui/tui-winsource.h (tui_erase_source_content)
6785         (tui_clear_source_content): Remove "display_prompt" parameter.
6786         * tui/tui-winsource.c (tui_update_source_window_as_is)
6787         (tui_update_source_windows_with_addr): Update.
6788         (tui_clear_source_content): Remove "display_prompt" parameter.
6789         (tui_erase_source_content): Likewise.  Simplify.
6790         (tui_show_source_content): Update.
6791         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6792         * tui/tui-stack.c (tui_show_frame_info): Update.
6793         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6794         Remove defines.
6795
6796 2019-07-17  Tom Tromey  <tom@tromey.com>
6797
6798         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6799         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6800         parameter.
6801         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6802         parameter.
6803
6804 2019-07-17  Tom Tromey  <tom@tromey.com>
6805
6806         * tui/tui-winsource.c (tui_clear_source_content)
6807         (tui_show_source_content, tui_show_exec_info_content)
6808         (tui_clear_exec_info_content): Update.
6809         * tui/tui-stack.c (tui_show_locator_content): Update.
6810         (tui_show_frame_info): Update.
6811         * tui/tui-source.h (tui_source_window): Don't declare.
6812         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6813         from tui_source_is_displayed.
6814         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6815         Remove field.
6816         (struct tui_source_window_base) <content_in_use>: New field.  Now
6817         bool.
6818         (struct tui_source_window) <showing_source_p>: New method.
6819         (TUI_SRC_WIN): Change cast.
6820         * tui/tui-data.c (tui_initialize_static_data): Update.
6821
6822 2019-07-17  Tom Tromey  <tom@tromey.com>
6823
6824         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6825         location_matches_p.
6826         * tui/tui-source.c (tui_source_window::location_matches_p): New
6827         method.
6828         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6829         method.
6830         * tui/tui-data.h (struct tui_source_window_base)
6831         <location_matches_p>: New method.
6832         (struct tui_source_window, struct tui_disasm_window)
6833         <location_matches_p>: Likewise.
6834
6835 2019-07-17  Tom Tromey  <tom@tromey.com>
6836
6837         * tui/tui-win.c (tui_set_win_height_command): Rename from
6838         tui_set_win_height.
6839         (tui_set_win_height_command): Remove.
6840
6841 2019-07-17  Tom Tromey  <tom@tromey.com>
6842
6843         * tui/tui-source.c (tui_source_window): New constructor.  Add
6844         observer.
6845         (~tui_source_window): New destructor.
6846         (tui_source_window::style_changed): New method.
6847         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6848         (tui_attach_detach_observers): Update.
6849         * tui/tui-data.h (struct tui_source_window): Make constructor not
6850         inline.  Add destructor.
6851         (struct tui_source_window) <style_changed>: New method.
6852         <m_observable>: New member.
6853
6854 2019-07-17  Tom Tromey  <tom@tromey.com>
6855
6856         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6857         * tui/tui-win.c (tui_resize_all): Fix typo.
6858
6859 2019-07-17  Tom Tromey  <tom@tromey.com>
6860
6861         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6862         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6863         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6864         * tui/tui-win.c (window_name_completer): Use foreach.
6865         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6866         (update_tab_width): Likewise.
6867         * tui/tui-layout.c (show_layout): Update.
6868         * tui/tui-data.h (class tui_window_iterator): New.
6869         (struct all_tui_windows): New.
6870         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6871
6872 2019-07-17  Tom Tromey  <tom@tromey.com>
6873
6874         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6875         parameter.  Don't reference globals.
6876         (tui_reg_command): Update.
6877
6878 2019-07-17  Tom Tromey  <tom@tromey.com>
6879
6880         * tui/tui-regs.c (tui_show_registers): Simplify.
6881
6882 2019-07-17  Tom Tromey  <tom@tromey.com>
6883
6884         * tui/tui-regs.c (tui_show_registers): Update.
6885         (tui_show_register_group): Add win_info parameter.
6886
6887 2019-07-17  Tom Tromey  <tom@tromey.com>
6888
6889         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6890         Rename from tui_display_reg_element_at_line.
6891         (tui_data_window::display_registers_from_line): Update.
6892         * tui/tui-data.h (struct tui_data_window)
6893         <display_reg_element_at_line>: New method.
6894
6895 2019-07-17  Tom Tromey  <tom@tromey.com>
6896
6897         * tui/tui-regs.h (tui_display_registers_from)
6898         (tui_display_registers_from_line): Don't declare.
6899         * tui/tui-windata.c (tui_data_window::display_all_data)
6900         (tui_data_window::refresh_all)
6901         (tui_data_window::do_scroll_vertical): Update.
6902         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6903         from tui_display_registers_from.
6904         (tui_display_reg_element_at_line): Update.
6905         (tui_data_window::display_registers_from_line): Rename from
6906         tui_display_registers_from_line.
6907         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6908         display_registers_from_line>: New methods.
6909
6910 2019-07-17  Tom Tromey  <tom@tromey.com>
6911
6912         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6913         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6914         from tui_erase_data_content.
6915         (tui_data_window::display_all_data)
6916         (tui_data_window::refresh_all)
6917         (tui_data_window::do_scroll_vertical): Update.
6918         * tui/tui-regs.c (tui_show_registers): Update.
6919         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6920         New method.
6921
6922 2019-07-17  Tom Tromey  <tom@tromey.com>
6923
6924         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6925         declare.
6926         * tui/tui-windata.c
6927         (tui_data_window::delete_data_content_windows): Rename from
6928         tui_delete_data_content_windows.
6929         (tui_data_window::display_all_data)
6930         (tui_data_window::do_scroll_vertical): Update.
6931         * tui/tui-data.h (struct tui_data_window)
6932         <delete_data_content_windows>: New method.
6933
6934 2019-07-17  Tom Tromey  <tom@tromey.com>
6935
6936         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6937         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6938
6939 2019-07-17  Tom Tromey  <tom@tromey.com>
6940
6941         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6942         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6943         from tui_display_all_data.
6944         * tui/tui-win.c
6945         (tui_data_window::do_make_visible_with_new_height): Update.
6946         * tui/tui-regs.c (tui_show_registers): Update.
6947         * tui/tui-layout.c (tui_set_layout): Update.
6948         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6949         method.
6950
6951 2019-07-17  Tom Tromey  <tom@tromey.com>
6952
6953         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6954         * tui/tui-windata.c (tui_display_data_from): Remove.
6955         (tui_data_window::refresh_all): Update.
6956
6957 2019-07-17  Tom Tromey  <tom@tromey.com>
6958
6959         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6960         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6961         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6962         tui_display_registers_from_line.
6963         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6964         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6965         "force_display" parameter.
6966
6967 2019-07-17  Tom Tromey  <tom@tromey.com>
6968
6969         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6970         declare.
6971         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6972         Rename from tui_first_reg_element_no_inline.
6973         (tui_display_reg_element_at_line)
6974         (tui_display_registers_from_line): Update.
6975         * tui/tui-data.h (struct tui_data_window)
6976         <first_reg_element_no_inline>: New method.
6977
6978 2019-07-17  Tom Tromey  <tom@tromey.com>
6979
6980         * tui/tui-windata.c (tui_display_data_from)
6981         (tui_data_window::do_scroll_vertical): Update.
6982         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6983         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6984         Rename from tui_line_from_reg_element_no.
6985         (tui_display_registers_from_line): Update.
6986         * tui/tui-data.h (struct tui_data_window)
6987         <line_from_reg_element_no>: New method.
6988
6989 2019-07-17  Tom Tromey  <tom@tromey.com>
6990
6991         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6992         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6993         tui_last_regs_line_no.
6994         (tui_display_reg_element_at_line)
6995         (tui_display_registers_from_line): Update.
6996         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6997         method.
6998
6999 2019-07-17  Tom Tromey  <tom@tromey.com>
7000
7001         PR tui/24722:
7002         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7003         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7004         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7005         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7006         (tui_update_breakpoint_info): Likewise.
7007         * tui/tui-hooks.c (tui_event_create_breakpoint)
7008         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7009         Update.
7010
7011 2019-07-17  Tom Tromey  <tom@tromey.com>
7012
7013         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7014
7015 2019-07-17  Tom Tromey  <tom@tromey.com>
7016
7017         * tui/tui-winsource.c (tui_update_source_window_as_is)
7018         (tui_update_source_windows_with_addr): Update.
7019         * tui/tui-source.h (tui_set_source_content)
7020         (tui_show_symtab_source): Add "win_info" parameter.
7021         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7022         parameter.
7023         (tui_show_symtab_source): Likewise.
7024
7025 2019-07-17  Tom Tromey  <tom@tromey.com>
7026
7027         * tui/tui-wingeneral.c
7028         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7029
7030 2019-07-17  Tom Tromey  <tom@tromey.com>
7031
7032         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7033         (struct tui_cmd_window) <can_scroll>: New method.
7034         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7035         method.
7036
7037 2019-07-17  Tom Tromey  <tromey@adacore.com>
7038
7039         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7040         do_field_signed>: Rename.  Change type of "value".
7041         * ui-out.c (ui_out::field_signed): Rename from field_int.
7042         Change type of "value".
7043         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7044         type of "value".
7045         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7046         do_field_int.  Change type of "value".
7047         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7048         do_field_int.  Change type of "value".
7049         * tracepoint.c (trace_status_mi, tfind_1)
7050         (print_one_static_tracepoint_marker): Update.
7051         * thread.c (print_thread_info_1, print_selected_thread_frame):
7052         Update.
7053         * stack.c (print_frame, print_frame_info): Update.
7054         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7055         Update.
7056         * source.c (print_source_lines_base): Update.
7057         * skip.c (info_skip_command): Update.
7058         * record-btrace.c (btrace_ui_out_decode_error)
7059         (btrace_call_history_src_line): Update.
7060         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7061         Update.
7062         * progspace.c (print_program_space): Update.
7063         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7064         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7065         do_field_int.  Change type of "value".
7066         * mi/mi-out.c (mi_ui_out::do_table_begin)
7067         (mi_ui_out::do_table_header): Update.
7068         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7069         type of "value".
7070         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7071         (mi_cmd_data_list_changed_registers, output_register)
7072         (mi_cmd_data_read_memory, mi_load_progress)
7073         (mi_cmd_trace_frame_collected): Update.
7074         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7075         Update.
7076         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7077         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7078         (mi_cmd_var_list_children, varobj_update_one): Update.
7079         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7080         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7081         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7082         * inferior.c (print_inferior): Update.
7083         * gdb_bfd.c (print_one_bfd): Update.
7084         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7085         Update.
7086         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7087         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7088         do_field_int.  Change type of "value".
7089         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7090         do_field_int.  Change type of "value".
7091         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7092         (print_one_breakpoint_location, print_it_catch_fork)
7093         (print_one_catch_fork, print_it_catch_vfork)
7094         (print_one_catch_vfork, print_it_catch_solib)
7095         (print_it_catch_exec, print_it_ranged_breakpoint)
7096         (print_mention_watchpoint, print_mention_masked_watchpoint)
7097         (bkpt_print_it, update_static_tracepoint): Update.
7098         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7099         * break-catch-syscall.c (print_it_catch_syscall): Update.
7100         * ada-tasks.c (print_ada_task_info): Update.
7101         * ada-lang.c (print_it_exception, print_mention_exception):
7102         Update.
7103
7104 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7105
7106         PR breakpoints/24541
7107         * gdbarch.c: Regenerate.
7108         * gdbarch.h: Regenerate.
7109         * gdbarch.sh: Adjust return type and parameter types for
7110         'stap_adjust_register'.
7111         (i386_stap_adjust_register): Adjust signature and return new
7112         register name.
7113         * stap-probe.c (stap_parse_register_operand): Adjust use of
7114         'gdbarch_stap_adjust_register'.
7115
7116 2019-07-17  Tom Tromey  <tromey@adacore.com>
7117
7118         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7119         declare VEC.
7120         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7121         std::vector.
7122         (struct s390_process_info): Add initializers.
7123         (s390_add_process): Use new.
7124         (s390_linux_nat_target::low_forget_process): Use delete.
7125         (s390_linux_nat_target::low_new_fork)
7126         (s390_linux_nat_target::stopped_by_watchpoint)
7127         (s390_linux_nat_target::low_prepare_to_resume)
7128         (s390_linux_nat_target::insert_watchpoint)
7129         (s390_linux_nat_target::insert_hw_breakpoint)
7130         (s390_linux_nat_target::remove_watchpoint)
7131         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7132
7133 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7134
7135         * aarch64-fbsd-nat.c: Include regcache.h.
7136         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7137         argument.
7138         (aarch64_fbsd_nat_target::fetch_registers)
7139         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7140         variable.
7141         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7142
7143 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7144
7145         * fbsd-nat.c: Include gdbarch.h.
7146
7147 2019-07-15  Tom Tromey  <tromey@adacore.com>
7148
7149         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7150
7151 2019-07-15  Tom Tromey  <tromey@adacore.com>
7152
7153         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7154         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7155         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7156         * cli-out.c (cli_ui_out::do_field_int): New method.
7157         * ui-out.c (ui_out::field_unsigned): New method.
7158         * symfile.c (generic_load): Use field_unsigned.
7159         (print_transfer_performance): Likewise.
7160         * record-btrace.c (ui_out_field_uint): Remove.
7161         (btrace_call_history_insn_range, btrace_call_history): Use
7162         field_unsigned.
7163         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7164         field_unsigned.
7165         * ui-out.h (class ui_out) <field_unsigned>: New method.
7166         <do_field_unsigned>: Likewise.
7167
7168 2019-07-15  Tom Tromey  <tromey@adacore.com>
7169
7170         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7171         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7172         * target.c (flash_erase_command): Use field_string.
7173         * infrun.c (print_signal_received_reason): Use field_string.
7174         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7175         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7176         field_string.
7177         * ada-tasks.c (print_ada_task_info): Use field_string.
7178
7179 2019-07-15  Tom Tromey  <tromey@adacore.com>
7180
7181         * target.c (flash_erase_command): Use field_core_addr.
7182         * symfile.c (generic_load): Use field_core_addr.
7183         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7184         Use field_core_addr.
7185         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7186         field_core_addr.
7187
7188 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7189
7190         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7191         value if its desired type is smaller than a CORE_ADDR and signed.
7192
7193 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7194
7195         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7196         of changes to field names, and use new is_reference field to
7197         decide if a property is a reference or not.
7198         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7199         field.
7200         (struct dwarf2_property_baton): Update header comment, rename
7201         'referenced_type' to 'property_type' and update comments.
7202         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7203         default property type, store in property baton, update to take
7204         accound of renamed field.
7205         (read_func_scope): Update call to attr_to_dynamic_prop.
7206         (read_array_type): Likewise.
7207         (dwarf2_per_cu_addr_sized_int_type): New function.
7208         (read_subrange_index_type): Move type finding code to
7209         dwarf2_per_cu_addr_sized_int_type.
7210         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7211         (dwarf2_per_cu_addr_type): New function.
7212         (set_die_type): Update calls to attr_to_dynamic_prop.
7213
7214 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7215
7216         * dwarf2read.c (read_subrange_index_type): New function.
7217         (read_subrange_type): Move code into new function and call it.
7218         * gdbtypes.c (create_range_type): Add some asserts.
7219
7220 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7221
7222         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7223         update return statements.
7224         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7225         declaration, and update comment to match.
7226         * gdbtypes.c (resolve_dynamic_array): Update call to
7227         dwarf2_evaluate_property to match new return type.
7228
7229 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7230
7231         * valarith.c (value_subscripted_rvalue): Change lowerbound
7232         parameter type from int to LONGEST.
7233         * value.h (value_subscripted_rvalue): Likewise in declaration.
7234
7235 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7236
7237         * cli/cli-utils.c (info_print_command_completer): New function.
7238         * cli/cli-utils.h: Add 'completer.h' include, and forward
7239         declaration for 'struct cmd_list_element'.
7240         (info_print_command_completer): Declare.
7241         * stack.c (_initialize_stack): Add completer for 'info locals' and
7242         'info args'.
7243         * symtab.c (_initialize_symtab): Add completer for 'info
7244         variables' and 'info functions'.
7245         * NEWS: Mention completion for additional info commands.
7246
7247 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7248
7249         * cli/cli-utils.c (extract_info_print_args): Delete.
7250         (extract_arg_maybe_quoted): Delete.
7251         (info_print_options_defs): New variable.
7252         (make_info_print_options_def_group): New function.
7253         (extract_info_print_options): Define new function.
7254         * cli/cli-utils.h (extract_info_print_args): Delete.
7255         (struct info_print_options): New structure.
7256         (extract_info_print_options): Declare new function.
7257         * stack.c (info_locals_command): Update to use new
7258         extract_info_print_options, also add a header comment.
7259         (info_args_command): Likewise.
7260         * symtab.c (info_variables_command): Likewise.
7261         (info_functions_command): Likewise.
7262
7263 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7264
7265         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7266         to extract string arguments.
7267         * common/common-utils.c (extract_string_maybe_quoted): New function.
7268         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7269
7270 2019-07-11  Tom Tromey  <tromey@adacore.com>
7271
7272         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7273         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7274         * top.h (gdbinit): Don't declare.
7275         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7276         into...
7277         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7278         * top.c (gdb_init): Don't call init_cli_cmds.
7279         (gdbinit): Remove.
7280         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7281
7282 2019-07-11  Tom Tromey  <tromey@adacore.com>
7283
7284         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7285         after it has been moved.
7286
7287 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7288
7289         * valops.c (value_must_coerce_to_target): Change return type to
7290         bool.
7291         * value.h (value_must_coerce_to_target): Likewise.
7292
7293 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7294
7295         * breakpoint.c (is_hardware_watchpoint): Remove
7296         forward-declaration.
7297         (is_masked_watchpoint): Change return type to bool.
7298         (is_tracepoint): Likewise.
7299         (is_breakpoint): Likewise.
7300         (is_hardware_watchpoint): Likewise.
7301         (is_watchpoint): Likewise.
7302         (is_no_memory_software_watchpoint): Likewise.
7303         (is_catchpoint): Likewise.
7304         (breakpoint_1): Make FILTER parameter's return type bool.
7305         is_masked_watchpoint): Change return type to bool.
7306         (save_breakpoints): Make FILTER parameter's return type bool.
7307         * breakpoint.h (is_breakpoint): Change return type to bool.
7308         (is_watchpoint): Likewise.
7309         (is_catchpoint): Likewise.
7310         (is_tracepoint): Likewise.
7311
7312 2019-07-10  Tom Tromey  <tom@tromey.com>
7313
7314         * defs.h: Don't include gdbarch.h.
7315         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7316         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7317         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7318         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7319         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7320         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7321         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7322         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7323         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7324         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7325         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7326         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7327         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7328         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7329         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7330         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7331         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7332         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7333         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7334         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7335         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7336         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7337         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7338         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7339         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7340         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7341         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7342
7343 2019-07-10  Tom Tromey  <tromey@adacore.com>
7344
7345         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7346         * breakpoint.c (init_ada_exception_breakpoint): Register as
7347         bp_catchpoint.
7348         (print_one_breakpoint_location, print_one_breakpoint): Use
7349         is_ada_exception_catchpoint.
7350         * ada-lang.c (class ada_catchpoint_location): Pass
7351         bp_loc_software_breakpoint to bp_location constructor.
7352         (is_ada_exception_catchpoint): New function.
7353
7354 2019-07-10  Tom Tromey  <tromey@adacore.com>
7355
7356         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7357         VEC.
7358         (struct arm_exidx_entry): New method operator<.
7359         (struct arm_exidx_data) <section_maps>: Change type.
7360         (arm_exidx_data_free): Remove.
7361         (arm_exidx_data_key): Change type.  Move lower.
7362         (arm_exidx_new_objfile): Update.
7363         (arm_compare_exidx_entries): Remove.
7364         (arm_find_exidx_entry, _initialize_arm_tdep)
7365
7366 2019-07-10  Tom Tromey  <tromey@adacore.com>
7367
7368         * solib-spu.c (ocl_program_data_key): Change type.
7369         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7370         Update.
7371
7372 2019-07-10  Tom Tromey  <tromey@adacore.com>
7373
7374         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7375         (struct solib_aix_inferior_data) <library_list>: Change type.
7376         (solib_aix_inferior_data_handle): Change type.
7377         (get_solib_aix_inferior_data): Update.
7378         (solib_aix_free_library_list): Remove.
7379         (library_list_start_library): Update.
7380         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7381         return type.
7382         (solib_aix_get_library_list)
7383         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7384         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7385
7386 2019-07-10  Tom Tromey  <tromey@adacore.com>
7387
7388         * solib-dsbt.c (struct dsbt_info): Add initializers.
7389         (solib_dsbt_pspace_data): Change type.
7390         (dsbt_pspace_data_cleanup): Remove.
7391         (get_dsbt_info, _initialize_dsbt_solib): Update.
7392
7393 2019-07-10  Tom Tromey  <tromey@adacore.com>
7394
7395         * spu-tdep.c (spu_overlay_data): Change type.
7396         (spu_get_overlay_table, spu_overlay_new_objfile)
7397         (_initialize_spu_tdep): Update.
7398
7399 2019-07-10  Tom Tromey  <tromey@adacore.com>
7400
7401         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7402         destructor.
7403         (dbx_objfile_data_key): Change type and declare later.
7404         (DBX_SYMFILE_INFO): Rewrite.
7405         * dbxread.c (dbx_objfile_data_key): Change type.
7406         (dbx_symfile_init): Update.
7407         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7408         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7409         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7410
7411 2019-07-10  Tom Tromey  <tromey@adacore.com>
7412
7413         * jit.c (jit_program_space_key): Change type.  Move lower.
7414         (get_jit_program_space_data): Update.
7415         (jit_program_space_data_cleanup): Remove.
7416         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7417         Update.
7418         (struct jit_program_space_data): Add initializers.
7419
7420 2019-07-10  Tom Tromey  <tromey@adacore.com>
7421
7422         * solib-darwin.c (struct darwin_info): Add initializers.
7423         (solib_darwin_pspace_data): Change type.
7424         (darwin_pspace_data_cleanup): Remove.
7425         (get_darwin_info, _initialize_darwin_solib): Update.
7426
7427 2019-07-10  Tom Tromey  <tromey@adacore.com>
7428
7429         * remote-sim.c (struct sim_inferior_data): Add initializers,
7430         constructor, and destructor.
7431         (sim_inferior_data_key): Change type.  Move lower.
7432         (check_for_duplicate_sim_descriptor): Update.
7433         (get_sim_inferior_data): Use new.  Update.
7434         (~sim_inferior_data_cleanup): Rename from
7435         sim_inferior_data_cleanup.  Simplify.
7436         (gdbsim_close_inferior, simulator_command)
7437         (sim_command_completer, _initialize_remote_sim): Update.
7438         (next_pid, INITIAL_PID): Move earlier.
7439
7440 2019-07-10  Tom Tromey  <tromey@adacore.com>
7441
7442         * python/python-internal.h (create_thread_object): Return
7443         gdbpy_ref.
7444         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7445         * python/py-inferior.c (struct threadlist_entry): Add
7446         constructor.
7447         <thread_obj>: Now a gdbpy_ref.
7448         (thread_to_thread_object): Update.
7449         (add_thread_object): Use new.
7450         (delete_thread_object): Use delete.
7451         (infpy_threads): Update.
7452         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7453         GIL.
7454
7455 2019-07-10  Tom Tromey  <tromey@adacore.com>
7456
7457         * valops.c (value_cast): Specialize error message for Ada.
7458
7459 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7460
7461         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7462
7463 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7464
7465         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7466         bpstat_should_step): Return bool, adjust comments.
7467         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7468         bpstat_should_step): Likewise.
7469
7470 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7471
7472         * features/Makefile: Use feature target descriptions for Arm.
7473         * features/arm/arm-core.c: Generate new file.
7474         * features/arm/arm-fpa.c: Likewise.
7475         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7476         * features/arm/arm-m-profile.c: Likewise.
7477         * features/arm/arm-vfpv2.c: Likewise.
7478         * features/arm/arm-vfpv3.c: Likewise.
7479         * features/arm/xscale-iwmmxt.c: Likewise.
7480         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7481
7482 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7483
7484         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7485         ptrace earlier.
7486
7487 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7488
7489         * features/aarch64-pauth.c: Regenerate.
7490
7491 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7492
7493         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7494         bool.
7495         (bpstat_what): Use false instead of 0.
7496
7497 2019-07-09  Pedro Alves  <palves@redhat.com>
7498
7499         * break-catch-throw.c (is_exception_catchpoint): New.
7500         * breakpoint.c (print_one_breakpoint_location): New parameter
7501         'raw_loc'.  Handle it.  Use
7502         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7503         looking at the breakpoint's type.
7504         (print_one_breakpoint): If handling "maint info breakpoints", also
7505         print locations of exception catchpoints.
7506         * breakpoint.h (is_exception_catchpoint): Declare.
7507
7508 2019-07-09  Pedro Alves  <palves@redhat.com>
7509
7510         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7511         "addr" field.
7512         (allocate_location_exception_catchpoint): New.
7513         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7514         (initialize_throw_catchpoint_ops): Install
7515         allocate_location_exception_catchpoint as allocate_location
7516         method.
7517         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7518         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7519         bp_loc_other.
7520         (breakpoint_address_is_meaningful): Delete.
7521         (bl_address_is_meaningful): New.
7522         (breakpoint_locations_match): Adjust comment.
7523         (bp_location_from_bp_type): New, factored out of...
7524         (bp_location::bp_location(breakpoint *)): ... this.
7525         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7526         factored out of...
7527         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7528         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7529         breakpoint_address_is_meaningful.
7530         (bp_locations_compare): Adjust comment.
7531         (update_global_location_list): Use bl_address_is_meaningful
7532         instead of breakpoint_address_is_meaningful.
7533         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7534         explicit.
7535         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7536         * python/py-breakpoint.c (bppy_get_location): No longer check
7537         whether location is null.
7538
7539 2019-07-09  Pedro Alves  <palves@redhat.com>
7540
7541         PR c++/15468
7542         * breakpoint.c (print_one_breakpoint_location): Remove
7543         single-location assert.
7544
7545 2019-07-09  Tom Tromey  <tom@tromey.com>
7546
7547         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7548         * configure: Rebuild.
7549         * configure.ac: Change common to gdbsupport.
7550         * gdbsupport: Rename from common.
7551         * acinclude.m4: Change common to gdbsupport.
7552         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7553         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7554         gdbsupport.
7555         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7556         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7557         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7558         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7559         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7560         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7561         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7562         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7563         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7564         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7565         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7566         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7567         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7568         coff-pe-read.c, command.h, compile/compile-c-support.c,
7569         compile/compile-c.h, compile/compile-cplus-symbols.c,
7570         compile/compile-cplus-types.c, compile/compile-cplus.h,
7571         compile/compile-loc2c.c, compile/compile.c, completer.c,
7572         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7573         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7574         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7575         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7576         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7577         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7578         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7579         features/aarch64-core.c, features/aarch64-fpu.c,
7580         features/aarch64-pauth.c, features/aarch64-sve.c,
7581         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7582         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7583         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7584         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7585         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7586         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7587         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7588         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7589         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7590         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7591         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7592         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7593         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7594         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7595         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7596         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7597         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7598         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7599         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7600         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7601         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7602         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7603         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7604         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7605         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7606         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7607         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7608         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7609         minsyms.c, mips-linux-tdep.c, namespace.h,
7610         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7611         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7612         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7613         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7614         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7615         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7616         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7617         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7618         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7619         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7620         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7621         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7622         procfs.c, producer.c, progspace.h, psymtab.h,
7623         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7624         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7625         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7626         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7627         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7628         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7629         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7630         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7631         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7632         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7633         target-memory.c, target.c, target.h, target/waitstatus.c,
7634         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7635         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7636         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7637         unittests/array-view-selftests.c,
7638         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7639         unittests/common-utils-selftests.c,
7640         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7641         unittests/format_pieces-selftests.c,
7642         unittests/function-view-selftests.c,
7643         unittests/lookup_name_info-selftests.c,
7644         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7645         unittests/mkdir-recursive-selftests.c,
7646         unittests/observable-selftests.c,
7647         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7648         unittests/parse-connection-spec-selftests.c,
7649         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7650         unittests/scoped_fd-selftests.c,
7651         unittests/scoped_mmap-selftests.c,
7652         unittests/scoped_restore-selftests.c,
7653         unittests/string_view-selftests.c, unittests/style-selftests.c,
7654         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7655         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7656         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7657         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7658         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7659         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7660
7661 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7662
7663         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7664         bool value.
7665         (decode_digits_ordinary): Set explicit_line field in sal.
7666         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7667         symtab_and_line that was set on an explicit line number in
7668         assembler code.  Do always update the recorded symtab and line if
7669         we do skip the prologue.
7670
7671 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7672
7673         * breakpoint.c (set_breakpoint_location_function): Remove
7674         explicit_loc parameter.
7675         (momentary_breakpoint_from_master): Update call to
7676         set_breakpoint_location_function.
7677         (add_location_to_breakpoint): Likewise.
7678
7679 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7680
7681         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7682         required features based on default bfd type when no specific bfd
7683         is present.
7684
7685 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7686
7687         * NEWS: Mention that GDB printf and eval commands can now print
7688         C-style and Ada-style convenience var strings without
7689         calling the inferior.
7690         * printcmd.c (printf_c_string): Locally print GDB internal var
7691         instead of transiting via the inferior.
7692         (printf_wide_c_string): Likewise.
7693
7694 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7695
7696         PR breakpoints/25011
7697         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7698
7699 2019-07-04  Tom Tromey  <tom@tromey.com>
7700
7701         PR tui/24724:
7702         * tui/tui-winsource.c (tui_clear_source_content): Update.
7703         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7704         (tui_update_breakpoint_info): Update.
7705         (tui_set_exec_info_content): Update.
7706         * tui/tui-source.c (tui_set_source_content_nil): Update.
7707         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7708         has_break.
7709         * tui/tui-data.h (enum tui_bp_flag): New.
7710         (tui_bp_flags): New enum flags type.
7711         (struct tui_source_element) <break_mode>: Change type.  Rename
7712         from has_break.
7713         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7714         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7715         constants.
7716         * tui/tui-winsource.h: Fix comment.
7717
7718 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7719
7720         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7721         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7722         (store_fpregs_to_thread)
7723         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7724         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7725         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7726         (IWMMXT_REGS_SIZE): Add define.
7727         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7728         (fetch_vfp_regs, store_vfp_regs)
7729         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7730         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7731
7732 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7733
7734         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7735         defines.
7736         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7737         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7738         (ARM_INT_REGISTER_SIZE): ...to this.
7739         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7740         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7741         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7742         (arm_linux_collect_gregset, supply_nwfpe_register)
7743         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7744         defines.
7745         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7746         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7747         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7748         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7749         (arm_return_in_memory, arm_store_return_value)
7750         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7751         (arm_record_ld_st_multiple): Likewise.
7752         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7753         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7754
7755 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7756
7757         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7758         AARCH64_DISPLACED_MODIFIED_INSNS.
7759         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7760         (aarch64_displaced_step_copy_insn): Likewise.
7761         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7762         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7763         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7764         ARM_DISPLACED_MODIFIED_INSNS.
7765         * arm-tdep.c (arm_gdbarch_init): Likewise.
7766         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7767         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7768         (struct arm_displaced_step_closure): Use
7769         ARM_DISPLACED_MODIFIED_INSNS.
7770
7771 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7772
7773         * features/Makefile: Remove unused xml files.
7774         * features/aarch64.xml: Remove.
7775         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7776         * features/i386/amd64-avx-avx512.xml: Remove.
7777         * features/i386/amd64-avx-linux.xml: Remove.
7778         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7779         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7780         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7781         * features/i386/amd64-avx-mpx.xml: Remove.
7782         * features/i386/amd64-avx.xml: Remove.
7783         * features/i386/amd64-linux.xml: Remove.
7784         * features/i386/amd64-mpx-linux.xml: Remove.
7785         * features/i386/amd64-mpx.xml: Remove.
7786         * features/i386/amd64.xml: Remove.
7787         * features/i386/i386-avx-avx512-linux.xml: Remove.
7788         * features/i386/i386-avx-avx512.xml: Remove.
7789         * features/i386/i386-avx-linux.xml: Remove.
7790         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7791         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7792         * features/i386/i386-avx-mpx-linux.xml: Remove.
7793         * features/i386/i386-avx-mpx.xml: Remove.
7794         * features/i386/i386-avx.xml: Remove.
7795         * features/i386/i386-linux.xml: Remove.
7796         * features/i386/i386-mmx-linux.xml: Remove.
7797         * features/i386/i386-mmx.xml: Remove.
7798         * features/i386/i386-mpx-linux.xml: Remove.
7799         * features/i386/i386-mpx.xml: Remove.
7800         * features/i386/i386.xml: Remove.
7801         * features/i386/x32-avx-avx512-linux.xml: Remove.
7802         * features/i386/x32-avx-linux.xml: Remove.
7803         * features/i386/x32-linux.xml: Remove.
7804
7805 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7806
7807         * regformats/aarch64.dat: Remove.
7808         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7809         * regformats/i386/amd64-avx-linux.dat: Remove.
7810         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7811         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7812         * regformats/i386/amd64-linux.dat: Remove.
7813         * regformats/i386/amd64-mpx-linux.dat: Remove.
7814         * regformats/i386/amd64.dat: Remove.
7815         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7816         * regformats/i386/i386-avx-linux.dat: Remove.
7817         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7818         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7819         * regformats/i386/i386-linux.dat: Remove.
7820         * regformats/i386/i386-mmx-linux.dat: Remove.
7821         * regformats/i386/i386-mpx-linux.dat: Remove.
7822         * regformats/i386/i386.dat: Remove.
7823         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7824         * regformats/i386/x32-avx-linux.dat: Remove.
7825         * regformats/i386/x32-linux.dat: Remove.
7826
7827 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7828
7829         * aarch64-tdep.c: Remove xml self tests.
7830         * amd64-linux-tdep.c: Likewise.
7831         * amd64-tdep.c: Likewise.
7832         * i386-linux-tdep.c: Likewise.
7833         * i386-tdep.c: Likewise.
7834
7835 2019-07-03  Pedro Alves  <palves@redhat.com>
7836
7837         PR cli/24732
7838         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7839         (pipe_cmd_option_defs): New.
7840         (make_pipe_cmd_options_def_group): New.
7841         (pipe_command): Use gdb::option::process_options.
7842         (pipe_command_completer): New function.
7843         (_initialize_cli_cmds): Install completer for "pipe" command.
7844
7845 2019-07-03  Pedro Alves  <palves@redhat.com>
7846
7847         * cli/cli-option.c (union option_value) <string>: New field.
7848         (struct option_def_and_value): Add ctor, move ctor, dtor and
7849         use DISABLE_COPY_AND_ASSIGN.
7850         (option_def_and_value::clear_value): New.
7851         (parse_option, save_option_value_in_ctx, get_val_type_str)
7852         (add_setshow_cmds_for_options): Handle var_string.
7853         * cli-option.h (union option_def::var_address) <string>: New
7854         field.
7855         (struct string_option_def): New.
7856         * maint-test-options.c (struct test_options_opts): Add default
7857         ctor and use DISABLE_COPY_AND_ASSIGN.
7858         <string_opt>: New field.
7859         (test_options_opts::~test_options_opts): New.
7860         (test_options_opts::dump): Also dump "-string".
7861         (test_options_option_defs): Install "string.
7862
7863 2019-07-03  Pedro Alves  <palves@redhat.com>
7864
7865         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7866         option_value with a null enumeration.
7867         (complete_options): Save the option values in the context.
7868         (save_option_value_in_ctx): New, factored out from ...
7869         (process_options): ... here.
7870         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7871         of the function.
7872         * maint-test-options.c (test_options_opts::dump): New, factored
7873         out from ...
7874         (maintenance_test_options_command_mode): ... here.
7875         (maintenance_test_options_command_completion_result): Delete.
7876         (maintenance_test_options_command_completion_text): Update
7877         comment.
7878         (maintenance_show_test_options_completion_result): Change
7879         prototype.  Just print
7880         maintenance_test_options_command_completion_text.
7881         (save_completion_result): New.
7882         (maintenance_test_options_completer_mode): Pass options context to
7883         complete_options, and then save a dump.
7884         (_initialize_maint_test_options): Use add_cmd to install "maint
7885         show test-options-completion-result".
7886
7887 2019-07-03  Pedro Alves  <palves@redhat.com>
7888
7889         * NEWS (New commands): Mention "with" and "maint with".
7890         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7891         (with_command, with_command_completer): New.
7892         (pipe_command): Adjust to new repeat_previous
7893         interface.
7894         (_initialize_cli_cmds): Install the "with" command and its "w"
7895         alias.
7896         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7897         declarations.
7898         * cli/cli-setshow.c (parse_cli_var_uinteger)
7899         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7900         argument strings for all var_types.
7901         (get_setshow_command_value_string): New, factored out from ...
7902         (do_show_command): ... this.
7903         * cli/cli-setshow.h: Include <string>.
7904         (get_setshow_command_value_string): Declare.
7905         * command.h (repeat_previous): Now returns const char *.  Adjust
7906         comment.
7907         * maint.c: Include "cli/cli-cmds.h".
7908         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7909         (_initialize_maint_cmds): Register the "maintenance with" command.
7910         * top.c (repeat_previous): Move bits from pipe_command here:
7911         Return the saved command line, if any; error out if there's no
7912         command to relaunch.
7913
7914 2019-07-03  Pedro Alves  <palves@redhat.com>
7915
7916         * NEWS (New commands): Mention "maint set/show test-settings"
7917         instead of "maint test-settings".
7918         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7919         (maintenance_test_settings_set_list): Rename to ...
7920         (maintenance_set_test_settings_list): ... this.
7921         (maintenance_test_settings_show_list): Rename to  ...
7922         (maintenance_show_test_settings_list): ... this.
7923         (maintenance_test_settings_cmd): Delete.
7924         (maintenance_test_settings_set_cmd): ...
7925         (maintenance_set_test_settings_cmd): ... this.
7926         (maintenance_test_settings_show_cmd): ...
7927         (maintenance_show_test_settings_cmd): ... this.
7928         (maintenance_test_settings_show_value_cmd):
7929         (maintenance_show_test_settings_value_cmd): ... this.
7930         (_initialize_maint_test_settings): No longer install the "maint
7931         test-settings" prefix command.  Rename "maint test-settings set"
7932         to "maint set test-settings", and "maint test-settings show" to
7933         "maint show test-settings".  Adjust all subcommands.
7934
7935 2019-07-03  Pedro Alves  <palves@redhat.com>
7936
7937         * maint-test-settings.c: Fix file's intro comment.  Replace all
7938         references to "test-options" with references to "test-settings",
7939         in comments.
7940
7941 2019-07-03  Pedro Alves  <palves@redhat.com>
7942
7943         * maint-test-settings.c (maintenance_test_settings_xxx)
7944         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7945         New.
7946         (maintenance_test_settings_enums): Use them.
7947         (maintenance_test_settings_enum): Default to
7948         maintenance_test_settings_xxx.
7949         (_initialize_maint_test_settings): Initialize
7950         MAINTENANCE_TEST_SETTINGS_FILENAME.
7951
7952 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7953
7954         * breakpoint.h (remove_breakpoints_inf): Change return type to
7955         void, move function documentation here.
7956         * breakpoint.c (remove_breakpoints_inf): Change return type to
7957         void, move function documentation to header.
7958
7959 2019-07-02  Pedro Alves  <palves@redhat.com>
7960
7961         * NEWS (Completion improvements): Mention "info threads".
7962         * thread.c (struct info_threads_opts, info_threads_option_defs)
7963         (make_info_threads_options_def_group): New.
7964         (info_threads_command): Use gdb::option::process_options.
7965         (info_threads_command_completer): New.
7966         (_initialize_thread): Use gdb::option::build_help to build the
7967         help text for "info threads".
7968
7969 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7970
7971         * defs.h (generic_load): Move from here...
7972         * symfile.h (generic_load): ... to here.  Rename name parameter
7973         to args.
7974         * symfile.c (generic_load): Add comment.
7975
7976 2019-07-01  Tom Tromey  <tromey@adacore.com>
7977
7978         * dwarf2read.c
7979         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7980         declaration of without_params.  Fix formatting.
7981
7982 2019-07-01  Tom Tromey  <tromey@adacore.com>
7983
7984         * ada-exp.y (find_primitive_type): Update.
7985         * ada-lang.h (ada_lookup_symbol): Update.
7986         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7987         parameter.
7988         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7989
7990 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7991
7992         PR breakpoints/24541
7993         * gdbarch.c: Regenerate.
7994         * gdbarch.h: Regenerate.
7995         * gdbarch.sh: Add 'stap_adjust_register'.
7996         * i386-tdep.c: Include '<unordered_set>'.
7997         (i386_stap_adjust_register): New function.
7998         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7999         * stap-probe.c (stap_parse_register_operand): Call
8000         'gdbarch_stap_adjust_register'.
8001
8002 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8003
8004         PR python/24742
8005         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8006         * python/python.c (do_start_initialization): Use 'xmalloc'
8007         instead of 'PyMem_Malloc'.
8008
8009 2019-06-28  Tom Tromey  <tromey@adacore.com>
8010
8011         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8012         for Ada.
8013
8014 2019-06-27  Tom Tromey  <tromey@adacore.com>
8015
8016         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8017         objfile_key.
8018         (arm_find_mapping_symbol, arm_record_special_symbol)
8019         (_initialize_arm_tdep): Update.
8020         (arm_objfile_data_free): Remove.
8021
8022 2019-06-27  Tom Tromey  <tromey@adacore.com>
8023
8024         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8025         to cp_print_static_field.
8026
8027 2019-06-26  Tom Tromey  <tromey@adacore.com>
8028
8029         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8030         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8031         declare.
8032
8033 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8034
8035         * features/aarch64-core.c (create_feature_aarch64_core):
8036         Regenerate.
8037         * features/aarch64-core.xml: Add cpsr flags.
8038
8039 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8040
8041         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8042         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8043
8044 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8045
8046         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8047         field.
8048         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8049         use.
8050         (arm_record_special_symbol): Don't insert new symbol in sorted
8051         position, push it at the end.
8052
8053 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8054
8055         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8056         (arm_mapping_symbol_s): Remove.
8057         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8058         (arm_mapping_symbol_vec): New typedef.
8059         (struct arm_per_objfile): Add constructor.
8060         <section_maps>: Change type to
8061         std::unique_ptr<arm_mapping_symbol_vec[]>.
8062         (arm_compare_mapping_symbols): Remove.
8063         (arm_find_mapping_symbol): Adjust to section_maps type change.
8064         (arm_objfile_data_free): Call delete on arm_per_objfile.
8065         (arm_record_special_symbol): Adjust to section_maps type change.
8066         Allocate arm_per_objfile with new.
8067
8068 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8069
8070         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8071         with the command prefix.
8072
8073 2019-06-25  Tom Tromey  <tom@tromey.com>
8074
8075         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8076         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8077
8078 2019-06-25  Tom Tromey  <tom@tromey.com>
8079
8080         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8081         type.
8082         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8083         protected.
8084
8085 2019-06-25  Tom Tromey  <tom@tromey.com>
8086
8087         * tui/tui-winsource.c
8088         (tui_source_window_base::set_is_exec_point_at): Add check against
8089         LOA_ADDRESS.
8090
8091 2019-06-25  Tom Tromey  <tom@tromey.com>
8092
8093         * tui/tui-source.c (tui_set_source_content): Don't check before
8094         xfree.
8095         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8096
8097 2019-06-25  Tom Tromey  <tom@tromey.com>
8098
8099         * tui/tui-winsource.h (tui_update_source_window_as_is)
8100         (tui_alloc_source_buffer, tui_line_is_displayed)
8101         (tui_addr_is_displayed): Change type of win_info.
8102         * tui/tui-winsource.c (tui_update_source_window_as_is)
8103         (tui_clear_source_content, tui_show_source_line)
8104         (tui_show_source_content, tui_source_window_base::refill)
8105         (tui_source_window_base::set_is_exec_point_at)
8106         (tui_source_window_base::set_is_exec_point_at)
8107         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8108         (tui_alloc_source_buffer, tui_line_is_displayed)
8109         (tui_addr_is_displayed): Change type of win_info.  Update.
8110         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8111         (tui_source_window_base::do_make_visible_with_new_height):
8112         Update.
8113         * tui/tui-source.c (tui_set_source_content)
8114         (tui_set_source_content_nil)
8115         (tui_source_window::do_scroll_vertical): Update.
8116         * tui/tui-layout.c (show_layout): Update.
8117         * tui/tui-disasm.c (tui_set_disassem_content)
8118         (tui_disasm_window::do_scroll_vertical): Update.
8119         * tui/tui-data.h (tui_win_content): Remove.
8120         (struct tui_gen_win_info) <content, content_size>: Remove.
8121         (struct tui_source_element): Add initializers and destructor.
8122         (union tui_which_element, struct tui_win_element): Remove.
8123         (struct tui_source_window_base) <content>: New field.
8124         (struct tui_data_window): Remove destructor.
8125         (tui_alloc_content, tui_free_win_content)
8126         (tui_free_all_source_wins_content): Don't declare.
8127         * tui/tui-data.c (tui_initialize_static_data): Update.
8128         (init_content_element, tui_alloc_content): Remove.
8129         (~tui_gen_win_info): Update.
8130         (~tui_data_window, tui_free_all_source_wins_content)
8131         (tui_free_win_content, free_content, free_content_elements):
8132         Remove.
8133
8134 2019-06-25  Tom Tromey  <tom@tromey.com>
8135
8136         * tui/tui-winsource.h (tui_clear_source_content)
8137         (tui_erase_source_content, tui_show_source_content): Change type
8138         of win_info.
8139         * tui/tui-winsource.c (tui_clear_source_content)
8140         (tui_erase_source_content, tui_show_source_content): Change type
8141         of win_info.
8142         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8143         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8144         win_info.
8145         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8146         win_info.
8147         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8148
8149 2019-06-25  Tom Tromey  <tom@tromey.com>
8150
8151         * tui/tui-winsource.c (tui_clear_source_content)
8152         (tui_source_window_base::set_is_exec_point_at): Update.
8153         * tui/tui-source.c (tui_set_source_content_nil): Update.
8154         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8155         a bool.
8156         * tui/tui-data.c (init_content_element): Update.
8157
8158 2019-06-25  Tom Tromey  <tom@tromey.com>
8159
8160         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8161         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8162         * tui/tui-layout.c (init_and_make_win): Update.
8163         * tui/tui.h (enum tui_win_type): Update.
8164         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8165         tui_win_is_auxillary.
8166         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8167         tui_win_is_auxillary.
8168
8169 2019-06-25  Tom Tromey  <tom@tromey.com>
8170
8171         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8172         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8173         (tui_delete_data_content_windows, tui_display_all_data)
8174         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8175         Update.
8176         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8177         * tui/tui-regs.c (tui_last_regs_line_no)
8178         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8179         (tui_show_registers): Update.
8180         (tui_show_register_group): Return void.  Update.
8181         (tui_display_registers_from, tui_display_reg_element_at_line)
8182         (tui_display_registers_from_line, tui_check_register_values):
8183         Update.
8184         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8185         member.
8186         (struct tui_data_window) <regs_content>: Now a std::vector.
8187         <regs_content_count>: Remove.
8188         (tui_add_content_elements, tui_free_data_content): Don't declare.
8189         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8190         (init_content_element): Remove DATA_WIN case.  Add assert.
8191         (tui_add_content_elements): Remove.
8192         (tui_data_window): Update.
8193         (tui_free_data_content): Remove.
8194         (free_content_elements): Remove DATA_WIN case.
8195
8196 2019-06-25  Tom Tromey  <tom@tromey.com>
8197
8198         * tui/tui-data.c (tui_data_item_window): Update.
8199         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8200         * tui/tui-windata.c (tui_display_all_data)
8201         (tui_display_data_from_line): Update.
8202         (tui_check_data_values): Remove.
8203         * tui/tui-regs.c (tui_show_register_group)
8204         (tui_display_reg_element_at_line): Update.
8205         * tui/tui-hooks.c (tui_register_changed)
8206         (tui_refresh_frame_and_register_information): Call
8207         tui_check_register_values.
8208         * tui/tui-data.h (struct tui_data_window) <data_content,
8209         data_content_count, data_type>: Remove.
8210         (enum tui_data_type): Remove.
8211
8212         * tui/tui-data.c (tui_data_window::clear_detail)
8213         (~tui_data_window): Update.
8214
8215 2019-06-25  Tom Tromey  <tom@tromey.com>
8216
8217         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8218         declare.
8219         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8220         Rename from tui_first_data_item_displayed.  Update.
8221         (tui_data_window::refresh_all)
8222         (tui_data_window::do_scroll_vertical): Update.
8223         * tui/tui-data.h (struct tui_data_window)
8224         <first_data_item_displayed>: Declare new method.
8225
8226 2019-06-25  Tom Tromey  <tom@tromey.com>
8227
8228         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8229         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8230         contents...
8231         (tui_initialize_static_data): ...here.
8232
8233 2019-06-25  Tom Tromey  <tom@tromey.com>
8234
8235         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8236         (tui_display_registers_from, tui_check_register_values): Update.
8237         (tui_display_register): Remove win_info parameter; update.
8238         (tui_get_register): Change type of parameters.
8239         * tui/tui-data.h (struct tui_data_element): Remove.
8240         (union tui_which_element) <data>: Remove.
8241         <data_window>: Change type.
8242         (struct tui_data_item_window): New.
8243         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8244         case.  Add assert.
8245         (~tui_data_item_window): New destructor.
8246         (free_content_elements): Remove DATA_ITEM_WIN case.
8247
8248 2019-06-25  Tom Tromey  <tom@tromey.com>
8249
8250         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8251         Remove.
8252
8253 2019-06-25  Tom Tromey  <tom@tromey.com>
8254
8255         * tui/tui-data.h (struct tui_command_element): Remove.
8256         (union tui_which_element) <command>: Remove.
8257         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8258         assert.
8259         (free_content_elements): Remove CMD_WIN case.
8260
8261 2019-06-25  Tom Tromey  <tom@tromey.com>
8262
8263         * tui/tui-layout.c (tui_set_layout): Update.
8264         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8265         * tui/tui-data.c (layout_def): Update.
8266
8267 2019-06-25  Tom Tromey  <tom@tromey.com>
8268
8269         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8270         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8271         (tui_source_window_base::set_new_height): Update.
8272         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8273         Update.
8274         (tui_set_locator_fullname, tui_set_locator_info)
8275         (tui_show_frame_info): Update.
8276         * tui/tui-source.c (tui_set_source_content)
8277         (tui_source_is_displayed): Update.
8278         * tui/tui-layout.c (show_source_disasm_command, show_data)
8279         (show_source_or_disasm_and_command): Update.
8280         * tui/tui-disasm.c (tui_set_disassem_content)
8281         (tui_get_begin_asm_address): Update.
8282         * tui/tui-data.h (struct tui_locator_element): Remove.
8283         (union tui_which_element) <locator>: Remove.
8284         (struct tui_locator_window): New.
8285         (tui_locator_win_info_ptr): Change return type.
8286         * tui/tui-data.c (_locator): Change type.
8287         (tui_locator_win_info_ptr): Change return type.
8288         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8289         (tui_alloc_content): Add assert.
8290
8291 2019-06-25  Tom Tromey  <tom@tromey.com>
8292
8293         * tui/tui-winsource.c
8294         (tui_exec_info_window::maybe_allocate_content): New method.
8295         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8296         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8297         (make_source_or_disasm_window): Add cast.
8298         * tui/tui-data.h (union tui_which_element) <simple_string>:
8299         Remove.
8300         (struct tui_source_info): New.
8301         (struct tui_source_window_base) <execution_info>: Change type.
8302         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8303         case, and add assert.
8304         (tui_alloc_content): Add assert.
8305
8306 2019-06-25  Tom Tromey  <tom@tromey.com>
8307
8308         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8309         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8310         * tui/tui-data.c (tui_alloc_win_info): Remove.
8311
8312 2019-06-25  Tom Tromey  <tom@tromey.com>
8313
8314         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8315         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8316         can_highlight.
8317
8318 2019-06-25  Tom Tromey  <tom@tromey.com>
8319
8320         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8321         make_visible_with_new_height method.
8322         (tui_win_info::make_visible_with_new_height): New method.
8323         (tui_source_window_base::do_make_visible_with_new_height)
8324         (tui_data_window::do_make_visible_with_new_height)
8325         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8326         (make_visible_with_new_height): Remove.
8327         (tui_resize_all, tui_adjust_win_heights): Use
8328         make_visible_with_new_height method.
8329         * tui/tui-data.h (struct tui_win_info)
8330         <do_make_visible_with_new_height, make_visible_with_new_height>:
8331         New methods.
8332         (struct tui_source_window_base, struct tui_data_window)
8333         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8334         methods.
8335
8336 2019-06-25  Tom Tromey  <tom@tromey.com>
8337
8338         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8339         method.
8340         (update_tab_width): Call update_tab_width method.
8341         * tui/tui-data.h (struct tui_win_info)
8342         (struct tui_source_window_base) <update_tab_width>: New methods.
8343
8344 2019-06-25  Tom Tromey  <tom@tromey.com>
8345
8346         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8347         parameter.
8348         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8349         parameter.
8350         (tui_gen_win_info::make_visible): Update.
8351         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8352         parameter.
8353         * tui/tui-data.h (enum tui_box): New enum.
8354         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8355
8356 2019-06-25  Tom Tromey  <tom@tromey.com>
8357
8358         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8359         init_and_make_win for EXEC_INFO_WIN.
8360         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8361         longer inline.
8362         (struct tui_win_info) <~tui_win_info>: Inline.
8363         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8364         Don't declare.
8365         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8366         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8367         Remove.
8368         (tui_initialize_static_data): Update.
8369         (~tui_gen_win_info): Handle more cleanup here.
8370         (~tui_source_window_base): Delete "execution_info".
8371         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8372
8373 2019-06-25  Tom Tromey  <tom@tromey.com>
8374
8375         * tui/tui-layout.c (make_command_window): Don't set
8376         can_highlight.
8377         (show_source_disasm_command): Call the reset method.
8378         (show_data): Don't set can_highlight.  Call the reset method.
8379         (tui_gen_win_info::reset): Rename from init_gen_win_info
8380         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8381         (show_source_or_disasm_and_command): Call the reset method.
8382         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8383         (struct tui_cmd_window): Set can_highlight.
8384
8385 2019-06-25  Tom Tromey  <tom@tromey.com>
8386
8387         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8388         from make_visible.
8389         (tui_make_visible, tui_make_invisible): Rewrite.
8390         (tui_win_info::make_visible): Remove.
8391         (tui_source_window_base::make_visible): Update.
8392         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8393         method.  Moved from...
8394         (struct tui_win_info) <make_visible>: ...here.
8395
8396 2019-06-25  Tom Tromey  <tom@tromey.com>
8397
8398         * tui/tui-winsource.c
8399         (tui_source_window_base::do_scroll_horizontal): Remove direction
8400         parameter.
8401         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8402         direction parameter.
8403         * tui/tui-win.c (tui_win_info::forward_scroll)
8404         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8405         (tui_win_info::right_scroll): Update.
8406         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8407         direction parameter.
8408         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8409         direction parameter.
8410         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8411         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8412         Remove direction parameter.
8413         (struct tui_source_window_base, struct tui_source_window)
8414         (struct tui_disasm_window, struct tui_data_window)
8415         (struct tui_cmd_window): Update.
8416
8417 2019-06-25  Tom Tromey  <tom@tromey.com>
8418
8419         * tui/tui-winsource.h (tui_set_exec_info_content)
8420         (tui_show_exec_info_content, tui_erase_exec_info_content)
8421         (tui_clear_exec_info_content, tui_update_exec_info): Change
8422         argument to tui_source_window_base.
8423         * tui/tui-winsource.c (tui_set_exec_info_content)
8424         (tui_show_exec_info_content, tui_erase_exec_info_content)
8425         (tui_clear_exec_info_content, tui_update_exec_info): Change
8426         argument to tui_source_window_base.
8427
8428 2019-06-25  Tom Tromey  <tom@tromey.com>
8429
8430         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8431         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8432
8433 2019-06-25  Tom Tromey  <tom@tromey.com>
8434
8435         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8436         check.
8437
8438 2019-06-25  Tom Tromey  <tom@tromey.com>
8439
8440         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8441         type to void.
8442         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8443         type to void.
8444         * tui/tui-source.c (tui_set_source_content): Update.
8445         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8446
8447 2019-06-25  Tom Tromey  <tom@tromey.com>
8448
8449         * tui/tui-win.c (window_name_completer, tui_set_focus)
8450         (tui_all_windows_info): Use name method.
8451         * tui/tui-data.h (struct tui_gen_win_info)
8452         (struct tui_source_window, struct tui_disasm_window)
8453         (struct tui_data_window, struct tui_cmd_window) <name>: New
8454         method.
8455         (tui_win_name): Don't declare.
8456         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8457         (tui_win_name): Remove.
8458
8459 2019-06-25  Tom Tromey  <tom@tromey.com>
8460
8461         * tui/tui-winsource.h (tui_update_source_window)
8462         (tui_update_source_window_as_is): Change parameter type.
8463         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8464         to be a tui_source_window_base.
8465         (tui_update_source_window_as_is): Likewise.
8466         * tui/tui-win.c (make_visible_with_new_height): Update.
8467
8468 2019-06-25  Tom Tromey  <tom@tromey.com>
8469
8470         * tui/tui-winsource.c (tui_erase_source_content)
8471         (tui_show_source_content, tui_show_exec_info_content)
8472         (tui_erase_exec_info_content): Use refresh_window method.
8473         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8474         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8475         from tui_refresh_win.
8476         (tui_data_window::refresh_window): New method.
8477         (tui_win_info::refresh, tui_source_window_base::refresh)
8478         (tui_refresh_all): Use refresh_window method.
8479         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8480         method.
8481         * tui/tui-regs.c (tui_display_register): Call refresh_window
8482         method.
8483         * tui/tui-layout.c (show_source_disasm_command)
8484         (show_source_or_disasm_and_command): Call refresh_window method.
8485         * tui/tui-data.h (struct tui_gen_win_info)
8486         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8487         New method.
8488
8489 2019-06-25  Tom Tromey  <tom@tromey.com>
8490
8491         * tui/tui.c (tui_rl_other_window, tui_enable)
8492         (tui_is_window_visible, tui_get_command_dimension): Update.
8493         * tui/tui-winsource.c (tui_update_source_window_as_is)
8494         (tui_clear_source_content, tui_erase_source_content)
8495         (tui_show_source_line, tui_source_window_base::refill)
8496         (tui_source_window_base::do_scroll_horizontal)
8497         (tui_source_window_base::set_is_exec_point_at)
8498         (tui_update_breakpoint_info, tui_set_exec_info_content)
8499         (tui_alloc_source_buffer, tui_line_is_displayed)
8500         (tui_addr_is_displayed): Update.
8501         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8502         (tui_check_and_display_highlight_if_needed)
8503         (tui_win_info::make_visible, tui_win_info::refresh)
8504         (tui_refresh_all): Update.
8505         * tui/tui-windata.c (tui_first_data_item_displayed)
8506         (tui_delete_data_content_windows, tui_erase_data_content)
8507         (tui_display_all_data, tui_data_window::refresh_all)
8508         (tui_check_data_values): Update.
8509         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8510         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8511         (tui_win_info::backward_scroll, tui_refresh_all_win)
8512         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8513         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8514         (tui_source_window_base::set_new_height)
8515         (tui_data_window::set_new_height)
8516         (make_invisible_and_set_new_height)
8517         (make_visible_with_new_height, new_height_ok)
8518         (parse_scrolling_args): Update.
8519         * tui/tui-stack.c (tui_show_frame_info): Update.
8520         * tui/tui-source.c (tui_set_source_content)
8521         (tui_set_source_content_nil, tui_source_is_displayed)
8522         (tui_source_window::do_scroll_vertical): Update.
8523         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8524         (tui_display_registers_from, tui_display_reg_element_at_line)
8525         (tui_check_register_values, tui_reg_command): Update.
8526         * tui/tui-layout.c (tui_default_win_height)
8527         (show_source_disasm_command, show_data, init_and_make_win)
8528         (show_source_or_disasm_and_command): Update.
8529         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8530         (tui_redisplay_readline, tui_mld_flush)
8531         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8532         (tui_getc): Update.
8533         * tui/tui-disasm.c (tui_set_disassem_content)
8534         (tui_disasm_window::do_scroll_vertical): Update.
8535         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8536         Now virtual.
8537         (struct tui_win_info): Derive from tui_gen_win_info.
8538         <~tui_win_info>: Mark as override.
8539         <generic>: Remove member.
8540         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8541         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8542         (~tui_data_window, ~tui_win_info)
8543         (tui_free_all_source_wins_content): Update.
8544         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8545
8546 2019-06-25  Tom Tromey  <tom@tromey.com>
8547
8548         * tui/tui-layout.c (init_and_make_win): Use new.
8549         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8550         destructor, initializers.
8551         (tui_alloc_generic_win_info): Don't declare.
8552         * tui/tui-data.c (_locator): Add argument to constructor.
8553         (source_win, disasm_win): New globals.
8554         (exec_info): Remove.
8555         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8556         Update.
8557         (tui_alloc_generic_win_info): Remove.
8558         (init_content_element): Use new.
8559         (tui_win_info::tui_win_info): Update.
8560         (free_content_elements) <case DATA_WIN>: Use delete.
8561
8562 2019-06-25  Tom Tromey  <tom@tromey.com>
8563
8564         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8565         * tui/tui-windata.c (tui_first_data_item_displayed)
8566         (tui_delete_data_content_windows): Update.
8567         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8568         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8569         (tui_display_registers_from, tui_check_register_values): Update.
8570         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8571         pointer.
8572         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8573         window.
8574         (tui_free_data_content): Update.
8575         (free_content_elements) <case DATA_WIN>: Free the window.
8576
8577 2019-06-25  Tom Tromey  <tom@tromey.com>
8578
8579         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8580         Update.
8581         * tui/tui-layout.c (make_command_window)
8582         (show_source_disasm_command, show_data, init_and_make_win)
8583         (show_source_or_disasm_and_command): Update.
8584         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8585         method.
8586         <can_highight, is_highlighted>: Now bool.
8587         (tui_set_win_highlight): Don't declare.
8588         * tui/tui-data.c (tui_set_win_highlight): Remove.
8589
8590 2019-06-25  Tom Tromey  <tom@tromey.com>
8591
8592         * tui/tui-wingeneral.c (make_visible): Remove check of window
8593         type.
8594
8595 2019-06-25  Tom Tromey  <tom@tromey.com>
8596
8597         * tui/tui-win.c (tui_win_info::max_height)
8598         (tui_cmd_window::max_height): New methods.
8599         (new_height_ok): Call max_height.
8600         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8601         <max_height>: New method.
8602
8603 2019-06-25  Tom Tromey  <tom@tromey.com>
8604
8605         * tui/tui-win.c (tui_source_window_base::set_new_height)
8606         (tui_data_window::set_new_height): New methods.
8607         (make_invisible_and_set_new_height): Call set_new_height method.
8608         * tui/tui-data.h (struct tui_win_info)
8609         (struct tui_source_window_base, struct tui_data_window)
8610         <set_new_height>: New method.
8611
8612 2019-06-25  Tom Tromey  <tom@tromey.com>
8613
8614         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8615         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8616         tui_refresh_data_win.
8617         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8618         method.
8619         (tui_refresh_all_win): Call the refresh_all method.
8620         (tui_set_focus): Likewise.
8621         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8622         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8623         Likewise.
8624
8625 2019-06-25  Tom Tromey  <tom@tromey.com>
8626
8627         * tui/tui-winsource.h (tui_refill_source_window)
8628         (tui_set_is_exec_point_at): Don't declare.
8629         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8630         (tui_source_window_base::refill): Rename from
8631         tui_refill_source_window.
8632         (tui_source_window_base::do_scroll_horizontal): Update.
8633         (tui_source_window_base::set_is_exec_point_at): Rename from
8634         tui_set_is_exec_point_at.
8635         (tui_update_all_breakpoint_info): Update.
8636         * tui/tui-stack.c (tui_show_frame_info): Update.
8637         * tui/tui-layout.c (show_data): Add cast.
8638         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8639         * tui/tui-data.h (struct tui_source_window_base) <refill,
8640         set_is_exec_point_at>: New methods.
8641         (tui_source_windows, tui_add_to_source_windows): Update types.
8642         (tui_add_to_source_windows): Remove redundant declaration.
8643         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8644         (tui_source_windows): Change return type.
8645         (tui_clear_source_windows_detail): Update.
8646         (tui_add_to_source_windows): Change type of parameter.
8647         (tui_free_all_source_wins_content): Update.
8648
8649 2019-06-25  Tom Tromey  <tom@tromey.com>
8650
8651         * tui/tui-wingeneral.c (tui_win_info::refresh)
8652         (tui_source_window_base::refresh): New methods.
8653         (tui_refresh_all): Call the refresh method.
8654         * tui/tui-data.h (struct tui_win_info)
8655         (struct tui_source_window_base) <refresh>: New method.
8656
8657 2019-06-25  Tom Tromey  <tom@tromey.com>
8658
8659         * tui/tui.h (tui_is_window_visible): Return bool.
8660         * tui/tui.c (tui_is_window_visible): Return bool.
8661         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8662         (tui_make_visible, tui_make_invisible)
8663         (tui_win_info::make_visible)
8664         (tui_source_window_base::make_visible, make_all_visible)
8665         (tui_make_all_visible, tui_make_all_invisible): Update.
8666         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8667         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8668         bool.
8669         (struct tui_win_info, struct tui_source_window_base)
8670         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8671         * tui/tui-data.c (tui_init_generic_part): Update.
8672
8673 2019-06-25  Tom Tromey  <tom@tromey.com>
8674
8675         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8676         (tui_source_window_base::make_visible): New methods.
8677         (make_all_visible): Make method call.
8678         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8679         (struct tui_source_window_base, struct tui_cmd_window): Override
8680         make_visible.
8681         (tui_win_is_source_type): Don't declare.
8682         * tui/tui-data.c (tui_win_is_source_type): Remove.
8683
8684 2019-06-25  Tom Tromey  <tom@tromey.com>
8685
8686         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8687         NULL check.
8688
8689 2019-06-25  Tom Tromey  <tom@tromey.com>
8690
8691         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8692         Inline constructor.  Add initializers for members.
8693         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8694         constructors; now inline in class.
8695
8696 2019-06-25  Tom Tromey  <tom@tromey.com>
8697
8698         * tui/tui-regs.c (tui_show_registers): Update.
8699         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8700         bool.
8701         * tui/tui-data.c (tui_data_window::clear_detail)
8702         (tui_data_window): Update.
8703
8704 2019-06-25  Tom Tromey  <tom@tromey.com>
8705
8706         * tui/tui-windata.c (tui_display_all_data)
8707         (tui_display_data_from_line, tui_display_data_from)
8708         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8709         Update.
8710         * tui/tui-regs.c (tui_last_regs_line_no)
8711         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8712         (tui_show_registers, tui_show_register_group)
8713         (tui_display_registers_from, tui_display_reg_element_at_line)
8714         (tui_display_registers_from_line, tui_check_register_values)
8715         (tui_reg_next, tui_reg_prev): Update.
8716         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8717         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8718         tui_data_window.
8719         (struct tui_win_info) <detail>: Remove.  Add new fields from
8720         tui_data_info.
8721         (TUI_DATA_WIN): Add cast.
8722         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8723         (~tui_data_window): Simplify.
8724
8725 2019-06-25  Tom Tromey  <tom@tromey.com>
8726
8727         * tui/tui-layout.c (show_source_disasm_command)
8728         (show_source_or_disasm_and_command): Update.
8729         * tui/tui-io.c (update_cmdwin_start_line)
8730         (tui_redisplay_readline): Update.
8731         * tui/tui-data.h (struct tui_command_info): Remove.
8732         (struct tui_win_info) <detail>: Remove command_info member.
8733         (struct tui_data_window) <start_line>: New member, from
8734         tui_command_info.
8735         (TUI_CMD_WIN): Add casts.
8736
8737 2019-06-25  Tom Tromey  <tom@tromey.com>
8738
8739         * tui/tui-winsource.c (tui_update_source_window)
8740         (tui_refill_source_window)
8741         (tui_source_window_base::do_scroll_horizontal)
8742         (tui_update_breakpoint_info, tui_set_exec_info_content)
8743         (tui_show_exec_info_content, tui_erase_exec_info_content)
8744         (tui_clear_exec_info_content): Update.
8745         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8746         Update.
8747         * tui/tui-win.c (make_invisible_and_set_new_height)
8748         (make_visible_with_new_height): Update.
8749         * tui/tui-source.c (tui_set_source_content)
8750         (tui_show_symtab_source): Update.
8751         * tui/tui-layout.c (extract_display_start_addr)
8752         (show_source_disasm_command, show_data)
8753         (make_source_or_disasm_window)
8754         (show_source_or_disasm_and_command): Update.
8755         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8756         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8757         "gdbarch".
8758         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8759         to tui_source_window_base.
8760         (struct tui_win_info) <detail>: Remove source_info member.
8761         (struct tui_source_window_base) <has_locator>: Inline.
8762         Move contents from tui_source_info; rename has_locator member to
8763         m_has_locator.
8764         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8765         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8766         header file.
8767         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8768         Simplify.
8769         (tui_free_all_source_wins_content): Cast to
8770         tui_source_window_base.
8771
8772 2019-06-25  Tom Tromey  <tom@tromey.com>
8773
8774         * tui/tui-win.c (make_invisible_and_set_new_height)
8775         (make_visible_with_new_height): Call has_locator method.
8776         * tui/tui-layout.c (show_source_disasm_command, show_data)
8777         (show_source_or_disasm_and_command): Update for bool change.
8778         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8779         (tui_win_info) <has_locator>: New method.
8780         (struct tui_source_window_base) <has_locator>: New method.
8781         (tui_win_has_locator): Don't declare.
8782         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8783         from tui_win_has_locator.
8784         (tui_source_window_base): Use false, not FALSE.
8785
8786 2019-06-25  Tom Tromey  <tom@tromey.com>
8787
8788         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8789         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8790         clear_detail method directly.
8791         (tui_clear_win_detail): Remove.
8792
8793 2019-06-25  Tom Tromey  <tom@tromey.com>
8794
8795         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8796         "this", not TUI_DISASM_WIN.
8797
8798 2019-06-25  Tom Tromey  <tom@tromey.com>
8799
8800         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8801         declare.
8802         * tui/tui-winsource.c
8803         (tui_source_window_base::do_scroll_horizontal): Rename from
8804         tui_horizontal_source_scroll.
8805         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8806         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8807         from tui_vertical_data_scroll.
8808         * tui/tui-win.h (tui_scroll): Don't declare.
8809         * tui/tui-win.c (tui_win_info::forward_scroll)
8810         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8811         (tui_win_info::right_scroll): Rename and update.
8812         (tui_scroll_forward_command, tui_scroll_backward_command)
8813         (tui_scroll_left_command, tui_scroll_right_command): Update.
8814         (tui_scroll): Remove.
8815         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8816         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8817         from tui_vertical_source_scroll.
8818         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8819         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8820         from tui_vertical_disassem_scroll.
8821         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8822         do_scroll_horizontal>: New methods.
8823         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8824         Likewise.
8825         (struct tui_source_window_base): Add do_scroll_horizontal.
8826         (struct tui_source_window, struct tui_disasm_window): Add
8827         do_scroll_vertical.
8828         (struct tui_data_window, struct tui_cmd_window): Add
8829         do_scroll_horizontal and do_scroll_vertical.
8830         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8831
8832 2019-06-25  Tom Tromey  <tom@tromey.com>
8833
8834         * tui/tui-data.h (struct tui_source_window_base): New struct.
8835         (struct tui_source_window): Derive from tui_source_window_base.
8836         (struct tui_disasm_window): New struct.
8837         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8838         from tui_source_window::clear_detail.
8839         (tui_source_window_base): Rename from tui_source_window.
8840         (~tui_source_window_base): Rename from ~tui_source_window.
8841         (tui_alloc_win_info): Create a tui_disasm_window.
8842
8843 2019-06-25  Tom Tromey  <tom@tromey.com>
8844
8845         * tui/tui-data.h (struct tui_source_window)
8846         (struct tui_data_window): Declare destructors.
8847         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8848         destructors.
8849         (tui_win_info): Simplify.
8850
8851 2019-06-25  Tom Tromey  <tom@tromey.com>
8852
8853         * tui/tui-winsource.c (tui_display_main)
8854         (tui_update_source_windows_with_addr)
8855         (tui_update_all_breakpoint_info): Update.
8856         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8857         (new_height_ok, parse_scrolling_args): Update.
8858         * tui/tui-stack.c (tui_show_frame_info): Update.
8859         * tui/tui-data.h (struct tui_list): Remove.
8860         (tui_source_windows): Return a reference to a std::vector.
8861         * tui/tui-data.c (source_windows): Now a std::vector.
8862         (tui_source_windows): Change return type.
8863         (tui_clear_source_windows): Rewrite.
8864         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8865         (tui_free_all_source_wins_content): Rewrite.
8866
8867 2019-06-25  Tom Tromey  <tom@tromey.com>
8868
8869         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8870         (struct tui_data_window, struct tui_cmd_window): Declare
8871         clear_detail method.
8872         * tui/tui-data.c (tui_source_window::clear_detail)
8873         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8874         methods.
8875         (tui_clear_win_detail): Simplify.
8876
8877 2019-06-25  Tom Tromey  <tom@tromey.com>
8878
8879         * tui/tui-layout.c (make_source_window, make_disasm_window)
8880         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8881         Return the new window.
8882         (show_source_disasm_command, show_data)
8883         (show_source_or_disasm_and_command): Update.
8884
8885 2019-06-25  Tom Tromey  <tom@tromey.com>
8886
8887         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8888         parameter.  Return the new window.
8889         (show_source_disasm_command): Update and remove NULL check.
8890         (show_source_or_disasm_and_command): Update.
8891
8892 2019-06-25  Tom Tromey  <tom@tromey.com>
8893
8894         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8895
8896 2019-06-25  Tom Tromey  <tom@tromey.com>
8897
8898         * tui/tui-data.h (struct tui_win_info): Make constructor
8899         protected.  Make destructor virtual.  Add initializers.
8900         (tui_source_window, tui_data_window, tui_cmd_window): New
8901         classes.
8902         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8903         constructor.  Add "type" parameter.
8904         (tui_source_window, tui_data_window, tui_cmd_window): New
8905         constructors.
8906         (tui_alloc_win_info): Instantiate the appropriate subclass.
8907
8908 2019-06-25  Tom Tromey  <tom@tromey.com>
8909
8910         * tui/tui-win.c (tui_resize_all): Use delete.
8911         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8912         destructor.
8913         (tui_free_window): Don't declare.
8914         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8915         Update.
8916
8917 2019-06-25  Tom Tromey  <tom@tromey.com>
8918
8919         * tui/tui-data.h (struct tui_win_info): Add constructor.
8920         * tui/tui-data.c (tui_alloc_win_info): Use new.
8921         (tui_free_window): Use delete.
8922
8923 2019-06-22  Tom Tromey  <tom@tromey.com>
8924
8925         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8926         declare.
8927         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8928
8929 2019-06-22  Tom Tromey  <tom@tromey.com>
8930
8931         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8932         declare.
8933         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8934
8935 2019-06-22  Tom de Vries  <tdevries@suse.de>
8936
8937         * dwarf2read.c (create_addrmap_from_aranges)
8938         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8939         instead of '%zu'.
8940
8941 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8942
8943         * dwarf2read.h (dwarf2_section_info_def): Remove.
8944         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8945         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8946         std::vector<dwarf2_section_info>.
8947         (struct dwo_file) <~dwo_file>: Remove.
8948         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8949         types field.
8950         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8951         (dwarf2_read_debug_names): Likewise.
8952         (create_debug_types_hash_table): Change parameter type to
8953         array_view, adjust code accordingly.
8954         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8955         (partial_die_info::fixup): Likewise.
8956         (determine_prefix): Likewise.
8957         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8958
8959 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8960
8961         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8962         gdb_bfd_ref_ptr.
8963         <~dwo_file>: Remove call to gdb_bfd_unref.
8964         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8965         gdb_bfd_ref_ptr::get.
8966
8967 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8968
8969         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8970         type to htab_up.
8971         * dwarf2read.c (struct dwo_file): Initialize fields.
8972         <~dwo_file>: New.
8973         (free_dwo_file): Remove, move content to ~dwo_file.
8974         (struct dwo_file_deleter): Remove.
8975         (dwo_file_up>: Remove custom deleter.
8976         (free_dwo_files): Remove.
8977         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8978         dwo_files.
8979         (process_skeletonless_type_units): Call unique_ptr::get.
8980         (allocate_dwo_file_hash_table): Add deleter to created hash
8981         table.  Change return type to htab_up.
8982         (lookup_dwo_file_slot): Don't memset dwo_file, call
8983         unique_ptr::get.
8984         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8985         (create_dwo_unit_in_dwp_v2): Likewise.
8986         (open_and_init_dwo_file): Likewise.
8987         (free_dwo_file_from_slot): Remove.
8988
8989 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8990
8991         * dwarf2read.h (struct dwarf2_section_info) <readin,
8992         is_virtual>: Change type to bool.
8993         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8994         true instead of 1.
8995
8996 2019-06-19  Tom Tromey  <tom@tromey.com>
8997
8998         * tui/tui-data.h (tui_init_content_element): Don't declare.
8999
9000 2019-06-19  Tom Tromey  <tom@tromey.com>
9001
9002         * tui/tui-data.h (tui_init_win_info): Don't declare.
9003
9004 2019-06-19  Tom de Vries  <tdevries@suse.de>
9005
9006         * dwarf2read.h (abstract_to_concrete): Change type to
9007         std::unordered_map<sect_offset, std::vector<sect_offset>,
9008         gdb::hash_enum<sect_offset>>.
9009
9010 2019-06-19  Tom Tromey  <tromey@adacore.com>
9011
9012         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9013         EVAL_AVOID_SIDE_EFFECTS specially.
9014
9015 2019-06-19  Tom Tromey  <tromey@adacore.com>
9016
9017         * source-cache.c (highlighter): New global.
9018         (source_cache::get_source_lines): Create a highlighter on demand.
9019
9020 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9021
9022         * defs.h (deprecated_interactive_hook): Delete declaration.
9023         * interps.c (clear_interpreter_hooks): Remove use of
9024         deprecated_interactive_hook.
9025         * top.c (deprecated_interactive_hook): Delete definition.
9026         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9027
9028 2019-06-18  Tom de Vries  <tdevries@suse.de>
9029
9030         PR gdb/24515
9031         * dwarf2read.h (abstract_to_concrete): Change type from
9032         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9033         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9034         * dwarf2read.c (read_variable): Update.
9035         (dwarf2_fetch_die_loc_sect_off): Update.
9036
9037 2019-06-17  Tom de Vries  <tdevries@suse.de>
9038
9039         PR gdb/24617
9040         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9041         accessing parent[parent_len - 1].
9042
9043 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9044
9045         PR gdb/24364
9046         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9047         call dtrace_process_dof with NULL dof.
9048
9049 2019-06-16  Tom de Vries  <tdevries@suse.de>
9050
9051         PR gdb/24445
9052         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9053
9054 2019-06-16  Tom Tromey  <tom@tromey.com>
9055
9056         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9057         (make_all_visible): Use address of member.
9058
9059 2019-06-16  Tom Tromey  <tom@tromey.com>
9060
9061         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9062         (tui_free_window, free_content, free_content_elements): Remove
9063         unnecessary cast.
9064         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9065         cast.
9066         * tui/tui-regs.c (tui_show_register_group)
9067         (tui_display_registers_from, tui_display_reg_element_at_line):
9068         Remove unnecessary cast.
9069
9070 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9071
9072         * linux-nat.c (normal_mask): Delete.
9073         (_initialize_linux_nat): Don't initialise normal_mask.
9074
9075 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9076
9077         PR gdb/24445
9078         * dwarf-index-write.h (write_psymtabs_to_index): Add
9079         dwz_basename parameter.
9080         * dwarf-index-write.c (write_gdbindex): Move file writing to
9081         write_gdbindex_1.  Change return type void.
9082         (assert_file_size): Move up, remove filename parameter.
9083         (write_gdbindex_1): New function.
9084         (write_debug_names): Change return type to void, call
9085         assert_file_size.
9086         (struct index_wip_file): New struct.
9087         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9088         file logic to index_wip_file.  Write index for dwz file if
9089         needed.
9090         (save_gdb_index_command): Pass basename of dwz file, if present.
9091         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9092         build-id of dwz file, if present.
9093         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9094         (dwarf2_get_dwz_file): Likewise.
9095         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9096         (dwarf2_get_dwz_file): Likewise.
9097
9098 2019-06-16  Tom Tromey  <tom@tromey.com>
9099
9100         * coffread.c (process_coff_symbol): Use xstrdup.
9101         * value.c (create_internalvar): Use xstrdup.
9102
9103 2019-06-16  Tom Tromey  <tom@tromey.com>
9104
9105         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9106         * breakpoint.c (stopin_command, stopat_command)
9107         (until_break_command, decode_location_default): Remove unnecessary
9108         cast.
9109         * utils.c (subset_compare): Remove unnecessary cast.
9110         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9111         cast.
9112         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9113         cast.
9114         * infcmd.c (path_command): Remove unnecessary cast.
9115         * coffread.c (decode_type): Remove unnecessary cast.
9116         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9117         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9118         * tui/tui-stack.c (tui_show_locator_content)
9119         (tui_show_frame_info): Remove unnecessary cast.
9120         * tui/tui-win.c (tui_scroll_forward_command)
9121         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9122         (parse_scrolling_args): Remove unnecessary cast.
9123         * tui/tui-data.c (init_win_info, tui_del_window)
9124         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9125         (free_content_elements): Remove unnecessary cast.
9126         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9127         unnecessary cast.
9128         * tui/tui-source.c (tui_set_source_content)
9129         (tui_vertical_source_scroll): Remove unnecessary cast.
9130         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9131         cast.
9132         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9133         * tui/tui-regs.c (tui_display_registers_from)
9134         (tui_display_register): Remove unnecessary cast.
9135         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9136         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9137         (make_visible): Remove unnecessary cast.
9138         * tui/tui-winsource.c (tui_erase_source_content)
9139         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9140         unnecessary cast.
9141         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9142         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9143         * stabsread.c (read_type, read_array_type, read_range_type):
9144         Remove unnecessary cast.
9145         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9146         (parse_symbol, parse_type, upgrade_type, parse_external)
9147         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9148         unnecessary cast.
9149         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9150
9151 2019-06-16  Tom Tromey  <tom@tromey.com>
9152
9153         * tui/tui-data.c (tui_alloc_generic_win_info)
9154         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9155         checks.
9156
9157 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9158             Andrew Burgess  <andrew.burgess@embecosm.com>
9159
9160         * f-typeprint.c (f_print_type): Don't return early for not
9161         associated or not allocated types.
9162         (f_type_print_varspec_suffix): Add print_rank parameter and print
9163         ranks of array types in case they dangling.
9164         (f_type_print_base): Add print_rank parameter.
9165
9166 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9167
9168         * NEWS: Mention new MI commands.
9169         * break-catch-throw.c (enum exception_event_kind): Move to
9170         breakpoint.h.
9171         (print_mention_exception_catchpoint): Output text as a single
9172         message.
9173         (catch_exception_command_1): Rename to...
9174         (catch_exception_event): ...this, make non-static, update header
9175         command, and change some parameter types.
9176         (catch_catch_command): Update for changes to
9177         catch_exception_command_1.
9178         (catch_throw_command): Likewise.
9179         (catch_rethrow_command): Likewise.
9180         * breakpoint.c (enum exception_event_kind): Delete.
9181         * breakpoint.h (enum exception_event_kind): Moved here from
9182         break-catch-throw.c.
9183         (catch_exception_event): Declare.
9184         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9185         (mi_cmd_catch_throw): New function.
9186         (mi_cmd_catch_rethrow): New function.
9187         (mi_cmd_catch_catch): New function.
9188         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9189         'catch-catch' entries.
9190         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9191         (mi_cmd_catch_rethrow): Declare.
9192         (mi_cmd_catch_catch): Declare.
9193
9194 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9195
9196         * annotate.c (annotate_source_line): Change return type to void,
9197         update implementation to match.
9198         * annotate.h (annotate_source_line): Change return type to void,
9199         update header comment.
9200         * stack.c (print_frame_info): Don't change what frame information
9201         is printed based on whether annotations are on or not.
9202
9203 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9204
9205         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9206         (annotate_source): Make static.
9207         (annotate_source_line): Moved from source.c and renamed from
9208         identify_source_line.  Update the return type.
9209         * annotate.h (annotate_source): Delete declaration.
9210         (annotate_source_line): Declaration moved from source.h, and
9211         renamed from identify_source_line.  Return type updated.
9212         * source.c (identify_source_line): Moved to annotate.c and renamed
9213         to annotate_source_line.
9214         (info_line_command): Remove check of annotation_level.
9215         * source.h (identify_source_line): Move declaration to annotate.h
9216         and rename to annotate_source_line.
9217         * stack.c: Add 'annotate.h' include.
9218         (print_frame_info): Remove check of annotation_level before
9219         calling annotate_source_line.
9220
9221 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9222
9223         * source-cache.c (source_cache::get_plain_source_lines): Use
9224         open_source_file_with_line_charpos instead of just
9225         open_source_file, remove call to find_source_lines.
9226         (source_cache::get_source_lines): Likewise.
9227         * source.c (find_source_lines): Make static.
9228         (get_filename_and_charpos): Renamed into...
9229         (open_source_file_with_line_charpos): ..this along with changes to
9230         return a scoped_fd, and some other minor clean ups.
9231         (identify_source_line): Use open_source_file_with_line_charpos.
9232         (search_command_helper): Use open_source_file_with_line_charpos
9233         instead of just open_source_file, remove call to
9234         find_source_lines.
9235         * source.h (open_source_file_with_line_charpos): Declare new
9236         function.
9237         (find_source_lines): Delete declaration.
9238
9239 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9240
9241         * source.c (get_filename_and_charpos): Remove fullname
9242         parameter.
9243         (identify_source_line): Update call to get_filename_and_charpos.
9244
9245 2019-06-14  Tom Tromey  <tromey@adacore.com>
9246
9247         PR gdb/24502:
9248         * ui-style.h (skip_ansi_escape): Update comment.
9249         * ui-file.h (class no_terminal_escape_file): New class.
9250         * ui-file.c (no_terminal_escape_file::write)
9251         (no_terminal_escape_file::puts): New methods.
9252         * cli/cli-logging.c (handle_redirections): Use
9253         no_terminal_escape_file.
9254
9255 2019-06-14  Tom Tromey  <tromey@adacore.com>
9256
9257         * NEWS: Move convenience variable news above Python news.
9258
9259 2019-06-14  Tom Tromey  <tom@tromey.com>
9260
9261         * gnulib: Move directory to top-level.
9262         * configure.ac: Don't configure gnulib.
9263         * configure: Rebuild.
9264         * common/common-defs.h: Use new path to gnulib.
9265         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9266         (GNULIB_H): Remove.
9267         (INCGNU): Look in new gnulib location.
9268         (HFILES_NO_SRCDIR): Remove gnulib files.
9269         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9270         (generated_files): Remove GNULIB_H.
9271         ($(LIBGNU), all-lib): Remove targets.
9272         (distclean): Don't mention GNULIB_BUILDDIR.
9273         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9274
9275 2019-06-14  Tom Tromey  <tromey@adacore.com>
9276
9277         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9278         Warn if symbol file does not provide any symbols.
9279
9280 2019-06-14  Tom Tromey  <tromey@adacore.com>
9281
9282         * source.c (find_and_open_source): Respect basenames_may_differ.
9283
9284 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9285
9286         * annotate.c (annotate_breakpoints_invalid): Make use of
9287         scoped_restore_terminal_state.
9288         (annotate_frames_invalid): Likewise.
9289
9290 2019-06-14  Tom Tromey  <tromey@adacore.com>
9291
9292         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9293         allow assignment to an internalvar.
9294
9295 2019-06-14  Tom Tromey  <tromey@adacore.com>
9296
9297         * ada-lex.l: Allow "_" in attribute names.
9298
9299 2019-06-14  Tom Tromey  <tromey@adacore.com>
9300
9301         PR gdb/24653:
9302         * regcache.c (registers_changed): Don't call alloca.
9303         * top.c (execute_command): Don't call alloca.
9304
9305 2019-06-13  Pedro Alves  <palves@redhat.com>
9306
9307         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9308         'expression'.  When parsing an expression, error out if there's
9309         junk after "unlimited".
9310         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9311         (do_set_command): Adjust calls to is_unlimited_literal.
9312
9313 2019-06-13  Pedro Alves  <palves@redhat.com>
9314
9315         * compile/compile.c (make_compile_options_def_group): Add braces
9316         around array_view initializer.
9317         * thread.c (make_thread_apply_all_options_def_group)
9318         (make_thread_apply_all_options_def_group): Likewise.
9319
9320 2019-06-13  Pedro Alves  <palves@redhat.com>
9321
9322         * NEWS (New commands): Mention "maint test-options
9323         require-delimiter", "maint test-options unknown-is-error", "maint
9324         test-options unknown-is-operand" and "maint show
9325         test-options-completion-result".
9326         (New command options, command completion): New section.
9327         (Completion improvements): New section.
9328         Mention that you can abbreviate "unlimited".
9329
9330 2019-06-13  Pedro Alves  <palves@redhat.com>
9331
9332         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9333         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9334         * unittests/cli-utils-selftests.c (test_parse_flags)
9335         (test_parse_flags_qcs): Delete.
9336         (test_cli_utils): Don't call deleted functions.
9337
9338 2019-06-13  Pedro Alves  <palves@redhat.com>
9339
9340         * thread.c: Include "cli/cli-option.h".
9341         (tp_array_compar_ascending): Global.
9342         (tp_array_compar): Delete function.
9343         (tp_array_compar_ascending, tp_array_compar_descending): New
9344         functions.
9345         (ascending_option_def, qcs_flag_option_def)
9346         (thr_qcs_flags_option_defs)
9347         (make_thread_apply_all_options_def_group)
9348         (make_thread_apply_options_def_group): New.
9349         (thread_apply_all_command): Use gdb::option::process_options.
9350         (thread_apply_command_completer)
9351         (thread_apply_all_command_completer): New.
9352         (thread_apply_command): Use gdb::option::process_options.
9353         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9354         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9355         to generate help text of "thread apply".  Adjust "taas"'s help.
9356         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9357         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9358
9359 2019-06-13  Pedro Alves  <palves@redhat.com>
9360
9361         * thread.c (thread_apply_command): Check for invalid TID with
9362         isdigit instead of !isalpha.
9363
9364 2019-06-13  Pedro Alves  <palves@redhat.com>
9365
9366         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9367         (validate_flags_qcs): New.
9368         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9369         (validate_flags_qcs): Declare.
9370         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9371         (make_frame_apply_options_def_group): New.
9372         (frame_apply_command_count): Process options with
9373         gdb::option::process_options.
9374         (frame_apply_completer): New.
9375         (frame_apply_level_completer, frame_apply_all_completer)
9376         (frame_apply_completer): New.
9377         (_initialize_stack): Update help of "frame apply", "frame apply
9378         level", "frame apply all" and "faas" to mention supported options
9379         and install command completers.
9380         * stack.h (frame_apply_all_completer): Declare.
9381         * thread.c: Include "stack.h".
9382         (tfaas_command): Add "--".
9383         (_initialize_thread): Update help "tfaas" to mention supported
9384         options and install command completer.
9385
9386 2019-06-13  Pedro Alves  <palves@redhat.com>
9387
9388         * completer.c (complete_nested_command_line): New.
9389         (gdb_completion_word_break_characters_throw): Add assertion.
9390         * completer.h (complete_nested_command_line): Declare.
9391
9392 2019-06-13  Pedro Alves  <palves@redhat.com>
9393
9394         * stack.c (parse_backtrace_qualifiers): New.
9395         (backtrace_command): Use it.
9396         (backtrace_command_completer): Complete on qualifiers.
9397
9398 2019-06-13  Pedro Alves  <palves@redhat.com>
9399
9400         * frame.c: Include "cli/cli-option.h.
9401         (user_set_backtrace_options): New.
9402         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9403         Delete.
9404         (get_prev_frame): Adjust.
9405         (boolean_option_def, uinteger_option_def)
9406         (set_backtrace_option_defs): New.
9407         (_initialize_frame): Adjust and use
9408         gdb::option::add_setshow_cmds_for_options to install "set
9409         backtrace past-main" and "set backtrace past-entry".
9410         * frame.h: Include "cli/cli-option.h".
9411         (struct frame_print_options): Forward declare.
9412         (print_frame_arguments_all, print_frame_arguments_scalars)
9413         (print_frame_arguments_none): Declare.
9414         (print_entry_values): Delete declaration.
9415         (struct frame_print_options, user_frame_print_options): New.
9416         (struct set_backtrace_options): New.
9417         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9418         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9419         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9420         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9421         (list_args_or_locals): Add frame_print_options parameter.
9422         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9423         * python/py-framefilter.c (enumerate_args): Pass down
9424         USER_FRAME_PRINT_OPTIONS.
9425         * stack.c: Include "cli/cli-option.h".
9426         (print_frame_arguments_all, print_frame_arguments_scalars)
9427         (print_frame_arguments_none): Declare.
9428         (print_raw_frame_arguments, print_entry_values): Delete.
9429         (user_frame_print_options): New.
9430         (boolean_option_def, enum_option_def, frame_print_option_defs):
9431         New.
9432         (struct backtrace_cmd_options): New.
9433         (bt_flag_option_def): New.
9434         (backtrace_command_option_defs): New.
9435         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9436         (print_frame_arg, read_frame_arg, print_frame_args)
9437         (print_frame_info, print_frame): Add frame_print_options parameter
9438         and use it.
9439         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9440         (backtrace_command_1): Add frame_print_options and
9441         backtrace_cmd_options parameters and use them.
9442         (make_backtrace_options_def_group): New.
9443         (backtrace_command): Process command options with
9444         gdb::option::process_options.
9445         (backtrace_command_completer): New.
9446         (_initialize_stack): Extend "backtrace"'s help to mention
9447         supported options.  Install completer for "backtrace".
9448         Install some settings commands with add_setshow_cmds_for_options.
9449
9450 2019-06-13  Pedro Alves  <palves@redhat.com>
9451
9452         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9453         and that "set/show print raw frame-arguments" are now deprecated.
9454
9455         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9456         command.
9457         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9458         * stack.c (_initialize_stack): Install "set/show print
9459         raw-frame-arguments", and deprecate "set/show print raw
9460         frame-arguments".
9461         * valprint.c (_initialize_valprint): Deprecate "set/show print
9462         raw".
9463
9464 2019-06-13  Pedro Alves  <palves@redhat.com>
9465
9466         * compile/compile.c (struct compile_options): New.
9467         (compile_flag_option_def, compile_command_option_defs)
9468         (make_compile_options_def_group): New.
9469         (compile_file_command): Handle options with
9470         gdb::option::process_options.
9471         (compile_file_command_completer): New function.
9472         (compile_code_command): Handle options with
9473         gdb::option::process_options.
9474         (compile_code_command_completer): New function.
9475         (_initialize_compiler): Install completers for "compile code" and
9476         "compile file".  Mention available options in "compile code" and
9477         "compile code"'s help.
9478         * completer.c (advance_to_completion_word): New, factored out from
9479         ...
9480         (advance_to_expression_complete_word_point): ... this.
9481         (advance_to_filename_complete_word_point): New.
9482         * completer.h (advance_to_filename_complete_word_point): New
9483         declaration.
9484
9485 2019-06-13  Pedro Alves  <palves@redhat.com>
9486
9487         * compile/compile.c: Include "cli/cli-option.h".
9488         (compile_print_value): Scope data pointer is now a
9489         value_print_options pointer; adjust.
9490         (compile_print_command): Process options.  Scope data pointer is
9491         now a value_print_options pointer; adjust.
9492         (_initialize_compile): Update "compile print"'s help to include
9493         supported options.  Install a completer for "compile print".
9494         * cp-valprint.c (show_vtblprint, show_objectprint)
9495         (show_static_field_print): Delete.
9496         (_initialize_cp_valprint): Don't install "set print
9497         static-members", "set print vtbl", "set print object" here.
9498         * printcmd.c: Include "cli/cli-option.h" and
9499         "common/gdb_optional.h".
9500         (print_command_parse_format): Rework to fill in a
9501         value_print_options instead of a format_data.
9502         (print_value): Change parameter type from format_data pointer to
9503         value_print_options reference.  Adjust.
9504         (print_command_1): Process options.  Adjust to pass down a
9505         value_print_options.
9506         (print_command_completer): New.
9507         (_initialize_printcmd): Install print_command_completer as
9508         handle_brkchars completer for the "print" command.  Update
9509         "print"'s help to include supported options.
9510         * valprint.c: Include "cli/cli-option.h".
9511         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9512         here from cp-valprint.c.
9513         (boolean_option_def, uinteger_option_def)
9514         (value_print_option_defs, make_value_print_options_def_group):
9515         New.  Use gdb::option::add_setshow_cmds_for_options to install
9516         "set print elements", "set print null-stop", "set print repeats",
9517         "set print pretty", "set print union", "set print array", "set
9518         print address", "set print symbol", "set print array-indexes".
9519         * valprint.h: Include <string> and "cli/cli-option.h".
9520         (make_value_print_options_def_group): Declare.
9521         (print_value): Change parameter type from format_data pointer to
9522         value_print_options reference.
9523         (print_command_completer): Declare.
9524
9525 2019-06-13  Pedro Alves  <palves@redhat.com>
9526
9527         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9528         (COMMON_SFILES): Add maint-test-settings.c.
9529         * cli/cli-decode.c (boolean_enums): New global, factored out from
9530         ...
9531         (add_setshow_boolean_cmd): ... here.
9532         * cli/cli-decode.h (boolean_enums): Declare.
9533         * cli/cli-option.c: New file.
9534         * cli/cli-option.h: New file.
9535         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9536         factored out from ...
9537         (parse_cli_boolean_value(const char *)): ... this.
9538         (is_unlimited_literal): Change parameter type to pointer to
9539         pointer.  Adjust and advance ARG pointer.
9540         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9541         (parse_cli_var_enum): New, factored out from ...
9542         (do_set_command): ... this.  Adjust.
9543         * cli/cli-setshow.h (parse_cli_boolean_value)
9544         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9545         (parse_cli_var_enum): Declare.
9546         * cli/cli-utils.c: Include "cli/cli-option.h".
9547         (get_ulongest): New.
9548         * cli/cli-utils.h (get_ulongest): Declare.
9549         (check_for_argument): New overloads.
9550         * maint-test-options.c: New file.
9551
9552 2019-06-13  Pedro Alves  <palves@redhat.com>
9553
9554         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9555         parse a range if "-" is at the end of the string.
9556
9557 2019-06-13  Pedro Alves  <palves@redhat.com>
9558
9559         * cli/cli-setshow.c (parse_auto_binary_operation)
9560         (parse_cli_boolean_value): Don't allow "o".
9561
9562 2019-06-13  Pedro Alves  <palves@redhat.com>
9563
9564         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9565         * NEWS: Mention maint test-settings KIND.
9566         * maint-test-settings.c: New file.
9567
9568 2019-06-13  Pedro Alves  <palves@redhat.com>
9569
9570         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9571         completer.
9572         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9573         "set" completers.
9574
9575 2019-06-13  Pedro Alves  <palves@redhat.com>
9576
9577         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9578         after item.
9579
9580 2019-06-13  Pedro Alves  <palves@redhat.com>
9581
9582         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9583
9584 2019-06-13  Pedro Alves <palves@redhat.com>
9585
9586         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9587         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9588         call.
9589         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9590         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9591         calls.
9592         (check_for_argument): Skip spaces after argument.
9593
9594 2019-06-13  Pedro Alves  <palves@redhat.com>
9595
9596         * thread.c (thread_apply_command): Adjust TID parsing.
9597         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9598         detected before end of string.
9599         (tid_is_in_list): Error out if LIST is invalid.
9600
9601 2019-06-13  Pedro Alves  <palves@redhat.com>
9602
9603         * completer.c (complete_line_internal_1): Rewind completion word
9604         point.
9605         (completion_tracker::advance_custom_word_point_by): Change
9606         parameter type to int.
9607         * completer.h (completion_tracker::advance_custom_word_point_by):
9608         Likewise.
9609
9610 2019-06-13  Pedro Alves  <palves@redhat.com>
9611
9612         * completer.c (advance_to_completion_word): Handle delimiters.
9613
9614 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9615
9616         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9617
9618 2019-06-11  Tom Tromey  <tom@tromey.com>
9619
9620         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9621         (xmalloc_failed): Move to alloc.c.
9622         * alloc.c: New file.
9623         * Makefile.in (COMMON_SFILES): Add alloc.c.
9624
9625 2019-06-11  Tom Tromey  <tom@tromey.com>
9626
9627         * nat/linux-waitpid.c: Don't include server.h.
9628         (linux_debug): Remove.
9629         (my_waitpid): Update.
9630
9631 2019-06-11  Tom Tromey  <tromey@adacore.com>
9632
9633         * infcall.c (_initialize_infcall): Remove trailing newline from
9634         help.
9635         * user-regs.c (_initialize_user_regs): Remove trailing newline
9636         from help.
9637         * typeprint.c (_initialize_typeprint): Remove trailing newline
9638         from help.
9639         * reverse.c (_initialize_reverse): Remove trailing newlines from
9640         help.
9641         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9642         from help.
9643         * language.c (add_set_language_command): Remove trailing newline
9644         from help.
9645         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9646         help.
9647         * disasm.c (_initialize_disasm): Remove trailing newline from
9648         help.
9649         * top.c (init_main): Remove trailing newline from help.
9650         * interps.c (_initialize_interpreter): Remove trailing newline
9651         from help.
9652         * btrace.c (_initialize_btrace): Remove trailing newlines from
9653         help.
9654         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9655         from help.
9656         * python/python.c (_initialize_python): Remove trailing newline
9657         from help.
9658         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9659         help.
9660         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9661         from help.  Reformat some text.
9662         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9663         from help.
9664         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9665         newline from help.
9666
9667 2019-06-11  Tom Tromey  <tromey@adacore.com>
9668
9669         * darwin-nat.c (darwin_decode_exception_message)
9670         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9671
9672 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9673
9674         * valops.c (value_slice): Check for not allocated or not
9675         associated values.
9676
9677 2019-06-10  Tom de Vries  <tdevries@suse.de>
9678
9679         PR gdb/24618
9680         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9681         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9682         invalid.
9683
9684 2019-06-10  Tom de Vries  <tdevries@suse.de>
9685
9686         PR gdb/24611
9687         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9688         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9689
9690 2019-06-10  Tom de Vries  <tdevries@suse.de>
9691
9692         PR symtab/24545
9693         * symtab.c (struct demangled_name_entry): Add language field.
9694         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9695         static minimal symbol".  Set and use language field.
9696
9697 2019-06-10  Tom Tromey  <tromey@adacore.com>
9698
9699         * ada-lang.c (_initialize_ada_language): Update help text.
9700
9701 2019-06-10  Tom Tromey  <tromey@adacore.com>
9702
9703         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9704         with a newline.
9705         * guile/guile.c (handle_boot_error): Don't end warning with a
9706         newline.
9707         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9708         warning with a newline.
9709         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9710         newline.
9711         (s12z_frame_cache): Likewise.
9712         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9713         a newline.
9714         * solib-svr4.c (disable_probes_interface): Don't end warning with
9715         a newline.
9716         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9717         newline.
9718         * python/python.c (do_finish_initialization): Don't end warning
9719         with a newline.
9720
9721 2019-06-10  Tom Tromey  <tom@tromey.com>
9722
9723         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9724         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9725         gdbpy_enter.
9726
9727 2019-06-10  Tom Tromey  <tromey@adacore.com>
9728
9729         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9730         data.
9731         (elf_new_init): Don't call stabsread_new_init.
9732         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9733         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9734         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9735
9736 2019-06-10  Tom de Vries  <tdevries@suse.de>
9737
9738         PR symtab/16264
9739         PR symtab/24517
9740         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9741
9742 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9743
9744         * source.c (find_and_open_source): Also rewrite relative file
9745         names.
9746
9747 2019-04-26  Amos Bird  <amosbird@gmail.com>
9748
9749         * annotate.c (annotate_thread_exited): Add "thread-exited"
9750         annotation.
9751
9752 2019-06-06  Tom Tromey  <tromey@adacore.com>
9753
9754         * maint.h (class scoped_command_stats): Use
9755         DISABLE_COPY_AND_ASSIGN.
9756         <print_time>: New method.
9757         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9758         print_time.
9759         (scoped_command_stats::print_time): New method.
9760
9761 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9762
9763         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9764         instructions of lengths 6 or 8 bytes.
9765
9766 2019-06-04  Pedro Alves  <palves@redhat.com>
9767
9768         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9769
9770         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9771         * breakpoint.c (condition_completer): Likewise.
9772         * cli/cli-dump.c (scan_expression): Likewise.
9773         * common/filestuff.c (mkdir_recursive): Likewise.
9774         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9775         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9776         (gdb_abspath): Likewise.
9777         * compile/compile-cplus-types.c
9778         (compile_cplus_instance::decl_name): Likewise.
9779         * completer.c (complete_explicit_location):
9780         (signal_completer, reg_or_group_completer_1): Likewise.
9781         * cp-support.c (cp_remove_params_if_any): Likewise.
9782         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9783         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9784         * infcmd.c (strip_bg_char): Likewise.
9785         * linespec.c (copy_token_string): Likewise.
9786         * mi/mi-main.c (output_cores): Likewise.
9787         * psymtab.c (psymtab_search_name):
9788         * symfile.c (test_set_ext_lang_command): Likewise.
9789         * target.c (target_fileio_read_stralloc): Likewise.
9790         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9791         * value.c (complete_internalvar): Likewise.
9792
9793 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9794
9795         Add objfile property to gdb.Type.
9796         * NEWS: Mention Python API addition.
9797         * python/py-type.c (typy_get_objfile): New method.
9798
9799 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9800
9801         * NEWS: Mention the new set|show style [title|highlight].
9802         Mention changes to "show style", "help" and "apropos".
9803
9804 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9805
9806         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9807         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9808         instead of print_help_for_command.
9809         (print_doc_of_command): New function.
9810         (help_list): Add 'apropos -v word' suggestion.
9811         (print_help_for_command): Style the command name using title style.
9812         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9813         (_initialize_cli_cmds): Describe -v in apropos_command help.
9814
9815 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9816
9817         * cli/cli-style.h (cli_style_option): Add name in constructor,
9818         add m_name class member, add constructor with intensity,
9819         add name class function.
9820         (cli_style_option::add_setshow_commands): Remove name argument.
9821         (highlight_style, title_style): New styles.
9822         * cli/cli-style.c (do_show): New function that shows a style
9823         characteristic styling the style name with itself.
9824         (set_style_name): New function.
9825         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9826         Update all callers according to the changes in cli/cli-style.h.
9827         * utils.h (fputs_highlighted): New function.
9828         * utils.c (fputs_highlighted): Likewise.
9829
9830 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9831
9832         * NEWS: Mention new pipe command and new convenience variables.
9833
9834 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9835
9836         * cli/cli-cmds.c (pipe_command): New function.
9837         (_initialize_cli_cmds): Call add_com for pipe_command.
9838         Define | as an alias for pipe.
9839         (exit_status_set_internal_vars): New function.
9840         (shell_escape): Call exit_status_set_internal_vars.
9841         cli/cli-decode.c (find_command_name_length): Recognize | as
9842         a single character command.
9843
9844 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9845
9846         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9847         top.c (execute_command_to_ui_file): New function, mostly a copy
9848         of execute_command_to_string.
9849         (execute_command_to_string): Implement by calling
9850         execute_command_to_ui_file.
9851
9852 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9853
9854         * top.h (saved_command_line): Remove declaration.
9855         * top.c (previous_saved_command_line, previous_repeat_arguments):
9856         New variables.
9857         (saved_command_line): Make static, define together with other
9858         'repeat variables'.
9859         (dont_repeat): Clear repeat_arguments.
9860         (repeat_previous, get_saved_command_line, save_command_line):
9861         New functions.
9862         (gdb_init): Initialize saved_command_line
9863         and previous_saved_command_line.
9864         * main.c (captured_main_1): Remove saved_command_line initialization.
9865         * event-top.c (handle_line_of_input): Update to use
9866         the new 'repeat' related functions instead of direct access to
9867         saved_command_line.
9868         * command.h (repeat_previous, get_saved_command_line,
9869         save_command_line): New declarations.
9870         (dont_repeat): Add comment.
9871
9872 2019-05-30  Tom Tromey  <tromey@adacore.com>
9873
9874         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9875         Fix comment.
9876         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9877
9878 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9879
9880         PR cli/24587
9881         * completer.c (complete): Initialize variable word.
9882
9883 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9884
9885         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9886         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9887         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9888         'body' is NULL to the outter 'if', protecting the '!is_define'
9889         situation as well.
9890
9891 2019-05-29  Tom Tromey  <tromey@adacore.com>
9892
9893         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9894         (dwarf_unknown): New function.
9895         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9896         (dwarf_type_encoding_name): Use dwarf_unknown.
9897
9898 2019-05-29  Tom Tromey  <tromey@adacore.com>
9899
9900         PR c++/20020:
9901         * cp-valprint.c (cp_print_value_fields): Call
9902         cp_print_static_field inside "try".
9903
9904 2019-05-29  Tom Tromey  <tromey@adacore.com>
9905
9906         * inflow.c (struct terminal_info): Add default operator=.
9907         * configure: Rebuild.
9908         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9909         -Wdeprecated-copy-dtor, -Wredundant-move.
9910
9911 2019-05-29  Tom Tromey  <tromey@adacore.com>
9912
9913         * NEWS: Add entry.
9914         * infcmd.c (print_return_value_1): Handle finish_print
9915         option.
9916         (show_print_finish): New function.
9917         (_initialize_infcmd): Add "set/show print finish" commands.
9918         * valprint.c (user_print_options): Initialize new member.
9919         * valprint.h (struct value_print_options) <finish_print>: New
9920         member.
9921
9922 2019-05-28  Tom Tromey  <tromey@adacore.com>
9923
9924         * ada-lang.c (ada_remove_Xbn_suffix)
9925         (find_old_style_renaming_symbol)
9926         (parse_old_style_renaming): Remove.
9927         (ada_find_renaming_symbol): Don't call
9928         find_old_style_renaming_symbol.
9929         (ada_is_renaming_symbol): Rename from
9930         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9931         bool.  Now static.
9932         (ada_read_var_value): Update and simplify.
9933         * ada-exp.y (write_var_or_type): Remove old code.
9934
9935 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9936
9937         PR gdb/25010
9938         * event-top.c: Remove include comment.
9939         * inflow.c (class scoped_ignore_sigttou): Move from here...
9940         * inflow.h (class scoped_ignore_sigttou): ...to here.
9941         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9942         * top.c:  Remove include comment.
9943
9944 2019-05-27  Tom Tromey  <tom@tromey.com>
9945
9946         * NEWS: Fix typo.
9947
9948 2019-05-22  Tom Tromey  <tromey@adacore.com>
9949
9950         * target.c (target_follow_exec): Constify parameter.
9951         * target-delegates.c: Rebuild.
9952         * remote.c (remote_target::follow_exec): Constify parameter.
9953         * infrun.c (follow_exec): Constify parameter.
9954         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9955         (target_follow_exec): Likewise.
9956
9957 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9958
9959         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9960         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9961
9962 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9963
9964         * NEWS: Add debugredirect and testsuite sections.
9965
9966 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9967
9968         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9969         target descriptions using exclusively floating point register name
9970         aliases.
9971
9972 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9973
9974         PR gdb/18644:
9975         * f-lang.c (build_fortran_types): Handle the case where
9976         gdbarch_floatformat_for_type returns a nullptr.
9977
9978 2019-05-21  Tom de Vries  <tdevries@suse.de>
9979
9980         PR cli/24587
9981         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9982
9983 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9984
9985         PR gdb/18644:
9986         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9987         16-byte floats.
9988         * i386-tdep.c (i386_floatformat_for_type): Use
9989         floatformats_ia64_quad for the 16-byte floating point component
9990         within a fortran 32-byte complex number.
9991
9992 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9993
9994         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9995         delete default constructor.
9996         (find_partial_die): Update to return const struct.
9997         (partial_die_parent_scope): Move variable declaration into scope
9998         of its use and change its type to auto.
9999         (guess_partial_die_structure_name): Likewise.
10000         (partial_die_info::fixup): Likewise.
10001
10002 2019-05-17  Tom Tromey  <tromey@adacore.com>
10003
10004         * source.c (find_and_open_source): Remove cast.
10005
10006 2019-05-17  Tom Tromey  <tromey@adacore.com>
10007
10008         * annotate.c (annotate_source): Make "filename" const.
10009         * annotate.h (annotate_source): Use const.
10010
10011 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10012
10013         * disasm.c (set_disassembler_options): Send errors to stderr.
10014
10015 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10016
10017         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10018         (cli_interp_base::set_logging): Check debug_redirect.
10019         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10020         * cli/cli-logging.c (debug_redirect): Add static variable.
10021         (pop_output_files): Add default param.
10022         (handle_redirections): Print debug setting.
10023         (show_logging_command): Likewise.
10024         (_initialize_cli_logging): Add debugredirect command.
10025         * interps.c (current_interp_set_logging): Add debug_redirect
10026         parameter.
10027         * interps.h (set_logging): Add debug_redirect parameter.
10028         (current_interp_set_logging): Likewise.
10029         * mi/mi-common.h: Likewise.
10030         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10031
10032 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10033             Tom Tromey  <tromey@adacore.com>
10034
10035         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10036         directly.
10037         * cli/cli-interp.h (make_logging_output): Remove declaration.
10038         * cli/cli-logging.c (make_logging_output): Remove function.
10039         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10040         directly.
10041         * ui-file.c (tee_file::tee_file): Remove bools.
10042         (tee_file::~tee_file): Remove deletes.
10043         * ui-file.h (tee_file): Remove bools.
10044
10045 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10046
10047         * mi/mi-cmds.h (mi_cmd_complete): New function.
10048         * mi/mi-main.c (mi_cmd_complete): Likewise.
10049         * mi/mi-cmds.c: Define new MI command -complete.
10050         * NEWS: Mention new -complete command.
10051
10052 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10053
10054         * completer.h (complete): New function.
10055         * completer.c (complete): Likewise.
10056         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10057         function defined in completer.h.
10058
10059 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10060
10061         * MAINTAINERS (Write After Approval): Add myself.
10062
10063 2019-05-17  Tom de Vries  <tdevries@suse.de>
10064
10065         PR gdb/24094
10066         * dwarf2read.c (struct cu_partial_die_info): New struct.
10067         (find_partial_die): Return cu_partial_die_info.
10068         (partial_die_parent_scope, guess_partial_die_structure_name)
10069         (partial_die_info::fixup): Handle new return type of find_partial_die.
10070
10071 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10072
10073         PR breakpoints/24541
10074         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10075         "std::string", simplifying the algorithm.
10076
10077 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10078
10079         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10080         (stap_static_probe_ops::get_probes): Likewise.
10081
10082 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10083
10084         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10085         '-')" and "else if".
10086         (stap_parse_single_operand): Join checks for
10087         "gdbarch_stap_parse_special_token_p" and
10088         "gdbarch_stap_parse_special_token" in the same "if" statement.
10089         Invert check when verifying for operation on register
10090         displacement.
10091
10092 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10093
10094         * stap-probe.c (stap_get_opcode): Update comment.
10095         (stap_get_expected_argument_type): Likewise.
10096         (handle_stap_probe): Likewise.
10097
10098 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10099
10100         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10101         return type to 'bool'.  Adjust comment.  Use 'bool' when
10102         appropriate.
10103         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10104         * stap-probe.c (stap_parse_argument_1): Likewise.
10105         (stap_is_operator): Likewise.
10106         (stap_is_generic_prefix): Likewise.
10107         (stap_is_register_prefix): Likewise.
10108         (stap_is_register_indirection_prefix): Likewise.
10109         (stap_is_integer_prefix): Likewise.
10110         (stap_generic_check_suffix): Likewise.
10111         (stap_check_integer_suffix): Likewise.
10112         (stap_check_register_suffix): Likewise.
10113         (stap_check_register_indirection_suffix): Likewise.
10114         (stap_parse_register_operand): Likewise.
10115         (stap_parse_single_operand): Likewise.
10116         (stap_parse_argument_1): Likewise.
10117         (stap_probe::get_argument_count): Likewise.
10118         (stap_is_operator): Likewise.
10119
10120 2019-05-16  Tom Tromey  <tromey@adacore.com>
10121
10122         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10123         keyword to foreach.
10124
10125 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10126
10127         * linux-thread-db.c (try_thread_db_load_1): Change return type
10128         to bool.
10129         (try_thread_db_load): Likewise.
10130         (try_thread_db_load_from_pdir_1): Likewise.
10131         (try_thread_db_load_from_pdir): Likewise.
10132         (try_thread_db_load_from_sdir): Likewise.
10133         (try_thread_db_load_from_dir): Likewise.
10134         (thread_db_load_search): Likewise.
10135         (has_libpthread): Likewise.
10136         (thread_db_load): Likewise.
10137
10138 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10139
10140         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10141         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10142         NULL, and complain/return if that's the case.
10143
10144 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10145
10146         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10147         (advance, posn, abstract_read_memory): New functions.
10148         [struct mem_read_abstraction]: New struct.
10149         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10150
10151 2019-05-14  Tom Tromey  <tromey@adacore.com>
10152
10153         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10154         value is not lval_memory.
10155
10156 2019-05-14  Tom Tromey  <tromey@adacore.com>
10157
10158         * solib.c (info_sharedlibrary_command): Style the file name.
10159
10160 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10161
10162         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10163         (aarch64_vnv_type): Likewise.
10164         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10165         * common/tdesc.c: Likewise.
10166         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10167         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10168         * features/aarch64-fpu.xml: Add ieee half view.
10169         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10170         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10171         * gdbtypes.h (struct builtin_type): Likewise.
10172         (struct objfile_type): Likewise.
10173
10174 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10175
10176         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10177         typo.
10178         * location.h (string_to_event_location): Likewise.
10179
10180 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10181
10182         GDB 8.3 released.
10183
10184 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10185
10186         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10187         New variable declaration.
10188         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10189         New variable.
10190         (print_one_breakpoint): Use ui_out::test_flags and new global
10191         variable to compute use_fixed_output.
10192         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10193         Remove.
10194         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10195         (mi_multi_location_breakpoint_output_fixed): Remove.
10196         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10197         new variable.
10198         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10199         fix_multi_location_breakpoint_output flag if version >= 3.
10200         * ui-out.h (enum ui_out_flag)
10201         <fix_multi_location_breakpoint_output>: New enumerator.
10202
10203 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10204
10205         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10206
10207 2019-05-10  Tom Tromey  <tromey@adacore.com>
10208
10209         * ada-lang.c (catch_ada_completer): New function.
10210         (_initialize_ada_language): Use it.
10211
10212 2019-05-10  Tom Tromey  <tromey@adacore.com>
10213
10214         * thread.c (print_thread_info): Make "requested_threads" const.
10215         * gdbthread.h (print_thread_info): Make "requested_threads"
10216         const.
10217         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10218         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10219
10220 2019-05-08  Tom Tromey  <tom@tromey.com>
10221
10222         * gdbtypes.c (objfile_type_data): Change type.
10223         (objfile_type, _initialize_gdbtypes): Update.
10224
10225 2019-05-08  Tom Tromey  <tom@tromey.com>
10226
10227         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10228         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10229         (_initialize_dwarf2_frame): Update.
10230
10231 2019-05-08  Tom Tromey  <tom@tromey.com>
10232
10233         * objc-lang.c (objc_objfile_data): Change type.
10234         (find_methods): Update.
10235         (_initialize_objc_lang): Remove.
10236
10237 2019-05-08  Tom Tromey  <tom@tromey.com>
10238
10239         * stabsread.c (rs6000_builtin_type_data): Change type.
10240         (rs6000_builtin_type, _initialize_stabsread): Update.
10241
10242 2019-05-08  Tom Tromey  <tom@tromey.com>
10243
10244         * mips-tdep.c (mips_pdr_data): Remove.
10245         (_initialize_mips_tdep): Update.
10246
10247 2019-05-08  Tom Tromey  <tom@tromey.com>
10248
10249         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10250         (hppa_init_objfile_priv_data, read_unwind_info)
10251         (find_unwind_entry, _initialize_hppa_tdep): Update.
10252
10253 2019-05-08  Tom Tromey  <tom@tromey.com>
10254
10255         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10256         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10257         on obstack.
10258         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10259
10260 2019-05-08  Tom Tromey  <tom@tromey.com>
10261
10262         * mdebugread.c (basic_type_data): Change type.
10263         (basic_type, _initialize_mdebugread): Update.
10264
10265 2019-05-08  Tom Tromey  <tom@tromey.com>
10266
10267         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10268
10269 2019-05-08  Tom Tromey  <tom@tromey.com>
10270
10271         * nto-tdep.c (nto_inferior_data_reg): Change type.
10272         (nto_inferior_data): Update.
10273         (nto_inferior_data_cleanup, nto_new_inferior_data)
10274         (_initialize_nto_tdep): Remove.
10275         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10276
10277 2019-05-08  Tom Tromey  <tom@tromey.com>
10278
10279         * ada-lang.c (struct ada_inferior_data): Add initializers.
10280         (ada_inferior_data): Change type.
10281         (ada_inferior_data_cleanup): Remove.
10282         (get_ada_inferior_data, ada_inferior_exit)
10283         (struct ada_pspace_data): Add initializers, destructor.
10284         (ada_pspace_data_handle): Change type.
10285         (get_ada_pspace_data): Update.
10286         (ada_pspace_data_cleanup): Remove.
10287
10288 2019-05-08  Tom Tromey  <tom@tromey.com>
10289
10290         * coffread.c (struct coff_symfile_info): Add initializers.
10291         (coff_objfile_data_key): Move lower.  Change type.
10292         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10293         Update.
10294         (coff_free_info): Remove.
10295
10296 2019-05-08  Tom Tromey  <tom@tromey.com>
10297
10298         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10299         (fbsd_pspace_data_handle): Move lower.  Change type.
10300         (get_fbsd_pspace_data): Update.
10301         (fbsd_pspace_data_cleanup): Remove.
10302         (_initialize_fbsd_tdep): Update.
10303
10304 2019-05-08  Tom Tromey  <tom@tromey.com>
10305
10306         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10307         (get_ada_tasks_pspace_data): Update.
10308         (ada_tasks_pspace_data_cleanup): Remove.
10309         (_initialize_tasks): Update.
10310         (ada_tasks_inferior_data_handle): Change type.
10311         (get_ada_tasks_inferior_data): Update.
10312         (ada_tasks_inferior_data_cleanup): Remove.
10313         (struct ada_tasks_pspace_data): Add initializers.
10314
10315 2019-05-08  Tom Tromey  <tom@tromey.com>
10316
10317         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10318         * symfile-debug.c (debug_sym_get_probes): Change type.
10319         * stap-probe.c (handle_stap_probe):
10320         (stap_static_probe_ops::get_probes): Change type.
10321         * probe.h (class static_probe_ops) <get_probes>: Change type.
10322         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10323         (parse_probes_in_pspace): Update.
10324         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10325         Update.
10326         (any_static_probe_ops::get_probes): Change type.
10327         * elfread.c (elfread_data): New typedef.
10328         (probe_key): Change type.
10329         (elf_get_probes): Likewise.  Update.
10330         (probe_key_free): Remove.
10331         (_initialize_elfread): Update.
10332         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10333         Change type.
10334         (dtrace_process_dof_probe, dtrace_process_dof)
10335         (dtrace_static_probe_ops::get_probe): Change type.
10336
10337 2019-05-08  Tom Tromey  <tom@tromey.com>
10338
10339         * xcoffread.c (struct xcoff_symfile_info): Rename from
10340         coff_symfile_info.  Add initializers.
10341         (xcoff_objfile_data_key): Move lower.  Change type.
10342         (XCOFF_DATA): Rewrite.
10343         (xcoff_free_info): Remove.
10344         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10345         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10346         (xcoff_initial_scan): Update.
10347
10348 2019-05-08  Tom Tromey  <tom@tromey.com>
10349
10350         * solib-svr4.c (struct svr4_info): Add initializers and
10351         destructor.
10352         <probes_table>: Now an htab_up.
10353         (solib_svr4_pspace_data): Change type.
10354         (free_probes_table): Simplify.
10355         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10356         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10357         (probes_table_remove_objfile_probes, register_solib_event_probe)
10358         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10359         (_initialize_svr4_solib): Update.
10360
10361 2019-05-08  Tom Tromey  <tom@tromey.com>
10362
10363         * remote.c (remote_pspace_data): Change type.
10364         (remote_pspace_data_cleanup): Remove.
10365         (get_remote_exec_file, set_pspace_remote_exec_file)
10366         (_initialize_remote): Update.
10367
10368 2019-05-08  Tom Tromey  <tom@tromey.com>
10369
10370         * breakpoint.c (breakpoint_objfile_key): Change type.
10371         (get_breakpoint_objfile_data): Update.
10372         (free_breakpoint_objfile_data): Remove.
10373         (_initialize_breakpoint): Update.
10374
10375 2019-05-08  Tom Tromey  <tom@tromey.com>
10376
10377         * linux-tdep.c (struct linux_info): Add initializers.
10378         (linux_inferior_data): Move.  Change type.
10379         (invalidate_linux_cache_inf): Update.
10380         (linux_inferior_data_cleanup): Remove.
10381         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10382
10383 2019-05-08  Tom Tromey  <tom@tromey.com>
10384
10385         * auxv.c (auxv_inferior_data): Move.  Change type.
10386         (auxv_inferior_data_cleanup): Remove.
10387         (invalidate_auxv_cache_inf): Rewrite.
10388         (get_auxv_inferior_data, _initialize_auxv): Update.
10389
10390 2019-05-08  Tom Tromey  <tom@tromey.com>
10391
10392         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10393         (symfile_debug_objfile_data_key): Change type.
10394         (symfile_debug_installed, debug_qf_has_symbols)
10395         (debug_qf_find_last_source_symtab)
10396         (debug_qf_forget_cached_source_info)
10397         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10398         (debug_qf_print_stats, debug_qf_dump)
10399         (debug_qf_expand_symtabs_for_function)
10400         (debug_qf_expand_all_symtabs)
10401         (debug_qf_expand_symtabs_with_fullname)
10402         (debug_qf_map_matching_symbols)
10403         (debug_qf_expand_symtabs_matching)
10404         (debug_qf_find_pc_sect_compunit_symtab)
10405         (debug_qf_map_symbol_filenames)
10406         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10407         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10408         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10409         (debug_sym_read_linetable, debug_sym_relocate): Update.
10410         (symfile_debug_free_objfile): Remove.
10411         (install_symfile_debug_logging, _initialize_symfile_debug):
10412         Update.
10413
10414 2019-05-08  Tom Tromey  <tom@tromey.com>
10415
10416         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10417         allocate_on_obstack.
10418         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10419         (get_dwarf2_per_objfile): Update.
10420         (set_dwarf2_per_objfile): Remove.
10421         (dwarf2_has_info, dwarf2_get_section_info): Update.
10422         (dwarf2_free_objfile): Remove.
10423         (_initialize_dwarf2_read): Update.
10424
10425 2019-05-08  Tom Tromey  <tom@tromey.com>
10426
10427         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10428         initializers.
10429         <unsupported_script_warning_printed,
10430         script_not_found_warning_printed>: Now bool.
10431         (auto_load_pspace_data): Change type.
10432         (~auto_load_pspace_info): Rename from
10433         auto_load_pspace_data_cleanup.
10434         (get_auto_load_pspace_data, init_loaded_scripts_info)
10435         (clear_section_scripts, maybe_print_unsupported_script_warning)
10436         (maybe_print_script_not_found_warning, _initialize_auto_load):
10437         Update.
10438
10439 2019-05-08  Tom Tromey  <tom@tromey.com>
10440
10441         * objfiles.c (objfile_pspace_info): Add destructor and
10442         initializers.
10443         (objfiles_pspace_data): Change type.
10444         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10445         (get_objfile_pspace_data): Update.
10446         (objfiles_bfd_data): Change type.
10447         (get_objfile_bfd_data): Update.
10448         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10449
10450 2019-05-08  Tom Tromey  <tom@tromey.com>
10451
10452         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10453         Change type.
10454         (get_catch_syscall_inferior_data): Update.
10455         (catch_syscall_inferior_data_cleanup): Remove.
10456         (_initialize_break_catch_syscall): Update.
10457
10458 2019-05-08  Tom Tromey  <tom@tromey.com>
10459
10460         * inflow.c (struct terminal_info): Add destructor and
10461         initializers.
10462         (inflow_inferior_data): Change type.
10463         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10464         (get_inflow_inferior_data, inflow_inferior_exit)
10465         (swap_terminal_info, _initialize_inflow): Update.
10466
10467 2019-05-08  Tom Tromey  <tom@tromey.com>
10468
10469         * target-dcache.c (target_dcache_cleanup): Remove.
10470         (target_dcache_aspace_key): Change type.
10471         (target_dcache_init_p, target_dcache_invalidate)
10472         (target_dcache_get, target_dcache_get_or_init)
10473         (_initialize_target_dcache): Update.
10474         * dcache.h (struct dcache_deleter): New.
10475
10476 2019-05-08  Tom Tromey  <tom@tromey.com>
10477
10478         * symtab.c (struct symbol_cache): Add destructor and
10479         initializers.
10480         (symbol_cache_key): Move.  Change type.
10481         (make_symbol_cache, free_symbol_cache): Remove.
10482         (get_symbol_cache): Update.
10483         (symbol_cache_cleanup): Remove.
10484         (ALL_PSPACES, symbol_cache_flush)
10485         (maintenance_print_symbol_cache)
10486         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10487         Update.
10488
10489 2019-05-08  Tom Tromey  <tom@tromey.com>
10490
10491         * symtab.c (struct main_info): Add destructor and initializers.
10492         (main_progspace_key): Move.  Change type.
10493         (get_main_info): Update.
10494         (main_info_cleanup): Remove.
10495         (_initialize_symtab): Update.
10496
10497 2019-05-08  Tom Tromey  <tom@tromey.com>
10498
10499         * registry.h (DECLARE_REGISTRY): Define the _key class.
10500
10501 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10502
10503         * NEWS: Merge two 'New commands' sections.
10504
10505 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10506
10507         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10508         parameter and use Ada language definition instead.
10509         (ada_val_print_ptr): Remove unused language parameter.
10510         (ada_val_print_num): Remove language parameter and use Ada language
10511         definition instead.
10512         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10513         parameter.
10514         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10515         parameter and use Ada language definition instead.
10516         (ada_val_print_1): Update all ada_val_print_xxx calls.
10517         Remove language parameter.
10518         (ada_val_print): Update ada_val_print_1 call.
10519
10520 2019-05-08  Tom Tromey  <tromey@adacore.com>
10521
10522         * remote.c (remote_hw_watchpoint_limit)
10523         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10524         Now static.
10525
10526 2019-05-08  Tom Tromey  <tromey@adacore.com>
10527
10528         * maint.c (_initialize_maint_cmds): Move initialization code to
10529         remote.c.
10530         (watchdog, show_watchdog): Move to remote.c.
10531         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10532         "watchdog" static.
10533         (_initialize_remote): Move initialization code from maint.c.
10534         * defs.h (watchdog): Don't declare.
10535
10536 2019-05-08  Tom Tromey  <tromey@adacore.com>
10537
10538         * tui/tui-interp.c: Include main.h.
10539         * interps.c: Include main.h.
10540         * main.h (interpreter_p): Declare.
10541         * defs.h (interpreter_p): Don't declare.
10542
10543 2019-05-08  Tom Tromey  <tromey@adacore.com>
10544
10545         * dwarf2loc.c: Include dwarf2read.h.
10546         * defs.h (read_unsigned_leb128): Don't declare.
10547         * dwarf2read.h (read_unsigned_leb128): Declare.
10548
10549 2019-05-08  Tom Tromey  <tromey@adacore.com>
10550
10551         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10552         method.
10553
10554 2019-05-08  Tom Tromey  <tromey@adacore.com>
10555
10556         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10557         when no wrap column is set.
10558
10559 2019-05-08  Tom Tromey  <tromey@adacore.com>
10560
10561         * c-lang.c (c_get_string): Handle non-C-style arrays.
10562
10563 2019-05-08  Tom Tromey  <tromey@adacore.com>
10564
10565         * typeprint.c (print_offset_data::update): Print the bit offset,
10566         not the number of bits remaining.
10567
10568 2019-05-08  Tom Tromey  <tromey@adacore.com>
10569
10570         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10571         padding at end of comment.
10572
10573 2019-05-08  Tom Tromey  <tromey@adacore.com>
10574
10575         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10576         Compare main types.
10577
10578 2019-05-06  Tom Tromey  <tom@tromey.com>
10579
10580         * common/scoped_mmap.c: Include common-defs.h.
10581         * common/scoped_mmap.h: Don't include config.h.
10582
10583 2019-05-04  Tom Tromey  <tom@tromey.com>
10584
10585         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10586         (struct aarch64_call_info): Add initializers.
10587         <si>: Now a std::vector.
10588         (pass_on_stack, aarch64_push_dummy_call): Update.
10589
10590 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10591             Tom Tromey  <tom@tromey.com>
10592
10593         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10594         (ppc_threads): Now a std::vector.  Now static.
10595         (hwdebug_find_thread_points_by_tid)
10596         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10597         Update.
10598
10599 2019-05-04  Tom Tromey  <tom@tromey.com>
10600
10601         * arc-tdep.c (arc_tdesc_init): Return bool.
10602
10603 2019-05-04  Tom Tromey  <tom@tromey.com>
10604
10605         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10606         Use gdb_assert_not_reached.
10607
10608 2019-05-04  Tom Tromey  <tom@tromey.com>
10609
10610         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10611         "false".
10612
10613 2019-05-04  Tom Tromey  <tom@tromey.com>
10614
10615         * arc-tdep.c (arc_tdesc_init): Use bool.
10616
10617 2019-05-04  Tom Tromey  <tom@tromey.com>
10618
10619         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10620
10621 2019-05-04  Tom Tromey  <tom@tromey.com>
10622
10623         * cli/cli-cmds.c (valid_command_p): Return bool.
10624
10625 2019-05-04  Tom Tromey  <tom@tromey.com>
10626
10627         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10628         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10629
10630 2019-05-04  Raul Tambre  <raul@tambre.ee>
10631
10632         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10633         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10634         operator for comparison.
10635
10636 2019-05-04  Tom Tromey  <tom@tromey.com>
10637
10638         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10639         (lookup_partial_symbol, print_partial_symbols)
10640         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10641         (psymbol_compare): Update.
10642         (add_psymbol_to_bcache): Clear the entire psymbol.
10643         (maintenance_check_psymtabs): Update.
10644         * psympriv.h (struct partial_symbol): Don't derive from
10645         general_symbol_info.
10646         <obj_section, unrelocated_address, address,
10647         set_unrelocated_address>: Update.
10648         <ginfo>: New member.
10649         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10650         (debug_names::write_psymbols): Update.
10651
10652 2019-05-04  Tom de Vries  <tdevries@suse.de>
10653
10654         * contrib/cc-with-tweaks.sh: Support -n arg.
10655
10656 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10657
10658         * corelow.c (core_target::detach): Ensure frame cache and
10659         register caches are cleared.
10660         inferior.c (exit_inferior_1): Likewise.
10661
10662 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10663             Tom Tromey  <tom@tromey.com>
10664
10665         * dictionary.c (collate_pending_symbols_by_language): Remove
10666         "struct" from foreach.
10667         * symtab.c (lookup_global_symbol_from_objfile)
10668         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10669         foreach.
10670         * ser-tcp.c (net_open): Remove "struct" from foreach.
10671         * objfiles.c (objfile_relocate, objfile_rebase)
10672         (objfile_has_symbols): Remove "struct" from foreach.
10673         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10674         from foreach.
10675         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10676         foreach.
10677         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10678         "struct" from foreach.
10679         * ada-lang.c (create_excep_cond_exprs)
10680         (ada_exception_catchpoint_cond_string): Remove "struct" from
10681         foreach.
10682
10683 2019-05-03  Tom Tromey  <tromey@adacore.com>
10684
10685         * ada-exp.y (convert_char_literal): Check suffix of each
10686         enumerator.
10687
10688 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10689
10690         PR ada/21406:
10691         * ada-exp.y (yywrap): Don't define.
10692         * ada-lex.l (%option): Add noyywrap
10693         (yywrap): Remove.
10694
10695 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10696
10697         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10698         _WIN32_WINNT to the XP level, unless already defined to a higher
10699         level.
10700
10701         * unittests/parse-connection-spec-selftests.c:
10702         * ser-tcp.c:
10703         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10704         override.
10705
10706         * symfile.c (find_separate_debug_file): Remove colon from the
10707         drive spec of DOS/Windows file names of the target, so that the
10708         file name produced from DEBUGDIR and the target's directory will
10709         be valid on DOS/Windows systems.
10710
10711 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10712
10713         * rust-lang.c (val_print_struct): Handle printing structures
10714         containing strings.
10715
10716 2019-05-02  Tom Tromey  <tromey@adacore.com>
10717
10718         * valarith.c (_initialize_valarith): Remove.
10719
10720 2019-05-01  Tom Tromey  <tromey@adacore.com>
10721
10722         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10723         bitfields.
10724
10725 2019-05-01  Tom Tromey  <tromey@adacore.com>
10726
10727         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10728         for big-endian copies.
10729
10730 2019-04-30  Ali Tamur  <tamur@google.com>
10731         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10732         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10733         (read_3_bytes): New function.
10734
10735 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10736
10737         * windows-nat.c (main_thread_id): Delete.
10738         (handle_output_debug_string): Replace main_thread_id by
10739         current_event.dwThreadId.
10740         (fake_create_process): Likewise.
10741         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10742         Do not set main_thread_id.
10743         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10744         current_event.dwThreadId.
10745         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10746
10747 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10748
10749         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10750         Use current_event.dwThreadId instead of main_thread_id.
10751
10752 2019-04-30  Tom Tromey  <tromey@adacore.com>
10753
10754         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10755         (create_excep_cond_exprs): Iterate over program spaces.
10756         (ada_exception_catchpoint_cond_string): Examine all minimal
10757         symbols for exception types.
10758
10759 2019-04-30  Tom Tromey  <tromey@adacore.com>
10760
10761         PR c++/24470:
10762         * dwarf2read.c (process_structure_scope): Handle case where type
10763         has template parameters but no symbol was created.
10764
10765 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10766             Chris January  <chris.january@arm.com>
10767
10768         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10769         qualifier.
10770         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10771
10772 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10773
10774         * f-typeprint.c (f_print_type): Update rules for printing
10775         whitespace.
10776         (f_type_print_varspec_suffix): Likewise.
10777
10778 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10779             Chris January  <chris.january@arm.com>
10780
10781         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10782         function arguments.
10783
10784 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10785
10786         * f-lang.c (build_fortran_types): Change name of void type to
10787         lower case.
10788         * f-typeprint.c (f_type_print_base): Print the name of the void
10789         type, rather than a fixed string.
10790         * f-valprint.c (f_decorations): Use lower case void string.
10791
10792 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10793             Chris January  <chris.january@arm.com>
10794
10795         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10796         types for Fortran.
10797
10798 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10799             Chris January  <chris.january@arm.com>
10800             David Lecomber  <david.lecomber@arm.com>
10801
10802         * f-exp.y (BINOP_INTRINSIC): New token.
10803         (exp): New parser rule handling BINOP_INTRINSIC.
10804         (f77_keywords): Add new builtin procedures.
10805         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10806         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10807         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10808         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10809         (print_unop_subexp_f): New function.
10810         (print_binop_subexp_f): New function.
10811         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10812         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10813         (dump_subexp_body_f): Likewise.
10814         (operator_check_f): Likewise.
10815         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10816         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10817
10818 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10819
10820         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10821         UNOP_KIND.
10822         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10823         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10824         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10825         (operator_length_f): New fuction.
10826         (print_subexp_f): New function.
10827         (op_name_f): New function.
10828         (dump_subexp_body_f): New function.
10829         (operator_check_f): New function.
10830         (exp_descriptor_f): Replace standard expression handling functions
10831         with new functions.
10832         * gdb/fortran-operator.def: New file.
10833         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10834         * gdb/std-operator.def: Remove UNOP_KIND.
10835
10836 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10837
10838         * std-operator.def: Remove unbalanced, stray double quote
10839         character.
10840
10841 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10842             Chris January  <chris.january@arm.com>
10843             Daniel Everett  <daniel.everett@arm.com>
10844             Nick Forrington  <nick.forrington@arm.com>
10845             Richard Bunt  <richard.bunt@arm.com>
10846
10847         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10848         of depth when printing anonymous structs or unions.
10849         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10850         Don't print either the top-level value, or the children if the
10851         max-depth is exceeded.
10852         (ppscm_print_children): When printing the key of a map, allow one
10853         extra level of depth.
10854         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10855         print either the top-level value, or the children if the max-depth
10856         is exceeded.
10857         (print_children): When printing the key of a map, allow one extra
10858         level of depth.
10859         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10860         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10861         (user_print_options): Initialise max_depth field.
10862         (val_print_scalar_or_string_type_p): New function.
10863         (val_print): Check to see if the max depth has been reached.
10864         (val_print_check_max_depth): Define new function.
10865         (show_print_max_depth): New function.
10866         (_initialize_valprint): Add 'print max-depth' option.
10867         * valprint.h (struct value_print_options) <max_depth>: New field.
10868         (val_print_check_max_depth): Declare new function.
10869         * NEWS: Document new feature.
10870
10871 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10872
10873         * ada-lang.c (ada_language_defn): Initialise new field.
10874         * c-lang.c (c_is_string_type_p): New function.
10875         (c_language_defn): Initialise new field.
10876         (cplus_language_defn): Initialise new field.
10877         (asm_language_defn): Initialise new field.
10878         (minimal_language_defn): Initialise new field.
10879         * c-lang.h (c_is_string_type_p): Declare new function.
10880         * d-lang.c (d_language_defn): Initialise new field.
10881         * f-lang.c (f_is_string_type_p): New function.
10882         (f_language_defn): Initialise new field.
10883         * go-lang.c (go_is_string_type_p): New function.
10884         (go_language_defn): Initialise new field.
10885         * language.c (default_is_string_type_p): New function.
10886         (unknown_language_defn): Initialise new field.
10887         (auto_language_defn): Initialise new field.
10888         * language.h (struct language_defn) <la_is_string_type_p>: New
10889         member variable.
10890         (default_is_string_type_p): Declare new function.
10891         * m2-lang.c (m2_language_defn): Initialise new field.
10892         * objc-lang.c (objc_language_defn): Initialise new field.
10893         * opencl-lang.c (opencl_language_defn): Initialise new field.
10894         * p-lang.c (pascal_is_string_type_p): New function.
10895         (pascal_language_defn): Initialise new field.
10896         * rust-lang.c (rust_is_string_type_p): New function.
10897         (rust_language_defn): Initialise new field.
10898
10899 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10900
10901         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10902         New field.
10903         * ada-lang.c (ada_language_defn): Initialise new field.
10904         * c-lang.c (c_language_defn): Likewise.
10905         (cplus_language_defn): Likewise.
10906         (asm_language_defn): Likewise.
10907         (minimal_language_defn): Likewise.
10908         * d-lang.c (d_language_defn): Likewise.
10909         * f-lang.c (f_language_defn): Likewise.
10910         * go-lang.c (go_language_defn): Likewise.
10911         * language.c (unknown_language_defn): Likewise.
10912         (auto_language_defn): Likewise.
10913         * m2-lang.c (m2_language_defn): Likewise.
10914         * objc-lang.c (objc_language_defn): Likewise.
10915         * opencl-lang.c (opencl_language_defn): Likewise.
10916         * p-lang.c (pascal_language_defn): Likewise.
10917         * rust-lang.c (rust_language_defn): Likewise.
10918
10919 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10920
10921         * ada-lang.c (ada_is_character_type): Change return type to bool.
10922         (ada_is_string_type): Likewise.
10923         * ada-lang.h (ada_is_character_type): Update declaration
10924         (ada_is_string_type): Likewise.
10925
10926 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10927
10928         Support style in 'frame|thread apply'
10929
10930         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10931         * record.c (record_start, record_stop): Update callers of
10932         execute_command_to_string with false.
10933         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10934         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10935         methods.
10936         (class string_file): New constructor with term_out parameter.
10937         Override methods term_out and can_emit_style_escape.  New member
10938         term_out.
10939         (class stdio_file): Override can_emit_style_escape.
10940         (class tee_file): Override term_out and can_emit_style_escape.
10941         * utils.h (can_emit_style_escape): Remove.
10942         * utils.c (can_emit_style_escape): Likewise.
10943         Update all callers of can_emit_style_escape (SOMESTREAM) to
10944         SOMESTREAM->can_emit_style_escape.
10945         * source-cache.c (source_cache::get_source_lines): Likewise.
10946         * stack.c (frame_apply_command_count): Call execute_command_to_string
10947         passing the term_out characteristic of the current gdb_stdout.
10948         * thread.c (thr_try_catch_cmd): Likewise.
10949         * top.c (execute_command_to_string): pass term_out parameter
10950         to construct the string_file for the command output.
10951         * ui-file.c (term_cli_styling): New function (most code moved
10952         from utils.c can_emit_style_escape).
10953         (string_file::string_file, string_file::can_emit_style_escape,
10954         stdio_file::can_emit_style_escape, tee_file::term_out,
10955         tee_file::can_emit_style_escape): New functions.
10956
10957 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10958
10959         * NEWS: Mention the new set|show may-call-functions.
10960         * infcall.c (may_call_functions_p): New variable.
10961         (show_may_call_functions_p): New function.
10962         (call_function_by_hand_dummy): Throws an error if not
10963         may-call-functions.
10964         (_initialize_infcall): Call add_setshow_boolean_cmd for
10965         may-call-functions.
10966
10967 2019-04-25  Keith Seitz  <keiths@redhat.com>
10968
10969         PR c++/24367
10970         * cp-support.c (inspect_type): Don't attempt substitutions
10971         of symbol with the same name.
10972
10973 2019-04-25  Tom Tromey  <tromey@adacore.com>
10974
10975         PR gdb/24475:
10976         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10977         static.
10978
10979 2019-04-25  Tom Tromey  <tromey@adacore.com>
10980
10981         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10982         rvalue reference.
10983         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10984         (gdb_xml_parser::parse): Use std::move.
10985         * python/python-internal.h (gdbpy_convert_exception): Take a const
10986         reference.
10987         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10988         std::move.
10989         * python/py-utils.c (gdbpy_convert_exception): Take a const
10990         reference.
10991         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10992         Use std::move.
10993         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10994         Use std::move.
10995         * mi/mi-main.c (mi_print_exception): Take a const reference.
10996         * main.c (handle_command_errors): Take a const reference.
10997         * linespec.c (parse_linespec): Use std::move.
10998         * infcall.c (run_inferior_call): Use std::move.
10999         (call_function_by_hand_dummy): Use std::move.
11000         * exec.c (try_open_exec_file): Use std::move.
11001         * exceptions.h (exception_print, exception_fprintf)
11002         (exception_print_same): Update.
11003         * exceptions.c (print_exception, exception_print)
11004         (exception_fprintf, exception_print_same): Change parameters to
11005         const reference.
11006         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11007         * common/new-op.c: Use std::move.
11008         * common/common-exceptions.h (struct gdb_exception): Add move
11009         constructor.
11010         (struct gdb_exception_error, struct gdb_exception_quit, struct
11011         gdb_quit_bad_alloc): Change constructor to move constructor.
11012         (throw_exception): Change parameter to rvalue reference.
11013         * common/common-exceptions.c (throw_exception): Take rvalue
11014         reference.
11015         * cli/cli-interp.c (safe_execute_command): Use std::move.
11016         * breakpoint.c (insert_bp_location, location_to_sals): Use
11017         std::move.
11018
11019 2019-04-25  Tom Tromey  <tromey@adacore.com>
11020
11021         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11022         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11023         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11024         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11025         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11026         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11027         guile/scm-value.c: Use unpack.
11028         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11029         gdbscm_gdb_exception.
11030         (gdbscm_throw_gdb_exception): Likewise.
11031         (struct gdbscm_gdb_exception): New.
11032         (unpack): New function.
11033         (gdbscm_wrap): Use unpack.
11034
11035 2019-04-25  Tom Tromey  <tromey@adacore.com>
11036
11037         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11038         (gdb_rl_callback_handler): Use std::move.
11039         * common/common-exceptions.h (struct gdb_exception): Add move
11040         assignment operator.
11041         (throw_exception_sjlj): Change "exception" to const reference.
11042         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11043         (throw_exception_sjlj): Change "exception" to const reference.
11044
11045 2019-04-25  Tom Tromey  <tromey@adacore.com>
11046
11047         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11048         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11049         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11050         Update.
11051         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11052         Update.
11053         * mi/mi-interp.c (mi_interp::exec): Update.
11054         * linespec.c (parse_linespec): Update.
11055         * infcall.c (run_inferior_call): Update.
11056         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11057         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11058         (gdbscm_lookup_global_symbol): Update.
11059         * guile/scm-param.c (gdbscm_parameter_value): Update.
11060         * guile/scm-frame.c (gdbscm_frame_read_register)
11061         (gdbscm_frame_read_var): Update.
11062         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11063         * exec.c (try_open_exec_file): Update.
11064         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11065         (gdb_rl_callback_handler): Update.
11066         * common/common-exceptions.h (exception_none): Don't declare.
11067         * common/common-exceptions.c (exception_none): Don't define.
11068         (struct catcher) <exception>: Update.
11069         * cli/cli-interp.c (safe_execute_command): Update.
11070         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11071
11072 2019-04-25  Ali Tamur  <tamur@google.com>
11073
11074         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11075         (read_attribute_value): Likewise.
11076         (dwarf2_read_addr_index): Update comment.
11077         (read_str_index): Add DW_FORM_strx.
11078         (dwarf2_string_attr): Likewise.
11079         (dwarf2_const_value_attr): Likewise.
11080         (dump_die_shallow): Likewise.
11081         (dwarf2_fetch_constant_bytes): Likewise.
11082         (skip_form_bytes): Likewise.
11083         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11084
11085 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11086
11087         PR corefiles/11608
11088         PR corefiles/18187
11089         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11090         OFFSET.  Verify if current mapping contains an ELF header.
11091         (linux_find_memory_regions_full): Adjust call to
11092         dump_mapping_p.
11093
11094 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11095             Kang Li <kanglictf@gmail.com>
11096
11097         PR gdb/21600
11098
11099         * dwarf2-frame.c (read_initial_length): Be consistent about using
11100         unsigned representation of length.
11101         (decode_frame_entry_1): Likewise.  Check for wraparound of
11102         end pointer as well as buffer overflow.
11103
11104 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11105
11106         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11107         "vq".
11108
11109 2019-04-24  Tom Tromey  <tromey@adacore.com>
11110
11111         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11112
11113 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11114
11115         * s12z-tdep.c (s12z_unwind_pc): Delete.
11116         (s12z_unwind_sp): Delete.
11117         (s12z_gdbarch_init): Don't register deleted functions with
11118         gdbarch.
11119
11120 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11121
11122         * rl78-tdep.c (rl78_unwind_sp): Delete.
11123         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11124
11125 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11126
11127         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11128         (xstormy16_unwind_pc): Delete.
11129         (xstormy16_dummy_id): Delete.
11130         (xstormy16_gdbarch_init): Don't register deleted functions with
11131         gdbarch.
11132
11133 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11134
11135         * vax-tdep.c (vax_unwind_pc): Delete.
11136         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11137
11138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11139
11140         * v850-tdep.c (v850_unwind_sp): Delete.
11141         (v850_unwind_pc): Delete.
11142         (v850_dummy_id): Delete.
11143         (v850_gdbarch_init): Don't register deleted functions with
11144         gdbarch.
11145
11146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11147
11148         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11149         (tilegx_unwind_pc): Delete.
11150         (tilegx_unwind_dummy_id): Delete.
11151         (tilegx_gdbarch_init): Don't register deleted functions with
11152         gdbarch.
11153
11154 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11155
11156         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11157         (tic6x_dummy_id): Delete.
11158         (tic6x_gdbarch_init): Don't register deleted functions with
11159         gdbarch.
11160
11161 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11162
11163         * sparc-tdep.c (sparc_unwind_pc): Delete.
11164         (sparc32_gdbarch_init): Don't register deleted function with
11165         gdbarch.
11166
11167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11168
11169         * sh-tdep.c (sh_unwind_sp): Delete.
11170         (sh_unwind_pc): Delete.
11171         (sh_dummy_id): Delete.
11172         (sh_gdbarch_init): Don't register deleted functions with
11173         gdbarch.
11174
11175 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11176
11177         * score-tdep.c (score_unwind_sp): Delete.
11178         (score_unwind_pc): Delete.
11179         (score_dummy_id): Delete.
11180         (score_gdbarch_init): Don't register deleted functions with
11181         gdbarch.
11182
11183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11184
11185         * rx-tdep.c (rx_unwind_pc): Delete.
11186         (rx_unwind_sp): Delete.
11187         (rx_dummy_id): Delete.
11188         (rx_gdbarch_init): Don't register deleted functions with
11189         gdbarch.  Update comment.
11190
11191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11192
11193         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11194         (rs6000_dummy_id): Delete.
11195         (rs6000_gdbarch_init): Don't register deleted functions with
11196         gdbarch.
11197
11198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11199
11200         * or1k-tdep.c (or1k_dummy_id): Delete.
11201         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11202
11203 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11204
11205         * nios2-tdep.c (nios2_dummy_id): Delete.
11206         (nios2_unwind_sp): Delete.
11207         (nios2_gdbarch_init): Don't register deleted functions with
11208         gdbarch.
11209
11210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11211
11212         * nds32-tdep.c (nds32_dummy_id): Delete.
11213         (nds32_unwind_pc): Delete.
11214         (nds32_unwind_sp): Delete.
11215         (nds32_gdbarch_init): Don't register deleted functions with
11216         gdbarch.
11217
11218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11219
11220         * msp430-tdep.c (msp430_unwind_pc): Delete.
11221         (msp430_unwind_sp): Delete.
11222         (msp430_dummy_id): Delete.
11223         (msp430_gdbarch_init): Don't register deleted functions with
11224         gdbarch.
11225
11226 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11227
11228         * moxie-tdep.c (moxie_unwind_sp): Delete.
11229         (moxie_unwind_pc): Delete.
11230         (moxie_dummy_id): Delete.
11231         (moxie_gdbarch_init): Don't register deleted functions with
11232         gdbarch.
11233
11234 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11235
11236         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11237         (mn10300_unwind_pc): Delete.
11238         (mn10300_unwind_sp): Delete.
11239         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11240         mn10300_unwind_sp.
11241         (mn10300_frame_unwind_init): Don't register deleted functions with
11242         gdbarch.
11243
11244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11245
11246         * mep-tdep.c (mep_unwind_pc): Delete.
11247         (mep_unwind_sp): Delete.
11248         (mep_dummy_id): Delete.
11249         (mep_gdbarch_init): Don't register deleted functions with
11250         gdbarch.
11251
11252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11253
11254         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11255         (m68hc11_unwind_sp): Delete.
11256         (m68hc11_gdbarch_init): Don't register deleted functions with
11257         gdbarch.
11258
11259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11260
11261         * m32r-tdep.c (m32r_unwind_sp): Delete.
11262         (m32r_unwind_pc): Delete.
11263         (m32r_dummy_id): Delete.
11264         (m32r_gdbarch_init): Don't register deleted functions with
11265         gdbarch.
11266
11267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11268
11269         * m32c-tdep.c (m32c_unwind_pc): Delete.
11270         (m32c_unwind_sp): Delete.
11271         (m32c_dummy_id): Delete.
11272         (m32c_gdbarch_init): Don't register deleted functions with
11273         gdbarch.
11274
11275 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11276
11277         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11278         (lm32_unwind_pc): Delete.
11279         (lm32_dummy_id): Delete.
11280         (lm32_gdbarch_init): Don't register deleted functions with
11281         gdbarch.
11282
11283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11284
11285         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11286         (iq2000_unwind_pc): Delete.
11287         (iq2000_dummy_id): Delete.
11288         (iq2000_gdbarch_init): Don't register deleted functions with
11289         gdbarch.
11290
11291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11292
11293         * nds32-tdep.c (nds32_type_align): Delete.
11294         (nds32_push_dummy_call): Use type_align instead.
11295
11296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11297
11298         * arm-tdep.c (arm_type_align): Only handle vector override case.
11299         (arm_push_dummy_call): Use type_align.
11300         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11301
11302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11303
11304         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11305         case.
11306         (pass_on_stack): Use type_align.
11307         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11308         function.
11309
11310 2019-04-23  Tom Tromey  <tromey@adacore.com>
11311
11312         * dwarf2read.c (line_header::file_name_at): Remove unused
11313         overload.
11314
11315 2019-04-23  Tom de Vries  <tdevries@suse.de>
11316
11317         PR gdb/24438
11318         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11319         invocation.
11320
11321
11322 2019-03-27  Ali Tamur  <tamur@google.com>
11323
11324         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11325         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11326         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11327         (dwarf_expr_context::get_addr_index): Likewise
11328         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11329         (symbol_needs_eval_context::get_addr_index): Likewise
11330         (disassemble_dwarf_expression): Add DW_OP_addrx
11331         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11332         (read_cutu_die_from_dwo): Update comment
11333         (skip_one_die): Add DW_FORM_addrx
11334         (read_attribute_value): Likewise
11335         (var_decode_location): Add DW_OP_addrx
11336         (dwarf2_const_value_attr): Add DW_FORM_addrx
11337         (dump_die_shallow): Likewise
11338         (dwarf2_fetch_constant_bytes): Likewise
11339         (decode_locdesc): Add DW_OP_addrx
11340         (skip_form_bytes): Add DW_FORM_addrx
11341
11342 2019-04-22  Ali Tamur  <tamur@google.com>
11343
11344         * MAINTAINERS (Write After Approval): Add self.
11345
11346 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11347
11348         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11349         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11350         (open_symbol_file_object): Likewise.
11351         (svr4_default_sos): Add info parameter.
11352         (svr4_read_so_list): Likewise.
11353         (svr4_current_sos_direct): Adjust functions calls to pass down
11354         info.
11355         (svr4_current_sos_1): Add info parameter.
11356         (svr4_current_sos): Call get_svr4_info, pass info down to
11357         svr4_current_sos_1.
11358         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11359         get_svr4_info.
11360         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11361         get_svr4_info.
11362         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11363         to get_svr4_info.
11364         (probes_table_remove_objfile_probes): Likewise.
11365         (register_solib_event_probe): Add info parameter.
11366         (solist_update_incremental): Pass info parameter down to
11367         svr4_read_so_list.
11368         (disable_probes_interface): Add info parameter.
11369         (svr4_handle_solib_event): Pass current_program_space to
11370         get_svr4_info.  Adjust disable_probes_interface cleanup.
11371         (svr4_create_probe_breakpoints): Add info parameter, pass it
11372         down to register_solib_event_probe.
11373         (svr4_create_solib_event_breakpoints): Add info parameter,
11374         pass it down to svr4_create_probe_breakpoints.
11375         (enable_break): Pass info down to
11376         svr4_create_solib_event_breakpoints.
11377         (svr4_solib_create_inferior_hook): Pass current_program_space to
11378         get_svr4_info.
11379         (svr4_clear_solib): Likewise.
11380
11381 2019-04-22  Pedro Alves  <palves@redhat.com>
11382
11383         * solib-svr4.c (svr4_free_objfile_observer): New.
11384         (probe_and_action::objfile): New field.
11385         (probes_table_htab_remove_objfile_probes)
11386         (probes_table_remove_objfile_probes): New functions.
11387         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11388         in the new probe_and_action.  Don't store the probe in 'lookup'.
11389         (svr4_create_probe_breakpoints): Pass objfile to
11390         register_solib_event_probe.
11391         (_initialize_svr4_solib): Register a free_objfile observer.
11392
11393 2019-04-19  Tom Tromey  <tom@tromey.com>
11394
11395         * common/queue.h: Remove.
11396
11397 2019-04-19  Tom Tromey  <tom@tromey.com>
11398
11399         * event-loop.c: Don't include "common/queue.h".
11400
11401 2019-04-19  Tom Tromey  <tom@tromey.com>
11402
11403         * remote.c (remote_target): Use delete.
11404         * remote-notif.h: Include <list>, not "common/queue.h".
11405         (notif_client_p): Remove typedef.
11406         (remote_notif_state): Add constructor, destructor, initializer.
11407         <notif_queue>: Now a std::list.
11408         (remote_notif_state_xfree): Don't declare.
11409         * remote-notif.c (remote_notif_process, handle_notification)
11410         (remote_notif_state_allocate): Update.
11411         (~remote_notif_state): Rename from remote_notif_state_xfree.
11412
11413 2019-04-19  Tom Tromey  <tom@tromey.com>
11414
11415         * symfile.c (reread_symbols): Update.
11416         * objfiles.c (objfile_register_static_link)
11417         (objfile_lookup_static_link): Update
11418         (~objfile) Don't delete static_links.
11419         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11420
11421 2019-04-19  Tom Tromey  <tom@tromey.com>
11422
11423         * type-stack.h (struct type_stack) <insert>: Constify string.
11424         * type-stack.c (type_stack::insert): Constify string.
11425         * gdbtypes.h (lookup_template_type): Update.
11426         (address_space_name_to_int): Update.
11427         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11428         const.
11429         (lookup_template_type): Make name const.
11430         * c-exp.y: Update rules.
11431         (lex_one_token, classify_name, classify_inner_name)
11432         (c_print_token): Update.
11433         * p-exp.y: Update rules.
11434         (yylex): Update.
11435         * f-exp.y: Update rules.
11436         (yylex): Update.
11437         * d-exp.y: Update rules.
11438         (lex_one_token, classify_name, classify_inner_name): Update.
11439         * parse.c (write_dollar_variable, copy_name): Return std::string.
11440         * parser-defs.h (copy_name): Change return type.
11441         * m2-exp.y: Update rules.
11442         (yylex): Update.
11443         * go-exp.y (lex_one_token): Update.
11444         Update rules.
11445         (classify_unsafe_function, classify_packaged_name)
11446         (classify_name, yylex): Update.
11447
11448 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11449
11450         * configure.ac: add --enable-source-highlight switch.
11451         * configure: Regenerate.
11452         * top.c (print_gdb_version): plumb --enable-source-highlight
11453         status to "show configuration".
11454
11455 2019-04-19  Tom Tromey  <tromey@adacore.com>
11456
11457         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11458         Check ADA_TYPE_P.
11459         (empty_record, ada_template_to_fixed_record_type_1)
11460         (template_to_static_fixed_type)
11461         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11462         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11463         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11464         macros.
11465
11466 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11467
11468         PR symtab/24423:
11469         * source.c (print_source_lines_base): Advance "iter" when a
11470         control character is seen.
11471
11472 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11473
11474         * inferior.h (struct infcall_suspend_state_deleter):
11475         Catch exception in destructor to avoid crash.
11476
11477 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11478
11479         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11480         close to the add_com "shell".
11481
11482 2019-04-18  Tom Tromey  <tromey@adacore.com>
11483
11484         * process-stratum-target.h (class process_stratum_target)
11485         <stratum>: Add "final".
11486
11487 2019-04-17  Tom Tromey  <tromey@adacore.com>
11488
11489         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11490         against nullptr before use.
11491
11492 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11493
11494         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11495
11496 2019-04-17  Jim Wilson  <jimw@sifive.com>
11497             Andrew Burgess  <andrew.burgess@embecosm.com>
11498
11499         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11500         code read might fail, assume 4-byte breakpoint in that case.
11501
11502 2019-04-15  Leszek Swirski  <leszeks@google.com>
11503
11504         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11505         rather than a hand-rolled POD check when checking for forced MEMORY
11506         classification.
11507
11508 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11509
11510         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11511         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11512         function.
11513         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11514         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11515         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11516         declaration.
11517
11518 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11519
11520         * aarch64-linux-nat.c
11521         (aarch64_linux_nat_target::thread_architecture): Add override.
11522         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11523         each VQ.
11524
11525 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11526
11527         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11528
11529 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11530
11531         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11532         target types of size 96-bits, add some additional comments, and
11533         check that the builtin type we found was the correct size.
11534
11535 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11536
11537         * utils.c (prompt_for_continue): Don't restore the styling at the
11538         end, as applied_style has the wrong value.  This fixes styling in
11539         long lists of file names that are interrupted by the "Continue?"
11540         prompt.
11541
11542 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11543
11544         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11545         * c-lang.c (c_language_defn): Likewise.
11546         (cplus_language_defn): Likewise.
11547         (asm_language_defn): Likewise.
11548         (minimal_language_defn): Likewise.
11549         * d-lang.c (d_language_defn): Likewise.
11550         * f-lang.c (f_language_defn): Likewise.
11551         * go-lang.c (go_language_defn): Likewise.
11552         * language.c (unknown_language_defn): Likewise.
11553         (auto_language_defn): Likewise.
11554         * language.h (struct language_defn): Remove la_magic field.
11555         (LANG_MAGIC): Delete.
11556         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11557         * objc-lang.c (objc_language_defn): Likewise.
11558         * opencl-lang.c (opencl_language_defn): Likewise.
11559         * p-lang.c (pascal_language_defn): Likewise.
11560         * rust-lang.c (rust_language_defn): Likewise.
11561
11562 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11563
11564         * riscv-tdep.c (riscv_type_align): New function.
11565         (riscv_type_alignment): Delete.
11566         (riscv_arg_location): Use 'type_align'.
11567         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11568
11569 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11570
11571         * gdbtypes.c (type_align): A struct with no non-static fields also
11572         has alignment of 1.
11573
11574 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11575
11576         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11577         component to 0.
11578         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11579         member.
11580         (riscv_struct_info::analyse): New implementation using new
11581         analyse_inner member function.
11582         (riscv_struct_info::field_offset): New member function.
11583         (riscv_struct_info::m_offsets): New member variable.
11584         (riscv_struct_info::analyse_inner): New private member function,
11585         takes the old implementation of riscv_struct_info::analyse but
11586         extended to track field offsets.
11587         (riscv_call_arg_struct): Update the struct folding special cases
11588         to handle cases where empty C++ structs, which are non-zero
11589         length, are found.
11590         (riscv_arg_location): Initialise the length of each location, a
11591         non-zero length now indicates the location is in use.
11592         (riscv_push_dummy_call): Allow for the first location having a
11593         non-zero offset when setting up arguments.
11594         (riscv_return_value): Likewise, but for return values.
11595
11596 2019-04-11  Tom Tromey  <tromey@adacore.com>
11597
11598         * utils.c (internal_vproblem): Make "msg" const.
11599
11600 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11601
11602         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11603         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11604         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11605         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11606
11607 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11608
11609         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11610         function.
11611         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11612         of amd64_collect_native_gregset.
11613         (amd64_linux_nat_target::store_registers): Likewise.
11614
11615 2019-04-10  Tom Tromey  <tom@tromey.com>
11616
11617         * symtab.c (lookup_global_symbol_from_objfile)
11618         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11619         * objfiles.h (class separate_debug_iterator): New.
11620         (class separate_debug_range): New.
11621         (struct objfile) <separate_debug_objfiles>: New method.
11622         (objfile_separate_debug_iterate): Don't declare.
11623         * objfiles.c (separate_debug_iterator::operator++): Rename from
11624         objfile_separate_debug_iterate.
11625         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11626         iterator.
11627         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11628         iterator.
11629
11630 2019-04-10  Tom Tromey  <tom@tromey.com>
11631
11632         * symfile.c (reread_symbols): Remove old comment.
11633         * objfiles.c (free_all_objfiles): Fix a typo.
11634
11635 2019-04-10  Tom Tromey  <tom@tromey.com>
11636
11637         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11638         * minsyms.c (lookup_minimal_symbol): Use foreach.
11639         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11640         (lookup_minimal_symbol_solib_trampoline): Likewise.
11641         * symfile.c (reread_symbols): Use foreach.
11642
11643 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11644             Tom Tromey  <tromey@adacore.com>
11645
11646         PR rust/24414:
11647         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11648         (rust_lex_int_test): Change "value" to be LONGEST.
11649         (rust_lex_tests): Add test for long integer literal.
11650
11651 2019-04-09  Tom Tromey  <tromey@adacore.com>
11652
11653         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11654         to bool.
11655         (extended_remote_target::attach): Update.
11656         (remote_target::remote_notice_new_inferior): Update.
11657         (remote_target::add_current_inferior_and_thread): Update.
11658         * inferior.c (exit_inferior_1): Use "false".
11659         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11660
11661 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11662
11663         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11664         the "start" command.
11665
11666 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11667
11668         * python/py-inferior.c (infpy_thread_from_thread_handle):
11669         Adjust comments to reflect renaming of thread_from_thread_handle
11670         to thread_from_handle.  Adjust keywords.  Fix type error message.
11671         (inferior_object_methods): Add thread_from_handle.  Retain
11672         thread_from_thread_handle, but mark it as deprecated.
11673
11674 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11675
11676         * gdbthread.h (find_thread_by_handle): Revise declaration.
11677         * thread.c (find_thread_by_handle): Likewise.  Adjust
11678         implementation too.
11679         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11680         support for buffer objects as handles.
11681
11682 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11683
11684         * python/py-infthread.c (thpy_thread_handle): New function.
11685         (thread_object_methods): Register thpy_thread_handle.
11686
11687 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11688
11689         * gdbthread.h (thread_to_thread_handle): Declare.
11690         * thread.c (gdbtypes.h): Include.
11691         (thread_to_thread_handle): New function.
11692
11693         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11694         (target_thread_info_to_thread_handle): Declare.
11695         * target.c (target_thread_info_to_thread_handle): New function.
11696         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11697         * target-delegates.c: Regenerate.
11698
11699         * linux-thread-db.c (class thread_db_target): Add method
11700         thread_info_to_thread_handle.
11701         (thread_db_target::thread_info_to_thread_handle): Define.
11702         * remote.c (class remote_target): Add new method
11703         thread_info_to_thread_handle.
11704         (remote_target::thread_info_to_thread_handle): Define.
11705
11706 2019-04-08  Pedro Alves  <palves@redhat.com>
11707
11708         * common/common-exceptions.c (throw_exception): Don't create
11709         named object to throw; throw directly.
11710         (throw_it): Likewise.  Don't initialize gdb_exception::message
11711         here, with new; pass FMT and AP to the ctor instead.
11712         * common/common-exceptions.h: Include <string>.
11713         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11714         const char *, va_list)): New ctor.  Use std::make_shared.
11715         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11716         errors)): Delete.
11717         (gdb_exception_error::gdb_exception_error(enum errors, const char
11718         *, va_list)): New.
11719         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11720         Add assertion.
11721         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11722         errors)): Delete.
11723         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11724         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11725         Add assertion.
11726
11727 2019-04-08  Tom Tromey  <tom@tromey.com>
11728
11729         * valops.c (value_rtti_indirect_type): Replace throw_exception
11730         with throw.
11731         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11732         with throw.
11733         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11734         throw.
11735         * target.c (target_translate_tls_address): Replace throw_exception
11736         with throw.
11737         * stack.c (frame_apply_command_count): Replace throw_exception
11738         with throw.
11739         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11740         throw.
11741         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11742         with throw.
11743         * rs6000-tdep.c (rs6000_frame_cache)
11744         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11745         * remote.c: Replace throw_exception with throw.
11746         * record-full.c (record_full_message, record_full_wait_1)
11747         (record_full_restore): Replace throw_exception with throw.
11748         * record-btrace.c:
11749         (get_thread_current_frame_id, record_btrace_start_replaying)
11750         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11751         (cmd_record_btrace_start): Replace throw_exception with throw.
11752         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11753         throw.
11754         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11755         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11756         * linespec.c:
11757         (find_linespec_symbols): Replace throw_exception with throw.
11758         * infrun.c (displaced_step_prepare, resume): Replace
11759         throw_exception with throw.
11760         * infcmd.c (post_create_inferior): Replace throw_exception with
11761         throw.
11762         * inf-loop.c (inferior_event_handler): Replace throw_exception
11763         with throw.
11764         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11765         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11766         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11767         (get_prev_frame_always, get_frame_pc_if_available)
11768         (get_frame_address_in_block_if_available, get_frame_language):
11769         Replace throw_exception with throw.
11770         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11771         throw_exception with throw.
11772         * eval.c (fetch_subexp_value, evaluate_var_value)
11773         (evaluate_funcall, evaluate_subexp_standard): Replace
11774         throw_exception with throw.
11775         * dwarf2loc.c (call_site_find_chain)
11776         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11777         Replace throw_exception with throw.
11778         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11779         with throw.
11780         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11781         throw.
11782         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11783         * completer.c (complete_line_internal): Replace throw_exception
11784         with throw.
11785         * compile/compile-object-run.c (compile_object_run): Replace
11786         throw_exception with throw.
11787         * cli/cli-script.c (process_next_line): Replace throw_exception
11788         with throw.
11789         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11790         (btrace_enable, btrace_maint_update_pt_packets): Replace
11791         throw_exception with throw.
11792         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11793         throw_exception with throw.
11794         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11795         throw_exception with throw.
11796         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11797         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11798         * aarch64-tdep.c (aarch64_make_prologue_cache)
11799         (aarch64_make_stub_cache): Replace throw_exception with throw.
11800
11801 2019-04-08  Tom Tromey  <tom@tromey.com>
11802
11803         * common/common-exceptions.c (throw_exception): Rename from
11804         throw_exception_cxx.  Remove old copy.  Make argument const.
11805         (throw_it): Create and throw exception objects directly.
11806         * common/common-exceptions.h (throw_exception): Make argument
11807         const.
11808         (struct gdb_exception_error): Add constructor.
11809         (struct gdb_exception_quit): Add constructor.
11810
11811 2019-04-08  Tom Tromey  <tom@tromey.com>
11812
11813         * common/common-exceptions.h (exception_rethrow): Don't declare.
11814         (TRY_SJLJ): Update comment.
11815         (TRY, CATCH, END_CATCH): Remove.
11816         * common/common-exceptions.c (exception_rethrow): Remove.
11817
11818 2019-04-08  Tom Tromey  <tom@tromey.com>
11819
11820         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11821         Remove.
11822         (gdb_exception_error): Rename from
11823         gdb_exception_RETURN_MASK_ERROR.
11824         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11825         (gdb_quit_bad_alloc): Update.
11826         * aarch64-tdep.c: Update.
11827         * ada-lang.c: Update.
11828         * ada-typeprint.c: Update.
11829         * ada-valprint.c: Update.
11830         * amd64-tdep.c: Update.
11831         * arch-utils.c: Update.
11832         * break-catch-throw.c: Update.
11833         * breakpoint.c: Update.
11834         * btrace.c: Update.
11835         * c-varobj.c: Update.
11836         * cli/cli-cmds.c: Update.
11837         * cli/cli-interp.c: Update.
11838         * cli/cli-script.c: Update.
11839         * common/common-exceptions.c: Update.
11840         * common/new-op.c: Update.
11841         * common/selftest.c: Update.
11842         * compile/compile-c-symbols.c: Update.
11843         * compile/compile-cplus-symbols.c: Update.
11844         * compile/compile-object-load.c: Update.
11845         * compile/compile-object-run.c: Update.
11846         * completer.c: Update.
11847         * corelow.c: Update.
11848         * cp-abi.c: Update.
11849         * cp-support.c: Update.
11850         * cp-valprint.c: Update.
11851         * darwin-nat.c: Update.
11852         * disasm-selftests.c: Update.
11853         * dtrace-probe.c: Update.
11854         * dwarf-index-cache.c: Update.
11855         * dwarf-index-write.c: Update.
11856         * dwarf2-frame-tailcall.c: Update.
11857         * dwarf2-frame.c: Update.
11858         * dwarf2loc.c: Update.
11859         * dwarf2read.c: Update.
11860         * eval.c: Update.
11861         * event-loop.c: Update.
11862         * event-top.c: Update.
11863         * exec.c: Update.
11864         * f-valprint.c: Update.
11865         * fbsd-tdep.c: Update.
11866         * frame-unwind.c: Update.
11867         * frame.c: Update.
11868         * gdbtypes.c: Update.
11869         * gnu-v3-abi.c: Update.
11870         * guile/guile-internal.h: Update.
11871         * guile/scm-block.c: Update.
11872         * guile/scm-breakpoint.c: Update.
11873         * guile/scm-cmd.c: Update.
11874         * guile/scm-disasm.c: Update.
11875         * guile/scm-frame.c: Update.
11876         * guile/scm-lazy-string.c: Update.
11877         * guile/scm-math.c: Update.
11878         * guile/scm-param.c: Update.
11879         * guile/scm-ports.c: Update.
11880         * guile/scm-pretty-print.c: Update.
11881         * guile/scm-symbol.c: Update.
11882         * guile/scm-symtab.c: Update.
11883         * guile/scm-type.c: Update.
11884         * guile/scm-value.c: Update.
11885         * i386-linux-tdep.c: Update.
11886         * i386-tdep.c: Update.
11887         * inf-loop.c: Update.
11888         * infcall.c: Update.
11889         * infcmd.c: Update.
11890         * infrun.c: Update.
11891         * jit.c: Update.
11892         * language.c: Update.
11893         * linespec.c: Update.
11894         * linux-fork.c: Update.
11895         * linux-nat.c: Update.
11896         * linux-tdep.c: Update.
11897         * linux-thread-db.c: Update.
11898         * main.c: Update.
11899         * mi/mi-cmd-break.c: Update.
11900         * mi/mi-cmd-stack.c: Update.
11901         * mi/mi-interp.c: Update.
11902         * mi/mi-main.c: Update.
11903         * objc-lang.c: Update.
11904         * p-valprint.c: Update.
11905         * parse.c: Update.
11906         * ppc-linux-tdep.c: Update.
11907         * printcmd.c: Update.
11908         * python/py-arch.c: Update.
11909         * python/py-breakpoint.c: Update.
11910         * python/py-cmd.c: Update.
11911         * python/py-finishbreakpoint.c: Update.
11912         * python/py-frame.c: Update.
11913         * python/py-framefilter.c: Update.
11914         * python/py-gdb-readline.c: Update.
11915         * python/py-inferior.c: Update.
11916         * python/py-infthread.c: Update.
11917         * python/py-lazy-string.c: Update.
11918         * python/py-linetable.c: Update.
11919         * python/py-objfile.c: Update.
11920         * python/py-param.c: Update.
11921         * python/py-prettyprint.c: Update.
11922         * python/py-progspace.c: Update.
11923         * python/py-record-btrace.c: Update.
11924         * python/py-record.c: Update.
11925         * python/py-symbol.c: Update.
11926         * python/py-type.c: Update.
11927         * python/py-unwind.c: Update.
11928         * python/py-utils.c: Update.
11929         * python/py-value.c: Update.
11930         * python/python.c: Update.
11931         * record-btrace.c: Update.
11932         * record-full.c: Update.
11933         * remote-fileio.c: Update.
11934         * remote.c: Update.
11935         * riscv-tdep.c: Update.
11936         * rs6000-aix-tdep.c: Update.
11937         * rs6000-tdep.c: Update.
11938         * rust-exp.y: Update.
11939         * rust-lang.c: Update.
11940         * s390-tdep.c: Update.
11941         * selftest-arch.c: Update.
11942         * solib-dsbt.c: Update.
11943         * solib-frv.c: Update.
11944         * solib-spu.c: Update.
11945         * solib-svr4.c: Update.
11946         * solib.c: Update.
11947         * sparc64-linux-tdep.c: Update.
11948         * stack.c: Update.
11949         * symfile-mem.c: Update.
11950         * symmisc.c: Update.
11951         * target.c: Update.
11952         * thread.c: Update.
11953         * top.c: Update.
11954         * tracefile-tfile.c: Update.
11955         * tui/tui.c: Update.
11956         * typeprint.c: Update.
11957         * unittests/cli-utils-selftests.c: Update.
11958         * unittests/parse-connection-spec-selftests.c: Update.
11959         * valops.c: Update.
11960         * valprint.c: Update.
11961         * value.c: Update.
11962         * varobj.c: Update.
11963         * windows-nat.c: Update.
11964         * x86-linux-nat.c: Update.
11965         * xml-support.c: Update.
11966
11967 2019-04-08  Tom Tromey  <tom@tromey.com>
11968
11969         * xml-support.c: Use C++ exception handling.
11970         * x86-linux-nat.c: Use C++ exception handling.
11971         * windows-nat.c: Use C++ exception handling.
11972         * varobj.c: Use C++ exception handling.
11973         * value.c: Use C++ exception handling.
11974         * valprint.c: Use C++ exception handling.
11975         * valops.c: Use C++ exception handling.
11976         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11977         handling.
11978         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11979         * typeprint.c: Use C++ exception handling.
11980         * tui/tui.c: Use C++ exception handling.
11981         * tracefile-tfile.c: Use C++ exception handling.
11982         * top.c: Use C++ exception handling.
11983         * thread.c: Use C++ exception handling.
11984         * target.c: Use C++ exception handling.
11985         * symmisc.c: Use C++ exception handling.
11986         * symfile-mem.c: Use C++ exception handling.
11987         * stack.c: Use C++ exception handling.
11988         * sparc64-linux-tdep.c: Use C++ exception handling.
11989         * solib.c: Use C++ exception handling.
11990         * solib-svr4.c: Use C++ exception handling.
11991         * solib-spu.c: Use C++ exception handling.
11992         * solib-frv.c: Use C++ exception handling.
11993         * solib-dsbt.c: Use C++ exception handling.
11994         * selftest-arch.c: Use C++ exception handling.
11995         * s390-tdep.c: Use C++ exception handling.
11996         * rust-lang.c: Use C++ exception handling.
11997         * rust-exp.y: Use C++ exception handling.
11998         * rs6000-tdep.c: Use C++ exception handling.
11999         * rs6000-aix-tdep.c: Use C++ exception handling.
12000         * riscv-tdep.c: Use C++ exception handling.
12001         * remote.c: Use C++ exception handling.
12002         * remote-fileio.c: Use C++ exception handling.
12003         * record-full.c: Use C++ exception handling.
12004         * record-btrace.c: Use C++ exception handling.
12005         * python/python.c: Use C++ exception handling.
12006         * python/py-value.c: Use C++ exception handling.
12007         * python/py-utils.c: Use C++ exception handling.
12008         * python/py-unwind.c: Use C++ exception handling.
12009         * python/py-type.c: Use C++ exception handling.
12010         * python/py-symbol.c: Use C++ exception handling.
12011         * python/py-record.c: Use C++ exception handling.
12012         * python/py-record-btrace.c: Use C++ exception handling.
12013         * python/py-progspace.c: Use C++ exception handling.
12014         * python/py-prettyprint.c: Use C++ exception handling.
12015         * python/py-param.c: Use C++ exception handling.
12016         * python/py-objfile.c: Use C++ exception handling.
12017         * python/py-linetable.c: Use C++ exception handling.
12018         * python/py-lazy-string.c: Use C++ exception handling.
12019         * python/py-infthread.c: Use C++ exception handling.
12020         * python/py-inferior.c: Use C++ exception handling.
12021         * python/py-gdb-readline.c: Use C++ exception handling.
12022         * python/py-framefilter.c: Use C++ exception handling.
12023         * python/py-frame.c: Use C++ exception handling.
12024         * python/py-finishbreakpoint.c: Use C++ exception handling.
12025         * python/py-cmd.c: Use C++ exception handling.
12026         * python/py-breakpoint.c: Use C++ exception handling.
12027         * python/py-arch.c: Use C++ exception handling.
12028         * printcmd.c: Use C++ exception handling.
12029         * ppc-linux-tdep.c: Use C++ exception handling.
12030         * parse.c: Use C++ exception handling.
12031         * p-valprint.c: Use C++ exception handling.
12032         * objc-lang.c: Use C++ exception handling.
12033         * mi/mi-main.c: Use C++ exception handling.
12034         * mi/mi-interp.c: Use C++ exception handling.
12035         * mi/mi-cmd-stack.c: Use C++ exception handling.
12036         * mi/mi-cmd-break.c: Use C++ exception handling.
12037         * main.c: Use C++ exception handling.
12038         * linux-thread-db.c: Use C++ exception handling.
12039         * linux-tdep.c: Use C++ exception handling.
12040         * linux-nat.c: Use C++ exception handling.
12041         * linux-fork.c: Use C++ exception handling.
12042         * linespec.c: Use C++ exception handling.
12043         * language.c: Use C++ exception handling.
12044         * jit.c: Use C++ exception handling.
12045         * infrun.c: Use C++ exception handling.
12046         * infcmd.c: Use C++ exception handling.
12047         * infcall.c: Use C++ exception handling.
12048         * inf-loop.c: Use C++ exception handling.
12049         * i386-tdep.c: Use C++ exception handling.
12050         * i386-linux-tdep.c: Use C++ exception handling.
12051         * guile/scm-value.c: Use C++ exception handling.
12052         * guile/scm-type.c: Use C++ exception handling.
12053         * guile/scm-symtab.c: Use C++ exception handling.
12054         * guile/scm-symbol.c: Use C++ exception handling.
12055         * guile/scm-pretty-print.c: Use C++ exception handling.
12056         * guile/scm-ports.c: Use C++ exception handling.
12057         * guile/scm-param.c: Use C++ exception handling.
12058         * guile/scm-math.c: Use C++ exception handling.
12059         * guile/scm-lazy-string.c: Use C++ exception handling.
12060         * guile/scm-frame.c: Use C++ exception handling.
12061         * guile/scm-disasm.c: Use C++ exception handling.
12062         * guile/scm-cmd.c: Use C++ exception handling.
12063         * guile/scm-breakpoint.c: Use C++ exception handling.
12064         * guile/scm-block.c: Use C++ exception handling.
12065         * guile/guile-internal.h: Use C++ exception handling.
12066         * gnu-v3-abi.c: Use C++ exception handling.
12067         * gdbtypes.c: Use C++ exception handling.
12068         * frame.c: Use C++ exception handling.
12069         * frame-unwind.c: Use C++ exception handling.
12070         * fbsd-tdep.c: Use C++ exception handling.
12071         * f-valprint.c: Use C++ exception handling.
12072         * exec.c: Use C++ exception handling.
12073         * event-top.c: Use C++ exception handling.
12074         * event-loop.c: Use C++ exception handling.
12075         * eval.c: Use C++ exception handling.
12076         * dwarf2read.c: Use C++ exception handling.
12077         * dwarf2loc.c: Use C++ exception handling.
12078         * dwarf2-frame.c: Use C++ exception handling.
12079         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12080         * dwarf-index-write.c: Use C++ exception handling.
12081         * dwarf-index-cache.c: Use C++ exception handling.
12082         * dtrace-probe.c: Use C++ exception handling.
12083         * disasm-selftests.c: Use C++ exception handling.
12084         * darwin-nat.c: Use C++ exception handling.
12085         * cp-valprint.c: Use C++ exception handling.
12086         * cp-support.c: Use C++ exception handling.
12087         * cp-abi.c: Use C++ exception handling.
12088         * corelow.c: Use C++ exception handling.
12089         * completer.c: Use C++ exception handling.
12090         * compile/compile-object-run.c: Use C++ exception handling.
12091         * compile/compile-object-load.c: Use C++ exception handling.
12092         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12093         * compile/compile-c-symbols.c: Use C++ exception handling.
12094         * common/selftest.c: Use C++ exception handling.
12095         * common/new-op.c: Use C++ exception handling.
12096         * cli/cli-script.c: Use C++ exception handling.
12097         * cli/cli-interp.c: Use C++ exception handling.
12098         * cli/cli-cmds.c: Use C++ exception handling.
12099         * c-varobj.c: Use C++ exception handling.
12100         * btrace.c: Use C++ exception handling.
12101         * breakpoint.c: Use C++ exception handling.
12102         * break-catch-throw.c: Use C++ exception handling.
12103         * arch-utils.c: Use C++ exception handling.
12104         * amd64-tdep.c: Use C++ exception handling.
12105         * ada-valprint.c: Use C++ exception handling.
12106         * ada-typeprint.c: Use C++ exception handling.
12107         * ada-lang.c: Use C++ exception handling.
12108         * aarch64-tdep.c: Use C++ exception handling.
12109
12110 2019-04-08  Tom Tromey  <tom@tromey.com>
12111
12112         * xml-support.c (gdb_xml_parser::parse): Update.
12113         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12114         * value.c (show_convenience): Update.
12115         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12116         (test_parse_flags_qcs): Update.
12117         * thread.c (thr_try_catch_cmd): Update.
12118         * target.c (target_translate_tls_address): Update.
12119         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12120         (info_frame_command_core, frame_apply_command_count): Update.
12121         * rust-exp.y (rust_lex_exception_test): Update.
12122         * riscv-tdep.c (riscv_print_one_register_info): Update.
12123         * remote.c (remote_target::enable_btrace): Update.
12124         * record-btrace.c (record_btrace_enable_warn): Update.
12125         * python/py-utils.c (gdbpy_convert_exception): Update.
12126         * printcmd.c (do_one_display, print_variable_and_value): Update.
12127         * mi/mi-main.c (mi_print_exception): Update.
12128         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12129         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12130         * linux-nat.c (linux_nat_target::attach): Update.
12131         * linux-fork.c (class scoped_switch_fork_info): Update.
12132         * infrun.c (displaced_step_prepare): Update.
12133         * infcall.c (call_function_by_hand_dummy): Update.
12134         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12135         * gnu-v3-abi.c (print_one_vtable): Update.
12136         * frame.c (get_prev_frame_always): Update.
12137         * f-valprint.c (info_common_command_for_block): Update.
12138         * exec.c (try_open_exec_file): Update.
12139         * exceptions.c (print_exception, exception_print)
12140         (exception_fprintf, exception_print_same): Update.
12141         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12142         * dwarf-index-cache.c (index_cache::store)
12143         (index_cache::lookup_gdb_index): Update.
12144         * darwin-nat.c (maybe_cache_shell): Update.
12145         * cp-valprint.c (cp_print_value_fields): Update.
12146         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12147         (gcc_cplus_symbol_address): Update.
12148         * compile/compile-c-symbols.c (gcc_convert_symbol)
12149         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12150         * common/selftest.c: Update.
12151         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12152         a std::string.
12153         (exception_try_scope_entry, exception_try_scope_exit): Don't
12154         declare.
12155         (struct exception_try_scope): Remove.
12156         (TRY): Don't use exception_try_scope.
12157         (struct gdb_exception): Add constructor, operator=.
12158         <what>: New method.
12159         (struct gdb_exception_RETURN_MASK_ALL)
12160         (struct gdb_exception_RETURN_MASK_ERROR)
12161         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12162         (struct gdb_quit_bad_alloc): Update.
12163         * common/common-exceptions.c (exception_none): Change
12164         initializer.
12165         (struct catcher) <state, exception>: Initialize inline.
12166         <prev>: Remove member.
12167         (current_catcher): Remove.
12168         (catchers): New global.
12169         (exceptions_state_mc_init): Simplify.
12170         (catcher_pop): Remove.
12171         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12172         (try_scope_depth, exception_try_scope_entry)
12173         (exception_try_scope_exit): Remove.
12174         (throw_exception_sjlj): Update.
12175         (exception_messages, exception_messages_size): Remove.
12176         (throw_it): Simplify.
12177         (gdb_exception_sliced_copy): Remove.
12178         (throw_exception_cxx): Update.
12179         * cli/cli-script.c (script_from_file): Update.
12180         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12181         Update.
12182         * ada-valprint.c (ada_val_print): Update.
12183         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12184         (create_excep_cond_exprs): Update.
12185
12186 2019-04-08  Tom Tromey  <tom@tromey.com>
12187
12188         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12189         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12190         (TRY, CATCH, END_CATCH): Remove some definitions.
12191         * common/common-exceptions.c: Don't use GDB_XCPT.
12192         (catcher_list_size): Remove.
12193         (throw_exception, throw_it): Simplify.
12194
12195 2019-04-05  Tom Tromey  <tom@tromey.com>
12196
12197         Revert the header-sorting patch.
12198         * ft32-tdep.c: Revert.
12199         * frv-tdep.c: Revert.
12200         * frv-linux-tdep.c: Revert.
12201         * frame.c: Revert.
12202         * frame-unwind.c: Revert.
12203         * frame-base.c: Revert.
12204         * fork-child.c: Revert.
12205         * findvar.c: Revert.
12206         * findcmd.c: Revert.
12207         * filesystem.c: Revert.
12208         * filename-seen-cache.h: Revert.
12209         * filename-seen-cache.c: Revert.
12210         * fbsd-tdep.c: Revert.
12211         * fbsd-nat.h: Revert.
12212         * fbsd-nat.c: Revert.
12213         * f-valprint.c: Revert.
12214         * f-typeprint.c: Revert.
12215         * f-lang.c: Revert.
12216         * extension.h: Revert.
12217         * extension.c: Revert.
12218         * extension-priv.h: Revert.
12219         * expprint.c: Revert.
12220         * exec.h: Revert.
12221         * exec.c: Revert.
12222         * exceptions.c: Revert.
12223         * event-top.c: Revert.
12224         * event-loop.c: Revert.
12225         * eval.c: Revert.
12226         * elfread.c: Revert.
12227         * dwarf2read.h: Revert.
12228         * dwarf2read.c: Revert.
12229         * dwarf2loc.c: Revert.
12230         * dwarf2expr.h: Revert.
12231         * dwarf2expr.c: Revert.
12232         * dwarf2-frame.c: Revert.
12233         * dwarf2-frame-tailcall.c: Revert.
12234         * dwarf-index-write.h: Revert.
12235         * dwarf-index-write.c: Revert.
12236         * dwarf-index-common.c: Revert.
12237         * dwarf-index-cache.h: Revert.
12238         * dwarf-index-cache.c: Revert.
12239         * dummy-frame.c: Revert.
12240         * dtrace-probe.c: Revert.
12241         * disasm.h: Revert.
12242         * disasm.c: Revert.
12243         * disasm-selftests.c: Revert.
12244         * dictionary.c: Revert.
12245         * dicos-tdep.c: Revert.
12246         * demangle.c: Revert.
12247         * dcache.h: Revert.
12248         * dcache.c: Revert.
12249         * darwin-nat.h: Revert.
12250         * darwin-nat.c: Revert.
12251         * darwin-nat-info.c: Revert.
12252         * d-valprint.c: Revert.
12253         * d-namespace.c: Revert.
12254         * d-lang.c: Revert.
12255         * ctf.c: Revert.
12256         * csky-tdep.c: Revert.
12257         * csky-linux-tdep.c: Revert.
12258         * cris-tdep.c: Revert.
12259         * cris-linux-tdep.c: Revert.
12260         * cp-valprint.c: Revert.
12261         * cp-support.c: Revert.
12262         * cp-namespace.c: Revert.
12263         * cp-abi.c: Revert.
12264         * corelow.c: Revert.
12265         * corefile.c: Revert.
12266         * continuations.c: Revert.
12267         * completer.h: Revert.
12268         * completer.c: Revert.
12269         * complaints.c: Revert.
12270         * coffread.c: Revert.
12271         * coff-pe-read.c: Revert.
12272         * cli-out.h: Revert.
12273         * cli-out.c: Revert.
12274         * charset.c: Revert.
12275         * c-varobj.c: Revert.
12276         * c-valprint.c: Revert.
12277         * c-typeprint.c: Revert.
12278         * c-lang.c: Revert.
12279         * buildsym.c: Revert.
12280         * buildsym-legacy.c: Revert.
12281         * build-id.h: Revert.
12282         * build-id.c: Revert.
12283         * btrace.c: Revert.
12284         * bsd-uthread.c: Revert.
12285         * breakpoint.h: Revert.
12286         * breakpoint.c: Revert.
12287         * break-catch-throw.c: Revert.
12288         * break-catch-syscall.c: Revert.
12289         * break-catch-sig.c: Revert.
12290         * blockframe.c: Revert.
12291         * block.c: Revert.
12292         * bfin-tdep.c: Revert.
12293         * bfin-linux-tdep.c: Revert.
12294         * bfd-target.c: Revert.
12295         * bcache.c: Revert.
12296         * ax-general.c: Revert.
12297         * ax-gdb.h: Revert.
12298         * ax-gdb.c: Revert.
12299         * avr-tdep.c: Revert.
12300         * auxv.c: Revert.
12301         * auto-load.c: Revert.
12302         * arm-wince-tdep.c: Revert.
12303         * arm-tdep.c: Revert.
12304         * arm-symbian-tdep.c: Revert.
12305         * arm-pikeos-tdep.c: Revert.
12306         * arm-obsd-tdep.c: Revert.
12307         * arm-nbsd-tdep.c: Revert.
12308         * arm-nbsd-nat.c: Revert.
12309         * arm-linux-tdep.c: Revert.
12310         * arm-linux-nat.c: Revert.
12311         * arm-fbsd-tdep.c: Revert.
12312         * arm-fbsd-nat.c: Revert.
12313         * arm-bsd-tdep.c: Revert.
12314         * arch-utils.c: Revert.
12315         * arc-tdep.c: Revert.
12316         * arc-newlib-tdep.c: Revert.
12317         * annotate.h: Revert.
12318         * annotate.c: Revert.
12319         * amd64-windows-tdep.c: Revert.
12320         * amd64-windows-nat.c: Revert.
12321         * amd64-tdep.c: Revert.
12322         * amd64-sol2-tdep.c: Revert.
12323         * amd64-obsd-tdep.c: Revert.
12324         * amd64-obsd-nat.c: Revert.
12325         * amd64-nbsd-tdep.c: Revert.
12326         * amd64-nbsd-nat.c: Revert.
12327         * amd64-nat.c: Revert.
12328         * amd64-linux-tdep.c: Revert.
12329         * amd64-linux-nat.c: Revert.
12330         * amd64-fbsd-tdep.c: Revert.
12331         * amd64-fbsd-nat.c: Revert.
12332         * amd64-dicos-tdep.c: Revert.
12333         * amd64-darwin-tdep.c: Revert.
12334         * amd64-bsd-nat.c: Revert.
12335         * alpha-tdep.c: Revert.
12336         * alpha-obsd-tdep.c: Revert.
12337         * alpha-nbsd-tdep.c: Revert.
12338         * alpha-mdebug-tdep.c: Revert.
12339         * alpha-linux-tdep.c: Revert.
12340         * alpha-linux-nat.c: Revert.
12341         * alpha-bsd-tdep.c: Revert.
12342         * alpha-bsd-nat.c: Revert.
12343         * aix-thread.c: Revert.
12344         * agent.c: Revert.
12345         * addrmap.c: Revert.
12346         * ada-varobj.c: Revert.
12347         * ada-valprint.c: Revert.
12348         * ada-typeprint.c: Revert.
12349         * ada-tasks.c: Revert.
12350         * ada-lang.c: Revert.
12351         * aarch64-tdep.c: Revert.
12352         * aarch64-ravenscar-thread.c: Revert.
12353         * aarch64-newlib-tdep.c: Revert.
12354         * aarch64-linux-tdep.c: Revert.
12355         * aarch64-linux-nat.c: Revert.
12356         * aarch64-fbsd-tdep.c: Revert.
12357         * aarch64-fbsd-nat.c: Revert.
12358         * aarch32-linux-nat.c: Revert.
12359
12360 2019-04-05  Tom Tromey  <tom@tromey.com>
12361
12362         * ft32-tdep.c: Sort headers.
12363         * frv-tdep.c: Sort headers.
12364         * frv-linux-tdep.c: Sort headers.
12365         * frame.c: Sort headers.
12366         * frame-unwind.c: Sort headers.
12367         * frame-base.c: Sort headers.
12368         * fork-child.c: Sort headers.
12369         * findvar.c: Sort headers.
12370         * findcmd.c: Sort headers.
12371         * filesystem.c: Sort headers.
12372         * filename-seen-cache.h: Sort headers.
12373         * filename-seen-cache.c: Sort headers.
12374         * fbsd-tdep.c: Sort headers.
12375         * fbsd-nat.h: Sort headers.
12376         * fbsd-nat.c: Sort headers.
12377         * f-valprint.c: Sort headers.
12378         * f-typeprint.c: Sort headers.
12379         * f-lang.c: Sort headers.
12380         * extension.h: Sort headers.
12381         * extension.c: Sort headers.
12382         * extension-priv.h: Sort headers.
12383         * expprint.c: Sort headers.
12384         * exec.h: Sort headers.
12385         * exec.c: Sort headers.
12386         * exceptions.c: Sort headers.
12387         * event-top.c: Sort headers.
12388         * event-loop.c: Sort headers.
12389         * eval.c: Sort headers.
12390         * elfread.c: Sort headers.
12391         * dwarf2read.h: Sort headers.
12392         * dwarf2read.c: Sort headers.
12393         * dwarf2loc.c: Sort headers.
12394         * dwarf2expr.h: Sort headers.
12395         * dwarf2expr.c: Sort headers.
12396         * dwarf2-frame.c: Sort headers.
12397         * dwarf2-frame-tailcall.c: Sort headers.
12398         * dwarf-index-write.h: Sort headers.
12399         * dwarf-index-write.c: Sort headers.
12400         * dwarf-index-common.c: Sort headers.
12401         * dwarf-index-cache.h: Sort headers.
12402         * dwarf-index-cache.c: Sort headers.
12403         * dummy-frame.c: Sort headers.
12404         * dtrace-probe.c: Sort headers.
12405         * disasm.h: Sort headers.
12406         * disasm.c: Sort headers.
12407         * disasm-selftests.c: Sort headers.
12408         * dictionary.c: Sort headers.
12409         * dicos-tdep.c: Sort headers.
12410         * demangle.c: Sort headers.
12411         * dcache.h: Sort headers.
12412         * dcache.c: Sort headers.
12413         * darwin-nat.h: Sort headers.
12414         * darwin-nat.c: Sort headers.
12415         * darwin-nat-info.c: Sort headers.
12416         * d-valprint.c: Sort headers.
12417         * d-namespace.c: Sort headers.
12418         * d-lang.c: Sort headers.
12419         * ctf.c: Sort headers.
12420         * csky-tdep.c: Sort headers.
12421         * csky-linux-tdep.c: Sort headers.
12422         * cris-tdep.c: Sort headers.
12423         * cris-linux-tdep.c: Sort headers.
12424         * cp-valprint.c: Sort headers.
12425         * cp-support.c: Sort headers.
12426         * cp-namespace.c: Sort headers.
12427         * cp-abi.c: Sort headers.
12428         * corelow.c: Sort headers.
12429         * corefile.c: Sort headers.
12430         * continuations.c: Sort headers.
12431         * completer.h: Sort headers.
12432         * completer.c: Sort headers.
12433         * complaints.c: Sort headers.
12434         * coffread.c: Sort headers.
12435         * coff-pe-read.c: Sort headers.
12436         * cli-out.h: Sort headers.
12437         * cli-out.c: Sort headers.
12438         * charset.c: Sort headers.
12439         * c-varobj.c: Sort headers.
12440         * c-valprint.c: Sort headers.
12441         * c-typeprint.c: Sort headers.
12442         * c-lang.c: Sort headers.
12443         * buildsym.c: Sort headers.
12444         * buildsym-legacy.c: Sort headers.
12445         * build-id.h: Sort headers.
12446         * build-id.c: Sort headers.
12447         * btrace.c: Sort headers.
12448         * bsd-uthread.c: Sort headers.
12449         * breakpoint.h: Sort headers.
12450         * breakpoint.c: Sort headers.
12451         * break-catch-throw.c: Sort headers.
12452         * break-catch-syscall.c: Sort headers.
12453         * break-catch-sig.c: Sort headers.
12454         * blockframe.c: Sort headers.
12455         * block.c: Sort headers.
12456         * bfin-tdep.c: Sort headers.
12457         * bfin-linux-tdep.c: Sort headers.
12458         * bfd-target.c: Sort headers.
12459         * bcache.c: Sort headers.
12460         * ax-general.c: Sort headers.
12461         * ax-gdb.h: Sort headers.
12462         * ax-gdb.c: Sort headers.
12463         * avr-tdep.c: Sort headers.
12464         * auxv.c: Sort headers.
12465         * auto-load.c: Sort headers.
12466         * arm-wince-tdep.c: Sort headers.
12467         * arm-tdep.c: Sort headers.
12468         * arm-symbian-tdep.c: Sort headers.
12469         * arm-pikeos-tdep.c: Sort headers.
12470         * arm-obsd-tdep.c: Sort headers.
12471         * arm-nbsd-tdep.c: Sort headers.
12472         * arm-nbsd-nat.c: Sort headers.
12473         * arm-linux-tdep.c: Sort headers.
12474         * arm-linux-nat.c: Sort headers.
12475         * arm-fbsd-tdep.c: Sort headers.
12476         * arm-fbsd-nat.c: Sort headers.
12477         * arm-bsd-tdep.c: Sort headers.
12478         * arch-utils.c: Sort headers.
12479         * arc-tdep.c: Sort headers.
12480         * arc-newlib-tdep.c: Sort headers.
12481         * annotate.h: Sort headers.
12482         * annotate.c: Sort headers.
12483         * amd64-windows-tdep.c: Sort headers.
12484         * amd64-windows-nat.c: Sort headers.
12485         * amd64-tdep.c: Sort headers.
12486         * amd64-sol2-tdep.c: Sort headers.
12487         * amd64-obsd-tdep.c: Sort headers.
12488         * amd64-obsd-nat.c: Sort headers.
12489         * amd64-nbsd-tdep.c: Sort headers.
12490         * amd64-nbsd-nat.c: Sort headers.
12491         * amd64-nat.c: Sort headers.
12492         * amd64-linux-tdep.c: Sort headers.
12493         * amd64-linux-nat.c: Sort headers.
12494         * amd64-fbsd-tdep.c: Sort headers.
12495         * amd64-fbsd-nat.c: Sort headers.
12496         * amd64-dicos-tdep.c: Sort headers.
12497         * amd64-darwin-tdep.c: Sort headers.
12498         * amd64-bsd-nat.c: Sort headers.
12499         * alpha-tdep.c: Sort headers.
12500         * alpha-obsd-tdep.c: Sort headers.
12501         * alpha-nbsd-tdep.c: Sort headers.
12502         * alpha-mdebug-tdep.c: Sort headers.
12503         * alpha-linux-tdep.c: Sort headers.
12504         * alpha-linux-nat.c: Sort headers.
12505         * alpha-bsd-tdep.c: Sort headers.
12506         * alpha-bsd-nat.c: Sort headers.
12507         * aix-thread.c: Sort headers.
12508         * agent.c: Sort headers.
12509         * addrmap.c: Sort headers.
12510         * ada-varobj.c: Sort headers.
12511         * ada-valprint.c: Sort headers.
12512         * ada-typeprint.c: Sort headers.
12513         * ada-tasks.c: Sort headers.
12514         * ada-lang.c: Sort headers.
12515         * aarch64-tdep.c: Sort headers.
12516         * aarch64-ravenscar-thread.c: Sort headers.
12517         * aarch64-newlib-tdep.c: Sort headers.
12518         * aarch64-linux-tdep.c: Sort headers.
12519         * aarch64-linux-nat.c: Sort headers.
12520         * aarch64-fbsd-tdep.c: Sort headers.
12521         * aarch64-fbsd-nat.c: Sort headers.
12522         * aarch32-linux-nat.c: Sort headers.
12523
12524 2019-04-04  Tom Tromey  <tom@tromey.com>
12525
12526         * varobj.c (varobj_create): Update.
12527         * rust-exp.y (struct rust_parser) <update_innermost_block,
12528         lookup_symbol>: New methods.
12529         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12530         Rename.
12531         (rust_parser::rust_lookup_type)
12532         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12533         * printcmd.c (display_command, do_one_display): Update.
12534         * parser-defs.h (struct parser_state) <parser_state>: Add
12535         "tracker" parameter.
12536         (block_tracker): New member.
12537         (class innermost_block_tracker) <innermost_block_tracker>: Add
12538         "types" parameter.
12539         <reset>: Remove method.
12540         (innermost_block): Don't declare.
12541         (null_post_parser): Update.
12542         * parse.c (innermost_block): Remove global.
12543         (write_dollar_variable): Update.
12544         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12545         Remove "tracker_types" parameter.
12546         (parse_expression): Add "tracker" parameter.
12547         (parse_expression_for_completion): Update.
12548         (null_post_parser): Add "tracker" parameter.
12549         * p-exp.y: Update rules.
12550         * m2-exp.y: Update rules.
12551         * language.h (struct language_defn) <la_post_parser>: Add
12552         "tracker" parameter.
12553         * go-exp.y: Update rules.
12554         * f-exp.y: Update rules.
12555         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12556         parameter.
12557         * d-exp.y: Update rules.
12558         * c-exp.y: Update rules.
12559         * breakpoint.c (set_breakpoint_condition): Create an
12560         innermost_block_tracker.
12561         (watch_command_1): Likewise.
12562         * ada-lang.c (resolve): Add "tracker" parameter.
12563         (resolve_subexp): Likewise.
12564         * ada-exp.y (write_var_from_sym): Update.
12565
12566 2019-04-04  Tom Tromey  <tom@tromey.com>
12567
12568         * type-stack.h: New file.
12569         * type-stack.c: New file.
12570         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12571         type-stack.h.
12572         (insert_into_type_stack, insert_type, push_type, push_type_int)
12573         (insert_type_address_space, pop_type, pop_type_int)
12574         (pop_typelist, pop_type_stack, append_type_stack)
12575         (push_type_stack, get_type_stack, push_typelist)
12576         (follow_type_instance_flags, follow_types): Don't declare.
12577         * parse.c (type_stack): Remove global.
12578         (parse_exp_in_context): Update.
12579         (insert_into_type_stack, insert_type, push_type, push_type_int)
12580         (insert_type_address_space, pop_type, pop_type_int)
12581         (pop_typelist, pop_type_stack, append_type_stack)
12582         (push_type_stack, get_type_stack, push_typelist)
12583         (follow_type_instance_flags, follow_types): Remove (moved to
12584         type-stack.c).
12585         * f-exp.y (type_stack): New global.
12586         Update rules.
12587         (push_kind_type, f_parse): Update.
12588         * d-exp.y (type_stack): New global.
12589         Update rules.
12590         (d_parse): Update.
12591         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12592         Update rules.
12593         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12594         (HFILES_NO_SRCDIR): Add type-stack.h.
12595
12596 2019-04-04  Tom Tromey  <tom@tromey.com>
12597
12598         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12599         (rust_parser::convert_ast_to_expression, rust_parse)
12600         (rust_lex_test_completion, rust_lex_tests): Update.
12601         * parser-defs.h (struct expr_completion_state): New.
12602         (struct parser_state) <parser_state>: Add completion parameter.
12603         <mark_struct_expression, mark_completion_tag>: New methods.
12604         <parse_completion, m_completion_state>: New members.
12605         (prefixify_expression, null_post_parser): Update.
12606         (mark_struct_expression, mark_completion_tag): Don't declare.
12607         * parse.c (parse_completion, expout_last_struct)
12608         (expout_tag_completion_type, expout_completion_name): Remove
12609         globals.
12610         (parser_state::mark_struct_expression)
12611         (parser_state::mark_completion_tag): Now methods.
12612         (prefixify_expression): Add last_struct parameter.
12613         (prefixify_subexp): Likewise.
12614         (parse_exp_1): Update.
12615         (parse_exp_in_context): Add cstate parameter.  Update.
12616         (parse_expression_for_completion): Create an
12617         expr_completion_state.
12618         (null_post_parser): Add "completion" parameter.
12619         * p-exp.y: Update rules.
12620         (yylex): Update.
12621         * language.h (struct language_defn) <la_post_parser>: Add
12622         "completing" parameter.
12623         * go-exp.y: Update rules.
12624         (lex_one_token): Update.
12625         * expression.h (parse_completion): Don't declare.
12626         * d-exp.y: Update rules.
12627         (lex_one_token): Update rules.
12628         * c-exp.y: Update rules.
12629         (lex_one_token): Update.
12630         * ada-lang.c (resolve): Add "parse_completion" parameter.
12631         (resolve_subexp): Likewise.
12632         (ada_resolve_function): Likewise.
12633
12634 2019-04-04  Tom Tromey  <tom@tromey.com>
12635
12636         * parser-defs.h (struct parser_state) <start_arglist,
12637         end_arglist>: New methods.
12638         <arglist_len, m_funcall_chain>: New members.
12639         (arglist_len, start_arglist, end_arglist): Don't declare.
12640         * parse.c (arglist_len, funcall_chain): Remove global.
12641         (start_arglist, end_arglist): Remove functions.
12642         (parse_exp_in_context): Update.
12643         * p-exp.y: Update rules.
12644         * m2-exp.y: Update rules.
12645         * go-exp.y: Update rules.
12646         * f-exp.y: Update rules.
12647         * d-exp.y: Update rules.
12648         * c-exp.y: Update rules.
12649
12650 2019-04-04  Tom Tromey  <tom@tromey.com>
12651
12652         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12653         lex_operator, push_back>: New methods.
12654         Update all rules.
12655         (rust_parser::lex_hex, lex_escape): Rename and update.
12656         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12657         (rust_parser::lex_operator): Rename and update.
12658         (rust_parser::lex_number, rustyylex, rustyyerror)
12659         (rust_lex_test_init, rust_lex_test_sequence)
12660         (rust_lex_test_push_back, rust_lex_tests): Update.
12661         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12662         parameter.
12663         <lexptr, prev_lexptr>: New members.
12664         (lexptr, prev_lexptr): Don't declare.
12665         * parse.c (lexptr, prev_lexptr): Remove globals.
12666         (parse_exp_in_context): Update.
12667         * p-exp.y (yylex, yyerror): Update.
12668         * m2-exp.y (parse_number, yylex, yyerror): Update.
12669         * go-exp.y (lex_one_token, yyerror): Update.
12670         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12671         * d-exp.y (lex_one_token, yyerror): Update.
12672         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12673         (lex_one_token, yyerror): Update.
12674         * ada-lex.l (YY_INPUT): Update.
12675         (rewind_to_char): Update.
12676         * ada-exp.y (yyerror): Update.
12677
12678 2019-04-04  Tom Tromey  <tom@tromey.com>
12679
12680         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12681         * parser-defs.h (struct parser_state) <parser_state>: Add new
12682         parameter.
12683         <comma_terminates>: New member.
12684         (comma_terminates): Don't declare global.
12685         * parse.c (comma_terminates): Remove global.
12686         (parse_exp_in_context): Update.
12687         * p-exp.y (yylex): Update.
12688         * m2-exp.y (yylex): Update.
12689         * go-exp.y (lex_one_token): Update.
12690         * f-exp.y (yylex): Update.
12691         * d-exp.y (lex_one_token): Update.
12692         * c-exp.y (lex_one_token): Update.
12693         * ada-lex.l: Update.
12694
12695 2019-04-04  Tom Tromey  <tom@tromey.com>
12696
12697         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12698         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12699         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12700         * parser-defs.h (paren_depth): Don't declare.
12701         * parse.c (paren_depth): Remove global.
12702         (parse_exp_in_context): Update.
12703         * p-exp.y (paren_depth): New global.
12704         (pascal_parse): Initialize it.
12705         * m2-exp.y (paren_depth): New global.
12706         (m2_parse): Initialize it.
12707         * go-exp.y (paren_depth): New global.
12708         (go_parse): Initialize it.
12709         * f-exp.y (paren_depth): New global.
12710         (f_parse): Initialize it.
12711         * d-exp.y (paren_depth): New global.
12712         (d_parse): Initialize it.
12713         * c-exp.y (paren_depth): New global.
12714         (c_parse): Initialize it.
12715         * ada-lex.l (paren_depth): New global.
12716         (lexer_init): Initialize it.
12717
12718 2019-04-04  Tom Tromey  <tom@tromey.com>
12719
12720         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12721         (rust_parser::convert_ast_to_type)
12722         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12723         * parser-defs.h (struct parser_state) <parser_state>: Add
12724         parameters.  Initialize new members.
12725         <expression_context_block, expression_context_pc>: New members.
12726         * parse.c (expression_context_block, expression_context_pc):
12727         Remove globals.
12728         (parse_exp_in_context): Update.
12729         * p-exp.y: Update all rules.
12730         (yylex): Update.
12731         * m2-exp.y: Update all rules.
12732         (yylex): Update.
12733         * go-exp.y (yylex): Update.
12734         * f-exp.y (yylex): Update.
12735         * d-exp.y: Update all rules.
12736         (yylex): Update.
12737         * c-exp.y: Update all rules.
12738         (lex_one_token, classify_name, yylex, c_parse): Update.
12739         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12740
12741 2019-04-04  Tom Tromey  <tom@tromey.com>
12742
12743         * gdbarch.h, gdbarch.c: Rebuild.
12744         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12745         * stap-probe.h:
12746         (struct stap_parse_info): Replace "parser_state" with
12747         "expr_builder".
12748         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12749         (parser_state): New class.
12750         * parse.c (expr_builder): Rename.
12751         (expr_builder::release): Rename.
12752         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12753         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12754         (write_exp_elt_longcst, write_exp_elt_floatcst)
12755         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12756         (write_exp_string_vector, write_exp_bitstring)
12757         (write_exp_msymbol, mark_struct_expression)
12758         (write_dollar_variable)
12759         (insert_type_address_space, increase_expout_size): Replace
12760         "parser_state" with "expr_builder".
12761         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12762         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12763         "parser_state" with "expr_builder".
12764
12765 2019-04-04  Tom Tromey  <tom@tromey.com>
12766
12767         * rust-exp.y: Replace "parse_language" with method call.
12768         * p-exp.y:
12769         (yylex): Replace "parse_language" with method call.
12770         * m2-exp.y:
12771         (yylex): Replace "parse_language" with method call.
12772         * go-exp.y (classify_name): Replace "parse_language" with method
12773         call.
12774         * f-exp.y (yylex): Replace "parse_language" with method call.
12775         * d-exp.y (lex_one_token): Replace "parse_language" with method
12776         call.
12777         * c-exp.y:
12778         (lex_one_token, classify_name, yylex): Replace "parse_language"
12779         with method call.
12780         * ada-exp.y (find_primitive_type, type_char)
12781         (type_system_address): Replace "parse_language" with method call.
12782
12783 2019-04-04  Tom Tromey  <tom@tromey.com>
12784
12785         * rust-exp.y: Replace "parse_gdbarch" with method call.
12786         * parse.c (write_dollar_variable, insert_type_address_space):
12787         Replace "parse_gdbarch" with method call.
12788         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12789         call.
12790         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12791         call.
12792         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12793         "parse_gdbarch" with method call.
12794         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12795         with method call.
12796         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12797         "parse_gdbarch" with method call.
12798         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12799         "parse_gdbarch" with method call.
12800         * c-exp.y (parse_type, parse_number, classify_name): Replace
12801         "parse_gdbarch" with method call.
12802         * ada-lex.l: Replace "parse_gdbarch" with method call.
12803         * ada-exp.y (parse_type, find_primitive_type, type_char)
12804         (type_system_address): Replace "parse_gdbarch" with method call.
12805
12806 2019-04-04  Tom Tromey  <tom@tromey.com>
12807
12808         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12809         * stap-probe.c (stap_parse_argument): Update.
12810         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12811         initial_size parameter.
12812         * rust-exp.y (rust_lex_tests): Update.
12813         * parse.c (parser_state): Update.
12814         (parse_exp_in_context): Update.
12815         * parser-defs.h (struct parser_state) <parser_state>: Remove
12816         "initial_size" parameter.
12817
12818 2019-04-04  Tom Tromey  <tom@tromey.com>
12819
12820         * parser-defs.h (increase_expout_size): Don't declare.
12821         * parse.c (increase_expout_size): Now static.
12822
12823 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12824
12825         * gnu-nat.c (gnu_nat_target::wait): Fix
12826         target_waitstatus_to_string call.
12827
12828 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12829
12830         * eval.c (evaluate_subexp_standard): Handle internal functions
12831         during Fortran function call handling.
12832
12833 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12834
12835         * NEWS: Mention new internal functions.
12836         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12837         (read_base_type): Use dwarf2_init_complex_target_type.
12838         * value.c (creal_internal_fn): New function.
12839         (cimag_internal_fn): New function.
12840         (_initialize_values): Register new internal functions.
12841
12842 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12843
12844         * infrun.c (stop_all_threads): If debug_infrun, always
12845         trace the wait status after wait_one, using
12846         target_waitstatus_to_string and target_pid_to_str.
12847         (handle_inferior_event): Replace various trace of
12848         wait status kind by a single trace.
12849         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12850         wait status kind image by target_waitstatus_to_string.
12851         * target/waitstatus.c (target_waitstatus_to_string): Fix
12852         obsolete comment.
12853
12854 2019-04-01  Tom Tromey  <tromey@adacore.com>
12855
12856         PR symtab/23331:
12857         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12858
12859 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12860             Pedro Alves  <palves@redhat.com>
12861
12862         * top.c (quit_force): Call 'finalize_values'.
12863         * value.c (finalize_values): New function.
12864         * value.h (finalize_values): Declare.
12865
12866 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12867
12868         * NEWS: Announce $_gdb_major and $_gdb_minor.
12869
12870         * top.c (init_gdb_version_vars): New function.
12871         (gdb_init): Call init_gdb_version_vars.
12872
12873 2019-03-29  Tom Tromey  <tromey@adacore.com>
12874
12875         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12876         help text.  Remove dead code.
12877
12878 2019-03-29  Keith Seitz  <keiths@redhat.com>
12879
12880         From Siddhesh Poyarekar:
12881         * f-lang.h (f77_get_upperbound): Return LONGEST.
12882         (f77_get_lowerbound): Likewise.
12883         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12884         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12885         print them.
12886         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12887         plongest to format print it.
12888         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12889         (f77_get_upperbound): Likewise.
12890         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12891         LOWER_BOUND to LONGEST.
12892         (f77_create_arrayprint_offset_tbl): Likewise.
12893
12894 2019-03-29  Keith Seitz  <keiths@redhat.com>
12895
12896         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12897         %s/pulongest for TYPE_LENGTH instead of %d in format
12898         strings.
12899         * ada-typerint.c (ada_print_type): Likewise.
12900         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12901         * compile/compile-c-support.c (generate_register_struct): Likewise.
12902         * gdbtypes.c (recursive_dump_type): Likewise.
12903         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12904         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12905         instead of %d in format strings.
12906         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12907         to std::min to ULONGEST.
12908         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12909         instead of %d in format strings.
12910         * tracepoint.c (info_scope_command): Likewise.
12911         * typeprint.c (print_offset_data::update)
12912         (print_offset_data::finish): Likewise.
12913         * xtensa-tdep.c (xtensa_store_return_value)
12914         (xtensa_push_dummy_call): Likewise.
12915
12916 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12917
12918         * windows-nat.c (display_selector): Fixed format specifications
12919         for 64-bit Cygwin.
12920
12921 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12922
12923         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12924
12925 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12926
12927         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12928         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12929         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12930         (nios2_linux_init_abi): Install it.
12931
12932 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12933
12934         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12935
12936 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12937
12938         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12939
12940 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12941             Tom Tromey  <tromey@adacore.com>
12942
12943         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12944
12945 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12946
12947         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12948         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12949         method to compute the bounds of range types. Also print "[evaluated]"
12950         if the bounds' values come from a dynamic evaluation.
12951
12952 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12953
12954         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12955         whitespace when pretty printing is on.
12956
12957 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12958
12959         * ppc-linux-nat.c: Add include.
12960
12961 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12962
12963         * NEWS: Mention AArch64 Pointer Authentication.
12964
12965 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12966
12967         * arm-linux-nat.c: Add include.
12968
12969 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12970
12971         * source-cache.c (source_cache::get_source_lines): Re-read
12972         fullname after calling open_source_file.
12973
12974 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12975
12976         * NEWS: Mention TLS support for FreeBSD.
12977
12978 2019-03-25  Tom Tromey  <tromey@adacore.com>
12979
12980         * minsyms.c (BUNCH_SIZE): Update comment.
12981         (~minimal_symbol_reader): Remove old comment.
12982         (compact_minimal_symbols): Update comment.
12983         (minimal_symbol_reader::install): Remove old comment.  Update
12984         other comments.
12985
12986 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12987
12988         * s390-linux-nat.c: Add include.
12989
12990 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12991
12992         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12993         Call linux_get_hwcap.
12994         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12995         Likewise.
12996         (aarch64_linux_get_hwcap): Remove function.
12997         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12998         declaration.
12999         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13000         linux_get_hwcap.
13001         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13002         * linux-tdep.c (linux_get_hwcap): Add function.
13003         (linux_get_hwcap2): Likewise.
13004         * linux-tdep.h (linux_get_hwcap): Add declaration.
13005         (linux_get_hwcap2): Likewise.
13006         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13007         (ppc_linux_get_hwcap2): Likewise.
13008         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13009         linux_get_hwcap.
13010         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13011         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13012         (ppc_linux_nat_target::read_description): Likewise.
13013         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13014         * s390-linux-nat.c: Likewise.
13015         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13016
13017 2019-03-24  Tom Tromey  <tom@tromey.com>
13018
13019         * ada-lang.c (standard_lookup): Simplify initialization.
13020         (ada_lookup_symbol_nonlocal): Simplify return.
13021         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13022         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13023         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13024         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13025         initialization.
13026         * solib.c (solib_global_lookup): Simplify.
13027         * symtab.c (null_block_symbol): Remove.
13028         (symbol_cache_lookup): Simplify returns.
13029         (lookup_language_this): Simplify returns.
13030         (lookup_symbol_aux): Simplify return.
13031         (lookup_local_symbol): Simplify returns.
13032         (lookup_global_symbol_from_objfile): Simplify return.
13033         (lookup_symbol_in_objfile_symtabs)
13034         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13035         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13036         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13037         * cp-namespace.c (cp_lookup_bare_symbol)
13038         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13039         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13040         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13041         (cp_lookup_symbol_via_imports): Simplify initialization.
13042         (find_symbol_in_baseclass): Likewise.
13043         * symtab.h (null_block_symbol): Remove.
13044         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13045         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13046         (d_lookup_symbol_module): Likewise.
13047         (find_symbol_in_baseclass): Simplify initialization.
13048
13049 2019-03-24  Tom Tromey  <tom@tromey.com>
13050
13051         * expression.h: Don't include symtab.h.
13052         (struct block): Forward declare.
13053
13054 2019-03-24  Tom Tromey  <tom@tromey.com>
13055
13056         * c-exp.y (typebase): Remove casts.
13057         * gdbtypes.c (lookup_unsigned_typename, )
13058         (lookup_signed_typename): Remove cast.
13059         * eval.c (parse_to_comma_and_eval): Remove cast.
13060         * parse.c (write_dollar_variable): Remove cast.
13061         * block.h (struct block) <superblock>: Now const.
13062         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13063         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13064         (map_block): Make "block" const.
13065         * symfile.h (struct quick_symbol_functions)
13066         <map_matching_symbols>: Constify block argument to "callback".
13067         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13068         const.
13069         (find_pc_sect_compunit_symtab): Make "b" const.
13070         (find_symbol_at_address): Likewise.
13071         (search_symbols): Likewise.
13072         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13073         (dw2_debug_names_lookup_symbol): Likewise.
13074         (dw2_map_matching_symbols): Update.
13075         * p-valprint.c (pascal_val_print): Remove "block".
13076         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13077         (aux_add_nonlocal_symbols): Make "block" const.
13078         (resolve_subexp): Remove cast.
13079         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13080         const.
13081         (iterate_over_file_blocks): Likewise.
13082         * f-exp.y (%union) <bval>: Remove.
13083         * coffread.c (patch_opaque_types): Make "b" const.
13084         * spu-tdep.c (spu_catch_start): Make "block" const.
13085         * c-valprint.c (print_unpacked_pointer): Remove "block".
13086         * symmisc.c (dump_symtab_1): Make "b" const.
13087         (block_depth): Make "block" const.
13088         * d-exp.y (%union) <bval>: Remove.
13089         * cp-support.h (cp_lookup_rtti_type): Update.
13090         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13091         * psymtab.c (psym_lookup_symbol): Make "block" const.
13092         (maintenance_check_psymtabs): Make "b" const.
13093         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13094         (enumerate_locals, enumerate_args): Update.
13095         * python/py-symtab.c (stpy_global_block): Make "block" const.
13096         (stpy_static_block): Likewise.
13097         * inline-frame.c (block_starting_point_at): Make "new_block"
13098         const.
13099         * block.c (find_block_in_blockvector): Make return type const.
13100         (blockvector_for_pc_sect): Make "b" const.
13101         (find_block_in_blockvector): Make "b" const.
13102
13103 2019-03-23  Tom Tromey  <tom@tromey.com>
13104
13105         * varobj.c (varobj_create): Update.
13106         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13107         * printcmd.c (display_command, do_one_display): Don't reset
13108         innermost_block.
13109         * parser-defs.h (enum innermost_block_tracker_type): Move to
13110         expression.h.
13111         (innermost_block): Update comment.
13112         * parse.c (parse_exp_1): Add tracker_types parameter.
13113         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13114         tracker_types parameter.  Reset innermost_block.
13115         (parse_exp_in_context): Remove.
13116         (parse_expression_for_completion): Update.
13117         * objfiles.c (~objfile): Don't reset expression_context_block or
13118         innermost_block.
13119         * expression.h (enum innermost_block_tracker_type): Move from
13120         parser-defs.h.
13121         (parse_exp_1): Add tracker_types parameter.
13122         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13123         reset innermost_block.
13124
13125 2019-03-23  Tom Tromey  <tom@tromey.com>
13126
13127         * objfiles.h: Include bcache.h.
13128
13129 2019-03-23  Tom Tromey  <tom@tromey.com>
13130
13131         * linespec.c (get_current_search_block): Use
13132         scoped_restore_current_language.
13133         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13134
13135 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13136             Jiong Wang  <jiong.wang@arm.com>
13137
13138         * aarch64-linux-tdep.c
13139         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13140         section.
13141         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13142
13143 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13144             Jiong Wang  <jiong.wang@arm.com>
13145
13146         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13147         instructions.
13148         (aarch64_analyze_prologue_test): Add PACIASP test.
13149         (aarch64_prologue_prev_register): Unmask PC value.
13150
13151 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13152             Jiong Wang  <jiong.wang@arm.com>
13153
13154         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13155         (aarch64_dwarf2_prev_register): Unmask PC value.
13156         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13157         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13158         DW_CFA_AARCH64_negate_ra_state.
13159         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13160
13161 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13162             Jiong Wang  <jiong.wang@arm.com>
13163
13164         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13165         registers.
13166         (aarch64_pseudo_register_name): Likewise.
13167         (aarch64_pseudo_register_type): Likewise.
13168         (aarch64_pseudo_register_reggroup_p): Likewise.
13169         (aarch64_gdbarch_init): Add pauth registers.
13170         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13171         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13172         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13173         (struct gdbarch_tdep): Add regnum for ra_state.
13174
13175 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13176             Jiong Wang  <jiong.wang@arm.com>
13177
13178         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13179
13180 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13181             Jiong Wang  <jiong.wang@arm.com>
13182
13183         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13184         function.
13185         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13186         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13187         (aarch64_gdbarch_init): Add puth registers.
13188         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13189         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13190         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13191
13192 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13193             Jiong Wang  <jiong.wang@arm.com>
13194
13195         * aarch64-linux-nat.c
13196         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13197         * aarch64-linux-tdep.c
13198         (aarch64_linux_core_read_description): Likewise.
13199         (aarch64_linux_get_hwcap): New function.
13200         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13201         (aarch64_linux_get_hwcap): New declaration.
13202
13203 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13204             Jiong Wang  <jiong.wang@arm.com>
13205
13206         * aarch64-linux-nat.c
13207         (aarch64_linux_nat_target::read_description): Add pauth param.
13208         * aarch64-linux-tdep.c
13209         (aarch64_linux_core_read_description): Likewise.
13210         * aarch64-tdep.c (struct target_desc): Add in pauth.
13211         (aarch64_read_description): Add pauth param.
13212         (aarch64_gdbarch_init): Likewise.
13213         * aarch64-tdep.h (aarch64_read_description): Likewise.
13214         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13215         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13216         * features/Makefile: Add new files.
13217         * features/aarch64-pauth.c: New file.
13218         * features/aarch64-pauth.xml: New file.
13219
13220 2019-03-20  Tom Tromey  <tromey@adacore.com>
13221
13222         * infrun.c (handle_inferior_event): Rename from
13223         handle_inferior_event_1.  Create a scoped_value_mark.
13224         (handle_inferior_event): Remove.
13225
13226 2019-03-19  Tom Tromey  <tromey@adacore.com>
13227
13228         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13229         * infrun.h (print_stop_event): Add "displays" parameter.
13230         * infrun.c (print_stop_event): Add "displays" parameter.
13231
13232 2019-03-19  Pedro Alves  <palves@redhat.com>
13233
13234         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13235         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13236         to -1.  Fix TABs vs spaces.
13237         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13238         * tui/tui-out.h (tui_ui_out) Add intro comments.
13239         <m_line, m_start_of_line>: In-class initialize, and add describing
13240         comment.
13241
13242 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13243
13244         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13245         variable names.
13246         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13247
13248 2019-03-18  Pedro Alves  <palves@redhat.com>
13249             Eli Zaretskii <eliz@gnu.org>
13250
13251         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13252         m_line and m_start_of_line.
13253
13254 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13255
13256         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13257         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13258         it returns a newline.  This fixes a regression in TU mode, whereby
13259         the next line is output on the same screen line as the user input.
13260
13261 2019-03-18  Tom Tromey  <tromey@adacore.com>
13262
13263         * minsyms.c (minimal_symbol_reader::install): Remove call to
13264         obstack_blank.
13265
13266 2019-03-18  Pedro Alves  <palves@redhat.com>
13267
13268         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13269         New globals.
13270         (apply_style): New, factored out from ...
13271         (apply_ansi_escape): ... this.  Handle reverse video mode.
13272         (tui_set_reverse_mode): New function.
13273         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13274         * tui/tui-winsource.c (tui_show_source_line): Use
13275         tui_set_reverse_mode instead of setting A_STANDOUT.
13276         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13277         New setter methods.
13278
13279 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13280
13281         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13282         Handle tabs.
13283
13284 2019-03-18  Tom Tromey  <tromey@adacore.com>
13285
13286         * ada-lang.c (empty_array): Add "high" parameter.
13287         (ada_evaluate_subexp): Update.
13288
13289 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13290
13291         * unittests/string_view-selftests.c: Define
13292         _initialize_string_view_selftests unconditionally.
13293
13294 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13295
13296         PR gdb/24350
13297         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13298
13299 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13300
13301         PR gdb/24351
13302         * windows-nat.c (display_selector): Fix format specifiers.
13303
13304 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13305
13306         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13307         tui_refill_source_window instead of tui_refresh_win, to update the
13308         current execution line.  This fixes redisplay of the current line
13309         when stepping through the code with "next" or "step".
13310
13311 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13312
13313         * source-cache.c (source_cache::get_source_lines): Call
13314         find_source_lines to initialize s->nlines.  This fixes vertical
13315         scrolling of TUI source window when the DOWN arrow is pressed.
13316
13317 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13318
13319         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13320         linux-thread-db.c (_initialize_thread_db): Likewise.
13321
13322 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13323
13324         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13325         wclrtoeol in tui_show_source_line".  This reverts changes made in
13326         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13327
13328 2019-03-15  Tom Tromey  <tom@tromey.com>
13329
13330         * symtab.h (struct minimal_symbol): Derive from
13331         general_symbol_info.
13332         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13333         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13334         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13335         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13336         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13337         (MSYMBOL_SEARCH_NAME): Update.
13338         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13339         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13340         * minsyms.c (minimal_symbol_reader::record_full): Update.
13341
13342 2019-03-15  Tom Tromey  <tom@tromey.com>
13343
13344         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13345
13346 2019-03-15  Tom Tromey  <tom@tromey.com>
13347
13348         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13349         unique_xmalloc_ptr.
13350         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13351         Update.
13352         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13353         (build_minimal_symbol_hash_tables)
13354         (minimal_symbol_reader::install): Update.
13355
13356 2019-03-15  Tom Tromey  <tom@tromey.com>
13357
13358         * symtab.c (create_demangled_names_hash): Update.
13359         (symbol_set_names): Update.
13360         * objfiles.h (struct objfile_per_bfd_storage)
13361         <demangled_names_hash>: Now an htab_up.
13362         * objfiles.c (objfile_per_bfd_storage): Simplify.
13363
13364 2019-03-15  Tom Tromey  <tom@tromey.com>
13365
13366         * objfiles.h (struct objfile_per_bfd_storage): Declare
13367         destructor.
13368         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13369         New.
13370         (get_objfile_bfd_data): Use new.  Don't initialize
13371         language_of_main.
13372         (free_objfile_per_bfd_storage): Remove.
13373         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13374
13375 2019-03-15  Tom Tromey  <tom@tromey.com>
13376
13377         * symfile.c (reread_symbols): Update.
13378         * objfiles.c (objfile::objfile): Update.
13379         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13380         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13381         comment.
13382         (minimal_symbol_reader::install): Update.
13383         (terminate_minimal_symbol_table): Remove.
13384         * jit.c (jit_object_close_impl): Update.
13385
13386 2019-03-15  Tom Tromey  <tom@tromey.com>
13387
13388         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13389         initializations.
13390
13391 2019-03-15  Tom Tromey  <tom@tromey.com>
13392
13393         * objfiles.h (struct objfile_per_bfd_storage)
13394         <demangled_hash_languages>: Now a bitset.
13395         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13396         (lookup_minimal_symbol): Update.
13397
13398 2019-03-15  Tom Tromey  <tom@tromey.com>
13399
13400         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13401         Don't return the symbol.
13402         * coffread.c (record_minimal_symbol): Use record_full.
13403
13404 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13405
13406         The MS-Windows port of ncurses fails to switch to a color pair if
13407         one or both of the colors are the implicit default colors.  This
13408         change records the default colors when TUI is initialized, and
13409         then specifies them explicitly when a color pair uses the default
13410         colors.  This allows color styling in TUI mode on MS-Windows.
13411
13412         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13413         ncurses_norm_attr.
13414         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13415         colors in ncurses_norm_attr.
13416         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13417         "none", replace it with the default color recorded in
13418         ncurses_norm_attr.
13419
13420 2019-03-14  Tom Tromey  <tromey@adacore.com>
13421
13422         * source-cache.h (class source_cache) <get_source_lines>: Return
13423         std::string.
13424         * source-cache.c (source_cache::extract_lines): Handle case where
13425         first_pos==npos.  Return std::string.
13426         (source_cache::get_source_lines): Update.
13427
13428 2019-03-14  Tom Tromey  <tromey@adacore.com>
13429
13430         * NEWS: Add item for "style sources" commands.
13431         * source-cache.c (source_cache::get_source_lines): Check
13432         source_styling.
13433         * cli/cli-style.c (source_styling): New global.
13434         (_initialize_cli_style): Add "style sources" commands.
13435         (show_style_sources): New function.
13436         * cli/cli-style.h (source_styling): Declare.
13437
13438 2019-03-14  Pedro Alves  <palves@redhat.com>
13439             Tom Tromey  <tromey@adacore.com>
13440
13441         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13442         * tui/tui-winsource.c (tui_refill_source_window): New function,
13443         from...
13444         (tui_horizontal_source_scroll): ... here.  Move some logic.
13445         * cli/cli-style.c (set_style_enabled): Notify new observable.
13446         * tui/tui-hooks.c (tui_redisplay_source): New function.
13447         (tui_attach_detach_observers): Attach or detach
13448         tui_redisplay_source.
13449         * observable.h (source_styling_changed): New observable.
13450         * observable.c: Define source_styling_changed observable.
13451
13452 2019-03-13  Tom Tromey  <tromey@adacore.com>
13453
13454         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13455         (i386_gnu_nat_target::store_registers): Update.
13456         * target-debug.h (target_debug_print_std_string): New macro.
13457         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13458         * windows-tdep.c (display_one_tib): Update.
13459         * tui/tui-stack.c (tui_make_status_line): Update.
13460         * top.c (print_inferior_quit_action): Update.
13461         * thread.c (thr_try_catch_cmd): Update.
13462         (add_thread_with_info): Update.
13463         (thread_target_id_str): Update.
13464         (thr_try_catch_cmd): Update.
13465         (thread_command): Update.
13466         (thread_find_command): Update.
13467         * record-btrace.c (record_btrace_target::info_record)
13468         (record_btrace_resume_thread, record_btrace_target::resume)
13469         (record_btrace_cancel_resume, record_btrace_step_thread)
13470         (record_btrace_target::wait, record_btrace_target::wait)
13471         (record_btrace_target::wait, record_btrace_target::stop): Update.
13472         * progspace.c (print_program_space): Update.
13473         * process-stratum-target.c
13474         (process_stratum_target::thread_address_space): Update.
13475         * linux-fork.c (linux_fork_mourn_inferior)
13476         (detach_checkpoint_command, info_checkpoints_command)
13477         (linux_fork_context): Update.
13478         (linux_fork_detach): Update.
13479         (class scoped_switch_fork_info): Update.
13480         (delete_checkpoint_command): Update.
13481         * infrun.c (follow_fork_inferior): Update.
13482         (follow_fork_inferior): Update.
13483         (proceed_after_vfork_done): Update.
13484         (handle_vfork_child_exec_or_exit): Update.
13485         (follow_exec): Update.
13486         (displaced_step_prepare_throw): Update.
13487         (displaced_step_restore): Update.
13488         (start_step_over): Update.
13489         (resume_1): Update.
13490         (clear_proceed_status_thread): Update.
13491         (proceed): Update.
13492         (print_target_wait_results): Update.
13493         (do_target_wait): Update.
13494         (context_switch): Update.
13495         (stop_all_threads): Update.
13496         (restart_threads): Update.
13497         (finish_step_over): Update.
13498         (handle_signal_stop): Update.
13499         (switch_back_to_stepped_thread): Update.
13500         (keep_going_pass_signal): Update.
13501         (print_exited_reason): Update.
13502         (normal_stop): Update.
13503         * inferior.c (inferior_pid_to_str): Change return type.
13504         (print_selected_inferior): Update.
13505         (add_inferior): Update.
13506         (detach_inferior): Update.
13507         * dummy-frame.c (fprint_dummy_frames): Update.
13508         * dcache.c (dcache_info_1): Update.
13509         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13510         (btrace_fetch, btrace_clear): Update.
13511         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13512         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13513         type.
13514         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13515         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13516         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13517         * gdbarch.c, gdbarch.h: Rebuild.
13518         * gdbarch.sh (core_pid_to_str): Change return type.
13519         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13520         return type.
13521         (windows_nat_target::pid_to_str): Change return type.
13522         (windows_delete_thread): Update.
13523         (windows_nat_target::attach): Update.
13524         (windows_nat_target::files_info): Update.
13525         * target-delegates.c: Rebuild.
13526         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13527         return type.
13528         (sol_thread_target::pid_to_str): Change return type.
13529         * remote.c (class remote_target) <pid_to_str>: Change return
13530         type.
13531         (remote_target::pid_to_str): Change return type.
13532         (extended_remote_target::attach, remote_target::remote_stop_ns)
13533         (remote_target::remote_notif_remove_queued_reply)
13534         (remote_target::push_stop_reply, remote_target::disable_btrace):
13535         Update.
13536         (extended_remote_target::attach): Update.
13537         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13538         type.
13539         (gdbsim_target::pid_to_str): Change return type.
13540         * ravenscar-thread.c (struct ravenscar_thread_target)
13541         <pid_to_str>: Change return type.
13542         (ravenscar_thread_target::pid_to_str): Change return type.
13543         * procfs.c (class procfs_target) <pid_to_str>: Change return
13544         type.
13545         (procfs_target::pid_to_str): Change return type.
13546         (procfs_target::attach): Update.
13547         (procfs_target::detach): Update.
13548         (procfs_target::fetch_registers): Update.
13549         (procfs_target::store_registers): Update.
13550         (procfs_target::wait): Update.
13551         (procfs_target::files_info): Update.
13552         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13553         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13554         return type.
13555         (nto_procfs_target::pid_to_str): Change return type.
13556         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13557         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13558         return type.
13559         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13560         (exit_lwp): Update.
13561         (attach_proc_task_lwp_callback, get_detach_signal)
13562         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13563         (linux_nat_target::resume, wait_lwp, stop_callback)
13564         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13565         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13566         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13567         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13568         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13569         type.
13570         (inf_ptrace_target::attach): Update.
13571         (inf_ptrace_target::files_info): Update.
13572         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13573         type.
13574         (go32_nat_target::pid_to_str): Change return type.
13575         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13576         (gnu_nat_target::wait): Update.
13577         (gnu_nat_target::wait): Update.
13578         (gnu_nat_target::resume): Update.
13579         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13580         (fbsd_nat_target::wait): Update.
13581         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13582         type.
13583         (darwin_nat_target::attach): Update.
13584         * corelow.c (class core_target) <pid_to_str>: Change return type.
13585         (core_target::pid_to_str): Change return type.
13586         * target.c (normal_pid_to_str): Change return type.
13587         (default_pid_to_str): Likewise.
13588         (target_pid_to_str): Change return type.
13589         (target_translate_tls_address): Update.
13590         (target_announce_detach): Update.
13591         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13592         return type.
13593         (bsd_uthread_target::pid_to_str): Change return type.
13594         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13595         type.
13596         (bsd_kvm_target::pid_to_str): Change return type.
13597         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13598         return type.
13599         (aix_thread_target::pid_to_str): Change return type.
13600         * target.h (struct target_ops) <pid_to_str>: Change return type.
13601         (target_pid_to_str, normal_pid_to_str): Likewise.
13602         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13603         type.
13604         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13605         type.
13606         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13607         return type.
13608         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13609         type.
13610         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13611         type.
13612         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13613         return type.
13614
13615 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13616
13617         * NEWS: Mention that the new default MI version is 3.  Mention
13618         changes to the output of commands and events that deal with
13619         multi-location breakpoints.
13620         * breakpoint.c: Include "mi/mi-out.h".
13621         (print_one_breakpoint): Change output syntax if using MI version
13622         >= 3.
13623         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13624         New.
13625         (mi_multi_location_breakpoint_output_fixed): New.
13626         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13627         (mi_cmd_fix_multi_location_breakpoint_output): New.
13628         (mi_multi_location_breakpoint_output_fixed): New.
13629         * mi/mi-cmds.c (mi_cmds): Register command
13630         -fix-multi-location-breakpoint-output.
13631         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13632         interpreter "mi".
13633
13634 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13635
13636         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13637         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13638         instantiate mi_ui_out based on interpreter name.
13639         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13640         * mi/mi-main.c (mi_load_progress): Likewise.
13641
13642 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13643
13644         * NEWS: Combine separate "New targets" sections for 8.3.
13645
13646 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13647
13648         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13649         (ppcfbsd_init_abi): Install gdbarch
13650         "fetch_tls_load_module_address" and "get_thread_local_address"
13651         methods.
13652
13653 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13654
13655         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13656         (riscv_fbsd_init_abi): Install gdbarch
13657         "fetch_tls_load_module_address" and "get_thread_local_address"
13658         methods.
13659
13660 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13661
13662         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13663         (i386fbsd_init_abi): Install gdbarch
13664         "fetch_tls_load_module_address" and "get_thread_local_address"
13665         methods.
13666
13667 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13668
13669         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13670         (amd64fbsd_init_abi): Install gdbarch
13671         "fetch_tls_load_module_address" and "get_thread_local_address"
13672         methods.
13673
13674 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13675
13676         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13677         (struct fbsd_pspace_data): New type.
13678         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13679         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13680         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13681         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13682         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13683
13684 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13685
13686         * gdbtypes.c (lookup_struct_elt): New function.
13687         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13688         * gdbtypes.h (struct struct_elt): New type.
13689         (lookup_struct_elt): New prototype.
13690
13691 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13692
13693         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13694         remove disabled code block.
13695
13696 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13697
13698         * gdbarch.sh (get_thread_local_address): New method.
13699         * gdbarch.h, gdbarch.c: Regenerate.
13700         * target.c (target_translate_tls_address): Use
13701         gdbarch_get_thread_local_address if present instead of
13702         target::get_thread_local_address.
13703
13704 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13705
13706         * target.h (target::get_thread_local_address): Update comment.
13707
13708 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13709
13710         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13711         objfile->separate_debug_objfile_backlink if not NULL.
13712
13713 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13714
13715         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13716         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13717         (amd64bsd_store_inferior_registers): Likewise.
13718         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13719         Enable segment base registers.
13720         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13721         PT_GETFSBASE and PT_GETGSBASE.
13722         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13723         PT_SETGSBASE.
13724         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13725         segment base registers.
13726         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13727
13728 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13729
13730         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13731         Update calls to i386_target_description to add 'segments'
13732         parameter.
13733         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13734         add segment base registers.
13735         * arch/i386.c (i386_create_target_description): Add 'segments'
13736         parameter to enable segment base registers.
13737         * arch/i386.h (i386_create_target_description): Likewise.
13738         * features/i386/32bit-segments.xml: New file.
13739         * features/i386/32bit-segments.c: Generate.
13740         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13741         call to i386_target_description to add 'segments' parameter.
13742         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13743         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13744         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13745         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13746         if feature is present.
13747         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13748         Add 'segments' parameter to call to i386_target_description.
13749         (i386_target_description): Add 'segments' parameter to enable
13750         segment base registers.
13751         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13752         to call to i386_target_description.
13753         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13754         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13755         Define I386_NUM_REGS.
13756         (i386_target_description): Add 'segments' parameter to enable
13757         segment base registers.
13758
13759 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13760
13761         PR/24325
13762         * source-cache.c: #undef open and close, to avoid unresolved
13763         externals during linking.
13764
13765 2019-03-12  Tom Tromey  <tromey@adacore.com>
13766
13767         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13768         const.  Add initializers.
13769         (_initialize_remote): Don't initialize ptid globals.
13770
13771 2019-03-12  Pedro Alves  <palves@redhat.com>
13772
13773         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13774
13775 2019-03-12  Pedro Alves  <palves@redhat.com>
13776
13777         * cp-name-parser.y (main): Remove unused 'len' variable.
13778
13779 2019-03-12  Tom Tromey  <tromey@adacore.com>
13780
13781         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13782         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13783
13784 2019-03-12  Tom Tromey  <tromey@adacore.com>
13785
13786         * linux-nat.c (iterate_over_lwps): Update.
13787         (stop_callback): Remove parameter.
13788         (stop_wait_callback, detach_callback, resume_set_callback)
13789         (select_singlestep_lwp_callback, set_ignore_sigint)
13790         (status_callback, resumed_callback, resume_clear_callback)
13791         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13792         data parameter.
13793         (linux_nat_target::detach, linux_nat_target::resume)
13794         (linux_stop_and_wait_all_lwps, select_event_lwp)
13795         (linux_nat_filter_event, linux_nat_wait_1)
13796         (linux_nat_target::kill, linux_nat_target::stop)
13797         (linux_nat_target::stop): Update.
13798         (linux_nat_resume_callback): Change type.
13799         (resume_stopped_resumed_lwps, count_events_callback)
13800         (select_event_lwp_callback): Likewise.
13801         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13802         * arm-linux-nat.c (struct update_registers_data): Remove.
13803         (update_registers_callback): Change type.
13804         (arm_linux_insert_hw_breakpoint1): Update.
13805         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13806         parameter.
13807         (x86_linux_dr_set_addr): Update.
13808         (x86_linux_dr_set_control): Update.
13809         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13810         (iterate_over_lwps): Use gdb::function_view.
13811         * nat/aarch64-linux-hw-point.c (struct
13812         aarch64_dr_update_callback_param): Remove.
13813         (debug_reg_change_callback): Change type.
13814         (aarch64_notify_debug_reg_change): Update.
13815         * s390-linux-nat.c (s390_refresh_per_info): Update.
13816
13817 2019-03-11  Tom Tromey  <tromey@adacore.com>
13818
13819         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13820         redundant assignment to "this_cu".
13821
13822 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13823
13824         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13825
13826 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13827
13828         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13829         from...
13830         (rank_one_type): ... this.
13831
13832 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13833
13834         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13835         from...
13836         (rank_one_type): ... this.
13837
13838 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13839
13840         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13841         from...
13842         (rank_one_type): ... this.
13843
13844 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13845
13846         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13847         from...
13848         (rank_one_type): ... this.
13849
13850 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13851
13852         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13853         from...
13854         (rank_one_type): ... this.
13855
13856 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13857
13858         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13859         from...
13860         (rank_one_type): ... this.
13861
13862 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13863
13864         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13865         from...
13866         (rank_one_type): ... this.
13867
13868 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13869
13870         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13871         from...
13872         (rank_one_type): ... this.
13873
13874 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13875
13876         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13877         from...
13878         (rank_one_type): ... this.
13879
13880 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13881
13882         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13883         from...
13884         (rank_one_type): ... this.
13885
13886 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13887
13888         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13889         from...
13890         (rank_one_type): ... this.
13891
13892 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13893
13894         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13895         from...
13896         (rank_one_type): ... this.
13897
13898 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13899
13900         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13901         inferior-events' shows the example events.
13902
13903 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13904
13905         Support styling on native MS-Windows console
13906
13907         PR/24315
13908         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13909         on MS-Windows if $TERM is not defined.
13910
13911         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13912
13913         * posix-hdep.c (gdb_console_fputs):
13914         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13915         functions.
13916         * ui-file.h (gdb_console_fputs): Add prototype.
13917
13918         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13919         back to fputs only if the former returns zero.
13920
13921 2019-03-07  Tom Tromey  <tom@tromey.com>
13922
13923         * symmisc.c (print_symbol_bcache_statistics): Update.
13924         (print_objfile_statistics): Update.
13925         * symfile.c (allocate_symtab): Update.
13926         * stabsread.c: Don't include bcache.h.
13927         * psymtab.h (struct psymbol_bcache): Don't declare.
13928         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13929         (psymbol_bcache_init, psymbol_bcache_free)
13930         (psymbol_bcache_get_bcache): Don't declare.
13931         * psymtab.c (struct psymbol_bcache): Remove.
13932         (psymtab_storage::psymtab_storage): Update.
13933         (psymtab_storage::~psymtab_storage): Update.
13934         (psymbol_bcache_init, psymbol_bcache_free)
13935         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13936         (add_psymbol_to_bcache): Update.
13937         (allocate_psymtab): Update.
13938         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13939         macro_cache>: No longer pointers.
13940         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13941         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13942         * macrotab.c (macro_bcache): Update.
13943         * macroexp.c: Don't include bcache.h.
13944         * gdbtypes.c (check_types_worklist): Update.
13945         (types_deeply_equal): Remove TRY/CATCH.  Update.
13946         * elfread.c (elf_symtab_read): Update.
13947         * dwarf2read.c: Don't include bcache.h.
13948         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13949         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13950         (print_bcache_statistics, bcache_memory_used): Don't declare.
13951         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13952         methods.  Rename all data members.
13953         * bcache.c (struct bcache): Move to bcache.h.
13954         (bcache::expand_hash_table): Rename from expand_hash_table.
13955         (bcache): Remove.
13956         (bcache::insert): Rename from bcache_full.
13957         (bcache::compare): Rename from bcache_compare.
13958         (bcache_xmalloc): Remove.
13959         (bcache::~bcache): Rename from bcache_xfree.
13960         (bcache::print_statistics): Rename from print_bcache_statistics.
13961         (bcache::memory_used): Rename from bcache_memory_used.
13962
13963 2019-03-07  Pedro Alves  <palves@redhat.com>
13964
13965         * infrun.c (normal_stop): Also check for
13966         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13967
13968 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13969
13970         * f-lang.c (value_from_host_double): Moved to...
13971         * value.c (value_from_host_double): ...here.
13972         * value.h (value_from_host_double): Declare.
13973         * guile/scm-math.c (vlscm_convert_typed_number): Use
13974         value_from_host_double.
13975         (vlscm_convert_number): Likewise.
13976         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13977         * python/py-value.c (convert_value_from_python): Likewise.
13978
13979 2019-03-06  Tom Tromey  <tom@tromey.com>
13980
13981         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13982
13983 2019-03-06  Tom Tromey  <tom@tromey.com>
13984
13985         * utils.h (free_current_contents): Don't declare.
13986         * utils.c (free_current_contents): Remove.
13987
13988 2019-03-06  Tom Tromey  <tom@tromey.com>
13989
13990         * top.c (quit_force): Update.
13991         * main.c (captured_command_loop): Update.
13992         * common/new-op.c (operator new): Update.
13993         * common/common-exceptions.c (struct catcher)
13994         <save_cleanup_chain>: Remove member.
13995         (exceptions_state_mc_init): Update.
13996         (exception_try_scope_entry): Return nullptr.
13997         (exception_try_scope_exit, exception_rethrow)
13998         (throw_exception_sjlj, throw_exception_cxx): Update.
13999         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14000         (all_cleanups, do_cleanups, discard_cleanups)
14001         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14002         (restore_cleanups, restore_final_cleanups): Don't declare.
14003         (do_final_cleanups): Remove parameter.
14004         * common/cleanups.c (cleanup_chain, make_cleanup)
14005         (make_cleanup_dtor, all_cleanups, do_cleanups)
14006         (discard_my_cleanups, discard_cleanups)
14007         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14008         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14009         (null_cleanup): Remove.
14010         (do_final_cleanups): Remove parameter.
14011
14012 2019-03-06  Tom Tromey  <tom@tromey.com>
14013
14014         * remote.c (remote_target::remote_parse_stop_reply): Use
14015         unique_xmalloc_ptr.
14016
14017 2019-03-06  Tom Tromey  <tom@tromey.com>
14018
14019         * stabsread.c (struct stabs_field_info): Rename from field_info.
14020         <list, fnlist>: Add initializers.
14021         <obstack>: New member.
14022         (read_member_functions, read_struct_fields, read_baseclasses):
14023         Allocate on obstack.  Don't use cleanups.
14024         (read_one_struct_field, read_member_functions, read_struct_fields)
14025         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14026         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14027         (read_struct_type): Update.
14028
14029 2019-03-06  Tom Tromey  <tom@tromey.com>
14030
14031         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14032         * common/filestuff.h (make_cleanup_close): Don't declare.
14033         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14034         Remove.
14035
14036 2019-03-06  Tom Tromey  <tom@tromey.com>
14037
14038         * solib-aix.c: Use make_scope_exit.
14039
14040 2019-03-06  Tom Tromey  <tom@tromey.com>
14041
14042         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14043         Use make_scope_exit.
14044
14045 2019-03-06  Tom Tromey  <tom@tromey.com>
14046
14047         * solib-svr4.c (disable_probes_interface): Remove parameter.
14048         (svr4_handle_solib_event): Use make_scope_exit.
14049
14050 2019-03-06  Tom Tromey  <tom@tromey.com>
14051
14052         * remote.c (struct stop_reply_deleter): Remove.
14053         (stop_reply_up): Update.
14054         (struct stop_reply): Derive from notif_event.  Don't typedef.
14055         <regcache>: Now a std::vector.
14056         (stop_reply_xfree): Remove.
14057         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14058         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14059         (remote_target::discard_pending_stop_replies): Use delete.
14060         (remote_target::remote_parse_stop_reply): Update.
14061         (remote_target::process_stop_reply): Update.
14062         * remote-notif.h (struct notif_event): Add virtual destructor.
14063         Remove "dtr" member.
14064         (struct notif_client) <alloc_event>: Return a unique_ptr.
14065         (notif_event_xfree): Don't declare.
14066         (notif_event_up): New typedef.
14067         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14068         (notif_event_xfree, do_notif_event_xfree): Remove.
14069         (remote_notif_state_xfree): Update.
14070
14071 2019-03-06  Tom Tromey  <tom@tromey.com>
14072
14073         * infrun.c (displaced_step_clear_cleanup): Now a
14074         forward_scope_exit type.
14075         (displaced_step_prepare_throw): Update.
14076         (displaced_step_fixup): Update.
14077
14078 2019-03-06  Tom Tromey  <tom@tromey.com>
14079
14080         * inferior.h (class inferior): Update comment.
14081         * gdbthread.h (class thread_info): Update comment.
14082
14083 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14084             Tom Tromey  <tom@tromey.com>
14085
14086         * stabsread.h (struct stab_section_list): Remove.
14087         (coffstab_build_psymtabs): Update.
14088         * dbxread.c (symbuf_sections): Now a std::vector.
14089         (sect_idx): New global.
14090         (fill_symbuf): Update.
14091         (coffstab_build_psymtabs): Change type of stabsects parameter.
14092         Update.
14093         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14094         std::vector.
14095         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14096         (coff_locate_sections): Update.
14097         (coff_symfile_read): Remove cleanups.  Update.
14098         (init_stringtab): Add storage parameter.
14099         (free_stringtab, free_stringtab_cleanup): Remove.
14100         (init_lineno): Add storage parameter.
14101         (free_linetab, free_linetab_cleanup): Remove.
14102
14103 2019-03-06  Pedro Alves  <palves@redhat.com>
14104
14105         * linux-fork.c (fork_info::clobber_regs): Delete.
14106         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14107         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14108         comment.  Adjust.
14109         (scoped_switch_fork_info::scoped_switch_fork_info)
14110         (checkpoint_command, linux_fork_context): Adjust
14111         fork_save_infrun_state calls.
14112
14113 2019-03-06  Pedro Alves  <palves@redhat.com>
14114
14115         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14116         (inf_has_multiple_threads): Return 'bool' and rewrite using
14117         inferior_info::threads().
14118
14119 2019-03-06  Pedro Alves  <palves@redhat.com>
14120
14121         * linux-fork.c: Include <list>.
14122         (fork_list): Now a std::list instance.
14123         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14124         (forks_exist_p, find_last_fork): Adjust.
14125         (new_fork): Delete.
14126         (one_fork_p): New.
14127         (add_fork): Adjust.
14128         (free_fork): Delete, folded into fork_info::~fork_info().
14129         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14130         Adjust.
14131         (init_fork_list): Delete.
14132         (linux_fork_killall, linux_fork_mourn_inferior)
14133         (linux_fork_detach, info_checkpoints_command): Adjust.
14134         (_initialize_linux_fork): No longer call init_fork_list.
14135
14136 2019-03-06  Pedro Alves  <palves@redhat.com>
14137
14138         * linux-fork.c (new_fork): New, split out of ...
14139         (add_fork): ... this.  Return void.  Move "first fork" special
14140         case from here, to ...
14141         (checkpoint_command): ... here.
14142         * linux-linux.h (add_fork): Return void.
14143
14144 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14145
14146         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14147
14148 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14149             Chris January  <chris.january@arm.com>
14150             David Lecomber  <david.lecomber@arm.com>
14151
14152         * f-exp.y: New token, UNOP_INTRINSIC.
14153         (exp): New pattern using UNOP_INTRINSIC token.
14154         (f77_keywords): Add 'abs' keyword.
14155         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14156         (value_from_host_double): New function.
14157         (evaluate_subexp_f): Support UNOP_ABS.
14158
14159 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14160
14161         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14162         types.
14163
14164 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14165
14166         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14167         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14168         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14169
14170 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14171
14172         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14173
14174 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14175             Chris January  <chris.january@arm.com>
14176
14177         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14178         * f-exp.y: Define 'KIND' token.
14179         (exp): New pattern for KIND expressions.
14180         (ptype): Handle types with a kind extension.
14181         (direct_abs_decl): Extend to spot kind extensions.
14182         (f77_keywords): Add 'kind' to the list.
14183         (push_kind_type): New function.
14184         (convert_to_kind_type): New function.
14185         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14186         * parse.c (operator_length_standard): Likewise.
14187         * parser-defs.h (enum type_pieces): Add tp_kind.
14188         * std-operator.def: Add UNOP_KIND.
14189
14190 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14191
14192         * f-exp.y (f_parse): Set yydebug.
14193
14194 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14195
14196         * f-lang.c (evaluate_subexp_f): New function.
14197         (exp_descriptor_f): New global.
14198         (f_language_defn): Use exp_descriptor_f instead of
14199         exp_descriptor_standard.
14200
14201 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14202
14203         * f-exp.y (struct token): Add comments.
14204         (dot_ops): Remove uppercase versions and the end marker.
14205         (f77_keywords): Likewise.
14206         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14207         entries in the dot_ops array are case insensitive, and use
14208         strncasecmp to compare strings.  Also some whitespace cleanup in
14209         this area.  Similar for the f77_keywords array, except entries in
14210         this list might be case sensitive.
14211
14212 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14213
14214         * f-exp.y (struct f77_boolean_val): Add comments.
14215         (boolean_values): Remove uppercase versions, and end marker.
14216         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14217         and use strncasecmp to achieve case insensitivity.  Additionally,
14218         perform whitespace cleanup around this code.
14219
14220 2019-03-06  Tom Tromey  <tromey@adacore.com>
14221
14222         * remote-sim.c (gdbsim_target_open): Use result of
14223         gdb_argv::release.
14224
14225 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14226         Dirk Schubert  <dirk.schubert@arm.com>
14227         Chris January  <chris.january@arm.com>
14228
14229         * eval.c (evaluate_subexp_standard): Call Fortran argument
14230         wrapping logic.
14231         * f-lang.c (struct value): A value which can be passed into a
14232         Fortran function call.
14233         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14234         where appropriate.
14235         (struct type): Value ready for a Fortran function call.
14236         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14237         is needed.
14238         * f-lang.h (fortran_argument_convert): Declaration.
14239         (fortran_preserve_arg_pointer): Declaration.
14240         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14241
14242 2019-03-05  Tom Tromey  <tromey@adacore.com>
14243
14244         * python/py-prettyprint.c (print_string_repr): Remove #if.
14245         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14246
14247 2019-03-05  Tom Tromey  <tromey@adacore.com>
14248
14249         * target.c (the_dummy_target): Move later.  Change type to
14250         "dummy_target".
14251         (initialize_targets): Don't initialize the_dummy_target.
14252
14253 2019-03-05  Tom Tromey  <tromey@adacore.com>
14254
14255         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14256         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14257
14258 2019-03-05  Tom Tromey  <tromey@adacore.com>
14259
14260         * windows-nat.c (windows_nat_target::attach)
14261         (windows_nat_target::detach): Don't call gdb_flush.
14262         * valprint.c (generic_val_print, val_print, val_print_string):
14263         Don't call gdb_flush.
14264         * utils.c (defaulted_query): Don't call gdb_flush.
14265         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14266         * target.c (target_announce_detach): Don't call gdb_flush.
14267         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14268         * remote.c (extended_remote_target::attach): Don't call
14269         gdb_flush.
14270         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14271         * printcmd.c (do_examine): Don't call gdb_flush.
14272         (info_display_command): Don't call gdb_flush.
14273         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14274         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14275         * memattr.c (info_mem_command): Don't call gdb_flush.
14276         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14277         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14278         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14279         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14280         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14281         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14282         (gnu_nat_target::detach): Don't call gdb_flush.
14283         * f-valprint.c (f_val_print): Don't call gdb_flush.
14284         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14285         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14286         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14287         gdb_flush.
14288         * c-valprint.c (c_val_print): Don't call gdb_flush.
14289         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14290
14291 2019-03-05  Tom Tromey  <tromey@adacore.com>
14292
14293         * varobj.c (update_dynamic_varobj_children): Update.
14294         (install_default_visualizer): Use reset, not release.
14295         * value.c (set_internalvar): Update.
14296         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14297         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14298         ATTRIBUTE_UNUSED_RESULT.
14299
14300 2019-03-05  Tom Tromey  <tromey@adacore.com>
14301
14302         * remote.c (class scoped_remote_fd) <release>: Add
14303         ATTRIBUTE_UNUSED_RESULT.
14304
14305 2019-03-05  Tom Tromey  <tromey@adacore.com>
14306
14307         * macroexp.c (struct macro_buffer) <release>: Add
14308         ATTRIBUTE_UNUSED_RESULT.
14309
14310 2019-03-05  Tom Tromey  <tromey@adacore.com>
14311
14312         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14313         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14314         ATTRIBUTE_UNUSED_RESULT.
14315
14316 2019-03-05  Tom Tromey  <tromey@adacore.com>
14317
14318         * common/scoped_fd.h (class scoped_fd) <release>: Add
14319         ATTRIBUTE_UNUSED_RESULT.
14320
14321 2019-03-05  Tom Tromey  <tromey@adacore.com>
14322
14323         * parser-defs.h (struct parser_state) <release>: Add
14324         ATTRIBUTE_UNUSED_RESULT.
14325
14326 2019-03-05  Tom Tromey  <tromey@adacore.com>
14327
14328         * utils.h (class gdb_argv) <release>: Add
14329         ATTRIBUTE_UNUSED_RESULT.
14330         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14331
14332 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14333
14334         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14335         for-loop range, to avoid compiler warnings.
14336
14337         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14338         avoid compiler warnings about unused variables.
14339
14340         * NEWS: Mention end of support for native debugging on MS-Windows
14341         before XP.
14342
14343         PR gdb/24292
14344         * common/netstuff.c:
14345         * gdbserver/gdbreplay.c
14346         * gdbserver/remote-utils.c:
14347         * ser-tcp.c:
14348         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14349         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14350         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14351         'getaddrinfo' and 'freeaddrinfo' were not available before
14352         Windows XP, and mingw.org's MinGW headers by default define
14353         _WIN32_WINNT to 0x500.
14354
14355 2019-03-01  Gary Benson <gbenson@redhat.com>
14356
14357         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14358
14359 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14360             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14361
14362         PR gdb/8527
14363         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14364         set_sigint_trap, clear_sigint_trap.
14365
14366 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14367
14368         * target.c (target_detach): Clear the regcache and the
14369         frame cache.
14370
14371 2019-02-27  Pedro Alves  <palves@redhat.com>
14372
14373         * utils.c (set_screen_size): When we cap the height/width sizes,
14374         tweak the corresponding command variable to show "unlimited":
14375
14376 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14377             Pedro Alves  <palves@redhat.com>
14378
14379         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14380         before calling rl_set_screen_size.
14381
14382 2019-02-27  Tom Tromey  <tromey@adacore.com>
14383
14384         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14385         define.
14386         * python/py-value.c: Remove Python 2.4 workaround.
14387         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14388         workaround.
14389         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14390         Python 2.4 workaround.
14391         * python/python-internal.h: Remove Python 2.4 comment.
14392         (Py_ssize_t): Don't define.
14393         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14394         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14395         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14396         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14397         * python/python.c (do_start_initialization): Remove Python 2.4
14398         workaround.
14399         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14400         (print_children): Remove Python 2.4 workaround.
14401         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14402         workaround.
14403         (CHARBUFFERPROC_NAME): Remove.
14404         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14405         Python 2.4 workaround.
14406
14407 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14408
14409         * NEWS: Note minimum Python version.
14410
14411 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14412
14413         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14414         code from these functions.  Remove corresponding ifdefs.  Use
14415         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14416         Remove gotos and target of gotos.
14417         (infpy_search_memory): Likewise.
14418
14419 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14420
14421         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14422         (hppa_gdbarch_init): Don't register deleted functions with
14423         gdbarch.
14424
14425 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14426
14427         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14428         (h8300_unwind_sp): Delete.
14429         (h8300_dummy_id): Delete.
14430         (h8300_gdbarch_init): Don't register deleted functions with
14431         gdbarch.
14432
14433 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14434
14435         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14436         (ft32_unwind_pc): Delete.
14437         (ft32_unwind_sp): Delete.
14438         (ft32_gdbarch_init): Don't register deleted functions with
14439         gdbarch.
14440
14441 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14442
14443         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14444         (frv_unwind_pc): Delete.
14445         (frv_unwind_sp): Delete.
14446         (frv_gdbarch_init): Don't register deleted functions with
14447         gdbarch.
14448
14449 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14450
14451         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14452         (riscv_unwind_pc): Delete.
14453         (riscv_unwind_sp): Delete.
14454         (riscv_gdbarch_init): Don't register deleted functions with
14455         gdbarch.
14456
14457 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14458
14459         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14460         (csky_unwind_pc): Delete.
14461         (csky_unwind_sp): Delete.
14462         (csky_gdbarch_init): Don't register deleted functions with
14463         gdbarch.
14464
14465 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14466
14467         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14468         (cris_unwind_pc): Delete.
14469         (cris_unwind_sp): Delete.
14470         (cris_gdbarch_init): Don't register deleted functions with
14471         gdbarch.
14472
14473 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14474
14475         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14476         (bfin_unwind_pc): Delete.
14477         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14478
14479 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14480
14481         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14482         (arm_unwind_pc): Delete.
14483         (arm_unwind_sp): Delete.
14484         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14485
14486 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14487
14488         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14489         (arc_unwind_pc): Delete.
14490         (arc_unwind_sp): Delete.
14491         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14492
14493 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14494
14495         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14496         (alpha_unwind_pc): Delete.
14497         (alpha_gdbarch_init): Don't register deleted functions with
14498         gdbarch.
14499
14500 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14501
14502         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14503         (aarch64_unwind_pc): Delete.
14504         (aarch64_unwind_sp): Delete.
14505         (aarch64_gdbarch_init): Don't register deleted functions with
14506         gdbarch.
14507
14508 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14509
14510         * gdbtypes.c (type_align): Don't consider static members when
14511         computing structure alignment.
14512
14513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14514
14515         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14516         return 0 for other types.
14517         * arch-utils.c (default_type_align): Always return 0.
14518         * gdbarch.h: Regenerate.
14519         * gdbarch.sh (type_align): Extend comment.
14520         * gdbtypes.c (type_align): Add additional comments, always call
14521         gdbarch_type_align before applying the default rules.
14522         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14523         generic code will then apply a suitable default.
14524         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14525         types, return 0 for other types.
14526
14527 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14528
14529         * NEWS: Create a new section for the next release branch.
14530         Rename the section of the current branch, now that it has
14531         been cut.
14532
14533 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14534
14535         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14536         * version.in: Bump version to 8.3.50.DATE-git.
14537
14538 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14539
14540         * aix-thread.c (ptid_cmp): Remove unused variable.
14541         (get_signaled_thread): Likewise.
14542         (store_regs_user_thread): Likewise.
14543         (store_regs_kernel_thread): Likewise.
14544         (fetch_regs_kernel_thread): Remove shadowed variable.
14545
14546 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14547
14548         * features/riscv/32bit-cpu.xml: Add register numbers.
14549         * features/riscv/32bit-fpu.c: Regenerate.
14550         * features/riscv/32bit-fpu.xml: Add register numbers.
14551         * features/riscv/64bit-cpu.xml: Add register numbers.
14552         * features/riscv/64bit-fpu.c: Regenerate.
14553         * features/riscv/64bit-fpu.xml: Add register numbers.
14554
14555 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14556
14557         * NEWS: Mention two argument form of gdb.Value constructor.
14558         * python/py-value.c (convert_buffer_and_type_to_value): New
14559         function.
14560         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14561         Add support for handling an optional second argument.  Call
14562         convert_buffer_and_type_to_value as appropriate.
14563         * python/python-internal.h (Py_buffer_deleter): New struct.
14564         (Py_buffer_up): New typedef.
14565
14566 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14567
14568         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14569         instead of releasing ownership.
14570
14571 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14572
14573         * dwarf2read.c (open_and_init_dwp_file): Call
14574         elf_numsections instead of bfd_count_sections to initialize
14575         dwp_file->num_sections.
14576
14577 2019-02-25  Tom Tromey  <tromey@adacore.com>
14578
14579         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14580
14581 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14582
14583         * gcore.in: Add '--readnever' option when invoking GDB.
14584
14585 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14586
14587         * MAINTAINERS: Update my email address.
14588
14589 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14590
14591         * build-id.c (build_id_to_debug_bfd_1): New function.
14592         (build_id_to_debug_bfd): Look for separate debug file in
14593         sysroot.
14594
14595 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14596
14597         * gdbarch.sh: Update the copyright year range that is placed into
14598         generated files.
14599
14600 2019-02-22  Keith Seitz  <keiths@redhat.com>
14601
14602         PR symtab/23853
14603         * linespec.c (create_sals_line_offset): Search for the default
14604         symtab's filename instead of its fullname.
14605
14606 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14607
14608         * NEWS: Update style defaults.
14609
14610 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14611
14612         * main.c (captured_main_1): Disable styling in batch mode.
14613
14614 2019-02-20  Tom Tromey  <tom@tromey.com>
14615
14616         * symtab.c (symtab_symbol_info): Fix typos.
14617
14618 2019-02-20  Tom Tromey  <tromey@adacore.com>
14619
14620         * findcmd.c (_initialize_mem_search): Use upper case for
14621         metasyntactic variables.
14622
14623 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14624
14625         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14626         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14627
14628 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14629
14630         * top.h (source_file_name): Change to std::string.
14631         * top.c (source_file_name): Likewise.
14632         (command_line_input): Adjust.
14633         * cli/cli-script.c (script_from_file): Adjust.
14634
14635 2019-02-19  Tom Tromey  <tromey@adacore.com>
14636
14637         * ravenscar-thread.c
14638         (ravenscar_thread_target::update_thread_list): Don't call
14639         ada_build_task_list.
14640         * ada-lang.h (ada_build_task_list): Don't declare.
14641         * ada-tasks.c (struct ada_tasks_inferior_data)
14642         <task_list_valid_p>: Now bool.
14643         (read_known_tasks, ada_task_list_changed)
14644         (ada_tasks_invalidate_inferior_data): Update.
14645         (read_known_tasks_array): Return bool.
14646         (read_known_tasks_list): Likewise.
14647         (read_known_tasks): Return void.
14648         (ada_build_task_list): Now static.
14649
14650 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14651
14652         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14653         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14654
14655 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14656
14657         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14658         variant for ada_tasks_pspace_data_handle and
14659         ada_tasks_inferior_data_handle.
14660         (ada_tasks_pspace_data_cleanup): New function.
14661         (ada_tasks_inferior_data_cleanup): New function.
14662
14663 2019-02-17  Tom Tromey  <tom@tromey.com>
14664
14665         * macrotab.h (macro_source_fullname): Return a std::string.
14666         * macrotab.c (macro_include, check_for_redefinition)
14667         (macro_undef, macro_lookup_definition, foreach_macro)
14668         (foreach_macro_in_scope): Update.
14669         (macro_source_fullname): Return a std::string.
14670         * macrocmd.c (show_pp_source_pos): Update.
14671
14672 2019-02-17  Tom Tromey  <tom@tromey.com>
14673
14674         * macrocmd.c (show_pp_source_pos): Style the file names.
14675
14676 2019-02-17  Tom Tromey  <tom@tromey.com>
14677
14678         PR tui/24197:
14679         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14680
14681 2019-02-17  Tom Tromey  <tom@tromey.com>
14682
14683         * ada-lang.c (user_select_syms): Use filtered printing.
14684         * utils.c (wrap_style): New global.
14685         (desired_style): Remove.
14686         (emit_style_escape): Add stream parameter.
14687         (set_output_style, reset_terminal_style, prompt_for_continue):
14688         Update.
14689         (flush_wrap_buffer): Only flush gdb_stdout.
14690         (wrap_here): Set wrap_style.
14691         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14692         treat escape sequences as a character.  Change when wrap buffer is
14693         flushed.
14694         (fputs_styled): Do not set the output style when the default is
14695         requested.
14696         * ui-style.h (struct ui_file_style) <is_default>: New method.
14697         * source.c (print_source_lines_base): Emit escape sequences in one
14698         piece.
14699
14700 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14701
14702         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14703         integers and enumeration types.
14704
14705 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14706
14707         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14708         instead of lookup_symbol_in_language
14709         (do_exact_match): New function.
14710         (ada_get_symbol_name_matcher): Return do_exact_match when
14711         doing a verbatim match.
14712
14713 2019-02-15  Tom Tromey  <tromey@adacore.com>
14714
14715         * ravenscar-thread.c (ravenscar_thread_target::resume)
14716         (ravenscar_thread_target::wait): Special case wildcard requests.
14717
14718 2019-02-15  Tom Tromey  <tromey@adacore.com>
14719
14720         * ravenscar-thread.c (base_ptid): Remove.
14721         (struct ravenscar_thread_target) <close>: New method.
14722         <m_base_ptid>: New member.
14723         <update_inferior_ptid, active_task, task_is_currently_active,
14724         runtime_initialized>: Declare methods.
14725         <ravenscar_thread_target>: Add constructor.
14726         (ravenscar_thread_target::task_is_currently_active)
14727         (ravenscar_thread_target::update_inferior_ptid)
14728         (ravenscar_runtime_initialized): Rename.  Now methods.
14729         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14730         (ravenscar_thread_target::update_thread_list): Update.
14731         (ravenscar_thread_target::active_task): Now method.
14732         (ravenscar_thread_target::store_registers)
14733         (ravenscar_thread_target::prepare_to_store)
14734         (ravenscar_thread_target::prepare_to_store)
14735         (ravenscar_thread_target::mourn_inferior): Update.
14736         (ravenscar_inferior_created): Use "new" to create target.
14737         (ravenscar_thread_target::get_ada_task_ptid): Update.
14738         (_initialize_ravenscar): Don't initialize base_ptid.
14739         (ravenscar_ops): Remove global.
14740
14741 2019-02-15  Tom Tromey  <tromey@adacore.com>
14742
14743         * target.h (push_target): Declare new overload.
14744         * target.c (push_target): New overload, taking an rvalue reference.
14745         * remote.c (remote_target::open_1): Use push_target overload.
14746         * corelow.c (core_target_open): Use push_target overload.
14747
14748 2019-02-15  Tom Tromey  <tromey@adacore.com>
14749
14750         * ravenscar-thread.c (is_ravenscar_task)
14751         (ravenscar_task_is_currently_active): Return bool.
14752         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14753         (_initialize_ravenscar): Remove "(void)".
14754         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14755         Return bool.
14756
14757 2019-02-15  Tom Tromey  <tromey@adacore.com>
14758
14759         * ravenscar-thread.c (ravenscar_runtime_initializer)
14760         (has_ravenscar_runtime, get_running_thread_id)
14761         (ravenscar_thread_target::resume): Fix indentation.
14762
14763 2019-02-15  Tom Tromey  <tromey@adacore.com>
14764
14765         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14766         from ravenscar_arch_ops.
14767         (sparc_ravenscar_ops::fetch_registers)
14768         (sparc_ravenscar_ops::store_registers): Now methods.
14769         (sparc_ravenscar_prepare_to_store): Remove.
14770         (sparc_ravenscar_ops): Redefine.
14771         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14772         methods and destructor.  Remove members.
14773         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14774         (ravenscar_thread_target::store_registers)
14775         (ravenscar_thread_target::prepare_to_store): Update.
14776         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14777         Remove.
14778         (struct ppc_ravenscar_powerpc_ops): Derive from
14779         ravenscar_arch_ops.
14780         (ppc_ravenscar_powerpc_ops::fetch_registers)
14781         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14782         (ppc_ravenscar_powerpc_ops): Redefine.
14783         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14784         (ppc_ravenscar_e500_ops::fetch_registers)
14785         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14786         (ppc_ravenscar_e500_ops): Redefine.
14787         * aarch64-ravenscar-thread.c
14788         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14789         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14790         (aarch64_ravenscar_fetch_registers)
14791         (aarch64_ravenscar_store_registers): Now methods.
14792         (aarch64_ravenscar_ops): Redefine.
14793
14794 2019-02-15  Tom Tromey  <tromey@adacore.com>
14795
14796         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14797         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14798         (ravenscar_thread_target::stopped_by_watchpoint)
14799         (ravenscar_thread_target::stopped_data_address)
14800         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14801
14802 2019-02-15  Tom Tromey  <tromey@adacore.com>
14803
14804         * ravenscar-thread.c: Fix some typos.
14805
14806 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14807             Tom Tromey  <tromey@adacore.com>
14808
14809         * ada-lang.c (ada_exception_sal): Change addr_string to a
14810         std::string.
14811         (create_ada_exception_catchpoint): Update.
14812
14813 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14814             Tom Tromey  <tromey@adacore.com>
14815
14816         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14817         (bp_location_ops): Remove.
14818         (base_breakpoint_allocate_location): Update.
14819         (free_bp_location): Update.
14820         * ada-lang.c (class ada_catchpoint_location)
14821         <ada_catchpoint_location>: Remove ops parameter.
14822         (ada_catchpoint_location_dtor): Remove.
14823         (ada_catchpoint_location_ops): Remove.
14824         (allocate_location_exception): Update.
14825         * breakpoint.h (struct bp_location_ops): Remove.
14826         (class bp_location) <bp_location>: Remove bp_location_ops
14827         parameter.
14828         <~bp_location>: Add destructor.
14829         <ops>: Remove.
14830
14831 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14832             Pedro Alves  <palves@redhat.com>
14833
14834         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14835         'PATH_MAX'.
14836
14837 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14838             Samuel Thibault  <samuel.thibault@gnu.org>
14839             Thomas Schwinge  <thomas@codesourcery.com>
14840
14841         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14842         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14843
14844 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14845
14846         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14847         (check_empty): Use "const char *".
14848
14849         * gnu-nat.c (gnu_nat_target::detach): Instead of
14850         'detach_inferior (pid)' call
14851         'detach_inferior (find_inferior_pid (pid))'.
14852
14853         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14854         'nat/fork-inferior.o'.
14855         * gnu-nat.c: #include "nat/fork-inferior.h".
14856
14857         * gnu-nat.c (gnu_nat_target::detach): Instead of
14858         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14859         * gnu-nat.h: #include "inf-child.h".
14860         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14861         'i386_gnu_nat_target::fetch_registers'.
14862         (gnu_store_registers): Rename/move to
14863         'i386_gnu_nat_target::store_registers'.
14864
14865         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14866         * gnu-nat.h (mach_thread_info): New function.
14867         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14868
14869         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14870
14871 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14872
14873         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14874
14875 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14876
14877         * windows-nat.c (windows_add_thread): Add new parameter
14878         "main_thread_p" with default value set to false.  Update
14879         function documentation as well as all callers.
14880         (windows_delete_thread): Likewise.
14881         (fake_create_process): Update call to windows_add_thread.
14882         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14883         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14884         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14885         call to windows_delete_thread.
14886
14887 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14888
14889         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14890
14891 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14892
14893         * symfile.c (find_separate_debug_file): Use canonical path of
14894         sysroot with child_path instead of gdb_sysroot if it is valid.
14895
14896 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14897
14898         * symfile.c (find_separate_debug_file): Use child_path to
14899         determine if an object file is under a sysroot.
14900
14901 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14902
14903         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14904         unittests/child-path-selftests.c.
14905         * common/pathstuff.c (child_path): New function.
14906         * common/pathstuff.h (child_path): New prototype.
14907         * unittests/child-path-selftests.c: New file.
14908
14909 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14910
14911         * symfile.c (find_separate_debug_file): Look for separate debug
14912         files in debug directories under the sysroot.
14913
14914 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14915
14916         * symtab.h (struct minimal_symbol data_p): New const method.
14917         (struct minimal_symbol text_p): Likewise.
14918         * symtab.c (output_source_filename): Use file name style
14919         to print file name.
14920         (print_symbol_info): Likewise.
14921         (print_msymbol_info): Use address style to print addresses.
14922         Use function name style to print executable text symbols.
14923         (expand_symtab_containing_pc): Use data_p.
14924         (find_pc_sect_compunit_symtab): Likewise.
14925
14926 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14927
14928         * breakpoint.c (describe_other_breakpoints): Use address style
14929         to print addresses.
14930         (say_where): Likewise.
14931
14932 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14933
14934         * ada-typeprint.c (print_func_type): Print function name
14935         style to print function name.
14936         * c-typeprint.c (c_print_type_1): Likewise.
14937
14938 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14939
14940         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14941         for execve.
14942
14943 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14944
14945         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14946         type_stack.
14947
14948 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14949
14950         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14951         TYPE_CODE_REF types.
14952
14953 2019-02-08  Jim Wilson  <jimw@sifive.com>
14954
14955         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14956         (riscv_linux_fregset): New.
14957         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14958
14959 2019-02-07  Tom Tromey  <tom@tromey.com>
14960
14961         * thread.c (thread_cancel_execution_command): Update.
14962         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14963         methods.
14964         (struct thread_fsm_ops): Remove.
14965         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14966         (thread_fsm_should_stop, thread_fsm_return_value)
14967         (thread_fsm_set_finished, thread_fsm_finished_p)
14968         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14969         Don't declare.
14970         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14971         * infrun.c (clear_proceed_status_thread)
14972         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14973         (print_stop_event): Update.
14974         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14975         Add constructor.
14976         (step_command_fsm_ops): Remove.
14977         (new_step_command_fsm): Remove.
14978         (step_1): Update.
14979         (step_command_fsm::should_stop): Rename from
14980         step_command_fsm_should_stop.
14981         (step_command_fsm::clean_up): Rename from
14982         step_command_fsm_clean_up.
14983         (step_command_fsm::do_async_reply_reason): Rename from
14984         step_command_fsm_async_reply_reason.
14985         (struct until_next_fsm): Inherit from thread_fsm.  Add
14986         constructor.
14987         (until_next_fsm_ops): Remove.
14988         (new_until_next_fsm): Remove.
14989         (until_next_fsm::should_stop): Rename from
14990         until_next_fsm_should_stop.
14991         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14992         (until_next_fsm::do_async_reply_reason): Rename from
14993         until_next_fsm_async_reply_reason.
14994         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14995         constructor.  Change type of breakpoint.
14996         (finish_command_fsm_ops): Remove.
14997         (new_finish_command_fsm): Remove.
14998         (finish_command_fsm::should_stop): Rename from
14999         finish_command_fsm_should_stop.
15000         (finish_command_fsm::clean_up): Rename from
15001         finish_command_fsm_clean_up.
15002         (finish_command_fsm::return_value): Rename from
15003         finish_command_fsm_return_value.
15004         (finish_command_fsm::do_async_reply_reason): Rename from
15005         finish_command_fsm_async_reply_reason.
15006         (finish_command): Update.
15007         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15008         Add constructor.
15009         (call_thread_fsm_ops): Remove.
15010         (call_thread_fsm::call_thread_fsm): Rename from
15011         new_call_thread_fsm.
15012         (call_thread_fsm::should_stop): Rename from
15013         call_thread_fsm_should_stop.
15014         (call_thread_fsm::should_notify_stop): Rename from
15015         call_thread_fsm_should_notify_stop.
15016         (run_inferior_call, call_function_by_hand_dummy): Update.
15017         * cli/cli-interp.c (should_print_stop_to_console): Update.
15018         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15019         Add constructor.  Change type of location_breakpoint,
15020         caller_breakpoint.
15021         (until_break_fsm_ops): Remove.
15022         (new_until_break_fsm): Remove.
15023         (until_break_fsm::should_stop): Rename from
15024         until_break_fsm_should_stop.
15025         (until_break_fsm::clean_up): Rename from
15026         until_break_fsm_clean_up.
15027         (until_break_fsm::do_async_reply_reason): Rename from
15028         until_break_fsm_async_reply_reason.
15029         (until_break_command): Update.
15030         * thread-fsm.c: Remove.
15031         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15032
15033 2019-02-07  Tom Tromey  <tom@tromey.com>
15034
15035         * yy-remap.h: Add include guard.
15036         * xtensa-tdep.h: Add include guard.
15037         * xcoffread.h: Rename include guard.
15038         * varobj-iter.h: Add include guard.
15039         * tui/tui.h: Rename include guard.
15040         * tui/tui-winsource.h: Rename include guard.
15041         * tui/tui-wingeneral.h: Rename include guard.
15042         * tui/tui-windata.h: Rename include guard.
15043         * tui/tui-win.h: Rename include guard.
15044         * tui/tui-stack.h: Rename include guard.
15045         * tui/tui-source.h: Rename include guard.
15046         * tui/tui-regs.h: Rename include guard.
15047         * tui/tui-out.h: Rename include guard.
15048         * tui/tui-layout.h: Rename include guard.
15049         * tui/tui-io.h: Rename include guard.
15050         * tui/tui-hooks.h: Rename include guard.
15051         * tui/tui-file.h: Rename include guard.
15052         * tui/tui-disasm.h: Rename include guard.
15053         * tui/tui-data.h: Rename include guard.
15054         * tui/tui-command.h: Rename include guard.
15055         * tic6x-tdep.h: Add include guard.
15056         * target/waitstatus.h: Rename include guard.
15057         * target/wait.h: Rename include guard.
15058         * target/target.h: Rename include guard.
15059         * target/resume.h: Rename include guard.
15060         * target-float.h: Rename include guard.
15061         * stabsread.h: Add include guard.
15062         * rs6000-tdep.h: Add include guard.
15063         * riscv-fbsd-tdep.h: Add include guard.
15064         * regformats/regdef.h: Rename include guard.
15065         * record.h: Rename include guard.
15066         * python/python.h: Rename include guard.
15067         * python/python-internal.h: Rename include guard.
15068         * python/py-stopevent.h: Rename include guard.
15069         * python/py-ref.h: Rename include guard.
15070         * python/py-record.h: Rename include guard.
15071         * python/py-record-full.h: Rename include guard.
15072         * python/py-record-btrace.h: Rename include guard.
15073         * python/py-instruction.h: Rename include guard.
15074         * python/py-events.h: Rename include guard.
15075         * python/py-event.h: Rename include guard.
15076         * procfs.h: Add include guard.
15077         * proc-utils.h: Add include guard.
15078         * p-lang.h: Add include guard.
15079         * or1k-tdep.h: Rename include guard.
15080         * observable.h: Rename include guard.
15081         * nto-tdep.h: Rename include guard.
15082         * nat/x86-linux.h: Rename include guard.
15083         * nat/x86-linux-dregs.h: Rename include guard.
15084         * nat/x86-gcc-cpuid.h: Add include guard.
15085         * nat/x86-dregs.h: Rename include guard.
15086         * nat/x86-cpuid.h: Rename include guard.
15087         * nat/ppc-linux.h: Rename include guard.
15088         * nat/mips-linux-watch.h: Rename include guard.
15089         * nat/linux-waitpid.h: Rename include guard.
15090         * nat/linux-ptrace.h: Rename include guard.
15091         * nat/linux-procfs.h: Rename include guard.
15092         * nat/linux-osdata.h: Rename include guard.
15093         * nat/linux-nat.h: Rename include guard.
15094         * nat/linux-namespaces.h: Rename include guard.
15095         * nat/linux-btrace.h: Rename include guard.
15096         * nat/glibc_thread_db.h: Rename include guard.
15097         * nat/gdb_thread_db.h: Rename include guard.
15098         * nat/gdb_ptrace.h: Rename include guard.
15099         * nat/fork-inferior.h: Rename include guard.
15100         * nat/amd64-linux-siginfo.h: Rename include guard.
15101         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15102         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15103         * nat/aarch64-linux.h: Rename include guard.
15104         * nat/aarch64-linux-hw-point.h: Rename include guard.
15105         * mn10300-tdep.h: Add include guard.
15106         * mips-linux-tdep.h: Add include guard.
15107         * mi/mi-parse.h: Rename include guard.
15108         * mi/mi-out.h: Rename include guard.
15109         * mi/mi-main.h: Rename include guard.
15110         * mi/mi-interp.h: Rename include guard.
15111         * mi/mi-getopt.h: Rename include guard.
15112         * mi/mi-console.h: Rename include guard.
15113         * mi/mi-common.h: Rename include guard.
15114         * mi/mi-cmds.h: Rename include guard.
15115         * mi/mi-cmd-break.h: Rename include guard.
15116         * m2-lang.h: Add include guard.
15117         * location.h: Rename include guard.
15118         * linux-record.h: Rename include guard.
15119         * linux-nat.h: Add include guard.
15120         * linux-fork.h: Add include guard.
15121         * i386-darwin-tdep.h: Rename include guard.
15122         * hppa-linux-offsets.h: Add include guard.
15123         * guile/guile.h: Rename include guard.
15124         * guile/guile-internal.h: Rename include guard.
15125         * gnu-nat.h: Rename include guard.
15126         * gdb-stabs.h: Rename include guard.
15127         * frv-tdep.h: Add include guard.
15128         * f-lang.h: Add include guard.
15129         * event-loop.h: Add include guard.
15130         * darwin-nat.h: Rename include guard.
15131         * cp-abi.h: Rename include guard.
15132         * config/sparc/nm-sol2.h: Rename include guard.
15133         * config/nm-nto.h: Rename include guard.
15134         * config/nm-linux.h: Add include guard.
15135         * config/i386/nm-i386gnu.h: Rename include guard.
15136         * config/djgpp/nl_types.h: Rename include guard.
15137         * config/djgpp/langinfo.h: Rename include guard.
15138         * compile/gcc-cp-plugin.h: Add include guard.
15139         * compile/gcc-c-plugin.h: Add include guard.
15140         * compile/compile.h: Rename include guard.
15141         * compile/compile-object-run.h: Rename include guard.
15142         * compile/compile-object-load.h: Rename include guard.
15143         * compile/compile-internal.h: Rename include guard.
15144         * compile/compile-cplus.h: Rename include guard.
15145         * compile/compile-c.h: Rename include guard.
15146         * common/xml-utils.h: Rename include guard.
15147         * common/x86-xstate.h: Rename include guard.
15148         * common/version.h: Rename include guard.
15149         * common/vec.h: Rename include guard.
15150         * common/tdesc.h: Rename include guard.
15151         * common/selftest.h: Rename include guard.
15152         * common/scoped_restore.h: Rename include guard.
15153         * common/scoped_mmap.h: Rename include guard.
15154         * common/scoped_fd.h: Rename include guard.
15155         * common/safe-iterator.h: Rename include guard.
15156         * common/run-time-clock.h: Rename include guard.
15157         * common/refcounted-object.h: Rename include guard.
15158         * common/queue.h: Rename include guard.
15159         * common/ptid.h: Rename include guard.
15160         * common/print-utils.h: Rename include guard.
15161         * common/preprocessor.h: Rename include guard.
15162         * common/pathstuff.h: Rename include guard.
15163         * common/observable.h: Rename include guard.
15164         * common/netstuff.h: Rename include guard.
15165         * common/job-control.h: Rename include guard.
15166         * common/host-defs.h: Rename include guard.
15167         * common/gdb_wait.h: Rename include guard.
15168         * common/gdb_vecs.h: Rename include guard.
15169         * common/gdb_unlinker.h: Rename include guard.
15170         * common/gdb_unique_ptr.h: Rename include guard.
15171         * common/gdb_tilde_expand.h: Rename include guard.
15172         * common/gdb_sys_time.h: Rename include guard.
15173         * common/gdb_string_view.h: Rename include guard.
15174         * common/gdb_splay_tree.h: Rename include guard.
15175         * common/gdb_setjmp.h: Rename include guard.
15176         * common/gdb_ref_ptr.h: Rename include guard.
15177         * common/gdb_optional.h: Rename include guard.
15178         * common/gdb_locale.h: Rename include guard.
15179         * common/gdb_assert.h: Rename include guard.
15180         * common/filtered-iterator.h: Rename include guard.
15181         * common/filestuff.h: Rename include guard.
15182         * common/fileio.h: Rename include guard.
15183         * common/environ.h: Rename include guard.
15184         * common/common-utils.h: Rename include guard.
15185         * common/common-types.h: Rename include guard.
15186         * common/common-regcache.h: Rename include guard.
15187         * common/common-inferior.h: Rename include guard.
15188         * common/common-gdbthread.h: Rename include guard.
15189         * common/common-exceptions.h: Rename include guard.
15190         * common/common-defs.h: Rename include guard.
15191         * common/common-debug.h: Rename include guard.
15192         * common/cleanups.h: Rename include guard.
15193         * common/buffer.h: Rename include guard.
15194         * common/btrace-common.h: Rename include guard.
15195         * common/break-common.h: Rename include guard.
15196         * cli/cli-utils.h: Rename include guard.
15197         * cli/cli-style.h: Rename include guard.
15198         * cli/cli-setshow.h: Rename include guard.
15199         * cli/cli-script.h: Rename include guard.
15200         * cli/cli-interp.h: Rename include guard.
15201         * cli/cli-decode.h: Rename include guard.
15202         * cli/cli-cmds.h: Rename include guard.
15203         * charset-list.h: Add include guard.
15204         * buildsym-legacy.h: Rename include guard.
15205         * bfin-tdep.h: Add include guard.
15206         * ax.h: Rename include guard.
15207         * arm-linux-tdep.h: Add include guard.
15208         * arm-fbsd-tdep.h: Add include guard.
15209         * arch/xtensa.h: Rename include guard.
15210         * arch/tic6x.h: Add include guard.
15211         * arch/i386.h: Add include guard.
15212         * arch/arm.h: Rename include guard.
15213         * arch/arm-linux.h: Rename include guard.
15214         * arch/arm-get-next-pcs.h: Rename include guard.
15215         * arch/amd64.h: Add include guard.
15216         * arch/aarch64-insn.h: Rename include guard.
15217         * arch-utils.h: Rename include guard.
15218         * annotate.h: Add include guard.
15219         * amd64-darwin-tdep.h: Rename include guard.
15220         * aarch64-linux-tdep.h: Add include guard.
15221         * aarch64-fbsd-tdep.h: Add include guard.
15222         * aarch32-linux-nat.h: Add include guard.
15223
15224 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15225
15226         * macrotab.c (macro_define_internal): New function that
15227         factorizes macro_define_object_internal and macro_define_function
15228         code.
15229         (macro_define_object_internal): Use macro_define_internal.
15230         (macro_define_function): Likewise.
15231
15232 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15233
15234         * macrocmd.c (extract_identifier): Return
15235         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15236         callers.
15237
15238 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15239
15240         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15241
15242 2019-02-05  Tom Tromey  <tom@tromey.com>
15243
15244         * target.c (target_stack::unpush): Move assertion earlier.
15245
15246 2019-01-30  Tom Tromey  <tom@tromey.com>
15247
15248         PR python/23615:
15249         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15250         (gdbpy_parse_and_eval): Likewise.
15251         * python/python-internal.h (gdbpy_allow_threads): New class.
15252
15253 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15254
15255         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15256         (aarch64_fbsd_fpregmap): Move earlier.
15257         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15258         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15259         instead of individual calls to trad_frame_set_reg_addr.
15260         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15261         earlier.
15262         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15263         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15264         instead of individual calls to trad_frame_set_reg_addr.
15265
15266 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15267
15268         * CONTRIBUTE: Replace contribution list with wiki link.
15269
15270 2019-01-25  Tom Tromey  <tom@tromey.com>
15271
15272         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15273
15274 2019-01-25  Tom Tromey  <tom@tromey.com>
15275
15276         * xtensa-linux-nat.c: Fix common/ includes.
15277         * xml-support.h: Fix common/ includes.
15278         * xml-support.c: Fix common/ includes.
15279         * x86-linux-nat.c: Fix common/ includes.
15280         * windows-nat.c: Fix common/ includes.
15281         * varobj.h: Fix common/ includes.
15282         * varobj.c: Fix common/ includes.
15283         * value.c: Fix common/ includes.
15284         * valops.c: Fix common/ includes.
15285         * utils.c: Fix common/ includes.
15286         * unittests/xml-utils-selftests.c: Fix common/ includes.
15287         * unittests/utils-selftests.c: Fix common/ includes.
15288         * unittests/unpack-selftests.c: Fix common/ includes.
15289         * unittests/tracepoint-selftests.c: Fix common/ includes.
15290         * unittests/style-selftests.c: Fix common/ includes.
15291         * unittests/string_view-selftests.c: Fix common/ includes.
15292         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15293         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15294         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15295         * unittests/rsp-low-selftests.c: Fix common/ includes.
15296         * unittests/parse-connection-spec-selftests.c: Fix common/
15297         includes.
15298         * unittests/optional-selftests.c: Fix common/ includes.
15299         * unittests/offset-type-selftests.c: Fix common/ includes.
15300         * unittests/observable-selftests.c: Fix common/ includes.
15301         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15302         * unittests/memrange-selftests.c: Fix common/ includes.
15303         * unittests/memory-map-selftests.c: Fix common/ includes.
15304         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15305         * unittests/function-view-selftests.c: Fix common/ includes.
15306         * unittests/environ-selftests.c: Fix common/ includes.
15307         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15308         * unittests/common-utils-selftests.c: Fix common/ includes.
15309         * unittests/cli-utils-selftests.c: Fix common/ includes.
15310         * unittests/array-view-selftests.c: Fix common/ includes.
15311         * ui-file.c: Fix common/ includes.
15312         * tui/tui-io.c: Fix common/ includes.
15313         * tracepoint.h: Fix common/ includes.
15314         * tracepoint.c: Fix common/ includes.
15315         * tracefile-tfile.c: Fix common/ includes.
15316         * top.h: Fix common/ includes.
15317         * top.c: Fix common/ includes.
15318         * thread.c: Fix common/ includes.
15319         * target/waitstatus.h: Fix common/ includes.
15320         * target/waitstatus.c: Fix common/ includes.
15321         * target.h: Fix common/ includes.
15322         * target.c: Fix common/ includes.
15323         * target-memory.c: Fix common/ includes.
15324         * target-descriptions.c: Fix common/ includes.
15325         * symtab.h: Fix common/ includes.
15326         * symfile.c: Fix common/ includes.
15327         * stap-probe.c: Fix common/ includes.
15328         * spu-linux-nat.c: Fix common/ includes.
15329         * sparc-nat.c: Fix common/ includes.
15330         * source.c: Fix common/ includes.
15331         * solib.c: Fix common/ includes.
15332         * solib-target.c: Fix common/ includes.
15333         * ser-unix.c: Fix common/ includes.
15334         * ser-tcp.c: Fix common/ includes.
15335         * ser-pipe.c: Fix common/ includes.
15336         * ser-base.c: Fix common/ includes.
15337         * selftest-arch.c: Fix common/ includes.
15338         * s12z-tdep.c: Fix common/ includes.
15339         * rust-exp.y: Fix common/ includes.
15340         * rs6000-aix-tdep.c: Fix common/ includes.
15341         * riscv-tdep.c: Fix common/ includes.
15342         * remote.c: Fix common/ includes.
15343         * remote-notif.h: Fix common/ includes.
15344         * remote-fileio.h: Fix common/ includes.
15345         * remote-fileio.c: Fix common/ includes.
15346         * regcache.h: Fix common/ includes.
15347         * regcache.c: Fix common/ includes.
15348         * record-btrace.c: Fix common/ includes.
15349         * python/python.c: Fix common/ includes.
15350         * python/py-type.c: Fix common/ includes.
15351         * python/py-inferior.c: Fix common/ includes.
15352         * progspace.h: Fix common/ includes.
15353         * producer.c: Fix common/ includes.
15354         * procfs.c: Fix common/ includes.
15355         * proc-api.c: Fix common/ includes.
15356         * printcmd.c: Fix common/ includes.
15357         * ppc-linux-nat.c: Fix common/ includes.
15358         * parser-defs.h: Fix common/ includes.
15359         * osdata.c: Fix common/ includes.
15360         * obsd-nat.c: Fix common/ includes.
15361         * nat/x86-linux.c: Fix common/ includes.
15362         * nat/x86-linux-dregs.c: Fix common/ includes.
15363         * nat/x86-dregs.h: Fix common/ includes.
15364         * nat/x86-dregs.c: Fix common/ includes.
15365         * nat/ppc-linux.c: Fix common/ includes.
15366         * nat/mips-linux-watch.h: Fix common/ includes.
15367         * nat/mips-linux-watch.c: Fix common/ includes.
15368         * nat/linux-waitpid.c: Fix common/ includes.
15369         * nat/linux-ptrace.h: Fix common/ includes.
15370         * nat/linux-ptrace.c: Fix common/ includes.
15371         * nat/linux-procfs.c: Fix common/ includes.
15372         * nat/linux-personality.c: Fix common/ includes.
15373         * nat/linux-osdata.c: Fix common/ includes.
15374         * nat/linux-namespaces.c: Fix common/ includes.
15375         * nat/linux-btrace.h: Fix common/ includes.
15376         * nat/linux-btrace.c: Fix common/ includes.
15377         * nat/fork-inferior.c: Fix common/ includes.
15378         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15379         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15380         * nat/aarch64-linux.c: Fix common/ includes.
15381         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15382         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15383         * namespace.h: Fix common/ includes.
15384         * mips-linux-tdep.c: Fix common/ includes.
15385         * minsyms.c: Fix common/ includes.
15386         * mi/mi-parse.h: Fix common/ includes.
15387         * mi/mi-main.c: Fix common/ includes.
15388         * mi/mi-cmd-env.c: Fix common/ includes.
15389         * memrange.h: Fix common/ includes.
15390         * memattr.c: Fix common/ includes.
15391         * maint.h: Fix common/ includes.
15392         * maint.c: Fix common/ includes.
15393         * main.c: Fix common/ includes.
15394         * machoread.c: Fix common/ includes.
15395         * location.c: Fix common/ includes.
15396         * linux-thread-db.c: Fix common/ includes.
15397         * linux-nat.c: Fix common/ includes.
15398         * linux-fork.c: Fix common/ includes.
15399         * inline-frame.c: Fix common/ includes.
15400         * infrun.c: Fix common/ includes.
15401         * inflow.c: Fix common/ includes.
15402         * inferior.h: Fix common/ includes.
15403         * inferior.c: Fix common/ includes.
15404         * infcmd.c: Fix common/ includes.
15405         * inf-ptrace.c: Fix common/ includes.
15406         * inf-child.c: Fix common/ includes.
15407         * ia64-linux-nat.c: Fix common/ includes.
15408         * i387-tdep.c: Fix common/ includes.
15409         * i386-tdep.c: Fix common/ includes.
15410         * i386-linux-tdep.c: Fix common/ includes.
15411         * i386-linux-nat.c: Fix common/ includes.
15412         * i386-go32-tdep.c: Fix common/ includes.
15413         * i386-fbsd-tdep.c: Fix common/ includes.
15414         * i386-fbsd-nat.c: Fix common/ includes.
15415         * guile/scm-type.c: Fix common/ includes.
15416         * guile/guile.c: Fix common/ includes.
15417         * go32-nat.c: Fix common/ includes.
15418         * gnu-nat.c: Fix common/ includes.
15419         * gdbthread.h: Fix common/ includes.
15420         * gdbarch-selftests.c: Fix common/ includes.
15421         * gdb_usleep.c: Fix common/ includes.
15422         * gdb_select.h: Fix common/ includes.
15423         * gdb_bfd.c: Fix common/ includes.
15424         * gcore.c: Fix common/ includes.
15425         * fork-child.c: Fix common/ includes.
15426         * findvar.c: Fix common/ includes.
15427         * fbsd-nat.c: Fix common/ includes.
15428         * event-top.c: Fix common/ includes.
15429         * event-loop.c: Fix common/ includes.
15430         * dwarf2read.c: Fix common/ includes.
15431         * dwarf2loc.c: Fix common/ includes.
15432         * dwarf2-frame.c: Fix common/ includes.
15433         * dwarf-index-cache.c: Fix common/ includes.
15434         * dtrace-probe.c: Fix common/ includes.
15435         * disasm-selftests.c: Fix common/ includes.
15436         * defs.h: Fix common/ includes.
15437         * csky-tdep.c: Fix common/ includes.
15438         * cp-valprint.c: Fix common/ includes.
15439         * cp-support.h: Fix common/ includes.
15440         * cp-support.c: Fix common/ includes.
15441         * corelow.c: Fix common/ includes.
15442         * completer.h: Fix common/ includes.
15443         * completer.c: Fix common/ includes.
15444         * compile/compile.c: Fix common/ includes.
15445         * compile/compile-loc2c.c: Fix common/ includes.
15446         * compile/compile-cplus-types.c: Fix common/ includes.
15447         * compile/compile-cplus-symbols.c: Fix common/ includes.
15448         * command.h: Fix common/ includes.
15449         * cli/cli-dump.c: Fix common/ includes.
15450         * cli/cli-cmds.c: Fix common/ includes.
15451         * charset.c: Fix common/ includes.
15452         * build-id.c: Fix common/ includes.
15453         * btrace.h: Fix common/ includes.
15454         * btrace.c: Fix common/ includes.
15455         * breakpoint.h: Fix common/ includes.
15456         * breakpoint.c: Fix common/ includes.
15457         * ax.h:
15458         (enum agent_op): Fix common/ includes.
15459         * ax-general.c (struct aop_map): Fix common/ includes.
15460         * ax-gdb.c: Fix common/ includes.
15461         * auxv.c: Fix common/ includes.
15462         * auto-load.c: Fix common/ includes.
15463         * arm-tdep.c: Fix common/ includes.
15464         * arch/riscv.c: Fix common/ includes.
15465         * arch/ppc-linux-common.c: Fix common/ includes.
15466         * arch/i386.c: Fix common/ includes.
15467         * arch/arm.c: Fix common/ includes.
15468         * arch/arm-linux.c: Fix common/ includes.
15469         * arch/arm-get-next-pcs.c: Fix common/ includes.
15470         * arch/amd64.c: Fix common/ includes.
15471         * arch/aarch64.c: Fix common/ includes.
15472         * arch/aarch64-insn.c: Fix common/ includes.
15473         * arch-utils.c: Fix common/ includes.
15474         * amd64-windows-tdep.c: Fix common/ includes.
15475         * amd64-tdep.c: Fix common/ includes.
15476         * amd64-sol2-tdep.c: Fix common/ includes.
15477         * amd64-obsd-tdep.c: Fix common/ includes.
15478         * amd64-nbsd-tdep.c: Fix common/ includes.
15479         * amd64-linux-tdep.c: Fix common/ includes.
15480         * amd64-linux-nat.c: Fix common/ includes.
15481         * amd64-fbsd-tdep.c: Fix common/ includes.
15482         * amd64-fbsd-nat.c: Fix common/ includes.
15483         * amd64-dicos-tdep.c: Fix common/ includes.
15484         * amd64-darwin-tdep.c: Fix common/ includes.
15485         * agent.c: Fix common/ includes.
15486         * ada-lang.h: Fix common/ includes.
15487         * ada-lang.c: Fix common/ includes.
15488         * aarch64-tdep.c: Fix common/ includes.
15489
15490 2019-01-25  Tom Tromey  <tom@tromey.com>
15491
15492         * common/create-version.sh: Use common/version.h.
15493
15494 2019-01-24  Pedro Alves  <palves@redhat.com>
15495
15496         * infrun.c (signal_stop, signal_print, signal_program)
15497         (signal_catch, signal_pass): Now arrays instead of pointers.
15498         (update_signals_program_target, do_target_resume)
15499         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15500         * linux-nat.c (linux_nat_target::pass_signals)
15501         (linux_nat_target::create_inferior, linux_nat_target::attach):
15502         Adjust.
15503         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15504         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15505         * procfs.c (procfs_target::pass_signals): Adjust.
15506         * record-full.c (record_full_target::resume): Adjust.
15507         * remote.c (remote_target::pass_signals)
15508         (remote_target::program_signals): Adjust.
15509         * target-debug.h (target_debug_print_signals): Now takes a
15510         gdb::array_view as parameter.  Adjust.
15511         * target.h (target_ops) <pass_signals, program_signals>: Replace
15512         pointer and length parameters with gdb::array_view.
15513         (target_pass_signals, target_program_signals): Likewise.
15514         * target-delegates.c: Regenerate.
15515
15516 2019-01-24  Pedro Alves  <palves@redhat.com>
15517
15518         * common/forward-scope-exit.h
15519         (forward_scope_exit::forward_scope_exit): Pass arguments to
15520         m_bind_function directly, instead of creating a std::bind and
15521         copying that.
15522
15523 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15524
15525         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15526         for static members.
15527         (pass_in_v_vfp_candidate): Likewise.
15528
15529 2019-01-23  Tom Tromey  <tom@tromey.com>
15530             Pedro Alves  <palves@redhat.com>
15531
15532         * regcache.c (class regcache_invalidator): Remove.
15533         (regcache::raw_write): Use make_scope_exit.
15534
15535 2019-01-23  Tom Tromey  <tom@tromey.com>
15536
15537         * ui-out.h (class ui_out_emit_type): Update comment.
15538
15539 2019-01-23  Tom Tromey  <tom@tromey.com>
15540
15541         * infrun.c (fetch_inferior_event): Update comment.
15542
15543 2019-01-23  Tom Tromey  <tom@tromey.com>
15544             Pedro Alves  <palves@redhat.com>
15545
15546         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15547         parameter.
15548         (fetch_inferior_event): Use SCOPE_EXIT.
15549
15550
15551 2019-01-23  Tom Tromey  <tom@tromey.com>
15552             Pedro Alves  <palves@redhat.com>
15553
15554         * infrun.c (disable_thread_events): Delete.
15555         (stop_all_threads): Use SCOPE_EXIT.
15556
15557 2019-01-23  Tom Tromey  <tom@tromey.com>
15558             Pedro Alves  <palves@redhat.com>
15559
15560         * symfile.c: Include forward-scope-exit.h.
15561         (clear_symtab_users_cleanup): Replace forward declaration with
15562         a FORWARD_SCOPE_EXIT.
15563         (syms_from_objfile_1): Use the forward_scope_exit and
15564         gdb::optional instead of cleanup_function.
15565         (reread_symbols): Use the forward_scope_exit instead of
15566         cleanup_function.
15567         (clear_symtab_users_cleanup): Remove function.
15568
15569 2019-01-23  Tom Tromey  <tom@tromey.com>
15570             Pedro Alves  <palves@redhat.com>
15571
15572         * linux-nat.c: Include scope-exit.h.
15573         (cleanup_target_stop): Remove.
15574         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15575         SCOPE_EXIT.
15576
15577 2019-01-23  Tom Tromey  <tom@tromey.com>
15578             Pedro Alves  <palves@redhat.com>
15579
15580         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15581         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15582
15583 2019-01-23  Tom Tromey  <tom@tromey.com>
15584             Andrew Burgess  <andrew.burgess@embecosm.com>
15585             Pedro Alves  <palves@redhat.com>
15586
15587         * infrun.c (fetch_inferior_event): Use scope_exit.
15588         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15589         * top.c (execute_command): Use scope_exit.
15590         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15591         * utils.c (do_bpstat_clear_actions_cleanup)
15592         (make_bpstat_clear_actions_cleanup): Remove.
15593
15594 2019-01-23  Tom Tromey  <tom@tromey.com>
15595             Pedro Alves  <palves@redhat.com>
15596
15597         * infrun.c: Include "common/scope-exit.h"
15598         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15599         (wait_for_inferior): Use SCOPE_EXIT.
15600         (fetch_inferior_event): Use scope_exit.
15601
15602 2019-01-23  Tom Tromey  <tom@tromey.com>
15603             Pedro Alves  <palves@redhat.com>
15604
15605         * breakpoint.c (create_breakpoint): Remove cleanup.
15606
15607 2019-01-23  Tom Tromey  <tom@tromey.com>
15608             Andrew Burgess  <andrew.burgess@embecosm.com>
15609             Pedro Alves  <palves@redhat.com>
15610
15611 2019-01-23  Pedro Alves  <palves@redhat.com>
15612
15613         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15614
15615 2019-01-23  Pedro Alves  <palves@redhat.com>
15616             Andrew Burgess  <andrew.burgess@embecosm.com>
15617
15618         * gdbthread.h: Include "common/forward-scope-exit.h".
15619         (scoped_finish_thread_state): Redefine custom class in terms of
15620         forward_scope_exit.
15621
15622 2019-01-23  Pedro Alves  <palves@redhat.com>
15623             Andrew Burgess  <andrew.burgess@embecosm.com>
15624
15625         * common/forward-scope-exit.h: New file.
15626
15627 2019-01-23  Pedro Alves  <palves@redhat.com>
15628             Andrew Burgess  <andrew.burgess@embecosm.com>
15629             Tom Tromey  <tom@tromey.com>
15630
15631         * common/scope-exit.h: New file.
15632
15633 2019-01-23  Pedro Alves  <palves@redhat.com>
15634
15635         * common/preprocessor.h (ESC): Rename to ...
15636         (ESC_PARENS): ... this.
15637         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15638         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15639
15640 2019-01-23  Tom Tromey  <tom@tromey.com>
15641
15642         * language.h (class scoped_switch_to_sym_language_if_auto):
15643         Initialize m_lang in both cases.
15644
15645 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15646
15647         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15648         with XCNEW.
15649
15650 2019-01-22  Tom Tromey  <tom@tromey.com>
15651
15652         * corelow.c: Do not include sys/file.h.
15653
15654 2019-01-22  Tom Tromey  <tom@tromey.com>
15655
15656         * tui/tui-wingeneral.h: Include gdb_curses.h.
15657
15658 2019-01-22  Tom Tromey  <tom@tromey.com>
15659
15660         * source-cache.h (class source_cache) <get_source_lines,
15661         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15662
15663 2019-01-22  Tom Tromey  <tom@tromey.com>
15664
15665         * remote-fileio.h (struct remote_target): Declare.
15666
15667 2019-01-22  Tom Tromey  <tom@tromey.com>
15668
15669         * python/py-arch.c: Do not include py-ref.h.
15670         * python/py-bpevent.c: Do not include py-ref.h.
15671         * python/py-cmd.c: Do not include py-ref.h.
15672         * python/py-continueevent.c: Do not include py-ref.h.
15673         * python/py-event.h: Do not include py-ref.h.
15674         * python/py-evtregistry.c: Do not include py-ref.h.
15675         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15676         * python/py-frame.c: Do not include py-ref.h.
15677         * python/py-framefilter.c: Do not include py-ref.h.
15678         * python/py-function.c: Do not include py-ref.h.
15679         * python/py-infevents.c: Do not include py-ref.h.
15680         * python/py-linetable.c: Do not include py-ref.h.
15681         * python/py-objfile.c: Do not include py-ref.h.
15682         * python/py-param.c: Do not include py-ref.h.
15683         * python/py-prettyprint.c: Do not include py-ref.h.
15684         * python/py-progspace.c: Do not include py-ref.h.
15685         * python/py-symbol.c: Do not include py-ref.h.
15686         * python/py-symtab.c: Do not include py-ref.h.
15687         * python/py-type.c: Do not include py-ref.h.
15688         * python/py-unwind.c: Do not include py-ref.h.
15689         * python/py-utils.c: Do not include py-ref.h.
15690         * python/py-value.c: Do not include py-ref.h.
15691         * python/py-varobj.c: Do not include py-ref.h.
15692         * python/py-xmethods.c: Do not include py-ref.h.
15693         * python/python.c: Do not include py-ref.h.
15694         * varobj.c: Do not include py-ref.h.
15695
15696 2019-01-22  Tom Tromey  <tom@tromey.com>
15697
15698         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15699         keyword for bcache.
15700
15701 2019-01-22  Tom Tromey  <tom@tromey.com>
15702
15703         * compile/compile-cplus-types.c: Remove a comment by #include.
15704
15705 2019-01-22  Tom Tromey  <tom@tromey.com>
15706
15707         * compile/gcc-c-plugin.h: Include compile-internal.h.
15708
15709 2019-01-22  Tom Tromey  <tom@tromey.com>
15710
15711         * stabsread.c (EXTERN): Do not define.
15712         (symnum, next_symbol_text_func, processing_gcc_compilation)
15713         (within_function, global_sym_chain, global_stabs)
15714         (previous_stab_code, this_object_header_files)
15715         (n_this_object_header_files)
15716         (n_allocated_this_object_header_files): Define.
15717         * stabsread.h (EXTERN): Never define.  Use "extern".
15718
15719 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15720
15721         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15722         history_value.
15723
15724 2019-01-21  Tom Tromey  <tom@tromey.com>
15725
15726         * ui-out.c: Fix includes.
15727         * tui/tui-source.c: Fix includes.
15728         * target.c: Fix includes.
15729         * remote.c: Fix includes.
15730         * regcache.c: Fix includes.
15731         * python/py-block.c: Fix includes.
15732         * printcmd.c: Fix includes.
15733         * or1k-tdep.c: Fix includes.
15734         * mi/mi-main.c: Fix includes.
15735         * m32r-tdep.c: Fix includes.
15736         * csky-tdep.c: Fix includes.
15737         * compile/compile-cplus-types.c: Fix includes.
15738         * cli/cli-interp.c: Fix includes.
15739
15740 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15741
15742         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15743         for padding.
15744
15745 2019-01-16  Tom Tromey  <tom@tromey.com>
15746
15747         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15748         earlier.
15749         (struct objfile) <msymbols_range>: Move from top level.
15750         <msymbols>: New method.
15751         (class objfile_msymbols): Remove.
15752         * symtab.c (default_collect_symbol_completion_matches_break_on):
15753         Update.
15754         * symmisc.c (dump_msymbols): Update.
15755         * stabsread.c (scan_file_globals): Update.
15756         * objc-lang.c (info_selectors_command, info_classes_command)
15757         (find_methods): Update.
15758         * minsyms.c (find_solib_trampoline_target): Update.
15759         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15760         * coffread.c (coff_symfile_read): Update.
15761         * ada-lang.c (ada_lookup_simple_minsym)
15762         (ada_collect_symbol_completion_matches): Update.
15763
15764 2019-01-16  Tom Tromey  <tom@tromey.com>
15765
15766         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15767         type.  Remove no-argument constructor.
15768         <iterator::operator++>: Simplify.
15769         <begin>: Update.
15770         <end>: Use minimal_symbol_count.
15771
15772 2019-01-16  Tom Tromey  <tom@tromey.com>
15773
15774         * objfiles.h (struct objfile) <psymtabs>: New method.
15775         (class objfile_psymtabs): Remove.
15776         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15777         typedef.
15778         <range>: New method.
15779         (require_partial_symbols): Change return type.
15780         * psymtab.c (require_partial_symbols)
15781         (psym_expand_symtabs_matching): Update.
15782         * mdebugread.c (parse_partial_symbols): Update.
15783         * dbxread.c (dbx_end_psymtab): Update.
15784
15785 2019-01-15  Tom Tromey  <tom@tromey.com>
15786
15787         * symtab.c (lookup_objfile_from_block)
15788         (lookup_symbol_in_objfile_symtabs)
15789         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15790         (find_line_symtab, info_sources_command)
15791         (default_collect_symbol_completion_matches_break_on)
15792         (make_source_files_completion_list): Update.
15793         * symmisc.c (print_objfile_statistics, dump_objfile)
15794         (maintenance_print_symbols, maintenance_info_symtabs)
15795         (maintenance_check_symtabs, maintenance_info_line_tables):
15796         Update.
15797         * source.c (select_source_symtab)
15798         (forget_cached_source_info_for_objfile): Update.
15799         * objfiles.h (class objfile_compunits): Remove.
15800         (struct objfile) <compunits_range>: New typedef.
15801         (compunits): New method.
15802         * objfiles.c (objfile_relocate1): Update.
15803         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15804         * maint.c (count_symtabs_and_blocks): Update.
15805         * linespec.c (iterate_over_all_matching_symtabs): Update.
15806         * cp-support.c (add_symbol_overload_list_qualified): Update.
15807         * coffread.c (coff_symtab_read): Update.
15808         * ada-lang.c (add_nonlocal_symbols)
15809         (ada_collect_symbol_completion_matches)
15810         (ada_add_global_exceptions): Update.
15811
15812 2019-01-15  Tom Tromey  <tom@tromey.com>
15813
15814         * progspace.h (program_space) <objfiles_safe_range>: New
15815         typedef.
15816         <objfiles_safe>: New method.
15817         * objfiles.h (class all_objfiles_safe): Remove.
15818         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15819         * jit.c (jit_inferior_exit_hook): Update.
15820
15821 2019-01-17  Tom Tromey  <tom@tromey.com>
15822
15823         * progspace.h (program_space) <objfiles_range>: New typedef.
15824         <objfiles>: New method.
15825         <objfiles_head>: Rename from objfiles.
15826         (object_files): Update.
15827         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15828         * guile/scm-pretty-print.c
15829         (ppscm_find_pretty_printer_from_objfiles): Update.
15830         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15831         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15832         Update.
15833         * python/py-progspace.c (pspy_get_objfiles): Update.
15834         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15835         Update.
15836         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15837         (objfpy_lookup_objfile_by_build_id): Update.
15838         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15839         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15840         Update.
15841         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15842         (expand_symtab_containing_pc, lookup_objfile_from_block)
15843         (lookup_static_symbol, basic_lookup_transparent_type)
15844         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15845         (find_line_symtab, info_sources_command)
15846         (default_collect_symbol_completion_matches_break_on)
15847         (make_source_files_completion_list, find_main_name): Update.
15848         * symmisc.c (print_symbol_bcache_statistics)
15849         (print_objfile_statistics, maintenance_print_symbols)
15850         (maintenance_print_msymbols, maintenance_print_objfiles)
15851         (maintenance_info_symtabs, maintenance_check_symtabs)
15852         (maintenance_expand_symtabs, maintenance_info_line_tables):
15853         Update.
15854         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15855         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15856         (map_overlay_command, unmap_overlay_command)
15857         (simple_overlay_update, expand_symtabs_matching)
15858         (map_symbol_filenames): Update.
15859         * symfile-debug.c (set_debug_symfile): Update.
15860         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15861         Update.
15862         * source.c (select_source_symtab, forget_cached_source_info):
15863         Update.
15864         * solib.c (solib_read_symbols): Update.
15865         * solib-spu.c (append_ocl_sos): Update.
15866         * psymtab.c (maintenance_print_psymbols)
15867         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15868         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15869         * printcmd.c (info_symbol_command): Update.
15870         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15871         Update.
15872         * objfiles.h (class all_objfiles): Remove.
15873         * objfiles.c (have_partial_symbols, have_full_symbols)
15874         (have_minimal_symbols, qsort_cmp, update_section_map)
15875         (shared_objfile_contains_address_p)
15876         (default_iterate_over_objfiles_in_search_order): Update.
15877         * objc-lang.c (info_selectors_command, info_classes_command)
15878         (find_methods): Update.
15879         * minsyms.c (find_solib_trampoline_target): Update.
15880         * maint.c (maintenance_info_sections)
15881         (maintenance_translate_address, count_symtabs_and_blocks):
15882         Update.
15883         * main.c (captured_main_1): Update.
15884         * linux-thread-db.c (try_thread_db_load_from_pdir)
15885         (has_libpthread): Update.
15886         * linespec.c (iterate_over_all_matching_symtabs)
15887         (search_minsyms_for_name): Update.
15888         * jit.c (jit_find_objf_with_entry_addr): Update.
15889         * hppa-tdep.c (find_unwind_entry)
15890         (hppa_lookup_stub_minimal_symbol): Update.
15891         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15892         Update.
15893         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15894         (elf_gnu_ifunc_resolve_by_got): Update.
15895         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15896         * dwarf-index-write.c (save_gdb_index_command): Update.
15897         * cp-support.c (add_symbol_overload_list_qualified): Update.
15898         * breakpoint.c (create_overlay_event_breakpoint)
15899         (create_longjmp_master_breakpoint)
15900         (create_std_terminate_master_breakpoint)
15901         (create_exception_master_breakpoint): Update.
15902         * blockframe.c (find_pc_partial_function): Update.
15903         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15904         (ada_collect_symbol_completion_matches)
15905         (ada_add_global_exceptions): Update.
15906
15907 2019-01-17  Tom Tromey  <tom@tromey.com>
15908
15909         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15910         declare VEC.
15911         (solib_target_parse_libraries): Change return type.
15912         (library_list_start_segment, library_list_start_section)
15913         (library_list_end_library, library_list_start_library); Update.
15914         (solib_target_free_library_list): Remove.
15915         (solib_target_parse_libraries): Remove cleanup.  Change return
15916         type.
15917         (solib_target_current_sos): Update.
15918
15919 2019-01-17  Tom Tromey  <tromey@bapiya>
15920
15921         * valprint.c: Replace "the the" with "the".
15922         * symtab.c: Replace "the the" with "the".
15923         * solib.c: Replace "the the" with "the".
15924         * solib-dsbt.c: Replace "the the" with "the".
15925         * linespec.c: Replace "the the" with "the".
15926         * dwarf2loc.h: Replace "the the" with "the".
15927         * amd64-windows-tdep.c: Replace "the the" with "the".
15928         * aarch64-tdep.c: Replace "the the" with "the".
15929
15930 2019-01-16  Keith Seitz  <keiths@redhat.com>
15931
15932         PR gdb/23773
15933         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15934         <builder>: Rename to ..
15935         <m_builder>: ... this and make private.
15936         (dwarf2_cu::get_builder): New method.  Change all users of
15937         `builder' to use this method.
15938         (dwarf2_start_symtab): Move to ...
15939         (dwarf2_cu::start_symtab): ... here.  Update all callers
15940         (setup_type_unit_groups): Move to ...
15941         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15942         callers.
15943         (dwarf2_cu::reset_builder): New method.
15944         (process_full_compunit, process_full_type_unit): Use
15945         dwarf2_cu::reset_builder.
15946         (follow_die_offset): Record the ancestor CU if it is different
15947         from the followed DIE's CU.
15948         (follow_die_sig_1): Likewise.
15949
15950 2019-01-15  Tom Tromey  <tom@tromey.com>
15951
15952         * remote.c (class remote_state) <buf>: Now a char_vector.
15953         <buf_size>: Remove.
15954         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15955         parameter.
15956         (remote_target::getpkt_or_notif_sane_1)
15957         (remote_target::getpkt_sane)
15958         (remote_target::getpkt_or_notif_sane): Likewise.
15959         (class remote_target) <putpkt>: New overload.
15960         (remote_target::read_frame): Change type of "buf_p".  Remove
15961         sizeof_p parameter.
15962         (packet_ok): New overload.
15963         (packet_check_result): New overload.
15964         Update all uses.
15965
15966 2019-01-14  Tom Tromey  <tom@tromey.com>
15967
15968         * remote-notif.c (handle_notification, remote_notif_ack)
15969         (remote_notif_parse): Make "buf" const.
15970         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15971         const.
15972         (remote_notif_parse, remote_notif_ack, handle_notification):
15973         Likewise.
15974         * remote.c (remote_notif_stop_parse): Make "buf" const.
15975         (remote_target::remote_parse_stop_reply): Make "buf" const.
15976         (remote_notif_stop_ack): Make "buf" const.
15977
15978 2019-01-14  Tom Tromey  <tom@tromey.com>
15979
15980         * remote.c (remote_console_output): Make parameter const.
15981
15982 2019-01-14  Tom Tromey  <tom@tromey.com>
15983
15984         * target-debug.h (target_debug_print_signals): Constify.
15985         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15986         * procfs.c (procfs_target::pass_signals): Update.
15987         * linux-nat.c (linux_nat_target::pass_signals): Update.
15988         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15989         * target-delegates.c: Rebuild.
15990         * remote.c (remote_target::program_signals): Update.
15991         (remote_target::pass_signals): Update.
15992         * target.c (target_pass_signals): Constify argument.
15993         (target_program_signals): Likewise.
15994         * target.h (struct target_ops) <pass_signals, program_signals>:
15995         Constify argument.
15996         (target_pass_signals, target_program_signals): Constify argument.
15997
15998 2019-01-14  Tom Tromey  <tom@tromey.com>
15999
16000         PR tui/28819:
16001         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16002
16003 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16004
16005         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16006         field.
16007         * rs6000-tdep.c: Include reggroups.h.
16008         (IS_V_ALIAS_PSEUDOREG): Define.
16009         (rs6000_register_name): Return names for the "vX" aliases.
16010         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16011         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16012         aliases.  Call default_register_reggroup_p for all other
16013         pseudo-registers.
16014         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16015         New functions.
16016         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16017         Handle "vX" aliases.
16018         (v_alias_pseudo_register_collect): New function.
16019         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16020         (rs6000_gdbarch_init): Initialize "vX" aliases as
16021         pseudo-registers.  Restore registration of
16022         rs6000_pseudo_register_reggroup_p with
16023         set_tdesc_pseudo_register_reggroup_p.
16024
16025 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16026
16027         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16028         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16029         set_gdbarch_num_pseudo_regs.
16030
16031 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16032
16033         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16034         Remove arg prefixname, add do_set and do_show.
16035         Add member functions set_list and show_list.
16036         * cli/cli-style.c (class cli_style_option): Update accordingly.
16037         (style_set_list): Move to file scope.
16038         (style_show_list): Likewise.
16039         (set_style): Call help_list.
16040         (show_style): Call cmd_show_list.
16041         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16042         Update to use the new macro.
16043
16044 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16045
16046         * ada-lang.c (_initialize_ada_language): Expand the help text
16047         for the "catch exception" command.
16048
16049 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16050
16051         * symtab.c (matching_obj_sections): Initialize obj,
16052         declare it closer to its usage.
16053
16054 2019-01-10  Tom Tromey  <tom@tromey.com>
16055
16056         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16057         (basic_inf_threads_range): Remove.
16058         (inf_threads_range, inf_non_exited_threads_range)
16059         (safe_inf_threads_range): Use next_adapter.
16060
16061 2019-01-10  Keith Seitz  <keiths@redhat.com>
16062
16063         PR gdb/23712
16064         PR symtab/23010
16065         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16066         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16067
16068 2019-01-10  Keith Seitz  <keiths@redhat.com>
16069
16070         PR gdb/23712
16071         PR symtab/23010
16072         * dictionary.c (pending_to_vector): Remove.
16073         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16074         Remove _1 suffix, replacing functions of the same name.  Update
16075         all callers.
16076         (dict_create_hashed, dict_create_hashed_expandable)
16077         (dict_create_linear, dict_create_linear_expandable, dict_free)
16078         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16079         Make functions static.
16080
16081 2019-01-10  Keith Seitz  <keiths@redhat.com>
16082
16083         PR gdb/23712
16084         PR symtab/23010
16085         * dictionary.h (struct dictionary): Replace declaration with
16086         multidictionary.
16087         (dict_create_hashed, dict_create_hashed_expandable)
16088         (dict_create_linear, dict_create_linear_expandable)
16089         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16090         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16091         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16092         taking multidictionary argument.
16093         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16094         * block.h (struct block) <dict>: Change to multidictionary
16095         and rename `multidict'.
16096         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16097         symmisc.c: Update all dictionary references to multidictionary.
16098
16099 2019-01-10  Keith Seitz  <keiths@redhat.com>
16100
16101         PR gdb/23712
16102         PR symtab/23010
16103         * dictionary.c: Include unordered_map.
16104         (pending_to_vector): New function.
16105         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16106         Rewrite the non-"_1" functions to take vector instead
16107         of linked list.
16108         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16109         "new" _1 versions of the same name.
16110         (multidictionary): Define.
16111         (std::hash<enum language): New definition.
16112         (collate_pending_symbols_by_language, mdict_create_hashed)
16113         (mdict_create_hashed_expandable, mdict_create_linear)
16114         (mdict_create_linear_expandable, mdict_free)
16115         (find_language_dictionary, create_new_language_dictionary)
16116         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16117         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16118         (mdict_size, mdict_empty): New functions.
16119         * dictionary.h (mdict_iterator): Define.
16120
16121 2019-01-10  Pedro Alves  <palves@redhat.com>
16122
16123         * breakpoint.c (read_uploaded_action)
16124         (create_tracepoint_from_upload): Adjust to use
16125         gdb::unique_xmalloc_ptr.
16126         * ctf.c (ctf_write_uploaded_tp):
16127         (SET_ARRAY_FIELD): Use emplace_back.
16128         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16129         * tracefile-tfile.c (tfile_write_uploaded_tp):
16130         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16131         gdb::unique_xmalloc_ptr.
16132         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16133         at_string, cond_string, cmd_strings>: Replace char pointers
16134         with gdb::unique_xmalloc_ptr.
16135
16136 2019-01-10  Pedro Alves  <palves@redhat.com>
16137
16138         * solib-target.c (library_list_start_library): Don't xstrdup name.
16139
16140 2019-01-10  Pedro Alves  <palves@redhat.com>
16141
16142         * mdebugread.c (parse_partial_symbols): Use
16143         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16144
16145 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16146
16147         * linux-fork.c (scoped_switch_fork_info)
16148         <~scoped_switch_fork_info>: Fix incorrect variable name.
16149
16150 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16151
16152         * linux-fork.c (scoped_switch_fork_info)
16153         <scoped_switch_fork_info>: Make explicit.
16154         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16155
16156 2019-01-10  Tom Tromey  <tom@tromey.com>
16157
16158         * objfiles.h (objfile::reset_psymtabs): Update.
16159         * objfiles.c (objfile::objfile): Update.
16160         * psymtab.h (psymtab_storage::obstack): Update.
16161         (psymtab_storage::m_obstack): Use gdb::optional.
16162         (class psymtab_storage): Update comment.  Remove objfile
16163         parameter.
16164         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16165
16166 2019-01-10  Tom Tromey  <tom@tromey.com>
16167
16168         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16169         <free_psymtabs>: Now private.
16170         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16171         (allocate_psymtab): Use new method.
16172
16173 2019-01-10  Tom Tromey  <tom@tromey.com>
16174
16175         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16176         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16177         * mdebugread.c (parse_partial_symbols): Use
16178         allocate_dependencies.
16179         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16180         allocate_dependencies.
16181         (process_psymtab_comp_unit_reader)
16182         (build_type_psymtab_dependencies): Likewise.
16183         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16184
16185 2019-01-10  Tom Tromey  <tom@tromey.com>
16186
16187         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16188         PSYMBOL_SET_LANGUAGE.
16189         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16190
16191 2019-01-10  Tom Tromey  <tom@tromey.com>
16192
16193         * psymtab.h (psymtab_storage::obstack): New method.
16194         <m_obstack>: Rename from obstack; now private.
16195         * psymtab.c (psymtab_storage): Update.
16196         * dwarf2read.c (create_addrmap_from_index)
16197         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16198         Update.
16199
16200 2019-01-10  Tom Tromey  <tom@tromey.com>
16201
16202         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16203         * objfiles.h (objfile::reset_psymtabs): New method.
16204
16205 2019-01-10  Tom Tromey  <tom@tromey.com>
16206
16207         * symmisc.c (print_symbol_bcache_statistics): Update.
16208         (print_objfile_statistics): Update.
16209         * symfile.c (reread_symbols): Update.
16210         * psymtab.h (class psymtab_storage): New.
16211         * psymtab.c (psymtab_storage): New constructor.
16212         (~psymtab_storage): New destructor.
16213         (require_partial_symbols): Update.
16214         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16215         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16216         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16217         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16218         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16219         (start_psymtab_common, end_psymtab_common)
16220         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16221         (allocate_psymtab): Update.
16222         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16223         Update.
16224         (dump_psymtab_addrmap, maintenance_print_psymbols)
16225         (maintenance_check_psymtabs): Update.
16226         (class objfile_psymtabs): Move to objfiles.h.
16227         * psympriv.h (discard_psymtab): Now inline.
16228         (psymtab_discarder::psymtab_discarder): Update.
16229         (psymtab_discarder::~psymtab_discarder): Update.
16230         (ALL_OBJFILE_PSYMTABS): Rewrite.
16231         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16232         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16233         Remove fields.
16234         <partial_symtabs>: New field.
16235         (class objfile_psymtabs): Move from psymtab.h.  Update.
16236         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16237         psymbol_cache.
16238         (objfile::~objfile): Don't destroy psymbol_cache.
16239         * mdebugread.c (parse_partial_symbols): Update.
16240         * dwarf2read.c (create_addrmap_from_index)
16241         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16242         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16243         (add_partial_subprogram, dwarf2_ranges_read): Update.
16244         * dwarf-index-write.c (write_address_map)
16245         (write_one_signatured_type, recursively_write_psymbols)
16246         (class debug_names, class debug_names, write_psymtabs_to_index):
16247         Update.
16248
16249 2019-01-10  Tom Tromey  <tom@tromey.com>
16250
16251         * symtab.h (SYMBOL_SET_NAMES): Update.
16252         (symbol_set_names): Update.
16253         (MSYMBOL_SET_NAMES): Update.
16254         * symtab.c (symbol_set_names): Change argument to be an
16255         objfile_per_bfd_storage.
16256         * psymtab.c (add_psymbol_to_bcache): Update.
16257         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16258
16259 2019-01-10  Tom Tromey  <tom@tromey.com>
16260
16261         * symtab.c (create_demangled_names_hash): Change argument to be an
16262         objfile_per_bfd_storage.
16263         (symbol_set_names): Update.
16264
16265 2019-01-10  Tom Tromey  <tom@tromey.com>
16266
16267         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16268         init_psymbol_list.
16269         * psymtab.c (init_psymbol_list): Do nothing if already called.
16270         * psympriv.h (init_psymbol_list): Add comment.
16271         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16272         init_psymbol_list.
16273         * dbxread.c (dbx_symfile_read): Unconditionally call
16274         init_psymbol_list.
16275
16276 2019-01-10  Tom Tromey  <tom@tromey.com>
16277
16278         * xcoffread.c (scan_xcoff_symtab): Update.
16279         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16280         "where".
16281         * mdebugread.c (parse_partial_symbols)
16282         (handle_psymbol_enumerators): Update.
16283         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16284         * dbxread.c (read_dbx_symtab): Update.
16285         * psympriv.h (psymbol_placement): New enum.
16286         (add_psymbol_to_list): Update.
16287
16288 2019-01-10  Tom Tromey  <tom@tromey.com>
16289
16290         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16291         static_psymbols parameters.
16292         (scan_xcoff_symtab): Update.
16293         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16294         static_psymbols parameters.
16295         * psympriv.h (start_psymtab_common): Update.
16296         * mdebugread.c (parse_partial_symbols): Update.
16297         * dwarf2read.c (create_partial_symtab): Update.
16298         * dbxread.c (read_dbx_symtab): Update.
16299         (start_psymtab): Remove global_psymbols and static_psymbols
16300         parameters.
16301
16302 2019-01-10  Tom Tromey  <tom@tromey.com>
16303
16304         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16305         * psymtab.c (allocate_psymtab): Add comment.
16306         * psympriv.h (allocate_psymtab): Add comment.
16307         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16308         initializations.
16309         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16310
16311 2019-01-10  Tom Tromey  <tom@tromey.com>
16312
16313         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16314         Don't declare.
16315         * mipsread.c: Include mdebugread.h.
16316         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16317         Declare.
16318         * elfread.c: Include mdebugread.h.
16319
16320 2019-01-09  Tom Tromey  <tom@tromey.com>
16321
16322         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16323         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16324         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16325         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16326         (psym_lookup_symbol, psym_find_last_source_symtab)
16327         (psym_forget_cached_source_info, psym_print_stats)
16328         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16329         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16330         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16331         (psym_find_compunit_symtab_by_address)
16332         (maintenance_print_psymbols, maintenance_info_psymtabs)
16333         (maintenance_check_psymtabs): Use ranged for.
16334         * psymtab.h (class objfile_psymtabs): New.
16335         (require_partial_symbols): Return objfile_psymtabs.
16336         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16337
16338 2019-01-09  Tom Tromey  <tom@tromey.com>
16339
16340         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16341         (find_pc_mapped_section, list_overlays_command)
16342         (map_overlay_command, unmap_overlay_command)
16343         (simple_overlay_update): Use all_objfiles.
16344         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16345         * printcmd.c (info_symbol_command): Use all_objfiles.
16346         * objfiles.h (ALL_OBJSECTIONS): Remove.
16347         * maint.c (maintenance_translate_address): Use all_objfiles.
16348         * gcore.c (gcore_create_callback): Use all_objfiles.
16349         (objfile_find_memory_regions): Likewise.
16350
16351 2019-01-09  Tom Tromey  <tom@tromey.com>
16352
16353         * symtab.c (find_line_symtab, info_sources_command)
16354         (make_source_files_completion_list): Use objfile_compunits.
16355         * source.c (select_source_symtab): Use objfile_compunits.
16356         * objfiles.h (struct objfile): Update comment.
16357         (ALL_OBJFILES): Remove.
16358         (ALL_FILETABS): Remove.
16359         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16360         objfile_compunits.
16361
16362 2019-01-09  Tom Tromey  <tom@tromey.com>
16363
16364         * symmisc.c (print_objfile_statistics, dump_objfile)
16365         (maintenance_print_symbols): Use compunit_filetabs.
16366         * source.c (forget_cached_source_info_for_objfile): Use
16367         compunit_filetabs.
16368         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16369         (ALL_FILETABS): Use compunit_filetabs.
16370         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16371         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16372
16373 2019-01-09  Tom Tromey  <tom@tromey.com>
16374
16375         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16376         (compunit_filetabs): New.
16377         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16378         compunit_filetabs.
16379         (info_sources_command, make_source_files_completion_list): Remove
16380         declaration.
16381         * symmisc.c (print_objfile_statistics, dump_objfile)
16382         (maintenance_print_symbols): Remove declaration.
16383         (maintenance_info_symtabs): Use compunit_filetabs.
16384         (maintenance_info_line_tables): Likewise.
16385         * source.c (select_source_symtab): Change local variable name.
16386         (forget_cached_source_info_for_objfile): Remove declaration.
16387         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16388         * objfiles.c (objfile_relocate1): Remove declaration.
16389         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16390         declaration.
16391         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16392         * coffread.c (coff_symtab_read): Remove declaration.
16393         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16394         compunit_filetabs.
16395
16396 2019-01-09  Tom Tromey  <tom@tromey.com>
16397
16398         * symtab.c (lookup_objfile_from_block)
16399         (find_pc_sect_compunit_symtab, search_symbols)
16400         (default_collect_symbol_completion_matches_break_on): Use
16401         objfile_compunits.
16402         * objfiles.h (ALL_COMPUNITS): Remove.
16403         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16404         * cp-support.c (add_symbol_overload_list_qualified): Use
16405         objfile_compunits.
16406         * ada-lang.c (ada_collect_symbol_completion_matches)
16407         (ada_add_global_exceptions): Use objfile_compunits.
16408
16409 2019-01-09  Tom Tromey  <tom@tromey.com>
16410
16411         * source.c (select_source_symtab)
16412         (forget_cached_source_info_for_objfile): Remove declaration.
16413         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16414         declaration.
16415         * maint.c (count_symtabs_and_blocks): Remove declaration.
16416         * cp-support.c (add_symbol_overload_list_qualified): Remove
16417         declaration.
16418         * coffread.c (coff_symtab_read): Remove declaration.
16419         * symtab.c (lookup_symbol_in_objfile_symtabs)
16420         (basic_lookup_transparent_type_1): Use objfile_compunits.
16421         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16422         (info_sources_command, search_symbols)
16423         (default_collect_symbol_completion_matches_break_on)
16424         (make_source_files_completion_list): Remove declaration.
16425         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16426         (ada_collect_symbol_completion_matches)
16427         (ada_add_global_exceptions): Remove declaration.
16428         * linespec.c (iterate_over_all_matching_symtabs): Use
16429         objfile_compunits.
16430         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16431         (class objfile_compunits): New.
16432         (ALL_COMPUNITS): Use objfile_compunits.
16433         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16434         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16435         objfile_compunits.
16436         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16437
16438 2019-01-09  Tom Tromey  <tom@tromey.com>
16439
16440         * symtab.c (search_symbols)
16441         (default_collect_symbol_completion_matches_break_on): Use
16442         objfile_msymbols.
16443         * ada-lang.c (ada_lookup_simple_minsym)
16444         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16445         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16446         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16447         objfile_msymbols.
16448         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16449         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16450         * objc-lang.c (find_methods): Use objfile_msymbols.
16451         (info_selectors_command, info_classes_command): Likewise.
16452         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16453         * objfiles.h (class objfile_msymbols): New.
16454         (ALL_OBJFILE_MSYMBOLS): Remove.
16455         (ALL_MSYMBOLS): Remove.
16456
16457 2019-01-09  Tom Tromey  <tom@tromey.com>
16458
16459         * common/next-iterator.h (next_adapter): Add Iterator template
16460         parameter.
16461         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16462         (class all_objfiles_safe): New.
16463         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16464         * objfiles.c (put_objfile_before): Update comment.
16465         (add_separate_debug_objfile): Likewise.
16466         (free_all_objfiles): Use all_objfiles_safe.
16467         (objfile_purge_solibs): Likewise.
16468
16469 2019-01-09  Tom Tromey  <tom@tromey.com>
16470
16471         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16472         (expand_symtab_containing_pc, lookup_static_symbol)
16473         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16474         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16475         all_objfiles.
16476         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16477         * breakpoint.c (create_overlay_event_breakpoint)
16478         (create_longjmp_master_breakpoint)
16479         (create_std_terminate_master_breakpoint)
16480         (create_exception_master_breakpoint): Use all_objfiles.
16481         * linux-thread-db.c (try_thread_db_load_from_pdir)
16482         (has_libpthread): Use all_objfiles.
16483         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16484         * linespec.c (iterate_over_all_matching_symtabs)
16485         (search_minsyms_for_name): Use all_objfiles.
16486         * maint.c (maintenance_info_sections): Use all_objfiles.
16487         * main.c (captured_main_1): Use all_objfiles.
16488         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16489         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16490         * guile/scm-pretty-print.c
16491         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16492         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16493         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16494         (maintenance_print_msymbols): Use all_objfiles.
16495         * source.c (select_source_symtab): Use all_objfiles.
16496         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16497         * symfile.c (remove_symbol_file_command)
16498         (expand_symtabs_matching, map_symbol_filenames): Use
16499         all_objfiles.
16500         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16501         all_objfiles.
16502         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16503         * objc-lang.c (find_methods): Use all_objfiles.
16504         * objfiles.c (have_partial_symbols, have_full_symbols)
16505         (have_minimal_symbols, qsort_cmp)
16506         (default_iterate_over_objfiles_in_search_order): Use
16507         all_objfiles.
16508         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16509         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16510         (maintenance_check_psymtabs): Use all_objfiles.
16511         (ALL_PSYMTABS): Remove.
16512         * compile/compile-object-run.c (do_module_cleanup): Use
16513         all_objfiles.
16514         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16515         * cp-support.c (add_symbol_overload_list_qualified): Use
16516         all_objfiles.
16517         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16518         Use all_objfiles.
16519         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16520         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16521         all_objfiles.
16522         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16523         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16524         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16525         Uses all_objfiles.
16526         * solib.c (solib_read_symbols): Use all_objfiles
16527
16528 2019-01-09  Tom Tromey  <tom@tromey.com>
16529
16530         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16531         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16532         all_objfiles.
16533         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16534         * symmisc.c (print_symbol_bcache_statistics)
16535         (print_objfile_statistics, maintenance_print_objfiles)
16536         (maintenance_info_symtabs, maintenance_check_symtabs)
16537         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16538         all_objfiles.
16539         * source.c (forget_cached_source_info): Use all_objfiles.
16540         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16541         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16542         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16543         * objfiles.c (update_section_map): Use all_objfiles.
16544         (shared_objfile_contains_address_p): Likewise.
16545         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16546         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16547
16548 2019-01-09  Tom Tromey  <tom@tromey.com>
16549
16550         * common/next-iterator.h: New file.
16551         * objfiles.h (class all_objfiles): New.
16552         (struct objfile_iterator): New.
16553
16554 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16555
16556         * NEWS: Move the description of the changed "frame", "select-frame",
16557          and "info frame" commands to the Changed commands section.
16558
16559 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16560
16561         * gdbtypes.c (check_stub_method_group): Remove handling of old
16562         mangling schemes.
16563         * linespec.c (find_methods): Likewise.
16564         * stabsread.c (read_member_functions): Likewise.
16565         * valops.c (search_struct_method): Likewise.
16566         (value_struct_elt_for_reference): Likewise.
16567         * NEWS: Mention this change.
16568
16569 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16570
16571         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16572         print_source_lines.
16573         * source.c (print_source_lines_base): Update line number check.
16574         (print_source_lines): New function.
16575         (source_lines_range::source_lines_range): New function.
16576         * source.h (class source_lines_range): New class.
16577         (print_source_lines): New declaration.
16578
16579 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16580
16581         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16582
16583 2019-01-08  Tom Tromey  <tom@tromey.com>
16584             Simon Marchi  <simon.marchi@ericsson.com>
16585
16586         PR gdb/24060
16587         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16588         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16589         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16590         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16591         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16592         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16593
16594 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16595
16596         * source.c (select_source_symtab): Move header comment to
16597         declaration in source.h.
16598         (forget_cached_source_info_for_objfile): Likewise.
16599         (forget_cached_source_info): Likewise.
16600         (identify_source_line): Likewise.
16601         * source.h (identify_source_line): Move declaration from symtab.h
16602         and add comment from source.c
16603         (print_source_lines): Likewise.
16604         (forget_cached_source_info_for_objfile): Likewise.
16605         (forget_cached_source_info): Likewise.
16606         (select_source_symtab): Likewise.
16607         (enum print_source_lines_flag): Move definition from symtab.h.
16608         * symtab.h (identify_source_line): Move declaration to source.h.
16609         (print_source_lines): Likewise.
16610         (forget_cached_source_info_for_objfile): Likewise.
16611         (forget_cached_source_info): Likewise.
16612         (select_source_symtab): Likewise.
16613         (enum print_source_lines_flag): Move definition to source.h.
16614         * tui/tui-hooks.c: Add 'source.h' include.
16615
16616 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16617
16618         * source.c (print_source_lines_base): Handle requests to print
16619         reverse line number sequences, and guard against empty lines
16620         string.
16621
16622 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16623
16624         * source.c (print_source_lines_base): Fix skip of '\r' if next
16625         character is '\n'.
16626
16627 2019-01-06  Tom Tromey  <tom@tromey.com>
16628
16629         * c-exp.y (struct c_parse_state) <macro_original_text,
16630         expansion_obstack>: New member.
16631         (macro_original_text, expansion_obstack): Remove globals.
16632         (scan_macro_expansion, scanning_macro_expansion)
16633         (finished_macro_expansion): Update.
16634         (scan_macro_cleanup): Remove.
16635         (yylex, c_parse): Update.
16636
16637 2019-01-06  Tom Tromey  <tom@tromey.com>
16638
16639         * c-exp.y (struct c_parse_state) <strings>: New member.
16640         (operator_stoken): Update.
16641
16642 2019-01-06  Tom Tromey  <tom@tromey.com>
16643
16644         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16645         (union type_stack_elt) <typelist_val>: Now a pointer to
16646         std::vector.
16647         (type_stack_cleanup): Don't declare.
16648         (push_typelist): Update.
16649         * parse.c (pop_typelist): Return a std::vector.
16650         (push_typelist): Take a std::vector.
16651         (follow_types): Update.  Do not free args.
16652         (type_stack_cleanup): Remove.
16653         * c-exp.y (struct c_parse_state): New.
16654         (cpstate): New global.
16655         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16656         (nonempty_typelist): Update.
16657         (func_mod): Create a new vector.
16658         (c_parse): Create a c_parse_state.
16659         (check_parameter_typelist): Do not delete params.
16660         (function_method): Update.  Do not delete type_list.
16661
16662 2019-01-06  Tom Tromey  <tom@tromey.com>
16663
16664         PR gdb/28155:
16665         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16666         check_typedef.
16667         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16668         (print_return_value): Likewise.
16669
16670 2019-01-05  Tom Tromey  <tom@tromey.com>
16671
16672         * contrib/cleanup_check.py: Remove.
16673         * contrib/gcc-with-excheck: Remove.
16674         * contrib/exsummary.py: Remove.
16675         * contrib/excheck.py: Remove.
16676
16677 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16678
16679         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16680         NULL. Initialize tpprev to NULL instead of assigning it
16681         to NULL on the next statement.
16682         * windows-nat.c (windows_delete_thread): Remove check for
16683         main_thread_id before printing thread exit notifications.
16684         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16685         Remove thread ID check against main_thread_id.
16686         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16687         windows_delete_thread.
16688         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16689
16690 2019-01-04  Tom Tromey  <tom@tromey.com>
16691
16692         * compile/compile.c (_initialize_compile): Use upper case for
16693         metasyntactic variables.
16694         * symmisc.c (_initialize_symmisc): Use upper case for
16695         metasyntactic variables.
16696         * psymtab.c (_initialize_psymtab): Use upper case for
16697         metasyntactic variables.
16698         * demangle.c (demangle_command): Use upper case for metasyntactic
16699         variables.
16700         (_initialize_demangler): Likewise.
16701         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16702         variables.
16703
16704 2019-01-03  Tom Tromey  <tom@tromey.com>
16705
16706         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16707
16708 2019-01-03  Tom Tromey  <tom@tromey.com>
16709
16710         * python/py-symtab.c (salpy_str): Update.
16711         (struct salpy_sal_object) <symtab>: Now a PyObject.
16712         (salpy_dealloc): Update.
16713         (del_objfile_sal): Use gdbpy_ref.
16714
16715 2019-01-03  Tom Tromey  <tom@tromey.com>
16716
16717         * python/py-type.c (convert_field): Use new_reference.  Return
16718         gdbpy_ref.
16719         (make_fielditem): Return gdbpy_ref.
16720         (typy_fields): Update.
16721         (typy_getitem): Update.
16722         (field_name): Return gdbpy_ref.  Use new_reference.
16723         (typy_iterator_iternext): Update.
16724
16725 2019-01-03  Tom Tromey  <tom@tromey.com>
16726
16727         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16728
16729 2019-01-03  Tom Tromey  <tom@tromey.com>
16730
16731         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16732         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16733         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16734         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16735         (pspy_set_type_printers): Likewise.
16736         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16737         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16738         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16739         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16740         (objfpy_set_type_printers): Likewise.
16741
16742 2019-01-03  Tom Tromey  <tom@tromey.com>
16743
16744         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16745         (gdbpy_print_stack): Use gdbpy_err_fetch.
16746         * python/python-internal.h (class gdbpy_err_fetch): New class.
16747         (class gdbpy_enter) <m_error_type, m_error_value,
16748         m_error_traceback>: Remove.
16749         <m_error>: New member.
16750         (gdbpy_exception_to_string): Don't declare.
16751         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16752         * python/py-value.c (convert_value_from_python): Use
16753         gdbpy_err_fetch.
16754         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16755         gdbpy_exception_to_string.
16756         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16757         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16758         gdbpy_err_fetch.
16759
16760 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16761
16762         * linux-nat.c (delete_lwp_cleanup): Delete.
16763         (struct lwp_deleter): New struct.
16764         (lwp_info_up): New typedef.
16765         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16766         lwp_info_up.
16767
16768 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16769
16770         * linux-fork.c (class scoped_switch_fork_info): New class.
16771         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16772
16773 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16774
16775         * valops.c (find_overload_match): Remove use of null_cleanup, and
16776         calls to do_cleanups.
16777
16778 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16779
16780         * compile/compile-cplus-types.c
16781         (compile_cplus_instance::decl_name): Handle changes to
16782         cp_func_name.
16783         * cp-support.c (cp_func_name): Update header comment, update
16784         return type.
16785         * cp-support.h (cp_func_name): Update return type in declaration.
16786         * valops.c (find_overload_match): Move temp_func local to top
16787         level of function and change its type.  Use temp_func to hold and
16788         delete temporary string obtained from cp_func_name.
16789
16790 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16791
16792         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16793         gdb::char_vector, remove cleanup, and update uses of `msg`.
16794
16795 2019-01-03  Jim Wilson  <jimw@sifive.com>
16796
16797         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16798
16799 2019-01-02  Tom Tromey  <tom@tromey.com>
16800
16801         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16802         (tdesc_parse_xml): Remove cleanups.
16803         * target-descriptions.h (make_cleanup_free_target_description):
16804         Don't declare.
16805         (target_desc_deleter): New struct.
16806         (target_desc_up): New typedef.
16807         * target-descriptions.c (target_desc_deleter::operator()): Rename
16808         from free_target_description.
16809         (make_cleanup_free_target_description): Remove.
16810
16811 2019-01-02  Tom Tromey  <tom@tromey.com>
16812
16813         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16814         constructor, destructor.
16815         (linespec_parser): Remove typedef.
16816         (~linespec_parser): Rename from linespec_parser_delete.
16817         (linespec_lex_to_end, linespec_complete_label)
16818         (linespec_complete): Update.
16819         (decode_line_full): Remove cleanups.
16820         (decode_line_1): Update.
16821
16822 2019-01-02  Tom Tromey  <tom@tromey.com>
16823
16824         * python/python-internal.h (inferior_to_inferior_object): Change
16825         return type.
16826         * python/py-exitedevent.c (create_exited_event_object): Update.
16827         * python/py-inferior.c (inferior_to_inferior_object): Return
16828         gdbpy_ref.
16829         (python_new_inferior, python_inferior_deleted)
16830         (thread_to_thread_object, delete_thread_object)
16831         (build_inferior_list, gdbpy_selected_inferior): Update.
16832         * python/py-infthread.c (create_thread_object): Update.  Also fail
16833         if inferior_to_inferior_object fails.
16834
16835 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16836
16837         * inferior.h (class inferior) <displaced_step_state>: New field.
16838         * infrun.h (struct displaced_step_state): Move here from
16839         infrun.c.  Initialize fields, add constructor.
16840         <inf>: Remove field.
16841         <reset>: New method.
16842         * infrun.c (struct displaced_step_inferior_state): Move to
16843         infrun.h.
16844         (displaced_step_inferior_states): Remove.
16845         (get_displaced_stepping_state): Adust.
16846         (displaced_step_in_progress_any_inferior): Adjust.
16847         (displaced_step_in_progress_thread): Adjust.
16848         (displaced_step_in_progress): Adjust.
16849         (add_displaced_stepping_state): Remove.
16850         (get_displaced_step_closure_by_addr): Adjust.
16851         (remove_displaced_stepping_state): Remove.
16852         (infrun_inferior_exit): Call displaced_step_state.reset.
16853         (use_displaced_stepping): Don't check for NULL.
16854         (displaced_step_prepare_throw): Call
16855         get_displaced_stepping_state.
16856         (displaced_step_fixup): Don't check for NULL.
16857         (prepare_for_detach): Don't check for NULL.
16858
16859 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16860
16861         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16862          in case of call that did not complete.
16863
16864 2019-01-02  Andrey Utkin  <autkin@undo.io>
16865
16866         * symfile.c (find_separate_debug_file): Fix search of debug files for
16867         remote debuggee.
16868
16869 2019-01-02  Tom Tromey  <tom@tromey.com>
16870
16871         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16872         indentation.
16873         * python/py-frame.c (frapy_older): Remove cast.
16874         (frapy_newer): Likewise.
16875         * python/py-breakpoint.c (local_setattro): Remove cast.
16876         * python/py-arch.c (archpy_name): Remove local variable.
16877         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16878
16879 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16880
16881         * unittests/basic_string_view/element_access/char/empty.cc:
16882         Fix year range in copyright header.
16883
16884 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16885
16886         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16887         Delete.
16888         <operator==>: Update with for removed field.
16889         <hash>: Likewise.
16890         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16891         <isa_features>: ...this.
16892         <abi_features>: New field.
16893         (riscv_isa_flen): Update comment.
16894         (riscv_abi_xlen): New declaration.
16895         (riscv_abi_flen): New declaration.
16896         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16897         isa_features.
16898         (riscv_abi_xlen): New function.
16899         (riscv_isa_flen): Update to get answer from isa_features.
16900         (riscv_abi_flen): New function.
16901         (riscv_has_fp_abi): Update to get answer from abi_features.
16902         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16903         xlen and flen.
16904         (riscv_call_info) <xlen, flen>: Update comment.
16905         (riscv_call_arg_struct): Remove invalid assertions
16906         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16907         is removed.
16908         (riscv_gdbarch_init): Gather isa features and abi features
16909         separately, ensure both match on the gdbarch when reusing an old
16910         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16911         a target with 64-bit float hardware.
16912
16913 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16914
16915         * source.c (search_command_helper): Stop reverse search
16916         when line 1 has been searched.
16917
16918 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16919
16920         * record-full.c (record_full_base_target::close): Rewrite
16921         record_full_core_buf_list free logic.
16922
16923 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16924
16925         * break-catch-syscall.c (print_one_catch_syscall): xfree
16926         the last text.
16927
16928 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16929
16930         * top.c (print_gdb_version): Update Copyright year in version
16931         message.
16932
16933 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16934
16935         Update copyright year range in all GDB files.
16936
16937 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16938
16939         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16940
16941 For older changes see ChangeLog-2018.
16942 \f
16943 Local Variables:
16944 mode: change-log
16945 left-margin: 8
16946 fill-column: 74
16947 version-control: never
16948 coding: utf-8
16949 End:
16950