gdb/ChangeLog

   1 2019-12-12  Tom Tromey  <tom@tromey.com>
   2
   3         * progspace.c (program_space::add_objfile)
   4         (program_space::remove_objfile): Update.
   5         (program_space::multi_objfile_p): Remove.
   6         * objfiles.h (struct objfile) <next>: Remove.
   7         * objfiles.c (objfile::objfile): Update.
   8         (put_objfile_before): Update.
   9         (unlink_objfile): Update.
  10         * progspace.h (object_files): Remove.
  11         (struct program_space) <objfiles_head>: Remove.
  12         <objfiles_list>: New member.
  13         <objfiles_range, objfiles_safe_range>: Change type.
  14         (objfiles): Change return type.
  15         (objfiles_safe): Update.
  16         (multi_objfile_p): Rewrite and inline.
  17         (object_files): Remove macro.
  18
  19 2019-12-12  Tom Tromey  <tom@tromey.com>
  20
  21         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
  22         second constructor.
  23         (basic_safe_range): New class.
  24
  25 2019-12-12  Tom Tromey  <tom@tromey.com>
  26
  27         * progspace.c (program_space::multi_objfile_p): New method.
  28         * printcmd.c (info_symbol_command): Update.
  29         * maint.c (maintenance_translate_address): Update.
  30         * objfiles.h (MULTI_OBJFILE_P): Remove.
  31         * progspace.h (struct program_space) <multi_objfile_p>: New
  32         method.
  33
  34 2019-12-12  Tom Tromey  <tom@tromey.com>
  35
  36         * progspace.h (struct program_space) <remove_objfile>: Declare.
  37         * progspace.c (program_space::remove_objfile): New method.
  38         * objfiles.c (unlink_objfile): Remove.
  39         (objfile::unlink): Call remove_objfile.
  40         (objfile): Don't call unlink_objfile.
  41
  42 2019-12-12  Tom Tromey  <tom@tromey.com>
  43
  44         * progspace.h (struct program_space) <add_objfile>: Declare
  45         method.
  46         * progspace.c (program_space::add_objfile): New method.
  47         * objfiles.c (~objfile): Don't unlink objfile.
  48         (put_objfile_before): Remove.
  49         (add_separate_debug_objfile): Don't call put_objfile_before.
  50         (objfile::make): Call add_objfile.  Set new_objfiles_available on
  51         the per-program-space data.
  52
  53 2019-12-12  Tom Tromey  <tom@tromey.com>
  54
  55         * symfile.c (syms_from_objfile_1): Use objfile_up.
  56         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
  57         method.
  58         (reread_symbols): Use objfile_up.
  59         * solib.c (update_solib_list, reload_shared_libraries_1): Call
  60         unlink method.
  61         * objfiles.h (struct objfile) <~objfile>: Now private.
  62         <unlink>: New method.
  63         (struct objfile_deleter): New.
  64         (objfile_up): New typedef.
  65         * objfiles.c (objfile::unlink): New method.
  66         (free_objfile_separate_debug, free_all_objfiles)
  67         (objfile_purge_solibs): Use it.
  68         * jit.c (jit_unregister_code): Remove.
  69         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
  70         objfile.
  71         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
  72         objfile.
  73         * compile/compile-object-load.c (compile_object_load): Use
  74         objfile_up.
  75
  76 2019-12-12  Tom Tromey  <tom@tromey.com>
  77
  78         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
  79         objfile::make.
  80         * objfiles.h (struct objjfile) <make>: No longer inline.
  81         (add_separate_debug_objfile): Don't declare.
  82         * objfiles.c (add_separate_debug_objfile): Now static.
  83         (objfile::make): Move from objfiles.h.  Call
  84         add_separate_debug_objfile.  Add "parent" parameter.
  85
  86 2019-12-12  Tom Tromey  <tom@tromey.com>
  87
  88         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
  89         * objfiles.h (struct objfile): Make constructor private.
  90         <make>: New static method.
  91         * jit.c (jit_object_close_impl): Update.
  92
  93 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
  94
  95         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
  96         gdb::byte_vector.
  97
  98 2019-12-12  Tom Tromey  <tromey@adacore.com>
  99
 100         * xml-support.c (xml_fetch_content_from_file): Don't call
 101         malloc_failure.
 102         * utils.h (class gdb_argv): Remove malloc_failure comment.
 103         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 104
 105 2019-12-12  Tom Tromey  <tromey@adacore.com>
 106
 107         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 108         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 109         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 110         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 111         * riscv-ravenscar-thread.c: New file.
 112         * riscv-ravenscar-thread.h: New file.
 113         * riscv-tdep.c (riscv_gdbarch_init): Call
 114         register_riscv_ravenscar_ops.
 115
 116 2019-12-12  Tom Tromey  <tromey@adacore.com>
 117
 118         * gdbsupport/thread-pool.c (set_thread_name): Use
 119         ATTRIBUTE_UNUSED.
 120
 121 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 122
 123         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 124         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 125         macros.
 126
 127 2019-12-11  Tom Tromey  <tom@tromey.com>
 128
 129         * tui/tui-win.c (tui_set_win_height_command): Call
 130         tui_adjust_window_height.
 131         (tui_adjust_win_heights, new_height_ok): Remove.
 132         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 133         * tui/tui-layout.c (tui_adjust_window_height): New function.
 134
 135 2019-12-11  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-win.c (tui_resize_all): Remove code, call
 138         tui_apply_current_layout.
 139
 140 2019-12-11  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 143         * tui/tui-layout.c (standard_layouts, applied_layout): New
 144         globals.
 145         (tui_apply_current_layout): New function.
 146         (show_layout): Set applied_layout.  Call
 147         tui_apply_current_layout.
 148         (show_source_command, show_disasm_command)
 149         (show_source_disasm_command, show_data)
 150         (show_source_or_disasm_and_command): Remove.
 151         (initialize_layouts): New function.
 152         (_initialize_tui_layout): Call initialize_layouts.
 153
 154 2019-12-11  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-layout.h (class tui_layout_base)
 157         (class tui_layout_window, class tui_layout_split): New.
 158         * tui/tui-layout.c (tui_get_window_by_name)
 159         (tui_layout_window::clone, tui_layout_window::apply)
 160         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 161         (tui_layout_split::add_window, tui_layout_split::clone)
 162         (tui_layout_split::get_sizes)
 163         (tui_layout_split::set_weights_from_heights)
 164         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 165         functions.
 166         (tui_layout_split::add_split, tui_layout_split::add_split)
 167         (tui_layout_split::set_weights_from_heights)
 168         (tui_layout_split::set_weights_from_heights): New functions.
 169
 170 2019-12-11  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 173         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 174         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 175         * tui/tui-data.h (struct tui_point): Remove.
 176         (struct tui_gen_win_info) <origin>: Remove.
 177         <x, y>: New fields.
 178         * tui/tui-command.c (tui_cmd_window::resize): Update.
 179
 180 2019-12-11  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 183         Implement.
 184         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 185         Implement.
 186         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 187         method.
 188         (struct tui_win_info) <min_height>: Implement.
 189
 190 2019-12-11  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 193         (struct tui_win_info) <can_box>: Update.
 194
 195 2019-12-11  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 198         method.
 199         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 200         method.
 201         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 202         method.
 203         (struct tui_win_info) <max_height>: Now override.
 204
 205 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 206
 207         * NEWS: Create a new section for the next release branch.
 208         Rename the section of the current branch, now that it has
 209         been cut.
 210
 211 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 212
 213         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 214         * version.in: Bump version to 10.0.50.DATE-git.
 215
 216 2019-12-11  Tom Tromey  <tromey@adacore.com>
 217
 218         PR build/25268:
 219         * gdbsupport/thread-pool.c (set_thread_name): New function.
 220         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 221         (thread_pool::thread_function): Call set_thread_name.
 222
 223 2019-12-11  Tom Tromey  <tromey@adacore.com>
 224
 225         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 226         bfd_get_signed_8.
 227
 228 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 229
 230         * NEWS: Document -raw-values option and the related setting commands.
 231         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 232         only set it on when /r is given.
 233         * valprint.c (value_print_option_defs): New element raw-values.
 234         * Makefile.in: Add the new file.
 235
 236 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 237
 238         * gdbsupport/safe-strerror.c: Supress the unused function warning
 239         for select_strerror_r.
 240
 241 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 242
 243         * config.in: Regenerate.
 244         * configure: Regenerate.
 245         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 246         safe_strerror instead of strerror.
 247         * gdbsupport/common.m4: Don't check for strerror.
 248         * gdbsupport/safe-strerror.c: Support both the glibc version
 249         of strerror_r and the XSI version.
 250
 251 2019-12-10  Tom Tromey  <tromey@adacore.com>
 252
 253         * ada-typeprint.c (print_choices): Use a single "?".
 254         (print_variant_part): Print "?" if the discriminant name
 255         is not known.
 256
 257 2019-12-10  George Barrett  <bob@bob131.so>
 258
 259         Fix scripted probe breakpoints.
 260         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 261         declaration forward.
 262         (breakpoint_ops_for_event_location_type)
 263         (breakpoint_ops_for_event_location): Add function definitions.
 264         (break_command_1, trace_command): Use
 265         breakpoint_ops_for_event_location.
 266         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 267         declarations.
 268         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 269         breakpoint_ops_for_event_location.
 270         * python/py-breakpoint.c (bppy_init): Use
 271         breakpoint_ops_for_event_location.
 272
 273 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 274
 275         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 276         when ranking an lvalue argument for an rvalue parameter.
 277
 278 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 279
 280         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 281         template argument for scoped_restore_tmpl from bool to int.
 282
 283 2019-12-07  Keith Seitz  <keiths@redhat.com>
 284
 285         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 286         (build_id_to_debug_bfd): Make static, rewriting to use
 287         build_id_to_bfd_suffix.
 288         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 289         adding `suffix' parameter. Append SUFFIX to file names
 290         when searching for matching files.
 291         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 292         (build_id_to_exec_bfd): Likewise.
 293         * build-id.h (build_id_to_debug_bfd): Clarify that function
 294         searches for BFD of debug info file.
 295         (build_id_to_exec_bfd): Declare.
 296         * corelow.c: Include build-id.h.
 297         (locate_exec_from_corefile_build_id): New function.
 298         (core_target_open): If no executable BFD is found,
 299         search for a core file BFD using build-id.
 300
 301 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 302
 303         * bcache.c: Put in namespace gdb.
 304         * bcache.h: Likewise.
 305         * gdbtypes.c (check_types_worklist): Update.
 306         (types_deeply_equal): Update.
 307         * macrotab.c (struct macro_table) <bcache>: Update.
 308         (new_macro_table): Update.
 309         * macrotab.h (struct bcache): Put this forward declaration
 310         inside namespace gdb.
 311         (new_macro_table): Update.
 312         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 313         Update.
 314         <macro_cache>: Update.
 315         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 316
 317 2019-12-06  Tom de Vries  <tdevries@suse.de>
 318
 319         PR symtab/24971
 320         * block.c (best_symbol, better_symbol): New function.
 321         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 322         decl.
 323
 324 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 325
 326         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 327         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 328         for ranking see-through reference cases.
 329
 330 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 331         * stack.c (faas_command): Check a command is provided.
 332         * thread.c (taas_command, tfaas_command): Likewise.
 333
 334 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 335         * inferior.c (prune_inferiors):  Only call delete_inferior,
 336         Do not modify the inferior list.
 337
 338 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 339
 340         * c-exp.y: Update calls to lookup_typename,
 341         lookup_signed_typename and lookup_unsigned_typename.
 342         * c-lang.c (evaluate_subexp_c): Likewise.
 343         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 344         Likewise.
 345         * eval.c (binop_promote): Likewise.
 346         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 347         (lookup_unsigned_typename): Likewise.
 348         (lookup_signed_typename): Likewise.
 349         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 350         (lookup_signed_typename): Likewise.
 351         (lookup_typename): Likewise.
 352         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 353         lookup_typename, lookup_signed_typename,
 354         lookup_unsigned_typename.
 355         * m2-exp.y: Likewise.
 356         * printcmd.c (printf_wide_c_string): Likewise.
 357         (ui_printf): Likewise.
 358         * python/py-type.c (typy_lookup_typename): Likewise.
 359         * python/py-xmethods.c (python_xmethod_worker::invoke):
 360         Likewise.
 361         * rust-exp.y: Likewise.
 362
 363 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 364
 365         * configure.nat (obsd64): Add missing files x86-nat.o and
 366         nat/x86-dregs.o.
 367
 368 2019-12-04  Tom Tromey  <tom@tromey.com>
 369
 370         * valprint.c (val_print_string): Use metadata_style.
 371         * go-valprint.c (print_go_string): Use metadata style.
 372         * p-valprint.c (pascal_object_print_static_field): Use metadata
 373         style.
 374         * cp-valprint.c (cp_print_static_field): Use metadata style.
 375
 376 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 377             Chris January  <chris.january@arm.com>
 378
 379         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 380         tokens.
 381         (typebase): New patterns for complex, single/double precision, and
 382         single/double complex.
 383         (f77_keywords): Change token for complex keyword, and add single,
 384         double, and precision keywords.
 385
 386 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 387
 388         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 389         "info io_registers".
 390
 391 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 392
 393         * regcache.c (cooked_read_test): Initialize thread list of
 394         mock_inferior.
 395
 396 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 397
 398         * aarch64-linux-tdep.c: Remove includes.
 399
 400 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 401
 402         * aarch64-tdep.c: Remove includes.
 403
 404 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 405
 406         * filtered-iterator.h (filtered_iterator) <operator==,
 407         operator!=>: Compare wrapped iterators, not wrapped pointers.
 408         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 409         unittests/filtered_iterator-selftests.c.
 410         * unittests/filtered_iterator-selftests.c: New file.
 411
 412 2019-12-04  Tom Tromey  <tromey@adacore.com>
 413
 414         * gdbtypes.c (create_range_type): Inherit endianity
 415         from base type.
 416
 417 2019-12-04  Tom Tromey  <tromey@adacore.com>
 418
 419         * ada-lang.c (decode_constrained_packed_array)
 420         (ada_value_assign, value_assign_to_component): Update.
 421         * dwarf2loc.c (rw_pieced_value, access_memory)
 422         (dwarf2_compile_expr_to_ax): Update.
 423         * dwarf2read.c (dwarf2_add_field): Update.
 424         * eval.c (evaluate_subexp_standard): Update.
 425         * gdbarch.c, gdbarch.h: Rebuild.
 426         * gdbarch.sh (bits_big_endian): Remove.
 427         * gdbtypes.h (union field_location): Update comment.
 428         * target-descriptions.c (make_gdb_type): Update.
 429         * valarith.c (value_bit_index): Update.
 430         * value.c (struct value) <bitpos>: Update comment.
 431         (unpack_bits_as_long, modify_field): Update.
 432         * value.h (value_bitpos): Update comment.
 433
 434 2019-12-04  Tom Tromey  <tromey@adacore.com>
 435
 436         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 437         endian-ness.
 438
 439 2019-12-04  Tom Tromey  <tromey@adacore.com>
 440
 441         * dwarf2read.c (dwarf2_init_float_type)
 442         (dwarf2_init_complex_target_type): Add byte_order parameter.
 443         (read_base_type): Compute byte order earlier.
 444         * gdbtypes.c (init_float_type): Add byte_order parameter.
 445         * gdbtypes.h (init_float_type): Add byte_order parameter.
 446
 447 2019-12-04  Tom Tromey  <tromey@adacore.com>
 448
 449         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 450
 451 2019-12-04  Tom Tromey  <tromey@adacore.com>
 452
 453         * dwarf2read.c (process_structure_scope): Initialize
 454         "discr_offset".
 455
 456 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 457
 458         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 459         add it into the search spec.
 460         (parse_max_results_option): New function.
 461         (mi_info_functions_or_variables): Parse -max-results flag and pass
 462         it to mi_symbol_info.
 463         (mi_cmd_symbol_info_modules): Likewise.
 464         (mi_cmd_symbol_info_types): Likewise.
 465         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 466         return type to bool, change result container into a set, and don't
 467         add new results if we have enough already.
 468         (global_symbol_searcher::add_matching_msymbols): Change return
 469         type to bool, and don't add new results if we have enough already.
 470         (sort_search_symbols_remove_dups): Delete.
 471         (global_symbol_searcher::search): Early exit from search loop when
 472         we have enough results.  Use a std::set to collect the results
 473         from calling add_matching_symbols.
 474         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 475         member function.
 476         (global_symbol_searcher) <m_max_search_results>: New member
 477         variable.
 478         (global_symbol_searcher) <add_matching_symbols>: Update header
 479         comment and change return type to bool.
 480         (global_symbol_searcher) <add_matching_msymbols>: Update header
 481         comment and change return type to bool.
 482
 483 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 484
 485         * symtab.c (symbol_search::compare_search_syms): Update header
 486         comment.
 487         (global_symbol_searcher::is_suitable_msymbol): New function.
 488         (global_symbol_searcher::expand_symtabs): New function.
 489         (global_symbol_searcher::add_matching_symbols): New function.
 490         (global_symbol_searcher::add_matching_msymbols): New function.
 491         (global_symbol_searcher::search): Move most of the content
 492         into the new functions above, and call them as needed.
 493         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 494         function.
 495         (global_symbol_searcher) <add_matching_symbols>: New member
 496         function.
 497         (global_symbol_searcher) <add_matching_msymbols>: New member
 498         function.
 499         (global_symbol_searcher) <is_suitable_msymbol>: New member
 500         function.
 501
 502 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 503
 504         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 505         -symbol-info-module-variables entries.
 506         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 507         (mi_cmd_symbol_info_module_variables): Declare.
 508         * mi/mi-symbol-cmds.c
 509         (module_symbol_search_iterator): New typedef.
 510         (output_module_symbols_in_single_module_and_file): New function.
 511         (output_module_symbols_in_single_module): New function.
 512         (mi_info_module_functions_or_variables): New function.
 513         (mi_cmd_symbol_info_module_functions): New function.
 514         (mi_cmd_symbol_info_module_variables): New function.
 515         * NEWS: Mention new MI command.
 516
 517 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 518
 519         * bcache.c (hash): Remove.
 520         (hash_continue): Remove.
 521         * bcache.h (hash): Remove.
 522         (hash_continue): Remove.
 523         (struct bcache) <ctor>: Update.
 524         * psymtab.c (psymbol_hash): Update.
 525         * stabsread.c (hashname): Update.
 526         * utils.h (fast_hash): Add an argument for a start value,
 527         defaulting to zero.
 528
 529 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 530         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 531         (destroy_block_symbol_cache): New function.
 532         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 533         (resize_symbol_cache): Likewise.
 534
 535 2019-12-02  Tom Tromey  <tom@tromey.com>
 536
 537         * unittests/tui-selftests.c (run_tests): Make conditional.
 538         (_initialize_tui_selftest): Make conditional.
 539
 540 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 541
 542         * aix-thread.c (debug_aix_thread): Change type to bool.
 543
 544 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 545
 546         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 547
 548 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 549
 550         * dwarf2read.c (read_tag_string_type): Read the fields required to
 551         make a dynamic string, and possibly create a dynamic range for the
 552         string.
 553         (attr_to_dynamic_prop): Setup is_reference based on the type of
 554         attribute being processed.
 555         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 556         (resolve_dynamic_array): Rename to...
 557         (resolve_dynamic_array_or_string): ...this, update header comment,
 558         and accept TYPE_CODE_STRING.
 559         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 560
 561 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 562
 563         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 564         of its implementation from...
 565         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 566         the new function.
 567
 568 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 569
 570         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 571         create a range with stride where appropriate.
 572         * f-valprint.c: Include 'gdbarch.h'.
 573         (f77_print_array_1): Take the stride into account when walking the
 574         array.  Also convert the stride into addressable units.
 575         * gdbtypes.c (create_range_type): Initialise the stride to
 576         constant zero.
 577         (create_range_type_with_stride): New function, initialise the
 578         range as normal, and then setup the stride.
 579         (has_static_range): Include the stride here.  Also change the
 580         return type to bool.
 581         (create_array_type_with_stride): Consider the range stride if the
 582         array isn't given its own stride.
 583         (resolve_dynamic_range): Resolve the stride if needed.
 584         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 585         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 586         (TYPE_BIT_STRIDE): Define.
 587         (TYPE_ARRAY_BIT_STRIDE): Define.
 588         (create_range_type_with_stride): Declare.
 589         * valarith.c (value_subscripted_rvalue): Take range stride into
 590         account when walking the array.
 591
 592 2019-12-01  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 595         specially.
 596
 597 2019-12-01  Tom Tromey  <tom@tromey.com>
 598
 599         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 600         \0.
 601         * unittests/tui-selftests.c: New file.
 602         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 603
 604 2019-12-01  Tom Tromey  <tom@tromey.com>
 605
 606         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 607
 608 2019-12-01  Tom Tromey  <tom@tromey.com>
 609
 610         * NEWS: Document new settings.
 611         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 612         * tui/tui-win.c (_initialize_tui_win): Add border style
 613         observers.
 614         * tui/tui-io.h (tui_apply_style): Declare.
 615         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 616         longer static.
 617         (apply_ansi_escape, tui_set_reverse_mode): Update.
 618         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 619         Add "skip_intensity" parameter.
 620         <changed>: New member.
 621         <do_set_value>: Declare.
 622         (tui_border_style, tui_active_border_style): Declare.
 623         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 624         globals.
 625         (cli_style_option): Initialize "changed".
 626         (cli_style_option::do_set_value): New function.
 627         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 628         parameter.  Update.
 629         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 630         (_initialize_cli_style): Update.  Create TUI border style
 631         commands.
 632
 633 2019-12-01  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 636         parameter.
 637         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 638         parameter.
 639         * tui/tui-win.h (compact_source): Declare.
 640         * tui/tui-win.c (compact_source): New global.
 641         (tui_set_compact_source, tui_show_compact_source): New functions.
 642         (_initialize_tui_win): Add "compact-source" setting.
 643         * tui/tui-source.c (tui_source_window::set_contents): Handle
 644         compact_source setting.
 645         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 646         * NEWS: Document new setting.
 647
 648 2019-11-30  Tom Tromey  <tom@tromey.com>
 649
 650         * dwarf2read.c (dwarf2_add_field): Include field offset when
 651         computing variant part length.
 652
 653 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 654         * NEWS:  Mention define-prefix.  Tell that command names can now
 655         contain a . character.
 656
 657 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 658
 659         * command.h (valid_cmd_char_p): Declare.
 660         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 661         the check of valid command char.
 662         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 663         valid_cmd_char_p.
 664         * cli/cli-script.c (validate_comname): Likewise.
 665         * completer.c (gdb_completer_command_word_break_characters):
 666         Do not remove . from the word break char, update comments.
 667         (complete_line_internal_1): Use valid_cmd_char_p.
 668         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 669         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 670
 671 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 672
 673         * cli/cli-script.c (do_define_command): Ensure a redefined
 674         prefix command is kept as a prefix command.
 675         (define_prefix_command): New function.
 676         (show_user_1): Report user defined prefixes.
 677         (_initialize_cli_script):  Create the new 'define-prefix' command.
 678         Add completers for 'define' and 'document'.
 679         * top.c (execute_command):  If command is a user-defined prefix only
 680         command, report the list of commands for this prefix command.
 681
 682 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 683
 684         * valops.c (find_oload_champ): Improve debug output.
 685
 686 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 687
 688         * valops.c (find_oload_champ): Print part of debug messages
 689         before the badness vector is std::move'd.
 690
 691 2019-11-28  Tom Tromey  <tom@tromey.com>
 692
 693         * value.c (creal_internal_fn): Fix comment.
 694
 695 2019-11-28  Tom Tromey  <tom@tromey.com>
 696
 697         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 698         flag_bound_evaluated>: Now unsigned.
 699
 700 2019-11-28  Tom Tromey  <tom@tromey.com>
 701
 702         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 703         declare.
 704
 705 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 706
 707         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 708         debug output.
 709         * jit.c (jit_unregister_code): Add debug print to match
 710         `jit_register_code`.
 711
 712 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 713
 714         * NEWS: Mention the new multithreaded symbol loading.
 715
 716 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 717
 718         * maint.c (n_worker_threads): Default to 0.
 719         (worker_threads_disabled): New function.
 720         * maint.h (worker_threads_disabled): New function.
 721         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
 722         here if worker_threads_disabled () is true.
 723         (minimal_symbol_reader::install): Skip all threading if
 724         worker_threads_disabled () is true.
 725
 726 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 727
 728         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
 729         hash code if possible.
 730         (add_minsym_to_demangled_hash_table): Likewise.
 731         (minimal_symbol_reader::install): Compute the hash codes for msymbol
 732         on the background thread.
 733         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
 734         Add these fields.
 735
 736 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 737
 738         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
 739         of the mangled name on the background thread.
 740         * symtab.c (symbol_set_names): Allow passing in the hash of the
 741         linkage_name.
 742         * symtab.h (symbol_set_names): Likewise.
 743
 744 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 745
 746         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
 747         physnames are computed for inherited DIEs.
 748
 749 2019-11-27  Tom Tromey  <tromey@adacore.com>
 750
 751         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 752         backslashes.
 753         * cp-support.c: Remove unnecessary backslashes.
 754
 755 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 756
 757         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 758         with sym->set_linkage_name.
 759         * coffread.c (coff_read_enum_type): Likewise.
 760         * mdebugread.c (parse_symbol): Likewise.
 761         * stabsread.c (patch_block_stabs): Likewise.
 762         (define_symbol): Likewise.
 763         (read_enum_type): Likewise.
 764         (common_block_end): Likewise.
 765         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 766         function.
 767         (SYMBOL_SET_LINKAGE_NAME): Remove.
 768         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 769         with sym->set_linkage_name.
 770
 771 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 772
 773         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 774         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 775         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 776         * NEWS: Mention new MI command.
 777
 778 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
 781         '-symbol-info-types', and '-symbol-info-variables'.
 782         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
 783         (mi_cmd_symbol_info_types): Declare.
 784         (mi_cmd_symbol_info_variables): Declare.
 785         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
 786         (output_debug_symbol): New function.
 787         (output_nondebug_symbol): New function.
 788         (mi_symbol_info): New function.
 789         (mi_info_functions_or_variables): New function.
 790         (mi_cmd_symbol_info_functions): New function.
 791         (mi_cmd_symbol_info_types): New function.
 792         (mi_cmd_symbol_info_variables): New function.
 793         * NEWS: Mention new commands.
 794
 795 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 796
 797         * symtab.c (symbol_to_info_string): New function, most content
 798         moved from print_symbol_info, but updated to return a std::string.
 799         (print_symbol_info): Update to use symbol_to_info_string and print
 800         returned string.
 801         * symtab.h (symbol_to_info_string): Declare new function.
 802
 803 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 804
 805         * python/python.c (gdbpy_rbreak): Convert to using
 806         global_symbol_searcher.
 807         * symtab.c (file_matches): Convert return type to bool, change
 808         file list to std::vector, update header comment.
 809         (search_symbols): Rename to...
 810         (global_symbol_searcher::search): ...this and update now its
 811         a member function of global_symbol_searcher.  Take account of the
 812         changes to file_matches.
 813         (symtab_symbol_info): Convert to using global_symbol_searcher.
 814         (rbreak_command): Likewise.
 815         (search_module_symbols): Likewise.
 816         * symtab.h (enum symbol_search): Update comment.
 817         (search_symbols): Remove declaration.
 818         (class global_symbol_searcher): New class.
 819
 820 2019-11-26  Tom Tromey  <tromey@adacore.com>
 821
 822         * cp-support.c (_initialize_cp_support): Conditionally initialize
 823         gdb_demangle_attempt_core_dump.
 824
 825 2019-11-26  Tom Tromey  <tom@tromey.com>
 826
 827         * python/py-function.c (fnpy_init): Update.
 828         * value.h (add_internal_function): Adjust declaration.
 829         * value.c (function_destroyer): Remove.
 830         (do_add_internal_function): Don't set destroyer or copy name.
 831         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 832         Set name_allocated.
 833         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 834         (cmdpy_init): Set name_allocated.
 835         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 836         member.
 837         (~cmd_list_element): Free "name" if needed.
 838
 839 2019-11-26  Tom Tromey  <tom@tromey.com>
 840
 841         * value.h (add_internal_function): Add new overload.  Move
 842         documentation from value.h.
 843         * value.c (do_add_internal_function): New function.
 844         (add_internal_function): Use it.  Add new overload.
 845         (function_destroyer): Don't free doc.
 846         * python/py-function.c (fnpy_init): Update.
 847
 848 2019-11-26  Tom Tromey  <tom@tromey.com>
 849
 850         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 851         (cmdpy_init): Set "doc_allocated".
 852
 853 2019-11-26  Tom Tromey  <tom@tromey.com>
 854
 855         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 856         name of worker thread.
 857         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 858         pthread_setname_np.
 859         * configure, config.in: Rebuild.
 860
 861 2019-11-26  Tom Tromey  <tom@tromey.com>
 862
 863         * python/python.c (class gdbpy_gil): New.
 864         (struct gdbpy_event): Add constructor, destructor, operator().
 865         (gdbpy_post_event): Use run_on_main_thread.
 866         (gdbpy_initialize_events): Remove.
 867         (do_start_initialization): Update.
 868
 869 2019-11-26  Tom Tromey  <tom@tromey.com>
 870
 871         * NEWS: Add entry.
 872         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 873         commands.  Call update_thread_pool_size.
 874         (update_thread_pool_size, maintenance_set_worker_threads): New
 875         functions.
 876         (n_worker_threads): New global.
 877
 878 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 879             Tom Tromey  <tom@tromey.com>
 880
 881         * minsyms.c (minimal_symbol_reader::install): Use
 882         parallel_for_each.
 883         * gdbsupport/parallel-for.h: New file.
 884         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 885
 886 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 887             Tom Tromey  <tom@tromey.com>
 888
 889         * gdbsupport/thread-pool.h: New file.
 890         * gdbsupport/thread-pool.c: New file.
 891         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 892         (HFILES_NO_SRCDIR): Add thread-pool.h.
 893
 894 2019-11-26  Tom Tromey  <tom@tromey.com>
 895
 896         * event-top.h (thread_local_segv_handler): Declare.
 897         * event-top.c (thread_local_segv_handler): New global.
 898         (install_handle_sigsegv, handle_sigsegv): New functions.
 899         (async_init_signals): Install SIGSEGV handler.
 900         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 901         thread-local.
 902         (report_failed_demangle): New function.
 903         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 904         handler-setting code, instead use segv_handler.  Run warning code
 905         on main thread.
 906
 907 2019-11-26  Tom Tromey  <tom@tromey.com>
 908
 909         * run-on-main-thread.c: New file.
 910         * run-on-main-thread.h: New file.
 911         * unittests/main-thread-selftests.c: New file.
 912         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 913         main-thread-selftests.c.
 914         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 915         (COMMON_SFILES): Add run-on-main-thread.c.
 916
 917 2019-11-26  Tom Tromey  <tom@tromey.com>
 918
 919         * main.c (setup_alternate_signal_stack): Remove.
 920         (captured_main_1): Use gdb::alternate_signal_stack.
 921         * gdbsupport/alt-stack.h: New file.
 922
 923 2019-11-26  Tom Tromey  <tom@tromey.com>
 924
 925         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 926         Remove comment.
 927         (save_original_signals_state, restore_original_signals_state): Use
 928         gdb_sigmask.
 929         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 930         (_initialize_linux_nat): Use gdb_sigmask.
 931         * guile/guile.c (_initialize_guile): Use block_signals.
 932         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 933         * gdbsupport/gdb-sigmask.h: New file.
 934         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 935         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 936         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 937         pthread_sigmask.
 938         * configure, config.in: Rebuild.
 939         * gdbsupport/block-signals.h: New file.
 940
 941 2019-11-26  Tom Tromey  <tom@tromey.com>
 942
 943         * acinclude.m4: Include ax_pthread.m4.
 944         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 945         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 946         (CLIBS): Use PTHREAD_LIBS.
 947         (aclocal_m4_deps): Add ax_pthread.m4.
 948         * config.in, configure: Rebuild.
 949         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 950
 951 2019-11-26  Tom Tromey  <tom@tromey.com>
 952
 953         * symtab.h (struct minimal_symbol) <name_set>: New member.
 954         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 955         Don't call symbol_set_names.
 956         (minimal_symbol_reader::install): Call symbol_set_names.
 957
 958 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 959
 960         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 961         restore_active_ext_lang, as GIL is needed for (indirectly)
 962         called PyOS_InterruptOccurred.
 963
 964 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 965
 966         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 967         definition.
 968
 969 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 970
 971         * remote-sim.c (simulator_command): Make static, remove
 972         declaration.
 973
 974 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 975
 976         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 977         static.
 978         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 979         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 980         (main): Likewise.
 981         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 982         (main): Likewise.
 983         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 984         (main): Likewise.
 985         * unittests/basic_string_view/element_access/char/1.cc (test01):
 986         Likewise.
 987         (main): Likewise.
 988         * unittests/basic_string_view/element_access/char/empty.cc (main):
 989         Likewise.
 990         * unittests/basic_string_view/element_access/char/front_back.cc
 991         (test01): Likewise.
 992         (main): Likewise.
 993         * unittests/basic_string_view/inserters/char/2.cc (test05):
 994         Likewise.
 995         (main): Likewise.
 996         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 997         (test01): Likewise.
 998         (main): Likewise.
 999         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1000         (test01): Likewise.
1001         (main): Likewise.
1002         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1003         Likewise.
1004         * unittests/basic_string_view/operations/compare/char/1.cc
1005         (test01): Likewise.
1006         (main): Likewise.
1007         * unittests/basic_string_view/operations/compare/char/13650.cc
1008         (test01): Likewise.
1009         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1010         Likewise.
1011         (main): Likewise.
1012         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1013         Likewise.
1014         (main): Likewise.
1015         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1016         Likewise.
1017         (main): Likewise.
1018         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1019         Likewise.
1020         (main): Likewise.
1021         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1022         Likewise.
1023         (main): Likewise.
1024         * unittests/basic_string_view/operations/find/char/4.cc (main):
1025         Likewise.
1026         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1027         Likewise.
1028         (main): Likewise.
1029         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1030         Likewise.
1031         (main): Likewise.
1032         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1033         Likewise.
1034         (main): Likewise.
1035         * unittests/basic_string_view/operations/substr/char/1.cc
1036         (test01): Likewise.
1037         (main): Likewise.
1038         * unittests/basic_string_view/operators/char/2.cc (main):
1039         Likewise.
1040         * unittests/optional/assignment/1.cc (test): Likewise.
1041         * unittests/optional/assignment/2.cc (test): Likewise.
1042         * unittests/optional/assignment/3.cc (test): Likewise.
1043         * unittests/optional/assignment/4.cc (test): Likewise.
1044         * unittests/optional/assignment/5.cc (test): Likewise.
1045         * unittests/optional/assignment/6.cc (test): Likewise.
1046         * unittests/optional/assignment/7.cc (test): Likewise.
1047         * unittests/optional/cons/copy.cc (test): Likewise.
1048         * unittests/optional/cons/default.cc (test): Likewise.
1049         * unittests/optional/cons/move.cc (test): Likewise.
1050         * unittests/optional/cons/value.cc (test): Likewise.
1051         * unittests/optional/in_place.cc (test): Likewise.
1052         * unittests/optional/observers/1.cc (test): Likewise.
1053         * unittests/optional/observers/2.cc (test): Likewise.
1054
1055 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1056
1057         * tui-win.h (tui_set_var_cmd): Remove.
1058         * tui-win.c (tui_set_var_cmd): Make static.
1059
1060 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1061
1062         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1063         rbreak_command_wrapper): Remove.
1064         * symtab.c (rbreak_command_wrapper): Remove.
1065
1066 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1067
1068         * inferior.h (info_terminal_command): Remove declaration.
1069         * inflow.c (info_terminal_command): Make static.
1070
1071 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1072
1073         * inferior.c (exit_inferior_silent): Remove.
1074
1075 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1076
1077         * dictionary.c (dict_empty, mdict_empty): Remove.
1078         * dictionary.c (mdict_empty): Remove.
1079
1080 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1081
1082          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1083          (arc_insn_get_memory_offset): Likewise.
1084          (arc_insn_dump): Likewise.
1085          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1086          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1087          * dictionary.c (dict_iterator_next): Likewise.
1088          (dict_iter_match_first): Likewise.
1089          (dict_iter_match_next): Likewise.
1090          * f-lang.c (evaluate_subexp_f): Likewise.
1091          * hppa-tdep.c (hppa_read_pc): Likewise.
1092          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1093          * parse.c (write_exp_elt_msym): Likewise.
1094          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1095          * remote.c (remote_packet_size): Likewise.
1096          (remote_notif_stop_parse): Likewise.
1097          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1098          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1099          * source.c (prepare_path_for_appending): Likewise.
1100          * sparc64-linux-tdep.c
1101          (sparc64_linux_handle_segmentation_fault); Likewise.
1102          * stack.c (frame_selection_by_function_completer): Likewise.
1103
1104 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1105
1106         * completer.c (set_gdb_completion_word_break_characters):
1107         Remove.
1108
1109 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1110
1111         * dwarf-index-write.c: Include dwarf-index-write.h.
1112         * mi/mi-interp.c: Include mi/mi-interp.h.
1113
1114 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1115
1116         * aarch32-tdep.c: Include aarch32-tdep.h.
1117         * aarch32-tdep.h: Forward-declare struct target_desc.
1118
1119 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1120
1121         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1122         strerror.
1123         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1124         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1125
1126 2019-11-25  Tom de Vries  <tdevries@suse.de>
1127
1128         * contrib/words.sh: Add -c option.
1129
1130 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1131
1132         * solib.c (solib_find_1): Change int to bool.
1133         (exec_file_find): Change int to bool.
1134         (solib_find): Change int to bool.
1135         (solib_read_symbols): Change int to bool.
1136         (solib_used): Change int to bool.
1137         (solib_add): Change int to bool.
1138         (info_sharedlibrary_command): Change int to bool.
1139         (solib_contains_address_p): Change int to bool.
1140         (solib_keep_data_in_core): Change int to bool.
1141         (in_solib_dynsym_resolve_code): Change int to bool.
1142         (reload_shared_libraries_1): Change int to bool.
1143         (gdb_sysroot_changed): Change int to bool.
1144         * solib.h (solib_read_symbols): Change int to bool.
1145         (solib_contains_address_p): Change int to bool.
1146         (solib_keep_data_in_core): Change int to bool.
1147         (in_solib_dynsym_resolve_code): Change int to bool.
1148         (libpthread_name_p): Change int to bool.
1149
1150 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1151
1152         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1153         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1154         (remote_packet_max_chars): New static global.
1155         (show_remote_packet_max_chars): New function.
1156         (remote_target::putpkt_binary): Adjust to use new
1157         remote_packet_max_chars option.
1158         (remote_target::getpkt_or_notif_sane_1): Likewise.
1159         (_initialize_remote): Register new remote-packet-max-chars option.
1160
1161 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1162
1163         * m68k-linux-nat.c: Include gdbarch.h.
1164
1165 2019-11-24  Tom Tromey  <tom@tromey.com>
1166
1167         * symfile.c (read_symbols): Update.
1168         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1169         bool.
1170         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1171         (psym_lookup_symbol, psym_find_last_source_symtab)
1172         (psym_forget_cached_source_info, psym_print_stats)
1173         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1174         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1175         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1176         (psym_find_compunit_symtab_by_address)
1177         (maintenance_print_psymbols, maintenance_info_psymtabs)
1178         (maintenance_check_psymtabs): Update.
1179         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1180         bool.
1181
1182 2019-11-22  Tom Tromey  <tom@tromey.com>
1183
1184         * observable.h: Update comments.
1185
1186 2019-11-22  Tom Tromey  <tromey@adacore.com>
1187
1188         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1189         (print_ada_task_info): Don't try to fetch thread id if task is not
1190         alive.
1191
1192 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1193
1194         * ada-exp.y: Update.
1195         * ada-lang.c (sort_choices): Update.
1196         (ada_print_symbol_signature): Update.
1197         (resolve_subexp): Update.
1198         (ada_parse_renaming): Update.
1199         (ada_read_renaming_var_value): Update.
1200         (lesseq_defined_than): Update.
1201         (remove_extra_symbols): Update.
1202         (remove_irrelevant_renamings): Update.
1203         (ada_add_block_symbols): Update.
1204         (ada_collect_symbol_completion_matches): Update.
1205         (ada_is_renaming_symbol): Update.
1206         (aggregate_assign_from_choices): Update.
1207         (ada_evaluate_subexp): Update.
1208         (ada_has_this_exception_support): Update.
1209         (ada_is_non_standard_exception_sym): Update.
1210         (ada_add_exceptions_from_frame): Update.
1211         (ada_add_global_exceptions): Update.
1212         (ada_print_subexp): Update.
1213         * ax-gdb.c (gen_var_ref): Update.
1214         (gen_maybe_namespace_elt): Update.
1215         (gen_expr_for_cast): Update.
1216         (gen_expr): Update.
1217         * block.h: Update.
1218         * blockframe.c (find_pc_partial_function): Update.
1219         * breakpoint.c (print_breakpoint_location): Update.
1220         (update_static_tracepoint): Update.
1221         * btrace.c (ftrace_print_function_name): Update.
1222         (ftrace_function_switched): Update.
1223         * buildsym.c (find_symbol_in_list): Update.
1224         * c-exp.y: Update.
1225         * c-typeprint.c (c_print_typedef): Update.
1226         (c_type_print_template_args): Update.
1227         * cli/cli-cmds.c (edit_command): Update.
1228         (list_command): Update.
1229         (print_sal_location): Update.
1230         * coffread.c (patch_opaque_types): Update.
1231         (process_coff_symbol): Update.
1232         (coff_read_enum_type): Update.
1233         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1234         (convert_one_symbol): Update.
1235         (hash_symname): Update.
1236         (eq_symname): Update.
1237         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1238         * compile/compile-cplus-types.c (debug_print_scope): Update.
1239         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1240         * compile/compile-object-load.c (get_out_value_type): Update.
1241         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1242         (search_symbol_list): Update.
1243         (cp_lookup_symbol_imports_or_template): Update.
1244         * cp-support.c (overload_list_add_symbol): Update.
1245         * ctfread.c (psymtab_to_symtab): Update.
1246         * dbxread.c (cp_set_block_scope): Update.
1247         * dictionary.c (iter_match_first_hashed): Update.
1248         (iter_match_next_hashed): Update.
1249         (insert_symbol_hashed): Update.
1250         (iter_match_next_linear): Update.
1251         * dictionary.h: Update.
1252         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1253         (locexpr_describe_location_piece): Update.
1254         (locexpr_describe_location_1): Update.
1255         (locexpr_generate_c_location): Update.
1256         (loclist_describe_location): Update.
1257         (loclist_generate_c_location): Update.
1258         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1259         (read_func_scope): Update.
1260         (process_enumeration_scope): Update.
1261         (new_symbol): Update.
1262         (dwarf2_const_value): Update.
1263         (dwarf2_symbol_mark_computed): Update.
1264         * eval.c (evaluate_funcall): Update.
1265         (evaluate_subexp_standard): Update.
1266         * expprint.c (print_subexp_standard): Update.
1267         (dump_subexp_body_standard): Update.
1268         * f-valprint.c (info_common_command_for_block): Update.
1269         * findvar.c (get_hosting_frame): Update.
1270         (default_read_var_value): Update.
1271         * go-lang.c (go_symbol_package_name): Update.
1272         * guile/scm-block.c (bkscm_print_block_smob): Update.
1273         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1274         (gdbscm_symbol_name): Update.
1275         (gdbscm_symbol_linkage_name): Update.
1276         (gdbscm_symbol_print_name): Update.
1277         * infcall.c (get_function_name): Update.
1278         * infcmd.c (jump_command): Update.
1279         (finish_command): Update.
1280         * infrun.c (insert_exception_resume_breakpoint): Update.
1281         * linespec.c (canonicalize_linespec): Update.
1282         (create_sals_line_offset): Update.
1283         (convert_linespec_to_sals): Update.
1284         (complete_label): Update.
1285         (find_label_symbols_in_block): Update.
1286         * m2-typeprint.c (m2_print_typedef): Update.
1287         * mdebugread.c (mdebug_reg_to_regnum): Update.
1288         (parse_symbol): Update.
1289         (mylookup_symbol): Update.
1290         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1291         (list_args_or_locals): Update.
1292         * objc-lang.c (compare_selectors): Update.
1293         (info_selectors_command): Update.
1294         (compare_classes): Update.
1295         (info_classes_command): Update.
1296         (find_imps): Update.
1297         * p-typeprint.c (pascal_print_typedef): Update.
1298         * printcmd.c (build_address_symbolic): Update.
1299         (info_address_command): Update.
1300         (print_variable_and_value): Update.
1301         * python/py-framefilter.c (extract_sym): Update.
1302         (py_print_single_arg): Update.
1303         * python/py-symbol.c (sympy_str): Update.
1304         (sympy_get_name): Update.
1305         (sympy_get_linkage_name): Update.
1306         * python/python.c (gdbpy_rbreak): Update.
1307         * record-btrace.c (btrace_get_bfun_name): Update.
1308         (btrace_call_history): Update.
1309         * rust-lang.c (rust_print_typedef): Update.
1310         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1311         * stabsread.c (stab_reg_to_regnum): Update.
1312         (define_symbol): Update.
1313         (read_enum_type): Update.
1314         (common_block_end): Update.
1315         (cleanup_undefined_types_1): Update.
1316         (scan_file_globals): Update.
1317         * stack.c (print_frame_arg): Update.
1318         (print_frame_args): Update.
1319         (find_frame_funname): Update.
1320         (info_frame_command_core): Update.
1321         (iterate_over_block_locals): Update.
1322         (print_block_frame_labels): Update.
1323         (do_print_variable_and_value): Update.
1324         (iterate_over_block_arg_vars): Update.
1325         (return_command): Update.
1326         * symmisc.c (dump_symtab_1): Update.
1327         (print_symbol): Update.
1328         * symtab.c (eq_symbol_entry): Update.
1329         (symbol_cache_dump): Update.
1330         (lookup_language_this): Update.
1331         (find_pc_sect_line): Update.
1332         (skip_prologue_sal): Update.
1333         (symbol_search::compare_search_syms): Update.
1334         (treg_matches_sym_type_name): Update.
1335         (search_symbols): Update.
1336         (print_symbol_info): Update.
1337         (rbreak_command): Update.
1338         (completion_list_add_symbol): Update.
1339         (find_gnu_ifunc): Update.
1340         (get_symbol_address): Update.
1341         (search_module_symbols): Update.
1342         (info_module_subcommand): Update.
1343         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1344         (SYMBOL_LINKAGE_NAME): Remove.
1345         (SYMBOL_DEMANGLED_NAME): Remove.
1346         (SYMBOL_PRINT_NAME): Remove.
1347         (SYMBOL_SEARCH_NAME): Remove.
1348         * tracepoint.c (set_traceframe_context): Update.
1349         (validate_actionline): Update.
1350         (collection_list::collect_symbol): Update.
1351         (encode_actions_1): Update.
1352         (info_scope_command): Update.
1353         (print_one_static_tracepoint_marker): Update.
1354         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1355         * valops.c (address_of_variable): Update.
1356         (find_overload_match): Update.
1357         (find_oload_champ): Update.
1358
1359 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1360
1361         * ada-lang.c (ada_lookup_simple_minsym): Update.
1362         (ada_collect_symbol_completion_matches): Update.
1363         * ada-tasks.c (read_atcb): Update.
1364         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1365         (amd64_windows_skip_trampoline_code): Update.
1366         * arm-tdep.c (skip_prologue_function): Update.
1367         (arm_skip_stack_protector): Update.
1368         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1369         (arm_wince_skip_main_prologue): Update.
1370         * ax-gdb.c (gen_expr): Update.
1371         * block.c (call_site_for_pc): Update.
1372         * blockframe.c (find_pc_partial_function): Update.
1373         * breakpoint.c (set_breakpoint_location_function): Update.
1374         * btrace.c (ftrace_print_function_name): Update.
1375         (ftrace_function_switched): Update.
1376         * c-valprint.c (print_unpacked_pointer): Update.
1377         * coffread.c (coff_symfile_read): Update.
1378         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1379         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1380         * dwarf-index-write.c (write_psymbols): Update.
1381         * dwarf2loc.c (call_site_to_target_addr): Update.
1382         (func_verify_no_selftailcall): Update.
1383         (tailcall_dump): Update.
1384         (call_site_find_chain_1): Update.
1385         (dwarf_expr_reg_to_entry_parameter): Update.
1386         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1387         * eval.c (evaluate_funcall): Update.
1388         (evaluate_subexp_standard): Update.
1389         (evaluate_subexp_for_sizeof): Update.
1390         * expprint.c (print_subexp_standard): Update.
1391         (dump_subexp_body_standard): Update.
1392         * frame.c (get_prev_frame_always_1): Update.
1393         * frv-tdep.c (frv_skip_main_prologue): Update.
1394         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1395         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1396         (gnuv3_get_typename_from_type_info): Update.
1397         (gnuv3_skip_trampoline): Update.
1398         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1399         * i386-tdep.c (i386_skip_main_prologue): Update.
1400         (i386_pe_skip_trampoline_code): Update.
1401         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1402         * infcall.c (get_function_name): Update.
1403         * linespec.c (minsym_found): Update.
1404         * linux-fork.c (info_checkpoints_command): Update.
1405         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1406         (m32c_m16c_pointer_to_address): Update.
1407         * maint.c (maintenance_translate_address): Update.
1408         * minsyms.c (add_minsym_to_hash_table): Update.
1409         (add_minsym_to_demangled_hash_table): Update.
1410         (lookup_minimal_symbol_mangled): Update.
1411         (lookup_minimal_symbol_demangled): Update.
1412         (lookup_minimal_symbol_linkage): Update.
1413         (lookup_minimal_symbol_text): Update.
1414         (lookup_minimal_symbol_by_pc_name): Update.
1415         (minimal_symbol_is_less_than): Update.
1416         (compact_minimal_symbols): Update.
1417         (build_minimal_symbol_hash_tables): Update.
1418         (find_solib_trampoline_target): Update.
1419         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1420         (mips_skip_pic_trampoline_code): Update.
1421         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1422         * objc-lang.c (info_selectors_command): Update.
1423         (info_classes_command): Update.
1424         (find_methods): Update.
1425         (find_imps): Update.
1426         * p-valprint.c (pascal_val_print): Update.
1427         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1428         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1429         * printcmd.c (build_address_symbolic): Update.
1430         (info_symbol_command): Update.
1431         * psymtab.c (psymbol_name_matches): Update.
1432         (match_partial_symbol): Update.
1433         (lookup_partial_symbol): Update.
1434         (print_partial_symbols): Update.
1435         (sort_pst_symbols): Update.
1436         (maintenance_check_psymtabs): Update.
1437         * python/py-framefilter.c (py_print_frame): Update.
1438         * python/python.c (gdbpy_rbreak): Update.
1439         * record-btrace.c (btrace_get_bfun_name): Update.
1440         (btrace_call_history): Update.
1441         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1442         (rs6000_skip_trampoline_code): Update.
1443         * sol-thread.c (info_cb): Update.
1444         * stabsread.c (scan_file_globals): Update.
1445         * stack.c (find_frame_funname): Update.
1446         (info_frame_command_core): Update.
1447         * symmisc.c (dump_msymbols): Update.
1448         * symtab.c (symbol_natural_name): Rename to..,
1449         (general_symbol_info::natural_name): ...this.
1450         (symbol_demangled_name): Rename to...
1451         (general_symbol_info::demangled_name): ...this.
1452         (symbol_search_name): Rename to...
1453         (general_symbol_info::search_name): ...this.
1454         (symbol_matches_search_name): Update.
1455         (find_pc_sect_line): Update.
1456         (skip_prologue_sal): Update.
1457         (search_symbols): Update.
1458         (print_msymbol_info): Update.
1459         (rbreak_command): Update.
1460         (completion_list_add_msymbol): Update.
1461         (completion_list_objc_symbol): Update.
1462         (get_msymbol_address): Update.
1463         * symtab.h (struct general_symbol_info): Add member functions
1464         natural_name (), linkage_name (), print_name (), demangled_name (),
1465         and search_name ().
1466         (SYMBOL_NATURAL_NAME): Update.
1467         (symbol_natural_name): Move to a member function on general_symbol_info.
1468         (SYMBOL_DEMANGLED_NAME): Update.
1469         (symbol_demangled_name): Move to a member function on
1470         general_symbol_info.
1471         (SYMBOL_SEARCH_NAME): Update.
1472         (symbol_search_name): Move to a member function on general_symbol_info.
1473         (MSYMBOL_NATURAL_NAME): Remove.
1474         (MSYMBOL_LINKAGE_NAME): Remove.
1475         (MSYMBOL_PRINT_NAME): Remove.
1476         (MSYMBOL_DEMANGLED_NAME): Remove.
1477         (MSYMBOL_SEARCH_NAME): Remove.
1478         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1479
1480 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1481
1482         * symtab.c (create_demangled_names_hash): Use per_bfd->
1483         minimal_symbol_count for computing the initial size, if greater
1484         than our default size.
1485
1486 2019-11-22  Tom de Vries  <tdevries@suse.de>
1487
1488         * contrib/words.sh: Improve words extraction.
1489
1490 2019-11-22  Tom de Vries  <tdevries@suse.de>
1491
1492         * contrib/words.sh: Combine sed invocations.
1493
1494 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1495
1496         * Makefile.in: Update.
1497         * demangle.c: Rename to...
1498         * gdb-demangle.c: ..this.
1499         (is_cplus_marker): Change return type to bool.
1500         (_initialize_demangler): Rename to...
1501         (_initialize_gdb_demangle): ...this.
1502         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1503         * symtab.h (demangle): Remove declaration; instead include
1504         gdb-demangle.h.
1505
1506 2019-11-21  Tom Tromey  <tromey@adacore.com>
1507
1508         * gdbsupport/format.c (format_pieces): Parse %I64d.
1509         * unittests/format_pieces-selftests.c (test_windows_formats): New
1510         function.
1511         (run_tests): Call it.
1512
1513 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1514
1515         Byte reverse display of variables with DW_END_big, DW_END_little
1516         (DW_AT_endianity) dwarf attributes if different than the native
1517         byte order.
1518         * ada-lang.c (ada_value_binop):
1519         Use type_byte_order instead of gdbarch_byte_order.
1520         * ada-valprint.c (printstr):
1521         (ada_val_print_string):
1522         * ada-lang.c (value_pointer):
1523         (ada_value_binop):
1524         Use type_byte_order instead of gdbarch_byte_order.
1525         * c-lang.c (c_get_string):
1526         Use type_byte_order instead of gdbarch_byte_order.
1527         * c-valprint.c (c_val_print_array):
1528         Use type_byte_order instead of gdbarch_byte_order.
1529         * cp-valprint.c (cp_print_class_member):
1530         Use type_byte_order instead of gdbarch_byte_order.
1531         * dwarf2loc.c (rw_pieced_value):
1532         Use type_byte_order instead of gdbarch_byte_order.
1533         * dwarf2read.c (read_base_type): Handle DW_END_big,
1534         DW_END_little
1535         * f-lang.c (f_get_encoding):
1536         Use type_byte_order instead of gdbarch_byte_order.
1537         * findvar.c (default_read_var_value):
1538         Use type_byte_order instead of gdbarch_byte_order.
1539         * gdbtypes.c (check_types_equal):
1540         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1541         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1542         and TYPE_ENDIANITY_LITTLE if set.
1543         (type_byte_order): new function.
1544         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1545         (struct main_type) <flag_endianity_not_default>:
1546         New field.
1547         (type_byte_order): New function.
1548         * infcmd.c (default_print_one_register_info):
1549         Use type_byte_order instead of gdbarch_byte_order.
1550         * p-lang.c (pascal_printstr):
1551         Use type_byte_order instead of gdbarch_byte_order.
1552         * p-valprint.c (pascal_val_print):
1553         Use type_byte_order instead of gdbarch_byte_order.
1554         * printcmd.c (print_scalar_formatted):
1555         Use type_byte_order instead of gdbarch_byte_order.
1556         * solib-darwin.c (darwin_current_sos):
1557         Use type_byte_order instead of gdbarch_byte_order.
1558         * solib-svr4.c (solib_svr4_r_ldsomap):
1559         Use type_byte_order instead of gdbarch_byte_order.
1560         * stap-probe.c (stap_modify_semaphore):
1561         Use type_byte_order instead of gdbarch_byte_order.
1562         * target-float.c (target_float_same_format_p):
1563         Use type_byte_order instead of gdbarch_byte_order.
1564         * valarith.c (scalar_binop):
1565         (value_bit_index):
1566         Use type_byte_order instead of gdbarch_byte_order.
1567         * valops.c (value_cast):
1568         Use type_byte_order instead of gdbarch_byte_order.
1569         * valprint.c (generic_emit_char):
1570         (generic_printstr):
1571         (val_print_string):
1572         Use type_byte_order instead of gdbarch_byte_order.
1573         * value.c (unpack_long):
1574         (unpack_bits_as_long):
1575         (unpack_value_bitfield):
1576         (modify_field):
1577         (pack_long):
1578         (pack_unsigned_long):
1579         Use type_byte_order instead of gdbarch_byte_order.
1580         * findvar.c (unsigned_pointer_to_address):
1581         (signed_pointer_to_address):
1582         (unsigned_address_to_pointer):
1583         (address_to_signed_pointer):
1584         (default_read_var_value):
1585         (default_value_from_register):
1586         Use type_byte_order instead of gdbarch_byte_order.
1587         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1588         Use type_byte_order instead of gdbarch_byte_order.
1589         * riscv-tdep.c (riscv_print_one_register_info):
1590         Use type_byte_order instead of gdbarch_byte_order.
1591
1592 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1593
1594         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1595         (current_ui_gdb_stdin_ptr): Likewise.
1596         (current_ui_gdb_stderr_ptr): Likewise.
1597         (current_ui_gdb_stdlog_ptr): Likewise.
1598         (current_ui_current_uiout_ptr): Likewise.
1599         (gen_ret_current_ui_field_ptr): Remove.
1600
1601 2019-11-21  Tom de Vries  <tdevries@suse.de>
1602
1603         PR gdb/24956
1604         * cli/cli-script.c (execute_control_command): Only switch to
1605         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1606
1607 2019-11-19  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1610         Now static.  Change type of "name".
1611         (tui_set_win_height_command): Don't copy "arg".
1612         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1613         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1614
1615 2019-11-19  Ali Tamur <tamur@google.com>
1616
1617         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1618         "if (attr != nullptr)".
1619         (dwarf2_find_base_address): Likewise.
1620         (dwarf2_build_include_psymtabs): Likewise.
1621         (read_cutu_die_from_dwo): Likewise.
1622         (read_func_scope): Likewise.
1623         (read_call_site_scope): Likewise.
1624         (dwarf2_get_pc_bounds): Likewise.
1625         (dwarf2_record_block_ranges): Likewise.
1626         (dwarf2_add_field): Likewise.
1627         (dwarf2_add_member_fn): Likewise.
1628         (read_structure_type): Likewise.
1629         (read_enumeration_type): Likewise.
1630         (read_array_type): Likewise.
1631         (read_array_order): Likewise.
1632         (read_set_type): Likewise.
1633         (read_common_block): Likewise.
1634         (read_tag_reference_type): Likewise.
1635         (read_tag_string_type): Likewise.
1636         (read_subroutine_type): Likewise.
1637         (read_base_type): Likewise.
1638         (read_subrange_type): Likewise.
1639         (new_symbol): Likewise.
1640         (prepare_one_comp_unit): Likewise.
1641
1642 2019-11-19  Tom Tromey  <tromey@adacore.com>
1643
1644         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1645         result in error when DebugActiveProcess fails.
1646
1647 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1648             Pedro Alves  <palves@redhat.com>
1649
1650         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1651         * target.c (target_stack::push): Call 'unpush' if there's a
1652         target on top of the stack.
1653
1654 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1655
1656         * python/py-block.c (blpy_dealloc): Call tp_free.
1657         (blpy_block_syms_dealloc): Likewise.
1658         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1659         * python/py-inferior.c (infpy_dealloc): Likewise.
1660         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1661         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1662         * python/py-symbol.c (sympy_dealloc): Likewise.
1663         * python/py-symtab.c (stpy_dealloc): Likewise.
1664         * python/py-type.c (typy_iterator_dealloc): Likewise.
1665
1666 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1667
1668         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1669         constructor instead of using a class initializer.
1670
1671 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1672
1673         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1674         * configure: Regenerate.
1675         * configure.ac: Don't source common.host.
1676         * gdbsupport/common.host: Remove.
1677         * gdbsupport/mingw-strerror.c: Remove.
1678         * gdbsupport/posix-strerror.c: Rename to...
1679         * gdbsupport/safe-strerror.c: ...this.
1680
1681 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1682
1683         * maint.c (scoped_command_stats::print_time): Use localtime_r
1684         instead of localtime (provided through gnulib if necessary).
1685         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1686         of ctime.
1687
1688 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1689
1690         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1691         avoid compile errors.
1692
1693 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1694
1695         * config.in: Regenerate.
1696         * configure: Regenerate.
1697         * gdbsupport/common.m4: No longer check for strerror_r.
1698         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1699         POSIX version of strerror_r, now that gnulib provides it if
1700         necessary.
1701
1702 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1703
1704         * README (`configure' options): Update.
1705
1706 2019-11-14  Tom Tromey  <tromey@adacore.com>
1707
1708         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1709         expected type for the RHS if the LHS is a convenience variable.
1710
1711 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1712
1713         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1714         Provide explicit default and copy constructor.
1715
1716 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1717
1718         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1719         only call Py_INCREF (newbp) in the bppy_pending_object case.
1720
1721 2019-11-13  Tom Tromey  <tromey@adacore.com>
1722
1723         PR build/25182:
1724         * psympriv.h (partial_symbol): Remove static assert.
1725         * symtab.h (general_symbol_info, symbol): Remove static assert.
1726
1727 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1728
1729         * gdbsupport/format.c (format_pieces::format_pieces): Support
1730         printf 'z' size modifier.
1731         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1732         * printcmd.c (ui_printf):  Handle size_t_arg.
1733         * ui-out.c (ui_out::vmessage): Likewise.
1734         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1735         function.
1736         (run_tests): Call test_format_int_sizes.
1737
1738 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1739
1740         * ada-exp.y (write_ambiguous_var): Update.
1741         * buildsym.c (add_symbol_to_list): Update.
1742         * dwarf2read.c (read_variable): Update.
1743         (new_symbol): Update.
1744         * jit.c (finalize_symtab): Update.
1745         * language.c (language_alloc_type_symbol): Update.
1746         * symtab.c (fixup_symbol_section): Update.
1747         (initialize_objfile_symbol_1): Move code to...
1748         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1749         (allocate_symbol): Update.
1750         (allocate_template_symbol): Update.
1751         (get_symbol_address): Update.
1752         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1753         of having as a field, and add a constructor.
1754         (SYMBOL_VALUE): Update.
1755         (SYMBOL_VALUE_ADDRESS): Update.
1756         (SET_SYMBOL_VALUE_ADDRESS): Update.
1757         (SYMBOL_VALUE_BYTES): Update.
1758         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1759         (SYMBOL_BLOCK_VALUE): Update.
1760         (SYMBOL_VALUE_CHAIN): Update.
1761         (SYMBOL_LANGUAGE): Update.
1762         (SYMBOL_SECTION): Update.
1763         (SYMBOL_OBJ_SECTION): Update.
1764         (SYMBOL_SET_LANGUAGE): Update.
1765         (SYMBOL_SET_LINKAGE_NAME): Update.
1766         (SYMBOL_SET_NAMES): Update.
1767         (SYMBOL_NATURAL_NAME): Update.
1768         (SYMBOL_LINKAGE_NAME): Update.
1769         (SYMBOL_DEMANGLED_NAME): Update.
1770         (SYMBOL_SEARCH_NAME): Update.
1771         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1772         (struct symbol): Update.
1773         (struct template_symbol): Update.
1774         (struct rust_vtable_symbol): Update.
1775         * xcoffread.c (SYMBOL_DUP): Update.
1776
1777 2019-11-12  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-layout.c (show_layout): Set current_layout.
1780         (show_source_disasm_command, show_data)
1781         (show_source_or_disasm_and_command): Don't set current_layout.
1782
1783 2019-11-12  Tom Tromey  <tom@tromey.com>
1784
1785         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1786
1787 2019-11-12  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-win.c (resize_message): New global.
1790         (show_tui_resize_message): New function.
1791         (tui_async_resize_screen): Print message if requested.
1792         (_initialize_tui_win): Add tui-resize-message setting.
1793         * NEWS: Add entry for new commands.
1794
1795 2019-11-11  Tom Tromey  <tom@tromey.com>
1796
1797         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1798         functions.
1799
1800 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1801
1802         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1803
1804 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1805
1806         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1807         function.
1808         * python/python-internal.h (gdbpy_lookup_static_symbols):
1809         Declare new function.
1810         * python/python.c (python_GdbMethods): Add
1811         gdb.lookup_static_symbols method.
1812         * NEWS: Mention gdb.lookup_static_symbols.
1813
1814 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1815
1816         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1817         static block of current object file first.  Also fix typo in
1818         header comment.
1819
1820 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1821
1822         * stack.c (set_last_displayed_sal): Delete.
1823         (last_displayed_sal_valid): Delete.
1824         (last_displayed_pspace): Delete.
1825         (last_displayed_addr): Delete.
1826         (last_displayed_symtab): Delete.
1827         (last_displayed_line): Delete.
1828         (class last_displayed_symtab_info_type): New.
1829         (last_displayed_symtab_info): New static global variable.
1830         (print_frame_info): Call methods on last_displayed_symtab_info.
1831         (clear_last_displayed_sal): Update header comment, and make use of
1832         last_displayed_symtab_info.
1833         (last_displayed_sal_is_valid): Likewise.
1834         (get_last_displayed_pspace): Likewise.
1835         (get_last_displayed_addr): Likewise.
1836         (get_last_displayed_symtab): Likewise.
1837         (get_last_displayed_line): Likewise.
1838         (get_last_displayed_sal): Likewise.
1839         * stack.h (clear_last_displayed_sal): Update header comment.
1840         (last_displayed_sal_is_valid): Likewise.
1841         (get_last_displayed_pspace): Likewise.
1842         (get_last_displayed_addr): Likewise.
1843         (get_last_displayed_symtab): Likewise.
1844         (get_last_displayed_line): Likewise.
1845         (get_last_displayed_sal): Likewise.
1846
1847 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1848
1849         * stack.c (frame_show_address): Convert return type to bool.
1850         * stack.h (frame_show_address): Likewise, and update header
1851         comment.
1852
1853 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1854
1855         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1856         * unittests/vec-utils-selftests.c: New file.
1857         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1858
1859 2019-11-10  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1862         (tui_highlight_win): Likewise.
1863         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1864         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1865         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1866         Don't set can_highlight.
1867
1868 2019-11-10  Tom Tromey  <tom@tromey.com>
1869
1870         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1871         Remove unused declaration.
1872
1873 2019-11-08  Tom Tromey  <tromey@adacore.com>
1874
1875         * top.c (read_command_file): Update.
1876         (command_line_input): Make return type const.
1877         * python/py-gdb-readline.c: Update.
1878         * linespec.c (decode_line_2): Update.
1879         * defs.h (command_line_input): Make return type const.
1880         * cli/cli-script.c (read_next_line): Make return type const.
1881         * ada-lang.c (get_selections): Update.
1882
1883 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1884
1885         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1886         * mi/mi-main.c (output_cores): Likewise.
1887         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1888         (linux_xfer_osdata_modules): Likewise.
1889         * remote.c (register_remote_support_xml): Likewise.
1890         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1891         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1892
1893 2019-11-06  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui-interp.c: Don't include readline.h.
1896         * tui/tui-hooks.c: Don't include readline.h.
1897         * symmisc.c: Include tilde.h, not readline.h.
1898         * symfile.c: Include tilde.h, not readline.h.
1899         * source.c: Include tilde.h, not readline.h.
1900         * solib.c: Include tilde.h, not readline.h.
1901         * psymtab.c: Include tilde.h, not readline.h.
1902         * exec.c: Include tilde.h, not readline.h.
1903         * corelow.c: Include tilde.h, not readline.h.
1904         * cli/cli-dump.c: Include tilde.h, not readline.h.
1905         * cli/cli-cmds.c: Don't include readline.h.
1906
1907 2019-11-05  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1910         (tui_disassemble): Set addr_size.
1911         (tui_disasm_window::set_contents): Use addr_size.
1912
1913 2019-11-05  Tom Tromey  <tom@tromey.com>
1914
1915         * rust-lang.c (rust_language_defn): Update.
1916         * python/py-value.c (valpy_string): Call c_get_string.
1917         * p-lang.c (pascal_language_defn): Update.
1918         * opencl-lang.c (opencl_language_defn): Update.
1919         * objc-lang.c (objc_language_defn): Update.
1920         * m2-lang.c (m2_language_defn): Update.
1921         * language.c (unknown_language_defn, auto_language_defn): Update.
1922         (default_get_string): Remove.
1923         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1924         * go-lang.c (go_language_defn): Update.
1925         * f-lang.c (f_language_defn): Update.
1926         * d-lang.c (d_language_defn): Update.
1927         * c-lang.c (c_language_defn, cplus_language_defn)
1928         (asm_language_defn, minimal_language_defn): Update.
1929         * ada-lang.c (ada_language_defn): Update.
1930         * language.h (struct language_defn) <la_get_string>: Remove.
1931         (LA_GET_STRING): Remove.
1932         (default_get_string): Don't declare.
1933
1934 2019-11-05  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-source.h (struct tui_source_window): Inline
1937         constructor.  Remove destructor.
1938         <style_changed, m_observable>: Move to superclass.
1939         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1940         (struct tui_source_window_base): Move private members to end.
1941         <style_changed, m_observable>: Move from tui_source_window.
1942         * tui/tui-winsource.c (tui_copy_source_line): Move from
1943         tui-source.c.  Rename from copy_source_line.  Add special handling
1944         for negative line number.
1945         (tui_source_window_base::style_changed): Move from
1946         tui_source_window.
1947         (tui_source_window_base): Register observer.
1948         (~tui_source_window_base): New.
1949         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1950         rename.
1951         (tui_source_window::set_contents): Use tui_copy_source_line.
1952         (tui_source_window::tui_source_window): Move to tui-source.h.
1953         (tui_source_window::~tui_source_window): Remove.
1954         (tui_source_window::style_changed): Move to superclass.
1955         * tui/tui-disasm.c (tui_disassemble): Create string file with
1956         styling, when possible.  Add "addr_size" parameter.
1957         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1958         Don't compute maximum size.
1959         (len_without_escapes): New function
1960
1961 2019-11-05  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1964         std::string.
1965         * tui/tui-winsource.c (tui_show_source_line): Update.
1966         * tui/tui-source.c (tui_source_window::set_contents): Update.
1967         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1968
1969 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1970
1971         * symtab.h (gdb_static_assert): Put && operator at the beginning
1972         of the line instead of the end.
1973
1974 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1975
1976         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1977         and sizeof (symbol).
1978         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1979
1980 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1981
1982         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1983         * configure.host: Mark *-*-solaris2.10* obsolete.
1984         * configure.tgt: Mark Solaris < 11 obsolete.
1985         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1986         Update target triplet.
1987
1988 2019-11-01  Tom Tromey  <tromey@adacore.com>
1989
1990         * utils.c (print_sys_errmsg): Simplify.
1991
1992 2019-11-01  Tom Tromey  <tromey@adacore.com>
1993
1994         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1995
1996 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1997
1998         * configure: Regenerate.
1999         * configure.ac: Remove check for strerror_r.
2000         * gdbsupport/common.m4: Check for strerror_r.
2001
2002 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2003
2004         PR gdb/25124
2005
2006         * arm-tdep.c (arm_per_objfile): Rename to ...
2007         (arm_per_bfd): ... this.
2008         (arm_objfile_data_key): Rename to ...
2009         (arm_bfd_data_key): ... this.
2010         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2011         data.
2012         (arm_record_special_symbol): Likewise.
2013
2014 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2015
2016         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2017         end.
2018         * c-typeprint.c (c_print_typedef): Likewise.
2019         * f-typeprint.c (f_print_typedef): Likewise.
2020         * m2-typeprint.c (m2_print_typedef): Likewise.
2021         * p-typeprint.c (pascal_print_typedef): Likewise.
2022         * rust-lang.c (rust_print_typedef): Likewise.
2023         * symtab.c (print_symbol_info): Print a newline after calling
2024         typedef_print.
2025
2026 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2027
2028         * symtab.c (info_module_cmdlist): New variable.
2029         (info_module_command): New function.
2030         (search_module_symbols): New function.
2031         (info_module_subcommand): New function.
2032         (struct info_modules_var_func_options): New struct.
2033         (info_modules_var_func_options_defs): New variable.
2034         (make_info_modules_var_func_options_def_group): New function.
2035         (info_module_functions_command): New function.
2036         (info_module_variables_command): New function.
2037         (info_module_var_func_command_completer): New function.
2038         (_initialize_symtab): Register new 'info module functions' and
2039         'info module variables' commands.
2040         * symtab.h (typedef symbol_search_in_module): New typedef.
2041         (search_module_symbols): Declare new function.
2042         * NEWS: Mention new commands.
2043
2044 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2045
2046         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2047         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2048         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2049         MODULES_DOMAIN.
2050         (scan_partial_symbols): Only create partial module symbols for non
2051         declarations.
2052         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2053         and MODULES_DOMAIN.
2054         * symtab.c (search_domain_name): Likewise.
2055         (search_symbols): Likewise.
2056         (print_symbol_info): Likewise.
2057         (symtab_symbol_info): Likewise.
2058         (info_modules_command): New function.
2059         (_initialize_symtab): Register 'info modules' command.
2060         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2061         * NEWS: Mention new 'info modules' command.
2062
2063 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2064
2065         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2066         and $_gdb_maint_setting_str.
2067
2068 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2069
2070         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2071         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2072         (str_value_from_setting, gdb_setting_str_internal_fn)
2073         (gdb_maint_setting_str_internal_fn): New functions.
2074         (_initialize_cli_cmds): Define the new convenience functions.
2075         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2076         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2077
2078 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2079
2080         * agent.c (set_can_use_agent): When the setting is turned on,
2081         look up agent symbols if we don't have them yet.
2082         (agent_new_objfile): Don't look up agent symbols when the agent
2083         setting is off.
2084
2085 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2086
2087         * config.in: Regenerate.
2088
2089 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2090
2091         * configure: Regenerate.
2092         * configure.ac: Check for strerror_r.
2093         * gdbsupport/common-utils.h (safe_strerror): Change return value
2094         to const char * and document that this function is now threadsafe.
2095         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2096         thread_local and call strerror_r, if available.
2097         * utils.c (perror_string): Update.
2098         (print_sys_errmsg): Update.
2099
2100 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2101
2102         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2103         objfile_key.
2104         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2105         objfile to fetch per-bfd data.
2106         (arm_find_exidx_entry): Likewise.
2107
2108 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2109
2110         * gdbsupport/agent.c (debug_agent): Change type to bool.
2111         (use_agent): Likewise.
2112         (all_agent_symbols_look_up): Likewise.
2113         (agent_loaded_p): Change return value to bool.
2114         (agent_look_up_symbols): Update.
2115         (agent_capability_check): Change return value to bool.
2116         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2117         (debug_agent): Change type to bool.
2118         (use_agent): Likewise.
2119         (agent_capability_check): Change return value to bool.
2120
2121 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2122
2123         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2124         (build_minimal_symbol_hash_tables): Code to clear the table moved
2125         to clear_minimal_symbol_hash_tables.
2126         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2127         when needed.
2128
2129 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2130
2131         * infcmd.c: Remove includes.
2132         * infrun.c: Remove includes.
2133
2134 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2135
2136         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2137         (grow_vect): Remove declaration.
2138         (ada_type_of_array): Remove declaration.
2139         (ada_update_initial_language): Remove declaration.
2140         (ada_fold_name): Remove declaration.
2141         (ada_fill_in_ada_prototype): Remove declaration.
2142         (user_select_syms): Remove declaration.
2143         (get_selections): Remove declaration.
2144         (ada_tag_type): Remove declaration.
2145         (ada_value_tag): Remove declaration.
2146         (ada_is_others_clause): Remove declaration.
2147         (ada_in_variant): Remove declaration.
2148         (ada_value_struct_elt): Remove declaration.
2149         (ada_attribute_name): Remove declaration.
2150         (ada_system_address_type): Remove declaration.
2151         * ada-lang.c (ada_watch_location_expression): Make static.
2152         (GROW_VECT): Move here from ada-lang.h.
2153         (grow_vect): Make static.
2154         (ada_update_initial_language): Make static.
2155         (ada_fold_name): Make static.
2156         (ada_type_of_array): Make static.
2157         (encoded_ordered_before): Move up.
2158         (sort_choices): Move up.
2159         (print_signatures): Move up.
2160         (ada_print_symbol_signature): Move up.
2161         (get_selections): Move up and make static.
2162         (user_select_syms): Move up and make static.
2163         (ada_value_struct_elt): Move up and make static.
2164         (ada_tag_type): Make static.
2165         (ada_value_tag): Make static.
2166         (ada_is_others_clause): Make static.
2167         (ada_in_variant): Make static.
2168         (ada_attribute_name): Make static.
2169
2170 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2171
2172         * ada-lang.c: Remove includes.
2173         * ada-typeprint.c: Remove includes.
2174         * ada-valprint.c: Remove includes.
2175
2176 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2177
2178         * addrmap.c: Add static assertions of type size, moved from
2179         _initialize_addrmap.
2180         (_initialize_addrmap): Remove.
2181
2182 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2183
2184         * coffread.c (record_minimal_symbol): Update.
2185         (process_coff_symbol): Update.
2186         * dbxread.c (read_dbx_symtab): Update.
2187         * dwarf2read.c (add_partial_symbol): Update.
2188         (fixup_go_packaging): Update.
2189         (load_partial_dies): Update.
2190         (new_symbol): Update.
2191         * elfread.c (record_minimal_symbol): Change signature to use
2192         gdb::string_view instead of name+len.
2193         (elf_symtab_read): Update.
2194         (elf_rel_plt_read): Update.
2195         * mdebugread.c (parse_partial_symbols): Update.
2196         (handle_psymbol_enumerators): Update.
2197         (new_symbol): Update.
2198         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2199         to use gdb::string_view instead of name+len.
2200         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2201         * psympriv.h (add_psymbol_to_list): Likewise.
2202         * psymtab.c (add_psymbol_to_bcache): Likewise.
2203         (add_psymbol_to_list): Likewise.
2204         * stabsread.c (define_symbol): Update.
2205         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2206         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2207         (symbol_set_names): Likewise.
2208         * xcoffread.c (scan_xcoff_symtab): Update.
2209
2210 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2211
2212         * symtab.h (symbol_set_names): Document that copy_name must be
2213         set to true for non-nullterminated strings.
2214         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2215         linkage_name if the entry was not found and we need to demangle.
2216
2217 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2218
2219         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2220         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2221         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2222         * gdbsupport/gdb_binary_search.h: New file.
2223
2224 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2225
2226         * NEWS: Mention new --with-system-gdbinit-dir option.
2227         * config.in: Regenerate.
2228         * configure: Regenerate.
2229         * configure.ac: Add new option --with-system-gdbinit-dir.
2230         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2231         for a ".gdb" suffix.
2232         * main.c (get_init_files): Change system_gdbinit argument to
2233         a vector and return the files in SYSTEM_GDBINIT_DIR in
2234         addition to SYSTEM_GDBINIT.
2235         (captured_main_1): Update.
2236         (print_gdb_help): Update.
2237         * top.c (print_gdb_configuration): Also print the value of
2238         SYSTEM_GDBINIT_DIR.
2239
2240 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2241
2242         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2243         that takes gdb::string_view arguments.
2244
2245 2019-10-26  Tom de Vries  <tdevries@suse.de>
2246
2247         * aarch64-linux-tdep.c: Fix typos in comments.
2248         * aarch64-tdep.c: Same.
2249         * ada-lang.c: Same.
2250         * amd64-nat.c: Same.
2251         * arc-tdep.c: Same.
2252         * arch/aarch64-insn.c: Same.
2253         * block.c: Same.
2254         * breakpoint.h: Same.
2255         * btrace.h: Same.
2256         * c-varobj.c: Same.
2257         * cli/cli-decode.c: Same.
2258         * cli/cli-script.c: Same.
2259         * cli/cli-utils.h: Same.
2260         * coff-pe-read.c: Same.
2261         * coffread.c: Same.
2262         * compile/compile-cplus-symbols.c: Same.
2263         * compile/compile-object-run.c: Same.
2264         * completer.c: Same.
2265         * corelow.c: Same.
2266         * cp-support.c: Same.
2267         * demangle.c: Same.
2268         * dwarf-index-write.c: Same.
2269         * dwarf2-frame.c: Same.
2270         * dwarf2-frame.h: Same.
2271         * eval.c: Same.
2272         * frame-base.h: Same.
2273         * frame.h: Same.
2274         * gdbcmd.h: Same.
2275         * gdbtypes.h: Same.
2276         * gnu-nat.c: Same.
2277         * guile/scm-objfile.c: Same.
2278         * i386-tdep.c: Same.
2279         * i386-tdep.h: Same.
2280         * infcall.c: Same.
2281         * infcall.h: Same.
2282         * linux-nat.c: Same.
2283         * m68k-tdep.c: Same.
2284         * macroexp.c: Same.
2285         * memattr.c: Same.
2286         * mi/mi-cmd-disas.c: Same.
2287         * mi/mi-getopt.h: Same.
2288         * mi/mi-main.c: Same.
2289         * minsyms.c: Same.
2290         * nat/aarch64-sve-linux-sigcontext.h: Same.
2291         * objfiles.h: Same.
2292         * ppc-linux-nat.c: Same.
2293         * ppc-linux-tdep.c: Same.
2294         * ppc-tdep.h: Same.
2295         * progspace.h: Same.
2296         * prologue-value.h: Same.
2297         * python/py-evtregistry.c: Same.
2298         * python/py-instruction.h: Same.
2299         * record-btrace.c: Same.
2300         * record-full.c: Same.
2301         * remote.c: Same.
2302         * rs6000-tdep.c: Same.
2303         * ser-tcp.c: Same.
2304         * sol-thread.c: Same.
2305         * sparc-sol2-tdep.c: Same.
2306         * sparc64-tdep.c: Same.
2307         * stabsread.c: Same.
2308         * symfile.c: Same.
2309         * symtab.h: Same.
2310         * target.c: Same.
2311         * tracepoint.c: Same.
2312         * tui/tui-data.h: Same.
2313         * tui/tui-io.c: Same.
2314         * tui/tui-win.c: Same.
2315         * tui/tui.c: Same.
2316         * unittests/rsp-low-selftests.c: Same.
2317         * user-regs.h: Same.
2318         * utils.c: Same.
2319         * utils.h: Same.
2320         * valarith.c: Same.
2321         * valops.c: Same.
2322         * valprint.c: Same.
2323         * valprint.h: Same.
2324         * value.c: Same.
2325         * value.h: Same.
2326         * varobj.c: Same.
2327         * x86-nat.h: Same.
2328         * xtensa-tdep.c: Same.
2329
2330 2019-10-25  Ali Tamur <tamur@google.com>
2331
2332         * charset.c (find_charset_names): Reflect API change.
2333
2334 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2335
2336         * symtab.c (struct demangled_name_entry): Change demangled name
2337         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2338         part of the struct anymore.
2339         (symbol_set_names): No longer obstack allocate + copy the demangled
2340         name, just store the allocated name from bfd.
2341
2342 2019-10-25  Tom Tromey  <tromey@adacore.com>
2343
2344         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2345         (bsearch_cie_cmp, add_cie): Remove.
2346         (find_cie): Reimplement.
2347         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2348         (dwarf2_build_frame_info): Update.
2349
2350 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2351
2352         PR gdb/25126
2353         * symfile.c (reread_symbols): Call forget_cached_source_info to
2354         clear the stale source cache.
2355
2356 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2357
2358         * configure: Regenerate.
2359         * configure.ac: Remove code that sets python_has_threads.
2360
2361 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2362
2363         * config.in: Regenerate.
2364         * configure: Regenerate.
2365         * configure.ac: Remove the code that uses sed to get the python
2366         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2367
2368 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2369
2370         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2371         error paths.
2372
2373 2019-10-23  Tom Tromey  <tom@tromey.com>
2374
2375         * arc-tdep.c: Remove ".." from include.
2376         * frv-tdep.c: Remove ".." from include.
2377         * lm32-tdep.c: Remove ".." from include.
2378         * microblaze-tdep.c: Remove ".." from include.
2379         * or1k-tdep.h: Remove ".." from include.
2380         * s12z-tdep.c: Remove ".." from include.
2381         * Makefile.in (OPCODES_CFLAGS): Add comment.
2382         (TOP_CFLAGS): New variable.
2383         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2384
2385 2019-10-23  Tom Tromey  <tom@tromey.com>
2386
2387         * Makefile.in (READLINE_DIR): Update.
2388
2389 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2390
2391         * infcall.c (call_function_by_hand_dummy): Fix the function
2392         comment.  And extract out a code section into...
2393         (reserve_stack_space): ...this new function.
2394
2395 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2396
2397         * infcall.c (value_arg_coerce): Remove an unused parameter.
2398         (call_function_by_hand_dummy): Update the call to
2399         'value_arg_coerce'.
2400
2401 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2402
2403         * infcall.c (call_function_by_hand_dummy): Refactor.
2404
2405 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2406
2407         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2408
2409 2019-10-23  Tom Tromey  <tom@tromey.com>
2410
2411         * configure: Rebuild.
2412         * configure.ac: Don't check for sigprocmask.
2413         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2414
2415 2019-10-23  Tom Tromey  <tom@tromey.com>
2416
2417         * configure: Rebuild.
2418         * acinclude.m4: Use m4_include, not sinclude.
2419
2420 2019-10-23  Tom de Vries  <tdevries@suse.de>
2421
2422         PR breakpoints/24687
2423         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2424
2425 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2426
2427         * symtab.c (struct demangled_name_entry) <language>: Change from
2428         bitfield to regular variable.
2429
2430 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2431
2432         * symtab.c (struct demangled_name_entry): Add a constructor.
2433         (free_demangled_name_entry): New function to call the destructor
2434         for demangled_name_entry.
2435         (create_demangled_names_hash): Pass free_demangled_name_entry to
2436         htab_create_alloc.
2437         (symbol_set_names): Call placement new for demangled_name_entry.
2438         * utils.c: No longer include xxhash.h here, now that fast_hash
2439         is inlined in the header.
2440         * utils.h: Instead, include it here.
2441
2442 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2443
2444         * Makefile.in: Link with libxxhash.
2445         * config.in: Regenerate.
2446         * configure: Regenerate.
2447         * configure.ac: Search for libxxhash.
2448         * utils.c (fast_hash): Use xxhash if present.
2449
2450 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2451
2452         * utils.h (fast_hash): New function.
2453         * symtab.c (hash_demangled_name_entry): Call new function
2454         fast_hash.
2455
2456 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2457
2458         * symtab.c (struct demangled_name_entry): Change type of mangled
2459         to gdb::string_view. Also adds a constructor that takes the
2460         mangled name.
2461         (hash_demangled_name_entry): Update.
2462         (eq_demangled_name_entry): Update.
2463         (free_demangled_name_entry): New function to call the destructor
2464         now that this is not a POD anymore.
2465         (create_demangled_names_hash): Pass free_demangled_name_entry to
2466         htab_create_alloc.
2467         (symbol_set_names): Update.
2468
2469 2019-10-21  Ali Tamur  <tamu@google.com>
2470
2471         * dwarf2read.c (dir_index): Change type.
2472         (file_name_index): Likewise.
2473         (line_header::include_dir_at): Change comment and implementation on
2474         whether it is DWARF 5.
2475         (line_header::is_valid_file_index): New function.
2476         (line_header::file_name_at): Change comment and implementation on
2477         whether it is DWARF 5.
2478         (line_header::file_names): Change to private field renamed as
2479         m_file_names and introduce a new accessor method.
2480         (line_header::file_names_size): New method.
2481         (line_header::include_dirs): Change to private field and rename as
2482         m_include_dirs.
2483         (dw2_get_file_names_reader): Define local var at a smaller scope and
2484         reflect API change.
2485         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2486         (process_structure_scope): Likewise.
2487         (line_header::add_include_dir): Change message and reflect renaming.
2488         (line_header::add_file_name): Likewise.
2489         (read_formatted_entries): Handle DW_FORM_data16.
2490         (dwarf_decode_line_header): Fix line header length calculation.
2491         (psymtab_include_file_name): Change comment and API.
2492         (lnp_state_machine::m_file): Update comment and reflect type change.
2493         (lnp_state_machine::record_line): Reflect type change.
2494         (dwarf_decode_lines): Reflect API change.
2495         (file_file_name): Likewise.
2496         (file_full_name): Likewise.
2497
2498 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2499
2500         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2501
2502 2019-10-21  Tom Tromey  <tom@tromey.com>
2503
2504         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2505
2506 2019-10-21  Tom Tromey  <tom@tromey.com>
2507
2508         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2509         NM_H.   Use AC_CONFIG_LINKS.
2510         * configure: Rebuild.
2511         * Makefile.in (NM_H): New variable.
2512         (generated_files): Add NM_H.  Remove gcore.
2513         (nm.h, stamp-nmh): New targets.
2514
2515 2019-10-20  Tom Tromey  <tom@tromey.com>
2516
2517         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2518         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2519         obsolete comment.
2520         (put_objfile_before): Now static.
2521
2522 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2523
2524         * gdbsupport/common-utils.h (startswith): Change return type to
2525         bool.
2526
2527 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2528
2529         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2530         * breakpoint.c (bp_locations_compare): Rename to...
2531         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2532         (update_global_location_list): Use std::sort instead of qsort.
2533         * buildsym.c (compare_line_numbers): Rename to...
2534         (lte_is_less_than): ...this, and change to std::sort semantics.
2535         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2536         instead of qsort.
2537         * disasm.c (compare_lines): Rename to...
2538         (line_is_less_than): ...this, and change to std::sort semantics.
2539         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2540         of qsort.
2541         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2542         (fde_is_less_than): ...this, and change to std::sort semantics.
2543         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2544         * mdebugread.c (compare_blocks):
2545         (block_is_less_than): ...this, and change to std::sort semantics.
2546         (sort_blocks): Call std::sort instead of qsort.
2547         * objfiles.c (qsort_cmp): Rename to...
2548         (sort_cmp): ...this, and change to std::sort semantics.
2549         (update_section_map): Call std::sort instead of qsort.
2550         * remote.c (compare_pnums): Remove.
2551         (map_regcache_remote_table): Call std::sort instead of qsort.
2552         * utils.c (compare_positive_ints): Remove.
2553         * utils.h (compare_positive_ints): Remove.
2554         * xcoffread.c (compare_lte): Remove.
2555         (arrange_linetable): Call std::sort instead of qsort.
2556
2557 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2558
2559         * symfile.c (init_entry_point_info): Fix typo.
2560         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2561
2562 2019-10-18  Tom de Vries  <tdevries@suse.de>
2563
2564         * aarch64-tdep.c: Fix typos in comments.
2565         * ada-lang.c: Same.
2566         * ada-tasks.c: Same.
2567         * alpha-tdep.c: Same.
2568         * alpha-tdep.h: Same.
2569         * amd64-nat.c: Same.
2570         * amd64-windows-tdep.c: Same.
2571         * arc-tdep.c: Same.
2572         * arc-tdep.h: Same.
2573         * arch-utils.c: Same.
2574         * arm-nbsd-tdep.c: Same.
2575         * arm-tdep.c: Same.
2576         * ax-gdb.c: Same.
2577         * blockframe.c: Same.
2578         * btrace.c: Same.
2579         * c-varobj.c: Same.
2580         * coff-pe-read.c: Same.
2581         * coffread.c: Same.
2582         * cris-tdep.c: Same.
2583         * darwin-nat.c: Same.
2584         * dbxread.c: Same.
2585         * dcache.c: Same.
2586         * disasm.c: Same.
2587         * dtrace-probe.c: Same.
2588         * dwarf-index-write.c: Same.
2589         * dwarf2-frame-tailcall.c: Same.
2590         * dwarf2-frame.c: Same.
2591         * dwarf2read.c: Same.
2592         * eval.c: Same.
2593         * exceptions.c: Same.
2594         * fbsd-tdep.c: Same.
2595         * findvar.c: Same.
2596         * frame.c: Same.
2597         * frv-tdep.c: Same.
2598         * gnu-v3-abi.c: Same.
2599         * go32-nat.c: Same.
2600         * h8300-tdep.c: Same.
2601         * hppa-tdep.c: Same.
2602         * i386-linux-tdep.c: Same.
2603         * i386-tdep.c: Same.
2604         * ia64-libunwind-tdep.c: Same.
2605         * ia64-tdep.c: Same.
2606         * infcmd.c: Same.
2607         * infrun.c: Same.
2608         * linespec.c: Same.
2609         * linux-nat.c: Same.
2610         * linux-thread-db.c: Same.
2611         * machoread.c: Same.
2612         * mdebugread.c: Same.
2613         * mep-tdep.c: Same.
2614         * mn10300-tdep.c: Same.
2615         * namespace.c: Same.
2616         * objfiles.c: Same.
2617         * opencl-lang.c: Same.
2618         * or1k-tdep.c: Same.
2619         * osabi.c: Same.
2620         * ppc-linux-nat.c: Same.
2621         * ppc-linux-tdep.c: Same.
2622         * ppc-sysv-tdep.c: Same.
2623         * printcmd.c: Same.
2624         * procfs.c: Same.
2625         * record-btrace.c: Same.
2626         * record-full.c: Same.
2627         * remote-fileio.c: Same.
2628         * remote.c: Same.
2629         * rs6000-tdep.c: Same.
2630         * s12z-tdep.c: Same.
2631         * score-tdep.c: Same.
2632         * ser-base.c: Same.
2633         * ser-go32.c: Same.
2634         * skip.c: Same.
2635         * sol-thread.c: Same.
2636         * solib-svr4.c: Same.
2637         * solib.c: Same.
2638         * source.c: Same.
2639         * sparc-nat.c: Same.
2640         * sparc-sol2-tdep.c: Same.
2641         * sparc-tdep.c: Same.
2642         * sparc64-tdep.c: Same.
2643         * stabsread.c: Same.
2644         * stack.c: Same.
2645         * symfile.c: Same.
2646         * symtab.c: Same.
2647         * target-descriptions.c: Same.
2648         * target-float.c: Same.
2649         * thread.c: Same.
2650         * utils.c: Same.
2651         * valops.c: Same.
2652         * valprint.c: Same.
2653         * value.c: Same.
2654         * varobj.c: Same.
2655         * windows-nat.c: Same.
2656         * xcoffread.c: Same.
2657         * xstormy16-tdep.c: Same.
2658         * xtensa-tdep.c: Same.
2659
2660 2019-10-17  Tom Tromey  <tromey@adacore.com>
2661
2662         * configure: Rebuild.
2663         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2664         in AC_CONFIG_FILES invocation.
2665         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2666         new-style config.status invocation.
2667
2668 2019-10-17  Tom de Vries  <tdevries@suse.de>
2669
2670         * arm-nbsd-nat.c: Fix typos in comments.
2671         * arm-tdep.c: Same.
2672         * darwin-nat-info.c: Same.
2673         * dwarf2read.c: Same.
2674         * elfread.c: Same.
2675         * event-top.c: Same.
2676         * findvar.c: Same.
2677         * gdbtypes.c: Same.
2678         * hppa-tdep.c: Same.
2679         * i386-tdep.c: Same.
2680         * jit.c: Same.
2681         * main.c: Same.
2682         * mdebugread.c: Same.
2683         * moxie-tdep.c: Same.
2684         * nto-procfs.c: Same.
2685         * osabi.c: Same.
2686         * ppc-linux-tdep.c: Same.
2687         * remote.c: Same.
2688         * riscv-tdep.c: Same.
2689         * s390-tdep.c: Same.
2690         * sh-tdep.c: Same.
2691         * sparc-linux-tdep.c: Same.
2692         * sparc-nat.c: Same.
2693         * stack.c: Same.
2694         * target-descriptions.c: Same.
2695         * top.c: Same.
2696         * varobj.c: Same.
2697
2698 2019-10-16  Tom Tromey  <tom@tromey.com>
2699
2700         * objfiles.h (struct objfile) <original_name>: Now const.
2701
2702 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2703
2704         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2705         pass on to sigsetjmp's second argument.
2706         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2707
2708 2019-10-16  Keith Seitz  <keiths@redhat.com>
2709
2710         PR gdb/23567
2711         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2712         sections whose size is greater than the file size.
2713
2714 2019-10-16  Jim Wilson  <jimw@sifive.com>
2715
2716         * riscv-tdep.c (riscv_gcc_target_options): New.
2717         (riscv_gnu_triplet_regexp): New.
2718         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2719         set_gdbarch_gnu_triplet_regexp.
2720
2721 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2722
2723         * Makefile.in: Add xml-builtin.h.
2724         * features/feature_to_c.sh: Add an include for xml-builtin.h
2725         to ensure that the compiler checks that the types match.
2726         * xml-builtin.h: New file.
2727         * xml-support.c (fetch_xml_builtin): Add missing const.
2728         * xml-support.h: Remove declaration of xml_builtins.
2729
2730 2019-10-16  Tom de Vries  <tdevries@suse.de>
2731
2732         PR tdep/25096
2733         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2734         (amd64_classify_aggregate): ... here.
2735         (amd64_classify_aggregate_field): Handled fiels of nested structs
2736         recursively.
2737
2738 2019-10-16  Tom de Vries  <tdevries@suse.de>
2739
2740         PR tdep/24104
2741         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2742         that handles 'theclass'.
2743
2744 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2745
2746         * linespec.c (decode_digits_ordinary): Update comment.
2747         * make-target-delegates: No longer need to handle VEC case.
2748         * memrange.c (normalize_mem_ranges): Update comment.
2749         * namespace.c (add_using_directive): Update comment.
2750         * objc-lang.c (uniquify_strings): Update comment.
2751         * ppc-linux-nat.c (struct thread_points): Update comment.
2752         * probe.h (find_probes_in_objfile): Update comment.
2753         * target.h (enum flash_preserve_mode): Update comment.
2754         * varobj.c (varobj_restrict_range): Update comment.
2755         * varobj.h (varobj_list_children): Update comment.
2756
2757 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2758
2759         * Makefile.in: Remove references to vec.h and vec.c.
2760         * aarch64-tdep.c: No longer include vec.h.
2761         * ada-lang.c: Likewise.
2762         * ada-lang.h: Likewise.
2763         * arm-tdep.c: Likewise.
2764         * ax.h: Likewise.
2765         * breakpoint.h: Likewise.
2766         * charset.c: Likewise.
2767         * cp-support.h: Likewise.
2768         * dtrace-probe.c: Likewise.
2769         * dwarf2read.c: Likewise.
2770         * extension.h: Likewise.
2771         * gdb_bfd.c: Likewise.
2772         * gdbsupport/gdb_vecs.h: Likewise.
2773         * gdbsupport/vec.c: Remove.
2774         * gdbsupport/vec.h: Remove.
2775         * gdbthread.h: Likewise.
2776         * guile/scm-type.c: Likewise.
2777         * inline-frame.c: Likewise.
2778         * machoread.c: Likewise.
2779         * memattr.c: Likewise.
2780         * memrange.h: Likewise.
2781         * namespace.h: Likewise.
2782         * nat/linux-btrace.h: Likewise.
2783         * osdata.c: Likewise.
2784         * parser-defs.h: Likewise.
2785         * progspace.h: Likewise.
2786         * python/py-type.c: Likewise.
2787         * record-btrace.c: Likewise.
2788         * rust-exp.y: Likewise.
2789         * solib-target.c: Likewise.
2790         * stap-probe.c: Likewise.
2791         * target-descriptions.c: Likewise.
2792         * target-memory.c: Likewise.
2793         * target.h: Likewise.
2794         * varobj.c: Likewise.
2795         * varobj.h: Likewise.
2796         * xml-support.h: Likewise.
2797
2798 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2799
2800         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2801         Update for new std::vector based implementation.
2802         (process_psymtab_comp_unit_reader): Likewise.
2803         (scan_partial_symbols): Likewise.
2804         (recursively_compute_inclusions): Likewise.
2805         (compute_compunit_symtab_includes): Likewise.
2806         (process_imported_unit_die): Likewise.
2807         (queue_and_load_dwo_tu): Likewise.
2808         (follow_die_sig_1): Likewise.
2809         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2810         (typedef dwarf2_per_cu_ptr): Remove.
2811         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2812         function.
2813         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2814         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2815         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2816         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2817         std::vector.
2818
2819 2019-10-15  Tom Tromey  <tromey@adacore.com>
2820
2821         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2822         TID.
2823
2824 2019-10-15  Tom Tromey  <tromey@adacore.com>
2825
2826         * windows-nat.c (windows_nat_target::fetch_registers)
2827         (windows_nat_target::store_registers): Rename "pid" to "tid".
2828
2829 2019-10-15  Tom Tromey  <tromey@adacore.com>
2830
2831         * gdbarch.h, gdbarch.c: Rebuild.
2832         * gdbarch.sh (gcc_target_options): Change return type to
2833         std::string.
2834         * compile/compile.c (get_args): Update.
2835         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2836         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2837         std::string.
2838         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2839         std::string.
2840         * arch-utils.c (default_gcc_target_options): Return std::string.
2841         * arch-utils.h (default_gcc_target_options): Return std::string.
2842         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2843
2844 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2845
2846         * breakpoint.c (breakpoint_chain): Make static.
2847         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2848         of accessing breakpoint_chain.
2849
2850 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2851
2852         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2853         to a gdb::function_view and return value to bool.
2854         * breakpoint.h (iterate_over_breakpoints): Likewise.
2855         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2856         (pop_dummy_frame): Update.
2857         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2858         (gdbscm_breakpoints): Update.
2859         * python/py-breakpoint.c (build_bp_list): Update.
2860         (gdbpy_breakpoints): Update.
2861         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2862         Update.
2863         (bpfinishpy_handle_stop): Update.
2864         (bpfinishpy_handle_exit): Update.
2865         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2866         (svr4_update_solib_event_breakpoints): Update.
2867
2868 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2869
2870         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2871         when unwrapping single-field structs.
2872
2873 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2874
2875         * dwarf2read.c: Remove includes.
2876
2877 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2878
2879         * ui-out.c (ui_out::call_do_message): Silence
2880         -Wformat-nonliteral warning.
2881
2882 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2883
2884         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2885         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2886         include: readline/tilde.h.
2887
2888 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2889
2890         * remote.c (remote_target::get_trace_status): Remove declaration of
2891         trace_regblock_size.
2892
2893 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2894
2895         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2896         (show_user): Remove declaration of cmdlist.
2897         * cli/cli-cmds.h (max_user_call_depth): Declare.
2898         * cli/cli-script.c (execute_user_command): Remove declaration
2899         of max_user_call_depth.
2900
2901 2019-10-11  Jim Wilson  <jimw@sifive.com>
2902
2903         * gdbsupport/print-utils.h (pulongest): Fix comment.
2904         (plongest): Likewise.
2905         (phex): Add missing comment, mention leading zeros.
2906         (phex_nz): Add mention of no leading zeros to comment.
2907
2908         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2909         plongest instead of unsigned long long cast.
2910
2911 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2912
2913         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2914         for external_editor_command and gdbtk_test.
2915
2916 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2917
2918         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2919         * varobj.c (varobjdebug): Move comment to...
2920         * varobj.h (varobjdebug): ...here, and declare.
2921
2922 2019-10-09  Tom Tromey  <tom@tromey.com>
2923
2924         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2925         erase_data_content.
2926
2927 2019-10-09  Tom Tromey  <tom@tromey.com>
2928
2929         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2930         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2931         * tui/tui-command.c (tui_cmd_window::resize)
2932         (tui_refresh_cmd_win): Update.
2933         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2934         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2935         * tui/tui-data.c (~tui_gen_win_info): Remove.
2936         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2937         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2938         (tui_redisplay_readline, tui_mld_flush)
2939         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2940         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2941         (tui_data_window::erase_data_content)
2942         (tui_data_item_window::rerender)
2943         (tui_data_item_window::refresh_window): Update.
2944         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2945         (box_win, tui_gen_win_info::make_window)
2946         (tui_gen_win_info::make_visible): Update.
2947         (tui_delete_win): Remove.
2948         * tui/tui-winsource.c
2949         (tui_source_window_base::do_erase_source_content): Update.
2950         (tui_show_source_line, tui_source_window_base::update_tab_width)
2951         (tui_source_window_base::update_exec_info): Update.
2952         * tui/tui-data.h (struct curses_deleter): New.
2953         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2954         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2955
2956 2019-10-09  Tom Tromey  <tom@tromey.com>
2957
2958         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2959
2960 2019-10-09  Tom Tromey  <tom@tromey.com>
2961
2962         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2963         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2964
2965 2019-10-09  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2968         window height directly.
2969         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2970         declare.
2971         * tui/tui-layout.c (tui_default_win_height): Remove.
2972         (tui_default_win_viewport_height): Remove.
2973
2974 2019-10-09  Tom Tromey  <tom@tromey.com>
2975
2976         * tui/tui.h: Remove comments.
2977
2978 2019-10-09  Tom de Vries  <tdevries@suse.de>
2979
2980         * python/lib/gdb/printer/bound_registers.py: Use
2981         '^builtin_type_bound128' as regexp argument for
2982         add_builtin_pretty_printer.
2983
2984 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2985
2986         * guile/guile.c (guile_extension_script_ops): Remove forward
2987         declaration and mark as static.
2988         (guile_script_ops): Likewise.
2989         (extension_language_guile): Move further down in the file so
2990         it can reference the definitions for guile_{extension_,}script_ops.
2991
2992 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2993
2994         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2995         except SORTL, DFLTCC, and KDSA.
2996
2997 2019-10-08  Tom Tromey  <tromey@adacore.com>
2998
2999         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3000         (struct safe_symbol_file_add_args): Remove.
3001
3002 2019-10-08  Tom Tromey  <tromey@adacore.com>
3003
3004         * windows-nat.c: Don't include buildsym-legacy.h.
3005
3006 2019-10-08  Tom Tromey  <tromey@adacore.com>
3007
3008         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3009
3010 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3011
3012         * gdbtypes.c (overload_debug): Move comment to header.
3013         * gdbtypes.h (overload_debug): Declare.
3014         * valops.c: Remove declaration of overload_debug, instead
3015         include gdbtypes.h.
3016
3017 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3018
3019         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3020         through _().
3021         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3022         move comment...
3023         * language.h (lang_frame_mismatch_warn): ... here. Also add
3024         declaration.
3025         * top.c (lang_frame_mismatch_warn): Remove declaration.
3026         (check_frame_language_change): Pass lang_frame_mismatch_warn
3027         through _().
3028
3029 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3030
3031         * c-lang.h (vtbl_ptr_name): Declare.
3032         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3033         it from the header.
3034         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3035
3036 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3037
3038         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3039         gdb_static_assert.
3040
3041 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3042
3043         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3044         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3045         * ctfread.c: New file.
3046         * ctfread.h: New file.
3047         * elfread.c: Include ctfread.h.
3048         (struct elfinfo text_p): New member ctfsect.
3049         (elf_locate_sections): Mark CTF section.
3050         (elf_symfile_read): Call elfctf_build_psymtabs.
3051         * Makefile.in (LIBCTF): Add.
3052         (CLIBS): Use it.
3053         (CDEPS): Likewise.
3054         (DIST): Add ctfread.c.
3055
3056 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3057
3058         * ctfread.c (struct nextfield): Renamed to ...
3059         (struct ctf_nextfield): ... this.
3060         (struct field_info): Renamed to ...
3061         (strut ctf_field_info): ... this.
3062         (attach_fields_to_type): Update for renamed structures.
3063         (ctf_add_member_cb): Likewise.
3064         (ctf_add_enum_member_cb): Likewise.
3065         (process_struct_members): Likewise.
3066         (process_enum_type): Likewise.
3067
3068 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3069
3070         * tracectf.h: Rename, was ctf.h.
3071         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3072         * tracefile.c: Likewise.
3073         * tracepoint.c: Remove unused include ctf.h.
3074         * mi/mi-main.c: Likewise.
3075         * Makefile.in Replace ctf.c with tracectf.c.
3076
3077 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3078
3079         * version.in: Change version number to "9.0.50.DATE-git".
3080
3081 2019-10-03  Tom Tromey  <tom@tromey.com>
3082
3083         PR rust/24976:
3084         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3085
3086 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3087
3088         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3089         cp_search_name_hash.
3090         * NEWS: Add entry about nested function support.
3091
3092 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3093             Andrew Burgess  <andrew.burgess@embecosm.com>
3094
3095         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3096         for nested static variables when searchin VAR_DOMAIN.
3097         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3098         global scope, update comment.
3099         (add_partial_subprogram): Call add_partial_subprogram recursively
3100         for nested subroutines when processinng Fortran.
3101         (load_partial_dies): Process the child entities of a subprogram
3102         when processing Fortran.
3103         (partial_die_parent_scope): Handle building scope
3104         for Fortran nested functions.
3105         (process_die): Record that nested functions have a scope.
3106         (new_symbol): Always record Fortran subprograms on the global
3107         symbol list.
3108         (determine_prefix): How to build the prefix for Fortran
3109         subprograms.
3110
3111 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3112
3113         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3114         have just sent the thread a SIGSTOP and are waiting for it to
3115         arrive.
3116
3117 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3118
3119         * btrace.c (btrace_add_pc): Remove whitespace before the template
3120         parameter in 'std::vector <...>'.
3121         (parse_xml_btrace_block): Likewise.
3122         (btrace_maint_decode_pt): Likewise.
3123         (btrace_maint_update_packets): Likewise.
3124         (btrace_maint_print_packets): Likewise.
3125         * btrace.h (struct btrace_maint_info): Likewise.
3126         * dwarf2read.c (struct type_unit_group): Likewise.
3127         (build_type_psymtabs_reader): Likewise.
3128         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3129         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3130         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3131
3132 2019-10-03  Tom de Vries  <tdevries@suse.de>
3133
3134         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3135         the first line of the help text for set/show style metadata.
3136
3137 2019-10-02  Tom Tromey  <tromey@adacore.com>
3138
3139         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3140         * gdbsupport/common-inferior.c: New file.
3141         * infcmd.c (startup_with_shell): Don't define.
3142         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3143         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3144         * inferior.h (startup_with_shell): Don't declare.
3145
3146 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3147
3148         * gdbsupport/gdb_assert.h: Include errors.h.
3149         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3150
3151 2019-10-02  Tom Tromey  <tromey@adacore.com>
3152
3153         * NEWS: Add $_ada_exception entry.
3154         * ada-lang.c (struct ada_catchpoint): Add constructor.
3155         <m_kind>: New member.
3156         (allocate_location_exception, re_set_exception): Remove
3157         "ex" parameter.
3158         (should_stop_exception): Compute $_ada_exception.
3159         (check_status_exception, print_it_exception)
3160         (print_one_exception, print_mention_exception): Remove
3161         "ex" parameter.
3162         (allocate_location_catch_exception, re_set_catch_exception)
3163         (check_status_exception, print_it_catch_exception)
3164         (print_one_catch_exception, print_mention_catch_exception)
3165         (print_recreate_catch_exception)
3166         (allocate_location_catch_exception_unhandled)
3167         (re_set_catch_exception_unhandled)
3168         (check_status_exception, print_it_catch_exception_unhandled)
3169         (print_one_catch_exception_unhandled)
3170         (print_mention_catch_exception_unhandled)
3171         (print_recreate_catch_exception_unhandled)
3172         (allocate_location_catch_assert, re_set_catch_assert)
3173         (check_status_assert, print_it_catch_assert)
3174         (print_one_catch_assert, print_mention_catch_assert)
3175         (print_recreate_catch_assert)
3176         (allocate_location_catch_handlers, re_set_catch_handlers)
3177         (check_status_handlers, print_it_catch_handlers)
3178         (print_one_catch_handlers, print_mention_catch_handlers)
3179         (print_recreate_catch_handlers): Remove.
3180         (create_ada_exception_catchpoint): Update.
3181         (initialize_ada_catchpoint_ops): Update.
3182
3183 2019-10-02  Tom Tromey  <tromey@adacore.com>
3184
3185         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3186         (create_excep_cond_exprs): Simplify exception string computation.
3187         (ada_exception_catchpoint_cond_string): Likewise.
3188
3189 2019-10-02  Tom Tromey  <tromey@adacore.com>
3190
3191         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3192         * ada-lang.c (lesseq_defined_than): Handle
3193         LOC_STATIC.
3194         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3195         parameter.
3196         (dwarf2_has_info): Likewise.
3197         (new_symbol): Set maybe_copied on symbol when
3198         appropriate.
3199         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3200         parameter.
3201         <can_copy>: New member.
3202         * elfread.c (record_minimal_symbol): Set maybe_copied
3203         on symbol when appropriate.
3204         (elf_symfile_read): Update call to dwarf2_has_info.
3205         * minsyms.c (lookup_minimal_symbol_linkage): New
3206         function.
3207         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3208         * symtab.c (get_symbol_address, get_msymbol_address):
3209         New functions.
3210         * symtab.h (get_symbol_address, get_msymbol_address):
3211         Declare.
3212         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3213         maybe_copied.
3214         (struct symbol, struct minimal_symbol) <maybe_copied>:
3215         New member.
3216
3217 2019-10-02  Tom Tromey  <tromey@adacore.com>
3218
3219         * source.c (struct current_source_location): New.
3220         (current_source_key): New global.
3221         (current_source_symtab, current_source_line)
3222         (current_source_pspace): Remove.
3223         (get_source_location): New function.
3224         (get_current_source_symtab_and_line)
3225         (set_default_source_symtab_and_line)
3226         (set_current_source_symtab_and_line)
3227         (clear_current_source_symtab_and_line, select_source_symtab)
3228         (info_source_command, print_source_lines_base)
3229         (info_line_command, search_command_helper, _initialize_source):
3230         Update.
3231
3232 2019-10-02  Tom Tromey  <tromey@adacore.com>
3233
3234         * source.c (select_source_symtab): Don't call
3235         decode_line_with_current_source.
3236
3237 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3238
3239         * symtab.c (lookup_global_symbol): Search global block.
3240
3241 2019-10-02  Tom Tromey  <tromey@adacore.com>
3242
3243         * coffread.c (process_coff_symbol): Update.
3244         * dwarf2read.c (var_decode_location, new_symbol): Update.
3245         * mdebugread.c (parse_symbol): Update.
3246         * objfiles.c (relocate_one_symbol): Update.
3247         * stabsread.c (define_symbol, fix_common_block)
3248         (scan_file_globals): Update.
3249         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3250         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3251         * xcoffread.c (process_xcoff_symbol): Update.
3252
3253 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3254
3255         * MAINTAINERS: Update my email address.
3256
3257 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3258
3259         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3260         std::vector.
3261         (build_type_psymtabs_reader): Update for std::vector.
3262         (build_type_psymtab_dependencies): Likewise.
3263         * dwarf2read.h: Remove use of DEF_VEC_P.
3264         (typedef sig_type_ptr): Delete.
3265
3266 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3267
3268         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3269         to std::vector.
3270         (btrace_maint_decode_pt): Likewise, and move allocation of the
3271         vector outside of the loop.
3272         (btrace_maint_update_packets): Update to handle change from VEC to
3273         std::vector.
3274         (btrace_maint_print_packets): Likewise.
3275         (maint_info_btrace_cmd): Likewise.
3276         * btrace.h: Remove use of DEF_VEC_O.
3277         (typedef btrace_pt_packet_s): Delete.
3278         (struct btrace_maint_info) <packets>: Change fromm VEC to
3279         std::vector.
3280         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3281
3282 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3283
3284         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3285         make accesses into the vector constant references.
3286         (btrace_add_pc): Update for std::vector.
3287         (btrace_stitch_bts): Likewise.
3288         (parse_xml_btrace_block): Likewise.
3289         (btrace_maint_update_packets): Likewise.
3290         (btrace_maint_print_packets): Likewise.
3291         (maint_info_btrace_cmd): Likewise.
3292         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3293         std::vector.
3294         (btrace_data::empty): Likewise.
3295         (btrace_data_append): Likewise.
3296         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3297         (typedef btrace_block_s): Delete.
3298         (struct btrace_block): Add constructor.
3299         (struct btrace_data_bts) <blocks>: Change to std::vector.
3300         * nat/linux-btrace.c (perf_event_read_bts): Update for
3301         std::vector.
3302         (linux_read_bts): Likewise.
3303
3304 2019-10-01  Tom Tromey  <tom@tromey.com>
3305
3306         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3307
3308 2019-10-01  Tom Tromey  <tom@tromey.com>
3309
3310         * stack.c (print_frame, info_frame_command_core): Use
3311         styled_string.
3312         * linux-thread-db.c (try_thread_db_load_1)
3313         (try_thread_db_load_from_pdir_1): Use styled_string.
3314         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3315         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3316         (maybe_print_unsupported_script_warning)
3317         (maybe_print_script_not_found_warning): Use styled_string.
3318         * ada-lang.c (user_select_syms): Use styled_string.
3319
3320 2019-10-01  Tom Tromey  <tom@tromey.com>
3321
3322         * p-lang.c (pascal_printstr): Use metadata style.
3323         * value.c (show_convenience): Use metadata style.
3324         * valprint.c (valprint_check_validity, val_print_optimized_out)
3325         (val_print_not_saved, val_print_unavailable)
3326         (val_print_invalid_address, generic_val_print, val_print)
3327         (value_check_printable, val_print_array_elements): Use metadata
3328         style.
3329         * ui-out.h (class ui_out) <field_fmt>: New overload.
3330         <do_field_fmt>: Add style parameter.
3331         * ui-out.c (ui_out::field_fmt): New overload.
3332         * typeprint.c (type_print_unknown_return_type)
3333         (val_print_not_allocated, val_print_not_associated): Use metadata
3334         style.
3335         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3336         parameter.
3337         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3338         * tracepoint.c (tvariables_info_1): Use metadata style.
3339         * stack.c (print_frame_arg, print_frame_info, print_frame)
3340         (info_frame_command_core): Use metadata style.
3341         * skip.c (info_skip_command): Use metadata style.
3342         * rust-lang.c (rust_print_enum): Use metadata style.
3343         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3344         metadata style.
3345         * python/py-framefilter.c (py_print_single_arg): Use metadata
3346         style.
3347         * printcmd.c (do_one_display, print_variable_and_value): Use
3348         metadata style.
3349         * p-valprint.c (pascal_val_print)
3350         (pascal_object_print_value_fields): Use metadata style.
3351         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3352         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3353         parameter.
3354         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3355         * m2-valprint.c (m2_print_long_set): Use metadata style.
3356         * m2-typeprint.c (m2_print_type): Use metadata style.
3357         * infcmd.c (print_return_value_1): Use metadata style.
3358         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3359         * f-valprint.c (info_common_command_for_block): Use metadata
3360         style.
3361         * f-typeprint.c (f_type_print_base): Use metadata style.
3362         * expprint.c (print_subexp_standard): Use metadata style.
3363         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3364         * cli/cli-style.h (class cli_style_option): Add constructor.
3365         (metadata_style): Declare.
3366         * cli/cli-style.c (metadata_style): New global.
3367         (_initialize_cli_style): Register metadata style.
3368         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3369         parameter.
3370         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3371         * c-typeprint.c (c_type_print_base_struct_union)
3372         (c_type_print_base_1): Use metadata style.
3373         * breakpoint.c (watchpoint_value_print)
3374         (print_one_breakpoint_location): Use metadata style.
3375         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3376         style.
3377         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3378         style.
3379         * ada-valprint.c (val_print_packed_array_elements, printstr)
3380         (print_field_values, ada_val_print_ref, ada_val_print): Use
3381         metadata style.
3382         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3383         style.
3384         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3385         style.
3386         * ada-lang.c (user_select_syms): Use metadata style.
3387
3388 2019-10-01  Tom Tromey  <tom@tromey.com>
3389
3390         * cli/cli-cmds.c (pwd_command): Style output.
3391
3392 2019-10-01  Pedro Alves  <palves@redhat.com>
3393             Tom Tromey  <tom@tromey.com>
3394
3395         * symtab.c (print_symbol_info): Use %ps.
3396         (print_msymbol_info): Use %ps.
3397         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3398         * printcmd.c (print_variable_and_value): Use %ps.
3399         * macrocmd.c (show_pp_source_pos): Use %ps.
3400         * infrun.c (print_exited_reason): Use ui_out::message.
3401         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3402         (describe_other_breakpoints): Use ui_out::message and new
3403         formats.
3404         (say_where): Use new formats.
3405         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3406         and new formats.
3407
3408 2019-10-01  Pedro Alves  <palves@redhat.com>
3409             Tom Tromey  <tom@tromey.com>
3410
3411         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3412         (test_gdb_formats): New function.
3413         (run_tests): Call it.
3414         (test_format_specifier): Update.
3415         * utils.h (fputs_filtered): Update comment.
3416         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3417         (fputs_styled_unfiltered): Declare.
3418         * utils.c (fputs_styled_unfiltered): New function.
3419         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3420         (vfprintf_filtered): Update.
3421         (vfprintf_unfiltered, vprintf_filtered): Update.
3422         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3423         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3424         disallow_ui_out_field>: New constants.
3425         (enum class field_kind): New.
3426         (struct base_field_s, struct signed_field_s): New.
3427         (signed_field): New function.
3428         (struct string_field_s): New.
3429         (string_field): New function.
3430         (struct styled_string_s): New.
3431         (styled_string): New function.
3432         (class ui_out) <message>: Add comment.
3433         <vmessage, call_do_message>: New methods.
3434         <do_message>: Add style parameter.
3435         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3436         methods.
3437         (ui_out::message): Rewrite.
3438         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3439         parameter.
3440         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3441         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3442         gdb_extensions parameter.
3443         (class format_piece): Add parameter to constructor.
3444         (n_int_args): New field.
3445         * gdbsupport/format.c (format_pieces::format_pieces): Add
3446         gdb_extensions parameter.  Handle '*'.
3447         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3448         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3449         vfprintf_styled_no_gdbfmt.
3450         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3451         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3452         unfiltered output.
3453         * ui-style.h (struct ui_file_style) <ptr>: New method.
3454
3455 2019-10-01  Tom Tromey  <tom@tromey.com>
3456
3457         * unittests/format_pieces-selftests.c: Update.  Add final format.
3458         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3459         empty literal pieces.
3460
3461 2019-10-01  Tom Tromey  <tom@tromey.com>
3462
3463         * ui-out.h (enum class ui_out_style_kind): Remove.
3464         (class ui_out) <field_string, field_stsream, do_field_string>:
3465         Change type of "style".
3466         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3467         (ui_out::field_string): Update.
3468         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3469         of "style".
3470         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3471         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3472         * stack.c (print_frame_arg, print_frame_info, print_frame):
3473         Update.
3474         * source.c (print_source_lines_base): Update.
3475         * solib.c (info_sharedlibrary_command): Update.
3476         * skip.c (info_skip_command): Update.
3477         * record-btrace.c (btrace_call_history_src_line)
3478         (btrace_call_history): Update.
3479         * python/py-framefilter.c (py_print_frame): Update.
3480         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3481         "style".
3482         * mi/mi-out.c (mi_ui_out::do_table_header)
3483         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3484         (mi_ui_out::do_field_string): Update.
3485         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3486         Update.
3487         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3488         "style".
3489         * cli-out.c (cli_ui_out::do_table_header)
3490         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3491         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3492         (cli_ui_out::do_field_fmt): Update.
3493         * breakpoint.c (print_breakpoint_location): Update.
3494         (update_static_tracepoint): Update.
3495
3496 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3497
3498         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3499         conversion of gdb_datadir.
3500         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3501         remove not needed c_str ().
3502
3503 2019-09-30  Ali Tamur <tamur@google.com>
3504
3505         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3506         (dwarf2_string_attr): Likewise.
3507
3508 2019-09-30  Ali Tamur <tamur@google.com>
3509
3510         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3511         (process_full_type_unit): Likewise.
3512         (dump_die_shallow): Likewise.
3513         (cu_debug_loc_section): Likewise.
3514
3515 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3516
3517         * minsyms.c (compare_minimal_symbols): Rename to...
3518         (minimal_symbol_is_less_than): ...this, and adjust to STL
3519         conventions (return bool, take arguments as references)
3520         (minimal_symbol_reader::install): Call std::sort instead
3521         of qsort.
3522
3523 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3524
3525         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3526         hash and why.
3527         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3528         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3529
3530 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3531
3532         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3533         * psympriv.h (add_psymbol_to_list): Move comment here and update
3534         it.
3535
3536 2019-09-29  Tom de Vries  <tdevries@suse.de>
3537
3538         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3539         Use $tmpdir/$(basename "$output_file").dwz instead of
3540         "${output_file}.dwz".
3541
3542 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3543
3544         PR gdb/25045
3545         * hppa-linux-nat.c: Include gdbarch.h.
3546
3547 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3548
3549         * blockframe.c (find_pc_partial_function): Change return type to bool.
3550         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3551         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3552         (stub_gnu_ifunc_resolve_name): Likewise.
3553         * symtab.c (compare_filenames_for_search): Likewise.
3554         (compare_glob_filenames_for_search): Likewise.
3555         (matching_obj_sections): Likewise.
3556         (symbol_matches_domain): Likewise.
3557         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3558         (find_line_pc): Change return type to bool.
3559         (find_line_pc_range): Likewise.
3560         (producer_is_realview): Likewise.
3561         * symtab.h (symbol_matches_domain): Likewise.
3562         (find_pc_partial_function): Likewise.
3563         (find_pc_line_pc_range): Likewise.
3564         (in_gnu_ifunc_stub): Likewise.
3565         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3566         (find_line_pc): Likewise.
3567         (find_line_pc_range): Likewise.
3568         (matching_obj_sections): Likewise.
3569         (find_line_symtab): Change out parameter to bool.
3570         (producer_is_realview): Change return type to bool.
3571         (compare_filenames_for_search): Likewise.
3572         (compare_glob_filenames_for_search): Likewise.
3573
3574 2019-09-26  Tom Tromey  <tom@tromey.com>
3575
3576         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3577         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3578         * gdb_usleep.h: Remove.
3579         * gdb_usleep.c: Remove.
3580         * utils.c: Don't include gdb_usleep.h.
3581
3582 2019-09-26  Tom Tromey  <tromey@adacore.com>
3583
3584         * python/py-type.c (type_to_type_object): Call check_typedef
3585         for stub types.
3586
3587 2019-09-26  Tom Tromey  <tom@tromey.com>
3588
3589         * utils.h (initialize_utils): Don't declare.
3590         * top.c (gdb_init): Don't call initialize_utils.
3591         * utils.c (initialize_utils): Remove.  Move contents...
3592         (_initialize_utils): ... here.
3593
3594 2019-09-25  Tom Tromey  <tom@tromey.com>
3595
3596         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3597         * utils.h (make_hex_string): Don't declare.
3598         * utils.c (make_hex_string): Remove.
3599
3600 2019-09-24  Tom de Vries  <tdevries@suse.de>
3601
3602         PR gdb/23815
3603         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3604         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3605
3606 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3607
3608         * NEWS: Mention new simulator port for PRU.
3609
3610 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3611
3612         * ada-exp.y (write_object_remaining): Update.
3613         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3614         and eliminate the static buffer.
3615         (ada_decode_symbol): Update.
3616         (ada_la_decode): Update.
3617         (ada_sniff_from_mangled_name): Update.
3618         (is_valid_name_for_wild_match): Update.
3619         (ada_lookup_name_info::matches): Update and simplify.
3620         (name_matches_regex): Update.
3621         (ada_add_global_exceptions): Update.
3622         * ada-lang.h (ada_decode): Update signature.
3623         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3624         * dwarf-index-write.c (debug_names::insert): Update.
3625
3626 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3627
3628         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3629         formatting.
3630
3631 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3632
3633         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3634         Change "nonzero" to "true" in documentation.
3635
3636 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3637
3638         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3639         (_initialize_darwin_solib): Don't set
3640         darwin_so_ops.lookup_lib_global_symbol.
3641         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3642         set_gdbarch_iterate_over_objfiles_in_search_order.
3643         (elf_lookup_lib_symbol): Rename to...
3644         (svr4_iterate_over_objfiles_in_search_order): this, and update
3645         to iterate semantics.
3646         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3647         * solib.c (solib_global_lookup): Remove.
3648         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3649         (solib_global_lookup): Remove.
3650         * symtab.c (lookup_global_or_static_symbol): Remove call to
3651         solib_global_lookup.
3652
3653 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3654
3655         * NEWS: Move entries about default MI version now being
3656         version 3, and about the GDB/MI fix for multi-location
3657         breakpoints to the "since GDB 8.3" section.
3658
3659 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3660
3661         GDB 8.3.1 released.
3662
3663 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3664
3665         * NEWS: Mention that Cell/B.E. debugging support was removed.
3666         * MAINTAINERS: Remove spu target.
3667
3668         * config/djgpp/fnchange.lst: Remove entries for removed files.
3669
3670         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3671         spu-multiarch.o, and spu-tdep.o.
3672         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3673         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3674         spu-multiarch.c, and spu-tdep.c.
3675         * spu-linux-nat.c: Remove file.
3676         * spu-multiarch.c: Remove file.
3677         * spu-tdep.c: Remove file.
3678         * spu-tdep.h: Remove file.
3679         * solib-spu.c: Remove file.
3680         * solib-spu.h: Remove file.
3681
3682         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3683         * configure.nat (spu-linux): Remove.
3684         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3685         solib-multiarch.o from gdb_target_obs.
3686         (spu*-*-*): Remove.
3687
3688         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3689         feature flag.
3690         (ppc_linux_no_features): Update.
3691         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3692         Cell/B.E. support.
3693         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3694         (tdesc_powerpc_cell64l): Likewise.
3695         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3696         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3697         Cell/B.E. support.
3698         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3699         Do not include "features/rs6000/powerpc-cell32l.c" or
3700         "features/rs6000/powerpc-cell64l.c".
3701         (ppc_linux_spu_section): Remove.
3702         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3703         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3704         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3705         (ppc_linux_spe_context_lookup): Remove.
3706         (ppc_linux_spe_context_inferior_created): Remove.
3707         (ppc_linux_spe_context_solib_loaded): Remove.
3708         (ppc_linux_spe_context_solib_unloaded): Remove.
3709         (ppc_linux_spe_context): Remove.
3710         (struct ppu2spu_cache): Remove.
3711         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3712         (struct ppu2spu_data): Remove.
3713         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3714         ppu2spu_unwind): Remove.
3715         (ppc_linux_init_abi): Remove Cell/B.E. support.
3716         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3717
3718         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3719         (rs6000/powerpc-cell64l-expedite): Likewise
3720         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3721         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3722         rs6000/powerpc-cell64l.xml.
3723         * features/rs6000/powerpc-cell32l.xml: Remove.
3724         * features/rs6000/powerpc-cell64l.xml: Likewise.
3725         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3726         * features/rs6000/powerpc-cell64l.c: Likewise.
3727         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3728         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3729         * regformats/reg-spu.dat: Remove.
3730
3731         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3732         * corelow.c (struct spuid_list): Remove.
3733         (add_to_spuid_list): Remove.
3734         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3735         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3736         (remote_protocol_features): Remove associated entries.
3737         (_initialize_remote): No longer initialize them.
3738         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3739         * linux-nat.c (SPUFS_MAGIC): Remove.
3740         (linux_proc_xfer_spu): Remove.
3741         (spu_enumerate_spu_ids): Remove.
3742         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3743         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3744         (linux_make_corefile_notes): No longer call it.
3745
3746         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3747         (cooked_write_test): Likewise.
3748
3749 2019-09-20  Tom Tromey  <tom@tromey.com>
3750
3751         * NEWS: Mention case-sensitivity of TUI commands.
3752         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3753         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3754         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3755
3756 2019-09-20  Tom Tromey  <tom@tromey.com>
3757
3758         * tui/tui-source.c (tui_source_window::set_contents): Use
3759         make_unique_xstrdup.
3760         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3761         make_unique_xstrdup.
3762
3763 2019-09-20  Tom Tromey  <tom@tromey.com>
3764
3765         * tui/tui-data.c: Remove separator comments.
3766         * tui/tui-layout.c: Remove separator comments.
3767         * tui/tui-win.c: Remove separator comments.
3768         * tui/tui-wingeneral.c: Remove separator comments.
3769
3770 2019-09-20  Tom Tromey  <tom@tromey.com>
3771
3772         * tui/tui.h (strcat_to_buf): Don't declare.
3773         * tui/tui.c (strcat_to_buf): Remove.
3774
3775 2019-09-20  Tom Tromey  <tom@tromey.com>
3776
3777         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3778         from "fullname".
3779         * tui/tui-source.c (tui_source_window::set_contents)
3780         (tui_source_window::location_matches_p)
3781         (tui_source_window::maybe_update): Update.
3782
3783 2019-09-20  Tom Tromey  <tom@tromey.com>
3784
3785         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3786         Update.
3787         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3788         prefix.
3789         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3790         (tui_data_window::line_from_reg_element_no)
3791         (tui_data_window::first_reg_element_no_inline)
3792         (tui_data_window::show_registers)
3793         (tui_data_window::show_register_group)
3794         (tui_data_window::display_registers_from)
3795         (tui_data_window::display_registers_from_line)
3796         (tui_data_window::first_data_item_displayed)
3797         (tui_data_window::delete_data_content_windows)
3798         (tui_data_window::erase_data_content)
3799         (tui_data_window::do_scroll_vertical)
3800         (tui_data_window::refresh_window)
3801         (tui_data_window::check_register_values): Update.
3802
3803 2019-09-20  Tom Tromey  <tom@tromey.com>
3804
3805         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3806         (struct tui_locator_window) <full_name, proc_name>: Now
3807         std::string.
3808         * tui/tui-stack.c (tui_locator_window::make_status_line)
3809         (tui_locator_window::set_locator_fullname)
3810         (tui_locator_window::set_locator_info): Update.
3811         * tui/tui-source.c (tui_source_window::set_contents)
3812         (tui_source_window::showing_source_p): Update.
3813
3814 2019-09-20  Tom Tromey  <tom@tromey.com>
3815
3816         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3817         Don't call tui_locator_win_info_ptr.
3818
3819 2019-09-20  Tom Tromey  <tom@tromey.com>
3820
3821         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3822
3823 2019-09-20  Tom Tromey  <tom@tromey.com>
3824
3825         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3826         height for locator.
3827         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3828         * tui/tui-layout.c (show_source_disasm_command, show_data)
3829         (show_source_or_disasm_and_command): Use 1 as height for locator.
3830
3831 2019-09-20  Tom Tromey  <tom@tromey.com>
3832
3833         * tui/tui.c (tui_enable): Update.
3834         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3835         Update.
3836         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3837         Update.
3838         * tui/tui-data.c (win_resized): Now bool.
3839         (tui_win_resized): Return bool.
3840         (tui_set_win_resized_to): Accept a bool.
3841
3842 2019-09-20  Tom Tromey  <tom@tromey.com>
3843
3844         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3845         Change type of "refresh_values_only".
3846         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3847         type of "refresh_values_only".
3848
3849 2019-09-20  Tom Tromey  <tom@tromey.com>
3850
3851         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3852         std::string.
3853         (tui_disassemble): Add "pos" parameter.
3854         (tui_disasm_window::set_contents): Simplify.
3855
3856 2019-09-20  Tom Tromey  <tom@tromey.com>
3857
3858         * tui/tui-winsource.h (struct tui_source_window_base)
3859         <show_source_content>: Now private.
3860         * tui/tui-winsource.c
3861         (tui_source_window_base::show_source_content): Don't handle empty
3862         content case.
3863
3864 2019-09-20  Tom Tromey  <tom@tromey.com>
3865
3866         * tui/tui-layout.c (show_source_disasm_command)
3867         (show_source_or_disasm_and_command): Don't call
3868         show_source_content.
3869
3870 2019-09-20  Tom Tromey  <tom@tromey.com>
3871
3872         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3873         Declare.
3874         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3875         from tui_make_status_line.
3876         (tui_locator_window::rerender): Update.
3877
3878 2019-09-20  Tom Tromey  <tom@tromey.com>
3879
3880         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3881         (tui_locator_window::rerender): Update.
3882
3883 2019-09-20  Tom Tromey  <tom@tromey.com>
3884
3885         * tui/tui-winsource.h (struct tui_source_window_base)
3886         <~tui_source_window_base>: Don't declare.
3887         <fullname>: Remove.
3888         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3889         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3890         member.
3891         * tui/tui-source.c (tui_source_window::set_contents): Update.
3892         (tui_source_window::location_matches_p)
3893         (tui_source_window::maybe_update): Update.
3894
3895 2019-09-20  Tom Tromey  <tom@tromey.com>
3896
3897         * tui/tui-winsource.h (~tui_source_element): Remove.
3898         (tui_source_element): Update.
3899         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3900         * tui/tui-winsource.c (tui_show_source_line): Update.
3901         * tui/tui-source.c (tui_source_window::set_contents): Update.
3902         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3903
3904 2019-09-20  Tom Tromey  <tom@tromey.com>
3905
3906         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3907         declare.
3908         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3909         tui_clear_source_windows_detail.
3910         * tui/tui-winsource.h (struct tui_source_window_base)
3911         <clear_detail>: Don't declare.
3912         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3913         Remove.
3914         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3915
3916 2019-09-20  Tom Tromey  <tromey@adacore.com>
3917
3918         PR ada/24919:
3919         * block.c (contained_in): Fix final return value.
3920
3921 2019-09-20  Alan Modra  <amodra@gmail.com>
3922
3923         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3924         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3925         (read_indirect_string_from_dwz): Use bfd accessor.
3926         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3927         * machoread.c (macho_symfile_read_all_oso): Likewise.
3928         * solib.c (solib_bfd_open): Likewise.
3929
3930 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3931
3932         * eval.c: Move declaration of overload_resolution to...
3933         * value.h: ...here.
3934
3935 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3936
3937         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3938         * arm-linux-tdep.c: Likewise.
3939         * arm-nbsd-nat.c: Likewise.
3940         * arm-tdep.h: Declare arm_apcs_32.
3941         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3942
3943 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3944
3945         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3946         * dwarf2read.h: Declare dwarf_always_disassemble.
3947
3948 2019-09-19  Tom de Vries  <tdevries@suse.de>
3949
3950         PR gdb/25009
3951         * source-cache.c (source_cache::ensure): Catch exception thrown during
3952         construction of the highlighter.
3953
3954 2019-09-18  Alan Modra  <amodra@gmail.com>
3955
3956         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3957         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3958         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3959         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3960         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3961         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3962         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3963         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3964         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3965         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3966         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3967         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3968         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3969         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3970         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3971         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3972         * mi/mi-interp.c: Update throughout for bfd section macro and
3973         function changes.
3974         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3975         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3976
3977 2019-09-18  Tom Tromey  <tom@tromey.com>
3978
3979         * NEWS: Add entry.
3980         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3981         call rl_initialize.
3982         (tui_enable): Do not call rl_initialize.
3983
3984 2019-09-18  Christian Groessler  <chris@groessler.org>
3985
3986         * alpha-linux-nat.c: Include gdbarch.h.
3987
3988 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3989
3990         * ui-file.c: Include cli/cli-style.h.
3991         (term_cli_styling): Remove cli_styling declaration.
3992
3993 2019-09-18  Alan Modra  <amodra@gmail.com>
3994
3995         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3996         to bfd_asymbol_section.
3997
3998 2019-09-18  Alan Modra  <amodra@gmail.com>
3999
4000         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4001         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4002         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4003
4004 2019-09-18  Alan Modra  <amodra@gmail.com>
4005
4006         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4007         * spu-linux-nat.c (spu_bfd_open): Likewise.
4008
4009 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4010
4011         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4012         to bool to match definition in dwarf2read.c.
4013
4014 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4015
4016         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4017         (print_signatures): Likewise.
4018         (trust_pad_over_xvs): Likewise.
4019         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4020         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4021         * arm-linux-nat.c (arm_apcs_32): Likewise.
4022         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4023         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4024         * arm-tdep.c (arm_debug): Likewise.
4025         (arm_apcs_32): Likewise.
4026         * auto-load.c (debug_auto_load): Likewise.
4027         (auto_load_gdb_scripts): Likewise.
4028         (global_auto_load): Likewise.
4029         (auto_load_local_gdbinit): Likewise.
4030         (auto_load_local_gdbinit_loaded): Likewise.
4031         * auto-load.h (global_auto_load): Likewise.
4032         (auto_load_local_gdbinit): Likewise.
4033         (auto_load_local_gdbinit_loaded): Likewise.
4034         * breakpoint.c (disconnected_dprintf): Likewise.
4035         (breakpoint_proceeded): Likewise.
4036         (automatic_hardware_breakpoints): Likewise.
4037         (always_inserted_mode): Likewise.
4038         (target_exact_watchpoints): Likewise.
4039         (_initialize_breakpoint): Update.
4040         * breakpoint.h (target_exact_watchpoints): Change to bool.
4041         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4042         * cli/cli-cmds.c (trace_commands): Likewise.
4043         * cli/cli-cmds.h (trace_commands): Likewise.
4044         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4045         to bool*.
4046         * cli/cli-logging.c (logging_overwrite): Change to bool.
4047         (logging_redirect): Likewise.
4048         (debug_redirect): Likewise.
4049         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4050         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4051         to bool.
4052         <boolean_option_def>: Update.
4053         (struct flag_option_def): Change default type of Context to bool
4054         from int.
4055         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4056         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4057         (get_setshow_command_value_string): Likewise.
4058         * cli/cli-style.c (cli_styling): Change to bool.
4059         (source_styling): Likewise.
4060         * cli/cli-style.h (source_styling): Likewise.
4061         (cli_styling): Likewise.
4062         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4063         to bool.
4064         * command.h (var_types): Update comment.
4065         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4066         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4067         bool.
4068         (debug_compile_cplus_scopes): Likewise.
4069         * compile/compile-internal.h (compile_debug): Likewise.
4070         * compile/compile.c (compile_debug): Likewise.
4071         (struct compile_options) <raw>: Likewise.
4072         * cp-support.c (catch_demangler_crashes): Likewise.
4073         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4074         (usr_cmd_cris_dwarf2_cfi): Likewise.
4075         * csky-tdep.c (csky_debug): Likewise.
4076         * darwin-nat.c (enable_mach_exceptions): Likewise.
4077         * dcache.c (dcache_enabled_p): Likewise.
4078         * defs.h (info_verbose): Likewise.
4079         * demangle.c (demangle): Likewise.
4080         (asm_demangle): Likewise.
4081         * dwarf-index-cache.c (debug_index_cache): Likewise.
4082         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4083         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4084         * dwarf2read.c (check_physname): Likewise.
4085         (use_deprecated_index_sections): Likewise.
4086         (dwarf_always_disassemble): Likewise.
4087         * eval.c (overload_resolution): Likewise.
4088         * event-top.c (set_editing_cmd_var): Likewise.
4089         (exec_done_display_p): Likewise.
4090         * event-top.h (set_editing_cmd_var): Likewise.
4091         (exec_done_display_p): Likewise.
4092         * exec.c (write_files): Likewise.
4093         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4094         (debug_fbsd_nat): Likewise.
4095         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4096         Likewise.
4097         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4098         <backtrace_past_entry> Likewise.
4099         * gdb-demangle.h (demangle): Likewise.
4100         (asm_demangle): Likewise.
4101         * gdb_bfd.c (bfd_sharing): Likewise.
4102         * gdbcore.h (write_files): Likewise.
4103         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4104         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4105         * gdbthread.h (print_thread_events): Likewise.
4106         * gdbtypes.c (opaque_type_resolution): Likewise.
4107         (strict_type_checking): Likewise.
4108         * gnu-nat.c (gnu_debug_flag): Likewise.
4109         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4110         * guile/scm-param.c (pascm_variable): Add boolval.
4111         (add_setshow_generic): Update.
4112         (pascm_param_value): Update.
4113         (pascm_set_param_value_x): Update.
4114         * hppa-tdep.c (hppa_debug): Change to bool..
4115         * infcall.c (may_call_functions_p): Likewise.
4116         (coerce_float_to_double_p): Likewise.
4117         (unwind_on_signal_p): Likewise.
4118         (unwind_on_terminating_exception_p): Likewise.
4119         * infcmd.c (startup_with_shell): Likewise.
4120         * inferior.c (print_inferior_events): Likewise.
4121         * inferior.h (startup_with_shell): Likewise.
4122         (print_inferior_events): Likewise.
4123         * infrun.c (step_stop_if_no_debug): Likewise.
4124         (detach_fork): Likewise.
4125         (debug_displaced): Likewise.
4126         (disable_randomization): Likewise.
4127         (non_stop): Likewise.
4128         (non_stop_1): Likewise.
4129         (observer_mode): Likewise.
4130         (observer_mode_1): Likewise.
4131         (set_observer_mode): Update.
4132         (sched_multi): Change to bool.
4133         * infrun.h (debug_displaced): Likewise.
4134         (sched_multi): Likewise.
4135         (step_stop_if_no_debug): Likewise.
4136         (non_stop): Likewise.
4137         (disable_randomization): Likewise.
4138         * linux-tdep.c (use_coredump_filter): Likewise.
4139         (dump_excluded_mappings): Likewise.
4140         * linux-thread-db.c (auto_load_thread_db): Likewise.
4141         (check_thread_db_on_load): Likewise.
4142         * main.c (captured_main_1): Update.
4143         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4144         xx2_opt, boolean_opt>: Change to bool.
4145         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4146         * maint.c (maintenance_profile_p): Likewise.
4147         (per_command_time): Likewise.
4148         (per_command_space): Likewise.
4149         (per_command_symtab): Likewise.
4150         * memattr.c (inaccessible_by_default): Likewise.
4151         * mi/mi-main.c (mi_async): Likewise.
4152         (mi_async_1): Likewise.
4153         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4154         * nat/fork-inferior.h (startup_with_shell): Likewise.
4155         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4156         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4157         * nios2-tdep.c (nios2_debug): Likewise.
4158         * or1k-tdep.c (or1k_debug): Likewise.
4159         * parse.c (parser_debug): Likewise.
4160         * parser-defs.h (parser_debug): Likewise.
4161         * printcmd.c (print_symbol_filename): Likewise.
4162         * proc-api.c (procfs_trace): Likewise.
4163         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4164         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4165         (set_parameter_value): Update.
4166         (add_setshow_generic): Update.
4167         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4168         to bool*.
4169         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4170         int*.
4171         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4172         * record-btrace.c (record_btrace_target::store_registers): Update.
4173         * record-full.c (record_full_memory_query): Change to bool.
4174         (record_full_stop_at_limit): Likewise.
4175         * record-full.h (record_full_memory_query): Likewise.
4176         * remote-notif.c (notif_debug): Likewise.
4177         * remote-notif.h (notif_debug): Likewise.
4178         * remote.c (use_range_stepping): Likewise.
4179         (interrupt_on_connect): Likewise.
4180         (remote_break): Likewise.
4181         * ser-tcp.c (tcp_auto_retry): Likewise.
4182         * ser-unix.c (serial_hwflow): Likewise.
4183         * skip.c (debug_skip): Likewise.
4184         * solib-aix.c (solib_aix_debug): Likewise.
4185         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4186         (spu_auto_flush_cache_p): Likewise.
4187         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4188         Likewise.
4189         (struct info_print_options) <quiet>: Likewise.
4190         * symfile-debug.c (debug_symfile): Likewise.
4191         * symfile.c (auto_solib_add): Likewise.
4192         (separate_debug_file_debug): Likewise.
4193         * symfile.h (auto_solib_add): Likewise.
4194         (separate_debug_file_debug): Likewise.
4195         * symtab.c (basenames_may_differ): Likewise.
4196         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4197         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4198         (struct info_types_options) <quiet>: Likewise.
4199         * symtab.h (demangle): Likewise.
4200         (basenames_may_differ): Likewise.
4201         * target-dcache.c (stack_cache_enabled_1): Likewise.
4202         (code_cache_enabled_1): Likewise.
4203         * target.c (trust_readonly): Likewise.
4204         (may_write_registers): Likewise.
4205         (may_write_memory): Likewise.
4206         (may_insert_breakpoints): Likewise.
4207         (may_insert_tracepoints): Likewise.
4208         (may_insert_fast_tracepoints): Likewise.
4209         (may_stop): Likewise.
4210         (auto_connect_native_target): Likewise.
4211         (target_stop_and_wait): Update.
4212         (target_async_permitted): Change to bool.
4213         (target_async_permitted_1): Likewise.
4214         (may_write_registers_1): Likewise.
4215         (may_write_memory_1): Likewise.
4216         (may_insert_breakpoints_1): Likewise.
4217         (may_insert_tracepoints_1): Likewise.
4218         (may_insert_fast_tracepoints_1): Likewise.
4219         (may_stop_1): Likewise.
4220         * target.h (target_async_permitted): Likewise.
4221         (may_write_registers): Likewise.
4222         (may_write_memory): Likewise.
4223         (may_insert_breakpoints): Likewise.
4224         (may_insert_tracepoints): Likewise.
4225         (may_insert_fast_tracepoints): Likewise.
4226         (may_stop): Likewise.
4227         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4228         (make_thread_apply_all_options_def_group): Change argument from int*
4229         to bool*.
4230         (thread_apply_all_command): Update.
4231         (print_thread_events): Change to bool.
4232         * top.c (confirm): Likewise.
4233         (command_editing_p): Likewise.
4234         (history_expansion_p): Likewise.
4235         (write_history_p): Likewise.
4236         (info_verbose): Likewise.
4237         * top.h (confirm): Likewise.
4238         (history_expansion_p): Likewise.
4239         * tracepoint.c (disconnected_tracing): Likewise.
4240         (circular_trace_buffer): Likewise.
4241         * typeprint.c (print_methods): Likewise.
4242         (print_typedefs): Likewise.
4243         * utils.c (debug_timestamp): Likewise.
4244         (sevenbit_strings): Likewise.
4245         (pagination_enabled): Likewise.
4246         * utils.h (sevenbit_strings): Likewise.
4247         (pagination_enabled): Likewise.
4248         * valops.c (overload_resolution): Likewise.
4249         * valprint.h (struct value_print_options) <prettyformat_arrays,
4250         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4251         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4252         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4253         Likewise.
4254         * windows-nat.c (new_console): Likewise.
4255         (cygwin_exceptions): Likewise.
4256         (new_group): Likewise.
4257         (debug_exec): Likewise.
4258         (debug_events): Likewise.
4259         (debug_memory): Likewise.
4260         (debug_exceptions): Likewise.
4261         (useshell): Likewise.
4262         * windows-tdep.c (maint_display_all_tib): Likewise.
4263         * xml-support.c (debug_xml): Likewise.
4264
4265 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4266
4267         * source.c (prepare_path_for_appending): New function.
4268         (openp): Make use of new function.
4269         (find_and_open_source): Search for the compilation directory and
4270         source file as a relative path beneath the directory search path.
4271
4272 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4273
4274         * source-cache.c (source_cache::get_line_charpos): Catch
4275         exceptions and return false, this matches the behaviour documented
4276         in the header file.
4277
4278 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4279
4280         * ada-tasks.c (info_task): Remove quoting of the task's name.
4281
4282 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4283
4284         * symfile.c (auto_solib_add): Replace comment with a reference
4285         to the header file.
4286
4287 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4288
4289         * NEWS: Mention that gdb can now be compiled with Python 3
4290         on Windows.
4291
4292 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4293
4294         * maint.c (maint_print_section_data::maint_print_section_data):
4295         Force use of 'float log10 (float)' by casting the argument to
4296         float.
4297
4298 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4299
4300         * maint.c: Add 'cmath' include.
4301         (struct maint_print_section_data): New structure.
4302         (print_section_index): New function.
4303         (print_bfd_section_info): Add header comment, small whitespace
4304         cleanup, and update to call new print_section_index function.
4305         (print_objfile_section_info): Likewise.
4306         (maint_obj_section_from_bfd_section): New function.
4307         (print_bfd_section_info_maybe_relocated): New function.
4308         (maintenance_info_sections): Add header comment, always use
4309         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4310
4311 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4312
4313         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4314         inner scope, add check that the objfile has psymtabs before
4315         checking psymtabs_addrmap.
4316         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4317
4318 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4319
4320         * NEWS: Announce that Ada task names are now shown at more places,
4321         and between quotes (except in info task output).
4322         * gdb/ada-tasks.c (task_to_str): New function.
4323         (display_current_task_id): Call task_to_str.
4324         (task_command_1): Likewise.
4325         (print_ada_task_info): In non-mi mode, Properly align headers and data
4326         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4327
4328 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4329
4330         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4331         prstatus.pr_lwp.pr_info instead of making it up.
4332
4333 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4334
4335         * auto-load.c (auto_load_expand_dir_vars): Update.
4336         * defs.h (gdb_datadir): Change to std::string.
4337         (python_libdir): Likewise.
4338         (relocate_gdb_directory): Change return type to std::string.
4339         * guile/guile.c (gdbscm_data_directory): Update.
4340         (initialize_scheme_side): Update.
4341         * jit.c (jit_reader_dir): Change to std::string.
4342         (jit_reader_load_command): Update.
4343         * main.c (gdb_datadir): Change to std::string.
4344         (python_libdir): Likewise.
4345         (set_gdb_data_directory): Update.
4346         (relocate_path): Change to return std::string.
4347         (relocate_gdb_directory): Change to return std::string.
4348         (relocate_gdbinit_path_maybe_in_datadir): Update.
4349         (captured_main_1): Update.
4350         * python/python.c (do_start_initialization): Update.
4351         * top.c (show_gdb_datadir): Update.
4352         * xml-syscall.c (xml_init_syscalls_info): Update.
4353         (init_syscalls_info): Update.
4354
4355 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4356
4357         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4358         out of get_init_files.
4359         (get_init_files): Update.
4360
4361 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4362
4363         * main.c (get_init_files): Change to use std::string.
4364         (captured_main_1): Update.
4365         (print_gdb_help): Update.
4366
4367 2019-09-11  Ali Tamur  <tamur@google.com>
4368
4369         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4370         implementation.
4371
4372 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4373
4374         * dbxread.c (read_dbx_symtab): Update.
4375         * dwarf2read.c (load_partial_dies): Update.
4376         * mdebugread.c (parse_partial_symbols): Update.
4377         (handle_psymbol_enumerators): Update.
4378         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4379         * psymtab.c (add_psymbol_to_bcache): Likewise.
4380         (add_psymbol_to_list): Likewise.
4381         * symtab.c (symbol_set_names): Likewise.
4382         * symtab.h (symbol_set_names): Likewise.
4383         * xcoffread.c (scan_xcoff_symtab): Update.
4384
4385 2019-09-11  Tom Tromey  <tom@tromey.com>
4386
4387         * symfile-mem.c (symbol_file_add_from_memory): Use
4388         bfd_set_filename.
4389         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4390         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4391
4392 2019-09-10  Tom Tromey  <tromey@adacore.com>
4393
4394         * dwarf-index-write.c (write_psymbols): Extend error message.
4395         (debug_names::insert): Add Ada code.
4396         (debug_names::write_psymbols): Remove Ada check.
4397         (debug_names) <m_string_obstack>: New member.
4398         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4399         (gdb_index_symbol_name_matcher::matches): Remove.
4400         (mapped_index_base::find_name_components_bounds): Add "lang"
4401         parameter.
4402         (mapped_index_base::build_name_components): Also split names
4403         according to Ada syntax.
4404         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4405         type of "match_callback".
4406         (check_match, check_find_bounds_finds)
4407         (dw2_expand_symtabs_matching): Update.
4408         (dw2_debug_names_iterator): Add new constructor.
4409         (dw2_debug_names_map_matching_symbols): New function.
4410         (dw2_debug_names_expand_symtabs_matching): Update.
4411         (dwarf2_debug_names_functions): Use
4412         dw2_debug_names_map_matching_symbols.
4413
4414 2019-09-10  Tom Tromey  <tromey@adacore.com>
4415
4416         * dwarf2read.c (dw2_get_file_names_reader): Add the
4417         CU's file name to the results.
4418
4419 2019-09-10  Tom Tromey  <tromey@adacore.com>
4420
4421         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4422         map_matching_symbols.  Update.
4423         * dwarf2read.c (dw2_map_matching_symbols): Update.
4424         * psymtab.c (match_partial_symbol): Change type; update.
4425         (psym_map_matching_symbols): Likewise.
4426         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4427         type; update.
4428         * symfile.h (struct quick_symbol_functions)
4429         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4430         Remove "match".
4431
4432 2019-09-10  Tom Tromey  <tromey@adacore.com>
4433
4434         * psymtab.c (map_block): Remove.
4435         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4436         * symtab.c (iterate_over_symbols_terminated): New function.
4437         * symtab.c (iterate_over_symbols_terminated): Declare.
4438
4439 2019-09-10  Tom Tromey  <tromey@adacore.com>
4440
4441         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4442         * language.h (struct language_defn) <la_iterate_over_symbols>:
4443         Return bool.
4444         * symtab.c (iterate_over_symbols): Return bool.
4445         * symtab.h (iterate_over_symbols): Return bool.
4446
4447 2019-09-10  Tom Tromey  <tromey@adacore.com>
4448
4449         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4450         (add_nonlocal_symbols): Update.
4451         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4452         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4453         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4454         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4455         Change type of "callback".  Remove "data".
4456
4457
4458 2019-09-09  Ali Tamur  <tamur@google.com>
4459
4460         * dwarf2read.c (comp_unit_head): Update comment.
4461         (dwarf2_dwo_name): New function declaration.
4462         (dwarf_unit_type_name): New function declaration.
4463         (read_comp_unit_head): Add support for new compilation units,
4464         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4465         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4466         (currently named as "signature") in their header. Also clarify error
4467         messages.
4468         (lookup_dwo_id): New function. Returns the dwo id of the given
4469         compile unit.
4470         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4471         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4472         functions.
4473         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4474         (dwarf2_dwo_name): Get the dwo name if present.
4475         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4476         purposes.
4477
4478 2019-09-09  Tom Tromey  <tom@tromey.com>
4479
4480         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4481
4482 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4483
4484         * python/python.c (do_start_initialization): Make progname_copy static,
4485         to avoid a leak report.
4486
4487 2019-09-08  Tom Tromey  <tom@tromey.com>
4488
4489         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4490
4491 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4492
4493         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4494         Change type to gdb::optional<block_enum>.
4495         (dw2_symtab_iter_init): Change block_index parameter type
4496         to gdb::optional<block_enum>.
4497         (dw2_lookup_symbol): Change block_index parameter
4498         type to block_enum.c
4499         (dw2_debug_names_lookup_symbol): Likewise.
4500         * psymtab.c (psym_lookup_symbol): Likewise.
4501         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4502         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4503         Likewise.
4504
4505 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4506
4507         * defs.h (relocate_gdb_directory): Change int to bool in
4508         signature and rename flag to relocatable.
4509         * main.c (relocate_path): Likewise.
4510         (relocate_gdb_directory): Likewise.
4511
4512 2019-09-06  Alan Modra  <amodra@gmail.com>
4513
4514         * coffread.c (coff_symfile_read): Constify filename variable.
4515         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4516         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4517         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4518         * solib.c (reload_shared_libraries_1): Likewise.
4519         * symfile.c (reread_symbols): Likewise.
4520         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4521         * solib-darwin.c (darwin_bfd_open): Likewise.
4522         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4523
4524 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4525
4526         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4527         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4528
4529 2019-09-03  Tom Tromey  <tromey@adacore.com>
4530
4531         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4532         types.
4533         (has_negatives): Unbias a range type bound.
4534         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4535         * gdbtypes.c (operator==): Handle new field.
4536         (create_range_type): Add "bias" parameter.
4537         (create_static_range_type, resolve_dynamic_range): Update.
4538         * gdbtypes.h (struct range_bounds) <bias>: New member.
4539         (create_range_type): Add bias parameter.
4540         * printcmd.c (print_scalar_formatted): Unbias range types.
4541         * value.c (unpack_long): Unbias range types.
4542         (pack_long): Bias range types.
4543
4544 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4545
4546         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4547         probe arguments.
4548
4549 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4550
4551         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4552         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4553         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4554         (compile_probe_arg): Likewise.
4555         * probe.h (get_argument_count): Likewise.
4556         * solib-svr4.c (solib_event_probe_action): Likewise.
4557         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4558
4559 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4560
4561         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4562         code to here...
4563         (svr4_create_solib_event_breakpoints): ...from here.
4564
4565 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4566
4567         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4568         suffix from warning message.
4569
4570 2019-08-30  Tom Tromey  <tom@tromey.com>
4571
4572         * tui/tui-winsource.h (struct tui_source_window_base)
4573         <refresh_all>: Don't declare.
4574         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4575         Remove.
4576         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4577         tui_show_locator_content.
4578         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4579         declare.
4580         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4581         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4582         declare.
4583
4584 2019-08-30  Tom Tromey  <tom@tromey.com>
4585
4586         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4587
4588 2019-08-30  Tom Tromey  <tom@tromey.com>
4589
4590         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4591         Remove unnecessary forward declarations.
4592
4593 2019-08-30  Tom Tromey  <tom@tromey.com>
4594
4595         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4596         rerender.
4597         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4598         tui_show_locator_content.
4599
4600 2019-08-30  Tom Tromey  <tom@tromey.com>
4601
4602         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4603         (tui_locator_window::rerender): Rewrite using body of previous
4604         tui_show_locator_content.
4605
4606 2019-08-30  Tom Tromey  <tom@tromey.com>
4607
4608         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4609         set_locator_fullname>: New methods.
4610         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4611         Rename from tui_set_locator_fullname.
4612         (tui_locator_window::set_locator_info): Rename from
4613         tui_set_locator_info.  Return bool.
4614         (tui_update_locator_fullname, tui_show_frame_info): Update.
4615
4616 2019-08-30  Tom Tromey  <tom@tromey.com>
4617
4618         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4619
4620 2019-08-30  Tom Tromey  <tom@tromey.com>
4621
4622         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4623         call touchwin.
4624
4625 2019-08-30  Tom Tromey  <tom@tromey.com>
4626
4627         * tui/tui-wingeneral.c (box_win): Assume win_info and
4628         win_info->handle cannot be NULL.
4629
4630 2019-08-30  Tom Tromey  <tom@tromey.com>
4631
4632         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4633         refresh_window>: Declare.
4634         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4635         resize.
4636         (tui_data_item_window::rerender): Rename from
4637         tui_display_register.
4638         (tui_data_item_window::refresh_window): New method.
4639         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4640         no-op.
4641
4642 2019-08-30  Tom Tromey  <tom@tromey.com>
4643
4644         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4645         regs_column_count, current_group>: Move later.  Now private.
4646         <get_current_group>: New method.
4647         * tui/tui-regs.c (tui_reg_command): Update.
4648         * tui/tui-layout.c (tui_set_layout): Update.
4649
4650 2019-08-30  Tom Tromey  <tom@tromey.com>
4651
4652         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4653         (tui_data_window::rerender): Don't call
4654         check_and_display_highlight_if_needed.
4655         (tui_data_window::refresh_all): Remove call to
4656         erase_data_content.
4657
4658 2019-08-30  Tom Tromey  <tom@tromey.com>
4659
4660         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4661         (tui_data_window::display_registers_from)
4662         (tui_data_window::display_reg_element_at_line)
4663         (tui_data_window::display_registers_from_line): Remove checks of
4664         "empty".
4665
4666 2019-08-30  Tom Tromey  <tom@tromey.com>
4667
4668         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4669         Don't declare.
4670         * tui/tui-regs.c (tui_data_window::show_registers): Call
4671         rerender.
4672         (tui_data_window::rerender): Rename from display_all_data.
4673         (tui_data_window::rerender): Remove old implementation.
4674
4675 2019-08-30  Tom Tromey  <tom@tromey.com>
4676
4677         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4678         text.
4679         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4680
4681 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4682             Sergio Durigan Junior  <sergiodj@redhat.com>
4683
4684         PR win32/24284
4685         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4686
4687 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4688
4689         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4690         when searching for types.
4691
4692 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4693
4694         * f-lang.c (f_language_defn): Use f_print_typedef.
4695         * f-lang.h (f_print_typedef): Declare.
4696         * f-typeprint.c (f_print_typedef): Define.
4697
4698 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4699
4700         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4701
4702 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4703
4704         * cli/cli-utils.c (info_print_options_defs): Delete.
4705         (make_info_print_options_def_group): Delete.
4706         (extract_info_print_options): Delete.
4707         (info_print_command_completer): Delete.
4708         (info_print_args_help): Add extra parameter, and optionally
4709         include text about -n flag.
4710         * cli/cli-utils.h (struct info_print_options): Delete.
4711         (extract_info_print_options): Delete declaration.
4712         (info_print_command_completer): Delete declaration.
4713         (info_print_args_help): Add extra parameter, extend header
4714         comment.
4715         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4716         search_symbols.
4717         * stack.c (struct info_print_options): New type.
4718         (info_print_options_defs): New file scoped variable.
4719         (make_info_print_options_def_group): New static function.
4720         (info_print_command_completer): New static function.
4721         (info_locals_command): Update to use new local functions.
4722         (info_args_command): Likewise.
4723         (_initialize_stack): Add extra parameter to calls to
4724         info_print_args_help.
4725         * symtab.c (search_symbols): Add extra parameter, use this to
4726         possibly excluse non-debug symbols.
4727         (symtab_symbol_info): Add extra parameter, which is passed on to
4728         search_symbols.
4729         (struct info_print_options): New type.
4730         (info_print_options_defs): New file scoped variable.
4731         (make_info_print_options_def_group): New static function.
4732         (info_print_command_completer): New static function.
4733         (info_variables_command): Update to use local functions, and pass
4734         extra parameter through to symtab_symbol_info.
4735         (info_functions_command): Likewise.
4736         (info_types_command): Pass additional argument through to
4737         symtab_symbol_info.
4738         (rbreak_command): Pass extra argument to search_symbols.
4739         (_initialize_symtab): Add extra arguments for calls to
4740         info_print_args_help, and update help text for 'info variables',
4741         'whereis', and 'info functions' commands.
4742         * symtab.h (search_symbols): Add extra argument to declaration.
4743         * NEWS: Mention new flags.
4744
4745 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4746
4747         * symtab.c (lookup_static_symbol): Call the new function (and move
4748         it down to be next to lookup_global_symbol).
4749         (struct global_sym_lookup_data): Add block_enum member and rename to...
4750         (struct global_or_static_sym_lookup_data): ...this.
4751         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4752         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4753         (lookup_symbol_global_or_static_iterator_cb): ...this.
4754         (lookup_global_or_static_symbol): New function.
4755         (lookup_global_symbol): Call new function.
4756
4757 2019-08-26  Tom de Vries  <tdevries@suse.de>
4758
4759         PR c++/24852
4760         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4761         when pc_probe.prob == NULL.
4762
4763 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4764
4765         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4766         variable symbol_linkage to symbol_linkage_.
4767
4768 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4769
4770         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4771         represent whether the symbol is static, dynamic, or we don't
4772         know.
4773
4774 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4775
4776         * gdb/rx-tdep.c (rx_register_names): New.
4777         (rx_register_name): Delete.
4778         (rx_psw_type): Delete.
4779         (rx_fpsw_type): Delete.
4780         (rx_register_type): Delete.
4781         (rx_gdbarch_init): Convert target-descriptions.
4782         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4783         * gdb/features/Makefile: Add rx.xml.
4784         * gdb/features/rx.xml: New.
4785         * gdb/features/rx.c: Generated.
4786         * gdb/NEWS: Mention target description support.
4787
4788 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4789
4790         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4791         *slot_ptr.
4792
4793 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4794
4795         * configure.ac: Don't check for 'dlfcn.h' (moved to
4796         gdbsupport/common.m4).
4797         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4798         'gdbsupport/'.
4799         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4800         * compile/compile-c-support.c: Include
4801         'gdbsupport/gdb-dlfcn.h'.
4802         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4803         * gdb-dlfcn.c: Move to...
4804         * gdbsupport/gdb-dlfcn.c: ... here.
4805         * gdb-dlfcn.h: Move to...
4806         * gdbsupport/gdb-dlfcn.h: ... here.
4807
4808 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4809
4810         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4811         the offset field signed.
4812
4813 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4814
4815         * python/lib/gdb/__init__.py (_execute_file): New function.
4816         * python/python.c (python_run_simple_file): Call gdb._execute_file
4817         on Windows.
4818
4819 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4820
4821         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4822         all uses as this was never set to anything but a zero value.
4823
4824 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4825
4826         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4827
4828 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4829
4830         * tui/tui-data.h (tui_gen_win_info): Add an =default
4831         move constructor, required by some GCC versions.
4832
4833 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4834
4835         * go32-nat.c (go32_sysinfo): Add hygon_p.
4836
4837 2019-08-20  Tom Tromey  <tom@tromey.com>
4838
4839         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4840         line_from_reg_element_no, first_reg_element_no_inline,
4841         display_all_data, delete_data_content_windows,
4842         erase_data_content>: Now private.
4843
4844 2019-08-20  Tom Tromey  <tom@tromey.com>
4845
4846         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4847         (tui_unhighlight_win, tui_highlight_win)
4848         (tui_win_info::make_window): Update.
4849         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4850
4851 2019-08-20  Tom Tromey  <tom@tromey.com>
4852
4853         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4854         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4855         (MAX_PID_WIDTH): Move to tui-stack.c.
4856         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4857         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4858         (MAX_PID_WIDTH): Move from tui-data.h.
4859
4860 2019-08-20  Tom Tromey  <tom@tromey.com>
4861
4862         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4863         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4864         (box_win): Update.
4865         (tui_gen_win_info::make_window): Rename from tui_make_window.
4866         (tui_win_info::make_window): New method.
4867         (tui_gen_win_info::make_visible): Update.
4868         * tui/tui-source.c (tui_source_window::set_contents): Update.
4869         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4870         (tui_data_window::display_registers_from): Update.
4871         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4872         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4873         Declare.
4874         <can_box>: Remove.
4875         <title>: Remove.
4876         (struct tui_win_info) <make_window>: Declare.
4877         <can_box>: Now virtual.
4878         <title>: New member.
4879         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4880         * tui/tui-command.c (tui_cmd_window::resize): Update.
4881
4882 2019-08-20  Tom Tromey  <tom@tromey.com>
4883
4884         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4885         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4886         (tui_data_window::check_register_values): Update.
4887
4888 2019-08-20  Tom Tromey  <tom@tromey.com>
4889
4890         * tui/tui-regs.h (struct tui_data_window): Use
4891         DISABLE_COPY_AND_ASSIGN.
4892         <regs_content>: Change type, removing unique_ptr.
4893         <tui_data_window>: Add move constructor.
4894         * tui/tui-regs.c (tui_data_window::show_registers)
4895         (tui_data_window::show_register_group)
4896         (tui_data_window::display_registers_from)
4897         (tui_data_window::display_registers_from)
4898         (tui_data_window::first_data_item_displayed)
4899         (tui_data_window::delete_data_content_windows)
4900         (tui_data_window::rerender, tui_data_window::refresh_window)
4901         (tui_data_window::check_register_values): Update.
4902
4903 2019-08-20  Tom Tromey  <tom@tromey.com>
4904
4905         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4906         show_register_group>: Declare.
4907         (tui_show_register_group): Don't declare.
4908         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4909         tui_show_registers.
4910         (tui_data_window::show_register_group): Rename from
4911         tui_show_register_group.
4912         (tui_data_window::check_register_values, tui_reg_command):
4913         Update.
4914         * tui/tui-layout.c (tui_set_layout): Update.
4915
4916 2019-08-20  Tom Tromey  <tom@tromey.com>
4917
4918         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4919         Declare.
4920         (tui_check_register_values): Don't declare.
4921         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4922         from tui_check_register_values.
4923         * tui/tui-hooks.c (tui_register_changed): Update.
4924
4925 2019-08-20  Tom Tromey  <tom@tromey.com>
4926
4927         * tui/tui-regs.c (tui_reg_layout): Move later.
4928         (tui_show_registers): Don't enable TUI mode or change layout.
4929
4930 2019-08-20  Tom Tromey  <tom@tromey.com>
4931
4932         * tui/tui-regs.h (struct tui_data_item_window)
4933         <~tui_data_item_window>: Remove.
4934         <content>: Now a unique_xmalloc_ptr.
4935         * tui/tui-regs.c (tui_register_format): Return a
4936         unique_xmalloc_ptr.
4937         (tui_get_register): Update.
4938         (~tui_data_item_window): Remove.
4939         (tui_data_window::display_registers_from, tui_display_register):
4940         Update.
4941         * tui/tui-io.h (tui_expand_tabs): Update.
4942         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4943         Remove "col" parameter.
4944
4945 2019-08-20  Tom Tromey  <tom@tromey.com>
4946
4947         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4948         field.
4949         * tui/tui-regs.c (~tui_data_item_window): Update.
4950
4951 2019-08-20  Tom Tromey  <tom@tromey.com>
4952
4953         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4954         earlier.
4955
4956 2019-08-20  Tom Tromey  <tom@tromey.com>
4957
4958         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4959
4960 2019-08-20  Tom Tromey  <tom@tromey.com>
4961
4962         * tui/tui-source.h (struct tui_source_window): Update.
4963         * tui/tui-regs.c (tui_show_registers): Update.
4964         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4965         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4966         (NO_REGS_STRING): Remove defines.
4967
4968 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4969
4970         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4971         unnecessary thread walk if remote doesn't support the packet.
4972
4973 2019-08-19  Tom Tromey  <tromey@adacore.com>
4974
4975         * python/py-value.c (value_has_field): Fix indentation.
4976
4977 2019-08-19  Tom Tromey  <tromey@adacore.com>
4978
4979         * printcmd.c (do_one_display, info_display_command): Update.
4980         * block.h (contained_in): Return bool.  Add allow_nested
4981         parameter.
4982         * block.c (contained_in): Return bool.  Add allow_nested
4983         parameter.
4984
4985 2019-08-19  Tom Tromey  <tom@tromey.com>
4986
4987         * configure: Rebuild.
4988         * configure.ac: Disallow the combination of -static-libstdc++ and
4989         source highlight.
4990         * source-cache.c (get_language_name): Handle rust.
4991         (source_cache::get_source_lines): Ignore highlighting exceptions.
4992
4993 2019-08-16  Tom Tromey  <tom@tromey.com>
4994
4995         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4996         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4997         (struct tui_source_window_base) <make_visible, refresh_window,
4998         resize>: Remove methods.
4999         <execution_info>: Remove field.
5000         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5001         (tui_show_source_line, tui_source_window_base)
5002         (~tui_source_window_base): Update.
5003         (tui_source_window_base::resize)
5004         (tui_source_window_base::make_visible)
5005         (tui_source_window_base::refresh_window): Remove.
5006         (tui_source_window_base::update_exec_info): Update.
5007         * tui/tui-source.c (tui_source_window::set_contents): Update.
5008         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5009
5010 2019-08-16  Tom Tromey  <tom@tromey.com>
5011
5012         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5013         deprecated_query_hook.
5014
5015 2019-08-16  Tom Tromey  <tom@tromey.com>
5016
5017         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5018         (tui_update_source_windows_with_line): Update.
5019         * tui/tui-source.h (struct tui_source_window)
5020         <show_symtab_source>: Declare.
5021         (tui_show_symtab_source): Don't declare.
5022         * tui/tui-source.c (tui_show_symtab_source): Rename from
5023         tui_show_symtab_source.
5024
5025 2019-08-16  Tom Tromey  <tom@tromey.com>
5026
5027         * tui/tui-winsource.h (struct tui_source_window_base)
5028         <set_contents>: Declare.
5029         * tui/tui-winsource.c
5030         (tui_source_window_base::update_source_window_as_is): Update.
5031         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5032         Declare.
5033         (tui_set_source_content): Don't declare.
5034         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5035         tui_set_source_content.
5036         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5037         Declare.
5038         (tui_set_disassem_content): Don't declare.
5039         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5040         tui_set_disassem_content.
5041
5042 2019-08-16  Tom Tromey  <tom@tromey.com>
5043
5044         * tui/tui-winsource.h (struct tui_source_window_base)
5045         <update_breakpoint_info>: Declare.
5046         (tui_update_breakpoint_info): Don't declare.
5047         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5048         (tui_update_all_breakpoint_info): Update.
5049         (tui_source_window_base::update_breakpoint_info): Rename from
5050         tui_update_breakpoint_info.
5051         (tui_source_window_base::update_exec_info): Update.
5052
5053 2019-08-16  Tom Tromey  <tom@tromey.com>
5054
5055         * tui/tui-winsource.h (struct tui_source_window_base)
5056         <update_source_window>: Declare.
5057         (tui_update_source_window): Don't declare.
5058         * tui/tui-winsource.c
5059         (tui_source_window_base::update_source_window): Rename from
5060         tui_update_source_window.
5061         (tui_source_window_base::rerender): Update.
5062         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5063         * tui/tui-disasm.c (tui_show_disassem)
5064         (tui_show_disassem_and_update_source)
5065         (tui_disasm_window::maybe_update): Update.
5066
5067 2019-08-16  Tom Tromey  <tom@tromey.com>
5068
5069         * tui/tui-winsource.h (struct tui_source_window_base)
5070         <update_source_window_as_is>: Declare.
5071         (tui_update_source_window_as_is): Don't declare.
5072         * tui/tui-winsource.c (tui_update_source_window): Update
5073         (tui_source_window_base::update_source_window_as_is): Rename from
5074         tui_update_source_window_as_is.
5075         (tui_source_window_base::refill): Update.
5076         * tui/tui-source.c (tui_show_symtab_source): Update.
5077         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5078         Update.
5079
5080 2019-08-16  Tom Tromey  <tom@tromey.com>
5081
5082         * tui/tui-winsource.h (tui_update_source_window)
5083         (tui_update_source_window_as_is): Remove "noerror" parameter.
5084         * tui/tui-winsource.c (tui_update_source_window)
5085         (tui_update_source_window_as_is): Remove "noerror" parameter.
5086         (tui_update_source_windows_with_addr)
5087         (tui_update_source_windows_with_line)
5088         (tui_source_window_base::rerender)
5089         (tui_source_window_base::refill): Update.
5090         * tui/tui-source.h (tui_set_source_content)
5091         (tui_show_symtab_source): Remove "noerror" parameter.
5092         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5093         parameter.
5094         (tui_show_symtab_source): Likewise.
5095         (tui_source_window::maybe_update): Update.
5096         * tui/tui-disasm.c (tui_show_disassem)
5097         (tui_show_disassem_and_update_source)
5098         (tui_disasm_window::do_scroll_vertical)
5099         (tui_disasm_window::maybe_update): Update.
5100
5101 2019-08-16  Tom Tromey  <tom@tromey.com>
5102
5103         * tui/tui.c (tui_is_window_visible): Update.
5104         * tui/tui-wingeneral.c (tui_make_window)
5105         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5106         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5107         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5108         (tui_set_win_height_command, parse_scrolling_args): Update.
5109         * tui/tui-source.c (tui_source_window::style_changed): Update.
5110         * tui/tui-regs.c (tui_show_registers)
5111         (tui_data_window::first_data_item_displayed)
5112         (tui_data_window::delete_data_content_windows)
5113         (tui_check_register_values, tui_reg_command): Update.
5114         * tui/tui-disasm.c (tui_show_disassem): Update.
5115         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5116         method.
5117         <is_visible>: Remove field.
5118         * tui/tui-data.c (tui_next_win, tui_prev_win)
5119         (tui_delete_invisible_windows): Update.
5120
5121 2019-08-16  Tom Tromey  <tom@tromey.com>
5122
5123         * tui/tui-winsource.h (struct tui_source_window_base)
5124         <m_has_locator>: Remove.
5125         * tui/tui-layout.c (show_source_disasm_command, show_data)
5126         (show_source_or_disasm_and_command): Update.
5127
5128 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5129
5130         * NEWS (Other MI changes): New subsection.
5131         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5132         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5133         * arch-utils.c (default_get_pc_address_flags): New function.
5134         * arch-utils.h (default_get_pc_address_flags): New declaration.
5135         * gdbarch.sh: Add get_pc_address_flags.
5136         * gdbarch.c: Regenerate.
5137         * gdbarch.h: Likewise.
5138         * stack.c (print_pc): New function.
5139         (print_frame_info) (print_frame): Call print_pc.
5140
5141 2019-08-16  Tom de Vries  <tdevries@suse.de>
5142
5143         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5144         print_objfile_section_info.
5145
5146 2019-08-15  Tom Tromey  <tom@tromey.com>
5147
5148         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5149         calling update_cmdwin_start_line.
5150         * tui/tui-winsource.h (struct tui_source_window_base)
5151         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5152         <rerender>: Declare.
5153         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5154         Call rerender.
5155         (tui_source_window_base::set_new_height): Remove.
5156         (tui_source_window_base::rerender): Rename from
5157         do_make_visible_with_new_height.
5158         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5159         resize method.
5160         (tui_win_info::make_invisible_and_set_new_height)
5161         (tui_win_info::make_visible_with_new_height): Remove.
5162         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5163         Declare.
5164         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5165         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5166         do_make_visible_with_new_height>: Don't declare.
5167         <rerender>: Declare.
5168         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5169         set_new_height.
5170         (tui_data_window::do_make_visible_with_new_height): Remove.
5171         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5172         call tui_show_locator_content.
5173         (tui_gen_win_info::resize): Call rerender.
5174         (show_source_or_disasm_and_command): Don't call
5175         tui_show_locator_content.
5176         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5177         method.
5178         (struct tui_win_info) <rerender>: Declare.
5179         <set_new_height, make_invisible_and_set_new_height,
5180         make_visible_with_new_height>: Don't declare.
5181         * tui/tui-data.c (tui_win_list::rerender): New method.
5182         * tui/tui-command.h (struct tui_cmd_window)
5183         <do_make_visible_with_new_height>: Don't declare.
5184         * tui/tui-command.c
5185         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5186
5187 2019-08-15  Tom Tromey  <tromey@adacore.com>
5188
5189         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5190         * ada-lang.c (ada_enum_name): Likewise.
5191
5192 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5193
5194         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5195         leading underscore.
5196         (GdbOutputErrorFile): Likewise.
5197         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5198         accordingly.
5199         (execute_unwinders): Rename to have a leading underscore.
5200         (auto_load_packages): Likewise.
5201         (global scope): Adjust call to auto_load_packages accordingly.
5202         (GdbSetPythonDirectory): Likewise.
5203         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5204         instead of execute_unwinders.
5205
5206 2019-08-15  Tom Tromey  <tom@tromey.com>
5207
5208         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5209         (show_data): Don't change window visibility.
5210         (tui_gen_win_info::resize): Remove special case for command
5211         window.  Use wresize, when available.
5212         (show_source_or_disasm_and_command): Don't change window
5213         visibility.
5214         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5215         <make_visible>: New method.
5216         * tui/tui-command.c (tui_cmd_window::resize): New method.
5217
5218 2019-08-15  Tom Tromey  <tom@tromey.com>
5219
5220         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5221         (struct tui_source_windows): New.
5222         * tui/tui-winsource.c (tui_display_main): Update.
5223         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5224         (new_height_ok, parse_scrolling_args): Update.
5225         * tui/tui-layout.c (show_layout, show_data): Update.
5226         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5227         (tui_add_to_source_windows): Don't declare.
5228         * tui/tui-data.c (source_windows, tui_source_windows)
5229         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5230
5231 2019-08-15  Tom Tromey  <tom@tromey.com>
5232
5233         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5234         Rename from reset.
5235         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5236         * tui/tui-layout.c (show_source_disasm_command, show_data):
5237         Update.
5238         (tui_gen_win_info::resize): Rename.
5239         (show_source_or_disasm_and_command): Update.
5240         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5241         reset.
5242
5243 2019-08-15  Tom Tromey  <tom@tromey.com>
5244
5245         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5246         * tui/tui-interp.c (tui_interp::init): Don't call
5247         tui_initialize_static_data.
5248         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5249
5250 2019-08-15  Tom Tromey  <tom@tromey.com>
5251
5252         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5253         examine tui_win_list.
5254
5255 2019-08-15  Tom Tromey  <tom@tromey.com>
5256
5257         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5258         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5259         tui_clear_source_content.
5260         (tui_clear_source_content): Remove.
5261         (tui_source_window_base::do_erase_source_content): Hoist call to
5262         content.clear().
5263         * tui/tui-stack.c (tui_show_frame_info): Don't call
5264         tui_clear_source_content.
5265
5266 2019-08-15  Tom Tromey  <tom@tromey.com>
5267
5268         * tui/tui-winsource.h (struct tui_source_window_base)
5269         <do_erase_source_content>: New method.
5270         <erase_source_content>: New method.
5271         (tui_erase_source_content): Don't declare.
5272         * tui/tui-winsource.c (tui_clear_source_content): Update.
5273         (tui_source_window_base::do_erase_source_content): Rename from
5274         tui_erase_source_content.
5275         (tui_source_window_base::show_source_content): Update.
5276         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5277         * tui/tui-source.h (struct tui_source_window)
5278         <erase_source_content>: New method.
5279         * tui/tui-disasm.h (struct tui_disasm_window)
5280         <erase_source_content>: New method.
5281
5282 2019-08-15  Tom Tromey  <tom@tromey.com>
5283
5284         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5285         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5286         constructor.
5287         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5288         * tui/tui-source.c (tui_set_source_content): Update.
5289         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5290
5291 2019-08-15  Tom Tromey  <tom@tromey.com>
5292
5293         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5294         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5295         tui-source.c.
5296         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5297         Declare.
5298         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5299         method.
5300         (tui_source_window::maybe_update): Update.
5301
5302 2019-08-15  Tom Tromey  <tom@tromey.com>
5303
5304         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5305         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5306         tui-disasm.c.
5307         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5308         Declare.
5309         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5310         method.
5311         (tui_disasm_window::maybe_update): Update.
5312
5313 2019-08-15  Tom Tromey  <tom@tromey.com>
5314
5315         * tui/tui-winsource.h (struct tui_source_window_base)
5316         <maybe_update>: Declare.
5317         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5318         method.
5319         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5320         Declare.
5321         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5322         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5323         Declare.
5324         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5325
5326 2019-08-15  Tom Tromey  <tom@tromey.com>
5327
5328         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5329
5330 2019-08-15  Tom Tromey  <tom@tromey.com>
5331
5332         * tui/tui-wingeneral.c: Include tui-stack.h.
5333         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5334         (struct tui_locator_window): Move from tui-data.h.
5335         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5336         (tui_initialize_static_data): Move from tui-data.c.
5337         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5338         (struct tui_locator_window): Move to tui-stack.c.
5339         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5340         (tui_initialize_static_data): Move to tui-stack.c.
5341
5342 2019-08-15  Tom Tromey  <tom@tromey.com>
5343
5344         * tui/tui-layout.c (show_source_disasm_command)
5345         (show_source_or_disasm_and_command): Use make_visible method, not
5346         tui_make_window.
5347         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5348         Remove.
5349
5350 2019-08-15  Tom Tromey  <tom@tromey.com>
5351
5352         * tui/tui-wingeneral.h (tui_make_window): Update.
5353         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5354         parameter.
5355         (tui_gen_win_info::make_visible): Update.
5356         * tui/tui-regs.c (tui_data_window::display_registers_from):
5357         Update.
5358         * tui/tui-layout.c (show_source_disasm_command)
5359         (show_source_or_disasm_and_command): Update.
5360         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5361         (enum tui_box): Remove.
5362         (struct tui_win_info) <can_box>: New method.
5363         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5364         method.
5365
5366 2019-08-15  Tom de Vries  <tdevries@suse.de>
5367
5368         * linux-nat-trad.c: Include gdbarch.h.
5369
5370 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5371
5372         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5373         register sizes.
5374
5375 2019-08-14  Tom Tromey  <tromey@adacore.com>
5376
5377         * darwin-nat.c: Include gdbarch.h.
5378         * darwin-nat-info.c: Include gdbarch.h.
5379
5380 2019-08-13  Tom Tromey  <tom@tromey.com>
5381
5382         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5383         Remove.
5384         * tui/tui-data.c (tui_initialize_static_data): Update.
5385
5386 2019-08-13  Tom Tromey  <tom@tromey.com>
5387
5388         * tui/tui-winsource.h (struct tui_exec_info_window)
5389         <~tui_exec_info_window, maybe_allocate_content, get_content,
5390         m_content>: Remove.
5391         (struct tui_source_window_base) <set_exec_info_content,
5392         show_exec_info_content>: Don't declare.
5393         * tui/tui-winsource.c
5394         (tui_exec_info_window::maybe_allocate_content): Remove.
5395         (tui_source_window_base::update_exec_info): Rename from
5396         set_exec_info_content.
5397         (tui_source_window_base::show_exec_info_content)
5398         (tui_source_window_base::update_exec_info): Remove.
5399
5400 2019-08-13  Tom Tromey  <tom@tromey.com>
5401
5402         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5403         declare.
5404         * tui/tui-winsource.c (tui_update_source_window_as_is)
5405         (tui_update_source_windows_with_addr, tui_erase_source_content):
5406         Update.
5407         (tui_clear_exec_info_content): Remove.
5408
5409 2019-08-13  Tom Tromey  <tom@tromey.com>
5410
5411         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5412         declare.
5413         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5414         call tui_erase_exec_info_content.
5415         (tui_clear_exec_info_content): Rename from
5416         tui_erase_exec_info_content.
5417         (tui_clear_exec_info_content): Delete.
5418
5419 2019-08-13  Tom Tromey  <tom@tromey.com>
5420
5421         * tui/tui-winsource.h (struct tui_source_window_base)
5422         <show_exec_info_content>: Declare.
5423         (tui_show_exec_info_content): Don't declare.
5424         * tui/tui-winsource.c
5425         (tui_source_window_base::show_exec_info_content): Rename from
5426         tui_show_exec_info_content.
5427         (tui_source_window_base::update_exec_info): Update.
5428
5429 2019-08-13  Tom Tromey  <tom@tromey.com>
5430
5431         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5432         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5433         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5434         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5435         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5436         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5437         ... here.
5438
5439 2019-08-13  Tom Tromey  <tom@tromey.com>
5440
5441         * tui/tui-winsource.h (struct tui_source_window_base)
5442         <update_exec_info>: Declare.
5443         (tui_update_exec_info): Don't declare.
5444         * tui/tui-winsource.c (tui_update_source_window_as_is)
5445         (tui_source_window_base::refresh_all)
5446         (tui_update_all_breakpoint_info): Update.
5447         (tui_source_window_base::update_exec_info): Rename from
5448         tui_update_exec_info.
5449         * tui/tui-stack.c (tui_show_frame_info): Update.
5450
5451 2019-08-13  Tom Tromey  <tom@tromey.com>
5452
5453         * tui/tui-winsource.h (struct tui_source_window_base)
5454         <set_exec_info_content>: Declare.
5455         (tui_set_exec_info_content): Don't declare.
5456         * tui/tui-winsource.c
5457         (tui_source_window_base::set_exec_info_content): Rename from
5458         tui_set_exec_info_content.
5459         (tui_update_exec_info): Update.
5460
5461 2019-08-13  Tom Tromey  <tom@tromey.com>
5462
5463         * tui/tui-winsource.h (struct tui_source_window_base)
5464         <show_source_content>: Declare.
5465         (tui_show_source_content): Don't declare.
5466         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5467         (tui_source_window_base::show_source_content): Rename from
5468         tui_show_source_content.
5469         (tui_source_window_base::refresh_all): Update.
5470         * tui/tui-layout.c (show_source_disasm_command)
5471         (show_source_or_disasm_and_command): Update.
5472
5473 2019-08-13  Tom Tromey  <tom@tromey.com>
5474
5475         * tui/tui-winsource.c (tui_erase_source_content)
5476         (tui_show_source_content, tui_source_window_base::refresh_all):
5477         Update.
5478         * tui/tui-wingeneral.h
5479         (tui_check_and_display_highlight_if_needed): Don't declare.
5480         * tui/tui-wingeneral.c
5481         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5482         check_and_display_highlight_if_needed.
5483         * tui/tui-win.c (tui_rehighlight_all)
5484         (tui_win_info::make_visible_with_new_height): Update.
5485         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5486         (tui_data_window::erase_data_content)
5487         (tui_data_window::display_all_data): Update.
5488         * tui/tui-data.h (struct tui_win_info)
5489         <check_and_display_highlight_if_needed>: Declare.
5490
5491 2019-08-13  Tom Tromey  <tom@tromey.com>
5492
5493         * tui/tui-win.c (tui_resize_all): Call
5494         tui_delete_invisible_windows.
5495         * tui/tui-layout.c (show_layout): Call
5496         tui_delete_invisible_windows.
5497         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5498         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5499
5500 2019-08-13  Tom Tromey  <tom@tromey.com>
5501
5502         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5503         tui_add_win_to_layout.
5504
5505 2019-08-13  Tom Tromey  <tom@tromey.com>
5506
5507         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5508         * tui/tui-layout.c (tui_default_win_height): Now static.
5509
5510 2019-08-13  Tom Tromey  <tom@tromey.com>
5511
5512         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5513         single switch.
5514         (show_source_disasm_command, show_source_or_disasm_and_command):
5515         Don't check current layout.
5516
5517 2019-08-13  Tom Tromey  <tom@tromey.com>
5518
5519         * tui/tui-wingeneral.c (make_all_visible): Remove.
5520         (tui_make_all_invisible): Simplify.
5521         * tui/tui-layout.c (tui_make_all_invisible): Move from
5522         tui-wingeneral.c; simplify.
5523         (show_layout): Hoist call to tui_make_all_invisible.
5524         (show_data): Don't call tui_make_all_invisible.
5525
5526 2019-08-13  Tom Tromey  <tom@tromey.com>
5527
5528         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5529         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5530
5531 2019-08-13  Tom Tromey  <tom@tromey.com>
5532
5533         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5534         tui-data.c.
5535         (show_source_disasm_command, show_data)
5536         (show_source_or_disasm_and_command): Don't use
5537         tui_set_current_layout_to.
5538         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5539         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5540         tui-layout.c.
5541         (tui_set_current_layout_to): Remove.
5542
5543 2019-08-13  Tom Tromey  <tom@tromey.com>
5544
5545         * tui/tui-layout.c (tui_set_layout): Update.
5546         * tui/tui-data.h (struct tui_layout_def): Remove.
5547         (tui_layout_def): Don't declare.
5548         * tui/tui-data.c (layout_def): Remove.
5549         (tui_layout_def): Remove.
5550
5551 2019-08-13  Tom Tromey  <tom@tromey.com>
5552
5553         * tui/tui-winsource.h (struct tui_source_window_base)
5554         <clear_detail>: No longer "override".
5555         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5556         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5557         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5558         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5559         Remove.
5560         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5561
5562 2019-08-13  Tom Tromey  <tromey@adacore.com>
5563
5564         * tracepoint.c: Don't include readline.h or history.h.
5565
5566 2019-08-12  Tom Tromey  <tom@tromey.com>
5567
5568         * configure: Rebuild.
5569         * configure.ac: Check for readline 7.
5570         * NEWS: Mention readline 7 requirement.
5571         * README: Update.
5572
5573 2019-08-12  Tom Tromey  <tom@tromey.com>
5574
5575         * mingw-hdep.c (gdb_select): Remove readline hack.
5576
5577 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5578
5579         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5580         when the function fails.
5581
5582 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5583
5584         * s390-tdep.c (s390_type_align): New function.
5585         (s390_gdbarch_init): Set it as type_align gdbarch method.
5586
5587 2019-08-09  Tom de Vries  <tdevries@suse.de>
5588
5589         PR gdb/24591
5590         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5591         pc_low with relocation offset.
5592
5593 2019-08-07  Tom Tromey  <tromey@adacore.com>
5594
5595         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5596         (print_frame_args): Update.
5597         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5598         Update.
5599         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5600         * frame.h (struct frame_arg): Add initializers.
5601         <error>: Now a unique_xmalloc_ptr.
5602
5603 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5604
5605         * NEWS: Expand the Pointer Authentication entry.
5606         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5607         (aarch64_frame_unmask_lr): ... to this.
5608         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5609         Call aarch64_frame_unmask_lr.
5610         * frame.c (struct frame_info): Add "masked" variable.
5611         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5612         (fprint_frame): Check for masked pc.
5613         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5614         declarations.
5615         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5616         * stack.c (print_frame): Check for masked pc.
5617
5618 2019-08-06  Tom Tromey  <tom@tromey.com>
5619
5620         * stabsread.c (patch_block_stabs, read_one_struct_field)
5621         (read_enum_type): Use obstack_strndup.
5622         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5623         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5624         * dwarf2read.c (guess_full_die_structure_name)
5625         (anonymous_struct_prefix): Use obstack_strndup.
5626         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5627         * c-exp.y (yylex): Use obstack_strndup.
5628         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5629         (write_var_or_type): Use obstack_strndup.
5630
5631 2019-08-06  Tom Tromey  <tom@tromey.com>
5632
5633         * symfile.c (reread_symbols): Use obstack_strdup.
5634         * stabsread.c (read_type): Use obstack_strdup.
5635         * gdb_obstack.h (obstack_strdup): New overload.
5636         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5637         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5638         (dwarf2_canonicalize_name): Use obstack_strdup.
5639         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5640         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5641         Use obstack_strdup.
5642
5643 2019-08-06  Tom Tromey  <tom@tromey.com>
5644
5645         * gdb_obstack.h (obstack_strdup): Define.
5646         * gdb_obstack.c (obstack_strdup): Don't define.
5647
5648 2019-08-06  Tom Tromey  <tom@tromey.com>
5649
5650         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5651         obstack_strdup.
5652         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5653         obstack_strdup.
5654         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5655         * stabsread.c (common_block_start): Use obstack_strdup.
5656         * objfiles.c (set_objfile_main_name, objfile): Use
5657         obstack_strdup.
5658         * namespace.c (add_using_directive): Use obstack_strdup.
5659         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5660         * jit.c (finalize_symtab): Use obstack_strdup.
5661         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5662         (guess_partial_die_structure_name, partial_die_info::fixup)
5663         (dwarf2_name): Use obstack_strdup.
5664         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5665         obstack_strdup.
5666         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5667         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5668         obstack_strdup.
5669         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5670
5671 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5672
5673         * unittests/help-doc-selftests.c: New file.
5674         * Makefile.in: Add the new file.
5675
5676 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5677
5678         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5679         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5680         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5681         the trailing '.' is not output, and the first character is uppercased.
5682         (print_help_for_command): Update call to print_doc_line.
5683         (print_doc_of_command): Likewise.
5684         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5685         * cli/cli-option.c (append_indented_doc): Do not append newline.
5686         (build_help_option): Append newline after first appended_indented_doc
5687         only if a second call is done.
5688         (build_help): Append 2 new lines before each option, except the first
5689         one.
5690         * compile/compile.c (_initialize_compile): Add new lines after
5691         %OPTIONS%, when not at the end of the help.
5692         Change help doc or code
5693         producing the help doc to respect the invariants.
5694         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5695         Also removed the new line after 'Options:', as all other commands
5696         do not put an empty line between 'Options:' and the first option.
5697         * printcmd.c (_initialize_printcmd): Likewise.
5698         * stack.c (_initialize_stack): Likewise.
5699         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5700         incorrectly telling COMMAND is optional.
5701         * ada-lang.c (_initialize_ada_language): Change help doc or code
5702         producing the help doc to respect the invariants.
5703         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5704         * breakpoint.c (_initialize_breakpoint): Likewise.
5705         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5706         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5707         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5708         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5709         _initialize_cli_style): Likewise.
5710         * corelow.c (core_target_info): Likewise.
5711         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5712         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5713         * filesystem.c (_initialize_filesystem): Likewise.
5714         * frame.c (_initialize_frame): Likewise.
5715         * gnu-nat.c (add_task_commands): Likewise.
5716         * infcall.c (_initialize_infcall): Likewise.
5717         * infcmd.c (_initialize_infcmd): Likewise.
5718         * interps.c (_initialize_interpreter): Likewise.
5719         * language.c (_initialize_language): Likewise.
5720         * linux-fork.c (_initialize_linux_fork): Likewise.
5721         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5722         * maint.c (_initialize_maint_cmds): Likewise.
5723         * memattr.c (_initialize_mem): Likewise.
5724         * printcmd.c (_initialize_printcmd): Likewise.
5725         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5726         _RegEx): Likewise.
5727         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5728         * record-btrace.c (_initialize_record_btrace): Likewise.
5729         * record-full.c (_initialize_record_full): Likewise.
5730         * record.c (_initialize_record): Likewise.
5731         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5732         * regcache.c (_initialize_regcache): Likewise.
5733         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5734         _initialize_remote): Likewise.
5735         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5736         * serial.c (_initialize_serial): Likewise.
5737         * skip.c (_initialize_step_skip): Likewise.
5738         * source.c (_initialize_source): Likewise.
5739         * stack.c (_initialize_stack): Likewise.
5740         * symfile.c (_initialize_symfile): Likewise.
5741         * symtab.c (_initialize_symtab): Likewise.
5742         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5743         * top.c (init_main): Likewise.
5744         * tracefile-tfile.c (tfile_target_info): Likewise.
5745         * tracepoint.c (_initialize_tracepoint): Likewise.
5746         * tui/tui-win.c (_initialize_tui_win): Likewise.
5747         * utils.c (add_internal_problem_command): Likewise.
5748         * valprint.c (value_print_option_defs): Likewise.
5749
5750 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5751
5752         PR build/24886
5753         * configure.ac: Drop enable-libmcheck support.
5754         * configure, config.in: Rebuild.
5755         * libmcheck.m4: Remove.
5756         * acinclude.m4: Don't include it.
5757         * Makefile.in: Don't distribute it.
5758         * top.c (print_gdb_configuration): Don't mention it.
5759
5760 2019-08-06  Tom Tromey  <tom@tromey.com>
5761
5762         * utils.c (set_output_style): Sometimes pass stream to
5763         emit_style_escape.
5764         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5765         * record-btrace.c (btrace_insn_history): Update.
5766         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5767         method.
5768         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5769         Update initializers.
5770         <m_uiout>: New field.
5771         <m_di>: Move lower.
5772         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5773         Remove "uiout" parameter.
5774         (dump_insns): Update.
5775         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5776         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5777
5778 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5779
5780         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5781         (error_in_psymtab_expansion): Likewise.
5782         (lookup_symbol_via_quick_fns): Likewise.
5783         (basic_lookup_transparent_type_quick): Likewise.
5784         (basic_lookup_transparent_type_1): Likewise.
5785
5786 2019-08-06  Tom Tromey  <tromey@adacore.com>
5787
5788         * source.c (last_source_error): Now bool.
5789         (print_source_lines_base): Make "noprint" bool.  Only open
5790         source file when last_source_visited changes.
5791
5792 2019-08-06  Tom Tromey  <tromey@adacore.com>
5793
5794         * annotate.c (annotate_source_line): Use g_source_cache.
5795         * source-cache.c (source_cache::get_plain_source_lines): Change
5796         parameters.  Populate m_offset_cache.
5797         (source_cache::ensure): New method.
5798         (source_cache::get_line_charpos): New method.
5799         (extract_lines): Move lower.  Change parameters.
5800         (source_cache::get_source_lines): Move lower.
5801         * source-cache.h (class source_cache): Update comment.
5802         <get_line_charpos>: New method.
5803         <get_source_lines>: Update comment.
5804         <clear>: Clear m_offset_cache.
5805         <get_plain_source_lines>: Change parameters.
5806         <ensure>: New method
5807         <m_offset_cache>: New member.
5808         * source.c (forget_cached_source_info_for_objfile): Update.
5809         (info_source_command): Use g_source_cache.
5810         (find_source_lines, open_source_file_with_line_charpos): Remove.
5811         (print_source_lines_base, search_command_helper): Use g_source_cache.
5812         * source.h (open_source_file_with_line_charpos): Don't declare.
5813         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5814         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5815         Use g_source_cache.
5816
5817 2019-08-06  Tom Tromey  <tromey@adacore.com>
5818
5819         * source-cache.c (source_cache::get_plain_source_lines):
5820         Remove "first_line" and "last_line" parameters.
5821         (source_cache::get_source_lines): Cache plain text.
5822         * source-cache.h (class source_cache)
5823         <get_plain_source_lines>: Update.
5824
5825 2019-08-06  Tom Tromey  <tromey@adacore.com>
5826
5827         * source-cache.c (extract_lines): No longer a method.
5828         Changed type of parameter.  Include final newline.
5829         (selftests::extract_lines_test): New function.
5830         (_initialize_source_cache): Likewise.
5831         * source-cache.h (class source_cache)
5832         <extract_lines>: Don't declare.
5833
5834 2019-08-06  Tom Tromey  <tromey@adacore.com>
5835
5836         * breakpoint.c (init_breakpoint_sal): Update.
5837         (breakpoint): Update.
5838         * breakpoint.h (struct breakpoint) <filter>: Now a
5839         unique_xmalloc_ptr.
5840
5841 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5842
5843         * NEWS: Mention dictionary access on blocks.
5844         * python/py-block.c (blpy_getitem): New function.
5845         (block_object_as_mapping): New struct.
5846         (block_object_type): Use new struct for tp_as_mapping field.
5847
5848 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5849
5850         * objfiles.h (objfile): Add a comment describing partial symbols.
5851
5852 2019-08-05  Tom Tromey  <tromey@adacore.com>
5853
5854         * compile/compile.c (_initialize_compile): Use _(), not N_().
5855         * thread.c (_initialize_thread): Use _(), not N_().
5856         * stack.c (_initialize_stack): Use _(), not N_().
5857         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5858
5859 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5860
5861         * dwarf2read.c (struct dw2_symtab_iterator):
5862         <want_specific_block>: Remove.
5863         <block_index>: Change type to gdb::optional.
5864         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5865         change type of BLOCK_INDEX parameter to gdb::optional.
5866         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5867         (dw2_lookup_symbol): Don't pass argument for
5868         WANT_SPECIFIC_BLOCK.
5869         (dw2_expand_symtabs_for_function): Don't pass argument for
5870         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5871         (class dw2_debug_names_iterator)
5872         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5873         parameter, change BLOCK_INDEX type to gdb::optional.
5874         <m_want_specific_block>: Remove.
5875         <m_block_index>: Change type to gdb::optional.
5876         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5877         gdb::optional.  Re-write in function of gdb::optional.
5878         (dw2_debug_names_lookup_symbol): Don't pass argument for
5879         WANT_SPECIFIC_BLOCK.
5880         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5881         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5882         BLOCK_INDEX.
5883
5884 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5885
5886         * NEWS: Mention changes to "info sources" command.
5887
5888 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5889
5890         * symtab.c (filename_partial_match_opts): New struct type.
5891         (struct output_source_filename_data): New members
5892         regexp, c_regexp, partial_match.
5893         (output_source_filename): Use new members to decide to print file.
5894         (info_sources_option_defs): New variable.
5895         (make_info_sources_options_def_group, print_info_sources_header,
5896         info_sources_command_completer):
5897         New functions.
5898         (info_sources_command): Read new optional arguments.
5899         (_initialize_symtab): Update info sources help.
5900
5901 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5902
5903         * ada-lang.c (exception_support_info_v0): Renamed from...
5904         (default_exception_support_info): ... this.  Create new
5905         definition for v1.
5906         (ada_has_this_exception_support): Look up catch_handlers_sym.
5907         (ada_exception_support_info_sniffer): Try v0 after default.
5908
5909 2019-08-01  Tom Tromey  <tromey@adacore.com>
5910
5911         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5912         gdbarch.h.
5913
5914 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5915
5916         * s12z-tdep.c: Fix include path for s12z-opc.h.
5917
5918 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5919
5920         * NEWS: Require GNU make 3.82.
5921
5922 2019-07-16  Tom Tromey  <tom@tromey.com>
5923
5924         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5925         declare.
5926
5927 2019-07-30  Tom Tromey  <tromey@adacore.com>
5928
5929         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5930
5931 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5932
5933         * printcmd.c (print_address_symbolic): Print negative offsets.
5934         (build_address_symbolic): Force signed arithmetic when computing
5935         offset.
5936
5937 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5938
5939         PR/24474: Add a function to lookup static variables.
5940         * NEWS: Mention this new function.
5941         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5942         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5943         * python/python.c (python_GdbMethods): Add new function.
5944
5945 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5946
5947         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5948         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5949         (objfpy_lookup_static_symbol): New function.
5950         (objfile_object_methods): Add new functions.
5951
5952 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5953
5954         * NEWS: Mention 'set|show print frame-info'.  Mention new
5955         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5956         backtrace argument.  Mention that python frame filtering code
5957         is now consistent with what 'backtrace' command prints.
5958
5959 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5960
5961         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5962         comments.
5963         (print_frame_info_auto, print_frame_info_source_line,
5964         print_frame_info_location, print_frame_info_source_and_location,
5965         print_frame_info_location_and_address, print_frame_info_short_location):
5966         New declarations.
5967         (struct frame_print_options): New member print_frame_info.
5968         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5969         * stack.h (get_user_print_what_frame_info): New declaration.
5970         (frame_show_address): New declaration.
5971         * stack.c (print_frame_arguments_choices): New value 'presence'.
5972         (print_frame_info_auto, print_frame_info_source_line,
5973         print_frame_info_location, print_frame_info_source_and_location,
5974         print_frame_info_location_and_address, print_frame_info_short_location,
5975         print_frame_info_choices, print_frame_info_print_what): New definitions.
5976         (print_frame_args): Only print dots for args if print frame-arguments
5977         is 'presence'.
5978         (frame_print_option_defs): New element for "frame-info".
5979         (get_user_print_what_frame_info): New function.
5980         (frame_show_address): Make non static.  Move comment to stack.h.
5981         (print_frame_info_to_print_what): New function.
5982         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5983         to decide what to print.
5984         (backtrace_command_1): Handle the new print_frame_arguments_presence
5985         value.
5986         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5987         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5988         (py_print_frame): In non-mi mode, use LOCATION as default for
5989         print_what, similarly to frame information printed directly by
5990         backtrace command. Handle frame-info user option in non MI mode.
5991
5992 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5993
5994         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5995         Add case for debugging 32-bit target on 64-bit host.  Revise
5996         comment.
5997
5998 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5999
6000         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6001         instead of find_function_entry_range_from_pc.
6002
6003 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6004
6005         * stack.c (find_frame_funname): Remove code which preferred
6006         minsym over symtab sym in "certain pathological cases".
6007
6008         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6009         parameter.  Change type of "do_demangle" to bool.
6010         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6011         Pass suitable "prefer_sym_over_minsym" flag to
6012         build_address_symbolic().  Don't output "+" for negative offsets.
6013         * printcmd.c (print_address_symbolic): Update invocation of
6014         build_address_symbolic to include a "prefer_sym_over_minsym"
6015         flag.
6016         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6017         Restrict cases in which use of minimal symbol is preferred to that
6018         of a found symbol.  Update comments.
6019
6020         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6021         for entry pc when entry pc is out of range for that FDE.
6022
6023 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6024
6025         PR gdb/24839:
6026         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6027         type.
6028
6029 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6030
6031         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6032         this function's Python signature.
6033
6034
6035 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6036
6037         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6038         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6039         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6040         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6041         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6042
6043
6044 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6045
6046         * h8300-tdep.c (h8300_register_name_common): New.
6047         h8300_register_name): Use h8300_register_name_common.
6048         (h8300s_register_name): Likewise.
6049         (h8300sx_register_name): Likewise.
6050         (h8300h_register_nam): New.
6051         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6052
6053
6054 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6055
6056         * arm-tdep.c (arm_skip_cmse_entry): New function.
6057         (arm_is_sgstubs_section): New function.
6058         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6059
6060 2019-07-22  Tom Tromey  <tom@tromey.com>
6061
6062         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6063         Don't self-assign.
6064
6065 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6066
6067         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6068         type_print.
6069
6070 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6071
6072         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6073         so that GDB doesn't match any msymbols when searching in the
6074         TYPES_DOMAIN.
6075         (print_symbol_info): Print using typedef_print or type_print based
6076         on the type of the symbol.  Add updated FIXME comment moved from...
6077         (_initialize_symtab): ... move and update FIXME comment to above.
6078
6079 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6080
6081         * NEWS: Mention adding -q option to "info types".
6082         * symtab.c (struct info_types_options): New struct.
6083         (info_types_options_defs): New variable.
6084         (make_info_types_options_def_group): New function.
6085         (info_types_command): Use gdb::option framework to parse options.
6086         (info_types_command_completer): New function.
6087         (_initialize_symtab): Extend the help text on "info types" and
6088         register command completer.
6089
6090 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6091
6092         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6093         (lookup_symbol_in_objfile): Change int to block_enum and add a
6094         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6095
6096 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6097
6098         * MAINTAINERS (Write After Approval): Add self.
6099
6100 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6101
6102         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6103         instruction to the dummy code region.
6104
6105 2019-07-19  Tom Tromey  <tromey@adacore.com>
6106
6107         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6108         (ARGSUSED, PARAMS, __func__): Remove rules.
6109
6110 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6111
6112         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6113         * features/arm/arm-with-iwmmxt.c: Remove.
6114         * features/arm/arm-with-iwmmxt.xml: Remove.
6115         * features/arm/arm-with-m-fpa-layout.c: Remove.
6116         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6117         * features/arm/arm-with-m-vfp-d16.c: Remove.
6118         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6119         * features/arm/arm-with-m.c: Remove.
6120         * features/arm/arm-with-m.xml: Remove.
6121         * features/arm/arm-with-neon.c: Remove.
6122         * features/arm/arm-with-neon.xml: Remove.
6123         * features/arm/arm-with-vfpv2.c: Remove.
6124         * features/arm/arm-with-vfpv2.xml: Remove.
6125         * features/arm/arm-with-vfpv3.c: Remove.
6126         * features/arm/arm-with-vfpv3.xml: Remove.
6127
6128 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6129
6130         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6131
6132 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6133
6134         * arch/aarch32.c (aarch32_create_target_description): Create
6135         target descriptions using features.
6136         * arch/arm.c (arm_create_target_description)
6137         (arm_create_mprofile_target_description): Likewise.
6138         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6139
6140 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6141
6142         * Makefile.in: Add new files.
6143         * aarch32-tdep.c: New file.
6144         * aarch32-tdep.h: New file.
6145         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6146         Call aarch32_read_description.
6147         * arch/aarch32.c: New file.
6148         * arch/aarch32.h: New file.
6149         * arch/arm.c (arm_create_target_description)
6150         (arm_create_mprofile_target_description): New function.
6151         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6152         (arm_create_target_description)
6153         (arm_create_mprofile_target_description): New declaration.
6154         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6155         read_description functions.
6156         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6157         Likewise.
6158         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6159         * arm-tdep.c (tdesc_arm_list): New variable.
6160         (arm_register_g_packet_guesses): Call create description functions.
6161         (arm_read_description) (arm_read_mprofile_description): New
6162         function.
6163         * arm-tdep.h (arm_read_description)
6164         (arm_read_mprofile_description): Add declaration.
6165         * configure.tgt: Add new files.
6166
6167 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6168
6169         * top.c (new_ui_command): Open specified terminal just once.
6170
6171 2019-07-18  Tom Tromey  <tromey@adacore.com>
6172
6173         * symtab.c (main_name): Constify return type.
6174         * symfile.c (set_initial_language): Update.
6175         * symtab.h (main_name): Constify return type.
6176
6177 2019-07-17  Tom Tromey  <tom@tromey.com>
6178
6179         * tui/tui-winsource.c (tui_update_source_window)
6180         (tui_update_source_window_as_is)
6181         (tui_update_source_windows_with_line): Remove return.
6182         * tui/tui-disasm.c (tui_show_disassem)
6183         (tui_show_disassem_and_update_source): Remove return.
6184         * tui/tui.c (tui_reset): Remove return.
6185         * tui/tui-wingeneral.c
6186         (tui_check_and_display_highlight_if_needed): Remove return.
6187
6188 2019-07-17  Tom Tromey  <tom@tromey.com>
6189
6190         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6191
6192 2019-07-17  Tom Tromey  <tom@tromey.com>
6193
6194         * tui/tui-winsource.h (struct tui_exec_info_window)
6195         (struct tui_source_window_base): Move from tui-data.h.
6196         * tui/tui-winsource.c: Move many method definitions from
6197         elsewhere.  Remove "structuring" comments.
6198         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6199         (tui_source_window_base::refresh_window): Move to
6200         tui-winsource.c.
6201         * tui/tui-win.c (tui_source_window_base::refresh_all)
6202         (tui_source_window_base::update_tab_width)
6203         (tui_source_window_base::set_new_height)
6204         (tui_source_window_base::do_make_visible_with_new_height): Move to
6205         tui-winsource.c.
6206         * tui/tui-source.h: Update.
6207         * tui/tui-source.c (tui_source_window_base::reset): Move to
6208         tui-winsource.c.
6209         * tui/tui-disasm.h: Update.
6210         * tui/tui-data.h (struct tui_exec_info_window): Move to
6211         tui-winsource.h.
6212         (struct tui_source_window_base): Likewise.
6213         * tui/tui-data.c (tui_source_window_base::clear_detail)
6214         (tui_source_window_base, ~tui_source_window_base): Move to
6215         tui-winsource.c.
6216
6217 2019-07-17  Tom Tromey  <tom@tromey.com>
6218
6219         * tui/tui-win.c (tui_resize_all)
6220         (tui_source_window_base::update_tab_width)
6221         (tui_adjust_win_heights): Update.
6222         (tui_win_info::make_invisible_and_set_new_height): Rename from
6223         make_invisible_and_set_new_height.
6224         * tui/tui-data.h (struct tui_win_info)
6225         <make_invisible_and_set_new_height>: New method.
6226
6227 2019-07-17  Tom Tromey  <tom@tromey.com>
6228
6229         * tui/tui.c: Update.
6230         * tui/tui-source.h (struct tui_source_window): Move from
6231         tui-data.h.
6232         * tui/tui-layout.c: Update.
6233         * tui/tui-disasm.c: Update.
6234         * tui/tui-data.h (struct tui_source_window): Move to
6235         tui-source.h.
6236
6237 2019-07-17  Tom Tromey  <tom@tromey.com>
6238
6239         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6240         tui-data.h.
6241         * tui/tui-data.h (struct tui_disasm_window): Move to
6242         tui-disasm.h.
6243
6244 2019-07-17  Tom Tromey  <tom@tromey.com>
6245
6246         * tui/tui-regs.h (struct tui_data_item_window): Move from
6247         tui-data.h.
6248         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6249         * tui/tui-data.h (struct tui_data_item_window): Move to
6250         tui-regs.h.
6251         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6252
6253 2019-07-17  Tom Tromey  <tom@tromey.com>
6254
6255         * tui/tui.c: Update.
6256         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6257         (tui_cmd_window::max_height): Move to tui-command.c.
6258         * tui/tui-layout.c: Update.
6259         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6260         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6261         tui-command.c.
6262         * tui/tui-command.h (struct tui_cmd_window): Move from
6263         tui-data.h.
6264         * tui/tui-command.c: Remove "structuring" comments.
6265         (tui_cmd_window::clear_detail)
6266         (tui_cmd_window::do_make_visible_with_new_height)
6267         (tui_cmd_window::max_height): Move from elsewhere.
6268
6269 2019-07-17  Tom Tromey  <tom@tromey.com>
6270
6271         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6272         Now static.
6273         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6274         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6275
6276 2019-07-17  Tom Tromey  <tom@tromey.com>
6277
6278         * tui/tui.c: Update.
6279         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6280         tui-regs.c.
6281         * tui/tui-windata.h: Remove file.
6282         * tui/tui-windata.c: Remove file.
6283         * tui/tui-win.c (tui_data_window::set_new_height)
6284         (tui_data_window::do_make_visible_with_new_height): Move to
6285         tui-regs.c.
6286         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6287         * tui/tui-regs.c: Remove "structuring" comments.
6288         (tui_data_window::first_data_item_displayed)
6289         (tui_data_window::delete_data_content_windows)
6290         (tui_data_window::erase_data_content)
6291         (tui_data_window::display_all_data)
6292         (tui_data_window::refresh_all)
6293         (tui_data_window::do_scroll_vertical)
6294         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6295         (tui_data_window::do_make_visible_with_new_height)
6296         (tui_data_window::refresh_window): Move from elsewhere.
6297         (_initialize_tui_regs): Move to end of file.
6298         * tui/tui-layout.c: Update.
6299         * tui/tui-hooks.c: Update.
6300         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6301         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6302         tui-regs.c.
6303         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6304
6305 2019-07-17  Tom Tromey  <tom@tromey.com>
6306
6307         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6308         seen.
6309
6310 2019-07-17  Tom Tromey  <tom@tromey.com>
6311
6312         * tui/tui-win.c (tui_source_window_base::set_new_height)
6313         (tui_source_window_base::do_make_visible_with_new_height): Use
6314         m_has_locator field directly.
6315         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6316         method.
6317         (struct tui_source_window_base) <has_locator>: Likewise.
6318
6319 2019-07-17  Tom Tromey  <tom@tromey.com>
6320
6321         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6322         Don't declare.
6323         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6324         Remove.
6325         * tui/tui-win.c (tui_source_window_base::set_new_height)
6326         (tui_source_window_base::set_new_height)
6327         (make_invisible_and_set_new_height)
6328         (tui_source_window_base::do_make_visible_with_new_height)
6329         (tui_source_window_base::do_make_visible_with_new_height):
6330         Update.
6331         * tui/tui-layout.c (show_source_disasm_command, show_data)
6332         (show_source_or_disasm_and_command): Update.
6333         * tui/tui-layout.c (show_layout): Update.
6334
6335 2019-07-17  Tom Tromey  <tom@tromey.com>
6336
6337         * tui/tui-layout.c (make_data_window): Remove.
6338         (show_data): Unify creation and re-initialization cases.
6339
6340 2019-07-17  Tom Tromey  <tom@tromey.com>
6341
6342         * tui/tui-layout.c (make_source_window, make_disasm_window):
6343         Remove.
6344         (show_data): Unify creation and re-initialization cases.
6345
6346 2019-07-17  Tom Tromey  <tom@tromey.com>
6347
6348         * tui/tui-layout.c (make_command_window): Remove.
6349         (show_source_disasm_command, show_source_or_disasm_and_command):
6350         Unify creation and re-initialization cases.
6351
6352 2019-07-17  Tom Tromey  <tom@tromey.com>
6353
6354         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6355         creation and re-initialization cases.
6356
6357 2019-07-17  Tom Tromey  <tom@tromey.com>
6358
6359         * tui/tui-regs.c (tui_get_register): Return void.
6360
6361 2019-07-17  Tom Tromey  <tom@tromey.com>
6362
6363         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6364         Simplify.
6365
6366 2019-07-17  Tom Tromey  <tom@tromey.com>
6367
6368         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6369         resetting.
6370
6371 2019-07-17  Tom Tromey  <tom@tromey.com>
6372
6373         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6374         * tui/tui-regs.c (tui_reg_layout): New function.
6375         (tui_show_registers, tui_reg_command): Use it.
6376         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6377         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6378         parameters.
6379         (tui_layout_command): Remove.
6380
6381 2019-07-17  Tom Tromey  <tom@tromey.com>
6382
6383         * tui/tui-layout.h (tui/tui-layout): Return void.
6384         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6385
6386 2019-07-17  Tom Tromey  <tom@tromey.com>
6387
6388         * tui/tui-layout.c (show_source_disasm_command, show_data):
6389         Update.
6390         (reset_locator): Remove.
6391         (show_source_or_disasm_and_command): Update.
6392
6393 2019-07-17  Tom Tromey  <tom@tromey.com>
6394
6395         * tui/tui-source.c (tui_source_window_base::reset): Remove
6396         win_type parameter.
6397         * tui/tui-layout.c (make_command_window, make_source_window)
6398         (make_disasm_window, make_data_window)
6399         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6400         (reset_locator, show_source_or_disasm_and_command): Update.
6401         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6402         win_type parameter.
6403         (struct tui_source_window_base) <reset>: Likewise.
6404
6405 2019-07-17  Tom Tromey  <tom@tromey.com>
6406
6407         * tui/tui-layout.c (show_source_disasm_command): Use
6408         reset_locator.
6409         (reset_locator): New function.
6410         (init_and_make_win): Remove.
6411         (show_source_or_disasm_and_command): Use reset_locator.
6412
6413 2019-07-17  Tom Tromey  <tom@tromey.com>
6414
6415         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6416         condition.
6417         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6418         Remove condition.
6419         * tui/tui-source.c (tui_source_window_base::reset): New method.
6420         * tui/tui-layout.c (make_command_window): Don't call
6421         init_and_make_win.
6422         (make_source_window, make_disasm_window): Don't call
6423         make_source_or_disasm_window.
6424         (make_data_window): Don't call init_and_make_win.  Change calling
6425         convention.
6426         (show_source_disasm_command, show_data): Simplify.
6427         (make_source_or_disasm_window): Remove.
6428         (show_source_or_disasm_and_command): Simplify.
6429         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6430         (struct tui_source_window_base) <reset>: Likewise.
6431         <execution_info>: Remove initializer.
6432         * tui/tui-data.c (tui_source_window_base): Initialize
6433         execution_info.
6434
6435 2019-07-17  Tom Tromey  <tom@tromey.com>
6436
6437         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6438         variable.
6439
6440 2019-07-17  Tom Tromey  <tom@tromey.com>
6441
6442         * tui/tui.c (tui_rl_other_window): Update.
6443         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6444         superclass method first.  Always iterate over regs_content.
6445         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6446         method.
6447         * tui/tui-win.c (tui_set_focus_command): Update.
6448
6449 2019-07-17  Tom Tromey  <tom@tromey.com>
6450
6451         * tui/tui-win.c (tui_set_focus_command): Rename from
6452         tui_set_focus.  Call tui_enable.
6453         (tui_set_focus_command): Remove.
6454
6455 2019-07-17  Tom Tromey  <tom@tromey.com>
6456
6457         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6458         refresh_window.
6459         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6460         touchwin.
6461         (tui_data_window::refresh_window): Call refresh_window on data
6462         items.  Always call superclass refresh_window.
6463         (tui_win_info::refresh): Remove.
6464         (tui_source_window_base::refresh_window): Update.
6465         (tui_refresh_all): Update.
6466         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6467         refresh_window.
6468         (show_source_or_disasm_and_command): Likewise.
6469         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6470         (struct tui_source_window_base) <refresh>: Likewise.
6471
6472 2019-07-17  Tom Tromey  <tom@tromey.com>
6473
6474         * tui/tui-winsource.c (tui_clear_source_content)
6475         (tui_show_source_content): Update.
6476         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6477         whether content is empty.
6478         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6479         Remove.
6480
6481 2019-07-17  Tom Tromey  <tom@tromey.com>
6482
6483         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6484         window's contents.
6485         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6486         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6487
6488 2019-07-17  Tom Tromey  <tom@tromey.com>
6489
6490         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6491         (struct tui_data_item_window): Update.
6492
6493 2019-07-17  Tom Tromey  <tom@tromey.com>
6494
6495         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6496         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6497         defines.
6498
6499 2019-07-17  Tom Tromey  <tom@tromey.com>
6500
6501         * tui/tui-winsource.h (tui_erase_source_content)
6502         (tui_clear_source_content): Remove "display_prompt" parameter.
6503         * tui/tui-winsource.c (tui_update_source_window_as_is)
6504         (tui_update_source_windows_with_addr): Update.
6505         (tui_clear_source_content): Remove "display_prompt" parameter.
6506         (tui_erase_source_content): Likewise.  Simplify.
6507         (tui_show_source_content): Update.
6508         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6509         * tui/tui-stack.c (tui_show_frame_info): Update.
6510         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6511         Remove defines.
6512
6513 2019-07-17  Tom Tromey  <tom@tromey.com>
6514
6515         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6516         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6517         parameter.
6518         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6519         parameter.
6520
6521 2019-07-17  Tom Tromey  <tom@tromey.com>
6522
6523         * tui/tui-winsource.c (tui_clear_source_content)
6524         (tui_show_source_content, tui_show_exec_info_content)
6525         (tui_clear_exec_info_content): Update.
6526         * tui/tui-stack.c (tui_show_locator_content): Update.
6527         (tui_show_frame_info): Update.
6528         * tui/tui-source.h (tui_source_window): Don't declare.
6529         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6530         from tui_source_is_displayed.
6531         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6532         Remove field.
6533         (struct tui_source_window_base) <content_in_use>: New field.  Now
6534         bool.
6535         (struct tui_source_window) <showing_source_p>: New method.
6536         (TUI_SRC_WIN): Change cast.
6537         * tui/tui-data.c (tui_initialize_static_data): Update.
6538
6539 2019-07-17  Tom Tromey  <tom@tromey.com>
6540
6541         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6542         location_matches_p.
6543         * tui/tui-source.c (tui_source_window::location_matches_p): New
6544         method.
6545         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6546         method.
6547         * tui/tui-data.h (struct tui_source_window_base)
6548         <location_matches_p>: New method.
6549         (struct tui_source_window, struct tui_disasm_window)
6550         <location_matches_p>: Likewise.
6551
6552 2019-07-17  Tom Tromey  <tom@tromey.com>
6553
6554         * tui/tui-win.c (tui_set_win_height_command): Rename from
6555         tui_set_win_height.
6556         (tui_set_win_height_command): Remove.
6557
6558 2019-07-17  Tom Tromey  <tom@tromey.com>
6559
6560         * tui/tui-source.c (tui_source_window): New constructor.  Add
6561         observer.
6562         (~tui_source_window): New destructor.
6563         (tui_source_window::style_changed): New method.
6564         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6565         (tui_attach_detach_observers): Update.
6566         * tui/tui-data.h (struct tui_source_window): Make constructor not
6567         inline.  Add destructor.
6568         (struct tui_source_window) <style_changed>: New method.
6569         <m_observable>: New member.
6570
6571 2019-07-17  Tom Tromey  <tom@tromey.com>
6572
6573         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6574         * tui/tui-win.c (tui_resize_all): Fix typo.
6575
6576 2019-07-17  Tom Tromey  <tom@tromey.com>
6577
6578         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6579         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6580         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6581         * tui/tui-win.c (window_name_completer): Use foreach.
6582         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6583         (update_tab_width): Likewise.
6584         * tui/tui-layout.c (show_layout): Update.
6585         * tui/tui-data.h (class tui_window_iterator): New.
6586         (struct all_tui_windows): New.
6587         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6588
6589 2019-07-17  Tom Tromey  <tom@tromey.com>
6590
6591         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6592         parameter.  Don't reference globals.
6593         (tui_reg_command): Update.
6594
6595 2019-07-17  Tom Tromey  <tom@tromey.com>
6596
6597         * tui/tui-regs.c (tui_show_registers): Simplify.
6598
6599 2019-07-17  Tom Tromey  <tom@tromey.com>
6600
6601         * tui/tui-regs.c (tui_show_registers): Update.
6602         (tui_show_register_group): Add win_info parameter.
6603
6604 2019-07-17  Tom Tromey  <tom@tromey.com>
6605
6606         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6607         Rename from tui_display_reg_element_at_line.
6608         (tui_data_window::display_registers_from_line): Update.
6609         * tui/tui-data.h (struct tui_data_window)
6610         <display_reg_element_at_line>: New method.
6611
6612 2019-07-17  Tom Tromey  <tom@tromey.com>
6613
6614         * tui/tui-regs.h (tui_display_registers_from)
6615         (tui_display_registers_from_line): Don't declare.
6616         * tui/tui-windata.c (tui_data_window::display_all_data)
6617         (tui_data_window::refresh_all)
6618         (tui_data_window::do_scroll_vertical): Update.
6619         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6620         from tui_display_registers_from.
6621         (tui_display_reg_element_at_line): Update.
6622         (tui_data_window::display_registers_from_line): Rename from
6623         tui_display_registers_from_line.
6624         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6625         display_registers_from_line>: New methods.
6626
6627 2019-07-17  Tom Tromey  <tom@tromey.com>
6628
6629         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6630         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6631         from tui_erase_data_content.
6632         (tui_data_window::display_all_data)
6633         (tui_data_window::refresh_all)
6634         (tui_data_window::do_scroll_vertical): Update.
6635         * tui/tui-regs.c (tui_show_registers): Update.
6636         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6637         New method.
6638
6639 2019-07-17  Tom Tromey  <tom@tromey.com>
6640
6641         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6642         declare.
6643         * tui/tui-windata.c
6644         (tui_data_window::delete_data_content_windows): Rename from
6645         tui_delete_data_content_windows.
6646         (tui_data_window::display_all_data)
6647         (tui_data_window::do_scroll_vertical): Update.
6648         * tui/tui-data.h (struct tui_data_window)
6649         <delete_data_content_windows>: New method.
6650
6651 2019-07-17  Tom Tromey  <tom@tromey.com>
6652
6653         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6654         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6655
6656 2019-07-17  Tom Tromey  <tom@tromey.com>
6657
6658         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6659         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6660         from tui_display_all_data.
6661         * tui/tui-win.c
6662         (tui_data_window::do_make_visible_with_new_height): Update.
6663         * tui/tui-regs.c (tui_show_registers): Update.
6664         * tui/tui-layout.c (tui_set_layout): Update.
6665         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6666         method.
6667
6668 2019-07-17  Tom Tromey  <tom@tromey.com>
6669
6670         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6671         * tui/tui-windata.c (tui_display_data_from): Remove.
6672         (tui_data_window::refresh_all): Update.
6673
6674 2019-07-17  Tom Tromey  <tom@tromey.com>
6675
6676         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6677         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6678         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6679         tui_display_registers_from_line.
6680         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6681         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6682         "force_display" parameter.
6683
6684 2019-07-17  Tom Tromey  <tom@tromey.com>
6685
6686         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6687         declare.
6688         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6689         Rename from tui_first_reg_element_no_inline.
6690         (tui_display_reg_element_at_line)
6691         (tui_display_registers_from_line): Update.
6692         * tui/tui-data.h (struct tui_data_window)
6693         <first_reg_element_no_inline>: New method.
6694
6695 2019-07-17  Tom Tromey  <tom@tromey.com>
6696
6697         * tui/tui-windata.c (tui_display_data_from)
6698         (tui_data_window::do_scroll_vertical): Update.
6699         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6700         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6701         Rename from tui_line_from_reg_element_no.
6702         (tui_display_registers_from_line): Update.
6703         * tui/tui-data.h (struct tui_data_window)
6704         <line_from_reg_element_no>: New method.
6705
6706 2019-07-17  Tom Tromey  <tom@tromey.com>
6707
6708         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6709         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6710         tui_last_regs_line_no.
6711         (tui_display_reg_element_at_line)
6712         (tui_display_registers_from_line): Update.
6713         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6714         method.
6715
6716 2019-07-17  Tom Tromey  <tom@tromey.com>
6717
6718         PR tui/24722:
6719         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6720         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6721         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6722         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6723         (tui_update_breakpoint_info): Likewise.
6724         * tui/tui-hooks.c (tui_event_create_breakpoint)
6725         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6726         Update.
6727
6728 2019-07-17  Tom Tromey  <tom@tromey.com>
6729
6730         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6731
6732 2019-07-17  Tom Tromey  <tom@tromey.com>
6733
6734         * tui/tui-winsource.c (tui_update_source_window_as_is)
6735         (tui_update_source_windows_with_addr): Update.
6736         * tui/tui-source.h (tui_set_source_content)
6737         (tui_show_symtab_source): Add "win_info" parameter.
6738         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6739         parameter.
6740         (tui_show_symtab_source): Likewise.
6741
6742 2019-07-17  Tom Tromey  <tom@tromey.com>
6743
6744         * tui/tui-wingeneral.c
6745         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6746
6747 2019-07-17  Tom Tromey  <tom@tromey.com>
6748
6749         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6750         (struct tui_cmd_window) <can_scroll>: New method.
6751         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6752         method.
6753
6754 2019-07-17  Tom Tromey  <tromey@adacore.com>
6755
6756         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6757         do_field_signed>: Rename.  Change type of "value".
6758         * ui-out.c (ui_out::field_signed): Rename from field_int.
6759         Change type of "value".
6760         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6761         type of "value".
6762         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6763         do_field_int.  Change type of "value".
6764         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6765         do_field_int.  Change type of "value".
6766         * tracepoint.c (trace_status_mi, tfind_1)
6767         (print_one_static_tracepoint_marker): Update.
6768         * thread.c (print_thread_info_1, print_selected_thread_frame):
6769         Update.
6770         * stack.c (print_frame, print_frame_info): Update.
6771         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6772         Update.
6773         * source.c (print_source_lines_base): Update.
6774         * skip.c (info_skip_command): Update.
6775         * record-btrace.c (btrace_ui_out_decode_error)
6776         (btrace_call_history_src_line): Update.
6777         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6778         Update.
6779         * progspace.c (print_program_space): Update.
6780         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6781         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6782         do_field_int.  Change type of "value".
6783         * mi/mi-out.c (mi_ui_out::do_table_begin)
6784         (mi_ui_out::do_table_header): Update.
6785         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6786         type of "value".
6787         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6788         (mi_cmd_data_list_changed_registers, output_register)
6789         (mi_cmd_data_read_memory, mi_load_progress)
6790         (mi_cmd_trace_frame_collected): Update.
6791         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6792         Update.
6793         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6794         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6795         (mi_cmd_var_list_children, varobj_update_one): Update.
6796         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6797         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6798         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6799         * inferior.c (print_inferior): Update.
6800         * gdb_bfd.c (print_one_bfd): Update.
6801         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6802         Update.
6803         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6804         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6805         do_field_int.  Change type of "value".
6806         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6807         do_field_int.  Change type of "value".
6808         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6809         (print_one_breakpoint_location, print_it_catch_fork)
6810         (print_one_catch_fork, print_it_catch_vfork)
6811         (print_one_catch_vfork, print_it_catch_solib)
6812         (print_it_catch_exec, print_it_ranged_breakpoint)
6813         (print_mention_watchpoint, print_mention_masked_watchpoint)
6814         (bkpt_print_it, update_static_tracepoint): Update.
6815         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6816         * break-catch-syscall.c (print_it_catch_syscall): Update.
6817         * ada-tasks.c (print_ada_task_info): Update.
6818         * ada-lang.c (print_it_exception, print_mention_exception):
6819         Update.
6820
6821 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6822
6823         PR breakpoints/24541
6824         * gdbarch.c: Regenerate.
6825         * gdbarch.h: Regenerate.
6826         * gdbarch.sh: Adjust return type and parameter types for
6827         'stap_adjust_register'.
6828         (i386_stap_adjust_register): Adjust signature and return new
6829         register name.
6830         * stap-probe.c (stap_parse_register_operand): Adjust use of
6831         'gdbarch_stap_adjust_register'.
6832
6833 2019-07-17  Tom Tromey  <tromey@adacore.com>
6834
6835         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6836         declare VEC.
6837         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6838         std::vector.
6839         (struct s390_process_info): Add initializers.
6840         (s390_add_process): Use new.
6841         (s390_linux_nat_target::low_forget_process): Use delete.
6842         (s390_linux_nat_target::low_new_fork)
6843         (s390_linux_nat_target::stopped_by_watchpoint)
6844         (s390_linux_nat_target::low_prepare_to_resume)
6845         (s390_linux_nat_target::insert_watchpoint)
6846         (s390_linux_nat_target::insert_hw_breakpoint)
6847         (s390_linux_nat_target::remove_watchpoint)
6848         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6849
6850 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6851
6852         * aarch64-fbsd-nat.c: Include regcache.h.
6853         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6854         argument.
6855         (aarch64_fbsd_nat_target::fetch_registers)
6856         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6857         variable.
6858         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6859
6860 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6861
6862         * fbsd-nat.c: Include gdbarch.h.
6863
6864 2019-07-15  Tom Tromey  <tromey@adacore.com>
6865
6866         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6867
6868 2019-07-15  Tom Tromey  <tromey@adacore.com>
6869
6870         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6871         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6872         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6873         * cli-out.c (cli_ui_out::do_field_int): New method.
6874         * ui-out.c (ui_out::field_unsigned): New method.
6875         * symfile.c (generic_load): Use field_unsigned.
6876         (print_transfer_performance): Likewise.
6877         * record-btrace.c (ui_out_field_uint): Remove.
6878         (btrace_call_history_insn_range, btrace_call_history): Use
6879         field_unsigned.
6880         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6881         field_unsigned.
6882         * ui-out.h (class ui_out) <field_unsigned>: New method.
6883         <do_field_unsigned>: Likewise.
6884
6885 2019-07-15  Tom Tromey  <tromey@adacore.com>
6886
6887         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6888         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6889         * target.c (flash_erase_command): Use field_string.
6890         * infrun.c (print_signal_received_reason): Use field_string.
6891         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6892         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6893         field_string.
6894         * ada-tasks.c (print_ada_task_info): Use field_string.
6895
6896 2019-07-15  Tom Tromey  <tromey@adacore.com>
6897
6898         * target.c (flash_erase_command): Use field_core_addr.
6899         * symfile.c (generic_load): Use field_core_addr.
6900         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6901         Use field_core_addr.
6902         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6903         field_core_addr.
6904
6905 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6906
6907         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6908         value if its desired type is smaller than a CORE_ADDR and signed.
6909
6910 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6911
6912         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6913         of changes to field names, and use new is_reference field to
6914         decide if a property is a reference or not.
6915         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6916         field.
6917         (struct dwarf2_property_baton): Update header comment, rename
6918         'referenced_type' to 'property_type' and update comments.
6919         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6920         default property type, store in property baton, update to take
6921         accound of renamed field.
6922         (read_func_scope): Update call to attr_to_dynamic_prop.
6923         (read_array_type): Likewise.
6924         (dwarf2_per_cu_addr_sized_int_type): New function.
6925         (read_subrange_index_type): Move type finding code to
6926         dwarf2_per_cu_addr_sized_int_type.
6927         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6928         (dwarf2_per_cu_addr_type): New function.
6929         (set_die_type): Update calls to attr_to_dynamic_prop.
6930
6931 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6932
6933         * dwarf2read.c (read_subrange_index_type): New function.
6934         (read_subrange_type): Move code into new function and call it.
6935         * gdbtypes.c (create_range_type): Add some asserts.
6936
6937 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6938
6939         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6940         update return statements.
6941         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6942         declaration, and update comment to match.
6943         * gdbtypes.c (resolve_dynamic_array): Update call to
6944         dwarf2_evaluate_property to match new return type.
6945
6946 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6947
6948         * valarith.c (value_subscripted_rvalue): Change lowerbound
6949         parameter type from int to LONGEST.
6950         * value.h (value_subscripted_rvalue): Likewise in declaration.
6951
6952 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6953
6954         * cli/cli-utils.c (info_print_command_completer): New function.
6955         * cli/cli-utils.h: Add 'completer.h' include, and forward
6956         declaration for 'struct cmd_list_element'.
6957         (info_print_command_completer): Declare.
6958         * stack.c (_initialize_stack): Add completer for 'info locals' and
6959         'info args'.
6960         * symtab.c (_initialize_symtab): Add completer for 'info
6961         variables' and 'info functions'.
6962         * NEWS: Mention completion for additional info commands.
6963
6964 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6965
6966         * cli/cli-utils.c (extract_info_print_args): Delete.
6967         (extract_arg_maybe_quoted): Delete.
6968         (info_print_options_defs): New variable.
6969         (make_info_print_options_def_group): New function.
6970         (extract_info_print_options): Define new function.
6971         * cli/cli-utils.h (extract_info_print_args): Delete.
6972         (struct info_print_options): New structure.
6973         (extract_info_print_options): Declare new function.
6974         * stack.c (info_locals_command): Update to use new
6975         extract_info_print_options, also add a header comment.
6976         (info_args_command): Likewise.
6977         * symtab.c (info_variables_command): Likewise.
6978         (info_functions_command): Likewise.
6979
6980 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6981
6982         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6983         to extract string arguments.
6984         * common/common-utils.c (extract_string_maybe_quoted): New function.
6985         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6986
6987 2019-07-11  Tom Tromey  <tromey@adacore.com>
6988
6989         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6990         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6991         * top.h (gdbinit): Don't declare.
6992         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6993         into...
6994         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6995         * top.c (gdb_init): Don't call init_cli_cmds.
6996         (gdbinit): Remove.
6997         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6998
6999 2019-07-11  Tom Tromey  <tromey@adacore.com>
7000
7001         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7002         after it has been moved.
7003
7004 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7005
7006         * valops.c (value_must_coerce_to_target): Change return type to
7007         bool.
7008         * value.h (value_must_coerce_to_target): Likewise.
7009
7010 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7011
7012         * breakpoint.c (is_hardware_watchpoint): Remove
7013         forward-declaration.
7014         (is_masked_watchpoint): Change return type to bool.
7015         (is_tracepoint): Likewise.
7016         (is_breakpoint): Likewise.
7017         (is_hardware_watchpoint): Likewise.
7018         (is_watchpoint): Likewise.
7019         (is_no_memory_software_watchpoint): Likewise.
7020         (is_catchpoint): Likewise.
7021         (breakpoint_1): Make FILTER parameter's return type bool.
7022         is_masked_watchpoint): Change return type to bool.
7023         (save_breakpoints): Make FILTER parameter's return type bool.
7024         * breakpoint.h (is_breakpoint): Change return type to bool.
7025         (is_watchpoint): Likewise.
7026         (is_catchpoint): Likewise.
7027         (is_tracepoint): Likewise.
7028
7029 2019-07-10  Tom Tromey  <tom@tromey.com>
7030
7031         * defs.h: Don't include gdbarch.h.
7032         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7033         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7034         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7035         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7036         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7037         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7038         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7039         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7040         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7041         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7042         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7043         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7044         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7045         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7046         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7047         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7048         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7049         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7050         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7051         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7052         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7053         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7054         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7055         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7056         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7057         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7058         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7059
7060 2019-07-10  Tom Tromey  <tromey@adacore.com>
7061
7062         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7063         * breakpoint.c (init_ada_exception_breakpoint): Register as
7064         bp_catchpoint.
7065         (print_one_breakpoint_location, print_one_breakpoint): Use
7066         is_ada_exception_catchpoint.
7067         * ada-lang.c (class ada_catchpoint_location): Pass
7068         bp_loc_software_breakpoint to bp_location constructor.
7069         (is_ada_exception_catchpoint): New function.
7070
7071 2019-07-10  Tom Tromey  <tromey@adacore.com>
7072
7073         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7074         VEC.
7075         (struct arm_exidx_entry): New method operator<.
7076         (struct arm_exidx_data) <section_maps>: Change type.
7077         (arm_exidx_data_free): Remove.
7078         (arm_exidx_data_key): Change type.  Move lower.
7079         (arm_exidx_new_objfile): Update.
7080         (arm_compare_exidx_entries): Remove.
7081         (arm_find_exidx_entry, _initialize_arm_tdep)
7082
7083 2019-07-10  Tom Tromey  <tromey@adacore.com>
7084
7085         * solib-spu.c (ocl_program_data_key): Change type.
7086         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7087         Update.
7088
7089 2019-07-10  Tom Tromey  <tromey@adacore.com>
7090
7091         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7092         (struct solib_aix_inferior_data) <library_list>: Change type.
7093         (solib_aix_inferior_data_handle): Change type.
7094         (get_solib_aix_inferior_data): Update.
7095         (solib_aix_free_library_list): Remove.
7096         (library_list_start_library): Update.
7097         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7098         return type.
7099         (solib_aix_get_library_list)
7100         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7101         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7102
7103 2019-07-10  Tom Tromey  <tromey@adacore.com>
7104
7105         * solib-dsbt.c (struct dsbt_info): Add initializers.
7106         (solib_dsbt_pspace_data): Change type.
7107         (dsbt_pspace_data_cleanup): Remove.
7108         (get_dsbt_info, _initialize_dsbt_solib): Update.
7109
7110 2019-07-10  Tom Tromey  <tromey@adacore.com>
7111
7112         * spu-tdep.c (spu_overlay_data): Change type.
7113         (spu_get_overlay_table, spu_overlay_new_objfile)
7114         (_initialize_spu_tdep): Update.
7115
7116 2019-07-10  Tom Tromey  <tromey@adacore.com>
7117
7118         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7119         destructor.
7120         (dbx_objfile_data_key): Change type and declare later.
7121         (DBX_SYMFILE_INFO): Rewrite.
7122         * dbxread.c (dbx_objfile_data_key): Change type.
7123         (dbx_symfile_init): Update.
7124         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7125         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7126         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7127
7128 2019-07-10  Tom Tromey  <tromey@adacore.com>
7129
7130         * jit.c (jit_program_space_key): Change type.  Move lower.
7131         (get_jit_program_space_data): Update.
7132         (jit_program_space_data_cleanup): Remove.
7133         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7134         Update.
7135         (struct jit_program_space_data): Add initializers.
7136
7137 2019-07-10  Tom Tromey  <tromey@adacore.com>
7138
7139         * solib-darwin.c (struct darwin_info): Add initializers.
7140         (solib_darwin_pspace_data): Change type.
7141         (darwin_pspace_data_cleanup): Remove.
7142         (get_darwin_info, _initialize_darwin_solib): Update.
7143
7144 2019-07-10  Tom Tromey  <tromey@adacore.com>
7145
7146         * remote-sim.c (struct sim_inferior_data): Add initializers,
7147         constructor, and destructor.
7148         (sim_inferior_data_key): Change type.  Move lower.
7149         (check_for_duplicate_sim_descriptor): Update.
7150         (get_sim_inferior_data): Use new.  Update.
7151         (~sim_inferior_data_cleanup): Rename from
7152         sim_inferior_data_cleanup.  Simplify.
7153         (gdbsim_close_inferior, simulator_command)
7154         (sim_command_completer, _initialize_remote_sim): Update.
7155         (next_pid, INITIAL_PID): Move earlier.
7156
7157 2019-07-10  Tom Tromey  <tromey@adacore.com>
7158
7159         * python/python-internal.h (create_thread_object): Return
7160         gdbpy_ref.
7161         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7162         * python/py-inferior.c (struct threadlist_entry): Add
7163         constructor.
7164         <thread_obj>: Now a gdbpy_ref.
7165         (thread_to_thread_object): Update.
7166         (add_thread_object): Use new.
7167         (delete_thread_object): Use delete.
7168         (infpy_threads): Update.
7169         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7170         GIL.
7171
7172 2019-07-10  Tom Tromey  <tromey@adacore.com>
7173
7174         * valops.c (value_cast): Specialize error message for Ada.
7175
7176 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7177
7178         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7179
7180 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7181
7182         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7183         bpstat_should_step): Return bool, adjust comments.
7184         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7185         bpstat_should_step): Likewise.
7186
7187 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7188
7189         * features/Makefile: Use feature target descriptions for Arm.
7190         * features/arm/arm-core.c: Generate new file.
7191         * features/arm/arm-fpa.c: Likewise.
7192         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7193         * features/arm/arm-m-profile.c: Likewise.
7194         * features/arm/arm-vfpv2.c: Likewise.
7195         * features/arm/arm-vfpv3.c: Likewise.
7196         * features/arm/xscale-iwmmxt.c: Likewise.
7197         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7198
7199 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7200
7201         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7202         ptrace earlier.
7203
7204 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7205
7206         * features/aarch64-pauth.c: Regenerate.
7207
7208 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7209
7210         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7211         bool.
7212         (bpstat_what): Use false instead of 0.
7213
7214 2019-07-09  Pedro Alves  <palves@redhat.com>
7215
7216         * break-catch-throw.c (is_exception_catchpoint): New.
7217         * breakpoint.c (print_one_breakpoint_location): New parameter
7218         'raw_loc'.  Handle it.  Use
7219         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7220         looking at the breakpoint's type.
7221         (print_one_breakpoint): If handling "maint info breakpoints", also
7222         print locations of exception catchpoints.
7223         * breakpoint.h (is_exception_catchpoint): Declare.
7224
7225 2019-07-09  Pedro Alves  <palves@redhat.com>
7226
7227         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7228         "addr" field.
7229         (allocate_location_exception_catchpoint): New.
7230         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7231         (initialize_throw_catchpoint_ops): Install
7232         allocate_location_exception_catchpoint as allocate_location
7233         method.
7234         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7235         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7236         bp_loc_other.
7237         (breakpoint_address_is_meaningful): Delete.
7238         (bl_address_is_meaningful): New.
7239         (breakpoint_locations_match): Adjust comment.
7240         (bp_location_from_bp_type): New, factored out of...
7241         (bp_location::bp_location(breakpoint *)): ... this.
7242         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7243         factored out of...
7244         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7245         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7246         breakpoint_address_is_meaningful.
7247         (bp_locations_compare): Adjust comment.
7248         (update_global_location_list): Use bl_address_is_meaningful
7249         instead of breakpoint_address_is_meaningful.
7250         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7251         explicit.
7252         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7253         * python/py-breakpoint.c (bppy_get_location): No longer check
7254         whether location is null.
7255
7256 2019-07-09  Pedro Alves  <palves@redhat.com>
7257
7258         PR c++/15468
7259         * breakpoint.c (print_one_breakpoint_location): Remove
7260         single-location assert.
7261
7262 2019-07-09  Tom Tromey  <tom@tromey.com>
7263
7264         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7265         * configure: Rebuild.
7266         * configure.ac: Change common to gdbsupport.
7267         * gdbsupport: Rename from common.
7268         * acinclude.m4: Change common to gdbsupport.
7269         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7270         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7271         gdbsupport.
7272         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7273         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7274         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7275         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7276         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7277         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7278         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7279         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7280         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7281         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7282         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7283         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7284         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7285         coff-pe-read.c, command.h, compile/compile-c-support.c,
7286         compile/compile-c.h, compile/compile-cplus-symbols.c,
7287         compile/compile-cplus-types.c, compile/compile-cplus.h,
7288         compile/compile-loc2c.c, compile/compile.c, completer.c,
7289         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7290         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7291         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7292         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7293         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7294         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7295         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7296         features/aarch64-core.c, features/aarch64-fpu.c,
7297         features/aarch64-pauth.c, features/aarch64-sve.c,
7298         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7299         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7300         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7301         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7302         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7303         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7304         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7305         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7306         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7307         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7308         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7309         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7310         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7311         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7312         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7313         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7314         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7315         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7316         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7317         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7318         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7319         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7320         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7321         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7322         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7323         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7324         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7325         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7326         minsyms.c, mips-linux-tdep.c, namespace.h,
7327         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7328         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7329         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7330         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7331         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7332         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7333         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7334         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7335         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7336         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7337         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7338         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7339         procfs.c, producer.c, progspace.h, psymtab.h,
7340         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7341         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7342         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7343         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7344         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7345         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7346         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7347         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7348         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7349         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7350         target-memory.c, target.c, target.h, target/waitstatus.c,
7351         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7352         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7353         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7354         unittests/array-view-selftests.c,
7355         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7356         unittests/common-utils-selftests.c,
7357         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7358         unittests/format_pieces-selftests.c,
7359         unittests/function-view-selftests.c,
7360         unittests/lookup_name_info-selftests.c,
7361         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7362         unittests/mkdir-recursive-selftests.c,
7363         unittests/observable-selftests.c,
7364         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7365         unittests/parse-connection-spec-selftests.c,
7366         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7367         unittests/scoped_fd-selftests.c,
7368         unittests/scoped_mmap-selftests.c,
7369         unittests/scoped_restore-selftests.c,
7370         unittests/string_view-selftests.c, unittests/style-selftests.c,
7371         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7372         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7373         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7374         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7375         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7376         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7377
7378 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7379
7380         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7381         bool value.
7382         (decode_digits_ordinary): Set explicit_line field in sal.
7383         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7384         symtab_and_line that was set on an explicit line number in
7385         assembler code.  Do always update the recorded symtab and line if
7386         we do skip the prologue.
7387
7388 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7389
7390         * breakpoint.c (set_breakpoint_location_function): Remove
7391         explicit_loc parameter.
7392         (momentary_breakpoint_from_master): Update call to
7393         set_breakpoint_location_function.
7394         (add_location_to_breakpoint): Likewise.
7395
7396 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7397
7398         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7399         required features based on default bfd type when no specific bfd
7400         is present.
7401
7402 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7403
7404         * NEWS: Mention that GDB printf and eval commands can now print
7405         C-style and Ada-style convenience var strings without
7406         calling the inferior.
7407         * printcmd.c (printf_c_string): Locally print GDB internal var
7408         instead of transiting via the inferior.
7409         (printf_wide_c_string): Likewise.
7410
7411 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7412
7413         PR breakpoints/25011
7414         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7415
7416 2019-07-04  Tom Tromey  <tom@tromey.com>
7417
7418         PR tui/24724:
7419         * tui/tui-winsource.c (tui_clear_source_content): Update.
7420         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7421         (tui_update_breakpoint_info): Update.
7422         (tui_set_exec_info_content): Update.
7423         * tui/tui-source.c (tui_set_source_content_nil): Update.
7424         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7425         has_break.
7426         * tui/tui-data.h (enum tui_bp_flag): New.
7427         (tui_bp_flags): New enum flags type.
7428         (struct tui_source_element) <break_mode>: Change type.  Rename
7429         from has_break.
7430         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7431         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7432         constants.
7433         * tui/tui-winsource.h: Fix comment.
7434
7435 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7436
7437         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7438         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7439         (store_fpregs_to_thread)
7440         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7441         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7442         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7443         (IWMMXT_REGS_SIZE): Add define.
7444         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7445         (fetch_vfp_regs, store_vfp_regs)
7446         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7447         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7448
7449 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7450
7451         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7452         defines.
7453         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7454         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7455         (ARM_INT_REGISTER_SIZE): ...to this.
7456         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7457         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7458         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7459         (arm_linux_collect_gregset, supply_nwfpe_register)
7460         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7461         defines.
7462         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7463         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7464         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7465         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7466         (arm_return_in_memory, arm_store_return_value)
7467         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7468         (arm_record_ld_st_multiple): Likewise.
7469         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7470         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7471
7472 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7473
7474         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7475         AARCH64_DISPLACED_MODIFIED_INSNS.
7476         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7477         (aarch64_displaced_step_copy_insn): Likewise.
7478         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7479         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7480         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7481         ARM_DISPLACED_MODIFIED_INSNS.
7482         * arm-tdep.c (arm_gdbarch_init): Likewise.
7483         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7484         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7485         (struct arm_displaced_step_closure): Use
7486         ARM_DISPLACED_MODIFIED_INSNS.
7487
7488 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7489
7490         * features/Makefile: Remove unused xml files.
7491         * features/aarch64.xml: Remove.
7492         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7493         * features/i386/amd64-avx-avx512.xml: Remove.
7494         * features/i386/amd64-avx-linux.xml: Remove.
7495         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7496         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7497         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7498         * features/i386/amd64-avx-mpx.xml: Remove.
7499         * features/i386/amd64-avx.xml: Remove.
7500         * features/i386/amd64-linux.xml: Remove.
7501         * features/i386/amd64-mpx-linux.xml: Remove.
7502         * features/i386/amd64-mpx.xml: Remove.
7503         * features/i386/amd64.xml: Remove.
7504         * features/i386/i386-avx-avx512-linux.xml: Remove.
7505         * features/i386/i386-avx-avx512.xml: Remove.
7506         * features/i386/i386-avx-linux.xml: Remove.
7507         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7508         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7509         * features/i386/i386-avx-mpx-linux.xml: Remove.
7510         * features/i386/i386-avx-mpx.xml: Remove.
7511         * features/i386/i386-avx.xml: Remove.
7512         * features/i386/i386-linux.xml: Remove.
7513         * features/i386/i386-mmx-linux.xml: Remove.
7514         * features/i386/i386-mmx.xml: Remove.
7515         * features/i386/i386-mpx-linux.xml: Remove.
7516         * features/i386/i386-mpx.xml: Remove.
7517         * features/i386/i386.xml: Remove.
7518         * features/i386/x32-avx-avx512-linux.xml: Remove.
7519         * features/i386/x32-avx-linux.xml: Remove.
7520         * features/i386/x32-linux.xml: Remove.
7521
7522 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7523
7524         * regformats/aarch64.dat: Remove.
7525         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7526         * regformats/i386/amd64-avx-linux.dat: Remove.
7527         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7528         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7529         * regformats/i386/amd64-linux.dat: Remove.
7530         * regformats/i386/amd64-mpx-linux.dat: Remove.
7531         * regformats/i386/amd64.dat: Remove.
7532         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7533         * regformats/i386/i386-avx-linux.dat: Remove.
7534         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7535         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7536         * regformats/i386/i386-linux.dat: Remove.
7537         * regformats/i386/i386-mmx-linux.dat: Remove.
7538         * regformats/i386/i386-mpx-linux.dat: Remove.
7539         * regformats/i386/i386.dat: Remove.
7540         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7541         * regformats/i386/x32-avx-linux.dat: Remove.
7542         * regformats/i386/x32-linux.dat: Remove.
7543
7544 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7545
7546         * aarch64-tdep.c: Remove xml self tests.
7547         * amd64-linux-tdep.c: Likewise.
7548         * amd64-tdep.c: Likewise.
7549         * i386-linux-tdep.c: Likewise.
7550         * i386-tdep.c: Likewise.
7551
7552 2019-07-03  Pedro Alves  <palves@redhat.com>
7553
7554         PR cli/24732
7555         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7556         (pipe_cmd_option_defs): New.
7557         (make_pipe_cmd_options_def_group): New.
7558         (pipe_command): Use gdb::option::process_options.
7559         (pipe_command_completer): New function.
7560         (_initialize_cli_cmds): Install completer for "pipe" command.
7561
7562 2019-07-03  Pedro Alves  <palves@redhat.com>
7563
7564         * cli/cli-option.c (union option_value) <string>: New field.
7565         (struct option_def_and_value): Add ctor, move ctor, dtor and
7566         use DISABLE_COPY_AND_ASSIGN.
7567         (option_def_and_value::clear_value): New.
7568         (parse_option, save_option_value_in_ctx, get_val_type_str)
7569         (add_setshow_cmds_for_options): Handle var_string.
7570         * cli-option.h (union option_def::var_address) <string>: New
7571         field.
7572         (struct string_option_def): New.
7573         * maint-test-options.c (struct test_options_opts): Add default
7574         ctor and use DISABLE_COPY_AND_ASSIGN.
7575         <string_opt>: New field.
7576         (test_options_opts::~test_options_opts): New.
7577         (test_options_opts::dump): Also dump "-string".
7578         (test_options_option_defs): Install "string.
7579
7580 2019-07-03  Pedro Alves  <palves@redhat.com>
7581
7582         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7583         option_value with a null enumeration.
7584         (complete_options): Save the option values in the context.
7585         (save_option_value_in_ctx): New, factored out from ...
7586         (process_options): ... here.
7587         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7588         of the function.
7589         * maint-test-options.c (test_options_opts::dump): New, factored
7590         out from ...
7591         (maintenance_test_options_command_mode): ... here.
7592         (maintenance_test_options_command_completion_result): Delete.
7593         (maintenance_test_options_command_completion_text): Update
7594         comment.
7595         (maintenance_show_test_options_completion_result): Change
7596         prototype.  Just print
7597         maintenance_test_options_command_completion_text.
7598         (save_completion_result): New.
7599         (maintenance_test_options_completer_mode): Pass options context to
7600         complete_options, and then save a dump.
7601         (_initialize_maint_test_options): Use add_cmd to install "maint
7602         show test-options-completion-result".
7603
7604 2019-07-03  Pedro Alves  <palves@redhat.com>
7605
7606         * NEWS (New commands): Mention "with" and "maint with".
7607         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7608         (with_command, with_command_completer): New.
7609         (pipe_command): Adjust to new repeat_previous
7610         interface.
7611         (_initialize_cli_cmds): Install the "with" command and its "w"
7612         alias.
7613         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7614         declarations.
7615         * cli/cli-setshow.c (parse_cli_var_uinteger)
7616         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7617         argument strings for all var_types.
7618         (get_setshow_command_value_string): New, factored out from ...
7619         (do_show_command): ... this.
7620         * cli/cli-setshow.h: Include <string>.
7621         (get_setshow_command_value_string): Declare.
7622         * command.h (repeat_previous): Now returns const char *.  Adjust
7623         comment.
7624         * maint.c: Include "cli/cli-cmds.h".
7625         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7626         (_initialize_maint_cmds): Register the "maintenance with" command.
7627         * top.c (repeat_previous): Move bits from pipe_command here:
7628         Return the saved command line, if any; error out if there's no
7629         command to relaunch.
7630
7631 2019-07-03  Pedro Alves  <palves@redhat.com>
7632
7633         * NEWS (New commands): Mention "maint set/show test-settings"
7634         instead of "maint test-settings".
7635         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7636         (maintenance_test_settings_set_list): Rename to ...
7637         (maintenance_set_test_settings_list): ... this.
7638         (maintenance_test_settings_show_list): Rename to  ...
7639         (maintenance_show_test_settings_list): ... this.
7640         (maintenance_test_settings_cmd): Delete.
7641         (maintenance_test_settings_set_cmd): ...
7642         (maintenance_set_test_settings_cmd): ... this.
7643         (maintenance_test_settings_show_cmd): ...
7644         (maintenance_show_test_settings_cmd): ... this.
7645         (maintenance_test_settings_show_value_cmd):
7646         (maintenance_show_test_settings_value_cmd): ... this.
7647         (_initialize_maint_test_settings): No longer install the "maint
7648         test-settings" prefix command.  Rename "maint test-settings set"
7649         to "maint set test-settings", and "maint test-settings show" to
7650         "maint show test-settings".  Adjust all subcommands.
7651
7652 2019-07-03  Pedro Alves  <palves@redhat.com>
7653
7654         * maint-test-settings.c: Fix file's intro comment.  Replace all
7655         references to "test-options" with references to "test-settings",
7656         in comments.
7657
7658 2019-07-03  Pedro Alves  <palves@redhat.com>
7659
7660         * maint-test-settings.c (maintenance_test_settings_xxx)
7661         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7662         New.
7663         (maintenance_test_settings_enums): Use them.
7664         (maintenance_test_settings_enum): Default to
7665         maintenance_test_settings_xxx.
7666         (_initialize_maint_test_settings): Initialize
7667         MAINTENANCE_TEST_SETTINGS_FILENAME.
7668
7669 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7670
7671         * breakpoint.h (remove_breakpoints_inf): Change return type to
7672         void, move function documentation here.
7673         * breakpoint.c (remove_breakpoints_inf): Change return type to
7674         void, move function documentation to header.
7675
7676 2019-07-02  Pedro Alves  <palves@redhat.com>
7677
7678         * NEWS (Completion improvements): Mention "info threads".
7679         * thread.c (struct info_threads_opts, info_threads_option_defs)
7680         (make_info_threads_options_def_group): New.
7681         (info_threads_command): Use gdb::option::process_options.
7682         (info_threads_command_completer): New.
7683         (_initialize_thread): Use gdb::option::build_help to build the
7684         help text for "info threads".
7685
7686 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7687
7688         * defs.h (generic_load): Move from here...
7689         * symfile.h (generic_load): ... to here.  Rename name parameter
7690         to args.
7691         * symfile.c (generic_load): Add comment.
7692
7693 2019-07-01  Tom Tromey  <tromey@adacore.com>
7694
7695         * dwarf2read.c
7696         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7697         declaration of without_params.  Fix formatting.
7698
7699 2019-07-01  Tom Tromey  <tromey@adacore.com>
7700
7701         * ada-exp.y (find_primitive_type): Update.
7702         * ada-lang.h (ada_lookup_symbol): Update.
7703         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7704         parameter.
7705         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7706
7707 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7708
7709         PR breakpoints/24541
7710         * gdbarch.c: Regenerate.
7711         * gdbarch.h: Regenerate.
7712         * gdbarch.sh: Add 'stap_adjust_register'.
7713         * i386-tdep.c: Include '<unordered_set>'.
7714         (i386_stap_adjust_register): New function.
7715         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7716         * stap-probe.c (stap_parse_register_operand): Call
7717         'gdbarch_stap_adjust_register'.
7718
7719 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7720
7721         PR python/24742
7722         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7723         * python/python.c (do_start_initialization): Use 'xmalloc'
7724         instead of 'PyMem_Malloc'.
7725
7726 2019-06-28  Tom Tromey  <tromey@adacore.com>
7727
7728         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7729         for Ada.
7730
7731 2019-06-27  Tom Tromey  <tromey@adacore.com>
7732
7733         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7734         objfile_key.
7735         (arm_find_mapping_symbol, arm_record_special_symbol)
7736         (_initialize_arm_tdep): Update.
7737         (arm_objfile_data_free): Remove.
7738
7739 2019-06-27  Tom Tromey  <tromey@adacore.com>
7740
7741         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7742         to cp_print_static_field.
7743
7744 2019-06-26  Tom Tromey  <tromey@adacore.com>
7745
7746         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7747         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7748         declare.
7749
7750 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7751
7752         * features/aarch64-core.c (create_feature_aarch64_core):
7753         Regenerate.
7754         * features/aarch64-core.xml: Add cpsr flags.
7755
7756 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7757
7758         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7759         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7760
7761 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7762
7763         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7764         field.
7765         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7766         use.
7767         (arm_record_special_symbol): Don't insert new symbol in sorted
7768         position, push it at the end.
7769
7770 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7771
7772         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7773         (arm_mapping_symbol_s): Remove.
7774         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7775         (arm_mapping_symbol_vec): New typedef.
7776         (struct arm_per_objfile): Add constructor.
7777         <section_maps>: Change type to
7778         std::unique_ptr<arm_mapping_symbol_vec[]>.
7779         (arm_compare_mapping_symbols): Remove.
7780         (arm_find_mapping_symbol): Adjust to section_maps type change.
7781         (arm_objfile_data_free): Call delete on arm_per_objfile.
7782         (arm_record_special_symbol): Adjust to section_maps type change.
7783         Allocate arm_per_objfile with new.
7784
7785 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7786
7787         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7788         with the command prefix.
7789
7790 2019-06-25  Tom Tromey  <tom@tromey.com>
7791
7792         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7793         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7794
7795 2019-06-25  Tom Tromey  <tom@tromey.com>
7796
7797         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7798         type.
7799         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7800         protected.
7801
7802 2019-06-25  Tom Tromey  <tom@tromey.com>
7803
7804         * tui/tui-winsource.c
7805         (tui_source_window_base::set_is_exec_point_at): Add check against
7806         LOA_ADDRESS.
7807
7808 2019-06-25  Tom Tromey  <tom@tromey.com>
7809
7810         * tui/tui-source.c (tui_set_source_content): Don't check before
7811         xfree.
7812         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7813
7814 2019-06-25  Tom Tromey  <tom@tromey.com>
7815
7816         * tui/tui-winsource.h (tui_update_source_window_as_is)
7817         (tui_alloc_source_buffer, tui_line_is_displayed)
7818         (tui_addr_is_displayed): Change type of win_info.
7819         * tui/tui-winsource.c (tui_update_source_window_as_is)
7820         (tui_clear_source_content, tui_show_source_line)
7821         (tui_show_source_content, tui_source_window_base::refill)
7822         (tui_source_window_base::set_is_exec_point_at)
7823         (tui_source_window_base::set_is_exec_point_at)
7824         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7825         (tui_alloc_source_buffer, tui_line_is_displayed)
7826         (tui_addr_is_displayed): Change type of win_info.  Update.
7827         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7828         (tui_source_window_base::do_make_visible_with_new_height):
7829         Update.
7830         * tui/tui-source.c (tui_set_source_content)
7831         (tui_set_source_content_nil)
7832         (tui_source_window::do_scroll_vertical): Update.
7833         * tui/tui-layout.c (show_layout): Update.
7834         * tui/tui-disasm.c (tui_set_disassem_content)
7835         (tui_disasm_window::do_scroll_vertical): Update.
7836         * tui/tui-data.h (tui_win_content): Remove.
7837         (struct tui_gen_win_info) <content, content_size>: Remove.
7838         (struct tui_source_element): Add initializers and destructor.
7839         (union tui_which_element, struct tui_win_element): Remove.
7840         (struct tui_source_window_base) <content>: New field.
7841         (struct tui_data_window): Remove destructor.
7842         (tui_alloc_content, tui_free_win_content)
7843         (tui_free_all_source_wins_content): Don't declare.
7844         * tui/tui-data.c (tui_initialize_static_data): Update.
7845         (init_content_element, tui_alloc_content): Remove.
7846         (~tui_gen_win_info): Update.
7847         (~tui_data_window, tui_free_all_source_wins_content)
7848         (tui_free_win_content, free_content, free_content_elements):
7849         Remove.
7850
7851 2019-06-25  Tom Tromey  <tom@tromey.com>
7852
7853         * tui/tui-winsource.h (tui_clear_source_content)
7854         (tui_erase_source_content, tui_show_source_content): Change type
7855         of win_info.
7856         * tui/tui-winsource.c (tui_clear_source_content)
7857         (tui_erase_source_content, tui_show_source_content): Change type
7858         of win_info.
7859         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7860         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7861         win_info.
7862         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7863         win_info.
7864         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7865
7866 2019-06-25  Tom Tromey  <tom@tromey.com>
7867
7868         * tui/tui-winsource.c (tui_clear_source_content)
7869         (tui_source_window_base::set_is_exec_point_at): Update.
7870         * tui/tui-source.c (tui_set_source_content_nil): Update.
7871         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7872         a bool.
7873         * tui/tui-data.c (init_content_element): Update.
7874
7875 2019-06-25  Tom Tromey  <tom@tromey.com>
7876
7877         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7878         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7879         * tui/tui-layout.c (init_and_make_win): Update.
7880         * tui/tui.h (enum tui_win_type): Update.
7881         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7882         tui_win_is_auxillary.
7883         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7884         tui_win_is_auxillary.
7885
7886 2019-06-25  Tom Tromey  <tom@tromey.com>
7887
7888         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7889         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7890         (tui_delete_data_content_windows, tui_display_all_data)
7891         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7892         Update.
7893         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7894         * tui/tui-regs.c (tui_last_regs_line_no)
7895         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7896         (tui_show_registers): Update.
7897         (tui_show_register_group): Return void.  Update.
7898         (tui_display_registers_from, tui_display_reg_element_at_line)
7899         (tui_display_registers_from_line, tui_check_register_values):
7900         Update.
7901         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7902         member.
7903         (struct tui_data_window) <regs_content>: Now a std::vector.
7904         <regs_content_count>: Remove.
7905         (tui_add_content_elements, tui_free_data_content): Don't declare.
7906         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7907         (init_content_element): Remove DATA_WIN case.  Add assert.
7908         (tui_add_content_elements): Remove.
7909         (tui_data_window): Update.
7910         (tui_free_data_content): Remove.
7911         (free_content_elements): Remove DATA_WIN case.
7912
7913 2019-06-25  Tom Tromey  <tom@tromey.com>
7914
7915         * tui/tui-data.c (tui_data_item_window): Update.
7916         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7917         * tui/tui-windata.c (tui_display_all_data)
7918         (tui_display_data_from_line): Update.
7919         (tui_check_data_values): Remove.
7920         * tui/tui-regs.c (tui_show_register_group)
7921         (tui_display_reg_element_at_line): Update.
7922         * tui/tui-hooks.c (tui_register_changed)
7923         (tui_refresh_frame_and_register_information): Call
7924         tui_check_register_values.
7925         * tui/tui-data.h (struct tui_data_window) <data_content,
7926         data_content_count, data_type>: Remove.
7927         (enum tui_data_type): Remove.
7928
7929         * tui/tui-data.c (tui_data_window::clear_detail)
7930         (~tui_data_window): Update.
7931
7932 2019-06-25  Tom Tromey  <tom@tromey.com>
7933
7934         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7935         declare.
7936         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7937         Rename from tui_first_data_item_displayed.  Update.
7938         (tui_data_window::refresh_all)
7939         (tui_data_window::do_scroll_vertical): Update.
7940         * tui/tui-data.h (struct tui_data_window)
7941         <first_data_item_displayed>: Declare new method.
7942
7943 2019-06-25  Tom Tromey  <tom@tromey.com>
7944
7945         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7946         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7947         contents...
7948         (tui_initialize_static_data): ...here.
7949
7950 2019-06-25  Tom Tromey  <tom@tromey.com>
7951
7952         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7953         (tui_display_registers_from, tui_check_register_values): Update.
7954         (tui_display_register): Remove win_info parameter; update.
7955         (tui_get_register): Change type of parameters.
7956         * tui/tui-data.h (struct tui_data_element): Remove.
7957         (union tui_which_element) <data>: Remove.
7958         <data_window>: Change type.
7959         (struct tui_data_item_window): New.
7960         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7961         case.  Add assert.
7962         (~tui_data_item_window): New destructor.
7963         (free_content_elements): Remove DATA_ITEM_WIN case.
7964
7965 2019-06-25  Tom Tromey  <tom@tromey.com>
7966
7967         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7968         Remove.
7969
7970 2019-06-25  Tom Tromey  <tom@tromey.com>
7971
7972         * tui/tui-data.h (struct tui_command_element): Remove.
7973         (union tui_which_element) <command>: Remove.
7974         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7975         assert.
7976         (free_content_elements): Remove CMD_WIN case.
7977
7978 2019-06-25  Tom Tromey  <tom@tromey.com>
7979
7980         * tui/tui-layout.c (tui_set_layout): Update.
7981         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7982         * tui/tui-data.c (layout_def): Update.
7983
7984 2019-06-25  Tom Tromey  <tom@tromey.com>
7985
7986         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7987         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7988         (tui_source_window_base::set_new_height): Update.
7989         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7990         Update.
7991         (tui_set_locator_fullname, tui_set_locator_info)
7992         (tui_show_frame_info): Update.
7993         * tui/tui-source.c (tui_set_source_content)
7994         (tui_source_is_displayed): Update.
7995         * tui/tui-layout.c (show_source_disasm_command, show_data)
7996         (show_source_or_disasm_and_command): Update.
7997         * tui/tui-disasm.c (tui_set_disassem_content)
7998         (tui_get_begin_asm_address): Update.
7999         * tui/tui-data.h (struct tui_locator_element): Remove.
8000         (union tui_which_element) <locator>: Remove.
8001         (struct tui_locator_window): New.
8002         (tui_locator_win_info_ptr): Change return type.
8003         * tui/tui-data.c (_locator): Change type.
8004         (tui_locator_win_info_ptr): Change return type.
8005         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8006         (tui_alloc_content): Add assert.
8007
8008 2019-06-25  Tom Tromey  <tom@tromey.com>
8009
8010         * tui/tui-winsource.c
8011         (tui_exec_info_window::maybe_allocate_content): New method.
8012         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8013         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8014         (make_source_or_disasm_window): Add cast.
8015         * tui/tui-data.h (union tui_which_element) <simple_string>:
8016         Remove.
8017         (struct tui_source_info): New.
8018         (struct tui_source_window_base) <execution_info>: Change type.
8019         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8020         case, and add assert.
8021         (tui_alloc_content): Add assert.
8022
8023 2019-06-25  Tom Tromey  <tom@tromey.com>
8024
8025         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8026         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8027         * tui/tui-data.c (tui_alloc_win_info): Remove.
8028
8029 2019-06-25  Tom Tromey  <tom@tromey.com>
8030
8031         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8032         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8033         can_highlight.
8034
8035 2019-06-25  Tom Tromey  <tom@tromey.com>
8036
8037         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8038         make_visible_with_new_height method.
8039         (tui_win_info::make_visible_with_new_height): New method.
8040         (tui_source_window_base::do_make_visible_with_new_height)
8041         (tui_data_window::do_make_visible_with_new_height)
8042         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8043         (make_visible_with_new_height): Remove.
8044         (tui_resize_all, tui_adjust_win_heights): Use
8045         make_visible_with_new_height method.
8046         * tui/tui-data.h (struct tui_win_info)
8047         <do_make_visible_with_new_height, make_visible_with_new_height>:
8048         New methods.
8049         (struct tui_source_window_base, struct tui_data_window)
8050         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8051         methods.
8052
8053 2019-06-25  Tom Tromey  <tom@tromey.com>
8054
8055         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8056         method.
8057         (update_tab_width): Call update_tab_width method.
8058         * tui/tui-data.h (struct tui_win_info)
8059         (struct tui_source_window_base) <update_tab_width>: New methods.
8060
8061 2019-06-25  Tom Tromey  <tom@tromey.com>
8062
8063         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8064         parameter.
8065         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8066         parameter.
8067         (tui_gen_win_info::make_visible): Update.
8068         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8069         parameter.
8070         * tui/tui-data.h (enum tui_box): New enum.
8071         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8072
8073 2019-06-25  Tom Tromey  <tom@tromey.com>
8074
8075         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8076         init_and_make_win for EXEC_INFO_WIN.
8077         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8078         longer inline.
8079         (struct tui_win_info) <~tui_win_info>: Inline.
8080         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8081         Don't declare.
8082         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8083         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8084         Remove.
8085         (tui_initialize_static_data): Update.
8086         (~tui_gen_win_info): Handle more cleanup here.
8087         (~tui_source_window_base): Delete "execution_info".
8088         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8089
8090 2019-06-25  Tom Tromey  <tom@tromey.com>
8091
8092         * tui/tui-layout.c (make_command_window): Don't set
8093         can_highlight.
8094         (show_source_disasm_command): Call the reset method.
8095         (show_data): Don't set can_highlight.  Call the reset method.
8096         (tui_gen_win_info::reset): Rename from init_gen_win_info
8097         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8098         (show_source_or_disasm_and_command): Call the reset method.
8099         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8100         (struct tui_cmd_window): Set can_highlight.
8101
8102 2019-06-25  Tom Tromey  <tom@tromey.com>
8103
8104         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8105         from make_visible.
8106         (tui_make_visible, tui_make_invisible): Rewrite.
8107         (tui_win_info::make_visible): Remove.
8108         (tui_source_window_base::make_visible): Update.
8109         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8110         method.  Moved from...
8111         (struct tui_win_info) <make_visible>: ...here.
8112
8113 2019-06-25  Tom Tromey  <tom@tromey.com>
8114
8115         * tui/tui-winsource.c
8116         (tui_source_window_base::do_scroll_horizontal): Remove direction
8117         parameter.
8118         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8119         direction parameter.
8120         * tui/tui-win.c (tui_win_info::forward_scroll)
8121         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8122         (tui_win_info::right_scroll): Update.
8123         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8124         direction parameter.
8125         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8126         direction parameter.
8127         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8128         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8129         Remove direction parameter.
8130         (struct tui_source_window_base, struct tui_source_window)
8131         (struct tui_disasm_window, struct tui_data_window)
8132         (struct tui_cmd_window): Update.
8133
8134 2019-06-25  Tom Tromey  <tom@tromey.com>
8135
8136         * tui/tui-winsource.h (tui_set_exec_info_content)
8137         (tui_show_exec_info_content, tui_erase_exec_info_content)
8138         (tui_clear_exec_info_content, tui_update_exec_info): Change
8139         argument to tui_source_window_base.
8140         * tui/tui-winsource.c (tui_set_exec_info_content)
8141         (tui_show_exec_info_content, tui_erase_exec_info_content)
8142         (tui_clear_exec_info_content, tui_update_exec_info): Change
8143         argument to tui_source_window_base.
8144
8145 2019-06-25  Tom Tromey  <tom@tromey.com>
8146
8147         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8148         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8149
8150 2019-06-25  Tom Tromey  <tom@tromey.com>
8151
8152         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8153         check.
8154
8155 2019-06-25  Tom Tromey  <tom@tromey.com>
8156
8157         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8158         type to void.
8159         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8160         type to void.
8161         * tui/tui-source.c (tui_set_source_content): Update.
8162         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8163
8164 2019-06-25  Tom Tromey  <tom@tromey.com>
8165
8166         * tui/tui-win.c (window_name_completer, tui_set_focus)
8167         (tui_all_windows_info): Use name method.
8168         * tui/tui-data.h (struct tui_gen_win_info)
8169         (struct tui_source_window, struct tui_disasm_window)
8170         (struct tui_data_window, struct tui_cmd_window) <name>: New
8171         method.
8172         (tui_win_name): Don't declare.
8173         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8174         (tui_win_name): Remove.
8175
8176 2019-06-25  Tom Tromey  <tom@tromey.com>
8177
8178         * tui/tui-winsource.h (tui_update_source_window)
8179         (tui_update_source_window_as_is): Change parameter type.
8180         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8181         to be a tui_source_window_base.
8182         (tui_update_source_window_as_is): Likewise.
8183         * tui/tui-win.c (make_visible_with_new_height): Update.
8184
8185 2019-06-25  Tom Tromey  <tom@tromey.com>
8186
8187         * tui/tui-winsource.c (tui_erase_source_content)
8188         (tui_show_source_content, tui_show_exec_info_content)
8189         (tui_erase_exec_info_content): Use refresh_window method.
8190         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8191         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8192         from tui_refresh_win.
8193         (tui_data_window::refresh_window): New method.
8194         (tui_win_info::refresh, tui_source_window_base::refresh)
8195         (tui_refresh_all): Use refresh_window method.
8196         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8197         method.
8198         * tui/tui-regs.c (tui_display_register): Call refresh_window
8199         method.
8200         * tui/tui-layout.c (show_source_disasm_command)
8201         (show_source_or_disasm_and_command): Call refresh_window method.
8202         * tui/tui-data.h (struct tui_gen_win_info)
8203         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8204         New method.
8205
8206 2019-06-25  Tom Tromey  <tom@tromey.com>
8207
8208         * tui/tui.c (tui_rl_other_window, tui_enable)
8209         (tui_is_window_visible, tui_get_command_dimension): Update.
8210         * tui/tui-winsource.c (tui_update_source_window_as_is)
8211         (tui_clear_source_content, tui_erase_source_content)
8212         (tui_show_source_line, tui_source_window_base::refill)
8213         (tui_source_window_base::do_scroll_horizontal)
8214         (tui_source_window_base::set_is_exec_point_at)
8215         (tui_update_breakpoint_info, tui_set_exec_info_content)
8216         (tui_alloc_source_buffer, tui_line_is_displayed)
8217         (tui_addr_is_displayed): Update.
8218         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8219         (tui_check_and_display_highlight_if_needed)
8220         (tui_win_info::make_visible, tui_win_info::refresh)
8221         (tui_refresh_all): Update.
8222         * tui/tui-windata.c (tui_first_data_item_displayed)
8223         (tui_delete_data_content_windows, tui_erase_data_content)
8224         (tui_display_all_data, tui_data_window::refresh_all)
8225         (tui_check_data_values): Update.
8226         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8227         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8228         (tui_win_info::backward_scroll, tui_refresh_all_win)
8229         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8230         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8231         (tui_source_window_base::set_new_height)
8232         (tui_data_window::set_new_height)
8233         (make_invisible_and_set_new_height)
8234         (make_visible_with_new_height, new_height_ok)
8235         (parse_scrolling_args): Update.
8236         * tui/tui-stack.c (tui_show_frame_info): Update.
8237         * tui/tui-source.c (tui_set_source_content)
8238         (tui_set_source_content_nil, tui_source_is_displayed)
8239         (tui_source_window::do_scroll_vertical): Update.
8240         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8241         (tui_display_registers_from, tui_display_reg_element_at_line)
8242         (tui_check_register_values, tui_reg_command): Update.
8243         * tui/tui-layout.c (tui_default_win_height)
8244         (show_source_disasm_command, show_data, init_and_make_win)
8245         (show_source_or_disasm_and_command): Update.
8246         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8247         (tui_redisplay_readline, tui_mld_flush)
8248         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8249         (tui_getc): Update.
8250         * tui/tui-disasm.c (tui_set_disassem_content)
8251         (tui_disasm_window::do_scroll_vertical): Update.
8252         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8253         Now virtual.
8254         (struct tui_win_info): Derive from tui_gen_win_info.
8255         <~tui_win_info>: Mark as override.
8256         <generic>: Remove member.
8257         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8258         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8259         (~tui_data_window, ~tui_win_info)
8260         (tui_free_all_source_wins_content): Update.
8261         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8262
8263 2019-06-25  Tom Tromey  <tom@tromey.com>
8264
8265         * tui/tui-layout.c (init_and_make_win): Use new.
8266         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8267         destructor, initializers.
8268         (tui_alloc_generic_win_info): Don't declare.
8269         * tui/tui-data.c (_locator): Add argument to constructor.
8270         (source_win, disasm_win): New globals.
8271         (exec_info): Remove.
8272         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8273         Update.
8274         (tui_alloc_generic_win_info): Remove.
8275         (init_content_element): Use new.
8276         (tui_win_info::tui_win_info): Update.
8277         (free_content_elements) <case DATA_WIN>: Use delete.
8278
8279 2019-06-25  Tom Tromey  <tom@tromey.com>
8280
8281         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8282         * tui/tui-windata.c (tui_first_data_item_displayed)
8283         (tui_delete_data_content_windows): Update.
8284         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8285         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8286         (tui_display_registers_from, tui_check_register_values): Update.
8287         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8288         pointer.
8289         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8290         window.
8291         (tui_free_data_content): Update.
8292         (free_content_elements) <case DATA_WIN>: Free the window.
8293
8294 2019-06-25  Tom Tromey  <tom@tromey.com>
8295
8296         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8297         Update.
8298         * tui/tui-layout.c (make_command_window)
8299         (show_source_disasm_command, show_data, init_and_make_win)
8300         (show_source_or_disasm_and_command): Update.
8301         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8302         method.
8303         <can_highight, is_highlighted>: Now bool.
8304         (tui_set_win_highlight): Don't declare.
8305         * tui/tui-data.c (tui_set_win_highlight): Remove.
8306
8307 2019-06-25  Tom Tromey  <tom@tromey.com>
8308
8309         * tui/tui-wingeneral.c (make_visible): Remove check of window
8310         type.
8311
8312 2019-06-25  Tom Tromey  <tom@tromey.com>
8313
8314         * tui/tui-win.c (tui_win_info::max_height)
8315         (tui_cmd_window::max_height): New methods.
8316         (new_height_ok): Call max_height.
8317         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8318         <max_height>: New method.
8319
8320 2019-06-25  Tom Tromey  <tom@tromey.com>
8321
8322         * tui/tui-win.c (tui_source_window_base::set_new_height)
8323         (tui_data_window::set_new_height): New methods.
8324         (make_invisible_and_set_new_height): Call set_new_height method.
8325         * tui/tui-data.h (struct tui_win_info)
8326         (struct tui_source_window_base, struct tui_data_window)
8327         <set_new_height>: New method.
8328
8329 2019-06-25  Tom Tromey  <tom@tromey.com>
8330
8331         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8332         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8333         tui_refresh_data_win.
8334         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8335         method.
8336         (tui_refresh_all_win): Call the refresh_all method.
8337         (tui_set_focus): Likewise.
8338         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8339         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8340         Likewise.
8341
8342 2019-06-25  Tom Tromey  <tom@tromey.com>
8343
8344         * tui/tui-winsource.h (tui_refill_source_window)
8345         (tui_set_is_exec_point_at): Don't declare.
8346         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8347         (tui_source_window_base::refill): Rename from
8348         tui_refill_source_window.
8349         (tui_source_window_base::do_scroll_horizontal): Update.
8350         (tui_source_window_base::set_is_exec_point_at): Rename from
8351         tui_set_is_exec_point_at.
8352         (tui_update_all_breakpoint_info): Update.
8353         * tui/tui-stack.c (tui_show_frame_info): Update.
8354         * tui/tui-layout.c (show_data): Add cast.
8355         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8356         * tui/tui-data.h (struct tui_source_window_base) <refill,
8357         set_is_exec_point_at>: New methods.
8358         (tui_source_windows, tui_add_to_source_windows): Update types.
8359         (tui_add_to_source_windows): Remove redundant declaration.
8360         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8361         (tui_source_windows): Change return type.
8362         (tui_clear_source_windows_detail): Update.
8363         (tui_add_to_source_windows): Change type of parameter.
8364         (tui_free_all_source_wins_content): Update.
8365
8366 2019-06-25  Tom Tromey  <tom@tromey.com>
8367
8368         * tui/tui-wingeneral.c (tui_win_info::refresh)
8369         (tui_source_window_base::refresh): New methods.
8370         (tui_refresh_all): Call the refresh method.
8371         * tui/tui-data.h (struct tui_win_info)
8372         (struct tui_source_window_base) <refresh>: New method.
8373
8374 2019-06-25  Tom Tromey  <tom@tromey.com>
8375
8376         * tui/tui.h (tui_is_window_visible): Return bool.
8377         * tui/tui.c (tui_is_window_visible): Return bool.
8378         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8379         (tui_make_visible, tui_make_invisible)
8380         (tui_win_info::make_visible)
8381         (tui_source_window_base::make_visible, make_all_visible)
8382         (tui_make_all_visible, tui_make_all_invisible): Update.
8383         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8384         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8385         bool.
8386         (struct tui_win_info, struct tui_source_window_base)
8387         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8388         * tui/tui-data.c (tui_init_generic_part): Update.
8389
8390 2019-06-25  Tom Tromey  <tom@tromey.com>
8391
8392         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8393         (tui_source_window_base::make_visible): New methods.
8394         (make_all_visible): Make method call.
8395         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8396         (struct tui_source_window_base, struct tui_cmd_window): Override
8397         make_visible.
8398         (tui_win_is_source_type): Don't declare.
8399         * tui/tui-data.c (tui_win_is_source_type): Remove.
8400
8401 2019-06-25  Tom Tromey  <tom@tromey.com>
8402
8403         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8404         NULL check.
8405
8406 2019-06-25  Tom Tromey  <tom@tromey.com>
8407
8408         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8409         Inline constructor.  Add initializers for members.
8410         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8411         constructors; now inline in class.
8412
8413 2019-06-25  Tom Tromey  <tom@tromey.com>
8414
8415         * tui/tui-regs.c (tui_show_registers): Update.
8416         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8417         bool.
8418         * tui/tui-data.c (tui_data_window::clear_detail)
8419         (tui_data_window): Update.
8420
8421 2019-06-25  Tom Tromey  <tom@tromey.com>
8422
8423         * tui/tui-windata.c (tui_display_all_data)
8424         (tui_display_data_from_line, tui_display_data_from)
8425         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8426         Update.
8427         * tui/tui-regs.c (tui_last_regs_line_no)
8428         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8429         (tui_show_registers, tui_show_register_group)
8430         (tui_display_registers_from, tui_display_reg_element_at_line)
8431         (tui_display_registers_from_line, tui_check_register_values)
8432         (tui_reg_next, tui_reg_prev): Update.
8433         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8434         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8435         tui_data_window.
8436         (struct tui_win_info) <detail>: Remove.  Add new fields from
8437         tui_data_info.
8438         (TUI_DATA_WIN): Add cast.
8439         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8440         (~tui_data_window): Simplify.
8441
8442 2019-06-25  Tom Tromey  <tom@tromey.com>
8443
8444         * tui/tui-layout.c (show_source_disasm_command)
8445         (show_source_or_disasm_and_command): Update.
8446         * tui/tui-io.c (update_cmdwin_start_line)
8447         (tui_redisplay_readline): Update.
8448         * tui/tui-data.h (struct tui_command_info): Remove.
8449         (struct tui_win_info) <detail>: Remove command_info member.
8450         (struct tui_data_window) <start_line>: New member, from
8451         tui_command_info.
8452         (TUI_CMD_WIN): Add casts.
8453
8454 2019-06-25  Tom Tromey  <tom@tromey.com>
8455
8456         * tui/tui-winsource.c (tui_update_source_window)
8457         (tui_refill_source_window)
8458         (tui_source_window_base::do_scroll_horizontal)
8459         (tui_update_breakpoint_info, tui_set_exec_info_content)
8460         (tui_show_exec_info_content, tui_erase_exec_info_content)
8461         (tui_clear_exec_info_content): Update.
8462         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8463         Update.
8464         * tui/tui-win.c (make_invisible_and_set_new_height)
8465         (make_visible_with_new_height): Update.
8466         * tui/tui-source.c (tui_set_source_content)
8467         (tui_show_symtab_source): Update.
8468         * tui/tui-layout.c (extract_display_start_addr)
8469         (show_source_disasm_command, show_data)
8470         (make_source_or_disasm_window)
8471         (show_source_or_disasm_and_command): Update.
8472         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8473         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8474         "gdbarch".
8475         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8476         to tui_source_window_base.
8477         (struct tui_win_info) <detail>: Remove source_info member.
8478         (struct tui_source_window_base) <has_locator>: Inline.
8479         Move contents from tui_source_info; rename has_locator member to
8480         m_has_locator.
8481         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8482         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8483         header file.
8484         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8485         Simplify.
8486         (tui_free_all_source_wins_content): Cast to
8487         tui_source_window_base.
8488
8489 2019-06-25  Tom Tromey  <tom@tromey.com>
8490
8491         * tui/tui-win.c (make_invisible_and_set_new_height)
8492         (make_visible_with_new_height): Call has_locator method.
8493         * tui/tui-layout.c (show_source_disasm_command, show_data)
8494         (show_source_or_disasm_and_command): Update for bool change.
8495         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8496         (tui_win_info) <has_locator>: New method.
8497         (struct tui_source_window_base) <has_locator>: New method.
8498         (tui_win_has_locator): Don't declare.
8499         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8500         from tui_win_has_locator.
8501         (tui_source_window_base): Use false, not FALSE.
8502
8503 2019-06-25  Tom Tromey  <tom@tromey.com>
8504
8505         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8506         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8507         clear_detail method directly.
8508         (tui_clear_win_detail): Remove.
8509
8510 2019-06-25  Tom Tromey  <tom@tromey.com>
8511
8512         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8513         "this", not TUI_DISASM_WIN.
8514
8515 2019-06-25  Tom Tromey  <tom@tromey.com>
8516
8517         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8518         declare.
8519         * tui/tui-winsource.c
8520         (tui_source_window_base::do_scroll_horizontal): Rename from
8521         tui_horizontal_source_scroll.
8522         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8523         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8524         from tui_vertical_data_scroll.
8525         * tui/tui-win.h (tui_scroll): Don't declare.
8526         * tui/tui-win.c (tui_win_info::forward_scroll)
8527         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8528         (tui_win_info::right_scroll): Rename and update.
8529         (tui_scroll_forward_command, tui_scroll_backward_command)
8530         (tui_scroll_left_command, tui_scroll_right_command): Update.
8531         (tui_scroll): Remove.
8532         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8533         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8534         from tui_vertical_source_scroll.
8535         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8536         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8537         from tui_vertical_disassem_scroll.
8538         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8539         do_scroll_horizontal>: New methods.
8540         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8541         Likewise.
8542         (struct tui_source_window_base): Add do_scroll_horizontal.
8543         (struct tui_source_window, struct tui_disasm_window): Add
8544         do_scroll_vertical.
8545         (struct tui_data_window, struct tui_cmd_window): Add
8546         do_scroll_horizontal and do_scroll_vertical.
8547         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8548
8549 2019-06-25  Tom Tromey  <tom@tromey.com>
8550
8551         * tui/tui-data.h (struct tui_source_window_base): New struct.
8552         (struct tui_source_window): Derive from tui_source_window_base.
8553         (struct tui_disasm_window): New struct.
8554         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8555         from tui_source_window::clear_detail.
8556         (tui_source_window_base): Rename from tui_source_window.
8557         (~tui_source_window_base): Rename from ~tui_source_window.
8558         (tui_alloc_win_info): Create a tui_disasm_window.
8559
8560 2019-06-25  Tom Tromey  <tom@tromey.com>
8561
8562         * tui/tui-data.h (struct tui_source_window)
8563         (struct tui_data_window): Declare destructors.
8564         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8565         destructors.
8566         (tui_win_info): Simplify.
8567
8568 2019-06-25  Tom Tromey  <tom@tromey.com>
8569
8570         * tui/tui-winsource.c (tui_display_main)
8571         (tui_update_source_windows_with_addr)
8572         (tui_update_all_breakpoint_info): Update.
8573         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8574         (new_height_ok, parse_scrolling_args): Update.
8575         * tui/tui-stack.c (tui_show_frame_info): Update.
8576         * tui/tui-data.h (struct tui_list): Remove.
8577         (tui_source_windows): Return a reference to a std::vector.
8578         * tui/tui-data.c (source_windows): Now a std::vector.
8579         (tui_source_windows): Change return type.
8580         (tui_clear_source_windows): Rewrite.
8581         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8582         (tui_free_all_source_wins_content): Rewrite.
8583
8584 2019-06-25  Tom Tromey  <tom@tromey.com>
8585
8586         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8587         (struct tui_data_window, struct tui_cmd_window): Declare
8588         clear_detail method.
8589         * tui/tui-data.c (tui_source_window::clear_detail)
8590         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8591         methods.
8592         (tui_clear_win_detail): Simplify.
8593
8594 2019-06-25  Tom Tromey  <tom@tromey.com>
8595
8596         * tui/tui-layout.c (make_source_window, make_disasm_window)
8597         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8598         Return the new window.
8599         (show_source_disasm_command, show_data)
8600         (show_source_or_disasm_and_command): Update.
8601
8602 2019-06-25  Tom Tromey  <tom@tromey.com>
8603
8604         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8605         parameter.  Return the new window.
8606         (show_source_disasm_command): Update and remove NULL check.
8607         (show_source_or_disasm_and_command): Update.
8608
8609 2019-06-25  Tom Tromey  <tom@tromey.com>
8610
8611         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8612
8613 2019-06-25  Tom Tromey  <tom@tromey.com>
8614
8615         * tui/tui-data.h (struct tui_win_info): Make constructor
8616         protected.  Make destructor virtual.  Add initializers.
8617         (tui_source_window, tui_data_window, tui_cmd_window): New
8618         classes.
8619         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8620         constructor.  Add "type" parameter.
8621         (tui_source_window, tui_data_window, tui_cmd_window): New
8622         constructors.
8623         (tui_alloc_win_info): Instantiate the appropriate subclass.
8624
8625 2019-06-25  Tom Tromey  <tom@tromey.com>
8626
8627         * tui/tui-win.c (tui_resize_all): Use delete.
8628         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8629         destructor.
8630         (tui_free_window): Don't declare.
8631         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8632         Update.
8633
8634 2019-06-25  Tom Tromey  <tom@tromey.com>
8635
8636         * tui/tui-data.h (struct tui_win_info): Add constructor.
8637         * tui/tui-data.c (tui_alloc_win_info): Use new.
8638         (tui_free_window): Use delete.
8639
8640 2019-06-22  Tom Tromey  <tom@tromey.com>
8641
8642         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8643         declare.
8644         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8645
8646 2019-06-22  Tom Tromey  <tom@tromey.com>
8647
8648         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8649         declare.
8650         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8651
8652 2019-06-22  Tom de Vries  <tdevries@suse.de>
8653
8654         * dwarf2read.c (create_addrmap_from_aranges)
8655         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8656         instead of '%zu'.
8657
8658 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8659
8660         * dwarf2read.h (dwarf2_section_info_def): Remove.
8661         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8662         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8663         std::vector<dwarf2_section_info>.
8664         (struct dwo_file) <~dwo_file>: Remove.
8665         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8666         types field.
8667         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8668         (dwarf2_read_debug_names): Likewise.
8669         (create_debug_types_hash_table): Change parameter type to
8670         array_view, adjust code accordingly.
8671         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8672         (partial_die_info::fixup): Likewise.
8673         (determine_prefix): Likewise.
8674         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8675
8676 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8677
8678         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8679         gdb_bfd_ref_ptr.
8680         <~dwo_file>: Remove call to gdb_bfd_unref.
8681         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8682         gdb_bfd_ref_ptr::get.
8683
8684 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8685
8686         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8687         type to htab_up.
8688         * dwarf2read.c (struct dwo_file): Initialize fields.
8689         <~dwo_file>: New.
8690         (free_dwo_file): Remove, move content to ~dwo_file.
8691         (struct dwo_file_deleter): Remove.
8692         (dwo_file_up>: Remove custom deleter.
8693         (free_dwo_files): Remove.
8694         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8695         dwo_files.
8696         (process_skeletonless_type_units): Call unique_ptr::get.
8697         (allocate_dwo_file_hash_table): Add deleter to created hash
8698         table.  Change return type to htab_up.
8699         (lookup_dwo_file_slot): Don't memset dwo_file, call
8700         unique_ptr::get.
8701         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8702         (create_dwo_unit_in_dwp_v2): Likewise.
8703         (open_and_init_dwo_file): Likewise.
8704         (free_dwo_file_from_slot): Remove.
8705
8706 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8707
8708         * dwarf2read.h (struct dwarf2_section_info) <readin,
8709         is_virtual>: Change type to bool.
8710         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8711         true instead of 1.
8712
8713 2019-06-19  Tom Tromey  <tom@tromey.com>
8714
8715         * tui/tui-data.h (tui_init_content_element): Don't declare.
8716
8717 2019-06-19  Tom Tromey  <tom@tromey.com>
8718
8719         * tui/tui-data.h (tui_init_win_info): Don't declare.
8720
8721 2019-06-19  Tom de Vries  <tdevries@suse.de>
8722
8723         * dwarf2read.h (abstract_to_concrete): Change type to
8724         std::unordered_map<sect_offset, std::vector<sect_offset>,
8725         gdb::hash_enum<sect_offset>>.
8726
8727 2019-06-19  Tom Tromey  <tromey@adacore.com>
8728
8729         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8730         EVAL_AVOID_SIDE_EFFECTS specially.
8731
8732 2019-06-19  Tom Tromey  <tromey@adacore.com>
8733
8734         * source-cache.c (highlighter): New global.
8735         (source_cache::get_source_lines): Create a highlighter on demand.
8736
8737 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8738
8739         * defs.h (deprecated_interactive_hook): Delete declaration.
8740         * interps.c (clear_interpreter_hooks): Remove use of
8741         deprecated_interactive_hook.
8742         * top.c (deprecated_interactive_hook): Delete definition.
8743         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8744
8745 2019-06-18  Tom de Vries  <tdevries@suse.de>
8746
8747         PR gdb/24515
8748         * dwarf2read.h (abstract_to_concrete): Change type from
8749         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8750         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8751         * dwarf2read.c (read_variable): Update.
8752         (dwarf2_fetch_die_loc_sect_off): Update.
8753
8754 2019-06-17  Tom de Vries  <tdevries@suse.de>
8755
8756         PR gdb/24617
8757         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8758         accessing parent[parent_len - 1].
8759
8760 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8761
8762         PR gdb/24364
8763         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8764         call dtrace_process_dof with NULL dof.
8765
8766 2019-06-16  Tom de Vries  <tdevries@suse.de>
8767
8768         PR gdb/24445
8769         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8770
8771 2019-06-16  Tom Tromey  <tom@tromey.com>
8772
8773         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8774         (make_all_visible): Use address of member.
8775
8776 2019-06-16  Tom Tromey  <tom@tromey.com>
8777
8778         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8779         (tui_free_window, free_content, free_content_elements): Remove
8780         unnecessary cast.
8781         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8782         cast.
8783         * tui/tui-regs.c (tui_show_register_group)
8784         (tui_display_registers_from, tui_display_reg_element_at_line):
8785         Remove unnecessary cast.
8786
8787 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8788
8789         * linux-nat.c (normal_mask): Delete.
8790         (_initialize_linux_nat): Don't initialise normal_mask.
8791
8792 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8793
8794         PR gdb/24445
8795         * dwarf-index-write.h (write_psymtabs_to_index): Add
8796         dwz_basename parameter.
8797         * dwarf-index-write.c (write_gdbindex): Move file writing to
8798         write_gdbindex_1.  Change return type void.
8799         (assert_file_size): Move up, remove filename parameter.
8800         (write_gdbindex_1): New function.
8801         (write_debug_names): Change return type to void, call
8802         assert_file_size.
8803         (struct index_wip_file): New struct.
8804         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8805         file logic to index_wip_file.  Write index for dwz file if
8806         needed.
8807         (save_gdb_index_command): Pass basename of dwz file, if present.
8808         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8809         build-id of dwz file, if present.
8810         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8811         (dwarf2_get_dwz_file): Likewise.
8812         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8813         (dwarf2_get_dwz_file): Likewise.
8814
8815 2019-06-16  Tom Tromey  <tom@tromey.com>
8816
8817         * coffread.c (process_coff_symbol): Use xstrdup.
8818         * value.c (create_internalvar): Use xstrdup.
8819
8820 2019-06-16  Tom Tromey  <tom@tromey.com>
8821
8822         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8823         * breakpoint.c (stopin_command, stopat_command)
8824         (until_break_command, decode_location_default): Remove unnecessary
8825         cast.
8826         * utils.c (subset_compare): Remove unnecessary cast.
8827         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8828         cast.
8829         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8830         cast.
8831         * infcmd.c (path_command): Remove unnecessary cast.
8832         * coffread.c (decode_type): Remove unnecessary cast.
8833         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8834         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8835         * tui/tui-stack.c (tui_show_locator_content)
8836         (tui_show_frame_info): Remove unnecessary cast.
8837         * tui/tui-win.c (tui_scroll_forward_command)
8838         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8839         (parse_scrolling_args): Remove unnecessary cast.
8840         * tui/tui-data.c (init_win_info, tui_del_window)
8841         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8842         (free_content_elements): Remove unnecessary cast.
8843         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8844         unnecessary cast.
8845         * tui/tui-source.c (tui_set_source_content)
8846         (tui_vertical_source_scroll): Remove unnecessary cast.
8847         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8848         cast.
8849         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8850         * tui/tui-regs.c (tui_display_registers_from)
8851         (tui_display_register): Remove unnecessary cast.
8852         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8853         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8854         (make_visible): Remove unnecessary cast.
8855         * tui/tui-winsource.c (tui_erase_source_content)
8856         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8857         unnecessary cast.
8858         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8859         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8860         * stabsread.c (read_type, read_array_type, read_range_type):
8861         Remove unnecessary cast.
8862         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8863         (parse_symbol, parse_type, upgrade_type, parse_external)
8864         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8865         unnecessary cast.
8866         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8867
8868 2019-06-16  Tom Tromey  <tom@tromey.com>
8869
8870         * tui/tui-data.c (tui_alloc_generic_win_info)
8871         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8872         checks.
8873
8874 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8875             Andrew Burgess  <andrew.burgess@embecosm.com>
8876
8877         * f-typeprint.c (f_print_type): Don't return early for not
8878         associated or not allocated types.
8879         (f_type_print_varspec_suffix): Add print_rank parameter and print
8880         ranks of array types in case they dangling.
8881         (f_type_print_base): Add print_rank parameter.
8882
8883 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8884
8885         * NEWS: Mention new MI commands.
8886         * break-catch-throw.c (enum exception_event_kind): Move to
8887         breakpoint.h.
8888         (print_mention_exception_catchpoint): Output text as a single
8889         message.
8890         (catch_exception_command_1): Rename to...
8891         (catch_exception_event): ...this, make non-static, update header
8892         command, and change some parameter types.
8893         (catch_catch_command): Update for changes to
8894         catch_exception_command_1.
8895         (catch_throw_command): Likewise.
8896         (catch_rethrow_command): Likewise.
8897         * breakpoint.c (enum exception_event_kind): Delete.
8898         * breakpoint.h (enum exception_event_kind): Moved here from
8899         break-catch-throw.c.
8900         (catch_exception_event): Declare.
8901         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8902         (mi_cmd_catch_throw): New function.
8903         (mi_cmd_catch_rethrow): New function.
8904         (mi_cmd_catch_catch): New function.
8905         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8906         'catch-catch' entries.
8907         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8908         (mi_cmd_catch_rethrow): Declare.
8909         (mi_cmd_catch_catch): Declare.
8910
8911 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8912
8913         * annotate.c (annotate_source_line): Change return type to void,
8914         update implementation to match.
8915         * annotate.h (annotate_source_line): Change return type to void,
8916         update header comment.
8917         * stack.c (print_frame_info): Don't change what frame information
8918         is printed based on whether annotations are on or not.
8919
8920 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8921
8922         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8923         (annotate_source): Make static.
8924         (annotate_source_line): Moved from source.c and renamed from
8925         identify_source_line.  Update the return type.
8926         * annotate.h (annotate_source): Delete declaration.
8927         (annotate_source_line): Declaration moved from source.h, and
8928         renamed from identify_source_line.  Return type updated.
8929         * source.c (identify_source_line): Moved to annotate.c and renamed
8930         to annotate_source_line.
8931         (info_line_command): Remove check of annotation_level.
8932         * source.h (identify_source_line): Move declaration to annotate.h
8933         and rename to annotate_source_line.
8934         * stack.c: Add 'annotate.h' include.
8935         (print_frame_info): Remove check of annotation_level before
8936         calling annotate_source_line.
8937
8938 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8939
8940         * source-cache.c (source_cache::get_plain_source_lines): Use
8941         open_source_file_with_line_charpos instead of just
8942         open_source_file, remove call to find_source_lines.
8943         (source_cache::get_source_lines): Likewise.
8944         * source.c (find_source_lines): Make static.
8945         (get_filename_and_charpos): Renamed into...
8946         (open_source_file_with_line_charpos): ..this along with changes to
8947         return a scoped_fd, and some other minor clean ups.
8948         (identify_source_line): Use open_source_file_with_line_charpos.
8949         (search_command_helper): Use open_source_file_with_line_charpos
8950         instead of just open_source_file, remove call to
8951         find_source_lines.
8952         * source.h (open_source_file_with_line_charpos): Declare new
8953         function.
8954         (find_source_lines): Delete declaration.
8955
8956 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8957
8958         * source.c (get_filename_and_charpos): Remove fullname
8959         parameter.
8960         (identify_source_line): Update call to get_filename_and_charpos.
8961
8962 2019-06-14  Tom Tromey  <tromey@adacore.com>
8963
8964         PR gdb/24502:
8965         * ui-style.h (skip_ansi_escape): Update comment.
8966         * ui-file.h (class no_terminal_escape_file): New class.
8967         * ui-file.c (no_terminal_escape_file::write)
8968         (no_terminal_escape_file::puts): New methods.
8969         * cli/cli-logging.c (handle_redirections): Use
8970         no_terminal_escape_file.
8971
8972 2019-06-14  Tom Tromey  <tromey@adacore.com>
8973
8974         * NEWS: Move convenience variable news above Python news.
8975
8976 2019-06-14  Tom Tromey  <tom@tromey.com>
8977
8978         * gnulib: Move directory to top-level.
8979         * configure.ac: Don't configure gnulib.
8980         * configure: Rebuild.
8981         * common/common-defs.h: Use new path to gnulib.
8982         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8983         (GNULIB_H): Remove.
8984         (INCGNU): Look in new gnulib location.
8985         (HFILES_NO_SRCDIR): Remove gnulib files.
8986         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8987         (generated_files): Remove GNULIB_H.
8988         ($(LIBGNU), all-lib): Remove targets.
8989         (distclean): Don't mention GNULIB_BUILDDIR.
8990         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8991
8992 2019-06-14  Tom Tromey  <tromey@adacore.com>
8993
8994         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8995         Warn if symbol file does not provide any symbols.
8996
8997 2019-06-14  Tom Tromey  <tromey@adacore.com>
8998
8999         * source.c (find_and_open_source): Respect basenames_may_differ.
9000
9001 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9002
9003         * annotate.c (annotate_breakpoints_invalid): Make use of
9004         scoped_restore_terminal_state.
9005         (annotate_frames_invalid): Likewise.
9006
9007 2019-06-14  Tom Tromey  <tromey@adacore.com>
9008
9009         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9010         allow assignment to an internalvar.
9011
9012 2019-06-14  Tom Tromey  <tromey@adacore.com>
9013
9014         * ada-lex.l: Allow "_" in attribute names.
9015
9016 2019-06-14  Tom Tromey  <tromey@adacore.com>
9017
9018         PR gdb/24653:
9019         * regcache.c (registers_changed): Don't call alloca.
9020         * top.c (execute_command): Don't call alloca.
9021
9022 2019-06-13  Pedro Alves  <palves@redhat.com>
9023
9024         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9025         'expression'.  When parsing an expression, error out if there's
9026         junk after "unlimited".
9027         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9028         (do_set_command): Adjust calls to is_unlimited_literal.
9029
9030 2019-06-13  Pedro Alves  <palves@redhat.com>
9031
9032         * compile/compile.c (make_compile_options_def_group): Add braces
9033         around array_view initializer.
9034         * thread.c (make_thread_apply_all_options_def_group)
9035         (make_thread_apply_all_options_def_group): Likewise.
9036
9037 2019-06-13  Pedro Alves  <palves@redhat.com>
9038
9039         * NEWS (New commands): Mention "maint test-options
9040         require-delimiter", "maint test-options unknown-is-error", "maint
9041         test-options unknown-is-operand" and "maint show
9042         test-options-completion-result".
9043         (New command options, command completion): New section.
9044         (Completion improvements): New section.
9045         Mention that you can abbreviate "unlimited".
9046
9047 2019-06-13  Pedro Alves  <palves@redhat.com>
9048
9049         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9050         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9051         * unittests/cli-utils-selftests.c (test_parse_flags)
9052         (test_parse_flags_qcs): Delete.
9053         (test_cli_utils): Don't call deleted functions.
9054
9055 2019-06-13  Pedro Alves  <palves@redhat.com>
9056
9057         * thread.c: Include "cli/cli-option.h".
9058         (tp_array_compar_ascending): Global.
9059         (tp_array_compar): Delete function.
9060         (tp_array_compar_ascending, tp_array_compar_descending): New
9061         functions.
9062         (ascending_option_def, qcs_flag_option_def)
9063         (thr_qcs_flags_option_defs)
9064         (make_thread_apply_all_options_def_group)
9065         (make_thread_apply_options_def_group): New.
9066         (thread_apply_all_command): Use gdb::option::process_options.
9067         (thread_apply_command_completer)
9068         (thread_apply_all_command_completer): New.
9069         (thread_apply_command): Use gdb::option::process_options.
9070         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9071         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9072         to generate help text of "thread apply".  Adjust "taas"'s help.
9073         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9074         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9075
9076 2019-06-13  Pedro Alves  <palves@redhat.com>
9077
9078         * thread.c (thread_apply_command): Check for invalid TID with
9079         isdigit instead of !isalpha.
9080
9081 2019-06-13  Pedro Alves  <palves@redhat.com>
9082
9083         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9084         (validate_flags_qcs): New.
9085         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9086         (validate_flags_qcs): Declare.
9087         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9088         (make_frame_apply_options_def_group): New.
9089         (frame_apply_command_count): Process options with
9090         gdb::option::process_options.
9091         (frame_apply_completer): New.
9092         (frame_apply_level_completer, frame_apply_all_completer)
9093         (frame_apply_completer): New.
9094         (_initialize_stack): Update help of "frame apply", "frame apply
9095         level", "frame apply all" and "faas" to mention supported options
9096         and install command completers.
9097         * stack.h (frame_apply_all_completer): Declare.
9098         * thread.c: Include "stack.h".
9099         (tfaas_command): Add "--".
9100         (_initialize_thread): Update help "tfaas" to mention supported
9101         options and install command completer.
9102
9103 2019-06-13  Pedro Alves  <palves@redhat.com>
9104
9105         * completer.c (complete_nested_command_line): New.
9106         (gdb_completion_word_break_characters_throw): Add assertion.
9107         * completer.h (complete_nested_command_line): Declare.
9108
9109 2019-06-13  Pedro Alves  <palves@redhat.com>
9110
9111         * stack.c (parse_backtrace_qualifiers): New.
9112         (backtrace_command): Use it.
9113         (backtrace_command_completer): Complete on qualifiers.
9114
9115 2019-06-13  Pedro Alves  <palves@redhat.com>
9116
9117         * frame.c: Include "cli/cli-option.h.
9118         (user_set_backtrace_options): New.
9119         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9120         Delete.
9121         (get_prev_frame): Adjust.
9122         (boolean_option_def, uinteger_option_def)
9123         (set_backtrace_option_defs): New.
9124         (_initialize_frame): Adjust and use
9125         gdb::option::add_setshow_cmds_for_options to install "set
9126         backtrace past-main" and "set backtrace past-entry".
9127         * frame.h: Include "cli/cli-option.h".
9128         (struct frame_print_options): Forward declare.
9129         (print_frame_arguments_all, print_frame_arguments_scalars)
9130         (print_frame_arguments_none): Declare.
9131         (print_entry_values): Delete declaration.
9132         (struct frame_print_options, user_frame_print_options): New.
9133         (struct set_backtrace_options): New.
9134         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9135         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9136         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9137         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9138         (list_args_or_locals): Add frame_print_options parameter.
9139         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9140         * python/py-framefilter.c (enumerate_args): Pass down
9141         USER_FRAME_PRINT_OPTIONS.
9142         * stack.c: Include "cli/cli-option.h".
9143         (print_frame_arguments_all, print_frame_arguments_scalars)
9144         (print_frame_arguments_none): Declare.
9145         (print_raw_frame_arguments, print_entry_values): Delete.
9146         (user_frame_print_options): New.
9147         (boolean_option_def, enum_option_def, frame_print_option_defs):
9148         New.
9149         (struct backtrace_cmd_options): New.
9150         (bt_flag_option_def): New.
9151         (backtrace_command_option_defs): New.
9152         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9153         (print_frame_arg, read_frame_arg, print_frame_args)
9154         (print_frame_info, print_frame): Add frame_print_options parameter
9155         and use it.
9156         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9157         (backtrace_command_1): Add frame_print_options and
9158         backtrace_cmd_options parameters and use them.
9159         (make_backtrace_options_def_group): New.
9160         (backtrace_command): Process command options with
9161         gdb::option::process_options.
9162         (backtrace_command_completer): New.
9163         (_initialize_stack): Extend "backtrace"'s help to mention
9164         supported options.  Install completer for "backtrace".
9165         Install some settings commands with add_setshow_cmds_for_options.
9166
9167 2019-06-13  Pedro Alves  <palves@redhat.com>
9168
9169         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9170         and that "set/show print raw frame-arguments" are now deprecated.
9171
9172         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9173         command.
9174         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9175         * stack.c (_initialize_stack): Install "set/show print
9176         raw-frame-arguments", and deprecate "set/show print raw
9177         frame-arguments".
9178         * valprint.c (_initialize_valprint): Deprecate "set/show print
9179         raw".
9180
9181 2019-06-13  Pedro Alves  <palves@redhat.com>
9182
9183         * compile/compile.c (struct compile_options): New.
9184         (compile_flag_option_def, compile_command_option_defs)
9185         (make_compile_options_def_group): New.
9186         (compile_file_command): Handle options with
9187         gdb::option::process_options.
9188         (compile_file_command_completer): New function.
9189         (compile_code_command): Handle options with
9190         gdb::option::process_options.
9191         (compile_code_command_completer): New function.
9192         (_initialize_compiler): Install completers for "compile code" and
9193         "compile file".  Mention available options in "compile code" and
9194         "compile code"'s help.
9195         * completer.c (advance_to_completion_word): New, factored out from
9196         ...
9197         (advance_to_expression_complete_word_point): ... this.
9198         (advance_to_filename_complete_word_point): New.
9199         * completer.h (advance_to_filename_complete_word_point): New
9200         declaration.
9201
9202 2019-06-13  Pedro Alves  <palves@redhat.com>
9203
9204         * compile/compile.c: Include "cli/cli-option.h".
9205         (compile_print_value): Scope data pointer is now a
9206         value_print_options pointer; adjust.
9207         (compile_print_command): Process options.  Scope data pointer is
9208         now a value_print_options pointer; adjust.
9209         (_initialize_compile): Update "compile print"'s help to include
9210         supported options.  Install a completer for "compile print".
9211         * cp-valprint.c (show_vtblprint, show_objectprint)
9212         (show_static_field_print): Delete.
9213         (_initialize_cp_valprint): Don't install "set print
9214         static-members", "set print vtbl", "set print object" here.
9215         * printcmd.c: Include "cli/cli-option.h" and
9216         "common/gdb_optional.h".
9217         (print_command_parse_format): Rework to fill in a
9218         value_print_options instead of a format_data.
9219         (print_value): Change parameter type from format_data pointer to
9220         value_print_options reference.  Adjust.
9221         (print_command_1): Process options.  Adjust to pass down a
9222         value_print_options.
9223         (print_command_completer): New.
9224         (_initialize_printcmd): Install print_command_completer as
9225         handle_brkchars completer for the "print" command.  Update
9226         "print"'s help to include supported options.
9227         * valprint.c: Include "cli/cli-option.h".
9228         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9229         here from cp-valprint.c.
9230         (boolean_option_def, uinteger_option_def)
9231         (value_print_option_defs, make_value_print_options_def_group):
9232         New.  Use gdb::option::add_setshow_cmds_for_options to install
9233         "set print elements", "set print null-stop", "set print repeats",
9234         "set print pretty", "set print union", "set print array", "set
9235         print address", "set print symbol", "set print array-indexes".
9236         * valprint.h: Include <string> and "cli/cli-option.h".
9237         (make_value_print_options_def_group): Declare.
9238         (print_value): Change parameter type from format_data pointer to
9239         value_print_options reference.
9240         (print_command_completer): Declare.
9241
9242 2019-06-13  Pedro Alves  <palves@redhat.com>
9243
9244         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9245         (COMMON_SFILES): Add maint-test-settings.c.
9246         * cli/cli-decode.c (boolean_enums): New global, factored out from
9247         ...
9248         (add_setshow_boolean_cmd): ... here.
9249         * cli/cli-decode.h (boolean_enums): Declare.
9250         * cli/cli-option.c: New file.
9251         * cli/cli-option.h: New file.
9252         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9253         factored out from ...
9254         (parse_cli_boolean_value(const char *)): ... this.
9255         (is_unlimited_literal): Change parameter type to pointer to
9256         pointer.  Adjust and advance ARG pointer.
9257         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9258         (parse_cli_var_enum): New, factored out from ...
9259         (do_set_command): ... this.  Adjust.
9260         * cli/cli-setshow.h (parse_cli_boolean_value)
9261         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9262         (parse_cli_var_enum): Declare.
9263         * cli/cli-utils.c: Include "cli/cli-option.h".
9264         (get_ulongest): New.
9265         * cli/cli-utils.h (get_ulongest): Declare.
9266         (check_for_argument): New overloads.
9267         * maint-test-options.c: New file.
9268
9269 2019-06-13  Pedro Alves  <palves@redhat.com>
9270
9271         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9272         parse a range if "-" is at the end of the string.
9273
9274 2019-06-13  Pedro Alves  <palves@redhat.com>
9275
9276         * cli/cli-setshow.c (parse_auto_binary_operation)
9277         (parse_cli_boolean_value): Don't allow "o".
9278
9279 2019-06-13  Pedro Alves  <palves@redhat.com>
9280
9281         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9282         * NEWS: Mention maint test-settings KIND.
9283         * maint-test-settings.c: New file.
9284
9285 2019-06-13  Pedro Alves  <palves@redhat.com>
9286
9287         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9288         completer.
9289         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9290         "set" completers.
9291
9292 2019-06-13  Pedro Alves  <palves@redhat.com>
9293
9294         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9295         after item.
9296
9297 2019-06-13  Pedro Alves  <palves@redhat.com>
9298
9299         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9300
9301 2019-06-13  Pedro Alves <palves@redhat.com>
9302
9303         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9304         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9305         call.
9306         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9307         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9308         calls.
9309         (check_for_argument): Skip spaces after argument.
9310
9311 2019-06-13  Pedro Alves  <palves@redhat.com>
9312
9313         * thread.c (thread_apply_command): Adjust TID parsing.
9314         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9315         detected before end of string.
9316         (tid_is_in_list): Error out if LIST is invalid.
9317
9318 2019-06-13  Pedro Alves  <palves@redhat.com>
9319
9320         * completer.c (complete_line_internal_1): Rewind completion word
9321         point.
9322         (completion_tracker::advance_custom_word_point_by): Change
9323         parameter type to int.
9324         * completer.h (completion_tracker::advance_custom_word_point_by):
9325         Likewise.
9326
9327 2019-06-13  Pedro Alves  <palves@redhat.com>
9328
9329         * completer.c (advance_to_completion_word): Handle delimiters.
9330
9331 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9332
9333         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9334
9335 2019-06-11  Tom Tromey  <tom@tromey.com>
9336
9337         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9338         (xmalloc_failed): Move to alloc.c.
9339         * alloc.c: New file.
9340         * Makefile.in (COMMON_SFILES): Add alloc.c.
9341
9342 2019-06-11  Tom Tromey  <tom@tromey.com>
9343
9344         * nat/linux-waitpid.c: Don't include server.h.
9345         (linux_debug): Remove.
9346         (my_waitpid): Update.
9347
9348 2019-06-11  Tom Tromey  <tromey@adacore.com>
9349
9350         * infcall.c (_initialize_infcall): Remove trailing newline from
9351         help.
9352         * user-regs.c (_initialize_user_regs): Remove trailing newline
9353         from help.
9354         * typeprint.c (_initialize_typeprint): Remove trailing newline
9355         from help.
9356         * reverse.c (_initialize_reverse): Remove trailing newlines from
9357         help.
9358         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9359         from help.
9360         * language.c (add_set_language_command): Remove trailing newline
9361         from help.
9362         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9363         help.
9364         * disasm.c (_initialize_disasm): Remove trailing newline from
9365         help.
9366         * top.c (init_main): Remove trailing newline from help.
9367         * interps.c (_initialize_interpreter): Remove trailing newline
9368         from help.
9369         * btrace.c (_initialize_btrace): Remove trailing newlines from
9370         help.
9371         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9372         from help.
9373         * python/python.c (_initialize_python): Remove trailing newline
9374         from help.
9375         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9376         help.
9377         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9378         from help.  Reformat some text.
9379         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9380         from help.
9381         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9382         newline from help.
9383
9384 2019-06-11  Tom Tromey  <tromey@adacore.com>
9385
9386         * darwin-nat.c (darwin_decode_exception_message)
9387         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9388
9389 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9390
9391         * valops.c (value_slice): Check for not allocated or not
9392         associated values.
9393
9394 2019-06-10  Tom de Vries  <tdevries@suse.de>
9395
9396         PR gdb/24618
9397         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9398         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9399         invalid.
9400
9401 2019-06-10  Tom de Vries  <tdevries@suse.de>
9402
9403         PR gdb/24611
9404         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9405         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9406
9407 2019-06-10  Tom de Vries  <tdevries@suse.de>
9408
9409         PR symtab/24545
9410         * symtab.c (struct demangled_name_entry): Add language field.
9411         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9412         static minimal symbol".  Set and use language field.
9413
9414 2019-06-10  Tom Tromey  <tromey@adacore.com>
9415
9416         * ada-lang.c (_initialize_ada_language): Update help text.
9417
9418 2019-06-10  Tom Tromey  <tromey@adacore.com>
9419
9420         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9421         with a newline.
9422         * guile/guile.c (handle_boot_error): Don't end warning with a
9423         newline.
9424         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9425         warning with a newline.
9426         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9427         newline.
9428         (s12z_frame_cache): Likewise.
9429         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9430         a newline.
9431         * solib-svr4.c (disable_probes_interface): Don't end warning with
9432         a newline.
9433         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9434         newline.
9435         * python/python.c (do_finish_initialization): Don't end warning
9436         with a newline.
9437
9438 2019-06-10  Tom Tromey  <tom@tromey.com>
9439
9440         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9441         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9442         gdbpy_enter.
9443
9444 2019-06-10  Tom Tromey  <tromey@adacore.com>
9445
9446         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9447         data.
9448         (elf_new_init): Don't call stabsread_new_init.
9449         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9450         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9451         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9452
9453 2019-06-10  Tom de Vries  <tdevries@suse.de>
9454
9455         PR symtab/16264
9456         PR symtab/24517
9457         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9458
9459 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9460
9461         * source.c (find_and_open_source): Also rewrite relative file
9462         names.
9463
9464 2019-04-26  Amos Bird  <amosbird@gmail.com>
9465
9466         * annotate.c (annotate_thread_exited): Add "thread-exited"
9467         annotation.
9468
9469 2019-06-06  Tom Tromey  <tromey@adacore.com>
9470
9471         * maint.h (class scoped_command_stats): Use
9472         DISABLE_COPY_AND_ASSIGN.
9473         <print_time>: New method.
9474         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9475         print_time.
9476         (scoped_command_stats::print_time): New method.
9477
9478 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9479
9480         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9481         instructions of lengths 6 or 8 bytes.
9482
9483 2019-06-04  Pedro Alves  <palves@redhat.com>
9484
9485         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9486
9487         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9488         * breakpoint.c (condition_completer): Likewise.
9489         * cli/cli-dump.c (scan_expression): Likewise.
9490         * common/filestuff.c (mkdir_recursive): Likewise.
9491         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9492         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9493         (gdb_abspath): Likewise.
9494         * compile/compile-cplus-types.c
9495         (compile_cplus_instance::decl_name): Likewise.
9496         * completer.c (complete_explicit_location):
9497         (signal_completer, reg_or_group_completer_1): Likewise.
9498         * cp-support.c (cp_remove_params_if_any): Likewise.
9499         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9500         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9501         * infcmd.c (strip_bg_char): Likewise.
9502         * linespec.c (copy_token_string): Likewise.
9503         * mi/mi-main.c (output_cores): Likewise.
9504         * psymtab.c (psymtab_search_name):
9505         * symfile.c (test_set_ext_lang_command): Likewise.
9506         * target.c (target_fileio_read_stralloc): Likewise.
9507         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9508         * value.c (complete_internalvar): Likewise.
9509
9510 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9511
9512         Add objfile property to gdb.Type.
9513         * NEWS: Mention Python API addition.
9514         * python/py-type.c (typy_get_objfile): New method.
9515
9516 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9517
9518         * NEWS: Mention the new set|show style [title|highlight].
9519         Mention changes to "show style", "help" and "apropos".
9520
9521 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9522
9523         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9524         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9525         instead of print_help_for_command.
9526         (print_doc_of_command): New function.
9527         (help_list): Add 'apropos -v word' suggestion.
9528         (print_help_for_command): Style the command name using title style.
9529         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9530         (_initialize_cli_cmds): Describe -v in apropos_command help.
9531
9532 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9533
9534         * cli/cli-style.h (cli_style_option): Add name in constructor,
9535         add m_name class member, add constructor with intensity,
9536         add name class function.
9537         (cli_style_option::add_setshow_commands): Remove name argument.
9538         (highlight_style, title_style): New styles.
9539         * cli/cli-style.c (do_show): New function that shows a style
9540         characteristic styling the style name with itself.
9541         (set_style_name): New function.
9542         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9543         Update all callers according to the changes in cli/cli-style.h.
9544         * utils.h (fputs_highlighted): New function.
9545         * utils.c (fputs_highlighted): Likewise.
9546
9547 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9548
9549         * NEWS: Mention new pipe command and new convenience variables.
9550
9551 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9552
9553         * cli/cli-cmds.c (pipe_command): New function.
9554         (_initialize_cli_cmds): Call add_com for pipe_command.
9555         Define | as an alias for pipe.
9556         (exit_status_set_internal_vars): New function.
9557         (shell_escape): Call exit_status_set_internal_vars.
9558         cli/cli-decode.c (find_command_name_length): Recognize | as
9559         a single character command.
9560
9561 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9562
9563         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9564         top.c (execute_command_to_ui_file): New function, mostly a copy
9565         of execute_command_to_string.
9566         (execute_command_to_string): Implement by calling
9567         execute_command_to_ui_file.
9568
9569 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9570
9571         * top.h (saved_command_line): Remove declaration.
9572         * top.c (previous_saved_command_line, previous_repeat_arguments):
9573         New variables.
9574         (saved_command_line): Make static, define together with other
9575         'repeat variables'.
9576         (dont_repeat): Clear repeat_arguments.
9577         (repeat_previous, get_saved_command_line, save_command_line):
9578         New functions.
9579         (gdb_init): Initialize saved_command_line
9580         and previous_saved_command_line.
9581         * main.c (captured_main_1): Remove saved_command_line initialization.
9582         * event-top.c (handle_line_of_input): Update to use
9583         the new 'repeat' related functions instead of direct access to
9584         saved_command_line.
9585         * command.h (repeat_previous, get_saved_command_line,
9586         save_command_line): New declarations.
9587         (dont_repeat): Add comment.
9588
9589 2019-05-30  Tom Tromey  <tromey@adacore.com>
9590
9591         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9592         Fix comment.
9593         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9594
9595 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9596
9597         PR cli/24587
9598         * completer.c (complete): Initialize variable word.
9599
9600 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9601
9602         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9603         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9604         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9605         'body' is NULL to the outter 'if', protecting the '!is_define'
9606         situation as well.
9607
9608 2019-05-29  Tom Tromey  <tromey@adacore.com>
9609
9610         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9611         (dwarf_unknown): New function.
9612         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9613         (dwarf_type_encoding_name): Use dwarf_unknown.
9614
9615 2019-05-29  Tom Tromey  <tromey@adacore.com>
9616
9617         PR c++/20020:
9618         * cp-valprint.c (cp_print_value_fields): Call
9619         cp_print_static_field inside "try".
9620
9621 2019-05-29  Tom Tromey  <tromey@adacore.com>
9622
9623         * inflow.c (struct terminal_info): Add default operator=.
9624         * configure: Rebuild.
9625         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9626         -Wdeprecated-copy-dtor, -Wredundant-move.
9627
9628 2019-05-29  Tom Tromey  <tromey@adacore.com>
9629
9630         * NEWS: Add entry.
9631         * infcmd.c (print_return_value_1): Handle finish_print
9632         option.
9633         (show_print_finish): New function.
9634         (_initialize_infcmd): Add "set/show print finish" commands.
9635         * valprint.c (user_print_options): Initialize new member.
9636         * valprint.h (struct value_print_options) <finish_print>: New
9637         member.
9638
9639 2019-05-28  Tom Tromey  <tromey@adacore.com>
9640
9641         * ada-lang.c (ada_remove_Xbn_suffix)
9642         (find_old_style_renaming_symbol)
9643         (parse_old_style_renaming): Remove.
9644         (ada_find_renaming_symbol): Don't call
9645         find_old_style_renaming_symbol.
9646         (ada_is_renaming_symbol): Rename from
9647         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9648         bool.  Now static.
9649         (ada_read_var_value): Update and simplify.
9650         * ada-exp.y (write_var_or_type): Remove old code.
9651
9652 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9653
9654         PR gdb/25010
9655         * event-top.c: Remove include comment.
9656         * inflow.c (class scoped_ignore_sigttou): Move from here...
9657         * inflow.h (class scoped_ignore_sigttou): ...to here.
9658         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9659         * top.c:  Remove include comment.
9660
9661 2019-05-27  Tom Tromey  <tom@tromey.com>
9662
9663         * NEWS: Fix typo.
9664
9665 2019-05-22  Tom Tromey  <tromey@adacore.com>
9666
9667         * target.c (target_follow_exec): Constify parameter.
9668         * target-delegates.c: Rebuild.
9669         * remote.c (remote_target::follow_exec): Constify parameter.
9670         * infrun.c (follow_exec): Constify parameter.
9671         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9672         (target_follow_exec): Likewise.
9673
9674 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9675
9676         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9677         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9678
9679 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9680
9681         * NEWS: Add debugredirect and testsuite sections.
9682
9683 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9684
9685         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9686         target descriptions using exclusively floating point register name
9687         aliases.
9688
9689 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9690
9691         PR gdb/18644:
9692         * f-lang.c (build_fortran_types): Handle the case where
9693         gdbarch_floatformat_for_type returns a nullptr.
9694
9695 2019-05-21  Tom de Vries  <tdevries@suse.de>
9696
9697         PR cli/24587
9698         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9699
9700 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9701
9702         PR gdb/18644:
9703         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9704         16-byte floats.
9705         * i386-tdep.c (i386_floatformat_for_type): Use
9706         floatformats_ia64_quad for the 16-byte floating point component
9707         within a fortran 32-byte complex number.
9708
9709 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9710
9711         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9712         delete default constructor.
9713         (find_partial_die): Update to return const struct.
9714         (partial_die_parent_scope): Move variable declaration into scope
9715         of its use and change its type to auto.
9716         (guess_partial_die_structure_name): Likewise.
9717         (partial_die_info::fixup): Likewise.
9718
9719 2019-05-17  Tom Tromey  <tromey@adacore.com>
9720
9721         * source.c (find_and_open_source): Remove cast.
9722
9723 2019-05-17  Tom Tromey  <tromey@adacore.com>
9724
9725         * annotate.c (annotate_source): Make "filename" const.
9726         * annotate.h (annotate_source): Use const.
9727
9728 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9729
9730         * disasm.c (set_disassembler_options): Send errors to stderr.
9731
9732 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9733
9734         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9735         (cli_interp_base::set_logging): Check debug_redirect.
9736         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9737         * cli/cli-logging.c (debug_redirect): Add static variable.
9738         (pop_output_files): Add default param.
9739         (handle_redirections): Print debug setting.
9740         (show_logging_command): Likewise.
9741         (_initialize_cli_logging): Add debugredirect command.
9742         * interps.c (current_interp_set_logging): Add debug_redirect
9743         parameter.
9744         * interps.h (set_logging): Add debug_redirect parameter.
9745         (current_interp_set_logging): Likewise.
9746         * mi/mi-common.h: Likewise.
9747         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9748
9749 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9750             Tom Tromey  <tromey@adacore.com>
9751
9752         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9753         directly.
9754         * cli/cli-interp.h (make_logging_output): Remove declaration.
9755         * cli/cli-logging.c (make_logging_output): Remove function.
9756         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9757         directly.
9758         * ui-file.c (tee_file::tee_file): Remove bools.
9759         (tee_file::~tee_file): Remove deletes.
9760         * ui-file.h (tee_file): Remove bools.
9761
9762 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9763
9764         * mi/mi-cmds.h (mi_cmd_complete): New function.
9765         * mi/mi-main.c (mi_cmd_complete): Likewise.
9766         * mi/mi-cmds.c: Define new MI command -complete.
9767         * NEWS: Mention new -complete command.
9768
9769 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9770
9771         * completer.h (complete): New function.
9772         * completer.c (complete): Likewise.
9773         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9774         function defined in completer.h.
9775
9776 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9777
9778         * MAINTAINERS (Write After Approval): Add myself.
9779
9780 2019-05-17  Tom de Vries  <tdevries@suse.de>
9781
9782         PR gdb/24094
9783         * dwarf2read.c (struct cu_partial_die_info): New struct.
9784         (find_partial_die): Return cu_partial_die_info.
9785         (partial_die_parent_scope, guess_partial_die_structure_name)
9786         (partial_die_info::fixup): Handle new return type of find_partial_die.
9787
9788 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9789
9790         PR breakpoints/24541
9791         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9792         "std::string", simplifying the algorithm.
9793
9794 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9795
9796         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9797         (stap_static_probe_ops::get_probes): Likewise.
9798
9799 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9800
9801         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9802         '-')" and "else if".
9803         (stap_parse_single_operand): Join checks for
9804         "gdbarch_stap_parse_special_token_p" and
9805         "gdbarch_stap_parse_special_token" in the same "if" statement.
9806         Invert check when verifying for operation on register
9807         displacement.
9808
9809 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9810
9811         * stap-probe.c (stap_get_opcode): Update comment.
9812         (stap_get_expected_argument_type): Likewise.
9813         (handle_stap_probe): Likewise.
9814
9815 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9816
9817         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9818         return type to 'bool'.  Adjust comment.  Use 'bool' when
9819         appropriate.
9820         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9821         * stap-probe.c (stap_parse_argument_1): Likewise.
9822         (stap_is_operator): Likewise.
9823         (stap_is_generic_prefix): Likewise.
9824         (stap_is_register_prefix): Likewise.
9825         (stap_is_register_indirection_prefix): Likewise.
9826         (stap_is_integer_prefix): Likewise.
9827         (stap_generic_check_suffix): Likewise.
9828         (stap_check_integer_suffix): Likewise.
9829         (stap_check_register_suffix): Likewise.
9830         (stap_check_register_indirection_suffix): Likewise.
9831         (stap_parse_register_operand): Likewise.
9832         (stap_parse_single_operand): Likewise.
9833         (stap_parse_argument_1): Likewise.
9834         (stap_probe::get_argument_count): Likewise.
9835         (stap_is_operator): Likewise.
9836
9837 2019-05-16  Tom Tromey  <tromey@adacore.com>
9838
9839         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9840         keyword to foreach.
9841
9842 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9843
9844         * linux-thread-db.c (try_thread_db_load_1): Change return type
9845         to bool.
9846         (try_thread_db_load): Likewise.
9847         (try_thread_db_load_from_pdir_1): Likewise.
9848         (try_thread_db_load_from_pdir): Likewise.
9849         (try_thread_db_load_from_sdir): Likewise.
9850         (try_thread_db_load_from_dir): Likewise.
9851         (thread_db_load_search): Likewise.
9852         (has_libpthread): Likewise.
9853         (thread_db_load): Likewise.
9854
9855 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9856
9857         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9858         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9859         NULL, and complain/return if that's the case.
9860
9861 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9862
9863         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9864         (advance, posn, abstract_read_memory): New functions.
9865         [struct mem_read_abstraction]: New struct.
9866         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9867
9868 2019-05-14  Tom Tromey  <tromey@adacore.com>
9869
9870         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9871         value is not lval_memory.
9872
9873 2019-05-14  Tom Tromey  <tromey@adacore.com>
9874
9875         * solib.c (info_sharedlibrary_command): Style the file name.
9876
9877 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9878
9879         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9880         (aarch64_vnv_type): Likewise.
9881         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9882         * common/tdesc.c: Likewise.
9883         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9884         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9885         * features/aarch64-fpu.xml: Add ieee half view.
9886         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9887         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9888         * gdbtypes.h (struct builtin_type): Likewise.
9889         (struct objfile_type): Likewise.
9890
9891 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9892
9893         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9894         typo.
9895         * location.h (string_to_event_location): Likewise.
9896
9897 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9898
9899         GDB 8.3 released.
9900
9901 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9902
9903         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9904         New variable declaration.
9905         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9906         New variable.
9907         (print_one_breakpoint): Use ui_out::test_flags and new global
9908         variable to compute use_fixed_output.
9909         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9910         Remove.
9911         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9912         (mi_multi_location_breakpoint_output_fixed): Remove.
9913         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9914         new variable.
9915         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9916         fix_multi_location_breakpoint_output flag if version >= 3.
9917         * ui-out.h (enum ui_out_flag)
9918         <fix_multi_location_breakpoint_output>: New enumerator.
9919
9920 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9921
9922         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9923
9924 2019-05-10  Tom Tromey  <tromey@adacore.com>
9925
9926         * ada-lang.c (catch_ada_completer): New function.
9927         (_initialize_ada_language): Use it.
9928
9929 2019-05-10  Tom Tromey  <tromey@adacore.com>
9930
9931         * thread.c (print_thread_info): Make "requested_threads" const.
9932         * gdbthread.h (print_thread_info): Make "requested_threads"
9933         const.
9934         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9935         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9936
9937 2019-05-08  Tom Tromey  <tom@tromey.com>
9938
9939         * gdbtypes.c (objfile_type_data): Change type.
9940         (objfile_type, _initialize_gdbtypes): Update.
9941
9942 2019-05-08  Tom Tromey  <tom@tromey.com>
9943
9944         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9945         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9946         (_initialize_dwarf2_frame): Update.
9947
9948 2019-05-08  Tom Tromey  <tom@tromey.com>
9949
9950         * objc-lang.c (objc_objfile_data): Change type.
9951         (find_methods): Update.
9952         (_initialize_objc_lang): Remove.
9953
9954 2019-05-08  Tom Tromey  <tom@tromey.com>
9955
9956         * stabsread.c (rs6000_builtin_type_data): Change type.
9957         (rs6000_builtin_type, _initialize_stabsread): Update.
9958
9959 2019-05-08  Tom Tromey  <tom@tromey.com>
9960
9961         * mips-tdep.c (mips_pdr_data): Remove.
9962         (_initialize_mips_tdep): Update.
9963
9964 2019-05-08  Tom Tromey  <tom@tromey.com>
9965
9966         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9967         (hppa_init_objfile_priv_data, read_unwind_info)
9968         (find_unwind_entry, _initialize_hppa_tdep): Update.
9969
9970 2019-05-08  Tom Tromey  <tom@tromey.com>
9971
9972         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9973         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9974         on obstack.
9975         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9976
9977 2019-05-08  Tom Tromey  <tom@tromey.com>
9978
9979         * mdebugread.c (basic_type_data): Change type.
9980         (basic_type, _initialize_mdebugread): Update.
9981
9982 2019-05-08  Tom Tromey  <tom@tromey.com>
9983
9984         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9985
9986 2019-05-08  Tom Tromey  <tom@tromey.com>
9987
9988         * nto-tdep.c (nto_inferior_data_reg): Change type.
9989         (nto_inferior_data): Update.
9990         (nto_inferior_data_cleanup, nto_new_inferior_data)
9991         (_initialize_nto_tdep): Remove.
9992         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9993
9994 2019-05-08  Tom Tromey  <tom@tromey.com>
9995
9996         * ada-lang.c (struct ada_inferior_data): Add initializers.
9997         (ada_inferior_data): Change type.
9998         (ada_inferior_data_cleanup): Remove.
9999         (get_ada_inferior_data, ada_inferior_exit)
10000         (struct ada_pspace_data): Add initializers, destructor.
10001         (ada_pspace_data_handle): Change type.
10002         (get_ada_pspace_data): Update.
10003         (ada_pspace_data_cleanup): Remove.
10004
10005 2019-05-08  Tom Tromey  <tom@tromey.com>
10006
10007         * coffread.c (struct coff_symfile_info): Add initializers.
10008         (coff_objfile_data_key): Move lower.  Change type.
10009         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10010         Update.
10011         (coff_free_info): Remove.
10012
10013 2019-05-08  Tom Tromey  <tom@tromey.com>
10014
10015         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10016         (fbsd_pspace_data_handle): Move lower.  Change type.
10017         (get_fbsd_pspace_data): Update.
10018         (fbsd_pspace_data_cleanup): Remove.
10019         (_initialize_fbsd_tdep): Update.
10020
10021 2019-05-08  Tom Tromey  <tom@tromey.com>
10022
10023         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10024         (get_ada_tasks_pspace_data): Update.
10025         (ada_tasks_pspace_data_cleanup): Remove.
10026         (_initialize_tasks): Update.
10027         (ada_tasks_inferior_data_handle): Change type.
10028         (get_ada_tasks_inferior_data): Update.
10029         (ada_tasks_inferior_data_cleanup): Remove.
10030         (struct ada_tasks_pspace_data): Add initializers.
10031
10032 2019-05-08  Tom Tromey  <tom@tromey.com>
10033
10034         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10035         * symfile-debug.c (debug_sym_get_probes): Change type.
10036         * stap-probe.c (handle_stap_probe):
10037         (stap_static_probe_ops::get_probes): Change type.
10038         * probe.h (class static_probe_ops) <get_probes>: Change type.
10039         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10040         (parse_probes_in_pspace): Update.
10041         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10042         Update.
10043         (any_static_probe_ops::get_probes): Change type.
10044         * elfread.c (elfread_data): New typedef.
10045         (probe_key): Change type.
10046         (elf_get_probes): Likewise.  Update.
10047         (probe_key_free): Remove.
10048         (_initialize_elfread): Update.
10049         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10050         Change type.
10051         (dtrace_process_dof_probe, dtrace_process_dof)
10052         (dtrace_static_probe_ops::get_probe): Change type.
10053
10054 2019-05-08  Tom Tromey  <tom@tromey.com>
10055
10056         * xcoffread.c (struct xcoff_symfile_info): Rename from
10057         coff_symfile_info.  Add initializers.
10058         (xcoff_objfile_data_key): Move lower.  Change type.
10059         (XCOFF_DATA): Rewrite.
10060         (xcoff_free_info): Remove.
10061         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10062         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10063         (xcoff_initial_scan): Update.
10064
10065 2019-05-08  Tom Tromey  <tom@tromey.com>
10066
10067         * solib-svr4.c (struct svr4_info): Add initializers and
10068         destructor.
10069         <probes_table>: Now an htab_up.
10070         (solib_svr4_pspace_data): Change type.
10071         (free_probes_table): Simplify.
10072         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10073         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10074         (probes_table_remove_objfile_probes, register_solib_event_probe)
10075         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10076         (_initialize_svr4_solib): Update.
10077
10078 2019-05-08  Tom Tromey  <tom@tromey.com>
10079
10080         * remote.c (remote_pspace_data): Change type.
10081         (remote_pspace_data_cleanup): Remove.
10082         (get_remote_exec_file, set_pspace_remote_exec_file)
10083         (_initialize_remote): Update.
10084
10085 2019-05-08  Tom Tromey  <tom@tromey.com>
10086
10087         * breakpoint.c (breakpoint_objfile_key): Change type.
10088         (get_breakpoint_objfile_data): Update.
10089         (free_breakpoint_objfile_data): Remove.
10090         (_initialize_breakpoint): Update.
10091
10092 2019-05-08  Tom Tromey  <tom@tromey.com>
10093
10094         * linux-tdep.c (struct linux_info): Add initializers.
10095         (linux_inferior_data): Move.  Change type.
10096         (invalidate_linux_cache_inf): Update.
10097         (linux_inferior_data_cleanup): Remove.
10098         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10099
10100 2019-05-08  Tom Tromey  <tom@tromey.com>
10101
10102         * auxv.c (auxv_inferior_data): Move.  Change type.
10103         (auxv_inferior_data_cleanup): Remove.
10104         (invalidate_auxv_cache_inf): Rewrite.
10105         (get_auxv_inferior_data, _initialize_auxv): Update.
10106
10107 2019-05-08  Tom Tromey  <tom@tromey.com>
10108
10109         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10110         (symfile_debug_objfile_data_key): Change type.
10111         (symfile_debug_installed, debug_qf_has_symbols)
10112         (debug_qf_find_last_source_symtab)
10113         (debug_qf_forget_cached_source_info)
10114         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10115         (debug_qf_print_stats, debug_qf_dump)
10116         (debug_qf_expand_symtabs_for_function)
10117         (debug_qf_expand_all_symtabs)
10118         (debug_qf_expand_symtabs_with_fullname)
10119         (debug_qf_map_matching_symbols)
10120         (debug_qf_expand_symtabs_matching)
10121         (debug_qf_find_pc_sect_compunit_symtab)
10122         (debug_qf_map_symbol_filenames)
10123         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10124         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10125         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10126         (debug_sym_read_linetable, debug_sym_relocate): Update.
10127         (symfile_debug_free_objfile): Remove.
10128         (install_symfile_debug_logging, _initialize_symfile_debug):
10129         Update.
10130
10131 2019-05-08  Tom Tromey  <tom@tromey.com>
10132
10133         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10134         allocate_on_obstack.
10135         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10136         (get_dwarf2_per_objfile): Update.
10137         (set_dwarf2_per_objfile): Remove.
10138         (dwarf2_has_info, dwarf2_get_section_info): Update.
10139         (dwarf2_free_objfile): Remove.
10140         (_initialize_dwarf2_read): Update.
10141
10142 2019-05-08  Tom Tromey  <tom@tromey.com>
10143
10144         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10145         initializers.
10146         <unsupported_script_warning_printed,
10147         script_not_found_warning_printed>: Now bool.
10148         (auto_load_pspace_data): Change type.
10149         (~auto_load_pspace_info): Rename from
10150         auto_load_pspace_data_cleanup.
10151         (get_auto_load_pspace_data, init_loaded_scripts_info)
10152         (clear_section_scripts, maybe_print_unsupported_script_warning)
10153         (maybe_print_script_not_found_warning, _initialize_auto_load):
10154         Update.
10155
10156 2019-05-08  Tom Tromey  <tom@tromey.com>
10157
10158         * objfiles.c (objfile_pspace_info): Add destructor and
10159         initializers.
10160         (objfiles_pspace_data): Change type.
10161         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10162         (get_objfile_pspace_data): Update.
10163         (objfiles_bfd_data): Change type.
10164         (get_objfile_bfd_data): Update.
10165         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10166
10167 2019-05-08  Tom Tromey  <tom@tromey.com>
10168
10169         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10170         Change type.
10171         (get_catch_syscall_inferior_data): Update.
10172         (catch_syscall_inferior_data_cleanup): Remove.
10173         (_initialize_break_catch_syscall): Update.
10174
10175 2019-05-08  Tom Tromey  <tom@tromey.com>
10176
10177         * inflow.c (struct terminal_info): Add destructor and
10178         initializers.
10179         (inflow_inferior_data): Change type.
10180         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10181         (get_inflow_inferior_data, inflow_inferior_exit)
10182         (swap_terminal_info, _initialize_inflow): Update.
10183
10184 2019-05-08  Tom Tromey  <tom@tromey.com>
10185
10186         * target-dcache.c (target_dcache_cleanup): Remove.
10187         (target_dcache_aspace_key): Change type.
10188         (target_dcache_init_p, target_dcache_invalidate)
10189         (target_dcache_get, target_dcache_get_or_init)
10190         (_initialize_target_dcache): Update.
10191         * dcache.h (struct dcache_deleter): New.
10192
10193 2019-05-08  Tom Tromey  <tom@tromey.com>
10194
10195         * symtab.c (struct symbol_cache): Add destructor and
10196         initializers.
10197         (symbol_cache_key): Move.  Change type.
10198         (make_symbol_cache, free_symbol_cache): Remove.
10199         (get_symbol_cache): Update.
10200         (symbol_cache_cleanup): Remove.
10201         (ALL_PSPACES, symbol_cache_flush)
10202         (maintenance_print_symbol_cache)
10203         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10204         Update.
10205
10206 2019-05-08  Tom Tromey  <tom@tromey.com>
10207
10208         * symtab.c (struct main_info): Add destructor and initializers.
10209         (main_progspace_key): Move.  Change type.
10210         (get_main_info): Update.
10211         (main_info_cleanup): Remove.
10212         (_initialize_symtab): Update.
10213
10214 2019-05-08  Tom Tromey  <tom@tromey.com>
10215
10216         * registry.h (DECLARE_REGISTRY): Define the _key class.
10217
10218 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10219
10220         * NEWS: Merge two 'New commands' sections.
10221
10222 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10223
10224         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10225         parameter and use Ada language definition instead.
10226         (ada_val_print_ptr): Remove unused language parameter.
10227         (ada_val_print_num): Remove language parameter and use Ada language
10228         definition instead.
10229         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10230         parameter.
10231         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10232         parameter and use Ada language definition instead.
10233         (ada_val_print_1): Update all ada_val_print_xxx calls.
10234         Remove language parameter.
10235         (ada_val_print): Update ada_val_print_1 call.
10236
10237 2019-05-08  Tom Tromey  <tromey@adacore.com>
10238
10239         * remote.c (remote_hw_watchpoint_limit)
10240         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10241         Now static.
10242
10243 2019-05-08  Tom Tromey  <tromey@adacore.com>
10244
10245         * maint.c (_initialize_maint_cmds): Move initialization code to
10246         remote.c.
10247         (watchdog, show_watchdog): Move to remote.c.
10248         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10249         "watchdog" static.
10250         (_initialize_remote): Move initialization code from maint.c.
10251         * defs.h (watchdog): Don't declare.
10252
10253 2019-05-08  Tom Tromey  <tromey@adacore.com>
10254
10255         * tui/tui-interp.c: Include main.h.
10256         * interps.c: Include main.h.
10257         * main.h (interpreter_p): Declare.
10258         * defs.h (interpreter_p): Don't declare.
10259
10260 2019-05-08  Tom Tromey  <tromey@adacore.com>
10261
10262         * dwarf2loc.c: Include dwarf2read.h.
10263         * defs.h (read_unsigned_leb128): Don't declare.
10264         * dwarf2read.h (read_unsigned_leb128): Declare.
10265
10266 2019-05-08  Tom Tromey  <tromey@adacore.com>
10267
10268         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10269         method.
10270
10271 2019-05-08  Tom Tromey  <tromey@adacore.com>
10272
10273         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10274         when no wrap column is set.
10275
10276 2019-05-08  Tom Tromey  <tromey@adacore.com>
10277
10278         * c-lang.c (c_get_string): Handle non-C-style arrays.
10279
10280 2019-05-08  Tom Tromey  <tromey@adacore.com>
10281
10282         * typeprint.c (print_offset_data::update): Print the bit offset,
10283         not the number of bits remaining.
10284
10285 2019-05-08  Tom Tromey  <tromey@adacore.com>
10286
10287         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10288         padding at end of comment.
10289
10290 2019-05-08  Tom Tromey  <tromey@adacore.com>
10291
10292         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10293         Compare main types.
10294
10295 2019-05-06  Tom Tromey  <tom@tromey.com>
10296
10297         * common/scoped_mmap.c: Include common-defs.h.
10298         * common/scoped_mmap.h: Don't include config.h.
10299
10300 2019-05-04  Tom Tromey  <tom@tromey.com>
10301
10302         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10303         (struct aarch64_call_info): Add initializers.
10304         <si>: Now a std::vector.
10305         (pass_on_stack, aarch64_push_dummy_call): Update.
10306
10307 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10308             Tom Tromey  <tom@tromey.com>
10309
10310         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10311         (ppc_threads): Now a std::vector.  Now static.
10312         (hwdebug_find_thread_points_by_tid)
10313         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10314         Update.
10315
10316 2019-05-04  Tom Tromey  <tom@tromey.com>
10317
10318         * arc-tdep.c (arc_tdesc_init): Return bool.
10319
10320 2019-05-04  Tom Tromey  <tom@tromey.com>
10321
10322         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10323         Use gdb_assert_not_reached.
10324
10325 2019-05-04  Tom Tromey  <tom@tromey.com>
10326
10327         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10328         "false".
10329
10330 2019-05-04  Tom Tromey  <tom@tromey.com>
10331
10332         * arc-tdep.c (arc_tdesc_init): Use bool.
10333
10334 2019-05-04  Tom Tromey  <tom@tromey.com>
10335
10336         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10337
10338 2019-05-04  Tom Tromey  <tom@tromey.com>
10339
10340         * cli/cli-cmds.c (valid_command_p): Return bool.
10341
10342 2019-05-04  Tom Tromey  <tom@tromey.com>
10343
10344         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10345         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10346
10347 2019-05-04  Raul Tambre  <raul@tambre.ee>
10348
10349         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10350         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10351         operator for comparison.
10352
10353 2019-05-04  Tom Tromey  <tom@tromey.com>
10354
10355         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10356         (lookup_partial_symbol, print_partial_symbols)
10357         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10358         (psymbol_compare): Update.
10359         (add_psymbol_to_bcache): Clear the entire psymbol.
10360         (maintenance_check_psymtabs): Update.
10361         * psympriv.h (struct partial_symbol): Don't derive from
10362         general_symbol_info.
10363         <obj_section, unrelocated_address, address,
10364         set_unrelocated_address>: Update.
10365         <ginfo>: New member.
10366         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10367         (debug_names::write_psymbols): Update.
10368
10369 2019-05-04  Tom de Vries  <tdevries@suse.de>
10370
10371         * contrib/cc-with-tweaks.sh: Support -n arg.
10372
10373 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10374
10375         * corelow.c (core_target::detach): Ensure frame cache and
10376         register caches are cleared.
10377         inferior.c (exit_inferior_1): Likewise.
10378
10379 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10380             Tom Tromey  <tom@tromey.com>
10381
10382         * dictionary.c (collate_pending_symbols_by_language): Remove
10383         "struct" from foreach.
10384         * symtab.c (lookup_global_symbol_from_objfile)
10385         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10386         foreach.
10387         * ser-tcp.c (net_open): Remove "struct" from foreach.
10388         * objfiles.c (objfile_relocate, objfile_rebase)
10389         (objfile_has_symbols): Remove "struct" from foreach.
10390         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10391         from foreach.
10392         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10393         foreach.
10394         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10395         "struct" from foreach.
10396         * ada-lang.c (create_excep_cond_exprs)
10397         (ada_exception_catchpoint_cond_string): Remove "struct" from
10398         foreach.
10399
10400 2019-05-03  Tom Tromey  <tromey@adacore.com>
10401
10402         * ada-exp.y (convert_char_literal): Check suffix of each
10403         enumerator.
10404
10405 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10406
10407         PR ada/21406:
10408         * ada-exp.y (yywrap): Don't define.
10409         * ada-lex.l (%option): Add noyywrap
10410         (yywrap): Remove.
10411
10412 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10413
10414         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10415         _WIN32_WINNT to the XP level, unless already defined to a higher
10416         level.
10417
10418         * unittests/parse-connection-spec-selftests.c:
10419         * ser-tcp.c:
10420         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10421         override.
10422
10423         * symfile.c (find_separate_debug_file): Remove colon from the
10424         drive spec of DOS/Windows file names of the target, so that the
10425         file name produced from DEBUGDIR and the target's directory will
10426         be valid on DOS/Windows systems.
10427
10428 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10429
10430         * rust-lang.c (val_print_struct): Handle printing structures
10431         containing strings.
10432
10433 2019-05-02  Tom Tromey  <tromey@adacore.com>
10434
10435         * valarith.c (_initialize_valarith): Remove.
10436
10437 2019-05-01  Tom Tromey  <tromey@adacore.com>
10438
10439         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10440         bitfields.
10441
10442 2019-05-01  Tom Tromey  <tromey@adacore.com>
10443
10444         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10445         for big-endian copies.
10446
10447 2019-04-30  Ali Tamur  <tamur@google.com>
10448         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10449         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10450         (read_3_bytes): New function.
10451
10452 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10453
10454         * windows-nat.c (main_thread_id): Delete.
10455         (handle_output_debug_string): Replace main_thread_id by
10456         current_event.dwThreadId.
10457         (fake_create_process): Likewise.
10458         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10459         Do not set main_thread_id.
10460         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10461         current_event.dwThreadId.
10462         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10463
10464 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10465
10466         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10467         Use current_event.dwThreadId instead of main_thread_id.
10468
10469 2019-04-30  Tom Tromey  <tromey@adacore.com>
10470
10471         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10472         (create_excep_cond_exprs): Iterate over program spaces.
10473         (ada_exception_catchpoint_cond_string): Examine all minimal
10474         symbols for exception types.
10475
10476 2019-04-30  Tom Tromey  <tromey@adacore.com>
10477
10478         PR c++/24470:
10479         * dwarf2read.c (process_structure_scope): Handle case where type
10480         has template parameters but no symbol was created.
10481
10482 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10483             Chris January  <chris.january@arm.com>
10484
10485         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10486         qualifier.
10487         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10488
10489 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10490
10491         * f-typeprint.c (f_print_type): Update rules for printing
10492         whitespace.
10493         (f_type_print_varspec_suffix): Likewise.
10494
10495 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10496             Chris January  <chris.january@arm.com>
10497
10498         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10499         function arguments.
10500
10501 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10502
10503         * f-lang.c (build_fortran_types): Change name of void type to
10504         lower case.
10505         * f-typeprint.c (f_type_print_base): Print the name of the void
10506         type, rather than a fixed string.
10507         * f-valprint.c (f_decorations): Use lower case void string.
10508
10509 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10510             Chris January  <chris.january@arm.com>
10511
10512         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10513         types for Fortran.
10514
10515 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10516             Chris January  <chris.january@arm.com>
10517             David Lecomber  <david.lecomber@arm.com>
10518
10519         * f-exp.y (BINOP_INTRINSIC): New token.
10520         (exp): New parser rule handling BINOP_INTRINSIC.
10521         (f77_keywords): Add new builtin procedures.
10522         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10523         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10524         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10525         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10526         (print_unop_subexp_f): New function.
10527         (print_binop_subexp_f): New function.
10528         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10529         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10530         (dump_subexp_body_f): Likewise.
10531         (operator_check_f): Likewise.
10532         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10533         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10534
10535 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10536
10537         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10538         UNOP_KIND.
10539         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10540         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10541         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10542         (operator_length_f): New fuction.
10543         (print_subexp_f): New function.
10544         (op_name_f): New function.
10545         (dump_subexp_body_f): New function.
10546         (operator_check_f): New function.
10547         (exp_descriptor_f): Replace standard expression handling functions
10548         with new functions.
10549         * gdb/fortran-operator.def: New file.
10550         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10551         * gdb/std-operator.def: Remove UNOP_KIND.
10552
10553 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10554
10555         * std-operator.def: Remove unbalanced, stray double quote
10556         character.
10557
10558 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10559             Chris January  <chris.january@arm.com>
10560             Daniel Everett  <daniel.everett@arm.com>
10561             Nick Forrington  <nick.forrington@arm.com>
10562             Richard Bunt  <richard.bunt@arm.com>
10563
10564         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10565         of depth when printing anonymous structs or unions.
10566         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10567         Don't print either the top-level value, or the children if the
10568         max-depth is exceeded.
10569         (ppscm_print_children): When printing the key of a map, allow one
10570         extra level of depth.
10571         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10572         print either the top-level value, or the children if the max-depth
10573         is exceeded.
10574         (print_children): When printing the key of a map, allow one extra
10575         level of depth.
10576         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10577         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10578         (user_print_options): Initialise max_depth field.
10579         (val_print_scalar_or_string_type_p): New function.
10580         (val_print): Check to see if the max depth has been reached.
10581         (val_print_check_max_depth): Define new function.
10582         (show_print_max_depth): New function.
10583         (_initialize_valprint): Add 'print max-depth' option.
10584         * valprint.h (struct value_print_options) <max_depth>: New field.
10585         (val_print_check_max_depth): Declare new function.
10586         * NEWS: Document new feature.
10587
10588 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10589
10590         * ada-lang.c (ada_language_defn): Initialise new field.
10591         * c-lang.c (c_is_string_type_p): New function.
10592         (c_language_defn): Initialise new field.
10593         (cplus_language_defn): Initialise new field.
10594         (asm_language_defn): Initialise new field.
10595         (minimal_language_defn): Initialise new field.
10596         * c-lang.h (c_is_string_type_p): Declare new function.
10597         * d-lang.c (d_language_defn): Initialise new field.
10598         * f-lang.c (f_is_string_type_p): New function.
10599         (f_language_defn): Initialise new field.
10600         * go-lang.c (go_is_string_type_p): New function.
10601         (go_language_defn): Initialise new field.
10602         * language.c (default_is_string_type_p): New function.
10603         (unknown_language_defn): Initialise new field.
10604         (auto_language_defn): Initialise new field.
10605         * language.h (struct language_defn) <la_is_string_type_p>: New
10606         member variable.
10607         (default_is_string_type_p): Declare new function.
10608         * m2-lang.c (m2_language_defn): Initialise new field.
10609         * objc-lang.c (objc_language_defn): Initialise new field.
10610         * opencl-lang.c (opencl_language_defn): Initialise new field.
10611         * p-lang.c (pascal_is_string_type_p): New function.
10612         (pascal_language_defn): Initialise new field.
10613         * rust-lang.c (rust_is_string_type_p): New function.
10614         (rust_language_defn): Initialise new field.
10615
10616 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10617
10618         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10619         New field.
10620         * ada-lang.c (ada_language_defn): Initialise new field.
10621         * c-lang.c (c_language_defn): Likewise.
10622         (cplus_language_defn): Likewise.
10623         (asm_language_defn): Likewise.
10624         (minimal_language_defn): Likewise.
10625         * d-lang.c (d_language_defn): Likewise.
10626         * f-lang.c (f_language_defn): Likewise.
10627         * go-lang.c (go_language_defn): Likewise.
10628         * language.c (unknown_language_defn): Likewise.
10629         (auto_language_defn): Likewise.
10630         * m2-lang.c (m2_language_defn): Likewise.
10631         * objc-lang.c (objc_language_defn): Likewise.
10632         * opencl-lang.c (opencl_language_defn): Likewise.
10633         * p-lang.c (pascal_language_defn): Likewise.
10634         * rust-lang.c (rust_language_defn): Likewise.
10635
10636 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10637
10638         * ada-lang.c (ada_is_character_type): Change return type to bool.
10639         (ada_is_string_type): Likewise.
10640         * ada-lang.h (ada_is_character_type): Update declaration
10641         (ada_is_string_type): Likewise.
10642
10643 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10644
10645         Support style in 'frame|thread apply'
10646
10647         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10648         * record.c (record_start, record_stop): Update callers of
10649         execute_command_to_string with false.
10650         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10651         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10652         methods.
10653         (class string_file): New constructor with term_out parameter.
10654         Override methods term_out and can_emit_style_escape.  New member
10655         term_out.
10656         (class stdio_file): Override can_emit_style_escape.
10657         (class tee_file): Override term_out and can_emit_style_escape.
10658         * utils.h (can_emit_style_escape): Remove.
10659         * utils.c (can_emit_style_escape): Likewise.
10660         Update all callers of can_emit_style_escape (SOMESTREAM) to
10661         SOMESTREAM->can_emit_style_escape.
10662         * source-cache.c (source_cache::get_source_lines): Likewise.
10663         * stack.c (frame_apply_command_count): Call execute_command_to_string
10664         passing the term_out characteristic of the current gdb_stdout.
10665         * thread.c (thr_try_catch_cmd): Likewise.
10666         * top.c (execute_command_to_string): pass term_out parameter
10667         to construct the string_file for the command output.
10668         * ui-file.c (term_cli_styling): New function (most code moved
10669         from utils.c can_emit_style_escape).
10670         (string_file::string_file, string_file::can_emit_style_escape,
10671         stdio_file::can_emit_style_escape, tee_file::term_out,
10672         tee_file::can_emit_style_escape): New functions.
10673
10674 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10675
10676         * NEWS: Mention the new set|show may-call-functions.
10677         * infcall.c (may_call_functions_p): New variable.
10678         (show_may_call_functions_p): New function.
10679         (call_function_by_hand_dummy): Throws an error if not
10680         may-call-functions.
10681         (_initialize_infcall): Call add_setshow_boolean_cmd for
10682         may-call-functions.
10683
10684 2019-04-25  Keith Seitz  <keiths@redhat.com>
10685
10686         PR c++/24367
10687         * cp-support.c (inspect_type): Don't attempt substitutions
10688         of symbol with the same name.
10689
10690 2019-04-25  Tom Tromey  <tromey@adacore.com>
10691
10692         PR gdb/24475:
10693         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10694         static.
10695
10696 2019-04-25  Tom Tromey  <tromey@adacore.com>
10697
10698         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10699         rvalue reference.
10700         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10701         (gdb_xml_parser::parse): Use std::move.
10702         * python/python-internal.h (gdbpy_convert_exception): Take a const
10703         reference.
10704         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10705         std::move.
10706         * python/py-utils.c (gdbpy_convert_exception): Take a const
10707         reference.
10708         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10709         Use std::move.
10710         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10711         Use std::move.
10712         * mi/mi-main.c (mi_print_exception): Take a const reference.
10713         * main.c (handle_command_errors): Take a const reference.
10714         * linespec.c (parse_linespec): Use std::move.
10715         * infcall.c (run_inferior_call): Use std::move.
10716         (call_function_by_hand_dummy): Use std::move.
10717         * exec.c (try_open_exec_file): Use std::move.
10718         * exceptions.h (exception_print, exception_fprintf)
10719         (exception_print_same): Update.
10720         * exceptions.c (print_exception, exception_print)
10721         (exception_fprintf, exception_print_same): Change parameters to
10722         const reference.
10723         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10724         * common/new-op.c: Use std::move.
10725         * common/common-exceptions.h (struct gdb_exception): Add move
10726         constructor.
10727         (struct gdb_exception_error, struct gdb_exception_quit, struct
10728         gdb_quit_bad_alloc): Change constructor to move constructor.
10729         (throw_exception): Change parameter to rvalue reference.
10730         * common/common-exceptions.c (throw_exception): Take rvalue
10731         reference.
10732         * cli/cli-interp.c (safe_execute_command): Use std::move.
10733         * breakpoint.c (insert_bp_location, location_to_sals): Use
10734         std::move.
10735
10736 2019-04-25  Tom Tromey  <tromey@adacore.com>
10737
10738         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10739         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10740         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10741         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10742         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10743         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10744         guile/scm-value.c: Use unpack.
10745         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10746         gdbscm_gdb_exception.
10747         (gdbscm_throw_gdb_exception): Likewise.
10748         (struct gdbscm_gdb_exception): New.
10749         (unpack): New function.
10750         (gdbscm_wrap): Use unpack.
10751
10752 2019-04-25  Tom Tromey  <tromey@adacore.com>
10753
10754         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10755         (gdb_rl_callback_handler): Use std::move.
10756         * common/common-exceptions.h (struct gdb_exception): Add move
10757         assignment operator.
10758         (throw_exception_sjlj): Change "exception" to const reference.
10759         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10760         (throw_exception_sjlj): Change "exception" to const reference.
10761
10762 2019-04-25  Tom Tromey  <tromey@adacore.com>
10763
10764         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10765         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10766         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10767         Update.
10768         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10769         Update.
10770         * mi/mi-interp.c (mi_interp::exec): Update.
10771         * linespec.c (parse_linespec): Update.
10772         * infcall.c (run_inferior_call): Update.
10773         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10774         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10775         (gdbscm_lookup_global_symbol): Update.
10776         * guile/scm-param.c (gdbscm_parameter_value): Update.
10777         * guile/scm-frame.c (gdbscm_frame_read_register)
10778         (gdbscm_frame_read_var): Update.
10779         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10780         * exec.c (try_open_exec_file): Update.
10781         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10782         (gdb_rl_callback_handler): Update.
10783         * common/common-exceptions.h (exception_none): Don't declare.
10784         * common/common-exceptions.c (exception_none): Don't define.
10785         (struct catcher) <exception>: Update.
10786         * cli/cli-interp.c (safe_execute_command): Update.
10787         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10788
10789 2019-04-25  Ali Tamur  <tamur@google.com>
10790
10791         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10792         (read_attribute_value): Likewise.
10793         (dwarf2_read_addr_index): Update comment.
10794         (read_str_index): Add DW_FORM_strx.
10795         (dwarf2_string_attr): Likewise.
10796         (dwarf2_const_value_attr): Likewise.
10797         (dump_die_shallow): Likewise.
10798         (dwarf2_fetch_constant_bytes): Likewise.
10799         (skip_form_bytes): Likewise.
10800         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10801
10802 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10803
10804         PR corefiles/11608
10805         PR corefiles/18187
10806         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10807         OFFSET.  Verify if current mapping contains an ELF header.
10808         (linux_find_memory_regions_full): Adjust call to
10809         dump_mapping_p.
10810
10811 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10812             Kang Li <kanglictf@gmail.com>
10813
10814         PR gdb/21600
10815
10816         * dwarf2-frame.c (read_initial_length): Be consistent about using
10817         unsigned representation of length.
10818         (decode_frame_entry_1): Likewise.  Check for wraparound of
10819         end pointer as well as buffer overflow.
10820
10821 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10822
10823         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10824         "vq".
10825
10826 2019-04-24  Tom Tromey  <tromey@adacore.com>
10827
10828         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10829
10830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10831
10832         * s12z-tdep.c (s12z_unwind_pc): Delete.
10833         (s12z_unwind_sp): Delete.
10834         (s12z_gdbarch_init): Don't register deleted functions with
10835         gdbarch.
10836
10837 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10838
10839         * rl78-tdep.c (rl78_unwind_sp): Delete.
10840         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10841
10842 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10843
10844         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10845         (xstormy16_unwind_pc): Delete.
10846         (xstormy16_dummy_id): Delete.
10847         (xstormy16_gdbarch_init): Don't register deleted functions with
10848         gdbarch.
10849
10850 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10851
10852         * vax-tdep.c (vax_unwind_pc): Delete.
10853         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10854
10855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10856
10857         * v850-tdep.c (v850_unwind_sp): Delete.
10858         (v850_unwind_pc): Delete.
10859         (v850_dummy_id): Delete.
10860         (v850_gdbarch_init): Don't register deleted functions with
10861         gdbarch.
10862
10863 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10864
10865         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10866         (tilegx_unwind_pc): Delete.
10867         (tilegx_unwind_dummy_id): Delete.
10868         (tilegx_gdbarch_init): Don't register deleted functions with
10869         gdbarch.
10870
10871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10872
10873         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10874         (tic6x_dummy_id): Delete.
10875         (tic6x_gdbarch_init): Don't register deleted functions with
10876         gdbarch.
10877
10878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10879
10880         * sparc-tdep.c (sparc_unwind_pc): Delete.
10881         (sparc32_gdbarch_init): Don't register deleted function with
10882         gdbarch.
10883
10884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10885
10886         * sh-tdep.c (sh_unwind_sp): Delete.
10887         (sh_unwind_pc): Delete.
10888         (sh_dummy_id): Delete.
10889         (sh_gdbarch_init): Don't register deleted functions with
10890         gdbarch.
10891
10892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10893
10894         * score-tdep.c (score_unwind_sp): Delete.
10895         (score_unwind_pc): Delete.
10896         (score_dummy_id): Delete.
10897         (score_gdbarch_init): Don't register deleted functions with
10898         gdbarch.
10899
10900 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10901
10902         * rx-tdep.c (rx_unwind_pc): Delete.
10903         (rx_unwind_sp): Delete.
10904         (rx_dummy_id): Delete.
10905         (rx_gdbarch_init): Don't register deleted functions with
10906         gdbarch.  Update comment.
10907
10908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10909
10910         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10911         (rs6000_dummy_id): Delete.
10912         (rs6000_gdbarch_init): Don't register deleted functions with
10913         gdbarch.
10914
10915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10916
10917         * or1k-tdep.c (or1k_dummy_id): Delete.
10918         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10919
10920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10921
10922         * nios2-tdep.c (nios2_dummy_id): Delete.
10923         (nios2_unwind_sp): Delete.
10924         (nios2_gdbarch_init): Don't register deleted functions with
10925         gdbarch.
10926
10927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10928
10929         * nds32-tdep.c (nds32_dummy_id): Delete.
10930         (nds32_unwind_pc): Delete.
10931         (nds32_unwind_sp): Delete.
10932         (nds32_gdbarch_init): Don't register deleted functions with
10933         gdbarch.
10934
10935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10936
10937         * msp430-tdep.c (msp430_unwind_pc): Delete.
10938         (msp430_unwind_sp): Delete.
10939         (msp430_dummy_id): Delete.
10940         (msp430_gdbarch_init): Don't register deleted functions with
10941         gdbarch.
10942
10943 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10944
10945         * moxie-tdep.c (moxie_unwind_sp): Delete.
10946         (moxie_unwind_pc): Delete.
10947         (moxie_dummy_id): Delete.
10948         (moxie_gdbarch_init): Don't register deleted functions with
10949         gdbarch.
10950
10951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10952
10953         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10954         (mn10300_unwind_pc): Delete.
10955         (mn10300_unwind_sp): Delete.
10956         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10957         mn10300_unwind_sp.
10958         (mn10300_frame_unwind_init): Don't register deleted functions with
10959         gdbarch.
10960
10961 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10962
10963         * mep-tdep.c (mep_unwind_pc): Delete.
10964         (mep_unwind_sp): Delete.
10965         (mep_dummy_id): Delete.
10966         (mep_gdbarch_init): Don't register deleted functions with
10967         gdbarch.
10968
10969 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10970
10971         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10972         (m68hc11_unwind_sp): Delete.
10973         (m68hc11_gdbarch_init): Don't register deleted functions with
10974         gdbarch.
10975
10976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10977
10978         * m32r-tdep.c (m32r_unwind_sp): Delete.
10979         (m32r_unwind_pc): Delete.
10980         (m32r_dummy_id): Delete.
10981         (m32r_gdbarch_init): Don't register deleted functions with
10982         gdbarch.
10983
10984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10985
10986         * m32c-tdep.c (m32c_unwind_pc): Delete.
10987         (m32c_unwind_sp): Delete.
10988         (m32c_dummy_id): Delete.
10989         (m32c_gdbarch_init): Don't register deleted functions with
10990         gdbarch.
10991
10992 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10993
10994         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10995         (lm32_unwind_pc): Delete.
10996         (lm32_dummy_id): Delete.
10997         (lm32_gdbarch_init): Don't register deleted functions with
10998         gdbarch.
10999
11000 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11001
11002         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11003         (iq2000_unwind_pc): Delete.
11004         (iq2000_dummy_id): Delete.
11005         (iq2000_gdbarch_init): Don't register deleted functions with
11006         gdbarch.
11007
11008 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11009
11010         * nds32-tdep.c (nds32_type_align): Delete.
11011         (nds32_push_dummy_call): Use type_align instead.
11012
11013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11014
11015         * arm-tdep.c (arm_type_align): Only handle vector override case.
11016         (arm_push_dummy_call): Use type_align.
11017         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11018
11019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11020
11021         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11022         case.
11023         (pass_on_stack): Use type_align.
11024         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11025         function.
11026
11027 2019-04-23  Tom Tromey  <tromey@adacore.com>
11028
11029         * dwarf2read.c (line_header::file_name_at): Remove unused
11030         overload.
11031
11032 2019-04-23  Tom de Vries  <tdevries@suse.de>
11033
11034         PR gdb/24438
11035         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11036         invocation.
11037
11038
11039 2019-03-27  Ali Tamur  <tamur@google.com>
11040
11041         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11042         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11043         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11044         (dwarf_expr_context::get_addr_index): Likewise
11045         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11046         (symbol_needs_eval_context::get_addr_index): Likewise
11047         (disassemble_dwarf_expression): Add DW_OP_addrx
11048         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11049         (read_cutu_die_from_dwo): Update comment
11050         (skip_one_die): Add DW_FORM_addrx
11051         (read_attribute_value): Likewise
11052         (var_decode_location): Add DW_OP_addrx
11053         (dwarf2_const_value_attr): Add DW_FORM_addrx
11054         (dump_die_shallow): Likewise
11055         (dwarf2_fetch_constant_bytes): Likewise
11056         (decode_locdesc): Add DW_OP_addrx
11057         (skip_form_bytes): Add DW_FORM_addrx
11058
11059 2019-04-22  Ali Tamur  <tamur@google.com>
11060
11061         * MAINTAINERS (Write After Approval): Add self.
11062
11063 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11064
11065         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11066         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11067         (open_symbol_file_object): Likewise.
11068         (svr4_default_sos): Add info parameter.
11069         (svr4_read_so_list): Likewise.
11070         (svr4_current_sos_direct): Adjust functions calls to pass down
11071         info.
11072         (svr4_current_sos_1): Add info parameter.
11073         (svr4_current_sos): Call get_svr4_info, pass info down to
11074         svr4_current_sos_1.
11075         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11076         get_svr4_info.
11077         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11078         get_svr4_info.
11079         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11080         to get_svr4_info.
11081         (probes_table_remove_objfile_probes): Likewise.
11082         (register_solib_event_probe): Add info parameter.
11083         (solist_update_incremental): Pass info parameter down to
11084         svr4_read_so_list.
11085         (disable_probes_interface): Add info parameter.
11086         (svr4_handle_solib_event): Pass current_program_space to
11087         get_svr4_info.  Adjust disable_probes_interface cleanup.
11088         (svr4_create_probe_breakpoints): Add info parameter, pass it
11089         down to register_solib_event_probe.
11090         (svr4_create_solib_event_breakpoints): Add info parameter,
11091         pass it down to svr4_create_probe_breakpoints.
11092         (enable_break): Pass info down to
11093         svr4_create_solib_event_breakpoints.
11094         (svr4_solib_create_inferior_hook): Pass current_program_space to
11095         get_svr4_info.
11096         (svr4_clear_solib): Likewise.
11097
11098 2019-04-22  Pedro Alves  <palves@redhat.com>
11099
11100         * solib-svr4.c (svr4_free_objfile_observer): New.
11101         (probe_and_action::objfile): New field.
11102         (probes_table_htab_remove_objfile_probes)
11103         (probes_table_remove_objfile_probes): New functions.
11104         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11105         in the new probe_and_action.  Don't store the probe in 'lookup'.
11106         (svr4_create_probe_breakpoints): Pass objfile to
11107         register_solib_event_probe.
11108         (_initialize_svr4_solib): Register a free_objfile observer.
11109
11110 2019-04-19  Tom Tromey  <tom@tromey.com>
11111
11112         * common/queue.h: Remove.
11113
11114 2019-04-19  Tom Tromey  <tom@tromey.com>
11115
11116         * event-loop.c: Don't include "common/queue.h".
11117
11118 2019-04-19  Tom Tromey  <tom@tromey.com>
11119
11120         * remote.c (remote_target): Use delete.
11121         * remote-notif.h: Include <list>, not "common/queue.h".
11122         (notif_client_p): Remove typedef.
11123         (remote_notif_state): Add constructor, destructor, initializer.
11124         <notif_queue>: Now a std::list.
11125         (remote_notif_state_xfree): Don't declare.
11126         * remote-notif.c (remote_notif_process, handle_notification)
11127         (remote_notif_state_allocate): Update.
11128         (~remote_notif_state): Rename from remote_notif_state_xfree.
11129
11130 2019-04-19  Tom Tromey  <tom@tromey.com>
11131
11132         * symfile.c (reread_symbols): Update.
11133         * objfiles.c (objfile_register_static_link)
11134         (objfile_lookup_static_link): Update
11135         (~objfile) Don't delete static_links.
11136         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11137
11138 2019-04-19  Tom Tromey  <tom@tromey.com>
11139
11140         * type-stack.h (struct type_stack) <insert>: Constify string.
11141         * type-stack.c (type_stack::insert): Constify string.
11142         * gdbtypes.h (lookup_template_type): Update.
11143         (address_space_name_to_int): Update.
11144         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11145         const.
11146         (lookup_template_type): Make name const.
11147         * c-exp.y: Update rules.
11148         (lex_one_token, classify_name, classify_inner_name)
11149         (c_print_token): Update.
11150         * p-exp.y: Update rules.
11151         (yylex): Update.
11152         * f-exp.y: Update rules.
11153         (yylex): Update.
11154         * d-exp.y: Update rules.
11155         (lex_one_token, classify_name, classify_inner_name): Update.
11156         * parse.c (write_dollar_variable, copy_name): Return std::string.
11157         * parser-defs.h (copy_name): Change return type.
11158         * m2-exp.y: Update rules.
11159         (yylex): Update.
11160         * go-exp.y (lex_one_token): Update.
11161         Update rules.
11162         (classify_unsafe_function, classify_packaged_name)
11163         (classify_name, yylex): Update.
11164
11165 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11166
11167         * configure.ac: add --enable-source-highlight switch.
11168         * configure: Regenerate.
11169         * top.c (print_gdb_version): plumb --enable-source-highlight
11170         status to "show configuration".
11171
11172 2019-04-19  Tom Tromey  <tromey@adacore.com>
11173
11174         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11175         Check ADA_TYPE_P.
11176         (empty_record, ada_template_to_fixed_record_type_1)
11177         (template_to_static_fixed_type)
11178         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11179         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11180         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11181         macros.
11182
11183 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11184
11185         PR symtab/24423:
11186         * source.c (print_source_lines_base): Advance "iter" when a
11187         control character is seen.
11188
11189 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11190
11191         * inferior.h (struct infcall_suspend_state_deleter):
11192         Catch exception in destructor to avoid crash.
11193
11194 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11195
11196         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11197         close to the add_com "shell".
11198
11199 2019-04-18  Tom Tromey  <tromey@adacore.com>
11200
11201         * process-stratum-target.h (class process_stratum_target)
11202         <stratum>: Add "final".
11203
11204 2019-04-17  Tom Tromey  <tromey@adacore.com>
11205
11206         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11207         against nullptr before use.
11208
11209 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11210
11211         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11212
11213 2019-04-17  Jim Wilson  <jimw@sifive.com>
11214             Andrew Burgess  <andrew.burgess@embecosm.com>
11215
11216         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11217         code read might fail, assume 4-byte breakpoint in that case.
11218
11219 2019-04-15  Leszek Swirski  <leszeks@google.com>
11220
11221         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11222         rather than a hand-rolled POD check when checking for forced MEMORY
11223         classification.
11224
11225 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11226
11227         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11228         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11229         function.
11230         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11231         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11232         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11233         declaration.
11234
11235 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11236
11237         * aarch64-linux-nat.c
11238         (aarch64_linux_nat_target::thread_architecture): Add override.
11239         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11240         each VQ.
11241
11242 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11243
11244         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11245
11246 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11247
11248         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11249         target types of size 96-bits, add some additional comments, and
11250         check that the builtin type we found was the correct size.
11251
11252 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11253
11254         * utils.c (prompt_for_continue): Don't restore the styling at the
11255         end, as applied_style has the wrong value.  This fixes styling in
11256         long lists of file names that are interrupted by the "Continue?"
11257         prompt.
11258
11259 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11260
11261         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11262         * c-lang.c (c_language_defn): Likewise.
11263         (cplus_language_defn): Likewise.
11264         (asm_language_defn): Likewise.
11265         (minimal_language_defn): Likewise.
11266         * d-lang.c (d_language_defn): Likewise.
11267         * f-lang.c (f_language_defn): Likewise.
11268         * go-lang.c (go_language_defn): Likewise.
11269         * language.c (unknown_language_defn): Likewise.
11270         (auto_language_defn): Likewise.
11271         * language.h (struct language_defn): Remove la_magic field.
11272         (LANG_MAGIC): Delete.
11273         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11274         * objc-lang.c (objc_language_defn): Likewise.
11275         * opencl-lang.c (opencl_language_defn): Likewise.
11276         * p-lang.c (pascal_language_defn): Likewise.
11277         * rust-lang.c (rust_language_defn): Likewise.
11278
11279 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11280
11281         * riscv-tdep.c (riscv_type_align): New function.
11282         (riscv_type_alignment): Delete.
11283         (riscv_arg_location): Use 'type_align'.
11284         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11285
11286 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11287
11288         * gdbtypes.c (type_align): A struct with no non-static fields also
11289         has alignment of 1.
11290
11291 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11292
11293         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11294         component to 0.
11295         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11296         member.
11297         (riscv_struct_info::analyse): New implementation using new
11298         analyse_inner member function.
11299         (riscv_struct_info::field_offset): New member function.
11300         (riscv_struct_info::m_offsets): New member variable.
11301         (riscv_struct_info::analyse_inner): New private member function,
11302         takes the old implementation of riscv_struct_info::analyse but
11303         extended to track field offsets.
11304         (riscv_call_arg_struct): Update the struct folding special cases
11305         to handle cases where empty C++ structs, which are non-zero
11306         length, are found.
11307         (riscv_arg_location): Initialise the length of each location, a
11308         non-zero length now indicates the location is in use.
11309         (riscv_push_dummy_call): Allow for the first location having a
11310         non-zero offset when setting up arguments.
11311         (riscv_return_value): Likewise, but for return values.
11312
11313 2019-04-11  Tom Tromey  <tromey@adacore.com>
11314
11315         * utils.c (internal_vproblem): Make "msg" const.
11316
11317 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11318
11319         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11320         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11321         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11322         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11323
11324 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11325
11326         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11327         function.
11328         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11329         of amd64_collect_native_gregset.
11330         (amd64_linux_nat_target::store_registers): Likewise.
11331
11332 2019-04-10  Tom Tromey  <tom@tromey.com>
11333
11334         * symtab.c (lookup_global_symbol_from_objfile)
11335         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11336         * objfiles.h (class separate_debug_iterator): New.
11337         (class separate_debug_range): New.
11338         (struct objfile) <separate_debug_objfiles>: New method.
11339         (objfile_separate_debug_iterate): Don't declare.
11340         * objfiles.c (separate_debug_iterator::operator++): Rename from
11341         objfile_separate_debug_iterate.
11342         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11343         iterator.
11344         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11345         iterator.
11346
11347 2019-04-10  Tom Tromey  <tom@tromey.com>
11348
11349         * symfile.c (reread_symbols): Remove old comment.
11350         * objfiles.c (free_all_objfiles): Fix a typo.
11351
11352 2019-04-10  Tom Tromey  <tom@tromey.com>
11353
11354         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11355         * minsyms.c (lookup_minimal_symbol): Use foreach.
11356         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11357         (lookup_minimal_symbol_solib_trampoline): Likewise.
11358         * symfile.c (reread_symbols): Use foreach.
11359
11360 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11361             Tom Tromey  <tromey@adacore.com>
11362
11363         PR rust/24414:
11364         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11365         (rust_lex_int_test): Change "value" to be LONGEST.
11366         (rust_lex_tests): Add test for long integer literal.
11367
11368 2019-04-09  Tom Tromey  <tromey@adacore.com>
11369
11370         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11371         to bool.
11372         (extended_remote_target::attach): Update.
11373         (remote_target::remote_notice_new_inferior): Update.
11374         (remote_target::add_current_inferior_and_thread): Update.
11375         * inferior.c (exit_inferior_1): Use "false".
11376         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11377
11378 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11379
11380         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11381         the "start" command.
11382
11383 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11384
11385         * python/py-inferior.c (infpy_thread_from_thread_handle):
11386         Adjust comments to reflect renaming of thread_from_thread_handle
11387         to thread_from_handle.  Adjust keywords.  Fix type error message.
11388         (inferior_object_methods): Add thread_from_handle.  Retain
11389         thread_from_thread_handle, but mark it as deprecated.
11390
11391 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11392
11393         * gdbthread.h (find_thread_by_handle): Revise declaration.
11394         * thread.c (find_thread_by_handle): Likewise.  Adjust
11395         implementation too.
11396         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11397         support for buffer objects as handles.
11398
11399 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11400
11401         * python/py-infthread.c (thpy_thread_handle): New function.
11402         (thread_object_methods): Register thpy_thread_handle.
11403
11404 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11405
11406         * gdbthread.h (thread_to_thread_handle): Declare.
11407         * thread.c (gdbtypes.h): Include.
11408         (thread_to_thread_handle): New function.
11409
11410         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11411         (target_thread_info_to_thread_handle): Declare.
11412         * target.c (target_thread_info_to_thread_handle): New function.
11413         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11414         * target-delegates.c: Regenerate.
11415
11416         * linux-thread-db.c (class thread_db_target): Add method
11417         thread_info_to_thread_handle.
11418         (thread_db_target::thread_info_to_thread_handle): Define.
11419         * remote.c (class remote_target): Add new method
11420         thread_info_to_thread_handle.
11421         (remote_target::thread_info_to_thread_handle): Define.
11422
11423 2019-04-08  Pedro Alves  <palves@redhat.com>
11424
11425         * common/common-exceptions.c (throw_exception): Don't create
11426         named object to throw; throw directly.
11427         (throw_it): Likewise.  Don't initialize gdb_exception::message
11428         here, with new; pass FMT and AP to the ctor instead.
11429         * common/common-exceptions.h: Include <string>.
11430         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11431         const char *, va_list)): New ctor.  Use std::make_shared.
11432         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11433         errors)): Delete.
11434         (gdb_exception_error::gdb_exception_error(enum errors, const char
11435         *, va_list)): New.
11436         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11437         Add assertion.
11438         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11439         errors)): Delete.
11440         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11441         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11442         Add assertion.
11443
11444 2019-04-08  Tom Tromey  <tom@tromey.com>
11445
11446         * valops.c (value_rtti_indirect_type): Replace throw_exception
11447         with throw.
11448         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11449         with throw.
11450         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11451         throw.
11452         * target.c (target_translate_tls_address): Replace throw_exception
11453         with throw.
11454         * stack.c (frame_apply_command_count): Replace throw_exception
11455         with throw.
11456         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11457         throw.
11458         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11459         with throw.
11460         * rs6000-tdep.c (rs6000_frame_cache)
11461         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11462         * remote.c: Replace throw_exception with throw.
11463         * record-full.c (record_full_message, record_full_wait_1)
11464         (record_full_restore): Replace throw_exception with throw.
11465         * record-btrace.c:
11466         (get_thread_current_frame_id, record_btrace_start_replaying)
11467         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11468         (cmd_record_btrace_start): Replace throw_exception with throw.
11469         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11470         throw.
11471         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11472         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11473         * linespec.c:
11474         (find_linespec_symbols): Replace throw_exception with throw.
11475         * infrun.c (displaced_step_prepare, resume): Replace
11476         throw_exception with throw.
11477         * infcmd.c (post_create_inferior): Replace throw_exception with
11478         throw.
11479         * inf-loop.c (inferior_event_handler): Replace throw_exception
11480         with throw.
11481         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11482         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11483         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11484         (get_prev_frame_always, get_frame_pc_if_available)
11485         (get_frame_address_in_block_if_available, get_frame_language):
11486         Replace throw_exception with throw.
11487         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11488         throw_exception with throw.
11489         * eval.c (fetch_subexp_value, evaluate_var_value)
11490         (evaluate_funcall, evaluate_subexp_standard): Replace
11491         throw_exception with throw.
11492         * dwarf2loc.c (call_site_find_chain)
11493         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11494         Replace throw_exception with throw.
11495         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11496         with throw.
11497         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11498         throw.
11499         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11500         * completer.c (complete_line_internal): Replace throw_exception
11501         with throw.
11502         * compile/compile-object-run.c (compile_object_run): Replace
11503         throw_exception with throw.
11504         * cli/cli-script.c (process_next_line): Replace throw_exception
11505         with throw.
11506         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11507         (btrace_enable, btrace_maint_update_pt_packets): Replace
11508         throw_exception with throw.
11509         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11510         throw_exception with throw.
11511         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11512         throw_exception with throw.
11513         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11514         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11515         * aarch64-tdep.c (aarch64_make_prologue_cache)
11516         (aarch64_make_stub_cache): Replace throw_exception with throw.
11517
11518 2019-04-08  Tom Tromey  <tom@tromey.com>
11519
11520         * common/common-exceptions.c (throw_exception): Rename from
11521         throw_exception_cxx.  Remove old copy.  Make argument const.
11522         (throw_it): Create and throw exception objects directly.
11523         * common/common-exceptions.h (throw_exception): Make argument
11524         const.
11525         (struct gdb_exception_error): Add constructor.
11526         (struct gdb_exception_quit): Add constructor.
11527
11528 2019-04-08  Tom Tromey  <tom@tromey.com>
11529
11530         * common/common-exceptions.h (exception_rethrow): Don't declare.
11531         (TRY_SJLJ): Update comment.
11532         (TRY, CATCH, END_CATCH): Remove.
11533         * common/common-exceptions.c (exception_rethrow): Remove.
11534
11535 2019-04-08  Tom Tromey  <tom@tromey.com>
11536
11537         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11538         Remove.
11539         (gdb_exception_error): Rename from
11540         gdb_exception_RETURN_MASK_ERROR.
11541         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11542         (gdb_quit_bad_alloc): Update.
11543         * aarch64-tdep.c: Update.
11544         * ada-lang.c: Update.
11545         * ada-typeprint.c: Update.
11546         * ada-valprint.c: Update.
11547         * amd64-tdep.c: Update.
11548         * arch-utils.c: Update.
11549         * break-catch-throw.c: Update.
11550         * breakpoint.c: Update.
11551         * btrace.c: Update.
11552         * c-varobj.c: Update.
11553         * cli/cli-cmds.c: Update.
11554         * cli/cli-interp.c: Update.
11555         * cli/cli-script.c: Update.
11556         * common/common-exceptions.c: Update.
11557         * common/new-op.c: Update.
11558         * common/selftest.c: Update.
11559         * compile/compile-c-symbols.c: Update.
11560         * compile/compile-cplus-symbols.c: Update.
11561         * compile/compile-object-load.c: Update.
11562         * compile/compile-object-run.c: Update.
11563         * completer.c: Update.
11564         * corelow.c: Update.
11565         * cp-abi.c: Update.
11566         * cp-support.c: Update.
11567         * cp-valprint.c: Update.
11568         * darwin-nat.c: Update.
11569         * disasm-selftests.c: Update.
11570         * dtrace-probe.c: Update.
11571         * dwarf-index-cache.c: Update.
11572         * dwarf-index-write.c: Update.
11573         * dwarf2-frame-tailcall.c: Update.
11574         * dwarf2-frame.c: Update.
11575         * dwarf2loc.c: Update.
11576         * dwarf2read.c: Update.
11577         * eval.c: Update.
11578         * event-loop.c: Update.
11579         * event-top.c: Update.
11580         * exec.c: Update.
11581         * f-valprint.c: Update.
11582         * fbsd-tdep.c: Update.
11583         * frame-unwind.c: Update.
11584         * frame.c: Update.
11585         * gdbtypes.c: Update.
11586         * gnu-v3-abi.c: Update.
11587         * guile/guile-internal.h: Update.
11588         * guile/scm-block.c: Update.
11589         * guile/scm-breakpoint.c: Update.
11590         * guile/scm-cmd.c: Update.
11591         * guile/scm-disasm.c: Update.
11592         * guile/scm-frame.c: Update.
11593         * guile/scm-lazy-string.c: Update.
11594         * guile/scm-math.c: Update.
11595         * guile/scm-param.c: Update.
11596         * guile/scm-ports.c: Update.
11597         * guile/scm-pretty-print.c: Update.
11598         * guile/scm-symbol.c: Update.
11599         * guile/scm-symtab.c: Update.
11600         * guile/scm-type.c: Update.
11601         * guile/scm-value.c: Update.
11602         * i386-linux-tdep.c: Update.
11603         * i386-tdep.c: Update.
11604         * inf-loop.c: Update.
11605         * infcall.c: Update.
11606         * infcmd.c: Update.
11607         * infrun.c: Update.
11608         * jit.c: Update.
11609         * language.c: Update.
11610         * linespec.c: Update.
11611         * linux-fork.c: Update.
11612         * linux-nat.c: Update.
11613         * linux-tdep.c: Update.
11614         * linux-thread-db.c: Update.
11615         * main.c: Update.
11616         * mi/mi-cmd-break.c: Update.
11617         * mi/mi-cmd-stack.c: Update.
11618         * mi/mi-interp.c: Update.
11619         * mi/mi-main.c: Update.
11620         * objc-lang.c: Update.
11621         * p-valprint.c: Update.
11622         * parse.c: Update.
11623         * ppc-linux-tdep.c: Update.
11624         * printcmd.c: Update.
11625         * python/py-arch.c: Update.
11626         * python/py-breakpoint.c: Update.
11627         * python/py-cmd.c: Update.
11628         * python/py-finishbreakpoint.c: Update.
11629         * python/py-frame.c: Update.
11630         * python/py-framefilter.c: Update.
11631         * python/py-gdb-readline.c: Update.
11632         * python/py-inferior.c: Update.
11633         * python/py-infthread.c: Update.
11634         * python/py-lazy-string.c: Update.
11635         * python/py-linetable.c: Update.
11636         * python/py-objfile.c: Update.
11637         * python/py-param.c: Update.
11638         * python/py-prettyprint.c: Update.
11639         * python/py-progspace.c: Update.
11640         * python/py-record-btrace.c: Update.
11641         * python/py-record.c: Update.
11642         * python/py-symbol.c: Update.
11643         * python/py-type.c: Update.
11644         * python/py-unwind.c: Update.
11645         * python/py-utils.c: Update.
11646         * python/py-value.c: Update.
11647         * python/python.c: Update.
11648         * record-btrace.c: Update.
11649         * record-full.c: Update.
11650         * remote-fileio.c: Update.
11651         * remote.c: Update.
11652         * riscv-tdep.c: Update.
11653         * rs6000-aix-tdep.c: Update.
11654         * rs6000-tdep.c: Update.
11655         * rust-exp.y: Update.
11656         * rust-lang.c: Update.
11657         * s390-tdep.c: Update.
11658         * selftest-arch.c: Update.
11659         * solib-dsbt.c: Update.
11660         * solib-frv.c: Update.
11661         * solib-spu.c: Update.
11662         * solib-svr4.c: Update.
11663         * solib.c: Update.
11664         * sparc64-linux-tdep.c: Update.
11665         * stack.c: Update.
11666         * symfile-mem.c: Update.
11667         * symmisc.c: Update.
11668         * target.c: Update.
11669         * thread.c: Update.
11670         * top.c: Update.
11671         * tracefile-tfile.c: Update.
11672         * tui/tui.c: Update.
11673         * typeprint.c: Update.
11674         * unittests/cli-utils-selftests.c: Update.
11675         * unittests/parse-connection-spec-selftests.c: Update.
11676         * valops.c: Update.
11677         * valprint.c: Update.
11678         * value.c: Update.
11679         * varobj.c: Update.
11680         * windows-nat.c: Update.
11681         * x86-linux-nat.c: Update.
11682         * xml-support.c: Update.
11683
11684 2019-04-08  Tom Tromey  <tom@tromey.com>
11685
11686         * xml-support.c: Use C++ exception handling.
11687         * x86-linux-nat.c: Use C++ exception handling.
11688         * windows-nat.c: Use C++ exception handling.
11689         * varobj.c: Use C++ exception handling.
11690         * value.c: Use C++ exception handling.
11691         * valprint.c: Use C++ exception handling.
11692         * valops.c: Use C++ exception handling.
11693         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11694         handling.
11695         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11696         * typeprint.c: Use C++ exception handling.
11697         * tui/tui.c: Use C++ exception handling.
11698         * tracefile-tfile.c: Use C++ exception handling.
11699         * top.c: Use C++ exception handling.
11700         * thread.c: Use C++ exception handling.
11701         * target.c: Use C++ exception handling.
11702         * symmisc.c: Use C++ exception handling.
11703         * symfile-mem.c: Use C++ exception handling.
11704         * stack.c: Use C++ exception handling.
11705         * sparc64-linux-tdep.c: Use C++ exception handling.
11706         * solib.c: Use C++ exception handling.
11707         * solib-svr4.c: Use C++ exception handling.
11708         * solib-spu.c: Use C++ exception handling.
11709         * solib-frv.c: Use C++ exception handling.
11710         * solib-dsbt.c: Use C++ exception handling.
11711         * selftest-arch.c: Use C++ exception handling.
11712         * s390-tdep.c: Use C++ exception handling.
11713         * rust-lang.c: Use C++ exception handling.
11714         * rust-exp.y: Use C++ exception handling.
11715         * rs6000-tdep.c: Use C++ exception handling.
11716         * rs6000-aix-tdep.c: Use C++ exception handling.
11717         * riscv-tdep.c: Use C++ exception handling.
11718         * remote.c: Use C++ exception handling.
11719         * remote-fileio.c: Use C++ exception handling.
11720         * record-full.c: Use C++ exception handling.
11721         * record-btrace.c: Use C++ exception handling.
11722         * python/python.c: Use C++ exception handling.
11723         * python/py-value.c: Use C++ exception handling.
11724         * python/py-utils.c: Use C++ exception handling.
11725         * python/py-unwind.c: Use C++ exception handling.
11726         * python/py-type.c: Use C++ exception handling.
11727         * python/py-symbol.c: Use C++ exception handling.
11728         * python/py-record.c: Use C++ exception handling.
11729         * python/py-record-btrace.c: Use C++ exception handling.
11730         * python/py-progspace.c: Use C++ exception handling.
11731         * python/py-prettyprint.c: Use C++ exception handling.
11732         * python/py-param.c: Use C++ exception handling.
11733         * python/py-objfile.c: Use C++ exception handling.
11734         * python/py-linetable.c: Use C++ exception handling.
11735         * python/py-lazy-string.c: Use C++ exception handling.
11736         * python/py-infthread.c: Use C++ exception handling.
11737         * python/py-inferior.c: Use C++ exception handling.
11738         * python/py-gdb-readline.c: Use C++ exception handling.
11739         * python/py-framefilter.c: Use C++ exception handling.
11740         * python/py-frame.c: Use C++ exception handling.
11741         * python/py-finishbreakpoint.c: Use C++ exception handling.
11742         * python/py-cmd.c: Use C++ exception handling.
11743         * python/py-breakpoint.c: Use C++ exception handling.
11744         * python/py-arch.c: Use C++ exception handling.
11745         * printcmd.c: Use C++ exception handling.
11746         * ppc-linux-tdep.c: Use C++ exception handling.
11747         * parse.c: Use C++ exception handling.
11748         * p-valprint.c: Use C++ exception handling.
11749         * objc-lang.c: Use C++ exception handling.
11750         * mi/mi-main.c: Use C++ exception handling.
11751         * mi/mi-interp.c: Use C++ exception handling.
11752         * mi/mi-cmd-stack.c: Use C++ exception handling.
11753         * mi/mi-cmd-break.c: Use C++ exception handling.
11754         * main.c: Use C++ exception handling.
11755         * linux-thread-db.c: Use C++ exception handling.
11756         * linux-tdep.c: Use C++ exception handling.
11757         * linux-nat.c: Use C++ exception handling.
11758         * linux-fork.c: Use C++ exception handling.
11759         * linespec.c: Use C++ exception handling.
11760         * language.c: Use C++ exception handling.
11761         * jit.c: Use C++ exception handling.
11762         * infrun.c: Use C++ exception handling.
11763         * infcmd.c: Use C++ exception handling.
11764         * infcall.c: Use C++ exception handling.
11765         * inf-loop.c: Use C++ exception handling.
11766         * i386-tdep.c: Use C++ exception handling.
11767         * i386-linux-tdep.c: Use C++ exception handling.
11768         * guile/scm-value.c: Use C++ exception handling.
11769         * guile/scm-type.c: Use C++ exception handling.
11770         * guile/scm-symtab.c: Use C++ exception handling.
11771         * guile/scm-symbol.c: Use C++ exception handling.
11772         * guile/scm-pretty-print.c: Use C++ exception handling.
11773         * guile/scm-ports.c: Use C++ exception handling.
11774         * guile/scm-param.c: Use C++ exception handling.
11775         * guile/scm-math.c: Use C++ exception handling.
11776         * guile/scm-lazy-string.c: Use C++ exception handling.
11777         * guile/scm-frame.c: Use C++ exception handling.
11778         * guile/scm-disasm.c: Use C++ exception handling.
11779         * guile/scm-cmd.c: Use C++ exception handling.
11780         * guile/scm-breakpoint.c: Use C++ exception handling.
11781         * guile/scm-block.c: Use C++ exception handling.
11782         * guile/guile-internal.h: Use C++ exception handling.
11783         * gnu-v3-abi.c: Use C++ exception handling.
11784         * gdbtypes.c: Use C++ exception handling.
11785         * frame.c: Use C++ exception handling.
11786         * frame-unwind.c: Use C++ exception handling.
11787         * fbsd-tdep.c: Use C++ exception handling.
11788         * f-valprint.c: Use C++ exception handling.
11789         * exec.c: Use C++ exception handling.
11790         * event-top.c: Use C++ exception handling.
11791         * event-loop.c: Use C++ exception handling.
11792         * eval.c: Use C++ exception handling.
11793         * dwarf2read.c: Use C++ exception handling.
11794         * dwarf2loc.c: Use C++ exception handling.
11795         * dwarf2-frame.c: Use C++ exception handling.
11796         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11797         * dwarf-index-write.c: Use C++ exception handling.
11798         * dwarf-index-cache.c: Use C++ exception handling.
11799         * dtrace-probe.c: Use C++ exception handling.
11800         * disasm-selftests.c: Use C++ exception handling.
11801         * darwin-nat.c: Use C++ exception handling.
11802         * cp-valprint.c: Use C++ exception handling.
11803         * cp-support.c: Use C++ exception handling.
11804         * cp-abi.c: Use C++ exception handling.
11805         * corelow.c: Use C++ exception handling.
11806         * completer.c: Use C++ exception handling.
11807         * compile/compile-object-run.c: Use C++ exception handling.
11808         * compile/compile-object-load.c: Use C++ exception handling.
11809         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11810         * compile/compile-c-symbols.c: Use C++ exception handling.
11811         * common/selftest.c: Use C++ exception handling.
11812         * common/new-op.c: Use C++ exception handling.
11813         * cli/cli-script.c: Use C++ exception handling.
11814         * cli/cli-interp.c: Use C++ exception handling.
11815         * cli/cli-cmds.c: Use C++ exception handling.
11816         * c-varobj.c: Use C++ exception handling.
11817         * btrace.c: Use C++ exception handling.
11818         * breakpoint.c: Use C++ exception handling.
11819         * break-catch-throw.c: Use C++ exception handling.
11820         * arch-utils.c: Use C++ exception handling.
11821         * amd64-tdep.c: Use C++ exception handling.
11822         * ada-valprint.c: Use C++ exception handling.
11823         * ada-typeprint.c: Use C++ exception handling.
11824         * ada-lang.c: Use C++ exception handling.
11825         * aarch64-tdep.c: Use C++ exception handling.
11826
11827 2019-04-08  Tom Tromey  <tom@tromey.com>
11828
11829         * xml-support.c (gdb_xml_parser::parse): Update.
11830         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11831         * value.c (show_convenience): Update.
11832         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11833         (test_parse_flags_qcs): Update.
11834         * thread.c (thr_try_catch_cmd): Update.
11835         * target.c (target_translate_tls_address): Update.
11836         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11837         (info_frame_command_core, frame_apply_command_count): Update.
11838         * rust-exp.y (rust_lex_exception_test): Update.
11839         * riscv-tdep.c (riscv_print_one_register_info): Update.
11840         * remote.c (remote_target::enable_btrace): Update.
11841         * record-btrace.c (record_btrace_enable_warn): Update.
11842         * python/py-utils.c (gdbpy_convert_exception): Update.
11843         * printcmd.c (do_one_display, print_variable_and_value): Update.
11844         * mi/mi-main.c (mi_print_exception): Update.
11845         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11846         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11847         * linux-nat.c (linux_nat_target::attach): Update.
11848         * linux-fork.c (class scoped_switch_fork_info): Update.
11849         * infrun.c (displaced_step_prepare): Update.
11850         * infcall.c (call_function_by_hand_dummy): Update.
11851         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11852         * gnu-v3-abi.c (print_one_vtable): Update.
11853         * frame.c (get_prev_frame_always): Update.
11854         * f-valprint.c (info_common_command_for_block): Update.
11855         * exec.c (try_open_exec_file): Update.
11856         * exceptions.c (print_exception, exception_print)
11857         (exception_fprintf, exception_print_same): Update.
11858         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11859         * dwarf-index-cache.c (index_cache::store)
11860         (index_cache::lookup_gdb_index): Update.
11861         * darwin-nat.c (maybe_cache_shell): Update.
11862         * cp-valprint.c (cp_print_value_fields): Update.
11863         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11864         (gcc_cplus_symbol_address): Update.
11865         * compile/compile-c-symbols.c (gcc_convert_symbol)
11866         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11867         * common/selftest.c: Update.
11868         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11869         a std::string.
11870         (exception_try_scope_entry, exception_try_scope_exit): Don't
11871         declare.
11872         (struct exception_try_scope): Remove.
11873         (TRY): Don't use exception_try_scope.
11874         (struct gdb_exception): Add constructor, operator=.
11875         <what>: New method.
11876         (struct gdb_exception_RETURN_MASK_ALL)
11877         (struct gdb_exception_RETURN_MASK_ERROR)
11878         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11879         (struct gdb_quit_bad_alloc): Update.
11880         * common/common-exceptions.c (exception_none): Change
11881         initializer.
11882         (struct catcher) <state, exception>: Initialize inline.
11883         <prev>: Remove member.
11884         (current_catcher): Remove.
11885         (catchers): New global.
11886         (exceptions_state_mc_init): Simplify.
11887         (catcher_pop): Remove.
11888         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11889         (try_scope_depth, exception_try_scope_entry)
11890         (exception_try_scope_exit): Remove.
11891         (throw_exception_sjlj): Update.
11892         (exception_messages, exception_messages_size): Remove.
11893         (throw_it): Simplify.
11894         (gdb_exception_sliced_copy): Remove.
11895         (throw_exception_cxx): Update.
11896         * cli/cli-script.c (script_from_file): Update.
11897         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11898         Update.
11899         * ada-valprint.c (ada_val_print): Update.
11900         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11901         (create_excep_cond_exprs): Update.
11902
11903 2019-04-08  Tom Tromey  <tom@tromey.com>
11904
11905         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11906         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11907         (TRY, CATCH, END_CATCH): Remove some definitions.
11908         * common/common-exceptions.c: Don't use GDB_XCPT.
11909         (catcher_list_size): Remove.
11910         (throw_exception, throw_it): Simplify.
11911
11912 2019-04-05  Tom Tromey  <tom@tromey.com>
11913
11914         Revert the header-sorting patch.
11915         * ft32-tdep.c: Revert.
11916         * frv-tdep.c: Revert.
11917         * frv-linux-tdep.c: Revert.
11918         * frame.c: Revert.
11919         * frame-unwind.c: Revert.
11920         * frame-base.c: Revert.
11921         * fork-child.c: Revert.
11922         * findvar.c: Revert.
11923         * findcmd.c: Revert.
11924         * filesystem.c: Revert.
11925         * filename-seen-cache.h: Revert.
11926         * filename-seen-cache.c: Revert.
11927         * fbsd-tdep.c: Revert.
11928         * fbsd-nat.h: Revert.
11929         * fbsd-nat.c: Revert.
11930         * f-valprint.c: Revert.
11931         * f-typeprint.c: Revert.
11932         * f-lang.c: Revert.
11933         * extension.h: Revert.
11934         * extension.c: Revert.
11935         * extension-priv.h: Revert.
11936         * expprint.c: Revert.
11937         * exec.h: Revert.
11938         * exec.c: Revert.
11939         * exceptions.c: Revert.
11940         * event-top.c: Revert.
11941         * event-loop.c: Revert.
11942         * eval.c: Revert.
11943         * elfread.c: Revert.
11944         * dwarf2read.h: Revert.
11945         * dwarf2read.c: Revert.
11946         * dwarf2loc.c: Revert.
11947         * dwarf2expr.h: Revert.
11948         * dwarf2expr.c: Revert.
11949         * dwarf2-frame.c: Revert.
11950         * dwarf2-frame-tailcall.c: Revert.
11951         * dwarf-index-write.h: Revert.
11952         * dwarf-index-write.c: Revert.
11953         * dwarf-index-common.c: Revert.
11954         * dwarf-index-cache.h: Revert.
11955         * dwarf-index-cache.c: Revert.
11956         * dummy-frame.c: Revert.
11957         * dtrace-probe.c: Revert.
11958         * disasm.h: Revert.
11959         * disasm.c: Revert.
11960         * disasm-selftests.c: Revert.
11961         * dictionary.c: Revert.
11962         * dicos-tdep.c: Revert.
11963         * demangle.c: Revert.
11964         * dcache.h: Revert.
11965         * dcache.c: Revert.
11966         * darwin-nat.h: Revert.
11967         * darwin-nat.c: Revert.
11968         * darwin-nat-info.c: Revert.
11969         * d-valprint.c: Revert.
11970         * d-namespace.c: Revert.
11971         * d-lang.c: Revert.
11972         * ctf.c: Revert.
11973         * csky-tdep.c: Revert.
11974         * csky-linux-tdep.c: Revert.
11975         * cris-tdep.c: Revert.
11976         * cris-linux-tdep.c: Revert.
11977         * cp-valprint.c: Revert.
11978         * cp-support.c: Revert.
11979         * cp-namespace.c: Revert.
11980         * cp-abi.c: Revert.
11981         * corelow.c: Revert.
11982         * corefile.c: Revert.
11983         * continuations.c: Revert.
11984         * completer.h: Revert.
11985         * completer.c: Revert.
11986         * complaints.c: Revert.
11987         * coffread.c: Revert.
11988         * coff-pe-read.c: Revert.
11989         * cli-out.h: Revert.
11990         * cli-out.c: Revert.
11991         * charset.c: Revert.
11992         * c-varobj.c: Revert.
11993         * c-valprint.c: Revert.
11994         * c-typeprint.c: Revert.
11995         * c-lang.c: Revert.
11996         * buildsym.c: Revert.
11997         * buildsym-legacy.c: Revert.
11998         * build-id.h: Revert.
11999         * build-id.c: Revert.
12000         * btrace.c: Revert.
12001         * bsd-uthread.c: Revert.
12002         * breakpoint.h: Revert.
12003         * breakpoint.c: Revert.
12004         * break-catch-throw.c: Revert.
12005         * break-catch-syscall.c: Revert.
12006         * break-catch-sig.c: Revert.
12007         * blockframe.c: Revert.
12008         * block.c: Revert.
12009         * bfin-tdep.c: Revert.
12010         * bfin-linux-tdep.c: Revert.
12011         * bfd-target.c: Revert.
12012         * bcache.c: Revert.
12013         * ax-general.c: Revert.
12014         * ax-gdb.h: Revert.
12015         * ax-gdb.c: Revert.
12016         * avr-tdep.c: Revert.
12017         * auxv.c: Revert.
12018         * auto-load.c: Revert.
12019         * arm-wince-tdep.c: Revert.
12020         * arm-tdep.c: Revert.
12021         * arm-symbian-tdep.c: Revert.
12022         * arm-pikeos-tdep.c: Revert.
12023         * arm-obsd-tdep.c: Revert.
12024         * arm-nbsd-tdep.c: Revert.
12025         * arm-nbsd-nat.c: Revert.
12026         * arm-linux-tdep.c: Revert.
12027         * arm-linux-nat.c: Revert.
12028         * arm-fbsd-tdep.c: Revert.
12029         * arm-fbsd-nat.c: Revert.
12030         * arm-bsd-tdep.c: Revert.
12031         * arch-utils.c: Revert.
12032         * arc-tdep.c: Revert.
12033         * arc-newlib-tdep.c: Revert.
12034         * annotate.h: Revert.
12035         * annotate.c: Revert.
12036         * amd64-windows-tdep.c: Revert.
12037         * amd64-windows-nat.c: Revert.
12038         * amd64-tdep.c: Revert.
12039         * amd64-sol2-tdep.c: Revert.
12040         * amd64-obsd-tdep.c: Revert.
12041         * amd64-obsd-nat.c: Revert.
12042         * amd64-nbsd-tdep.c: Revert.
12043         * amd64-nbsd-nat.c: Revert.
12044         * amd64-nat.c: Revert.
12045         * amd64-linux-tdep.c: Revert.
12046         * amd64-linux-nat.c: Revert.
12047         * amd64-fbsd-tdep.c: Revert.
12048         * amd64-fbsd-nat.c: Revert.
12049         * amd64-dicos-tdep.c: Revert.
12050         * amd64-darwin-tdep.c: Revert.
12051         * amd64-bsd-nat.c: Revert.
12052         * alpha-tdep.c: Revert.
12053         * alpha-obsd-tdep.c: Revert.
12054         * alpha-nbsd-tdep.c: Revert.
12055         * alpha-mdebug-tdep.c: Revert.
12056         * alpha-linux-tdep.c: Revert.
12057         * alpha-linux-nat.c: Revert.
12058         * alpha-bsd-tdep.c: Revert.
12059         * alpha-bsd-nat.c: Revert.
12060         * aix-thread.c: Revert.
12061         * agent.c: Revert.
12062         * addrmap.c: Revert.
12063         * ada-varobj.c: Revert.
12064         * ada-valprint.c: Revert.
12065         * ada-typeprint.c: Revert.
12066         * ada-tasks.c: Revert.
12067         * ada-lang.c: Revert.
12068         * aarch64-tdep.c: Revert.
12069         * aarch64-ravenscar-thread.c: Revert.
12070         * aarch64-newlib-tdep.c: Revert.
12071         * aarch64-linux-tdep.c: Revert.
12072         * aarch64-linux-nat.c: Revert.
12073         * aarch64-fbsd-tdep.c: Revert.
12074         * aarch64-fbsd-nat.c: Revert.
12075         * aarch32-linux-nat.c: Revert.
12076
12077 2019-04-05  Tom Tromey  <tom@tromey.com>
12078
12079         * ft32-tdep.c: Sort headers.
12080         * frv-tdep.c: Sort headers.
12081         * frv-linux-tdep.c: Sort headers.
12082         * frame.c: Sort headers.
12083         * frame-unwind.c: Sort headers.
12084         * frame-base.c: Sort headers.
12085         * fork-child.c: Sort headers.
12086         * findvar.c: Sort headers.
12087         * findcmd.c: Sort headers.
12088         * filesystem.c: Sort headers.
12089         * filename-seen-cache.h: Sort headers.
12090         * filename-seen-cache.c: Sort headers.
12091         * fbsd-tdep.c: Sort headers.
12092         * fbsd-nat.h: Sort headers.
12093         * fbsd-nat.c: Sort headers.
12094         * f-valprint.c: Sort headers.
12095         * f-typeprint.c: Sort headers.
12096         * f-lang.c: Sort headers.
12097         * extension.h: Sort headers.
12098         * extension.c: Sort headers.
12099         * extension-priv.h: Sort headers.
12100         * expprint.c: Sort headers.
12101         * exec.h: Sort headers.
12102         * exec.c: Sort headers.
12103         * exceptions.c: Sort headers.
12104         * event-top.c: Sort headers.
12105         * event-loop.c: Sort headers.
12106         * eval.c: Sort headers.
12107         * elfread.c: Sort headers.
12108         * dwarf2read.h: Sort headers.
12109         * dwarf2read.c: Sort headers.
12110         * dwarf2loc.c: Sort headers.
12111         * dwarf2expr.h: Sort headers.
12112         * dwarf2expr.c: Sort headers.
12113         * dwarf2-frame.c: Sort headers.
12114         * dwarf2-frame-tailcall.c: Sort headers.
12115         * dwarf-index-write.h: Sort headers.
12116         * dwarf-index-write.c: Sort headers.
12117         * dwarf-index-common.c: Sort headers.
12118         * dwarf-index-cache.h: Sort headers.
12119         * dwarf-index-cache.c: Sort headers.
12120         * dummy-frame.c: Sort headers.
12121         * dtrace-probe.c: Sort headers.
12122         * disasm.h: Sort headers.
12123         * disasm.c: Sort headers.
12124         * disasm-selftests.c: Sort headers.
12125         * dictionary.c: Sort headers.
12126         * dicos-tdep.c: Sort headers.
12127         * demangle.c: Sort headers.
12128         * dcache.h: Sort headers.
12129         * dcache.c: Sort headers.
12130         * darwin-nat.h: Sort headers.
12131         * darwin-nat.c: Sort headers.
12132         * darwin-nat-info.c: Sort headers.
12133         * d-valprint.c: Sort headers.
12134         * d-namespace.c: Sort headers.
12135         * d-lang.c: Sort headers.
12136         * ctf.c: Sort headers.
12137         * csky-tdep.c: Sort headers.
12138         * csky-linux-tdep.c: Sort headers.
12139         * cris-tdep.c: Sort headers.
12140         * cris-linux-tdep.c: Sort headers.
12141         * cp-valprint.c: Sort headers.
12142         * cp-support.c: Sort headers.
12143         * cp-namespace.c: Sort headers.
12144         * cp-abi.c: Sort headers.
12145         * corelow.c: Sort headers.
12146         * corefile.c: Sort headers.
12147         * continuations.c: Sort headers.
12148         * completer.h: Sort headers.
12149         * completer.c: Sort headers.
12150         * complaints.c: Sort headers.
12151         * coffread.c: Sort headers.
12152         * coff-pe-read.c: Sort headers.
12153         * cli-out.h: Sort headers.
12154         * cli-out.c: Sort headers.
12155         * charset.c: Sort headers.
12156         * c-varobj.c: Sort headers.
12157         * c-valprint.c: Sort headers.
12158         * c-typeprint.c: Sort headers.
12159         * c-lang.c: Sort headers.
12160         * buildsym.c: Sort headers.
12161         * buildsym-legacy.c: Sort headers.
12162         * build-id.h: Sort headers.
12163         * build-id.c: Sort headers.
12164         * btrace.c: Sort headers.
12165         * bsd-uthread.c: Sort headers.
12166         * breakpoint.h: Sort headers.
12167         * breakpoint.c: Sort headers.
12168         * break-catch-throw.c: Sort headers.
12169         * break-catch-syscall.c: Sort headers.
12170         * break-catch-sig.c: Sort headers.
12171         * blockframe.c: Sort headers.
12172         * block.c: Sort headers.
12173         * bfin-tdep.c: Sort headers.
12174         * bfin-linux-tdep.c: Sort headers.
12175         * bfd-target.c: Sort headers.
12176         * bcache.c: Sort headers.
12177         * ax-general.c: Sort headers.
12178         * ax-gdb.h: Sort headers.
12179         * ax-gdb.c: Sort headers.
12180         * avr-tdep.c: Sort headers.
12181         * auxv.c: Sort headers.
12182         * auto-load.c: Sort headers.
12183         * arm-wince-tdep.c: Sort headers.
12184         * arm-tdep.c: Sort headers.
12185         * arm-symbian-tdep.c: Sort headers.
12186         * arm-pikeos-tdep.c: Sort headers.
12187         * arm-obsd-tdep.c: Sort headers.
12188         * arm-nbsd-tdep.c: Sort headers.
12189         * arm-nbsd-nat.c: Sort headers.
12190         * arm-linux-tdep.c: Sort headers.
12191         * arm-linux-nat.c: Sort headers.
12192         * arm-fbsd-tdep.c: Sort headers.
12193         * arm-fbsd-nat.c: Sort headers.
12194         * arm-bsd-tdep.c: Sort headers.
12195         * arch-utils.c: Sort headers.
12196         * arc-tdep.c: Sort headers.
12197         * arc-newlib-tdep.c: Sort headers.
12198         * annotate.h: Sort headers.
12199         * annotate.c: Sort headers.
12200         * amd64-windows-tdep.c: Sort headers.
12201         * amd64-windows-nat.c: Sort headers.
12202         * amd64-tdep.c: Sort headers.
12203         * amd64-sol2-tdep.c: Sort headers.
12204         * amd64-obsd-tdep.c: Sort headers.
12205         * amd64-obsd-nat.c: Sort headers.
12206         * amd64-nbsd-tdep.c: Sort headers.
12207         * amd64-nbsd-nat.c: Sort headers.
12208         * amd64-nat.c: Sort headers.
12209         * amd64-linux-tdep.c: Sort headers.
12210         * amd64-linux-nat.c: Sort headers.
12211         * amd64-fbsd-tdep.c: Sort headers.
12212         * amd64-fbsd-nat.c: Sort headers.
12213         * amd64-dicos-tdep.c: Sort headers.
12214         * amd64-darwin-tdep.c: Sort headers.
12215         * amd64-bsd-nat.c: Sort headers.
12216         * alpha-tdep.c: Sort headers.
12217         * alpha-obsd-tdep.c: Sort headers.
12218         * alpha-nbsd-tdep.c: Sort headers.
12219         * alpha-mdebug-tdep.c: Sort headers.
12220         * alpha-linux-tdep.c: Sort headers.
12221         * alpha-linux-nat.c: Sort headers.
12222         * alpha-bsd-tdep.c: Sort headers.
12223         * alpha-bsd-nat.c: Sort headers.
12224         * aix-thread.c: Sort headers.
12225         * agent.c: Sort headers.
12226         * addrmap.c: Sort headers.
12227         * ada-varobj.c: Sort headers.
12228         * ada-valprint.c: Sort headers.
12229         * ada-typeprint.c: Sort headers.
12230         * ada-tasks.c: Sort headers.
12231         * ada-lang.c: Sort headers.
12232         * aarch64-tdep.c: Sort headers.
12233         * aarch64-ravenscar-thread.c: Sort headers.
12234         * aarch64-newlib-tdep.c: Sort headers.
12235         * aarch64-linux-tdep.c: Sort headers.
12236         * aarch64-linux-nat.c: Sort headers.
12237         * aarch64-fbsd-tdep.c: Sort headers.
12238         * aarch64-fbsd-nat.c: Sort headers.
12239         * aarch32-linux-nat.c: Sort headers.
12240
12241 2019-04-04  Tom Tromey  <tom@tromey.com>
12242
12243         * varobj.c (varobj_create): Update.
12244         * rust-exp.y (struct rust_parser) <update_innermost_block,
12245         lookup_symbol>: New methods.
12246         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12247         Rename.
12248         (rust_parser::rust_lookup_type)
12249         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12250         * printcmd.c (display_command, do_one_display): Update.
12251         * parser-defs.h (struct parser_state) <parser_state>: Add
12252         "tracker" parameter.
12253         (block_tracker): New member.
12254         (class innermost_block_tracker) <innermost_block_tracker>: Add
12255         "types" parameter.
12256         <reset>: Remove method.
12257         (innermost_block): Don't declare.
12258         (null_post_parser): Update.
12259         * parse.c (innermost_block): Remove global.
12260         (write_dollar_variable): Update.
12261         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12262         Remove "tracker_types" parameter.
12263         (parse_expression): Add "tracker" parameter.
12264         (parse_expression_for_completion): Update.
12265         (null_post_parser): Add "tracker" parameter.
12266         * p-exp.y: Update rules.
12267         * m2-exp.y: Update rules.
12268         * language.h (struct language_defn) <la_post_parser>: Add
12269         "tracker" parameter.
12270         * go-exp.y: Update rules.
12271         * f-exp.y: Update rules.
12272         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12273         parameter.
12274         * d-exp.y: Update rules.
12275         * c-exp.y: Update rules.
12276         * breakpoint.c (set_breakpoint_condition): Create an
12277         innermost_block_tracker.
12278         (watch_command_1): Likewise.
12279         * ada-lang.c (resolve): Add "tracker" parameter.
12280         (resolve_subexp): Likewise.
12281         * ada-exp.y (write_var_from_sym): Update.
12282
12283 2019-04-04  Tom Tromey  <tom@tromey.com>
12284
12285         * type-stack.h: New file.
12286         * type-stack.c: New file.
12287         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12288         type-stack.h.
12289         (insert_into_type_stack, insert_type, push_type, push_type_int)
12290         (insert_type_address_space, pop_type, pop_type_int)
12291         (pop_typelist, pop_type_stack, append_type_stack)
12292         (push_type_stack, get_type_stack, push_typelist)
12293         (follow_type_instance_flags, follow_types): Don't declare.
12294         * parse.c (type_stack): Remove global.
12295         (parse_exp_in_context): Update.
12296         (insert_into_type_stack, insert_type, push_type, push_type_int)
12297         (insert_type_address_space, pop_type, pop_type_int)
12298         (pop_typelist, pop_type_stack, append_type_stack)
12299         (push_type_stack, get_type_stack, push_typelist)
12300         (follow_type_instance_flags, follow_types): Remove (moved to
12301         type-stack.c).
12302         * f-exp.y (type_stack): New global.
12303         Update rules.
12304         (push_kind_type, f_parse): Update.
12305         * d-exp.y (type_stack): New global.
12306         Update rules.
12307         (d_parse): Update.
12308         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12309         Update rules.
12310         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12311         (HFILES_NO_SRCDIR): Add type-stack.h.
12312
12313 2019-04-04  Tom Tromey  <tom@tromey.com>
12314
12315         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12316         (rust_parser::convert_ast_to_expression, rust_parse)
12317         (rust_lex_test_completion, rust_lex_tests): Update.
12318         * parser-defs.h (struct expr_completion_state): New.
12319         (struct parser_state) <parser_state>: Add completion parameter.
12320         <mark_struct_expression, mark_completion_tag>: New methods.
12321         <parse_completion, m_completion_state>: New members.
12322         (prefixify_expression, null_post_parser): Update.
12323         (mark_struct_expression, mark_completion_tag): Don't declare.
12324         * parse.c (parse_completion, expout_last_struct)
12325         (expout_tag_completion_type, expout_completion_name): Remove
12326         globals.
12327         (parser_state::mark_struct_expression)
12328         (parser_state::mark_completion_tag): Now methods.
12329         (prefixify_expression): Add last_struct parameter.
12330         (prefixify_subexp): Likewise.
12331         (parse_exp_1): Update.
12332         (parse_exp_in_context): Add cstate parameter.  Update.
12333         (parse_expression_for_completion): Create an
12334         expr_completion_state.
12335         (null_post_parser): Add "completion" parameter.
12336         * p-exp.y: Update rules.
12337         (yylex): Update.
12338         * language.h (struct language_defn) <la_post_parser>: Add
12339         "completing" parameter.
12340         * go-exp.y: Update rules.
12341         (lex_one_token): Update.
12342         * expression.h (parse_completion): Don't declare.
12343         * d-exp.y: Update rules.
12344         (lex_one_token): Update rules.
12345         * c-exp.y: Update rules.
12346         (lex_one_token): Update.
12347         * ada-lang.c (resolve): Add "parse_completion" parameter.
12348         (resolve_subexp): Likewise.
12349         (ada_resolve_function): Likewise.
12350
12351 2019-04-04  Tom Tromey  <tom@tromey.com>
12352
12353         * parser-defs.h (struct parser_state) <start_arglist,
12354         end_arglist>: New methods.
12355         <arglist_len, m_funcall_chain>: New members.
12356         (arglist_len, start_arglist, end_arglist): Don't declare.
12357         * parse.c (arglist_len, funcall_chain): Remove global.
12358         (start_arglist, end_arglist): Remove functions.
12359         (parse_exp_in_context): Update.
12360         * p-exp.y: Update rules.
12361         * m2-exp.y: Update rules.
12362         * go-exp.y: Update rules.
12363         * f-exp.y: Update rules.
12364         * d-exp.y: Update rules.
12365         * c-exp.y: Update rules.
12366
12367 2019-04-04  Tom Tromey  <tom@tromey.com>
12368
12369         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12370         lex_operator, push_back>: New methods.
12371         Update all rules.
12372         (rust_parser::lex_hex, lex_escape): Rename and update.
12373         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12374         (rust_parser::lex_operator): Rename and update.
12375         (rust_parser::lex_number, rustyylex, rustyyerror)
12376         (rust_lex_test_init, rust_lex_test_sequence)
12377         (rust_lex_test_push_back, rust_lex_tests): Update.
12378         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12379         parameter.
12380         <lexptr, prev_lexptr>: New members.
12381         (lexptr, prev_lexptr): Don't declare.
12382         * parse.c (lexptr, prev_lexptr): Remove globals.
12383         (parse_exp_in_context): Update.
12384         * p-exp.y (yylex, yyerror): Update.
12385         * m2-exp.y (parse_number, yylex, yyerror): Update.
12386         * go-exp.y (lex_one_token, yyerror): Update.
12387         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12388         * d-exp.y (lex_one_token, yyerror): Update.
12389         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12390         (lex_one_token, yyerror): Update.
12391         * ada-lex.l (YY_INPUT): Update.
12392         (rewind_to_char): Update.
12393         * ada-exp.y (yyerror): Update.
12394
12395 2019-04-04  Tom Tromey  <tom@tromey.com>
12396
12397         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12398         * parser-defs.h (struct parser_state) <parser_state>: Add new
12399         parameter.
12400         <comma_terminates>: New member.
12401         (comma_terminates): Don't declare global.
12402         * parse.c (comma_terminates): Remove global.
12403         (parse_exp_in_context): Update.
12404         * p-exp.y (yylex): Update.
12405         * m2-exp.y (yylex): Update.
12406         * go-exp.y (lex_one_token): Update.
12407         * f-exp.y (yylex): Update.
12408         * d-exp.y (lex_one_token): Update.
12409         * c-exp.y (lex_one_token): Update.
12410         * ada-lex.l: Update.
12411
12412 2019-04-04  Tom Tromey  <tom@tromey.com>
12413
12414         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12415         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12416         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12417         * parser-defs.h (paren_depth): Don't declare.
12418         * parse.c (paren_depth): Remove global.
12419         (parse_exp_in_context): Update.
12420         * p-exp.y (paren_depth): New global.
12421         (pascal_parse): Initialize it.
12422         * m2-exp.y (paren_depth): New global.
12423         (m2_parse): Initialize it.
12424         * go-exp.y (paren_depth): New global.
12425         (go_parse): Initialize it.
12426         * f-exp.y (paren_depth): New global.
12427         (f_parse): Initialize it.
12428         * d-exp.y (paren_depth): New global.
12429         (d_parse): Initialize it.
12430         * c-exp.y (paren_depth): New global.
12431         (c_parse): Initialize it.
12432         * ada-lex.l (paren_depth): New global.
12433         (lexer_init): Initialize it.
12434
12435 2019-04-04  Tom Tromey  <tom@tromey.com>
12436
12437         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12438         (rust_parser::convert_ast_to_type)
12439         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12440         * parser-defs.h (struct parser_state) <parser_state>: Add
12441         parameters.  Initialize new members.
12442         <expression_context_block, expression_context_pc>: New members.
12443         * parse.c (expression_context_block, expression_context_pc):
12444         Remove globals.
12445         (parse_exp_in_context): Update.
12446         * p-exp.y: Update all rules.
12447         (yylex): Update.
12448         * m2-exp.y: Update all rules.
12449         (yylex): Update.
12450         * go-exp.y (yylex): Update.
12451         * f-exp.y (yylex): Update.
12452         * d-exp.y: Update all rules.
12453         (yylex): Update.
12454         * c-exp.y: Update all rules.
12455         (lex_one_token, classify_name, yylex, c_parse): Update.
12456         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12457
12458 2019-04-04  Tom Tromey  <tom@tromey.com>
12459
12460         * gdbarch.h, gdbarch.c: Rebuild.
12461         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12462         * stap-probe.h:
12463         (struct stap_parse_info): Replace "parser_state" with
12464         "expr_builder".
12465         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12466         (parser_state): New class.
12467         * parse.c (expr_builder): Rename.
12468         (expr_builder::release): Rename.
12469         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12470         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12471         (write_exp_elt_longcst, write_exp_elt_floatcst)
12472         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12473         (write_exp_string_vector, write_exp_bitstring)
12474         (write_exp_msymbol, mark_struct_expression)
12475         (write_dollar_variable)
12476         (insert_type_address_space, increase_expout_size): Replace
12477         "parser_state" with "expr_builder".
12478         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12479         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12480         "parser_state" with "expr_builder".
12481
12482 2019-04-04  Tom Tromey  <tom@tromey.com>
12483
12484         * rust-exp.y: Replace "parse_language" with method call.
12485         * p-exp.y:
12486         (yylex): Replace "parse_language" with method call.
12487         * m2-exp.y:
12488         (yylex): Replace "parse_language" with method call.
12489         * go-exp.y (classify_name): Replace "parse_language" with method
12490         call.
12491         * f-exp.y (yylex): Replace "parse_language" with method call.
12492         * d-exp.y (lex_one_token): Replace "parse_language" with method
12493         call.
12494         * c-exp.y:
12495         (lex_one_token, classify_name, yylex): Replace "parse_language"
12496         with method call.
12497         * ada-exp.y (find_primitive_type, type_char)
12498         (type_system_address): Replace "parse_language" with method call.
12499
12500 2019-04-04  Tom Tromey  <tom@tromey.com>
12501
12502         * rust-exp.y: Replace "parse_gdbarch" with method call.
12503         * parse.c (write_dollar_variable, insert_type_address_space):
12504         Replace "parse_gdbarch" with method call.
12505         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12506         call.
12507         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12508         call.
12509         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12510         "parse_gdbarch" with method call.
12511         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12512         with method call.
12513         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12514         "parse_gdbarch" with method call.
12515         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12516         "parse_gdbarch" with method call.
12517         * c-exp.y (parse_type, parse_number, classify_name): Replace
12518         "parse_gdbarch" with method call.
12519         * ada-lex.l: Replace "parse_gdbarch" with method call.
12520         * ada-exp.y (parse_type, find_primitive_type, type_char)
12521         (type_system_address): Replace "parse_gdbarch" with method call.
12522
12523 2019-04-04  Tom Tromey  <tom@tromey.com>
12524
12525         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12526         * stap-probe.c (stap_parse_argument): Update.
12527         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12528         initial_size parameter.
12529         * rust-exp.y (rust_lex_tests): Update.
12530         * parse.c (parser_state): Update.
12531         (parse_exp_in_context): Update.
12532         * parser-defs.h (struct parser_state) <parser_state>: Remove
12533         "initial_size" parameter.
12534
12535 2019-04-04  Tom Tromey  <tom@tromey.com>
12536
12537         * parser-defs.h (increase_expout_size): Don't declare.
12538         * parse.c (increase_expout_size): Now static.
12539
12540 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12541
12542         * gnu-nat.c (gnu_nat_target::wait): Fix
12543         target_waitstatus_to_string call.
12544
12545 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12546
12547         * eval.c (evaluate_subexp_standard): Handle internal functions
12548         during Fortran function call handling.
12549
12550 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12551
12552         * NEWS: Mention new internal functions.
12553         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12554         (read_base_type): Use dwarf2_init_complex_target_type.
12555         * value.c (creal_internal_fn): New function.
12556         (cimag_internal_fn): New function.
12557         (_initialize_values): Register new internal functions.
12558
12559 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12560
12561         * infrun.c (stop_all_threads): If debug_infrun, always
12562         trace the wait status after wait_one, using
12563         target_waitstatus_to_string and target_pid_to_str.
12564         (handle_inferior_event): Replace various trace of
12565         wait status kind by a single trace.
12566         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12567         wait status kind image by target_waitstatus_to_string.
12568         * target/waitstatus.c (target_waitstatus_to_string): Fix
12569         obsolete comment.
12570
12571 2019-04-01  Tom Tromey  <tromey@adacore.com>
12572
12573         PR symtab/23331:
12574         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12575
12576 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12577             Pedro Alves  <palves@redhat.com>
12578
12579         * top.c (quit_force): Call 'finalize_values'.
12580         * value.c (finalize_values): New function.
12581         * value.h (finalize_values): Declare.
12582
12583 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12584
12585         * NEWS: Announce $_gdb_major and $_gdb_minor.
12586
12587         * top.c (init_gdb_version_vars): New function.
12588         (gdb_init): Call init_gdb_version_vars.
12589
12590 2019-03-29  Tom Tromey  <tromey@adacore.com>
12591
12592         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12593         help text.  Remove dead code.
12594
12595 2019-03-29  Keith Seitz  <keiths@redhat.com>
12596
12597         From Siddhesh Poyarekar:
12598         * f-lang.h (f77_get_upperbound): Return LONGEST.
12599         (f77_get_lowerbound): Likewise.
12600         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12601         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12602         print them.
12603         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12604         plongest to format print it.
12605         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12606         (f77_get_upperbound): Likewise.
12607         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12608         LOWER_BOUND to LONGEST.
12609         (f77_create_arrayprint_offset_tbl): Likewise.
12610
12611 2019-03-29  Keith Seitz  <keiths@redhat.com>
12612
12613         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12614         %s/pulongest for TYPE_LENGTH instead of %d in format
12615         strings.
12616         * ada-typerint.c (ada_print_type): Likewise.
12617         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12618         * compile/compile-c-support.c (generate_register_struct): Likewise.
12619         * gdbtypes.c (recursive_dump_type): Likewise.
12620         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12621         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12622         instead of %d in format strings.
12623         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12624         to std::min to ULONGEST.
12625         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12626         instead of %d in format strings.
12627         * tracepoint.c (info_scope_command): Likewise.
12628         * typeprint.c (print_offset_data::update)
12629         (print_offset_data::finish): Likewise.
12630         * xtensa-tdep.c (xtensa_store_return_value)
12631         (xtensa_push_dummy_call): Likewise.
12632
12633 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12634
12635         * windows-nat.c (display_selector): Fixed format specifications
12636         for 64-bit Cygwin.
12637
12638 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12639
12640         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12641
12642 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12643
12644         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12645         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12646         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12647         (nios2_linux_init_abi): Install it.
12648
12649 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12650
12651         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12652
12653 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12654
12655         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12656
12657 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12658             Tom Tromey  <tromey@adacore.com>
12659
12660         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12661
12662 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12663
12664         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12665         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12666         method to compute the bounds of range types. Also print "[evaluated]"
12667         if the bounds' values come from a dynamic evaluation.
12668
12669 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12670
12671         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12672         whitespace when pretty printing is on.
12673
12674 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12675
12676         * ppc-linux-nat.c: Add include.
12677
12678 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12679
12680         * NEWS: Mention AArch64 Pointer Authentication.
12681
12682 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12683
12684         * arm-linux-nat.c: Add include.
12685
12686 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12687
12688         * source-cache.c (source_cache::get_source_lines): Re-read
12689         fullname after calling open_source_file.
12690
12691 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12692
12693         * NEWS: Mention TLS support for FreeBSD.
12694
12695 2019-03-25  Tom Tromey  <tromey@adacore.com>
12696
12697         * minsyms.c (BUNCH_SIZE): Update comment.
12698         (~minimal_symbol_reader): Remove old comment.
12699         (compact_minimal_symbols): Update comment.
12700         (minimal_symbol_reader::install): Remove old comment.  Update
12701         other comments.
12702
12703 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12704
12705         * s390-linux-nat.c: Add include.
12706
12707 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12708
12709         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12710         Call linux_get_hwcap.
12711         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12712         Likewise.
12713         (aarch64_linux_get_hwcap): Remove function.
12714         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12715         declaration.
12716         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12717         linux_get_hwcap.
12718         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12719         * linux-tdep.c (linux_get_hwcap): Add function.
12720         (linux_get_hwcap2): Likewise.
12721         * linux-tdep.h (linux_get_hwcap): Add declaration.
12722         (linux_get_hwcap2): Likewise.
12723         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12724         (ppc_linux_get_hwcap2): Likewise.
12725         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12726         linux_get_hwcap.
12727         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12728         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12729         (ppc_linux_nat_target::read_description): Likewise.
12730         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12731         * s390-linux-nat.c: Likewise.
12732         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12733
12734 2019-03-24  Tom Tromey  <tom@tromey.com>
12735
12736         * ada-lang.c (standard_lookup): Simplify initialization.
12737         (ada_lookup_symbol_nonlocal): Simplify return.
12738         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12739         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12740         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12741         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12742         initialization.
12743         * solib.c (solib_global_lookup): Simplify.
12744         * symtab.c (null_block_symbol): Remove.
12745         (symbol_cache_lookup): Simplify returns.
12746         (lookup_language_this): Simplify returns.
12747         (lookup_symbol_aux): Simplify return.
12748         (lookup_local_symbol): Simplify returns.
12749         (lookup_global_symbol_from_objfile): Simplify return.
12750         (lookup_symbol_in_objfile_symtabs)
12751         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12752         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12753         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12754         * cp-namespace.c (cp_lookup_bare_symbol)
12755         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12756         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12757         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12758         (cp_lookup_symbol_via_imports): Simplify initialization.
12759         (find_symbol_in_baseclass): Likewise.
12760         * symtab.h (null_block_symbol): Remove.
12761         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12762         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12763         (d_lookup_symbol_module): Likewise.
12764         (find_symbol_in_baseclass): Simplify initialization.
12765
12766 2019-03-24  Tom Tromey  <tom@tromey.com>
12767
12768         * expression.h: Don't include symtab.h.
12769         (struct block): Forward declare.
12770
12771 2019-03-24  Tom Tromey  <tom@tromey.com>
12772
12773         * c-exp.y (typebase): Remove casts.
12774         * gdbtypes.c (lookup_unsigned_typename, )
12775         (lookup_signed_typename): Remove cast.
12776         * eval.c (parse_to_comma_and_eval): Remove cast.
12777         * parse.c (write_dollar_variable): Remove cast.
12778         * block.h (struct block) <superblock>: Now const.
12779         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12780         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12781         (map_block): Make "block" const.
12782         * symfile.h (struct quick_symbol_functions)
12783         <map_matching_symbols>: Constify block argument to "callback".
12784         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12785         const.
12786         (find_pc_sect_compunit_symtab): Make "b" const.
12787         (find_symbol_at_address): Likewise.
12788         (search_symbols): Likewise.
12789         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12790         (dw2_debug_names_lookup_symbol): Likewise.
12791         (dw2_map_matching_symbols): Update.
12792         * p-valprint.c (pascal_val_print): Remove "block".
12793         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12794         (aux_add_nonlocal_symbols): Make "block" const.
12795         (resolve_subexp): Remove cast.
12796         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12797         const.
12798         (iterate_over_file_blocks): Likewise.
12799         * f-exp.y (%union) <bval>: Remove.
12800         * coffread.c (patch_opaque_types): Make "b" const.
12801         * spu-tdep.c (spu_catch_start): Make "block" const.
12802         * c-valprint.c (print_unpacked_pointer): Remove "block".
12803         * symmisc.c (dump_symtab_1): Make "b" const.
12804         (block_depth): Make "block" const.
12805         * d-exp.y (%union) <bval>: Remove.
12806         * cp-support.h (cp_lookup_rtti_type): Update.
12807         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12808         * psymtab.c (psym_lookup_symbol): Make "block" const.
12809         (maintenance_check_psymtabs): Make "b" const.
12810         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12811         (enumerate_locals, enumerate_args): Update.
12812         * python/py-symtab.c (stpy_global_block): Make "block" const.
12813         (stpy_static_block): Likewise.
12814         * inline-frame.c (block_starting_point_at): Make "new_block"
12815         const.
12816         * block.c (find_block_in_blockvector): Make return type const.
12817         (blockvector_for_pc_sect): Make "b" const.
12818         (find_block_in_blockvector): Make "b" const.
12819
12820 2019-03-23  Tom Tromey  <tom@tromey.com>
12821
12822         * varobj.c (varobj_create): Update.
12823         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12824         * printcmd.c (display_command, do_one_display): Don't reset
12825         innermost_block.
12826         * parser-defs.h (enum innermost_block_tracker_type): Move to
12827         expression.h.
12828         (innermost_block): Update comment.
12829         * parse.c (parse_exp_1): Add tracker_types parameter.
12830         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12831         tracker_types parameter.  Reset innermost_block.
12832         (parse_exp_in_context): Remove.
12833         (parse_expression_for_completion): Update.
12834         * objfiles.c (~objfile): Don't reset expression_context_block or
12835         innermost_block.
12836         * expression.h (enum innermost_block_tracker_type): Move from
12837         parser-defs.h.
12838         (parse_exp_1): Add tracker_types parameter.
12839         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12840         reset innermost_block.
12841
12842 2019-03-23  Tom Tromey  <tom@tromey.com>
12843
12844         * objfiles.h: Include bcache.h.
12845
12846 2019-03-23  Tom Tromey  <tom@tromey.com>
12847
12848         * linespec.c (get_current_search_block): Use
12849         scoped_restore_current_language.
12850         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12851
12852 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12853             Jiong Wang  <jiong.wang@arm.com>
12854
12855         * aarch64-linux-tdep.c
12856         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12857         section.
12858         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12859
12860 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12861             Jiong Wang  <jiong.wang@arm.com>
12862
12863         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12864         instructions.
12865         (aarch64_analyze_prologue_test): Add PACIASP test.
12866         (aarch64_prologue_prev_register): Unmask PC value.
12867
12868 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12869             Jiong Wang  <jiong.wang@arm.com>
12870
12871         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12872         (aarch64_dwarf2_prev_register): Unmask PC value.
12873         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12874         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12875         DW_CFA_AARCH64_negate_ra_state.
12876         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12877
12878 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12879             Jiong Wang  <jiong.wang@arm.com>
12880
12881         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12882         registers.
12883         (aarch64_pseudo_register_name): Likewise.
12884         (aarch64_pseudo_register_type): Likewise.
12885         (aarch64_pseudo_register_reggroup_p): Likewise.
12886         (aarch64_gdbarch_init): Add pauth registers.
12887         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12888         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12889         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12890         (struct gdbarch_tdep): Add regnum for ra_state.
12891
12892 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12893             Jiong Wang  <jiong.wang@arm.com>
12894
12895         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12896
12897 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12898             Jiong Wang  <jiong.wang@arm.com>
12899
12900         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12901         function.
12902         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12903         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12904         (aarch64_gdbarch_init): Add puth registers.
12905         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12906         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12907         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12908
12909 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12910             Jiong Wang  <jiong.wang@arm.com>
12911
12912         * aarch64-linux-nat.c
12913         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12914         * aarch64-linux-tdep.c
12915         (aarch64_linux_core_read_description): Likewise.
12916         (aarch64_linux_get_hwcap): New function.
12917         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12918         (aarch64_linux_get_hwcap): New declaration.
12919
12920 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12921             Jiong Wang  <jiong.wang@arm.com>
12922
12923         * aarch64-linux-nat.c
12924         (aarch64_linux_nat_target::read_description): Add pauth param.
12925         * aarch64-linux-tdep.c
12926         (aarch64_linux_core_read_description): Likewise.
12927         * aarch64-tdep.c (struct target_desc): Add in pauth.
12928         (aarch64_read_description): Add pauth param.
12929         (aarch64_gdbarch_init): Likewise.
12930         * aarch64-tdep.h (aarch64_read_description): Likewise.
12931         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12932         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12933         * features/Makefile: Add new files.
12934         * features/aarch64-pauth.c: New file.
12935         * features/aarch64-pauth.xml: New file.
12936
12937 2019-03-20  Tom Tromey  <tromey@adacore.com>
12938
12939         * infrun.c (handle_inferior_event): Rename from
12940         handle_inferior_event_1.  Create a scoped_value_mark.
12941         (handle_inferior_event): Remove.
12942
12943 2019-03-19  Tom Tromey  <tromey@adacore.com>
12944
12945         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12946         * infrun.h (print_stop_event): Add "displays" parameter.
12947         * infrun.c (print_stop_event): Add "displays" parameter.
12948
12949 2019-03-19  Pedro Alves  <palves@redhat.com>
12950
12951         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12952         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12953         to -1.  Fix TABs vs spaces.
12954         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12955         * tui/tui-out.h (tui_ui_out) Add intro comments.
12956         <m_line, m_start_of_line>: In-class initialize, and add describing
12957         comment.
12958
12959 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12960
12961         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12962         variable names.
12963         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12964
12965 2019-03-18  Pedro Alves  <palves@redhat.com>
12966             Eli Zaretskii <eliz@gnu.org>
12967
12968         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12969         m_line and m_start_of_line.
12970
12971 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12972
12973         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12974         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12975         it returns a newline.  This fixes a regression in TU mode, whereby
12976         the next line is output on the same screen line as the user input.
12977
12978 2019-03-18  Tom Tromey  <tromey@adacore.com>
12979
12980         * minsyms.c (minimal_symbol_reader::install): Remove call to
12981         obstack_blank.
12982
12983 2019-03-18  Pedro Alves  <palves@redhat.com>
12984
12985         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12986         New globals.
12987         (apply_style): New, factored out from ...
12988         (apply_ansi_escape): ... this.  Handle reverse video mode.
12989         (tui_set_reverse_mode): New function.
12990         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12991         * tui/tui-winsource.c (tui_show_source_line): Use
12992         tui_set_reverse_mode instead of setting A_STANDOUT.
12993         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12994         New setter methods.
12995
12996 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12997
12998         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12999         Handle tabs.
13000
13001 2019-03-18  Tom Tromey  <tromey@adacore.com>
13002
13003         * ada-lang.c (empty_array): Add "high" parameter.
13004         (ada_evaluate_subexp): Update.
13005
13006 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13007
13008         * unittests/string_view-selftests.c: Define
13009         _initialize_string_view_selftests unconditionally.
13010
13011 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13012
13013         PR gdb/24350
13014         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13015
13016 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13017
13018         PR gdb/24351
13019         * windows-nat.c (display_selector): Fix format specifiers.
13020
13021 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13022
13023         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13024         tui_refill_source_window instead of tui_refresh_win, to update the
13025         current execution line.  This fixes redisplay of the current line
13026         when stepping through the code with "next" or "step".
13027
13028 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13029
13030         * source-cache.c (source_cache::get_source_lines): Call
13031         find_source_lines to initialize s->nlines.  This fixes vertical
13032         scrolling of TUI source window when the DOWN arrow is pressed.
13033
13034 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13035
13036         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13037         linux-thread-db.c (_initialize_thread_db): Likewise.
13038
13039 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13040
13041         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13042         wclrtoeol in tui_show_source_line".  This reverts changes made in
13043         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13044
13045 2019-03-15  Tom Tromey  <tom@tromey.com>
13046
13047         * symtab.h (struct minimal_symbol): Derive from
13048         general_symbol_info.
13049         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13050         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13051         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13052         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13053         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13054         (MSYMBOL_SEARCH_NAME): Update.
13055         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13056         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13057         * minsyms.c (minimal_symbol_reader::record_full): Update.
13058
13059 2019-03-15  Tom Tromey  <tom@tromey.com>
13060
13061         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13062
13063 2019-03-15  Tom Tromey  <tom@tromey.com>
13064
13065         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13066         unique_xmalloc_ptr.
13067         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13068         Update.
13069         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13070         (build_minimal_symbol_hash_tables)
13071         (minimal_symbol_reader::install): Update.
13072
13073 2019-03-15  Tom Tromey  <tom@tromey.com>
13074
13075         * symtab.c (create_demangled_names_hash): Update.
13076         (symbol_set_names): Update.
13077         * objfiles.h (struct objfile_per_bfd_storage)
13078         <demangled_names_hash>: Now an htab_up.
13079         * objfiles.c (objfile_per_bfd_storage): Simplify.
13080
13081 2019-03-15  Tom Tromey  <tom@tromey.com>
13082
13083         * objfiles.h (struct objfile_per_bfd_storage): Declare
13084         destructor.
13085         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13086         New.
13087         (get_objfile_bfd_data): Use new.  Don't initialize
13088         language_of_main.
13089         (free_objfile_per_bfd_storage): Remove.
13090         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13091
13092 2019-03-15  Tom Tromey  <tom@tromey.com>
13093
13094         * symfile.c (reread_symbols): Update.
13095         * objfiles.c (objfile::objfile): Update.
13096         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13097         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13098         comment.
13099         (minimal_symbol_reader::install): Update.
13100         (terminate_minimal_symbol_table): Remove.
13101         * jit.c (jit_object_close_impl): Update.
13102
13103 2019-03-15  Tom Tromey  <tom@tromey.com>
13104
13105         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13106         initializations.
13107
13108 2019-03-15  Tom Tromey  <tom@tromey.com>
13109
13110         * objfiles.h (struct objfile_per_bfd_storage)
13111         <demangled_hash_languages>: Now a bitset.
13112         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13113         (lookup_minimal_symbol): Update.
13114
13115 2019-03-15  Tom Tromey  <tom@tromey.com>
13116
13117         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13118         Don't return the symbol.
13119         * coffread.c (record_minimal_symbol): Use record_full.
13120
13121 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13122
13123         The MS-Windows port of ncurses fails to switch to a color pair if
13124         one or both of the colors are the implicit default colors.  This
13125         change records the default colors when TUI is initialized, and
13126         then specifies them explicitly when a color pair uses the default
13127         colors.  This allows color styling in TUI mode on MS-Windows.
13128
13129         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13130         ncurses_norm_attr.
13131         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13132         colors in ncurses_norm_attr.
13133         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13134         "none", replace it with the default color recorded in
13135         ncurses_norm_attr.
13136
13137 2019-03-14  Tom Tromey  <tromey@adacore.com>
13138
13139         * source-cache.h (class source_cache) <get_source_lines>: Return
13140         std::string.
13141         * source-cache.c (source_cache::extract_lines): Handle case where
13142         first_pos==npos.  Return std::string.
13143         (source_cache::get_source_lines): Update.
13144
13145 2019-03-14  Tom Tromey  <tromey@adacore.com>
13146
13147         * NEWS: Add item for "style sources" commands.
13148         * source-cache.c (source_cache::get_source_lines): Check
13149         source_styling.
13150         * cli/cli-style.c (source_styling): New global.
13151         (_initialize_cli_style): Add "style sources" commands.
13152         (show_style_sources): New function.
13153         * cli/cli-style.h (source_styling): Declare.
13154
13155 2019-03-14  Pedro Alves  <palves@redhat.com>
13156             Tom Tromey  <tromey@adacore.com>
13157
13158         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13159         * tui/tui-winsource.c (tui_refill_source_window): New function,
13160         from...
13161         (tui_horizontal_source_scroll): ... here.  Move some logic.
13162         * cli/cli-style.c (set_style_enabled): Notify new observable.
13163         * tui/tui-hooks.c (tui_redisplay_source): New function.
13164         (tui_attach_detach_observers): Attach or detach
13165         tui_redisplay_source.
13166         * observable.h (source_styling_changed): New observable.
13167         * observable.c: Define source_styling_changed observable.
13168
13169 2019-03-13  Tom Tromey  <tromey@adacore.com>
13170
13171         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13172         (i386_gnu_nat_target::store_registers): Update.
13173         * target-debug.h (target_debug_print_std_string): New macro.
13174         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13175         * windows-tdep.c (display_one_tib): Update.
13176         * tui/tui-stack.c (tui_make_status_line): Update.
13177         * top.c (print_inferior_quit_action): Update.
13178         * thread.c (thr_try_catch_cmd): Update.
13179         (add_thread_with_info): Update.
13180         (thread_target_id_str): Update.
13181         (thr_try_catch_cmd): Update.
13182         (thread_command): Update.
13183         (thread_find_command): Update.
13184         * record-btrace.c (record_btrace_target::info_record)
13185         (record_btrace_resume_thread, record_btrace_target::resume)
13186         (record_btrace_cancel_resume, record_btrace_step_thread)
13187         (record_btrace_target::wait, record_btrace_target::wait)
13188         (record_btrace_target::wait, record_btrace_target::stop): Update.
13189         * progspace.c (print_program_space): Update.
13190         * process-stratum-target.c
13191         (process_stratum_target::thread_address_space): Update.
13192         * linux-fork.c (linux_fork_mourn_inferior)
13193         (detach_checkpoint_command, info_checkpoints_command)
13194         (linux_fork_context): Update.
13195         (linux_fork_detach): Update.
13196         (class scoped_switch_fork_info): Update.
13197         (delete_checkpoint_command): Update.
13198         * infrun.c (follow_fork_inferior): Update.
13199         (follow_fork_inferior): Update.
13200         (proceed_after_vfork_done): Update.
13201         (handle_vfork_child_exec_or_exit): Update.
13202         (follow_exec): Update.
13203         (displaced_step_prepare_throw): Update.
13204         (displaced_step_restore): Update.
13205         (start_step_over): Update.
13206         (resume_1): Update.
13207         (clear_proceed_status_thread): Update.
13208         (proceed): Update.
13209         (print_target_wait_results): Update.
13210         (do_target_wait): Update.
13211         (context_switch): Update.
13212         (stop_all_threads): Update.
13213         (restart_threads): Update.
13214         (finish_step_over): Update.
13215         (handle_signal_stop): Update.
13216         (switch_back_to_stepped_thread): Update.
13217         (keep_going_pass_signal): Update.
13218         (print_exited_reason): Update.
13219         (normal_stop): Update.
13220         * inferior.c (inferior_pid_to_str): Change return type.
13221         (print_selected_inferior): Update.
13222         (add_inferior): Update.
13223         (detach_inferior): Update.
13224         * dummy-frame.c (fprint_dummy_frames): Update.
13225         * dcache.c (dcache_info_1): Update.
13226         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13227         (btrace_fetch, btrace_clear): Update.
13228         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13229         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13230         type.
13231         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13232         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13233         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13234         * gdbarch.c, gdbarch.h: Rebuild.
13235         * gdbarch.sh (core_pid_to_str): Change return type.
13236         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13237         return type.
13238         (windows_nat_target::pid_to_str): Change return type.
13239         (windows_delete_thread): Update.
13240         (windows_nat_target::attach): Update.
13241         (windows_nat_target::files_info): Update.
13242         * target-delegates.c: Rebuild.
13243         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13244         return type.
13245         (sol_thread_target::pid_to_str): Change return type.
13246         * remote.c (class remote_target) <pid_to_str>: Change return
13247         type.
13248         (remote_target::pid_to_str): Change return type.
13249         (extended_remote_target::attach, remote_target::remote_stop_ns)
13250         (remote_target::remote_notif_remove_queued_reply)
13251         (remote_target::push_stop_reply, remote_target::disable_btrace):
13252         Update.
13253         (extended_remote_target::attach): Update.
13254         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13255         type.
13256         (gdbsim_target::pid_to_str): Change return type.
13257         * ravenscar-thread.c (struct ravenscar_thread_target)
13258         <pid_to_str>: Change return type.
13259         (ravenscar_thread_target::pid_to_str): Change return type.
13260         * procfs.c (class procfs_target) <pid_to_str>: Change return
13261         type.
13262         (procfs_target::pid_to_str): Change return type.
13263         (procfs_target::attach): Update.
13264         (procfs_target::detach): Update.
13265         (procfs_target::fetch_registers): Update.
13266         (procfs_target::store_registers): Update.
13267         (procfs_target::wait): Update.
13268         (procfs_target::files_info): Update.
13269         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13270         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13271         return type.
13272         (nto_procfs_target::pid_to_str): Change return type.
13273         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13274         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13275         return type.
13276         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13277         (exit_lwp): Update.
13278         (attach_proc_task_lwp_callback, get_detach_signal)
13279         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13280         (linux_nat_target::resume, wait_lwp, stop_callback)
13281         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13282         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13283         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13284         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13285         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13286         type.
13287         (inf_ptrace_target::attach): Update.
13288         (inf_ptrace_target::files_info): Update.
13289         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13290         type.
13291         (go32_nat_target::pid_to_str): Change return type.
13292         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13293         (gnu_nat_target::wait): Update.
13294         (gnu_nat_target::wait): Update.
13295         (gnu_nat_target::resume): Update.
13296         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13297         (fbsd_nat_target::wait): Update.
13298         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13299         type.
13300         (darwin_nat_target::attach): Update.
13301         * corelow.c (class core_target) <pid_to_str>: Change return type.
13302         (core_target::pid_to_str): Change return type.
13303         * target.c (normal_pid_to_str): Change return type.
13304         (default_pid_to_str): Likewise.
13305         (target_pid_to_str): Change return type.
13306         (target_translate_tls_address): Update.
13307         (target_announce_detach): Update.
13308         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13309         return type.
13310         (bsd_uthread_target::pid_to_str): Change return type.
13311         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13312         type.
13313         (bsd_kvm_target::pid_to_str): Change return type.
13314         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13315         return type.
13316         (aix_thread_target::pid_to_str): Change return type.
13317         * target.h (struct target_ops) <pid_to_str>: Change return type.
13318         (target_pid_to_str, normal_pid_to_str): Likewise.
13319         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13320         type.
13321         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13322         type.
13323         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13324         return type.
13325         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13326         type.
13327         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13328         type.
13329         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13330         return type.
13331
13332 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13333
13334         * NEWS: Mention that the new default MI version is 3.  Mention
13335         changes to the output of commands and events that deal with
13336         multi-location breakpoints.
13337         * breakpoint.c: Include "mi/mi-out.h".
13338         (print_one_breakpoint): Change output syntax if using MI version
13339         >= 3.
13340         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13341         New.
13342         (mi_multi_location_breakpoint_output_fixed): New.
13343         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13344         (mi_cmd_fix_multi_location_breakpoint_output): New.
13345         (mi_multi_location_breakpoint_output_fixed): New.
13346         * mi/mi-cmds.c (mi_cmds): Register command
13347         -fix-multi-location-breakpoint-output.
13348         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13349         interpreter "mi".
13350
13351 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13352
13353         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13354         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13355         instantiate mi_ui_out based on interpreter name.
13356         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13357         * mi/mi-main.c (mi_load_progress): Likewise.
13358
13359 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13360
13361         * NEWS: Combine separate "New targets" sections for 8.3.
13362
13363 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13364
13365         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13366         (ppcfbsd_init_abi): Install gdbarch
13367         "fetch_tls_load_module_address" and "get_thread_local_address"
13368         methods.
13369
13370 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13371
13372         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13373         (riscv_fbsd_init_abi): Install gdbarch
13374         "fetch_tls_load_module_address" and "get_thread_local_address"
13375         methods.
13376
13377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13378
13379         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13380         (i386fbsd_init_abi): Install gdbarch
13381         "fetch_tls_load_module_address" and "get_thread_local_address"
13382         methods.
13383
13384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13385
13386         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13387         (amd64fbsd_init_abi): Install gdbarch
13388         "fetch_tls_load_module_address" and "get_thread_local_address"
13389         methods.
13390
13391 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13392
13393         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13394         (struct fbsd_pspace_data): New type.
13395         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13396         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13397         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13398         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13399         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13400
13401 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13402
13403         * gdbtypes.c (lookup_struct_elt): New function.
13404         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13405         * gdbtypes.h (struct struct_elt): New type.
13406         (lookup_struct_elt): New prototype.
13407
13408 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13409
13410         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13411         remove disabled code block.
13412
13413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13414
13415         * gdbarch.sh (get_thread_local_address): New method.
13416         * gdbarch.h, gdbarch.c: Regenerate.
13417         * target.c (target_translate_tls_address): Use
13418         gdbarch_get_thread_local_address if present instead of
13419         target::get_thread_local_address.
13420
13421 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13422
13423         * target.h (target::get_thread_local_address): Update comment.
13424
13425 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13426
13427         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13428         objfile->separate_debug_objfile_backlink if not NULL.
13429
13430 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13431
13432         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13433         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13434         (amd64bsd_store_inferior_registers): Likewise.
13435         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13436         Enable segment base registers.
13437         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13438         PT_GETFSBASE and PT_GETGSBASE.
13439         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13440         PT_SETGSBASE.
13441         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13442         segment base registers.
13443         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13444
13445 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13446
13447         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13448         Update calls to i386_target_description to add 'segments'
13449         parameter.
13450         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13451         add segment base registers.
13452         * arch/i386.c (i386_create_target_description): Add 'segments'
13453         parameter to enable segment base registers.
13454         * arch/i386.h (i386_create_target_description): Likewise.
13455         * features/i386/32bit-segments.xml: New file.
13456         * features/i386/32bit-segments.c: Generate.
13457         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13458         call to i386_target_description to add 'segments' parameter.
13459         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13460         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13461         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13462         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13463         if feature is present.
13464         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13465         Add 'segments' parameter to call to i386_target_description.
13466         (i386_target_description): Add 'segments' parameter to enable
13467         segment base registers.
13468         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13469         to call to i386_target_description.
13470         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13471         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13472         Define I386_NUM_REGS.
13473         (i386_target_description): Add 'segments' parameter to enable
13474         segment base registers.
13475
13476 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13477
13478         PR/24325
13479         * source-cache.c: #undef open and close, to avoid unresolved
13480         externals during linking.
13481
13482 2019-03-12  Tom Tromey  <tromey@adacore.com>
13483
13484         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13485         const.  Add initializers.
13486         (_initialize_remote): Don't initialize ptid globals.
13487
13488 2019-03-12  Pedro Alves  <palves@redhat.com>
13489
13490         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13491
13492 2019-03-12  Pedro Alves  <palves@redhat.com>
13493
13494         * cp-name-parser.y (main): Remove unused 'len' variable.
13495
13496 2019-03-12  Tom Tromey  <tromey@adacore.com>
13497
13498         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13499         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13500
13501 2019-03-12  Tom Tromey  <tromey@adacore.com>
13502
13503         * linux-nat.c (iterate_over_lwps): Update.
13504         (stop_callback): Remove parameter.
13505         (stop_wait_callback, detach_callback, resume_set_callback)
13506         (select_singlestep_lwp_callback, set_ignore_sigint)
13507         (status_callback, resumed_callback, resume_clear_callback)
13508         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13509         data parameter.
13510         (linux_nat_target::detach, linux_nat_target::resume)
13511         (linux_stop_and_wait_all_lwps, select_event_lwp)
13512         (linux_nat_filter_event, linux_nat_wait_1)
13513         (linux_nat_target::kill, linux_nat_target::stop)
13514         (linux_nat_target::stop): Update.
13515         (linux_nat_resume_callback): Change type.
13516         (resume_stopped_resumed_lwps, count_events_callback)
13517         (select_event_lwp_callback): Likewise.
13518         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13519         * arm-linux-nat.c (struct update_registers_data): Remove.
13520         (update_registers_callback): Change type.
13521         (arm_linux_insert_hw_breakpoint1): Update.
13522         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13523         parameter.
13524         (x86_linux_dr_set_addr): Update.
13525         (x86_linux_dr_set_control): Update.
13526         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13527         (iterate_over_lwps): Use gdb::function_view.
13528         * nat/aarch64-linux-hw-point.c (struct
13529         aarch64_dr_update_callback_param): Remove.
13530         (debug_reg_change_callback): Change type.
13531         (aarch64_notify_debug_reg_change): Update.
13532         * s390-linux-nat.c (s390_refresh_per_info): Update.
13533
13534 2019-03-11  Tom Tromey  <tromey@adacore.com>
13535
13536         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13537         redundant assignment to "this_cu".
13538
13539 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13540
13541         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13542
13543 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13544
13545         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13546         from...
13547         (rank_one_type): ... this.
13548
13549 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13550
13551         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13552         from...
13553         (rank_one_type): ... this.
13554
13555 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13556
13557         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13558         from...
13559         (rank_one_type): ... this.
13560
13561 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13562
13563         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13564         from...
13565         (rank_one_type): ... this.
13566
13567 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13568
13569         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13570         from...
13571         (rank_one_type): ... this.
13572
13573 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13574
13575         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13576         from...
13577         (rank_one_type): ... this.
13578
13579 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13580
13581         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13582         from...
13583         (rank_one_type): ... this.
13584
13585 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13586
13587         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13588         from...
13589         (rank_one_type): ... this.
13590
13591 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13592
13593         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13594         from...
13595         (rank_one_type): ... this.
13596
13597 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13598
13599         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13600         from...
13601         (rank_one_type): ... this.
13602
13603 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13604
13605         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13606         from...
13607         (rank_one_type): ... this.
13608
13609 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13610
13611         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13612         from...
13613         (rank_one_type): ... this.
13614
13615 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13616
13617         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13618         inferior-events' shows the example events.
13619
13620 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13621
13622         Support styling on native MS-Windows console
13623
13624         PR/24315
13625         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13626         on MS-Windows if $TERM is not defined.
13627
13628         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13629
13630         * posix-hdep.c (gdb_console_fputs):
13631         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13632         functions.
13633         * ui-file.h (gdb_console_fputs): Add prototype.
13634
13635         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13636         back to fputs only if the former returns zero.
13637
13638 2019-03-07  Tom Tromey  <tom@tromey.com>
13639
13640         * symmisc.c (print_symbol_bcache_statistics): Update.
13641         (print_objfile_statistics): Update.
13642         * symfile.c (allocate_symtab): Update.
13643         * stabsread.c: Don't include bcache.h.
13644         * psymtab.h (struct psymbol_bcache): Don't declare.
13645         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13646         (psymbol_bcache_init, psymbol_bcache_free)
13647         (psymbol_bcache_get_bcache): Don't declare.
13648         * psymtab.c (struct psymbol_bcache): Remove.
13649         (psymtab_storage::psymtab_storage): Update.
13650         (psymtab_storage::~psymtab_storage): Update.
13651         (psymbol_bcache_init, psymbol_bcache_free)
13652         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13653         (add_psymbol_to_bcache): Update.
13654         (allocate_psymtab): Update.
13655         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13656         macro_cache>: No longer pointers.
13657         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13658         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13659         * macrotab.c (macro_bcache): Update.
13660         * macroexp.c: Don't include bcache.h.
13661         * gdbtypes.c (check_types_worklist): Update.
13662         (types_deeply_equal): Remove TRY/CATCH.  Update.
13663         * elfread.c (elf_symtab_read): Update.
13664         * dwarf2read.c: Don't include bcache.h.
13665         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13666         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13667         (print_bcache_statistics, bcache_memory_used): Don't declare.
13668         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13669         methods.  Rename all data members.
13670         * bcache.c (struct bcache): Move to bcache.h.
13671         (bcache::expand_hash_table): Rename from expand_hash_table.
13672         (bcache): Remove.
13673         (bcache::insert): Rename from bcache_full.
13674         (bcache::compare): Rename from bcache_compare.
13675         (bcache_xmalloc): Remove.
13676         (bcache::~bcache): Rename from bcache_xfree.
13677         (bcache::print_statistics): Rename from print_bcache_statistics.
13678         (bcache::memory_used): Rename from bcache_memory_used.
13679
13680 2019-03-07  Pedro Alves  <palves@redhat.com>
13681
13682         * infrun.c (normal_stop): Also check for
13683         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13684
13685 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13686
13687         * f-lang.c (value_from_host_double): Moved to...
13688         * value.c (value_from_host_double): ...here.
13689         * value.h (value_from_host_double): Declare.
13690         * guile/scm-math.c (vlscm_convert_typed_number): Use
13691         value_from_host_double.
13692         (vlscm_convert_number): Likewise.
13693         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13694         * python/py-value.c (convert_value_from_python): Likewise.
13695
13696 2019-03-06  Tom Tromey  <tom@tromey.com>
13697
13698         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13699
13700 2019-03-06  Tom Tromey  <tom@tromey.com>
13701
13702         * utils.h (free_current_contents): Don't declare.
13703         * utils.c (free_current_contents): Remove.
13704
13705 2019-03-06  Tom Tromey  <tom@tromey.com>
13706
13707         * top.c (quit_force): Update.
13708         * main.c (captured_command_loop): Update.
13709         * common/new-op.c (operator new): Update.
13710         * common/common-exceptions.c (struct catcher)
13711         <save_cleanup_chain>: Remove member.
13712         (exceptions_state_mc_init): Update.
13713         (exception_try_scope_entry): Return nullptr.
13714         (exception_try_scope_exit, exception_rethrow)
13715         (throw_exception_sjlj, throw_exception_cxx): Update.
13716         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13717         (all_cleanups, do_cleanups, discard_cleanups)
13718         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13719         (restore_cleanups, restore_final_cleanups): Don't declare.
13720         (do_final_cleanups): Remove parameter.
13721         * common/cleanups.c (cleanup_chain, make_cleanup)
13722         (make_cleanup_dtor, all_cleanups, do_cleanups)
13723         (discard_my_cleanups, discard_cleanups)
13724         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13725         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13726         (null_cleanup): Remove.
13727         (do_final_cleanups): Remove parameter.
13728
13729 2019-03-06  Tom Tromey  <tom@tromey.com>
13730
13731         * remote.c (remote_target::remote_parse_stop_reply): Use
13732         unique_xmalloc_ptr.
13733
13734 2019-03-06  Tom Tromey  <tom@tromey.com>
13735
13736         * stabsread.c (struct stabs_field_info): Rename from field_info.
13737         <list, fnlist>: Add initializers.
13738         <obstack>: New member.
13739         (read_member_functions, read_struct_fields, read_baseclasses):
13740         Allocate on obstack.  Don't use cleanups.
13741         (read_one_struct_field, read_member_functions, read_struct_fields)
13742         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13743         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13744         (read_struct_type): Update.
13745
13746 2019-03-06  Tom Tromey  <tom@tromey.com>
13747
13748         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13749         * common/filestuff.h (make_cleanup_close): Don't declare.
13750         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13751         Remove.
13752
13753 2019-03-06  Tom Tromey  <tom@tromey.com>
13754
13755         * solib-aix.c: Use make_scope_exit.
13756
13757 2019-03-06  Tom Tromey  <tom@tromey.com>
13758
13759         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13760         Use make_scope_exit.
13761
13762 2019-03-06  Tom Tromey  <tom@tromey.com>
13763
13764         * solib-svr4.c (disable_probes_interface): Remove parameter.
13765         (svr4_handle_solib_event): Use make_scope_exit.
13766
13767 2019-03-06  Tom Tromey  <tom@tromey.com>
13768
13769         * remote.c (struct stop_reply_deleter): Remove.
13770         (stop_reply_up): Update.
13771         (struct stop_reply): Derive from notif_event.  Don't typedef.
13772         <regcache>: Now a std::vector.
13773         (stop_reply_xfree): Remove.
13774         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13775         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13776         (remote_target::discard_pending_stop_replies): Use delete.
13777         (remote_target::remote_parse_stop_reply): Update.
13778         (remote_target::process_stop_reply): Update.
13779         * remote-notif.h (struct notif_event): Add virtual destructor.
13780         Remove "dtr" member.
13781         (struct notif_client) <alloc_event>: Return a unique_ptr.
13782         (notif_event_xfree): Don't declare.
13783         (notif_event_up): New typedef.
13784         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13785         (notif_event_xfree, do_notif_event_xfree): Remove.
13786         (remote_notif_state_xfree): Update.
13787
13788 2019-03-06  Tom Tromey  <tom@tromey.com>
13789
13790         * infrun.c (displaced_step_clear_cleanup): Now a
13791         forward_scope_exit type.
13792         (displaced_step_prepare_throw): Update.
13793         (displaced_step_fixup): Update.
13794
13795 2019-03-06  Tom Tromey  <tom@tromey.com>
13796
13797         * inferior.h (class inferior): Update comment.
13798         * gdbthread.h (class thread_info): Update comment.
13799
13800 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13801             Tom Tromey  <tom@tromey.com>
13802
13803         * stabsread.h (struct stab_section_list): Remove.
13804         (coffstab_build_psymtabs): Update.
13805         * dbxread.c (symbuf_sections): Now a std::vector.
13806         (sect_idx): New global.
13807         (fill_symbuf): Update.
13808         (coffstab_build_psymtabs): Change type of stabsects parameter.
13809         Update.
13810         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13811         std::vector.
13812         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13813         (coff_locate_sections): Update.
13814         (coff_symfile_read): Remove cleanups.  Update.
13815         (init_stringtab): Add storage parameter.
13816         (free_stringtab, free_stringtab_cleanup): Remove.
13817         (init_lineno): Add storage parameter.
13818         (free_linetab, free_linetab_cleanup): Remove.
13819
13820 2019-03-06  Pedro Alves  <palves@redhat.com>
13821
13822         * linux-fork.c (fork_info::clobber_regs): Delete.
13823         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13824         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13825         comment.  Adjust.
13826         (scoped_switch_fork_info::scoped_switch_fork_info)
13827         (checkpoint_command, linux_fork_context): Adjust
13828         fork_save_infrun_state calls.
13829
13830 2019-03-06  Pedro Alves  <palves@redhat.com>
13831
13832         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13833         (inf_has_multiple_threads): Return 'bool' and rewrite using
13834         inferior_info::threads().
13835
13836 2019-03-06  Pedro Alves  <palves@redhat.com>
13837
13838         * linux-fork.c: Include <list>.
13839         (fork_list): Now a std::list instance.
13840         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13841         (forks_exist_p, find_last_fork): Adjust.
13842         (new_fork): Delete.
13843         (one_fork_p): New.
13844         (add_fork): Adjust.
13845         (free_fork): Delete, folded into fork_info::~fork_info().
13846         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13847         Adjust.
13848         (init_fork_list): Delete.
13849         (linux_fork_killall, linux_fork_mourn_inferior)
13850         (linux_fork_detach, info_checkpoints_command): Adjust.
13851         (_initialize_linux_fork): No longer call init_fork_list.
13852
13853 2019-03-06  Pedro Alves  <palves@redhat.com>
13854
13855         * linux-fork.c (new_fork): New, split out of ...
13856         (add_fork): ... this.  Return void.  Move "first fork" special
13857         case from here, to ...
13858         (checkpoint_command): ... here.
13859         * linux-linux.h (add_fork): Return void.
13860
13861 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13862
13863         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13864
13865 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13866             Chris January  <chris.january@arm.com>
13867             David Lecomber  <david.lecomber@arm.com>
13868
13869         * f-exp.y: New token, UNOP_INTRINSIC.
13870         (exp): New pattern using UNOP_INTRINSIC token.
13871         (f77_keywords): Add 'abs' keyword.
13872         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13873         (value_from_host_double): New function.
13874         (evaluate_subexp_f): Support UNOP_ABS.
13875
13876 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13877
13878         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13879         types.
13880
13881 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13882
13883         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13884         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13885         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13886
13887 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13888
13889         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13890
13891 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13892             Chris January  <chris.january@arm.com>
13893
13894         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13895         * f-exp.y: Define 'KIND' token.
13896         (exp): New pattern for KIND expressions.
13897         (ptype): Handle types with a kind extension.
13898         (direct_abs_decl): Extend to spot kind extensions.
13899         (f77_keywords): Add 'kind' to the list.
13900         (push_kind_type): New function.
13901         (convert_to_kind_type): New function.
13902         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13903         * parse.c (operator_length_standard): Likewise.
13904         * parser-defs.h (enum type_pieces): Add tp_kind.
13905         * std-operator.def: Add UNOP_KIND.
13906
13907 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13908
13909         * f-exp.y (f_parse): Set yydebug.
13910
13911 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13912
13913         * f-lang.c (evaluate_subexp_f): New function.
13914         (exp_descriptor_f): New global.
13915         (f_language_defn): Use exp_descriptor_f instead of
13916         exp_descriptor_standard.
13917
13918 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13919
13920         * f-exp.y (struct token): Add comments.
13921         (dot_ops): Remove uppercase versions and the end marker.
13922         (f77_keywords): Likewise.
13923         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13924         entries in the dot_ops array are case insensitive, and use
13925         strncasecmp to compare strings.  Also some whitespace cleanup in
13926         this area.  Similar for the f77_keywords array, except entries in
13927         this list might be case sensitive.
13928
13929 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13930
13931         * f-exp.y (struct f77_boolean_val): Add comments.
13932         (boolean_values): Remove uppercase versions, and end marker.
13933         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13934         and use strncasecmp to achieve case insensitivity.  Additionally,
13935         perform whitespace cleanup around this code.
13936
13937 2019-03-06  Tom Tromey  <tromey@adacore.com>
13938
13939         * remote-sim.c (gdbsim_target_open): Use result of
13940         gdb_argv::release.
13941
13942 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13943         Dirk Schubert  <dirk.schubert@arm.com>
13944         Chris January  <chris.january@arm.com>
13945
13946         * eval.c (evaluate_subexp_standard): Call Fortran argument
13947         wrapping logic.
13948         * f-lang.c (struct value): A value which can be passed into a
13949         Fortran function call.
13950         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13951         where appropriate.
13952         (struct type): Value ready for a Fortran function call.
13953         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13954         is needed.
13955         * f-lang.h (fortran_argument_convert): Declaration.
13956         (fortran_preserve_arg_pointer): Declaration.
13957         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13958
13959 2019-03-05  Tom Tromey  <tromey@adacore.com>
13960
13961         * python/py-prettyprint.c (print_string_repr): Remove #if.
13962         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13963
13964 2019-03-05  Tom Tromey  <tromey@adacore.com>
13965
13966         * target.c (the_dummy_target): Move later.  Change type to
13967         "dummy_target".
13968         (initialize_targets): Don't initialize the_dummy_target.
13969
13970 2019-03-05  Tom Tromey  <tromey@adacore.com>
13971
13972         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13973         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13974
13975 2019-03-05  Tom Tromey  <tromey@adacore.com>
13976
13977         * windows-nat.c (windows_nat_target::attach)
13978         (windows_nat_target::detach): Don't call gdb_flush.
13979         * valprint.c (generic_val_print, val_print, val_print_string):
13980         Don't call gdb_flush.
13981         * utils.c (defaulted_query): Don't call gdb_flush.
13982         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13983         * target.c (target_announce_detach): Don't call gdb_flush.
13984         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13985         * remote.c (extended_remote_target::attach): Don't call
13986         gdb_flush.
13987         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13988         * printcmd.c (do_examine): Don't call gdb_flush.
13989         (info_display_command): Don't call gdb_flush.
13990         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13991         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13992         * memattr.c (info_mem_command): Don't call gdb_flush.
13993         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13994         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13995         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13996         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13997         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13998         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13999         (gnu_nat_target::detach): Don't call gdb_flush.
14000         * f-valprint.c (f_val_print): Don't call gdb_flush.
14001         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14002         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14003         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14004         gdb_flush.
14005         * c-valprint.c (c_val_print): Don't call gdb_flush.
14006         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14007
14008 2019-03-05  Tom Tromey  <tromey@adacore.com>
14009
14010         * varobj.c (update_dynamic_varobj_children): Update.
14011         (install_default_visualizer): Use reset, not release.
14012         * value.c (set_internalvar): Update.
14013         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14014         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14015         ATTRIBUTE_UNUSED_RESULT.
14016
14017 2019-03-05  Tom Tromey  <tromey@adacore.com>
14018
14019         * remote.c (class scoped_remote_fd) <release>: Add
14020         ATTRIBUTE_UNUSED_RESULT.
14021
14022 2019-03-05  Tom Tromey  <tromey@adacore.com>
14023
14024         * macroexp.c (struct macro_buffer) <release>: Add
14025         ATTRIBUTE_UNUSED_RESULT.
14026
14027 2019-03-05  Tom Tromey  <tromey@adacore.com>
14028
14029         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14030         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14031         ATTRIBUTE_UNUSED_RESULT.
14032
14033 2019-03-05  Tom Tromey  <tromey@adacore.com>
14034
14035         * common/scoped_fd.h (class scoped_fd) <release>: Add
14036         ATTRIBUTE_UNUSED_RESULT.
14037
14038 2019-03-05  Tom Tromey  <tromey@adacore.com>
14039
14040         * parser-defs.h (struct parser_state) <release>: Add
14041         ATTRIBUTE_UNUSED_RESULT.
14042
14043 2019-03-05  Tom Tromey  <tromey@adacore.com>
14044
14045         * utils.h (class gdb_argv) <release>: Add
14046         ATTRIBUTE_UNUSED_RESULT.
14047         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14048
14049 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14050
14051         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14052         for-loop range, to avoid compiler warnings.
14053
14054         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14055         avoid compiler warnings about unused variables.
14056
14057         * NEWS: Mention end of support for native debugging on MS-Windows
14058         before XP.
14059
14060         PR gdb/24292
14061         * common/netstuff.c:
14062         * gdbserver/gdbreplay.c
14063         * gdbserver/remote-utils.c:
14064         * ser-tcp.c:
14065         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14066         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14067         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14068         'getaddrinfo' and 'freeaddrinfo' were not available before
14069         Windows XP, and mingw.org's MinGW headers by default define
14070         _WIN32_WINNT to 0x500.
14071
14072 2019-03-01  Gary Benson <gbenson@redhat.com>
14073
14074         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14075
14076 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14077             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14078
14079         PR gdb/8527
14080         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14081         set_sigint_trap, clear_sigint_trap.
14082
14083 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14084
14085         * target.c (target_detach): Clear the regcache and the
14086         frame cache.
14087
14088 2019-02-27  Pedro Alves  <palves@redhat.com>
14089
14090         * utils.c (set_screen_size): When we cap the height/width sizes,
14091         tweak the corresponding command variable to show "unlimited":
14092
14093 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14094             Pedro Alves  <palves@redhat.com>
14095
14096         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14097         before calling rl_set_screen_size.
14098
14099 2019-02-27  Tom Tromey  <tromey@adacore.com>
14100
14101         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14102         define.
14103         * python/py-value.c: Remove Python 2.4 workaround.
14104         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14105         workaround.
14106         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14107         Python 2.4 workaround.
14108         * python/python-internal.h: Remove Python 2.4 comment.
14109         (Py_ssize_t): Don't define.
14110         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14111         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14112         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14113         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14114         * python/python.c (do_start_initialization): Remove Python 2.4
14115         workaround.
14116         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14117         (print_children): Remove Python 2.4 workaround.
14118         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14119         workaround.
14120         (CHARBUFFERPROC_NAME): Remove.
14121         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14122         Python 2.4 workaround.
14123
14124 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14125
14126         * NEWS: Note minimum Python version.
14127
14128 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14129
14130         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14131         code from these functions.  Remove corresponding ifdefs.  Use
14132         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14133         Remove gotos and target of gotos.
14134         (infpy_search_memory): Likewise.
14135
14136 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14137
14138         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14139         (hppa_gdbarch_init): Don't register deleted functions with
14140         gdbarch.
14141
14142 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14143
14144         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14145         (h8300_unwind_sp): Delete.
14146         (h8300_dummy_id): Delete.
14147         (h8300_gdbarch_init): Don't register deleted functions with
14148         gdbarch.
14149
14150 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14151
14152         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14153         (ft32_unwind_pc): Delete.
14154         (ft32_unwind_sp): Delete.
14155         (ft32_gdbarch_init): Don't register deleted functions with
14156         gdbarch.
14157
14158 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14159
14160         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14161         (frv_unwind_pc): Delete.
14162         (frv_unwind_sp): Delete.
14163         (frv_gdbarch_init): Don't register deleted functions with
14164         gdbarch.
14165
14166 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14167
14168         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14169         (riscv_unwind_pc): Delete.
14170         (riscv_unwind_sp): Delete.
14171         (riscv_gdbarch_init): Don't register deleted functions with
14172         gdbarch.
14173
14174 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14175
14176         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14177         (csky_unwind_pc): Delete.
14178         (csky_unwind_sp): Delete.
14179         (csky_gdbarch_init): Don't register deleted functions with
14180         gdbarch.
14181
14182 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14183
14184         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14185         (cris_unwind_pc): Delete.
14186         (cris_unwind_sp): Delete.
14187         (cris_gdbarch_init): Don't register deleted functions with
14188         gdbarch.
14189
14190 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14191
14192         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14193         (bfin_unwind_pc): Delete.
14194         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14195
14196 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14197
14198         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14199         (arm_unwind_pc): Delete.
14200         (arm_unwind_sp): Delete.
14201         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14202
14203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14204
14205         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14206         (arc_unwind_pc): Delete.
14207         (arc_unwind_sp): Delete.
14208         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14209
14210 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14211
14212         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14213         (alpha_unwind_pc): Delete.
14214         (alpha_gdbarch_init): Don't register deleted functions with
14215         gdbarch.
14216
14217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14218
14219         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14220         (aarch64_unwind_pc): Delete.
14221         (aarch64_unwind_sp): Delete.
14222         (aarch64_gdbarch_init): Don't register deleted functions with
14223         gdbarch.
14224
14225 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14226
14227         * gdbtypes.c (type_align): Don't consider static members when
14228         computing structure alignment.
14229
14230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14231
14232         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14233         return 0 for other types.
14234         * arch-utils.c (default_type_align): Always return 0.
14235         * gdbarch.h: Regenerate.
14236         * gdbarch.sh (type_align): Extend comment.
14237         * gdbtypes.c (type_align): Add additional comments, always call
14238         gdbarch_type_align before applying the default rules.
14239         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14240         generic code will then apply a suitable default.
14241         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14242         types, return 0 for other types.
14243
14244 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14245
14246         * NEWS: Create a new section for the next release branch.
14247         Rename the section of the current branch, now that it has
14248         been cut.
14249
14250 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14251
14252         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14253         * version.in: Bump version to 8.3.50.DATE-git.
14254
14255 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14256
14257         * aix-thread.c (ptid_cmp): Remove unused variable.
14258         (get_signaled_thread): Likewise.
14259         (store_regs_user_thread): Likewise.
14260         (store_regs_kernel_thread): Likewise.
14261         (fetch_regs_kernel_thread): Remove shadowed variable.
14262
14263 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14264
14265         * features/riscv/32bit-cpu.xml: Add register numbers.
14266         * features/riscv/32bit-fpu.c: Regenerate.
14267         * features/riscv/32bit-fpu.xml: Add register numbers.
14268         * features/riscv/64bit-cpu.xml: Add register numbers.
14269         * features/riscv/64bit-fpu.c: Regenerate.
14270         * features/riscv/64bit-fpu.xml: Add register numbers.
14271
14272 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14273
14274         * NEWS: Mention two argument form of gdb.Value constructor.
14275         * python/py-value.c (convert_buffer_and_type_to_value): New
14276         function.
14277         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14278         Add support for handling an optional second argument.  Call
14279         convert_buffer_and_type_to_value as appropriate.
14280         * python/python-internal.h (Py_buffer_deleter): New struct.
14281         (Py_buffer_up): New typedef.
14282
14283 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14284
14285         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14286         instead of releasing ownership.
14287
14288 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14289
14290         * dwarf2read.c (open_and_init_dwp_file): Call
14291         elf_numsections instead of bfd_count_sections to initialize
14292         dwp_file->num_sections.
14293
14294 2019-02-25  Tom Tromey  <tromey@adacore.com>
14295
14296         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14297
14298 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14299
14300         * gcore.in: Add '--readnever' option when invoking GDB.
14301
14302 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14303
14304         * MAINTAINERS: Update my email address.
14305
14306 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14307
14308         * build-id.c (build_id_to_debug_bfd_1): New function.
14309         (build_id_to_debug_bfd): Look for separate debug file in
14310         sysroot.
14311
14312 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14313
14314         * gdbarch.sh: Update the copyright year range that is placed into
14315         generated files.
14316
14317 2019-02-22  Keith Seitz  <keiths@redhat.com>
14318
14319         PR symtab/23853
14320         * linespec.c (create_sals_line_offset): Search for the default
14321         symtab's filename instead of its fullname.
14322
14323 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14324
14325         * NEWS: Update style defaults.
14326
14327 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14328
14329         * main.c (captured_main_1): Disable styling in batch mode.
14330
14331 2019-02-20  Tom Tromey  <tom@tromey.com>
14332
14333         * symtab.c (symtab_symbol_info): Fix typos.
14334
14335 2019-02-20  Tom Tromey  <tromey@adacore.com>
14336
14337         * findcmd.c (_initialize_mem_search): Use upper case for
14338         metasyntactic variables.
14339
14340 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14341
14342         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14343         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14344
14345 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14346
14347         * top.h (source_file_name): Change to std::string.
14348         * top.c (source_file_name): Likewise.
14349         (command_line_input): Adjust.
14350         * cli/cli-script.c (script_from_file): Adjust.
14351
14352 2019-02-19  Tom Tromey  <tromey@adacore.com>
14353
14354         * ravenscar-thread.c
14355         (ravenscar_thread_target::update_thread_list): Don't call
14356         ada_build_task_list.
14357         * ada-lang.h (ada_build_task_list): Don't declare.
14358         * ada-tasks.c (struct ada_tasks_inferior_data)
14359         <task_list_valid_p>: Now bool.
14360         (read_known_tasks, ada_task_list_changed)
14361         (ada_tasks_invalidate_inferior_data): Update.
14362         (read_known_tasks_array): Return bool.
14363         (read_known_tasks_list): Likewise.
14364         (read_known_tasks): Return void.
14365         (ada_build_task_list): Now static.
14366
14367 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14368
14369         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14370         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14371
14372 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14373
14374         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14375         variant for ada_tasks_pspace_data_handle and
14376         ada_tasks_inferior_data_handle.
14377         (ada_tasks_pspace_data_cleanup): New function.
14378         (ada_tasks_inferior_data_cleanup): New function.
14379
14380 2019-02-17  Tom Tromey  <tom@tromey.com>
14381
14382         * macrotab.h (macro_source_fullname): Return a std::string.
14383         * macrotab.c (macro_include, check_for_redefinition)
14384         (macro_undef, macro_lookup_definition, foreach_macro)
14385         (foreach_macro_in_scope): Update.
14386         (macro_source_fullname): Return a std::string.
14387         * macrocmd.c (show_pp_source_pos): Update.
14388
14389 2019-02-17  Tom Tromey  <tom@tromey.com>
14390
14391         * macrocmd.c (show_pp_source_pos): Style the file names.
14392
14393 2019-02-17  Tom Tromey  <tom@tromey.com>
14394
14395         PR tui/24197:
14396         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14397
14398 2019-02-17  Tom Tromey  <tom@tromey.com>
14399
14400         * ada-lang.c (user_select_syms): Use filtered printing.
14401         * utils.c (wrap_style): New global.
14402         (desired_style): Remove.
14403         (emit_style_escape): Add stream parameter.
14404         (set_output_style, reset_terminal_style, prompt_for_continue):
14405         Update.
14406         (flush_wrap_buffer): Only flush gdb_stdout.
14407         (wrap_here): Set wrap_style.
14408         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14409         treat escape sequences as a character.  Change when wrap buffer is
14410         flushed.
14411         (fputs_styled): Do not set the output style when the default is
14412         requested.
14413         * ui-style.h (struct ui_file_style) <is_default>: New method.
14414         * source.c (print_source_lines_base): Emit escape sequences in one
14415         piece.
14416
14417 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14418
14419         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14420         integers and enumeration types.
14421
14422 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14423
14424         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14425         instead of lookup_symbol_in_language
14426         (do_exact_match): New function.
14427         (ada_get_symbol_name_matcher): Return do_exact_match when
14428         doing a verbatim match.
14429
14430 2019-02-15  Tom Tromey  <tromey@adacore.com>
14431
14432         * ravenscar-thread.c (ravenscar_thread_target::resume)
14433         (ravenscar_thread_target::wait): Special case wildcard requests.
14434
14435 2019-02-15  Tom Tromey  <tromey@adacore.com>
14436
14437         * ravenscar-thread.c (base_ptid): Remove.
14438         (struct ravenscar_thread_target) <close>: New method.
14439         <m_base_ptid>: New member.
14440         <update_inferior_ptid, active_task, task_is_currently_active,
14441         runtime_initialized>: Declare methods.
14442         <ravenscar_thread_target>: Add constructor.
14443         (ravenscar_thread_target::task_is_currently_active)
14444         (ravenscar_thread_target::update_inferior_ptid)
14445         (ravenscar_runtime_initialized): Rename.  Now methods.
14446         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14447         (ravenscar_thread_target::update_thread_list): Update.
14448         (ravenscar_thread_target::active_task): Now method.
14449         (ravenscar_thread_target::store_registers)
14450         (ravenscar_thread_target::prepare_to_store)
14451         (ravenscar_thread_target::prepare_to_store)
14452         (ravenscar_thread_target::mourn_inferior): Update.
14453         (ravenscar_inferior_created): Use "new" to create target.
14454         (ravenscar_thread_target::get_ada_task_ptid): Update.
14455         (_initialize_ravenscar): Don't initialize base_ptid.
14456         (ravenscar_ops): Remove global.
14457
14458 2019-02-15  Tom Tromey  <tromey@adacore.com>
14459
14460         * target.h (push_target): Declare new overload.
14461         * target.c (push_target): New overload, taking an rvalue reference.
14462         * remote.c (remote_target::open_1): Use push_target overload.
14463         * corelow.c (core_target_open): Use push_target overload.
14464
14465 2019-02-15  Tom Tromey  <tromey@adacore.com>
14466
14467         * ravenscar-thread.c (is_ravenscar_task)
14468         (ravenscar_task_is_currently_active): Return bool.
14469         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14470         (_initialize_ravenscar): Remove "(void)".
14471         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14472         Return bool.
14473
14474 2019-02-15  Tom Tromey  <tromey@adacore.com>
14475
14476         * ravenscar-thread.c (ravenscar_runtime_initializer)
14477         (has_ravenscar_runtime, get_running_thread_id)
14478         (ravenscar_thread_target::resume): Fix indentation.
14479
14480 2019-02-15  Tom Tromey  <tromey@adacore.com>
14481
14482         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14483         from ravenscar_arch_ops.
14484         (sparc_ravenscar_ops::fetch_registers)
14485         (sparc_ravenscar_ops::store_registers): Now methods.
14486         (sparc_ravenscar_prepare_to_store): Remove.
14487         (sparc_ravenscar_ops): Redefine.
14488         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14489         methods and destructor.  Remove members.
14490         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14491         (ravenscar_thread_target::store_registers)
14492         (ravenscar_thread_target::prepare_to_store): Update.
14493         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14494         Remove.
14495         (struct ppc_ravenscar_powerpc_ops): Derive from
14496         ravenscar_arch_ops.
14497         (ppc_ravenscar_powerpc_ops::fetch_registers)
14498         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14499         (ppc_ravenscar_powerpc_ops): Redefine.
14500         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14501         (ppc_ravenscar_e500_ops::fetch_registers)
14502         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14503         (ppc_ravenscar_e500_ops): Redefine.
14504         * aarch64-ravenscar-thread.c
14505         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14506         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14507         (aarch64_ravenscar_fetch_registers)
14508         (aarch64_ravenscar_store_registers): Now methods.
14509         (aarch64_ravenscar_ops): Redefine.
14510
14511 2019-02-15  Tom Tromey  <tromey@adacore.com>
14512
14513         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14514         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14515         (ravenscar_thread_target::stopped_by_watchpoint)
14516         (ravenscar_thread_target::stopped_data_address)
14517         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14518
14519 2019-02-15  Tom Tromey  <tromey@adacore.com>
14520
14521         * ravenscar-thread.c: Fix some typos.
14522
14523 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14524             Tom Tromey  <tromey@adacore.com>
14525
14526         * ada-lang.c (ada_exception_sal): Change addr_string to a
14527         std::string.
14528         (create_ada_exception_catchpoint): Update.
14529
14530 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14531             Tom Tromey  <tromey@adacore.com>
14532
14533         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14534         (bp_location_ops): Remove.
14535         (base_breakpoint_allocate_location): Update.
14536         (free_bp_location): Update.
14537         * ada-lang.c (class ada_catchpoint_location)
14538         <ada_catchpoint_location>: Remove ops parameter.
14539         (ada_catchpoint_location_dtor): Remove.
14540         (ada_catchpoint_location_ops): Remove.
14541         (allocate_location_exception): Update.
14542         * breakpoint.h (struct bp_location_ops): Remove.
14543         (class bp_location) <bp_location>: Remove bp_location_ops
14544         parameter.
14545         <~bp_location>: Add destructor.
14546         <ops>: Remove.
14547
14548 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14549             Pedro Alves  <palves@redhat.com>
14550
14551         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14552         'PATH_MAX'.
14553
14554 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14555             Samuel Thibault  <samuel.thibault@gnu.org>
14556             Thomas Schwinge  <thomas@codesourcery.com>
14557
14558         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14559         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14560
14561 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14562
14563         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14564         (check_empty): Use "const char *".
14565
14566         * gnu-nat.c (gnu_nat_target::detach): Instead of
14567         'detach_inferior (pid)' call
14568         'detach_inferior (find_inferior_pid (pid))'.
14569
14570         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14571         'nat/fork-inferior.o'.
14572         * gnu-nat.c: #include "nat/fork-inferior.h".
14573
14574         * gnu-nat.c (gnu_nat_target::detach): Instead of
14575         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14576         * gnu-nat.h: #include "inf-child.h".
14577         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14578         'i386_gnu_nat_target::fetch_registers'.
14579         (gnu_store_registers): Rename/move to
14580         'i386_gnu_nat_target::store_registers'.
14581
14582         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14583         * gnu-nat.h (mach_thread_info): New function.
14584         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14585
14586         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14587
14588 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14589
14590         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14591
14592 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14593
14594         * windows-nat.c (windows_add_thread): Add new parameter
14595         "main_thread_p" with default value set to false.  Update
14596         function documentation as well as all callers.
14597         (windows_delete_thread): Likewise.
14598         (fake_create_process): Update call to windows_add_thread.
14599         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14600         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14601         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14602         call to windows_delete_thread.
14603
14604 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14605
14606         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14607
14608 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14609
14610         * symfile.c (find_separate_debug_file): Use canonical path of
14611         sysroot with child_path instead of gdb_sysroot if it is valid.
14612
14613 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14614
14615         * symfile.c (find_separate_debug_file): Use child_path to
14616         determine if an object file is under a sysroot.
14617
14618 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14619
14620         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14621         unittests/child-path-selftests.c.
14622         * common/pathstuff.c (child_path): New function.
14623         * common/pathstuff.h (child_path): New prototype.
14624         * unittests/child-path-selftests.c: New file.
14625
14626 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14627
14628         * symfile.c (find_separate_debug_file): Look for separate debug
14629         files in debug directories under the sysroot.
14630
14631 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14632
14633         * symtab.h (struct minimal_symbol data_p): New const method.
14634         (struct minimal_symbol text_p): Likewise.
14635         * symtab.c (output_source_filename): Use file name style
14636         to print file name.
14637         (print_symbol_info): Likewise.
14638         (print_msymbol_info): Use address style to print addresses.
14639         Use function name style to print executable text symbols.
14640         (expand_symtab_containing_pc): Use data_p.
14641         (find_pc_sect_compunit_symtab): Likewise.
14642
14643 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14644
14645         * breakpoint.c (describe_other_breakpoints): Use address style
14646         to print addresses.
14647         (say_where): Likewise.
14648
14649 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14650
14651         * ada-typeprint.c (print_func_type): Print function name
14652         style to print function name.
14653         * c-typeprint.c (c_print_type_1): Likewise.
14654
14655 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14656
14657         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14658         for execve.
14659
14660 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14661
14662         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14663         type_stack.
14664
14665 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14666
14667         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14668         TYPE_CODE_REF types.
14669
14670 2019-02-08  Jim Wilson  <jimw@sifive.com>
14671
14672         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14673         (riscv_linux_fregset): New.
14674         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14675
14676 2019-02-07  Tom Tromey  <tom@tromey.com>
14677
14678         * thread.c (thread_cancel_execution_command): Update.
14679         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14680         methods.
14681         (struct thread_fsm_ops): Remove.
14682         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14683         (thread_fsm_should_stop, thread_fsm_return_value)
14684         (thread_fsm_set_finished, thread_fsm_finished_p)
14685         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14686         Don't declare.
14687         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14688         * infrun.c (clear_proceed_status_thread)
14689         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14690         (print_stop_event): Update.
14691         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14692         Add constructor.
14693         (step_command_fsm_ops): Remove.
14694         (new_step_command_fsm): Remove.
14695         (step_1): Update.
14696         (step_command_fsm::should_stop): Rename from
14697         step_command_fsm_should_stop.
14698         (step_command_fsm::clean_up): Rename from
14699         step_command_fsm_clean_up.
14700         (step_command_fsm::do_async_reply_reason): Rename from
14701         step_command_fsm_async_reply_reason.
14702         (struct until_next_fsm): Inherit from thread_fsm.  Add
14703         constructor.
14704         (until_next_fsm_ops): Remove.
14705         (new_until_next_fsm): Remove.
14706         (until_next_fsm::should_stop): Rename from
14707         until_next_fsm_should_stop.
14708         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14709         (until_next_fsm::do_async_reply_reason): Rename from
14710         until_next_fsm_async_reply_reason.
14711         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14712         constructor.  Change type of breakpoint.
14713         (finish_command_fsm_ops): Remove.
14714         (new_finish_command_fsm): Remove.
14715         (finish_command_fsm::should_stop): Rename from
14716         finish_command_fsm_should_stop.
14717         (finish_command_fsm::clean_up): Rename from
14718         finish_command_fsm_clean_up.
14719         (finish_command_fsm::return_value): Rename from
14720         finish_command_fsm_return_value.
14721         (finish_command_fsm::do_async_reply_reason): Rename from
14722         finish_command_fsm_async_reply_reason.
14723         (finish_command): Update.
14724         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14725         Add constructor.
14726         (call_thread_fsm_ops): Remove.
14727         (call_thread_fsm::call_thread_fsm): Rename from
14728         new_call_thread_fsm.
14729         (call_thread_fsm::should_stop): Rename from
14730         call_thread_fsm_should_stop.
14731         (call_thread_fsm::should_notify_stop): Rename from
14732         call_thread_fsm_should_notify_stop.
14733         (run_inferior_call, call_function_by_hand_dummy): Update.
14734         * cli/cli-interp.c (should_print_stop_to_console): Update.
14735         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14736         Add constructor.  Change type of location_breakpoint,
14737         caller_breakpoint.
14738         (until_break_fsm_ops): Remove.
14739         (new_until_break_fsm): Remove.
14740         (until_break_fsm::should_stop): Rename from
14741         until_break_fsm_should_stop.
14742         (until_break_fsm::clean_up): Rename from
14743         until_break_fsm_clean_up.
14744         (until_break_fsm::do_async_reply_reason): Rename from
14745         until_break_fsm_async_reply_reason.
14746         (until_break_command): Update.
14747         * thread-fsm.c: Remove.
14748         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14749
14750 2019-02-07  Tom Tromey  <tom@tromey.com>
14751
14752         * yy-remap.h: Add include guard.
14753         * xtensa-tdep.h: Add include guard.
14754         * xcoffread.h: Rename include guard.
14755         * varobj-iter.h: Add include guard.
14756         * tui/tui.h: Rename include guard.
14757         * tui/tui-winsource.h: Rename include guard.
14758         * tui/tui-wingeneral.h: Rename include guard.
14759         * tui/tui-windata.h: Rename include guard.
14760         * tui/tui-win.h: Rename include guard.
14761         * tui/tui-stack.h: Rename include guard.
14762         * tui/tui-source.h: Rename include guard.
14763         * tui/tui-regs.h: Rename include guard.
14764         * tui/tui-out.h: Rename include guard.
14765         * tui/tui-layout.h: Rename include guard.
14766         * tui/tui-io.h: Rename include guard.
14767         * tui/tui-hooks.h: Rename include guard.
14768         * tui/tui-file.h: Rename include guard.
14769         * tui/tui-disasm.h: Rename include guard.
14770         * tui/tui-data.h: Rename include guard.
14771         * tui/tui-command.h: Rename include guard.
14772         * tic6x-tdep.h: Add include guard.
14773         * target/waitstatus.h: Rename include guard.
14774         * target/wait.h: Rename include guard.
14775         * target/target.h: Rename include guard.
14776         * target/resume.h: Rename include guard.
14777         * target-float.h: Rename include guard.
14778         * stabsread.h: Add include guard.
14779         * rs6000-tdep.h: Add include guard.
14780         * riscv-fbsd-tdep.h: Add include guard.
14781         * regformats/regdef.h: Rename include guard.
14782         * record.h: Rename include guard.
14783         * python/python.h: Rename include guard.
14784         * python/python-internal.h: Rename include guard.
14785         * python/py-stopevent.h: Rename include guard.
14786         * python/py-ref.h: Rename include guard.
14787         * python/py-record.h: Rename include guard.
14788         * python/py-record-full.h: Rename include guard.
14789         * python/py-record-btrace.h: Rename include guard.
14790         * python/py-instruction.h: Rename include guard.
14791         * python/py-events.h: Rename include guard.
14792         * python/py-event.h: Rename include guard.
14793         * procfs.h: Add include guard.
14794         * proc-utils.h: Add include guard.
14795         * p-lang.h: Add include guard.
14796         * or1k-tdep.h: Rename include guard.
14797         * observable.h: Rename include guard.
14798         * nto-tdep.h: Rename include guard.
14799         * nat/x86-linux.h: Rename include guard.
14800         * nat/x86-linux-dregs.h: Rename include guard.
14801         * nat/x86-gcc-cpuid.h: Add include guard.
14802         * nat/x86-dregs.h: Rename include guard.
14803         * nat/x86-cpuid.h: Rename include guard.
14804         * nat/ppc-linux.h: Rename include guard.
14805         * nat/mips-linux-watch.h: Rename include guard.
14806         * nat/linux-waitpid.h: Rename include guard.
14807         * nat/linux-ptrace.h: Rename include guard.
14808         * nat/linux-procfs.h: Rename include guard.
14809         * nat/linux-osdata.h: Rename include guard.
14810         * nat/linux-nat.h: Rename include guard.
14811         * nat/linux-namespaces.h: Rename include guard.
14812         * nat/linux-btrace.h: Rename include guard.
14813         * nat/glibc_thread_db.h: Rename include guard.
14814         * nat/gdb_thread_db.h: Rename include guard.
14815         * nat/gdb_ptrace.h: Rename include guard.
14816         * nat/fork-inferior.h: Rename include guard.
14817         * nat/amd64-linux-siginfo.h: Rename include guard.
14818         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14819         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14820         * nat/aarch64-linux.h: Rename include guard.
14821         * nat/aarch64-linux-hw-point.h: Rename include guard.
14822         * mn10300-tdep.h: Add include guard.
14823         * mips-linux-tdep.h: Add include guard.
14824         * mi/mi-parse.h: Rename include guard.
14825         * mi/mi-out.h: Rename include guard.
14826         * mi/mi-main.h: Rename include guard.
14827         * mi/mi-interp.h: Rename include guard.
14828         * mi/mi-getopt.h: Rename include guard.
14829         * mi/mi-console.h: Rename include guard.
14830         * mi/mi-common.h: Rename include guard.
14831         * mi/mi-cmds.h: Rename include guard.
14832         * mi/mi-cmd-break.h: Rename include guard.
14833         * m2-lang.h: Add include guard.
14834         * location.h: Rename include guard.
14835         * linux-record.h: Rename include guard.
14836         * linux-nat.h: Add include guard.
14837         * linux-fork.h: Add include guard.
14838         * i386-darwin-tdep.h: Rename include guard.
14839         * hppa-linux-offsets.h: Add include guard.
14840         * guile/guile.h: Rename include guard.
14841         * guile/guile-internal.h: Rename include guard.
14842         * gnu-nat.h: Rename include guard.
14843         * gdb-stabs.h: Rename include guard.
14844         * frv-tdep.h: Add include guard.
14845         * f-lang.h: Add include guard.
14846         * event-loop.h: Add include guard.
14847         * darwin-nat.h: Rename include guard.
14848         * cp-abi.h: Rename include guard.
14849         * config/sparc/nm-sol2.h: Rename include guard.
14850         * config/nm-nto.h: Rename include guard.
14851         * config/nm-linux.h: Add include guard.
14852         * config/i386/nm-i386gnu.h: Rename include guard.
14853         * config/djgpp/nl_types.h: Rename include guard.
14854         * config/djgpp/langinfo.h: Rename include guard.
14855         * compile/gcc-cp-plugin.h: Add include guard.
14856         * compile/gcc-c-plugin.h: Add include guard.
14857         * compile/compile.h: Rename include guard.
14858         * compile/compile-object-run.h: Rename include guard.
14859         * compile/compile-object-load.h: Rename include guard.
14860         * compile/compile-internal.h: Rename include guard.
14861         * compile/compile-cplus.h: Rename include guard.
14862         * compile/compile-c.h: Rename include guard.
14863         * common/xml-utils.h: Rename include guard.
14864         * common/x86-xstate.h: Rename include guard.
14865         * common/version.h: Rename include guard.
14866         * common/vec.h: Rename include guard.
14867         * common/tdesc.h: Rename include guard.
14868         * common/selftest.h: Rename include guard.
14869         * common/scoped_restore.h: Rename include guard.
14870         * common/scoped_mmap.h: Rename include guard.
14871         * common/scoped_fd.h: Rename include guard.
14872         * common/safe-iterator.h: Rename include guard.
14873         * common/run-time-clock.h: Rename include guard.
14874         * common/refcounted-object.h: Rename include guard.
14875         * common/queue.h: Rename include guard.
14876         * common/ptid.h: Rename include guard.
14877         * common/print-utils.h: Rename include guard.
14878         * common/preprocessor.h: Rename include guard.
14879         * common/pathstuff.h: Rename include guard.
14880         * common/observable.h: Rename include guard.
14881         * common/netstuff.h: Rename include guard.
14882         * common/job-control.h: Rename include guard.
14883         * common/host-defs.h: Rename include guard.
14884         * common/gdb_wait.h: Rename include guard.
14885         * common/gdb_vecs.h: Rename include guard.
14886         * common/gdb_unlinker.h: Rename include guard.
14887         * common/gdb_unique_ptr.h: Rename include guard.
14888         * common/gdb_tilde_expand.h: Rename include guard.
14889         * common/gdb_sys_time.h: Rename include guard.
14890         * common/gdb_string_view.h: Rename include guard.
14891         * common/gdb_splay_tree.h: Rename include guard.
14892         * common/gdb_setjmp.h: Rename include guard.
14893         * common/gdb_ref_ptr.h: Rename include guard.
14894         * common/gdb_optional.h: Rename include guard.
14895         * common/gdb_locale.h: Rename include guard.
14896         * common/gdb_assert.h: Rename include guard.
14897         * common/filtered-iterator.h: Rename include guard.
14898         * common/filestuff.h: Rename include guard.
14899         * common/fileio.h: Rename include guard.
14900         * common/environ.h: Rename include guard.
14901         * common/common-utils.h: Rename include guard.
14902         * common/common-types.h: Rename include guard.
14903         * common/common-regcache.h: Rename include guard.
14904         * common/common-inferior.h: Rename include guard.
14905         * common/common-gdbthread.h: Rename include guard.
14906         * common/common-exceptions.h: Rename include guard.
14907         * common/common-defs.h: Rename include guard.
14908         * common/common-debug.h: Rename include guard.
14909         * common/cleanups.h: Rename include guard.
14910         * common/buffer.h: Rename include guard.
14911         * common/btrace-common.h: Rename include guard.
14912         * common/break-common.h: Rename include guard.
14913         * cli/cli-utils.h: Rename include guard.
14914         * cli/cli-style.h: Rename include guard.
14915         * cli/cli-setshow.h: Rename include guard.
14916         * cli/cli-script.h: Rename include guard.
14917         * cli/cli-interp.h: Rename include guard.
14918         * cli/cli-decode.h: Rename include guard.
14919         * cli/cli-cmds.h: Rename include guard.
14920         * charset-list.h: Add include guard.
14921         * buildsym-legacy.h: Rename include guard.
14922         * bfin-tdep.h: Add include guard.
14923         * ax.h: Rename include guard.
14924         * arm-linux-tdep.h: Add include guard.
14925         * arm-fbsd-tdep.h: Add include guard.
14926         * arch/xtensa.h: Rename include guard.
14927         * arch/tic6x.h: Add include guard.
14928         * arch/i386.h: Add include guard.
14929         * arch/arm.h: Rename include guard.
14930         * arch/arm-linux.h: Rename include guard.
14931         * arch/arm-get-next-pcs.h: Rename include guard.
14932         * arch/amd64.h: Add include guard.
14933         * arch/aarch64-insn.h: Rename include guard.
14934         * arch-utils.h: Rename include guard.
14935         * annotate.h: Add include guard.
14936         * amd64-darwin-tdep.h: Rename include guard.
14937         * aarch64-linux-tdep.h: Add include guard.
14938         * aarch64-fbsd-tdep.h: Add include guard.
14939         * aarch32-linux-nat.h: Add include guard.
14940
14941 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14942
14943         * macrotab.c (macro_define_internal): New function that
14944         factorizes macro_define_object_internal and macro_define_function
14945         code.
14946         (macro_define_object_internal): Use macro_define_internal.
14947         (macro_define_function): Likewise.
14948
14949 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14950
14951         * macrocmd.c (extract_identifier): Return
14952         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14953         callers.
14954
14955 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14956
14957         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14958
14959 2019-02-05  Tom Tromey  <tom@tromey.com>
14960
14961         * target.c (target_stack::unpush): Move assertion earlier.
14962
14963 2019-01-30  Tom Tromey  <tom@tromey.com>
14964
14965         PR python/23615:
14966         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14967         (gdbpy_parse_and_eval): Likewise.
14968         * python/python-internal.h (gdbpy_allow_threads): New class.
14969
14970 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14971
14972         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14973         (aarch64_fbsd_fpregmap): Move earlier.
14974         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14975         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14976         instead of individual calls to trad_frame_set_reg_addr.
14977         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14978         earlier.
14979         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14980         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14981         instead of individual calls to trad_frame_set_reg_addr.
14982
14983 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14984
14985         * CONTRIBUTE: Replace contribution list with wiki link.
14986
14987 2019-01-25  Tom Tromey  <tom@tromey.com>
14988
14989         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14990
14991 2019-01-25  Tom Tromey  <tom@tromey.com>
14992
14993         * xtensa-linux-nat.c: Fix common/ includes.
14994         * xml-support.h: Fix common/ includes.
14995         * xml-support.c: Fix common/ includes.
14996         * x86-linux-nat.c: Fix common/ includes.
14997         * windows-nat.c: Fix common/ includes.
14998         * varobj.h: Fix common/ includes.
14999         * varobj.c: Fix common/ includes.
15000         * value.c: Fix common/ includes.
15001         * valops.c: Fix common/ includes.
15002         * utils.c: Fix common/ includes.
15003         * unittests/xml-utils-selftests.c: Fix common/ includes.
15004         * unittests/utils-selftests.c: Fix common/ includes.
15005         * unittests/unpack-selftests.c: Fix common/ includes.
15006         * unittests/tracepoint-selftests.c: Fix common/ includes.
15007         * unittests/style-selftests.c: Fix common/ includes.
15008         * unittests/string_view-selftests.c: Fix common/ includes.
15009         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15010         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15011         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15012         * unittests/rsp-low-selftests.c: Fix common/ includes.
15013         * unittests/parse-connection-spec-selftests.c: Fix common/
15014         includes.
15015         * unittests/optional-selftests.c: Fix common/ includes.
15016         * unittests/offset-type-selftests.c: Fix common/ includes.
15017         * unittests/observable-selftests.c: Fix common/ includes.
15018         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15019         * unittests/memrange-selftests.c: Fix common/ includes.
15020         * unittests/memory-map-selftests.c: Fix common/ includes.
15021         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15022         * unittests/function-view-selftests.c: Fix common/ includes.
15023         * unittests/environ-selftests.c: Fix common/ includes.
15024         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15025         * unittests/common-utils-selftests.c: Fix common/ includes.
15026         * unittests/cli-utils-selftests.c: Fix common/ includes.
15027         * unittests/array-view-selftests.c: Fix common/ includes.
15028         * ui-file.c: Fix common/ includes.
15029         * tui/tui-io.c: Fix common/ includes.
15030         * tracepoint.h: Fix common/ includes.
15031         * tracepoint.c: Fix common/ includes.
15032         * tracefile-tfile.c: Fix common/ includes.
15033         * top.h: Fix common/ includes.
15034         * top.c: Fix common/ includes.
15035         * thread.c: Fix common/ includes.
15036         * target/waitstatus.h: Fix common/ includes.
15037         * target/waitstatus.c: Fix common/ includes.
15038         * target.h: Fix common/ includes.
15039         * target.c: Fix common/ includes.
15040         * target-memory.c: Fix common/ includes.
15041         * target-descriptions.c: Fix common/ includes.
15042         * symtab.h: Fix common/ includes.
15043         * symfile.c: Fix common/ includes.
15044         * stap-probe.c: Fix common/ includes.
15045         * spu-linux-nat.c: Fix common/ includes.
15046         * sparc-nat.c: Fix common/ includes.
15047         * source.c: Fix common/ includes.
15048         * solib.c: Fix common/ includes.
15049         * solib-target.c: Fix common/ includes.
15050         * ser-unix.c: Fix common/ includes.
15051         * ser-tcp.c: Fix common/ includes.
15052         * ser-pipe.c: Fix common/ includes.
15053         * ser-base.c: Fix common/ includes.
15054         * selftest-arch.c: Fix common/ includes.
15055         * s12z-tdep.c: Fix common/ includes.
15056         * rust-exp.y: Fix common/ includes.
15057         * rs6000-aix-tdep.c: Fix common/ includes.
15058         * riscv-tdep.c: Fix common/ includes.
15059         * remote.c: Fix common/ includes.
15060         * remote-notif.h: Fix common/ includes.
15061         * remote-fileio.h: Fix common/ includes.
15062         * remote-fileio.c: Fix common/ includes.
15063         * regcache.h: Fix common/ includes.
15064         * regcache.c: Fix common/ includes.
15065         * record-btrace.c: Fix common/ includes.
15066         * python/python.c: Fix common/ includes.
15067         * python/py-type.c: Fix common/ includes.
15068         * python/py-inferior.c: Fix common/ includes.
15069         * progspace.h: Fix common/ includes.
15070         * producer.c: Fix common/ includes.
15071         * procfs.c: Fix common/ includes.
15072         * proc-api.c: Fix common/ includes.
15073         * printcmd.c: Fix common/ includes.
15074         * ppc-linux-nat.c: Fix common/ includes.
15075         * parser-defs.h: Fix common/ includes.
15076         * osdata.c: Fix common/ includes.
15077         * obsd-nat.c: Fix common/ includes.
15078         * nat/x86-linux.c: Fix common/ includes.
15079         * nat/x86-linux-dregs.c: Fix common/ includes.
15080         * nat/x86-dregs.h: Fix common/ includes.
15081         * nat/x86-dregs.c: Fix common/ includes.
15082         * nat/ppc-linux.c: Fix common/ includes.
15083         * nat/mips-linux-watch.h: Fix common/ includes.
15084         * nat/mips-linux-watch.c: Fix common/ includes.
15085         * nat/linux-waitpid.c: Fix common/ includes.
15086         * nat/linux-ptrace.h: Fix common/ includes.
15087         * nat/linux-ptrace.c: Fix common/ includes.
15088         * nat/linux-procfs.c: Fix common/ includes.
15089         * nat/linux-personality.c: Fix common/ includes.
15090         * nat/linux-osdata.c: Fix common/ includes.
15091         * nat/linux-namespaces.c: Fix common/ includes.
15092         * nat/linux-btrace.h: Fix common/ includes.
15093         * nat/linux-btrace.c: Fix common/ includes.
15094         * nat/fork-inferior.c: Fix common/ includes.
15095         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15096         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15097         * nat/aarch64-linux.c: Fix common/ includes.
15098         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15099         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15100         * namespace.h: Fix common/ includes.
15101         * mips-linux-tdep.c: Fix common/ includes.
15102         * minsyms.c: Fix common/ includes.
15103         * mi/mi-parse.h: Fix common/ includes.
15104         * mi/mi-main.c: Fix common/ includes.
15105         * mi/mi-cmd-env.c: Fix common/ includes.
15106         * memrange.h: Fix common/ includes.
15107         * memattr.c: Fix common/ includes.
15108         * maint.h: Fix common/ includes.
15109         * maint.c: Fix common/ includes.
15110         * main.c: Fix common/ includes.
15111         * machoread.c: Fix common/ includes.
15112         * location.c: Fix common/ includes.
15113         * linux-thread-db.c: Fix common/ includes.
15114         * linux-nat.c: Fix common/ includes.
15115         * linux-fork.c: Fix common/ includes.
15116         * inline-frame.c: Fix common/ includes.
15117         * infrun.c: Fix common/ includes.
15118         * inflow.c: Fix common/ includes.
15119         * inferior.h: Fix common/ includes.
15120         * inferior.c: Fix common/ includes.
15121         * infcmd.c: Fix common/ includes.
15122         * inf-ptrace.c: Fix common/ includes.
15123         * inf-child.c: Fix common/ includes.
15124         * ia64-linux-nat.c: Fix common/ includes.
15125         * i387-tdep.c: Fix common/ includes.
15126         * i386-tdep.c: Fix common/ includes.
15127         * i386-linux-tdep.c: Fix common/ includes.
15128         * i386-linux-nat.c: Fix common/ includes.
15129         * i386-go32-tdep.c: Fix common/ includes.
15130         * i386-fbsd-tdep.c: Fix common/ includes.
15131         * i386-fbsd-nat.c: Fix common/ includes.
15132         * guile/scm-type.c: Fix common/ includes.
15133         * guile/guile.c: Fix common/ includes.
15134         * go32-nat.c: Fix common/ includes.
15135         * gnu-nat.c: Fix common/ includes.
15136         * gdbthread.h: Fix common/ includes.
15137         * gdbarch-selftests.c: Fix common/ includes.
15138         * gdb_usleep.c: Fix common/ includes.
15139         * gdb_select.h: Fix common/ includes.
15140         * gdb_bfd.c: Fix common/ includes.
15141         * gcore.c: Fix common/ includes.
15142         * fork-child.c: Fix common/ includes.
15143         * findvar.c: Fix common/ includes.
15144         * fbsd-nat.c: Fix common/ includes.
15145         * event-top.c: Fix common/ includes.
15146         * event-loop.c: Fix common/ includes.
15147         * dwarf2read.c: Fix common/ includes.
15148         * dwarf2loc.c: Fix common/ includes.
15149         * dwarf2-frame.c: Fix common/ includes.
15150         * dwarf-index-cache.c: Fix common/ includes.
15151         * dtrace-probe.c: Fix common/ includes.
15152         * disasm-selftests.c: Fix common/ includes.
15153         * defs.h: Fix common/ includes.
15154         * csky-tdep.c: Fix common/ includes.
15155         * cp-valprint.c: Fix common/ includes.
15156         * cp-support.h: Fix common/ includes.
15157         * cp-support.c: Fix common/ includes.
15158         * corelow.c: Fix common/ includes.
15159         * completer.h: Fix common/ includes.
15160         * completer.c: Fix common/ includes.
15161         * compile/compile.c: Fix common/ includes.
15162         * compile/compile-loc2c.c: Fix common/ includes.
15163         * compile/compile-cplus-types.c: Fix common/ includes.
15164         * compile/compile-cplus-symbols.c: Fix common/ includes.
15165         * command.h: Fix common/ includes.
15166         * cli/cli-dump.c: Fix common/ includes.
15167         * cli/cli-cmds.c: Fix common/ includes.
15168         * charset.c: Fix common/ includes.
15169         * build-id.c: Fix common/ includes.
15170         * btrace.h: Fix common/ includes.
15171         * btrace.c: Fix common/ includes.
15172         * breakpoint.h: Fix common/ includes.
15173         * breakpoint.c: Fix common/ includes.
15174         * ax.h:
15175         (enum agent_op): Fix common/ includes.
15176         * ax-general.c (struct aop_map): Fix common/ includes.
15177         * ax-gdb.c: Fix common/ includes.
15178         * auxv.c: Fix common/ includes.
15179         * auto-load.c: Fix common/ includes.
15180         * arm-tdep.c: Fix common/ includes.
15181         * arch/riscv.c: Fix common/ includes.
15182         * arch/ppc-linux-common.c: Fix common/ includes.
15183         * arch/i386.c: Fix common/ includes.
15184         * arch/arm.c: Fix common/ includes.
15185         * arch/arm-linux.c: Fix common/ includes.
15186         * arch/arm-get-next-pcs.c: Fix common/ includes.
15187         * arch/amd64.c: Fix common/ includes.
15188         * arch/aarch64.c: Fix common/ includes.
15189         * arch/aarch64-insn.c: Fix common/ includes.
15190         * arch-utils.c: Fix common/ includes.
15191         * amd64-windows-tdep.c: Fix common/ includes.
15192         * amd64-tdep.c: Fix common/ includes.
15193         * amd64-sol2-tdep.c: Fix common/ includes.
15194         * amd64-obsd-tdep.c: Fix common/ includes.
15195         * amd64-nbsd-tdep.c: Fix common/ includes.
15196         * amd64-linux-tdep.c: Fix common/ includes.
15197         * amd64-linux-nat.c: Fix common/ includes.
15198         * amd64-fbsd-tdep.c: Fix common/ includes.
15199         * amd64-fbsd-nat.c: Fix common/ includes.
15200         * amd64-dicos-tdep.c: Fix common/ includes.
15201         * amd64-darwin-tdep.c: Fix common/ includes.
15202         * agent.c: Fix common/ includes.
15203         * ada-lang.h: Fix common/ includes.
15204         * ada-lang.c: Fix common/ includes.
15205         * aarch64-tdep.c: Fix common/ includes.
15206
15207 2019-01-25  Tom Tromey  <tom@tromey.com>
15208
15209         * common/create-version.sh: Use common/version.h.
15210
15211 2019-01-24  Pedro Alves  <palves@redhat.com>
15212
15213         * infrun.c (signal_stop, signal_print, signal_program)
15214         (signal_catch, signal_pass): Now arrays instead of pointers.
15215         (update_signals_program_target, do_target_resume)
15216         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15217         * linux-nat.c (linux_nat_target::pass_signals)
15218         (linux_nat_target::create_inferior, linux_nat_target::attach):
15219         Adjust.
15220         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15221         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15222         * procfs.c (procfs_target::pass_signals): Adjust.
15223         * record-full.c (record_full_target::resume): Adjust.
15224         * remote.c (remote_target::pass_signals)
15225         (remote_target::program_signals): Adjust.
15226         * target-debug.h (target_debug_print_signals): Now takes a
15227         gdb::array_view as parameter.  Adjust.
15228         * target.h (target_ops) <pass_signals, program_signals>: Replace
15229         pointer and length parameters with gdb::array_view.
15230         (target_pass_signals, target_program_signals): Likewise.
15231         * target-delegates.c: Regenerate.
15232
15233 2019-01-24  Pedro Alves  <palves@redhat.com>
15234
15235         * common/forward-scope-exit.h
15236         (forward_scope_exit::forward_scope_exit): Pass arguments to
15237         m_bind_function directly, instead of creating a std::bind and
15238         copying that.
15239
15240 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15241
15242         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15243         for static members.
15244         (pass_in_v_vfp_candidate): Likewise.
15245
15246 2019-01-23  Tom Tromey  <tom@tromey.com>
15247             Pedro Alves  <palves@redhat.com>
15248
15249         * regcache.c (class regcache_invalidator): Remove.
15250         (regcache::raw_write): Use make_scope_exit.
15251
15252 2019-01-23  Tom Tromey  <tom@tromey.com>
15253
15254         * ui-out.h (class ui_out_emit_type): Update comment.
15255
15256 2019-01-23  Tom Tromey  <tom@tromey.com>
15257
15258         * infrun.c (fetch_inferior_event): Update comment.
15259
15260 2019-01-23  Tom Tromey  <tom@tromey.com>
15261             Pedro Alves  <palves@redhat.com>
15262
15263         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15264         parameter.
15265         (fetch_inferior_event): Use SCOPE_EXIT.
15266
15267
15268 2019-01-23  Tom Tromey  <tom@tromey.com>
15269             Pedro Alves  <palves@redhat.com>
15270
15271         * infrun.c (disable_thread_events): Delete.
15272         (stop_all_threads): Use SCOPE_EXIT.
15273
15274 2019-01-23  Tom Tromey  <tom@tromey.com>
15275             Pedro Alves  <palves@redhat.com>
15276
15277         * symfile.c: Include forward-scope-exit.h.
15278         (clear_symtab_users_cleanup): Replace forward declaration with
15279         a FORWARD_SCOPE_EXIT.
15280         (syms_from_objfile_1): Use the forward_scope_exit and
15281         gdb::optional instead of cleanup_function.
15282         (reread_symbols): Use the forward_scope_exit instead of
15283         cleanup_function.
15284         (clear_symtab_users_cleanup): Remove function.
15285
15286 2019-01-23  Tom Tromey  <tom@tromey.com>
15287             Pedro Alves  <palves@redhat.com>
15288
15289         * linux-nat.c: Include scope-exit.h.
15290         (cleanup_target_stop): Remove.
15291         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15292         SCOPE_EXIT.
15293
15294 2019-01-23  Tom Tromey  <tom@tromey.com>
15295             Pedro Alves  <palves@redhat.com>
15296
15297         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15298         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15299
15300 2019-01-23  Tom Tromey  <tom@tromey.com>
15301             Andrew Burgess  <andrew.burgess@embecosm.com>
15302             Pedro Alves  <palves@redhat.com>
15303
15304         * infrun.c (fetch_inferior_event): Use scope_exit.
15305         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15306         * top.c (execute_command): Use scope_exit.
15307         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15308         * utils.c (do_bpstat_clear_actions_cleanup)
15309         (make_bpstat_clear_actions_cleanup): Remove.
15310
15311 2019-01-23  Tom Tromey  <tom@tromey.com>
15312             Pedro Alves  <palves@redhat.com>
15313
15314         * infrun.c: Include "common/scope-exit.h"
15315         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15316         (wait_for_inferior): Use SCOPE_EXIT.
15317         (fetch_inferior_event): Use scope_exit.
15318
15319 2019-01-23  Tom Tromey  <tom@tromey.com>
15320             Pedro Alves  <palves@redhat.com>
15321
15322         * breakpoint.c (create_breakpoint): Remove cleanup.
15323
15324 2019-01-23  Tom Tromey  <tom@tromey.com>
15325             Andrew Burgess  <andrew.burgess@embecosm.com>
15326             Pedro Alves  <palves@redhat.com>
15327
15328 2019-01-23  Pedro Alves  <palves@redhat.com>
15329
15330         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15331
15332 2019-01-23  Pedro Alves  <palves@redhat.com>
15333             Andrew Burgess  <andrew.burgess@embecosm.com>
15334
15335         * gdbthread.h: Include "common/forward-scope-exit.h".
15336         (scoped_finish_thread_state): Redefine custom class in terms of
15337         forward_scope_exit.
15338
15339 2019-01-23  Pedro Alves  <palves@redhat.com>
15340             Andrew Burgess  <andrew.burgess@embecosm.com>
15341
15342         * common/forward-scope-exit.h: New file.
15343
15344 2019-01-23  Pedro Alves  <palves@redhat.com>
15345             Andrew Burgess  <andrew.burgess@embecosm.com>
15346             Tom Tromey  <tom@tromey.com>
15347
15348         * common/scope-exit.h: New file.
15349
15350 2019-01-23  Pedro Alves  <palves@redhat.com>
15351
15352         * common/preprocessor.h (ESC): Rename to ...
15353         (ESC_PARENS): ... this.
15354         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15355         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15356
15357 2019-01-23  Tom Tromey  <tom@tromey.com>
15358
15359         * language.h (class scoped_switch_to_sym_language_if_auto):
15360         Initialize m_lang in both cases.
15361
15362 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15363
15364         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15365         with XCNEW.
15366
15367 2019-01-22  Tom Tromey  <tom@tromey.com>
15368
15369         * corelow.c: Do not include sys/file.h.
15370
15371 2019-01-22  Tom Tromey  <tom@tromey.com>
15372
15373         * tui/tui-wingeneral.h: Include gdb_curses.h.
15374
15375 2019-01-22  Tom Tromey  <tom@tromey.com>
15376
15377         * source-cache.h (class source_cache) <get_source_lines,
15378         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15379
15380 2019-01-22  Tom Tromey  <tom@tromey.com>
15381
15382         * remote-fileio.h (struct remote_target): Declare.
15383
15384 2019-01-22  Tom Tromey  <tom@tromey.com>
15385
15386         * python/py-arch.c: Do not include py-ref.h.
15387         * python/py-bpevent.c: Do not include py-ref.h.
15388         * python/py-cmd.c: Do not include py-ref.h.
15389         * python/py-continueevent.c: Do not include py-ref.h.
15390         * python/py-event.h: Do not include py-ref.h.
15391         * python/py-evtregistry.c: Do not include py-ref.h.
15392         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15393         * python/py-frame.c: Do not include py-ref.h.
15394         * python/py-framefilter.c: Do not include py-ref.h.
15395         * python/py-function.c: Do not include py-ref.h.
15396         * python/py-infevents.c: Do not include py-ref.h.
15397         * python/py-linetable.c: Do not include py-ref.h.
15398         * python/py-objfile.c: Do not include py-ref.h.
15399         * python/py-param.c: Do not include py-ref.h.
15400         * python/py-prettyprint.c: Do not include py-ref.h.
15401         * python/py-progspace.c: Do not include py-ref.h.
15402         * python/py-symbol.c: Do not include py-ref.h.
15403         * python/py-symtab.c: Do not include py-ref.h.
15404         * python/py-type.c: Do not include py-ref.h.
15405         * python/py-unwind.c: Do not include py-ref.h.
15406         * python/py-utils.c: Do not include py-ref.h.
15407         * python/py-value.c: Do not include py-ref.h.
15408         * python/py-varobj.c: Do not include py-ref.h.
15409         * python/py-xmethods.c: Do not include py-ref.h.
15410         * python/python.c: Do not include py-ref.h.
15411         * varobj.c: Do not include py-ref.h.
15412
15413 2019-01-22  Tom Tromey  <tom@tromey.com>
15414
15415         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15416         keyword for bcache.
15417
15418 2019-01-22  Tom Tromey  <tom@tromey.com>
15419
15420         * compile/compile-cplus-types.c: Remove a comment by #include.
15421
15422 2019-01-22  Tom Tromey  <tom@tromey.com>
15423
15424         * compile/gcc-c-plugin.h: Include compile-internal.h.
15425
15426 2019-01-22  Tom Tromey  <tom@tromey.com>
15427
15428         * stabsread.c (EXTERN): Do not define.
15429         (symnum, next_symbol_text_func, processing_gcc_compilation)
15430         (within_function, global_sym_chain, global_stabs)
15431         (previous_stab_code, this_object_header_files)
15432         (n_this_object_header_files)
15433         (n_allocated_this_object_header_files): Define.
15434         * stabsread.h (EXTERN): Never define.  Use "extern".
15435
15436 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15437
15438         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15439         history_value.
15440
15441 2019-01-21  Tom Tromey  <tom@tromey.com>
15442
15443         * ui-out.c: Fix includes.
15444         * tui/tui-source.c: Fix includes.
15445         * target.c: Fix includes.
15446         * remote.c: Fix includes.
15447         * regcache.c: Fix includes.
15448         * python/py-block.c: Fix includes.
15449         * printcmd.c: Fix includes.
15450         * or1k-tdep.c: Fix includes.
15451         * mi/mi-main.c: Fix includes.
15452         * m32r-tdep.c: Fix includes.
15453         * csky-tdep.c: Fix includes.
15454         * compile/compile-cplus-types.c: Fix includes.
15455         * cli/cli-interp.c: Fix includes.
15456
15457 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15458
15459         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15460         for padding.
15461
15462 2019-01-16  Tom Tromey  <tom@tromey.com>
15463
15464         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15465         earlier.
15466         (struct objfile) <msymbols_range>: Move from top level.
15467         <msymbols>: New method.
15468         (class objfile_msymbols): Remove.
15469         * symtab.c (default_collect_symbol_completion_matches_break_on):
15470         Update.
15471         * symmisc.c (dump_msymbols): Update.
15472         * stabsread.c (scan_file_globals): Update.
15473         * objc-lang.c (info_selectors_command, info_classes_command)
15474         (find_methods): Update.
15475         * minsyms.c (find_solib_trampoline_target): Update.
15476         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15477         * coffread.c (coff_symfile_read): Update.
15478         * ada-lang.c (ada_lookup_simple_minsym)
15479         (ada_collect_symbol_completion_matches): Update.
15480
15481 2019-01-16  Tom Tromey  <tom@tromey.com>
15482
15483         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15484         type.  Remove no-argument constructor.
15485         <iterator::operator++>: Simplify.
15486         <begin>: Update.
15487         <end>: Use minimal_symbol_count.
15488
15489 2019-01-16  Tom Tromey  <tom@tromey.com>
15490
15491         * objfiles.h (struct objfile) <psymtabs>: New method.
15492         (class objfile_psymtabs): Remove.
15493         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15494         typedef.
15495         <range>: New method.
15496         (require_partial_symbols): Change return type.
15497         * psymtab.c (require_partial_symbols)
15498         (psym_expand_symtabs_matching): Update.
15499         * mdebugread.c (parse_partial_symbols): Update.
15500         * dbxread.c (dbx_end_psymtab): Update.
15501
15502 2019-01-15  Tom Tromey  <tom@tromey.com>
15503
15504         * symtab.c (lookup_objfile_from_block)
15505         (lookup_symbol_in_objfile_symtabs)
15506         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15507         (find_line_symtab, info_sources_command)
15508         (default_collect_symbol_completion_matches_break_on)
15509         (make_source_files_completion_list): Update.
15510         * symmisc.c (print_objfile_statistics, dump_objfile)
15511         (maintenance_print_symbols, maintenance_info_symtabs)
15512         (maintenance_check_symtabs, maintenance_info_line_tables):
15513         Update.
15514         * source.c (select_source_symtab)
15515         (forget_cached_source_info_for_objfile): Update.
15516         * objfiles.h (class objfile_compunits): Remove.
15517         (struct objfile) <compunits_range>: New typedef.
15518         (compunits): New method.
15519         * objfiles.c (objfile_relocate1): Update.
15520         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15521         * maint.c (count_symtabs_and_blocks): Update.
15522         * linespec.c (iterate_over_all_matching_symtabs): Update.
15523         * cp-support.c (add_symbol_overload_list_qualified): Update.
15524         * coffread.c (coff_symtab_read): Update.
15525         * ada-lang.c (add_nonlocal_symbols)
15526         (ada_collect_symbol_completion_matches)
15527         (ada_add_global_exceptions): Update.
15528
15529 2019-01-15  Tom Tromey  <tom@tromey.com>
15530
15531         * progspace.h (program_space) <objfiles_safe_range>: New
15532         typedef.
15533         <objfiles_safe>: New method.
15534         * objfiles.h (class all_objfiles_safe): Remove.
15535         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15536         * jit.c (jit_inferior_exit_hook): Update.
15537
15538 2019-01-17  Tom Tromey  <tom@tromey.com>
15539
15540         * progspace.h (program_space) <objfiles_range>: New typedef.
15541         <objfiles>: New method.
15542         <objfiles_head>: Rename from objfiles.
15543         (object_files): Update.
15544         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15545         * guile/scm-pretty-print.c
15546         (ppscm_find_pretty_printer_from_objfiles): Update.
15547         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15548         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15549         Update.
15550         * python/py-progspace.c (pspy_get_objfiles): Update.
15551         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15552         Update.
15553         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15554         (objfpy_lookup_objfile_by_build_id): Update.
15555         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15556         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15557         Update.
15558         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15559         (expand_symtab_containing_pc, lookup_objfile_from_block)
15560         (lookup_static_symbol, basic_lookup_transparent_type)
15561         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15562         (find_line_symtab, info_sources_command)
15563         (default_collect_symbol_completion_matches_break_on)
15564         (make_source_files_completion_list, find_main_name): Update.
15565         * symmisc.c (print_symbol_bcache_statistics)
15566         (print_objfile_statistics, maintenance_print_symbols)
15567         (maintenance_print_msymbols, maintenance_print_objfiles)
15568         (maintenance_info_symtabs, maintenance_check_symtabs)
15569         (maintenance_expand_symtabs, maintenance_info_line_tables):
15570         Update.
15571         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15572         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15573         (map_overlay_command, unmap_overlay_command)
15574         (simple_overlay_update, expand_symtabs_matching)
15575         (map_symbol_filenames): Update.
15576         * symfile-debug.c (set_debug_symfile): Update.
15577         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15578         Update.
15579         * source.c (select_source_symtab, forget_cached_source_info):
15580         Update.
15581         * solib.c (solib_read_symbols): Update.
15582         * solib-spu.c (append_ocl_sos): Update.
15583         * psymtab.c (maintenance_print_psymbols)
15584         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15585         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15586         * printcmd.c (info_symbol_command): Update.
15587         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15588         Update.
15589         * objfiles.h (class all_objfiles): Remove.
15590         * objfiles.c (have_partial_symbols, have_full_symbols)
15591         (have_minimal_symbols, qsort_cmp, update_section_map)
15592         (shared_objfile_contains_address_p)
15593         (default_iterate_over_objfiles_in_search_order): Update.
15594         * objc-lang.c (info_selectors_command, info_classes_command)
15595         (find_methods): Update.
15596         * minsyms.c (find_solib_trampoline_target): Update.
15597         * maint.c (maintenance_info_sections)
15598         (maintenance_translate_address, count_symtabs_and_blocks):
15599         Update.
15600         * main.c (captured_main_1): Update.
15601         * linux-thread-db.c (try_thread_db_load_from_pdir)
15602         (has_libpthread): Update.
15603         * linespec.c (iterate_over_all_matching_symtabs)
15604         (search_minsyms_for_name): Update.
15605         * jit.c (jit_find_objf_with_entry_addr): Update.
15606         * hppa-tdep.c (find_unwind_entry)
15607         (hppa_lookup_stub_minimal_symbol): Update.
15608         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15609         Update.
15610         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15611         (elf_gnu_ifunc_resolve_by_got): Update.
15612         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15613         * dwarf-index-write.c (save_gdb_index_command): Update.
15614         * cp-support.c (add_symbol_overload_list_qualified): Update.
15615         * breakpoint.c (create_overlay_event_breakpoint)
15616         (create_longjmp_master_breakpoint)
15617         (create_std_terminate_master_breakpoint)
15618         (create_exception_master_breakpoint): Update.
15619         * blockframe.c (find_pc_partial_function): Update.
15620         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15621         (ada_collect_symbol_completion_matches)
15622         (ada_add_global_exceptions): Update.
15623
15624 2019-01-17  Tom Tromey  <tom@tromey.com>
15625
15626         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15627         declare VEC.
15628         (solib_target_parse_libraries): Change return type.
15629         (library_list_start_segment, library_list_start_section)
15630         (library_list_end_library, library_list_start_library); Update.
15631         (solib_target_free_library_list): Remove.
15632         (solib_target_parse_libraries): Remove cleanup.  Change return
15633         type.
15634         (solib_target_current_sos): Update.
15635
15636 2019-01-17  Tom Tromey  <tromey@bapiya>
15637
15638         * valprint.c: Replace "the the" with "the".
15639         * symtab.c: Replace "the the" with "the".
15640         * solib.c: Replace "the the" with "the".
15641         * solib-dsbt.c: Replace "the the" with "the".
15642         * linespec.c: Replace "the the" with "the".
15643         * dwarf2loc.h: Replace "the the" with "the".
15644         * amd64-windows-tdep.c: Replace "the the" with "the".
15645         * aarch64-tdep.c: Replace "the the" with "the".
15646
15647 2019-01-16  Keith Seitz  <keiths@redhat.com>
15648
15649         PR gdb/23773
15650         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15651         <builder>: Rename to ..
15652         <m_builder>: ... this and make private.
15653         (dwarf2_cu::get_builder): New method.  Change all users of
15654         `builder' to use this method.
15655         (dwarf2_start_symtab): Move to ...
15656         (dwarf2_cu::start_symtab): ... here.  Update all callers
15657         (setup_type_unit_groups): Move to ...
15658         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15659         callers.
15660         (dwarf2_cu::reset_builder): New method.
15661         (process_full_compunit, process_full_type_unit): Use
15662         dwarf2_cu::reset_builder.
15663         (follow_die_offset): Record the ancestor CU if it is different
15664         from the followed DIE's CU.
15665         (follow_die_sig_1): Likewise.
15666
15667 2019-01-15  Tom Tromey  <tom@tromey.com>
15668
15669         * remote.c (class remote_state) <buf>: Now a char_vector.
15670         <buf_size>: Remove.
15671         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15672         parameter.
15673         (remote_target::getpkt_or_notif_sane_1)
15674         (remote_target::getpkt_sane)
15675         (remote_target::getpkt_or_notif_sane): Likewise.
15676         (class remote_target) <putpkt>: New overload.
15677         (remote_target::read_frame): Change type of "buf_p".  Remove
15678         sizeof_p parameter.
15679         (packet_ok): New overload.
15680         (packet_check_result): New overload.
15681         Update all uses.
15682
15683 2019-01-14  Tom Tromey  <tom@tromey.com>
15684
15685         * remote-notif.c (handle_notification, remote_notif_ack)
15686         (remote_notif_parse): Make "buf" const.
15687         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15688         const.
15689         (remote_notif_parse, remote_notif_ack, handle_notification):
15690         Likewise.
15691         * remote.c (remote_notif_stop_parse): Make "buf" const.
15692         (remote_target::remote_parse_stop_reply): Make "buf" const.
15693         (remote_notif_stop_ack): Make "buf" const.
15694
15695 2019-01-14  Tom Tromey  <tom@tromey.com>
15696
15697         * remote.c (remote_console_output): Make parameter const.
15698
15699 2019-01-14  Tom Tromey  <tom@tromey.com>
15700
15701         * target-debug.h (target_debug_print_signals): Constify.
15702         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15703         * procfs.c (procfs_target::pass_signals): Update.
15704         * linux-nat.c (linux_nat_target::pass_signals): Update.
15705         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15706         * target-delegates.c: Rebuild.
15707         * remote.c (remote_target::program_signals): Update.
15708         (remote_target::pass_signals): Update.
15709         * target.c (target_pass_signals): Constify argument.
15710         (target_program_signals): Likewise.
15711         * target.h (struct target_ops) <pass_signals, program_signals>:
15712         Constify argument.
15713         (target_pass_signals, target_program_signals): Constify argument.
15714
15715 2019-01-14  Tom Tromey  <tom@tromey.com>
15716
15717         PR tui/28819:
15718         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15719
15720 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15721
15722         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15723         field.
15724         * rs6000-tdep.c: Include reggroups.h.
15725         (IS_V_ALIAS_PSEUDOREG): Define.
15726         (rs6000_register_name): Return names for the "vX" aliases.
15727         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15728         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15729         aliases.  Call default_register_reggroup_p for all other
15730         pseudo-registers.
15731         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15732         New functions.
15733         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15734         Handle "vX" aliases.
15735         (v_alias_pseudo_register_collect): New function.
15736         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15737         (rs6000_gdbarch_init): Initialize "vX" aliases as
15738         pseudo-registers.  Restore registration of
15739         rs6000_pseudo_register_reggroup_p with
15740         set_tdesc_pseudo_register_reggroup_p.
15741
15742 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15743
15744         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15745         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15746         set_gdbarch_num_pseudo_regs.
15747
15748 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15749
15750         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15751         Remove arg prefixname, add do_set and do_show.
15752         Add member functions set_list and show_list.
15753         * cli/cli-style.c (class cli_style_option): Update accordingly.
15754         (style_set_list): Move to file scope.
15755         (style_show_list): Likewise.
15756         (set_style): Call help_list.
15757         (show_style): Call cmd_show_list.
15758         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15759         Update to use the new macro.
15760
15761 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15762
15763         * ada-lang.c (_initialize_ada_language): Expand the help text
15764         for the "catch exception" command.
15765
15766 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15767
15768         * symtab.c (matching_obj_sections): Initialize obj,
15769         declare it closer to its usage.
15770
15771 2019-01-10  Tom Tromey  <tom@tromey.com>
15772
15773         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15774         (basic_inf_threads_range): Remove.
15775         (inf_threads_range, inf_non_exited_threads_range)
15776         (safe_inf_threads_range): Use next_adapter.
15777
15778 2019-01-10  Keith Seitz  <keiths@redhat.com>
15779
15780         PR gdb/23712
15781         PR symtab/23010
15782         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15783         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15784
15785 2019-01-10  Keith Seitz  <keiths@redhat.com>
15786
15787         PR gdb/23712
15788         PR symtab/23010
15789         * dictionary.c (pending_to_vector): Remove.
15790         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15791         Remove _1 suffix, replacing functions of the same name.  Update
15792         all callers.
15793         (dict_create_hashed, dict_create_hashed_expandable)
15794         (dict_create_linear, dict_create_linear_expandable, dict_free)
15795         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15796         Make functions static.
15797
15798 2019-01-10  Keith Seitz  <keiths@redhat.com>
15799
15800         PR gdb/23712
15801         PR symtab/23010
15802         * dictionary.h (struct dictionary): Replace declaration with
15803         multidictionary.
15804         (dict_create_hashed, dict_create_hashed_expandable)
15805         (dict_create_linear, dict_create_linear_expandable)
15806         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15807         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15808         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15809         taking multidictionary argument.
15810         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15811         * block.h (struct block) <dict>: Change to multidictionary
15812         and rename `multidict'.
15813         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15814         symmisc.c: Update all dictionary references to multidictionary.
15815
15816 2019-01-10  Keith Seitz  <keiths@redhat.com>
15817
15818         PR gdb/23712
15819         PR symtab/23010
15820         * dictionary.c: Include unordered_map.
15821         (pending_to_vector): New function.
15822         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15823         Rewrite the non-"_1" functions to take vector instead
15824         of linked list.
15825         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15826         "new" _1 versions of the same name.
15827         (multidictionary): Define.
15828         (std::hash<enum language): New definition.
15829         (collate_pending_symbols_by_language, mdict_create_hashed)
15830         (mdict_create_hashed_expandable, mdict_create_linear)
15831         (mdict_create_linear_expandable, mdict_free)
15832         (find_language_dictionary, create_new_language_dictionary)
15833         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15834         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15835         (mdict_size, mdict_empty): New functions.
15836         * dictionary.h (mdict_iterator): Define.
15837
15838 2019-01-10  Pedro Alves  <palves@redhat.com>
15839
15840         * breakpoint.c (read_uploaded_action)
15841         (create_tracepoint_from_upload): Adjust to use
15842         gdb::unique_xmalloc_ptr.
15843         * ctf.c (ctf_write_uploaded_tp):
15844         (SET_ARRAY_FIELD): Use emplace_back.
15845         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15846         * tracefile-tfile.c (tfile_write_uploaded_tp):
15847         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15848         gdb::unique_xmalloc_ptr.
15849         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15850         at_string, cond_string, cmd_strings>: Replace char pointers
15851         with gdb::unique_xmalloc_ptr.
15852
15853 2019-01-10  Pedro Alves  <palves@redhat.com>
15854
15855         * solib-target.c (library_list_start_library): Don't xstrdup name.
15856
15857 2019-01-10  Pedro Alves  <palves@redhat.com>
15858
15859         * mdebugread.c (parse_partial_symbols): Use
15860         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15861
15862 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15863
15864         * linux-fork.c (scoped_switch_fork_info)
15865         <~scoped_switch_fork_info>: Fix incorrect variable name.
15866
15867 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15868
15869         * linux-fork.c (scoped_switch_fork_info)
15870         <scoped_switch_fork_info>: Make explicit.
15871         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15872
15873 2019-01-10  Tom Tromey  <tom@tromey.com>
15874
15875         * objfiles.h (objfile::reset_psymtabs): Update.
15876         * objfiles.c (objfile::objfile): Update.
15877         * psymtab.h (psymtab_storage::obstack): Update.
15878         (psymtab_storage::m_obstack): Use gdb::optional.
15879         (class psymtab_storage): Update comment.  Remove objfile
15880         parameter.
15881         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15882
15883 2019-01-10  Tom Tromey  <tom@tromey.com>
15884
15885         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15886         <free_psymtabs>: Now private.
15887         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15888         (allocate_psymtab): Use new method.
15889
15890 2019-01-10  Tom Tromey  <tom@tromey.com>
15891
15892         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15893         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15894         * mdebugread.c (parse_partial_symbols): Use
15895         allocate_dependencies.
15896         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15897         allocate_dependencies.
15898         (process_psymtab_comp_unit_reader)
15899         (build_type_psymtab_dependencies): Likewise.
15900         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15901
15902 2019-01-10  Tom Tromey  <tom@tromey.com>
15903
15904         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15905         PSYMBOL_SET_LANGUAGE.
15906         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15907
15908 2019-01-10  Tom Tromey  <tom@tromey.com>
15909
15910         * psymtab.h (psymtab_storage::obstack): New method.
15911         <m_obstack>: Rename from obstack; now private.
15912         * psymtab.c (psymtab_storage): Update.
15913         * dwarf2read.c (create_addrmap_from_index)
15914         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15915         Update.
15916
15917 2019-01-10  Tom Tromey  <tom@tromey.com>
15918
15919         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15920         * objfiles.h (objfile::reset_psymtabs): New method.
15921
15922 2019-01-10  Tom Tromey  <tom@tromey.com>
15923
15924         * symmisc.c (print_symbol_bcache_statistics): Update.
15925         (print_objfile_statistics): Update.
15926         * symfile.c (reread_symbols): Update.
15927         * psymtab.h (class psymtab_storage): New.
15928         * psymtab.c (psymtab_storage): New constructor.
15929         (~psymtab_storage): New destructor.
15930         (require_partial_symbols): Update.
15931         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15932         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15933         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15934         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15935         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15936         (start_psymtab_common, end_psymtab_common)
15937         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15938         (allocate_psymtab): Update.
15939         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15940         Update.
15941         (dump_psymtab_addrmap, maintenance_print_psymbols)
15942         (maintenance_check_psymtabs): Update.
15943         (class objfile_psymtabs): Move to objfiles.h.
15944         * psympriv.h (discard_psymtab): Now inline.
15945         (psymtab_discarder::psymtab_discarder): Update.
15946         (psymtab_discarder::~psymtab_discarder): Update.
15947         (ALL_OBJFILE_PSYMTABS): Rewrite.
15948         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15949         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15950         Remove fields.
15951         <partial_symtabs>: New field.
15952         (class objfile_psymtabs): Move from psymtab.h.  Update.
15953         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15954         psymbol_cache.
15955         (objfile::~objfile): Don't destroy psymbol_cache.
15956         * mdebugread.c (parse_partial_symbols): Update.
15957         * dwarf2read.c (create_addrmap_from_index)
15958         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15959         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15960         (add_partial_subprogram, dwarf2_ranges_read): Update.
15961         * dwarf-index-write.c (write_address_map)
15962         (write_one_signatured_type, recursively_write_psymbols)
15963         (class debug_names, class debug_names, write_psymtabs_to_index):
15964         Update.
15965
15966 2019-01-10  Tom Tromey  <tom@tromey.com>
15967
15968         * symtab.h (SYMBOL_SET_NAMES): Update.
15969         (symbol_set_names): Update.
15970         (MSYMBOL_SET_NAMES): Update.
15971         * symtab.c (symbol_set_names): Change argument to be an
15972         objfile_per_bfd_storage.
15973         * psymtab.c (add_psymbol_to_bcache): Update.
15974         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15975
15976 2019-01-10  Tom Tromey  <tom@tromey.com>
15977
15978         * symtab.c (create_demangled_names_hash): Change argument to be an
15979         objfile_per_bfd_storage.
15980         (symbol_set_names): Update.
15981
15982 2019-01-10  Tom Tromey  <tom@tromey.com>
15983
15984         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15985         init_psymbol_list.
15986         * psymtab.c (init_psymbol_list): Do nothing if already called.
15987         * psympriv.h (init_psymbol_list): Add comment.
15988         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15989         init_psymbol_list.
15990         * dbxread.c (dbx_symfile_read): Unconditionally call
15991         init_psymbol_list.
15992
15993 2019-01-10  Tom Tromey  <tom@tromey.com>
15994
15995         * xcoffread.c (scan_xcoff_symtab): Update.
15996         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15997         "where".
15998         * mdebugread.c (parse_partial_symbols)
15999         (handle_psymbol_enumerators): Update.
16000         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16001         * dbxread.c (read_dbx_symtab): Update.
16002         * psympriv.h (psymbol_placement): New enum.
16003         (add_psymbol_to_list): Update.
16004
16005 2019-01-10  Tom Tromey  <tom@tromey.com>
16006
16007         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16008         static_psymbols parameters.
16009         (scan_xcoff_symtab): Update.
16010         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16011         static_psymbols parameters.
16012         * psympriv.h (start_psymtab_common): Update.
16013         * mdebugread.c (parse_partial_symbols): Update.
16014         * dwarf2read.c (create_partial_symtab): Update.
16015         * dbxread.c (read_dbx_symtab): Update.
16016         (start_psymtab): Remove global_psymbols and static_psymbols
16017         parameters.
16018
16019 2019-01-10  Tom Tromey  <tom@tromey.com>
16020
16021         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16022         * psymtab.c (allocate_psymtab): Add comment.
16023         * psympriv.h (allocate_psymtab): Add comment.
16024         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16025         initializations.
16026         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16027
16028 2019-01-10  Tom Tromey  <tom@tromey.com>
16029
16030         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16031         Don't declare.
16032         * mipsread.c: Include mdebugread.h.
16033         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16034         Declare.
16035         * elfread.c: Include mdebugread.h.
16036
16037 2019-01-09  Tom Tromey  <tom@tromey.com>
16038
16039         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16040         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16041         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16042         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16043         (psym_lookup_symbol, psym_find_last_source_symtab)
16044         (psym_forget_cached_source_info, psym_print_stats)
16045         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16046         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16047         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16048         (psym_find_compunit_symtab_by_address)
16049         (maintenance_print_psymbols, maintenance_info_psymtabs)
16050         (maintenance_check_psymtabs): Use ranged for.
16051         * psymtab.h (class objfile_psymtabs): New.
16052         (require_partial_symbols): Return objfile_psymtabs.
16053         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16054
16055 2019-01-09  Tom Tromey  <tom@tromey.com>
16056
16057         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16058         (find_pc_mapped_section, list_overlays_command)
16059         (map_overlay_command, unmap_overlay_command)
16060         (simple_overlay_update): Use all_objfiles.
16061         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16062         * printcmd.c (info_symbol_command): Use all_objfiles.
16063         * objfiles.h (ALL_OBJSECTIONS): Remove.
16064         * maint.c (maintenance_translate_address): Use all_objfiles.
16065         * gcore.c (gcore_create_callback): Use all_objfiles.
16066         (objfile_find_memory_regions): Likewise.
16067
16068 2019-01-09  Tom Tromey  <tom@tromey.com>
16069
16070         * symtab.c (find_line_symtab, info_sources_command)
16071         (make_source_files_completion_list): Use objfile_compunits.
16072         * source.c (select_source_symtab): Use objfile_compunits.
16073         * objfiles.h (struct objfile): Update comment.
16074         (ALL_OBJFILES): Remove.
16075         (ALL_FILETABS): Remove.
16076         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16077         objfile_compunits.
16078
16079 2019-01-09  Tom Tromey  <tom@tromey.com>
16080
16081         * symmisc.c (print_objfile_statistics, dump_objfile)
16082         (maintenance_print_symbols): Use compunit_filetabs.
16083         * source.c (forget_cached_source_info_for_objfile): Use
16084         compunit_filetabs.
16085         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16086         (ALL_FILETABS): Use compunit_filetabs.
16087         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16088         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16089
16090 2019-01-09  Tom Tromey  <tom@tromey.com>
16091
16092         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16093         (compunit_filetabs): New.
16094         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16095         compunit_filetabs.
16096         (info_sources_command, make_source_files_completion_list): Remove
16097         declaration.
16098         * symmisc.c (print_objfile_statistics, dump_objfile)
16099         (maintenance_print_symbols): Remove declaration.
16100         (maintenance_info_symtabs): Use compunit_filetabs.
16101         (maintenance_info_line_tables): Likewise.
16102         * source.c (select_source_symtab): Change local variable name.
16103         (forget_cached_source_info_for_objfile): Remove declaration.
16104         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16105         * objfiles.c (objfile_relocate1): Remove declaration.
16106         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16107         declaration.
16108         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16109         * coffread.c (coff_symtab_read): Remove declaration.
16110         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16111         compunit_filetabs.
16112
16113 2019-01-09  Tom Tromey  <tom@tromey.com>
16114
16115         * symtab.c (lookup_objfile_from_block)
16116         (find_pc_sect_compunit_symtab, search_symbols)
16117         (default_collect_symbol_completion_matches_break_on): Use
16118         objfile_compunits.
16119         * objfiles.h (ALL_COMPUNITS): Remove.
16120         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16121         * cp-support.c (add_symbol_overload_list_qualified): Use
16122         objfile_compunits.
16123         * ada-lang.c (ada_collect_symbol_completion_matches)
16124         (ada_add_global_exceptions): Use objfile_compunits.
16125
16126 2019-01-09  Tom Tromey  <tom@tromey.com>
16127
16128         * source.c (select_source_symtab)
16129         (forget_cached_source_info_for_objfile): Remove declaration.
16130         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16131         declaration.
16132         * maint.c (count_symtabs_and_blocks): Remove declaration.
16133         * cp-support.c (add_symbol_overload_list_qualified): Remove
16134         declaration.
16135         * coffread.c (coff_symtab_read): Remove declaration.
16136         * symtab.c (lookup_symbol_in_objfile_symtabs)
16137         (basic_lookup_transparent_type_1): Use objfile_compunits.
16138         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16139         (info_sources_command, search_symbols)
16140         (default_collect_symbol_completion_matches_break_on)
16141         (make_source_files_completion_list): Remove declaration.
16142         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16143         (ada_collect_symbol_completion_matches)
16144         (ada_add_global_exceptions): Remove declaration.
16145         * linespec.c (iterate_over_all_matching_symtabs): Use
16146         objfile_compunits.
16147         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16148         (class objfile_compunits): New.
16149         (ALL_COMPUNITS): Use objfile_compunits.
16150         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16151         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16152         objfile_compunits.
16153         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16154
16155 2019-01-09  Tom Tromey  <tom@tromey.com>
16156
16157         * symtab.c (search_symbols)
16158         (default_collect_symbol_completion_matches_break_on): Use
16159         objfile_msymbols.
16160         * ada-lang.c (ada_lookup_simple_minsym)
16161         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16162         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16163         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16164         objfile_msymbols.
16165         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16166         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16167         * objc-lang.c (find_methods): Use objfile_msymbols.
16168         (info_selectors_command, info_classes_command): Likewise.
16169         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16170         * objfiles.h (class objfile_msymbols): New.
16171         (ALL_OBJFILE_MSYMBOLS): Remove.
16172         (ALL_MSYMBOLS): Remove.
16173
16174 2019-01-09  Tom Tromey  <tom@tromey.com>
16175
16176         * common/next-iterator.h (next_adapter): Add Iterator template
16177         parameter.
16178         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16179         (class all_objfiles_safe): New.
16180         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16181         * objfiles.c (put_objfile_before): Update comment.
16182         (add_separate_debug_objfile): Likewise.
16183         (free_all_objfiles): Use all_objfiles_safe.
16184         (objfile_purge_solibs): Likewise.
16185
16186 2019-01-09  Tom Tromey  <tom@tromey.com>
16187
16188         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16189         (expand_symtab_containing_pc, lookup_static_symbol)
16190         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16191         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16192         all_objfiles.
16193         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16194         * breakpoint.c (create_overlay_event_breakpoint)
16195         (create_longjmp_master_breakpoint)
16196         (create_std_terminate_master_breakpoint)
16197         (create_exception_master_breakpoint): Use all_objfiles.
16198         * linux-thread-db.c (try_thread_db_load_from_pdir)
16199         (has_libpthread): Use all_objfiles.
16200         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16201         * linespec.c (iterate_over_all_matching_symtabs)
16202         (search_minsyms_for_name): Use all_objfiles.
16203         * maint.c (maintenance_info_sections): Use all_objfiles.
16204         * main.c (captured_main_1): Use all_objfiles.
16205         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16206         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16207         * guile/scm-pretty-print.c
16208         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16209         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16210         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16211         (maintenance_print_msymbols): Use all_objfiles.
16212         * source.c (select_source_symtab): Use all_objfiles.
16213         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16214         * symfile.c (remove_symbol_file_command)
16215         (expand_symtabs_matching, map_symbol_filenames): Use
16216         all_objfiles.
16217         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16218         all_objfiles.
16219         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16220         * objc-lang.c (find_methods): Use all_objfiles.
16221         * objfiles.c (have_partial_symbols, have_full_symbols)
16222         (have_minimal_symbols, qsort_cmp)
16223         (default_iterate_over_objfiles_in_search_order): Use
16224         all_objfiles.
16225         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16226         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16227         (maintenance_check_psymtabs): Use all_objfiles.
16228         (ALL_PSYMTABS): Remove.
16229         * compile/compile-object-run.c (do_module_cleanup): Use
16230         all_objfiles.
16231         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16232         * cp-support.c (add_symbol_overload_list_qualified): Use
16233         all_objfiles.
16234         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16235         Use all_objfiles.
16236         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16237         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16238         all_objfiles.
16239         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16240         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16241         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16242         Uses all_objfiles.
16243         * solib.c (solib_read_symbols): Use all_objfiles
16244
16245 2019-01-09  Tom Tromey  <tom@tromey.com>
16246
16247         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16248         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16249         all_objfiles.
16250         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16251         * symmisc.c (print_symbol_bcache_statistics)
16252         (print_objfile_statistics, maintenance_print_objfiles)
16253         (maintenance_info_symtabs, maintenance_check_symtabs)
16254         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16255         all_objfiles.
16256         * source.c (forget_cached_source_info): Use all_objfiles.
16257         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16258         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16259         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16260         * objfiles.c (update_section_map): Use all_objfiles.
16261         (shared_objfile_contains_address_p): Likewise.
16262         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16263         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16264
16265 2019-01-09  Tom Tromey  <tom@tromey.com>
16266
16267         * common/next-iterator.h: New file.
16268         * objfiles.h (class all_objfiles): New.
16269         (struct objfile_iterator): New.
16270
16271 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16272
16273         * NEWS: Move the description of the changed "frame", "select-frame",
16274          and "info frame" commands to the Changed commands section.
16275
16276 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16277
16278         * gdbtypes.c (check_stub_method_group): Remove handling of old
16279         mangling schemes.
16280         * linespec.c (find_methods): Likewise.
16281         * stabsread.c (read_member_functions): Likewise.
16282         * valops.c (search_struct_method): Likewise.
16283         (value_struct_elt_for_reference): Likewise.
16284         * NEWS: Mention this change.
16285
16286 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16287
16288         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16289         print_source_lines.
16290         * source.c (print_source_lines_base): Update line number check.
16291         (print_source_lines): New function.
16292         (source_lines_range::source_lines_range): New function.
16293         * source.h (class source_lines_range): New class.
16294         (print_source_lines): New declaration.
16295
16296 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16297
16298         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16299
16300 2019-01-08  Tom Tromey  <tom@tromey.com>
16301             Simon Marchi  <simon.marchi@ericsson.com>
16302
16303         PR gdb/24060
16304         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16305         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16306         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16307         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16308         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16309         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16310
16311 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16312
16313         * source.c (select_source_symtab): Move header comment to
16314         declaration in source.h.
16315         (forget_cached_source_info_for_objfile): Likewise.
16316         (forget_cached_source_info): Likewise.
16317         (identify_source_line): Likewise.
16318         * source.h (identify_source_line): Move declaration from symtab.h
16319         and add comment from source.c
16320         (print_source_lines): Likewise.
16321         (forget_cached_source_info_for_objfile): Likewise.
16322         (forget_cached_source_info): Likewise.
16323         (select_source_symtab): Likewise.
16324         (enum print_source_lines_flag): Move definition from symtab.h.
16325         * symtab.h (identify_source_line): Move declaration to source.h.
16326         (print_source_lines): Likewise.
16327         (forget_cached_source_info_for_objfile): Likewise.
16328         (forget_cached_source_info): Likewise.
16329         (select_source_symtab): Likewise.
16330         (enum print_source_lines_flag): Move definition to source.h.
16331         * tui/tui-hooks.c: Add 'source.h' include.
16332
16333 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16334
16335         * source.c (print_source_lines_base): Handle requests to print
16336         reverse line number sequences, and guard against empty lines
16337         string.
16338
16339 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16340
16341         * source.c (print_source_lines_base): Fix skip of '\r' if next
16342         character is '\n'.
16343
16344 2019-01-06  Tom Tromey  <tom@tromey.com>
16345
16346         * c-exp.y (struct c_parse_state) <macro_original_text,
16347         expansion_obstack>: New member.
16348         (macro_original_text, expansion_obstack): Remove globals.
16349         (scan_macro_expansion, scanning_macro_expansion)
16350         (finished_macro_expansion): Update.
16351         (scan_macro_cleanup): Remove.
16352         (yylex, c_parse): Update.
16353
16354 2019-01-06  Tom Tromey  <tom@tromey.com>
16355
16356         * c-exp.y (struct c_parse_state) <strings>: New member.
16357         (operator_stoken): Update.
16358
16359 2019-01-06  Tom Tromey  <tom@tromey.com>
16360
16361         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16362         (union type_stack_elt) <typelist_val>: Now a pointer to
16363         std::vector.
16364         (type_stack_cleanup): Don't declare.
16365         (push_typelist): Update.
16366         * parse.c (pop_typelist): Return a std::vector.
16367         (push_typelist): Take a std::vector.
16368         (follow_types): Update.  Do not free args.
16369         (type_stack_cleanup): Remove.
16370         * c-exp.y (struct c_parse_state): New.
16371         (cpstate): New global.
16372         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16373         (nonempty_typelist): Update.
16374         (func_mod): Create a new vector.
16375         (c_parse): Create a c_parse_state.
16376         (check_parameter_typelist): Do not delete params.
16377         (function_method): Update.  Do not delete type_list.
16378
16379 2019-01-06  Tom Tromey  <tom@tromey.com>
16380
16381         PR gdb/28155:
16382         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16383         check_typedef.
16384         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16385         (print_return_value): Likewise.
16386
16387 2019-01-05  Tom Tromey  <tom@tromey.com>
16388
16389         * contrib/cleanup_check.py: Remove.
16390         * contrib/gcc-with-excheck: Remove.
16391         * contrib/exsummary.py: Remove.
16392         * contrib/excheck.py: Remove.
16393
16394 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16395
16396         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16397         NULL. Initialize tpprev to NULL instead of assigning it
16398         to NULL on the next statement.
16399         * windows-nat.c (windows_delete_thread): Remove check for
16400         main_thread_id before printing thread exit notifications.
16401         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16402         Remove thread ID check against main_thread_id.
16403         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16404         windows_delete_thread.
16405         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16406
16407 2019-01-04  Tom Tromey  <tom@tromey.com>
16408
16409         * compile/compile.c (_initialize_compile): Use upper case for
16410         metasyntactic variables.
16411         * symmisc.c (_initialize_symmisc): Use upper case for
16412         metasyntactic variables.
16413         * psymtab.c (_initialize_psymtab): Use upper case for
16414         metasyntactic variables.
16415         * demangle.c (demangle_command): Use upper case for metasyntactic
16416         variables.
16417         (_initialize_demangler): Likewise.
16418         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16419         variables.
16420
16421 2019-01-03  Tom Tromey  <tom@tromey.com>
16422
16423         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16424
16425 2019-01-03  Tom Tromey  <tom@tromey.com>
16426
16427         * python/py-symtab.c (salpy_str): Update.
16428         (struct salpy_sal_object) <symtab>: Now a PyObject.
16429         (salpy_dealloc): Update.
16430         (del_objfile_sal): Use gdbpy_ref.
16431
16432 2019-01-03  Tom Tromey  <tom@tromey.com>
16433
16434         * python/py-type.c (convert_field): Use new_reference.  Return
16435         gdbpy_ref.
16436         (make_fielditem): Return gdbpy_ref.
16437         (typy_fields): Update.
16438         (typy_getitem): Update.
16439         (field_name): Return gdbpy_ref.  Use new_reference.
16440         (typy_iterator_iternext): Update.
16441
16442 2019-01-03  Tom Tromey  <tom@tromey.com>
16443
16444         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16445
16446 2019-01-03  Tom Tromey  <tom@tromey.com>
16447
16448         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16449         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16450         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16451         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16452         (pspy_set_type_printers): Likewise.
16453         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16454         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16455         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16456         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16457         (objfpy_set_type_printers): Likewise.
16458
16459 2019-01-03  Tom Tromey  <tom@tromey.com>
16460
16461         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16462         (gdbpy_print_stack): Use gdbpy_err_fetch.
16463         * python/python-internal.h (class gdbpy_err_fetch): New class.
16464         (class gdbpy_enter) <m_error_type, m_error_value,
16465         m_error_traceback>: Remove.
16466         <m_error>: New member.
16467         (gdbpy_exception_to_string): Don't declare.
16468         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16469         * python/py-value.c (convert_value_from_python): Use
16470         gdbpy_err_fetch.
16471         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16472         gdbpy_exception_to_string.
16473         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16474         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16475         gdbpy_err_fetch.
16476
16477 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16478
16479         * linux-nat.c (delete_lwp_cleanup): Delete.
16480         (struct lwp_deleter): New struct.
16481         (lwp_info_up): New typedef.
16482         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16483         lwp_info_up.
16484
16485 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16486
16487         * linux-fork.c (class scoped_switch_fork_info): New class.
16488         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16489
16490 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16491
16492         * valops.c (find_overload_match): Remove use of null_cleanup, and
16493         calls to do_cleanups.
16494
16495 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16496
16497         * compile/compile-cplus-types.c
16498         (compile_cplus_instance::decl_name): Handle changes to
16499         cp_func_name.
16500         * cp-support.c (cp_func_name): Update header comment, update
16501         return type.
16502         * cp-support.h (cp_func_name): Update return type in declaration.
16503         * valops.c (find_overload_match): Move temp_func local to top
16504         level of function and change its type.  Use temp_func to hold and
16505         delete temporary string obtained from cp_func_name.
16506
16507 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16508
16509         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16510         gdb::char_vector, remove cleanup, and update uses of `msg`.
16511
16512 2019-01-03  Jim Wilson  <jimw@sifive.com>
16513
16514         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16515
16516 2019-01-02  Tom Tromey  <tom@tromey.com>
16517
16518         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16519         (tdesc_parse_xml): Remove cleanups.
16520         * target-descriptions.h (make_cleanup_free_target_description):
16521         Don't declare.
16522         (target_desc_deleter): New struct.
16523         (target_desc_up): New typedef.
16524         * target-descriptions.c (target_desc_deleter::operator()): Rename
16525         from free_target_description.
16526         (make_cleanup_free_target_description): Remove.
16527
16528 2019-01-02  Tom Tromey  <tom@tromey.com>
16529
16530         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16531         constructor, destructor.
16532         (linespec_parser): Remove typedef.
16533         (~linespec_parser): Rename from linespec_parser_delete.
16534         (linespec_lex_to_end, linespec_complete_label)
16535         (linespec_complete): Update.
16536         (decode_line_full): Remove cleanups.
16537         (decode_line_1): Update.
16538
16539 2019-01-02  Tom Tromey  <tom@tromey.com>
16540
16541         * python/python-internal.h (inferior_to_inferior_object): Change
16542         return type.
16543         * python/py-exitedevent.c (create_exited_event_object): Update.
16544         * python/py-inferior.c (inferior_to_inferior_object): Return
16545         gdbpy_ref.
16546         (python_new_inferior, python_inferior_deleted)
16547         (thread_to_thread_object, delete_thread_object)
16548         (build_inferior_list, gdbpy_selected_inferior): Update.
16549         * python/py-infthread.c (create_thread_object): Update.  Also fail
16550         if inferior_to_inferior_object fails.
16551
16552 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16553
16554         * inferior.h (class inferior) <displaced_step_state>: New field.
16555         * infrun.h (struct displaced_step_state): Move here from
16556         infrun.c.  Initialize fields, add constructor.
16557         <inf>: Remove field.
16558         <reset>: New method.
16559         * infrun.c (struct displaced_step_inferior_state): Move to
16560         infrun.h.
16561         (displaced_step_inferior_states): Remove.
16562         (get_displaced_stepping_state): Adust.
16563         (displaced_step_in_progress_any_inferior): Adjust.
16564         (displaced_step_in_progress_thread): Adjust.
16565         (displaced_step_in_progress): Adjust.
16566         (add_displaced_stepping_state): Remove.
16567         (get_displaced_step_closure_by_addr): Adjust.
16568         (remove_displaced_stepping_state): Remove.
16569         (infrun_inferior_exit): Call displaced_step_state.reset.
16570         (use_displaced_stepping): Don't check for NULL.
16571         (displaced_step_prepare_throw): Call
16572         get_displaced_stepping_state.
16573         (displaced_step_fixup): Don't check for NULL.
16574         (prepare_for_detach): Don't check for NULL.
16575
16576 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16577
16578         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16579          in case of call that did not complete.
16580
16581 2019-01-02  Andrey Utkin  <autkin@undo.io>
16582
16583         * symfile.c (find_separate_debug_file): Fix search of debug files for
16584         remote debuggee.
16585
16586 2019-01-02  Tom Tromey  <tom@tromey.com>
16587
16588         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16589         indentation.
16590         * python/py-frame.c (frapy_older): Remove cast.
16591         (frapy_newer): Likewise.
16592         * python/py-breakpoint.c (local_setattro): Remove cast.
16593         * python/py-arch.c (archpy_name): Remove local variable.
16594         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16595
16596 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16597
16598         * unittests/basic_string_view/element_access/char/empty.cc:
16599         Fix year range in copyright header.
16600
16601 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16602
16603         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16604         Delete.
16605         <operator==>: Update with for removed field.
16606         <hash>: Likewise.
16607         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16608         <isa_features>: ...this.
16609         <abi_features>: New field.
16610         (riscv_isa_flen): Update comment.
16611         (riscv_abi_xlen): New declaration.
16612         (riscv_abi_flen): New declaration.
16613         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16614         isa_features.
16615         (riscv_abi_xlen): New function.
16616         (riscv_isa_flen): Update to get answer from isa_features.
16617         (riscv_abi_flen): New function.
16618         (riscv_has_fp_abi): Update to get answer from abi_features.
16619         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16620         xlen and flen.
16621         (riscv_call_info) <xlen, flen>: Update comment.
16622         (riscv_call_arg_struct): Remove invalid assertions
16623         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16624         is removed.
16625         (riscv_gdbarch_init): Gather isa features and abi features
16626         separately, ensure both match on the gdbarch when reusing an old
16627         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16628         a target with 64-bit float hardware.
16629
16630 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16631
16632         * source.c (search_command_helper): Stop reverse search
16633         when line 1 has been searched.
16634
16635 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16636
16637         * record-full.c (record_full_base_target::close): Rewrite
16638         record_full_core_buf_list free logic.
16639
16640 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16641
16642         * break-catch-syscall.c (print_one_catch_syscall): xfree
16643         the last text.
16644
16645 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16646
16647         * top.c (print_gdb_version): Update Copyright year in version
16648         message.
16649
16650 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16651
16652         Update copyright year range in all GDB files.
16653
16654 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16655
16656         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16657
16658 For older changes see ChangeLog-2018.
16659 \f
16660 Local Variables:
16661 mode: change-log
16662 left-margin: 8
16663 fill-column: 74
16664 version-control: never
16665 coding: utf-8
16666 End:
16667