9c1322d2a0da10e6907bcea8146a427702de0733
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2019-12-12 Tom Tromey <tom@tromey.com>
2
3 * symfile.c (symbol_file_clear): Update.
4 * progspace.h (struct program_space) <free_all_objfiles>: Declare
5 method.
6 * progspace.c (program_space::free_all_objfiles): New method.
7 * objfiles.h (free_all_objfiles): Don't declare.
8 * objfiles.c (free_all_objfiles): Move to program_space.
9
10 2019-12-12 Tom Tromey <tom@tromey.com>
11
12 * progspace.c (program_space::add_objfile)
13 (program_space::remove_objfile): Update.
14 (program_space::multi_objfile_p): Remove.
15 * objfiles.h (struct objfile) <next>: Remove.
16 * objfiles.c (objfile::objfile): Update.
17 (put_objfile_before): Update.
18 (unlink_objfile): Update.
19 * progspace.h (object_files): Remove.
20 (struct program_space) <objfiles_head>: Remove.
21 <objfiles_list>: New member.
22 <objfiles_range, objfiles_safe_range>: Change type.
23 (objfiles): Change return type.
24 (objfiles_safe): Update.
25 (multi_objfile_p): Rewrite and inline.
26 (object_files): Remove macro.
27
28 2019-12-12 Tom Tromey <tom@tromey.com>
29
30 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
31 second constructor.
32 (basic_safe_range): New class.
33
34 2019-12-12 Tom Tromey <tom@tromey.com>
35
36 * progspace.c (program_space::multi_objfile_p): New method.
37 * printcmd.c (info_symbol_command): Update.
38 * maint.c (maintenance_translate_address): Update.
39 * objfiles.h (MULTI_OBJFILE_P): Remove.
40 * progspace.h (struct program_space) <multi_objfile_p>: New
41 method.
42
43 2019-12-12 Tom Tromey <tom@tromey.com>
44
45 * progspace.h (struct program_space) <remove_objfile>: Declare.
46 * progspace.c (program_space::remove_objfile): New method.
47 * objfiles.c (unlink_objfile): Remove.
48 (objfile::unlink): Call remove_objfile.
49 (objfile): Don't call unlink_objfile.
50
51 2019-12-12 Tom Tromey <tom@tromey.com>
52
53 * progspace.h (struct program_space) <add_objfile>: Declare
54 method.
55 * progspace.c (program_space::add_objfile): New method.
56 * objfiles.c (~objfile): Don't unlink objfile.
57 (put_objfile_before): Remove.
58 (add_separate_debug_objfile): Don't call put_objfile_before.
59 (objfile::make): Call add_objfile. Set new_objfiles_available on
60 the per-program-space data.
61
62 2019-12-12 Tom Tromey <tom@tromey.com>
63
64 * symfile.c (syms_from_objfile_1): Use objfile_up.
65 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
66 method.
67 (reread_symbols): Use objfile_up.
68 * solib.c (update_solib_list, reload_shared_libraries_1): Call
69 unlink method.
70 * objfiles.h (struct objfile) <~objfile>: Now private.
71 <unlink>: New method.
72 (struct objfile_deleter): New.
73 (objfile_up): New typedef.
74 * objfiles.c (objfile::unlink): New method.
75 (free_objfile_separate_debug, free_all_objfiles)
76 (objfile_purge_solibs): Use it.
77 * jit.c (jit_unregister_code): Remove.
78 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
79 objfile.
80 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
81 objfile.
82 * compile/compile-object-load.c (compile_object_load): Use
83 objfile_up.
84
85 2019-12-12 Tom Tromey <tom@tromey.com>
86
87 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
88 objfile::make.
89 * objfiles.h (struct objjfile) <make>: No longer inline.
90 (add_separate_debug_objfile): Don't declare.
91 * objfiles.c (add_separate_debug_objfile): Now static.
92 (objfile::make): Move from objfiles.h. Call
93 add_separate_debug_objfile. Add "parent" parameter.
94
95 2019-12-12 Tom Tromey <tom@tromey.com>
96
97 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
98 * objfiles.h (struct objfile): Make constructor private.
99 <make>: New static method.
100 * jit.c (jit_object_close_impl): Update.
101
102 2019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
103
104 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
105 gdb::byte_vector.
106
107 2019-12-12 Tom Tromey <tromey@adacore.com>
108
109 * xml-support.c (xml_fetch_content_from_file): Don't call
110 malloc_failure.
111 * utils.h (class gdb_argv): Remove malloc_failure comment.
112 * utils.c (gdb_argv::reset): Don't call malloc_failure.
113
114 2019-12-12 Tom Tromey <tromey@adacore.com>
115
116 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
117 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
118 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
119 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
120 * riscv-ravenscar-thread.c: New file.
121 * riscv-ravenscar-thread.h: New file.
122 * riscv-tdep.c (riscv_gdbarch_init): Call
123 register_riscv_ravenscar_ops.
124
125 2019-12-12 Tom Tromey <tromey@adacore.com>
126
127 * gdbsupport/thread-pool.c (set_thread_name): Use
128 ATTRIBUTE_UNUSED.
129
130 2019-12-12 Luis Machado <luis.machado@linaro.org>
131
132 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
133 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
134 macros.
135
136 2019-12-11 Tom Tromey <tom@tromey.com>
137
138 * tui/tui-win.c (tui_set_win_height_command): Call
139 tui_adjust_window_height.
140 (tui_adjust_win_heights, new_height_ok): Remove.
141 * tui/tui-layout.h (tui_adjust_window_height): Declare.
142 * tui/tui-layout.c (tui_adjust_window_height): New function.
143
144 2019-12-11 Tom Tromey <tom@tromey.com>
145
146 * tui/tui-win.c (tui_resize_all): Remove code, call
147 tui_apply_current_layout.
148
149 2019-12-11 Tom Tromey <tom@tromey.com>
150
151 * tui/tui-layout.h (tui_apply_current_layout): Declare.
152 * tui/tui-layout.c (standard_layouts, applied_layout): New
153 globals.
154 (tui_apply_current_layout): New function.
155 (show_layout): Set applied_layout. Call
156 tui_apply_current_layout.
157 (show_source_command, show_disasm_command)
158 (show_source_disasm_command, show_data)
159 (show_source_or_disasm_and_command): Remove.
160 (initialize_layouts): New function.
161 (_initialize_tui_layout): Call initialize_layouts.
162
163 2019-12-11 Tom Tromey <tom@tromey.com>
164
165 * tui/tui-layout.h (class tui_layout_base)
166 (class tui_layout_window, class tui_layout_split): New.
167 * tui/tui-layout.c (tui_get_window_by_name)
168 (tui_layout_window::clone, tui_layout_window::apply)
169 (tui_layout_window::get_sizes, tui_layout_window::add_split)
170 (tui_layout_split::add_window, tui_layout_split::clone)
171 (tui_layout_split::get_sizes)
172 (tui_layout_split::set_weights_from_heights)
173 (tui_layout_split::adjust_size, tui_layout_split::apply): New
174 functions.
175 (tui_layout_split::add_split, tui_layout_split::add_split)
176 (tui_layout_split::set_weights_from_heights)
177 (tui_layout_split::set_weights_from_heights): New functions.
178
179 2019-12-11 Tom Tromey <tom@tromey.com>
180
181 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
182 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
183 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
184 * tui/tui-data.h (struct tui_point): Remove.
185 (struct tui_gen_win_info) <origin>: Remove.
186 <x, y>: New fields.
187 * tui/tui-command.c (tui_cmd_window::resize): Update.
188
189 2019-12-11 Tom Tromey <tom@tromey.com>
190
191 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
192 Implement.
193 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
194 Implement.
195 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
196 method.
197 (struct tui_win_info) <min_height>: Implement.
198
199 2019-12-11 Tom Tromey <tom@tromey.com>
200
201 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
202 (struct tui_win_info) <can_box>: Update.
203
204 2019-12-11 Tom Tromey <tom@tromey.com>
205
206 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
207 method.
208 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
209 method.
210 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
211 method.
212 (struct tui_win_info) <max_height>: Now override.
213
214 2019-12-11 Joel Brobecker <brobecker@adacore.com>
215
216 * NEWS: Create a new section for the next release branch.
217 Rename the section of the current branch, now that it has
218 been cut.
219
220 2019-12-11 Joel Brobecker <brobecker@adacore.com>
221
222 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
223 * version.in: Bump version to 10.0.50.DATE-git.
224
225 2019-12-11 Tom Tromey <tromey@adacore.com>
226
227 PR build/25268:
228 * gdbsupport/thread-pool.c (set_thread_name): New function.
229 (thread_pool::set_thread_count): Don't call pthread_setname_np.
230 (thread_pool::thread_function): Call set_thread_name.
231
232 2019-12-11 Tom Tromey <tromey@adacore.com>
233
234 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
235 bfd_get_signed_8.
236
237 2019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
238
239 * NEWS: Document -raw-values option and the related setting commands.
240 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
241 only set it on when /r is given.
242 * valprint.c (value_print_option_defs): New element raw-values.
243 * Makefile.in: Add the new file.
244
245 2019-12-10 Christian Biesinger <cbiesinger@google.com>
246
247 * gdbsupport/safe-strerror.c: Supress the unused function warning
248 for select_strerror_r.
249
250 2019-12-10 Christian Biesinger <cbiesinger@google.com>
251
252 * config.in: Regenerate.
253 * configure: Regenerate.
254 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
255 safe_strerror instead of strerror.
256 * gdbsupport/common.m4: Don't check for strerror.
257 * gdbsupport/safe-strerror.c: Support both the glibc version
258 of strerror_r and the XSI version.
259
260 2019-12-10 Tom Tromey <tromey@adacore.com>
261
262 * ada-typeprint.c (print_choices): Use a single "?".
263 (print_variant_part): Print "?" if the discriminant name
264 is not known.
265
266 2019-12-10 George Barrett <bob@bob131.so>
267
268 Fix scripted probe breakpoints.
269 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
270 declaration forward.
271 (breakpoint_ops_for_event_location_type)
272 (breakpoint_ops_for_event_location): Add function definitions.
273 (break_command_1, trace_command): Use
274 breakpoint_ops_for_event_location.
275 * breakpoint.h (breakpoint_ops_for_event_location): Add function
276 declarations.
277 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
278 breakpoint_ops_for_event_location.
279 * python/py-breakpoint.c (bppy_init): Use
280 breakpoint_ops_for_event_location.
281
282 2019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
283
284 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
285 when ranking an lvalue argument for an rvalue parameter.
286
287 2019-12-08 Wataru Ashihara <wataash@wataash.com>
288
289 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
290 template argument for scoped_restore_tmpl from bool to int.
291
292 2019-12-07 Keith Seitz <keiths@redhat.com>
293
294 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
295 (build_id_to_debug_bfd): Make static, rewriting to use
296 build_id_to_bfd_suffix.
297 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
298 adding `suffix' parameter. Append SUFFIX to file names
299 when searching for matching files.
300 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
301 (build_id_to_exec_bfd): Likewise.
302 * build-id.h (build_id_to_debug_bfd): Clarify that function
303 searches for BFD of debug info file.
304 (build_id_to_exec_bfd): Declare.
305 * corelow.c: Include build-id.h.
306 (locate_exec_from_corefile_build_id): New function.
307 (core_target_open): If no executable BFD is found,
308 search for a core file BFD using build-id.
309
310 2019-12-06 Christian Biesinger <cbiesinger@google.com>
311
312 * bcache.c: Put in namespace gdb.
313 * bcache.h: Likewise.
314 * gdbtypes.c (check_types_worklist): Update.
315 (types_deeply_equal): Update.
316 * macrotab.c (struct macro_table) <bcache>: Update.
317 (new_macro_table): Update.
318 * macrotab.h (struct bcache): Put this forward declaration
319 inside namespace gdb.
320 (new_macro_table): Update.
321 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
322 Update.
323 <macro_cache>: Update.
324 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
325
326 2019-12-06 Tom de Vries <tdevries@suse.de>
327
328 PR symtab/24971
329 * block.c (best_symbol, better_symbol): New function.
330 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
331 decl.
332
333 2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
334
335 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
336 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
337 for ranking see-through reference cases.
338
339 2019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
340 * stack.c (faas_command): Check a command is provided.
341 * thread.c (taas_command, tfaas_command): Likewise.
342
343 2019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
344 * inferior.c (prune_inferiors): Only call delete_inferior,
345 Do not modify the inferior list.
346
347 2019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
348
349 * c-exp.y: Update calls to lookup_typename,
350 lookup_signed_typename and lookup_unsigned_typename.
351 * c-lang.c (evaluate_subexp_c): Likewise.
352 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
353 Likewise.
354 * eval.c (binop_promote): Likewise.
355 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
356 (lookup_unsigned_typename): Likewise.
357 (lookup_signed_typename): Likewise.
358 * gdbtypes.h (lookup_unsigned_typename): Likewise.
359 (lookup_signed_typename): Likewise.
360 (lookup_typename): Likewise.
361 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
362 lookup_typename, lookup_signed_typename,
363 lookup_unsigned_typename.
364 * m2-exp.y: Likewise.
365 * printcmd.c (printf_wide_c_string): Likewise.
366 (ui_printf): Likewise.
367 * python/py-type.c (typy_lookup_typename): Likewise.
368 * python/py-xmethods.c (python_xmethod_worker::invoke):
369 Likewise.
370 * rust-exp.y: Likewise.
371
372 2019-12-04 Christian Biesinger <cbiesinger@google.com>
373
374 * configure.nat (obsd64): Add missing files x86-nat.o and
375 nat/x86-dregs.o.
376
377 2019-12-04 Tom Tromey <tom@tromey.com>
378
379 * valprint.c (val_print_string): Use metadata_style.
380 * go-valprint.c (print_go_string): Use metadata style.
381 * p-valprint.c (pascal_object_print_static_field): Use metadata
382 style.
383 * cp-valprint.c (cp_print_static_field): Use metadata style.
384
385 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
386 Chris January <chris.january@arm.com>
387
388 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
389 tokens.
390 (typebase): New patterns for complex, single/double precision, and
391 single/double complex.
392 (f77_keywords): Change token for complex keyword, and add single,
393 double, and precision keywords.
394
395 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
396
397 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
398 "info io_registers".
399
400 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
401
402 * regcache.c (cooked_read_test): Initialize thread list of
403 mock_inferior.
404
405 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
406
407 * aarch64-linux-tdep.c: Remove includes.
408
409 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
410
411 * aarch64-tdep.c: Remove includes.
412
413 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
414
415 * filtered-iterator.h (filtered_iterator) <operator==,
416 operator!=>: Compare wrapped iterators, not wrapped pointers.
417 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
418 unittests/filtered_iterator-selftests.c.
419 * unittests/filtered_iterator-selftests.c: New file.
420
421 2019-12-04 Tom Tromey <tromey@adacore.com>
422
423 * gdbtypes.c (create_range_type): Inherit endianity
424 from base type.
425
426 2019-12-04 Tom Tromey <tromey@adacore.com>
427
428 * ada-lang.c (decode_constrained_packed_array)
429 (ada_value_assign, value_assign_to_component): Update.
430 * dwarf2loc.c (rw_pieced_value, access_memory)
431 (dwarf2_compile_expr_to_ax): Update.
432 * dwarf2read.c (dwarf2_add_field): Update.
433 * eval.c (evaluate_subexp_standard): Update.
434 * gdbarch.c, gdbarch.h: Rebuild.
435 * gdbarch.sh (bits_big_endian): Remove.
436 * gdbtypes.h (union field_location): Update comment.
437 * target-descriptions.c (make_gdb_type): Update.
438 * valarith.c (value_bit_index): Update.
439 * value.c (struct value) <bitpos>: Update comment.
440 (unpack_bits_as_long, modify_field): Update.
441 * value.h (value_bitpos): Update comment.
442
443 2019-12-04 Tom Tromey <tromey@adacore.com>
444
445 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
446 endian-ness.
447
448 2019-12-04 Tom Tromey <tromey@adacore.com>
449
450 * dwarf2read.c (dwarf2_init_float_type)
451 (dwarf2_init_complex_target_type): Add byte_order parameter.
452 (read_base_type): Compute byte order earlier.
453 * gdbtypes.c (init_float_type): Add byte_order parameter.
454 * gdbtypes.h (init_float_type): Add byte_order parameter.
455
456 2019-12-04 Tom Tromey <tromey@adacore.com>
457
458 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
459
460 2019-12-04 Tom Tromey <tromey@adacore.com>
461
462 * dwarf2read.c (process_structure_scope): Initialize
463 "discr_offset".
464
465 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
466
467 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
468 add it into the search spec.
469 (parse_max_results_option): New function.
470 (mi_info_functions_or_variables): Parse -max-results flag and pass
471 it to mi_symbol_info.
472 (mi_cmd_symbol_info_modules): Likewise.
473 (mi_cmd_symbol_info_types): Likewise.
474 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
475 return type to bool, change result container into a set, and don't
476 add new results if we have enough already.
477 (global_symbol_searcher::add_matching_msymbols): Change return
478 type to bool, and don't add new results if we have enough already.
479 (sort_search_symbols_remove_dups): Delete.
480 (global_symbol_searcher::search): Early exit from search loop when
481 we have enough results. Use a std::set to collect the results
482 from calling add_matching_symbols.
483 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
484 member function.
485 (global_symbol_searcher) <m_max_search_results>: New member
486 variable.
487 (global_symbol_searcher) <add_matching_symbols>: Update header
488 comment and change return type to bool.
489 (global_symbol_searcher) <add_matching_msymbols>: Update header
490 comment and change return type to bool.
491
492 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
493
494 * symtab.c (symbol_search::compare_search_syms): Update header
495 comment.
496 (global_symbol_searcher::is_suitable_msymbol): New function.
497 (global_symbol_searcher::expand_symtabs): New function.
498 (global_symbol_searcher::add_matching_symbols): New function.
499 (global_symbol_searcher::add_matching_msymbols): New function.
500 (global_symbol_searcher::search): Move most of the content
501 into the new functions above, and call them as needed.
502 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
503 function.
504 (global_symbol_searcher) <add_matching_symbols>: New member
505 function.
506 (global_symbol_searcher) <add_matching_msymbols>: New member
507 function.
508 (global_symbol_searcher) <is_suitable_msymbol>: New member
509 function.
510
511 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
512
513 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
514 -symbol-info-module-variables entries.
515 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
516 (mi_cmd_symbol_info_module_variables): Declare.
517 * mi/mi-symbol-cmds.c
518 (module_symbol_search_iterator): New typedef.
519 (output_module_symbols_in_single_module_and_file): New function.
520 (output_module_symbols_in_single_module): New function.
521 (mi_info_module_functions_or_variables): New function.
522 (mi_cmd_symbol_info_module_functions): New function.
523 (mi_cmd_symbol_info_module_variables): New function.
524 * NEWS: Mention new MI command.
525
526 2019-12-03 Christian Biesinger <cbiesinger@google.com>
527
528 * bcache.c (hash): Remove.
529 (hash_continue): Remove.
530 * bcache.h (hash): Remove.
531 (hash_continue): Remove.
532 (struct bcache) <ctor>: Update.
533 * psymtab.c (psymbol_hash): Update.
534 * stabsread.c (hashname): Update.
535 * utils.h (fast_hash): Add an argument for a start value,
536 defaulting to zero.
537
538 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
539 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
540 (destroy_block_symbol_cache): New function.
541 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
542 (resize_symbol_cache): Likewise.
543
544 2019-12-02 Tom Tromey <tom@tromey.com>
545
546 * unittests/tui-selftests.c (run_tests): Make conditional.
547 (_initialize_tui_selftest): Make conditional.
548
549 2019-12-02 Christian Biesinger <cbiesinger@google.com>
550
551 * aix-thread.c (debug_aix_thread): Change type to bool.
552
553 2019-12-02 Luis Machado <luis.machado@linaro.org>
554
555 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
556
557 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
558
559 * dwarf2read.c (read_tag_string_type): Read the fields required to
560 make a dynamic string, and possibly create a dynamic range for the
561 string.
562 (attr_to_dynamic_prop): Setup is_reference based on the type of
563 attribute being processed.
564 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
565 (resolve_dynamic_array): Rename to...
566 (resolve_dynamic_array_or_string): ...this, update header comment,
567 and accept TYPE_CODE_STRING.
568 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
569
570 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
571
572 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
573 of its implementation from...
574 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
575 the new function.
576
577 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
578
579 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
580 create a range with stride where appropriate.
581 * f-valprint.c: Include 'gdbarch.h'.
582 (f77_print_array_1): Take the stride into account when walking the
583 array. Also convert the stride into addressable units.
584 * gdbtypes.c (create_range_type): Initialise the stride to
585 constant zero.
586 (create_range_type_with_stride): New function, initialise the
587 range as normal, and then setup the stride.
588 (has_static_range): Include the stride here. Also change the
589 return type to bool.
590 (create_array_type_with_stride): Consider the range stride if the
591 array isn't given its own stride.
592 (resolve_dynamic_range): Resolve the stride if needed.
593 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
594 (struct range_bounds) <flag_is_byte_stride>: New member variable.
595 (TYPE_BIT_STRIDE): Define.
596 (TYPE_ARRAY_BIT_STRIDE): Define.
597 (create_range_type_with_stride): Declare.
598 * valarith.c (value_subscripted_rvalue): Take range stride into
599 account when walking the array.
600
601 2019-12-01 Tom Tromey <tom@tromey.com>
602
603 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
604 specially.
605
606 2019-12-01 Tom Tromey <tom@tromey.com>
607
608 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
609 \0.
610 * unittests/tui-selftests.c: New file.
611 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
612
613 2019-12-01 Tom Tromey <tom@tromey.com>
614
615 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
616
617 2019-12-01 Tom Tromey <tom@tromey.com>
618
619 * NEWS: Document new settings.
620 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
621 * tui/tui-win.c (_initialize_tui_win): Add border style
622 observers.
623 * tui/tui-io.h (tui_apply_style): Declare.
624 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
625 longer static.
626 (apply_ansi_escape, tui_set_reverse_mode): Update.
627 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
628 Add "skip_intensity" parameter.
629 <changed>: New member.
630 <do_set_value>: Declare.
631 (tui_border_style, tui_active_border_style): Declare.
632 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
633 globals.
634 (cli_style_option): Initialize "changed".
635 (cli_style_option::do_set_value): New function.
636 (cli_style_option::add_setshow_commands): Add "skip_intensity"
637 parameter. Update.
638 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
639 (_initialize_cli_style): Update. Create TUI border style
640 commands.
641
642 2019-12-01 Tom Tromey <tom@tromey.com>
643
644 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
645 parameter.
646 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
647 parameter.
648 * tui/tui-win.h (compact_source): Declare.
649 * tui/tui-win.c (compact_source): New global.
650 (tui_set_compact_source, tui_show_compact_source): New functions.
651 (_initialize_tui_win): Add "compact-source" setting.
652 * tui/tui-source.c (tui_source_window::set_contents): Handle
653 compact_source setting.
654 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
655 * NEWS: Document new setting.
656
657 2019-11-30 Tom Tromey <tom@tromey.com>
658
659 * dwarf2read.c (dwarf2_add_field): Include field offset when
660 computing variant part length.
661
662 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
663 * NEWS: Mention define-prefix. Tell that command names can now
664 contain a . character.
665
666 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
667
668 * command.h (valid_cmd_char_p): Declare.
669 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
670 the check of valid command char.
671 (find_command_name_length, valid_user_defined_cmd_name_p): Use
672 valid_cmd_char_p.
673 * cli/cli-script.c (validate_comname): Likewise.
674 * completer.c (gdb_completer_command_word_break_characters):
675 Do not remove . from the word break char, update comments.
676 (complete_line_internal_1): Use valid_cmd_char_p.
677 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
678 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
679
680 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
681
682 * cli/cli-script.c (do_define_command): Ensure a redefined
683 prefix command is kept as a prefix command.
684 (define_prefix_command): New function.
685 (show_user_1): Report user defined prefixes.
686 (_initialize_cli_script): Create the new 'define-prefix' command.
687 Add completers for 'define' and 'document'.
688 * top.c (execute_command): If command is a user-defined prefix only
689 command, report the list of commands for this prefix command.
690
691 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
692
693 * valops.c (find_oload_champ): Improve debug output.
694
695 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
696
697 * valops.c (find_oload_champ): Print part of debug messages
698 before the badness vector is std::move'd.
699
700 2019-11-28 Tom Tromey <tom@tromey.com>
701
702 * value.c (creal_internal_fn): Fix comment.
703
704 2019-11-28 Tom Tromey <tom@tromey.com>
705
706 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
707 flag_bound_evaluated>: Now unsigned.
708
709 2019-11-28 Tom Tromey <tom@tromey.com>
710
711 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
712 declare.
713
714 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
715
716 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
717 debug output.
718 * jit.c (jit_unregister_code): Add debug print to match
719 `jit_register_code`.
720
721 2019-11-27 Christian Biesinger <cbiesinger@google.com>
722
723 * NEWS: Mention the new multithreaded symbol loading.
724
725 2019-11-27 Christian Biesinger <cbiesinger@google.com>
726
727 * maint.c (n_worker_threads): Default to 0.
728 (worker_threads_disabled): New function.
729 * maint.h (worker_threads_disabled): New function.
730 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
731 here if worker_threads_disabled () is true.
732 (minimal_symbol_reader::install): Skip all threading if
733 worker_threads_disabled () is true.
734
735 2019-11-27 Christian Biesinger <cbiesinger@google.com>
736
737 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
738 hash code if possible.
739 (add_minsym_to_demangled_hash_table): Likewise.
740 (minimal_symbol_reader::install): Compute the hash codes for msymbol
741 on the background thread.
742 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
743 Add these fields.
744
745 2019-11-27 Christian Biesinger <cbiesinger@google.com>
746
747 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
748 of the mangled name on the background thread.
749 * symtab.c (symbol_set_names): Allow passing in the hash of the
750 linkage_name.
751 * symtab.h (symbol_set_names): Likewise.
752
753 2019-11-27 Kevin Buettner <kevinb@redhat.com>
754
755 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
756 physnames are computed for inherited DIEs.
757
758 2019-11-27 Tom Tromey <tromey@adacore.com>
759
760 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
761 backslashes.
762 * cp-support.c: Remove unnecessary backslashes.
763
764 2019-11-27 Christian Biesinger <cbiesinger@google.com>
765
766 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
767 with sym->set_linkage_name.
768 * coffread.c (coff_read_enum_type): Likewise.
769 * mdebugread.c (parse_symbol): Likewise.
770 * stabsread.c (patch_block_stabs): Likewise.
771 (define_symbol): Likewise.
772 (read_enum_type): Likewise.
773 (common_block_end): Likewise.
774 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
775 function.
776 (SYMBOL_SET_LINKAGE_NAME): Remove.
777 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
778 with sym->set_linkage_name.
779
780 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
781
782 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
783 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
784 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
785 * NEWS: Mention new MI command.
786
787 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
788
789 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
790 '-symbol-info-types', and '-symbol-info-variables'.
791 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
792 (mi_cmd_symbol_info_types): Declare.
793 (mi_cmd_symbol_info_variables): Declare.
794 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
795 (output_debug_symbol): New function.
796 (output_nondebug_symbol): New function.
797 (mi_symbol_info): New function.
798 (mi_info_functions_or_variables): New function.
799 (mi_cmd_symbol_info_functions): New function.
800 (mi_cmd_symbol_info_types): New function.
801 (mi_cmd_symbol_info_variables): New function.
802 * NEWS: Mention new commands.
803
804 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
805
806 * symtab.c (symbol_to_info_string): New function, most content
807 moved from print_symbol_info, but updated to return a std::string.
808 (print_symbol_info): Update to use symbol_to_info_string and print
809 returned string.
810 * symtab.h (symbol_to_info_string): Declare new function.
811
812 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
813
814 * python/python.c (gdbpy_rbreak): Convert to using
815 global_symbol_searcher.
816 * symtab.c (file_matches): Convert return type to bool, change
817 file list to std::vector, update header comment.
818 (search_symbols): Rename to...
819 (global_symbol_searcher::search): ...this and update now its
820 a member function of global_symbol_searcher. Take account of the
821 changes to file_matches.
822 (symtab_symbol_info): Convert to using global_symbol_searcher.
823 (rbreak_command): Likewise.
824 (search_module_symbols): Likewise.
825 * symtab.h (enum symbol_search): Update comment.
826 (search_symbols): Remove declaration.
827 (class global_symbol_searcher): New class.
828
829 2019-11-26 Tom Tromey <tromey@adacore.com>
830
831 * cp-support.c (_initialize_cp_support): Conditionally initialize
832 gdb_demangle_attempt_core_dump.
833
834 2019-11-26 Tom Tromey <tom@tromey.com>
835
836 * python/py-function.c (fnpy_init): Update.
837 * value.h (add_internal_function): Adjust declaration.
838 * value.c (function_destroyer): Remove.
839 (do_add_internal_function): Don't set destroyer or copy name.
840 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
841 Set name_allocated.
842 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
843 (cmdpy_init): Set name_allocated.
844 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
845 member.
846 (~cmd_list_element): Free "name" if needed.
847
848 2019-11-26 Tom Tromey <tom@tromey.com>
849
850 * value.h (add_internal_function): Add new overload. Move
851 documentation from value.h.
852 * value.c (do_add_internal_function): New function.
853 (add_internal_function): Use it. Add new overload.
854 (function_destroyer): Don't free doc.
855 * python/py-function.c (fnpy_init): Update.
856
857 2019-11-26 Tom Tromey <tom@tromey.com>
858
859 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
860 (cmdpy_init): Set "doc_allocated".
861
862 2019-11-26 Tom Tromey <tom@tromey.com>
863
864 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
865 name of worker thread.
866 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
867 pthread_setname_np.
868 * configure, config.in: Rebuild.
869
870 2019-11-26 Tom Tromey <tom@tromey.com>
871
872 * python/python.c (class gdbpy_gil): New.
873 (struct gdbpy_event): Add constructor, destructor, operator().
874 (gdbpy_post_event): Use run_on_main_thread.
875 (gdbpy_initialize_events): Remove.
876 (do_start_initialization): Update.
877
878 2019-11-26 Tom Tromey <tom@tromey.com>
879
880 * NEWS: Add entry.
881 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
882 commands. Call update_thread_pool_size.
883 (update_thread_pool_size, maintenance_set_worker_threads): New
884 functions.
885 (n_worker_threads): New global.
886
887 2019-11-26 Christian Biesinger <cbiesinger@google.com>
888 Tom Tromey <tom@tromey.com>
889
890 * minsyms.c (minimal_symbol_reader::install): Use
891 parallel_for_each.
892 * gdbsupport/parallel-for.h: New file.
893 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
894
895 2019-11-26 Christian Biesinger <cbiesinger@google.com>
896 Tom Tromey <tom@tromey.com>
897
898 * gdbsupport/thread-pool.h: New file.
899 * gdbsupport/thread-pool.c: New file.
900 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
901 (HFILES_NO_SRCDIR): Add thread-pool.h.
902
903 2019-11-26 Tom Tromey <tom@tromey.com>
904
905 * event-top.h (thread_local_segv_handler): Declare.
906 * event-top.c (thread_local_segv_handler): New global.
907 (install_handle_sigsegv, handle_sigsegv): New functions.
908 (async_init_signals): Install SIGSEGV handler.
909 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
910 thread-local.
911 (report_failed_demangle): New function.
912 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
913 handler-setting code, instead use segv_handler. Run warning code
914 on main thread.
915
916 2019-11-26 Tom Tromey <tom@tromey.com>
917
918 * run-on-main-thread.c: New file.
919 * run-on-main-thread.h: New file.
920 * unittests/main-thread-selftests.c: New file.
921 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
922 main-thread-selftests.c.
923 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
924 (COMMON_SFILES): Add run-on-main-thread.c.
925
926 2019-11-26 Tom Tromey <tom@tromey.com>
927
928 * main.c (setup_alternate_signal_stack): Remove.
929 (captured_main_1): Use gdb::alternate_signal_stack.
930 * gdbsupport/alt-stack.h: New file.
931
932 2019-11-26 Tom Tromey <tom@tromey.com>
933
934 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
935 Remove comment.
936 (save_original_signals_state, restore_original_signals_state): Use
937 gdb_sigmask.
938 * linux-nat.c (block_child_signals, restore_child_signals_mask)
939 (_initialize_linux_nat): Use gdb_sigmask.
940 * guile/guile.c (_initialize_guile): Use block_signals.
941 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
942 * gdbsupport/gdb-sigmask.h: New file.
943 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
944 * cp-support.c (gdb_demangle): Use gdb_sigmask.
945 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
946 pthread_sigmask.
947 * configure, config.in: Rebuild.
948 * gdbsupport/block-signals.h: New file.
949
950 2019-11-26 Tom Tromey <tom@tromey.com>
951
952 * acinclude.m4: Include ax_pthread.m4.
953 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
954 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
955 (CLIBS): Use PTHREAD_LIBS.
956 (aclocal_m4_deps): Add ax_pthread.m4.
957 * config.in, configure: Rebuild.
958 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
959
960 2019-11-26 Tom Tromey <tom@tromey.com>
961
962 * symtab.h (struct minimal_symbol) <name_set>: New member.
963 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
964 Don't call symbol_set_names.
965 (minimal_symbol_reader::install): Call symbol_set_names.
966
967 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
968
969 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
970 restore_active_ext_lang, as GIL is needed for (indirectly)
971 called PyOS_InterruptOccurred.
972
973 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
974
975 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
976 definition.
977
978 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
979
980 * remote-sim.c (simulator_command): Make static, remove
981 declaration.
982
983 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
984
985 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
986 static.
987 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
988 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
989 (main): Likewise.
990 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
991 (main): Likewise.
992 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
993 (main): Likewise.
994 * unittests/basic_string_view/element_access/char/1.cc (test01):
995 Likewise.
996 (main): Likewise.
997 * unittests/basic_string_view/element_access/char/empty.cc (main):
998 Likewise.
999 * unittests/basic_string_view/element_access/char/front_back.cc
1000 (test01): Likewise.
1001 (main): Likewise.
1002 * unittests/basic_string_view/inserters/char/2.cc (test05):
1003 Likewise.
1004 (main): Likewise.
1005 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1006 (test01): Likewise.
1007 (main): Likewise.
1008 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1009 (test01): Likewise.
1010 (main): Likewise.
1011 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1012 Likewise.
1013 * unittests/basic_string_view/operations/compare/char/1.cc
1014 (test01): Likewise.
1015 (main): Likewise.
1016 * unittests/basic_string_view/operations/compare/char/13650.cc
1017 (test01): Likewise.
1018 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1019 Likewise.
1020 (main): Likewise.
1021 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1022 Likewise.
1023 (main): Likewise.
1024 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1025 Likewise.
1026 (main): Likewise.
1027 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1028 Likewise.
1029 (main): Likewise.
1030 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1031 Likewise.
1032 (main): Likewise.
1033 * unittests/basic_string_view/operations/find/char/4.cc (main):
1034 Likewise.
1035 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1036 Likewise.
1037 (main): Likewise.
1038 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1039 Likewise.
1040 (main): Likewise.
1041 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1042 Likewise.
1043 (main): Likewise.
1044 * unittests/basic_string_view/operations/substr/char/1.cc
1045 (test01): Likewise.
1046 (main): Likewise.
1047 * unittests/basic_string_view/operators/char/2.cc (main):
1048 Likewise.
1049 * unittests/optional/assignment/1.cc (test): Likewise.
1050 * unittests/optional/assignment/2.cc (test): Likewise.
1051 * unittests/optional/assignment/3.cc (test): Likewise.
1052 * unittests/optional/assignment/4.cc (test): Likewise.
1053 * unittests/optional/assignment/5.cc (test): Likewise.
1054 * unittests/optional/assignment/6.cc (test): Likewise.
1055 * unittests/optional/assignment/7.cc (test): Likewise.
1056 * unittests/optional/cons/copy.cc (test): Likewise.
1057 * unittests/optional/cons/default.cc (test): Likewise.
1058 * unittests/optional/cons/move.cc (test): Likewise.
1059 * unittests/optional/cons/value.cc (test): Likewise.
1060 * unittests/optional/in_place.cc (test): Likewise.
1061 * unittests/optional/observers/1.cc (test): Likewise.
1062 * unittests/optional/observers/2.cc (test): Likewise.
1063
1064 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1065
1066 * tui-win.h (tui_set_var_cmd): Remove.
1067 * tui-win.c (tui_set_var_cmd): Make static.
1068
1069 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1070
1071 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1072 rbreak_command_wrapper): Remove.
1073 * symtab.c (rbreak_command_wrapper): Remove.
1074
1075 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1076
1077 * inferior.h (info_terminal_command): Remove declaration.
1078 * inflow.c (info_terminal_command): Make static.
1079
1080 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1081
1082 * inferior.c (exit_inferior_silent): Remove.
1083
1084 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1085
1086 * dictionary.c (dict_empty, mdict_empty): Remove.
1087 * dictionary.c (mdict_empty): Remove.
1088
1089 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1090
1091 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1092 (arc_insn_get_memory_offset): Likewise.
1093 (arc_insn_dump): Likewise.
1094 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1095 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1096 * dictionary.c (dict_iterator_next): Likewise.
1097 (dict_iter_match_first): Likewise.
1098 (dict_iter_match_next): Likewise.
1099 * f-lang.c (evaluate_subexp_f): Likewise.
1100 * hppa-tdep.c (hppa_read_pc): Likewise.
1101 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1102 * parse.c (write_exp_elt_msym): Likewise.
1103 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1104 * remote.c (remote_packet_size): Likewise.
1105 (remote_notif_stop_parse): Likewise.
1106 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1107 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1108 * source.c (prepare_path_for_appending): Likewise.
1109 * sparc64-linux-tdep.c
1110 (sparc64_linux_handle_segmentation_fault); Likewise.
1111 * stack.c (frame_selection_by_function_completer): Likewise.
1112
1113 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1114
1115 * completer.c (set_gdb_completion_word_break_characters):
1116 Remove.
1117
1118 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1119
1120 * dwarf-index-write.c: Include dwarf-index-write.h.
1121 * mi/mi-interp.c: Include mi/mi-interp.h.
1122
1123 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1124
1125 * aarch32-tdep.c: Include aarch32-tdep.h.
1126 * aarch32-tdep.h: Forward-declare struct target_desc.
1127
1128 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1129
1130 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1131 strerror.
1132 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1133 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1134
1135 2019-11-25 Tom de Vries <tdevries@suse.de>
1136
1137 * contrib/words.sh: Add -c option.
1138
1139 2019-11-25 Christian Biesinger <cbiesinger@google.com>
1140
1141 * solib.c (solib_find_1): Change int to bool.
1142 (exec_file_find): Change int to bool.
1143 (solib_find): Change int to bool.
1144 (solib_read_symbols): Change int to bool.
1145 (solib_used): Change int to bool.
1146 (solib_add): Change int to bool.
1147 (info_sharedlibrary_command): Change int to bool.
1148 (solib_contains_address_p): Change int to bool.
1149 (solib_keep_data_in_core): Change int to bool.
1150 (in_solib_dynsym_resolve_code): Change int to bool.
1151 (reload_shared_libraries_1): Change int to bool.
1152 (gdb_sysroot_changed): Change int to bool.
1153 * solib.h (solib_read_symbols): Change int to bool.
1154 (solib_contains_address_p): Change int to bool.
1155 (solib_keep_data_in_core): Change int to bool.
1156 (in_solib_dynsym_resolve_code): Change int to bool.
1157 (libpthread_name_p): Change int to bool.
1158
1159 2019-11-25 Luis Machado <luis.machado@linaro.org>
1160
1161 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1162 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1163 (remote_packet_max_chars): New static global.
1164 (show_remote_packet_max_chars): New function.
1165 (remote_target::putpkt_binary): Adjust to use new
1166 remote_packet_max_chars option.
1167 (remote_target::getpkt_or_notif_sane_1): Likewise.
1168 (_initialize_remote): Register new remote-packet-max-chars option.
1169
1170 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
1171
1172 * m68k-linux-nat.c: Include gdbarch.h.
1173
1174 2019-11-24 Tom Tromey <tom@tromey.com>
1175
1176 * symfile.c (read_symbols): Update.
1177 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1178 bool.
1179 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1180 (psym_lookup_symbol, psym_find_last_source_symtab)
1181 (psym_forget_cached_source_info, psym_print_stats)
1182 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1183 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1184 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1185 (psym_find_compunit_symtab_by_address)
1186 (maintenance_print_psymbols, maintenance_info_psymtabs)
1187 (maintenance_check_psymtabs): Update.
1188 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1189 bool.
1190
1191 2019-11-22 Tom Tromey <tom@tromey.com>
1192
1193 * observable.h: Update comments.
1194
1195 2019-11-22 Tom Tromey <tromey@adacore.com>
1196
1197 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1198 (print_ada_task_info): Don't try to fetch thread id if task is not
1199 alive.
1200
1201 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1202
1203 * ada-exp.y: Update.
1204 * ada-lang.c (sort_choices): Update.
1205 (ada_print_symbol_signature): Update.
1206 (resolve_subexp): Update.
1207 (ada_parse_renaming): Update.
1208 (ada_read_renaming_var_value): Update.
1209 (lesseq_defined_than): Update.
1210 (remove_extra_symbols): Update.
1211 (remove_irrelevant_renamings): Update.
1212 (ada_add_block_symbols): Update.
1213 (ada_collect_symbol_completion_matches): Update.
1214 (ada_is_renaming_symbol): Update.
1215 (aggregate_assign_from_choices): Update.
1216 (ada_evaluate_subexp): Update.
1217 (ada_has_this_exception_support): Update.
1218 (ada_is_non_standard_exception_sym): Update.
1219 (ada_add_exceptions_from_frame): Update.
1220 (ada_add_global_exceptions): Update.
1221 (ada_print_subexp): Update.
1222 * ax-gdb.c (gen_var_ref): Update.
1223 (gen_maybe_namespace_elt): Update.
1224 (gen_expr_for_cast): Update.
1225 (gen_expr): Update.
1226 * block.h: Update.
1227 * blockframe.c (find_pc_partial_function): Update.
1228 * breakpoint.c (print_breakpoint_location): Update.
1229 (update_static_tracepoint): Update.
1230 * btrace.c (ftrace_print_function_name): Update.
1231 (ftrace_function_switched): Update.
1232 * buildsym.c (find_symbol_in_list): Update.
1233 * c-exp.y: Update.
1234 * c-typeprint.c (c_print_typedef): Update.
1235 (c_type_print_template_args): Update.
1236 * cli/cli-cmds.c (edit_command): Update.
1237 (list_command): Update.
1238 (print_sal_location): Update.
1239 * coffread.c (patch_opaque_types): Update.
1240 (process_coff_symbol): Update.
1241 (coff_read_enum_type): Update.
1242 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1243 (convert_one_symbol): Update.
1244 (hash_symname): Update.
1245 (eq_symname): Update.
1246 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1247 * compile/compile-cplus-types.c (debug_print_scope): Update.
1248 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1249 * compile/compile-object-load.c (get_out_value_type): Update.
1250 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1251 (search_symbol_list): Update.
1252 (cp_lookup_symbol_imports_or_template): Update.
1253 * cp-support.c (overload_list_add_symbol): Update.
1254 * ctfread.c (psymtab_to_symtab): Update.
1255 * dbxread.c (cp_set_block_scope): Update.
1256 * dictionary.c (iter_match_first_hashed): Update.
1257 (iter_match_next_hashed): Update.
1258 (insert_symbol_hashed): Update.
1259 (iter_match_next_linear): Update.
1260 * dictionary.h: Update.
1261 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1262 (locexpr_describe_location_piece): Update.
1263 (locexpr_describe_location_1): Update.
1264 (locexpr_generate_c_location): Update.
1265 (loclist_describe_location): Update.
1266 (loclist_generate_c_location): Update.
1267 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1268 (read_func_scope): Update.
1269 (process_enumeration_scope): Update.
1270 (new_symbol): Update.
1271 (dwarf2_const_value): Update.
1272 (dwarf2_symbol_mark_computed): Update.
1273 * eval.c (evaluate_funcall): Update.
1274 (evaluate_subexp_standard): Update.
1275 * expprint.c (print_subexp_standard): Update.
1276 (dump_subexp_body_standard): Update.
1277 * f-valprint.c (info_common_command_for_block): Update.
1278 * findvar.c (get_hosting_frame): Update.
1279 (default_read_var_value): Update.
1280 * go-lang.c (go_symbol_package_name): Update.
1281 * guile/scm-block.c (bkscm_print_block_smob): Update.
1282 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1283 (gdbscm_symbol_name): Update.
1284 (gdbscm_symbol_linkage_name): Update.
1285 (gdbscm_symbol_print_name): Update.
1286 * infcall.c (get_function_name): Update.
1287 * infcmd.c (jump_command): Update.
1288 (finish_command): Update.
1289 * infrun.c (insert_exception_resume_breakpoint): Update.
1290 * linespec.c (canonicalize_linespec): Update.
1291 (create_sals_line_offset): Update.
1292 (convert_linespec_to_sals): Update.
1293 (complete_label): Update.
1294 (find_label_symbols_in_block): Update.
1295 * m2-typeprint.c (m2_print_typedef): Update.
1296 * mdebugread.c (mdebug_reg_to_regnum): Update.
1297 (parse_symbol): Update.
1298 (mylookup_symbol): Update.
1299 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1300 (list_args_or_locals): Update.
1301 * objc-lang.c (compare_selectors): Update.
1302 (info_selectors_command): Update.
1303 (compare_classes): Update.
1304 (info_classes_command): Update.
1305 (find_imps): Update.
1306 * p-typeprint.c (pascal_print_typedef): Update.
1307 * printcmd.c (build_address_symbolic): Update.
1308 (info_address_command): Update.
1309 (print_variable_and_value): Update.
1310 * python/py-framefilter.c (extract_sym): Update.
1311 (py_print_single_arg): Update.
1312 * python/py-symbol.c (sympy_str): Update.
1313 (sympy_get_name): Update.
1314 (sympy_get_linkage_name): Update.
1315 * python/python.c (gdbpy_rbreak): Update.
1316 * record-btrace.c (btrace_get_bfun_name): Update.
1317 (btrace_call_history): Update.
1318 * rust-lang.c (rust_print_typedef): Update.
1319 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1320 * stabsread.c (stab_reg_to_regnum): Update.
1321 (define_symbol): Update.
1322 (read_enum_type): Update.
1323 (common_block_end): Update.
1324 (cleanup_undefined_types_1): Update.
1325 (scan_file_globals): Update.
1326 * stack.c (print_frame_arg): Update.
1327 (print_frame_args): Update.
1328 (find_frame_funname): Update.
1329 (info_frame_command_core): Update.
1330 (iterate_over_block_locals): Update.
1331 (print_block_frame_labels): Update.
1332 (do_print_variable_and_value): Update.
1333 (iterate_over_block_arg_vars): Update.
1334 (return_command): Update.
1335 * symmisc.c (dump_symtab_1): Update.
1336 (print_symbol): Update.
1337 * symtab.c (eq_symbol_entry): Update.
1338 (symbol_cache_dump): Update.
1339 (lookup_language_this): Update.
1340 (find_pc_sect_line): Update.
1341 (skip_prologue_sal): Update.
1342 (symbol_search::compare_search_syms): Update.
1343 (treg_matches_sym_type_name): Update.
1344 (search_symbols): Update.
1345 (print_symbol_info): Update.
1346 (rbreak_command): Update.
1347 (completion_list_add_symbol): Update.
1348 (find_gnu_ifunc): Update.
1349 (get_symbol_address): Update.
1350 (search_module_symbols): Update.
1351 (info_module_subcommand): Update.
1352 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1353 (SYMBOL_LINKAGE_NAME): Remove.
1354 (SYMBOL_DEMANGLED_NAME): Remove.
1355 (SYMBOL_PRINT_NAME): Remove.
1356 (SYMBOL_SEARCH_NAME): Remove.
1357 * tracepoint.c (set_traceframe_context): Update.
1358 (validate_actionline): Update.
1359 (collection_list::collect_symbol): Update.
1360 (encode_actions_1): Update.
1361 (info_scope_command): Update.
1362 (print_one_static_tracepoint_marker): Update.
1363 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1364 * valops.c (address_of_variable): Update.
1365 (find_overload_match): Update.
1366 (find_oload_champ): Update.
1367
1368 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1369
1370 * ada-lang.c (ada_lookup_simple_minsym): Update.
1371 (ada_collect_symbol_completion_matches): Update.
1372 * ada-tasks.c (read_atcb): Update.
1373 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1374 (amd64_windows_skip_trampoline_code): Update.
1375 * arm-tdep.c (skip_prologue_function): Update.
1376 (arm_skip_stack_protector): Update.
1377 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1378 (arm_wince_skip_main_prologue): Update.
1379 * ax-gdb.c (gen_expr): Update.
1380 * block.c (call_site_for_pc): Update.
1381 * blockframe.c (find_pc_partial_function): Update.
1382 * breakpoint.c (set_breakpoint_location_function): Update.
1383 * btrace.c (ftrace_print_function_name): Update.
1384 (ftrace_function_switched): Update.
1385 * c-valprint.c (print_unpacked_pointer): Update.
1386 * coffread.c (coff_symfile_read): Update.
1387 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1388 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1389 * dwarf-index-write.c (write_psymbols): Update.
1390 * dwarf2loc.c (call_site_to_target_addr): Update.
1391 (func_verify_no_selftailcall): Update.
1392 (tailcall_dump): Update.
1393 (call_site_find_chain_1): Update.
1394 (dwarf_expr_reg_to_entry_parameter): Update.
1395 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1396 * eval.c (evaluate_funcall): Update.
1397 (evaluate_subexp_standard): Update.
1398 (evaluate_subexp_for_sizeof): Update.
1399 * expprint.c (print_subexp_standard): Update.
1400 (dump_subexp_body_standard): Update.
1401 * frame.c (get_prev_frame_always_1): Update.
1402 * frv-tdep.c (frv_skip_main_prologue): Update.
1403 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1404 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1405 (gnuv3_get_typename_from_type_info): Update.
1406 (gnuv3_skip_trampoline): Update.
1407 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1408 * i386-tdep.c (i386_skip_main_prologue): Update.
1409 (i386_pe_skip_trampoline_code): Update.
1410 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1411 * infcall.c (get_function_name): Update.
1412 * linespec.c (minsym_found): Update.
1413 * linux-fork.c (info_checkpoints_command): Update.
1414 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1415 (m32c_m16c_pointer_to_address): Update.
1416 * maint.c (maintenance_translate_address): Update.
1417 * minsyms.c (add_minsym_to_hash_table): Update.
1418 (add_minsym_to_demangled_hash_table): Update.
1419 (lookup_minimal_symbol_mangled): Update.
1420 (lookup_minimal_symbol_demangled): Update.
1421 (lookup_minimal_symbol_linkage): Update.
1422 (lookup_minimal_symbol_text): Update.
1423 (lookup_minimal_symbol_by_pc_name): Update.
1424 (minimal_symbol_is_less_than): Update.
1425 (compact_minimal_symbols): Update.
1426 (build_minimal_symbol_hash_tables): Update.
1427 (find_solib_trampoline_target): Update.
1428 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1429 (mips_skip_pic_trampoline_code): Update.
1430 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1431 * objc-lang.c (info_selectors_command): Update.
1432 (info_classes_command): Update.
1433 (find_methods): Update.
1434 (find_imps): Update.
1435 * p-valprint.c (pascal_val_print): Update.
1436 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1437 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1438 * printcmd.c (build_address_symbolic): Update.
1439 (info_symbol_command): Update.
1440 * psymtab.c (psymbol_name_matches): Update.
1441 (match_partial_symbol): Update.
1442 (lookup_partial_symbol): Update.
1443 (print_partial_symbols): Update.
1444 (sort_pst_symbols): Update.
1445 (maintenance_check_psymtabs): Update.
1446 * python/py-framefilter.c (py_print_frame): Update.
1447 * python/python.c (gdbpy_rbreak): Update.
1448 * record-btrace.c (btrace_get_bfun_name): Update.
1449 (btrace_call_history): Update.
1450 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1451 (rs6000_skip_trampoline_code): Update.
1452 * sol-thread.c (info_cb): Update.
1453 * stabsread.c (scan_file_globals): Update.
1454 * stack.c (find_frame_funname): Update.
1455 (info_frame_command_core): Update.
1456 * symmisc.c (dump_msymbols): Update.
1457 * symtab.c (symbol_natural_name): Rename to..,
1458 (general_symbol_info::natural_name): ...this.
1459 (symbol_demangled_name): Rename to...
1460 (general_symbol_info::demangled_name): ...this.
1461 (symbol_search_name): Rename to...
1462 (general_symbol_info::search_name): ...this.
1463 (symbol_matches_search_name): Update.
1464 (find_pc_sect_line): Update.
1465 (skip_prologue_sal): Update.
1466 (search_symbols): Update.
1467 (print_msymbol_info): Update.
1468 (rbreak_command): Update.
1469 (completion_list_add_msymbol): Update.
1470 (completion_list_objc_symbol): Update.
1471 (get_msymbol_address): Update.
1472 * symtab.h (struct general_symbol_info): Add member functions
1473 natural_name (), linkage_name (), print_name (), demangled_name (),
1474 and search_name ().
1475 (SYMBOL_NATURAL_NAME): Update.
1476 (symbol_natural_name): Move to a member function on general_symbol_info.
1477 (SYMBOL_DEMANGLED_NAME): Update.
1478 (symbol_demangled_name): Move to a member function on
1479 general_symbol_info.
1480 (SYMBOL_SEARCH_NAME): Update.
1481 (symbol_search_name): Move to a member function on general_symbol_info.
1482 (MSYMBOL_NATURAL_NAME): Remove.
1483 (MSYMBOL_LINKAGE_NAME): Remove.
1484 (MSYMBOL_PRINT_NAME): Remove.
1485 (MSYMBOL_DEMANGLED_NAME): Remove.
1486 (MSYMBOL_SEARCH_NAME): Remove.
1487 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1488
1489 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1490
1491 * symtab.c (create_demangled_names_hash): Use per_bfd->
1492 minimal_symbol_count for computing the initial size, if greater
1493 than our default size.
1494
1495 2019-11-22 Tom de Vries <tdevries@suse.de>
1496
1497 * contrib/words.sh: Improve words extraction.
1498
1499 2019-11-22 Tom de Vries <tdevries@suse.de>
1500
1501 * contrib/words.sh: Combine sed invocations.
1502
1503 2019-11-21 Christian Biesinger <cbiesinger@google.com>
1504
1505 * Makefile.in: Update.
1506 * demangle.c: Rename to...
1507 * gdb-demangle.c: ..this.
1508 (is_cplus_marker): Change return type to bool.
1509 (_initialize_demangler): Rename to...
1510 (_initialize_gdb_demangle): ...this.
1511 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1512 * symtab.h (demangle): Remove declaration; instead include
1513 gdb-demangle.h.
1514
1515 2019-11-21 Tom Tromey <tromey@adacore.com>
1516
1517 * gdbsupport/format.c (format_pieces): Parse %I64d.
1518 * unittests/format_pieces-selftests.c (test_windows_formats): New
1519 function.
1520 (run_tests): Call it.
1521
1522 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1523
1524 Byte reverse display of variables with DW_END_big, DW_END_little
1525 (DW_AT_endianity) dwarf attributes if different than the native
1526 byte order.
1527 * ada-lang.c (ada_value_binop):
1528 Use type_byte_order instead of gdbarch_byte_order.
1529 * ada-valprint.c (printstr):
1530 (ada_val_print_string):
1531 * ada-lang.c (value_pointer):
1532 (ada_value_binop):
1533 Use type_byte_order instead of gdbarch_byte_order.
1534 * c-lang.c (c_get_string):
1535 Use type_byte_order instead of gdbarch_byte_order.
1536 * c-valprint.c (c_val_print_array):
1537 Use type_byte_order instead of gdbarch_byte_order.
1538 * cp-valprint.c (cp_print_class_member):
1539 Use type_byte_order instead of gdbarch_byte_order.
1540 * dwarf2loc.c (rw_pieced_value):
1541 Use type_byte_order instead of gdbarch_byte_order.
1542 * dwarf2read.c (read_base_type): Handle DW_END_big,
1543 DW_END_little
1544 * f-lang.c (f_get_encoding):
1545 Use type_byte_order instead of gdbarch_byte_order.
1546 * findvar.c (default_read_var_value):
1547 Use type_byte_order instead of gdbarch_byte_order.
1548 * gdbtypes.c (check_types_equal):
1549 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1550 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1551 and TYPE_ENDIANITY_LITTLE if set.
1552 (type_byte_order): new function.
1553 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1554 (struct main_type) <flag_endianity_not_default>:
1555 New field.
1556 (type_byte_order): New function.
1557 * infcmd.c (default_print_one_register_info):
1558 Use type_byte_order instead of gdbarch_byte_order.
1559 * p-lang.c (pascal_printstr):
1560 Use type_byte_order instead of gdbarch_byte_order.
1561 * p-valprint.c (pascal_val_print):
1562 Use type_byte_order instead of gdbarch_byte_order.
1563 * printcmd.c (print_scalar_formatted):
1564 Use type_byte_order instead of gdbarch_byte_order.
1565 * solib-darwin.c (darwin_current_sos):
1566 Use type_byte_order instead of gdbarch_byte_order.
1567 * solib-svr4.c (solib_svr4_r_ldsomap):
1568 Use type_byte_order instead of gdbarch_byte_order.
1569 * stap-probe.c (stap_modify_semaphore):
1570 Use type_byte_order instead of gdbarch_byte_order.
1571 * target-float.c (target_float_same_format_p):
1572 Use type_byte_order instead of gdbarch_byte_order.
1573 * valarith.c (scalar_binop):
1574 (value_bit_index):
1575 Use type_byte_order instead of gdbarch_byte_order.
1576 * valops.c (value_cast):
1577 Use type_byte_order instead of gdbarch_byte_order.
1578 * valprint.c (generic_emit_char):
1579 (generic_printstr):
1580 (val_print_string):
1581 Use type_byte_order instead of gdbarch_byte_order.
1582 * value.c (unpack_long):
1583 (unpack_bits_as_long):
1584 (unpack_value_bitfield):
1585 (modify_field):
1586 (pack_long):
1587 (pack_unsigned_long):
1588 Use type_byte_order instead of gdbarch_byte_order.
1589 * findvar.c (unsigned_pointer_to_address):
1590 (signed_pointer_to_address):
1591 (unsigned_address_to_pointer):
1592 (address_to_signed_pointer):
1593 (default_read_var_value):
1594 (default_value_from_register):
1595 Use type_byte_order instead of gdbarch_byte_order.
1596 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1597 Use type_byte_order instead of gdbarch_byte_order.
1598 * riscv-tdep.c (riscv_print_one_register_info):
1599 Use type_byte_order instead of gdbarch_byte_order.
1600
1601 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1602
1603 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1604 (current_ui_gdb_stdin_ptr): Likewise.
1605 (current_ui_gdb_stderr_ptr): Likewise.
1606 (current_ui_gdb_stdlog_ptr): Likewise.
1607 (current_ui_current_uiout_ptr): Likewise.
1608 (gen_ret_current_ui_field_ptr): Remove.
1609
1610 2019-11-21 Tom de Vries <tdevries@suse.de>
1611
1612 PR gdb/24956
1613 * cli/cli-script.c (execute_control_command): Only switch to
1614 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1615
1616 2019-11-19 Tom Tromey <tom@tromey.com>
1617
1618 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1619 Now static. Change type of "name".
1620 (tui_set_win_height_command): Don't copy "arg".
1621 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1622 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1623
1624 2019-11-19 Ali Tamur <tamur@google.com>
1625
1626 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1627 "if (attr != nullptr)".
1628 (dwarf2_find_base_address): Likewise.
1629 (dwarf2_build_include_psymtabs): Likewise.
1630 (read_cutu_die_from_dwo): Likewise.
1631 (read_func_scope): Likewise.
1632 (read_call_site_scope): Likewise.
1633 (dwarf2_get_pc_bounds): Likewise.
1634 (dwarf2_record_block_ranges): Likewise.
1635 (dwarf2_add_field): Likewise.
1636 (dwarf2_add_member_fn): Likewise.
1637 (read_structure_type): Likewise.
1638 (read_enumeration_type): Likewise.
1639 (read_array_type): Likewise.
1640 (read_array_order): Likewise.
1641 (read_set_type): Likewise.
1642 (read_common_block): Likewise.
1643 (read_tag_reference_type): Likewise.
1644 (read_tag_string_type): Likewise.
1645 (read_subroutine_type): Likewise.
1646 (read_base_type): Likewise.
1647 (read_subrange_type): Likewise.
1648 (new_symbol): Likewise.
1649 (prepare_one_comp_unit): Likewise.
1650
1651 2019-11-19 Tom Tromey <tromey@adacore.com>
1652
1653 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1654 result in error when DebugActiveProcess fails.
1655
1656 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1657 Pedro Alves <palves@redhat.com>
1658
1659 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1660 * target.c (target_stack::push): Call 'unpush' if there's a
1661 target on top of the stack.
1662
1663 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1664
1665 * python/py-block.c (blpy_dealloc): Call tp_free.
1666 (blpy_block_syms_dealloc): Likewise.
1667 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1668 * python/py-inferior.c (infpy_dealloc): Likewise.
1669 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1670 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1671 * python/py-symbol.c (sympy_dealloc): Likewise.
1672 * python/py-symtab.c (stpy_dealloc): Likewise.
1673 * python/py-type.c (typy_iterator_dealloc): Likewise.
1674
1675 2019-11-18 Christian Biesinger <cbiesinger@google.com>
1676
1677 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1678 constructor instead of using a class initializer.
1679
1680 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1681
1682 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1683 * configure: Regenerate.
1684 * configure.ac: Don't source common.host.
1685 * gdbsupport/common.host: Remove.
1686 * gdbsupport/mingw-strerror.c: Remove.
1687 * gdbsupport/posix-strerror.c: Rename to...
1688 * gdbsupport/safe-strerror.c: ...this.
1689
1690 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1691
1692 * maint.c (scoped_command_stats::print_time): Use localtime_r
1693 instead of localtime (provided through gnulib if necessary).
1694 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1695 of ctime.
1696
1697 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1698
1699 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1700 avoid compile errors.
1701
1702 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1703
1704 * config.in: Regenerate.
1705 * configure: Regenerate.
1706 * gdbsupport/common.m4: No longer check for strerror_r.
1707 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1708 POSIX version of strerror_r, now that gnulib provides it if
1709 necessary.
1710
1711 2019-11-14 Christian Biesinger <cbiesinger@google.com>
1712
1713 * README (`configure' options): Update.
1714
1715 2019-11-14 Tom Tromey <tromey@adacore.com>
1716
1717 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1718 expected type for the RHS if the LHS is a convenience variable.
1719
1720 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1721
1722 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1723 Provide explicit default and copy constructor.
1724
1725 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1726
1727 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1728 only call Py_INCREF (newbp) in the bppy_pending_object case.
1729
1730 2019-11-13 Tom Tromey <tromey@adacore.com>
1731
1732 PR build/25182:
1733 * psympriv.h (partial_symbol): Remove static assert.
1734 * symtab.h (general_symbol_info, symbol): Remove static assert.
1735
1736 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1737
1738 * gdbsupport/format.c (format_pieces::format_pieces): Support
1739 printf 'z' size modifier.
1740 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1741 * printcmd.c (ui_printf): Handle size_t_arg.
1742 * ui-out.c (ui_out::vmessage): Likewise.
1743 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1744 function.
1745 (run_tests): Call test_format_int_sizes.
1746
1747 2019-11-12 Christian Biesinger <cbiesinger@google.com>
1748
1749 * ada-exp.y (write_ambiguous_var): Update.
1750 * buildsym.c (add_symbol_to_list): Update.
1751 * dwarf2read.c (read_variable): Update.
1752 (new_symbol): Update.
1753 * jit.c (finalize_symtab): Update.
1754 * language.c (language_alloc_type_symbol): Update.
1755 * symtab.c (fixup_symbol_section): Update.
1756 (initialize_objfile_symbol_1): Move code to...
1757 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1758 (allocate_symbol): Update.
1759 (allocate_template_symbol): Update.
1760 (get_symbol_address): Update.
1761 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1762 of having as a field, and add a constructor.
1763 (SYMBOL_VALUE): Update.
1764 (SYMBOL_VALUE_ADDRESS): Update.
1765 (SET_SYMBOL_VALUE_ADDRESS): Update.
1766 (SYMBOL_VALUE_BYTES): Update.
1767 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1768 (SYMBOL_BLOCK_VALUE): Update.
1769 (SYMBOL_VALUE_CHAIN): Update.
1770 (SYMBOL_LANGUAGE): Update.
1771 (SYMBOL_SECTION): Update.
1772 (SYMBOL_OBJ_SECTION): Update.
1773 (SYMBOL_SET_LANGUAGE): Update.
1774 (SYMBOL_SET_LINKAGE_NAME): Update.
1775 (SYMBOL_SET_NAMES): Update.
1776 (SYMBOL_NATURAL_NAME): Update.
1777 (SYMBOL_LINKAGE_NAME): Update.
1778 (SYMBOL_DEMANGLED_NAME): Update.
1779 (SYMBOL_SEARCH_NAME): Update.
1780 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1781 (struct symbol): Update.
1782 (struct template_symbol): Update.
1783 (struct rust_vtable_symbol): Update.
1784 * xcoffread.c (SYMBOL_DUP): Update.
1785
1786 2019-11-12 Tom Tromey <tom@tromey.com>
1787
1788 * tui/tui-layout.c (show_layout): Set current_layout.
1789 (show_source_disasm_command, show_data)
1790 (show_source_or_disasm_and_command): Don't set current_layout.
1791
1792 2019-11-12 Tom Tromey <tom@tromey.com>
1793
1794 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1795
1796 2019-11-12 Tom Tromey <tom@tromey.com>
1797
1798 * tui/tui-win.c (resize_message): New global.
1799 (show_tui_resize_message): New function.
1800 (tui_async_resize_screen): Print message if requested.
1801 (_initialize_tui_win): Add tui-resize-message setting.
1802 * NEWS: Add entry for new commands.
1803
1804 2019-11-11 Tom Tromey <tom@tromey.com>
1805
1806 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1807 functions.
1808
1809 2019-11-11 Christian Biesinger <cbiesinger@google.com>
1810
1811 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1812
1813 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1814
1815 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1816 function.
1817 * python/python-internal.h (gdbpy_lookup_static_symbols):
1818 Declare new function.
1819 * python/python.c (python_GdbMethods): Add
1820 gdb.lookup_static_symbols method.
1821 * NEWS: Mention gdb.lookup_static_symbols.
1822
1823 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1824
1825 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1826 static block of current object file first. Also fix typo in
1827 header comment.
1828
1829 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1830
1831 * stack.c (set_last_displayed_sal): Delete.
1832 (last_displayed_sal_valid): Delete.
1833 (last_displayed_pspace): Delete.
1834 (last_displayed_addr): Delete.
1835 (last_displayed_symtab): Delete.
1836 (last_displayed_line): Delete.
1837 (class last_displayed_symtab_info_type): New.
1838 (last_displayed_symtab_info): New static global variable.
1839 (print_frame_info): Call methods on last_displayed_symtab_info.
1840 (clear_last_displayed_sal): Update header comment, and make use of
1841 last_displayed_symtab_info.
1842 (last_displayed_sal_is_valid): Likewise.
1843 (get_last_displayed_pspace): Likewise.
1844 (get_last_displayed_addr): Likewise.
1845 (get_last_displayed_symtab): Likewise.
1846 (get_last_displayed_line): Likewise.
1847 (get_last_displayed_sal): Likewise.
1848 * stack.h (clear_last_displayed_sal): Update header comment.
1849 (last_displayed_sal_is_valid): Likewise.
1850 (get_last_displayed_pspace): Likewise.
1851 (get_last_displayed_addr): Likewise.
1852 (get_last_displayed_symtab): Likewise.
1853 (get_last_displayed_line): Likewise.
1854 (get_last_displayed_sal): Likewise.
1855
1856 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1857
1858 * stack.c (frame_show_address): Convert return type to bool.
1859 * stack.h (frame_show_address): Likewise, and update header
1860 comment.
1861
1862 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1863
1864 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1865 * unittests/vec-utils-selftests.c: New file.
1866 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1867
1868 2019-11-10 Tom Tromey <tom@tromey.com>
1869
1870 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1871 (tui_highlight_win): Likewise.
1872 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1873 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1874 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1875 Don't set can_highlight.
1876
1877 2019-11-10 Tom Tromey <tom@tromey.com>
1878
1879 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1880 Remove unused declaration.
1881
1882 2019-11-08 Tom Tromey <tromey@adacore.com>
1883
1884 * top.c (read_command_file): Update.
1885 (command_line_input): Make return type const.
1886 * python/py-gdb-readline.c: Update.
1887 * linespec.c (decode_line_2): Update.
1888 * defs.h (command_line_input): Make return type const.
1889 * cli/cli-script.c (read_next_line): Make return type const.
1890 * ada-lang.c (get_selections): Update.
1891
1892 2019-11-06 Christian Biesinger <cbiesinger@google.com>
1893
1894 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1895 * mi/mi-main.c (output_cores): Likewise.
1896 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1897 (linux_xfer_osdata_modules): Likewise.
1898 * remote.c (register_remote_support_xml): Likewise.
1899 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1900 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1901
1902 2019-11-06 Tom Tromey <tom@tromey.com>
1903
1904 * tui/tui-interp.c: Don't include readline.h.
1905 * tui/tui-hooks.c: Don't include readline.h.
1906 * symmisc.c: Include tilde.h, not readline.h.
1907 * symfile.c: Include tilde.h, not readline.h.
1908 * source.c: Include tilde.h, not readline.h.
1909 * solib.c: Include tilde.h, not readline.h.
1910 * psymtab.c: Include tilde.h, not readline.h.
1911 * exec.c: Include tilde.h, not readline.h.
1912 * corelow.c: Include tilde.h, not readline.h.
1913 * cli/cli-dump.c: Include tilde.h, not readline.h.
1914 * cli/cli-cmds.c: Don't include readline.h.
1915
1916 2019-11-05 Tom Tromey <tom@tromey.com>
1917
1918 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1919 (tui_disassemble): Set addr_size.
1920 (tui_disasm_window::set_contents): Use addr_size.
1921
1922 2019-11-05 Tom Tromey <tom@tromey.com>
1923
1924 * rust-lang.c (rust_language_defn): Update.
1925 * python/py-value.c (valpy_string): Call c_get_string.
1926 * p-lang.c (pascal_language_defn): Update.
1927 * opencl-lang.c (opencl_language_defn): Update.
1928 * objc-lang.c (objc_language_defn): Update.
1929 * m2-lang.c (m2_language_defn): Update.
1930 * language.c (unknown_language_defn, auto_language_defn): Update.
1931 (default_get_string): Remove.
1932 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1933 * go-lang.c (go_language_defn): Update.
1934 * f-lang.c (f_language_defn): Update.
1935 * d-lang.c (d_language_defn): Update.
1936 * c-lang.c (c_language_defn, cplus_language_defn)
1937 (asm_language_defn, minimal_language_defn): Update.
1938 * ada-lang.c (ada_language_defn): Update.
1939 * language.h (struct language_defn) <la_get_string>: Remove.
1940 (LA_GET_STRING): Remove.
1941 (default_get_string): Don't declare.
1942
1943 2019-11-05 Tom Tromey <tom@tromey.com>
1944
1945 * tui/tui-source.h (struct tui_source_window): Inline
1946 constructor. Remove destructor.
1947 <style_changed, m_observable>: Move to superclass.
1948 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1949 (struct tui_source_window_base): Move private members to end.
1950 <style_changed, m_observable>: Move from tui_source_window.
1951 * tui/tui-winsource.c (tui_copy_source_line): Move from
1952 tui-source.c. Rename from copy_source_line. Add special handling
1953 for negative line number.
1954 (tui_source_window_base::style_changed): Move from
1955 tui_source_window.
1956 (tui_source_window_base): Register observer.
1957 (~tui_source_window_base): New.
1958 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1959 rename.
1960 (tui_source_window::set_contents): Use tui_copy_source_line.
1961 (tui_source_window::tui_source_window): Move to tui-source.h.
1962 (tui_source_window::~tui_source_window): Remove.
1963 (tui_source_window::style_changed): Move to superclass.
1964 * tui/tui-disasm.c (tui_disassemble): Create string file with
1965 styling, when possible. Add "addr_size" parameter.
1966 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1967 Don't compute maximum size.
1968 (len_without_escapes): New function
1969
1970 2019-11-05 Tom Tromey <tom@tromey.com>
1971
1972 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1973 std::string.
1974 * tui/tui-winsource.c (tui_show_source_line): Update.
1975 * tui/tui-source.c (tui_source_window::set_contents): Update.
1976 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1977
1978 2019-11-05 Christian Biesinger <cbiesinger@google.com>
1979
1980 * symtab.h (gdb_static_assert): Put && operator at the beginning
1981 of the line instead of the end.
1982
1983 2019-11-04 Christian Biesinger <cbiesinger@google.com>
1984
1985 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1986 and sizeof (symbol).
1987 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1988
1989 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1990
1991 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1992 * configure.host: Mark *-*-solaris2.10* obsolete.
1993 * configure.tgt: Mark Solaris < 11 obsolete.
1994 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1995 Update target triplet.
1996
1997 2019-11-01 Tom Tromey <tromey@adacore.com>
1998
1999 * utils.c (print_sys_errmsg): Simplify.
2000
2001 2019-11-01 Tom Tromey <tromey@adacore.com>
2002
2003 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2004
2005 2019-11-01 Christian Biesinger <cbiesinger@google.com>
2006
2007 * configure: Regenerate.
2008 * configure.ac: Remove check for strerror_r.
2009 * gdbsupport/common.m4: Check for strerror_r.
2010
2011 2019-11-01 Luis Machado <luis.machado@linaro.org>
2012
2013 PR gdb/25124
2014
2015 * arm-tdep.c (arm_per_objfile): Rename to ...
2016 (arm_per_bfd): ... this.
2017 (arm_objfile_data_key): Rename to ...
2018 (arm_bfd_data_key): ... this.
2019 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2020 data.
2021 (arm_record_special_symbol): Likewise.
2022
2023 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2024
2025 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2026 end.
2027 * c-typeprint.c (c_print_typedef): Likewise.
2028 * f-typeprint.c (f_print_typedef): Likewise.
2029 * m2-typeprint.c (m2_print_typedef): Likewise.
2030 * p-typeprint.c (pascal_print_typedef): Likewise.
2031 * rust-lang.c (rust_print_typedef): Likewise.
2032 * symtab.c (print_symbol_info): Print a newline after calling
2033 typedef_print.
2034
2035 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2036
2037 * symtab.c (info_module_cmdlist): New variable.
2038 (info_module_command): New function.
2039 (search_module_symbols): New function.
2040 (info_module_subcommand): New function.
2041 (struct info_modules_var_func_options): New struct.
2042 (info_modules_var_func_options_defs): New variable.
2043 (make_info_modules_var_func_options_def_group): New function.
2044 (info_module_functions_command): New function.
2045 (info_module_variables_command): New function.
2046 (info_module_var_func_command_completer): New function.
2047 (_initialize_symtab): Register new 'info module functions' and
2048 'info module variables' commands.
2049 * symtab.h (typedef symbol_search_in_module): New typedef.
2050 (search_module_symbols): Declare new function.
2051 * NEWS: Mention new commands.
2052
2053 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2054
2055 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2056 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2057 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2058 MODULES_DOMAIN.
2059 (scan_partial_symbols): Only create partial module symbols for non
2060 declarations.
2061 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2062 and MODULES_DOMAIN.
2063 * symtab.c (search_domain_name): Likewise.
2064 (search_symbols): Likewise.
2065 (print_symbol_info): Likewise.
2066 (symtab_symbol_info): Likewise.
2067 (info_modules_command): New function.
2068 (_initialize_symtab): Register 'info modules' command.
2069 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2070 * NEWS: Mention new 'info modules' command.
2071
2072 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2073
2074 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2075 and $_gdb_maint_setting_str.
2076
2077 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2078
2079 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2080 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2081 (str_value_from_setting, gdb_setting_str_internal_fn)
2082 (gdb_maint_setting_str_internal_fn): New functions.
2083 (_initialize_cli_cmds): Define the new convenience functions.
2084 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2085 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2086
2087 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2088
2089 * agent.c (set_can_use_agent): When the setting is turned on,
2090 look up agent symbols if we don't have them yet.
2091 (agent_new_objfile): Don't look up agent symbols when the agent
2092 setting is off.
2093
2094 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2095
2096 * config.in: Regenerate.
2097
2098 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2099
2100 * configure: Regenerate.
2101 * configure.ac: Check for strerror_r.
2102 * gdbsupport/common-utils.h (safe_strerror): Change return value
2103 to const char * and document that this function is now threadsafe.
2104 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2105 thread_local and call strerror_r, if available.
2106 * utils.c (perror_string): Update.
2107 (print_sys_errmsg): Update.
2108
2109 2019-10-31 Luis Machado <luis.machado@linaro.org>
2110
2111 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2112 objfile_key.
2113 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2114 objfile to fetch per-bfd data.
2115 (arm_find_exidx_entry): Likewise.
2116
2117 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2118
2119 * gdbsupport/agent.c (debug_agent): Change type to bool.
2120 (use_agent): Likewise.
2121 (all_agent_symbols_look_up): Likewise.
2122 (agent_loaded_p): Change return value to bool.
2123 (agent_look_up_symbols): Update.
2124 (agent_capability_check): Change return value to bool.
2125 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2126 (debug_agent): Change type to bool.
2127 (use_agent): Likewise.
2128 (agent_capability_check): Change return value to bool.
2129
2130 2019-10-30 Christian Biesinger <cbiesinger@google.com>
2131
2132 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2133 (build_minimal_symbol_hash_tables): Code to clear the table moved
2134 to clear_minimal_symbol_hash_tables.
2135 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2136 when needed.
2137
2138 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2139
2140 * infcmd.c: Remove includes.
2141 * infrun.c: Remove includes.
2142
2143 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2144
2145 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2146 (grow_vect): Remove declaration.
2147 (ada_type_of_array): Remove declaration.
2148 (ada_update_initial_language): Remove declaration.
2149 (ada_fold_name): Remove declaration.
2150 (ada_fill_in_ada_prototype): Remove declaration.
2151 (user_select_syms): Remove declaration.
2152 (get_selections): Remove declaration.
2153 (ada_tag_type): Remove declaration.
2154 (ada_value_tag): Remove declaration.
2155 (ada_is_others_clause): Remove declaration.
2156 (ada_in_variant): Remove declaration.
2157 (ada_value_struct_elt): Remove declaration.
2158 (ada_attribute_name): Remove declaration.
2159 (ada_system_address_type): Remove declaration.
2160 * ada-lang.c (ada_watch_location_expression): Make static.
2161 (GROW_VECT): Move here from ada-lang.h.
2162 (grow_vect): Make static.
2163 (ada_update_initial_language): Make static.
2164 (ada_fold_name): Make static.
2165 (ada_type_of_array): Make static.
2166 (encoded_ordered_before): Move up.
2167 (sort_choices): Move up.
2168 (print_signatures): Move up.
2169 (ada_print_symbol_signature): Move up.
2170 (get_selections): Move up and make static.
2171 (user_select_syms): Move up and make static.
2172 (ada_value_struct_elt): Move up and make static.
2173 (ada_tag_type): Make static.
2174 (ada_value_tag): Make static.
2175 (ada_is_others_clause): Make static.
2176 (ada_in_variant): Make static.
2177 (ada_attribute_name): Make static.
2178
2179 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2180
2181 * ada-lang.c: Remove includes.
2182 * ada-typeprint.c: Remove includes.
2183 * ada-valprint.c: Remove includes.
2184
2185 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
2186
2187 * addrmap.c: Add static assertions of type size, moved from
2188 _initialize_addrmap.
2189 (_initialize_addrmap): Remove.
2190
2191 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2192
2193 * coffread.c (record_minimal_symbol): Update.
2194 (process_coff_symbol): Update.
2195 * dbxread.c (read_dbx_symtab): Update.
2196 * dwarf2read.c (add_partial_symbol): Update.
2197 (fixup_go_packaging): Update.
2198 (load_partial_dies): Update.
2199 (new_symbol): Update.
2200 * elfread.c (record_minimal_symbol): Change signature to use
2201 gdb::string_view instead of name+len.
2202 (elf_symtab_read): Update.
2203 (elf_rel_plt_read): Update.
2204 * mdebugread.c (parse_partial_symbols): Update.
2205 (handle_psymbol_enumerators): Update.
2206 (new_symbol): Update.
2207 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2208 to use gdb::string_view instead of name+len.
2209 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2210 * psympriv.h (add_psymbol_to_list): Likewise.
2211 * psymtab.c (add_psymbol_to_bcache): Likewise.
2212 (add_psymbol_to_list): Likewise.
2213 * stabsread.c (define_symbol): Update.
2214 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2215 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2216 (symbol_set_names): Likewise.
2217 * xcoffread.c (scan_xcoff_symtab): Update.
2218
2219 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2220
2221 * symtab.h (symbol_set_names): Document that copy_name must be
2222 set to true for non-nullterminated strings.
2223 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2224 linkage_name if the entry was not found and we need to demangle.
2225
2226 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2227
2228 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2229 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2230 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2231 * gdbsupport/gdb_binary_search.h: New file.
2232
2233 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2234
2235 * NEWS: Mention new --with-system-gdbinit-dir option.
2236 * config.in: Regenerate.
2237 * configure: Regenerate.
2238 * configure.ac: Add new option --with-system-gdbinit-dir.
2239 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2240 for a ".gdb" suffix.
2241 * main.c (get_init_files): Change system_gdbinit argument to
2242 a vector and return the files in SYSTEM_GDBINIT_DIR in
2243 addition to SYSTEM_GDBINIT.
2244 (captured_main_1): Update.
2245 (print_gdb_help): Update.
2246 * top.c (print_gdb_configuration): Also print the value of
2247 SYSTEM_GDBINIT_DIR.
2248
2249 2019-10-28 Christian Biesinger <cbiesinger@google.com>
2250
2251 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2252 that takes gdb::string_view arguments.
2253
2254 2019-10-26 Tom de Vries <tdevries@suse.de>
2255
2256 * aarch64-linux-tdep.c: Fix typos in comments.
2257 * aarch64-tdep.c: Same.
2258 * ada-lang.c: Same.
2259 * amd64-nat.c: Same.
2260 * arc-tdep.c: Same.
2261 * arch/aarch64-insn.c: Same.
2262 * block.c: Same.
2263 * breakpoint.h: Same.
2264 * btrace.h: Same.
2265 * c-varobj.c: Same.
2266 * cli/cli-decode.c: Same.
2267 * cli/cli-script.c: Same.
2268 * cli/cli-utils.h: Same.
2269 * coff-pe-read.c: Same.
2270 * coffread.c: Same.
2271 * compile/compile-cplus-symbols.c: Same.
2272 * compile/compile-object-run.c: Same.
2273 * completer.c: Same.
2274 * corelow.c: Same.
2275 * cp-support.c: Same.
2276 * demangle.c: Same.
2277 * dwarf-index-write.c: Same.
2278 * dwarf2-frame.c: Same.
2279 * dwarf2-frame.h: Same.
2280 * eval.c: Same.
2281 * frame-base.h: Same.
2282 * frame.h: Same.
2283 * gdbcmd.h: Same.
2284 * gdbtypes.h: Same.
2285 * gnu-nat.c: Same.
2286 * guile/scm-objfile.c: Same.
2287 * i386-tdep.c: Same.
2288 * i386-tdep.h: Same.
2289 * infcall.c: Same.
2290 * infcall.h: Same.
2291 * linux-nat.c: Same.
2292 * m68k-tdep.c: Same.
2293 * macroexp.c: Same.
2294 * memattr.c: Same.
2295 * mi/mi-cmd-disas.c: Same.
2296 * mi/mi-getopt.h: Same.
2297 * mi/mi-main.c: Same.
2298 * minsyms.c: Same.
2299 * nat/aarch64-sve-linux-sigcontext.h: Same.
2300 * objfiles.h: Same.
2301 * ppc-linux-nat.c: Same.
2302 * ppc-linux-tdep.c: Same.
2303 * ppc-tdep.h: Same.
2304 * progspace.h: Same.
2305 * prologue-value.h: Same.
2306 * python/py-evtregistry.c: Same.
2307 * python/py-instruction.h: Same.
2308 * record-btrace.c: Same.
2309 * record-full.c: Same.
2310 * remote.c: Same.
2311 * rs6000-tdep.c: Same.
2312 * ser-tcp.c: Same.
2313 * sol-thread.c: Same.
2314 * sparc-sol2-tdep.c: Same.
2315 * sparc64-tdep.c: Same.
2316 * stabsread.c: Same.
2317 * symfile.c: Same.
2318 * symtab.h: Same.
2319 * target.c: Same.
2320 * tracepoint.c: Same.
2321 * tui/tui-data.h: Same.
2322 * tui/tui-io.c: Same.
2323 * tui/tui-win.c: Same.
2324 * tui/tui.c: Same.
2325 * unittests/rsp-low-selftests.c: Same.
2326 * user-regs.h: Same.
2327 * utils.c: Same.
2328 * utils.h: Same.
2329 * valarith.c: Same.
2330 * valops.c: Same.
2331 * valprint.c: Same.
2332 * valprint.h: Same.
2333 * value.c: Same.
2334 * value.h: Same.
2335 * varobj.c: Same.
2336 * x86-nat.h: Same.
2337 * xtensa-tdep.c: Same.
2338
2339 2019-10-25 Ali Tamur <tamur@google.com>
2340
2341 * charset.c (find_charset_names): Reflect API change.
2342
2343 2019-10-25 Christian Biesinger <cbiesinger@google.com>
2344
2345 * symtab.c (struct demangled_name_entry): Change demangled name
2346 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2347 part of the struct anymore.
2348 (symbol_set_names): No longer obstack allocate + copy the demangled
2349 name, just store the allocated name from bfd.
2350
2351 2019-10-25 Tom Tromey <tromey@adacore.com>
2352
2353 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2354 (bsearch_cie_cmp, add_cie): Remove.
2355 (find_cie): Reimplement.
2356 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2357 (dwarf2_build_frame_info): Update.
2358
2359 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2360
2361 PR gdb/25126
2362 * symfile.c (reread_symbols): Call forget_cached_source_info to
2363 clear the stale source cache.
2364
2365 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2366
2367 * configure: Regenerate.
2368 * configure.ac: Remove code that sets python_has_threads.
2369
2370 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2371
2372 * config.in: Regenerate.
2373 * configure: Regenerate.
2374 * configure.ac: Remove the code that uses sed to get the python
2375 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2376
2377 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2378
2379 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2380 error paths.
2381
2382 2019-10-23 Tom Tromey <tom@tromey.com>
2383
2384 * arc-tdep.c: Remove ".." from include.
2385 * frv-tdep.c: Remove ".." from include.
2386 * lm32-tdep.c: Remove ".." from include.
2387 * microblaze-tdep.c: Remove ".." from include.
2388 * or1k-tdep.h: Remove ".." from include.
2389 * s12z-tdep.c: Remove ".." from include.
2390 * Makefile.in (OPCODES_CFLAGS): Add comment.
2391 (TOP_CFLAGS): New variable.
2392 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2393
2394 2019-10-23 Tom Tromey <tom@tromey.com>
2395
2396 * Makefile.in (READLINE_DIR): Update.
2397
2398 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2399
2400 * infcall.c (call_function_by_hand_dummy): Fix the function
2401 comment. And extract out a code section into...
2402 (reserve_stack_space): ...this new function.
2403
2404 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2405
2406 * infcall.c (value_arg_coerce): Remove an unused parameter.
2407 (call_function_by_hand_dummy): Update the call to
2408 'value_arg_coerce'.
2409
2410 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2411
2412 * infcall.c (call_function_by_hand_dummy): Refactor.
2413
2414 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2415
2416 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2417
2418 2019-10-23 Tom Tromey <tom@tromey.com>
2419
2420 * configure: Rebuild.
2421 * configure.ac: Don't check for sigprocmask.
2422 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2423
2424 2019-10-23 Tom Tromey <tom@tromey.com>
2425
2426 * configure: Rebuild.
2427 * acinclude.m4: Use m4_include, not sinclude.
2428
2429 2019-10-23 Tom de Vries <tdevries@suse.de>
2430
2431 PR breakpoints/24687
2432 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2433
2434 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2435
2436 * symtab.c (struct demangled_name_entry) <language>: Change from
2437 bitfield to regular variable.
2438
2439 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2440
2441 * symtab.c (struct demangled_name_entry): Add a constructor.
2442 (free_demangled_name_entry): New function to call the destructor
2443 for demangled_name_entry.
2444 (create_demangled_names_hash): Pass free_demangled_name_entry to
2445 htab_create_alloc.
2446 (symbol_set_names): Call placement new for demangled_name_entry.
2447 * utils.c: No longer include xxhash.h here, now that fast_hash
2448 is inlined in the header.
2449 * utils.h: Instead, include it here.
2450
2451 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2452
2453 * Makefile.in: Link with libxxhash.
2454 * config.in: Regenerate.
2455 * configure: Regenerate.
2456 * configure.ac: Search for libxxhash.
2457 * utils.c (fast_hash): Use xxhash if present.
2458
2459 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2460
2461 * utils.h (fast_hash): New function.
2462 * symtab.c (hash_demangled_name_entry): Call new function
2463 fast_hash.
2464
2465 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2466
2467 * symtab.c (struct demangled_name_entry): Change type of mangled
2468 to gdb::string_view. Also adds a constructor that takes the
2469 mangled name.
2470 (hash_demangled_name_entry): Update.
2471 (eq_demangled_name_entry): Update.
2472 (free_demangled_name_entry): New function to call the destructor
2473 now that this is not a POD anymore.
2474 (create_demangled_names_hash): Pass free_demangled_name_entry to
2475 htab_create_alloc.
2476 (symbol_set_names): Update.
2477
2478 2019-10-21 Ali Tamur <tamu@google.com>
2479
2480 * dwarf2read.c (dir_index): Change type.
2481 (file_name_index): Likewise.
2482 (line_header::include_dir_at): Change comment and implementation on
2483 whether it is DWARF 5.
2484 (line_header::is_valid_file_index): New function.
2485 (line_header::file_name_at): Change comment and implementation on
2486 whether it is DWARF 5.
2487 (line_header::file_names): Change to private field renamed as
2488 m_file_names and introduce a new accessor method.
2489 (line_header::file_names_size): New method.
2490 (line_header::include_dirs): Change to private field and rename as
2491 m_include_dirs.
2492 (dw2_get_file_names_reader): Define local var at a smaller scope and
2493 reflect API change.
2494 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2495 (process_structure_scope): Likewise.
2496 (line_header::add_include_dir): Change message and reflect renaming.
2497 (line_header::add_file_name): Likewise.
2498 (read_formatted_entries): Handle DW_FORM_data16.
2499 (dwarf_decode_line_header): Fix line header length calculation.
2500 (psymtab_include_file_name): Change comment and API.
2501 (lnp_state_machine::m_file): Update comment and reflect type change.
2502 (lnp_state_machine::record_line): Reflect type change.
2503 (dwarf_decode_lines): Reflect API change.
2504 (file_file_name): Likewise.
2505 (file_full_name): Likewise.
2506
2507 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2508
2509 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2510
2511 2019-10-21 Tom Tromey <tom@tromey.com>
2512
2513 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2514
2515 2019-10-21 Tom Tromey <tom@tromey.com>
2516
2517 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2518 NM_H. Use AC_CONFIG_LINKS.
2519 * configure: Rebuild.
2520 * Makefile.in (NM_H): New variable.
2521 (generated_files): Add NM_H. Remove gcore.
2522 (nm.h, stamp-nmh): New targets.
2523
2524 2019-10-20 Tom Tromey <tom@tromey.com>
2525
2526 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2527 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2528 obsolete comment.
2529 (put_objfile_before): Now static.
2530
2531 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2532
2533 * gdbsupport/common-utils.h (startswith): Change return type to
2534 bool.
2535
2536 2019-10-19 Christian Biesinger <cbiesinger@google.com>
2537
2538 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2539 * breakpoint.c (bp_locations_compare): Rename to...
2540 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2541 (update_global_location_list): Use std::sort instead of qsort.
2542 * buildsym.c (compare_line_numbers): Rename to...
2543 (lte_is_less_than): ...this, and change to std::sort semantics.
2544 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2545 instead of qsort.
2546 * disasm.c (compare_lines): Rename to...
2547 (line_is_less_than): ...this, and change to std::sort semantics.
2548 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2549 of qsort.
2550 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2551 (fde_is_less_than): ...this, and change to std::sort semantics.
2552 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2553 * mdebugread.c (compare_blocks):
2554 (block_is_less_than): ...this, and change to std::sort semantics.
2555 (sort_blocks): Call std::sort instead of qsort.
2556 * objfiles.c (qsort_cmp): Rename to...
2557 (sort_cmp): ...this, and change to std::sort semantics.
2558 (update_section_map): Call std::sort instead of qsort.
2559 * remote.c (compare_pnums): Remove.
2560 (map_regcache_remote_table): Call std::sort instead of qsort.
2561 * utils.c (compare_positive_ints): Remove.
2562 * utils.h (compare_positive_ints): Remove.
2563 * xcoffread.c (compare_lte): Remove.
2564 (arrange_linetable): Call std::sort instead of qsort.
2565
2566 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2567
2568 * symfile.c (init_entry_point_info): Fix typo.
2569 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2570
2571 2019-10-18 Tom de Vries <tdevries@suse.de>
2572
2573 * aarch64-tdep.c: Fix typos in comments.
2574 * ada-lang.c: Same.
2575 * ada-tasks.c: Same.
2576 * alpha-tdep.c: Same.
2577 * alpha-tdep.h: Same.
2578 * amd64-nat.c: Same.
2579 * amd64-windows-tdep.c: Same.
2580 * arc-tdep.c: Same.
2581 * arc-tdep.h: Same.
2582 * arch-utils.c: Same.
2583 * arm-nbsd-tdep.c: Same.
2584 * arm-tdep.c: Same.
2585 * ax-gdb.c: Same.
2586 * blockframe.c: Same.
2587 * btrace.c: Same.
2588 * c-varobj.c: Same.
2589 * coff-pe-read.c: Same.
2590 * coffread.c: Same.
2591 * cris-tdep.c: Same.
2592 * darwin-nat.c: Same.
2593 * dbxread.c: Same.
2594 * dcache.c: Same.
2595 * disasm.c: Same.
2596 * dtrace-probe.c: Same.
2597 * dwarf-index-write.c: Same.
2598 * dwarf2-frame-tailcall.c: Same.
2599 * dwarf2-frame.c: Same.
2600 * dwarf2read.c: Same.
2601 * eval.c: Same.
2602 * exceptions.c: Same.
2603 * fbsd-tdep.c: Same.
2604 * findvar.c: Same.
2605 * frame.c: Same.
2606 * frv-tdep.c: Same.
2607 * gnu-v3-abi.c: Same.
2608 * go32-nat.c: Same.
2609 * h8300-tdep.c: Same.
2610 * hppa-tdep.c: Same.
2611 * i386-linux-tdep.c: Same.
2612 * i386-tdep.c: Same.
2613 * ia64-libunwind-tdep.c: Same.
2614 * ia64-tdep.c: Same.
2615 * infcmd.c: Same.
2616 * infrun.c: Same.
2617 * linespec.c: Same.
2618 * linux-nat.c: Same.
2619 * linux-thread-db.c: Same.
2620 * machoread.c: Same.
2621 * mdebugread.c: Same.
2622 * mep-tdep.c: Same.
2623 * mn10300-tdep.c: Same.
2624 * namespace.c: Same.
2625 * objfiles.c: Same.
2626 * opencl-lang.c: Same.
2627 * or1k-tdep.c: Same.
2628 * osabi.c: Same.
2629 * ppc-linux-nat.c: Same.
2630 * ppc-linux-tdep.c: Same.
2631 * ppc-sysv-tdep.c: Same.
2632 * printcmd.c: Same.
2633 * procfs.c: Same.
2634 * record-btrace.c: Same.
2635 * record-full.c: Same.
2636 * remote-fileio.c: Same.
2637 * remote.c: Same.
2638 * rs6000-tdep.c: Same.
2639 * s12z-tdep.c: Same.
2640 * score-tdep.c: Same.
2641 * ser-base.c: Same.
2642 * ser-go32.c: Same.
2643 * skip.c: Same.
2644 * sol-thread.c: Same.
2645 * solib-svr4.c: Same.
2646 * solib.c: Same.
2647 * source.c: Same.
2648 * sparc-nat.c: Same.
2649 * sparc-sol2-tdep.c: Same.
2650 * sparc-tdep.c: Same.
2651 * sparc64-tdep.c: Same.
2652 * stabsread.c: Same.
2653 * stack.c: Same.
2654 * symfile.c: Same.
2655 * symtab.c: Same.
2656 * target-descriptions.c: Same.
2657 * target-float.c: Same.
2658 * thread.c: Same.
2659 * utils.c: Same.
2660 * valops.c: Same.
2661 * valprint.c: Same.
2662 * value.c: Same.
2663 * varobj.c: Same.
2664 * windows-nat.c: Same.
2665 * xcoffread.c: Same.
2666 * xstormy16-tdep.c: Same.
2667 * xtensa-tdep.c: Same.
2668
2669 2019-10-17 Tom Tromey <tromey@adacore.com>
2670
2671 * configure: Rebuild.
2672 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2673 in AC_CONFIG_FILES invocation.
2674 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2675 new-style config.status invocation.
2676
2677 2019-10-17 Tom de Vries <tdevries@suse.de>
2678
2679 * arm-nbsd-nat.c: Fix typos in comments.
2680 * arm-tdep.c: Same.
2681 * darwin-nat-info.c: Same.
2682 * dwarf2read.c: Same.
2683 * elfread.c: Same.
2684 * event-top.c: Same.
2685 * findvar.c: Same.
2686 * gdbtypes.c: Same.
2687 * hppa-tdep.c: Same.
2688 * i386-tdep.c: Same.
2689 * jit.c: Same.
2690 * main.c: Same.
2691 * mdebugread.c: Same.
2692 * moxie-tdep.c: Same.
2693 * nto-procfs.c: Same.
2694 * osabi.c: Same.
2695 * ppc-linux-tdep.c: Same.
2696 * remote.c: Same.
2697 * riscv-tdep.c: Same.
2698 * s390-tdep.c: Same.
2699 * sh-tdep.c: Same.
2700 * sparc-linux-tdep.c: Same.
2701 * sparc-nat.c: Same.
2702 * stack.c: Same.
2703 * target-descriptions.c: Same.
2704 * top.c: Same.
2705 * varobj.c: Same.
2706
2707 2019-10-16 Tom Tromey <tom@tromey.com>
2708
2709 * objfiles.h (struct objfile) <original_name>: Now const.
2710
2711 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2712
2713 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2714 pass on to sigsetjmp's second argument.
2715 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2716
2717 2019-10-16 Keith Seitz <keiths@redhat.com>
2718
2719 PR gdb/23567
2720 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2721 sections whose size is greater than the file size.
2722
2723 2019-10-16 Jim Wilson <jimw@sifive.com>
2724
2725 * riscv-tdep.c (riscv_gcc_target_options): New.
2726 (riscv_gnu_triplet_regexp): New.
2727 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2728 set_gdbarch_gnu_triplet_regexp.
2729
2730 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2731
2732 * Makefile.in: Add xml-builtin.h.
2733 * features/feature_to_c.sh: Add an include for xml-builtin.h
2734 to ensure that the compiler checks that the types match.
2735 * xml-builtin.h: New file.
2736 * xml-support.c (fetch_xml_builtin): Add missing const.
2737 * xml-support.h: Remove declaration of xml_builtins.
2738
2739 2019-10-16 Tom de Vries <tdevries@suse.de>
2740
2741 PR tdep/25096
2742 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2743 (amd64_classify_aggregate): ... here.
2744 (amd64_classify_aggregate_field): Handled fiels of nested structs
2745 recursively.
2746
2747 2019-10-16 Tom de Vries <tdevries@suse.de>
2748
2749 PR tdep/24104
2750 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2751 that handles 'theclass'.
2752
2753 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2754
2755 * linespec.c (decode_digits_ordinary): Update comment.
2756 * make-target-delegates: No longer need to handle VEC case.
2757 * memrange.c (normalize_mem_ranges): Update comment.
2758 * namespace.c (add_using_directive): Update comment.
2759 * objc-lang.c (uniquify_strings): Update comment.
2760 * ppc-linux-nat.c (struct thread_points): Update comment.
2761 * probe.h (find_probes_in_objfile): Update comment.
2762 * target.h (enum flash_preserve_mode): Update comment.
2763 * varobj.c (varobj_restrict_range): Update comment.
2764 * varobj.h (varobj_list_children): Update comment.
2765
2766 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2767
2768 * Makefile.in: Remove references to vec.h and vec.c.
2769 * aarch64-tdep.c: No longer include vec.h.
2770 * ada-lang.c: Likewise.
2771 * ada-lang.h: Likewise.
2772 * arm-tdep.c: Likewise.
2773 * ax.h: Likewise.
2774 * breakpoint.h: Likewise.
2775 * charset.c: Likewise.
2776 * cp-support.h: Likewise.
2777 * dtrace-probe.c: Likewise.
2778 * dwarf2read.c: Likewise.
2779 * extension.h: Likewise.
2780 * gdb_bfd.c: Likewise.
2781 * gdbsupport/gdb_vecs.h: Likewise.
2782 * gdbsupport/vec.c: Remove.
2783 * gdbsupport/vec.h: Remove.
2784 * gdbthread.h: Likewise.
2785 * guile/scm-type.c: Likewise.
2786 * inline-frame.c: Likewise.
2787 * machoread.c: Likewise.
2788 * memattr.c: Likewise.
2789 * memrange.h: Likewise.
2790 * namespace.h: Likewise.
2791 * nat/linux-btrace.h: Likewise.
2792 * osdata.c: Likewise.
2793 * parser-defs.h: Likewise.
2794 * progspace.h: Likewise.
2795 * python/py-type.c: Likewise.
2796 * record-btrace.c: Likewise.
2797 * rust-exp.y: Likewise.
2798 * solib-target.c: Likewise.
2799 * stap-probe.c: Likewise.
2800 * target-descriptions.c: Likewise.
2801 * target-memory.c: Likewise.
2802 * target.h: Likewise.
2803 * varobj.c: Likewise.
2804 * varobj.h: Likewise.
2805 * xml-support.h: Likewise.
2806
2807 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2808
2809 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2810 Update for new std::vector based implementation.
2811 (process_psymtab_comp_unit_reader): Likewise.
2812 (scan_partial_symbols): Likewise.
2813 (recursively_compute_inclusions): Likewise.
2814 (compute_compunit_symtab_includes): Likewise.
2815 (process_imported_unit_die): Likewise.
2816 (queue_and_load_dwo_tu): Likewise.
2817 (follow_die_sig_1): Likewise.
2818 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2819 (typedef dwarf2_per_cu_ptr): Remove.
2820 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2821 function.
2822 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2823 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2824 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2825 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2826 std::vector.
2827
2828 2019-10-15 Tom Tromey <tromey@adacore.com>
2829
2830 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2831 TID.
2832
2833 2019-10-15 Tom Tromey <tromey@adacore.com>
2834
2835 * windows-nat.c (windows_nat_target::fetch_registers)
2836 (windows_nat_target::store_registers): Rename "pid" to "tid".
2837
2838 2019-10-15 Tom Tromey <tromey@adacore.com>
2839
2840 * gdbarch.h, gdbarch.c: Rebuild.
2841 * gdbarch.sh (gcc_target_options): Change return type to
2842 std::string.
2843 * compile/compile.c (get_args): Update.
2844 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2845 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2846 std::string.
2847 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2848 std::string.
2849 * arch-utils.c (default_gcc_target_options): Return std::string.
2850 * arch-utils.h (default_gcc_target_options): Return std::string.
2851 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2852
2853 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2854
2855 * breakpoint.c (breakpoint_chain): Make static.
2856 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2857 of accessing breakpoint_chain.
2858
2859 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2860
2861 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2862 to a gdb::function_view and return value to bool.
2863 * breakpoint.h (iterate_over_breakpoints): Likewise.
2864 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2865 (pop_dummy_frame): Update.
2866 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2867 (gdbscm_breakpoints): Update.
2868 * python/py-breakpoint.c (build_bp_list): Update.
2869 (gdbpy_breakpoints): Update.
2870 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2871 Update.
2872 (bpfinishpy_handle_stop): Update.
2873 (bpfinishpy_handle_exit): Update.
2874 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2875 (svr4_update_solib_event_breakpoints): Update.
2876
2877 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2878
2879 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2880 when unwrapping single-field structs.
2881
2882 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2883
2884 * dwarf2read.c: Remove includes.
2885
2886 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2887
2888 * ui-out.c (ui_out::call_do_message): Silence
2889 -Wformat-nonliteral warning.
2890
2891 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2892
2893 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2894 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2895 include: readline/tilde.h.
2896
2897 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2898
2899 * remote.c (remote_target::get_trace_status): Remove declaration of
2900 trace_regblock_size.
2901
2902 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2903
2904 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2905 (show_user): Remove declaration of cmdlist.
2906 * cli/cli-cmds.h (max_user_call_depth): Declare.
2907 * cli/cli-script.c (execute_user_command): Remove declaration
2908 of max_user_call_depth.
2909
2910 2019-10-11 Jim Wilson <jimw@sifive.com>
2911
2912 * gdbsupport/print-utils.h (pulongest): Fix comment.
2913 (plongest): Likewise.
2914 (phex): Add missing comment, mention leading zeros.
2915 (phex_nz): Add mention of no leading zeros to comment.
2916
2917 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2918 plongest instead of unsigned long long cast.
2919
2920 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2921
2922 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2923 for external_editor_command and gdbtk_test.
2924
2925 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2926
2927 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2928 * varobj.c (varobjdebug): Move comment to...
2929 * varobj.h (varobjdebug): ...here, and declare.
2930
2931 2019-10-09 Tom Tromey <tom@tromey.com>
2932
2933 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2934 erase_data_content.
2935
2936 2019-10-09 Tom Tromey <tom@tromey.com>
2937
2938 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2939 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2940 * tui/tui-command.c (tui_cmd_window::resize)
2941 (tui_refresh_cmd_win): Update.
2942 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2943 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2944 * tui/tui-data.c (~tui_gen_win_info): Remove.
2945 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2946 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2947 (tui_redisplay_readline, tui_mld_flush)
2948 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2949 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2950 (tui_data_window::erase_data_content)
2951 (tui_data_item_window::rerender)
2952 (tui_data_item_window::refresh_window): Update.
2953 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2954 (box_win, tui_gen_win_info::make_window)
2955 (tui_gen_win_info::make_visible): Update.
2956 (tui_delete_win): Remove.
2957 * tui/tui-winsource.c
2958 (tui_source_window_base::do_erase_source_content): Update.
2959 (tui_show_source_line, tui_source_window_base::update_tab_width)
2960 (tui_source_window_base::update_exec_info): Update.
2961 * tui/tui-data.h (struct curses_deleter): New.
2962 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2963 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2964
2965 2019-10-09 Tom Tromey <tom@tromey.com>
2966
2967 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2968
2969 2019-10-09 Tom Tromey <tom@tromey.com>
2970
2971 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2972 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2973
2974 2019-10-09 Tom Tromey <tom@tromey.com>
2975
2976 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2977 window height directly.
2978 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2979 declare.
2980 * tui/tui-layout.c (tui_default_win_height): Remove.
2981 (tui_default_win_viewport_height): Remove.
2982
2983 2019-10-09 Tom Tromey <tom@tromey.com>
2984
2985 * tui/tui.h: Remove comments.
2986
2987 2019-10-09 Tom de Vries <tdevries@suse.de>
2988
2989 * python/lib/gdb/printer/bound_registers.py: Use
2990 '^builtin_type_bound128' as regexp argument for
2991 add_builtin_pretty_printer.
2992
2993 2019-10-09 Christian Biesinger <cbiesinger@google.com>
2994
2995 * guile/guile.c (guile_extension_script_ops): Remove forward
2996 declaration and mark as static.
2997 (guile_script_ops): Likewise.
2998 (extension_language_guile): Move further down in the file so
2999 it can reference the definitions for guile_{extension_,}script_ops.
3000
3001 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3002
3003 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3004 except SORTL, DFLTCC, and KDSA.
3005
3006 2019-10-08 Tom Tromey <tromey@adacore.com>
3007
3008 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3009 (struct safe_symbol_file_add_args): Remove.
3010
3011 2019-10-08 Tom Tromey <tromey@adacore.com>
3012
3013 * windows-nat.c: Don't include buildsym-legacy.h.
3014
3015 2019-10-08 Tom Tromey <tromey@adacore.com>
3016
3017 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3018
3019 2019-10-08 Christian Biesinger <cbiesinger@google.com>
3020
3021 * gdbtypes.c (overload_debug): Move comment to header.
3022 * gdbtypes.h (overload_debug): Declare.
3023 * valops.c: Remove declaration of overload_debug, instead
3024 include gdbtypes.h.
3025
3026 2019-10-08 Christian Biesinger <cbiesinger@google.com>
3027
3028 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3029 through _().
3030 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3031 move comment...
3032 * language.h (lang_frame_mismatch_warn): ... here. Also add
3033 declaration.
3034 * top.c (lang_frame_mismatch_warn): Remove declaration.
3035 (check_frame_language_change): Pass lang_frame_mismatch_warn
3036 through _().
3037
3038 2019-10-07 Christian Biesinger <cbiesinger@google.com>
3039
3040 * c-lang.h (vtbl_ptr_name): Declare.
3041 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3042 it from the header.
3043 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3044
3045 2019-10-07 Christian Biesinger <cbiesinger@google.com>
3046
3047 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3048 gdb_static_assert.
3049
3050 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
3051
3052 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3053 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3054 * ctfread.c: New file.
3055 * ctfread.h: New file.
3056 * elfread.c: Include ctfread.h.
3057 (struct elfinfo text_p): New member ctfsect.
3058 (elf_locate_sections): Mark CTF section.
3059 (elf_symfile_read): Call elfctf_build_psymtabs.
3060 * Makefile.in (LIBCTF): Add.
3061 (CLIBS): Use it.
3062 (CDEPS): Likewise.
3063 (DIST): Add ctfread.c.
3064
3065 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3066
3067 * ctfread.c (struct nextfield): Renamed to ...
3068 (struct ctf_nextfield): ... this.
3069 (struct field_info): Renamed to ...
3070 (strut ctf_field_info): ... this.
3071 (attach_fields_to_type): Update for renamed structures.
3072 (ctf_add_member_cb): Likewise.
3073 (ctf_add_enum_member_cb): Likewise.
3074 (process_struct_members): Likewise.
3075 (process_enum_type): Likewise.
3076
3077 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
3078
3079 * tracectf.h: Rename, was ctf.h.
3080 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3081 * tracefile.c: Likewise.
3082 * tracepoint.c: Remove unused include ctf.h.
3083 * mi/mi-main.c: Likewise.
3084 * Makefile.in Replace ctf.c with tracectf.c.
3085
3086 2019-10-06 Joel Brobecker <brobecker@adacore.com>
3087
3088 * version.in: Change version number to "9.0.50.DATE-git".
3089
3090 2019-10-03 Tom Tromey <tom@tromey.com>
3091
3092 PR rust/24976:
3093 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3094
3095 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3096
3097 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3098 cp_search_name_hash.
3099 * NEWS: Add entry about nested function support.
3100
3101 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3102 Andrew Burgess <andrew.burgess@embecosm.com>
3103
3104 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3105 for nested static variables when searchin VAR_DOMAIN.
3106 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3107 global scope, update comment.
3108 (add_partial_subprogram): Call add_partial_subprogram recursively
3109 for nested subroutines when processinng Fortran.
3110 (load_partial_dies): Process the child entities of a subprogram
3111 when processing Fortran.
3112 (partial_die_parent_scope): Handle building scope
3113 for Fortran nested functions.
3114 (process_die): Record that nested functions have a scope.
3115 (new_symbol): Always record Fortran subprograms on the global
3116 symbol list.
3117 (determine_prefix): How to build the prefix for Fortran
3118 subprograms.
3119
3120 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3121
3122 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3123 have just sent the thread a SIGSTOP and are waiting for it to
3124 arrive.
3125
3126 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3127
3128 * btrace.c (btrace_add_pc): Remove whitespace before the template
3129 parameter in 'std::vector <...>'.
3130 (parse_xml_btrace_block): Likewise.
3131 (btrace_maint_decode_pt): Likewise.
3132 (btrace_maint_update_packets): Likewise.
3133 (btrace_maint_print_packets): Likewise.
3134 * btrace.h (struct btrace_maint_info): Likewise.
3135 * dwarf2read.c (struct type_unit_group): Likewise.
3136 (build_type_psymtabs_reader): Likewise.
3137 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3138 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3139 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3140
3141 2019-10-03 Tom de Vries <tdevries@suse.de>
3142
3143 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3144 the first line of the help text for set/show style metadata.
3145
3146 2019-10-02 Tom Tromey <tromey@adacore.com>
3147
3148 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3149 * gdbsupport/common-inferior.c: New file.
3150 * infcmd.c (startup_with_shell): Don't define.
3151 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3152 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3153 * inferior.h (startup_with_shell): Don't declare.
3154
3155 2019-10-02 Christian Biesinger <cbiesinger@google.com>
3156
3157 * gdbsupport/gdb_assert.h: Include errors.h.
3158 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3159
3160 2019-10-02 Tom Tromey <tromey@adacore.com>
3161
3162 * NEWS: Add $_ada_exception entry.
3163 * ada-lang.c (struct ada_catchpoint): Add constructor.
3164 <m_kind>: New member.
3165 (allocate_location_exception, re_set_exception): Remove
3166 "ex" parameter.
3167 (should_stop_exception): Compute $_ada_exception.
3168 (check_status_exception, print_it_exception)
3169 (print_one_exception, print_mention_exception): Remove
3170 "ex" parameter.
3171 (allocate_location_catch_exception, re_set_catch_exception)
3172 (check_status_exception, print_it_catch_exception)
3173 (print_one_catch_exception, print_mention_catch_exception)
3174 (print_recreate_catch_exception)
3175 (allocate_location_catch_exception_unhandled)
3176 (re_set_catch_exception_unhandled)
3177 (check_status_exception, print_it_catch_exception_unhandled)
3178 (print_one_catch_exception_unhandled)
3179 (print_mention_catch_exception_unhandled)
3180 (print_recreate_catch_exception_unhandled)
3181 (allocate_location_catch_assert, re_set_catch_assert)
3182 (check_status_assert, print_it_catch_assert)
3183 (print_one_catch_assert, print_mention_catch_assert)
3184 (print_recreate_catch_assert)
3185 (allocate_location_catch_handlers, re_set_catch_handlers)
3186 (check_status_handlers, print_it_catch_handlers)
3187 (print_one_catch_handlers, print_mention_catch_handlers)
3188 (print_recreate_catch_handlers): Remove.
3189 (create_ada_exception_catchpoint): Update.
3190 (initialize_ada_catchpoint_ops): Update.
3191
3192 2019-10-02 Tom Tromey <tromey@adacore.com>
3193
3194 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3195 (create_excep_cond_exprs): Simplify exception string computation.
3196 (ada_exception_catchpoint_cond_string): Likewise.
3197
3198 2019-10-02 Tom Tromey <tromey@adacore.com>
3199
3200 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3201 * ada-lang.c (lesseq_defined_than): Handle
3202 LOC_STATIC.
3203 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3204 parameter.
3205 (dwarf2_has_info): Likewise.
3206 (new_symbol): Set maybe_copied on symbol when
3207 appropriate.
3208 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3209 parameter.
3210 <can_copy>: New member.
3211 * elfread.c (record_minimal_symbol): Set maybe_copied
3212 on symbol when appropriate.
3213 (elf_symfile_read): Update call to dwarf2_has_info.
3214 * minsyms.c (lookup_minimal_symbol_linkage): New
3215 function.
3216 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3217 * symtab.c (get_symbol_address, get_msymbol_address):
3218 New functions.
3219 * symtab.h (get_symbol_address, get_msymbol_address):
3220 Declare.
3221 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3222 maybe_copied.
3223 (struct symbol, struct minimal_symbol) <maybe_copied>:
3224 New member.
3225
3226 2019-10-02 Tom Tromey <tromey@adacore.com>
3227
3228 * source.c (struct current_source_location): New.
3229 (current_source_key): New global.
3230 (current_source_symtab, current_source_line)
3231 (current_source_pspace): Remove.
3232 (get_source_location): New function.
3233 (get_current_source_symtab_and_line)
3234 (set_default_source_symtab_and_line)
3235 (set_current_source_symtab_and_line)
3236 (clear_current_source_symtab_and_line, select_source_symtab)
3237 (info_source_command, print_source_lines_base)
3238 (info_line_command, search_command_helper, _initialize_source):
3239 Update.
3240
3241 2019-10-02 Tom Tromey <tromey@adacore.com>
3242
3243 * source.c (select_source_symtab): Don't call
3244 decode_line_with_current_source.
3245
3246 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3247
3248 * symtab.c (lookup_global_symbol): Search global block.
3249
3250 2019-10-02 Tom Tromey <tromey@adacore.com>
3251
3252 * coffread.c (process_coff_symbol): Update.
3253 * dwarf2read.c (var_decode_location, new_symbol): Update.
3254 * mdebugread.c (parse_symbol): Update.
3255 * objfiles.c (relocate_one_symbol): Update.
3256 * stabsread.c (define_symbol, fix_common_block)
3257 (scan_file_globals): Update.
3258 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3259 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3260 * xcoffread.c (process_xcoff_symbol): Update.
3261
3262 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3263
3264 * MAINTAINERS: Update my email address.
3265
3266 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3267
3268 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3269 std::vector.
3270 (build_type_psymtabs_reader): Update for std::vector.
3271 (build_type_psymtab_dependencies): Likewise.
3272 * dwarf2read.h: Remove use of DEF_VEC_P.
3273 (typedef sig_type_ptr): Delete.
3274
3275 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3276
3277 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3278 to std::vector.
3279 (btrace_maint_decode_pt): Likewise, and move allocation of the
3280 vector outside of the loop.
3281 (btrace_maint_update_packets): Update to handle change from VEC to
3282 std::vector.
3283 (btrace_maint_print_packets): Likewise.
3284 (maint_info_btrace_cmd): Likewise.
3285 * btrace.h: Remove use of DEF_VEC_O.
3286 (typedef btrace_pt_packet_s): Delete.
3287 (struct btrace_maint_info) <packets>: Change fromm VEC to
3288 std::vector.
3289 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3290
3291 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3292
3293 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3294 make accesses into the vector constant references.
3295 (btrace_add_pc): Update for std::vector.
3296 (btrace_stitch_bts): Likewise.
3297 (parse_xml_btrace_block): Likewise.
3298 (btrace_maint_update_packets): Likewise.
3299 (btrace_maint_print_packets): Likewise.
3300 (maint_info_btrace_cmd): Likewise.
3301 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3302 std::vector.
3303 (btrace_data::empty): Likewise.
3304 (btrace_data_append): Likewise.
3305 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3306 (typedef btrace_block_s): Delete.
3307 (struct btrace_block): Add constructor.
3308 (struct btrace_data_bts) <blocks>: Change to std::vector.
3309 * nat/linux-btrace.c (perf_event_read_bts): Update for
3310 std::vector.
3311 (linux_read_bts): Likewise.
3312
3313 2019-10-01 Tom Tromey <tom@tromey.com>
3314
3315 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3316
3317 2019-10-01 Tom Tromey <tom@tromey.com>
3318
3319 * stack.c (print_frame, info_frame_command_core): Use
3320 styled_string.
3321 * linux-thread-db.c (try_thread_db_load_1)
3322 (try_thread_db_load_from_pdir_1): Use styled_string.
3323 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3324 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3325 (maybe_print_unsupported_script_warning)
3326 (maybe_print_script_not_found_warning): Use styled_string.
3327 * ada-lang.c (user_select_syms): Use styled_string.
3328
3329 2019-10-01 Tom Tromey <tom@tromey.com>
3330
3331 * p-lang.c (pascal_printstr): Use metadata style.
3332 * value.c (show_convenience): Use metadata style.
3333 * valprint.c (valprint_check_validity, val_print_optimized_out)
3334 (val_print_not_saved, val_print_unavailable)
3335 (val_print_invalid_address, generic_val_print, val_print)
3336 (value_check_printable, val_print_array_elements): Use metadata
3337 style.
3338 * ui-out.h (class ui_out) <field_fmt>: New overload.
3339 <do_field_fmt>: Add style parameter.
3340 * ui-out.c (ui_out::field_fmt): New overload.
3341 * typeprint.c (type_print_unknown_return_type)
3342 (val_print_not_allocated, val_print_not_associated): Use metadata
3343 style.
3344 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3345 parameter.
3346 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3347 * tracepoint.c (tvariables_info_1): Use metadata style.
3348 * stack.c (print_frame_arg, print_frame_info, print_frame)
3349 (info_frame_command_core): Use metadata style.
3350 * skip.c (info_skip_command): Use metadata style.
3351 * rust-lang.c (rust_print_enum): Use metadata style.
3352 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3353 metadata style.
3354 * python/py-framefilter.c (py_print_single_arg): Use metadata
3355 style.
3356 * printcmd.c (do_one_display, print_variable_and_value): Use
3357 metadata style.
3358 * p-valprint.c (pascal_val_print)
3359 (pascal_object_print_value_fields): Use metadata style.
3360 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3361 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3362 parameter.
3363 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3364 * m2-valprint.c (m2_print_long_set): Use metadata style.
3365 * m2-typeprint.c (m2_print_type): Use metadata style.
3366 * infcmd.c (print_return_value_1): Use metadata style.
3367 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3368 * f-valprint.c (info_common_command_for_block): Use metadata
3369 style.
3370 * f-typeprint.c (f_type_print_base): Use metadata style.
3371 * expprint.c (print_subexp_standard): Use metadata style.
3372 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3373 * cli/cli-style.h (class cli_style_option): Add constructor.
3374 (metadata_style): Declare.
3375 * cli/cli-style.c (metadata_style): New global.
3376 (_initialize_cli_style): Register metadata style.
3377 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3378 parameter.
3379 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3380 * c-typeprint.c (c_type_print_base_struct_union)
3381 (c_type_print_base_1): Use metadata style.
3382 * breakpoint.c (watchpoint_value_print)
3383 (print_one_breakpoint_location): Use metadata style.
3384 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3385 style.
3386 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3387 style.
3388 * ada-valprint.c (val_print_packed_array_elements, printstr)
3389 (print_field_values, ada_val_print_ref, ada_val_print): Use
3390 metadata style.
3391 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3392 style.
3393 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3394 style.
3395 * ada-lang.c (user_select_syms): Use metadata style.
3396
3397 2019-10-01 Tom Tromey <tom@tromey.com>
3398
3399 * cli/cli-cmds.c (pwd_command): Style output.
3400
3401 2019-10-01 Pedro Alves <palves@redhat.com>
3402 Tom Tromey <tom@tromey.com>
3403
3404 * symtab.c (print_symbol_info): Use %ps.
3405 (print_msymbol_info): Use %ps.
3406 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3407 * printcmd.c (print_variable_and_value): Use %ps.
3408 * macrocmd.c (show_pp_source_pos): Use %ps.
3409 * infrun.c (print_exited_reason): Use ui_out::message.
3410 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3411 (describe_other_breakpoints): Use ui_out::message and new
3412 formats.
3413 (say_where): Use new formats.
3414 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3415 and new formats.
3416
3417 2019-10-01 Pedro Alves <palves@redhat.com>
3418 Tom Tromey <tom@tromey.com>
3419
3420 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3421 (test_gdb_formats): New function.
3422 (run_tests): Call it.
3423 (test_format_specifier): Update.
3424 * utils.h (fputs_filtered): Update comment.
3425 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3426 (fputs_styled_unfiltered): Declare.
3427 * utils.c (fputs_styled_unfiltered): New function.
3428 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3429 (vfprintf_filtered): Update.
3430 (vfprintf_unfiltered, vprintf_filtered): Update.
3431 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3432 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3433 disallow_ui_out_field>: New constants.
3434 (enum class field_kind): New.
3435 (struct base_field_s, struct signed_field_s): New.
3436 (signed_field): New function.
3437 (struct string_field_s): New.
3438 (string_field): New function.
3439 (struct styled_string_s): New.
3440 (styled_string): New function.
3441 (class ui_out) <message>: Add comment.
3442 <vmessage, call_do_message>: New methods.
3443 <do_message>: Add style parameter.
3444 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3445 methods.
3446 (ui_out::message): Rewrite.
3447 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3448 parameter.
3449 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3450 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3451 gdb_extensions parameter.
3452 (class format_piece): Add parameter to constructor.
3453 (n_int_args): New field.
3454 * gdbsupport/format.c (format_pieces::format_pieces): Add
3455 gdb_extensions parameter. Handle '*'.
3456 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3457 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3458 vfprintf_styled_no_gdbfmt.
3459 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3460 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3461 unfiltered output.
3462 * ui-style.h (struct ui_file_style) <ptr>: New method.
3463
3464 2019-10-01 Tom Tromey <tom@tromey.com>
3465
3466 * unittests/format_pieces-selftests.c: Update. Add final format.
3467 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3468 empty literal pieces.
3469
3470 2019-10-01 Tom Tromey <tom@tromey.com>
3471
3472 * ui-out.h (enum class ui_out_style_kind): Remove.
3473 (class ui_out) <field_string, field_stsream, do_field_string>:
3474 Change type of "style".
3475 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3476 (ui_out::field_string): Update.
3477 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3478 of "style".
3479 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3480 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3481 * stack.c (print_frame_arg, print_frame_info, print_frame):
3482 Update.
3483 * source.c (print_source_lines_base): Update.
3484 * solib.c (info_sharedlibrary_command): Update.
3485 * skip.c (info_skip_command): Update.
3486 * record-btrace.c (btrace_call_history_src_line)
3487 (btrace_call_history): Update.
3488 * python/py-framefilter.c (py_print_frame): Update.
3489 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3490 "style".
3491 * mi/mi-out.c (mi_ui_out::do_table_header)
3492 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3493 (mi_ui_out::do_field_string): Update.
3494 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3495 Update.
3496 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3497 "style".
3498 * cli-out.c (cli_ui_out::do_table_header)
3499 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3500 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3501 (cli_ui_out::do_field_fmt): Update.
3502 * breakpoint.c (print_breakpoint_location): Update.
3503 (update_static_tracepoint): Update.
3504
3505 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3506
3507 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3508 conversion of gdb_datadir.
3509 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3510 remove not needed c_str ().
3511
3512 2019-09-30 Ali Tamur <tamur@google.com>
3513
3514 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3515 (dwarf2_string_attr): Likewise.
3516
3517 2019-09-30 Ali Tamur <tamur@google.com>
3518
3519 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3520 (process_full_type_unit): Likewise.
3521 (dump_die_shallow): Likewise.
3522 (cu_debug_loc_section): Likewise.
3523
3524 2019-09-28 Christian Biesinger <cbiesinger@google.com>
3525
3526 * minsyms.c (compare_minimal_symbols): Rename to...
3527 (minimal_symbol_is_less_than): ...this, and adjust to STL
3528 conventions (return bool, take arguments as references)
3529 (minimal_symbol_reader::install): Call std::sort instead
3530 of qsort.
3531
3532 2019-09-29 Christian Biesinger <cbiesinger@google.com>
3533
3534 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3535 hash and why.
3536 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3537 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3538
3539 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3540
3541 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3542 * psympriv.h (add_psymbol_to_list): Move comment here and update
3543 it.
3544
3545 2019-09-29 Tom de Vries <tdevries@suse.de>
3546
3547 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3548 Use $tmpdir/$(basename "$output_file").dwz instead of
3549 "${output_file}.dwz".
3550
3551 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3552
3553 PR gdb/25045
3554 * hppa-linux-nat.c: Include gdbarch.h.
3555
3556 2019-09-26 Christian Biesinger <cbiesinger@google.com>
3557
3558 * blockframe.c (find_pc_partial_function): Change return type to bool.
3559 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3560 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3561 (stub_gnu_ifunc_resolve_name): Likewise.
3562 * symtab.c (compare_filenames_for_search): Likewise.
3563 (compare_glob_filenames_for_search): Likewise.
3564 (matching_obj_sections): Likewise.
3565 (symbol_matches_domain): Likewise.
3566 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3567 (find_line_pc): Change return type to bool.
3568 (find_line_pc_range): Likewise.
3569 (producer_is_realview): Likewise.
3570 * symtab.h (symbol_matches_domain): Likewise.
3571 (find_pc_partial_function): Likewise.
3572 (find_pc_line_pc_range): Likewise.
3573 (in_gnu_ifunc_stub): Likewise.
3574 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3575 (find_line_pc): Likewise.
3576 (find_line_pc_range): Likewise.
3577 (matching_obj_sections): Likewise.
3578 (find_line_symtab): Change out parameter to bool.
3579 (producer_is_realview): Change return type to bool.
3580 (compare_filenames_for_search): Likewise.
3581 (compare_glob_filenames_for_search): Likewise.
3582
3583 2019-09-26 Tom Tromey <tom@tromey.com>
3584
3585 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3586 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3587 * gdb_usleep.h: Remove.
3588 * gdb_usleep.c: Remove.
3589 * utils.c: Don't include gdb_usleep.h.
3590
3591 2019-09-26 Tom Tromey <tromey@adacore.com>
3592
3593 * python/py-type.c (type_to_type_object): Call check_typedef
3594 for stub types.
3595
3596 2019-09-26 Tom Tromey <tom@tromey.com>
3597
3598 * utils.h (initialize_utils): Don't declare.
3599 * top.c (gdb_init): Don't call initialize_utils.
3600 * utils.c (initialize_utils): Remove. Move contents...
3601 (_initialize_utils): ... here.
3602
3603 2019-09-25 Tom Tromey <tom@tromey.com>
3604
3605 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3606 * utils.h (make_hex_string): Don't declare.
3607 * utils.c (make_hex_string): Remove.
3608
3609 2019-09-24 Tom de Vries <tdevries@suse.de>
3610
3611 PR gdb/23815
3612 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3613 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3614
3615 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3616
3617 * NEWS: Mention new simulator port for PRU.
3618
3619 2019-09-23 Christian Biesinger <cbiesinger@google.com>
3620
3621 * ada-exp.y (write_object_remaining): Update.
3622 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3623 and eliminate the static buffer.
3624 (ada_decode_symbol): Update.
3625 (ada_la_decode): Update.
3626 (ada_sniff_from_mangled_name): Update.
3627 (is_valid_name_for_wild_match): Update.
3628 (ada_lookup_name_info::matches): Update and simplify.
3629 (name_matches_regex): Update.
3630 (ada_add_global_exceptions): Update.
3631 * ada-lang.h (ada_decode): Update signature.
3632 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3633 * dwarf-index-write.c (debug_names::insert): Update.
3634
3635 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3636
3637 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3638 formatting.
3639
3640 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3641
3642 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3643 Change "nonzero" to "true" in documentation.
3644
3645 2019-09-20 Christian Biesinger <cbiesinger@google.com>
3646
3647 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3648 (_initialize_darwin_solib): Don't set
3649 darwin_so_ops.lookup_lib_global_symbol.
3650 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3651 set_gdbarch_iterate_over_objfiles_in_search_order.
3652 (elf_lookup_lib_symbol): Rename to...
3653 (svr4_iterate_over_objfiles_in_search_order): this, and update
3654 to iterate semantics.
3655 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3656 * solib.c (solib_global_lookup): Remove.
3657 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3658 (solib_global_lookup): Remove.
3659 * symtab.c (lookup_global_or_static_symbol): Remove call to
3660 solib_global_lookup.
3661
3662 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3663
3664 * NEWS: Move entries about default MI version now being
3665 version 3, and about the GDB/MI fix for multi-location
3666 breakpoints to the "since GDB 8.3" section.
3667
3668 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3669
3670 GDB 8.3.1 released.
3671
3672 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3673
3674 * NEWS: Mention that Cell/B.E. debugging support was removed.
3675 * MAINTAINERS: Remove spu target.
3676
3677 * config/djgpp/fnchange.lst: Remove entries for removed files.
3678
3679 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3680 spu-multiarch.o, and spu-tdep.o.
3681 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3682 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3683 spu-multiarch.c, and spu-tdep.c.
3684 * spu-linux-nat.c: Remove file.
3685 * spu-multiarch.c: Remove file.
3686 * spu-tdep.c: Remove file.
3687 * spu-tdep.h: Remove file.
3688 * solib-spu.c: Remove file.
3689 * solib-spu.h: Remove file.
3690
3691 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3692 * configure.nat (spu-linux): Remove.
3693 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3694 solib-multiarch.o from gdb_target_obs.
3695 (spu*-*-*): Remove.
3696
3697 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3698 feature flag.
3699 (ppc_linux_no_features): Update.
3700 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3701 Cell/B.E. support.
3702 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3703 (tdesc_powerpc_cell64l): Likewise.
3704 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3705 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3706 Cell/B.E. support.
3707 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3708 Do not include "features/rs6000/powerpc-cell32l.c" or
3709 "features/rs6000/powerpc-cell64l.c".
3710 (ppc_linux_spu_section): Remove.
3711 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3712 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3713 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3714 (ppc_linux_spe_context_lookup): Remove.
3715 (ppc_linux_spe_context_inferior_created): Remove.
3716 (ppc_linux_spe_context_solib_loaded): Remove.
3717 (ppc_linux_spe_context_solib_unloaded): Remove.
3718 (ppc_linux_spe_context): Remove.
3719 (struct ppu2spu_cache): Remove.
3720 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3721 (struct ppu2spu_data): Remove.
3722 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3723 ppu2spu_unwind): Remove.
3724 (ppc_linux_init_abi): Remove Cell/B.E. support.
3725 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3726
3727 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3728 (rs6000/powerpc-cell64l-expedite): Likewise
3729 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3730 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3731 rs6000/powerpc-cell64l.xml.
3732 * features/rs6000/powerpc-cell32l.xml: Remove.
3733 * features/rs6000/powerpc-cell64l.xml: Likewise.
3734 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3735 * features/rs6000/powerpc-cell64l.c: Likewise.
3736 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3737 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3738 * regformats/reg-spu.dat: Remove.
3739
3740 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3741 * corelow.c (struct spuid_list): Remove.
3742 (add_to_spuid_list): Remove.
3743 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3744 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3745 (remote_protocol_features): Remove associated entries.
3746 (_initialize_remote): No longer initialize them.
3747 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3748 * linux-nat.c (SPUFS_MAGIC): Remove.
3749 (linux_proc_xfer_spu): Remove.
3750 (spu_enumerate_spu_ids): Remove.
3751 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3752 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3753 (linux_make_corefile_notes): No longer call it.
3754
3755 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3756 (cooked_write_test): Likewise.
3757
3758 2019-09-20 Tom Tromey <tom@tromey.com>
3759
3760 * NEWS: Mention case-sensitivity of TUI commands.
3761 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3762 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3763 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3764
3765 2019-09-20 Tom Tromey <tom@tromey.com>
3766
3767 * tui/tui-source.c (tui_source_window::set_contents): Use
3768 make_unique_xstrdup.
3769 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3770 make_unique_xstrdup.
3771
3772 2019-09-20 Tom Tromey <tom@tromey.com>
3773
3774 * tui/tui-data.c: Remove separator comments.
3775 * tui/tui-layout.c: Remove separator comments.
3776 * tui/tui-win.c: Remove separator comments.
3777 * tui/tui-wingeneral.c: Remove separator comments.
3778
3779 2019-09-20 Tom Tromey <tom@tromey.com>
3780
3781 * tui/tui.h (strcat_to_buf): Don't declare.
3782 * tui/tui.c (strcat_to_buf): Remove.
3783
3784 2019-09-20 Tom Tromey <tom@tromey.com>
3785
3786 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3787 from "fullname".
3788 * tui/tui-source.c (tui_source_window::set_contents)
3789 (tui_source_window::location_matches_p)
3790 (tui_source_window::maybe_update): Update.
3791
3792 2019-09-20 Tom Tromey <tom@tromey.com>
3793
3794 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3795 Update.
3796 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3797 prefix.
3798 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3799 (tui_data_window::line_from_reg_element_no)
3800 (tui_data_window::first_reg_element_no_inline)
3801 (tui_data_window::show_registers)
3802 (tui_data_window::show_register_group)
3803 (tui_data_window::display_registers_from)
3804 (tui_data_window::display_registers_from_line)
3805 (tui_data_window::first_data_item_displayed)
3806 (tui_data_window::delete_data_content_windows)
3807 (tui_data_window::erase_data_content)
3808 (tui_data_window::do_scroll_vertical)
3809 (tui_data_window::refresh_window)
3810 (tui_data_window::check_register_values): Update.
3811
3812 2019-09-20 Tom Tromey <tom@tromey.com>
3813
3814 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3815 (struct tui_locator_window) <full_name, proc_name>: Now
3816 std::string.
3817 * tui/tui-stack.c (tui_locator_window::make_status_line)
3818 (tui_locator_window::set_locator_fullname)
3819 (tui_locator_window::set_locator_info): Update.
3820 * tui/tui-source.c (tui_source_window::set_contents)
3821 (tui_source_window::showing_source_p): Update.
3822
3823 2019-09-20 Tom Tromey <tom@tromey.com>
3824
3825 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3826 Don't call tui_locator_win_info_ptr.
3827
3828 2019-09-20 Tom Tromey <tom@tromey.com>
3829
3830 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3831
3832 2019-09-20 Tom Tromey <tom@tromey.com>
3833
3834 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3835 height for locator.
3836 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3837 * tui/tui-layout.c (show_source_disasm_command, show_data)
3838 (show_source_or_disasm_and_command): Use 1 as height for locator.
3839
3840 2019-09-20 Tom Tromey <tom@tromey.com>
3841
3842 * tui/tui.c (tui_enable): Update.
3843 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3844 Update.
3845 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3846 Update.
3847 * tui/tui-data.c (win_resized): Now bool.
3848 (tui_win_resized): Return bool.
3849 (tui_set_win_resized_to): Accept a bool.
3850
3851 2019-09-20 Tom Tromey <tom@tromey.com>
3852
3853 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3854 Change type of "refresh_values_only".
3855 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3856 type of "refresh_values_only".
3857
3858 2019-09-20 Tom Tromey <tom@tromey.com>
3859
3860 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3861 std::string.
3862 (tui_disassemble): Add "pos" parameter.
3863 (tui_disasm_window::set_contents): Simplify.
3864
3865 2019-09-20 Tom Tromey <tom@tromey.com>
3866
3867 * tui/tui-winsource.h (struct tui_source_window_base)
3868 <show_source_content>: Now private.
3869 * tui/tui-winsource.c
3870 (tui_source_window_base::show_source_content): Don't handle empty
3871 content case.
3872
3873 2019-09-20 Tom Tromey <tom@tromey.com>
3874
3875 * tui/tui-layout.c (show_source_disasm_command)
3876 (show_source_or_disasm_and_command): Don't call
3877 show_source_content.
3878
3879 2019-09-20 Tom Tromey <tom@tromey.com>
3880
3881 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3882 Declare.
3883 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3884 from tui_make_status_line.
3885 (tui_locator_window::rerender): Update.
3886
3887 2019-09-20 Tom Tromey <tom@tromey.com>
3888
3889 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3890 (tui_locator_window::rerender): Update.
3891
3892 2019-09-20 Tom Tromey <tom@tromey.com>
3893
3894 * tui/tui-winsource.h (struct tui_source_window_base)
3895 <~tui_source_window_base>: Don't declare.
3896 <fullname>: Remove.
3897 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3898 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3899 member.
3900 * tui/tui-source.c (tui_source_window::set_contents): Update.
3901 (tui_source_window::location_matches_p)
3902 (tui_source_window::maybe_update): Update.
3903
3904 2019-09-20 Tom Tromey <tom@tromey.com>
3905
3906 * tui/tui-winsource.h (~tui_source_element): Remove.
3907 (tui_source_element): Update.
3908 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3909 * tui/tui-winsource.c (tui_show_source_line): Update.
3910 * tui/tui-source.c (tui_source_window::set_contents): Update.
3911 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3912
3913 2019-09-20 Tom Tromey <tom@tromey.com>
3914
3915 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3916 declare.
3917 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3918 tui_clear_source_windows_detail.
3919 * tui/tui-winsource.h (struct tui_source_window_base)
3920 <clear_detail>: Don't declare.
3921 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3922 Remove.
3923 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3924
3925 2019-09-20 Tom Tromey <tromey@adacore.com>
3926
3927 PR ada/24919:
3928 * block.c (contained_in): Fix final return value.
3929
3930 2019-09-20 Alan Modra <amodra@gmail.com>
3931
3932 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3933 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3934 (read_indirect_string_from_dwz): Use bfd accessor.
3935 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3936 * machoread.c (macho_symfile_read_all_oso): Likewise.
3937 * solib.c (solib_bfd_open): Likewise.
3938
3939 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3940
3941 * eval.c: Move declaration of overload_resolution to...
3942 * value.h: ...here.
3943
3944 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3945
3946 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3947 * arm-linux-tdep.c: Likewise.
3948 * arm-nbsd-nat.c: Likewise.
3949 * arm-tdep.h: Declare arm_apcs_32.
3950 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3951
3952 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3953
3954 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3955 * dwarf2read.h: Declare dwarf_always_disassemble.
3956
3957 2019-09-19 Tom de Vries <tdevries@suse.de>
3958
3959 PR gdb/25009
3960 * source-cache.c (source_cache::ensure): Catch exception thrown during
3961 construction of the highlighter.
3962
3963 2019-09-18 Alan Modra <amodra@gmail.com>
3964
3965 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3966 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3967 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3968 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3969 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3970 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3971 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3972 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3973 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3974 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3975 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3976 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3977 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3978 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3979 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3980 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3981 * mi/mi-interp.c: Update throughout for bfd section macro and
3982 function changes.
3983 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3984 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3985
3986 2019-09-18 Tom Tromey <tom@tromey.com>
3987
3988 * NEWS: Add entry.
3989 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3990 call rl_initialize.
3991 (tui_enable): Do not call rl_initialize.
3992
3993 2019-09-18 Christian Groessler <chris@groessler.org>
3994
3995 * alpha-linux-nat.c: Include gdbarch.h.
3996
3997 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3998
3999 * ui-file.c: Include cli/cli-style.h.
4000 (term_cli_styling): Remove cli_styling declaration.
4001
4002 2019-09-18 Alan Modra <amodra@gmail.com>
4003
4004 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4005 to bfd_asymbol_section.
4006
4007 2019-09-18 Alan Modra <amodra@gmail.com>
4008
4009 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4010 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4011 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4012
4013 2019-09-18 Alan Modra <amodra@gmail.com>
4014
4015 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4016 * spu-linux-nat.c (spu_bfd_open): Likewise.
4017
4018 2019-09-18 Christian Biesinger <cbiesinger@google.com>
4019
4020 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4021 to bool to match definition in dwarf2read.c.
4022
4023 2019-09-17 Christian Biesinger <cbiesinger@google.com>
4024
4025 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4026 (print_signatures): Likewise.
4027 (trust_pad_over_xvs): Likewise.
4028 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4029 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4030 * arm-linux-nat.c (arm_apcs_32): Likewise.
4031 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4032 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4033 * arm-tdep.c (arm_debug): Likewise.
4034 (arm_apcs_32): Likewise.
4035 * auto-load.c (debug_auto_load): Likewise.
4036 (auto_load_gdb_scripts): Likewise.
4037 (global_auto_load): Likewise.
4038 (auto_load_local_gdbinit): Likewise.
4039 (auto_load_local_gdbinit_loaded): Likewise.
4040 * auto-load.h (global_auto_load): Likewise.
4041 (auto_load_local_gdbinit): Likewise.
4042 (auto_load_local_gdbinit_loaded): Likewise.
4043 * breakpoint.c (disconnected_dprintf): Likewise.
4044 (breakpoint_proceeded): Likewise.
4045 (automatic_hardware_breakpoints): Likewise.
4046 (always_inserted_mode): Likewise.
4047 (target_exact_watchpoints): Likewise.
4048 (_initialize_breakpoint): Update.
4049 * breakpoint.h (target_exact_watchpoints): Change to bool.
4050 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4051 * cli/cli-cmds.c (trace_commands): Likewise.
4052 * cli/cli-cmds.h (trace_commands): Likewise.
4053 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4054 to bool*.
4055 * cli/cli-logging.c (logging_overwrite): Change to bool.
4056 (logging_redirect): Likewise.
4057 (debug_redirect): Likewise.
4058 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4059 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4060 to bool.
4061 <boolean_option_def>: Update.
4062 (struct flag_option_def): Change default type of Context to bool
4063 from int.
4064 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4065 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4066 (get_setshow_command_value_string): Likewise.
4067 * cli/cli-style.c (cli_styling): Change to bool.
4068 (source_styling): Likewise.
4069 * cli/cli-style.h (source_styling): Likewise.
4070 (cli_styling): Likewise.
4071 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4072 to bool.
4073 * command.h (var_types): Update comment.
4074 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4075 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4076 bool.
4077 (debug_compile_cplus_scopes): Likewise.
4078 * compile/compile-internal.h (compile_debug): Likewise.
4079 * compile/compile.c (compile_debug): Likewise.
4080 (struct compile_options) <raw>: Likewise.
4081 * cp-support.c (catch_demangler_crashes): Likewise.
4082 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4083 (usr_cmd_cris_dwarf2_cfi): Likewise.
4084 * csky-tdep.c (csky_debug): Likewise.
4085 * darwin-nat.c (enable_mach_exceptions): Likewise.
4086 * dcache.c (dcache_enabled_p): Likewise.
4087 * defs.h (info_verbose): Likewise.
4088 * demangle.c (demangle): Likewise.
4089 (asm_demangle): Likewise.
4090 * dwarf-index-cache.c (debug_index_cache): Likewise.
4091 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4092 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4093 * dwarf2read.c (check_physname): Likewise.
4094 (use_deprecated_index_sections): Likewise.
4095 (dwarf_always_disassemble): Likewise.
4096 * eval.c (overload_resolution): Likewise.
4097 * event-top.c (set_editing_cmd_var): Likewise.
4098 (exec_done_display_p): Likewise.
4099 * event-top.h (set_editing_cmd_var): Likewise.
4100 (exec_done_display_p): Likewise.
4101 * exec.c (write_files): Likewise.
4102 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4103 (debug_fbsd_nat): Likewise.
4104 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4105 Likewise.
4106 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4107 <backtrace_past_entry> Likewise.
4108 * gdb-demangle.h (demangle): Likewise.
4109 (asm_demangle): Likewise.
4110 * gdb_bfd.c (bfd_sharing): Likewise.
4111 * gdbcore.h (write_files): Likewise.
4112 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4113 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4114 * gdbthread.h (print_thread_events): Likewise.
4115 * gdbtypes.c (opaque_type_resolution): Likewise.
4116 (strict_type_checking): Likewise.
4117 * gnu-nat.c (gnu_debug_flag): Likewise.
4118 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4119 * guile/scm-param.c (pascm_variable): Add boolval.
4120 (add_setshow_generic): Update.
4121 (pascm_param_value): Update.
4122 (pascm_set_param_value_x): Update.
4123 * hppa-tdep.c (hppa_debug): Change to bool..
4124 * infcall.c (may_call_functions_p): Likewise.
4125 (coerce_float_to_double_p): Likewise.
4126 (unwind_on_signal_p): Likewise.
4127 (unwind_on_terminating_exception_p): Likewise.
4128 * infcmd.c (startup_with_shell): Likewise.
4129 * inferior.c (print_inferior_events): Likewise.
4130 * inferior.h (startup_with_shell): Likewise.
4131 (print_inferior_events): Likewise.
4132 * infrun.c (step_stop_if_no_debug): Likewise.
4133 (detach_fork): Likewise.
4134 (debug_displaced): Likewise.
4135 (disable_randomization): Likewise.
4136 (non_stop): Likewise.
4137 (non_stop_1): Likewise.
4138 (observer_mode): Likewise.
4139 (observer_mode_1): Likewise.
4140 (set_observer_mode): Update.
4141 (sched_multi): Change to bool.
4142 * infrun.h (debug_displaced): Likewise.
4143 (sched_multi): Likewise.
4144 (step_stop_if_no_debug): Likewise.
4145 (non_stop): Likewise.
4146 (disable_randomization): Likewise.
4147 * linux-tdep.c (use_coredump_filter): Likewise.
4148 (dump_excluded_mappings): Likewise.
4149 * linux-thread-db.c (auto_load_thread_db): Likewise.
4150 (check_thread_db_on_load): Likewise.
4151 * main.c (captured_main_1): Update.
4152 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4153 xx2_opt, boolean_opt>: Change to bool.
4154 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4155 * maint.c (maintenance_profile_p): Likewise.
4156 (per_command_time): Likewise.
4157 (per_command_space): Likewise.
4158 (per_command_symtab): Likewise.
4159 * memattr.c (inaccessible_by_default): Likewise.
4160 * mi/mi-main.c (mi_async): Likewise.
4161 (mi_async_1): Likewise.
4162 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4163 * nat/fork-inferior.h (startup_with_shell): Likewise.
4164 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4165 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4166 * nios2-tdep.c (nios2_debug): Likewise.
4167 * or1k-tdep.c (or1k_debug): Likewise.
4168 * parse.c (parser_debug): Likewise.
4169 * parser-defs.h (parser_debug): Likewise.
4170 * printcmd.c (print_symbol_filename): Likewise.
4171 * proc-api.c (procfs_trace): Likewise.
4172 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4173 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4174 (set_parameter_value): Update.
4175 (add_setshow_generic): Update.
4176 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4177 to bool*.
4178 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4179 int*.
4180 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4181 * record-btrace.c (record_btrace_target::store_registers): Update.
4182 * record-full.c (record_full_memory_query): Change to bool.
4183 (record_full_stop_at_limit): Likewise.
4184 * record-full.h (record_full_memory_query): Likewise.
4185 * remote-notif.c (notif_debug): Likewise.
4186 * remote-notif.h (notif_debug): Likewise.
4187 * remote.c (use_range_stepping): Likewise.
4188 (interrupt_on_connect): Likewise.
4189 (remote_break): Likewise.
4190 * ser-tcp.c (tcp_auto_retry): Likewise.
4191 * ser-unix.c (serial_hwflow): Likewise.
4192 * skip.c (debug_skip): Likewise.
4193 * solib-aix.c (solib_aix_debug): Likewise.
4194 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4195 (spu_auto_flush_cache_p): Likewise.
4196 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4197 Likewise.
4198 (struct info_print_options) <quiet>: Likewise.
4199 * symfile-debug.c (debug_symfile): Likewise.
4200 * symfile.c (auto_solib_add): Likewise.
4201 (separate_debug_file_debug): Likewise.
4202 * symfile.h (auto_solib_add): Likewise.
4203 (separate_debug_file_debug): Likewise.
4204 * symtab.c (basenames_may_differ): Likewise.
4205 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4206 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4207 (struct info_types_options) <quiet>: Likewise.
4208 * symtab.h (demangle): Likewise.
4209 (basenames_may_differ): Likewise.
4210 * target-dcache.c (stack_cache_enabled_1): Likewise.
4211 (code_cache_enabled_1): Likewise.
4212 * target.c (trust_readonly): Likewise.
4213 (may_write_registers): Likewise.
4214 (may_write_memory): Likewise.
4215 (may_insert_breakpoints): Likewise.
4216 (may_insert_tracepoints): Likewise.
4217 (may_insert_fast_tracepoints): Likewise.
4218 (may_stop): Likewise.
4219 (auto_connect_native_target): Likewise.
4220 (target_stop_and_wait): Update.
4221 (target_async_permitted): Change to bool.
4222 (target_async_permitted_1): Likewise.
4223 (may_write_registers_1): Likewise.
4224 (may_write_memory_1): Likewise.
4225 (may_insert_breakpoints_1): Likewise.
4226 (may_insert_tracepoints_1): Likewise.
4227 (may_insert_fast_tracepoints_1): Likewise.
4228 (may_stop_1): Likewise.
4229 * target.h (target_async_permitted): Likewise.
4230 (may_write_registers): Likewise.
4231 (may_write_memory): Likewise.
4232 (may_insert_breakpoints): Likewise.
4233 (may_insert_tracepoints): Likewise.
4234 (may_insert_fast_tracepoints): Likewise.
4235 (may_stop): Likewise.
4236 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4237 (make_thread_apply_all_options_def_group): Change argument from int*
4238 to bool*.
4239 (thread_apply_all_command): Update.
4240 (print_thread_events): Change to bool.
4241 * top.c (confirm): Likewise.
4242 (command_editing_p): Likewise.
4243 (history_expansion_p): Likewise.
4244 (write_history_p): Likewise.
4245 (info_verbose): Likewise.
4246 * top.h (confirm): Likewise.
4247 (history_expansion_p): Likewise.
4248 * tracepoint.c (disconnected_tracing): Likewise.
4249 (circular_trace_buffer): Likewise.
4250 * typeprint.c (print_methods): Likewise.
4251 (print_typedefs): Likewise.
4252 * utils.c (debug_timestamp): Likewise.
4253 (sevenbit_strings): Likewise.
4254 (pagination_enabled): Likewise.
4255 * utils.h (sevenbit_strings): Likewise.
4256 (pagination_enabled): Likewise.
4257 * valops.c (overload_resolution): Likewise.
4258 * valprint.h (struct value_print_options) <prettyformat_arrays,
4259 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4260 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4261 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4262 Likewise.
4263 * windows-nat.c (new_console): Likewise.
4264 (cygwin_exceptions): Likewise.
4265 (new_group): Likewise.
4266 (debug_exec): Likewise.
4267 (debug_events): Likewise.
4268 (debug_memory): Likewise.
4269 (debug_exceptions): Likewise.
4270 (useshell): Likewise.
4271 * windows-tdep.c (maint_display_all_tib): Likewise.
4272 * xml-support.c (debug_xml): Likewise.
4273
4274 2019-09-17 Mike Gulick <mgulick@mathworks.com>
4275
4276 * source.c (prepare_path_for_appending): New function.
4277 (openp): Make use of new function.
4278 (find_and_open_source): Search for the compilation directory and
4279 source file as a relative path beneath the directory search path.
4280
4281 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4282
4283 * source-cache.c (source_cache::get_line_charpos): Catch
4284 exceptions and return false, this matches the behaviour documented
4285 in the header file.
4286
4287 2019-09-17 Joel Brobecker <brobecker@adacore.com>
4288
4289 * ada-tasks.c (info_task): Remove quoting of the task's name.
4290
4291 2019-09-16 Christian Biesinger <cbiesinger@google.com>
4292
4293 * symfile.c (auto_solib_add): Replace comment with a reference
4294 to the header file.
4295
4296 2019-09-14 Christian Biesinger <cbiesinger@google.com>
4297
4298 * NEWS: Mention that gdb can now be compiled with Python 3
4299 on Windows.
4300
4301 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4302
4303 * maint.c (maint_print_section_data::maint_print_section_data):
4304 Force use of 'float log10 (float)' by casting the argument to
4305 float.
4306
4307 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4308
4309 * maint.c: Add 'cmath' include.
4310 (struct maint_print_section_data): New structure.
4311 (print_section_index): New function.
4312 (print_bfd_section_info): Add header comment, small whitespace
4313 cleanup, and update to call new print_section_index function.
4314 (print_objfile_section_info): Likewise.
4315 (maint_obj_section_from_bfd_section): New function.
4316 (print_bfd_section_info_maybe_relocated): New function.
4317 (maintenance_info_sections): Add header comment, always use
4318 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4319
4320 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4321
4322 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4323 inner scope, add check that the objfile has psymtabs before
4324 checking psymtabs_addrmap.
4325 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4326
4327 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4328
4329 * NEWS: Announce that Ada task names are now shown at more places,
4330 and between quotes (except in info task output).
4331 * gdb/ada-tasks.c (task_to_str): New function.
4332 (display_current_task_id): Call task_to_str.
4333 (task_command_1): Likewise.
4334 (print_ada_task_info): In non-mi mode, Properly align headers and data
4335 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4336
4337 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4338
4339 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4340 prstatus.pr_lwp.pr_info instead of making it up.
4341
4342 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4343
4344 * auto-load.c (auto_load_expand_dir_vars): Update.
4345 * defs.h (gdb_datadir): Change to std::string.
4346 (python_libdir): Likewise.
4347 (relocate_gdb_directory): Change return type to std::string.
4348 * guile/guile.c (gdbscm_data_directory): Update.
4349 (initialize_scheme_side): Update.
4350 * jit.c (jit_reader_dir): Change to std::string.
4351 (jit_reader_load_command): Update.
4352 * main.c (gdb_datadir): Change to std::string.
4353 (python_libdir): Likewise.
4354 (set_gdb_data_directory): Update.
4355 (relocate_path): Change to return std::string.
4356 (relocate_gdb_directory): Change to return std::string.
4357 (relocate_gdbinit_path_maybe_in_datadir): Update.
4358 (captured_main_1): Update.
4359 * python/python.c (do_start_initialization): Update.
4360 * top.c (show_gdb_datadir): Update.
4361 * xml-syscall.c (xml_init_syscalls_info): Update.
4362 (init_syscalls_info): Update.
4363
4364 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4365
4366 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4367 out of get_init_files.
4368 (get_init_files): Update.
4369
4370 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4371
4372 * main.c (get_init_files): Change to use std::string.
4373 (captured_main_1): Update.
4374 (print_gdb_help): Update.
4375
4376 2019-09-11 Ali Tamur <tamur@google.com>
4377
4378 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4379 implementation.
4380
4381 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4382
4383 * dbxread.c (read_dbx_symtab): Update.
4384 * dwarf2read.c (load_partial_dies): Update.
4385 * mdebugread.c (parse_partial_symbols): Update.
4386 (handle_psymbol_enumerators): Update.
4387 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4388 * psymtab.c (add_psymbol_to_bcache): Likewise.
4389 (add_psymbol_to_list): Likewise.
4390 * symtab.c (symbol_set_names): Likewise.
4391 * symtab.h (symbol_set_names): Likewise.
4392 * xcoffread.c (scan_xcoff_symtab): Update.
4393
4394 2019-09-11 Tom Tromey <tom@tromey.com>
4395
4396 * symfile-mem.c (symbol_file_add_from_memory): Use
4397 bfd_set_filename.
4398 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4399 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4400
4401 2019-09-10 Tom Tromey <tromey@adacore.com>
4402
4403 * dwarf-index-write.c (write_psymbols): Extend error message.
4404 (debug_names::insert): Add Ada code.
4405 (debug_names::write_psymbols): Remove Ada check.
4406 (debug_names) <m_string_obstack>: New member.
4407 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4408 (gdb_index_symbol_name_matcher::matches): Remove.
4409 (mapped_index_base::find_name_components_bounds): Add "lang"
4410 parameter.
4411 (mapped_index_base::build_name_components): Also split names
4412 according to Ada syntax.
4413 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4414 type of "match_callback".
4415 (check_match, check_find_bounds_finds)
4416 (dw2_expand_symtabs_matching): Update.
4417 (dw2_debug_names_iterator): Add new constructor.
4418 (dw2_debug_names_map_matching_symbols): New function.
4419 (dw2_debug_names_expand_symtabs_matching): Update.
4420 (dwarf2_debug_names_functions): Use
4421 dw2_debug_names_map_matching_symbols.
4422
4423 2019-09-10 Tom Tromey <tromey@adacore.com>
4424
4425 * dwarf2read.c (dw2_get_file_names_reader): Add the
4426 CU's file name to the results.
4427
4428 2019-09-10 Tom Tromey <tromey@adacore.com>
4429
4430 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4431 map_matching_symbols. Update.
4432 * dwarf2read.c (dw2_map_matching_symbols): Update.
4433 * psymtab.c (match_partial_symbol): Change type; update.
4434 (psym_map_matching_symbols): Likewise.
4435 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4436 type; update.
4437 * symfile.h (struct quick_symbol_functions)
4438 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4439 Remove "match".
4440
4441 2019-09-10 Tom Tromey <tromey@adacore.com>
4442
4443 * psymtab.c (map_block): Remove.
4444 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4445 * symtab.c (iterate_over_symbols_terminated): New function.
4446 * symtab.c (iterate_over_symbols_terminated): Declare.
4447
4448 2019-09-10 Tom Tromey <tromey@adacore.com>
4449
4450 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4451 * language.h (struct language_defn) <la_iterate_over_symbols>:
4452 Return bool.
4453 * symtab.c (iterate_over_symbols): Return bool.
4454 * symtab.h (iterate_over_symbols): Return bool.
4455
4456 2019-09-10 Tom Tromey <tromey@adacore.com>
4457
4458 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4459 (add_nonlocal_symbols): Update.
4460 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4461 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4462 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4463 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4464 Change type of "callback". Remove "data".
4465
4466
4467 2019-09-09 Ali Tamur <tamur@google.com>
4468
4469 * dwarf2read.c (comp_unit_head): Update comment.
4470 (dwarf2_dwo_name): New function declaration.
4471 (dwarf_unit_type_name): New function declaration.
4472 (read_comp_unit_head): Add support for new compilation units,
4473 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4474 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4475 (currently named as "signature") in their header. Also clarify error
4476 messages.
4477 (lookup_dwo_id): New function. Returns the dwo id of the given
4478 compile unit.
4479 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4480 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4481 functions.
4482 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4483 (dwarf2_dwo_name): Get the dwo name if present.
4484 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4485 purposes.
4486
4487 2019-09-09 Tom Tromey <tom@tromey.com>
4488
4489 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4490
4491 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4492
4493 * python/python.c (do_start_initialization): Make progname_copy static,
4494 to avoid a leak report.
4495
4496 2019-09-08 Tom Tromey <tom@tromey.com>
4497
4498 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4499
4500 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
4501
4502 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4503 Change type to gdb::optional<block_enum>.
4504 (dw2_symtab_iter_init): Change block_index parameter type
4505 to gdb::optional<block_enum>.
4506 (dw2_lookup_symbol): Change block_index parameter
4507 type to block_enum.c
4508 (dw2_debug_names_lookup_symbol): Likewise.
4509 * psymtab.c (psym_lookup_symbol): Likewise.
4510 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4511 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4512 Likewise.
4513
4514 2019-09-06 Christian Biesinger <cbiesinger@google.com>
4515
4516 * defs.h (relocate_gdb_directory): Change int to bool in
4517 signature and rename flag to relocatable.
4518 * main.c (relocate_path): Likewise.
4519 (relocate_gdb_directory): Likewise.
4520
4521 2019-09-06 Alan Modra <amodra@gmail.com>
4522
4523 * coffread.c (coff_symfile_read): Constify filename variable.
4524 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4525 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4526 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4527 * solib.c (reload_shared_libraries_1): Likewise.
4528 * symfile.c (reread_symbols): Likewise.
4529 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4530 * solib-darwin.c (darwin_bfd_open): Likewise.
4531 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4532
4533 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4534
4535 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4536 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4537
4538 2019-09-03 Tom Tromey <tromey@adacore.com>
4539
4540 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4541 types.
4542 (has_negatives): Unbias a range type bound.
4543 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4544 * gdbtypes.c (operator==): Handle new field.
4545 (create_range_type): Add "bias" parameter.
4546 (create_static_range_type, resolve_dynamic_range): Update.
4547 * gdbtypes.h (struct range_bounds) <bias>: New member.
4548 (create_range_type): Add bias parameter.
4549 * printcmd.c (print_scalar_formatted): Unbias range types.
4550 * value.c (unpack_long): Unbias range types.
4551 (pack_long): Bias range types.
4552
4553 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4554
4555 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4556 probe arguments.
4557
4558 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4559
4560 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4561 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4562 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4563 (compile_probe_arg): Likewise.
4564 * probe.h (get_argument_count): Likewise.
4565 * solib-svr4.c (solib_event_probe_action): Likewise.
4566 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4567
4568 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4569
4570 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4571 code to here...
4572 (svr4_create_solib_event_breakpoints): ...from here.
4573
4574 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4575
4576 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4577 suffix from warning message.
4578
4579 2019-08-30 Tom Tromey <tom@tromey.com>
4580
4581 * tui/tui-winsource.h (struct tui_source_window_base)
4582 <refresh_all>: Don't declare.
4583 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4584 Remove.
4585 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4586 tui_show_locator_content.
4587 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4588 declare.
4589 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4590 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4591 declare.
4592
4593 2019-08-30 Tom Tromey <tom@tromey.com>
4594
4595 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4596
4597 2019-08-30 Tom Tromey <tom@tromey.com>
4598
4599 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4600 Remove unnecessary forward declarations.
4601
4602 2019-08-30 Tom Tromey <tom@tromey.com>
4603
4604 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4605 rerender.
4606 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4607 tui_show_locator_content.
4608
4609 2019-08-30 Tom Tromey <tom@tromey.com>
4610
4611 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4612 (tui_locator_window::rerender): Rewrite using body of previous
4613 tui_show_locator_content.
4614
4615 2019-08-30 Tom Tromey <tom@tromey.com>
4616
4617 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4618 set_locator_fullname>: New methods.
4619 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4620 Rename from tui_set_locator_fullname.
4621 (tui_locator_window::set_locator_info): Rename from
4622 tui_set_locator_info. Return bool.
4623 (tui_update_locator_fullname, tui_show_frame_info): Update.
4624
4625 2019-08-30 Tom Tromey <tom@tromey.com>
4626
4627 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4628
4629 2019-08-30 Tom Tromey <tom@tromey.com>
4630
4631 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4632 call touchwin.
4633
4634 2019-08-30 Tom Tromey <tom@tromey.com>
4635
4636 * tui/tui-wingeneral.c (box_win): Assume win_info and
4637 win_info->handle cannot be NULL.
4638
4639 2019-08-30 Tom Tromey <tom@tromey.com>
4640
4641 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4642 refresh_window>: Declare.
4643 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4644 resize.
4645 (tui_data_item_window::rerender): Rename from
4646 tui_display_register.
4647 (tui_data_item_window::refresh_window): New method.
4648 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4649 no-op.
4650
4651 2019-08-30 Tom Tromey <tom@tromey.com>
4652
4653 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4654 regs_column_count, current_group>: Move later. Now private.
4655 <get_current_group>: New method.
4656 * tui/tui-regs.c (tui_reg_command): Update.
4657 * tui/tui-layout.c (tui_set_layout): Update.
4658
4659 2019-08-30 Tom Tromey <tom@tromey.com>
4660
4661 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4662 (tui_data_window::rerender): Don't call
4663 check_and_display_highlight_if_needed.
4664 (tui_data_window::refresh_all): Remove call to
4665 erase_data_content.
4666
4667 2019-08-30 Tom Tromey <tom@tromey.com>
4668
4669 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4670 (tui_data_window::display_registers_from)
4671 (tui_data_window::display_reg_element_at_line)
4672 (tui_data_window::display_registers_from_line): Remove checks of
4673 "empty".
4674
4675 2019-08-30 Tom Tromey <tom@tromey.com>
4676
4677 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4678 Don't declare.
4679 * tui/tui-regs.c (tui_data_window::show_registers): Call
4680 rerender.
4681 (tui_data_window::rerender): Rename from display_all_data.
4682 (tui_data_window::rerender): Remove old implementation.
4683
4684 2019-08-30 Tom Tromey <tom@tromey.com>
4685
4686 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4687 text.
4688 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4689
4690 2019-08-29 Bernhard Wodok <barto@gmx.net>
4691 Sergio Durigan Junior <sergiodj@redhat.com>
4692
4693 PR win32/24284
4694 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4695
4696 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4697
4698 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4699 when searching for types.
4700
4701 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4702
4703 * f-lang.c (f_language_defn): Use f_print_typedef.
4704 * f-lang.h (f_print_typedef): Declare.
4705 * f-typeprint.c (f_print_typedef): Define.
4706
4707 2019-08-27 Christian Biesinger <cbiesinger@google.com>
4708
4709 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4710
4711 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4712
4713 * cli/cli-utils.c (info_print_options_defs): Delete.
4714 (make_info_print_options_def_group): Delete.
4715 (extract_info_print_options): Delete.
4716 (info_print_command_completer): Delete.
4717 (info_print_args_help): Add extra parameter, and optionally
4718 include text about -n flag.
4719 * cli/cli-utils.h (struct info_print_options): Delete.
4720 (extract_info_print_options): Delete declaration.
4721 (info_print_command_completer): Delete declaration.
4722 (info_print_args_help): Add extra parameter, extend header
4723 comment.
4724 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4725 search_symbols.
4726 * stack.c (struct info_print_options): New type.
4727 (info_print_options_defs): New file scoped variable.
4728 (make_info_print_options_def_group): New static function.
4729 (info_print_command_completer): New static function.
4730 (info_locals_command): Update to use new local functions.
4731 (info_args_command): Likewise.
4732 (_initialize_stack): Add extra parameter to calls to
4733 info_print_args_help.
4734 * symtab.c (search_symbols): Add extra parameter, use this to
4735 possibly excluse non-debug symbols.
4736 (symtab_symbol_info): Add extra parameter, which is passed on to
4737 search_symbols.
4738 (struct info_print_options): New type.
4739 (info_print_options_defs): New file scoped variable.
4740 (make_info_print_options_def_group): New static function.
4741 (info_print_command_completer): New static function.
4742 (info_variables_command): Update to use local functions, and pass
4743 extra parameter through to symtab_symbol_info.
4744 (info_functions_command): Likewise.
4745 (info_types_command): Pass additional argument through to
4746 symtab_symbol_info.
4747 (rbreak_command): Pass extra argument to search_symbols.
4748 (_initialize_symtab): Add extra arguments for calls to
4749 info_print_args_help, and update help text for 'info variables',
4750 'whereis', and 'info functions' commands.
4751 * symtab.h (search_symbols): Add extra argument to declaration.
4752 * NEWS: Mention new flags.
4753
4754 2019-08-26 Christian Biesinger <cbiesinger@google.com>
4755
4756 * symtab.c (lookup_static_symbol): Call the new function (and move
4757 it down to be next to lookup_global_symbol).
4758 (struct global_sym_lookup_data): Add block_enum member and rename to...
4759 (struct global_or_static_sym_lookup_data): ...this.
4760 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4761 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4762 (lookup_symbol_global_or_static_iterator_cb): ...this.
4763 (lookup_global_or_static_symbol): New function.
4764 (lookup_global_symbol): Call new function.
4765
4766 2019-08-26 Tom de Vries <tdevries@suse.de>
4767
4768 PR c++/24852
4769 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4770 when pc_probe.prob == NULL.
4771
4772 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4773
4774 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4775 variable symbol_linkage to symbol_linkage_.
4776
4777 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4778
4779 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4780 represent whether the symbol is static, dynamic, or we don't
4781 know.
4782
4783 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4784
4785 * gdb/rx-tdep.c (rx_register_names): New.
4786 (rx_register_name): Delete.
4787 (rx_psw_type): Delete.
4788 (rx_fpsw_type): Delete.
4789 (rx_register_type): Delete.
4790 (rx_gdbarch_init): Convert target-descriptions.
4791 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4792 * gdb/features/Makefile: Add rx.xml.
4793 * gdb/features/rx.xml: New.
4794 * gdb/features/rx.c: Generated.
4795 * gdb/NEWS: Mention target description support.
4796
4797 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4798
4799 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4800 *slot_ptr.
4801
4802 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4803
4804 * configure.ac: Don't check for 'dlfcn.h' (moved to
4805 gdbsupport/common.m4).
4806 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4807 'gdbsupport/'.
4808 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4809 * compile/compile-c-support.c: Include
4810 'gdbsupport/gdb-dlfcn.h'.
4811 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4812 * gdb-dlfcn.c: Move to...
4813 * gdbsupport/gdb-dlfcn.c: ... here.
4814 * gdb-dlfcn.h: Move to...
4815 * gdbsupport/gdb-dlfcn.h: ... here.
4816
4817 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4818
4819 * nios2-tdep.c (struct reg_value): Improve comments. Make
4820 the offset field signed.
4821
4822 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4823
4824 * python/lib/gdb/__init__.py (_execute_file): New function.
4825 * python/python.c (python_run_simple_file): Call gdb._execute_file
4826 on Windows.
4827
4828 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4829
4830 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4831 all uses as this was never set to anything but a zero value.
4832
4833 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4834
4835 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4836
4837 2019-08-21 Christian Biesinger <cbiesinger@google.com>
4838
4839 * tui/tui-data.h (tui_gen_win_info): Add an =default
4840 move constructor, required by some GCC versions.
4841
4842 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
4843
4844 * go32-nat.c (go32_sysinfo): Add hygon_p.
4845
4846 2019-08-20 Tom Tromey <tom@tromey.com>
4847
4848 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4849 line_from_reg_element_no, first_reg_element_no_inline,
4850 display_all_data, delete_data_content_windows,
4851 erase_data_content>: Now private.
4852
4853 2019-08-20 Tom Tromey <tom@tromey.com>
4854
4855 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4856 (tui_unhighlight_win, tui_highlight_win)
4857 (tui_win_info::make_window): Update.
4858 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4859
4860 2019-08-20 Tom Tromey <tom@tromey.com>
4861
4862 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4863 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4864 (MAX_PID_WIDTH): Move to tui-stack.c.
4865 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4866 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4867 (MAX_PID_WIDTH): Move from tui-data.h.
4868
4869 2019-08-20 Tom Tromey <tom@tromey.com>
4870
4871 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4872 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4873 (box_win): Update.
4874 (tui_gen_win_info::make_window): Rename from tui_make_window.
4875 (tui_win_info::make_window): New method.
4876 (tui_gen_win_info::make_visible): Update.
4877 * tui/tui-source.c (tui_source_window::set_contents): Update.
4878 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4879 (tui_data_window::display_registers_from): Update.
4880 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4881 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4882 Declare.
4883 <can_box>: Remove.
4884 <title>: Remove.
4885 (struct tui_win_info) <make_window>: Declare.
4886 <can_box>: Now virtual.
4887 <title>: New member.
4888 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4889 * tui/tui-command.c (tui_cmd_window::resize): Update.
4890
4891 2019-08-20 Tom Tromey <tom@tromey.com>
4892
4893 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4894 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4895 (tui_data_window::check_register_values): Update.
4896
4897 2019-08-20 Tom Tromey <tom@tromey.com>
4898
4899 * tui/tui-regs.h (struct tui_data_window): Use
4900 DISABLE_COPY_AND_ASSIGN.
4901 <regs_content>: Change type, removing unique_ptr.
4902 <tui_data_window>: Add move constructor.
4903 * tui/tui-regs.c (tui_data_window::show_registers)
4904 (tui_data_window::show_register_group)
4905 (tui_data_window::display_registers_from)
4906 (tui_data_window::display_registers_from)
4907 (tui_data_window::first_data_item_displayed)
4908 (tui_data_window::delete_data_content_windows)
4909 (tui_data_window::rerender, tui_data_window::refresh_window)
4910 (tui_data_window::check_register_values): Update.
4911
4912 2019-08-20 Tom Tromey <tom@tromey.com>
4913
4914 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4915 show_register_group>: Declare.
4916 (tui_show_register_group): Don't declare.
4917 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4918 tui_show_registers.
4919 (tui_data_window::show_register_group): Rename from
4920 tui_show_register_group.
4921 (tui_data_window::check_register_values, tui_reg_command):
4922 Update.
4923 * tui/tui-layout.c (tui_set_layout): Update.
4924
4925 2019-08-20 Tom Tromey <tom@tromey.com>
4926
4927 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4928 Declare.
4929 (tui_check_register_values): Don't declare.
4930 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4931 from tui_check_register_values.
4932 * tui/tui-hooks.c (tui_register_changed): Update.
4933
4934 2019-08-20 Tom Tromey <tom@tromey.com>
4935
4936 * tui/tui-regs.c (tui_reg_layout): Move later.
4937 (tui_show_registers): Don't enable TUI mode or change layout.
4938
4939 2019-08-20 Tom Tromey <tom@tromey.com>
4940
4941 * tui/tui-regs.h (struct tui_data_item_window)
4942 <~tui_data_item_window>: Remove.
4943 <content>: Now a unique_xmalloc_ptr.
4944 * tui/tui-regs.c (tui_register_format): Return a
4945 unique_xmalloc_ptr.
4946 (tui_get_register): Update.
4947 (~tui_data_item_window): Remove.
4948 (tui_data_window::display_registers_from, tui_display_register):
4949 Update.
4950 * tui/tui-io.h (tui_expand_tabs): Update.
4951 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4952 Remove "col" parameter.
4953
4954 2019-08-20 Tom Tromey <tom@tromey.com>
4955
4956 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4957 field.
4958 * tui/tui-regs.c (~tui_data_item_window): Update.
4959
4960 2019-08-20 Tom Tromey <tom@tromey.com>
4961
4962 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4963 earlier.
4964
4965 2019-08-20 Tom Tromey <tom@tromey.com>
4966
4967 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4968
4969 2019-08-20 Tom Tromey <tom@tromey.com>
4970
4971 * tui/tui-source.h (struct tui_source_window): Update.
4972 * tui/tui-regs.c (tui_show_registers): Update.
4973 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4974 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4975 (NO_REGS_STRING): Remove defines.
4976
4977 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
4978
4979 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4980 unnecessary thread walk if remote doesn't support the packet.
4981
4982 2019-08-19 Tom Tromey <tromey@adacore.com>
4983
4984 * python/py-value.c (value_has_field): Fix indentation.
4985
4986 2019-08-19 Tom Tromey <tromey@adacore.com>
4987
4988 * printcmd.c (do_one_display, info_display_command): Update.
4989 * block.h (contained_in): Return bool. Add allow_nested
4990 parameter.
4991 * block.c (contained_in): Return bool. Add allow_nested
4992 parameter.
4993
4994 2019-08-19 Tom Tromey <tom@tromey.com>
4995
4996 * configure: Rebuild.
4997 * configure.ac: Disallow the combination of -static-libstdc++ and
4998 source highlight.
4999 * source-cache.c (get_language_name): Handle rust.
5000 (source_cache::get_source_lines): Ignore highlighting exceptions.
5001
5002 2019-08-16 Tom Tromey <tom@tromey.com>
5003
5004 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5005 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5006 (struct tui_source_window_base) <make_visible, refresh_window,
5007 resize>: Remove methods.
5008 <execution_info>: Remove field.
5009 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5010 (tui_show_source_line, tui_source_window_base)
5011 (~tui_source_window_base): Update.
5012 (tui_source_window_base::resize)
5013 (tui_source_window_base::make_visible)
5014 (tui_source_window_base::refresh_window): Remove.
5015 (tui_source_window_base::update_exec_info): Update.
5016 * tui/tui-source.c (tui_source_window::set_contents): Update.
5017 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5018
5019 2019-08-16 Tom Tromey <tom@tromey.com>
5020
5021 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5022 deprecated_query_hook.
5023
5024 2019-08-16 Tom Tromey <tom@tromey.com>
5025
5026 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5027 (tui_update_source_windows_with_line): Update.
5028 * tui/tui-source.h (struct tui_source_window)
5029 <show_symtab_source>: Declare.
5030 (tui_show_symtab_source): Don't declare.
5031 * tui/tui-source.c (tui_show_symtab_source): Rename from
5032 tui_show_symtab_source.
5033
5034 2019-08-16 Tom Tromey <tom@tromey.com>
5035
5036 * tui/tui-winsource.h (struct tui_source_window_base)
5037 <set_contents>: Declare.
5038 * tui/tui-winsource.c
5039 (tui_source_window_base::update_source_window_as_is): Update.
5040 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5041 Declare.
5042 (tui_set_source_content): Don't declare.
5043 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5044 tui_set_source_content.
5045 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5046 Declare.
5047 (tui_set_disassem_content): Don't declare.
5048 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5049 tui_set_disassem_content.
5050
5051 2019-08-16 Tom Tromey <tom@tromey.com>
5052
5053 * tui/tui-winsource.h (struct tui_source_window_base)
5054 <update_breakpoint_info>: Declare.
5055 (tui_update_breakpoint_info): Don't declare.
5056 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5057 (tui_update_all_breakpoint_info): Update.
5058 (tui_source_window_base::update_breakpoint_info): Rename from
5059 tui_update_breakpoint_info.
5060 (tui_source_window_base::update_exec_info): Update.
5061
5062 2019-08-16 Tom Tromey <tom@tromey.com>
5063
5064 * tui/tui-winsource.h (struct tui_source_window_base)
5065 <update_source_window>: Declare.
5066 (tui_update_source_window): Don't declare.
5067 * tui/tui-winsource.c
5068 (tui_source_window_base::update_source_window): Rename from
5069 tui_update_source_window.
5070 (tui_source_window_base::rerender): Update.
5071 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5072 * tui/tui-disasm.c (tui_show_disassem)
5073 (tui_show_disassem_and_update_source)
5074 (tui_disasm_window::maybe_update): Update.
5075
5076 2019-08-16 Tom Tromey <tom@tromey.com>
5077
5078 * tui/tui-winsource.h (struct tui_source_window_base)
5079 <update_source_window_as_is>: Declare.
5080 (tui_update_source_window_as_is): Don't declare.
5081 * tui/tui-winsource.c (tui_update_source_window): Update
5082 (tui_source_window_base::update_source_window_as_is): Rename from
5083 tui_update_source_window_as_is.
5084 (tui_source_window_base::refill): Update.
5085 * tui/tui-source.c (tui_show_symtab_source): Update.
5086 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5087 Update.
5088
5089 2019-08-16 Tom Tromey <tom@tromey.com>
5090
5091 * tui/tui-winsource.h (tui_update_source_window)
5092 (tui_update_source_window_as_is): Remove "noerror" parameter.
5093 * tui/tui-winsource.c (tui_update_source_window)
5094 (tui_update_source_window_as_is): Remove "noerror" parameter.
5095 (tui_update_source_windows_with_addr)
5096 (tui_update_source_windows_with_line)
5097 (tui_source_window_base::rerender)
5098 (tui_source_window_base::refill): Update.
5099 * tui/tui-source.h (tui_set_source_content)
5100 (tui_show_symtab_source): Remove "noerror" parameter.
5101 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5102 parameter.
5103 (tui_show_symtab_source): Likewise.
5104 (tui_source_window::maybe_update): Update.
5105 * tui/tui-disasm.c (tui_show_disassem)
5106 (tui_show_disassem_and_update_source)
5107 (tui_disasm_window::do_scroll_vertical)
5108 (tui_disasm_window::maybe_update): Update.
5109
5110 2019-08-16 Tom Tromey <tom@tromey.com>
5111
5112 * tui/tui.c (tui_is_window_visible): Update.
5113 * tui/tui-wingeneral.c (tui_make_window)
5114 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5115 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5116 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5117 (tui_set_win_height_command, parse_scrolling_args): Update.
5118 * tui/tui-source.c (tui_source_window::style_changed): Update.
5119 * tui/tui-regs.c (tui_show_registers)
5120 (tui_data_window::first_data_item_displayed)
5121 (tui_data_window::delete_data_content_windows)
5122 (tui_check_register_values, tui_reg_command): Update.
5123 * tui/tui-disasm.c (tui_show_disassem): Update.
5124 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5125 method.
5126 <is_visible>: Remove field.
5127 * tui/tui-data.c (tui_next_win, tui_prev_win)
5128 (tui_delete_invisible_windows): Update.
5129
5130 2019-08-16 Tom Tromey <tom@tromey.com>
5131
5132 * tui/tui-winsource.h (struct tui_source_window_base)
5133 <m_has_locator>: Remove.
5134 * tui/tui-layout.c (show_source_disasm_command, show_data)
5135 (show_source_or_disasm_and_command): Update.
5136
5137 2019-08-16 Alan Hayward <alan.hayward@arm.com>
5138
5139 * NEWS (Other MI changes): New subsection.
5140 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5141 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5142 * arch-utils.c (default_get_pc_address_flags): New function.
5143 * arch-utils.h (default_get_pc_address_flags): New declaration.
5144 * gdbarch.sh: Add get_pc_address_flags.
5145 * gdbarch.c: Regenerate.
5146 * gdbarch.h: Likewise.
5147 * stack.c (print_pc): New function.
5148 (print_frame_info) (print_frame): Call print_pc.
5149
5150 2019-08-16 Tom de Vries <tdevries@suse.de>
5151
5152 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5153 print_objfile_section_info.
5154
5155 2019-08-15 Tom Tromey <tom@tromey.com>
5156
5157 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5158 calling update_cmdwin_start_line.
5159 * tui/tui-winsource.h (struct tui_source_window_base)
5160 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5161 <rerender>: Declare.
5162 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5163 Call rerender.
5164 (tui_source_window_base::set_new_height): Remove.
5165 (tui_source_window_base::rerender): Rename from
5166 do_make_visible_with_new_height.
5167 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5168 resize method.
5169 (tui_win_info::make_invisible_and_set_new_height)
5170 (tui_win_info::make_visible_with_new_height): Remove.
5171 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5172 Declare.
5173 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5174 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5175 do_make_visible_with_new_height>: Don't declare.
5176 <rerender>: Declare.
5177 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5178 set_new_height.
5179 (tui_data_window::do_make_visible_with_new_height): Remove.
5180 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5181 call tui_show_locator_content.
5182 (tui_gen_win_info::resize): Call rerender.
5183 (show_source_or_disasm_and_command): Don't call
5184 tui_show_locator_content.
5185 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5186 method.
5187 (struct tui_win_info) <rerender>: Declare.
5188 <set_new_height, make_invisible_and_set_new_height,
5189 make_visible_with_new_height>: Don't declare.
5190 * tui/tui-data.c (tui_win_list::rerender): New method.
5191 * tui/tui-command.h (struct tui_cmd_window)
5192 <do_make_visible_with_new_height>: Don't declare.
5193 * tui/tui-command.c
5194 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5195
5196 2019-08-15 Tom Tromey <tromey@adacore.com>
5197
5198 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5199 * ada-lang.c (ada_enum_name): Likewise.
5200
5201 2019-08-15 Christian Biesinger <cbiesinger@google.com>
5202
5203 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5204 leading underscore.
5205 (GdbOutputErrorFile): Likewise.
5206 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5207 accordingly.
5208 (execute_unwinders): Rename to have a leading underscore.
5209 (auto_load_packages): Likewise.
5210 (global scope): Adjust call to auto_load_packages accordingly.
5211 (GdbSetPythonDirectory): Likewise.
5212 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5213 instead of execute_unwinders.
5214
5215 2019-08-15 Tom Tromey <tom@tromey.com>
5216
5217 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5218 (show_data): Don't change window visibility.
5219 (tui_gen_win_info::resize): Remove special case for command
5220 window. Use wresize, when available.
5221 (show_source_or_disasm_and_command): Don't change window
5222 visibility.
5223 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5224 <make_visible>: New method.
5225 * tui/tui-command.c (tui_cmd_window::resize): New method.
5226
5227 2019-08-15 Tom Tromey <tom@tromey.com>
5228
5229 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5230 (struct tui_source_windows): New.
5231 * tui/tui-winsource.c (tui_display_main): Update.
5232 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5233 (new_height_ok, parse_scrolling_args): Update.
5234 * tui/tui-layout.c (show_layout, show_data): Update.
5235 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5236 (tui_add_to_source_windows): Don't declare.
5237 * tui/tui-data.c (source_windows, tui_source_windows)
5238 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5239
5240 2019-08-15 Tom Tromey <tom@tromey.com>
5241
5242 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5243 Rename from reset.
5244 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5245 * tui/tui-layout.c (show_source_disasm_command, show_data):
5246 Update.
5247 (tui_gen_win_info::resize): Rename.
5248 (show_source_or_disasm_and_command): Update.
5249 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5250 reset.
5251
5252 2019-08-15 Tom Tromey <tom@tromey.com>
5253
5254 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5255 * tui/tui-interp.c (tui_interp::init): Don't call
5256 tui_initialize_static_data.
5257 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5258
5259 2019-08-15 Tom Tromey <tom@tromey.com>
5260
5261 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5262 examine tui_win_list.
5263
5264 2019-08-15 Tom Tromey <tom@tromey.com>
5265
5266 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5267 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5268 tui_clear_source_content.
5269 (tui_clear_source_content): Remove.
5270 (tui_source_window_base::do_erase_source_content): Hoist call to
5271 content.clear().
5272 * tui/tui-stack.c (tui_show_frame_info): Don't call
5273 tui_clear_source_content.
5274
5275 2019-08-15 Tom Tromey <tom@tromey.com>
5276
5277 * tui/tui-winsource.h (struct tui_source_window_base)
5278 <do_erase_source_content>: New method.
5279 <erase_source_content>: New method.
5280 (tui_erase_source_content): Don't declare.
5281 * tui/tui-winsource.c (tui_clear_source_content): Update.
5282 (tui_source_window_base::do_erase_source_content): Rename from
5283 tui_erase_source_content.
5284 (tui_source_window_base::show_source_content): Update.
5285 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5286 * tui/tui-source.h (struct tui_source_window)
5287 <erase_source_content>: New method.
5288 * tui/tui-disasm.h (struct tui_disasm_window)
5289 <erase_source_content>: New method.
5290
5291 2019-08-15 Tom Tromey <tom@tromey.com>
5292
5293 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5294 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5295 constructor.
5296 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5297 * tui/tui-source.c (tui_set_source_content): Update.
5298 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5299
5300 2019-08-15 Tom Tromey <tom@tromey.com>
5301
5302 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5303 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5304 tui-source.c.
5305 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5306 Declare.
5307 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5308 method.
5309 (tui_source_window::maybe_update): Update.
5310
5311 2019-08-15 Tom Tromey <tom@tromey.com>
5312
5313 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5314 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5315 tui-disasm.c.
5316 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5317 Declare.
5318 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5319 method.
5320 (tui_disasm_window::maybe_update): Update.
5321
5322 2019-08-15 Tom Tromey <tom@tromey.com>
5323
5324 * tui/tui-winsource.h (struct tui_source_window_base)
5325 <maybe_update>: Declare.
5326 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5327 method.
5328 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5329 Declare.
5330 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5331 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5332 Declare.
5333 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5334
5335 2019-08-15 Tom Tromey <tom@tromey.com>
5336
5337 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5338
5339 2019-08-15 Tom Tromey <tom@tromey.com>
5340
5341 * tui/tui-wingeneral.c: Include tui-stack.h.
5342 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5343 (struct tui_locator_window): Move from tui-data.h.
5344 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5345 (tui_initialize_static_data): Move from tui-data.c.
5346 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5347 (struct tui_locator_window): Move to tui-stack.c.
5348 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5349 (tui_initialize_static_data): Move to tui-stack.c.
5350
5351 2019-08-15 Tom Tromey <tom@tromey.com>
5352
5353 * tui/tui-layout.c (show_source_disasm_command)
5354 (show_source_or_disasm_and_command): Use make_visible method, not
5355 tui_make_window.
5356 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5357 Remove.
5358
5359 2019-08-15 Tom Tromey <tom@tromey.com>
5360
5361 * tui/tui-wingeneral.h (tui_make_window): Update.
5362 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5363 parameter.
5364 (tui_gen_win_info::make_visible): Update.
5365 * tui/tui-regs.c (tui_data_window::display_registers_from):
5366 Update.
5367 * tui/tui-layout.c (show_source_disasm_command)
5368 (show_source_or_disasm_and_command): Update.
5369 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5370 (enum tui_box): Remove.
5371 (struct tui_win_info) <can_box>: New method.
5372 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5373 method.
5374
5375 2019-08-15 Tom de Vries <tdevries@suse.de>
5376
5377 * linux-nat-trad.c: Include gdbarch.h.
5378
5379 2019-08-14 Alan Hayward <alan.hayward@arm.com>
5380
5381 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5382 register sizes.
5383
5384 2019-08-14 Tom Tromey <tromey@adacore.com>
5385
5386 * darwin-nat.c: Include gdbarch.h.
5387 * darwin-nat-info.c: Include gdbarch.h.
5388
5389 2019-08-13 Tom Tromey <tom@tromey.com>
5390
5391 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5392 Remove.
5393 * tui/tui-data.c (tui_initialize_static_data): Update.
5394
5395 2019-08-13 Tom Tromey <tom@tromey.com>
5396
5397 * tui/tui-winsource.h (struct tui_exec_info_window)
5398 <~tui_exec_info_window, maybe_allocate_content, get_content,
5399 m_content>: Remove.
5400 (struct tui_source_window_base) <set_exec_info_content,
5401 show_exec_info_content>: Don't declare.
5402 * tui/tui-winsource.c
5403 (tui_exec_info_window::maybe_allocate_content): Remove.
5404 (tui_source_window_base::update_exec_info): Rename from
5405 set_exec_info_content.
5406 (tui_source_window_base::show_exec_info_content)
5407 (tui_source_window_base::update_exec_info): Remove.
5408
5409 2019-08-13 Tom Tromey <tom@tromey.com>
5410
5411 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5412 declare.
5413 * tui/tui-winsource.c (tui_update_source_window_as_is)
5414 (tui_update_source_windows_with_addr, tui_erase_source_content):
5415 Update.
5416 (tui_clear_exec_info_content): Remove.
5417
5418 2019-08-13 Tom Tromey <tom@tromey.com>
5419
5420 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5421 declare.
5422 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5423 call tui_erase_exec_info_content.
5424 (tui_clear_exec_info_content): Rename from
5425 tui_erase_exec_info_content.
5426 (tui_clear_exec_info_content): Delete.
5427
5428 2019-08-13 Tom Tromey <tom@tromey.com>
5429
5430 * tui/tui-winsource.h (struct tui_source_window_base)
5431 <show_exec_info_content>: Declare.
5432 (tui_show_exec_info_content): Don't declare.
5433 * tui/tui-winsource.c
5434 (tui_source_window_base::show_exec_info_content): Rename from
5435 tui_show_exec_info_content.
5436 (tui_source_window_base::update_exec_info): Update.
5437
5438 2019-08-13 Tom Tromey <tom@tromey.com>
5439
5440 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5441 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5442 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5443 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5444 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5445 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5446 ... here.
5447
5448 2019-08-13 Tom Tromey <tom@tromey.com>
5449
5450 * tui/tui-winsource.h (struct tui_source_window_base)
5451 <update_exec_info>: Declare.
5452 (tui_update_exec_info): Don't declare.
5453 * tui/tui-winsource.c (tui_update_source_window_as_is)
5454 (tui_source_window_base::refresh_all)
5455 (tui_update_all_breakpoint_info): Update.
5456 (tui_source_window_base::update_exec_info): Rename from
5457 tui_update_exec_info.
5458 * tui/tui-stack.c (tui_show_frame_info): Update.
5459
5460 2019-08-13 Tom Tromey <tom@tromey.com>
5461
5462 * tui/tui-winsource.h (struct tui_source_window_base)
5463 <set_exec_info_content>: Declare.
5464 (tui_set_exec_info_content): Don't declare.
5465 * tui/tui-winsource.c
5466 (tui_source_window_base::set_exec_info_content): Rename from
5467 tui_set_exec_info_content.
5468 (tui_update_exec_info): Update.
5469
5470 2019-08-13 Tom Tromey <tom@tromey.com>
5471
5472 * tui/tui-winsource.h (struct tui_source_window_base)
5473 <show_source_content>: Declare.
5474 (tui_show_source_content): Don't declare.
5475 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5476 (tui_source_window_base::show_source_content): Rename from
5477 tui_show_source_content.
5478 (tui_source_window_base::refresh_all): Update.
5479 * tui/tui-layout.c (show_source_disasm_command)
5480 (show_source_or_disasm_and_command): Update.
5481
5482 2019-08-13 Tom Tromey <tom@tromey.com>
5483
5484 * tui/tui-winsource.c (tui_erase_source_content)
5485 (tui_show_source_content, tui_source_window_base::refresh_all):
5486 Update.
5487 * tui/tui-wingeneral.h
5488 (tui_check_and_display_highlight_if_needed): Don't declare.
5489 * tui/tui-wingeneral.c
5490 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5491 check_and_display_highlight_if_needed.
5492 * tui/tui-win.c (tui_rehighlight_all)
5493 (tui_win_info::make_visible_with_new_height): Update.
5494 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5495 (tui_data_window::erase_data_content)
5496 (tui_data_window::display_all_data): Update.
5497 * tui/tui-data.h (struct tui_win_info)
5498 <check_and_display_highlight_if_needed>: Declare.
5499
5500 2019-08-13 Tom Tromey <tom@tromey.com>
5501
5502 * tui/tui-win.c (tui_resize_all): Call
5503 tui_delete_invisible_windows.
5504 * tui/tui-layout.c (show_layout): Call
5505 tui_delete_invisible_windows.
5506 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5507 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5508
5509 2019-08-13 Tom Tromey <tom@tromey.com>
5510
5511 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5512 tui_add_win_to_layout.
5513
5514 2019-08-13 Tom Tromey <tom@tromey.com>
5515
5516 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5517 * tui/tui-layout.c (tui_default_win_height): Now static.
5518
5519 2019-08-13 Tom Tromey <tom@tromey.com>
5520
5521 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5522 single switch.
5523 (show_source_disasm_command, show_source_or_disasm_and_command):
5524 Don't check current layout.
5525
5526 2019-08-13 Tom Tromey <tom@tromey.com>
5527
5528 * tui/tui-wingeneral.c (make_all_visible): Remove.
5529 (tui_make_all_invisible): Simplify.
5530 * tui/tui-layout.c (tui_make_all_invisible): Move from
5531 tui-wingeneral.c; simplify.
5532 (show_layout): Hoist call to tui_make_all_invisible.
5533 (show_data): Don't call tui_make_all_invisible.
5534
5535 2019-08-13 Tom Tromey <tom@tromey.com>
5536
5537 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5538 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5539
5540 2019-08-13 Tom Tromey <tom@tromey.com>
5541
5542 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5543 tui-data.c.
5544 (show_source_disasm_command, show_data)
5545 (show_source_or_disasm_and_command): Don't use
5546 tui_set_current_layout_to.
5547 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5548 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5549 tui-layout.c.
5550 (tui_set_current_layout_to): Remove.
5551
5552 2019-08-13 Tom Tromey <tom@tromey.com>
5553
5554 * tui/tui-layout.c (tui_set_layout): Update.
5555 * tui/tui-data.h (struct tui_layout_def): Remove.
5556 (tui_layout_def): Don't declare.
5557 * tui/tui-data.c (layout_def): Remove.
5558 (tui_layout_def): Remove.
5559
5560 2019-08-13 Tom Tromey <tom@tromey.com>
5561
5562 * tui/tui-winsource.h (struct tui_source_window_base)
5563 <clear_detail>: No longer "override".
5564 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5565 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5566 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5567 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5568 Remove.
5569 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5570
5571 2019-08-13 Tom Tromey <tromey@adacore.com>
5572
5573 * tracepoint.c: Don't include readline.h or history.h.
5574
5575 2019-08-12 Tom Tromey <tom@tromey.com>
5576
5577 * configure: Rebuild.
5578 * configure.ac: Check for readline 7.
5579 * NEWS: Mention readline 7 requirement.
5580 * README: Update.
5581
5582 2019-08-12 Tom Tromey <tom@tromey.com>
5583
5584 * mingw-hdep.c (gdb_select): Remove readline hack.
5585
5586 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5587
5588 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5589 when the function fails.
5590
5591 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5592
5593 * s390-tdep.c (s390_type_align): New function.
5594 (s390_gdbarch_init): Set it as type_align gdbarch method.
5595
5596 2019-08-09 Tom de Vries <tdevries@suse.de>
5597
5598 PR gdb/24591
5599 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5600 pc_low with relocation offset.
5601
5602 2019-08-07 Tom Tromey <tromey@adacore.com>
5603
5604 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5605 (print_frame_args): Update.
5606 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5607 Update.
5608 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5609 * frame.h (struct frame_arg): Add initializers.
5610 <error>: Now a unique_xmalloc_ptr.
5611
5612 2019-08-07 Alan Hayward <alan.hayward@arm.com>
5613
5614 * NEWS: Expand the Pointer Authentication entry.
5615 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5616 (aarch64_frame_unmask_lr): ... to this.
5617 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5618 Call aarch64_frame_unmask_lr.
5619 * frame.c (struct frame_info): Add "masked" variable.
5620 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5621 (fprint_frame): Check for masked pc.
5622 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5623 declarations.
5624 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5625 * stack.c (print_frame): Check for masked pc.
5626
5627 2019-08-06 Tom Tromey <tom@tromey.com>
5628
5629 * stabsread.c (patch_block_stabs, read_one_struct_field)
5630 (read_enum_type): Use obstack_strndup.
5631 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5632 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5633 * dwarf2read.c (guess_full_die_structure_name)
5634 (anonymous_struct_prefix): Use obstack_strndup.
5635 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5636 * c-exp.y (yylex): Use obstack_strndup.
5637 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5638 (write_var_or_type): Use obstack_strndup.
5639
5640 2019-08-06 Tom Tromey <tom@tromey.com>
5641
5642 * symfile.c (reread_symbols): Use obstack_strdup.
5643 * stabsread.c (read_type): Use obstack_strdup.
5644 * gdb_obstack.h (obstack_strdup): New overload.
5645 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5646 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5647 (dwarf2_canonicalize_name): Use obstack_strdup.
5648 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5649 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5650 Use obstack_strdup.
5651
5652 2019-08-06 Tom Tromey <tom@tromey.com>
5653
5654 * gdb_obstack.h (obstack_strdup): Define.
5655 * gdb_obstack.c (obstack_strdup): Don't define.
5656
5657 2019-08-06 Tom Tromey <tom@tromey.com>
5658
5659 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5660 obstack_strdup.
5661 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5662 obstack_strdup.
5663 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5664 * stabsread.c (common_block_start): Use obstack_strdup.
5665 * objfiles.c (set_objfile_main_name, objfile): Use
5666 obstack_strdup.
5667 * namespace.c (add_using_directive): Use obstack_strdup.
5668 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5669 * jit.c (finalize_symtab): Use obstack_strdup.
5670 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5671 (guess_partial_die_structure_name, partial_die_info::fixup)
5672 (dwarf2_name): Use obstack_strdup.
5673 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5674 obstack_strdup.
5675 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5676 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5677 obstack_strdup.
5678 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5679
5680 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5681
5682 * unittests/help-doc-selftests.c: New file.
5683 * Makefile.in: Add the new file.
5684
5685 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5686
5687 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5688 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5689 the full first line, except when FOR_VALUE_PREFIX. In this case,
5690 the trailing '.' is not output, and the first character is uppercased.
5691 (print_help_for_command): Update call to print_doc_line.
5692 (print_doc_of_command): Likewise.
5693 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5694 * cli/cli-option.c (append_indented_doc): Do not append newline.
5695 (build_help_option): Append newline after first appended_indented_doc
5696 only if a second call is done.
5697 (build_help): Append 2 new lines before each option, except the first
5698 one.
5699 * compile/compile.c (_initialize_compile): Add new lines after
5700 %OPTIONS%, when not at the end of the help.
5701 Change help doc or code
5702 producing the help doc to respect the invariants.
5703 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5704 Also removed the new line after 'Options:', as all other commands
5705 do not put an empty line between 'Options:' and the first option.
5706 * printcmd.c (_initialize_printcmd): Likewise.
5707 * stack.c (_initialize_stack): Likewise.
5708 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5709 incorrectly telling COMMAND is optional.
5710 * ada-lang.c (_initialize_ada_language): Change help doc or code
5711 producing the help doc to respect the invariants.
5712 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5713 * breakpoint.c (_initialize_breakpoint): Likewise.
5714 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5715 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5716 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5717 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5718 _initialize_cli_style): Likewise.
5719 * corelow.c (core_target_info): Likewise.
5720 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5721 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5722 * filesystem.c (_initialize_filesystem): Likewise.
5723 * frame.c (_initialize_frame): Likewise.
5724 * gnu-nat.c (add_task_commands): Likewise.
5725 * infcall.c (_initialize_infcall): Likewise.
5726 * infcmd.c (_initialize_infcmd): Likewise.
5727 * interps.c (_initialize_interpreter): Likewise.
5728 * language.c (_initialize_language): Likewise.
5729 * linux-fork.c (_initialize_linux_fork): Likewise.
5730 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5731 * maint.c (_initialize_maint_cmds): Likewise.
5732 * memattr.c (_initialize_mem): Likewise.
5733 * printcmd.c (_initialize_printcmd): Likewise.
5734 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5735 _RegEx): Likewise.
5736 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5737 * record-btrace.c (_initialize_record_btrace): Likewise.
5738 * record-full.c (_initialize_record_full): Likewise.
5739 * record.c (_initialize_record): Likewise.
5740 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5741 * regcache.c (_initialize_regcache): Likewise.
5742 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5743 _initialize_remote): Likewise.
5744 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5745 * serial.c (_initialize_serial): Likewise.
5746 * skip.c (_initialize_step_skip): Likewise.
5747 * source.c (_initialize_source): Likewise.
5748 * stack.c (_initialize_stack): Likewise.
5749 * symfile.c (_initialize_symfile): Likewise.
5750 * symtab.c (_initialize_symtab): Likewise.
5751 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5752 * top.c (init_main): Likewise.
5753 * tracefile-tfile.c (tfile_target_info): Likewise.
5754 * tracepoint.c (_initialize_tracepoint): Likewise.
5755 * tui/tui-win.c (_initialize_tui_win): Likewise.
5756 * utils.c (add_internal_problem_command): Likewise.
5757 * valprint.c (value_print_option_defs): Likewise.
5758
5759 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
5760
5761 PR build/24886
5762 * configure.ac: Drop enable-libmcheck support.
5763 * configure, config.in: Rebuild.
5764 * libmcheck.m4: Remove.
5765 * acinclude.m4: Don't include it.
5766 * Makefile.in: Don't distribute it.
5767 * top.c (print_gdb_configuration): Don't mention it.
5768
5769 2019-08-06 Tom Tromey <tom@tromey.com>
5770
5771 * utils.c (set_output_style): Sometimes pass stream to
5772 emit_style_escape.
5773 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5774 * record-btrace.c (btrace_insn_history): Update.
5775 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5776 method.
5777 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5778 Update initializers.
5779 <m_uiout>: New field.
5780 <m_di>: Move lower.
5781 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5782 Remove "uiout" parameter.
5783 (dump_insns): Update.
5784 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5785 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5786
5787 2019-08-06 Christian Biesinger <cbiesinger@google.com>
5788
5789 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5790 (error_in_psymtab_expansion): Likewise.
5791 (lookup_symbol_via_quick_fns): Likewise.
5792 (basic_lookup_transparent_type_quick): Likewise.
5793 (basic_lookup_transparent_type_1): Likewise.
5794
5795 2019-08-06 Tom Tromey <tromey@adacore.com>
5796
5797 * source.c (last_source_error): Now bool.
5798 (print_source_lines_base): Make "noprint" bool. Only open
5799 source file when last_source_visited changes.
5800
5801 2019-08-06 Tom Tromey <tromey@adacore.com>
5802
5803 * annotate.c (annotate_source_line): Use g_source_cache.
5804 * source-cache.c (source_cache::get_plain_source_lines): Change
5805 parameters. Populate m_offset_cache.
5806 (source_cache::ensure): New method.
5807 (source_cache::get_line_charpos): New method.
5808 (extract_lines): Move lower. Change parameters.
5809 (source_cache::get_source_lines): Move lower.
5810 * source-cache.h (class source_cache): Update comment.
5811 <get_line_charpos>: New method.
5812 <get_source_lines>: Update comment.
5813 <clear>: Clear m_offset_cache.
5814 <get_plain_source_lines>: Change parameters.
5815 <ensure>: New method
5816 <m_offset_cache>: New member.
5817 * source.c (forget_cached_source_info_for_objfile): Update.
5818 (info_source_command): Use g_source_cache.
5819 (find_source_lines, open_source_file_with_line_charpos): Remove.
5820 (print_source_lines_base, search_command_helper): Use g_source_cache.
5821 * source.h (open_source_file_with_line_charpos): Don't declare.
5822 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5823 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5824 Use g_source_cache.
5825
5826 2019-08-06 Tom Tromey <tromey@adacore.com>
5827
5828 * source-cache.c (source_cache::get_plain_source_lines):
5829 Remove "first_line" and "last_line" parameters.
5830 (source_cache::get_source_lines): Cache plain text.
5831 * source-cache.h (class source_cache)
5832 <get_plain_source_lines>: Update.
5833
5834 2019-08-06 Tom Tromey <tromey@adacore.com>
5835
5836 * source-cache.c (extract_lines): No longer a method.
5837 Changed type of parameter. Include final newline.
5838 (selftests::extract_lines_test): New function.
5839 (_initialize_source_cache): Likewise.
5840 * source-cache.h (class source_cache)
5841 <extract_lines>: Don't declare.
5842
5843 2019-08-06 Tom Tromey <tromey@adacore.com>
5844
5845 * breakpoint.c (init_breakpoint_sal): Update.
5846 (breakpoint): Update.
5847 * breakpoint.h (struct breakpoint) <filter>: Now a
5848 unique_xmalloc_ptr.
5849
5850 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5851
5852 * NEWS: Mention dictionary access on blocks.
5853 * python/py-block.c (blpy_getitem): New function.
5854 (block_object_as_mapping): New struct.
5855 (block_object_type): Use new struct for tp_as_mapping field.
5856
5857 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5858
5859 * objfiles.h (objfile): Add a comment describing partial symbols.
5860
5861 2019-08-05 Tom Tromey <tromey@adacore.com>
5862
5863 * compile/compile.c (_initialize_compile): Use _(), not N_().
5864 * thread.c (_initialize_thread): Use _(), not N_().
5865 * stack.c (_initialize_stack): Use _(), not N_().
5866 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5867
5868 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5869
5870 * dwarf2read.c (struct dw2_symtab_iterator):
5871 <want_specific_block>: Remove.
5872 <block_index>: Change type to gdb::optional.
5873 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5874 change type of BLOCK_INDEX parameter to gdb::optional.
5875 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5876 (dw2_lookup_symbol): Don't pass argument for
5877 WANT_SPECIFIC_BLOCK.
5878 (dw2_expand_symtabs_for_function): Don't pass argument for
5879 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5880 (class dw2_debug_names_iterator)
5881 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5882 parameter, change BLOCK_INDEX type to gdb::optional.
5883 <m_want_specific_block>: Remove.
5884 <m_block_index>: Change type to gdb::optional.
5885 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5886 gdb::optional. Re-write in function of gdb::optional.
5887 (dw2_debug_names_lookup_symbol): Don't pass argument for
5888 WANT_SPECIFIC_BLOCK.
5889 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5890 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5891 BLOCK_INDEX.
5892
5893 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5894
5895 * NEWS: Mention changes to "info sources" command.
5896
5897 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5898
5899 * symtab.c (filename_partial_match_opts): New struct type.
5900 (struct output_source_filename_data): New members
5901 regexp, c_regexp, partial_match.
5902 (output_source_filename): Use new members to decide to print file.
5903 (info_sources_option_defs): New variable.
5904 (make_info_sources_options_def_group, print_info_sources_header,
5905 info_sources_command_completer):
5906 New functions.
5907 (info_sources_command): Read new optional arguments.
5908 (_initialize_symtab): Update info sources help.
5909
5910 2019-08-02 Alexandre Oliva <oliva@adacore.com>
5911
5912 * ada-lang.c (exception_support_info_v0): Renamed from...
5913 (default_exception_support_info): ... this. Create new
5914 definition for v1.
5915 (ada_has_this_exception_support): Look up catch_handlers_sym.
5916 (ada_exception_support_info_sniffer): Try v0 after default.
5917
5918 2019-08-01 Tom Tromey <tromey@adacore.com>
5919
5920 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5921 gdbarch.h.
5922
5923 2019-08-01 Christian Biesinger <cbiesinger@google.com>
5924
5925 * s12z-tdep.c: Fix include path for s12z-opc.h.
5926
5927 2019-08-01 Alan Hayward <alan.hayward@arm.com>
5928
5929 * NEWS: Require GNU make 3.82.
5930
5931 2019-07-16 Tom Tromey <tom@tromey.com>
5932
5933 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5934 declare.
5935
5936 2019-07-30 Tom Tromey <tromey@adacore.com>
5937
5938 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5939
5940 2019-07-30 Kevin Buettner <kevinb@redhat.com>
5941
5942 * printcmd.c (print_address_symbolic): Print negative offsets.
5943 (build_address_symbolic): Force signed arithmetic when computing
5944 offset.
5945
5946 2019-07-30 Christian Biesinger <cbiesinger@google.com>
5947
5948 PR/24474: Add a function to lookup static variables.
5949 * NEWS: Mention this new function.
5950 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5951 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5952 * python/python.c (python_GdbMethods): Add new function.
5953
5954 2019-07-29 Christian Biesinger <cbiesinger@google.com>
5955
5956 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5957 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5958 (objfpy_lookup_static_symbol): New function.
5959 (objfile_object_methods): Add new functions.
5960
5961 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5962
5963 * NEWS: Mention 'set|show print frame-info'. Mention new
5964 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5965 backtrace argument. Mention that python frame filtering code
5966 is now consistent with what 'backtrace' command prints.
5967
5968 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5969
5970 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5971 comments.
5972 (print_frame_info_auto, print_frame_info_source_line,
5973 print_frame_info_location, print_frame_info_source_and_location,
5974 print_frame_info_location_and_address, print_frame_info_short_location):
5975 New declarations.
5976 (struct frame_print_options): New member print_frame_info.
5977 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5978 * stack.h (get_user_print_what_frame_info): New declaration.
5979 (frame_show_address): New declaration.
5980 * stack.c (print_frame_arguments_choices): New value 'presence'.
5981 (print_frame_info_auto, print_frame_info_source_line,
5982 print_frame_info_location, print_frame_info_source_and_location,
5983 print_frame_info_location_and_address, print_frame_info_short_location,
5984 print_frame_info_choices, print_frame_info_print_what): New definitions.
5985 (print_frame_args): Only print dots for args if print frame-arguments
5986 is 'presence'.
5987 (frame_print_option_defs): New element for "frame-info".
5988 (get_user_print_what_frame_info): New function.
5989 (frame_show_address): Make non static. Move comment to stack.h.
5990 (print_frame_info_to_print_what): New function.
5991 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5992 to decide what to print.
5993 (backtrace_command_1): Handle the new print_frame_arguments_presence
5994 value.
5995 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5996 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5997 (py_print_frame): In non-mi mode, use LOCATION as default for
5998 print_what, similarly to frame information printed directly by
5999 backtrace command. Handle frame-info user option in non MI mode.
6000
6001 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6002
6003 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6004 Add case for debugging 32-bit target on 64-bit host. Revise
6005 comment.
6006
6007 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6008
6009 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6010 instead of find_function_entry_range_from_pc.
6011
6012 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6013
6014 * stack.c (find_frame_funname): Remove code which preferred
6015 minsym over symtab sym in "certain pathological cases".
6016
6017 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6018 parameter. Change type of "do_demangle" to bool.
6019 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6020 Pass suitable "prefer_sym_over_minsym" flag to
6021 build_address_symbolic(). Don't output "+" for negative offsets.
6022 * printcmd.c (print_address_symbolic): Update invocation of
6023 build_address_symbolic to include a "prefer_sym_over_minsym"
6024 flag.
6025 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6026 Restrict cases in which use of minimal symbol is preferred to that
6027 of a found symbol. Update comments.
6028
6029 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6030 for entry pc when entry pc is out of range for that FDE.
6031
6032 2019-07-26 Brian Callahan <bcallah@openbsd.org>
6033
6034 PR gdb/24839:
6035 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6036 type.
6037
6038 2019-07-25 Christian Biesinger <cbiesinger@google.com>
6039
6040 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6041 this function's Python signature.
6042
6043
6044 2019-07-24 Christian Biesinger <cbiesinger@google.com>
6045
6046 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6047 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6048 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6049 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6050 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6051
6052
6053 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6054
6055 * h8300-tdep.c (h8300_register_name_common): New.
6056 h8300_register_name): Use h8300_register_name_common.
6057 (h8300s_register_name): Likewise.
6058 (h8300sx_register_name): Likewise.
6059 (h8300h_register_nam): New.
6060 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6061
6062
6063 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6064
6065 * arm-tdep.c (arm_skip_cmse_entry): New function.
6066 (arm_is_sgstubs_section): New function.
6067 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6068
6069 2019-07-22 Tom Tromey <tom@tromey.com>
6070
6071 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6072 Don't self-assign.
6073
6074 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6075
6076 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6077 type_print.
6078
6079 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6080
6081 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6082 so that GDB doesn't match any msymbols when searching in the
6083 TYPES_DOMAIN.
6084 (print_symbol_info): Print using typedef_print or type_print based
6085 on the type of the symbol. Add updated FIXME comment moved from...
6086 (_initialize_symtab): ... move and update FIXME comment to above.
6087
6088 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6089
6090 * NEWS: Mention adding -q option to "info types".
6091 * symtab.c (struct info_types_options): New struct.
6092 (info_types_options_defs): New variable.
6093 (make_info_types_options_def_group): New function.
6094 (info_types_command): Use gdb::option framework to parse options.
6095 (info_types_command_completer): New function.
6096 (_initialize_symtab): Extend the help text on "info types" and
6097 register command completer.
6098
6099 2019-07-21 Christian Biesinger <cbiesinger@google.com>
6100
6101 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6102 (lookup_symbol_in_objfile): Change int to block_enum and add a
6103 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6104
6105 2019-07-20 Christian Biesinger <cbiesinger@google.com>
6106
6107 * MAINTAINERS (Write After Approval): Add self.
6108
6109 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6110
6111 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6112 instruction to the dummy code region.
6113
6114 2019-07-19 Tom Tromey <tromey@adacore.com>
6115
6116 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6117 (ARGSUSED, PARAMS, __func__): Remove rules.
6118
6119 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6120
6121 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6122 * features/arm/arm-with-iwmmxt.c: Remove.
6123 * features/arm/arm-with-iwmmxt.xml: Remove.
6124 * features/arm/arm-with-m-fpa-layout.c: Remove.
6125 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6126 * features/arm/arm-with-m-vfp-d16.c: Remove.
6127 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6128 * features/arm/arm-with-m.c: Remove.
6129 * features/arm/arm-with-m.xml: Remove.
6130 * features/arm/arm-with-neon.c: Remove.
6131 * features/arm/arm-with-neon.xml: Remove.
6132 * features/arm/arm-with-vfpv2.c: Remove.
6133 * features/arm/arm-with-vfpv2.xml: Remove.
6134 * features/arm/arm-with-vfpv3.c: Remove.
6135 * features/arm/arm-with-vfpv3.xml: Remove.
6136
6137 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6138
6139 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6140
6141 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6142
6143 * arch/aarch32.c (aarch32_create_target_description): Create
6144 target descriptions using features.
6145 * arch/arm.c (arm_create_target_description)
6146 (arm_create_mprofile_target_description): Likewise.
6147 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6148
6149 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6150
6151 * Makefile.in: Add new files.
6152 * aarch32-tdep.c: New file.
6153 * aarch32-tdep.h: New file.
6154 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6155 Call aarch32_read_description.
6156 * arch/aarch32.c: New file.
6157 * arch/aarch32.h: New file.
6158 * arch/arm.c (arm_create_target_description)
6159 (arm_create_mprofile_target_description): New function.
6160 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6161 (arm_create_target_description)
6162 (arm_create_mprofile_target_description): New declaration.
6163 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6164 read_description functions.
6165 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6166 Likewise.
6167 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6168 * arm-tdep.c (tdesc_arm_list): New variable.
6169 (arm_register_g_packet_guesses): Call create description functions.
6170 (arm_read_description) (arm_read_mprofile_description): New
6171 function.
6172 * arm-tdep.h (arm_read_description)
6173 (arm_read_mprofile_description): Add declaration.
6174 * configure.tgt: Add new files.
6175
6176 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6177
6178 * top.c (new_ui_command): Open specified terminal just once.
6179
6180 2019-07-18 Tom Tromey <tromey@adacore.com>
6181
6182 * symtab.c (main_name): Constify return type.
6183 * symfile.c (set_initial_language): Update.
6184 * symtab.h (main_name): Constify return type.
6185
6186 2019-07-17 Tom Tromey <tom@tromey.com>
6187
6188 * tui/tui-winsource.c (tui_update_source_window)
6189 (tui_update_source_window_as_is)
6190 (tui_update_source_windows_with_line): Remove return.
6191 * tui/tui-disasm.c (tui_show_disassem)
6192 (tui_show_disassem_and_update_source): Remove return.
6193 * tui/tui.c (tui_reset): Remove return.
6194 * tui/tui-wingeneral.c
6195 (tui_check_and_display_highlight_if_needed): Remove return.
6196
6197 2019-07-17 Tom Tromey <tom@tromey.com>
6198
6199 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6200
6201 2019-07-17 Tom Tromey <tom@tromey.com>
6202
6203 * tui/tui-winsource.h (struct tui_exec_info_window)
6204 (struct tui_source_window_base): Move from tui-data.h.
6205 * tui/tui-winsource.c: Move many method definitions from
6206 elsewhere. Remove "structuring" comments.
6207 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6208 (tui_source_window_base::refresh_window): Move to
6209 tui-winsource.c.
6210 * tui/tui-win.c (tui_source_window_base::refresh_all)
6211 (tui_source_window_base::update_tab_width)
6212 (tui_source_window_base::set_new_height)
6213 (tui_source_window_base::do_make_visible_with_new_height): Move to
6214 tui-winsource.c.
6215 * tui/tui-source.h: Update.
6216 * tui/tui-source.c (tui_source_window_base::reset): Move to
6217 tui-winsource.c.
6218 * tui/tui-disasm.h: Update.
6219 * tui/tui-data.h (struct tui_exec_info_window): Move to
6220 tui-winsource.h.
6221 (struct tui_source_window_base): Likewise.
6222 * tui/tui-data.c (tui_source_window_base::clear_detail)
6223 (tui_source_window_base, ~tui_source_window_base): Move to
6224 tui-winsource.c.
6225
6226 2019-07-17 Tom Tromey <tom@tromey.com>
6227
6228 * tui/tui-win.c (tui_resize_all)
6229 (tui_source_window_base::update_tab_width)
6230 (tui_adjust_win_heights): Update.
6231 (tui_win_info::make_invisible_and_set_new_height): Rename from
6232 make_invisible_and_set_new_height.
6233 * tui/tui-data.h (struct tui_win_info)
6234 <make_invisible_and_set_new_height>: New method.
6235
6236 2019-07-17 Tom Tromey <tom@tromey.com>
6237
6238 * tui/tui.c: Update.
6239 * tui/tui-source.h (struct tui_source_window): Move from
6240 tui-data.h.
6241 * tui/tui-layout.c: Update.
6242 * tui/tui-disasm.c: Update.
6243 * tui/tui-data.h (struct tui_source_window): Move to
6244 tui-source.h.
6245
6246 2019-07-17 Tom Tromey <tom@tromey.com>
6247
6248 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6249 tui-data.h.
6250 * tui/tui-data.h (struct tui_disasm_window): Move to
6251 tui-disasm.h.
6252
6253 2019-07-17 Tom Tromey <tom@tromey.com>
6254
6255 * tui/tui-regs.h (struct tui_data_item_window): Move from
6256 tui-data.h.
6257 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6258 * tui/tui-data.h (struct tui_data_item_window): Move to
6259 tui-regs.h.
6260 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6261
6262 2019-07-17 Tom Tromey <tom@tromey.com>
6263
6264 * tui/tui.c: Update.
6265 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6266 (tui_cmd_window::max_height): Move to tui-command.c.
6267 * tui/tui-layout.c: Update.
6268 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6269 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6270 tui-command.c.
6271 * tui/tui-command.h (struct tui_cmd_window): Move from
6272 tui-data.h.
6273 * tui/tui-command.c: Remove "structuring" comments.
6274 (tui_cmd_window::clear_detail)
6275 (tui_cmd_window::do_make_visible_with_new_height)
6276 (tui_cmd_window::max_height): Move from elsewhere.
6277
6278 2019-07-17 Tom Tromey <tom@tromey.com>
6279
6280 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6281 Now static.
6282 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6283 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6284
6285 2019-07-17 Tom Tromey <tom@tromey.com>
6286
6287 * tui/tui.c: Update.
6288 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6289 tui-regs.c.
6290 * tui/tui-windata.h: Remove file.
6291 * tui/tui-windata.c: Remove file.
6292 * tui/tui-win.c (tui_data_window::set_new_height)
6293 (tui_data_window::do_make_visible_with_new_height): Move to
6294 tui-regs.c.
6295 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6296 * tui/tui-regs.c: Remove "structuring" comments.
6297 (tui_data_window::first_data_item_displayed)
6298 (tui_data_window::delete_data_content_windows)
6299 (tui_data_window::erase_data_content)
6300 (tui_data_window::display_all_data)
6301 (tui_data_window::refresh_all)
6302 (tui_data_window::do_scroll_vertical)
6303 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6304 (tui_data_window::do_make_visible_with_new_height)
6305 (tui_data_window::refresh_window): Move from elsewhere.
6306 (_initialize_tui_regs): Move to end of file.
6307 * tui/tui-layout.c: Update.
6308 * tui/tui-hooks.c: Update.
6309 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6310 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6311 tui-regs.c.
6312 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6313
6314 2019-07-17 Tom Tromey <tom@tromey.com>
6315
6316 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6317 seen.
6318
6319 2019-07-17 Tom Tromey <tom@tromey.com>
6320
6321 * tui/tui-win.c (tui_source_window_base::set_new_height)
6322 (tui_source_window_base::do_make_visible_with_new_height): Use
6323 m_has_locator field directly.
6324 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6325 method.
6326 (struct tui_source_window_base) <has_locator>: Likewise.
6327
6328 2019-07-17 Tom Tromey <tom@tromey.com>
6329
6330 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6331 Don't declare.
6332 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6333 Remove.
6334 * tui/tui-win.c (tui_source_window_base::set_new_height)
6335 (tui_source_window_base::set_new_height)
6336 (make_invisible_and_set_new_height)
6337 (tui_source_window_base::do_make_visible_with_new_height)
6338 (tui_source_window_base::do_make_visible_with_new_height):
6339 Update.
6340 * tui/tui-layout.c (show_source_disasm_command, show_data)
6341 (show_source_or_disasm_and_command): Update.
6342 * tui/tui-layout.c (show_layout): Update.
6343
6344 2019-07-17 Tom Tromey <tom@tromey.com>
6345
6346 * tui/tui-layout.c (make_data_window): Remove.
6347 (show_data): Unify creation and re-initialization cases.
6348
6349 2019-07-17 Tom Tromey <tom@tromey.com>
6350
6351 * tui/tui-layout.c (make_source_window, make_disasm_window):
6352 Remove.
6353 (show_data): Unify creation and re-initialization cases.
6354
6355 2019-07-17 Tom Tromey <tom@tromey.com>
6356
6357 * tui/tui-layout.c (make_command_window): Remove.
6358 (show_source_disasm_command, show_source_or_disasm_and_command):
6359 Unify creation and re-initialization cases.
6360
6361 2019-07-17 Tom Tromey <tom@tromey.com>
6362
6363 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6364 creation and re-initialization cases.
6365
6366 2019-07-17 Tom Tromey <tom@tromey.com>
6367
6368 * tui/tui-regs.c (tui_get_register): Return void.
6369
6370 2019-07-17 Tom Tromey <tom@tromey.com>
6371
6372 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6373 Simplify.
6374
6375 2019-07-17 Tom Tromey <tom@tromey.com>
6376
6377 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6378 resetting.
6379
6380 2019-07-17 Tom Tromey <tom@tromey.com>
6381
6382 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6383 * tui/tui-regs.c (tui_reg_layout): New function.
6384 (tui_show_registers, tui_reg_command): Use it.
6385 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6386 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6387 parameters.
6388 (tui_layout_command): Remove.
6389
6390 2019-07-17 Tom Tromey <tom@tromey.com>
6391
6392 * tui/tui-layout.h (tui/tui-layout): Return void.
6393 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6394
6395 2019-07-17 Tom Tromey <tom@tromey.com>
6396
6397 * tui/tui-layout.c (show_source_disasm_command, show_data):
6398 Update.
6399 (reset_locator): Remove.
6400 (show_source_or_disasm_and_command): Update.
6401
6402 2019-07-17 Tom Tromey <tom@tromey.com>
6403
6404 * tui/tui-source.c (tui_source_window_base::reset): Remove
6405 win_type parameter.
6406 * tui/tui-layout.c (make_command_window, make_source_window)
6407 (make_disasm_window, make_data_window)
6408 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6409 (reset_locator, show_source_or_disasm_and_command): Update.
6410 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6411 win_type parameter.
6412 (struct tui_source_window_base) <reset>: Likewise.
6413
6414 2019-07-17 Tom Tromey <tom@tromey.com>
6415
6416 * tui/tui-layout.c (show_source_disasm_command): Use
6417 reset_locator.
6418 (reset_locator): New function.
6419 (init_and_make_win): Remove.
6420 (show_source_or_disasm_and_command): Use reset_locator.
6421
6422 2019-07-17 Tom Tromey <tom@tromey.com>
6423
6424 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6425 condition.
6426 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6427 Remove condition.
6428 * tui/tui-source.c (tui_source_window_base::reset): New method.
6429 * tui/tui-layout.c (make_command_window): Don't call
6430 init_and_make_win.
6431 (make_source_window, make_disasm_window): Don't call
6432 make_source_or_disasm_window.
6433 (make_data_window): Don't call init_and_make_win. Change calling
6434 convention.
6435 (show_source_disasm_command, show_data): Simplify.
6436 (make_source_or_disasm_window): Remove.
6437 (show_source_or_disasm_and_command): Simplify.
6438 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6439 (struct tui_source_window_base) <reset>: Likewise.
6440 <execution_info>: Remove initializer.
6441 * tui/tui-data.c (tui_source_window_base): Initialize
6442 execution_info.
6443
6444 2019-07-17 Tom Tromey <tom@tromey.com>
6445
6446 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6447 variable.
6448
6449 2019-07-17 Tom Tromey <tom@tromey.com>
6450
6451 * tui/tui.c (tui_rl_other_window): Update.
6452 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6453 superclass method first. Always iterate over regs_content.
6454 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6455 method.
6456 * tui/tui-win.c (tui_set_focus_command): Update.
6457
6458 2019-07-17 Tom Tromey <tom@tromey.com>
6459
6460 * tui/tui-win.c (tui_set_focus_command): Rename from
6461 tui_set_focus. Call tui_enable.
6462 (tui_set_focus_command): Remove.
6463
6464 2019-07-17 Tom Tromey <tom@tromey.com>
6465
6466 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6467 refresh_window.
6468 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6469 touchwin.
6470 (tui_data_window::refresh_window): Call refresh_window on data
6471 items. Always call superclass refresh_window.
6472 (tui_win_info::refresh): Remove.
6473 (tui_source_window_base::refresh_window): Update.
6474 (tui_refresh_all): Update.
6475 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6476 refresh_window.
6477 (show_source_or_disasm_and_command): Likewise.
6478 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6479 (struct tui_source_window_base) <refresh>: Likewise.
6480
6481 2019-07-17 Tom Tromey <tom@tromey.com>
6482
6483 * tui/tui-winsource.c (tui_clear_source_content)
6484 (tui_show_source_content): Update.
6485 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6486 whether content is empty.
6487 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6488 Remove.
6489
6490 2019-07-17 Tom Tromey <tom@tromey.com>
6491
6492 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6493 window's contents.
6494 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6495 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6496
6497 2019-07-17 Tom Tromey <tom@tromey.com>
6498
6499 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6500 (struct tui_data_item_window): Update.
6501
6502 2019-07-17 Tom Tromey <tom@tromey.com>
6503
6504 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6505 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6506 defines.
6507
6508 2019-07-17 Tom Tromey <tom@tromey.com>
6509
6510 * tui/tui-winsource.h (tui_erase_source_content)
6511 (tui_clear_source_content): Remove "display_prompt" parameter.
6512 * tui/tui-winsource.c (tui_update_source_window_as_is)
6513 (tui_update_source_windows_with_addr): Update.
6514 (tui_clear_source_content): Remove "display_prompt" parameter.
6515 (tui_erase_source_content): Likewise. Simplify.
6516 (tui_show_source_content): Update.
6517 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6518 * tui/tui-stack.c (tui_show_frame_info): Update.
6519 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6520 Remove defines.
6521
6522 2019-07-17 Tom Tromey <tom@tromey.com>
6523
6524 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6525 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6526 parameter.
6527 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6528 parameter.
6529
6530 2019-07-17 Tom Tromey <tom@tromey.com>
6531
6532 * tui/tui-winsource.c (tui_clear_source_content)
6533 (tui_show_source_content, tui_show_exec_info_content)
6534 (tui_clear_exec_info_content): Update.
6535 * tui/tui-stack.c (tui_show_locator_content): Update.
6536 (tui_show_frame_info): Update.
6537 * tui/tui-source.h (tui_source_window): Don't declare.
6538 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6539 from tui_source_is_displayed.
6540 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6541 Remove field.
6542 (struct tui_source_window_base) <content_in_use>: New field. Now
6543 bool.
6544 (struct tui_source_window) <showing_source_p>: New method.
6545 (TUI_SRC_WIN): Change cast.
6546 * tui/tui-data.c (tui_initialize_static_data): Update.
6547
6548 2019-07-17 Tom Tromey <tom@tromey.com>
6549
6550 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6551 location_matches_p.
6552 * tui/tui-source.c (tui_source_window::location_matches_p): New
6553 method.
6554 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6555 method.
6556 * tui/tui-data.h (struct tui_source_window_base)
6557 <location_matches_p>: New method.
6558 (struct tui_source_window, struct tui_disasm_window)
6559 <location_matches_p>: Likewise.
6560
6561 2019-07-17 Tom Tromey <tom@tromey.com>
6562
6563 * tui/tui-win.c (tui_set_win_height_command): Rename from
6564 tui_set_win_height.
6565 (tui_set_win_height_command): Remove.
6566
6567 2019-07-17 Tom Tromey <tom@tromey.com>
6568
6569 * tui/tui-source.c (tui_source_window): New constructor. Add
6570 observer.
6571 (~tui_source_window): New destructor.
6572 (tui_source_window::style_changed): New method.
6573 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6574 (tui_attach_detach_observers): Update.
6575 * tui/tui-data.h (struct tui_source_window): Make constructor not
6576 inline. Add destructor.
6577 (struct tui_source_window) <style_changed>: New method.
6578 <m_observable>: New member.
6579
6580 2019-07-17 Tom Tromey <tom@tromey.com>
6581
6582 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6583 * tui/tui-win.c (tui_resize_all): Fix typo.
6584
6585 2019-07-17 Tom Tromey <tom@tromey.com>
6586
6587 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6588 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6589 (tui_refresh_all): Remove "list" parameter. Use foreach.
6590 * tui/tui-win.c (window_name_completer): Use foreach.
6591 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6592 (update_tab_width): Likewise.
6593 * tui/tui-layout.c (show_layout): Update.
6594 * tui/tui-data.h (class tui_window_iterator): New.
6595 (struct all_tui_windows): New.
6596 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6597
6598 2019-07-17 Tom Tromey <tom@tromey.com>
6599
6600 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6601 parameter. Don't reference globals.
6602 (tui_reg_command): Update.
6603
6604 2019-07-17 Tom Tromey <tom@tromey.com>
6605
6606 * tui/tui-regs.c (tui_show_registers): Simplify.
6607
6608 2019-07-17 Tom Tromey <tom@tromey.com>
6609
6610 * tui/tui-regs.c (tui_show_registers): Update.
6611 (tui_show_register_group): Add win_info parameter.
6612
6613 2019-07-17 Tom Tromey <tom@tromey.com>
6614
6615 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6616 Rename from tui_display_reg_element_at_line.
6617 (tui_data_window::display_registers_from_line): Update.
6618 * tui/tui-data.h (struct tui_data_window)
6619 <display_reg_element_at_line>: New method.
6620
6621 2019-07-17 Tom Tromey <tom@tromey.com>
6622
6623 * tui/tui-regs.h (tui_display_registers_from)
6624 (tui_display_registers_from_line): Don't declare.
6625 * tui/tui-windata.c (tui_data_window::display_all_data)
6626 (tui_data_window::refresh_all)
6627 (tui_data_window::do_scroll_vertical): Update.
6628 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6629 from tui_display_registers_from.
6630 (tui_display_reg_element_at_line): Update.
6631 (tui_data_window::display_registers_from_line): Rename from
6632 tui_display_registers_from_line.
6633 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6634 display_registers_from_line>: New methods.
6635
6636 2019-07-17 Tom Tromey <tom@tromey.com>
6637
6638 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6639 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6640 from tui_erase_data_content.
6641 (tui_data_window::display_all_data)
6642 (tui_data_window::refresh_all)
6643 (tui_data_window::do_scroll_vertical): Update.
6644 * tui/tui-regs.c (tui_show_registers): Update.
6645 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6646 New method.
6647
6648 2019-07-17 Tom Tromey <tom@tromey.com>
6649
6650 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6651 declare.
6652 * tui/tui-windata.c
6653 (tui_data_window::delete_data_content_windows): Rename from
6654 tui_delete_data_content_windows.
6655 (tui_data_window::display_all_data)
6656 (tui_data_window::do_scroll_vertical): Update.
6657 * tui/tui-data.h (struct tui_data_window)
6658 <delete_data_content_windows>: New method.
6659
6660 2019-07-17 Tom Tromey <tom@tromey.com>
6661
6662 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6663 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6664
6665 2019-07-17 Tom Tromey <tom@tromey.com>
6666
6667 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6668 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6669 from tui_display_all_data.
6670 * tui/tui-win.c
6671 (tui_data_window::do_make_visible_with_new_height): Update.
6672 * tui/tui-regs.c (tui_show_registers): Update.
6673 * tui/tui-layout.c (tui_set_layout): Update.
6674 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6675 method.
6676
6677 2019-07-17 Tom Tromey <tom@tromey.com>
6678
6679 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6680 * tui/tui-windata.c (tui_display_data_from): Remove.
6681 (tui_data_window::refresh_all): Update.
6682
6683 2019-07-17 Tom Tromey <tom@tromey.com>
6684
6685 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6686 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6687 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6688 tui_display_registers_from_line.
6689 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6690 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6691 "force_display" parameter.
6692
6693 2019-07-17 Tom Tromey <tom@tromey.com>
6694
6695 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6696 declare.
6697 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6698 Rename from tui_first_reg_element_no_inline.
6699 (tui_display_reg_element_at_line)
6700 (tui_display_registers_from_line): Update.
6701 * tui/tui-data.h (struct tui_data_window)
6702 <first_reg_element_no_inline>: New method.
6703
6704 2019-07-17 Tom Tromey <tom@tromey.com>
6705
6706 * tui/tui-windata.c (tui_display_data_from)
6707 (tui_data_window::do_scroll_vertical): Update.
6708 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6709 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6710 Rename from tui_line_from_reg_element_no.
6711 (tui_display_registers_from_line): Update.
6712 * tui/tui-data.h (struct tui_data_window)
6713 <line_from_reg_element_no>: New method.
6714
6715 2019-07-17 Tom Tromey <tom@tromey.com>
6716
6717 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6718 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6719 tui_last_regs_line_no.
6720 (tui_display_reg_element_at_line)
6721 (tui_display_registers_from_line): Update.
6722 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6723 method.
6724
6725 2019-07-17 Tom Tromey <tom@tromey.com>
6726
6727 PR tui/24722:
6728 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6729 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6730 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6731 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6732 (tui_update_breakpoint_info): Likewise.
6733 * tui/tui-hooks.c (tui_event_create_breakpoint)
6734 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6735 Update.
6736
6737 2019-07-17 Tom Tromey <tom@tromey.com>
6738
6739 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6740
6741 2019-07-17 Tom Tromey <tom@tromey.com>
6742
6743 * tui/tui-winsource.c (tui_update_source_window_as_is)
6744 (tui_update_source_windows_with_addr): Update.
6745 * tui/tui-source.h (tui_set_source_content)
6746 (tui_show_symtab_source): Add "win_info" parameter.
6747 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6748 parameter.
6749 (tui_show_symtab_source): Likewise.
6750
6751 2019-07-17 Tom Tromey <tom@tromey.com>
6752
6753 * tui/tui-wingeneral.c
6754 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6755
6756 2019-07-17 Tom Tromey <tom@tromey.com>
6757
6758 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6759 (struct tui_cmd_window) <can_scroll>: New method.
6760 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6761 method.
6762
6763 2019-07-17 Tom Tromey <tromey@adacore.com>
6764
6765 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6766 do_field_signed>: Rename. Change type of "value".
6767 * ui-out.c (ui_out::field_signed): Rename from field_int.
6768 Change type of "value".
6769 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6770 type of "value".
6771 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6772 do_field_int. Change type of "value".
6773 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6774 do_field_int. Change type of "value".
6775 * tracepoint.c (trace_status_mi, tfind_1)
6776 (print_one_static_tracepoint_marker): Update.
6777 * thread.c (print_thread_info_1, print_selected_thread_frame):
6778 Update.
6779 * stack.c (print_frame, print_frame_info): Update.
6780 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6781 Update.
6782 * source.c (print_source_lines_base): Update.
6783 * skip.c (info_skip_command): Update.
6784 * record-btrace.c (btrace_ui_out_decode_error)
6785 (btrace_call_history_src_line): Update.
6786 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6787 Update.
6788 * progspace.c (print_program_space): Update.
6789 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6790 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6791 do_field_int. Change type of "value".
6792 * mi/mi-out.c (mi_ui_out::do_table_begin)
6793 (mi_ui_out::do_table_header): Update.
6794 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6795 type of "value".
6796 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6797 (mi_cmd_data_list_changed_registers, output_register)
6798 (mi_cmd_data_read_memory, mi_load_progress)
6799 (mi_cmd_trace_frame_collected): Update.
6800 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6801 Update.
6802 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6803 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6804 (mi_cmd_var_list_children, varobj_update_one): Update.
6805 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6806 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6807 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6808 * inferior.c (print_inferior): Update.
6809 * gdb_bfd.c (print_one_bfd): Update.
6810 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6811 Update.
6812 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6813 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6814 do_field_int. Change type of "value".
6815 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6816 do_field_int. Change type of "value".
6817 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6818 (print_one_breakpoint_location, print_it_catch_fork)
6819 (print_one_catch_fork, print_it_catch_vfork)
6820 (print_one_catch_vfork, print_it_catch_solib)
6821 (print_it_catch_exec, print_it_ranged_breakpoint)
6822 (print_mention_watchpoint, print_mention_masked_watchpoint)
6823 (bkpt_print_it, update_static_tracepoint): Update.
6824 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6825 * break-catch-syscall.c (print_it_catch_syscall): Update.
6826 * ada-tasks.c (print_ada_task_info): Update.
6827 * ada-lang.c (print_it_exception, print_mention_exception):
6828 Update.
6829
6830 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6831
6832 PR breakpoints/24541
6833 * gdbarch.c: Regenerate.
6834 * gdbarch.h: Regenerate.
6835 * gdbarch.sh: Adjust return type and parameter types for
6836 'stap_adjust_register'.
6837 (i386_stap_adjust_register): Adjust signature and return new
6838 register name.
6839 * stap-probe.c (stap_parse_register_operand): Adjust use of
6840 'gdbarch_stap_adjust_register'.
6841
6842 2019-07-17 Tom Tromey <tromey@adacore.com>
6843
6844 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6845 declare VEC.
6846 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6847 std::vector.
6848 (struct s390_process_info): Add initializers.
6849 (s390_add_process): Use new.
6850 (s390_linux_nat_target::low_forget_process): Use delete.
6851 (s390_linux_nat_target::low_new_fork)
6852 (s390_linux_nat_target::stopped_by_watchpoint)
6853 (s390_linux_nat_target::low_prepare_to_resume)
6854 (s390_linux_nat_target::insert_watchpoint)
6855 (s390_linux_nat_target::insert_hw_breakpoint)
6856 (s390_linux_nat_target::remove_watchpoint)
6857 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6858
6859 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6860
6861 * aarch64-fbsd-nat.c: Include regcache.h.
6862 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6863 argument.
6864 (aarch64_fbsd_nat_target::fetch_registers)
6865 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6866 variable.
6867 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6868
6869 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6870
6871 * fbsd-nat.c: Include gdbarch.h.
6872
6873 2019-07-15 Tom Tromey <tromey@adacore.com>
6874
6875 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6876
6877 2019-07-15 Tom Tromey <tromey@adacore.com>
6878
6879 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6880 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6881 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6882 * cli-out.c (cli_ui_out::do_field_int): New method.
6883 * ui-out.c (ui_out::field_unsigned): New method.
6884 * symfile.c (generic_load): Use field_unsigned.
6885 (print_transfer_performance): Likewise.
6886 * record-btrace.c (ui_out_field_uint): Remove.
6887 (btrace_call_history_insn_range, btrace_call_history): Use
6888 field_unsigned.
6889 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6890 field_unsigned.
6891 * ui-out.h (class ui_out) <field_unsigned>: New method.
6892 <do_field_unsigned>: Likewise.
6893
6894 2019-07-15 Tom Tromey <tromey@adacore.com>
6895
6896 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6897 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6898 * target.c (flash_erase_command): Use field_string.
6899 * infrun.c (print_signal_received_reason): Use field_string.
6900 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6901 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6902 field_string.
6903 * ada-tasks.c (print_ada_task_info): Use field_string.
6904
6905 2019-07-15 Tom Tromey <tromey@adacore.com>
6906
6907 * target.c (flash_erase_command): Use field_core_addr.
6908 * symfile.c (generic_load): Use field_core_addr.
6909 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6910 Use field_core_addr.
6911 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6912 field_core_addr.
6913
6914 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6915
6916 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6917 value if its desired type is smaller than a CORE_ADDR and signed.
6918
6919 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6920
6921 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6922 of changes to field names, and use new is_reference field to
6923 decide if a property is a reference or not.
6924 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6925 field.
6926 (struct dwarf2_property_baton): Update header comment, rename
6927 'referenced_type' to 'property_type' and update comments.
6928 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6929 default property type, store in property baton, update to take
6930 accound of renamed field.
6931 (read_func_scope): Update call to attr_to_dynamic_prop.
6932 (read_array_type): Likewise.
6933 (dwarf2_per_cu_addr_sized_int_type): New function.
6934 (read_subrange_index_type): Move type finding code to
6935 dwarf2_per_cu_addr_sized_int_type.
6936 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6937 (dwarf2_per_cu_addr_type): New function.
6938 (set_die_type): Update calls to attr_to_dynamic_prop.
6939
6940 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6941
6942 * dwarf2read.c (read_subrange_index_type): New function.
6943 (read_subrange_type): Move code into new function and call it.
6944 * gdbtypes.c (create_range_type): Add some asserts.
6945
6946 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6947
6948 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6949 update return statements.
6950 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6951 declaration, and update comment to match.
6952 * gdbtypes.c (resolve_dynamic_array): Update call to
6953 dwarf2_evaluate_property to match new return type.
6954
6955 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6956
6957 * valarith.c (value_subscripted_rvalue): Change lowerbound
6958 parameter type from int to LONGEST.
6959 * value.h (value_subscripted_rvalue): Likewise in declaration.
6960
6961 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6962
6963 * cli/cli-utils.c (info_print_command_completer): New function.
6964 * cli/cli-utils.h: Add 'completer.h' include, and forward
6965 declaration for 'struct cmd_list_element'.
6966 (info_print_command_completer): Declare.
6967 * stack.c (_initialize_stack): Add completer for 'info locals' and
6968 'info args'.
6969 * symtab.c (_initialize_symtab): Add completer for 'info
6970 variables' and 'info functions'.
6971 * NEWS: Mention completion for additional info commands.
6972
6973 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6974
6975 * cli/cli-utils.c (extract_info_print_args): Delete.
6976 (extract_arg_maybe_quoted): Delete.
6977 (info_print_options_defs): New variable.
6978 (make_info_print_options_def_group): New function.
6979 (extract_info_print_options): Define new function.
6980 * cli/cli-utils.h (extract_info_print_args): Delete.
6981 (struct info_print_options): New structure.
6982 (extract_info_print_options): Declare new function.
6983 * stack.c (info_locals_command): Update to use new
6984 extract_info_print_options, also add a header comment.
6985 (info_args_command): Likewise.
6986 * symtab.c (info_variables_command): Likewise.
6987 (info_functions_command): Likewise.
6988
6989 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6990
6991 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6992 to extract string arguments.
6993 * common/common-utils.c (extract_string_maybe_quoted): New function.
6994 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6995
6996 2019-07-11 Tom Tromey <tromey@adacore.com>
6997
6998 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6999 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7000 * top.h (gdbinit): Don't declare.
7001 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7002 into...
7003 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7004 * top.c (gdb_init): Don't call init_cli_cmds.
7005 (gdbinit): Remove.
7006 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7007
7008 2019-07-11 Tom Tromey <tromey@adacore.com>
7009
7010 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7011 after it has been moved.
7012
7013 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7014
7015 * valops.c (value_must_coerce_to_target): Change return type to
7016 bool.
7017 * value.h (value_must_coerce_to_target): Likewise.
7018
7019 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
7020
7021 * breakpoint.c (is_hardware_watchpoint): Remove
7022 forward-declaration.
7023 (is_masked_watchpoint): Change return type to bool.
7024 (is_tracepoint): Likewise.
7025 (is_breakpoint): Likewise.
7026 (is_hardware_watchpoint): Likewise.
7027 (is_watchpoint): Likewise.
7028 (is_no_memory_software_watchpoint): Likewise.
7029 (is_catchpoint): Likewise.
7030 (breakpoint_1): Make FILTER parameter's return type bool.
7031 is_masked_watchpoint): Change return type to bool.
7032 (save_breakpoints): Make FILTER parameter's return type bool.
7033 * breakpoint.h (is_breakpoint): Change return type to bool.
7034 (is_watchpoint): Likewise.
7035 (is_catchpoint): Likewise.
7036 (is_tracepoint): Likewise.
7037
7038 2019-07-10 Tom Tromey <tom@tromey.com>
7039
7040 * defs.h: Don't include gdbarch.h.
7041 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7042 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7043 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7044 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7045 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7046 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7047 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7048 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7049 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7050 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7051 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7052 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7053 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7054 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7055 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7056 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7057 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7058 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7059 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7060 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7061 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7062 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7063 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7064 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7065 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7066 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7067 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7068
7069 2019-07-10 Tom Tromey <tromey@adacore.com>
7070
7071 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7072 * breakpoint.c (init_ada_exception_breakpoint): Register as
7073 bp_catchpoint.
7074 (print_one_breakpoint_location, print_one_breakpoint): Use
7075 is_ada_exception_catchpoint.
7076 * ada-lang.c (class ada_catchpoint_location): Pass
7077 bp_loc_software_breakpoint to bp_location constructor.
7078 (is_ada_exception_catchpoint): New function.
7079
7080 2019-07-10 Tom Tromey <tromey@adacore.com>
7081
7082 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7083 VEC.
7084 (struct arm_exidx_entry): New method operator<.
7085 (struct arm_exidx_data) <section_maps>: Change type.
7086 (arm_exidx_data_free): Remove.
7087 (arm_exidx_data_key): Change type. Move lower.
7088 (arm_exidx_new_objfile): Update.
7089 (arm_compare_exidx_entries): Remove.
7090 (arm_find_exidx_entry, _initialize_arm_tdep)
7091
7092 2019-07-10 Tom Tromey <tromey@adacore.com>
7093
7094 * solib-spu.c (ocl_program_data_key): Change type.
7095 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7096 Update.
7097
7098 2019-07-10 Tom Tromey <tromey@adacore.com>
7099
7100 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7101 (struct solib_aix_inferior_data) <library_list>: Change type.
7102 (solib_aix_inferior_data_handle): Change type.
7103 (get_solib_aix_inferior_data): Update.
7104 (solib_aix_free_library_list): Remove.
7105 (library_list_start_library): Update.
7106 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7107 return type.
7108 (solib_aix_get_library_list)
7109 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7110 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7111
7112 2019-07-10 Tom Tromey <tromey@adacore.com>
7113
7114 * solib-dsbt.c (struct dsbt_info): Add initializers.
7115 (solib_dsbt_pspace_data): Change type.
7116 (dsbt_pspace_data_cleanup): Remove.
7117 (get_dsbt_info, _initialize_dsbt_solib): Update.
7118
7119 2019-07-10 Tom Tromey <tromey@adacore.com>
7120
7121 * spu-tdep.c (spu_overlay_data): Change type.
7122 (spu_get_overlay_table, spu_overlay_new_objfile)
7123 (_initialize_spu_tdep): Update.
7124
7125 2019-07-10 Tom Tromey <tromey@adacore.com>
7126
7127 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7128 destructor.
7129 (dbx_objfile_data_key): Change type and declare later.
7130 (DBX_SYMFILE_INFO): Rewrite.
7131 * dbxread.c (dbx_objfile_data_key): Change type.
7132 (dbx_symfile_init): Update.
7133 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7134 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7135 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7136
7137 2019-07-10 Tom Tromey <tromey@adacore.com>
7138
7139 * jit.c (jit_program_space_key): Change type. Move lower.
7140 (get_jit_program_space_data): Update.
7141 (jit_program_space_data_cleanup): Remove.
7142 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7143 Update.
7144 (struct jit_program_space_data): Add initializers.
7145
7146 2019-07-10 Tom Tromey <tromey@adacore.com>
7147
7148 * solib-darwin.c (struct darwin_info): Add initializers.
7149 (solib_darwin_pspace_data): Change type.
7150 (darwin_pspace_data_cleanup): Remove.
7151 (get_darwin_info, _initialize_darwin_solib): Update.
7152
7153 2019-07-10 Tom Tromey <tromey@adacore.com>
7154
7155 * remote-sim.c (struct sim_inferior_data): Add initializers,
7156 constructor, and destructor.
7157 (sim_inferior_data_key): Change type. Move lower.
7158 (check_for_duplicate_sim_descriptor): Update.
7159 (get_sim_inferior_data): Use new. Update.
7160 (~sim_inferior_data_cleanup): Rename from
7161 sim_inferior_data_cleanup. Simplify.
7162 (gdbsim_close_inferior, simulator_command)
7163 (sim_command_completer, _initialize_remote_sim): Update.
7164 (next_pid, INITIAL_PID): Move earlier.
7165
7166 2019-07-10 Tom Tromey <tromey@adacore.com>
7167
7168 * python/python-internal.h (create_thread_object): Return
7169 gdbpy_ref.
7170 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7171 * python/py-inferior.c (struct threadlist_entry): Add
7172 constructor.
7173 <thread_obj>: Now a gdbpy_ref.
7174 (thread_to_thread_object): Update.
7175 (add_thread_object): Use new.
7176 (delete_thread_object): Use delete.
7177 (infpy_threads): Update.
7178 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7179 GIL.
7180
7181 2019-07-10 Tom Tromey <tromey@adacore.com>
7182
7183 * valops.c (value_cast): Specialize error message for Ada.
7184
7185 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7186
7187 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7188
7189 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7190
7191 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7192 bpstat_should_step): Return bool, adjust comments.
7193 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7194 bpstat_should_step): Likewise.
7195
7196 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7197
7198 * features/Makefile: Use feature target descriptions for Arm.
7199 * features/arm/arm-core.c: Generate new file.
7200 * features/arm/arm-fpa.c: Likewise.
7201 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7202 * features/arm/arm-m-profile.c: Likewise.
7203 * features/arm/arm-vfpv2.c: Likewise.
7204 * features/arm/arm-vfpv3.c: Likewise.
7205 * features/arm/xscale-iwmmxt.c: Likewise.
7206 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7207
7208 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7209
7210 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7211 ptrace earlier.
7212
7213 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7214
7215 * features/aarch64-pauth.c: Regenerate.
7216
7217 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7218
7219 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7220 bool.
7221 (bpstat_what): Use false instead of 0.
7222
7223 2019-07-09 Pedro Alves <palves@redhat.com>
7224
7225 * break-catch-throw.c (is_exception_catchpoint): New.
7226 * breakpoint.c (print_one_breakpoint_location): New parameter
7227 'raw_loc'. Handle it. Use
7228 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7229 looking at the breakpoint's type.
7230 (print_one_breakpoint): If handling "maint info breakpoints", also
7231 print locations of exception catchpoints.
7232 * breakpoint.h (is_exception_catchpoint): Declare.
7233
7234 2019-07-09 Pedro Alves <palves@redhat.com>
7235
7236 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7237 "addr" field.
7238 (allocate_location_exception_catchpoint): New.
7239 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7240 (initialize_throw_catchpoint_ops): Install
7241 allocate_location_exception_catchpoint as allocate_location
7242 method.
7243 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7244 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7245 bp_loc_other.
7246 (breakpoint_address_is_meaningful): Delete.
7247 (bl_address_is_meaningful): New.
7248 (breakpoint_locations_match): Adjust comment.
7249 (bp_location_from_bp_type): New, factored out of...
7250 (bp_location::bp_location(breakpoint *)): ... this.
7251 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7252 factored out of...
7253 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7254 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7255 breakpoint_address_is_meaningful.
7256 (bp_locations_compare): Adjust comment.
7257 (update_global_location_list): Use bl_address_is_meaningful
7258 instead of breakpoint_address_is_meaningful.
7259 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7260 explicit.
7261 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7262 * python/py-breakpoint.c (bppy_get_location): No longer check
7263 whether location is null.
7264
7265 2019-07-09 Pedro Alves <palves@redhat.com>
7266
7267 PR c++/15468
7268 * breakpoint.c (print_one_breakpoint_location): Remove
7269 single-location assert.
7270
7271 2019-07-09 Tom Tromey <tom@tromey.com>
7272
7273 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7274 * configure: Rebuild.
7275 * configure.ac: Change common to gdbsupport.
7276 * gdbsupport: Rename from common.
7277 * acinclude.m4: Change common to gdbsupport.
7278 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7279 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7280 gdbsupport.
7281 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7282 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7283 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7284 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7285 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7286 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7287 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7288 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7289 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7290 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7291 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7292 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7293 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7294 coff-pe-read.c, command.h, compile/compile-c-support.c,
7295 compile/compile-c.h, compile/compile-cplus-symbols.c,
7296 compile/compile-cplus-types.c, compile/compile-cplus.h,
7297 compile/compile-loc2c.c, compile/compile.c, completer.c,
7298 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7299 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7300 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7301 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7302 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7303 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7304 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7305 features/aarch64-core.c, features/aarch64-fpu.c,
7306 features/aarch64-pauth.c, features/aarch64-sve.c,
7307 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7308 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7309 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7310 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7311 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7312 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7313 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7314 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7315 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7316 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7317 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7318 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7319 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7320 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7321 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7322 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7323 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7324 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7325 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7326 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7327 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7328 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7329 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7330 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7331 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7332 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7333 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7334 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7335 minsyms.c, mips-linux-tdep.c, namespace.h,
7336 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7337 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7338 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7339 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7340 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7341 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7342 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7343 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7344 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7345 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7346 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7347 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7348 procfs.c, producer.c, progspace.h, psymtab.h,
7349 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7350 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7351 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7352 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7353 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7354 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7355 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7356 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7357 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7358 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7359 target-memory.c, target.c, target.h, target/waitstatus.c,
7360 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7361 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7362 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7363 unittests/array-view-selftests.c,
7364 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7365 unittests/common-utils-selftests.c,
7366 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7367 unittests/format_pieces-selftests.c,
7368 unittests/function-view-selftests.c,
7369 unittests/lookup_name_info-selftests.c,
7370 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7371 unittests/mkdir-recursive-selftests.c,
7372 unittests/observable-selftests.c,
7373 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7374 unittests/parse-connection-spec-selftests.c,
7375 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7376 unittests/scoped_fd-selftests.c,
7377 unittests/scoped_mmap-selftests.c,
7378 unittests/scoped_restore-selftests.c,
7379 unittests/string_view-selftests.c, unittests/style-selftests.c,
7380 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7381 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7382 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7383 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7384 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7385 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7386
7387 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7388
7389 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7390 bool value.
7391 (decode_digits_ordinary): Set explicit_line field in sal.
7392 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7393 symtab_and_line that was set on an explicit line number in
7394 assembler code. Do always update the recorded symtab and line if
7395 we do skip the prologue.
7396
7397 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7398
7399 * breakpoint.c (set_breakpoint_location_function): Remove
7400 explicit_loc parameter.
7401 (momentary_breakpoint_from_master): Update call to
7402 set_breakpoint_location_function.
7403 (add_location_to_breakpoint): Likewise.
7404
7405 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7406
7407 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7408 required features based on default bfd type when no specific bfd
7409 is present.
7410
7411 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7412
7413 * NEWS: Mention that GDB printf and eval commands can now print
7414 C-style and Ada-style convenience var strings without
7415 calling the inferior.
7416 * printcmd.c (printf_c_string): Locally print GDB internal var
7417 instead of transiting via the inferior.
7418 (printf_wide_c_string): Likewise.
7419
7420 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7421
7422 PR breakpoints/25011
7423 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7424
7425 2019-07-04 Tom Tromey <tom@tromey.com>
7426
7427 PR tui/24724:
7428 * tui/tui-winsource.c (tui_clear_source_content): Update.
7429 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7430 (tui_update_breakpoint_info): Update.
7431 (tui_set_exec_info_content): Update.
7432 * tui/tui-source.c (tui_set_source_content_nil): Update.
7433 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7434 has_break.
7435 * tui/tui-data.h (enum tui_bp_flag): New.
7436 (tui_bp_flags): New enum flags type.
7437 (struct tui_source_element) <break_mode>: Change type. Rename
7438 from has_break.
7439 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7440 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7441 constants.
7442 * tui/tui-winsource.h: Fix comment.
7443
7444 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7445
7446 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7447 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7448 (store_fpregs_to_thread)
7449 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7450 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7451 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7452 (IWMMXT_REGS_SIZE): Add define.
7453 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7454 (fetch_vfp_regs, store_vfp_regs)
7455 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7456 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7457
7458 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7459
7460 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7461 defines.
7462 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7463 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7464 (ARM_INT_REGISTER_SIZE): ...to this.
7465 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7466 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7467 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7468 (arm_linux_collect_gregset, supply_nwfpe_register)
7469 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7470 defines.
7471 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7472 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7473 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7474 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7475 (arm_return_in_memory, arm_store_return_value)
7476 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7477 (arm_record_ld_st_multiple): Likewise.
7478 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7479 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7480
7481 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7482
7483 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7484 AARCH64_DISPLACED_MODIFIED_INSNS.
7485 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7486 (aarch64_displaced_step_copy_insn): Likewise.
7487 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7488 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7489 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7490 ARM_DISPLACED_MODIFIED_INSNS.
7491 * arm-tdep.c (arm_gdbarch_init): Likewise.
7492 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7493 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7494 (struct arm_displaced_step_closure): Use
7495 ARM_DISPLACED_MODIFIED_INSNS.
7496
7497 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7498
7499 * features/Makefile: Remove unused xml files.
7500 * features/aarch64.xml: Remove.
7501 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7502 * features/i386/amd64-avx-avx512.xml: Remove.
7503 * features/i386/amd64-avx-linux.xml: Remove.
7504 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7505 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7506 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7507 * features/i386/amd64-avx-mpx.xml: Remove.
7508 * features/i386/amd64-avx.xml: Remove.
7509 * features/i386/amd64-linux.xml: Remove.
7510 * features/i386/amd64-mpx-linux.xml: Remove.
7511 * features/i386/amd64-mpx.xml: Remove.
7512 * features/i386/amd64.xml: Remove.
7513 * features/i386/i386-avx-avx512-linux.xml: Remove.
7514 * features/i386/i386-avx-avx512.xml: Remove.
7515 * features/i386/i386-avx-linux.xml: Remove.
7516 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7517 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7518 * features/i386/i386-avx-mpx-linux.xml: Remove.
7519 * features/i386/i386-avx-mpx.xml: Remove.
7520 * features/i386/i386-avx.xml: Remove.
7521 * features/i386/i386-linux.xml: Remove.
7522 * features/i386/i386-mmx-linux.xml: Remove.
7523 * features/i386/i386-mmx.xml: Remove.
7524 * features/i386/i386-mpx-linux.xml: Remove.
7525 * features/i386/i386-mpx.xml: Remove.
7526 * features/i386/i386.xml: Remove.
7527 * features/i386/x32-avx-avx512-linux.xml: Remove.
7528 * features/i386/x32-avx-linux.xml: Remove.
7529 * features/i386/x32-linux.xml: Remove.
7530
7531 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7532
7533 * regformats/aarch64.dat: Remove.
7534 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7535 * regformats/i386/amd64-avx-linux.dat: Remove.
7536 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7537 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7538 * regformats/i386/amd64-linux.dat: Remove.
7539 * regformats/i386/amd64-mpx-linux.dat: Remove.
7540 * regformats/i386/amd64.dat: Remove.
7541 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7542 * regformats/i386/i386-avx-linux.dat: Remove.
7543 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7544 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7545 * regformats/i386/i386-linux.dat: Remove.
7546 * regformats/i386/i386-mmx-linux.dat: Remove.
7547 * regformats/i386/i386-mpx-linux.dat: Remove.
7548 * regformats/i386/i386.dat: Remove.
7549 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7550 * regformats/i386/x32-avx-linux.dat: Remove.
7551 * regformats/i386/x32-linux.dat: Remove.
7552
7553 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7554
7555 * aarch64-tdep.c: Remove xml self tests.
7556 * amd64-linux-tdep.c: Likewise.
7557 * amd64-tdep.c: Likewise.
7558 * i386-linux-tdep.c: Likewise.
7559 * i386-tdep.c: Likewise.
7560
7561 2019-07-03 Pedro Alves <palves@redhat.com>
7562
7563 PR cli/24732
7564 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7565 (pipe_cmd_option_defs): New.
7566 (make_pipe_cmd_options_def_group): New.
7567 (pipe_command): Use gdb::option::process_options.
7568 (pipe_command_completer): New function.
7569 (_initialize_cli_cmds): Install completer for "pipe" command.
7570
7571 2019-07-03 Pedro Alves <palves@redhat.com>
7572
7573 * cli/cli-option.c (union option_value) <string>: New field.
7574 (struct option_def_and_value): Add ctor, move ctor, dtor and
7575 use DISABLE_COPY_AND_ASSIGN.
7576 (option_def_and_value::clear_value): New.
7577 (parse_option, save_option_value_in_ctx, get_val_type_str)
7578 (add_setshow_cmds_for_options): Handle var_string.
7579 * cli-option.h (union option_def::var_address) <string>: New
7580 field.
7581 (struct string_option_def): New.
7582 * maint-test-options.c (struct test_options_opts): Add default
7583 ctor and use DISABLE_COPY_AND_ASSIGN.
7584 <string_opt>: New field.
7585 (test_options_opts::~test_options_opts): New.
7586 (test_options_opts::dump): Also dump "-string".
7587 (test_options_option_defs): Install "string.
7588
7589 2019-07-03 Pedro Alves <palves@redhat.com>
7590
7591 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7592 option_value with a null enumeration.
7593 (complete_options): Save the option values in the context.
7594 (save_option_value_in_ctx): New, factored out from ...
7595 (process_options): ... here.
7596 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7597 of the function.
7598 * maint-test-options.c (test_options_opts::dump): New, factored
7599 out from ...
7600 (maintenance_test_options_command_mode): ... here.
7601 (maintenance_test_options_command_completion_result): Delete.
7602 (maintenance_test_options_command_completion_text): Update
7603 comment.
7604 (maintenance_show_test_options_completion_result): Change
7605 prototype. Just print
7606 maintenance_test_options_command_completion_text.
7607 (save_completion_result): New.
7608 (maintenance_test_options_completer_mode): Pass options context to
7609 complete_options, and then save a dump.
7610 (_initialize_maint_test_options): Use add_cmd to install "maint
7611 show test-options-completion-result".
7612
7613 2019-07-03 Pedro Alves <palves@redhat.com>
7614
7615 * NEWS (New commands): Mention "with" and "maint with".
7616 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7617 (with_command, with_command_completer): New.
7618 (pipe_command): Adjust to new repeat_previous
7619 interface.
7620 (_initialize_cli_cmds): Install the "with" command and its "w"
7621 alias.
7622 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7623 declarations.
7624 * cli/cli-setshow.c (parse_cli_var_uinteger)
7625 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7626 argument strings for all var_types.
7627 (get_setshow_command_value_string): New, factored out from ...
7628 (do_show_command): ... this.
7629 * cli/cli-setshow.h: Include <string>.
7630 (get_setshow_command_value_string): Declare.
7631 * command.h (repeat_previous): Now returns const char *. Adjust
7632 comment.
7633 * maint.c: Include "cli/cli-cmds.h".
7634 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7635 (_initialize_maint_cmds): Register the "maintenance with" command.
7636 * top.c (repeat_previous): Move bits from pipe_command here:
7637 Return the saved command line, if any; error out if there's no
7638 command to relaunch.
7639
7640 2019-07-03 Pedro Alves <palves@redhat.com>
7641
7642 * NEWS (New commands): Mention "maint set/show test-settings"
7643 instead of "maint test-settings".
7644 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7645 (maintenance_test_settings_set_list): Rename to ...
7646 (maintenance_set_test_settings_list): ... this.
7647 (maintenance_test_settings_show_list): Rename to ...
7648 (maintenance_show_test_settings_list): ... this.
7649 (maintenance_test_settings_cmd): Delete.
7650 (maintenance_test_settings_set_cmd): ...
7651 (maintenance_set_test_settings_cmd): ... this.
7652 (maintenance_test_settings_show_cmd): ...
7653 (maintenance_show_test_settings_cmd): ... this.
7654 (maintenance_test_settings_show_value_cmd):
7655 (maintenance_show_test_settings_value_cmd): ... this.
7656 (_initialize_maint_test_settings): No longer install the "maint
7657 test-settings" prefix command. Rename "maint test-settings set"
7658 to "maint set test-settings", and "maint test-settings show" to
7659 "maint show test-settings". Adjust all subcommands.
7660
7661 2019-07-03 Pedro Alves <palves@redhat.com>
7662
7663 * maint-test-settings.c: Fix file's intro comment. Replace all
7664 references to "test-options" with references to "test-settings",
7665 in comments.
7666
7667 2019-07-03 Pedro Alves <palves@redhat.com>
7668
7669 * maint-test-settings.c (maintenance_test_settings_xxx)
7670 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7671 New.
7672 (maintenance_test_settings_enums): Use them.
7673 (maintenance_test_settings_enum): Default to
7674 maintenance_test_settings_xxx.
7675 (_initialize_maint_test_settings): Initialize
7676 MAINTENANCE_TEST_SETTINGS_FILENAME.
7677
7678 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7679
7680 * breakpoint.h (remove_breakpoints_inf): Change return type to
7681 void, move function documentation here.
7682 * breakpoint.c (remove_breakpoints_inf): Change return type to
7683 void, move function documentation to header.
7684
7685 2019-07-02 Pedro Alves <palves@redhat.com>
7686
7687 * NEWS (Completion improvements): Mention "info threads".
7688 * thread.c (struct info_threads_opts, info_threads_option_defs)
7689 (make_info_threads_options_def_group): New.
7690 (info_threads_command): Use gdb::option::process_options.
7691 (info_threads_command_completer): New.
7692 (_initialize_thread): Use gdb::option::build_help to build the
7693 help text for "info threads".
7694
7695 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7696
7697 * defs.h (generic_load): Move from here...
7698 * symfile.h (generic_load): ... to here. Rename name parameter
7699 to args.
7700 * symfile.c (generic_load): Add comment.
7701
7702 2019-07-01 Tom Tromey <tromey@adacore.com>
7703
7704 * dwarf2read.c
7705 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7706 declaration of without_params. Fix formatting.
7707
7708 2019-07-01 Tom Tromey <tromey@adacore.com>
7709
7710 * ada-exp.y (find_primitive_type): Update.
7711 * ada-lang.h (ada_lookup_symbol): Update.
7712 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7713 parameter.
7714 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7715
7716 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7717
7718 PR breakpoints/24541
7719 * gdbarch.c: Regenerate.
7720 * gdbarch.h: Regenerate.
7721 * gdbarch.sh: Add 'stap_adjust_register'.
7722 * i386-tdep.c: Include '<unordered_set>'.
7723 (i386_stap_adjust_register): New function.
7724 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7725 * stap-probe.c (stap_parse_register_operand): Call
7726 'gdbarch_stap_adjust_register'.
7727
7728 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7729
7730 PR python/24742
7731 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7732 * python/python.c (do_start_initialization): Use 'xmalloc'
7733 instead of 'PyMem_Malloc'.
7734
7735 2019-06-28 Tom Tromey <tromey@adacore.com>
7736
7737 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7738 for Ada.
7739
7740 2019-06-27 Tom Tromey <tromey@adacore.com>
7741
7742 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7743 objfile_key.
7744 (arm_find_mapping_symbol, arm_record_special_symbol)
7745 (_initialize_arm_tdep): Update.
7746 (arm_objfile_data_free): Remove.
7747
7748 2019-06-27 Tom Tromey <tromey@adacore.com>
7749
7750 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7751 to cp_print_static_field.
7752
7753 2019-06-26 Tom Tromey <tromey@adacore.com>
7754
7755 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7756 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7757 declare.
7758
7759 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7760
7761 * features/aarch64-core.c (create_feature_aarch64_core):
7762 Regenerate.
7763 * features/aarch64-core.xml: Add cpsr flags.
7764
7765 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7766
7767 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7768 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7769
7770 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7771
7772 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7773 field.
7774 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7775 use.
7776 (arm_record_special_symbol): Don't insert new symbol in sorted
7777 position, push it at the end.
7778
7779 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7780
7781 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7782 (arm_mapping_symbol_s): Remove.
7783 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7784 (arm_mapping_symbol_vec): New typedef.
7785 (struct arm_per_objfile): Add constructor.
7786 <section_maps>: Change type to
7787 std::unique_ptr<arm_mapping_symbol_vec[]>.
7788 (arm_compare_mapping_symbols): Remove.
7789 (arm_find_mapping_symbol): Adjust to section_maps type change.
7790 (arm_objfile_data_free): Call delete on arm_per_objfile.
7791 (arm_record_special_symbol): Adjust to section_maps type change.
7792 Allocate arm_per_objfile with new.
7793
7794 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7795
7796 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7797 with the command prefix.
7798
7799 2019-06-25 Tom Tromey <tom@tromey.com>
7800
7801 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7802 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7803
7804 2019-06-25 Tom Tromey <tom@tromey.com>
7805
7806 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7807 type.
7808 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7809 protected.
7810
7811 2019-06-25 Tom Tromey <tom@tromey.com>
7812
7813 * tui/tui-winsource.c
7814 (tui_source_window_base::set_is_exec_point_at): Add check against
7815 LOA_ADDRESS.
7816
7817 2019-06-25 Tom Tromey <tom@tromey.com>
7818
7819 * tui/tui-source.c (tui_set_source_content): Don't check before
7820 xfree.
7821 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7822
7823 2019-06-25 Tom Tromey <tom@tromey.com>
7824
7825 * tui/tui-winsource.h (tui_update_source_window_as_is)
7826 (tui_alloc_source_buffer, tui_line_is_displayed)
7827 (tui_addr_is_displayed): Change type of win_info.
7828 * tui/tui-winsource.c (tui_update_source_window_as_is)
7829 (tui_clear_source_content, tui_show_source_line)
7830 (tui_show_source_content, tui_source_window_base::refill)
7831 (tui_source_window_base::set_is_exec_point_at)
7832 (tui_source_window_base::set_is_exec_point_at)
7833 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7834 (tui_alloc_source_buffer, tui_line_is_displayed)
7835 (tui_addr_is_displayed): Change type of win_info. Update.
7836 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7837 (tui_source_window_base::do_make_visible_with_new_height):
7838 Update.
7839 * tui/tui-source.c (tui_set_source_content)
7840 (tui_set_source_content_nil)
7841 (tui_source_window::do_scroll_vertical): Update.
7842 * tui/tui-layout.c (show_layout): Update.
7843 * tui/tui-disasm.c (tui_set_disassem_content)
7844 (tui_disasm_window::do_scroll_vertical): Update.
7845 * tui/tui-data.h (tui_win_content): Remove.
7846 (struct tui_gen_win_info) <content, content_size>: Remove.
7847 (struct tui_source_element): Add initializers and destructor.
7848 (union tui_which_element, struct tui_win_element): Remove.
7849 (struct tui_source_window_base) <content>: New field.
7850 (struct tui_data_window): Remove destructor.
7851 (tui_alloc_content, tui_free_win_content)
7852 (tui_free_all_source_wins_content): Don't declare.
7853 * tui/tui-data.c (tui_initialize_static_data): Update.
7854 (init_content_element, tui_alloc_content): Remove.
7855 (~tui_gen_win_info): Update.
7856 (~tui_data_window, tui_free_all_source_wins_content)
7857 (tui_free_win_content, free_content, free_content_elements):
7858 Remove.
7859
7860 2019-06-25 Tom Tromey <tom@tromey.com>
7861
7862 * tui/tui-winsource.h (tui_clear_source_content)
7863 (tui_erase_source_content, tui_show_source_content): Change type
7864 of win_info.
7865 * tui/tui-winsource.c (tui_clear_source_content)
7866 (tui_erase_source_content, tui_show_source_content): Change type
7867 of win_info.
7868 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7869 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7870 win_info.
7871 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7872 win_info.
7873 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7874
7875 2019-06-25 Tom Tromey <tom@tromey.com>
7876
7877 * tui/tui-winsource.c (tui_clear_source_content)
7878 (tui_source_window_base::set_is_exec_point_at): Update.
7879 * tui/tui-source.c (tui_set_source_content_nil): Update.
7880 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7881 a bool.
7882 * tui/tui-data.c (init_content_element): Update.
7883
7884 2019-06-25 Tom Tromey <tom@tromey.com>
7885
7886 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7887 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7888 * tui/tui-layout.c (init_and_make_win): Update.
7889 * tui/tui.h (enum tui_win_type): Update.
7890 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7891 tui_win_is_auxillary.
7892 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7893 tui_win_is_auxillary.
7894
7895 2019-06-25 Tom Tromey <tom@tromey.com>
7896
7897 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7898 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7899 (tui_delete_data_content_windows, tui_display_all_data)
7900 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7901 Update.
7902 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7903 * tui/tui-regs.c (tui_last_regs_line_no)
7904 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7905 (tui_show_registers): Update.
7906 (tui_show_register_group): Return void. Update.
7907 (tui_display_registers_from, tui_display_reg_element_at_line)
7908 (tui_display_registers_from_line, tui_check_register_values):
7909 Update.
7910 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7911 member.
7912 (struct tui_data_window) <regs_content>: Now a std::vector.
7913 <regs_content_count>: Remove.
7914 (tui_add_content_elements, tui_free_data_content): Don't declare.
7915 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7916 (init_content_element): Remove DATA_WIN case. Add assert.
7917 (tui_add_content_elements): Remove.
7918 (tui_data_window): Update.
7919 (tui_free_data_content): Remove.
7920 (free_content_elements): Remove DATA_WIN case.
7921
7922 2019-06-25 Tom Tromey <tom@tromey.com>
7923
7924 * tui/tui-data.c (tui_data_item_window): Update.
7925 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7926 * tui/tui-windata.c (tui_display_all_data)
7927 (tui_display_data_from_line): Update.
7928 (tui_check_data_values): Remove.
7929 * tui/tui-regs.c (tui_show_register_group)
7930 (tui_display_reg_element_at_line): Update.
7931 * tui/tui-hooks.c (tui_register_changed)
7932 (tui_refresh_frame_and_register_information): Call
7933 tui_check_register_values.
7934 * tui/tui-data.h (struct tui_data_window) <data_content,
7935 data_content_count, data_type>: Remove.
7936 (enum tui_data_type): Remove.
7937
7938 * tui/tui-data.c (tui_data_window::clear_detail)
7939 (~tui_data_window): Update.
7940
7941 2019-06-25 Tom Tromey <tom@tromey.com>
7942
7943 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7944 declare.
7945 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7946 Rename from tui_first_data_item_displayed. Update.
7947 (tui_data_window::refresh_all)
7948 (tui_data_window::do_scroll_vertical): Update.
7949 * tui/tui-data.h (struct tui_data_window)
7950 <first_data_item_displayed>: Declare new method.
7951
7952 2019-06-25 Tom Tromey <tom@tromey.com>
7953
7954 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7955 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7956 contents...
7957 (tui_initialize_static_data): ...here.
7958
7959 2019-06-25 Tom Tromey <tom@tromey.com>
7960
7961 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7962 (tui_display_registers_from, tui_check_register_values): Update.
7963 (tui_display_register): Remove win_info parameter; update.
7964 (tui_get_register): Change type of parameters.
7965 * tui/tui-data.h (struct tui_data_element): Remove.
7966 (union tui_which_element) <data>: Remove.
7967 <data_window>: Change type.
7968 (struct tui_data_item_window): New.
7969 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7970 case. Add assert.
7971 (~tui_data_item_window): New destructor.
7972 (free_content_elements): Remove DATA_ITEM_WIN case.
7973
7974 2019-06-25 Tom Tromey <tom@tromey.com>
7975
7976 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7977 Remove.
7978
7979 2019-06-25 Tom Tromey <tom@tromey.com>
7980
7981 * tui/tui-data.h (struct tui_command_element): Remove.
7982 (union tui_which_element) <command>: Remove.
7983 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7984 assert.
7985 (free_content_elements): Remove CMD_WIN case.
7986
7987 2019-06-25 Tom Tromey <tom@tromey.com>
7988
7989 * tui/tui-layout.c (tui_set_layout): Update.
7990 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7991 * tui/tui-data.c (layout_def): Update.
7992
7993 2019-06-25 Tom Tromey <tom@tromey.com>
7994
7995 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7996 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7997 (tui_source_window_base::set_new_height): Update.
7998 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7999 Update.
8000 (tui_set_locator_fullname, tui_set_locator_info)
8001 (tui_show_frame_info): Update.
8002 * tui/tui-source.c (tui_set_source_content)
8003 (tui_source_is_displayed): Update.
8004 * tui/tui-layout.c (show_source_disasm_command, show_data)
8005 (show_source_or_disasm_and_command): Update.
8006 * tui/tui-disasm.c (tui_set_disassem_content)
8007 (tui_get_begin_asm_address): Update.
8008 * tui/tui-data.h (struct tui_locator_element): Remove.
8009 (union tui_which_element) <locator>: Remove.
8010 (struct tui_locator_window): New.
8011 (tui_locator_win_info_ptr): Change return type.
8012 * tui/tui-data.c (_locator): Change type.
8013 (tui_locator_win_info_ptr): Change return type.
8014 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8015 (tui_alloc_content): Add assert.
8016
8017 2019-06-25 Tom Tromey <tom@tromey.com>
8018
8019 * tui/tui-winsource.c
8020 (tui_exec_info_window::maybe_allocate_content): New method.
8021 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8022 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8023 (make_source_or_disasm_window): Add cast.
8024 * tui/tui-data.h (union tui_which_element) <simple_string>:
8025 Remove.
8026 (struct tui_source_info): New.
8027 (struct tui_source_window_base) <execution_info>: Change type.
8028 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8029 case, and add assert.
8030 (tui_alloc_content): Add assert.
8031
8032 2019-06-25 Tom Tromey <tom@tromey.com>
8033
8034 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8035 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8036 * tui/tui-data.c (tui_alloc_win_info): Remove.
8037
8038 2019-06-25 Tom Tromey <tom@tromey.com>
8039
8040 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8041 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8042 can_highlight.
8043
8044 2019-06-25 Tom Tromey <tom@tromey.com>
8045
8046 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8047 make_visible_with_new_height method.
8048 (tui_win_info::make_visible_with_new_height): New method.
8049 (tui_source_window_base::do_make_visible_with_new_height)
8050 (tui_data_window::do_make_visible_with_new_height)
8051 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8052 (make_visible_with_new_height): Remove.
8053 (tui_resize_all, tui_adjust_win_heights): Use
8054 make_visible_with_new_height method.
8055 * tui/tui-data.h (struct tui_win_info)
8056 <do_make_visible_with_new_height, make_visible_with_new_height>:
8057 New methods.
8058 (struct tui_source_window_base, struct tui_data_window)
8059 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8060 methods.
8061
8062 2019-06-25 Tom Tromey <tom@tromey.com>
8063
8064 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8065 method.
8066 (update_tab_width): Call update_tab_width method.
8067 * tui/tui-data.h (struct tui_win_info)
8068 (struct tui_source_window_base) <update_tab_width>: New methods.
8069
8070 2019-06-25 Tom Tromey <tom@tromey.com>
8071
8072 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8073 parameter.
8074 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8075 parameter.
8076 (tui_gen_win_info::make_visible): Update.
8077 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8078 parameter.
8079 * tui/tui-data.h (enum tui_box): New enum.
8080 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8081
8082 2019-06-25 Tom Tromey <tom@tromey.com>
8083
8084 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8085 init_and_make_win for EXEC_INFO_WIN.
8086 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8087 longer inline.
8088 (struct tui_win_info) <~tui_win_info>: Inline.
8089 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8090 Don't declare.
8091 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8092 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8093 Remove.
8094 (tui_initialize_static_data): Update.
8095 (~tui_gen_win_info): Handle more cleanup here.
8096 (~tui_source_window_base): Delete "execution_info".
8097 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8098
8099 2019-06-25 Tom Tromey <tom@tromey.com>
8100
8101 * tui/tui-layout.c (make_command_window): Don't set
8102 can_highlight.
8103 (show_source_disasm_command): Call the reset method.
8104 (show_data): Don't set can_highlight. Call the reset method.
8105 (tui_gen_win_info::reset): Rename from init_gen_win_info
8106 (init_and_make_win): Simplify. Return tui_gen_win_info.
8107 (show_source_or_disasm_and_command): Call the reset method.
8108 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8109 (struct tui_cmd_window): Set can_highlight.
8110
8111 2019-06-25 Tom Tromey <tom@tromey.com>
8112
8113 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8114 from make_visible.
8115 (tui_make_visible, tui_make_invisible): Rewrite.
8116 (tui_win_info::make_visible): Remove.
8117 (tui_source_window_base::make_visible): Update.
8118 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8119 method. Moved from...
8120 (struct tui_win_info) <make_visible>: ...here.
8121
8122 2019-06-25 Tom Tromey <tom@tromey.com>
8123
8124 * tui/tui-winsource.c
8125 (tui_source_window_base::do_scroll_horizontal): Remove direction
8126 parameter.
8127 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8128 direction parameter.
8129 * tui/tui-win.c (tui_win_info::forward_scroll)
8130 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8131 (tui_win_info::right_scroll): Update.
8132 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8133 direction parameter.
8134 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8135 direction parameter.
8136 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8137 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8138 Remove direction parameter.
8139 (struct tui_source_window_base, struct tui_source_window)
8140 (struct tui_disasm_window, struct tui_data_window)
8141 (struct tui_cmd_window): Update.
8142
8143 2019-06-25 Tom Tromey <tom@tromey.com>
8144
8145 * tui/tui-winsource.h (tui_set_exec_info_content)
8146 (tui_show_exec_info_content, tui_erase_exec_info_content)
8147 (tui_clear_exec_info_content, tui_update_exec_info): Change
8148 argument to tui_source_window_base.
8149 * tui/tui-winsource.c (tui_set_exec_info_content)
8150 (tui_show_exec_info_content, tui_erase_exec_info_content)
8151 (tui_clear_exec_info_content, tui_update_exec_info): Change
8152 argument to tui_source_window_base.
8153
8154 2019-06-25 Tom Tromey <tom@tromey.com>
8155
8156 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8157 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8158
8159 2019-06-25 Tom Tromey <tom@tromey.com>
8160
8161 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8162 check.
8163
8164 2019-06-25 Tom Tromey <tom@tromey.com>
8165
8166 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8167 type to void.
8168 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8169 type to void.
8170 * tui/tui-source.c (tui_set_source_content): Update.
8171 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8172
8173 2019-06-25 Tom Tromey <tom@tromey.com>
8174
8175 * tui/tui-win.c (window_name_completer, tui_set_focus)
8176 (tui_all_windows_info): Use name method.
8177 * tui/tui-data.h (struct tui_gen_win_info)
8178 (struct tui_source_window, struct tui_disasm_window)
8179 (struct tui_data_window, struct tui_cmd_window) <name>: New
8180 method.
8181 (tui_win_name): Don't declare.
8182 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8183 (tui_win_name): Remove.
8184
8185 2019-06-25 Tom Tromey <tom@tromey.com>
8186
8187 * tui/tui-winsource.h (tui_update_source_window)
8188 (tui_update_source_window_as_is): Change parameter type.
8189 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8190 to be a tui_source_window_base.
8191 (tui_update_source_window_as_is): Likewise.
8192 * tui/tui-win.c (make_visible_with_new_height): Update.
8193
8194 2019-06-25 Tom Tromey <tom@tromey.com>
8195
8196 * tui/tui-winsource.c (tui_erase_source_content)
8197 (tui_show_source_content, tui_show_exec_info_content)
8198 (tui_erase_exec_info_content): Use refresh_window method.
8199 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8200 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8201 from tui_refresh_win.
8202 (tui_data_window::refresh_window): New method.
8203 (tui_win_info::refresh, tui_source_window_base::refresh)
8204 (tui_refresh_all): Use refresh_window method.
8205 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8206 method.
8207 * tui/tui-regs.c (tui_display_register): Call refresh_window
8208 method.
8209 * tui/tui-layout.c (show_source_disasm_command)
8210 (show_source_or_disasm_and_command): Call refresh_window method.
8211 * tui/tui-data.h (struct tui_gen_win_info)
8212 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8213 New method.
8214
8215 2019-06-25 Tom Tromey <tom@tromey.com>
8216
8217 * tui/tui.c (tui_rl_other_window, tui_enable)
8218 (tui_is_window_visible, tui_get_command_dimension): Update.
8219 * tui/tui-winsource.c (tui_update_source_window_as_is)
8220 (tui_clear_source_content, tui_erase_source_content)
8221 (tui_show_source_line, tui_source_window_base::refill)
8222 (tui_source_window_base::do_scroll_horizontal)
8223 (tui_source_window_base::set_is_exec_point_at)
8224 (tui_update_breakpoint_info, tui_set_exec_info_content)
8225 (tui_alloc_source_buffer, tui_line_is_displayed)
8226 (tui_addr_is_displayed): Update.
8227 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8228 (tui_check_and_display_highlight_if_needed)
8229 (tui_win_info::make_visible, tui_win_info::refresh)
8230 (tui_refresh_all): Update.
8231 * tui/tui-windata.c (tui_first_data_item_displayed)
8232 (tui_delete_data_content_windows, tui_erase_data_content)
8233 (tui_display_all_data, tui_data_window::refresh_all)
8234 (tui_check_data_values): Update.
8235 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8236 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8237 (tui_win_info::backward_scroll, tui_refresh_all_win)
8238 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8239 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8240 (tui_source_window_base::set_new_height)
8241 (tui_data_window::set_new_height)
8242 (make_invisible_and_set_new_height)
8243 (make_visible_with_new_height, new_height_ok)
8244 (parse_scrolling_args): Update.
8245 * tui/tui-stack.c (tui_show_frame_info): Update.
8246 * tui/tui-source.c (tui_set_source_content)
8247 (tui_set_source_content_nil, tui_source_is_displayed)
8248 (tui_source_window::do_scroll_vertical): Update.
8249 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8250 (tui_display_registers_from, tui_display_reg_element_at_line)
8251 (tui_check_register_values, tui_reg_command): Update.
8252 * tui/tui-layout.c (tui_default_win_height)
8253 (show_source_disasm_command, show_data, init_and_make_win)
8254 (show_source_or_disasm_and_command): Update.
8255 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8256 (tui_redisplay_readline, tui_mld_flush)
8257 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8258 (tui_getc): Update.
8259 * tui/tui-disasm.c (tui_set_disassem_content)
8260 (tui_disasm_window::do_scroll_vertical): Update.
8261 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8262 Now virtual.
8263 (struct tui_win_info): Derive from tui_gen_win_info.
8264 <~tui_win_info>: Mark as override.
8265 <generic>: Remove member.
8266 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8267 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8268 (~tui_data_window, ~tui_win_info)
8269 (tui_free_all_source_wins_content): Update.
8270 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8271
8272 2019-06-25 Tom Tromey <tom@tromey.com>
8273
8274 * tui/tui-layout.c (init_and_make_win): Use new.
8275 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8276 destructor, initializers.
8277 (tui_alloc_generic_win_info): Don't declare.
8278 * tui/tui-data.c (_locator): Add argument to constructor.
8279 (source_win, disasm_win): New globals.
8280 (exec_info): Remove.
8281 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8282 Update.
8283 (tui_alloc_generic_win_info): Remove.
8284 (init_content_element): Use new.
8285 (tui_win_info::tui_win_info): Update.
8286 (free_content_elements) <case DATA_WIN>: Use delete.
8287
8288 2019-06-25 Tom Tromey <tom@tromey.com>
8289
8290 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8291 * tui/tui-windata.c (tui_first_data_item_displayed)
8292 (tui_delete_data_content_windows): Update.
8293 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8294 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8295 (tui_display_registers_from, tui_check_register_values): Update.
8296 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8297 pointer.
8298 * tui/tui-data.c (init_content_element): Update. Allocate the new
8299 window.
8300 (tui_free_data_content): Update.
8301 (free_content_elements) <case DATA_WIN>: Free the window.
8302
8303 2019-06-25 Tom Tromey <tom@tromey.com>
8304
8305 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8306 Update.
8307 * tui/tui-layout.c (make_command_window)
8308 (show_source_disasm_command, show_data, init_and_make_win)
8309 (show_source_or_disasm_and_command): Update.
8310 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8311 method.
8312 <can_highight, is_highlighted>: Now bool.
8313 (tui_set_win_highlight): Don't declare.
8314 * tui/tui-data.c (tui_set_win_highlight): Remove.
8315
8316 2019-06-25 Tom Tromey <tom@tromey.com>
8317
8318 * tui/tui-wingeneral.c (make_visible): Remove check of window
8319 type.
8320
8321 2019-06-25 Tom Tromey <tom@tromey.com>
8322
8323 * tui/tui-win.c (tui_win_info::max_height)
8324 (tui_cmd_window::max_height): New methods.
8325 (new_height_ok): Call max_height.
8326 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8327 <max_height>: New method.
8328
8329 2019-06-25 Tom Tromey <tom@tromey.com>
8330
8331 * tui/tui-win.c (tui_source_window_base::set_new_height)
8332 (tui_data_window::set_new_height): New methods.
8333 (make_invisible_and_set_new_height): Call set_new_height method.
8334 * tui/tui-data.h (struct tui_win_info)
8335 (struct tui_source_window_base, struct tui_data_window)
8336 <set_new_height>: New method.
8337
8338 2019-06-25 Tom Tromey <tom@tromey.com>
8339
8340 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8341 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8342 tui_refresh_data_win.
8343 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8344 method.
8345 (tui_refresh_all_win): Call the refresh_all method.
8346 (tui_set_focus): Likewise.
8347 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8348 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8349 Likewise.
8350
8351 2019-06-25 Tom Tromey <tom@tromey.com>
8352
8353 * tui/tui-winsource.h (tui_refill_source_window)
8354 (tui_set_is_exec_point_at): Don't declare.
8355 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8356 (tui_source_window_base::refill): Rename from
8357 tui_refill_source_window.
8358 (tui_source_window_base::do_scroll_horizontal): Update.
8359 (tui_source_window_base::set_is_exec_point_at): Rename from
8360 tui_set_is_exec_point_at.
8361 (tui_update_all_breakpoint_info): Update.
8362 * tui/tui-stack.c (tui_show_frame_info): Update.
8363 * tui/tui-layout.c (show_data): Add cast.
8364 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8365 * tui/tui-data.h (struct tui_source_window_base) <refill,
8366 set_is_exec_point_at>: New methods.
8367 (tui_source_windows, tui_add_to_source_windows): Update types.
8368 (tui_add_to_source_windows): Remove redundant declaration.
8369 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8370 (tui_source_windows): Change return type.
8371 (tui_clear_source_windows_detail): Update.
8372 (tui_add_to_source_windows): Change type of parameter.
8373 (tui_free_all_source_wins_content): Update.
8374
8375 2019-06-25 Tom Tromey <tom@tromey.com>
8376
8377 * tui/tui-wingeneral.c (tui_win_info::refresh)
8378 (tui_source_window_base::refresh): New methods.
8379 (tui_refresh_all): Call the refresh method.
8380 * tui/tui-data.h (struct tui_win_info)
8381 (struct tui_source_window_base) <refresh>: New method.
8382
8383 2019-06-25 Tom Tromey <tom@tromey.com>
8384
8385 * tui/tui.h (tui_is_window_visible): Return bool.
8386 * tui/tui.c (tui_is_window_visible): Return bool.
8387 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8388 (tui_make_visible, tui_make_invisible)
8389 (tui_win_info::make_visible)
8390 (tui_source_window_base::make_visible, make_all_visible)
8391 (tui_make_all_visible, tui_make_all_invisible): Update.
8392 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8393 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8394 bool.
8395 (struct tui_win_info, struct tui_source_window_base)
8396 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8397 * tui/tui-data.c (tui_init_generic_part): Update.
8398
8399 2019-06-25 Tom Tromey <tom@tromey.com>
8400
8401 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8402 (tui_source_window_base::make_visible): New methods.
8403 (make_all_visible): Make method call.
8404 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8405 (struct tui_source_window_base, struct tui_cmd_window): Override
8406 make_visible.
8407 (tui_win_is_source_type): Don't declare.
8408 * tui/tui-data.c (tui_win_is_source_type): Remove.
8409
8410 2019-06-25 Tom Tromey <tom@tromey.com>
8411
8412 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8413 NULL check.
8414
8415 2019-06-25 Tom Tromey <tom@tromey.com>
8416
8417 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8418 Inline constructor. Add initializers for members.
8419 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8420 constructors; now inline in class.
8421
8422 2019-06-25 Tom Tromey <tom@tromey.com>
8423
8424 * tui/tui-regs.c (tui_show_registers): Update.
8425 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8426 bool.
8427 * tui/tui-data.c (tui_data_window::clear_detail)
8428 (tui_data_window): Update.
8429
8430 2019-06-25 Tom Tromey <tom@tromey.com>
8431
8432 * tui/tui-windata.c (tui_display_all_data)
8433 (tui_display_data_from_line, tui_display_data_from)
8434 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8435 Update.
8436 * tui/tui-regs.c (tui_last_regs_line_no)
8437 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8438 (tui_show_registers, tui_show_register_group)
8439 (tui_display_registers_from, tui_display_reg_element_at_line)
8440 (tui_display_registers_from_line, tui_check_register_values)
8441 (tui_reg_next, tui_reg_prev): Update.
8442 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8443 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8444 tui_data_window.
8445 (struct tui_win_info) <detail>: Remove. Add new fields from
8446 tui_data_info.
8447 (TUI_DATA_WIN): Add cast.
8448 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8449 (~tui_data_window): Simplify.
8450
8451 2019-06-25 Tom Tromey <tom@tromey.com>
8452
8453 * tui/tui-layout.c (show_source_disasm_command)
8454 (show_source_or_disasm_and_command): Update.
8455 * tui/tui-io.c (update_cmdwin_start_line)
8456 (tui_redisplay_readline): Update.
8457 * tui/tui-data.h (struct tui_command_info): Remove.
8458 (struct tui_win_info) <detail>: Remove command_info member.
8459 (struct tui_data_window) <start_line>: New member, from
8460 tui_command_info.
8461 (TUI_CMD_WIN): Add casts.
8462
8463 2019-06-25 Tom Tromey <tom@tromey.com>
8464
8465 * tui/tui-winsource.c (tui_update_source_window)
8466 (tui_refill_source_window)
8467 (tui_source_window_base::do_scroll_horizontal)
8468 (tui_update_breakpoint_info, tui_set_exec_info_content)
8469 (tui_show_exec_info_content, tui_erase_exec_info_content)
8470 (tui_clear_exec_info_content): Update.
8471 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8472 Update.
8473 * tui/tui-win.c (make_invisible_and_set_new_height)
8474 (make_visible_with_new_height): Update.
8475 * tui/tui-source.c (tui_set_source_content)
8476 (tui_show_symtab_source): Update.
8477 * tui/tui-layout.c (extract_display_start_addr)
8478 (show_source_disasm_command, show_data)
8479 (make_source_or_disasm_window)
8480 (show_source_or_disasm_and_command): Update.
8481 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8482 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8483 "gdbarch".
8484 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8485 to tui_source_window_base.
8486 (struct tui_win_info) <detail>: Remove source_info member.
8487 (struct tui_source_window_base) <has_locator>: Inline.
8488 Move contents from tui_source_info; rename has_locator member to
8489 m_has_locator.
8490 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8491 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8492 header file.
8493 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8494 Simplify.
8495 (tui_free_all_source_wins_content): Cast to
8496 tui_source_window_base.
8497
8498 2019-06-25 Tom Tromey <tom@tromey.com>
8499
8500 * tui/tui-win.c (make_invisible_and_set_new_height)
8501 (make_visible_with_new_height): Call has_locator method.
8502 * tui/tui-layout.c (show_source_disasm_command, show_data)
8503 (show_source_or_disasm_and_command): Update for bool change.
8504 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8505 (tui_win_info) <has_locator>: New method.
8506 (struct tui_source_window_base) <has_locator>: New method.
8507 (tui_win_has_locator): Don't declare.
8508 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8509 from tui_win_has_locator.
8510 (tui_source_window_base): Use false, not FALSE.
8511
8512 2019-06-25 Tom Tromey <tom@tromey.com>
8513
8514 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8515 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8516 clear_detail method directly.
8517 (tui_clear_win_detail): Remove.
8518
8519 2019-06-25 Tom Tromey <tom@tromey.com>
8520
8521 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8522 "this", not TUI_DISASM_WIN.
8523
8524 2019-06-25 Tom Tromey <tom@tromey.com>
8525
8526 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8527 declare.
8528 * tui/tui-winsource.c
8529 (tui_source_window_base::do_scroll_horizontal): Rename from
8530 tui_horizontal_source_scroll.
8531 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8532 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8533 from tui_vertical_data_scroll.
8534 * tui/tui-win.h (tui_scroll): Don't declare.
8535 * tui/tui-win.c (tui_win_info::forward_scroll)
8536 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8537 (tui_win_info::right_scroll): Rename and update.
8538 (tui_scroll_forward_command, tui_scroll_backward_command)
8539 (tui_scroll_left_command, tui_scroll_right_command): Update.
8540 (tui_scroll): Remove.
8541 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8542 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8543 from tui_vertical_source_scroll.
8544 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8545 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8546 from tui_vertical_disassem_scroll.
8547 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8548 do_scroll_horizontal>: New methods.
8549 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8550 Likewise.
8551 (struct tui_source_window_base): Add do_scroll_horizontal.
8552 (struct tui_source_window, struct tui_disasm_window): Add
8553 do_scroll_vertical.
8554 (struct tui_data_window, struct tui_cmd_window): Add
8555 do_scroll_horizontal and do_scroll_vertical.
8556 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8557
8558 2019-06-25 Tom Tromey <tom@tromey.com>
8559
8560 * tui/tui-data.h (struct tui_source_window_base): New struct.
8561 (struct tui_source_window): Derive from tui_source_window_base.
8562 (struct tui_disasm_window): New struct.
8563 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8564 from tui_source_window::clear_detail.
8565 (tui_source_window_base): Rename from tui_source_window.
8566 (~tui_source_window_base): Rename from ~tui_source_window.
8567 (tui_alloc_win_info): Create a tui_disasm_window.
8568
8569 2019-06-25 Tom Tromey <tom@tromey.com>
8570
8571 * tui/tui-data.h (struct tui_source_window)
8572 (struct tui_data_window): Declare destructors.
8573 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8574 destructors.
8575 (tui_win_info): Simplify.
8576
8577 2019-06-25 Tom Tromey <tom@tromey.com>
8578
8579 * tui/tui-winsource.c (tui_display_main)
8580 (tui_update_source_windows_with_addr)
8581 (tui_update_all_breakpoint_info): Update.
8582 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8583 (new_height_ok, parse_scrolling_args): Update.
8584 * tui/tui-stack.c (tui_show_frame_info): Update.
8585 * tui/tui-data.h (struct tui_list): Remove.
8586 (tui_source_windows): Return a reference to a std::vector.
8587 * tui/tui-data.c (source_windows): Now a std::vector.
8588 (tui_source_windows): Change return type.
8589 (tui_clear_source_windows): Rewrite.
8590 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8591 (tui_free_all_source_wins_content): Rewrite.
8592
8593 2019-06-25 Tom Tromey <tom@tromey.com>
8594
8595 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8596 (struct tui_data_window, struct tui_cmd_window): Declare
8597 clear_detail method.
8598 * tui/tui-data.c (tui_source_window::clear_detail)
8599 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8600 methods.
8601 (tui_clear_win_detail): Simplify.
8602
8603 2019-06-25 Tom Tromey <tom@tromey.com>
8604
8605 * tui/tui-layout.c (make_source_window, make_disasm_window)
8606 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8607 Return the new window.
8608 (show_source_disasm_command, show_data)
8609 (show_source_or_disasm_and_command): Update.
8610
8611 2019-06-25 Tom Tromey <tom@tromey.com>
8612
8613 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8614 parameter. Return the new window.
8615 (show_source_disasm_command): Update and remove NULL check.
8616 (show_source_or_disasm_and_command): Update.
8617
8618 2019-06-25 Tom Tromey <tom@tromey.com>
8619
8620 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8621
8622 2019-06-25 Tom Tromey <tom@tromey.com>
8623
8624 * tui/tui-data.h (struct tui_win_info): Make constructor
8625 protected. Make destructor virtual. Add initializers.
8626 (tui_source_window, tui_data_window, tui_cmd_window): New
8627 classes.
8628 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8629 constructor. Add "type" parameter.
8630 (tui_source_window, tui_data_window, tui_cmd_window): New
8631 constructors.
8632 (tui_alloc_win_info): Instantiate the appropriate subclass.
8633
8634 2019-06-25 Tom Tromey <tom@tromey.com>
8635
8636 * tui/tui-win.c (tui_resize_all): Use delete.
8637 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8638 destructor.
8639 (tui_free_window): Don't declare.
8640 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8641 Update.
8642
8643 2019-06-25 Tom Tromey <tom@tromey.com>
8644
8645 * tui/tui-data.h (struct tui_win_info): Add constructor.
8646 * tui/tui-data.c (tui_alloc_win_info): Use new.
8647 (tui_free_window): Use delete.
8648
8649 2019-06-22 Tom Tromey <tom@tromey.com>
8650
8651 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8652 declare.
8653 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8654
8655 2019-06-22 Tom Tromey <tom@tromey.com>
8656
8657 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8658 declare.
8659 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8660
8661 2019-06-22 Tom de Vries <tdevries@suse.de>
8662
8663 * dwarf2read.c (create_addrmap_from_aranges)
8664 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8665 instead of '%zu'.
8666
8667 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
8668
8669 * dwarf2read.h (dwarf2_section_info_def): Remove.
8670 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8671 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8672 std::vector<dwarf2_section_info>.
8673 (struct dwo_file) <~dwo_file>: Remove.
8674 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8675 types field.
8676 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8677 (dwarf2_read_debug_names): Likewise.
8678 (create_debug_types_hash_table): Change parameter type to
8679 array_view, adjust code accordingly.
8680 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8681 (partial_die_info::fixup): Likewise.
8682 (determine_prefix): Likewise.
8683 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8684
8685 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8686
8687 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8688 gdb_bfd_ref_ptr.
8689 <~dwo_file>: Remove call to gdb_bfd_unref.
8690 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8691 gdb_bfd_ref_ptr::get.
8692
8693 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8694
8695 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8696 type to htab_up.
8697 * dwarf2read.c (struct dwo_file): Initialize fields.
8698 <~dwo_file>: New.
8699 (free_dwo_file): Remove, move content to ~dwo_file.
8700 (struct dwo_file_deleter): Remove.
8701 (dwo_file_up>: Remove custom deleter.
8702 (free_dwo_files): Remove.
8703 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8704 dwo_files.
8705 (process_skeletonless_type_units): Call unique_ptr::get.
8706 (allocate_dwo_file_hash_table): Add deleter to created hash
8707 table. Change return type to htab_up.
8708 (lookup_dwo_file_slot): Don't memset dwo_file, call
8709 unique_ptr::get.
8710 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8711 (create_dwo_unit_in_dwp_v2): Likewise.
8712 (open_and_init_dwo_file): Likewise.
8713 (free_dwo_file_from_slot): Remove.
8714
8715 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8716
8717 * dwarf2read.h (struct dwarf2_section_info) <readin,
8718 is_virtual>: Change type to bool.
8719 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8720 true instead of 1.
8721
8722 2019-06-19 Tom Tromey <tom@tromey.com>
8723
8724 * tui/tui-data.h (tui_init_content_element): Don't declare.
8725
8726 2019-06-19 Tom Tromey <tom@tromey.com>
8727
8728 * tui/tui-data.h (tui_init_win_info): Don't declare.
8729
8730 2019-06-19 Tom de Vries <tdevries@suse.de>
8731
8732 * dwarf2read.h (abstract_to_concrete): Change type to
8733 std::unordered_map<sect_offset, std::vector<sect_offset>,
8734 gdb::hash_enum<sect_offset>>.
8735
8736 2019-06-19 Tom Tromey <tromey@adacore.com>
8737
8738 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8739 EVAL_AVOID_SIDE_EFFECTS specially.
8740
8741 2019-06-19 Tom Tromey <tromey@adacore.com>
8742
8743 * source-cache.c (highlighter): New global.
8744 (source_cache::get_source_lines): Create a highlighter on demand.
8745
8746 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8747
8748 * defs.h (deprecated_interactive_hook): Delete declaration.
8749 * interps.c (clear_interpreter_hooks): Remove use of
8750 deprecated_interactive_hook.
8751 * top.c (deprecated_interactive_hook): Delete definition.
8752 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8753
8754 2019-06-18 Tom de Vries <tdevries@suse.de>
8755
8756 PR gdb/24515
8757 * dwarf2read.h (abstract_to_concrete): Change type from
8758 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8759 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8760 * dwarf2read.c (read_variable): Update.
8761 (dwarf2_fetch_die_loc_sect_off): Update.
8762
8763 2019-06-17 Tom de Vries <tdevries@suse.de>
8764
8765 PR gdb/24617
8766 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8767 accessing parent[parent_len - 1].
8768
8769 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8770
8771 PR gdb/24364
8772 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8773 call dtrace_process_dof with NULL dof.
8774
8775 2019-06-16 Tom de Vries <tdevries@suse.de>
8776
8777 PR gdb/24445
8778 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8779
8780 2019-06-16 Tom Tromey <tom@tromey.com>
8781
8782 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8783 (make_all_visible): Use address of member.
8784
8785 2019-06-16 Tom Tromey <tom@tromey.com>
8786
8787 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8788 (tui_free_window, free_content, free_content_elements): Remove
8789 unnecessary cast.
8790 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8791 cast.
8792 * tui/tui-regs.c (tui_show_register_group)
8793 (tui_display_registers_from, tui_display_reg_element_at_line):
8794 Remove unnecessary cast.
8795
8796 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8797
8798 * linux-nat.c (normal_mask): Delete.
8799 (_initialize_linux_nat): Don't initialise normal_mask.
8800
8801 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8802
8803 PR gdb/24445
8804 * dwarf-index-write.h (write_psymtabs_to_index): Add
8805 dwz_basename parameter.
8806 * dwarf-index-write.c (write_gdbindex): Move file writing to
8807 write_gdbindex_1. Change return type void.
8808 (assert_file_size): Move up, remove filename parameter.
8809 (write_gdbindex_1): New function.
8810 (write_debug_names): Change return type to void, call
8811 assert_file_size.
8812 (struct index_wip_file): New struct.
8813 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8814 file logic to index_wip_file. Write index for dwz file if
8815 needed.
8816 (save_gdb_index_command): Pass basename of dwz file, if present.
8817 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8818 build-id of dwz file, if present.
8819 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8820 (dwarf2_get_dwz_file): Likewise.
8821 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8822 (dwarf2_get_dwz_file): Likewise.
8823
8824 2019-06-16 Tom Tromey <tom@tromey.com>
8825
8826 * coffread.c (process_coff_symbol): Use xstrdup.
8827 * value.c (create_internalvar): Use xstrdup.
8828
8829 2019-06-16 Tom Tromey <tom@tromey.com>
8830
8831 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8832 * breakpoint.c (stopin_command, stopat_command)
8833 (until_break_command, decode_location_default): Remove unnecessary
8834 cast.
8835 * utils.c (subset_compare): Remove unnecessary cast.
8836 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8837 cast.
8838 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8839 cast.
8840 * infcmd.c (path_command): Remove unnecessary cast.
8841 * coffread.c (decode_type): Remove unnecessary cast.
8842 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8843 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8844 * tui/tui-stack.c (tui_show_locator_content)
8845 (tui_show_frame_info): Remove unnecessary cast.
8846 * tui/tui-win.c (tui_scroll_forward_command)
8847 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8848 (parse_scrolling_args): Remove unnecessary cast.
8849 * tui/tui-data.c (init_win_info, tui_del_window)
8850 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8851 (free_content_elements): Remove unnecessary cast.
8852 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8853 unnecessary cast.
8854 * tui/tui-source.c (tui_set_source_content)
8855 (tui_vertical_source_scroll): Remove unnecessary cast.
8856 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8857 cast.
8858 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8859 * tui/tui-regs.c (tui_display_registers_from)
8860 (tui_display_register): Remove unnecessary cast.
8861 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8862 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8863 (make_visible): Remove unnecessary cast.
8864 * tui/tui-winsource.c (tui_erase_source_content)
8865 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8866 unnecessary cast.
8867 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8868 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8869 * stabsread.c (read_type, read_array_type, read_range_type):
8870 Remove unnecessary cast.
8871 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8872 (parse_symbol, parse_type, upgrade_type, parse_external)
8873 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8874 unnecessary cast.
8875 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8876
8877 2019-06-16 Tom Tromey <tom@tromey.com>
8878
8879 * tui/tui-data.c (tui_alloc_generic_win_info)
8880 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8881 checks.
8882
8883 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8884 Andrew Burgess <andrew.burgess@embecosm.com>
8885
8886 * f-typeprint.c (f_print_type): Don't return early for not
8887 associated or not allocated types.
8888 (f_type_print_varspec_suffix): Add print_rank parameter and print
8889 ranks of array types in case they dangling.
8890 (f_type_print_base): Add print_rank parameter.
8891
8892 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8893
8894 * NEWS: Mention new MI commands.
8895 * break-catch-throw.c (enum exception_event_kind): Move to
8896 breakpoint.h.
8897 (print_mention_exception_catchpoint): Output text as a single
8898 message.
8899 (catch_exception_command_1): Rename to...
8900 (catch_exception_event): ...this, make non-static, update header
8901 command, and change some parameter types.
8902 (catch_catch_command): Update for changes to
8903 catch_exception_command_1.
8904 (catch_throw_command): Likewise.
8905 (catch_rethrow_command): Likewise.
8906 * breakpoint.c (enum exception_event_kind): Delete.
8907 * breakpoint.h (enum exception_event_kind): Moved here from
8908 break-catch-throw.c.
8909 (catch_exception_event): Declare.
8910 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8911 (mi_cmd_catch_throw): New function.
8912 (mi_cmd_catch_rethrow): New function.
8913 (mi_cmd_catch_catch): New function.
8914 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8915 'catch-catch' entries.
8916 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8917 (mi_cmd_catch_rethrow): Declare.
8918 (mi_cmd_catch_catch): Declare.
8919
8920 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8921
8922 * annotate.c (annotate_source_line): Change return type to void,
8923 update implementation to match.
8924 * annotate.h (annotate_source_line): Change return type to void,
8925 update header comment.
8926 * stack.c (print_frame_info): Don't change what frame information
8927 is printed based on whether annotations are on or not.
8928
8929 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8930
8931 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8932 (annotate_source): Make static.
8933 (annotate_source_line): Moved from source.c and renamed from
8934 identify_source_line. Update the return type.
8935 * annotate.h (annotate_source): Delete declaration.
8936 (annotate_source_line): Declaration moved from source.h, and
8937 renamed from identify_source_line. Return type updated.
8938 * source.c (identify_source_line): Moved to annotate.c and renamed
8939 to annotate_source_line.
8940 (info_line_command): Remove check of annotation_level.
8941 * source.h (identify_source_line): Move declaration to annotate.h
8942 and rename to annotate_source_line.
8943 * stack.c: Add 'annotate.h' include.
8944 (print_frame_info): Remove check of annotation_level before
8945 calling annotate_source_line.
8946
8947 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8948
8949 * source-cache.c (source_cache::get_plain_source_lines): Use
8950 open_source_file_with_line_charpos instead of just
8951 open_source_file, remove call to find_source_lines.
8952 (source_cache::get_source_lines): Likewise.
8953 * source.c (find_source_lines): Make static.
8954 (get_filename_and_charpos): Renamed into...
8955 (open_source_file_with_line_charpos): ..this along with changes to
8956 return a scoped_fd, and some other minor clean ups.
8957 (identify_source_line): Use open_source_file_with_line_charpos.
8958 (search_command_helper): Use open_source_file_with_line_charpos
8959 instead of just open_source_file, remove call to
8960 find_source_lines.
8961 * source.h (open_source_file_with_line_charpos): Declare new
8962 function.
8963 (find_source_lines): Delete declaration.
8964
8965 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8966
8967 * source.c (get_filename_and_charpos): Remove fullname
8968 parameter.
8969 (identify_source_line): Update call to get_filename_and_charpos.
8970
8971 2019-06-14 Tom Tromey <tromey@adacore.com>
8972
8973 PR gdb/24502:
8974 * ui-style.h (skip_ansi_escape): Update comment.
8975 * ui-file.h (class no_terminal_escape_file): New class.
8976 * ui-file.c (no_terminal_escape_file::write)
8977 (no_terminal_escape_file::puts): New methods.
8978 * cli/cli-logging.c (handle_redirections): Use
8979 no_terminal_escape_file.
8980
8981 2019-06-14 Tom Tromey <tromey@adacore.com>
8982
8983 * NEWS: Move convenience variable news above Python news.
8984
8985 2019-06-14 Tom Tromey <tom@tromey.com>
8986
8987 * gnulib: Move directory to top-level.
8988 * configure.ac: Don't configure gnulib.
8989 * configure: Rebuild.
8990 * common/common-defs.h: Use new path to gnulib.
8991 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8992 (GNULIB_H): Remove.
8993 (INCGNU): Look in new gnulib location.
8994 (HFILES_NO_SRCDIR): Remove gnulib files.
8995 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8996 (generated_files): Remove GNULIB_H.
8997 ($(LIBGNU), all-lib): Remove targets.
8998 (distclean): Don't mention GNULIB_BUILDDIR.
8999 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9000
9001 2019-06-14 Tom Tromey <tromey@adacore.com>
9002
9003 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9004 Warn if symbol file does not provide any symbols.
9005
9006 2019-06-14 Tom Tromey <tromey@adacore.com>
9007
9008 * source.c (find_and_open_source): Respect basenames_may_differ.
9009
9010 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9011
9012 * annotate.c (annotate_breakpoints_invalid): Make use of
9013 scoped_restore_terminal_state.
9014 (annotate_frames_invalid): Likewise.
9015
9016 2019-06-14 Tom Tromey <tromey@adacore.com>
9017
9018 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9019 allow assignment to an internalvar.
9020
9021 2019-06-14 Tom Tromey <tromey@adacore.com>
9022
9023 * ada-lex.l: Allow "_" in attribute names.
9024
9025 2019-06-14 Tom Tromey <tromey@adacore.com>
9026
9027 PR gdb/24653:
9028 * regcache.c (registers_changed): Don't call alloca.
9029 * top.c (execute_command): Don't call alloca.
9030
9031 2019-06-13 Pedro Alves <palves@redhat.com>
9032
9033 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9034 'expression'. When parsing an expression, error out if there's
9035 junk after "unlimited".
9036 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9037 (do_set_command): Adjust calls to is_unlimited_literal.
9038
9039 2019-06-13 Pedro Alves <palves@redhat.com>
9040
9041 * compile/compile.c (make_compile_options_def_group): Add braces
9042 around array_view initializer.
9043 * thread.c (make_thread_apply_all_options_def_group)
9044 (make_thread_apply_all_options_def_group): Likewise.
9045
9046 2019-06-13 Pedro Alves <palves@redhat.com>
9047
9048 * NEWS (New commands): Mention "maint test-options
9049 require-delimiter", "maint test-options unknown-is-error", "maint
9050 test-options unknown-is-operand" and "maint show
9051 test-options-completion-result".
9052 (New command options, command completion): New section.
9053 (Completion improvements): New section.
9054 Mention that you can abbreviate "unlimited".
9055
9056 2019-06-13 Pedro Alves <palves@redhat.com>
9057
9058 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9059 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9060 * unittests/cli-utils-selftests.c (test_parse_flags)
9061 (test_parse_flags_qcs): Delete.
9062 (test_cli_utils): Don't call deleted functions.
9063
9064 2019-06-13 Pedro Alves <palves@redhat.com>
9065
9066 * thread.c: Include "cli/cli-option.h".
9067 (tp_array_compar_ascending): Global.
9068 (tp_array_compar): Delete function.
9069 (tp_array_compar_ascending, tp_array_compar_descending): New
9070 functions.
9071 (ascending_option_def, qcs_flag_option_def)
9072 (thr_qcs_flags_option_defs)
9073 (make_thread_apply_all_options_def_group)
9074 (make_thread_apply_options_def_group): New.
9075 (thread_apply_all_command): Use gdb::option::process_options.
9076 (thread_apply_command_completer)
9077 (thread_apply_all_command_completer): New.
9078 (thread_apply_command): Use gdb::option::process_options.
9079 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9080 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9081 to generate help text of "thread apply". Adjust "taas"'s help.
9082 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9083 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9084
9085 2019-06-13 Pedro Alves <palves@redhat.com>
9086
9087 * thread.c (thread_apply_command): Check for invalid TID with
9088 isdigit instead of !isalpha.
9089
9090 2019-06-13 Pedro Alves <palves@redhat.com>
9091
9092 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9093 (validate_flags_qcs): New.
9094 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9095 (validate_flags_qcs): Declare.
9096 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9097 (make_frame_apply_options_def_group): New.
9098 (frame_apply_command_count): Process options with
9099 gdb::option::process_options.
9100 (frame_apply_completer): New.
9101 (frame_apply_level_completer, frame_apply_all_completer)
9102 (frame_apply_completer): New.
9103 (_initialize_stack): Update help of "frame apply", "frame apply
9104 level", "frame apply all" and "faas" to mention supported options
9105 and install command completers.
9106 * stack.h (frame_apply_all_completer): Declare.
9107 * thread.c: Include "stack.h".
9108 (tfaas_command): Add "--".
9109 (_initialize_thread): Update help "tfaas" to mention supported
9110 options and install command completer.
9111
9112 2019-06-13 Pedro Alves <palves@redhat.com>
9113
9114 * completer.c (complete_nested_command_line): New.
9115 (gdb_completion_word_break_characters_throw): Add assertion.
9116 * completer.h (complete_nested_command_line): Declare.
9117
9118 2019-06-13 Pedro Alves <palves@redhat.com>
9119
9120 * stack.c (parse_backtrace_qualifiers): New.
9121 (backtrace_command): Use it.
9122 (backtrace_command_completer): Complete on qualifiers.
9123
9124 2019-06-13 Pedro Alves <palves@redhat.com>
9125
9126 * frame.c: Include "cli/cli-option.h.
9127 (user_set_backtrace_options): New.
9128 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9129 Delete.
9130 (get_prev_frame): Adjust.
9131 (boolean_option_def, uinteger_option_def)
9132 (set_backtrace_option_defs): New.
9133 (_initialize_frame): Adjust and use
9134 gdb::option::add_setshow_cmds_for_options to install "set
9135 backtrace past-main" and "set backtrace past-entry".
9136 * frame.h: Include "cli/cli-option.h".
9137 (struct frame_print_options): Forward declare.
9138 (print_frame_arguments_all, print_frame_arguments_scalars)
9139 (print_frame_arguments_none): Declare.
9140 (print_entry_values): Delete declaration.
9141 (struct frame_print_options, user_frame_print_options): New.
9142 (struct set_backtrace_options): New.
9143 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9144 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9145 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9146 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9147 (list_args_or_locals): Add frame_print_options parameter.
9148 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9149 * python/py-framefilter.c (enumerate_args): Pass down
9150 USER_FRAME_PRINT_OPTIONS.
9151 * stack.c: Include "cli/cli-option.h".
9152 (print_frame_arguments_all, print_frame_arguments_scalars)
9153 (print_frame_arguments_none): Declare.
9154 (print_raw_frame_arguments, print_entry_values): Delete.
9155 (user_frame_print_options): New.
9156 (boolean_option_def, enum_option_def, frame_print_option_defs):
9157 New.
9158 (struct backtrace_cmd_options): New.
9159 (bt_flag_option_def): New.
9160 (backtrace_command_option_defs): New.
9161 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9162 (print_frame_arg, read_frame_arg, print_frame_args)
9163 (print_frame_info, print_frame): Add frame_print_options parameter
9164 and use it.
9165 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9166 (backtrace_command_1): Add frame_print_options and
9167 backtrace_cmd_options parameters and use them.
9168 (make_backtrace_options_def_group): New.
9169 (backtrace_command): Process command options with
9170 gdb::option::process_options.
9171 (backtrace_command_completer): New.
9172 (_initialize_stack): Extend "backtrace"'s help to mention
9173 supported options. Install completer for "backtrace".
9174 Install some settings commands with add_setshow_cmds_for_options.
9175
9176 2019-06-13 Pedro Alves <palves@redhat.com>
9177
9178 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9179 and that "set/show print raw frame-arguments" are now deprecated.
9180
9181 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9182 command.
9183 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9184 * stack.c (_initialize_stack): Install "set/show print
9185 raw-frame-arguments", and deprecate "set/show print raw
9186 frame-arguments".
9187 * valprint.c (_initialize_valprint): Deprecate "set/show print
9188 raw".
9189
9190 2019-06-13 Pedro Alves <palves@redhat.com>
9191
9192 * compile/compile.c (struct compile_options): New.
9193 (compile_flag_option_def, compile_command_option_defs)
9194 (make_compile_options_def_group): New.
9195 (compile_file_command): Handle options with
9196 gdb::option::process_options.
9197 (compile_file_command_completer): New function.
9198 (compile_code_command): Handle options with
9199 gdb::option::process_options.
9200 (compile_code_command_completer): New function.
9201 (_initialize_compiler): Install completers for "compile code" and
9202 "compile file". Mention available options in "compile code" and
9203 "compile code"'s help.
9204 * completer.c (advance_to_completion_word): New, factored out from
9205 ...
9206 (advance_to_expression_complete_word_point): ... this.
9207 (advance_to_filename_complete_word_point): New.
9208 * completer.h (advance_to_filename_complete_word_point): New
9209 declaration.
9210
9211 2019-06-13 Pedro Alves <palves@redhat.com>
9212
9213 * compile/compile.c: Include "cli/cli-option.h".
9214 (compile_print_value): Scope data pointer is now a
9215 value_print_options pointer; adjust.
9216 (compile_print_command): Process options. Scope data pointer is
9217 now a value_print_options pointer; adjust.
9218 (_initialize_compile): Update "compile print"'s help to include
9219 supported options. Install a completer for "compile print".
9220 * cp-valprint.c (show_vtblprint, show_objectprint)
9221 (show_static_field_print): Delete.
9222 (_initialize_cp_valprint): Don't install "set print
9223 static-members", "set print vtbl", "set print object" here.
9224 * printcmd.c: Include "cli/cli-option.h" and
9225 "common/gdb_optional.h".
9226 (print_command_parse_format): Rework to fill in a
9227 value_print_options instead of a format_data.
9228 (print_value): Change parameter type from format_data pointer to
9229 value_print_options reference. Adjust.
9230 (print_command_1): Process options. Adjust to pass down a
9231 value_print_options.
9232 (print_command_completer): New.
9233 (_initialize_printcmd): Install print_command_completer as
9234 handle_brkchars completer for the "print" command. Update
9235 "print"'s help to include supported options.
9236 * valprint.c: Include "cli/cli-option.h".
9237 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9238 here from cp-valprint.c.
9239 (boolean_option_def, uinteger_option_def)
9240 (value_print_option_defs, make_value_print_options_def_group):
9241 New. Use gdb::option::add_setshow_cmds_for_options to install
9242 "set print elements", "set print null-stop", "set print repeats",
9243 "set print pretty", "set print union", "set print array", "set
9244 print address", "set print symbol", "set print array-indexes".
9245 * valprint.h: Include <string> and "cli/cli-option.h".
9246 (make_value_print_options_def_group): Declare.
9247 (print_value): Change parameter type from format_data pointer to
9248 value_print_options reference.
9249 (print_command_completer): Declare.
9250
9251 2019-06-13 Pedro Alves <palves@redhat.com>
9252
9253 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9254 (COMMON_SFILES): Add maint-test-settings.c.
9255 * cli/cli-decode.c (boolean_enums): New global, factored out from
9256 ...
9257 (add_setshow_boolean_cmd): ... here.
9258 * cli/cli-decode.h (boolean_enums): Declare.
9259 * cli/cli-option.c: New file.
9260 * cli/cli-option.h: New file.
9261 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9262 factored out from ...
9263 (parse_cli_boolean_value(const char *)): ... this.
9264 (is_unlimited_literal): Change parameter type to pointer to
9265 pointer. Adjust and advance ARG pointer.
9266 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9267 (parse_cli_var_enum): New, factored out from ...
9268 (do_set_command): ... this. Adjust.
9269 * cli/cli-setshow.h (parse_cli_boolean_value)
9270 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9271 (parse_cli_var_enum): Declare.
9272 * cli/cli-utils.c: Include "cli/cli-option.h".
9273 (get_ulongest): New.
9274 * cli/cli-utils.h (get_ulongest): Declare.
9275 (check_for_argument): New overloads.
9276 * maint-test-options.c: New file.
9277
9278 2019-06-13 Pedro Alves <palves@redhat.com>
9279
9280 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9281 parse a range if "-" is at the end of the string.
9282
9283 2019-06-13 Pedro Alves <palves@redhat.com>
9284
9285 * cli/cli-setshow.c (parse_auto_binary_operation)
9286 (parse_cli_boolean_value): Don't allow "o".
9287
9288 2019-06-13 Pedro Alves <palves@redhat.com>
9289
9290 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9291 * NEWS: Mention maint test-settings KIND.
9292 * maint-test-settings.c: New file.
9293
9294 2019-06-13 Pedro Alves <palves@redhat.com>
9295
9296 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9297 completer.
9298 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9299 "set" completers.
9300
9301 2019-06-13 Pedro Alves <palves@redhat.com>
9302
9303 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9304 after item.
9305
9306 2019-06-13 Pedro Alves <palves@redhat.com>
9307
9308 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9309
9310 2019-06-13 Pedro Alves <palves@redhat.com>
9311
9312 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9313 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9314 call.
9315 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9316 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9317 calls.
9318 (check_for_argument): Skip spaces after argument.
9319
9320 2019-06-13 Pedro Alves <palves@redhat.com>
9321
9322 * thread.c (thread_apply_command): Adjust TID parsing.
9323 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9324 detected before end of string.
9325 (tid_is_in_list): Error out if LIST is invalid.
9326
9327 2019-06-13 Pedro Alves <palves@redhat.com>
9328
9329 * completer.c (complete_line_internal_1): Rewind completion word
9330 point.
9331 (completion_tracker::advance_custom_word_point_by): Change
9332 parameter type to int.
9333 * completer.h (completion_tracker::advance_custom_word_point_by):
9334 Likewise.
9335
9336 2019-06-13 Pedro Alves <palves@redhat.com>
9337
9338 * completer.c (advance_to_completion_word): Handle delimiters.
9339
9340 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9341
9342 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9343
9344 2019-06-11 Tom Tromey <tom@tromey.com>
9345
9346 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9347 (xmalloc_failed): Move to alloc.c.
9348 * alloc.c: New file.
9349 * Makefile.in (COMMON_SFILES): Add alloc.c.
9350
9351 2019-06-11 Tom Tromey <tom@tromey.com>
9352
9353 * nat/linux-waitpid.c: Don't include server.h.
9354 (linux_debug): Remove.
9355 (my_waitpid): Update.
9356
9357 2019-06-11 Tom Tromey <tromey@adacore.com>
9358
9359 * infcall.c (_initialize_infcall): Remove trailing newline from
9360 help.
9361 * user-regs.c (_initialize_user_regs): Remove trailing newline
9362 from help.
9363 * typeprint.c (_initialize_typeprint): Remove trailing newline
9364 from help.
9365 * reverse.c (_initialize_reverse): Remove trailing newlines from
9366 help.
9367 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9368 from help.
9369 * language.c (add_set_language_command): Remove trailing newline
9370 from help.
9371 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9372 help.
9373 * disasm.c (_initialize_disasm): Remove trailing newline from
9374 help.
9375 * top.c (init_main): Remove trailing newline from help.
9376 * interps.c (_initialize_interpreter): Remove trailing newline
9377 from help.
9378 * btrace.c (_initialize_btrace): Remove trailing newlines from
9379 help.
9380 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9381 from help.
9382 * python/python.c (_initialize_python): Remove trailing newline
9383 from help.
9384 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9385 help.
9386 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9387 from help. Reformat some text.
9388 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9389 from help.
9390 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9391 newline from help.
9392
9393 2019-06-11 Tom Tromey <tromey@adacore.com>
9394
9395 * darwin-nat.c (darwin_decode_exception_message)
9396 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9397
9398 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9399
9400 * valops.c (value_slice): Check for not allocated or not
9401 associated values.
9402
9403 2019-06-10 Tom de Vries <tdevries@suse.de>
9404
9405 PR gdb/24618
9406 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9407 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9408 invalid.
9409
9410 2019-06-10 Tom de Vries <tdevries@suse.de>
9411
9412 PR gdb/24611
9413 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9414 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9415
9416 2019-06-10 Tom de Vries <tdevries@suse.de>
9417
9418 PR symtab/24545
9419 * symtab.c (struct demangled_name_entry): Add language field.
9420 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9421 static minimal symbol". Set and use language field.
9422
9423 2019-06-10 Tom Tromey <tromey@adacore.com>
9424
9425 * ada-lang.c (_initialize_ada_language): Update help text.
9426
9427 2019-06-10 Tom Tromey <tromey@adacore.com>
9428
9429 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9430 with a newline.
9431 * guile/guile.c (handle_boot_error): Don't end warning with a
9432 newline.
9433 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9434 warning with a newline.
9435 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9436 newline.
9437 (s12z_frame_cache): Likewise.
9438 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9439 a newline.
9440 * solib-svr4.c (disable_probes_interface): Don't end warning with
9441 a newline.
9442 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9443 newline.
9444 * python/python.c (do_finish_initialization): Don't end warning
9445 with a newline.
9446
9447 2019-06-10 Tom Tromey <tom@tromey.com>
9448
9449 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9450 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9451 gdbpy_enter.
9452
9453 2019-06-10 Tom Tromey <tromey@adacore.com>
9454
9455 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9456 data.
9457 (elf_new_init): Don't call stabsread_new_init.
9458 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9459 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9460 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9461
9462 2019-06-10 Tom de Vries <tdevries@suse.de>
9463
9464 PR symtab/16264
9465 PR symtab/24517
9466 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9467
9468 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9469
9470 * source.c (find_and_open_source): Also rewrite relative file
9471 names.
9472
9473 2019-04-26 Amos Bird <amosbird@gmail.com>
9474
9475 * annotate.c (annotate_thread_exited): Add "thread-exited"
9476 annotation.
9477
9478 2019-06-06 Tom Tromey <tromey@adacore.com>
9479
9480 * maint.h (class scoped_command_stats): Use
9481 DISABLE_COPY_AND_ASSIGN.
9482 <print_time>: New method.
9483 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9484 print_time.
9485 (scoped_command_stats::print_time): New method.
9486
9487 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9488
9489 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9490 instructions of lengths 6 or 8 bytes.
9491
9492 2019-06-04 Pedro Alves <palves@redhat.com>
9493
9494 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9495
9496 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9497 * breakpoint.c (condition_completer): Likewise.
9498 * cli/cli-dump.c (scan_expression): Likewise.
9499 * common/filestuff.c (mkdir_recursive): Likewise.
9500 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9501 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9502 (gdb_abspath): Likewise.
9503 * compile/compile-cplus-types.c
9504 (compile_cplus_instance::decl_name): Likewise.
9505 * completer.c (complete_explicit_location):
9506 (signal_completer, reg_or_group_completer_1): Likewise.
9507 * cp-support.c (cp_remove_params_if_any): Likewise.
9508 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9509 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9510 * infcmd.c (strip_bg_char): Likewise.
9511 * linespec.c (copy_token_string): Likewise.
9512 * mi/mi-main.c (output_cores): Likewise.
9513 * psymtab.c (psymtab_search_name):
9514 * symfile.c (test_set_ext_lang_command): Likewise.
9515 * target.c (target_fileio_read_stralloc): Likewise.
9516 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9517 * value.c (complete_internalvar): Likewise.
9518
9519 2019-06-04 Christian Biesinger <cbiesinger@google.com>
9520
9521 Add objfile property to gdb.Type.
9522 * NEWS: Mention Python API addition.
9523 * python/py-type.c (typy_get_objfile): New method.
9524
9525 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9526
9527 * NEWS: Mention the new set|show style [title|highlight].
9528 Mention changes to "show style", "help" and "apropos".
9529
9530 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9531
9532 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9533 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9534 instead of print_help_for_command.
9535 (print_doc_of_command): New function.
9536 (help_list): Add 'apropos -v word' suggestion.
9537 (print_help_for_command): Style the command name using title style.
9538 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9539 (_initialize_cli_cmds): Describe -v in apropos_command help.
9540
9541 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9542
9543 * cli/cli-style.h (cli_style_option): Add name in constructor,
9544 add m_name class member, add constructor with intensity,
9545 add name class function.
9546 (cli_style_option::add_setshow_commands): Remove name argument.
9547 (highlight_style, title_style): New styles.
9548 * cli/cli-style.c (do_show): New function that shows a style
9549 characteristic styling the style name with itself.
9550 (set_style_name): New function.
9551 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9552 Update all callers according to the changes in cli/cli-style.h.
9553 * utils.h (fputs_highlighted): New function.
9554 * utils.c (fputs_highlighted): Likewise.
9555
9556 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9557
9558 * NEWS: Mention new pipe command and new convenience variables.
9559
9560 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9561
9562 * cli/cli-cmds.c (pipe_command): New function.
9563 (_initialize_cli_cmds): Call add_com for pipe_command.
9564 Define | as an alias for pipe.
9565 (exit_status_set_internal_vars): New function.
9566 (shell_escape): Call exit_status_set_internal_vars.
9567 cli/cli-decode.c (find_command_name_length): Recognize | as
9568 a single character command.
9569
9570 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9571
9572 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9573 top.c (execute_command_to_ui_file): New function, mostly a copy
9574 of execute_command_to_string.
9575 (execute_command_to_string): Implement by calling
9576 execute_command_to_ui_file.
9577
9578 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9579
9580 * top.h (saved_command_line): Remove declaration.
9581 * top.c (previous_saved_command_line, previous_repeat_arguments):
9582 New variables.
9583 (saved_command_line): Make static, define together with other
9584 'repeat variables'.
9585 (dont_repeat): Clear repeat_arguments.
9586 (repeat_previous, get_saved_command_line, save_command_line):
9587 New functions.
9588 (gdb_init): Initialize saved_command_line
9589 and previous_saved_command_line.
9590 * main.c (captured_main_1): Remove saved_command_line initialization.
9591 * event-top.c (handle_line_of_input): Update to use
9592 the new 'repeat' related functions instead of direct access to
9593 saved_command_line.
9594 * command.h (repeat_previous, get_saved_command_line,
9595 save_command_line): New declarations.
9596 (dont_repeat): Add comment.
9597
9598 2019-05-30 Tom Tromey <tromey@adacore.com>
9599
9600 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9601 Fix comment.
9602 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9603
9604 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9605
9606 PR cli/24587
9607 * completer.c (complete): Initialize variable word.
9608
9609 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9610
9611 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9612 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9613 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9614 'body' is NULL to the outter 'if', protecting the '!is_define'
9615 situation as well.
9616
9617 2019-05-29 Tom Tromey <tromey@adacore.com>
9618
9619 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9620 (dwarf_unknown): New function.
9621 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9622 (dwarf_type_encoding_name): Use dwarf_unknown.
9623
9624 2019-05-29 Tom Tromey <tromey@adacore.com>
9625
9626 PR c++/20020:
9627 * cp-valprint.c (cp_print_value_fields): Call
9628 cp_print_static_field inside "try".
9629
9630 2019-05-29 Tom Tromey <tromey@adacore.com>
9631
9632 * inflow.c (struct terminal_info): Add default operator=.
9633 * configure: Rebuild.
9634 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9635 -Wdeprecated-copy-dtor, -Wredundant-move.
9636
9637 2019-05-29 Tom Tromey <tromey@adacore.com>
9638
9639 * NEWS: Add entry.
9640 * infcmd.c (print_return_value_1): Handle finish_print
9641 option.
9642 (show_print_finish): New function.
9643 (_initialize_infcmd): Add "set/show print finish" commands.
9644 * valprint.c (user_print_options): Initialize new member.
9645 * valprint.h (struct value_print_options) <finish_print>: New
9646 member.
9647
9648 2019-05-28 Tom Tromey <tromey@adacore.com>
9649
9650 * ada-lang.c (ada_remove_Xbn_suffix)
9651 (find_old_style_renaming_symbol)
9652 (parse_old_style_renaming): Remove.
9653 (ada_find_renaming_symbol): Don't call
9654 find_old_style_renaming_symbol.
9655 (ada_is_renaming_symbol): Rename from
9656 ada_find_renaming_symbol. Remove "block" parameter. Return
9657 bool. Now static.
9658 (ada_read_var_value): Update and simplify.
9659 * ada-exp.y (write_var_or_type): Remove old code.
9660
9661 2019-05-28 Alan Hayward <alan.hayward@arm.com>
9662
9663 PR gdb/25010
9664 * event-top.c: Remove include comment.
9665 * inflow.c (class scoped_ignore_sigttou): Move from here...
9666 * inflow.h (class scoped_ignore_sigttou): ...to here.
9667 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9668 * top.c: Remove include comment.
9669
9670 2019-05-27 Tom Tromey <tom@tromey.com>
9671
9672 * NEWS: Fix typo.
9673
9674 2019-05-22 Tom Tromey <tromey@adacore.com>
9675
9676 * target.c (target_follow_exec): Constify parameter.
9677 * target-delegates.c: Rebuild.
9678 * remote.c (remote_target::follow_exec): Constify parameter.
9679 * infrun.c (follow_exec): Constify parameter.
9680 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9681 (target_follow_exec): Likewise.
9682
9683 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9684
9685 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9686 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9687
9688 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9689
9690 * NEWS: Add debugredirect and testsuite sections.
9691
9692 2019-05-22 Simon Cook <simon.cook@embecosm.com>
9693
9694 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9695 target descriptions using exclusively floating point register name
9696 aliases.
9697
9698 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9699
9700 PR gdb/18644:
9701 * f-lang.c (build_fortran_types): Handle the case where
9702 gdbarch_floatformat_for_type returns a nullptr.
9703
9704 2019-05-21 Tom de Vries <tdevries@suse.de>
9705
9706 PR cli/24587
9707 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9708
9709 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9710
9711 PR gdb/18644:
9712 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9713 16-byte floats.
9714 * i386-tdep.c (i386_floatformat_for_type): Use
9715 floatformats_ia64_quad for the 16-byte floating point component
9716 within a fortran 32-byte complex number.
9717
9718 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9719
9720 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9721 delete default constructor.
9722 (find_partial_die): Update to return const struct.
9723 (partial_die_parent_scope): Move variable declaration into scope
9724 of its use and change its type to auto.
9725 (guess_partial_die_structure_name): Likewise.
9726 (partial_die_info::fixup): Likewise.
9727
9728 2019-05-17 Tom Tromey <tromey@adacore.com>
9729
9730 * source.c (find_and_open_source): Remove cast.
9731
9732 2019-05-17 Tom Tromey <tromey@adacore.com>
9733
9734 * annotate.c (annotate_source): Make "filename" const.
9735 * annotate.h (annotate_source): Use const.
9736
9737 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9738
9739 * disasm.c (set_disassembler_options): Send errors to stderr.
9740
9741 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9742
9743 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9744 (cli_interp_base::set_logging): Check debug_redirect.
9745 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9746 * cli/cli-logging.c (debug_redirect): Add static variable.
9747 (pop_output_files): Add default param.
9748 (handle_redirections): Print debug setting.
9749 (show_logging_command): Likewise.
9750 (_initialize_cli_logging): Add debugredirect command.
9751 * interps.c (current_interp_set_logging): Add debug_redirect
9752 parameter.
9753 * interps.h (set_logging): Add debug_redirect parameter.
9754 (current_interp_set_logging): Likewise.
9755 * mi/mi-common.h: Likewise.
9756 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9757
9758 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9759 Tom Tromey <tromey@adacore.com>
9760
9761 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9762 directly.
9763 * cli/cli-interp.h (make_logging_output): Remove declaration.
9764 * cli/cli-logging.c (make_logging_output): Remove function.
9765 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9766 directly.
9767 * ui-file.c (tee_file::tee_file): Remove bools.
9768 (tee_file::~tee_file): Remove deletes.
9769 * ui-file.h (tee_file): Remove bools.
9770
9771 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9772
9773 * mi/mi-cmds.h (mi_cmd_complete): New function.
9774 * mi/mi-main.c (mi_cmd_complete): Likewise.
9775 * mi/mi-cmds.c: Define new MI command -complete.
9776 * NEWS: Mention new -complete command.
9777
9778 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9779
9780 * completer.h (complete): New function.
9781 * completer.c (complete): Likewise.
9782 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9783 function defined in completer.h.
9784
9785 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9786
9787 * MAINTAINERS (Write After Approval): Add myself.
9788
9789 2019-05-17 Tom de Vries <tdevries@suse.de>
9790
9791 PR gdb/24094
9792 * dwarf2read.c (struct cu_partial_die_info): New struct.
9793 (find_partial_die): Return cu_partial_die_info.
9794 (partial_die_parent_scope, guess_partial_die_structure_name)
9795 (partial_die_info::fixup): Handle new return type of find_partial_die.
9796
9797 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9798
9799 PR breakpoints/24541
9800 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9801 "std::string", simplifying the algorithm.
9802
9803 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9804
9805 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9806 (stap_static_probe_ops::get_probes): Likewise.
9807
9808 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9809
9810 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9811 '-')" and "else if".
9812 (stap_parse_single_operand): Join checks for
9813 "gdbarch_stap_parse_special_token_p" and
9814 "gdbarch_stap_parse_special_token" in the same "if" statement.
9815 Invert check when verifying for operation on register
9816 displacement.
9817
9818 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9819
9820 * stap-probe.c (stap_get_opcode): Update comment.
9821 (stap_get_expected_argument_type): Likewise.
9822 (handle_stap_probe): Likewise.
9823
9824 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9825
9826 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9827 return type to 'bool'. Adjust comment. Use 'bool' when
9828 appropriate.
9829 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9830 * stap-probe.c (stap_parse_argument_1): Likewise.
9831 (stap_is_operator): Likewise.
9832 (stap_is_generic_prefix): Likewise.
9833 (stap_is_register_prefix): Likewise.
9834 (stap_is_register_indirection_prefix): Likewise.
9835 (stap_is_integer_prefix): Likewise.
9836 (stap_generic_check_suffix): Likewise.
9837 (stap_check_integer_suffix): Likewise.
9838 (stap_check_register_suffix): Likewise.
9839 (stap_check_register_indirection_suffix): Likewise.
9840 (stap_parse_register_operand): Likewise.
9841 (stap_parse_single_operand): Likewise.
9842 (stap_parse_argument_1): Likewise.
9843 (stap_probe::get_argument_count): Likewise.
9844 (stap_is_operator): Likewise.
9845
9846 2019-05-16 Tom Tromey <tromey@adacore.com>
9847
9848 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9849 keyword to foreach.
9850
9851 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
9852
9853 * linux-thread-db.c (try_thread_db_load_1): Change return type
9854 to bool.
9855 (try_thread_db_load): Likewise.
9856 (try_thread_db_load_from_pdir_1): Likewise.
9857 (try_thread_db_load_from_pdir): Likewise.
9858 (try_thread_db_load_from_sdir): Likewise.
9859 (try_thread_db_load_from_dir): Likewise.
9860 (thread_db_load_search): Likewise.
9861 (has_libpthread): Likewise.
9862 (thread_db_load): Likewise.
9863
9864 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9865
9866 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9867 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9868 NULL, and complain/return if that's the case.
9869
9870 2019-05-15 John Darrington <john@darrington.wattle.id.au>
9871
9872 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9873 (advance, posn, abstract_read_memory): New functions.
9874 [struct mem_read_abstraction]: New struct.
9875 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9876
9877 2019-05-14 Tom Tromey <tromey@adacore.com>
9878
9879 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9880 value is not lval_memory.
9881
9882 2019-05-14 Tom Tromey <tromey@adacore.com>
9883
9884 * solib.c (info_sharedlibrary_command): Style the file name.
9885
9886 2019-05-14 Alan Hayward <alan.hayward@arm.com>
9887
9888 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9889 (aarch64_vnv_type): Likewise.
9890 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9891 * common/tdesc.c: Likewise.
9892 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9893 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9894 * features/aarch64-fpu.xml: Add ieee half view.
9895 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9896 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9897 * gdbtypes.h (struct builtin_type): Likewise.
9898 (struct objfile_type): Likewise.
9899
9900 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
9901
9902 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9903 typo.
9904 * location.h (string_to_event_location): Likewise.
9905
9906 2019-05-11 Joel Brobecker <brobecker@adacore.com>
9907
9908 GDB 8.3 released.
9909
9910 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9911
9912 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9913 New variable declaration.
9914 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9915 New variable.
9916 (print_one_breakpoint): Use ui_out::test_flags and new global
9917 variable to compute use_fixed_output.
9918 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9919 Remove.
9920 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9921 (mi_multi_location_breakpoint_output_fixed): Remove.
9922 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9923 new variable.
9924 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9925 fix_multi_location_breakpoint_output flag if version >= 3.
9926 * ui-out.h (enum ui_out_flag)
9927 <fix_multi_location_breakpoint_output>: New enumerator.
9928
9929 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9930
9931 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9932
9933 2019-05-10 Tom Tromey <tromey@adacore.com>
9934
9935 * ada-lang.c (catch_ada_completer): New function.
9936 (_initialize_ada_language): Use it.
9937
9938 2019-05-10 Tom Tromey <tromey@adacore.com>
9939
9940 * thread.c (print_thread_info): Make "requested_threads" const.
9941 * gdbthread.h (print_thread_info): Make "requested_threads"
9942 const.
9943 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9944 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9945
9946 2019-05-08 Tom Tromey <tom@tromey.com>
9947
9948 * gdbtypes.c (objfile_type_data): Change type.
9949 (objfile_type, _initialize_gdbtypes): Update.
9950
9951 2019-05-08 Tom Tromey <tom@tromey.com>
9952
9953 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9954 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9955 (_initialize_dwarf2_frame): Update.
9956
9957 2019-05-08 Tom Tromey <tom@tromey.com>
9958
9959 * objc-lang.c (objc_objfile_data): Change type.
9960 (find_methods): Update.
9961 (_initialize_objc_lang): Remove.
9962
9963 2019-05-08 Tom Tromey <tom@tromey.com>
9964
9965 * stabsread.c (rs6000_builtin_type_data): Change type.
9966 (rs6000_builtin_type, _initialize_stabsread): Update.
9967
9968 2019-05-08 Tom Tromey <tom@tromey.com>
9969
9970 * mips-tdep.c (mips_pdr_data): Remove.
9971 (_initialize_mips_tdep): Update.
9972
9973 2019-05-08 Tom Tromey <tom@tromey.com>
9974
9975 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9976 (hppa_init_objfile_priv_data, read_unwind_info)
9977 (find_unwind_entry, _initialize_hppa_tdep): Update.
9978
9979 2019-05-08 Tom Tromey <tom@tromey.com>
9980
9981 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9982 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9983 on obstack.
9984 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9985
9986 2019-05-08 Tom Tromey <tom@tromey.com>
9987
9988 * mdebugread.c (basic_type_data): Change type.
9989 (basic_type, _initialize_mdebugread): Update.
9990
9991 2019-05-08 Tom Tromey <tom@tromey.com>
9992
9993 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9994
9995 2019-05-08 Tom Tromey <tom@tromey.com>
9996
9997 * nto-tdep.c (nto_inferior_data_reg): Change type.
9998 (nto_inferior_data): Update.
9999 (nto_inferior_data_cleanup, nto_new_inferior_data)
10000 (_initialize_nto_tdep): Remove.
10001 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10002
10003 2019-05-08 Tom Tromey <tom@tromey.com>
10004
10005 * ada-lang.c (struct ada_inferior_data): Add initializers.
10006 (ada_inferior_data): Change type.
10007 (ada_inferior_data_cleanup): Remove.
10008 (get_ada_inferior_data, ada_inferior_exit)
10009 (struct ada_pspace_data): Add initializers, destructor.
10010 (ada_pspace_data_handle): Change type.
10011 (get_ada_pspace_data): Update.
10012 (ada_pspace_data_cleanup): Remove.
10013
10014 2019-05-08 Tom Tromey <tom@tromey.com>
10015
10016 * coffread.c (struct coff_symfile_info): Add initializers.
10017 (coff_objfile_data_key): Move lower. Change type.
10018 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10019 Update.
10020 (coff_free_info): Remove.
10021
10022 2019-05-08 Tom Tromey <tom@tromey.com>
10023
10024 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10025 (fbsd_pspace_data_handle): Move lower. Change type.
10026 (get_fbsd_pspace_data): Update.
10027 (fbsd_pspace_data_cleanup): Remove.
10028 (_initialize_fbsd_tdep): Update.
10029
10030 2019-05-08 Tom Tromey <tom@tromey.com>
10031
10032 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10033 (get_ada_tasks_pspace_data): Update.
10034 (ada_tasks_pspace_data_cleanup): Remove.
10035 (_initialize_tasks): Update.
10036 (ada_tasks_inferior_data_handle): Change type.
10037 (get_ada_tasks_inferior_data): Update.
10038 (ada_tasks_inferior_data_cleanup): Remove.
10039 (struct ada_tasks_pspace_data): Add initializers.
10040
10041 2019-05-08 Tom Tromey <tom@tromey.com>
10042
10043 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10044 * symfile-debug.c (debug_sym_get_probes): Change type.
10045 * stap-probe.c (handle_stap_probe):
10046 (stap_static_probe_ops::get_probes): Change type.
10047 * probe.h (class static_probe_ops) <get_probes>: Change type.
10048 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10049 (parse_probes_in_pspace): Update.
10050 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10051 Update.
10052 (any_static_probe_ops::get_probes): Change type.
10053 * elfread.c (elfread_data): New typedef.
10054 (probe_key): Change type.
10055 (elf_get_probes): Likewise. Update.
10056 (probe_key_free): Remove.
10057 (_initialize_elfread): Update.
10058 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10059 Change type.
10060 (dtrace_process_dof_probe, dtrace_process_dof)
10061 (dtrace_static_probe_ops::get_probe): Change type.
10062
10063 2019-05-08 Tom Tromey <tom@tromey.com>
10064
10065 * xcoffread.c (struct xcoff_symfile_info): Rename from
10066 coff_symfile_info. Add initializers.
10067 (xcoff_objfile_data_key): Move lower. Change type.
10068 (XCOFF_DATA): Rewrite.
10069 (xcoff_free_info): Remove.
10070 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10071 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10072 (xcoff_initial_scan): Update.
10073
10074 2019-05-08 Tom Tromey <tom@tromey.com>
10075
10076 * solib-svr4.c (struct svr4_info): Add initializers and
10077 destructor.
10078 <probes_table>: Now an htab_up.
10079 (solib_svr4_pspace_data): Change type.
10080 (free_probes_table): Simplify.
10081 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10082 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10083 (probes_table_remove_objfile_probes, register_solib_event_probe)
10084 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10085 (_initialize_svr4_solib): Update.
10086
10087 2019-05-08 Tom Tromey <tom@tromey.com>
10088
10089 * remote.c (remote_pspace_data): Change type.
10090 (remote_pspace_data_cleanup): Remove.
10091 (get_remote_exec_file, set_pspace_remote_exec_file)
10092 (_initialize_remote): Update.
10093
10094 2019-05-08 Tom Tromey <tom@tromey.com>
10095
10096 * breakpoint.c (breakpoint_objfile_key): Change type.
10097 (get_breakpoint_objfile_data): Update.
10098 (free_breakpoint_objfile_data): Remove.
10099 (_initialize_breakpoint): Update.
10100
10101 2019-05-08 Tom Tromey <tom@tromey.com>
10102
10103 * linux-tdep.c (struct linux_info): Add initializers.
10104 (linux_inferior_data): Move. Change type.
10105 (invalidate_linux_cache_inf): Update.
10106 (linux_inferior_data_cleanup): Remove.
10107 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10108
10109 2019-05-08 Tom Tromey <tom@tromey.com>
10110
10111 * auxv.c (auxv_inferior_data): Move. Change type.
10112 (auxv_inferior_data_cleanup): Remove.
10113 (invalidate_auxv_cache_inf): Rewrite.
10114 (get_auxv_inferior_data, _initialize_auxv): Update.
10115
10116 2019-05-08 Tom Tromey <tom@tromey.com>
10117
10118 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10119 (symfile_debug_objfile_data_key): Change type.
10120 (symfile_debug_installed, debug_qf_has_symbols)
10121 (debug_qf_find_last_source_symtab)
10122 (debug_qf_forget_cached_source_info)
10123 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10124 (debug_qf_print_stats, debug_qf_dump)
10125 (debug_qf_expand_symtabs_for_function)
10126 (debug_qf_expand_all_symtabs)
10127 (debug_qf_expand_symtabs_with_fullname)
10128 (debug_qf_map_matching_symbols)
10129 (debug_qf_expand_symtabs_matching)
10130 (debug_qf_find_pc_sect_compunit_symtab)
10131 (debug_qf_map_symbol_filenames)
10132 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10133 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10134 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10135 (debug_sym_read_linetable, debug_sym_relocate): Update.
10136 (symfile_debug_free_objfile): Remove.
10137 (install_symfile_debug_logging, _initialize_symfile_debug):
10138 Update.
10139
10140 2019-05-08 Tom Tromey <tom@tromey.com>
10141
10142 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10143 allocate_on_obstack.
10144 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10145 (get_dwarf2_per_objfile): Update.
10146 (set_dwarf2_per_objfile): Remove.
10147 (dwarf2_has_info, dwarf2_get_section_info): Update.
10148 (dwarf2_free_objfile): Remove.
10149 (_initialize_dwarf2_read): Update.
10150
10151 2019-05-08 Tom Tromey <tom@tromey.com>
10152
10153 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10154 initializers.
10155 <unsupported_script_warning_printed,
10156 script_not_found_warning_printed>: Now bool.
10157 (auto_load_pspace_data): Change type.
10158 (~auto_load_pspace_info): Rename from
10159 auto_load_pspace_data_cleanup.
10160 (get_auto_load_pspace_data, init_loaded_scripts_info)
10161 (clear_section_scripts, maybe_print_unsupported_script_warning)
10162 (maybe_print_script_not_found_warning, _initialize_auto_load):
10163 Update.
10164
10165 2019-05-08 Tom Tromey <tom@tromey.com>
10166
10167 * objfiles.c (objfile_pspace_info): Add destructor and
10168 initializers.
10169 (objfiles_pspace_data): Change type.
10170 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10171 (get_objfile_pspace_data): Update.
10172 (objfiles_bfd_data): Change type.
10173 (get_objfile_bfd_data): Update.
10174 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10175
10176 2019-05-08 Tom Tromey <tom@tromey.com>
10177
10178 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10179 Change type.
10180 (get_catch_syscall_inferior_data): Update.
10181 (catch_syscall_inferior_data_cleanup): Remove.
10182 (_initialize_break_catch_syscall): Update.
10183
10184 2019-05-08 Tom Tromey <tom@tromey.com>
10185
10186 * inflow.c (struct terminal_info): Add destructor and
10187 initializers.
10188 (inflow_inferior_data): Change type.
10189 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10190 (get_inflow_inferior_data, inflow_inferior_exit)
10191 (swap_terminal_info, _initialize_inflow): Update.
10192
10193 2019-05-08 Tom Tromey <tom@tromey.com>
10194
10195 * target-dcache.c (target_dcache_cleanup): Remove.
10196 (target_dcache_aspace_key): Change type.
10197 (target_dcache_init_p, target_dcache_invalidate)
10198 (target_dcache_get, target_dcache_get_or_init)
10199 (_initialize_target_dcache): Update.
10200 * dcache.h (struct dcache_deleter): New.
10201
10202 2019-05-08 Tom Tromey <tom@tromey.com>
10203
10204 * symtab.c (struct symbol_cache): Add destructor and
10205 initializers.
10206 (symbol_cache_key): Move. Change type.
10207 (make_symbol_cache, free_symbol_cache): Remove.
10208 (get_symbol_cache): Update.
10209 (symbol_cache_cleanup): Remove.
10210 (ALL_PSPACES, symbol_cache_flush)
10211 (maintenance_print_symbol_cache)
10212 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10213 Update.
10214
10215 2019-05-08 Tom Tromey <tom@tromey.com>
10216
10217 * symtab.c (struct main_info): Add destructor and initializers.
10218 (main_progspace_key): Move. Change type.
10219 (get_main_info): Update.
10220 (main_info_cleanup): Remove.
10221 (_initialize_symtab): Update.
10222
10223 2019-05-08 Tom Tromey <tom@tromey.com>
10224
10225 * registry.h (DECLARE_REGISTRY): Define the _key class.
10226
10227 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10228
10229 * NEWS: Merge two 'New commands' sections.
10230
10231 2019-05-08 Joel Brobecker <brobecker@adacore.com>
10232
10233 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10234 parameter and use Ada language definition instead.
10235 (ada_val_print_ptr): Remove unused language parameter.
10236 (ada_val_print_num): Remove language parameter and use Ada language
10237 definition instead.
10238 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10239 parameter.
10240 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10241 parameter and use Ada language definition instead.
10242 (ada_val_print_1): Update all ada_val_print_xxx calls.
10243 Remove language parameter.
10244 (ada_val_print): Update ada_val_print_1 call.
10245
10246 2019-05-08 Tom Tromey <tromey@adacore.com>
10247
10248 * remote.c (remote_hw_watchpoint_limit)
10249 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10250 Now static.
10251
10252 2019-05-08 Tom Tromey <tromey@adacore.com>
10253
10254 * maint.c (_initialize_maint_cmds): Move initialization code to
10255 remote.c.
10256 (watchdog, show_watchdog): Move to remote.c.
10257 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10258 "watchdog" static.
10259 (_initialize_remote): Move initialization code from maint.c.
10260 * defs.h (watchdog): Don't declare.
10261
10262 2019-05-08 Tom Tromey <tromey@adacore.com>
10263
10264 * tui/tui-interp.c: Include main.h.
10265 * interps.c: Include main.h.
10266 * main.h (interpreter_p): Declare.
10267 * defs.h (interpreter_p): Don't declare.
10268
10269 2019-05-08 Tom Tromey <tromey@adacore.com>
10270
10271 * dwarf2loc.c: Include dwarf2read.h.
10272 * defs.h (read_unsigned_leb128): Don't declare.
10273 * dwarf2read.h (read_unsigned_leb128): Declare.
10274
10275 2019-05-08 Tom Tromey <tromey@adacore.com>
10276
10277 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10278 method.
10279
10280 2019-05-08 Tom Tromey <tromey@adacore.com>
10281
10282 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10283 when no wrap column is set.
10284
10285 2019-05-08 Tom Tromey <tromey@adacore.com>
10286
10287 * c-lang.c (c_get_string): Handle non-C-style arrays.
10288
10289 2019-05-08 Tom Tromey <tromey@adacore.com>
10290
10291 * typeprint.c (print_offset_data::update): Print the bit offset,
10292 not the number of bits remaining.
10293
10294 2019-05-08 Tom Tromey <tromey@adacore.com>
10295
10296 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10297 padding at end of comment.
10298
10299 2019-05-08 Tom Tromey <tromey@adacore.com>
10300
10301 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10302 Compare main types.
10303
10304 2019-05-06 Tom Tromey <tom@tromey.com>
10305
10306 * common/scoped_mmap.c: Include common-defs.h.
10307 * common/scoped_mmap.h: Don't include config.h.
10308
10309 2019-05-04 Tom Tromey <tom@tromey.com>
10310
10311 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10312 (struct aarch64_call_info): Add initializers.
10313 <si>: Now a std::vector.
10314 (pass_on_stack, aarch64_push_dummy_call): Update.
10315
10316 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
10317 Tom Tromey <tom@tromey.com>
10318
10319 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10320 (ppc_threads): Now a std::vector. Now static.
10321 (hwdebug_find_thread_points_by_tid)
10322 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10323 Update.
10324
10325 2019-05-04 Tom Tromey <tom@tromey.com>
10326
10327 * arc-tdep.c (arc_tdesc_init): Return bool.
10328
10329 2019-05-04 Tom Tromey <tom@tromey.com>
10330
10331 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10332 Use gdb_assert_not_reached.
10333
10334 2019-05-04 Tom Tromey <tom@tromey.com>
10335
10336 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10337 "false".
10338
10339 2019-05-04 Tom Tromey <tom@tromey.com>
10340
10341 * arc-tdep.c (arc_tdesc_init): Use bool.
10342
10343 2019-05-04 Tom Tromey <tom@tromey.com>
10344
10345 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10346
10347 2019-05-04 Tom Tromey <tom@tromey.com>
10348
10349 * cli/cli-cmds.c (valid_command_p): Return bool.
10350
10351 2019-05-04 Tom Tromey <tom@tromey.com>
10352
10353 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10354 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10355
10356 2019-05-04 Raul Tambre <raul@tambre.ee>
10357
10358 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10359 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10360 operator for comparison.
10361
10362 2019-05-04 Tom Tromey <tom@tromey.com>
10363
10364 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10365 (lookup_partial_symbol, print_partial_symbols)
10366 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10367 (psymbol_compare): Update.
10368 (add_psymbol_to_bcache): Clear the entire psymbol.
10369 (maintenance_check_psymtabs): Update.
10370 * psympriv.h (struct partial_symbol): Don't derive from
10371 general_symbol_info.
10372 <obj_section, unrelocated_address, address,
10373 set_unrelocated_address>: Update.
10374 <ginfo>: New member.
10375 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10376 (debug_names::write_psymbols): Update.
10377
10378 2019-05-04 Tom de Vries <tdevries@suse.de>
10379
10380 * contrib/cc-with-tweaks.sh: Support -n arg.
10381
10382 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10383
10384 * corelow.c (core_target::detach): Ensure frame cache and
10385 register caches are cleared.
10386 inferior.c (exit_inferior_1): Likewise.
10387
10388 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10389 Tom Tromey <tom@tromey.com>
10390
10391 * dictionary.c (collate_pending_symbols_by_language): Remove
10392 "struct" from foreach.
10393 * symtab.c (lookup_global_symbol_from_objfile)
10394 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10395 foreach.
10396 * ser-tcp.c (net_open): Remove "struct" from foreach.
10397 * objfiles.c (objfile_relocate, objfile_rebase)
10398 (objfile_has_symbols): Remove "struct" from foreach.
10399 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10400 from foreach.
10401 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10402 foreach.
10403 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10404 "struct" from foreach.
10405 * ada-lang.c (create_excep_cond_exprs)
10406 (ada_exception_catchpoint_cond_string): Remove "struct" from
10407 foreach.
10408
10409 2019-05-03 Tom Tromey <tromey@adacore.com>
10410
10411 * ada-exp.y (convert_char_literal): Check suffix of each
10412 enumerator.
10413
10414 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10415
10416 PR ada/21406:
10417 * ada-exp.y (yywrap): Don't define.
10418 * ada-lex.l (%option): Add noyywrap
10419 (yywrap): Remove.
10420
10421 2019-05-03 Eli Zaretskii <eliz@gnu.org>
10422
10423 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10424 _WIN32_WINNT to the XP level, unless already defined to a higher
10425 level.
10426
10427 * unittests/parse-connection-spec-selftests.c:
10428 * ser-tcp.c:
10429 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10430 override.
10431
10432 * symfile.c (find_separate_debug_file): Remove colon from the
10433 drive spec of DOS/Windows file names of the target, so that the
10434 file name produced from DEBUGDIR and the target's directory will
10435 be valid on DOS/Windows systems.
10436
10437 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10438
10439 * rust-lang.c (val_print_struct): Handle printing structures
10440 containing strings.
10441
10442 2019-05-02 Tom Tromey <tromey@adacore.com>
10443
10444 * valarith.c (_initialize_valarith): Remove.
10445
10446 2019-05-01 Tom Tromey <tromey@adacore.com>
10447
10448 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10449 bitfields.
10450
10451 2019-05-01 Tom Tromey <tromey@adacore.com>
10452
10453 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10454 for big-endian copies.
10455
10456 2019-04-30 Ali Tamur <tamur@google.com>
10457 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10458 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10459 (read_3_bytes): New function.
10460
10461 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10462
10463 * windows-nat.c (main_thread_id): Delete.
10464 (handle_output_debug_string): Replace main_thread_id by
10465 current_event.dwThreadId.
10466 (fake_create_process): Likewise.
10467 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10468 Do not set main_thread_id.
10469 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10470 current_event.dwThreadId.
10471 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10472
10473 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10474
10475 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10476 Use current_event.dwThreadId instead of main_thread_id.
10477
10478 2019-04-30 Tom Tromey <tromey@adacore.com>
10479
10480 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10481 (create_excep_cond_exprs): Iterate over program spaces.
10482 (ada_exception_catchpoint_cond_string): Examine all minimal
10483 symbols for exception types.
10484
10485 2019-04-30 Tom Tromey <tromey@adacore.com>
10486
10487 PR c++/24470:
10488 * dwarf2read.c (process_structure_scope): Handle case where type
10489 has template parameters but no symbol was created.
10490
10491 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10492 Chris January <chris.january@arm.com>
10493
10494 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10495 qualifier.
10496 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10497
10498 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10499
10500 * f-typeprint.c (f_print_type): Update rules for printing
10501 whitespace.
10502 (f_type_print_varspec_suffix): Likewise.
10503
10504 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10505 Chris January <chris.january@arm.com>
10506
10507 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10508 function arguments.
10509
10510 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10511
10512 * f-lang.c (build_fortran_types): Change name of void type to
10513 lower case.
10514 * f-typeprint.c (f_type_print_base): Print the name of the void
10515 type, rather than a fixed string.
10516 * f-valprint.c (f_decorations): Use lower case void string.
10517
10518 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10519 Chris January <chris.january@arm.com>
10520
10521 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10522 types for Fortran.
10523
10524 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10525 Chris January <chris.january@arm.com>
10526 David Lecomber <david.lecomber@arm.com>
10527
10528 * f-exp.y (BINOP_INTRINSIC): New token.
10529 (exp): New parser rule handling BINOP_INTRINSIC.
10530 (f77_keywords): Add new builtin procedures.
10531 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10532 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10533 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10534 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10535 (print_unop_subexp_f): New function.
10536 (print_binop_subexp_f): New function.
10537 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10538 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10539 (dump_subexp_body_f): Likewise.
10540 (operator_check_f): Likewise.
10541 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10542 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10543
10544 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10545
10546 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10547 UNOP_KIND.
10548 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10549 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10550 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10551 (operator_length_f): New fuction.
10552 (print_subexp_f): New function.
10553 (op_name_f): New function.
10554 (dump_subexp_body_f): New function.
10555 (operator_check_f): New function.
10556 (exp_descriptor_f): Replace standard expression handling functions
10557 with new functions.
10558 * gdb/fortran-operator.def: New file.
10559 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10560 * gdb/std-operator.def: Remove UNOP_KIND.
10561
10562 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10563
10564 * std-operator.def: Remove unbalanced, stray double quote
10565 character.
10566
10567 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10568 Chris January <chris.january@arm.com>
10569 Daniel Everett <daniel.everett@arm.com>
10570 Nick Forrington <nick.forrington@arm.com>
10571 Richard Bunt <richard.bunt@arm.com>
10572
10573 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10574 of depth when printing anonymous structs or unions.
10575 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10576 Don't print either the top-level value, or the children if the
10577 max-depth is exceeded.
10578 (ppscm_print_children): When printing the key of a map, allow one
10579 extra level of depth.
10580 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10581 print either the top-level value, or the children if the max-depth
10582 is exceeded.
10583 (print_children): When printing the key of a map, allow one extra
10584 level of depth.
10585 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10586 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10587 (user_print_options): Initialise max_depth field.
10588 (val_print_scalar_or_string_type_p): New function.
10589 (val_print): Check to see if the max depth has been reached.
10590 (val_print_check_max_depth): Define new function.
10591 (show_print_max_depth): New function.
10592 (_initialize_valprint): Add 'print max-depth' option.
10593 * valprint.h (struct value_print_options) <max_depth>: New field.
10594 (val_print_check_max_depth): Declare new function.
10595 * NEWS: Document new feature.
10596
10597 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10598
10599 * ada-lang.c (ada_language_defn): Initialise new field.
10600 * c-lang.c (c_is_string_type_p): New function.
10601 (c_language_defn): Initialise new field.
10602 (cplus_language_defn): Initialise new field.
10603 (asm_language_defn): Initialise new field.
10604 (minimal_language_defn): Initialise new field.
10605 * c-lang.h (c_is_string_type_p): Declare new function.
10606 * d-lang.c (d_language_defn): Initialise new field.
10607 * f-lang.c (f_is_string_type_p): New function.
10608 (f_language_defn): Initialise new field.
10609 * go-lang.c (go_is_string_type_p): New function.
10610 (go_language_defn): Initialise new field.
10611 * language.c (default_is_string_type_p): New function.
10612 (unknown_language_defn): Initialise new field.
10613 (auto_language_defn): Initialise new field.
10614 * language.h (struct language_defn) <la_is_string_type_p>: New
10615 member variable.
10616 (default_is_string_type_p): Declare new function.
10617 * m2-lang.c (m2_language_defn): Initialise new field.
10618 * objc-lang.c (objc_language_defn): Initialise new field.
10619 * opencl-lang.c (opencl_language_defn): Initialise new field.
10620 * p-lang.c (pascal_is_string_type_p): New function.
10621 (pascal_language_defn): Initialise new field.
10622 * rust-lang.c (rust_is_string_type_p): New function.
10623 (rust_language_defn): Initialise new field.
10624
10625 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10626
10627 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10628 New field.
10629 * ada-lang.c (ada_language_defn): Initialise new field.
10630 * c-lang.c (c_language_defn): Likewise.
10631 (cplus_language_defn): Likewise.
10632 (asm_language_defn): Likewise.
10633 (minimal_language_defn): Likewise.
10634 * d-lang.c (d_language_defn): Likewise.
10635 * f-lang.c (f_language_defn): Likewise.
10636 * go-lang.c (go_language_defn): Likewise.
10637 * language.c (unknown_language_defn): Likewise.
10638 (auto_language_defn): Likewise.
10639 * m2-lang.c (m2_language_defn): Likewise.
10640 * objc-lang.c (objc_language_defn): Likewise.
10641 * opencl-lang.c (opencl_language_defn): Likewise.
10642 * p-lang.c (pascal_language_defn): Likewise.
10643 * rust-lang.c (rust_language_defn): Likewise.
10644
10645 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10646
10647 * ada-lang.c (ada_is_character_type): Change return type to bool.
10648 (ada_is_string_type): Likewise.
10649 * ada-lang.h (ada_is_character_type): Update declaration
10650 (ada_is_string_type): Likewise.
10651
10652 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10653
10654 Support style in 'frame|thread apply'
10655
10656 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10657 * record.c (record_start, record_stop): Update callers of
10658 execute_command_to_string with false.
10659 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10660 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10661 methods.
10662 (class string_file): New constructor with term_out parameter.
10663 Override methods term_out and can_emit_style_escape. New member
10664 term_out.
10665 (class stdio_file): Override can_emit_style_escape.
10666 (class tee_file): Override term_out and can_emit_style_escape.
10667 * utils.h (can_emit_style_escape): Remove.
10668 * utils.c (can_emit_style_escape): Likewise.
10669 Update all callers of can_emit_style_escape (SOMESTREAM) to
10670 SOMESTREAM->can_emit_style_escape.
10671 * source-cache.c (source_cache::get_source_lines): Likewise.
10672 * stack.c (frame_apply_command_count): Call execute_command_to_string
10673 passing the term_out characteristic of the current gdb_stdout.
10674 * thread.c (thr_try_catch_cmd): Likewise.
10675 * top.c (execute_command_to_string): pass term_out parameter
10676 to construct the string_file for the command output.
10677 * ui-file.c (term_cli_styling): New function (most code moved
10678 from utils.c can_emit_style_escape).
10679 (string_file::string_file, string_file::can_emit_style_escape,
10680 stdio_file::can_emit_style_escape, tee_file::term_out,
10681 tee_file::can_emit_style_escape): New functions.
10682
10683 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10684
10685 * NEWS: Mention the new set|show may-call-functions.
10686 * infcall.c (may_call_functions_p): New variable.
10687 (show_may_call_functions_p): New function.
10688 (call_function_by_hand_dummy): Throws an error if not
10689 may-call-functions.
10690 (_initialize_infcall): Call add_setshow_boolean_cmd for
10691 may-call-functions.
10692
10693 2019-04-25 Keith Seitz <keiths@redhat.com>
10694
10695 PR c++/24367
10696 * cp-support.c (inspect_type): Don't attempt substitutions
10697 of symbol with the same name.
10698
10699 2019-04-25 Tom Tromey <tromey@adacore.com>
10700
10701 PR gdb/24475:
10702 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10703 static.
10704
10705 2019-04-25 Tom Tromey <tromey@adacore.com>
10706
10707 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10708 rvalue reference.
10709 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10710 (gdb_xml_parser::parse): Use std::move.
10711 * python/python-internal.h (gdbpy_convert_exception): Take a const
10712 reference.
10713 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10714 std::move.
10715 * python/py-utils.c (gdbpy_convert_exception): Take a const
10716 reference.
10717 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10718 Use std::move.
10719 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10720 Use std::move.
10721 * mi/mi-main.c (mi_print_exception): Take a const reference.
10722 * main.c (handle_command_errors): Take a const reference.
10723 * linespec.c (parse_linespec): Use std::move.
10724 * infcall.c (run_inferior_call): Use std::move.
10725 (call_function_by_hand_dummy): Use std::move.
10726 * exec.c (try_open_exec_file): Use std::move.
10727 * exceptions.h (exception_print, exception_fprintf)
10728 (exception_print_same): Update.
10729 * exceptions.c (print_exception, exception_print)
10730 (exception_fprintf, exception_print_same): Change parameters to
10731 const reference.
10732 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10733 * common/new-op.c: Use std::move.
10734 * common/common-exceptions.h (struct gdb_exception): Add move
10735 constructor.
10736 (struct gdb_exception_error, struct gdb_exception_quit, struct
10737 gdb_quit_bad_alloc): Change constructor to move constructor.
10738 (throw_exception): Change parameter to rvalue reference.
10739 * common/common-exceptions.c (throw_exception): Take rvalue
10740 reference.
10741 * cli/cli-interp.c (safe_execute_command): Use std::move.
10742 * breakpoint.c (insert_bp_location, location_to_sals): Use
10743 std::move.
10744
10745 2019-04-25 Tom Tromey <tromey@adacore.com>
10746
10747 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10748 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10749 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10750 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10751 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10752 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10753 guile/scm-value.c: Use unpack.
10754 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10755 gdbscm_gdb_exception.
10756 (gdbscm_throw_gdb_exception): Likewise.
10757 (struct gdbscm_gdb_exception): New.
10758 (unpack): New function.
10759 (gdbscm_wrap): Use unpack.
10760
10761 2019-04-25 Tom Tromey <tromey@adacore.com>
10762
10763 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10764 (gdb_rl_callback_handler): Use std::move.
10765 * common/common-exceptions.h (struct gdb_exception): Add move
10766 assignment operator.
10767 (throw_exception_sjlj): Change "exception" to const reference.
10768 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10769 (throw_exception_sjlj): Change "exception" to const reference.
10770
10771 2019-04-25 Tom Tromey <tromey@adacore.com>
10772
10773 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10774 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10775 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10776 Update.
10777 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10778 Update.
10779 * mi/mi-interp.c (mi_interp::exec): Update.
10780 * linespec.c (parse_linespec): Update.
10781 * infcall.c (run_inferior_call): Update.
10782 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10783 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10784 (gdbscm_lookup_global_symbol): Update.
10785 * guile/scm-param.c (gdbscm_parameter_value): Update.
10786 * guile/scm-frame.c (gdbscm_frame_read_register)
10787 (gdbscm_frame_read_var): Update.
10788 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10789 * exec.c (try_open_exec_file): Update.
10790 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10791 (gdb_rl_callback_handler): Update.
10792 * common/common-exceptions.h (exception_none): Don't declare.
10793 * common/common-exceptions.c (exception_none): Don't define.
10794 (struct catcher) <exception>: Update.
10795 * cli/cli-interp.c (safe_execute_command): Update.
10796 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10797
10798 2019-04-25 Ali Tamur <tamur@google.com>
10799
10800 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10801 (read_attribute_value): Likewise.
10802 (dwarf2_read_addr_index): Update comment.
10803 (read_str_index): Add DW_FORM_strx.
10804 (dwarf2_string_attr): Likewise.
10805 (dwarf2_const_value_attr): Likewise.
10806 (dump_die_shallow): Likewise.
10807 (dwarf2_fetch_constant_bytes): Likewise.
10808 (skip_form_bytes): Likewise.
10809 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10810
10811 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10812
10813 PR corefiles/11608
10814 PR corefiles/18187
10815 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10816 OFFSET. Verify if current mapping contains an ELF header.
10817 (linux_find_memory_regions_full): Adjust call to
10818 dump_mapping_p.
10819
10820 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10821 Kang Li <kanglictf@gmail.com>
10822
10823 PR gdb/21600
10824
10825 * dwarf2-frame.c (read_initial_length): Be consistent about using
10826 unsigned representation of length.
10827 (decode_frame_entry_1): Likewise. Check for wraparound of
10828 end pointer as well as buffer overflow.
10829
10830 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10831
10832 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10833 "vq".
10834
10835 2019-04-24 Tom Tromey <tromey@adacore.com>
10836
10837 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10838
10839 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10840
10841 * s12z-tdep.c (s12z_unwind_pc): Delete.
10842 (s12z_unwind_sp): Delete.
10843 (s12z_gdbarch_init): Don't register deleted functions with
10844 gdbarch.
10845
10846 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10847
10848 * rl78-tdep.c (rl78_unwind_sp): Delete.
10849 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10850
10851 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10852
10853 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10854 (xstormy16_unwind_pc): Delete.
10855 (xstormy16_dummy_id): Delete.
10856 (xstormy16_gdbarch_init): Don't register deleted functions with
10857 gdbarch.
10858
10859 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10860
10861 * vax-tdep.c (vax_unwind_pc): Delete.
10862 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10863
10864 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10865
10866 * v850-tdep.c (v850_unwind_sp): Delete.
10867 (v850_unwind_pc): Delete.
10868 (v850_dummy_id): Delete.
10869 (v850_gdbarch_init): Don't register deleted functions with
10870 gdbarch.
10871
10872 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10873
10874 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10875 (tilegx_unwind_pc): Delete.
10876 (tilegx_unwind_dummy_id): Delete.
10877 (tilegx_gdbarch_init): Don't register deleted functions with
10878 gdbarch.
10879
10880 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10881
10882 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10883 (tic6x_dummy_id): Delete.
10884 (tic6x_gdbarch_init): Don't register deleted functions with
10885 gdbarch.
10886
10887 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10888
10889 * sparc-tdep.c (sparc_unwind_pc): Delete.
10890 (sparc32_gdbarch_init): Don't register deleted function with
10891 gdbarch.
10892
10893 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10894
10895 * sh-tdep.c (sh_unwind_sp): Delete.
10896 (sh_unwind_pc): Delete.
10897 (sh_dummy_id): Delete.
10898 (sh_gdbarch_init): Don't register deleted functions with
10899 gdbarch.
10900
10901 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10902
10903 * score-tdep.c (score_unwind_sp): Delete.
10904 (score_unwind_pc): Delete.
10905 (score_dummy_id): Delete.
10906 (score_gdbarch_init): Don't register deleted functions with
10907 gdbarch.
10908
10909 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10910
10911 * rx-tdep.c (rx_unwind_pc): Delete.
10912 (rx_unwind_sp): Delete.
10913 (rx_dummy_id): Delete.
10914 (rx_gdbarch_init): Don't register deleted functions with
10915 gdbarch. Update comment.
10916
10917 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10918
10919 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10920 (rs6000_dummy_id): Delete.
10921 (rs6000_gdbarch_init): Don't register deleted functions with
10922 gdbarch.
10923
10924 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10925
10926 * or1k-tdep.c (or1k_dummy_id): Delete.
10927 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10928
10929 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10930
10931 * nios2-tdep.c (nios2_dummy_id): Delete.
10932 (nios2_unwind_sp): Delete.
10933 (nios2_gdbarch_init): Don't register deleted functions with
10934 gdbarch.
10935
10936 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10937
10938 * nds32-tdep.c (nds32_dummy_id): Delete.
10939 (nds32_unwind_pc): Delete.
10940 (nds32_unwind_sp): Delete.
10941 (nds32_gdbarch_init): Don't register deleted functions with
10942 gdbarch.
10943
10944 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10945
10946 * msp430-tdep.c (msp430_unwind_pc): Delete.
10947 (msp430_unwind_sp): Delete.
10948 (msp430_dummy_id): Delete.
10949 (msp430_gdbarch_init): Don't register deleted functions with
10950 gdbarch.
10951
10952 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10953
10954 * moxie-tdep.c (moxie_unwind_sp): Delete.
10955 (moxie_unwind_pc): Delete.
10956 (moxie_dummy_id): Delete.
10957 (moxie_gdbarch_init): Don't register deleted functions with
10958 gdbarch.
10959
10960 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10961
10962 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10963 (mn10300_unwind_pc): Delete.
10964 (mn10300_unwind_sp): Delete.
10965 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10966 mn10300_unwind_sp.
10967 (mn10300_frame_unwind_init): Don't register deleted functions with
10968 gdbarch.
10969
10970 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10971
10972 * mep-tdep.c (mep_unwind_pc): Delete.
10973 (mep_unwind_sp): Delete.
10974 (mep_dummy_id): Delete.
10975 (mep_gdbarch_init): Don't register deleted functions with
10976 gdbarch.
10977
10978 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10979
10980 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10981 (m68hc11_unwind_sp): Delete.
10982 (m68hc11_gdbarch_init): Don't register deleted functions with
10983 gdbarch.
10984
10985 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10986
10987 * m32r-tdep.c (m32r_unwind_sp): Delete.
10988 (m32r_unwind_pc): Delete.
10989 (m32r_dummy_id): Delete.
10990 (m32r_gdbarch_init): Don't register deleted functions with
10991 gdbarch.
10992
10993 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10994
10995 * m32c-tdep.c (m32c_unwind_pc): Delete.
10996 (m32c_unwind_sp): Delete.
10997 (m32c_dummy_id): Delete.
10998 (m32c_gdbarch_init): Don't register deleted functions with
10999 gdbarch.
11000
11001 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11002
11003 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11004 (lm32_unwind_pc): Delete.
11005 (lm32_dummy_id): Delete.
11006 (lm32_gdbarch_init): Don't register deleted functions with
11007 gdbarch.
11008
11009 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11010
11011 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11012 (iq2000_unwind_pc): Delete.
11013 (iq2000_dummy_id): Delete.
11014 (iq2000_gdbarch_init): Don't register deleted functions with
11015 gdbarch.
11016
11017 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11018
11019 * nds32-tdep.c (nds32_type_align): Delete.
11020 (nds32_push_dummy_call): Use type_align instead.
11021
11022 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11023
11024 * arm-tdep.c (arm_type_align): Only handle vector override case.
11025 (arm_push_dummy_call): Use type_align.
11026 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11027
11028 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11029
11030 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11031 case.
11032 (pass_on_stack): Use type_align.
11033 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11034 function.
11035
11036 2019-04-23 Tom Tromey <tromey@adacore.com>
11037
11038 * dwarf2read.c (line_header::file_name_at): Remove unused
11039 overload.
11040
11041 2019-04-23 Tom de Vries <tdevries@suse.de>
11042
11043 PR gdb/24438
11044 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11045 invocation.
11046
11047
11048 2019-03-27 Ali Tamur <tamur@google.com>
11049
11050 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11051 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11052 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11053 (dwarf_expr_context::get_addr_index): Likewise
11054 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11055 (symbol_needs_eval_context::get_addr_index): Likewise
11056 (disassemble_dwarf_expression): Add DW_OP_addrx
11057 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11058 (read_cutu_die_from_dwo): Update comment
11059 (skip_one_die): Add DW_FORM_addrx
11060 (read_attribute_value): Likewise
11061 (var_decode_location): Add DW_OP_addrx
11062 (dwarf2_const_value_attr): Add DW_FORM_addrx
11063 (dump_die_shallow): Likewise
11064 (dwarf2_fetch_constant_bytes): Likewise
11065 (decode_locdesc): Add DW_OP_addrx
11066 (skip_form_bytes): Add DW_FORM_addrx
11067
11068 2019-04-22 Ali Tamur <tamur@google.com>
11069
11070 * MAINTAINERS (Write After Approval): Add self.
11071
11072 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
11073
11074 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11075 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11076 (open_symbol_file_object): Likewise.
11077 (svr4_default_sos): Add info parameter.
11078 (svr4_read_so_list): Likewise.
11079 (svr4_current_sos_direct): Adjust functions calls to pass down
11080 info.
11081 (svr4_current_sos_1): Add info parameter.
11082 (svr4_current_sos): Call get_svr4_info, pass info down to
11083 svr4_current_sos_1.
11084 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11085 get_svr4_info.
11086 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11087 get_svr4_info.
11088 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11089 to get_svr4_info.
11090 (probes_table_remove_objfile_probes): Likewise.
11091 (register_solib_event_probe): Add info parameter.
11092 (solist_update_incremental): Pass info parameter down to
11093 svr4_read_so_list.
11094 (disable_probes_interface): Add info parameter.
11095 (svr4_handle_solib_event): Pass current_program_space to
11096 get_svr4_info. Adjust disable_probes_interface cleanup.
11097 (svr4_create_probe_breakpoints): Add info parameter, pass it
11098 down to register_solib_event_probe.
11099 (svr4_create_solib_event_breakpoints): Add info parameter,
11100 pass it down to svr4_create_probe_breakpoints.
11101 (enable_break): Pass info down to
11102 svr4_create_solib_event_breakpoints.
11103 (svr4_solib_create_inferior_hook): Pass current_program_space to
11104 get_svr4_info.
11105 (svr4_clear_solib): Likewise.
11106
11107 2019-04-22 Pedro Alves <palves@redhat.com>
11108
11109 * solib-svr4.c (svr4_free_objfile_observer): New.
11110 (probe_and_action::objfile): New field.
11111 (probes_table_htab_remove_objfile_probes)
11112 (probes_table_remove_objfile_probes): New functions.
11113 (register_solib_event_probe): Add 'objfile' parameter. Store it
11114 in the new probe_and_action. Don't store the probe in 'lookup'.
11115 (svr4_create_probe_breakpoints): Pass objfile to
11116 register_solib_event_probe.
11117 (_initialize_svr4_solib): Register a free_objfile observer.
11118
11119 2019-04-19 Tom Tromey <tom@tromey.com>
11120
11121 * common/queue.h: Remove.
11122
11123 2019-04-19 Tom Tromey <tom@tromey.com>
11124
11125 * event-loop.c: Don't include "common/queue.h".
11126
11127 2019-04-19 Tom Tromey <tom@tromey.com>
11128
11129 * remote.c (remote_target): Use delete.
11130 * remote-notif.h: Include <list>, not "common/queue.h".
11131 (notif_client_p): Remove typedef.
11132 (remote_notif_state): Add constructor, destructor, initializer.
11133 <notif_queue>: Now a std::list.
11134 (remote_notif_state_xfree): Don't declare.
11135 * remote-notif.c (remote_notif_process, handle_notification)
11136 (remote_notif_state_allocate): Update.
11137 (~remote_notif_state): Rename from remote_notif_state_xfree.
11138
11139 2019-04-19 Tom Tromey <tom@tromey.com>
11140
11141 * symfile.c (reread_symbols): Update.
11142 * objfiles.c (objfile_register_static_link)
11143 (objfile_lookup_static_link): Update
11144 (~objfile) Don't delete static_links.
11145 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11146
11147 2019-04-19 Tom Tromey <tom@tromey.com>
11148
11149 * type-stack.h (struct type_stack) <insert>: Constify string.
11150 * type-stack.c (type_stack::insert): Constify string.
11151 * gdbtypes.h (lookup_template_type): Update.
11152 (address_space_name_to_int): Update.
11153 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11154 const.
11155 (lookup_template_type): Make name const.
11156 * c-exp.y: Update rules.
11157 (lex_one_token, classify_name, classify_inner_name)
11158 (c_print_token): Update.
11159 * p-exp.y: Update rules.
11160 (yylex): Update.
11161 * f-exp.y: Update rules.
11162 (yylex): Update.
11163 * d-exp.y: Update rules.
11164 (lex_one_token, classify_name, classify_inner_name): Update.
11165 * parse.c (write_dollar_variable, copy_name): Return std::string.
11166 * parser-defs.h (copy_name): Change return type.
11167 * m2-exp.y: Update rules.
11168 (yylex): Update.
11169 * go-exp.y (lex_one_token): Update.
11170 Update rules.
11171 (classify_unsafe_function, classify_packaged_name)
11172 (classify_name, yylex): Update.
11173
11174 2019-04-19 Sergei Trofimovich <siarheit@google.com>
11175
11176 * configure.ac: add --enable-source-highlight switch.
11177 * configure: Regenerate.
11178 * top.c (print_gdb_version): plumb --enable-source-highlight
11179 status to "show configuration".
11180
11181 2019-04-19 Tom Tromey <tromey@adacore.com>
11182
11183 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11184 Check ADA_TYPE_P.
11185 (empty_record, ada_template_to_fixed_record_type_1)
11186 (template_to_static_fixed_type)
11187 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11188 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11189 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11190 macros.
11191
11192 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11193
11194 PR symtab/24423:
11195 * source.c (print_source_lines_base): Advance "iter" when a
11196 control character is seen.
11197
11198 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11199
11200 * inferior.h (struct infcall_suspend_state_deleter):
11201 Catch exception in destructor to avoid crash.
11202
11203 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11204
11205 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11206 close to the add_com "shell".
11207
11208 2019-04-18 Tom Tromey <tromey@adacore.com>
11209
11210 * process-stratum-target.h (class process_stratum_target)
11211 <stratum>: Add "final".
11212
11213 2019-04-17 Tom Tromey <tromey@adacore.com>
11214
11215 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11216 against nullptr before use.
11217
11218 2019-04-17 Alan Hayward <alan.hayward@arm.com>
11219
11220 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11221
11222 2019-04-17 Jim Wilson <jimw@sifive.com>
11223 Andrew Burgess <andrew.burgess@embecosm.com>
11224
11225 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11226 code read might fail, assume 4-byte breakpoint in that case.
11227
11228 2019-04-15 Leszek Swirski <leszeks@google.com>
11229
11230 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11231 rather than a hand-rolled POD check when checking for forced MEMORY
11232 classification.
11233
11234 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11235
11236 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11237 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11238 function.
11239 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11240 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11241 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11242 declaration.
11243
11244 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11245
11246 * aarch64-linux-nat.c
11247 (aarch64_linux_nat_target::thread_architecture): Add override.
11248 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11249 each VQ.
11250
11251 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11252
11253 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11254
11255 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11256
11257 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11258 target types of size 96-bits, add some additional comments, and
11259 check that the builtin type we found was the correct size.
11260
11261 2019-04-12 Eli Zaretskii <eliz@gnu.org>
11262
11263 * utils.c (prompt_for_continue): Don't restore the styling at the
11264 end, as applied_style has the wrong value. This fixes styling in
11265 long lists of file names that are interrupted by the "Continue?"
11266 prompt.
11267
11268 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11269
11270 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11271 * c-lang.c (c_language_defn): Likewise.
11272 (cplus_language_defn): Likewise.
11273 (asm_language_defn): Likewise.
11274 (minimal_language_defn): Likewise.
11275 * d-lang.c (d_language_defn): Likewise.
11276 * f-lang.c (f_language_defn): Likewise.
11277 * go-lang.c (go_language_defn): Likewise.
11278 * language.c (unknown_language_defn): Likewise.
11279 (auto_language_defn): Likewise.
11280 * language.h (struct language_defn): Remove la_magic field.
11281 (LANG_MAGIC): Delete.
11282 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11283 * objc-lang.c (objc_language_defn): Likewise.
11284 * opencl-lang.c (opencl_language_defn): Likewise.
11285 * p-lang.c (pascal_language_defn): Likewise.
11286 * rust-lang.c (rust_language_defn): Likewise.
11287
11288 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11289
11290 * riscv-tdep.c (riscv_type_align): New function.
11291 (riscv_type_alignment): Delete.
11292 (riscv_arg_location): Use 'type_align'.
11293 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11294
11295 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11296
11297 * gdbtypes.c (type_align): A struct with no non-static fields also
11298 has alignment of 1.
11299
11300 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11301
11302 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11303 component to 0.
11304 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11305 member.
11306 (riscv_struct_info::analyse): New implementation using new
11307 analyse_inner member function.
11308 (riscv_struct_info::field_offset): New member function.
11309 (riscv_struct_info::m_offsets): New member variable.
11310 (riscv_struct_info::analyse_inner): New private member function,
11311 takes the old implementation of riscv_struct_info::analyse but
11312 extended to track field offsets.
11313 (riscv_call_arg_struct): Update the struct folding special cases
11314 to handle cases where empty C++ structs, which are non-zero
11315 length, are found.
11316 (riscv_arg_location): Initialise the length of each location, a
11317 non-zero length now indicates the location is in use.
11318 (riscv_push_dummy_call): Allow for the first location having a
11319 non-zero offset when setting up arguments.
11320 (riscv_return_value): Likewise, but for return values.
11321
11322 2019-04-11 Tom Tromey <tromey@adacore.com>
11323
11324 * utils.c (internal_vproblem): Make "msg" const.
11325
11326 2019-04-11 Alan Hayward <alan.hayward@arm.com>
11327
11328 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11329 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11330 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11331 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11332
11333 2019-04-10 Kevin Buettner <kevinb@redhat.com>
11334
11335 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11336 function.
11337 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11338 of amd64_collect_native_gregset.
11339 (amd64_linux_nat_target::store_registers): Likewise.
11340
11341 2019-04-10 Tom Tromey <tom@tromey.com>
11342
11343 * symtab.c (lookup_global_symbol_from_objfile)
11344 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11345 * objfiles.h (class separate_debug_iterator): New.
11346 (class separate_debug_range): New.
11347 (struct objfile) <separate_debug_objfiles>: New method.
11348 (objfile_separate_debug_iterate): Don't declare.
11349 * objfiles.c (separate_debug_iterator::operator++): Rename from
11350 objfile_separate_debug_iterate.
11351 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11352 iterator.
11353 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11354 iterator.
11355
11356 2019-04-10 Tom Tromey <tom@tromey.com>
11357
11358 * symfile.c (reread_symbols): Remove old comment.
11359 * objfiles.c (free_all_objfiles): Fix a typo.
11360
11361 2019-04-10 Tom Tromey <tom@tromey.com>
11362
11363 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11364 * minsyms.c (lookup_minimal_symbol): Use foreach.
11365 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11366 (lookup_minimal_symbol_solib_trampoline): Likewise.
11367 * symfile.c (reread_symbols): Use foreach.
11368
11369 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
11370 Tom Tromey <tromey@adacore.com>
11371
11372 PR rust/24414:
11373 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11374 (rust_lex_int_test): Change "value" to be LONGEST.
11375 (rust_lex_tests): Add test for long integer literal.
11376
11377 2019-04-09 Tom Tromey <tromey@adacore.com>
11378
11379 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11380 to bool.
11381 (extended_remote_target::attach): Update.
11382 (remote_target::remote_notice_new_inferior): Update.
11383 (remote_target::add_current_inferior_and_thread): Update.
11384 * inferior.c (exit_inferior_1): Use "false".
11385 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11386
11387 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
11388
11389 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11390 the "start" command.
11391
11392 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11393
11394 * python/py-inferior.c (infpy_thread_from_thread_handle):
11395 Adjust comments to reflect renaming of thread_from_thread_handle
11396 to thread_from_handle. Adjust keywords. Fix type error message.
11397 (inferior_object_methods): Add thread_from_handle. Retain
11398 thread_from_thread_handle, but mark it as deprecated.
11399
11400 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11401
11402 * gdbthread.h (find_thread_by_handle): Revise declaration.
11403 * thread.c (find_thread_by_handle): Likewise. Adjust
11404 implementation too.
11405 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11406 support for buffer objects as handles.
11407
11408 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11409
11410 * python/py-infthread.c (thpy_thread_handle): New function.
11411 (thread_object_methods): Register thpy_thread_handle.
11412
11413 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11414
11415 * gdbthread.h (thread_to_thread_handle): Declare.
11416 * thread.c (gdbtypes.h): Include.
11417 (thread_to_thread_handle): New function.
11418
11419 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11420 (target_thread_info_to_thread_handle): Declare.
11421 * target.c (target_thread_info_to_thread_handle): New function.
11422 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11423 * target-delegates.c: Regenerate.
11424
11425 * linux-thread-db.c (class thread_db_target): Add method
11426 thread_info_to_thread_handle.
11427 (thread_db_target::thread_info_to_thread_handle): Define.
11428 * remote.c (class remote_target): Add new method
11429 thread_info_to_thread_handle.
11430 (remote_target::thread_info_to_thread_handle): Define.
11431
11432 2019-04-08 Pedro Alves <palves@redhat.com>
11433
11434 * common/common-exceptions.c (throw_exception): Don't create
11435 named object to throw; throw directly.
11436 (throw_it): Likewise. Don't initialize gdb_exception::message
11437 here, with new; pass FMT and AP to the ctor instead.
11438 * common/common-exceptions.h: Include <string>.
11439 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11440 const char *, va_list)): New ctor. Use std::make_shared.
11441 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11442 errors)): Delete.
11443 (gdb_exception_error::gdb_exception_error(enum errors, const char
11444 *, va_list)): New.
11445 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11446 Add assertion.
11447 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11448 errors)): Delete.
11449 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11450 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11451 Add assertion.
11452
11453 2019-04-08 Tom Tromey <tom@tromey.com>
11454
11455 * valops.c (value_rtti_indirect_type): Replace throw_exception
11456 with throw.
11457 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11458 with throw.
11459 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11460 throw.
11461 * target.c (target_translate_tls_address): Replace throw_exception
11462 with throw.
11463 * stack.c (frame_apply_command_count): Replace throw_exception
11464 with throw.
11465 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11466 throw.
11467 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11468 with throw.
11469 * rs6000-tdep.c (rs6000_frame_cache)
11470 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11471 * remote.c: Replace throw_exception with throw.
11472 * record-full.c (record_full_message, record_full_wait_1)
11473 (record_full_restore): Replace throw_exception with throw.
11474 * record-btrace.c:
11475 (get_thread_current_frame_id, record_btrace_start_replaying)
11476 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11477 (cmd_record_btrace_start): Replace throw_exception with throw.
11478 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11479 throw.
11480 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11481 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11482 * linespec.c:
11483 (find_linespec_symbols): Replace throw_exception with throw.
11484 * infrun.c (displaced_step_prepare, resume): Replace
11485 throw_exception with throw.
11486 * infcmd.c (post_create_inferior): Replace throw_exception with
11487 throw.
11488 * inf-loop.c (inferior_event_handler): Replace throw_exception
11489 with throw.
11490 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11491 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11492 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11493 (get_prev_frame_always, get_frame_pc_if_available)
11494 (get_frame_address_in_block_if_available, get_frame_language):
11495 Replace throw_exception with throw.
11496 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11497 throw_exception with throw.
11498 * eval.c (fetch_subexp_value, evaluate_var_value)
11499 (evaluate_funcall, evaluate_subexp_standard): Replace
11500 throw_exception with throw.
11501 * dwarf2loc.c (call_site_find_chain)
11502 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11503 Replace throw_exception with throw.
11504 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11505 with throw.
11506 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11507 throw.
11508 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11509 * completer.c (complete_line_internal): Replace throw_exception
11510 with throw.
11511 * compile/compile-object-run.c (compile_object_run): Replace
11512 throw_exception with throw.
11513 * cli/cli-script.c (process_next_line): Replace throw_exception
11514 with throw.
11515 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11516 (btrace_enable, btrace_maint_update_pt_packets): Replace
11517 throw_exception with throw.
11518 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11519 throw_exception with throw.
11520 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11521 throw_exception with throw.
11522 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11523 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11524 * aarch64-tdep.c (aarch64_make_prologue_cache)
11525 (aarch64_make_stub_cache): Replace throw_exception with throw.
11526
11527 2019-04-08 Tom Tromey <tom@tromey.com>
11528
11529 * common/common-exceptions.c (throw_exception): Rename from
11530 throw_exception_cxx. Remove old copy. Make argument const.
11531 (throw_it): Create and throw exception objects directly.
11532 * common/common-exceptions.h (throw_exception): Make argument
11533 const.
11534 (struct gdb_exception_error): Add constructor.
11535 (struct gdb_exception_quit): Add constructor.
11536
11537 2019-04-08 Tom Tromey <tom@tromey.com>
11538
11539 * common/common-exceptions.h (exception_rethrow): Don't declare.
11540 (TRY_SJLJ): Update comment.
11541 (TRY, CATCH, END_CATCH): Remove.
11542 * common/common-exceptions.c (exception_rethrow): Remove.
11543
11544 2019-04-08 Tom Tromey <tom@tromey.com>
11545
11546 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11547 Remove.
11548 (gdb_exception_error): Rename from
11549 gdb_exception_RETURN_MASK_ERROR.
11550 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11551 (gdb_quit_bad_alloc): Update.
11552 * aarch64-tdep.c: Update.
11553 * ada-lang.c: Update.
11554 * ada-typeprint.c: Update.
11555 * ada-valprint.c: Update.
11556 * amd64-tdep.c: Update.
11557 * arch-utils.c: Update.
11558 * break-catch-throw.c: Update.
11559 * breakpoint.c: Update.
11560 * btrace.c: Update.
11561 * c-varobj.c: Update.
11562 * cli/cli-cmds.c: Update.
11563 * cli/cli-interp.c: Update.
11564 * cli/cli-script.c: Update.
11565 * common/common-exceptions.c: Update.
11566 * common/new-op.c: Update.
11567 * common/selftest.c: Update.
11568 * compile/compile-c-symbols.c: Update.
11569 * compile/compile-cplus-symbols.c: Update.
11570 * compile/compile-object-load.c: Update.
11571 * compile/compile-object-run.c: Update.
11572 * completer.c: Update.
11573 * corelow.c: Update.
11574 * cp-abi.c: Update.
11575 * cp-support.c: Update.
11576 * cp-valprint.c: Update.
11577 * darwin-nat.c: Update.
11578 * disasm-selftests.c: Update.
11579 * dtrace-probe.c: Update.
11580 * dwarf-index-cache.c: Update.
11581 * dwarf-index-write.c: Update.
11582 * dwarf2-frame-tailcall.c: Update.
11583 * dwarf2-frame.c: Update.
11584 * dwarf2loc.c: Update.
11585 * dwarf2read.c: Update.
11586 * eval.c: Update.
11587 * event-loop.c: Update.
11588 * event-top.c: Update.
11589 * exec.c: Update.
11590 * f-valprint.c: Update.
11591 * fbsd-tdep.c: Update.
11592 * frame-unwind.c: Update.
11593 * frame.c: Update.
11594 * gdbtypes.c: Update.
11595 * gnu-v3-abi.c: Update.
11596 * guile/guile-internal.h: Update.
11597 * guile/scm-block.c: Update.
11598 * guile/scm-breakpoint.c: Update.
11599 * guile/scm-cmd.c: Update.
11600 * guile/scm-disasm.c: Update.
11601 * guile/scm-frame.c: Update.
11602 * guile/scm-lazy-string.c: Update.
11603 * guile/scm-math.c: Update.
11604 * guile/scm-param.c: Update.
11605 * guile/scm-ports.c: Update.
11606 * guile/scm-pretty-print.c: Update.
11607 * guile/scm-symbol.c: Update.
11608 * guile/scm-symtab.c: Update.
11609 * guile/scm-type.c: Update.
11610 * guile/scm-value.c: Update.
11611 * i386-linux-tdep.c: Update.
11612 * i386-tdep.c: Update.
11613 * inf-loop.c: Update.
11614 * infcall.c: Update.
11615 * infcmd.c: Update.
11616 * infrun.c: Update.
11617 * jit.c: Update.
11618 * language.c: Update.
11619 * linespec.c: Update.
11620 * linux-fork.c: Update.
11621 * linux-nat.c: Update.
11622 * linux-tdep.c: Update.
11623 * linux-thread-db.c: Update.
11624 * main.c: Update.
11625 * mi/mi-cmd-break.c: Update.
11626 * mi/mi-cmd-stack.c: Update.
11627 * mi/mi-interp.c: Update.
11628 * mi/mi-main.c: Update.
11629 * objc-lang.c: Update.
11630 * p-valprint.c: Update.
11631 * parse.c: Update.
11632 * ppc-linux-tdep.c: Update.
11633 * printcmd.c: Update.
11634 * python/py-arch.c: Update.
11635 * python/py-breakpoint.c: Update.
11636 * python/py-cmd.c: Update.
11637 * python/py-finishbreakpoint.c: Update.
11638 * python/py-frame.c: Update.
11639 * python/py-framefilter.c: Update.
11640 * python/py-gdb-readline.c: Update.
11641 * python/py-inferior.c: Update.
11642 * python/py-infthread.c: Update.
11643 * python/py-lazy-string.c: Update.
11644 * python/py-linetable.c: Update.
11645 * python/py-objfile.c: Update.
11646 * python/py-param.c: Update.
11647 * python/py-prettyprint.c: Update.
11648 * python/py-progspace.c: Update.
11649 * python/py-record-btrace.c: Update.
11650 * python/py-record.c: Update.
11651 * python/py-symbol.c: Update.
11652 * python/py-type.c: Update.
11653 * python/py-unwind.c: Update.
11654 * python/py-utils.c: Update.
11655 * python/py-value.c: Update.
11656 * python/python.c: Update.
11657 * record-btrace.c: Update.
11658 * record-full.c: Update.
11659 * remote-fileio.c: Update.
11660 * remote.c: Update.
11661 * riscv-tdep.c: Update.
11662 * rs6000-aix-tdep.c: Update.
11663 * rs6000-tdep.c: Update.
11664 * rust-exp.y: Update.
11665 * rust-lang.c: Update.
11666 * s390-tdep.c: Update.
11667 * selftest-arch.c: Update.
11668 * solib-dsbt.c: Update.
11669 * solib-frv.c: Update.
11670 * solib-spu.c: Update.
11671 * solib-svr4.c: Update.
11672 * solib.c: Update.
11673 * sparc64-linux-tdep.c: Update.
11674 * stack.c: Update.
11675 * symfile-mem.c: Update.
11676 * symmisc.c: Update.
11677 * target.c: Update.
11678 * thread.c: Update.
11679 * top.c: Update.
11680 * tracefile-tfile.c: Update.
11681 * tui/tui.c: Update.
11682 * typeprint.c: Update.
11683 * unittests/cli-utils-selftests.c: Update.
11684 * unittests/parse-connection-spec-selftests.c: Update.
11685 * valops.c: Update.
11686 * valprint.c: Update.
11687 * value.c: Update.
11688 * varobj.c: Update.
11689 * windows-nat.c: Update.
11690 * x86-linux-nat.c: Update.
11691 * xml-support.c: Update.
11692
11693 2019-04-08 Tom Tromey <tom@tromey.com>
11694
11695 * xml-support.c: Use C++ exception handling.
11696 * x86-linux-nat.c: Use C++ exception handling.
11697 * windows-nat.c: Use C++ exception handling.
11698 * varobj.c: Use C++ exception handling.
11699 * value.c: Use C++ exception handling.
11700 * valprint.c: Use C++ exception handling.
11701 * valops.c: Use C++ exception handling.
11702 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11703 handling.
11704 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11705 * typeprint.c: Use C++ exception handling.
11706 * tui/tui.c: Use C++ exception handling.
11707 * tracefile-tfile.c: Use C++ exception handling.
11708 * top.c: Use C++ exception handling.
11709 * thread.c: Use C++ exception handling.
11710 * target.c: Use C++ exception handling.
11711 * symmisc.c: Use C++ exception handling.
11712 * symfile-mem.c: Use C++ exception handling.
11713 * stack.c: Use C++ exception handling.
11714 * sparc64-linux-tdep.c: Use C++ exception handling.
11715 * solib.c: Use C++ exception handling.
11716 * solib-svr4.c: Use C++ exception handling.
11717 * solib-spu.c: Use C++ exception handling.
11718 * solib-frv.c: Use C++ exception handling.
11719 * solib-dsbt.c: Use C++ exception handling.
11720 * selftest-arch.c: Use C++ exception handling.
11721 * s390-tdep.c: Use C++ exception handling.
11722 * rust-lang.c: Use C++ exception handling.
11723 * rust-exp.y: Use C++ exception handling.
11724 * rs6000-tdep.c: Use C++ exception handling.
11725 * rs6000-aix-tdep.c: Use C++ exception handling.
11726 * riscv-tdep.c: Use C++ exception handling.
11727 * remote.c: Use C++ exception handling.
11728 * remote-fileio.c: Use C++ exception handling.
11729 * record-full.c: Use C++ exception handling.
11730 * record-btrace.c: Use C++ exception handling.
11731 * python/python.c: Use C++ exception handling.
11732 * python/py-value.c: Use C++ exception handling.
11733 * python/py-utils.c: Use C++ exception handling.
11734 * python/py-unwind.c: Use C++ exception handling.
11735 * python/py-type.c: Use C++ exception handling.
11736 * python/py-symbol.c: Use C++ exception handling.
11737 * python/py-record.c: Use C++ exception handling.
11738 * python/py-record-btrace.c: Use C++ exception handling.
11739 * python/py-progspace.c: Use C++ exception handling.
11740 * python/py-prettyprint.c: Use C++ exception handling.
11741 * python/py-param.c: Use C++ exception handling.
11742 * python/py-objfile.c: Use C++ exception handling.
11743 * python/py-linetable.c: Use C++ exception handling.
11744 * python/py-lazy-string.c: Use C++ exception handling.
11745 * python/py-infthread.c: Use C++ exception handling.
11746 * python/py-inferior.c: Use C++ exception handling.
11747 * python/py-gdb-readline.c: Use C++ exception handling.
11748 * python/py-framefilter.c: Use C++ exception handling.
11749 * python/py-frame.c: Use C++ exception handling.
11750 * python/py-finishbreakpoint.c: Use C++ exception handling.
11751 * python/py-cmd.c: Use C++ exception handling.
11752 * python/py-breakpoint.c: Use C++ exception handling.
11753 * python/py-arch.c: Use C++ exception handling.
11754 * printcmd.c: Use C++ exception handling.
11755 * ppc-linux-tdep.c: Use C++ exception handling.
11756 * parse.c: Use C++ exception handling.
11757 * p-valprint.c: Use C++ exception handling.
11758 * objc-lang.c: Use C++ exception handling.
11759 * mi/mi-main.c: Use C++ exception handling.
11760 * mi/mi-interp.c: Use C++ exception handling.
11761 * mi/mi-cmd-stack.c: Use C++ exception handling.
11762 * mi/mi-cmd-break.c: Use C++ exception handling.
11763 * main.c: Use C++ exception handling.
11764 * linux-thread-db.c: Use C++ exception handling.
11765 * linux-tdep.c: Use C++ exception handling.
11766 * linux-nat.c: Use C++ exception handling.
11767 * linux-fork.c: Use C++ exception handling.
11768 * linespec.c: Use C++ exception handling.
11769 * language.c: Use C++ exception handling.
11770 * jit.c: Use C++ exception handling.
11771 * infrun.c: Use C++ exception handling.
11772 * infcmd.c: Use C++ exception handling.
11773 * infcall.c: Use C++ exception handling.
11774 * inf-loop.c: Use C++ exception handling.
11775 * i386-tdep.c: Use C++ exception handling.
11776 * i386-linux-tdep.c: Use C++ exception handling.
11777 * guile/scm-value.c: Use C++ exception handling.
11778 * guile/scm-type.c: Use C++ exception handling.
11779 * guile/scm-symtab.c: Use C++ exception handling.
11780 * guile/scm-symbol.c: Use C++ exception handling.
11781 * guile/scm-pretty-print.c: Use C++ exception handling.
11782 * guile/scm-ports.c: Use C++ exception handling.
11783 * guile/scm-param.c: Use C++ exception handling.
11784 * guile/scm-math.c: Use C++ exception handling.
11785 * guile/scm-lazy-string.c: Use C++ exception handling.
11786 * guile/scm-frame.c: Use C++ exception handling.
11787 * guile/scm-disasm.c: Use C++ exception handling.
11788 * guile/scm-cmd.c: Use C++ exception handling.
11789 * guile/scm-breakpoint.c: Use C++ exception handling.
11790 * guile/scm-block.c: Use C++ exception handling.
11791 * guile/guile-internal.h: Use C++ exception handling.
11792 * gnu-v3-abi.c: Use C++ exception handling.
11793 * gdbtypes.c: Use C++ exception handling.
11794 * frame.c: Use C++ exception handling.
11795 * frame-unwind.c: Use C++ exception handling.
11796 * fbsd-tdep.c: Use C++ exception handling.
11797 * f-valprint.c: Use C++ exception handling.
11798 * exec.c: Use C++ exception handling.
11799 * event-top.c: Use C++ exception handling.
11800 * event-loop.c: Use C++ exception handling.
11801 * eval.c: Use C++ exception handling.
11802 * dwarf2read.c: Use C++ exception handling.
11803 * dwarf2loc.c: Use C++ exception handling.
11804 * dwarf2-frame.c: Use C++ exception handling.
11805 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11806 * dwarf-index-write.c: Use C++ exception handling.
11807 * dwarf-index-cache.c: Use C++ exception handling.
11808 * dtrace-probe.c: Use C++ exception handling.
11809 * disasm-selftests.c: Use C++ exception handling.
11810 * darwin-nat.c: Use C++ exception handling.
11811 * cp-valprint.c: Use C++ exception handling.
11812 * cp-support.c: Use C++ exception handling.
11813 * cp-abi.c: Use C++ exception handling.
11814 * corelow.c: Use C++ exception handling.
11815 * completer.c: Use C++ exception handling.
11816 * compile/compile-object-run.c: Use C++ exception handling.
11817 * compile/compile-object-load.c: Use C++ exception handling.
11818 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11819 * compile/compile-c-symbols.c: Use C++ exception handling.
11820 * common/selftest.c: Use C++ exception handling.
11821 * common/new-op.c: Use C++ exception handling.
11822 * cli/cli-script.c: Use C++ exception handling.
11823 * cli/cli-interp.c: Use C++ exception handling.
11824 * cli/cli-cmds.c: Use C++ exception handling.
11825 * c-varobj.c: Use C++ exception handling.
11826 * btrace.c: Use C++ exception handling.
11827 * breakpoint.c: Use C++ exception handling.
11828 * break-catch-throw.c: Use C++ exception handling.
11829 * arch-utils.c: Use C++ exception handling.
11830 * amd64-tdep.c: Use C++ exception handling.
11831 * ada-valprint.c: Use C++ exception handling.
11832 * ada-typeprint.c: Use C++ exception handling.
11833 * ada-lang.c: Use C++ exception handling.
11834 * aarch64-tdep.c: Use C++ exception handling.
11835
11836 2019-04-08 Tom Tromey <tom@tromey.com>
11837
11838 * xml-support.c (gdb_xml_parser::parse): Update.
11839 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11840 * value.c (show_convenience): Update.
11841 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11842 (test_parse_flags_qcs): Update.
11843 * thread.c (thr_try_catch_cmd): Update.
11844 * target.c (target_translate_tls_address): Update.
11845 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11846 (info_frame_command_core, frame_apply_command_count): Update.
11847 * rust-exp.y (rust_lex_exception_test): Update.
11848 * riscv-tdep.c (riscv_print_one_register_info): Update.
11849 * remote.c (remote_target::enable_btrace): Update.
11850 * record-btrace.c (record_btrace_enable_warn): Update.
11851 * python/py-utils.c (gdbpy_convert_exception): Update.
11852 * printcmd.c (do_one_display, print_variable_and_value): Update.
11853 * mi/mi-main.c (mi_print_exception): Update.
11854 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11855 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11856 * linux-nat.c (linux_nat_target::attach): Update.
11857 * linux-fork.c (class scoped_switch_fork_info): Update.
11858 * infrun.c (displaced_step_prepare): Update.
11859 * infcall.c (call_function_by_hand_dummy): Update.
11860 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11861 * gnu-v3-abi.c (print_one_vtable): Update.
11862 * frame.c (get_prev_frame_always): Update.
11863 * f-valprint.c (info_common_command_for_block): Update.
11864 * exec.c (try_open_exec_file): Update.
11865 * exceptions.c (print_exception, exception_print)
11866 (exception_fprintf, exception_print_same): Update.
11867 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11868 * dwarf-index-cache.c (index_cache::store)
11869 (index_cache::lookup_gdb_index): Update.
11870 * darwin-nat.c (maybe_cache_shell): Update.
11871 * cp-valprint.c (cp_print_value_fields): Update.
11872 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11873 (gcc_cplus_symbol_address): Update.
11874 * compile/compile-c-symbols.c (gcc_convert_symbol)
11875 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11876 * common/selftest.c: Update.
11877 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11878 a std::string.
11879 (exception_try_scope_entry, exception_try_scope_exit): Don't
11880 declare.
11881 (struct exception_try_scope): Remove.
11882 (TRY): Don't use exception_try_scope.
11883 (struct gdb_exception): Add constructor, operator=.
11884 <what>: New method.
11885 (struct gdb_exception_RETURN_MASK_ALL)
11886 (struct gdb_exception_RETURN_MASK_ERROR)
11887 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11888 (struct gdb_quit_bad_alloc): Update.
11889 * common/common-exceptions.c (exception_none): Change
11890 initializer.
11891 (struct catcher) <state, exception>: Initialize inline.
11892 <prev>: Remove member.
11893 (current_catcher): Remove.
11894 (catchers): New global.
11895 (exceptions_state_mc_init): Simplify.
11896 (catcher_pop): Remove.
11897 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11898 (try_scope_depth, exception_try_scope_entry)
11899 (exception_try_scope_exit): Remove.
11900 (throw_exception_sjlj): Update.
11901 (exception_messages, exception_messages_size): Remove.
11902 (throw_it): Simplify.
11903 (gdb_exception_sliced_copy): Remove.
11904 (throw_exception_cxx): Update.
11905 * cli/cli-script.c (script_from_file): Update.
11906 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11907 Update.
11908 * ada-valprint.c (ada_val_print): Update.
11909 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11910 (create_excep_cond_exprs): Update.
11911
11912 2019-04-08 Tom Tromey <tom@tromey.com>
11913
11914 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11915 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11916 (TRY, CATCH, END_CATCH): Remove some definitions.
11917 * common/common-exceptions.c: Don't use GDB_XCPT.
11918 (catcher_list_size): Remove.
11919 (throw_exception, throw_it): Simplify.
11920
11921 2019-04-05 Tom Tromey <tom@tromey.com>
11922
11923 Revert the header-sorting patch.
11924 * ft32-tdep.c: Revert.
11925 * frv-tdep.c: Revert.
11926 * frv-linux-tdep.c: Revert.
11927 * frame.c: Revert.
11928 * frame-unwind.c: Revert.
11929 * frame-base.c: Revert.
11930 * fork-child.c: Revert.
11931 * findvar.c: Revert.
11932 * findcmd.c: Revert.
11933 * filesystem.c: Revert.
11934 * filename-seen-cache.h: Revert.
11935 * filename-seen-cache.c: Revert.
11936 * fbsd-tdep.c: Revert.
11937 * fbsd-nat.h: Revert.
11938 * fbsd-nat.c: Revert.
11939 * f-valprint.c: Revert.
11940 * f-typeprint.c: Revert.
11941 * f-lang.c: Revert.
11942 * extension.h: Revert.
11943 * extension.c: Revert.
11944 * extension-priv.h: Revert.
11945 * expprint.c: Revert.
11946 * exec.h: Revert.
11947 * exec.c: Revert.
11948 * exceptions.c: Revert.
11949 * event-top.c: Revert.
11950 * event-loop.c: Revert.
11951 * eval.c: Revert.
11952 * elfread.c: Revert.
11953 * dwarf2read.h: Revert.
11954 * dwarf2read.c: Revert.
11955 * dwarf2loc.c: Revert.
11956 * dwarf2expr.h: Revert.
11957 * dwarf2expr.c: Revert.
11958 * dwarf2-frame.c: Revert.
11959 * dwarf2-frame-tailcall.c: Revert.
11960 * dwarf-index-write.h: Revert.
11961 * dwarf-index-write.c: Revert.
11962 * dwarf-index-common.c: Revert.
11963 * dwarf-index-cache.h: Revert.
11964 * dwarf-index-cache.c: Revert.
11965 * dummy-frame.c: Revert.
11966 * dtrace-probe.c: Revert.
11967 * disasm.h: Revert.
11968 * disasm.c: Revert.
11969 * disasm-selftests.c: Revert.
11970 * dictionary.c: Revert.
11971 * dicos-tdep.c: Revert.
11972 * demangle.c: Revert.
11973 * dcache.h: Revert.
11974 * dcache.c: Revert.
11975 * darwin-nat.h: Revert.
11976 * darwin-nat.c: Revert.
11977 * darwin-nat-info.c: Revert.
11978 * d-valprint.c: Revert.
11979 * d-namespace.c: Revert.
11980 * d-lang.c: Revert.
11981 * ctf.c: Revert.
11982 * csky-tdep.c: Revert.
11983 * csky-linux-tdep.c: Revert.
11984 * cris-tdep.c: Revert.
11985 * cris-linux-tdep.c: Revert.
11986 * cp-valprint.c: Revert.
11987 * cp-support.c: Revert.
11988 * cp-namespace.c: Revert.
11989 * cp-abi.c: Revert.
11990 * corelow.c: Revert.
11991 * corefile.c: Revert.
11992 * continuations.c: Revert.
11993 * completer.h: Revert.
11994 * completer.c: Revert.
11995 * complaints.c: Revert.
11996 * coffread.c: Revert.
11997 * coff-pe-read.c: Revert.
11998 * cli-out.h: Revert.
11999 * cli-out.c: Revert.
12000 * charset.c: Revert.
12001 * c-varobj.c: Revert.
12002 * c-valprint.c: Revert.
12003 * c-typeprint.c: Revert.
12004 * c-lang.c: Revert.
12005 * buildsym.c: Revert.
12006 * buildsym-legacy.c: Revert.
12007 * build-id.h: Revert.
12008 * build-id.c: Revert.
12009 * btrace.c: Revert.
12010 * bsd-uthread.c: Revert.
12011 * breakpoint.h: Revert.
12012 * breakpoint.c: Revert.
12013 * break-catch-throw.c: Revert.
12014 * break-catch-syscall.c: Revert.
12015 * break-catch-sig.c: Revert.
12016 * blockframe.c: Revert.
12017 * block.c: Revert.
12018 * bfin-tdep.c: Revert.
12019 * bfin-linux-tdep.c: Revert.
12020 * bfd-target.c: Revert.
12021 * bcache.c: Revert.
12022 * ax-general.c: Revert.
12023 * ax-gdb.h: Revert.
12024 * ax-gdb.c: Revert.
12025 * avr-tdep.c: Revert.
12026 * auxv.c: Revert.
12027 * auto-load.c: Revert.
12028 * arm-wince-tdep.c: Revert.
12029 * arm-tdep.c: Revert.
12030 * arm-symbian-tdep.c: Revert.
12031 * arm-pikeos-tdep.c: Revert.
12032 * arm-obsd-tdep.c: Revert.
12033 * arm-nbsd-tdep.c: Revert.
12034 * arm-nbsd-nat.c: Revert.
12035 * arm-linux-tdep.c: Revert.
12036 * arm-linux-nat.c: Revert.
12037 * arm-fbsd-tdep.c: Revert.
12038 * arm-fbsd-nat.c: Revert.
12039 * arm-bsd-tdep.c: Revert.
12040 * arch-utils.c: Revert.
12041 * arc-tdep.c: Revert.
12042 * arc-newlib-tdep.c: Revert.
12043 * annotate.h: Revert.
12044 * annotate.c: Revert.
12045 * amd64-windows-tdep.c: Revert.
12046 * amd64-windows-nat.c: Revert.
12047 * amd64-tdep.c: Revert.
12048 * amd64-sol2-tdep.c: Revert.
12049 * amd64-obsd-tdep.c: Revert.
12050 * amd64-obsd-nat.c: Revert.
12051 * amd64-nbsd-tdep.c: Revert.
12052 * amd64-nbsd-nat.c: Revert.
12053 * amd64-nat.c: Revert.
12054 * amd64-linux-tdep.c: Revert.
12055 * amd64-linux-nat.c: Revert.
12056 * amd64-fbsd-tdep.c: Revert.
12057 * amd64-fbsd-nat.c: Revert.
12058 * amd64-dicos-tdep.c: Revert.
12059 * amd64-darwin-tdep.c: Revert.
12060 * amd64-bsd-nat.c: Revert.
12061 * alpha-tdep.c: Revert.
12062 * alpha-obsd-tdep.c: Revert.
12063 * alpha-nbsd-tdep.c: Revert.
12064 * alpha-mdebug-tdep.c: Revert.
12065 * alpha-linux-tdep.c: Revert.
12066 * alpha-linux-nat.c: Revert.
12067 * alpha-bsd-tdep.c: Revert.
12068 * alpha-bsd-nat.c: Revert.
12069 * aix-thread.c: Revert.
12070 * agent.c: Revert.
12071 * addrmap.c: Revert.
12072 * ada-varobj.c: Revert.
12073 * ada-valprint.c: Revert.
12074 * ada-typeprint.c: Revert.
12075 * ada-tasks.c: Revert.
12076 * ada-lang.c: Revert.
12077 * aarch64-tdep.c: Revert.
12078 * aarch64-ravenscar-thread.c: Revert.
12079 * aarch64-newlib-tdep.c: Revert.
12080 * aarch64-linux-tdep.c: Revert.
12081 * aarch64-linux-nat.c: Revert.
12082 * aarch64-fbsd-tdep.c: Revert.
12083 * aarch64-fbsd-nat.c: Revert.
12084 * aarch32-linux-nat.c: Revert.
12085
12086 2019-04-05 Tom Tromey <tom@tromey.com>
12087
12088 * ft32-tdep.c: Sort headers.
12089 * frv-tdep.c: Sort headers.
12090 * frv-linux-tdep.c: Sort headers.
12091 * frame.c: Sort headers.
12092 * frame-unwind.c: Sort headers.
12093 * frame-base.c: Sort headers.
12094 * fork-child.c: Sort headers.
12095 * findvar.c: Sort headers.
12096 * findcmd.c: Sort headers.
12097 * filesystem.c: Sort headers.
12098 * filename-seen-cache.h: Sort headers.
12099 * filename-seen-cache.c: Sort headers.
12100 * fbsd-tdep.c: Sort headers.
12101 * fbsd-nat.h: Sort headers.
12102 * fbsd-nat.c: Sort headers.
12103 * f-valprint.c: Sort headers.
12104 * f-typeprint.c: Sort headers.
12105 * f-lang.c: Sort headers.
12106 * extension.h: Sort headers.
12107 * extension.c: Sort headers.
12108 * extension-priv.h: Sort headers.
12109 * expprint.c: Sort headers.
12110 * exec.h: Sort headers.
12111 * exec.c: Sort headers.
12112 * exceptions.c: Sort headers.
12113 * event-top.c: Sort headers.
12114 * event-loop.c: Sort headers.
12115 * eval.c: Sort headers.
12116 * elfread.c: Sort headers.
12117 * dwarf2read.h: Sort headers.
12118 * dwarf2read.c: Sort headers.
12119 * dwarf2loc.c: Sort headers.
12120 * dwarf2expr.h: Sort headers.
12121 * dwarf2expr.c: Sort headers.
12122 * dwarf2-frame.c: Sort headers.
12123 * dwarf2-frame-tailcall.c: Sort headers.
12124 * dwarf-index-write.h: Sort headers.
12125 * dwarf-index-write.c: Sort headers.
12126 * dwarf-index-common.c: Sort headers.
12127 * dwarf-index-cache.h: Sort headers.
12128 * dwarf-index-cache.c: Sort headers.
12129 * dummy-frame.c: Sort headers.
12130 * dtrace-probe.c: Sort headers.
12131 * disasm.h: Sort headers.
12132 * disasm.c: Sort headers.
12133 * disasm-selftests.c: Sort headers.
12134 * dictionary.c: Sort headers.
12135 * dicos-tdep.c: Sort headers.
12136 * demangle.c: Sort headers.
12137 * dcache.h: Sort headers.
12138 * dcache.c: Sort headers.
12139 * darwin-nat.h: Sort headers.
12140 * darwin-nat.c: Sort headers.
12141 * darwin-nat-info.c: Sort headers.
12142 * d-valprint.c: Sort headers.
12143 * d-namespace.c: Sort headers.
12144 * d-lang.c: Sort headers.
12145 * ctf.c: Sort headers.
12146 * csky-tdep.c: Sort headers.
12147 * csky-linux-tdep.c: Sort headers.
12148 * cris-tdep.c: Sort headers.
12149 * cris-linux-tdep.c: Sort headers.
12150 * cp-valprint.c: Sort headers.
12151 * cp-support.c: Sort headers.
12152 * cp-namespace.c: Sort headers.
12153 * cp-abi.c: Sort headers.
12154 * corelow.c: Sort headers.
12155 * corefile.c: Sort headers.
12156 * continuations.c: Sort headers.
12157 * completer.h: Sort headers.
12158 * completer.c: Sort headers.
12159 * complaints.c: Sort headers.
12160 * coffread.c: Sort headers.
12161 * coff-pe-read.c: Sort headers.
12162 * cli-out.h: Sort headers.
12163 * cli-out.c: Sort headers.
12164 * charset.c: Sort headers.
12165 * c-varobj.c: Sort headers.
12166 * c-valprint.c: Sort headers.
12167 * c-typeprint.c: Sort headers.
12168 * c-lang.c: Sort headers.
12169 * buildsym.c: Sort headers.
12170 * buildsym-legacy.c: Sort headers.
12171 * build-id.h: Sort headers.
12172 * build-id.c: Sort headers.
12173 * btrace.c: Sort headers.
12174 * bsd-uthread.c: Sort headers.
12175 * breakpoint.h: Sort headers.
12176 * breakpoint.c: Sort headers.
12177 * break-catch-throw.c: Sort headers.
12178 * break-catch-syscall.c: Sort headers.
12179 * break-catch-sig.c: Sort headers.
12180 * blockframe.c: Sort headers.
12181 * block.c: Sort headers.
12182 * bfin-tdep.c: Sort headers.
12183 * bfin-linux-tdep.c: Sort headers.
12184 * bfd-target.c: Sort headers.
12185 * bcache.c: Sort headers.
12186 * ax-general.c: Sort headers.
12187 * ax-gdb.h: Sort headers.
12188 * ax-gdb.c: Sort headers.
12189 * avr-tdep.c: Sort headers.
12190 * auxv.c: Sort headers.
12191 * auto-load.c: Sort headers.
12192 * arm-wince-tdep.c: Sort headers.
12193 * arm-tdep.c: Sort headers.
12194 * arm-symbian-tdep.c: Sort headers.
12195 * arm-pikeos-tdep.c: Sort headers.
12196 * arm-obsd-tdep.c: Sort headers.
12197 * arm-nbsd-tdep.c: Sort headers.
12198 * arm-nbsd-nat.c: Sort headers.
12199 * arm-linux-tdep.c: Sort headers.
12200 * arm-linux-nat.c: Sort headers.
12201 * arm-fbsd-tdep.c: Sort headers.
12202 * arm-fbsd-nat.c: Sort headers.
12203 * arm-bsd-tdep.c: Sort headers.
12204 * arch-utils.c: Sort headers.
12205 * arc-tdep.c: Sort headers.
12206 * arc-newlib-tdep.c: Sort headers.
12207 * annotate.h: Sort headers.
12208 * annotate.c: Sort headers.
12209 * amd64-windows-tdep.c: Sort headers.
12210 * amd64-windows-nat.c: Sort headers.
12211 * amd64-tdep.c: Sort headers.
12212 * amd64-sol2-tdep.c: Sort headers.
12213 * amd64-obsd-tdep.c: Sort headers.
12214 * amd64-obsd-nat.c: Sort headers.
12215 * amd64-nbsd-tdep.c: Sort headers.
12216 * amd64-nbsd-nat.c: Sort headers.
12217 * amd64-nat.c: Sort headers.
12218 * amd64-linux-tdep.c: Sort headers.
12219 * amd64-linux-nat.c: Sort headers.
12220 * amd64-fbsd-tdep.c: Sort headers.
12221 * amd64-fbsd-nat.c: Sort headers.
12222 * amd64-dicos-tdep.c: Sort headers.
12223 * amd64-darwin-tdep.c: Sort headers.
12224 * amd64-bsd-nat.c: Sort headers.
12225 * alpha-tdep.c: Sort headers.
12226 * alpha-obsd-tdep.c: Sort headers.
12227 * alpha-nbsd-tdep.c: Sort headers.
12228 * alpha-mdebug-tdep.c: Sort headers.
12229 * alpha-linux-tdep.c: Sort headers.
12230 * alpha-linux-nat.c: Sort headers.
12231 * alpha-bsd-tdep.c: Sort headers.
12232 * alpha-bsd-nat.c: Sort headers.
12233 * aix-thread.c: Sort headers.
12234 * agent.c: Sort headers.
12235 * addrmap.c: Sort headers.
12236 * ada-varobj.c: Sort headers.
12237 * ada-valprint.c: Sort headers.
12238 * ada-typeprint.c: Sort headers.
12239 * ada-tasks.c: Sort headers.
12240 * ada-lang.c: Sort headers.
12241 * aarch64-tdep.c: Sort headers.
12242 * aarch64-ravenscar-thread.c: Sort headers.
12243 * aarch64-newlib-tdep.c: Sort headers.
12244 * aarch64-linux-tdep.c: Sort headers.
12245 * aarch64-linux-nat.c: Sort headers.
12246 * aarch64-fbsd-tdep.c: Sort headers.
12247 * aarch64-fbsd-nat.c: Sort headers.
12248 * aarch32-linux-nat.c: Sort headers.
12249
12250 2019-04-04 Tom Tromey <tom@tromey.com>
12251
12252 * varobj.c (varobj_create): Update.
12253 * rust-exp.y (struct rust_parser) <update_innermost_block,
12254 lookup_symbol>: New methods.
12255 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12256 Rename.
12257 (rust_parser::rust_lookup_type)
12258 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12259 * printcmd.c (display_command, do_one_display): Update.
12260 * parser-defs.h (struct parser_state) <parser_state>: Add
12261 "tracker" parameter.
12262 (block_tracker): New member.
12263 (class innermost_block_tracker) <innermost_block_tracker>: Add
12264 "types" parameter.
12265 <reset>: Remove method.
12266 (innermost_block): Don't declare.
12267 (null_post_parser): Update.
12268 * parse.c (innermost_block): Remove global.
12269 (write_dollar_variable): Update.
12270 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12271 Remove "tracker_types" parameter.
12272 (parse_expression): Add "tracker" parameter.
12273 (parse_expression_for_completion): Update.
12274 (null_post_parser): Add "tracker" parameter.
12275 * p-exp.y: Update rules.
12276 * m2-exp.y: Update rules.
12277 * language.h (struct language_defn) <la_post_parser>: Add
12278 "tracker" parameter.
12279 * go-exp.y: Update rules.
12280 * f-exp.y: Update rules.
12281 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12282 parameter.
12283 * d-exp.y: Update rules.
12284 * c-exp.y: Update rules.
12285 * breakpoint.c (set_breakpoint_condition): Create an
12286 innermost_block_tracker.
12287 (watch_command_1): Likewise.
12288 * ada-lang.c (resolve): Add "tracker" parameter.
12289 (resolve_subexp): Likewise.
12290 * ada-exp.y (write_var_from_sym): Update.
12291
12292 2019-04-04 Tom Tromey <tom@tromey.com>
12293
12294 * type-stack.h: New file.
12295 * type-stack.c: New file.
12296 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12297 type-stack.h.
12298 (insert_into_type_stack, insert_type, push_type, push_type_int)
12299 (insert_type_address_space, pop_type, pop_type_int)
12300 (pop_typelist, pop_type_stack, append_type_stack)
12301 (push_type_stack, get_type_stack, push_typelist)
12302 (follow_type_instance_flags, follow_types): Don't declare.
12303 * parse.c (type_stack): Remove global.
12304 (parse_exp_in_context): Update.
12305 (insert_into_type_stack, insert_type, push_type, push_type_int)
12306 (insert_type_address_space, pop_type, pop_type_int)
12307 (pop_typelist, pop_type_stack, append_type_stack)
12308 (push_type_stack, get_type_stack, push_typelist)
12309 (follow_type_instance_flags, follow_types): Remove (moved to
12310 type-stack.c).
12311 * f-exp.y (type_stack): New global.
12312 Update rules.
12313 (push_kind_type, f_parse): Update.
12314 * d-exp.y (type_stack): New global.
12315 Update rules.
12316 (d_parse): Update.
12317 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12318 Update rules.
12319 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12320 (HFILES_NO_SRCDIR): Add type-stack.h.
12321
12322 2019-04-04 Tom Tromey <tom@tromey.com>
12323
12324 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12325 (rust_parser::convert_ast_to_expression, rust_parse)
12326 (rust_lex_test_completion, rust_lex_tests): Update.
12327 * parser-defs.h (struct expr_completion_state): New.
12328 (struct parser_state) <parser_state>: Add completion parameter.
12329 <mark_struct_expression, mark_completion_tag>: New methods.
12330 <parse_completion, m_completion_state>: New members.
12331 (prefixify_expression, null_post_parser): Update.
12332 (mark_struct_expression, mark_completion_tag): Don't declare.
12333 * parse.c (parse_completion, expout_last_struct)
12334 (expout_tag_completion_type, expout_completion_name): Remove
12335 globals.
12336 (parser_state::mark_struct_expression)
12337 (parser_state::mark_completion_tag): Now methods.
12338 (prefixify_expression): Add last_struct parameter.
12339 (prefixify_subexp): Likewise.
12340 (parse_exp_1): Update.
12341 (parse_exp_in_context): Add cstate parameter. Update.
12342 (parse_expression_for_completion): Create an
12343 expr_completion_state.
12344 (null_post_parser): Add "completion" parameter.
12345 * p-exp.y: Update rules.
12346 (yylex): Update.
12347 * language.h (struct language_defn) <la_post_parser>: Add
12348 "completing" parameter.
12349 * go-exp.y: Update rules.
12350 (lex_one_token): Update.
12351 * expression.h (parse_completion): Don't declare.
12352 * d-exp.y: Update rules.
12353 (lex_one_token): Update rules.
12354 * c-exp.y: Update rules.
12355 (lex_one_token): Update.
12356 * ada-lang.c (resolve): Add "parse_completion" parameter.
12357 (resolve_subexp): Likewise.
12358 (ada_resolve_function): Likewise.
12359
12360 2019-04-04 Tom Tromey <tom@tromey.com>
12361
12362 * parser-defs.h (struct parser_state) <start_arglist,
12363 end_arglist>: New methods.
12364 <arglist_len, m_funcall_chain>: New members.
12365 (arglist_len, start_arglist, end_arglist): Don't declare.
12366 * parse.c (arglist_len, funcall_chain): Remove global.
12367 (start_arglist, end_arglist): Remove functions.
12368 (parse_exp_in_context): Update.
12369 * p-exp.y: Update rules.
12370 * m2-exp.y: Update rules.
12371 * go-exp.y: Update rules.
12372 * f-exp.y: Update rules.
12373 * d-exp.y: Update rules.
12374 * c-exp.y: Update rules.
12375
12376 2019-04-04 Tom Tromey <tom@tromey.com>
12377
12378 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12379 lex_operator, push_back>: New methods.
12380 Update all rules.
12381 (rust_parser::lex_hex, lex_escape): Rename and update.
12382 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12383 (rust_parser::lex_operator): Rename and update.
12384 (rust_parser::lex_number, rustyylex, rustyyerror)
12385 (rust_lex_test_init, rust_lex_test_sequence)
12386 (rust_lex_test_push_back, rust_lex_tests): Update.
12387 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12388 parameter.
12389 <lexptr, prev_lexptr>: New members.
12390 (lexptr, prev_lexptr): Don't declare.
12391 * parse.c (lexptr, prev_lexptr): Remove globals.
12392 (parse_exp_in_context): Update.
12393 * p-exp.y (yylex, yyerror): Update.
12394 * m2-exp.y (parse_number, yylex, yyerror): Update.
12395 * go-exp.y (lex_one_token, yyerror): Update.
12396 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12397 * d-exp.y (lex_one_token, yyerror): Update.
12398 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12399 (lex_one_token, yyerror): Update.
12400 * ada-lex.l (YY_INPUT): Update.
12401 (rewind_to_char): Update.
12402 * ada-exp.y (yyerror): Update.
12403
12404 2019-04-04 Tom Tromey <tom@tromey.com>
12405
12406 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12407 * parser-defs.h (struct parser_state) <parser_state>: Add new
12408 parameter.
12409 <comma_terminates>: New member.
12410 (comma_terminates): Don't declare global.
12411 * parse.c (comma_terminates): Remove global.
12412 (parse_exp_in_context): Update.
12413 * p-exp.y (yylex): Update.
12414 * m2-exp.y (yylex): Update.
12415 * go-exp.y (lex_one_token): Update.
12416 * f-exp.y (yylex): Update.
12417 * d-exp.y (lex_one_token): Update.
12418 * c-exp.y (lex_one_token): Update.
12419 * ada-lex.l: Update.
12420
12421 2019-04-04 Tom Tromey <tom@tromey.com>
12422
12423 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12424 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12425 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12426 * parser-defs.h (paren_depth): Don't declare.
12427 * parse.c (paren_depth): Remove global.
12428 (parse_exp_in_context): Update.
12429 * p-exp.y (paren_depth): New global.
12430 (pascal_parse): Initialize it.
12431 * m2-exp.y (paren_depth): New global.
12432 (m2_parse): Initialize it.
12433 * go-exp.y (paren_depth): New global.
12434 (go_parse): Initialize it.
12435 * f-exp.y (paren_depth): New global.
12436 (f_parse): Initialize it.
12437 * d-exp.y (paren_depth): New global.
12438 (d_parse): Initialize it.
12439 * c-exp.y (paren_depth): New global.
12440 (c_parse): Initialize it.
12441 * ada-lex.l (paren_depth): New global.
12442 (lexer_init): Initialize it.
12443
12444 2019-04-04 Tom Tromey <tom@tromey.com>
12445
12446 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12447 (rust_parser::convert_ast_to_type)
12448 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12449 * parser-defs.h (struct parser_state) <parser_state>: Add
12450 parameters. Initialize new members.
12451 <expression_context_block, expression_context_pc>: New members.
12452 * parse.c (expression_context_block, expression_context_pc):
12453 Remove globals.
12454 (parse_exp_in_context): Update.
12455 * p-exp.y: Update all rules.
12456 (yylex): Update.
12457 * m2-exp.y: Update all rules.
12458 (yylex): Update.
12459 * go-exp.y (yylex): Update.
12460 * f-exp.y (yylex): Update.
12461 * d-exp.y: Update all rules.
12462 (yylex): Update.
12463 * c-exp.y: Update all rules.
12464 (lex_one_token, classify_name, yylex, c_parse): Update.
12465 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12466
12467 2019-04-04 Tom Tromey <tom@tromey.com>
12468
12469 * gdbarch.h, gdbarch.c: Rebuild.
12470 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12471 * stap-probe.h:
12472 (struct stap_parse_info): Replace "parser_state" with
12473 "expr_builder".
12474 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12475 (parser_state): New class.
12476 * parse.c (expr_builder): Rename.
12477 (expr_builder::release): Rename.
12478 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12479 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12480 (write_exp_elt_longcst, write_exp_elt_floatcst)
12481 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12482 (write_exp_string_vector, write_exp_bitstring)
12483 (write_exp_msymbol, mark_struct_expression)
12484 (write_dollar_variable)
12485 (insert_type_address_space, increase_expout_size): Replace
12486 "parser_state" with "expr_builder".
12487 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12488 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12489 "parser_state" with "expr_builder".
12490
12491 2019-04-04 Tom Tromey <tom@tromey.com>
12492
12493 * rust-exp.y: Replace "parse_language" with method call.
12494 * p-exp.y:
12495 (yylex): Replace "parse_language" with method call.
12496 * m2-exp.y:
12497 (yylex): Replace "parse_language" with method call.
12498 * go-exp.y (classify_name): Replace "parse_language" with method
12499 call.
12500 * f-exp.y (yylex): Replace "parse_language" with method call.
12501 * d-exp.y (lex_one_token): Replace "parse_language" with method
12502 call.
12503 * c-exp.y:
12504 (lex_one_token, classify_name, yylex): Replace "parse_language"
12505 with method call.
12506 * ada-exp.y (find_primitive_type, type_char)
12507 (type_system_address): Replace "parse_language" with method call.
12508
12509 2019-04-04 Tom Tromey <tom@tromey.com>
12510
12511 * rust-exp.y: Replace "parse_gdbarch" with method call.
12512 * parse.c (write_dollar_variable, insert_type_address_space):
12513 Replace "parse_gdbarch" with method call.
12514 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12515 call.
12516 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12517 call.
12518 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12519 "parse_gdbarch" with method call.
12520 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12521 with method call.
12522 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12523 "parse_gdbarch" with method call.
12524 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12525 "parse_gdbarch" with method call.
12526 * c-exp.y (parse_type, parse_number, classify_name): Replace
12527 "parse_gdbarch" with method call.
12528 * ada-lex.l: Replace "parse_gdbarch" with method call.
12529 * ada-exp.y (parse_type, find_primitive_type, type_char)
12530 (type_system_address): Replace "parse_gdbarch" with method call.
12531
12532 2019-04-04 Tom Tromey <tom@tromey.com>
12533
12534 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12535 * stap-probe.c (stap_parse_argument): Update.
12536 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12537 initial_size parameter.
12538 * rust-exp.y (rust_lex_tests): Update.
12539 * parse.c (parser_state): Update.
12540 (parse_exp_in_context): Update.
12541 * parser-defs.h (struct parser_state) <parser_state>: Remove
12542 "initial_size" parameter.
12543
12544 2019-04-04 Tom Tromey <tom@tromey.com>
12545
12546 * parser-defs.h (increase_expout_size): Don't declare.
12547 * parse.c (increase_expout_size): Now static.
12548
12549 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12550
12551 * gnu-nat.c (gnu_nat_target::wait): Fix
12552 target_waitstatus_to_string call.
12553
12554 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12555
12556 * eval.c (evaluate_subexp_standard): Handle internal functions
12557 during Fortran function call handling.
12558
12559 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12560
12561 * NEWS: Mention new internal functions.
12562 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12563 (read_base_type): Use dwarf2_init_complex_target_type.
12564 * value.c (creal_internal_fn): New function.
12565 (cimag_internal_fn): New function.
12566 (_initialize_values): Register new internal functions.
12567
12568 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12569
12570 * infrun.c (stop_all_threads): If debug_infrun, always
12571 trace the wait status after wait_one, using
12572 target_waitstatus_to_string and target_pid_to_str.
12573 (handle_inferior_event): Replace various trace of
12574 wait status kind by a single trace.
12575 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12576 wait status kind image by target_waitstatus_to_string.
12577 * target/waitstatus.c (target_waitstatus_to_string): Fix
12578 obsolete comment.
12579
12580 2019-04-01 Tom Tromey <tromey@adacore.com>
12581
12582 PR symtab/23331:
12583 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12584
12585 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12586 Pedro Alves <palves@redhat.com>
12587
12588 * top.c (quit_force): Call 'finalize_values'.
12589 * value.c (finalize_values): New function.
12590 * value.h (finalize_values): Declare.
12591
12592 2019-03-30 Eli Zaretskii <eliz@gnu.org>
12593
12594 * NEWS: Announce $_gdb_major and $_gdb_minor.
12595
12596 * top.c (init_gdb_version_vars): New function.
12597 (gdb_init): Call init_gdb_version_vars.
12598
12599 2019-03-29 Tom Tromey <tromey@adacore.com>
12600
12601 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12602 help text. Remove dead code.
12603
12604 2019-03-29 Keith Seitz <keiths@redhat.com>
12605
12606 From Siddhesh Poyarekar:
12607 * f-lang.h (f77_get_upperbound): Return LONGEST.
12608 (f77_get_lowerbound): Likewise.
12609 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12610 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12611 print them.
12612 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12613 plongest to format print it.
12614 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12615 (f77_get_upperbound): Likewise.
12616 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12617 LOWER_BOUND to LONGEST.
12618 (f77_create_arrayprint_offset_tbl): Likewise.
12619
12620 2019-03-29 Keith Seitz <keiths@redhat.com>
12621
12622 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12623 %s/pulongest for TYPE_LENGTH instead of %d in format
12624 strings.
12625 * ada-typerint.c (ada_print_type): Likewise.
12626 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12627 * compile/compile-c-support.c (generate_register_struct): Likewise.
12628 * gdbtypes.c (recursive_dump_type): Likewise.
12629 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12630 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12631 instead of %d in format strings.
12632 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12633 to std::min to ULONGEST.
12634 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12635 instead of %d in format strings.
12636 * tracepoint.c (info_scope_command): Likewise.
12637 * typeprint.c (print_offset_data::update)
12638 (print_offset_data::finish): Likewise.
12639 * xtensa-tdep.c (xtensa_store_return_value)
12640 (xtensa_push_dummy_call): Likewise.
12641
12642 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12643
12644 * windows-nat.c (display_selector): Fixed format specifications
12645 for 64-bit Cygwin.
12646
12647 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12648
12649 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12650
12651 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12652
12653 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12654 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12655 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12656 (nios2_linux_init_abi): Install it.
12657
12658 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12659
12660 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12661
12662 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12663
12664 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12665
12666 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12667 Tom Tromey <tromey@adacore.com>
12668
12669 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12670
12671 2019-03-26 Joel Brobecker <brobecker@adacore.com>
12672
12673 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12674 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12675 method to compute the bounds of range types. Also print "[evaluated]"
12676 if the bounds' values come from a dynamic evaluation.
12677
12678 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12679
12680 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12681 whitespace when pretty printing is on.
12682
12683 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12684
12685 * ppc-linux-nat.c: Add include.
12686
12687 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12688
12689 * NEWS: Mention AArch64 Pointer Authentication.
12690
12691 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12692
12693 * arm-linux-nat.c: Add include.
12694
12695 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12696
12697 * source-cache.c (source_cache::get_source_lines): Re-read
12698 fullname after calling open_source_file.
12699
12700 2019-03-25 John Baldwin <jhb@FreeBSD.org>
12701
12702 * NEWS: Mention TLS support for FreeBSD.
12703
12704 2019-03-25 Tom Tromey <tromey@adacore.com>
12705
12706 * minsyms.c (BUNCH_SIZE): Update comment.
12707 (~minimal_symbol_reader): Remove old comment.
12708 (compact_minimal_symbols): Update comment.
12709 (minimal_symbol_reader::install): Remove old comment. Update
12710 other comments.
12711
12712 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12713
12714 * s390-linux-nat.c: Add include.
12715
12716 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12717
12718 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12719 Call linux_get_hwcap.
12720 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12721 Likewise.
12722 (aarch64_linux_get_hwcap): Remove function.
12723 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12724 declaration.
12725 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12726 linux_get_hwcap.
12727 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12728 * linux-tdep.c (linux_get_hwcap): Add function.
12729 (linux_get_hwcap2): Likewise.
12730 * linux-tdep.h (linux_get_hwcap): Add declaration.
12731 (linux_get_hwcap2): Likewise.
12732 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12733 (ppc_linux_get_hwcap2): Likewise.
12734 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12735 linux_get_hwcap.
12736 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12737 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12738 (ppc_linux_nat_target::read_description): Likewise.
12739 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12740 * s390-linux-nat.c: Likewise.
12741 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12742
12743 2019-03-24 Tom Tromey <tom@tromey.com>
12744
12745 * ada-lang.c (standard_lookup): Simplify initialization.
12746 (ada_lookup_symbol_nonlocal): Simplify return.
12747 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12748 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12749 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12750 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12751 initialization.
12752 * solib.c (solib_global_lookup): Simplify.
12753 * symtab.c (null_block_symbol): Remove.
12754 (symbol_cache_lookup): Simplify returns.
12755 (lookup_language_this): Simplify returns.
12756 (lookup_symbol_aux): Simplify return.
12757 (lookup_local_symbol): Simplify returns.
12758 (lookup_global_symbol_from_objfile): Simplify return.
12759 (lookup_symbol_in_objfile_symtabs)
12760 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12761 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12762 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12763 * cp-namespace.c (cp_lookup_bare_symbol)
12764 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12765 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12766 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12767 (cp_lookup_symbol_via_imports): Simplify initialization.
12768 (find_symbol_in_baseclass): Likewise.
12769 * symtab.h (null_block_symbol): Remove.
12770 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12771 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12772 (d_lookup_symbol_module): Likewise.
12773 (find_symbol_in_baseclass): Simplify initialization.
12774
12775 2019-03-24 Tom Tromey <tom@tromey.com>
12776
12777 * expression.h: Don't include symtab.h.
12778 (struct block): Forward declare.
12779
12780 2019-03-24 Tom Tromey <tom@tromey.com>
12781
12782 * c-exp.y (typebase): Remove casts.
12783 * gdbtypes.c (lookup_unsigned_typename, )
12784 (lookup_signed_typename): Remove cast.
12785 * eval.c (parse_to_comma_and_eval): Remove cast.
12786 * parse.c (write_dollar_variable): Remove cast.
12787 * block.h (struct block) <superblock>: Now const.
12788 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12789 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12790 (map_block): Make "block" const.
12791 * symfile.h (struct quick_symbol_functions)
12792 <map_matching_symbols>: Constify block argument to "callback".
12793 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12794 const.
12795 (find_pc_sect_compunit_symtab): Make "b" const.
12796 (find_symbol_at_address): Likewise.
12797 (search_symbols): Likewise.
12798 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12799 (dw2_debug_names_lookup_symbol): Likewise.
12800 (dw2_map_matching_symbols): Update.
12801 * p-valprint.c (pascal_val_print): Remove "block".
12802 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12803 (aux_add_nonlocal_symbols): Make "block" const.
12804 (resolve_subexp): Remove cast.
12805 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12806 const.
12807 (iterate_over_file_blocks): Likewise.
12808 * f-exp.y (%union) <bval>: Remove.
12809 * coffread.c (patch_opaque_types): Make "b" const.
12810 * spu-tdep.c (spu_catch_start): Make "block" const.
12811 * c-valprint.c (print_unpacked_pointer): Remove "block".
12812 * symmisc.c (dump_symtab_1): Make "b" const.
12813 (block_depth): Make "block" const.
12814 * d-exp.y (%union) <bval>: Remove.
12815 * cp-support.h (cp_lookup_rtti_type): Update.
12816 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12817 * psymtab.c (psym_lookup_symbol): Make "block" const.
12818 (maintenance_check_psymtabs): Make "b" const.
12819 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12820 (enumerate_locals, enumerate_args): Update.
12821 * python/py-symtab.c (stpy_global_block): Make "block" const.
12822 (stpy_static_block): Likewise.
12823 * inline-frame.c (block_starting_point_at): Make "new_block"
12824 const.
12825 * block.c (find_block_in_blockvector): Make return type const.
12826 (blockvector_for_pc_sect): Make "b" const.
12827 (find_block_in_blockvector): Make "b" const.
12828
12829 2019-03-23 Tom Tromey <tom@tromey.com>
12830
12831 * varobj.c (varobj_create): Update.
12832 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12833 * printcmd.c (display_command, do_one_display): Don't reset
12834 innermost_block.
12835 * parser-defs.h (enum innermost_block_tracker_type): Move to
12836 expression.h.
12837 (innermost_block): Update comment.
12838 * parse.c (parse_exp_1): Add tracker_types parameter.
12839 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12840 tracker_types parameter. Reset innermost_block.
12841 (parse_exp_in_context): Remove.
12842 (parse_expression_for_completion): Update.
12843 * objfiles.c (~objfile): Don't reset expression_context_block or
12844 innermost_block.
12845 * expression.h (enum innermost_block_tracker_type): Move from
12846 parser-defs.h.
12847 (parse_exp_1): Add tracker_types parameter.
12848 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12849 reset innermost_block.
12850
12851 2019-03-23 Tom Tromey <tom@tromey.com>
12852
12853 * objfiles.h: Include bcache.h.
12854
12855 2019-03-23 Tom Tromey <tom@tromey.com>
12856
12857 * linespec.c (get_current_search_block): Use
12858 scoped_restore_current_language.
12859 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12860
12861 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12862 Jiong Wang <jiong.wang@arm.com>
12863
12864 * aarch64-linux-tdep.c
12865 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12866 section.
12867 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12868
12869 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12870 Jiong Wang <jiong.wang@arm.com>
12871
12872 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12873 instructions.
12874 (aarch64_analyze_prologue_test): Add PACIASP test.
12875 (aarch64_prologue_prev_register): Unmask PC value.
12876
12877 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12878 Jiong Wang <jiong.wang@arm.com>
12879
12880 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12881 (aarch64_dwarf2_prev_register): Unmask PC value.
12882 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12883 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12884 DW_CFA_AARCH64_negate_ra_state.
12885 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12886
12887 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12888 Jiong Wang <jiong.wang@arm.com>
12889
12890 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12891 registers.
12892 (aarch64_pseudo_register_name): Likewise.
12893 (aarch64_pseudo_register_type): Likewise.
12894 (aarch64_pseudo_register_reggroup_p): Likewise.
12895 (aarch64_gdbarch_init): Add pauth registers.
12896 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12897 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12898 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12899 (struct gdbarch_tdep): Add regnum for ra_state.
12900
12901 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12902 Jiong Wang <jiong.wang@arm.com>
12903
12904 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12905
12906 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12907 Jiong Wang <jiong.wang@arm.com>
12908
12909 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12910 function.
12911 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12912 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12913 (aarch64_gdbarch_init): Add puth registers.
12914 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12915 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12916 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12917
12918 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12919 Jiong Wang <jiong.wang@arm.com>
12920
12921 * aarch64-linux-nat.c
12922 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12923 * aarch64-linux-tdep.c
12924 (aarch64_linux_core_read_description): Likewise.
12925 (aarch64_linux_get_hwcap): New function.
12926 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12927 (aarch64_linux_get_hwcap): New declaration.
12928
12929 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12930 Jiong Wang <jiong.wang@arm.com>
12931
12932 * aarch64-linux-nat.c
12933 (aarch64_linux_nat_target::read_description): Add pauth param.
12934 * aarch64-linux-tdep.c
12935 (aarch64_linux_core_read_description): Likewise.
12936 * aarch64-tdep.c (struct target_desc): Add in pauth.
12937 (aarch64_read_description): Add pauth param.
12938 (aarch64_gdbarch_init): Likewise.
12939 * aarch64-tdep.h (aarch64_read_description): Likewise.
12940 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12941 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12942 * features/Makefile: Add new files.
12943 * features/aarch64-pauth.c: New file.
12944 * features/aarch64-pauth.xml: New file.
12945
12946 2019-03-20 Tom Tromey <tromey@adacore.com>
12947
12948 * infrun.c (handle_inferior_event): Rename from
12949 handle_inferior_event_1. Create a scoped_value_mark.
12950 (handle_inferior_event): Remove.
12951
12952 2019-03-19 Tom Tromey <tromey@adacore.com>
12953
12954 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12955 * infrun.h (print_stop_event): Add "displays" parameter.
12956 * infrun.c (print_stop_event): Add "displays" parameter.
12957
12958 2019-03-19 Pedro Alves <palves@redhat.com>
12959
12960 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12961 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12962 to -1. Fix TABs vs spaces.
12963 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12964 * tui/tui-out.h (tui_ui_out) Add intro comments.
12965 <m_line, m_start_of_line>: In-class initialize, and add describing
12966 comment.
12967
12968 2019-03-18 Alan Hayward <alan.hayward@arm.com>
12969
12970 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12971 variable names.
12972 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12973
12974 2019-03-18 Pedro Alves <palves@redhat.com>
12975 Eli Zaretskii <eliz@gnu.org>
12976
12977 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12978 m_line and m_start_of_line.
12979
12980 2019-03-18 Eli Zaretskii <eliz@gnu.org>
12981
12982 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12983 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12984 it returns a newline. This fixes a regression in TU mode, whereby
12985 the next line is output on the same screen line as the user input.
12986
12987 2019-03-18 Tom Tromey <tromey@adacore.com>
12988
12989 * minsyms.c (minimal_symbol_reader::install): Remove call to
12990 obstack_blank.
12991
12992 2019-03-18 Pedro Alves <palves@redhat.com>
12993
12994 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12995 New globals.
12996 (apply_style): New, factored out from ...
12997 (apply_ansi_escape): ... this. Handle reverse video mode.
12998 (tui_set_reverse_mode): New function.
12999 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13000 * tui/tui-winsource.c (tui_show_source_line): Use
13001 tui_set_reverse_mode instead of setting A_STANDOUT.
13002 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13003 New setter methods.
13004
13005 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
13006
13007 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13008 Handle tabs.
13009
13010 2019-03-18 Tom Tromey <tromey@adacore.com>
13011
13012 * ada-lang.c (empty_array): Add "high" parameter.
13013 (ada_evaluate_subexp): Update.
13014
13015 2019-03-17 Sergei Trofimovich <siarheit@google.com>
13016
13017 * unittests/string_view-selftests.c: Define
13018 _initialize_string_view_selftests unconditionally.
13019
13020 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13021
13022 PR gdb/24350
13023 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13024
13025 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13026
13027 PR gdb/24351
13028 * windows-nat.c (display_selector): Fix format specifiers.
13029
13030 2019-03-17 Eli Zaretskii <eliz@gnu.org>
13031
13032 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13033 tui_refill_source_window instead of tui_refresh_win, to update the
13034 current execution line. This fixes redisplay of the current line
13035 when stepping through the code with "next" or "step".
13036
13037 2019-03-16 Eli Zaretskii <eliz@gnu.org>
13038
13039 * source-cache.c (source_cache::get_source_lines): Call
13040 find_source_lines to initialize s->nlines. This fixes vertical
13041 scrolling of TUI source window when the DOWN arrow is pressed.
13042
13043 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13044
13045 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13046 linux-thread-db.c (_initialize_thread_db): Likewise.
13047
13048 2019-03-16 Eli Zaretskii <eliz@gnu.org>
13049
13050 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13051 wclrtoeol in tui_show_source_line". This reverts changes made in
13052 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13053
13054 2019-03-15 Tom Tromey <tom@tromey.com>
13055
13056 * symtab.h (struct minimal_symbol): Derive from
13057 general_symbol_info.
13058 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13059 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13060 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13061 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13062 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13063 (MSYMBOL_SEARCH_NAME): Update.
13064 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13065 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13066 * minsyms.c (minimal_symbol_reader::record_full): Update.
13067
13068 2019-03-15 Tom Tromey <tom@tromey.com>
13069
13070 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13071
13072 2019-03-15 Tom Tromey <tom@tromey.com>
13073
13074 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13075 unique_xmalloc_ptr.
13076 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13077 Update.
13078 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13079 (build_minimal_symbol_hash_tables)
13080 (minimal_symbol_reader::install): Update.
13081
13082 2019-03-15 Tom Tromey <tom@tromey.com>
13083
13084 * symtab.c (create_demangled_names_hash): Update.
13085 (symbol_set_names): Update.
13086 * objfiles.h (struct objfile_per_bfd_storage)
13087 <demangled_names_hash>: Now an htab_up.
13088 * objfiles.c (objfile_per_bfd_storage): Simplify.
13089
13090 2019-03-15 Tom Tromey <tom@tromey.com>
13091
13092 * objfiles.h (struct objfile_per_bfd_storage): Declare
13093 destructor.
13094 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13095 New.
13096 (get_objfile_bfd_data): Use new. Don't initialize
13097 language_of_main.
13098 (free_objfile_per_bfd_storage): Remove.
13099 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13100
13101 2019-03-15 Tom Tromey <tom@tromey.com>
13102
13103 * symfile.c (reread_symbols): Update.
13104 * objfiles.c (objfile::objfile): Update.
13105 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13106 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13107 comment.
13108 (minimal_symbol_reader::install): Update.
13109 (terminate_minimal_symbol_table): Remove.
13110 * jit.c (jit_object_close_impl): Update.
13111
13112 2019-03-15 Tom Tromey <tom@tromey.com>
13113
13114 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13115 initializations.
13116
13117 2019-03-15 Tom Tromey <tom@tromey.com>
13118
13119 * objfiles.h (struct objfile_per_bfd_storage)
13120 <demangled_hash_languages>: Now a bitset.
13121 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13122 (lookup_minimal_symbol): Update.
13123
13124 2019-03-15 Tom Tromey <tom@tromey.com>
13125
13126 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13127 Don't return the symbol.
13128 * coffread.c (record_minimal_symbol): Use record_full.
13129
13130 2019-03-14 Eli Zaretskii <eliz@gnu.org>
13131
13132 The MS-Windows port of ncurses fails to switch to a color pair if
13133 one or both of the colors are the implicit default colors. This
13134 change records the default colors when TUI is initialized, and
13135 then specifies them explicitly when a color pair uses the default
13136 colors. This allows color styling in TUI mode on MS-Windows.
13137
13138 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13139 ncurses_norm_attr.
13140 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13141 colors in ncurses_norm_attr.
13142 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13143 "none", replace it with the default color recorded in
13144 ncurses_norm_attr.
13145
13146 2019-03-14 Tom Tromey <tromey@adacore.com>
13147
13148 * source-cache.h (class source_cache) <get_source_lines>: Return
13149 std::string.
13150 * source-cache.c (source_cache::extract_lines): Handle case where
13151 first_pos==npos. Return std::string.
13152 (source_cache::get_source_lines): Update.
13153
13154 2019-03-14 Tom Tromey <tromey@adacore.com>
13155
13156 * NEWS: Add item for "style sources" commands.
13157 * source-cache.c (source_cache::get_source_lines): Check
13158 source_styling.
13159 * cli/cli-style.c (source_styling): New global.
13160 (_initialize_cli_style): Add "style sources" commands.
13161 (show_style_sources): New function.
13162 * cli/cli-style.h (source_styling): Declare.
13163
13164 2019-03-14 Pedro Alves <palves@redhat.com>
13165 Tom Tromey <tromey@adacore.com>
13166
13167 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13168 * tui/tui-winsource.c (tui_refill_source_window): New function,
13169 from...
13170 (tui_horizontal_source_scroll): ... here. Move some logic.
13171 * cli/cli-style.c (set_style_enabled): Notify new observable.
13172 * tui/tui-hooks.c (tui_redisplay_source): New function.
13173 (tui_attach_detach_observers): Attach or detach
13174 tui_redisplay_source.
13175 * observable.h (source_styling_changed): New observable.
13176 * observable.c: Define source_styling_changed observable.
13177
13178 2019-03-13 Tom Tromey <tromey@adacore.com>
13179
13180 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13181 (i386_gnu_nat_target::store_registers): Update.
13182 * target-debug.h (target_debug_print_std_string): New macro.
13183 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13184 * windows-tdep.c (display_one_tib): Update.
13185 * tui/tui-stack.c (tui_make_status_line): Update.
13186 * top.c (print_inferior_quit_action): Update.
13187 * thread.c (thr_try_catch_cmd): Update.
13188 (add_thread_with_info): Update.
13189 (thread_target_id_str): Update.
13190 (thr_try_catch_cmd): Update.
13191 (thread_command): Update.
13192 (thread_find_command): Update.
13193 * record-btrace.c (record_btrace_target::info_record)
13194 (record_btrace_resume_thread, record_btrace_target::resume)
13195 (record_btrace_cancel_resume, record_btrace_step_thread)
13196 (record_btrace_target::wait, record_btrace_target::wait)
13197 (record_btrace_target::wait, record_btrace_target::stop): Update.
13198 * progspace.c (print_program_space): Update.
13199 * process-stratum-target.c
13200 (process_stratum_target::thread_address_space): Update.
13201 * linux-fork.c (linux_fork_mourn_inferior)
13202 (detach_checkpoint_command, info_checkpoints_command)
13203 (linux_fork_context): Update.
13204 (linux_fork_detach): Update.
13205 (class scoped_switch_fork_info): Update.
13206 (delete_checkpoint_command): Update.
13207 * infrun.c (follow_fork_inferior): Update.
13208 (follow_fork_inferior): Update.
13209 (proceed_after_vfork_done): Update.
13210 (handle_vfork_child_exec_or_exit): Update.
13211 (follow_exec): Update.
13212 (displaced_step_prepare_throw): Update.
13213 (displaced_step_restore): Update.
13214 (start_step_over): Update.
13215 (resume_1): Update.
13216 (clear_proceed_status_thread): Update.
13217 (proceed): Update.
13218 (print_target_wait_results): Update.
13219 (do_target_wait): Update.
13220 (context_switch): Update.
13221 (stop_all_threads): Update.
13222 (restart_threads): Update.
13223 (finish_step_over): Update.
13224 (handle_signal_stop): Update.
13225 (switch_back_to_stepped_thread): Update.
13226 (keep_going_pass_signal): Update.
13227 (print_exited_reason): Update.
13228 (normal_stop): Update.
13229 * inferior.c (inferior_pid_to_str): Change return type.
13230 (print_selected_inferior): Update.
13231 (add_inferior): Update.
13232 (detach_inferior): Update.
13233 * dummy-frame.c (fprint_dummy_frames): Update.
13234 * dcache.c (dcache_info_1): Update.
13235 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13236 (btrace_fetch, btrace_clear): Update.
13237 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13238 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13239 type.
13240 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13241 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13242 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13243 * gdbarch.c, gdbarch.h: Rebuild.
13244 * gdbarch.sh (core_pid_to_str): Change return type.
13245 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13246 return type.
13247 (windows_nat_target::pid_to_str): Change return type.
13248 (windows_delete_thread): Update.
13249 (windows_nat_target::attach): Update.
13250 (windows_nat_target::files_info): Update.
13251 * target-delegates.c: Rebuild.
13252 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13253 return type.
13254 (sol_thread_target::pid_to_str): Change return type.
13255 * remote.c (class remote_target) <pid_to_str>: Change return
13256 type.
13257 (remote_target::pid_to_str): Change return type.
13258 (extended_remote_target::attach, remote_target::remote_stop_ns)
13259 (remote_target::remote_notif_remove_queued_reply)
13260 (remote_target::push_stop_reply, remote_target::disable_btrace):
13261 Update.
13262 (extended_remote_target::attach): Update.
13263 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13264 type.
13265 (gdbsim_target::pid_to_str): Change return type.
13266 * ravenscar-thread.c (struct ravenscar_thread_target)
13267 <pid_to_str>: Change return type.
13268 (ravenscar_thread_target::pid_to_str): Change return type.
13269 * procfs.c (class procfs_target) <pid_to_str>: Change return
13270 type.
13271 (procfs_target::pid_to_str): Change return type.
13272 (procfs_target::attach): Update.
13273 (procfs_target::detach): Update.
13274 (procfs_target::fetch_registers): Update.
13275 (procfs_target::store_registers): Update.
13276 (procfs_target::wait): Update.
13277 (procfs_target::files_info): Update.
13278 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13279 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13280 return type.
13281 (nto_procfs_target::pid_to_str): Change return type.
13282 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13283 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13284 return type.
13285 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13286 (exit_lwp): Update.
13287 (attach_proc_task_lwp_callback, get_detach_signal)
13288 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13289 (linux_nat_target::resume, wait_lwp, stop_callback)
13290 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13291 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13292 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13293 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13294 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13295 type.
13296 (inf_ptrace_target::attach): Update.
13297 (inf_ptrace_target::files_info): Update.
13298 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13299 type.
13300 (go32_nat_target::pid_to_str): Change return type.
13301 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13302 (gnu_nat_target::wait): Update.
13303 (gnu_nat_target::wait): Update.
13304 (gnu_nat_target::resume): Update.
13305 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13306 (fbsd_nat_target::wait): Update.
13307 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13308 type.
13309 (darwin_nat_target::attach): Update.
13310 * corelow.c (class core_target) <pid_to_str>: Change return type.
13311 (core_target::pid_to_str): Change return type.
13312 * target.c (normal_pid_to_str): Change return type.
13313 (default_pid_to_str): Likewise.
13314 (target_pid_to_str): Change return type.
13315 (target_translate_tls_address): Update.
13316 (target_announce_detach): Update.
13317 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13318 return type.
13319 (bsd_uthread_target::pid_to_str): Change return type.
13320 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13321 type.
13322 (bsd_kvm_target::pid_to_str): Change return type.
13323 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13324 return type.
13325 (aix_thread_target::pid_to_str): Change return type.
13326 * target.h (struct target_ops) <pid_to_str>: Change return type.
13327 (target_pid_to_str, normal_pid_to_str): Likewise.
13328 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13329 type.
13330 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13331 type.
13332 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13333 return type.
13334 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13335 type.
13336 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13337 type.
13338 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13339 return type.
13340
13341 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13342
13343 * NEWS: Mention that the new default MI version is 3. Mention
13344 changes to the output of commands and events that deal with
13345 multi-location breakpoints.
13346 * breakpoint.c: Include "mi/mi-out.h".
13347 (print_one_breakpoint): Change output syntax if using MI version
13348 >= 3.
13349 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13350 New.
13351 (mi_multi_location_breakpoint_output_fixed): New.
13352 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13353 (mi_cmd_fix_multi_location_breakpoint_output): New.
13354 (mi_multi_location_breakpoint_output_fixed): New.
13355 * mi/mi-cmds.c (mi_cmds): Register command
13356 -fix-multi-location-breakpoint-output.
13357 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13358 interpreter "mi".
13359
13360 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13361
13362 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13363 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13364 instantiate mi_ui_out based on interpreter name.
13365 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13366 * mi/mi-main.c (mi_load_progress): Likewise.
13367
13368 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13369
13370 * NEWS: Combine separate "New targets" sections for 8.3.
13371
13372 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13373
13374 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13375 (ppcfbsd_init_abi): Install gdbarch
13376 "fetch_tls_load_module_address" and "get_thread_local_address"
13377 methods.
13378
13379 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13380
13381 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13382 (riscv_fbsd_init_abi): Install gdbarch
13383 "fetch_tls_load_module_address" and "get_thread_local_address"
13384 methods.
13385
13386 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13387
13388 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13389 (i386fbsd_init_abi): Install gdbarch
13390 "fetch_tls_load_module_address" and "get_thread_local_address"
13391 methods.
13392
13393 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13394
13395 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13396 (amd64fbsd_init_abi): Install gdbarch
13397 "fetch_tls_load_module_address" and "get_thread_local_address"
13398 methods.
13399
13400 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13401
13402 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13403 (struct fbsd_pspace_data): New type.
13404 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13405 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13406 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13407 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13408 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13409
13410 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13411
13412 * gdbtypes.c (lookup_struct_elt): New function.
13413 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13414 * gdbtypes.h (struct struct_elt): New type.
13415 (lookup_struct_elt): New prototype.
13416
13417 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13418
13419 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13420 remove disabled code block.
13421
13422 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13423
13424 * gdbarch.sh (get_thread_local_address): New method.
13425 * gdbarch.h, gdbarch.c: Regenerate.
13426 * target.c (target_translate_tls_address): Use
13427 gdbarch_get_thread_local_address if present instead of
13428 target::get_thread_local_address.
13429
13430 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13431
13432 * target.h (target::get_thread_local_address): Update comment.
13433
13434 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13435
13436 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13437 objfile->separate_debug_objfile_backlink if not NULL.
13438
13439 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13440
13441 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13442 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13443 (amd64bsd_store_inferior_registers): Likewise.
13444 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13445 Enable segment base registers.
13446 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13447 PT_GETFSBASE and PT_GETGSBASE.
13448 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13449 PT_SETGSBASE.
13450 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13451 segment base registers.
13452 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13453
13454 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13455
13456 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13457 Update calls to i386_target_description to add 'segments'
13458 parameter.
13459 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13460 add segment base registers.
13461 * arch/i386.c (i386_create_target_description): Add 'segments'
13462 parameter to enable segment base registers.
13463 * arch/i386.h (i386_create_target_description): Likewise.
13464 * features/i386/32bit-segments.xml: New file.
13465 * features/i386/32bit-segments.c: Generate.
13466 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13467 call to i386_target_description to add 'segments' parameter.
13468 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13469 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13470 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13471 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13472 if feature is present.
13473 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13474 Add 'segments' parameter to call to i386_target_description.
13475 (i386_target_description): Add 'segments' parameter to enable
13476 segment base registers.
13477 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13478 to call to i386_target_description.
13479 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13480 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13481 Define I386_NUM_REGS.
13482 (i386_target_description): Add 'segments' parameter to enable
13483 segment base registers.
13484
13485 2019-03-12 Eli Zaretskii <eliz@gnu.org>
13486
13487 PR/24325
13488 * source-cache.c: #undef open and close, to avoid unresolved
13489 externals during linking.
13490
13491 2019-03-12 Tom Tromey <tromey@adacore.com>
13492
13493 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13494 const. Add initializers.
13495 (_initialize_remote): Don't initialize ptid globals.
13496
13497 2019-03-12 Pedro Alves <palves@redhat.com>
13498
13499 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13500
13501 2019-03-12 Pedro Alves <palves@redhat.com>
13502
13503 * cp-name-parser.y (main): Remove unused 'len' variable.
13504
13505 2019-03-12 Tom Tromey <tromey@adacore.com>
13506
13507 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13508 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13509
13510 2019-03-12 Tom Tromey <tromey@adacore.com>
13511
13512 * linux-nat.c (iterate_over_lwps): Update.
13513 (stop_callback): Remove parameter.
13514 (stop_wait_callback, detach_callback, resume_set_callback)
13515 (select_singlestep_lwp_callback, set_ignore_sigint)
13516 (status_callback, resumed_callback, resume_clear_callback)
13517 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13518 data parameter.
13519 (linux_nat_target::detach, linux_nat_target::resume)
13520 (linux_stop_and_wait_all_lwps, select_event_lwp)
13521 (linux_nat_filter_event, linux_nat_wait_1)
13522 (linux_nat_target::kill, linux_nat_target::stop)
13523 (linux_nat_target::stop): Update.
13524 (linux_nat_resume_callback): Change type.
13525 (resume_stopped_resumed_lwps, count_events_callback)
13526 (select_event_lwp_callback): Likewise.
13527 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13528 * arm-linux-nat.c (struct update_registers_data): Remove.
13529 (update_registers_callback): Change type.
13530 (arm_linux_insert_hw_breakpoint1): Update.
13531 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13532 parameter.
13533 (x86_linux_dr_set_addr): Update.
13534 (x86_linux_dr_set_control): Update.
13535 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13536 (iterate_over_lwps): Use gdb::function_view.
13537 * nat/aarch64-linux-hw-point.c (struct
13538 aarch64_dr_update_callback_param): Remove.
13539 (debug_reg_change_callback): Change type.
13540 (aarch64_notify_debug_reg_change): Update.
13541 * s390-linux-nat.c (s390_refresh_per_info): Update.
13542
13543 2019-03-11 Tom Tromey <tromey@adacore.com>
13544
13545 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13546 redundant assignment to "this_cu".
13547
13548 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13549
13550 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13551
13552 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13553
13554 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13555 from...
13556 (rank_one_type): ... this.
13557
13558 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13559
13560 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13561 from...
13562 (rank_one_type): ... this.
13563
13564 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13565
13566 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13567 from...
13568 (rank_one_type): ... this.
13569
13570 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13571
13572 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13573 from...
13574 (rank_one_type): ... this.
13575
13576 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13577
13578 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13579 from...
13580 (rank_one_type): ... this.
13581
13582 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13583
13584 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13585 from...
13586 (rank_one_type): ... this.
13587
13588 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13589
13590 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13591 from...
13592 (rank_one_type): ... this.
13593
13594 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13595
13596 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13597 from...
13598 (rank_one_type): ... this.
13599
13600 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13601
13602 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13603 from...
13604 (rank_one_type): ... this.
13605
13606 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13607
13608 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13609 from...
13610 (rank_one_type): ... this.
13611
13612 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13613
13614 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13615 from...
13616 (rank_one_type): ... this.
13617
13618 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13619
13620 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13621 from...
13622 (rank_one_type): ... this.
13623
13624 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13625
13626 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13627 inferior-events' shows the example events.
13628
13629 2019-03-08 Eli Zaretskii <eliz@gnu.org>
13630
13631 Support styling on native MS-Windows console
13632
13633 PR/24315
13634 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13635 on MS-Windows if $TERM is not defined.
13636
13637 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13638
13639 * posix-hdep.c (gdb_console_fputs):
13640 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13641 functions.
13642 * ui-file.h (gdb_console_fputs): Add prototype.
13643
13644 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13645 back to fputs only if the former returns zero.
13646
13647 2019-03-07 Tom Tromey <tom@tromey.com>
13648
13649 * symmisc.c (print_symbol_bcache_statistics): Update.
13650 (print_objfile_statistics): Update.
13651 * symfile.c (allocate_symtab): Update.
13652 * stabsread.c: Don't include bcache.h.
13653 * psymtab.h (struct psymbol_bcache): Don't declare.
13654 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13655 (psymbol_bcache_init, psymbol_bcache_free)
13656 (psymbol_bcache_get_bcache): Don't declare.
13657 * psymtab.c (struct psymbol_bcache): Remove.
13658 (psymtab_storage::psymtab_storage): Update.
13659 (psymtab_storage::~psymtab_storage): Update.
13660 (psymbol_bcache_init, psymbol_bcache_free)
13661 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13662 (add_psymbol_to_bcache): Update.
13663 (allocate_psymtab): Update.
13664 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13665 macro_cache>: No longer pointers.
13666 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13667 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13668 * macrotab.c (macro_bcache): Update.
13669 * macroexp.c: Don't include bcache.h.
13670 * gdbtypes.c (check_types_worklist): Update.
13671 (types_deeply_equal): Remove TRY/CATCH. Update.
13672 * elfread.c (elf_symtab_read): Update.
13673 * dwarf2read.c: Don't include bcache.h.
13674 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13675 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13676 (print_bcache_statistics, bcache_memory_used): Don't declare.
13677 (struct bcache): Move from bcache.c. Add constructor, destructor,
13678 methods. Rename all data members.
13679 * bcache.c (struct bcache): Move to bcache.h.
13680 (bcache::expand_hash_table): Rename from expand_hash_table.
13681 (bcache): Remove.
13682 (bcache::insert): Rename from bcache_full.
13683 (bcache::compare): Rename from bcache_compare.
13684 (bcache_xmalloc): Remove.
13685 (bcache::~bcache): Rename from bcache_xfree.
13686 (bcache::print_statistics): Rename from print_bcache_statistics.
13687 (bcache::memory_used): Rename from bcache_memory_used.
13688
13689 2019-03-07 Pedro Alves <palves@redhat.com>
13690
13691 * infrun.c (normal_stop): Also check for
13692 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13693
13694 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13695
13696 * f-lang.c (value_from_host_double): Moved to...
13697 * value.c (value_from_host_double): ...here.
13698 * value.h (value_from_host_double): Declare.
13699 * guile/scm-math.c (vlscm_convert_typed_number): Use
13700 value_from_host_double.
13701 (vlscm_convert_number): Likewise.
13702 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13703 * python/py-value.c (convert_value_from_python): Likewise.
13704
13705 2019-03-06 Tom Tromey <tom@tromey.com>
13706
13707 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13708
13709 2019-03-06 Tom Tromey <tom@tromey.com>
13710
13711 * utils.h (free_current_contents): Don't declare.
13712 * utils.c (free_current_contents): Remove.
13713
13714 2019-03-06 Tom Tromey <tom@tromey.com>
13715
13716 * top.c (quit_force): Update.
13717 * main.c (captured_command_loop): Update.
13718 * common/new-op.c (operator new): Update.
13719 * common/common-exceptions.c (struct catcher)
13720 <save_cleanup_chain>: Remove member.
13721 (exceptions_state_mc_init): Update.
13722 (exception_try_scope_entry): Return nullptr.
13723 (exception_try_scope_exit, exception_rethrow)
13724 (throw_exception_sjlj, throw_exception_cxx): Update.
13725 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13726 (all_cleanups, do_cleanups, discard_cleanups)
13727 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13728 (restore_cleanups, restore_final_cleanups): Don't declare.
13729 (do_final_cleanups): Remove parameter.
13730 * common/cleanups.c (cleanup_chain, make_cleanup)
13731 (make_cleanup_dtor, all_cleanups, do_cleanups)
13732 (discard_my_cleanups, discard_cleanups)
13733 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13734 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13735 (null_cleanup): Remove.
13736 (do_final_cleanups): Remove parameter.
13737
13738 2019-03-06 Tom Tromey <tom@tromey.com>
13739
13740 * remote.c (remote_target::remote_parse_stop_reply): Use
13741 unique_xmalloc_ptr.
13742
13743 2019-03-06 Tom Tromey <tom@tromey.com>
13744
13745 * stabsread.c (struct stabs_field_info): Rename from field_info.
13746 <list, fnlist>: Add initializers.
13747 <obstack>: New member.
13748 (read_member_functions, read_struct_fields, read_baseclasses):
13749 Allocate on obstack. Don't use cleanups.
13750 (read_one_struct_field, read_member_functions, read_struct_fields)
13751 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13752 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13753 (read_struct_type): Update.
13754
13755 2019-03-06 Tom Tromey <tom@tromey.com>
13756
13757 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13758 * common/filestuff.h (make_cleanup_close): Don't declare.
13759 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13760 Remove.
13761
13762 2019-03-06 Tom Tromey <tom@tromey.com>
13763
13764 * solib-aix.c: Use make_scope_exit.
13765
13766 2019-03-06 Tom Tromey <tom@tromey.com>
13767
13768 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13769 Use make_scope_exit.
13770
13771 2019-03-06 Tom Tromey <tom@tromey.com>
13772
13773 * solib-svr4.c (disable_probes_interface): Remove parameter.
13774 (svr4_handle_solib_event): Use make_scope_exit.
13775
13776 2019-03-06 Tom Tromey <tom@tromey.com>
13777
13778 * remote.c (struct stop_reply_deleter): Remove.
13779 (stop_reply_up): Update.
13780 (struct stop_reply): Derive from notif_event. Don't typedef.
13781 <regcache>: Now a std::vector.
13782 (stop_reply_xfree): Remove.
13783 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13784 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13785 (remote_target::discard_pending_stop_replies): Use delete.
13786 (remote_target::remote_parse_stop_reply): Update.
13787 (remote_target::process_stop_reply): Update.
13788 * remote-notif.h (struct notif_event): Add virtual destructor.
13789 Remove "dtr" member.
13790 (struct notif_client) <alloc_event>: Return a unique_ptr.
13791 (notif_event_xfree): Don't declare.
13792 (notif_event_up): New typedef.
13793 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13794 (notif_event_xfree, do_notif_event_xfree): Remove.
13795 (remote_notif_state_xfree): Update.
13796
13797 2019-03-06 Tom Tromey <tom@tromey.com>
13798
13799 * infrun.c (displaced_step_clear_cleanup): Now a
13800 forward_scope_exit type.
13801 (displaced_step_prepare_throw): Update.
13802 (displaced_step_fixup): Update.
13803
13804 2019-03-06 Tom Tromey <tom@tromey.com>
13805
13806 * inferior.h (class inferior): Update comment.
13807 * gdbthread.h (class thread_info): Update comment.
13808
13809 2019-03-06 Joel Brobecker <brobecker@adacore.com>
13810 Tom Tromey <tom@tromey.com>
13811
13812 * stabsread.h (struct stab_section_list): Remove.
13813 (coffstab_build_psymtabs): Update.
13814 * dbxread.c (symbuf_sections): Now a std::vector.
13815 (sect_idx): New global.
13816 (fill_symbuf): Update.
13817 (coffstab_build_psymtabs): Change type of stabsects parameter.
13818 Update.
13819 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13820 std::vector.
13821 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13822 (coff_locate_sections): Update.
13823 (coff_symfile_read): Remove cleanups. Update.
13824 (init_stringtab): Add storage parameter.
13825 (free_stringtab, free_stringtab_cleanup): Remove.
13826 (init_lineno): Add storage parameter.
13827 (free_linetab, free_linetab_cleanup): Remove.
13828
13829 2019-03-06 Pedro Alves <palves@redhat.com>
13830
13831 * linux-fork.c (fork_info::clobber_regs): Delete.
13832 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13833 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13834 comment. Adjust.
13835 (scoped_switch_fork_info::scoped_switch_fork_info)
13836 (checkpoint_command, linux_fork_context): Adjust
13837 fork_save_infrun_state calls.
13838
13839 2019-03-06 Pedro Alves <palves@redhat.com>
13840
13841 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13842 (inf_has_multiple_threads): Return 'bool' and rewrite using
13843 inferior_info::threads().
13844
13845 2019-03-06 Pedro Alves <palves@redhat.com>
13846
13847 * linux-fork.c: Include <list>.
13848 (fork_list): Now a std::list instance.
13849 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13850 (forks_exist_p, find_last_fork): Adjust.
13851 (new_fork): Delete.
13852 (one_fork_p): New.
13853 (add_fork): Adjust.
13854 (free_fork): Delete, folded into fork_info::~fork_info().
13855 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13856 Adjust.
13857 (init_fork_list): Delete.
13858 (linux_fork_killall, linux_fork_mourn_inferior)
13859 (linux_fork_detach, info_checkpoints_command): Adjust.
13860 (_initialize_linux_fork): No longer call init_fork_list.
13861
13862 2019-03-06 Pedro Alves <palves@redhat.com>
13863
13864 * linux-fork.c (new_fork): New, split out of ...
13865 (add_fork): ... this. Return void. Move "first fork" special
13866 case from here, to ...
13867 (checkpoint_command): ... here.
13868 * linux-linux.h (add_fork): Return void.
13869
13870 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13871
13872 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13873
13874 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13875 Chris January <chris.january@arm.com>
13876 David Lecomber <david.lecomber@arm.com>
13877
13878 * f-exp.y: New token, UNOP_INTRINSIC.
13879 (exp): New pattern using UNOP_INTRINSIC token.
13880 (f77_keywords): Add 'abs' keyword.
13881 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13882 (value_from_host_double): New function.
13883 (evaluate_subexp_f): Support UNOP_ABS.
13884
13885 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13886
13887 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13888 types.
13889
13890 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13891
13892 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13893 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13894 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13895
13896 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13897
13898 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13899
13900 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13901 Chris January <chris.january@arm.com>
13902
13903 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13904 * f-exp.y: Define 'KIND' token.
13905 (exp): New pattern for KIND expressions.
13906 (ptype): Handle types with a kind extension.
13907 (direct_abs_decl): Extend to spot kind extensions.
13908 (f77_keywords): Add 'kind' to the list.
13909 (push_kind_type): New function.
13910 (convert_to_kind_type): New function.
13911 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13912 * parse.c (operator_length_standard): Likewise.
13913 * parser-defs.h (enum type_pieces): Add tp_kind.
13914 * std-operator.def: Add UNOP_KIND.
13915
13916 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13917
13918 * f-exp.y (f_parse): Set yydebug.
13919
13920 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13921
13922 * f-lang.c (evaluate_subexp_f): New function.
13923 (exp_descriptor_f): New global.
13924 (f_language_defn): Use exp_descriptor_f instead of
13925 exp_descriptor_standard.
13926
13927 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13928
13929 * f-exp.y (struct token): Add comments.
13930 (dot_ops): Remove uppercase versions and the end marker.
13931 (f77_keywords): Likewise.
13932 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13933 entries in the dot_ops array are case insensitive, and use
13934 strncasecmp to compare strings. Also some whitespace cleanup in
13935 this area. Similar for the f77_keywords array, except entries in
13936 this list might be case sensitive.
13937
13938 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13939
13940 * f-exp.y (struct f77_boolean_val): Add comments.
13941 (boolean_values): Remove uppercase versions, and end marker.
13942 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13943 and use strncasecmp to achieve case insensitivity. Additionally,
13944 perform whitespace cleanup around this code.
13945
13946 2019-03-06 Tom Tromey <tromey@adacore.com>
13947
13948 * remote-sim.c (gdbsim_target_open): Use result of
13949 gdb_argv::release.
13950
13951 2019-03-06 Richard Bunt <richard.bunt@arm.com>
13952 Dirk Schubert <dirk.schubert@arm.com>
13953 Chris January <chris.january@arm.com>
13954
13955 * eval.c (evaluate_subexp_standard): Call Fortran argument
13956 wrapping logic.
13957 * f-lang.c (struct value): A value which can be passed into a
13958 Fortran function call.
13959 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13960 where appropriate.
13961 (struct type): Value ready for a Fortran function call.
13962 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13963 is needed.
13964 * f-lang.h (fortran_argument_convert): Declaration.
13965 (fortran_preserve_arg_pointer): Declaration.
13966 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13967
13968 2019-03-05 Tom Tromey <tromey@adacore.com>
13969
13970 * python/py-prettyprint.c (print_string_repr): Remove #if.
13971 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13972
13973 2019-03-05 Tom Tromey <tromey@adacore.com>
13974
13975 * target.c (the_dummy_target): Move later. Change type to
13976 "dummy_target".
13977 (initialize_targets): Don't initialize the_dummy_target.
13978
13979 2019-03-05 Tom Tromey <tromey@adacore.com>
13980
13981 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13982 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13983
13984 2019-03-05 Tom Tromey <tromey@adacore.com>
13985
13986 * windows-nat.c (windows_nat_target::attach)
13987 (windows_nat_target::detach): Don't call gdb_flush.
13988 * valprint.c (generic_val_print, val_print, val_print_string):
13989 Don't call gdb_flush.
13990 * utils.c (defaulted_query): Don't call gdb_flush.
13991 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13992 * target.c (target_announce_detach): Don't call gdb_flush.
13993 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13994 * remote.c (extended_remote_target::attach): Don't call
13995 gdb_flush.
13996 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13997 * printcmd.c (do_examine): Don't call gdb_flush.
13998 (info_display_command): Don't call gdb_flush.
13999 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14000 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14001 * memattr.c (info_mem_command): Don't call gdb_flush.
14002 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14003 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14004 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14005 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14006 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14007 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14008 (gnu_nat_target::detach): Don't call gdb_flush.
14009 * f-valprint.c (f_val_print): Don't call gdb_flush.
14010 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14011 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14012 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14013 gdb_flush.
14014 * c-valprint.c (c_val_print): Don't call gdb_flush.
14015 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14016
14017 2019-03-05 Tom Tromey <tromey@adacore.com>
14018
14019 * varobj.c (update_dynamic_varobj_children): Update.
14020 (install_default_visualizer): Use reset, not release.
14021 * value.c (set_internalvar): Update.
14022 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14023 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14024 ATTRIBUTE_UNUSED_RESULT.
14025
14026 2019-03-05 Tom Tromey <tromey@adacore.com>
14027
14028 * remote.c (class scoped_remote_fd) <release>: Add
14029 ATTRIBUTE_UNUSED_RESULT.
14030
14031 2019-03-05 Tom Tromey <tromey@adacore.com>
14032
14033 * macroexp.c (struct macro_buffer) <release>: Add
14034 ATTRIBUTE_UNUSED_RESULT.
14035
14036 2019-03-05 Tom Tromey <tromey@adacore.com>
14037
14038 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14039 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14040 ATTRIBUTE_UNUSED_RESULT.
14041
14042 2019-03-05 Tom Tromey <tromey@adacore.com>
14043
14044 * common/scoped_fd.h (class scoped_fd) <release>: Add
14045 ATTRIBUTE_UNUSED_RESULT.
14046
14047 2019-03-05 Tom Tromey <tromey@adacore.com>
14048
14049 * parser-defs.h (struct parser_state) <release>: Add
14050 ATTRIBUTE_UNUSED_RESULT.
14051
14052 2019-03-05 Tom Tromey <tromey@adacore.com>
14053
14054 * utils.h (class gdb_argv) <release>: Add
14055 ATTRIBUTE_UNUSED_RESULT.
14056 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14057
14058 2019-03-02 Eli Zaretskii <eliz@gnu.org>
14059
14060 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14061 for-loop range, to avoid compiler warnings.
14062
14063 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14064 avoid compiler warnings about unused variables.
14065
14066 * NEWS: Mention end of support for native debugging on MS-Windows
14067 before XP.
14068
14069 PR gdb/24292
14070 * common/netstuff.c:
14071 * gdbserver/gdbreplay.c
14072 * gdbserver/remote-utils.c:
14073 * ser-tcp.c:
14074 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14075 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14076 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14077 'getaddrinfo' and 'freeaddrinfo' were not available before
14078 Windows XP, and mingw.org's MinGW headers by default define
14079 _WIN32_WINNT to 0x500.
14080
14081 2019-03-01 Gary Benson <gbenson@redhat.com>
14082
14083 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14084
14085 2019-02-28 Brian Vandenberg <phantall@gmail.com>
14086 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14087
14088 PR gdb/8527
14089 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14090 set_sigint_trap, clear_sigint_trap.
14091
14092 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14093
14094 * target.c (target_detach): Clear the regcache and the
14095 frame cache.
14096
14097 2019-02-27 Pedro Alves <palves@redhat.com>
14098
14099 * utils.c (set_screen_size): When we cap the height/width sizes,
14100 tweak the corresponding command variable to show "unlimited":
14101
14102 2019-02-27 Saagar Jha <saagar@saagarjha.com>
14103 Pedro Alves <palves@redhat.com>
14104
14105 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14106 before calling rl_set_screen_size.
14107
14108 2019-02-27 Tom Tromey <tromey@adacore.com>
14109
14110 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14111 define.
14112 * python/py-value.c: Remove Python 2.4 workaround.
14113 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14114 workaround.
14115 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14116 Python 2.4 workaround.
14117 * python/python-internal.h: Remove Python 2.4 comment.
14118 (Py_ssize_t): Don't define.
14119 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14120 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14121 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14122 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14123 * python/python.c (do_start_initialization): Remove Python 2.4
14124 workaround.
14125 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14126 (print_children): Remove Python 2.4 workaround.
14127 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14128 workaround.
14129 (CHARBUFFERPROC_NAME): Remove.
14130 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14131 Python 2.4 workaround.
14132
14133 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14134
14135 * NEWS: Note minimum Python version.
14136
14137 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14138
14139 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14140 code from these functions. Remove corresponding ifdefs. Use
14141 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14142 Remove gotos and target of gotos.
14143 (infpy_search_memory): Likewise.
14144
14145 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14146
14147 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14148 (hppa_gdbarch_init): Don't register deleted functions with
14149 gdbarch.
14150
14151 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14152
14153 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14154 (h8300_unwind_sp): Delete.
14155 (h8300_dummy_id): Delete.
14156 (h8300_gdbarch_init): Don't register deleted functions with
14157 gdbarch.
14158
14159 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14160
14161 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14162 (ft32_unwind_pc): Delete.
14163 (ft32_unwind_sp): Delete.
14164 (ft32_gdbarch_init): Don't register deleted functions with
14165 gdbarch.
14166
14167 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14168
14169 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14170 (frv_unwind_pc): Delete.
14171 (frv_unwind_sp): Delete.
14172 (frv_gdbarch_init): Don't register deleted functions with
14173 gdbarch.
14174
14175 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14176
14177 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14178 (riscv_unwind_pc): Delete.
14179 (riscv_unwind_sp): Delete.
14180 (riscv_gdbarch_init): Don't register deleted functions with
14181 gdbarch.
14182
14183 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14184
14185 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14186 (csky_unwind_pc): Delete.
14187 (csky_unwind_sp): Delete.
14188 (csky_gdbarch_init): Don't register deleted functions with
14189 gdbarch.
14190
14191 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14192
14193 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14194 (cris_unwind_pc): Delete.
14195 (cris_unwind_sp): Delete.
14196 (cris_gdbarch_init): Don't register deleted functions with
14197 gdbarch.
14198
14199 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14200
14201 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14202 (bfin_unwind_pc): Delete.
14203 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14204
14205 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14206
14207 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14208 (arm_unwind_pc): Delete.
14209 (arm_unwind_sp): Delete.
14210 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14211
14212 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14213
14214 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14215 (arc_unwind_pc): Delete.
14216 (arc_unwind_sp): Delete.
14217 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14218
14219 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14220
14221 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14222 (alpha_unwind_pc): Delete.
14223 (alpha_gdbarch_init): Don't register deleted functions with
14224 gdbarch.
14225
14226 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14227
14228 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14229 (aarch64_unwind_pc): Delete.
14230 (aarch64_unwind_sp): Delete.
14231 (aarch64_gdbarch_init): Don't register deleted functions with
14232 gdbarch.
14233
14234 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14235
14236 * gdbtypes.c (type_align): Don't consider static members when
14237 computing structure alignment.
14238
14239 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14240
14241 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14242 return 0 for other types.
14243 * arch-utils.c (default_type_align): Always return 0.
14244 * gdbarch.h: Regenerate.
14245 * gdbarch.sh (type_align): Extend comment.
14246 * gdbtypes.c (type_align): Add additional comments, always call
14247 gdbarch_type_align before applying the default rules.
14248 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14249 generic code will then apply a suitable default.
14250 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14251 types, return 0 for other types.
14252
14253 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14254
14255 * NEWS: Create a new section for the next release branch.
14256 Rename the section of the current branch, now that it has
14257 been cut.
14258
14259 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14260
14261 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14262 * version.in: Bump version to 8.3.50.DATE-git.
14263
14264 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
14265
14266 * aix-thread.c (ptid_cmp): Remove unused variable.
14267 (get_signaled_thread): Likewise.
14268 (store_regs_user_thread): Likewise.
14269 (store_regs_kernel_thread): Likewise.
14270 (fetch_regs_kernel_thread): Remove shadowed variable.
14271
14272 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14273
14274 * features/riscv/32bit-cpu.xml: Add register numbers.
14275 * features/riscv/32bit-fpu.c: Regenerate.
14276 * features/riscv/32bit-fpu.xml: Add register numbers.
14277 * features/riscv/64bit-cpu.xml: Add register numbers.
14278 * features/riscv/64bit-fpu.c: Regenerate.
14279 * features/riscv/64bit-fpu.xml: Add register numbers.
14280
14281 2019-02-26 Kevin Buettner <kevinb@redhat.com>
14282
14283 * NEWS: Mention two argument form of gdb.Value constructor.
14284 * python/py-value.c (convert_buffer_and_type_to_value): New
14285 function.
14286 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14287 Add support for handling an optional second argument. Call
14288 convert_buffer_and_type_to_value as appropriate.
14289 * python/python-internal.h (Py_buffer_deleter): New struct.
14290 (Py_buffer_up): New typedef.
14291
14292 2019-02-25 John Baldwin <jhb@FreeBSD.org>
14293
14294 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14295 instead of releasing ownership.
14296
14297 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
14298
14299 * dwarf2read.c (open_and_init_dwp_file): Call
14300 elf_numsections instead of bfd_count_sections to initialize
14301 dwp_file->num_sections.
14302
14303 2019-02-25 Tom Tromey <tromey@adacore.com>
14304
14305 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14306
14307 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14308
14309 * gcore.in: Add '--readnever' option when invoking GDB.
14310
14311 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14312
14313 * MAINTAINERS: Update my email address.
14314
14315 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14316
14317 * build-id.c (build_id_to_debug_bfd_1): New function.
14318 (build_id_to_debug_bfd): Look for separate debug file in
14319 sysroot.
14320
14321 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14322
14323 * gdbarch.sh: Update the copyright year range that is placed into
14324 generated files.
14325
14326 2019-02-22 Keith Seitz <keiths@redhat.com>
14327
14328 PR symtab/23853
14329 * linespec.c (create_sals_line_offset): Search for the default
14330 symtab's filename instead of its fullname.
14331
14332 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14333
14334 * NEWS: Update style defaults.
14335
14336 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14337
14338 * main.c (captured_main_1): Disable styling in batch mode.
14339
14340 2019-02-20 Tom Tromey <tom@tromey.com>
14341
14342 * symtab.c (symtab_symbol_info): Fix typos.
14343
14344 2019-02-20 Tom Tromey <tromey@adacore.com>
14345
14346 * findcmd.c (_initialize_mem_search): Use upper case for
14347 metasyntactic variables.
14348
14349 2019-02-20 Alan Hayward <alan.hayward@arm.com>
14350
14351 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14352 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14353
14354 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14355
14356 * top.h (source_file_name): Change to std::string.
14357 * top.c (source_file_name): Likewise.
14358 (command_line_input): Adjust.
14359 * cli/cli-script.c (script_from_file): Adjust.
14360
14361 2019-02-19 Tom Tromey <tromey@adacore.com>
14362
14363 * ravenscar-thread.c
14364 (ravenscar_thread_target::update_thread_list): Don't call
14365 ada_build_task_list.
14366 * ada-lang.h (ada_build_task_list): Don't declare.
14367 * ada-tasks.c (struct ada_tasks_inferior_data)
14368 <task_list_valid_p>: Now bool.
14369 (read_known_tasks, ada_task_list_changed)
14370 (ada_tasks_invalidate_inferior_data): Update.
14371 (read_known_tasks_array): Return bool.
14372 (read_known_tasks_list): Likewise.
14373 (read_known_tasks): Return void.
14374 (ada_build_task_list): Now static.
14375
14376 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14377
14378 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14379 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14380
14381 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14382
14383 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14384 variant for ada_tasks_pspace_data_handle and
14385 ada_tasks_inferior_data_handle.
14386 (ada_tasks_pspace_data_cleanup): New function.
14387 (ada_tasks_inferior_data_cleanup): New function.
14388
14389 2019-02-17 Tom Tromey <tom@tromey.com>
14390
14391 * macrotab.h (macro_source_fullname): Return a std::string.
14392 * macrotab.c (macro_include, check_for_redefinition)
14393 (macro_undef, macro_lookup_definition, foreach_macro)
14394 (foreach_macro_in_scope): Update.
14395 (macro_source_fullname): Return a std::string.
14396 * macrocmd.c (show_pp_source_pos): Update.
14397
14398 2019-02-17 Tom Tromey <tom@tromey.com>
14399
14400 * macrocmd.c (show_pp_source_pos): Style the file names.
14401
14402 2019-02-17 Tom Tromey <tom@tromey.com>
14403
14404 PR tui/24197:
14405 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14406
14407 2019-02-17 Tom Tromey <tom@tromey.com>
14408
14409 * ada-lang.c (user_select_syms): Use filtered printing.
14410 * utils.c (wrap_style): New global.
14411 (desired_style): Remove.
14412 (emit_style_escape): Add stream parameter.
14413 (set_output_style, reset_terminal_style, prompt_for_continue):
14414 Update.
14415 (flush_wrap_buffer): Only flush gdb_stdout.
14416 (wrap_here): Set wrap_style.
14417 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14418 treat escape sequences as a character. Change when wrap buffer is
14419 flushed.
14420 (fputs_styled): Do not set the output style when the default is
14421 requested.
14422 * ui-style.h (struct ui_file_style) <is_default>: New method.
14423 * source.c (print_source_lines_base): Emit escape sequences in one
14424 piece.
14425
14426 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14427
14428 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14429 integers and enumeration types.
14430
14431 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14432
14433 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14434 instead of lookup_symbol_in_language
14435 (do_exact_match): New function.
14436 (ada_get_symbol_name_matcher): Return do_exact_match when
14437 doing a verbatim match.
14438
14439 2019-02-15 Tom Tromey <tromey@adacore.com>
14440
14441 * ravenscar-thread.c (ravenscar_thread_target::resume)
14442 (ravenscar_thread_target::wait): Special case wildcard requests.
14443
14444 2019-02-15 Tom Tromey <tromey@adacore.com>
14445
14446 * ravenscar-thread.c (base_ptid): Remove.
14447 (struct ravenscar_thread_target) <close>: New method.
14448 <m_base_ptid>: New member.
14449 <update_inferior_ptid, active_task, task_is_currently_active,
14450 runtime_initialized>: Declare methods.
14451 <ravenscar_thread_target>: Add constructor.
14452 (ravenscar_thread_target::task_is_currently_active)
14453 (ravenscar_thread_target::update_inferior_ptid)
14454 (ravenscar_runtime_initialized): Rename. Now methods.
14455 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14456 (ravenscar_thread_target::update_thread_list): Update.
14457 (ravenscar_thread_target::active_task): Now method.
14458 (ravenscar_thread_target::store_registers)
14459 (ravenscar_thread_target::prepare_to_store)
14460 (ravenscar_thread_target::prepare_to_store)
14461 (ravenscar_thread_target::mourn_inferior): Update.
14462 (ravenscar_inferior_created): Use "new" to create target.
14463 (ravenscar_thread_target::get_ada_task_ptid): Update.
14464 (_initialize_ravenscar): Don't initialize base_ptid.
14465 (ravenscar_ops): Remove global.
14466
14467 2019-02-15 Tom Tromey <tromey@adacore.com>
14468
14469 * target.h (push_target): Declare new overload.
14470 * target.c (push_target): New overload, taking an rvalue reference.
14471 * remote.c (remote_target::open_1): Use push_target overload.
14472 * corelow.c (core_target_open): Use push_target overload.
14473
14474 2019-02-15 Tom Tromey <tromey@adacore.com>
14475
14476 * ravenscar-thread.c (is_ravenscar_task)
14477 (ravenscar_task_is_currently_active): Return bool.
14478 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14479 (_initialize_ravenscar): Remove "(void)".
14480 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14481 Return bool.
14482
14483 2019-02-15 Tom Tromey <tromey@adacore.com>
14484
14485 * ravenscar-thread.c (ravenscar_runtime_initializer)
14486 (has_ravenscar_runtime, get_running_thread_id)
14487 (ravenscar_thread_target::resume): Fix indentation.
14488
14489 2019-02-15 Tom Tromey <tromey@adacore.com>
14490
14491 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14492 from ravenscar_arch_ops.
14493 (sparc_ravenscar_ops::fetch_registers)
14494 (sparc_ravenscar_ops::store_registers): Now methods.
14495 (sparc_ravenscar_prepare_to_store): Remove.
14496 (sparc_ravenscar_ops): Redefine.
14497 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14498 methods and destructor. Remove members.
14499 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14500 (ravenscar_thread_target::store_registers)
14501 (ravenscar_thread_target::prepare_to_store): Update.
14502 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14503 Remove.
14504 (struct ppc_ravenscar_powerpc_ops): Derive from
14505 ravenscar_arch_ops.
14506 (ppc_ravenscar_powerpc_ops::fetch_registers)
14507 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14508 (ppc_ravenscar_powerpc_ops): Redefine.
14509 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14510 (ppc_ravenscar_e500_ops::fetch_registers)
14511 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14512 (ppc_ravenscar_e500_ops): Redefine.
14513 * aarch64-ravenscar-thread.c
14514 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14515 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14516 (aarch64_ravenscar_fetch_registers)
14517 (aarch64_ravenscar_store_registers): Now methods.
14518 (aarch64_ravenscar_ops): Redefine.
14519
14520 2019-02-15 Tom Tromey <tromey@adacore.com>
14521
14522 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14523 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14524 (ravenscar_thread_target::stopped_by_watchpoint)
14525 (ravenscar_thread_target::stopped_data_address)
14526 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14527
14528 2019-02-15 Tom Tromey <tromey@adacore.com>
14529
14530 * ravenscar-thread.c: Fix some typos.
14531
14532 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14533 Tom Tromey <tromey@adacore.com>
14534
14535 * ada-lang.c (ada_exception_sal): Change addr_string to a
14536 std::string.
14537 (create_ada_exception_catchpoint): Update.
14538
14539 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14540 Tom Tromey <tromey@adacore.com>
14541
14542 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14543 (bp_location_ops): Remove.
14544 (base_breakpoint_allocate_location): Update.
14545 (free_bp_location): Update.
14546 * ada-lang.c (class ada_catchpoint_location)
14547 <ada_catchpoint_location>: Remove ops parameter.
14548 (ada_catchpoint_location_dtor): Remove.
14549 (ada_catchpoint_location_ops): Remove.
14550 (allocate_location_exception): Update.
14551 * breakpoint.h (struct bp_location_ops): Remove.
14552 (class bp_location) <bp_location>: Remove bp_location_ops
14553 parameter.
14554 <~bp_location>: Add destructor.
14555 <ops>: Remove.
14556
14557 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14558 Pedro Alves <palves@redhat.com>
14559
14560 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14561 'PATH_MAX'.
14562
14563 2019-02-14 David Michael <fedora.dm0@gmail.com>
14564 Samuel Thibault <samuel.thibault@gnu.org>
14565 Thomas Schwinge <thomas@codesourcery.com>
14566
14567 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14568 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14569
14570 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14571
14572 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14573 (check_empty): Use "const char *".
14574
14575 * gnu-nat.c (gnu_nat_target::detach): Instead of
14576 'detach_inferior (pid)' call
14577 'detach_inferior (find_inferior_pid (pid))'.
14578
14579 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14580 'nat/fork-inferior.o'.
14581 * gnu-nat.c: #include "nat/fork-inferior.h".
14582
14583 * gnu-nat.c (gnu_nat_target::detach): Instead of
14584 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14585 * gnu-nat.h: #include "inf-child.h".
14586 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14587 'i386_gnu_nat_target::fetch_registers'.
14588 (gnu_store_registers): Rename/move to
14589 'i386_gnu_nat_target::store_registers'.
14590
14591 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14592 * gnu-nat.h (mach_thread_info): New function.
14593 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14594
14595 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14596
14597 2019-02-14 Frederic Konrad <konrad@adacore.com>
14598
14599 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14600
14601 2019-02-14 Joel Brobecker <brobecker@adacore.com>
14602
14603 * windows-nat.c (windows_add_thread): Add new parameter
14604 "main_thread_p" with default value set to false. Update
14605 function documentation as well as all callers.
14606 (windows_delete_thread): Likewise.
14607 (fake_create_process): Update call to windows_add_thread.
14608 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14609 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14610 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14611 call to windows_delete_thread.
14612
14613 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14614
14615 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14616
14617 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14618
14619 * symfile.c (find_separate_debug_file): Use canonical path of
14620 sysroot with child_path instead of gdb_sysroot if it is valid.
14621
14622 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14623
14624 * symfile.c (find_separate_debug_file): Use child_path to
14625 determine if an object file is under a sysroot.
14626
14627 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14628
14629 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14630 unittests/child-path-selftests.c.
14631 * common/pathstuff.c (child_path): New function.
14632 * common/pathstuff.h (child_path): New prototype.
14633 * unittests/child-path-selftests.c: New file.
14634
14635 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14636
14637 * symfile.c (find_separate_debug_file): Look for separate debug
14638 files in debug directories under the sysroot.
14639
14640 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14641
14642 * symtab.h (struct minimal_symbol data_p): New const method.
14643 (struct minimal_symbol text_p): Likewise.
14644 * symtab.c (output_source_filename): Use file name style
14645 to print file name.
14646 (print_symbol_info): Likewise.
14647 (print_msymbol_info): Use address style to print addresses.
14648 Use function name style to print executable text symbols.
14649 (expand_symtab_containing_pc): Use data_p.
14650 (find_pc_sect_compunit_symtab): Likewise.
14651
14652 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14653
14654 * breakpoint.c (describe_other_breakpoints): Use address style
14655 to print addresses.
14656 (say_where): Likewise.
14657
14658 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14659
14660 * ada-typeprint.c (print_func_type): Print function name
14661 style to print function name.
14662 * c-typeprint.c (c_print_type_1): Likewise.
14663
14664 2019-02-11 Alan Hayward <alan.hayward@arm.com>
14665
14666 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14667 for execve.
14668
14669 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14670
14671 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14672 type_stack.
14673
14674 2019-02-10 Joel Brobecker <brobecker@adacore.com>
14675
14676 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14677 TYPE_CODE_REF types.
14678
14679 2019-02-08 Jim Wilson <jimw@sifive.com>
14680
14681 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14682 (riscv_linux_fregset): New.
14683 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14684
14685 2019-02-07 Tom Tromey <tom@tromey.com>
14686
14687 * thread.c (thread_cancel_execution_command): Update.
14688 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14689 methods.
14690 (struct thread_fsm_ops): Remove.
14691 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14692 (thread_fsm_should_stop, thread_fsm_return_value)
14693 (thread_fsm_set_finished, thread_fsm_finished_p)
14694 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14695 Don't declare.
14696 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14697 * infrun.c (clear_proceed_status_thread)
14698 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14699 (print_stop_event): Update.
14700 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14701 Add constructor.
14702 (step_command_fsm_ops): Remove.
14703 (new_step_command_fsm): Remove.
14704 (step_1): Update.
14705 (step_command_fsm::should_stop): Rename from
14706 step_command_fsm_should_stop.
14707 (step_command_fsm::clean_up): Rename from
14708 step_command_fsm_clean_up.
14709 (step_command_fsm::do_async_reply_reason): Rename from
14710 step_command_fsm_async_reply_reason.
14711 (struct until_next_fsm): Inherit from thread_fsm. Add
14712 constructor.
14713 (until_next_fsm_ops): Remove.
14714 (new_until_next_fsm): Remove.
14715 (until_next_fsm::should_stop): Rename from
14716 until_next_fsm_should_stop.
14717 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14718 (until_next_fsm::do_async_reply_reason): Rename from
14719 until_next_fsm_async_reply_reason.
14720 (struct finish_command_fsm): Inherit from thread_fsm. Add
14721 constructor. Change type of breakpoint.
14722 (finish_command_fsm_ops): Remove.
14723 (new_finish_command_fsm): Remove.
14724 (finish_command_fsm::should_stop): Rename from
14725 finish_command_fsm_should_stop.
14726 (finish_command_fsm::clean_up): Rename from
14727 finish_command_fsm_clean_up.
14728 (finish_command_fsm::return_value): Rename from
14729 finish_command_fsm_return_value.
14730 (finish_command_fsm::do_async_reply_reason): Rename from
14731 finish_command_fsm_async_reply_reason.
14732 (finish_command): Update.
14733 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14734 Add constructor.
14735 (call_thread_fsm_ops): Remove.
14736 (call_thread_fsm::call_thread_fsm): Rename from
14737 new_call_thread_fsm.
14738 (call_thread_fsm::should_stop): Rename from
14739 call_thread_fsm_should_stop.
14740 (call_thread_fsm::should_notify_stop): Rename from
14741 call_thread_fsm_should_notify_stop.
14742 (run_inferior_call, call_function_by_hand_dummy): Update.
14743 * cli/cli-interp.c (should_print_stop_to_console): Update.
14744 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14745 Add constructor. Change type of location_breakpoint,
14746 caller_breakpoint.
14747 (until_break_fsm_ops): Remove.
14748 (new_until_break_fsm): Remove.
14749 (until_break_fsm::should_stop): Rename from
14750 until_break_fsm_should_stop.
14751 (until_break_fsm::clean_up): Rename from
14752 until_break_fsm_clean_up.
14753 (until_break_fsm::do_async_reply_reason): Rename from
14754 until_break_fsm_async_reply_reason.
14755 (until_break_command): Update.
14756 * thread-fsm.c: Remove.
14757 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14758
14759 2019-02-07 Tom Tromey <tom@tromey.com>
14760
14761 * yy-remap.h: Add include guard.
14762 * xtensa-tdep.h: Add include guard.
14763 * xcoffread.h: Rename include guard.
14764 * varobj-iter.h: Add include guard.
14765 * tui/tui.h: Rename include guard.
14766 * tui/tui-winsource.h: Rename include guard.
14767 * tui/tui-wingeneral.h: Rename include guard.
14768 * tui/tui-windata.h: Rename include guard.
14769 * tui/tui-win.h: Rename include guard.
14770 * tui/tui-stack.h: Rename include guard.
14771 * tui/tui-source.h: Rename include guard.
14772 * tui/tui-regs.h: Rename include guard.
14773 * tui/tui-out.h: Rename include guard.
14774 * tui/tui-layout.h: Rename include guard.
14775 * tui/tui-io.h: Rename include guard.
14776 * tui/tui-hooks.h: Rename include guard.
14777 * tui/tui-file.h: Rename include guard.
14778 * tui/tui-disasm.h: Rename include guard.
14779 * tui/tui-data.h: Rename include guard.
14780 * tui/tui-command.h: Rename include guard.
14781 * tic6x-tdep.h: Add include guard.
14782 * target/waitstatus.h: Rename include guard.
14783 * target/wait.h: Rename include guard.
14784 * target/target.h: Rename include guard.
14785 * target/resume.h: Rename include guard.
14786 * target-float.h: Rename include guard.
14787 * stabsread.h: Add include guard.
14788 * rs6000-tdep.h: Add include guard.
14789 * riscv-fbsd-tdep.h: Add include guard.
14790 * regformats/regdef.h: Rename include guard.
14791 * record.h: Rename include guard.
14792 * python/python.h: Rename include guard.
14793 * python/python-internal.h: Rename include guard.
14794 * python/py-stopevent.h: Rename include guard.
14795 * python/py-ref.h: Rename include guard.
14796 * python/py-record.h: Rename include guard.
14797 * python/py-record-full.h: Rename include guard.
14798 * python/py-record-btrace.h: Rename include guard.
14799 * python/py-instruction.h: Rename include guard.
14800 * python/py-events.h: Rename include guard.
14801 * python/py-event.h: Rename include guard.
14802 * procfs.h: Add include guard.
14803 * proc-utils.h: Add include guard.
14804 * p-lang.h: Add include guard.
14805 * or1k-tdep.h: Rename include guard.
14806 * observable.h: Rename include guard.
14807 * nto-tdep.h: Rename include guard.
14808 * nat/x86-linux.h: Rename include guard.
14809 * nat/x86-linux-dregs.h: Rename include guard.
14810 * nat/x86-gcc-cpuid.h: Add include guard.
14811 * nat/x86-dregs.h: Rename include guard.
14812 * nat/x86-cpuid.h: Rename include guard.
14813 * nat/ppc-linux.h: Rename include guard.
14814 * nat/mips-linux-watch.h: Rename include guard.
14815 * nat/linux-waitpid.h: Rename include guard.
14816 * nat/linux-ptrace.h: Rename include guard.
14817 * nat/linux-procfs.h: Rename include guard.
14818 * nat/linux-osdata.h: Rename include guard.
14819 * nat/linux-nat.h: Rename include guard.
14820 * nat/linux-namespaces.h: Rename include guard.
14821 * nat/linux-btrace.h: Rename include guard.
14822 * nat/glibc_thread_db.h: Rename include guard.
14823 * nat/gdb_thread_db.h: Rename include guard.
14824 * nat/gdb_ptrace.h: Rename include guard.
14825 * nat/fork-inferior.h: Rename include guard.
14826 * nat/amd64-linux-siginfo.h: Rename include guard.
14827 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14828 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14829 * nat/aarch64-linux.h: Rename include guard.
14830 * nat/aarch64-linux-hw-point.h: Rename include guard.
14831 * mn10300-tdep.h: Add include guard.
14832 * mips-linux-tdep.h: Add include guard.
14833 * mi/mi-parse.h: Rename include guard.
14834 * mi/mi-out.h: Rename include guard.
14835 * mi/mi-main.h: Rename include guard.
14836 * mi/mi-interp.h: Rename include guard.
14837 * mi/mi-getopt.h: Rename include guard.
14838 * mi/mi-console.h: Rename include guard.
14839 * mi/mi-common.h: Rename include guard.
14840 * mi/mi-cmds.h: Rename include guard.
14841 * mi/mi-cmd-break.h: Rename include guard.
14842 * m2-lang.h: Add include guard.
14843 * location.h: Rename include guard.
14844 * linux-record.h: Rename include guard.
14845 * linux-nat.h: Add include guard.
14846 * linux-fork.h: Add include guard.
14847 * i386-darwin-tdep.h: Rename include guard.
14848 * hppa-linux-offsets.h: Add include guard.
14849 * guile/guile.h: Rename include guard.
14850 * guile/guile-internal.h: Rename include guard.
14851 * gnu-nat.h: Rename include guard.
14852 * gdb-stabs.h: Rename include guard.
14853 * frv-tdep.h: Add include guard.
14854 * f-lang.h: Add include guard.
14855 * event-loop.h: Add include guard.
14856 * darwin-nat.h: Rename include guard.
14857 * cp-abi.h: Rename include guard.
14858 * config/sparc/nm-sol2.h: Rename include guard.
14859 * config/nm-nto.h: Rename include guard.
14860 * config/nm-linux.h: Add include guard.
14861 * config/i386/nm-i386gnu.h: Rename include guard.
14862 * config/djgpp/nl_types.h: Rename include guard.
14863 * config/djgpp/langinfo.h: Rename include guard.
14864 * compile/gcc-cp-plugin.h: Add include guard.
14865 * compile/gcc-c-plugin.h: Add include guard.
14866 * compile/compile.h: Rename include guard.
14867 * compile/compile-object-run.h: Rename include guard.
14868 * compile/compile-object-load.h: Rename include guard.
14869 * compile/compile-internal.h: Rename include guard.
14870 * compile/compile-cplus.h: Rename include guard.
14871 * compile/compile-c.h: Rename include guard.
14872 * common/xml-utils.h: Rename include guard.
14873 * common/x86-xstate.h: Rename include guard.
14874 * common/version.h: Rename include guard.
14875 * common/vec.h: Rename include guard.
14876 * common/tdesc.h: Rename include guard.
14877 * common/selftest.h: Rename include guard.
14878 * common/scoped_restore.h: Rename include guard.
14879 * common/scoped_mmap.h: Rename include guard.
14880 * common/scoped_fd.h: Rename include guard.
14881 * common/safe-iterator.h: Rename include guard.
14882 * common/run-time-clock.h: Rename include guard.
14883 * common/refcounted-object.h: Rename include guard.
14884 * common/queue.h: Rename include guard.
14885 * common/ptid.h: Rename include guard.
14886 * common/print-utils.h: Rename include guard.
14887 * common/preprocessor.h: Rename include guard.
14888 * common/pathstuff.h: Rename include guard.
14889 * common/observable.h: Rename include guard.
14890 * common/netstuff.h: Rename include guard.
14891 * common/job-control.h: Rename include guard.
14892 * common/host-defs.h: Rename include guard.
14893 * common/gdb_wait.h: Rename include guard.
14894 * common/gdb_vecs.h: Rename include guard.
14895 * common/gdb_unlinker.h: Rename include guard.
14896 * common/gdb_unique_ptr.h: Rename include guard.
14897 * common/gdb_tilde_expand.h: Rename include guard.
14898 * common/gdb_sys_time.h: Rename include guard.
14899 * common/gdb_string_view.h: Rename include guard.
14900 * common/gdb_splay_tree.h: Rename include guard.
14901 * common/gdb_setjmp.h: Rename include guard.
14902 * common/gdb_ref_ptr.h: Rename include guard.
14903 * common/gdb_optional.h: Rename include guard.
14904 * common/gdb_locale.h: Rename include guard.
14905 * common/gdb_assert.h: Rename include guard.
14906 * common/filtered-iterator.h: Rename include guard.
14907 * common/filestuff.h: Rename include guard.
14908 * common/fileio.h: Rename include guard.
14909 * common/environ.h: Rename include guard.
14910 * common/common-utils.h: Rename include guard.
14911 * common/common-types.h: Rename include guard.
14912 * common/common-regcache.h: Rename include guard.
14913 * common/common-inferior.h: Rename include guard.
14914 * common/common-gdbthread.h: Rename include guard.
14915 * common/common-exceptions.h: Rename include guard.
14916 * common/common-defs.h: Rename include guard.
14917 * common/common-debug.h: Rename include guard.
14918 * common/cleanups.h: Rename include guard.
14919 * common/buffer.h: Rename include guard.
14920 * common/btrace-common.h: Rename include guard.
14921 * common/break-common.h: Rename include guard.
14922 * cli/cli-utils.h: Rename include guard.
14923 * cli/cli-style.h: Rename include guard.
14924 * cli/cli-setshow.h: Rename include guard.
14925 * cli/cli-script.h: Rename include guard.
14926 * cli/cli-interp.h: Rename include guard.
14927 * cli/cli-decode.h: Rename include guard.
14928 * cli/cli-cmds.h: Rename include guard.
14929 * charset-list.h: Add include guard.
14930 * buildsym-legacy.h: Rename include guard.
14931 * bfin-tdep.h: Add include guard.
14932 * ax.h: Rename include guard.
14933 * arm-linux-tdep.h: Add include guard.
14934 * arm-fbsd-tdep.h: Add include guard.
14935 * arch/xtensa.h: Rename include guard.
14936 * arch/tic6x.h: Add include guard.
14937 * arch/i386.h: Add include guard.
14938 * arch/arm.h: Rename include guard.
14939 * arch/arm-linux.h: Rename include guard.
14940 * arch/arm-get-next-pcs.h: Rename include guard.
14941 * arch/amd64.h: Add include guard.
14942 * arch/aarch64-insn.h: Rename include guard.
14943 * arch-utils.h: Rename include guard.
14944 * annotate.h: Add include guard.
14945 * amd64-darwin-tdep.h: Rename include guard.
14946 * aarch64-linux-tdep.h: Add include guard.
14947 * aarch64-fbsd-tdep.h: Add include guard.
14948 * aarch32-linux-nat.h: Add include guard.
14949
14950 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14951
14952 * macrotab.c (macro_define_internal): New function that
14953 factorizes macro_define_object_internal and macro_define_function
14954 code.
14955 (macro_define_object_internal): Use macro_define_internal.
14956 (macro_define_function): Likewise.
14957
14958 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14959
14960 * macrocmd.c (extract_identifier): Return
14961 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14962 callers.
14963
14964 2019-02-06 John Baldwin <jhb@FreeBSD.org>
14965
14966 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14967
14968 2019-02-05 Tom Tromey <tom@tromey.com>
14969
14970 * target.c (target_stack::unpush): Move assertion earlier.
14971
14972 2019-01-30 Tom Tromey <tom@tromey.com>
14973
14974 PR python/23615:
14975 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14976 (gdbpy_parse_and_eval): Likewise.
14977 * python/python-internal.h (gdbpy_allow_threads): New class.
14978
14979 2019-01-28 John Baldwin <jhb@FreeBSD.org>
14980
14981 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14982 (aarch64_fbsd_fpregmap): Move earlier.
14983 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14984 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14985 instead of individual calls to trad_frame_set_reg_addr.
14986 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14987 earlier.
14988 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14989 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14990 instead of individual calls to trad_frame_set_reg_addr.
14991
14992 2019-01-28 Alan Hayward <alan.hayward@arm.com>
14993
14994 * CONTRIBUTE: Replace contribution list with wiki link.
14995
14996 2019-01-25 Tom Tromey <tom@tromey.com>
14997
14998 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14999
15000 2019-01-25 Tom Tromey <tom@tromey.com>
15001
15002 * xtensa-linux-nat.c: Fix common/ includes.
15003 * xml-support.h: Fix common/ includes.
15004 * xml-support.c: Fix common/ includes.
15005 * x86-linux-nat.c: Fix common/ includes.
15006 * windows-nat.c: Fix common/ includes.
15007 * varobj.h: Fix common/ includes.
15008 * varobj.c: Fix common/ includes.
15009 * value.c: Fix common/ includes.
15010 * valops.c: Fix common/ includes.
15011 * utils.c: Fix common/ includes.
15012 * unittests/xml-utils-selftests.c: Fix common/ includes.
15013 * unittests/utils-selftests.c: Fix common/ includes.
15014 * unittests/unpack-selftests.c: Fix common/ includes.
15015 * unittests/tracepoint-selftests.c: Fix common/ includes.
15016 * unittests/style-selftests.c: Fix common/ includes.
15017 * unittests/string_view-selftests.c: Fix common/ includes.
15018 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15019 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15020 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15021 * unittests/rsp-low-selftests.c: Fix common/ includes.
15022 * unittests/parse-connection-spec-selftests.c: Fix common/
15023 includes.
15024 * unittests/optional-selftests.c: Fix common/ includes.
15025 * unittests/offset-type-selftests.c: Fix common/ includes.
15026 * unittests/observable-selftests.c: Fix common/ includes.
15027 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15028 * unittests/memrange-selftests.c: Fix common/ includes.
15029 * unittests/memory-map-selftests.c: Fix common/ includes.
15030 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15031 * unittests/function-view-selftests.c: Fix common/ includes.
15032 * unittests/environ-selftests.c: Fix common/ includes.
15033 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15034 * unittests/common-utils-selftests.c: Fix common/ includes.
15035 * unittests/cli-utils-selftests.c: Fix common/ includes.
15036 * unittests/array-view-selftests.c: Fix common/ includes.
15037 * ui-file.c: Fix common/ includes.
15038 * tui/tui-io.c: Fix common/ includes.
15039 * tracepoint.h: Fix common/ includes.
15040 * tracepoint.c: Fix common/ includes.
15041 * tracefile-tfile.c: Fix common/ includes.
15042 * top.h: Fix common/ includes.
15043 * top.c: Fix common/ includes.
15044 * thread.c: Fix common/ includes.
15045 * target/waitstatus.h: Fix common/ includes.
15046 * target/waitstatus.c: Fix common/ includes.
15047 * target.h: Fix common/ includes.
15048 * target.c: Fix common/ includes.
15049 * target-memory.c: Fix common/ includes.
15050 * target-descriptions.c: Fix common/ includes.
15051 * symtab.h: Fix common/ includes.
15052 * symfile.c: Fix common/ includes.
15053 * stap-probe.c: Fix common/ includes.
15054 * spu-linux-nat.c: Fix common/ includes.
15055 * sparc-nat.c: Fix common/ includes.
15056 * source.c: Fix common/ includes.
15057 * solib.c: Fix common/ includes.
15058 * solib-target.c: Fix common/ includes.
15059 * ser-unix.c: Fix common/ includes.
15060 * ser-tcp.c: Fix common/ includes.
15061 * ser-pipe.c: Fix common/ includes.
15062 * ser-base.c: Fix common/ includes.
15063 * selftest-arch.c: Fix common/ includes.
15064 * s12z-tdep.c: Fix common/ includes.
15065 * rust-exp.y: Fix common/ includes.
15066 * rs6000-aix-tdep.c: Fix common/ includes.
15067 * riscv-tdep.c: Fix common/ includes.
15068 * remote.c: Fix common/ includes.
15069 * remote-notif.h: Fix common/ includes.
15070 * remote-fileio.h: Fix common/ includes.
15071 * remote-fileio.c: Fix common/ includes.
15072 * regcache.h: Fix common/ includes.
15073 * regcache.c: Fix common/ includes.
15074 * record-btrace.c: Fix common/ includes.
15075 * python/python.c: Fix common/ includes.
15076 * python/py-type.c: Fix common/ includes.
15077 * python/py-inferior.c: Fix common/ includes.
15078 * progspace.h: Fix common/ includes.
15079 * producer.c: Fix common/ includes.
15080 * procfs.c: Fix common/ includes.
15081 * proc-api.c: Fix common/ includes.
15082 * printcmd.c: Fix common/ includes.
15083 * ppc-linux-nat.c: Fix common/ includes.
15084 * parser-defs.h: Fix common/ includes.
15085 * osdata.c: Fix common/ includes.
15086 * obsd-nat.c: Fix common/ includes.
15087 * nat/x86-linux.c: Fix common/ includes.
15088 * nat/x86-linux-dregs.c: Fix common/ includes.
15089 * nat/x86-dregs.h: Fix common/ includes.
15090 * nat/x86-dregs.c: Fix common/ includes.
15091 * nat/ppc-linux.c: Fix common/ includes.
15092 * nat/mips-linux-watch.h: Fix common/ includes.
15093 * nat/mips-linux-watch.c: Fix common/ includes.
15094 * nat/linux-waitpid.c: Fix common/ includes.
15095 * nat/linux-ptrace.h: Fix common/ includes.
15096 * nat/linux-ptrace.c: Fix common/ includes.
15097 * nat/linux-procfs.c: Fix common/ includes.
15098 * nat/linux-personality.c: Fix common/ includes.
15099 * nat/linux-osdata.c: Fix common/ includes.
15100 * nat/linux-namespaces.c: Fix common/ includes.
15101 * nat/linux-btrace.h: Fix common/ includes.
15102 * nat/linux-btrace.c: Fix common/ includes.
15103 * nat/fork-inferior.c: Fix common/ includes.
15104 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15105 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15106 * nat/aarch64-linux.c: Fix common/ includes.
15107 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15108 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15109 * namespace.h: Fix common/ includes.
15110 * mips-linux-tdep.c: Fix common/ includes.
15111 * minsyms.c: Fix common/ includes.
15112 * mi/mi-parse.h: Fix common/ includes.
15113 * mi/mi-main.c: Fix common/ includes.
15114 * mi/mi-cmd-env.c: Fix common/ includes.
15115 * memrange.h: Fix common/ includes.
15116 * memattr.c: Fix common/ includes.
15117 * maint.h: Fix common/ includes.
15118 * maint.c: Fix common/ includes.
15119 * main.c: Fix common/ includes.
15120 * machoread.c: Fix common/ includes.
15121 * location.c: Fix common/ includes.
15122 * linux-thread-db.c: Fix common/ includes.
15123 * linux-nat.c: Fix common/ includes.
15124 * linux-fork.c: Fix common/ includes.
15125 * inline-frame.c: Fix common/ includes.
15126 * infrun.c: Fix common/ includes.
15127 * inflow.c: Fix common/ includes.
15128 * inferior.h: Fix common/ includes.
15129 * inferior.c: Fix common/ includes.
15130 * infcmd.c: Fix common/ includes.
15131 * inf-ptrace.c: Fix common/ includes.
15132 * inf-child.c: Fix common/ includes.
15133 * ia64-linux-nat.c: Fix common/ includes.
15134 * i387-tdep.c: Fix common/ includes.
15135 * i386-tdep.c: Fix common/ includes.
15136 * i386-linux-tdep.c: Fix common/ includes.
15137 * i386-linux-nat.c: Fix common/ includes.
15138 * i386-go32-tdep.c: Fix common/ includes.
15139 * i386-fbsd-tdep.c: Fix common/ includes.
15140 * i386-fbsd-nat.c: Fix common/ includes.
15141 * guile/scm-type.c: Fix common/ includes.
15142 * guile/guile.c: Fix common/ includes.
15143 * go32-nat.c: Fix common/ includes.
15144 * gnu-nat.c: Fix common/ includes.
15145 * gdbthread.h: Fix common/ includes.
15146 * gdbarch-selftests.c: Fix common/ includes.
15147 * gdb_usleep.c: Fix common/ includes.
15148 * gdb_select.h: Fix common/ includes.
15149 * gdb_bfd.c: Fix common/ includes.
15150 * gcore.c: Fix common/ includes.
15151 * fork-child.c: Fix common/ includes.
15152 * findvar.c: Fix common/ includes.
15153 * fbsd-nat.c: Fix common/ includes.
15154 * event-top.c: Fix common/ includes.
15155 * event-loop.c: Fix common/ includes.
15156 * dwarf2read.c: Fix common/ includes.
15157 * dwarf2loc.c: Fix common/ includes.
15158 * dwarf2-frame.c: Fix common/ includes.
15159 * dwarf-index-cache.c: Fix common/ includes.
15160 * dtrace-probe.c: Fix common/ includes.
15161 * disasm-selftests.c: Fix common/ includes.
15162 * defs.h: Fix common/ includes.
15163 * csky-tdep.c: Fix common/ includes.
15164 * cp-valprint.c: Fix common/ includes.
15165 * cp-support.h: Fix common/ includes.
15166 * cp-support.c: Fix common/ includes.
15167 * corelow.c: Fix common/ includes.
15168 * completer.h: Fix common/ includes.
15169 * completer.c: Fix common/ includes.
15170 * compile/compile.c: Fix common/ includes.
15171 * compile/compile-loc2c.c: Fix common/ includes.
15172 * compile/compile-cplus-types.c: Fix common/ includes.
15173 * compile/compile-cplus-symbols.c: Fix common/ includes.
15174 * command.h: Fix common/ includes.
15175 * cli/cli-dump.c: Fix common/ includes.
15176 * cli/cli-cmds.c: Fix common/ includes.
15177 * charset.c: Fix common/ includes.
15178 * build-id.c: Fix common/ includes.
15179 * btrace.h: Fix common/ includes.
15180 * btrace.c: Fix common/ includes.
15181 * breakpoint.h: Fix common/ includes.
15182 * breakpoint.c: Fix common/ includes.
15183 * ax.h:
15184 (enum agent_op): Fix common/ includes.
15185 * ax-general.c (struct aop_map): Fix common/ includes.
15186 * ax-gdb.c: Fix common/ includes.
15187 * auxv.c: Fix common/ includes.
15188 * auto-load.c: Fix common/ includes.
15189 * arm-tdep.c: Fix common/ includes.
15190 * arch/riscv.c: Fix common/ includes.
15191 * arch/ppc-linux-common.c: Fix common/ includes.
15192 * arch/i386.c: Fix common/ includes.
15193 * arch/arm.c: Fix common/ includes.
15194 * arch/arm-linux.c: Fix common/ includes.
15195 * arch/arm-get-next-pcs.c: Fix common/ includes.
15196 * arch/amd64.c: Fix common/ includes.
15197 * arch/aarch64.c: Fix common/ includes.
15198 * arch/aarch64-insn.c: Fix common/ includes.
15199 * arch-utils.c: Fix common/ includes.
15200 * amd64-windows-tdep.c: Fix common/ includes.
15201 * amd64-tdep.c: Fix common/ includes.
15202 * amd64-sol2-tdep.c: Fix common/ includes.
15203 * amd64-obsd-tdep.c: Fix common/ includes.
15204 * amd64-nbsd-tdep.c: Fix common/ includes.
15205 * amd64-linux-tdep.c: Fix common/ includes.
15206 * amd64-linux-nat.c: Fix common/ includes.
15207 * amd64-fbsd-tdep.c: Fix common/ includes.
15208 * amd64-fbsd-nat.c: Fix common/ includes.
15209 * amd64-dicos-tdep.c: Fix common/ includes.
15210 * amd64-darwin-tdep.c: Fix common/ includes.
15211 * agent.c: Fix common/ includes.
15212 * ada-lang.h: Fix common/ includes.
15213 * ada-lang.c: Fix common/ includes.
15214 * aarch64-tdep.c: Fix common/ includes.
15215
15216 2019-01-25 Tom Tromey <tom@tromey.com>
15217
15218 * common/create-version.sh: Use common/version.h.
15219
15220 2019-01-24 Pedro Alves <palves@redhat.com>
15221
15222 * infrun.c (signal_stop, signal_print, signal_program)
15223 (signal_catch, signal_pass): Now arrays instead of pointers.
15224 (update_signals_program_target, do_target_resume)
15225 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15226 * linux-nat.c (linux_nat_target::pass_signals)
15227 (linux_nat_target::create_inferior, linux_nat_target::attach):
15228 Adjust.
15229 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15230 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15231 * procfs.c (procfs_target::pass_signals): Adjust.
15232 * record-full.c (record_full_target::resume): Adjust.
15233 * remote.c (remote_target::pass_signals)
15234 (remote_target::program_signals): Adjust.
15235 * target-debug.h (target_debug_print_signals): Now takes a
15236 gdb::array_view as parameter. Adjust.
15237 * target.h (target_ops) <pass_signals, program_signals>: Replace
15238 pointer and length parameters with gdb::array_view.
15239 (target_pass_signals, target_program_signals): Likewise.
15240 * target-delegates.c: Regenerate.
15241
15242 2019-01-24 Pedro Alves <palves@redhat.com>
15243
15244 * common/forward-scope-exit.h
15245 (forward_scope_exit::forward_scope_exit): Pass arguments to
15246 m_bind_function directly, instead of creating a std::bind and
15247 copying that.
15248
15249 2019-01-24 Alan Hayward <alan.hayward@arm.com>
15250
15251 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15252 for static members.
15253 (pass_in_v_vfp_candidate): Likewise.
15254
15255 2019-01-23 Tom Tromey <tom@tromey.com>
15256 Pedro Alves <palves@redhat.com>
15257
15258 * regcache.c (class regcache_invalidator): Remove.
15259 (regcache::raw_write): Use make_scope_exit.
15260
15261 2019-01-23 Tom Tromey <tom@tromey.com>
15262
15263 * ui-out.h (class ui_out_emit_type): Update comment.
15264
15265 2019-01-23 Tom Tromey <tom@tromey.com>
15266
15267 * infrun.c (fetch_inferior_event): Update comment.
15268
15269 2019-01-23 Tom Tromey <tom@tromey.com>
15270 Pedro Alves <palves@redhat.com>
15271
15272 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15273 parameter.
15274 (fetch_inferior_event): Use SCOPE_EXIT.
15275
15276
15277 2019-01-23 Tom Tromey <tom@tromey.com>
15278 Pedro Alves <palves@redhat.com>
15279
15280 * infrun.c (disable_thread_events): Delete.
15281 (stop_all_threads): Use SCOPE_EXIT.
15282
15283 2019-01-23 Tom Tromey <tom@tromey.com>
15284 Pedro Alves <palves@redhat.com>
15285
15286 * symfile.c: Include forward-scope-exit.h.
15287 (clear_symtab_users_cleanup): Replace forward declaration with
15288 a FORWARD_SCOPE_EXIT.
15289 (syms_from_objfile_1): Use the forward_scope_exit and
15290 gdb::optional instead of cleanup_function.
15291 (reread_symbols): Use the forward_scope_exit instead of
15292 cleanup_function.
15293 (clear_symtab_users_cleanup): Remove function.
15294
15295 2019-01-23 Tom Tromey <tom@tromey.com>
15296 Pedro Alves <palves@redhat.com>
15297
15298 * linux-nat.c: Include scope-exit.h.
15299 (cleanup_target_stop): Remove.
15300 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15301 SCOPE_EXIT.
15302
15303 2019-01-23 Tom Tromey <tom@tromey.com>
15304 Pedro Alves <palves@redhat.com>
15305
15306 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15307 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15308
15309 2019-01-23 Tom Tromey <tom@tromey.com>
15310 Andrew Burgess <andrew.burgess@embecosm.com>
15311 Pedro Alves <palves@redhat.com>
15312
15313 * infrun.c (fetch_inferior_event): Use scope_exit.
15314 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15315 * top.c (execute_command): Use scope_exit.
15316 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15317 * utils.c (do_bpstat_clear_actions_cleanup)
15318 (make_bpstat_clear_actions_cleanup): Remove.
15319
15320 2019-01-23 Tom Tromey <tom@tromey.com>
15321 Pedro Alves <palves@redhat.com>
15322
15323 * infrun.c: Include "common/scope-exit.h"
15324 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15325 (wait_for_inferior): Use SCOPE_EXIT.
15326 (fetch_inferior_event): Use scope_exit.
15327
15328 2019-01-23 Tom Tromey <tom@tromey.com>
15329 Pedro Alves <palves@redhat.com>
15330
15331 * breakpoint.c (create_breakpoint): Remove cleanup.
15332
15333 2019-01-23 Tom Tromey <tom@tromey.com>
15334 Andrew Burgess <andrew.burgess@embecosm.com>
15335 Pedro Alves <palves@redhat.com>
15336
15337 2019-01-23 Pedro Alves <palves@redhat.com>
15338
15339 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15340
15341 2019-01-23 Pedro Alves <palves@redhat.com>
15342 Andrew Burgess <andrew.burgess@embecosm.com>
15343
15344 * gdbthread.h: Include "common/forward-scope-exit.h".
15345 (scoped_finish_thread_state): Redefine custom class in terms of
15346 forward_scope_exit.
15347
15348 2019-01-23 Pedro Alves <palves@redhat.com>
15349 Andrew Burgess <andrew.burgess@embecosm.com>
15350
15351 * common/forward-scope-exit.h: New file.
15352
15353 2019-01-23 Pedro Alves <palves@redhat.com>
15354 Andrew Burgess <andrew.burgess@embecosm.com>
15355 Tom Tromey <tom@tromey.com>
15356
15357 * common/scope-exit.h: New file.
15358
15359 2019-01-23 Pedro Alves <palves@redhat.com>
15360
15361 * common/preprocessor.h (ESC): Rename to ...
15362 (ESC_PARENS): ... this.
15363 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15364 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15365
15366 2019-01-23 Tom Tromey <tom@tromey.com>
15367
15368 * language.h (class scoped_switch_to_sym_language_if_auto):
15369 Initialize m_lang in both cases.
15370
15371 2019-01-23 Alan Hayward <alan.hayward@arm.com>
15372
15373 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15374 with XCNEW.
15375
15376 2019-01-22 Tom Tromey <tom@tromey.com>
15377
15378 * corelow.c: Do not include sys/file.h.
15379
15380 2019-01-22 Tom Tromey <tom@tromey.com>
15381
15382 * tui/tui-wingeneral.h: Include gdb_curses.h.
15383
15384 2019-01-22 Tom Tromey <tom@tromey.com>
15385
15386 * source-cache.h (class source_cache) <get_source_lines,
15387 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15388
15389 2019-01-22 Tom Tromey <tom@tromey.com>
15390
15391 * remote-fileio.h (struct remote_target): Declare.
15392
15393 2019-01-22 Tom Tromey <tom@tromey.com>
15394
15395 * python/py-arch.c: Do not include py-ref.h.
15396 * python/py-bpevent.c: Do not include py-ref.h.
15397 * python/py-cmd.c: Do not include py-ref.h.
15398 * python/py-continueevent.c: Do not include py-ref.h.
15399 * python/py-event.h: Do not include py-ref.h.
15400 * python/py-evtregistry.c: Do not include py-ref.h.
15401 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15402 * python/py-frame.c: Do not include py-ref.h.
15403 * python/py-framefilter.c: Do not include py-ref.h.
15404 * python/py-function.c: Do not include py-ref.h.
15405 * python/py-infevents.c: Do not include py-ref.h.
15406 * python/py-linetable.c: Do not include py-ref.h.
15407 * python/py-objfile.c: Do not include py-ref.h.
15408 * python/py-param.c: Do not include py-ref.h.
15409 * python/py-prettyprint.c: Do not include py-ref.h.
15410 * python/py-progspace.c: Do not include py-ref.h.
15411 * python/py-symbol.c: Do not include py-ref.h.
15412 * python/py-symtab.c: Do not include py-ref.h.
15413 * python/py-type.c: Do not include py-ref.h.
15414 * python/py-unwind.c: Do not include py-ref.h.
15415 * python/py-utils.c: Do not include py-ref.h.
15416 * python/py-value.c: Do not include py-ref.h.
15417 * python/py-varobj.c: Do not include py-ref.h.
15418 * python/py-xmethods.c: Do not include py-ref.h.
15419 * python/python.c: Do not include py-ref.h.
15420 * varobj.c: Do not include py-ref.h.
15421
15422 2019-01-22 Tom Tromey <tom@tromey.com>
15423
15424 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15425 keyword for bcache.
15426
15427 2019-01-22 Tom Tromey <tom@tromey.com>
15428
15429 * compile/compile-cplus-types.c: Remove a comment by #include.
15430
15431 2019-01-22 Tom Tromey <tom@tromey.com>
15432
15433 * compile/gcc-c-plugin.h: Include compile-internal.h.
15434
15435 2019-01-22 Tom Tromey <tom@tromey.com>
15436
15437 * stabsread.c (EXTERN): Do not define.
15438 (symnum, next_symbol_text_func, processing_gcc_compilation)
15439 (within_function, global_sym_chain, global_stabs)
15440 (previous_stab_code, this_object_header_files)
15441 (n_this_object_header_files)
15442 (n_allocated_this_object_header_files): Define.
15443 * stabsread.h (EXTERN): Never define. Use "extern".
15444
15445 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15446
15447 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15448 history_value.
15449
15450 2019-01-21 Tom Tromey <tom@tromey.com>
15451
15452 * ui-out.c: Fix includes.
15453 * tui/tui-source.c: Fix includes.
15454 * target.c: Fix includes.
15455 * remote.c: Fix includes.
15456 * regcache.c: Fix includes.
15457 * python/py-block.c: Fix includes.
15458 * printcmd.c: Fix includes.
15459 * or1k-tdep.c: Fix includes.
15460 * mi/mi-main.c: Fix includes.
15461 * m32r-tdep.c: Fix includes.
15462 * csky-tdep.c: Fix includes.
15463 * compile/compile-cplus-types.c: Fix includes.
15464 * cli/cli-interp.c: Fix includes.
15465
15466 2019-01-21 Alan Hayward <alan.hayward@arm.com>
15467
15468 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15469 for padding.
15470
15471 2019-01-16 Tom Tromey <tom@tromey.com>
15472
15473 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15474 earlier.
15475 (struct objfile) <msymbols_range>: Move from top level.
15476 <msymbols>: New method.
15477 (class objfile_msymbols): Remove.
15478 * symtab.c (default_collect_symbol_completion_matches_break_on):
15479 Update.
15480 * symmisc.c (dump_msymbols): Update.
15481 * stabsread.c (scan_file_globals): Update.
15482 * objc-lang.c (info_selectors_command, info_classes_command)
15483 (find_methods): Update.
15484 * minsyms.c (find_solib_trampoline_target): Update.
15485 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15486 * coffread.c (coff_symfile_read): Update.
15487 * ada-lang.c (ada_lookup_simple_minsym)
15488 (ada_collect_symbol_completion_matches): Update.
15489
15490 2019-01-16 Tom Tromey <tom@tromey.com>
15491
15492 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15493 type. Remove no-argument constructor.
15494 <iterator::operator++>: Simplify.
15495 <begin>: Update.
15496 <end>: Use minimal_symbol_count.
15497
15498 2019-01-16 Tom Tromey <tom@tromey.com>
15499
15500 * objfiles.h (struct objfile) <psymtabs>: New method.
15501 (class objfile_psymtabs): Remove.
15502 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15503 typedef.
15504 <range>: New method.
15505 (require_partial_symbols): Change return type.
15506 * psymtab.c (require_partial_symbols)
15507 (psym_expand_symtabs_matching): Update.
15508 * mdebugread.c (parse_partial_symbols): Update.
15509 * dbxread.c (dbx_end_psymtab): Update.
15510
15511 2019-01-15 Tom Tromey <tom@tromey.com>
15512
15513 * symtab.c (lookup_objfile_from_block)
15514 (lookup_symbol_in_objfile_symtabs)
15515 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15516 (find_line_symtab, info_sources_command)
15517 (default_collect_symbol_completion_matches_break_on)
15518 (make_source_files_completion_list): Update.
15519 * symmisc.c (print_objfile_statistics, dump_objfile)
15520 (maintenance_print_symbols, maintenance_info_symtabs)
15521 (maintenance_check_symtabs, maintenance_info_line_tables):
15522 Update.
15523 * source.c (select_source_symtab)
15524 (forget_cached_source_info_for_objfile): Update.
15525 * objfiles.h (class objfile_compunits): Remove.
15526 (struct objfile) <compunits_range>: New typedef.
15527 (compunits): New method.
15528 * objfiles.c (objfile_relocate1): Update.
15529 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15530 * maint.c (count_symtabs_and_blocks): Update.
15531 * linespec.c (iterate_over_all_matching_symtabs): Update.
15532 * cp-support.c (add_symbol_overload_list_qualified): Update.
15533 * coffread.c (coff_symtab_read): Update.
15534 * ada-lang.c (add_nonlocal_symbols)
15535 (ada_collect_symbol_completion_matches)
15536 (ada_add_global_exceptions): Update.
15537
15538 2019-01-15 Tom Tromey <tom@tromey.com>
15539
15540 * progspace.h (program_space) <objfiles_safe_range>: New
15541 typedef.
15542 <objfiles_safe>: New method.
15543 * objfiles.h (class all_objfiles_safe): Remove.
15544 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15545 * jit.c (jit_inferior_exit_hook): Update.
15546
15547 2019-01-17 Tom Tromey <tom@tromey.com>
15548
15549 * progspace.h (program_space) <objfiles_range>: New typedef.
15550 <objfiles>: New method.
15551 <objfiles_head>: Rename from objfiles.
15552 (object_files): Update.
15553 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15554 * guile/scm-pretty-print.c
15555 (ppscm_find_pretty_printer_from_objfiles): Update.
15556 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15557 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15558 Update.
15559 * python/py-progspace.c (pspy_get_objfiles): Update.
15560 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15561 Update.
15562 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15563 (objfpy_lookup_objfile_by_build_id): Update.
15564 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15565 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15566 Update.
15567 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15568 (expand_symtab_containing_pc, lookup_objfile_from_block)
15569 (lookup_static_symbol, basic_lookup_transparent_type)
15570 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15571 (find_line_symtab, info_sources_command)
15572 (default_collect_symbol_completion_matches_break_on)
15573 (make_source_files_completion_list, find_main_name): Update.
15574 * symmisc.c (print_symbol_bcache_statistics)
15575 (print_objfile_statistics, maintenance_print_symbols)
15576 (maintenance_print_msymbols, maintenance_print_objfiles)
15577 (maintenance_info_symtabs, maintenance_check_symtabs)
15578 (maintenance_expand_symtabs, maintenance_info_line_tables):
15579 Update.
15580 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15581 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15582 (map_overlay_command, unmap_overlay_command)
15583 (simple_overlay_update, expand_symtabs_matching)
15584 (map_symbol_filenames): Update.
15585 * symfile-debug.c (set_debug_symfile): Update.
15586 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15587 Update.
15588 * source.c (select_source_symtab, forget_cached_source_info):
15589 Update.
15590 * solib.c (solib_read_symbols): Update.
15591 * solib-spu.c (append_ocl_sos): Update.
15592 * psymtab.c (maintenance_print_psymbols)
15593 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15594 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15595 * printcmd.c (info_symbol_command): Update.
15596 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15597 Update.
15598 * objfiles.h (class all_objfiles): Remove.
15599 * objfiles.c (have_partial_symbols, have_full_symbols)
15600 (have_minimal_symbols, qsort_cmp, update_section_map)
15601 (shared_objfile_contains_address_p)
15602 (default_iterate_over_objfiles_in_search_order): Update.
15603 * objc-lang.c (info_selectors_command, info_classes_command)
15604 (find_methods): Update.
15605 * minsyms.c (find_solib_trampoline_target): Update.
15606 * maint.c (maintenance_info_sections)
15607 (maintenance_translate_address, count_symtabs_and_blocks):
15608 Update.
15609 * main.c (captured_main_1): Update.
15610 * linux-thread-db.c (try_thread_db_load_from_pdir)
15611 (has_libpthread): Update.
15612 * linespec.c (iterate_over_all_matching_symtabs)
15613 (search_minsyms_for_name): Update.
15614 * jit.c (jit_find_objf_with_entry_addr): Update.
15615 * hppa-tdep.c (find_unwind_entry)
15616 (hppa_lookup_stub_minimal_symbol): Update.
15617 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15618 Update.
15619 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15620 (elf_gnu_ifunc_resolve_by_got): Update.
15621 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15622 * dwarf-index-write.c (save_gdb_index_command): Update.
15623 * cp-support.c (add_symbol_overload_list_qualified): Update.
15624 * breakpoint.c (create_overlay_event_breakpoint)
15625 (create_longjmp_master_breakpoint)
15626 (create_std_terminate_master_breakpoint)
15627 (create_exception_master_breakpoint): Update.
15628 * blockframe.c (find_pc_partial_function): Update.
15629 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15630 (ada_collect_symbol_completion_matches)
15631 (ada_add_global_exceptions): Update.
15632
15633 2019-01-17 Tom Tromey <tom@tromey.com>
15634
15635 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15636 declare VEC.
15637 (solib_target_parse_libraries): Change return type.
15638 (library_list_start_segment, library_list_start_section)
15639 (library_list_end_library, library_list_start_library); Update.
15640 (solib_target_free_library_list): Remove.
15641 (solib_target_parse_libraries): Remove cleanup. Change return
15642 type.
15643 (solib_target_current_sos): Update.
15644
15645 2019-01-17 Tom Tromey <tromey@bapiya>
15646
15647 * valprint.c: Replace "the the" with "the".
15648 * symtab.c: Replace "the the" with "the".
15649 * solib.c: Replace "the the" with "the".
15650 * solib-dsbt.c: Replace "the the" with "the".
15651 * linespec.c: Replace "the the" with "the".
15652 * dwarf2loc.h: Replace "the the" with "the".
15653 * amd64-windows-tdep.c: Replace "the the" with "the".
15654 * aarch64-tdep.c: Replace "the the" with "the".
15655
15656 2019-01-16 Keith Seitz <keiths@redhat.com>
15657
15658 PR gdb/23773
15659 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15660 <builder>: Rename to ..
15661 <m_builder>: ... this and make private.
15662 (dwarf2_cu::get_builder): New method. Change all users of
15663 `builder' to use this method.
15664 (dwarf2_start_symtab): Move to ...
15665 (dwarf2_cu::start_symtab): ... here. Update all callers
15666 (setup_type_unit_groups): Move to ...
15667 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15668 callers.
15669 (dwarf2_cu::reset_builder): New method.
15670 (process_full_compunit, process_full_type_unit): Use
15671 dwarf2_cu::reset_builder.
15672 (follow_die_offset): Record the ancestor CU if it is different
15673 from the followed DIE's CU.
15674 (follow_die_sig_1): Likewise.
15675
15676 2019-01-15 Tom Tromey <tom@tromey.com>
15677
15678 * remote.c (class remote_state) <buf>: Now a char_vector.
15679 <buf_size>: Remove.
15680 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15681 parameter.
15682 (remote_target::getpkt_or_notif_sane_1)
15683 (remote_target::getpkt_sane)
15684 (remote_target::getpkt_or_notif_sane): Likewise.
15685 (class remote_target) <putpkt>: New overload.
15686 (remote_target::read_frame): Change type of "buf_p". Remove
15687 sizeof_p parameter.
15688 (packet_ok): New overload.
15689 (packet_check_result): New overload.
15690 Update all uses.
15691
15692 2019-01-14 Tom Tromey <tom@tromey.com>
15693
15694 * remote-notif.c (handle_notification, remote_notif_ack)
15695 (remote_notif_parse): Make "buf" const.
15696 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15697 const.
15698 (remote_notif_parse, remote_notif_ack, handle_notification):
15699 Likewise.
15700 * remote.c (remote_notif_stop_parse): Make "buf" const.
15701 (remote_target::remote_parse_stop_reply): Make "buf" const.
15702 (remote_notif_stop_ack): Make "buf" const.
15703
15704 2019-01-14 Tom Tromey <tom@tromey.com>
15705
15706 * remote.c (remote_console_output): Make parameter const.
15707
15708 2019-01-14 Tom Tromey <tom@tromey.com>
15709
15710 * target-debug.h (target_debug_print_signals): Constify.
15711 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15712 * procfs.c (procfs_target::pass_signals): Update.
15713 * linux-nat.c (linux_nat_target::pass_signals): Update.
15714 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15715 * target-delegates.c: Rebuild.
15716 * remote.c (remote_target::program_signals): Update.
15717 (remote_target::pass_signals): Update.
15718 * target.c (target_pass_signals): Constify argument.
15719 (target_program_signals): Likewise.
15720 * target.h (struct target_ops) <pass_signals, program_signals>:
15721 Constify argument.
15722 (target_pass_signals, target_program_signals): Constify argument.
15723
15724 2019-01-14 Tom Tromey <tom@tromey.com>
15725
15726 PR tui/28819:
15727 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15728
15729 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15730
15731 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15732 field.
15733 * rs6000-tdep.c: Include reggroups.h.
15734 (IS_V_ALIAS_PSEUDOREG): Define.
15735 (rs6000_register_name): Return names for the "vX" aliases.
15736 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15737 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15738 aliases. Call default_register_reggroup_p for all other
15739 pseudo-registers.
15740 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15741 New functions.
15742 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15743 Handle "vX" aliases.
15744 (v_alias_pseudo_register_collect): New function.
15745 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15746 (rs6000_gdbarch_init): Initialize "vX" aliases as
15747 pseudo-registers. Restore registration of
15748 rs6000_pseudo_register_reggroup_p with
15749 set_tdesc_pseudo_register_reggroup_p.
15750
15751 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15752
15753 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15754 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15755 set_gdbarch_num_pseudo_regs.
15756
15757 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15758
15759 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15760 Remove arg prefixname, add do_set and do_show.
15761 Add member functions set_list and show_list.
15762 * cli/cli-style.c (class cli_style_option): Update accordingly.
15763 (style_set_list): Move to file scope.
15764 (style_show_list): Likewise.
15765 (set_style): Call help_list.
15766 (show_style): Call cmd_show_list.
15767 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15768 Update to use the new macro.
15769
15770 2019-10-12 Joel Brobecker <brobecker@adacore.com>
15771
15772 * ada-lang.c (_initialize_ada_language): Expand the help text
15773 for the "catch exception" command.
15774
15775 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15776
15777 * symtab.c (matching_obj_sections): Initialize obj,
15778 declare it closer to its usage.
15779
15780 2019-01-10 Tom Tromey <tom@tromey.com>
15781
15782 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15783 (basic_inf_threads_range): Remove.
15784 (inf_threads_range, inf_non_exited_threads_range)
15785 (safe_inf_threads_range): Use next_adapter.
15786
15787 2019-01-10 Keith Seitz <keiths@redhat.com>
15788
15789 PR gdb/23712
15790 PR symtab/23010
15791 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15792 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15793
15794 2019-01-10 Keith Seitz <keiths@redhat.com>
15795
15796 PR gdb/23712
15797 PR symtab/23010
15798 * dictionary.c (pending_to_vector): Remove.
15799 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15800 Remove _1 suffix, replacing functions of the same name. Update
15801 all callers.
15802 (dict_create_hashed, dict_create_hashed_expandable)
15803 (dict_create_linear, dict_create_linear_expandable, dict_free)
15804 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15805 Make functions static.
15806
15807 2019-01-10 Keith Seitz <keiths@redhat.com>
15808
15809 PR gdb/23712
15810 PR symtab/23010
15811 * dictionary.h (struct dictionary): Replace declaration with
15812 multidictionary.
15813 (dict_create_hashed, dict_create_hashed_expandable)
15814 (dict_create_linear, dict_create_linear_expandable)
15815 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15816 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15817 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15818 taking multidictionary argument.
15819 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15820 * block.h (struct block) <dict>: Change to multidictionary
15821 and rename `multidict'.
15822 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15823 symmisc.c: Update all dictionary references to multidictionary.
15824
15825 2019-01-10 Keith Seitz <keiths@redhat.com>
15826
15827 PR gdb/23712
15828 PR symtab/23010
15829 * dictionary.c: Include unordered_map.
15830 (pending_to_vector): New function.
15831 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15832 Rewrite the non-"_1" functions to take vector instead
15833 of linked list.
15834 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15835 "new" _1 versions of the same name.
15836 (multidictionary): Define.
15837 (std::hash<enum language): New definition.
15838 (collate_pending_symbols_by_language, mdict_create_hashed)
15839 (mdict_create_hashed_expandable, mdict_create_linear)
15840 (mdict_create_linear_expandable, mdict_free)
15841 (find_language_dictionary, create_new_language_dictionary)
15842 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15843 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15844 (mdict_size, mdict_empty): New functions.
15845 * dictionary.h (mdict_iterator): Define.
15846
15847 2019-01-10 Pedro Alves <palves@redhat.com>
15848
15849 * breakpoint.c (read_uploaded_action)
15850 (create_tracepoint_from_upload): Adjust to use
15851 gdb::unique_xmalloc_ptr.
15852 * ctf.c (ctf_write_uploaded_tp):
15853 (SET_ARRAY_FIELD): Use emplace_back.
15854 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15855 * tracefile-tfile.c (tfile_write_uploaded_tp):
15856 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15857 gdb::unique_xmalloc_ptr.
15858 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15859 at_string, cond_string, cmd_strings>: Replace char pointers
15860 with gdb::unique_xmalloc_ptr.
15861
15862 2019-01-10 Pedro Alves <palves@redhat.com>
15863
15864 * solib-target.c (library_list_start_library): Don't xstrdup name.
15865
15866 2019-01-10 Pedro Alves <palves@redhat.com>
15867
15868 * mdebugread.c (parse_partial_symbols): Use
15869 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15870
15871 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15872
15873 * linux-fork.c (scoped_switch_fork_info)
15874 <~scoped_switch_fork_info>: Fix incorrect variable name.
15875
15876 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15877
15878 * linux-fork.c (scoped_switch_fork_info)
15879 <scoped_switch_fork_info>: Make explicit.
15880 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15881
15882 2019-01-10 Tom Tromey <tom@tromey.com>
15883
15884 * objfiles.h (objfile::reset_psymtabs): Update.
15885 * objfiles.c (objfile::objfile): Update.
15886 * psymtab.h (psymtab_storage::obstack): Update.
15887 (psymtab_storage::m_obstack): Use gdb::optional.
15888 (class psymtab_storage): Update comment. Remove objfile
15889 parameter.
15890 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15891
15892 2019-01-10 Tom Tromey <tom@tromey.com>
15893
15894 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15895 <free_psymtabs>: Now private.
15896 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15897 (allocate_psymtab): Use new method.
15898
15899 2019-01-10 Tom Tromey <tom@tromey.com>
15900
15901 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15902 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15903 * mdebugread.c (parse_partial_symbols): Use
15904 allocate_dependencies.
15905 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15906 allocate_dependencies.
15907 (process_psymtab_comp_unit_reader)
15908 (build_type_psymtab_dependencies): Likewise.
15909 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15910
15911 2019-01-10 Tom Tromey <tom@tromey.com>
15912
15913 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15914 PSYMBOL_SET_LANGUAGE.
15915 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15916
15917 2019-01-10 Tom Tromey <tom@tromey.com>
15918
15919 * psymtab.h (psymtab_storage::obstack): New method.
15920 <m_obstack>: Rename from obstack; now private.
15921 * psymtab.c (psymtab_storage): Update.
15922 * dwarf2read.c (create_addrmap_from_index)
15923 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15924 Update.
15925
15926 2019-01-10 Tom Tromey <tom@tromey.com>
15927
15928 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15929 * objfiles.h (objfile::reset_psymtabs): New method.
15930
15931 2019-01-10 Tom Tromey <tom@tromey.com>
15932
15933 * symmisc.c (print_symbol_bcache_statistics): Update.
15934 (print_objfile_statistics): Update.
15935 * symfile.c (reread_symbols): Update.
15936 * psymtab.h (class psymtab_storage): New.
15937 * psymtab.c (psymtab_storage): New constructor.
15938 (~psymtab_storage): New destructor.
15939 (require_partial_symbols): Update.
15940 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15941 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15942 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15943 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15944 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15945 (start_psymtab_common, end_psymtab_common)
15946 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15947 (allocate_psymtab): Update.
15948 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15949 Update.
15950 (dump_psymtab_addrmap, maintenance_print_psymbols)
15951 (maintenance_check_psymtabs): Update.
15952 (class objfile_psymtabs): Move to objfiles.h.
15953 * psympriv.h (discard_psymtab): Now inline.
15954 (psymtab_discarder::psymtab_discarder): Update.
15955 (psymtab_discarder::~psymtab_discarder): Update.
15956 (ALL_OBJFILE_PSYMTABS): Rewrite.
15957 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15958 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15959 Remove fields.
15960 <partial_symtabs>: New field.
15961 (class objfile_psymtabs): Move from psymtab.h. Update.
15962 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15963 psymbol_cache.
15964 (objfile::~objfile): Don't destroy psymbol_cache.
15965 * mdebugread.c (parse_partial_symbols): Update.
15966 * dwarf2read.c (create_addrmap_from_index)
15967 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15968 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15969 (add_partial_subprogram, dwarf2_ranges_read): Update.
15970 * dwarf-index-write.c (write_address_map)
15971 (write_one_signatured_type, recursively_write_psymbols)
15972 (class debug_names, class debug_names, write_psymtabs_to_index):
15973 Update.
15974
15975 2019-01-10 Tom Tromey <tom@tromey.com>
15976
15977 * symtab.h (SYMBOL_SET_NAMES): Update.
15978 (symbol_set_names): Update.
15979 (MSYMBOL_SET_NAMES): Update.
15980 * symtab.c (symbol_set_names): Change argument to be an
15981 objfile_per_bfd_storage.
15982 * psymtab.c (add_psymbol_to_bcache): Update.
15983 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15984
15985 2019-01-10 Tom Tromey <tom@tromey.com>
15986
15987 * symtab.c (create_demangled_names_hash): Change argument to be an
15988 objfile_per_bfd_storage.
15989 (symbol_set_names): Update.
15990
15991 2019-01-10 Tom Tromey <tom@tromey.com>
15992
15993 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15994 init_psymbol_list.
15995 * psymtab.c (init_psymbol_list): Do nothing if already called.
15996 * psympriv.h (init_psymbol_list): Add comment.
15997 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15998 init_psymbol_list.
15999 * dbxread.c (dbx_symfile_read): Unconditionally call
16000 init_psymbol_list.
16001
16002 2019-01-10 Tom Tromey <tom@tromey.com>
16003
16004 * xcoffread.c (scan_xcoff_symtab): Update.
16005 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16006 "where".
16007 * mdebugread.c (parse_partial_symbols)
16008 (handle_psymbol_enumerators): Update.
16009 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16010 * dbxread.c (read_dbx_symtab): Update.
16011 * psympriv.h (psymbol_placement): New enum.
16012 (add_psymbol_to_list): Update.
16013
16014 2019-01-10 Tom Tromey <tom@tromey.com>
16015
16016 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16017 static_psymbols parameters.
16018 (scan_xcoff_symtab): Update.
16019 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16020 static_psymbols parameters.
16021 * psympriv.h (start_psymtab_common): Update.
16022 * mdebugread.c (parse_partial_symbols): Update.
16023 * dwarf2read.c (create_partial_symtab): Update.
16024 * dbxread.c (read_dbx_symtab): Update.
16025 (start_psymtab): Remove global_psymbols and static_psymbols
16026 parameters.
16027
16028 2019-01-10 Tom Tromey <tom@tromey.com>
16029
16030 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16031 * psymtab.c (allocate_psymtab): Add comment.
16032 * psympriv.h (allocate_psymtab): Add comment.
16033 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16034 initializations.
16035 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16036
16037 2019-01-10 Tom Tromey <tom@tromey.com>
16038
16039 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16040 Don't declare.
16041 * mipsread.c: Include mdebugread.h.
16042 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16043 Declare.
16044 * elfread.c: Include mdebugread.h.
16045
16046 2019-01-09 Tom Tromey <tom@tromey.com>
16047
16048 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16049 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16050 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16051 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16052 (psym_lookup_symbol, psym_find_last_source_symtab)
16053 (psym_forget_cached_source_info, psym_print_stats)
16054 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16055 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16056 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16057 (psym_find_compunit_symtab_by_address)
16058 (maintenance_print_psymbols, maintenance_info_psymtabs)
16059 (maintenance_check_psymtabs): Use ranged for.
16060 * psymtab.h (class objfile_psymtabs): New.
16061 (require_partial_symbols): Return objfile_psymtabs.
16062 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16063
16064 2019-01-09 Tom Tromey <tom@tromey.com>
16065
16066 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16067 (find_pc_mapped_section, list_overlays_command)
16068 (map_overlay_command, unmap_overlay_command)
16069 (simple_overlay_update): Use all_objfiles.
16070 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16071 * printcmd.c (info_symbol_command): Use all_objfiles.
16072 * objfiles.h (ALL_OBJSECTIONS): Remove.
16073 * maint.c (maintenance_translate_address): Use all_objfiles.
16074 * gcore.c (gcore_create_callback): Use all_objfiles.
16075 (objfile_find_memory_regions): Likewise.
16076
16077 2019-01-09 Tom Tromey <tom@tromey.com>
16078
16079 * symtab.c (find_line_symtab, info_sources_command)
16080 (make_source_files_completion_list): Use objfile_compunits.
16081 * source.c (select_source_symtab): Use objfile_compunits.
16082 * objfiles.h (struct objfile): Update comment.
16083 (ALL_OBJFILES): Remove.
16084 (ALL_FILETABS): Remove.
16085 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16086 objfile_compunits.
16087
16088 2019-01-09 Tom Tromey <tom@tromey.com>
16089
16090 * symmisc.c (print_objfile_statistics, dump_objfile)
16091 (maintenance_print_symbols): Use compunit_filetabs.
16092 * source.c (forget_cached_source_info_for_objfile): Use
16093 compunit_filetabs.
16094 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16095 (ALL_FILETABS): Use compunit_filetabs.
16096 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16097 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16098
16099 2019-01-09 Tom Tromey <tom@tromey.com>
16100
16101 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16102 (compunit_filetabs): New.
16103 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16104 compunit_filetabs.
16105 (info_sources_command, make_source_files_completion_list): Remove
16106 declaration.
16107 * symmisc.c (print_objfile_statistics, dump_objfile)
16108 (maintenance_print_symbols): Remove declaration.
16109 (maintenance_info_symtabs): Use compunit_filetabs.
16110 (maintenance_info_line_tables): Likewise.
16111 * source.c (select_source_symtab): Change local variable name.
16112 (forget_cached_source_info_for_objfile): Remove declaration.
16113 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16114 * objfiles.c (objfile_relocate1): Remove declaration.
16115 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16116 declaration.
16117 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16118 * coffread.c (coff_symtab_read): Remove declaration.
16119 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16120 compunit_filetabs.
16121
16122 2019-01-09 Tom Tromey <tom@tromey.com>
16123
16124 * symtab.c (lookup_objfile_from_block)
16125 (find_pc_sect_compunit_symtab, search_symbols)
16126 (default_collect_symbol_completion_matches_break_on): Use
16127 objfile_compunits.
16128 * objfiles.h (ALL_COMPUNITS): Remove.
16129 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16130 * cp-support.c (add_symbol_overload_list_qualified): Use
16131 objfile_compunits.
16132 * ada-lang.c (ada_collect_symbol_completion_matches)
16133 (ada_add_global_exceptions): Use objfile_compunits.
16134
16135 2019-01-09 Tom Tromey <tom@tromey.com>
16136
16137 * source.c (select_source_symtab)
16138 (forget_cached_source_info_for_objfile): Remove declaration.
16139 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16140 declaration.
16141 * maint.c (count_symtabs_and_blocks): Remove declaration.
16142 * cp-support.c (add_symbol_overload_list_qualified): Remove
16143 declaration.
16144 * coffread.c (coff_symtab_read): Remove declaration.
16145 * symtab.c (lookup_symbol_in_objfile_symtabs)
16146 (basic_lookup_transparent_type_1): Use objfile_compunits.
16147 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16148 (info_sources_command, search_symbols)
16149 (default_collect_symbol_completion_matches_break_on)
16150 (make_source_files_completion_list): Remove declaration.
16151 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16152 (ada_collect_symbol_completion_matches)
16153 (ada_add_global_exceptions): Remove declaration.
16154 * linespec.c (iterate_over_all_matching_symtabs): Use
16155 objfile_compunits.
16156 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16157 (class objfile_compunits): New.
16158 (ALL_COMPUNITS): Use objfile_compunits.
16159 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16160 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16161 objfile_compunits.
16162 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16163
16164 2019-01-09 Tom Tromey <tom@tromey.com>
16165
16166 * symtab.c (search_symbols)
16167 (default_collect_symbol_completion_matches_break_on): Use
16168 objfile_msymbols.
16169 * ada-lang.c (ada_lookup_simple_minsym)
16170 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16171 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16172 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16173 objfile_msymbols.
16174 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16175 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16176 * objc-lang.c (find_methods): Use objfile_msymbols.
16177 (info_selectors_command, info_classes_command): Likewise.
16178 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16179 * objfiles.h (class objfile_msymbols): New.
16180 (ALL_OBJFILE_MSYMBOLS): Remove.
16181 (ALL_MSYMBOLS): Remove.
16182
16183 2019-01-09 Tom Tromey <tom@tromey.com>
16184
16185 * common/next-iterator.h (next_adapter): Add Iterator template
16186 parameter.
16187 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16188 (class all_objfiles_safe): New.
16189 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16190 * objfiles.c (put_objfile_before): Update comment.
16191 (add_separate_debug_objfile): Likewise.
16192 (free_all_objfiles): Use all_objfiles_safe.
16193 (objfile_purge_solibs): Likewise.
16194
16195 2019-01-09 Tom Tromey <tom@tromey.com>
16196
16197 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16198 (expand_symtab_containing_pc, lookup_static_symbol)
16199 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16200 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16201 all_objfiles.
16202 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16203 * breakpoint.c (create_overlay_event_breakpoint)
16204 (create_longjmp_master_breakpoint)
16205 (create_std_terminate_master_breakpoint)
16206 (create_exception_master_breakpoint): Use all_objfiles.
16207 * linux-thread-db.c (try_thread_db_load_from_pdir)
16208 (has_libpthread): Use all_objfiles.
16209 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16210 * linespec.c (iterate_over_all_matching_symtabs)
16211 (search_minsyms_for_name): Use all_objfiles.
16212 * maint.c (maintenance_info_sections): Use all_objfiles.
16213 * main.c (captured_main_1): Use all_objfiles.
16214 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16215 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16216 * guile/scm-pretty-print.c
16217 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16218 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16219 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16220 (maintenance_print_msymbols): Use all_objfiles.
16221 * source.c (select_source_symtab): Use all_objfiles.
16222 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16223 * symfile.c (remove_symbol_file_command)
16224 (expand_symtabs_matching, map_symbol_filenames): Use
16225 all_objfiles.
16226 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16227 all_objfiles.
16228 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16229 * objc-lang.c (find_methods): Use all_objfiles.
16230 * objfiles.c (have_partial_symbols, have_full_symbols)
16231 (have_minimal_symbols, qsort_cmp)
16232 (default_iterate_over_objfiles_in_search_order): Use
16233 all_objfiles.
16234 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16235 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16236 (maintenance_check_psymtabs): Use all_objfiles.
16237 (ALL_PSYMTABS): Remove.
16238 * compile/compile-object-run.c (do_module_cleanup): Use
16239 all_objfiles.
16240 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16241 * cp-support.c (add_symbol_overload_list_qualified): Use
16242 all_objfiles.
16243 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16244 Use all_objfiles.
16245 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16246 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16247 all_objfiles.
16248 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16249 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16250 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16251 Uses all_objfiles.
16252 * solib.c (solib_read_symbols): Use all_objfiles
16253
16254 2019-01-09 Tom Tromey <tom@tromey.com>
16255
16256 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16257 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16258 all_objfiles.
16259 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16260 * symmisc.c (print_symbol_bcache_statistics)
16261 (print_objfile_statistics, maintenance_print_objfiles)
16262 (maintenance_info_symtabs, maintenance_check_symtabs)
16263 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16264 all_objfiles.
16265 * source.c (forget_cached_source_info): Use all_objfiles.
16266 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16267 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16268 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16269 * objfiles.c (update_section_map): Use all_objfiles.
16270 (shared_objfile_contains_address_p): Likewise.
16271 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16272 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16273
16274 2019-01-09 Tom Tromey <tom@tromey.com>
16275
16276 * common/next-iterator.h: New file.
16277 * objfiles.h (class all_objfiles): New.
16278 (struct objfile_iterator): New.
16279
16280 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16281
16282 * NEWS: Move the description of the changed "frame", "select-frame",
16283 and "info frame" commands to the Changed commands section.
16284
16285 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16286
16287 * gdbtypes.c (check_stub_method_group): Remove handling of old
16288 mangling schemes.
16289 * linespec.c (find_methods): Likewise.
16290 * stabsread.c (read_member_functions): Likewise.
16291 * valops.c (search_struct_method): Likewise.
16292 (value_struct_elt_for_reference): Likewise.
16293 * NEWS: Mention this change.
16294
16295 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16296
16297 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16298 print_source_lines.
16299 * source.c (print_source_lines_base): Update line number check.
16300 (print_source_lines): New function.
16301 (source_lines_range::source_lines_range): New function.
16302 * source.h (class source_lines_range): New class.
16303 (print_source_lines): New declaration.
16304
16305 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16306
16307 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16308
16309 2019-01-08 Tom Tromey <tom@tromey.com>
16310 Simon Marchi <simon.marchi@ericsson.com>
16311
16312 PR gdb/24060
16313 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16314 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16315 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16316 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16317 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16318 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16319
16320 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16321
16322 * source.c (select_source_symtab): Move header comment to
16323 declaration in source.h.
16324 (forget_cached_source_info_for_objfile): Likewise.
16325 (forget_cached_source_info): Likewise.
16326 (identify_source_line): Likewise.
16327 * source.h (identify_source_line): Move declaration from symtab.h
16328 and add comment from source.c
16329 (print_source_lines): Likewise.
16330 (forget_cached_source_info_for_objfile): Likewise.
16331 (forget_cached_source_info): Likewise.
16332 (select_source_symtab): Likewise.
16333 (enum print_source_lines_flag): Move definition from symtab.h.
16334 * symtab.h (identify_source_line): Move declaration to source.h.
16335 (print_source_lines): Likewise.
16336 (forget_cached_source_info_for_objfile): Likewise.
16337 (forget_cached_source_info): Likewise.
16338 (select_source_symtab): Likewise.
16339 (enum print_source_lines_flag): Move definition to source.h.
16340 * tui/tui-hooks.c: Add 'source.h' include.
16341
16342 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16343
16344 * source.c (print_source_lines_base): Handle requests to print
16345 reverse line number sequences, and guard against empty lines
16346 string.
16347
16348 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16349
16350 * source.c (print_source_lines_base): Fix skip of '\r' if next
16351 character is '\n'.
16352
16353 2019-01-06 Tom Tromey <tom@tromey.com>
16354
16355 * c-exp.y (struct c_parse_state) <macro_original_text,
16356 expansion_obstack>: New member.
16357 (macro_original_text, expansion_obstack): Remove globals.
16358 (scan_macro_expansion, scanning_macro_expansion)
16359 (finished_macro_expansion): Update.
16360 (scan_macro_cleanup): Remove.
16361 (yylex, c_parse): Update.
16362
16363 2019-01-06 Tom Tromey <tom@tromey.com>
16364
16365 * c-exp.y (struct c_parse_state) <strings>: New member.
16366 (operator_stoken): Update.
16367
16368 2019-01-06 Tom Tromey <tom@tromey.com>
16369
16370 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16371 (union type_stack_elt) <typelist_val>: Now a pointer to
16372 std::vector.
16373 (type_stack_cleanup): Don't declare.
16374 (push_typelist): Update.
16375 * parse.c (pop_typelist): Return a std::vector.
16376 (push_typelist): Take a std::vector.
16377 (follow_types): Update. Do not free args.
16378 (type_stack_cleanup): Remove.
16379 * c-exp.y (struct c_parse_state): New.
16380 (cpstate): New global.
16381 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16382 (nonempty_typelist): Update.
16383 (func_mod): Create a new vector.
16384 (c_parse): Create a c_parse_state.
16385 (check_parameter_typelist): Do not delete params.
16386 (function_method): Update. Do not delete type_list.
16387
16388 2019-01-06 Tom Tromey <tom@tromey.com>
16389
16390 PR gdb/28155:
16391 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16392 check_typedef.
16393 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16394 (print_return_value): Likewise.
16395
16396 2019-01-05 Tom Tromey <tom@tromey.com>
16397
16398 * contrib/cleanup_check.py: Remove.
16399 * contrib/gcc-with-excheck: Remove.
16400 * contrib/exsummary.py: Remove.
16401 * contrib/excheck.py: Remove.
16402
16403 2019-01-05 Joel Brobecker <brobecker@adacore.com>
16404
16405 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16406 NULL. Initialize tpprev to NULL instead of assigning it
16407 to NULL on the next statement.
16408 * windows-nat.c (windows_delete_thread): Remove check for
16409 main_thread_id before printing thread exit notifications.
16410 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16411 Remove thread ID check against main_thread_id.
16412 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16413 windows_delete_thread.
16414 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16415
16416 2019-01-04 Tom Tromey <tom@tromey.com>
16417
16418 * compile/compile.c (_initialize_compile): Use upper case for
16419 metasyntactic variables.
16420 * symmisc.c (_initialize_symmisc): Use upper case for
16421 metasyntactic variables.
16422 * psymtab.c (_initialize_psymtab): Use upper case for
16423 metasyntactic variables.
16424 * demangle.c (demangle_command): Use upper case for metasyntactic
16425 variables.
16426 (_initialize_demangler): Likewise.
16427 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16428 variables.
16429
16430 2019-01-03 Tom Tromey <tom@tromey.com>
16431
16432 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16433
16434 2019-01-03 Tom Tromey <tom@tromey.com>
16435
16436 * python/py-symtab.c (salpy_str): Update.
16437 (struct salpy_sal_object) <symtab>: Now a PyObject.
16438 (salpy_dealloc): Update.
16439 (del_objfile_sal): Use gdbpy_ref.
16440
16441 2019-01-03 Tom Tromey <tom@tromey.com>
16442
16443 * python/py-type.c (convert_field): Use new_reference. Return
16444 gdbpy_ref.
16445 (make_fielditem): Return gdbpy_ref.
16446 (typy_fields): Update.
16447 (typy_getitem): Update.
16448 (field_name): Return gdbpy_ref. Use new_reference.
16449 (typy_iterator_iternext): Update.
16450
16451 2019-01-03 Tom Tromey <tom@tromey.com>
16452
16453 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16454
16455 2019-01-03 Tom Tromey <tom@tromey.com>
16456
16457 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16458 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16459 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16460 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16461 (pspy_set_type_printers): Likewise.
16462 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16463 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16464 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16465 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16466 (objfpy_set_type_printers): Likewise.
16467
16468 2019-01-03 Tom Tromey <tom@tromey.com>
16469
16470 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16471 (gdbpy_print_stack): Use gdbpy_err_fetch.
16472 * python/python-internal.h (class gdbpy_err_fetch): New class.
16473 (class gdbpy_enter) <m_error_type, m_error_value,
16474 m_error_traceback>: Remove.
16475 <m_error>: New member.
16476 (gdbpy_exception_to_string): Don't declare.
16477 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16478 * python/py-value.c (convert_value_from_python): Use
16479 gdbpy_err_fetch.
16480 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16481 gdbpy_exception_to_string.
16482 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16483 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16484 gdbpy_err_fetch.
16485
16486 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16487
16488 * linux-nat.c (delete_lwp_cleanup): Delete.
16489 (struct lwp_deleter): New struct.
16490 (lwp_info_up): New typedef.
16491 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16492 lwp_info_up.
16493
16494 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16495
16496 * linux-fork.c (class scoped_switch_fork_info): New class.
16497 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16498
16499 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16500
16501 * valops.c (find_overload_match): Remove use of null_cleanup, and
16502 calls to do_cleanups.
16503
16504 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16505
16506 * compile/compile-cplus-types.c
16507 (compile_cplus_instance::decl_name): Handle changes to
16508 cp_func_name.
16509 * cp-support.c (cp_func_name): Update header comment, update
16510 return type.
16511 * cp-support.h (cp_func_name): Update return type in declaration.
16512 * valops.c (find_overload_match): Move temp_func local to top
16513 level of function and change its type. Use temp_func to hold and
16514 delete temporary string obtained from cp_func_name.
16515
16516 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16517
16518 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16519 gdb::char_vector, remove cleanup, and update uses of `msg`.
16520
16521 2019-01-03 Jim Wilson <jimw@sifive.com>
16522
16523 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16524
16525 2019-01-02 Tom Tromey <tom@tromey.com>
16526
16527 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16528 (tdesc_parse_xml): Remove cleanups.
16529 * target-descriptions.h (make_cleanup_free_target_description):
16530 Don't declare.
16531 (target_desc_deleter): New struct.
16532 (target_desc_up): New typedef.
16533 * target-descriptions.c (target_desc_deleter::operator()): Rename
16534 from free_target_description.
16535 (make_cleanup_free_target_description): Remove.
16536
16537 2019-01-02 Tom Tromey <tom@tromey.com>
16538
16539 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16540 constructor, destructor.
16541 (linespec_parser): Remove typedef.
16542 (~linespec_parser): Rename from linespec_parser_delete.
16543 (linespec_lex_to_end, linespec_complete_label)
16544 (linespec_complete): Update.
16545 (decode_line_full): Remove cleanups.
16546 (decode_line_1): Update.
16547
16548 2019-01-02 Tom Tromey <tom@tromey.com>
16549
16550 * python/python-internal.h (inferior_to_inferior_object): Change
16551 return type.
16552 * python/py-exitedevent.c (create_exited_event_object): Update.
16553 * python/py-inferior.c (inferior_to_inferior_object): Return
16554 gdbpy_ref.
16555 (python_new_inferior, python_inferior_deleted)
16556 (thread_to_thread_object, delete_thread_object)
16557 (build_inferior_list, gdbpy_selected_inferior): Update.
16558 * python/py-infthread.c (create_thread_object): Update. Also fail
16559 if inferior_to_inferior_object fails.
16560
16561 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16562
16563 * inferior.h (class inferior) <displaced_step_state>: New field.
16564 * infrun.h (struct displaced_step_state): Move here from
16565 infrun.c. Initialize fields, add constructor.
16566 <inf>: Remove field.
16567 <reset>: New method.
16568 * infrun.c (struct displaced_step_inferior_state): Move to
16569 infrun.h.
16570 (displaced_step_inferior_states): Remove.
16571 (get_displaced_stepping_state): Adust.
16572 (displaced_step_in_progress_any_inferior): Adjust.
16573 (displaced_step_in_progress_thread): Adjust.
16574 (displaced_step_in_progress): Adjust.
16575 (add_displaced_stepping_state): Remove.
16576 (get_displaced_step_closure_by_addr): Adjust.
16577 (remove_displaced_stepping_state): Remove.
16578 (infrun_inferior_exit): Call displaced_step_state.reset.
16579 (use_displaced_stepping): Don't check for NULL.
16580 (displaced_step_prepare_throw): Call
16581 get_displaced_stepping_state.
16582 (displaced_step_fixup): Don't check for NULL.
16583 (prepare_for_detach): Don't check for NULL.
16584
16585 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16586
16587 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16588 in case of call that did not complete.
16589
16590 2019-01-02 Andrey Utkin <autkin@undo.io>
16591
16592 * symfile.c (find_separate_debug_file): Fix search of debug files for
16593 remote debuggee.
16594
16595 2019-01-02 Tom Tromey <tom@tromey.com>
16596
16597 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16598 indentation.
16599 * python/py-frame.c (frapy_older): Remove cast.
16600 (frapy_newer): Likewise.
16601 * python/py-breakpoint.c (local_setattro): Remove cast.
16602 * python/py-arch.c (archpy_name): Remove local variable.
16603 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16604
16605 2019-01-02 Joel Brobecker <brobecker@adacore.com>
16606
16607 * unittests/basic_string_view/element_access/char/empty.cc:
16608 Fix year range in copyright header.
16609
16610 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16611
16612 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16613 Delete.
16614 <operator==>: Update with for removed field.
16615 <hash>: Likewise.
16616 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16617 <isa_features>: ...this.
16618 <abi_features>: New field.
16619 (riscv_isa_flen): Update comment.
16620 (riscv_abi_xlen): New declaration.
16621 (riscv_abi_flen): New declaration.
16622 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16623 isa_features.
16624 (riscv_abi_xlen): New function.
16625 (riscv_isa_flen): Update to get answer from isa_features.
16626 (riscv_abi_flen): New function.
16627 (riscv_has_fp_abi): Update to get answer from abi_features.
16628 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16629 xlen and flen.
16630 (riscv_call_info) <xlen, flen>: Update comment.
16631 (riscv_call_arg_struct): Remove invalid assertions
16632 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16633 is removed.
16634 (riscv_gdbarch_init): Gather isa features and abi features
16635 separately, ensure both match on the gdbarch when reusing an old
16636 gdbarch. Relax an error check to allow 32-bit abi float to run on
16637 a target with 64-bit float hardware.
16638
16639 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16640
16641 * source.c (search_command_helper): Stop reverse search
16642 when line 1 has been searched.
16643
16644 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16645
16646 * record-full.c (record_full_base_target::close): Rewrite
16647 record_full_core_buf_list free logic.
16648
16649 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16650
16651 * break-catch-syscall.c (print_one_catch_syscall): xfree
16652 the last text.
16653
16654 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16655
16656 * top.c (print_gdb_version): Update Copyright year in version
16657 message.
16658
16659 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16660
16661 Update copyright year range in all GDB files.
16662
16663 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16664
16665 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16666
16667 For older changes see ChangeLog-2018.
16668 \f
16669 Local Variables:
16670 mode: change-log
16671 left-margin: 8
16672 fill-column: 74
16673 version-control: never
16674 coding: utf-8
16675 End:
16676
This page took 0.350752 seconds and 3 git commands to generate.