gdb/ChangeLog

   1 2020-06-28  Tom Tromey  <tom@tromey.com>
   2
   3         * command.h (cmd_types): Remove.
   4         (cmd_type): Don't declare.
   5         * cli/cli-decode.h (enum cmd_types): Uncomment.  No longer a
   6         typedef.
   7         * cli/cli-cmds.c (setting_cmd): Use cmd->type directly.
   8         * cli/cli-decode.c (cmd_type): Remove.
   9
  10 2020-06-27  Pedro Alves  <palves@redhat.com>
  11
  12         * fork-child.c (prefork_hook): Adjust.
  13         * infcmd.c (set_inferior_io_terminal, get_inferior_io_terminal):
  14         Delete.
  15         (set_inferior_tty_command, show_inferior_tty_command): Adjust.
  16         * inferior.c (inferior::set_tty, inferior::tty): New methods.
  17         * inferior.h (set_inferior_io_terminal, get_inferior_io_terminal):
  18         Remove declarations.
  19         (struct inferior) <set_tty, tty>: New methods.
  20         (struct inferior) <terminal>: Rename to ...
  21         (struct inferior) <m_terminal>: ... this and make private.
  22         * main.c (captured_main_1): Adjust.
  23         * mi/mi-cmd-env.c (mi_cmd_inferior_tty_set): Adjust.
  24         (mi_cmd_inferior_tty_show): Adjust.
  25         * nto-procfs.c (nto_procfs_target::create_inferior): Adjust.
  26         * windows-nat.c (windows_nat_target::create_inferior): Adjust.
  27
  28 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
  29
  30         * configure.ac: Add --enable-libctf: handle --disable-static
  31         properly.
  32         * acinclude.m4: sinclude ../config/enable.m4.
  33         * Makefile.in (aclocal_m4_deps): Adjust accordingly.
  34         (LIBCTF): Substitute in.
  35         (CTF_DEPS): New, likewise.
  36         (CLIBS): libctf needs symbols from libbfd: move earlier.
  37         (CDEPS): Use CTF_DEPS, not LIBCTF, now LIBCTF can include rpath
  38         flags.
  39         * ctfread.c: Surround in ENABLE_LIBCTF.
  40         (elfctf_build_psymtabs) [!ENABLE_LIBCTF]: New stub.
  41         * configure: Regenerate.
  42         * config.in: Likewise.
  43
  44 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
  45
  46         * infcmd.c (set_inferior_io_terminal): Use make_unique_xstrdup.
  47
  48 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
  49
  50         * inferior.h (struct inferior) <terminal>: Change type to
  51         gdb::unique_xmalloc_ptr<char>.
  52         * inferior.c (inferior::~inferior): Don't free inf->terminal.
  53         * infcmd.c (set_inferior_io_terminal): Don't free terminal
  54         field, adjust to unique pointer.
  55         (get_inferior_io_terminal): Adjust to unique pointer.
  56
  57 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
  58
  59         * riscv-tdep.c (riscv_print_registers_info): Loop over all
  60         registers, not just the known core set of registers.
  61
  62 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
  63
  64         * riscv-tdep.c (riscv_register_name): Return NULL for duplicate
  65         fflags, frm, and fcsr registers.
  66         (riscv_register_reggroup_p): Remove unknown CSRs from save and
  67         restore groups.
  68         (riscv_tdesc_unknown_reg): New function.
  69         (riscv_gdbarch_init): Pass riscv_tdesc_unknown_reg to
  70         tdesc_use_registers.
  71         * riscv-tdep.h (struct gdbarch_tdep): Add
  72         unknown_csrs_first_regnum, unknown_csrs_count,
  73         duplicate_fflags_regnum, duplicate_frm_regnum, and
  74         duplicate_fcsr_regnum fields.
  75
  76 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
  77
  78         * target-descriptions.c (tdesc_use_registers): Add new parameter a
  79         callback, use the callback (when not null) to help number unknown
  80         registers.
  81         * target-descriptions.h (tdesc_unknown_register_ftype): New typedef.
  82         (tdesc_use_registers): Add extra parameter to declaration.
  83
  84 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
  85
  86         * riscv-tdep.c (value_of_riscv_user_reg): Moved to here from later
  87         in the file.
  88         (class riscv_pending_register_alias): Likewise.
  89         (riscv_register_feature::register_info): Change 'required_p' field
  90         to 'required', and change its type.  Add 'check' member function.
  91         (riscv_register_feature::register_info::check): Define new member
  92         function.
  93         (riscv_xreg_feature): Change initialisation of 'required' field.
  94         (riscv_freg_feature): Likewise.
  95         (riscv_virtual_feature): Likewise.
  96         (riscv_csr_feature): Likewise.
  97         (riscv_check_tdesc_feature): Take extra parameter, the csr
  98         tdesc_feature, rewrite the function to use the new
  99         riscv_register_feature::register_info::check function.
 100         (riscv_gdbarch_init): Pass the csr tdesc_feature where needed.
 101
 102 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 103
 104         * features/Makefile: Remove all references to the deleted files
 105         below.
 106         * features/riscv/32bit-csr.c: Deleted.
 107         * features/riscv/32bit-csr.xml: Deleted.
 108         * features/riscv/64bit-csr.c: Deleted.
 109         * features/riscv/64bit-csr.xml: Deleted.
 110         * features/riscv/rebuild-csr-xml.sh: Deleted.
 111
 112 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 113
 114         * riscv-tdep.c (struct riscv_register_feature::register_info): Fix
 115         whitespace error for declaration of names member variable.
 116         (struct riscv_register_feature): Add new prefer_first_name member
 117         variable, and fix whitespace error in declaration of registers.
 118         (riscv_xreg_feature): Initialize prefer_first_name field.
 119         (riscv_freg_feature): Likewise.
 120         (riscv_virtual_feature): Likewise.
 121         (riscv_csr_feature): Likewise.
 122         (riscv_register_name): Expand on comments.  Remove register name
 123         modifications for CSR and virtual registers.
 124
 125 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 126
 127         * riscv-tdep.c (struct riscv_register_feature): Fix whitespace
 128         errors.
 129
 130 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 131
 132         * riscv-tdep.c (riscv_create_csr_aliases): Handle csr aliases from
 133         riscv-opc.h.
 134         (class riscv_pending_register_alias): New class.
 135         (riscv_check_tdesc_feature): Take vector of pending aliases and
 136         populate it as appropriate.
 137         (riscv_setup_register_aliases): Delete.
 138         (riscv_gdbarch_init): Create vector of pending aliases and pass it
 139         to riscv_check_tdesc_feature in all cases.  Use the vector to
 140         create the register aliases.
 141
 142 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 143
 144         * sol2-tdep.c (sol2_static_transform_name): Remove.
 145         (sol2_init_abi): Don't register it.
 146         * gdbarch.sh (static_transform_name): Remove.
 147         * gdbarch.c, gdbarch.h: Regenerate.
 148
 149         * dbxread.c (read_dbx_symtab) <'S'>: Remove call to
 150         gdbarch_static_transform_name.
 151         * mdebugread.c (parse_partial_symbols) <'S'>: Likewise.
 152         * stabsread.c (define_symbol) <'X'>: Remove.
 153         (define_symbol) <'S'>: Remove gdbarch_static_transform_name
 154         handling.
 155         <'V'>: Likewise.
 156         * xcoffread.c (scan_xcoff_symtab): Remove gdbarch.
 157         <'S'>: Remove call to gdbarch_static_transform_name.
 158
 159 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 160
 161         * procfs.c (procfs_pre_trace): New function.
 162         (procfs_target::create_inferior): Pass it to fork_inferior.
 163
 164 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 165
 166         * configure.tgt <sparc-*-linux*> (gdb_target_obs): Remove
 167         sparc-sol2-tdep.o, sol2-tdep.o, sparc64-sol2-tdep.o.
 168         <sparc64-*-linux*> (gdb_target_obs): Remove sparc64-sol2-tdep.o,
 169         sol2-tdep.o, sparc-sol2-tdep.o.
 170         * sparc-sol2-tdep.c (sparc32_sol2_init_abi): Make static.
 171         * sparc-tdep.h (sparc32_sol2_init_abi): Remove.
 172         * sparc64-sol2-tdep.c (sparc64_sol2_init_abi): Make static.
 173         * sparc64-tdep.h (sparc64_sol2_init_abi): Remove.
 174
 175 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 176
 177         * amd64-sol2-tdep.c (amd64_sol2_sigtramp_p): Remove.
 178         (amd64_sol2_init_abi): Use sol2_sigtramp_p.
 179         Call sol2_init_abi.
 180         Remove calls to set_gdbarch_skip_solib_resolver,
 181         set_gdbarch_core_pid_to_str.
 182         * i386-sol2-tdep.c (i386_sol2_sigtramp_p): Remove.
 183         (i386_sol2_static_transform_name): Remove.
 184         (i386_sol2_init_abi): Call sol2_init_abi.
 185         Remove calls to set_gdbarch_sofun_address_maybe_missing,
 186         set_gdbarch_static_transform_name,
 187         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
 188         Use sol2_sigtramp_p.
 189         * sol2-tdep.c (sol2_pc_in_sigtramp): New function.
 190         (sol2_sigtramp_p): New function.
 191         (sol2_static_transform_name): New function.
 192         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Make static.
 193         (sol2_init_abi): New function.
 194         * sol2-tdep.h (sol2_sigtramp_p, sol2_init_abi): Declare.
 195         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Remove.
 196         * sparc-sol2-tdep.c (sparc_sol2_pc_in_sigtramp): Remove.
 197         (sparc32_sol2_sigtramp_frame_sniffer): Just call sol2_sigtramp_p.
 198         (sparc_sol2_static_transform_name): Remove.
 199         (sparc32_sol2_init_abi): Call sol2_init_abi.
 200         Remove calls to set_gdbarch_sofun_address_maybe_missing,
 201         set_gdbarch_static_transform_name,
 202         set_gdbarch_skip_solib_resolver,
 203         set_gdbarch_core_pid_to_str.
 204         * sparc-tdep.h (sparc_sol2_pc_in_sigtramp)
 205         (sparc_sol2_static_transform_name): Remove
 206         * sparc64-sol2-tdep.c (sparc64_sol2_sigtramp_frame_sniffer): Just
 207         call sol2_sigtramp_p.
 208         (sparc64_sol2_init_abi): Call sol2_init_abi.
 209         Remove calls to set_gdbarch_sofun_address_maybe_missing,
 210         set_gdbarch_static_transform_name,
 211         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
 212
 213 2020-06-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 214
 215         * symfile-add-flags.h: New flag SYMFILE_ALWAYS_CONFIRM.
 216         * exec.c (validate_exec_file): If from_tty, set both
 217         SYMFILE_VERBOSE (== from_tty) and SYMFILE_ALWAYS_CONFIRM.
 218         * symfile.c (symbol_file_add_with_addrs): if always_confirm
 219         and from_tty, unconditionally ask a confirmation.
 220
 221 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 222
 223         * target-descriptions.c (tdesc_architecture_name): Protect against
 224         NULL pointer dereference.
 225         (maint_print_xml_tdesc_cmd): New function.
 226         (_initialize_target_descriptions): Register new 'maint print
 227         xml-tdesc' command and give it the filename completer.
 228         * NEWS: Mention new 'maint print xml-tdesc' command.
 229
 230 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 231
 232         * target-descriptions.c (class tdesc_compatible_info): New class.
 233         (struct target_desc): Change type of compatible vector.
 234         (tdesc_compatible_p): Update for change in type of
 235         target_desc::compatible.
 236         (tdesc_compatible_info_list): New function.
 237         (tdesc_compatible_info_arch_name): New function.
 238         (tdesc_add_compatible): Update for change in type of
 239         target_desc::compatible.
 240         (print_c_tdesc::visit_pre): Likewise.
 241
 242 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 243
 244         * target-descriptions.c (print_c_tdesc::print_c_tdesc): Change
 245         whitespace to underscore.
 246         (maint_print_c_tdesc_cmd): Use fake filename for target
 247         descriptions that came from the target.
 248         (_initialize_target_descriptions): Add filename command completion
 249         for 'maint print c-tdesc'.
 250
 251 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
 252
 253         * dwarf2/loc.c (decode_debug_loclists_addresses): Add empty
 254         lines.
 255
 256 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
 257
 258         * dwarf2/loc.c (decode_debug_loc_dwo_addresses): Add empty
 259         lines.
 260         (dwarf2_find_location_expression): Likewise.
 261         (call_site_parameter_matches): Likewise.
 262         (dwarf2_compile_expr_to_ax): Likewise.
 263         (disassemble_dwarf_expression): Likewise.
 264         (loclist_describe_location): Likewise.
 265
 266 2020-06-23  Pedro Alves  <palves@redhat.com>
 267
 268         * gdbarch-selftests.c: Don't include inferior.h, gdbthread.h or
 269         progspace-and-thread.h.  Include scoped-mock-context.h instead.
 270         (register_to_value_test): Use scoped_mock_context.
 271         * regcache.c: Include "scoped-mock-context.h".
 272         (cooked_read_test): Don't error out if a target is already pushed.
 273         Use scoped_mock_context.  Adjust.
 274         * scoped-mock-context.h: New file.
 275
 276 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 277
 278         * ada-lang.c (ada_language_data): Delete la_is_string_type_p
 279         initializer.
 280         (ada_language::is_string_type_p): New member function.
 281         * c-lang.c (c_language_data): Delete la_is_string_type_p
 282         initializer.
 283         (cplus_language_data): Likewise.
 284         (asm_language_data): Likewise.
 285         (minimal_language_data): Likewise.
 286         * d-lang.c (d_language_data): Likewise.
 287         * f-lang.c (f_is_string_type_p): Delete function, implementation
 288         moved to f_language::is_string_type_p.
 289         (f_language_data): Delete la_is_string_type_p initializer.
 290         (f_language::is_string_type_p): New member function,
 291         implementation from f_is_string_type_p.
 292         * go-lang.c (go_is_string_type_p): Delete function, implementation
 293         moved to go_language::is_string_type_p.
 294         (go_language_data): Delete la_is_string_type_p initializer.
 295         (go_language::is_string_type_p): New member function,
 296         implementation from go_is_string_type_p.
 297         * language.c (language_defn::is_string_type_p): Define new member
 298         function.
 299         (default_is_string_type_p): Make static, add comment copied from
 300         header file.
 301         (unknown_language_data): Delete la_is_string_type_p initializer.
 302         (unknown_language::is_string_type_p): New member function.
 303         (auto_language_data): Delete la_is_string_type_p initializer.
 304         (auto_language::is_string_type_p): New member function.
 305         * language.h (language_data): Delete la_is_string_type_p field.
 306         (language_defn::is_string_type_p): Declare new function.
 307         (default_is_string_type_p): Delete desclaration, move comment to
 308         definition.
 309         * m2-lang.c (m2_is_string_type_p): Delete function, implementation
 310         moved to m2_language::is_string_type_p.
 311         (m2_language_data): Delete la_is_string_type_p initializer.
 312         (m2_language::is_string_type_p): New member function,
 313         implementation from m2_is_string_type_p.
 314         * objc-lang.c (objc_language_data): Delete la_is_string_type_p
 315         initializer.
 316         * opencl-lang.c (opencl_language_data): Likewise.
 317         * p-lang.c (pascal_is_string_type_p): Delete function,
 318         implementation moved to pascal_language::is_string_type_p.
 319         (pascal_language_data): Delete la_is_string_type_p initializer.
 320         (pascal_language::is_string_type_p): New member function,
 321         implementation from pascal_is_string_type_p.
 322         * rust-lang.c (rust_is_string_type_p): Delete function,
 323         implementation moved to rust_language::is_string_type_p.
 324         (rust_language_data): Delete la_is_string_type_p initializer.
 325         (rust_language::is_string_type_p): New member function,
 326         implementation from rust_is_string_type_p.
 327         * valprint.c (val_print_scalar_or_string_type_p): Update call to
 328         is_string_type_p.
 329
 330 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 331
 332         * ada-lang.c (ada_language_data): Delete la_print_typedef
 333         initializer.
 334         (ada_language::print_typedef): New member function.
 335         * c-lang.c (c_language_data): Delete la_print_typedef initializer.
 336         (cplus_language_data): Likewise.
 337         (asm_language_data): Likewise.
 338         (minimal_language_data): Likewise.
 339         * d-lang.c (d_language_data): Likewise.
 340         * f-lang.c (f_language_data): Likewise.
 341         (f_language::print_typedef): New member function.
 342         * go-lang.c (go_language_data): Delete la_print_typedef
 343         initializer.
 344         * language.c (language_defn::print_typedef): Define member
 345         function.
 346         (unknown_language_data): Delete la_print_typedef initializer.
 347         (unknown_language::print_typedef): New member function.
 348         (auto_language_data): Delete la_print_typedef initializer.
 349         (auto_language::print_typedef): New member function.
 350         * language.h (language_data): Delete la_print_typedef field.
 351         (language_defn::print_typedef): Declare new member function.
 352         (LA_PRINT_TYPEDEF): Update call to print_typedef.
 353         (default_print_typedef): Delete declaration.
 354         * m2-lang.c (m2_language_data): Delete la_print_typedef
 355         initializer.
 356         (m2_language::print_typedef): New member function.
 357         * objc-lang.c (objc_language_data): Delete la_print_typedef
 358         initializer.
 359         * opencl-lang.c (opencl_language_data): Likewise.
 360         * p-lang.c (pascal_language_data): Likewise.
 361         (pascal_language::print_typedef): New member function.
 362         * rust-lang.c (rust_print_typedef): Delete function,
 363         implementation moved to rust_language::print_typedef.
 364         (rust_language): Delete la_print_typedef initializer.
 365         (rust_language::print_typedef): New member function,
 366         implementation from rust_print_typedef.
 367         * typeprint.c (default_print_typedef): Delete.
 368
 369 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 370
 371         * ada-lang.c (ada_language_data): Delete la_printstr initializer.
 372         (ada_language::printstr): New member function.
 373         * c-lang.c (c_language_data): Delete la_printstr initializer.
 374         (cplus_language_data): Likewise.
 375         (asm_language_data): Likewise.
 376         (minimal_language_data): Likewise.
 377         * d-lang.c (d_language_data): Likewise.
 378         * f-lang.c (f_printstr): Rename to f_language::printstr.
 379         (f_language_data): Delete la_printstr initializer.
 380         (f_language::printstr): New member function, implementation from
 381         f_printstr.
 382         * go-lang.c (go_language_data): Delete la_printstr initializer.
 383         * language.c (language_defn::printstr): Define new member
 384         function.
 385         (unk_lang_printstr): Delete.
 386         (unknown_language_data): Delete la_printstr initializer.
 387         (unknown_language::printstr): New member function.
 388         (auto_language_data): Delete la_printstr initializer.
 389         (auto_language::printstr): New member function.
 390         * language.h (language_data): Delete la_printstr field.
 391         (language_defn::printstr): Declare new member function.
 392         (LA_PRINT_STRING): Update call to printstr.
 393         * m2-lang.c (m2_printstr): Rename to m2_language::printstr.
 394         (m2_language_data): Delete la_printstr initializer.
 395         (m2_language::printstr): New member function, implementation from
 396         m2_printstr.
 397         * objc-lang.c (objc_language_data): Delete la_printstr
 398         initializer.
 399         * opencl-lang.c (opencl_language_data): Likewise.
 400         * p-lang.c (pascal_printstr): Rename to pascal_language::printstr.
 401         (pascal_language_data): Delete la_printstr initializer.
 402         (pascal_language::printstr): New member function, implementation
 403         from pascal_printstr.
 404         * p-lang.h (pascal_printstr): Delete declaration.
 405         * rust-lang.c (rust_printstr): Update header comment.
 406         (rust_language_data): Delete la_printstr initializer.
 407         (rust_language::printstr): New member function.
 408
 409 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 410
 411         * ada-lang.c (ada_language_data): Delete la_printchar initializer.
 412         (ada_language::printchar): New member function.
 413         * c-lang.c (c_language_data): Delete la_printchar initializer.
 414         (cplus_language_data): Likewise.
 415         (asm_language_data): Likewise.
 416         (minimal_language_data): Likewise.
 417         * d-lang.c (d_language_data): Likewise.
 418         * f-lang.c (f_printchar): Rename to f_language::printchar.
 419         (f_language_data): Delete la_printchar initializer.
 420         (f_language::printchar): New member function, implementation from
 421         f_printchar.
 422         * go-lang.c (go_language_data): Delete la_printchar initializer.
 423         * language.c (unk_lang_printchar): Delete.
 424         (language_defn::printchar): Define new member function.
 425         (unknown_language_data): Delete la_printchar initializer.
 426         (unknown_language::printchar): New member function.
 427         (auto_language_data): Delete la_printchar initializer.
 428         (auto_language::printchar): New member function.
 429         * language.h (language_data): Delete la_printchar field.
 430         (language_defn::printchar): Declare new member function.
 431         (LA_PRINT_CHAR): Update call to printchar.
 432         * m2-lang.c (m2_language_data): Delete la_printchar initializer.
 433         (m2_language::printchar): New member function.
 434         * objc-lang.c (objc_language_data): Delete la_printchar
 435         initializer.
 436         * opencl-lang.c (opencl_language_data): Likewise.
 437         * p-lang.c (pascal_language_data): Delete la_printchar
 438         initializer.
 439         (pascal_language::printchar): New member function.
 440         * rust-lang.c (rust_printchar): Rename to
 441         rust_language::printchar.
 442         (rust_language_data): Delete la_printchar initializer.
 443         (rust_language::printchar): New member function, implementation
 444         from rust_printchar.
 445
 446 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 447
 448         * ada-lang.c (emit_char): Renamed to ada_language::emitchar.
 449         (ada_language_data): Delete la_emitchar initializer.
 450         (ada_language::emitchar): New member function, implementation from
 451         emit_char.
 452         * c-lang.c (c_language_data): Delete la_emitchar initializer.
 453         (cplus_language_data): Likewise.
 454         (asm_language_data): Likewise.
 455         (minimal_language_data): Likewise.
 456         * d-lang.c (d_language_data): Likewise.
 457         * f-lang.c (f_emit_char): Rename to f_language::emitchar.
 458         (f_language_data): Delete la_emitchar initializer.
 459         (f_language::emitchar): New member function, implementation from
 460         f_emit_char.
 461         * go-lang.c (go_language_data): Delete la_emitchar initializer.
 462         * language.c (unk_lang_emit_char): Delete.
 463         (language_defn::emitchar): New member function definition.
 464         (unknown_language_data): Delete la_emitchar initializer.
 465         (unknown_language::emitchar): New member function.
 466         (auto_language_data): Delete la_emitchar initializer.
 467         (auto_language::emitchar): New member function.
 468         * language.h (language_data): Delete la_emitchar field.
 469         (language_defn::emitchar): New member field declaration.
 470         (LA_EMIT_CHAR): Update call to emitchar.
 471         * m2-lang.c (m2_emit_char): Rename to m2_language::emitchar.
 472         (m2_language_data): Delete la_emitchar initializer.
 473         (m2_language::emitchar): New member function, implementation from
 474         m2_emit_char.
 475         * objc-lang.c (objc_language_data): Delete la_emitchar
 476         initializer.
 477         * opencl-lang.c (opencl_language_data): Likewise.
 478         * p-lang.c (pascal_emit_char): Rename to pascal_language::emitchar.
 479         (pascal_language_data): Delete la_emitchar initializer.
 480         (pascal_language::emitchar): New member function, implementation
 481         from pascal_emit_char.
 482         * rust-lang.c (rust_emitchar): Rename to rust_language::emitchar.
 483         (rust_language_data): Delete la_emitchar initializer.
 484         (rust_language::emitchar): New member function, implementation
 485         from rust_emitchar.
 486
 487 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 488
 489         * ada-lang.c (resolve): Rename to ada_language::post_parser.
 490         (ada_language_data): Delete la_post_parser initializer.
 491         (ada_language::post_parser): New member function.
 492         * c-lang.c (c_language_data): Delete la_post_parser initializer.
 493         (cplus_language_data): Likewise.
 494         (asm_language_data): Likewise.
 495         (minimal_language_data): Likewise.
 496         * d-lang.c (d_language_data): Likewise.
 497         * f-lang.c (f_language_data): Likewise.
 498         * go-lang.c (go_language_data): Likewise.
 499         * language.c (unknown_language_data): Likewise.
 500         (auto_language_data): Likewise.
 501         * language.h (language_data): Delete la_post_parser field.
 502         (language_defn::post_parser): New member function.
 503         * m2-lang.c (m2_language_data): Delete la_post_parser initializer.
 504         * objc-lang.c (objc_language_data): Likewise.
 505         * opencl-lang.c (opencl_language_data): Likewise.
 506         * p-lang.c (pascal_language_data): Likewise.
 507         * parse.c (parse_exp_in_context): Update call to post_parser.
 508         (null_post_parser): Delete definition.
 509         * parser-defs.h (null_post_parser): Delete declaration.
 510         * rust-lang.c (rust_language_data): Delete la_post_parser
 511         initializer.
 512
 513 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 514
 515         * ada-lang.c (parse): Rename to ada_language::parser.
 516         (ada_language_data): Delete la_parser initializer.
 517         (ada_language::parser): New member function, implementation from
 518         parse.
 519         * c-lang.c (c_language_data): Delete la_parser initializer.
 520         (cplus_language_data): Likewise.
 521         (asm_language_data): Likewise.
 522         (minimal_language_data): Likewise.
 523         * d-lang.c (d_language_data): Likewise.
 524         (d_language::parser): New member function.
 525         * f-lang.c (f_language_data): Delete la_parser initializer.
 526         (f_language::parser): New member function.
 527         * go-lang.c (go_language_data): Delete la_parser initializer.
 528         (go_language::parser): New member function.
 529         * language.c (unk_lang_parser): Delete.
 530         (language_defn::parser): Define new member function.
 531         (unknown_language_data): Delete la_parser initializer.
 532         (unknown_language::parser): New member function.
 533         (auto_language_data): Delete la_parser initializer.
 534         (auto_language::parser): New member function.
 535         * language.h (language_data): Delete la_parser field.
 536         (language_defn::parser): Declare new member function.
 537         * m2-lang.c (m2_language_data): Delete la_parser initializer.
 538         (m2_language::parser): New member function.
 539         * objc-lang.c (objc_language_data): Delete la_parser initializer.
 540         * opencl-lang.c (opencl_language_data): Likewise.
 541         * p-lang.c (pascal_language_data): Likewise.
 542         (pascal_language::parser): New member function.
 543         * parse.c (parse_exp_in_context): Update call to parser.
 544         * rust-lang.c (rust_language_data): Delete la_parser initializer.
 545         (rust_language::parser): New member function.
 546
 547 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 548
 549         * top.c (print_gdb_configuration): Print --with-python-libdir
 550         configuration value.
 551
 552 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 553
 554         * NEWS: Mention change to the alias command.
 555
 556 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 557
 558         * cli/cli-cmds.c (lookup_cmd_for_default_args)
 559         (alias_command_completer)
 560         (make_alias_options_def_group): New functions.
 561         (alias_opts, alias_option_defs): New struct and array.
 562         (alias_usage_error): Update usage.
 563         (alias_command): Handles optional DEFAULT-ARGS... arguments.
 564         Use option framework.
 565         (_initialize_cli_cmds): Update alias command help.
 566         Update aliases command help.
 567         (show_user):
 568         Add NULL for new default_args lookup_cmd argument.
 569         (valid_command_p): Rename to validate_aliased_command.
 570         Add NULL for new default_args lookup_cmd argument.  Verify that the
 571         aliased_command has no default args.
 572         * cli/cli-decode.c (help_cmd): Show aliases definitions.
 573         (lookup_cmd_1, lookup_cmd): New argument default_args.
 574         (add_alias_cmd):
 575         Add NULL for new default_args lookup_cmd argument.
 576         (print_help_for_command): Show default args under the layout
 577          alias some_alias = some_aliased_cmd some_alias_default_arg.
 578         * cli/cli-decode.h (struct cmd_list_element): New member default_args.
 579         xfree default_args in destructor.
 580         * cli/cli-script.c (process_next_line, do_define_command):
 581         Add NULL for new default_args lookup_cmd argument.
 582         * command.h: Declare new default_args argument in lookup_cmd
 583         and lookup_cmd_1.
 584         * completer.c (complete_line_internal_1):
 585         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 586         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 587         * guile/scm-param.c (add_setshow_generic, pascm_parameter_defined_p):
 588         Likewise.
 589         * infcmd.c (_initialize_infcmd): Likewise.
 590         * python/py-auto-load.c (gdbpy_initialize_auto_load): Likewise.
 591         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 592         * python/py-param.c (add_setshow_generic): Likewise.
 593         * remote.c (_initialize_remote): Likewise.
 594         * top.c (execute_command): Prepend default_args if command has some.
 595         (set_verbose):
 596         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 597         * tracepoint.c (validate_actionline, encode_actions_1):
 598         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 599
 600 2020-06-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 601
 602         * jit.c (jit_read_descriptor): Use bool as the return type.
 603         (jit_breakpoint_re_set_internal): Use bool as the return type.
 604         Invert the return value logic; return true if the jit breakpoint
 605         has been successfully initialized.
 606         (jit_inferior_init): Update the call to
 607         jit_breakpoint_re_set_internal.
 608
 609 2020-06-22  Pedro Alves  <palves@redhat.com>
 610
 611         PR gdb/25939
 612         * procfs.c (procfs_target::wait): Don't reference inferior_ptid.
 613         Use the current inferior instead.  Don't return
 614         TARGET_WAITKIND_SPURIOUS/inferior_ptid -- instead continue and
 615         wait again.
 616         * sol-thread.c (sol_thread_target::wait): Don't reference
 617         inferior_ptid.
 618         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, ps_lsetfpregs)
 619         (sol_update_thread_list_callback): Use the current inferior's pid
 620         instead of inferior_ptid.
 621
 622 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 623
 624         * procfs.c: Cleanup many comments.
 625
 626         (READ_WATCHFLAG, WRITE_WATCHFLAG, EXEC_WATCHFLAG)
 627         (AFTER_WATCHFLAG): Replace by value.
 628
 629         (MAIN_PROC_NAME_FORMAT): Inline ...
 630         (create_procinfo): ... here.
 631
 632         (procfs_debug_inferior): Remove SYS_exec handling.
 633         (syscall_is_exec): Likewise.
 634         (procfs_set_exec_trap): Likewise.
 635
 636         (syscall_is_lwp_exit): Inline in callers.
 637         (syscall_is_exit): Likewise.
 638         (syscall_is_exec): Likewise.
 639         (syscall_is_lwp_create): Likewise.
 640
 641         (invalidate_cache): Remove #if 0 code.
 642
 643         (make_signal_thread_runnable):  Remove.
 644         (procfs_target::resume): Remove #if 0 code.
 645
 646 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 647
 648         PR gdb/25939
 649         * procfs.c (procfs_target::procfs_init_inferior): Move push_target
 650         call ...
 651         (procfs_target::create_inferior): ... here.
 652
 653 2020-06-21  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 654
 655         * exec.c (validate_exec_file): Ensure the build-id is up to
 656         date by calling reopen_exec_file (that checks file timestamp
 657         to decide to re-read the file).
 658
 659 2020-06-18  Pedro Alves  <palves@redhat.com>
 660
 661         PR gdb/25412
 662         * gdbthread.h (delete_thread, delete_thread_silent)
 663         (find_thread_ptid): Update comments.
 664         * thread.c (current_thread_): New global.
 665         (is_current_thread): Move higher, and reimplement.
 666         (inferior_thread): Reimplement.
 667         (set_thread_exited): Use bool.  Add assertions.
 668         (add_thread_silent): Simplify thread-reuse handling by always
 669         calling delete_thread.
 670         (delete_thread): Remove intro comment.
 671         (find_thread_ptid): Skip exited threads.
 672         (switch_to_thread_no_regs): Write to current_thread_.
 673         (switch_to_no_thread): Check CURRENT_THREAD_ instead of
 674         INFERIOR_PTID.  Clear current_thread_.
 675
 676 2020-06-18  Pedro Alves  <palves@redhat.com>
 677
 678         * aix-thread.c (pd_update): Use switch_to_thread.
 679
 680 2020-06-18  Pedro Alves  <palves@redhat.com>
 681
 682         * ravenscar-thread.c (ravenscar_thread_target): Update.
 683         (ravenscar_thread_target::update_inferior_ptid): Rename to ...
 684         (ravenscar_thread_target::add_active_thread): ... this.  Don't
 685         set m_base_ptid here.  Update to avoid referencing inferior_ptid.
 686         (ravenscar_thread_target::wait): Don't write to inferior_ptid.
 687
 688 2020-06-18  Pedro Alves  <palves@redhat.com>
 689
 690         * nat/windows-nat.c (current_windows_thread): Remove.
 691         * nat/windows-nat.h (current_windows_thread): Remove.
 692         * windows-nat.c (windows_nat_target::stopped_by_sw_breakpoint):
 693         Adjust.
 694         (display_selectors): Adjust to fetch the current
 695         windows_thread_info based on inferior_ptid.
 696         (fake_create_process): No longer write to current_windows_thread.
 697         (windows_nat_target::get_windows_debug_event):
 698         Don't set inferior_ptid or current_windows_thread.
 699         (windows_nat_target::wait): Adjust to not rely on
 700         current_windows_thread.
 701         (do_initial_windows_stuff): Now a method of windows_nat_target.
 702         Switch to the last_ptid thread.
 703         (windows_nat_target::attach): Adjust.
 704         (windows_nat_target::detach): Use switch_to_no_thread instead of
 705         writing to inferior_ptid directly.
 706         (windows_nat_target::create_inferior): Adjust.
 707
 708 2020-06-18  Pedro Alves  <palves@redhat.com>
 709
 710         * windows-nat.c (do_initial_windows_stuff): No longer set inferior_ptid.
 711
 712 2020-06-18  Pedro Alves  <palves@redhat.com>
 713
 714         * go32-nat.c (go32_nat_target::create_inferior): Switch to thread
 715         after creating it, instead of writing to inferior_ptid.  Don't
 716         write to inferior_ptid.
 717
 718 2020-06-18  Pedro Alves  <palves@redhat.com>
 719
 720         * fork-child.c (postfork_hook): Don't write to inferior_ptid.
 721
 722 2020-06-18  Pedro Alves  <palves@redhat.com>
 723
 724         * bsd-kvm.c (bsd_kvm_target_open): Switch to thread after adding
 725         it, instead of writing to inferior_ptid.
 726
 727 2020-06-18  Pedro Alves  <palves@redhat.com>
 728
 729         * btrace.c (btrace_fetch): Use switch_to_thread instead of writing
 730         to inferior_ptid.
 731
 732 2020-06-18  Pedro Alves  <palves@redhat.com>
 733
 734         * bsd-kvm.c (bsd_kvm_target::close): Use switch_to_no_thread
 735         instead of writing to inferior_ptid directly.
 736
 737 2020-06-18  Pedro Alves  <palves@redhat.com>
 738
 739         * corelow.c (core_target::close): Use switch_to_no_thread instead
 740         of writing to inferior_ptid directly.
 741         (add_to_thread_list, core_target_open): Use switch_to_thread
 742         instead of writing to inferior_ptid directly.
 743
 744 2020-06-18  Pedro Alves  <palves@redhat.com>
 745
 746         * darwin-nat.c (darwin_nat_target::decode_message): Don't write to
 747         inferior_ptid.
 748         (darwin_nat_target::stop_inferior, darwin_nat_target::kill): Avoid
 749         inferior_ptid.
 750         (darwin_attach_pid): Use switch_to_no_thread instead of writing to
 751         inferior_ptid directly.
 752         (darwin_nat_target::init_thread_list): Switch to thread, instead
 753         of writing to inferior_ptid.
 754         (darwin_nat_target::attach): Don't write to inferior_ptid.
 755         (darwin_nat_target::get_ada_task_ptid): Avoid inferior_ptid.
 756
 757 2020-06-18  Pedro Alves  <palves@redhat.com>
 758
 759         * gnu-nat.c (gnu_nat_target::create_inferior): Switch to the added
 760         thread.
 761         (gnu_nat_target::attach): Don't write to inferior_ptid directly.
 762         Instead use switch_to_thread.
 763         (gnu_nat_target::detach): Use switch_to_no_thread
 764         instead of writing to inferior_ptid directly.  Used passed-in
 765         inferior instead of looking up the inferior by pid.
 766
 767 2020-06-18  Pedro Alves  <palves@redhat.com>
 768
 769         * go32-nat.c (go32_nat_target::create_inferior): Don't write to
 770         inferior_ptid.
 771
 772 2020-06-18  Pedro Alves  <palves@redhat.com>
 773
 774         * nto-procfs.c (nto_procfs_target::update_thread_list): Avoid
 775         inferior_ptid.
 776         (nto_procfs_target::attach): Avoid inferior_ptid.  Switch to
 777         thread.
 778         (nto_procfs_target::detach): Avoid referencing
 779         inferior_ptid.  Use switch_to_no_thread instead of writing to
 780         inferior_ptid directly.
 781         (nto_procfs_target::mourn_inferior): Use switch_to_no_thread
 782         instead of writing to inferior_ptid directly.
 783         (nto_procfs_target::create_inferior): Avoid inferior_ptid.  Switch
 784         to thread.
 785
 786 2020-06-18  Pedro Alves  <palves@redhat.com>
 787
 788         * remote-sim.c (gdbsim_target::create_inferior): Switch to thread
 789         after creating it, instead of writing to inferior_ptid.
 790         (gdbsim_target_open): Use switch_to_no_thread instead of writing
 791         to inferior_ptid directly.
 792         (gdbsim_target::wait): Don't write to inferior_ptid.
 793
 794 2020-06-18  Pedro Alves  <palves@redhat.com>
 795
 796         * remote.c (remote_target::remote_notice_new_inferior): Use
 797         switch_to_thread instead of writing to inferior_ptid directly.
 798         (remote_target::add_current_inferior_and_thread): Use
 799         switch_to_no_thread instead of writing to inferior_ptid directly.
 800         (extended_remote_target::attach): Use switch_to_inferior_no_thread
 801         and switch_to_thread instead of using set_current_inferior or
 802         writing to inferior_ptid directly.
 803
 804 2020-06-18  Pedro Alves  <palves@redhat.com>
 805
 806         * tracectf.c (ctf_target_open): Switch to added thread instead of
 807         writing to inferior_ptid directly.
 808         (ctf_target::close): Use switch_to_no_thread instead of writing to
 809         inferior_ptid directly.
 810
 811 2020-06-18  Pedro Alves  <palves@redhat.com>
 812
 813         * tracefile-tfile.c (tfile_target_open): Don't write to
 814         inferior_ptid directly, instead switch to added thread.
 815         (tfile_target::close): Use switch_to_no_thread instead of writing
 816         to inferior_ptid directly.
 817
 818 2020-06-18  Pedro Alves  <palves@redhat.com>
 819
 820         * procfs.c (procfs_target::attach): Don't write to inferior_ptid.
 821         (procfs_target::detach): Use switch_to_no_thread
 822         instead of writing to inferior_ptid directly.
 823         (do_attach): Change return type to void.  Switch to the added
 824         thread.
 825         (procfs_target::create_inferior): Switch to the added thread.
 826         (procfs_do_thread_registers): Don't write to inferior_ptid.
 827
 828 2020-06-18  Pedro Alves  <palves@redhat.com>
 829
 830         * infrun.c (generic_mourn_inferior): Use switch_to_thread instead
 831         of writing to inferior_ptid.
 832         (scoped_restore_exited_inferior): Delete.
 833         (handle_vfork_child_exec_or_exit): Simplify using
 834         scoped_restore_current_pspace_and_thread.  Use switch_to_thread
 835         instead of writing to inferior_ptid.
 836         (THREAD_STOPPED_BY): Delete.
 837         (thread_stopped_by_watchpoint, thread_stopped_by_sw_breakpoint)
 838         (thread_stopped_by_hw_breakpoint): Delete.
 839         (save_waitstatus): Use
 840         scoped_restore_current_thread+switch_to_thread, and call
 841         target_stopped_by_watchpoint instead of
 842         thread_stopped_by_watchpoint, target_stopped_by_sw_breakpoint
 843         instead of thread_stopped_by_sw_breakpoint, and
 844         target_stopped_by_hw_breakpoint instead of
 845         thread_stopped_by_hw_breakpoint.
 846         (handle_inferior_event)
 847         <TARGET_WAITKIND_EXITED/TARGET_WAITKIND_SIGNALLED>: Don't write to
 848         inferior_ptid directly, nor
 849         set_current_inferior/set_current_program_space.  Use
 850         switch_to_thread / switch_to_inferior_no_thread instead.
 851
 852 2020-06-18  Pedro Alves  <palves@redhat.com>
 853
 854         * target.c (generic_mourn_inferior): Use switch_to_no_thread
 855         instead of writing to inferior_ptid.
 856
 857 2020-06-18  Pedro Alves  <palves@redhat.com>
 858
 859         * inf-ptrace.c (inf_ptrace_target::create_inferior): Switch to the
 860         added thread.
 861         (inf_ptrace_target::attach): Don't write to inferior_ptid.  Switch
 862         to the added thread.
 863         (inf_ptrace_target::detach_success): Use switch_to_no_thread
 864         instead of writing to inferior_ptid.
 865
 866 2020-06-18  Pedro Alves  <palves@redhat.com>
 867
 868         * gdbarch-selftests.c: Include "progspace-and-thread.h".
 869         (register_to_value_test): Mock a program_space too.  Heap-allocate
 870         the address space.  Don't write to inferior_ptid.  Use
 871         switch_to_thread instead.
 872
 873 2020-06-18  Pedro Alves  <palves@redhat.com>
 874
 875         * linux-tdep.c (find_signalled_thread(thread_info *,void *)):
 876         Delete.
 877         (find_signalled_thread()): New, factored out from
 878         linux_make_corefile_notes and adjusted to handle exited threads.
 879         (linux_make_corefile_notes): Adjust to use the new
 880         find_signalled_thread.
 881
 882 2020-06-18  Pedro Alves  <palves@redhat.com>
 883
 884         * linux-tdep.c (btrace_fetch): Save/restore current thread instead
 885         of saving/restoring inferior_ptid.
 886
 887 2020-06-17  Tom Tromey  <tom@tromey.com>
 888
 889         * tui/tui-win.h (tui_scroll_forward, tui_scroll_backward)
 890         (tui_scroll_left, tui_scroll_right, struct tui_win_info): Don't
 891         declare.
 892         * tui/tui-data.h (MIN_CMD_WIN_HEIGHT): Remove.
 893
 894 2020-06-15  Simon Marchi  <simon.marchi@efficios.com>
 895
 896         * dwarf2/read.c (dwarf2_initialize_objfile): Check for presence
 897         of partial symtabs.
 898
 899 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 900
 901         * regformats/reg-arm.dat: Remove.
 902         * regformats/reg-bfin.dat: Remove.
 903         * regformats/reg-cris.dat: Remove.
 904         * regformats/reg-crisv32.dat: Remove.
 905         * regformats/reg-m32r.dat: Remove.
 906         * regformats/reg-tilegx.dat: Remove.
 907         * regformats/reg-tilegx32.dat: Remove.
 908
 909 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 910
 911         * features/Makefile (WHICH): Remove arm files.
 912         * regformats/arm/arm-with-iwmmxt.dat: Remove.
 913         * regformats/arm/arm-with-neon.dat: Remove.
 914         * regformats/arm/arm-with-vfpv2.dat: Remove.
 915         * regformats/arm/arm-with-vfpv3.dat: Remove.
 916
 917 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 918
 919         * features/Makefile (XMLTOC): Remove rx.xml.
 920
 921 2020-06-17  Pedro Alves  <palves@redhat.com>
 922
 923         * gdbthread.h (thread_control_state) <trap_expected> Update
 924         comments.
 925
 926 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 927
 928         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
 929         ada_language::lookup_symbol_nonlocal.
 930         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
 931         (ada_language::lookup_symbol_nonlocal): New member function,
 932         implementation from ada_lookup_symbol_nonlocal.
 933         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
 934         initializer.
 935         (cplus_language_data): Delete la_lookup_symbol_nonlocal
 936         initializer.
 937         (cplus_language::lookup_symbol_nonlocal): New member function.
 938         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
 939         (minimal_language_data) Likewise.
 940         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
 941         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
 942         initializer.
 943         (d_language::lookup_symbol_nonlocal): New member function.
 944         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
 945         initializer.
 946         (f_language::lookup_symbol_nonlocal): New member function.
 947         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
 948         initializer.
 949         * language.c (unknown_language_data): Likewise.
 950         (auto_language_data): Likewise.
 951         * language.h (language_data): Delete la_lookup_symbol_nonlocal
 952         field.
 953         (language_defn::lookup_symbol_nonlocal): New member function.
 954         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
 955         initializer.
 956         * objc-lang.c (objc_language_data): Likewise.
 957         * opencl-lang.c (opencl_language_data): Likewise.
 958         * p-lang.c (pascal_language_data): Likewise.
 959         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
 960         rust_language::lookup_symbol_nonlocal.
 961         (rust_language_data): Delete la_lookup_symbol_nonlocal
 962         initializer.
 963         (rust_language::lookup_symbol_nonlocal): New member function,
 964         implementation from rust_lookup_symbol_nonlocal.
 965         * symtab.c (lookup_symbol_aux): Update call to
 966         lookup_symbol_nonlocal.
 967         (basic_lookup_symbol_nonlocal): Rename to...
 968         (language_defn::lookup_symbol_nonlocal): ...this, and update
 969         header comment.  Remove language_defn parameter, and replace with
 970         uses of `this'.
 971         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
 972
 973 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 974
 975         * ada-lang.c (ada_language_data): Delete la_value_print_inner
 976         initializer.
 977         (ada_language::value_print_inner): New member function.
 978         * c-lang.c (c_language_data): Delete la_value_print_inner
 979         initializer.
 980         (cplus_language_data): Likewise.
 981         (asm_language_data): Likewise.
 982         (minimal_language_data): Likewise.
 983         * d-lang.c (d_language_data): Likewise.
 984         (d_language::value_print_inner): New member function.
 985         * f-lang.c (f_language_data): Delete la_value_print_inner
 986         initializer.
 987         (f_language::value_print_inner): New member function.
 988         * f-lang.h (f_value_print_innner): Rename to...
 989         (f_value_print_inner): ...this (note spelling of 'inner').
 990         * f-valprint.c (f_value_print_innner): Rename to...
 991         (f_value_print_inner): ...this (note spelling of 'inner').
 992         * go-lang.c (go_language_data): Delete la_value_print_inner
 993         initializer.
 994         (go_language::value_print_inner): New member function.
 995         * language.c (language_defn::value_print_inner): Define new member
 996         function.
 997         (unk_lang_value_print_inner): Delete.
 998         (unknown_language_data): Delete la_value_print_inner initializer.
 999         (unknown_language::value_print_inner): New member function.
1000         (auto_language_data): Delete la_value_print_inner initializer.
1001         (auto_language::value_print_inner): New member function.
1002         * language.h (language_data): Delete la_value_print_inner field.
1003         (language_defn::value_print_inner): Delcare new member function.
1004         * m2-lang.c (m2_language_data): Delete la_value_print_inner
1005         initializer.
1006         (m2_language::value_print_inner): New member function.
1007         * objc-lang.c (objc_language_data): Delete la_value_print_inner
1008         initializer.
1009         * opencl-lang.c (opencl_language_data): Likewise.
1010         * p-lang.c (pascal_language_data): Likewise.
1011         (pascal_language::value_print_inner): New member function.
1012         * rust-lang.c (rust_language_data): Delete la_value_print_inner
1013         initializer.
1014         (rust_language::value_print_inner): New member function.
1015         * valprint.c (do_val_print): Update call to value_print_inner.
1016
1017 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1018
1019         * ada-lang.c (ada_language_data): Delete la_value_print
1020         initializer.
1021         (ada_language::value_print): New member function.
1022         * c-lang.c (c_language_data): Delete la_value_print initializer.
1023         (cplus_language_data): Likewise.
1024         (asm_language_data): Likewise.
1025         (minimal_language_data): Likewise.
1026         * d-lang.c (d_language_data): Likewise.
1027         * f-lang.c (f_language_data): Likewise.
1028         * go-lang.c (go_language_data): Likewise.
1029         * language.c (unk_lang_value_print): Delete.
1030         (language_defn::value_print): Define new member function.
1031         (unknown_language_data): Delete la_value_print initializer.
1032         (unknown_language::value_print): New member function.
1033         (auto_language_data): Delete la_value_print initializer.
1034         (auto_language::value_print): New member function.
1035         * language.h (language_data): Delete la_value_print field.
1036         (language_defn::value_print): Declare new member function.
1037         (LA_VALUE_PRINT): Update call to value_print.
1038         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
1039         * objc-lang.c (objc_language_data): Likewise.
1040         * opencl-lang.c (opencl_language_data): Likewise.
1041         * p-lang.c (pascal_language_data): Likewise.
1042         (pascal_language::value_print): New member function.
1043         * rust-lang.c (rust_language_data): Delete la_value_print
1044         initializer.
1045
1046 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1047
1048         * ada-lang.c (ada_watch_location_expression): Rename to
1049         ada_language::watch_location_expression.
1050         (ada_language_data): Delete la_watch_location_expression
1051         initializer.
1052         (ada_language::watch_location_expression): New member function,
1053         implementation from ada_watch_location_expression.
1054         * breakpoint.c (watch_command_1): Update call to
1055         watch_location_expression.
1056         * c-lang.c (c_watch_location_expression): Rename to
1057         language_defn::watch_location_expression.
1058         (c_language_data): Delete la_watch_location_expression
1059         initializer.
1060         (cplus_language_data): Likewise.
1061         (asm_language_data): Likewise.
1062         (minimal_language_data): Likewise.
1063         * c-lang.h (c_watch_location_expression): Delete declaration.
1064         * d-lang.c (d_language_data): Delete la_watch_location_expression
1065         initializer.
1066         * f-lang.c (f_language_data): Likewise.
1067         * go-lang.c (go_language_data): Likewise.
1068         * language.c (language_defn::watch_location_expression): Member
1069         function implementation from c_watch_location_expression.
1070         (unknown_language_data): Delete la_watch_location_expression
1071         initializer.
1072         (auto_language_data): Likewise.
1073         * language.h (language_data): Delete la_watch_location_expression
1074         field.
1075         (language_defn::watch_location_expression): Declare new member
1076         function.
1077         * m2-lang.c (m2_language_data): Delete
1078         la_watch_location_expression initializer.
1079         * objc-lang.c (objc_language_data): Likewise.
1080         * opencl-lang.c (opencl_language_data): Likewise.
1081         * p-lang.c (pascal_language_data): Likewise.
1082         * rust-lang.c (rust_watch_location_expression): Rename to
1083         rust_language::watch_location_expression.
1084         (rust_language_data): Delete la_watch_location_expression
1085         initializer.
1086         (rust_language::watch_location_expression): New member function,
1087         implementation from rust_watch_location_expression.
1088
1089 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1090
1091         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
1092         ada_language::collect_symbol_completion_matches.
1093         (ada_language_data): Delete la_collect_symbol_completion_matches
1094         initializer.
1095         (ada_language::collect_symbol_completion_matches): New member
1096         function, implementation from
1097         ada_collect_symbol_completion_matches.
1098         * c-lang.c (c_language_data): Delete
1099         la_collect_symbol_completion_matches initializer.
1100         (cplus_language_data): Likewise.
1101         (asm_language_data): Likewise.
1102         (minimal_language_data): Likewise.
1103         * d-lang.c (d_language_data): Likewise.
1104         * f-lang.c (f_collect_symbol_completion_matches): Rename to
1105         f_language::collect_symbol_completion_matches.
1106         (f_language_data): Delete la_collect_symbol_completion_matches
1107         initializer.
1108         (f_language::collect_symbol_completion_matches) New member
1109         function, implementation from f_collect_symbol_completion_matches.
1110         * go-lang.c (go_language_data): Delete
1111         la_collect_symbol_completion_matches initializer.
1112         * language.c (unknown_language_data): Likewise.
1113         (auto_language_data): Likewise.
1114         * language.h (language_data): Delete
1115         la_collect_symbol_completion_matches field.
1116         (language_defn::collect_symbol_completion_matches): New member
1117         function.
1118         * m2-lang.c (m2_language_data): Delete
1119         la_collect_symbol_completion_matches initializer.
1120         * objc-lang.c (objc_language_data): Likewise.
1121         * opencl-lang.c (opencl_language_data): Likewise.
1122         * p-lang.c (pascal_language_data): Likewise.
1123         * rust-lang.c (rust_language_data): Likewise.
1124         * symtab.c (default_collect_symbol_completion_matches): Delete.
1125         (collect_symbol_completion_matches): Update call to
1126         collect_symbol_completion_matches.
1127         (collect_symbol_completion_matches_type): Likewise.
1128         * symtab.h (default_collect_symbol_completion_matches): Delete
1129         declaration.
1130
1131 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1132
1133         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
1134         (ada_language_data): Delete la_word_break_characters initializer.
1135         (ada_language::word_break_characters): New member function.
1136         * c-lang.c (c_language_data): Delete la_word_break_characters
1137         initializer.
1138         (cplus_language_data): Likewise.
1139         (asm_language_data): Likewise.
1140         (minimal_language_data): Likewise.
1141         * completer.c: Update global comment.
1142         (advance_to_expression_complete_word_point): Update call to
1143         word_break_characters.
1144         (complete_files_symbols): Likewise.
1145         (complete_line_internal_1): Likewise.
1146         (default_completer_handle_brkchars): Likewise.
1147         (skip_quoted_chars): Likewise.
1148         * d-lang.c (d_language_data): Delete la_word_break_characters
1149         initializer.
1150         * f-lang.c (f_word_break_characters): Delete.
1151         (f_language_data): Delete la_word_break_characters initializer.
1152         (f_language::word_break_characters): New member function.
1153         * go-lang.c (go_language_data): Delete la_word_break_characters
1154         initializer.
1155         * language.c (unknown_language_data): Likewise.
1156         (auto_language_data): Likewise.
1157         * language.h (default_word_break_characters): Move declaration to
1158         earlier in the file.
1159         (language_data): Delete la_word_break_characters field.
1160         (language_defn::word_break_characters): New member function.
1161         * m2-lang.c (m2_language_data): Delete la_word_break_characters
1162         initializer.
1163         * objc-lang.c (objc_language_data): Likewise.
1164         * opencl-lang.c (opencl_language_data): Likewise.
1165         * p-lang.c (pascal_language_data): Likewise.
1166         * rust-lang.c (rust_language_data): Likewise.
1167
1168 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1169
1170         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
1171         (ada_language_data): Delete la_get_symbol_name_matcher
1172         initializer.
1173         (language_defn::get_symbol_name_matcher_inner): New member
1174         function.
1175         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
1176         initializer.
1177         (cplus_language_data): Likewise.
1178         (cplus_language::get_symbol_name_matcher_inner): New member
1179         function.
1180         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
1181         (minimal_language_data): Likewise.
1182         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
1183         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
1184         initializer.
1185         * dictionary.c (iter_match_first_hashed): Update call to
1186         get_symbol_name_matcher.
1187         (iter_match_next_hashed): Likewise.
1188         (iter_match_next_linear): Likewise.
1189         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
1190         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
1191         initializer.
1192         (f_language::get_symbol_name_matcher_inner): New member function.
1193         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
1194         initializer.
1195         * language.c (default_symbol_name_matcher): Update header comment,
1196         make static.
1197         (language_defn::get_symbol_name_matcher): New definition.
1198         (language_defn::get_symbol_name_matcher_inner): Likewise.
1199         (get_symbol_name_matcher): Delete.
1200         (unknown_language_data): Delete la_get_symbol_name_matcher
1201         initializer.
1202         (auto_language_data): Likewise.
1203         * language.h (language_data): Delete la_get_symbol_name_matcher
1204         field.
1205         (language_defn::get_symbol_name_matcher): New member function.
1206         (language_defn::get_symbol_name_matcher_inner): Likewise.
1207         (default_symbol_name_matcher): Delete declaration.
1208         * linespec.c (find_methods): Update call to
1209         get_symbol_name_matcher.
1210         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
1211         initializer.
1212         * minsyms.c (lookup_minimal_symbol): Update call to
1213         get_symbol_name_matcher.
1214         (iterate_over_minimal_symbols): Likewise.
1215         * objc-lang.c (objc_language_data): Delete
1216         la_get_symbol_name_matcher initializer.
1217         * opencl-lang.c (opencl_language_data): Likewise.
1218         * p-lang.c (pascal_language_data): Likewise.
1219         * psymtab.c (psymbol_name_matches): Update call to
1220         get_symbol_name_matcher.
1221         * rust-lang.c (rust_language_data): Delete
1222         la_get_symbol_name_matcher initializer.
1223         * symtab.c (symbol_matches_search_name): Update call to
1224         get_symbol_name_matcher.
1225         (compare_symbol_name): Likewise.
1226
1227 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1228
1229         * ada-lang.c (ada_language_data): Delete la_compute_program
1230         initializer.
1231         * c-lang.c (c_language_data): Likewise.
1232         (c_language::compute_program): New member function.
1233         (cplus_language_data): Delete la_compute_program initializer.
1234         (cplus_language::compute_program): New member function.
1235         (asm_language_data): Delete la_compute_program initializer.
1236         (minimal_language_data): Likewise.
1237         * c-lang.h (c_compute_program): Update comment.
1238         (cplus_compute_program): Likewise.
1239         * compile/compile-c-support.c (c_compute_program): Likewise.
1240         (cplus_compute_program): Likewise.
1241         * compile/compile.c (compile_to_object): Update call to
1242         la_compute_program.
1243         * d-lang.c (d_language_data): Delete la_compute_program
1244         initializer.
1245         * f-lang.c (f_language_data): Likewise.
1246         * go-lang.c (go_language_data): Likewise.
1247         * language.c (unknown_language_data): Likewise.
1248         (auto_language_data): Likewise.
1249         * language.h (language_data): Delete la_compute_program field.
1250         (language_defn::compute_program): New member function.
1251         * m2-lang.c (m2_language_data): Delete la_compute_program
1252         initializer.
1253         * objc-lang.c (objc_language_data): Likewise.
1254         * opencl-lang.c (opencl_language_data): Likewise.
1255         * p-lang.c (pascal_language_data): Likewise.
1256         * rust-lang.c (rust_language_data): Likewise.
1257
1258 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1259
1260         * ada-lang.c (ada_language_data) Delete
1261         la_class_name_from_physname initializer.
1262         * c-lang.c (c_language_data): Likewise.
1263         (cplus_language_data): Likewise.
1264         (cplus_language::class_name_from_physname): New member function.
1265         (asm_language_data): Delete la_class_name_from_physname
1266         initializer.
1267         (minimal_language_data): Likewise.
1268         * d-lang.c (d_language_data): Likewise.
1269         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
1270         method on language_defn class.
1271         (guess_full_die_structure_name): Likewise.
1272         * f-lang.c (f_language_data): Delete la_class_name_from_physname
1273         initializer.
1274         * go-lang.c (go_language_data): Likewise.
1275         * language.c (language_class_name_from_physname): Delete.
1276         (unk_lang_class_name): Delete.
1277         (unknown_language_data): Delete la_class_name_from_physname
1278         initializer.
1279         (auto_language_data): Likewise.
1280         * language.h (language_data): Delete la_class_name_from_physname
1281         field.
1282         (language_defn::class_name_from_physname): New function.
1283         (language_class_name_from_physname): Delete declaration.
1284         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
1285         initializer.
1286         * objc-lang.c (objc_language_data): Likewise.
1287         * opencl-lang.c (opencl_language_data): Likewise.
1288         * p-lang.c (pascal_language_data): Likewise.
1289         * rust-lang.c (rust_language_data): Likewise.
1290
1291 2020-06-16  Tom Tromey  <tom@tromey.com>
1292
1293         * tui/tui-data.h (STATUS_NAME): New macro.
1294         * tui/tui-layout.c (tui_remove_some_windows)
1295         (initialize_known_windows, tui_register_window)
1296         (tui_layout_split::remove_windows, initialize_layouts)
1297         (tui_new_layout_command): Don't use hard-coded window names.
1298
1299 2020-06-16  Tom Tromey  <tom@tromey.com>
1300
1301         PR tui/25348:
1302         * tui/tui.c (tui_ensure_readline_initialized): Rename from
1303         tui_initialize_readline.  Only run once.  Call rl_initialize.
1304         * tui/tui.h (tui_ensure_readline_initialized): Rename from
1305         tui_initialize_readline.
1306         * tui/tui-io.c (tui_setup_io): Call
1307         tui_ensure_readline_initialized.
1308         * tui/tui-interp.c (tui_interp::init): Update.
1309
1310 2020-06-16  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
1313         Also preserve the status window.
1314
1315 2020-06-16  Tom Tromey  <tom@tromey.com>
1316
1317         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
1318         where m_window==nullptr.
1319
1320 2020-06-15  Tom Tromey  <tromey@adacore.com>
1321
1322         * windows-nat.c (windows_nat::handle_output_debug_string):
1323         Update.
1324         (windows_nat::handle_ms_vc_exception): Update.
1325         * target.h (target_read_string): Change API.
1326         * target.c (target_read_string): Change API.
1327         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
1328         Update.
1329         * solib-frv.c (frv_current_sos): Update.
1330         * solib-dsbt.c (dsbt_current_sos): Update.
1331         * solib-darwin.c (darwin_current_sos): Update.
1332         * linux-thread-db.c (inferior_has_bug): Update.
1333         * expprint.c (print_subexp_standard): Update.
1334         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
1335         (ada_exception_message_1): Update.
1336
1337 2020-06-15  Tom Tromey  <tromey@adacore.com>
1338
1339         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
1340
1341 2020-06-15  Tom Tromey  <tromey@adacore.com>
1342
1343         * valprint.c (read_string): Update comment.
1344         * target.c (MIN): Remove.
1345         (target_read_string): Rewrite.
1346
1347 2020-06-15  Tom Tromey  <tromey@adacore.com>
1348
1349         * corefile.c (read_memory_string): Remove.
1350         * ada-valprint.c (ada_value_print_ptr): Update.
1351         * ada-lang.h (ada_tag_name): Change return type.
1352         * ada-lang.c (type_from_tag): Update.
1353         (ada_tag_name_from_tsd): Change return type.  Use
1354         target_read_string.
1355         (ada_tag_name): Likewise.
1356         * gdbcore.h (read_memory_string): Don't declare.
1357
1358 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
1359
1360         * symtab.c (rbreak_command): Ignore Windows drive colon.
1361
1362 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
1363
1364         * NEWS: Mention removed GDBserver host support.
1365
1366 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
1367
1368         * features/riscv/rebuild-csr-xml.sh: Updated.
1369
1370 2020-06-11  Tom Tromey  <tom@tromey.com>
1371
1372         PR gdb/18318:
1373         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
1374
1375 2020-06-09  Jonny Grant  <jg@jguk.org>
1376 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
1377
1378         * main.c (captured_main_1): Don't print new line after help.
1379         (print_gdb_help): add mailing list and IRC channel information
1380         to --help.  Add new lines between items in the footer.  Remove
1381         quotes around bug url.
1382
1383 2020-06-11  Keith Seitz  <keiths@redhat.com>
1384
1385         PR gdb/21356
1386         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
1387         Resolve typedefs for type length calculations.
1388
1389 2020-06-10  Tom de Vries  <tdevries@suse.de>
1390
1391         PR ada/24713
1392         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
1393         (write_psymbols): Enable .gdb_index for ada.
1394         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
1395         ada.
1396
1397 2020-06-10  Tom de Vries  <tdevries@suse.de>
1398
1399         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
1400         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
1401         namei" instead of "const char *name" argument.
1402         (dw2_map_matching_symbols): Use "offset_type namei" variant of
1403         dw2_symtab_iter_init.
1404
1405 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1406
1407         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
1408         to use type::field and field::type instead.
1409
1410 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1411
1412         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
1413         to use field::type instead.
1414
1415 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1416
1417         * gdbtypes.h (struct field) <type, set_type>: New methods.
1418         Rename `type` field to...
1419         <m_type>: ... this.  Change references throughout to use type or
1420         set_type methods.
1421         (FIELD_TYPE): Use field::type.  Change call sites that modify
1422         the field's type to use field::set_type instead.
1423
1424 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1425
1426         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
1427         to use type::index_type instead.
1428
1429 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1430
1431         * gdbtypes.h (struct type) <index_type, set_index_type>: New
1432         methods.
1433         (TYPE_INDEX_TYPE): Use type::index_type.
1434         * gdbtypes.c (create_array_type_with_stride): Likewise.
1435
1436 2020-06-07  Tom Tromey  <tom@tromey.com>
1437
1438         * valprint.c (generic_val_print_float): Remove "embedded_offset"
1439         parameter.
1440         (generic_value_print): Update.
1441
1442 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1443
1444         Revert commit 982a38f60b0.
1445         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
1446
1447 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1448
1449         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
1450         avoid use after free.
1451
1452 2020-06-05  Tom de Vries  <tdevries@suse.de>
1453
1454         * NEWS: Fix typos.
1455
1456 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
1457
1458         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
1459         the per_bfd object.
1460         (dwarf2_read_debug_names): Likewise.
1461         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
1462         object when re-using a per_bfd object with an index.
1463
1464 2020-06-03  Tom de Vries  <tdevries@suse.de>
1465
1466         PR symtab/26046
1467         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
1468         children for C++.
1469         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
1470         DW_TAG_subprogram.
1471
1472 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1473
1474         * ada-lang.c (ada_language_data): Delete skip_trampoline
1475         initializer.
1476         * c-lang.c (c_language_data): Likewise.
1477         (cplus_language_data): Likewise.
1478         (cplus_language::skip_trampoline): New member function.
1479         (asm_language_data): Delete skip_trampoline initializer.
1480         (minimal_language_data): Likewise.
1481         * d-lang.c (d_language_data): Likewise.
1482         * f-lang.c (f_language_data): Likewise.
1483         * go-lang.c (go_language_data): Likewise.
1484         * language.c (unk_lang_trampoline): Delete function.
1485         (skip_language_trampoline): Update.
1486         (unknown_language_data): Delete skip_trampoline initializer.
1487         (auto_language_data): Likewise.
1488         * language.h (language_data): Delete skip_trampoline field.
1489         (language_defn::skip_trampoline): New function.
1490         * m2-lang.c (m2_language_data): Delete skip_trampoline
1491         initializer.
1492         * objc-lang.c (objc_skip_trampoline): Delete function, move
1493         implementation to objc_language::skip_trampoline.
1494         (objc_language_data): Delete skip_trampoline initializer.
1495         (objc_language::skip_trampoline): New member function with
1496         implementation from objc_skip_trampoline.
1497         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
1498         initializer.
1499         * p-lang.c (pascal_language_data): Likewise.
1500         * rust-lang.c (rust_language_data): Likewise.
1501
1502 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1503
1504         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
1505         (ada_language::demangle): New member function.
1506         * c-lang.c (c_language_data): Delete la_demangle initializer.
1507         (cplus_language_data): Delete la_demangle initializer.
1508         (cplus_language::demangle): New member function.
1509         (asm_language_data): Delete la_demangle initializer.
1510         (minimal_language_data): Delete la_demangle initializer.
1511         * d-lang.c (d_language_data): Delete la_demangle initializer.
1512         (d_language::demangle): New member function.
1513         * f-lang.c (f_language_data): Delete la_demangle initializer.
1514         (f_language::demangle): New member function.
1515         * go-lang.c (go_language_data): Delete la_demangle initializer.
1516         (go_language::demangle): New member function.
1517         * language.c (language_demangle): Update.
1518         (unk_lang_demangle): Delete.
1519         (unknown_language_data): Delete la_demangle initializer.
1520         (unknown_language::demangle): New member function.
1521         (auto_language_data): Delete la_demangle initializer.
1522         (auto_language::demangle): New member function.
1523         * language.h (language_data): Delete la_demangle field.
1524         (language_defn::demangle): New function.
1525         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
1526         * objc-lang.c (objc_language_data): Delete la_demangle
1527         initializer.
1528         (objc_language::demangle): New member function.
1529         * opencl-lang.c (opencl_language_data): Delete la_demangle
1530         initializer.
1531         * p-lang.c (pascal_language_data): Likewise.
1532         * rust-lang.c (rust_language_data): Likewise.
1533         (rust_language::demangle): New member function.
1534
1535 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1536
1537         * ada-lang.c (ada_language_data): Delete la_print_type
1538         initializer.
1539         (ada_language::print_type): New member function.
1540         * c-lang.c (c_language_data): Delete la_print_type initializer.
1541         (c_language::print_type): New member function.
1542         (cplus_language_data): Delete la_print_type initializer.
1543         (cplus_language::print_type): New member function.
1544         (asm_language_data): Delete la_print_type initializer.
1545         (asm_language::print_type): New member function.
1546         (minimal_language_data): Delete la_print_type initializer.
1547         (minimal_language::print_type): New member function.
1548         * d-lang.c (d_language_data): Delete la_print_type initializer.
1549         (d_language::print_type): New member function.
1550         * f-lang.c (f_language_data): Delete la_print_type initializer.
1551         (f_language::print_type): New member function.
1552         * go-lang.c (go_language_data): Delete la_print_type initializer.
1553         (go_language::print_type): New member function.
1554         * language.c (unk_lang_print_type): Delete.
1555         (unknown_language_data): Delete la_print_type initializer.
1556         (unknown_language::print_type): New member function.
1557         (auto_language_data): Delete la_print_type initializer.
1558         (auto_language::print_type): New member function.
1559         * language.h (language_data): Delete la_print_type field.
1560         (language_defn::print_type): New function.
1561         (LA_PRINT_TYPE): Update.
1562         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
1563         (m2_language::print_type): New member function.
1564         * objc-lang.c (objc_language_data): Delete la_print_type
1565         initializer.
1566         (objc_language::print_type): New member function.
1567         * opencl-lang.c (opencl_print_type): Delete, implementation moved
1568         to opencl_language::print_type.
1569         (opencl_language_data): Delete la_print_type initializer.
1570         (opencl_language::print_type): New member function, implementation
1571         from opencl_print_type.
1572         * p-lang.c (pascal_language_data): Delete la_print_type
1573         initializer.
1574         (pascal_language::print_type): New member function.
1575         * rust-lang.c (rust_print_type): Delete, implementation moved to
1576         rust_language::print_type.
1577         (rust_language_data): Delete la_print_type initializer.
1578         (rust_language::print_type): New member function, implementation
1579         from rust_print_type.
1580
1581 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1582
1583         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
1584         implementation moves to...
1585         (ada_language::sniff_from_mangled_name): ...here.  Update return
1586         type.
1587         (ada_language_data): Delete la_sniff_from_mangled_name
1588         initializer.
1589         * c-lang.c (c_language_data): Likewise.
1590         (cplus_language_data): Likewise.
1591         (cplus_language::sniff_from_mangled_name): New member function,
1592         implementation taken from gdb_sniff_from_mangled_name.
1593         (asm_language_data): Delete la_sniff_from_mangled_name
1594         initializer.
1595         (minimal_language_data): Likewise.
1596         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
1597         implementation moves to cplus_language::sniff_from_mangled_name.
1598         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
1599         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
1600         moves to...
1601         (d_language::sniff_from_mangled_name): ...here.
1602         (d_language_data): Delete la_sniff_from_mangled_name initializer.
1603         * f-lang.c (f_language_data): Likewise.
1604         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
1605         moves to...
1606         (go_language::sniff_from_mangled_name): ...here.
1607         (go_language_data): Delete la_sniff_from_mangled_name initializer.
1608         * language.c (language_sniff_from_mangled_name): Delete.
1609         (unknown_language_data): Delete la_sniff_from_mangled_name
1610         initializer.
1611         (auto_language_data): Likewise.
1612         * language.h (language_data): Delete la_sniff_from_mangled_name
1613         field.
1614         (language_defn::sniff_from_mangled_name): New function.
1615         (language_sniff_from_mangled_name): Delete declaration.
1616         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
1617         field.
1618         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
1619         implementation moves to...
1620         (objc_language::sniff_from_mangled_name): ...here.
1621         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
1622         * opencl-lang.c (opencl_language_data): Likewise.
1623         * p-lang.c (pascal_language_data): Likewise.
1624         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
1625         implementation moves to...
1626         (rust_language::sniff_from_mangled_name): ...here.
1627         (rust_language_data): Delete la_sniff_from_mangled_name
1628         initializer.
1629         * symtab.c (symbol_find_demangled_name): Call
1630         sniff_from_mangled_name member function.
1631
1632 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1633
1634         * ada-lang.c (ada_language_data): Delete la_search_name_hash
1635         initializer.
1636         * c-lang.c (c_language_data): Likewise.
1637         (cplus_language_data): Likewise.
1638         (cplus_language::search_name_hash): New member function.
1639         (asm_language_data): Delete la_search_name_hash initializer.
1640         (minimal_language_data): Likewise.
1641         * d-lang.c (d_language_data): Likewise.
1642         * dictionary.c (default_search_name_hash): Rename to...
1643         (language_defn::search_name_hash): ...this.
1644         * f-lang.c (f_language_data): Likewise.
1645         (f_language::search_name_hash): New member function.
1646         * go-lang.c (go_language_data): Delete la_search_name_hash
1647         initializer.
1648         * language.c (unknown_language_data): Likewise.
1649         (auto_language_data): Likewise.
1650         * language.h (struct language_data): Delete la_search_name_hash
1651         field.
1652         (language_defn::search_name_hash): Declare new member function.
1653         (default_search_name_hash): Delete declaration.
1654         * m2-lang.c (m2_language_data): Delete la_search_name_hash
1655         initializer.
1656         * objc-lang.c (objc_language_data): Likewise.
1657         * opencl-lang.c (opencl_language_data): Likewise.
1658         * p-lang.c (pascal_language_data): Likewise.
1659         * rust-lang.c (rust_language_data): Likewise.
1660         * symtab.c (search_name_hash): Update call.
1661
1662 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1663
1664         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
1665         initializer.
1666         * c-lang.c (class compile_instance): Declare.
1667         (c_language_data): Delete la_get_compile_instance initializer.
1668         (c_language::get_compile_instance): New member function.
1669         (cplus_language_data): Delete la_get_compile_instance initializer.
1670         (cplus_language::get_compile_instance): New member function.
1671         (asm_language_data): Delete la_get_compile_instance initializer.
1672         (minimal_language_data): Likewise.
1673         * c-lang.h (c_get_compile_context): Update comment.
1674         (cplus_get_compile_context): Update comment.
1675         * compile/compile.c (compile_to_object): Update calls, don't rely
1676         on function pointer being NULL.
1677         * d-lang.c (d_language_data): Delete la_get_compile_instance
1678         initializer.
1679         * f-lang.c (f_language_data): Likewise.
1680         * go-lang.c (go_language_data): Likewise.
1681         * language.c (unknown_language_data): Likewise.
1682         (auto_language_data): Likewise.
1683         * language.h (language_data): Delete la_get_compile_instance field.
1684         (language_defn::get_compile_instance): New member function.
1685         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
1686         initializer.
1687         * objc-lang.c (objc_language_data): Likewise.
1688         * opencl-lang.c (opencl_language_data): Likewise.
1689         * p-lang.c (pascal_language_data): Likewise.
1690         * rust-lang.c (rust_language_data): Likewise.
1691
1692 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1693
1694         * ada-lang.c (ada_add_all_symbols): Update comment.
1695         (ada_iterate_over_symbols): Delete, move implementation to...
1696         (ada_language::iterate_over_symbols): ...here, a new member
1697         function, rewrite to use range based for loop.
1698         (ada_language_data): Delete la_iterate_over_symbols initializer.
1699         * c-lang.c (c_language_data): Likewise.
1700         (cplus_language_data): Likewise.
1701         (asm_language_data): Likewise.
1702         (minimal_language_data): Likewise.
1703         * d-lang.c (d_language_data): Likewise.
1704         * f-lang.c (f_language_data): Likewise.
1705         * go-lang.c (go_language_data): Likewise.
1706         * language.c (unknown_language_data): Likewise.
1707         (auto_language_data): Likewise.
1708         * language.h (language_data): Delete la_iterate_over_symbols field.
1709         (language_defn::iterate_over_symbols): New member function.
1710         (LA_ITERATE_OVER_SYMBOLS): Update.
1711         * linespec.c (iterate_over_all_matching_symtabs): Update.
1712         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
1713         initializer.
1714         * objc-lang.c (objc_language_data): Likewise.
1715         * opencl-lang.c (opencl_language_data): Likewise.
1716         * p-lang.c (pascal_language_data): Likewise.
1717         * rust-lang.c (rust_language_data): Likewise.
1718
1719 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1720
1721         * ada-lang.c (ada_language_data): Delete
1722         la_lookup_transparent_type initializer.
1723         * c-lang.c (c_language_data): Likewise.
1724         (cplus_language_data): Likewise.
1725         (cplus_language::lookup_transparent_type): New member function.
1726         (asm_language_data): Delete la_lookup_transparent_type
1727         initializer.
1728         (minimal_language_data): Likewise.
1729         * d-lang.c (d_language_data): Likewise.
1730         * f-lang.c (f_language_data): Likewise.
1731         * go-lang.c (go_language_data): Likewise.
1732         * language.c (unknown_language_data): Likewise.
1733         (auto_language_data): Likewise.
1734         * language.h (struct language_data): Delete
1735         la_lookup_transparent_type field.
1736         (language_defn::lookup_transparent_type): New member function.
1737         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
1738         initializer.
1739         * objc-lang.c (objc_language_data): Likewise.
1740         * opencl-lang.c (opencl_language_data): Likewise.
1741         * p-lang.c (pascal_language_data): Likewise.
1742         * rust-lang.c (rust_language_data): Likewise.
1743         * symtab.c (symbol_matches_domain): Update call.
1744
1745 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1746
1747         * ada-lang.c (ada_language_arch_info): Delete function, move
1748         implementation to...
1749         (ada_language::language_arch_info): ...here, a new member
1750         function.
1751         (ada_language_data): Delete la_language_arch_info.
1752         * c-lang.c (c_language_data): Likewise.
1753         (c_language::language_arch_info): New member function.
1754         (cplus_language_arch_info): Delete function, move
1755         implementation to...
1756         (cplus_language::language_arch_info): ...here, a new member
1757         function.
1758         (cplus_language_data): Delete la_language_arch_info.
1759         (asm_language_data): Likewise.
1760         (asm_language::language_arch_info): New member function.
1761         (minimal_language_data): Delete la_language_arch_info.
1762         (minimal_language::language_arch_info): New member function.
1763         * d-lang.c (d_language_arch_info): Delete function, move
1764         implementation to...
1765         (d_language::language_arch_info): ...here, a new member
1766         function.
1767         (d_language_data): Delete la_language_arch_info.
1768         * f-lang.c (f_language_arch_info): Delete function, move
1769         implementation to...
1770         (f_language::language_arch_info): ...here, a new member
1771         function.
1772         (f_language_data): Delete la_language_arch_info.
1773         * go-lang.c (go_language_arch_info): Delete function, move
1774         implementation to...
1775         (go_language::language_arch_info): ...here, a new member
1776         function.
1777         (go_language_data): Delete la_language_arch_info.
1778         * language.c (unknown_language_data): Likewise.
1779         (unknown_language::language_arch_info): New member function.
1780         (auto_language_data): Delete la_language_arch_info.
1781         (auto_language::language_arch_info): New member function.
1782         (language_gdbarch_post_init): Update call to
1783         la_language_arch_info.
1784         * language.h (language_data): Delete la_language_arch_info
1785         function pointer.
1786         (language_defn::language_arch_info): New function.
1787         * m2-lang.c (m2_language_arch_info): Delete function, move
1788         implementation to...
1789         (m2_language::language_arch_info): ...here, a new member
1790         function.
1791         (m2_language_data): Delete la_language_arch_info.
1792         * objc-lang.c (objc_language_arch_info): Delete function, move
1793         implementation to...
1794         (objc_language::language_arch_info): ...here, a new member
1795         function.
1796         (objc_language_data): Delete la_language_arch_info.
1797         * opencl-lang.c (opencl_language_arch_info): Delete function, move
1798         implementation to...
1799         (opencl_language::language_arch_info): ...here, a new member
1800         function.
1801         (opencl_language_data): Delete la_language_arch_info.
1802         * p-lang.c (pascal_language_arch_info): Delete function, move
1803         implementation to...
1804         (pascal_language::language_arch_info): ...here, a new member
1805         function.
1806         (pascal_language_data): Delete la_language_arch_info.
1807         * rust-lang.c (rust_language_arch_info): Delete function, move
1808         implementation to...
1809         (rust_language::language_arch_info): ...here, a new member
1810         function.
1811         (rust_language_data): Delete la_language_arch_info.
1812
1813 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1814
1815         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
1816         initializer.
1817         * c-lang.c (c_language_data): Likewise.
1818         (cplus_language_data): Likewise.
1819         (cplus_language::pass_by_reference_info): New method.
1820         (asm_language_data): Delete la_pass_by_reference initializer.
1821         (minimal_language_data): Likewise.
1822         * cp-abi.c (cp_pass_by_reference): Remove use of
1823         default_pass_by_reference.
1824         * d-lang.c (d_language_data): Likewise.
1825         * f-lang.c (f_language_data): Likewise.
1826         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
1827         default_pass_by_reference.
1828         * go-lang.c (go_language_data): Likewise.
1829         * language.c (language_pass_by_reference): Update.
1830         (default_pass_by_reference): Delete.
1831         (unknown_language_data): Delete la_pass_by_reference
1832         initializer.
1833         (auto_language_data): Likewise.
1834         * language.h (struct language_data): Delete la_pass_by_reference
1835         field.
1836         (language_defn::pass_by_reference_info): New member function.
1837         (default_pass_by_reference): Delete declaration.
1838         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
1839         initializer.
1840         * objc-lang.c (objc_language_data): Likewise.
1841         * opencl-lang.c (opencl_language_data): Likewise.
1842         * p-lang.c (pascal_language_data): Likewise.
1843         * rust-lang.c (rust_language_data): Likewise.
1844
1845 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1846
1847         * ada-lang.c (ada_read_var_value): Delete function, move
1848         implementation to...
1849         (ada_language::read_var_value): ...here.
1850         (ada_language_data): Delete la_read_var_value initializer.
1851         * c-lang.c (c_language_data): Likewise.
1852         (cplus_language_data): Likewise.
1853         (minimal_language_data): Likewise.
1854         * d-lang.c (d_language_data): Likewise.
1855         * f-lang.c (f_language_data): Likewise.
1856         * findvar.c (default_read_var_value): Rename to...
1857         (language_defn::read_var_value): ...this.
1858         * findvar.c (read_var_value): Update header comment, and change to
1859         call member function instead of function pointer.
1860         * go-lang.c (go_language_data): Likewise.
1861         * language.c (unknown_language_data): Delete la_read_var_value
1862         initializer.
1863         (auto_language_data): Likewise.
1864         * language.h (struct language_data): Delete la_read_var_value
1865         field.
1866         (language_defn::read_var_value): New member function.
1867         (default_read_var_value): Delete declaration.
1868         * m2-lang.c (m2_language_data): Delete la_read_var_value
1869         initializer.
1870         * objc-lang.c (objc_language_data): Likewise.
1871         * opencl-lang.c (opencl_language_data): Likewise.
1872         * p-lang.c (pascal_language_data): Likewise.
1873         * rust-lang.c (rust_language_data): Likewise.
1874         * value.h (default_read_var_value): Delete declaration.
1875
1876 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1877
1878         * ada-lang.c (ada_print_array_index): Delete function, move
1879         implementation to...
1880         (ada_language::print_array_index): ...here.
1881         (ada_language_data): Delete la_print_array_index initializer.
1882         * c-lang.c (c_language_data): Likewise.
1883         (cplus_language_data): Likewise.
1884         (minimal_language_data): Likewise.
1885         * d-lang.c (d_language_data): Likewise.
1886         * f-lang.c (f_language_data): Likewise.
1887         * go-lang.c (go_language_data): Likewise.
1888         * language.c (default_print_array_index): Delete function, move
1889         implementation to...
1890         (language_defn::print_array_index): ...here.
1891         (unknown_language_data): Delete la_print_array_index initializer.
1892         (auto_language_data): Likewise.
1893         * language.h (struct language_data): Delete la_print_array_index
1894         field.
1895         (language_defn::print_array_index): New member function.
1896         (LA_PRINT_ARRAY_INDEX): Update.
1897         (default_print_array_index): Delete declaration.
1898         * m2-lang.c (m2_language_data): Delete la_print_array_index
1899         initializer.
1900         * objc-lang.c (objc_language_data): Likewise.
1901         * opencl-lang.c (opencl_language_data): Likewise.
1902         * p-lang.c (pascal_language_data): Likewise.
1903         * rust-lang.c (rust_language_data): Likewise.
1904
1905 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1906
1907         * gdb/ada-lang.c (ada_language_defn): Convert to...
1908         (ada_language_data): ...this.
1909         (class ada_language): New class.
1910         (ada_language_defn): New static global.
1911         * gdb/c-lang.c (c_language_defn): Convert to...
1912         (c_language_data): ...this.
1913         (class c_language): New class.
1914         (c_language_defn): New static global.
1915         (cplus_language_defn): Convert to...
1916         (cplus_language_data): ...this.
1917         (class cplus_language): New class.
1918         (cplus_language_defn): New static global.
1919         (asm_language_defn): Convert to...
1920         (asm_language_data): ...this.
1921         (class asm_language): New class.
1922         (asm_language_defn): New static global.
1923         (minimal_language_defn): Convert to...
1924         (minimal_language_data): ...this.
1925         (class minimal_language): New class.
1926         (minimal_language_defn): New static global.
1927         * gdb/d-lang.c (d_language_defn): Convert to...
1928         (d_language_data): ...this.
1929         (class d_language): New class.
1930         (d_language_defn): New static global.
1931         * gdb/f-lang.c (f_language_defn): Convert to...
1932         (f_language_data): ...this.
1933         (class f_language): New class.
1934         (f_language_defn): New static global.
1935         * gdb/go-lang.c (go_language_defn): Convert to...
1936         (go_language_data): ...this.
1937         (class go_language): New class.
1938         (go_language_defn): New static global.
1939         * gdb/language.c (unknown_language_defn): Remove declaration.
1940         (current_language): Initialize to nullptr, real initialization is
1941         moved to _initialize_language.
1942         (languages): Delete global.
1943         (language_defn::languages): Define.
1944         (set_language_command): Use language_defn::languages.
1945         (set_language): Likewise.
1946         (range_error): Likewise.
1947         (language_enum): Likewise.
1948         (language_def): Likewise.
1949         (add_set_language_command): Use language_def::languages for the
1950         language list, and language_def to lookup language pointers.
1951         (skip_language_trampoline): Use language_defn::languages.
1952         (unknown_language_defn): Convert to...
1953         (unknown_language_data): ...this.
1954         (class unknown_language): New class.
1955         (unknown_language_defn): New static global.
1956         (auto_language_defn): Convert to...
1957         (auto_language_data): ...this.
1958         (class auto_language): New class.
1959         (auto_language_defn): New static global.
1960         (language_gdbarch_post_init): Use language_defn::languages.
1961         (_initialize_language): Initialize current_language.
1962         * gdb/language.h (struct language_defn): Rename to...
1963         (struct language_data): ...this.
1964         (struct language_defn): New.
1965         (auto_language_defn): Delete.
1966         (unknown_language_defn): Delete.
1967         (minimal_language_defn): Delete.
1968         (ada_language_defn): Delete.
1969         (asm_language_defn): Delete.
1970         (c_language_defn): Delete.
1971         (cplus_language_defn): Delete.
1972         (d_language_defn): Delete.
1973         (f_language_defn): Delete.
1974         (go_language_defn): Delete.
1975         (m2_language_defn): Delete.
1976         (objc_language_defn): Delete.
1977         (opencl_language_defn): Delete.
1978         (pascal_language_defn): Delete.
1979         (rust_language_defn): Delete.
1980         * gdb/m2-lang.c (m2_language_defn): Convert to...
1981         (m2_language_data): ...this.
1982         (class m2_language): New class.
1983         (m2_language_defn): New static global.
1984         * gdb/objc-lang.c (objc_language_defn): Convert to...
1985         (objc_language_data): ...this.
1986         (class objc_language): New class.
1987         (objc_language_defn): New static global.
1988         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
1989         (opencl_language_data): ...this.
1990         (class opencl_language): New class.
1991         (opencl_language_defn): New static global.
1992         * gdb/p-lang.c (pascal_language_defn): Convert to...
1993         (pascal_language_data): ...this.
1994         (class pascal_language): New class.
1995         (pascal_language_defn): New static global.
1996         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
1997         language pointer, update comment format.
1998         * gdb/rust-lang.c (rust_language_defn): Convert to...
1999         (rust_language_data): ...this.
2000         (class rust_language): New class.
2001         (rust_language_defn): New static global.
2002
2003 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2004
2005         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
2006         member variable.
2007         <m_stmt_at_address>: New member variable.
2008         (lnp_state_machine::record_line): Don't record some lines, update
2009         tracking of is_stmt at the same address.
2010         (lnp_state_machine::lnp_state_machine): Initialise new member
2011         variables.
2012
2013 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2014
2015         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
2016         "-include gnu-nat-mig.h".
2017         * gnu-nat-mig.h: New file.
2018         * gnu-nat.c: Include "gnu-nat-mig.h".
2019         (exc_server, msg_reply_server, notify_server,
2020         process_reply_server): Remove declarations.
2021
2022 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2023
2024         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
2025         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
2026         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
2027         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
2028         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
2029         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
2030         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
2031         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
2032         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
2033         to gnu_nat_target class.
2034         * gnu-nat.c: Likewise.
2035         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
2036         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
2037         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
2038         object.
2039         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
2040         instead of `gnu_target'.
2041
2042 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2043
2044         * i386-gnu-tdep.c: Include "gdbcore.h"
2045         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
2046         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
2047         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
2048         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
2049         i386_gnu_sigcontext_addr): New functions
2050         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
2051         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
2052         tdep.
2053
2054 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2055
2056         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
2057         before fork_inferior call. Avoid calling it if target_is_pushed returns
2058         true.
2059
2060 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2061
2062         * gnu-nat.h (gnu_target): New variable declaration.
2063         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
2064         gnu_target.
2065         * gnu-nat.c (gnu_target): New variable.
2066         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
2067         add_thread_silent, and add_thread calls.
2068         (gnu_nat_target::create_inferior): Pass gnu_target to
2069         add_thread_silent, thread_change_ptid call.
2070         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
2071         call.
2072
2073 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2074
2075         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
2076         (gnu_nat_target::find_memory_regions): Remove unused
2077         `old_address' variable.
2078
2079 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2080
2081         * gnu-nat.c: Include "gdbarch.h".
2082
2083 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2084
2085         * reply_mig_hack.awk (Error return): Cast function through
2086         void *, to bypass compiler function call check.
2087
2088 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2089
2090         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
2091         $(srcdir)/reply_mig_hack.awk.
2092
2093 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2094
2095         * gnu-nat.h (gnu_debug_flag): Set type to bool.
2096
2097 2020-05-30  Jonny Grant  <jg@jguk.org>
2098
2099         * configure.ac (ACX_BUGURL): change bug URL to https.
2100
2101 2020-05-30  Pedro Alves  <palves@redhat.com>
2102
2103         * cp-support.c (replace_typedefs_template): New.
2104         (replace_typedefs_qualified_name): Handle
2105         DEMANGLE_COMPONENT_TEMPLATE.
2106
2107 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
2108
2109         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
2110         dwarf2/index-cache.h, dwarf2/index-write.c,
2111         dwarf2/index-write.h, dwarf2/line-header.c,
2112         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
2113         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
2114         variables and fields from `dwarf2_per_objfile` to just
2115         `per_objfile` throughout.
2116
2117 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
2118
2119         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2120         <push_dwarf_reg_entry_value>: Add comment.
2121
2122 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
2123             Keith Seitz  <keiths@redhat.com>
2124
2125         * python/python.c (do_start_initialization): Call PyEval_SaveThread
2126         instead of PyEval_ReleaseLock.
2127         (class gdbpy_gil): Move to earlier in file.
2128         (finalize_python): Set gdb_python_initialized.
2129         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
2130         when not initialized.
2131
2132 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
2133
2134         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2135         <push_dwarf_reg_entry_value>: Remove assert.  Override
2136         per_objfile with caller_per_objfile.
2137
2138 2020-05-28  Tom de Vries  <tdevries@suse.de>
2139
2140         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
2141         PR gold/15646 workaround to symbol kind "type".
2142
2143 2020-05-27  Tom Tromey  <tromey@adacore.com>
2144
2145         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
2146
2147 2020-05-27  Tom Tromey  <tromey@adacore.com>
2148
2149         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
2150         Use htab_find_with_hash.
2151         <add_abbrev>: Remove "abbrev_number" parameter.
2152         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
2153         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
2154         (hash_abbrev): Add comment.
2155         (abbrev_table::lookup_abbrev): Move to header file.
2156         (abbrev_table::read): Update.
2157
2158 2020-05-27  Tom Tromey  <tromey@adacore.com>
2159
2160         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
2161         method.
2162         <canonical_name>: New member.
2163         <raw_name>: Rename from "name".
2164         (partial_die_info): Initialize canonical_name.
2165         (scan_partial_symbols): Check raw_name.
2166         (partial_die_parent_scope, partial_die_full_name)
2167         (add_partial_symbol, add_partial_subprogram)
2168         (add_partial_enumeration, load_partial_dies): Use "name" method.
2169         (partial_die_info::name): New method.
2170         (partial_die_info::read, guess_partial_die_structure_name)
2171         (partial_die_info::fixup): Update.
2172
2173 2020-05-27  Tom Tromey  <tromey@adacore.com>
2174
2175         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
2176         <get_ref_die_offset>: Inline.
2177         <get_ref_die_offset_complaint>: New method.
2178         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
2179         (attribute::get_ref_die_offset_complaint): Rename from
2180         get_ref_die_offset.  Just issue complaint.
2181
2182 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
2183
2184         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
2185
2186 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
2187
2188         * exec.c (exec_file_attach): Use errno value of first openp failure.
2189
2190 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
2191
2192         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
2193         Don't close thread handle.
2194
2195 2020-05-27  Tom Tromey  <tom@tromey.com>
2196             Simon Marchi  <simon.marchi@efficios.com>
2197
2198         * objfiles.h (struct objfile) <partial_symtabs>: Now a
2199         shared_ptr.
2200         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
2201         member.
2202         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
2203         dwarf2_per_bfd_objfile_data_key>: New globals.
2204         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
2205         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
2206         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
2207         shared.
2208         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
2209         short-circuit when sharing.
2210         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
2211         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
2212
2213 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2214
2215         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
2216         to...
2217         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
2218         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
2219
2220 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2221
2222         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
2223         build_name_components, find_name_components_bounds>:
2224         Add per_objfile parameter.
2225         (struct mapped_index) <symbol_name_at>: Likewise.
2226         (struct mapped_debug_names): Remove constructor.
2227         <dwarf2_per_objfile>: Remove field.
2228         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
2229         (mapped_index_base::find_name_components_bounds,
2230         mapped_index_base::build_name_components,
2231         dw2_expand_symtabs_matching_symbol): Likewise.
2232         (class mock_mapped_index) <symbol_name_at>: Likewise.
2233         (check_match): Likewise.
2234         (check_find_bounds_finds): Likewise.
2235         (test_mapped_index_find_name_component_bounds): Update.
2236         (CHECK_MATCH): Update.
2237         (dw2_expand_symtabs_matching): Update.
2238         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
2239         per_objfile parameter.
2240         <find_vec_in_debug_names>: Likewise.
2241         <m_per_objfile>: New field.
2242         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
2243         parameter.
2244         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
2245         (dw2_debug_names_iterator::next): Update.
2246         (dw2_debug_names_lookup_symbol): Update.
2247         (dw2_debug_names_expand_symtabs_for_function): Update.
2248         (dw2_debug_names_map_matching_symbols): Update.
2249         (dw2_debug_names_expand_symtabs_matching): Update.
2250         (dwarf2_read_debug_names): Update.
2251
2252 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2253
2254         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
2255         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
2256         move to dwarf2_per_objfile.
2257         <read_in_chain>: Remove.
2258         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
2259         remove_all_cus, age_comp_units>: New methods.
2260         <m_dwarf2_cus>: New member.
2261         (struct dwarf2_per_cu_data) <cu>: Remove.
2262         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
2263         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
2264         moved to methods of dwarf2_per_objfile.
2265         (dwarf2_clear_marks): Remove.
2266         (dwarf2_queue_item::~dwarf2_queue_item): Update.
2267         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
2268         (dwarf2_per_bfd::free_cached_comp_units): Remove.
2269         (dwarf2_per_objfile::remove_all_cus): New.
2270         (class free_cached_comp_units) <~free_cached_comp_units>:
2271         Update.
2272         (load_cu): Update.
2273         (dw2_do_instantiate_symtab): Adjust.
2274         (fill_in_sig_entry_from_dwo_entry): Adjust.
2275         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2276         (cutu_reader::cutu_reader): Likewise.
2277         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
2278         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
2279         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
2280         and dwarf2_per_objfile::age_comp_units.
2281         (load_partial_comp_unit): Update.
2282         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
2283         (process_queue): Likewise.
2284         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
2285         backlink.
2286         (dwarf2_read_addr_index): Likewise.
2287         (follow_die_offset): Likewise.
2288         (dwarf2_fetch_die_loc_sect_off): Likewise.
2289         (dwarf2_fetch_constant_bytes): Likewise.
2290         (dwarf2_fetch_die_type_sect_off): Likewise.
2291         (follow_die_sig_1): Likewise.
2292         (load_full_type_unit): Likewise.
2293         (read_signatured_type): Likewise.
2294         (dwarf2_cu::dwarf2_cu): Don't set cu field.
2295         (dwarf2_cu::~dwarf2_cu): Remove.
2296         (dwarf2_per_objfile::get_cu): New.
2297         (dwarf2_per_objfile::set_cu): New.
2298         (age_cached_comp_units): Rename to...
2299         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
2300         to std::unordered_map.
2301         (free_one_cached_comp_unit): Rename to...
2302         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
2303         to std::unordered_map.
2304         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
2305         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
2306         a dwarf2_per_objfile in data.
2307         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
2308         (dwarf2_clear_marks): Remove.
2309
2310 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2311
2312         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
2313         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
2314         (init_tu_and_read_dwo_dies): Likewise.
2315         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
2316         (cutu_reader::cutu_reader): Likewise.
2317         (load_partial_comp_unit): Likewise.
2318         (process_psymtab_comp_unit): Update.
2319         (build_type_psymtabs_1): Update.
2320         (process_skeletonless_type_unit): Update.
2321         (load_full_comp_unit): Update.
2322         (find_partial_die): Update.
2323         (dwarf2_read_addr_index): Update.
2324         (read_signatured_type): Update.
2325
2326 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2327
2328         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
2329         m_header_read_in>: New fields.
2330         <get_header>: New method.
2331         * dwarf2/read.c (per_cu_header_read_in): Remove.
2332         (dwarf2_per_cu_data::get_header): New.
2333         (dwarf2_per_cu_data::addr_size): Update.
2334         (dwarf2_per_cu_data::offset_size): Update.
2335         (dwarf2_per_cu_data::ref_addr_size): Update.
2336
2337 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2338
2339         * dwarf2/read.c (load_cu): Return dwarf2_cu.
2340         (dw2_do_instantiate_symtab): Update.
2341         (queue_and_load_all_dwo_tus): Change parameter from
2342         dwarf2_per_cu_data to dwarf2_cu.
2343         (dwarf2_fetch_die_loc_sect_off): Update.
2344         (dwarf2_fetch_constant_bytes): Update.
2345         (dwarf2_fetch_die_type_sect_off): Update.
2346
2347 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2348
2349         * dwarf2/read.c (process_full_comp_unit,
2350         process_full_type_unit): Remove per_cu, per_objfile paramters.
2351         Add dwarf2_cu parameter.
2352         (process_queue): Update.
2353
2354 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2355
2356         * dwarf2/read.c (create_cu_from_index_list): Replace
2357         dwarf2_per_objfile parameter with dwarf2_per_bfd.
2358         (create_cus_from_index_list): Likewise.
2359         (create_cus_from_index): Likewise.
2360         (create_signatured_type_table_from_index): Likewise.
2361         (create_cus_from_debug_names_list): Likewise.
2362         (create_cus_from_debug_names): Likewise.
2363         (dwarf2_read_gdb_index): Update.
2364         (dwarf2_read_debug_names): Update.
2365
2366 2020-05-27  Tom Tromey  <tom@tromey.com>
2367             Simon Marchi  <simon.marchi@efficios.com>
2368
2369         * dwarf2/read.h (struct dwarf2_per_objfile)
2370         <get_type_for_signatured_type, set_type_for_signatured_type>:
2371         New methods.
2372         <m_type_map>: New member.
2373         (struct signatured_type) <type>: Remove.
2374         * dwarf2/read.c
2375         (dwarf2_per_objfile::get_type_for_signatured_type,
2376         dwarf2_per_objfile::set_type_for_signatured_type): New.
2377         (get_signatured_type): Use new methods.
2378
2379 2020-05-27  Tom Tromey  <tom@tromey.com>
2380             Simon Marchi  <simon.marchi@efficios.com>
2381
2382         * dwarf2/read.h (struct type_unit_group_unshareable): New.
2383         (struct dwarf2_per_objfile) <type_units>: New member.
2384         <get_type_unit_group_unshareable>: New method.
2385         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
2386         num_symtabs, symtabs>: Remove; move to
2387         type_unit_group_unshareable.
2388         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
2389         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
2390         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
2391
2392 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2393
2394         * dwarf2/read.h (struct dwarf2_per_cu_data):
2395         <dwarf2_per_objfile>: Remove.
2396         * dwarf2/read.c (create_cu_from_index_list): Don't assign
2397         dwarf2_per_objfile.
2398         (create_signatured_type_table_from_index): Likewise.
2399         (create_signatured_type_table_from_debug_names): Likewise.
2400         (create_debug_type_hash_table): Likewise.
2401         (fill_in_sig_entry_from_dwo_entry): Likewise.
2402         (create_type_unit_group): Likewise.
2403         (read_comp_units_from_section): Likewise.
2404         (create_cus_hash_table): Likewise.
2405
2406 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2407
2408         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
2409         dwarf2_per_cu_data::dwarf2_per_objfile.
2410         (compute_compunit_symtab_includes): Likewise.
2411         (dwarf2_cu::start_symtab): Likewise.
2412
2413 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2414
2415         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
2416         parameter.
2417         * dwarf2/read.c (get_die_type_at_offset): Likewise.
2418         (read_namespace_alias): Update.
2419         (lookup_die_type): Update.
2420         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
2421         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
2422         Update.
2423         (disassemble_dwarf_expression): Update.
2424
2425 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2426
2427         * dwarf2/read.h (struct dwarf2_queue_item): Add
2428         dwarf2_per_objfile parameter, assign new parameter.
2429         <per_objfile>: New field.
2430         * dwarf2/read.c (free_one_cached_comp_unit): Add
2431         dwarf2_per_objfile parameter.
2432         (queue_comp_unit): Likewise.
2433         (dw2_do_instantiate_symtab): Update.
2434         (process_psymtab_comp_unit): Update.
2435         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
2436         (process_imported_unit_die): Update.
2437         (queue_and_load_dwo_tu): Update.
2438         (follow_die_offset): Update.
2439         (follow_die_sig_1): Update.
2440
2441 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2442
2443         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
2444         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
2445         (read_call_site_scope): Assign per_objfile.
2446         (dwarf2_per_cu_data::objfile): Remove.
2447         * gdbtypes.h (struct call_site) <per_objfile>: New member.
2448         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
2449         dwarf2_per_objfile parameter.
2450         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
2451         dwarf2_per_objfile parameter.
2452         (dwarf_expr_reg_to_entry_parameter): Add output
2453         dwarf2_per_objfile parameter.
2454         (locexpr_get_frame_base): Update.
2455         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
2456         <push_dwarf_reg_entry_value>: Update.
2457         <call_site_to_target_addr>: Update.
2458         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
2459         parameter.
2460         (value_of_dwarf_reg_entry): Update.
2461         (rw_pieced_value): Update.
2462         (indirect_synthetic_pointer): Update.
2463         (dwarf2_evaluate_property): Update.
2464         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
2465         parameter.
2466         (locexpr_read_variable): Update.
2467         (locexpr_get_symbol_read_needs): Update.
2468         (loclist_read_variable): Update.
2469
2470 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2471
2472         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
2473         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2474         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
2475         parameter.
2476         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
2477         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2478         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
2479         parameter.
2480         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
2481         sect_variable_value): Add dwarf2_per_objfile parameter.
2482         (class dwarf_evaluate_loc_desc) <dwarf_call,
2483         dwarf_variable_value>: Update.
2484         (fetch_const_value_from_synthetic_pointer): Add
2485         dwarf2_per_objfile parameter.
2486         (fetch_const_value_from_synthetic_pointer): Update.
2487         (coerced_pieced_ref): Update.
2488         (class symbol_needs_eval_context) <dwarf_call,
2489         dwarf_variable_value>: Update.
2490         (dwarf2_compile_expr_to_ax): Update.
2491
2492 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2493
2494         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
2495         parameter.
2496         (dwarf2_evaluate_loc_desc_full): Update.
2497
2498 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2499
2500         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
2501         parameter.
2502         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
2503         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
2504         dwarf2_per_objfile parameter.
2505         (decode_debug_loc_dwo_addresses): Likewise.
2506         (dwarf2_find_location_expression): Update.
2507         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
2508         (locexpr_describe_location_piece): Add dwarf2_per_objfile
2509         parameter.
2510         (disassemble_dwarf_expression): Add dwarf2_per_objfile
2511         parameter.
2512         (locexpr_describe_location_1): Likewise.
2513         (locexpr_describe_location): Update.
2514
2515 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2516
2517         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
2518         Remove.
2519         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
2520         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
2521         (dwarf2_compile_property_to_c): Update.
2522         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
2523         use text offset from objfile.
2524         (locexpr_tracepoint_var_ref): Update.
2525         (locexpr_generate_c_location): Update.
2526         (loclist_describe_location): Update.
2527         (loclist_tracepoint_var_ref): Update.
2528         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
2529         dwarf2_per_objfile parameter.
2530         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
2531         use text offset from objfile.
2532         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
2533
2534 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2535
2536         * dwarf2/expr.h (struct dwarf_expr_context)
2537         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
2538         <offset>: Remove.
2539         <per_objfile>: New member.
2540         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
2541         dwarf2_per_objfile parameter.  Don't set offset, set
2542         per_objfile.
2543         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
2544         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
2545         a dwarf2_per_objfile object instead of an offset.
2546         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
2547         constructor.
2548         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
2549         to dwarf2_expr_executor constructor.  Don't set offset.
2550         (dwarf2_fetch_cfa_info): Update.
2551         (struct dwarf2_frame_cache) <text_offset>: Remove.
2552         <per_objfile>: New field.
2553         (dwarf2_frame_cache): Update.
2554         (dwarf2_frame_prev_register): Update.
2555         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2556         <dwarf_evaluate_loc_desc>: Add constructor.
2557         (dwarf2_evaluate_loc_desc_full): Update.
2558         (dwarf2_locexpr_baton_eval): Update.
2559         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
2560         Add constructor.
2561         (dwarf2_loc_desc_get_symbol_read_needs): Update.
2562
2563 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2564
2565         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
2566         addr_sized_int_type>: Move to dwarf2_cu.
2567         <int_type>: Move to dwarf2_per_objfile.
2568         (struct dwarf2_per_objfile) <int_type>: Move here.
2569         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
2570         addr_sized_int_type>: Move here.
2571         (read_func_scope): Update.
2572         (read_array_type): Update.
2573         (read_tag_string_type): Update.
2574         (attr_to_dynamic_prop): Update.
2575         (dwarf2_per_cu_data::int_type): Rename to...
2576         (dwarf2_per_objfile::int_type): ... this.
2577         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
2578         (dwarf2_cu::addr_sized_int_type): ... this.
2579         (read_subrange_type): Update.
2580         (dwarf2_per_cu_data::addr_type): Rename to...
2581         (dwarf2_cu::addr_type): ... this.
2582         (set_die_type): Update.
2583
2584 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2585
2586         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
2587         data through per_cu->cu.
2588
2589 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2590
2591         * dwarf2/read.c (lookup_dwo_comp_unit): Change
2592         dwarf2_per_cu_data parameter fo dwarf2_cu.
2593         (lookup_dwo_type_unit): Likewise.
2594         (read_cutu_die_from_dwo): Likewise.
2595         (lookup_dwo_unit): Likewise.
2596         (open_and_init_dwo_file): Likewise.
2597         (lookup_dwo_cutu): Likewise.
2598         (lookup_dwo_comp_unit): Likewise.
2599         (lookup_dwo_type_unit): Likewise.
2600         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2601         (cutu_reader::cutu_reader): Update.
2602
2603 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2604
2605         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
2606         parameter.
2607         (process_full_type_unit): Likewise.
2608         (process_queue): Update.
2609
2610 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2611
2612         * dwarf2/read.c (recursively_compute_inclusions): Add
2613         dwarf2_per_objfile parameter.
2614         (compute_compunit_symtab_includes): Likewise.
2615         (process_cu_includes): Update.
2616
2617 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2618
2619         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
2620         parameter.
2621         (create_type_unit_group): Update.
2622         (process_psymtab_comp_unit_reader): Update.
2623         (build_type_psymtabs_reader): Update.
2624
2625 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2626
2627         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
2628         object through m_this_cu->cu.
2629
2630 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2631
2632         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
2633         the info parameter.
2634         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
2635
2636 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2637
2638         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
2639         per_objfile parameter.
2640         (load_full_type_unit): Add per_objfile parameter.
2641         (read_signatured_type): Likewise.
2642         (load_full_comp_unit): Likewise.
2643         (load_cu): Likewise.
2644         (dw2_do_instantiate_symtab): Likewise.
2645         (dw2_get_file_names): Likewise.
2646         (dw2_map_symtabs_matching_filename): Update.
2647         (dw_expand_symtabs_matching_file_matcher): Update.
2648         (dw2_map_symbol_filenames): Update.
2649         (process_psymtab_comp_unit): Add per_objfile parameter.
2650         (build_type_psymtabs_1): Update.
2651         (process_skeletonless_type_unit): Update.
2652         (dwarf2_build_psymtabs_hard): Update.
2653         (load_partial_comp_unit): Add per_objfile parameter.
2654         (scan_partial_symbols): Update.
2655         (load_full_comp_unit): Add per_objfile parameter.
2656         (process_imported_unit_die): Update.
2657         (create_cus_hash_table): Update.
2658         (find_partial_die): Update.
2659         (dwarf2_read_addr_index): Update.
2660         (follow_die_offset): Update.
2661         (dwarf2_fetch_die_loc_sect_off): Update.
2662         (dwarf2_fetch_constant_bytes): Update.
2663         (dwarf2_fetch_die_type_sect_off): Update.
2664         (follow_die_sig_1): Update.
2665         (load_full_type_unit): Add per_objfile parameter.
2666         (read_signatured_type): Likewise.
2667
2668 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2669
2670         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
2671         of objfile_name.
2672
2673 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2674
2675         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
2676         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
2677         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
2678         field.
2679         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
2680         (create_cus_from_index): Update.
2681         (dwarf2_read_gdb_index): Update.
2682         (create_cus_from_debug_names): Update.
2683         (dwarf2_read_debug_names): Update.
2684         (get_abbrev_section_for_cu): Update.
2685         (create_all_comp_units): Update.
2686         (read_attribute_value): Update.
2687         (get_debug_line_section): Update.
2688         * dwarf2/index-cache.c (index_cache::store): Update.
2689         * dwarf2/index-write.c (save_gdb_index_command): Update.
2690         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
2691
2692 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2693
2694         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
2695         member.
2696         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
2697         dwarf2_per_cu_data::per_bfd.
2698         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
2699         (create_type_unit_group): Likewise.
2700         (queue_comp_unit): Remove reference to
2701         per_cu->dwarf2_per_objfile.
2702         (maybe_queue_comp_unit): Likewise.
2703         (fill_in_sig_entry_from_dwo_entry): Assign new field.
2704         (create_cus_hash_table): Assign new field.
2705
2706 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2707
2708         * dwarf2/read.c: Replace
2709         dwarf2_cu->per_cu->dwarf2_per_objfile references with
2710         dwarf2_cu->per_objfile throughout.
2711
2712 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2713
2714         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
2715         parameter, don't use per_cu->dwarf2_per_objfile.
2716         (dw2_instantiate_symtab): Likewise.
2717         (dw2_find_last_source_symtab): Update.
2718         (dw2_map_expand_apply): Update.
2719         (dw2_lookup_symbol): Update.
2720         (dw2_expand_symtabs_for_function): Update.
2721         (dw2_expand_all_symtabs): Update.
2722         (dw2_expand_symtabs_with_fullname): Update.
2723         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
2724         don't use per_cu->dwarf2_per_objfile.
2725         (dw2_expand_marked_cus): Update.
2726         (dw2_find_pc_sect_compunit_symtab): Update.
2727         (dw2_debug_names_lookup_symbol): Update.
2728         (dw2_debug_names_expand_symtabs_for_function): Update.
2729         (dw2_debug_names_map_matching_symbols): Update.
2730         (dwarf2_psymtab::expand_psymtab): Update.
2731
2732 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2733
2734         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
2735         <per_objfile>: New member.
2736         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
2737         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
2738         call to dwarf2_cu.
2739         (cutu_reader::cutu_reader): Update.
2740         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
2741
2742 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2743
2744         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
2745         struct dwarf2_per_objfile.
2746         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
2747         dwarf2_per_bfd.
2748         * dwarf2/read.c (set_die_type): Update.
2749         (get_die_type_at_offset): Update.
2750
2751 2020-05-27  Tom Tromey  <tom@tromey.com>
2752             Simon Marchi  <simon.marchi@efficios.com>
2753
2754         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
2755         method.
2756         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
2757         get_symtab, set_symtab>: New methods.
2758         <m_symtabs>: New field.
2759         (struct dwarf2_psymtab): Derive from partial_symtab.
2760         <readin_p, get_compunit_symtab>: Declare methods.
2761         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
2762         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
2763         New methods.
2764         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
2765         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
2766         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
2767         (dw2_symtab_iter_next, dw2_print_stats)
2768         (dw2_expand_symtabs_with_fullname)
2769         (dw2_expand_symtabs_matching_one)
2770         (dw_expand_symtabs_matching_file_matcher)
2771         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
2772         (dw2_debug_names_iterator::next)
2773         (dw2_debug_names_map_matching_symbols)
2774         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
2775         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
2776         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
2777         New methods.
2778         (get_compunit_symtab, process_full_comp_unit)
2779         (process_full_type_unit): Update.
2780         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
2781
2782 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2783
2784         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
2785         then introduce a new dwarf2_per_objfile type.
2786         <read_line_string>: Move to the new dwarf2_per_objfile type.
2787         <objfile>: Likewise.
2788         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
2789         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
2790         dwarf2_per_objfile->per_bfd.
2791         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
2792         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
2793         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
2794         (dwarf2_per_bfd::free_cached_comp_units): ... this.
2795         (dwarf2_has_info): Allocate dwarf2_per_bfd.
2796         (dwarf2_per_objfile::locate_sections): Rename to...
2797         (dwarf2_per_bfd::locate_sections): ... this.
2798         (dwarf2_per_objfile::get_cutu): Rename to...
2799         (dwarf2_per_bfd::get_cutu): ... this.
2800         (dwarf2_per_objfile::get_cu): Rename to...
2801         (dwarf2_per_bfd::get_cu): ... this.
2802         (dwarf2_per_objfile::get_tu): Rename to...
2803         (dwarf2_per_bfd::get_tu): ... this.
2804         (dwarf2_per_objfile::allocate_per_cu): Rename to...
2805         (dwarf2_per_bfd::allocate_per_cu): ... this.
2806         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
2807         (dwarf2_per_bfd::allocate_signatured_type): ... this.
2808         (get_gdb_index_contents_ftype): Change parameter from
2809         dwarf2_per_objfile to dwarf2_per_bfd.
2810         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
2811         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
2812
2813 2020-05-27  Tom Tromey  <tom@tromey.com>
2814             Simon Marchi  <simon.marchi@efficios.com>
2815
2816         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
2817         (allocate_piece_closure): Set "per_objfile" member.
2818         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
2819         (locexpr_describe_location, loclist_describe_location): Use new
2820         member.
2821         * dwarf2/read.c (read_call_site_scope)
2822         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
2823         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
2824         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
2825         handle_data_member_location): Set per_objfile member.
2826         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
2827         member.
2828         (struct dwarf2_loclist_baton) <per_objfile>: New member.
2829
2830 2020-05-27  Tom Tromey  <tom@tromey.com>
2831
2832         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
2833         allocate_signatured_type>: Declare new methods.
2834         <m_num_psymtabs>: New member.
2835         (struct dwarf2_per_cu_data) <index>: New member.
2836         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
2837         (dwarf2_per_objfile::allocate_signatured_type): New methods.
2838         (create_cu_from_index_list): Use allocate_per_cu.
2839         (create_signatured_type_table_from_index)
2840         (create_signatured_type_table_from_debug_names)
2841         (create_debug_type_hash_table, add_type_unit)
2842         (read_comp_units_from_section): Use allocate_signatured_type.
2843
2844 2020-05-27  Tom Tromey  <tom@tromey.com>
2845
2846         * psymtab.c (partial_map_expand_apply)
2847         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
2848         (psym_lookup_global_symbol_language)
2849         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
2850         (psym_print_stats, psym_expand_symtabs_for_function)
2851         (psym_map_symbol_filenames, psym_map_matching_symbols)
2852         (psym_expand_symtabs_matching)
2853         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
2854         (maintenance_check_psymtabs): Update.
2855         * psympriv.h (struct partial_symtab) <readin_p,
2856         get_compunit_symtab>: Add objfile parameter.
2857         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
2858         Likewise.
2859         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
2860         get_compunit_symtab>: Likewise.
2861         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
2862
2863 2020-05-27  Tom Tromey  <tom@tromey.com>
2864
2865         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
2866         member.
2867         * dwarf2/read.c (delete_file_name_entry): Fix comment.
2868         (create_cu_from_index_list)
2869         (create_signatured_type_table_from_index)
2870         (create_signatured_type_table_from_debug_names)
2871         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
2872         (dwarf2_create_include_psymtab)
2873         (create_debug_type_hash_table, add_type_unit)
2874         (create_type_unit_group, read_comp_units_from_section)
2875         (dwarf2_compute_name, create_cus_hash_table)
2876         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
2877         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
2878         obstack.
2879         (dw2_get_real_path): Likewise.  Change argument to
2880         dwarf2_per_objfile.
2881
2882 2020-05-27  Luis Machado  <luis.machado@linaro.org>
2883
2884         PR tdep/26000
2885         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
2886         for ldrd (immediate).
2887
2888 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2889
2890         * command.h: Add comment giving the name of class_tui.
2891         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
2892         create the fake command for the help for class_tui.
2893
2894 2020-05-26  Tom Tromey  <tromey@adacore.com>
2895
2896         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
2897         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
2898         (val_atr): New function.
2899         (value_val_atr): Use it.
2900         * ada-valprint.c (print_optional_low_bound): Change low bound
2901         handling for enums.
2902         (val_print_packed_array_elements): Don't call discrete_position.
2903         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
2904         discrete_position for enum types.
2905         * language.c (default_print_array_index): Change type.
2906         * language.h (struct language_defn) <la_print_array_index>: Add
2907         index_type parameter, change type of index_value.
2908         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
2909         (default_print_array_index): Update.
2910         * valprint.c (maybe_print_array_index): Don't call
2911         value_from_longest.  Update.
2912         (value_print_array_elements): Don't call discrete_position.
2913
2914 2020-05-26  Tom Tromey  <tromey@adacore.com>
2915
2916         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
2917         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
2918
2919 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
2920
2921         PR gdb/13519
2922         * avr-tdep.c (avr_integer_to_address): Return data or code
2923         address accordingly to the second 'type' argument of the
2924         function.
2925
2926 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
2927
2928         * infcmd.c, inferior.h: (construct_inferior_arguments):
2929         Moved function from here to gdbsupport/common-inferior.{h,cc}
2930
2931 2020-05-23  Tom Tromey  <tom@tromey.com>
2932
2933         Revert commit eca1f90c:
2934         * NEWS: Remove entry for completion styling.
2935         * completer.c (_rl_completion_prefix_display_length): Move
2936         declaration later.
2937         (gdb_fnprint): Revert.
2938         (gdb_display_match_list_1): Likewise.
2939         * cli/cli-style.c (completion_prefix_style)
2940         (completion_difference_style, completion_suffix_style): Remove.
2941         (_initialize_cli_style): Revert.
2942         * cli/cli-style.h (completion_prefix_style)
2943         (completion_difference_style, completion_suffix_style): Don't
2944         declare.
2945
2946 2020-05-24  Pedro Alves  <palves@redhat.com>
2947
2948         * symtab.c (completion_list_add_name): Return boolean indication
2949         of whether the symbol matched.
2950         (completion_list_add_symbol): Don't try to remove C++ aliases if
2951         the symbol didn't match in the first place.
2952         * symtab.h (completion_list_add_name): Return bool.
2953
2954 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
2955
2956         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
2957         type::field.
2958
2959 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
2960
2961         GDB 9.2 released.
2962
2963 2020-05-23  Tom Tromey  <tom@tromey.com>
2964
2965         * NEWS: Add entry for completion styling.
2966         * completer.c (_rl_completion_prefix_display_length): Move
2967         declaration earlier.
2968         (gdb_fnprint): Use completion_style.
2969         (gdb_display_match_list_1): Likewise.
2970         * cli/cli-style.c (completion_prefix_style)
2971         (completion_difference_style, completion_suffix_style): New
2972         globals.
2973         (_initialize_cli_style): Register new globals.
2974         * cli/cli-style.h (completion_prefix_style)
2975         (completion_difference_style, completion_suffix_style): Declare.
2976
2977 2020-05-23  Pedro Alves  <palves@redhat.com>
2978
2979         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
2980         (parse_escape): Use ISDIGIT instead of isdigit.
2981         (puts_debug): Use gdb_isprint instead of isprint.
2982         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
2983         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
2984         ISSPACE instead of isspace.
2985         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
2986         instead of isspace.
2987         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
2988         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
2989         instead of isxdigit and ISDIGIT instead of isdigit.
2990
2991 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2992
2993         * gdbtypes.h (struct type) <field>: New method.
2994         (TYPE_FIELDS): Remove, replace all uses with either type::fields
2995         or type::field.
2996
2997 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2998
2999         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
3000         (TYPE_FIELDS): Use type::fields.  Change all call sites that
3001         modify the propery to use type::set_fields instead.
3002
3003 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3004
3005         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
3006         type::num_fields instead.
3007
3008 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3009
3010         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
3011         methods.
3012         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
3013         that modify the number of fields to use type::set_num_fields
3014         instead.
3015
3016 2020-05-22  Tom Tromey  <tromey@adacore.com>
3017
3018         * compile/compile-object-load.h (munmap_list_free): Don't
3019         declare.
3020
3021 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3022
3023         * annotate.c (annotate_source_line): Update return type, add call
3024         to update current symtab and line.
3025         * annotate.h (annotate_source_line): Update return type, and
3026         extend header comment.
3027         * source.c (info_line_command): Check annotation_level before
3028         calling annotate_source_line.
3029         * stack.c (print_frame_info): If calling annotate_source_line
3030         returns true, then don't print any other source line information.
3031
3032 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
3033
3034         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
3035
3036 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
3037
3038         * coffread.c (patch_type): Remove NULL check before xfree.
3039         * corefile.c (set_gnutarget): Likewise.
3040         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
3041         * exec.c (build_section_table): Likewise.
3042         * remote.c (remote_target::pass_signals): Likewise.
3043         * utils.c (n_spaces): Likewise.
3044         * cli/cli-script.c (document_command): Likewise.
3045         * i386-windows-tdep.c (core_process_module_section): Likewise.
3046         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
3047
3048 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
3049
3050         * symfile.c (reread_symbols): Clear objfile's section_offsets
3051         vector and section indices, re-compute them by calling
3052         sym_offsets.
3053
3054 2020-05-20  Tom Tromey  <tromey@adacore.com>
3055
3056         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
3057         (desc_one_bound, desc_index_type): Compute field name.
3058
3059 2020-05-20  Tom de Vries  <tdevries@suse.de>
3060
3061         PR symtab/25833
3062         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
3063
3064 2020-05-20  Alan Modra  <amodra@gmail.com>
3065
3066         PR 25993
3067         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
3068         bfd_set_filename.
3069         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
3070         passed to bfd_set_filename.
3071         * symfile-mem.c (add_vsyscall_page): Likewise for string
3072         passed to symbol_file_add_from_memory.
3073         (symbol_file_add_from_memory): Make name param a const char* and
3074         don't strdup.
3075
3076 2020-05-20  Alan Modra  <amodra@gmail.com>
3077
3078         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
3079         rather than accessing bfd->filename directly.
3080         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
3081         and use bfd_section_name.
3082         * dwarf2/frame.c (decode_frame_entry): Likewise.
3083         * exec.c (exec_set_section_address): Likewise.
3084         * solib-aix.c (solib_aix_bfd_open): Likewise.
3085         * stap-probe.c (get_stap_base_address): Likewise.
3086         * symfile.c (reread_symbols): Likewise.
3087
3088 2020-05-19  Tom Tromey  <tromey@adacore.com>
3089
3090         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
3091
3092 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3093
3094         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
3095
3096 2020-05-19  Pedro Alves  <palves@redhat.com>
3097
3098         * NEWS (set exec-file-mismatch): Adjust entry.
3099         * exec.c: Include "build-id.h".
3100         (validate_exec_file): Try to match build IDs instead of filenames.
3101         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
3102         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
3103         and pass down 'warn_if_slow'.
3104         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
3105         gdb_bfd_open_closure to pass it down.
3106         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
3107
3108 2020-05-19  Pedro Alves  <palves@redhat.com>
3109
3110         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
3111         * target.c (target_fileio_open_1): Rename to target_fileio_open
3112         and make extern.  Use bool.
3113         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
3114         (target_fileio_read_alloc_1): Adjust.
3115         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
3116         (target_fileio_open_warn_if_slow): Delete declaration.
3117
3118 2020-05-19  Pedro Alves  <palves@redhat.com>
3119
3120         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
3121         Adjust all callers.
3122
3123 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
3124
3125         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
3126         whether disp is negative.
3127
3128 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3129
3130         * symfile.h (struct symfile_segment_data)
3131         <~symfile_segment_data>: Remove.
3132         <segment_info>: Change to std::vector.
3133         * symfile.c (default_symfile_segments): Update.
3134         * elfread.c (elf_symfile_segments): Update.
3135
3136 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3137
3138         * symfile.h (struct symfile_segment_data) <struct segment>: New.
3139         <segments>: New.
3140         <segment_bases, segment_sizes>: Remove.
3141         * symfile.c (default_symfile_segments): Update.
3142         * elfread.c (elf_symfile_segments): Update.
3143         * remote.c (remote_target::get_offsets): Update.
3144         * solib-target.c (solib_target_relocate_section_addresses):
3145         Update.
3146
3147 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3148
3149         * symfile.h (struct symfile_segment_data): Initialize fields.
3150         <~symfile_segment_data>: Add.
3151         (symfile_segment_data_up): New.
3152         (struct sym_fns) <sym_segments>: Return a
3153         symfile_segment_data_up.
3154         (default_symfile_segments): Return a symfile_segment_data_up.
3155         (free_symfile_segment_data): Remove.
3156         (get_symfile_segment_data): Return a symfile_segment_data_up.
3157         * symfile.c (default_symfile_segments): Likewise.
3158         (get_symfile_segment_data): Likewise.
3159         (free_symfile_segment_data): Remove.
3160         (symfile_find_segment_sections): Update.
3161         * elfread.c (elf_symfile_segments): Return a
3162         symfile_segment_data_up.
3163         * remote.c (remote_target::get_offsets): Update.
3164         * solib-target.c (solib_target_relocate_section_addresses):
3165         Update.
3166         * symfile-debug.c (debug_sym_segments): Return a
3167         symfile_segment_data_up.
3168
3169 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3170
3171         PR build/25981
3172         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
3173         Hardcode register numbers.
3174
3175         PR build/25981
3176         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
3177         procfs_find_LDT_entry): Remove.
3178         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
3179         procfs_find_LDT_entry): Remove.
3180         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
3181         Remove.
3182
3183 2020-05-17  Pedro Alves  <palves@redhat.com>
3184             Andrew Burgess  <andrew.burgess@embecosm.com>
3185             Keno Fischer  <keno@juliacomputing.com>
3186
3187         PR gdb/25741
3188         * breakpoint.c (build_target_condition_list): Update comments.
3189         (build_target_command_list): Update comments and skip matching
3190         locations.
3191         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
3192         a separate function.  Simplify "set breakpoint auto-hw off"
3193         handling.
3194         (insert_breakpoints): Update comment.
3195         (tracepoint_locations_match): New parameter.  For breakpoints,
3196         compare location types too, if the caller wants to.
3197         (handle_automatic_hardware_breakpoints): New functions.
3198         (bp_location_is_less_than): Also sort by location type and
3199         hardware breakpoint length.
3200         (update_global_location_list): Handle "set breakpoint auto-hw on"
3201         here.
3202         (update_breakpoint_locations): Ask breakpoint_locations_match to
3203         ignore location types.
3204
3205 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
3206
3207         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
3208         type::name instead.
3209
3210 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
3211
3212         * gdbtypes.h (struct type) <name, set_name>: New methods.
3213         (TYPE_CODE): Use type::name.  Change all call sites used to set
3214         the name to use type::set_name instead.
3215
3216 2020-05-16  Tom Tromey  <tom@tromey.com>
3217
3218         * top.c (quit_force): Update.
3219         * infrun.c (handle_no_resumed): Update.
3220         * top.h (all_uis): New function.
3221         (ALL_UIS): Remove.
3222
3223 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
3224
3225         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
3226
3227 2020-05-16  Pedro Alves  <palves@redhat.com>
3228
3229         * ia64-linux-nat.c
3230         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
3231         Declare method.
3232         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
3233
3234 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
3235
3236         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
3237         (sparc64_adi_info): Likewise.
3238
3239 2020-05-15  Tom Tromey  <tom@tromey.com>
3240
3241         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
3242         block_objfile.
3243         (lookup_objfile_from_block): Remove.
3244         (lookup_symbol_in_block, lookup_symbol_in_static_block)
3245         (lookup_global_symbol): Use block_objfile.
3246         * symtab.h (lookup_objfile_from_block): Don't declare.
3247         * printcmd.c (clear_dangling_display_expressions): Use
3248         block_objfile.
3249         * parse.c (operator_check_standard): Use block_objfile.
3250
3251 2020-05-15  Tom Tromey  <tom@tromey.com>
3252
3253         * language.c (language_alloc_type_symbol): Set
3254         SYMBOL_SECTION.
3255         * symtab.c (initialize_objfile_symbol): Remove.
3256         (allocate_symbol): Remove.
3257         (allocate_template_symbol): Remove.
3258         * dwarf2/read.c (fixup_go_packaging): Use "new".
3259         (new_symbol): Use "new".
3260         (read_variable): Don't call initialize_objfile_symbol.  Use
3261         "new".
3262         (read_func_scope): Use "new".
3263         * xcoffread.c (process_xcoff_symbol): Don't call
3264         initialize_objfile_symbol.
3265         (SYMBOL_DUP): Remove.
3266         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
3267         "new".
3268         * symtab.h (allocate_symbol, initialize_objfile_symbol)
3269         (allocate_template_symbol): Don't declare.
3270         (struct symbol): Add copy constructor.  Change defaults.
3271         * jit.c (finalize_symtab): Use "new".
3272         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
3273         Use "new".
3274         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
3275         (common_block_end): Use "new".
3276         * mdebugread.c (parse_symbol): Use "new".
3277         (new_symbol): Likewise.
3278
3279 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3280
3281         * NEWS: Mention changes to help and apropos.
3282
3283 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3284
3285         * command.h (enum command_class): Improve comments, document
3286         that class_alias is for user-defined aliases, give the class
3287         name for each class, remove unused class_xdb.
3288         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
3289         * breakpoint.c (_initialize_breakpoint): Replace class_alias
3290         by a precise class.
3291         * infcmd.c (_initialize_infcmd): Likewise.
3292         * reverse.c (_initialize_reverse): Likewise.
3293         * stack.c (_initialize_stack): Likewise.
3294         * symfile.c (_initialize_symfile): Likewise.
3295         * tracepoint.c (_initialize_tracepoint): Likewise.
3296
3297 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3298
3299         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
3300         when their aliased command is traversed.
3301         (help_cmd): Add fput_command_names_styled call to
3302         output command name and aliases when command has an alias.
3303
3304 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3305
3306         * cli/cli-decode.h (help_cmd_list): Remove declaration.
3307         * cli/cli-decode.c (help_cmd_list): Declare as static,
3308         remove prefix argument, use bool for recurse arg, rework to show the aliases of
3309         a command together with the command.
3310         (fput_command_name_styled, fput_command_names_styled): New functions.
3311         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
3312         fput_command_name_styled.
3313         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
3314         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
3315
3316 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3317
3318         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
3319         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
3320         * command.h (cmd_show_list): Likewise.
3321         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
3322         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
3323
3324 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3325
3326         * unittests/command-def-selftests.c (traverse_command_structure):
3327         Verify all commands of a list have the same prefix command and
3328         that only the top cmdlist commands have a null prefix.
3329
3330 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3331
3332         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
3333         as prefix, not one of its aliases.
3334         (set_cmd_prefix): Remove.
3335         (do_add_cmd): Centralize the setting of the prefix of a command, when
3336         command is defined after its full chain of prefix commands.
3337         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
3338         (add_setshow_cmd_full): Likewise.
3339         (update_prefix_field_of_prefixed_commands): New function.
3340         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
3341         update_prefix_field_of_prefixed_commands.
3342         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
3343         addresses of remote_set_cmdlist and remote_show_cmdlist given
3344         as argument, not the address of an argument.
3345         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
3346         * gdb/remote.c (_initialize_remote): Likewise.
3347
3348 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3349
3350         * cli/cli-cmds.c (alias_command): Check for an existing alias
3351         using lookup_cmd_composition, as valid_command_p is too strict
3352         and forbids aliases that are the prefix of an existing alias
3353         or command.
3354         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
3355         command is properly recognised as a valid command.
3356
3357 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3358
3359         * unittests/help-doc-selftests.c: Rename to
3360         unittests/command-def-selftests.c
3361         * unittests/command-def-selftests.c (help_doc_tests): Update some
3362         comments.
3363         (command_structure_tests, traverse_command_structure): New namespace
3364         and function.
3365         (command_structure_invariants_tests): New function.
3366         (_initialize_command_def_selftests) Renamed from
3367         _initialize_help_doc_selftests, register command_structure_invariants
3368         selftest.
3369
3370 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3371
3372         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
3373         an alias of 'show'.
3374
3375 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
3376
3377         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
3378         ada_is_fixed_point_type.  Update all callers.
3379         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
3380         all callers.
3381         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
3382         Update all callers.
3383         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
3384         print_fixed_point_type.  Update all callers.
3385         * ada-valprint.c (ada_value_print_num): Replace call to
3386         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
3387
3388 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
3389
3390         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
3391         processors.
3392         (cpu_supports_bts): Add CV_AMD case.
3393
3394 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
3395             Simon Marchi  <simon.marchi@efficios.com>
3396
3397         * infrun.c (stop_all_threads): Collect multiple wait events at
3398         each pass.
3399
3400 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
3401
3402         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
3403         type::code instead.
3404
3405 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
3406
3407         * gdbtypes.h (struct type) <code, set_code>: New methods.
3408         (TYPE_CODE): Use type::code.  Change all call sites used to set
3409         the code to use type::set_code instead.
3410
3411 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3412             Tom de Vries  <tdevries@suse.de>
3413             Pedro Alves  <palves@redhat.com>
3414
3415         PR threads/25478
3416         * infrun.c (stop_all_threads): Do NOT ignore
3417         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
3418         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
3419         received.
3420         (handle_no_resumed): Remove code handling a live inferior with no
3421         threads.
3422         * remote.c (has_single_non_exited_thread): New.
3423         (remote_target::update_thread_list): Do not delete a thread if is
3424         the last thread of the process.
3425         * thread.c (thread_select): Call delete_exited_threads instead of
3426         prune_threads.
3427
3428 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3429
3430         * infrun.c (stop_all_threads): Enable/disable thread events of all
3431         targets.  Move a debug message denoting the end of the function
3432         into the SCOPED_EXIT block.
3433
3434 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3435
3436         * process-stratum-target.h: Include <set>.
3437         (all_non_exited_process_targets, switch_to_target_no_thread): New
3438         function declarations.
3439         * process-stratum-target.c (all_non_exited_process_targets)
3440         (switch_to_target_no_thread): New function implementations.
3441
3442 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3443
3444         * infrun.c (handle_inferior_event): Extract out a piece of code
3445         into...
3446         (mark_non_executing_threads): ...this new function.
3447
3448 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3449
3450         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
3451         use.
3452
3453 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3454
3455         * regcache.c (regcache_read_pc_protected): New function
3456         implementation that returns 0 if the PC cannot read via
3457         'regcache_read_pc'.
3458         * infrun.c (proceed): Call 'regcache_read_pc_protected'
3459         instead of 'regcache_read_pc'.
3460         (keep_going_pass_signal): Ditto.
3461
3462 2020-05-13  Tom Tromey  <tromey@adacore.com>
3463
3464         * ada-lang.c (align_value): Remove.
3465         (ada_template_to_fixed_record_type_1): Use align_up.
3466
3467 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3468
3469         * async-event.c: Update the copyright year.
3470         * async-event.h: Update the copyright year.
3471
3472 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
3473
3474         * objfiles.h (is_addr_in_objfile,
3475         shared_objfile_contains_address_p): Return bool.
3476         * objfile.c (is_addr_in_objfile,
3477         shared_objfile_contains_address_p): Return bool.
3478
3479 2020-05-11  Tom Tromey  <tromey@adacore.com>
3480
3481         * cli/cli-cmds.c (info_command): Restore.
3482         (_initialize_cli_cmds): Use add_prefix_command for "info".
3483         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
3484
3485 2020-05-11  Tom Tromey  <tromey@adacore.com>
3486
3487         * ada-lang.c (ada_value_primitive_field): Now public.
3488         * ada-lang.h (ada_value_primitive_field): Declare.
3489         * ada-valprint.c (print_field_values): Use
3490         ada_value_primitive_field for wrapper fields.
3491
3492 2020-05-11  Tom de Vries  <tdevries@suse.de>
3493
3494         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
3495         MODULE_DOMAIN.
3496
3497 2020-05-11  Tom de Vries  <tdevries@suse.de>
3498
3499         PR symtab/25941
3500         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
3501         with length 0, if not gdb-produced.
3502         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
3503
3504 2020-05-09  Tom de Vries  <tdevries@suse.de>
3505
3506         PR gdb/25955
3507         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
3508         calculation.
3509
3510 2020-05-09  Tom Tromey  <tom@tromey.com>
3511
3512         * top.c (server_command): Now bool.
3513         * top.h (server_command): Now bool.
3514
3515 2020-05-08  Tom Tromey  <tromey@adacore.com>
3516
3517         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
3518         already being processed.
3519
3520 2020-05-08  Tom Tromey  <tom@tromey.com>
3521
3522         * printcmd.c (struct display) <next>: Remove.
3523         <display>: New constructor.
3524         <exp_string>: Now a std::string.
3525         <enabled_p>: Now a bool.
3526         (display_number): Move definition earlier.
3527         (displays): Rename from display_chain.  Now a std::vector.
3528         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
3529         (display_command): Update.
3530         (do_one_display, disable_display)
3531         (enable_disable_display_command, do_enable_disable_display):
3532         Update.
3533         (free_display): Remove.
3534         (clear_displays): Rewrite.
3535         (delete_display): Update.
3536         (map_display_numbers): Use function_view.  Remove "data"
3537         parameter.  Update.
3538         (do_delete_display): Remove.
3539         (undisplay_command): Update.
3540         (do_one_display, do_displays, disable_display)
3541         (info_display_command): Update.
3542         (do_enable_disable_display): Remove.
3543         (enable_disable_display_command)
3544         (clear_dangling_display_expressions): Update.
3545
3546 2020-05-08  Tom Tromey  <tom@tromey.com>
3547
3548         * symtab.c (set_symbol_cache_size)
3549         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
3550         (maintenance_print_symbol_cache_statistics): Update.
3551         * symmisc.c (print_symbol_bcache_statistics)
3552         (print_objfile_statistics, maintenance_print_objfiles)
3553         (maintenance_info_symtabs, maintenance_check_symtabs)
3554         (maintenance_expand_symtabs, maintenance_info_line_tables):
3555         Update.
3556         * symfile-debug.c (set_debug_symfile): Update.
3557         * source.c (forget_cached_source_info): Update.
3558         * python/python.c (gdbpy_progspaces): Update.
3559         * psymtab.c (maintenance_info_psymtabs): Update.
3560         * probe.c (parse_probes): Update.
3561         * linespec.c (iterate_over_all_matching_symtabs)
3562         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
3563         * guile/scm-progspace.c (gdbscm_progspaces): Update.
3564         * exec.c (exec_target::close): Update.
3565         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
3566         * breakpoint.c (print_one_breakpoint_location)
3567         (create_longjmp_master_breakpoint)
3568         (create_std_terminate_master_breakpoint): Update.
3569         * progspace.c (program_spaces): Now a std::vector.
3570         (maybe_new_address_space): Update.
3571         (add_program_space): Remove.
3572         (program_space::program_space): Update.
3573         (remove_program_space): Update.
3574         (number_of_program_spaces): Remove.
3575         (print_program_space, update_address_spaces): Update.
3576         * progspace.h (program_spaces): Change type.
3577         (ALL_PSPACES): Remove.
3578         (number_of_program_spaces): Don't declare.
3579         (struct program_space) <next>: Remove.
3580
3581 2020-05-08  Tom Tromey  <tom@tromey.com>
3582
3583         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
3584         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
3585         (enable_break): Update.
3586         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
3587         (frv_fdpic_find_canonical_descriptor): Update.
3588         (frv_fetch_objfile_link_map): Update.
3589         * progspace.c (program_space::free_all_objfiles): Update.
3590         (program_space::solibs): New method.
3591         * progspace.h (struct program_space) <solibs>: New method.
3592         * solist.h (master_so_list): Don't declare.
3593         (ALL_SO_LIBS): Remove.
3594         * solib.h (so_list_head): Remove.
3595         (update_solib_list): Update comment.
3596         * solib.c (master_so_list): Remove.
3597         (solib_used, update_solib_list, solib_add)
3598         (info_sharedlibrary_command, clear_solib)
3599         (reload_shared_libraries_1, remove_user_added_objfile): Update.
3600
3601 2020-05-08  Tom Tromey  <tom@tromey.com>
3602
3603         * extension.c (extension_languages): Now a std::array.
3604         (ALL_EXTENSION_LANGUAGES): Remove.
3605         (get_ext_lang_defn, get_ext_lang_of_file)
3606         (eval_ext_lang_from_control_command): Update.
3607         (finish_ext_lang_initialization)
3608         (auto_load_ext_lang_scripts_for_objfile)
3609         (ext_lang_type_printers::ext_lang_type_printers)
3610         (apply_ext_lang_type_printers)
3611         (ext_lang_type_printers::~ext_lang_type_printers)
3612         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
3613         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
3614         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
3615         (get_matching_xmethod_workers, ext_lang_colorize)
3616         (ext_lang_before_prompt): Update.
3617         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
3618
3619 2020-05-08  Tom Tromey  <tom@tromey.com>
3620
3621         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
3622         overload.
3623         <swap_string, m_string>: Remove.
3624         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
3625         Update.
3626         * stabsread.c (define_symbol, read_type): Update.
3627         * linespec.c (find_linespec_symbols): Update.
3628         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
3629         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
3630         * dbxread.c (read_dbx_symtab): Update.
3631         * cp-support.h (cp_canonicalize_string_full)
3632         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
3633         Return unique_xmalloc_ptr.
3634         * cp-support.c (inspect_type): Update.
3635         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
3636         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
3637         Likewise.
3638         * c-typeprint.c (print_name_maybe_canonical): Update.
3639         * break-catch-throw.c (check_status_exception_catchpoint):
3640         Update.
3641
3642 2020-05-08  Tom de Vries  <tdevries@suse.de>
3643
3644         * infrun.c (follow_fork): Copy current_line and current_symtab to
3645         child thread.
3646
3647 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3648
3649         * async-event.c (struct async_signal_handler, struct
3650         async_event_handler): Reformat, remove typedef.
3651
3652 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3653
3654         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
3655         access thistype->main_type->dyn_prop_list directly.
3656
3657 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3658
3659         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
3660         (remove_dyn_prop): Remove.  Update all users to use
3661         type::remove_dyn_prop.
3662         * gdbtypes.c (remove_dyn_prop): Rename to...
3663         (type::remove_dyn_prop): ... this.
3664
3665 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
3666
3667         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
3668         (add_dyn_prop): Remove.  Update all users to use
3669         type::add_dyn_prop.
3670         * gdbtypes.c (add_dyn_prop): Rename to...
3671         (type::add_dyn_prop): ... this.
3672
3673 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3674
3675         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
3676         (get_dyn_prop): Remove.  Update all users to use
3677         type::dyn_prop.
3678         * gdbtypes.c (get_dyn_prop): Rename to...
3679         (type::dyn_prop): ... this.
3680
3681 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
3682
3683         * gdbtypes.h (struct main_type) <flag_static>: Remove.
3684
3685 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
3686
3687         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
3688         instruction, skip it if it's there.
3689
3690 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
3691
3692         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
3693
3694 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
3695
3696         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
3697         * gdbtypes.c (recursive_dump_type): Remove use of
3698         TYPE_INCOMPLETE.
3699
3700 2020-05-03  Tom Tromey  <tom@tromey.com>
3701
3702         * breakpoint.c (catch_command, tcatch_command): Remove.
3703         (_initialize_breakpoint): Use add_basic_prefix_cmd,
3704         add_show_prefix_cmd.
3705         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
3706         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
3707         Remove.
3708         (add_internal_problem_command): Use add_basic_prefix_cmd,
3709         add_show_prefix_cmd.
3710         * mips-tdep.c (set_mipsfpu_command): Remove.
3711         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
3712         * dwarf2/index-cache.c (set_index_cache_command): Remove.
3713         (_initialize_index_cache): Use add_basic_prefix_cmd.
3714         * memattr.c (dummy_cmd): Remove.
3715         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
3716         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
3717         (_initialize_tui_win): Use add_basic_prefix_cmd,
3718         add_show_prefix_cmd.
3719         * cli/cli-logging.c (set_logging_command): Remove.
3720         (_initialize_cli_logging): Use add_basic_prefix_cmd,
3721         add_show_prefix_cmd.
3722         (show_logging_command): Remove.
3723         * target.c (target_command): Remove.
3724         (add_target): Use add_basic_prefix_cmd.
3725
3726 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
3727
3728         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
3729
3730 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3731
3732         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
3733         info_command.
3734
3735 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
3736
3737         * nbsd-nat.c (nbsd_enable_proc_events)
3738         (nbsd_nat_target::post_startup_inferior): Add.
3739         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
3740         (nbsd_nat_target::update_thread_list): Rewrite.
3741         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
3742         "PTRACE_LWP_CREATE".
3743         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
3744
3745 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3746
3747         * stack.c (_initialize_stack): Remove duplicated creation
3748         of "frame" command and "f" alias.
3749
3750 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
3751
3752         PR gdb/18706
3753         * gdbtypes.c (check_typedef): Calculate size of array of
3754         stubbed type.
3755
3756 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
3757
3758         PR gdb/15559
3759         * i386-tdep.c (i386_push_dummy_call): Call
3760         i386_thiscall_push_dummy_call.
3761         (i386_thiscall_push_dummy_call): New function.
3762         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
3763         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
3764         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
3765
3766 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3767
3768         * gdbarch.sh (do_read): Add shellcheck disable directive for
3769         warning SC2162.
3770
3771 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3772
3773         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
3774         "referenced but not assigned" warning.
3775
3776 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3777
3778         * gdbarch.sh: Remove code that sets fallbackdefault.
3779
3780 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3781
3782         * gdbarch.sh: Use shell operators && and || instead of
3783         -a and -o.
3784
3785 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3786
3787         * gdbarch.sh: Use $(...) instead of `...`.
3788
3789 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3790
3791         * gdbarch.sh: Use double quotes around variables.
3792
3793 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3794
3795         * gdbarch.sh: Use %s with printf, instead of variables in the
3796         format string.
3797
3798 2020-04-29  Tom Tromey  <tromey@adacore.com>
3799
3800         PR ada/25875:
3801         * dwarf2/read.c (update_enumeration_type_from_children): Compute
3802         type fields here.
3803         (read_enumeration_type): Call
3804         update_enumeration_type_from_children later.  Update comments.
3805         (process_enumeration_scope): Don't create type fields.
3806
3807 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
3808
3809         * nbsd-tdep.c: Include "xml-syscall.h".
3810         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
3811
3812 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
3813
3814         * nbsd-nat.c: Include "sys/wait.h".
3815         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
3816         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
3817         (nbsd_nat_target::remove_exec_catchpoint)
3818         (nbsd_nat_target::set_syscall_catchpoint): Add.
3819         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
3820         (nbsd_nat_target::insert_exec_catchpoint)
3821         (nbsd_nat_target::remove_exec_catchpoint)
3822         (nbsd_nat_target::set_syscall_catchpoint): Add.
3823         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
3824         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
3825         `nbsd_get_syscall_number'.
3826
3827 2020-04-29  Tom Tromey  <tom@tromey.com>
3828
3829         * stack.c (print_block_frame_labels): Remove.
3830
3831 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
3832
3833         PR gdb/17320
3834         * ada-valprint.c (val_print_packed_array_elements): Move array
3835         end bracket to new line.
3836         (ada_val_print_string): Remove extra spaces before first array
3837         element.
3838         * c-valprint.c (c_value_print_array): Likewise.
3839         * m2-valprint.c (m2_print_array_contents): Likewise.
3840         (m2_value_print_inner): Likewise.
3841         * p-valprint.c (pascal_value_print_inner): Likewise.
3842         * valprint.c (generic_val_print_array): Likewise.
3843         (value_print_array_elements): Move first array element and array
3844         end bracket to new line.
3845
3846 2020-04-29  Tom de Vries  <tdevries@suse.de>
3847
3848         PR symtab/25889
3849         * linespec.c (find_method): Fix ix calculation.
3850
3851 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
3852
3853         * syscalls/update-netbsd.sh: New file.
3854         * syscalls/netbsd.xml: Regenerate.
3855         * data-directory/Makefile.in: Register `netbsd.xml' in
3856         `SYSCALLS_FILES'.
3857
3858 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3859
3860         * syscalls/update-freebsd.sh: Add double quotes.
3861
3862 2020-04-28  Tom Tromey  <tom@tromey.com>
3863
3864         * NEWS: Update.
3865         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
3866         (cmdpy_init): Allow class_tui.
3867
3868 2020-04-28 Mark Williams <mark@myosotissp.com>
3869
3870         PR gdb/24480
3871         * dwarf2read.c: Add missing assingments to list_in_scope when
3872         start_symtab was already called.
3873
3874 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3875
3876         PR gdb/25881
3877         * dwarf2/read.c (offset_map_type): Use
3878         gdb:hash_enum<sect_offset> as hash function.
3879
3880 2020-04-28  Tom de Vries  <tdevries@suse.de>
3881
3882         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
3883         with DW_AT_signature.
3884
3885 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
3886
3887         * configure.ac: Remove check for fs_base/gs_base in
3888         user_regs_struct.
3889         * configure: Re-generate.
3890         * config.in: Re-generate.
3891         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
3892         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
3893         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
3894
3895 2020-04-27  Luis Machado  <luis.machado@linaro.org>
3896
3897         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
3898         problematic inline frame unwinding situation.
3899         * frame.c (frame_id_computed_p): New function.
3900         * frame.h (frame_id_computed_p): New prototype.
3901
3902 2020-04-26  Tom Tromey  <tom@tromey.com>
3903
3904         * command.h (enum command_class) <class_pseudo>: Remove.
3905
3906 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3907
3908         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
3909         and whitespace.
3910
3911 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
3912
3913         * inf-ptrace.c (inf_ptrace_target::wait): Remove
3914         `PT_GET_PROCESS_STATE' block.
3915
3916 2020-04-24  Tom Tromey  <tom@tromey.com>
3917
3918         * symtab.h (symbol_get_demangled_name): Don't declare.
3919         * symtab.c (symbol_get_demangled_name): Remove.
3920         (general_symbol_info::natural_name)
3921         (general_symbol_info::demangled_name): Update.
3922
3923 2020-04-24  Tom Tromey  <tom@tromey.com>
3924
3925         PR rust/25025:
3926         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
3927
3928 2020-04-24  Tom Tromey  <tom@tromey.com>
3929
3930         PR symtab/12707:
3931         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
3932         exists.
3933         (new_symbol): Likewise.
3934         * compile/compile-object-load.c (get_out_value_type): Use
3935         symbol_matches_search_name.
3936
3937 2020-04-24  Tom Tromey  <tom@tromey.com>
3938
3939         * dwarf2/read.c (add_partial_symbol): Do not call
3940         compute_and_set_names.
3941
3942 2020-04-24  Tom Tromey  <tom@tromey.com>
3943
3944         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
3945         overload.
3946
3947 2020-04-24  Tom Tromey  <tom@tromey.com>
3948
3949         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
3950         (add_psymbol_to_list): New overload.  Make old overload call new
3951         one.
3952         * psympriv.h (add_psymbol_to_list): New overload.
3953
3954 2020-04-24  Tom Tromey  <tom@tromey.com>
3955
3956         * dwarf2/read.c (partial_die_info::read) <case
3957         DW_AT_linkage_name>: Use value_as_string.
3958         (dwarf2_string_attr): Use value_as_string.
3959         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
3960         method.
3961         * dwarf2/attribute.c (attribute::value_as_string): New method.
3962
3963 2020-04-24  Tom Tromey  <tom@tromey.com>
3964
3965         * symtab.c (general_symbol_info::natural_name)
3966         (general_symbol_info::demangled_name): Check for language_rust.
3967
3968 2020-04-24  Tom Tromey  <tom@tromey.com>
3969
3970         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
3971         (dwarf2_physname): ... from here.
3972         (partial_die_info::read): Add Rust "{" hack.
3973
3974 2020-04-24  Tom Tromey  <tom@tromey.com>
3975
3976         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
3977         method.
3978         (symbol_set_demangled_name): Don't declare.
3979         * symtab.c (general_symbol_info::set_demangled_name): Rename from
3980         symbol_set_demangled_name.
3981         (general_symbol_info::set_language)
3982         (general_symbol_info::compute_and_set_names): Update.
3983         * minsyms.c (minimal_symbol_reader::install): Update.
3984         * dwarf2/read.c (new_symbol): Update.
3985
3986 2020-04-24  Tom Tromey  <tromey@adacore.com>
3987
3988         PR python/23662:
3989         * python/py-type.c (convert_field): Handle
3990         FIELD_LOC_KIND_DWARF_BLOCK.
3991         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
3992         (typy_get_dynamic): Nw function.
3993         (type_object_getset): Add "dynamic".
3994         * NEWS: Add entry.
3995
3996 2020-04-24  Tom Tromey  <tromey@adacore.com>
3997
3998         * ada-typeprint.c (print_choices, print_variant_part)
3999         (print_record_field_types_dynamic): New functions.
4000         (print_record_field_types): Use print_record_field_types_dynamic.
4001
4002 2020-04-24  Tom Tromey  <tromey@adacore.com>
4003
4004         * dwarf2/read.c (handle_data_member_location): New overload.
4005         (dwarf2_add_field): Use it.
4006         (decode_locdesc): Add "computed" parameter.  Update comment.
4007         * gdbtypes.c (is_dynamic_type_internal): Also look for
4008         FIELD_LOC_KIND_DWARF_BLOCK.
4009         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
4010         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
4011         virtual base classes.
4012         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
4013         FIELD_LOC_KIND_DWARF_BLOCK.
4014
4015 2020-04-24  Tom Tromey  <tromey@adacore.com>
4016
4017         * dwarf2/read.c (read_structure_type): Handle dynamic length.
4018         * gdbtypes.c (is_dynamic_type_internal): Check
4019         TYPE_HAS_DYNAMIC_LENGTH.
4020         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
4021         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
4022         New macros.
4023         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
4024         constant.
4025
4026 2020-04-24  Tom Tromey  <tromey@adacore.com>
4027
4028         * dwarf2/read.c (struct variant_field): Rewrite.
4029         (struct variant_part_builder): New.
4030         (struct nextfield): Remove "variant" field.  Add "offset".
4031         (struct field_info): Add "current_variant_part" and
4032         "variant_parts".
4033         (alloc_discriminant_info): Remove.
4034         (alloc_rust_variant): New function.
4035         (quirk_rust_enum): Update.
4036         (dwarf2_add_field): Set "offset" member.  Don't handle
4037         DW_TAG_variant_part.
4038         (offset_map_type): New typedef.
4039         (convert_variant_range, create_one_variant)
4040         (create_one_variant_part, create_variant_parts)
4041         (add_variant_property): New functions.
4042         (dwarf2_attach_fields_to_type): Call add_variant_property.
4043         (read_structure_type): Don't handle DW_TAG_variant_part.
4044         (handle_variant_part, handle_variant): New functions.
4045         (handle_struct_member_die): Use them.
4046         (process_structure_scope): Don't handle variant parts.
4047         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
4048         (struct discriminant_info): Remove.
4049         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
4050         (struct main_type) <flag_discriminated_union>: Remove.
4051         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
4052         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
4053         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
4054         Update.
4055         * valops.c (value_union_variant): Remove.
4056         * value.h (value_union_variant): Don't declare.
4057
4058 2020-04-24  Tom Tromey  <tromey@adacore.com>
4059
4060         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
4061         (ada_value_primitive_packed_val): Update.
4062         * ada-valprint.c (ada_value_print_1): Update.
4063         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
4064         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
4065         just an address.  Use evaluate_for_locexpr_baton.
4066         (dwarf2_evaluate_property): Update.
4067         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
4068         array_view.
4069         * findvar.c (default_read_var_value): Update.
4070         * gdbtypes.c (compute_variant_fields_inner)
4071         (resolve_dynamic_type_internal): Update.
4072         (resolve_dynamic_type): Change type of valaddr parameter.
4073         * gdbtypes.h (resolve_dynamic_type): Update.
4074         * valarith.c (value_subscripted_rvalue): Update.
4075         * value.c (value_from_contents_and_address): Update.
4076
4077 2020-04-24  Tom Tromey  <tromey@adacore.com>
4078
4079         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
4080         "push_initial_value" parameter.
4081         (dwarf2_evaluate_property): Likewise.
4082         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
4083
4084 2020-04-24  Tom Tromey  <tromey@adacore.com>
4085
4086         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
4087         (variant::matches, compute_variant_fields_recurse)
4088         (compute_variant_fields_inner, compute_variant_fields): New
4089         functions.
4090         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
4091         Use resolved_type after type is made.
4092         (operator==): Add new cases.
4093         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
4094         (struct discriminant_range, struct variant, struct variant_part):
4095         New.
4096         (union dynamic_prop_data) <variant_parts, original_type>: New
4097         members.
4098         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
4099         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
4100         constants.
4101         * value.c (unpack_bits_as_long): Now public.
4102         * value.h (unpack_bits_as_long): Declare.
4103
4104 2020-04-24  Tom Tromey  <tromey@adacore.com>
4105
4106         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
4107         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
4108
4109 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
4110
4111         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
4112
4113 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
4114
4115         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
4116         (remove_fork_catchpoint, post_startup_inferior)
4117         (post_attach): Move...
4118         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
4119         (remove_fork_catchpoint, post_startup_inferior)
4120         (post_attach): ...here.
4121         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
4122         (remove_fork_catchpoint, post_startup_inferior)
4123         (post_attach): Move...
4124         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
4125         (remove_fork_catchpoint, post_startup_inferior)
4126         (post_attach): ...here.
4127
4128 2020-04-24  Tom Tromey  <tromey@adacore.com>
4129
4130         * nat/windows-nat.h (struct windows_thread_info)
4131         <pc_adjusted>: New member.
4132         * windows-nat.c (windows_fetch_one_register): Check
4133         pc_adjusted.
4134         (windows_nat_target::get_windows_debug_event)
4135         (windows_nat_target::wait): Set pc_adjusted.
4136
4137 2020-04-24  Tom de Vries  <tdevries@suse.de>
4138
4139         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
4140         Run gdb-add-index inside temp dir.
4141
4142 2020-04-23  Tom Tromey  <tromey@adacore.com>
4143
4144         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
4145         in loop.
4146
4147 2020-04-23  Luis Machado  <luis.machado@linaro.org>
4148
4149         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
4150         get_frame_register instead of gdbarch_unwind_pc.
4151
4152 2020-04-23  Tom de Vries  <tdevries@suse.de>
4153
4154         * symtab.c (lookup_global_symbol): Prefer def over decl.
4155
4156 2020-04-23  Tom de Vries  <tdevries@suse.de>
4157
4158         PR symtab/25807
4159         * block.c (best_symbol, better_symbol): Promote to external.
4160         * block.h (best_symbol, better_symbol): Declare.
4161         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
4162         decl.
4163
4164 2020-04-23  Tom Tromey  <tromey@adacore.com>
4165
4166         PR ada/25837:
4167         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
4168         "const char *", not a "const std::string &".
4169         <name_and_matcher::operator==>: Update.
4170         * unittests/lookup_name_info-selftests.c: Change type of
4171         "result".
4172
4173 2020-04-23  Tom Tromey  <tom@tromey.com>
4174
4175         * inferior.h (iterate_over_inferiors): Don't declare.
4176         * inferior.c (iterate_over_inferiors): Remove.
4177         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
4178         Remove.
4179         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
4180         use iterate_over_inferiors.
4181         (darwin_resume_inferior_it)
4182         (struct resume_inferior_threads_param)
4183         (darwin_resume_inferior_threads_it): Remove.
4184         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
4185
4186 2020-04-23  Tom de Vries  <tdevries@suse.de>
4187
4188         * blockframe.c (find_pc_partial_function): Use
4189         find_pc_sect_compunit_symtab rather than
4190         objfile->sf->qf->find_pc_sect_compunit_symtab.
4191
4192 2020-04-22  Tom de Vries  <tdevries@suse.de>
4193
4194         PR symtab/25764
4195         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
4196         in psymtabs.
4197
4198 2020-04-22  Tom de Vries  <tdevries@suse.de>
4199
4200         PR symtab/25801
4201         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
4202         symtabs.
4203
4204 2020-04-22  Tom de Vries  <tdevries@suse.de>
4205
4206         PR symtab/25700
4207         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
4208         CU if already created.
4209
4210 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4211
4212         * infrun.c (displaced_step_fixup): Switch to the event_thread
4213         before calling displaced_step_restore, not after.
4214
4215 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
4216
4217         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
4218         its inferior is not recorded by us.
4219         (record_btrace_target_open): Replace call to
4220         all_non_exited_threads () with call to current_inferior
4221         ()->non_exited_threads ().
4222         (record_btrace_target::stop_recording): Likewise.
4223         (record_btrace_target::close): Likewise.
4224         (record_btrace_target::wait): Likewise.
4225         (record_btrace_target::record_stop_replaying): Likewise.
4226
4227 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
4228
4229         * btrace.c (btrace_enable): Throw an error on double enables and
4230         when enabling recording fails.
4231         (btrace_disable): Throw an error if the thread is not recorded.
4232
4233 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
4234
4235         * record-btrace.c (record_btrace_target::fetch_registers): Forward
4236         request if we do not have a thread_info.
4237
4238 2020-04-21  Tom de Vries  <tdevries@suse.de>
4239
4240         PR gdb/25471
4241         * thread.c
4242         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
4243         exception in get_frame_id.
4244
4245 2020-04-20  Tom Tromey  <tromey@adacore.com>
4246
4247         * python/python.c (struct gdbpy_event): Mark move constructor as
4248         noexcept.
4249         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
4250         constructor as noexcept.
4251         * completer.h (struct completion_result): Mark move constructor as
4252         noexcept.
4253         * completer.c (completion_result::completion_result): Use
4254         initialization style.  Don't call reset_match_list.
4255
4256 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
4257
4258         * MAINTAINERS (Write After Approval): Add myself.
4259
4260 2020-04-18  Tom Tromey  <tom@tromey.com>
4261
4262         * windows-tdep.c (init_w32_command_list)
4263         (w32_prefix_command_valid): Restore.
4264         (_initialize_windows_tdep): Call init_w32_command_list.
4265
4266 2020-04-18  Tom Tromey  <tom@tromey.com>
4267
4268         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
4269         * value.c (value_fn_field): Update.
4270         * valops.c (find_function_in_inferior)
4271         (value_allocate_space_in_inferior): Update.
4272         * tui/tui-winsource.c (tui_update_source_windows_with_line):
4273         Update.
4274         * tui/tui-source.c (tui_source_window::set_contents): Update.
4275         * symtab.c (lookup_global_or_static_symbol)
4276         (find_function_start_sal_1, skip_prologue_sal)
4277         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
4278         * symmisc.c (dump_msymbols, dump_symtab_1)
4279         (maintenance_print_one_line_table): Update.
4280         * symfile.c (init_entry_point_info, section_is_mapped)
4281         (list_overlays_command, simple_read_overlay_table)
4282         (simple_overlay_update_1): Update.
4283         * stap-probe.c (handle_stap_probe): Update.
4284         * stabsread.c (dbx_init_float_type, define_symbol)
4285         (read_one_struct_field, read_enum_type, read_range_type): Update.
4286         * source.c (info_line_command): Update.
4287         * python/python.c (gdbpy_source_objfile_script)
4288         (gdbpy_execute_objfile_script): Update.
4289         * python/py-type.c (save_objfile_types): Update.
4290         * python/py-objfile.c (py_free_objfile): Update.
4291         * python/py-inferior.c (python_new_objfile): Update.
4292         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
4293         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
4294         (maintenance_check_psymtabs): Update.
4295         * printcmd.c (info_address_command): Update.
4296         * objfiles.h (struct objfile) <arch>: New method, from
4297         get_objfile_arch.
4298         (get_objfile_arch): Don't declare.
4299         * objfiles.c (get_objfile_arch): Remove.
4300         (filter_overlapping_sections): Update.
4301         * minsyms.c (msymbol_is_function): Update.
4302         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
4303         (output_nondebug_symbol): Update.
4304         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
4305         (mdebug_expand_psymtab): Update.
4306         * machoread.c (macho_add_oso_symfile): Update.
4307         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
4308         Update.
4309         * linux-fork.c (checkpoint_command): Update.
4310         * linespec.c (convert_linespec_to_sals): Update.
4311         * jit.c (finalize_symtab): Update.
4312         * infrun.c (insert_exception_resume_from_probe): Update.
4313         * ia64-tdep.c (ia64_find_unwind_table): Update.
4314         * hppa-tdep.c (internalize_unwinds): Update.
4315         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
4316         Update.
4317         * gcore.c (call_target_sbrk): Update.
4318         * elfread.c (record_minimal_symbol, elf_symtab_read)
4319         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
4320         (elf_gnu_ifunc_resolve_by_got): Update.
4321         * dwarf2/read.c (create_addrmap_from_index)
4322         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4323         (read_debug_names_from_section)
4324         (process_psymtab_comp_unit_reader, add_partial_symbol)
4325         (add_partial_subprogram, process_full_comp_unit)
4326         (read_file_scope, read_func_scope, read_lexical_block_scope)
4327         (read_call_site_scope, dwarf2_ranges_read)
4328         (dwarf2_record_block_ranges, dwarf2_add_field)
4329         (mark_common_block_symbol_computed, read_tag_pointer_type)
4330         (read_tag_string_type, dwarf2_init_float_type)
4331         (dwarf2_init_complex_target_type, read_base_type)
4332         (partial_die_info::read, partial_die_info::read)
4333         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
4334         (dwarf2_fetch_die_loc_sect_off): Update.
4335         * dwarf2/loc.c (dwarf2_find_location_expression)
4336         (class dwarf_evaluate_loc_desc, rw_pieced_value)
4337         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
4338         (dwarf2_loc_desc_get_symbol_read_needs)
4339         (locexpr_describe_location_piece, locexpr_describe_location_1)
4340         (loclist_describe_location): Update.
4341         * dwarf2/index-write.c (write_debug_names): Update.
4342         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
4343         * dtrace-probe.c (dtrace_process_dof): Update.
4344         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
4345         (process_one_symbol): Update.
4346         * ctfread.c (ctf_init_float_type, read_base_type): Update.
4347         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
4348         (coff_read_enum_type): Update.
4349         * cli/cli-cmds.c (edit_command, list_command): Update.
4350         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
4351         * breakpoint.c (create_overlay_event_breakpoint)
4352         (create_longjmp_master_breakpoint)
4353         (create_std_terminate_master_breakpoint)
4354         (create_exception_master_breakpoint, get_sal_arch): Update.
4355         * block.c (block_gdbarch): Update.
4356         * annotate.c (annotate_source_line): Update.
4357
4358 2020-04-17  Tom Tromey  <tromey@adacore.com>
4359
4360         * auto-load.c (show_auto_load_cmd): Remove.
4361         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
4362         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
4363         (maintenance_print_arc_command): Remove.
4364         * tui/tui-win.c (tui_command): Remove.
4365         (tui_get_cmd_list): Use add_basic_prefix_cmd.
4366         * tui/tui-layout.c (tui_layout_command): Remove.
4367         (_initialize_tui_layout): Use add_basic_prefix_cmd.
4368         * python/python.c (user_set_python, user_show_python): Remove.
4369         (_initialize_python): Use add_basic_prefix_cmd,
4370         add_show_prefix_cmd.
4371         * guile/guile.c (set_guile_command, show_guile_command): Remove.
4372         (install_gdb_commands): Use add_basic_prefix_cmd,
4373         add_show_prefix_cmd.
4374         (info_guile_command): Remove.
4375         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
4376         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
4377         add_show_prefix_cmd.
4378         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
4379         Remove do_set and do_show parameters.
4380         * cli/cli-style.c (set_style, show_style): Remove.
4381         (_initialize_cli_style): Use add_basic_prefix_cmd,
4382         add_show_prefix_cmd.
4383         (cli_style_option::add_setshow_commands): Remove do_set and
4384         do_show parameters.
4385         (cli_style_option::add_setshow_commands): Use
4386         add_basic_prefix_cmd, add_show_prefix_cmd.
4387         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
4388         (set_style_name): Remove.
4389         * cli/cli-dump.c (dump_command, append_command): Remove.
4390         (srec_dump_command, ihex_dump_command, verilog_dump_command)
4391         (tekhex_dump_command, binary_dump_command)
4392         (binary_append_command): Remove.
4393         (_initialize_cli_dump): Use add_basic_prefix_cmd.
4394         * windows-tdep.c (w32_prefix_command_valid): Remove global.
4395         (init_w32_command_list): Remove; move into ...
4396         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
4397         * valprint.c (set_print, show_print, set_print_raw)
4398         (show_print_raw): Remove.
4399         (_initialize_valprint): Use add_basic_prefix_cmd,
4400         add_show_prefix_cmd.
4401         * typeprint.c (set_print_type, show_print_type): Remove.
4402         (_initialize_typeprint): Use add_basic_prefix_cmd,
4403         add_show_prefix_cmd.
4404         * record.c (set_record_command, show_record_command): Remove.
4405         (_initialize_record): Use add_basic_prefix_cmd,
4406         add_show_prefix_cmd.
4407         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
4408         add_show_prefix_cmd.
4409         (info_command, show_command, set_debug, show_debug): Remove.
4410         * top.h (set_history, show_history): Don't declare.
4411         * top.c (set_history, show_history): Remove.
4412         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
4413         (unset_tdesc_cmd): Remove.
4414         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
4415         add_show_prefix_cmd.
4416         * symtab.c (info_module_command): Remove.
4417         (_initialize_symtab): Use add_basic_prefix_cmd.
4418         * symfile.c (overlay_command): Remove.
4419         (_initialize_symfile): Use add_basic_prefix_cmd.
4420         * sparc64-tdep.c (info_adi_command): Remove.
4421         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
4422         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
4423         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
4424         add_show_prefix_cmd.
4425         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
4426         (_initialize_serial): Use add_basic_prefix_cmd,
4427         add_show_prefix_cmd.
4428         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
4429         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
4430         add_show_prefix_cmd.
4431         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
4432         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
4433         add_show_prefix_cmd.
4434         * riscv-tdep.c (show_riscv_command, set_riscv_command)
4435         (show_debug_riscv_command, set_debug_riscv_command): Remove.
4436         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
4437         add_show_prefix_cmd.
4438         * remote.c (remote_command, set_remote_cmd): Remove.
4439         (_initialize_remote): Use add_basic_prefix_cmd.
4440         * record-full.c (set_record_full_command)
4441         (show_record_full_command): Remove.
4442         (_initialize_record_full): Use add_basic_prefix_cmd,
4443         add_show_prefix_cmd.
4444         * record-btrace.c (cmd_set_record_btrace)
4445         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
4446         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
4447         (cmd_show_record_btrace_pt): Remove.
4448         (_initialize_record_btrace): Use add_basic_prefix_cmd,
4449         add_show_prefix_cmd.
4450         * ravenscar-thread.c (set_ravenscar_command)
4451         (show_ravenscar_command): Remove.
4452         (_initialize_ravenscar): Use add_basic_prefix_cmd,
4453         add_show_prefix_cmd.
4454         * mips-tdep.c (show_mips_command, set_mips_command)
4455         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
4456         add_show_prefix_cmd.
4457         * maint.c (maintenance_command, maintenance_info_command)
4458         (maintenance_check_command, maintenance_print_command)
4459         (maintenance_set_cmd, maintenance_show_cmd): Remove.
4460         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
4461         add_show_prefix_cmd.
4462         (show_per_command_cmd): Remove.
4463         * maint-test-settings.c (maintenance_set_test_settings_cmd):
4464         Remove.
4465         (maintenance_show_test_settings_cmd): Remove.
4466         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
4467         add_show_prefix_cmd.
4468         * maint-test-options.c (maintenance_test_options_command):
4469         Remove.
4470         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
4471         * macrocmd.c (macro_command): Remove
4472         (_initialize_macrocmd): Use add_basic_prefix_cmd.
4473         * language.c (set_check, show_check): Remove.
4474         (_initialize_language): Use add_basic_prefix_cmd,
4475         add_show_prefix_cmd.
4476         * infcmd.c (unset_command): Remove.
4477         (_initialize_infcmd): Use add_basic_prefix_cmd.
4478         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
4479         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
4480         add_show_prefix_cmd.
4481         * go32-nat.c (go32_info_dos_command): Remove.
4482         (_initialize_go32_nat): Use add_basic_prefix_cmd.
4483         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
4484         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
4485         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
4486         (_initialize_frame): Use add_basic_prefix_cmd,
4487         add_show_prefix_cmd.
4488         * dcache.c (set_dcache_command, show_dcache_command): Remove.
4489         (_initialize_dcache): Use add_basic_prefix_cmd,
4490         add_show_prefix_cmd.
4491         * cp-support.c (maint_cplus_command): Remove.
4492         (_initialize_cp_support): Use add_basic_prefix_cmd.
4493         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
4494         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
4495         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
4496         add_basic_prefix_cmd, add_show_prefix_cmd.
4497         * breakpoint.c (save_command): Remove.
4498         (_initialize_breakpoint): Use add_basic_prefix_cmd.
4499         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
4500         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
4501         add_show_prefix_cmd.
4502         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
4503         (set_ada_command, show_ada_command): Remove.
4504         (_initialize_ada_language): Use add_basic_prefix_cmd,
4505         add_show_prefix_cmd.
4506         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
4507
4508 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
4509
4510         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
4511         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
4512
4513 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
4514
4515         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
4516         warning messages.
4517
4518 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
4519
4520         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
4521         import table is not at beginning of .idata section.
4522
4523 2020-04-16  Pedro Alves  <palves@redhat.com>
4524
4525         * inferior.c (delete_inferior): Use delete operator directly
4526         instead of delete_program_space.
4527         * progspace.c (add_program_space): New, factored out from
4528         program_space::program_space.
4529         (remove_program_space): New, factored out from
4530         delete_program_space.
4531         (program_space::program_space): Remove intro comment.  Rewrite.
4532         (program_space::~program_space): Remove intro comment.  Call
4533         remove_program_space.
4534         (delete_program_space): Delete.
4535         * progspace.h (program_space::program_space): Make explicit.  Move
4536         intro comment here, adjusted.
4537         (program_space::~program_space): Move intro comment here,
4538         adjusted.
4539         (delete_program_space): Remove.
4540
4541 2020-04-16  Tom Tromey  <tromey@adacore.com>
4542
4543         * windows-nat.c (windows_nat::handle_access_violation): New
4544         function.
4545         * nat/windows-nat.h (handle_access_violation): Declare.
4546         * nat/windows-nat.c (handle_exception): Move Cygwin code to
4547         windows-nat.c.  Call handle_access_violation.
4548
4549 2020-04-16  Tom de Vries  <tdevries@suse.de>
4550
4551         PR symtab/25791
4552         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
4553         CUs without psymtab.
4554
4555 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
4556
4557         * python/python.c (do_start_initialization): Don't call
4558         PyEval_InitThreads for Python 3.9 and beyond.
4559
4560 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
4561
4562         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
4563         thread functions.
4564         (obsd_nat_target::wait): Likewise.
4565
4566 2020-04-15  Tom Tromey  <tromey@adacore.com>
4567
4568         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
4569         (DEBUG_EXCEPT): Use debug_printf.
4570
4571 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4572
4573         * completer.c (class completion_tracker::completion_hash_entry)
4574         <hash_name>: New member function.
4575         (completion_tracker::discard_completions): New callback to hash a
4576         completion_hash_entry, pass this to htab_create_alloc.
4577
4578 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
4579
4580         * windows-nat.c (windows_make_so): Warn rather than stopping with
4581         an error if realpath() fails.
4582
4583 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
4584
4585         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
4586         (nbsd_nat_target::info_proc): Add do_status.
4587
4588 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
4589             Tom de Vries  <tdevries@suse.de>
4590
4591         PR symtab/25718
4592         * psympriv.h (struct partial_symtab::read_symtab)
4593         (struct partial_symtab::expand_psymtab)
4594         (struct partial_symtab::read_dependencies): Update comments.
4595         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
4596         read_symtab for includer.
4597         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
4598         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
4599         (struct dwarf2_include_psymtab::m_readin): Remove.
4600         (struct dwarf2_include_psymtab::includer): New member function.
4601         (dwarf2_psymtab::expand_psymtab): Assert !readin.
4602
4603 2020-04-14  Tom de Vries  <tdevries@suse.de>
4604
4605         PR symtab/25720
4606         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
4607         with NULL symbol_matcher and lookup_name.
4608         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
4609         and lookup_name.
4610         * dwarf2/read.c (dw2_expand_symtabs_matching)
4611         (dw2_debug_names_expand_symtabs_matching): Same.
4612         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
4613         Make lookup_name a pointer.  Update comment.
4614         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
4615         lookup_name being a pointer.
4616         * symfile.c (expand_symtabs_matching): Same.
4617         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
4618         * linespec.c (iterate_over_all_matching_symtabs): Same.
4619
4620 2020-04-13  Tom Tromey  <tom@tromey.com>
4621
4622         * run-on-main-thread.c: Update include.
4623         * unittests/main-thread-selftests.c: Update include.
4624         * tui/tui-win.c: Update include.
4625         * tui/tui-io.c: Update include.
4626         * tui/tui-interp.c: Update include.
4627         * tui/tui-hooks.c: Update include.
4628         * top.h: Update include.
4629         * top.c: Update include.
4630         * ser-base.c: Update include.
4631         * remote.c: Update include.
4632         * remote-notif.c: Update include.
4633         * remote-fileio.c: Update include.
4634         * record-full.c: Update include.
4635         * record-btrace.c: Update include.
4636         * python/python.c: Update include.
4637         * posix-hdep.c: Update include.
4638         * mingw-hdep.c: Update include.
4639         * mi/mi-main.c: Update include.
4640         * mi/mi-interp.c: Update include.
4641         * main.c: Update include.
4642         * linux-nat.c: Update include.
4643         * interps.c: Update include.
4644         * infrun.c: Update include.
4645         * inf-loop.c: Update include.
4646         * event-top.c: Update include.
4647         * event-loop.c: Move to ../gdbsupport/.
4648         * event-loop.h: Move to ../gdbsupport/.
4649         * async-event.h: Update include.
4650         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
4651
4652 2020-04-13  Tom Tromey  <tom@tromey.com>
4653
4654         * tui/tui-win.c: Include async-event.h.
4655         * remote.c: Include async-event.h.
4656         * remote-notif.c: Include async-event.h.
4657         * record-full.c: Include async-event.h.
4658         * record-btrace.c: Include async-event.h.
4659         * infrun.c: Include async-event.h.
4660         * event-top.c: Include async-event.h.
4661         * event-loop.h: Move some declarations to async-event.h.
4662         * event-loop.c: Don't include ser-event.h or top.h.  Move some
4663         code to async-event.c.
4664         * async-event.h: New file.
4665         * async-event.c: New file.
4666         * Makefile.in (COMMON_SFILES): Add async-event.c.
4667         (HFILES_NO_SRCDIR): Add async-event.h.
4668
4669 2020-04-13  Tom Tromey  <tom@tromey.com>
4670
4671         * utils.c (flush_streams): New function.
4672         * event-loop.c (gdb_wait_for_event): Call flush_streams.
4673
4674 2020-04-13  Tom Tromey  <tom@tromey.com>
4675
4676         * event-loop.c (handle_file_event): Use warning, not
4677         printf_unfiltered.
4678
4679 2020-04-13  Tom Tromey  <tom@tromey.com>
4680
4681         * event-loop.c: Include <chrono>.
4682
4683 2020-04-13  Tom Tromey  <tom@tromey.com>
4684
4685         * gdb_select.h: Move to ../gdbsupport/.
4686         * event-loop.c: Update include path.
4687         * top.c: Update include path.
4688         * ser-base.c: Update include path.
4689         * ui-file.c: Update include path.
4690         * ser-tcp.c: Update include path.
4691         * guile/scm-ports.c: Update include path.
4692         * posix-hdep.c: Update include path.
4693         * ser-unix.c: Update include path.
4694         * gdb_usleep.c: Update include path.
4695         * mingw-hdep.c: Update include path.
4696         * inflow.c: Update include path.
4697         * infrun.c: Update include path.
4698         * event-top.c: Update include path.
4699
4700 2020-04-13  Tom Tromey  <tom@tromey.com>
4701
4702         * configure: Rebuild.
4703         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
4704
4705 2020-04-13  Tom Tromey  <tom@tromey.com>
4706
4707         * event-loop.h (start_event_loop): Don't declare.
4708         * event-loop.c (start_event_loop): Move...
4709         * main.c (start_event_loop): ...here.  Now static.
4710
4711 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
4712
4713         * MAINTAINERS: Update my email address.
4714
4715 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4716
4717         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
4718         IP_ALL.
4719
4720 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4721
4722         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
4723         (nbsd_nat_target::info_proc): Add do_cmdline.
4724
4725 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4726
4727         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
4728         (nbsd_nat_target::info_proc): Add do_cwd.
4729
4730 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4731
4732         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
4733
4734 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
4735
4736         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
4737         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
4738         (nbsd_nat_target::info_proc): New functions.
4739         * nbsd-nat.c (kinfo_get_vmmap): New function.
4740         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
4741         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
4742         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
4743         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
4744         functions.
4745         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
4746         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
4747         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
4748         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
4749         (KINFO_VME_FLAG_GROWS_DOWN): New.
4750
4751 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
4752
4753         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
4754         bit shift.
4755
4756 2020-04-10  Tom Tromey  <tromey@adacore.com>
4757
4758         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
4759
4760 2020-04-10  Tom Tromey  <tromey@adacore.com>
4761
4762         * symtab.c (get_symbol_address, get_msymbol_address): Skip
4763         separate debug files.
4764
4765 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
4766
4767         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4768         Move to...
4769         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4770         ... here.
4771         * windows-nat.c (windows_nat_target::get_windows_debug_event):
4772         Check for STATUS_WX86_BREAKPOINT.
4773         (windows_nat_target::wait): Same.
4774
4775 2020-04-10  Tom de Vries  <tdevries@suse.de>
4776
4777         PR cli/25808
4778         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
4779
4780 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4781
4782         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
4783         (Write After Approval): Remove Tom de Vries.
4784
4785 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4786
4787         revert partially:
4788         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4789
4790         * buildsym.c (record_line): Fix undefined behavior and preserve
4791         lines at eof.
4792
4793 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
4794
4795         * auxv.h (svr4_auxv_parse): New.
4796         * auxv.c (default_auxv_parse): Split into default_auxv_parse
4797         and generic_auxv_parse.
4798         (svr4_auxv_parse): Add.
4799         * obsd-tdep.c: Include "auxv.h".
4800         (obsd_auxv_parse): Remove.
4801         (obsd_init_abi): Remove comment.
4802         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
4803         from `obsd_auxv_parse' to `svr4_auxv_parse'.
4804         * nbsd-tdep.c: Include "auxv.h".
4805         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
4806
4807 2020-04-08  Tom Tromey  <tromey@adacore.com>
4808
4809         * nat/windows-nat.h (last_wait_event): Don't declare.
4810         (wait_for_debug_event): Update comment.
4811         * nat/windows-nat.c (last_wait_event): Now static.
4812
4813 2020-04-08  Tom Tromey  <tromey@adacore.com>
4814
4815         * windows-nat.c (wait_for_debug_event): Move to
4816         nat/windows-nat.c.
4817         * nat/windows-nat.h (wait_for_debug_event): Declare.
4818         * nat/windows-nat.c (wait_for_debug_event): Move from
4819         windows-nat.c.  No longer static.
4820
4821 2020-04-08  Tom Tromey  <tromey@adacore.com>
4822
4823         * windows-nat.c (get_windows_debug_event): Use
4824         fetch_pending_stop.
4825         * nat/windows-nat.h (fetch_pending_stop): Declare.
4826         * nat/windows-nat.c (fetch_pending_stop): New function.
4827
4828 2020-04-08  Tom Tromey  <tromey@adacore.com>
4829
4830         * windows-nat.c (windows_continue): Use matching_pending_stop and
4831         continue_last_debug_event.
4832         * nat/windows-nat.h (matching_pending_stop)
4833         (continue_last_debug_event): Declare.
4834         * nat/windows-nat.c (DEBUG_EVENTS): New define.
4835         (matching_pending_stop, continue_last_debug_event): New
4836         functions.
4837
4838 2020-04-08  Tom Tromey  <tromey@adacore.com>
4839
4840         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
4841         (handle_exception_result): Move to nat/windows-nat.h.
4842         (DEBUG_EXCEPTION_SIMPLE): Remove.
4843         (windows_nat::handle_ms_vc_exception): New function.
4844         (handle_exception): Move to nat/windows-nat.c.
4845         (get_windows_debug_event): Update.
4846         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
4847         nat/windows-nat.c.
4848         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
4849         (handle_exception_result): Move from windows-nat.c.
4850         (handle_exception): Declare.
4851         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
4852         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
4853         windows-nat.c.
4854
4855 2020-04-08  Tom Tromey  <tromey@adacore.com>
4856
4857         * windows-nat.c (exception_count, event_count): Remove.
4858         (handle_exception, get_windows_debug_event)
4859         (do_initial_windows_stuff): Update.
4860
4861 2020-04-08  Tom Tromey  <tromey@adacore.com>
4862
4863         * windows-nat.c (windows_nat::handle_load_dll)
4864         (windows_nat::handle_unload_dll): Rename.  No longer static.
4865         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
4866         Declare.
4867
4868 2020-04-08  Tom Tromey  <tromey@adacore.com>
4869
4870         * complaints.h (stop_whining): Declare at top-level.
4871         (complaint): Don't declare stop_whining.
4872
4873 2020-04-08  Tom Tromey  <tromey@adacore.com>
4874
4875         * windows-nat.c (windows_nat::handle_output_debug_string):
4876         Rename.  No longer static.
4877         * nat/windows-nat.h (handle_output_debug_string): Declare.
4878
4879 2020-04-08  Tom Tromey  <tromey@adacore.com>
4880
4881         * windows-nat.c (current_process_handle, current_process_id)
4882         (main_thread_id, last_sig, current_event, last_wait_event)
4883         (current_windows_thread, desired_stop_thread_id, pending_stops)
4884         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
4885         (display_selectors, fake_create_process)
4886         (get_windows_debug_event): Update.
4887         * nat/windows-nat.h (current_process_handle, current_process_id)
4888         (main_thread_id, last_sig, current_event, last_wait_event)
4889         (current_windows_thread, desired_stop_thread_id, pending_stops)
4890         (struct pending_stop, siginfo_er): Move from windows-nat.c.
4891         * nat/windows-nat.c (current_process_handle, current_process_id)
4892         (main_thread_id, last_sig, current_event, last_wait_event)
4893         (current_windows_thread, desired_stop_thread_id, pending_stops)
4894         (siginfo_er): New globals.  Move from windows-nat.c.
4895
4896 2020-04-08  Tom Tromey  <tromey@adacore.com>
4897
4898         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
4899         (handle_load_dll): Update.
4900         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
4901
4902 2020-04-08  Tom Tromey  <tromey@adacore.com>
4903
4904         * windows-nat.c (enum thread_disposition_type): Move to
4905         nat/windows-nat.h.
4906         (windows_nat::thread_rec): Rename from thread_rec.  No longer
4907         static.
4908         (windows_add_thread, windows_nat_target::fetch_registers)
4909         (windows_nat_target::store_registers, handle_exception)
4910         (windows_nat_target::resume, get_windows_debug_event)
4911         (windows_nat_target::get_tib_address)
4912         (windows_nat_target::thread_name)
4913         (windows_nat_target::thread_alive): Update.
4914         * nat/windows-nat.h (enum thread_disposition_type): Move from
4915         windows-nat.c.
4916         (thread_rec): Declare.
4917
4918 2020-04-08  Tom Tromey  <tromey@adacore.com>
4919
4920         * windows-nat.c: Add "using namespace".
4921         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
4922         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
4923
4924 2020-04-08  Tom Tromey  <tromey@adacore.com>
4925
4926         * nat/windows-nat.h (struct windows_thread_info): Declare
4927         destructor.
4928         * nat/windows-nat.c (~windows_thread_info): New.
4929
4930 2020-04-08  Tom Tromey  <tromey@adacore.com>
4931
4932         PR gdb/22992
4933         * windows-nat.c (current_event): Update comment.
4934         (last_wait_event, desired_stop_thread_id): New globals.
4935         (struct pending_stop): New.
4936         (pending_stops): New global.
4937         (windows_nat_target) <stopped_by_sw_breakpoint>
4938         <supports_stopped_by_sw_breakpoint>: New methods.
4939         (windows_fetch_one_register): Add assertions.  Adjust PC.
4940         (windows_continue): Handle pending stops.  Suspend other threads
4941         when stepping.  Use last_wait_event
4942         (wait_for_debug_event): New function.
4943         (get_windows_debug_event): Use wait_for_debug_event.  Handle
4944         pending stops.  Queue spurious stops.
4945         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
4946         (windows_nat_target::kill): Use wait_for_debug_event.
4947         * nat/windows-nat.h (struct windows_thread_info)
4948         <stopped_at_software_breakpoint>: New field.
4949         * nat/windows-nat.c (windows_thread_info::resume): Clear
4950         stopped_at_software_breakpoint.
4951
4952 2020-04-08  Tom Tromey  <tromey@adacore.com>
4953
4954         * windows-nat.c (enum thread_disposition_type): New.
4955         (thread_rec): Replace "get_context" parameter with "disposition";
4956         change type.
4957         (windows_add_thread, windows_nat_target::fetch_registers)
4958         (windows_nat_target::store_registers, handle_exception)
4959         (windows_nat_target::resume, get_windows_debug_event)
4960         (windows_nat_target::get_tib_address)
4961         (windows_nat_target::thread_name)
4962         (windows_nat_target::thread_alive): Update.
4963
4964 2020-04-08  Tom Tromey  <tromey@adacore.com>
4965
4966         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
4967         (windows_continue): Use windows_continue::resume.
4968         * nat/windows-nat.h (struct windows_thread_info) <suspend,
4969         resume>: Declare new methods.
4970         * nat/windows-nat.c: New file.
4971         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
4972
4973 2020-04-08  Tom Tromey  <tromey@adacore.com>
4974
4975         * windows-nat.c (windows_add_thread, windows_delete_thread)
4976         (windows_nat_target::fetch_registers)
4977         (windows_nat_target::store_registers, fake_create_process)
4978         (windows_nat_target::resume, windows_nat_target::resume)
4979         (get_windows_debug_event, windows_nat_target::wait)
4980         (windows_nat_target::pid_to_str)
4981         (windows_nat_target::get_tib_address)
4982         (windows_nat_target::get_ada_task_ptid)
4983         (windows_nat_target::thread_name)
4984         (windows_nat_target::thread_alive): Use lwp, not tid.
4985
4986 2020-04-08  Tom Tromey  <tromey@adacore.com>
4987
4988         * windows-nat.c (handle_exception)
4989         (windows_nat_target::thread_name): Update.
4990         * nat/windows-nat.h (windows_thread_info): Remove destructor.
4991         <name>: Now unique_xmalloc_ptr.
4992
4993 2020-04-08  Tom Tromey  <tromey@adacore.com>
4994
4995         * windows-nat.c (thread_rec)
4996         (windows_nat_target::fetch_registers): Update.
4997         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
4998         Update comment.
4999         <debug_registers_changed, reload_context>: Now bool.
5000
5001 2020-04-08  Tom Tromey  <tromey@adacore.com>
5002
5003         * windows-nat.c (windows_add_thread): Use new.
5004         (windows_init_thread_list, windows_delete_thread): Use delete.
5005         (get_windows_debug_event): Update.
5006         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
5007         destructor, and initializers.
5008
5009 2020-04-08  Tom Tromey  <tromey@adacore.com>
5010
5011         * windows-nat.c (struct windows_thread_info): Remove.
5012         * nat/windows-nat.h: New file.
5013
5014 2020-04-08  Tom Tromey  <tromey@adacore.com>
5015
5016         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
5017         (thread_rec, windows_add_thread, windows_delete_thread)
5018         (windows_continue): Update.
5019
5020 2020-04-08  Tom Tromey  <tromey@adacore.com>
5021
5022         * windows-nat.c (struct windows_thread_info): Remove typedef.
5023         (thread_head): Remove.
5024         (thread_list): New global.
5025         (thread_rec, windows_add_thread, windows_init_thread_list)
5026         (windows_delete_thread, windows_continue): Update.
5027
5028 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
5029
5030         * windows-tdep.h (windows_init_abi): Add comment.
5031         (cygwin_init_abi): New declaration.
5032         * windows-tdep.c: Split signal enumeration in two, one for
5033         Windows and one for Cygwin.
5034         (windows_gdb_signal_to_target): Only deal with signal of the
5035         Windows OS ABI.
5036         (cygwin_gdb_signal_to_target): New function.
5037         (windows_init_abi): Rename to windows_init_abi_common, don't set
5038         gdb_signal_to_target gdbarch method.  Add new new function with
5039         this name.
5040         (cygwin_init_abi): New function.
5041         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
5042         comment.  Don't call windows_init_abi.
5043         (amd64_windows_init_abi): Add comment, call windows_init_abi.
5044         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
5045         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
5046         i386_windows_init_abi_common, don't call windows_init_abi.  Add
5047         a new function of this name.
5048         (i386_cygwin_init_abi): New function.
5049         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
5050         OS ABI Cygwin.
5051
5052 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
5053
5054         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
5055         parameter.c.
5056         (dwarf2_read_gdb_index): Update.
5057
5058 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
5059
5060         * nbsd-tdep.c: Include "objfiles.h".
5061         (nbsd_skip_solib_resolver): New.
5062         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
5063
5064 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
5065
5066         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
5067         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
5068         with DW_LLE_base_addressx are being emitted in DWARFv5.
5069         Add the newly added kind DW_LOC_OFFSET_PAIR also.
5070         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
5071         unsigned integer.
5072
5073 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
5074
5075         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
5076         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
5077         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
5078         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
5079         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
5080         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
5081         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
5082
5083
5084 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
5085
5086         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
5087         (read_loclist_index): New function definition.
5088         (lookup_loclist_base): New function definition.
5089         (read_loclist_header): New function definition.
5090         (dwarf2_cu): Add loclist_base and loclist_header field.
5091         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
5092         (read_full_die_1): Read the value of DW_AT_loclists_base.
5093         (read_attribute_reprocess): Handle DW_FORM_loclistx.
5094         (read_attribute_value): Handle DW_FORM_loclistx.
5095         (skip_one_die): Handle DW_FORM_loclistx.
5096         (loclist_header): New structure declaration.
5097         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
5098
5099 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
5100
5101         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
5102         constructor.  Remove `addr` parameter from other constructor and
5103         add `per_cu` parameter.
5104         * dwarf2/read.c (create_partial_symtab): Update.
5105
5106 2020-04-07  Tom de Vries  <tdevries@suse.de>
5107
5108         PR symtab/25796
5109         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
5110         (partial_die_info::fixup): Inherit has_const_value.
5111
5112 2020-04-07  Tom de Vries  <tdevries@suse.de>
5113
5114         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
5115         symbols without address.
5116
5117 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
5118
5119         * nbsd-nat.h (struct thread_info): Add forward declaration.
5120         (nbsd_nat_target::thread_alive): Add.
5121         (nbsd_nat_target::thread_name): Likewise.
5122         (nbsd_nat_target::update_thread_list): Likewise.
5123         (update_thread_list::post_attach): Likewise.
5124         (post_attach::pid_to_str): Likewise.
5125         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
5126         (nbsd_thread_lister): Add.
5127         (nbsd_nat_target::thread_alive): Likewise.
5128         (nbsd_nat_target::thread_name): Likewise.
5129         (nbsd_add_threads): Likewise.
5130         (update_thread_list::post_attach): Likewise.
5131         (nbsd_nat_target::update_thread_list): Likewise.
5132         (post_attach::pid_to_str): Likewise.
5133
5134 2020-04-06  Tom Tromey  <tromey@adacore.com>
5135
5136         * ada-valprint.c (print_variant_part): Extract the variant field.
5137         (print_field_values): Use the field as the outer value when
5138         recursing.
5139
5140 2020-04-06  Tom Tromey  <tromey@adacore.com>
5141
5142         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
5143         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
5144         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
5145         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
5146         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
5147
5148 2020-04-06  Tom Tromey  <tromey@adacore.com>
5149
5150         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
5151         TYPE_CODE_ERROR.
5152
5153 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
5154
5155         * nbsd-tdep.c: Include "gdbarch.h".
5156         Define enum with NetBSD signal numbers.
5157         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
5158         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
5159         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
5160         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
5161         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
5162         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
5163         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
5164         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
5165         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
5166         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
5167         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
5168         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
5169
5170 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
5171
5172         PR gdb/25325
5173         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
5174
5175 2020-04-03  Tom Tromey  <tromey@adacore.com>
5176
5177         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
5178         Read constant block.
5179
5180 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
5181
5182         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
5183         (gdb_bfd_get_full_section_contents): New declaration.
5184         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
5185         * windows-tdep.c (is_linked_with_cygwin_dll): Use
5186         gdb_bfd_get_full_section_contents.
5187
5188 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
5189
5190         * exec.c (build_section_table): Replace internal_error with
5191         gdb_assert.
5192         (section_table_xfer_memory_partial): Likewise.
5193         * mdebugread.c (parse_partial_symbols): Likewise.
5194         * psymtab.c (lookup_partial_symbol): Likewise.
5195         * utils.c (wrap_here): Likewise.
5196
5197 2020-04-02  Tom Tromey  <tromey@adacore.com>
5198
5199         * f-lang.c (build_fortran_types): Use arch_type to initialize
5200         builtin_complex_s32 in the TYPE_CODE_ERROR case.
5201
5202 2020-04-02  Tom Tromey  <tromey@adacore.com>
5203
5204         * dwarf2/read.c (partial_die_info::read): Do not create a vector
5205         of attributes.
5206
5207 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5208             Bernd Edlinger <bernd.edlinger@hotmail.de>
5209             Tom Tromey  <tromey@adacore.com>
5210
5211         * buildsym.c (buildsym_compunit::record_line): Remove
5212         deduplication code.
5213
5214 2020-04-02  Tom de Vries  <tdevries@suse.de>
5215
5216         PR ada/24671
5217         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
5218
5219 2020-04-02  Tom de Vries  <tdevries@suse.de>
5220
5221         * dwarf2/read.c (dwarf2_gdb_index_functions,
5222         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
5223         NULL.
5224         * psymtab.c (psym_lookup_global_symbol_language): New function.
5225         (psym_functions): Init psym_lookup_global_symbol_language with
5226         psym_lookup_global_symbol_language.
5227         * symfile-debug.c (debug_sym_quick_functions): Init
5228         lookup_global_symbol_language with NULL.
5229         * symfile.c (set_initial_language): Remove fixme comment.
5230         * symfile.h (struct quick_symbol_functions): Add
5231         lookup_global_symbol_language.
5232         * symtab.c (find_quick_global_symbol_language): New function.
5233         (find_main_name): Use find_quick_global_symbol_language.
5234
5235 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
5236
5237         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
5238
5239 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5240
5241         * buildsym.c (record_line): Fix undefined behavior and preserve
5242         lines at eof.
5243
5244 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5245
5246         * buildsym.c (record_line): Fix the resizing condition.
5247
5248 2020-04-01  Tom Tromey  <tom@tromey.com>
5249
5250         * value.h (value_literal_complex): Add comment.
5251         * valops.c (value_literal_complex): Refer to value.h.
5252
5253 2020-04-01  Tom Tromey  <tom@tromey.com>
5254
5255         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
5256         (scalar_type): New rule, from typebase.
5257         (typebase): Use scalar_type.  Recognize complex types.
5258         (field_name): Handle FLOAT_KEYWORD.
5259         (ident_tokens): Add _Complex and __complex__.
5260
5261 2020-04-01  Tom Tromey  <tom@tromey.com>
5262
5263         PR exp/25299:
5264         * valarith.c (promotion_type, complex_binop): New functions.
5265         (scalar_binop): Handle complex numbers.  Use promotion_type.
5266         (value_pos, value_neg, value_complement): Handle complex numbers.
5267
5268 2020-04-01  Tom Tromey  <tom@tromey.com>
5269
5270         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
5271         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
5272         (parse_number): Handle complex numbers.
5273
5274 2020-04-01  Tom Tromey  <tom@tromey.com>
5275
5276         * c-valprint.c (c_decorations): Change complex suffix to "i".
5277
5278 2020-04-01  Tom Tromey  <tom@tromey.com>
5279
5280         * valprint.c (generic_value_print_complex): Use accessors.
5281         * value.h (value_real_part, value_imaginary_part): Declare.
5282         * valops.c (value_real_part, value_imaginary_part): New
5283         functions.
5284         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
5285
5286 2020-04-01  Tom Tromey  <tom@tromey.com>
5287
5288         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
5289         (read_range_type): Update.
5290         * mdebugread.c (basic_type): Update.
5291         * go-lang.c (build_go_types): Use init_complex_type.
5292         * gdbtypes.h (struct main_type) <complex_type>: New member.
5293         (init_complex_type): Update.
5294         (arch_complex_type): Don't declare.
5295         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
5296         Make name if none given.  Use alloc_type_copy.  Look for cached
5297         complex type.
5298         (arch_complex_type): Remove.
5299         (gdbtypes_post_init): Use init_complex_type.
5300         * f-lang.c (build_fortran_types): Use init_complex_type.
5301         * dwarf2/read.c (read_base_type): Update.
5302         * d-lang.c (build_d_types): Use init_complex_type.
5303         * ctfread.c (read_base_type): Update.
5304
5305 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5306
5307         * infrun.c (stop_all_threads): Update assertion, plus when
5308         stopping threads, take into account that we might be trying
5309         to stop an all-stop target.
5310         (stop_waiting): Call 'stop_all_threads' if there exists a
5311         non-stop target.
5312
5313 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5314
5315         * target.h (exists_non_stop_target): New function declaration.
5316         * target.c (exists_non_stop_target): New function.
5317
5318 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
5319
5320         PR gdb/24789
5321         * eval.c (is_integral_or_integral_reference): New function.
5322         (evaluate_subexp_standard): Allow integer references in
5323         pointer arithmetic.
5324
5325 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5326
5327         * remote.c (remote_target::remote_parse_stop_reply): Remove the
5328         check for no ptid in the stop reply when the target is non-stop.
5329
5330 2020-04-01  Tom Tromey  <tromey@adacore.com>
5331
5332         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
5333         "name" parameter to rvalue reference.  Initialize m_name_holder.
5334         <lookup_name_info>: New overloads.
5335         <name>: Return gdb::string_view.
5336         <c_str>: New method.
5337         <make_ignore_params>: Update.
5338         <search_name_hash>: Update.
5339         <language_lookup_name>: Return const char *.
5340         <m_name>: Change type.
5341         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
5342         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
5343         (lookup_name_info::match_any): Update.
5344         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
5345         Update.
5346         * minsyms.c (linkage_name_str): Update.
5347         * language.c (default_symbol_name_matcher): Update.
5348         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
5349         Update.
5350         * ada-lang.c (ada_fold_name): Change parameter to string_view.
5351         (ada_lookup_name_info::ada_lookup_name_info): Update.
5352         (literal_symbol_name_matcher): Update.
5353
5354 2020-04-01  Tom Tromey  <tromey@adacore.com>
5355
5356         * psymtab.c (psymtab_search_name): Remove function.
5357         (psym_lookup_symbol): Create search name and lookup name here.
5358         (lookup_partial_symbol): Remove "name" parameter; add
5359         lookup_name.
5360         (psym_expand_symtabs_for_function): Update.
5361
5362 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
5363
5364         PR tui/25597:
5365         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
5366
5367 2020-03-31  Tom Tromey  <tromey@adacore.com>
5368
5369         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
5370         memcpy.
5371
5372 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
5373
5374         * features/riscv/32bit-csr.xml: Regenerated.
5375         * features/riscv/64bit-csr.xml: Regenerated.
5376
5377 2020-03-30  Tom Tromey  <tromey@adacore.com>
5378
5379         * ada-valprint.c (print_variant_part): Update.
5380         * ada-lang.h (ada_which_variant_applies): Update.
5381         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
5382         outer_valaddr parameters; replace with "outer" value parameter.
5383         (to_fixed_variant_branch_type): Update.
5384
5385 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5386
5387         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
5388         <list>.  Remove inclusion of observable.h.
5389         (PPC_DEBUG_CURRENT_VERSION): Move up define.
5390         (struct arch_lwp_info): New struct.
5391         (class ppc_linux_dreg_interface): New class.
5392         (struct ppc_linux_process_info): New struct.
5393         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
5394         <low_new_clone, low_forget_process, low_prepare_to_resume>
5395         <copy_thread_dreg_state, mark_thread_stale>
5396         <mark_debug_registers_changed, register_hw_breakpoint>
5397         <clear_hw_breakpoint, register_wp, clear_wp>
5398         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
5399         <num_memory_accesses, get_trigger_type>
5400         <create_watchpoint_request, hwdebug_point_cmp>
5401         <init_arch_lwp_info, get_arch_lwp_info>
5402         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
5403         methods.
5404         <struct ptid_hash>: New inner struct.
5405         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
5406         members.
5407         (saved_dabr_value, hwdebug_info, max_slots_number)
5408         (struct hw_break_tuple, struct thread_points, ppc_threads)
5409         (have_ptrace_hwdebug_interface)
5410         (hwdebug_find_thread_points_by_tid)
5411         (hwdebug_insert_point, hwdebug_remove_point): Remove.
5412         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
5413         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
5414         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
5415         use m_dreg_interface.
5416         (hwdebug_point_cmp): Change to...
5417         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
5418         reference arguments instead of pointers.
5419         (ppc_linux_nat_target::ranged_break_num_registers): Use
5420         m_dreg_interface.
5421         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
5422         m_dreg_interface.  Call register_hw_breakpoint.
5423         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
5424         m_dreg_interface.  Call clear_hw_breakpoint.
5425         (get_trigger_type): Change to...
5426         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
5427         comment.
5428         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
5429         use m_dreg_interface.  Call register_hw_breakpoint.
5430         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
5431         use m_dreg_interface.  Call clear_hw_breakpoint.
5432         (can_use_watchpoint_cond_accel): Change to...
5433         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
5434         method.  Update comment, use m_dreg_interface and
5435         m_process_info.
5436         (calculate_dvc): Change to...
5437         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
5438         m_dreg_interface.
5439         (num_memory_accesses): Change to...
5440         (ppc_linux_nat_target::num_memory_accesses): ...this method.
5441         (check_condition): Change to...
5442         (ppc_linux_nat_target::check_condition): ...this method.
5443         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
5444         comment, use m_dreg_interface.
5445         (create_watchpoint_request): Change to...
5446         (ppc_linux_nat_target::create_watchpoint_request): ...this
5447         method.  Use m_dreg_interface.
5448         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
5449         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
5450         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
5451         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
5452         (ppc_linux_nat_target::low_forget_process)
5453         (ppc_linux_nat_target::low_new_fork)
5454         (ppc_linux_nat_target::low_new_clone)
5455         (ppc_linux_nat_target::low_delete_thread)
5456         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
5457         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
5458         only call mark_thread_stale.
5459         (ppc_linux_thread_exit): Remove.
5460         (ppc_linux_nat_target::stopped_data_address): Change to...
5461         (ppc_linux_nat_target::low_stopped_data_address): This. Add
5462         comment, use m_dreg_interface and m_thread_hw_breakpoints.
5463         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
5464         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
5465         comment.  Call low_stopped_data_address.
5466         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
5467         m_dreg_interface.
5468         (ppc_linux_nat_target::masked_watch_num_registers): Use
5469         m_dreg_interface.
5470         (ppc_linux_nat_target::copy_thread_dreg_state)
5471         (ppc_linux_nat_target::mark_thread_stale)
5472         (ppc_linux_nat_target::mark_debug_registers_changed)
5473         (ppc_linux_nat_target::register_hw_breakpoint)
5474         (ppc_linux_nat_target::clear_hw_breakpoint)
5475         (ppc_linux_nat_target::register_wp)
5476         (ppc_linux_nat_target::clear_wp)
5477         (ppc_linux_nat_target::init_arch_lwp_info)
5478         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
5479         (_initialize_ppc_linux_nat): Remove observer callback.
5480
5481 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5482
5483         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
5484         (ppc_linux_nat_target::auxv_parse)
5485         (ppc_linux_nat_target::read_description)
5486         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
5487         Move up.
5488
5489 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5490
5491         * linux-nat.h (low_new_clone): New method.
5492         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
5493
5494 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5495
5496         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
5497         (dbx_expand_psymtab): ... this.
5498         (start_psymtab): Update.
5499         * mdebugread.c (psymtab_to_symtab_1): Rename to...
5500         (mdebug_expand_psymtab): ... this.
5501         (parse_partial_symbols): Update.
5502         (new_psymtab): Update.
5503         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
5504         (xcoff_expand_psymtab): ... this.
5505         (xcoff_start_psymtab): Update.
5506
5507 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5508
5509         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
5510         <expand_dependencies>: ... this.
5511         * psymtab.c (partial_symtab::read_dependencies): Rename to...
5512         (partial_symtab::expand_dependencies): ... this.
5513         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
5514         Update.
5515         (dwarf2_psymtab::expand_psymtab): Update.
5516         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5517         * mdebugread.c (psymtab_to_symtab_1): Update.
5518         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5519
5520 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5521
5522         * psympriv.h (discard_psymtab): Remove.
5523         * dbxread.c (dbx_end_psymtab): Update.
5524         * xcoffread.c (xcoff_end_psymtab): Update.
5525
5526 2020-03-28  Tom Tromey  <tom@tromey.com>
5527
5528         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
5529         comment.
5530
5531 2020-03-28  Tom Tromey  <tom@tromey.com>
5532
5533         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
5534
5535 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
5536
5537         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
5538
5539 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
5540
5541         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
5542
5543 2020-03-26  Tom Tromey  <tom@tromey.com>
5544
5545         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
5546         (mark_common_block_symbol_computed, read_tag_string_type)
5547         (attr_to_dynamic_prop, read_subrange_type): Update.
5548         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
5549         to be methods on struct attribute.
5550         (skip_one_die, process_imported_unit_die, read_namespace_alias)
5551         (read_call_site_scope, partial_die_info::read)
5552         (partial_die_info::read, lookup_die_type, follow_die_ref):
5553         Update.
5554         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
5555         from dwarf2_get_ref_die_offset.
5556         (attribute::constant_value): New method, from
5557         dwarf2_get_attr_constant_value.
5558         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
5559         Declare method.
5560         <constant_value>: New method.
5561
5562 2020-03-26  Tom Tromey  <tom@tromey.com>
5563
5564         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
5565         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
5566         (dwarf_type_encoding_name): Move to stringify.c.
5567         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
5568         * dwarf2/stringify.c: New file.
5569         * dwarf2/stringify.h: New file.
5570
5571 2020-03-26  Tom Tromey  <tom@tromey.com>
5572
5573         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
5574         Rewrite.
5575
5576 2020-03-26  Tom Tromey  <tom@tromey.com>
5577
5578         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
5579         methods.
5580         * dwarf2/read.c (lookup_addr_base): Move to die.h.
5581         (lookup_ranges_base): Likewise.
5582         (read_cutu_die_from_dwo, read_full_die_1): Update.
5583
5584 2020-03-26  Tom Tromey  <tom@tromey.com>
5585
5586         * dwarf2/read.c (read_import_statement, read_file_scope)
5587         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
5588         (read_lexical_block_scope, read_call_site_scope)
5589         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
5590         (handle_struct_member_die, process_structure_scope)
5591         (update_enumeration_type_from_children)
5592         (process_enumeration_scope, read_array_type, read_common_block)
5593         (read_namespace, read_module, read_subroutine_type): Update.
5594         (sibling_die): Remove.
5595
5596 2020-03-26  Tom Tromey  <tom@tromey.com>
5597
5598         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
5599         (build_type_psymtabs_reader, read_structure_type)
5600         (read_enumeration_type, read_full_die_1): Update.
5601         (dwarf2_attr_no_follow): Move to die.h.
5602         * dwarf2/die.h (struct die_info) <attr>: New method.
5603
5604 2020-03-26  Tom Tromey  <tom@tromey.com>
5605
5606         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
5607         <base_address>: Now an optional.
5608         (dwarf2_find_base_address, dwarf2_rnglists_process)
5609         (dwarf2_ranges_process, fill_in_loclist_baton)
5610         (dwarf2_symbol_mark_computed): Update.
5611
5612 2020-03-26  Tom Tromey  <tom@tromey.com>
5613
5614         * dwarf2/read.c (struct die_info): Move to die.h.
5615         * dwarf2/die.h: New file.
5616
5617 2020-03-26  Tom Tromey  <tom@tromey.com>
5618
5619         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
5620         * dwarf2/read.c
5621         (dwarf2_statement_list_fits_in_line_number_section_complaint):
5622         Move to line-header.c.
5623         (read_checked_initial_length_and_offset, read_formatted_entries):
5624         Likewise.
5625         (dwarf_decode_line_header): Split into two.
5626         * dwarf2/line-header.c
5627         (dwarf2_statement_list_fits_in_line_number_section_complaint):
5628         Move from read.c.
5629         (read_checked_initial_length_and_offset, read_formatted_entries):
5630         Likewise.
5631         (dwarf_decode_line_header): New function, split from read.c.
5632
5633 2020-03-26  Tom Tromey  <tom@tromey.com>
5634
5635         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
5636         Declare method.
5637         * dwarf2/read.c (read_attribute_value): Update.
5638         (dwarf2_per_objfile::read_line_string): Rename from
5639         read_indirect_line_string.
5640         (read_formatted_entries): Update.
5641
5642 2020-03-26  Tom Tromey  <tom@tromey.com>
5643
5644         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
5645         variable.
5646
5647 2020-03-26  Tom Tromey  <tom@tromey.com>
5648
5649         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
5650         const.
5651         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
5652         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
5653         parameter const.
5654
5655 2020-03-26  Tom Tromey  <tom@tromey.com>
5656
5657         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
5658         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
5659         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
5660         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
5661
5662 2020-03-26  Tom Tromey  <tom@tromey.com>
5663
5664         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
5665         file_names_size, file_full_name, file_file_name>: Use const.
5666         <file_name_at, file_names>: Add const overload.
5667         * dwarf2/line-header.c (line_header::file_file_name)
5668         (line_header::file_full_name): Update.
5669
5670 2020-03-26  Tom Tromey  <tom@tromey.com>
5671
5672         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
5673         (macro_start_file, consume_improper_spaces)
5674         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
5675         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
5676         (dwarf_decode_macros): Move to macro.c.
5677         * dwarf2/macro.c: New file.
5678         * dwarf2/macro.h: New file.
5679         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
5680
5681 2020-03-26  Tom Tromey  <tom@tromey.com>
5682
5683         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
5684         method.
5685         * dwarf2/section.c: New method.  From
5686         read_indirect_string_at_offset_from.
5687         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
5688         (read_indirect_string_at_offset_from): Move to section.c.
5689         (read_indirect_string_at_offset): Rewrite.
5690         (read_indirect_line_string_at_offset): Remove.
5691         (read_indirect_string, read_indirect_line_string)
5692         (dwarf_decode_macro_bytes): Update.
5693
5694 2020-03-26  Tom Tromey  <tom@tromey.com>
5695
5696         * dwarf2/section.h (struct dwarf2_section_info)
5697         <overload_complaint>: Declare.
5698         (dwarf2_section_buffer_overflow_complaint): Don't declare.
5699         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
5700         Rename from dwarf2_section_buffer_overflow_complaint.
5701         * dwarf2/read.c (skip_one_die, partial_die_info::read)
5702         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
5703
5704 2020-03-26  Tom Tromey  <tom@tromey.com>
5705
5706         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
5707         Declare.
5708         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
5709         Move from read.c.
5710         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
5711         to section.c.
5712
5713 2020-03-26  Tom Tromey  <tom@tromey.com>
5714
5715         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
5716
5717 2020-03-26  Tom Tromey  <tom@tromey.com>
5718
5719         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
5720         "builder".
5721         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
5722         parameter.
5723         (dwarf_decode_macros): Update.
5724
5725 2020-03-26  Tom Tromey  <tom@tromey.com>
5726
5727         * dwarf2/read.c (read_attribute_value): Update.
5728         (read_indirect_string_from_dwz): Move to dwz.c; change into
5729         method.
5730         (dwarf_decode_macro_bytes): Update.
5731         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
5732         * dwarf2/dwz.c: New file.
5733         * Makefile.in (COMMON_SFILES): Add dwz.c.
5734
5735 2020-03-26  Tom Tromey  <tom@tromey.com>
5736
5737         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
5738         * dwarf2/read.c: Add include.
5739         * dwarf2/index-write.c: Add include.
5740         * dwarf2/index-cache.c: Add include.
5741         * dwarf2/dwz.h: New file.
5742
5743 2020-03-25  Tom Tromey  <tom@tromey.com>
5744
5745         * compile/compile-object-load.c (get_out_value_type): Mention
5746         correct symbol name in error message.
5747
5748 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
5749
5750         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
5751
5752 2020-03-25  Tom de Vries  <tdevries@suse.de>
5753
5754         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
5755         * symmisc.c (dump_symtab_1): Print user and includes fields.
5756         (maintenance_info_symtabs): Same.
5757
5758 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
5759
5760         PR gdb/25534
5761         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
5762         (riscv_regcache_cooked_write): New function.
5763         (riscv_push_dummy_call): Use new function.
5764         (riscv_return_value): Likewise.
5765
5766 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
5767
5768         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
5769         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
5770         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
5771         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
5772         * infrun.c (follow_fork): Likewise.
5773         (follow_fork_inferior): Likewise.
5774         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
5775         * linux-nat.h (class linux_nat_target): Likewise.
5776         * remote.c (class remote_target) <follow_fork>: Likewise.
5777         (remote_target::follow_fork): Likewise.
5778         * target-delegates.c: Re-generate.
5779         * target.c (default_follow_fork): Likewise.
5780         (target_follow_fork): Likewise.
5781         * target.h (struct target_ops) <follow_fork>: Likewise.
5782         (target_follow_fork): Likewise.
5783
5784 2020-03-24  Tom de Vries  <tdevries@suse.de>
5785
5786         * psymtab.c (maintenance_info_psymtabs): Print user field.
5787
5788 2020-03-20  Tom Tromey  <tromey@adacore.com>
5789
5790         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
5791         const.
5792         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
5793         const.
5794
5795 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
5796
5797         * ptrace.m4: Don't check for ptrace declaration.
5798         * config.in: Re-generate.
5799         * configure: Re-generate.
5800         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
5801         not defined.
5802
5803 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5804
5805         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
5806         `PTRACE_TYPE_RET'.
5807         * i386-bsd-nat.c (gdb_ptrace): Likewise.
5808         * sparc-nat.c (gdb_ptrace): Likewise.
5809         * x86-bsd-nat.c (gdb_ptrace): Likewise.
5810
5811 2020-03-20  Tom Tromey  <tromey@adacore.com>
5812
5813         * c-exp.y (lex_one_token): Fix assert.
5814
5815 2020-03-20  Tom Tromey  <tromey@adacore.com>
5816
5817         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
5818         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
5819         strncpy call.
5820
5821 2020-03-20  Tom Tromey  <tromey@adacore.com>
5822
5823         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
5824
5825 2020-03-20  Tom Tromey  <tromey@adacore.com>
5826
5827         * ada-valprint.c (print_variant_part): Remove parameters; switch
5828         to value-based API.
5829         (print_field_values): Likewise.
5830         (ada_val_print_struct_union): Likewise.
5831         (ada_value_print_1): Update.
5832
5833 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5834
5835         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
5836         nbsd_nat_target instead of inf_ptrace_target.
5837         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5838         nbsd_nat_target.
5839
5840 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5841
5842         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
5843         it to the ptrace call.
5844         * (store_registers): Likewise.
5845
5846 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5847
5848         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
5849         it to the ptrace call.
5850         * (store_registers): Likewise.
5851
5852 2020-03-19  Luis Machado  <luis.machado@linaro.org>
5853
5854         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
5855         valid, fetch vg value from ptrace.
5856
5857 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5858         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
5859         * inf-ptrace.c: Likewise.
5860         * (gdb_ptrace): Add.
5861         * (inf_ptrace_target::resume): Update.
5862         * (inf_ptrace_target::xfer_partial): Likewise.
5863         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
5864         * (inf_ptrace_peek_poke): Update.
5865
5866 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5867
5868         * x86-bsd-nat.c (gdb_ptrace): New.
5869         * (x86bsd_dr_set): Add new argument `ptid'.
5870         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
5871         x86bsd_dr_set_addr): Update.
5872
5873 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5874
5875         * remote.c (remote_target::process_stop_reply): Handle events for
5876         all threads differently.
5877
5878 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5879
5880         * completer.c (completion_tracker::remove_completion): Define new
5881         function.
5882         * completer.h (completion_tracker::remove_completion): Declare new
5883         function.
5884         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
5885         when adding a C++ function symbol.
5886
5887 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5888
5889         * completer.c (completion_tracker::completion_hash_entry): Define
5890         new class.
5891         (advance_to_filename_complete_word_point): Call
5892         recompute_lowest_common_denominator.
5893         (completion_tracker::completion_tracker): Call discard_completions
5894         to setup the hash table.
5895         (completion_tracker::discard_completions): Allow for being called
5896         from the constructor, pass new equal function, and element deleter
5897         when constructing the hash table.  Initialise new class member
5898         variables.
5899         (completion_tracker::maybe_add_completion): Remove use of
5900         m_entries_vec, and store more information into m_entries_hash.
5901         (completion_tracker::recompute_lcd_visitor): New function, most
5902         content taken from...
5903         (completion_tracker::recompute_lowest_common_denominator):
5904         ...here, this now just visits each item in the hash calling the
5905         above visitor.
5906         (completion_tracker::build_completion_result): Remove use of
5907         m_entries_vec, call recompute_lowest_common_denominator.
5908         * completer.h (completion_tracker::have_completions): Remove use
5909         of m_entries_vec.
5910         (completion_tracker::completion_hash_entry): Declare new class.
5911         (completion_tracker::recompute_lowest_common_denominator): Change
5912         function signature.
5913         (completion_tracker::recompute_lcd_visitor): Declare new function.
5914         (completion_tracker::m_entries_vec): Delete.
5915         (completion_tracker::m_entries_hash): Initialize to NULL.
5916         (completion_tracker::m_lowest_common_denominator_valid): New
5917         member variable.
5918         (completion_tracker::m_lowest_common_denominator_max_length): New
5919         member variable.
5920
5921 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5922
5923         * regformats/regdef.h: Put reg in gdb namespace.
5924
5925 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5926
5927         * i386-bsd-nat.c (gdb_ptrace): New.
5928         * (i386bsd_fetch_inferior_registers,
5929         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5930         * (i386bsd_fetch_inferior_registers,
5931         i386bsd_store_inferior_registers) Use gdb_ptrace.
5932
5933 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5934
5935         * amd64-bsd-nat.c (gdb_ptrace): New.
5936         * (amd64bsd_fetch_inferior_registers,
5937         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5938         * (amd64bsd_fetch_inferior_registers,
5939         amd64bsd_store_inferior_registers) Use gdb_ptrace.
5940
5941 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5942
5943         * user-regs.c (user_reg::read): Rename to...
5944         (user_reg::xread): ...this.
5945         * (append_user_reg): Rename argument `read' to `xread'.
5946         * (user_reg_add_builtin): Likewise.
5947         * (user_reg_add): Likewise.
5948         * (value_of_user_reg): Likewise.
5949
5950 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5951
5952         * sparc-nat.c (gdb_ptrace): New.
5953         * sparc-nat.c (sparc_fetch_inferior_registers)
5954         (sparc_store_inferior_registers) Remove obsolete comment.
5955         * sparc-nat.c (sparc_fetch_inferior_registers)
5956         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
5957         * sparc-nat.c (sparc_fetch_inferior_registers)
5958         (sparc_store_inferior_registers) Use gdb_ptrace.
5959
5960 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5961
5962         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
5963         it to the ptrace call.
5964         * sh-nbsd-nat.c (store_registers): Likewise.
5965
5966 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5967
5968         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
5969         nbsd_nat_target instead of inf_ptrace_target.
5970         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5971         nbsd_nat_target.
5972
5973 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5974
5975         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
5976
5977 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5978
5979         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
5980         <sys/sysctl.h>.
5981         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
5982
5983 2020-03-17  Tom de Vries  <tdevries@suse.de>
5984
5985         PR gdb/23710
5986         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
5987         fields.
5988         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
5989         fields.
5990         (process_imported_unit_die): Skip import of c++ CUs.
5991
5992 2020-03-16  Tom Tromey  <tom@tromey.com>
5993
5994         * p-valprint.c (pascal_object_print_value): Initialize
5995         base_value.
5996
5997 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
5998             Shahab Vahedi  <shahab@synopsys.com>
5999
6000         * Makefile.in: Add arch/arc.o
6001         * configure.tgt: Likewise.
6002         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
6003         (_initialize_arc_tdep): Don't initialize old target descriptions.
6004         (arc_read_description): New function to cache target descriptions.
6005         * arc-tdep.h (arc_read_description): Add proto type.
6006         * arch/arc.c: New file.
6007         * arch/arc.h: Likewise.
6008         * features/Makefile: Replace old target descriptions with new.
6009         * features/arc-arcompact.c: Remove.
6010         * features/arc-arcompact.xml: Likewise.
6011         * features/arc-v2.c: Likewise
6012         * features/arc-v2.xml: Likewise
6013         * features/arc/aux-arcompact.xml: New file.
6014         * features/arc/aux-v2.xml: Likewise.
6015         * features/arc/core-arcompact.xml: Likewise.
6016         * features/arc/core-v2.xml: Likewise.
6017         * features/arc/aux-arcompact.c: Generate.
6018         * features/arc/aux-v2.c: Likewise.
6019         * features/arc/core-arcompact.c: Likewise.
6020         * features/arc/core-v2.c: Likewise.
6021         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
6022
6023 2020-03-16  Tom Tromey  <tromey@adacore.com>
6024
6025         PR gdb/25663:
6026         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
6027         putting value into bcache.
6028
6029 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6030
6031         PR gdb/21500
6032         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
6033         to...
6034         (amd64_windows_init_abi_common): ... this.  Don't set size of
6035         long type.
6036         (amd64_windows_init_abi): New function.
6037         (amd64_cygwin_init_abi): New function.
6038         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
6039         the Cygwin OS ABI.
6040         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
6041         comment.
6042
6043 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6044
6045         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
6046         * windows-tdep.c (CYGWIN_DLL_NAME): New.
6047         (pe_import_directory_entry): New struct type.
6048         (is_linked_with_cygwin_dll): New function.
6049         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
6050         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
6051         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
6052
6053 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6054
6055         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
6056         i386_cygwin_core_osabi_sniffer.
6057
6058 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6059
6060         * i386-cygwin-tdep.c: Rename to...
6061         * i386-windows-tdep.c: ... this.
6062         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
6063         i386-windows-tdep.c.
6064         * configure.tgt: Likewise.
6065
6066 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6067
6068         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
6069         * osabi.c (gdb_osabi_names): Add "Windows".
6070         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
6071         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
6072         (i386_cygwin_core_osabi_sniffer): New function, extracted from
6073         i386_cygwin_osabi_sniffer.
6074         (_initialize_i386_cygwin_tdep): Register OS ABI
6075         GDB_OSABI_WINDOWS for i386.
6076         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
6077         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
6078         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
6079         for x86-64.
6080         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
6081         when the target matches '*-*-mingw*'.
6082
6083 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6084
6085         * defs.h (enum gdb_osabi): Move to...
6086         * osabi.h (enum gdb_osabi): ... here.
6087         * gdbarch.sh: Include osabi.h in gdbarch.h.
6088         * gdbarch.h: Re-generate.
6089
6090 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6091
6092         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
6093         function.
6094         (_initialize_amd64_windows_tdep): Register osabi sniffer.
6095
6096 2020-03-14  Tom Tromey  <tom@tromey.com>
6097
6098         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
6099         for C++.
6100         (c_type_print_modifier): Likewise.  Add "language" parameter.
6101         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
6102         (c_type_print_base_1): Update.
6103         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
6104         constants.
6105         * type-stack.c (type_stack::insert): Handle tp_atomic and
6106         tp_restrict.
6107         (type_stack::follow_type_instance_flags): Likewise.
6108         (type_stack::follow_types): Likewise.  Merge type-following code.
6109         * c-exp.y (RESTRICT, ATOMIC): New tokens.
6110         (space_identifier, cv_with_space_id)
6111         (const_or_volatile_or_space_identifier_noopt)
6112         (const_or_volatile_or_space_identifier): Remove.
6113         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
6114         rules.
6115         (ptr_operator, typebase): Update.
6116         (enum token_flag) <FLAG_C>: New constant.
6117         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
6118         "_Atomic".
6119         (lex_one_token): Handle FLAG_C.
6120
6121 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6122
6123         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
6124         it to the ptrace call.
6125         * m68k-bsd-nat.c (store_registers): Likewise.
6126
6127 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6128
6129         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
6130         gdb_byte *.
6131         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
6132         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
6133         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
6134
6135 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6136
6137         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
6138         nbsd_nat_target instead of inf_ptrace_target.
6139         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
6140         nbsd_nat_target.
6141
6142 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6143
6144         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
6145         register_t.
6146
6147 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6148
6149         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
6150         it to the ptrace call.
6151         * alpha-bsd-nat.c (store_registers): Likewise.
6152
6153 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6154
6155         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
6156         includes.
6157         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
6158         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
6159         fill_fpregset): Likewise.
6160
6161 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6162
6163         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
6164         nbsd_nat_target instead of inf_ptrace_target.
6165         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
6166         nbsd_nat_target.
6167
6168 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6169
6170         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
6171         register_t.
6172
6173 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6174
6175         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
6176         it to the ptrace call.
6177         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
6178         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
6179         * arm-nbsd-nat.c (store_register): Likewise.
6180         * arm-nbsd-nat.c (store_regs): Likewise.
6181         * arm-nbsd-nat.c (store_fp_register): Likewise.
6182         * arm-nbsd-nat.c (store_fp_regs): Likewise.
6183
6184 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6185
6186         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
6187         nbsd_nat_target instead of inf_ptrace_target.
6188         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
6189         nbsd_nat_target.
6190
6191 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6192
6193         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
6194         it to the ptrace call.
6195         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
6196
6197 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6198
6199         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
6200         it to the ptrace call.
6201         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
6202
6203 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6204
6205         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
6206         gdb_byte *.
6207         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
6208
6209 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6210
6211         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
6212         instead of inf_ptrace_target.
6213         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
6214         nbsd_nat_target.
6215
6216 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6217
6218         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
6219         register_t.
6220
6221 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6222
6223         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
6224         register_t.
6225
6226 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6227
6228         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
6229         register_t.
6230
6231 2020-03-13  Tom Tromey  <tom@tromey.com>
6232
6233         * value.h (val_print): Don't declare.
6234         * valprint.h (val_print_array_elements)
6235         (val_print_scalar_formatted, generic_val_print): Don't declare.
6236         * valprint.c (generic_val_print_array): Take a struct value.
6237         (generic_val_print_ptr, generic_val_print_memberptr)
6238         (generic_val_print_bool, generic_val_print_int)
6239         (generic_val_print_char, generic_val_print_complex)
6240         (generic_val_print): Remove.
6241         (generic_value_print): Update.
6242         (do_val_print): Remove unused parameters.  Don't call
6243         la_val_print.
6244         (val_print): Remove.
6245         (common_val_print): Update.  Don't call value_check_printable.
6246         (val_print_scalar_formatted, val_print_array_elements): Remove.
6247         * rust-lang.c (rust_val_print): Remove.
6248         (rust_language_defn): Update.
6249         * p-valprint.c (pascal_val_print): Remove.
6250         (pascal_value_print_inner): Update.
6251         (pascal_object_print_val_fields, pascal_object_print_val):
6252         Remove.
6253         (pascal_object_print_static_field): Update.
6254         * p-lang.h (pascal_val_print): Don't declare.
6255         * p-lang.c (pascal_language_defn): Update.
6256         * opencl-lang.c (opencl_language_defn): Update.
6257         * objc-lang.c (objc_language_defn): Update.
6258         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
6259         * m2-lang.h (m2_val_print): Don't declare.
6260         * m2-lang.c (m2_language_defn): Update.
6261         * language.h (struct language_defn) <la_val_print>: Remove.
6262         * language.c (unk_lang_value_print_inner): Rename.  Change
6263         argument types.
6264         (unknown_language_defn, auto_language_defn): Update.
6265         * go-valprint.c (go_val_print): Remove.
6266         * go-lang.h (go_val_print): Don't declare.
6267         * go-lang.c (go_language_defn): Update.
6268         * f-valprint.c (f_val_print): Remove.
6269         * f-lang.h (f_value_print): Don't declare.
6270         * f-lang.c (f_language_defn): Update.
6271         * d-valprint.c (d_val_print): Remove.
6272         * d-lang.h (d_value_print): Don't declare.
6273         * d-lang.c (d_language_defn): Update.
6274         * cp-valprint.c (cp_print_value_fields)
6275         (cp_print_value_fields_rtti, cp_print_value): Remove.
6276         (cp_print_static_field): Update.
6277         * c-valprint.c (c_val_print_array, c_val_print_ptr)
6278         (c_val_print_struct, c_val_print_union, c_val_print_int)
6279         (c_val_print_memberptr, c_val_print): Remove.
6280         * c-lang.h (c_val_print_array, cp_print_value_fields)
6281         (cp_print_value_fields_rtti): Don't declare.
6282         * c-lang.c (c_language_defn, cplus_language_defn)
6283         (asm_language_defn, minimal_language_defn): Update.
6284         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
6285         (ada_val_print_enum): Take a struct value.
6286         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
6287         (ada_val_print): Remove.
6288         (ada_value_print_1): Update.
6289         (printable_val_type): Remove.
6290         * ada-lang.h (ada_val_print): Don't declare.
6291         * ada-lang.c (ada_language_defn): Update.
6292
6293 2020-03-13  Tom Tromey  <tom@tromey.com>
6294
6295         * valprint.c (do_val_print): Update.
6296         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
6297         a struct value.
6298         (value_to_value_object_no_release): Declare.
6299         * python/py-value.c (value_to_value_object_no_release): New
6300         function.
6301         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
6302         struct value.
6303         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
6304         function.
6305         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
6306         a struct value.
6307         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
6308         Declare.
6309         (gdbscm_apply_val_pretty_printer): Take a struct value.
6310         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
6311         value.
6312         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
6313         value.
6314         * extension-priv.h (struct extension_language_ops)
6315         <apply_val_pretty_printer>: Take a struct value.
6316         * cp-valprint.c (cp_print_value): Create a struct value.
6317         (cp_print_value): Update.
6318
6319 2020-03-13  Tom Tromey  <tom@tromey.com>
6320
6321         * ada-valprint.c (print_field_values): Call common_val_print.
6322
6323 2020-03-13  Tom Tromey  <tom@tromey.com>
6324
6325         * ada-valprint.c (val_print_packed_array_elements): Remove
6326         bitoffset and val parameters.  Call common_val_print.
6327         (ada_val_print_string): Remove offset, address, and original_value
6328         parameters.
6329         (ada_val_print_array): Update.
6330         (ada_value_print_array): New function.
6331         (ada_value_print_1): Call it.
6332
6333 2020-03-13  Tom Tromey  <tom@tromey.com>
6334
6335         * ada-valprint.c (ada_value_print): Use common_val_print.
6336
6337 2020-03-13  Tom Tromey  <tom@tromey.com>
6338
6339         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
6340
6341 2020-03-13  Tom Tromey  <tom@tromey.com>
6342
6343         * ada-valprint.c (ada_value_print_num): New function.
6344         (ada_value_print_1): Use it.
6345
6346 2020-03-13  Tom Tromey  <tom@tromey.com>
6347
6348         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
6349
6350 2020-03-13  Tom Tromey  <tom@tromey.com>
6351
6352         * ada-valprint.c (ada_value_print_ptr): New function.
6353         (ada_value_print_1): Use it.
6354
6355 2020-03-13  Tom Tromey  <tom@tromey.com>
6356
6357         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
6358         call common_val_print.
6359         (ada_val_print_1): Update.
6360         (ada_value_print_1): New function.
6361         (ada_value_print_inner): Rewrite.
6362
6363 2020-03-13  Tom Tromey  <tom@tromey.com>
6364
6365         * cp-valprint.c (cp_print_value_fields): Update.
6366         (cp_print_value): New function.
6367
6368 2020-03-13  Tom Tromey  <tom@tromey.com>
6369
6370         * m2-valprint.c (m2_value_print_inner): Use
6371         cp_print_value_fields.
6372         * cp-valprint.c (cp_print_value_fields): New function.
6373         * c-valprint.c (c_value_print_struct): New function.
6374         (c_value_print_inner): Use c_value_print_struct.
6375         * c-lang.h (cp_print_value_fields): Declare.
6376
6377 2020-03-13  Tom Tromey  <tom@tromey.com>
6378
6379         * c-valprint.c (c_value_print_array): New function.
6380         (c_value_print_inner): Use it.
6381
6382 2020-03-13  Tom Tromey  <tom@tromey.com>
6383
6384         * c-valprint.c (c_value_print_memberptr): New function.
6385         (c_value_print_inner): Use it.
6386
6387 2020-03-13  Tom Tromey  <tom@tromey.com>
6388
6389         * c-valprint.c (c_value_print_int): New function.
6390         (c_value_print_inner): Use it.
6391
6392 2020-03-13  Tom Tromey  <tom@tromey.com>
6393
6394         * c-valprint.c (c_value_print_ptr): New function.
6395         (c_value_print_inner): Use it.
6396
6397 2020-03-13  Tom Tromey  <tom@tromey.com>
6398
6399         * c-valprint.c (c_value_print_inner): Rewrite.
6400
6401 2020-03-13  Tom Tromey  <tom@tromey.com>
6402
6403         * valprint.c (generic_value_print_complex): New function.
6404         (generic_value_print): Use it.
6405
6406 2020-03-13  Tom Tromey  <tom@tromey.com>
6407
6408         * valprint.c (generic_val_print_float): Don't call
6409         val_print_scalar_formatted.
6410         (generic_val_print, generic_value_print): Update.
6411
6412 2020-03-13  Tom Tromey  <tom@tromey.com>
6413
6414         * valprint.c (generic_value_print_char): New function
6415         (generic_value_print): Use it.
6416
6417 2020-03-13  Tom Tromey  <tom@tromey.com>
6418
6419         * valprint.c (generic_value_print_int): New function.
6420         (generic_value_print): Use it.
6421
6422 2020-03-13  Tom Tromey  <tom@tromey.com>
6423
6424         * valprint.c (generic_value_print_bool): New function.
6425         (generic_value_print): Use it.
6426
6427 2020-03-13  Tom Tromey  <tom@tromey.com>
6428
6429         * valprint.c (generic_val_print_func): Simplify.
6430         (generic_val_print, generic_value_print): Update.
6431
6432 2020-03-13  Tom Tromey  <tom@tromey.com>
6433
6434         * valprint.c (generic_val_print_flags): Remove.
6435         (generic_val_print, generic_value_print): Update.
6436         (val_print_type_code_flags): Add original_value parameter.
6437
6438 2020-03-13  Tom Tromey  <tom@tromey.com>
6439
6440         * valprint.c (generic_val_print): Update.
6441         (generic_value_print): Update.
6442         * valprint.c (generic_val_print_enum): Don't call
6443         val_print_scalar_formatted.
6444
6445 2020-03-13  Tom Tromey  <tom@tromey.com>
6446
6447         * valprint.c (generic_value_print): Call generic_value_print_ptr.
6448         * valprint.c (generic_value_print_ptr): New function.
6449
6450 2020-03-13  Tom Tromey  <tom@tromey.com>
6451
6452         * valprint.c (generic_value_print): Rewrite.
6453
6454 2020-03-13  Tom Tromey  <tom@tromey.com>
6455
6456         * p-valprint.c (pascal_object_print_value_fields)
6457         (pascal_object_print_value): New functions.
6458
6459 2020-03-13  Tom Tromey  <tom@tromey.com>
6460
6461         * p-valprint.c (pascal_value_print_inner): Rewrite.
6462
6463 2020-03-13  Tom Tromey  <tom@tromey.com>
6464
6465         * f-valprint.c (f_value_print_innner): Rewrite.
6466
6467 2020-03-13  Tom Tromey  <tom@tromey.com>
6468
6469         * m2-valprint.c (m2_print_unbounded_array): New overload.
6470         (m2_print_unbounded_array): Update.
6471         (m2_print_array_contents): Take a struct value.
6472         (m2_value_print_inner): Rewrite.
6473
6474 2020-03-13  Tom Tromey  <tom@tromey.com>
6475
6476         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
6477         (d_value_print_inner): New function.
6478         * d-lang.h (d_value_print_inner): Declare.
6479         * d-lang.c (d_language_defn): Use d_value_print_inner.
6480
6481 2020-03-13  Tom Tromey  <tom@tromey.com>
6482
6483         * go-valprint.c (go_value_print_inner): New function.
6484         * go-lang.h (go_value_print_inner): Declare.
6485         * go-lang.c (go_language_defn): Use go_value_print_inner.
6486
6487 2020-03-13  Tom Tromey  <tom@tromey.com>
6488
6489         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
6490         API.
6491         (rust_val_print): Rewrite.
6492         (rust_value_print_inner): New function, from rust_val_print.
6493         (rust_language_defn): Use rust_value_print_inner.
6494
6495 2020-03-13  Tom Tromey  <tom@tromey.com>
6496
6497         * ada-valprint.c (ada_value_print_inner): New function.
6498         * ada-lang.h (ada_value_print_inner): Declare.
6499         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
6500
6501 2020-03-13  Tom Tromey  <tom@tromey.com>
6502
6503         * f-valprint.c (f_value_print_innner): New function.
6504         * f-lang.h (f_value_print_innner): Declare.
6505         * f-lang.c (f_language_defn): Use f_value_print_innner.
6506
6507 2020-03-13  Tom Tromey  <tom@tromey.com>
6508
6509         * p-valprint.c (pascal_value_print_inner): New function.
6510         * p-lang.h (pascal_value_print_inner): Declare.
6511         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
6512
6513 2020-03-13  Tom Tromey  <tom@tromey.com>
6514
6515         * m2-valprint.c (m2_value_print_inner): New function.
6516         * m2-lang.h (m2_value_print_inner): Declare.
6517         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
6518
6519 2020-03-13  Tom Tromey  <tom@tromey.com>
6520
6521         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
6522         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
6523         * c-valprint.c (c_value_print_inner): New function.
6524         * c-lang.h (c_value_print_inner): Declare.
6525         * c-lang.c (c_language_defn, cplus_language_defn)
6526         (asm_language_defn, minimal_language_defn): Use
6527         c_value_print_inner.
6528
6529 2020-03-13  Tom Tromey  <tom@tromey.com>
6530
6531         * p-valprint.c (pascal_object_print_value_fields): Now static.
6532         * p-lang.h (pascal_object_print_value_fields): Don't declare.
6533
6534 2020-03-13  Tom Tromey  <tom@tromey.com>
6535
6536         * c-valprint.c (c_val_print_array): Simplify.
6537
6538 2020-03-13  Tom Tromey  <tom@tromey.com>
6539
6540         * valprint.c (value_print_array_elements): New function.
6541         * valprint.h (value_print_array_elements): Declare.
6542
6543 2020-03-13  Tom Tromey  <tom@tromey.com>
6544
6545         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
6546         * mips-tdep.c (mips_print_register): Use
6547         value_print_scalar_formatted.
6548
6549 2020-03-13  Tom Tromey  <tom@tromey.com>
6550
6551         * valprint.h (value_print_scalar_formatted): Declare.
6552         * valprint.c (value_print_scalar_formatted): New function.
6553
6554 2020-03-13  Tom Tromey  <tom@tromey.com>
6555
6556         * valprint.h (generic_value_print): Declare.
6557         * valprint.c (generic_value_print): New function.
6558
6559 2020-03-13  Tom Tromey  <tom@tromey.com>
6560
6561         * valprint.c (do_val_print): Call la_value_print_inner, if
6562         available.
6563         * rust-lang.c (rust_language_defn): Update.
6564         * p-lang.c (pascal_language_defn): Update.
6565         * opencl-lang.c (opencl_language_defn): Update.
6566         * objc-lang.c (objc_language_defn): Update.
6567         * m2-lang.c (m2_language_defn): Update.
6568         * language.h (struct language_defn) <la_value_print_inner>: New
6569         member.
6570         * language.c (unknown_language_defn, auto_language_defn): Update.
6571         * go-lang.c (go_language_defn): Update.
6572         * f-lang.c (f_language_defn): Update.
6573         * d-lang.c (d_language_defn): Update.
6574         * c-lang.c (c_language_defn, cplus_language_defn)
6575         (asm_language_defn, minimal_language_defn): Update.
6576         * ada-lang.c (ada_language_defn): Update.
6577
6578 2020-03-13  Tom Tromey  <tom@tromey.com>
6579
6580         * c-valprint.c (c_value_print): Use common_val_print.
6581
6582 2020-03-13  Tom Tromey  <tom@tromey.com>
6583
6584         * cp-valprint.c (cp_print_static_field): Use common_val_print.
6585
6586 2020-03-13  Tom Tromey  <tom@tromey.com>
6587
6588         * f-valprint.c (f77_print_array_1, f_val_print): Use
6589         common_val_print.
6590
6591 2020-03-13  Tom Tromey  <tom@tromey.com>
6592
6593         * riscv-tdep.c (riscv_print_one_register_info): Use
6594         common_val_print.
6595
6596 2020-03-13  Tom Tromey  <tom@tromey.com>
6597
6598         * mi/mi-main.c (output_register): Use common_val_print.
6599
6600 2020-03-13  Tom Tromey  <tom@tromey.com>
6601
6602         * infcmd.c (default_print_one_register_info): Use
6603         common_val_print.
6604
6605 2020-03-13  Tom Tromey  <tom@tromey.com>
6606
6607         * valprint.h (common_val_print_checked): Declare.
6608         * valprint.c (common_val_print_checked): New function.
6609         * stack.c (print_frame_arg): Use common_val_print_checked.
6610
6611 2020-03-13  Tom Tromey  <tom@tromey.com>
6612
6613         * valprint.c (do_val_print): New function, from val_print.
6614         (val_print): Use do_val_print.
6615         (common_val_print): Use do_val_print.
6616
6617 2020-03-13  Tom Tromey  <tom@tromey.com>
6618
6619         * valprint.c (value_print): Use scoped_value_mark.
6620
6621 2020-03-13  Tom de Vries  <tdevries@suse.de>
6622
6623         PR symtab/25646
6624         * psymtab.c (partial_symtab::partial_symtab): Don't set
6625         globals_offset and statics_offset.  Push element onto
6626         current_global_psymbols and current_static_psymbols stacks.
6627         (concat): New function.
6628         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
6629         element from current_global_psymbols and current_static_psymbols
6630         stacks.  Concat popped elements to global_psymbols and
6631         static_symbols.
6632         (add_psymbol_to_list): Use current_global_psymbols and
6633         current_static_psymbols stacks.
6634         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
6635         current_static_psymbols fields.
6636
6637 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
6638
6639         * corelow.c (sniff_core_bfd): Remove.
6640         (class core_target) <m_core_vec>: Remove.
6641         (core_target::core_target): Update.
6642         (core_file_fns): Remove.
6643         (deprecated_add_core_fns): Remove.
6644         (default_core_sniffer): Remove.
6645         (sniff_core_bfd): Remove.
6646         (default_check_format): Remove.
6647         (gdb_check_format): Remove.
6648         (core_target_open): Update.
6649         (core_target::get_core_register_section): Update.
6650         (get_core_registers_cb): Update.
6651         (core_target::fetch_registers): Update.
6652         * gdbcore.h (struct core_fns): Remove.
6653         (deprecated_add_core_fns): Remove.
6654         (default_core_sniffer): Remove.
6655         (default_check_format): Remove.
6656
6657 2020-03-12  Tom Tromey  <tom@tromey.com>
6658
6659         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
6660         CORE_ADDR.
6661         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
6662
6663 2020-03-12  Tom Tromey  <tom@tromey.com>
6664
6665         * remote.c (remote_target::download_tracepoint)
6666         (remote_target::enable_tracepoint)
6667         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
6668         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
6669         sprintf_vma.
6670
6671 2020-03-12  Tom Tromey  <tom@tromey.com>
6672
6673         * symfile-mem.c: Update CORE_ADDR size assert.
6674
6675 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6676
6677         * selftest.m4: Move to gdbsupport/.
6678         * acinclude.m4: Update path to selftest.m4.
6679
6680 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6681
6682         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
6683         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
6684         gdbarch-selfselftests.c and selftest-arch.c.
6685         (SUBDIR_UNITTESTS_OBS): Rename to...
6686         (SELFTESTS_OBS): ... this.
6687         (COMMON_SFILES): Remove disasm-selftests.c and
6688         gdbarch-selftests.c.
6689         * configure.ac: Don't add selftest-arch.{c,o} to
6690         CONFIG_{SRCS,OBS}.
6691         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
6692         preprocessor conditions.
6693
6694 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6695
6696         * configure.ac: Don't source bfd/development.sh.
6697         * selftest.m4: Modify comment.
6698         * configure: Re-generate.
6699
6700 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6701
6702         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
6703         not "true" or "false".
6704         * configure: Re-generate.
6705
6706 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
6707
6708         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
6709         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
6710         renamed to arm_nbsd_supply_gregset.
6711         (fetch_register): Update to call arm_nbsd_supply_gregset.
6712         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
6713         (arm_netbsd_nat_target::fetch_registers): Update.
6714         (fetch_elfcore_registers): Removed.
6715         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
6716         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
6717         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
6718         not require NetBSD system headers.
6719         (arm_nbsd_regset): New struct.
6720         (arm_nbsd_iterate_over_regset_sections): New function.
6721         (arm_netbsd_init_abi_common): Updated to call
6722         set_gdbarch_iterate_over_regset_sections.
6723         * arm-nbsd-tdep.h: New file.
6724
6725 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
6726
6727         * symtab.c (find_pc_sect_line): Add check which prevents infinite
6728         recursion.
6729
6730 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
6731
6732         * configure: Re-generate.
6733
6734 2020-03-11  Tom Tromey  <tromey@adacore.com>
6735
6736         * ada-typeprint.c (print_choices): Fix comment.
6737
6738 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6739
6740         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
6741         previous item in the list, when the list has no items.
6742
6743 2020-03-11  Tom de Vries  <tdevries@suse.de>
6744
6745         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
6746         PROP_LOCLIST handling code.
6747
6748 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6749
6750         * buildsym-legacy.c (record_line): Pass extra parameter to
6751         record_line.
6752         * buildsym.c (buildsym_compunit::record_line): Take an extra
6753         parameter, reduce duplication in the line table, and record the
6754         is_stmt flag in the line table.
6755         * buildsym.h (buildsym_compunit::record_line): Add extra
6756         parameter.
6757         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
6758         non-statement lines.
6759         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
6760         this to the symtab builder.
6761         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
6762         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
6763         through to dwarf_record_line_1.
6764         * infrun.c (process_event_stop_test): When stepping, don't stop at
6765         a non-statement instruction, and only refresh the step info when
6766         we land in the middle of a line's range.  Also add an extra
6767         comment.
6768         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
6769         field.
6770         * record-btrace.c (btrace_find_line_range): Only record lines
6771         marked as is-statement.
6772         * stack.c (frame_show_address): Show the frame address if we are
6773         in a non-statement sal.
6774         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
6775         (maintenance_print_one_line_table): Print a header for the is_stmt
6776         column, and include is_stmt information in the output.
6777         * symtab.c (find_pc_sect_line): Find lines marked as statements in
6778         preference to non-statements.
6779         (find_pcs_for_symtab_line): Prefer is-statement entries.
6780         (find_line_common): Likewise.
6781         * symtab.h (struct linetable_entry): Add is_stmt field.
6782         (struct symtab_and_line): Likewise.
6783         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
6784         arranging the line table.
6785
6786 2020-03-07  Tom de Vries  <tdevries@suse.de>
6787
6788         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
6789         DIE.
6790
6791 2020-03-07  Tom Tromey  <tom@tromey.com>
6792
6793         * valops.c (value_literal_complex): Remove obsolete comment.
6794         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
6795         comment.
6796
6797 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
6798
6799         * infrun.h: Forward-declare thread_info.
6800         (set_step_info): Add thread_info parameter, add doc.
6801         * infrun.c (set_step_info): Add thread_info parameter, move doc
6802         to header.
6803         * infrun.c (process_event_stop_test): Pass thread to
6804         set_step_info call.
6805         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
6806         set_step_info.
6807         (prepare_one_step): Add thread_info parameter, pass it to
6808         set_step_frame and prepare_one_step (recursive) call.
6809         (step_1): Pass thread to prepare_one_step call.
6810         (step_command_fsm::should_stop): Pass thread to
6811         prepare_one_step.
6812         (until_next_fsm): Pass thread to set_step_frame call.
6813         (finish_command): Pass thread to set_step_info call.
6814
6815 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
6816
6817         * windows-tdep.c (windows_solib_create_inferior_hook):
6818         Check if inferior is running.
6819
6820 2020-03-06  Tom de Vries  <tdevries@suse.de>
6821
6822         * NEWS: Fix "the the".
6823         * ctfread.c: Same.
6824
6825 2020-03-06  Tom de Vries  <tdevries@suse.de>
6826
6827         * psymtab.c (psymtab_to_symtab): Don't print "done.".
6828
6829 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6830
6831         * .dir-locals.el: Add a comment referencing the other copies of
6832         this file.
6833
6834 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
6835
6836         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
6837         psargs.
6838
6839 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6840
6841         * .gitattributes: New file.
6842
6843 2020-03-04  Tom Tromey  <tom@tromey.com>
6844
6845         * symmisc.c (print_symbol_bcache_statistics)
6846         (print_objfile_statistics): Update.
6847         * symfile.c (allocate_symtab): Use intern.
6848         * psymtab.c (partial_symtab::partial_symtab): Use intern.
6849         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6850         macro_cache>: Remove.
6851         <string_cache>: New member.
6852         (struct objfile) <intern>: New methods.
6853         * elfread.c (elf_symtab_read): Use intern.
6854         * dwarf2/read.c (fixup_go_packaging): Intern package name.
6855         (dwarf2_compute_name, dwarf2_physname)
6856         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
6857         names.
6858         (guess_partial_die_structure_name): Update.
6859         (partial_die_info::fixup): Intern name.
6860         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
6861         name.
6862         (dwarf2_name): Intern name.  Update.
6863         * buildsym.c (buildsym_compunit::get_macro_table): Use
6864         string_cache.
6865
6866 2020-03-04  Tom Tromey  <tom@tromey.com>
6867
6868         * jit.c (bfd_open_from_target_memory): Make "target" const.
6869         * corefile.c (gnutarget): Now const.
6870         * gdbcore.h (gnutarget): Now const.
6871
6872 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
6873
6874         * NEWS: Mention support for WOW64 processes.
6875         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
6876         (amd64_windows_segment_register_p): Remove static.
6877         (_initialize_amd64_windows_nat): Update.
6878         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
6879         * i386-windows-nat.c (context_offset): Update.
6880         (i386_mappings): Rename and remove static.
6881         (i386_windows_segment_register_p): Remove static.
6882         (_initialize_i386_windows_nat): Update.
6883         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
6884         (STATUS_WX86_SINGLE_STEP): New macro.
6885         (EnumProcessModulesEx): New macro.
6886         (Wow64SuspendThread): New macro.
6887         (Wow64GetThreadContext): New macro.
6888         (Wow64SetThreadContext): New macro.
6889         (Wow64GetThreadSelectorEntry): New macro.
6890         (windows_set_context_register_offsets): Add static.
6891         (windows_set_segment_register_p): Likewise.
6892         (windows_add_thread): Adapt for WOW64 processes.
6893         (windows_fetch_one_register): Likewise.
6894         (windows_nat_target::fetch_registers): Likewise.
6895         (windows_store_one_register): Likewise.
6896         (display_selector): Likewise.
6897         (display_selectors): Likewise.
6898         (handle_exception): Likewise.
6899         (windows_continue): Likewise.
6900         (windows_nat_target::resume): Likewise.
6901         (windows_add_all_dlls): Likewise.
6902         (do_initial_windows_stuff): Likewise.
6903         (windows_nat_target::attach): Likewise.
6904         (windows_get_exec_module_filename): Likewise.
6905         (windows_nat_target::create_inferior): Likewise.
6906         (windows_xfer_siginfo): Likewise.
6907         (_initialize_loadable): Initialize Wow64SuspendThread,
6908         Wow64GetThreadContext, Wow64SetThreadContext,
6909         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
6910         * windows-nat.h (windows_set_context_register_offsets):
6911         Remove declaration.
6912         (windows_set_segment_register_p): Likewise.
6913         (i386_windows_segment_register_p): Add declaration.
6914         (amd64_windows_segment_register_p): Likewise.
6915
6916 2020-03-04  Luis Machado  <luis.machado@linaro.org>
6917
6918         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
6919         in "info registers" for AArch64/ARM.
6920
6921         The change caused "info registers" to not print GPR's.
6922
6923         gdb/ChangeLog:
6924
6925         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
6926
6927         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
6928         when reg->group is empty and reggroup is not.
6929
6930 2020-03-03  Tom Tromey  <tromey@adacore.com>
6931
6932         * dwarf2/frame.c (struct dwarf2_frame_cache)
6933         <checked_tailcall_bottom, entry_cfa_sp_offset,
6934         entry_cfa_sp_offset_p>: Remove members.
6935         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
6936         (dwarf2_frame_prev_register): Don't call
6937         dwarf2_tailcall_sniffer_first.
6938         (dwarf2_append_unwinders): Don't append tailcall unwinder.
6939         * frame-unwind.c (add_unwinder): New fuction.
6940         (frame_unwind_init): Use it.  Add tailcall unwinder.
6941
6942 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6943             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
6944
6945         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
6946         value should be printed as true.
6947
6948 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
6949
6950         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
6951         (windows_init_abi): Set and use windows_so_ops.
6952
6953 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
6954
6955         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
6956         when verifying if dealing with a convenience variable.
6957
6958 2020-03-03  Luis Machado  <luis.machado@linaro.org>
6959
6960         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
6961
6962 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
6963
6964         * infrun.c (gdbarch_supports_displaced_stepping): New.
6965         (use_displaced_stepping): Break up conditions in smaller pieces.
6966         Use gdbarch_supports_displaced_stepping.
6967         (displaced_step_prepare_throw): Use
6968         gdbarch_supports_displaced_stepping.
6969
6970 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6971
6972         * NEWS: Mention new behaviour of the history filename.
6973         * top.c (write_history_p): Add comment.
6974         (show_write_history_p): Add header comment, give a different
6975         message when history writing is on, but the history filename is
6976         empty.
6977         (history_filename): Add comment.
6978         (history_filename_empty): New function.
6979         (show_history_filename): Add header comment, give a different
6980         message when the filename is empty.
6981         (init_history): Compare history_filename against nullptr, and only
6982         read history if the filename is not empty.
6983         (set_history_filename): Add header comment, and only make
6984         non-empty filenames absolute.
6985         (init_main): Make the filename argument to 'set history filename'
6986         optional.
6987
6988 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
6989
6990         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
6991         (arm_supply_vfpregset): ...this, and update to use VFP registers.
6992         (fetch_fp_register): Update.
6993         (fetch_fp_regs): Update.
6994         (store_fp_register): Update.
6995         (store_fp_regs): Update.
6996         (arm_netbsd_nat_target::read_description): New function.
6997         (fetch_elfcore_registers): Update.
6998
6999 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7000
7001         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
7002         general_thread if the stop reply is missing a thread-id.
7003         (remote_target::process_stop_reply): Use the first non-exited
7004         thread if the target didn't pass a thread-id.
7005         * infrun.c (do_target_wait): Move call to
7006         switch_to_inferior_no_thread to ....
7007         (do_target_wait_1): ... here.
7008
7009 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
7010
7011         * debuginfod-support.c: Include defs.h first.
7012
7013 2020-02-28  Tom de Vries  <tdevries@suse.de>
7014
7015         * symfile.c (set_initial_language): Use default language for lookup.
7016
7017 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
7018
7019         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
7020         reader variable, pass `this` to read_cutu_die_from_dwo.
7021
7022 2020-02-27  Aaron Merey  <amerey@redhat.com>
7023
7024         * source.c (open_source_file): Check for nullptr when computing
7025         srcpath.
7026
7027 2020-02-27  Tom Tromey  <tromey@adacore.com>
7028
7029         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
7030         member.
7031         (dwarf2_add_field): Don't update nfields.
7032         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
7033
7034 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7035
7036         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
7037         abs.
7038
7039 2020-02-26  Tom Tromey  <tom@tromey.com>
7040
7041         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
7042         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
7043         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
7044         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
7045         per_cu_data.
7046
7047 2020-02-26  Tom Tromey  <tom@tromey.com>
7048
7049         * dwarf2/index-write.c (psym_index_map): Change type.
7050         (add_address_entry_worker, write_one_signatured_type)
7051         (recursively_count_psymbols, recursively_write_psymbols)
7052         (class debug_names, psyms_seen_size, write_gdbindex)
7053         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
7054
7055 2020-02-26  Aaron Merey  <amerey@redhat.com>
7056
7057         * Makefile.in: Handle optional debuginfod support.
7058         * NEWS: Update.
7059         * README: Add --with-debuginfod summary.
7060         * config.in: Regenerate.
7061         * configure: Regenerate.
7062         * configure.ac: Handle optional debuginfod support.
7063         * debuginfod-support.c: debuginfod helper functions.
7064         * debuginfod-support.h: Ditto.
7065         * doc/gdb.texinfo: Add --with-debuginfod to configure options
7066         summary.
7067         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
7068         when a dwz file cannot be found.
7069         * elfread.c (elf_symfile_read): Query debuginfod servers when a
7070         debuginfo file cannot be found.
7071         * source.c (open_source_file): Query debuginfod servers when a
7072         source file cannot be found.
7073         * top.c (print_gdb_configuration): Include
7074         --{with,without}-debuginfod in the output.
7075
7076 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
7077
7078         * thread.c (thr_try_catch_cmd): Print thread name.
7079
7080 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
7081
7082         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
7083         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
7084         dwarf2_fetch_die_type_sect_off): Move to...
7085         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
7086         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
7087         dwarf2_fetch_die_type_sect_off): ... here.
7088         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
7089         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
7090         dwarf2_fetch_die_type_sect_off): Move doc to header file.
7091
7092 2020-02-26  Tom de Vries  <tdevries@suse.de>
7093
7094         PR gdb/25603
7095         * symfile.c (set_initial_language): Exit-early if
7096         language_mode == language_mode_manual.
7097
7098 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
7099
7100         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
7101         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
7102         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
7103
7104 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
7105
7106         * gdbtypes.c (create_array_type_with_stride): Handle negative
7107         array strides.
7108         * valarith.c (value_subscripted_rvalue): Likewise.
7109
7110 2020-02-25  Luis Machado  <luis.machado@linaro.org>
7111
7112         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
7113
7114 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
7115
7116         * loc.h (dwarf2_get_die_type): Move to...
7117         * read.h (dwarf2_get_die_type): ... here.
7118         * read.c (dwarf2_get_die_type): Move doc to header.
7119
7120 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
7121
7122         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
7123         'gnulib/Makefile.in' to the list.
7124
7125 2020-02-24  Tom Tromey  <tom@tromey.com>
7126
7127         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
7128         Remove.
7129         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
7130         XOBNEWVEC.
7131
7132 2020-02-24  Tom Tromey  <tom@tromey.com>
7133
7134         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
7135         New method.
7136         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
7137         (dw2_do_instantiate_symtab, dw2_get_file_names)
7138         (build_type_psymtab_dependencies, load_full_type_unit): Update.
7139
7140 2020-02-24  Tom Tromey  <tom@tromey.com>
7141
7142         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
7143         make_scoped_restore.
7144         (dwarf2_psymtab::read_symtab): Don't clear
7145         reading_partial_symbols.
7146
7147 2020-02-24  Tom de Vries  <tdevries@suse.de>
7148
7149         PR gdb/25592
7150         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
7151
7152 2020-02-24  Tom de Vries  <tdevries@suse.de>
7153
7154         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
7155         commands layout next/prev/regs.
7156
7157 2020-02-22  Tom Tromey  <tom@tromey.com>
7158
7159         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
7160         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
7161
7162 2020-02-22  Tom Tromey  <tom@tromey.com>
7163
7164         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
7165
7166 2020-02-22  Tom Tromey  <tom@tromey.com>
7167
7168         * tui/tui-win.c (_initialize_tui_win): Add usage text.
7169         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
7170         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
7171         * tui/tui.c (_initialize_tui): Add usage text.
7172
7173 2020-02-22  Tom Tromey  <tom@tromey.com>
7174
7175         * tui/tui-win.c (tui_set_focus_command)
7176         (tui_set_win_height_command): Use error_no_arg.
7177         (_initialize_tui_win): Update help text.
7178         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
7179
7180 2020-02-22  Tom Tromey  <tom@tromey.com>
7181
7182         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
7183         * tui/tui-disasm.h (struct tui_disasm_window)
7184         <display_start_addr>: Declare.
7185         * tui/tui-source.h (struct tui_source_window)
7186         <display_start_addr>: Declare.
7187         * tui/tui-winsource.h (struct tui_source_window_base)
7188         <show_source_line, display_start_addr>: New methods.
7189         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
7190         Rename and move to protected section.
7191         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
7192         (tui_source_window_base::do_erase_source_content): Update.
7193         (tui_source_window_base::show_source_line): Now a method.
7194         (tui_source_window_base::show_source_content)
7195         (tui_source_window_base::tui_source_window_base)
7196         (tui_source_window_base::rerender)
7197         (tui_source_window_base::refill)
7198         (tui_source_window_base::do_scroll_horizontal)
7199         (tui_source_window_base::set_is_exec_point_at)
7200         (tui_source_window_base::update_breakpoint_info)
7201         (tui_source_window_base::update_exec_info): Update.
7202         * tui/tui-source.c (tui_source_window::set_contents)
7203         (tui_source_window::showing_source_p)
7204         (tui_source_window::do_scroll_vertical)
7205         (tui_source_window::location_matches_p)
7206         (tui_source_window::line_is_displayed): Update.
7207         (tui_source_window::display_start_addr): New method.
7208         * tui/tui-disasm.c (tui_disasm_window::set_contents)
7209         (tui_disasm_window::do_scroll_vertical)
7210         (tui_disasm_window::location_matches_p): Update.
7211         (tui_disasm_window::display_start_addr): New method.
7212
7213 2020-02-22  Tom Tromey  <tom@tromey.com>
7214
7215         * NEWS: Add entry for gdb.register_window_type.
7216         * tui/tui-layout.h (window_factory): New typedef.
7217         (tui_register_window): Declare.
7218         * tui/tui-layout.c (saved_tui_windows): New global.
7219         (tui_apply_current_layout): Use it.
7220         (tui_register_window): New function.
7221         * python/python.c (do_start_initialization): Call
7222         gdbpy_initialize_tui.
7223         (python_GdbMethods): Add "register_window_type" function.
7224         * python/python-internal.h (gdbpy_register_tui_window)
7225         (gdbpy_initialize_tui): Declare.
7226         * python/py-tui.c: New file.
7227         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
7228
7229 2020-02-22  Tom Tromey  <tom@tromey.com>
7230
7231         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
7232
7233 2020-02-22  Tom Tromey  <tom@tromey.com>
7234
7235         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
7236         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
7237         * tui/tui-data.c (tui_set_win_with_focus): Remove.
7238         (tui_set_win_focus_to): Move from tui-win.c.
7239
7240 2020-02-22  Tom Tromey  <tom@tromey.com>
7241
7242         * tui/tui-layout.c (make_standard_window, get_locator_window): New
7243         functions.
7244         (known_window_types): New global.
7245         (tui_get_window_by_name): Reimplement.
7246         (initialize_known_windows): New function.
7247         (validate_window_name): Rewrite.
7248         (_initialize_tui_layout): Call initialize_known_windows.
7249
7250 2020-02-22  Tom Tromey  <tom@tromey.com>
7251
7252         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
7253         Remove constants.
7254         * tui/tui-winsource.h (struct tui_source_window_base)
7255         <tui_source_window_base>: Remove parameter.
7256         * tui/tui-winsource.c
7257         (tui_source_window_base::tui_source_window_base): Remove
7258         parameter.
7259         (tui_source_window_base::refill): Update.
7260         * tui/tui-stack.h (struct tui_locator_window)
7261         <tui_locator_window>: Update.
7262         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
7263         Default the constructor.
7264         * tui/tui-regs.h (struct tui_data_item_window)
7265         <tui_data_item_window>: Default the constructor.
7266         (struct tui_data_window) <tui_data_window>: Likewise.
7267         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
7268         Default the constructor.
7269         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
7270         Default the constructor.
7271         <type>: Remove.
7272         (struct tui_win_info) <tui_win_info>: Default the constructor.
7273         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
7274         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
7275         Default the constructor.
7276
7277 2020-02-22  Tom Tromey  <tom@tromey.com>
7278
7279         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
7280         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
7281         * tui/tui-win.c (tui_resize_all): Don't call
7282         tui_delete_invisible_windows.
7283         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
7284         done.
7285         (tui_set_layout): Update.
7286         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
7287         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
7288         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
7289
7290 2020-02-22  Tom Tromey  <tom@tromey.com>
7291
7292         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
7293         correctly.
7294
7295 2020-02-22  Tom Tromey  <tom@tromey.com>
7296
7297         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
7298
7299 2020-02-22  Tom Tromey  <tom@tromey.com>
7300
7301         * tui/tui-winsource.h (struct tui_source_window_iterator)
7302         <inner_iterator>: New etytypedef.
7303         <tui_source_window_iterator>: Take "end" parameter.
7304         <tui_source_window_iterator>: Take iterator.
7305         <operator*, advance>: Update.
7306         <m_iter>: Change type.
7307         <m_end>: New field.
7308         (struct tui_source_windows) <begin, end>: Update.
7309         * tui/tui-layout.c (tui_windows): New global.
7310         (tui_apply_current_layout): Clear tui_windows.
7311         (tui_layout_window::apply): Update tui_windows.
7312         * tui/tui-data.h (tui_windows): Declare.
7313         (all_tui_windows): Now inline function.
7314         (class tui_window_iterator, struct all_tui_windows): Remove.
7315
7316 2020-02-22  Tom Tromey  <tom@tromey.com>
7317
7318         PR tui/17850:
7319         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
7320         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
7321         "height" argument.
7322         (class tui_layout_window) <get_sizes>: Likewise.
7323         (class tui_layout_split) <tui_layout_split>: Add "vertical"
7324         argument.
7325         <get_sizes>: Add "height" argument.
7326         <m_vertical>: New field.
7327         * tui/tui-layout.c (tui_layout_split::clone): Update.
7328         (tui_layout_split::get_sizes): Add "height" argument.
7329         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
7330         (tui_new_layout_command): Parse "-horizontal".
7331         (_initialize_tui_layout): Update help string.
7332         (tui_layout_split::specification): Add "-horizontal" when needed.
7333         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
7334         argument.
7335         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
7336         New methods.
7337
7338 2020-02-22  Tom Tromey  <tom@tromey.com>
7339
7340         * tui/tui-layout.h (enum tui_adjust_result): New.
7341         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
7342         (class tui_layout_window) <adjust_size>: Return
7343         tui_adjust_result.  Rewrite.
7344         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
7345         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
7346
7347 2020-02-22  Tom Tromey  <tom@tromey.com>
7348
7349         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
7350         parameter and return types.
7351         (class tui_layout_base) <specification>: Add "depth".
7352         (class tui_layout_window) <specification>: Add "depth".
7353         (class tui_layout_split) <specification>: Add "depth".
7354         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
7355         and return types.
7356         (tui_new_layout_command): Parse sub-layouts.
7357         (_initialize_tui_layout): Update help string.
7358         (tui_layout_window::specification): Add "depth".
7359         (add_layout_command): Update.
7360
7361 2020-02-22  Tom Tromey  <tom@tromey.com>
7362
7363         * NEWS: Add "tui new-layout" item.
7364         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
7365         Add new-layout command to help text.
7366         (validate_window_name): New function.
7367         (tui_new_layout_command): New function.
7368         (_initialize_tui_layout): Register "new-layout".
7369         (tui_layout_window::specification): New method.
7370         (tui_layout_window::specification): New method.
7371         * tui/tui-layout.h (class tui_layout_base) <specification>: New
7372         method.
7373         (class tui_layout_window) <specification>: New method.
7374         (class tui_layout_split) <specification>: New method.
7375
7376 2020-02-22  Tom Tromey  <tom@tromey.com>
7377
7378         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
7379         * tui/tui-win.c (window_name_completer): Update comment.
7380         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
7381         Declare method.
7382         (class tui_layout_window) <replace_window>: Likewise.
7383         (class tui_layout_split) <replace_window>: Likewise.
7384         (tui_set_layout): Don't declare.
7385         (tui_set_initial_layout): Declare function.
7386         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
7387         (asm_regs_layout): New globals.
7388         (tui_current_layout, show_layout): Remove.
7389         (tui_set_layout, tui_add_win_to_layout): Rewrite.
7390         (find_layout, tui_apply_layout): New function.
7391         (layout_completer): Remove.
7392         (tui_next_layout): Reimplement.
7393         (tui_next_layout_command): New function.
7394         (tui_set_initial_layout, tui_prev_layout_command): New functions.
7395         (tui_regs_layout): Reimplement.
7396         (tui_regs_layout_command): New function.
7397         (extract_display_start_addr): Rewrite.
7398         (next_layout, prev_layout): Remove.
7399         (tui_layout_window::replace_window): New method.
7400         (tui_layout_split::replace_window): New method.
7401         (destroy_layout): New function.
7402         (layout_list): New global.
7403         (add_layout_command): New function.
7404         (initialize_layouts): Update.
7405         (tui_layout_command): New function.
7406         (_initialize_tui_layout): Install "layout" commands.
7407         * tui/tui-data.h (enum tui_layout_type): Remove.
7408         (tui_current_layout): Don't declare.
7409
7410 2020-02-22  Tom Tromey  <tom@tromey.com>
7411
7412         * tui/tui-regs.c (tui_reg_layout): Remove.
7413         (tui_reg_command): Use tui_regs_layout.
7414         * tui/tui-layout.h (tui_reg_command): Declare.
7415         * tui/tui-layout.c (tui_reg_command): New function.
7416
7417 2020-02-22  Tom Tromey  <tom@tromey.com>
7418
7419         * tui/tui.c (tui_rl_delete_other_windows): Call
7420         tui_remove_some_windows.
7421         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
7422         Declare method.
7423         (class tui_layout_window) <remove_windows>: New method.
7424         (class tui_layout_split) <remove_windows>: Declare.
7425         (tui_remove_some_windows): Declare.
7426         * tui/tui-layout.c (tui_remove_some_windows): New function.
7427         (tui_layout_split::remove_windows): New method.
7428
7429 2020-02-22  Tom Tromey  <tom@tromey.com>
7430
7431         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
7432         * tui/tui-layout.h (tui_next_layout): Declare.
7433         * tui/tui-layout.c (tui_next_layout): New function.
7434
7435 2020-02-22  Tom Tromey  <tom@tromey.com>
7436
7437         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
7438         correct coordinates.
7439
7440 2020-02-22  Tom Tromey  <tom@tromey.com>
7441
7442         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
7443         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
7444         DATA_WIN case.
7445
7446 2020-02-22  Tom Tromey  <tom@tromey.com>
7447
7448         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
7449         TUI_DISASM_WIN, not tui_win_list.
7450
7451 2020-02-22  Tom Tromey  <tom@tromey.com>
7452
7453         * valprint.c (generic_val_print_enum_1)
7454         (val_print_type_code_flags): Style member names.
7455         * rust-lang.c (val_print_struct, rust_print_enum)
7456         (rust_print_struct_def, rust_internal_print_type): Style member
7457         names.
7458         * p-valprint.c (pascal_object_print_value_fields): Style member
7459         names.  Only call fprintf_symbol_filtered for static members.
7460         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
7461         * f-valprint.c (f_val_print): Style member names.
7462         * f-typeprint.c (f_type_print_base): Style member names.
7463         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
7464         call fprintf_symbol_filtered for static members.
7465         (cp_print_class_member): Style member names.
7466         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
7467         member names.
7468         * ada-valprint.c (ada_print_scalar): Style enum names.
7469         (ada_val_print_enum): Likewise.
7470         * ada-typeprint.c (print_enum_type): Style enum names.
7471
7472 2020-02-21  Tom Tromey  <tom@tromey.com>
7473
7474         * psympriv.h (struct partial_symtab): Update comment.
7475
7476 2020-02-21  Tom Tromey  <tromey@adacore.com>
7477
7478         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
7479         type is CORE_ADDR.
7480
7481 2020-02-21  Tom de Vries  <tdevries@suse.de>
7482
7483         PR gdb/25534
7484         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
7485         if dependencies[i]->user != NULL.
7486
7487 2020-02-21  Ali Tamur  <tamur@google.com>
7488
7489         * dwarf2/read.c (dwarf2_name): Add null check.
7490
7491 2020-02-20  Tom Tromey  <tom@tromey.com>
7492
7493         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
7494         ">=", in binary search.
7495         (dwarf2_find_containing_comp_unit): New overload.
7496         (run_test): New self-test.
7497         (_initialize_dwarf2_read): Register new test.
7498
7499 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
7500
7501         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
7502         * riscv-tdep.h: Likewise.
7503         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
7504         rv32-only CSR.
7505         * features/riscv/64bit-csr.xml: Regenerated.
7506
7507 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
7508             Tom Tromey  <tom@tromey.com>
7509
7510         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
7511         of 'fputc_unfiltered'.
7512         (putchar_unfiltered): Call 'fputc_unfiltered'.
7513         (fputc_unfiltered): Call 'fputs_unfiltered'.
7514
7515 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
7516
7517         * config.in: Regenerate.
7518         * configure: Regenerate.
7519         * configure.ac: Add --with-python-libdir option.
7520         * main.c: Use WITH_PYTHON_LIBDIR.
7521
7522 2020-02-19  Tom Tromey  <tom@tromey.com>
7523
7524         * symtab.c (general_symbol_info::compute_and_set_names): Use
7525         obstack_strndup.  Simplify call to symbol_set_demangled_name.
7526
7527 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
7528
7529         * dwarf2/read.c (allocate_signatured_type_table,
7530         allocate_dwo_unit_table, allocate_type_unit_groups_table,
7531         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
7532         Remove objfile parameter, update all callers.
7533
7534 2020-02-19  Doug Evans  <dje@google.com>
7535
7536         PR rust/25535
7537         * rust-lang.c (rust_print_enum): Apply embedded_offset to
7538         rust_enum_variant calculation.
7539
7540 2020-02-19  Tom Tromey  <tromey@adacore.com>
7541
7542         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
7543
7544 2020-02-19  Tom Tromey  <tromey@adacore.com>
7545
7546         * ada-lang.c (cache_symbol): Use obstack_strdup.
7547
7548 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7549
7550         * configure: Regenerate.
7551
7552 2020-02-19  Tom Tromey  <tromey@adacore.com>
7553
7554         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
7555         NULL check.
7556
7557 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
7558
7559         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
7560
7561 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7562
7563         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
7564         if GDBSERVER is not defined.
7565         (riscv_tdesc_cache): Likewise, also store const target_desc.
7566         (STATIC_IN_GDB): Define.
7567         (riscv_create_target_description): Update declaration with
7568         STATIC_IN_GDB.
7569         (riscv_lookup_target_description): New function, only define if
7570         GDBSERVER is not defined.
7571         * arch/riscv.h (riscv_create_target_description): Declare only
7572         when GDBSERVER is defined.
7573         (riscv_lookup_target_description): New declaration when GDBSERVER
7574         is not defined.
7575         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
7576         (riscv_linux_read_features): ...this, and return
7577         riscv_gdbarch_features instead of target_desc.
7578         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
7579         (riscv_linux_read_description): Rename to...
7580         (riscv_linux_read_features): ...this.
7581         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
7582         Update to use riscv_gdbarch_features and
7583         riscv_lookup_target_description.
7584         * riscv-tdep.c (riscv_find_default_target_description): Use
7585         riscv_lookup_target_description instead of
7586         riscv_create_target_description.
7587
7588 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7589
7590         * valprint.c (generic_val_print_enum_1): When printing a flag
7591         enum with value 0 and there is no enumerator with value 0, print
7592         just "0" instead of "(unknown: 0x0)".
7593
7594 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7595
7596         * valprint.c (generic_val_print_enum_1): Print unknown part of
7597         flag enum in hex.
7598
7599 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7600
7601         * dwarf2/read.c (update_enumeration_type_from_children): Allow
7602         flag enums to contain duplicate enumerators.
7603         * valprint.c (generic_val_print_enum_1): Update comment.
7604
7605 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7606
7607         * dwarf2/read.c: Include "count-one-bits.h".
7608         (update_enumeration_type_from_children): If an enumerator has
7609         multiple bits set, don't treat the enumeration as a "flag enum".
7610         * valprint.c (generic_val_print_enum_1): Assert that enumerators
7611         of flag enums have 0 or 1 bit set.
7612
7613 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7614
7615         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
7616         conversion.
7617         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7618         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
7619         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7620         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
7621         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7622
7623 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7624
7625         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
7626
7627 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7628
7629         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
7630         displaced_step_closure_up.
7631         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
7632         (struct displaced_step_closure_up):
7633         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7634         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
7635         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
7636         Likewise.
7637         * gdbarch.sh (displaced_step_copy_insn): Likewise.
7638         * gdbarch.c, gdbarch.h: Re-generate.
7639         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
7640         displaced_step_closure_up.
7641         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7642         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
7643         * infrun.h (displaced_step_closure_up): New type alias.
7644         (struct displaced_step_inferior_state) <step_closure>: Change
7645         type to displaced_step_closure_up.
7646         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
7647         displaced_step_closure_up.
7648         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7649
7650 2020-02-14  Tom Tromey  <tom@tromey.com>
7651
7652         * minidebug.c (gnu_debug_key): New global.
7653         (find_separate_debug_file_in_section): Use it.
7654
7655 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7656
7657         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
7658         std::unique_ptr.
7659         * gdbarch.c: Re-generate.
7660         * gdbarch.h: Re-generate.
7661         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
7662         change.
7663         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
7664         type to std::unique_ptr.
7665         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
7666         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7667         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
7668         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
7669         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
7670         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7671         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
7672         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
7673         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7674
7675 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7676
7677         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
7678         std::unique_ptr.
7679         (displaced_step_clear): Rename to...
7680         (displaced_step_reset): ... this.  Just call displaced->reset ().
7681         (displaced_step_clear_cleanup): Rename to...
7682         (displaced_step_reset_cleanup): ... this.
7683         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
7684         (displaced_step_fixup): Likewise.
7685         (resume_1): Likewise.
7686         (handle_inferior_event): Restore child's memory before calling
7687         displaced_step_fixup on the parent.
7688         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
7689         to std::unique_ptr.
7690         <step_closure>: Change type to std::unique_ptr.
7691
7692 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7693
7694         * arm-tdep.c: Include count-one-bits.h.
7695         (cleanup_block_store_pc): Use count_one_bits.
7696         (cleanup_block_load_pc): Use count_one_bits.
7697         (arm_copy_block_xfer): Use count_one_bits.
7698         (thumb2_copy_block_xfer): Use count_one_bits.
7699         (thumb_copy_pop_pc_16bit): Use count_one_bits.
7700         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
7701         (thumb_get_next_pcs_raw): Use count_one_bits.
7702         (arm_get_next_pcs_raw): Use count_one_bits_l.
7703         * arch/arm.c (bitcount): Remove.
7704         * arch/arm.h (bitcount): Remove.
7705
7706 2020-02-14  Tom Tromey  <tromey@adacore.com>
7707
7708         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
7709         Update.
7710         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
7711         * dwarf2/loc.c (call_site_find_chain_1): Return
7712         unique_xmalloc_ptr.
7713         (call_site_find_chain): Likewise.
7714
7715 2020-02-14  Richard Biener  <rguenther@suse.de>
7716
7717         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
7718         on expression with division operators.
7719
7720 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
7721
7722         * MAINTAINERS (Write After Approval): Adding myself.
7723
7724 2020-02-12  Tom Tromey  <tom@tromey.com>
7725
7726         * event-loop.c (event_data, gdb_event, event_handler_func):
7727         Remove.
7728
7729 2020-02-12  Tom Tromey  <tom@tromey.com>
7730
7731         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
7732         (dwarf2_frame_objfile_data): Add comment.
7733         (find_comp_unit, set_comp_unit): New functions.
7734         (dwarf2_frame_find_fde): Use find_comp_unit.
7735         (dwarf2_build_frame_info): Use set_comp_unit.
7736
7737 2020-02-12  Tom Tromey  <tom@tromey.com>
7738
7739         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
7740         (comp_unit): Don't initialize objfile.
7741         (execute_cfa_program): Add text_offset parameter.
7742         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
7743         (dwarf2_frame_cache): Update.
7744         (dwarf2_build_frame_info): Don't set "objfile" member.
7745
7746 2020-02-12  Tom Tromey  <tom@tromey.com>
7747
7748         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
7749         (decode_frame_entry): Likewise.
7750         (dwarf2_build_frame_info): Update.
7751
7752 2020-02-12  Tom Tromey  <tom@tromey.com>
7753
7754         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
7755         (decode_frame_entry_1): Use the comp_unit obstack.
7756
7757 2020-02-12  Tom Tromey  <tom@tromey.com>
7758
7759         * dwarf2/frame.c (struct comp_unit): Add initializers and
7760         constructor.
7761         (dwarf2_frame_objfile_data): Store a comp_unit.
7762         (dwarf2_frame_find_fde): Update.
7763         (dwarf2_build_frame_info): Use "new".
7764
7765 2020-02-12  Tom Tromey  <tom@tromey.com>
7766
7767         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
7768         (dwarf2_fde_table): Typedef for std::vector.
7769         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
7770         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
7771         (decode_frame_entry): Update.
7772         (dwarf2_build_frame_info): Use "new".
7773
7774 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7775
7776         * arm-tdep.c (arm_gdbarch_init): Update.
7777         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
7778         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
7779         have_neon, is_m>: Change to bool.
7780
7781 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7782
7783         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
7784
7785 2020-02-12  Tom Tromey  <tom@tromey.com>
7786
7787         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
7788
7789 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
7790
7791         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
7792         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
7793
7794 2020-02-11  Tom Tromey  <tom@tromey.com>
7795
7796         * psymtab.h: Update comment.
7797
7798 2020-02-11  Tom Tromey  <tom@tromey.com>
7799
7800         * gdb_obstack.h (struct auto_obstack): Use
7801         DISABLE_COPY_AND_ASSIGN.
7802
7803 2020-02-11  Tom Tromey  <tom@tromey.com>
7804
7805         * dwarf2/frame.h (struct objfile): Don't forward declare.
7806
7807 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7808
7809         * cris-tdep.c (cris_supply_gregset): Change signature to match
7810         what struct regset expects.
7811         (cris_regset): New struct.
7812         (fetch_core_registers): Remove.
7813         (cris_iterate_over_regset_sections): New function.
7814         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
7815         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
7816
7817 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7818
7819         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
7820         registers.
7821
7822 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7823
7824         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
7825
7826 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7827
7828         * configure: Re-generate.
7829
7830 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7831
7832         * configure: Re-generate.
7833
7834 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7835
7836         * acinclude: Update warning.m4 path.
7837         * warning.m4: Move to gdbsupport.
7838
7839 2020-02-11  Tom Tromey  <tromey@adacore.com>
7840
7841         * remote.c (remote_console_output): Update.
7842         * printcmd.c (printf_command): Update.
7843         * event-loop.c (gdb_wait_for_event): Update.
7844         * linux-nat.c (sigchld_handler): Update.
7845         * remote-sim.c (gdb_os_write_stdout): Update.
7846         (gdb_os_flush_stdout): Update.
7847         (gdb_os_flush_stderr): Update.
7848         (gdb_os_write_stderr): Update.
7849         * exceptions.c (print_exception): Update.
7850         * remote-fileio.c (remote_fileio_func_read): Update.
7851         (remote_fileio_func_write): Update.
7852         * tui/tui.c (tui_enable): Update.
7853         * tui/tui-interp.c (tui_interp::init): Update.
7854         * utils.c (init_page_info): Update.
7855         (putchar_unfiltered, fputc_unfiltered): Update.
7856         (gdb_flush): Update.
7857         (emit_style_escape): Update.
7858         (flush_wrap_buffer, fputs_maybe_filtered): Update.
7859         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
7860         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
7861         (stderr_file::write): Update.
7862         (stderr_file::puts): Update.
7863         * ui-file.h (ui_file_isatty, ui_file_write)
7864         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
7865         (ui_file_puts): Don't declare.
7866
7867 2020-02-10  Tom de Vries  <tdevries@suse.de>
7868
7869         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
7870         sentinel to char *.
7871
7872 2020-02-09  Tom de Vries  <tdevries@suse.de>
7873
7874         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
7875         filename if it matches "<artificial>".
7876
7877 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7878
7879         * windows-tdep.c (struct enum_value_name): New struct.
7880         (create_enum): New function.
7881         (windows_get_siginfo_type): Create and use enum types.
7882
7883 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7884
7885         * NEWS: Mention $_siginfo support for Windows.
7886         * windows-nat.c (handle_exception): Set siginfo_er.
7887         (windows_nat_target::mourn_inferior): Reset siginfo_er.
7888         (windows_xfer_siginfo): New function.
7889         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
7890         * windows-tdep.c (struct windows_gdbarch_data): New struct.
7891         (init_windows_gdbarch_data): New function.
7892         (get_windows_gdbarch_data): New function.
7893         (windows_get_siginfo_type): New function.
7894         (windows_init_abi): Register windows_get_siginfo_type.
7895         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
7896
7897 2020-02-08  Tom Tromey  <tom@tromey.com>
7898
7899         * dwarf2/read.c (class cutu_reader) <cutu_reader,
7900         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
7901         <keep>: Declare method.
7902         <m_keep>: Remove member.
7903         <~cutu_reader>: Remove.
7904         (cutu_reader::init_tu_and_read_dwo_dies): Update.
7905         (cutu_reader::cutu_reader): Update.
7906         (cutu_reader::keep): Rename from ~cutu_reader.
7907         (process_psymtab_comp_unit, build_type_psymtabs_1)
7908         (process_skeletonless_type_unit, load_partial_comp_unit)
7909         (load_full_comp_unit, dwarf2_read_addr_index)
7910         (read_signatured_type): Update.
7911
7912 2020-02-08  Tom Tromey  <tom@tromey.com>
7913
7914         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
7915         "want_partial_unit" parameter.
7916         (process_psymtab_comp_unit): Change want_partial_unit to bool.
7917         Inline check for DW_TAG_partial_unit.
7918         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
7919
7920 2020-02-08  Tom Tromey  <tom@tromey.com>
7921
7922         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
7923         read.c.
7924         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
7925         read.c.
7926
7927 2020-02-08  Tom Tromey  <tom@tromey.com>
7928
7929         * dwarf2/read.c (read_address): Move to comp-unit.c.
7930         (dwarf2_rnglists_process, dwarf2_ranges_process)
7931         (read_attribute_value, dwarf_decode_lines_1)
7932         (var_decode_location, decode_locdesc): Update.
7933         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
7934         read.c.  Remove "cu" parameter.
7935         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
7936         method.
7937
7938 2020-02-08  Tom Tromey  <tom@tromey.com>
7939
7940         * dwarf2/read.c (read_attribute_value, read_indirect_string)
7941         (read_indirect_line_string): Update.
7942         * dwarf2/comp-unit.c (read_offset): Remove.
7943         (read_comp_unit_head): Update.
7944         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
7945         method.
7946         (read_offset): Don't declare.
7947
7948 2020-02-08  Tom Tromey  <tom@tromey.com>
7949
7950         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
7951         * dwarf2/read.c (struct comp_unit_head): Move to
7952         dwarf2/comp-unit.h.
7953         (enum class rcuh_kind): Move to comp-unit.h.
7954         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
7955         (read_comp_unit_head, error_check_comp_unit_head)
7956         (read_and_check_comp_unit_head): Move to comp-unit.c.
7957         (read_offset, dwarf_unit_type_name): Likewise.
7958         (create_debug_type_hash_table, read_cutu_die_from_dwo)
7959         (cutu_reader::cutu_reader, read_call_site_scope)
7960         (find_partial_die, follow_die_offset): Update.
7961         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
7962
7963 2020-02-08  Tom Tromey  <tom@tromey.com>
7964
7965         * dwarf2/read.c (read_offset_1): Move to leb.c.
7966         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
7967         (dwarf_decode_macro_bytes): Update.
7968         * dwarf2/leb.c (read_offset): Rename; move from read.c.
7969         * dwarf2/leb.h (read_offset): Declare.
7970
7971 2020-02-08  Tom Tromey  <tom@tromey.com>
7972
7973         * dwarf2/read.c (dwarf2_section_size): Remove.
7974         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
7975         Update.
7976         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
7977
7978 2020-02-08  Tom Tromey  <tom@tromey.com>
7979
7980         * dwarf2/read.c (read_initial_length): Move to leb.c.
7981         * dwarf2/leb.h (read_initial_length): Declare.
7982         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
7983         handle_nonstd parameter.
7984         * dwarf2/frame.c (read_initial_length): Remove.
7985         (decode_frame_entry_1): Update.
7986
7987 2020-02-08  Tom Tromey  <tom@tromey.com>
7988
7989         * dwarf2/loc.c (dwarf2_find_location_expression)
7990         (dwarf_evaluate_loc_desc::get_tls_address)
7991         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
7992         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
7993         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
7994         (dwarf2_compile_property_to_c)
7995         (dwarf2_loc_desc_get_symbol_read_needs)
7996         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
7997         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
7998         (loclist_describe_location, loclist_tracepoint_var_ref)
7999         (loclist_generate_c_location): Update.
8000         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
8001         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
8002         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
8003         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
8004         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
8005         (dwarf2_per_cu_data::addr_size)
8006         (dwarf2_per_cu_data::ref_addr_size)
8007         (dwarf2_per_cu_data::text_offset)
8008         (dwarf2_per_cu_data::addr_type): Now methods.
8009         (per_cu_header_read_in): Make per_cu "const".
8010         (dwarf2_version): Remove.
8011         (dwarf2_per_cu_data::int_type): Now a method.
8012         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
8013         (set_die_type, read_array_type, read_subrange_index_type)
8014         (read_tag_string_type, read_subrange_type): Update.
8015         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
8016         offset_size, ref_addr_size, text_offset, addr_type, version,
8017         objfile, int_type, addr_sized_int_type>: Declare methods.
8018
8019 2020-02-08  Tom Tromey  <tom@tromey.com>
8020
8021         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
8022         Move earlier.
8023
8024 2020-02-08  Tom Tromey  <tom@tromey.com>
8025
8026         * dwarf2/read.h (dwarf_line_debug): Declare.
8027         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
8028         * dwarf2/read.c: Move line_header code to new files.
8029         (dwarf_line_debug): No longer static.
8030         * dwarf2/line-header.c: New file.
8031         * dwarf2/line-header.h: New file.
8032
8033 2020-02-08  Tom Tromey  <tom@tromey.com>
8034
8035         * dwarf2/read.c (struct line_header) <file_full_name,
8036         file_file_name>: Return unique_xmalloc_ptr.
8037         (line_header::file_file_name): Update.
8038         (line_header::file_full_name): Update.
8039         (dw2_get_file_names_reader): Update.
8040         (macro_start_file): Update.
8041
8042 2020-02-08  Tom Tromey  <tom@tromey.com>
8043
8044         * dwarf2/read.c (struct line_header) <file_full_name,
8045         file_file_name>: Declare methods.
8046         (dw2_get_file_names_reader): Update.
8047         (file_file_name): Now a method.
8048         (file_full_name): Likewise.
8049         (macro_start_file): Update.
8050
8051 2020-02-08  Tom Tromey  <tom@tromey.com>
8052
8053         * dwarf2/read.c (dwarf_always_disassemble)
8054         (show_dwarf_always_disassemble): Move to loc.c.
8055         (_initialize_dwarf2_read): Move "always-disassemble" registration
8056         to loc.c.
8057         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
8058         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
8059         static.
8060         (show_dwarf_always_disassemble): Move from read.c.
8061         (_initialize_dwarf2loc): Move always-disassemble from read.c.
8062
8063 2020-02-08  Tom Tromey  <tom@tromey.com>
8064
8065         * dwarf2/read.c (~dwarf2_per_objfile): Update.
8066         (create_quick_file_names_table): Return htab_up.
8067         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
8068         Update.
8069         * dwarf2/read.h (struct dwarf2_per_objfile)
8070         <quick_file_names_table>: Now htab_up.
8071
8072 2020-02-08  Tom Tromey  <tom@tromey.com>
8073
8074         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
8075
8076 2020-02-08  Tom Tromey  <tom@tromey.com>
8077
8078         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
8079         Rewrite.
8080         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
8081         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
8082         (abbrev_table::abbrev_table): No longer inline.
8083         (ABBREV_HASH_SIZE): Remove.
8084         (abbrev_table::m_abbrevs): Now an htab_up.
8085
8086 2020-02-08  Tom Tromey  <tom@tromey.com>
8087
8088         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
8089         (cutu_reader): Update.
8090         (build_type_psymtabs_1): Update.
8091         * dwarf2/abbrev.c (abbrev_table::read): Rename.
8092         (abbrev_table::alloc_abbrev): Update.
8093         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
8094         (abbrev_table::read): New static method, renamed from
8095         abbrev_table_read_table.
8096         (abbrev_table::alloc_abbrev)
8097         (abbrev_table::add_abbrev): Now private.
8098         (abbrev_table::abbrev_table): Now private.
8099         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
8100
8101 2020-02-08  Tom Tromey  <tom@tromey.com>
8102
8103         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
8104         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
8105         htab_up.
8106
8107 2020-02-08  Tom Tromey  <tom@tromey.com>
8108
8109         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
8110         htab_up.
8111         (lookup_dwo_unit_in_dwp): Update.
8112         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
8113         on obstack.
8114
8115 2020-02-08  Tom Tromey  <tom@tromey.com>
8116
8117         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
8118         obstack.
8119
8120 2020-02-08  Tom Tromey  <tom@tromey.com>
8121
8122         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
8123         line_header_hash.
8124         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
8125         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
8126         Change type to htab_up.
8127
8128 2020-02-08  Tom Tromey  <tom@tromey.com>
8129
8130         * dwarf2/read.c (allocate_type_unit_groups_table): Return
8131         htab_up.  Don't allocate on obstack.
8132         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
8133         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
8134         Change type to htab_up.
8135
8136 2020-02-08  Tom Tromey  <tom@tromey.com>
8137
8138         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
8139         Change type to htab_up.
8140         * dwarf2/read.c (create_signatured_type_table_from_index)
8141         (create_signatured_type_table_from_debug_names)
8142         (create_all_type_units, add_type_unit)
8143         (lookup_dwo_signatured_type, lookup_signatured_type)
8144         (process_skeletonless_type_unit): Update.
8145         (create_debug_type_hash_table, create_debug_types_hash_table):
8146         Change type of types_htab.
8147         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
8148         htab_up.  Don't allocate on obstack.
8149         (create_cus_hash_table): Change type of cus_htab parameter.
8150         (struct dwo_file) <cus, tus>: Now htab_up.
8151         (lookup_dwo_signatured_type, lookup_dwo_cutu)
8152         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
8153         (queue_and_load_all_dwo_tus): Update.
8154         * dwarf2/index-write.c (write_gdbindex): Update.
8155         (write_debug_names): Update.
8156
8157 2020-02-08  Tom Tromey  <tom@tromey.com>
8158
8159         * dwarf2/read.h (struct dwarf2_queue_item): Move from
8160         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
8161         destructor.
8162         (struct dwarf2_per_objfile) <queue>: New member.
8163         * dwarf2/read.c (struct dwarf2_queue_item): Move to
8164         dwarf2/read.h.
8165         (dwarf2_queue, dwarf2_queue_tail): Remove.
8166         (class dwarf2_queue_guard): Add parameter to constructor.  Use
8167         DISABLE_COPY_AND_ASSIGN.
8168         <m_per_objfile>: New member.
8169         <~dwarf2_queue_guard>: Rewrite.
8170         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
8171         Update.
8172         (~dwarf2_queue_item): New.
8173
8174 2020-02-08  Tom Tromey  <tom@tromey.com>
8175
8176         * dwarf2/read.c (struct die_info) <has_children>: New member.
8177         (dw2_get_file_names_reader): Remove has_children.
8178         (dw2_get_file_names): Update.
8179         (read_cutu_die_from_dwo): Remove has_children.
8180         (cutu_reader::init_tu_and_read_dwo_dies)
8181         (cutu_reader::cutu_reader): Update.
8182         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
8183         Remove has_children.
8184         (build_type_psymtabs_1, process_skeletonless_type_unit)
8185         (load_partial_comp_unit, load_full_comp_unit): Update.
8186         (create_dwo_cu_reader): Remove has_children.
8187         (create_cus_hash_table, read_die_and_children): Update.
8188         (read_full_die_1,read_full_die): Remove has_children.
8189         (read_signatured_type): Update.
8190         (class cutu_reader) <has_children>: Remove.
8191
8192 2020-02-08  Tom Tromey  <tom@tromey.com>
8193
8194         * dwarf2/expr.c: Rename from dwarf2expr.c.
8195         * dwarf2/expr.h: Rename from dwarf2expr.h.
8196         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
8197         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
8198         * dwarf2/frame.c: Rename from dwarf2-frame.c.
8199         * dwarf2/frame.h: Rename from dwarf2-frame.h.
8200         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
8201         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
8202         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
8203         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
8204         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
8205         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
8206         * dwarf2/loc.c: Rename from dwarf2loc.c.
8207         * dwarf2/loc.h: Rename from dwarf2loc.h.
8208         * dwarf2/read.c: Rename from dwarf2read.c.
8209         * dwarf2/read.h: Rename from dwarf2read.h.
8210         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
8211         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
8212         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
8213         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
8214         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
8215         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
8216         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
8217         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
8218         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
8219         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
8220         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
8221         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
8222         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
8223         Update.
8224         * Makefile.in (COMMON_SFILES): Update.
8225         (HFILES_NO_SRCDIR): Update.
8226
8227 2020-02-08  Tom Tromey  <tom@tromey.com>
8228
8229         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
8230         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
8231
8232 2020-02-08  Tom Tromey  <tom@tromey.com>
8233
8234         * dwarf2read.h (struct die_info): Don't declare.
8235
8236 2020-02-08  Tom Tromey  <tom@tromey.com>
8237
8238         * dwarf2read.h (die_info_ptr): Remove typedef.
8239
8240 2020-02-08  Tom Tromey  <tom@tromey.com>
8241
8242         * dwarf2read.c (read_call_site_scope)
8243         (handle_data_member_location, dwarf2_add_member_fn)
8244         (mark_common_block_symbol_computed, read_common_block)
8245         (attr_to_dynamic_prop, partial_die_info::read)
8246         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
8247         (dwarf2_symbol_mark_computed, set_die_type): Update.
8248         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
8249         method.
8250         (attr_form_is_block): Don't declare.
8251         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
8252
8253 2020-02-08  Tom Tromey  <tom@tromey.com>
8254
8255         * dwarf2read.c (dwarf2_find_base_address, )
8256         (read_call_site_scope, rust_containing_type)
8257         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
8258         (handle_data_member_location, dwarf2_add_member_fn)
8259         (get_alignment, read_structure_type, process_structure_scope)
8260         (mark_common_block_symbol_computed, read_common_block)
8261         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
8262         (partial_die_info::read, read_attribute_value, new_symbol)
8263         (lookup_die_type, dwarf2_get_ref_die_offset)
8264         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
8265         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
8266         (dwarf2_symbol_mark_computed): Update.
8267         * dwarf2/attribute.h (struct attribute) <value_as_address,
8268         form_is_section_offset, form_is_constant, form_is_ref>: Declare
8269         methods.
8270         (value_as_address, attr_form_is_section_offset)
8271         (attr_form_is_constant, attr_form_is_ref): Don't declare.
8272         * dwarf2/attribute.c (attribute::value_as_address)
8273         (attribute::form_is_section_offset, attribute::form_is_constant)
8274         (attribute::form_is_ref): Now methods.
8275
8276 2020-02-08  Tom Tromey  <tom@tromey.com>
8277
8278         * dwarf2read.c (struct attribute, DW_STRING)
8279         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
8280         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
8281         (attr_form_is_block, attr_form_is_section_offset)
8282         (attr_form_is_constant, attr_form_is_ref): Move.
8283         * dwarf2/attribute.h: New file.
8284         * dwarf2/attribute.c: New file, from dwarf2read.c.
8285         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
8286
8287 2020-02-08  Tom Tromey  <tom@tromey.com>
8288
8289         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
8290         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
8291         Move.
8292         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
8293         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
8294         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
8295         abbrev.c.
8296         * dwarf2/abbrev.h: New file.
8297         * dwarf2/abbrev.c: New file, from dwarf2read.c.
8298         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
8299
8300 2020-02-08  Tom Tromey  <tom@tromey.com>
8301
8302         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
8303         (dwarf2_section_size, dwarf2_get_section_info)
8304         (create_signatured_type_table_from_debug_names)
8305         (create_addrmap_from_aranges, read_debug_names_from_section)
8306         (get_gdb_index_contents_from_section, read_comp_unit_head)
8307         (error_check_comp_unit_head, read_abbrev_offset)
8308         (create_debug_type_hash_table, init_cu_die_reader)
8309         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
8310         (read_comp_units_from_section, create_cus_hash_table)
8311         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
8312         (create_dwp_v2_section, dwarf2_rnglists_process)
8313         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
8314         (abbrev_table_read_table, read_indirect_string_at_offset_from)
8315         (read_indirect_string_from_dwz, read_addr_index_1)
8316         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
8317         (dwarf_decode_macro_bytes, dwarf_decode_macros)
8318         (fill_in_loclist_baton): Update.
8319         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
8320         get_containing_section, get_bfd_owner, get_bfd_section,
8321         get_file_name, get_id, get_flags, empty, read>: Declare methods.
8322         (dwarf2_read_section, get_section_name, get_section_file_name)
8323         (get_containing_section, get_section_bfd_owner)
8324         (get_section_bfd_section, get_section_name, get_section_file_name)
8325         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
8326         declare.
8327         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
8328         (dwarf2_section_info::get_bfd_owner)
8329         (dwarf2_section_info::get_bfd_section)
8330         (dwarf2_section_info::get_name)
8331         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
8332         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
8333         (dwarf2_section_info::read): Now methods.
8334         * dwarf-index-write.c (class debug_names): Update.
8335
8336 2020-02-08  Tom Tromey  <tom@tromey.com>
8337
8338         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
8339         Move to dwarf2/section.h.
8340         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
8341         (get_section_bfd_section, get_section_name)
8342         (get_section_file_name, get_section_id, get_section_flags)
8343         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
8344         dwarf2/section.c.
8345         * dwarf2/section.h: New file.
8346         * dwarf2/section.c: New file, from dwarf2read.c.
8347         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
8348
8349 2020-02-08  Tom Tromey  <tom@tromey.com>
8350
8351         * dwarf2read.h (read_unsigned_leb128): Don't declare.
8352         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
8353         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
8354         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
8355         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
8356         * dwarf2/leb.h: New file, from dwarf2read.c.
8357         * dwarf2/leb.c: New file, from dwarf2read.c.
8358         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
8359         Remove.
8360         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
8361         (COMMON_SFILES): Add dwarf2/leb.c.
8362
8363 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
8364
8365         GDB 9.1 released.
8366
8367 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
8368
8369         PR gdb/25190:
8370         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
8371         * gdb/remote.c (remote_console_output): Update.
8372         * gdb/ui-file.c (fputs_unfiltered): Rename to...
8373         (ui_file_puts): ...this.
8374         * gdb/ui-file.h (ui_file_puts): Add declaration.
8375         * gdb/utils.c (emit_style_escape): Update.
8376         (flush_wrap_buffer): Update.
8377         (fputs_maybe_filtered): Update.
8378         (fputs_unfiltered): Add function.
8379
8380 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
8381
8382         * gdb/event-loop.c (gdb_wait_for_event): Update.
8383         * gdb/printcmd.c (printf_command): Update.
8384         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
8385         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
8386         (gdb_os_flush_stderr): Update.
8387         * gdb/remote.c (remote_console_output): Update.
8388         * gdb/ui-file.c (gdb_flush): Rename to...
8389         (ui_file_flush): ...this.
8390         (stderr_file::write): Update.
8391         (stderr_file::puts): Update.
8392         * gdb/ui-file.h (gdb_flush): Rename to...
8393         (ui_file_flush): ...this.
8394         * gdb/utils.c (gdb_flush): Add function.
8395         * gdb/utils.h (gdb_flush): Add declaration.
8396
8397 2020-02-07  Tom Tromey  <tromey@adacore.com>
8398
8399         PR breakpoints/24915:
8400         * source.c (find_and_open_source): Do not check basenames_may_differ.
8401
8402 2020-02-07  Tom Tromey  <tom@tromey.com>
8403
8404         * README: Update gdbserver documentation.
8405         * gdbserver: Move to top level.
8406         * configure.tgt (build_gdbserver): Remove.
8407         * configure.ac: Remove --enable-gdbserver.
8408         * configure: Rebuild.
8409         * Makefile.in (distclean): Don't mention gdbserver.
8410
8411 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
8412
8413         * source-cache.c (source_cache::ensure): Surround
8414         get_plain_source_lines with a try/catch.
8415         (source_cache::get_line_charpos): Get rid of try/catch
8416         and only check for the return value of "ensure".
8417         * tui/tui-source.c (tui_source_window::set_contents):
8418         Simplify "nlines" calculation.
8419
8420 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
8421
8422         * MAINTAINERS (Write After Approval): Add myself.
8423
8424 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
8425
8426         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
8427         function call.
8428
8429 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
8430
8431         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
8432
8433 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
8434
8435         * nat/riscv-linux-tdesc.h: New file.
8436         * nat/riscv-linux-tdesc.c: New file, taking code from...
8437         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
8438         ... here.
8439         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
8440         NATDEPFILES.
8441
8442 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
8443
8444         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
8445         we don't set the fake simulator ptid to the null_ptid.
8446
8447 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
8448
8449         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
8450         * gdbthread.h (class thread_info) <resumed>: Likewise.
8451         * infrun.c (resume_1): Likewise.
8452         (proceed): Likewise.
8453         (infrun_thread_stop_requested): Likewise.
8454         (stop_all_threads): Likewise.
8455         (handle_inferior_event): Likewise.
8456         (restart_threads): Likewise.
8457         (finish_step_over): Likewise.
8458         (keep_going_stepped_thread): Likewise.
8459         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
8460         (linux_handle_extended_wait): Likewise.
8461         * record-btrace.c (get_thread_current_frame_id): Likewise.
8462         * record-full.c (record_full_wait_1): Likewise.
8463         * remote.c (remote_target::process_initial_stop_replies): Likewise.
8464         * target.c (target_resume): Likewise.
8465         * thread.c (set_running_thread): Likewise.
8466
8467 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
8468
8469         * f-valprint.c (f77_print_array_1): Changed datatype of index
8470         variable to LONGEST from int to enable it to contain bound
8471         values correctly.
8472
8473 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
8474
8475         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
8476         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
8477         offsets according to FLEN determined.
8478         (riscv_linux_nat_target::read_description): Determine FLEN
8479         dynamically.
8480         (riscv_linux_nat_target::fetch_registers): Size regset buffer
8481         according to FLEN determined.
8482         (riscv_linux_nat_target::store_registers): Likewise.
8483
8484 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
8485
8486         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
8487         when reg->group is empty and reggroup is not.
8488
8489 2020-01-31  Tom Tromey  <tromey@adacore.com>
8490
8491         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
8492         Call beneath target's mourn_inferior after unpushing.
8493
8494 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
8495
8496         PR tui/9765
8497         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
8498         have enough lines to fill the screen, still return the lowest
8499         address we found.
8500
8501 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
8502
8503         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
8504         '-', '<', and '>' commands.
8505
8506 2020-01-29  Pedro Alves  <palves@redhat.com>
8507             Sergio Durigan Junior  <sergiodj@redhat.com>
8508
8509         * infcmd.c (construct_inferior_arguments): Assert that
8510         'argc' is greater than 0.
8511
8512 2020-01-29  Luis Machado  <luis.machado@linaro.org>
8513
8514         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
8515         (BRK_INSN_MASK): Define to 0xd4200000.
8516         (aarch64_program_breakpoint_here_p): New function.
8517         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
8518         * arch-utils.c (default_program_breakpoint_here_p): Moved from
8519         breakpoint.c.
8520         * arch-utils.h (default_program_breakpoint_here_p): Moved from
8521         breakpoint.h
8522         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
8523         call gdbarch_program_breakpoint_here_p.
8524         (program_breakpoint_here): Moved to arch-utils.c, renamed to
8525         default_program_breakpoint_here_p, changed return type to bool and
8526         simplified.
8527         * breakpoint.h (program_breakpoint_here): Moved prototype to
8528         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
8529         return type to bool.
8530         * gdbarch.c: Regenerate.
8531         * gdbarch.h: Regenerate.
8532         * gdbarch.sh (program_breakpoint_here_p): New method.
8533         * infrun.c (handle_signal_stop): Call
8534         gdbarch_program_breakpoint_here_p.
8535
8536 2020-01-26  Tom Tromey  <tom@tromey.com>
8537
8538         * ctfread.c (struct ctf_fp_info): Reindent.
8539         (_initialize_ctfread): Remove.
8540
8541 2020-01-26  Tom Tromey  <tom@tromey.com>
8542
8543         * psymtab.c (partial_map_expand_apply)
8544         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
8545         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
8546         (psym_print_stats, psym_expand_symtabs_for_function)
8547         (psym_map_symbol_filenames, psym_map_matching_symbols)
8548         (psym_expand_symtabs_matching)
8549         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
8550         (maintenance_check_psymtabs): Use new methods.
8551         * psympriv.h (struct partial_symtab) <readin_p,
8552         get_compunit_symtab>: New methods.
8553         <readin, compunit_symtab>: Remove members.
8554         (struct standard_psymtab): New.
8555         (struct legacy_psymtab): Derive from standard_psymtab.
8556         * dwarf2read.h (struct dwarf2_psymtab): Derive from
8557         standard_psymtab.
8558         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
8559
8560 2020-01-26  Tom Tromey  <tom@tromey.com>
8561
8562         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
8563         read_dependencies.  Add assert.
8564         * psymtab.c (partial_symtab::read_dependencies): New method.
8565         * psympriv.h (struct partial_symtab) <read_dependencies>: New
8566         method.
8567         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
8568         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
8569         read_dependencies.
8570         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
8571         Add assert.
8572
8573 2020-01-26  Tom Tromey  <tom@tromey.com>
8574
8575         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
8576         Call expand_psymtab.
8577         (xcoff_read_symtab): Call expand_psymtab.
8578         (xcoff_start_psymtab, xcoff_end_psymtab): Set
8579         legacy_expand_psymtab.
8580         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
8581         method.
8582         (struct legacy_psymtab) <expand_psymtab>: Implement.
8583         <legacy_expand_psymtab>: New member.
8584         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
8585         (parse_partial_symbols): Set legacy_expand_psymtab.
8586         (psymtab_to_symtab_1): Change argument order.  Call
8587         expand_psymtab.
8588         (new_psymtab): Set legacy_expand_psymtab.
8589         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
8590         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
8591         expand_psymtab.
8592         (dwarf2_psymtab::expand_psymtab): Rename from
8593         psymtab_to_symtab_1.  Call expand_psymtab.
8594         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
8595         (dbx_end_psymtab): Likewise.
8596         (dbx_psymtab_to_symtab_1): Change argument order. Call
8597         expand_psymtab.
8598         (dbx_read_symtab): Call expand_psymtab.
8599         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
8600         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
8601         (ctf_psymtab::read_symtab): Call expand_psymtab.
8602
8603 2020-01-26  Tom Tromey  <tom@tromey.com>
8604
8605         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
8606         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
8607         messages.
8608         * mdebugread.c (mdebug_read_symtab): Remove prints.
8609         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
8610         assert.
8611         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
8612
8613 2020-01-26  Tom Tromey  <tom@tromey.com>
8614
8615         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
8616         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
8617         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
8618         legacy_symtab.
8619         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
8620         * psymtab.c (psymtab_to_symtab): Call method.
8621         (dump_psymtab): Update.
8622         * psympriv.h (struct partial_symtab): Add virtual destructor.
8623         <read_symtab>: New method.
8624         (struct legacy_symtab): New.
8625         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
8626         (struct pst_map) <pst>: Now a legacy_psymtab.
8627         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
8628         (new_psymtab): Use legacy_psymtab.
8629         * dwarf2read.h (struct dwarf2_psymtab): New.
8630         (struct dwarf2_per_cu_data) <psymtab>: Use it.
8631         * dwarf2read.c (dwarf2_create_include_psymtab)
8632         (dwarf2_build_include_psymtabs, create_type_unit_group)
8633         (create_partial_symtab, process_psymtab_comp_unit_reader)
8634         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
8635         (set_partial_user): Use dwarf2_psymtab.
8636         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
8637         (psymtab_to_symtab_1, process_full_comp_unit)
8638         (process_full_type_unit, dwarf2_ranges_read)
8639         (dwarf2_get_pc_bounds, psymtab_include_file_name)
8640         (dwarf_decode_lines): Use dwarf2_psymtab.
8641         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
8642         (add_address_entry_worker, write_one_signatured_type)
8643         (recursively_count_psymbols, recursively_write_psymbols)
8644         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
8645         (write_debug_names): Likewise.
8646         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
8647         <pst>: Now a legacy_psymtab.
8648         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
8649         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
8650         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
8651         * ctfread.c (struct ctf_psymtab): New.
8652         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
8653         ctf_psymtab.
8654         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
8655         (create_partial_symtab): Return a ctf_psymtab.
8656         (scan_partial_symbols): Update.
8657
8658 2020-01-26  Tom Tromey  <tom@tromey.com>
8659
8660         * xcoffread.c (xcoff_start_psymtab): Use new.
8661         * psymtab.c (partial_symtab::partial_symtab): New constructor,
8662         renamed from start_psymtab_common.
8663         * psympriv.h (struct partial_symtab): Add new constructor.
8664         (start_psymtab_common): Don't declare.
8665         * mdebugread.c (parse_partial_symbols): Use new.
8666         * dwarf2read.c (create_partial_symtab): Use new.
8667         * dbxread.c (start_psymtab): Use new.
8668         * ctfread.c (create_partial_symtab): Use new.
8669
8670 2020-01-26  Tom Tromey  <tom@tromey.com>
8671
8672         * xcoffread.c (xcoff_end_psymtab): Use new.
8673         * psymtab.c (start_psymtab_common): Use new.
8674         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
8675         Update.
8676         * psympriv.h (struct partial_symtab): Add parameters to
8677         constructor.  Don't inline.
8678         (allocate_psymtab): Don't declare.
8679         * mdebugread.c (new_psymtab): Use new.
8680         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
8681         * dbxread.c (dbx_end_psymtab): Use new.
8682
8683 2020-01-26  Tom Tromey  <tom@tromey.com>
8684
8685         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
8686         allocate_psymtab.  Update documentation.
8687         * psymtab.c (psymtab_storage::install_psymtab): Rename from
8688         allocate_psymtab.  Do not use new.
8689         (allocate_psymtab): Use new.  Update.
8690
8691 2020-01-26  Tom Tromey  <tom@tromey.com>
8692
8693         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
8694         * psymtab.c (psym_print_stats): Update.
8695         * psympriv.h (struct partial_symtab) <readin,
8696         psymtabs_addrmap_supported, anonymous>: Now bool.
8697         * mdebugread.c (psymtab_to_symtab_1): Update.
8698         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
8699         (build_type_psymtabs_reader, psymtab_to_symtab_1)
8700         (process_full_comp_unit, process_full_type_unit): Update.
8701         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
8702         * ctfread.c (psymtab_to_symtab): Update.
8703
8704 2020-01-26  Tom Tromey  <tom@tromey.com>
8705
8706         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
8707         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
8708         * psymtab.c (psymtab_storage): Delete psymtabs.
8709         (psymtab_storage::allocate_psymtab): Use new.
8710         (psymtab_storage::discard_psymtab): Use delete.
8711         * psympriv.h (struct partial_symtab): Add constructor and
8712         initializers.
8713
8714 2020-01-26  Tom Tromey  <tom@tromey.com>
8715
8716         * machoread.c: Do not include psympriv.h.
8717
8718 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8719
8720         * NEWS: Mention the new option and the set/show commands.
8721
8722 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8723
8724         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
8725         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
8726         (validate_exec_file): New variables, enums, functions.
8727         (exec_file_locate_attach, print_section_info): Style the filenames.
8728         (_initialize_exec): Install show_exec_file_mismatch_command and
8729          set_exec_file_mismatch_command.
8730         * gdbcore.h (validate_exec_file): Declare.
8731         * infcmd.c (attach_command): Call validate_exec_file.
8732         * remote.c ( remote_target::remote_add_inferior): Likewise.
8733
8734 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8735
8736         * frame.c (find_frame_sal): Move call to get_next_frame into more
8737         inner scope.
8738         * inline-frame.c (inilne_state) <inline_state>: Update argument
8739         types.
8740         (inilne_state) <skipped_symbol>: Rename to...
8741         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
8742         (skip_inline_frames): Build vector of skipped symbols and use this
8743         to reate the inline_state.
8744         (inline_skipped_symbol): Add a comment and some assertions, fetch
8745         skipped symbol from the list.
8746
8747 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8748
8749         * buildsym.c (lte_is_less_than): Delete.
8750         (buildsym_compunit::end_symtab_with_blockvector): Create local
8751         lambda function to sort line table entries, and use
8752         std::stable_sort instead of std::sort.
8753         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
8754         markers when looking for a previous line.
8755
8756 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8757
8758         * dwarf2read.c (lnp_state_machine::record_line): Include
8759         end_sequence parameter in debug print out.  Record the line if we
8760         are at an end_sequence marker even if it's not the start of a
8761         statement.
8762         * symmisc.c (maintenance_print_one_line_table): Print end of
8763         sequence markers with 'END' not '0'.
8764
8765 2020-01-24  Pedro Alves  <palves@redhat.com>
8766
8767         PR gdb/25410
8768         * thread.c (scoped_restore_current_thread::restore): Use
8769         switch_to_inferior_no_thread.
8770         * exec.c: Include "progspace-and-thread.h".
8771         (add_target_sections, remove_target_sections):
8772         scoped_restore_current_pspace_and_thread instead of
8773         scoped_restore_current_thread.
8774         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
8775         and aspace to the inferior before calling clone_program_space.
8776         Remove stale comment.
8777
8778 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8779
8780         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
8781         (arm_netbsd_nat_target::fetch_registers): ...this.
8782         (arm_nbsd_nat_target::store_registers): Rename to...
8783         (arm_netbsd_nat_target::store_registers): ...this.
8784
8785 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8786
8787         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
8788         register_t.
8789
8790 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8791
8792         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
8793         Update comment.
8794         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
8795         Likewise.
8796         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
8797         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
8798         the correct replacement (iterate_over_regset_sections).
8799         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
8800         Update comment.
8801
8802 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
8803
8804         PR gdb/23718
8805         * gdb/python/python.c (execute_gdb_command): Call
8806         async_enable_stdin in catch block.
8807
8808 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8809
8810         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
8811         SWITCH_THRU_ALL_UIS.
8812
8813 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8814
8815         PR tui/9765
8816         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
8817         comment, add extra parameter, and update to store previous symbol
8818         when appropriate.
8819         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
8820         add extra parameter.
8821         * tui/tui-disasm.c (tui_disassemble): Update header comment,
8822         remove unneeded parameter, add try/catch around gdb_print_insn,
8823         rewrite to add items to asm_lines vector.
8824         (tui_find_backward_disassembly_start_address): New function.
8825         (tui_find_disassembly_address): Updated throughout.
8826         (tui_disasm_window::set_contents): Update for changes to
8827         tui_disassemble.
8828         (tui_disasm_window::do_scroll_vertical): No need to adjust the
8829         number of lines to scroll.
8830
8831 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
8832
8833         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
8834         (SECT_OFF_DATA): Likewise.
8835         (SECT_OFF_RODATA): Likewise.
8836         (SECT_OFF_TEXT): Likewise.
8837         (SECT_OFF_BSS): Likewise.
8838         (struct objfile) <text_section_offset, data_section_offset>: New
8839         methods.
8840         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
8841         objfile::text_section_offset.
8842         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
8843         * coffread.c (coff_symtab_read): Likewise.
8844         (enter_linenos): Likewise.
8845         (process_coff_symbol): Likewise.
8846         * ctfread.c (get_objfile_text_range): Likewise.
8847         * dtrace-probe.c (dtrace_probe::get_relocated_address):
8848         Use objfile::data_section_offset.
8849         * dwarf2-frame.c (execute_cfa_program): Use
8850         objfile::text_section_offset.
8851         (dwarf2_frame_find_fde): Likewise.
8852         * dwarf2read.c (create_addrmap_from_index): Likewise.
8853         (create_addrmap_from_aranges): Likewise.
8854         (dw2_find_pc_sect_compunit_symtab): Likewise.
8855         (process_psymtab_comp_unit_reader): Likewise.
8856         (add_partial_symbol): Likewise.
8857         (add_partial_subprogram): Likewise.
8858         (process_full_comp_unit): Likewise.
8859         (read_file_scope): Likewise.
8860         (read_func_scope): Likewise.
8861         (read_lexical_block_scope): Likewise.
8862         (read_call_site_scope): Likewise.
8863         (dwarf2_rnglists_process): Likewise.
8864         (dwarf2_ranges_process): Likewise.
8865         (dwarf2_ranges_read): Likewise.
8866         (dwarf_decode_lines_1): Likewise.
8867         (new_symbol): Likewise.
8868         (dwarf2_fetch_die_loc_sect_off): Likewise.
8869         (dwarf2_per_cu_text_offset): Likewise.
8870         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
8871         * hppa-tdep.c (read_unwind_info): Likewise.
8872         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
8873         * psympriv.h (struct partial_symtab): Likewise.
8874         * psymtab.c (find_pc_sect_psymtab): Likewise.
8875         * solib-svr4.c (enable_break): Likewise.
8876         * stap-probe.c (relocate_address): Use
8877         objfile::data_section_offset.
8878         * xcoffread.c (enter_line_range): Use
8879         objfile::text_section_offset.
8880         (read_xcoff_symtab): Likewise.
8881
8882 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8883
8884         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
8885         declaration to narrower scopes.
8886
8887 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8888
8889         * darwin-nat.h (struct darwin_exception_msg, enum
8890         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
8891         Move up.
8892         (class darwin_nat_target) <wait_1, check_new_threads,
8893         decode_exception_message, decode_message, stop_inferior,
8894         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
8895         * darwin-nat.c (darwin_check_new_threads): Rename to...
8896         (darwin_nat_target::check_new_threads): ... this.
8897         (darwin_suspend_inferior_it): Remove.
8898         (darwin_decode_exception_message): Rename to...
8899         (darwin_nat_target::decode_exception_message): ... this.
8900         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
8901         (darwin_decode_message): Rename to...
8902         (darwin_nat_target::decode_message): ... this.
8903         (cancel_breakpoint): Rename to...
8904         (darwin_nat_target::cancel_breakpoint): ... this.
8905         (darwin_wait): Rename to...
8906         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
8907         instead of iterate_over_inferiors.
8908         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
8909         (darwin_stop_inferior): Rename to...
8910         (darwin_nat_target::stop_inferior): ... this.
8911         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
8912         (darwin_init_thread_list): Rename to...
8913         (darwin_nat_target::init_thread_list): ... this.
8914         (darwin_ptrace_him): Rename to...
8915         (darwin_nat_target::ptrace_him): ... this.
8916         (darwin_nat_target::create_inferior): Pass lambda function to
8917         fork_inferior.
8918         (darwin_nat_target::detach): Call stop_inferior instead of
8919         darwin_stop_inferior.
8920         * fork-inferior.h (fork_inferior): Change init_trace_fun
8921         parameter to gdb::function_view.
8922         * fork-inferior.c (fork_inferior): Likewise.
8923
8924 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
8925
8926         * i386-cygwin-tdep.c (core_process_module_section): Update.
8927         * windows-nat.c (struct lm_info_windows): Add text_offset.
8928         (windows_xfer_shared_libraries): Update.
8929         * windows-tdep.c (windows_xfer_shared_library):
8930         Add text_offset_cached argument.
8931         * windows-tdep.h (windows_xfer_shared_library): Update.
8932
8933 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8934
8935         * gdbarch.sh: Add declaration for _initialize_gdbarch.
8936
8937 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8938
8939         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
8940         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
8941         replace with range-based for.
8942         (gdbsim_interrupt_inferior): Remove.
8943         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
8944         with a range-based for.  Inline code from
8945         gdbsim_interrupt_inferior.
8946
8947 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8948
8949         * infrun.c (proceed): Fix indentation.
8950
8951 2020-01-21  Tom Tromey  <tromey@adacore.com>
8952
8953         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
8954         * python/python.c (python_extension_ops): Update.
8955         (gdbpy_colorize): New function.
8956         * python/lib/gdb/__init__.py (colorize): New function.
8957         * extension.h (ext_lang_colorize): Declare.
8958         * extension.c (ext_lang_colorize): New function.
8959         * extension-priv.h (struct extension_language_ops) <colorize>: New
8960         member.
8961         * cli/cli-style.c (_initialize_cli_style): Update help text.
8962
8963 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8964
8965         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
8966         <cond>: Change type to bool.
8967         (aarch64_displaced_step_b_cond): Update cond to use bool type.
8968         (aarch64_displaced_step_cb): Likewise.
8969         (aarch64_displaced_step_tb): Likewise.
8970
8971 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8972
8973         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
8974         output.
8975
8976 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8977
8978         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
8979         <pc_adjust>: Adjust the documentation.
8980         (aarch64_displaced_step_fixup): Check if PC really moved before
8981         adjusting it.
8982
8983 2020-01-19  Tom Tromey  <tom@tromey.com>
8984
8985         * disasm.c (~gdb_disassembler): New destructor.
8986         (gdb_buffered_insn_length): Call disassemble_free_target.
8987         * disasm.h (class gdb_disassembler): Declare destructor.  Use
8988         DISABLE_COPY_AND_ASSIGN.
8989
8990 2020-01-19  Tom Tromey  <tom@tromey.com>
8991
8992         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
8993         (die_reader_func_ftype): Remove.
8994         (cutu_reader): New class.
8995         (dw2_get_file_names_reader): Remove "data" parameter.
8996         (dw2_get_file_names): Use cutu_reader.
8997         (create_debug_type_hash_table): Update.
8998         (read_cutu_die_from_dwo): Update comment.
8999         (lookup_dwo_unit): Add dwo_name parameter.
9000         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
9001         die_reader_func_ftype and data parameters.
9002         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
9003         Remove die_reader_func_ftype and data parameters.
9004         (~cutu_reader): New; from init_cutu_and_read_dies.
9005         (cutu_reader::cutu_reader): Rename from
9006         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
9007         and data parameters.
9008         (init_cutu_and_read_dies_simple): Remove.
9009         (struct process_psymtab_comp_unit_data): Remove.
9010         (process_psymtab_comp_unit_reader): Remove data parameter; add
9011         want_partial_unit and pretend_language parameters.
9012         (process_psymtab_comp_unit): Use cutu_reader.
9013         (build_type_psymtabs_reader): Remove data parameter.
9014         (build_type_psymtabs_1): Use cutu_reader.
9015         (process_skeletonless_type_unit): Likewise.
9016         (load_partial_comp_unit_reader): Remove.
9017         (load_partial_comp_unit): Use cutu_reader.
9018         (load_full_comp_unit_reader): Remove.
9019         (load_full_comp_unit): Use cutu_reader.
9020         (struct create_dwo_cu_data): Remove.
9021         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
9022         dwo_unit parameters.
9023         (create_cus_hash_table): Use cutu_reader.
9024         (struct dwarf2_read_addr_index_data): Remove.
9025         (dwarf2_read_addr_index_reader): Remove.
9026         (dwarf2_read_addr_index): Use cutu_reader.
9027         (read_signatured_type_reader): Remove.
9028         (read_signatured_type): Use cutu_reader.
9029
9030 2020-01-19  Tom Tromey  <tom@tromey.com>
9031
9032         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
9033         * tui/tui-wingeneral.h (class tui_suppress_output): New.
9034         (tui_wrefresh): Declare.
9035         * tui/tui-wingeneral.c (suppress_output): New global.
9036         (tui_suppress_output, ~tui_suppress_output): New constructor and
9037         destructor.
9038         (tui_wrefresh): New function.
9039         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
9040         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
9041         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
9042         method.
9043         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
9044         tui_wrefresh.
9045         (tui_data_window::no_refresh): New method.
9046         (tui_data_item_window::refresh_window): Call tui_wrefresh.
9047         (tui_reg_command): Use tui_suppress_output
9048         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
9049         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
9050         method.
9051         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
9052
9053 2020-01-19  Tom Tromey  <tom@tromey.com>
9054
9055         * tui/tui-winsource.c (tui_update_source_windows_with_line):
9056         Handle case where symtab is null.
9057
9058 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
9059
9060         * linux-fork.c (one_fork_p): Simplify.
9061
9062 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9063
9064         * top.c (struct qt_args): Remove.
9065         (kill_or_detach): Change return type to void, replace `void *`
9066         parameter with a proper one.
9067         (print_inferior_quit_action):  Likewise.
9068         (quit_confirm): Use range-based for loop to iterate over inferiors.
9069         (quit_force): Likewise.
9070
9071 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9072
9073         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
9074         `void *` parameter with proper parameters.
9075         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
9076         (print_one_inferior): Change return type to void, replace `void *`
9077         parameter with proper parameters.
9078         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
9079         inferiors.
9080         (get_other_inferior): Remove.
9081         (mi_cmd_remove_inferior): Use range-based loop to iterate over
9082         inferiors.
9083
9084 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9085
9086         * mi/mi-interp.c (report_initial_inferior): Remove.
9087         (mi_interp::init): Use range-based for to iterate over inferiors.
9088
9089 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9090
9091         * python/py-inferior.c (build_inferior_list): Remove.
9092         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
9093
9094 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
9095
9096         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
9097         (btrace_stitch_trace): Likewise.
9098         * charset.c (intermediate_encoding): Likewise (vaild).
9099         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
9100         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
9101         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
9102
9103 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
9104
9105         * windows-tdep.c (windows_get_tlb_type):
9106         Add rtl_user_process_parameters type.
9107
9108 2020-01-16  Pedro Alves  <palves@redhat.com>
9109             Norbert Lange  <nolange79@gmail.com>
9110
9111         PR build/24805
9112         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
9113         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
9114         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
9115         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
9116         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
9117         (ps_plog): Redeclare exported functions with default visibility.
9118
9119 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
9120
9121         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
9122         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
9123
9124 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
9125
9126         * infcmd.c (post_create_inferior): Use get_thread_regcache
9127         instead of get_current_regcache.
9128
9129 2020-01-14  Tom Tromey  <tom@tromey.com>
9130
9131         PR symtab/12535:
9132         * python/python.c (gdbpy_decode_line): Treat empty string the same
9133         as no argument.
9134
9135 2020-01-14  Tom Tromey  <tom@tromey.com>
9136
9137         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
9138
9139 2020-01-14  Tom Tromey  <tom@tromey.com>
9140
9141         * nat/linux-btrace.c: Don't include <config.h>.
9142         * nat/linux-ptrace.c: Don't include <config.h>.
9143         * nat/x86-linux-dregs.c: Don't include <config.h>.
9144
9145 2020-01-14  Tom Tromey  <tom@tromey.com>
9146
9147         * configure: Rebuild.
9148         * configure.ac: Move many checks to ../gdbsupport/common.m4.
9149
9150 2020-01-14  Tom Tromey  <tom@tromey.com>
9151
9152         * nat/x86-linux-dregs.c: Include configh.h.
9153         * nat/linux-ptrace.c: Include configh.h.
9154         * nat/linux-btrace.c: Include configh.h.
9155         * defs.h: Include config.h, bfd.h.
9156         * configure.ac: Don't source common.host.
9157         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
9158         * configure: Rebuild.
9159         * acinclude.m4: Update path.
9160         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
9161         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
9162         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
9163         (CLIBS): Add LIBSUPPORT.
9164         (CDEPS): Likewise.
9165         (COMMON_SFILES): Remove gdbsupport files.
9166         (HFILES_NO_SRCDIR): Likewise.
9167         (stamp-version): Update path to create-version.sh.
9168         (ALLDEPFILES): Remove gdbsupport files.
9169
9170 2020-01-14  Tom Tromey  <tom@tromey.com>
9171
9172         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
9173         USE_WIN32API when needed.
9174         * configure.ac (USE_WIN32API): Don't define.
9175         (WIN32LIBS): Use WIN32APILIBS.
9176         * configure: Rebuild.
9177
9178 2020-01-14  Tom Tromey  <tom@tromey.com>
9179
9180         * configure: Rebuild.
9181         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
9182
9183 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
9184
9185         * skip.c (skip_function_command): Make skip w/o arguments use the
9186         name of the inlined function if pc is inside any inlined function.
9187
9188 2020-01-14  Luis Machado  <luis.machado@linaro.org>
9189
9190         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
9191         * infrun.c (resume_1): Likewise.
9192         (handle_inferior_event): Remove stale comment.
9193         * linux-nat.c (linux_nat_target::resume): Update comments.
9194         (save_stop_reason): Likewise.
9195         (linux_nat_filter_event): Likewise.
9196         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
9197
9198 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9199
9200         * elfread.c (record_minimal_symbol): Set section index to 0 for
9201         non-allocatable sections.
9202
9203
9204 2020-01-13  Ali Tamur <tamur@google.com>
9205
9206         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
9207         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
9208         to gdb::optional.  Update comments.
9209         (dwo_file): Update comments.
9210         (read_attribute): Update API to take an additional out parameter,
9211         need_reprocess.  This is used to mark attributes that need other
9212         attributes (e.g. str_offsets_base) for correct computation which may not
9213         have been read yet.
9214         (read_attribute_reprocess): New function declaration.
9215         (read_addr_index): Likewise.
9216         (read_dwo_str_index): Likewise.
9217         (read_stub_str_index): Likewise.
9218         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
9219         (lookup_addr_base): New function definition.
9220         (lookup_ranges_base): Likewise.
9221         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
9222         lookup_ranges_base.
9223         (init_cutu_and_read_dies): Update comments.
9224         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
9225         unit.  This is used to inherit parent's str_offsets_base and addr_base.
9226         Update comments.
9227         (init_cutu_and_read_dies_simple): Reflect API changes.
9228         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
9229         (create_cus_hash_table): Change API to take parent compile unit.
9230         Reflect API changes.
9231         (open_and_init_dwo_file): Reflect API changes.
9232         (dwarf2_get_pc_bounds): Update comments.
9233         (dwarf2_record_block_ranges): Likewise.
9234         (read_full_die_1): Change implementation to reprocess attributes that
9235         need str_offsets_base and addr_base.
9236         (partial_die_info::read): Likewise.
9237         (read_attribute_reprocess): New function definition.
9238         (read_attribute_value): Change API to take an additional out parameter,
9239         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
9240         when a non-dwo compile unit has index based attributes.
9241         (read_attribute): Reflect API changes.
9242         (read_addr_index_1): Reflect API changes.  Update comments.
9243         (dwarf2_read_addr_index_data): Reflect API changes.
9244         (dwarf2_read_addr_index): Likewise.
9245         (read_str_index): Change API and implementation.  This becomes a helper
9246         to be used by the new string index related methods.  Update error
9247         message and comments.
9248         (read_dwo_str_index): New function definition.
9249         (read_stub_str_index): Likewise.
9250         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
9251         * symfile.h (dwarf2_debug_sections): Likewise.
9252         * xcoffread.c (dwarf2_debug_sections): Likewise.
9253
9254 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9255
9256         * gdbcore.h (struct core_fns) <core_read_registers>: Change
9257         core_reg_sect type to gdb_byte *.
9258         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
9259         * cris-tdep.c (fetch_core_registers): Likewise.
9260         * corelow.c (core_target::get_core_register_section): Change
9261         type of `contents` to gdb::byte_vector.
9262
9263 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9264
9265         * tui/tui-wingeneral.c (box_win): Position the title in the center
9266         of the border.
9267
9268 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9269
9270         * corelow.c (core_target::get_core_register_section): Use
9271           std::vector instead of alloca.
9272
9273 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9274
9275         * warning.m4: Add -Wmissing-declarations to build_warnings.
9276         * configure: Re-generate.
9277
9278 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9279
9280         * python/python.c (init__gdb_module): Add declaration.
9281
9282 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9283
9284         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
9285         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
9286         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
9287         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
9288         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
9289         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
9290         * ada-exp.y (_initialize_ada_exp): Add declaration.
9291         * ada-lang.c (_initialize_ada_language): Add declaration.
9292         * ada-tasks.c (_initialize_tasks): Add declaration.
9293         * agent.c (_initialize_agent): Add declaration.
9294         * aix-thread.c (_initialize_aix_thread): Add declaration.
9295         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
9296         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
9297         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
9298         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
9299         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
9300         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
9301         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
9302         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
9303         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
9304         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
9305         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
9306         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
9307         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
9308         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
9309         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
9310         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
9311         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
9312         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
9313         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
9314         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
9315         * annotate.c (_initialize_annotate): Add declaration.
9316         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
9317         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
9318         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
9319         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
9320         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
9321         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
9322         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
9323         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
9324         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
9325         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
9326         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
9327         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
9328         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
9329         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
9330         * auto-load.c (_initialize_auto_load): Add declaration.
9331         * auxv.c (_initialize_auxv): Add declaration.
9332         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
9333         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
9334         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
9335         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
9336         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
9337         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
9338         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
9339         * breakpoint.c (_initialize_breakpoint): Add declaration.
9340         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
9341         * btrace.c (_initialize_btrace): Add declaration.
9342         * charset.c (_initialize_charset): Add declaration.
9343         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
9344         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
9345         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
9346         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
9347         * cli/cli-script.c (_initialize_cli_script): Add declaration.
9348         * cli/cli-style.c (_initialize_cli_style): Add declaration.
9349         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
9350         * coffread.c (_initialize_coffread): Add declaration.
9351         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
9352         * compile/compile.c (_initialize_compile): Add declaration.
9353         * complaints.c (_initialize_complaints): Add declaration.
9354         * completer.c (_initialize_completer): Add declaration.
9355         * copying.c (_initialize_copying): Add declaration.
9356         * corefile.c (_initialize_core): Add declaration.
9357         * corelow.c (_initialize_corelow): Add declaration.
9358         * cp-abi.c (_initialize_cp_abi): Add declaration.
9359         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
9360         * cp-support.c (_initialize_cp_support): Add declaration.
9361         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
9362         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
9363         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
9364         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
9365         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
9366         * ctfread.c (_initialize_ctfread): Add declaration.
9367         * d-lang.c (_initialize_d_language): Add declaration.
9368         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
9369         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
9370         * dbxread.c (_initialize_dbxread): Add declaration.
9371         * dcache.c (_initialize_dcache): Add declaration.
9372         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
9373         * disasm.c (_initialize_disasm): Add declaration.
9374         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
9375         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
9376         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
9377         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
9378         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
9379         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
9380         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
9381         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
9382         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
9383         * elfread.c (_initialize_elfread): Add declaration.
9384         * exec.c (_initialize_exec): Add declaration.
9385         * extension.c (_initialize_extension): Add declaration.
9386         * f-lang.c (_initialize_f_language): Add declaration.
9387         * f-valprint.c (_initialize_f_valprint): Add declaration.
9388         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
9389         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
9390         * filesystem.c (_initialize_filesystem): Add declaration.
9391         * findcmd.c (_initialize_mem_search): Add declaration.
9392         * findvar.c (_initialize_findvar): Add declaration.
9393         * fork-child.c (_initialize_fork_child): Add declaration.
9394         * frame-base.c (_initialize_frame_base): Add declaration.
9395         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
9396         * frame.c (_initialize_frame): Add declaration.
9397         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
9398         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
9399         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
9400         * gcore.c (_initialize_gcore): Add declaration.
9401         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
9402         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
9403         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
9404         * gdbarch.c (_initialize_gdbarch): Add declaration.
9405         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
9406         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
9407         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
9408         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
9409         * go-lang.c (_initialize_go_language): Add declaration.
9410         * go32-nat.c (_initialize_go32_nat): Add declaration.
9411         * guile/guile.c (_initialize_guile): Add declaration.
9412         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
9413         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
9414         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
9415         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
9416         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
9417         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
9418         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
9419         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
9420         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
9421         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
9422         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
9423         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
9424         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
9425         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
9426         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
9427         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
9428         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
9429         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
9430         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
9431         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
9432         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
9433         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
9434         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
9435         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
9436         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
9437         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
9438         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
9439         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
9440         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
9441         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
9442         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
9443         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
9444         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
9445         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
9446         * infcall.c (_initialize_infcall): Add declaration.
9447         * infcmd.c (_initialize_infcmd): Add declaration.
9448         * inflow.c (_initialize_inflow): Add declaration.
9449         * infrun.c (_initialize_infrun): Add declaration.
9450         * interps.c (_initialize_interpreter): Add declaration.
9451         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
9452         * jit.c (_initialize_jit): Add declaration.
9453         * language.c (_initialize_language): Add declaration.
9454         * linux-fork.c (_initialize_linux_fork): Add declaration.
9455         * linux-nat.c (_initialize_linux_nat): Add declaration.
9456         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
9457         * linux-thread-db.c (_initialize_thread_db): Add declaration.
9458         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
9459         * m2-lang.c (_initialize_m2_language): Add declaration.
9460         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
9461         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
9462         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
9463         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
9464         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
9465         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
9466         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
9467         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
9468         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
9469         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
9470         * machoread.c (_initialize_machoread): Add declaration.
9471         * macrocmd.c (_initialize_macrocmd): Add declaration.
9472         * macroscope.c (_initialize_macroscope): Add declaration.
9473         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
9474         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
9475         * maint.c (_initialize_maint_cmds): Add declaration.
9476         * mdebugread.c (_initialize_mdebugread): Add declaration.
9477         * memattr.c (_initialize_mem): Add declaration.
9478         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
9479         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
9480         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
9481         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
9482         * mi/mi-main.c (_initialize_mi_main): Add declaration.
9483         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
9484         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
9485         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
9486         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
9487         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
9488         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
9489         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
9490         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
9491         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
9492         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
9493         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
9494         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
9495         * mipsread.c (_initialize_mipsread): Add declaration.
9496         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
9497         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
9498         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
9499         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
9500         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
9501         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
9502         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
9503         * nto-procfs.c (_initialize_procfs): Add declaration.
9504         * objc-lang.c (_initialize_objc_language): Add declaration.
9505         * observable.c (_initialize_observer): Add declaration.
9506         * opencl-lang.c (_initialize_opencl_language): Add declaration.
9507         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
9508         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
9509         * osabi.c (_initialize_gdb_osabi): Add declaration.
9510         * osdata.c (_initialize_osdata): Add declaration.
9511         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
9512         * parse.c (_initialize_parse): Add declaration.
9513         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
9514         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
9515         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
9516         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
9517         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
9518         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
9519         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
9520         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
9521         * printcmd.c (_initialize_printcmd): Add declaration.
9522         * probe.c (_initialize_probe): Add declaration.
9523         * proc-api.c (_initialize_proc_api): Add declaration.
9524         * proc-events.c (_initialize_proc_events): Add declaration.
9525         * proc-service.c (_initialize_proc_service): Add declaration.
9526         * procfs.c (_initialize_procfs): Add declaration.
9527         * producer.c (_initialize_producer): Add declaration.
9528         * psymtab.c (_initialize_psymtab): Add declaration.
9529         * python/python.c (_initialize_python): Add declaration.
9530         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
9531         * record-btrace.c (_initialize_record_btrace): Add declaration.
9532         * record-full.c (_initialize_record_full): Add declaration.
9533         * record.c (_initialize_record): Add declaration.
9534         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
9535         * regcache.c (_initialize_regcache): Add declaration.
9536         * reggroups.c (_initialize_reggroup): Add declaration.
9537         * remote-notif.c (_initialize_notif): Add declaration.
9538         * remote-sim.c (_initialize_remote_sim): Add declaration.
9539         * remote.c (_initialize_remote): Add declaration.
9540         * reverse.c (_initialize_reverse): Add declaration.
9541         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
9542         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
9543         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
9544         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
9545         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
9546         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
9547         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
9548         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
9549         Add declaration.
9550         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
9551         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
9552         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
9553         * rust-exp.y (_initialize_rust_exp): Add declaration.
9554         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
9555         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
9556         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
9557         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
9558         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
9559         * score-tdep.c (_initialize_score_tdep): Add declaration.
9560         * ser-go32.c (_initialize_ser_dos): Add declaration.
9561         * ser-mingw.c (_initialize_ser_windows): Add declaration.
9562         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
9563         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
9564         * ser-uds.c (_initialize_ser_socket): Add declaration.
9565         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
9566         * serial.c (_initialize_serial): Add declaration.
9567         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
9568         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
9569         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
9570         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
9571         * skip.c (_initialize_step_skip): Add declaration.
9572         * sol-thread.c (_initialize_sol_thread): Add declaration.
9573         * solib-aix.c (_initialize_solib_aix): Add declaration.
9574         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
9575         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
9576         * solib-frv.c (_initialize_frv_solib): Add declaration.
9577         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
9578         * solib-target.c (_initialize_solib_target): Add declaration.
9579         * solib.c (_initialize_solib): Add declaration.
9580         * source-cache.c (_initialize_source_cache): Add declaration.
9581         * source.c (_initialize_source): Add declaration.
9582         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
9583         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
9584         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
9585         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
9586         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
9587         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
9588         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
9589         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
9590         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
9591         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
9592         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
9593         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
9594         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
9595         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
9596         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
9597         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
9598         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
9599         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
9600         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
9601         * stabsread.c (_initialize_stabsread): Add declaration.
9602         * stack.c (_initialize_stack): Add declaration.
9603         * stap-probe.c (_initialize_stap_probe): Add declaration.
9604         * std-regs.c (_initialize_frame_reg): Add declaration.
9605         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
9606         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
9607         * symfile.c (_initialize_symfile): Add declaration.
9608         * symmisc.c (_initialize_symmisc): Add declaration.
9609         * symtab.c (_initialize_symtab): Add declaration.
9610         * target.c (_initialize_target): Add declaration.
9611         * target-connection.c (_initialize_target_connection): Add
9612         declaration.
9613         * target-dcache.c (_initialize_target_dcache): Add declaration.
9614         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
9615         * thread.c (_initialize_thread): Add declaration.
9616         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
9617         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
9618         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
9619         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
9620         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
9621         * tracectf.c (_initialize_ctf): Add declaration.
9622         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
9623         * tracefile.c (_initialize_tracefile): Add declaration.
9624         * tracepoint.c (_initialize_tracepoint): Add declaration.
9625         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
9626         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
9627         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
9628         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
9629         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
9630         * tui/tui-win.c (_initialize_tui_win): Add declaration.
9631         * tui/tui.c (_initialize_tui): Add declaration.
9632         * typeprint.c (_initialize_typeprint): Add declaration.
9633         * ui-style.c (_initialize_ui_style): Add declaration.
9634         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
9635         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
9636         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
9637         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
9638         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
9639         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
9640         * unittests/filtered_iterator-selftests.c
9641         (_initialize_filtered_iterator_selftests): Add declaration.
9642         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
9643         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
9644         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
9645         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
9646         * unittests/main-thread-selftests.c
9647         (_initialize_main_thread_selftests): Add declaration.
9648         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
9649         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
9650         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
9651         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
9652         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
9653         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
9654         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
9655         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
9656         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
9657         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
9658         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
9659         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
9660         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
9661         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
9662         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
9663         declaration.
9664         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
9665         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
9666         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
9667         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
9668         * user-regs.c (_initialize_user_regs): Add declaration.
9669         * utils.c (_initialize_utils): Add declaration.
9670         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
9671         * valops.c (_initialize_valops): Add declaration.
9672         * valprint.c (_initialize_valprint): Add declaration.
9673         * value.c (_initialize_values): Add declaration.
9674         * varobj.c (_initialize_varobj): Add declaration.
9675         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
9676         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
9677         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
9678         * windows-nat.c (_initialize_windows_nat): Add declaration.
9679         (_initialize_check_for_gdb_ini): Add declaration.
9680         (_initialize_loadable): Add declaration.
9681         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
9682         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
9683         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
9684         * xcoffread.c (_initialize_xcoffread): Add declaration.
9685         * xml-support.c (_initialize_xml_support): Add declaration.
9686         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
9687         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
9688         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
9689         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
9690
9691 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9692
9693         * regformats/regdat.sh: Generate declaration for init function.
9694
9695 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9696
9697         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
9698         up.
9699         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
9700         close_one_inferior>: New methods.
9701         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
9702         pass down target to find_inferior_pid.
9703         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
9704         Pass down target to find_inferior_ptid.
9705         (gdbsim_target::create_inferior): Pass down target to
9706         add_thread_silent.
9707         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
9708         target down to find_inferior_ptid and switch_to_thread.
9709         (gdbsim_target::close): Update to call close_one_inferior.
9710         (struct resume_data): Remove.
9711         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
9712         directly, rather than through a void pointer.
9713         (gdbsim_target::resume): Update to call resume_one_inferior.
9714
9715 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
9716
9717         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
9718
9719 2020-01-12  Pedro Alves  <palves@redhat.com>
9720
9721         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
9722         directly for the current inferior instead of
9723         discard_all_inferiors.
9724         (discard_all_inferiors): Delete.
9725
9726 2020-01-11  Tom Tromey  <tom@tromey.com>
9727
9728         * tui/tui-wingeneral.c (box_win): Check cli_styling.
9729         * tui/tui-winsource.c (tui_source_window_base::refill): Use
9730         deprecated_safe_get_selected_frame.
9731
9732 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
9733
9734         * inferior.c (print_inferior): Switch inferior before printing it.
9735
9736 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
9737             Pedro Alves  <palves@redhat.com>
9738
9739         * progspace-and-thread.c (switch_to_program_space_and_thread):
9740         Assert there's an inferior for PSPACE.  Use
9741         switch_to_inferior_no_thread to switch the inferior too.
9742         * progspace.c (program_space::~program_space): Call
9743         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
9744         (program_space::free_all_objfiles): Don't call clear_symtab_users
9745         here.
9746         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
9747
9748 2020-01-10  Pedro Alves  <palves@redhat.com>
9749
9750         * NEWS: Mention multi-target debugging, "info connections", and
9751         "add-inferior -no-connection".
9752
9753 2020-01-10  Pedro Alves  <palves@redhat.com>
9754
9755         * infrun.c: Include "target-connection.h".
9756         (check_multi_target_resumption): New.
9757         (proceed): Call it.
9758         * target-connection.c (make_target_connection_string): Make
9759         extern.
9760         * target-connection.h (make_target_connection_string): Declare.
9761
9762 2020-01-10  Pedro Alves  <palves@redhat.com>
9763
9764         * Makefile.in (COMMON_SFILES): Add target-connection.c.
9765         * inferior.c (uiout_field_connection): New function.
9766         (print_inferior): Add new "connection-id" column.
9767         (add_inferior_command): Show connection number/string of added
9768         inferior.
9769         * process-stratum-target.h
9770         (process_stratum_target::connection_string): New virtual method.
9771         (process_stratum_target::connection_number): New field.
9772         * remote.c (remote_target::connection_string): New override.
9773         * target-connection.c: New file.
9774         * target-connection.h: New file.
9775         * target.c (decref_target): Remove process_stratum targets from
9776         the connection list.
9777         (target_stack::push): Add process_stratum targets to the
9778         connection list.
9779
9780 2020-01-10  Pedro Alves  <palves@redhat.com>
9781
9782         Revert:
9783         2016-04-12  Pedro Alves  <palves@redhat.com>
9784         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
9785         Remove references to name.
9786         * serial.h (struct serial) <name>: Delete.
9787
9788 2020-01-10  Pedro Alves  <palves@redhat.com>
9789
9790         * gdbarch-selftests.c (register_to_value_test): Remove "target
9791         already pushed" check.
9792
9793 2020-01-10  Pedro Alves  <palves@redhat.com>
9794             John Baldwin  <jhb@FreeBSD.org>
9795
9796         * aarch64-linux-nat.c
9797         (aarch64_linux_nat_target::thread_architecture): Adjust.
9798         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
9799         (task_command_1): Likewise.
9800         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
9801         (aix_thread_target::wait, aix_thread_target::fetch_registers)
9802         (aix_thread_target::store_registers)
9803         (aix_thread_target::thread_alive): Adjust.
9804         * amd64-fbsd-tdep.c: Include "inferior.h".
9805         (amd64fbsd_get_thread_local_address): Pass down target.
9806         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
9807         thread's gdbarch instead of target_gdbarch.
9808         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
9809         get_last_target_status.
9810         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
9811         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
9812         inferiors.
9813         (update_inserted_breakpoint_locations): Skip if inferiors with no
9814         execution.
9815         (update_global_location_list): When handling moribund locations,
9816         find representative inferior for location's pspace, and use thread
9817         count of its process_stratum target.
9818         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
9819         * bsd-uthread.c (bsd_uthread_target::wait): Use
9820         as_process_stratum_target and adjust thread_change_ptid and
9821         add_thread calls.
9822         (bsd_uthread_target::update_thread_list): Use
9823         as_process_stratum_target and adjust find_thread_ptid,
9824         thread_change_ptid and add_thread calls.
9825         * btrace.c (maint_btrace_packet_history_cmd): Adjust
9826         find_thread_ptid call.
9827         * corelow.c (add_to_thread_list): Adjust add_thread call.
9828         (core_target_open): Adjust add_thread_silent and thread_count
9829         calls.
9830         (core_target::pid_to_str): Adjust find_inferior_ptid call.
9831         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
9832         * event-top.c (async_disconnect): Pop targets from all inferiors.
9833         * exec.c (add_target_sections): Push exec target on all inferiors
9834         sharing the program space.
9835         (remove_target_sections): Remove the exec target from all
9836         inferiors sharing the program space.
9837         (exec_on_vfork): New.
9838         * exec.h (exec_on_vfork): Declare.
9839         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
9840         Pass it down.
9841         (fbsd_nat_target::update_thread_list): Adjust.
9842         (fbsd_nat_target::resume): Adjust.
9843         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
9844         down.
9845         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
9846         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
9847         get_thread_arch_regcache call.
9848         * fork-child.c (gdb_startup_inferior): Pass target down to
9849         startup_inferior and set_executing.
9850         * gdbthread.h (struct process_stratum_target): Forward declare.
9851         (add_thread, add_thread_silent, add_thread_with_info)
9852         (in_thread_list): Add process_stratum_target parameter.
9853         (find_thread_ptid(inferior*, ptid_t)): New overload.
9854         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
9855         parameter.
9856         (all_threads()): Delete overload.
9857         (all_threads, all_non_exited_threads): Add process_stratum_target
9858         parameter.
9859         (all_threads_safe): Use brace initialization.
9860         (thread_count): Add process_stratum_target parameter.
9861         (set_resumed, set_running, set_stop_requested, set_executing)
9862         (threads_are_executing, finish_thread_state): Add
9863         process_stratum_target parameter.
9864         (switch_to_thread): Use is_current_thread.
9865         * i386-fbsd-tdep.c: Include "inferior.h".
9866         (i386fbsd_get_thread_local_address): Pass down target.
9867         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
9868         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
9869         have_inferiors check.
9870         * inf-ptrace.c (inf_ptrace_target::create_inferior)
9871         (inf_ptrace_target::attach): Adjust.
9872         * infcall.c (run_inferior_call): Adjust.
9873         * infcmd.c (run_command_1): Pass target to
9874         scoped_finish_thread_state.
9875         (proceed_thread_callback): Skip inferiors with no execution.
9876         (continue_command): Rename 'all_threads' local to avoid hiding
9877         'all_threads' function.  Adjust get_last_target_status call.
9878         (prepare_one_step): Adjust set_running call.
9879         (signal_command): Use user_visible_resume_target.  Compare thread
9880         pointers instead of inferior_ptid.
9881         (info_program_command): Adjust to pass down target.
9882         (attach_command): Mark target's 'thread_executing' flag.
9883         (stop_current_target_threads_ns): New, factored out from ...
9884         (interrupt_target_1): ... this.  Switch inferior before making
9885         target calls.
9886         * inferior-iter.h
9887         (struct all_inferiors_iterator, struct all_inferiors_range)
9888         (struct all_inferiors_safe_range)
9889         (struct all_non_exited_inferiors_range): Filter on
9890         process_stratum_target too.  Remove explicit.
9891         * inferior.c (inferior::inferior): Push dummy target on target
9892         stack.
9893         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
9894         Add process_stratum_target parameter, and pass it down.
9895         (have_live_inferiors): Adjust.
9896         (switch_to_inferior_and_push_target): New.
9897         (add_inferior_command, clone_inferior_command): Handle
9898         "-no-connection" parameter.  Use
9899         switch_to_inferior_and_push_target.
9900         (_initialize_inferior): Mention "-no-connection" option in
9901         the help of "add-inferior" and "clone-inferior" commands.
9902         * inferior.h: Include "process-stratum-target.h".
9903         (interrupt_target_1): Use bool.
9904         (struct inferior) <push_target, unpush_target, target_is_pushed,
9905         find_target_beneath, top_target, process_target, target_at,
9906         m_stack>: New.
9907         (discard_all_inferiors): Delete.
9908         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
9909         (all_inferiors, all_non_exited_inferiors): Add
9910         process_stratum_target parameter.
9911         * infrun.c: Include "gdb_select.h" and <unordered_map>.
9912         (target_last_proc_target): New global.
9913         (follow_fork_inferior): Push target on new inferior.  Pass target
9914         to add_thread_silent.  Call exec_on_vfork.  Handle target's
9915         reference count.
9916         (follow_fork): Adjust get_last_target_status call.  Also consider
9917         target.
9918         (follow_exec): Push target on new inferior.
9919         (struct execution_control_state) <target>: New field.
9920         (user_visible_resume_target): New.
9921         (do_target_resume): Call target_async.
9922         (resume_1): Set target's threads_executing flag.  Consider resume
9923         target.
9924         (commit_resume_all_targets): New.
9925         (proceed): Also consider resume target.  Skip threads of inferiors
9926         with no execution.  Commit resumtion in all targets.
9927         (start_remote): Pass current inferior to wait_for_inferior.
9928         (infrun_thread_stop_requested): Consider target as well.  Pass
9929         thread_info pointer to clear_inline_frame_state instead of ptid.
9930         (infrun_thread_thread_exit): Consider target as well.
9931         (random_pending_event_thread): New inferior parameter.  Use it.
9932         (do_target_wait): Rename to ...
9933         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
9934         down.
9935         (threads_are_resumed_pending_p, do_target_wait): New.
9936         (prepare_for_detach): Adjust calls.
9937         (wait_for_inferior): New inferior parameter.  Handle it.  Use
9938         do_target_wait_1 instead of do_target_wait.
9939         (fetch_inferior_event): Adjust.  Switch to representative
9940         inferior.  Pass target down.
9941         (set_last_target_status): Add process_stratum_target parameter.
9942         Save target in global.
9943         (get_last_target_status): Add process_stratum_target parameter and
9944         handle it.
9945         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
9946         (context_switch): Check inferior_ptid == null_ptid before calling
9947         inferior_thread().
9948         (get_inferior_stop_soon): Pass down target.
9949         (wait_one): Rename to ...
9950         (poll_one_curr_target): ... this.
9951         (struct wait_one_event): New.
9952         (wait_one): New.
9953         (stop_all_threads): Adjust.
9954         (handle_no_resumed, handle_inferior_event): Adjust to consider the
9955         event's target.
9956         (switch_back_to_stepped_thread): Also consider target.
9957         (print_stop_event): Update.
9958         (normal_stop): Update.  Also consider the resume target.
9959         * infrun.h (wait_for_inferior): Remove declaration.
9960         (user_visible_resume_target): New declaration.
9961         (get_last_target_status, set_last_target_status): New
9962         process_stratum_target parameter.
9963         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9964         process_stratum_target parameter, and use it.
9965         (clear_inline_frame_state (thread_info*)): New.
9966         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9967         process_stratum_target parameter.
9968         (clear_inline_frame_state (thread_info*)): Declare.
9969         * linux-fork.c (delete_checkpoint_command): Pass target down to
9970         find_thread_ptid.
9971         (checkpoint_command): Adjust.
9972         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
9973         instead of just tweaking inferior_ptid.
9974         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
9975         (exit_lwp): Pass target down to find_thread_ptid.
9976         (attach_proc_task_lwp_callback): Pass target down to
9977         add_thread/set_running/set_executing.
9978         (linux_nat_target::attach): Pass target down to
9979         thread_change_ptid.
9980         (get_detach_signal): Pass target down to find_thread_ptid.
9981         Consider last target status's target.
9982         (linux_resume_one_lwp_throw, resume_lwp)
9983         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
9984         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
9985         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
9986         (linux_nat_target::async_wait_fd): New.
9987         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
9988         target down.
9989         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
9990         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
9991         * linux-thread-db.c (struct thread_db_info::process_target): New
9992         field.
9993         (add_thread_db_info): Save target.
9994         (get_thread_db_info): New process_stratum_target parameter.  Also
9995         match target.
9996         (delete_thread_db_info): New process_stratum_target parameter.
9997         Also match target.
9998         (thread_from_lwp): Adjust to pass down target.
9999         (thread_db_notice_clone): Pass down target.
10000         (check_thread_db_callback): Pass down target.
10001         (try_thread_db_load_1): Always push the thread_db target.
10002         (try_thread_db_load, record_thread): Pass target down.
10003         (thread_db_target::detach): Pass target down.  Always unpush the
10004         thread_db target.
10005         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
10006         target down.  Always unpush the thread_db target.
10007         (find_new_threads_callback, thread_db_find_new_threads_2)
10008         (thread_db_target::update_thread_list): Pass target down.
10009         (thread_db_target::pid_to_str): Pass current inferior down.
10010         (thread_db_target::get_thread_local_address): Pass target down.
10011         (thread_db_target::resume, maintenance_check_libthread_db): Pass
10012         target down.
10013         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
10014         * procfs.c (procfs_target::procfs_init_inferior): Declare.
10015         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
10016         (procfs_init_inferior): Rename to ...
10017         (procfs_target::procfs_init_inferior): ... this and adjust.
10018         (procfs_target::create_inferior, procfs_notice_thread)
10019         (procfs_do_thread_registers): Adjust.
10020         * ppc-fbsd-tdep.c: Include "inferior.h".
10021         (ppcfbsd_get_thread_local_address): Pass down target.
10022         * proc-service.c (ps_xfer_memory): Switch current inferior and
10023         program space as well.
10024         (get_ps_regcache): Pass target down.
10025         * process-stratum-target.c
10026         (process_stratum_target::thread_address_space)
10027         (process_stratum_target::thread_architecture): Pass target down.
10028         * process-stratum-target.h
10029         (process_stratum_target::threads_executing): New field.
10030         (as_process_stratum_target): New.
10031         * ravenscar-thread.c
10032         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
10033         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
10034         down.
10035         * record-btrace.c (record_btrace_target::info_record): Adjust.
10036         (record_btrace_target::record_method)
10037         (record_btrace_target::record_is_replaying)
10038         (record_btrace_target::fetch_registers)
10039         (get_thread_current_frame_id, record_btrace_target::resume)
10040         (record_btrace_target::wait, record_btrace_target::stop): Pass
10041         target down.
10042         * record-full.c (record_full_wait_1): Switch to event thread.
10043         Pass target down.
10044         * regcache.c (regcache::regcache)
10045         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
10046         process_stratum_target parameter and handle it.
10047         (current_thread_target): New global.
10048         (get_thread_regcache): Add process_stratum_target parameter and
10049         handle it.  Switch inferior before calling target method.
10050         (get_thread_regcache): Pass target down.
10051         (get_thread_regcache_for_ptid): Pass target down.
10052         (registers_changed_ptid): Add process_stratum_target parameter and
10053         handle it.
10054         (registers_changed_thread, registers_changed): Pass target down.
10055         (test_get_thread_arch_aspace_regcache): New.
10056         (current_regcache_test): Define a couple local test_target_ops
10057         instances and use them for testing.
10058         (readwrite_regcache): Pass process_stratum_target parameter.
10059         (cooked_read_test, cooked_write_test): Pass mock_target down.
10060         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
10061         (get_thread_arch_aspace_regcache): Add process_stratum_target
10062         parameter.
10063         (regcache::target): New method.
10064         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
10065         (regcache::registers_changed_ptid): Add process_stratum_target
10066         parameter.
10067         (regcache::m_target): New field.
10068         (registers_changed_ptid): Add process_stratum_target parameter.
10069         * remote.c (remote_state::supports_vCont_probed): New field.
10070         (remote_target::async_wait_fd): New method.
10071         (remote_unpush_and_throw): Add remote_target parameter.
10072         (get_current_remote_target): Adjust.
10073         (remote_target::remote_add_inferior): Push target.
10074         (remote_target::remote_add_thread)
10075         (remote_target::remote_notice_new_inferior)
10076         (get_remote_thread_info): Pass target down.
10077         (remote_target::update_thread_list): Skip threads of inferiors
10078         bound to other targets.  (remote_target::close): Don't discard
10079         inferiors.  (remote_target::add_current_inferior_and_thread)
10080         (remote_target::process_initial_stop_replies)
10081         (remote_target::start_remote)
10082         (remote_target::remote_serial_quit_handler): Pass down target.
10083         (remote_target::remote_unpush_target): New remote_target
10084         parameter.  Unpush the target from all inferiors.
10085         (remote_target::remote_unpush_and_throw): New remote_target
10086         parameter.  Pass it down.
10087         (remote_target::open_1): Check whether the current inferior has
10088         execution instead of checking whether any inferior is live.  Pass
10089         target down.
10090         (remote_target::remote_detach_1): Pass down target.  Use
10091         remote_unpush_target.
10092         (extended_remote_target::attach): Pass down target.
10093         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
10094         (remote_target::append_resumption): Pass down target.
10095         (remote_target::append_pending_thread_resumptions)
10096         (remote_target::remote_resume_with_hc, remote_target::resume)
10097         (remote_target::commit_resume): Pass down target.
10098         (remote_target::remote_stop_ns): Check supports_vCont_probed.
10099         (remote_target::interrupt_query)
10100         (remote_target::remove_new_fork_children)
10101         (remote_target::check_pending_events_prevent_wildcard_vcont)
10102         (remote_target::remote_parse_stop_reply)
10103         (remote_target::process_stop_reply): Pass down target.
10104         (first_remote_resumed_thread): New remote_target parameter.  Pass
10105         it down.
10106         (remote_target::wait_as): Pass down target.
10107         (unpush_and_perror): New remote_target parameter.  Pass it down.
10108         (remote_target::readchar, remote_target::remote_serial_write)
10109         (remote_target::getpkt_or_notif_sane_1)
10110         (remote_target::kill_new_fork_children, remote_target::kill): Pass
10111         down target.
10112         (remote_target::mourn_inferior): Pass down target.  Use
10113         remote_unpush_target.
10114         (remote_target::core_of_thread)
10115         (remote_target::remote_btrace_maybe_reopen): Pass down target.
10116         (remote_target::pid_to_exec_file)
10117         (remote_target::thread_handle_to_thread_info): Pass down target.
10118         (remote_target::async_wait_fd): New.
10119         * riscv-fbsd-tdep.c: Include "inferior.h".
10120         (riscv_fbsd_get_thread_local_address): Pass down target.
10121         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
10122         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
10123         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
10124         Adjust.
10125         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
10126         * solib-svr4.c (enable_break): Pass down target.
10127         * spu-multiarch.c (parse_spufs_run): Pass down target.
10128         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
10129         * target-delegates.c: Regenerate.
10130         * target.c (g_target_stack): Delete.
10131         (current_top_target): Return the current inferior's top target.
10132         (target_has_execution_1): Refer to the passed-in inferior's top
10133         target.
10134         (target_supports_terminal_ours): Check whether the initial
10135         inferior was already created.
10136         (decref_target): New.
10137         (target_stack::push): Incref/decref the target.
10138         (push_target, push_target, unpush_target): Adjust.
10139         (target_stack::unpush): Defref target.
10140         (target_is_pushed): Return bool.  Adjust to refer to the current
10141         inferior's target stack.
10142         (dispose_inferior): Delete, and inline parts ...
10143         (target_preopen): ... here.  Only dispose of the current inferior.
10144         (target_detach): Hold strong target reference while detaching.
10145         Pass target down.
10146         (target_thread_name): Add assertion.
10147         (target_resume): Pass down target.
10148         (target_ops::beneath, find_target_at): Adjust to refer to the
10149         current inferior's target stack.
10150         (get_dummy_target): New.
10151         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
10152         has a thread running.
10153         (initialize_targets): Rename to ...
10154         (_initialize_target): ... this.
10155         * target.h: Include "gdbsupport/refcounted-object.h".
10156         (struct target_ops): Inherit refcounted_object.
10157         (target_ops::shortname, target_ops::longname): Make const.
10158         (target_ops::async_wait_fd): New method.
10159         (decref_target): Declare.
10160         (struct target_ops_ref_policy): New.
10161         (target_ops_ref): New typedef.
10162         (get_dummy_target): Declare function.
10163         (target_is_pushed): Return bool.
10164         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
10165         (all_matching_threads_iterator::all_matching_threads_iterator):
10166         Handle filter target.
10167         * thread-iter.h (struct all_matching_threads_iterator, struct
10168         all_matching_threads_range, class all_non_exited_threads_range):
10169         Filter by target too.  Remove explicit.
10170         * thread.c (threads_executing): Delete.
10171         (inferior_thread): Pass down current inferior.
10172         (clear_thread_inferior_resources): Pass down thread pointer
10173         instead of ptid_t.
10174         (add_thread_silent, add_thread_with_info, add_thread): Add
10175         process_stratum_target parameter.  Use it for thread and inferior
10176         searches.
10177         (is_current_thread): New.
10178         (thread_info::deletable): Use it.
10179         (find_thread_ptid, thread_count, in_thread_list)
10180         (thread_change_ptid, set_resumed, set_running): New
10181         process_stratum_target parameter.  Pass it down.
10182         (set_executing): New process_stratum_target parameter.  Pass it
10183         down.  Adjust reference to 'threads_executing'.
10184         (threads_are_executing): New process_stratum_target parameter.
10185         Adjust reference to 'threads_executing'.
10186         (set_stop_requested, finish_thread_state): New
10187         process_stratum_target parameter.  Pass it down.
10188         (switch_to_thread): Also match inferior.
10189         (switch_to_thread): New process_stratum_target parameter.  Pass it
10190         down.
10191         (update_threads_executing): Reimplement.
10192         * top.c (quit_force): Pop targets from all inferior.
10193         (gdb_init): Don't call initialize_targets.
10194         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
10195         Declare.
10196         (windows_add_thread, windows_delete_thread): Adjust.
10197         (get_windows_debug_event): Rename to ...
10198         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
10199         * tracefile-tfile.c (tfile_target_open): Pass down target.
10200         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
10201         Forward declare.
10202         (switch_to_thread): Add process_stratum_target parameter.
10203         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
10204         parameter.  Use it.
10205         (mi_on_resume): Pass target down.
10206         * nat/fork-inferior.c (startup_inferior): Add
10207         process_stratum_target parameter.  Pass it down.
10208         * nat/fork-inferior.h (startup_inferior): Add
10209         process_stratum_target parameter.
10210         * python/py-threadevent.c (py_get_event_thread): Pass target down.
10211
10212 2020-01-10  Pedro Alves  <palves@redhat.com>
10213
10214         * remote.c (remote_target::start_remote): Don't set inferior_ptid
10215         directly.  Instead find the first thread in the thread list and
10216         use switch_to_thread.
10217
10218 2020-01-10  Pedro Alves  <palves@redhat.com>
10219
10220         * remote.c (remote_target::remote_add_inferior): Don't bind a
10221         process to the current inferior if the current inferior is already
10222         bound to a process.
10223
10224 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
10225             Pedro Alves  <palves@redhat.com>
10226
10227         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
10228         If no process is specified, return null_ptid instead of
10229         inferior_ptid.
10230         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
10231         TARGET_WAITKIND_SIGNALLED with no pid.
10232
10233 2020-01-10  Pedro Alves  <palves@redhat.com>
10234
10235         * remote.c (first_remote_resumed_thread): New.
10236         (remote_target::wait_as): Use it as default event_ptid instead of
10237         inferior_ptid.
10238
10239 2020-01-10  Pedro Alves  <palves@redhat.com>
10240
10241         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
10242
10243 2020-01-10  Pedro Alves  <palves@redhat.com>
10244
10245         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
10246         not -1.
10247
10248 2020-01-10  Pedro Alves  <palves@redhat.com>
10249
10250         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
10251         ptid to get_last_target_status.
10252         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
10253         ptid to get_last_target_status.
10254         * infcmd.c (continue_command): Don't pass a target_waitstatus to
10255         get_last_target_status.
10256         (info_program_command): Don't pass a target_waitstatus to
10257         get_last_target_status.
10258         * infrun.c (init_wait_for_inferior): Use
10259         nullify_last_target_wait_ptid.
10260         (get_last_target_status): Handle nullptr arguments.
10261         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
10262         (print_stop_event): Don't pass a ptid to get_last_target_status.
10263         (normal_stop): Don't pass a ptid to get_last_target_status.
10264         * infrun.h (get_last_target_status, set_last_target_status): Move
10265         comments here and update.
10266         (nullify_last_target_wait_ptid): Declare.
10267         * linux-fork.c (fork_load_infrun_state): Remove local extern
10268         declaration of nullify_last_target_wait_ptid.
10269         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
10270         to get_last_target_status.
10271
10272 2020-01-10  Pedro Alves  <palves@redhat.com>
10273
10274         * gdbthread.h (scoped_restore_current_thread)
10275         <dont_restore, restore, m_dont_restore>: Declare.
10276         * thread.c (thread_alive): Add assertion.  Return bool.
10277         (switch_to_thread_if_alive): New.
10278         (prune_threads): Switch inferior/thread.
10279         (print_thread_info_1): Switch thread before calling target methods.
10280         (scoped_restore_current_thread::restore): New, factored out from
10281         ...
10282         (scoped_restore_current_thread::~scoped_restore_current_thread):
10283         ... this.
10284         (scoped_restore_current_thread::scoped_restore_current_thread):
10285         Add assertion.
10286         (thread_apply_all_command, thread_select): Use
10287         switch_to_thread_if_alive.
10288         * infrun.c (proceed, restart_threads, handle_signal_stop)
10289         (switch_back_to_stepped_thread): Switch current thread before
10290         calling target methods.
10291
10292 2020-01-10  Pedro Alves <palves@redhat.com>
10293
10294         * inferior.c (switch_to_inferior_no_thread): New function,
10295         factored out from ...
10296         (inferior_command): ... here.
10297         * inferior.h (switch_to_inferior_no_thread): Declare.
10298         * mi/mi-main.c (run_one_inferior): Use
10299         switch_to_inferior_no_thread.
10300
10301 2020-01-10  Pedro Alves  <palves@redhat.com>
10302
10303         * infcmd.c (kill_command): Remove dead code.
10304
10305 2020-01-10  Pedro Alves  <palves@redhat.com>
10306
10307         * remote.c (remote_target::mourn_inferior): No longer check
10308         whether the target is running.
10309
10310 2020-01-10  Pedro Alves  <palves@redhat.com>
10311
10312         * corelow.c (core_target::has_execution): Change parameter type to
10313         inferior pointer.
10314         * inferior.c (number_of_live_inferiors): Use
10315         inferior::has_execution instead of target_has_execution_1.
10316         * inferior.h (inferior::has_execution): New.
10317         * linux-thread-db.c (thread_db_target::update_thread_list): Use
10318         inferior::has_execution instead of target_has_execution_1.
10319         * process-stratum-target.c
10320         (process_stratum_target::has_execution): Change parameter type to
10321         inferior pointer.  Check the inferior's PID instead of
10322         inferior_ptid.
10323         * process-stratum-target.h
10324         (process_stratum_target::has_execution): Change parameter type to
10325         inferior pointer.
10326         * record-full.c (record_full_core_target::has_execution): Change
10327         parameter type to inferior pointer.
10328         * target.c (target_has_execution_1): Change parameter type to
10329         inferior pointer.
10330         (target_has_execution_current): Adjust.
10331         * target.h (target_ops::has_execution): Change parameter type to
10332         inferior pointer.
10333         (target_has_execution_1): Change parameter type to inferior
10334         pointer.  Change return type to bool.
10335         * tracefile.h (tracefile_target::has_execution): Change parameter
10336         type to inferior pointer.
10337
10338 2020-01-10  Pedro Alves  <palves@redhat.com>
10339
10340         * exceptions.c (print_flush): Remove current_top_target() check.
10341
10342 2020-01-10  Pedro Alves  <palves@redhat.com>
10343
10344         * remote.c (show_remote_exec_file): Show the current inferior's
10345         exec-file instead of the command variable's value.
10346
10347 2020-01-10  Pedro Alves  <palves@redhat.com>
10348
10349         * record-full.c (record_full_resume_ptid): New global.
10350         (record_full_target::resume): Set it.
10351         (record_full_wait_1): Use record_full_resume_ptid instead of
10352         inferior_ptid.
10353
10354 2020-01-10  Pedro Alves  <palves@redhat.com>
10355
10356         * gdbthread.h (scoped_restore_current_thread)
10357         <dont_restore, restore, m_dont_restore>: Declare.
10358         * thread.c (thread_alive): Add assertion.  Return bool.
10359         (switch_to_thread_if_alive): New.
10360         (prune_threads): Switch inferior/thread.
10361         (print_thread_info_1): Switch thread before calling target methods.
10362         (scoped_restore_current_thread::restore): New, factored out from
10363         ...
10364         (scoped_restore_current_thread::~scoped_restore_current_thread):
10365         ... this.
10366         (scoped_restore_current_thread::scoped_restore_current_thread):
10367         Add assertion.
10368         (thread_apply_all_command, thread_select): Use
10369         switch_to_thread_if_alive.
10370
10371 2020-01-10  George Barrett  <bob@bob131.so>
10372
10373         * stap-probe.c (stap_modify_semaphore): Don't check for null
10374         semaphores.
10375         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
10376         for null semaphores.
10377
10378 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10379
10380         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
10381         all source windows, and maintain horizontal scroll status while
10382         doing so.
10383
10384 2020-01-09  Tom Tromey  <tom@tromey.com>
10385
10386         PR tui/18932:
10387         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
10388         update_source_window, not print_source_lines.
10389
10390 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10391
10392         * tui/tui.c (tui_enable): Register tui hooks after calling
10393         tui_display_main.
10394
10395 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
10396
10397         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
10398
10399 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
10400
10401         * thread.c (print_thread_info_1): Fix indentation.
10402
10403 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
10404
10405         * symtab.c (general_symbol_info::compute_and_set_names): Move the
10406         unique_xmalloc_ptr outside the if to always free the demangled name.
10407
10408 2020-01-08  Tom Tromey  <tromey@adacore.com>
10409
10410         * xcoffread.c (enter_line_range, read_xcoff_symtab)
10411         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
10412         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
10413         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
10414         Remove.
10415         (section_offsets): New typedef.
10416         * symtab.c (fixup_section, get_msymbol_address): Update.
10417         * symmisc.c (dump_msymbols): Update.
10418         * symfile.h (relative_addr_info_to_section_offsets)
10419         (symfile_map_offsets_to_segments): Update.
10420         * symfile.c (build_section_addr_info_from_objfile)
10421         (init_objfile_sect_indices): Update.
10422         (struct place_section_arg): Change type of "offsets".
10423         (place_section): Update.
10424         (relative_addr_info_to_section_offsets): Change type of
10425         "section_offsets".  Remove "num_sections" parameter.
10426         (default_symfile_offsets, syms_from_objfile_1)
10427         (set_objfile_default_section_offset): Update.
10428         (reread_symbols): No need to preserve section offsets by hand.
10429         (symfile_map_offsets_to_segments): Change type of "offsets".
10430         * stap-probe.c (relocate_address): Update.
10431         * stabsread.h (process_one_symbol): Update.
10432         * solib-target.c (struct lm_info_target) <offsets>: Change type.
10433         (solib_target_relocate_section_addresses): Update.
10434         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
10435         Update.
10436         * solib-frv.c (frv_relocate_main_executable): Update.
10437         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
10438         * solib-aix.c (solib_aix_get_section_offsets): Change return
10439         type.
10440         (solib_aix_solib_create_inferior_hook): Update.
10441         * remote.c (remote_target::get_offsets): Update.
10442         * psymtab.c (find_pc_sect_psymtab): Update.
10443         * psympriv.h (struct partial_symbol) <address, text_low,
10444         text_high>: Update.
10445         * objfiles.h (obj_section_offset): Update.
10446         (struct objfile) <section_offsets>: Change type.
10447         <num_sections>: Remove.
10448         (objfile_relocate): Update.
10449         * objfiles.c (entry_point_address_query): Update
10450         (relocate_one_symbol): Change type of "section_offsets".
10451         (objfile_relocate1, objfile_relocate1): Change type of
10452         "new_offsets".
10453         (objfile_rebase1): Update.
10454         * mipsread.c (mipscoff_symfile_read): Update.
10455         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
10456         parameter.
10457         * mdebugread.c (parse_symbol): Change type of "section_offsets".
10458         (parse_external, psymtab_to_symtab_1): Update.
10459         * machoread.c (macho_symfile_offsets): Update.
10460         * ia64-tdep.c (ia64_find_unwind_table): Update.
10461         * hppa-tdep.c (read_unwind_info): Update.
10462         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
10463         * dwarf2read.c (create_addrmap_from_index)
10464         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10465         (process_psymtab_comp_unit_reader, add_partial_symbol)
10466         (add_partial_subprogram, process_full_comp_unit)
10467         (read_file_scope, read_func_scope, read_lexical_block_scope)
10468         (read_call_site_scope, dwarf2_rnglists_process)
10469         (dwarf2_ranges_process, dwarf2_ranges_read)
10470         (dwarf_decode_lines_1, var_decode_location, new_symbol)
10471         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
10472         Update.
10473         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
10474         Update.
10475         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
10476         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
10477         (process_one_symbol): Change type of "section_offsets".
10478         * ctfread.c (get_objfile_text_range): Update.
10479         * coffread.c (coff_symtab_read, enter_linenos)
10480         (process_coff_symbol): Update.
10481         * coff-pe-read.c (add_pe_forwarded_sym): Update.
10482         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
10483
10484 2020-01-08  Tom Tromey  <tromey@adacore.com>
10485
10486         * dwarf2read.c (parse_macro_definition): Use std::string.
10487         (parse_macro_definition): Likewise.
10488
10489 2020-01-08  Tom Tromey  <tromey@adacore.com>
10490
10491         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
10492         (ATTR_ALLOC_CHUNK): Remove.
10493
10494 2020-01-08  Tom Tromey  <tromey@adacore.com>
10495
10496         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
10497
10498 2020-01-08  Tom Tromey  <tromey@adacore.com>
10499
10500         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
10501         (dwarf2_compute_name, open_dwo_file): Likewise.
10502         (process_enumeration_scope): Use std::vector.
10503         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
10504         (partial_die_info::fixup, dwarf2_start_subfile)
10505         (guess_full_die_structure_name, dwarf2_name): Likewise.
10506         (determine_prefix): Update.
10507         (guess_full_die_structure_name): Make return type const.
10508         (partial_die_full_name): Return unique_xmalloc_ptr.
10509         (DW_FIELD_ALLOC_CHUNK): Remove.
10510
10511 2020-01-07  Tom Tromey  <tromey@adacore.com>
10512
10513         PR build/24937:
10514         * stap-probe.c (class stap_static_probe_ops): Add constructor.
10515
10516 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
10517
10518         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
10519
10520 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10521
10522         * stack.c (print_frame_info): Move disassemble_next_line code
10523         inside source_print block.
10524
10525 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10526
10527         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
10528         gdb/signals.h, as we are now using native signal symbols.
10529
10530 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
10531
10532         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
10533         overflow by an early check of content vs threshold.
10534         * tui/tui-source.c (tui_source_window::line_is_displayed):
10535         Likewise.
10536
10537 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10538
10539         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
10540
10541 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
10542
10543         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
10544         export table if no section contains it's RVA.
10545
10546 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10547
10548         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
10549
10550 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
10551
10552         * source.c (print_source_lines_base): Set last_line_listed.
10553
10554 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
10555
10556         * tui/tui-disasm.c: Remove trailing spaces.
10557
10558 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10559             Pedro Alves  <palves@redhat.com>
10560
10561         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
10562         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
10563         (windows_gdb_signal_to_target): New function, uses the above
10564         enumeration to convert GDB internal signal codes to equivalent
10565         Windows codes.
10566         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
10567         * windows-nat.c: Include "gdb_wait.h".
10568         (get_windows_debug_event): Extract the fatal exception from the
10569         exit status and convert to the equivalent Posix signal number.
10570         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
10571         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
10572         * gdbsupport/gdb_wait.c: New file, implements
10573         windows_status_to_termsig.
10574         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
10575         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
10576
10577 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
10578
10579         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
10580         show_layout.
10581
10582 2020-01-05  Luis Machado  <luis.machado@linaro.org>
10583
10584         * aarch64-linux-nat.c
10585         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
10586         and bfd_mach_aarch64.
10587
10588 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10589
10590         * ui-file.c (stdio_file::can_emit_style_escape)
10591         (tee_file::can_emit_style_escape): Ensure style is used also on
10592         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
10593         to gdb_stdout.
10594         * main.c (set_gdb_data_directory): Use file style to output the
10595         warning that the given pathname is not a directory.
10596         * top.c (show_history_filename, gdb_safe_append_history)
10597         (show_gdb_datadir): Use file style.
10598
10599 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
10600
10601         * solib-target.c (struct lm_info_target):
10602         Change offsets to be a unique_xmalloc_ptr.
10603         (solib_target_relocate_section_addresses): Update.
10604
10605 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
10606
10607         * windows-nat.c (windows_clear_solib): Free so_list linked list.
10608
10609 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
10610
10611         * MAINTAINERS (Write After Approval): Add myself.
10612
10613 2020-01-02  Luis Machado  <luis.machado@linaro.org>
10614
10615         * proc-service.c (get_ps_regcache): Remove reference to obsolete
10616         Cell BE architecture.
10617         * target.h (struct target_ops) <thread_architecture>: Likewise.
10618
10619 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
10620
10621         * Makefile.in: Use INSTALL_PROGRAM_ENV.
10622
10623 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
10624
10625         * MAINTAINERS (Write After Approval): Add myself.
10626
10627 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10628
10629         * gdbarch.sh: Update copyright year range of generated files.
10630
10631 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10632
10633         Update copyright year range in all GDB files.
10634
10635 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10636
10637         * copyright.py: Convert to Python 3.
10638
10639 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10640
10641         * copyright.py: Adapt after move of gnulib directory from gdb
10642         directory to toplevel directory.
10643
10644 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10645
10646         * copyright.py (main): Exit if run from the wrong directory.
10647
10648 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10649
10650         * top.c (print_gdb_version): Change copyright year to 2020.
10651
10652 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10653
10654         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
10655
10656 For older changes see ChangeLog-2019.
10657 \f
10658 Local Variables:
10659 mode: change-log
10660 left-margin: 8
10661 fill-column: 74
10662 version-control: never
10663 coding: utf-8
10664 End: