gdb: introduce displaced_step_closure_up type alias
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2020-02-14 Simon Marchi <simon.marchi@efficios.com>
2
3 * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
4 displaced_step_closure_up.
5 * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
6 (struct displaced_step_closure_up):
7 * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
8 * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
9 * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
10 Likewise.
11 * gdbarch.sh (displaced_step_copy_insn): Likewise.
12 * gdbarch.c, gdbarch.h: Re-generate.
13 * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
14 displaced_step_closure_up.
15 * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
16 * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
17 * infrun.h (displaced_step_closure_up): New type alias.
18 (struct displaced_step_inferior_state) <step_closure>: Change
19 type to displaced_step_closure_up.
20 * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
21 displaced_step_closure_up.
22 * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
23
24 2020-02-14 Simon Marchi <simon.marchi@efficios.com>
25
26 * gdbarch.sh (displaced_step_copy_insn): Change return type to an
27 std::unique_ptr.
28 * gdbarch.c: Re-generate.
29 * gdbarch.h: Re-generate.
30 * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
31 change.
32 * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
33 type to std::unique_ptr.
34 * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
35 * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
36 * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
37 * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
38 * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
39 * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
40 * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
41 * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
42 * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
43
44 2020-02-14 Simon Marchi <simon.marchi@efficios.com>
45
46 * infrun.c (get_displaced_step_closure_by_addr): Adjust to
47 std::unique_ptr.
48 (displaced_step_clear): Rename to...
49 (displaced_step_reset): ... this. Just call displaced->reset ().
50 (displaced_step_clear_cleanup): Rename to...
51 (displaced_step_reset_cleanup): ... this.
52 (displaced_step_prepare_throw): Adjust to std::unique_ptr.
53 (displaced_step_fixup): Likewise.
54 (resume_1): Likewise.
55 (handle_inferior_event): Restore child's memory before calling
56 displaced_step_fixup on the parent.
57 * infrun.h (displaced_step_inferior_state) <reset>: Adjust
58 to std::unique_ptr.
59 <step_closure>: Change type to std::unique_ptr.
60
61 2020-02-08 Joel Brobecker <brobecker@adacore.com>
62
63 * version.in: Set GDB version number to 9.1.
64
65 2020-02-05 Iain Buclaw <ibuclaw@gdcproject.org>
66
67 PR gdb/25190:
68 * gdb/remote-sim.c (gdb_os_write_stderr): Update.
69 * gdb/remote.c (remote_console_output): Update.
70 * gdb/ui-file.c (fputs_unfiltered): Rename to...
71 (ui_file_puts): ...this.
72 * gdb/ui-file.h (ui_file_puts): Add declaration.
73 * gdb/utils.c (emit_style_escape): Update.
74 (flush_wrap_buffer): Update.
75 (fputs_maybe_filtered): Update.
76 (fputs_unfiltered): Add function.
77
78 2020-02-05 Iain Buclaw <ibuclaw@gdcproject.org>
79
80 * gdb/event-loop.c (gdb_wait_for_event): Update.
81 * gdb/printcmd.c (printf_command): Update.
82 * gdb/remote-fileio.c (remote_fileio_func_write): Update.
83 * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
84 (gdb_os_flush_stderr): Update.
85 * gdb/remote.c (remote_console_output): Update.
86 * gdb/ui-file.c (gdb_flush): Rename to...
87 (ui_file_flush): ...this.
88 (stderr_file::write): Update.
89 (stderr_file::puts): Update.
90 * gdb/ui-file.h (gdb_flush): Rename to...
91 (ui_file_flush): ...this.
92 * gdb/utils.c (gdb_flush): Add function.
93 * gdb/utils.h (gdb_flush): Add declaration.
94
95 2020-02-07 Tom Tromey <tromey@adacore.com>
96
97 PR breakpoints/24915:
98 * source.c (find_and_open_source): Do not check basenames_may_differ.
99
100 2020-01-10 Christian Biesinger <cbiesinger@google.com>
101
102 * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
103
104 2020-01-07 Tom Tromey <tromey@adacore.com>
105
106 PR build/24937:
107 * stap-probe.c (class stap_static_probe_ops): Add constructor.
108
109 2020-01-06 Andrew Burgess <andrew.burgess@embecosm.com>
110
111 * stack.c (print_frame_info): Move disassemble_next_line code
112 inside source_print block.
113
114 2020-01-01 Joel Brobecker <brobecker@adacore.com>
115
116 * gdbarch.sh: Update copyright year range of generated files.
117
118 2020-01-01 Joel Brobecker <brobecker@adacore.com>
119
120 Update copyright year range in all the GDB files automatically
121 handled by our copyright.py script.
122
123 2020-01-01 Joel Brobecker <brobecker@adacore.com>
124
125 * copyright.py: Convert to Python 3.
126
127 2020-01-01 Joel Brobecker <brobecker@adacore.com>
128
129 * copyright.py: Adapt after move of gnulib directory from gdb
130 directory to toplevel directory.
131
132 2020-01-01 Joel Brobecker <brobecker@adacore.com>
133
134 * copyright.py (main): Exit if run from the wrong directory.
135
136 2020-01-01 Joel Brobecker <brobecker@adacore.com>
137
138 * top.c (print_gdb_version): Change copyright year to 2020.
139
140 2019-12-26 Christian Biesinger <cbiesinger@google.com>
141
142 * configure: Regenerate.
143 * configure.ac: Quote variable arguments of test.
144 * gdbsupport/common.m4: Likewise.
145
146 2019-12-21 Eli Zaretskii <eliz@gnu.org>
147
148 * top.c (print_gdb_configuration): Print "--with-xxhash" or
149 "--without-xxhash" according to HAVE_LIBXXHASH.
150
151 2019-12-18 Tom Tromey <tromey@adacore.com>
152
153 PR build/25268:
154 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
155 type on macOS. Add comment.
156
157 2019-12-18 Tom Tromey <tromey@adacore.com>
158
159 PR build/25250:
160 * ui-out.c (ui_out::vmessage): Update.
161 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
162 Rename.
163 (string_field): Update.
164 (signed_field): Update.
165
166 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
167
168 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
169
170 2019-12-11 Joel Brobecker <brobecker@adacore.com>
171
172 * version.in: Set GDB version number to 9.0.90.DATE-git.
173
174 2019-12-11 Joel Brobecker <brobecker@adacore.com>
175
176 GDB 9.0.90 released.
177
178 2019-12-11 Joel Brobecker <brobecker@adacore.com>
179
180 * version.in: Set GDB version number to 9.0.90.
181
182 2019-12-11 Joel Brobecker <brobecker@adacore.com>
183
184 * NEWS: Change "Changes since GDB 8.3" into "Changes in GDB 9".
185
186 2019-12-11 Joel Brobecker <brobecker@adacore.com>
187
188 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
189 * version.in: Bump version to 9.0.90.DATE-git.
190
191 2019-12-11 Tom Tromey <tromey@adacore.com>
192
193 PR build/25268:
194 * gdbsupport/thread-pool.c (set_thread_name): New function.
195 (thread_pool::set_thread_count): Don't call pthread_setname_np.
196 (thread_pool::thread_function): Call set_thread_name.
197
198 2019-12-11 Tom Tromey <tromey@adacore.com>
199
200 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
201 bfd_get_signed_8.
202
203 2019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
204
205 * NEWS: Document -raw-values option and the related setting commands.
206 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
207 only set it on when /r is given.
208 * valprint.c (value_print_option_defs): New element raw-values.
209 * Makefile.in: Add the new file.
210
211 2019-12-10 Christian Biesinger <cbiesinger@google.com>
212
213 * gdbsupport/safe-strerror.c: Supress the unused function warning
214 for select_strerror_r.
215
216 2019-12-10 Christian Biesinger <cbiesinger@google.com>
217
218 * config.in: Regenerate.
219 * configure: Regenerate.
220 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
221 safe_strerror instead of strerror.
222 * gdbsupport/common.m4: Don't check for strerror.
223 * gdbsupport/safe-strerror.c: Support both the glibc version
224 of strerror_r and the XSI version.
225
226 2019-12-10 Tom Tromey <tromey@adacore.com>
227
228 * ada-typeprint.c (print_choices): Use a single "?".
229 (print_variant_part): Print "?" if the discriminant name
230 is not known.
231
232 2019-12-10 George Barrett <bob@bob131.so>
233
234 Fix scripted probe breakpoints.
235 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
236 declaration forward.
237 (breakpoint_ops_for_event_location_type)
238 (breakpoint_ops_for_event_location): Add function definitions.
239 (break_command_1, trace_command): Use
240 breakpoint_ops_for_event_location.
241 * breakpoint.h (breakpoint_ops_for_event_location): Add function
242 declarations.
243 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
244 breakpoint_ops_for_event_location.
245 * python/py-breakpoint.c (bppy_init): Use
246 breakpoint_ops_for_event_location.
247
248 2019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
249
250 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
251 when ranking an lvalue argument for an rvalue parameter.
252
253 2019-12-08 Wataru Ashihara <wataash@wataash.com>
254
255 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
256 template argument for scoped_restore_tmpl from bool to int.
257
258 2019-12-07 Keith Seitz <keiths@redhat.com>
259
260 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
261 (build_id_to_debug_bfd): Make static, rewriting to use
262 build_id_to_bfd_suffix.
263 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
264 adding `suffix' parameter. Append SUFFIX to file names
265 when searching for matching files.
266 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
267 (build_id_to_exec_bfd): Likewise.
268 * build-id.h (build_id_to_debug_bfd): Clarify that function
269 searches for BFD of debug info file.
270 (build_id_to_exec_bfd): Declare.
271 * corelow.c: Include build-id.h.
272 (locate_exec_from_corefile_build_id): New function.
273 (core_target_open): If no executable BFD is found,
274 search for a core file BFD using build-id.
275
276 2019-12-06 Christian Biesinger <cbiesinger@google.com>
277
278 * bcache.c: Put in namespace gdb.
279 * bcache.h: Likewise.
280 * gdbtypes.c (check_types_worklist): Update.
281 (types_deeply_equal): Update.
282 * macrotab.c (struct macro_table) <bcache>: Update.
283 (new_macro_table): Update.
284 * macrotab.h (struct bcache): Put this forward declaration
285 inside namespace gdb.
286 (new_macro_table): Update.
287 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
288 Update.
289 <macro_cache>: Update.
290 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
291
292 2019-12-06 Tom de Vries <tdevries@suse.de>
293
294 PR symtab/24971
295 * block.c (best_symbol, better_symbol): New function.
296 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
297 decl.
298
299 2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
300
301 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
302 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
303 for ranking see-through reference cases.
304
305 2019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
306 * stack.c (faas_command): Check a command is provided.
307 * thread.c (taas_command, tfaas_command): Likewise.
308
309 2019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
310 * inferior.c (prune_inferiors): Only call delete_inferior,
311 Do not modify the inferior list.
312
313 2019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
314
315 * c-exp.y: Update calls to lookup_typename,
316 lookup_signed_typename and lookup_unsigned_typename.
317 * c-lang.c (evaluate_subexp_c): Likewise.
318 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
319 Likewise.
320 * eval.c (binop_promote): Likewise.
321 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
322 (lookup_unsigned_typename): Likewise.
323 (lookup_signed_typename): Likewise.
324 * gdbtypes.h (lookup_unsigned_typename): Likewise.
325 (lookup_signed_typename): Likewise.
326 (lookup_typename): Likewise.
327 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
328 lookup_typename, lookup_signed_typename,
329 lookup_unsigned_typename.
330 * m2-exp.y: Likewise.
331 * printcmd.c (printf_wide_c_string): Likewise.
332 (ui_printf): Likewise.
333 * python/py-type.c (typy_lookup_typename): Likewise.
334 * python/py-xmethods.c (python_xmethod_worker::invoke):
335 Likewise.
336 * rust-exp.y: Likewise.
337
338 2019-12-04 Christian Biesinger <cbiesinger@google.com>
339
340 * configure.nat (obsd64): Add missing files x86-nat.o and
341 nat/x86-dregs.o.
342
343 2019-12-04 Tom Tromey <tom@tromey.com>
344
345 * valprint.c (val_print_string): Use metadata_style.
346 * go-valprint.c (print_go_string): Use metadata style.
347 * p-valprint.c (pascal_object_print_static_field): Use metadata
348 style.
349 * cp-valprint.c (cp_print_static_field): Use metadata style.
350
351 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
352 Chris January <chris.january@arm.com>
353
354 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
355 tokens.
356 (typebase): New patterns for complex, single/double precision, and
357 single/double complex.
358 (f77_keywords): Change token for complex keyword, and add single,
359 double, and precision keywords.
360
361 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
362
363 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
364 "info io_registers".
365
366 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
367
368 * regcache.c (cooked_read_test): Initialize thread list of
369 mock_inferior.
370
371 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
372
373 * aarch64-linux-tdep.c: Remove includes.
374
375 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
376
377 * aarch64-tdep.c: Remove includes.
378
379 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
380
381 * filtered-iterator.h (filtered_iterator) <operator==,
382 operator!=>: Compare wrapped iterators, not wrapped pointers.
383 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
384 unittests/filtered_iterator-selftests.c.
385 * unittests/filtered_iterator-selftests.c: New file.
386
387 2019-12-04 Tom Tromey <tromey@adacore.com>
388
389 * gdbtypes.c (create_range_type): Inherit endianity
390 from base type.
391
392 2019-12-04 Tom Tromey <tromey@adacore.com>
393
394 * ada-lang.c (decode_constrained_packed_array)
395 (ada_value_assign, value_assign_to_component): Update.
396 * dwarf2loc.c (rw_pieced_value, access_memory)
397 (dwarf2_compile_expr_to_ax): Update.
398 * dwarf2read.c (dwarf2_add_field): Update.
399 * eval.c (evaluate_subexp_standard): Update.
400 * gdbarch.c, gdbarch.h: Rebuild.
401 * gdbarch.sh (bits_big_endian): Remove.
402 * gdbtypes.h (union field_location): Update comment.
403 * target-descriptions.c (make_gdb_type): Update.
404 * valarith.c (value_bit_index): Update.
405 * value.c (struct value) <bitpos>: Update comment.
406 (unpack_bits_as_long, modify_field): Update.
407 * value.h (value_bitpos): Update comment.
408
409 2019-12-04 Tom Tromey <tromey@adacore.com>
410
411 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
412 endian-ness.
413
414 2019-12-04 Tom Tromey <tromey@adacore.com>
415
416 * dwarf2read.c (dwarf2_init_float_type)
417 (dwarf2_init_complex_target_type): Add byte_order parameter.
418 (read_base_type): Compute byte order earlier.
419 * gdbtypes.c (init_float_type): Add byte_order parameter.
420 * gdbtypes.h (init_float_type): Add byte_order parameter.
421
422 2019-12-04 Tom Tromey <tromey@adacore.com>
423
424 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
425
426 2019-12-04 Tom Tromey <tromey@adacore.com>
427
428 * dwarf2read.c (process_structure_scope): Initialize
429 "discr_offset".
430
431 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
432
433 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
434 add it into the search spec.
435 (parse_max_results_option): New function.
436 (mi_info_functions_or_variables): Parse -max-results flag and pass
437 it to mi_symbol_info.
438 (mi_cmd_symbol_info_modules): Likewise.
439 (mi_cmd_symbol_info_types): Likewise.
440 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
441 return type to bool, change result container into a set, and don't
442 add new results if we have enough already.
443 (global_symbol_searcher::add_matching_msymbols): Change return
444 type to bool, and don't add new results if we have enough already.
445 (sort_search_symbols_remove_dups): Delete.
446 (global_symbol_searcher::search): Early exit from search loop when
447 we have enough results. Use a std::set to collect the results
448 from calling add_matching_symbols.
449 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
450 member function.
451 (global_symbol_searcher) <m_max_search_results>: New member
452 variable.
453 (global_symbol_searcher) <add_matching_symbols>: Update header
454 comment and change return type to bool.
455 (global_symbol_searcher) <add_matching_msymbols>: Update header
456 comment and change return type to bool.
457
458 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
459
460 * symtab.c (symbol_search::compare_search_syms): Update header
461 comment.
462 (global_symbol_searcher::is_suitable_msymbol): New function.
463 (global_symbol_searcher::expand_symtabs): New function.
464 (global_symbol_searcher::add_matching_symbols): New function.
465 (global_symbol_searcher::add_matching_msymbols): New function.
466 (global_symbol_searcher::search): Move most of the content
467 into the new functions above, and call them as needed.
468 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
469 function.
470 (global_symbol_searcher) <add_matching_symbols>: New member
471 function.
472 (global_symbol_searcher) <add_matching_msymbols>: New member
473 function.
474 (global_symbol_searcher) <is_suitable_msymbol>: New member
475 function.
476
477 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
478
479 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
480 -symbol-info-module-variables entries.
481 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
482 (mi_cmd_symbol_info_module_variables): Declare.
483 * mi/mi-symbol-cmds.c
484 (module_symbol_search_iterator): New typedef.
485 (output_module_symbols_in_single_module_and_file): New function.
486 (output_module_symbols_in_single_module): New function.
487 (mi_info_module_functions_or_variables): New function.
488 (mi_cmd_symbol_info_module_functions): New function.
489 (mi_cmd_symbol_info_module_variables): New function.
490 * NEWS: Mention new MI command.
491
492 2019-12-03 Christian Biesinger <cbiesinger@google.com>
493
494 * bcache.c (hash): Remove.
495 (hash_continue): Remove.
496 * bcache.h (hash): Remove.
497 (hash_continue): Remove.
498 (struct bcache) <ctor>: Update.
499 * psymtab.c (psymbol_hash): Update.
500 * stabsread.c (hashname): Update.
501 * utils.h (fast_hash): Add an argument for a start value,
502 defaulting to zero.
503
504 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
505 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
506 (destroy_block_symbol_cache): New function.
507 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
508 (resize_symbol_cache): Likewise.
509
510 2019-12-02 Tom Tromey <tom@tromey.com>
511
512 * unittests/tui-selftests.c (run_tests): Make conditional.
513 (_initialize_tui_selftest): Make conditional.
514
515 2019-12-02 Christian Biesinger <cbiesinger@google.com>
516
517 * aix-thread.c (debug_aix_thread): Change type to bool.
518
519 2019-12-02 Luis Machado <luis.machado@linaro.org>
520
521 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
522
523 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
524
525 * dwarf2read.c (read_tag_string_type): Read the fields required to
526 make a dynamic string, and possibly create a dynamic range for the
527 string.
528 (attr_to_dynamic_prop): Setup is_reference based on the type of
529 attribute being processed.
530 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
531 (resolve_dynamic_array): Rename to...
532 (resolve_dynamic_array_or_string): ...this, update header comment,
533 and accept TYPE_CODE_STRING.
534 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
535
536 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
537
538 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
539 of its implementation from...
540 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
541 the new function.
542
543 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
544
545 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
546 create a range with stride where appropriate.
547 * f-valprint.c: Include 'gdbarch.h'.
548 (f77_print_array_1): Take the stride into account when walking the
549 array. Also convert the stride into addressable units.
550 * gdbtypes.c (create_range_type): Initialise the stride to
551 constant zero.
552 (create_range_type_with_stride): New function, initialise the
553 range as normal, and then setup the stride.
554 (has_static_range): Include the stride here. Also change the
555 return type to bool.
556 (create_array_type_with_stride): Consider the range stride if the
557 array isn't given its own stride.
558 (resolve_dynamic_range): Resolve the stride if needed.
559 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
560 (struct range_bounds) <flag_is_byte_stride>: New member variable.
561 (TYPE_BIT_STRIDE): Define.
562 (TYPE_ARRAY_BIT_STRIDE): Define.
563 (create_range_type_with_stride): Declare.
564 * valarith.c (value_subscripted_rvalue): Take range stride into
565 account when walking the array.
566
567 2019-12-01 Tom Tromey <tom@tromey.com>
568
569 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
570 specially.
571
572 2019-12-01 Tom Tromey <tom@tromey.com>
573
574 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
575 \0.
576 * unittests/tui-selftests.c: New file.
577 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
578
579 2019-12-01 Tom Tromey <tom@tromey.com>
580
581 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
582
583 2019-12-01 Tom Tromey <tom@tromey.com>
584
585 * NEWS: Document new settings.
586 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
587 * tui/tui-win.c (_initialize_tui_win): Add border style
588 observers.
589 * tui/tui-io.h (tui_apply_style): Declare.
590 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
591 longer static.
592 (apply_ansi_escape, tui_set_reverse_mode): Update.
593 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
594 Add "skip_intensity" parameter.
595 <changed>: New member.
596 <do_set_value>: Declare.
597 (tui_border_style, tui_active_border_style): Declare.
598 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
599 globals.
600 (cli_style_option): Initialize "changed".
601 (cli_style_option::do_set_value): New function.
602 (cli_style_option::add_setshow_commands): Add "skip_intensity"
603 parameter. Update.
604 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
605 (_initialize_cli_style): Update. Create TUI border style
606 commands.
607
608 2019-12-01 Tom Tromey <tom@tromey.com>
609
610 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
611 parameter.
612 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
613 parameter.
614 * tui/tui-win.h (compact_source): Declare.
615 * tui/tui-win.c (compact_source): New global.
616 (tui_set_compact_source, tui_show_compact_source): New functions.
617 (_initialize_tui_win): Add "compact-source" setting.
618 * tui/tui-source.c (tui_source_window::set_contents): Handle
619 compact_source setting.
620 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
621 * NEWS: Document new setting.
622
623 2019-11-30 Tom Tromey <tom@tromey.com>
624
625 * dwarf2read.c (dwarf2_add_field): Include field offset when
626 computing variant part length.
627
628 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
629 * NEWS: Mention define-prefix. Tell that command names can now
630 contain a . character.
631
632 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
633
634 * command.h (valid_cmd_char_p): Declare.
635 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
636 the check of valid command char.
637 (find_command_name_length, valid_user_defined_cmd_name_p): Use
638 valid_cmd_char_p.
639 * cli/cli-script.c (validate_comname): Likewise.
640 * completer.c (gdb_completer_command_word_break_characters):
641 Do not remove . from the word break char, update comments.
642 (complete_line_internal_1): Use valid_cmd_char_p.
643 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
644 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
645
646 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
647
648 * cli/cli-script.c (do_define_command): Ensure a redefined
649 prefix command is kept as a prefix command.
650 (define_prefix_command): New function.
651 (show_user_1): Report user defined prefixes.
652 (_initialize_cli_script): Create the new 'define-prefix' command.
653 Add completers for 'define' and 'document'.
654 * top.c (execute_command): If command is a user-defined prefix only
655 command, report the list of commands for this prefix command.
656
657 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
658
659 * valops.c (find_oload_champ): Improve debug output.
660
661 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
662
663 * valops.c (find_oload_champ): Print part of debug messages
664 before the badness vector is std::move'd.
665
666 2019-11-28 Tom Tromey <tom@tromey.com>
667
668 * value.c (creal_internal_fn): Fix comment.
669
670 2019-11-28 Tom Tromey <tom@tromey.com>
671
672 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
673 flag_bound_evaluated>: Now unsigned.
674
675 2019-11-28 Tom Tromey <tom@tromey.com>
676
677 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
678 declare.
679
680 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
681
682 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
683 debug output.
684 * jit.c (jit_unregister_code): Add debug print to match
685 `jit_register_code`.
686
687 2019-11-27 Christian Biesinger <cbiesinger@google.com>
688
689 * NEWS: Mention the new multithreaded symbol loading.
690
691 2019-11-27 Christian Biesinger <cbiesinger@google.com>
692
693 * maint.c (n_worker_threads): Default to 0.
694 (worker_threads_disabled): New function.
695 * maint.h (worker_threads_disabled): New function.
696 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
697 here if worker_threads_disabled () is true.
698 (minimal_symbol_reader::install): Skip all threading if
699 worker_threads_disabled () is true.
700
701 2019-11-27 Christian Biesinger <cbiesinger@google.com>
702
703 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
704 hash code if possible.
705 (add_minsym_to_demangled_hash_table): Likewise.
706 (minimal_symbol_reader::install): Compute the hash codes for msymbol
707 on the background thread.
708 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
709 Add these fields.
710
711 2019-11-27 Christian Biesinger <cbiesinger@google.com>
712
713 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
714 of the mangled name on the background thread.
715 * symtab.c (symbol_set_names): Allow passing in the hash of the
716 linkage_name.
717 * symtab.h (symbol_set_names): Likewise.
718
719 2019-11-27 Kevin Buettner <kevinb@redhat.com>
720
721 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
722 physnames are computed for inherited DIEs.
723
724 2019-11-27 Tom Tromey <tromey@adacore.com>
725
726 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
727 backslashes.
728 * cp-support.c: Remove unnecessary backslashes.
729
730 2019-11-27 Christian Biesinger <cbiesinger@google.com>
731
732 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
733 with sym->set_linkage_name.
734 * coffread.c (coff_read_enum_type): Likewise.
735 * mdebugread.c (parse_symbol): Likewise.
736 * stabsread.c (patch_block_stabs): Likewise.
737 (define_symbol): Likewise.
738 (read_enum_type): Likewise.
739 (common_block_end): Likewise.
740 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
741 function.
742 (SYMBOL_SET_LINKAGE_NAME): Remove.
743 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
744 with sym->set_linkage_name.
745
746 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
747
748 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
749 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
750 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
751 * NEWS: Mention new MI command.
752
753 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
754
755 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
756 '-symbol-info-types', and '-symbol-info-variables'.
757 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
758 (mi_cmd_symbol_info_types): Declare.
759 (mi_cmd_symbol_info_variables): Declare.
760 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
761 (output_debug_symbol): New function.
762 (output_nondebug_symbol): New function.
763 (mi_symbol_info): New function.
764 (mi_info_functions_or_variables): New function.
765 (mi_cmd_symbol_info_functions): New function.
766 (mi_cmd_symbol_info_types): New function.
767 (mi_cmd_symbol_info_variables): New function.
768 * NEWS: Mention new commands.
769
770 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
771
772 * symtab.c (symbol_to_info_string): New function, most content
773 moved from print_symbol_info, but updated to return a std::string.
774 (print_symbol_info): Update to use symbol_to_info_string and print
775 returned string.
776 * symtab.h (symbol_to_info_string): Declare new function.
777
778 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
779
780 * python/python.c (gdbpy_rbreak): Convert to using
781 global_symbol_searcher.
782 * symtab.c (file_matches): Convert return type to bool, change
783 file list to std::vector, update header comment.
784 (search_symbols): Rename to...
785 (global_symbol_searcher::search): ...this and update now its
786 a member function of global_symbol_searcher. Take account of the
787 changes to file_matches.
788 (symtab_symbol_info): Convert to using global_symbol_searcher.
789 (rbreak_command): Likewise.
790 (search_module_symbols): Likewise.
791 * symtab.h (enum symbol_search): Update comment.
792 (search_symbols): Remove declaration.
793 (class global_symbol_searcher): New class.
794
795 2019-11-26 Tom Tromey <tromey@adacore.com>
796
797 * cp-support.c (_initialize_cp_support): Conditionally initialize
798 gdb_demangle_attempt_core_dump.
799
800 2019-11-26 Tom Tromey <tom@tromey.com>
801
802 * python/py-function.c (fnpy_init): Update.
803 * value.h (add_internal_function): Adjust declaration.
804 * value.c (function_destroyer): Remove.
805 (do_add_internal_function): Don't set destroyer or copy name.
806 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
807 Set name_allocated.
808 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
809 (cmdpy_init): Set name_allocated.
810 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
811 member.
812 (~cmd_list_element): Free "name" if needed.
813
814 2019-11-26 Tom Tromey <tom@tromey.com>
815
816 * value.h (add_internal_function): Add new overload. Move
817 documentation from value.h.
818 * value.c (do_add_internal_function): New function.
819 (add_internal_function): Use it. Add new overload.
820 (function_destroyer): Don't free doc.
821 * python/py-function.c (fnpy_init): Update.
822
823 2019-11-26 Tom Tromey <tom@tromey.com>
824
825 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
826 (cmdpy_init): Set "doc_allocated".
827
828 2019-11-26 Tom Tromey <tom@tromey.com>
829
830 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
831 name of worker thread.
832 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
833 pthread_setname_np.
834 * configure, config.in: Rebuild.
835
836 2019-11-26 Tom Tromey <tom@tromey.com>
837
838 * python/python.c (class gdbpy_gil): New.
839 (struct gdbpy_event): Add constructor, destructor, operator().
840 (gdbpy_post_event): Use run_on_main_thread.
841 (gdbpy_initialize_events): Remove.
842 (do_start_initialization): Update.
843
844 2019-11-26 Tom Tromey <tom@tromey.com>
845
846 * NEWS: Add entry.
847 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
848 commands. Call update_thread_pool_size.
849 (update_thread_pool_size, maintenance_set_worker_threads): New
850 functions.
851 (n_worker_threads): New global.
852
853 2019-11-26 Christian Biesinger <cbiesinger@google.com>
854 Tom Tromey <tom@tromey.com>
855
856 * minsyms.c (minimal_symbol_reader::install): Use
857 parallel_for_each.
858 * gdbsupport/parallel-for.h: New file.
859 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
860
861 2019-11-26 Christian Biesinger <cbiesinger@google.com>
862 Tom Tromey <tom@tromey.com>
863
864 * gdbsupport/thread-pool.h: New file.
865 * gdbsupport/thread-pool.c: New file.
866 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
867 (HFILES_NO_SRCDIR): Add thread-pool.h.
868
869 2019-11-26 Tom Tromey <tom@tromey.com>
870
871 * event-top.h (thread_local_segv_handler): Declare.
872 * event-top.c (thread_local_segv_handler): New global.
873 (install_handle_sigsegv, handle_sigsegv): New functions.
874 (async_init_signals): Install SIGSEGV handler.
875 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
876 thread-local.
877 (report_failed_demangle): New function.
878 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
879 handler-setting code, instead use segv_handler. Run warning code
880 on main thread.
881
882 2019-11-26 Tom Tromey <tom@tromey.com>
883
884 * run-on-main-thread.c: New file.
885 * run-on-main-thread.h: New file.
886 * unittests/main-thread-selftests.c: New file.
887 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
888 main-thread-selftests.c.
889 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
890 (COMMON_SFILES): Add run-on-main-thread.c.
891
892 2019-11-26 Tom Tromey <tom@tromey.com>
893
894 * main.c (setup_alternate_signal_stack): Remove.
895 (captured_main_1): Use gdb::alternate_signal_stack.
896 * gdbsupport/alt-stack.h: New file.
897
898 2019-11-26 Tom Tromey <tom@tromey.com>
899
900 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
901 Remove comment.
902 (save_original_signals_state, restore_original_signals_state): Use
903 gdb_sigmask.
904 * linux-nat.c (block_child_signals, restore_child_signals_mask)
905 (_initialize_linux_nat): Use gdb_sigmask.
906 * guile/guile.c (_initialize_guile): Use block_signals.
907 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
908 * gdbsupport/gdb-sigmask.h: New file.
909 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
910 * cp-support.c (gdb_demangle): Use gdb_sigmask.
911 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
912 pthread_sigmask.
913 * configure, config.in: Rebuild.
914 * gdbsupport/block-signals.h: New file.
915
916 2019-11-26 Tom Tromey <tom@tromey.com>
917
918 * acinclude.m4: Include ax_pthread.m4.
919 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
920 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
921 (CLIBS): Use PTHREAD_LIBS.
922 (aclocal_m4_deps): Add ax_pthread.m4.
923 * config.in, configure: Rebuild.
924 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
925
926 2019-11-26 Tom Tromey <tom@tromey.com>
927
928 * symtab.h (struct minimal_symbol) <name_set>: New member.
929 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
930 Don't call symbol_set_names.
931 (minimal_symbol_reader::install): Call symbol_set_names.
932
933 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
934
935 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
936 restore_active_ext_lang, as GIL is needed for (indirectly)
937 called PyOS_InterruptOccurred.
938
939 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
940
941 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
942 definition.
943
944 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
945
946 * remote-sim.c (simulator_command): Make static, remove
947 declaration.
948
949 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
950
951 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
952 static.
953 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
954 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
955 (main): Likewise.
956 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
957 (main): Likewise.
958 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
959 (main): Likewise.
960 * unittests/basic_string_view/element_access/char/1.cc (test01):
961 Likewise.
962 (main): Likewise.
963 * unittests/basic_string_view/element_access/char/empty.cc (main):
964 Likewise.
965 * unittests/basic_string_view/element_access/char/front_back.cc
966 (test01): Likewise.
967 (main): Likewise.
968 * unittests/basic_string_view/inserters/char/2.cc (test05):
969 Likewise.
970 (main): Likewise.
971 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
972 (test01): Likewise.
973 (main): Likewise.
974 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
975 (test01): Likewise.
976 (main): Likewise.
977 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
978 Likewise.
979 * unittests/basic_string_view/operations/compare/char/1.cc
980 (test01): Likewise.
981 (main): Likewise.
982 * unittests/basic_string_view/operations/compare/char/13650.cc
983 (test01): Likewise.
984 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
985 Likewise.
986 (main): Likewise.
987 * unittests/basic_string_view/operations/data/char/1.cc (test01):
988 Likewise.
989 (main): Likewise.
990 * unittests/basic_string_view/operations/find/char/1.cc (test01):
991 Likewise.
992 (main): Likewise.
993 * unittests/basic_string_view/operations/find/char/2.cc (test02):
994 Likewise.
995 (main): Likewise.
996 * unittests/basic_string_view/operations/find/char/3.cc (test03):
997 Likewise.
998 (main): Likewise.
999 * unittests/basic_string_view/operations/find/char/4.cc (main):
1000 Likewise.
1001 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1002 Likewise.
1003 (main): Likewise.
1004 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1005 Likewise.
1006 (main): Likewise.
1007 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1008 Likewise.
1009 (main): Likewise.
1010 * unittests/basic_string_view/operations/substr/char/1.cc
1011 (test01): Likewise.
1012 (main): Likewise.
1013 * unittests/basic_string_view/operators/char/2.cc (main):
1014 Likewise.
1015 * unittests/optional/assignment/1.cc (test): Likewise.
1016 * unittests/optional/assignment/2.cc (test): Likewise.
1017 * unittests/optional/assignment/3.cc (test): Likewise.
1018 * unittests/optional/assignment/4.cc (test): Likewise.
1019 * unittests/optional/assignment/5.cc (test): Likewise.
1020 * unittests/optional/assignment/6.cc (test): Likewise.
1021 * unittests/optional/assignment/7.cc (test): Likewise.
1022 * unittests/optional/cons/copy.cc (test): Likewise.
1023 * unittests/optional/cons/default.cc (test): Likewise.
1024 * unittests/optional/cons/move.cc (test): Likewise.
1025 * unittests/optional/cons/value.cc (test): Likewise.
1026 * unittests/optional/in_place.cc (test): Likewise.
1027 * unittests/optional/observers/1.cc (test): Likewise.
1028 * unittests/optional/observers/2.cc (test): Likewise.
1029
1030 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1031
1032 * tui-win.h (tui_set_var_cmd): Remove.
1033 * tui-win.c (tui_set_var_cmd): Make static.
1034
1035 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1036
1037 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1038 rbreak_command_wrapper): Remove.
1039 * symtab.c (rbreak_command_wrapper): Remove.
1040
1041 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1042
1043 * inferior.h (info_terminal_command): Remove declaration.
1044 * inflow.c (info_terminal_command): Make static.
1045
1046 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1047
1048 * inferior.c (exit_inferior_silent): Remove.
1049
1050 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1051
1052 * dictionary.c (dict_empty, mdict_empty): Remove.
1053 * dictionary.c (mdict_empty): Remove.
1054
1055 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1056
1057 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1058 (arc_insn_get_memory_offset): Likewise.
1059 (arc_insn_dump): Likewise.
1060 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1061 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1062 * dictionary.c (dict_iterator_next): Likewise.
1063 (dict_iter_match_first): Likewise.
1064 (dict_iter_match_next): Likewise.
1065 * f-lang.c (evaluate_subexp_f): Likewise.
1066 * hppa-tdep.c (hppa_read_pc): Likewise.
1067 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1068 * parse.c (write_exp_elt_msym): Likewise.
1069 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1070 * remote.c (remote_packet_size): Likewise.
1071 (remote_notif_stop_parse): Likewise.
1072 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1073 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1074 * source.c (prepare_path_for_appending): Likewise.
1075 * sparc64-linux-tdep.c
1076 (sparc64_linux_handle_segmentation_fault); Likewise.
1077 * stack.c (frame_selection_by_function_completer): Likewise.
1078
1079 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1080
1081 * completer.c (set_gdb_completion_word_break_characters):
1082 Remove.
1083
1084 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1085
1086 * dwarf-index-write.c: Include dwarf-index-write.h.
1087 * mi/mi-interp.c: Include mi/mi-interp.h.
1088
1089 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1090
1091 * aarch32-tdep.c: Include aarch32-tdep.h.
1092 * aarch32-tdep.h: Forward-declare struct target_desc.
1093
1094 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1095
1096 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1097 strerror.
1098 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1099 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1100
1101 2019-11-25 Tom de Vries <tdevries@suse.de>
1102
1103 * contrib/words.sh: Add -c option.
1104
1105 2019-11-25 Christian Biesinger <cbiesinger@google.com>
1106
1107 * solib.c (solib_find_1): Change int to bool.
1108 (exec_file_find): Change int to bool.
1109 (solib_find): Change int to bool.
1110 (solib_read_symbols): Change int to bool.
1111 (solib_used): Change int to bool.
1112 (solib_add): Change int to bool.
1113 (info_sharedlibrary_command): Change int to bool.
1114 (solib_contains_address_p): Change int to bool.
1115 (solib_keep_data_in_core): Change int to bool.
1116 (in_solib_dynsym_resolve_code): Change int to bool.
1117 (reload_shared_libraries_1): Change int to bool.
1118 (gdb_sysroot_changed): Change int to bool.
1119 * solib.h (solib_read_symbols): Change int to bool.
1120 (solib_contains_address_p): Change int to bool.
1121 (solib_keep_data_in_core): Change int to bool.
1122 (in_solib_dynsym_resolve_code): Change int to bool.
1123 (libpthread_name_p): Change int to bool.
1124
1125 2019-11-25 Luis Machado <luis.machado@linaro.org>
1126
1127 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1128 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1129 (remote_packet_max_chars): New static global.
1130 (show_remote_packet_max_chars): New function.
1131 (remote_target::putpkt_binary): Adjust to use new
1132 remote_packet_max_chars option.
1133 (remote_target::getpkt_or_notif_sane_1): Likewise.
1134 (_initialize_remote): Register new remote-packet-max-chars option.
1135
1136 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
1137
1138 * m68k-linux-nat.c: Include gdbarch.h.
1139
1140 2019-11-24 Tom Tromey <tom@tromey.com>
1141
1142 * symfile.c (read_symbols): Update.
1143 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1144 bool.
1145 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1146 (psym_lookup_symbol, psym_find_last_source_symtab)
1147 (psym_forget_cached_source_info, psym_print_stats)
1148 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1149 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1150 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1151 (psym_find_compunit_symtab_by_address)
1152 (maintenance_print_psymbols, maintenance_info_psymtabs)
1153 (maintenance_check_psymtabs): Update.
1154 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1155 bool.
1156
1157 2019-11-22 Tom Tromey <tom@tromey.com>
1158
1159 * observable.h: Update comments.
1160
1161 2019-11-22 Tom Tromey <tromey@adacore.com>
1162
1163 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1164 (print_ada_task_info): Don't try to fetch thread id if task is not
1165 alive.
1166
1167 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1168
1169 * ada-exp.y: Update.
1170 * ada-lang.c (sort_choices): Update.
1171 (ada_print_symbol_signature): Update.
1172 (resolve_subexp): Update.
1173 (ada_parse_renaming): Update.
1174 (ada_read_renaming_var_value): Update.
1175 (lesseq_defined_than): Update.
1176 (remove_extra_symbols): Update.
1177 (remove_irrelevant_renamings): Update.
1178 (ada_add_block_symbols): Update.
1179 (ada_collect_symbol_completion_matches): Update.
1180 (ada_is_renaming_symbol): Update.
1181 (aggregate_assign_from_choices): Update.
1182 (ada_evaluate_subexp): Update.
1183 (ada_has_this_exception_support): Update.
1184 (ada_is_non_standard_exception_sym): Update.
1185 (ada_add_exceptions_from_frame): Update.
1186 (ada_add_global_exceptions): Update.
1187 (ada_print_subexp): Update.
1188 * ax-gdb.c (gen_var_ref): Update.
1189 (gen_maybe_namespace_elt): Update.
1190 (gen_expr_for_cast): Update.
1191 (gen_expr): Update.
1192 * block.h: Update.
1193 * blockframe.c (find_pc_partial_function): Update.
1194 * breakpoint.c (print_breakpoint_location): Update.
1195 (update_static_tracepoint): Update.
1196 * btrace.c (ftrace_print_function_name): Update.
1197 (ftrace_function_switched): Update.
1198 * buildsym.c (find_symbol_in_list): Update.
1199 * c-exp.y: Update.
1200 * c-typeprint.c (c_print_typedef): Update.
1201 (c_type_print_template_args): Update.
1202 * cli/cli-cmds.c (edit_command): Update.
1203 (list_command): Update.
1204 (print_sal_location): Update.
1205 * coffread.c (patch_opaque_types): Update.
1206 (process_coff_symbol): Update.
1207 (coff_read_enum_type): Update.
1208 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1209 (convert_one_symbol): Update.
1210 (hash_symname): Update.
1211 (eq_symname): Update.
1212 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1213 * compile/compile-cplus-types.c (debug_print_scope): Update.
1214 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1215 * compile/compile-object-load.c (get_out_value_type): Update.
1216 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1217 (search_symbol_list): Update.
1218 (cp_lookup_symbol_imports_or_template): Update.
1219 * cp-support.c (overload_list_add_symbol): Update.
1220 * ctfread.c (psymtab_to_symtab): Update.
1221 * dbxread.c (cp_set_block_scope): Update.
1222 * dictionary.c (iter_match_first_hashed): Update.
1223 (iter_match_next_hashed): Update.
1224 (insert_symbol_hashed): Update.
1225 (iter_match_next_linear): Update.
1226 * dictionary.h: Update.
1227 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1228 (locexpr_describe_location_piece): Update.
1229 (locexpr_describe_location_1): Update.
1230 (locexpr_generate_c_location): Update.
1231 (loclist_describe_location): Update.
1232 (loclist_generate_c_location): Update.
1233 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1234 (read_func_scope): Update.
1235 (process_enumeration_scope): Update.
1236 (new_symbol): Update.
1237 (dwarf2_const_value): Update.
1238 (dwarf2_symbol_mark_computed): Update.
1239 * eval.c (evaluate_funcall): Update.
1240 (evaluate_subexp_standard): Update.
1241 * expprint.c (print_subexp_standard): Update.
1242 (dump_subexp_body_standard): Update.
1243 * f-valprint.c (info_common_command_for_block): Update.
1244 * findvar.c (get_hosting_frame): Update.
1245 (default_read_var_value): Update.
1246 * go-lang.c (go_symbol_package_name): Update.
1247 * guile/scm-block.c (bkscm_print_block_smob): Update.
1248 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1249 (gdbscm_symbol_name): Update.
1250 (gdbscm_symbol_linkage_name): Update.
1251 (gdbscm_symbol_print_name): Update.
1252 * infcall.c (get_function_name): Update.
1253 * infcmd.c (jump_command): Update.
1254 (finish_command): Update.
1255 * infrun.c (insert_exception_resume_breakpoint): Update.
1256 * linespec.c (canonicalize_linespec): Update.
1257 (create_sals_line_offset): Update.
1258 (convert_linespec_to_sals): Update.
1259 (complete_label): Update.
1260 (find_label_symbols_in_block): Update.
1261 * m2-typeprint.c (m2_print_typedef): Update.
1262 * mdebugread.c (mdebug_reg_to_regnum): Update.
1263 (parse_symbol): Update.
1264 (mylookup_symbol): Update.
1265 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1266 (list_args_or_locals): Update.
1267 * objc-lang.c (compare_selectors): Update.
1268 (info_selectors_command): Update.
1269 (compare_classes): Update.
1270 (info_classes_command): Update.
1271 (find_imps): Update.
1272 * p-typeprint.c (pascal_print_typedef): Update.
1273 * printcmd.c (build_address_symbolic): Update.
1274 (info_address_command): Update.
1275 (print_variable_and_value): Update.
1276 * python/py-framefilter.c (extract_sym): Update.
1277 (py_print_single_arg): Update.
1278 * python/py-symbol.c (sympy_str): Update.
1279 (sympy_get_name): Update.
1280 (sympy_get_linkage_name): Update.
1281 * python/python.c (gdbpy_rbreak): Update.
1282 * record-btrace.c (btrace_get_bfun_name): Update.
1283 (btrace_call_history): Update.
1284 * rust-lang.c (rust_print_typedef): Update.
1285 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1286 * stabsread.c (stab_reg_to_regnum): Update.
1287 (define_symbol): Update.
1288 (read_enum_type): Update.
1289 (common_block_end): Update.
1290 (cleanup_undefined_types_1): Update.
1291 (scan_file_globals): Update.
1292 * stack.c (print_frame_arg): Update.
1293 (print_frame_args): Update.
1294 (find_frame_funname): Update.
1295 (info_frame_command_core): Update.
1296 (iterate_over_block_locals): Update.
1297 (print_block_frame_labels): Update.
1298 (do_print_variable_and_value): Update.
1299 (iterate_over_block_arg_vars): Update.
1300 (return_command): Update.
1301 * symmisc.c (dump_symtab_1): Update.
1302 (print_symbol): Update.
1303 * symtab.c (eq_symbol_entry): Update.
1304 (symbol_cache_dump): Update.
1305 (lookup_language_this): Update.
1306 (find_pc_sect_line): Update.
1307 (skip_prologue_sal): Update.
1308 (symbol_search::compare_search_syms): Update.
1309 (treg_matches_sym_type_name): Update.
1310 (search_symbols): Update.
1311 (print_symbol_info): Update.
1312 (rbreak_command): Update.
1313 (completion_list_add_symbol): Update.
1314 (find_gnu_ifunc): Update.
1315 (get_symbol_address): Update.
1316 (search_module_symbols): Update.
1317 (info_module_subcommand): Update.
1318 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1319 (SYMBOL_LINKAGE_NAME): Remove.
1320 (SYMBOL_DEMANGLED_NAME): Remove.
1321 (SYMBOL_PRINT_NAME): Remove.
1322 (SYMBOL_SEARCH_NAME): Remove.
1323 * tracepoint.c (set_traceframe_context): Update.
1324 (validate_actionline): Update.
1325 (collection_list::collect_symbol): Update.
1326 (encode_actions_1): Update.
1327 (info_scope_command): Update.
1328 (print_one_static_tracepoint_marker): Update.
1329 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1330 * valops.c (address_of_variable): Update.
1331 (find_overload_match): Update.
1332 (find_oload_champ): Update.
1333
1334 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1335
1336 * ada-lang.c (ada_lookup_simple_minsym): Update.
1337 (ada_collect_symbol_completion_matches): Update.
1338 * ada-tasks.c (read_atcb): Update.
1339 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1340 (amd64_windows_skip_trampoline_code): Update.
1341 * arm-tdep.c (skip_prologue_function): Update.
1342 (arm_skip_stack_protector): Update.
1343 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1344 (arm_wince_skip_main_prologue): Update.
1345 * ax-gdb.c (gen_expr): Update.
1346 * block.c (call_site_for_pc): Update.
1347 * blockframe.c (find_pc_partial_function): Update.
1348 * breakpoint.c (set_breakpoint_location_function): Update.
1349 * btrace.c (ftrace_print_function_name): Update.
1350 (ftrace_function_switched): Update.
1351 * c-valprint.c (print_unpacked_pointer): Update.
1352 * coffread.c (coff_symfile_read): Update.
1353 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1354 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1355 * dwarf-index-write.c (write_psymbols): Update.
1356 * dwarf2loc.c (call_site_to_target_addr): Update.
1357 (func_verify_no_selftailcall): Update.
1358 (tailcall_dump): Update.
1359 (call_site_find_chain_1): Update.
1360 (dwarf_expr_reg_to_entry_parameter): Update.
1361 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1362 * eval.c (evaluate_funcall): Update.
1363 (evaluate_subexp_standard): Update.
1364 (evaluate_subexp_for_sizeof): Update.
1365 * expprint.c (print_subexp_standard): Update.
1366 (dump_subexp_body_standard): Update.
1367 * frame.c (get_prev_frame_always_1): Update.
1368 * frv-tdep.c (frv_skip_main_prologue): Update.
1369 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1370 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1371 (gnuv3_get_typename_from_type_info): Update.
1372 (gnuv3_skip_trampoline): Update.
1373 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1374 * i386-tdep.c (i386_skip_main_prologue): Update.
1375 (i386_pe_skip_trampoline_code): Update.
1376 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1377 * infcall.c (get_function_name): Update.
1378 * linespec.c (minsym_found): Update.
1379 * linux-fork.c (info_checkpoints_command): Update.
1380 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1381 (m32c_m16c_pointer_to_address): Update.
1382 * maint.c (maintenance_translate_address): Update.
1383 * minsyms.c (add_minsym_to_hash_table): Update.
1384 (add_minsym_to_demangled_hash_table): Update.
1385 (lookup_minimal_symbol_mangled): Update.
1386 (lookup_minimal_symbol_demangled): Update.
1387 (lookup_minimal_symbol_linkage): Update.
1388 (lookup_minimal_symbol_text): Update.
1389 (lookup_minimal_symbol_by_pc_name): Update.
1390 (minimal_symbol_is_less_than): Update.
1391 (compact_minimal_symbols): Update.
1392 (build_minimal_symbol_hash_tables): Update.
1393 (find_solib_trampoline_target): Update.
1394 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1395 (mips_skip_pic_trampoline_code): Update.
1396 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1397 * objc-lang.c (info_selectors_command): Update.
1398 (info_classes_command): Update.
1399 (find_methods): Update.
1400 (find_imps): Update.
1401 * p-valprint.c (pascal_val_print): Update.
1402 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1403 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1404 * printcmd.c (build_address_symbolic): Update.
1405 (info_symbol_command): Update.
1406 * psymtab.c (psymbol_name_matches): Update.
1407 (match_partial_symbol): Update.
1408 (lookup_partial_symbol): Update.
1409 (print_partial_symbols): Update.
1410 (sort_pst_symbols): Update.
1411 (maintenance_check_psymtabs): Update.
1412 * python/py-framefilter.c (py_print_frame): Update.
1413 * python/python.c (gdbpy_rbreak): Update.
1414 * record-btrace.c (btrace_get_bfun_name): Update.
1415 (btrace_call_history): Update.
1416 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1417 (rs6000_skip_trampoline_code): Update.
1418 * sol-thread.c (info_cb): Update.
1419 * stabsread.c (scan_file_globals): Update.
1420 * stack.c (find_frame_funname): Update.
1421 (info_frame_command_core): Update.
1422 * symmisc.c (dump_msymbols): Update.
1423 * symtab.c (symbol_natural_name): Rename to..,
1424 (general_symbol_info::natural_name): ...this.
1425 (symbol_demangled_name): Rename to...
1426 (general_symbol_info::demangled_name): ...this.
1427 (symbol_search_name): Rename to...
1428 (general_symbol_info::search_name): ...this.
1429 (symbol_matches_search_name): Update.
1430 (find_pc_sect_line): Update.
1431 (skip_prologue_sal): Update.
1432 (search_symbols): Update.
1433 (print_msymbol_info): Update.
1434 (rbreak_command): Update.
1435 (completion_list_add_msymbol): Update.
1436 (completion_list_objc_symbol): Update.
1437 (get_msymbol_address): Update.
1438 * symtab.h (struct general_symbol_info): Add member functions
1439 natural_name (), linkage_name (), print_name (), demangled_name (),
1440 and search_name ().
1441 (SYMBOL_NATURAL_NAME): Update.
1442 (symbol_natural_name): Move to a member function on general_symbol_info.
1443 (SYMBOL_DEMANGLED_NAME): Update.
1444 (symbol_demangled_name): Move to a member function on
1445 general_symbol_info.
1446 (SYMBOL_SEARCH_NAME): Update.
1447 (symbol_search_name): Move to a member function on general_symbol_info.
1448 (MSYMBOL_NATURAL_NAME): Remove.
1449 (MSYMBOL_LINKAGE_NAME): Remove.
1450 (MSYMBOL_PRINT_NAME): Remove.
1451 (MSYMBOL_DEMANGLED_NAME): Remove.
1452 (MSYMBOL_SEARCH_NAME): Remove.
1453 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1454
1455 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1456
1457 * symtab.c (create_demangled_names_hash): Use per_bfd->
1458 minimal_symbol_count for computing the initial size, if greater
1459 than our default size.
1460
1461 2019-11-22 Tom de Vries <tdevries@suse.de>
1462
1463 * contrib/words.sh: Improve words extraction.
1464
1465 2019-11-22 Tom de Vries <tdevries@suse.de>
1466
1467 * contrib/words.sh: Combine sed invocations.
1468
1469 2019-11-21 Christian Biesinger <cbiesinger@google.com>
1470
1471 * Makefile.in: Update.
1472 * demangle.c: Rename to...
1473 * gdb-demangle.c: ..this.
1474 (is_cplus_marker): Change return type to bool.
1475 (_initialize_demangler): Rename to...
1476 (_initialize_gdb_demangle): ...this.
1477 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1478 * symtab.h (demangle): Remove declaration; instead include
1479 gdb-demangle.h.
1480
1481 2019-11-21 Tom Tromey <tromey@adacore.com>
1482
1483 * gdbsupport/format.c (format_pieces): Parse %I64d.
1484 * unittests/format_pieces-selftests.c (test_windows_formats): New
1485 function.
1486 (run_tests): Call it.
1487
1488 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1489
1490 Byte reverse display of variables with DW_END_big, DW_END_little
1491 (DW_AT_endianity) dwarf attributes if different than the native
1492 byte order.
1493 * ada-lang.c (ada_value_binop):
1494 Use type_byte_order instead of gdbarch_byte_order.
1495 * ada-valprint.c (printstr):
1496 (ada_val_print_string):
1497 * ada-lang.c (value_pointer):
1498 (ada_value_binop):
1499 Use type_byte_order instead of gdbarch_byte_order.
1500 * c-lang.c (c_get_string):
1501 Use type_byte_order instead of gdbarch_byte_order.
1502 * c-valprint.c (c_val_print_array):
1503 Use type_byte_order instead of gdbarch_byte_order.
1504 * cp-valprint.c (cp_print_class_member):
1505 Use type_byte_order instead of gdbarch_byte_order.
1506 * dwarf2loc.c (rw_pieced_value):
1507 Use type_byte_order instead of gdbarch_byte_order.
1508 * dwarf2read.c (read_base_type): Handle DW_END_big,
1509 DW_END_little
1510 * f-lang.c (f_get_encoding):
1511 Use type_byte_order instead of gdbarch_byte_order.
1512 * findvar.c (default_read_var_value):
1513 Use type_byte_order instead of gdbarch_byte_order.
1514 * gdbtypes.c (check_types_equal):
1515 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1516 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1517 and TYPE_ENDIANITY_LITTLE if set.
1518 (type_byte_order): new function.
1519 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1520 (struct main_type) <flag_endianity_not_default>:
1521 New field.
1522 (type_byte_order): New function.
1523 * infcmd.c (default_print_one_register_info):
1524 Use type_byte_order instead of gdbarch_byte_order.
1525 * p-lang.c (pascal_printstr):
1526 Use type_byte_order instead of gdbarch_byte_order.
1527 * p-valprint.c (pascal_val_print):
1528 Use type_byte_order instead of gdbarch_byte_order.
1529 * printcmd.c (print_scalar_formatted):
1530 Use type_byte_order instead of gdbarch_byte_order.
1531 * solib-darwin.c (darwin_current_sos):
1532 Use type_byte_order instead of gdbarch_byte_order.
1533 * solib-svr4.c (solib_svr4_r_ldsomap):
1534 Use type_byte_order instead of gdbarch_byte_order.
1535 * stap-probe.c (stap_modify_semaphore):
1536 Use type_byte_order instead of gdbarch_byte_order.
1537 * target-float.c (target_float_same_format_p):
1538 Use type_byte_order instead of gdbarch_byte_order.
1539 * valarith.c (scalar_binop):
1540 (value_bit_index):
1541 Use type_byte_order instead of gdbarch_byte_order.
1542 * valops.c (value_cast):
1543 Use type_byte_order instead of gdbarch_byte_order.
1544 * valprint.c (generic_emit_char):
1545 (generic_printstr):
1546 (val_print_string):
1547 Use type_byte_order instead of gdbarch_byte_order.
1548 * value.c (unpack_long):
1549 (unpack_bits_as_long):
1550 (unpack_value_bitfield):
1551 (modify_field):
1552 (pack_long):
1553 (pack_unsigned_long):
1554 Use type_byte_order instead of gdbarch_byte_order.
1555 * findvar.c (unsigned_pointer_to_address):
1556 (signed_pointer_to_address):
1557 (unsigned_address_to_pointer):
1558 (address_to_signed_pointer):
1559 (default_read_var_value):
1560 (default_value_from_register):
1561 Use type_byte_order instead of gdbarch_byte_order.
1562 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1563 Use type_byte_order instead of gdbarch_byte_order.
1564 * riscv-tdep.c (riscv_print_one_register_info):
1565 Use type_byte_order instead of gdbarch_byte_order.
1566
1567 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1568
1569 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1570 (current_ui_gdb_stdin_ptr): Likewise.
1571 (current_ui_gdb_stderr_ptr): Likewise.
1572 (current_ui_gdb_stdlog_ptr): Likewise.
1573 (current_ui_current_uiout_ptr): Likewise.
1574 (gen_ret_current_ui_field_ptr): Remove.
1575
1576 2019-11-21 Tom de Vries <tdevries@suse.de>
1577
1578 PR gdb/24956
1579 * cli/cli-script.c (execute_control_command): Only switch to
1580 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1581
1582 2019-11-19 Tom Tromey <tom@tromey.com>
1583
1584 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1585 Now static. Change type of "name".
1586 (tui_set_win_height_command): Don't copy "arg".
1587 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1588 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1589
1590 2019-11-19 Ali Tamur <tamur@google.com>
1591
1592 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1593 "if (attr != nullptr)".
1594 (dwarf2_find_base_address): Likewise.
1595 (dwarf2_build_include_psymtabs): Likewise.
1596 (read_cutu_die_from_dwo): Likewise.
1597 (read_func_scope): Likewise.
1598 (read_call_site_scope): Likewise.
1599 (dwarf2_get_pc_bounds): Likewise.
1600 (dwarf2_record_block_ranges): Likewise.
1601 (dwarf2_add_field): Likewise.
1602 (dwarf2_add_member_fn): Likewise.
1603 (read_structure_type): Likewise.
1604 (read_enumeration_type): Likewise.
1605 (read_array_type): Likewise.
1606 (read_array_order): Likewise.
1607 (read_set_type): Likewise.
1608 (read_common_block): Likewise.
1609 (read_tag_reference_type): Likewise.
1610 (read_tag_string_type): Likewise.
1611 (read_subroutine_type): Likewise.
1612 (read_base_type): Likewise.
1613 (read_subrange_type): Likewise.
1614 (new_symbol): Likewise.
1615 (prepare_one_comp_unit): Likewise.
1616
1617 2019-11-19 Tom Tromey <tromey@adacore.com>
1618
1619 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1620 result in error when DebugActiveProcess fails.
1621
1622 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1623 Pedro Alves <palves@redhat.com>
1624
1625 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1626 * target.c (target_stack::push): Call 'unpush' if there's a
1627 target on top of the stack.
1628
1629 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1630
1631 * python/py-block.c (blpy_dealloc): Call tp_free.
1632 (blpy_block_syms_dealloc): Likewise.
1633 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1634 * python/py-inferior.c (infpy_dealloc): Likewise.
1635 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1636 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1637 * python/py-symbol.c (sympy_dealloc): Likewise.
1638 * python/py-symtab.c (stpy_dealloc): Likewise.
1639 * python/py-type.c (typy_iterator_dealloc): Likewise.
1640
1641 2019-11-18 Christian Biesinger <cbiesinger@google.com>
1642
1643 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1644 constructor instead of using a class initializer.
1645
1646 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1647
1648 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1649 * configure: Regenerate.
1650 * configure.ac: Don't source common.host.
1651 * gdbsupport/common.host: Remove.
1652 * gdbsupport/mingw-strerror.c: Remove.
1653 * gdbsupport/posix-strerror.c: Rename to...
1654 * gdbsupport/safe-strerror.c: ...this.
1655
1656 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1657
1658 * maint.c (scoped_command_stats::print_time): Use localtime_r
1659 instead of localtime (provided through gnulib if necessary).
1660 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1661 of ctime.
1662
1663 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1664
1665 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1666 avoid compile errors.
1667
1668 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1669
1670 * config.in: Regenerate.
1671 * configure: Regenerate.
1672 * gdbsupport/common.m4: No longer check for strerror_r.
1673 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1674 POSIX version of strerror_r, now that gnulib provides it if
1675 necessary.
1676
1677 2019-11-14 Christian Biesinger <cbiesinger@google.com>
1678
1679 * README (`configure' options): Update.
1680
1681 2019-11-14 Tom Tromey <tromey@adacore.com>
1682
1683 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1684 expected type for the RHS if the LHS is a convenience variable.
1685
1686 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1687
1688 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1689 Provide explicit default and copy constructor.
1690
1691 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1692
1693 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1694 only call Py_INCREF (newbp) in the bppy_pending_object case.
1695
1696 2019-11-13 Tom Tromey <tromey@adacore.com>
1697
1698 PR build/25182:
1699 * psympriv.h (partial_symbol): Remove static assert.
1700 * symtab.h (general_symbol_info, symbol): Remove static assert.
1701
1702 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1703
1704 * gdbsupport/format.c (format_pieces::format_pieces): Support
1705 printf 'z' size modifier.
1706 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1707 * printcmd.c (ui_printf): Handle size_t_arg.
1708 * ui-out.c (ui_out::vmessage): Likewise.
1709 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1710 function.
1711 (run_tests): Call test_format_int_sizes.
1712
1713 2019-11-12 Christian Biesinger <cbiesinger@google.com>
1714
1715 * ada-exp.y (write_ambiguous_var): Update.
1716 * buildsym.c (add_symbol_to_list): Update.
1717 * dwarf2read.c (read_variable): Update.
1718 (new_symbol): Update.
1719 * jit.c (finalize_symtab): Update.
1720 * language.c (language_alloc_type_symbol): Update.
1721 * symtab.c (fixup_symbol_section): Update.
1722 (initialize_objfile_symbol_1): Move code to...
1723 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1724 (allocate_symbol): Update.
1725 (allocate_template_symbol): Update.
1726 (get_symbol_address): Update.
1727 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1728 of having as a field, and add a constructor.
1729 (SYMBOL_VALUE): Update.
1730 (SYMBOL_VALUE_ADDRESS): Update.
1731 (SET_SYMBOL_VALUE_ADDRESS): Update.
1732 (SYMBOL_VALUE_BYTES): Update.
1733 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1734 (SYMBOL_BLOCK_VALUE): Update.
1735 (SYMBOL_VALUE_CHAIN): Update.
1736 (SYMBOL_LANGUAGE): Update.
1737 (SYMBOL_SECTION): Update.
1738 (SYMBOL_OBJ_SECTION): Update.
1739 (SYMBOL_SET_LANGUAGE): Update.
1740 (SYMBOL_SET_LINKAGE_NAME): Update.
1741 (SYMBOL_SET_NAMES): Update.
1742 (SYMBOL_NATURAL_NAME): Update.
1743 (SYMBOL_LINKAGE_NAME): Update.
1744 (SYMBOL_DEMANGLED_NAME): Update.
1745 (SYMBOL_SEARCH_NAME): Update.
1746 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1747 (struct symbol): Update.
1748 (struct template_symbol): Update.
1749 (struct rust_vtable_symbol): Update.
1750 * xcoffread.c (SYMBOL_DUP): Update.
1751
1752 2019-11-12 Tom Tromey <tom@tromey.com>
1753
1754 * tui/tui-layout.c (show_layout): Set current_layout.
1755 (show_source_disasm_command, show_data)
1756 (show_source_or_disasm_and_command): Don't set current_layout.
1757
1758 2019-11-12 Tom Tromey <tom@tromey.com>
1759
1760 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1761
1762 2019-11-12 Tom Tromey <tom@tromey.com>
1763
1764 * tui/tui-win.c (resize_message): New global.
1765 (show_tui_resize_message): New function.
1766 (tui_async_resize_screen): Print message if requested.
1767 (_initialize_tui_win): Add tui-resize-message setting.
1768 * NEWS: Add entry for new commands.
1769
1770 2019-11-11 Tom Tromey <tom@tromey.com>
1771
1772 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1773 functions.
1774
1775 2019-11-11 Christian Biesinger <cbiesinger@google.com>
1776
1777 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1778
1779 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1780
1781 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1782 function.
1783 * python/python-internal.h (gdbpy_lookup_static_symbols):
1784 Declare new function.
1785 * python/python.c (python_GdbMethods): Add
1786 gdb.lookup_static_symbols method.
1787 * NEWS: Mention gdb.lookup_static_symbols.
1788
1789 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1790
1791 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1792 static block of current object file first. Also fix typo in
1793 header comment.
1794
1795 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1796
1797 * stack.c (set_last_displayed_sal): Delete.
1798 (last_displayed_sal_valid): Delete.
1799 (last_displayed_pspace): Delete.
1800 (last_displayed_addr): Delete.
1801 (last_displayed_symtab): Delete.
1802 (last_displayed_line): Delete.
1803 (class last_displayed_symtab_info_type): New.
1804 (last_displayed_symtab_info): New static global variable.
1805 (print_frame_info): Call methods on last_displayed_symtab_info.
1806 (clear_last_displayed_sal): Update header comment, and make use of
1807 last_displayed_symtab_info.
1808 (last_displayed_sal_is_valid): Likewise.
1809 (get_last_displayed_pspace): Likewise.
1810 (get_last_displayed_addr): Likewise.
1811 (get_last_displayed_symtab): Likewise.
1812 (get_last_displayed_line): Likewise.
1813 (get_last_displayed_sal): Likewise.
1814 * stack.h (clear_last_displayed_sal): Update header comment.
1815 (last_displayed_sal_is_valid): Likewise.
1816 (get_last_displayed_pspace): Likewise.
1817 (get_last_displayed_addr): Likewise.
1818 (get_last_displayed_symtab): Likewise.
1819 (get_last_displayed_line): Likewise.
1820 (get_last_displayed_sal): Likewise.
1821
1822 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1823
1824 * stack.c (frame_show_address): Convert return type to bool.
1825 * stack.h (frame_show_address): Likewise, and update header
1826 comment.
1827
1828 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1829
1830 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1831 * unittests/vec-utils-selftests.c: New file.
1832 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1833
1834 2019-11-10 Tom Tromey <tom@tromey.com>
1835
1836 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1837 (tui_highlight_win): Likewise.
1838 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1839 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1840 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1841 Don't set can_highlight.
1842
1843 2019-11-10 Tom Tromey <tom@tromey.com>
1844
1845 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1846 Remove unused declaration.
1847
1848 2019-11-08 Tom Tromey <tromey@adacore.com>
1849
1850 * top.c (read_command_file): Update.
1851 (command_line_input): Make return type const.
1852 * python/py-gdb-readline.c: Update.
1853 * linespec.c (decode_line_2): Update.
1854 * defs.h (command_line_input): Make return type const.
1855 * cli/cli-script.c (read_next_line): Make return type const.
1856 * ada-lang.c (get_selections): Update.
1857
1858 2019-11-06 Christian Biesinger <cbiesinger@google.com>
1859
1860 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1861 * mi/mi-main.c (output_cores): Likewise.
1862 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1863 (linux_xfer_osdata_modules): Likewise.
1864 * remote.c (register_remote_support_xml): Likewise.
1865 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1866 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1867
1868 2019-11-06 Tom Tromey <tom@tromey.com>
1869
1870 * tui/tui-interp.c: Don't include readline.h.
1871 * tui/tui-hooks.c: Don't include readline.h.
1872 * symmisc.c: Include tilde.h, not readline.h.
1873 * symfile.c: Include tilde.h, not readline.h.
1874 * source.c: Include tilde.h, not readline.h.
1875 * solib.c: Include tilde.h, not readline.h.
1876 * psymtab.c: Include tilde.h, not readline.h.
1877 * exec.c: Include tilde.h, not readline.h.
1878 * corelow.c: Include tilde.h, not readline.h.
1879 * cli/cli-dump.c: Include tilde.h, not readline.h.
1880 * cli/cli-cmds.c: Don't include readline.h.
1881
1882 2019-11-05 Tom Tromey <tom@tromey.com>
1883
1884 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1885 (tui_disassemble): Set addr_size.
1886 (tui_disasm_window::set_contents): Use addr_size.
1887
1888 2019-11-05 Tom Tromey <tom@tromey.com>
1889
1890 * rust-lang.c (rust_language_defn): Update.
1891 * python/py-value.c (valpy_string): Call c_get_string.
1892 * p-lang.c (pascal_language_defn): Update.
1893 * opencl-lang.c (opencl_language_defn): Update.
1894 * objc-lang.c (objc_language_defn): Update.
1895 * m2-lang.c (m2_language_defn): Update.
1896 * language.c (unknown_language_defn, auto_language_defn): Update.
1897 (default_get_string): Remove.
1898 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1899 * go-lang.c (go_language_defn): Update.
1900 * f-lang.c (f_language_defn): Update.
1901 * d-lang.c (d_language_defn): Update.
1902 * c-lang.c (c_language_defn, cplus_language_defn)
1903 (asm_language_defn, minimal_language_defn): Update.
1904 * ada-lang.c (ada_language_defn): Update.
1905 * language.h (struct language_defn) <la_get_string>: Remove.
1906 (LA_GET_STRING): Remove.
1907 (default_get_string): Don't declare.
1908
1909 2019-11-05 Tom Tromey <tom@tromey.com>
1910
1911 * tui/tui-source.h (struct tui_source_window): Inline
1912 constructor. Remove destructor.
1913 <style_changed, m_observable>: Move to superclass.
1914 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1915 (struct tui_source_window_base): Move private members to end.
1916 <style_changed, m_observable>: Move from tui_source_window.
1917 * tui/tui-winsource.c (tui_copy_source_line): Move from
1918 tui-source.c. Rename from copy_source_line. Add special handling
1919 for negative line number.
1920 (tui_source_window_base::style_changed): Move from
1921 tui_source_window.
1922 (tui_source_window_base): Register observer.
1923 (~tui_source_window_base): New.
1924 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1925 rename.
1926 (tui_source_window::set_contents): Use tui_copy_source_line.
1927 (tui_source_window::tui_source_window): Move to tui-source.h.
1928 (tui_source_window::~tui_source_window): Remove.
1929 (tui_source_window::style_changed): Move to superclass.
1930 * tui/tui-disasm.c (tui_disassemble): Create string file with
1931 styling, when possible. Add "addr_size" parameter.
1932 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1933 Don't compute maximum size.
1934 (len_without_escapes): New function
1935
1936 2019-11-05 Tom Tromey <tom@tromey.com>
1937
1938 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1939 std::string.
1940 * tui/tui-winsource.c (tui_show_source_line): Update.
1941 * tui/tui-source.c (tui_source_window::set_contents): Update.
1942 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1943
1944 2019-11-05 Christian Biesinger <cbiesinger@google.com>
1945
1946 * symtab.h (gdb_static_assert): Put && operator at the beginning
1947 of the line instead of the end.
1948
1949 2019-11-04 Christian Biesinger <cbiesinger@google.com>
1950
1951 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1952 and sizeof (symbol).
1953 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1954
1955 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1956
1957 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1958 * configure.host: Mark *-*-solaris2.10* obsolete.
1959 * configure.tgt: Mark Solaris < 11 obsolete.
1960 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1961 Update target triplet.
1962
1963 2019-11-01 Tom Tromey <tromey@adacore.com>
1964
1965 * utils.c (print_sys_errmsg): Simplify.
1966
1967 2019-11-01 Tom Tromey <tromey@adacore.com>
1968
1969 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1970
1971 2019-11-01 Christian Biesinger <cbiesinger@google.com>
1972
1973 * configure: Regenerate.
1974 * configure.ac: Remove check for strerror_r.
1975 * gdbsupport/common.m4: Check for strerror_r.
1976
1977 2019-11-01 Luis Machado <luis.machado@linaro.org>
1978
1979 PR gdb/25124
1980
1981 * arm-tdep.c (arm_per_objfile): Rename to ...
1982 (arm_per_bfd): ... this.
1983 (arm_objfile_data_key): Rename to ...
1984 (arm_bfd_data_key): ... this.
1985 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1986 data.
1987 (arm_record_special_symbol): Likewise.
1988
1989 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1990
1991 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1992 end.
1993 * c-typeprint.c (c_print_typedef): Likewise.
1994 * f-typeprint.c (f_print_typedef): Likewise.
1995 * m2-typeprint.c (m2_print_typedef): Likewise.
1996 * p-typeprint.c (pascal_print_typedef): Likewise.
1997 * rust-lang.c (rust_print_typedef): Likewise.
1998 * symtab.c (print_symbol_info): Print a newline after calling
1999 typedef_print.
2000
2001 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2002
2003 * symtab.c (info_module_cmdlist): New variable.
2004 (info_module_command): New function.
2005 (search_module_symbols): New function.
2006 (info_module_subcommand): New function.
2007 (struct info_modules_var_func_options): New struct.
2008 (info_modules_var_func_options_defs): New variable.
2009 (make_info_modules_var_func_options_def_group): New function.
2010 (info_module_functions_command): New function.
2011 (info_module_variables_command): New function.
2012 (info_module_var_func_command_completer): New function.
2013 (_initialize_symtab): Register new 'info module functions' and
2014 'info module variables' commands.
2015 * symtab.h (typedef symbol_search_in_module): New typedef.
2016 (search_module_symbols): Declare new function.
2017 * NEWS: Mention new commands.
2018
2019 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2020
2021 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2022 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2023 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2024 MODULES_DOMAIN.
2025 (scan_partial_symbols): Only create partial module symbols for non
2026 declarations.
2027 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2028 and MODULES_DOMAIN.
2029 * symtab.c (search_domain_name): Likewise.
2030 (search_symbols): Likewise.
2031 (print_symbol_info): Likewise.
2032 (symtab_symbol_info): Likewise.
2033 (info_modules_command): New function.
2034 (_initialize_symtab): Register 'info modules' command.
2035 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2036 * NEWS: Mention new 'info modules' command.
2037
2038 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2039
2040 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2041 and $_gdb_maint_setting_str.
2042
2043 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2044
2045 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2046 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2047 (str_value_from_setting, gdb_setting_str_internal_fn)
2048 (gdb_maint_setting_str_internal_fn): New functions.
2049 (_initialize_cli_cmds): Define the new convenience functions.
2050 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2051 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2052
2053 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2054
2055 * agent.c (set_can_use_agent): When the setting is turned on,
2056 look up agent symbols if we don't have them yet.
2057 (agent_new_objfile): Don't look up agent symbols when the agent
2058 setting is off.
2059
2060 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2061
2062 * config.in: Regenerate.
2063
2064 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2065
2066 * configure: Regenerate.
2067 * configure.ac: Check for strerror_r.
2068 * gdbsupport/common-utils.h (safe_strerror): Change return value
2069 to const char * and document that this function is now threadsafe.
2070 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2071 thread_local and call strerror_r, if available.
2072 * utils.c (perror_string): Update.
2073 (print_sys_errmsg): Update.
2074
2075 2019-10-31 Luis Machado <luis.machado@linaro.org>
2076
2077 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2078 objfile_key.
2079 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2080 objfile to fetch per-bfd data.
2081 (arm_find_exidx_entry): Likewise.
2082
2083 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2084
2085 * gdbsupport/agent.c (debug_agent): Change type to bool.
2086 (use_agent): Likewise.
2087 (all_agent_symbols_look_up): Likewise.
2088 (agent_loaded_p): Change return value to bool.
2089 (agent_look_up_symbols): Update.
2090 (agent_capability_check): Change return value to bool.
2091 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2092 (debug_agent): Change type to bool.
2093 (use_agent): Likewise.
2094 (agent_capability_check): Change return value to bool.
2095
2096 2019-10-30 Christian Biesinger <cbiesinger@google.com>
2097
2098 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2099 (build_minimal_symbol_hash_tables): Code to clear the table moved
2100 to clear_minimal_symbol_hash_tables.
2101 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2102 when needed.
2103
2104 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2105
2106 * infcmd.c: Remove includes.
2107 * infrun.c: Remove includes.
2108
2109 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2110
2111 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2112 (grow_vect): Remove declaration.
2113 (ada_type_of_array): Remove declaration.
2114 (ada_update_initial_language): Remove declaration.
2115 (ada_fold_name): Remove declaration.
2116 (ada_fill_in_ada_prototype): Remove declaration.
2117 (user_select_syms): Remove declaration.
2118 (get_selections): Remove declaration.
2119 (ada_tag_type): Remove declaration.
2120 (ada_value_tag): Remove declaration.
2121 (ada_is_others_clause): Remove declaration.
2122 (ada_in_variant): Remove declaration.
2123 (ada_value_struct_elt): Remove declaration.
2124 (ada_attribute_name): Remove declaration.
2125 (ada_system_address_type): Remove declaration.
2126 * ada-lang.c (ada_watch_location_expression): Make static.
2127 (GROW_VECT): Move here from ada-lang.h.
2128 (grow_vect): Make static.
2129 (ada_update_initial_language): Make static.
2130 (ada_fold_name): Make static.
2131 (ada_type_of_array): Make static.
2132 (encoded_ordered_before): Move up.
2133 (sort_choices): Move up.
2134 (print_signatures): Move up.
2135 (ada_print_symbol_signature): Move up.
2136 (get_selections): Move up and make static.
2137 (user_select_syms): Move up and make static.
2138 (ada_value_struct_elt): Move up and make static.
2139 (ada_tag_type): Make static.
2140 (ada_value_tag): Make static.
2141 (ada_is_others_clause): Make static.
2142 (ada_in_variant): Make static.
2143 (ada_attribute_name): Make static.
2144
2145 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2146
2147 * ada-lang.c: Remove includes.
2148 * ada-typeprint.c: Remove includes.
2149 * ada-valprint.c: Remove includes.
2150
2151 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
2152
2153 * addrmap.c: Add static assertions of type size, moved from
2154 _initialize_addrmap.
2155 (_initialize_addrmap): Remove.
2156
2157 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2158
2159 * coffread.c (record_minimal_symbol): Update.
2160 (process_coff_symbol): Update.
2161 * dbxread.c (read_dbx_symtab): Update.
2162 * dwarf2read.c (add_partial_symbol): Update.
2163 (fixup_go_packaging): Update.
2164 (load_partial_dies): Update.
2165 (new_symbol): Update.
2166 * elfread.c (record_minimal_symbol): Change signature to use
2167 gdb::string_view instead of name+len.
2168 (elf_symtab_read): Update.
2169 (elf_rel_plt_read): Update.
2170 * mdebugread.c (parse_partial_symbols): Update.
2171 (handle_psymbol_enumerators): Update.
2172 (new_symbol): Update.
2173 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2174 to use gdb::string_view instead of name+len.
2175 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2176 * psympriv.h (add_psymbol_to_list): Likewise.
2177 * psymtab.c (add_psymbol_to_bcache): Likewise.
2178 (add_psymbol_to_list): Likewise.
2179 * stabsread.c (define_symbol): Update.
2180 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2181 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2182 (symbol_set_names): Likewise.
2183 * xcoffread.c (scan_xcoff_symtab): Update.
2184
2185 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2186
2187 * symtab.h (symbol_set_names): Document that copy_name must be
2188 set to true for non-nullterminated strings.
2189 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2190 linkage_name if the entry was not found and we need to demangle.
2191
2192 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2193
2194 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2195 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2196 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2197 * gdbsupport/gdb_binary_search.h: New file.
2198
2199 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2200
2201 * NEWS: Mention new --with-system-gdbinit-dir option.
2202 * config.in: Regenerate.
2203 * configure: Regenerate.
2204 * configure.ac: Add new option --with-system-gdbinit-dir.
2205 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2206 for a ".gdb" suffix.
2207 * main.c (get_init_files): Change system_gdbinit argument to
2208 a vector and return the files in SYSTEM_GDBINIT_DIR in
2209 addition to SYSTEM_GDBINIT.
2210 (captured_main_1): Update.
2211 (print_gdb_help): Update.
2212 * top.c (print_gdb_configuration): Also print the value of
2213 SYSTEM_GDBINIT_DIR.
2214
2215 2019-10-28 Christian Biesinger <cbiesinger@google.com>
2216
2217 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2218 that takes gdb::string_view arguments.
2219
2220 2019-10-26 Tom de Vries <tdevries@suse.de>
2221
2222 * aarch64-linux-tdep.c: Fix typos in comments.
2223 * aarch64-tdep.c: Same.
2224 * ada-lang.c: Same.
2225 * amd64-nat.c: Same.
2226 * arc-tdep.c: Same.
2227 * arch/aarch64-insn.c: Same.
2228 * block.c: Same.
2229 * breakpoint.h: Same.
2230 * btrace.h: Same.
2231 * c-varobj.c: Same.
2232 * cli/cli-decode.c: Same.
2233 * cli/cli-script.c: Same.
2234 * cli/cli-utils.h: Same.
2235 * coff-pe-read.c: Same.
2236 * coffread.c: Same.
2237 * compile/compile-cplus-symbols.c: Same.
2238 * compile/compile-object-run.c: Same.
2239 * completer.c: Same.
2240 * corelow.c: Same.
2241 * cp-support.c: Same.
2242 * demangle.c: Same.
2243 * dwarf-index-write.c: Same.
2244 * dwarf2-frame.c: Same.
2245 * dwarf2-frame.h: Same.
2246 * eval.c: Same.
2247 * frame-base.h: Same.
2248 * frame.h: Same.
2249 * gdbcmd.h: Same.
2250 * gdbtypes.h: Same.
2251 * gnu-nat.c: Same.
2252 * guile/scm-objfile.c: Same.
2253 * i386-tdep.c: Same.
2254 * i386-tdep.h: Same.
2255 * infcall.c: Same.
2256 * infcall.h: Same.
2257 * linux-nat.c: Same.
2258 * m68k-tdep.c: Same.
2259 * macroexp.c: Same.
2260 * memattr.c: Same.
2261 * mi/mi-cmd-disas.c: Same.
2262 * mi/mi-getopt.h: Same.
2263 * mi/mi-main.c: Same.
2264 * minsyms.c: Same.
2265 * nat/aarch64-sve-linux-sigcontext.h: Same.
2266 * objfiles.h: Same.
2267 * ppc-linux-nat.c: Same.
2268 * ppc-linux-tdep.c: Same.
2269 * ppc-tdep.h: Same.
2270 * progspace.h: Same.
2271 * prologue-value.h: Same.
2272 * python/py-evtregistry.c: Same.
2273 * python/py-instruction.h: Same.
2274 * record-btrace.c: Same.
2275 * record-full.c: Same.
2276 * remote.c: Same.
2277 * rs6000-tdep.c: Same.
2278 * ser-tcp.c: Same.
2279 * sol-thread.c: Same.
2280 * sparc-sol2-tdep.c: Same.
2281 * sparc64-tdep.c: Same.
2282 * stabsread.c: Same.
2283 * symfile.c: Same.
2284 * symtab.h: Same.
2285 * target.c: Same.
2286 * tracepoint.c: Same.
2287 * tui/tui-data.h: Same.
2288 * tui/tui-io.c: Same.
2289 * tui/tui-win.c: Same.
2290 * tui/tui.c: Same.
2291 * unittests/rsp-low-selftests.c: Same.
2292 * user-regs.h: Same.
2293 * utils.c: Same.
2294 * utils.h: Same.
2295 * valarith.c: Same.
2296 * valops.c: Same.
2297 * valprint.c: Same.
2298 * valprint.h: Same.
2299 * value.c: Same.
2300 * value.h: Same.
2301 * varobj.c: Same.
2302 * x86-nat.h: Same.
2303 * xtensa-tdep.c: Same.
2304
2305 2019-10-25 Ali Tamur <tamur@google.com>
2306
2307 * charset.c (find_charset_names): Reflect API change.
2308
2309 2019-10-25 Christian Biesinger <cbiesinger@google.com>
2310
2311 * symtab.c (struct demangled_name_entry): Change demangled name
2312 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2313 part of the struct anymore.
2314 (symbol_set_names): No longer obstack allocate + copy the demangled
2315 name, just store the allocated name from bfd.
2316
2317 2019-10-25 Tom Tromey <tromey@adacore.com>
2318
2319 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2320 (bsearch_cie_cmp, add_cie): Remove.
2321 (find_cie): Reimplement.
2322 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2323 (dwarf2_build_frame_info): Update.
2324
2325 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2326
2327 PR gdb/25126
2328 * symfile.c (reread_symbols): Call forget_cached_source_info to
2329 clear the stale source cache.
2330
2331 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2332
2333 * configure: Regenerate.
2334 * configure.ac: Remove code that sets python_has_threads.
2335
2336 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2337
2338 * config.in: Regenerate.
2339 * configure: Regenerate.
2340 * configure.ac: Remove the code that uses sed to get the python
2341 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2342
2343 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2344
2345 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2346 error paths.
2347
2348 2019-10-23 Tom Tromey <tom@tromey.com>
2349
2350 * arc-tdep.c: Remove ".." from include.
2351 * frv-tdep.c: Remove ".." from include.
2352 * lm32-tdep.c: Remove ".." from include.
2353 * microblaze-tdep.c: Remove ".." from include.
2354 * or1k-tdep.h: Remove ".." from include.
2355 * s12z-tdep.c: Remove ".." from include.
2356 * Makefile.in (OPCODES_CFLAGS): Add comment.
2357 (TOP_CFLAGS): New variable.
2358 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2359
2360 2019-10-23 Tom Tromey <tom@tromey.com>
2361
2362 * Makefile.in (READLINE_DIR): Update.
2363
2364 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2365
2366 * infcall.c (call_function_by_hand_dummy): Fix the function
2367 comment. And extract out a code section into...
2368 (reserve_stack_space): ...this new function.
2369
2370 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2371
2372 * infcall.c (value_arg_coerce): Remove an unused parameter.
2373 (call_function_by_hand_dummy): Update the call to
2374 'value_arg_coerce'.
2375
2376 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2377
2378 * infcall.c (call_function_by_hand_dummy): Refactor.
2379
2380 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2381
2382 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2383
2384 2019-10-23 Tom Tromey <tom@tromey.com>
2385
2386 * configure: Rebuild.
2387 * configure.ac: Don't check for sigprocmask.
2388 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2389
2390 2019-10-23 Tom Tromey <tom@tromey.com>
2391
2392 * configure: Rebuild.
2393 * acinclude.m4: Use m4_include, not sinclude.
2394
2395 2019-10-23 Tom de Vries <tdevries@suse.de>
2396
2397 PR breakpoints/24687
2398 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2399
2400 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2401
2402 * symtab.c (struct demangled_name_entry) <language>: Change from
2403 bitfield to regular variable.
2404
2405 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2406
2407 * symtab.c (struct demangled_name_entry): Add a constructor.
2408 (free_demangled_name_entry): New function to call the destructor
2409 for demangled_name_entry.
2410 (create_demangled_names_hash): Pass free_demangled_name_entry to
2411 htab_create_alloc.
2412 (symbol_set_names): Call placement new for demangled_name_entry.
2413 * utils.c: No longer include xxhash.h here, now that fast_hash
2414 is inlined in the header.
2415 * utils.h: Instead, include it here.
2416
2417 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2418
2419 * Makefile.in: Link with libxxhash.
2420 * config.in: Regenerate.
2421 * configure: Regenerate.
2422 * configure.ac: Search for libxxhash.
2423 * utils.c (fast_hash): Use xxhash if present.
2424
2425 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2426
2427 * utils.h (fast_hash): New function.
2428 * symtab.c (hash_demangled_name_entry): Call new function
2429 fast_hash.
2430
2431 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2432
2433 * symtab.c (struct demangled_name_entry): Change type of mangled
2434 to gdb::string_view. Also adds a constructor that takes the
2435 mangled name.
2436 (hash_demangled_name_entry): Update.
2437 (eq_demangled_name_entry): Update.
2438 (free_demangled_name_entry): New function to call the destructor
2439 now that this is not a POD anymore.
2440 (create_demangled_names_hash): Pass free_demangled_name_entry to
2441 htab_create_alloc.
2442 (symbol_set_names): Update.
2443
2444 2019-10-21 Ali Tamur <tamu@google.com>
2445
2446 * dwarf2read.c (dir_index): Change type.
2447 (file_name_index): Likewise.
2448 (line_header::include_dir_at): Change comment and implementation on
2449 whether it is DWARF 5.
2450 (line_header::is_valid_file_index): New function.
2451 (line_header::file_name_at): Change comment and implementation on
2452 whether it is DWARF 5.
2453 (line_header::file_names): Change to private field renamed as
2454 m_file_names and introduce a new accessor method.
2455 (line_header::file_names_size): New method.
2456 (line_header::include_dirs): Change to private field and rename as
2457 m_include_dirs.
2458 (dw2_get_file_names_reader): Define local var at a smaller scope and
2459 reflect API change.
2460 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2461 (process_structure_scope): Likewise.
2462 (line_header::add_include_dir): Change message and reflect renaming.
2463 (line_header::add_file_name): Likewise.
2464 (read_formatted_entries): Handle DW_FORM_data16.
2465 (dwarf_decode_line_header): Fix line header length calculation.
2466 (psymtab_include_file_name): Change comment and API.
2467 (lnp_state_machine::m_file): Update comment and reflect type change.
2468 (lnp_state_machine::record_line): Reflect type change.
2469 (dwarf_decode_lines): Reflect API change.
2470 (file_file_name): Likewise.
2471 (file_full_name): Likewise.
2472
2473 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2474
2475 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2476
2477 2019-10-21 Tom Tromey <tom@tromey.com>
2478
2479 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2480
2481 2019-10-21 Tom Tromey <tom@tromey.com>
2482
2483 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2484 NM_H. Use AC_CONFIG_LINKS.
2485 * configure: Rebuild.
2486 * Makefile.in (NM_H): New variable.
2487 (generated_files): Add NM_H. Remove gcore.
2488 (nm.h, stamp-nmh): New targets.
2489
2490 2019-10-20 Tom Tromey <tom@tromey.com>
2491
2492 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2493 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2494 obsolete comment.
2495 (put_objfile_before): Now static.
2496
2497 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2498
2499 * gdbsupport/common-utils.h (startswith): Change return type to
2500 bool.
2501
2502 2019-10-19 Christian Biesinger <cbiesinger@google.com>
2503
2504 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2505 * breakpoint.c (bp_locations_compare): Rename to...
2506 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2507 (update_global_location_list): Use std::sort instead of qsort.
2508 * buildsym.c (compare_line_numbers): Rename to...
2509 (lte_is_less_than): ...this, and change to std::sort semantics.
2510 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2511 instead of qsort.
2512 * disasm.c (compare_lines): Rename to...
2513 (line_is_less_than): ...this, and change to std::sort semantics.
2514 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2515 of qsort.
2516 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2517 (fde_is_less_than): ...this, and change to std::sort semantics.
2518 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2519 * mdebugread.c (compare_blocks):
2520 (block_is_less_than): ...this, and change to std::sort semantics.
2521 (sort_blocks): Call std::sort instead of qsort.
2522 * objfiles.c (qsort_cmp): Rename to...
2523 (sort_cmp): ...this, and change to std::sort semantics.
2524 (update_section_map): Call std::sort instead of qsort.
2525 * remote.c (compare_pnums): Remove.
2526 (map_regcache_remote_table): Call std::sort instead of qsort.
2527 * utils.c (compare_positive_ints): Remove.
2528 * utils.h (compare_positive_ints): Remove.
2529 * xcoffread.c (compare_lte): Remove.
2530 (arrange_linetable): Call std::sort instead of qsort.
2531
2532 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2533
2534 * symfile.c (init_entry_point_info): Fix typo.
2535 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2536
2537 2019-10-18 Tom de Vries <tdevries@suse.de>
2538
2539 * aarch64-tdep.c: Fix typos in comments.
2540 * ada-lang.c: Same.
2541 * ada-tasks.c: Same.
2542 * alpha-tdep.c: Same.
2543 * alpha-tdep.h: Same.
2544 * amd64-nat.c: Same.
2545 * amd64-windows-tdep.c: Same.
2546 * arc-tdep.c: Same.
2547 * arc-tdep.h: Same.
2548 * arch-utils.c: Same.
2549 * arm-nbsd-tdep.c: Same.
2550 * arm-tdep.c: Same.
2551 * ax-gdb.c: Same.
2552 * blockframe.c: Same.
2553 * btrace.c: Same.
2554 * c-varobj.c: Same.
2555 * coff-pe-read.c: Same.
2556 * coffread.c: Same.
2557 * cris-tdep.c: Same.
2558 * darwin-nat.c: Same.
2559 * dbxread.c: Same.
2560 * dcache.c: Same.
2561 * disasm.c: Same.
2562 * dtrace-probe.c: Same.
2563 * dwarf-index-write.c: Same.
2564 * dwarf2-frame-tailcall.c: Same.
2565 * dwarf2-frame.c: Same.
2566 * dwarf2read.c: Same.
2567 * eval.c: Same.
2568 * exceptions.c: Same.
2569 * fbsd-tdep.c: Same.
2570 * findvar.c: Same.
2571 * frame.c: Same.
2572 * frv-tdep.c: Same.
2573 * gnu-v3-abi.c: Same.
2574 * go32-nat.c: Same.
2575 * h8300-tdep.c: Same.
2576 * hppa-tdep.c: Same.
2577 * i386-linux-tdep.c: Same.
2578 * i386-tdep.c: Same.
2579 * ia64-libunwind-tdep.c: Same.
2580 * ia64-tdep.c: Same.
2581 * infcmd.c: Same.
2582 * infrun.c: Same.
2583 * linespec.c: Same.
2584 * linux-nat.c: Same.
2585 * linux-thread-db.c: Same.
2586 * machoread.c: Same.
2587 * mdebugread.c: Same.
2588 * mep-tdep.c: Same.
2589 * mn10300-tdep.c: Same.
2590 * namespace.c: Same.
2591 * objfiles.c: Same.
2592 * opencl-lang.c: Same.
2593 * or1k-tdep.c: Same.
2594 * osabi.c: Same.
2595 * ppc-linux-nat.c: Same.
2596 * ppc-linux-tdep.c: Same.
2597 * ppc-sysv-tdep.c: Same.
2598 * printcmd.c: Same.
2599 * procfs.c: Same.
2600 * record-btrace.c: Same.
2601 * record-full.c: Same.
2602 * remote-fileio.c: Same.
2603 * remote.c: Same.
2604 * rs6000-tdep.c: Same.
2605 * s12z-tdep.c: Same.
2606 * score-tdep.c: Same.
2607 * ser-base.c: Same.
2608 * ser-go32.c: Same.
2609 * skip.c: Same.
2610 * sol-thread.c: Same.
2611 * solib-svr4.c: Same.
2612 * solib.c: Same.
2613 * source.c: Same.
2614 * sparc-nat.c: Same.
2615 * sparc-sol2-tdep.c: Same.
2616 * sparc-tdep.c: Same.
2617 * sparc64-tdep.c: Same.
2618 * stabsread.c: Same.
2619 * stack.c: Same.
2620 * symfile.c: Same.
2621 * symtab.c: Same.
2622 * target-descriptions.c: Same.
2623 * target-float.c: Same.
2624 * thread.c: Same.
2625 * utils.c: Same.
2626 * valops.c: Same.
2627 * valprint.c: Same.
2628 * value.c: Same.
2629 * varobj.c: Same.
2630 * windows-nat.c: Same.
2631 * xcoffread.c: Same.
2632 * xstormy16-tdep.c: Same.
2633 * xtensa-tdep.c: Same.
2634
2635 2019-10-17 Tom Tromey <tromey@adacore.com>
2636
2637 * configure: Rebuild.
2638 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2639 in AC_CONFIG_FILES invocation.
2640 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2641 new-style config.status invocation.
2642
2643 2019-10-17 Tom de Vries <tdevries@suse.de>
2644
2645 * arm-nbsd-nat.c: Fix typos in comments.
2646 * arm-tdep.c: Same.
2647 * darwin-nat-info.c: Same.
2648 * dwarf2read.c: Same.
2649 * elfread.c: Same.
2650 * event-top.c: Same.
2651 * findvar.c: Same.
2652 * gdbtypes.c: Same.
2653 * hppa-tdep.c: Same.
2654 * i386-tdep.c: Same.
2655 * jit.c: Same.
2656 * main.c: Same.
2657 * mdebugread.c: Same.
2658 * moxie-tdep.c: Same.
2659 * nto-procfs.c: Same.
2660 * osabi.c: Same.
2661 * ppc-linux-tdep.c: Same.
2662 * remote.c: Same.
2663 * riscv-tdep.c: Same.
2664 * s390-tdep.c: Same.
2665 * sh-tdep.c: Same.
2666 * sparc-linux-tdep.c: Same.
2667 * sparc-nat.c: Same.
2668 * stack.c: Same.
2669 * target-descriptions.c: Same.
2670 * top.c: Same.
2671 * varobj.c: Same.
2672
2673 2019-10-16 Tom Tromey <tom@tromey.com>
2674
2675 * objfiles.h (struct objfile) <original_name>: Now const.
2676
2677 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2678
2679 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2680 pass on to sigsetjmp's second argument.
2681 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2682
2683 2019-10-16 Keith Seitz <keiths@redhat.com>
2684
2685 PR gdb/23567
2686 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2687 sections whose size is greater than the file size.
2688
2689 2019-10-16 Jim Wilson <jimw@sifive.com>
2690
2691 * riscv-tdep.c (riscv_gcc_target_options): New.
2692 (riscv_gnu_triplet_regexp): New.
2693 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2694 set_gdbarch_gnu_triplet_regexp.
2695
2696 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2697
2698 * Makefile.in: Add xml-builtin.h.
2699 * features/feature_to_c.sh: Add an include for xml-builtin.h
2700 to ensure that the compiler checks that the types match.
2701 * xml-builtin.h: New file.
2702 * xml-support.c (fetch_xml_builtin): Add missing const.
2703 * xml-support.h: Remove declaration of xml_builtins.
2704
2705 2019-10-16 Tom de Vries <tdevries@suse.de>
2706
2707 PR tdep/25096
2708 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2709 (amd64_classify_aggregate): ... here.
2710 (amd64_classify_aggregate_field): Handled fiels of nested structs
2711 recursively.
2712
2713 2019-10-16 Tom de Vries <tdevries@suse.de>
2714
2715 PR tdep/24104
2716 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2717 that handles 'theclass'.
2718
2719 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2720
2721 * linespec.c (decode_digits_ordinary): Update comment.
2722 * make-target-delegates: No longer need to handle VEC case.
2723 * memrange.c (normalize_mem_ranges): Update comment.
2724 * namespace.c (add_using_directive): Update comment.
2725 * objc-lang.c (uniquify_strings): Update comment.
2726 * ppc-linux-nat.c (struct thread_points): Update comment.
2727 * probe.h (find_probes_in_objfile): Update comment.
2728 * target.h (enum flash_preserve_mode): Update comment.
2729 * varobj.c (varobj_restrict_range): Update comment.
2730 * varobj.h (varobj_list_children): Update comment.
2731
2732 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2733
2734 * Makefile.in: Remove references to vec.h and vec.c.
2735 * aarch64-tdep.c: No longer include vec.h.
2736 * ada-lang.c: Likewise.
2737 * ada-lang.h: Likewise.
2738 * arm-tdep.c: Likewise.
2739 * ax.h: Likewise.
2740 * breakpoint.h: Likewise.
2741 * charset.c: Likewise.
2742 * cp-support.h: Likewise.
2743 * dtrace-probe.c: Likewise.
2744 * dwarf2read.c: Likewise.
2745 * extension.h: Likewise.
2746 * gdb_bfd.c: Likewise.
2747 * gdbsupport/gdb_vecs.h: Likewise.
2748 * gdbsupport/vec.c: Remove.
2749 * gdbsupport/vec.h: Remove.
2750 * gdbthread.h: Likewise.
2751 * guile/scm-type.c: Likewise.
2752 * inline-frame.c: Likewise.
2753 * machoread.c: Likewise.
2754 * memattr.c: Likewise.
2755 * memrange.h: Likewise.
2756 * namespace.h: Likewise.
2757 * nat/linux-btrace.h: Likewise.
2758 * osdata.c: Likewise.
2759 * parser-defs.h: Likewise.
2760 * progspace.h: Likewise.
2761 * python/py-type.c: Likewise.
2762 * record-btrace.c: Likewise.
2763 * rust-exp.y: Likewise.
2764 * solib-target.c: Likewise.
2765 * stap-probe.c: Likewise.
2766 * target-descriptions.c: Likewise.
2767 * target-memory.c: Likewise.
2768 * target.h: Likewise.
2769 * varobj.c: Likewise.
2770 * varobj.h: Likewise.
2771 * xml-support.h: Likewise.
2772
2773 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2774
2775 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2776 Update for new std::vector based implementation.
2777 (process_psymtab_comp_unit_reader): Likewise.
2778 (scan_partial_symbols): Likewise.
2779 (recursively_compute_inclusions): Likewise.
2780 (compute_compunit_symtab_includes): Likewise.
2781 (process_imported_unit_die): Likewise.
2782 (queue_and_load_dwo_tu): Likewise.
2783 (follow_die_sig_1): Likewise.
2784 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2785 (typedef dwarf2_per_cu_ptr): Remove.
2786 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2787 function.
2788 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2789 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2790 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2791 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2792 std::vector.
2793
2794 2019-10-15 Tom Tromey <tromey@adacore.com>
2795
2796 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2797 TID.
2798
2799 2019-10-15 Tom Tromey <tromey@adacore.com>
2800
2801 * windows-nat.c (windows_nat_target::fetch_registers)
2802 (windows_nat_target::store_registers): Rename "pid" to "tid".
2803
2804 2019-10-15 Tom Tromey <tromey@adacore.com>
2805
2806 * gdbarch.h, gdbarch.c: Rebuild.
2807 * gdbarch.sh (gcc_target_options): Change return type to
2808 std::string.
2809 * compile/compile.c (get_args): Update.
2810 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2811 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2812 std::string.
2813 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2814 std::string.
2815 * arch-utils.c (default_gcc_target_options): Return std::string.
2816 * arch-utils.h (default_gcc_target_options): Return std::string.
2817 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2818
2819 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2820
2821 * breakpoint.c (breakpoint_chain): Make static.
2822 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2823 of accessing breakpoint_chain.
2824
2825 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2826
2827 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2828 to a gdb::function_view and return value to bool.
2829 * breakpoint.h (iterate_over_breakpoints): Likewise.
2830 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2831 (pop_dummy_frame): Update.
2832 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2833 (gdbscm_breakpoints): Update.
2834 * python/py-breakpoint.c (build_bp_list): Update.
2835 (gdbpy_breakpoints): Update.
2836 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2837 Update.
2838 (bpfinishpy_handle_stop): Update.
2839 (bpfinishpy_handle_exit): Update.
2840 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2841 (svr4_update_solib_event_breakpoints): Update.
2842
2843 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2844
2845 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2846 when unwrapping single-field structs.
2847
2848 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2849
2850 * dwarf2read.c: Remove includes.
2851
2852 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2853
2854 * ui-out.c (ui_out::call_do_message): Silence
2855 -Wformat-nonliteral warning.
2856
2857 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2858
2859 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2860 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2861 include: readline/tilde.h.
2862
2863 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2864
2865 * remote.c (remote_target::get_trace_status): Remove declaration of
2866 trace_regblock_size.
2867
2868 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2869
2870 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2871 (show_user): Remove declaration of cmdlist.
2872 * cli/cli-cmds.h (max_user_call_depth): Declare.
2873 * cli/cli-script.c (execute_user_command): Remove declaration
2874 of max_user_call_depth.
2875
2876 2019-10-11 Jim Wilson <jimw@sifive.com>
2877
2878 * gdbsupport/print-utils.h (pulongest): Fix comment.
2879 (plongest): Likewise.
2880 (phex): Add missing comment, mention leading zeros.
2881 (phex_nz): Add mention of no leading zeros to comment.
2882
2883 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2884 plongest instead of unsigned long long cast.
2885
2886 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2887
2888 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2889 for external_editor_command and gdbtk_test.
2890
2891 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2892
2893 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2894 * varobj.c (varobjdebug): Move comment to...
2895 * varobj.h (varobjdebug): ...here, and declare.
2896
2897 2019-10-09 Tom Tromey <tom@tromey.com>
2898
2899 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2900 erase_data_content.
2901
2902 2019-10-09 Tom Tromey <tom@tromey.com>
2903
2904 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2905 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2906 * tui/tui-command.c (tui_cmd_window::resize)
2907 (tui_refresh_cmd_win): Update.
2908 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2909 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2910 * tui/tui-data.c (~tui_gen_win_info): Remove.
2911 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2912 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2913 (tui_redisplay_readline, tui_mld_flush)
2914 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2915 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2916 (tui_data_window::erase_data_content)
2917 (tui_data_item_window::rerender)
2918 (tui_data_item_window::refresh_window): Update.
2919 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2920 (box_win, tui_gen_win_info::make_window)
2921 (tui_gen_win_info::make_visible): Update.
2922 (tui_delete_win): Remove.
2923 * tui/tui-winsource.c
2924 (tui_source_window_base::do_erase_source_content): Update.
2925 (tui_show_source_line, tui_source_window_base::update_tab_width)
2926 (tui_source_window_base::update_exec_info): Update.
2927 * tui/tui-data.h (struct curses_deleter): New.
2928 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2929 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2930
2931 2019-10-09 Tom Tromey <tom@tromey.com>
2932
2933 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2934
2935 2019-10-09 Tom Tromey <tom@tromey.com>
2936
2937 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2938 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2939
2940 2019-10-09 Tom Tromey <tom@tromey.com>
2941
2942 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2943 window height directly.
2944 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2945 declare.
2946 * tui/tui-layout.c (tui_default_win_height): Remove.
2947 (tui_default_win_viewport_height): Remove.
2948
2949 2019-10-09 Tom Tromey <tom@tromey.com>
2950
2951 * tui/tui.h: Remove comments.
2952
2953 2019-10-09 Tom de Vries <tdevries@suse.de>
2954
2955 * python/lib/gdb/printer/bound_registers.py: Use
2956 '^builtin_type_bound128' as regexp argument for
2957 add_builtin_pretty_printer.
2958
2959 2019-10-09 Christian Biesinger <cbiesinger@google.com>
2960
2961 * guile/guile.c (guile_extension_script_ops): Remove forward
2962 declaration and mark as static.
2963 (guile_script_ops): Likewise.
2964 (extension_language_guile): Move further down in the file so
2965 it can reference the definitions for guile_{extension_,}script_ops.
2966
2967 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2968
2969 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2970 except SORTL, DFLTCC, and KDSA.
2971
2972 2019-10-08 Tom Tromey <tromey@adacore.com>
2973
2974 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2975 (struct safe_symbol_file_add_args): Remove.
2976
2977 2019-10-08 Tom Tromey <tromey@adacore.com>
2978
2979 * windows-nat.c: Don't include buildsym-legacy.h.
2980
2981 2019-10-08 Tom Tromey <tromey@adacore.com>
2982
2983 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2984
2985 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2986
2987 * gdbtypes.c (overload_debug): Move comment to header.
2988 * gdbtypes.h (overload_debug): Declare.
2989 * valops.c: Remove declaration of overload_debug, instead
2990 include gdbtypes.h.
2991
2992 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2993
2994 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2995 through _().
2996 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2997 move comment...
2998 * language.h (lang_frame_mismatch_warn): ... here. Also add
2999 declaration.
3000 * top.c (lang_frame_mismatch_warn): Remove declaration.
3001 (check_frame_language_change): Pass lang_frame_mismatch_warn
3002 through _().
3003
3004 2019-10-07 Christian Biesinger <cbiesinger@google.com>
3005
3006 * c-lang.h (vtbl_ptr_name): Declare.
3007 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3008 it from the header.
3009 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3010
3011 2019-10-07 Christian Biesinger <cbiesinger@google.com>
3012
3013 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3014 gdb_static_assert.
3015
3016 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
3017
3018 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3019 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3020 * ctfread.c: New file.
3021 * ctfread.h: New file.
3022 * elfread.c: Include ctfread.h.
3023 (struct elfinfo text_p): New member ctfsect.
3024 (elf_locate_sections): Mark CTF section.
3025 (elf_symfile_read): Call elfctf_build_psymtabs.
3026 * Makefile.in (LIBCTF): Add.
3027 (CLIBS): Use it.
3028 (CDEPS): Likewise.
3029 (DIST): Add ctfread.c.
3030
3031 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3032
3033 * ctfread.c (struct nextfield): Renamed to ...
3034 (struct ctf_nextfield): ... this.
3035 (struct field_info): Renamed to ...
3036 (strut ctf_field_info): ... this.
3037 (attach_fields_to_type): Update for renamed structures.
3038 (ctf_add_member_cb): Likewise.
3039 (ctf_add_enum_member_cb): Likewise.
3040 (process_struct_members): Likewise.
3041 (process_enum_type): Likewise.
3042
3043 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
3044
3045 * tracectf.h: Rename, was ctf.h.
3046 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3047 * tracefile.c: Likewise.
3048 * tracepoint.c: Remove unused include ctf.h.
3049 * mi/mi-main.c: Likewise.
3050 * Makefile.in Replace ctf.c with tracectf.c.
3051
3052 2019-10-06 Joel Brobecker <brobecker@adacore.com>
3053
3054 * version.in: Change version number to "9.0.50.DATE-git".
3055
3056 2019-10-03 Tom Tromey <tom@tromey.com>
3057
3058 PR rust/24976:
3059 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3060
3061 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3062
3063 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3064 cp_search_name_hash.
3065 * NEWS: Add entry about nested function support.
3066
3067 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3068 Andrew Burgess <andrew.burgess@embecosm.com>
3069
3070 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3071 for nested static variables when searchin VAR_DOMAIN.
3072 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3073 global scope, update comment.
3074 (add_partial_subprogram): Call add_partial_subprogram recursively
3075 for nested subroutines when processinng Fortran.
3076 (load_partial_dies): Process the child entities of a subprogram
3077 when processing Fortran.
3078 (partial_die_parent_scope): Handle building scope
3079 for Fortran nested functions.
3080 (process_die): Record that nested functions have a scope.
3081 (new_symbol): Always record Fortran subprograms on the global
3082 symbol list.
3083 (determine_prefix): How to build the prefix for Fortran
3084 subprograms.
3085
3086 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3087
3088 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3089 have just sent the thread a SIGSTOP and are waiting for it to
3090 arrive.
3091
3092 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3093
3094 * btrace.c (btrace_add_pc): Remove whitespace before the template
3095 parameter in 'std::vector <...>'.
3096 (parse_xml_btrace_block): Likewise.
3097 (btrace_maint_decode_pt): Likewise.
3098 (btrace_maint_update_packets): Likewise.
3099 (btrace_maint_print_packets): Likewise.
3100 * btrace.h (struct btrace_maint_info): Likewise.
3101 * dwarf2read.c (struct type_unit_group): Likewise.
3102 (build_type_psymtabs_reader): Likewise.
3103 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3104 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3105 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3106
3107 2019-10-03 Tom de Vries <tdevries@suse.de>
3108
3109 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3110 the first line of the help text for set/show style metadata.
3111
3112 2019-10-02 Tom Tromey <tromey@adacore.com>
3113
3114 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3115 * gdbsupport/common-inferior.c: New file.
3116 * infcmd.c (startup_with_shell): Don't define.
3117 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3118 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3119 * inferior.h (startup_with_shell): Don't declare.
3120
3121 2019-10-02 Christian Biesinger <cbiesinger@google.com>
3122
3123 * gdbsupport/gdb_assert.h: Include errors.h.
3124 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3125
3126 2019-10-02 Tom Tromey <tromey@adacore.com>
3127
3128 * NEWS: Add $_ada_exception entry.
3129 * ada-lang.c (struct ada_catchpoint): Add constructor.
3130 <m_kind>: New member.
3131 (allocate_location_exception, re_set_exception): Remove
3132 "ex" parameter.
3133 (should_stop_exception): Compute $_ada_exception.
3134 (check_status_exception, print_it_exception)
3135 (print_one_exception, print_mention_exception): Remove
3136 "ex" parameter.
3137 (allocate_location_catch_exception, re_set_catch_exception)
3138 (check_status_exception, print_it_catch_exception)
3139 (print_one_catch_exception, print_mention_catch_exception)
3140 (print_recreate_catch_exception)
3141 (allocate_location_catch_exception_unhandled)
3142 (re_set_catch_exception_unhandled)
3143 (check_status_exception, print_it_catch_exception_unhandled)
3144 (print_one_catch_exception_unhandled)
3145 (print_mention_catch_exception_unhandled)
3146 (print_recreate_catch_exception_unhandled)
3147 (allocate_location_catch_assert, re_set_catch_assert)
3148 (check_status_assert, print_it_catch_assert)
3149 (print_one_catch_assert, print_mention_catch_assert)
3150 (print_recreate_catch_assert)
3151 (allocate_location_catch_handlers, re_set_catch_handlers)
3152 (check_status_handlers, print_it_catch_handlers)
3153 (print_one_catch_handlers, print_mention_catch_handlers)
3154 (print_recreate_catch_handlers): Remove.
3155 (create_ada_exception_catchpoint): Update.
3156 (initialize_ada_catchpoint_ops): Update.
3157
3158 2019-10-02 Tom Tromey <tromey@adacore.com>
3159
3160 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3161 (create_excep_cond_exprs): Simplify exception string computation.
3162 (ada_exception_catchpoint_cond_string): Likewise.
3163
3164 2019-10-02 Tom Tromey <tromey@adacore.com>
3165
3166 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3167 * ada-lang.c (lesseq_defined_than): Handle
3168 LOC_STATIC.
3169 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3170 parameter.
3171 (dwarf2_has_info): Likewise.
3172 (new_symbol): Set maybe_copied on symbol when
3173 appropriate.
3174 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3175 parameter.
3176 <can_copy>: New member.
3177 * elfread.c (record_minimal_symbol): Set maybe_copied
3178 on symbol when appropriate.
3179 (elf_symfile_read): Update call to dwarf2_has_info.
3180 * minsyms.c (lookup_minimal_symbol_linkage): New
3181 function.
3182 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3183 * symtab.c (get_symbol_address, get_msymbol_address):
3184 New functions.
3185 * symtab.h (get_symbol_address, get_msymbol_address):
3186 Declare.
3187 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3188 maybe_copied.
3189 (struct symbol, struct minimal_symbol) <maybe_copied>:
3190 New member.
3191
3192 2019-10-02 Tom Tromey <tromey@adacore.com>
3193
3194 * source.c (struct current_source_location): New.
3195 (current_source_key): New global.
3196 (current_source_symtab, current_source_line)
3197 (current_source_pspace): Remove.
3198 (get_source_location): New function.
3199 (get_current_source_symtab_and_line)
3200 (set_default_source_symtab_and_line)
3201 (set_current_source_symtab_and_line)
3202 (clear_current_source_symtab_and_line, select_source_symtab)
3203 (info_source_command, print_source_lines_base)
3204 (info_line_command, search_command_helper, _initialize_source):
3205 Update.
3206
3207 2019-10-02 Tom Tromey <tromey@adacore.com>
3208
3209 * source.c (select_source_symtab): Don't call
3210 decode_line_with_current_source.
3211
3212 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3213
3214 * symtab.c (lookup_global_symbol): Search global block.
3215
3216 2019-10-02 Tom Tromey <tromey@adacore.com>
3217
3218 * coffread.c (process_coff_symbol): Update.
3219 * dwarf2read.c (var_decode_location, new_symbol): Update.
3220 * mdebugread.c (parse_symbol): Update.
3221 * objfiles.c (relocate_one_symbol): Update.
3222 * stabsread.c (define_symbol, fix_common_block)
3223 (scan_file_globals): Update.
3224 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3225 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3226 * xcoffread.c (process_xcoff_symbol): Update.
3227
3228 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3229
3230 * MAINTAINERS: Update my email address.
3231
3232 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3233
3234 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3235 std::vector.
3236 (build_type_psymtabs_reader): Update for std::vector.
3237 (build_type_psymtab_dependencies): Likewise.
3238 * dwarf2read.h: Remove use of DEF_VEC_P.
3239 (typedef sig_type_ptr): Delete.
3240
3241 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3242
3243 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3244 to std::vector.
3245 (btrace_maint_decode_pt): Likewise, and move allocation of the
3246 vector outside of the loop.
3247 (btrace_maint_update_packets): Update to handle change from VEC to
3248 std::vector.
3249 (btrace_maint_print_packets): Likewise.
3250 (maint_info_btrace_cmd): Likewise.
3251 * btrace.h: Remove use of DEF_VEC_O.
3252 (typedef btrace_pt_packet_s): Delete.
3253 (struct btrace_maint_info) <packets>: Change fromm VEC to
3254 std::vector.
3255 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3256
3257 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3258
3259 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3260 make accesses into the vector constant references.
3261 (btrace_add_pc): Update for std::vector.
3262 (btrace_stitch_bts): Likewise.
3263 (parse_xml_btrace_block): Likewise.
3264 (btrace_maint_update_packets): Likewise.
3265 (btrace_maint_print_packets): Likewise.
3266 (maint_info_btrace_cmd): Likewise.
3267 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3268 std::vector.
3269 (btrace_data::empty): Likewise.
3270 (btrace_data_append): Likewise.
3271 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3272 (typedef btrace_block_s): Delete.
3273 (struct btrace_block): Add constructor.
3274 (struct btrace_data_bts) <blocks>: Change to std::vector.
3275 * nat/linux-btrace.c (perf_event_read_bts): Update for
3276 std::vector.
3277 (linux_read_bts): Likewise.
3278
3279 2019-10-01 Tom Tromey <tom@tromey.com>
3280
3281 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3282
3283 2019-10-01 Tom Tromey <tom@tromey.com>
3284
3285 * stack.c (print_frame, info_frame_command_core): Use
3286 styled_string.
3287 * linux-thread-db.c (try_thread_db_load_1)
3288 (try_thread_db_load_from_pdir_1): Use styled_string.
3289 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3290 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3291 (maybe_print_unsupported_script_warning)
3292 (maybe_print_script_not_found_warning): Use styled_string.
3293 * ada-lang.c (user_select_syms): Use styled_string.
3294
3295 2019-10-01 Tom Tromey <tom@tromey.com>
3296
3297 * p-lang.c (pascal_printstr): Use metadata style.
3298 * value.c (show_convenience): Use metadata style.
3299 * valprint.c (valprint_check_validity, val_print_optimized_out)
3300 (val_print_not_saved, val_print_unavailable)
3301 (val_print_invalid_address, generic_val_print, val_print)
3302 (value_check_printable, val_print_array_elements): Use metadata
3303 style.
3304 * ui-out.h (class ui_out) <field_fmt>: New overload.
3305 <do_field_fmt>: Add style parameter.
3306 * ui-out.c (ui_out::field_fmt): New overload.
3307 * typeprint.c (type_print_unknown_return_type)
3308 (val_print_not_allocated, val_print_not_associated): Use metadata
3309 style.
3310 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3311 parameter.
3312 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3313 * tracepoint.c (tvariables_info_1): Use metadata style.
3314 * stack.c (print_frame_arg, print_frame_info, print_frame)
3315 (info_frame_command_core): Use metadata style.
3316 * skip.c (info_skip_command): Use metadata style.
3317 * rust-lang.c (rust_print_enum): Use metadata style.
3318 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3319 metadata style.
3320 * python/py-framefilter.c (py_print_single_arg): Use metadata
3321 style.
3322 * printcmd.c (do_one_display, print_variable_and_value): Use
3323 metadata style.
3324 * p-valprint.c (pascal_val_print)
3325 (pascal_object_print_value_fields): Use metadata style.
3326 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3327 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3328 parameter.
3329 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3330 * m2-valprint.c (m2_print_long_set): Use metadata style.
3331 * m2-typeprint.c (m2_print_type): Use metadata style.
3332 * infcmd.c (print_return_value_1): Use metadata style.
3333 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3334 * f-valprint.c (info_common_command_for_block): Use metadata
3335 style.
3336 * f-typeprint.c (f_type_print_base): Use metadata style.
3337 * expprint.c (print_subexp_standard): Use metadata style.
3338 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3339 * cli/cli-style.h (class cli_style_option): Add constructor.
3340 (metadata_style): Declare.
3341 * cli/cli-style.c (metadata_style): New global.
3342 (_initialize_cli_style): Register metadata style.
3343 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3344 parameter.
3345 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3346 * c-typeprint.c (c_type_print_base_struct_union)
3347 (c_type_print_base_1): Use metadata style.
3348 * breakpoint.c (watchpoint_value_print)
3349 (print_one_breakpoint_location): Use metadata style.
3350 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3351 style.
3352 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3353 style.
3354 * ada-valprint.c (val_print_packed_array_elements, printstr)
3355 (print_field_values, ada_val_print_ref, ada_val_print): Use
3356 metadata style.
3357 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3358 style.
3359 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3360 style.
3361 * ada-lang.c (user_select_syms): Use metadata style.
3362
3363 2019-10-01 Tom Tromey <tom@tromey.com>
3364
3365 * cli/cli-cmds.c (pwd_command): Style output.
3366
3367 2019-10-01 Pedro Alves <palves@redhat.com>
3368 Tom Tromey <tom@tromey.com>
3369
3370 * symtab.c (print_symbol_info): Use %ps.
3371 (print_msymbol_info): Use %ps.
3372 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3373 * printcmd.c (print_variable_and_value): Use %ps.
3374 * macrocmd.c (show_pp_source_pos): Use %ps.
3375 * infrun.c (print_exited_reason): Use ui_out::message.
3376 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3377 (describe_other_breakpoints): Use ui_out::message and new
3378 formats.
3379 (say_where): Use new formats.
3380 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3381 and new formats.
3382
3383 2019-10-01 Pedro Alves <palves@redhat.com>
3384 Tom Tromey <tom@tromey.com>
3385
3386 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3387 (test_gdb_formats): New function.
3388 (run_tests): Call it.
3389 (test_format_specifier): Update.
3390 * utils.h (fputs_filtered): Update comment.
3391 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3392 (fputs_styled_unfiltered): Declare.
3393 * utils.c (fputs_styled_unfiltered): New function.
3394 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3395 (vfprintf_filtered): Update.
3396 (vfprintf_unfiltered, vprintf_filtered): Update.
3397 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3398 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3399 disallow_ui_out_field>: New constants.
3400 (enum class field_kind): New.
3401 (struct base_field_s, struct signed_field_s): New.
3402 (signed_field): New function.
3403 (struct string_field_s): New.
3404 (string_field): New function.
3405 (struct styled_string_s): New.
3406 (styled_string): New function.
3407 (class ui_out) <message>: Add comment.
3408 <vmessage, call_do_message>: New methods.
3409 <do_message>: Add style parameter.
3410 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3411 methods.
3412 (ui_out::message): Rewrite.
3413 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3414 parameter.
3415 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3416 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3417 gdb_extensions parameter.
3418 (class format_piece): Add parameter to constructor.
3419 (n_int_args): New field.
3420 * gdbsupport/format.c (format_pieces::format_pieces): Add
3421 gdb_extensions parameter. Handle '*'.
3422 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3423 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3424 vfprintf_styled_no_gdbfmt.
3425 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3426 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3427 unfiltered output.
3428 * ui-style.h (struct ui_file_style) <ptr>: New method.
3429
3430 2019-10-01 Tom Tromey <tom@tromey.com>
3431
3432 * unittests/format_pieces-selftests.c: Update. Add final format.
3433 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3434 empty literal pieces.
3435
3436 2019-10-01 Tom Tromey <tom@tromey.com>
3437
3438 * ui-out.h (enum class ui_out_style_kind): Remove.
3439 (class ui_out) <field_string, field_stsream, do_field_string>:
3440 Change type of "style".
3441 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3442 (ui_out::field_string): Update.
3443 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3444 of "style".
3445 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3446 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3447 * stack.c (print_frame_arg, print_frame_info, print_frame):
3448 Update.
3449 * source.c (print_source_lines_base): Update.
3450 * solib.c (info_sharedlibrary_command): Update.
3451 * skip.c (info_skip_command): Update.
3452 * record-btrace.c (btrace_call_history_src_line)
3453 (btrace_call_history): Update.
3454 * python/py-framefilter.c (py_print_frame): Update.
3455 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3456 "style".
3457 * mi/mi-out.c (mi_ui_out::do_table_header)
3458 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3459 (mi_ui_out::do_field_string): Update.
3460 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3461 Update.
3462 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3463 "style".
3464 * cli-out.c (cli_ui_out::do_table_header)
3465 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3466 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3467 (cli_ui_out::do_field_fmt): Update.
3468 * breakpoint.c (print_breakpoint_location): Update.
3469 (update_static_tracepoint): Update.
3470
3471 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3472
3473 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3474 conversion of gdb_datadir.
3475 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3476 remove not needed c_str ().
3477
3478 2019-09-30 Ali Tamur <tamur@google.com>
3479
3480 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3481 (dwarf2_string_attr): Likewise.
3482
3483 2019-09-30 Ali Tamur <tamur@google.com>
3484
3485 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3486 (process_full_type_unit): Likewise.
3487 (dump_die_shallow): Likewise.
3488 (cu_debug_loc_section): Likewise.
3489
3490 2019-09-28 Christian Biesinger <cbiesinger@google.com>
3491
3492 * minsyms.c (compare_minimal_symbols): Rename to...
3493 (minimal_symbol_is_less_than): ...this, and adjust to STL
3494 conventions (return bool, take arguments as references)
3495 (minimal_symbol_reader::install): Call std::sort instead
3496 of qsort.
3497
3498 2019-09-29 Christian Biesinger <cbiesinger@google.com>
3499
3500 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3501 hash and why.
3502 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3503 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3504
3505 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3506
3507 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3508 * psympriv.h (add_psymbol_to_list): Move comment here and update
3509 it.
3510
3511 2019-09-29 Tom de Vries <tdevries@suse.de>
3512
3513 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3514 Use $tmpdir/$(basename "$output_file").dwz instead of
3515 "${output_file}.dwz".
3516
3517 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3518
3519 PR gdb/25045
3520 * hppa-linux-nat.c: Include gdbarch.h.
3521
3522 2019-09-26 Christian Biesinger <cbiesinger@google.com>
3523
3524 * blockframe.c (find_pc_partial_function): Change return type to bool.
3525 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3526 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3527 (stub_gnu_ifunc_resolve_name): Likewise.
3528 * symtab.c (compare_filenames_for_search): Likewise.
3529 (compare_glob_filenames_for_search): Likewise.
3530 (matching_obj_sections): Likewise.
3531 (symbol_matches_domain): Likewise.
3532 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3533 (find_line_pc): Change return type to bool.
3534 (find_line_pc_range): Likewise.
3535 (producer_is_realview): Likewise.
3536 * symtab.h (symbol_matches_domain): Likewise.
3537 (find_pc_partial_function): Likewise.
3538 (find_pc_line_pc_range): Likewise.
3539 (in_gnu_ifunc_stub): Likewise.
3540 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3541 (find_line_pc): Likewise.
3542 (find_line_pc_range): Likewise.
3543 (matching_obj_sections): Likewise.
3544 (find_line_symtab): Change out parameter to bool.
3545 (producer_is_realview): Change return type to bool.
3546 (compare_filenames_for_search): Likewise.
3547 (compare_glob_filenames_for_search): Likewise.
3548
3549 2019-09-26 Tom Tromey <tom@tromey.com>
3550
3551 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3552 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3553 * gdb_usleep.h: Remove.
3554 * gdb_usleep.c: Remove.
3555 * utils.c: Don't include gdb_usleep.h.
3556
3557 2019-09-26 Tom Tromey <tromey@adacore.com>
3558
3559 * python/py-type.c (type_to_type_object): Call check_typedef
3560 for stub types.
3561
3562 2019-09-26 Tom Tromey <tom@tromey.com>
3563
3564 * utils.h (initialize_utils): Don't declare.
3565 * top.c (gdb_init): Don't call initialize_utils.
3566 * utils.c (initialize_utils): Remove. Move contents...
3567 (_initialize_utils): ... here.
3568
3569 2019-09-25 Tom Tromey <tom@tromey.com>
3570
3571 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3572 * utils.h (make_hex_string): Don't declare.
3573 * utils.c (make_hex_string): Remove.
3574
3575 2019-09-24 Tom de Vries <tdevries@suse.de>
3576
3577 PR gdb/23815
3578 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3579 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3580
3581 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3582
3583 * NEWS: Mention new simulator port for PRU.
3584
3585 2019-09-23 Christian Biesinger <cbiesinger@google.com>
3586
3587 * ada-exp.y (write_object_remaining): Update.
3588 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3589 and eliminate the static buffer.
3590 (ada_decode_symbol): Update.
3591 (ada_la_decode): Update.
3592 (ada_sniff_from_mangled_name): Update.
3593 (is_valid_name_for_wild_match): Update.
3594 (ada_lookup_name_info::matches): Update and simplify.
3595 (name_matches_regex): Update.
3596 (ada_add_global_exceptions): Update.
3597 * ada-lang.h (ada_decode): Update signature.
3598 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3599 * dwarf-index-write.c (debug_names::insert): Update.
3600
3601 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3602
3603 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3604 formatting.
3605
3606 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3607
3608 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3609 Change "nonzero" to "true" in documentation.
3610
3611 2019-09-20 Christian Biesinger <cbiesinger@google.com>
3612
3613 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3614 (_initialize_darwin_solib): Don't set
3615 darwin_so_ops.lookup_lib_global_symbol.
3616 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3617 set_gdbarch_iterate_over_objfiles_in_search_order.
3618 (elf_lookup_lib_symbol): Rename to...
3619 (svr4_iterate_over_objfiles_in_search_order): this, and update
3620 to iterate semantics.
3621 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3622 * solib.c (solib_global_lookup): Remove.
3623 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3624 (solib_global_lookup): Remove.
3625 * symtab.c (lookup_global_or_static_symbol): Remove call to
3626 solib_global_lookup.
3627
3628 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3629
3630 * NEWS: Move entries about default MI version now being
3631 version 3, and about the GDB/MI fix for multi-location
3632 breakpoints to the "since GDB 8.3" section.
3633
3634 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3635
3636 GDB 8.3.1 released.
3637
3638 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3639
3640 * NEWS: Mention that Cell/B.E. debugging support was removed.
3641 * MAINTAINERS: Remove spu target.
3642
3643 * config/djgpp/fnchange.lst: Remove entries for removed files.
3644
3645 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3646 spu-multiarch.o, and spu-tdep.o.
3647 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3648 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3649 spu-multiarch.c, and spu-tdep.c.
3650 * spu-linux-nat.c: Remove file.
3651 * spu-multiarch.c: Remove file.
3652 * spu-tdep.c: Remove file.
3653 * spu-tdep.h: Remove file.
3654 * solib-spu.c: Remove file.
3655 * solib-spu.h: Remove file.
3656
3657 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3658 * configure.nat (spu-linux): Remove.
3659 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3660 solib-multiarch.o from gdb_target_obs.
3661 (spu*-*-*): Remove.
3662
3663 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3664 feature flag.
3665 (ppc_linux_no_features): Update.
3666 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3667 Cell/B.E. support.
3668 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3669 (tdesc_powerpc_cell64l): Likewise.
3670 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3671 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3672 Cell/B.E. support.
3673 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3674 Do not include "features/rs6000/powerpc-cell32l.c" or
3675 "features/rs6000/powerpc-cell64l.c".
3676 (ppc_linux_spu_section): Remove.
3677 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3678 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3679 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3680 (ppc_linux_spe_context_lookup): Remove.
3681 (ppc_linux_spe_context_inferior_created): Remove.
3682 (ppc_linux_spe_context_solib_loaded): Remove.
3683 (ppc_linux_spe_context_solib_unloaded): Remove.
3684 (ppc_linux_spe_context): Remove.
3685 (struct ppu2spu_cache): Remove.
3686 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3687 (struct ppu2spu_data): Remove.
3688 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3689 ppu2spu_unwind): Remove.
3690 (ppc_linux_init_abi): Remove Cell/B.E. support.
3691 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3692
3693 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3694 (rs6000/powerpc-cell64l-expedite): Likewise
3695 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3696 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3697 rs6000/powerpc-cell64l.xml.
3698 * features/rs6000/powerpc-cell32l.xml: Remove.
3699 * features/rs6000/powerpc-cell64l.xml: Likewise.
3700 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3701 * features/rs6000/powerpc-cell64l.c: Likewise.
3702 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3703 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3704 * regformats/reg-spu.dat: Remove.
3705
3706 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3707 * corelow.c (struct spuid_list): Remove.
3708 (add_to_spuid_list): Remove.
3709 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3710 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3711 (remote_protocol_features): Remove associated entries.
3712 (_initialize_remote): No longer initialize them.
3713 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3714 * linux-nat.c (SPUFS_MAGIC): Remove.
3715 (linux_proc_xfer_spu): Remove.
3716 (spu_enumerate_spu_ids): Remove.
3717 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3718 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3719 (linux_make_corefile_notes): No longer call it.
3720
3721 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3722 (cooked_write_test): Likewise.
3723
3724 2019-09-20 Tom Tromey <tom@tromey.com>
3725
3726 * NEWS: Mention case-sensitivity of TUI commands.
3727 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3728 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3729 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3730
3731 2019-09-20 Tom Tromey <tom@tromey.com>
3732
3733 * tui/tui-source.c (tui_source_window::set_contents): Use
3734 make_unique_xstrdup.
3735 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3736 make_unique_xstrdup.
3737
3738 2019-09-20 Tom Tromey <tom@tromey.com>
3739
3740 * tui/tui-data.c: Remove separator comments.
3741 * tui/tui-layout.c: Remove separator comments.
3742 * tui/tui-win.c: Remove separator comments.
3743 * tui/tui-wingeneral.c: Remove separator comments.
3744
3745 2019-09-20 Tom Tromey <tom@tromey.com>
3746
3747 * tui/tui.h (strcat_to_buf): Don't declare.
3748 * tui/tui.c (strcat_to_buf): Remove.
3749
3750 2019-09-20 Tom Tromey <tom@tromey.com>
3751
3752 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3753 from "fullname".
3754 * tui/tui-source.c (tui_source_window::set_contents)
3755 (tui_source_window::location_matches_p)
3756 (tui_source_window::maybe_update): Update.
3757
3758 2019-09-20 Tom Tromey <tom@tromey.com>
3759
3760 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3761 Update.
3762 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3763 prefix.
3764 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3765 (tui_data_window::line_from_reg_element_no)
3766 (tui_data_window::first_reg_element_no_inline)
3767 (tui_data_window::show_registers)
3768 (tui_data_window::show_register_group)
3769 (tui_data_window::display_registers_from)
3770 (tui_data_window::display_registers_from_line)
3771 (tui_data_window::first_data_item_displayed)
3772 (tui_data_window::delete_data_content_windows)
3773 (tui_data_window::erase_data_content)
3774 (tui_data_window::do_scroll_vertical)
3775 (tui_data_window::refresh_window)
3776 (tui_data_window::check_register_values): Update.
3777
3778 2019-09-20 Tom Tromey <tom@tromey.com>
3779
3780 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3781 (struct tui_locator_window) <full_name, proc_name>: Now
3782 std::string.
3783 * tui/tui-stack.c (tui_locator_window::make_status_line)
3784 (tui_locator_window::set_locator_fullname)
3785 (tui_locator_window::set_locator_info): Update.
3786 * tui/tui-source.c (tui_source_window::set_contents)
3787 (tui_source_window::showing_source_p): Update.
3788
3789 2019-09-20 Tom Tromey <tom@tromey.com>
3790
3791 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3792 Don't call tui_locator_win_info_ptr.
3793
3794 2019-09-20 Tom Tromey <tom@tromey.com>
3795
3796 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3797
3798 2019-09-20 Tom Tromey <tom@tromey.com>
3799
3800 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3801 height for locator.
3802 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3803 * tui/tui-layout.c (show_source_disasm_command, show_data)
3804 (show_source_or_disasm_and_command): Use 1 as height for locator.
3805
3806 2019-09-20 Tom Tromey <tom@tromey.com>
3807
3808 * tui/tui.c (tui_enable): Update.
3809 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3810 Update.
3811 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3812 Update.
3813 * tui/tui-data.c (win_resized): Now bool.
3814 (tui_win_resized): Return bool.
3815 (tui_set_win_resized_to): Accept a bool.
3816
3817 2019-09-20 Tom Tromey <tom@tromey.com>
3818
3819 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3820 Change type of "refresh_values_only".
3821 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3822 type of "refresh_values_only".
3823
3824 2019-09-20 Tom Tromey <tom@tromey.com>
3825
3826 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3827 std::string.
3828 (tui_disassemble): Add "pos" parameter.
3829 (tui_disasm_window::set_contents): Simplify.
3830
3831 2019-09-20 Tom Tromey <tom@tromey.com>
3832
3833 * tui/tui-winsource.h (struct tui_source_window_base)
3834 <show_source_content>: Now private.
3835 * tui/tui-winsource.c
3836 (tui_source_window_base::show_source_content): Don't handle empty
3837 content case.
3838
3839 2019-09-20 Tom Tromey <tom@tromey.com>
3840
3841 * tui/tui-layout.c (show_source_disasm_command)
3842 (show_source_or_disasm_and_command): Don't call
3843 show_source_content.
3844
3845 2019-09-20 Tom Tromey <tom@tromey.com>
3846
3847 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3848 Declare.
3849 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3850 from tui_make_status_line.
3851 (tui_locator_window::rerender): Update.
3852
3853 2019-09-20 Tom Tromey <tom@tromey.com>
3854
3855 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3856 (tui_locator_window::rerender): Update.
3857
3858 2019-09-20 Tom Tromey <tom@tromey.com>
3859
3860 * tui/tui-winsource.h (struct tui_source_window_base)
3861 <~tui_source_window_base>: Don't declare.
3862 <fullname>: Remove.
3863 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3864 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3865 member.
3866 * tui/tui-source.c (tui_source_window::set_contents): Update.
3867 (tui_source_window::location_matches_p)
3868 (tui_source_window::maybe_update): Update.
3869
3870 2019-09-20 Tom Tromey <tom@tromey.com>
3871
3872 * tui/tui-winsource.h (~tui_source_element): Remove.
3873 (tui_source_element): Update.
3874 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3875 * tui/tui-winsource.c (tui_show_source_line): Update.
3876 * tui/tui-source.c (tui_source_window::set_contents): Update.
3877 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3878
3879 2019-09-20 Tom Tromey <tom@tromey.com>
3880
3881 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3882 declare.
3883 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3884 tui_clear_source_windows_detail.
3885 * tui/tui-winsource.h (struct tui_source_window_base)
3886 <clear_detail>: Don't declare.
3887 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3888 Remove.
3889 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3890
3891 2019-09-20 Tom Tromey <tromey@adacore.com>
3892
3893 PR ada/24919:
3894 * block.c (contained_in): Fix final return value.
3895
3896 2019-09-20 Alan Modra <amodra@gmail.com>
3897
3898 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3899 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3900 (read_indirect_string_from_dwz): Use bfd accessor.
3901 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3902 * machoread.c (macho_symfile_read_all_oso): Likewise.
3903 * solib.c (solib_bfd_open): Likewise.
3904
3905 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3906
3907 * eval.c: Move declaration of overload_resolution to...
3908 * value.h: ...here.
3909
3910 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3911
3912 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3913 * arm-linux-tdep.c: Likewise.
3914 * arm-nbsd-nat.c: Likewise.
3915 * arm-tdep.h: Declare arm_apcs_32.
3916 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3917
3918 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3919
3920 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3921 * dwarf2read.h: Declare dwarf_always_disassemble.
3922
3923 2019-09-19 Tom de Vries <tdevries@suse.de>
3924
3925 PR gdb/25009
3926 * source-cache.c (source_cache::ensure): Catch exception thrown during
3927 construction of the highlighter.
3928
3929 2019-09-18 Alan Modra <amodra@gmail.com>
3930
3931 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3932 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3933 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3934 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3935 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3936 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3937 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3938 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3939 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3940 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3941 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3942 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3943 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3944 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3945 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3946 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3947 * mi/mi-interp.c: Update throughout for bfd section macro and
3948 function changes.
3949 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3950 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3951
3952 2019-09-18 Tom Tromey <tom@tromey.com>
3953
3954 * NEWS: Add entry.
3955 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3956 call rl_initialize.
3957 (tui_enable): Do not call rl_initialize.
3958
3959 2019-09-18 Christian Groessler <chris@groessler.org>
3960
3961 * alpha-linux-nat.c: Include gdbarch.h.
3962
3963 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3964
3965 * ui-file.c: Include cli/cli-style.h.
3966 (term_cli_styling): Remove cli_styling declaration.
3967
3968 2019-09-18 Alan Modra <amodra@gmail.com>
3969
3970 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3971 to bfd_asymbol_section.
3972
3973 2019-09-18 Alan Modra <amodra@gmail.com>
3974
3975 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3976 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3977 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3978
3979 2019-09-18 Alan Modra <amodra@gmail.com>
3980
3981 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3982 * spu-linux-nat.c (spu_bfd_open): Likewise.
3983
3984 2019-09-18 Christian Biesinger <cbiesinger@google.com>
3985
3986 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3987 to bool to match definition in dwarf2read.c.
3988
3989 2019-09-17 Christian Biesinger <cbiesinger@google.com>
3990
3991 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3992 (print_signatures): Likewise.
3993 (trust_pad_over_xvs): Likewise.
3994 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3995 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3996 * arm-linux-nat.c (arm_apcs_32): Likewise.
3997 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3998 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3999 * arm-tdep.c (arm_debug): Likewise.
4000 (arm_apcs_32): Likewise.
4001 * auto-load.c (debug_auto_load): Likewise.
4002 (auto_load_gdb_scripts): Likewise.
4003 (global_auto_load): Likewise.
4004 (auto_load_local_gdbinit): Likewise.
4005 (auto_load_local_gdbinit_loaded): Likewise.
4006 * auto-load.h (global_auto_load): Likewise.
4007 (auto_load_local_gdbinit): Likewise.
4008 (auto_load_local_gdbinit_loaded): Likewise.
4009 * breakpoint.c (disconnected_dprintf): Likewise.
4010 (breakpoint_proceeded): Likewise.
4011 (automatic_hardware_breakpoints): Likewise.
4012 (always_inserted_mode): Likewise.
4013 (target_exact_watchpoints): Likewise.
4014 (_initialize_breakpoint): Update.
4015 * breakpoint.h (target_exact_watchpoints): Change to bool.
4016 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4017 * cli/cli-cmds.c (trace_commands): Likewise.
4018 * cli/cli-cmds.h (trace_commands): Likewise.
4019 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4020 to bool*.
4021 * cli/cli-logging.c (logging_overwrite): Change to bool.
4022 (logging_redirect): Likewise.
4023 (debug_redirect): Likewise.
4024 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4025 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4026 to bool.
4027 <boolean_option_def>: Update.
4028 (struct flag_option_def): Change default type of Context to bool
4029 from int.
4030 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4031 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4032 (get_setshow_command_value_string): Likewise.
4033 * cli/cli-style.c (cli_styling): Change to bool.
4034 (source_styling): Likewise.
4035 * cli/cli-style.h (source_styling): Likewise.
4036 (cli_styling): Likewise.
4037 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4038 to bool.
4039 * command.h (var_types): Update comment.
4040 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4041 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4042 bool.
4043 (debug_compile_cplus_scopes): Likewise.
4044 * compile/compile-internal.h (compile_debug): Likewise.
4045 * compile/compile.c (compile_debug): Likewise.
4046 (struct compile_options) <raw>: Likewise.
4047 * cp-support.c (catch_demangler_crashes): Likewise.
4048 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4049 (usr_cmd_cris_dwarf2_cfi): Likewise.
4050 * csky-tdep.c (csky_debug): Likewise.
4051 * darwin-nat.c (enable_mach_exceptions): Likewise.
4052 * dcache.c (dcache_enabled_p): Likewise.
4053 * defs.h (info_verbose): Likewise.
4054 * demangle.c (demangle): Likewise.
4055 (asm_demangle): Likewise.
4056 * dwarf-index-cache.c (debug_index_cache): Likewise.
4057 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4058 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4059 * dwarf2read.c (check_physname): Likewise.
4060 (use_deprecated_index_sections): Likewise.
4061 (dwarf_always_disassemble): Likewise.
4062 * eval.c (overload_resolution): Likewise.
4063 * event-top.c (set_editing_cmd_var): Likewise.
4064 (exec_done_display_p): Likewise.
4065 * event-top.h (set_editing_cmd_var): Likewise.
4066 (exec_done_display_p): Likewise.
4067 * exec.c (write_files): Likewise.
4068 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4069 (debug_fbsd_nat): Likewise.
4070 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4071 Likewise.
4072 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4073 <backtrace_past_entry> Likewise.
4074 * gdb-demangle.h (demangle): Likewise.
4075 (asm_demangle): Likewise.
4076 * gdb_bfd.c (bfd_sharing): Likewise.
4077 * gdbcore.h (write_files): Likewise.
4078 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4079 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4080 * gdbthread.h (print_thread_events): Likewise.
4081 * gdbtypes.c (opaque_type_resolution): Likewise.
4082 (strict_type_checking): Likewise.
4083 * gnu-nat.c (gnu_debug_flag): Likewise.
4084 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4085 * guile/scm-param.c (pascm_variable): Add boolval.
4086 (add_setshow_generic): Update.
4087 (pascm_param_value): Update.
4088 (pascm_set_param_value_x): Update.
4089 * hppa-tdep.c (hppa_debug): Change to bool..
4090 * infcall.c (may_call_functions_p): Likewise.
4091 (coerce_float_to_double_p): Likewise.
4092 (unwind_on_signal_p): Likewise.
4093 (unwind_on_terminating_exception_p): Likewise.
4094 * infcmd.c (startup_with_shell): Likewise.
4095 * inferior.c (print_inferior_events): Likewise.
4096 * inferior.h (startup_with_shell): Likewise.
4097 (print_inferior_events): Likewise.
4098 * infrun.c (step_stop_if_no_debug): Likewise.
4099 (detach_fork): Likewise.
4100 (debug_displaced): Likewise.
4101 (disable_randomization): Likewise.
4102 (non_stop): Likewise.
4103 (non_stop_1): Likewise.
4104 (observer_mode): Likewise.
4105 (observer_mode_1): Likewise.
4106 (set_observer_mode): Update.
4107 (sched_multi): Change to bool.
4108 * infrun.h (debug_displaced): Likewise.
4109 (sched_multi): Likewise.
4110 (step_stop_if_no_debug): Likewise.
4111 (non_stop): Likewise.
4112 (disable_randomization): Likewise.
4113 * linux-tdep.c (use_coredump_filter): Likewise.
4114 (dump_excluded_mappings): Likewise.
4115 * linux-thread-db.c (auto_load_thread_db): Likewise.
4116 (check_thread_db_on_load): Likewise.
4117 * main.c (captured_main_1): Update.
4118 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4119 xx2_opt, boolean_opt>: Change to bool.
4120 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4121 * maint.c (maintenance_profile_p): Likewise.
4122 (per_command_time): Likewise.
4123 (per_command_space): Likewise.
4124 (per_command_symtab): Likewise.
4125 * memattr.c (inaccessible_by_default): Likewise.
4126 * mi/mi-main.c (mi_async): Likewise.
4127 (mi_async_1): Likewise.
4128 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4129 * nat/fork-inferior.h (startup_with_shell): Likewise.
4130 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4131 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4132 * nios2-tdep.c (nios2_debug): Likewise.
4133 * or1k-tdep.c (or1k_debug): Likewise.
4134 * parse.c (parser_debug): Likewise.
4135 * parser-defs.h (parser_debug): Likewise.
4136 * printcmd.c (print_symbol_filename): Likewise.
4137 * proc-api.c (procfs_trace): Likewise.
4138 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4139 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4140 (set_parameter_value): Update.
4141 (add_setshow_generic): Update.
4142 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4143 to bool*.
4144 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4145 int*.
4146 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4147 * record-btrace.c (record_btrace_target::store_registers): Update.
4148 * record-full.c (record_full_memory_query): Change to bool.
4149 (record_full_stop_at_limit): Likewise.
4150 * record-full.h (record_full_memory_query): Likewise.
4151 * remote-notif.c (notif_debug): Likewise.
4152 * remote-notif.h (notif_debug): Likewise.
4153 * remote.c (use_range_stepping): Likewise.
4154 (interrupt_on_connect): Likewise.
4155 (remote_break): Likewise.
4156 * ser-tcp.c (tcp_auto_retry): Likewise.
4157 * ser-unix.c (serial_hwflow): Likewise.
4158 * skip.c (debug_skip): Likewise.
4159 * solib-aix.c (solib_aix_debug): Likewise.
4160 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4161 (spu_auto_flush_cache_p): Likewise.
4162 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4163 Likewise.
4164 (struct info_print_options) <quiet>: Likewise.
4165 * symfile-debug.c (debug_symfile): Likewise.
4166 * symfile.c (auto_solib_add): Likewise.
4167 (separate_debug_file_debug): Likewise.
4168 * symfile.h (auto_solib_add): Likewise.
4169 (separate_debug_file_debug): Likewise.
4170 * symtab.c (basenames_may_differ): Likewise.
4171 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4172 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4173 (struct info_types_options) <quiet>: Likewise.
4174 * symtab.h (demangle): Likewise.
4175 (basenames_may_differ): Likewise.
4176 * target-dcache.c (stack_cache_enabled_1): Likewise.
4177 (code_cache_enabled_1): Likewise.
4178 * target.c (trust_readonly): Likewise.
4179 (may_write_registers): Likewise.
4180 (may_write_memory): Likewise.
4181 (may_insert_breakpoints): Likewise.
4182 (may_insert_tracepoints): Likewise.
4183 (may_insert_fast_tracepoints): Likewise.
4184 (may_stop): Likewise.
4185 (auto_connect_native_target): Likewise.
4186 (target_stop_and_wait): Update.
4187 (target_async_permitted): Change to bool.
4188 (target_async_permitted_1): Likewise.
4189 (may_write_registers_1): Likewise.
4190 (may_write_memory_1): Likewise.
4191 (may_insert_breakpoints_1): Likewise.
4192 (may_insert_tracepoints_1): Likewise.
4193 (may_insert_fast_tracepoints_1): Likewise.
4194 (may_stop_1): Likewise.
4195 * target.h (target_async_permitted): Likewise.
4196 (may_write_registers): Likewise.
4197 (may_write_memory): Likewise.
4198 (may_insert_breakpoints): Likewise.
4199 (may_insert_tracepoints): Likewise.
4200 (may_insert_fast_tracepoints): Likewise.
4201 (may_stop): Likewise.
4202 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4203 (make_thread_apply_all_options_def_group): Change argument from int*
4204 to bool*.
4205 (thread_apply_all_command): Update.
4206 (print_thread_events): Change to bool.
4207 * top.c (confirm): Likewise.
4208 (command_editing_p): Likewise.
4209 (history_expansion_p): Likewise.
4210 (write_history_p): Likewise.
4211 (info_verbose): Likewise.
4212 * top.h (confirm): Likewise.
4213 (history_expansion_p): Likewise.
4214 * tracepoint.c (disconnected_tracing): Likewise.
4215 (circular_trace_buffer): Likewise.
4216 * typeprint.c (print_methods): Likewise.
4217 (print_typedefs): Likewise.
4218 * utils.c (debug_timestamp): Likewise.
4219 (sevenbit_strings): Likewise.
4220 (pagination_enabled): Likewise.
4221 * utils.h (sevenbit_strings): Likewise.
4222 (pagination_enabled): Likewise.
4223 * valops.c (overload_resolution): Likewise.
4224 * valprint.h (struct value_print_options) <prettyformat_arrays,
4225 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4226 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4227 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4228 Likewise.
4229 * windows-nat.c (new_console): Likewise.
4230 (cygwin_exceptions): Likewise.
4231 (new_group): Likewise.
4232 (debug_exec): Likewise.
4233 (debug_events): Likewise.
4234 (debug_memory): Likewise.
4235 (debug_exceptions): Likewise.
4236 (useshell): Likewise.
4237 * windows-tdep.c (maint_display_all_tib): Likewise.
4238 * xml-support.c (debug_xml): Likewise.
4239
4240 2019-09-17 Mike Gulick <mgulick@mathworks.com>
4241
4242 * source.c (prepare_path_for_appending): New function.
4243 (openp): Make use of new function.
4244 (find_and_open_source): Search for the compilation directory and
4245 source file as a relative path beneath the directory search path.
4246
4247 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4248
4249 * source-cache.c (source_cache::get_line_charpos): Catch
4250 exceptions and return false, this matches the behaviour documented
4251 in the header file.
4252
4253 2019-09-17 Joel Brobecker <brobecker@adacore.com>
4254
4255 * ada-tasks.c (info_task): Remove quoting of the task's name.
4256
4257 2019-09-16 Christian Biesinger <cbiesinger@google.com>
4258
4259 * symfile.c (auto_solib_add): Replace comment with a reference
4260 to the header file.
4261
4262 2019-09-14 Christian Biesinger <cbiesinger@google.com>
4263
4264 * NEWS: Mention that gdb can now be compiled with Python 3
4265 on Windows.
4266
4267 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4268
4269 * maint.c (maint_print_section_data::maint_print_section_data):
4270 Force use of 'float log10 (float)' by casting the argument to
4271 float.
4272
4273 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4274
4275 * maint.c: Add 'cmath' include.
4276 (struct maint_print_section_data): New structure.
4277 (print_section_index): New function.
4278 (print_bfd_section_info): Add header comment, small whitespace
4279 cleanup, and update to call new print_section_index function.
4280 (print_objfile_section_info): Likewise.
4281 (maint_obj_section_from_bfd_section): New function.
4282 (print_bfd_section_info_maybe_relocated): New function.
4283 (maintenance_info_sections): Add header comment, always use
4284 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4285
4286 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4287
4288 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4289 inner scope, add check that the objfile has psymtabs before
4290 checking psymtabs_addrmap.
4291 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4292
4293 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4294
4295 * NEWS: Announce that Ada task names are now shown at more places,
4296 and between quotes (except in info task output).
4297 * gdb/ada-tasks.c (task_to_str): New function.
4298 (display_current_task_id): Call task_to_str.
4299 (task_command_1): Likewise.
4300 (print_ada_task_info): In non-mi mode, Properly align headers and data
4301 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4302
4303 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4304
4305 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4306 prstatus.pr_lwp.pr_info instead of making it up.
4307
4308 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4309
4310 * auto-load.c (auto_load_expand_dir_vars): Update.
4311 * defs.h (gdb_datadir): Change to std::string.
4312 (python_libdir): Likewise.
4313 (relocate_gdb_directory): Change return type to std::string.
4314 * guile/guile.c (gdbscm_data_directory): Update.
4315 (initialize_scheme_side): Update.
4316 * jit.c (jit_reader_dir): Change to std::string.
4317 (jit_reader_load_command): Update.
4318 * main.c (gdb_datadir): Change to std::string.
4319 (python_libdir): Likewise.
4320 (set_gdb_data_directory): Update.
4321 (relocate_path): Change to return std::string.
4322 (relocate_gdb_directory): Change to return std::string.
4323 (relocate_gdbinit_path_maybe_in_datadir): Update.
4324 (captured_main_1): Update.
4325 * python/python.c (do_start_initialization): Update.
4326 * top.c (show_gdb_datadir): Update.
4327 * xml-syscall.c (xml_init_syscalls_info): Update.
4328 (init_syscalls_info): Update.
4329
4330 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4331
4332 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4333 out of get_init_files.
4334 (get_init_files): Update.
4335
4336 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4337
4338 * main.c (get_init_files): Change to use std::string.
4339 (captured_main_1): Update.
4340 (print_gdb_help): Update.
4341
4342 2019-09-11 Ali Tamur <tamur@google.com>
4343
4344 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4345 implementation.
4346
4347 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4348
4349 * dbxread.c (read_dbx_symtab): Update.
4350 * dwarf2read.c (load_partial_dies): Update.
4351 * mdebugread.c (parse_partial_symbols): Update.
4352 (handle_psymbol_enumerators): Update.
4353 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4354 * psymtab.c (add_psymbol_to_bcache): Likewise.
4355 (add_psymbol_to_list): Likewise.
4356 * symtab.c (symbol_set_names): Likewise.
4357 * symtab.h (symbol_set_names): Likewise.
4358 * xcoffread.c (scan_xcoff_symtab): Update.
4359
4360 2019-09-11 Tom Tromey <tom@tromey.com>
4361
4362 * symfile-mem.c (symbol_file_add_from_memory): Use
4363 bfd_set_filename.
4364 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4365 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4366
4367 2019-09-10 Tom Tromey <tromey@adacore.com>
4368
4369 * dwarf-index-write.c (write_psymbols): Extend error message.
4370 (debug_names::insert): Add Ada code.
4371 (debug_names::write_psymbols): Remove Ada check.
4372 (debug_names) <m_string_obstack>: New member.
4373 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4374 (gdb_index_symbol_name_matcher::matches): Remove.
4375 (mapped_index_base::find_name_components_bounds): Add "lang"
4376 parameter.
4377 (mapped_index_base::build_name_components): Also split names
4378 according to Ada syntax.
4379 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4380 type of "match_callback".
4381 (check_match, check_find_bounds_finds)
4382 (dw2_expand_symtabs_matching): Update.
4383 (dw2_debug_names_iterator): Add new constructor.
4384 (dw2_debug_names_map_matching_symbols): New function.
4385 (dw2_debug_names_expand_symtabs_matching): Update.
4386 (dwarf2_debug_names_functions): Use
4387 dw2_debug_names_map_matching_symbols.
4388
4389 2019-09-10 Tom Tromey <tromey@adacore.com>
4390
4391 * dwarf2read.c (dw2_get_file_names_reader): Add the
4392 CU's file name to the results.
4393
4394 2019-09-10 Tom Tromey <tromey@adacore.com>
4395
4396 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4397 map_matching_symbols. Update.
4398 * dwarf2read.c (dw2_map_matching_symbols): Update.
4399 * psymtab.c (match_partial_symbol): Change type; update.
4400 (psym_map_matching_symbols): Likewise.
4401 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4402 type; update.
4403 * symfile.h (struct quick_symbol_functions)
4404 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4405 Remove "match".
4406
4407 2019-09-10 Tom Tromey <tromey@adacore.com>
4408
4409 * psymtab.c (map_block): Remove.
4410 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4411 * symtab.c (iterate_over_symbols_terminated): New function.
4412 * symtab.c (iterate_over_symbols_terminated): Declare.
4413
4414 2019-09-10 Tom Tromey <tromey@adacore.com>
4415
4416 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4417 * language.h (struct language_defn) <la_iterate_over_symbols>:
4418 Return bool.
4419 * symtab.c (iterate_over_symbols): Return bool.
4420 * symtab.h (iterate_over_symbols): Return bool.
4421
4422 2019-09-10 Tom Tromey <tromey@adacore.com>
4423
4424 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4425 (add_nonlocal_symbols): Update.
4426 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4427 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4428 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4429 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4430 Change type of "callback". Remove "data".
4431
4432
4433 2019-09-09 Ali Tamur <tamur@google.com>
4434
4435 * dwarf2read.c (comp_unit_head): Update comment.
4436 (dwarf2_dwo_name): New function declaration.
4437 (dwarf_unit_type_name): New function declaration.
4438 (read_comp_unit_head): Add support for new compilation units,
4439 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4440 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4441 (currently named as "signature") in their header. Also clarify error
4442 messages.
4443 (lookup_dwo_id): New function. Returns the dwo id of the given
4444 compile unit.
4445 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4446 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4447 functions.
4448 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4449 (dwarf2_dwo_name): Get the dwo name if present.
4450 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4451 purposes.
4452
4453 2019-09-09 Tom Tromey <tom@tromey.com>
4454
4455 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4456
4457 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4458
4459 * python/python.c (do_start_initialization): Make progname_copy static,
4460 to avoid a leak report.
4461
4462 2019-09-08 Tom Tromey <tom@tromey.com>
4463
4464 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4465
4466 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
4467
4468 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4469 Change type to gdb::optional<block_enum>.
4470 (dw2_symtab_iter_init): Change block_index parameter type
4471 to gdb::optional<block_enum>.
4472 (dw2_lookup_symbol): Change block_index parameter
4473 type to block_enum.c
4474 (dw2_debug_names_lookup_symbol): Likewise.
4475 * psymtab.c (psym_lookup_symbol): Likewise.
4476 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4477 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4478 Likewise.
4479
4480 2019-09-06 Christian Biesinger <cbiesinger@google.com>
4481
4482 * defs.h (relocate_gdb_directory): Change int to bool in
4483 signature and rename flag to relocatable.
4484 * main.c (relocate_path): Likewise.
4485 (relocate_gdb_directory): Likewise.
4486
4487 2019-09-06 Alan Modra <amodra@gmail.com>
4488
4489 * coffread.c (coff_symfile_read): Constify filename variable.
4490 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4491 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4492 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4493 * solib.c (reload_shared_libraries_1): Likewise.
4494 * symfile.c (reread_symbols): Likewise.
4495 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4496 * solib-darwin.c (darwin_bfd_open): Likewise.
4497 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4498
4499 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4500
4501 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4502 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4503
4504 2019-09-03 Tom Tromey <tromey@adacore.com>
4505
4506 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4507 types.
4508 (has_negatives): Unbias a range type bound.
4509 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4510 * gdbtypes.c (operator==): Handle new field.
4511 (create_range_type): Add "bias" parameter.
4512 (create_static_range_type, resolve_dynamic_range): Update.
4513 * gdbtypes.h (struct range_bounds) <bias>: New member.
4514 (create_range_type): Add bias parameter.
4515 * printcmd.c (print_scalar_formatted): Unbias range types.
4516 * value.c (unpack_long): Unbias range types.
4517 (pack_long): Bias range types.
4518
4519 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4520
4521 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4522 probe arguments.
4523
4524 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4525
4526 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4527 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4528 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4529 (compile_probe_arg): Likewise.
4530 * probe.h (get_argument_count): Likewise.
4531 * solib-svr4.c (solib_event_probe_action): Likewise.
4532 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4533
4534 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4535
4536 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4537 code to here...
4538 (svr4_create_solib_event_breakpoints): ...from here.
4539
4540 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4541
4542 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4543 suffix from warning message.
4544
4545 2019-08-30 Tom Tromey <tom@tromey.com>
4546
4547 * tui/tui-winsource.h (struct tui_source_window_base)
4548 <refresh_all>: Don't declare.
4549 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4550 Remove.
4551 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4552 tui_show_locator_content.
4553 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4554 declare.
4555 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4556 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4557 declare.
4558
4559 2019-08-30 Tom Tromey <tom@tromey.com>
4560
4561 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4562
4563 2019-08-30 Tom Tromey <tom@tromey.com>
4564
4565 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4566 Remove unnecessary forward declarations.
4567
4568 2019-08-30 Tom Tromey <tom@tromey.com>
4569
4570 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4571 rerender.
4572 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4573 tui_show_locator_content.
4574
4575 2019-08-30 Tom Tromey <tom@tromey.com>
4576
4577 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4578 (tui_locator_window::rerender): Rewrite using body of previous
4579 tui_show_locator_content.
4580
4581 2019-08-30 Tom Tromey <tom@tromey.com>
4582
4583 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4584 set_locator_fullname>: New methods.
4585 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4586 Rename from tui_set_locator_fullname.
4587 (tui_locator_window::set_locator_info): Rename from
4588 tui_set_locator_info. Return bool.
4589 (tui_update_locator_fullname, tui_show_frame_info): Update.
4590
4591 2019-08-30 Tom Tromey <tom@tromey.com>
4592
4593 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4594
4595 2019-08-30 Tom Tromey <tom@tromey.com>
4596
4597 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4598 call touchwin.
4599
4600 2019-08-30 Tom Tromey <tom@tromey.com>
4601
4602 * tui/tui-wingeneral.c (box_win): Assume win_info and
4603 win_info->handle cannot be NULL.
4604
4605 2019-08-30 Tom Tromey <tom@tromey.com>
4606
4607 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4608 refresh_window>: Declare.
4609 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4610 resize.
4611 (tui_data_item_window::rerender): Rename from
4612 tui_display_register.
4613 (tui_data_item_window::refresh_window): New method.
4614 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4615 no-op.
4616
4617 2019-08-30 Tom Tromey <tom@tromey.com>
4618
4619 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4620 regs_column_count, current_group>: Move later. Now private.
4621 <get_current_group>: New method.
4622 * tui/tui-regs.c (tui_reg_command): Update.
4623 * tui/tui-layout.c (tui_set_layout): Update.
4624
4625 2019-08-30 Tom Tromey <tom@tromey.com>
4626
4627 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4628 (tui_data_window::rerender): Don't call
4629 check_and_display_highlight_if_needed.
4630 (tui_data_window::refresh_all): Remove call to
4631 erase_data_content.
4632
4633 2019-08-30 Tom Tromey <tom@tromey.com>
4634
4635 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4636 (tui_data_window::display_registers_from)
4637 (tui_data_window::display_reg_element_at_line)
4638 (tui_data_window::display_registers_from_line): Remove checks of
4639 "empty".
4640
4641 2019-08-30 Tom Tromey <tom@tromey.com>
4642
4643 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4644 Don't declare.
4645 * tui/tui-regs.c (tui_data_window::show_registers): Call
4646 rerender.
4647 (tui_data_window::rerender): Rename from display_all_data.
4648 (tui_data_window::rerender): Remove old implementation.
4649
4650 2019-08-30 Tom Tromey <tom@tromey.com>
4651
4652 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4653 text.
4654 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4655
4656 2019-08-29 Bernhard Wodok <barto@gmx.net>
4657 Sergio Durigan Junior <sergiodj@redhat.com>
4658
4659 PR win32/24284
4660 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4661
4662 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4663
4664 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4665 when searching for types.
4666
4667 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4668
4669 * f-lang.c (f_language_defn): Use f_print_typedef.
4670 * f-lang.h (f_print_typedef): Declare.
4671 * f-typeprint.c (f_print_typedef): Define.
4672
4673 2019-08-27 Christian Biesinger <cbiesinger@google.com>
4674
4675 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4676
4677 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4678
4679 * cli/cli-utils.c (info_print_options_defs): Delete.
4680 (make_info_print_options_def_group): Delete.
4681 (extract_info_print_options): Delete.
4682 (info_print_command_completer): Delete.
4683 (info_print_args_help): Add extra parameter, and optionally
4684 include text about -n flag.
4685 * cli/cli-utils.h (struct info_print_options): Delete.
4686 (extract_info_print_options): Delete declaration.
4687 (info_print_command_completer): Delete declaration.
4688 (info_print_args_help): Add extra parameter, extend header
4689 comment.
4690 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4691 search_symbols.
4692 * stack.c (struct info_print_options): New type.
4693 (info_print_options_defs): New file scoped variable.
4694 (make_info_print_options_def_group): New static function.
4695 (info_print_command_completer): New static function.
4696 (info_locals_command): Update to use new local functions.
4697 (info_args_command): Likewise.
4698 (_initialize_stack): Add extra parameter to calls to
4699 info_print_args_help.
4700 * symtab.c (search_symbols): Add extra parameter, use this to
4701 possibly excluse non-debug symbols.
4702 (symtab_symbol_info): Add extra parameter, which is passed on to
4703 search_symbols.
4704 (struct info_print_options): New type.
4705 (info_print_options_defs): New file scoped variable.
4706 (make_info_print_options_def_group): New static function.
4707 (info_print_command_completer): New static function.
4708 (info_variables_command): Update to use local functions, and pass
4709 extra parameter through to symtab_symbol_info.
4710 (info_functions_command): Likewise.
4711 (info_types_command): Pass additional argument through to
4712 symtab_symbol_info.
4713 (rbreak_command): Pass extra argument to search_symbols.
4714 (_initialize_symtab): Add extra arguments for calls to
4715 info_print_args_help, and update help text for 'info variables',
4716 'whereis', and 'info functions' commands.
4717 * symtab.h (search_symbols): Add extra argument to declaration.
4718 * NEWS: Mention new flags.
4719
4720 2019-08-26 Christian Biesinger <cbiesinger@google.com>
4721
4722 * symtab.c (lookup_static_symbol): Call the new function (and move
4723 it down to be next to lookup_global_symbol).
4724 (struct global_sym_lookup_data): Add block_enum member and rename to...
4725 (struct global_or_static_sym_lookup_data): ...this.
4726 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4727 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4728 (lookup_symbol_global_or_static_iterator_cb): ...this.
4729 (lookup_global_or_static_symbol): New function.
4730 (lookup_global_symbol): Call new function.
4731
4732 2019-08-26 Tom de Vries <tdevries@suse.de>
4733
4734 PR c++/24852
4735 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4736 when pc_probe.prob == NULL.
4737
4738 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4739
4740 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4741 variable symbol_linkage to symbol_linkage_.
4742
4743 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4744
4745 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4746 represent whether the symbol is static, dynamic, or we don't
4747 know.
4748
4749 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4750
4751 * gdb/rx-tdep.c (rx_register_names): New.
4752 (rx_register_name): Delete.
4753 (rx_psw_type): Delete.
4754 (rx_fpsw_type): Delete.
4755 (rx_register_type): Delete.
4756 (rx_gdbarch_init): Convert target-descriptions.
4757 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4758 * gdb/features/Makefile: Add rx.xml.
4759 * gdb/features/rx.xml: New.
4760 * gdb/features/rx.c: Generated.
4761 * gdb/NEWS: Mention target description support.
4762
4763 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4764
4765 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4766 *slot_ptr.
4767
4768 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4769
4770 * configure.ac: Don't check for 'dlfcn.h' (moved to
4771 gdbsupport/common.m4).
4772 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4773 'gdbsupport/'.
4774 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4775 * compile/compile-c-support.c: Include
4776 'gdbsupport/gdb-dlfcn.h'.
4777 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4778 * gdb-dlfcn.c: Move to...
4779 * gdbsupport/gdb-dlfcn.c: ... here.
4780 * gdb-dlfcn.h: Move to...
4781 * gdbsupport/gdb-dlfcn.h: ... here.
4782
4783 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4784
4785 * nios2-tdep.c (struct reg_value): Improve comments. Make
4786 the offset field signed.
4787
4788 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4789
4790 * python/lib/gdb/__init__.py (_execute_file): New function.
4791 * python/python.c (python_run_simple_file): Call gdb._execute_file
4792 on Windows.
4793
4794 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4795
4796 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4797 all uses as this was never set to anything but a zero value.
4798
4799 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4800
4801 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4802
4803 2019-08-21 Christian Biesinger <cbiesinger@google.com>
4804
4805 * tui/tui-data.h (tui_gen_win_info): Add an =default
4806 move constructor, required by some GCC versions.
4807
4808 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
4809
4810 * go32-nat.c (go32_sysinfo): Add hygon_p.
4811
4812 2019-08-20 Tom Tromey <tom@tromey.com>
4813
4814 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4815 line_from_reg_element_no, first_reg_element_no_inline,
4816 display_all_data, delete_data_content_windows,
4817 erase_data_content>: Now private.
4818
4819 2019-08-20 Tom Tromey <tom@tromey.com>
4820
4821 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4822 (tui_unhighlight_win, tui_highlight_win)
4823 (tui_win_info::make_window): Update.
4824 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4825
4826 2019-08-20 Tom Tromey <tom@tromey.com>
4827
4828 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4829 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4830 (MAX_PID_WIDTH): Move to tui-stack.c.
4831 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4832 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4833 (MAX_PID_WIDTH): Move from tui-data.h.
4834
4835 2019-08-20 Tom Tromey <tom@tromey.com>
4836
4837 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4838 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4839 (box_win): Update.
4840 (tui_gen_win_info::make_window): Rename from tui_make_window.
4841 (tui_win_info::make_window): New method.
4842 (tui_gen_win_info::make_visible): Update.
4843 * tui/tui-source.c (tui_source_window::set_contents): Update.
4844 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4845 (tui_data_window::display_registers_from): Update.
4846 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4847 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4848 Declare.
4849 <can_box>: Remove.
4850 <title>: Remove.
4851 (struct tui_win_info) <make_window>: Declare.
4852 <can_box>: Now virtual.
4853 <title>: New member.
4854 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4855 * tui/tui-command.c (tui_cmd_window::resize): Update.
4856
4857 2019-08-20 Tom Tromey <tom@tromey.com>
4858
4859 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4860 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4861 (tui_data_window::check_register_values): Update.
4862
4863 2019-08-20 Tom Tromey <tom@tromey.com>
4864
4865 * tui/tui-regs.h (struct tui_data_window): Use
4866 DISABLE_COPY_AND_ASSIGN.
4867 <regs_content>: Change type, removing unique_ptr.
4868 <tui_data_window>: Add move constructor.
4869 * tui/tui-regs.c (tui_data_window::show_registers)
4870 (tui_data_window::show_register_group)
4871 (tui_data_window::display_registers_from)
4872 (tui_data_window::display_registers_from)
4873 (tui_data_window::first_data_item_displayed)
4874 (tui_data_window::delete_data_content_windows)
4875 (tui_data_window::rerender, tui_data_window::refresh_window)
4876 (tui_data_window::check_register_values): Update.
4877
4878 2019-08-20 Tom Tromey <tom@tromey.com>
4879
4880 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4881 show_register_group>: Declare.
4882 (tui_show_register_group): Don't declare.
4883 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4884 tui_show_registers.
4885 (tui_data_window::show_register_group): Rename from
4886 tui_show_register_group.
4887 (tui_data_window::check_register_values, tui_reg_command):
4888 Update.
4889 * tui/tui-layout.c (tui_set_layout): Update.
4890
4891 2019-08-20 Tom Tromey <tom@tromey.com>
4892
4893 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4894 Declare.
4895 (tui_check_register_values): Don't declare.
4896 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4897 from tui_check_register_values.
4898 * tui/tui-hooks.c (tui_register_changed): Update.
4899
4900 2019-08-20 Tom Tromey <tom@tromey.com>
4901
4902 * tui/tui-regs.c (tui_reg_layout): Move later.
4903 (tui_show_registers): Don't enable TUI mode or change layout.
4904
4905 2019-08-20 Tom Tromey <tom@tromey.com>
4906
4907 * tui/tui-regs.h (struct tui_data_item_window)
4908 <~tui_data_item_window>: Remove.
4909 <content>: Now a unique_xmalloc_ptr.
4910 * tui/tui-regs.c (tui_register_format): Return a
4911 unique_xmalloc_ptr.
4912 (tui_get_register): Update.
4913 (~tui_data_item_window): Remove.
4914 (tui_data_window::display_registers_from, tui_display_register):
4915 Update.
4916 * tui/tui-io.h (tui_expand_tabs): Update.
4917 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4918 Remove "col" parameter.
4919
4920 2019-08-20 Tom Tromey <tom@tromey.com>
4921
4922 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4923 field.
4924 * tui/tui-regs.c (~tui_data_item_window): Update.
4925
4926 2019-08-20 Tom Tromey <tom@tromey.com>
4927
4928 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4929 earlier.
4930
4931 2019-08-20 Tom Tromey <tom@tromey.com>
4932
4933 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4934
4935 2019-08-20 Tom Tromey <tom@tromey.com>
4936
4937 * tui/tui-source.h (struct tui_source_window): Update.
4938 * tui/tui-regs.c (tui_show_registers): Update.
4939 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4940 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4941 (NO_REGS_STRING): Remove defines.
4942
4943 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
4944
4945 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4946 unnecessary thread walk if remote doesn't support the packet.
4947
4948 2019-08-19 Tom Tromey <tromey@adacore.com>
4949
4950 * python/py-value.c (value_has_field): Fix indentation.
4951
4952 2019-08-19 Tom Tromey <tromey@adacore.com>
4953
4954 * printcmd.c (do_one_display, info_display_command): Update.
4955 * block.h (contained_in): Return bool. Add allow_nested
4956 parameter.
4957 * block.c (contained_in): Return bool. Add allow_nested
4958 parameter.
4959
4960 2019-08-19 Tom Tromey <tom@tromey.com>
4961
4962 * configure: Rebuild.
4963 * configure.ac: Disallow the combination of -static-libstdc++ and
4964 source highlight.
4965 * source-cache.c (get_language_name): Handle rust.
4966 (source_cache::get_source_lines): Ignore highlighting exceptions.
4967
4968 2019-08-16 Tom Tromey <tom@tromey.com>
4969
4970 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4971 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4972 (struct tui_source_window_base) <make_visible, refresh_window,
4973 resize>: Remove methods.
4974 <execution_info>: Remove field.
4975 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4976 (tui_show_source_line, tui_source_window_base)
4977 (~tui_source_window_base): Update.
4978 (tui_source_window_base::resize)
4979 (tui_source_window_base::make_visible)
4980 (tui_source_window_base::refresh_window): Remove.
4981 (tui_source_window_base::update_exec_info): Update.
4982 * tui/tui-source.c (tui_source_window::set_contents): Update.
4983 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4984
4985 2019-08-16 Tom Tromey <tom@tromey.com>
4986
4987 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4988 deprecated_query_hook.
4989
4990 2019-08-16 Tom Tromey <tom@tromey.com>
4991
4992 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4993 (tui_update_source_windows_with_line): Update.
4994 * tui/tui-source.h (struct tui_source_window)
4995 <show_symtab_source>: Declare.
4996 (tui_show_symtab_source): Don't declare.
4997 * tui/tui-source.c (tui_show_symtab_source): Rename from
4998 tui_show_symtab_source.
4999
5000 2019-08-16 Tom Tromey <tom@tromey.com>
5001
5002 * tui/tui-winsource.h (struct tui_source_window_base)
5003 <set_contents>: Declare.
5004 * tui/tui-winsource.c
5005 (tui_source_window_base::update_source_window_as_is): Update.
5006 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5007 Declare.
5008 (tui_set_source_content): Don't declare.
5009 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5010 tui_set_source_content.
5011 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5012 Declare.
5013 (tui_set_disassem_content): Don't declare.
5014 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5015 tui_set_disassem_content.
5016
5017 2019-08-16 Tom Tromey <tom@tromey.com>
5018
5019 * tui/tui-winsource.h (struct tui_source_window_base)
5020 <update_breakpoint_info>: Declare.
5021 (tui_update_breakpoint_info): Don't declare.
5022 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5023 (tui_update_all_breakpoint_info): Update.
5024 (tui_source_window_base::update_breakpoint_info): Rename from
5025 tui_update_breakpoint_info.
5026 (tui_source_window_base::update_exec_info): Update.
5027
5028 2019-08-16 Tom Tromey <tom@tromey.com>
5029
5030 * tui/tui-winsource.h (struct tui_source_window_base)
5031 <update_source_window>: Declare.
5032 (tui_update_source_window): Don't declare.
5033 * tui/tui-winsource.c
5034 (tui_source_window_base::update_source_window): Rename from
5035 tui_update_source_window.
5036 (tui_source_window_base::rerender): Update.
5037 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5038 * tui/tui-disasm.c (tui_show_disassem)
5039 (tui_show_disassem_and_update_source)
5040 (tui_disasm_window::maybe_update): Update.
5041
5042 2019-08-16 Tom Tromey <tom@tromey.com>
5043
5044 * tui/tui-winsource.h (struct tui_source_window_base)
5045 <update_source_window_as_is>: Declare.
5046 (tui_update_source_window_as_is): Don't declare.
5047 * tui/tui-winsource.c (tui_update_source_window): Update
5048 (tui_source_window_base::update_source_window_as_is): Rename from
5049 tui_update_source_window_as_is.
5050 (tui_source_window_base::refill): Update.
5051 * tui/tui-source.c (tui_show_symtab_source): Update.
5052 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5053 Update.
5054
5055 2019-08-16 Tom Tromey <tom@tromey.com>
5056
5057 * tui/tui-winsource.h (tui_update_source_window)
5058 (tui_update_source_window_as_is): Remove "noerror" parameter.
5059 * tui/tui-winsource.c (tui_update_source_window)
5060 (tui_update_source_window_as_is): Remove "noerror" parameter.
5061 (tui_update_source_windows_with_addr)
5062 (tui_update_source_windows_with_line)
5063 (tui_source_window_base::rerender)
5064 (tui_source_window_base::refill): Update.
5065 * tui/tui-source.h (tui_set_source_content)
5066 (tui_show_symtab_source): Remove "noerror" parameter.
5067 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5068 parameter.
5069 (tui_show_symtab_source): Likewise.
5070 (tui_source_window::maybe_update): Update.
5071 * tui/tui-disasm.c (tui_show_disassem)
5072 (tui_show_disassem_and_update_source)
5073 (tui_disasm_window::do_scroll_vertical)
5074 (tui_disasm_window::maybe_update): Update.
5075
5076 2019-08-16 Tom Tromey <tom@tromey.com>
5077
5078 * tui/tui.c (tui_is_window_visible): Update.
5079 * tui/tui-wingeneral.c (tui_make_window)
5080 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5081 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5082 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5083 (tui_set_win_height_command, parse_scrolling_args): Update.
5084 * tui/tui-source.c (tui_source_window::style_changed): Update.
5085 * tui/tui-regs.c (tui_show_registers)
5086 (tui_data_window::first_data_item_displayed)
5087 (tui_data_window::delete_data_content_windows)
5088 (tui_check_register_values, tui_reg_command): Update.
5089 * tui/tui-disasm.c (tui_show_disassem): Update.
5090 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5091 method.
5092 <is_visible>: Remove field.
5093 * tui/tui-data.c (tui_next_win, tui_prev_win)
5094 (tui_delete_invisible_windows): Update.
5095
5096 2019-08-16 Tom Tromey <tom@tromey.com>
5097
5098 * tui/tui-winsource.h (struct tui_source_window_base)
5099 <m_has_locator>: Remove.
5100 * tui/tui-layout.c (show_source_disasm_command, show_data)
5101 (show_source_or_disasm_and_command): Update.
5102
5103 2019-08-16 Alan Hayward <alan.hayward@arm.com>
5104
5105 * NEWS (Other MI changes): New subsection.
5106 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5107 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5108 * arch-utils.c (default_get_pc_address_flags): New function.
5109 * arch-utils.h (default_get_pc_address_flags): New declaration.
5110 * gdbarch.sh: Add get_pc_address_flags.
5111 * gdbarch.c: Regenerate.
5112 * gdbarch.h: Likewise.
5113 * stack.c (print_pc): New function.
5114 (print_frame_info) (print_frame): Call print_pc.
5115
5116 2019-08-16 Tom de Vries <tdevries@suse.de>
5117
5118 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5119 print_objfile_section_info.
5120
5121 2019-08-15 Tom Tromey <tom@tromey.com>
5122
5123 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5124 calling update_cmdwin_start_line.
5125 * tui/tui-winsource.h (struct tui_source_window_base)
5126 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5127 <rerender>: Declare.
5128 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5129 Call rerender.
5130 (tui_source_window_base::set_new_height): Remove.
5131 (tui_source_window_base::rerender): Rename from
5132 do_make_visible_with_new_height.
5133 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5134 resize method.
5135 (tui_win_info::make_invisible_and_set_new_height)
5136 (tui_win_info::make_visible_with_new_height): Remove.
5137 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5138 Declare.
5139 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5140 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5141 do_make_visible_with_new_height>: Don't declare.
5142 <rerender>: Declare.
5143 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5144 set_new_height.
5145 (tui_data_window::do_make_visible_with_new_height): Remove.
5146 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5147 call tui_show_locator_content.
5148 (tui_gen_win_info::resize): Call rerender.
5149 (show_source_or_disasm_and_command): Don't call
5150 tui_show_locator_content.
5151 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5152 method.
5153 (struct tui_win_info) <rerender>: Declare.
5154 <set_new_height, make_invisible_and_set_new_height,
5155 make_visible_with_new_height>: Don't declare.
5156 * tui/tui-data.c (tui_win_list::rerender): New method.
5157 * tui/tui-command.h (struct tui_cmd_window)
5158 <do_make_visible_with_new_height>: Don't declare.
5159 * tui/tui-command.c
5160 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5161
5162 2019-08-15 Tom Tromey <tromey@adacore.com>
5163
5164 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5165 * ada-lang.c (ada_enum_name): Likewise.
5166
5167 2019-08-15 Christian Biesinger <cbiesinger@google.com>
5168
5169 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5170 leading underscore.
5171 (GdbOutputErrorFile): Likewise.
5172 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5173 accordingly.
5174 (execute_unwinders): Rename to have a leading underscore.
5175 (auto_load_packages): Likewise.
5176 (global scope): Adjust call to auto_load_packages accordingly.
5177 (GdbSetPythonDirectory): Likewise.
5178 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5179 instead of execute_unwinders.
5180
5181 2019-08-15 Tom Tromey <tom@tromey.com>
5182
5183 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5184 (show_data): Don't change window visibility.
5185 (tui_gen_win_info::resize): Remove special case for command
5186 window. Use wresize, when available.
5187 (show_source_or_disasm_and_command): Don't change window
5188 visibility.
5189 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5190 <make_visible>: New method.
5191 * tui/tui-command.c (tui_cmd_window::resize): New method.
5192
5193 2019-08-15 Tom Tromey <tom@tromey.com>
5194
5195 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5196 (struct tui_source_windows): New.
5197 * tui/tui-winsource.c (tui_display_main): Update.
5198 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5199 (new_height_ok, parse_scrolling_args): Update.
5200 * tui/tui-layout.c (show_layout, show_data): Update.
5201 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5202 (tui_add_to_source_windows): Don't declare.
5203 * tui/tui-data.c (source_windows, tui_source_windows)
5204 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5205
5206 2019-08-15 Tom Tromey <tom@tromey.com>
5207
5208 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5209 Rename from reset.
5210 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5211 * tui/tui-layout.c (show_source_disasm_command, show_data):
5212 Update.
5213 (tui_gen_win_info::resize): Rename.
5214 (show_source_or_disasm_and_command): Update.
5215 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5216 reset.
5217
5218 2019-08-15 Tom Tromey <tom@tromey.com>
5219
5220 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5221 * tui/tui-interp.c (tui_interp::init): Don't call
5222 tui_initialize_static_data.
5223 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5224
5225 2019-08-15 Tom Tromey <tom@tromey.com>
5226
5227 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5228 examine tui_win_list.
5229
5230 2019-08-15 Tom Tromey <tom@tromey.com>
5231
5232 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5233 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5234 tui_clear_source_content.
5235 (tui_clear_source_content): Remove.
5236 (tui_source_window_base::do_erase_source_content): Hoist call to
5237 content.clear().
5238 * tui/tui-stack.c (tui_show_frame_info): Don't call
5239 tui_clear_source_content.
5240
5241 2019-08-15 Tom Tromey <tom@tromey.com>
5242
5243 * tui/tui-winsource.h (struct tui_source_window_base)
5244 <do_erase_source_content>: New method.
5245 <erase_source_content>: New method.
5246 (tui_erase_source_content): Don't declare.
5247 * tui/tui-winsource.c (tui_clear_source_content): Update.
5248 (tui_source_window_base::do_erase_source_content): Rename from
5249 tui_erase_source_content.
5250 (tui_source_window_base::show_source_content): Update.
5251 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5252 * tui/tui-source.h (struct tui_source_window)
5253 <erase_source_content>: New method.
5254 * tui/tui-disasm.h (struct tui_disasm_window)
5255 <erase_source_content>: New method.
5256
5257 2019-08-15 Tom Tromey <tom@tromey.com>
5258
5259 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5260 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5261 constructor.
5262 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5263 * tui/tui-source.c (tui_set_source_content): Update.
5264 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5265
5266 2019-08-15 Tom Tromey <tom@tromey.com>
5267
5268 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5269 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5270 tui-source.c.
5271 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5272 Declare.
5273 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5274 method.
5275 (tui_source_window::maybe_update): Update.
5276
5277 2019-08-15 Tom Tromey <tom@tromey.com>
5278
5279 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5280 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5281 tui-disasm.c.
5282 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5283 Declare.
5284 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5285 method.
5286 (tui_disasm_window::maybe_update): Update.
5287
5288 2019-08-15 Tom Tromey <tom@tromey.com>
5289
5290 * tui/tui-winsource.h (struct tui_source_window_base)
5291 <maybe_update>: Declare.
5292 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5293 method.
5294 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5295 Declare.
5296 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5297 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5298 Declare.
5299 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5300
5301 2019-08-15 Tom Tromey <tom@tromey.com>
5302
5303 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5304
5305 2019-08-15 Tom Tromey <tom@tromey.com>
5306
5307 * tui/tui-wingeneral.c: Include tui-stack.h.
5308 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5309 (struct tui_locator_window): Move from tui-data.h.
5310 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5311 (tui_initialize_static_data): Move from tui-data.c.
5312 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5313 (struct tui_locator_window): Move to tui-stack.c.
5314 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5315 (tui_initialize_static_data): Move to tui-stack.c.
5316
5317 2019-08-15 Tom Tromey <tom@tromey.com>
5318
5319 * tui/tui-layout.c (show_source_disasm_command)
5320 (show_source_or_disasm_and_command): Use make_visible method, not
5321 tui_make_window.
5322 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5323 Remove.
5324
5325 2019-08-15 Tom Tromey <tom@tromey.com>
5326
5327 * tui/tui-wingeneral.h (tui_make_window): Update.
5328 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5329 parameter.
5330 (tui_gen_win_info::make_visible): Update.
5331 * tui/tui-regs.c (tui_data_window::display_registers_from):
5332 Update.
5333 * tui/tui-layout.c (show_source_disasm_command)
5334 (show_source_or_disasm_and_command): Update.
5335 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5336 (enum tui_box): Remove.
5337 (struct tui_win_info) <can_box>: New method.
5338 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5339 method.
5340
5341 2019-08-15 Tom de Vries <tdevries@suse.de>
5342
5343 * linux-nat-trad.c: Include gdbarch.h.
5344
5345 2019-08-14 Alan Hayward <alan.hayward@arm.com>
5346
5347 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5348 register sizes.
5349
5350 2019-08-14 Tom Tromey <tromey@adacore.com>
5351
5352 * darwin-nat.c: Include gdbarch.h.
5353 * darwin-nat-info.c: Include gdbarch.h.
5354
5355 2019-08-13 Tom Tromey <tom@tromey.com>
5356
5357 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5358 Remove.
5359 * tui/tui-data.c (tui_initialize_static_data): Update.
5360
5361 2019-08-13 Tom Tromey <tom@tromey.com>
5362
5363 * tui/tui-winsource.h (struct tui_exec_info_window)
5364 <~tui_exec_info_window, maybe_allocate_content, get_content,
5365 m_content>: Remove.
5366 (struct tui_source_window_base) <set_exec_info_content,
5367 show_exec_info_content>: Don't declare.
5368 * tui/tui-winsource.c
5369 (tui_exec_info_window::maybe_allocate_content): Remove.
5370 (tui_source_window_base::update_exec_info): Rename from
5371 set_exec_info_content.
5372 (tui_source_window_base::show_exec_info_content)
5373 (tui_source_window_base::update_exec_info): Remove.
5374
5375 2019-08-13 Tom Tromey <tom@tromey.com>
5376
5377 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5378 declare.
5379 * tui/tui-winsource.c (tui_update_source_window_as_is)
5380 (tui_update_source_windows_with_addr, tui_erase_source_content):
5381 Update.
5382 (tui_clear_exec_info_content): Remove.
5383
5384 2019-08-13 Tom Tromey <tom@tromey.com>
5385
5386 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5387 declare.
5388 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5389 call tui_erase_exec_info_content.
5390 (tui_clear_exec_info_content): Rename from
5391 tui_erase_exec_info_content.
5392 (tui_clear_exec_info_content): Delete.
5393
5394 2019-08-13 Tom Tromey <tom@tromey.com>
5395
5396 * tui/tui-winsource.h (struct tui_source_window_base)
5397 <show_exec_info_content>: Declare.
5398 (tui_show_exec_info_content): Don't declare.
5399 * tui/tui-winsource.c
5400 (tui_source_window_base::show_exec_info_content): Rename from
5401 tui_show_exec_info_content.
5402 (tui_source_window_base::update_exec_info): Update.
5403
5404 2019-08-13 Tom Tromey <tom@tromey.com>
5405
5406 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5407 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5408 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5409 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5410 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5411 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5412 ... here.
5413
5414 2019-08-13 Tom Tromey <tom@tromey.com>
5415
5416 * tui/tui-winsource.h (struct tui_source_window_base)
5417 <update_exec_info>: Declare.
5418 (tui_update_exec_info): Don't declare.
5419 * tui/tui-winsource.c (tui_update_source_window_as_is)
5420 (tui_source_window_base::refresh_all)
5421 (tui_update_all_breakpoint_info): Update.
5422 (tui_source_window_base::update_exec_info): Rename from
5423 tui_update_exec_info.
5424 * tui/tui-stack.c (tui_show_frame_info): Update.
5425
5426 2019-08-13 Tom Tromey <tom@tromey.com>
5427
5428 * tui/tui-winsource.h (struct tui_source_window_base)
5429 <set_exec_info_content>: Declare.
5430 (tui_set_exec_info_content): Don't declare.
5431 * tui/tui-winsource.c
5432 (tui_source_window_base::set_exec_info_content): Rename from
5433 tui_set_exec_info_content.
5434 (tui_update_exec_info): Update.
5435
5436 2019-08-13 Tom Tromey <tom@tromey.com>
5437
5438 * tui/tui-winsource.h (struct tui_source_window_base)
5439 <show_source_content>: Declare.
5440 (tui_show_source_content): Don't declare.
5441 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5442 (tui_source_window_base::show_source_content): Rename from
5443 tui_show_source_content.
5444 (tui_source_window_base::refresh_all): Update.
5445 * tui/tui-layout.c (show_source_disasm_command)
5446 (show_source_or_disasm_and_command): Update.
5447
5448 2019-08-13 Tom Tromey <tom@tromey.com>
5449
5450 * tui/tui-winsource.c (tui_erase_source_content)
5451 (tui_show_source_content, tui_source_window_base::refresh_all):
5452 Update.
5453 * tui/tui-wingeneral.h
5454 (tui_check_and_display_highlight_if_needed): Don't declare.
5455 * tui/tui-wingeneral.c
5456 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5457 check_and_display_highlight_if_needed.
5458 * tui/tui-win.c (tui_rehighlight_all)
5459 (tui_win_info::make_visible_with_new_height): Update.
5460 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5461 (tui_data_window::erase_data_content)
5462 (tui_data_window::display_all_data): Update.
5463 * tui/tui-data.h (struct tui_win_info)
5464 <check_and_display_highlight_if_needed>: Declare.
5465
5466 2019-08-13 Tom Tromey <tom@tromey.com>
5467
5468 * tui/tui-win.c (tui_resize_all): Call
5469 tui_delete_invisible_windows.
5470 * tui/tui-layout.c (show_layout): Call
5471 tui_delete_invisible_windows.
5472 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5473 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5474
5475 2019-08-13 Tom Tromey <tom@tromey.com>
5476
5477 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5478 tui_add_win_to_layout.
5479
5480 2019-08-13 Tom Tromey <tom@tromey.com>
5481
5482 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5483 * tui/tui-layout.c (tui_default_win_height): Now static.
5484
5485 2019-08-13 Tom Tromey <tom@tromey.com>
5486
5487 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5488 single switch.
5489 (show_source_disasm_command, show_source_or_disasm_and_command):
5490 Don't check current layout.
5491
5492 2019-08-13 Tom Tromey <tom@tromey.com>
5493
5494 * tui/tui-wingeneral.c (make_all_visible): Remove.
5495 (tui_make_all_invisible): Simplify.
5496 * tui/tui-layout.c (tui_make_all_invisible): Move from
5497 tui-wingeneral.c; simplify.
5498 (show_layout): Hoist call to tui_make_all_invisible.
5499 (show_data): Don't call tui_make_all_invisible.
5500
5501 2019-08-13 Tom Tromey <tom@tromey.com>
5502
5503 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5504 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5505
5506 2019-08-13 Tom Tromey <tom@tromey.com>
5507
5508 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5509 tui-data.c.
5510 (show_source_disasm_command, show_data)
5511 (show_source_or_disasm_and_command): Don't use
5512 tui_set_current_layout_to.
5513 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5514 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5515 tui-layout.c.
5516 (tui_set_current_layout_to): Remove.
5517
5518 2019-08-13 Tom Tromey <tom@tromey.com>
5519
5520 * tui/tui-layout.c (tui_set_layout): Update.
5521 * tui/tui-data.h (struct tui_layout_def): Remove.
5522 (tui_layout_def): Don't declare.
5523 * tui/tui-data.c (layout_def): Remove.
5524 (tui_layout_def): Remove.
5525
5526 2019-08-13 Tom Tromey <tom@tromey.com>
5527
5528 * tui/tui-winsource.h (struct tui_source_window_base)
5529 <clear_detail>: No longer "override".
5530 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5531 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5532 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5533 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5534 Remove.
5535 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5536
5537 2019-08-13 Tom Tromey <tromey@adacore.com>
5538
5539 * tracepoint.c: Don't include readline.h or history.h.
5540
5541 2019-08-12 Tom Tromey <tom@tromey.com>
5542
5543 * configure: Rebuild.
5544 * configure.ac: Check for readline 7.
5545 * NEWS: Mention readline 7 requirement.
5546 * README: Update.
5547
5548 2019-08-12 Tom Tromey <tom@tromey.com>
5549
5550 * mingw-hdep.c (gdb_select): Remove readline hack.
5551
5552 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5553
5554 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5555 when the function fails.
5556
5557 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5558
5559 * s390-tdep.c (s390_type_align): New function.
5560 (s390_gdbarch_init): Set it as type_align gdbarch method.
5561
5562 2019-08-09 Tom de Vries <tdevries@suse.de>
5563
5564 PR gdb/24591
5565 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5566 pc_low with relocation offset.
5567
5568 2019-08-07 Tom Tromey <tromey@adacore.com>
5569
5570 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5571 (print_frame_args): Update.
5572 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5573 Update.
5574 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5575 * frame.h (struct frame_arg): Add initializers.
5576 <error>: Now a unique_xmalloc_ptr.
5577
5578 2019-08-07 Alan Hayward <alan.hayward@arm.com>
5579
5580 * NEWS: Expand the Pointer Authentication entry.
5581 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5582 (aarch64_frame_unmask_lr): ... to this.
5583 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5584 Call aarch64_frame_unmask_lr.
5585 * frame.c (struct frame_info): Add "masked" variable.
5586 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5587 (fprint_frame): Check for masked pc.
5588 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5589 declarations.
5590 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5591 * stack.c (print_frame): Check for masked pc.
5592
5593 2019-08-06 Tom Tromey <tom@tromey.com>
5594
5595 * stabsread.c (patch_block_stabs, read_one_struct_field)
5596 (read_enum_type): Use obstack_strndup.
5597 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5598 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5599 * dwarf2read.c (guess_full_die_structure_name)
5600 (anonymous_struct_prefix): Use obstack_strndup.
5601 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5602 * c-exp.y (yylex): Use obstack_strndup.
5603 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5604 (write_var_or_type): Use obstack_strndup.
5605
5606 2019-08-06 Tom Tromey <tom@tromey.com>
5607
5608 * symfile.c (reread_symbols): Use obstack_strdup.
5609 * stabsread.c (read_type): Use obstack_strdup.
5610 * gdb_obstack.h (obstack_strdup): New overload.
5611 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5612 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5613 (dwarf2_canonicalize_name): Use obstack_strdup.
5614 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5615 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5616 Use obstack_strdup.
5617
5618 2019-08-06 Tom Tromey <tom@tromey.com>
5619
5620 * gdb_obstack.h (obstack_strdup): Define.
5621 * gdb_obstack.c (obstack_strdup): Don't define.
5622
5623 2019-08-06 Tom Tromey <tom@tromey.com>
5624
5625 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5626 obstack_strdup.
5627 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5628 obstack_strdup.
5629 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5630 * stabsread.c (common_block_start): Use obstack_strdup.
5631 * objfiles.c (set_objfile_main_name, objfile): Use
5632 obstack_strdup.
5633 * namespace.c (add_using_directive): Use obstack_strdup.
5634 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5635 * jit.c (finalize_symtab): Use obstack_strdup.
5636 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5637 (guess_partial_die_structure_name, partial_die_info::fixup)
5638 (dwarf2_name): Use obstack_strdup.
5639 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5640 obstack_strdup.
5641 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5642 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5643 obstack_strdup.
5644 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5645
5646 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5647
5648 * unittests/help-doc-selftests.c: New file.
5649 * Makefile.in: Add the new file.
5650
5651 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5652
5653 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5654 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5655 the full first line, except when FOR_VALUE_PREFIX. In this case,
5656 the trailing '.' is not output, and the first character is uppercased.
5657 (print_help_for_command): Update call to print_doc_line.
5658 (print_doc_of_command): Likewise.
5659 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5660 * cli/cli-option.c (append_indented_doc): Do not append newline.
5661 (build_help_option): Append newline after first appended_indented_doc
5662 only if a second call is done.
5663 (build_help): Append 2 new lines before each option, except the first
5664 one.
5665 * compile/compile.c (_initialize_compile): Add new lines after
5666 %OPTIONS%, when not at the end of the help.
5667 Change help doc or code
5668 producing the help doc to respect the invariants.
5669 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5670 Also removed the new line after 'Options:', as all other commands
5671 do not put an empty line between 'Options:' and the first option.
5672 * printcmd.c (_initialize_printcmd): Likewise.
5673 * stack.c (_initialize_stack): Likewise.
5674 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5675 incorrectly telling COMMAND is optional.
5676 * ada-lang.c (_initialize_ada_language): Change help doc or code
5677 producing the help doc to respect the invariants.
5678 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5679 * breakpoint.c (_initialize_breakpoint): Likewise.
5680 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5681 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5682 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5683 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5684 _initialize_cli_style): Likewise.
5685 * corelow.c (core_target_info): Likewise.
5686 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5687 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5688 * filesystem.c (_initialize_filesystem): Likewise.
5689 * frame.c (_initialize_frame): Likewise.
5690 * gnu-nat.c (add_task_commands): Likewise.
5691 * infcall.c (_initialize_infcall): Likewise.
5692 * infcmd.c (_initialize_infcmd): Likewise.
5693 * interps.c (_initialize_interpreter): Likewise.
5694 * language.c (_initialize_language): Likewise.
5695 * linux-fork.c (_initialize_linux_fork): Likewise.
5696 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5697 * maint.c (_initialize_maint_cmds): Likewise.
5698 * memattr.c (_initialize_mem): Likewise.
5699 * printcmd.c (_initialize_printcmd): Likewise.
5700 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5701 _RegEx): Likewise.
5702 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5703 * record-btrace.c (_initialize_record_btrace): Likewise.
5704 * record-full.c (_initialize_record_full): Likewise.
5705 * record.c (_initialize_record): Likewise.
5706 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5707 * regcache.c (_initialize_regcache): Likewise.
5708 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5709 _initialize_remote): Likewise.
5710 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5711 * serial.c (_initialize_serial): Likewise.
5712 * skip.c (_initialize_step_skip): Likewise.
5713 * source.c (_initialize_source): Likewise.
5714 * stack.c (_initialize_stack): Likewise.
5715 * symfile.c (_initialize_symfile): Likewise.
5716 * symtab.c (_initialize_symtab): Likewise.
5717 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5718 * top.c (init_main): Likewise.
5719 * tracefile-tfile.c (tfile_target_info): Likewise.
5720 * tracepoint.c (_initialize_tracepoint): Likewise.
5721 * tui/tui-win.c (_initialize_tui_win): Likewise.
5722 * utils.c (add_internal_problem_command): Likewise.
5723 * valprint.c (value_print_option_defs): Likewise.
5724
5725 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
5726
5727 PR build/24886
5728 * configure.ac: Drop enable-libmcheck support.
5729 * configure, config.in: Rebuild.
5730 * libmcheck.m4: Remove.
5731 * acinclude.m4: Don't include it.
5732 * Makefile.in: Don't distribute it.
5733 * top.c (print_gdb_configuration): Don't mention it.
5734
5735 2019-08-06 Tom Tromey <tom@tromey.com>
5736
5737 * utils.c (set_output_style): Sometimes pass stream to
5738 emit_style_escape.
5739 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5740 * record-btrace.c (btrace_insn_history): Update.
5741 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5742 method.
5743 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5744 Update initializers.
5745 <m_uiout>: New field.
5746 <m_di>: Move lower.
5747 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5748 Remove "uiout" parameter.
5749 (dump_insns): Update.
5750 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5751 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5752
5753 2019-08-06 Christian Biesinger <cbiesinger@google.com>
5754
5755 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5756 (error_in_psymtab_expansion): Likewise.
5757 (lookup_symbol_via_quick_fns): Likewise.
5758 (basic_lookup_transparent_type_quick): Likewise.
5759 (basic_lookup_transparent_type_1): Likewise.
5760
5761 2019-08-06 Tom Tromey <tromey@adacore.com>
5762
5763 * source.c (last_source_error): Now bool.
5764 (print_source_lines_base): Make "noprint" bool. Only open
5765 source file when last_source_visited changes.
5766
5767 2019-08-06 Tom Tromey <tromey@adacore.com>
5768
5769 * annotate.c (annotate_source_line): Use g_source_cache.
5770 * source-cache.c (source_cache::get_plain_source_lines): Change
5771 parameters. Populate m_offset_cache.
5772 (source_cache::ensure): New method.
5773 (source_cache::get_line_charpos): New method.
5774 (extract_lines): Move lower. Change parameters.
5775 (source_cache::get_source_lines): Move lower.
5776 * source-cache.h (class source_cache): Update comment.
5777 <get_line_charpos>: New method.
5778 <get_source_lines>: Update comment.
5779 <clear>: Clear m_offset_cache.
5780 <get_plain_source_lines>: Change parameters.
5781 <ensure>: New method
5782 <m_offset_cache>: New member.
5783 * source.c (forget_cached_source_info_for_objfile): Update.
5784 (info_source_command): Use g_source_cache.
5785 (find_source_lines, open_source_file_with_line_charpos): Remove.
5786 (print_source_lines_base, search_command_helper): Use g_source_cache.
5787 * source.h (open_source_file_with_line_charpos): Don't declare.
5788 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5789 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5790 Use g_source_cache.
5791
5792 2019-08-06 Tom Tromey <tromey@adacore.com>
5793
5794 * source-cache.c (source_cache::get_plain_source_lines):
5795 Remove "first_line" and "last_line" parameters.
5796 (source_cache::get_source_lines): Cache plain text.
5797 * source-cache.h (class source_cache)
5798 <get_plain_source_lines>: Update.
5799
5800 2019-08-06 Tom Tromey <tromey@adacore.com>
5801
5802 * source-cache.c (extract_lines): No longer a method.
5803 Changed type of parameter. Include final newline.
5804 (selftests::extract_lines_test): New function.
5805 (_initialize_source_cache): Likewise.
5806 * source-cache.h (class source_cache)
5807 <extract_lines>: Don't declare.
5808
5809 2019-08-06 Tom Tromey <tromey@adacore.com>
5810
5811 * breakpoint.c (init_breakpoint_sal): Update.
5812 (breakpoint): Update.
5813 * breakpoint.h (struct breakpoint) <filter>: Now a
5814 unique_xmalloc_ptr.
5815
5816 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5817
5818 * NEWS: Mention dictionary access on blocks.
5819 * python/py-block.c (blpy_getitem): New function.
5820 (block_object_as_mapping): New struct.
5821 (block_object_type): Use new struct for tp_as_mapping field.
5822
5823 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5824
5825 * objfiles.h (objfile): Add a comment describing partial symbols.
5826
5827 2019-08-05 Tom Tromey <tromey@adacore.com>
5828
5829 * compile/compile.c (_initialize_compile): Use _(), not N_().
5830 * thread.c (_initialize_thread): Use _(), not N_().
5831 * stack.c (_initialize_stack): Use _(), not N_().
5832 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5833
5834 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5835
5836 * dwarf2read.c (struct dw2_symtab_iterator):
5837 <want_specific_block>: Remove.
5838 <block_index>: Change type to gdb::optional.
5839 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5840 change type of BLOCK_INDEX parameter to gdb::optional.
5841 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5842 (dw2_lookup_symbol): Don't pass argument for
5843 WANT_SPECIFIC_BLOCK.
5844 (dw2_expand_symtabs_for_function): Don't pass argument for
5845 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5846 (class dw2_debug_names_iterator)
5847 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5848 parameter, change BLOCK_INDEX type to gdb::optional.
5849 <m_want_specific_block>: Remove.
5850 <m_block_index>: Change type to gdb::optional.
5851 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5852 gdb::optional. Re-write in function of gdb::optional.
5853 (dw2_debug_names_lookup_symbol): Don't pass argument for
5854 WANT_SPECIFIC_BLOCK.
5855 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5856 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5857 BLOCK_INDEX.
5858
5859 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5860
5861 * NEWS: Mention changes to "info sources" command.
5862
5863 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5864
5865 * symtab.c (filename_partial_match_opts): New struct type.
5866 (struct output_source_filename_data): New members
5867 regexp, c_regexp, partial_match.
5868 (output_source_filename): Use new members to decide to print file.
5869 (info_sources_option_defs): New variable.
5870 (make_info_sources_options_def_group, print_info_sources_header,
5871 info_sources_command_completer):
5872 New functions.
5873 (info_sources_command): Read new optional arguments.
5874 (_initialize_symtab): Update info sources help.
5875
5876 2019-08-02 Alexandre Oliva <oliva@adacore.com>
5877
5878 * ada-lang.c (exception_support_info_v0): Renamed from...
5879 (default_exception_support_info): ... this. Create new
5880 definition for v1.
5881 (ada_has_this_exception_support): Look up catch_handlers_sym.
5882 (ada_exception_support_info_sniffer): Try v0 after default.
5883
5884 2019-08-01 Tom Tromey <tromey@adacore.com>
5885
5886 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5887 gdbarch.h.
5888
5889 2019-08-01 Christian Biesinger <cbiesinger@google.com>
5890
5891 * s12z-tdep.c: Fix include path for s12z-opc.h.
5892
5893 2019-08-01 Alan Hayward <alan.hayward@arm.com>
5894
5895 * NEWS: Require GNU make 3.82.
5896
5897 2019-07-16 Tom Tromey <tom@tromey.com>
5898
5899 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5900 declare.
5901
5902 2019-07-30 Tom Tromey <tromey@adacore.com>
5903
5904 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5905
5906 2019-07-30 Kevin Buettner <kevinb@redhat.com>
5907
5908 * printcmd.c (print_address_symbolic): Print negative offsets.
5909 (build_address_symbolic): Force signed arithmetic when computing
5910 offset.
5911
5912 2019-07-30 Christian Biesinger <cbiesinger@google.com>
5913
5914 PR/24474: Add a function to lookup static variables.
5915 * NEWS: Mention this new function.
5916 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5917 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5918 * python/python.c (python_GdbMethods): Add new function.
5919
5920 2019-07-29 Christian Biesinger <cbiesinger@google.com>
5921
5922 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5923 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5924 (objfpy_lookup_static_symbol): New function.
5925 (objfile_object_methods): Add new functions.
5926
5927 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5928
5929 * NEWS: Mention 'set|show print frame-info'. Mention new
5930 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5931 backtrace argument. Mention that python frame filtering code
5932 is now consistent with what 'backtrace' command prints.
5933
5934 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5935
5936 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5937 comments.
5938 (print_frame_info_auto, print_frame_info_source_line,
5939 print_frame_info_location, print_frame_info_source_and_location,
5940 print_frame_info_location_and_address, print_frame_info_short_location):
5941 New declarations.
5942 (struct frame_print_options): New member print_frame_info.
5943 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5944 * stack.h (get_user_print_what_frame_info): New declaration.
5945 (frame_show_address): New declaration.
5946 * stack.c (print_frame_arguments_choices): New value 'presence'.
5947 (print_frame_info_auto, print_frame_info_source_line,
5948 print_frame_info_location, print_frame_info_source_and_location,
5949 print_frame_info_location_and_address, print_frame_info_short_location,
5950 print_frame_info_choices, print_frame_info_print_what): New definitions.
5951 (print_frame_args): Only print dots for args if print frame-arguments
5952 is 'presence'.
5953 (frame_print_option_defs): New element for "frame-info".
5954 (get_user_print_what_frame_info): New function.
5955 (frame_show_address): Make non static. Move comment to stack.h.
5956 (print_frame_info_to_print_what): New function.
5957 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5958 to decide what to print.
5959 (backtrace_command_1): Handle the new print_frame_arguments_presence
5960 value.
5961 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5962 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5963 (py_print_frame): In non-mi mode, use LOCATION as default for
5964 print_what, similarly to frame information printed directly by
5965 backtrace command. Handle frame-info user option in non MI mode.
5966
5967 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5968
5969 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5970 Add case for debugging 32-bit target on 64-bit host. Revise
5971 comment.
5972
5973 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5974
5975 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5976 instead of find_function_entry_range_from_pc.
5977
5978 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5979
5980 * stack.c (find_frame_funname): Remove code which preferred
5981 minsym over symtab sym in "certain pathological cases".
5982
5983 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5984 parameter. Change type of "do_demangle" to bool.
5985 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5986 Pass suitable "prefer_sym_over_minsym" flag to
5987 build_address_symbolic(). Don't output "+" for negative offsets.
5988 * printcmd.c (print_address_symbolic): Update invocation of
5989 build_address_symbolic to include a "prefer_sym_over_minsym"
5990 flag.
5991 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5992 Restrict cases in which use of minimal symbol is preferred to that
5993 of a found symbol. Update comments.
5994
5995 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5996 for entry pc when entry pc is out of range for that FDE.
5997
5998 2019-07-26 Brian Callahan <bcallah@openbsd.org>
5999
6000 PR gdb/24839:
6001 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6002 type.
6003
6004 2019-07-25 Christian Biesinger <cbiesinger@google.com>
6005
6006 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6007 this function's Python signature.
6008
6009
6010 2019-07-24 Christian Biesinger <cbiesinger@google.com>
6011
6012 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6013 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6014 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6015 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6016 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6017
6018
6019 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6020
6021 * h8300-tdep.c (h8300_register_name_common): New.
6022 h8300_register_name): Use h8300_register_name_common.
6023 (h8300s_register_name): Likewise.
6024 (h8300sx_register_name): Likewise.
6025 (h8300h_register_nam): New.
6026 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6027
6028
6029 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6030
6031 * arm-tdep.c (arm_skip_cmse_entry): New function.
6032 (arm_is_sgstubs_section): New function.
6033 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6034
6035 2019-07-22 Tom Tromey <tom@tromey.com>
6036
6037 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6038 Don't self-assign.
6039
6040 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6041
6042 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6043 type_print.
6044
6045 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6046
6047 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6048 so that GDB doesn't match any msymbols when searching in the
6049 TYPES_DOMAIN.
6050 (print_symbol_info): Print using typedef_print or type_print based
6051 on the type of the symbol. Add updated FIXME comment moved from...
6052 (_initialize_symtab): ... move and update FIXME comment to above.
6053
6054 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6055
6056 * NEWS: Mention adding -q option to "info types".
6057 * symtab.c (struct info_types_options): New struct.
6058 (info_types_options_defs): New variable.
6059 (make_info_types_options_def_group): New function.
6060 (info_types_command): Use gdb::option framework to parse options.
6061 (info_types_command_completer): New function.
6062 (_initialize_symtab): Extend the help text on "info types" and
6063 register command completer.
6064
6065 2019-07-21 Christian Biesinger <cbiesinger@google.com>
6066
6067 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6068 (lookup_symbol_in_objfile): Change int to block_enum and add a
6069 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6070
6071 2019-07-20 Christian Biesinger <cbiesinger@google.com>
6072
6073 * MAINTAINERS (Write After Approval): Add self.
6074
6075 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6076
6077 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6078 instruction to the dummy code region.
6079
6080 2019-07-19 Tom Tromey <tromey@adacore.com>
6081
6082 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6083 (ARGSUSED, PARAMS, __func__): Remove rules.
6084
6085 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6086
6087 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6088 * features/arm/arm-with-iwmmxt.c: Remove.
6089 * features/arm/arm-with-iwmmxt.xml: Remove.
6090 * features/arm/arm-with-m-fpa-layout.c: Remove.
6091 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6092 * features/arm/arm-with-m-vfp-d16.c: Remove.
6093 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6094 * features/arm/arm-with-m.c: Remove.
6095 * features/arm/arm-with-m.xml: Remove.
6096 * features/arm/arm-with-neon.c: Remove.
6097 * features/arm/arm-with-neon.xml: Remove.
6098 * features/arm/arm-with-vfpv2.c: Remove.
6099 * features/arm/arm-with-vfpv2.xml: Remove.
6100 * features/arm/arm-with-vfpv3.c: Remove.
6101 * features/arm/arm-with-vfpv3.xml: Remove.
6102
6103 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6104
6105 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6106
6107 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6108
6109 * arch/aarch32.c (aarch32_create_target_description): Create
6110 target descriptions using features.
6111 * arch/arm.c (arm_create_target_description)
6112 (arm_create_mprofile_target_description): Likewise.
6113 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6114
6115 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6116
6117 * Makefile.in: Add new files.
6118 * aarch32-tdep.c: New file.
6119 * aarch32-tdep.h: New file.
6120 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6121 Call aarch32_read_description.
6122 * arch/aarch32.c: New file.
6123 * arch/aarch32.h: New file.
6124 * arch/arm.c (arm_create_target_description)
6125 (arm_create_mprofile_target_description): New function.
6126 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6127 (arm_create_target_description)
6128 (arm_create_mprofile_target_description): New declaration.
6129 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6130 read_description functions.
6131 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6132 Likewise.
6133 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6134 * arm-tdep.c (tdesc_arm_list): New variable.
6135 (arm_register_g_packet_guesses): Call create description functions.
6136 (arm_read_description) (arm_read_mprofile_description): New
6137 function.
6138 * arm-tdep.h (arm_read_description)
6139 (arm_read_mprofile_description): Add declaration.
6140 * configure.tgt: Add new files.
6141
6142 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6143
6144 * top.c (new_ui_command): Open specified terminal just once.
6145
6146 2019-07-18 Tom Tromey <tromey@adacore.com>
6147
6148 * symtab.c (main_name): Constify return type.
6149 * symfile.c (set_initial_language): Update.
6150 * symtab.h (main_name): Constify return type.
6151
6152 2019-07-17 Tom Tromey <tom@tromey.com>
6153
6154 * tui/tui-winsource.c (tui_update_source_window)
6155 (tui_update_source_window_as_is)
6156 (tui_update_source_windows_with_line): Remove return.
6157 * tui/tui-disasm.c (tui_show_disassem)
6158 (tui_show_disassem_and_update_source): Remove return.
6159 * tui/tui.c (tui_reset): Remove return.
6160 * tui/tui-wingeneral.c
6161 (tui_check_and_display_highlight_if_needed): Remove return.
6162
6163 2019-07-17 Tom Tromey <tom@tromey.com>
6164
6165 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6166
6167 2019-07-17 Tom Tromey <tom@tromey.com>
6168
6169 * tui/tui-winsource.h (struct tui_exec_info_window)
6170 (struct tui_source_window_base): Move from tui-data.h.
6171 * tui/tui-winsource.c: Move many method definitions from
6172 elsewhere. Remove "structuring" comments.
6173 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6174 (tui_source_window_base::refresh_window): Move to
6175 tui-winsource.c.
6176 * tui/tui-win.c (tui_source_window_base::refresh_all)
6177 (tui_source_window_base::update_tab_width)
6178 (tui_source_window_base::set_new_height)
6179 (tui_source_window_base::do_make_visible_with_new_height): Move to
6180 tui-winsource.c.
6181 * tui/tui-source.h: Update.
6182 * tui/tui-source.c (tui_source_window_base::reset): Move to
6183 tui-winsource.c.
6184 * tui/tui-disasm.h: Update.
6185 * tui/tui-data.h (struct tui_exec_info_window): Move to
6186 tui-winsource.h.
6187 (struct tui_source_window_base): Likewise.
6188 * tui/tui-data.c (tui_source_window_base::clear_detail)
6189 (tui_source_window_base, ~tui_source_window_base): Move to
6190 tui-winsource.c.
6191
6192 2019-07-17 Tom Tromey <tom@tromey.com>
6193
6194 * tui/tui-win.c (tui_resize_all)
6195 (tui_source_window_base::update_tab_width)
6196 (tui_adjust_win_heights): Update.
6197 (tui_win_info::make_invisible_and_set_new_height): Rename from
6198 make_invisible_and_set_new_height.
6199 * tui/tui-data.h (struct tui_win_info)
6200 <make_invisible_and_set_new_height>: New method.
6201
6202 2019-07-17 Tom Tromey <tom@tromey.com>
6203
6204 * tui/tui.c: Update.
6205 * tui/tui-source.h (struct tui_source_window): Move from
6206 tui-data.h.
6207 * tui/tui-layout.c: Update.
6208 * tui/tui-disasm.c: Update.
6209 * tui/tui-data.h (struct tui_source_window): Move to
6210 tui-source.h.
6211
6212 2019-07-17 Tom Tromey <tom@tromey.com>
6213
6214 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6215 tui-data.h.
6216 * tui/tui-data.h (struct tui_disasm_window): Move to
6217 tui-disasm.h.
6218
6219 2019-07-17 Tom Tromey <tom@tromey.com>
6220
6221 * tui/tui-regs.h (struct tui_data_item_window): Move from
6222 tui-data.h.
6223 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6224 * tui/tui-data.h (struct tui_data_item_window): Move to
6225 tui-regs.h.
6226 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6227
6228 2019-07-17 Tom Tromey <tom@tromey.com>
6229
6230 * tui/tui.c: Update.
6231 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6232 (tui_cmd_window::max_height): Move to tui-command.c.
6233 * tui/tui-layout.c: Update.
6234 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6235 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6236 tui-command.c.
6237 * tui/tui-command.h (struct tui_cmd_window): Move from
6238 tui-data.h.
6239 * tui/tui-command.c: Remove "structuring" comments.
6240 (tui_cmd_window::clear_detail)
6241 (tui_cmd_window::do_make_visible_with_new_height)
6242 (tui_cmd_window::max_height): Move from elsewhere.
6243
6244 2019-07-17 Tom Tromey <tom@tromey.com>
6245
6246 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6247 Now static.
6248 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6249 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6250
6251 2019-07-17 Tom Tromey <tom@tromey.com>
6252
6253 * tui/tui.c: Update.
6254 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6255 tui-regs.c.
6256 * tui/tui-windata.h: Remove file.
6257 * tui/tui-windata.c: Remove file.
6258 * tui/tui-win.c (tui_data_window::set_new_height)
6259 (tui_data_window::do_make_visible_with_new_height): Move to
6260 tui-regs.c.
6261 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6262 * tui/tui-regs.c: Remove "structuring" comments.
6263 (tui_data_window::first_data_item_displayed)
6264 (tui_data_window::delete_data_content_windows)
6265 (tui_data_window::erase_data_content)
6266 (tui_data_window::display_all_data)
6267 (tui_data_window::refresh_all)
6268 (tui_data_window::do_scroll_vertical)
6269 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6270 (tui_data_window::do_make_visible_with_new_height)
6271 (tui_data_window::refresh_window): Move from elsewhere.
6272 (_initialize_tui_regs): Move to end of file.
6273 * tui/tui-layout.c: Update.
6274 * tui/tui-hooks.c: Update.
6275 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6276 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6277 tui-regs.c.
6278 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6279
6280 2019-07-17 Tom Tromey <tom@tromey.com>
6281
6282 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6283 seen.
6284
6285 2019-07-17 Tom Tromey <tom@tromey.com>
6286
6287 * tui/tui-win.c (tui_source_window_base::set_new_height)
6288 (tui_source_window_base::do_make_visible_with_new_height): Use
6289 m_has_locator field directly.
6290 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6291 method.
6292 (struct tui_source_window_base) <has_locator>: Likewise.
6293
6294 2019-07-17 Tom Tromey <tom@tromey.com>
6295
6296 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6297 Don't declare.
6298 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6299 Remove.
6300 * tui/tui-win.c (tui_source_window_base::set_new_height)
6301 (tui_source_window_base::set_new_height)
6302 (make_invisible_and_set_new_height)
6303 (tui_source_window_base::do_make_visible_with_new_height)
6304 (tui_source_window_base::do_make_visible_with_new_height):
6305 Update.
6306 * tui/tui-layout.c (show_source_disasm_command, show_data)
6307 (show_source_or_disasm_and_command): Update.
6308 * tui/tui-layout.c (show_layout): Update.
6309
6310 2019-07-17 Tom Tromey <tom@tromey.com>
6311
6312 * tui/tui-layout.c (make_data_window): Remove.
6313 (show_data): Unify creation and re-initialization cases.
6314
6315 2019-07-17 Tom Tromey <tom@tromey.com>
6316
6317 * tui/tui-layout.c (make_source_window, make_disasm_window):
6318 Remove.
6319 (show_data): Unify creation and re-initialization cases.
6320
6321 2019-07-17 Tom Tromey <tom@tromey.com>
6322
6323 * tui/tui-layout.c (make_command_window): Remove.
6324 (show_source_disasm_command, show_source_or_disasm_and_command):
6325 Unify creation and re-initialization cases.
6326
6327 2019-07-17 Tom Tromey <tom@tromey.com>
6328
6329 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6330 creation and re-initialization cases.
6331
6332 2019-07-17 Tom Tromey <tom@tromey.com>
6333
6334 * tui/tui-regs.c (tui_get_register): Return void.
6335
6336 2019-07-17 Tom Tromey <tom@tromey.com>
6337
6338 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6339 Simplify.
6340
6341 2019-07-17 Tom Tromey <tom@tromey.com>
6342
6343 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6344 resetting.
6345
6346 2019-07-17 Tom Tromey <tom@tromey.com>
6347
6348 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6349 * tui/tui-regs.c (tui_reg_layout): New function.
6350 (tui_show_registers, tui_reg_command): Use it.
6351 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6352 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6353 parameters.
6354 (tui_layout_command): Remove.
6355
6356 2019-07-17 Tom Tromey <tom@tromey.com>
6357
6358 * tui/tui-layout.h (tui/tui-layout): Return void.
6359 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6360
6361 2019-07-17 Tom Tromey <tom@tromey.com>
6362
6363 * tui/tui-layout.c (show_source_disasm_command, show_data):
6364 Update.
6365 (reset_locator): Remove.
6366 (show_source_or_disasm_and_command): Update.
6367
6368 2019-07-17 Tom Tromey <tom@tromey.com>
6369
6370 * tui/tui-source.c (tui_source_window_base::reset): Remove
6371 win_type parameter.
6372 * tui/tui-layout.c (make_command_window, make_source_window)
6373 (make_disasm_window, make_data_window)
6374 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6375 (reset_locator, show_source_or_disasm_and_command): Update.
6376 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6377 win_type parameter.
6378 (struct tui_source_window_base) <reset>: Likewise.
6379
6380 2019-07-17 Tom Tromey <tom@tromey.com>
6381
6382 * tui/tui-layout.c (show_source_disasm_command): Use
6383 reset_locator.
6384 (reset_locator): New function.
6385 (init_and_make_win): Remove.
6386 (show_source_or_disasm_and_command): Use reset_locator.
6387
6388 2019-07-17 Tom Tromey <tom@tromey.com>
6389
6390 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6391 condition.
6392 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6393 Remove condition.
6394 * tui/tui-source.c (tui_source_window_base::reset): New method.
6395 * tui/tui-layout.c (make_command_window): Don't call
6396 init_and_make_win.
6397 (make_source_window, make_disasm_window): Don't call
6398 make_source_or_disasm_window.
6399 (make_data_window): Don't call init_and_make_win. Change calling
6400 convention.
6401 (show_source_disasm_command, show_data): Simplify.
6402 (make_source_or_disasm_window): Remove.
6403 (show_source_or_disasm_and_command): Simplify.
6404 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6405 (struct tui_source_window_base) <reset>: Likewise.
6406 <execution_info>: Remove initializer.
6407 * tui/tui-data.c (tui_source_window_base): Initialize
6408 execution_info.
6409
6410 2019-07-17 Tom Tromey <tom@tromey.com>
6411
6412 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6413 variable.
6414
6415 2019-07-17 Tom Tromey <tom@tromey.com>
6416
6417 * tui/tui.c (tui_rl_other_window): Update.
6418 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6419 superclass method first. Always iterate over regs_content.
6420 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6421 method.
6422 * tui/tui-win.c (tui_set_focus_command): Update.
6423
6424 2019-07-17 Tom Tromey <tom@tromey.com>
6425
6426 * tui/tui-win.c (tui_set_focus_command): Rename from
6427 tui_set_focus. Call tui_enable.
6428 (tui_set_focus_command): Remove.
6429
6430 2019-07-17 Tom Tromey <tom@tromey.com>
6431
6432 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6433 refresh_window.
6434 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6435 touchwin.
6436 (tui_data_window::refresh_window): Call refresh_window on data
6437 items. Always call superclass refresh_window.
6438 (tui_win_info::refresh): Remove.
6439 (tui_source_window_base::refresh_window): Update.
6440 (tui_refresh_all): Update.
6441 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6442 refresh_window.
6443 (show_source_or_disasm_and_command): Likewise.
6444 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6445 (struct tui_source_window_base) <refresh>: Likewise.
6446
6447 2019-07-17 Tom Tromey <tom@tromey.com>
6448
6449 * tui/tui-winsource.c (tui_clear_source_content)
6450 (tui_show_source_content): Update.
6451 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6452 whether content is empty.
6453 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6454 Remove.
6455
6456 2019-07-17 Tom Tromey <tom@tromey.com>
6457
6458 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6459 window's contents.
6460 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6461 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6462
6463 2019-07-17 Tom Tromey <tom@tromey.com>
6464
6465 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6466 (struct tui_data_item_window): Update.
6467
6468 2019-07-17 Tom Tromey <tom@tromey.com>
6469
6470 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6471 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6472 defines.
6473
6474 2019-07-17 Tom Tromey <tom@tromey.com>
6475
6476 * tui/tui-winsource.h (tui_erase_source_content)
6477 (tui_clear_source_content): Remove "display_prompt" parameter.
6478 * tui/tui-winsource.c (tui_update_source_window_as_is)
6479 (tui_update_source_windows_with_addr): Update.
6480 (tui_clear_source_content): Remove "display_prompt" parameter.
6481 (tui_erase_source_content): Likewise. Simplify.
6482 (tui_show_source_content): Update.
6483 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6484 * tui/tui-stack.c (tui_show_frame_info): Update.
6485 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6486 Remove defines.
6487
6488 2019-07-17 Tom Tromey <tom@tromey.com>
6489
6490 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6491 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6492 parameter.
6493 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6494 parameter.
6495
6496 2019-07-17 Tom Tromey <tom@tromey.com>
6497
6498 * tui/tui-winsource.c (tui_clear_source_content)
6499 (tui_show_source_content, tui_show_exec_info_content)
6500 (tui_clear_exec_info_content): Update.
6501 * tui/tui-stack.c (tui_show_locator_content): Update.
6502 (tui_show_frame_info): Update.
6503 * tui/tui-source.h (tui_source_window): Don't declare.
6504 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6505 from tui_source_is_displayed.
6506 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6507 Remove field.
6508 (struct tui_source_window_base) <content_in_use>: New field. Now
6509 bool.
6510 (struct tui_source_window) <showing_source_p>: New method.
6511 (TUI_SRC_WIN): Change cast.
6512 * tui/tui-data.c (tui_initialize_static_data): Update.
6513
6514 2019-07-17 Tom Tromey <tom@tromey.com>
6515
6516 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6517 location_matches_p.
6518 * tui/tui-source.c (tui_source_window::location_matches_p): New
6519 method.
6520 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6521 method.
6522 * tui/tui-data.h (struct tui_source_window_base)
6523 <location_matches_p>: New method.
6524 (struct tui_source_window, struct tui_disasm_window)
6525 <location_matches_p>: Likewise.
6526
6527 2019-07-17 Tom Tromey <tom@tromey.com>
6528
6529 * tui/tui-win.c (tui_set_win_height_command): Rename from
6530 tui_set_win_height.
6531 (tui_set_win_height_command): Remove.
6532
6533 2019-07-17 Tom Tromey <tom@tromey.com>
6534
6535 * tui/tui-source.c (tui_source_window): New constructor. Add
6536 observer.
6537 (~tui_source_window): New destructor.
6538 (tui_source_window::style_changed): New method.
6539 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6540 (tui_attach_detach_observers): Update.
6541 * tui/tui-data.h (struct tui_source_window): Make constructor not
6542 inline. Add destructor.
6543 (struct tui_source_window) <style_changed>: New method.
6544 <m_observable>: New member.
6545
6546 2019-07-17 Tom Tromey <tom@tromey.com>
6547
6548 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6549 * tui/tui-win.c (tui_resize_all): Fix typo.
6550
6551 2019-07-17 Tom Tromey <tom@tromey.com>
6552
6553 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6554 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6555 (tui_refresh_all): Remove "list" parameter. Use foreach.
6556 * tui/tui-win.c (window_name_completer): Use foreach.
6557 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6558 (update_tab_width): Likewise.
6559 * tui/tui-layout.c (show_layout): Update.
6560 * tui/tui-data.h (class tui_window_iterator): New.
6561 (struct all_tui_windows): New.
6562 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6563
6564 2019-07-17 Tom Tromey <tom@tromey.com>
6565
6566 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6567 parameter. Don't reference globals.
6568 (tui_reg_command): Update.
6569
6570 2019-07-17 Tom Tromey <tom@tromey.com>
6571
6572 * tui/tui-regs.c (tui_show_registers): Simplify.
6573
6574 2019-07-17 Tom Tromey <tom@tromey.com>
6575
6576 * tui/tui-regs.c (tui_show_registers): Update.
6577 (tui_show_register_group): Add win_info parameter.
6578
6579 2019-07-17 Tom Tromey <tom@tromey.com>
6580
6581 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6582 Rename from tui_display_reg_element_at_line.
6583 (tui_data_window::display_registers_from_line): Update.
6584 * tui/tui-data.h (struct tui_data_window)
6585 <display_reg_element_at_line>: New method.
6586
6587 2019-07-17 Tom Tromey <tom@tromey.com>
6588
6589 * tui/tui-regs.h (tui_display_registers_from)
6590 (tui_display_registers_from_line): Don't declare.
6591 * tui/tui-windata.c (tui_data_window::display_all_data)
6592 (tui_data_window::refresh_all)
6593 (tui_data_window::do_scroll_vertical): Update.
6594 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6595 from tui_display_registers_from.
6596 (tui_display_reg_element_at_line): Update.
6597 (tui_data_window::display_registers_from_line): Rename from
6598 tui_display_registers_from_line.
6599 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6600 display_registers_from_line>: New methods.
6601
6602 2019-07-17 Tom Tromey <tom@tromey.com>
6603
6604 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6605 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6606 from tui_erase_data_content.
6607 (tui_data_window::display_all_data)
6608 (tui_data_window::refresh_all)
6609 (tui_data_window::do_scroll_vertical): Update.
6610 * tui/tui-regs.c (tui_show_registers): Update.
6611 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6612 New method.
6613
6614 2019-07-17 Tom Tromey <tom@tromey.com>
6615
6616 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6617 declare.
6618 * tui/tui-windata.c
6619 (tui_data_window::delete_data_content_windows): Rename from
6620 tui_delete_data_content_windows.
6621 (tui_data_window::display_all_data)
6622 (tui_data_window::do_scroll_vertical): Update.
6623 * tui/tui-data.h (struct tui_data_window)
6624 <delete_data_content_windows>: New method.
6625
6626 2019-07-17 Tom Tromey <tom@tromey.com>
6627
6628 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6629 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6630
6631 2019-07-17 Tom Tromey <tom@tromey.com>
6632
6633 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6634 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6635 from tui_display_all_data.
6636 * tui/tui-win.c
6637 (tui_data_window::do_make_visible_with_new_height): Update.
6638 * tui/tui-regs.c (tui_show_registers): Update.
6639 * tui/tui-layout.c (tui_set_layout): Update.
6640 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6641 method.
6642
6643 2019-07-17 Tom Tromey <tom@tromey.com>
6644
6645 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6646 * tui/tui-windata.c (tui_display_data_from): Remove.
6647 (tui_data_window::refresh_all): Update.
6648
6649 2019-07-17 Tom Tromey <tom@tromey.com>
6650
6651 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6652 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6653 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6654 tui_display_registers_from_line.
6655 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6656 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6657 "force_display" parameter.
6658
6659 2019-07-17 Tom Tromey <tom@tromey.com>
6660
6661 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6662 declare.
6663 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6664 Rename from tui_first_reg_element_no_inline.
6665 (tui_display_reg_element_at_line)
6666 (tui_display_registers_from_line): Update.
6667 * tui/tui-data.h (struct tui_data_window)
6668 <first_reg_element_no_inline>: New method.
6669
6670 2019-07-17 Tom Tromey <tom@tromey.com>
6671
6672 * tui/tui-windata.c (tui_display_data_from)
6673 (tui_data_window::do_scroll_vertical): Update.
6674 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6675 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6676 Rename from tui_line_from_reg_element_no.
6677 (tui_display_registers_from_line): Update.
6678 * tui/tui-data.h (struct tui_data_window)
6679 <line_from_reg_element_no>: New method.
6680
6681 2019-07-17 Tom Tromey <tom@tromey.com>
6682
6683 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6684 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6685 tui_last_regs_line_no.
6686 (tui_display_reg_element_at_line)
6687 (tui_display_registers_from_line): Update.
6688 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6689 method.
6690
6691 2019-07-17 Tom Tromey <tom@tromey.com>
6692
6693 PR tui/24722:
6694 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6695 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6696 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6697 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6698 (tui_update_breakpoint_info): Likewise.
6699 * tui/tui-hooks.c (tui_event_create_breakpoint)
6700 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6701 Update.
6702
6703 2019-07-17 Tom Tromey <tom@tromey.com>
6704
6705 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6706
6707 2019-07-17 Tom Tromey <tom@tromey.com>
6708
6709 * tui/tui-winsource.c (tui_update_source_window_as_is)
6710 (tui_update_source_windows_with_addr): Update.
6711 * tui/tui-source.h (tui_set_source_content)
6712 (tui_show_symtab_source): Add "win_info" parameter.
6713 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6714 parameter.
6715 (tui_show_symtab_source): Likewise.
6716
6717 2019-07-17 Tom Tromey <tom@tromey.com>
6718
6719 * tui/tui-wingeneral.c
6720 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6721
6722 2019-07-17 Tom Tromey <tom@tromey.com>
6723
6724 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6725 (struct tui_cmd_window) <can_scroll>: New method.
6726 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6727 method.
6728
6729 2019-07-17 Tom Tromey <tromey@adacore.com>
6730
6731 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6732 do_field_signed>: Rename. Change type of "value".
6733 * ui-out.c (ui_out::field_signed): Rename from field_int.
6734 Change type of "value".
6735 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6736 type of "value".
6737 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6738 do_field_int. Change type of "value".
6739 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6740 do_field_int. Change type of "value".
6741 * tracepoint.c (trace_status_mi, tfind_1)
6742 (print_one_static_tracepoint_marker): Update.
6743 * thread.c (print_thread_info_1, print_selected_thread_frame):
6744 Update.
6745 * stack.c (print_frame, print_frame_info): Update.
6746 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6747 Update.
6748 * source.c (print_source_lines_base): Update.
6749 * skip.c (info_skip_command): Update.
6750 * record-btrace.c (btrace_ui_out_decode_error)
6751 (btrace_call_history_src_line): Update.
6752 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6753 Update.
6754 * progspace.c (print_program_space): Update.
6755 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6756 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6757 do_field_int. Change type of "value".
6758 * mi/mi-out.c (mi_ui_out::do_table_begin)
6759 (mi_ui_out::do_table_header): Update.
6760 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6761 type of "value".
6762 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6763 (mi_cmd_data_list_changed_registers, output_register)
6764 (mi_cmd_data_read_memory, mi_load_progress)
6765 (mi_cmd_trace_frame_collected): Update.
6766 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6767 Update.
6768 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6769 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6770 (mi_cmd_var_list_children, varobj_update_one): Update.
6771 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6772 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6773 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6774 * inferior.c (print_inferior): Update.
6775 * gdb_bfd.c (print_one_bfd): Update.
6776 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6777 Update.
6778 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6779 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6780 do_field_int. Change type of "value".
6781 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6782 do_field_int. Change type of "value".
6783 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6784 (print_one_breakpoint_location, print_it_catch_fork)
6785 (print_one_catch_fork, print_it_catch_vfork)
6786 (print_one_catch_vfork, print_it_catch_solib)
6787 (print_it_catch_exec, print_it_ranged_breakpoint)
6788 (print_mention_watchpoint, print_mention_masked_watchpoint)
6789 (bkpt_print_it, update_static_tracepoint): Update.
6790 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6791 * break-catch-syscall.c (print_it_catch_syscall): Update.
6792 * ada-tasks.c (print_ada_task_info): Update.
6793 * ada-lang.c (print_it_exception, print_mention_exception):
6794 Update.
6795
6796 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6797
6798 PR breakpoints/24541
6799 * gdbarch.c: Regenerate.
6800 * gdbarch.h: Regenerate.
6801 * gdbarch.sh: Adjust return type and parameter types for
6802 'stap_adjust_register'.
6803 (i386_stap_adjust_register): Adjust signature and return new
6804 register name.
6805 * stap-probe.c (stap_parse_register_operand): Adjust use of
6806 'gdbarch_stap_adjust_register'.
6807
6808 2019-07-17 Tom Tromey <tromey@adacore.com>
6809
6810 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6811 declare VEC.
6812 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6813 std::vector.
6814 (struct s390_process_info): Add initializers.
6815 (s390_add_process): Use new.
6816 (s390_linux_nat_target::low_forget_process): Use delete.
6817 (s390_linux_nat_target::low_new_fork)
6818 (s390_linux_nat_target::stopped_by_watchpoint)
6819 (s390_linux_nat_target::low_prepare_to_resume)
6820 (s390_linux_nat_target::insert_watchpoint)
6821 (s390_linux_nat_target::insert_hw_breakpoint)
6822 (s390_linux_nat_target::remove_watchpoint)
6823 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6824
6825 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6826
6827 * aarch64-fbsd-nat.c: Include regcache.h.
6828 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6829 argument.
6830 (aarch64_fbsd_nat_target::fetch_registers)
6831 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6832 variable.
6833 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6834
6835 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6836
6837 * fbsd-nat.c: Include gdbarch.h.
6838
6839 2019-07-15 Tom Tromey <tromey@adacore.com>
6840
6841 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6842
6843 2019-07-15 Tom Tromey <tromey@adacore.com>
6844
6845 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6846 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6847 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6848 * cli-out.c (cli_ui_out::do_field_int): New method.
6849 * ui-out.c (ui_out::field_unsigned): New method.
6850 * symfile.c (generic_load): Use field_unsigned.
6851 (print_transfer_performance): Likewise.
6852 * record-btrace.c (ui_out_field_uint): Remove.
6853 (btrace_call_history_insn_range, btrace_call_history): Use
6854 field_unsigned.
6855 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6856 field_unsigned.
6857 * ui-out.h (class ui_out) <field_unsigned>: New method.
6858 <do_field_unsigned>: Likewise.
6859
6860 2019-07-15 Tom Tromey <tromey@adacore.com>
6861
6862 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6863 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6864 * target.c (flash_erase_command): Use field_string.
6865 * infrun.c (print_signal_received_reason): Use field_string.
6866 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6867 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6868 field_string.
6869 * ada-tasks.c (print_ada_task_info): Use field_string.
6870
6871 2019-07-15 Tom Tromey <tromey@adacore.com>
6872
6873 * target.c (flash_erase_command): Use field_core_addr.
6874 * symfile.c (generic_load): Use field_core_addr.
6875 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6876 Use field_core_addr.
6877 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6878 field_core_addr.
6879
6880 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6881
6882 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6883 value if its desired type is smaller than a CORE_ADDR and signed.
6884
6885 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6886
6887 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6888 of changes to field names, and use new is_reference field to
6889 decide if a property is a reference or not.
6890 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6891 field.
6892 (struct dwarf2_property_baton): Update header comment, rename
6893 'referenced_type' to 'property_type' and update comments.
6894 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6895 default property type, store in property baton, update to take
6896 accound of renamed field.
6897 (read_func_scope): Update call to attr_to_dynamic_prop.
6898 (read_array_type): Likewise.
6899 (dwarf2_per_cu_addr_sized_int_type): New function.
6900 (read_subrange_index_type): Move type finding code to
6901 dwarf2_per_cu_addr_sized_int_type.
6902 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6903 (dwarf2_per_cu_addr_type): New function.
6904 (set_die_type): Update calls to attr_to_dynamic_prop.
6905
6906 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6907
6908 * dwarf2read.c (read_subrange_index_type): New function.
6909 (read_subrange_type): Move code into new function and call it.
6910 * gdbtypes.c (create_range_type): Add some asserts.
6911
6912 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6913
6914 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6915 update return statements.
6916 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6917 declaration, and update comment to match.
6918 * gdbtypes.c (resolve_dynamic_array): Update call to
6919 dwarf2_evaluate_property to match new return type.
6920
6921 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6922
6923 * valarith.c (value_subscripted_rvalue): Change lowerbound
6924 parameter type from int to LONGEST.
6925 * value.h (value_subscripted_rvalue): Likewise in declaration.
6926
6927 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6928
6929 * cli/cli-utils.c (info_print_command_completer): New function.
6930 * cli/cli-utils.h: Add 'completer.h' include, and forward
6931 declaration for 'struct cmd_list_element'.
6932 (info_print_command_completer): Declare.
6933 * stack.c (_initialize_stack): Add completer for 'info locals' and
6934 'info args'.
6935 * symtab.c (_initialize_symtab): Add completer for 'info
6936 variables' and 'info functions'.
6937 * NEWS: Mention completion for additional info commands.
6938
6939 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6940
6941 * cli/cli-utils.c (extract_info_print_args): Delete.
6942 (extract_arg_maybe_quoted): Delete.
6943 (info_print_options_defs): New variable.
6944 (make_info_print_options_def_group): New function.
6945 (extract_info_print_options): Define new function.
6946 * cli/cli-utils.h (extract_info_print_args): Delete.
6947 (struct info_print_options): New structure.
6948 (extract_info_print_options): Declare new function.
6949 * stack.c (info_locals_command): Update to use new
6950 extract_info_print_options, also add a header comment.
6951 (info_args_command): Likewise.
6952 * symtab.c (info_variables_command): Likewise.
6953 (info_functions_command): Likewise.
6954
6955 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6956
6957 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6958 to extract string arguments.
6959 * common/common-utils.c (extract_string_maybe_quoted): New function.
6960 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6961
6962 2019-07-11 Tom Tromey <tromey@adacore.com>
6963
6964 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6965 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6966 * top.h (gdbinit): Don't declare.
6967 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6968 into...
6969 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6970 * top.c (gdb_init): Don't call init_cli_cmds.
6971 (gdbinit): Remove.
6972 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6973
6974 2019-07-11 Tom Tromey <tromey@adacore.com>
6975
6976 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6977 after it has been moved.
6978
6979 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6980
6981 * valops.c (value_must_coerce_to_target): Change return type to
6982 bool.
6983 * value.h (value_must_coerce_to_target): Likewise.
6984
6985 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
6986
6987 * breakpoint.c (is_hardware_watchpoint): Remove
6988 forward-declaration.
6989 (is_masked_watchpoint): Change return type to bool.
6990 (is_tracepoint): Likewise.
6991 (is_breakpoint): Likewise.
6992 (is_hardware_watchpoint): Likewise.
6993 (is_watchpoint): Likewise.
6994 (is_no_memory_software_watchpoint): Likewise.
6995 (is_catchpoint): Likewise.
6996 (breakpoint_1): Make FILTER parameter's return type bool.
6997 is_masked_watchpoint): Change return type to bool.
6998 (save_breakpoints): Make FILTER parameter's return type bool.
6999 * breakpoint.h (is_breakpoint): Change return type to bool.
7000 (is_watchpoint): Likewise.
7001 (is_catchpoint): Likewise.
7002 (is_tracepoint): Likewise.
7003
7004 2019-07-10 Tom Tromey <tom@tromey.com>
7005
7006 * defs.h: Don't include gdbarch.h.
7007 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7008 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7009 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7010 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7011 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7012 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7013 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7014 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7015 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7016 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7017 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7018 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7019 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7020 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7021 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7022 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7023 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7024 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7025 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7026 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7027 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7028 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7029 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7030 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7031 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7032 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7033 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7034
7035 2019-07-10 Tom Tromey <tromey@adacore.com>
7036
7037 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7038 * breakpoint.c (init_ada_exception_breakpoint): Register as
7039 bp_catchpoint.
7040 (print_one_breakpoint_location, print_one_breakpoint): Use
7041 is_ada_exception_catchpoint.
7042 * ada-lang.c (class ada_catchpoint_location): Pass
7043 bp_loc_software_breakpoint to bp_location constructor.
7044 (is_ada_exception_catchpoint): New function.
7045
7046 2019-07-10 Tom Tromey <tromey@adacore.com>
7047
7048 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7049 VEC.
7050 (struct arm_exidx_entry): New method operator<.
7051 (struct arm_exidx_data) <section_maps>: Change type.
7052 (arm_exidx_data_free): Remove.
7053 (arm_exidx_data_key): Change type. Move lower.
7054 (arm_exidx_new_objfile): Update.
7055 (arm_compare_exidx_entries): Remove.
7056 (arm_find_exidx_entry, _initialize_arm_tdep)
7057
7058 2019-07-10 Tom Tromey <tromey@adacore.com>
7059
7060 * solib-spu.c (ocl_program_data_key): Change type.
7061 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7062 Update.
7063
7064 2019-07-10 Tom Tromey <tromey@adacore.com>
7065
7066 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7067 (struct solib_aix_inferior_data) <library_list>: Change type.
7068 (solib_aix_inferior_data_handle): Change type.
7069 (get_solib_aix_inferior_data): Update.
7070 (solib_aix_free_library_list): Remove.
7071 (library_list_start_library): Update.
7072 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7073 return type.
7074 (solib_aix_get_library_list)
7075 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7076 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7077
7078 2019-07-10 Tom Tromey <tromey@adacore.com>
7079
7080 * solib-dsbt.c (struct dsbt_info): Add initializers.
7081 (solib_dsbt_pspace_data): Change type.
7082 (dsbt_pspace_data_cleanup): Remove.
7083 (get_dsbt_info, _initialize_dsbt_solib): Update.
7084
7085 2019-07-10 Tom Tromey <tromey@adacore.com>
7086
7087 * spu-tdep.c (spu_overlay_data): Change type.
7088 (spu_get_overlay_table, spu_overlay_new_objfile)
7089 (_initialize_spu_tdep): Update.
7090
7091 2019-07-10 Tom Tromey <tromey@adacore.com>
7092
7093 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7094 destructor.
7095 (dbx_objfile_data_key): Change type and declare later.
7096 (DBX_SYMFILE_INFO): Rewrite.
7097 * dbxread.c (dbx_objfile_data_key): Change type.
7098 (dbx_symfile_init): Update.
7099 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7100 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7101 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7102
7103 2019-07-10 Tom Tromey <tromey@adacore.com>
7104
7105 * jit.c (jit_program_space_key): Change type. Move lower.
7106 (get_jit_program_space_data): Update.
7107 (jit_program_space_data_cleanup): Remove.
7108 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7109 Update.
7110 (struct jit_program_space_data): Add initializers.
7111
7112 2019-07-10 Tom Tromey <tromey@adacore.com>
7113
7114 * solib-darwin.c (struct darwin_info): Add initializers.
7115 (solib_darwin_pspace_data): Change type.
7116 (darwin_pspace_data_cleanup): Remove.
7117 (get_darwin_info, _initialize_darwin_solib): Update.
7118
7119 2019-07-10 Tom Tromey <tromey@adacore.com>
7120
7121 * remote-sim.c (struct sim_inferior_data): Add initializers,
7122 constructor, and destructor.
7123 (sim_inferior_data_key): Change type. Move lower.
7124 (check_for_duplicate_sim_descriptor): Update.
7125 (get_sim_inferior_data): Use new. Update.
7126 (~sim_inferior_data_cleanup): Rename from
7127 sim_inferior_data_cleanup. Simplify.
7128 (gdbsim_close_inferior, simulator_command)
7129 (sim_command_completer, _initialize_remote_sim): Update.
7130 (next_pid, INITIAL_PID): Move earlier.
7131
7132 2019-07-10 Tom Tromey <tromey@adacore.com>
7133
7134 * python/python-internal.h (create_thread_object): Return
7135 gdbpy_ref.
7136 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7137 * python/py-inferior.c (struct threadlist_entry): Add
7138 constructor.
7139 <thread_obj>: Now a gdbpy_ref.
7140 (thread_to_thread_object): Update.
7141 (add_thread_object): Use new.
7142 (delete_thread_object): Use delete.
7143 (infpy_threads): Update.
7144 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7145 GIL.
7146
7147 2019-07-10 Tom Tromey <tromey@adacore.com>
7148
7149 * valops.c (value_cast): Specialize error message for Ada.
7150
7151 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7152
7153 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7154
7155 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7156
7157 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7158 bpstat_should_step): Return bool, adjust comments.
7159 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7160 bpstat_should_step): Likewise.
7161
7162 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7163
7164 * features/Makefile: Use feature target descriptions for Arm.
7165 * features/arm/arm-core.c: Generate new file.
7166 * features/arm/arm-fpa.c: Likewise.
7167 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7168 * features/arm/arm-m-profile.c: Likewise.
7169 * features/arm/arm-vfpv2.c: Likewise.
7170 * features/arm/arm-vfpv3.c: Likewise.
7171 * features/arm/xscale-iwmmxt.c: Likewise.
7172 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7173
7174 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7175
7176 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7177 ptrace earlier.
7178
7179 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7180
7181 * features/aarch64-pauth.c: Regenerate.
7182
7183 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7184
7185 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7186 bool.
7187 (bpstat_what): Use false instead of 0.
7188
7189 2019-07-09 Pedro Alves <palves@redhat.com>
7190
7191 * break-catch-throw.c (is_exception_catchpoint): New.
7192 * breakpoint.c (print_one_breakpoint_location): New parameter
7193 'raw_loc'. Handle it. Use
7194 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7195 looking at the breakpoint's type.
7196 (print_one_breakpoint): If handling "maint info breakpoints", also
7197 print locations of exception catchpoints.
7198 * breakpoint.h (is_exception_catchpoint): Declare.
7199
7200 2019-07-09 Pedro Alves <palves@redhat.com>
7201
7202 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7203 "addr" field.
7204 (allocate_location_exception_catchpoint): New.
7205 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7206 (initialize_throw_catchpoint_ops): Install
7207 allocate_location_exception_catchpoint as allocate_location
7208 method.
7209 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7210 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7211 bp_loc_other.
7212 (breakpoint_address_is_meaningful): Delete.
7213 (bl_address_is_meaningful): New.
7214 (breakpoint_locations_match): Adjust comment.
7215 (bp_location_from_bp_type): New, factored out of...
7216 (bp_location::bp_location(breakpoint *)): ... this.
7217 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7218 factored out of...
7219 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7220 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7221 breakpoint_address_is_meaningful.
7222 (bp_locations_compare): Adjust comment.
7223 (update_global_location_list): Use bl_address_is_meaningful
7224 instead of breakpoint_address_is_meaningful.
7225 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7226 explicit.
7227 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7228 * python/py-breakpoint.c (bppy_get_location): No longer check
7229 whether location is null.
7230
7231 2019-07-09 Pedro Alves <palves@redhat.com>
7232
7233 PR c++/15468
7234 * breakpoint.c (print_one_breakpoint_location): Remove
7235 single-location assert.
7236
7237 2019-07-09 Tom Tromey <tom@tromey.com>
7238
7239 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7240 * configure: Rebuild.
7241 * configure.ac: Change common to gdbsupport.
7242 * gdbsupport: Rename from common.
7243 * acinclude.m4: Change common to gdbsupport.
7244 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7245 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7246 gdbsupport.
7247 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7248 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7249 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7250 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7251 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7252 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7253 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7254 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7255 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7256 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7257 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7258 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7259 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7260 coff-pe-read.c, command.h, compile/compile-c-support.c,
7261 compile/compile-c.h, compile/compile-cplus-symbols.c,
7262 compile/compile-cplus-types.c, compile/compile-cplus.h,
7263 compile/compile-loc2c.c, compile/compile.c, completer.c,
7264 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7265 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7266 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7267 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7268 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7269 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7270 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7271 features/aarch64-core.c, features/aarch64-fpu.c,
7272 features/aarch64-pauth.c, features/aarch64-sve.c,
7273 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7274 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7275 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7276 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7277 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7278 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7279 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7280 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7281 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7282 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7283 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7284 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7285 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7286 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7287 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7288 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7289 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7290 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7291 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7292 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7293 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7294 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7295 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7296 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7297 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7298 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7299 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7300 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7301 minsyms.c, mips-linux-tdep.c, namespace.h,
7302 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7303 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7304 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7305 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7306 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7307 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7308 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7309 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7310 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7311 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7312 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7313 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7314 procfs.c, producer.c, progspace.h, psymtab.h,
7315 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7316 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7317 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7318 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7319 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7320 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7321 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7322 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7323 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7324 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7325 target-memory.c, target.c, target.h, target/waitstatus.c,
7326 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7327 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7328 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7329 unittests/array-view-selftests.c,
7330 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7331 unittests/common-utils-selftests.c,
7332 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7333 unittests/format_pieces-selftests.c,
7334 unittests/function-view-selftests.c,
7335 unittests/lookup_name_info-selftests.c,
7336 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7337 unittests/mkdir-recursive-selftests.c,
7338 unittests/observable-selftests.c,
7339 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7340 unittests/parse-connection-spec-selftests.c,
7341 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7342 unittests/scoped_fd-selftests.c,
7343 unittests/scoped_mmap-selftests.c,
7344 unittests/scoped_restore-selftests.c,
7345 unittests/string_view-selftests.c, unittests/style-selftests.c,
7346 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7347 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7348 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7349 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7350 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7351 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7352
7353 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7354
7355 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7356 bool value.
7357 (decode_digits_ordinary): Set explicit_line field in sal.
7358 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7359 symtab_and_line that was set on an explicit line number in
7360 assembler code. Do always update the recorded symtab and line if
7361 we do skip the prologue.
7362
7363 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7364
7365 * breakpoint.c (set_breakpoint_location_function): Remove
7366 explicit_loc parameter.
7367 (momentary_breakpoint_from_master): Update call to
7368 set_breakpoint_location_function.
7369 (add_location_to_breakpoint): Likewise.
7370
7371 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7372
7373 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7374 required features based on default bfd type when no specific bfd
7375 is present.
7376
7377 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7378
7379 * NEWS: Mention that GDB printf and eval commands can now print
7380 C-style and Ada-style convenience var strings without
7381 calling the inferior.
7382 * printcmd.c (printf_c_string): Locally print GDB internal var
7383 instead of transiting via the inferior.
7384 (printf_wide_c_string): Likewise.
7385
7386 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7387
7388 PR breakpoints/25011
7389 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7390
7391 2019-07-04 Tom Tromey <tom@tromey.com>
7392
7393 PR tui/24724:
7394 * tui/tui-winsource.c (tui_clear_source_content): Update.
7395 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7396 (tui_update_breakpoint_info): Update.
7397 (tui_set_exec_info_content): Update.
7398 * tui/tui-source.c (tui_set_source_content_nil): Update.
7399 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7400 has_break.
7401 * tui/tui-data.h (enum tui_bp_flag): New.
7402 (tui_bp_flags): New enum flags type.
7403 (struct tui_source_element) <break_mode>: Change type. Rename
7404 from has_break.
7405 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7406 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7407 constants.
7408 * tui/tui-winsource.h: Fix comment.
7409
7410 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7411
7412 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7413 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7414 (store_fpregs_to_thread)
7415 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7416 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7417 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7418 (IWMMXT_REGS_SIZE): Add define.
7419 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7420 (fetch_vfp_regs, store_vfp_regs)
7421 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7422 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7423
7424 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7425
7426 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7427 defines.
7428 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7429 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7430 (ARM_INT_REGISTER_SIZE): ...to this.
7431 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7432 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7433 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7434 (arm_linux_collect_gregset, supply_nwfpe_register)
7435 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7436 defines.
7437 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7438 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7439 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7440 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7441 (arm_return_in_memory, arm_store_return_value)
7442 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7443 (arm_record_ld_st_multiple): Likewise.
7444 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7445 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7446
7447 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7448
7449 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7450 AARCH64_DISPLACED_MODIFIED_INSNS.
7451 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7452 (aarch64_displaced_step_copy_insn): Likewise.
7453 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7454 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7455 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7456 ARM_DISPLACED_MODIFIED_INSNS.
7457 * arm-tdep.c (arm_gdbarch_init): Likewise.
7458 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7459 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7460 (struct arm_displaced_step_closure): Use
7461 ARM_DISPLACED_MODIFIED_INSNS.
7462
7463 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7464
7465 * features/Makefile: Remove unused xml files.
7466 * features/aarch64.xml: Remove.
7467 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7468 * features/i386/amd64-avx-avx512.xml: Remove.
7469 * features/i386/amd64-avx-linux.xml: Remove.
7470 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7471 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7472 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7473 * features/i386/amd64-avx-mpx.xml: Remove.
7474 * features/i386/amd64-avx.xml: Remove.
7475 * features/i386/amd64-linux.xml: Remove.
7476 * features/i386/amd64-mpx-linux.xml: Remove.
7477 * features/i386/amd64-mpx.xml: Remove.
7478 * features/i386/amd64.xml: Remove.
7479 * features/i386/i386-avx-avx512-linux.xml: Remove.
7480 * features/i386/i386-avx-avx512.xml: Remove.
7481 * features/i386/i386-avx-linux.xml: Remove.
7482 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7483 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7484 * features/i386/i386-avx-mpx-linux.xml: Remove.
7485 * features/i386/i386-avx-mpx.xml: Remove.
7486 * features/i386/i386-avx.xml: Remove.
7487 * features/i386/i386-linux.xml: Remove.
7488 * features/i386/i386-mmx-linux.xml: Remove.
7489 * features/i386/i386-mmx.xml: Remove.
7490 * features/i386/i386-mpx-linux.xml: Remove.
7491 * features/i386/i386-mpx.xml: Remove.
7492 * features/i386/i386.xml: Remove.
7493 * features/i386/x32-avx-avx512-linux.xml: Remove.
7494 * features/i386/x32-avx-linux.xml: Remove.
7495 * features/i386/x32-linux.xml: Remove.
7496
7497 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7498
7499 * regformats/aarch64.dat: Remove.
7500 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7501 * regformats/i386/amd64-avx-linux.dat: Remove.
7502 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7503 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7504 * regformats/i386/amd64-linux.dat: Remove.
7505 * regformats/i386/amd64-mpx-linux.dat: Remove.
7506 * regformats/i386/amd64.dat: Remove.
7507 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7508 * regformats/i386/i386-avx-linux.dat: Remove.
7509 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7510 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7511 * regformats/i386/i386-linux.dat: Remove.
7512 * regformats/i386/i386-mmx-linux.dat: Remove.
7513 * regformats/i386/i386-mpx-linux.dat: Remove.
7514 * regformats/i386/i386.dat: Remove.
7515 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7516 * regformats/i386/x32-avx-linux.dat: Remove.
7517 * regformats/i386/x32-linux.dat: Remove.
7518
7519 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7520
7521 * aarch64-tdep.c: Remove xml self tests.
7522 * amd64-linux-tdep.c: Likewise.
7523 * amd64-tdep.c: Likewise.
7524 * i386-linux-tdep.c: Likewise.
7525 * i386-tdep.c: Likewise.
7526
7527 2019-07-03 Pedro Alves <palves@redhat.com>
7528
7529 PR cli/24732
7530 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7531 (pipe_cmd_option_defs): New.
7532 (make_pipe_cmd_options_def_group): New.
7533 (pipe_command): Use gdb::option::process_options.
7534 (pipe_command_completer): New function.
7535 (_initialize_cli_cmds): Install completer for "pipe" command.
7536
7537 2019-07-03 Pedro Alves <palves@redhat.com>
7538
7539 * cli/cli-option.c (union option_value) <string>: New field.
7540 (struct option_def_and_value): Add ctor, move ctor, dtor and
7541 use DISABLE_COPY_AND_ASSIGN.
7542 (option_def_and_value::clear_value): New.
7543 (parse_option, save_option_value_in_ctx, get_val_type_str)
7544 (add_setshow_cmds_for_options): Handle var_string.
7545 * cli-option.h (union option_def::var_address) <string>: New
7546 field.
7547 (struct string_option_def): New.
7548 * maint-test-options.c (struct test_options_opts): Add default
7549 ctor and use DISABLE_COPY_AND_ASSIGN.
7550 <string_opt>: New field.
7551 (test_options_opts::~test_options_opts): New.
7552 (test_options_opts::dump): Also dump "-string".
7553 (test_options_option_defs): Install "string.
7554
7555 2019-07-03 Pedro Alves <palves@redhat.com>
7556
7557 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7558 option_value with a null enumeration.
7559 (complete_options): Save the option values in the context.
7560 (save_option_value_in_ctx): New, factored out from ...
7561 (process_options): ... here.
7562 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7563 of the function.
7564 * maint-test-options.c (test_options_opts::dump): New, factored
7565 out from ...
7566 (maintenance_test_options_command_mode): ... here.
7567 (maintenance_test_options_command_completion_result): Delete.
7568 (maintenance_test_options_command_completion_text): Update
7569 comment.
7570 (maintenance_show_test_options_completion_result): Change
7571 prototype. Just print
7572 maintenance_test_options_command_completion_text.
7573 (save_completion_result): New.
7574 (maintenance_test_options_completer_mode): Pass options context to
7575 complete_options, and then save a dump.
7576 (_initialize_maint_test_options): Use add_cmd to install "maint
7577 show test-options-completion-result".
7578
7579 2019-07-03 Pedro Alves <palves@redhat.com>
7580
7581 * NEWS (New commands): Mention "with" and "maint with".
7582 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7583 (with_command, with_command_completer): New.
7584 (pipe_command): Adjust to new repeat_previous
7585 interface.
7586 (_initialize_cli_cmds): Install the "with" command and its "w"
7587 alias.
7588 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7589 declarations.
7590 * cli/cli-setshow.c (parse_cli_var_uinteger)
7591 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7592 argument strings for all var_types.
7593 (get_setshow_command_value_string): New, factored out from ...
7594 (do_show_command): ... this.
7595 * cli/cli-setshow.h: Include <string>.
7596 (get_setshow_command_value_string): Declare.
7597 * command.h (repeat_previous): Now returns const char *. Adjust
7598 comment.
7599 * maint.c: Include "cli/cli-cmds.h".
7600 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7601 (_initialize_maint_cmds): Register the "maintenance with" command.
7602 * top.c (repeat_previous): Move bits from pipe_command here:
7603 Return the saved command line, if any; error out if there's no
7604 command to relaunch.
7605
7606 2019-07-03 Pedro Alves <palves@redhat.com>
7607
7608 * NEWS (New commands): Mention "maint set/show test-settings"
7609 instead of "maint test-settings".
7610 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7611 (maintenance_test_settings_set_list): Rename to ...
7612 (maintenance_set_test_settings_list): ... this.
7613 (maintenance_test_settings_show_list): Rename to ...
7614 (maintenance_show_test_settings_list): ... this.
7615 (maintenance_test_settings_cmd): Delete.
7616 (maintenance_test_settings_set_cmd): ...
7617 (maintenance_set_test_settings_cmd): ... this.
7618 (maintenance_test_settings_show_cmd): ...
7619 (maintenance_show_test_settings_cmd): ... this.
7620 (maintenance_test_settings_show_value_cmd):
7621 (maintenance_show_test_settings_value_cmd): ... this.
7622 (_initialize_maint_test_settings): No longer install the "maint
7623 test-settings" prefix command. Rename "maint test-settings set"
7624 to "maint set test-settings", and "maint test-settings show" to
7625 "maint show test-settings". Adjust all subcommands.
7626
7627 2019-07-03 Pedro Alves <palves@redhat.com>
7628
7629 * maint-test-settings.c: Fix file's intro comment. Replace all
7630 references to "test-options" with references to "test-settings",
7631 in comments.
7632
7633 2019-07-03 Pedro Alves <palves@redhat.com>
7634
7635 * maint-test-settings.c (maintenance_test_settings_xxx)
7636 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7637 New.
7638 (maintenance_test_settings_enums): Use them.
7639 (maintenance_test_settings_enum): Default to
7640 maintenance_test_settings_xxx.
7641 (_initialize_maint_test_settings): Initialize
7642 MAINTENANCE_TEST_SETTINGS_FILENAME.
7643
7644 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7645
7646 * breakpoint.h (remove_breakpoints_inf): Change return type to
7647 void, move function documentation here.
7648 * breakpoint.c (remove_breakpoints_inf): Change return type to
7649 void, move function documentation to header.
7650
7651 2019-07-02 Pedro Alves <palves@redhat.com>
7652
7653 * NEWS (Completion improvements): Mention "info threads".
7654 * thread.c (struct info_threads_opts, info_threads_option_defs)
7655 (make_info_threads_options_def_group): New.
7656 (info_threads_command): Use gdb::option::process_options.
7657 (info_threads_command_completer): New.
7658 (_initialize_thread): Use gdb::option::build_help to build the
7659 help text for "info threads".
7660
7661 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7662
7663 * defs.h (generic_load): Move from here...
7664 * symfile.h (generic_load): ... to here. Rename name parameter
7665 to args.
7666 * symfile.c (generic_load): Add comment.
7667
7668 2019-07-01 Tom Tromey <tromey@adacore.com>
7669
7670 * dwarf2read.c
7671 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7672 declaration of without_params. Fix formatting.
7673
7674 2019-07-01 Tom Tromey <tromey@adacore.com>
7675
7676 * ada-exp.y (find_primitive_type): Update.
7677 * ada-lang.h (ada_lookup_symbol): Update.
7678 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7679 parameter.
7680 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7681
7682 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7683
7684 PR breakpoints/24541
7685 * gdbarch.c: Regenerate.
7686 * gdbarch.h: Regenerate.
7687 * gdbarch.sh: Add 'stap_adjust_register'.
7688 * i386-tdep.c: Include '<unordered_set>'.
7689 (i386_stap_adjust_register): New function.
7690 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7691 * stap-probe.c (stap_parse_register_operand): Call
7692 'gdbarch_stap_adjust_register'.
7693
7694 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7695
7696 PR python/24742
7697 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7698 * python/python.c (do_start_initialization): Use 'xmalloc'
7699 instead of 'PyMem_Malloc'.
7700
7701 2019-06-28 Tom Tromey <tromey@adacore.com>
7702
7703 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7704 for Ada.
7705
7706 2019-06-27 Tom Tromey <tromey@adacore.com>
7707
7708 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7709 objfile_key.
7710 (arm_find_mapping_symbol, arm_record_special_symbol)
7711 (_initialize_arm_tdep): Update.
7712 (arm_objfile_data_free): Remove.
7713
7714 2019-06-27 Tom Tromey <tromey@adacore.com>
7715
7716 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7717 to cp_print_static_field.
7718
7719 2019-06-26 Tom Tromey <tromey@adacore.com>
7720
7721 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7722 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7723 declare.
7724
7725 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7726
7727 * features/aarch64-core.c (create_feature_aarch64_core):
7728 Regenerate.
7729 * features/aarch64-core.xml: Add cpsr flags.
7730
7731 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7732
7733 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7734 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7735
7736 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7737
7738 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7739 field.
7740 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7741 use.
7742 (arm_record_special_symbol): Don't insert new symbol in sorted
7743 position, push it at the end.
7744
7745 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7746
7747 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7748 (arm_mapping_symbol_s): Remove.
7749 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7750 (arm_mapping_symbol_vec): New typedef.
7751 (struct arm_per_objfile): Add constructor.
7752 <section_maps>: Change type to
7753 std::unique_ptr<arm_mapping_symbol_vec[]>.
7754 (arm_compare_mapping_symbols): Remove.
7755 (arm_find_mapping_symbol): Adjust to section_maps type change.
7756 (arm_objfile_data_free): Call delete on arm_per_objfile.
7757 (arm_record_special_symbol): Adjust to section_maps type change.
7758 Allocate arm_per_objfile with new.
7759
7760 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7761
7762 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7763 with the command prefix.
7764
7765 2019-06-25 Tom Tromey <tom@tromey.com>
7766
7767 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7768 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7769
7770 2019-06-25 Tom Tromey <tom@tromey.com>
7771
7772 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7773 type.
7774 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7775 protected.
7776
7777 2019-06-25 Tom Tromey <tom@tromey.com>
7778
7779 * tui/tui-winsource.c
7780 (tui_source_window_base::set_is_exec_point_at): Add check against
7781 LOA_ADDRESS.
7782
7783 2019-06-25 Tom Tromey <tom@tromey.com>
7784
7785 * tui/tui-source.c (tui_set_source_content): Don't check before
7786 xfree.
7787 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7788
7789 2019-06-25 Tom Tromey <tom@tromey.com>
7790
7791 * tui/tui-winsource.h (tui_update_source_window_as_is)
7792 (tui_alloc_source_buffer, tui_line_is_displayed)
7793 (tui_addr_is_displayed): Change type of win_info.
7794 * tui/tui-winsource.c (tui_update_source_window_as_is)
7795 (tui_clear_source_content, tui_show_source_line)
7796 (tui_show_source_content, tui_source_window_base::refill)
7797 (tui_source_window_base::set_is_exec_point_at)
7798 (tui_source_window_base::set_is_exec_point_at)
7799 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7800 (tui_alloc_source_buffer, tui_line_is_displayed)
7801 (tui_addr_is_displayed): Change type of win_info. Update.
7802 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7803 (tui_source_window_base::do_make_visible_with_new_height):
7804 Update.
7805 * tui/tui-source.c (tui_set_source_content)
7806 (tui_set_source_content_nil)
7807 (tui_source_window::do_scroll_vertical): Update.
7808 * tui/tui-layout.c (show_layout): Update.
7809 * tui/tui-disasm.c (tui_set_disassem_content)
7810 (tui_disasm_window::do_scroll_vertical): Update.
7811 * tui/tui-data.h (tui_win_content): Remove.
7812 (struct tui_gen_win_info) <content, content_size>: Remove.
7813 (struct tui_source_element): Add initializers and destructor.
7814 (union tui_which_element, struct tui_win_element): Remove.
7815 (struct tui_source_window_base) <content>: New field.
7816 (struct tui_data_window): Remove destructor.
7817 (tui_alloc_content, tui_free_win_content)
7818 (tui_free_all_source_wins_content): Don't declare.
7819 * tui/tui-data.c (tui_initialize_static_data): Update.
7820 (init_content_element, tui_alloc_content): Remove.
7821 (~tui_gen_win_info): Update.
7822 (~tui_data_window, tui_free_all_source_wins_content)
7823 (tui_free_win_content, free_content, free_content_elements):
7824 Remove.
7825
7826 2019-06-25 Tom Tromey <tom@tromey.com>
7827
7828 * tui/tui-winsource.h (tui_clear_source_content)
7829 (tui_erase_source_content, tui_show_source_content): Change type
7830 of win_info.
7831 * tui/tui-winsource.c (tui_clear_source_content)
7832 (tui_erase_source_content, tui_show_source_content): Change type
7833 of win_info.
7834 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7835 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7836 win_info.
7837 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7838 win_info.
7839 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7840
7841 2019-06-25 Tom Tromey <tom@tromey.com>
7842
7843 * tui/tui-winsource.c (tui_clear_source_content)
7844 (tui_source_window_base::set_is_exec_point_at): Update.
7845 * tui/tui-source.c (tui_set_source_content_nil): Update.
7846 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7847 a bool.
7848 * tui/tui-data.c (init_content_element): Update.
7849
7850 2019-06-25 Tom Tromey <tom@tromey.com>
7851
7852 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7853 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7854 * tui/tui-layout.c (init_and_make_win): Update.
7855 * tui/tui.h (enum tui_win_type): Update.
7856 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7857 tui_win_is_auxillary.
7858 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7859 tui_win_is_auxillary.
7860
7861 2019-06-25 Tom Tromey <tom@tromey.com>
7862
7863 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7864 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7865 (tui_delete_data_content_windows, tui_display_all_data)
7866 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7867 Update.
7868 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7869 * tui/tui-regs.c (tui_last_regs_line_no)
7870 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7871 (tui_show_registers): Update.
7872 (tui_show_register_group): Return void. Update.
7873 (tui_display_registers_from, tui_display_reg_element_at_line)
7874 (tui_display_registers_from_line, tui_check_register_values):
7875 Update.
7876 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7877 member.
7878 (struct tui_data_window) <regs_content>: Now a std::vector.
7879 <regs_content_count>: Remove.
7880 (tui_add_content_elements, tui_free_data_content): Don't declare.
7881 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7882 (init_content_element): Remove DATA_WIN case. Add assert.
7883 (tui_add_content_elements): Remove.
7884 (tui_data_window): Update.
7885 (tui_free_data_content): Remove.
7886 (free_content_elements): Remove DATA_WIN case.
7887
7888 2019-06-25 Tom Tromey <tom@tromey.com>
7889
7890 * tui/tui-data.c (tui_data_item_window): Update.
7891 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7892 * tui/tui-windata.c (tui_display_all_data)
7893 (tui_display_data_from_line): Update.
7894 (tui_check_data_values): Remove.
7895 * tui/tui-regs.c (tui_show_register_group)
7896 (tui_display_reg_element_at_line): Update.
7897 * tui/tui-hooks.c (tui_register_changed)
7898 (tui_refresh_frame_and_register_information): Call
7899 tui_check_register_values.
7900 * tui/tui-data.h (struct tui_data_window) <data_content,
7901 data_content_count, data_type>: Remove.
7902 (enum tui_data_type): Remove.
7903
7904 * tui/tui-data.c (tui_data_window::clear_detail)
7905 (~tui_data_window): Update.
7906
7907 2019-06-25 Tom Tromey <tom@tromey.com>
7908
7909 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7910 declare.
7911 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7912 Rename from tui_first_data_item_displayed. Update.
7913 (tui_data_window::refresh_all)
7914 (tui_data_window::do_scroll_vertical): Update.
7915 * tui/tui-data.h (struct tui_data_window)
7916 <first_data_item_displayed>: Declare new method.
7917
7918 2019-06-25 Tom Tromey <tom@tromey.com>
7919
7920 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7921 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7922 contents...
7923 (tui_initialize_static_data): ...here.
7924
7925 2019-06-25 Tom Tromey <tom@tromey.com>
7926
7927 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7928 (tui_display_registers_from, tui_check_register_values): Update.
7929 (tui_display_register): Remove win_info parameter; update.
7930 (tui_get_register): Change type of parameters.
7931 * tui/tui-data.h (struct tui_data_element): Remove.
7932 (union tui_which_element) <data>: Remove.
7933 <data_window>: Change type.
7934 (struct tui_data_item_window): New.
7935 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7936 case. Add assert.
7937 (~tui_data_item_window): New destructor.
7938 (free_content_elements): Remove DATA_ITEM_WIN case.
7939
7940 2019-06-25 Tom Tromey <tom@tromey.com>
7941
7942 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7943 Remove.
7944
7945 2019-06-25 Tom Tromey <tom@tromey.com>
7946
7947 * tui/tui-data.h (struct tui_command_element): Remove.
7948 (union tui_which_element) <command>: Remove.
7949 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7950 assert.
7951 (free_content_elements): Remove CMD_WIN case.
7952
7953 2019-06-25 Tom Tromey <tom@tromey.com>
7954
7955 * tui/tui-layout.c (tui_set_layout): Update.
7956 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7957 * tui/tui-data.c (layout_def): Update.
7958
7959 2019-06-25 Tom Tromey <tom@tromey.com>
7960
7961 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7962 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7963 (tui_source_window_base::set_new_height): Update.
7964 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7965 Update.
7966 (tui_set_locator_fullname, tui_set_locator_info)
7967 (tui_show_frame_info): Update.
7968 * tui/tui-source.c (tui_set_source_content)
7969 (tui_source_is_displayed): Update.
7970 * tui/tui-layout.c (show_source_disasm_command, show_data)
7971 (show_source_or_disasm_and_command): Update.
7972 * tui/tui-disasm.c (tui_set_disassem_content)
7973 (tui_get_begin_asm_address): Update.
7974 * tui/tui-data.h (struct tui_locator_element): Remove.
7975 (union tui_which_element) <locator>: Remove.
7976 (struct tui_locator_window): New.
7977 (tui_locator_win_info_ptr): Change return type.
7978 * tui/tui-data.c (_locator): Change type.
7979 (tui_locator_win_info_ptr): Change return type.
7980 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7981 (tui_alloc_content): Add assert.
7982
7983 2019-06-25 Tom Tromey <tom@tromey.com>
7984
7985 * tui/tui-winsource.c
7986 (tui_exec_info_window::maybe_allocate_content): New method.
7987 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7988 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7989 (make_source_or_disasm_window): Add cast.
7990 * tui/tui-data.h (union tui_which_element) <simple_string>:
7991 Remove.
7992 (struct tui_source_info): New.
7993 (struct tui_source_window_base) <execution_info>: Change type.
7994 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7995 case, and add assert.
7996 (tui_alloc_content): Add assert.
7997
7998 2019-06-25 Tom Tromey <tom@tromey.com>
7999
8000 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8001 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8002 * tui/tui-data.c (tui_alloc_win_info): Remove.
8003
8004 2019-06-25 Tom Tromey <tom@tromey.com>
8005
8006 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8007 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8008 can_highlight.
8009
8010 2019-06-25 Tom Tromey <tom@tromey.com>
8011
8012 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8013 make_visible_with_new_height method.
8014 (tui_win_info::make_visible_with_new_height): New method.
8015 (tui_source_window_base::do_make_visible_with_new_height)
8016 (tui_data_window::do_make_visible_with_new_height)
8017 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8018 (make_visible_with_new_height): Remove.
8019 (tui_resize_all, tui_adjust_win_heights): Use
8020 make_visible_with_new_height method.
8021 * tui/tui-data.h (struct tui_win_info)
8022 <do_make_visible_with_new_height, make_visible_with_new_height>:
8023 New methods.
8024 (struct tui_source_window_base, struct tui_data_window)
8025 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8026 methods.
8027
8028 2019-06-25 Tom Tromey <tom@tromey.com>
8029
8030 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8031 method.
8032 (update_tab_width): Call update_tab_width method.
8033 * tui/tui-data.h (struct tui_win_info)
8034 (struct tui_source_window_base) <update_tab_width>: New methods.
8035
8036 2019-06-25 Tom Tromey <tom@tromey.com>
8037
8038 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8039 parameter.
8040 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8041 parameter.
8042 (tui_gen_win_info::make_visible): Update.
8043 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8044 parameter.
8045 * tui/tui-data.h (enum tui_box): New enum.
8046 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8047
8048 2019-06-25 Tom Tromey <tom@tromey.com>
8049
8050 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8051 init_and_make_win for EXEC_INFO_WIN.
8052 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8053 longer inline.
8054 (struct tui_win_info) <~tui_win_info>: Inline.
8055 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8056 Don't declare.
8057 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8058 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8059 Remove.
8060 (tui_initialize_static_data): Update.
8061 (~tui_gen_win_info): Handle more cleanup here.
8062 (~tui_source_window_base): Delete "execution_info".
8063 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8064
8065 2019-06-25 Tom Tromey <tom@tromey.com>
8066
8067 * tui/tui-layout.c (make_command_window): Don't set
8068 can_highlight.
8069 (show_source_disasm_command): Call the reset method.
8070 (show_data): Don't set can_highlight. Call the reset method.
8071 (tui_gen_win_info::reset): Rename from init_gen_win_info
8072 (init_and_make_win): Simplify. Return tui_gen_win_info.
8073 (show_source_or_disasm_and_command): Call the reset method.
8074 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8075 (struct tui_cmd_window): Set can_highlight.
8076
8077 2019-06-25 Tom Tromey <tom@tromey.com>
8078
8079 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8080 from make_visible.
8081 (tui_make_visible, tui_make_invisible): Rewrite.
8082 (tui_win_info::make_visible): Remove.
8083 (tui_source_window_base::make_visible): Update.
8084 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8085 method. Moved from...
8086 (struct tui_win_info) <make_visible>: ...here.
8087
8088 2019-06-25 Tom Tromey <tom@tromey.com>
8089
8090 * tui/tui-winsource.c
8091 (tui_source_window_base::do_scroll_horizontal): Remove direction
8092 parameter.
8093 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8094 direction parameter.
8095 * tui/tui-win.c (tui_win_info::forward_scroll)
8096 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8097 (tui_win_info::right_scroll): Update.
8098 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8099 direction parameter.
8100 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8101 direction parameter.
8102 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8103 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8104 Remove direction parameter.
8105 (struct tui_source_window_base, struct tui_source_window)
8106 (struct tui_disasm_window, struct tui_data_window)
8107 (struct tui_cmd_window): Update.
8108
8109 2019-06-25 Tom Tromey <tom@tromey.com>
8110
8111 * tui/tui-winsource.h (tui_set_exec_info_content)
8112 (tui_show_exec_info_content, tui_erase_exec_info_content)
8113 (tui_clear_exec_info_content, tui_update_exec_info): Change
8114 argument to tui_source_window_base.
8115 * tui/tui-winsource.c (tui_set_exec_info_content)
8116 (tui_show_exec_info_content, tui_erase_exec_info_content)
8117 (tui_clear_exec_info_content, tui_update_exec_info): Change
8118 argument to tui_source_window_base.
8119
8120 2019-06-25 Tom Tromey <tom@tromey.com>
8121
8122 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8123 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8124
8125 2019-06-25 Tom Tromey <tom@tromey.com>
8126
8127 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8128 check.
8129
8130 2019-06-25 Tom Tromey <tom@tromey.com>
8131
8132 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8133 type to void.
8134 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8135 type to void.
8136 * tui/tui-source.c (tui_set_source_content): Update.
8137 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8138
8139 2019-06-25 Tom Tromey <tom@tromey.com>
8140
8141 * tui/tui-win.c (window_name_completer, tui_set_focus)
8142 (tui_all_windows_info): Use name method.
8143 * tui/tui-data.h (struct tui_gen_win_info)
8144 (struct tui_source_window, struct tui_disasm_window)
8145 (struct tui_data_window, struct tui_cmd_window) <name>: New
8146 method.
8147 (tui_win_name): Don't declare.
8148 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8149 (tui_win_name): Remove.
8150
8151 2019-06-25 Tom Tromey <tom@tromey.com>
8152
8153 * tui/tui-winsource.h (tui_update_source_window)
8154 (tui_update_source_window_as_is): Change parameter type.
8155 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8156 to be a tui_source_window_base.
8157 (tui_update_source_window_as_is): Likewise.
8158 * tui/tui-win.c (make_visible_with_new_height): Update.
8159
8160 2019-06-25 Tom Tromey <tom@tromey.com>
8161
8162 * tui/tui-winsource.c (tui_erase_source_content)
8163 (tui_show_source_content, tui_show_exec_info_content)
8164 (tui_erase_exec_info_content): Use refresh_window method.
8165 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8166 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8167 from tui_refresh_win.
8168 (tui_data_window::refresh_window): New method.
8169 (tui_win_info::refresh, tui_source_window_base::refresh)
8170 (tui_refresh_all): Use refresh_window method.
8171 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8172 method.
8173 * tui/tui-regs.c (tui_display_register): Call refresh_window
8174 method.
8175 * tui/tui-layout.c (show_source_disasm_command)
8176 (show_source_or_disasm_and_command): Call refresh_window method.
8177 * tui/tui-data.h (struct tui_gen_win_info)
8178 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8179 New method.
8180
8181 2019-06-25 Tom Tromey <tom@tromey.com>
8182
8183 * tui/tui.c (tui_rl_other_window, tui_enable)
8184 (tui_is_window_visible, tui_get_command_dimension): Update.
8185 * tui/tui-winsource.c (tui_update_source_window_as_is)
8186 (tui_clear_source_content, tui_erase_source_content)
8187 (tui_show_source_line, tui_source_window_base::refill)
8188 (tui_source_window_base::do_scroll_horizontal)
8189 (tui_source_window_base::set_is_exec_point_at)
8190 (tui_update_breakpoint_info, tui_set_exec_info_content)
8191 (tui_alloc_source_buffer, tui_line_is_displayed)
8192 (tui_addr_is_displayed): Update.
8193 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8194 (tui_check_and_display_highlight_if_needed)
8195 (tui_win_info::make_visible, tui_win_info::refresh)
8196 (tui_refresh_all): Update.
8197 * tui/tui-windata.c (tui_first_data_item_displayed)
8198 (tui_delete_data_content_windows, tui_erase_data_content)
8199 (tui_display_all_data, tui_data_window::refresh_all)
8200 (tui_check_data_values): Update.
8201 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8202 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8203 (tui_win_info::backward_scroll, tui_refresh_all_win)
8204 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8205 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8206 (tui_source_window_base::set_new_height)
8207 (tui_data_window::set_new_height)
8208 (make_invisible_and_set_new_height)
8209 (make_visible_with_new_height, new_height_ok)
8210 (parse_scrolling_args): Update.
8211 * tui/tui-stack.c (tui_show_frame_info): Update.
8212 * tui/tui-source.c (tui_set_source_content)
8213 (tui_set_source_content_nil, tui_source_is_displayed)
8214 (tui_source_window::do_scroll_vertical): Update.
8215 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8216 (tui_display_registers_from, tui_display_reg_element_at_line)
8217 (tui_check_register_values, tui_reg_command): Update.
8218 * tui/tui-layout.c (tui_default_win_height)
8219 (show_source_disasm_command, show_data, init_and_make_win)
8220 (show_source_or_disasm_and_command): Update.
8221 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8222 (tui_redisplay_readline, tui_mld_flush)
8223 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8224 (tui_getc): Update.
8225 * tui/tui-disasm.c (tui_set_disassem_content)
8226 (tui_disasm_window::do_scroll_vertical): Update.
8227 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8228 Now virtual.
8229 (struct tui_win_info): Derive from tui_gen_win_info.
8230 <~tui_win_info>: Mark as override.
8231 <generic>: Remove member.
8232 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8233 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8234 (~tui_data_window, ~tui_win_info)
8235 (tui_free_all_source_wins_content): Update.
8236 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8237
8238 2019-06-25 Tom Tromey <tom@tromey.com>
8239
8240 * tui/tui-layout.c (init_and_make_win): Use new.
8241 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8242 destructor, initializers.
8243 (tui_alloc_generic_win_info): Don't declare.
8244 * tui/tui-data.c (_locator): Add argument to constructor.
8245 (source_win, disasm_win): New globals.
8246 (exec_info): Remove.
8247 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8248 Update.
8249 (tui_alloc_generic_win_info): Remove.
8250 (init_content_element): Use new.
8251 (tui_win_info::tui_win_info): Update.
8252 (free_content_elements) <case DATA_WIN>: Use delete.
8253
8254 2019-06-25 Tom Tromey <tom@tromey.com>
8255
8256 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8257 * tui/tui-windata.c (tui_first_data_item_displayed)
8258 (tui_delete_data_content_windows): Update.
8259 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8260 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8261 (tui_display_registers_from, tui_check_register_values): Update.
8262 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8263 pointer.
8264 * tui/tui-data.c (init_content_element): Update. Allocate the new
8265 window.
8266 (tui_free_data_content): Update.
8267 (free_content_elements) <case DATA_WIN>: Free the window.
8268
8269 2019-06-25 Tom Tromey <tom@tromey.com>
8270
8271 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8272 Update.
8273 * tui/tui-layout.c (make_command_window)
8274 (show_source_disasm_command, show_data, init_and_make_win)
8275 (show_source_or_disasm_and_command): Update.
8276 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8277 method.
8278 <can_highight, is_highlighted>: Now bool.
8279 (tui_set_win_highlight): Don't declare.
8280 * tui/tui-data.c (tui_set_win_highlight): Remove.
8281
8282 2019-06-25 Tom Tromey <tom@tromey.com>
8283
8284 * tui/tui-wingeneral.c (make_visible): Remove check of window
8285 type.
8286
8287 2019-06-25 Tom Tromey <tom@tromey.com>
8288
8289 * tui/tui-win.c (tui_win_info::max_height)
8290 (tui_cmd_window::max_height): New methods.
8291 (new_height_ok): Call max_height.
8292 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8293 <max_height>: New method.
8294
8295 2019-06-25 Tom Tromey <tom@tromey.com>
8296
8297 * tui/tui-win.c (tui_source_window_base::set_new_height)
8298 (tui_data_window::set_new_height): New methods.
8299 (make_invisible_and_set_new_height): Call set_new_height method.
8300 * tui/tui-data.h (struct tui_win_info)
8301 (struct tui_source_window_base, struct tui_data_window)
8302 <set_new_height>: New method.
8303
8304 2019-06-25 Tom Tromey <tom@tromey.com>
8305
8306 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8307 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8308 tui_refresh_data_win.
8309 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8310 method.
8311 (tui_refresh_all_win): Call the refresh_all method.
8312 (tui_set_focus): Likewise.
8313 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8314 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8315 Likewise.
8316
8317 2019-06-25 Tom Tromey <tom@tromey.com>
8318
8319 * tui/tui-winsource.h (tui_refill_source_window)
8320 (tui_set_is_exec_point_at): Don't declare.
8321 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8322 (tui_source_window_base::refill): Rename from
8323 tui_refill_source_window.
8324 (tui_source_window_base::do_scroll_horizontal): Update.
8325 (tui_source_window_base::set_is_exec_point_at): Rename from
8326 tui_set_is_exec_point_at.
8327 (tui_update_all_breakpoint_info): Update.
8328 * tui/tui-stack.c (tui_show_frame_info): Update.
8329 * tui/tui-layout.c (show_data): Add cast.
8330 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8331 * tui/tui-data.h (struct tui_source_window_base) <refill,
8332 set_is_exec_point_at>: New methods.
8333 (tui_source_windows, tui_add_to_source_windows): Update types.
8334 (tui_add_to_source_windows): Remove redundant declaration.
8335 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8336 (tui_source_windows): Change return type.
8337 (tui_clear_source_windows_detail): Update.
8338 (tui_add_to_source_windows): Change type of parameter.
8339 (tui_free_all_source_wins_content): Update.
8340
8341 2019-06-25 Tom Tromey <tom@tromey.com>
8342
8343 * tui/tui-wingeneral.c (tui_win_info::refresh)
8344 (tui_source_window_base::refresh): New methods.
8345 (tui_refresh_all): Call the refresh method.
8346 * tui/tui-data.h (struct tui_win_info)
8347 (struct tui_source_window_base) <refresh>: New method.
8348
8349 2019-06-25 Tom Tromey <tom@tromey.com>
8350
8351 * tui/tui.h (tui_is_window_visible): Return bool.
8352 * tui/tui.c (tui_is_window_visible): Return bool.
8353 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8354 (tui_make_visible, tui_make_invisible)
8355 (tui_win_info::make_visible)
8356 (tui_source_window_base::make_visible, make_all_visible)
8357 (tui_make_all_visible, tui_make_all_invisible): Update.
8358 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8359 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8360 bool.
8361 (struct tui_win_info, struct tui_source_window_base)
8362 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8363 * tui/tui-data.c (tui_init_generic_part): Update.
8364
8365 2019-06-25 Tom Tromey <tom@tromey.com>
8366
8367 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8368 (tui_source_window_base::make_visible): New methods.
8369 (make_all_visible): Make method call.
8370 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8371 (struct tui_source_window_base, struct tui_cmd_window): Override
8372 make_visible.
8373 (tui_win_is_source_type): Don't declare.
8374 * tui/tui-data.c (tui_win_is_source_type): Remove.
8375
8376 2019-06-25 Tom Tromey <tom@tromey.com>
8377
8378 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8379 NULL check.
8380
8381 2019-06-25 Tom Tromey <tom@tromey.com>
8382
8383 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8384 Inline constructor. Add initializers for members.
8385 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8386 constructors; now inline in class.
8387
8388 2019-06-25 Tom Tromey <tom@tromey.com>
8389
8390 * tui/tui-regs.c (tui_show_registers): Update.
8391 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8392 bool.
8393 * tui/tui-data.c (tui_data_window::clear_detail)
8394 (tui_data_window): Update.
8395
8396 2019-06-25 Tom Tromey <tom@tromey.com>
8397
8398 * tui/tui-windata.c (tui_display_all_data)
8399 (tui_display_data_from_line, tui_display_data_from)
8400 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8401 Update.
8402 * tui/tui-regs.c (tui_last_regs_line_no)
8403 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8404 (tui_show_registers, tui_show_register_group)
8405 (tui_display_registers_from, tui_display_reg_element_at_line)
8406 (tui_display_registers_from_line, tui_check_register_values)
8407 (tui_reg_next, tui_reg_prev): Update.
8408 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8409 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8410 tui_data_window.
8411 (struct tui_win_info) <detail>: Remove. Add new fields from
8412 tui_data_info.
8413 (TUI_DATA_WIN): Add cast.
8414 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8415 (~tui_data_window): Simplify.
8416
8417 2019-06-25 Tom Tromey <tom@tromey.com>
8418
8419 * tui/tui-layout.c (show_source_disasm_command)
8420 (show_source_or_disasm_and_command): Update.
8421 * tui/tui-io.c (update_cmdwin_start_line)
8422 (tui_redisplay_readline): Update.
8423 * tui/tui-data.h (struct tui_command_info): Remove.
8424 (struct tui_win_info) <detail>: Remove command_info member.
8425 (struct tui_data_window) <start_line>: New member, from
8426 tui_command_info.
8427 (TUI_CMD_WIN): Add casts.
8428
8429 2019-06-25 Tom Tromey <tom@tromey.com>
8430
8431 * tui/tui-winsource.c (tui_update_source_window)
8432 (tui_refill_source_window)
8433 (tui_source_window_base::do_scroll_horizontal)
8434 (tui_update_breakpoint_info, tui_set_exec_info_content)
8435 (tui_show_exec_info_content, tui_erase_exec_info_content)
8436 (tui_clear_exec_info_content): Update.
8437 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8438 Update.
8439 * tui/tui-win.c (make_invisible_and_set_new_height)
8440 (make_visible_with_new_height): Update.
8441 * tui/tui-source.c (tui_set_source_content)
8442 (tui_show_symtab_source): Update.
8443 * tui/tui-layout.c (extract_display_start_addr)
8444 (show_source_disasm_command, show_data)
8445 (make_source_or_disasm_window)
8446 (show_source_or_disasm_and_command): Update.
8447 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8448 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8449 "gdbarch".
8450 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8451 to tui_source_window_base.
8452 (struct tui_win_info) <detail>: Remove source_info member.
8453 (struct tui_source_window_base) <has_locator>: Inline.
8454 Move contents from tui_source_info; rename has_locator member to
8455 m_has_locator.
8456 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8457 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8458 header file.
8459 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8460 Simplify.
8461 (tui_free_all_source_wins_content): Cast to
8462 tui_source_window_base.
8463
8464 2019-06-25 Tom Tromey <tom@tromey.com>
8465
8466 * tui/tui-win.c (make_invisible_and_set_new_height)
8467 (make_visible_with_new_height): Call has_locator method.
8468 * tui/tui-layout.c (show_source_disasm_command, show_data)
8469 (show_source_or_disasm_and_command): Update for bool change.
8470 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8471 (tui_win_info) <has_locator>: New method.
8472 (struct tui_source_window_base) <has_locator>: New method.
8473 (tui_win_has_locator): Don't declare.
8474 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8475 from tui_win_has_locator.
8476 (tui_source_window_base): Use false, not FALSE.
8477
8478 2019-06-25 Tom Tromey <tom@tromey.com>
8479
8480 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8481 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8482 clear_detail method directly.
8483 (tui_clear_win_detail): Remove.
8484
8485 2019-06-25 Tom Tromey <tom@tromey.com>
8486
8487 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8488 "this", not TUI_DISASM_WIN.
8489
8490 2019-06-25 Tom Tromey <tom@tromey.com>
8491
8492 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8493 declare.
8494 * tui/tui-winsource.c
8495 (tui_source_window_base::do_scroll_horizontal): Rename from
8496 tui_horizontal_source_scroll.
8497 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8498 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8499 from tui_vertical_data_scroll.
8500 * tui/tui-win.h (tui_scroll): Don't declare.
8501 * tui/tui-win.c (tui_win_info::forward_scroll)
8502 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8503 (tui_win_info::right_scroll): Rename and update.
8504 (tui_scroll_forward_command, tui_scroll_backward_command)
8505 (tui_scroll_left_command, tui_scroll_right_command): Update.
8506 (tui_scroll): Remove.
8507 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8508 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8509 from tui_vertical_source_scroll.
8510 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8511 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8512 from tui_vertical_disassem_scroll.
8513 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8514 do_scroll_horizontal>: New methods.
8515 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8516 Likewise.
8517 (struct tui_source_window_base): Add do_scroll_horizontal.
8518 (struct tui_source_window, struct tui_disasm_window): Add
8519 do_scroll_vertical.
8520 (struct tui_data_window, struct tui_cmd_window): Add
8521 do_scroll_horizontal and do_scroll_vertical.
8522 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8523
8524 2019-06-25 Tom Tromey <tom@tromey.com>
8525
8526 * tui/tui-data.h (struct tui_source_window_base): New struct.
8527 (struct tui_source_window): Derive from tui_source_window_base.
8528 (struct tui_disasm_window): New struct.
8529 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8530 from tui_source_window::clear_detail.
8531 (tui_source_window_base): Rename from tui_source_window.
8532 (~tui_source_window_base): Rename from ~tui_source_window.
8533 (tui_alloc_win_info): Create a tui_disasm_window.
8534
8535 2019-06-25 Tom Tromey <tom@tromey.com>
8536
8537 * tui/tui-data.h (struct tui_source_window)
8538 (struct tui_data_window): Declare destructors.
8539 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8540 destructors.
8541 (tui_win_info): Simplify.
8542
8543 2019-06-25 Tom Tromey <tom@tromey.com>
8544
8545 * tui/tui-winsource.c (tui_display_main)
8546 (tui_update_source_windows_with_addr)
8547 (tui_update_all_breakpoint_info): Update.
8548 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8549 (new_height_ok, parse_scrolling_args): Update.
8550 * tui/tui-stack.c (tui_show_frame_info): Update.
8551 * tui/tui-data.h (struct tui_list): Remove.
8552 (tui_source_windows): Return a reference to a std::vector.
8553 * tui/tui-data.c (source_windows): Now a std::vector.
8554 (tui_source_windows): Change return type.
8555 (tui_clear_source_windows): Rewrite.
8556 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8557 (tui_free_all_source_wins_content): Rewrite.
8558
8559 2019-06-25 Tom Tromey <tom@tromey.com>
8560
8561 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8562 (struct tui_data_window, struct tui_cmd_window): Declare
8563 clear_detail method.
8564 * tui/tui-data.c (tui_source_window::clear_detail)
8565 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8566 methods.
8567 (tui_clear_win_detail): Simplify.
8568
8569 2019-06-25 Tom Tromey <tom@tromey.com>
8570
8571 * tui/tui-layout.c (make_source_window, make_disasm_window)
8572 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8573 Return the new window.
8574 (show_source_disasm_command, show_data)
8575 (show_source_or_disasm_and_command): Update.
8576
8577 2019-06-25 Tom Tromey <tom@tromey.com>
8578
8579 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8580 parameter. Return the new window.
8581 (show_source_disasm_command): Update and remove NULL check.
8582 (show_source_or_disasm_and_command): Update.
8583
8584 2019-06-25 Tom Tromey <tom@tromey.com>
8585
8586 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8587
8588 2019-06-25 Tom Tromey <tom@tromey.com>
8589
8590 * tui/tui-data.h (struct tui_win_info): Make constructor
8591 protected. Make destructor virtual. Add initializers.
8592 (tui_source_window, tui_data_window, tui_cmd_window): New
8593 classes.
8594 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8595 constructor. Add "type" parameter.
8596 (tui_source_window, tui_data_window, tui_cmd_window): New
8597 constructors.
8598 (tui_alloc_win_info): Instantiate the appropriate subclass.
8599
8600 2019-06-25 Tom Tromey <tom@tromey.com>
8601
8602 * tui/tui-win.c (tui_resize_all): Use delete.
8603 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8604 destructor.
8605 (tui_free_window): Don't declare.
8606 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8607 Update.
8608
8609 2019-06-25 Tom Tromey <tom@tromey.com>
8610
8611 * tui/tui-data.h (struct tui_win_info): Add constructor.
8612 * tui/tui-data.c (tui_alloc_win_info): Use new.
8613 (tui_free_window): Use delete.
8614
8615 2019-06-22 Tom Tromey <tom@tromey.com>
8616
8617 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8618 declare.
8619 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8620
8621 2019-06-22 Tom Tromey <tom@tromey.com>
8622
8623 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8624 declare.
8625 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8626
8627 2019-06-22 Tom de Vries <tdevries@suse.de>
8628
8629 * dwarf2read.c (create_addrmap_from_aranges)
8630 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8631 instead of '%zu'.
8632
8633 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
8634
8635 * dwarf2read.h (dwarf2_section_info_def): Remove.
8636 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8637 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8638 std::vector<dwarf2_section_info>.
8639 (struct dwo_file) <~dwo_file>: Remove.
8640 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8641 types field.
8642 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8643 (dwarf2_read_debug_names): Likewise.
8644 (create_debug_types_hash_table): Change parameter type to
8645 array_view, adjust code accordingly.
8646 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8647 (partial_die_info::fixup): Likewise.
8648 (determine_prefix): Likewise.
8649 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8650
8651 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8652
8653 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8654 gdb_bfd_ref_ptr.
8655 <~dwo_file>: Remove call to gdb_bfd_unref.
8656 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8657 gdb_bfd_ref_ptr::get.
8658
8659 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8660
8661 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8662 type to htab_up.
8663 * dwarf2read.c (struct dwo_file): Initialize fields.
8664 <~dwo_file>: New.
8665 (free_dwo_file): Remove, move content to ~dwo_file.
8666 (struct dwo_file_deleter): Remove.
8667 (dwo_file_up>: Remove custom deleter.
8668 (free_dwo_files): Remove.
8669 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8670 dwo_files.
8671 (process_skeletonless_type_units): Call unique_ptr::get.
8672 (allocate_dwo_file_hash_table): Add deleter to created hash
8673 table. Change return type to htab_up.
8674 (lookup_dwo_file_slot): Don't memset dwo_file, call
8675 unique_ptr::get.
8676 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8677 (create_dwo_unit_in_dwp_v2): Likewise.
8678 (open_and_init_dwo_file): Likewise.
8679 (free_dwo_file_from_slot): Remove.
8680
8681 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8682
8683 * dwarf2read.h (struct dwarf2_section_info) <readin,
8684 is_virtual>: Change type to bool.
8685 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8686 true instead of 1.
8687
8688 2019-06-19 Tom Tromey <tom@tromey.com>
8689
8690 * tui/tui-data.h (tui_init_content_element): Don't declare.
8691
8692 2019-06-19 Tom Tromey <tom@tromey.com>
8693
8694 * tui/tui-data.h (tui_init_win_info): Don't declare.
8695
8696 2019-06-19 Tom de Vries <tdevries@suse.de>
8697
8698 * dwarf2read.h (abstract_to_concrete): Change type to
8699 std::unordered_map<sect_offset, std::vector<sect_offset>,
8700 gdb::hash_enum<sect_offset>>.
8701
8702 2019-06-19 Tom Tromey <tromey@adacore.com>
8703
8704 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8705 EVAL_AVOID_SIDE_EFFECTS specially.
8706
8707 2019-06-19 Tom Tromey <tromey@adacore.com>
8708
8709 * source-cache.c (highlighter): New global.
8710 (source_cache::get_source_lines): Create a highlighter on demand.
8711
8712 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8713
8714 * defs.h (deprecated_interactive_hook): Delete declaration.
8715 * interps.c (clear_interpreter_hooks): Remove use of
8716 deprecated_interactive_hook.
8717 * top.c (deprecated_interactive_hook): Delete definition.
8718 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8719
8720 2019-06-18 Tom de Vries <tdevries@suse.de>
8721
8722 PR gdb/24515
8723 * dwarf2read.h (abstract_to_concrete): Change type from
8724 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8725 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8726 * dwarf2read.c (read_variable): Update.
8727 (dwarf2_fetch_die_loc_sect_off): Update.
8728
8729 2019-06-17 Tom de Vries <tdevries@suse.de>
8730
8731 PR gdb/24617
8732 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8733 accessing parent[parent_len - 1].
8734
8735 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8736
8737 PR gdb/24364
8738 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8739 call dtrace_process_dof with NULL dof.
8740
8741 2019-06-16 Tom de Vries <tdevries@suse.de>
8742
8743 PR gdb/24445
8744 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8745
8746 2019-06-16 Tom Tromey <tom@tromey.com>
8747
8748 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8749 (make_all_visible): Use address of member.
8750
8751 2019-06-16 Tom Tromey <tom@tromey.com>
8752
8753 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8754 (tui_free_window, free_content, free_content_elements): Remove
8755 unnecessary cast.
8756 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8757 cast.
8758 * tui/tui-regs.c (tui_show_register_group)
8759 (tui_display_registers_from, tui_display_reg_element_at_line):
8760 Remove unnecessary cast.
8761
8762 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8763
8764 * linux-nat.c (normal_mask): Delete.
8765 (_initialize_linux_nat): Don't initialise normal_mask.
8766
8767 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8768
8769 PR gdb/24445
8770 * dwarf-index-write.h (write_psymtabs_to_index): Add
8771 dwz_basename parameter.
8772 * dwarf-index-write.c (write_gdbindex): Move file writing to
8773 write_gdbindex_1. Change return type void.
8774 (assert_file_size): Move up, remove filename parameter.
8775 (write_gdbindex_1): New function.
8776 (write_debug_names): Change return type to void, call
8777 assert_file_size.
8778 (struct index_wip_file): New struct.
8779 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8780 file logic to index_wip_file. Write index for dwz file if
8781 needed.
8782 (save_gdb_index_command): Pass basename of dwz file, if present.
8783 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8784 build-id of dwz file, if present.
8785 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8786 (dwarf2_get_dwz_file): Likewise.
8787 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8788 (dwarf2_get_dwz_file): Likewise.
8789
8790 2019-06-16 Tom Tromey <tom@tromey.com>
8791
8792 * coffread.c (process_coff_symbol): Use xstrdup.
8793 * value.c (create_internalvar): Use xstrdup.
8794
8795 2019-06-16 Tom Tromey <tom@tromey.com>
8796
8797 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8798 * breakpoint.c (stopin_command, stopat_command)
8799 (until_break_command, decode_location_default): Remove unnecessary
8800 cast.
8801 * utils.c (subset_compare): Remove unnecessary cast.
8802 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8803 cast.
8804 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8805 cast.
8806 * infcmd.c (path_command): Remove unnecessary cast.
8807 * coffread.c (decode_type): Remove unnecessary cast.
8808 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8809 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8810 * tui/tui-stack.c (tui_show_locator_content)
8811 (tui_show_frame_info): Remove unnecessary cast.
8812 * tui/tui-win.c (tui_scroll_forward_command)
8813 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8814 (parse_scrolling_args): Remove unnecessary cast.
8815 * tui/tui-data.c (init_win_info, tui_del_window)
8816 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8817 (free_content_elements): Remove unnecessary cast.
8818 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8819 unnecessary cast.
8820 * tui/tui-source.c (tui_set_source_content)
8821 (tui_vertical_source_scroll): Remove unnecessary cast.
8822 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8823 cast.
8824 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8825 * tui/tui-regs.c (tui_display_registers_from)
8826 (tui_display_register): Remove unnecessary cast.
8827 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8828 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8829 (make_visible): Remove unnecessary cast.
8830 * tui/tui-winsource.c (tui_erase_source_content)
8831 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8832 unnecessary cast.
8833 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8834 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8835 * stabsread.c (read_type, read_array_type, read_range_type):
8836 Remove unnecessary cast.
8837 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8838 (parse_symbol, parse_type, upgrade_type, parse_external)
8839 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8840 unnecessary cast.
8841 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8842
8843 2019-06-16 Tom Tromey <tom@tromey.com>
8844
8845 * tui/tui-data.c (tui_alloc_generic_win_info)
8846 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8847 checks.
8848
8849 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8850 Andrew Burgess <andrew.burgess@embecosm.com>
8851
8852 * f-typeprint.c (f_print_type): Don't return early for not
8853 associated or not allocated types.
8854 (f_type_print_varspec_suffix): Add print_rank parameter and print
8855 ranks of array types in case they dangling.
8856 (f_type_print_base): Add print_rank parameter.
8857
8858 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8859
8860 * NEWS: Mention new MI commands.
8861 * break-catch-throw.c (enum exception_event_kind): Move to
8862 breakpoint.h.
8863 (print_mention_exception_catchpoint): Output text as a single
8864 message.
8865 (catch_exception_command_1): Rename to...
8866 (catch_exception_event): ...this, make non-static, update header
8867 command, and change some parameter types.
8868 (catch_catch_command): Update for changes to
8869 catch_exception_command_1.
8870 (catch_throw_command): Likewise.
8871 (catch_rethrow_command): Likewise.
8872 * breakpoint.c (enum exception_event_kind): Delete.
8873 * breakpoint.h (enum exception_event_kind): Moved here from
8874 break-catch-throw.c.
8875 (catch_exception_event): Declare.
8876 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8877 (mi_cmd_catch_throw): New function.
8878 (mi_cmd_catch_rethrow): New function.
8879 (mi_cmd_catch_catch): New function.
8880 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8881 'catch-catch' entries.
8882 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8883 (mi_cmd_catch_rethrow): Declare.
8884 (mi_cmd_catch_catch): Declare.
8885
8886 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8887
8888 * annotate.c (annotate_source_line): Change return type to void,
8889 update implementation to match.
8890 * annotate.h (annotate_source_line): Change return type to void,
8891 update header comment.
8892 * stack.c (print_frame_info): Don't change what frame information
8893 is printed based on whether annotations are on or not.
8894
8895 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8896
8897 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8898 (annotate_source): Make static.
8899 (annotate_source_line): Moved from source.c and renamed from
8900 identify_source_line. Update the return type.
8901 * annotate.h (annotate_source): Delete declaration.
8902 (annotate_source_line): Declaration moved from source.h, and
8903 renamed from identify_source_line. Return type updated.
8904 * source.c (identify_source_line): Moved to annotate.c and renamed
8905 to annotate_source_line.
8906 (info_line_command): Remove check of annotation_level.
8907 * source.h (identify_source_line): Move declaration to annotate.h
8908 and rename to annotate_source_line.
8909 * stack.c: Add 'annotate.h' include.
8910 (print_frame_info): Remove check of annotation_level before
8911 calling annotate_source_line.
8912
8913 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8914
8915 * source-cache.c (source_cache::get_plain_source_lines): Use
8916 open_source_file_with_line_charpos instead of just
8917 open_source_file, remove call to find_source_lines.
8918 (source_cache::get_source_lines): Likewise.
8919 * source.c (find_source_lines): Make static.
8920 (get_filename_and_charpos): Renamed into...
8921 (open_source_file_with_line_charpos): ..this along with changes to
8922 return a scoped_fd, and some other minor clean ups.
8923 (identify_source_line): Use open_source_file_with_line_charpos.
8924 (search_command_helper): Use open_source_file_with_line_charpos
8925 instead of just open_source_file, remove call to
8926 find_source_lines.
8927 * source.h (open_source_file_with_line_charpos): Declare new
8928 function.
8929 (find_source_lines): Delete declaration.
8930
8931 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8932
8933 * source.c (get_filename_and_charpos): Remove fullname
8934 parameter.
8935 (identify_source_line): Update call to get_filename_and_charpos.
8936
8937 2019-06-14 Tom Tromey <tromey@adacore.com>
8938
8939 PR gdb/24502:
8940 * ui-style.h (skip_ansi_escape): Update comment.
8941 * ui-file.h (class no_terminal_escape_file): New class.
8942 * ui-file.c (no_terminal_escape_file::write)
8943 (no_terminal_escape_file::puts): New methods.
8944 * cli/cli-logging.c (handle_redirections): Use
8945 no_terminal_escape_file.
8946
8947 2019-06-14 Tom Tromey <tromey@adacore.com>
8948
8949 * NEWS: Move convenience variable news above Python news.
8950
8951 2019-06-14 Tom Tromey <tom@tromey.com>
8952
8953 * gnulib: Move directory to top-level.
8954 * configure.ac: Don't configure gnulib.
8955 * configure: Rebuild.
8956 * common/common-defs.h: Use new path to gnulib.
8957 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8958 (GNULIB_H): Remove.
8959 (INCGNU): Look in new gnulib location.
8960 (HFILES_NO_SRCDIR): Remove gnulib files.
8961 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8962 (generated_files): Remove GNULIB_H.
8963 ($(LIBGNU), all-lib): Remove targets.
8964 (distclean): Don't mention GNULIB_BUILDDIR.
8965 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8966
8967 2019-06-14 Tom Tromey <tromey@adacore.com>
8968
8969 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8970 Warn if symbol file does not provide any symbols.
8971
8972 2019-06-14 Tom Tromey <tromey@adacore.com>
8973
8974 * source.c (find_and_open_source): Respect basenames_may_differ.
8975
8976 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8977
8978 * annotate.c (annotate_breakpoints_invalid): Make use of
8979 scoped_restore_terminal_state.
8980 (annotate_frames_invalid): Likewise.
8981
8982 2019-06-14 Tom Tromey <tromey@adacore.com>
8983
8984 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8985 allow assignment to an internalvar.
8986
8987 2019-06-14 Tom Tromey <tromey@adacore.com>
8988
8989 * ada-lex.l: Allow "_" in attribute names.
8990
8991 2019-06-14 Tom Tromey <tromey@adacore.com>
8992
8993 PR gdb/24653:
8994 * regcache.c (registers_changed): Don't call alloca.
8995 * top.c (execute_command): Don't call alloca.
8996
8997 2019-06-13 Pedro Alves <palves@redhat.com>
8998
8999 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9000 'expression'. When parsing an expression, error out if there's
9001 junk after "unlimited".
9002 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9003 (do_set_command): Adjust calls to is_unlimited_literal.
9004
9005 2019-06-13 Pedro Alves <palves@redhat.com>
9006
9007 * compile/compile.c (make_compile_options_def_group): Add braces
9008 around array_view initializer.
9009 * thread.c (make_thread_apply_all_options_def_group)
9010 (make_thread_apply_all_options_def_group): Likewise.
9011
9012 2019-06-13 Pedro Alves <palves@redhat.com>
9013
9014 * NEWS (New commands): Mention "maint test-options
9015 require-delimiter", "maint test-options unknown-is-error", "maint
9016 test-options unknown-is-operand" and "maint show
9017 test-options-completion-result".
9018 (New command options, command completion): New section.
9019 (Completion improvements): New section.
9020 Mention that you can abbreviate "unlimited".
9021
9022 2019-06-13 Pedro Alves <palves@redhat.com>
9023
9024 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9025 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9026 * unittests/cli-utils-selftests.c (test_parse_flags)
9027 (test_parse_flags_qcs): Delete.
9028 (test_cli_utils): Don't call deleted functions.
9029
9030 2019-06-13 Pedro Alves <palves@redhat.com>
9031
9032 * thread.c: Include "cli/cli-option.h".
9033 (tp_array_compar_ascending): Global.
9034 (tp_array_compar): Delete function.
9035 (tp_array_compar_ascending, tp_array_compar_descending): New
9036 functions.
9037 (ascending_option_def, qcs_flag_option_def)
9038 (thr_qcs_flags_option_defs)
9039 (make_thread_apply_all_options_def_group)
9040 (make_thread_apply_options_def_group): New.
9041 (thread_apply_all_command): Use gdb::option::process_options.
9042 (thread_apply_command_completer)
9043 (thread_apply_all_command_completer): New.
9044 (thread_apply_command): Use gdb::option::process_options.
9045 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9046 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9047 to generate help text of "thread apply". Adjust "taas"'s help.
9048 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9049 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9050
9051 2019-06-13 Pedro Alves <palves@redhat.com>
9052
9053 * thread.c (thread_apply_command): Check for invalid TID with
9054 isdigit instead of !isalpha.
9055
9056 2019-06-13 Pedro Alves <palves@redhat.com>
9057
9058 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9059 (validate_flags_qcs): New.
9060 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9061 (validate_flags_qcs): Declare.
9062 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9063 (make_frame_apply_options_def_group): New.
9064 (frame_apply_command_count): Process options with
9065 gdb::option::process_options.
9066 (frame_apply_completer): New.
9067 (frame_apply_level_completer, frame_apply_all_completer)
9068 (frame_apply_completer): New.
9069 (_initialize_stack): Update help of "frame apply", "frame apply
9070 level", "frame apply all" and "faas" to mention supported options
9071 and install command completers.
9072 * stack.h (frame_apply_all_completer): Declare.
9073 * thread.c: Include "stack.h".
9074 (tfaas_command): Add "--".
9075 (_initialize_thread): Update help "tfaas" to mention supported
9076 options and install command completer.
9077
9078 2019-06-13 Pedro Alves <palves@redhat.com>
9079
9080 * completer.c (complete_nested_command_line): New.
9081 (gdb_completion_word_break_characters_throw): Add assertion.
9082 * completer.h (complete_nested_command_line): Declare.
9083
9084 2019-06-13 Pedro Alves <palves@redhat.com>
9085
9086 * stack.c (parse_backtrace_qualifiers): New.
9087 (backtrace_command): Use it.
9088 (backtrace_command_completer): Complete on qualifiers.
9089
9090 2019-06-13 Pedro Alves <palves@redhat.com>
9091
9092 * frame.c: Include "cli/cli-option.h.
9093 (user_set_backtrace_options): New.
9094 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9095 Delete.
9096 (get_prev_frame): Adjust.
9097 (boolean_option_def, uinteger_option_def)
9098 (set_backtrace_option_defs): New.
9099 (_initialize_frame): Adjust and use
9100 gdb::option::add_setshow_cmds_for_options to install "set
9101 backtrace past-main" and "set backtrace past-entry".
9102 * frame.h: Include "cli/cli-option.h".
9103 (struct frame_print_options): Forward declare.
9104 (print_frame_arguments_all, print_frame_arguments_scalars)
9105 (print_frame_arguments_none): Declare.
9106 (print_entry_values): Delete declaration.
9107 (struct frame_print_options, user_frame_print_options): New.
9108 (struct set_backtrace_options): New.
9109 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9110 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9111 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9112 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9113 (list_args_or_locals): Add frame_print_options parameter.
9114 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9115 * python/py-framefilter.c (enumerate_args): Pass down
9116 USER_FRAME_PRINT_OPTIONS.
9117 * stack.c: Include "cli/cli-option.h".
9118 (print_frame_arguments_all, print_frame_arguments_scalars)
9119 (print_frame_arguments_none): Declare.
9120 (print_raw_frame_arguments, print_entry_values): Delete.
9121 (user_frame_print_options): New.
9122 (boolean_option_def, enum_option_def, frame_print_option_defs):
9123 New.
9124 (struct backtrace_cmd_options): New.
9125 (bt_flag_option_def): New.
9126 (backtrace_command_option_defs): New.
9127 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9128 (print_frame_arg, read_frame_arg, print_frame_args)
9129 (print_frame_info, print_frame): Add frame_print_options parameter
9130 and use it.
9131 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9132 (backtrace_command_1): Add frame_print_options and
9133 backtrace_cmd_options parameters and use them.
9134 (make_backtrace_options_def_group): New.
9135 (backtrace_command): Process command options with
9136 gdb::option::process_options.
9137 (backtrace_command_completer): New.
9138 (_initialize_stack): Extend "backtrace"'s help to mention
9139 supported options. Install completer for "backtrace".
9140 Install some settings commands with add_setshow_cmds_for_options.
9141
9142 2019-06-13 Pedro Alves <palves@redhat.com>
9143
9144 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9145 and that "set/show print raw frame-arguments" are now deprecated.
9146
9147 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9148 command.
9149 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9150 * stack.c (_initialize_stack): Install "set/show print
9151 raw-frame-arguments", and deprecate "set/show print raw
9152 frame-arguments".
9153 * valprint.c (_initialize_valprint): Deprecate "set/show print
9154 raw".
9155
9156 2019-06-13 Pedro Alves <palves@redhat.com>
9157
9158 * compile/compile.c (struct compile_options): New.
9159 (compile_flag_option_def, compile_command_option_defs)
9160 (make_compile_options_def_group): New.
9161 (compile_file_command): Handle options with
9162 gdb::option::process_options.
9163 (compile_file_command_completer): New function.
9164 (compile_code_command): Handle options with
9165 gdb::option::process_options.
9166 (compile_code_command_completer): New function.
9167 (_initialize_compiler): Install completers for "compile code" and
9168 "compile file". Mention available options in "compile code" and
9169 "compile code"'s help.
9170 * completer.c (advance_to_completion_word): New, factored out from
9171 ...
9172 (advance_to_expression_complete_word_point): ... this.
9173 (advance_to_filename_complete_word_point): New.
9174 * completer.h (advance_to_filename_complete_word_point): New
9175 declaration.
9176
9177 2019-06-13 Pedro Alves <palves@redhat.com>
9178
9179 * compile/compile.c: Include "cli/cli-option.h".
9180 (compile_print_value): Scope data pointer is now a
9181 value_print_options pointer; adjust.
9182 (compile_print_command): Process options. Scope data pointer is
9183 now a value_print_options pointer; adjust.
9184 (_initialize_compile): Update "compile print"'s help to include
9185 supported options. Install a completer for "compile print".
9186 * cp-valprint.c (show_vtblprint, show_objectprint)
9187 (show_static_field_print): Delete.
9188 (_initialize_cp_valprint): Don't install "set print
9189 static-members", "set print vtbl", "set print object" here.
9190 * printcmd.c: Include "cli/cli-option.h" and
9191 "common/gdb_optional.h".
9192 (print_command_parse_format): Rework to fill in a
9193 value_print_options instead of a format_data.
9194 (print_value): Change parameter type from format_data pointer to
9195 value_print_options reference. Adjust.
9196 (print_command_1): Process options. Adjust to pass down a
9197 value_print_options.
9198 (print_command_completer): New.
9199 (_initialize_printcmd): Install print_command_completer as
9200 handle_brkchars completer for the "print" command. Update
9201 "print"'s help to include supported options.
9202 * valprint.c: Include "cli/cli-option.h".
9203 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9204 here from cp-valprint.c.
9205 (boolean_option_def, uinteger_option_def)
9206 (value_print_option_defs, make_value_print_options_def_group):
9207 New. Use gdb::option::add_setshow_cmds_for_options to install
9208 "set print elements", "set print null-stop", "set print repeats",
9209 "set print pretty", "set print union", "set print array", "set
9210 print address", "set print symbol", "set print array-indexes".
9211 * valprint.h: Include <string> and "cli/cli-option.h".
9212 (make_value_print_options_def_group): Declare.
9213 (print_value): Change parameter type from format_data pointer to
9214 value_print_options reference.
9215 (print_command_completer): Declare.
9216
9217 2019-06-13 Pedro Alves <palves@redhat.com>
9218
9219 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9220 (COMMON_SFILES): Add maint-test-settings.c.
9221 * cli/cli-decode.c (boolean_enums): New global, factored out from
9222 ...
9223 (add_setshow_boolean_cmd): ... here.
9224 * cli/cli-decode.h (boolean_enums): Declare.
9225 * cli/cli-option.c: New file.
9226 * cli/cli-option.h: New file.
9227 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9228 factored out from ...
9229 (parse_cli_boolean_value(const char *)): ... this.
9230 (is_unlimited_literal): Change parameter type to pointer to
9231 pointer. Adjust and advance ARG pointer.
9232 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9233 (parse_cli_var_enum): New, factored out from ...
9234 (do_set_command): ... this. Adjust.
9235 * cli/cli-setshow.h (parse_cli_boolean_value)
9236 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9237 (parse_cli_var_enum): Declare.
9238 * cli/cli-utils.c: Include "cli/cli-option.h".
9239 (get_ulongest): New.
9240 * cli/cli-utils.h (get_ulongest): Declare.
9241 (check_for_argument): New overloads.
9242 * maint-test-options.c: New file.
9243
9244 2019-06-13 Pedro Alves <palves@redhat.com>
9245
9246 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9247 parse a range if "-" is at the end of the string.
9248
9249 2019-06-13 Pedro Alves <palves@redhat.com>
9250
9251 * cli/cli-setshow.c (parse_auto_binary_operation)
9252 (parse_cli_boolean_value): Don't allow "o".
9253
9254 2019-06-13 Pedro Alves <palves@redhat.com>
9255
9256 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9257 * NEWS: Mention maint test-settings KIND.
9258 * maint-test-settings.c: New file.
9259
9260 2019-06-13 Pedro Alves <palves@redhat.com>
9261
9262 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9263 completer.
9264 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9265 "set" completers.
9266
9267 2019-06-13 Pedro Alves <palves@redhat.com>
9268
9269 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9270 after item.
9271
9272 2019-06-13 Pedro Alves <palves@redhat.com>
9273
9274 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9275
9276 2019-06-13 Pedro Alves <palves@redhat.com>
9277
9278 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9279 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9280 call.
9281 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9282 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9283 calls.
9284 (check_for_argument): Skip spaces after argument.
9285
9286 2019-06-13 Pedro Alves <palves@redhat.com>
9287
9288 * thread.c (thread_apply_command): Adjust TID parsing.
9289 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9290 detected before end of string.
9291 (tid_is_in_list): Error out if LIST is invalid.
9292
9293 2019-06-13 Pedro Alves <palves@redhat.com>
9294
9295 * completer.c (complete_line_internal_1): Rewind completion word
9296 point.
9297 (completion_tracker::advance_custom_word_point_by): Change
9298 parameter type to int.
9299 * completer.h (completion_tracker::advance_custom_word_point_by):
9300 Likewise.
9301
9302 2019-06-13 Pedro Alves <palves@redhat.com>
9303
9304 * completer.c (advance_to_completion_word): Handle delimiters.
9305
9306 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9307
9308 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9309
9310 2019-06-11 Tom Tromey <tom@tromey.com>
9311
9312 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9313 (xmalloc_failed): Move to alloc.c.
9314 * alloc.c: New file.
9315 * Makefile.in (COMMON_SFILES): Add alloc.c.
9316
9317 2019-06-11 Tom Tromey <tom@tromey.com>
9318
9319 * nat/linux-waitpid.c: Don't include server.h.
9320 (linux_debug): Remove.
9321 (my_waitpid): Update.
9322
9323 2019-06-11 Tom Tromey <tromey@adacore.com>
9324
9325 * infcall.c (_initialize_infcall): Remove trailing newline from
9326 help.
9327 * user-regs.c (_initialize_user_regs): Remove trailing newline
9328 from help.
9329 * typeprint.c (_initialize_typeprint): Remove trailing newline
9330 from help.
9331 * reverse.c (_initialize_reverse): Remove trailing newlines from
9332 help.
9333 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9334 from help.
9335 * language.c (add_set_language_command): Remove trailing newline
9336 from help.
9337 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9338 help.
9339 * disasm.c (_initialize_disasm): Remove trailing newline from
9340 help.
9341 * top.c (init_main): Remove trailing newline from help.
9342 * interps.c (_initialize_interpreter): Remove trailing newline
9343 from help.
9344 * btrace.c (_initialize_btrace): Remove trailing newlines from
9345 help.
9346 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9347 from help.
9348 * python/python.c (_initialize_python): Remove trailing newline
9349 from help.
9350 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9351 help.
9352 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9353 from help. Reformat some text.
9354 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9355 from help.
9356 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9357 newline from help.
9358
9359 2019-06-11 Tom Tromey <tromey@adacore.com>
9360
9361 * darwin-nat.c (darwin_decode_exception_message)
9362 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9363
9364 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9365
9366 * valops.c (value_slice): Check for not allocated or not
9367 associated values.
9368
9369 2019-06-10 Tom de Vries <tdevries@suse.de>
9370
9371 PR gdb/24618
9372 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9373 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9374 invalid.
9375
9376 2019-06-10 Tom de Vries <tdevries@suse.de>
9377
9378 PR gdb/24611
9379 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9380 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9381
9382 2019-06-10 Tom de Vries <tdevries@suse.de>
9383
9384 PR symtab/24545
9385 * symtab.c (struct demangled_name_entry): Add language field.
9386 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9387 static minimal symbol". Set and use language field.
9388
9389 2019-06-10 Tom Tromey <tromey@adacore.com>
9390
9391 * ada-lang.c (_initialize_ada_language): Update help text.
9392
9393 2019-06-10 Tom Tromey <tromey@adacore.com>
9394
9395 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9396 with a newline.
9397 * guile/guile.c (handle_boot_error): Don't end warning with a
9398 newline.
9399 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9400 warning with a newline.
9401 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9402 newline.
9403 (s12z_frame_cache): Likewise.
9404 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9405 a newline.
9406 * solib-svr4.c (disable_probes_interface): Don't end warning with
9407 a newline.
9408 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9409 newline.
9410 * python/python.c (do_finish_initialization): Don't end warning
9411 with a newline.
9412
9413 2019-06-10 Tom Tromey <tom@tromey.com>
9414
9415 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9416 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9417 gdbpy_enter.
9418
9419 2019-06-10 Tom Tromey <tromey@adacore.com>
9420
9421 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9422 data.
9423 (elf_new_init): Don't call stabsread_new_init.
9424 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9425 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9426 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9427
9428 2019-06-10 Tom de Vries <tdevries@suse.de>
9429
9430 PR symtab/16264
9431 PR symtab/24517
9432 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9433
9434 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9435
9436 * source.c (find_and_open_source): Also rewrite relative file
9437 names.
9438
9439 2019-04-26 Amos Bird <amosbird@gmail.com>
9440
9441 * annotate.c (annotate_thread_exited): Add "thread-exited"
9442 annotation.
9443
9444 2019-06-06 Tom Tromey <tromey@adacore.com>
9445
9446 * maint.h (class scoped_command_stats): Use
9447 DISABLE_COPY_AND_ASSIGN.
9448 <print_time>: New method.
9449 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9450 print_time.
9451 (scoped_command_stats::print_time): New method.
9452
9453 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9454
9455 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9456 instructions of lengths 6 or 8 bytes.
9457
9458 2019-06-04 Pedro Alves <palves@redhat.com>
9459
9460 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9461
9462 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9463 * breakpoint.c (condition_completer): Likewise.
9464 * cli/cli-dump.c (scan_expression): Likewise.
9465 * common/filestuff.c (mkdir_recursive): Likewise.
9466 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9467 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9468 (gdb_abspath): Likewise.
9469 * compile/compile-cplus-types.c
9470 (compile_cplus_instance::decl_name): Likewise.
9471 * completer.c (complete_explicit_location):
9472 (signal_completer, reg_or_group_completer_1): Likewise.
9473 * cp-support.c (cp_remove_params_if_any): Likewise.
9474 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9475 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9476 * infcmd.c (strip_bg_char): Likewise.
9477 * linespec.c (copy_token_string): Likewise.
9478 * mi/mi-main.c (output_cores): Likewise.
9479 * psymtab.c (psymtab_search_name):
9480 * symfile.c (test_set_ext_lang_command): Likewise.
9481 * target.c (target_fileio_read_stralloc): Likewise.
9482 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9483 * value.c (complete_internalvar): Likewise.
9484
9485 2019-06-04 Christian Biesinger <cbiesinger@google.com>
9486
9487 Add objfile property to gdb.Type.
9488 * NEWS: Mention Python API addition.
9489 * python/py-type.c (typy_get_objfile): New method.
9490
9491 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9492
9493 * NEWS: Mention the new set|show style [title|highlight].
9494 Mention changes to "show style", "help" and "apropos".
9495
9496 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9497
9498 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9499 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9500 instead of print_help_for_command.
9501 (print_doc_of_command): New function.
9502 (help_list): Add 'apropos -v word' suggestion.
9503 (print_help_for_command): Style the command name using title style.
9504 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9505 (_initialize_cli_cmds): Describe -v in apropos_command help.
9506
9507 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9508
9509 * cli/cli-style.h (cli_style_option): Add name in constructor,
9510 add m_name class member, add constructor with intensity,
9511 add name class function.
9512 (cli_style_option::add_setshow_commands): Remove name argument.
9513 (highlight_style, title_style): New styles.
9514 * cli/cli-style.c (do_show): New function that shows a style
9515 characteristic styling the style name with itself.
9516 (set_style_name): New function.
9517 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9518 Update all callers according to the changes in cli/cli-style.h.
9519 * utils.h (fputs_highlighted): New function.
9520 * utils.c (fputs_highlighted): Likewise.
9521
9522 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9523
9524 * NEWS: Mention new pipe command and new convenience variables.
9525
9526 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9527
9528 * cli/cli-cmds.c (pipe_command): New function.
9529 (_initialize_cli_cmds): Call add_com for pipe_command.
9530 Define | as an alias for pipe.
9531 (exit_status_set_internal_vars): New function.
9532 (shell_escape): Call exit_status_set_internal_vars.
9533 cli/cli-decode.c (find_command_name_length): Recognize | as
9534 a single character command.
9535
9536 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9537
9538 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9539 top.c (execute_command_to_ui_file): New function, mostly a copy
9540 of execute_command_to_string.
9541 (execute_command_to_string): Implement by calling
9542 execute_command_to_ui_file.
9543
9544 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9545
9546 * top.h (saved_command_line): Remove declaration.
9547 * top.c (previous_saved_command_line, previous_repeat_arguments):
9548 New variables.
9549 (saved_command_line): Make static, define together with other
9550 'repeat variables'.
9551 (dont_repeat): Clear repeat_arguments.
9552 (repeat_previous, get_saved_command_line, save_command_line):
9553 New functions.
9554 (gdb_init): Initialize saved_command_line
9555 and previous_saved_command_line.
9556 * main.c (captured_main_1): Remove saved_command_line initialization.
9557 * event-top.c (handle_line_of_input): Update to use
9558 the new 'repeat' related functions instead of direct access to
9559 saved_command_line.
9560 * command.h (repeat_previous, get_saved_command_line,
9561 save_command_line): New declarations.
9562 (dont_repeat): Add comment.
9563
9564 2019-05-30 Tom Tromey <tromey@adacore.com>
9565
9566 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9567 Fix comment.
9568 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9569
9570 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9571
9572 PR cli/24587
9573 * completer.c (complete): Initialize variable word.
9574
9575 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9576
9577 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9578 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9579 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9580 'body' is NULL to the outter 'if', protecting the '!is_define'
9581 situation as well.
9582
9583 2019-05-29 Tom Tromey <tromey@adacore.com>
9584
9585 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9586 (dwarf_unknown): New function.
9587 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9588 (dwarf_type_encoding_name): Use dwarf_unknown.
9589
9590 2019-05-29 Tom Tromey <tromey@adacore.com>
9591
9592 PR c++/20020:
9593 * cp-valprint.c (cp_print_value_fields): Call
9594 cp_print_static_field inside "try".
9595
9596 2019-05-29 Tom Tromey <tromey@adacore.com>
9597
9598 * inflow.c (struct terminal_info): Add default operator=.
9599 * configure: Rebuild.
9600 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9601 -Wdeprecated-copy-dtor, -Wredundant-move.
9602
9603 2019-05-29 Tom Tromey <tromey@adacore.com>
9604
9605 * NEWS: Add entry.
9606 * infcmd.c (print_return_value_1): Handle finish_print
9607 option.
9608 (show_print_finish): New function.
9609 (_initialize_infcmd): Add "set/show print finish" commands.
9610 * valprint.c (user_print_options): Initialize new member.
9611 * valprint.h (struct value_print_options) <finish_print>: New
9612 member.
9613
9614 2019-05-28 Tom Tromey <tromey@adacore.com>
9615
9616 * ada-lang.c (ada_remove_Xbn_suffix)
9617 (find_old_style_renaming_symbol)
9618 (parse_old_style_renaming): Remove.
9619 (ada_find_renaming_symbol): Don't call
9620 find_old_style_renaming_symbol.
9621 (ada_is_renaming_symbol): Rename from
9622 ada_find_renaming_symbol. Remove "block" parameter. Return
9623 bool. Now static.
9624 (ada_read_var_value): Update and simplify.
9625 * ada-exp.y (write_var_or_type): Remove old code.
9626
9627 2019-05-28 Alan Hayward <alan.hayward@arm.com>
9628
9629 PR gdb/25010
9630 * event-top.c: Remove include comment.
9631 * inflow.c (class scoped_ignore_sigttou): Move from here...
9632 * inflow.h (class scoped_ignore_sigttou): ...to here.
9633 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9634 * top.c: Remove include comment.
9635
9636 2019-05-27 Tom Tromey <tom@tromey.com>
9637
9638 * NEWS: Fix typo.
9639
9640 2019-05-22 Tom Tromey <tromey@adacore.com>
9641
9642 * target.c (target_follow_exec): Constify parameter.
9643 * target-delegates.c: Rebuild.
9644 * remote.c (remote_target::follow_exec): Constify parameter.
9645 * infrun.c (follow_exec): Constify parameter.
9646 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9647 (target_follow_exec): Likewise.
9648
9649 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9650
9651 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9652 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9653
9654 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9655
9656 * NEWS: Add debugredirect and testsuite sections.
9657
9658 2019-05-22 Simon Cook <simon.cook@embecosm.com>
9659
9660 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9661 target descriptions using exclusively floating point register name
9662 aliases.
9663
9664 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9665
9666 PR gdb/18644:
9667 * f-lang.c (build_fortran_types): Handle the case where
9668 gdbarch_floatformat_for_type returns a nullptr.
9669
9670 2019-05-21 Tom de Vries <tdevries@suse.de>
9671
9672 PR cli/24587
9673 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9674
9675 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9676
9677 PR gdb/18644:
9678 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9679 16-byte floats.
9680 * i386-tdep.c (i386_floatformat_for_type): Use
9681 floatformats_ia64_quad for the 16-byte floating point component
9682 within a fortran 32-byte complex number.
9683
9684 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9685
9686 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9687 delete default constructor.
9688 (find_partial_die): Update to return const struct.
9689 (partial_die_parent_scope): Move variable declaration into scope
9690 of its use and change its type to auto.
9691 (guess_partial_die_structure_name): Likewise.
9692 (partial_die_info::fixup): Likewise.
9693
9694 2019-05-17 Tom Tromey <tromey@adacore.com>
9695
9696 * source.c (find_and_open_source): Remove cast.
9697
9698 2019-05-17 Tom Tromey <tromey@adacore.com>
9699
9700 * annotate.c (annotate_source): Make "filename" const.
9701 * annotate.h (annotate_source): Use const.
9702
9703 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9704
9705 * disasm.c (set_disassembler_options): Send errors to stderr.
9706
9707 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9708
9709 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9710 (cli_interp_base::set_logging): Check debug_redirect.
9711 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9712 * cli/cli-logging.c (debug_redirect): Add static variable.
9713 (pop_output_files): Add default param.
9714 (handle_redirections): Print debug setting.
9715 (show_logging_command): Likewise.
9716 (_initialize_cli_logging): Add debugredirect command.
9717 * interps.c (current_interp_set_logging): Add debug_redirect
9718 parameter.
9719 * interps.h (set_logging): Add debug_redirect parameter.
9720 (current_interp_set_logging): Likewise.
9721 * mi/mi-common.h: Likewise.
9722 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9723
9724 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9725 Tom Tromey <tromey@adacore.com>
9726
9727 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9728 directly.
9729 * cli/cli-interp.h (make_logging_output): Remove declaration.
9730 * cli/cli-logging.c (make_logging_output): Remove function.
9731 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9732 directly.
9733 * ui-file.c (tee_file::tee_file): Remove bools.
9734 (tee_file::~tee_file): Remove deletes.
9735 * ui-file.h (tee_file): Remove bools.
9736
9737 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9738
9739 * mi/mi-cmds.h (mi_cmd_complete): New function.
9740 * mi/mi-main.c (mi_cmd_complete): Likewise.
9741 * mi/mi-cmds.c: Define new MI command -complete.
9742 * NEWS: Mention new -complete command.
9743
9744 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9745
9746 * completer.h (complete): New function.
9747 * completer.c (complete): Likewise.
9748 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9749 function defined in completer.h.
9750
9751 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9752
9753 * MAINTAINERS (Write After Approval): Add myself.
9754
9755 2019-05-17 Tom de Vries <tdevries@suse.de>
9756
9757 PR gdb/24094
9758 * dwarf2read.c (struct cu_partial_die_info): New struct.
9759 (find_partial_die): Return cu_partial_die_info.
9760 (partial_die_parent_scope, guess_partial_die_structure_name)
9761 (partial_die_info::fixup): Handle new return type of find_partial_die.
9762
9763 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9764
9765 PR breakpoints/24541
9766 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9767 "std::string", simplifying the algorithm.
9768
9769 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9770
9771 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9772 (stap_static_probe_ops::get_probes): Likewise.
9773
9774 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9775
9776 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9777 '-')" and "else if".
9778 (stap_parse_single_operand): Join checks for
9779 "gdbarch_stap_parse_special_token_p" and
9780 "gdbarch_stap_parse_special_token" in the same "if" statement.
9781 Invert check when verifying for operation on register
9782 displacement.
9783
9784 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9785
9786 * stap-probe.c (stap_get_opcode): Update comment.
9787 (stap_get_expected_argument_type): Likewise.
9788 (handle_stap_probe): Likewise.
9789
9790 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9791
9792 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9793 return type to 'bool'. Adjust comment. Use 'bool' when
9794 appropriate.
9795 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9796 * stap-probe.c (stap_parse_argument_1): Likewise.
9797 (stap_is_operator): Likewise.
9798 (stap_is_generic_prefix): Likewise.
9799 (stap_is_register_prefix): Likewise.
9800 (stap_is_register_indirection_prefix): Likewise.
9801 (stap_is_integer_prefix): Likewise.
9802 (stap_generic_check_suffix): Likewise.
9803 (stap_check_integer_suffix): Likewise.
9804 (stap_check_register_suffix): Likewise.
9805 (stap_check_register_indirection_suffix): Likewise.
9806 (stap_parse_register_operand): Likewise.
9807 (stap_parse_single_operand): Likewise.
9808 (stap_parse_argument_1): Likewise.
9809 (stap_probe::get_argument_count): Likewise.
9810 (stap_is_operator): Likewise.
9811
9812 2019-05-16 Tom Tromey <tromey@adacore.com>
9813
9814 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9815 keyword to foreach.
9816
9817 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
9818
9819 * linux-thread-db.c (try_thread_db_load_1): Change return type
9820 to bool.
9821 (try_thread_db_load): Likewise.
9822 (try_thread_db_load_from_pdir_1): Likewise.
9823 (try_thread_db_load_from_pdir): Likewise.
9824 (try_thread_db_load_from_sdir): Likewise.
9825 (try_thread_db_load_from_dir): Likewise.
9826 (thread_db_load_search): Likewise.
9827 (has_libpthread): Likewise.
9828 (thread_db_load): Likewise.
9829
9830 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9831
9832 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9833 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9834 NULL, and complain/return if that's the case.
9835
9836 2019-05-15 John Darrington <john@darrington.wattle.id.au>
9837
9838 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9839 (advance, posn, abstract_read_memory): New functions.
9840 [struct mem_read_abstraction]: New struct.
9841 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9842
9843 2019-05-14 Tom Tromey <tromey@adacore.com>
9844
9845 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9846 value is not lval_memory.
9847
9848 2019-05-14 Tom Tromey <tromey@adacore.com>
9849
9850 * solib.c (info_sharedlibrary_command): Style the file name.
9851
9852 2019-05-14 Alan Hayward <alan.hayward@arm.com>
9853
9854 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9855 (aarch64_vnv_type): Likewise.
9856 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9857 * common/tdesc.c: Likewise.
9858 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9859 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9860 * features/aarch64-fpu.xml: Add ieee half view.
9861 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9862 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9863 * gdbtypes.h (struct builtin_type): Likewise.
9864 (struct objfile_type): Likewise.
9865
9866 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
9867
9868 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9869 typo.
9870 * location.h (string_to_event_location): Likewise.
9871
9872 2019-05-11 Joel Brobecker <brobecker@adacore.com>
9873
9874 GDB 8.3 released.
9875
9876 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9877
9878 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9879 New variable declaration.
9880 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9881 New variable.
9882 (print_one_breakpoint): Use ui_out::test_flags and new global
9883 variable to compute use_fixed_output.
9884 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9885 Remove.
9886 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9887 (mi_multi_location_breakpoint_output_fixed): Remove.
9888 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9889 new variable.
9890 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9891 fix_multi_location_breakpoint_output flag if version >= 3.
9892 * ui-out.h (enum ui_out_flag)
9893 <fix_multi_location_breakpoint_output>: New enumerator.
9894
9895 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9896
9897 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9898
9899 2019-05-10 Tom Tromey <tromey@adacore.com>
9900
9901 * ada-lang.c (catch_ada_completer): New function.
9902 (_initialize_ada_language): Use it.
9903
9904 2019-05-10 Tom Tromey <tromey@adacore.com>
9905
9906 * thread.c (print_thread_info): Make "requested_threads" const.
9907 * gdbthread.h (print_thread_info): Make "requested_threads"
9908 const.
9909 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9910 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9911
9912 2019-05-08 Tom Tromey <tom@tromey.com>
9913
9914 * gdbtypes.c (objfile_type_data): Change type.
9915 (objfile_type, _initialize_gdbtypes): Update.
9916
9917 2019-05-08 Tom Tromey <tom@tromey.com>
9918
9919 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9920 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9921 (_initialize_dwarf2_frame): Update.
9922
9923 2019-05-08 Tom Tromey <tom@tromey.com>
9924
9925 * objc-lang.c (objc_objfile_data): Change type.
9926 (find_methods): Update.
9927 (_initialize_objc_lang): Remove.
9928
9929 2019-05-08 Tom Tromey <tom@tromey.com>
9930
9931 * stabsread.c (rs6000_builtin_type_data): Change type.
9932 (rs6000_builtin_type, _initialize_stabsread): Update.
9933
9934 2019-05-08 Tom Tromey <tom@tromey.com>
9935
9936 * mips-tdep.c (mips_pdr_data): Remove.
9937 (_initialize_mips_tdep): Update.
9938
9939 2019-05-08 Tom Tromey <tom@tromey.com>
9940
9941 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9942 (hppa_init_objfile_priv_data, read_unwind_info)
9943 (find_unwind_entry, _initialize_hppa_tdep): Update.
9944
9945 2019-05-08 Tom Tromey <tom@tromey.com>
9946
9947 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9948 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9949 on obstack.
9950 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9951
9952 2019-05-08 Tom Tromey <tom@tromey.com>
9953
9954 * mdebugread.c (basic_type_data): Change type.
9955 (basic_type, _initialize_mdebugread): Update.
9956
9957 2019-05-08 Tom Tromey <tom@tromey.com>
9958
9959 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9960
9961 2019-05-08 Tom Tromey <tom@tromey.com>
9962
9963 * nto-tdep.c (nto_inferior_data_reg): Change type.
9964 (nto_inferior_data): Update.
9965 (nto_inferior_data_cleanup, nto_new_inferior_data)
9966 (_initialize_nto_tdep): Remove.
9967 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9968
9969 2019-05-08 Tom Tromey <tom@tromey.com>
9970
9971 * ada-lang.c (struct ada_inferior_data): Add initializers.
9972 (ada_inferior_data): Change type.
9973 (ada_inferior_data_cleanup): Remove.
9974 (get_ada_inferior_data, ada_inferior_exit)
9975 (struct ada_pspace_data): Add initializers, destructor.
9976 (ada_pspace_data_handle): Change type.
9977 (get_ada_pspace_data): Update.
9978 (ada_pspace_data_cleanup): Remove.
9979
9980 2019-05-08 Tom Tromey <tom@tromey.com>
9981
9982 * coffread.c (struct coff_symfile_info): Add initializers.
9983 (coff_objfile_data_key): Move lower. Change type.
9984 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9985 Update.
9986 (coff_free_info): Remove.
9987
9988 2019-05-08 Tom Tromey <tom@tromey.com>
9989
9990 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9991 (fbsd_pspace_data_handle): Move lower. Change type.
9992 (get_fbsd_pspace_data): Update.
9993 (fbsd_pspace_data_cleanup): Remove.
9994 (_initialize_fbsd_tdep): Update.
9995
9996 2019-05-08 Tom Tromey <tom@tromey.com>
9997
9998 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9999 (get_ada_tasks_pspace_data): Update.
10000 (ada_tasks_pspace_data_cleanup): Remove.
10001 (_initialize_tasks): Update.
10002 (ada_tasks_inferior_data_handle): Change type.
10003 (get_ada_tasks_inferior_data): Update.
10004 (ada_tasks_inferior_data_cleanup): Remove.
10005 (struct ada_tasks_pspace_data): Add initializers.
10006
10007 2019-05-08 Tom Tromey <tom@tromey.com>
10008
10009 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10010 * symfile-debug.c (debug_sym_get_probes): Change type.
10011 * stap-probe.c (handle_stap_probe):
10012 (stap_static_probe_ops::get_probes): Change type.
10013 * probe.h (class static_probe_ops) <get_probes>: Change type.
10014 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10015 (parse_probes_in_pspace): Update.
10016 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10017 Update.
10018 (any_static_probe_ops::get_probes): Change type.
10019 * elfread.c (elfread_data): New typedef.
10020 (probe_key): Change type.
10021 (elf_get_probes): Likewise. Update.
10022 (probe_key_free): Remove.
10023 (_initialize_elfread): Update.
10024 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10025 Change type.
10026 (dtrace_process_dof_probe, dtrace_process_dof)
10027 (dtrace_static_probe_ops::get_probe): Change type.
10028
10029 2019-05-08 Tom Tromey <tom@tromey.com>
10030
10031 * xcoffread.c (struct xcoff_symfile_info): Rename from
10032 coff_symfile_info. Add initializers.
10033 (xcoff_objfile_data_key): Move lower. Change type.
10034 (XCOFF_DATA): Rewrite.
10035 (xcoff_free_info): Remove.
10036 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10037 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10038 (xcoff_initial_scan): Update.
10039
10040 2019-05-08 Tom Tromey <tom@tromey.com>
10041
10042 * solib-svr4.c (struct svr4_info): Add initializers and
10043 destructor.
10044 <probes_table>: Now an htab_up.
10045 (solib_svr4_pspace_data): Change type.
10046 (free_probes_table): Simplify.
10047 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10048 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10049 (probes_table_remove_objfile_probes, register_solib_event_probe)
10050 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10051 (_initialize_svr4_solib): Update.
10052
10053 2019-05-08 Tom Tromey <tom@tromey.com>
10054
10055 * remote.c (remote_pspace_data): Change type.
10056 (remote_pspace_data_cleanup): Remove.
10057 (get_remote_exec_file, set_pspace_remote_exec_file)
10058 (_initialize_remote): Update.
10059
10060 2019-05-08 Tom Tromey <tom@tromey.com>
10061
10062 * breakpoint.c (breakpoint_objfile_key): Change type.
10063 (get_breakpoint_objfile_data): Update.
10064 (free_breakpoint_objfile_data): Remove.
10065 (_initialize_breakpoint): Update.
10066
10067 2019-05-08 Tom Tromey <tom@tromey.com>
10068
10069 * linux-tdep.c (struct linux_info): Add initializers.
10070 (linux_inferior_data): Move. Change type.
10071 (invalidate_linux_cache_inf): Update.
10072 (linux_inferior_data_cleanup): Remove.
10073 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10074
10075 2019-05-08 Tom Tromey <tom@tromey.com>
10076
10077 * auxv.c (auxv_inferior_data): Move. Change type.
10078 (auxv_inferior_data_cleanup): Remove.
10079 (invalidate_auxv_cache_inf): Rewrite.
10080 (get_auxv_inferior_data, _initialize_auxv): Update.
10081
10082 2019-05-08 Tom Tromey <tom@tromey.com>
10083
10084 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10085 (symfile_debug_objfile_data_key): Change type.
10086 (symfile_debug_installed, debug_qf_has_symbols)
10087 (debug_qf_find_last_source_symtab)
10088 (debug_qf_forget_cached_source_info)
10089 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10090 (debug_qf_print_stats, debug_qf_dump)
10091 (debug_qf_expand_symtabs_for_function)
10092 (debug_qf_expand_all_symtabs)
10093 (debug_qf_expand_symtabs_with_fullname)
10094 (debug_qf_map_matching_symbols)
10095 (debug_qf_expand_symtabs_matching)
10096 (debug_qf_find_pc_sect_compunit_symtab)
10097 (debug_qf_map_symbol_filenames)
10098 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10099 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10100 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10101 (debug_sym_read_linetable, debug_sym_relocate): Update.
10102 (symfile_debug_free_objfile): Remove.
10103 (install_symfile_debug_logging, _initialize_symfile_debug):
10104 Update.
10105
10106 2019-05-08 Tom Tromey <tom@tromey.com>
10107
10108 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10109 allocate_on_obstack.
10110 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10111 (get_dwarf2_per_objfile): Update.
10112 (set_dwarf2_per_objfile): Remove.
10113 (dwarf2_has_info, dwarf2_get_section_info): Update.
10114 (dwarf2_free_objfile): Remove.
10115 (_initialize_dwarf2_read): Update.
10116
10117 2019-05-08 Tom Tromey <tom@tromey.com>
10118
10119 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10120 initializers.
10121 <unsupported_script_warning_printed,
10122 script_not_found_warning_printed>: Now bool.
10123 (auto_load_pspace_data): Change type.
10124 (~auto_load_pspace_info): Rename from
10125 auto_load_pspace_data_cleanup.
10126 (get_auto_load_pspace_data, init_loaded_scripts_info)
10127 (clear_section_scripts, maybe_print_unsupported_script_warning)
10128 (maybe_print_script_not_found_warning, _initialize_auto_load):
10129 Update.
10130
10131 2019-05-08 Tom Tromey <tom@tromey.com>
10132
10133 * objfiles.c (objfile_pspace_info): Add destructor and
10134 initializers.
10135 (objfiles_pspace_data): Change type.
10136 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10137 (get_objfile_pspace_data): Update.
10138 (objfiles_bfd_data): Change type.
10139 (get_objfile_bfd_data): Update.
10140 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10141
10142 2019-05-08 Tom Tromey <tom@tromey.com>
10143
10144 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10145 Change type.
10146 (get_catch_syscall_inferior_data): Update.
10147 (catch_syscall_inferior_data_cleanup): Remove.
10148 (_initialize_break_catch_syscall): Update.
10149
10150 2019-05-08 Tom Tromey <tom@tromey.com>
10151
10152 * inflow.c (struct terminal_info): Add destructor and
10153 initializers.
10154 (inflow_inferior_data): Change type.
10155 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10156 (get_inflow_inferior_data, inflow_inferior_exit)
10157 (swap_terminal_info, _initialize_inflow): Update.
10158
10159 2019-05-08 Tom Tromey <tom@tromey.com>
10160
10161 * target-dcache.c (target_dcache_cleanup): Remove.
10162 (target_dcache_aspace_key): Change type.
10163 (target_dcache_init_p, target_dcache_invalidate)
10164 (target_dcache_get, target_dcache_get_or_init)
10165 (_initialize_target_dcache): Update.
10166 * dcache.h (struct dcache_deleter): New.
10167
10168 2019-05-08 Tom Tromey <tom@tromey.com>
10169
10170 * symtab.c (struct symbol_cache): Add destructor and
10171 initializers.
10172 (symbol_cache_key): Move. Change type.
10173 (make_symbol_cache, free_symbol_cache): Remove.
10174 (get_symbol_cache): Update.
10175 (symbol_cache_cleanup): Remove.
10176 (ALL_PSPACES, symbol_cache_flush)
10177 (maintenance_print_symbol_cache)
10178 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10179 Update.
10180
10181 2019-05-08 Tom Tromey <tom@tromey.com>
10182
10183 * symtab.c (struct main_info): Add destructor and initializers.
10184 (main_progspace_key): Move. Change type.
10185 (get_main_info): Update.
10186 (main_info_cleanup): Remove.
10187 (_initialize_symtab): Update.
10188
10189 2019-05-08 Tom Tromey <tom@tromey.com>
10190
10191 * registry.h (DECLARE_REGISTRY): Define the _key class.
10192
10193 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10194
10195 * NEWS: Merge two 'New commands' sections.
10196
10197 2019-05-08 Joel Brobecker <brobecker@adacore.com>
10198
10199 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10200 parameter and use Ada language definition instead.
10201 (ada_val_print_ptr): Remove unused language parameter.
10202 (ada_val_print_num): Remove language parameter and use Ada language
10203 definition instead.
10204 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10205 parameter.
10206 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10207 parameter and use Ada language definition instead.
10208 (ada_val_print_1): Update all ada_val_print_xxx calls.
10209 Remove language parameter.
10210 (ada_val_print): Update ada_val_print_1 call.
10211
10212 2019-05-08 Tom Tromey <tromey@adacore.com>
10213
10214 * remote.c (remote_hw_watchpoint_limit)
10215 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10216 Now static.
10217
10218 2019-05-08 Tom Tromey <tromey@adacore.com>
10219
10220 * maint.c (_initialize_maint_cmds): Move initialization code to
10221 remote.c.
10222 (watchdog, show_watchdog): Move to remote.c.
10223 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10224 "watchdog" static.
10225 (_initialize_remote): Move initialization code from maint.c.
10226 * defs.h (watchdog): Don't declare.
10227
10228 2019-05-08 Tom Tromey <tromey@adacore.com>
10229
10230 * tui/tui-interp.c: Include main.h.
10231 * interps.c: Include main.h.
10232 * main.h (interpreter_p): Declare.
10233 * defs.h (interpreter_p): Don't declare.
10234
10235 2019-05-08 Tom Tromey <tromey@adacore.com>
10236
10237 * dwarf2loc.c: Include dwarf2read.h.
10238 * defs.h (read_unsigned_leb128): Don't declare.
10239 * dwarf2read.h (read_unsigned_leb128): Declare.
10240
10241 2019-05-08 Tom Tromey <tromey@adacore.com>
10242
10243 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10244 method.
10245
10246 2019-05-08 Tom Tromey <tromey@adacore.com>
10247
10248 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10249 when no wrap column is set.
10250
10251 2019-05-08 Tom Tromey <tromey@adacore.com>
10252
10253 * c-lang.c (c_get_string): Handle non-C-style arrays.
10254
10255 2019-05-08 Tom Tromey <tromey@adacore.com>
10256
10257 * typeprint.c (print_offset_data::update): Print the bit offset,
10258 not the number of bits remaining.
10259
10260 2019-05-08 Tom Tromey <tromey@adacore.com>
10261
10262 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10263 padding at end of comment.
10264
10265 2019-05-08 Tom Tromey <tromey@adacore.com>
10266
10267 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10268 Compare main types.
10269
10270 2019-05-06 Tom Tromey <tom@tromey.com>
10271
10272 * common/scoped_mmap.c: Include common-defs.h.
10273 * common/scoped_mmap.h: Don't include config.h.
10274
10275 2019-05-04 Tom Tromey <tom@tromey.com>
10276
10277 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10278 (struct aarch64_call_info): Add initializers.
10279 <si>: Now a std::vector.
10280 (pass_on_stack, aarch64_push_dummy_call): Update.
10281
10282 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
10283 Tom Tromey <tom@tromey.com>
10284
10285 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10286 (ppc_threads): Now a std::vector. Now static.
10287 (hwdebug_find_thread_points_by_tid)
10288 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10289 Update.
10290
10291 2019-05-04 Tom Tromey <tom@tromey.com>
10292
10293 * arc-tdep.c (arc_tdesc_init): Return bool.
10294
10295 2019-05-04 Tom Tromey <tom@tromey.com>
10296
10297 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10298 Use gdb_assert_not_reached.
10299
10300 2019-05-04 Tom Tromey <tom@tromey.com>
10301
10302 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10303 "false".
10304
10305 2019-05-04 Tom Tromey <tom@tromey.com>
10306
10307 * arc-tdep.c (arc_tdesc_init): Use bool.
10308
10309 2019-05-04 Tom Tromey <tom@tromey.com>
10310
10311 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10312
10313 2019-05-04 Tom Tromey <tom@tromey.com>
10314
10315 * cli/cli-cmds.c (valid_command_p): Return bool.
10316
10317 2019-05-04 Tom Tromey <tom@tromey.com>
10318
10319 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10320 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10321
10322 2019-05-04 Raul Tambre <raul@tambre.ee>
10323
10324 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10325 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10326 operator for comparison.
10327
10328 2019-05-04 Tom Tromey <tom@tromey.com>
10329
10330 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10331 (lookup_partial_symbol, print_partial_symbols)
10332 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10333 (psymbol_compare): Update.
10334 (add_psymbol_to_bcache): Clear the entire psymbol.
10335 (maintenance_check_psymtabs): Update.
10336 * psympriv.h (struct partial_symbol): Don't derive from
10337 general_symbol_info.
10338 <obj_section, unrelocated_address, address,
10339 set_unrelocated_address>: Update.
10340 <ginfo>: New member.
10341 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10342 (debug_names::write_psymbols): Update.
10343
10344 2019-05-04 Tom de Vries <tdevries@suse.de>
10345
10346 * contrib/cc-with-tweaks.sh: Support -n arg.
10347
10348 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10349
10350 * corelow.c (core_target::detach): Ensure frame cache and
10351 register caches are cleared.
10352 inferior.c (exit_inferior_1): Likewise.
10353
10354 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10355 Tom Tromey <tom@tromey.com>
10356
10357 * dictionary.c (collate_pending_symbols_by_language): Remove
10358 "struct" from foreach.
10359 * symtab.c (lookup_global_symbol_from_objfile)
10360 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10361 foreach.
10362 * ser-tcp.c (net_open): Remove "struct" from foreach.
10363 * objfiles.c (objfile_relocate, objfile_rebase)
10364 (objfile_has_symbols): Remove "struct" from foreach.
10365 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10366 from foreach.
10367 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10368 foreach.
10369 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10370 "struct" from foreach.
10371 * ada-lang.c (create_excep_cond_exprs)
10372 (ada_exception_catchpoint_cond_string): Remove "struct" from
10373 foreach.
10374
10375 2019-05-03 Tom Tromey <tromey@adacore.com>
10376
10377 * ada-exp.y (convert_char_literal): Check suffix of each
10378 enumerator.
10379
10380 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10381
10382 PR ada/21406:
10383 * ada-exp.y (yywrap): Don't define.
10384 * ada-lex.l (%option): Add noyywrap
10385 (yywrap): Remove.
10386
10387 2019-05-03 Eli Zaretskii <eliz@gnu.org>
10388
10389 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10390 _WIN32_WINNT to the XP level, unless already defined to a higher
10391 level.
10392
10393 * unittests/parse-connection-spec-selftests.c:
10394 * ser-tcp.c:
10395 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10396 override.
10397
10398 * symfile.c (find_separate_debug_file): Remove colon from the
10399 drive spec of DOS/Windows file names of the target, so that the
10400 file name produced from DEBUGDIR and the target's directory will
10401 be valid on DOS/Windows systems.
10402
10403 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10404
10405 * rust-lang.c (val_print_struct): Handle printing structures
10406 containing strings.
10407
10408 2019-05-02 Tom Tromey <tromey@adacore.com>
10409
10410 * valarith.c (_initialize_valarith): Remove.
10411
10412 2019-05-01 Tom Tromey <tromey@adacore.com>
10413
10414 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10415 bitfields.
10416
10417 2019-05-01 Tom Tromey <tromey@adacore.com>
10418
10419 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10420 for big-endian copies.
10421
10422 2019-04-30 Ali Tamur <tamur@google.com>
10423 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10424 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10425 (read_3_bytes): New function.
10426
10427 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10428
10429 * windows-nat.c (main_thread_id): Delete.
10430 (handle_output_debug_string): Replace main_thread_id by
10431 current_event.dwThreadId.
10432 (fake_create_process): Likewise.
10433 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10434 Do not set main_thread_id.
10435 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10436 current_event.dwThreadId.
10437 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10438
10439 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10440
10441 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10442 Use current_event.dwThreadId instead of main_thread_id.
10443
10444 2019-04-30 Tom Tromey <tromey@adacore.com>
10445
10446 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10447 (create_excep_cond_exprs): Iterate over program spaces.
10448 (ada_exception_catchpoint_cond_string): Examine all minimal
10449 symbols for exception types.
10450
10451 2019-04-30 Tom Tromey <tromey@adacore.com>
10452
10453 PR c++/24470:
10454 * dwarf2read.c (process_structure_scope): Handle case where type
10455 has template parameters but no symbol was created.
10456
10457 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10458 Chris January <chris.january@arm.com>
10459
10460 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10461 qualifier.
10462 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10463
10464 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10465
10466 * f-typeprint.c (f_print_type): Update rules for printing
10467 whitespace.
10468 (f_type_print_varspec_suffix): Likewise.
10469
10470 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10471 Chris January <chris.january@arm.com>
10472
10473 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10474 function arguments.
10475
10476 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10477
10478 * f-lang.c (build_fortran_types): Change name of void type to
10479 lower case.
10480 * f-typeprint.c (f_type_print_base): Print the name of the void
10481 type, rather than a fixed string.
10482 * f-valprint.c (f_decorations): Use lower case void string.
10483
10484 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10485 Chris January <chris.january@arm.com>
10486
10487 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10488 types for Fortran.
10489
10490 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10491 Chris January <chris.january@arm.com>
10492 David Lecomber <david.lecomber@arm.com>
10493
10494 * f-exp.y (BINOP_INTRINSIC): New token.
10495 (exp): New parser rule handling BINOP_INTRINSIC.
10496 (f77_keywords): Add new builtin procedures.
10497 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10498 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10499 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10500 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10501 (print_unop_subexp_f): New function.
10502 (print_binop_subexp_f): New function.
10503 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10504 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10505 (dump_subexp_body_f): Likewise.
10506 (operator_check_f): Likewise.
10507 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10508 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10509
10510 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10511
10512 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10513 UNOP_KIND.
10514 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10515 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10516 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10517 (operator_length_f): New fuction.
10518 (print_subexp_f): New function.
10519 (op_name_f): New function.
10520 (dump_subexp_body_f): New function.
10521 (operator_check_f): New function.
10522 (exp_descriptor_f): Replace standard expression handling functions
10523 with new functions.
10524 * gdb/fortran-operator.def: New file.
10525 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10526 * gdb/std-operator.def: Remove UNOP_KIND.
10527
10528 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10529
10530 * std-operator.def: Remove unbalanced, stray double quote
10531 character.
10532
10533 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10534 Chris January <chris.january@arm.com>
10535 Daniel Everett <daniel.everett@arm.com>
10536 Nick Forrington <nick.forrington@arm.com>
10537 Richard Bunt <richard.bunt@arm.com>
10538
10539 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10540 of depth when printing anonymous structs or unions.
10541 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10542 Don't print either the top-level value, or the children if the
10543 max-depth is exceeded.
10544 (ppscm_print_children): When printing the key of a map, allow one
10545 extra level of depth.
10546 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10547 print either the top-level value, or the children if the max-depth
10548 is exceeded.
10549 (print_children): When printing the key of a map, allow one extra
10550 level of depth.
10551 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10552 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10553 (user_print_options): Initialise max_depth field.
10554 (val_print_scalar_or_string_type_p): New function.
10555 (val_print): Check to see if the max depth has been reached.
10556 (val_print_check_max_depth): Define new function.
10557 (show_print_max_depth): New function.
10558 (_initialize_valprint): Add 'print max-depth' option.
10559 * valprint.h (struct value_print_options) <max_depth>: New field.
10560 (val_print_check_max_depth): Declare new function.
10561 * NEWS: Document new feature.
10562
10563 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10564
10565 * ada-lang.c (ada_language_defn): Initialise new field.
10566 * c-lang.c (c_is_string_type_p): New function.
10567 (c_language_defn): Initialise new field.
10568 (cplus_language_defn): Initialise new field.
10569 (asm_language_defn): Initialise new field.
10570 (minimal_language_defn): Initialise new field.
10571 * c-lang.h (c_is_string_type_p): Declare new function.
10572 * d-lang.c (d_language_defn): Initialise new field.
10573 * f-lang.c (f_is_string_type_p): New function.
10574 (f_language_defn): Initialise new field.
10575 * go-lang.c (go_is_string_type_p): New function.
10576 (go_language_defn): Initialise new field.
10577 * language.c (default_is_string_type_p): New function.
10578 (unknown_language_defn): Initialise new field.
10579 (auto_language_defn): Initialise new field.
10580 * language.h (struct language_defn) <la_is_string_type_p>: New
10581 member variable.
10582 (default_is_string_type_p): Declare new function.
10583 * m2-lang.c (m2_language_defn): Initialise new field.
10584 * objc-lang.c (objc_language_defn): Initialise new field.
10585 * opencl-lang.c (opencl_language_defn): Initialise new field.
10586 * p-lang.c (pascal_is_string_type_p): New function.
10587 (pascal_language_defn): Initialise new field.
10588 * rust-lang.c (rust_is_string_type_p): New function.
10589 (rust_language_defn): Initialise new field.
10590
10591 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10592
10593 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10594 New field.
10595 * ada-lang.c (ada_language_defn): Initialise new field.
10596 * c-lang.c (c_language_defn): Likewise.
10597 (cplus_language_defn): Likewise.
10598 (asm_language_defn): Likewise.
10599 (minimal_language_defn): Likewise.
10600 * d-lang.c (d_language_defn): Likewise.
10601 * f-lang.c (f_language_defn): Likewise.
10602 * go-lang.c (go_language_defn): Likewise.
10603 * language.c (unknown_language_defn): Likewise.
10604 (auto_language_defn): Likewise.
10605 * m2-lang.c (m2_language_defn): Likewise.
10606 * objc-lang.c (objc_language_defn): Likewise.
10607 * opencl-lang.c (opencl_language_defn): Likewise.
10608 * p-lang.c (pascal_language_defn): Likewise.
10609 * rust-lang.c (rust_language_defn): Likewise.
10610
10611 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10612
10613 * ada-lang.c (ada_is_character_type): Change return type to bool.
10614 (ada_is_string_type): Likewise.
10615 * ada-lang.h (ada_is_character_type): Update declaration
10616 (ada_is_string_type): Likewise.
10617
10618 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10619
10620 Support style in 'frame|thread apply'
10621
10622 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10623 * record.c (record_start, record_stop): Update callers of
10624 execute_command_to_string with false.
10625 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10626 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10627 methods.
10628 (class string_file): New constructor with term_out parameter.
10629 Override methods term_out and can_emit_style_escape. New member
10630 term_out.
10631 (class stdio_file): Override can_emit_style_escape.
10632 (class tee_file): Override term_out and can_emit_style_escape.
10633 * utils.h (can_emit_style_escape): Remove.
10634 * utils.c (can_emit_style_escape): Likewise.
10635 Update all callers of can_emit_style_escape (SOMESTREAM) to
10636 SOMESTREAM->can_emit_style_escape.
10637 * source-cache.c (source_cache::get_source_lines): Likewise.
10638 * stack.c (frame_apply_command_count): Call execute_command_to_string
10639 passing the term_out characteristic of the current gdb_stdout.
10640 * thread.c (thr_try_catch_cmd): Likewise.
10641 * top.c (execute_command_to_string): pass term_out parameter
10642 to construct the string_file for the command output.
10643 * ui-file.c (term_cli_styling): New function (most code moved
10644 from utils.c can_emit_style_escape).
10645 (string_file::string_file, string_file::can_emit_style_escape,
10646 stdio_file::can_emit_style_escape, tee_file::term_out,
10647 tee_file::can_emit_style_escape): New functions.
10648
10649 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10650
10651 * NEWS: Mention the new set|show may-call-functions.
10652 * infcall.c (may_call_functions_p): New variable.
10653 (show_may_call_functions_p): New function.
10654 (call_function_by_hand_dummy): Throws an error if not
10655 may-call-functions.
10656 (_initialize_infcall): Call add_setshow_boolean_cmd for
10657 may-call-functions.
10658
10659 2019-04-25 Keith Seitz <keiths@redhat.com>
10660
10661 PR c++/24367
10662 * cp-support.c (inspect_type): Don't attempt substitutions
10663 of symbol with the same name.
10664
10665 2019-04-25 Tom Tromey <tromey@adacore.com>
10666
10667 PR gdb/24475:
10668 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10669 static.
10670
10671 2019-04-25 Tom Tromey <tromey@adacore.com>
10672
10673 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10674 rvalue reference.
10675 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10676 (gdb_xml_parser::parse): Use std::move.
10677 * python/python-internal.h (gdbpy_convert_exception): Take a const
10678 reference.
10679 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10680 std::move.
10681 * python/py-utils.c (gdbpy_convert_exception): Take a const
10682 reference.
10683 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10684 Use std::move.
10685 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10686 Use std::move.
10687 * mi/mi-main.c (mi_print_exception): Take a const reference.
10688 * main.c (handle_command_errors): Take a const reference.
10689 * linespec.c (parse_linespec): Use std::move.
10690 * infcall.c (run_inferior_call): Use std::move.
10691 (call_function_by_hand_dummy): Use std::move.
10692 * exec.c (try_open_exec_file): Use std::move.
10693 * exceptions.h (exception_print, exception_fprintf)
10694 (exception_print_same): Update.
10695 * exceptions.c (print_exception, exception_print)
10696 (exception_fprintf, exception_print_same): Change parameters to
10697 const reference.
10698 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10699 * common/new-op.c: Use std::move.
10700 * common/common-exceptions.h (struct gdb_exception): Add move
10701 constructor.
10702 (struct gdb_exception_error, struct gdb_exception_quit, struct
10703 gdb_quit_bad_alloc): Change constructor to move constructor.
10704 (throw_exception): Change parameter to rvalue reference.
10705 * common/common-exceptions.c (throw_exception): Take rvalue
10706 reference.
10707 * cli/cli-interp.c (safe_execute_command): Use std::move.
10708 * breakpoint.c (insert_bp_location, location_to_sals): Use
10709 std::move.
10710
10711 2019-04-25 Tom Tromey <tromey@adacore.com>
10712
10713 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10714 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10715 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10716 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10717 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10718 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10719 guile/scm-value.c: Use unpack.
10720 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10721 gdbscm_gdb_exception.
10722 (gdbscm_throw_gdb_exception): Likewise.
10723 (struct gdbscm_gdb_exception): New.
10724 (unpack): New function.
10725 (gdbscm_wrap): Use unpack.
10726
10727 2019-04-25 Tom Tromey <tromey@adacore.com>
10728
10729 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10730 (gdb_rl_callback_handler): Use std::move.
10731 * common/common-exceptions.h (struct gdb_exception): Add move
10732 assignment operator.
10733 (throw_exception_sjlj): Change "exception" to const reference.
10734 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10735 (throw_exception_sjlj): Change "exception" to const reference.
10736
10737 2019-04-25 Tom Tromey <tromey@adacore.com>
10738
10739 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10740 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10741 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10742 Update.
10743 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10744 Update.
10745 * mi/mi-interp.c (mi_interp::exec): Update.
10746 * linespec.c (parse_linespec): Update.
10747 * infcall.c (run_inferior_call): Update.
10748 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10749 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10750 (gdbscm_lookup_global_symbol): Update.
10751 * guile/scm-param.c (gdbscm_parameter_value): Update.
10752 * guile/scm-frame.c (gdbscm_frame_read_register)
10753 (gdbscm_frame_read_var): Update.
10754 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10755 * exec.c (try_open_exec_file): Update.
10756 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10757 (gdb_rl_callback_handler): Update.
10758 * common/common-exceptions.h (exception_none): Don't declare.
10759 * common/common-exceptions.c (exception_none): Don't define.
10760 (struct catcher) <exception>: Update.
10761 * cli/cli-interp.c (safe_execute_command): Update.
10762 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10763
10764 2019-04-25 Ali Tamur <tamur@google.com>
10765
10766 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10767 (read_attribute_value): Likewise.
10768 (dwarf2_read_addr_index): Update comment.
10769 (read_str_index): Add DW_FORM_strx.
10770 (dwarf2_string_attr): Likewise.
10771 (dwarf2_const_value_attr): Likewise.
10772 (dump_die_shallow): Likewise.
10773 (dwarf2_fetch_constant_bytes): Likewise.
10774 (skip_form_bytes): Likewise.
10775 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10776
10777 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10778
10779 PR corefiles/11608
10780 PR corefiles/18187
10781 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10782 OFFSET. Verify if current mapping contains an ELF header.
10783 (linux_find_memory_regions_full): Adjust call to
10784 dump_mapping_p.
10785
10786 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10787 Kang Li <kanglictf@gmail.com>
10788
10789 PR gdb/21600
10790
10791 * dwarf2-frame.c (read_initial_length): Be consistent about using
10792 unsigned representation of length.
10793 (decode_frame_entry_1): Likewise. Check for wraparound of
10794 end pointer as well as buffer overflow.
10795
10796 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10797
10798 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10799 "vq".
10800
10801 2019-04-24 Tom Tromey <tromey@adacore.com>
10802
10803 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10804
10805 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10806
10807 * s12z-tdep.c (s12z_unwind_pc): Delete.
10808 (s12z_unwind_sp): Delete.
10809 (s12z_gdbarch_init): Don't register deleted functions with
10810 gdbarch.
10811
10812 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10813
10814 * rl78-tdep.c (rl78_unwind_sp): Delete.
10815 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10816
10817 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10818
10819 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10820 (xstormy16_unwind_pc): Delete.
10821 (xstormy16_dummy_id): Delete.
10822 (xstormy16_gdbarch_init): Don't register deleted functions with
10823 gdbarch.
10824
10825 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10826
10827 * vax-tdep.c (vax_unwind_pc): Delete.
10828 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10829
10830 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10831
10832 * v850-tdep.c (v850_unwind_sp): Delete.
10833 (v850_unwind_pc): Delete.
10834 (v850_dummy_id): Delete.
10835 (v850_gdbarch_init): Don't register deleted functions with
10836 gdbarch.
10837
10838 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10839
10840 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10841 (tilegx_unwind_pc): Delete.
10842 (tilegx_unwind_dummy_id): Delete.
10843 (tilegx_gdbarch_init): Don't register deleted functions with
10844 gdbarch.
10845
10846 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10847
10848 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10849 (tic6x_dummy_id): Delete.
10850 (tic6x_gdbarch_init): Don't register deleted functions with
10851 gdbarch.
10852
10853 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10854
10855 * sparc-tdep.c (sparc_unwind_pc): Delete.
10856 (sparc32_gdbarch_init): Don't register deleted function with
10857 gdbarch.
10858
10859 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10860
10861 * sh-tdep.c (sh_unwind_sp): Delete.
10862 (sh_unwind_pc): Delete.
10863 (sh_dummy_id): Delete.
10864 (sh_gdbarch_init): Don't register deleted functions with
10865 gdbarch.
10866
10867 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10868
10869 * score-tdep.c (score_unwind_sp): Delete.
10870 (score_unwind_pc): Delete.
10871 (score_dummy_id): Delete.
10872 (score_gdbarch_init): Don't register deleted functions with
10873 gdbarch.
10874
10875 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10876
10877 * rx-tdep.c (rx_unwind_pc): Delete.
10878 (rx_unwind_sp): Delete.
10879 (rx_dummy_id): Delete.
10880 (rx_gdbarch_init): Don't register deleted functions with
10881 gdbarch. Update comment.
10882
10883 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10884
10885 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10886 (rs6000_dummy_id): Delete.
10887 (rs6000_gdbarch_init): Don't register deleted functions with
10888 gdbarch.
10889
10890 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10891
10892 * or1k-tdep.c (or1k_dummy_id): Delete.
10893 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10894
10895 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10896
10897 * nios2-tdep.c (nios2_dummy_id): Delete.
10898 (nios2_unwind_sp): Delete.
10899 (nios2_gdbarch_init): Don't register deleted functions with
10900 gdbarch.
10901
10902 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10903
10904 * nds32-tdep.c (nds32_dummy_id): Delete.
10905 (nds32_unwind_pc): Delete.
10906 (nds32_unwind_sp): Delete.
10907 (nds32_gdbarch_init): Don't register deleted functions with
10908 gdbarch.
10909
10910 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10911
10912 * msp430-tdep.c (msp430_unwind_pc): Delete.
10913 (msp430_unwind_sp): Delete.
10914 (msp430_dummy_id): Delete.
10915 (msp430_gdbarch_init): Don't register deleted functions with
10916 gdbarch.
10917
10918 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10919
10920 * moxie-tdep.c (moxie_unwind_sp): Delete.
10921 (moxie_unwind_pc): Delete.
10922 (moxie_dummy_id): Delete.
10923 (moxie_gdbarch_init): Don't register deleted functions with
10924 gdbarch.
10925
10926 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10927
10928 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10929 (mn10300_unwind_pc): Delete.
10930 (mn10300_unwind_sp): Delete.
10931 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10932 mn10300_unwind_sp.
10933 (mn10300_frame_unwind_init): Don't register deleted functions with
10934 gdbarch.
10935
10936 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10937
10938 * mep-tdep.c (mep_unwind_pc): Delete.
10939 (mep_unwind_sp): Delete.
10940 (mep_dummy_id): Delete.
10941 (mep_gdbarch_init): Don't register deleted functions with
10942 gdbarch.
10943
10944 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10945
10946 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10947 (m68hc11_unwind_sp): Delete.
10948 (m68hc11_gdbarch_init): Don't register deleted functions with
10949 gdbarch.
10950
10951 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10952
10953 * m32r-tdep.c (m32r_unwind_sp): Delete.
10954 (m32r_unwind_pc): Delete.
10955 (m32r_dummy_id): Delete.
10956 (m32r_gdbarch_init): Don't register deleted functions with
10957 gdbarch.
10958
10959 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10960
10961 * m32c-tdep.c (m32c_unwind_pc): Delete.
10962 (m32c_unwind_sp): Delete.
10963 (m32c_dummy_id): Delete.
10964 (m32c_gdbarch_init): Don't register deleted functions with
10965 gdbarch.
10966
10967 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10968
10969 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10970 (lm32_unwind_pc): Delete.
10971 (lm32_dummy_id): Delete.
10972 (lm32_gdbarch_init): Don't register deleted functions with
10973 gdbarch.
10974
10975 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10976
10977 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10978 (iq2000_unwind_pc): Delete.
10979 (iq2000_dummy_id): Delete.
10980 (iq2000_gdbarch_init): Don't register deleted functions with
10981 gdbarch.
10982
10983 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10984
10985 * nds32-tdep.c (nds32_type_align): Delete.
10986 (nds32_push_dummy_call): Use type_align instead.
10987
10988 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10989
10990 * arm-tdep.c (arm_type_align): Only handle vector override case.
10991 (arm_push_dummy_call): Use type_align.
10992 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10993
10994 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10995
10996 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10997 case.
10998 (pass_on_stack): Use type_align.
10999 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11000 function.
11001
11002 2019-04-23 Tom Tromey <tromey@adacore.com>
11003
11004 * dwarf2read.c (line_header::file_name_at): Remove unused
11005 overload.
11006
11007 2019-04-23 Tom de Vries <tdevries@suse.de>
11008
11009 PR gdb/24438
11010 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11011 invocation.
11012
11013
11014 2019-03-27 Ali Tamur <tamur@google.com>
11015
11016 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11017 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11018 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11019 (dwarf_expr_context::get_addr_index): Likewise
11020 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11021 (symbol_needs_eval_context::get_addr_index): Likewise
11022 (disassemble_dwarf_expression): Add DW_OP_addrx
11023 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11024 (read_cutu_die_from_dwo): Update comment
11025 (skip_one_die): Add DW_FORM_addrx
11026 (read_attribute_value): Likewise
11027 (var_decode_location): Add DW_OP_addrx
11028 (dwarf2_const_value_attr): Add DW_FORM_addrx
11029 (dump_die_shallow): Likewise
11030 (dwarf2_fetch_constant_bytes): Likewise
11031 (decode_locdesc): Add DW_OP_addrx
11032 (skip_form_bytes): Add DW_FORM_addrx
11033
11034 2019-04-22 Ali Tamur <tamur@google.com>
11035
11036 * MAINTAINERS (Write After Approval): Add self.
11037
11038 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
11039
11040 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11041 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11042 (open_symbol_file_object): Likewise.
11043 (svr4_default_sos): Add info parameter.
11044 (svr4_read_so_list): Likewise.
11045 (svr4_current_sos_direct): Adjust functions calls to pass down
11046 info.
11047 (svr4_current_sos_1): Add info parameter.
11048 (svr4_current_sos): Call get_svr4_info, pass info down to
11049 svr4_current_sos_1.
11050 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11051 get_svr4_info.
11052 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11053 get_svr4_info.
11054 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11055 to get_svr4_info.
11056 (probes_table_remove_objfile_probes): Likewise.
11057 (register_solib_event_probe): Add info parameter.
11058 (solist_update_incremental): Pass info parameter down to
11059 svr4_read_so_list.
11060 (disable_probes_interface): Add info parameter.
11061 (svr4_handle_solib_event): Pass current_program_space to
11062 get_svr4_info. Adjust disable_probes_interface cleanup.
11063 (svr4_create_probe_breakpoints): Add info parameter, pass it
11064 down to register_solib_event_probe.
11065 (svr4_create_solib_event_breakpoints): Add info parameter,
11066 pass it down to svr4_create_probe_breakpoints.
11067 (enable_break): Pass info down to
11068 svr4_create_solib_event_breakpoints.
11069 (svr4_solib_create_inferior_hook): Pass current_program_space to
11070 get_svr4_info.
11071 (svr4_clear_solib): Likewise.
11072
11073 2019-04-22 Pedro Alves <palves@redhat.com>
11074
11075 * solib-svr4.c (svr4_free_objfile_observer): New.
11076 (probe_and_action::objfile): New field.
11077 (probes_table_htab_remove_objfile_probes)
11078 (probes_table_remove_objfile_probes): New functions.
11079 (register_solib_event_probe): Add 'objfile' parameter. Store it
11080 in the new probe_and_action. Don't store the probe in 'lookup'.
11081 (svr4_create_probe_breakpoints): Pass objfile to
11082 register_solib_event_probe.
11083 (_initialize_svr4_solib): Register a free_objfile observer.
11084
11085 2019-04-19 Tom Tromey <tom@tromey.com>
11086
11087 * common/queue.h: Remove.
11088
11089 2019-04-19 Tom Tromey <tom@tromey.com>
11090
11091 * event-loop.c: Don't include "common/queue.h".
11092
11093 2019-04-19 Tom Tromey <tom@tromey.com>
11094
11095 * remote.c (remote_target): Use delete.
11096 * remote-notif.h: Include <list>, not "common/queue.h".
11097 (notif_client_p): Remove typedef.
11098 (remote_notif_state): Add constructor, destructor, initializer.
11099 <notif_queue>: Now a std::list.
11100 (remote_notif_state_xfree): Don't declare.
11101 * remote-notif.c (remote_notif_process, handle_notification)
11102 (remote_notif_state_allocate): Update.
11103 (~remote_notif_state): Rename from remote_notif_state_xfree.
11104
11105 2019-04-19 Tom Tromey <tom@tromey.com>
11106
11107 * symfile.c (reread_symbols): Update.
11108 * objfiles.c (objfile_register_static_link)
11109 (objfile_lookup_static_link): Update
11110 (~objfile) Don't delete static_links.
11111 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11112
11113 2019-04-19 Tom Tromey <tom@tromey.com>
11114
11115 * type-stack.h (struct type_stack) <insert>: Constify string.
11116 * type-stack.c (type_stack::insert): Constify string.
11117 * gdbtypes.h (lookup_template_type): Update.
11118 (address_space_name_to_int): Update.
11119 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11120 const.
11121 (lookup_template_type): Make name const.
11122 * c-exp.y: Update rules.
11123 (lex_one_token, classify_name, classify_inner_name)
11124 (c_print_token): Update.
11125 * p-exp.y: Update rules.
11126 (yylex): Update.
11127 * f-exp.y: Update rules.
11128 (yylex): Update.
11129 * d-exp.y: Update rules.
11130 (lex_one_token, classify_name, classify_inner_name): Update.
11131 * parse.c (write_dollar_variable, copy_name): Return std::string.
11132 * parser-defs.h (copy_name): Change return type.
11133 * m2-exp.y: Update rules.
11134 (yylex): Update.
11135 * go-exp.y (lex_one_token): Update.
11136 Update rules.
11137 (classify_unsafe_function, classify_packaged_name)
11138 (classify_name, yylex): Update.
11139
11140 2019-04-19 Sergei Trofimovich <siarheit@google.com>
11141
11142 * configure.ac: add --enable-source-highlight switch.
11143 * configure: Regenerate.
11144 * top.c (print_gdb_version): plumb --enable-source-highlight
11145 status to "show configuration".
11146
11147 2019-04-19 Tom Tromey <tromey@adacore.com>
11148
11149 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11150 Check ADA_TYPE_P.
11151 (empty_record, ada_template_to_fixed_record_type_1)
11152 (template_to_static_fixed_type)
11153 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11154 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11155 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11156 macros.
11157
11158 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11159
11160 PR symtab/24423:
11161 * source.c (print_source_lines_base): Advance "iter" when a
11162 control character is seen.
11163
11164 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11165
11166 * inferior.h (struct infcall_suspend_state_deleter):
11167 Catch exception in destructor to avoid crash.
11168
11169 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11170
11171 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11172 close to the add_com "shell".
11173
11174 2019-04-18 Tom Tromey <tromey@adacore.com>
11175
11176 * process-stratum-target.h (class process_stratum_target)
11177 <stratum>: Add "final".
11178
11179 2019-04-17 Tom Tromey <tromey@adacore.com>
11180
11181 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11182 against nullptr before use.
11183
11184 2019-04-17 Alan Hayward <alan.hayward@arm.com>
11185
11186 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11187
11188 2019-04-17 Jim Wilson <jimw@sifive.com>
11189 Andrew Burgess <andrew.burgess@embecosm.com>
11190
11191 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11192 code read might fail, assume 4-byte breakpoint in that case.
11193
11194 2019-04-15 Leszek Swirski <leszeks@google.com>
11195
11196 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11197 rather than a hand-rolled POD check when checking for forced MEMORY
11198 classification.
11199
11200 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11201
11202 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11203 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11204 function.
11205 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11206 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11207 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11208 declaration.
11209
11210 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11211
11212 * aarch64-linux-nat.c
11213 (aarch64_linux_nat_target::thread_architecture): Add override.
11214 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11215 each VQ.
11216
11217 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11218
11219 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11220
11221 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11222
11223 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11224 target types of size 96-bits, add some additional comments, and
11225 check that the builtin type we found was the correct size.
11226
11227 2019-04-12 Eli Zaretskii <eliz@gnu.org>
11228
11229 * utils.c (prompt_for_continue): Don't restore the styling at the
11230 end, as applied_style has the wrong value. This fixes styling in
11231 long lists of file names that are interrupted by the "Continue?"
11232 prompt.
11233
11234 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11235
11236 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11237 * c-lang.c (c_language_defn): Likewise.
11238 (cplus_language_defn): Likewise.
11239 (asm_language_defn): Likewise.
11240 (minimal_language_defn): Likewise.
11241 * d-lang.c (d_language_defn): Likewise.
11242 * f-lang.c (f_language_defn): Likewise.
11243 * go-lang.c (go_language_defn): Likewise.
11244 * language.c (unknown_language_defn): Likewise.
11245 (auto_language_defn): Likewise.
11246 * language.h (struct language_defn): Remove la_magic field.
11247 (LANG_MAGIC): Delete.
11248 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11249 * objc-lang.c (objc_language_defn): Likewise.
11250 * opencl-lang.c (opencl_language_defn): Likewise.
11251 * p-lang.c (pascal_language_defn): Likewise.
11252 * rust-lang.c (rust_language_defn): Likewise.
11253
11254 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11255
11256 * riscv-tdep.c (riscv_type_align): New function.
11257 (riscv_type_alignment): Delete.
11258 (riscv_arg_location): Use 'type_align'.
11259 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11260
11261 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11262
11263 * gdbtypes.c (type_align): A struct with no non-static fields also
11264 has alignment of 1.
11265
11266 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11267
11268 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11269 component to 0.
11270 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11271 member.
11272 (riscv_struct_info::analyse): New implementation using new
11273 analyse_inner member function.
11274 (riscv_struct_info::field_offset): New member function.
11275 (riscv_struct_info::m_offsets): New member variable.
11276 (riscv_struct_info::analyse_inner): New private member function,
11277 takes the old implementation of riscv_struct_info::analyse but
11278 extended to track field offsets.
11279 (riscv_call_arg_struct): Update the struct folding special cases
11280 to handle cases where empty C++ structs, which are non-zero
11281 length, are found.
11282 (riscv_arg_location): Initialise the length of each location, a
11283 non-zero length now indicates the location is in use.
11284 (riscv_push_dummy_call): Allow for the first location having a
11285 non-zero offset when setting up arguments.
11286 (riscv_return_value): Likewise, but for return values.
11287
11288 2019-04-11 Tom Tromey <tromey@adacore.com>
11289
11290 * utils.c (internal_vproblem): Make "msg" const.
11291
11292 2019-04-11 Alan Hayward <alan.hayward@arm.com>
11293
11294 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11295 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11296 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11297 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11298
11299 2019-04-10 Kevin Buettner <kevinb@redhat.com>
11300
11301 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11302 function.
11303 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11304 of amd64_collect_native_gregset.
11305 (amd64_linux_nat_target::store_registers): Likewise.
11306
11307 2019-04-10 Tom Tromey <tom@tromey.com>
11308
11309 * symtab.c (lookup_global_symbol_from_objfile)
11310 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11311 * objfiles.h (class separate_debug_iterator): New.
11312 (class separate_debug_range): New.
11313 (struct objfile) <separate_debug_objfiles>: New method.
11314 (objfile_separate_debug_iterate): Don't declare.
11315 * objfiles.c (separate_debug_iterator::operator++): Rename from
11316 objfile_separate_debug_iterate.
11317 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11318 iterator.
11319 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11320 iterator.
11321
11322 2019-04-10 Tom Tromey <tom@tromey.com>
11323
11324 * symfile.c (reread_symbols): Remove old comment.
11325 * objfiles.c (free_all_objfiles): Fix a typo.
11326
11327 2019-04-10 Tom Tromey <tom@tromey.com>
11328
11329 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11330 * minsyms.c (lookup_minimal_symbol): Use foreach.
11331 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11332 (lookup_minimal_symbol_solib_trampoline): Likewise.
11333 * symfile.c (reread_symbols): Use foreach.
11334
11335 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
11336 Tom Tromey <tromey@adacore.com>
11337
11338 PR rust/24414:
11339 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11340 (rust_lex_int_test): Change "value" to be LONGEST.
11341 (rust_lex_tests): Add test for long integer literal.
11342
11343 2019-04-09 Tom Tromey <tromey@adacore.com>
11344
11345 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11346 to bool.
11347 (extended_remote_target::attach): Update.
11348 (remote_target::remote_notice_new_inferior): Update.
11349 (remote_target::add_current_inferior_and_thread): Update.
11350 * inferior.c (exit_inferior_1): Use "false".
11351 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11352
11353 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
11354
11355 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11356 the "start" command.
11357
11358 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11359
11360 * python/py-inferior.c (infpy_thread_from_thread_handle):
11361 Adjust comments to reflect renaming of thread_from_thread_handle
11362 to thread_from_handle. Adjust keywords. Fix type error message.
11363 (inferior_object_methods): Add thread_from_handle. Retain
11364 thread_from_thread_handle, but mark it as deprecated.
11365
11366 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11367
11368 * gdbthread.h (find_thread_by_handle): Revise declaration.
11369 * thread.c (find_thread_by_handle): Likewise. Adjust
11370 implementation too.
11371 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11372 support for buffer objects as handles.
11373
11374 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11375
11376 * python/py-infthread.c (thpy_thread_handle): New function.
11377 (thread_object_methods): Register thpy_thread_handle.
11378
11379 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11380
11381 * gdbthread.h (thread_to_thread_handle): Declare.
11382 * thread.c (gdbtypes.h): Include.
11383 (thread_to_thread_handle): New function.
11384
11385 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11386 (target_thread_info_to_thread_handle): Declare.
11387 * target.c (target_thread_info_to_thread_handle): New function.
11388 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11389 * target-delegates.c: Regenerate.
11390
11391 * linux-thread-db.c (class thread_db_target): Add method
11392 thread_info_to_thread_handle.
11393 (thread_db_target::thread_info_to_thread_handle): Define.
11394 * remote.c (class remote_target): Add new method
11395 thread_info_to_thread_handle.
11396 (remote_target::thread_info_to_thread_handle): Define.
11397
11398 2019-04-08 Pedro Alves <palves@redhat.com>
11399
11400 * common/common-exceptions.c (throw_exception): Don't create
11401 named object to throw; throw directly.
11402 (throw_it): Likewise. Don't initialize gdb_exception::message
11403 here, with new; pass FMT and AP to the ctor instead.
11404 * common/common-exceptions.h: Include <string>.
11405 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11406 const char *, va_list)): New ctor. Use std::make_shared.
11407 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11408 errors)): Delete.
11409 (gdb_exception_error::gdb_exception_error(enum errors, const char
11410 *, va_list)): New.
11411 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11412 Add assertion.
11413 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11414 errors)): Delete.
11415 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11416 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11417 Add assertion.
11418
11419 2019-04-08 Tom Tromey <tom@tromey.com>
11420
11421 * valops.c (value_rtti_indirect_type): Replace throw_exception
11422 with throw.
11423 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11424 with throw.
11425 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11426 throw.
11427 * target.c (target_translate_tls_address): Replace throw_exception
11428 with throw.
11429 * stack.c (frame_apply_command_count): Replace throw_exception
11430 with throw.
11431 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11432 throw.
11433 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11434 with throw.
11435 * rs6000-tdep.c (rs6000_frame_cache)
11436 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11437 * remote.c: Replace throw_exception with throw.
11438 * record-full.c (record_full_message, record_full_wait_1)
11439 (record_full_restore): Replace throw_exception with throw.
11440 * record-btrace.c:
11441 (get_thread_current_frame_id, record_btrace_start_replaying)
11442 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11443 (cmd_record_btrace_start): Replace throw_exception with throw.
11444 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11445 throw.
11446 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11447 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11448 * linespec.c:
11449 (find_linespec_symbols): Replace throw_exception with throw.
11450 * infrun.c (displaced_step_prepare, resume): Replace
11451 throw_exception with throw.
11452 * infcmd.c (post_create_inferior): Replace throw_exception with
11453 throw.
11454 * inf-loop.c (inferior_event_handler): Replace throw_exception
11455 with throw.
11456 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11457 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11458 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11459 (get_prev_frame_always, get_frame_pc_if_available)
11460 (get_frame_address_in_block_if_available, get_frame_language):
11461 Replace throw_exception with throw.
11462 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11463 throw_exception with throw.
11464 * eval.c (fetch_subexp_value, evaluate_var_value)
11465 (evaluate_funcall, evaluate_subexp_standard): Replace
11466 throw_exception with throw.
11467 * dwarf2loc.c (call_site_find_chain)
11468 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11469 Replace throw_exception with throw.
11470 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11471 with throw.
11472 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11473 throw.
11474 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11475 * completer.c (complete_line_internal): Replace throw_exception
11476 with throw.
11477 * compile/compile-object-run.c (compile_object_run): Replace
11478 throw_exception with throw.
11479 * cli/cli-script.c (process_next_line): Replace throw_exception
11480 with throw.
11481 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11482 (btrace_enable, btrace_maint_update_pt_packets): Replace
11483 throw_exception with throw.
11484 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11485 throw_exception with throw.
11486 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11487 throw_exception with throw.
11488 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11489 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11490 * aarch64-tdep.c (aarch64_make_prologue_cache)
11491 (aarch64_make_stub_cache): Replace throw_exception with throw.
11492
11493 2019-04-08 Tom Tromey <tom@tromey.com>
11494
11495 * common/common-exceptions.c (throw_exception): Rename from
11496 throw_exception_cxx. Remove old copy. Make argument const.
11497 (throw_it): Create and throw exception objects directly.
11498 * common/common-exceptions.h (throw_exception): Make argument
11499 const.
11500 (struct gdb_exception_error): Add constructor.
11501 (struct gdb_exception_quit): Add constructor.
11502
11503 2019-04-08 Tom Tromey <tom@tromey.com>
11504
11505 * common/common-exceptions.h (exception_rethrow): Don't declare.
11506 (TRY_SJLJ): Update comment.
11507 (TRY, CATCH, END_CATCH): Remove.
11508 * common/common-exceptions.c (exception_rethrow): Remove.
11509
11510 2019-04-08 Tom Tromey <tom@tromey.com>
11511
11512 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11513 Remove.
11514 (gdb_exception_error): Rename from
11515 gdb_exception_RETURN_MASK_ERROR.
11516 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11517 (gdb_quit_bad_alloc): Update.
11518 * aarch64-tdep.c: Update.
11519 * ada-lang.c: Update.
11520 * ada-typeprint.c: Update.
11521 * ada-valprint.c: Update.
11522 * amd64-tdep.c: Update.
11523 * arch-utils.c: Update.
11524 * break-catch-throw.c: Update.
11525 * breakpoint.c: Update.
11526 * btrace.c: Update.
11527 * c-varobj.c: Update.
11528 * cli/cli-cmds.c: Update.
11529 * cli/cli-interp.c: Update.
11530 * cli/cli-script.c: Update.
11531 * common/common-exceptions.c: Update.
11532 * common/new-op.c: Update.
11533 * common/selftest.c: Update.
11534 * compile/compile-c-symbols.c: Update.
11535 * compile/compile-cplus-symbols.c: Update.
11536 * compile/compile-object-load.c: Update.
11537 * compile/compile-object-run.c: Update.
11538 * completer.c: Update.
11539 * corelow.c: Update.
11540 * cp-abi.c: Update.
11541 * cp-support.c: Update.
11542 * cp-valprint.c: Update.
11543 * darwin-nat.c: Update.
11544 * disasm-selftests.c: Update.
11545 * dtrace-probe.c: Update.
11546 * dwarf-index-cache.c: Update.
11547 * dwarf-index-write.c: Update.
11548 * dwarf2-frame-tailcall.c: Update.
11549 * dwarf2-frame.c: Update.
11550 * dwarf2loc.c: Update.
11551 * dwarf2read.c: Update.
11552 * eval.c: Update.
11553 * event-loop.c: Update.
11554 * event-top.c: Update.
11555 * exec.c: Update.
11556 * f-valprint.c: Update.
11557 * fbsd-tdep.c: Update.
11558 * frame-unwind.c: Update.
11559 * frame.c: Update.
11560 * gdbtypes.c: Update.
11561 * gnu-v3-abi.c: Update.
11562 * guile/guile-internal.h: Update.
11563 * guile/scm-block.c: Update.
11564 * guile/scm-breakpoint.c: Update.
11565 * guile/scm-cmd.c: Update.
11566 * guile/scm-disasm.c: Update.
11567 * guile/scm-frame.c: Update.
11568 * guile/scm-lazy-string.c: Update.
11569 * guile/scm-math.c: Update.
11570 * guile/scm-param.c: Update.
11571 * guile/scm-ports.c: Update.
11572 * guile/scm-pretty-print.c: Update.
11573 * guile/scm-symbol.c: Update.
11574 * guile/scm-symtab.c: Update.
11575 * guile/scm-type.c: Update.
11576 * guile/scm-value.c: Update.
11577 * i386-linux-tdep.c: Update.
11578 * i386-tdep.c: Update.
11579 * inf-loop.c: Update.
11580 * infcall.c: Update.
11581 * infcmd.c: Update.
11582 * infrun.c: Update.
11583 * jit.c: Update.
11584 * language.c: Update.
11585 * linespec.c: Update.
11586 * linux-fork.c: Update.
11587 * linux-nat.c: Update.
11588 * linux-tdep.c: Update.
11589 * linux-thread-db.c: Update.
11590 * main.c: Update.
11591 * mi/mi-cmd-break.c: Update.
11592 * mi/mi-cmd-stack.c: Update.
11593 * mi/mi-interp.c: Update.
11594 * mi/mi-main.c: Update.
11595 * objc-lang.c: Update.
11596 * p-valprint.c: Update.
11597 * parse.c: Update.
11598 * ppc-linux-tdep.c: Update.
11599 * printcmd.c: Update.
11600 * python/py-arch.c: Update.
11601 * python/py-breakpoint.c: Update.
11602 * python/py-cmd.c: Update.
11603 * python/py-finishbreakpoint.c: Update.
11604 * python/py-frame.c: Update.
11605 * python/py-framefilter.c: Update.
11606 * python/py-gdb-readline.c: Update.
11607 * python/py-inferior.c: Update.
11608 * python/py-infthread.c: Update.
11609 * python/py-lazy-string.c: Update.
11610 * python/py-linetable.c: Update.
11611 * python/py-objfile.c: Update.
11612 * python/py-param.c: Update.
11613 * python/py-prettyprint.c: Update.
11614 * python/py-progspace.c: Update.
11615 * python/py-record-btrace.c: Update.
11616 * python/py-record.c: Update.
11617 * python/py-symbol.c: Update.
11618 * python/py-type.c: Update.
11619 * python/py-unwind.c: Update.
11620 * python/py-utils.c: Update.
11621 * python/py-value.c: Update.
11622 * python/python.c: Update.
11623 * record-btrace.c: Update.
11624 * record-full.c: Update.
11625 * remote-fileio.c: Update.
11626 * remote.c: Update.
11627 * riscv-tdep.c: Update.
11628 * rs6000-aix-tdep.c: Update.
11629 * rs6000-tdep.c: Update.
11630 * rust-exp.y: Update.
11631 * rust-lang.c: Update.
11632 * s390-tdep.c: Update.
11633 * selftest-arch.c: Update.
11634 * solib-dsbt.c: Update.
11635 * solib-frv.c: Update.
11636 * solib-spu.c: Update.
11637 * solib-svr4.c: Update.
11638 * solib.c: Update.
11639 * sparc64-linux-tdep.c: Update.
11640 * stack.c: Update.
11641 * symfile-mem.c: Update.
11642 * symmisc.c: Update.
11643 * target.c: Update.
11644 * thread.c: Update.
11645 * top.c: Update.
11646 * tracefile-tfile.c: Update.
11647 * tui/tui.c: Update.
11648 * typeprint.c: Update.
11649 * unittests/cli-utils-selftests.c: Update.
11650 * unittests/parse-connection-spec-selftests.c: Update.
11651 * valops.c: Update.
11652 * valprint.c: Update.
11653 * value.c: Update.
11654 * varobj.c: Update.
11655 * windows-nat.c: Update.
11656 * x86-linux-nat.c: Update.
11657 * xml-support.c: Update.
11658
11659 2019-04-08 Tom Tromey <tom@tromey.com>
11660
11661 * xml-support.c: Use C++ exception handling.
11662 * x86-linux-nat.c: Use C++ exception handling.
11663 * windows-nat.c: Use C++ exception handling.
11664 * varobj.c: Use C++ exception handling.
11665 * value.c: Use C++ exception handling.
11666 * valprint.c: Use C++ exception handling.
11667 * valops.c: Use C++ exception handling.
11668 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11669 handling.
11670 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11671 * typeprint.c: Use C++ exception handling.
11672 * tui/tui.c: Use C++ exception handling.
11673 * tracefile-tfile.c: Use C++ exception handling.
11674 * top.c: Use C++ exception handling.
11675 * thread.c: Use C++ exception handling.
11676 * target.c: Use C++ exception handling.
11677 * symmisc.c: Use C++ exception handling.
11678 * symfile-mem.c: Use C++ exception handling.
11679 * stack.c: Use C++ exception handling.
11680 * sparc64-linux-tdep.c: Use C++ exception handling.
11681 * solib.c: Use C++ exception handling.
11682 * solib-svr4.c: Use C++ exception handling.
11683 * solib-spu.c: Use C++ exception handling.
11684 * solib-frv.c: Use C++ exception handling.
11685 * solib-dsbt.c: Use C++ exception handling.
11686 * selftest-arch.c: Use C++ exception handling.
11687 * s390-tdep.c: Use C++ exception handling.
11688 * rust-lang.c: Use C++ exception handling.
11689 * rust-exp.y: Use C++ exception handling.
11690 * rs6000-tdep.c: Use C++ exception handling.
11691 * rs6000-aix-tdep.c: Use C++ exception handling.
11692 * riscv-tdep.c: Use C++ exception handling.
11693 * remote.c: Use C++ exception handling.
11694 * remote-fileio.c: Use C++ exception handling.
11695 * record-full.c: Use C++ exception handling.
11696 * record-btrace.c: Use C++ exception handling.
11697 * python/python.c: Use C++ exception handling.
11698 * python/py-value.c: Use C++ exception handling.
11699 * python/py-utils.c: Use C++ exception handling.
11700 * python/py-unwind.c: Use C++ exception handling.
11701 * python/py-type.c: Use C++ exception handling.
11702 * python/py-symbol.c: Use C++ exception handling.
11703 * python/py-record.c: Use C++ exception handling.
11704 * python/py-record-btrace.c: Use C++ exception handling.
11705 * python/py-progspace.c: Use C++ exception handling.
11706 * python/py-prettyprint.c: Use C++ exception handling.
11707 * python/py-param.c: Use C++ exception handling.
11708 * python/py-objfile.c: Use C++ exception handling.
11709 * python/py-linetable.c: Use C++ exception handling.
11710 * python/py-lazy-string.c: Use C++ exception handling.
11711 * python/py-infthread.c: Use C++ exception handling.
11712 * python/py-inferior.c: Use C++ exception handling.
11713 * python/py-gdb-readline.c: Use C++ exception handling.
11714 * python/py-framefilter.c: Use C++ exception handling.
11715 * python/py-frame.c: Use C++ exception handling.
11716 * python/py-finishbreakpoint.c: Use C++ exception handling.
11717 * python/py-cmd.c: Use C++ exception handling.
11718 * python/py-breakpoint.c: Use C++ exception handling.
11719 * python/py-arch.c: Use C++ exception handling.
11720 * printcmd.c: Use C++ exception handling.
11721 * ppc-linux-tdep.c: Use C++ exception handling.
11722 * parse.c: Use C++ exception handling.
11723 * p-valprint.c: Use C++ exception handling.
11724 * objc-lang.c: Use C++ exception handling.
11725 * mi/mi-main.c: Use C++ exception handling.
11726 * mi/mi-interp.c: Use C++ exception handling.
11727 * mi/mi-cmd-stack.c: Use C++ exception handling.
11728 * mi/mi-cmd-break.c: Use C++ exception handling.
11729 * main.c: Use C++ exception handling.
11730 * linux-thread-db.c: Use C++ exception handling.
11731 * linux-tdep.c: Use C++ exception handling.
11732 * linux-nat.c: Use C++ exception handling.
11733 * linux-fork.c: Use C++ exception handling.
11734 * linespec.c: Use C++ exception handling.
11735 * language.c: Use C++ exception handling.
11736 * jit.c: Use C++ exception handling.
11737 * infrun.c: Use C++ exception handling.
11738 * infcmd.c: Use C++ exception handling.
11739 * infcall.c: Use C++ exception handling.
11740 * inf-loop.c: Use C++ exception handling.
11741 * i386-tdep.c: Use C++ exception handling.
11742 * i386-linux-tdep.c: Use C++ exception handling.
11743 * guile/scm-value.c: Use C++ exception handling.
11744 * guile/scm-type.c: Use C++ exception handling.
11745 * guile/scm-symtab.c: Use C++ exception handling.
11746 * guile/scm-symbol.c: Use C++ exception handling.
11747 * guile/scm-pretty-print.c: Use C++ exception handling.
11748 * guile/scm-ports.c: Use C++ exception handling.
11749 * guile/scm-param.c: Use C++ exception handling.
11750 * guile/scm-math.c: Use C++ exception handling.
11751 * guile/scm-lazy-string.c: Use C++ exception handling.
11752 * guile/scm-frame.c: Use C++ exception handling.
11753 * guile/scm-disasm.c: Use C++ exception handling.
11754 * guile/scm-cmd.c: Use C++ exception handling.
11755 * guile/scm-breakpoint.c: Use C++ exception handling.
11756 * guile/scm-block.c: Use C++ exception handling.
11757 * guile/guile-internal.h: Use C++ exception handling.
11758 * gnu-v3-abi.c: Use C++ exception handling.
11759 * gdbtypes.c: Use C++ exception handling.
11760 * frame.c: Use C++ exception handling.
11761 * frame-unwind.c: Use C++ exception handling.
11762 * fbsd-tdep.c: Use C++ exception handling.
11763 * f-valprint.c: Use C++ exception handling.
11764 * exec.c: Use C++ exception handling.
11765 * event-top.c: Use C++ exception handling.
11766 * event-loop.c: Use C++ exception handling.
11767 * eval.c: Use C++ exception handling.
11768 * dwarf2read.c: Use C++ exception handling.
11769 * dwarf2loc.c: Use C++ exception handling.
11770 * dwarf2-frame.c: Use C++ exception handling.
11771 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11772 * dwarf-index-write.c: Use C++ exception handling.
11773 * dwarf-index-cache.c: Use C++ exception handling.
11774 * dtrace-probe.c: Use C++ exception handling.
11775 * disasm-selftests.c: Use C++ exception handling.
11776 * darwin-nat.c: Use C++ exception handling.
11777 * cp-valprint.c: Use C++ exception handling.
11778 * cp-support.c: Use C++ exception handling.
11779 * cp-abi.c: Use C++ exception handling.
11780 * corelow.c: Use C++ exception handling.
11781 * completer.c: Use C++ exception handling.
11782 * compile/compile-object-run.c: Use C++ exception handling.
11783 * compile/compile-object-load.c: Use C++ exception handling.
11784 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11785 * compile/compile-c-symbols.c: Use C++ exception handling.
11786 * common/selftest.c: Use C++ exception handling.
11787 * common/new-op.c: Use C++ exception handling.
11788 * cli/cli-script.c: Use C++ exception handling.
11789 * cli/cli-interp.c: Use C++ exception handling.
11790 * cli/cli-cmds.c: Use C++ exception handling.
11791 * c-varobj.c: Use C++ exception handling.
11792 * btrace.c: Use C++ exception handling.
11793 * breakpoint.c: Use C++ exception handling.
11794 * break-catch-throw.c: Use C++ exception handling.
11795 * arch-utils.c: Use C++ exception handling.
11796 * amd64-tdep.c: Use C++ exception handling.
11797 * ada-valprint.c: Use C++ exception handling.
11798 * ada-typeprint.c: Use C++ exception handling.
11799 * ada-lang.c: Use C++ exception handling.
11800 * aarch64-tdep.c: Use C++ exception handling.
11801
11802 2019-04-08 Tom Tromey <tom@tromey.com>
11803
11804 * xml-support.c (gdb_xml_parser::parse): Update.
11805 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11806 * value.c (show_convenience): Update.
11807 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11808 (test_parse_flags_qcs): Update.
11809 * thread.c (thr_try_catch_cmd): Update.
11810 * target.c (target_translate_tls_address): Update.
11811 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11812 (info_frame_command_core, frame_apply_command_count): Update.
11813 * rust-exp.y (rust_lex_exception_test): Update.
11814 * riscv-tdep.c (riscv_print_one_register_info): Update.
11815 * remote.c (remote_target::enable_btrace): Update.
11816 * record-btrace.c (record_btrace_enable_warn): Update.
11817 * python/py-utils.c (gdbpy_convert_exception): Update.
11818 * printcmd.c (do_one_display, print_variable_and_value): Update.
11819 * mi/mi-main.c (mi_print_exception): Update.
11820 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11821 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11822 * linux-nat.c (linux_nat_target::attach): Update.
11823 * linux-fork.c (class scoped_switch_fork_info): Update.
11824 * infrun.c (displaced_step_prepare): Update.
11825 * infcall.c (call_function_by_hand_dummy): Update.
11826 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11827 * gnu-v3-abi.c (print_one_vtable): Update.
11828 * frame.c (get_prev_frame_always): Update.
11829 * f-valprint.c (info_common_command_for_block): Update.
11830 * exec.c (try_open_exec_file): Update.
11831 * exceptions.c (print_exception, exception_print)
11832 (exception_fprintf, exception_print_same): Update.
11833 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11834 * dwarf-index-cache.c (index_cache::store)
11835 (index_cache::lookup_gdb_index): Update.
11836 * darwin-nat.c (maybe_cache_shell): Update.
11837 * cp-valprint.c (cp_print_value_fields): Update.
11838 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11839 (gcc_cplus_symbol_address): Update.
11840 * compile/compile-c-symbols.c (gcc_convert_symbol)
11841 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11842 * common/selftest.c: Update.
11843 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11844 a std::string.
11845 (exception_try_scope_entry, exception_try_scope_exit): Don't
11846 declare.
11847 (struct exception_try_scope): Remove.
11848 (TRY): Don't use exception_try_scope.
11849 (struct gdb_exception): Add constructor, operator=.
11850 <what>: New method.
11851 (struct gdb_exception_RETURN_MASK_ALL)
11852 (struct gdb_exception_RETURN_MASK_ERROR)
11853 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11854 (struct gdb_quit_bad_alloc): Update.
11855 * common/common-exceptions.c (exception_none): Change
11856 initializer.
11857 (struct catcher) <state, exception>: Initialize inline.
11858 <prev>: Remove member.
11859 (current_catcher): Remove.
11860 (catchers): New global.
11861 (exceptions_state_mc_init): Simplify.
11862 (catcher_pop): Remove.
11863 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11864 (try_scope_depth, exception_try_scope_entry)
11865 (exception_try_scope_exit): Remove.
11866 (throw_exception_sjlj): Update.
11867 (exception_messages, exception_messages_size): Remove.
11868 (throw_it): Simplify.
11869 (gdb_exception_sliced_copy): Remove.
11870 (throw_exception_cxx): Update.
11871 * cli/cli-script.c (script_from_file): Update.
11872 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11873 Update.
11874 * ada-valprint.c (ada_val_print): Update.
11875 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11876 (create_excep_cond_exprs): Update.
11877
11878 2019-04-08 Tom Tromey <tom@tromey.com>
11879
11880 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11881 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11882 (TRY, CATCH, END_CATCH): Remove some definitions.
11883 * common/common-exceptions.c: Don't use GDB_XCPT.
11884 (catcher_list_size): Remove.
11885 (throw_exception, throw_it): Simplify.
11886
11887 2019-04-05 Tom Tromey <tom@tromey.com>
11888
11889 Revert the header-sorting patch.
11890 * ft32-tdep.c: Revert.
11891 * frv-tdep.c: Revert.
11892 * frv-linux-tdep.c: Revert.
11893 * frame.c: Revert.
11894 * frame-unwind.c: Revert.
11895 * frame-base.c: Revert.
11896 * fork-child.c: Revert.
11897 * findvar.c: Revert.
11898 * findcmd.c: Revert.
11899 * filesystem.c: Revert.
11900 * filename-seen-cache.h: Revert.
11901 * filename-seen-cache.c: Revert.
11902 * fbsd-tdep.c: Revert.
11903 * fbsd-nat.h: Revert.
11904 * fbsd-nat.c: Revert.
11905 * f-valprint.c: Revert.
11906 * f-typeprint.c: Revert.
11907 * f-lang.c: Revert.
11908 * extension.h: Revert.
11909 * extension.c: Revert.
11910 * extension-priv.h: Revert.
11911 * expprint.c: Revert.
11912 * exec.h: Revert.
11913 * exec.c: Revert.
11914 * exceptions.c: Revert.
11915 * event-top.c: Revert.
11916 * event-loop.c: Revert.
11917 * eval.c: Revert.
11918 * elfread.c: Revert.
11919 * dwarf2read.h: Revert.
11920 * dwarf2read.c: Revert.
11921 * dwarf2loc.c: Revert.
11922 * dwarf2expr.h: Revert.
11923 * dwarf2expr.c: Revert.
11924 * dwarf2-frame.c: Revert.
11925 * dwarf2-frame-tailcall.c: Revert.
11926 * dwarf-index-write.h: Revert.
11927 * dwarf-index-write.c: Revert.
11928 * dwarf-index-common.c: Revert.
11929 * dwarf-index-cache.h: Revert.
11930 * dwarf-index-cache.c: Revert.
11931 * dummy-frame.c: Revert.
11932 * dtrace-probe.c: Revert.
11933 * disasm.h: Revert.
11934 * disasm.c: Revert.
11935 * disasm-selftests.c: Revert.
11936 * dictionary.c: Revert.
11937 * dicos-tdep.c: Revert.
11938 * demangle.c: Revert.
11939 * dcache.h: Revert.
11940 * dcache.c: Revert.
11941 * darwin-nat.h: Revert.
11942 * darwin-nat.c: Revert.
11943 * darwin-nat-info.c: Revert.
11944 * d-valprint.c: Revert.
11945 * d-namespace.c: Revert.
11946 * d-lang.c: Revert.
11947 * ctf.c: Revert.
11948 * csky-tdep.c: Revert.
11949 * csky-linux-tdep.c: Revert.
11950 * cris-tdep.c: Revert.
11951 * cris-linux-tdep.c: Revert.
11952 * cp-valprint.c: Revert.
11953 * cp-support.c: Revert.
11954 * cp-namespace.c: Revert.
11955 * cp-abi.c: Revert.
11956 * corelow.c: Revert.
11957 * corefile.c: Revert.
11958 * continuations.c: Revert.
11959 * completer.h: Revert.
11960 * completer.c: Revert.
11961 * complaints.c: Revert.
11962 * coffread.c: Revert.
11963 * coff-pe-read.c: Revert.
11964 * cli-out.h: Revert.
11965 * cli-out.c: Revert.
11966 * charset.c: Revert.
11967 * c-varobj.c: Revert.
11968 * c-valprint.c: Revert.
11969 * c-typeprint.c: Revert.
11970 * c-lang.c: Revert.
11971 * buildsym.c: Revert.
11972 * buildsym-legacy.c: Revert.
11973 * build-id.h: Revert.
11974 * build-id.c: Revert.
11975 * btrace.c: Revert.
11976 * bsd-uthread.c: Revert.
11977 * breakpoint.h: Revert.
11978 * breakpoint.c: Revert.
11979 * break-catch-throw.c: Revert.
11980 * break-catch-syscall.c: Revert.
11981 * break-catch-sig.c: Revert.
11982 * blockframe.c: Revert.
11983 * block.c: Revert.
11984 * bfin-tdep.c: Revert.
11985 * bfin-linux-tdep.c: Revert.
11986 * bfd-target.c: Revert.
11987 * bcache.c: Revert.
11988 * ax-general.c: Revert.
11989 * ax-gdb.h: Revert.
11990 * ax-gdb.c: Revert.
11991 * avr-tdep.c: Revert.
11992 * auxv.c: Revert.
11993 * auto-load.c: Revert.
11994 * arm-wince-tdep.c: Revert.
11995 * arm-tdep.c: Revert.
11996 * arm-symbian-tdep.c: Revert.
11997 * arm-pikeos-tdep.c: Revert.
11998 * arm-obsd-tdep.c: Revert.
11999 * arm-nbsd-tdep.c: Revert.
12000 * arm-nbsd-nat.c: Revert.
12001 * arm-linux-tdep.c: Revert.
12002 * arm-linux-nat.c: Revert.
12003 * arm-fbsd-tdep.c: Revert.
12004 * arm-fbsd-nat.c: Revert.
12005 * arm-bsd-tdep.c: Revert.
12006 * arch-utils.c: Revert.
12007 * arc-tdep.c: Revert.
12008 * arc-newlib-tdep.c: Revert.
12009 * annotate.h: Revert.
12010 * annotate.c: Revert.
12011 * amd64-windows-tdep.c: Revert.
12012 * amd64-windows-nat.c: Revert.
12013 * amd64-tdep.c: Revert.
12014 * amd64-sol2-tdep.c: Revert.
12015 * amd64-obsd-tdep.c: Revert.
12016 * amd64-obsd-nat.c: Revert.
12017 * amd64-nbsd-tdep.c: Revert.
12018 * amd64-nbsd-nat.c: Revert.
12019 * amd64-nat.c: Revert.
12020 * amd64-linux-tdep.c: Revert.
12021 * amd64-linux-nat.c: Revert.
12022 * amd64-fbsd-tdep.c: Revert.
12023 * amd64-fbsd-nat.c: Revert.
12024 * amd64-dicos-tdep.c: Revert.
12025 * amd64-darwin-tdep.c: Revert.
12026 * amd64-bsd-nat.c: Revert.
12027 * alpha-tdep.c: Revert.
12028 * alpha-obsd-tdep.c: Revert.
12029 * alpha-nbsd-tdep.c: Revert.
12030 * alpha-mdebug-tdep.c: Revert.
12031 * alpha-linux-tdep.c: Revert.
12032 * alpha-linux-nat.c: Revert.
12033 * alpha-bsd-tdep.c: Revert.
12034 * alpha-bsd-nat.c: Revert.
12035 * aix-thread.c: Revert.
12036 * agent.c: Revert.
12037 * addrmap.c: Revert.
12038 * ada-varobj.c: Revert.
12039 * ada-valprint.c: Revert.
12040 * ada-typeprint.c: Revert.
12041 * ada-tasks.c: Revert.
12042 * ada-lang.c: Revert.
12043 * aarch64-tdep.c: Revert.
12044 * aarch64-ravenscar-thread.c: Revert.
12045 * aarch64-newlib-tdep.c: Revert.
12046 * aarch64-linux-tdep.c: Revert.
12047 * aarch64-linux-nat.c: Revert.
12048 * aarch64-fbsd-tdep.c: Revert.
12049 * aarch64-fbsd-nat.c: Revert.
12050 * aarch32-linux-nat.c: Revert.
12051
12052 2019-04-05 Tom Tromey <tom@tromey.com>
12053
12054 * ft32-tdep.c: Sort headers.
12055 * frv-tdep.c: Sort headers.
12056 * frv-linux-tdep.c: Sort headers.
12057 * frame.c: Sort headers.
12058 * frame-unwind.c: Sort headers.
12059 * frame-base.c: Sort headers.
12060 * fork-child.c: Sort headers.
12061 * findvar.c: Sort headers.
12062 * findcmd.c: Sort headers.
12063 * filesystem.c: Sort headers.
12064 * filename-seen-cache.h: Sort headers.
12065 * filename-seen-cache.c: Sort headers.
12066 * fbsd-tdep.c: Sort headers.
12067 * fbsd-nat.h: Sort headers.
12068 * fbsd-nat.c: Sort headers.
12069 * f-valprint.c: Sort headers.
12070 * f-typeprint.c: Sort headers.
12071 * f-lang.c: Sort headers.
12072 * extension.h: Sort headers.
12073 * extension.c: Sort headers.
12074 * extension-priv.h: Sort headers.
12075 * expprint.c: Sort headers.
12076 * exec.h: Sort headers.
12077 * exec.c: Sort headers.
12078 * exceptions.c: Sort headers.
12079 * event-top.c: Sort headers.
12080 * event-loop.c: Sort headers.
12081 * eval.c: Sort headers.
12082 * elfread.c: Sort headers.
12083 * dwarf2read.h: Sort headers.
12084 * dwarf2read.c: Sort headers.
12085 * dwarf2loc.c: Sort headers.
12086 * dwarf2expr.h: Sort headers.
12087 * dwarf2expr.c: Sort headers.
12088 * dwarf2-frame.c: Sort headers.
12089 * dwarf2-frame-tailcall.c: Sort headers.
12090 * dwarf-index-write.h: Sort headers.
12091 * dwarf-index-write.c: Sort headers.
12092 * dwarf-index-common.c: Sort headers.
12093 * dwarf-index-cache.h: Sort headers.
12094 * dwarf-index-cache.c: Sort headers.
12095 * dummy-frame.c: Sort headers.
12096 * dtrace-probe.c: Sort headers.
12097 * disasm.h: Sort headers.
12098 * disasm.c: Sort headers.
12099 * disasm-selftests.c: Sort headers.
12100 * dictionary.c: Sort headers.
12101 * dicos-tdep.c: Sort headers.
12102 * demangle.c: Sort headers.
12103 * dcache.h: Sort headers.
12104 * dcache.c: Sort headers.
12105 * darwin-nat.h: Sort headers.
12106 * darwin-nat.c: Sort headers.
12107 * darwin-nat-info.c: Sort headers.
12108 * d-valprint.c: Sort headers.
12109 * d-namespace.c: Sort headers.
12110 * d-lang.c: Sort headers.
12111 * ctf.c: Sort headers.
12112 * csky-tdep.c: Sort headers.
12113 * csky-linux-tdep.c: Sort headers.
12114 * cris-tdep.c: Sort headers.
12115 * cris-linux-tdep.c: Sort headers.
12116 * cp-valprint.c: Sort headers.
12117 * cp-support.c: Sort headers.
12118 * cp-namespace.c: Sort headers.
12119 * cp-abi.c: Sort headers.
12120 * corelow.c: Sort headers.
12121 * corefile.c: Sort headers.
12122 * continuations.c: Sort headers.
12123 * completer.h: Sort headers.
12124 * completer.c: Sort headers.
12125 * complaints.c: Sort headers.
12126 * coffread.c: Sort headers.
12127 * coff-pe-read.c: Sort headers.
12128 * cli-out.h: Sort headers.
12129 * cli-out.c: Sort headers.
12130 * charset.c: Sort headers.
12131 * c-varobj.c: Sort headers.
12132 * c-valprint.c: Sort headers.
12133 * c-typeprint.c: Sort headers.
12134 * c-lang.c: Sort headers.
12135 * buildsym.c: Sort headers.
12136 * buildsym-legacy.c: Sort headers.
12137 * build-id.h: Sort headers.
12138 * build-id.c: Sort headers.
12139 * btrace.c: Sort headers.
12140 * bsd-uthread.c: Sort headers.
12141 * breakpoint.h: Sort headers.
12142 * breakpoint.c: Sort headers.
12143 * break-catch-throw.c: Sort headers.
12144 * break-catch-syscall.c: Sort headers.
12145 * break-catch-sig.c: Sort headers.
12146 * blockframe.c: Sort headers.
12147 * block.c: Sort headers.
12148 * bfin-tdep.c: Sort headers.
12149 * bfin-linux-tdep.c: Sort headers.
12150 * bfd-target.c: Sort headers.
12151 * bcache.c: Sort headers.
12152 * ax-general.c: Sort headers.
12153 * ax-gdb.h: Sort headers.
12154 * ax-gdb.c: Sort headers.
12155 * avr-tdep.c: Sort headers.
12156 * auxv.c: Sort headers.
12157 * auto-load.c: Sort headers.
12158 * arm-wince-tdep.c: Sort headers.
12159 * arm-tdep.c: Sort headers.
12160 * arm-symbian-tdep.c: Sort headers.
12161 * arm-pikeos-tdep.c: Sort headers.
12162 * arm-obsd-tdep.c: Sort headers.
12163 * arm-nbsd-tdep.c: Sort headers.
12164 * arm-nbsd-nat.c: Sort headers.
12165 * arm-linux-tdep.c: Sort headers.
12166 * arm-linux-nat.c: Sort headers.
12167 * arm-fbsd-tdep.c: Sort headers.
12168 * arm-fbsd-nat.c: Sort headers.
12169 * arm-bsd-tdep.c: Sort headers.
12170 * arch-utils.c: Sort headers.
12171 * arc-tdep.c: Sort headers.
12172 * arc-newlib-tdep.c: Sort headers.
12173 * annotate.h: Sort headers.
12174 * annotate.c: Sort headers.
12175 * amd64-windows-tdep.c: Sort headers.
12176 * amd64-windows-nat.c: Sort headers.
12177 * amd64-tdep.c: Sort headers.
12178 * amd64-sol2-tdep.c: Sort headers.
12179 * amd64-obsd-tdep.c: Sort headers.
12180 * amd64-obsd-nat.c: Sort headers.
12181 * amd64-nbsd-tdep.c: Sort headers.
12182 * amd64-nbsd-nat.c: Sort headers.
12183 * amd64-nat.c: Sort headers.
12184 * amd64-linux-tdep.c: Sort headers.
12185 * amd64-linux-nat.c: Sort headers.
12186 * amd64-fbsd-tdep.c: Sort headers.
12187 * amd64-fbsd-nat.c: Sort headers.
12188 * amd64-dicos-tdep.c: Sort headers.
12189 * amd64-darwin-tdep.c: Sort headers.
12190 * amd64-bsd-nat.c: Sort headers.
12191 * alpha-tdep.c: Sort headers.
12192 * alpha-obsd-tdep.c: Sort headers.
12193 * alpha-nbsd-tdep.c: Sort headers.
12194 * alpha-mdebug-tdep.c: Sort headers.
12195 * alpha-linux-tdep.c: Sort headers.
12196 * alpha-linux-nat.c: Sort headers.
12197 * alpha-bsd-tdep.c: Sort headers.
12198 * alpha-bsd-nat.c: Sort headers.
12199 * aix-thread.c: Sort headers.
12200 * agent.c: Sort headers.
12201 * addrmap.c: Sort headers.
12202 * ada-varobj.c: Sort headers.
12203 * ada-valprint.c: Sort headers.
12204 * ada-typeprint.c: Sort headers.
12205 * ada-tasks.c: Sort headers.
12206 * ada-lang.c: Sort headers.
12207 * aarch64-tdep.c: Sort headers.
12208 * aarch64-ravenscar-thread.c: Sort headers.
12209 * aarch64-newlib-tdep.c: Sort headers.
12210 * aarch64-linux-tdep.c: Sort headers.
12211 * aarch64-linux-nat.c: Sort headers.
12212 * aarch64-fbsd-tdep.c: Sort headers.
12213 * aarch64-fbsd-nat.c: Sort headers.
12214 * aarch32-linux-nat.c: Sort headers.
12215
12216 2019-04-04 Tom Tromey <tom@tromey.com>
12217
12218 * varobj.c (varobj_create): Update.
12219 * rust-exp.y (struct rust_parser) <update_innermost_block,
12220 lookup_symbol>: New methods.
12221 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12222 Rename.
12223 (rust_parser::rust_lookup_type)
12224 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12225 * printcmd.c (display_command, do_one_display): Update.
12226 * parser-defs.h (struct parser_state) <parser_state>: Add
12227 "tracker" parameter.
12228 (block_tracker): New member.
12229 (class innermost_block_tracker) <innermost_block_tracker>: Add
12230 "types" parameter.
12231 <reset>: Remove method.
12232 (innermost_block): Don't declare.
12233 (null_post_parser): Update.
12234 * parse.c (innermost_block): Remove global.
12235 (write_dollar_variable): Update.
12236 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12237 Remove "tracker_types" parameter.
12238 (parse_expression): Add "tracker" parameter.
12239 (parse_expression_for_completion): Update.
12240 (null_post_parser): Add "tracker" parameter.
12241 * p-exp.y: Update rules.
12242 * m2-exp.y: Update rules.
12243 * language.h (struct language_defn) <la_post_parser>: Add
12244 "tracker" parameter.
12245 * go-exp.y: Update rules.
12246 * f-exp.y: Update rules.
12247 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12248 parameter.
12249 * d-exp.y: Update rules.
12250 * c-exp.y: Update rules.
12251 * breakpoint.c (set_breakpoint_condition): Create an
12252 innermost_block_tracker.
12253 (watch_command_1): Likewise.
12254 * ada-lang.c (resolve): Add "tracker" parameter.
12255 (resolve_subexp): Likewise.
12256 * ada-exp.y (write_var_from_sym): Update.
12257
12258 2019-04-04 Tom Tromey <tom@tromey.com>
12259
12260 * type-stack.h: New file.
12261 * type-stack.c: New file.
12262 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12263 type-stack.h.
12264 (insert_into_type_stack, insert_type, push_type, push_type_int)
12265 (insert_type_address_space, pop_type, pop_type_int)
12266 (pop_typelist, pop_type_stack, append_type_stack)
12267 (push_type_stack, get_type_stack, push_typelist)
12268 (follow_type_instance_flags, follow_types): Don't declare.
12269 * parse.c (type_stack): Remove global.
12270 (parse_exp_in_context): Update.
12271 (insert_into_type_stack, insert_type, push_type, push_type_int)
12272 (insert_type_address_space, pop_type, pop_type_int)
12273 (pop_typelist, pop_type_stack, append_type_stack)
12274 (push_type_stack, get_type_stack, push_typelist)
12275 (follow_type_instance_flags, follow_types): Remove (moved to
12276 type-stack.c).
12277 * f-exp.y (type_stack): New global.
12278 Update rules.
12279 (push_kind_type, f_parse): Update.
12280 * d-exp.y (type_stack): New global.
12281 Update rules.
12282 (d_parse): Update.
12283 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12284 Update rules.
12285 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12286 (HFILES_NO_SRCDIR): Add type-stack.h.
12287
12288 2019-04-04 Tom Tromey <tom@tromey.com>
12289
12290 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12291 (rust_parser::convert_ast_to_expression, rust_parse)
12292 (rust_lex_test_completion, rust_lex_tests): Update.
12293 * parser-defs.h (struct expr_completion_state): New.
12294 (struct parser_state) <parser_state>: Add completion parameter.
12295 <mark_struct_expression, mark_completion_tag>: New methods.
12296 <parse_completion, m_completion_state>: New members.
12297 (prefixify_expression, null_post_parser): Update.
12298 (mark_struct_expression, mark_completion_tag): Don't declare.
12299 * parse.c (parse_completion, expout_last_struct)
12300 (expout_tag_completion_type, expout_completion_name): Remove
12301 globals.
12302 (parser_state::mark_struct_expression)
12303 (parser_state::mark_completion_tag): Now methods.
12304 (prefixify_expression): Add last_struct parameter.
12305 (prefixify_subexp): Likewise.
12306 (parse_exp_1): Update.
12307 (parse_exp_in_context): Add cstate parameter. Update.
12308 (parse_expression_for_completion): Create an
12309 expr_completion_state.
12310 (null_post_parser): Add "completion" parameter.
12311 * p-exp.y: Update rules.
12312 (yylex): Update.
12313 * language.h (struct language_defn) <la_post_parser>: Add
12314 "completing" parameter.
12315 * go-exp.y: Update rules.
12316 (lex_one_token): Update.
12317 * expression.h (parse_completion): Don't declare.
12318 * d-exp.y: Update rules.
12319 (lex_one_token): Update rules.
12320 * c-exp.y: Update rules.
12321 (lex_one_token): Update.
12322 * ada-lang.c (resolve): Add "parse_completion" parameter.
12323 (resolve_subexp): Likewise.
12324 (ada_resolve_function): Likewise.
12325
12326 2019-04-04 Tom Tromey <tom@tromey.com>
12327
12328 * parser-defs.h (struct parser_state) <start_arglist,
12329 end_arglist>: New methods.
12330 <arglist_len, m_funcall_chain>: New members.
12331 (arglist_len, start_arglist, end_arglist): Don't declare.
12332 * parse.c (arglist_len, funcall_chain): Remove global.
12333 (start_arglist, end_arglist): Remove functions.
12334 (parse_exp_in_context): Update.
12335 * p-exp.y: Update rules.
12336 * m2-exp.y: Update rules.
12337 * go-exp.y: Update rules.
12338 * f-exp.y: Update rules.
12339 * d-exp.y: Update rules.
12340 * c-exp.y: Update rules.
12341
12342 2019-04-04 Tom Tromey <tom@tromey.com>
12343
12344 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12345 lex_operator, push_back>: New methods.
12346 Update all rules.
12347 (rust_parser::lex_hex, lex_escape): Rename and update.
12348 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12349 (rust_parser::lex_operator): Rename and update.
12350 (rust_parser::lex_number, rustyylex, rustyyerror)
12351 (rust_lex_test_init, rust_lex_test_sequence)
12352 (rust_lex_test_push_back, rust_lex_tests): Update.
12353 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12354 parameter.
12355 <lexptr, prev_lexptr>: New members.
12356 (lexptr, prev_lexptr): Don't declare.
12357 * parse.c (lexptr, prev_lexptr): Remove globals.
12358 (parse_exp_in_context): Update.
12359 * p-exp.y (yylex, yyerror): Update.
12360 * m2-exp.y (parse_number, yylex, yyerror): Update.
12361 * go-exp.y (lex_one_token, yyerror): Update.
12362 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12363 * d-exp.y (lex_one_token, yyerror): Update.
12364 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12365 (lex_one_token, yyerror): Update.
12366 * ada-lex.l (YY_INPUT): Update.
12367 (rewind_to_char): Update.
12368 * ada-exp.y (yyerror): Update.
12369
12370 2019-04-04 Tom Tromey <tom@tromey.com>
12371
12372 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12373 * parser-defs.h (struct parser_state) <parser_state>: Add new
12374 parameter.
12375 <comma_terminates>: New member.
12376 (comma_terminates): Don't declare global.
12377 * parse.c (comma_terminates): Remove global.
12378 (parse_exp_in_context): Update.
12379 * p-exp.y (yylex): Update.
12380 * m2-exp.y (yylex): Update.
12381 * go-exp.y (lex_one_token): Update.
12382 * f-exp.y (yylex): Update.
12383 * d-exp.y (lex_one_token): Update.
12384 * c-exp.y (lex_one_token): Update.
12385 * ada-lex.l: Update.
12386
12387 2019-04-04 Tom Tromey <tom@tromey.com>
12388
12389 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12390 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12391 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12392 * parser-defs.h (paren_depth): Don't declare.
12393 * parse.c (paren_depth): Remove global.
12394 (parse_exp_in_context): Update.
12395 * p-exp.y (paren_depth): New global.
12396 (pascal_parse): Initialize it.
12397 * m2-exp.y (paren_depth): New global.
12398 (m2_parse): Initialize it.
12399 * go-exp.y (paren_depth): New global.
12400 (go_parse): Initialize it.
12401 * f-exp.y (paren_depth): New global.
12402 (f_parse): Initialize it.
12403 * d-exp.y (paren_depth): New global.
12404 (d_parse): Initialize it.
12405 * c-exp.y (paren_depth): New global.
12406 (c_parse): Initialize it.
12407 * ada-lex.l (paren_depth): New global.
12408 (lexer_init): Initialize it.
12409
12410 2019-04-04 Tom Tromey <tom@tromey.com>
12411
12412 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12413 (rust_parser::convert_ast_to_type)
12414 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12415 * parser-defs.h (struct parser_state) <parser_state>: Add
12416 parameters. Initialize new members.
12417 <expression_context_block, expression_context_pc>: New members.
12418 * parse.c (expression_context_block, expression_context_pc):
12419 Remove globals.
12420 (parse_exp_in_context): Update.
12421 * p-exp.y: Update all rules.
12422 (yylex): Update.
12423 * m2-exp.y: Update all rules.
12424 (yylex): Update.
12425 * go-exp.y (yylex): Update.
12426 * f-exp.y (yylex): Update.
12427 * d-exp.y: Update all rules.
12428 (yylex): Update.
12429 * c-exp.y: Update all rules.
12430 (lex_one_token, classify_name, yylex, c_parse): Update.
12431 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12432
12433 2019-04-04 Tom Tromey <tom@tromey.com>
12434
12435 * gdbarch.h, gdbarch.c: Rebuild.
12436 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12437 * stap-probe.h:
12438 (struct stap_parse_info): Replace "parser_state" with
12439 "expr_builder".
12440 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12441 (parser_state): New class.
12442 * parse.c (expr_builder): Rename.
12443 (expr_builder::release): Rename.
12444 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12445 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12446 (write_exp_elt_longcst, write_exp_elt_floatcst)
12447 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12448 (write_exp_string_vector, write_exp_bitstring)
12449 (write_exp_msymbol, mark_struct_expression)
12450 (write_dollar_variable)
12451 (insert_type_address_space, increase_expout_size): Replace
12452 "parser_state" with "expr_builder".
12453 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12454 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12455 "parser_state" with "expr_builder".
12456
12457 2019-04-04 Tom Tromey <tom@tromey.com>
12458
12459 * rust-exp.y: Replace "parse_language" with method call.
12460 * p-exp.y:
12461 (yylex): Replace "parse_language" with method call.
12462 * m2-exp.y:
12463 (yylex): Replace "parse_language" with method call.
12464 * go-exp.y (classify_name): Replace "parse_language" with method
12465 call.
12466 * f-exp.y (yylex): Replace "parse_language" with method call.
12467 * d-exp.y (lex_one_token): Replace "parse_language" with method
12468 call.
12469 * c-exp.y:
12470 (lex_one_token, classify_name, yylex): Replace "parse_language"
12471 with method call.
12472 * ada-exp.y (find_primitive_type, type_char)
12473 (type_system_address): Replace "parse_language" with method call.
12474
12475 2019-04-04 Tom Tromey <tom@tromey.com>
12476
12477 * rust-exp.y: Replace "parse_gdbarch" with method call.
12478 * parse.c (write_dollar_variable, insert_type_address_space):
12479 Replace "parse_gdbarch" with method call.
12480 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12481 call.
12482 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12483 call.
12484 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12485 "parse_gdbarch" with method call.
12486 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12487 with method call.
12488 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12489 "parse_gdbarch" with method call.
12490 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12491 "parse_gdbarch" with method call.
12492 * c-exp.y (parse_type, parse_number, classify_name): Replace
12493 "parse_gdbarch" with method call.
12494 * ada-lex.l: Replace "parse_gdbarch" with method call.
12495 * ada-exp.y (parse_type, find_primitive_type, type_char)
12496 (type_system_address): Replace "parse_gdbarch" with method call.
12497
12498 2019-04-04 Tom Tromey <tom@tromey.com>
12499
12500 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12501 * stap-probe.c (stap_parse_argument): Update.
12502 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12503 initial_size parameter.
12504 * rust-exp.y (rust_lex_tests): Update.
12505 * parse.c (parser_state): Update.
12506 (parse_exp_in_context): Update.
12507 * parser-defs.h (struct parser_state) <parser_state>: Remove
12508 "initial_size" parameter.
12509
12510 2019-04-04 Tom Tromey <tom@tromey.com>
12511
12512 * parser-defs.h (increase_expout_size): Don't declare.
12513 * parse.c (increase_expout_size): Now static.
12514
12515 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12516
12517 * gnu-nat.c (gnu_nat_target::wait): Fix
12518 target_waitstatus_to_string call.
12519
12520 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12521
12522 * eval.c (evaluate_subexp_standard): Handle internal functions
12523 during Fortran function call handling.
12524
12525 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12526
12527 * NEWS: Mention new internal functions.
12528 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12529 (read_base_type): Use dwarf2_init_complex_target_type.
12530 * value.c (creal_internal_fn): New function.
12531 (cimag_internal_fn): New function.
12532 (_initialize_values): Register new internal functions.
12533
12534 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12535
12536 * infrun.c (stop_all_threads): If debug_infrun, always
12537 trace the wait status after wait_one, using
12538 target_waitstatus_to_string and target_pid_to_str.
12539 (handle_inferior_event): Replace various trace of
12540 wait status kind by a single trace.
12541 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12542 wait status kind image by target_waitstatus_to_string.
12543 * target/waitstatus.c (target_waitstatus_to_string): Fix
12544 obsolete comment.
12545
12546 2019-04-01 Tom Tromey <tromey@adacore.com>
12547
12548 PR symtab/23331:
12549 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12550
12551 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12552 Pedro Alves <palves@redhat.com>
12553
12554 * top.c (quit_force): Call 'finalize_values'.
12555 * value.c (finalize_values): New function.
12556 * value.h (finalize_values): Declare.
12557
12558 2019-03-30 Eli Zaretskii <eliz@gnu.org>
12559
12560 * NEWS: Announce $_gdb_major and $_gdb_minor.
12561
12562 * top.c (init_gdb_version_vars): New function.
12563 (gdb_init): Call init_gdb_version_vars.
12564
12565 2019-03-29 Tom Tromey <tromey@adacore.com>
12566
12567 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12568 help text. Remove dead code.
12569
12570 2019-03-29 Keith Seitz <keiths@redhat.com>
12571
12572 From Siddhesh Poyarekar:
12573 * f-lang.h (f77_get_upperbound): Return LONGEST.
12574 (f77_get_lowerbound): Likewise.
12575 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12576 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12577 print them.
12578 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12579 plongest to format print it.
12580 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12581 (f77_get_upperbound): Likewise.
12582 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12583 LOWER_BOUND to LONGEST.
12584 (f77_create_arrayprint_offset_tbl): Likewise.
12585
12586 2019-03-29 Keith Seitz <keiths@redhat.com>
12587
12588 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12589 %s/pulongest for TYPE_LENGTH instead of %d in format
12590 strings.
12591 * ada-typerint.c (ada_print_type): Likewise.
12592 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12593 * compile/compile-c-support.c (generate_register_struct): Likewise.
12594 * gdbtypes.c (recursive_dump_type): Likewise.
12595 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12596 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12597 instead of %d in format strings.
12598 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12599 to std::min to ULONGEST.
12600 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12601 instead of %d in format strings.
12602 * tracepoint.c (info_scope_command): Likewise.
12603 * typeprint.c (print_offset_data::update)
12604 (print_offset_data::finish): Likewise.
12605 * xtensa-tdep.c (xtensa_store_return_value)
12606 (xtensa_push_dummy_call): Likewise.
12607
12608 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12609
12610 * windows-nat.c (display_selector): Fixed format specifications
12611 for 64-bit Cygwin.
12612
12613 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12614
12615 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12616
12617 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12618
12619 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12620 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12621 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12622 (nios2_linux_init_abi): Install it.
12623
12624 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12625
12626 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12627
12628 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12629
12630 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12631
12632 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12633 Tom Tromey <tromey@adacore.com>
12634
12635 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12636
12637 2019-03-26 Joel Brobecker <brobecker@adacore.com>
12638
12639 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12640 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12641 method to compute the bounds of range types. Also print "[evaluated]"
12642 if the bounds' values come from a dynamic evaluation.
12643
12644 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12645
12646 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12647 whitespace when pretty printing is on.
12648
12649 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12650
12651 * ppc-linux-nat.c: Add include.
12652
12653 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12654
12655 * NEWS: Mention AArch64 Pointer Authentication.
12656
12657 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12658
12659 * arm-linux-nat.c: Add include.
12660
12661 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12662
12663 * source-cache.c (source_cache::get_source_lines): Re-read
12664 fullname after calling open_source_file.
12665
12666 2019-03-25 John Baldwin <jhb@FreeBSD.org>
12667
12668 * NEWS: Mention TLS support for FreeBSD.
12669
12670 2019-03-25 Tom Tromey <tromey@adacore.com>
12671
12672 * minsyms.c (BUNCH_SIZE): Update comment.
12673 (~minimal_symbol_reader): Remove old comment.
12674 (compact_minimal_symbols): Update comment.
12675 (minimal_symbol_reader::install): Remove old comment. Update
12676 other comments.
12677
12678 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12679
12680 * s390-linux-nat.c: Add include.
12681
12682 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12683
12684 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12685 Call linux_get_hwcap.
12686 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12687 Likewise.
12688 (aarch64_linux_get_hwcap): Remove function.
12689 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12690 declaration.
12691 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12692 linux_get_hwcap.
12693 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12694 * linux-tdep.c (linux_get_hwcap): Add function.
12695 (linux_get_hwcap2): Likewise.
12696 * linux-tdep.h (linux_get_hwcap): Add declaration.
12697 (linux_get_hwcap2): Likewise.
12698 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12699 (ppc_linux_get_hwcap2): Likewise.
12700 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12701 linux_get_hwcap.
12702 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12703 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12704 (ppc_linux_nat_target::read_description): Likewise.
12705 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12706 * s390-linux-nat.c: Likewise.
12707 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12708
12709 2019-03-24 Tom Tromey <tom@tromey.com>
12710
12711 * ada-lang.c (standard_lookup): Simplify initialization.
12712 (ada_lookup_symbol_nonlocal): Simplify return.
12713 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12714 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12715 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12716 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12717 initialization.
12718 * solib.c (solib_global_lookup): Simplify.
12719 * symtab.c (null_block_symbol): Remove.
12720 (symbol_cache_lookup): Simplify returns.
12721 (lookup_language_this): Simplify returns.
12722 (lookup_symbol_aux): Simplify return.
12723 (lookup_local_symbol): Simplify returns.
12724 (lookup_global_symbol_from_objfile): Simplify return.
12725 (lookup_symbol_in_objfile_symtabs)
12726 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12727 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12728 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12729 * cp-namespace.c (cp_lookup_bare_symbol)
12730 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12731 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12732 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12733 (cp_lookup_symbol_via_imports): Simplify initialization.
12734 (find_symbol_in_baseclass): Likewise.
12735 * symtab.h (null_block_symbol): Remove.
12736 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12737 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12738 (d_lookup_symbol_module): Likewise.
12739 (find_symbol_in_baseclass): Simplify initialization.
12740
12741 2019-03-24 Tom Tromey <tom@tromey.com>
12742
12743 * expression.h: Don't include symtab.h.
12744 (struct block): Forward declare.
12745
12746 2019-03-24 Tom Tromey <tom@tromey.com>
12747
12748 * c-exp.y (typebase): Remove casts.
12749 * gdbtypes.c (lookup_unsigned_typename, )
12750 (lookup_signed_typename): Remove cast.
12751 * eval.c (parse_to_comma_and_eval): Remove cast.
12752 * parse.c (write_dollar_variable): Remove cast.
12753 * block.h (struct block) <superblock>: Now const.
12754 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12755 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12756 (map_block): Make "block" const.
12757 * symfile.h (struct quick_symbol_functions)
12758 <map_matching_symbols>: Constify block argument to "callback".
12759 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12760 const.
12761 (find_pc_sect_compunit_symtab): Make "b" const.
12762 (find_symbol_at_address): Likewise.
12763 (search_symbols): Likewise.
12764 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12765 (dw2_debug_names_lookup_symbol): Likewise.
12766 (dw2_map_matching_symbols): Update.
12767 * p-valprint.c (pascal_val_print): Remove "block".
12768 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12769 (aux_add_nonlocal_symbols): Make "block" const.
12770 (resolve_subexp): Remove cast.
12771 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12772 const.
12773 (iterate_over_file_blocks): Likewise.
12774 * f-exp.y (%union) <bval>: Remove.
12775 * coffread.c (patch_opaque_types): Make "b" const.
12776 * spu-tdep.c (spu_catch_start): Make "block" const.
12777 * c-valprint.c (print_unpacked_pointer): Remove "block".
12778 * symmisc.c (dump_symtab_1): Make "b" const.
12779 (block_depth): Make "block" const.
12780 * d-exp.y (%union) <bval>: Remove.
12781 * cp-support.h (cp_lookup_rtti_type): Update.
12782 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12783 * psymtab.c (psym_lookup_symbol): Make "block" const.
12784 (maintenance_check_psymtabs): Make "b" const.
12785 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12786 (enumerate_locals, enumerate_args): Update.
12787 * python/py-symtab.c (stpy_global_block): Make "block" const.
12788 (stpy_static_block): Likewise.
12789 * inline-frame.c (block_starting_point_at): Make "new_block"
12790 const.
12791 * block.c (find_block_in_blockvector): Make return type const.
12792 (blockvector_for_pc_sect): Make "b" const.
12793 (find_block_in_blockvector): Make "b" const.
12794
12795 2019-03-23 Tom Tromey <tom@tromey.com>
12796
12797 * varobj.c (varobj_create): Update.
12798 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12799 * printcmd.c (display_command, do_one_display): Don't reset
12800 innermost_block.
12801 * parser-defs.h (enum innermost_block_tracker_type): Move to
12802 expression.h.
12803 (innermost_block): Update comment.
12804 * parse.c (parse_exp_1): Add tracker_types parameter.
12805 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12806 tracker_types parameter. Reset innermost_block.
12807 (parse_exp_in_context): Remove.
12808 (parse_expression_for_completion): Update.
12809 * objfiles.c (~objfile): Don't reset expression_context_block or
12810 innermost_block.
12811 * expression.h (enum innermost_block_tracker_type): Move from
12812 parser-defs.h.
12813 (parse_exp_1): Add tracker_types parameter.
12814 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12815 reset innermost_block.
12816
12817 2019-03-23 Tom Tromey <tom@tromey.com>
12818
12819 * objfiles.h: Include bcache.h.
12820
12821 2019-03-23 Tom Tromey <tom@tromey.com>
12822
12823 * linespec.c (get_current_search_block): Use
12824 scoped_restore_current_language.
12825 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12826
12827 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12828 Jiong Wang <jiong.wang@arm.com>
12829
12830 * aarch64-linux-tdep.c
12831 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12832 section.
12833 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12834
12835 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12836 Jiong Wang <jiong.wang@arm.com>
12837
12838 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12839 instructions.
12840 (aarch64_analyze_prologue_test): Add PACIASP test.
12841 (aarch64_prologue_prev_register): Unmask PC value.
12842
12843 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12844 Jiong Wang <jiong.wang@arm.com>
12845
12846 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12847 (aarch64_dwarf2_prev_register): Unmask PC value.
12848 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12849 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12850 DW_CFA_AARCH64_negate_ra_state.
12851 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12852
12853 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12854 Jiong Wang <jiong.wang@arm.com>
12855
12856 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12857 registers.
12858 (aarch64_pseudo_register_name): Likewise.
12859 (aarch64_pseudo_register_type): Likewise.
12860 (aarch64_pseudo_register_reggroup_p): Likewise.
12861 (aarch64_gdbarch_init): Add pauth registers.
12862 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12863 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12864 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12865 (struct gdbarch_tdep): Add regnum for ra_state.
12866
12867 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12868 Jiong Wang <jiong.wang@arm.com>
12869
12870 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12871
12872 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12873 Jiong Wang <jiong.wang@arm.com>
12874
12875 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12876 function.
12877 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12878 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12879 (aarch64_gdbarch_init): Add puth registers.
12880 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12881 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12882 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12883
12884 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12885 Jiong Wang <jiong.wang@arm.com>
12886
12887 * aarch64-linux-nat.c
12888 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12889 * aarch64-linux-tdep.c
12890 (aarch64_linux_core_read_description): Likewise.
12891 (aarch64_linux_get_hwcap): New function.
12892 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12893 (aarch64_linux_get_hwcap): New declaration.
12894
12895 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12896 Jiong Wang <jiong.wang@arm.com>
12897
12898 * aarch64-linux-nat.c
12899 (aarch64_linux_nat_target::read_description): Add pauth param.
12900 * aarch64-linux-tdep.c
12901 (aarch64_linux_core_read_description): Likewise.
12902 * aarch64-tdep.c (struct target_desc): Add in pauth.
12903 (aarch64_read_description): Add pauth param.
12904 (aarch64_gdbarch_init): Likewise.
12905 * aarch64-tdep.h (aarch64_read_description): Likewise.
12906 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12907 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12908 * features/Makefile: Add new files.
12909 * features/aarch64-pauth.c: New file.
12910 * features/aarch64-pauth.xml: New file.
12911
12912 2019-03-20 Tom Tromey <tromey@adacore.com>
12913
12914 * infrun.c (handle_inferior_event): Rename from
12915 handle_inferior_event_1. Create a scoped_value_mark.
12916 (handle_inferior_event): Remove.
12917
12918 2019-03-19 Tom Tromey <tromey@adacore.com>
12919
12920 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12921 * infrun.h (print_stop_event): Add "displays" parameter.
12922 * infrun.c (print_stop_event): Add "displays" parameter.
12923
12924 2019-03-19 Pedro Alves <palves@redhat.com>
12925
12926 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12927 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12928 to -1. Fix TABs vs spaces.
12929 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12930 * tui/tui-out.h (tui_ui_out) Add intro comments.
12931 <m_line, m_start_of_line>: In-class initialize, and add describing
12932 comment.
12933
12934 2019-03-18 Alan Hayward <alan.hayward@arm.com>
12935
12936 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12937 variable names.
12938 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12939
12940 2019-03-18 Pedro Alves <palves@redhat.com>
12941 Eli Zaretskii <eliz@gnu.org>
12942
12943 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12944 m_line and m_start_of_line.
12945
12946 2019-03-18 Eli Zaretskii <eliz@gnu.org>
12947
12948 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12949 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12950 it returns a newline. This fixes a regression in TU mode, whereby
12951 the next line is output on the same screen line as the user input.
12952
12953 2019-03-18 Tom Tromey <tromey@adacore.com>
12954
12955 * minsyms.c (minimal_symbol_reader::install): Remove call to
12956 obstack_blank.
12957
12958 2019-03-18 Pedro Alves <palves@redhat.com>
12959
12960 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12961 New globals.
12962 (apply_style): New, factored out from ...
12963 (apply_ansi_escape): ... this. Handle reverse video mode.
12964 (tui_set_reverse_mode): New function.
12965 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12966 * tui/tui-winsource.c (tui_show_source_line): Use
12967 tui_set_reverse_mode instead of setting A_STANDOUT.
12968 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12969 New setter methods.
12970
12971 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
12972
12973 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12974 Handle tabs.
12975
12976 2019-03-18 Tom Tromey <tromey@adacore.com>
12977
12978 * ada-lang.c (empty_array): Add "high" parameter.
12979 (ada_evaluate_subexp): Update.
12980
12981 2019-03-17 Sergei Trofimovich <siarheit@google.com>
12982
12983 * unittests/string_view-selftests.c: Define
12984 _initialize_string_view_selftests unconditionally.
12985
12986 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12987
12988 PR gdb/24350
12989 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12990
12991 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12992
12993 PR gdb/24351
12994 * windows-nat.c (display_selector): Fix format specifiers.
12995
12996 2019-03-17 Eli Zaretskii <eliz@gnu.org>
12997
12998 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12999 tui_refill_source_window instead of tui_refresh_win, to update the
13000 current execution line. This fixes redisplay of the current line
13001 when stepping through the code with "next" or "step".
13002
13003 2019-03-16 Eli Zaretskii <eliz@gnu.org>
13004
13005 * source-cache.c (source_cache::get_source_lines): Call
13006 find_source_lines to initialize s->nlines. This fixes vertical
13007 scrolling of TUI source window when the DOWN arrow is pressed.
13008
13009 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13010
13011 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13012 linux-thread-db.c (_initialize_thread_db): Likewise.
13013
13014 2019-03-16 Eli Zaretskii <eliz@gnu.org>
13015
13016 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13017 wclrtoeol in tui_show_source_line". This reverts changes made in
13018 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13019
13020 2019-03-15 Tom Tromey <tom@tromey.com>
13021
13022 * symtab.h (struct minimal_symbol): Derive from
13023 general_symbol_info.
13024 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13025 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13026 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13027 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13028 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13029 (MSYMBOL_SEARCH_NAME): Update.
13030 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13031 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13032 * minsyms.c (minimal_symbol_reader::record_full): Update.
13033
13034 2019-03-15 Tom Tromey <tom@tromey.com>
13035
13036 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13037
13038 2019-03-15 Tom Tromey <tom@tromey.com>
13039
13040 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13041 unique_xmalloc_ptr.
13042 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13043 Update.
13044 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13045 (build_minimal_symbol_hash_tables)
13046 (minimal_symbol_reader::install): Update.
13047
13048 2019-03-15 Tom Tromey <tom@tromey.com>
13049
13050 * symtab.c (create_demangled_names_hash): Update.
13051 (symbol_set_names): Update.
13052 * objfiles.h (struct objfile_per_bfd_storage)
13053 <demangled_names_hash>: Now an htab_up.
13054 * objfiles.c (objfile_per_bfd_storage): Simplify.
13055
13056 2019-03-15 Tom Tromey <tom@tromey.com>
13057
13058 * objfiles.h (struct objfile_per_bfd_storage): Declare
13059 destructor.
13060 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13061 New.
13062 (get_objfile_bfd_data): Use new. Don't initialize
13063 language_of_main.
13064 (free_objfile_per_bfd_storage): Remove.
13065 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13066
13067 2019-03-15 Tom Tromey <tom@tromey.com>
13068
13069 * symfile.c (reread_symbols): Update.
13070 * objfiles.c (objfile::objfile): Update.
13071 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13072 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13073 comment.
13074 (minimal_symbol_reader::install): Update.
13075 (terminate_minimal_symbol_table): Remove.
13076 * jit.c (jit_object_close_impl): Update.
13077
13078 2019-03-15 Tom Tromey <tom@tromey.com>
13079
13080 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13081 initializations.
13082
13083 2019-03-15 Tom Tromey <tom@tromey.com>
13084
13085 * objfiles.h (struct objfile_per_bfd_storage)
13086 <demangled_hash_languages>: Now a bitset.
13087 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13088 (lookup_minimal_symbol): Update.
13089
13090 2019-03-15 Tom Tromey <tom@tromey.com>
13091
13092 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13093 Don't return the symbol.
13094 * coffread.c (record_minimal_symbol): Use record_full.
13095
13096 2019-03-14 Eli Zaretskii <eliz@gnu.org>
13097
13098 The MS-Windows port of ncurses fails to switch to a color pair if
13099 one or both of the colors are the implicit default colors. This
13100 change records the default colors when TUI is initialized, and
13101 then specifies them explicitly when a color pair uses the default
13102 colors. This allows color styling in TUI mode on MS-Windows.
13103
13104 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13105 ncurses_norm_attr.
13106 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13107 colors in ncurses_norm_attr.
13108 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13109 "none", replace it with the default color recorded in
13110 ncurses_norm_attr.
13111
13112 2019-03-14 Tom Tromey <tromey@adacore.com>
13113
13114 * source-cache.h (class source_cache) <get_source_lines>: Return
13115 std::string.
13116 * source-cache.c (source_cache::extract_lines): Handle case where
13117 first_pos==npos. Return std::string.
13118 (source_cache::get_source_lines): Update.
13119
13120 2019-03-14 Tom Tromey <tromey@adacore.com>
13121
13122 * NEWS: Add item for "style sources" commands.
13123 * source-cache.c (source_cache::get_source_lines): Check
13124 source_styling.
13125 * cli/cli-style.c (source_styling): New global.
13126 (_initialize_cli_style): Add "style sources" commands.
13127 (show_style_sources): New function.
13128 * cli/cli-style.h (source_styling): Declare.
13129
13130 2019-03-14 Pedro Alves <palves@redhat.com>
13131 Tom Tromey <tromey@adacore.com>
13132
13133 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13134 * tui/tui-winsource.c (tui_refill_source_window): New function,
13135 from...
13136 (tui_horizontal_source_scroll): ... here. Move some logic.
13137 * cli/cli-style.c (set_style_enabled): Notify new observable.
13138 * tui/tui-hooks.c (tui_redisplay_source): New function.
13139 (tui_attach_detach_observers): Attach or detach
13140 tui_redisplay_source.
13141 * observable.h (source_styling_changed): New observable.
13142 * observable.c: Define source_styling_changed observable.
13143
13144 2019-03-13 Tom Tromey <tromey@adacore.com>
13145
13146 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13147 (i386_gnu_nat_target::store_registers): Update.
13148 * target-debug.h (target_debug_print_std_string): New macro.
13149 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13150 * windows-tdep.c (display_one_tib): Update.
13151 * tui/tui-stack.c (tui_make_status_line): Update.
13152 * top.c (print_inferior_quit_action): Update.
13153 * thread.c (thr_try_catch_cmd): Update.
13154 (add_thread_with_info): Update.
13155 (thread_target_id_str): Update.
13156 (thr_try_catch_cmd): Update.
13157 (thread_command): Update.
13158 (thread_find_command): Update.
13159 * record-btrace.c (record_btrace_target::info_record)
13160 (record_btrace_resume_thread, record_btrace_target::resume)
13161 (record_btrace_cancel_resume, record_btrace_step_thread)
13162 (record_btrace_target::wait, record_btrace_target::wait)
13163 (record_btrace_target::wait, record_btrace_target::stop): Update.
13164 * progspace.c (print_program_space): Update.
13165 * process-stratum-target.c
13166 (process_stratum_target::thread_address_space): Update.
13167 * linux-fork.c (linux_fork_mourn_inferior)
13168 (detach_checkpoint_command, info_checkpoints_command)
13169 (linux_fork_context): Update.
13170 (linux_fork_detach): Update.
13171 (class scoped_switch_fork_info): Update.
13172 (delete_checkpoint_command): Update.
13173 * infrun.c (follow_fork_inferior): Update.
13174 (follow_fork_inferior): Update.
13175 (proceed_after_vfork_done): Update.
13176 (handle_vfork_child_exec_or_exit): Update.
13177 (follow_exec): Update.
13178 (displaced_step_prepare_throw): Update.
13179 (displaced_step_restore): Update.
13180 (start_step_over): Update.
13181 (resume_1): Update.
13182 (clear_proceed_status_thread): Update.
13183 (proceed): Update.
13184 (print_target_wait_results): Update.
13185 (do_target_wait): Update.
13186 (context_switch): Update.
13187 (stop_all_threads): Update.
13188 (restart_threads): Update.
13189 (finish_step_over): Update.
13190 (handle_signal_stop): Update.
13191 (switch_back_to_stepped_thread): Update.
13192 (keep_going_pass_signal): Update.
13193 (print_exited_reason): Update.
13194 (normal_stop): Update.
13195 * inferior.c (inferior_pid_to_str): Change return type.
13196 (print_selected_inferior): Update.
13197 (add_inferior): Update.
13198 (detach_inferior): Update.
13199 * dummy-frame.c (fprint_dummy_frames): Update.
13200 * dcache.c (dcache_info_1): Update.
13201 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13202 (btrace_fetch, btrace_clear): Update.
13203 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13204 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13205 type.
13206 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13207 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13208 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13209 * gdbarch.c, gdbarch.h: Rebuild.
13210 * gdbarch.sh (core_pid_to_str): Change return type.
13211 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13212 return type.
13213 (windows_nat_target::pid_to_str): Change return type.
13214 (windows_delete_thread): Update.
13215 (windows_nat_target::attach): Update.
13216 (windows_nat_target::files_info): Update.
13217 * target-delegates.c: Rebuild.
13218 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13219 return type.
13220 (sol_thread_target::pid_to_str): Change return type.
13221 * remote.c (class remote_target) <pid_to_str>: Change return
13222 type.
13223 (remote_target::pid_to_str): Change return type.
13224 (extended_remote_target::attach, remote_target::remote_stop_ns)
13225 (remote_target::remote_notif_remove_queued_reply)
13226 (remote_target::push_stop_reply, remote_target::disable_btrace):
13227 Update.
13228 (extended_remote_target::attach): Update.
13229 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13230 type.
13231 (gdbsim_target::pid_to_str): Change return type.
13232 * ravenscar-thread.c (struct ravenscar_thread_target)
13233 <pid_to_str>: Change return type.
13234 (ravenscar_thread_target::pid_to_str): Change return type.
13235 * procfs.c (class procfs_target) <pid_to_str>: Change return
13236 type.
13237 (procfs_target::pid_to_str): Change return type.
13238 (procfs_target::attach): Update.
13239 (procfs_target::detach): Update.
13240 (procfs_target::fetch_registers): Update.
13241 (procfs_target::store_registers): Update.
13242 (procfs_target::wait): Update.
13243 (procfs_target::files_info): Update.
13244 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13245 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13246 return type.
13247 (nto_procfs_target::pid_to_str): Change return type.
13248 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13249 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13250 return type.
13251 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13252 (exit_lwp): Update.
13253 (attach_proc_task_lwp_callback, get_detach_signal)
13254 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13255 (linux_nat_target::resume, wait_lwp, stop_callback)
13256 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13257 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13258 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13259 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13260 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13261 type.
13262 (inf_ptrace_target::attach): Update.
13263 (inf_ptrace_target::files_info): Update.
13264 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13265 type.
13266 (go32_nat_target::pid_to_str): Change return type.
13267 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13268 (gnu_nat_target::wait): Update.
13269 (gnu_nat_target::wait): Update.
13270 (gnu_nat_target::resume): Update.
13271 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13272 (fbsd_nat_target::wait): Update.
13273 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13274 type.
13275 (darwin_nat_target::attach): Update.
13276 * corelow.c (class core_target) <pid_to_str>: Change return type.
13277 (core_target::pid_to_str): Change return type.
13278 * target.c (normal_pid_to_str): Change return type.
13279 (default_pid_to_str): Likewise.
13280 (target_pid_to_str): Change return type.
13281 (target_translate_tls_address): Update.
13282 (target_announce_detach): Update.
13283 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13284 return type.
13285 (bsd_uthread_target::pid_to_str): Change return type.
13286 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13287 type.
13288 (bsd_kvm_target::pid_to_str): Change return type.
13289 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13290 return type.
13291 (aix_thread_target::pid_to_str): Change return type.
13292 * target.h (struct target_ops) <pid_to_str>: Change return type.
13293 (target_pid_to_str, normal_pid_to_str): Likewise.
13294 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13295 type.
13296 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13297 type.
13298 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13299 return type.
13300 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13301 type.
13302 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13303 type.
13304 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13305 return type.
13306
13307 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13308
13309 * NEWS: Mention that the new default MI version is 3. Mention
13310 changes to the output of commands and events that deal with
13311 multi-location breakpoints.
13312 * breakpoint.c: Include "mi/mi-out.h".
13313 (print_one_breakpoint): Change output syntax if using MI version
13314 >= 3.
13315 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13316 New.
13317 (mi_multi_location_breakpoint_output_fixed): New.
13318 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13319 (mi_cmd_fix_multi_location_breakpoint_output): New.
13320 (mi_multi_location_breakpoint_output_fixed): New.
13321 * mi/mi-cmds.c (mi_cmds): Register command
13322 -fix-multi-location-breakpoint-output.
13323 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13324 interpreter "mi".
13325
13326 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13327
13328 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13329 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13330 instantiate mi_ui_out based on interpreter name.
13331 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13332 * mi/mi-main.c (mi_load_progress): Likewise.
13333
13334 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13335
13336 * NEWS: Combine separate "New targets" sections for 8.3.
13337
13338 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13339
13340 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13341 (ppcfbsd_init_abi): Install gdbarch
13342 "fetch_tls_load_module_address" and "get_thread_local_address"
13343 methods.
13344
13345 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13346
13347 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13348 (riscv_fbsd_init_abi): Install gdbarch
13349 "fetch_tls_load_module_address" and "get_thread_local_address"
13350 methods.
13351
13352 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13353
13354 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13355 (i386fbsd_init_abi): Install gdbarch
13356 "fetch_tls_load_module_address" and "get_thread_local_address"
13357 methods.
13358
13359 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13360
13361 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13362 (amd64fbsd_init_abi): Install gdbarch
13363 "fetch_tls_load_module_address" and "get_thread_local_address"
13364 methods.
13365
13366 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13367
13368 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13369 (struct fbsd_pspace_data): New type.
13370 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13371 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13372 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13373 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13374 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13375
13376 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13377
13378 * gdbtypes.c (lookup_struct_elt): New function.
13379 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13380 * gdbtypes.h (struct struct_elt): New type.
13381 (lookup_struct_elt): New prototype.
13382
13383 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13384
13385 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13386 remove disabled code block.
13387
13388 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13389
13390 * gdbarch.sh (get_thread_local_address): New method.
13391 * gdbarch.h, gdbarch.c: Regenerate.
13392 * target.c (target_translate_tls_address): Use
13393 gdbarch_get_thread_local_address if present instead of
13394 target::get_thread_local_address.
13395
13396 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13397
13398 * target.h (target::get_thread_local_address): Update comment.
13399
13400 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13401
13402 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13403 objfile->separate_debug_objfile_backlink if not NULL.
13404
13405 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13406
13407 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13408 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13409 (amd64bsd_store_inferior_registers): Likewise.
13410 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13411 Enable segment base registers.
13412 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13413 PT_GETFSBASE and PT_GETGSBASE.
13414 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13415 PT_SETGSBASE.
13416 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13417 segment base registers.
13418 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13419
13420 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13421
13422 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13423 Update calls to i386_target_description to add 'segments'
13424 parameter.
13425 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13426 add segment base registers.
13427 * arch/i386.c (i386_create_target_description): Add 'segments'
13428 parameter to enable segment base registers.
13429 * arch/i386.h (i386_create_target_description): Likewise.
13430 * features/i386/32bit-segments.xml: New file.
13431 * features/i386/32bit-segments.c: Generate.
13432 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13433 call to i386_target_description to add 'segments' parameter.
13434 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13435 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13436 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13437 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13438 if feature is present.
13439 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13440 Add 'segments' parameter to call to i386_target_description.
13441 (i386_target_description): Add 'segments' parameter to enable
13442 segment base registers.
13443 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13444 to call to i386_target_description.
13445 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13446 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13447 Define I386_NUM_REGS.
13448 (i386_target_description): Add 'segments' parameter to enable
13449 segment base registers.
13450
13451 2019-03-12 Eli Zaretskii <eliz@gnu.org>
13452
13453 PR/24325
13454 * source-cache.c: #undef open and close, to avoid unresolved
13455 externals during linking.
13456
13457 2019-03-12 Tom Tromey <tromey@adacore.com>
13458
13459 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13460 const. Add initializers.
13461 (_initialize_remote): Don't initialize ptid globals.
13462
13463 2019-03-12 Pedro Alves <palves@redhat.com>
13464
13465 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13466
13467 2019-03-12 Pedro Alves <palves@redhat.com>
13468
13469 * cp-name-parser.y (main): Remove unused 'len' variable.
13470
13471 2019-03-12 Tom Tromey <tromey@adacore.com>
13472
13473 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13474 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13475
13476 2019-03-12 Tom Tromey <tromey@adacore.com>
13477
13478 * linux-nat.c (iterate_over_lwps): Update.
13479 (stop_callback): Remove parameter.
13480 (stop_wait_callback, detach_callback, resume_set_callback)
13481 (select_singlestep_lwp_callback, set_ignore_sigint)
13482 (status_callback, resumed_callback, resume_clear_callback)
13483 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13484 data parameter.
13485 (linux_nat_target::detach, linux_nat_target::resume)
13486 (linux_stop_and_wait_all_lwps, select_event_lwp)
13487 (linux_nat_filter_event, linux_nat_wait_1)
13488 (linux_nat_target::kill, linux_nat_target::stop)
13489 (linux_nat_target::stop): Update.
13490 (linux_nat_resume_callback): Change type.
13491 (resume_stopped_resumed_lwps, count_events_callback)
13492 (select_event_lwp_callback): Likewise.
13493 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13494 * arm-linux-nat.c (struct update_registers_data): Remove.
13495 (update_registers_callback): Change type.
13496 (arm_linux_insert_hw_breakpoint1): Update.
13497 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13498 parameter.
13499 (x86_linux_dr_set_addr): Update.
13500 (x86_linux_dr_set_control): Update.
13501 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13502 (iterate_over_lwps): Use gdb::function_view.
13503 * nat/aarch64-linux-hw-point.c (struct
13504 aarch64_dr_update_callback_param): Remove.
13505 (debug_reg_change_callback): Change type.
13506 (aarch64_notify_debug_reg_change): Update.
13507 * s390-linux-nat.c (s390_refresh_per_info): Update.
13508
13509 2019-03-11 Tom Tromey <tromey@adacore.com>
13510
13511 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13512 redundant assignment to "this_cu".
13513
13514 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13515
13516 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13517
13518 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13519
13520 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13521 from...
13522 (rank_one_type): ... this.
13523
13524 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13525
13526 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13527 from...
13528 (rank_one_type): ... this.
13529
13530 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13531
13532 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13533 from...
13534 (rank_one_type): ... this.
13535
13536 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13537
13538 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13539 from...
13540 (rank_one_type): ... this.
13541
13542 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13543
13544 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13545 from...
13546 (rank_one_type): ... this.
13547
13548 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13549
13550 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13551 from...
13552 (rank_one_type): ... this.
13553
13554 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13555
13556 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13557 from...
13558 (rank_one_type): ... this.
13559
13560 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13561
13562 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13563 from...
13564 (rank_one_type): ... this.
13565
13566 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13567
13568 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13569 from...
13570 (rank_one_type): ... this.
13571
13572 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13573
13574 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13575 from...
13576 (rank_one_type): ... this.
13577
13578 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13579
13580 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13581 from...
13582 (rank_one_type): ... this.
13583
13584 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13585
13586 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13587 from...
13588 (rank_one_type): ... this.
13589
13590 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13591
13592 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13593 inferior-events' shows the example events.
13594
13595 2019-03-08 Eli Zaretskii <eliz@gnu.org>
13596
13597 Support styling on native MS-Windows console
13598
13599 PR/24315
13600 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13601 on MS-Windows if $TERM is not defined.
13602
13603 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13604
13605 * posix-hdep.c (gdb_console_fputs):
13606 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13607 functions.
13608 * ui-file.h (gdb_console_fputs): Add prototype.
13609
13610 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13611 back to fputs only if the former returns zero.
13612
13613 2019-03-07 Tom Tromey <tom@tromey.com>
13614
13615 * symmisc.c (print_symbol_bcache_statistics): Update.
13616 (print_objfile_statistics): Update.
13617 * symfile.c (allocate_symtab): Update.
13618 * stabsread.c: Don't include bcache.h.
13619 * psymtab.h (struct psymbol_bcache): Don't declare.
13620 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13621 (psymbol_bcache_init, psymbol_bcache_free)
13622 (psymbol_bcache_get_bcache): Don't declare.
13623 * psymtab.c (struct psymbol_bcache): Remove.
13624 (psymtab_storage::psymtab_storage): Update.
13625 (psymtab_storage::~psymtab_storage): Update.
13626 (psymbol_bcache_init, psymbol_bcache_free)
13627 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13628 (add_psymbol_to_bcache): Update.
13629 (allocate_psymtab): Update.
13630 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13631 macro_cache>: No longer pointers.
13632 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13633 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13634 * macrotab.c (macro_bcache): Update.
13635 * macroexp.c: Don't include bcache.h.
13636 * gdbtypes.c (check_types_worklist): Update.
13637 (types_deeply_equal): Remove TRY/CATCH. Update.
13638 * elfread.c (elf_symtab_read): Update.
13639 * dwarf2read.c: Don't include bcache.h.
13640 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13641 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13642 (print_bcache_statistics, bcache_memory_used): Don't declare.
13643 (struct bcache): Move from bcache.c. Add constructor, destructor,
13644 methods. Rename all data members.
13645 * bcache.c (struct bcache): Move to bcache.h.
13646 (bcache::expand_hash_table): Rename from expand_hash_table.
13647 (bcache): Remove.
13648 (bcache::insert): Rename from bcache_full.
13649 (bcache::compare): Rename from bcache_compare.
13650 (bcache_xmalloc): Remove.
13651 (bcache::~bcache): Rename from bcache_xfree.
13652 (bcache::print_statistics): Rename from print_bcache_statistics.
13653 (bcache::memory_used): Rename from bcache_memory_used.
13654
13655 2019-03-07 Pedro Alves <palves@redhat.com>
13656
13657 * infrun.c (normal_stop): Also check for
13658 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13659
13660 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13661
13662 * f-lang.c (value_from_host_double): Moved to...
13663 * value.c (value_from_host_double): ...here.
13664 * value.h (value_from_host_double): Declare.
13665 * guile/scm-math.c (vlscm_convert_typed_number): Use
13666 value_from_host_double.
13667 (vlscm_convert_number): Likewise.
13668 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13669 * python/py-value.c (convert_value_from_python): Likewise.
13670
13671 2019-03-06 Tom Tromey <tom@tromey.com>
13672
13673 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13674
13675 2019-03-06 Tom Tromey <tom@tromey.com>
13676
13677 * utils.h (free_current_contents): Don't declare.
13678 * utils.c (free_current_contents): Remove.
13679
13680 2019-03-06 Tom Tromey <tom@tromey.com>
13681
13682 * top.c (quit_force): Update.
13683 * main.c (captured_command_loop): Update.
13684 * common/new-op.c (operator new): Update.
13685 * common/common-exceptions.c (struct catcher)
13686 <save_cleanup_chain>: Remove member.
13687 (exceptions_state_mc_init): Update.
13688 (exception_try_scope_entry): Return nullptr.
13689 (exception_try_scope_exit, exception_rethrow)
13690 (throw_exception_sjlj, throw_exception_cxx): Update.
13691 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13692 (all_cleanups, do_cleanups, discard_cleanups)
13693 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13694 (restore_cleanups, restore_final_cleanups): Don't declare.
13695 (do_final_cleanups): Remove parameter.
13696 * common/cleanups.c (cleanup_chain, make_cleanup)
13697 (make_cleanup_dtor, all_cleanups, do_cleanups)
13698 (discard_my_cleanups, discard_cleanups)
13699 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13700 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13701 (null_cleanup): Remove.
13702 (do_final_cleanups): Remove parameter.
13703
13704 2019-03-06 Tom Tromey <tom@tromey.com>
13705
13706 * remote.c (remote_target::remote_parse_stop_reply): Use
13707 unique_xmalloc_ptr.
13708
13709 2019-03-06 Tom Tromey <tom@tromey.com>
13710
13711 * stabsread.c (struct stabs_field_info): Rename from field_info.
13712 <list, fnlist>: Add initializers.
13713 <obstack>: New member.
13714 (read_member_functions, read_struct_fields, read_baseclasses):
13715 Allocate on obstack. Don't use cleanups.
13716 (read_one_struct_field, read_member_functions, read_struct_fields)
13717 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13718 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13719 (read_struct_type): Update.
13720
13721 2019-03-06 Tom Tromey <tom@tromey.com>
13722
13723 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13724 * common/filestuff.h (make_cleanup_close): Don't declare.
13725 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13726 Remove.
13727
13728 2019-03-06 Tom Tromey <tom@tromey.com>
13729
13730 * solib-aix.c: Use make_scope_exit.
13731
13732 2019-03-06 Tom Tromey <tom@tromey.com>
13733
13734 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13735 Use make_scope_exit.
13736
13737 2019-03-06 Tom Tromey <tom@tromey.com>
13738
13739 * solib-svr4.c (disable_probes_interface): Remove parameter.
13740 (svr4_handle_solib_event): Use make_scope_exit.
13741
13742 2019-03-06 Tom Tromey <tom@tromey.com>
13743
13744 * remote.c (struct stop_reply_deleter): Remove.
13745 (stop_reply_up): Update.
13746 (struct stop_reply): Derive from notif_event. Don't typedef.
13747 <regcache>: Now a std::vector.
13748 (stop_reply_xfree): Remove.
13749 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13750 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13751 (remote_target::discard_pending_stop_replies): Use delete.
13752 (remote_target::remote_parse_stop_reply): Update.
13753 (remote_target::process_stop_reply): Update.
13754 * remote-notif.h (struct notif_event): Add virtual destructor.
13755 Remove "dtr" member.
13756 (struct notif_client) <alloc_event>: Return a unique_ptr.
13757 (notif_event_xfree): Don't declare.
13758 (notif_event_up): New typedef.
13759 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13760 (notif_event_xfree, do_notif_event_xfree): Remove.
13761 (remote_notif_state_xfree): Update.
13762
13763 2019-03-06 Tom Tromey <tom@tromey.com>
13764
13765 * infrun.c (displaced_step_clear_cleanup): Now a
13766 forward_scope_exit type.
13767 (displaced_step_prepare_throw): Update.
13768 (displaced_step_fixup): Update.
13769
13770 2019-03-06 Tom Tromey <tom@tromey.com>
13771
13772 * inferior.h (class inferior): Update comment.
13773 * gdbthread.h (class thread_info): Update comment.
13774
13775 2019-03-06 Joel Brobecker <brobecker@adacore.com>
13776 Tom Tromey <tom@tromey.com>
13777
13778 * stabsread.h (struct stab_section_list): Remove.
13779 (coffstab_build_psymtabs): Update.
13780 * dbxread.c (symbuf_sections): Now a std::vector.
13781 (sect_idx): New global.
13782 (fill_symbuf): Update.
13783 (coffstab_build_psymtabs): Change type of stabsects parameter.
13784 Update.
13785 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13786 std::vector.
13787 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13788 (coff_locate_sections): Update.
13789 (coff_symfile_read): Remove cleanups. Update.
13790 (init_stringtab): Add storage parameter.
13791 (free_stringtab, free_stringtab_cleanup): Remove.
13792 (init_lineno): Add storage parameter.
13793 (free_linetab, free_linetab_cleanup): Remove.
13794
13795 2019-03-06 Pedro Alves <palves@redhat.com>
13796
13797 * linux-fork.c (fork_info::clobber_regs): Delete.
13798 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13799 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13800 comment. Adjust.
13801 (scoped_switch_fork_info::scoped_switch_fork_info)
13802 (checkpoint_command, linux_fork_context): Adjust
13803 fork_save_infrun_state calls.
13804
13805 2019-03-06 Pedro Alves <palves@redhat.com>
13806
13807 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13808 (inf_has_multiple_threads): Return 'bool' and rewrite using
13809 inferior_info::threads().
13810
13811 2019-03-06 Pedro Alves <palves@redhat.com>
13812
13813 * linux-fork.c: Include <list>.
13814 (fork_list): Now a std::list instance.
13815 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13816 (forks_exist_p, find_last_fork): Adjust.
13817 (new_fork): Delete.
13818 (one_fork_p): New.
13819 (add_fork): Adjust.
13820 (free_fork): Delete, folded into fork_info::~fork_info().
13821 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13822 Adjust.
13823 (init_fork_list): Delete.
13824 (linux_fork_killall, linux_fork_mourn_inferior)
13825 (linux_fork_detach, info_checkpoints_command): Adjust.
13826 (_initialize_linux_fork): No longer call init_fork_list.
13827
13828 2019-03-06 Pedro Alves <palves@redhat.com>
13829
13830 * linux-fork.c (new_fork): New, split out of ...
13831 (add_fork): ... this. Return void. Move "first fork" special
13832 case from here, to ...
13833 (checkpoint_command): ... here.
13834 * linux-linux.h (add_fork): Return void.
13835
13836 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13837
13838 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13839
13840 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13841 Chris January <chris.january@arm.com>
13842 David Lecomber <david.lecomber@arm.com>
13843
13844 * f-exp.y: New token, UNOP_INTRINSIC.
13845 (exp): New pattern using UNOP_INTRINSIC token.
13846 (f77_keywords): Add 'abs' keyword.
13847 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13848 (value_from_host_double): New function.
13849 (evaluate_subexp_f): Support UNOP_ABS.
13850
13851 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13852
13853 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13854 types.
13855
13856 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13857
13858 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13859 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13860 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13861
13862 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13863
13864 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13865
13866 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13867 Chris January <chris.january@arm.com>
13868
13869 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13870 * f-exp.y: Define 'KIND' token.
13871 (exp): New pattern for KIND expressions.
13872 (ptype): Handle types with a kind extension.
13873 (direct_abs_decl): Extend to spot kind extensions.
13874 (f77_keywords): Add 'kind' to the list.
13875 (push_kind_type): New function.
13876 (convert_to_kind_type): New function.
13877 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13878 * parse.c (operator_length_standard): Likewise.
13879 * parser-defs.h (enum type_pieces): Add tp_kind.
13880 * std-operator.def: Add UNOP_KIND.
13881
13882 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13883
13884 * f-exp.y (f_parse): Set yydebug.
13885
13886 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13887
13888 * f-lang.c (evaluate_subexp_f): New function.
13889 (exp_descriptor_f): New global.
13890 (f_language_defn): Use exp_descriptor_f instead of
13891 exp_descriptor_standard.
13892
13893 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13894
13895 * f-exp.y (struct token): Add comments.
13896 (dot_ops): Remove uppercase versions and the end marker.
13897 (f77_keywords): Likewise.
13898 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13899 entries in the dot_ops array are case insensitive, and use
13900 strncasecmp to compare strings. Also some whitespace cleanup in
13901 this area. Similar for the f77_keywords array, except entries in
13902 this list might be case sensitive.
13903
13904 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13905
13906 * f-exp.y (struct f77_boolean_val): Add comments.
13907 (boolean_values): Remove uppercase versions, and end marker.
13908 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13909 and use strncasecmp to achieve case insensitivity. Additionally,
13910 perform whitespace cleanup around this code.
13911
13912 2019-03-06 Tom Tromey <tromey@adacore.com>
13913
13914 * remote-sim.c (gdbsim_target_open): Use result of
13915 gdb_argv::release.
13916
13917 2019-03-06 Richard Bunt <richard.bunt@arm.com>
13918 Dirk Schubert <dirk.schubert@arm.com>
13919 Chris January <chris.january@arm.com>
13920
13921 * eval.c (evaluate_subexp_standard): Call Fortran argument
13922 wrapping logic.
13923 * f-lang.c (struct value): A value which can be passed into a
13924 Fortran function call.
13925 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13926 where appropriate.
13927 (struct type): Value ready for a Fortran function call.
13928 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13929 is needed.
13930 * f-lang.h (fortran_argument_convert): Declaration.
13931 (fortran_preserve_arg_pointer): Declaration.
13932 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13933
13934 2019-03-05 Tom Tromey <tromey@adacore.com>
13935
13936 * python/py-prettyprint.c (print_string_repr): Remove #if.
13937 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13938
13939 2019-03-05 Tom Tromey <tromey@adacore.com>
13940
13941 * target.c (the_dummy_target): Move later. Change type to
13942 "dummy_target".
13943 (initialize_targets): Don't initialize the_dummy_target.
13944
13945 2019-03-05 Tom Tromey <tromey@adacore.com>
13946
13947 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13948 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13949
13950 2019-03-05 Tom Tromey <tromey@adacore.com>
13951
13952 * windows-nat.c (windows_nat_target::attach)
13953 (windows_nat_target::detach): Don't call gdb_flush.
13954 * valprint.c (generic_val_print, val_print, val_print_string):
13955 Don't call gdb_flush.
13956 * utils.c (defaulted_query): Don't call gdb_flush.
13957 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13958 * target.c (target_announce_detach): Don't call gdb_flush.
13959 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13960 * remote.c (extended_remote_target::attach): Don't call
13961 gdb_flush.
13962 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13963 * printcmd.c (do_examine): Don't call gdb_flush.
13964 (info_display_command): Don't call gdb_flush.
13965 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13966 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13967 * memattr.c (info_mem_command): Don't call gdb_flush.
13968 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13969 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13970 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13971 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13972 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13973 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13974 (gnu_nat_target::detach): Don't call gdb_flush.
13975 * f-valprint.c (f_val_print): Don't call gdb_flush.
13976 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13977 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13978 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13979 gdb_flush.
13980 * c-valprint.c (c_val_print): Don't call gdb_flush.
13981 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13982
13983 2019-03-05 Tom Tromey <tromey@adacore.com>
13984
13985 * varobj.c (update_dynamic_varobj_children): Update.
13986 (install_default_visualizer): Use reset, not release.
13987 * value.c (set_internalvar): Update.
13988 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13989 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13990 ATTRIBUTE_UNUSED_RESULT.
13991
13992 2019-03-05 Tom Tromey <tromey@adacore.com>
13993
13994 * remote.c (class scoped_remote_fd) <release>: Add
13995 ATTRIBUTE_UNUSED_RESULT.
13996
13997 2019-03-05 Tom Tromey <tromey@adacore.com>
13998
13999 * macroexp.c (struct macro_buffer) <release>: Add
14000 ATTRIBUTE_UNUSED_RESULT.
14001
14002 2019-03-05 Tom Tromey <tromey@adacore.com>
14003
14004 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14005 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14006 ATTRIBUTE_UNUSED_RESULT.
14007
14008 2019-03-05 Tom Tromey <tromey@adacore.com>
14009
14010 * common/scoped_fd.h (class scoped_fd) <release>: Add
14011 ATTRIBUTE_UNUSED_RESULT.
14012
14013 2019-03-05 Tom Tromey <tromey@adacore.com>
14014
14015 * parser-defs.h (struct parser_state) <release>: Add
14016 ATTRIBUTE_UNUSED_RESULT.
14017
14018 2019-03-05 Tom Tromey <tromey@adacore.com>
14019
14020 * utils.h (class gdb_argv) <release>: Add
14021 ATTRIBUTE_UNUSED_RESULT.
14022 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14023
14024 2019-03-02 Eli Zaretskii <eliz@gnu.org>
14025
14026 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14027 for-loop range, to avoid compiler warnings.
14028
14029 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14030 avoid compiler warnings about unused variables.
14031
14032 * NEWS: Mention end of support for native debugging on MS-Windows
14033 before XP.
14034
14035 PR gdb/24292
14036 * common/netstuff.c:
14037 * gdbserver/gdbreplay.c
14038 * gdbserver/remote-utils.c:
14039 * ser-tcp.c:
14040 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14041 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14042 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14043 'getaddrinfo' and 'freeaddrinfo' were not available before
14044 Windows XP, and mingw.org's MinGW headers by default define
14045 _WIN32_WINNT to 0x500.
14046
14047 2019-03-01 Gary Benson <gbenson@redhat.com>
14048
14049 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14050
14051 2019-02-28 Brian Vandenberg <phantall@gmail.com>
14052 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14053
14054 PR gdb/8527
14055 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14056 set_sigint_trap, clear_sigint_trap.
14057
14058 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14059
14060 * target.c (target_detach): Clear the regcache and the
14061 frame cache.
14062
14063 2019-02-27 Pedro Alves <palves@redhat.com>
14064
14065 * utils.c (set_screen_size): When we cap the height/width sizes,
14066 tweak the corresponding command variable to show "unlimited":
14067
14068 2019-02-27 Saagar Jha <saagar@saagarjha.com>
14069 Pedro Alves <palves@redhat.com>
14070
14071 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14072 before calling rl_set_screen_size.
14073
14074 2019-02-27 Tom Tromey <tromey@adacore.com>
14075
14076 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14077 define.
14078 * python/py-value.c: Remove Python 2.4 workaround.
14079 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14080 workaround.
14081 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14082 Python 2.4 workaround.
14083 * python/python-internal.h: Remove Python 2.4 comment.
14084 (Py_ssize_t): Don't define.
14085 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14086 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14087 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14088 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14089 * python/python.c (do_start_initialization): Remove Python 2.4
14090 workaround.
14091 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14092 (print_children): Remove Python 2.4 workaround.
14093 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14094 workaround.
14095 (CHARBUFFERPROC_NAME): Remove.
14096 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14097 Python 2.4 workaround.
14098
14099 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14100
14101 * NEWS: Note minimum Python version.
14102
14103 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14104
14105 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14106 code from these functions. Remove corresponding ifdefs. Use
14107 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14108 Remove gotos and target of gotos.
14109 (infpy_search_memory): Likewise.
14110
14111 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14112
14113 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14114 (hppa_gdbarch_init): Don't register deleted functions with
14115 gdbarch.
14116
14117 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14118
14119 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14120 (h8300_unwind_sp): Delete.
14121 (h8300_dummy_id): Delete.
14122 (h8300_gdbarch_init): Don't register deleted functions with
14123 gdbarch.
14124
14125 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14126
14127 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14128 (ft32_unwind_pc): Delete.
14129 (ft32_unwind_sp): Delete.
14130 (ft32_gdbarch_init): Don't register deleted functions with
14131 gdbarch.
14132
14133 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14134
14135 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14136 (frv_unwind_pc): Delete.
14137 (frv_unwind_sp): Delete.
14138 (frv_gdbarch_init): Don't register deleted functions with
14139 gdbarch.
14140
14141 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14142
14143 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14144 (riscv_unwind_pc): Delete.
14145 (riscv_unwind_sp): Delete.
14146 (riscv_gdbarch_init): Don't register deleted functions with
14147 gdbarch.
14148
14149 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14150
14151 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14152 (csky_unwind_pc): Delete.
14153 (csky_unwind_sp): Delete.
14154 (csky_gdbarch_init): Don't register deleted functions with
14155 gdbarch.
14156
14157 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14158
14159 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14160 (cris_unwind_pc): Delete.
14161 (cris_unwind_sp): Delete.
14162 (cris_gdbarch_init): Don't register deleted functions with
14163 gdbarch.
14164
14165 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14166
14167 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14168 (bfin_unwind_pc): Delete.
14169 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14170
14171 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14172
14173 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14174 (arm_unwind_pc): Delete.
14175 (arm_unwind_sp): Delete.
14176 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14177
14178 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14179
14180 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14181 (arc_unwind_pc): Delete.
14182 (arc_unwind_sp): Delete.
14183 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14184
14185 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14186
14187 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14188 (alpha_unwind_pc): Delete.
14189 (alpha_gdbarch_init): Don't register deleted functions with
14190 gdbarch.
14191
14192 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14193
14194 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14195 (aarch64_unwind_pc): Delete.
14196 (aarch64_unwind_sp): Delete.
14197 (aarch64_gdbarch_init): Don't register deleted functions with
14198 gdbarch.
14199
14200 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14201
14202 * gdbtypes.c (type_align): Don't consider static members when
14203 computing structure alignment.
14204
14205 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14206
14207 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14208 return 0 for other types.
14209 * arch-utils.c (default_type_align): Always return 0.
14210 * gdbarch.h: Regenerate.
14211 * gdbarch.sh (type_align): Extend comment.
14212 * gdbtypes.c (type_align): Add additional comments, always call
14213 gdbarch_type_align before applying the default rules.
14214 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14215 generic code will then apply a suitable default.
14216 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14217 types, return 0 for other types.
14218
14219 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14220
14221 * NEWS: Create a new section for the next release branch.
14222 Rename the section of the current branch, now that it has
14223 been cut.
14224
14225 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14226
14227 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14228 * version.in: Bump version to 8.3.50.DATE-git.
14229
14230 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
14231
14232 * aix-thread.c (ptid_cmp): Remove unused variable.
14233 (get_signaled_thread): Likewise.
14234 (store_regs_user_thread): Likewise.
14235 (store_regs_kernel_thread): Likewise.
14236 (fetch_regs_kernel_thread): Remove shadowed variable.
14237
14238 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14239
14240 * features/riscv/32bit-cpu.xml: Add register numbers.
14241 * features/riscv/32bit-fpu.c: Regenerate.
14242 * features/riscv/32bit-fpu.xml: Add register numbers.
14243 * features/riscv/64bit-cpu.xml: Add register numbers.
14244 * features/riscv/64bit-fpu.c: Regenerate.
14245 * features/riscv/64bit-fpu.xml: Add register numbers.
14246
14247 2019-02-26 Kevin Buettner <kevinb@redhat.com>
14248
14249 * NEWS: Mention two argument form of gdb.Value constructor.
14250 * python/py-value.c (convert_buffer_and_type_to_value): New
14251 function.
14252 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14253 Add support for handling an optional second argument. Call
14254 convert_buffer_and_type_to_value as appropriate.
14255 * python/python-internal.h (Py_buffer_deleter): New struct.
14256 (Py_buffer_up): New typedef.
14257
14258 2019-02-25 John Baldwin <jhb@FreeBSD.org>
14259
14260 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14261 instead of releasing ownership.
14262
14263 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
14264
14265 * dwarf2read.c (open_and_init_dwp_file): Call
14266 elf_numsections instead of bfd_count_sections to initialize
14267 dwp_file->num_sections.
14268
14269 2019-02-25 Tom Tromey <tromey@adacore.com>
14270
14271 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14272
14273 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14274
14275 * gcore.in: Add '--readnever' option when invoking GDB.
14276
14277 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14278
14279 * MAINTAINERS: Update my email address.
14280
14281 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14282
14283 * build-id.c (build_id_to_debug_bfd_1): New function.
14284 (build_id_to_debug_bfd): Look for separate debug file in
14285 sysroot.
14286
14287 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14288
14289 * gdbarch.sh: Update the copyright year range that is placed into
14290 generated files.
14291
14292 2019-02-22 Keith Seitz <keiths@redhat.com>
14293
14294 PR symtab/23853
14295 * linespec.c (create_sals_line_offset): Search for the default
14296 symtab's filename instead of its fullname.
14297
14298 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14299
14300 * NEWS: Update style defaults.
14301
14302 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14303
14304 * main.c (captured_main_1): Disable styling in batch mode.
14305
14306 2019-02-20 Tom Tromey <tom@tromey.com>
14307
14308 * symtab.c (symtab_symbol_info): Fix typos.
14309
14310 2019-02-20 Tom Tromey <tromey@adacore.com>
14311
14312 * findcmd.c (_initialize_mem_search): Use upper case for
14313 metasyntactic variables.
14314
14315 2019-02-20 Alan Hayward <alan.hayward@arm.com>
14316
14317 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14318 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14319
14320 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14321
14322 * top.h (source_file_name): Change to std::string.
14323 * top.c (source_file_name): Likewise.
14324 (command_line_input): Adjust.
14325 * cli/cli-script.c (script_from_file): Adjust.
14326
14327 2019-02-19 Tom Tromey <tromey@adacore.com>
14328
14329 * ravenscar-thread.c
14330 (ravenscar_thread_target::update_thread_list): Don't call
14331 ada_build_task_list.
14332 * ada-lang.h (ada_build_task_list): Don't declare.
14333 * ada-tasks.c (struct ada_tasks_inferior_data)
14334 <task_list_valid_p>: Now bool.
14335 (read_known_tasks, ada_task_list_changed)
14336 (ada_tasks_invalidate_inferior_data): Update.
14337 (read_known_tasks_array): Return bool.
14338 (read_known_tasks_list): Likewise.
14339 (read_known_tasks): Return void.
14340 (ada_build_task_list): Now static.
14341
14342 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14343
14344 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14345 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14346
14347 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14348
14349 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14350 variant for ada_tasks_pspace_data_handle and
14351 ada_tasks_inferior_data_handle.
14352 (ada_tasks_pspace_data_cleanup): New function.
14353 (ada_tasks_inferior_data_cleanup): New function.
14354
14355 2019-02-17 Tom Tromey <tom@tromey.com>
14356
14357 * macrotab.h (macro_source_fullname): Return a std::string.
14358 * macrotab.c (macro_include, check_for_redefinition)
14359 (macro_undef, macro_lookup_definition, foreach_macro)
14360 (foreach_macro_in_scope): Update.
14361 (macro_source_fullname): Return a std::string.
14362 * macrocmd.c (show_pp_source_pos): Update.
14363
14364 2019-02-17 Tom Tromey <tom@tromey.com>
14365
14366 * macrocmd.c (show_pp_source_pos): Style the file names.
14367
14368 2019-02-17 Tom Tromey <tom@tromey.com>
14369
14370 PR tui/24197:
14371 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14372
14373 2019-02-17 Tom Tromey <tom@tromey.com>
14374
14375 * ada-lang.c (user_select_syms): Use filtered printing.
14376 * utils.c (wrap_style): New global.
14377 (desired_style): Remove.
14378 (emit_style_escape): Add stream parameter.
14379 (set_output_style, reset_terminal_style, prompt_for_continue):
14380 Update.
14381 (flush_wrap_buffer): Only flush gdb_stdout.
14382 (wrap_here): Set wrap_style.
14383 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14384 treat escape sequences as a character. Change when wrap buffer is
14385 flushed.
14386 (fputs_styled): Do not set the output style when the default is
14387 requested.
14388 * ui-style.h (struct ui_file_style) <is_default>: New method.
14389 * source.c (print_source_lines_base): Emit escape sequences in one
14390 piece.
14391
14392 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14393
14394 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14395 integers and enumeration types.
14396
14397 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14398
14399 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14400 instead of lookup_symbol_in_language
14401 (do_exact_match): New function.
14402 (ada_get_symbol_name_matcher): Return do_exact_match when
14403 doing a verbatim match.
14404
14405 2019-02-15 Tom Tromey <tromey@adacore.com>
14406
14407 * ravenscar-thread.c (ravenscar_thread_target::resume)
14408 (ravenscar_thread_target::wait): Special case wildcard requests.
14409
14410 2019-02-15 Tom Tromey <tromey@adacore.com>
14411
14412 * ravenscar-thread.c (base_ptid): Remove.
14413 (struct ravenscar_thread_target) <close>: New method.
14414 <m_base_ptid>: New member.
14415 <update_inferior_ptid, active_task, task_is_currently_active,
14416 runtime_initialized>: Declare methods.
14417 <ravenscar_thread_target>: Add constructor.
14418 (ravenscar_thread_target::task_is_currently_active)
14419 (ravenscar_thread_target::update_inferior_ptid)
14420 (ravenscar_runtime_initialized): Rename. Now methods.
14421 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14422 (ravenscar_thread_target::update_thread_list): Update.
14423 (ravenscar_thread_target::active_task): Now method.
14424 (ravenscar_thread_target::store_registers)
14425 (ravenscar_thread_target::prepare_to_store)
14426 (ravenscar_thread_target::prepare_to_store)
14427 (ravenscar_thread_target::mourn_inferior): Update.
14428 (ravenscar_inferior_created): Use "new" to create target.
14429 (ravenscar_thread_target::get_ada_task_ptid): Update.
14430 (_initialize_ravenscar): Don't initialize base_ptid.
14431 (ravenscar_ops): Remove global.
14432
14433 2019-02-15 Tom Tromey <tromey@adacore.com>
14434
14435 * target.h (push_target): Declare new overload.
14436 * target.c (push_target): New overload, taking an rvalue reference.
14437 * remote.c (remote_target::open_1): Use push_target overload.
14438 * corelow.c (core_target_open): Use push_target overload.
14439
14440 2019-02-15 Tom Tromey <tromey@adacore.com>
14441
14442 * ravenscar-thread.c (is_ravenscar_task)
14443 (ravenscar_task_is_currently_active): Return bool.
14444 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14445 (_initialize_ravenscar): Remove "(void)".
14446 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14447 Return bool.
14448
14449 2019-02-15 Tom Tromey <tromey@adacore.com>
14450
14451 * ravenscar-thread.c (ravenscar_runtime_initializer)
14452 (has_ravenscar_runtime, get_running_thread_id)
14453 (ravenscar_thread_target::resume): Fix indentation.
14454
14455 2019-02-15 Tom Tromey <tromey@adacore.com>
14456
14457 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14458 from ravenscar_arch_ops.
14459 (sparc_ravenscar_ops::fetch_registers)
14460 (sparc_ravenscar_ops::store_registers): Now methods.
14461 (sparc_ravenscar_prepare_to_store): Remove.
14462 (sparc_ravenscar_ops): Redefine.
14463 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14464 methods and destructor. Remove members.
14465 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14466 (ravenscar_thread_target::store_registers)
14467 (ravenscar_thread_target::prepare_to_store): Update.
14468 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14469 Remove.
14470 (struct ppc_ravenscar_powerpc_ops): Derive from
14471 ravenscar_arch_ops.
14472 (ppc_ravenscar_powerpc_ops::fetch_registers)
14473 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14474 (ppc_ravenscar_powerpc_ops): Redefine.
14475 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14476 (ppc_ravenscar_e500_ops::fetch_registers)
14477 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14478 (ppc_ravenscar_e500_ops): Redefine.
14479 * aarch64-ravenscar-thread.c
14480 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14481 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14482 (aarch64_ravenscar_fetch_registers)
14483 (aarch64_ravenscar_store_registers): Now methods.
14484 (aarch64_ravenscar_ops): Redefine.
14485
14486 2019-02-15 Tom Tromey <tromey@adacore.com>
14487
14488 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14489 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14490 (ravenscar_thread_target::stopped_by_watchpoint)
14491 (ravenscar_thread_target::stopped_data_address)
14492 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14493
14494 2019-02-15 Tom Tromey <tromey@adacore.com>
14495
14496 * ravenscar-thread.c: Fix some typos.
14497
14498 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14499 Tom Tromey <tromey@adacore.com>
14500
14501 * ada-lang.c (ada_exception_sal): Change addr_string to a
14502 std::string.
14503 (create_ada_exception_catchpoint): Update.
14504
14505 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14506 Tom Tromey <tromey@adacore.com>
14507
14508 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14509 (bp_location_ops): Remove.
14510 (base_breakpoint_allocate_location): Update.
14511 (free_bp_location): Update.
14512 * ada-lang.c (class ada_catchpoint_location)
14513 <ada_catchpoint_location>: Remove ops parameter.
14514 (ada_catchpoint_location_dtor): Remove.
14515 (ada_catchpoint_location_ops): Remove.
14516 (allocate_location_exception): Update.
14517 * breakpoint.h (struct bp_location_ops): Remove.
14518 (class bp_location) <bp_location>: Remove bp_location_ops
14519 parameter.
14520 <~bp_location>: Add destructor.
14521 <ops>: Remove.
14522
14523 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14524 Pedro Alves <palves@redhat.com>
14525
14526 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14527 'PATH_MAX'.
14528
14529 2019-02-14 David Michael <fedora.dm0@gmail.com>
14530 Samuel Thibault <samuel.thibault@gnu.org>
14531 Thomas Schwinge <thomas@codesourcery.com>
14532
14533 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14534 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14535
14536 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14537
14538 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14539 (check_empty): Use "const char *".
14540
14541 * gnu-nat.c (gnu_nat_target::detach): Instead of
14542 'detach_inferior (pid)' call
14543 'detach_inferior (find_inferior_pid (pid))'.
14544
14545 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14546 'nat/fork-inferior.o'.
14547 * gnu-nat.c: #include "nat/fork-inferior.h".
14548
14549 * gnu-nat.c (gnu_nat_target::detach): Instead of
14550 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14551 * gnu-nat.h: #include "inf-child.h".
14552 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14553 'i386_gnu_nat_target::fetch_registers'.
14554 (gnu_store_registers): Rename/move to
14555 'i386_gnu_nat_target::store_registers'.
14556
14557 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14558 * gnu-nat.h (mach_thread_info): New function.
14559 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14560
14561 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14562
14563 2019-02-14 Frederic Konrad <konrad@adacore.com>
14564
14565 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14566
14567 2019-02-14 Joel Brobecker <brobecker@adacore.com>
14568
14569 * windows-nat.c (windows_add_thread): Add new parameter
14570 "main_thread_p" with default value set to false. Update
14571 function documentation as well as all callers.
14572 (windows_delete_thread): Likewise.
14573 (fake_create_process): Update call to windows_add_thread.
14574 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14575 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14576 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14577 call to windows_delete_thread.
14578
14579 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14580
14581 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14582
14583 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14584
14585 * symfile.c (find_separate_debug_file): Use canonical path of
14586 sysroot with child_path instead of gdb_sysroot if it is valid.
14587
14588 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14589
14590 * symfile.c (find_separate_debug_file): Use child_path to
14591 determine if an object file is under a sysroot.
14592
14593 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14594
14595 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14596 unittests/child-path-selftests.c.
14597 * common/pathstuff.c (child_path): New function.
14598 * common/pathstuff.h (child_path): New prototype.
14599 * unittests/child-path-selftests.c: New file.
14600
14601 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14602
14603 * symfile.c (find_separate_debug_file): Look for separate debug
14604 files in debug directories under the sysroot.
14605
14606 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14607
14608 * symtab.h (struct minimal_symbol data_p): New const method.
14609 (struct minimal_symbol text_p): Likewise.
14610 * symtab.c (output_source_filename): Use file name style
14611 to print file name.
14612 (print_symbol_info): Likewise.
14613 (print_msymbol_info): Use address style to print addresses.
14614 Use function name style to print executable text symbols.
14615 (expand_symtab_containing_pc): Use data_p.
14616 (find_pc_sect_compunit_symtab): Likewise.
14617
14618 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14619
14620 * breakpoint.c (describe_other_breakpoints): Use address style
14621 to print addresses.
14622 (say_where): Likewise.
14623
14624 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14625
14626 * ada-typeprint.c (print_func_type): Print function name
14627 style to print function name.
14628 * c-typeprint.c (c_print_type_1): Likewise.
14629
14630 2019-02-11 Alan Hayward <alan.hayward@arm.com>
14631
14632 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14633 for execve.
14634
14635 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14636
14637 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14638 type_stack.
14639
14640 2019-02-10 Joel Brobecker <brobecker@adacore.com>
14641
14642 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14643 TYPE_CODE_REF types.
14644
14645 2019-02-08 Jim Wilson <jimw@sifive.com>
14646
14647 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14648 (riscv_linux_fregset): New.
14649 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14650
14651 2019-02-07 Tom Tromey <tom@tromey.com>
14652
14653 * thread.c (thread_cancel_execution_command): Update.
14654 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14655 methods.
14656 (struct thread_fsm_ops): Remove.
14657 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14658 (thread_fsm_should_stop, thread_fsm_return_value)
14659 (thread_fsm_set_finished, thread_fsm_finished_p)
14660 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14661 Don't declare.
14662 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14663 * infrun.c (clear_proceed_status_thread)
14664 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14665 (print_stop_event): Update.
14666 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14667 Add constructor.
14668 (step_command_fsm_ops): Remove.
14669 (new_step_command_fsm): Remove.
14670 (step_1): Update.
14671 (step_command_fsm::should_stop): Rename from
14672 step_command_fsm_should_stop.
14673 (step_command_fsm::clean_up): Rename from
14674 step_command_fsm_clean_up.
14675 (step_command_fsm::do_async_reply_reason): Rename from
14676 step_command_fsm_async_reply_reason.
14677 (struct until_next_fsm): Inherit from thread_fsm. Add
14678 constructor.
14679 (until_next_fsm_ops): Remove.
14680 (new_until_next_fsm): Remove.
14681 (until_next_fsm::should_stop): Rename from
14682 until_next_fsm_should_stop.
14683 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14684 (until_next_fsm::do_async_reply_reason): Rename from
14685 until_next_fsm_async_reply_reason.
14686 (struct finish_command_fsm): Inherit from thread_fsm. Add
14687 constructor. Change type of breakpoint.
14688 (finish_command_fsm_ops): Remove.
14689 (new_finish_command_fsm): Remove.
14690 (finish_command_fsm::should_stop): Rename from
14691 finish_command_fsm_should_stop.
14692 (finish_command_fsm::clean_up): Rename from
14693 finish_command_fsm_clean_up.
14694 (finish_command_fsm::return_value): Rename from
14695 finish_command_fsm_return_value.
14696 (finish_command_fsm::do_async_reply_reason): Rename from
14697 finish_command_fsm_async_reply_reason.
14698 (finish_command): Update.
14699 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14700 Add constructor.
14701 (call_thread_fsm_ops): Remove.
14702 (call_thread_fsm::call_thread_fsm): Rename from
14703 new_call_thread_fsm.
14704 (call_thread_fsm::should_stop): Rename from
14705 call_thread_fsm_should_stop.
14706 (call_thread_fsm::should_notify_stop): Rename from
14707 call_thread_fsm_should_notify_stop.
14708 (run_inferior_call, call_function_by_hand_dummy): Update.
14709 * cli/cli-interp.c (should_print_stop_to_console): Update.
14710 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14711 Add constructor. Change type of location_breakpoint,
14712 caller_breakpoint.
14713 (until_break_fsm_ops): Remove.
14714 (new_until_break_fsm): Remove.
14715 (until_break_fsm::should_stop): Rename from
14716 until_break_fsm_should_stop.
14717 (until_break_fsm::clean_up): Rename from
14718 until_break_fsm_clean_up.
14719 (until_break_fsm::do_async_reply_reason): Rename from
14720 until_break_fsm_async_reply_reason.
14721 (until_break_command): Update.
14722 * thread-fsm.c: Remove.
14723 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14724
14725 2019-02-07 Tom Tromey <tom@tromey.com>
14726
14727 * yy-remap.h: Add include guard.
14728 * xtensa-tdep.h: Add include guard.
14729 * xcoffread.h: Rename include guard.
14730 * varobj-iter.h: Add include guard.
14731 * tui/tui.h: Rename include guard.
14732 * tui/tui-winsource.h: Rename include guard.
14733 * tui/tui-wingeneral.h: Rename include guard.
14734 * tui/tui-windata.h: Rename include guard.
14735 * tui/tui-win.h: Rename include guard.
14736 * tui/tui-stack.h: Rename include guard.
14737 * tui/tui-source.h: Rename include guard.
14738 * tui/tui-regs.h: Rename include guard.
14739 * tui/tui-out.h: Rename include guard.
14740 * tui/tui-layout.h: Rename include guard.
14741 * tui/tui-io.h: Rename include guard.
14742 * tui/tui-hooks.h: Rename include guard.
14743 * tui/tui-file.h: Rename include guard.
14744 * tui/tui-disasm.h: Rename include guard.
14745 * tui/tui-data.h: Rename include guard.
14746 * tui/tui-command.h: Rename include guard.
14747 * tic6x-tdep.h: Add include guard.
14748 * target/waitstatus.h: Rename include guard.
14749 * target/wait.h: Rename include guard.
14750 * target/target.h: Rename include guard.
14751 * target/resume.h: Rename include guard.
14752 * target-float.h: Rename include guard.
14753 * stabsread.h: Add include guard.
14754 * rs6000-tdep.h: Add include guard.
14755 * riscv-fbsd-tdep.h: Add include guard.
14756 * regformats/regdef.h: Rename include guard.
14757 * record.h: Rename include guard.
14758 * python/python.h: Rename include guard.
14759 * python/python-internal.h: Rename include guard.
14760 * python/py-stopevent.h: Rename include guard.
14761 * python/py-ref.h: Rename include guard.
14762 * python/py-record.h: Rename include guard.
14763 * python/py-record-full.h: Rename include guard.
14764 * python/py-record-btrace.h: Rename include guard.
14765 * python/py-instruction.h: Rename include guard.
14766 * python/py-events.h: Rename include guard.
14767 * python/py-event.h: Rename include guard.
14768 * procfs.h: Add include guard.
14769 * proc-utils.h: Add include guard.
14770 * p-lang.h: Add include guard.
14771 * or1k-tdep.h: Rename include guard.
14772 * observable.h: Rename include guard.
14773 * nto-tdep.h: Rename include guard.
14774 * nat/x86-linux.h: Rename include guard.
14775 * nat/x86-linux-dregs.h: Rename include guard.
14776 * nat/x86-gcc-cpuid.h: Add include guard.
14777 * nat/x86-dregs.h: Rename include guard.
14778 * nat/x86-cpuid.h: Rename include guard.
14779 * nat/ppc-linux.h: Rename include guard.
14780 * nat/mips-linux-watch.h: Rename include guard.
14781 * nat/linux-waitpid.h: Rename include guard.
14782 * nat/linux-ptrace.h: Rename include guard.
14783 * nat/linux-procfs.h: Rename include guard.
14784 * nat/linux-osdata.h: Rename include guard.
14785 * nat/linux-nat.h: Rename include guard.
14786 * nat/linux-namespaces.h: Rename include guard.
14787 * nat/linux-btrace.h: Rename include guard.
14788 * nat/glibc_thread_db.h: Rename include guard.
14789 * nat/gdb_thread_db.h: Rename include guard.
14790 * nat/gdb_ptrace.h: Rename include guard.
14791 * nat/fork-inferior.h: Rename include guard.
14792 * nat/amd64-linux-siginfo.h: Rename include guard.
14793 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14794 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14795 * nat/aarch64-linux.h: Rename include guard.
14796 * nat/aarch64-linux-hw-point.h: Rename include guard.
14797 * mn10300-tdep.h: Add include guard.
14798 * mips-linux-tdep.h: Add include guard.
14799 * mi/mi-parse.h: Rename include guard.
14800 * mi/mi-out.h: Rename include guard.
14801 * mi/mi-main.h: Rename include guard.
14802 * mi/mi-interp.h: Rename include guard.
14803 * mi/mi-getopt.h: Rename include guard.
14804 * mi/mi-console.h: Rename include guard.
14805 * mi/mi-common.h: Rename include guard.
14806 * mi/mi-cmds.h: Rename include guard.
14807 * mi/mi-cmd-break.h: Rename include guard.
14808 * m2-lang.h: Add include guard.
14809 * location.h: Rename include guard.
14810 * linux-record.h: Rename include guard.
14811 * linux-nat.h: Add include guard.
14812 * linux-fork.h: Add include guard.
14813 * i386-darwin-tdep.h: Rename include guard.
14814 * hppa-linux-offsets.h: Add include guard.
14815 * guile/guile.h: Rename include guard.
14816 * guile/guile-internal.h: Rename include guard.
14817 * gnu-nat.h: Rename include guard.
14818 * gdb-stabs.h: Rename include guard.
14819 * frv-tdep.h: Add include guard.
14820 * f-lang.h: Add include guard.
14821 * event-loop.h: Add include guard.
14822 * darwin-nat.h: Rename include guard.
14823 * cp-abi.h: Rename include guard.
14824 * config/sparc/nm-sol2.h: Rename include guard.
14825 * config/nm-nto.h: Rename include guard.
14826 * config/nm-linux.h: Add include guard.
14827 * config/i386/nm-i386gnu.h: Rename include guard.
14828 * config/djgpp/nl_types.h: Rename include guard.
14829 * config/djgpp/langinfo.h: Rename include guard.
14830 * compile/gcc-cp-plugin.h: Add include guard.
14831 * compile/gcc-c-plugin.h: Add include guard.
14832 * compile/compile.h: Rename include guard.
14833 * compile/compile-object-run.h: Rename include guard.
14834 * compile/compile-object-load.h: Rename include guard.
14835 * compile/compile-internal.h: Rename include guard.
14836 * compile/compile-cplus.h: Rename include guard.
14837 * compile/compile-c.h: Rename include guard.
14838 * common/xml-utils.h: Rename include guard.
14839 * common/x86-xstate.h: Rename include guard.
14840 * common/version.h: Rename include guard.
14841 * common/vec.h: Rename include guard.
14842 * common/tdesc.h: Rename include guard.
14843 * common/selftest.h: Rename include guard.
14844 * common/scoped_restore.h: Rename include guard.
14845 * common/scoped_mmap.h: Rename include guard.
14846 * common/scoped_fd.h: Rename include guard.
14847 * common/safe-iterator.h: Rename include guard.
14848 * common/run-time-clock.h: Rename include guard.
14849 * common/refcounted-object.h: Rename include guard.
14850 * common/queue.h: Rename include guard.
14851 * common/ptid.h: Rename include guard.
14852 * common/print-utils.h: Rename include guard.
14853 * common/preprocessor.h: Rename include guard.
14854 * common/pathstuff.h: Rename include guard.
14855 * common/observable.h: Rename include guard.
14856 * common/netstuff.h: Rename include guard.
14857 * common/job-control.h: Rename include guard.
14858 * common/host-defs.h: Rename include guard.
14859 * common/gdb_wait.h: Rename include guard.
14860 * common/gdb_vecs.h: Rename include guard.
14861 * common/gdb_unlinker.h: Rename include guard.
14862 * common/gdb_unique_ptr.h: Rename include guard.
14863 * common/gdb_tilde_expand.h: Rename include guard.
14864 * common/gdb_sys_time.h: Rename include guard.
14865 * common/gdb_string_view.h: Rename include guard.
14866 * common/gdb_splay_tree.h: Rename include guard.
14867 * common/gdb_setjmp.h: Rename include guard.
14868 * common/gdb_ref_ptr.h: Rename include guard.
14869 * common/gdb_optional.h: Rename include guard.
14870 * common/gdb_locale.h: Rename include guard.
14871 * common/gdb_assert.h: Rename include guard.
14872 * common/filtered-iterator.h: Rename include guard.
14873 * common/filestuff.h: Rename include guard.
14874 * common/fileio.h: Rename include guard.
14875 * common/environ.h: Rename include guard.
14876 * common/common-utils.h: Rename include guard.
14877 * common/common-types.h: Rename include guard.
14878 * common/common-regcache.h: Rename include guard.
14879 * common/common-inferior.h: Rename include guard.
14880 * common/common-gdbthread.h: Rename include guard.
14881 * common/common-exceptions.h: Rename include guard.
14882 * common/common-defs.h: Rename include guard.
14883 * common/common-debug.h: Rename include guard.
14884 * common/cleanups.h: Rename include guard.
14885 * common/buffer.h: Rename include guard.
14886 * common/btrace-common.h: Rename include guard.
14887 * common/break-common.h: Rename include guard.
14888 * cli/cli-utils.h: Rename include guard.
14889 * cli/cli-style.h: Rename include guard.
14890 * cli/cli-setshow.h: Rename include guard.
14891 * cli/cli-script.h: Rename include guard.
14892 * cli/cli-interp.h: Rename include guard.
14893 * cli/cli-decode.h: Rename include guard.
14894 * cli/cli-cmds.h: Rename include guard.
14895 * charset-list.h: Add include guard.
14896 * buildsym-legacy.h: Rename include guard.
14897 * bfin-tdep.h: Add include guard.
14898 * ax.h: Rename include guard.
14899 * arm-linux-tdep.h: Add include guard.
14900 * arm-fbsd-tdep.h: Add include guard.
14901 * arch/xtensa.h: Rename include guard.
14902 * arch/tic6x.h: Add include guard.
14903 * arch/i386.h: Add include guard.
14904 * arch/arm.h: Rename include guard.
14905 * arch/arm-linux.h: Rename include guard.
14906 * arch/arm-get-next-pcs.h: Rename include guard.
14907 * arch/amd64.h: Add include guard.
14908 * arch/aarch64-insn.h: Rename include guard.
14909 * arch-utils.h: Rename include guard.
14910 * annotate.h: Add include guard.
14911 * amd64-darwin-tdep.h: Rename include guard.
14912 * aarch64-linux-tdep.h: Add include guard.
14913 * aarch64-fbsd-tdep.h: Add include guard.
14914 * aarch32-linux-nat.h: Add include guard.
14915
14916 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14917
14918 * macrotab.c (macro_define_internal): New function that
14919 factorizes macro_define_object_internal and macro_define_function
14920 code.
14921 (macro_define_object_internal): Use macro_define_internal.
14922 (macro_define_function): Likewise.
14923
14924 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14925
14926 * macrocmd.c (extract_identifier): Return
14927 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14928 callers.
14929
14930 2019-02-06 John Baldwin <jhb@FreeBSD.org>
14931
14932 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14933
14934 2019-02-05 Tom Tromey <tom@tromey.com>
14935
14936 * target.c (target_stack::unpush): Move assertion earlier.
14937
14938 2019-01-30 Tom Tromey <tom@tromey.com>
14939
14940 PR python/23615:
14941 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14942 (gdbpy_parse_and_eval): Likewise.
14943 * python/python-internal.h (gdbpy_allow_threads): New class.
14944
14945 2019-01-28 John Baldwin <jhb@FreeBSD.org>
14946
14947 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14948 (aarch64_fbsd_fpregmap): Move earlier.
14949 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14950 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14951 instead of individual calls to trad_frame_set_reg_addr.
14952 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14953 earlier.
14954 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14955 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14956 instead of individual calls to trad_frame_set_reg_addr.
14957
14958 2019-01-28 Alan Hayward <alan.hayward@arm.com>
14959
14960 * CONTRIBUTE: Replace contribution list with wiki link.
14961
14962 2019-01-25 Tom Tromey <tom@tromey.com>
14963
14964 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14965
14966 2019-01-25 Tom Tromey <tom@tromey.com>
14967
14968 * xtensa-linux-nat.c: Fix common/ includes.
14969 * xml-support.h: Fix common/ includes.
14970 * xml-support.c: Fix common/ includes.
14971 * x86-linux-nat.c: Fix common/ includes.
14972 * windows-nat.c: Fix common/ includes.
14973 * varobj.h: Fix common/ includes.
14974 * varobj.c: Fix common/ includes.
14975 * value.c: Fix common/ includes.
14976 * valops.c: Fix common/ includes.
14977 * utils.c: Fix common/ includes.
14978 * unittests/xml-utils-selftests.c: Fix common/ includes.
14979 * unittests/utils-selftests.c: Fix common/ includes.
14980 * unittests/unpack-selftests.c: Fix common/ includes.
14981 * unittests/tracepoint-selftests.c: Fix common/ includes.
14982 * unittests/style-selftests.c: Fix common/ includes.
14983 * unittests/string_view-selftests.c: Fix common/ includes.
14984 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14985 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14986 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14987 * unittests/rsp-low-selftests.c: Fix common/ includes.
14988 * unittests/parse-connection-spec-selftests.c: Fix common/
14989 includes.
14990 * unittests/optional-selftests.c: Fix common/ includes.
14991 * unittests/offset-type-selftests.c: Fix common/ includes.
14992 * unittests/observable-selftests.c: Fix common/ includes.
14993 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14994 * unittests/memrange-selftests.c: Fix common/ includes.
14995 * unittests/memory-map-selftests.c: Fix common/ includes.
14996 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14997 * unittests/function-view-selftests.c: Fix common/ includes.
14998 * unittests/environ-selftests.c: Fix common/ includes.
14999 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15000 * unittests/common-utils-selftests.c: Fix common/ includes.
15001 * unittests/cli-utils-selftests.c: Fix common/ includes.
15002 * unittests/array-view-selftests.c: Fix common/ includes.
15003 * ui-file.c: Fix common/ includes.
15004 * tui/tui-io.c: Fix common/ includes.
15005 * tracepoint.h: Fix common/ includes.
15006 * tracepoint.c: Fix common/ includes.
15007 * tracefile-tfile.c: Fix common/ includes.
15008 * top.h: Fix common/ includes.
15009 * top.c: Fix common/ includes.
15010 * thread.c: Fix common/ includes.
15011 * target/waitstatus.h: Fix common/ includes.
15012 * target/waitstatus.c: Fix common/ includes.
15013 * target.h: Fix common/ includes.
15014 * target.c: Fix common/ includes.
15015 * target-memory.c: Fix common/ includes.
15016 * target-descriptions.c: Fix common/ includes.
15017 * symtab.h: Fix common/ includes.
15018 * symfile.c: Fix common/ includes.
15019 * stap-probe.c: Fix common/ includes.
15020 * spu-linux-nat.c: Fix common/ includes.
15021 * sparc-nat.c: Fix common/ includes.
15022 * source.c: Fix common/ includes.
15023 * solib.c: Fix common/ includes.
15024 * solib-target.c: Fix common/ includes.
15025 * ser-unix.c: Fix common/ includes.
15026 * ser-tcp.c: Fix common/ includes.
15027 * ser-pipe.c: Fix common/ includes.
15028 * ser-base.c: Fix common/ includes.
15029 * selftest-arch.c: Fix common/ includes.
15030 * s12z-tdep.c: Fix common/ includes.
15031 * rust-exp.y: Fix common/ includes.
15032 * rs6000-aix-tdep.c: Fix common/ includes.
15033 * riscv-tdep.c: Fix common/ includes.
15034 * remote.c: Fix common/ includes.
15035 * remote-notif.h: Fix common/ includes.
15036 * remote-fileio.h: Fix common/ includes.
15037 * remote-fileio.c: Fix common/ includes.
15038 * regcache.h: Fix common/ includes.
15039 * regcache.c: Fix common/ includes.
15040 * record-btrace.c: Fix common/ includes.
15041 * python/python.c: Fix common/ includes.
15042 * python/py-type.c: Fix common/ includes.
15043 * python/py-inferior.c: Fix common/ includes.
15044 * progspace.h: Fix common/ includes.
15045 * producer.c: Fix common/ includes.
15046 * procfs.c: Fix common/ includes.
15047 * proc-api.c: Fix common/ includes.
15048 * printcmd.c: Fix common/ includes.
15049 * ppc-linux-nat.c: Fix common/ includes.
15050 * parser-defs.h: Fix common/ includes.
15051 * osdata.c: Fix common/ includes.
15052 * obsd-nat.c: Fix common/ includes.
15053 * nat/x86-linux.c: Fix common/ includes.
15054 * nat/x86-linux-dregs.c: Fix common/ includes.
15055 * nat/x86-dregs.h: Fix common/ includes.
15056 * nat/x86-dregs.c: Fix common/ includes.
15057 * nat/ppc-linux.c: Fix common/ includes.
15058 * nat/mips-linux-watch.h: Fix common/ includes.
15059 * nat/mips-linux-watch.c: Fix common/ includes.
15060 * nat/linux-waitpid.c: Fix common/ includes.
15061 * nat/linux-ptrace.h: Fix common/ includes.
15062 * nat/linux-ptrace.c: Fix common/ includes.
15063 * nat/linux-procfs.c: Fix common/ includes.
15064 * nat/linux-personality.c: Fix common/ includes.
15065 * nat/linux-osdata.c: Fix common/ includes.
15066 * nat/linux-namespaces.c: Fix common/ includes.
15067 * nat/linux-btrace.h: Fix common/ includes.
15068 * nat/linux-btrace.c: Fix common/ includes.
15069 * nat/fork-inferior.c: Fix common/ includes.
15070 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15071 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15072 * nat/aarch64-linux.c: Fix common/ includes.
15073 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15074 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15075 * namespace.h: Fix common/ includes.
15076 * mips-linux-tdep.c: Fix common/ includes.
15077 * minsyms.c: Fix common/ includes.
15078 * mi/mi-parse.h: Fix common/ includes.
15079 * mi/mi-main.c: Fix common/ includes.
15080 * mi/mi-cmd-env.c: Fix common/ includes.
15081 * memrange.h: Fix common/ includes.
15082 * memattr.c: Fix common/ includes.
15083 * maint.h: Fix common/ includes.
15084 * maint.c: Fix common/ includes.
15085 * main.c: Fix common/ includes.
15086 * machoread.c: Fix common/ includes.
15087 * location.c: Fix common/ includes.
15088 * linux-thread-db.c: Fix common/ includes.
15089 * linux-nat.c: Fix common/ includes.
15090 * linux-fork.c: Fix common/ includes.
15091 * inline-frame.c: Fix common/ includes.
15092 * infrun.c: Fix common/ includes.
15093 * inflow.c: Fix common/ includes.
15094 * inferior.h: Fix common/ includes.
15095 * inferior.c: Fix common/ includes.
15096 * infcmd.c: Fix common/ includes.
15097 * inf-ptrace.c: Fix common/ includes.
15098 * inf-child.c: Fix common/ includes.
15099 * ia64-linux-nat.c: Fix common/ includes.
15100 * i387-tdep.c: Fix common/ includes.
15101 * i386-tdep.c: Fix common/ includes.
15102 * i386-linux-tdep.c: Fix common/ includes.
15103 * i386-linux-nat.c: Fix common/ includes.
15104 * i386-go32-tdep.c: Fix common/ includes.
15105 * i386-fbsd-tdep.c: Fix common/ includes.
15106 * i386-fbsd-nat.c: Fix common/ includes.
15107 * guile/scm-type.c: Fix common/ includes.
15108 * guile/guile.c: Fix common/ includes.
15109 * go32-nat.c: Fix common/ includes.
15110 * gnu-nat.c: Fix common/ includes.
15111 * gdbthread.h: Fix common/ includes.
15112 * gdbarch-selftests.c: Fix common/ includes.
15113 * gdb_usleep.c: Fix common/ includes.
15114 * gdb_select.h: Fix common/ includes.
15115 * gdb_bfd.c: Fix common/ includes.
15116 * gcore.c: Fix common/ includes.
15117 * fork-child.c: Fix common/ includes.
15118 * findvar.c: Fix common/ includes.
15119 * fbsd-nat.c: Fix common/ includes.
15120 * event-top.c: Fix common/ includes.
15121 * event-loop.c: Fix common/ includes.
15122 * dwarf2read.c: Fix common/ includes.
15123 * dwarf2loc.c: Fix common/ includes.
15124 * dwarf2-frame.c: Fix common/ includes.
15125 * dwarf-index-cache.c: Fix common/ includes.
15126 * dtrace-probe.c: Fix common/ includes.
15127 * disasm-selftests.c: Fix common/ includes.
15128 * defs.h: Fix common/ includes.
15129 * csky-tdep.c: Fix common/ includes.
15130 * cp-valprint.c: Fix common/ includes.
15131 * cp-support.h: Fix common/ includes.
15132 * cp-support.c: Fix common/ includes.
15133 * corelow.c: Fix common/ includes.
15134 * completer.h: Fix common/ includes.
15135 * completer.c: Fix common/ includes.
15136 * compile/compile.c: Fix common/ includes.
15137 * compile/compile-loc2c.c: Fix common/ includes.
15138 * compile/compile-cplus-types.c: Fix common/ includes.
15139 * compile/compile-cplus-symbols.c: Fix common/ includes.
15140 * command.h: Fix common/ includes.
15141 * cli/cli-dump.c: Fix common/ includes.
15142 * cli/cli-cmds.c: Fix common/ includes.
15143 * charset.c: Fix common/ includes.
15144 * build-id.c: Fix common/ includes.
15145 * btrace.h: Fix common/ includes.
15146 * btrace.c: Fix common/ includes.
15147 * breakpoint.h: Fix common/ includes.
15148 * breakpoint.c: Fix common/ includes.
15149 * ax.h:
15150 (enum agent_op): Fix common/ includes.
15151 * ax-general.c (struct aop_map): Fix common/ includes.
15152 * ax-gdb.c: Fix common/ includes.
15153 * auxv.c: Fix common/ includes.
15154 * auto-load.c: Fix common/ includes.
15155 * arm-tdep.c: Fix common/ includes.
15156 * arch/riscv.c: Fix common/ includes.
15157 * arch/ppc-linux-common.c: Fix common/ includes.
15158 * arch/i386.c: Fix common/ includes.
15159 * arch/arm.c: Fix common/ includes.
15160 * arch/arm-linux.c: Fix common/ includes.
15161 * arch/arm-get-next-pcs.c: Fix common/ includes.
15162 * arch/amd64.c: Fix common/ includes.
15163 * arch/aarch64.c: Fix common/ includes.
15164 * arch/aarch64-insn.c: Fix common/ includes.
15165 * arch-utils.c: Fix common/ includes.
15166 * amd64-windows-tdep.c: Fix common/ includes.
15167 * amd64-tdep.c: Fix common/ includes.
15168 * amd64-sol2-tdep.c: Fix common/ includes.
15169 * amd64-obsd-tdep.c: Fix common/ includes.
15170 * amd64-nbsd-tdep.c: Fix common/ includes.
15171 * amd64-linux-tdep.c: Fix common/ includes.
15172 * amd64-linux-nat.c: Fix common/ includes.
15173 * amd64-fbsd-tdep.c: Fix common/ includes.
15174 * amd64-fbsd-nat.c: Fix common/ includes.
15175 * amd64-dicos-tdep.c: Fix common/ includes.
15176 * amd64-darwin-tdep.c: Fix common/ includes.
15177 * agent.c: Fix common/ includes.
15178 * ada-lang.h: Fix common/ includes.
15179 * ada-lang.c: Fix common/ includes.
15180 * aarch64-tdep.c: Fix common/ includes.
15181
15182 2019-01-25 Tom Tromey <tom@tromey.com>
15183
15184 * common/create-version.sh: Use common/version.h.
15185
15186 2019-01-24 Pedro Alves <palves@redhat.com>
15187
15188 * infrun.c (signal_stop, signal_print, signal_program)
15189 (signal_catch, signal_pass): Now arrays instead of pointers.
15190 (update_signals_program_target, do_target_resume)
15191 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15192 * linux-nat.c (linux_nat_target::pass_signals)
15193 (linux_nat_target::create_inferior, linux_nat_target::attach):
15194 Adjust.
15195 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15196 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15197 * procfs.c (procfs_target::pass_signals): Adjust.
15198 * record-full.c (record_full_target::resume): Adjust.
15199 * remote.c (remote_target::pass_signals)
15200 (remote_target::program_signals): Adjust.
15201 * target-debug.h (target_debug_print_signals): Now takes a
15202 gdb::array_view as parameter. Adjust.
15203 * target.h (target_ops) <pass_signals, program_signals>: Replace
15204 pointer and length parameters with gdb::array_view.
15205 (target_pass_signals, target_program_signals): Likewise.
15206 * target-delegates.c: Regenerate.
15207
15208 2019-01-24 Pedro Alves <palves@redhat.com>
15209
15210 * common/forward-scope-exit.h
15211 (forward_scope_exit::forward_scope_exit): Pass arguments to
15212 m_bind_function directly, instead of creating a std::bind and
15213 copying that.
15214
15215 2019-01-24 Alan Hayward <alan.hayward@arm.com>
15216
15217 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15218 for static members.
15219 (pass_in_v_vfp_candidate): Likewise.
15220
15221 2019-01-23 Tom Tromey <tom@tromey.com>
15222 Pedro Alves <palves@redhat.com>
15223
15224 * regcache.c (class regcache_invalidator): Remove.
15225 (regcache::raw_write): Use make_scope_exit.
15226
15227 2019-01-23 Tom Tromey <tom@tromey.com>
15228
15229 * ui-out.h (class ui_out_emit_type): Update comment.
15230
15231 2019-01-23 Tom Tromey <tom@tromey.com>
15232
15233 * infrun.c (fetch_inferior_event): Update comment.
15234
15235 2019-01-23 Tom Tromey <tom@tromey.com>
15236 Pedro Alves <palves@redhat.com>
15237
15238 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15239 parameter.
15240 (fetch_inferior_event): Use SCOPE_EXIT.
15241
15242
15243 2019-01-23 Tom Tromey <tom@tromey.com>
15244 Pedro Alves <palves@redhat.com>
15245
15246 * infrun.c (disable_thread_events): Delete.
15247 (stop_all_threads): Use SCOPE_EXIT.
15248
15249 2019-01-23 Tom Tromey <tom@tromey.com>
15250 Pedro Alves <palves@redhat.com>
15251
15252 * symfile.c: Include forward-scope-exit.h.
15253 (clear_symtab_users_cleanup): Replace forward declaration with
15254 a FORWARD_SCOPE_EXIT.
15255 (syms_from_objfile_1): Use the forward_scope_exit and
15256 gdb::optional instead of cleanup_function.
15257 (reread_symbols): Use the forward_scope_exit instead of
15258 cleanup_function.
15259 (clear_symtab_users_cleanup): Remove function.
15260
15261 2019-01-23 Tom Tromey <tom@tromey.com>
15262 Pedro Alves <palves@redhat.com>
15263
15264 * linux-nat.c: Include scope-exit.h.
15265 (cleanup_target_stop): Remove.
15266 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15267 SCOPE_EXIT.
15268
15269 2019-01-23 Tom Tromey <tom@tromey.com>
15270 Pedro Alves <palves@redhat.com>
15271
15272 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15273 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15274
15275 2019-01-23 Tom Tromey <tom@tromey.com>
15276 Andrew Burgess <andrew.burgess@embecosm.com>
15277 Pedro Alves <palves@redhat.com>
15278
15279 * infrun.c (fetch_inferior_event): Use scope_exit.
15280 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15281 * top.c (execute_command): Use scope_exit.
15282 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15283 * utils.c (do_bpstat_clear_actions_cleanup)
15284 (make_bpstat_clear_actions_cleanup): Remove.
15285
15286 2019-01-23 Tom Tromey <tom@tromey.com>
15287 Pedro Alves <palves@redhat.com>
15288
15289 * infrun.c: Include "common/scope-exit.h"
15290 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15291 (wait_for_inferior): Use SCOPE_EXIT.
15292 (fetch_inferior_event): Use scope_exit.
15293
15294 2019-01-23 Tom Tromey <tom@tromey.com>
15295 Pedro Alves <palves@redhat.com>
15296
15297 * breakpoint.c (create_breakpoint): Remove cleanup.
15298
15299 2019-01-23 Tom Tromey <tom@tromey.com>
15300 Andrew Burgess <andrew.burgess@embecosm.com>
15301 Pedro Alves <palves@redhat.com>
15302
15303 2019-01-23 Pedro Alves <palves@redhat.com>
15304
15305 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15306
15307 2019-01-23 Pedro Alves <palves@redhat.com>
15308 Andrew Burgess <andrew.burgess@embecosm.com>
15309
15310 * gdbthread.h: Include "common/forward-scope-exit.h".
15311 (scoped_finish_thread_state): Redefine custom class in terms of
15312 forward_scope_exit.
15313
15314 2019-01-23 Pedro Alves <palves@redhat.com>
15315 Andrew Burgess <andrew.burgess@embecosm.com>
15316
15317 * common/forward-scope-exit.h: New file.
15318
15319 2019-01-23 Pedro Alves <palves@redhat.com>
15320 Andrew Burgess <andrew.burgess@embecosm.com>
15321 Tom Tromey <tom@tromey.com>
15322
15323 * common/scope-exit.h: New file.
15324
15325 2019-01-23 Pedro Alves <palves@redhat.com>
15326
15327 * common/preprocessor.h (ESC): Rename to ...
15328 (ESC_PARENS): ... this.
15329 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15330 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15331
15332 2019-01-23 Tom Tromey <tom@tromey.com>
15333
15334 * language.h (class scoped_switch_to_sym_language_if_auto):
15335 Initialize m_lang in both cases.
15336
15337 2019-01-23 Alan Hayward <alan.hayward@arm.com>
15338
15339 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15340 with XCNEW.
15341
15342 2019-01-22 Tom Tromey <tom@tromey.com>
15343
15344 * corelow.c: Do not include sys/file.h.
15345
15346 2019-01-22 Tom Tromey <tom@tromey.com>
15347
15348 * tui/tui-wingeneral.h: Include gdb_curses.h.
15349
15350 2019-01-22 Tom Tromey <tom@tromey.com>
15351
15352 * source-cache.h (class source_cache) <get_source_lines,
15353 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15354
15355 2019-01-22 Tom Tromey <tom@tromey.com>
15356
15357 * remote-fileio.h (struct remote_target): Declare.
15358
15359 2019-01-22 Tom Tromey <tom@tromey.com>
15360
15361 * python/py-arch.c: Do not include py-ref.h.
15362 * python/py-bpevent.c: Do not include py-ref.h.
15363 * python/py-cmd.c: Do not include py-ref.h.
15364 * python/py-continueevent.c: Do not include py-ref.h.
15365 * python/py-event.h: Do not include py-ref.h.
15366 * python/py-evtregistry.c: Do not include py-ref.h.
15367 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15368 * python/py-frame.c: Do not include py-ref.h.
15369 * python/py-framefilter.c: Do not include py-ref.h.
15370 * python/py-function.c: Do not include py-ref.h.
15371 * python/py-infevents.c: Do not include py-ref.h.
15372 * python/py-linetable.c: Do not include py-ref.h.
15373 * python/py-objfile.c: Do not include py-ref.h.
15374 * python/py-param.c: Do not include py-ref.h.
15375 * python/py-prettyprint.c: Do not include py-ref.h.
15376 * python/py-progspace.c: Do not include py-ref.h.
15377 * python/py-symbol.c: Do not include py-ref.h.
15378 * python/py-symtab.c: Do not include py-ref.h.
15379 * python/py-type.c: Do not include py-ref.h.
15380 * python/py-unwind.c: Do not include py-ref.h.
15381 * python/py-utils.c: Do not include py-ref.h.
15382 * python/py-value.c: Do not include py-ref.h.
15383 * python/py-varobj.c: Do not include py-ref.h.
15384 * python/py-xmethods.c: Do not include py-ref.h.
15385 * python/python.c: Do not include py-ref.h.
15386 * varobj.c: Do not include py-ref.h.
15387
15388 2019-01-22 Tom Tromey <tom@tromey.com>
15389
15390 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15391 keyword for bcache.
15392
15393 2019-01-22 Tom Tromey <tom@tromey.com>
15394
15395 * compile/compile-cplus-types.c: Remove a comment by #include.
15396
15397 2019-01-22 Tom Tromey <tom@tromey.com>
15398
15399 * compile/gcc-c-plugin.h: Include compile-internal.h.
15400
15401 2019-01-22 Tom Tromey <tom@tromey.com>
15402
15403 * stabsread.c (EXTERN): Do not define.
15404 (symnum, next_symbol_text_func, processing_gcc_compilation)
15405 (within_function, global_sym_chain, global_stabs)
15406 (previous_stab_code, this_object_header_files)
15407 (n_this_object_header_files)
15408 (n_allocated_this_object_header_files): Define.
15409 * stabsread.h (EXTERN): Never define. Use "extern".
15410
15411 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15412
15413 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15414 history_value.
15415
15416 2019-01-21 Tom Tromey <tom@tromey.com>
15417
15418 * ui-out.c: Fix includes.
15419 * tui/tui-source.c: Fix includes.
15420 * target.c: Fix includes.
15421 * remote.c: Fix includes.
15422 * regcache.c: Fix includes.
15423 * python/py-block.c: Fix includes.
15424 * printcmd.c: Fix includes.
15425 * or1k-tdep.c: Fix includes.
15426 * mi/mi-main.c: Fix includes.
15427 * m32r-tdep.c: Fix includes.
15428 * csky-tdep.c: Fix includes.
15429 * compile/compile-cplus-types.c: Fix includes.
15430 * cli/cli-interp.c: Fix includes.
15431
15432 2019-01-21 Alan Hayward <alan.hayward@arm.com>
15433
15434 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15435 for padding.
15436
15437 2019-01-16 Tom Tromey <tom@tromey.com>
15438
15439 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15440 earlier.
15441 (struct objfile) <msymbols_range>: Move from top level.
15442 <msymbols>: New method.
15443 (class objfile_msymbols): Remove.
15444 * symtab.c (default_collect_symbol_completion_matches_break_on):
15445 Update.
15446 * symmisc.c (dump_msymbols): Update.
15447 * stabsread.c (scan_file_globals): Update.
15448 * objc-lang.c (info_selectors_command, info_classes_command)
15449 (find_methods): Update.
15450 * minsyms.c (find_solib_trampoline_target): Update.
15451 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15452 * coffread.c (coff_symfile_read): Update.
15453 * ada-lang.c (ada_lookup_simple_minsym)
15454 (ada_collect_symbol_completion_matches): Update.
15455
15456 2019-01-16 Tom Tromey <tom@tromey.com>
15457
15458 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15459 type. Remove no-argument constructor.
15460 <iterator::operator++>: Simplify.
15461 <begin>: Update.
15462 <end>: Use minimal_symbol_count.
15463
15464 2019-01-16 Tom Tromey <tom@tromey.com>
15465
15466 * objfiles.h (struct objfile) <psymtabs>: New method.
15467 (class objfile_psymtabs): Remove.
15468 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15469 typedef.
15470 <range>: New method.
15471 (require_partial_symbols): Change return type.
15472 * psymtab.c (require_partial_symbols)
15473 (psym_expand_symtabs_matching): Update.
15474 * mdebugread.c (parse_partial_symbols): Update.
15475 * dbxread.c (dbx_end_psymtab): Update.
15476
15477 2019-01-15 Tom Tromey <tom@tromey.com>
15478
15479 * symtab.c (lookup_objfile_from_block)
15480 (lookup_symbol_in_objfile_symtabs)
15481 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15482 (find_line_symtab, info_sources_command)
15483 (default_collect_symbol_completion_matches_break_on)
15484 (make_source_files_completion_list): Update.
15485 * symmisc.c (print_objfile_statistics, dump_objfile)
15486 (maintenance_print_symbols, maintenance_info_symtabs)
15487 (maintenance_check_symtabs, maintenance_info_line_tables):
15488 Update.
15489 * source.c (select_source_symtab)
15490 (forget_cached_source_info_for_objfile): Update.
15491 * objfiles.h (class objfile_compunits): Remove.
15492 (struct objfile) <compunits_range>: New typedef.
15493 (compunits): New method.
15494 * objfiles.c (objfile_relocate1): Update.
15495 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15496 * maint.c (count_symtabs_and_blocks): Update.
15497 * linespec.c (iterate_over_all_matching_symtabs): Update.
15498 * cp-support.c (add_symbol_overload_list_qualified): Update.
15499 * coffread.c (coff_symtab_read): Update.
15500 * ada-lang.c (add_nonlocal_symbols)
15501 (ada_collect_symbol_completion_matches)
15502 (ada_add_global_exceptions): Update.
15503
15504 2019-01-15 Tom Tromey <tom@tromey.com>
15505
15506 * progspace.h (program_space) <objfiles_safe_range>: New
15507 typedef.
15508 <objfiles_safe>: New method.
15509 * objfiles.h (class all_objfiles_safe): Remove.
15510 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15511 * jit.c (jit_inferior_exit_hook): Update.
15512
15513 2019-01-17 Tom Tromey <tom@tromey.com>
15514
15515 * progspace.h (program_space) <objfiles_range>: New typedef.
15516 <objfiles>: New method.
15517 <objfiles_head>: Rename from objfiles.
15518 (object_files): Update.
15519 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15520 * guile/scm-pretty-print.c
15521 (ppscm_find_pretty_printer_from_objfiles): Update.
15522 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15523 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15524 Update.
15525 * python/py-progspace.c (pspy_get_objfiles): Update.
15526 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15527 Update.
15528 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15529 (objfpy_lookup_objfile_by_build_id): Update.
15530 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15531 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15532 Update.
15533 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15534 (expand_symtab_containing_pc, lookup_objfile_from_block)
15535 (lookup_static_symbol, basic_lookup_transparent_type)
15536 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15537 (find_line_symtab, info_sources_command)
15538 (default_collect_symbol_completion_matches_break_on)
15539 (make_source_files_completion_list, find_main_name): Update.
15540 * symmisc.c (print_symbol_bcache_statistics)
15541 (print_objfile_statistics, maintenance_print_symbols)
15542 (maintenance_print_msymbols, maintenance_print_objfiles)
15543 (maintenance_info_symtabs, maintenance_check_symtabs)
15544 (maintenance_expand_symtabs, maintenance_info_line_tables):
15545 Update.
15546 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15547 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15548 (map_overlay_command, unmap_overlay_command)
15549 (simple_overlay_update, expand_symtabs_matching)
15550 (map_symbol_filenames): Update.
15551 * symfile-debug.c (set_debug_symfile): Update.
15552 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15553 Update.
15554 * source.c (select_source_symtab, forget_cached_source_info):
15555 Update.
15556 * solib.c (solib_read_symbols): Update.
15557 * solib-spu.c (append_ocl_sos): Update.
15558 * psymtab.c (maintenance_print_psymbols)
15559 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15560 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15561 * printcmd.c (info_symbol_command): Update.
15562 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15563 Update.
15564 * objfiles.h (class all_objfiles): Remove.
15565 * objfiles.c (have_partial_symbols, have_full_symbols)
15566 (have_minimal_symbols, qsort_cmp, update_section_map)
15567 (shared_objfile_contains_address_p)
15568 (default_iterate_over_objfiles_in_search_order): Update.
15569 * objc-lang.c (info_selectors_command, info_classes_command)
15570 (find_methods): Update.
15571 * minsyms.c (find_solib_trampoline_target): Update.
15572 * maint.c (maintenance_info_sections)
15573 (maintenance_translate_address, count_symtabs_and_blocks):
15574 Update.
15575 * main.c (captured_main_1): Update.
15576 * linux-thread-db.c (try_thread_db_load_from_pdir)
15577 (has_libpthread): Update.
15578 * linespec.c (iterate_over_all_matching_symtabs)
15579 (search_minsyms_for_name): Update.
15580 * jit.c (jit_find_objf_with_entry_addr): Update.
15581 * hppa-tdep.c (find_unwind_entry)
15582 (hppa_lookup_stub_minimal_symbol): Update.
15583 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15584 Update.
15585 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15586 (elf_gnu_ifunc_resolve_by_got): Update.
15587 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15588 * dwarf-index-write.c (save_gdb_index_command): Update.
15589 * cp-support.c (add_symbol_overload_list_qualified): Update.
15590 * breakpoint.c (create_overlay_event_breakpoint)
15591 (create_longjmp_master_breakpoint)
15592 (create_std_terminate_master_breakpoint)
15593 (create_exception_master_breakpoint): Update.
15594 * blockframe.c (find_pc_partial_function): Update.
15595 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15596 (ada_collect_symbol_completion_matches)
15597 (ada_add_global_exceptions): Update.
15598
15599 2019-01-17 Tom Tromey <tom@tromey.com>
15600
15601 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15602 declare VEC.
15603 (solib_target_parse_libraries): Change return type.
15604 (library_list_start_segment, library_list_start_section)
15605 (library_list_end_library, library_list_start_library); Update.
15606 (solib_target_free_library_list): Remove.
15607 (solib_target_parse_libraries): Remove cleanup. Change return
15608 type.
15609 (solib_target_current_sos): Update.
15610
15611 2019-01-17 Tom Tromey <tromey@bapiya>
15612
15613 * valprint.c: Replace "the the" with "the".
15614 * symtab.c: Replace "the the" with "the".
15615 * solib.c: Replace "the the" with "the".
15616 * solib-dsbt.c: Replace "the the" with "the".
15617 * linespec.c: Replace "the the" with "the".
15618 * dwarf2loc.h: Replace "the the" with "the".
15619 * amd64-windows-tdep.c: Replace "the the" with "the".
15620 * aarch64-tdep.c: Replace "the the" with "the".
15621
15622 2019-01-16 Keith Seitz <keiths@redhat.com>
15623
15624 PR gdb/23773
15625 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15626 <builder>: Rename to ..
15627 <m_builder>: ... this and make private.
15628 (dwarf2_cu::get_builder): New method. Change all users of
15629 `builder' to use this method.
15630 (dwarf2_start_symtab): Move to ...
15631 (dwarf2_cu::start_symtab): ... here. Update all callers
15632 (setup_type_unit_groups): Move to ...
15633 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15634 callers.
15635 (dwarf2_cu::reset_builder): New method.
15636 (process_full_compunit, process_full_type_unit): Use
15637 dwarf2_cu::reset_builder.
15638 (follow_die_offset): Record the ancestor CU if it is different
15639 from the followed DIE's CU.
15640 (follow_die_sig_1): Likewise.
15641
15642 2019-01-15 Tom Tromey <tom@tromey.com>
15643
15644 * remote.c (class remote_state) <buf>: Now a char_vector.
15645 <buf_size>: Remove.
15646 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15647 parameter.
15648 (remote_target::getpkt_or_notif_sane_1)
15649 (remote_target::getpkt_sane)
15650 (remote_target::getpkt_or_notif_sane): Likewise.
15651 (class remote_target) <putpkt>: New overload.
15652 (remote_target::read_frame): Change type of "buf_p". Remove
15653 sizeof_p parameter.
15654 (packet_ok): New overload.
15655 (packet_check_result): New overload.
15656 Update all uses.
15657
15658 2019-01-14 Tom Tromey <tom@tromey.com>
15659
15660 * remote-notif.c (handle_notification, remote_notif_ack)
15661 (remote_notif_parse): Make "buf" const.
15662 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15663 const.
15664 (remote_notif_parse, remote_notif_ack, handle_notification):
15665 Likewise.
15666 * remote.c (remote_notif_stop_parse): Make "buf" const.
15667 (remote_target::remote_parse_stop_reply): Make "buf" const.
15668 (remote_notif_stop_ack): Make "buf" const.
15669
15670 2019-01-14 Tom Tromey <tom@tromey.com>
15671
15672 * remote.c (remote_console_output): Make parameter const.
15673
15674 2019-01-14 Tom Tromey <tom@tromey.com>
15675
15676 * target-debug.h (target_debug_print_signals): Constify.
15677 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15678 * procfs.c (procfs_target::pass_signals): Update.
15679 * linux-nat.c (linux_nat_target::pass_signals): Update.
15680 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15681 * target-delegates.c: Rebuild.
15682 * remote.c (remote_target::program_signals): Update.
15683 (remote_target::pass_signals): Update.
15684 * target.c (target_pass_signals): Constify argument.
15685 (target_program_signals): Likewise.
15686 * target.h (struct target_ops) <pass_signals, program_signals>:
15687 Constify argument.
15688 (target_pass_signals, target_program_signals): Constify argument.
15689
15690 2019-01-14 Tom Tromey <tom@tromey.com>
15691
15692 PR tui/28819:
15693 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15694
15695 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15696
15697 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15698 field.
15699 * rs6000-tdep.c: Include reggroups.h.
15700 (IS_V_ALIAS_PSEUDOREG): Define.
15701 (rs6000_register_name): Return names for the "vX" aliases.
15702 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15703 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15704 aliases. Call default_register_reggroup_p for all other
15705 pseudo-registers.
15706 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15707 New functions.
15708 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15709 Handle "vX" aliases.
15710 (v_alias_pseudo_register_collect): New function.
15711 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15712 (rs6000_gdbarch_init): Initialize "vX" aliases as
15713 pseudo-registers. Restore registration of
15714 rs6000_pseudo_register_reggroup_p with
15715 set_tdesc_pseudo_register_reggroup_p.
15716
15717 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15718
15719 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15720 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15721 set_gdbarch_num_pseudo_regs.
15722
15723 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15724
15725 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15726 Remove arg prefixname, add do_set and do_show.
15727 Add member functions set_list and show_list.
15728 * cli/cli-style.c (class cli_style_option): Update accordingly.
15729 (style_set_list): Move to file scope.
15730 (style_show_list): Likewise.
15731 (set_style): Call help_list.
15732 (show_style): Call cmd_show_list.
15733 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15734 Update to use the new macro.
15735
15736 2019-10-12 Joel Brobecker <brobecker@adacore.com>
15737
15738 * ada-lang.c (_initialize_ada_language): Expand the help text
15739 for the "catch exception" command.
15740
15741 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15742
15743 * symtab.c (matching_obj_sections): Initialize obj,
15744 declare it closer to its usage.
15745
15746 2019-01-10 Tom Tromey <tom@tromey.com>
15747
15748 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15749 (basic_inf_threads_range): Remove.
15750 (inf_threads_range, inf_non_exited_threads_range)
15751 (safe_inf_threads_range): Use next_adapter.
15752
15753 2019-01-10 Keith Seitz <keiths@redhat.com>
15754
15755 PR gdb/23712
15756 PR symtab/23010
15757 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15758 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15759
15760 2019-01-10 Keith Seitz <keiths@redhat.com>
15761
15762 PR gdb/23712
15763 PR symtab/23010
15764 * dictionary.c (pending_to_vector): Remove.
15765 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15766 Remove _1 suffix, replacing functions of the same name. Update
15767 all callers.
15768 (dict_create_hashed, dict_create_hashed_expandable)
15769 (dict_create_linear, dict_create_linear_expandable, dict_free)
15770 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15771 Make functions static.
15772
15773 2019-01-10 Keith Seitz <keiths@redhat.com>
15774
15775 PR gdb/23712
15776 PR symtab/23010
15777 * dictionary.h (struct dictionary): Replace declaration with
15778 multidictionary.
15779 (dict_create_hashed, dict_create_hashed_expandable)
15780 (dict_create_linear, dict_create_linear_expandable)
15781 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15782 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15783 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15784 taking multidictionary argument.
15785 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15786 * block.h (struct block) <dict>: Change to multidictionary
15787 and rename `multidict'.
15788 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15789 symmisc.c: Update all dictionary references to multidictionary.
15790
15791 2019-01-10 Keith Seitz <keiths@redhat.com>
15792
15793 PR gdb/23712
15794 PR symtab/23010
15795 * dictionary.c: Include unordered_map.
15796 (pending_to_vector): New function.
15797 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15798 Rewrite the non-"_1" functions to take vector instead
15799 of linked list.
15800 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15801 "new" _1 versions of the same name.
15802 (multidictionary): Define.
15803 (std::hash<enum language): New definition.
15804 (collate_pending_symbols_by_language, mdict_create_hashed)
15805 (mdict_create_hashed_expandable, mdict_create_linear)
15806 (mdict_create_linear_expandable, mdict_free)
15807 (find_language_dictionary, create_new_language_dictionary)
15808 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15809 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15810 (mdict_size, mdict_empty): New functions.
15811 * dictionary.h (mdict_iterator): Define.
15812
15813 2019-01-10 Pedro Alves <palves@redhat.com>
15814
15815 * breakpoint.c (read_uploaded_action)
15816 (create_tracepoint_from_upload): Adjust to use
15817 gdb::unique_xmalloc_ptr.
15818 * ctf.c (ctf_write_uploaded_tp):
15819 (SET_ARRAY_FIELD): Use emplace_back.
15820 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15821 * tracefile-tfile.c (tfile_write_uploaded_tp):
15822 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15823 gdb::unique_xmalloc_ptr.
15824 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15825 at_string, cond_string, cmd_strings>: Replace char pointers
15826 with gdb::unique_xmalloc_ptr.
15827
15828 2019-01-10 Pedro Alves <palves@redhat.com>
15829
15830 * solib-target.c (library_list_start_library): Don't xstrdup name.
15831
15832 2019-01-10 Pedro Alves <palves@redhat.com>
15833
15834 * mdebugread.c (parse_partial_symbols): Use
15835 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15836
15837 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15838
15839 * linux-fork.c (scoped_switch_fork_info)
15840 <~scoped_switch_fork_info>: Fix incorrect variable name.
15841
15842 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15843
15844 * linux-fork.c (scoped_switch_fork_info)
15845 <scoped_switch_fork_info>: Make explicit.
15846 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15847
15848 2019-01-10 Tom Tromey <tom@tromey.com>
15849
15850 * objfiles.h (objfile::reset_psymtabs): Update.
15851 * objfiles.c (objfile::objfile): Update.
15852 * psymtab.h (psymtab_storage::obstack): Update.
15853 (psymtab_storage::m_obstack): Use gdb::optional.
15854 (class psymtab_storage): Update comment. Remove objfile
15855 parameter.
15856 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15857
15858 2019-01-10 Tom Tromey <tom@tromey.com>
15859
15860 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15861 <free_psymtabs>: Now private.
15862 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15863 (allocate_psymtab): Use new method.
15864
15865 2019-01-10 Tom Tromey <tom@tromey.com>
15866
15867 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15868 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15869 * mdebugread.c (parse_partial_symbols): Use
15870 allocate_dependencies.
15871 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15872 allocate_dependencies.
15873 (process_psymtab_comp_unit_reader)
15874 (build_type_psymtab_dependencies): Likewise.
15875 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15876
15877 2019-01-10 Tom Tromey <tom@tromey.com>
15878
15879 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15880 PSYMBOL_SET_LANGUAGE.
15881 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15882
15883 2019-01-10 Tom Tromey <tom@tromey.com>
15884
15885 * psymtab.h (psymtab_storage::obstack): New method.
15886 <m_obstack>: Rename from obstack; now private.
15887 * psymtab.c (psymtab_storage): Update.
15888 * dwarf2read.c (create_addrmap_from_index)
15889 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15890 Update.
15891
15892 2019-01-10 Tom Tromey <tom@tromey.com>
15893
15894 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15895 * objfiles.h (objfile::reset_psymtabs): New method.
15896
15897 2019-01-10 Tom Tromey <tom@tromey.com>
15898
15899 * symmisc.c (print_symbol_bcache_statistics): Update.
15900 (print_objfile_statistics): Update.
15901 * symfile.c (reread_symbols): Update.
15902 * psymtab.h (class psymtab_storage): New.
15903 * psymtab.c (psymtab_storage): New constructor.
15904 (~psymtab_storage): New destructor.
15905 (require_partial_symbols): Update.
15906 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15907 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15908 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15909 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15910 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15911 (start_psymtab_common, end_psymtab_common)
15912 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15913 (allocate_psymtab): Update.
15914 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15915 Update.
15916 (dump_psymtab_addrmap, maintenance_print_psymbols)
15917 (maintenance_check_psymtabs): Update.
15918 (class objfile_psymtabs): Move to objfiles.h.
15919 * psympriv.h (discard_psymtab): Now inline.
15920 (psymtab_discarder::psymtab_discarder): Update.
15921 (psymtab_discarder::~psymtab_discarder): Update.
15922 (ALL_OBJFILE_PSYMTABS): Rewrite.
15923 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15924 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15925 Remove fields.
15926 <partial_symtabs>: New field.
15927 (class objfile_psymtabs): Move from psymtab.h. Update.
15928 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15929 psymbol_cache.
15930 (objfile::~objfile): Don't destroy psymbol_cache.
15931 * mdebugread.c (parse_partial_symbols): Update.
15932 * dwarf2read.c (create_addrmap_from_index)
15933 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15934 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15935 (add_partial_subprogram, dwarf2_ranges_read): Update.
15936 * dwarf-index-write.c (write_address_map)
15937 (write_one_signatured_type, recursively_write_psymbols)
15938 (class debug_names, class debug_names, write_psymtabs_to_index):
15939 Update.
15940
15941 2019-01-10 Tom Tromey <tom@tromey.com>
15942
15943 * symtab.h (SYMBOL_SET_NAMES): Update.
15944 (symbol_set_names): Update.
15945 (MSYMBOL_SET_NAMES): Update.
15946 * symtab.c (symbol_set_names): Change argument to be an
15947 objfile_per_bfd_storage.
15948 * psymtab.c (add_psymbol_to_bcache): Update.
15949 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15950
15951 2019-01-10 Tom Tromey <tom@tromey.com>
15952
15953 * symtab.c (create_demangled_names_hash): Change argument to be an
15954 objfile_per_bfd_storage.
15955 (symbol_set_names): Update.
15956
15957 2019-01-10 Tom Tromey <tom@tromey.com>
15958
15959 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15960 init_psymbol_list.
15961 * psymtab.c (init_psymbol_list): Do nothing if already called.
15962 * psympriv.h (init_psymbol_list): Add comment.
15963 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15964 init_psymbol_list.
15965 * dbxread.c (dbx_symfile_read): Unconditionally call
15966 init_psymbol_list.
15967
15968 2019-01-10 Tom Tromey <tom@tromey.com>
15969
15970 * xcoffread.c (scan_xcoff_symtab): Update.
15971 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15972 "where".
15973 * mdebugread.c (parse_partial_symbols)
15974 (handle_psymbol_enumerators): Update.
15975 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15976 * dbxread.c (read_dbx_symtab): Update.
15977 * psympriv.h (psymbol_placement): New enum.
15978 (add_psymbol_to_list): Update.
15979
15980 2019-01-10 Tom Tromey <tom@tromey.com>
15981
15982 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15983 static_psymbols parameters.
15984 (scan_xcoff_symtab): Update.
15985 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15986 static_psymbols parameters.
15987 * psympriv.h (start_psymtab_common): Update.
15988 * mdebugread.c (parse_partial_symbols): Update.
15989 * dwarf2read.c (create_partial_symtab): Update.
15990 * dbxread.c (read_dbx_symtab): Update.
15991 (start_psymtab): Remove global_psymbols and static_psymbols
15992 parameters.
15993
15994 2019-01-10 Tom Tromey <tom@tromey.com>
15995
15996 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15997 * psymtab.c (allocate_psymtab): Add comment.
15998 * psympriv.h (allocate_psymtab): Add comment.
15999 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16000 initializations.
16001 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16002
16003 2019-01-10 Tom Tromey <tom@tromey.com>
16004
16005 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16006 Don't declare.
16007 * mipsread.c: Include mdebugread.h.
16008 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16009 Declare.
16010 * elfread.c: Include mdebugread.h.
16011
16012 2019-01-09 Tom Tromey <tom@tromey.com>
16013
16014 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16015 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16016 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16017 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16018 (psym_lookup_symbol, psym_find_last_source_symtab)
16019 (psym_forget_cached_source_info, psym_print_stats)
16020 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16021 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16022 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16023 (psym_find_compunit_symtab_by_address)
16024 (maintenance_print_psymbols, maintenance_info_psymtabs)
16025 (maintenance_check_psymtabs): Use ranged for.
16026 * psymtab.h (class objfile_psymtabs): New.
16027 (require_partial_symbols): Return objfile_psymtabs.
16028 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16029
16030 2019-01-09 Tom Tromey <tom@tromey.com>
16031
16032 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16033 (find_pc_mapped_section, list_overlays_command)
16034 (map_overlay_command, unmap_overlay_command)
16035 (simple_overlay_update): Use all_objfiles.
16036 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16037 * printcmd.c (info_symbol_command): Use all_objfiles.
16038 * objfiles.h (ALL_OBJSECTIONS): Remove.
16039 * maint.c (maintenance_translate_address): Use all_objfiles.
16040 * gcore.c (gcore_create_callback): Use all_objfiles.
16041 (objfile_find_memory_regions): Likewise.
16042
16043 2019-01-09 Tom Tromey <tom@tromey.com>
16044
16045 * symtab.c (find_line_symtab, info_sources_command)
16046 (make_source_files_completion_list): Use objfile_compunits.
16047 * source.c (select_source_symtab): Use objfile_compunits.
16048 * objfiles.h (struct objfile): Update comment.
16049 (ALL_OBJFILES): Remove.
16050 (ALL_FILETABS): Remove.
16051 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16052 objfile_compunits.
16053
16054 2019-01-09 Tom Tromey <tom@tromey.com>
16055
16056 * symmisc.c (print_objfile_statistics, dump_objfile)
16057 (maintenance_print_symbols): Use compunit_filetabs.
16058 * source.c (forget_cached_source_info_for_objfile): Use
16059 compunit_filetabs.
16060 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16061 (ALL_FILETABS): Use compunit_filetabs.
16062 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16063 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16064
16065 2019-01-09 Tom Tromey <tom@tromey.com>
16066
16067 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16068 (compunit_filetabs): New.
16069 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16070 compunit_filetabs.
16071 (info_sources_command, make_source_files_completion_list): Remove
16072 declaration.
16073 * symmisc.c (print_objfile_statistics, dump_objfile)
16074 (maintenance_print_symbols): Remove declaration.
16075 (maintenance_info_symtabs): Use compunit_filetabs.
16076 (maintenance_info_line_tables): Likewise.
16077 * source.c (select_source_symtab): Change local variable name.
16078 (forget_cached_source_info_for_objfile): Remove declaration.
16079 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16080 * objfiles.c (objfile_relocate1): Remove declaration.
16081 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16082 declaration.
16083 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16084 * coffread.c (coff_symtab_read): Remove declaration.
16085 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16086 compunit_filetabs.
16087
16088 2019-01-09 Tom Tromey <tom@tromey.com>
16089
16090 * symtab.c (lookup_objfile_from_block)
16091 (find_pc_sect_compunit_symtab, search_symbols)
16092 (default_collect_symbol_completion_matches_break_on): Use
16093 objfile_compunits.
16094 * objfiles.h (ALL_COMPUNITS): Remove.
16095 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16096 * cp-support.c (add_symbol_overload_list_qualified): Use
16097 objfile_compunits.
16098 * ada-lang.c (ada_collect_symbol_completion_matches)
16099 (ada_add_global_exceptions): Use objfile_compunits.
16100
16101 2019-01-09 Tom Tromey <tom@tromey.com>
16102
16103 * source.c (select_source_symtab)
16104 (forget_cached_source_info_for_objfile): Remove declaration.
16105 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16106 declaration.
16107 * maint.c (count_symtabs_and_blocks): Remove declaration.
16108 * cp-support.c (add_symbol_overload_list_qualified): Remove
16109 declaration.
16110 * coffread.c (coff_symtab_read): Remove declaration.
16111 * symtab.c (lookup_symbol_in_objfile_symtabs)
16112 (basic_lookup_transparent_type_1): Use objfile_compunits.
16113 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16114 (info_sources_command, search_symbols)
16115 (default_collect_symbol_completion_matches_break_on)
16116 (make_source_files_completion_list): Remove declaration.
16117 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16118 (ada_collect_symbol_completion_matches)
16119 (ada_add_global_exceptions): Remove declaration.
16120 * linespec.c (iterate_over_all_matching_symtabs): Use
16121 objfile_compunits.
16122 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16123 (class objfile_compunits): New.
16124 (ALL_COMPUNITS): Use objfile_compunits.
16125 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16126 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16127 objfile_compunits.
16128 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16129
16130 2019-01-09 Tom Tromey <tom@tromey.com>
16131
16132 * symtab.c (search_symbols)
16133 (default_collect_symbol_completion_matches_break_on): Use
16134 objfile_msymbols.
16135 * ada-lang.c (ada_lookup_simple_minsym)
16136 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16137 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16138 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16139 objfile_msymbols.
16140 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16141 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16142 * objc-lang.c (find_methods): Use objfile_msymbols.
16143 (info_selectors_command, info_classes_command): Likewise.
16144 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16145 * objfiles.h (class objfile_msymbols): New.
16146 (ALL_OBJFILE_MSYMBOLS): Remove.
16147 (ALL_MSYMBOLS): Remove.
16148
16149 2019-01-09 Tom Tromey <tom@tromey.com>
16150
16151 * common/next-iterator.h (next_adapter): Add Iterator template
16152 parameter.
16153 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16154 (class all_objfiles_safe): New.
16155 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16156 * objfiles.c (put_objfile_before): Update comment.
16157 (add_separate_debug_objfile): Likewise.
16158 (free_all_objfiles): Use all_objfiles_safe.
16159 (objfile_purge_solibs): Likewise.
16160
16161 2019-01-09 Tom Tromey <tom@tromey.com>
16162
16163 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16164 (expand_symtab_containing_pc, lookup_static_symbol)
16165 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16166 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16167 all_objfiles.
16168 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16169 * breakpoint.c (create_overlay_event_breakpoint)
16170 (create_longjmp_master_breakpoint)
16171 (create_std_terminate_master_breakpoint)
16172 (create_exception_master_breakpoint): Use all_objfiles.
16173 * linux-thread-db.c (try_thread_db_load_from_pdir)
16174 (has_libpthread): Use all_objfiles.
16175 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16176 * linespec.c (iterate_over_all_matching_symtabs)
16177 (search_minsyms_for_name): Use all_objfiles.
16178 * maint.c (maintenance_info_sections): Use all_objfiles.
16179 * main.c (captured_main_1): Use all_objfiles.
16180 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16181 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16182 * guile/scm-pretty-print.c
16183 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16184 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16185 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16186 (maintenance_print_msymbols): Use all_objfiles.
16187 * source.c (select_source_symtab): Use all_objfiles.
16188 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16189 * symfile.c (remove_symbol_file_command)
16190 (expand_symtabs_matching, map_symbol_filenames): Use
16191 all_objfiles.
16192 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16193 all_objfiles.
16194 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16195 * objc-lang.c (find_methods): Use all_objfiles.
16196 * objfiles.c (have_partial_symbols, have_full_symbols)
16197 (have_minimal_symbols, qsort_cmp)
16198 (default_iterate_over_objfiles_in_search_order): Use
16199 all_objfiles.
16200 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16201 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16202 (maintenance_check_psymtabs): Use all_objfiles.
16203 (ALL_PSYMTABS): Remove.
16204 * compile/compile-object-run.c (do_module_cleanup): Use
16205 all_objfiles.
16206 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16207 * cp-support.c (add_symbol_overload_list_qualified): Use
16208 all_objfiles.
16209 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16210 Use all_objfiles.
16211 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16212 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16213 all_objfiles.
16214 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16215 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16216 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16217 Uses all_objfiles.
16218 * solib.c (solib_read_symbols): Use all_objfiles
16219
16220 2019-01-09 Tom Tromey <tom@tromey.com>
16221
16222 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16223 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16224 all_objfiles.
16225 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16226 * symmisc.c (print_symbol_bcache_statistics)
16227 (print_objfile_statistics, maintenance_print_objfiles)
16228 (maintenance_info_symtabs, maintenance_check_symtabs)
16229 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16230 all_objfiles.
16231 * source.c (forget_cached_source_info): Use all_objfiles.
16232 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16233 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16234 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16235 * objfiles.c (update_section_map): Use all_objfiles.
16236 (shared_objfile_contains_address_p): Likewise.
16237 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16238 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16239
16240 2019-01-09 Tom Tromey <tom@tromey.com>
16241
16242 * common/next-iterator.h: New file.
16243 * objfiles.h (class all_objfiles): New.
16244 (struct objfile_iterator): New.
16245
16246 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16247
16248 * NEWS: Move the description of the changed "frame", "select-frame",
16249 and "info frame" commands to the Changed commands section.
16250
16251 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16252
16253 * gdbtypes.c (check_stub_method_group): Remove handling of old
16254 mangling schemes.
16255 * linespec.c (find_methods): Likewise.
16256 * stabsread.c (read_member_functions): Likewise.
16257 * valops.c (search_struct_method): Likewise.
16258 (value_struct_elt_for_reference): Likewise.
16259 * NEWS: Mention this change.
16260
16261 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16262
16263 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16264 print_source_lines.
16265 * source.c (print_source_lines_base): Update line number check.
16266 (print_source_lines): New function.
16267 (source_lines_range::source_lines_range): New function.
16268 * source.h (class source_lines_range): New class.
16269 (print_source_lines): New declaration.
16270
16271 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16272
16273 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16274
16275 2019-01-08 Tom Tromey <tom@tromey.com>
16276 Simon Marchi <simon.marchi@ericsson.com>
16277
16278 PR gdb/24060
16279 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16280 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16281 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16282 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16283 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16284 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16285
16286 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16287
16288 * source.c (select_source_symtab): Move header comment to
16289 declaration in source.h.
16290 (forget_cached_source_info_for_objfile): Likewise.
16291 (forget_cached_source_info): Likewise.
16292 (identify_source_line): Likewise.
16293 * source.h (identify_source_line): Move declaration from symtab.h
16294 and add comment from source.c
16295 (print_source_lines): Likewise.
16296 (forget_cached_source_info_for_objfile): Likewise.
16297 (forget_cached_source_info): Likewise.
16298 (select_source_symtab): Likewise.
16299 (enum print_source_lines_flag): Move definition from symtab.h.
16300 * symtab.h (identify_source_line): Move declaration to source.h.
16301 (print_source_lines): Likewise.
16302 (forget_cached_source_info_for_objfile): Likewise.
16303 (forget_cached_source_info): Likewise.
16304 (select_source_symtab): Likewise.
16305 (enum print_source_lines_flag): Move definition to source.h.
16306 * tui/tui-hooks.c: Add 'source.h' include.
16307
16308 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16309
16310 * source.c (print_source_lines_base): Handle requests to print
16311 reverse line number sequences, and guard against empty lines
16312 string.
16313
16314 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16315
16316 * source.c (print_source_lines_base): Fix skip of '\r' if next
16317 character is '\n'.
16318
16319 2019-01-06 Tom Tromey <tom@tromey.com>
16320
16321 * c-exp.y (struct c_parse_state) <macro_original_text,
16322 expansion_obstack>: New member.
16323 (macro_original_text, expansion_obstack): Remove globals.
16324 (scan_macro_expansion, scanning_macro_expansion)
16325 (finished_macro_expansion): Update.
16326 (scan_macro_cleanup): Remove.
16327 (yylex, c_parse): Update.
16328
16329 2019-01-06 Tom Tromey <tom@tromey.com>
16330
16331 * c-exp.y (struct c_parse_state) <strings>: New member.
16332 (operator_stoken): Update.
16333
16334 2019-01-06 Tom Tromey <tom@tromey.com>
16335
16336 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16337 (union type_stack_elt) <typelist_val>: Now a pointer to
16338 std::vector.
16339 (type_stack_cleanup): Don't declare.
16340 (push_typelist): Update.
16341 * parse.c (pop_typelist): Return a std::vector.
16342 (push_typelist): Take a std::vector.
16343 (follow_types): Update. Do not free args.
16344 (type_stack_cleanup): Remove.
16345 * c-exp.y (struct c_parse_state): New.
16346 (cpstate): New global.
16347 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16348 (nonempty_typelist): Update.
16349 (func_mod): Create a new vector.
16350 (c_parse): Create a c_parse_state.
16351 (check_parameter_typelist): Do not delete params.
16352 (function_method): Update. Do not delete type_list.
16353
16354 2019-01-06 Tom Tromey <tom@tromey.com>
16355
16356 PR gdb/28155:
16357 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16358 check_typedef.
16359 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16360 (print_return_value): Likewise.
16361
16362 2019-01-05 Tom Tromey <tom@tromey.com>
16363
16364 * contrib/cleanup_check.py: Remove.
16365 * contrib/gcc-with-excheck: Remove.
16366 * contrib/exsummary.py: Remove.
16367 * contrib/excheck.py: Remove.
16368
16369 2019-01-05 Joel Brobecker <brobecker@adacore.com>
16370
16371 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16372 NULL. Initialize tpprev to NULL instead of assigning it
16373 to NULL on the next statement.
16374 * windows-nat.c (windows_delete_thread): Remove check for
16375 main_thread_id before printing thread exit notifications.
16376 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16377 Remove thread ID check against main_thread_id.
16378 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16379 windows_delete_thread.
16380 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16381
16382 2019-01-04 Tom Tromey <tom@tromey.com>
16383
16384 * compile/compile.c (_initialize_compile): Use upper case for
16385 metasyntactic variables.
16386 * symmisc.c (_initialize_symmisc): Use upper case for
16387 metasyntactic variables.
16388 * psymtab.c (_initialize_psymtab): Use upper case for
16389 metasyntactic variables.
16390 * demangle.c (demangle_command): Use upper case for metasyntactic
16391 variables.
16392 (_initialize_demangler): Likewise.
16393 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16394 variables.
16395
16396 2019-01-03 Tom Tromey <tom@tromey.com>
16397
16398 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16399
16400 2019-01-03 Tom Tromey <tom@tromey.com>
16401
16402 * python/py-symtab.c (salpy_str): Update.
16403 (struct salpy_sal_object) <symtab>: Now a PyObject.
16404 (salpy_dealloc): Update.
16405 (del_objfile_sal): Use gdbpy_ref.
16406
16407 2019-01-03 Tom Tromey <tom@tromey.com>
16408
16409 * python/py-type.c (convert_field): Use new_reference. Return
16410 gdbpy_ref.
16411 (make_fielditem): Return gdbpy_ref.
16412 (typy_fields): Update.
16413 (typy_getitem): Update.
16414 (field_name): Return gdbpy_ref. Use new_reference.
16415 (typy_iterator_iternext): Update.
16416
16417 2019-01-03 Tom Tromey <tom@tromey.com>
16418
16419 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16420
16421 2019-01-03 Tom Tromey <tom@tromey.com>
16422
16423 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16424 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16425 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16426 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16427 (pspy_set_type_printers): Likewise.
16428 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16429 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16430 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16431 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16432 (objfpy_set_type_printers): Likewise.
16433
16434 2019-01-03 Tom Tromey <tom@tromey.com>
16435
16436 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16437 (gdbpy_print_stack): Use gdbpy_err_fetch.
16438 * python/python-internal.h (class gdbpy_err_fetch): New class.
16439 (class gdbpy_enter) <m_error_type, m_error_value,
16440 m_error_traceback>: Remove.
16441 <m_error>: New member.
16442 (gdbpy_exception_to_string): Don't declare.
16443 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16444 * python/py-value.c (convert_value_from_python): Use
16445 gdbpy_err_fetch.
16446 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16447 gdbpy_exception_to_string.
16448 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16449 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16450 gdbpy_err_fetch.
16451
16452 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16453
16454 * linux-nat.c (delete_lwp_cleanup): Delete.
16455 (struct lwp_deleter): New struct.
16456 (lwp_info_up): New typedef.
16457 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16458 lwp_info_up.
16459
16460 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16461
16462 * linux-fork.c (class scoped_switch_fork_info): New class.
16463 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16464
16465 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16466
16467 * valops.c (find_overload_match): Remove use of null_cleanup, and
16468 calls to do_cleanups.
16469
16470 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16471
16472 * compile/compile-cplus-types.c
16473 (compile_cplus_instance::decl_name): Handle changes to
16474 cp_func_name.
16475 * cp-support.c (cp_func_name): Update header comment, update
16476 return type.
16477 * cp-support.h (cp_func_name): Update return type in declaration.
16478 * valops.c (find_overload_match): Move temp_func local to top
16479 level of function and change its type. Use temp_func to hold and
16480 delete temporary string obtained from cp_func_name.
16481
16482 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16483
16484 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16485 gdb::char_vector, remove cleanup, and update uses of `msg`.
16486
16487 2019-01-03 Jim Wilson <jimw@sifive.com>
16488
16489 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16490
16491 2019-01-02 Tom Tromey <tom@tromey.com>
16492
16493 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16494 (tdesc_parse_xml): Remove cleanups.
16495 * target-descriptions.h (make_cleanup_free_target_description):
16496 Don't declare.
16497 (target_desc_deleter): New struct.
16498 (target_desc_up): New typedef.
16499 * target-descriptions.c (target_desc_deleter::operator()): Rename
16500 from free_target_description.
16501 (make_cleanup_free_target_description): Remove.
16502
16503 2019-01-02 Tom Tromey <tom@tromey.com>
16504
16505 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16506 constructor, destructor.
16507 (linespec_parser): Remove typedef.
16508 (~linespec_parser): Rename from linespec_parser_delete.
16509 (linespec_lex_to_end, linespec_complete_label)
16510 (linespec_complete): Update.
16511 (decode_line_full): Remove cleanups.
16512 (decode_line_1): Update.
16513
16514 2019-01-02 Tom Tromey <tom@tromey.com>
16515
16516 * python/python-internal.h (inferior_to_inferior_object): Change
16517 return type.
16518 * python/py-exitedevent.c (create_exited_event_object): Update.
16519 * python/py-inferior.c (inferior_to_inferior_object): Return
16520 gdbpy_ref.
16521 (python_new_inferior, python_inferior_deleted)
16522 (thread_to_thread_object, delete_thread_object)
16523 (build_inferior_list, gdbpy_selected_inferior): Update.
16524 * python/py-infthread.c (create_thread_object): Update. Also fail
16525 if inferior_to_inferior_object fails.
16526
16527 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16528
16529 * inferior.h (class inferior) <displaced_step_state>: New field.
16530 * infrun.h (struct displaced_step_state): Move here from
16531 infrun.c. Initialize fields, add constructor.
16532 <inf>: Remove field.
16533 <reset>: New method.
16534 * infrun.c (struct displaced_step_inferior_state): Move to
16535 infrun.h.
16536 (displaced_step_inferior_states): Remove.
16537 (get_displaced_stepping_state): Adust.
16538 (displaced_step_in_progress_any_inferior): Adjust.
16539 (displaced_step_in_progress_thread): Adjust.
16540 (displaced_step_in_progress): Adjust.
16541 (add_displaced_stepping_state): Remove.
16542 (get_displaced_step_closure_by_addr): Adjust.
16543 (remove_displaced_stepping_state): Remove.
16544 (infrun_inferior_exit): Call displaced_step_state.reset.
16545 (use_displaced_stepping): Don't check for NULL.
16546 (displaced_step_prepare_throw): Call
16547 get_displaced_stepping_state.
16548 (displaced_step_fixup): Don't check for NULL.
16549 (prepare_for_detach): Don't check for NULL.
16550
16551 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16552
16553 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16554 in case of call that did not complete.
16555
16556 2019-01-02 Andrey Utkin <autkin@undo.io>
16557
16558 * symfile.c (find_separate_debug_file): Fix search of debug files for
16559 remote debuggee.
16560
16561 2019-01-02 Tom Tromey <tom@tromey.com>
16562
16563 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16564 indentation.
16565 * python/py-frame.c (frapy_older): Remove cast.
16566 (frapy_newer): Likewise.
16567 * python/py-breakpoint.c (local_setattro): Remove cast.
16568 * python/py-arch.c (archpy_name): Remove local variable.
16569 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16570
16571 2019-01-02 Joel Brobecker <brobecker@adacore.com>
16572
16573 * unittests/basic_string_view/element_access/char/empty.cc:
16574 Fix year range in copyright header.
16575
16576 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16577
16578 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16579 Delete.
16580 <operator==>: Update with for removed field.
16581 <hash>: Likewise.
16582 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16583 <isa_features>: ...this.
16584 <abi_features>: New field.
16585 (riscv_isa_flen): Update comment.
16586 (riscv_abi_xlen): New declaration.
16587 (riscv_abi_flen): New declaration.
16588 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16589 isa_features.
16590 (riscv_abi_xlen): New function.
16591 (riscv_isa_flen): Update to get answer from isa_features.
16592 (riscv_abi_flen): New function.
16593 (riscv_has_fp_abi): Update to get answer from abi_features.
16594 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16595 xlen and flen.
16596 (riscv_call_info) <xlen, flen>: Update comment.
16597 (riscv_call_arg_struct): Remove invalid assertions
16598 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16599 is removed.
16600 (riscv_gdbarch_init): Gather isa features and abi features
16601 separately, ensure both match on the gdbarch when reusing an old
16602 gdbarch. Relax an error check to allow 32-bit abi float to run on
16603 a target with 64-bit float hardware.
16604
16605 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16606
16607 * source.c (search_command_helper): Stop reverse search
16608 when line 1 has been searched.
16609
16610 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16611
16612 * record-full.c (record_full_base_target::close): Rewrite
16613 record_full_core_buf_list free logic.
16614
16615 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16616
16617 * break-catch-syscall.c (print_one_catch_syscall): xfree
16618 the last text.
16619
16620 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16621
16622 * top.c (print_gdb_version): Update Copyright year in version
16623 message.
16624
16625 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16626
16627 Update copyright year range in all GDB files.
16628
16629 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16630
16631 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16632
16633 For older changes see ChangeLog-2018.
16634 \f
16635 Local Variables:
16636 mode: change-log
16637 left-margin: 8
16638 fill-column: 74
16639 version-control: never
16640 coding: utf-8
16641 End:
16642
This page took 0.386924 seconds and 4 git commands to generate.